Rolling out r212757
[WebKit-https.git] / Tools / ChangeLog
1 2017-02-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2
3         [GTK] Do not use g_return_if_fail in EventSenderProxy::continuousMouseScrollBy
4         https://bugs.webkit.org/show_bug.cgi?id=168721
5
6         Reviewed by Michael Catanzaro.
7
8         Use WTFLogAlways instead. It's still shown in stderr, but it won't crash if we ever run tests with fatal
9         criticals.
10
11         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
12         (WTR::EventSenderProxy::continuousMouseScrollBy):
13
14 2017-02-21  Youenn Fablet  <youenn@apple.com>
15
16         [WebRTC][Mac] Activate libwebrtc
17         https://bugs.webkit.org/show_bug.cgi?id=167293
18         <rdar://problem/30401864>
19
20         Reviewed by Alex Christensen.
21
22         Fixing paths to allow loading libwebrtc.dylib successfully.
23
24         * Scripts/build-webkit:
25         * Scripts/webkitdirs.pm:
26         (setupMacWebKitEnvironment):
27         (setupIOSWebKitEnvironment):
28         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
29
30 2017-02-21  Saam Barati  <sbarati@apple.com>
31
32         Add the Briggs optimistic allocator to run on ARM64
33         https://bugs.webkit.org/show_bug.cgi?id=168454
34
35         Reviewed by Filip Pizlo.
36
37         * Scripts/run-jsc-stress-tests:
38
39 2017-02-20  Filip Pizlo  <fpizlo@apple.com>
40
41         The collector thread should only start when the mutator doesn't have heap access
42         https://bugs.webkit.org/show_bug.cgi?id=167737
43
44         Reviewed by Keith Miller.
45         
46         Make more tests collect continuously.
47
48         * Scripts/run-jsc-stress-tests:
49
50 2017-02-20  Simon Fraser  <simon.fraser@apple.com>
51
52         Add support to PlatformCALayer/GraphicsLayerCA for subpixel-antialiased text, with a Setting and a MiniBrowser switch
53         https://bugs.webkit.org/show_bug.cgi?id=168620
54         <rdar://problem/30617772>
55
56         Reviewed by Tim Horton.
57         
58         Add a setting that allows one to toggle subpixel-antialiased layer text on and off.
59
60         * DumpRenderTree/mac/DumpRenderTree.mm:
61         (resetWebPreferencesToConsistentValues):
62         * MiniBrowser/mac/SettingsController.h:
63         * MiniBrowser/mac/SettingsController.m:
64         (-[SettingsController _populateMenu]):
65         (-[SettingsController validateMenuItem:]):
66         (-[SettingsController toggleSubpixelAntialiasedLayerTextEnabled:]):
67         (-[SettingsController subpixelAntialiasedLayerTextEnabled]):
68         * MiniBrowser/mac/WK1BrowserWindowController.m:
69         (-[WK1BrowserWindowController didChangeSettings]):
70         * MiniBrowser/mac/WK2BrowserWindowController.m:
71         (-[WK2BrowserWindowController didChangeSettings]):
72         * WebKitTestRunner/TestController.cpp:
73         (WTR::TestController::resetPreferencesToConsistentValues):
74
75 2017-02-21  Jonathan Bedard  <jbedard@apple.com>
76
77         webkitpy: Refactor Device class
78         https://bugs.webkit.org/show_bug.cgi?id=168332
79
80         Reviewed by Alexey Proskuryakov.
81
82         Separate the more specific SimulatedDevice from the abstract
83         idea of a device.
84
85         * Scripts/webkitpy/xcode/device.py: Added.
86         (Device):  Base device class.
87         (Device.__init__): Initialize _host, name and udid.
88         (Device.install_app): Function declaration.
89         (Device.launch_app): Ditto.
90         (Device.__eq__): Compare two devices by udid.
91         (Device.__ne__): Ditto.
92         (Device.__repr__): Return device name and udid in formatted string.
93         * Scripts/webkitpy/xcode/simulated_device.py: Copied from Tools/Scripts/webkitpy/xcode/simulator.py.
94         (SimulatedDevice):
95         (SimulatedDevice.__init__): Call Device.__init__ first.
96         (SimulatedDevice.delete): Device -> SimulatedDevice.
97         (SimulatedDevice.reset): Ditto.
98         (SimulatedDevice.__eq__): Moved to device.py.
99         (SimulatedDevice.__ne__): Ditto.
100         (SimulatedDevice.__repr__): Call Device __repr__ first.
101         (DeviceType): Kept in Scripts/webkitpy/xcode/simulator.py.
102         (Runtime): Kept in Scripts/webkitpy/xcode/simulator.py.
103         (Device): Renamed SimulatedDevice.
104         (Simulator): Kept in Scripts/webkitpy/xcode/simulator.py.
105         * Scripts/webkitpy/xcode/simulator.py:
106         (Simulator): Define Simulator.Device class as None.
107         (Simulator.__init__): Import SimulatedDevice as Simulator.Device.
108         (Simulator.delete_device): Use Simulator.Device.
109         (Simulator.reset_device): Ditto.
110         (Simulator._parse_devices): Ditto.
111         (Simulator.lookup_or_create_device): Make 
112         (Device): Moved to simulated_device as SimulatedDevice.
113
114 2017-02-21  JF Bastien  <jfbastien@apple.com>
115
116         Fix cmake build
117         https://bugs.webkit.org/show_bug.cgi?id=168665
118
119         Reviewed by Mark Lam.
120
121         It was broken by r212555 and r212681.
122
123         * DumpRenderTree/PlatformMac.cmake:
124
125 2017-02-21  Alexey Proskuryakov  <ap@apple.com>
126
127         Improve bot watcher's dashboard performance
128         https://bugs.webkit.org/show_bug.cgi?id=168624
129         <rdar://problem/30190109>
130
131         Reviewed by Daniel Bates.
132
133         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
134         There was an unnecessary linear complexity algorithm in indexOfRevision().
135
136 2017-02-21  Alex Christensen  <achristensen@webkit.org>
137
138         Unreviewed, rolling out r212699.
139
140         Internal build not ready
141
142         Reverted changeset:
143
144         "[WebRTC][Mac] Activate libwebrtc"
145         https://bugs.webkit.org/show_bug.cgi?id=167293
146         http://trac.webkit.org/changeset/212699
147
148 2017-02-20  Carlos Garcia Campos  <cgarcia@igalia.com>
149
150         Remove ENABLE_THREADED_COMPOSITOR build option
151         https://bugs.webkit.org/show_bug.cgi?id=168606
152
153         Reviewed by Michael Catanzaro.
154
155         * Scripts/webkitperl/FeatureList.pm:
156
157 2017-02-20  Youenn Fablet  <youenn@apple.com>
158
159         [WebRTC][Mac] Activate libwebrtc
160         https://bugs.webkit.org/show_bug.cgi?id=167293
161         <rdar://problem/30401864>
162
163         Reviewed by Alex Christensen.
164
165         Fixing paths to allow loading libwebrtc.dylib successfully.
166
167         * Scripts/build-webkit:
168         * Scripts/webkitdirs.pm:
169         (setupMacWebKitEnvironment):
170         (setupIOSWebKitEnvironment):
171
172 2017-02-20  Ryan Haddad  <ryanhaddad@apple.com>
173
174         Unreviewed, rolling out r212685.
175
176         This change broke the 32-bit Sierra build.
177
178         Reverted changeset:
179
180         "Resource Load Statistics: Add alternate classification
181         method"
182         https://bugs.webkit.org/show_bug.cgi?id=168347
183         http://trac.webkit.org/changeset/212685
184
185 2017-02-20  John Wilander  <wilander@apple.com>
186
187         Resource Load Statistics: Add alternate classification method
188         https://bugs.webkit.org/show_bug.cgi?id=168347
189         <rdar://problem/30352793>
190
191         Reviewed by Alex Christensen.
192
193         Added three testRunner functions to facilitate layout tests:
194         - setStatisticsSubframeUnderTopFrameOrigin()
195         - setStatisticsSubresourceUnderTopFrameOrigin()
196         - setStatisticsSubresourceUniqueRedirectTo()
197
198         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
199         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
200         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
201         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
202         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
203         * WebKitTestRunner/InjectedBundle/TestRunner.h:
204         * WebKitTestRunner/TestController.cpp:
205         (WTR::TestController::setStatisticsSubframeUnderTopFrameOrigin):
206         (WTR::TestController::setStatisticsSubresourceUnderTopFrameOrigin):
207         (WTR::TestController::setStatisticsSubresourceUniqueRedirectTo):
208         * WebKitTestRunner/TestController.h:
209         * WebKitTestRunner/TestInvocation.cpp:
210         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
211
212 2017-02-20  Anders Carlsson  <andersca@apple.com>
213
214         Use the new drag code path when dragging links
215         https://bugs.webkit.org/show_bug.cgi?id=168612
216
217         Reviewed by Tim Horton.
218
219         If a type is not dynamic, just use the static UTI.
220
221         * DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
222         (-[LocalPasteboard writeObjects:]):
223
224 2017-02-17  Anders Carlsson  <andersca@apple.com>
225
226         Add a new drag code path and use it for dragging plain text
227         https://bugs.webkit.org/show_bug.cgi?id=168534
228
229         Reviewed by Geoffrey Garen.
230
231         Update the testing infrastructure to handle NSDraggingSession.
232
233         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
234         * DumpRenderTree/mac/DumpRenderTreePasteboard.mm: Renamed from Tools/DumpRenderTree/mac/DumpRenderTreePasteboard.m.
235         (-[LocalPasteboard writeObjects:]):
236         Implement this in terms of the legacy pasteboard API.
237
238         * DumpRenderTree/mac/EventSendingController.mm:
239         (drt_WebHTMLView_beginDraggingSessionWithItemsEventSource):
240         (+[EventSendingController initialize]):
241         Swizzle the drag method instead of adding a delegate method (like the old code does).
242
243 2017-02-20  Florian Bruhin  <git@the-compiler.org>
244
245         Handle EINTR during webkitpy server process select()
246         https://bugs.webkit.org/show_bug.cgi?id=168361
247
248         Reviewed by Michael Catanzaro.
249
250         Otherwise, on my machine, resizing the terminal run-webkit-tests is running in
251         makes it die.
252
253         * Scripts/webkitpy/port/server_process.py:
254         (ServerProcess._wait_for_data_and_update_buffers_using_select):
255
256 2017-02-20  Carlos Garcia Campos  <cgarcia@igalia.com>
257
258         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/default-menu.
259
260         It can happen that the window onload event is dispatched after the load finished is received in the UI
261         process. Move the script to select the text to the body instead of using a window onload handler.
262
263         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
264         (testContextMenuDefaultMenu):
265
266 2017-02-20  Manuel Rego Casasnovas  <rego@igalia.com>
267
268         [css-grid] Remove compilation flag ENABLE_CSS_GRID_LAYOUT
269         https://bugs.webkit.org/show_bug.cgi?id=167693
270
271         Reviewed by Sergio Villar Senin.
272
273         * Scripts/webkitperl/FeatureList.pm:
274         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
275         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
276         (TestWebKitAPI::computeNumberOfTracks):
277         (TestWebKitAPI::TEST):
278         * TestWebKitAPI/Tests/WebCore/GridPosition.cpp:
279         (TestWebKitAPI::TEST):
280
281 2017-02-19  Commit Queue  <commit-queue@webkit.org>
282
283         Unreviewed, rolling out r212466.
284         https://bugs.webkit.org/show_bug.cgi?id=168577
285
286         causes crashes on AArch64 on linux, maybe it's causing crashes
287         on iOS too (Requested by pizlo on #webkit).
288
289         Reverted changeset:
290
291         "The collector thread should only start when the mutator
292         doesn't have heap access"
293         https://bugs.webkit.org/show_bug.cgi?id=167737
294         http://trac.webkit.org/changeset/212466
295
296 2017-02-17  Aakash Jain  <aakash_jain@apple.com>
297
298         Fix failure from r212579.
299
300         Unreviewed build-fix.
301
302         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
303         (CheckPatchRelevance._changes_are_relevant): Return true for all groups others than jsc for now.
304
305 2017-02-17  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
306
307         EWS should run JavaScriptCore tests
308         https://bugs.webkit.org/show_bug.cgi?id=162458
309
310         Reviewed by Alexey Proskuryakov.
311
312         * QueueStatusServer/config/queues.py: Add jsc-ews queue.
313         * QueueStatusServer/model/queuestatus.py:
314         (QueueStatus.did_skip): Returns whether patch was skipped, based on status.
315         * QueueStatusServer/handlers/statusbubble.py:
316         (StatusBubble._should_show_bubble_for): Add logic to hide jsc-ews bubble if the patch does not touch jsc.
317         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
318         (MockSCM.__init__): Add _mockChangedFiles variable.
319         (MockSCM.changed_files): Change to use _mockChangedFiles variables.
320         * Scripts/webkitpy/common/config/ews.json: Add config info for JSC EWS.
321         * Scripts/webkitpy/common/config/ports.py: Add support for JSC EWS in Mac Port.
322         (DeprecatedPort._append_build_style_flag): Helper function to append build_style to a command.
323         (DeprecatedPort.build_jsc_command): Added - command to build JSC only (quicker than building all of WebKit).
324         (DeprecatedPort.run_javascriptcore_tests_command): Allow JSC EWS to only run JSC tests.
325         (MacPort.run_webkit_tests_command): Check for JSC.
326         * Scripts/webkitpy/common/config/ports_mock.py:
327         (MockPort.run_javascriptcore_tests_command): Add build_style argument.
328         * Scripts/webkitpy/common/config/ports_unittest.py:
329         (DeprecatedPortTest.test_mac_port): Add unit tests for build-jsc shell command.
330         * Scripts/webkitpy/common/net/abstracttestresults.py: Added.
331         (AbstractTestResults): Abstract superclass of JSCTestResults and JSCTestResults.
332         (AbstractTestResults.test_results): Stub.
333         (AbstractTestResults.failing_tests): Stub.
334         (AbstractTestResults.did_exceed_test_failure_limit): Stub.
335         * Scripts/webkitpy/common/net/jsctestresults.py: Added.
336         (JSCTestResults): Added.
337         (JSCTestResults.intersection): Return a JSCTestResults object with failures common to both input objects.
338         (JSCTestResults.results_from_string): Use json library to parse results.
339         (JSCTestResults.__init__): Initialize members.
340         (JSCTestResults.equals): This enables unit testing.
341         (JSCTestResults.is_subset): Checks if one set of failures is a subset of another.
342         (JSCTestResults.all_passed): Getter.
343         (JSCTestResults.failing_tests): Getter.
344         (JSCTestResults.did_exceed_test_failure_limit): Getter.
345         * Scripts/webkitpy/common/net/jsctestresults_unittest.py: Added.
346         (JSCTestResultsTest): Class to test JSCTestResults.
347         (JSCTestResultsTest.test_results_from_string): Tests parsing.
348         (JSCTestResultsTest.test_intersection_api_tests): Unit test for intersection() class method.
349         (JSCTestResultsTest.test_intersection_stress_tests): Unit test for intersection() class method.
350         (JSCTestResultsTest.test_intersection_general_case): Unit test for intersection() class method.
351         * Scripts/webkitpy/port/base.py:
352         (Port.jsc_results_directory): Returns the directory for the JSC test results JSON file.
353         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
354         (EarlyWarningSystemTask.run): Add check_patch_relevance step.
355         * Scripts/webkitpy/tool/bot/jscews_unittest.py: Added.
356         (MockPatchAnalysisTask): Mocked-out version of PatchAnalysisTask that doesn't run commands.
357         (MockPatchAnalysisTask.__init__): Sets attributes.
358         (MockPatchAnalysisTask._test): Override to not run command.
359         (MockPatchAnalysisTask._build_and_test_without_patch): Override to not run command.
360         (MockPatchAnalysisTask.validate): Assume mocked patch is valid for purposes of testing retry logic.
361         (MockPatchAnalysisTask.test_run_count): Specific to the mocked version, to test retry logic.
362         (MockJSCEarlyWarningSystem): Mocked-out version of AbstarctEarlyWarningSystem so we can provide test results.
363         (MockJSCEarlyWarningSystem.__init__): Sets attributes, also sets group to jsc.
364         (MockJSCEarlyWarningSystem.test_results): Returns test results provided by us, instead of using a JSON reader.
365         (JSCEarlyWarningSystemTest): Class to test retry logic in below situations.
366         (JSCEarlyWarningSystemTest._create_task): Helper function to abstract out common code.
367         (JSCEarlyWarningSystemTest._results_indicate_all_passed): False if input is None or has failures, else True.
368         (JSCEarlyWarningSystemTest.test_success_case): Clean patch on clean tree.
369         (JSCEarlyWarningSystemTest.test_test_failure): Failed patch on clean tree.
370         (JSCEarlyWarningSystemTest.test_fix): Patch that fixes all tree redness.
371         (JSCEarlyWarningSystemTest.test_ineffective_patch): Patch that has same failures as tree.
372         (JSCEarlyWarningSystemTest.test_partially_effective_patch): Patch fixes some failures but adds no new failures.
373         (JSCEarlyWarningSystemTest.test_different_test_failures_in_patch_and_tree): Patch has some failures not in tree.
374         (JSCEarlyWarningSystemTest.test_first_results_could_not_be_read): Patch results not readable.
375         (JSCEarlyWarningSystemTest.test_second_results_could_not_be_read): Patch results not readable on second run.
376         (JSCEarlyWarningSystemTest.test_clean_results_could_not_be_read): Results from clean tree not readable.
377         (JSCEarlyWarningSystemTest.test_flaky_results_on_clean_tree_pass): Patch has one flake and no failures.
378         (JSCEarlyWarningSystemTest.test_flaky_results_on_clean_tree_pass_v2): Patch has one flake and no failures.
379         (JSCEarlyWarningSystemTest.test_flaky_results_on_clean_tree_failure): Patch has flakes and failed tests.
380         (JSCEarlyWarningSystemTest.test_flaky_results_on_red_tree_pass): Patch has same failures as tree, plus a flake.
381         * Scripts/webkitpy/tool/bot/jsctestresultsreader.py: Added.
382         (JSCTestResultsReader): Reads results file.
383         (JSCTestResultsReader.__init__): Sets attributes.
384         (JSCTestResultsReader._read_file_contents): Reads file.
385         (JSCTestResultsReader.results): Reads the results file and returns a JSCTestResults object.
386         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
387         (PatchIsNotApplicable): Exception for when patch doesn't have relevant changes.
388         (PatchAnalysisTask._check_patch_relevance): Added.
389         (PatchAnalysisTask._build): Check for JSC.
390         (PatchAnalysisTask._build_without_patch): Check for JSC.
391         (PatchAnalysisTask._test): Check for JSC.
392         (PatchAnalysisTask._build_and_test_without_patch): Check for JSC.
393         (PatchAnalysisTask._retry_jsc_tests): Retry logic for JSC EWS.
394         (PatchAnalysisTask._retry_layout_tests): Retry logic for layout tests EWS.
395         (PatchAnalysisTask._test_patch): Add retry logic for JSC.
396         * Scripts/webkitpy/tool/commands/download.py:
397         (CheckPatchRelevance): Add check-patch-relevance command.
398         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
399         (AbstractEarlyWarningSystem._create_task): Abstract out to enable mocking.
400         (AbstractEarlyWarningSystem.begin_work_queue): Use JSCTestResultsReader not LayoutTestResultsReader in JSC EWS.
401         (AbstractEarlyWarningSystem.review_patch): Handle PatchIsApplicable.
402         (AbstractEarlyWarningSystem.test_results): _layout_test_results_reader -> _test_results_reader.
403         (AbstractEarlyWarningSystem.archive_last_test_results): _layout_test_results_reader -> _test_results_reader.
404         (AbstractEarlyWarningSystem.group): This attribute determines the type of EWS (eg. JSC).
405         (AbstractEarlyWarningSystem.load_ews_classes): Add _group, and make classes of type cls to enable mocking.
406         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
407         (TestEWS): Sample layout test EWS class used for unit testing.
408         (TestJSCEWS): Sample JSC EWS class used for unit testing.
409         (AbstractEarlyWarningSystemTest.test_failing_tests_message.TestEWS): Add _group.
410         (AbstractEarlyWarningSystemTest.test_failing_jsc_tests_message.TestEWS): Added test for jsc failures message.
411         (AbstractEarlyWarningSystemTest): Add _group variable.
412         (EarlyWarningSystemTest._default_expected_logs): Add check-patch-relevance step, inconclusive logs, and group.
413         (EarlyWarningSystemTest._test_ews): Add logs_are_conclusive option to pass through to default_expected_logs().
414         (EarlyWarningSystemTest.test_inconclusive_test_results): Test not removing patch from queue if not conclusive.
415         (MockAbstractEarlyWarningSystemForInconclusiveJSCResults): Added.
416         (MockAbstractEarlyWarningSystemForInconclusiveJSCResults._test_patch): Simulates running tests but not getting a conclusive result.
417         (MockEarlyWarningSystemTaskForInconclusiveJSCResults): Added.
418         (MockEarlyWarningSystemTaskForInconclusiveJSCResults._create_task): Use MockEarlyWarningSystemTask (not EarlyWarningSystemTask).
419         * Scripts/webkitpy/tool/steps/__init__.py: Add CheckPatchRelevance import.
420         * Scripts/webkitpy/tool/steps/build.py:
421         (Build.options): Check for JSC.
422         (Build.build): Check for JSC.
423         (Build.run): Check for JSC.
424         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py: Added.
425         (CheckPatchRelevance): Added.
426         (CheckPatchRelevance._does_contain_change_in_paths): Abstract function to perform regex matching.
427         (CheckPatchRelevance.run): Check if changed files in patch belong in certain folders.
428         * Scripts/webkitpy/tool/steps/options.py:
429         (Options): Add --group command line option.
430         * Scripts/webkitpy/tool/steps/runtests.py:
431         (RunTests.options): Add group.
432         (RunTests.run): Check for JSC.
433         (RunTests._run_webkit_tests): Check for JSC.
434         (RunTests): Add _group attribute.
435         (RunTests._run_javascriptcore_tests): New.
436         * Scripts/webkitpy/tool/steps/steps_unittest.py: Unit tests.
437
438 2017-02-17  Aakash Jain  <aakash_jain@apple.com>
439
440         Fix tools that were broken by Efl removal
441         https://bugs.webkit.org/show_bug.cgi?id=168496
442
443         Reviewed by Alexey Proskuryakov.
444
445         * QueueStatusServer/config/queues.py:
446         * Scripts/webkitpy/common/config/ews.json:
447         * TestResultServer/static-dashboards/builders.jsonp:
448         * TestResultServer/static-dashboards/flakiness_dashboard.js:
449         * TestResultServer/static-dashboards/loader_unittests.js:
450
451 2017-02-16  Lucas Forschler  <lforschler@apple.com>
452
453         https://bugs.webkit.org/show_bug.cgi?id=168442
454         Move the SVN checkout from http -> https.
455         Update unit tests.
456
457         Reviewed by Alexey Proskuryakov.
458
459         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
460         (CheckOutSource.__init__):
461         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
462         (SVNMirrorTest.get_SVNMirrorFromConfig):
463         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
464
465 2017-02-16  Commit Queue  <commit-queue@webkit.org>
466
467         Unreviewed, rolling out r212514.
468         https://bugs.webkit.org/show_bug.cgi?id=168489
469
470         broke test runner (Requested by alexchristensen on #webkit).
471
472         Reverted changeset:
473
474         "Remove EFL-specific files in Tools."
475         http://trac.webkit.org/changeset/212514
476
477 2017-02-16  Alex Christensen  <achristensen@webkit.org>
478
479         Remove EFL-specific files in Tools.
480
481         Rubber-stamped by Anders Carlsson.
482
483         * ImageDiff/efl: Removed.
484         * ImageDiff/efl/ImageDiff.cpp: Removed.
485         * MiniBrowser/efl: Removed.
486         * MiniBrowser/efl/CMakeLists.txt: Removed.
487         * MiniBrowser/efl/main.c: Removed.
488         * Scripts/run-efl-tests: Removed.
489         * Scripts/update-webkitefl-libs: Removed.
490         * Scripts/webkitpy/port/efl.py: Removed.
491         * Scripts/webkitpy/port/efl_unittest.py: Removed.
492         * TestWebKitAPI/Tests/WebKit2/efl: Removed.
493         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp: Removed.
494         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp: Removed.
495         * TestWebKitAPI/Tests/WebKit2/efl/WKViewScrollTo.cpp: Removed.
496         * TestWebKitAPI/Tests/WebKit2/efl/scrollTo.html: Removed.
497         * TestWebKitAPI/efl: Removed.
498         * TestWebKitAPI/efl/InjectedBundleController.cpp: Removed.
499         * TestWebKitAPI/efl/PlatformUtilities.cpp: Removed.
500         * TestWebKitAPI/efl/PlatformWebView.cpp: Removed.
501         * TestWebKitAPI/efl/main.cpp: Removed.
502         * WebKitTestRunner/InjectedBundle/efl: Removed.
503         * WebKitTestRunner/InjectedBundle/efl/ActivateFontsEfl.cpp: Removed.
504         * WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp: Removed.
505         * WebKitTestRunner/InjectedBundle/efl/FontManagement.h: Removed.
506         * WebKitTestRunner/InjectedBundle/efl/InjectedBundleEfl.cpp: Removed.
507         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp: Removed.
508         * WebKitTestRunner/efl: Removed.
509         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp: Removed.
510         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp: Removed.
511         * WebKitTestRunner/efl/TestControllerEfl.cpp: Removed.
512         * WebKitTestRunner/efl/main.cpp: Removed.
513         * efl: Removed.
514         * efl/install-dependencies: Removed.
515         * efl/jhbuild-optional.modules: Removed.
516         * efl/jhbuild.modules: Removed.
517         * efl/jhbuildrc: Removed.
518         * efl/patches: Removed.
519         * efl/patches/evas-fix-build-with-giflib5.patch: Removed.
520         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Removed.
521         * efl/patches/gst-libav.patch: Removed.
522         * efl/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Removed.
523         * efl/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
524         * efl/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
525         * efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Removed.
526
527 2017-02-16  Myles C. Maxfield  <mmaxfield@apple.com>
528
529         font-weight in @font-face can cause a font to be downloaded even when it's not used
530         https://bugs.webkit.org/show_bug.cgi?id=168114
531         <rdar://problem/30301317>
532
533         Reviewed by Darin Adler.
534
535         LastResort needs to be usable in tests.
536
537         * DumpRenderTree/mac/DumpRenderTree.mm:
538         (allowedFontFamilySet):
539         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
540         (WTR::allowedFontFamilySet):
541         * WebKitTestRunner/mac/TestControllerMac.mm:
542         (WTR::allowedFontFamilySet):
543
544 2017-02-16  Alex Christensen  <achristensen@webkit.org>
545
546         Remove old URL parser
547         https://bugs.webkit.org/show_bug.cgi?id=168483
548
549         Reviewed by Tim Horton.
550
551         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
552         (TestWebKitAPI::checkURL):
553         (TestWebKitAPI::checkRelativeURL):
554         (TestWebKitAPI::checkURLDifferences):
555         (TestWebKitAPI::checkRelativeURLDifferences):
556
557 2017-02-16  Wenson Hsieh  <wenson_hsieh@apple.com>
558
559         [WK2] Add additional test infrastructure and unit tests for data interaction
560         https://bugs.webkit.org/show_bug.cgi?id=168439
561         <rdar://problem/30557942>
562
563         Reviewed by Tim Horton.
564
565         Adds test support for additional data interaction scenarios that we currently cannot test, and also adds 7 new
566         test cases to DataInteractionTests. Most of the changes here refactor and augment DataInteractionSimulator to
567         support data interaction from  See per-method descriptions below for more details.
568
569         * Configurations/TestWebKitAPI.xcconfig:
570
571         Add MobileCoreServices to the list of additional frameworks to link against on iOS.
572
573         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
574
575         Add a new build phase that copies additional resources from WebKitAdditions/Resources/TestWebKitAPI and dumps
576         them into TestWebKitAPI.resources/ in the build directory, if the WebKitAdditions folder exists.
577
578         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
579         (-[TestWKWebView editorContainsImageElement]):
580         (-[TestWKWebView editorValue]):
581
582         New helper methods for querying information from the "editor" element in a test page.
583
584         (TestWebKitAPI::TEST):
585         (TestWebKitAPI::runTestsExpectingToObserveEvents): Deleted.
586
587         Moves logic for capturing events during a simulated data interaction run from the test file to
588         DataInteractionSimulator. See -[DataInteractionSimulator observedEventNames].
589
590         * TestWebKitAPI/cocoa/TestWKWebView.h:
591         * TestWebKitAPI/cocoa/TestWKWebView.mm:
592         (-[TestMessageHandler removeMessage:]):
593         (-[TestWKWebView clearMessageHandlers:]):
594
595         Add the ability to clear message handlers from the TestWKWebView.
596
597         * TestWebKitAPI/ios/DataInteractionSimulator.h:
598         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
599         (dataInteractionEventNames):
600         (-[DataInteractionSimulator initWithWebView:]):
601         (-[DataInteractionSimulator _resetSimulatedState]):
602
603         Moves logic to clear test harness state from any previous runs into a helper. Called at the beginning when
604         simulating data interaction.
605
606         (-[DataInteractionSimulator observedEventNames]):
607
608         Returns a list of the names of events relevant to data interaction that were observed over the course of the
609         most recent run.
610
611         (-[DataInteractionSimulator runFrom:to:]):
612
613         Changes -run to -runFrom:to:, which takes window-relative start and end locations. This allows the test harness
614         to run the same data interaction for multiple simulated gestures.
615
616         (-[DataInteractionSimulator _advanceProgress]):
617         (-[DataInteractionSimulator _finishDataInteraction]):
618         (-[DataInteractionSimulator externalItemProvider]):
619         (-[DataInteractionSimulator setExternalItemProvider:]):
620
621         Adds the -externalItemProvider property to DataInteractionSimulator. Setting this skips the gesture recognition
622         phase of a test run.
623
624         (-[DataInteractionSimulator webViewDidPerformDataInteractionControllerOperation:]):
625         (-[DataInteractionSimulator webView:beginDataInteractionWithSourceIndex:gestureRecognizer:]):
626         (-[DataInteractionSimulator webViewDidSendDataInteractionStartRequest:]):
627         (-[DataInteractionSimulator webView:didReceiveDataInteractionStartResponse:]):
628
629         While a request to start data interaction is in flight, put the remainder of the test on hold until the web
630         process returns. Then continue the test by scheduling a progress advance call. This addresses a race condition
631         wherein the the web process might take longer than usual to process the request to start data interaction, and
632         in the meantime, DataInteractionSimulator would end up completing the rest of the test before a response from
633         the web process is received, which then causes no simulated delegate methods to be fired.
634
635         (-[DataInteractionSimulator initWithWebView:startLocation:endLocation:]): Deleted.
636         (-[DataInteractionSimulator run]): Deleted.
637
638 2017-02-16  Wenson Hsieh  <wenson_hsieh@apple.com>
639
640         Remove unused test pages in TestWebKitAPI
641         https://bugs.webkit.org/show_bug.cgi?id=168462
642
643         Reviewed by Anders Carlsson.
644
645         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
646         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Removed.
647         * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Removed.
648         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Removed.
649         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Removed.
650         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Removed.
651
652 2017-02-16  Alex Christensen  <achristensen@webkit.org>
653
654         Special URLs without a host are invalid
655         https://bugs.webkit.org/show_bug.cgi?id=168461
656
657         Reviewed by Tim Horton.
658
659         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
660         (TestWebKitAPI::TEST_F):
661
662 2017-02-10  Filip Pizlo  <fpizlo@apple.com>
663
664         The collector thread should only start when the mutator doesn't have heap access
665         https://bugs.webkit.org/show_bug.cgi?id=167737
666
667         Reviewed by Keith Miller.
668         
669         Make more tests collect continuously.
670
671         * Scripts/run-jsc-stress-tests:
672
673 2017-02-16  Tim Horton  <timothy_horton@apple.com>
674
675         WKWebView inside a UICollectionView flashes when items are inserted above it
676         https://bugs.webkit.org/show_bug.cgi?id=168376
677         <rdar://problem/29322051>
678
679         Reviewed by Simon Fraser.
680
681         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
682         (-[TestRunnerWKWebView _setStableStateOverride:]):
683         Update the one external caller of this internal method...
684
685         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
686         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
687         * DumpRenderTree/mac/UIScriptControllerMac.mm:
688         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
689         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
690         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
691         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
692         * TestRunnerShared/UIScriptContext/UIScriptController.h:
693         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
694         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
695         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
696         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
697         Expose doAfterVisibleContentRectUpdate to DRT and WKTR. It is called
698         back after we dispatch a visible content rect update from the UI process
699         to the Web Content process, so any messages sent from the block will arrive
700         after the visible content rect update.
701
702 2017-02-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
703
704         [GTK] Add two new buildbots that build-only test on Debian stable and Ubuntu LTS.
705         https://bugs.webkit.org/show_bug.cgi?id=168321
706
707         This bots should be added to the trunk build scheduler.
708         Unreviewed fix after r212429.
709
710         * BuildSlaveSupport/build.webkit.org-config/config.json:
711
712 2017-02-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
713
714         [GTK] Add two new buildbots that build-only test on Debian stable and Ubuntu LTS
715         https://bugs.webkit.org/show_bug.cgi?id=168321
716
717         Reviewed by Michael Catanzaro.
718
719         The additionalArgument --default-cmake-features is used both to
720         skip the JHBuild (InstallGtkDependencies) build step and to build
721         with the default features from the CMake config.
722
723         * BuildSlaveSupport/build.webkit.org-config/config.json:
724         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
725         (Factory.__init__):
726         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
727
728 2017-02-15  Lucas Forschler  <lforschler@apple.com>
729
730         https://bugs.webkit.org/show_bug.cgi?id=168386
731         Remove EFL from build.webkit.org
732
733         Reviewed by Alex Christensen
734
735         * BuildSlaveSupport/build.webkit.org-config/config.json:
736         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
737         (DeleteStaleBuildFiles.start):
738         (appendCustomBuildFlags):
739         (RunWebKitTests.start):
740         (RunBuiltinsTests):
741         (Factory.__init__):
742         (TestFactory.__init__):
743         (loadBuilderConfig):
744         (InstallEflDependencies): Deleted.
745         (RunEflAPITests): Deleted.
746         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
747         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
748         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
749         (BubbleQueueServer):
750         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
751         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
752         (Analyzer.prototype._triggeringQueue):
753         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
754         (WebKitBuildbot):
755         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
756         (table.queue-grid tr.platform.linux-efl img.logo): Deleted.
757         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
758         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
759         (_should_file_trigger_build):
760
761 2017-02-15  Alex Christensen  <achristensen@webkit.org>
762
763         Unreviewed, rolling out r212169.
764
765         Broke iOS WebInspector
766
767         Reverted changeset:
768
769         "WebInspector: refactor RemoteInspector to move cocoa specific
770         code to their own files"
771         https://bugs.webkit.org/show_bug.cgi?id=166681
772         http://trac.webkit.org/changeset/212169
773
774 2017-02-15  Jonathan Bedard  <jbedard@apple.com>
775
776         webkitpy: Fix DarwinPort._get_crash_log()
777         https://bugs.webkit.org/show_bug.cgi?id=168372
778         <rdar://problem/30535156>
779
780         Reviewed by Daniel Bates.
781
782         Callers of _get_crash_log expect a pair to be returned and do not check it's return value.  
783         DarwinPort should return the expected return value for _get_crash_log.
784
785         * Scripts/webkitpy/port/darwin.py:
786         (DarwinPort._get_crash_log): Call parent class's implementation of _get_crash_log.
787
788 2017-02-15  Chris Dumez  <cdumez@apple.com>
789
790         [iOS] Form Validation Bubble should be sensitive to Dynamic Type
791         https://bugs.webkit.org/show_bug.cgi?id=168291
792         <rdar://problem/30508593>
793
794         Reviewed by Tim Horton.
795
796         Drop overridePreference() implementation in iOS's UIScriptController
797         as it was only used for the minimum font size setting and this setting
798         is not exposed on iOS.
799
800         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
801         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
802         (WTR::UIScriptController::overridePreference):
803         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
804
805 2017-02-15  Jonathan Bedard  <jbedard@apple.com>
806
807         webkitpy: Memoize app_identifier_from_bundle for efficiency, call parent class for _get_crash_log
808         https://bugs.webkit.org/show_bug.cgi?id=168329
809         <rdar://problem/30518832>
810
811         Reviewed by Daniel Bates.
812
813         When testing on device, app_identifier_from_bundle is repeatedly called but the return value will
814         never change given the same input arguments.  Memoize function for efficiency.
815
816         * Scripts/webkitpy/port/darwin.py: Add memoized import.
817         (DarwinPort):
818         (DarwinPort.app_identifier_from_bundle): Memoize to avoid extra executions of PlistBuddy.
819         
820
821 2017-02-15  Jonathan Bedard  <jbedard@apple.com>
822
823         webkitpy: Remove unused import from darwin.py
824         https://bugs.webkit.org/show_bug.cgi?id=168371
825
826         Reviewed by Alex Christensen.
827
828         * Scripts/webkitpy/port/darwin.py: Remove unused 'time' module.
829
830 2017-02-15  Carlos Garcia Campos  <cgarcia@igalia.com>
831
832         [SOUP] Credentials stored by libsoup are used even StoredCredentials policy is DoNotAllowStoredCredentials
833         https://bugs.webkit.org/show_bug.cgi?id=168364
834
835         Reviewed by Michael Catanzaro.
836
837         This can happen if a previous load with allowed to use stored credentials authenticated successfully, saving the
838         credentials in libsoup. It's actually a libsoup bug, but since it's causing layout test failures and we have
839         patches for them, let's patch out jhbuild until we have a new libsoup version to depend on.
840
841         Fixes: http/tests/security/credentials-from-different-domains.html
842                http/tests/xmlhttprequest/cross-origin-no-authorization.html
843
844         * gtk/jhbuild.modules:
845         * gtk/patches/libsoup-auth-Fix-async-authentication-when-flag-SOUP_MESSAGE.patch: Added.
846         * gtk/patches/libsoup-auth-do-not-use-cached-credentials-in-lookup-method-.patch: Added.
847
848 2017-02-14  Carlos Garcia Campos  <cgarcia@igalia.com>
849
850         [GTK] Update cookie manager API to properly work with ephemeral sessions
851         https://bugs.webkit.org/show_bug.cgi?id=168230
852
853         Reviewed by Michael Catanzaro.
854
855         Update unit tests and add new cases for the new API.
856
857         * MiniBrowser/gtk/main.c:
858         (gotWebsiteDataCallback):
859         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
860         (testCookieManagerEphemeral):
861         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
862         (testWebContextEphemeral):
863         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
864         (testWebViewEphemeral):
865         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
866         (serverCallback):
867         (testWebsiteDataEphemeral):
868         (testWebsiteDataCookies):
869         (beforeAll):
870
871 2017-02-14  Wenson Hsieh  <wenson_hsieh@apple.com>
872
873         [WK2] Support data interaction on links
874         https://bugs.webkit.org/show_bug.cgi?id=168331
875         <rdar://problem/30200837>
876
877         Reviewed by Tim Horton.
878
879         Adds 2 unit tests checking that data interaction from a link (with or without a background image) into an
880         editable area results in the link URL being inserted.
881
882         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
883         * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Added.
884         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Added.
885         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
886         (TestWebKitAPI::TEST):
887
888 2017-02-14  Jason Rinn  <jrinn@apple.com>
889
890         Add a test for new WebKit Cocoa API, _getContentsAsString.
891         https://bugs.webkit.org/show_bug.cgi?id=168147
892         <rdar://problem/30502539>
893
894         Reviewed by Tim Horton.
895
896         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
897         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewGetContents.mm: Added.
898         (TEST):
899
900 2017-02-14  Matt Rajca  <mrajca@apple.com>
901
902         Website policies: iframes should respect the autoplay policy of the top-level document
903         https://bugs.webkit.org/show_bug.cgi?id=168333
904
905         Reviewed by Alex Christensen.
906
907         * TestWebKitAPI/Tests/WebKit2/autoplay-check-frame.html: Added.
908         * TestWebKitAPI/Tests/WebKit2/autoplay-check-in-iframe.html: Added.
909         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
910         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
911         (TEST):
912
913 2017-02-14  Chris Dumez  <cdumez@apple.com>
914
915         HTML Form Validation bubble should take minimum font size setting into consideration
916         https://bugs.webkit.org/show_bug.cgi?id=168271
917         <rdar://problem/29869869>
918
919         Reviewed by Simon Fraser.
920
921         Extend UIScriptController's contentsOfUserInterfaceItem() to also return the
922         font size of the validation bubble.
923
924         Add an overridePreference() method to UIScriptController. This is currently
925         used to override the value of the minimumFontSize setting. testRunner's
926         overridePreference() is not usable on WK2 because it does not update the
927         value of the preference on the UIProcess side.
928
929         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
930         (WTR::UIScriptController::overridePreference):
931         * DumpRenderTree/mac/UIScriptControllerMac.mm:
932         (WTR::UIScriptController::overridePreference):
933         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
934         * TestRunnerShared/UIScriptContext/UIScriptController.h:
935         * WebKitTestRunner/TestController.cpp:
936         (WTR::TestController::resetPreferencesToConsistentValues):
937         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
938         (WTR::UIScriptController::overridePreference):
939         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
940         (WTR::UIScriptController::contentsOfUserInterfaceItem):
941         (WTR::UIScriptController::overridePreference):
942
943 2017-02-14  Florian Bruhin  <git@the-compiler.org>
944
945         Use a set instead of a list for tests when parsing expectations
946         https://bugs.webkit.org/show_bug.cgi?id=168304
947
948         In _collect_matching_tests, a lot of membership tests are done on a giant list
949         of strings. By making it a set instead, we can make those much faster, and
950         there's no reason for it to be a list.
951
952         With ~45k tests and some 1000 expectations, this reduces the parse time from 34s
953         to 3s on my machine.
954
955         Reviewed by Ryosuke Niwa.
956
957         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
958         (TestExpectationParser.__init__):
959         (TestExpectationParser._collect_matching_tests):
960
961 2017-02-14  Jonathan Bedard  <jbedard@apple.com>
962
963         Unreviewed build-fix after r212297.
964
965         * Scripts/webkitpy/port/simulator_process.py:
966         (SimulatorProcess.stop): Should return value of the ServerProcess's stop.
967
968 2017-02-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
969
970         [CMake] build-webkit should allow building with the default cmake configuration
971         https://bugs.webkit.org/show_bug.cgi?id=168323
972
973         Reviewed by Michael Catanzaro.
974
975         Add a --default-cmake-features switch that makes the script pass
976         no value for any of the features defined by build-webkit, that
977         way the default values from the port cmake config will be used.
978
979         * Scripts/build-webkit:
980         (cMakeArgsFromFeatures):
981
982 2017-02-14  Jonathan Bedard  <jbedard@apple.com>
983
984         Unreviewed build-fix after r212297.
985
986         * Scripts/webkitpy/port/simulator_process.py:
987         (SimulatorProcess.stop): Handle case where there is no process to kill.
988
989 2017-02-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
990
991         [CMake] build-webkit should print the cmake command executed
992         https://bugs.webkit.org/show_bug.cgi?id=168318
993
994         Reviewed by Michael Catanzaro.
995
996         Run the cmake commands to configure or start the build through
997         a wrapper that prints the command before executing it.
998
999         * Scripts/webkitdirs.pm:
1000         (systemVerbose):
1001         (generateBuildSystemFromCMakeProject):
1002         (buildCMakeGeneratedProject):
1003         (cleanCMakeGeneratedProject):
1004
1005 2017-02-14  Jonathan Bedard  <jbedard@apple.com>
1006
1007         run-webkit-tests for iOS Simulator always complains that stopping WebKitTestRunnerApp.app times out
1008         https://bugs.webkit.org/show_bug.cgi?id=168150
1009
1010         Reviewed by Alexey Proskuryakov.
1011
1012         * Scripts/webkitpy/port/simulator_process.py:
1013         (SimulatorProcess.stop): Close app before calling ServerProcess's stop.
1014         (SimulatorProcess._kill): Move closing of app into stop().
1015         * Scripts/webkitpy/xcode/simulator.py:
1016         (Device.launch_app):
1017         (Device.terminate_app): Deleted.
1018
1019 2017-02-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1020
1021         REGRESSION(r212192): [GTK] Broke downloads API tests
1022         https://bugs.webkit.org/show_bug.cgi?id=168193
1023
1024         Unreviewed. Update test expectations after r212192.
1025
1026         The suggested filename now includes a file extensions if the MIME type is known.
1027
1028         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1029         (testDownloadRemoteFile):
1030         (testDownloadMIMEType):
1031
1032 2017-02-14  Commit Queue  <commit-queue@webkit.org>
1033
1034         Unreviewed, rolling out r212237.
1035         https://bugs.webkit.org/show_bug.cgi?id=168298
1036
1037         This was a wrong fix (Requested by rniwa on #webkit).
1038
1039         Reverted changeset:
1040
1041         "Nwtr unexpectedly passes mismatch ref test if the hashes
1042         doesn't match but no diff"
1043         https://bugs.webkit.org/show_bug.cgi?id=168221
1044         http://trac.webkit.org/changeset/212237
1045
1046 2017-02-13  Alex Christensen  <achristensen@webkit.org>
1047
1048         URLs with an invalid IPv4 address should be invalid
1049         https://bugs.webkit.org/show_bug.cgi?id=168260
1050
1051         Reviewed by Tim Horton.
1052
1053         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1054         (TestWebKitAPI::TEST_F):
1055         Update tests to reflect new correct behavior.
1056
1057 2017-02-13  Don Olmstead  <don.olmstead@am.sony.com>
1058
1059         [WinCairo] Add Build Slave
1060         https://bugs.webkit.org/show_bug.cgi?id=168263
1061
1062         Reviewed by Lucas Forschler.
1063
1064         * BuildSlaveSupport/build.webkit.org-config/config.json:
1065
1066 2017-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
1067
1068         Fix the build after r212254
1069
1070         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1071         (-[DataInteractionSimulator _currentLocation]):
1072
1073 2017-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
1074
1075         [WK2] Add test infrastructure and unit tests for data interaction
1076         https://bugs.webkit.org/show_bug.cgi?id=168159
1077         <rdar://problem/30477634>
1078
1079         Reviewed by Tim Horton.
1080
1081         Uses the testing delegate introduced in WebKit2 to override the gesture recognizer used to initiate data
1082         interaction. Instead of being driven by UIKit, the DataInteractionSimulator drives this overridden gesture
1083         recognizer by making the WKContentView call its dataInteractionGestureRecognized method. To simulate an actual
1084         gesture being performed, we fire the gesture recognizer (or call the data interaction delegate methods, if the
1085         gesture has already been recognized) at regular intervals over the course of the test.
1086
1087         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1088         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Added.
1089         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Added.
1090         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Added.
1091
1092         New test pages for data interaction.
1093
1094         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Added.
1095         (TestWebKitAPI::runTestsExpectingToObserveEvents):
1096         (TestWebKitAPI::TEST):
1097         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1098         (-[TestWKWebView stringByEvaluatingJavaScript:]):
1099         * TestWebKitAPI/ios/DataInteractionSimulator.h: Added.
1100         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Added.
1101         (-[MockLongPressGestureRecognizer initWithWindow:]):
1102         (-[MockLongPressGestureRecognizer locationInView:]):
1103         (-[MockLongPressGestureRecognizer state]):
1104         (-[MockLongPressGestureRecognizer numberOfTouches]):
1105         (-[DataInteractionSimulator initWithWebView:startLocation:endLocation:]):
1106         (-[DataInteractionSimulator dealloc]):
1107         (-[DataInteractionSimulator run]):
1108
1109         Performs a data interaction gesture from the start location to the end location with linear interpolation. For
1110         now, the timestep and progress per tick are 30ms and 3.33%, respectively, which means that tests should complete
1111         in a little under 1 second, though this can be easily changed to be configurable in the future if needed.
1112
1113         (-[DataInteractionSimulator _advanceProgress]):
1114
1115         Fired periodically to drive the data interaction gesture. Schedules a call of itself until the test is
1116         completed, and calls _finishDataInteraction when progress is at 1.
1117
1118         (-[DataInteractionSimulator _finishDataInteraction]):
1119         (-[DataInteractionSimulator _currentLocation]):
1120         (-[DataInteractionSimulator _scheduleAdvanceProgress]):
1121         (-[DataInteractionSimulator _recognizeGestureAtLocation:withState:]):
1122         (-[DataInteractionSimulator dataInteractionGestureRecognizer]):
1123         (-[DataInteractionSimulator webViewDidPerformDataInteractionControllerOperation:]):
1124         (-[DataInteractionSimulator webView:beginDataInteractionWithSourceIndex:gestureRecognizer:]):
1125
1126 2017-02-13  Alex Christensen  <achristensen@webkit.org>
1127
1128         Percent should be allowed in non-special URL hosts
1129         https://bugs.webkit.org/show_bug.cgi?id=168255
1130
1131         Reviewed by Tim Horton.
1132
1133         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1134         (TestWebKitAPI::TEST_F):
1135
1136 2017-02-13  Fujii Hironori  <Hironori.Fujii@sony.com>
1137
1138         Nwtr unexpectedly passes mismatch ref test if the hashes doesn't match but no diff
1139         https://bugs.webkit.org/show_bug.cgi?id=168221
1140
1141         Reviewed by Ryosuke Niwa.
1142
1143         There is a logic error in comparing mismatch ref test images. In
1144         mismatch ref tests, it should be failed if two images has no diff.
1145         But, if the hashes are different, nwtr unexpectedly pass the
1146         mismatch ref test.
1147
1148         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1149         (SingleTestRunner._compare_output_with_reference): Fail the
1150         mismatch ref test if hashes of two images are equal. Invoke
1151         ImageDiff if the hashes don't match.
1152
1153 2017-02-13  Myles C. Maxfield  <mmaxfield@apple.com>
1154
1155         Update custom line breaking iterators to the latest version of Unicode
1156         https://bugs.webkit.org/show_bug.cgi?id=168182
1157
1158         Reviewed by Zalan Bujtas.
1159
1160         Treat the system's ICU as the source of truth to compare breaking positions against.
1161
1162         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1163         * TestWebKitAPI/Tests/WebCore/LineBreaking.mm: Added.
1164         (generateJavaScriptForTest):
1165         (breakingLocationsFromICU):
1166         (testAFewStrings):
1167         (TEST):
1168         * TestWebKitAPI/Tests/WebKit2Cocoa/AllAhem.svg: Renamed from LayoutTests/css3/line-break/resources/AllAhem.svg.
1169         * TestWebKitAPI/Tests/WebKit2Cocoa/LineBreaking.html: Added.
1170
1171 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
1172
1173         [GTK] Several failing WebViewEditor API tests
1174         https://bugs.webkit.org/show_bug.cgi?id=161608
1175
1176         Reviewed by Carlos Garcia Campos.
1177
1178         Selection.collapse() requires arguments; passing no arguments means the JS that selects the
1179         text range here never gets evaluated. Perhaps there was a DOM API change? Changing it to use
1180         Selection.removeAllRanges(), which seems like a better function anyway, fixes all the tests
1181         except the first one, which is still broken due to unrelated bug #151654.
1182
1183         * Scripts/run-gtk-tests:
1184         (TestRunner):
1185         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
1186
1187 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
1188
1189         Unreviewed, skip flaky WebKitPrintOperation/custom-widget test
1190
1191         * Scripts/run-gtk-tests:
1192         (TestRunner):
1193
1194 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
1195
1196         Unreviewed, skip flaky form-controls-associated-signal test
1197
1198         * Scripts/run-gtk-tests:
1199         (TestRunner):
1200
1201 2017-02-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1202
1203         [GTK] Handle caps lock indicator in event modifiers
1204         https://bugs.webkit.org/show_bug.cgi?id=168186
1205
1206         Reviewed by Michael Catanzaro.
1207
1208         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1209         (WTR::webkitModifiersToGDKModifiers): Handle kWKEventModifiersCapsLockKey.
1210
1211 2017-02-11  Simon Fraser  <simon.fraser@apple.com>
1212
1213         MiniBrowser WK1 fails to update URL for within-page navigations
1214         https://bugs.webkit.org/show_bug.cgi?id=168173
1215
1216         Reviewed by Tim Horton.
1217         
1218         Implement -webView:didChangeLocationWithinPageForFrame: so that clicking on named
1219         anchors updates the URL field.
1220
1221         * MiniBrowser/mac/WK1BrowserWindowController.m:
1222         (-[WK1BrowserWindowController webView:didChangeLocationWithinPageForFrame:]):
1223
1224 2017-02-10  John Wilander  <wilander@apple.com>
1225
1226         Updates to Resource Load Statistics: Get the right website data store and introduce timeout for user interaction
1227         https://bugs.webkit.org/show_bug.cgi?id=167474
1228         <rdar://problem/24681808>
1229         <rdar://problem/24703286>
1230         <rdar://problem/30290270>
1231
1232         This patch adds test infrastructure to allow testing 
1233         of the various rules in place for data records removal.
1234
1235         Reviewed by Andy Estes.
1236
1237         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1238         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1239         (WTR::InjectedBundle::didReceiveMessageToPage):
1240             Callback mechanism to tell pages that a website data store
1241             scan has happened.
1242         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1243         (WTR::TestRunner::setStatisticsPrevalentResource):
1244         (WTR::TestRunner::isStatisticsPrevalentResource):
1245         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
1246         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
1247         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
1248         (WTR::TestRunner::installStatisticsDidModifyDataRecordsCallback):
1249         (WTR::TestRunner::statisticsDidModifyDataRecordsCallback):
1250         (WTR::TestRunner::statisticsFireDataModificationHandler):
1251         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
1252         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
1253         (WTR::TestRunner::setStatisticsMinimumTimeBetweeenDataRecordsRemoval):
1254         (WTR::TestRunner::statisticsResetToConsistentState):
1255         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1256         * WebKitTestRunner/TestController.cpp:
1257         (WTR::TestController::setStatisticsPrevalentResource):
1258         (WTR::TestController::isStatisticsPrevalentResource):
1259         (WTR::TestController::setStatisticsHasHadUserInteraction):
1260         (WTR::TestController::isStatisticsHasHadUserInteraction):
1261         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1262         (WTR::TestController::statisticsFireDataModificationHandler):
1263         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
1264         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
1265         (WTR::TestController::setStatisticsMinimumTimeBetweeenDataRecordsRemoval):
1266         (WTR::TestController::statisticsResetToConsistentState):
1267         * WebKitTestRunner/TestController.h:
1268             These are all configuration and test functions.
1269         * WebKitTestRunner/TestInvocation.cpp:
1270         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1271
1272 2017-02-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1273
1274         REGRESSION(r182916) run-perf-tests never timeouts
1275         https://bugs.webkit.org/show_bug.cgi?id=167626
1276
1277         Reviewed by Ryosuke Niwa.
1278
1279         The --time-out-ms value (defaults to 600 seconds) of run-perf-tests
1280         was beeing ignored because the driver was created with no_timeout=True
1281         unconditionally.
1282         This adds a new parameter --no-timeout (disabled by default), that
1283         allows to use the driver with the expected timeout values.
1284         It also passes --no-timeout to DRT/WTR to ensure that timeouts
1285         are always controlled by the Python Driver.
1286
1287         * Scripts/webkitpy/performance_tests/perftest.py:
1288         (PerfTest._create_driver): Only disable timeout if --no-timeout is passed.
1289         (PerfTest.run): Disabling timeout should be done when the Driver is created.
1290         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1291         (PerfTestsRunner.__init__): Ensure --no-timeout is passed to DRT/WTR
1292         (PerfTestsRunner._parse_args): Add a --no-timeout parameter.
1293         (_run_tests_set): Pass the no-timeout parameter.
1294         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1295         (MainTest.test_drt_notimeout): Test --no-timeout is passed to DRT/WTR
1296         (MainTest.test_default_args): Test default values for additional_drt_flag and no_timeout.
1297         (MainTest.test_parse_args): Test that the argument no-timeout.
1298
1299 2017-02-10  Daniel Bates  <dabates@apple.com>
1300
1301         Detach frame from document when entering page cache
1302         https://bugs.webkit.org/show_bug.cgi?id=166774
1303         <rdar://problem/29904368>
1304
1305         Reviewed by Chris Dumez.
1306
1307         * DumpRenderTree/mac/DumpRenderTree.mm:
1308         (resetWebPreferencesToConsistentValues):
1309         * DumpRenderTree/win/DumpRenderTree.cpp:
1310         (resetWebPreferencesToConsistentValues):
1311         * WebKitTestRunner/TestController.cpp:
1312         (WTR::TestController::resetPreferencesToConsistentValues):
1313
1314 2017-02-10  Tim Horton  <timothy_horton@apple.com>
1315
1316         Infinite UI process hang under ensurePositionInformationIsUpToDate
1317         https://bugs.webkit.org/show_bug.cgi?id=168154
1318         <rdar://problem/30428673>
1319
1320         Reviewed by Simon Fraser.
1321
1322         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1323         * TestWebKitAPI/Tests/WebKit2Cocoa/InteractionDeadlockAfterCrash.mm: Added.
1324         (recursiveFindHighlightLongPressRecognizer):
1325         (TEST):
1326         Add a somewhat nasty test that does an async interaction information update, but
1327         kills the Web process before it arrives, and then does a sync interaction
1328         information update, which will wait for the oustanding async interaction
1329         information update if we still think it's coming. Before the patch, this
1330         test times out with the UI process stuck under ensurePositionInformationIsUpToDate.
1331
1332 2017-02-10  Simon Fraser  <simon.fraser@apple.com>
1333
1334         Make sure the "inwindow" flag propagates to TiledBackings for masks and reflections
1335         https://bugs.webkit.org/show_bug.cgi?id=168127
1336         rdar://problem/30467120
1337
1338         Reviewed by Tim Horton.
1339
1340         Reparent the web view before we try to fetch it via:
1341             [[[window contentView] subviews] objectAtIndex:0];
1342         which would throw an exception if the test unparented it.
1343
1344         * DumpRenderTree/mac/DumpRenderTree.mm:
1345         (resetWebViewToConsistentStateBeforeTesting):
1346         (runTest):
1347
1348 2017-02-10  Joseph Pecoraro  <pecoraro@apple.com>
1349
1350         [Resource Timing] Enable Resource Timing by default in Tests
1351         https://bugs.webkit.org/show_bug.cgi?id=168145
1352
1353         Reviewed by Ryosuke Niwa.
1354
1355         * DumpRenderTree/mac/DumpRenderTree.mm:
1356         (resetWebPreferencesToConsistentValues):
1357         * DumpRenderTree/win/DumpRenderTree.cpp:
1358         (resetWebPreferencesToConsistentValues):
1359         * WebKitTestRunner/TestController.cpp:
1360         (WTR::TestController::resetPreferencesToConsistentValues):
1361
1362 2017-02-10  Jonathan Bedard  <jbedard@apple.com>
1363
1364         Removing LayoutTestRelay
1365         https://bugs.webkit.org/show_bug.cgi?id=165927
1366
1367         Reviewed by Daniel Bates.
1368         Part 2
1369
1370         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
1371         simulators through simctl (iOS 10 and later), use this functionality instead.
1372
1373         * BuildSlaveSupport/built-product-archive:
1374         (archiveBuiltProduct): Remove archiving of LayoutTestRelay as it is no longer being built.
1375         Added a FIXME that we will need to implement similar archiving machinery once we build
1376         ImageDiff for Mac when building WebKit for iOS. Currently ImageDiff is built with the iOS SDK.
1377         * BuildSlaveSupport/kill-old-processes:
1378         (main): Remove LayoutTestRelay from list of processes.
1379         * LayoutTestRelay: Removed LayoutTestRelay.
1380         * Makefile:
1381         * Scripts/build-layouttestrelay: Removed.
1382         * Scripts/build-webkit: Removed LayoutTestRelay references.
1383
1384 2017-02-10  Jiewen Tan  <jiewen_tan@apple.com>
1385
1386         [WebCrypto] Add WebCryptoAPI to watchlist
1387         https://bugs.webkit.org/show_bug.cgi?id=168138
1388
1389         Reviewed by Youenn Fablet.
1390
1391         * Scripts/webkitpy/common/config/watchlist:
1392
1393 2017-02-10  Brady Eidson  <beidson@apple.com>
1394
1395         Replace all WebKit Library Version checks in WK2 with SDK version checks.
1396         https://bugs.webkit.org/show_bug.cgi?id=168124
1397
1398         Reviewed by Geoffrey Garen.
1399
1400         For each of our tools that use WebKit2, opt them in to the new linkedOnOrAfter(Everything) setting.
1401         
1402         * MiniBrowser/mac/main.m:
1403         (main):
1404         * MobileMiniBrowser/MobileMiniBrowser/main.m:
1405         (main):
1406         * TestWebKitAPI/ios/mainIOS.mm:
1407         (main):
1408         * TestWebKitAPI/mac/mainMac.mm:
1409         (main):
1410         * WebKitTestRunner/ios/mainIOS.mm:
1411         (main):
1412         * WebKitTestRunner/mac/main.mm:
1413         (setDefaultsToConsistentValuesForTesting):
1414
1415 2017-02-10  Alex Christensen  <achristensen@webkit.org>
1416
1417         Fix El Capitan build.
1418
1419         * Scripts/build-webkit:
1420         Don't build libwebrtc anywhere for now.
1421
1422 2017-02-10  Andy Estes  <aestes@apple.com>
1423
1424         Move two MiniBrowserBundle settings out of the .pbxproj
1425         https://bugs.webkit.org/show_bug.cgi?id=168106
1426
1427         Reviewed by Tim Horton.
1428
1429         INFOPLIST_FILE was specified in MiniBrowserBundle.xcconfig but overridden to "" in
1430         the project file. This removes the project file override.
1431
1432         WRAPPER_EXTENSION was moved from the project file to MiniBrowserBundle.xcconfig.
1433
1434         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig:
1435         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1436
1437 2017-02-10  Alex Christensen  <achristensen@webkit.org>
1438
1439         Fix 32-and-64-bit build on El Capitan.
1440
1441         * Scripts/build-webkit:
1442         Somebody's building with something like this:
1443         build-webkit ARCHS="i386 x86_64"
1444         We want this to also not build libwebrtc for now.
1445
1446 2017-02-10  Alex Christensen  <achristensen@webkit.org>
1447
1448         Fix 32-bit build on El Capitan.
1449
1450         * Scripts/build-webkit:
1451         The bot uses ARCHS=i386 instead of --32-bit.
1452         This is a hack, but it should fix the bot until I can do a better fix in the morning.
1453
1454 2017-02-10  Alex Christensen  <achristensen@webkit.org>
1455
1456         Fix 32-bit build on El Capitan.
1457
1458         * Scripts/build-webkit:
1459         Don't build i386 libwebrtc.
1460
1461 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1462
1463         Unreviewed, rolling out r212040.
1464
1465         Broke build.  I'm not surprised
1466
1467         Reverted changeset:
1468
1469         "[WebRTC][Mac] Activate libwebrtc"
1470         https://bugs.webkit.org/show_bug.cgi?id=167293
1471         http://trac.webkit.org/changeset/212040
1472
1473 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1474
1475         Build libwebrtc on bots without using it yet
1476         https://bugs.webkit.org/show_bug.cgi?id=168062
1477
1478         Reviewed by Brent Fulgham.
1479
1480         * Scripts/build-webkit:
1481
1482 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1483
1484         Don't build libwebrtc.
1485
1486         * Scripts/build-webkit:
1487         Not ready yet.  It broke El Capitan and iOS.
1488
1489 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1490
1491         Build libwebrtc on bots without using it yet
1492         https://bugs.webkit.org/show_bug.cgi?id=168062
1493
1494         Reviewed by Brent Fulgham.
1495
1496         * Scripts/build-webkit:
1497
1498 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1499
1500         Rename isAppleMacWebKit to isAppleCocoaWebKit
1501         https://bugs.webkit.org/show_bug.cgi?id=168075
1502
1503         Reviewed by Geoffrey Garen.
1504
1505         It returns true for Mac and iOS.  "isAppleMacWebKit" is confusing and wrong.
1506
1507         * Scripts/build-api-tests:
1508         * Scripts/build-dumprendertree:
1509         * Scripts/build-jsc:
1510         (buildMyProject):
1511         * Scripts/build-layouttestrelay:
1512         * Scripts/build-webkit:
1513         * Scripts/build-webkittestrunner:
1514         * Scripts/run-api-tests:
1515         (isSupportedPlatform):
1516         (runTest):
1517         (listAllTests):
1518         (prepareEnvironmentForRunningTestTool):
1519         * Scripts/run-content-extension-tester:
1520         * Scripts/run-javascriptcore-tests:
1521         * Scripts/run-minibrowser:
1522         * Scripts/show-pretty-diff:
1523         * Scripts/webkitdirs.pm:
1524         (determineBaseProductDir):
1525         (determineArchitecture):
1526         (determinePassedArchitecture):
1527         (safariPath):
1528         (builtDylibPathForName):
1529         (checkFrameworks):
1530         (isAppleWebKit):
1531         (isAppleCocoaWebKit):
1532         (determineNmPath):
1533         (launcherName):
1534         (wrapperPrefixIfNeeded):
1535         (isCMakeBuild):
1536         (mobileSafariBundle):
1537         (debugSafari):
1538         (runSafari):
1539         (runMiniBrowser):
1540         (debugMiniBrowser):
1541         (runWebKitTestRunner):
1542         (debugWebKitTestRunner):
1543         (isAppleMacWebKit): Deleted.
1544         * Scripts/webkitperl/FeatureList.pm:
1545
1546 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1547
1548         Revert r211991
1549         https://bugs.webkit.org/show_bug.cgi?id=168062
1550
1551         * Scripts/build-webkit:
1552         Not quite ready yet.
1553
1554 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1555
1556         Build libwebrtc on bots without using it yet
1557         https://bugs.webkit.org/show_bug.cgi?id=168062
1558
1559         Reviewed by Brent Fulgham.
1560
1561         * Scripts/build-webkit:
1562         Build libwebrtc on Mac when we build ANGLE.
1563
1564 2017-02-09  Youenn Fablet  <youenn@apple.com>
1565
1566         Improve W3C importer command line options
1567         https://bugs.webkit.org/show_bug.cgi?id=167448
1568
1569         Reviewed by Ryosuke Niwa.
1570
1571         Making the list of test paths to import the main arguments of the script.
1572         Allow passing the source directory to import as a -s option.
1573         Adding a warning when given test paths are skipped by default in ImportExpectations.
1574
1575         Making link conversion off by default when importing from a specific directory since this script is mostly used with web-platform-tests.
1576         Link conversion rules do not change when imported tests are downloaded by the script.
1577
1578         * Scripts/webkitpy/w3c/test_importer.py:
1579         (main):
1580         (parse_args):
1581         (TestImporter.__init__):
1582         (TestImporter.do_import):
1583         (TestImporter):
1584         (TestImporter.check_imported_expectations):
1585
1586 2017-02-08  Chris Dumez  <cdumez@apple.com>
1587
1588         Update web-platform-tests resources
1589         https://bugs.webkit.org/show_bug.cgi?id=168026
1590
1591         Reviewed by Youenn Fablet.
1592
1593         Stop copying testharness.js from resources/ to web-platform-tests/resources.
1594
1595         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1596         (WebPlatformTestServer._copy_webkit_test_files):
1597
1598 2017-02-08  Andy Estes  <aestes@apple.com>
1599
1600         Custom protocols should not continue loading after a network process crash
1601         https://bugs.webkit.org/show_bug.cgi?id=168028
1602         <rdar://problem/27607520>
1603
1604         Reviewed by Brady Eidson.
1605
1606         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1607         (processGroup):
1608         (-[CloseWhileStartingProtocol startLoading]):
1609         (-[CloseWhileStartingProtocol stopLoading]):
1610         (TestWebKitAPI::runTest):
1611         (TestWebKitAPI::TEST):
1612
1613 2017-02-08  Dan Bernstein  <mitz@apple.com>
1614
1615         [Cocoa] WKRemoteObjectCoder doesn’t handle CGSize
1616         https://bugs.webkit.org/show_bug.cgi?id=168031
1617
1618         Reviewed by Tim Horton.
1619
1620         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
1621         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1622         (TEST):
1623         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
1624         (-[RemoteObjectRegistryPlugIn takeSize:completionHandler:]):
1625
1626 2017-02-08  Chris Dumez  <cdumez@apple.com>
1627
1628         Use smaller tiles in windows that are not active to facilitate App Napping
1629         https://bugs.webkit.org/show_bug.cgi?id=167997
1630         <rdar://problem/30358835>
1631
1632         Reviewed by Simon Fraser.
1633
1634         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1635         (WTR::PlatformWebView::setWindowIsKey):
1636         Actually update windowIsKey state of NSWindow so the WebView
1637         properly updates its activity state.
1638
1639 2017-02-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1640
1641         Add kUTTypeUTF8PlainText and kUTTypeJPEG to the list of compatible content types in DragData
1642         https://bugs.webkit.org/show_bug.cgi?id=167942
1643         <rdar://problem/30315079>
1644
1645         Reviewed by Tim Horton.
1646
1647         Adds a new test case that simulates dragging from a source that only vends JPEG images or UTF8 plaintext into a
1648         contenteditable area. An image element and the plain text content, respectively, should be inserted into the
1649         contenteditable in these cases.
1650
1651         The DragSource and DragInfo are used to mock dragging into the WebView. There is no reliance on using mouse
1652         events in this test, since we call the dragging delegate methods (draggingEntered:, draggingUpdated:, and
1653         performDragOperation:) directly.
1654
1655         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1656         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm: Added.
1657         (+[FrameLoadCompletionListener listenerWithCompletionBlock:]):
1658         (-[FrameLoadCompletionListener initWithCompletionBlock:]):
1659         (-[FrameLoadCompletionListener webView:didFinishLoadForFrame:]):
1660         (-[DragSource draggingSourceOperationMaskForLocal:]):
1661         (-[DragInfo initWithImage:offset:pasteboard:source:destinationWindow:]):
1662         (-[DragInfo lastMousePosition]):
1663         (-[DragInfo setLastMousePosition:]):
1664         (-[DragInfo draggingDestinationWindow]):
1665         (-[DragInfo draggingSourceOperationMask]):
1666         (-[DragInfo draggingLocation]):
1667         (-[DragInfo draggedImageLocation]):
1668         (-[DragInfo draggedImage]):
1669         (-[DragInfo draggingPasteboard]):
1670         (-[DragInfo draggingSource]):
1671         (-[DragInfo draggingSequenceNumber]):
1672         (-[DragInfo slideDraggedImageTo:]):
1673         (-[DragInfo namesOfPromisedFilesDroppedAtDestination:]):
1674         (-[DragInfo draggingFormation]):
1675         (-[DragInfo setDraggingFormation:]):
1676         (-[DragInfo animatesToDestination]):
1677         (-[DragInfo setAnimatesToDestination:]):
1678         (-[DragInfo numberOfValidItemsForDrop]):
1679         (-[DragInfo setNumberOfValidItemsForDrop:]):
1680         (-[DragInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1681         (-[DragInfo springLoadingHighlight]):
1682         (-[DragInfo resetSpringLoading]):
1683         (TestWebKitAPI::getTestImage):
1684         (TestWebKitAPI::webViewAfterPerformingDragOperation):
1685         (TestWebKitAPI::TEST):
1686         * TestWebKitAPI/Tests/mac/full-page-contenteditable.html: Added.
1687
1688 2017-02-08  Jer Noble  <jer.noble@apple.com>
1689
1690         Move FullscreenClient creation into WebViewImpl, for use in (deprecated) WKView.
1691         https://bugs.webkit.org/show_bug.cgi?id=168007
1692
1693         Reviewed by Alex Christensen.
1694
1695         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm:
1696         (didFinishLoadForFrame):
1697         (TestWebKitAPI::TEST):
1698
1699 2017-02-08  Commit Queue  <commit-queue@webkit.org>
1700
1701         Unreviewed, rolling out r211873.
1702         https://bugs.webkit.org/show_bug.cgi?id=168001
1703
1704         It's in jhbuild for consistent layout tests (Requested by
1705         mcatanzaro on #webkit).
1706
1707         Reverted changeset:
1708
1709         "[GTK] Add icu packages to Tools/gtk/install-dependencies"
1710         https://bugs.webkit.org/show_bug.cgi?id=167993
1711         http://trac.webkit.org/changeset/211873
1712
1713 2017-02-08  Adrian Perez de Castro  <aperez@igalia.com>
1714
1715         [GTK] Add icu packages to Tools/gtk/install-dependencies
1716         https://bugs.webkit.org/show_bug.cgi?id=167993
1717
1718         Reviewed by Michael Catanzaro.
1719
1720         * gtk/install-dependencies: Add "icu" to the list of required packages (or "icu-dev", or "icu-devel"
1721         depending in the GNU/Linux distribution)
1722
1723 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
1724
1725         Update flakiness dashboard configuration.
1726         https://bugs.webkit.org/show_bug.cgi?id=167957
1727
1728         Reviewed by Alexey Proskuryakov.
1729
1730         * TestResultServer/static-dashboards/builders.jsonp:
1731
1732 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
1733
1734         Replace a bot that has an incorrect configuration.
1735         https://bugs.webkit.org/show_bug.cgi?id=167747
1736
1737         Rubber-stamped by Alexey Proskuryakov.
1738
1739         * BuildSlaveSupport/build.webkit.org-config/config.json:
1740
1741 2017-02-07  Myles C. Maxfield  <mmaxfield@apple.com>
1742
1743         [Win] [GTK] [EFL] Compile (but don't use, yet) the platform-independent piece of ComplexTextController
1744         https://bugs.webkit.org/show_bug.cgi?id=167927
1745
1746         Reviewed by Brent Fulgham.
1747
1748         Enable ComplexTextController API tests on the Win and GTK ports.
1749
1750         * TestWebKitAPI/PlatformGTK.cmake:
1751         * TestWebKitAPI/PlatformWin.cmake:
1752
1753 2017-02-07  Jonathan Bedard  <jbedard@apple.com>
1754
1755         File index appended to previous file in svn-create-patch with SVN 1.9
1756         https://bugs.webkit.org/show_bug.cgi?id=167903
1757         <rdar://problem/30387395>
1758
1759         Reviewed by Daniel Bates.
1760
1761         * Scripts/VCSUtils.pm:
1762         (fixSVNPatchForAdditionWithHistory): Append a trailing newline character.
1763         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Do not remove
1764         trailing newline character from the expected result before comparing it to the actual result.
1765
1766 2017-02-07  Olivier Blin  <olivier.blin@softathome.com>
1767
1768         [webkitdirs] remove unused host_processor variable in determineArchitecture()
1769         https://bugs.webkit.org/show_bug.cgi?id=167936
1770
1771         Reviewed by Michael Catanzaro.
1772
1773         * Scripts/webkitdirs.pm:
1774         (determineArchitecture):
1775         The host_processor variable in webkitdirs.pm's determineArchitecture() is not used anymore,
1776         since r195083.
1777
1778 2017-02-07  Youenn Fablet  <youenn@apple.com>
1779
1780         Use a JSON file to define which WPT files/folders to import
1781         https://bugs.webkit.org/show_bug.cgi?id=167923
1782
1783         Reviewed by Alex Christensen.
1784
1785         * Scripts/webkitpy/w3c/test_downloader.py:
1786         (TestDownloader.__init__):
1787         (TestDownloader._init_paths_from_expectations):
1788         * Scripts/webkitpy/w3c/test_importer.py:
1789         (parse_args):
1790         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1791
1792 2017-02-06  Fujii Hironori  <Hironori.Fujii@sony.com>
1793
1794         [GTK] jhbuild fails: mesa-11.0.6.tar.xz: 404 Not Found
1795         https://bugs.webkit.org/show_bug.cgi?id=167916
1796
1797         Reviewed by Carlos Garcia Campos.
1798
1799         URL of mesa-11.0.6.tar.xz has been moved.
1800
1801         * gtk/jhbuild.modules: Fix the module path.
1802
1803 2017-02-06  Joseph Pecoraro  <pecoraro@apple.com>
1804
1805         Static Analyzer: Address some leaks in MiniBrowser
1806         https://bugs.webkit.org/show_bug.cgi?id=167897
1807
1808         Reviewed by Alexey Proskuryakov.
1809
1810         * MiniBrowser/mac/BrowserWindowController.m:
1811         (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
1812         * MiniBrowser/mac/ExtensionManagerWindowController.m:
1813         (-[ExtensionManagerWindowController add:]):
1814         (-[ExtensionManagerWindowController remove:]):
1815         * MiniBrowser/mac/SettingsController.m:
1816         (-[SettingsController _populateMenu]):
1817         (-[SettingsController togglePerWindowWebProcessesDisabled:]):
1818         Address obvious leaks caught by the static analyzer.
1819
1820 2017-02-06  Myles C. Maxfield  <mmaxfield@apple.com>
1821
1822         Migrate ComplexTextController to use platform-independent types
1823         https://bugs.webkit.org/show_bug.cgi?id=167833
1824
1825         Reviewed by Brent Fulgham.
1826
1827         Migrate tests away from platform-dependent types.
1828
1829         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1830         (TestWebKitAPI::TEST_F):
1831
1832 2017-02-06  Brent Fulgham  <bfulgham@apple.com>
1833
1834         Correct File Path Handling in SecurityOrigin and FileSystem
1835         https://bugs.webkit.org/show_bug.cgi?id=167894
1836         <rdar://problem/30380080>
1837
1838         Reviewed by Alexey Proskuryakov.
1839
1840         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Don't encode the temporary files,
1841         and perform same-volume checks using filesystem-compatible paths.        
1842         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Create SecurityOrigins from
1843         filesystem paths, and perform validation of same-volume checks.
1844         (TestWebKitAPI::SecurityOriginTest::tempFilePath): Added.
1845         (TestWebKitAPI::SecurityOriginTest::spaceContainingFilePath): Added.
1846         (TestWebKitAPI::SecurityOriginTest::bangContainingFilePath): Added.
1847         (TestWebKitAPI::SecurityOriginTest::quoteContainingFilePath): Added.
1848
1849 2017-02-06  Jer Noble  <jer.noble@apple.com>
1850
1851         Playback stalls when a SourceBuffer append causes frame eviction
1852         https://bugs.webkit.org/show_bug.cgi?id=167834
1853
1854         Reviewed by Eric Carlson.
1855
1856         Add new correctness tests for the Webcore::SampleMap class. Add additional subtests
1857         for the WTF::MediaTime class.
1858
1859         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1860         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1861         (TestWebKitAPI::TEST):
1862         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp: Added.
1863         (WTF::operator<<):
1864         (TestWebKitAPI::TestSample::create):
1865         (TestWebKitAPI::TestSample::TestSample):
1866         (TestWebKitAPI::TEST_F):
1867
1868 2017-02-06  Ryan Haddad  <ryanhaddad@apple.com>
1869
1870         Change capitalization in platform name after r211735.
1871
1872         Unreviewed dashboard fix.
1873
1874         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1875         (WebKitBuildbot):
1876
1877 2017-02-06  Alexey Proskuryakov  <ap@apple.com>
1878
1879         Move the Leaks bot to Sierra
1880         https://bugs.webkit.org/show_bug.cgi?id=167886
1881
1882         Reviewed by Daniel Bates.
1883
1884         * BuildSlaveSupport/build.webkit.org-config/config.json:
1885         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1886         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1887         (LeaksViewer._displayURLPrompt):
1888         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1889         (WebKitBuildbot):
1890
1891 2017-02-06  Jonathan Bedard  <jbedard@apple.com>
1892
1893         Prevent app crash on launch during simctl install workaround
1894         https://bugs.webkit.org/show_bug.cgi?id=167685
1895
1896         Reviewed by Daniel Bates.
1897
1898         * Scripts/webkitpy/port/simulator_process.py:
1899         (SimulatorProcess.__init__): Pass environment to install.
1900         * Scripts/webkitpy/xcode/simulator.py:
1901         (Device.install_app): Accept environment, pass environment to launch.
1902
1903 2017-02-06  Alex Christensen  <achristensen@webkit.org>
1904
1905         Rebase API tests after r211638
1906         https://bugs.webkit.org/show_bug.cgi?id=167779
1907
1908         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1909         (TestWebKitAPI::TEST_F):
1910         URLs with non-special schemes and characters like % in the host now fail to parse,
1911         more like their special counterparts and according to spec.
1912
1913 2017-02-06  Csaba Osztrogonác  <ossy@webkit.org>
1914
1915         Unreviewed trivial fix after r211697.
1916         https://bugs.webkit.org/show_bug.cgi?id=167863
1917
1918         * Scripts/run-javascriptcore-tests:
1919         (runJSCStressTests): Renamed ES6SampleBench to ARES-6.
1920
1921 2017-02-04  Simon Fraser  <simon.fraser@apple.com>
1922
1923         Clean up how GraphicsLayer's "inWindow" state is set, and fix some issues with Page Overlays
1924         https://bugs.webkit.org/show_bug.cgi?id=167850
1925
1926         Reviewed by Tim Horton.
1927
1928         * DumpRenderTree/TestRunner.cpp:
1929         (TestRunner::uiScriptDidComplete): Fix an assertion that fires for non-16-bit strings.
1930
1931 2017-02-04  Andreas Kling  <akling@apple.com>
1932
1933         Plug some leaks in TestController and UIScriptContext.
1934         <https://webkit.org/b/167839>
1935
1936         Reviewed by Alexey Proskuryakov.
1937
1938         Fix a couple of the leaks seen on the leaks bot.
1939
1940         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
1941         (UIScriptContext::runUIScript):
1942         * WebKitTestRunner/TestController.cpp:
1943         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
1944         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
1945
1946 2017-02-03  Jeremy Jones  <jeremyj@apple.com>
1947
1948         WK1 mouse events are missing movementX and movementY for pointerlock.
1949         https://bugs.webkit.org/show_bug.cgi?id=167775
1950         rdar://problem/30343810
1951
1952         Reviewed by Alexey Proskuryakov.
1953
1954         Set kCGMouseEventDeltaX and kCGMouseEventDeltaY when synthesizing mouse move events.
1955
1956         * DumpRenderTree/mac/EventSendingController.mm:
1957         (-[EventSendingController mouseMoveToX:Y:]):
1958         * WebKitTestRunner/mac/EventSenderProxy.mm:
1959         (WTR::EventSenderProxy::mouseMoveTo):
1960
1961 2017-02-03  Simon Fraser  <simon.fraser@apple.com>
1962
1963         Correctly set the "inWindow" flag for TileControllers that aren't the page tiles, and clarify "usingTiledBacking" logic
1964         https://bugs.webkit.org/show_bug.cgi?id=167774
1965
1966         Reviewed by Tim Horton.
1967
1968         Implement UIScriptController removeViewFromWindow() and addViewToWindow(), and hook
1969         up for Mac WK1 and WK2, and iOS WK2. It takes a callback because view state updates to the
1970         web process are async, so the callback fires after the web process gets the new state.
1971
1972         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1973         (WTR::UIScriptController::removeViewFromWindow):
1974         (WTR::UIScriptController::addViewToWindow):
1975         * DumpRenderTree/mac/DumpRenderTree.mm:
1976         (createWebViewAndOffscreenWindow):
1977         (resetWebViewToConsistentStateBeforeTesting):
1978         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1979         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1980         (WTR::UIScriptController::removeViewFromWindow):
1981         (WTR::UIScriptController::addViewToWindow):
1982         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1983         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1984         (WTR::UIScriptController::removeViewFromWindow):
1985         (WTR::UIScriptController::addViewToWindow):
1986         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1987         * WebKitTestRunner/PlatformWebView.h:
1988         * WebKitTestRunner/TestController.cpp:
1989         (WTR::TestController::resetStateToConsistentValues):
1990         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1991         (WTR::PlatformWebView::removeFromWindow):
1992         (WTR::PlatformWebView::addToWindow):
1993         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1994         (WTR::UIScriptController::removeViewFromWindow):
1995         (WTR::UIScriptController::addViewToWindow):
1996         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1997         (WTR::PlatformWebView::removeFromWindow):
1998         (WTR::PlatformWebView::addToWindow):
1999         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2000         (WTR::UIScriptController::removeViewFromWindow):
2001         (WTR::UIScriptController::addViewToWindow):
2002
2003 2017-02-03  Alexey Proskuryakov  <ap@apple.com>
2004
2005         Remove check for SkipSafariExecutableEntitlementChecks
2006         https://bugs.webkit.org/show_bug.cgi?id=167762
2007
2008         Reviewed by Dan Bernstein.
2009
2010         Follow-up fix: don't break internal behavior.
2011
2012         * Scripts/webkitdirs.pm:
2013         (safariPath):
2014         (executableHasEntitlements): Deleted.
2015         (safariPathFromSafariBundle): Deleted.
2016         (installedSafariPath): Deleted.
2017
2018 2017-02-03  Daniel Bates  <dabates@apple.com>
2019
2020         [Mac][WK2] Add SPI to override the Content Security Policy of a page
2021         https://bugs.webkit.org/show_bug.cgi?id=167810
2022         <rdar://problem/30102568>
2023
2024         Reviewed by Anders Carlsson.
2025
2026         Add tests to ensure that we do not regress -[WKWebView _setOverrideContentSecurityPolicy:].
2027
2028         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2029         * TestWebKitAPI/Tests/WebKit2Cocoa/OverrideContentSecurityPolicy.mm: Added.
2030         (TEST):
2031         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp-iframe.html: Added.
2032         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp.html: Added.
2033         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp-iframe.html: Added.
2034         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp.html: Added.
2035
2036 2017-02-02  Alex Christensen  <achristensen@webkit.org>
2037
2038         URLParser: Fix parsing invalid IPv4 addresses with non-ASCII characters
2039         https://bugs.webkit.org/show_bug.cgi?id=167773
2040         <rdar://problem/30221102>
2041
2042         Reviewed by Ryosuke Niwa.
2043
2044         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2045         (TestWebKitAPI::TEST_F):
2046
2047 2017-02-02  Alexey Proskuryakov  <ap@apple.com>
2048
2049         Remove check for SkipSafariExecutableEntitlementChecks
2050         https://bugs.webkit.org/show_bug.cgi?id=167762
2051         rdar://problem/22480673
2052
2053         Reviewed by Dan Bernstein.
2054
2055         * Scripts/webkitdirs.pm:
2056         (safariPathFromSafariBundle):
2057         (skipSafariExecutableEntitlementChecks): Deleted.
2058
2059 2017-02-02  Jonathan Bedard  <jbedard@apple.com>
2060
2061         Undefined subroutine in svn-create-patch
2062         https://bugs.webkit.org/show_bug.cgi?id=167742
2063
2064         Unreviewed build-fix after r211543.
2065
2066         * Scripts/VCSUtils.pm: fixSVNPatchForAdditionWithHistory was not exported.
2067
2068 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2069
2070         Unreviewed. Fix jhbuild dependencies build.
2071
2072         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch:
2073         Patch updated.
2074
2075 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2076
2077         [EME][GStreamer] Fixed decryptor selection
2078         https://bugs.webkit.org/show_bug.cgi?id=167588
2079
2080         Reviewed by Žan Doberšek.
2081
2082         This patches are pending at https://bugzilla.gnome.org/show_bug.cgi?id=770107
2083
2084         * gtk/jhbuild.modules: Added patches to gstreamer and
2085         gst-plugins-good packages.
2086         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch: Added.
2087         * gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
2088
2089 2017-02-01  Dewei Zhu  <dewei_zhu@apple.com>
2090
2091         Make run-benchmark script supports 'config' key in test plan.
2092         https://bugs.webkit.org/show_bug.cgi?id=167715
2093
2094         Reviewed by Ryosuke Niwa.
2095
2096         Add support for 'config' key in test paln.
2097         'config' key is a dictionary that specifies environment configurations while test is running.
2098         Specifies orientation to be portrait in MotionMark benchmark.
2099
2100         * Scripts/webkitpy/benchmark_runner/README.md:
2101         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2102         (BenchmarkRunner.__init__):
2103         (BenchmarkRunner._run_benchmark):
2104         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2105         (BrowserDriver.prepare_env):
2106         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
2107         (LinuxBrowserDriver.prepare_env):
2108         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2109         (OSXBrowserDriver.prepare_env):
2110         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2111         (OSXSafariDriver.prepare_env):
2112         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
2113
2114 2017-02-01  Daniel Bates  <dabates@apple.com>
2115
2116         REGRESSION (r210820): svn-create-patch does not emit property change only diff
2117         https://bugs.webkit.org/show_bug.cgi?id=167169
2118
2119         Reviewed by David Kilzer.
2120
2121         More directly handle the SVN 1.9 or newer syntax change for a diff of a copied or moved file
2122         - a SVN diff header and an empty body. In particular, remove a duplicate leading SVN diff
2123         header from the output of "svn diff" on a file that was copied or moved.
2124
2125         Following r210820 svn-create-patch emits to standard output a diff only if it has at least one
2126         chunk range line (e.g. @@ -0,0 +1,7 @@) as a means to workaround a syntax change in the diff
2127         output of a copied or moved file in SVN version 1.9 or newer. In SVN 1.9 or newer "svn diff"
2128         of a copied or moved file always emits to standard output a leading SVN diff header (an "Index:"
2129         line followed by a separator line) with an empty body; => no chunk range lines. However a diff
2130         of a file with only a property change also does not contain any chunk range lines. Therefore
2131         svn-create-patch no longer emitted to standard output such a diff. Instead of indirectly detecting
2132         a SVN diff header with an empty body by counting the number of chunk range lines in the diff
2133         we should directly test for the presence of a leading SVN diff header with an empty body and
2134         remove such lines from the diff.
2135
2136         * Scripts/VCSUtils.pm:
2137         (fixSVNPatchForAdditionWithHistory): Added.
2138         * Scripts/svn-create-patch:
2139         (generateDiff): Pass the output from "svn diff" to fixSVNPatchForAdditionWithHistory() when
2140         we have a non empty patch for an added file with history (i.e. a copied or moved file).
2141         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Added.
2142
2143 2017-02-01  Eric Carlson  <eric.carlson@apple.com>
2144
2145         [Mac] Update CARingBuffer class
2146         https://bugs.webkit.org/show_bug.cgi?id=167656
2147
2148         Reviewed by Jer Noble.
2149
2150         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2151         * TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp: Added.
2152         (TestWebKitAPI::CARingBufferTest::SetUp):
2153         (TestWebKitAPI::CARingBufferTest::setup):
2154         (TestWebKitAPI::CARingBufferTest::setListDataBuffer):
2155         (TestWebKitAPI::CARingBufferTest::description):
2156         (TestWebKitAPI::CARingBufferTest::bufferList):
2157         (TestWebKitAPI::CARingBufferTest::ringBuffer):
2158         (TestWebKitAPI::CARingBufferTest::capacity):
2159         (TestWebKitAPI::CARingBufferTest::audioBufferListSizeForStream):
2160         (TestWebKitAPI::CARingBufferTest::configureBufferListForStream):
2161         (TestWebKitAPI::TEST_F):
2162         (TestWebKitAPI::MixingTest::run):
2163
2164 2017-02-01  Alexey Proskuryakov  <ap@apple.com>
2165
2166         [Mac] TestWebKitAPI includes system frameworks incorrectly
2167         https://bugs.webkit.org/show_bug.cgi?id=167703
2168         rdar://problem/30301498
2169
2170         Reviewed by Ryosuke Niwa.
2171
2172         FRAMEWORK_SEARCH_PATH results in frameworks being treated as user ones, not system.
2173         Make TestWebKitAPI use -iframework instead, like the rest of WebKit does.
2174
2175         Also, reduced the number of subframework search paths, looks like we only need one now.
2176
2177         * TestWebKitAPI/Configurations/Base.xcconfig:
2178
2179 2017-02-01  Brent Fulgham  <bfulgham@apple.com>
2180
2181         Correct "filesHaveSameVolume" predicate
2182         https://bugs.webkit.org/show_bug.cgi?id=167696
2183         <rdar://problem/30298722>
2184
2185         Reviewed by David Kilzer.
2186
2187         Add new tests that confirm that the 'filesHaveSamePath' predicate properly handles
2188         percent-escaped path inputs.
2189
2190         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
2191         (TestWebKitAPI::FileSystemTest::spaceContainingFilePath):
2192         (TestWebKitAPI::FileSystemTest::bangContainingFilePath):
2193         (TestWebKitAPI::FileSystemTest::quoteContainingFilePath):
2194         (TestWebKitAPI::TEST_F):
2195
2196 2017-02-01  Tomas Popela  <tpopela@redhat.com>
2197
2198         Unreviewed. Fix coding style in MiniBrowser
2199
2200         * MiniBrowser/gtk/BrowserWindow.c:
2201         (editingCommandCallback):
2202         (insertImageCommandCallback):
2203         (insertLinkCommandCallback):
2204
2205 2017-02-01  Tomas Popela  <tpopela@redhat.com>
2206
2207         [GTK] Add an API to add a custom tab into the print dialog
2208         https://bugs.webkit.org/show_bug.cgi?id=151998
2209
2210         Reviewed by Carlos Garcia Campos.
2211
2212         Add a new WebKitPrintOperation/custom-widget test in TestPrinting
2213         that is testing a newly added API.
2214
2215         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
2216         (testPrintCustomWidget):
2217         (beforeAll):
2218
2219 2017-02-01  Enrique Ocaña González  <eocanha@igalia.com>
2220
2221         [GStreamer][MSE] qtdemux: Update the tfdt patch to the version finally accepted upstream
2222         https://bugs.webkit.org/show_bug.cgi?id=166529
2223
2224         Reviewed by Xabier Rodriguez-Calvar.
2225
2226         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch:
2227         New patch version accepted in GStreamer upstream.
2228
2229 2017-02-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2230
2231         [GTK] Install either libxfont1-dev or libxfont-dev as dependency
2232         https://bugs.webkit.org/show_bug.cgi?id=167498
2233
2234         Reviewed by Carlos Garcia Campos.
2235
2236         Depending on the distro version you can need either libxfont1-dev
2237         or libfont-dev to build with jhbuild.
2238
2239         * gtk/install-dependencies:
2240
2241 2017-01-31  Ryan Haddad  <ryanhaddad@apple.com>
2242
2243         Disable API test WebKit2.WKWebProcessPlugInRangeHandle
2244         https://bugs.webkit.org/show_bug.cgi?id=167594
2245
2246         Unreviewed test gardening.
2247
2248         Disabling this test while we investigate the cause of a timeout on ios-simulator.
2249
2250         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
2251         (TEST):
2252
2253 2017-01-31  Filip Pizlo  <fpizlo@apple.com>
2254
2255         Move slow-running microbenchmarks out of JSTests/microbenchmarks
2256         https://bugs.webkit.org/show_bug.cgi?id=167676
2257
2258         Reviewed by Saam Barati.
2259
2260         * Scripts/run-javascriptcore-tests:
2261         (runJSCStressTests): Add slowMicrobenchmarks.yaml.
2262
2263 2017-01-31  Megan Gardner  <megan_gardner@apple.com>
2264
2265         Make Dump Render Tree not crash
2266         https://bugs.webkit.org/show_bug.cgi?id=167667
2267
2268         DumpRenderTree is crashing when running WK2 tests that it's not supposed to be running. 
2269         DumpRenderTree uses RunLoop::main.dispatch(), but that crashes because it's not set up on iOS.
2270         So we're making use of RunWebThread, which is the correct thing to do on iOS, and it doesn't crash.
2271         This does not fix any tests, it just fixes the crash.
2272         
2273         Reviewed by Simon Fraser.
2274
2275         * DumpRenderTree/TestRunner.cpp:
2276         (TestRunner::callUIScriptCallback):
2277
2278 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
2279
2280         Workaround for simctl install failing to report install failure
2281         https://bugs.webkit.org/show_bug.cgi?id=167654
2282
2283         Reviewed by Daniel Bates.
2284
2285         simctl install will sometimes report success even though install has failed.
2286         To workaround this bug, we attempt an app launch after install to ensure
2287         install has succeeded.
2288
2289         * Scripts/webkitpy/xcode/simulator.py:
2290         (Device.install_app): Attempt app launch after install, retry install if launch fails.
2291         (Device.launch_app): Correct comment.
2292
2293 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
2294
2295         Unreviewed webkitpy fix after r211405.
2296
2297         * Scripts/webkitpy/xcode/simulator.py:
2298         (Device.launch_app): Remove @staticmethod on _log_debug_error.
2299
2300 2017-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2301
2302         Unreviewed. Do not include libwebrtc and qunit in GTK+ tarballs.
2303
2304         * gtk/manifest.txt.in:
2305
2306 2017-01-31  Chris Fleizach  <cfleizach@apple.com>
2307
2308         AX: enable search predication for iOS
2309         https://bugs.webkit.org/show_bug.cgi?id=167558
2310         <rdar://problem/30251367>
2311
2312         Reviewed by Joanmarie Diggs.
2313
2314         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2315         (AccessibilityUIElement::uiElementForSearchPredicate):
2316         * DumpRenderTree/mac/AccessibilityCommonMac.h:
2317         * DumpRenderTree/mac/AccessibilityCommonMac.mm:
2318         (searchPredicateParameterizedAttributeForSearchCriteria):
2319         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2320         (searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
2321         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2322         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
2323         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2324         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
2325         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
2326         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
2327         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2328         (WTR::searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
2329         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2330
2331 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
2332
2333         Workaround for simctl launch bug
2334         https://bugs.webkit.org/show_bug.cgi?id=167613
2335
2336         Reviewed by Daniel Bates.
2337
2338         simctl launch will sometimes fail because of a race condition when many
2339         simulators are being run simultaneously. These failures will always have
2340         an exit code of 1. This change attempts to launch an app multiple times
2341         before reporting a failure to workaround this bug.
2342
2343         * Scripts/webkitpy/xcode/simulator.py:
2344         (Device.launch_app): Execute multiple launch attempts, better logging of failures.
2345
2346 2017-01-30  Alexey Proskuryakov  <ap@apple.com>
2347
2348         Commit queue fails to look at real name aliases for the reviewer
2349         https://bugs.webkit.org/show_bug.cgi?id=167422
2350
2351         Reviewed by Joseph Pecoraro.
2352
2353         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2354         (test_has_valid_reviewer): Added tests.
2355
2356         * Scripts/webkitpy/common/config/committers.py:
2357         (CommitterList._name_to_contributor_map):
2358         Made _name_to_contributor_map include alias names.
2359
2360         * Scripts/webkitpy/common/config/committers_unittest.py:
2361         (CommittersTest.test_contributors_by_fuzzy_match):
2362         Removed subtests that are now obsolete, as these matches are strict. It is not
2363         obvious if distance based fuzzy matching for names is useful at all, but we can
2364         look into that some other time.
2365
2366 2017-01-30  Aakash Jain  <aakash_jain@apple.com>
2367
2368         QueueStatusServer should have an explicit timeout for _fetch_url
2369         https://bugs.webkit.org/show_bug.cgi?id=167467
2370
2371         Reviewed by Alexey Proskuryakov.
2372
2373         * Scripts/webkitpy/common/net/statusserver.py:
2374         (StatusServer._fetch_url): Add an explicit timeout of 300s.
2375
2376 2017-01-30  Kocsen Chung  <kocsen_chung@apple.com>
2377
2378         Add support for Trac instances that host multiple projects.
2379         https://bugs.webkit.org/show_bug.cgi?id=167524
2380
2381         Reviewed by Alexey Proskuryakov.
2382
2383         When multiple projects are hosted on a single Trac instance, the current
2384         behavior will retrieve changesets from all tracked projects.
2385         This patch teaches Trac.js to get project-specific changesets from Trac.
2386         We do this by replacing the parameter `changeset=on` to `repo-projectname=on`
2387         when querying the Trac timeline.
2388
2389         To tell Trac to be aware of multi-project instances we leverage the 
2390         `options` parameter when creating a new instance: 
2391
2392             new Trac("https://mytrac.com/", { projectIdentifier: "tracProjectName" });
2393
2394         If this option is not provided, the original behaviour will prevail.
2395         Additionally, add corresponding tests.
2396
2397         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2398         (Trac): Reason about new optional parameter 'projectIdentifier'.
2399         (Trac.prototype.revisionURL): Given a projectIdentifier, append it to the end of the URL.
2400         (Trac.prototype._xmlTimelineURL): Given a projectIdentifier,
2401         replace default parameter `changeset=on` with `repo-projectname=on`.
2402         (Trac.prototype._convertCommitInfoElementToObject): Fix missing ';'.
2403         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js:
2404         (MockTrac): Add support for instantiating Trac with a projectIdentifier.
2405         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
2406         (setup): Provide a multiple-project MockTrac instance to all test cases for testing.
2407         Add the following tests:
2408             test("revisionURL")
2409             test("revisionURL with Trac Identifier")
2410             test("_xmlTimelineURL")
2411             test("_xmlTimelineURL with Trac Identifier")
2412         (this.view._latestProductiveIteration): Fix missing ';'.
2413
2414 2017-01-30  Myles C. Maxfield  <mmaxfield@apple.com>
2415
2416         Correct spacing regression on inter-element complex path shaping on some fonts
2417         https://bugs.webkit.org/show_bug.cgi?id=166013
2418
2419         Reviewed by Simon Fraser.
2420
2421         Unskip existing tests and make some new tests:
2422         - Testing complex text with no origins
2423         - Testing initial expansions
2424         - Testing the sign of vertical advances
2425
2426         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
2427         (TestWebKitAPI::TEST_F):
2428
2429 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2430
2431         [GTK][EFL] Avoid using a thin directory to create the built product on the archive-built-product step.
2432         https://bugs.webkit.org/show_bug.cgi?id=167596
2433
2434         Reviewed by Daniel Bates.
2435
2436         We avoid needing a thin directory by invoking the zip program with
2437         the list of directories from the build directory to be zipped,
2438         and by using the zip feature to exclude files matching a pattern.
2439
2440         * BuildSlaveSupport/built-product-archive:
2441         (copyBuildFiles):
2442         (createZipFromList):
2443         (archiveBuiltProduct):
2444
2445 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
2446
2447         Use simctl instead of LayoutTestRelay
2448         https://bugs.webkit.org/show_bug.cgi?id=165927
2449
2450         Reviewed by Daniel Bates.
2451
2452         Part 1
2453
2454         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
2455         simulators through simctl (iOS 10 and later), use this functionality instead.
2456
2457         * Scripts/webkitpy/port/base.py:
2458         (Port.__init__): Added _test_runner_process_constructor.
2459         * Scripts/webkitpy/port/darwin.py:
2460         (DarwinPort.app_identifier_from_bundle): Added function to extract bundle ID from plist.
2461         * Scripts/webkitpy/port/driver.py:
2462         (Driver._start): Pass worker_number to server_process so we can look up the correct simulator device to use.
2463         (IOSSimulatorDriver): Deleted.
2464         * Scripts/webkitpy/port/driver_unittest.py:
2465         (DriverTest.test_stop_cleans_up_properly): Set _test_runner_process_constructor for testing.
2466         (DriverTest.test_two_starts_cleans_up_properly): Ditto.
2467         (DriverTest.test_start_actually_starts): Ditto.
2468         * Scripts/webkitpy/port/ios.py:
2469         (IOSSimulatorPort): Remove relay_name.
2470         (IOSSimulatorPort.__init__): Set _test_runner_process_constructor to SimulatorProcess for IOSSimulatorPort.
2471         (IOSSimulatorPort._create_simulators): Formatting change.
2472         (IOSSimulatorPort.relay_path): Deleted.
2473         (IOSSimulatorPort._check_relay): Deleted.
2474         (IOSSimulatorPort._check_port_build): Deleted. Use base class implementation
2475         (IOSSimulatorPort._build_relay): Deleted.
2476         (IOSSimulatorPort._build_driver): Deleted. Use base class implementation
2477         (IOSSimulatorPort._driver_class): Deleted. Use base class implementation
2478         * Scripts/webkitpy/port/ios_unittest.py:
2479         (iosTest.test_32bit): Update test.
2480         (iosTest.test_64bit): Update test.
2481         * Scripts/webkitpy/port/server_process.py:
2482         (ServerProcess.__init__): Added argument worker_number. This class does not make use of it. We will make use of this argument in SimulatorProcess to lookup the associated simulator device.
2483         (ServerProcess._set_file_nonblocking): Added to share common code.
2484         * Scripts/webkitpy/port/server_process_mock.py:
2485         (MockServerProcess.__init__): Added argument worker_number.
2486         * Scripts/webkitpy/port/simulator_process.py: Added.
2487         (SimulatorProcess): Added.
2488         (SimulatorProcess.Popen): Added.
2489         (SimulatorProcess.Popen.__init__): Added. Initialize Popen structure with stdin, stdout, stderr and pid.
2490         (SimulatorProcess.Popen.poll): Added. Check if the process is running.
2491         (SimulatorProcess.Popen.wait): Added. Wait for process to close.
2492         (SimulatorProcess.__init__): Added. Install app to device specified through port and worker_number.
2493         (SimulatorProcess._reset): Added. Unlink fifos.
2494         (SimulatorProcess._start): Added. Launch app on simulator, link fifos.
2495         (SimulatorProcess._kill): Added. Shutdown app on simulator.
2496         * Scripts/webkitpy/xcode/simulator.py:
2497         (Device.__init__): Accept host to run install/launch/terminate.
2498         (Device.install_app): Install app to target Device.
2499         (Device.launch_app): Launch app on target Device.
2500         (Device.terminate_app): Shutdown app on target Device.
2501         (Simulator._parse_devices): Pass host to Device.
2502
2503 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2504
2505         [GTK] pixman fails to compile on Raspberry Pi (GCC crash)
2506         https://bugs.webkit.org/show_bug.cgi?id=167411
2507
2508         Reviewed by Michael Catanzaro.
2509
2510         Disable the ARM iwMMXt fast path for pixman, because it triggers
2511         a GCC bug on the RPi with Raspbian/PIXEL causing a build failure.
2512
2513         * gtk/jhbuild.modules:
2514
2515 2017-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2516
2517         [GTK] Add API to handle the accelerated compositing policy
2518         https://bugs.webkit.org/show_bug.cgi?id=167509
2519
2520         Reviewed by Michael Catanzaro.
2521
2522         Handle new setting in MiniBrowser. The settings dialog doesn't support enum settings so it needs to be handled
2523         as a special case. Also add test cases to the get/set API.
2524
2525         * MiniBrowser/gtk/BrowserSettingsDialog.c:
2526         (hardwareAccelerationPolicyToString):
2527         (stringToHardwareAccelerationPolicy):
2528         (cellRendererChanged):
2529         (browserSettingsDialogConstructed):
2530         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
2531         (testWebKitSettings):
2532
2533 2017-01-29  Andy Estes  <aestes@apple.com>
2534
2535         [QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy
2536         https://bugs.webkit.org/show_bug.cgi?id=167563
2537         <rdar://problem/30253207>
2538
2539         Reviewed by Andreas Kling.
2540
2541         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
2542         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2543         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2544         (runTest):
2545         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
2546         (TEST):
2547
2548 2017-01-29  Dan Bernstein  <mitz@apple.com>
2549
2550         [iOS] Expose WebCore::DataDetection::detectContentInRange WKWebProcessPlugInRangeHandle
2551         https://bugs.webkit.org/show_bug.cgi?id=167565
2552
2553         Reviewed by Sam Weinig.
2554
2555         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2556         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm: Added.
2557         (-[BundleRangeHandleRemoteObject textFromBodyRange:]):
2558         (-[BundleRangeHandleRemoteObject bodyInnerHTMLAfterDetectingData:]):
2559         (TEST):
2560         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandlePlugIn.mm: Added.
2561         (-[BundleRangeHandlePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2562         (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
2563         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandleProtocol.h: Added.
2564
2565 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
2566
2567         Add Link Preload as an off-by-default experimental feature menu item.
2568         https://bugs.webkit.org/show_bug.cgi?id=167201
2569
2570         Reviewed by Ryosuke Niwa.
2571
2572         * DumpRenderTree/mac/DumpRenderTree.mm:
2573         (resetWebPreferencesToConsistentValues):
2574         * DumpRenderTree/win/DumpRenderTree.cpp:
2575         (resetWebPreferencesToConsistentValues):
2576
2577 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
2578
2579         Add User Timing Experimental Feature
2580         https://bugs.webkit.org/show_bug.cgi?id=167542
2581         <rdar://problem/22746307>
2582
2583         Reviewed by Ryosuke Niwa.
2584
2585         * DumpRenderTree/mac/DumpRenderTree.mm:
2586         (enableExperimentalFeatures):
2587         (resetWebPreferencesToConsistentValues):
2588         * DumpRenderTree/win/DumpRenderTree.cpp:
2589         (enableExperimentalFeatures):
2590
2591 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
2592
2593         Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line
2594         https://bugs.webkit.org/show_bug.cgi?id=167519
2595
2596         Reviewed by Ryosuke Niwa.
2597
2598         * QueueStatusServer/templates/statusbubble.html:
2599         To measure the bubbleContainer's width, it must not be wrapping based
2600         on its parent container. So when measuring the width temporarily set
2601         the parent to a very large width so as to not artificially wrap us.
2602         Restore the parent's width after measuring.
2603
2604 2017-01-27  Andy Estes  <aestes@apple.com>
2605
2606         [iOS] Add a test for _WKNSFileManagerExtras
2607         https://bugs.webkit.org/show_bug.cgi?id=167478
2608
2609         Reviewed by Andreas Kling.
2610
2611         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2612         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm: Added.
2613         (expectAttributes):
2614         (TEST):
2615
2616 2017-01-27  Keith Miller  <keith_miller@apple.com>
2617
2618         run-benchmarks should make sure it passes the test url to the right application
2619         https://bugs.webkit.org/show_bug.cgi?id=167533
2620
2621         Reviewed by Joseph Pecoraro.
2622
2623         This fixes an issue when trying to run-benchmark script with the
2624         system default browser set to STP. Previously, it would run
2625         the test in STP rather than the provided build. Now, it should run
2626         in the provided build.
2627
2628         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2629         (OSXSafariDriver.launch_url):
2630
2631 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
2632
2633         [Cocoa] Prepare ComplexTextController for unit testing
2634         https://bugs.webkit.org/show_bug.cgi?id=167493
2635
2636         Reviewed by Simon Fraser.
2637
2638         Addressing post-review comments from Simon Fraser.
2639
2640         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
2641         (TestWebKitAPI::TEST_F):
2642
2643 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
2644
2645         [Cocoa] Prepare ComplexTextController for unit testing
2646         https://bugs.webkit.org/show_bug.cgi?id=167493
2647
2648         Reviewed by Dean Jackson.
2649
2650         Create four unit tests.
2651
2652         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2653         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp: Added.
2654         (TestWebKitAPI::ComplexTextControllerTest::SetUp):
2655         (TestWebKitAPI::TEST_F):
2656
2657 2017-01-26  Chris Dumez  <cdumez@apple.com>
2658
2659         Crash when navigating back to a page in PacheCache when one of its frames has been removed
2660         https://bugs.webkit.org/show_bug.cgi?id=167421
2661         <rdar://problem/30188490>
2662
2663         Reviewed by Darin Adler.
2664
2665         Add a new setting allowing layout tests to enable PageCache in a window
2666         that has an opener, for convenience.
2667
2668         * DumpRenderTree/mac/DumpRenderTree.mm:
2669         (resetWebPreferencesToConsistentValues):
2670         * DumpRenderTree/win/DumpRenderTree.cpp:
2671         (resetWebPreferencesToConsistentValues):
2672         * WebKitTestRunner/TestController.cpp:
2673         (WTR::TestController::resetPreferencesToConsistentValues):
2674
2675 2017-01-26  Keith Miller  <keith_miller@apple.com>
2676
2677         classInfo should take a VM so it is not materialized from the object on each call
2678         https://bugs.webkit.org/show_bug.cgi?id=167424
2679
2680         Rubber Stamped by Michael Saboff.
2681
2682         Previously, classInfo() would get the VM from the target's
2683         MarkedBlock.  Most callers already have a VM on hand, so it is
2684         wasteful to compute the VM from the marked block every time. This
2685         patch refactors some of the most common callers of classInfo(),
2686         jsDynamicCast and inherits to take a VM as well.
2687
2688         * DumpRenderTree/TestRunner.cpp:
2689         (setAudioResultCallback):
2690
2691 2017-01-26  Jer Noble  <jer.noble@apple.com>
2692
2693         Autoplay muted videos stop playback of any streaming app in the background
2694         https://bugs.webkit.org/show_bug.cgi?id=163993
2695         <rdar://problem/29020431>
2696
2697         Reviewed by Eric Carlson.
2698
2699         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2700         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
2701         (TestWebKitAPI::TEST):
2702         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio-and-webaudio.html: Added.
2703
2704 2017-01-26  Ryan Haddad  <ryanhaddad@apple.com>
2705
2706         Disable API test WebKit2.WebsitePoliciesPlayAfterPreventedAutoplay.
2707         https://bugs.webkit.org/show_bug.cgi?id=167466
2708
2709         Unreviewed test gardening.
2710
2711         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2712         (TEST):
2713
2714 2017-01-26  Matt Rajca  <mrajca@apple.com>
2715
2716         Notify clients when the user plays media otherwise prevented from autoplaying
2717         https://bugs.webkit.org/show_bug.cgi?id=167390
2718
2719         Reviewed by Alex Christensen.
2720
2721         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2722         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
2723         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
2724         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2725         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
2726         (TEST):
2727         * TestWebKitAPI/cocoa/TestWKWebView.h:
2728         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2729         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
2730         (-[TestWKWebView waitForLoad]):
2731         (-[TestWKWebView mouseUpAtPoint:]):
2732         * WebKitTestRunner/TestController.cpp:
2733         (WTR::TestController::createOtherPage):
2734         (WTR::TestController::createWebViewWithOptions):
2735
2736 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
2737
2738         Crash when setting custom scale factor.
2739         https://bugs.webkit.org/show_bug.cgi?id=167369
2740
2741         Reviewed by Sam Weinig.
2742
2743         Added API test.
2744
2745         * TestWebKitAPI/PlatformWin.cmake:
2746         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp: Added.
2747         (TestWebKitAPI::WebKitCreateInstance):
2748         (TestWebKitAPI::ScaleWebView::SetUp):
2749         (TestWebKitAPI::ScaleWebView::TearDown):
2750         (TestWebKitAPI::TEST_F):
2751
2752 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2753
2754         run-benchmark nests MotionMark results by the suite name twice
2755         https://bugs.webkit.org/show_bug.cgi?id=164948
2756
2757         Reviewed by Said Abou-Hallawa.
2758
2759         Use a single level MotionMark now that this is the name of the benchmark,
2760         and we no longer have tests that aren't part of the MotionMark suite.
2761
2762         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch:
2763
2764 2017-01-25  Ryan Haddad  <ryanhaddad@apple.com>
2765
2766         Unreviewed, rolling out r211193.
2767
2768         This change broke internal builds.
2769
2770         Reverted changeset:
2771
2772         "Notify clients when the user plays media otherwise prevented
2773         from autoplaying"
2774         https://bugs.webkit.org/show_bug.cgi?id=167390
2775         http://trac.webkit.org/changeset/211193
2776
2777 2017-01-25  Matt Rajca  <mrajca@apple.com>
2778
2779         Notify clients when the user plays media otherwise prevented from autoplaying
2780         https://bugs.webkit.org/show_bug.cgi?id=167390
2781
2782         Reviewed by Alex Christensen.
2783
2784         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2785         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
2786         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
2787         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2788         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
2789         (TEST):
2790         * TestWebKitAPI/cocoa/TestWKWebView.h:
2791         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2792         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
2793         (-[TestWKWebView waitForLoad]):
2794         (-[TestWKWebView mouseUpAtPoint:]):
2795         * WebKitTestRunner/TestController.cpp:
2796         (WTR::TestController::createOtherPage):
2797         (WTR::TestController::createWebViewWithOptions):
2798
2799 2017-01-25  Matt Rajca  <mrajca@apple.com>
2800
2801         [ios-simulator] API test WebKit2.WebsitePoliciesAutoplayEnabled timing out
2802         https://bugs.webkit.org/show_bug.cgi?id=167385
2803
2804         Reviewed by Alex Christensen.
2805
2806         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Avoid arbitrary timeouts in favor of promises.
2807         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html:
2808         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2809         (TEST): Allow inline (rather than full screen) media playback on iOS.
2810
2811 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2812
2813         [GTK] Icon Database should be in private browsing mode for ephemeral web views
2814         https://bugs.webkit.org/show_bug.cgi?id=167414
2815
2816         Reviewed by Michael Catanzaro.
2817
2818         Add a test case to check ephemeral web views don't write favicons to the database.
2819
2820         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
2821         (ephemeralViewLoadChanged):
2822         (testPrivateBrowsing):
2823         (testFaviconDatabase):
2824
2825 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2826
2827         [GTK] Add a private browsing mode to MiniBrowser
2828         https://bugs.webkit.org/show_bug.cgi?id=167413
2829
2830         Reviewed by Michael Catanzaro.
2831
2832         Add -p/--private command line option to create a private instance. Also add CTRL+SHIFT+P shortcut to create
2833         private windows, even on non-private instances.
2834
2835         * MiniBrowser/gtk/BrowserWindow.c:
2836         (webViewTitleChanged): Add [Private] to title window for private windows.
2837         (webViewCreate): Pass web context to browser_window_new.
2838         (openPrivateWindow): Create a new ephemeral web view and add it to a new window.
2839         (browserWindowFinalize): Disconnect web context signal handlers.
2840         (browser_window_init): Add shortcut for opening private window.
2841         (browser_window_new): It now receives the context and connect to download-started here.
2842         (browser_window_get_web_context): Return the context.
2843         * MiniBrowser/gtk/BrowserWindow.h:
2844         * MiniBrowser/gtk/main.c:
2845         (createBrowserTab): Create the web view for the window web context.
2846         (aboutDataScriptMessageReceivedCallback): Do not use the default web context, but the window one.
2847         (aboutDataHandleRequest): Ditto.
2848         (aboutURISchemeRequestCallback): Ditto.
2849         (main): Create ephemeral web context if private command line option is used.
2850
2851 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2852
2853         collectMatchingElementsInFlatTree should not find elements inside an user agent shadow tree
2854         https://bugs.webkit.org/show_bug.cgi?id=167409
2855
2856         Reviewed by Antti Koivisto.
2857
2858         Added a test case for collectMatchingElementsInFlatTree not finding elements inside an user agent shadow tree
2859         as well as tests for the newly added matchingElementInFlatTree.
2860
2861         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp:
2862         (TestWebKitAPI::runJavaScriptAlert):
2863         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
2864         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
2865         * TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html:
2866
2867 2017-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2868
2869         [GTK] Add API to create ephemeral web views and deprecate the private browsing setting
2870         https://bugs.webkit.org/show_bug.cgi?id=167370
2871
2872         Reviewed by Michael Catanzaro.
2873
2874         Add several test cases of ephemeral web views.
2875
2876         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
2877         (testWebViewAuthenticationStorage):
2878         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
2879         (ephemeralViewloadChanged):
2880         (testCookieManagerEphemeral):
2881         (beforeAll):
2882         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
2883         (testWebKitSettings):
2884         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2885         (testWebContextEphemeral):
2886         (ephemeralViewloadChanged):
2887         (testWebContextProxySettings):
2888         (beforeAll):
2889         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2890         (ephemeralViewloadChanged):
2891         (testWebViewEphemeral):
2892         (beforeAll):
2893         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
2894         (ephemeralViewloadChanged):
2895         (testWebsiteDataEphemeral):
2896         (beforeAll):
2897
2898 2017-01-24  Alex Christensen  <achristensen@webkit.org>
2899
2900         REGRESSION (r208902): URLWithUserTypedString returns nil with file URLs
2901         https://bugs.webkit.org/show_bug.cgi?id=167402
2902
2903         Reviewed by Ryosuke Niwa.
2904
2905         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
2906         (TestWebKitAPI::TEST):
2907
2908 2017-01-24  Zalan Bujtas  <zalan@apple.com>
2909
2910         Add simple line layout toggle to MiniBrowser
2911         https://bugs.webkit.org/show_bug.cgi?id=167405
2912
2913         Reviewed by Andreas Kling.
2914
2915         * MiniBrowser/mac/SettingsController.h:
2916         * MiniBrowser/mac/SettingsController.m:
2917         (-[SettingsController _populateMenu]):
2918         (-[SettingsController validateMenuItem:]):
2919         (-[SettingsController toggleSimpleLineLayoutEnabled:]):
2920         (-[SettingsController simpleLineLayoutEnabled]):
2921         * MiniBrowser/mac/WK1BrowserWindowController.m:
2922         (-[WK1BrowserWindowController didChangeSettings]):
2923         * MiniBrowser/mac/WK2BrowserWindowController.m:
2924         (-[WK2BrowserWindowController didChangeSettings]):
2925
2926 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
2927
2928         WKR does not include my nick when commit-queue lands my patch
2929         https://bugs.webkit.org/show_bug.cgi?id=167388
2930
2931         Reviewed by Ryosuke Niwa.
2932
2933         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2934         (NewCommitBot._summarize_commit_log):
2935         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
2936         Perform nickname insertion before grabbing "Patch by" details.
2937         This way we can include the nickname with the full name.
2938
2939 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
2940
2941         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
2942         https://bugs.webkit.org/show_bug.cgi?id=167394
2943
2944         Reviewed by Ryosuke Niwa.
2945
2946         * Scripts/webkitperl/FeatureList.pm:
2947         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2948
2949 2017-01-24  Youenn Fablet  <youenn@apple.com>
2950
2951         [WebRTC] Use HAVE_PTHREAD_COND_TIMEDWAIT_RELATIVE for libwebrtc
2952         https://bugs.webkit.org/show_bug.cgi?id=167353
2953
2954         Reviewed by Alex Christensen.
2955
2956         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2957         (CMakeGenerator.initialize_targets):
2958
2959 2017-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2960
2961         WKR should not confuse Miguel Gomez with Andres Gomez
2962         https://bugs.webkit.org/show_bug.cgi?id=167389
2963
2964         Reviewed by Lucas Forschler.
2965
2966         Andres's email is a substring of Miguel's, causing WKR to credit Miguel's commits to
2967         "mAndres Gomez". Fix this.
2968
2969         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2970         (NewCommitBot._summarize_commit_log): Be stricter about matching emails. SVN logs include a
2971         space on each side of the email address, so expect both spaces to be there before
2972         considering the email for replacement.
2973         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Add a test.
2974
2975 2017-01-24  Matt Rajca  <mrajca@apple.com>
2976
2977         Pass down website autoplay policies to media elements
2978         https://bugs.webkit.org/show_bug.cgi?id=167355
2979
2980         Reviewed by Alex Christensen.
2981
2982         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2983         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/autoplayCheck.html to match our naming conventions.
2984         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html: Added.
2985         * TestWebKitAPI/Tests/WebKit2/test-without-audio-track.mp4: Added.
2986         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2987         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
2988         (TEST):
2989
2990 2017-01-24  Nan Wang  <n_wang@apple.com>
2991
2992         AX: Speak Selection does not work in an iframe
2993         https://bugs.webkit.org/show_bug.cgi?id=166794
2994         <rdar://problem/29913013>
2995
2996         Reviewed by Chris Fleizach.
2997
2998         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2999         (WTR::UIScriptController::retrieveSpeakSelectionContent):
3000         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
3001         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3002         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3003         (WTR::UIScriptController::retrieveSpeakSelectionContent):
3004         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
3005         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3006         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3007         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3008         (-[TestRunnerWKWebView dealloc]):
3009         (-[TestRunnerWKWebView _accessibilityDidGetSpeakSelectionContent:]):
3010         (-[TestRunnerWKWebView accessibilityRetrieveSpeakSelectionContentWithCompletionHandler:]):
3011         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3012         (WTR::UIScriptController::retrieveSpeakSelectionContent):
3013         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
3014
3015 2017-01-24  Daniel Bates  <dabates@apple.com>
3016
3017         StringView.split() should use an iterator design pattern instead of allocating a Vector
3018         https://bugs.webkit.org/show_bug.cgi?id=163225
3019
3020         Reviewed by Darin Adler.
3021
3022         Add unit tests for StringView.split().
3023
3024         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3025         (TestWebKitAPI::stringViewFromLiteral): Moved to the top of the file so that it can be
3026         used in the StringView.split() unit tests.
3027         (TestWebKitAPI::stringViewFromUTF8): Ditto.
3028         (TestWebKitAPI::vectorFromSplitResult): Convenience function to convert a StringView::SplitResult
3029         object to a Vector of String objects.
3030         (TestWebKitAPI::TEST): Added the following tests:
3031             - WTF.StringViewSplitEmptyAndNullStrings
3032             - WTF.StringViewSplitBasic
3033             - WTF.StringViewSplitWithConsecutiveSeparators
3034
3035 2017-01-23  Anders Carlsson  <andersca@apple.com>
3036
3037         The Score Esports crashes on launch
3038         https://bugs.webkit.org/show_bug.cgi?id=167338
3039         rdar://problem/29948645
3040
3041         Reviewed by Dan Bernstein.
3042
3043         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
3044         (TestWebKitAPI::TEST):
3045         Add a test.
3046
3047 2017-01-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3048
3049         [GTK] Add API to WebKitWebsiteDataManager to handle website data
3050         https://bugs.webkit.org/show_bug.cgi?id=146589
3051
3052         Reviewed by Michael Catanzaro.
3053
3054         Add about:data handler to MiniBrowser to manually test the website data API. Also add unit tests to test all the
3055         new API, moving the WebKitWebsiteDataManager configuration API to the new file too.
3056
3057         * MiniBrowser/gtk/BrowserWindow.c:
3058         (webViewDecidePolicy):
3059         (newTabCallback):
3060         * MiniBrowser/gtk/main.c:
3061         (createBrowserTab):
3062         (aboutDataRequestFree):
3063         (aboutDataRequestNew):
3064         (aboutDataRequestForView):
3065         (websiteDataRemovedCallback):
3066         (websiteDataClearedCallback):
3067         (aboutDataScriptMessageReceivedCallback):
3068         (domainListFree):
3069         (aboutDataFillTable):
3070         (gotWebsiteDataCallback):
3071         (aboutDataHandleRequest):
3072         (aboutURISchemeRequestCallback):
3073         (main):
3074         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3075         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3076         (serverCallback):
3077         (beforeAll):
3078         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp: Added.
3079         (serverCallback):
3080         (WebsiteDataTest::WebsiteDataTest):
3081         (WebsiteDataTest::~WebsiteDataTest):
3082         (WebsiteDataTest::fetch):
3083         (WebsiteDataTest::remove):
3084         (WebsiteDataTest::clear):
3085         (testWebsiteDataConfiguration):
3086         (testWebsiteDataCache):
3087         (testWebsiteDataStorage):
3088         (testWebsiteDataDatabases):
3089         (testWebsiteDataAppcache):
3090         (beforeAll):
3091         (afterAll):
3092
3093 2017-01-23  Commit Queue  <commit-queue@webkit.org>
3094
3095         Unreviewed, rolling out r211062.
3096         https://bugs.webkit.org/show_bug.cgi?id=167354
3097
3098         broke API tests (Requested by alexchristensen on #webkit).
3099
3100         Reverted changeset:
3101
3102         "Pass down website autoplay policies to media elements"
3103         https://bugs.webkit.org/show_bug.cgi?id=167132
3104         http://trac.webkit.org/changeset/211062
3105
3106 2017-01-23  Alex Christensen  <achristensen@webkit.org>
3107
3108         URLParser should fail to parse percent-encoded invalid UTF-8 sequences
3109         https://bugs.webkit.org/show_bug.cgi?id=167330
3110
3111         Reviewed by Tim Horton.
3112
3113         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3114         (TestWebKitAPI::TEST_F):
3115
3116 2017-01-23  Alex Christensen  <achristensen@webkit.org>
3117
3118         Make URLs with non-special schemes and a query or fragment but no slash after the host more compatible
3119         https://bugs.webkit.org/show_bug.cgi?id=167317
3120
3121         Reviewed by Sam Weinig.
3122
3123         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3124         (TestWebKitAPI::TEST_F):
3125
3126 2017-01-23  Jonathan Bedard  <jbedard@apple.com>
3127
3128         svn-create-patch should emit properties when files are moved or copied
3129         https://bugs.webkit.org/show_bug.cgi?id=167264
3130
3131         Reviewed by Daniel Bates.
3132
3133         * Scripts/svn-create-patch:
3134         (manufacturePatchForAdditionWithHistory): Diff the source file against nothing to get properties.
3135
3136 2017-01-23  Youenn Fablet  <youenn@apple.com>
3137
3138         [WebRTC] Filter libwebrtc link flags
3139         https://bugs.webkit.org/show_bug.cgi?id=167287
3140
3141         Reviewed by Alex Christensen.
3142
3143         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
3144         (CMakeGenerator._compute_link_flags):
3145         (CMakeGenerator._compute_link_flags.keep_flag):
3146         (CMakeGenerator._generate_compile_target_options):
3147
3148 2017-01-23  Youenn Fablet  <youennf@gmail.com>
3149
3150         [WebRTC] Make VP8 optional in libwebrtc
3151         https://bugs.webkit.org/show_bug.cgi?id=167257
3152
3153         Reviewed by Darin Adler.
3154
3155         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
3156         (CMakeGenerator.remove_libvpx): Adding vp8_noop.cc to the build system.
3157
3158 2017-01-23  Jer Noble  <jer.noble@apple.com>
3159
3160         Video details does not apear and missing scrubber in Control Center
3161         https://bugs.webkit.org/show_bug.cgi?id=167233
3162
3163         Reviewed by Alex Christensen.
3164
3165         Refactor TestWKWebViewMac to work on PLATFORM(IOS). Add a new test to
3166         NowPlayingControlTests for iOS.
3167
3168         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3169         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
3170         (-[NowPlayingTestWebView setWindowVisible:]):
3171         (TestWebKitAPI::TEST):
3172         * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm:
3173         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
3174         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
3175         * TestWebKitAPI/cocoa/TestWKWebView.h: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.h.
3176         * TestWebKitAPI/cocoa/TestWKWebView.mm: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.mm.
3177         (SOFT_LINK_CLASS):
3178         (-[TestMessageHandler addMessage:withHandler:]):
3179         (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
3180         (__simulated_forceClickAssociatedEventsMask):
3181         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
3182         (-[TestWKWebViewHostWindow isKeyWindow]):
3183         (-[TestWKWebViewHostWindow makeKeyWindow]):
3184         (-[TestWKWebViewHostWindow resignKeyWindow]):
3185         (-[TestWKWebView initWithFrame:]):
3186         (-[TestWKWebView initWithFrame:configuration:]):
3187         (-[TestWKWebView _setUpTestWindow:]):
3188         (-[TestWKWebView performAfterReceivingMessage:action:]):
3189         (-[TestWKWebView loadTestPageNamed:]):
3190         (-[TestWKWebView synchronouslyLoadTestPageNamed:]):
3191         (-[TestWKWebView stringByEvaluatingJavaScript:]):
3192         (-[TestWKWebView waitForMessage:]):
3193         (-[TestWKWebView performAfterLoading:]):
3194         (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
3195         (-[TestWKWebView typeCharacter:]):
3196
3197 2017-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3198
3199         Unreviewed. Bring back gtk-doc error messages after r209981.
3200
3201         Since r209981, if gtk-doc shows warnings the build fails but those warnings are not printed to stdout so it's
3202         impossible to know what's wrong.
3203
3204         * gtk/gtkdoc.py:
3205         (GTKDoc._run_command): Make print_output True by default again and use debug instead of info to log "Running" messages.
3206
3207 2017-01-20  Youenn Fablet  <youennf@gmail.com>
3208
3209         [WebRTC] Update build system to make G711 optional in libwebrtc
3210         https://bugs.webkit.org/show_bug.cgi?id=167256
3211
3212         Reviewed by Alex Christensen.
3213
3214         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
3215         (CMakeGenerator.remove_webrtc_g711): Adding a missing file to the build system as this file includes generic pcm encoder functions.
3216
3217 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
3218
3219         Cleanup RuntimeEnabledFeatures
3220         https://bugs.webkit.org/show_bug.cgi?id=167228
3221
3222         Reviewed by Simon Fraser.
3223
3224         * DumpRenderTree/mac/DumpRenderTree.mm:
3225         (enableExperimentalFeatures):
3226         (resetWebPreferencesToConsistentValues):
3227         (setWebPreferencesForTestOptions):
3228         (resetWebViewToConsistentStateBeforeTesting):
3229         * DumpRenderTree/win/DumpRenderTree.cpp:
3230         (enableExperimentalFeatures):
3231         (resetWebPreferencesToConsistentValues):
3232         More closely match WebKitTestRunner initialization of preferences
3233         for experimental features.
3234
3235 2017-01-20  Alex Christensen  <achristensen@webkit.org>
3236
3237         Build Fix for Windows DumpRenderTree after r210976
3238         https://bugs.webkit.org/show_bug.cgi?id=167115
3239
3240         * DumpRenderTree/win/DumpRenderTree.cpp:
3241         (resetWebPreferencesToConsistentValues):
3242
3243 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
3244
3245         Remove outdated ENABLE(CSP_NEXT) build flag
3246         https://bugs.webkit.org/show_bug.cgi?id=167252
3247
3248         Reviewed by Brent Fulgham.
3249
3250         * Scripts/webkitperl/FeatureList.pm:
3251         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3252
3253 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
3254
3255         Build Fix for Windows DumpRenderTree after r210976
3256
3257         * DumpRenderTree/win/DumpRenderTree.cpp:
3258         (resetWebPreferencesToConsistentValues):
3259
3260 2017-01-20  Antoine Quint  <graouts@apple.com>
3261
3262         Web Animations should be off by default and enabled as an experimental feature
3263         https://bugs.webkit.org/show_bug.cgi?id=167115
3264         <rdar://problem/30048963>
3265
3266         Reviewed by Joseph Pecoraro.
3267
3268         Turn Web Animations on in DRT.
3269
3270         * DumpRenderTree/mac/DumpRenderTree.mm:
3271         (resetWebPreferencesToConsistentValues):
3272         * DumpRenderTree/win/DumpRenderTree.cpp:
3273         (resetWebPreferencesToConsistentValues):
3274
3275 2017-01-20  Youenn Fablet  <youenn@apple.com>
3276
3277         [WebRTC] Add libwebrtc build infrastructure
3278         https://bugs.webkit.org/show_bug.cgi?id=167207
3279
3280         Reviewed by Alex Christensen.
3281
3282         Adding a script doing the libwebrtc project json to CMake file conversion.
3283
3284         * Scripts/generate-libwebrtc-cmake: Added.
3285         * Scripts/webkitpy/libwebrtc/__init__.py: Added.
3286         * Scripts/webkitpy/libwebrtc/generate_cmake.py: Added.
3287
3288 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
3289
3290         Mini Browser: Show tooltip for Experimental Features
3291         https://bugs.webkit.org/show_bug.cgi?id=167225
3292
3293         Reviewed by Alex Christensen.
3294
3295         * MiniBrowser/mac/SettingsController.m:
3296         (-[SettingsController _populateMenu]):
3297         Include the full details string as a tooltip.
3298
3299 2017-01-20  Per Arne Vollan  <pvollan@apple.com>
3300
3301         [Win] Test output results should not be written twice.
3302         https://bugs.webkit.org/show_bug.cgi?id=167197
3303
3304         Reviewed by Brent Fulgham.
3305
3306         Prevent test output from being written twice by returning early from
3307         the dump() function, if it already has been called.
3308         This patch also adds a missing newline to a test output line. 
3309         
3310         * DumpRenderTree/win/DumpRenderTree.cpp:
3311         (dump):
3312
3313 2017-01-20  Antoine Quint  <graouts@apple.com>
3314
3315         [Modern Media Controls] Turn modern media controls on by default
3316         https://bugs.webkit.org/show_bug.cgi?id=165668
3317
3318         Reviewed by Dean Jackson.
3319
3320         Enabled modern media controls by default in test runners.
3321
3322         * DumpRenderTree/TestOptions.h:
3323         * WebKitTestRunner/TestOptions.h:
3324
3325 2017-01-19  Chris Dumez  <cdumez@apple.com>
3326
3327         iterable<> should be enabled on WK1
3328         https://bugs.webkit.org/show_bug.cgi?id=167221
3329         <rdar://problem/30108531>
3330
3331         Reviewed by Youenn Fablet.
3332
3333         * DumpRenderTree/mac/DumpRenderTree.mm:
3334         (resetWebPreferencesToConsistentValues):
3335         * DumpRenderTree/win/DumpRenderTree.cpp:
3336         (resetWebPreferencesToConsistentValues):
3337         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3338         (WTR::InjectedBundle::beginTesting):
3339         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3340         (WTR::TestRunner::setDOMIteratorEnabled): Deleted.
3341         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3342
3343 2017-01-19  Aakash Jain  <aakash_jain@apple.com>
3344
3345         Ensure status server logs go to log file
3346         https://bugs.webkit.org/show_bug.cgi?id=167210
3347
3348         Reviewed by Alexey Proskuryakov.
3349
3350         * Scripts/webkitpy/common/net/statusserver.py:
3351         (StatusServer.next_work_item): Change log level from debug to info in
3352         order to facilitate deubgging issues.
3353         (StatusServer.update_work_items): Same.
3354
3355 2017-01-19  Megan Gardner  <megan_gardner@apple.com>
3356
3357         Additional selection tests and interpolation fix
3358         https://bugs.webkit.org/show_bug.cgi?id=167171
3359
3360         Reviewed by Simon Fraser.
3361
3362         We weren't adding the final event when interpolating event streams.
3363
3364         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3365         (-[HIDEventGenerator interpolatedEvents:]):
3366
3367 2017-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
3368
3369         [Cocoa] Variation fonts are erroneously disabled on iOS
3370         https://bugs.webkit.org/show_bug.cgi?id=167172
3371
3372         Reviewed by Simon Fraser.
3373
3374         OpenSource builders don't seem to understand sdk=embedded*.
3375
3376         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3377
3378 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3379
3380         Unreviewed. Fix GTK+ unit tests failing since r210531.
3381
3382         Avoid using paths to files that don't actually exist.
3383
3384         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
3385         (testWebKitConsoleMessageNetworkError):
3386         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
3387         (testContextMenuDefaultMenu):
3388         * TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg: Added.
3389         * TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json: Added.
3390         * TestWebKitAPI/Tests/WebKit2Gtk/resources/tracks.ogg: Added.
3391
3392 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3393
3394         [GTK] Provide API to set proxy settings
3395         https://bugs.webkit.org/show_bug.cgi?id=128674
3396
3397         Reviewed by Michael Catanzaro.
3398
3399         Add tests for new proxy settings API.
3400
3401         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3402         (serverCallback):
3403         (ProxyTest::ProxyTest):
3404         (ProxyTest::~ProxyTest):
3405         (ProxyTest::loadURIAndGetMainResourceData):
3406         (ProxyTest::proxyServerPortAsString):
3407         (testWebContextProxySettings):
3408         (beforeAll):
3409
3410 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
3411
3412         Add back my old email address so old commits will still match it.
3413
3414         * Scripts/webkitpy/common/config/contributors.json:
3415
3416 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
3417
3418         Remove my old email address from contributors.json and watchlist.
3419
3420         * Scripts/validate-committer-lists:
3421         (CommitterListFromGit): Change the mapping to the correct email.
3422         * Scripts/webkitpy/common/config/contributors.json:
3423         * Scripts/webkitpy/common/config/watchlist:
3424
3425 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
3426
3427         Unreviewed, rolling out r210848.
3428
3429         This change introduced media-related LayoutTest failures and
3430         crashes on macOS.
3431
3432         Reverted changeset:
3433
3434         "[Modern Media Controls] Turn modern media controls on by
3435         default"
3436         https://bugs.webkit.org/show_bug.cgi?id=165668
3437         http://trac.webkit.org/changeset/210848
3438
3439 2017-01-18  Andreas Kling  <akling@apple.com>
3440
3441         Document::securityOrigin() should return a reference.
3442         <https://webkit.org/b/167124>
3443
3444         Reviewed by Sam Weinig.
3445
3446         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
3447         (TestWebKitAPI::TEST_F):
3448
3449 2017-01-18  Per Arne Vollan  <pvollan@apple.com>
3450
3451         [Win] Clipboard tests are flaky.
3452         https://bugs.webkit.org/show_bug.cgi?id=167088
3453
3454         Reviewed by Brent Fulgham.
3455
3456         Tests involving the clipboard are flaky when running with multiple DRTs, since the clipboard is global. 
3457         We can fix this by assigning each DRT a separate window station (each window station has its own clipboard).
3458
3459         * DumpRenderTree/win/DumpRenderTree.cpp:
3460         (main):
3461
3462 2017-01-18  Antoine Quint  <graouts@apple.com>
3463
3464         [Modern Media Controls] Turn modern media controls on by default
3465         https://bugs.webkit.org/show_bug.cgi?id=165668
3466
3467         Reviewed by Dean Jackson.
3468
3469         Enabled modern media controls by default in test runners. 
3470
3471         * DumpRenderTree/TestOptions.h:
3472         * WebKitTestRunner/TestOptions.h:
3473
3474 2017-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
3475
3476         Unreviewed, rolling out r210834
3477         https://bugs.webkit.org/show_bug.cgi?id=165668
3478
3479         It introduced dozens of test timeouts.
3480
3481         Reverted changeset:
3482         "[Modern Media Controls] Turn modern media controls on by default"
3483         https://bugs.webkit.org/show_bug.cgi?id=165668
3484         http://trac.webkit.org/changeset/210834
3485
3486 2017-01-17  Antoine Quint  <graouts@apple.com>
3487
3488         [Modern Media Controls] Turn modern media controls on by default
3489         https://bugs.webkit.org/show_bug.cgi?id=165668
3490
3491         Reviewed by Dean Jackson.
3492
3493         Enabled modern media controls by default in test runners. 
3494
3495         * DumpRenderTree/TestOptions.h:
3496         * WebKitTestRunner/TestOptions.h:
3497
3498 2017-01-17  Chris Dumez  <cdumez@apple.com>
3499
3500         Document title changed twice when setting document.title
3501         https://bugs.webkit.org/show_bug.cgi?id=167065
3502
3503         Reviewed by Darin Adler.
3504
3505         Add WebKit2GTK API test that was written by Michael Catanzaro.
3506
3507         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3508         (testWebViewTitleChange):
3509         (beforeAll):
3510
3511 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
3512
3513         ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
3514         https://bugs.webkit.org/show_bug.cgi?id=116551
3515         <rdar://problem/13949830>
3516
3517         Reviewed by Alex Christensen.
3518
3519         * Scripts/webkitperl/FeatureList.pm:
3520         Remove stale RESOURCE_TIMING references which are now a runtime enabled feature
3521         that is part of the existing WEB_TIMING feature.
3522
3523         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3524
3525 2017-01-17  Jonathan Bedard  <jbedard@apple.com>
3526
3527         'webkit-patch post' no longer works with moved/copied files
3528         https://bugs.webkit.org/show_bug.cgi?id=166914
3529         <rdar://problem/29979707>
3530
3531         Reviewed by Daniel Bates.
3532
3533         SVN 1.9 has a bug where when a file has been moved or copied, the svn diff of the new
3534         file outputs only the "Index:" line with an empty body.  This workaround
3535         ignores such output from svn diff.  A issue has been filed with SVN, a link to the
3536         public email list tracking this bug is below.
3537         http://mail-archives.apache.org/mod_mbox/subversion-users/201701.mbox/%3cCF9BDE0A-7454-4405-8259-1120C6B76A03@apple.com%3e
3538         
3539
3540         * Scripts/svn-create-patch:
3541         (generateDiff): Ignore an "Index:" line with an empty body.
3542
3543 2017-01-16  Joseph Pecoraro  <pecoraro@apple.com>
3544
3545         Remove the REQUEST_ANIMATION_FRAME flag
3546         https://bugs.webkit.org/show_bug.cgi?id=156980
3547         <rdar://problem/25906849>
3548
3549         Reviewed by Simon Fraser.
3550
3551         * Scripts/webkitperl/FeatureList.pm:
3552         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3553
3554 2017-01-15  Sam Weinig  <sam@webkit.org>
3555
3556         Add the ability to use numbers in makeString()
3557         https://bugs.webkit.org/show_bug.cgi?id=167087
3558
3559         Reviewed by Darin Adler.
3560
3561         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3562         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Added.
3563         Add tests for StringConcatenate, focusing on new numeric additions.
3564
3565 2017-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
3566
3567         Unreviewed, remove stale comment.
3568
3569         This test was fixed by r163173.
3570
3571         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3572
3573 2017-01-14  Yusuke Suzuki  <utatane.tea@gmail.com>
3574
3575         Annotate large string tests with largeHeap
3576         https://bugs.webkit.org/show_bug.cgi?id=167054
3577
3578         Reviewed by Filip Pizlo.
3579
3580         * Scripts/run-javascriptcore-tests:
3581         * Scripts/run-jsc-stress-tests:
3582
3583 2017-01-14  Joseph Pecoraro  <pecoraro@apple.com>
3584
3585         Remove stale references to ENABLE_ES6_GENERATORS and ENABLE_PROMISES
3586         https://bugs.webkit.org/show_bug.cgi?id=167043
3587
3588         Reviewed by Darin Adler.
3589
3590         * Scripts/webkitperl/FeatureList.pm:
3591
3592 2017-01-13  Joseph Pecoraro  <pecoraro@apple.com>
3593
3594         Remove ENABLE(DETAILS_ELEMENT) guards
3595         https://bugs.webkit.org/show_bug.cgi?id=167042
3596
3597         Reviewed by Alex Christensen.
3598
3599         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3600
3601 2017-01-13  Said Abou-Hallawa  <sabouhallawa@apple.com>
3602
3603         26 MotionMark performance tests failing
3604         https://bugs.webkit.org/show_bug.cgi?id=166854
3605
3606         Reviewed by Ryosuke Niwa.
3607
3608         Unrelated change. This is the last place that we need to rename Animometer
3609         to MotionMark.
3610
3611         * Scripts/webkitpy/common/config/watchlist:
3612
3613 2017-01-13  Yusuke Suzuki  <utatane.tea@gmail.com>
3614
3615         run-jsc-benchmarks' echo should have -e option
3616         https://bugs.webkit.org/show_bug.cgi?id=167009
3617
3618         Reviewed by Sam Weinig.
3619
3620         echo requires `-e` option to use escape sequence.
3621         Without it, in some environment (in my Fedora 25), the escape sequence is not
3622         recognized and just dumped as `\c` etc.
3623
3624         * Scripts/run-jsc-benchmarks:
3625
3626 2017-01-12  Chris Dumez  <cdumez@apple.com>
3627
3628         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
3629         https://bugs.webkit.org/show_bug.cgi?id=166995
3630
3631         Reviewed by Jer Noble.
3632
3633         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
3634         as some people are having trouble building without it.
3635
3636         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3637
3638 2017-01-12  Sam Weinig  <sam@webkit.org>
3639
3640         Add the ability to filter the set of bindings tests you want to run
3641         https://bugs.webkit.org/show_bug.cgi?id=166977
3642
3643         Reviewed by Tim Horton.
3644
3645