2011-03-15 Ilya Sherman <isherman@chromium.org>
[WebKit-https.git] / Tools / ChangeLog
1 2011-03-15  Ilya Sherman  <isherman@chromium.org>
2
3         Reviewed by Tony Chang.
4
5         Autofilled form elements are assigned fixed background color but not text color
6         https://bugs.webkit.org/show_bug.cgi?id=48382
7
8         * DumpRenderTree/LayoutTestController.cpp:
9         (setAutofilledCallback): Added.
10         (LayoutTestController::staticFunctions):
11         * DumpRenderTree/LayoutTestController.h:
12         * DumpRenderTree/chromium/LayoutTestController.cpp:
13         (LayoutTestController::LayoutTestController):
14         (LayoutTestController::setAutofilled): Added.
15         * DumpRenderTree/chromium/LayoutTestController.h:
16         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
17         (LayoutTestController::setAutofilled): Added.
18         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
19         (LayoutTestController::setAutofilled): Added.
20         (LayoutTestController::setValueForUser): Style tweak.
21         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
22         (LayoutTestController::setAutofilled): Added (stub).
23         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
24         (LayoutTestController::setAutofilled): Added (stub).
25
26 2011-03-15  Dan Bernstein  <mitz@apple.com>
27
28         Build fix after r81135.
29
30         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
31
32 2011-03-15  Dan Bernstein  <mitz@apple.com>
33
34         Build fix after r81135.
35
36         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
37         * WebKitTestRunner/mac/TestControllerMac.mm:
38         * WebKitTestRunner/mac/TestInvocationMac.mm:
39         * WebKitTestRunner/mac/main.mm:
40
41 2011-03-15  Balazs Kelemen  <kbalazs@webkit.org>
42
43         Reviewed by Adam Barth.
44
45         REGRESSION(80977): breaks Qt ARMv7 Linux Release bot
46         https://bugs.webkit.org/show_bug.cgi?id=56349
47
48         * QtTestBrowser/QtTestBrowser.pro: Link against fontconfig
49         on platforms where we use it. Copied from DumpRenderTree.pro.
50
51 2011-03-15  Dan Bernstein  <mitz@apple.com>
52
53         Build fix after r81135.
54
55         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
56         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
57
58 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
59
60         Reviewed by Darin Adler.
61
62         Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
63         info into the headers rather than in export symbol definition files, but disable it on 
64         all platforms initially so we can deal with port build issues one port at a time.
65         
66         https://bugs.webkit.org/show_bug.cgi?id=27551
67
68         * DumpRenderTree/cg/ImageDiffCG.cpp:
69         * DumpRenderTree/chromium/config.h:
70         * DumpRenderTree/config.h:
71         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
72         * TestWebKitAPI/TestWebKitAPIPrefix.h:
73         * WebKitAPITest/HostWindow.cpp:
74         * WebKitAPITest/TestsController.cpp:
75         * WebKitAPITest/config.h: Added.
76         * WebKitAPITest/main.cpp:
77         * WebKitAPITest/tests/WebViewDestruction.cpp:
78         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp:
79         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
80         * WebKitTestRunner/InjectedBundle/GCController.cpp:
81         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
82         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
83         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
84         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
85         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
86         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
87         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
88         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp:
89         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp:
90         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
91         * WebKitTestRunner/TestController.cpp:
92         * WebKitTestRunner/TestInvocation.cpp:
93         * WebKitTestRunner/config.h: Added.
94         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
95         * WebKitTestRunner/qt/TestControllerQt.cpp:
96         * WebKitTestRunner/qt/TestInvocationQt.cpp:
97         * WebKitTestRunner/qt/main.cpp:
98         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
99         * WebKitTestRunner/win/TestControllerWin.cpp:
100         * WebKitTestRunner/win/TestInvocationWin.cpp:
101         * WebKitTestRunner/win/main.cpp:
102         * wx/build/settings.py:
103
104 2011-03-15  Hayato Ito  <hayato@chromium.org>
105
106         Reviewed by Shinichiro Hamaji.
107
108         [NRWT] Add support for reftests to new-run-webkit-tests.
109
110         https://bugs.webkit.org/show_bug.cgi?id=55457
111
112         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
113         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
114         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
115         * Scripts/webkitpy/layout_tests/port/base.py:
116         * Scripts/webkitpy/layout_tests/port/dryrun.py:
117         * Scripts/webkitpy/layout_tests/port/test.py:
118         * Scripts/webkitpy/layout_tests/port/test_files.py:
119         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
120
121 2011-03-15  Alejandro G. Castro  <alex@igalia.com>
122
123         Reviewed by Martin Robinson.
124
125         [GTK] Fix compilation warning after r80892
126         https://bugs.webkit.org/show_bug.cgi?id=56302
127
128         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
129         (LayoutTestController::originsWithLocalStorage):
130
131 2011-03-15  Robert Hogan  <robert@webkit.org>
132
133         Reviewed by Adam Barth.
134
135         Document the qmakearg argument, and hint how to build webkit2 on Qt
136         https://bugs.webkit.org/show_bug.cgi?id=56326
137
138         * Scripts/build-webkit: add --qmakearg to build-webkit --help
139
140 2011-03-15  Adam Roben  <aroben@apple.com>
141
142         Make Windows 7 Release (Tests) a core builder
143
144         We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
145         give it a few more days of greenness first.
146
147         Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder
148
149         Reviewed by Sam Weinig.
150
151         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
152         (BuildBot): Added a regexp to match Windows 7 Release (Tests).
153
154         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
155         (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
156         Updated the core regexps to match the buildbot module. Updated the expected results to match
157         the current set of core builders.
158
159 2011-03-14  Adam Roben  <aroben@apple.com>
160
161         Add forgotten file from r81116
162
163         * TestWebKitAPI/Configurations/TestWebKitAPICFNetwork.vsprops: Added.
164
165 2011-03-14  Sam Weinig  <sam@webkit.org>
166
167         Reviewed by Adam Roben.
168
169         about:blank fake responses don't get serialized when sent the UIProcess
170         <rdar://problem/9108119>
171         https://bugs.webkit.org/show_bug.cgi?id=56357
172
173         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: Added.
174         (TestWebKitAPI::decidePolicyForResponse):
175         (TestWebKitAPI::TEST):
176         Add test that loads of about:blank have a response with a MIMEType of text/html.
177
178         * TestWebKitAPI/PlatformUtilities.h:
179         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
180         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
181         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
182         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
183         Add helper to get the MIMEType from a WKURLResponse.
184
185         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
186         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
187         Add new files.
188
189 2011-03-14  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
190
191         Reviewed by Kenneth Rohde Christiansen.
192
193         [Qt] Command-line options for QGLWidget and WebGL to QtTestBrowser
194         https://bugs.webkit.org/show_bug.cgi?id=56006
195
196         * QtTestBrowser/launcherwindow.cpp:
197         (LauncherWindow::initializeView):
198         * QtTestBrowser/main.cpp:
199         (LauncherApplication::handleUserOptions):
200
201 2011-03-14  James Kozianski  <koz@chromium.org>
202
203         Reviewed by Ojan Vafai.
204
205         Add method to make BuildBot return test outputs
206         https://bugs.webkit.org/show_bug.cgi?id=54374
207
208         The Builder.latest_cached_build will be used by the new rebaseline
209         script to determine the build to use baselines from.
210
211         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
212         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
213
214 2011-03-14  Adam Roben  <aroben@apple.com>
215
216         Test that WKBundlePageCanHandleRequest returns true for empty document URLs
217
218         Reviewed by Sam Weinig.
219
220         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp: Added.
221         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Store the result of the test.
222         (TestWebKitAPI::setInjectedBundleClient): Hook up our callback.
223         (TestWebKitAPI::TEST): Register "emptyscheme" as an empty document scheme, load a page to
224         ensure the web process is initialized, then ask the bundle to run the test and assert that
225         it succeeded.
226
227         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp: Added.
228         (TestWebKitAPI::CanHandleRequestTest::CanHandleRequestTest): Just call up to the base class.
229         (TestWebKitAPI::canHandleURL): Helper function to test whether WebKit2 claims to be able to
230         handle a given URL.
231         (TestWebKitAPI::runTest): Check that empty document URLs can be handled (and that an unknown
232         URL type cannot be handled).
233         (TestWebKitAPI::CanHandleRequestTest::didReceiveMessage): Run the test and return the
234         result.
235
236         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
237         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
238         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
239         Added new files to the project.
240
241 2011-03-14  Sheriff Bot  <webkit.review.bot@gmail.com>
242
243         Unreviewed, rolling out r81094.
244         http://trac.webkit.org/changeset/81094
245         https://bugs.webkit.org/show_bug.cgi?id=56355
246
247         Broke the chromium DRT related build. (Requested by dave_levin
248         on #webkit).
249
250         * DumpRenderTree/chromium/DumpRenderTree.cpp:
251         (main):
252         * DumpRenderTree/chromium/LayoutTestController.cpp:
253         (LayoutTestController::LayoutTestController):
254         (LayoutTestController::layerTreeAsText):
255         * DumpRenderTree/chromium/LayoutTestController.h:
256         * DumpRenderTree/chromium/TestShell.cpp:
257         (TestShell::runFileTest):
258         (TestShell::dump):
259         * DumpRenderTree/chromium/TestShell.h:
260         (TestParams::TestParams):
261
262 2011-03-14  Daniel Sievers  <sievers@google.com>
263
264         Reviewed by Simon Fraser.
265
266         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
267         https://bugs.webkit.org/show_bug.cgi?id=56139
268
269         * DumpRenderTree/chromium/DumpRenderTree.cpp:
270         (main):
271         * DumpRenderTree/chromium/LayoutTestController.cpp:
272         (LayoutTestController::LayoutTestController):
273         (LayoutTestController::layerTreeAsText):
274         * DumpRenderTree/chromium/LayoutTestController.h:
275         (LayoutTestController::setShowDebugLayerTree):
276         * DumpRenderTree/chromium/TestShell.cpp:
277         (TestShell::runFileTest):
278         (TestShell::dump):
279         * DumpRenderTree/chromium/TestShell.h:
280         (TestParams::TestParams):
281
282 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
283
284         Reviewed by Adam Roben.
285
286         [Qt][WK2]Unbreak InjectedBundle on Qt
287         https://bugs.webkit.org/show_bug.cgi?id=54109
288
289         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
290         (WTR::InjectedBundlePage::willSendRequestForFrame): Use new WebKit2
291         API's instead of KURL to analyze the URL.
292         * WebKitTestRunner/StringFunctions.h:
293         (WTR::adoptWK): Moved from InjectedBundlePage.cpp to make it available globally
294         in the WebKitTestRunner project.
295         (WTR::toWK): Use adoptWK.
296         (WTR::operator<<): Added helper for printing a WKURL.
297         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Do not link
298         against WebCore.
299
300 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
301
302         Reviewed by Kenneth Rohde Christiansen.
303
304         check-webkit-style falsely should not complain about WebKit2 API headers in the Shared directory
305         https://bugs.webkit.org/show_bug.cgi?id=56321
306
307         * Scripts/webkitpy/style/checker.py: Add the patch "Source/WebKit2/Shared/API/c"
308         to the list of exceptions for WebKit2 C API headers.
309
310 2011-03-14  Adam Roben  <aroben@apple.com>
311
312         Show the list of recent leaky builds in reverse chronological order
313
314         Previously they were being shown in a deterministic but surprising order based on
315         lexicographically sorting the build offsets (-1, -10, -2, -3...).
316
317         Fixes <http://webkit.org/b/56342> Leaks Viewer shows recent builds in a strange order
318
319         Reviewed by Darin Adler.
320
321         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
322         (RecentBuildsLoader.prototype.start): Sort the builds by revision before passing them to our
323         callback.
324
325 2011-03-14  Adam Roben  <aroben@apple.com>
326
327         Show a list of up to 10 recent leaky builds when Leaks Viewer loads
328
329         Fixes <http://webkit.org/b/56043> Leaks Viewer should present a list of recent builds to
330         analyze
331
332         Reviewed by David Kilzer and Joe Pecoraro.
333
334         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
335         (#url-prompt): Made this a bit taller to make room for the list of builds.
336
337         (#recent-builds-loading-indicator):
338         (#recent-builds-list):
339         Added styles for the build list and loading indicator.
340
341         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
342         (LeaksViewer.loaded): Pass the URL from the query through decodeURIComponent before loading
343         it. This will unescape it.
344         (LeaksViewer.urlPromptButtonClicked): Moved code from here to _urlChosenFromPrompt.
345         (LeaksViewer._didLoadRecentBuilds): Added. Stores the builds and updates the prompt.
346         (LeaksViewer._displayURLPrompt): Start loading the recent leaky builds.
347         (LeaksViewer._updateURLPrompt): Create a list of the recent leaky builds and add them to the
348         prompt UI.
349         (LeaksViewer._urlChosenFromPrompt): Added. Code came from urlPromptButtonClicked. This is
350         now also used when a recent build is clicked.
351
352         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js: Added.
353         (RecentBuildsLoader): Store the callback.
354         (RecentBuildsLoader.prototype.start): Load the N most recent builds from the specified
355         builder. Find the revision number, leak count, and results URL for each one. Pass the
356         resulting info to our callback.
357
358         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
359         (range): Added this helper function to return an array containing the integers [0, n).
360
361         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added
362         RecentBuildsLoader.js and added text to the prompt UI to show the recent builds.
363
364 2011-03-14  Mark Rowe  <mrowe@apple.com>
365
366         Reviewed by Adam Roben.
367
368         Fix two memory leaks within LayoutTestController's storage support.
369
370         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
371         (LayoutTestController::originsWithLocalStorage): Don't leak the JSStringRef that is returned
372         by JSStringCreateWithCFString.
373         (LayoutTestController::deleteLocalStorageForOrigin): Don't leak the WebSecurityOrigin that we
374         allocate.
375
376 2011-03-14  Mark Rowe  <mrowe@apple.com>
377
378         Reviewed by Oliver Hunt.
379
380         <http://webkit.org/b/56304> REGRESSION(r80892): 100,000+ leaks seen on the build bot
381
382         * DumpRenderTree/LayoutTestController.cpp:
383         (LayoutTestController::staticFunctions): Remove duplicate entries.
384
385 2011-03-14  Alice Liu  <alice.liu@apple.com>
386
387         Reviewed by Dan Bernstein.
388
389         DumpRenderTree Perl Support fails to build with ARCHS="i386 x86_64"
390
391         * DumpRenderTree/mac/PerlSupport/Makefile:
392         Add whitespace when joining "-arch" with the architectures passed in as arguments.
393
394 2011-03-14  Daniel Bates  <dbates@rim.com>
395
396         https://bugs.webkit.org/show_bug.cgi?id=55438
397         Add double quotes around value of -DCMAKE_WINCE_SDK that I inadvertently did not add
398         when landing changeset 81041 <http://trac.webkit.org/changeset/81041>.
399
400         * Scripts/build-webkit:
401
402 2011-03-14  Daniel Bates  <dbates@rim.com>
403
404         Reviewed by David Kilzer.
405
406         Cleanup: Separate port-specific implementation details from webkitdirs::buildCMakeProject()
407         https://bugs.webkit.org/show_bug.cgi?id=55438
408
409         Separate out the EFL- and WinCE-specific logic from the port-independent logic in
410         webkitdirs::buildCMakeProject(). Also, remove redundant code for generating the
411         CMake arguments for feature defines.
412
413         * Scripts/build-webkit:
414           - Added cMakeArgsFromFeatures() to convert the @features array to CMake arguments.
415           - Modified EFL and WinCE-specific building logic to call buildCMakeProjectOrExit().
416           - Sorted forward declarations.
417           - Initialize $makeArgs with the empty string so as to simplify its use in string operations;
418             Modified call sites as needed.
419         * Scripts/webkitdirs.pm:
420           - Added cleanCMakeGeneratedProject() to clean a CMake build.
421           - Added buildCMakeGeneratedProject() to build using generated build system.
422           - Added buildCMakeProjectOrExit() which is a facade for building a CMake project.
423           - Added generateBuildSystemFromCMakeProject() to generate the build system from
424             a CMake project.
425           - Removed buildCMakeProject(). This functionality is in buildCMakeProjectOrExit().
426
427 2011-03-14  John Knottenbelt  <jknotten@chromium.org>
428
429         Reviewed by Steve Block.
430
431         Detach Geolocation from Frame when Page destroyed.
432         https://bugs.webkit.org/show_bug.cgi?id=52877
433
434         Extend the layout test controller to expose the number of pending
435         geolocation requests, so that we can test that the requests have
436         been cancelled on page close.
437
438         * DumpRenderTree/LayoutTestController.cpp:
439         (numberOfPendingGeolocationPermissionRequestsCallback):
440         (LayoutTestController::staticFunctions):
441         * DumpRenderTree/LayoutTestController.h:
442         * DumpRenderTree/chromium/LayoutTestController.cpp:
443         (LayoutTestController::LayoutTestController):
444         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
445         * DumpRenderTree/chromium/LayoutTestController.h:
446         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
447         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
448         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
449         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
450         * DumpRenderTree/mac/UIDelegate.h:
451         * DumpRenderTree/mac/UIDelegate.mm:
452         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
453         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
454         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
455         * DumpRenderTree/qt/LayoutTestControllerQt.h:
456         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
457         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
458         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
459         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
460
461
462 2011-03-14  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
463
464         Unreviewed. Modify my email address in committers.py.
465
466         * Scripts/webkitpy/common/config/committers.py:
467
468 2011-03-13  Joe Wild  <joseph.wild@nokia.com>
469
470         Reviewed by Kenneth Rohde Christiansen.
471
472         [Qt] QtLauncher does not load the same set of fonts as the DRT
473         https://bugs.webkit.org/show_bug.cgi?id=34959
474
475         This patch adds the option "-use-test-fonts" to the QtTestBrowser.
476         When this option is used the webkit fonts are loaded the same
477         as they are in DumpRenderTree.  This option can be used on
478         QtTestBrowser and run-launcher.  It can only be used
479         on Linux systems with FcInit and is configured as such.
480
481         * QtTestBrowser/launcherwindow.h:
482         (WindowOptions::WindowOptions):
483         * QtTestBrowser/main.cpp:
484         (initWebKitTestFonts):
485         (launcherMain):
486         (LauncherApplication::handleUserOptions):
487
488 2011-03-12  Dan Bernstein  <mitz@apple.com>
489
490         Reviewed by Mark Rowe.
491
492         <rdar://problem/8995822> Build DumpRenderTree perl support only for the architectures
493         DumpRenderTree is being built for.
494
495         * DumpRenderTree/mac/PerlSupport/Makefile:
496
497 2011-03-12  Dan Bernstein  <mitz@apple.com>
498
499         Suggested by Mark Rowe.
500
501         * DumpRenderTree/mac/Configurations/Base.xcconfig: Leave C++ exceptions enabled
502         as they were before r80915.
503
504 2011-03-12  Anders Carlsson  <andersca@apple.com>
505
506         Reviewed by Sam Weinig.
507
508         Should be able to download a PDF to the Downloads folder
509         https://bugs.webkit.org/show_bug.cgi?id=56256
510
511         * MiniBrowser/mac/BrowserWindowController.m:
512         (-[BrowserWindowController awakeFromNib]):
513         * WebKitTestRunner/TestController.cpp:
514         (WTR::TestController::createOtherPage):
515         (WTR::TestController::initialize):
516         Update for API changes.
517
518 2011-03-11  Anton D'Auria  <adauria@apple.com>
519
520         Reviewed and landed by Brady Eidson.
521
522         https://bugs.webkit.org/show_bug.cgi?id=51878
523         Add WebKit1 API to view and delete local storage
524
525         Added tests that write to LocalStorage, delete one origin, get list of origins with local storage, delete all origins.
526
527         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
528         * DumpRenderTree/LayoutTestController.cpp:
529         (syncLocalStorageCallback):
530         (observeStorageTrackerNotificationsCallback):
531         (deleteAllLocalStorageCallback):
532         (deleteLocalStorageForOriginCallback):
533         (originsWithLocalStorageCallback):
534         (LayoutTestController::staticFunctions):
535         * DumpRenderTree/LayoutTestController.h:
536         * DumpRenderTree/StorageTrackerDelegate.h: Added.
537         * DumpRenderTree/StorageTrackerDelegate.mm: Added.
538         (-[StorageTrackerDelegate init]):
539         (-[StorageTrackerDelegate logNotifications:controller:]):
540         (-[StorageTrackerDelegate originModified:]):
541         (-[StorageTrackerDelegate dealloc]):
542         (-[StorageTrackerDelegate setControllerToNotifyDone:]):
543         * DumpRenderTree/chromium/LayoutTestController.cpp:
544         (LayoutTestController::LayoutTestController):
545         (LayoutTestController::deleteAllLocalStorage):
546         (LayoutTestController::originsWithLocalStorage):
547         (LayoutTestController::deleteLocalStorageForOrigin):
548         (observeStorageTrackerNotifications):
549         (syncLocalStorage):
550         * DumpRenderTree/chromium/LayoutTestController.h:
551         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
552         (LayoutTestController::originsWithLocalStorage):
553         (LayoutTestController::deleteAllLocalStorage):
554         (LayoutTestController::deleteLocalStorageForOrigin):
555         (LayoutTestController::observeStorageTrackerNotifications):
556         (LayoutTestController::syncLocalStorage):
557         * DumpRenderTree/mac/DumpRenderTree.mm:
558         (resetDefaultsToConsistentValues):
559         (allocateGlobalControllers):
560         (releaseGlobalControllers):
561         * DumpRenderTree/mac/DumpRenderTreeMac.h:
562         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
563         (LayoutTestController::syncLocalStorage):
564         (LayoutTestController::observeStorageTrackerNotifications):
565         (LayoutTestController::deleteAllLocalStorage):
566         (LayoutTestController::originsWithLocalStorage):
567         (LayoutTestController::deleteLocalStorageForOrigin):
568         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
569         (LayoutTestController::originsWithLocalStorage):
570         (LayoutTestController::deleteAllLocalStorage):
571         (LayoutTestController::deleteLocalStorageForOrigin):
572         (LayoutTestController::observeStorageTrackerNotifications):
573         (LayoutTestController::syncLocalStorage):
574         * DumpRenderTree/qt/LayoutTestControllerQt.h:
575         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
576         (LayoutTestController::clearAllApplicationCaches):
577         (LayoutTestController::syncLocalStorage):
578         (LayoutTestController::observeStorageTrackerNotifications):
579         (LayoutTestController::clearAllDatabases):
580         (LayoutTestController::deleteAllLocalStorage):
581         (LayoutTestController::originsWithLocalStorage):
582         (LayoutTestController::deleteLocalStorageForOrigin):
583         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
584         (LayoutTestController::syncLocalStorage):
585         (LayoutTestController::observeStorageTrackerNotifications):
586         (LayoutTestController::clearAllDatabases):
587         (LayoutTestController::deleteAllLocalStorage):
588         (LayoutTestController::originsWithLocalStorage):
589         (LayoutTestController::deleteLocalStorageForOrigin):
590
591 2011-03-11  Jessie Berlin  <jberlin@apple.com>
592
593         Reviewed by Adam Roben.
594
595         Crash calling WebContext::clearResourceCaches(InMemoryResourceCachesOnly) before the Web
596         Process has finished launching.
597         https://bugs.webkit.org/show_bug.cgi?id=56208
598
599         * TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Added.
600         (TestWebKitAPI::TEST):
601         Test that calling WKContextClearResourceCaches works with both options when called before
602         the Web Process is valid.
603
604         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
605         Add the new test.
606         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
607         Ditto.
608
609 2011-03-11  Adam Roben  <aroben@apple.com>
610
611         Make it possible to view all leaks from a build at once in Leaks Viewer
612
613         You can now give Leaks Viewer the URL of a build results page (e.g.,
614         <http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r80847%20(15493)/>), and it
615         will load all the leaks files from that build.
616
617         Fixes <http://webkit.org/b/56030> Leaks Viewer: Would like to be able to look at all leaks
618         files from a particular build at once, rather than one at a time
619
620         Reviewed by David Kilzer.
621
622         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksLoader.js: Added.
623         (LeaksLoader): Initialize our properties.
624         (LeaksLoader.prototype.start): If the URL ends in .txt, assume it's a single leaks file and
625         load it. Otherwise assume it's a build results page URL and start fetching the leaks files
626         from that page.
627         (LeaksLoader.prototype._loadLeaksFiles): Tell our client how many leaks files we're loading
628         so it can provide feedback. Then load each one and pass it to the client.
629         (LeaksLoader.prototype._loadLeaksFromResultsPage): Load the HTML of the results page, parse
630         it into a DOM, pull out all the links to leaks files, and load each one.
631
632         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParser.js: Added.
633         (LeaksParser): Initialize our worker.
634         (LeaksParser.prototype.addLeaksFile): Tell the worker about the leaks file's contents.
635
636         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js: Added.
637         This code mostly came from Worker.js.
638         (LeaksParserWorker): Initialize our profile.
639         (LeaksParserWorker.prototype.addLeaksFile): Parse the leaks file and incorporate it into our
640         profile.
641         (LeaksParserWorker.prototype._parseLeaks):
642         (LeaksParserWorker.prototype._createNode):
643         (LeaksParserWorker.prototype._incorporateLeaks):
644         Moved these functions here from LeaksViewer. _incorporateLeaks is essentially just a renamed
645         version of createProfile which adds to this.profile instead of making a new profile each
646         time.
647         (onmessage): Parse the file and send back the new profile.
648
649         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
650         (#loading-indicator):
651         (#spinner):
652         (#loading-indicator-label):
653         Tweaked styles to accomodate a longer label.
654
655         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
656         (LeaksViewer.loaded): Set up a loader and parser.
657
658         (LeaksViewer.get filesLeftToParse):
659         (LeaksViewer.set filesLeftToParse):
660         Added these simple accessors.
661
662         (LeaksViewer._didCountLeaksFiles): Callback from LeaksLoader. Stores the count.
663         (LeaksViewer._didLoadLeaksFile): Callback from LeaksLoader. Passes the file contents off to
664         the parser.
665         (LeaksViewer._didParseLeaksFile): Callback from LeaksParser. If all files have been parsed,
666         tell the ProfilerAgent and mark that we're done loading. (Code came from the old
667         _loadLeaksFromURL function).
668         (LeaksViewer._loadLeaksFromURL): Now just calls through to the loader.
669         (LeaksViewer._loadingIndicatorText): Added. Returns the text that should show up in the
670         loading indicator, including the number of files being loaded.
671         (LeaksViewer._loadingStatusChanged): Update the loading indicator's label, too.
672         (LeaksViewer._updateLoadingIndicatorLabel): Added. Just updates the label!
673         (LeaksViewer._updateTitle): Moved code to compute the "Loading" text to
674         _loadingIndicatorText.
675
676         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js: Added.
677         (getResource): Moved here from LeaksViewer.js.
678
679         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Subsumed by
680         LeaksParserWorker.js.
681
682         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added new JS
683         files, added a #loading-indicator-label element, and tweaked the prompt wording.
684
685 2011-03-11  Adam Roben  <aroben@apple.com>
686
687         Don't trigger a build when build.webkit.org's HTML files are modified
688
689         Fixes <http://webkit.org/b/56190> Windows bots shouldn't have built r80848/r80851, but did
690
691         Reviewed by Dan Bernstein.
692
693         * Scripts/webkitpy/common/config/build.py:
694         (_should_file_trigger_build): Added build.webkit.org's public_html directory to the list of
695         directories that shouldn't trigger builds. Re-sorted the list.
696
697         * Scripts/webkitpy/common/config/build_unittest.py:
698         (ShouldBuildTest): Added a test to cover the above change.
699
700 2011-03-11  Adam Roben  <aroben@apple.com>
701
702         Roll out r80848
703
704         It was accidentally committed.
705
706         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
707         (LeaksViewer._loadLeaksFromURL):
708
709 2011-03-11  Tony Chang  <tony@chromium.org>
710
711         Reviewed by Ojan Vafai.
712
713         kill hung lighttpd processes on the chromium win bot
714         https://bugs.webkit.org/show_bug.cgi?id=56152
715
716         Sometimes this process doesn't exit and it holds on to
717         a log file that we can't delete or copy, causing the tests
718         to go red.
719
720         * BuildSlaveSupport/win/kill-old-processes:
721
722 2011-03-11  Ilya Sherman  <isherman@chromium.org>
723
724         Reviewed by Kent Tamura.
725
726         [Chromium] missing HTMLInputElement::setValueForUser() to tests
727         https://bugs.webkit.org/show_bug.cgi?id=55854
728
729         * DumpRenderTree/chromium/LayoutTestController.cpp:
730         (LayoutTestController::LayoutTestController):
731         (LayoutTestController::setValueForUser): Added.
732         * DumpRenderTree/chromium/LayoutTestController.h:
733
734 2011-03-10  Peter Kasting  <pkasting@google.com>
735
736         Reviewed by Dimitri Glazkov.
737
738         Clean up some gross code in TestShellWin.cpp.  No functional change.
739         https://bugs.webkit.org/show_bug.cgi?id=56048
740
741         * DumpRenderTree/chromium/TestShellWin.cpp:
742         (checkLayoutTestSystemDependencies):
743
744 2011-03-10  Keith Kyzivat  <keith.kyzivat@nokia.com>
745
746         Reviewed by Laszlo Gombos.
747
748         [Qt] Buildfix for platforms where X11 is not available (e.g. Symbian)
749
750         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
751         (WTR::activateFonts): Guard X11-specific code with Q_WS_X11.
752
753 2011-03-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
754
755         Reviewed by Kenneth Rohde Christiansen.
756
757         [EFL] Make single backing store the default for EWebLauncher
758         https://bugs.webkit.org/show_bug.cgi?id=55753
759
760         Set single backing store the default for EWebLauncher.
761
762         * EWebLauncher/main.c:
763         (main):
764
765 2011-03-10  Adam Roben  <aroben@apple.com>
766
767         Ignore errors from files being held open when creating a test result archive
768
769         Fixes <http://webkit.org/b/55581> Test results don't get uploaded if test-result-archive
770         fails to delete the results directory
771
772         Reviewed by Mark Rowe.
773
774         * BuildSlaveSupport/test-result-archive:
775         (archiveTestResults): Ignore errno 2 when deleting the results directory, since it can be
776         thrown when a process is holding a file open.
777
778 2011-03-10  Sheriff Bot  <webkit.review.bot@gmail.com>
779
780         Unreviewed, rolling out r80701.
781         http://trac.webkit.org/changeset/80701
782         https://bugs.webkit.org/show_bug.cgi?id=56126
783
784         fast/dom/Geolocation/window-close-crash.html fails on Snow
785         Leopard release builds (Requested by mihaip on #webkit).
786
787         * DumpRenderTree/LayoutTestController.cpp:
788         (LayoutTestController::staticFunctions):
789         * DumpRenderTree/LayoutTestController.h:
790         * DumpRenderTree/chromium/LayoutTestController.cpp:
791         (LayoutTestController::LayoutTestController):
792         * DumpRenderTree/chromium/LayoutTestController.h:
793         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
794         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
795         * DumpRenderTree/mac/UIDelegate.h:
796         * DumpRenderTree/mac/UIDelegate.mm:
797         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
798         * DumpRenderTree/qt/LayoutTestControllerQt.h:
799         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
800         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
801
802 2011-03-10  Philippe Normand  <pnormand@igalia.com>
803
804         Reviewed by Gustavo Noronha Silva.
805
806         [GTK] run-gtk-tests doesn't fail if a test crashes
807         https://bugs.webkit.org/show_bug.cgi?id=56089
808
809         * Scripts/run-gtk-tests: gtester -k exits with a 0 exit status
810         even if a test crashes. So run the tests individually and if a
811         test fails remember its exit code so run-gtk-test fails too, if
812         required.
813
814 2011-01-26  John Knottenbelt  <jknotten@chromium.org>
815
816         Reviewed by Dmitry Titov.
817
818         Detach Geolocation from Frame when Page destroyed.
819         https://bugs.webkit.org/show_bug.cgi?id=52877
820
821         Extend the layout test controller to expose the number of pending
822         geolocation requests, so that we can test that the requests have
823         been cancelled on page close.
824
825         * DumpRenderTree/LayoutTestController.cpp:
826         (numberOfPendingGeolocationPermissionRequestsCallback):
827         (LayoutTestController::staticFunctions):
828         * DumpRenderTree/LayoutTestController.h:
829         * DumpRenderTree/chromium/LayoutTestController.cpp:
830         (LayoutTestController::LayoutTestController):
831         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
832         * DumpRenderTree/chromium/LayoutTestController.h:
833         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
834         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
835         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
836         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
837         * DumpRenderTree/mac/UIDelegate.h:
838         * DumpRenderTree/mac/UIDelegate.mm:
839         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
840         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
841         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
842         * DumpRenderTree/qt/LayoutTestControllerQt.h:
843         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
844         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
845         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
846         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
847
848
849 2011-03-09  Adam Roben  <aroben@apple.com>
850
851         Hide Leaks Viewer's URL prompt by default
852
853         We will show it as needed. I think I left it visible by default by accident after doing some
854         testing.
855
856         Fixes <http://webkit.org/b/56031> Leaks Viewer: URL prompt overlay shouldn't appear when a
857         URL is passed as a query parameter, but does
858
859         Reviewed by Simon Fraser.
860
861         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
862
863 2011-03-09  Adam Roben  <aroben@apple.com>
864
865         Don't use Element.classList or box-shadow in Leaks Viewer
866
867         They aren't supported by Safari 5. Luckily we have substitutes for them!
868
869         Fixes <http://webkit.org/b/56035> Leaks viewer doesn't work in Safari 5
870
871         Reviewed by Simon Fraser.
872
873         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
874         (#url-prompt): Use -webkit-box-shadow instead of box-shadow.
875
876         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
877         (LeaksViewer.urlPromptButtonClicked):
878         (LeaksViewer._displayURLPrompt):
879         (LeaksViewer._setLoadingIndicatorHidden):
880         Use add/removeStyleClass (from utilities.js) instead of Element.classList.
881
882 2011-03-09  Adam Roben  <aroben@apple.com>
883
884         Add a link to the Leaks Viewer tool on the build.webkit.org homepage
885
886         Rubber-stamped by David Kilzer.
887
888         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
889
890 2011-03-09  Adam Roben  <aroben@apple.com>
891
892         Add a Leaks Viewer tool to build.webkit.org
893
894         This tool parses leaks from the files generated by the leaks bot and displays them in a
895         view similar to the Web Inspector's Profiles pane (in fact, it uses the Web Inspector's
896         code).
897
898         The URL of the leaks file can be entered in a prompt when the tools is first shown, or can
899         be passed to the tool via the "url" query parameter.
900
901         Only one leaks file can be viewed at a time for now. Only the number of leaks, as opposed to
902         the number of leaked bytes, is shown. And this tool has made apparent some bugs in the Web
903         Inspector's Heavy profile view. But it's still pretty useful as-is.
904
905         Fixes <http://webkit.org/b/56028> Would like a Shark-like tool for viewing leaks from leak bots
906
907         Reviewed by Darin Adler.
908
909         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css: Added.
910         (#url-prompt-container): This is the dark overlay that is shown behind the URL prompt.
911         (#url-prompt): This is the prompt itself.
912
913         (#loading-indicator):
914         (#loading-indicator > img):
915         These show a spinner in the bottom-right when we're loading a leaks file.
916
917         (.percent-time-status-bar-item): Hide the Percent button since we never want to show leaks
918         as percentages.
919
920         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js: Added.
921         (LeaksViewer.loaded): Initialize ourselves and start loading the leaks file (or prompt for a
922         URL if one wasn't given to us as a query parameter).
923
924         (LeaksViewer.get loading):
925         (LeaksViewer.set loading):
926         (LeaksViewer.get url):
927         (LeaksViewer.set url):
928         Pretty simple accessors.
929
930         (LeaksViewer.urlPromptButtonClicked): Start loading the URL from the prompt and hide the
931         prompt.
932         (LeaksViewer._displayURLPrompt): Show the prompt and focus the URL input.
933         (LeaksViewer._loadLeaksFromURL): Start fetching the leaks file. When we've retrieved the
934         file, hand it off to a Web Worker that will parse it into a fake "profile", then hand off
935         the profile to the Web Inspector code once it's been created.
936         (LeaksViewer._loadingStatusChanged): Update our loading indicator and title.
937         (LeaksViewer._setLoadingIndicatorHidden): Simply hide or show the indicator.
938         (LeaksViewer._updateTitle): Set our title based on our URL and loading status.
939         (getResource): Helper function to fetch a resource via XHR and pass it to a callback.
940
941         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js: Added.
942         (WebInspector.UIString): Just a simple implementation since this tool isn't localized.
943         (ProfilerAgent.getProfile): Store the callback.
944         (ProfilerAgent.profileReady): Call the callback.
945         (monkeyPatchInspectorObjects): Fix up WebInspector.ProfileDataGridNode to show the self leak
946         count and total leak counts as real values, not percentages or milliseconds.
947
948         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Added.
949         (onmessage): Create a profile based on the leaks file and pass it back to our caller.
950         (parseLeaks): Extract call stacks out of a leaks file.
951         (createNode): Helper function to create a new empty profile node.
952         (createProfile): Take the leak stacks and turn them into a fake "profile" for consumption by
953         WebInspector.ProfileView.
954
955         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added.
956
957 2011-03-09  Dan Bernstein  <mitz@apple.com>
958
959         Reviewed by Adam Roben.
960
961         Combine multiple --ignore-tests values
962         https://bugs.webkit.org/show_bug.cgi?id=56016
963
964         * Scripts/old-run-webkit-tests:
965
966 2011-03-08  Kenji Imasaki  <imasaki@chromium.org>
967
968         Reviewed by David Levin.
969
970         Adding myself to the committer file.
971
972         * Scripts/webkitpy/common/config/committers.py:
973
974 2011-03-08  Jessie Berlin  <jberlin@apple.com>
975
976         Rubber-stamped by Adam Roben.
977
978         Fix two leaks I introduced into the API tests.
979
980         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
981         (TestWebKitAPI::TEST):
982
983 2011-03-08  Jessie Berlin  <jberlin@apple.com>
984
985         Reviewed by Anders Carlsson.
986
987         Crash in CFNetwork visiting google.com
988         https://bugs.webkit.org/show_bug.cgi?id=55958
989
990         Add a test for not trying to copy a null CFURLResponse.
991
992         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp: Added.
993         (TestWebKitAPI::TEST):
994         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
995
996 2011-03-08  Hayato Ito  <hayato@chromium.org>
997
998         Reviewed by Ojan Vafai.
999
1000         [NRWT] Renamed a FailureWithType class to a ComparisonTestFailure class.
1001
1002         FailureWithType is a confusing naming because we have removed test_type/* classes in r79840.
1003
1004         https://bugs.webkit.org/show_bug.cgi?id=55450
1005
1006         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1007
1008 2011-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1009
1010         Reviewed by Martin Robinson.
1011
1012         [GTK] Add layoutTestController.setValueForUser() after r80412
1013         https://bugs.webkit.org/show_bug.cgi?id=55862
1014
1015         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1016         (LayoutTestController::setValueForUser): Implement setValueForUser()
1017
1018 2011-03-08  Patrick Gansterer  <paroga@webkit.org>
1019
1020         Reviewed by Adam Barth.
1021
1022         Add script_shell_command to WebKitPort
1023         https://bugs.webkit.org/show_bug.cgi?id=55925
1024
1025         Add a central place where we generate the shell command from the script name.
1026         This function will be used later to detect the correct script interpreter on Win32.
1027
1028         * Scripts/webkitpy/common/config/ports.py:
1029         * Scripts/webkitpy/layout_tests/port/base.py:
1030         * Scripts/webkitpy/tool/steps/abstractstep.py:
1031         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1032
1033 2011-03-07  Ojan Vafai  <ojan@chromium.org>
1034
1035         Reviewed by Adam Barth.
1036
1037         add webkit-patch attach-to-bug for posting to bugzilla from the commandline
1038         https://bugs.webkit.org/show_bug.cgi?id=55749
1039
1040         * Scripts/webkitpy/tool/commands/upload.py:
1041         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1042         * Scripts/webkitpy/tool/steps/__init__.py:
1043         * Scripts/webkitpy/tool/steps/attachtobug.py: Added.
1044         * Scripts/webkitpy/tool/steps/options.py:
1045
1046 2011-03-07  Daniel Cheng  <dcheng@chromium.org>
1047
1048         Reviewed by David Levin.
1049
1050         Add support for DataTransferItems
1051         https://bugs.webkit.org/show_bug.cgi?id=55115
1052
1053         Enable data transfer items in DRT.
1054
1055         * DumpRenderTree/chromium/TestShell.cpp:
1056         (TestShell::TestShell):
1057
1058 2011-03-06  Ojan Vafai  <ojan@chromium.org>
1059
1060         Reviewed by Tony Chang.
1061
1062         [test dashboard] pull treemap files
1063         https://bugs.webkit.org/show_bug.cgi?id=55852
1064
1065         * TestResultServer/handlers/dashboardhandler.py:
1066
1067 2011-03-03  Hayato Ito  <hayato@chromium.org>
1068
1069         Reviewed by Mihai Parparita.
1070
1071         [NRWT] Clear output image file used by DumpRenderTree to make sure the
1072         previous image should not be used in the ChromiumDriver.
1073
1074         Also make sure that output image from the ChromiumDriver should be ''
1075         (empty string) if a test crashes for consistency with the WebKitDriver
1076         implementation.
1077
1078         https://bugs.webkit.org/show_bug.cgi?id=55746
1079
1080         * Scripts/webkitpy/layout_tests/port/chromium.py:
1081
1082 2011-03-07  Zan Dobersek  <zandobersek@gmail.com>
1083
1084         Reviewed by Martin Robinson.
1085
1086         [Gtk] fast/js/navigator-language.html fails locally
1087         https://bugs.webkit.org/show_bug.cgi?id=55880
1088
1089         Add LANG variable to the clean environment when running
1090         old-run-webkit-tests script.
1091
1092         * Scripts/old-run-webkit-tests:
1093
1094 2011-03-07  Tony Chang  <tony@chromium.org>
1095
1096         Reviewed by Mihai Parparita.
1097
1098         [Chromium] Find .checksum files without .pngs and vice-versa
1099         https://bugs.webkit.org/show_bug.cgi?id=55236
1100
1101         * Scripts/find-mismatched-layout-test-results: Added. A script for finding
1102             mismatched results.
1103
1104 2011-03-07  Chris Fleizach  <cfleizach@apple.com>
1105
1106         Reviewed by Beth Dakin.
1107
1108         AX: WK1 needs to use the ScrollView attachment for AXScrollArea, WK2 should not use this element.
1109         https://bugs.webkit.org/show_bug.cgi?id=55706
1110
1111         The rootElement in DRT should point to the scroll view. In WK1, that will be the parent of the rootObject.
1112
1113         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1114         (AccessibilityController::focusedElement):
1115            Remove FIXME comment about caching the focusedElement. In fact, we shouldn't cache this 
1116            because it could change at any time.
1117         (AccessibilityController::rootElement):
1118
1119 2011-03-07  Sam Weinig  <sam@webkit.org>
1120
1121         Reviewed by Anders Carlsson.
1122
1123         Add unableToImplementPolicy callback for WebKit2 policy client
1124         <rdar://problem/9071902>
1125         https://bugs.webkit.org/show_bug.cgi?id=55884
1126
1127         * MiniBrowser/mac/BrowserWindowController.m:
1128         (-[BrowserWindowController awakeFromNib]):
1129         Update policy client initialization struct for new member.
1130
1131 2011-03-07  Sam Weinig  <sam@webkit.org>
1132
1133         Reviewed by Anders Carlsson.
1134
1135         Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
1136         https://bugs.webkit.org/show_bug.cgi?id=55827
1137
1138         * MiniBrowser/mac/BrowserWindowController.m:
1139         (decidePolicyForResponse):
1140         (-[BrowserWindowController awakeFromNib]):
1141         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1142         (TestWebKitAPI::decidePolicyForResponse):
1143         (TestWebKitAPI::TEST):
1144         Update tools for new name.
1145
1146 2011-03-06  Daniel Bates  <dbates@rim.com>
1147
1148         Reviewed by Eric Seidel and David Kilzer.
1149
1150         Fix misspelled word in build-webkit's checkForJavaSDK() and sort forward declarations
1151         https://bugs.webkit.org/show_bug.cgi?id=55503
1152
1153         Fix misspelled word "Dowloads" [sic] in the message printed to standard output
1154         in checkForJavaSDK().
1155
1156         Also, remove extraneous space in function prototype for unlinkZeroFiles.
1157
1158         * Scripts/build-webkit:
1159
1160 2011-03-05  Brian Weinstein  <bweinstein@apple.com>
1161
1162         Reviewed by Sam Weinig.
1163
1164         Fix Web Process crashes caused by https://bugs.webkit.org/show_bug.cgi?id=53919.
1165
1166         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1167         (WTR::InjectedBundlePage::willSendRequestForFrame): Retain the WKURLRequestRef returned
1168             by willSendRequestForFrame. The API expects a retained reference to the URL request.
1169
1170 2011-03-05  Ilya Sherman  <isherman@chromium.org>
1171
1172         Reviewed by Darin Adler.
1173
1174         HTMLInputElement::setValue() should schedule change event when the element is focused
1175         In service of https://code.google.com/p/chromium/issues/detail?id=42716
1176         https://bugs.webkit.org/show_bug.cgi?id=53160
1177
1178         * DumpRenderTree/LayoutTestController.cpp:
1179         (setValueForUserCallback):
1180         (LayoutTestController::staticFunctions):
1181         * DumpRenderTree/LayoutTestController.h:
1182         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1183         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
1184         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1185         (LayoutTestController::setValueForUser): Expose HTMLInputElement::setValueForUser() to tests
1186         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1187         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
1188         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1189         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
1190         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1191         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
1192
1193 2011-03-04  Mark Rowe  <mrowe@apple.com>
1194
1195         Reviewed by Alexey Proskuryakov.
1196
1197         <rdar://problem/9055252> DumpRenderTree is crashing with GuardMalloc
1198
1199         GuardMalloc does not expect the memory containing its malloc_zone_t to ever be read-only.
1200         
1201         * DumpRenderTree/mac/CheckedMalloc.cpp:
1202         (protectionOfRegion): Retrieve the protection flags for the VM region containing the given address.
1203         (makeLargeMallocFailSilently): Save the initial protection flags, temporarily make the region writeable,
1204         and then restore the initial protection flags when we're done.
1205
1206 2011-03-04  Evan Martin  <evan@chromium.org>
1207
1208         Reviewed by Tony Chang.
1209
1210         [gdb] pretty-print KURL in gdb
1211         https://bugs.webkit.org/show_bug.cgi?id=55788
1212
1213         * gdb/webkit.py: extend the pretty-printers to print WTF::CString
1214         and KURLGooglePrivate.  As always, "p/r" can be used to sidestep
1215         pretty-printing.
1216
1217 2011-03-03  Timothy Hatcher  <timothy@apple.com>
1218
1219         Update the tests that use WKPageRunJavaScriptInMainFrame use the WKSerializedScriptValueRef.
1220
1221         Reviewed by Darin Adler.
1222
1223         * TestWebKitAPI/JavaScriptTest.cpp:
1224         (TestWebKitAPI::javaScriptCallback):
1225         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
1226         (TestWebKitAPI::didRunJavaScript):
1227         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1228         (TestWebKitAPI::nullJavaScriptCallback):
1229         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
1230         (TestWebKitAPI::didRunJavaScript):
1231
1232 2011-03-03  Timothy Hatcher  <timothy@apple.com>
1233
1234         Make run-api-tests show failed if a test fails.
1235
1236         https://webkit.org/b/55725
1237
1238         Reviewed by Sam Weinig.
1239
1240         * Scripts/run-api-tests:
1241         (runTest): Remove "my" from the nested $result assignment so the
1242         check outside the condition sees the real result.
1243
1244 2011-03-02  MORITA Hajime  <morrita@google.com>
1245
1246         Reviewed by Kent Tamura.
1247
1248         [Chromium][DRT] WebTask should use webkit_support::TaskAdaptor
1249         https://bugs.webkit.org/show_bug.cgi?id=55434
1250
1251         Changed WebTask to be a subclass of webkit_support::TaskAdaptor
1252         and passed the object webkit_support::PostDelayedTask directly.
1253
1254         Note that the change keeps postTask() as is because it has a
1255         semantics taht webkit_support::PostDelayedTask() has; It jumps to
1256         the main thread.
1257
1258         * DumpRenderTree/chromium/Task.cpp:
1259         (postDelayedTask):
1260         * DumpRenderTree/chromium/Task.h:
1261         (WebTask::Run):
1262
1263 2011-03-03  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1264
1265         Reviewed by Kenneth Rohde Christiansen.
1266
1267         [QT] Implement mock client-based geolocation for layout testing
1268         https://bugs.webkit.org/show_bug.cgi?id=54334
1269
1270         Implement testing for Client-Based geolocation for QtWebkit.
1271
1272         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1273         (WebCore::DumpRenderTree::DumpRenderTree):
1274         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1275         (LayoutTestController::reset):
1276         (LayoutTestController::setGeolocationPermission):
1277         (LayoutTestController::setMockGeolocationError):
1278         (LayoutTestController::setMockGeolocationPosition):
1279
1280 2011-03-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1281
1282         Unreviewed, rolling out r80237.
1283         http://trac.webkit.org/changeset/80237
1284         https://bugs.webkit.org/show_bug.cgi?id=55714
1285
1286         Windows bots aren't ready to be core (Requested by aroben on
1287         #webkit).
1288
1289         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1290         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1291
1292 2011-03-03  Mihai Parparita  <mihaip@chromium.org>
1293
1294         Reviewed by Tony Chang.
1295
1296         NRWT: AttributeError: TestRunner2 instance has no attribute '_cancel_workers'
1297         https://bugs.webkit.org/show_bug.cgi?id=55694
1298         
1299         Fixes for interruptions in NRWT:
1300         - Make TestRunInterruptedException be pickleable correctly (the base
1301           Exception class defines a __reduce__ that does not include the reason)
1302         - Fix ordering of returned arguments from TestRunner2._run_tests
1303           (interrupted and keyboard_interrupted were reversed)
1304         - Fix cancel_workers callsites (was using old name).
1305         - In handle_exception re-raise actual exception instance that was thrown
1306
1307         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1308         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
1309         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
1310         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1311
1312 2011-03-03  Qi Zhang  <qi.2.zhang@nokia.com>
1313
1314         Unreviewed.
1315
1316         Adding myself as a committer.
1317
1318         * Scripts/webkitpy/common/config/committers.py:
1319
1320 2011-03-03  Tony Gentilcore  <tonyg@chromium.org>
1321
1322         Reviewed by Mihai Parparita.
1323
1324         Teach sheriffbot to answer whois commands
1325         https://bugs.webkit.org/show_bug.cgi?id=55687
1326
1327         * Scripts/webkitpy/tool/bot/irc_command.py:
1328         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1329         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1330
1331 2011-03-03  Victoria Kirst  <vrk@google.com>
1332
1333         Reviewed by Eric Carlson.
1334
1335         Enable media tests in chromium-gpu/test_expectations
1336         https://bugs.webkit.org/show_bug.cgi?id=53608
1337
1338         Add media folder to the list of GPU test paths.
1339
1340         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1341
1342 2011-03-03  Adam Roben  <aroben@apple.com>
1343
1344         Work around a bug in KURL's parsing of Windows-style absolute file: URLs
1345
1346         Fixes <http://webkit.org/b/55674> Many tests fail in WebKit2 mode on Windows due to
1347         incorrect parsing of absolute Windows-style file: URLs
1348
1349         Reviewed by Tim Hatcher.
1350
1351         * WebKitTestRunner/TestInvocation.cpp:
1352         (WTR::createWKURL): Add a "localhost" host to file: URLs we create to work around
1353         <http://webkit.org/b/55683>.
1354
1355 2011-03-03  Tony Chang  <tony@chromium.org>
1356
1357         Reviewed by Dimitri Glazkov.
1358
1359         [chromium] Run kill-old-processes on the chromium-win bot too
1360         https://bugs.webkit.org/show_bug.cgi?id=55630
1361
1362         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1363         * BuildSlaveSupport/win/kill-old-processes: Add wdiff.exe to the kill list.
1364
1365 2011-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1366
1367         Reviewed by Martin Robinson.
1368
1369         [GTK] DRT needs implementation of EventSender.scheduleAsynchronousClick
1370         https://bugs.webkit.org/show_bug.cgi?id=53960
1371
1372         * DumpRenderTree/gtk/EventSender.cpp:
1373         (sendClick):
1374         (scheduleAsynchronousClickCallback):
1375
1376 2011-03-03  Adam Roben  <aroben@apple.com>
1377
1378         Look for Windows-style paths when checking whether a test is an Inspector test
1379
1380         WTR part of <http://webkit.org/b/55672> <rdar://problem/9080867> All inspector tests time
1381         out or crash on Windows 7 Release (WebKit2 Tests)
1382
1383         Reviewed by Darin Adler.
1384
1385         * WebKitTestRunner/TestInvocation.cpp:
1386         (WTR::shouldOpenWebInspector): Also look for backslashes, since that's what we'll get on
1387         Windows.
1388
1389 2011-03-03  Adam Roben  <aroben@apple.com>
1390
1391         Make Windows 7 Release (Tests) a core builder
1392
1393         We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
1394         give it a few more days of greenness first.
1395
1396         Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder
1397
1398         Reviewed by Andreas Kling.
1399
1400         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1401         (BuildBot): Added a regexp to match Windows 7 Release (Tests).
1402
1403         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1404         (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
1405         Updated the core regexps to match the buildbot module. Updated the expected results to match
1406         the current set of core builders.
1407
1408 2011-03-03  Benjamin Poulain  <benjamin.poulain@nokia.com>
1409
1410         Reviewed by Andreas Kling.
1411
1412         Adding myself as a reviewer.
1413
1414         * Scripts/webkitpy/common/config/committers.py:
1415
1416 2011-03-03  Lukasz Slachciak  <l.slachciak@samsung.com>
1417
1418         Reviewed by Xan Lopez.
1419
1420         [GTK] Extended application cache database API and added unit tests file.
1421         https://bugs.webkit.org/show_bug.cgi?id=55335
1422
1423         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: removed external declaration
1424         of webkit_application_cache_set_maximum_size due to API exposal.
1425
1426 2011-03-02  Ojan Vafai  <ojan@chromium.org>
1427
1428         Reviewed by Adam Barth.
1429
1430         make webkit-patch upload work for security bugs
1431         https://bugs.webkit.org/show_bug.cgi?id=55655
1432
1433         The problem is that we shell out to prepare-ChangeLog,
1434         which does not authenticate with bugzilla. All it needs from
1435         bugzilla is the bug title though. We just pass it through from
1436         webkit-patch instead.
1437
1438         * Scripts/prepare-ChangeLog:
1439         * Scripts/webkitpy/common/net/bugzilla/bug.py:
1440         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1441
1442 2011-03-01  Ojan Vafai  <ojan@chromium.org>
1443
1444         Reviewed by Tony Chang.
1445
1446         [test-dashboard] make gtest JSON match layout-tests JSON
1447         https://bugs.webkit.org/show_bug.cgi?id=55556
1448
1449         http://trac.webkit.org/changeset/80090 stopped converting time_ms to t.
1450         Make this code match.
1451
1452         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1453
1454 2011-03-02  Dirk Pranke  <dpranke@chromium.org>
1455
1456         Reviewed by Tony Chang.
1457
1458         NRWT - implement Linux Hardy 64-bit port support. This involves
1459         adding support for non-'x86' architectures and updating the
1460         "deduplicate_tests" script to correctly understand that
1461         port.name() is not always equal to basename(port.baseline_path()).
1462
1463         This change introduces two new port names: 'chromium-linux-x86'
1464         and 'chromium-linux-x86_64'. Using the prior 'chromium-linux'
1465         flag will cause the code to determine which one to use at
1466         runtime, just like we currently do with 'chromium-win'.
1467
1468         https://bugs.webkit.org/show_bug.cgi?id=55535
1469
1470         * Scripts/webkitpy/common/system/executive_mock.py:
1471           Handle 'return_stderr' keyword arg to run_command()
1472         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
1473         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1474         * Scripts/webkitpy/layout_tests/port/base.py:
1475         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1476         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1477         * Scripts/webkitpy/layout_tests/port/factory.py:
1478         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1479
1480 2011-03-02  Kevin Ollivier  <kevino@theolliviers.com>
1481
1482         [wx] Build fix, make sure we put the wxWebKit dylib in the right directory and
1483         update symlinks accordingly.
1484
1485         * wx/packaging/build-mac-installer.py:
1486
1487 2011-03-02  Sheriff Bot  <webkit.review.bot@gmail.com>
1488
1489         Unreviewed, rolling out r80139.
1490         http://trac.webkit.org/changeset/80139
1491         https://bugs.webkit.org/show_bug.cgi?id=55620
1492
1493         failing and crashing tests on Snow Leopard bot (Requested by
1494         mihaip1 on #webkit).
1495
1496         * DumpRenderTree/LayoutTestController.cpp:
1497         (LayoutTestController::staticFunctions):
1498         * DumpRenderTree/LayoutTestController.h:
1499         * DumpRenderTree/chromium/LayoutTestController.cpp:
1500         (LayoutTestController::LayoutTestController):
1501         * DumpRenderTree/chromium/LayoutTestController.h:
1502         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1503         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1504         * DumpRenderTree/mac/UIDelegate.h:
1505         * DumpRenderTree/mac/UIDelegate.mm:
1506         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1507         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1508         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1509         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1510
1511 2011-03-02  Adam Roben  <aroben@apple.com>
1512
1513         Wait for force a paint in WebKitTestRunner until we're actually ready to dump the output
1514
1515         This matches DumpRenderTree on Windows.
1516
1517         Fixes <http://webkit.org/b/55469> <rdar://problem/9068539> REGRESSION (r79863): Lots of
1518         dom/html/level2/html/HTMLFrameElement*.html tests crashing in FrameView::paintOverhangAreas
1519         in WebKit2
1520
1521         Reviewed by Beth Dakin.
1522
1523         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1524         (WTR::InjectedBundlePage::dump): Moved code to force a paint here...
1525         (WTR::InjectedBundlePage::didFinishLoadForFrame): ...from here.
1526
1527 2011-03-02  Daniel Cheng  <dcheng@chromium.org>
1528
1529         Reviewed by David Levin.
1530
1531         Add feature define for data transfer items
1532         https://bugs.webkit.org/show_bug.cgi?id=55510
1533
1534         * Scripts/build-webkit:
1535
1536 2011-03-02  Adam Roben  <aroben@apple.com>
1537
1538         Look in the new-to-SnowLeopard location for crash logs on SnowLeopard and newer
1539
1540         ReportCrash saves logs to ~/Library/Logs/CrashReporter on Leopard, but to
1541         ~/Library/Logs/DiagnosticReports on SnowLeopard. old-run-webkit-tests was only looking in
1542         the former location, but was getting lucky on some SnowLeopard machines because symlinks
1543         were being created there pointing into DiagnosticReports. For machines without these
1544         symlinks, crash logs were not getting captured.
1545
1546         Fixes <http://webkit.org/b/55607> old-run-webkit-tests doesn't capture crash logs on some
1547         SnowLeopard machines
1548
1549         Reviewed by Eric Seidel.
1550
1551         * Scripts/old-run-webkit-tests:
1552         (captureSavedCrashLog): Look in ~/Library/Logs/DiagnosticReports on SnowLeopard and newer.
1553
1554 2011-03-02  Adam Roben  <aroben@apple.com>
1555
1556         Don't try to capture crash logs on platforms that haven't implemented that feature
1557
1558         Fixes <http://webkit.org/b/55504> Use of uninitialized value in numeric lt (<) at
1559         Tools/Scripts/old-run-webkit-tests line 1778 seen on Qt bots after a crash
1560
1561         Reviewed by Joseph Pecoraro.
1562
1563         * Scripts/old-run-webkit-tests:
1564         (captureSavedCrashLog): Bail if we don't have a crash log glob.
1565         (findNewestFileMatchingGlob): Fix a buggy test for when no paths match the glob. This isn't
1566         strictly required to fix bug 55504, but seems worthwhile.
1567
1568 2011-01-26  John Knottenbelt  <jknotten@chromium.org>
1569
1570         Reviewed by Dmitry Titov.
1571
1572         Detach Geolocation from Frame when Page destroyed.
1573         https://bugs.webkit.org/show_bug.cgi?id=52877
1574
1575         Extend the layout test controller to expose the number of pending
1576         geolocation requests, so that we can test that the requests have
1577         been cancelled on page close.
1578
1579         * DumpRenderTree/LayoutTestController.cpp:
1580         (numberOfPendingGeolocationPermissionRequestsCallback):
1581         (LayoutTestController::staticFunctions):
1582         * DumpRenderTree/LayoutTestController.h:
1583         * DumpRenderTree/chromium/LayoutTestController.cpp:
1584         (LayoutTestController::LayoutTestController):
1585         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1586         * DumpRenderTree/chromium/LayoutTestController.h:
1587         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1588         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1589         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1590         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1591         * DumpRenderTree/mac/UIDelegate.h:
1592         * DumpRenderTree/mac/UIDelegate.mm:
1593         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
1594         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1595         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1596         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1597         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1598         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1599         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1600         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1601
1602
1603 2011-03-01  Kent Tamura  <tkent@chromium.org>
1604
1605         Reviewed by Dimitri Glazkov.
1606
1607         Assertion fails when a form validation bubble appears
1608         https://bugs.webkit.org/show_bug.cgi?id=55550
1609
1610         Test: fast/forms/interactive-validation-attach-assertion.html
1611
1612         * DumpRenderTree/chromium/WebPreferences.cpp:
1613         (WebPreferences::applyTo): Enable the interactive validation feature by
1614           default. This matches to Chromium browser.
1615
1616 2011-03-01  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1617
1618         Reviewed by Kent Tamura.
1619
1620         Remove efl port style exception of Webcore/JavaScriptCore
1621         https://bugs.webkit.org/show_bug.cgi?id=55549
1622
1623         WebCore and JavaScriptCore need to adhere WebKit coding style.
1624
1625         * Scripts/webkitpy/style/checker.py:
1626
1627 2011-03-01  Tony Chang  <tony@chromium.org>
1628
1629         Reviewed by Ojan Vafai.
1630
1631         [chromium] clean up temp files on chromium-mac builder too
1632         https://bugs.webkit.org/show_bug.cgi?id=55525
1633
1634         * BuildSlaveSupport/chromium/remove-crash-logs:
1635
1636 2011-02-28  Ojan Vafai  <ojan@chromium.org>
1637
1638         Reviewed by Tony Chang.
1639
1640         wrap json in a function call to afford cross-domain loading
1641         https://bugs.webkit.org/show_bug.cgi?id=55353
1642
1643         Also delete the code that compacts the JSON. It turns out this
1644         breaks the rebaseline tool and is probably a premature optimization anyways.
1645
1646         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1647         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1648         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1649         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1650
1651 2011-03-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1652
1653         Unreviewed, rolling out r80079.
1654         http://trac.webkit.org/changeset/80079
1655         https://bugs.webkit.org/show_bug.cgi?id=55547
1656
1657         "Broke the Win debug build?" (Requested by dcheng on #webkit).
1658
1659         * Scripts/build-webkit:
1660
1661 2011-03-01  Mark Rowe  <mrowe@apple.com>
1662
1663         Reviewed by Sam Weinig.
1664
1665         Update verification scripts to handle WebKit2.
1666
1667         * Scripts/check-for-global-initializers: Skip object files that use RefCountedLeakChecker.
1668         * Scripts/check-for-inappropriate-files-in-framework: Add some inappropriate file types for
1669         WebKit2.
1670
1671 2011-03-01  Daniel Cheng  <dcheng@chromium.org>
1672
1673         Reviewed by David Levin.
1674
1675         Add feature define for data transfer items
1676         https://bugs.webkit.org/show_bug.cgi?id=55510
1677
1678         * Scripts/build-webkit:
1679
1680 2011-02-23  Joseph Pecoraro  <joepeck@webkit.org>
1681
1682         Reviewed by Timothy Hatcher.
1683
1684         All Console Messages should be passed to ChromeClients.
1685         https://bugs.webkit.org/show_bug.cgi?id=54926
1686
1687         Update DumpRenderTree's UIDelegate to use the new console message delegate.
1688
1689         * DumpRenderTree/mac/UIDelegate.mm:
1690         (-[UIDelegate webView:addMessageToConsole:withSource:]):
1691
1692 2011-03-01  Dirk Pranke  <dpranke@chromium.org>
1693
1694         Reviewed by Adam Barth.
1695
1696         Tragically, we stopped running the python unit tests
1697         on Chromium Win just as I was getting them to be green.
1698         This patch turns them back on.
1699
1700         https://bugs.webkit.org/show_bug.cgi?id=55521
1701
1702         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1703
1704 2011-03-01  Dirk Pranke  <dpranke@chromium.org>
1705
1706         Reviewed by Adam Roben.
1707
1708         Disable
1709         webkitpy.common.system.executive_unittest.ExecutiveTest.\
1710            test_kill_all fails on win until it can be properly triaged.
1711
1712         https://bugs.webkit.org/show_bug.cgi?id=54790
1713
1714         * Scripts/webkitpy/common/system/executive_unittest.py:
1715
1716     2011-03-01  Helder Correia  <helder@sencha.com>
1717
1718             Unreviewed. Add myself to committers.py.
1719
1720             * Scripts/webkitpy/common/config/committers.py:
1721
1722 2011-03-01  Adam Roben  <aroben@apple.com>
1723
1724         Give up if a crash log for the web process is taking too long to be saved on Windows
1725
1726         This should keep the bots from getting stuck while waiting for a crash log, if writing a
1727         crash log ever hangs or the UI process for some reason doesn't notice it's finished.
1728
1729         Fixes <http://webkit.org/b/55499> WebKitTestRunner can hang forever waiting for a crash log
1730         to be saved for the web process
1731
1732         Reviewed by Steve Falkenburg.
1733
1734         * WebKitTestRunner/win/TestControllerWin.cpp:
1735         (WTR::runRunLoopUntil): Moved code to run the run loop here here from platformRunUntil.
1736         Generalized the code slightly to handle the optional object to wait on.
1737         (WTR::TestController::platformRunUntil): Use the new runRunLoopUntil function, and also use
1738         it (with a timeout) when waiting for a crash log for the web process to be saved. This will
1739         prevent us from waiting forever.
1740
1741 2011-03-01  Adam Roben  <aroben@apple.com>
1742
1743         Give WebKitLauncherWin's PDB file a name different from WebKit's
1744
1745         WebKitLauncherWin (which builds WebKit.exe) and WebKit (which builds WebKit.dll) were
1746         fighting over the same PDB file, meaning that one of them was going to lose and not have
1747         symbols. WebKitLauncherWin's PDB file is now named WebKitLauncherWin.pdb.
1748
1749         Fixes <http://webkit.org/b/55495> Crashes in WebKit.dll have bad backtraces for some test
1750         runs (due to missing symbols)
1751
1752         Reviewed by David Kilzer.
1753
1754         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Use the project name,
1755         "WebKitLauncherWin", instead of the target name, "WebKit", when naming the PDB file.
1756
1757 2011-03-01  Adam Roben  <aroben@apple.com>
1758
1759         Count web process crashes toward the --exit-after-n-crashes-or-timeouts limit
1760
1761         Fixes <http://webkit.org/b/55492> Web process crashes aren't counted toward the
1762         --exit-after-n-crashes-or-timeouts limit
1763
1764         Reviewed by David Kilzer.
1765
1766         * Scripts/old-run-webkit-tests:
1767         (stopRunningTestsEarlyIfNeeded): Include web process crashes in the computation, and print
1768         the number of tests that caused the web process to crash when exiting early.
1769
1770 2011-03-01  Adam Roben  <aroben@apple.com>
1771
1772         Save a crash log when the web process crashes
1773
1774         On Windows, WebKitTestRunner now detects when the web process is crashing and waits to exit
1775         until it has finished crashing, which guarantees that the crash log will have had time to be
1776         saved, too. On Mac, we always wait until ReportCrash has exited before capturing the crash
1777         log, so all we have to do is choose the right crash log out of the CrashReporter directory.
1778
1779         Fixes <http://webkit.org/b/44121> <rdar://problem/8320759> When the web process crashes and
1780         a crash log is being saved, WebKitTestRunner thinks the web process has become unresponsive
1781
1782         Reviewed by Sam Weinig.
1783
1784         * Scripts/old-run-webkit-tests:
1785         (testCrashedOrTimedOut): Don't kill WebKitTestRunner when the web process crashes. It will
1786         kill itself. On Windows, this will cause us to wait until the crash log has been saved. On
1787         Mac, it should have no effect. Capture saved crash logs for web process crashes, too.
1788         (captureSavedCrashLog): Added $webProcessCrashed argument. On Mac, look for
1789         WebProces_*.crash files when the web process crashes.
1790
1791         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1792         (WTR::InjectedBundle::initialize): Added an initializationUserData argument. Updated for
1793         initializePlatformDefaults -> platformInitialize rename. Pass the initializationUserData
1794         along to platformInitialize.
1795
1796         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: See above.
1797
1798         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
1799         (WKBundleInitialize): Pass along the initializationUserData to the InjectedBundle.
1800
1801         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1802         (WTR::InjectedBundle::platformInitialize):
1803         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
1804         (WTR::InjectedBundle::platformInitialize):
1805         Updated function signature.
1806
1807         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp:
1808         (WTR::exceptionFilter): Added. Tells the UI process we're crashing by signaling the
1809         webProcessCrashingEvent, then lets the crash continue as normal.
1810
1811         (WTR::InjectedBundle::platformInitialize): Hook up exceptionFilter. Retrieve the name of the
1812         event we should use to tell the UI process we're crashing from the initializationUserData,
1813         and get a handle to that event.
1814
1815         * WebKitTestRunner/TestController.cpp:
1816         (WTR::TestController::TestController): Initialize new members.
1817         (WTR::TestController::processDidCrash): Removed unnecessary WKPageRef argument. Changed to
1818         only print the "#CRASHED - WebProcess" message once, since this can be called more than once
1819         when a crash log is being saved on Windows. Exit right away if specified. (This is the
1820         default.)
1821
1822         * WebKitTestRunner/TestController.h: Added new members.
1823
1824         * WebKitTestRunner/win/TestControllerWin.cpp:
1825         (WTR::TestController::platformInitialize): Set up the event the web process will use to tell
1826         us it's crashing.
1827         (WTR::TestController::platformRunUntil): Pass MWMO_INPUTAVAILABLE to
1828         ::MsgWaitForMultipleObjectsEx so we'll process messages that have already been seen by
1829         ::PeekMessage. (This is unrelated to the bug fix.) Notice when the webProcessCrashingEvent
1830         has been signaled. When this happens, print the "#CRASHED - WebProcess" message right away
1831         so the test harness will know the web process has crashed and not try to kill us, then wait
1832         for the web process to finish crashing so a crash log will have time to be saved.
1833         (WTR::toWK): Simple hepler function.
1834         (WTR::TestController::platformInitializeContext): Pass along the name of the event the web
1835         process should use to tell us it is crashing in the context's initialization user data.
1836
1837 2011-03-01  Dimitri Glazkov  <dglazkov@chromium.org>
1838
1839         Reviewed by Tony Gentilcore.
1840
1841         Move the checks to exclude Python/Perl tests for Chromium Win build to the right place.
1842         https://bugs.webkit.org/show_bug.cgi?id=55476
1843
1844         Chromium Win uses BuildAndTestFactory, not TestFactory.
1845
1846         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Moved to the right place.
1847
1848 2011-03-01  Adam Roben  <aroben@apple.com>
1849
1850         Test that the WebKit2 responsiveness timer doesn't fire too early
1851
1852         Test for <http://webkit.org/b/55417> <rdar://problem/9065287> RunLoop::Timer fires 1000x too
1853         early on Windows
1854
1855         Reviewed by Anders Carlsson.
1856
1857         * TestWebKitAPI/PlatformUtilities.h: Added sleep().
1858
1859         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp: Added.
1860         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1861         (TestWebKitAPI::didFinishLoadForFrame):
1862         (TestWebKitAPI::processDidBecomeUnresponsive):
1863         (TestWebKitAPI::setInjectedBundleClient):
1864         (TestWebKitAPI::setPageLoaderClient):
1865         Simple helper functions.
1866
1867         (TestWebKitAPI::TEST): Load an HTML file to make sure the web process is initialized. Then
1868         tell the web process to pause and press the spacebar key. The spacebar keypress should cause
1869         the responsiveness timer to start, but the web process should unpause before it has a chance
1870         to fire. Run until the web process has unpaused, and assert that the timer didn't fire.
1871
1872         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp: Added.
1873         (TestWebKitAPI::ResponsivenessTimerDoesntFireEarlyTest::ResponsivenessTimerDoesntFireEarlyTest):
1874         Call up to the base class.
1875         (TestWebKitAPI::ResponsivenessTimerDoesntFireEarlyTest::didReceiveMessage): When asked to
1876         pause, sleep for 0.5 seconds, then send back a message saying we paused.
1877
1878         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1879         (TestWebKitAPI::Util::sleep): Added. Calls through to usleep.
1880         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1881         (TestWebKitAPI::Util::sleep): Added. Calls through to ::Sleep.
1882
1883         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1884         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1885         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
1886         Added new files.
1887
1888 2011-03-01  Andras Becsi  <abecsi@webkit.org>
1889
1890         Reviewed by Csaba Osztrogonác.
1891
1892         [Qt] Clean up the project files and move common options to WebKit.pri.
1893
1894         * WebKitTestRunner/qt/WebKitTestRunner.pro: Deduplicate.
1895
1896
1897 2011-03-01  Adam Roben  <aroben@apple.com>
1898
1899         Skip another multiprocessing test on Windows
1900
1901         It is sometimes failing (and may be leaving child Python processes around).
1902         <http://webkit.org/b/55087> tracks the failure.
1903
1904         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
1905         (FuncitonTests.test_get__processes): Skip this test on Windows.
1906
1907 2011-03-01  Ilya Tikhonovsky  <loislo@chromium.org>
1908
1909         Reviewed by Pavel Feldman.
1910
1911         Web Inspector: reduce inspector tests flakiness.
1912         https://bugs.webkit.org/show_bug.cgi?id=55401
1913
1914         * DumpRenderTree/chromium/TestShell.cpp:
1915         (TestShell::runFileTest):
1916         * DumpRenderTree/chromium/WebPreferences.cpp:
1917         (WebPreferences::reset):
1918
1919 2011-02-28  Mihai Parparita  <mihaip@chromium.org>
1920
1921         Reviewed by James Robinson.
1922
1923         NRWT should still upload results when it exits early due to too many failures
1924         https://bugs.webkit.org/show_bug.cgi?id=55432
1925         
1926         Only keyboard interrupts should prevent results from being uploaded.
1927
1928         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1929         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1930
1931 2011-02-28  Alice Liu  <alice.liu@apple.com>
1932
1933         Reviewed by Adam Roben and Gavin Barraclough.
1934
1935         Test for https://bugs.webkit.org/show_bug.cgi?id=54898
1936         InjectedBundleNodeHandle dies too early in WKBundleHitTestResultGetNodeHandle.
1937
1938         * TestWebKitAPI/InjectedBundleController.h:
1939         (TestWebKitAPI::InjectedBundleController::bundle):
1940         * TestWebKitAPI/PlatformWebView.h:
1941         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp: Added.
1942         (TestWebKitAPI::didFinishLoadForFrame):
1943         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1944         (TestWebKitAPI::setPageLoaderClient):
1945         (TestWebKitAPI::TEST):
1946         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp: Added.
1947         (TestWebKitAPI::HitTestResultNodeHandleTest::HitTestResultNodeHandleTest):
1948         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
1949         (TestWebKitAPI::HitTestResultNodeHandleTest::didCreatePage):
1950         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1951         (TestWebKitAPI::PlatformWebView::simulateRightClick):
1952         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
1953         (TestWebKitAPI::PlatformWebView::simulateRightClick):
1954         
1955         Added files to:
1956         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1957         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1958         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
1959
1960 2011-02-28  Adam Roben  <aroben@apple.com>
1961
1962         Start running InjectedBundle API tests on Windows
1963
1964         A new project, TestWebKitAPIInjectedBundle, builds the injected bundle DLL.
1965
1966         Fixes <http://webkit.org/b/55420> run-api-tests doesn't run injected bundle tests on Windows
1967
1968         Reviewed by Darin Adler.
1969
1970         * TestWebKitAPI/Configurations/TestWebKitAPIDebug.vsprops: Added.
1971         * TestWebKitAPI/Configurations/TestWebKitAPIDebugAll.vsprops: Added.
1972         * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops: Added.
1973         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops: Added.
1974         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops: Added.
1975         These are just extracted from TestWebKitAPI.vcproj.
1976
1977         * TestWebKitAPI/Configurations/TestWebKitAPIInjectedBundleCommon.vsprops: Added. Just sets
1978         up the DLL's filename.
1979
1980         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Fixed DLL name.
1981         (TestWebKitAPI::Util::createInjectedBundlePath): Changed to use kCFAllocatorNull instead of
1982         0 (== kCFAllocatorDefault) so that CF won't try to deallocate our C string.
1983
1984         * TestWebKitAPI/win/TestWebKitAPI.sln: Added TestWebKitAPIInjectedBundle. Removed the bogus
1985         "all" configuration.
1986
1987         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Changed to use the new .vsprops files. Added
1988         injected bundle tests. Let VS resort things.
1989
1990         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Copied from Tools/TestWebKitAPI/win/TestWebKitAPI.vcproj.
1991
1992 2011-02-28  Adam Roben  <aroben@apple.com>
1993
1994         Add a test for the paint rect passed via WM_PAINT to windowless plugins
1995
1996         Test for <http://webkit.org/b/55365> <rdar://problem/9031089> REGRESSION (r79040): WebKit2:
1997         Large portions of pages with plugins paint black
1998
1999         Reviewed by Anders Carlsson.
2000
2001         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2002         (PluginTest::NPP_HandleEvent):
2003         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2004         Added NPP_HandleEvent. Just returns 0 at this level.
2005
2006         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowlessPaintRectCoordinates.cpp: Added.
2007         (WindowlessPaintRectCoordinates::WindowlessPaintRectCoordinates): Call up to the base class.
2008         (WindowlessPaintRectCoordinates::NPP_New): Mark ourselves as windowless.
2009         (WindowlessPaintRectCoordinates::NPP_HandleEvent): Check that the paint rect passed via
2010         WM_PAINT has the expected coordinates.
2011
2012         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2013         (NPP_HandleEvent): Give the PluginTest a chance to handle the event before doing anything
2014         else.
2015
2016         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added new file, let VS
2017         resort things.
2018
2019         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2020         (WTR::InjectedBundlePage::didFinishLoadForFrame): Added a call to WKBundlePageForceRepaint.
2021         This is roughly equivalent to the call to -[WebView displayIfNeeded] in -[FrameLoadDelegate
2022         webView:didFinishLoadForFrame:] in DumpRenderTree.
2023
2024         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2025         (WTR::PlatformWebView::PlatformWebView): Tell the WKView it's in a window so that plugins
2026         can start running.
2027
2028 2011-02-28  Adam Roben  <aroben@apple.com>
2029
2030         Tell MiniBrowser's WKViews that they're in a window
2031
2032         Fixes <http://webkit.org/b/55364> Plugins don't work in MiniBrowser on Windows
2033
2034         Reviewed by Anders Carlsson.
2035
2036         * MiniBrowser/win/BrowserView.cpp:
2037         (BrowserView::create): Call WKViewSetIsInWindow after creating the view.
2038
2039 2011-02-28  Alexis Menard  <alexis.menard@openbossa.org>
2040
2041         Reviewed by Csaba Osztrogonác.
2042
2043         The new QML tests require QML_IMPORT_PATH variable to be set in order to
2044         load the proper plugin.
2045
2046         * Scripts/run-qtwebkit-tests:
2047
2048 2011-02-28  Joone Hur  <joone.hur@collabora.co.uk>
2049
2050         Unreviewed, fix spelling mistake.
2051
2052         hardware-accelated => hardware-accelerated.
2053
2054         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2055
2056 2011-02-28  Kristian Amlie  <kristian.amlie@nokia.com>
2057
2058         Reviewed by Andreas Kling.
2059
2060         Made sure that the build-webkit --qmake argument is always respected.
2061
2062         Previously, it would be respected during the build, but not during
2063         the early feature detection. The build would also fail if qmake was
2064         not in your path, even if you specified --qmake with a valid qmake
2065         binary.
2066
2067         [Qt] WebKit patches required to work with a modularized version of Qt
2068         https://bugs.webkit.org/show_bug.cgi?id=53916
2069
2070         * Scripts/build-webkit:
2071         * Scripts/webkitdirs.pm:
2072
2073 2011-02-27  Ojan Vafai  <ojan@chromium.org>
2074
2075         Fix failing tests from http://trac.webkit.org/changeset/79837.
2076
2077         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2078         This was just a mistake that would break if someone tried printing with this configuration.
2079         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2080         Method signature changed. Didn't notice that this method was being calling in a unittest.
2081
2082 2011-02-24  Hayato Ito  <hayato@chromium.org>
2083
2084         Reviewed by Eric Seidel.
2085
2086         [NRWT] Remove test_types/* classes.
2087
2088         This is the last patch in the series of efforts which tried to remove test_types classes.
2089         A single_test_runner module will take over responsibilities of test_type classes.
2090
2091         From this patch, we won't display statistics per test_type even if a '--verbose' option is given.
2092
2093         https://bugs.webkit.org/show_bug.cgi?id=55123
2094
2095         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
2096         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2097         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
2098         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2099         * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
2100         * Scripts/webkitpy/layout_tests/test_types/__init__.py: Removed.
2101         * Scripts/webkitpy/layout_tests/test_types/image_diff.py: Removed.
2102         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: Removed.
2103         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py: Removed.
2104         * Scripts/webkitpy/layout_tests/test_types/text_diff.py: Removed.
2105
2106 2011-02-25  Ojan Vafai  <ojan@chromium.org>
2107
2108         Reviewed by Tony Chang.
2109
2110         Change results.json format to the one used by unexpected_results.json
2111         https://bugs.webkit.org/show_bug.cgi?id=52267
2112
2113         Also add runtimes in milliseconds to the JSON and make the output format more compact.
2114         Named the file full_results.json to avoid conflicting with the results.json
2115         file the test-results server currently serves up.
2116
2117         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2118         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2119         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2120         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2121         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
2122         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2123
2124 2011-02-27  Adam Roben  <aroben@apple.com>
2125
2126         Followup fix to r79827
2127
2128         * DumpRenderTree/win/UIDelegate.cpp:
2129         (UIDelegate::webViewAddMessageToConsole): Replaced call to urlSuitableForTestResult with
2130         lastPathComponent. This matches what we did here before r79827, and matches Mac.
2131
2132 2011-02-27  Dan Bernstein  <mitz@apple.com>
2133
2134         Reviewed by Adam Roben.
2135
2136         Make bisect-builds print a trac link for the regression range
2137         https://bugs.webkit.org/show_bug.cgi?id=55331
2138
2139         * Scripts/bisect-builds:
2140
2141 2011-02-27  Adam Roben  <aroben@apple.com>
2142
2143         Use iswalpha instead of isalpha when dealing with wchar_ts in EditingDelegate
2144
2145         Fixes <http://webkit.org/b/55062> <rdar://problem/9059907> Crash beneath
2146         EditingDelegate::checkSpellingOfString when running fast/forms/input-text-maxlength.html or
2147         fast/forms/input-text-paste-maxlength.html on Windows with full page heap enabled
2148
2149         Reviewed by Anders Carlsson.
2150
2151         * DumpRenderTree/win/EditingDelegate.cpp:
2152         (indexOfFirstWordCharacter):
2153         (wordLength):
2154         Use iswalpha instead of isalpha, since TCHAR is really just wchar_t.
2155
2156 2011-02-27  Adam Roben  <aroben@apple.com>
2157
2158         Make ResourceLoadDelegate print URLs relative to the main resource on Windows
2159
2160         This matches Mac. (In fact, the code was ported from Mac!)
2161
2162         Fixes <http://webkit.org/b/55328> URLs printed by ResourceLoadDelegate on Windows don't
2163         match Mac
2164
2165         Reviewed by Anders Carlsson.
2166
2167         * DumpRenderTree/win/DumpRenderTree.cpp:
2168         (substringFromIndex): Added. Emulates -[NSString substringFromIndex:].
2169         (urlSuitableForTestResult): Ported code from -[NSURL(DRTExtras)
2170         _drt_descriptionSuitableForTestResult].
2171         (cfStringRefToWString): Moved here from LayoutTestControllerWin.cpp.
2172
2173         * DumpRenderTree/win/DumpRenderTreeWin.h: Added declaration of cfStringRefToWString.
2174
2175         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Moved cfStringRefToWString to
2176         DumpRenderTree.cpp.
2177
2178 2011-02-27  Adam Roben  <aroben@apple.com>
2179
2180         Change the order of Chang Shu's email addresses so the first one is their Bugzilla username
2181
2182         This makes Bugzilla autocompletion work correctly.
2183
2184         * Scripts/webkitpy/common/config/committers.py:
2185
2186 2011-02-27  Patrick Gansterer  <paroga@webkit.org>
2187
2188         Reviewed by Andreas Kling.
2189
2190         [Qt] fast/loader/user-stylesheet-fast-path.html fails
2191         https://bugs.webkit.org/show_bug.cgi?id=50911
2192
2193         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2194         (LayoutTestController::setUserStyleSheetLocation):
2195         Use QUrl::fromEncoded since the passed string is already encoded.
2196
2197 2011-02-27  Adam Roben  <aroben@apple.com>
2198
2199         Ensure $testResultsDirectory is an absolute path before setting up Windows crash log saving
2200
2201         Windows 7 (and maybe Vista?) launches the post-mortem debugger with a working directory that
2202         is different from old-run-webkit-test's. Because of this, the path to the crash log file
2203         (which is relative to $testResultsDirectory) must be an absolute path. See the bug for more
2204         details.
2205
2206         Fixes <http://webkit.org/b/55318> Crash logs aren't saved on Windows 7 when a relative
2207         --results-directory path is used (like on the test slaves)
2208
2209         Reviewed by Dan Bernstein.
2210
2211         * Scripts/old-run-webkit-tests: Moved the call to setUpWindowsCrashLogSaving after we've
2212         made $testResultsDirectory an absolute path.
2213
2214 2011-02-26  Dominic Mazzoni  <dmazzoni@google.com>
2215
2216         Reviewed by Adam Barth.
2217
2218         m_dumpAccessibilityNotifications should be initialized.
2219         https://bugs.webkit.org/show_bug.cgi?id=54874
2220
2221         * DumpRenderTree/chromium/AccessibilityController.cpp:
2222         (AccessibilityController::AccessibilityController):
2223
2224 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
2225
2226         Reviewed by Pavel Feldman.
2227
2228         DumpRenderTree should reset frame opener between tests.
2229         https://bugs.webkit.org/show_bug.cgi?id=54874
2230
2231         Added clearOpener() calls between tests.
2232         Some tests are using window.open() to change current window location.
2233         This changes window.opener property whose nullity is checked before
2234         showing xml viewer.
2235
2236         * DumpRenderTree/chromium/TestShell.cpp:
2237         (TestShell::resetTestController):
2238         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2239         (resetDefaultsToConsistentValues):
2240         * DumpRenderTree/mac/DumpRenderTree.mm:
2241         (resetWebViewToConsistentStateBeforeTesting):
2242         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2243         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2244         * DumpRenderTree/win/DumpRenderTree.cpp:
2245         (resetWebViewToConsistentStateBeforeTesting):
2246         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2247         (WTR::InjectedBundlePage::reset):
2248
2249 2011-02-26  Yael Aharon  <yael.aharon@nokia.com>
2250
2251         Reviewed by Andreas Kling.
2252
2253         [Qt] Fix the focus in MiniBrowser.
2254         https://bugs.webkit.org/show_bug.cgi?id=55288
2255
2256         Give focus to the web view when a load starts.
2257
2258         * MiniBrowser/qt/BrowserWindow.cpp:
2259         (BrowserWindow::urlChanged):
2260
2261 2011-02-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2262
2263         Reviewed by Adam Barth.
2264
2265         [EFL] Add coding style exceptions for EFL port
2266         https://bugs.webkit.org/show_bug.cgi?id=54733
2267
2268         The EFL APIs use EFL naming style, which includes both lower-cased and camel-cased,
2269         underscore-sparated values. But, style checking rule have found parameter_name errors
2270         in efl directories so far.
2271
2272         * Scripts/webkitpy/style/checker.py: Add prameter_name rule's exception and efl directories.
2273
2274 2011-02-26  David Levin  <levin@chromium.org>
2275
2276         Reviewed by Darin Adler.
2277
2278         check-webkit-style should check for spaces after periods in comments
2279         https://bugs.webkit.org/show_bug.cgi?id=55253
2280
2281         * Scripts/webkitpy/style/checkers/cpp.py: Added the check.
2282         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests
2283           and fixed the name of one related test.
2284
2285 2011-02-26  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2286
2287         Reviewed by Andreas Kling.
2288
2289         Make it possible to test the targetdensity-dpi support
2290         https://bugs.webkit.org/show_bug.cgi?id=55142
2291
2292         Test the viewport meta tag feature targetdensity-dpi by
2293         adding extra arguments to dumpConfigurationForViewport
2294
2295         Add the new arguments to the shared header and all
2296         implementation.
2297
2298         * DumpRenderTree/LayoutTestController.cpp:
2299         (dumpConfigurationForViewportCallback):
2300         * DumpRenderTree/LayoutTestController.h:
2301         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2302         (LayoutTestController::dumpConfigurationForViewport):
2303         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2304         (LayoutTestController::dumpConfigurationForViewport):
2305         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2306         (LayoutTestController::dumpConfigurationForViewport):
2307         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2308         (LayoutTestController::dumpConfigurationForViewport):
2309         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2310         (LayoutTestController::dumpConfigurationForViewport):
2311         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2312
2313 2011-02-26  Sheriff Bot  <webkit.review.bot@gmail.com>
2314
2315         Unreviewed, rolling out r79764.
2316         http://trac.webkit.org/changeset/79764
2317         https://bugs.webkit.org/show_bug.cgi?id=55295
2318
2319         "broke Chromium builds" (Requested by rniwa on #webkit).
2320
2321         * DumpRenderTree/chromium/TestShell.cpp:
2322         (TestShell::resetTestController):
2323         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2324         (resetDefaultsToConsistentValues):
2325         * DumpRenderTree/mac/DumpRenderTree.mm:
2326         (resetWebViewToConsistentStateBeforeTesting):
2327         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2328         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2329         * DumpRenderTree/win/DumpRenderTree.cpp:
2330         (resetWebViewToConsistentStateBeforeTesting):
2331         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2332         (WTR::InjectedBundlePage::reset):
2333
2334 2011-02-26  Yongjun Zhang  <yongjun_zhang@apple.com>
2335
2336         Reviewed by David Kilzer.
2337
2338         https://bugs.webkit.org/show_bug.cgi?id=48781
2339
2340         Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.
2341
2342         Add a new resource load client method (shouldPaintBrokenImage).  WebKit client can decide if WebCore
2343         should paint the default broken image when an image fails to load or decode.
2344
2345         * DumpRenderTree/LayoutTestController.cpp:
2346         (LayoutTestController::LayoutTestController):
2347         (setShouldPaintBrokenImageCallback):
2348         (LayoutTestController::staticFunctions):
2349         (LayoutTestController::setShouldPaintBrokenImage):
2350         * DumpRenderTree/LayoutTestController.h:
2351         (LayoutTestController::shouldPaintBrokenImage):
2352         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2353         (-[ResourceLoadDelegate webView:shouldPaintBrokenImageForURL:]):
2354
2355 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
2356
2357         Reviewed by Pavel Feldman.
2358
2359         DumpRenderTree should reset frame opener between tests.
2360         https://bugs.webkit.org/show_bug.cgi?id=54874
2361
2362         Added clearOpener() calls between tests.
2363         Some tests are using window.open() to change current window location.
2364         This changes window.opener property whose nullity is checked before
2365         showing xml viewer.
2366
2367         * DumpRenderTree/chromium/TestShell.cpp:
2368         (TestShell::resetTestController):
2369         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2370         (resetDefaultsToConsistentValues):
2371         * DumpRenderTree/mac/DumpRenderTree.mm:
2372         (resetWebViewToConsistentStateBeforeTesting):
2373         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2374         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2375         * DumpRenderTree/win/DumpRenderTree.cpp:
2376         (resetWebViewToConsistentStateBeforeTesting):
2377         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2378         (WTR::InjectedBundlePage::reset):
2379
2380 2011-02-25  Lukasz Slachciak  <l.slachciak@samsung.com>
2381
2382         Reviewed by Kenneth Rohde Christiansen.
2383
2384         [EFL] Added EWebLauncher command line option to turn on/off frame flattening
2385         https://bugs.webkit.org/show_bug.cgi?id=54809
2386
2387         * EWebLauncher/main.c: Handling -f option added.
2388         (on_key_down):
2389         (browserCreate):
2390         (main):
2391
2392 2011-02-25  Sheriff Bot  <webkit.review.bot@gmail.com>
2393
2394         Unreviewed, rolling out r79324.
2395         http://trac.webkit.org/changeset/79324
2396         https://bugs.webkit.org/show_bug.cgi?id=55260
2397
2398         Leopard Debug is once again running out of address space while
2399         linking (Requested by aroben on #webkit).
2400
2401         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2402         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2403
2404 2011-02-25  Tony Chang  <tony@chromium.org>
2405
2406         Reviewed by James Robinson.
2407
2408         Clean up temp files left by crashing DRTs on chromium-win
2409         https://bugs.webkit.org/show_bug.cgi?id=55182
2410
2411         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2412         * BuildSlaveSupport/chromium/remove-crash-logs: Added.
2413
2414 2011-02-25  Adam Roben  <aroben@apple.com>
2415
2416         Double-check that modifying the registry worked
2417
2418         On Windows Vista/7 with UAC enabled, regtool will fail to modify the registry, but it will
2419         still return a successful exit code. So we double-check here that the value we tried to
2420         write to the registry was really written.
2421
2422         Fixes <http://webkit.org/b/55227> old-run-webkit-tests falsely claims to be saving crash
2423         logs on Windows Vista/7
2424
2425         Reviewed by Darin Adler.
2426
2427         * Scripts/old-run-webkit-tests:
2428         (writeRegistryString): After trying to write the string value, check that it was really
2429         written.
2430
2431 2011-02-25  Adam Roben  <aroben@apple.com>
2432
2433         Set the 32-bit post-mortem debugger on 64-bit OSes
2434
2435         The post-mortem debugger is controlled by some registry values in
2436         HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion\AeDebug. On 64-bit OSes, you can either
2437         set the values in that key, which will be used for 64-bit apps, or in the equivalent key
2438         under Wow6432Node, which will be used for 32-bit apps. Since DumpRenderTree and
2439         WebKitTestRunner are 32-bit, we want to use the latter location.
2440
2441         Fixes <http://webkit.org/b/55225> old-run-webkit-tests sets the post-mortem debugger for
2442         64-bit apps, but should set it for 32-bit apps instead
2443
2444         Reviewed by Darin Adler.
2445
2446         * Scripts/old-run-webkit-tests:
2447         (readRegistryString):
2448         (writeRegistryString):
2449         Pass --wow32 to regtool so it will get/set values beneath Wow6432Node, which is where
2450         Windows looks for the post-mortem debugger values when a 32-bit app crashes on a 64-bit OS.
2451         Passing --wow32 on a 32-bit OS will not have any effect.
2452
2453 2011-02-25  Adam Roben  <aroben@apple.com>
2454
2455         Clean up code to set up crash log saving on Windows
2456
2457         Fixes <http://webkit.org/b/55224> old-run-webkit-test's Windows registry code is ugly
2458
2459         Reviewed by David Kilzer.
2460
2461         * Scripts/old-run-webkit-tests:
2462         (readRegistryString):
2463         (writeRegistryString):
2464         Moved code to read strings from and write strings to the registry here...
2465
2466         (setUpWindowsCrashLogSaving): ...from here.
2467
2468 2011-02-25  Adam Roben  <aroben@apple.com>
2469
2470         Work around Cygwin's crash-suppression behavior
2471
2472         Cygwin calls ::SetErrorMode(SEM_FAILCRITICALERRORS), which any processes it launches will
2473         inherit. This is bad for testing/debugging, as it causes the post-mortem debugger not to be
2474         invoked. (Cygwin does this because it makes crashes more UNIX-y.) We reset the error mode
2475         when our test apps launch to work around Cygwin's behavior.
2476
2477         Fixes <http://webkit.org/b/55222> Test apps crash silently (without invoking post-mortem
2478         debugger) when launched from Cygwin 1.7
2479
2480         Reviewed by Darin Adler.
2481
2482         * DumpRenderTree/win/DumpRenderTree.cpp:
2483         (main):
2484         * TestWebKitAPI/win/main.cpp:
2485         (main):
2486         * WebKitAPITest/main.cpp:
2487         (main):
2488         * WebKitTestRunner/win/TestControllerWin.cpp:
2489         (WTR::TestController::platformInitialize):
2490         Call ::SetErrorMode(0) to undo Cygwin's folly.
2491
2492 2011-02-24  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2493
2494         Reviewed by Andreas Kling.
2495
2496         [Qt] Revert the support for QNAM affined to a different thread.
2497         https://bugs.webkit.org/show_bug.cgi?id=55149
2498
2499         Qt 4.8 will have QNAM use its own thread internally by default,
2500         no need to keep this complexity in WebKit.
2501
2502         This mainly reverts:
2503         http://trac.webkit.org/changeset/73710
2504         http://trac.webkit.org/changeset/73712
2505
2506         * QtTestBrowser/launcherwindow.cpp:
2507         (LauncherWindow::~LauncherWindow):
2508         (LauncherWindow::initializeView):
2509         (LauncherWindow::createChrome):
2510         * QtTestBrowser/launcherwindow.h:
2511         (WindowOptions::WindowOptions):
2512         * QtTestBrowser/webpage.cpp:
2513         (WebPage::WebPage):
2514         * QtTestBrowser/webpage.h:
2515
2516 2011-02-24  Adam Barth  <abarth@webkit.org>
2517
2518         Reviewed by Eric Seidel.
2519
2520         Add a script for creating gypi files
2521         https://bugs.webkit.org/show_bug.cgi?id=55113
2522
2523         This is a trivial script to create gypi files from the source code in
2524         the current directory.
2525
2526         * Scripts/make-gypi: Added.
2527
2528 2011-02-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2529
2530         Unreviewed, rolling out r79628.
2531         http://trac.webkit.org/changeset/79628
2532         https://bugs.webkit.org/show_bug.cgi?id=55195
2533
2534         "broke chromium win tests" (Requested by dpranke on #webkit).
2535
2536         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2537         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2538
2539 2011-02-24  Dirk Pranke  <dpranke@chromium.org>
2540
2541         Reviewed by Mihai Parparita.
2542
2543         rebaseline-chromium-webkit-tests can't handle GPU variants
2544         https://bugs.webkit.org/show_bug.cgi?id=55002
2545
2546         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2547         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2548
2549 2011-02-24  Dirk Pranke  <dpranke@chromium.org>
2550
2551         Reviewed by Mihai Parparita.
2552
2553         nrwt: log command used to start web server to --verbose
2554
2555         https://bugs.webkit.org/show_bug.cgi?id=55188
2556
2557         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2558         * Scripts/webkitpy/layout_tests/port/http_server.py:
2559
2560 2011-02-24  Victoria Kirst  <vrk@google.com>
2561
2562         Reviewed by Mihai Parparita.
2563
2564         [chromium] Move media-file.js and video-test.js back to media/ for UILayoutTests
2565         https://bugs.webkit.org/show_bug.cgi?id=55089
2566
2567         This adds an alias into the media/ directory so that http/tests/media
2568         tests can access the media resources when running in an httpd process.
2569
2570         * Scripts/webkitperl/httpd.pm:
2571         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2572         * Scripts/webkitpy/layout_tests/port/http_server.py:
2573
2574 2011-02-24  Dirk Pranke  <dpranke@chromium.org>
2575
2576         Reviewed by Mihai Parparita.
2577
2578         nrwt: enable multiple processes by default on Chromium Win.
2579
2580         https://bugs.webkit.org/show_bug.cgi?id=55163
2581
2582         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2583         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2584
2585 2011-02-24  Sam Weinig  <sam@webkit.org>
2586
2587         Attempt to fix Qt.
2588
2589         * WebKitTestRunner/TestInvocation.cpp:
2590
2591 2011-02-24  James Robinson  <jamesr@chromium.org>
2592
2593         Unreviewed, rolling out r79598.
2594         http://trac.webkit.org/changeset/79598
2595         https://bugs.webkit.org/show_bug.cgi?id=55089
2596
2597         Appears to be causing trouble with httpd on windows
2598
2599         * Scripts/webkitperl/httpd.pm:
2600         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2601         * Scripts/webkitpy/layout_tests/port/http_server.py:
2602
2603 2011-02-24  Sam Weinig  <sam@webkit.org>
2604
2605         Reviewed by Darin Adler.
2606
2607         Add basic pixel testing support to WebKitTestRunner
2608         https://bugs.webkit.org/show_bug.cgi?id=55161
2609
2610         * Scripts/old-run-webkit-tests:
2611         Don't print color space information when using WebKitTestRunner since
2612         we don't need to change the screen.
2613
2614         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2615         (WTR::InjectedBundle::initialize):
2616         Add call to initializePlatformDefaults.
2617         
2618         (WTR::InjectedBundle::done):
2619         Return a dictionary on completion with both the text output and pixel dump override.
2620
2621         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2622         Add declaration for initializePlatformDefaults.
2623
2624         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2625         (WTR::LayoutTestController::LayoutTestController):
2626         (WTR::LayoutTestController::dumpAsText):
2627         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2628         (WTR::LayoutTestController::shouldDumpPixels):
2629         Make setting dumpAsText override the dump pixels preference.
2630
2631         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: Added.
2632         (WTR::InjectedBundle::initializePlatformDefaults):
2633         Set platform defaults matching DumpRenderTree.
2634
2635         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp: Added.
2636         (WTR::InjectedBundle::initializePlatformDefaults):
2637         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp: Added.
2638         (WTR::InjectedBundle::initializePlatformDefaults):
2639         Add stubs for initializePlatformDefaults.
2640
2641         * WebKitTestRunner/TestController.cpp:
2642         (WTR::TestController::runTest):
2643         (WTR::TestController::runTestingServerLoop):
2644         (WTR::TestController::run):
2645         Parse expected pixel results out of stdin and setup the invocation with it.
2646
2647         * WebKitTestRunner/TestInvocation.cpp:
2648         (WTR::TestInvocation::TestInvocation):
2649         Initialize new members.
2650
2651         (WTR::TestInvocation::~TestInvocation):
2652         (WTR::TestInvocation::setIsPixelTest):
2653         (WTR::sizeWebViewForCurrentTest):
2654         (WTR::TestInvocation::invoke):
2655         (WTR::TestInvocation::dump):
2656         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2657         * WebKitTestRunner/TestInvocation.h:
2658         Dump pixels in addition to text by calling dumpPixelsAndCompareWithExpected.
2659
2660         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2661         (WTR::PlatformWebView::PlatformWebView):
2662         Use -[NSColorSpace genericRGBColorSpace] instead of the main screen color space.
2663
2664         * WebKitTestRunner/mac/TestInvocationMac.mm: Added.
2665         (WTR::createCGContextFromPlatformView):
2666         (WTR::computeMD5HashStringForContext):
2667         (WTR::dumpBitmap):
2668         (WTR::forceRepaintFunction):
2669         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2670         Add mac specific pixel dumping support. Right now, we always pull pixels
2671         from the window server.
2672
2673         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2674         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2675         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2676         * WebKitTestRunner/win/InjectedBundle.vcproj:
2677         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2678         Add new files.
2679
2680 2011-02-24  Chang Shu  <cshu@webkit.org>
2681
2682         Reviewed by Kenneth Rohde Christiansen.
2683
2684         [Qt] Launch MiniBrowser if the test run is WebKit2. 
2685         https://bugs.webkit.org/show_bug.cgi?id=55145
2686
2687         * Scripts/old-run-webkit-tests:
2688         * Scripts/run-launcher:
2689         * Scripts/webkitdirs.pm:
2690
2691 2011-02-24  Victoria Kirst  <vrk@google.com>
2692
2693         Reviewed by Mihai Parparita.
2694
2695         [chromium] Move media-file.js and video-test.js back to media/ for UILayoutTests
2696         https://bugs.webkit.org/show_bug.cgi?id=55089
2697
2698         This adds an alias into the media/ directory so that http/tests/media
2699         tests can access the media resources when running in an httpd process.
2700
2701         * Scripts/webkitperl/httpd.pm:
2702         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2703         * Scripts/webkitpy/layout_tests/port/http_server.py:
2704
2705 2011-02-24  Andrew Wilson  <atwilson@chromium.org>
2706
2707         Unreviewed, rolling out r79570.
2708         http://trac.webkit.org/changeset/79570
2709         https://bugs.webkit.org/show_bug.cgi?id=54874
2710
2711         Breaks chromium build because glue/mocks/mock_web_frame.h/cc
2712         was not updated
2713
2714         * DumpRenderTree/chromium/TestShell.cpp:
2715         (TestShell::resetTestController):
2716         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2717         (resetDefaultsToConsistentValues):
2718         * DumpRenderTree/mac/DumpRenderTree.mm:
2719         (resetWebViewToConsistentStateBeforeTesting):
2720         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2721         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2722         * DumpRenderTree/win/DumpRenderTree.cpp:
2723         (resetWebViewToConsistentStateBeforeTesting):
2724         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2725         (WTR::InjectedBundlePage::reset):
2726
2727 2011-02-24  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2728
2729         Reviewed by Laszlo Gombos.
2730
2731         [Qt] add android 2.2 user agent to QtTestBrowser
2732         https://bugs.webkit.org/show_bug.cgi?id=55085
2733
2734         Credit to Forrest Hodgkins to find right user-agent which works for youtube.
2735         * QtTestBrowser/useragentlist.txt:
2736
2737 2011-02-24  Adam Roben  <aroben@apple.com>
2738
2739         Change FrameLoadDelegate to support any number of delegates with delayed work to process
2740
2741         This makes our behavior match Mac more closely, and allows us to remove an incorrect
2742         assertion that was firing during some tests. (The assertion was claiming that there was
2743         never more than one delegate with delayed work to process, but that was not the case.)
2744
2745         Fixes <http://webkit.org/b/55146> Assertion failure in FrameLoadDelegate::locationChangeDone
2746         when running http/tests/navigation/back-twice-without-commit.html
2747
2748         Reviewed by Eric Carlson.
2749
2750         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2751         (delegatesWithDelayedWork): Added. Returns all FrameLoadDelegates that have delayed work to
2752         process. A single delegate may appear in this Vector more than once (just as, on Mac, a
2753         single delegate may have multiple performSelector requests).
2754         (processWorkTimer): Pass the HWND to ::KillTimer, for pedantic brownie points. Added an
2755         assertion that the timer firing is the shared process work timer. Instead of using the
2756         single, global "delegate waiting for timer" delegate, give all delegates that have delayed
2757         work to process a chance to process their work.
2758         (FrameLoadDelegate::locationChangeDone): If we don't already have an active timer for
2759         processing delayed work, create one. Then add ourselves to the delegatesWithDelayedWork
2760         Vector so our processWork function will be called when the timer fires.
2761
2762 2011-02-24  Vsevolod Vlasov  <vsevik@chromium.org>
2763
2764         Reviewed by Alexey Proskuryakov.
2765
2766         DumpRenderTree should reset frame opener between tests.
2767         https://bugs.webkit.org/show_bug.cgi?id=54874
2768
2769         Added clearOpener() calls between tests.
2770         Some tests are using window.open() to change current window location.
2771         This changes window.opener property whose nullity is checked before
2772         showing xml viewer.
2773
2774         * DumpRenderTree/chromium/TestShell.cpp:
2775         (TestShell::resetTestController):
2776         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2777         (resetDefaultsToConsistentValues):
2778         * DumpRenderTree/mac/DumpRenderTree.mm:
2779         (resetWebViewToConsistentStateBeforeTesting):
2780         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2781         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2782         * DumpRenderTree/win/DumpRenderTree.cpp:
2783         (resetWebViewToConsistentStateBeforeTesting):
2784         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2785         (WTR::InjectedBundlePage::reset):
2786
2787 2011-02-24  Adam Roben  <aroben@apple.com>
2788
2789         Don't trigger Windows builds for changes to WebCore.exp.in or the top-level GNUmakefile.am
2790
2791         Fixes <http://webkit.org/b/55144> Windows builders should not have built r79343 or r79440,
2792         but did
2793
2794         Reviewed by Anders Carlsson.
2795
2796         * Scripts/webkitpy/common/config/build.py:
2797         (_should_file_trigger_build): Loosened the pattern for GNUmakefile.am to include the
2798         top-level GNUmakefile.am, and loosened the pattern for .exp files to include WebCore.exp.in.
2799
2800         * Scripts/webkitpy/common/config/build_unittest.py:
2801         (ShouldBuildTest): Added some more tests.
2802
2803 2011-02-24  Andras Becsi  <abecsi@webkit.org>
2804
2805         Reviewed by Laszlo Gombos.
2806
2807         [Qt] MinGW build fails to link
2808         https://bugs.webkit.org/show_bug.cgi?id=55050
2809
2810         Prepend the libraries of subcomponents instead of appending them
2811         to fix the library order according to the dependency of the libraries
2812
2813         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2814         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2815
2816 2011-02-24  Gabor Loki  <loki@webkit.org>
2817
2818         Reviewed by Csaba Osztrogonác.
2819
2820         [Qt] Remove ARMv5 Release buildbot.
2821
2822         Remove ARMv5 Release buildbot, because there is very little difference
2823         between ARMv5 and ARMv7 Release bots, and there is also very little
2824         interest in ARMv5 build slave (compared to ARMv7).
2825
2826         * BuildSlaveSupport/build.webkit.org-config/config.json:
2827         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2828
2829 2011-02-22  Ojan Vafai  <ojan@chromium.org>
2830
2831         Reviewed by Tony Chang.
2832
2833         fix revision number finding when creating git patches
2834         https://bugs.webkit.org/show_bug.cgi?id=55024
2835
2836         HEAD~n does not walk merge commits correctly. git log however does.
2837
2838         * Scripts/webkitpy/common/checkout/scm.py:
2839         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2840
2841 2011-02-23  Kenneth Russell  <kbr@google.com>
2842
2843         Unreviewed, rolling out r79387.
2844         https://bugs.webkit.org/show_bug.cgi?id=54885
2845
2846         Reapply the code changes from r79038 since they weren't the root
2847         cause of the test timeouts.
2848
2849         * DumpRenderTree/chromium/WebViewHost.cpp:
2850         (WebViewHost::reset):
2851
2852 2011-02-23  Siddharth Mathur  <siddharth.mathur@nokia.com>
2853
2854         Reviewed by Laszlo Gombos.
2855
2856         [Qt] Make sure Symbian binary UIDs are unique
2857
2858         * MiniBrowser/qt/MiniBrowser.pro: Resolve the UID collision with
2859         QtTestBrowser.pro by changing the UID.
2860
2861 2011-02-23  Patrick Gansterer  <paroga@webkit.org>
2862
2863         Reviewed by Darin Adler.
2864
2865         Rename PLATFORM(CF) to USE(CF)
2866         https://bugs.webkit.org/show_bug.cgi?id=53540
2867
2868         * DumpRenderTree/config.h:
2869
2870 2011-02-23  Dirk Pranke  <dpranke@chromium.org>
2871
2872         Reviewed by Ojan Vafai.
2873
2874         nrwt: turn on multiprocessing on chromium_linux, clean up unit tests for worker model defaults
2875         https://bugs.webkit.org/show_bug.cgi?id=55016
2876
2877         * Scripts/webkitpy/layout_tests/port/base.py:
2878         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2879         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: Added.
2880         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2881         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2882         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2883         * Scripts/webkitpy/layout_tests/port/mac.py:
2884         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2885         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2886         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2887
2888 2011-02-23  Tony Chang  <tony@chromium.org>
2889
2890         Reviewed by Kent Tamura.
2891
2892         [chromium] DumpRenderTree --check-layout-test-sys-deps leaks 4 temp dirs
2893         https://bugs.webkit.org/show_bug.cgi?id=55004
2894
2895         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2896         (WebKitSupportTestEnvironment::WebKitSupportTestEnvironment):
2897         (WebKitSupportTestEnvironment::~WebKitSupportTestEnvironment):
2898         (main): Use a C++ object to ensure that TearDownTestEnvironment
2899             gets called when --check-layout-test-sys-deps is called
2900
2901 2011-02-23  Gopal Raghavan  <gopal.1.raghavan@nokia.com>
2902
2903         Reviewed by Anders Carlsson.
2904
2905         [Qt] [Qt] check webkit style fails in qt/tests
2906         https://bugs.webkit.org/show_bug.cgi?id=54998
2907
2908         check-webkit-style was complaining about missing config.h in WebKit/qt/test/qdeclarativewebview. This patch was originally part of 50222. Reviewer suggested to split and create a separate patch for checker.
2909
2910         * Scripts/webkitpy/style/checker.py:
2911
2912 2011-02-22  Vsevolod Vlasov  <vsevik@chromium.org>
2913
2914         Reviewed by Pavel Feldman.
2915
2916         DumpRenderTree should dump as text if test path contains "dumpAsText/"
2917         https://bugs.webkit.org/show_bug.cgi?id=54873
2918
2919         * DumpRenderTree/chromium/LayoutTestController.h:
2920         (LayoutTestController::setShouldDumpAsText):
2921         (LayoutTestController::setShouldGeneratePixelResults):
2922         * DumpRenderTree/chromium/TestShell.cpp:
2923         (TestShell::runFileTest):
2924         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2925         (shouldDumpAsText):
2926         (dump):
2927         (runTest):
2928         * DumpRenderTree/mac/DumpRenderTree.mm:
2929         (shouldDumpAsText):
2930         (runTest):
2931         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2932         (WebCore::isDumpAsTextTest):
2933         (WebCore::DumpRenderTree::open):
2934         * DumpRenderTree/win/DumpRenderTree.cpp:
2935         (shouldDumpAsText):
2936         (runTest):
2937         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2938         (WTR::InjectedBundlePage::dump):
2939
2940 2011-02-22  Kenneth Russell  <kbr@google.com>
2941
2942         Reviewed by James Robinson.
2943
2944         Many tests started timing out on the chrome mac canaries around r79035
2945         https://bugs.webkit.org/show_bug.cgi?id=54885
2946
2947         Revert the code changes, but not the Chromium DEPS roll, from
2948         r79038 to see whether this clears up the timing-out tests. Was not
2949         able to reproduce the timeouts locally with a Release mode build
2950         of DRT (on Snow Leopard).
2951
2952         * DumpRenderTree/chromium/WebViewHost.cpp:
2953         (WebViewHost::reset):
2954
2955 2011-02-22  Dirk Pranke  <dpranke@chromium.org>
2956
2957         Reviewed by James Robinson.
2958
2959         nrwt: --platform chromium-gpu doesn't work with --worker-model=processes
2960         https://bugs.webkit.org/show_bug.cgi?id=55009
2961
2962         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2963
2964 2011-02-18  Mihai Parparita  <mihaip@chromium.org>
2965
2966         Reviewed by Ojan Vafai.
2967
2968         Default to 500 for --exit-after-n-failures
2969         https://bugs.webkit.org/show_bug.cgi?id=54773
2970
2971         Make 500 the default value for --exit-after-n-failures (ORWT bots
2972         already default to this as of r75726). Similarly, change the default for
2973         --exit-after-n-crashes-or-timeouts to 20.
2974
2975         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2976
2977 2011-02-02  Martin Robinson  <mrobinson@igalia.com>
2978
2979         Reviewed by Xan Lopez.
2980
2981         [GTK] DRT needs an implementation of LayoutTestController.setSelectTrailingWhitespace
2982         https://bugs.webkit.org/show_bug.cgi?id=53603
2983
2984         Add support for LayoutTestController.setSelectTrailingWhitespace by calling through
2985         to DumpRenderTreeSupportGtk for this functionality.
2986
2987         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2988         (resetDefaultsToConsistentValues): Always call LayoutTestController.setSelectTrailingWhitespace to
2989         false when reseting values between tests.
2990         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2991         (LayoutTestController::setSelectTrailingWhitespaceEnabled): Call LayoutTestController.setSelectTrailingWhitespace
2992         with the appropriate value.
2993
2994 2011-02-22  Adam Roben  <aroben@apple.com>
2995
2996         Don't trigger a Windows build when the top-level ChangeLog changes
2997
2998         r79320 is an example of a change that shouldn't have built on Windows, but did, because of
2999         this bug.
3000
3001         Fixes <http://webkit.org/b/54957> Windows bots build when top-level ChangeLog changes, but
3002         shouldn't
3003
3004         Reviewed by Anders Carlsson.
3005
3006         * Scripts/webkitpy/common/config/build.py:
3007         (_should_file_trigger_build): Modified the ChangeLog pattern to match the top-level
3008         ChangeLog, and re-sorted it in the list.
3009
3010         * Scripts/webkitpy/common/config/build_unittest.py:
3011         (ShouldBuildTest): Added a test that ChangeLogs don't trigger builds.
3012
3013 2011-02-22  Sheriff Bot  <webkit.review.bot@gmail.com>
3014
3015         Unreviewed, rolling out r78691.
3016         http://trac.webkit.org/changeset/78691
3017         https://bugs.webkit.org/show_bug.cgi?id=54956
3018
3019         Leopard Debug is successfully building again (Requested by
3020         aroben on #webkit).
3021
3022         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3023         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3024
3025 2011-02-22  Ilya Tikhonovsky  <loislo@chromium.org>
3026
3027         Reviewed by Pavel Feldman.
3028
3029         Web Inspector: flakyness of inspector tests.
3030         https://bugs.webkit.org/show_bug.cgi?id=54729
3031
3032         As far as we have the protocol with sequence numbers we can simplify test harness support
3033         and drop out chomium specific methods.
3034
3035         * DumpRenderTree/DumpRenderTree.gypi:
3036         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
3037         (DRTDevToolsAgent::sendMessageToInspectorFrontend):
3038         (DRTDevToolsAgent::runtimePropertyChanged):
3039         (DRTDevToolsAgent::asyncCall):
3040         (DRTDevToolsAgent::call):
3041         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3042         * DumpRenderTree/chromium/DRTDevToolsCallArgs.cpp: Removed.
3043         * DumpRenderTree/chromium/DRTDevToolsCallArgs.h: Removed.
3044         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
3045         (DRTDevToolsClient::sendMessageToBackend):
3046         (DRTDevToolsClient::asyncCall):
3047         (DRTDevToolsClient::call):
3048         * DumpRenderTree/chromium/DRTDevToolsClient.h:
3049
3050 2011-02-22  Andras Becsi  <abecsi@webkit.org>
3051
3052         Reviewed by Laszlo Gombos.
3053
3054         [Qt] Redesign the build system
3055         https://bugs.webkit.org/show_bug.cgi?id=51339
3056
3057         Part 2.
3058
3059         Build WebCore as a static library, compile the WebKit API and WebKit2 API
3060         in a final step and link to WebKit2, WebCore and JSC libraries to fix
3061         linking issues resulting from stripped away symbols.
3062
3063         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Remove superfluous includepaths.
3064
3065 2011-02-21  Lukasz Slachciak  <l.slachciak@samsung.com>
3066
3067         Reviewed by Antonio Gomes.
3068
3069         [EFL] Restored spatial navigation option in EWebLauncher since #18662 bug is closed
3070         https://bugs.webkit.org/show_bug.cgi?id=54806
3071
3072         * EWebLauncher/main.c:
3073         (on_key_down): calling ewk_view_setting_spatial_navigation_set when "F12" pressed added.
3074
3075 2011-02-21  Dirk Pranke  <dpranke@chromium.org>
3076
3077         Reviewed by Kent Tamura.
3078
3079         nrwt: revert behavior on 10.5 to "old-threads". It's possible
3080         that r79062 has introduced a bunch of flakiness, although I
3081         can't explain why right now. This change should restore the
3082         old behavior, and then we can look at the build logs to see
3083         if the tests stop timing out or being flaky.
3084
3085         https://bugs.webkit.org/show_bug.cgi?id=54925
3086
3087         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3088         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3089         * Scripts/webkitpy/layout_tests/port/mac.py:
3090         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3091
3092 2011-02-21  Dirk Pranke  <dpranke@chromium.org>
3093
3094         Reviewed by Dimitri Glazkov.
3095
3096         nrwt: fix typo causing us to try and repeatedly shut down the servers
3097         https://bugs.webkit.org/show_bug.cgi?id=54904
3098
3099         * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
3100
3101 2011-02-21  Alejandro G. Castro  <alex@igalia.com>
3102
3103         Reviewed by Csaba Osztrogonác.
3104
3105         REGRESSION(r79157):
3106         plugins/get-url-with-javascript-destroying-plugin.html make the
3107         next test crash
3108         https://bugs.webkit.org/show_bug.cgi?id=54863
3109
3110         * GNUmakefile.am:
3111
3112 2011-02-20  Dirk Pranke  <dpranke@chromium.org>
3113
3114         Reviewed by Ojan Vafai.
3115
3116         test-webkitpy: stop skipping a bunch of tests on win32
3117         https://bugs.webkit.org/show_bug.cgi?id=54788
3118
3119         * Scripts/webkitpy/common/net/testoutputset_unittest.py:
3120         * Scripts/webkitpy/test/main.py:
3121
3122 2011-02-20  Dirk Pranke  <dpranke@chromium.org>
3123
3124         Reviewed by Ojan Vafai.
3125
3126         Fix various bugs related to handling of dir separators and real
3127         vs. fake filesystems that were causing test-webkitpy to fail
3128         tests on win32. These bugs have a variety of causes but are
3129         lumped together because they should be easy to review.
3130
3131         https://bugs.webkit.org/show_bug.cgi?id=54700
3132
3133         * Scripts/webkitpy/common/net/testoutput.py:
3134           Here we were using os.path.sep but not escaping it prior to
3135           using in a regexp, which  caused bad things on win32.
3136         * Scripts/webkitpy/common/net/testoutput_unittest.py:
3137           Same here.
3138         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3139           Here we were using the native filesystem instead of the mock
3140           filesystem, making some tests unnecessarily platform dependent.
3141           Also we weren't setting the default configuration for the
3142           TestChromiumWinPort.
3143         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py:
3144           Here we *shouldn't* use os.path.join(), just so the code becomes
3145           less platform dependent.
3146         * Scripts/webkitpy/style/checker.py:
3147           Here we should be using os.path.sep instead of "/"; the tests
3148           require the native filesystem.
3149         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3150           Here the underlying code is using os.path.sep, so we probably
3151           should as well.
3152         * Scripts/webkitpy/style/test_expectations_unittest.py:
3153           Here we should be using the filesystem hanging of the port
3154           object (which is the mocked filesystem) rather than the native
3155           one.
3156
3157 2011-02-20  Anders Carlsson  <andersca@apple.com>
3158
3159         Reviewed by Maciej Stachowiak.
3160
3161         Crash when a plug-in requests a javascript: url that destroys the plug-in
3162         https://bugs.webkit.org/show_bug.cgi?id=54837
3163         <rdar://problem/9005475>
3164
3165         Add new plug-in test.
3166
3167         * DumpRenderTree/DumpRenderTree.gypi:
3168         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3169         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3170         (PluginTest::NPN_GetURL):
3171         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3172         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURLDestroyingPlugin.cpp: Added.
3173         (GetURLWithJavaScriptURLDestroyingPlugin::GetURLWithJavaScriptURLDestroyingPlugin):
3174         (GetURLWithJavaScriptURLDestroyingPlugin::NPP_New):
3175         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3176         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3177
3178 2011-02-19  Patrick Gansterer  <paroga@webkit.org>
3179
3180         Reviewed by Andreas Kling.
3181
3182         Make WinCE a core builder
3183         https://bugs.webkit.org/show_bug.cgi?id=54801
3184
3185         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3186         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3187
3188 2011-02-19  Lukasz Slachciak  <l.slachciak@samsung.com>
3189
3190         Reviewed by Andreas Kling.
3191
3192         Fixed problem with launching EWebLauncher with "run-launcher --efl". Incorrect path referring to non-existing .libs directory ws set.
3193         https://webkit.org/b/54778
3194
3195         * Scripts/webkitdirs.pm:
3196
3197 2011-02-18  David Levin  <levin@chromium.org>
3198
3199         Reviewed by Eric Seidel.
3200
3201         check-webkit-style: Misses brace style error when the line with the { has a } in it.
3202         https://bugs.webkit.org/show_bug.cgi?id=54769
3203
3204         * Scripts/webkitpy/style/checkers/cpp.py: Fixed the check for the close brace
3205           to only look after the last open brace, so that the open brace in this line
3206           "} else {" will still be able to trigger the error.
3207         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added related unit tests.
3208
3209 2011-02-18  Zan Dobersek  <zandobersek@gmail.com>
3210
3211         Reviewed by Martin Robinson.
3212
3213         [Gtk] Re-enable meter tag support
3214         https://bugs.webkit.org/show_bug.cgi?id=54762
3215
3216         Meter tag is supported on the Gtk port, enable it by default.
3217
3218         * Scripts/build-webkit:
3219
3220 2011-02-18  David Levin  <levin@chromium.org>
3221
3222         Reviewed by Eric Seidel.
3223
3224         check-webkit-style falsely complains about WebKitGTK+ public headers
3225         https://bugs.webkit.org/show_bug.cgi?id=54650
3226
3227         * Scripts/webkitpy/style/checker.py: Add some exceptions for the gtk files.
3228         * Scripts/webkitpy/style/checkers/cpp.py: Restrict the checks for WEBKIT_API
3229           to the chromium directory (and improved the checks slightly).
3230         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added corresponding tests.
3231
3232 2011-02-18  Dirk Pranke  <dpranke@chromium.org>
3233
3234         Reviewed by James Robinson.
3235
3236         new-run-webkit-tests: enable multiple processes by default on
3237         mac. This change removes the artificial restrictions we placed
3238         on the # of child processes we used with the old threading
3239         model, and switches to the new message-based model and multiple
3240         processes, where available. If multiple processes are not
3241         available (Leopard / Python 2.5), then we use the 'inline' model
3242         instead of the 'old-threads' model on the 'mac' port or one
3243         process on the 'chromium-mac' port. We need additional testing
3244         to see if the new 'threads' model works reliably and is worth
3245         supporting, or if we should just live with things being slightly
3246         slow.
3247
3248         https://bugs.webkit.org/show_bug.cgi?id=54596
3249
3250         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3251         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3252         * Scripts/webkitpy/layout_tests/port/mac.py:
3253         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3254         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3255
3256 2011-02-18  Andrew Wilson  <atwilson@chromium.org>
3257
3258         Unreviewed, rolling out r79047.
3259         http://trac.webkit.org/changeset/79047
3260         https://bugs.webkit.org/show_bug.cgi?id=54596
3261
3262         Broke canary bots - please watch the canaries the next time
3263         you land this
3264
3265         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3266         * Scripts/webkitpy/layout_tests/port/mac.py:
3267
3268 2011-02-18  Emil A Eklund  <eae@chromium.org>
3269
3270         Reviewed by Darin Adler.
3271
3272         Crash in EventHandler::sendContextMenuEventForKey
3273         https://bugs.webkit.org/show_bug.cgi?id=54495
3274
3275         Add support for the context menu key (VK_APPS) to EventSender for
3276         platforms that support the key.
3277
3278         * DumpRenderTree/chromium/EventSender.cpp:
3279         (EventSender::keyDown):
3280         * DumpRenderTree/gtk/EventSender.cpp:
3281         (keyDownCallback):
3282         * DumpRenderTree/qt/EventSenderQt.cpp:
3283         (EventSender::keyDown):
3284         * DumpRenderTree/win/EventSender.cpp:
3285         (keyDownCallback):
3286
3287 2011-02-18  Dirk Pranke  <dpranke@chromium.org>
3288
3289         Reviewed by Ojan Vafai.
3290
3291         new-run-webkit-tests: enable multiple processes by default on mac
3292         https://bugs.webkit.org/show_bug.cgi?id=54596
3293
3294         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3295         * Scripts/webkitpy/layout_tests/port/mac.py:
3296
3297 2011-02-18  Dirk Pranke  <dpranke@chromium.org>
3298
3299         Reviewed by Adam Roben.
3300
3301         Skip pretty patch unit tests if ruby isn't installed.
3302
3303         https://bugs.webkit.org/show_bug.cgi?id=54699
3304
3305         * Scripts/webkitpy/common/prettypatch_unittest.py:
3306
3307 2011-02-18  Dirk Pranke  <dpranke@chromium.org>
3308
3309         Reviewed by Adam Roben.
3310
3311         Skip mac.test_skipped_file_paths() when running on win32; the
3312         test has hardcoded '/' directory separators and since it's a
3313         port-specific test and we have coverage on other ports it's not
3314         worth it to make the test more generic.
3315
3316         https://bugs.webkit.org/show_bug.cgi?id=54698
3317
3318         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3319
3320 2011-02-18  Dirk Pranke  <dpranke@chromium.org>
3321
3322         Reviewed by Adam Roben.
3323
3324         Fix webkitpy.layout_tests.port.config_unittest to work on Win32.
3325
3326         https://bugs.webkit.org/show_bug.cgi?id=54703
3327
3328         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3329
3330 2011-02-18  Dirk Pranke  <dpranke@chromium.org>
3331
3332         Reviewed by Adam Roben.
3333
3334         Change the default port we're mocking out on win32 when we
3335         run mock_drt_unittest. Normally we'd default to the
3336         port-specific default, but that would be "win", which doesn't
3337         currently work.
3338
3339         https://bugs.webkit.org/show_bug.cgi?id=54708
3340
3341         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3342
3343 2011-02-18  Kenneth Russell  <kbr@google.com>
3344
3345         Reviewed by James Robinson.
3346
3347         [chromium] Clean up initialization of minimum timer interval
3348         https://bugs.webkit.org/show_bug.cgi?id=54772
3349
3350         Use new GetForegroundTabTimerInterval function in webkit_support
3351         to reset the minimum timer interval before each test.
3352
3353         * DumpRenderTree/chromium/WebViewHost.cpp:
3354         (WebViewHost::reset):
3355
3356 2011-02-18  Dirk Pranke  <dpranke@chromium.org>
3357
3358         Reviewed by Adam Roben.
3359
3360         r78494 fixed the chromium_win unittest failing under win32,
3361         but not cygwin. This fixes cygwin as well.
3362
3363         https://bugs.webkit.org/show_bug.cgi?id=54652
3364
3365         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3366
3367 2011-02-18  Dirk Pranke  <dpranke@chromium.org>
3368
3369         Reviewed by Ojan Vafai, Mihai Parparita.
3370
3371         new-run-webkit-tests: r78522 made it impossible to create a
3372         'chromium-win' or 'chromium-mac' port; they would always get the
3373         version tacked on to the end. It turns out that we actually need
3374         to be able to create these ports in order for
3375         rebaseline-chromium-webkit-tests to work correctly given the
3376         broken coverage of our layout bots. As soon as we get SL and
3377         Win 7 bots running reliably on the canaries, we can get rid of
3378         this change. Note that we only need to change the chromium_mac
3379         and win ports because linux doesn't yet use versions and that
3380         script doesn't work with non-chromium ports.
3381
3382         Also, this change fixes a bug where we were using
3383         "platform/chromium-win-win7" and
3384         "platform/chromium-mac-snowleopard" as the baseline dirs for
3385         Win 7 and SL; we should've been using the generic directories
3386         instead since they are the newest versions of the os's.
3387
3388         https://bugs.webkit.org/show_bug.cgi?id=54691
3389
3390         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3391         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3392         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3393         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3394         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3395
3396 2011-02-16  MORITA Hajime  <morrita@google.com>
3397
3398         Reviewed by Kent Tamura.
3399
3400         [Chromium][DRT] some PostDelayedTask() accesses possibly dangling this pointer.
3401         http://webkit.org/b/53899
3402
3403         Replaced static invocation wrappers with MethodTask objects,
3404         which are removed on WebViewHost destructor.
3405         
3406         * DumpRenderTree/chromium/WebViewHost.cpp:
3407         (WebViewHost::requestCheckingOfText):
3408         (WebViewHost::scheduleAnimation):
3409         (WebViewHost::closeWidgetSoon):
3410         * DumpRenderTree/chromium/WebViewHost.h:
3411         (WebViewHost::HostMethodTask::HostMethodTask):
3412         (WebViewHost::HostMethodTask::runIfValid):
3413         (WebViewHost::taskList):
3414
3415 2011-02-07  Hayato Ito  <hayato@chromium.org>
3416
3417         Reviewed by Ojan Vafai.
3418
3419         Get rid of code which writes test results from test_type's
3420         compare_output() method.
3421         Writing test results now happens in single_test_runner, using
3422         newly introduced test_result_writer module.
3423
3424         Subsequent patches will eliminate test_type/* classes.
3425
3426         https://bugs.webkit.org/show_bug.cgi?id=53908
3427
3428         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
3429         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: Added.
3430         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
3431         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
3432         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3433
3434 2011-02-17  Dirk Pranke  <dpranke@chromium.org>
3435
3436         Reviewed by Adam Roben.
3437
3438         Add blacklist of remaining webkitpy/* modules that fail on
3439         Win32, so that test-webkitpy will at least run cleanly.
3440
3441         https://bugs.webkit.org/show_bug.cgi?id=54709
3442
3443         * Scripts/webkitpy/layout_tests/test/main.py:
3444
3445 2011-02-17  Simon Fraser  <simon.fraser@apple.com>
3446
3447         Reviewed by Sam Weinig.
3448
3449         Set a preference to ensure that scrollbars are in a predictable
3450         state for DRT.
3451
3452         * DumpRenderTree/mac/DumpRenderTree.mm:
3453         (resetDefaultsToConsistentValues):
3454
3455 2011-02-17  Dirk Pranke  <dpranke@chromium.org>
3456
3457         Reviewed by Adam Roben.
3458
3459         test-webkitpy doesn't work with the multiprocessing module on win32
3460         or cygwin, so we skip it for now.
3461
3462         https://bugs.webkit.org/show_bug.cgi?id=54520
3463
3464         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
3465         * Scripts/webkitpy/layout_tests/layout_package/run_webkit_tests_unittest.py:
3466
3467 2011-02-17  Dirk Pranke  <dpranke@chromium.org>
3468
3469         Reviewed by Adam Roben.
3470
3471         Fix version, baseline_search_path for chromium-win-win7. Also
3472         fix chromium_win_unittests, and fix port_testcase.make_port()
3473         to correctly use the options passed into it and only set
3474         results_directory() if necessary.
3475
3476         https://bugs.webkit.org/show_bug.cgi?id=54652
3477
3478         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3479         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3480         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3481
3482 2011-02-17  Dirk Pranke  <dpranke@chromium.org>
3483
3484         Reviewed by Ojan Vafai.
3485
3486         Fix a hang in new-run-webkit-tests when run with
3487         --dry-run --worker-model=processes
3488
3489         https://bugs.webkit.org/show_bug.cgi?id=54595
3490
3491         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
3492         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3493
3494 2011-02-17  Kevin Ollivier  <kevino@theolliviers.com>
3495
3496         [wx] Build fixes after recent changes.
3497
3498         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3499         (LayoutTestController::setMinimumTimerInterval):
3500         * wx/build/settings.py:
3501
3502 2011-02-17  Csaba Osztrogonác  <ossy@webkit.org>
3503
3504         Reviewed by Andreas Kling.
3505
3506         [Qt] ImageDiff sometimes hangs
3507         https://bugs.webkit.org/show_bug.cgi?id=54641
3508
3509         * DumpRenderTree/qt/ImageDiff.cpp: Clear actualImage and baselineImage after all comparison.
3510         (main):
3511
3512 2011-02-17  Peter Varga  <pvarga@webkit.org>
3513
3514         Reviewed by Csaba Osztrogonác.
3515
3516         The run-sunspider --v8-suite doesn't work
3517         https://bugs.webkit.org/show_bug.cgi?id=54660
3518
3519         * Scripts/run-sunspider:
3520
3521 2011-02-17  Gabor Rapcsanyi  <rgabor@webkit.org>
3522
3523         Reviewed by Csaba Osztrogonác.
3524
3525         [NRWT] Fix environment setup on Qt port.
3526         https://bugs.webkit.org/show_bug.cgi?id=54549
3527
3528         * Scripts/webkitpy/layout_tests/port/qt.py:
3529
3530 2011-02-16  Yael Aharon  <yael.aharon@nokia.com>
3531
3532         Reviewed by Andreas Kling.
3533
3534         [Qt] Enable tiled backing store by default in MiniBrowser.
3535         https://bugs.webkit.org/show_bug.cgi?id=54581
3536
3537         Instead of a flag to turn it on, a new flag is defined to turn
3538         tiled backing store off.
3539
3540         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3541         (MiniBrowserApplication::handleUserOptions):
3542         * MiniBrowser/qt/MiniBrowserApplication.h:
3543         (WindowOptions::WindowOptions):
3544
3545 2011-02-16  Eric Seidel  <eric@webkit.org>
3546
3547         Reviewed by Mihai Parparita.
3548
3549         flaky test archive uploads are always 22 bytes long
3550         https://bugs.webkit.org/show_bug.cgi?id=54593
3551
3552         Speculative fix for the 22-bytes bug.
3553
3554         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3555
3556 2011-02-16  Anna Cavender  <annacc@chromium.org>
3557
3558         Reviewed by Mihai Parparita.
3559
3560         http/tests/media should be served over HTTP (not from local file)
3561         https://bugs.webkit.org/show_bug.cgi?id=54028
3562
3563         Removed special file:// treatment of http/tests/media
3564
3565         * Scripts/old-run-webkit-tests:
3566         * Scripts/webkitpy/layout_tests/port/base.py:
3567
3568 2011-02-16  Mihai Parparita  <mihaip@chromium.org>
3569
3570         Reviewed by Ojan Vafai.
3571
3572         ChangeLog.parse_latest_entry_from_file does not handle rolled over ChangeLogs
3573         https://bugs.webkit.org/show_bug.cgi?id=54609
3574         
3575         r78737 rolled over ChangeLogs, and webkit-patch complains when landing
3576         patches such as this one that are the first to add an entry to the
3577         ChangeLog (since they don't see a second date line to know where the
3578         entry ends).
3579
3580         * Scripts/webkitpy/common/checkout/changelog.py:
3581         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3582
3583 == Rolled over to ChangeLog-2011-02-16 ==