More debug queue build fixing.
[WebKit-https.git] / Tools / ChangeLog
1 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
2
3         More debug queue build fixing.
4
5         Preserve the build style in one more place. Changed mock build_style from "both"
6         to "release", as we don't support testing both debug and release.
7
8         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
9         (MockCommitQueue.archive_last_test_results):
10         (MockCommitQueue):
11         (MockCommitQueue.build_style):
12         (MockCommitQueue.did_pass_testing_ews):
13         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
14         (PatchAnalysisTask._test):
15         (PatchAnalysisTask._build_and_test_without_patch):
16         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
17         (EarlyWarningSystemTest._default_expected_logs):
18         * Scripts/webkitpy/tool/commands/queues_unittest.py:
19
20 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
21
22         More debug queue build fixing.
23
24         Add build_style argument to derived classes as well.
25
26         * Scripts/webkitpy/common/config/ports.py:
27         (MacPort):
28         (MacPort.run_webkit_tests_command):
29         (WinPort.run_bindings_tests_command):
30         (WinPort):
31         (WinPort.run_webkit_tests_command):
32         (GtkWK2Port.build_webkit_command):
33         (GtkWK2Port):
34         (GtkWK2Port.run_webkit_tests_command):
35
36 2015-10-13  Myles C. Maxfield  <mmaxfield@apple.com>
37
38         [iOS] Build fix
39
40         Unreviewed.
41
42         Mach-O section names are limited to 16 characters.
43
44         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
45         * DumpRenderTree/mac/DumpRenderTree.mm:
46         (activateFontsIOS):
47
48 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
49
50         Build fix for mac-debug EWS queue.
51
52         Unreviewed.
53
54         Pass --debug to run-webkit-tests.
55
56         While at it, removed unsupported run_webkit_unit_tests_command. All the test steps
57         will need to be substantially modified to work in EWS, so the dummy implementation
58         was not helpful.
59
60         * Scripts/webkitpy/common/config/ports.py:
61         (DeprecatedPort.run_javascriptcore_tests_command):
62         (DeprecatedPort):
63         (DeprecatedPort.run_webkit_tests_command):
64         (DeprecatedPort.run_python_unittests_command):
65         (DeprecatedPort.run_webkit_unit_tests_command): Deleted.
66         * Scripts/webkitpy/common/config/ports_mock.py:
67         (MockPort.run_javascriptcore_tests_command):
68         (MockPort):
69         (MockPort.run_webkit_tests_command):
70         (MockPort.run_bindings_tests_command):
71         (MockPort.run_webkit_unit_tests_command): Deleted.
72         * Scripts/webkitpy/tool/commands/download_unittest.py:
73         * Scripts/webkitpy/tool/steps/runtests.py:
74         (RunTests.run):
75         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
76         (RunTestsTest.test_webkit_run_unit_tests):
77         * Scripts/webkitpy/tool/steps/steps_unittest.py:
78         (StepsTest.test_runtests_args):
79
80 2015-10-13  Brent Fulgham  <bfulgham@apple.com>
81
82         [Win] Generate Crash Traces
83         https://bugs.webkit.org/show_bug.cgi?id=150103
84
85         Reviewed by Daniel Bates.
86
87         We were using an exception filter to try to emit "#CRASHED" to stderr
88         when a test program crashed. However, the modern Python implementation
89         seems capable of recognizing crashes on its own. Furthermore, registering
90         the exception handler was preventing the JIT debugger (NTSD) from
91         automatically attaching to the crashing program, so we were not getting
92         crash traces.
93         
94         * DumpRenderTree/win/DumpRenderTree.cpp:
95         (main): Don't register an exception filter.
96         (exceptionFilter): Deleted.
97         * Scripts/webkitpy/common/system/crashlogs.py:
98         (CrashLogs): Add another regular expression to handle a second crash trace
99         syntax I encountered during testing.
100         (CrashLogs._find_newest_log_win): If the old regular expression doesn't match,
101         try the new one. The PID found by the new expression is in hexadecimal, so
102         convert it to an integer before returning it.
103         * Scripts/webkitpy/port/driver.py:
104         (Driver._check_for_driver_crash_or_unresponsiveness): Windows was not recognizing
105         the "#CRASHED" state because it was appending '\r\n', rather than just '\r'. Instead,
106         check for "#CRASHED" after stripping off the EOL characters.
107         * Scripts/webkitpy/port/win.py:
108         (WinPort.setup_crash_log_saving): Put back the '-e %ld' flag in the debugger
109         invocation. This is apparently used to signal an event when the debugger is finished.
110
111 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
112
113         Mac Debug and 32-bit queues should be separate
114         https://bugs.webkit.org/show_bug.cgi?id=150092
115
116         Reviewed by Lucas Forschler.
117
118         * QueueStatusServer/config/queues.py:
119         * QueueStatusServer/model/queues.py:
120         (Queue._capitalize_after_dash):
121         (Queue._caplitalize_after_dash): Deleted.
122         * Scripts/webkitpy/common/config/ews.json:
123
124 2015-10-13  Sergio Villar Senin  <svillar@igalia.com>
125
126         [GTK] Fix build for ENABLE_TOUCH_EVENTS=OFF
127         https://bugs.webkit.org/show_bug.cgi?id=150085
128
129         Reviewed by Carlos Garcia Campos.
130
131         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
132
133 2015-10-13  Sebastian Dröge  <sebastian@centricular.com>
134
135         Unreviewed, add myself to the committers list.
136
137         * Scripts/webkitpy/common/config/contributors.json:
138
139 2015-10-12  Alexey Proskuryakov  <ap@apple.com>
140
141         Update bot watcher's dashboard to reflect that EWS is on iOS 9 now
142         https://bugs.webkit.org/show_bug.cgi?id=149983
143
144         Reviewed by Dan Bates.
145
146         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
147         (BubbleQueueServer):
148         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
149
150 2015-10-12  Alexey Proskuryakov  <ap@apple.com>
151
152         Fix webkitpy tests after r190922.
153
154         * Scripts/webkitpy/common/config/ews.json:
155         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
156         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
157
158 2015-10-12  Alexey Proskuryakov  <ap@apple.com>
159
160         Add a Mac debug EWS queue
161         https://bugs.webkit.org/show_bug.cgi?id=150069
162
163         Reviewed by Geoffrey Garen.
164
165         * QueueStatusServer/config/queues.py:
166         * Scripts/webkitpy/common/config/ews.json:
167         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
168         (AbstractEarlyWarningSystem):
169         (AbstractEarlyWarningSystem.archive_last_test_results):
170         (AbstractEarlyWarningSystem.build_style):
171         (AbstractEarlyWarningSystem.refetch_patch):
172         (AbstractEarlyWarningSystem.load_ews_classes):
173
174 2015-10-12  Mario Sanchez Prada  <mario@endlessm.com>
175
176         [GTK] Update jhbuild's version of harfbuzz
177         https://bugs.webkit.org/show_bug.cgi?id=149749
178
179         Reviewed by Martin Robinson.
180
181         Update harfbuzz to 0.9.35, following the lead of Debian Stable.
182
183         * gtk/jhbuild.modules: Updated details for harfbuzz.
184
185 2015-10-12  Mario Sanchez Prada  <mario@endlessm.com>
186
187         [GTK] Media tests crashing with gst-plugins-bad 1.4.4 and cpp 5.2
188         https://bugs.webkit.org/show_bug.cgi?id=150026
189
190         Reviewed by Philippe Normand.
191
192         Backport upstream patch from gst-plugins-bad so that the right version
193         of FAAD2 can be found with newer versions of cpp, so that gst-plugins-bad
194         gets compiled properly, avoiding crashes on runtime while running tests.
195
196         * gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Added.
197         * gtk/jhbuild.modules: Referenced the newly added patch for gst-plugins-bad.
198
199 2015-10-11  Myles C. Maxfield  <mmaxfield@apple.com>
200
201         Test font-variant-* and font-feature-settings with mocked preinstalled fonts
202         https://bugs.webkit.org/show_bug.cgi?id=149777
203
204         Reviewed by Simon Fraser.
205
206         Include FontWithFeatures in DumpRenderTree and WebKitTestRunner. Add it
207         to the list of tests to preinstall at startup time.
208
209         Also, update the generation of the 'name' table in the FontWithFeatures font.
210
211         * DumpRenderTree/mac/DumpRenderTree.mm:
212         (allowedFontFamilySet):
213         (activateTestingFonts):
214         (activateFontsIOS):
215         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
216         (Generator::generate):
217         (Generator::appendCFFTable):
218         (Generator::appendNameSubtable):
219         (Generator::appendNAMETable):
220         * FontWithFeatures/FontWithFeatures/main.cpp:
221         (main):
222         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
223         (WTR::allowedFontFamilySet):
224         (WTR::activateFonts):
225         * WebKitTestRunner/mac/TestControllerMac.mm:
226         (WTR::allowedFontFamilySet):
227
228 2015-10-11  Jinyoung Hur  <hur.ims@navercorp.com>
229
230         Unreviewed. Add Jinyoung Hur as a committer. 
231
232         * Scripts/webkitpy/common/config/contributors.json:
233
234 2015-10-10  Dan Bernstein  <mitz@apple.com>
235
236         [iOS] Remove unnecessary iOS version checks
237         https://bugs.webkit.org/show_bug.cgi?id=150002
238
239         Reviewed by Alexey Proskuryakov.
240
241         * WebKitTestRunner/ios/HIDEventGenerator.mm:
242         (-[HIDEventGenerator _createIOHIDEventType:]):
243         (-[HIDEventGenerator _sendHIDEvent:]):
244         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
245         * WebKitTestRunner/ios/UIKitSPI.h:
246
247 2015-10-09  Myles C. Maxfield  <mmaxfield@apple.com>
248
249         Unreviewed, rolling out r190689
250         https://bugs.webkit.org/show_bug.cgi?id=149992
251
252         Fixed in other repository.
253
254         Reverted changesets:
255
256         "Unreviewed, rolling out r190572, r190593, r190594, and r190639."
257         https://bugs.webkit.org/show_bug.cgi?id=149897
258
259 2015-10-09  Brian Burg  <bburg@apple.com>
260
261         Teach webkitperl how to figure out IOS versions from the SDK
262         https://bugs.webkit.org/show_bug.cgi?id=149963
263
264         Reviewed by Daniel Bates.
265
266         It should be easier to check the major and minor version of IOS SDKs.
267
268         * Scripts/copy-webkitlibraries-to-product-directory: use iosVersion().
269         * Scripts/webkitdirs.pm:
270         (splitVersionString): Added.
271         (determineOSXVersion): Use splitVersionString.
272         (determineIOSVersion): Added. Look at the SDK version and make a tuple.
273         (iosVersion): Added.
274
275 2015-10-09  Simon Fraser  <simon.fraser@apple.com>
276
277         [iOS WK2] Fix some leaks in TestRunnerWKWebView and UIScriptContext
278         https://bugs.webkit.org/show_bug.cgi?id=149960
279
280         Reviewed by Tim Horton.
281         
282         Use adoptWK(), and null out some members (file is not using ARC).
283
284         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
285         (UIScriptContext::uiScriptComplete):
286         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
287         (-[TestRunnerWKWebView dealloc]):
288
289 2015-10-09  Csaba Osztrogonác  <ossy@webkit.org>
290
291         Remove ENABLE_SUID_SANDBOX_LINUX cruft
292         https://bugs.webkit.org/show_bug.cgi?id=149954
293
294         Reviewed by Darin Adler.
295
296         * Scripts/webkitperl/FeatureList.pm:
297
298 2015-10-09  Daniel Bates  <dabates@apple.com>
299
300         Make iOS builders generate debug information in a separate dSYM file
301         https://bugs.webkit.org/show_bug.cgi?id=149696
302
303         Reviewed by Darin Adler.
304
305         Similar to the Mac builders, the iOS builders should write debug information
306         into a separate dSYM file instead of including such information in the binary
307         itself (default Xcode behavior)
308
309         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
310         (CompileWebKit.start):
311
312 2015-10-09  Csaba Osztrogonác  <ossy@webkit.org>
313
314         Fix webkitpy tests after r190779
315         https://bugs.webkit.org/show_bug.cgi?id=149949
316
317         Reviewed by Ryosuke Niwa.
318
319         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
320         (BenchmarkResults.format):
321         (BenchmarkResults._format_values):
322
323 2015-10-08  Dewei Zhu  <dewei_zhu@apple.com>
324
325         Extend run-benchmark script to support human-readable results conversion.
326         https://bugs.webkit.org/show_bug.cgi?id=149944
327
328         Reviewed by Ryosuke Niwa.
329
330         Add '--read-results-json' and '--no-adjust-unit' options.
331         '--read-results-json' option converts result file to human readable format.
332         '--no-adjust-unit' option skips scientific notation convertion.
333         '--platform' defaults to 'osx' and '--browser' defaults to 'safari'.
334
335         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
336         (BenchmarkResults.format):
337         (BenchmarkResults._format_tests):
338         (BenchmarkResults._format_values):
339         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
340         (BenchmarkRunner.__init__):
341         (BenchmarkRunner._run_benchmark):
342         (BenchmarkRunner._dump):
343         (BenchmarkRunner.show_results):
344         (BenchmarkRunner._show_results): Deleted.
345         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
346         (parse_args):
347         (start):
348
349 2015-10-08  Daniel Bates  <dabates@apple.com>
350
351         Add iOS 9 device builder to WebKit Bot Watcher's Dashboard
352         https://bugs.webkit.org/show_bug.cgi?id=149945
353
354         Reviewed by Dan Bernstein.
355
356         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9.png: Added.
357         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9@2x.png: Added.
358         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
359         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
360         (WebKitBuildbot):
361         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
362         (table.queue-grid tr.platform.ios-9 img.logo):
363
364 2015-10-08  Daniel Bates  <dabates@apple.com>
365
366         Teach build-webkit to install LLVM binaries for iOS when building for device with the public iOS SDK
367         https://bugs.webkit.org/show_bug.cgi?id=149943
368
369         Reviewed by Dan Bernstein.
370
371         Following the addition of the LLVM binaries for iOS in changeset r190759 (bug #149913) we should
372         teach build-webkit to install them when building for iOS device using the public iOS SDK. 
373
374         * Scripts/build-webkit:
375
376 2015-10-08  Daniel Bates  <dabates@apple.com>
377
378         Add LLVM binaries for iOS 9 device
379         https://bugs.webkit.org/show_bug.cgi?id=149913
380
381         Reviewed by Filip Pizlo.
382
383         Implement support for building LLVM for ARM64-based iOS devices.
384
385         * Scripts/build-jsc: Enable the FTL when building for Mac or iOS device.
386         * Scripts/copy-webkitlibraries-to-product-directory: Move logic to clean
387         an existing build earlier in the file such that remove previously built
388         libraries before building/copying new ones (if applicable).
389         (fileContains): Moved function outside of if-block.
390         (isContentOfFileEqualToString): Renamed; formerly named fileContentsEquals().
391         (buildLLVM): Added. Extracted machinery to build LLVM into this function and
392         added logic to build LLVM for ARM64-based iOS devices.
393         (symlinkLLVMLibrariesIfNeeded): Added. Extracted machinery to symlink the built
394         LLVM into the WebKitBuild directory.
395
396 2015-10-08  Alexey Proskuryakov  <ap@apple.com>
397
398         Crash-only queues on bot watcher's dashboard should not have non-crashing tests in popovers
399         https://bugs.webkit.org/show_bug.cgi?id=149848
400
401         Reviewed by Darin Adler.
402
403         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
404
405 2015-10-07  Brent Fulgham  <bfulgham@apple.com>
406
407         [Win] Support 64-bit Build and Testing
408         https://bugs.webkit.org/show_bug.cgi?id=149904
409
410         Reviewed by Daniel Bates.
411
412         Extend our existing scripts to support 64-bit build and test operations on
413         Windows.
414
415         * Scripts/build-dumprendertree: We don't need to build DRT on its own;
416         Windows always builds the whole stack.
417         * Scripts/webkit-build-directory: Add an option to return the location of
418         the executable files produced by a specific configuration. This change is
419         actually useful for Gtk and EFL, too.
420         * Scripts/webkitdirs.pm:
421         (executableProductDir): Added. This function appends the proper binary
422         path to the productDir. This is useful for Windows, Gtk, and EFL ports.
423         (jscProductDir): Use the new 'executableProductDir' method.
424         (setPathForRunningWebKitApp): Ditto.
425         (runSafari): Ditto.
426         (runMiniBrowser): Ditto.
427         * Scripts/webkitpy/port/factory.py:
428         (configuration_options): Add a 64-bit option, used on Windows to specify
429         which binary target should be used for testing.
430         * Scripts/webkitpy/port/win.py:
431         (WinPort._port_flag_for_scripts): Added. Supply the 64-bit flag to child
432         processes when needed.
433         (WinPort._build_path): Add the correct binary target path to _build_path.
434         (WinPort._ntsd_location): Check 32-bit paths when running 32-bit tests,
435         64-bit paths for 64-bit tests.
436         (WinPort.setup_crash_log_saving): Remove '-e %ld' argument, since the
437         NTSD debugger does not understand this argument.
438
439 2015-10-07  Myles C. Maxfield  <mmaxfield@apple.com>
440
441         Test font-variant-* and font-feature-settings with TrueType fonts
442         https://bugs.webkit.org/show_bug.cgi?id=149776
443
444         Reviewed by Simon Fraser.
445
446         This test extends our existing FontWithFeatures project to be able to generate a
447         TrueType font. This font is conceptually similar as the existing OpenType font,
448         except the feature -> character mapping is different.
449
450         The font itself only supports the following characters:
451         ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
452         However, the shape of these letters are either an X or a check mark.
453         The letter "A" always is a check mark.
454         The letter "B" always is an X.
455         Each font feature has an letter associated with it. When the font feature is enabled,
456         that letter is shown as a check mark. For example, when
457         "kLowerCaseType / kLowerCaseSmallCapsSelector" is enabled, "S" is shown as a check
458         mark.
459
460         Here are the mappings of font features to letters:
461         kLigaturesType / kCommonLigaturesOnSelector: C
462         kLigaturesType / kContextualLigaturesOnSelector: D
463         kLigaturesType / kRareLigaturesOnSelector: G
464         kLigaturesType / kHistoricalLigaturesOnSelector: I
465         kContextualAlternatesType / kContextualAlternatesOnSelector: L
466         kVerticalPositionType / kInferiorsSelector: O
467         kVerticalPositionType / kSuperiorsSelector: P
468         kLowerCaseType / kLowerCaseSmallCapsSelector: S
469         kUpperCaseType / kUpperCaseSmallCapsSelector: V
470         kLowerCaseType / kLowerCasePetiteCapsSelector: T
471         kUpperCaseType / kUpperCasePetiteCapsSelector: W
472         kLetterCaseType / 14: Y
473         kStyleOptionsType / kTitlingCapsSelector: a
474         kNumberCaseType / kUpperCaseNumbersSelector: c
475         kNumberCaseType / kLowerCaseNumbersSelector: d
476         kNumberSpacingType / kProportionalNumbersSelector: f
477         kNumberSpacingType / kMonospacedNumbersSelector: g
478         kFractionsType / kDiagonalFractionsSelector: i
479         kFractionsType / kVerticalFractionsSelector: j
480         kVerticalPositionType / kOrdinalsSelector: Q
481         kTypographicExtrasType / kSlashedZeroOnSelector: k
482         kLigaturesType / kHistoricalLigaturesOnSelector: K
483         kCharacterShapeType / kJIS1978CharactersSelector: m
484         kCharacterShapeType / kJIS1983CharactersSelector: n
485         kCharacterShapeType / kJIS1990CharactersSelector: o
486         kCharacterShapeType / kJIS2004CharactersSelector: p
487         kCharacterShapeType / kSimplifiedCharactersSelector: q
488         kCharacterShapeType / kTraditionalCharactersSelector: r
489         kTextSpacingType / kMonospacedTextSelector: t
490         kTextSpacingType / kProportionalTextSelector: u
491         kRubyKanaType / kRubyKanaOnSelector: v
492
493         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj:
494         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
495         (CFFBuilder::moveTo):
496         (CFFBuilder::lineTo):
497         (GLYFBuilder::GLYFBuilder):
498         (GLYFBuilder::takeResult):
499         (GLYFBuilder::moveTo):
500         (GLYFBuilder::lineTo):
501         (GLYFBuilder::closePath):
502         (GLYFBuilder::writePoint):
503         (GLYFBuilder::append16):
504         (generateBoxCharString):
505         (generateCheckCharString):
506         (generateXCharString):
507         (itemForGlyph):
508         (Generator::generate):
509         (Generator::insertSelector):
510         (Generator::insertFeature):
511         (Generator::generateFeatureDescription):
512         (Generator::appendCFFTable):
513         (Generator::appendGLYFTable):
514         (Generator::appendLOCATable):
515         (Generator::appendFEATTable):
516         (Generator::appendMetamorphosisChain):
517         (Generator::appendMORXTable):
518         (Generator::appendHEADTable):
519         (Generator::appendHMTXTable):
520         (Generator::appendNameSubtable):
521         (Generator::append2ByteASCIIString):
522         (Generator::appendNAMETable):
523         (generateFont):
524         (CFFBuilder::curveToCubic): Deleted.
525         (charStringForGlyph): Deleted.
526         * FontWithFeatures/FontWithFeatures/FontCreator.h:
527         * FontWithFeatures/FontWithFeatures/main.cpp:
528         (constructFontWithTrueTypeFeature):
529         (constructFontWithOpenTypeFeature):
530         (drawText):
531         (main):
532         (drawTextWithFeature): Deleted.
533
534 2015-10-07  Commit Queue  <commit-queue@webkit.org>
535
536         Unreviewed, rolling out r190572, r190593, r190594, and
537         r190639.
538         https://bugs.webkit.org/show_bug.cgi?id=149897
539
540         Breaks Mavericks build (Requested by litherum on #webkit).
541
542         Reverted changesets:
543
544         "Allow WKRetainPtrs to be used as keys in hashing data
545         structures"
546         https://bugs.webkit.org/show_bug.cgi?id=149762
547         http://trac.webkit.org/changeset/190572
548
549         "REGRESSION(189668?): http/tests/notifications/events.html
550         flakily asserts or times out"
551         https://bugs.webkit.org/show_bug.cgi?id=149218
552         http://trac.webkit.org/changeset/190593
553
554         "Prospective Mavericks build fix."
555         http://trac.webkit.org/changeset/190594
556
557         "Post-review cleanup after r190572."
558         http://trac.webkit.org/changeset/190639
559
560 2015-10-06  Michael Catanzaro  <mcatanzaro@igalia.com>
561
562         [GTK] Add autocleanups
563         https://bugs.webkit.org/show_bug.cgi?id=149588
564
565         Reviewed by Darin Adler.
566
567         * TestWebKitAPI/Tests/WebKit2Gtk/AutocleanupsTest.cpp: Added.
568         (AutocleanupsTest::create):
569         (AutocleanupsTest::testWebProcessAutocleanups):
570         (registerTests):
571         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
572         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutocleanups.cpp: Added.
573         (testUIProcessAutocleanups):
574         (testWebProcessAutocleanups):
575         (beforeAll):
576         (afterAll):
577
578 2015-10-06  Brian Burg  <bburg@apple.com>
579
580         Unreviewed, try to fix the iOS 8 build after r190368.
581
582         On older versions, IOHIDEventCreateForceEvent is not available.
583
584         * WebKitTestRunner/ios/HIDEventGenerator.mm:
585         (-[HIDEventGenerator _createIOHIDEventType:]): Add another guard for force events.
586
587 2015-10-06  Keith Miller  <keith_miller@apple.com>
588
589         Add gmalloc option to run-javascriptcore-tests.
590         https://bugs.webkit.org/show_bug.cgi?id=149858
591
592         Reviewed by Geoffrey Garen.
593
594         run-javascriptcore-tests takes a new option --gmalloc with an optional string argument, the path to the gmalloc dylib.
595         If no argument is provided then /usr/lib/libgmalloc.dylib is used by default.
596
597         * Scripts/run-javascriptcore-tests:
598
599 2015-10-06  Myles C. Maxfield  <mmaxfield@apple.com>
600
601         Post-review cleanup after r190572.
602
603         Unreviewed.
604
605         * TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp:
606
607 2015-10-06  Brent Fulgham  <bfulgham@apple.com>
608
609         [Win] Unreviewed build correction.
610
611         * TestWebKitAPI/PlatformWin.cmake: We don't need to link to all of these libraries. Most
612         are soft-linked at runtime.
613
614 2015-10-06  Keith Miller  <keith_miller@apple.com>
615
616         Fix run-javascriptcore-tests/run-jsc-stress-tests to work with rootless, add a --quick option and deprecate the Mozilla driver.
617         https://bugs.webkit.org/show_bug.cgi?id=149815
618
619         Reviewed by Filip Pizlo.
620
621         Rootless has an issue where it will strip any environment variables that start with DYLD starting a perl/ruby/python script.
622         Now, run-jsc-stress-tests takes an new argument, --env-vars, that will set the specified environment variables before
623         running tests. Additionally, I added a quick option that only runs default and the NoCJITValidate versions of each test.
624         Finally, I removed the calls to the mozilla jsDriver.pl since the run-jsc-stress-tests runner runs the same test suite
625         so should just use one test runner.
626
627         * Scripts/run-javascriptcore-tests:
628         (runJSCStressTests):
629         (runMozillaTests): Deleted.
630         (defaultJsDriverArgsForMozillaTests): Deleted.
631         * Scripts/run-jsc-stress-tests:
632
633 2015-10-06  Mark Salisbury  <mark.salisbury@hp.com>
634
635         [GTK] Make update-webkitgtk-libs work behind firewall
636
637         update-webkitgtk-libs can work behind a firewall with changes to
638         a few packages.  Where outbound git and active FTP connections
639         fail, using http protocol succeeds.  Most packages are
640         already accessed using http.
641
642         https://bugs.webkit.org/show_bug.cgi?id=148941
643
644         Reviewed by Martin Robinson.
645
646         Tools
647         * gtk/jhbuild.modules:
648             Replace git URLs with http.  Remove no longer used ftp repositories.
649             Update argument for libxml2's autogen.sh script (--without-python
650             is ignored; --with-python=no is correct).
651         * jhbuild/jhbuild-wrapper:
652             Instead of connecting to git://git.gnome.org/jhbuild, connect to
653             http://git.gnome.org/browse/jhbuild.
654
655 2015-10-06  Daniel Bates  <dbates@webkit.org>
656
657         Enable XSLT when building WebKit for iOS using the public iOS SDK
658         https://bugs.webkit.org/show_bug.cgi?id=149827
659
660         Reviewed by Alexey Proskuryakov.
661
662         Teach script configure-xcode-for-ios-development to copy the OS X XSLT headers to the iPhoneOS
663         and iPhoneSimulator SDKs so as to support building WebKit for iOS with XSLT. A person must
664         run this script before building WebKit for iOS or the build will fail because one or more XSLT
665         headers cannot be found.
666
667         * Scripts/configure-xcode-for-ios-development:
668         (copyMissingXSLTHeadersToSDKIfNeeded): Added.
669
670 2015-10-05  Myles C. Maxfield  <mmaxfield@apple.com>
671
672         REGRESSION(189668?): http/tests/notifications/events.html flakily asserts or times out
673         https://bugs.webkit.org/show_bug.cgi?id=149218
674
675         Reviewed by Alexey Proskuryakov.
676
677         Because of r189668, WebKitTestRunner now tears down and recreates its WKNotificationManagerRef
678         when the TestOptions change. Previously, WebNotificationProvider only could handle a single
679         WKNotificationManagerRef. Because the ower of the WKNotificationManagerRef is reference counted,
680         and AppKit internally retains some objects which end up retaining the WKNotificationManagerRef,
681         the old WKNotificationManager may not be destroyed before the new one is created. Therefore,
682         WebNotificationProvider must be updated to appropriately handle multiple
683         WKNotificationManagerRefs in flight at the same time.
684
685         * WebKitTestRunner/WebNotificationProvider.cpp:
686         (WTR::WebNotificationProvider::~WebNotificationProvider):
687         (WTR::WebNotificationProvider::showWebNotification):
688         (WTR::WebNotificationProvider::closeWebNotification):
689         (WTR::WebNotificationProvider::addNotificationManager):
690         (WTR::WebNotificationProvider::removeNotificationManager):
691         (WTR::WebNotificationProvider::simulateWebNotificationClick):
692         (WTR::WebNotificationProvider::reset):
693         * WebKitTestRunner/WebNotificationProvider.h:
694
695 2015-10-05  Daniel Bates  <dabates@apple.com>
696
697         Disable Bitcode when building for iOS device
698         https://bugs.webkit.org/show_bug.cgi?id=149818
699
700         Reviewed by Alexey Proskuryakov.
701
702         Xcode 7 generates bitcode for iOS device apps by default. Do not generate bitcode
703         when building for iOS device.
704
705         * Scripts/webkitdirs.pm:
706         (XcodeOptions):
707
708 2015-10-05  Daniel Bates  <dabates@apple.com>
709
710         [iOS] Make it possible to build WebKit using iphoneos SDK without a developer certificate installed
711         https://bugs.webkit.org/show_bug.cgi?id=140828
712         <rdar://problem/19520599>
713
714         Reviewed by Alexey Proskuryakov.
715
716         Support building WebKit for iOS device without an iOS Developer certificate installed. Otherwise,
717         we will pass CODE_SIGN_IDENTITY="iPhone Developer: " to Xcode to find a iOS Developer certificate
718         to use. To use a specific installed iOS Developer certificate, explicitly pass CODE_SIGN_IDENTITY
719         to build-webkit.
720
721         * Scripts/webkitdirs.pm:
722         (XcodeOptions): Cleaned up code. When building for iOS device, pass to Xcode CODE_SIGN_IDENTITY="iPhone Developer: "
723         to code sign using the installed iOS development certificate (if it exists - we assume there is only one such certificate).
724         Otherwise, pass CODE_SIGN_IDENTITY="" and CODE_SIGNING_REQUIRED=NO to Xcode to disable code signing.
725         (hasIOSDevelopmentCertificate): Added.
726
727 2015-10-05  Daniel Bates  <dabates@apple.com>
728
729         DumpRenderTree built with public iOS SDK crashes under -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
730         https://bugs.webkit.org/show_bug.cgi?id=149766
731
732         Reviewed by Alexey Proskuryakov.
733
734         Create network storage testing session on iOS.
735
736         Currently we do not create a network storage testing session on iOS. A network storage testing session always
737         has an associated cookie store. When WebKit is built without USE(CFNETWORK), NetworkStorageSession::defaultStorageSession().cookieStorage()
738         returns nullptr because the caller is expected to interact with NSHTTPCookieStorage instead of querying
739         NetworkStorageSession for the cookie store. When WebKit is built with USE(CFNETWORK) accessing
740         NetworkStorageSession::defaultStorageSession().cookieStorage() returns a valid cookie store (creating one if
741         it does not exist). Instead we should make use of NetworkStorageSession::switchToNewTestingSession() to
742         create a network storage testing session when building DumpRenderTree for iOS so as to ensure a consistent
743         testing environment regardless of whether we built with USE(CFNETWORK). This will also make the behavior of
744         DumpRenderTree on iOS more consistent with the behavior of DumpRenderTree on Mac.
745
746         As a side effect of this change DumpRenderTree no longer crashes in -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
747         when WebKit is built without USE(CFNETWORK) because NetworkStorageSession::defaultStorageSession().cookieStorage()
748         returns a non-null pointer to a cookie store.
749
750         * DumpRenderTree/mac/DumpRenderTree.mm:
751         (prepareConsistentTestingEnvironment):
752
753 2015-10-05  Simon Fraser  <simon.fraser@apple.com>
754
755         Fix the iOS 8 build again, where -[UIApplication _enqueueHIDEvent:] is not
756         available.
757
758         * WebKitTestRunner/ios/HIDEventGenerator.mm:
759         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
760
761 2015-10-05  Myles C. Maxfield  <mmaxfield@apple.com>
762
763         Allow WKRetainPtrs to be used as keys in hashing data structures
764         https://bugs.webkit.org/show_bug.cgi?id=149762
765
766         Reviewed by Anders Carlsson.
767
768         * TestWebKitAPI/PlatformGTK.cmake:
769         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
770         * TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp: Added.
771         (TestWebKitAPI::TEST):
772
773 2015-10-05  Simon Fraser  <simon.fraser@apple.com>
774
775         Fix the iOS 8 build, where -[UIApplication _enqueueHIDEvent:] is not
776         available, and tidy up the #ifdefs in the UIKitSPI header.
777
778         * WebKitTestRunner/ios/HIDEventGenerator.mm:
779         (-[HIDEventGenerator _sendHIDEvent:]):
780         * WebKitTestRunner/ios/UIKitSPI.h:
781
782 2015-10-04  Zan Dobersek  <zdobersek@igalia.com>
783
784         [GTK] Remove duplicate entries in WebKitTestRunner_SOURCES
785         https://bugs.webkit.org/show_bug.cgi?id=149792
786
787         Reviewed by Martin Robinson.
788
789         * WebKitTestRunner/PlatformGTK.cmake: Don't list build targets
790         for WebKitTestRunner multiple times.
791
792 2015-10-04  Daniel Bates  <dabates@apple.com>
793
794         Fix the Apple Internal iOS build after <http://trac.webkit.org/changeset/190515>
795         (https://bugs.webkit.org/show_bug.cgi?id=149753)
796
797         For now, support calling build-layouttestrelay without --ios-simulator so long
798         as we are building on a Mac.
799
800         * Scripts/build-layouttestrelay:
801
802 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
803
804         Support Trac 1.0.x XML timeline link format
805         https://bugs.webkit.org/show_bug.cgi?id=149786
806
807         Reviewed by Lucas Forschler.
808
809         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
810         (Trac.prototype._convertCommitInfoElementToObject):
811
812 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
813
814         Fix some errors on bot watcher's dashboard
815         https://bugs.webkit.org/show_bug.cgi?id=149789
816
817         Reviewed by Lucas Forschler.
818
819         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
820         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): We may not get to layout
821         tests step, in which case layoutTestResults.tooManyFailures would raise an exception.
822
823 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
824
825         Bot watcher's dashboard builders should turn yellow when svn fails
826         https://bugs.webkit.org/show_bug.cgi?id=149791
827
828         Reviewed by Lucas Forschler.
829
830         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
831         (BuildbotBuilderQueueView.prototype.appendBuilderQueueStatus):
832         (BuildbotBuilderQueueView.prototype.update):
833
834 2015-10-02  Daniel Bates  <dabates@apple.com>
835
836         Add iOS 9 Simulator builders and testers to WebKit Bot Watcher's Dashboard
837         https://bugs.webkit.org/show_bug.cgi?id=149769
838
839         Reviewed by Alexey Proskuryakov.
840
841         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator.png: Added.
842         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator@2x.png: Added.
843         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
844         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
845         (WebKitBuildbot):
846         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
847         (table.queue-grid tr.platform.ios-simulator-9 img.logo):
848
849 2015-10-02  Ryosuke Niwa  <rniwa@webkit.org>
850
851         REGRESSION(r190370): Speedometer spits out an extra console message
852         https://bugs.webkit.org/show_bug.cgi?id=149720
853
854         Unreviewed. Temporarily ignore the console error message.
855
856         * Scripts/webkitpy/performance_tests/perftest.py:
857         (PerfTest._filter_output):
858
859 2015-10-02  Brent Fulgham  <bfulgham@apple.com>
860
861         Provide "--no-ninja" option to avoid using Ninja
862         https://bugs.webkit.org/show_bug.cgi?id=149757
863
864         Reviewed by Alex Christensen.
865
866         Add a new command line argument understood by webkitdirs.pm so
867         that we can conditionally avoid using Ninja. This is an
868         'opt-out' argument, so no existing Ninja users should be affected.
869         
870         * Scripts/webkitdirs.pm:
871         (canUseNinja): Check for option and block ninja if present.
872
873 2015-10-02  Aakash Jain  <aakash_jain@apple.com>
874
875         Flakiness dashboard should support OS X El Capitan
876         https://bugs.webkit.org/show_bug.cgi?id=149648
877
878         Reviewed by Alexey Proskuryakov.
879
880         * TestResultServer/static-dashboards/flakiness_dashboard.js: Fix the broken dashboard for ElCapitan.
881
882 2015-10-02  Daniel Bates  <dabates@apple.com>
883
884         Fix run-webkit-tests --ios-simulator after <http://trac.webkit.org/changeset/190515>
885         (https://bugs.webkit.org/show_bug.cgi?id=149753)
886
887         For now, pass --ios-simulator.
888
889         * Scripts/webkitpy/port/ios.py:
890         (IOSSimulatorPort._build_relay):
891
892 2015-10-02  Simon Fraser  <simon.fraser@apple.com>
893
894         Remove a "nullable" that breaks the iOS 8 build.
895
896         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
897         (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]):
898
899 2015-10-02  Daniel Bates  <dabates@apple.com>
900
901         LayoutTestRelay is not built and archived when building for iOS Simulator
902         https://bugs.webkit.org/show_bug.cgi?id=149753
903
904         Reviewed by Alexey Proskuryakov and Andy Estes.
905
906         Towards running layout tests on the iOS Simulator test bots, we need to teach scripts build-webkit
907         and built-product-archive to build the Mac tool LayoutTestRelay and include this tool in the built
908         product archive when building for iOS Simulator, respectively.
909
910         * BuildSlaveSupport/built-product-archive:
911         (main): Pass the full platform name (options.platform) to archiveBuiltProduct() so that it can
912         differentiate between iOS device and iOS Simulator platforms.
913         (webkitBuildDirectoryForConfigurationAndPlatform): Extracted logic to run the script webkit-build-directory
914         from determineWebKitBuildDirectories() into this function so that it can be used by both
915         determineWebKitBuildDirectories() and archiveBuiltProduct().
916         (determineWebKitBuildDirectories): Moved logic to execute the script webkit-build-directory from here to
917         webkitBuildDirectoryForConfigurationAndPlatform().
918         (createZip): Added parameter embedParentDirectoryNameOnDarwin (defaults to False) to specify whether
919         we should call ditto(1) with --keepParent to embed the parent directory name in the zip archive. This
920         argument is only applicable when building on Darwin. We only pass embedParentDirectoryNameOnDarwin=True
921         when making an archive for a Mac or iOS device build. For iOS Simulator builds we archive two directories
922         and we do not want to keep the parent directory because it is a placeholder directory used as a workaround
923         for the limitation that ditto(1) can only accept a single directory to archive on its command line.
924         (archiveBuiltProduct): Modified to take the full platform name as an argument. Added logic for iOS.
925         For iOS device builds we use the same logic as for a Mac build and archive the configuration-specific
926         build directory. For iOS Simulator builds we archive the configuration-specific iOS build directory,
927         LayoutTestRelay and LayoutTestRelay.dSYM (if it exists) from the configuration-specific Mac build.
928         * Scripts/build-layouttestrelay:
929             - Remove unnecessary include of Perl module POSIX.
930             - Only build LayoutTestRelay when building for iOS Simulator (i.e. --ios-simulator is passed).
931         * Scripts/build-webkit:
932             - Invoke script build-layouttestrelay when building for iOS Simulator.
933
934 2015-10-02  Brent Fulgham  <bfulgham@apple.com>
935
936         [Win] Unreviewed test fix.
937
938         You cannot run 'run-webkit-tests' from the command line because it does not know
939         to append the binary subdirectory (bin32/bin64). We don't see this on our builders
940         because they explicitly set use the 'root' argument to provide the full path to
941         the test binaries.
942
943         * Scripts/webkitpy/port/win.py:
944         (WinPort._build_path): Added.
945
946 2015-10-02  Alex Christensen  <achristensen@webkit.org>
947
948         Reloading without content blockers doesn't apply to resource loads after the main frame finishes
949         https://bugs.webkit.org/show_bug.cgi?id=149430
950         rdar://problem/22742222
951
952         Reviewed by Geoffrey Garen.
953
954         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
955         (WTR::TestController::cocoaResetStateToConsistentValues):
956         * WebKitTestRunner/mac/TestControllerMac.mm:
957         (WTR::TestController::platformConfigureViewForTest):
958         Test what happens when you disable content blockers from the SPI.
959
960 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
961
962         [Win] Unreviewed build fix for run-api-tests
963
964         * Scripts/run-api-tests:
965         (testToolPaths): Windows run needs to specify the binary path.
966
967 2015-10-01  Daniel Bates  <dabates@apple.com>
968
969         Another attempt to fix the Windows builders after <https://trac.webkit.org/changeset/190387>
970         (https://bugs.webkit.org/show_bug.cgi?id=149695)
971
972         Following r190424 we can now rely on webkit-build-directory to return the path to
973         the correct configuration-specific build directory on Windows.
974
975         * BuildSlaveSupport/built-product-archive:
976         (archiveBuiltProduct):
977
978 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
979
980         [Win] Unreviewed build fix.
981
982         * Scripts/webkitdirs.pm:
983         (setupAppleWinEnv): Use 64-bit build tools if available
984
985 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
986
987         [Win] Fix TestWebKitAPI build under CMake.
988
989         Reviewed by Alex Christensen.
990
991         * TestWebKitAPI/PlatformWin.cmake: Add missing link command
992         for Psapi.lib.
993
994 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
995
996         [Win] Fix behavior of webkit-build-directory script
997         https://bugs.webkit.org/show_bug.cgi?id=149718
998
999         Reviewed by Alex Christensen.
1000
1001         * Scripts/webkitdirs.pm:
1002         (determineConfigurationProductDir): Do not include the binary
1003         sub-directory in the configuration product directory output.
1004         (jscProductDir): Append correct binary path for Windows build.
1005         (setPathForRunningWebKitApp): Include properly binary subdirectories.
1006         (runSafari): Update for revised productDir behavior.
1007         (runMiniBrowser): Ditto.
1008
1009 2015-10-01  Alexey Proskuryakov  <ap@apple.com>
1010
1011         Stop building LayoutTestRelay for now. It's a Mac project, but build-webkit tries to
1012         use iOS SDK, like with all the others.
1013
1014         * Scripts/build-webkit:
1015
1016 2015-10-01  Daniel Bates  <dabates@apple.com>
1017
1018         Attempt to fix the iOS 9 Simulator testers
1019
1020         Add dependency DumpRenderTree.app to target All of project DumpRenderTree so that we
1021         build DumpRenderTree.app, if applicable. Also, teach build-webkit to build project
1022         LayoutTestRelay when building for iOS Simulator.
1023
1024         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1025         * Scripts/build-webkit:
1026
1027 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1028
1029         [GTK] Websites with invalid auth header keep loading forever
1030         https://bugs.webkit.org/show_bug.cgi?id=149710
1031
1032         Reviewed by Martin Robinson.
1033
1034         Add test case to check that we can authenticate sites with an
1035         empty realm.
1036
1037         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
1038         (testWebViewAuthenticationEmptyRealm):
1039         (serverCallback):
1040         (beforeAll):
1041
1042 2015-10-01  Alexey Proskuryakov  <ap@apple.com>
1043
1044         [Mac] Make run-api-tests work with System Integrity Protection
1045         https://bugs.webkit.org/show_bug.cgi?id=149711
1046         rdar://problem/22928202
1047
1048         Reviewed by Dan Bernstein.
1049
1050         * Scripts/run-api-tests:
1051         (runTest):
1052         (archCommandLineArgumentsForRestrictedEnvironmentVariables):
1053
1054 2015-10-01  Daniel Bates  <dabates@apple.com>
1055
1056         Attempt to fix the Windows build after <https://trac.webkit.org/changeset/190387>
1057         (https://bugs.webkit.org/show_bug.cgi?id=149695)
1058
1059         For some reason built-product-archive hardcodes the assumption that we build for 32-bit Windows.
1060         For now, use the path to the top-level WebKit build directory instead of using the configuration-
1061         specific build directory.
1062
1063         * BuildSlaveSupport/built-product-archive:
1064         (archiveBuiltProduct):
1065
1066 2015-10-01  Csaba Osztrogonác  <ossy@webkit.org>
1067
1068         [EFL] Fix the openwebrtc and gst-plugins-openwebrtc build with clang
1069         https://bugs.webkit.org/show_bug.cgi?id=145837
1070
1071         Reviewed by Philippe Normand.
1072
1073         * efl/jhbuild.modules:
1074         * efl/patches/openwebrtc-clang-warning-fix.patch: Added.
1075         * efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Added.
1076
1077 2015-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1078
1079         Unreviewed. Fix the iOS build after r190407.
1080
1081         * WebKitTestRunner/ios/IOKitSPI.h:
1082
1083 2015-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1084
1085         Implement keyboard event sending for iOS in WebKitTestRunner
1086         https://bugs.webkit.org/show_bug.cgi?id=149676
1087
1088         Reviewed by Simon Fraser.
1089
1090         Adds support for generating and sending key events in WebKitTestRunner. This is accomplished in a similar
1091         way as touch events, using IOHIDEvent machinery. Also adds callbacks to the UIScriptController JS API that
1092         allows us to run code when the keyboard is shown or hidden.
1093
1094         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Adds the typeCharacter JS interface.
1095         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1096         (WTR::UIScriptController::setDidShowKeyboardCallback):
1097         (WTR::UIScriptController::didShowKeyboardCallback):
1098         (WTR::UIScriptController::setDidHideKeyboardCallback):
1099         (WTR::UIScriptController::didHideKeyboardCallback):
1100         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
1101         (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
1102         (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
1103         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1104         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1105         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1106         (-[TestRunnerWKWebView initWithFrame:configuration:]): Registers the TestRunnerWKWebView to listen to
1107                 the notifications that the keyboard has been raised or lowered.
1108         (-[TestRunnerWKWebView _keyboardDidShow:]):
1109         (-[TestRunnerWKWebView _keyboardDidHide:]):
1110         * WebKitTestRunner/ios/HIDEventGenerator.h:
1111         * WebKitTestRunner/ios/HIDEventGenerator.m:
1112         (-[HIDEventGenerator _sendIOHIDKeyboardEvent:usage:isKeyDown:]): Helper to send a HID keyboard event.
1113         (shouldWrapWithShiftKeyEventForCharacter): Helper used to generate key events.
1114         (hidUsageCodeForCharacter): Ditto.
1115         (-[HIDEventGenerator keyDown:completionBlock:]): Synthesizes and sends HIDKeyboardEvents, triggering
1116                 a keyDown event in WebKit.
1117         * WebKitTestRunner/ios/IOKitSPI.h:
1118         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1119
1120 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1121
1122         Unreviewed, rolling out r190399.
1123
1124         Tests are still failing even after r190362
1125
1126         Reverted changeset:
1127
1128         "Unreviewed. Unskip GTK+ user media unit tests after r190362."
1129         http://trac.webkit.org/changeset/190399
1130
1131 2015-10-01  Csaba Osztrogonác  <ossy@webkit.org>
1132
1133         [jhbuild] switch to new upstream usrsctp library
1134         https://bugs.webkit.org/show_bug.cgi?id=149494
1135
1136         Reviewed by Philippe Normand.
1137
1138         * efl/jhbuild.modules:
1139         * gtk/jhbuild.modules:
1140
1141 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1142
1143         Unreviewed. Unskip GTK+ user media unit tests after r190362.
1144
1145         They should pass now.
1146
1147         * Scripts/run-gtk-tests:
1148         (TestRunner):
1149
1150 2015-09-30  Daniel Bates  <dabates@apple.com>
1151
1152         Another attempt to fix the build after <https://trac.webkit.org/changeset/190387>
1153         (https://bugs.webkit.org/show_bug.cgi?id=149695)
1154
1155         * BuildSlaveSupport/built-product-archive:
1156         (determineWebKitBuildDirectories): Substitute _configurationBuildDirectory for _buildDirectory.
1157         (extractBuiltProduct): Substitute _topLevelBuildDirectory for _buildDirectory.
1158
1159 2015-09-30  Daniel Bates  <dabates@apple.com>
1160
1161         Attempt to fix the build after <https://trac.webkit.org/changeset/190387>
1162         (https://bugs.webkit.org/show_bug.cgi?id=149695)
1163
1164         Actually, we need to pass --configuration to script webkit-build-directory to have
1165         it return the path to the configuration-specific build directory.
1166
1167         * BuildSlaveSupport/built-product-archive:
1168         (determineWebKitBuildDirectories):
1169
1170 2015-09-30  Daniel Bates  <dabates@apple.com>
1171
1172         built-product-archive archives incorrect build directory for iOS port
1173         https://bugs.webkit.org/show_bug.cgi?id=149695
1174
1175         Reviewed by Darin Adler.
1176
1177         Fixes an issue where the script built-product-archive archives a non-existent
1178         build directory for the iOS port. Without loss of generality, the script assumes
1179         the path to the Release configuration build for iOS is in directory WebKitBuild/Release.
1180         But the built products for this configuration are in directory WebKitBuild/Release-iphonesimulator.
1181
1182         Currently the script built-product-archive calls `webkit-build-directory --top-level ...`
1183         to determine the top-level build directory and computes the configuration-specific
1184         build directory to be the concatenation of the the top-level build directory and
1185         the configuration (e.g. Release). This is incorrect. Instead we should call
1186         webkit-build-directory omitting the flag --top-level to compute the path to the
1187         configuration-specific build directory.
1188
1189         * BuildSlaveSupport/built-product-archive: Fix up the style such that we use single quoted literals.
1190         (main): Renamed global variable _buildDirectory to _topLevelBuildDirectory to better describe
1191         its purpose and added global variable _configurationBuildDirectory to store the path
1192         to the configuration-specific build directory. Ensure that we have a non-empty string
1193         for both the top-level and configuration-specific build directories.
1194         (determineWebKitBuildDirectories): Formerly named determineWebKitBuildDirectory.
1195         Compute the configuration-specific build directory and store it in the global variable
1196         _configurationBuildDirectory.
1197         (archiveBuiltProduct): Modified to use _configurationBuildDirectory.
1198         (extractBuiltProduct): Modified to use _configurationBuildDirectory and _topLevelBuildDirectory
1199         as needed.
1200         (determineWebKitBuildDirectory): Deleted.
1201
1202 2015-09-30  Hunseop Jeong  <hs85.jeong@samsung.com>
1203
1204         [EFL] css3/device-adapt/* tests failed after r190335.
1205         https://bugs.webkit.org/show_bug.cgi?id=149655
1206
1207         Reviewed by Simon Fraser.
1208
1209         device-adapt/* tests need the fixedLayout option but useFixedLayout option is
1210         overwritten by updatePlatformSpecificViewOptionsForTest after r190335.
1211
1212         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1213         (WTR::shouldUseFixedLayout):
1214
1215 2015-09-30  Dewei Zhu  <dewei_zhu@apple.com>
1216
1217         Extend JetStream timeout for slow devices.
1218
1219         Reviewed by Chris Dumez.
1220
1221         Extend JetStream timeout to 20 minutes.
1222
1223         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
1224
1225 2015-09-30  Daniel Bates  <dabates@apple.com>
1226
1227         Rename iOS builders/testers to include version
1228         https://bugs.webkit.org/show_bug.cgi?id=149685
1229
1230         Reviewed by Simon Fraser.
1231
1232         Substitute "Apple iOS 9" for "Apple iOS" in the names of iOS builders/testers so as
1233         make it clear to a reader the version of iOS these builders/testers are using.
1234
1235         * BuildSlaveSupport/build.webkit.org-config/config.json:
1236         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1237
1238 2015-09-30  Daniel Bates  <dabates@apple.com>
1239
1240         Add iOS criterion for triggering a build
1241         https://bugs.webkit.org/show_bug.cgi?id=149679
1242
1243         Rubber-stamped by Alexey Proskuryakov.
1244
1245         First pass at defining criterion for triggering an iOS build.
1246
1247         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1248         (_should_file_trigger_build):
1249         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1250         (ShouldBuildTest):
1251         (ShouldBuildTest.test_should_build):
1252
1253 2015-09-29  Simon Fraser  <simon.fraser@apple.com>
1254
1255         [iOS] Allow tests to generate user gestures for UI testing
1256         https://bugs.webkit.org/show_bug.cgi?id=149653
1257
1258         Reviewed by Tim Horton.
1259
1260         Expose functionality in UIScriptController to allow for testing single- and double-tap,
1261         and to listen for completion of scrolling and zooming in the WKWebView.
1262         
1263         Tap generation is done using synthetic IOHIDEvents, via a new HIDEventGenerator class
1264         which hides the complexity of creating these events. Event dispatch is asynchronous.
1265         We detect when the last event has been handled by dispatching a vendor-specific event,
1266         which is detected via -_handleHIDEvent: in our UIApplication subclass.
1267         
1268         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Link with IOKit.
1269         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Two new properties
1270         for 'will begin zooming' and 'did end zooming' callbacks, and functions to dispatch
1271         single and double taps.
1272         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
1273         (UIScriptContext::registerCallback): Used to store the callbacks for zooming.
1274         Unlike the "task" callbacks, these are persistent, but we store them in the same hash map.
1275         (UIScriptContext::unregisterCallback):
1276         (UIScriptContext::callbackWithID):
1277         (UIScriptContext::fireCallback):
1278         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
1279         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1280         (WTR::UIScriptController::setWillBeginZoomingCallback): Cross-platform code.
1281         (WTR::UIScriptController::willBeginZoomingCallback): Ditto.
1282         (WTR::UIScriptController::setDidEndZoomingCallback):
1283         (WTR::UIScriptController::didEndZoomingCallback):
1284         (WTR::UIScriptController::singleTapAtPoint): Non-iOS stub.
1285         (WTR::UIScriptController::doubleTapAtPoint): Ditto.
1286         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
1287         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
1288         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1289         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1290         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Properties for the zooming callbacks.
1291         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1292         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]): Dispatch the zooming callback.
1293         (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]): Ditto.
1294         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]): Ditto.
1295         (-[TestRunnerWKWebView onDidEndZooming:]): Deleted.
1296         * WebKitTestRunner/ios/HIDEventGenerator.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
1297         * WebKitTestRunner/ios/HIDEventGenerator.m: Added.
1298         (simpleDragCurve):
1299         (calculateNextLocation):
1300         (delayBetweenMove):
1301         (+[HIDEventGenerator sharedHIDEventGenerator]):
1302         (+[HIDEventGenerator nextEventCallbackID]):
1303         (-[HIDEventGenerator init]):
1304         (-[HIDEventGenerator _createIOHIDEventType:]):
1305         (-[HIDEventGenerator _sendHIDEvent:]):
1306         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
1307         (-[HIDEventGenerator _updateTouchPoints:count:]):
1308         (-[HIDEventGenerator touchDownAtPoints:touchCount:]):
1309         (-[HIDEventGenerator touchDown:touchCount:]):
1310         (-[HIDEventGenerator touchDown:]):
1311         (-[HIDEventGenerator liftUpAtPoints:touchCount:]):
1312         (-[HIDEventGenerator liftUp:touchCount:]):
1313         (-[HIDEventGenerator liftUp:]):
1314         (-[HIDEventGenerator moveToPoints:touchCount:duration:]):
1315         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
1316         (-[HIDEventGenerator tap:completionBlock:]):
1317         (-[HIDEventGenerator doubleTap:completionBlock:]):
1318         (-[HIDEventGenerator twoFingerTap:completionBlock:]):
1319         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
1320         (-[HIDEventGenerator pinchCloseWithStartPoint:endPoint:duration:completionBlock:]):
1321         (-[HIDEventGenerator pinchOpenWithStartPoint:endPoint:duration:completionBlock:]):
1322         (-[HIDEventGenerator markerEventReceived:]):
1323         * WebKitTestRunner/ios/IOKitSPI.h: Added.
1324         * WebKitTestRunner/ios/UIKitSPI.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
1325         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1326         (WTR::globalToContentCoordinates):
1327         (WTR::UIScriptController::singleTapAtPoint):
1328         (WTR::UIScriptController::doubleTapAtPoint):
1329         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
1330         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
1331         * WebKitTestRunner/ios/mainIOS.mm:
1332         (-[WebKitTestRunnerApp _handleHIDEvent:]):
1333
1334 2015-09-30  Dana Burkart  <dburkart@apple.com>
1335
1336         git-add-reviewer should trim trailing spaces/newlines
1337         https://bugs.webkit.org/show_bug.cgi?id=149513
1338
1339         Reviewed by Darin Adler.
1340
1341         * Scripts/git-add-reviewer:
1342         (nonInteractive):
1343
1344 2015-09-30  Eric Carlson  <eric.carlson@apple.com>
1345
1346         REGRESSION(r190262): User media unit test failures after r190262
1347         https://bugs.webkit.org/show_bug.cgi?id=149580
1348
1349         Reviewed by Darin Adler.
1350
1351         * WebKitTestRunner/TestController.cpp:
1352         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Fix parameter
1353           order to WKUserMediaPermissionRequestAllow.
1354
1355 2015-09-30  Daniel Bates  <dabates@apple.com>
1356
1357         Add iOS builders and testers
1358         https://bugs.webkit.org/show_bug.cgi?id=149549
1359
1360         Reviewed by Alexey Proskuryakov.
1361
1362         Adds definitions for 64-bit iOS Simulator release builders and testers and a iOS device
1363         builder that builds universal release binaries for armv7, armv7s and arm64 architectures.
1364
1365         * BuildSlaveSupport/build.webkit.org-config/config.json: Add definitions for builders and testers.
1366         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Update unit tests.
1367
1368 2015-09-30  Timothy Hatcher  <timothy@apple.com>
1369
1370         Give WebKitLauncher the get-task-allow entitlement to allow it to work on El Capitan
1371         https://bugs.webkit.org/show_bug.cgi?id=149674
1372
1373         Reviewed by Lucas Forschler.
1374
1375         * WebKitLauncher/WebKitLauncher.entitlements: Added.
1376         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
1377
1378 2015-09-30  Jason Marcell  <jmarcell@apple.com>
1379
1380         BuildbotQueueView.prototype._appendPendingRevisionCount should skip repositories that don't
1381         have an associated trac instance.
1382         https://bugs.webkit.org/show_bug.cgi?id=149673
1383
1384         Reviewed by Alexey Proskuryakov.
1385
1386         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1387         (BuildbotQueueView.prototype._appendPendingRevisionCount): Skip repositories that don't
1388         have an associated trac instance.
1389
1390 2015-09-30  Daniel Bates  <dabates@apple.com>
1391
1392         Prioritize testing latest build request on iOS test bots
1393         https://bugs.webkit.org/show_bug.cgi?id=149669
1394
1395         Reviewed by Darin Adler.
1396
1397         We should prioritize testing of the latest build request on the iOS test bots
1398         as we do for Mac and Windows test bots.
1399
1400         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1401         (loadBuilderConfig):
1402
1403 2015-09-30  Daniel Bates  <dabates@apple.com>
1404
1405         Add buildbot category for iOS builders and testers
1406         https://bugs.webkit.org/show_bug.cgi?id=149667
1407
1408         Reviewed by Darin Adler.
1409
1410         Group iOS builders and testers under category iOS and add dashboard and console hyperlinks
1411         for iOS to the build.webkit.org home page.
1412
1413         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1414         (loadBuilderConfig):
1415         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1416
1417 2015-09-30  Daniel Bates  <dabates@apple.com>
1418
1419         Actually fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
1420         (https://bugs.webkit.org/show_bug.cgi?id=149539)
1421
1422         I inadvertently didn't remove the ONLY_ACTIVE_ARCH=NO flag when building on a Mac
1423         in <http://trac.webkit.org/changeset/190351>.
1424
1425         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1426         (CompileWebKit.start):
1427
1428 2015-09-30  Daniel Bates  <dabates@apple.com>
1429
1430         Attempt to fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
1431         (https://bugs.webkit.org/show_bug.cgi?id=149539)
1432
1433         {32, 64}-bit Mac builders should not try to build project {Plugin.64, Plugin.32},
1434         respectively; only pass ONLY_ACTIVE_ARCH=NO when building for iOS.
1435
1436         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1437         (CompileWebKit.start):
1438
1439 2015-09-30  Lucas Forschler  <lforschler@apple.com>
1440
1441         bot210 was configured for a queue instead of bot126.
1442         
1443         Unreviewed config.json fix.
1444         
1445         * BuildSlaveSupport/build.webkit.org-config/config.json:
1446
1447 2015-09-30  Lucas Forschler  <lforschler@apple.com>
1448
1449         Bring El Capitan buildbot infrastructure online.
1450         https://bugs.webkit.org/show_bug.cgi?id=149605
1451         
1452         Reviewed by Darin Adler.
1453
1454         * BuildSlaveSupport/build.webkit.org-config/config.json:
1455
1456 2015-09-30  Tomas Popela  <tpopela@redhat.com>
1457
1458         [GTK] Deprecation warnings in DOMNodeTest
1459         https://bugs.webkit.org/show_bug.cgi?id=149663
1460
1461         After the webkit_dom_document_get_elements_by_tag_name deprecation we
1462         need to update the tests to use webkit_dom_document_query_selector_all
1463         to avoid compilation warnings.
1464
1465         Also add a new test for webkit_dom_document_get_elements_by_tag_name_as_html_collection
1466         (the suggested replacement for the deprecated function).
1467
1468         Reviewed by Carlos Garcia Campos.
1469
1470         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
1471         (WebKitDOMNodeTest::testTagNamesNodeList):
1472         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
1473         (registerTests):
1474         (WebKitDOMNodeTest::testTagNames): Deleted.
1475         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
1476         (prepareDOMForTagNamesTests):
1477         (testWebKitDOMNodeTagNamesNodeList):
1478         (testWebKitDOMNodeTagNamesHTMLCollection):
1479         (beforeAll):
1480         (testWebKitDOMNodeTagNames): Deleted.
1481
1482 2015-09-29  Simon Fraser  <simon.fraser@apple.com>
1483
1484         WebKitTestRunner fails to apply "useFlexibleViewport" when it's specified in a file comment
1485         https://bugs.webkit.org/show_bug.cgi?id=149650
1486
1487         Reviewed by Tim Horton.
1488         
1489         TestInvocation::invoke() consulted shouldMakeViewportFlexible(), but that only
1490         looks at the file path, and not the custom options that come from file comments.
1491         
1492         Fix by computing TestOptions before making the TestInvocation, and setting them
1493         as const TestInvocation data. This meant changing various call sites to take
1494         the std::string pathOrURL, rather than the TestInvocation itself.
1495         
1496         Also initialize TestInvocation with a WKURLRef, rather than a std::string.
1497
1498         * WebKitTestRunner/CMakeLists.txt:
1499         * WebKitTestRunner/TestController.cpp:
1500         (WTR::TestController::ensureViewSupportsOptionsForTest):
1501         (WTR::testPath):
1502         (WTR::createTestURL):
1503         (WTR::updateTestOptionsFromTestHeader):
1504         (WTR::TestController::testOptionsForTest):
1505         (WTR::TestController::updateWebViewSizeForTest):
1506         (WTR::TestController::updateWindowScaleForTest):
1507         (WTR::TestController::runTest):
1508         * WebKitTestRunner/TestController.h:
1509         * WebKitTestRunner/TestInvocation.cpp:
1510         (WTR::TestInvocation::TestInvocation):
1511         (WTR::TestInvocation::invoke):
1512         (WTR::createWKURL): Deleted.
1513         (WTR::TestInvocation::shouldMakeViewportFlexible): Deleted.
1514         (WTR::TestInvocation::shouldUseFixedLayout): Deleted.
1515         * WebKitTestRunner/TestInvocation.h:
1516         (WTR::TestInvocation::options):
1517         * WebKitTestRunner/TestOptions.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
1518         (WTR::pathContains):
1519         (WTR::shouldMakeViewportFlexible):
1520         (WTR::shouldUseFixedLayout):
1521         (WTR::isSVGTestPath):
1522         (WTR::isHiDPITestPath):
1523         (WTR::TestOptions::TestOptions):
1524         * WebKitTestRunner/TestOptions.h:
1525         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1526         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1527         (WTR::pathContains):
1528         (WTR::shouldUseFixedLayout):
1529         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
1530         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1531         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
1532         * WebKitTestRunner/ios/TestControllerIOS.mm:
1533         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
1534         * WebKitTestRunner/mac/TestControllerMac.mm:
1535         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
1536
1537 2015-09-29  Aakash Jain  <aakash_jain@apple.com>
1538
1539         Flakiness dashboard should support OS X El Capitan
1540         https://bugs.webkit.org/show_bug.cgi?id=149648
1541
1542         Reviewed by Alexey Proskuryakov.
1543
1544         * QueueStatusServer/app.yaml: We do not need to maintain SVN revision here because of 
1545         difference between new appscale and old Google App Engine implementation.
1546         * TestResultServer/app.yaml: Same.
1547         * TestResultServer/static-dashboards/builders.jsonp: Added OSX El Capitan support.
1548
1549 2015-09-29  Daniel Bates  <dabates@apple.com>
1550
1551         configure-xcode-for-ios-development does not work with Xcode 7
1552         https://bugs.webkit.org/show_bug.cgi?id=149640
1553
1554         Reviewed by Alexey Proskuryakov.
1555
1556         When Xcode 7 is installed, running configure-xcode-for-ios-development dies with an error
1557         because it cannot find the Xcode specification files for iOS simulator and device. These
1558         files have moved to a new location in Xcode 7 distribution. Moreover we must add the
1559         relevant definitions to the Xcode 7 specification files directly as opposed to creating
1560         new specification files with the added definitions (as we did in older versions of Xcode)
1561         in order for Xcode 7 to honor these definitions.
1562
1563         * Scripts/configure-xcode-for-ios-development: Sorted forward declarations.
1564         (updateXcodeSpecificationFilesForSDKIfNeeded): Added.
1565         (updateXcode7SpecificationFile): Added.
1566         (createLegacyXcodeSpecificationFilesForSDKIfNeeded): Formerly named createXcodeSpecificationFilesForSDKIfNeeded.
1567         (writeXcodeSpecification): Moved congratulations line to caller so as to write out the
1568         appropriate success message.
1569         (mergeXcodeSpecificationWithSpecificationAndId): Formerly named createXcodeSpecificationFromSpecificationAndId.
1570         (createXcodeSpecificationFilesForSDKIfNeeded): Deleted.
1571         (createXcodeSpecificationFromSpecificationAndId): Deleted.
1572
1573 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
1574
1575         [Win] Allow 'prepare-ChangeLog' to be used without Cygwin
1576         https://bugs.webkit.org/show_bug.cgi?id=149639
1577
1578         Reviewed by Alex Christensen.
1579
1580         * Scripts/VCSUtils.pm:
1581         (exitStatus): Use 'isWindows()' method.
1582         (isSVNVersion16OrNewer): 'eval' is not needed here, and just causes
1583         an error. This method could probably just go away.
1584         (normalizePath): Leave Windows (or Unix) paths as platform paths, rather than
1585         always changing to Unix style. 
1586         (unixPath): Added. Needed so Windows can always show a Unix path in the
1587         ChangeLog file.
1588         (changeLogName): Work around the fact that 'getpwuid' is not available on
1589         a pure Windows build of Perl.
1590         * Scripts/prepare-ChangeLog:
1591         (generateFunctionLists): Normalize path received from 'svn' in case it's a Unix
1592         path on Windows.
1593         (svnUpdateCommand): Added helper function. Needed because Windows Perl does not
1594         support using arrays for 'open' arguments.
1595         (resolveChangeLogsPath): Ditto.
1596         (resolveConflictedChangeLogs): Use new helper functions.
1597         (generateNewChangeLogs): Force Windows to use Unix paths in ChangeLog output.
1598         (diffCommand): Use double-quotes for paths, since Windows doesn't understand single
1599         quotes. Unix systems are happy either way.
1600         (statusCommand): Ditto.
1601         * Scripts/webkitdirs.pm:
1602         (launcherName): Drive-by fix. WinLauncher was renamed to MiniBrowser some time ago.
1603
1604 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
1605
1606         [Win] Unreviewed 64-bit build fix after switch to CMake.
1607
1608         * Scripts/webkitdirs.pm:
1609         (determineIsWin64FromArchitecture): Added.
1610
1611 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1612
1613         printing does not use minimum page zoom factor
1614         https://bugs.webkit.org/show_bug.cgi?id=108507
1615
1616         Reviewed by Darin Adler.
1617
1618         WebKitTestRunner always takes the snapshots from the UI process
1619         (expect for IOS), so in the case of printing, the layout in the
1620         web view is not the expected one. When printing, we need to take
1621         the snapshot in the web process and ensure it's rendered with a
1622         PrintContext.
1623
1624         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1625         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
1626         kWKSnapshotOptionsPrinting option to
1627         WKBundlePageCreateSnapshotWithOptions() when printing.
1628
1629 2015-09-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1630
1631         [WTR] Pixel tests generate the snapshots twice in Web and UI processes
1632         https://bugs.webkit.org/show_bug.cgi?id=149595
1633
1634         Reviewed by Tim Horton.
1635
1636         All ports except IOS implement
1637         PlatformWebView::windowSnapshotImage() to generate the snapshot
1638         for the pixel tests in the UI process. But we are still generating
1639         a snapshot for pixel tests in the Web process too, that is passed
1640         to the UI process but ignored.
1641         Whether a pixel result is needed or not, is only known by the web
1642         process depending on whether the test called dumpAsText with
1643         dumpPixels == true or not. Since the pixels are now dump in the UI
1644         process, we need to pass that information to the UI process when
1645         the test is done. For that we set a PixelResultIsPending bool
1646         parameter to the Done message, and we only add the PixelResult
1647         when UI process doesn't need to generate the pixels dump.
1648
1649         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1650         (WTR::InjectedBundle::didReceiveMessageToPage): Set
1651         m_pixelResultIsPending to false on reset.
1652         (WTR::InjectedBundle::done): Add PixelResultIsPending parameter to the
1653         Done message, and set the PixelResult if m_pixelResultIsPending is false.
1654         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1655         (WTR::InjectedBundle::setPixelResult): Set m_pixelResultIsPending to false.
1656         (WTR::InjectedBundle::setNeedsPixelResult): Set m_pixelResultIsPending.
1657         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1658         (WTR::InjectedBundlePage::dump): Only create a snapshot for IOS
1659         port.
1660         * WebKitTestRunner/TestInvocation.cpp:
1661         (WTR::TestInvocation::dumpResults): Use either the pixel result
1662         from the web process or generate a pixel result from the web view
1663         if need it.
1664         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1665         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
1666         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
1667         is created by the caller now, but the CG implementation needs to
1668         know if it's a Web or UI process snapshot.
1669         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1670         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
1671         cairo surface for the given image.
1672         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1673         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
1674         CGContext for the given image.
1675
1676 2015-09-28  Dean Johnson  <dean_johnson@apple.com>
1677
1678         Fix JS errors on dashboard metrics page
1679         https://bugs.webkit.org/show_bug.cgi?id=149608
1680
1681         Reviewed by Alexey Proskuryakov.
1682
1683         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Updated to use Settings.
1684         (initPlatformsByFamily): 
1685         (updateHiddenPlatforms):
1686         (parsePlatformFamily): Deleted.
1687         (updateToggleButtons): Deleted.
1688         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
1689         (updateHiddenPlatforms): Added to remove errors.
1690         (initPlatformsByFamily): Added to remove errors.
1691         (unhiddenQueues): Updated to use Settings.
1692         (documentReady): Added logic to add toggle buttons to the settings menu.
1693         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
1694         (Settings.prototype.parsePlatformFamily): Moved duplicate logic from Main.js and
1695         MetricsMain.js to Settings.
1696         (Settings.prototype.updateToggleButtons): Moved duplicate logic from Main.js and
1697         MetricsMain.js to Settings.
1698         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
1699         (QueueView.prototype._updateHiddenState): Updated to use Settings.
1700
1701 2015-09-28  Aakash Jain  <aakash_jain@apple.com>
1702
1703         Appscale query fails because of missing index
1704         https://bugs.webkit.org/show_bug.cgi?id=149609
1705
1706         Reviewed by Darin Adler.
1707
1708         * QueueStatusServer/index.yaml: Added the required index.
1709
1710 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
1711
1712         [Win] Fix the 64-bit build after switch to cmake.
1713
1714         Reviewed by Alex Christensen.
1715
1716         * Scripts/webkitdirs.pm:
1717         (generateBuildSystemFromCMakeProject): Use correct arguments for cmake to
1718         run a 64-bit build.
1719
1720 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
1721
1722         [Win] Allow Windows to run test-webkitpy without Cygwin
1723         https://bugs.webkit.org/show_bug.cgi?id=149602
1724
1725         Reviewed by Alex Christensen.
1726
1727         These changes mostly shift from hard-coded paths using UNIX-style
1728         separators to Python's "os.path.join" syntax that uses the correct
1729         path separator for each platform.
1730         
1731         * Scripts/webkitpy/common/system/path.py:
1732         (cygpath): Don't pass paths through Cygpath on native Windows.
1733         * Scripts/webkitpy/port/win.py:
1734         (WinPort._path_to_apache): Use os.path.join.
1735         (WinPort._ntsd_location): Support 64-bit environment (ProgramW6432 doesn't exist
1736         in 64-bit environments).
1737         * Scripts/webkitpy/style/checker.py: Use os.path.join.
1738         * Scripts/webkitpy/style/checker_unittest.py:
1739         (GlobalVariablesTest.test_path_rules_specifier.assertNoCheck): Use os.path.join.
1740         (GlobalVariablesTest.test_path_rules_specifier): Ditto.
1741         (GlobalVariablesTest): Ditto.
1742         (GlobalVariablesTest.test_max_reports_per_category): Ditto.
1743         (CheckerDispatcherSkipTest.test_should_skip_with_warning): Ditto.
1744         (CheckerDispatcherDispatchTest.test_js_paths): Ditto.
1745         (CheckerDispatcherDispatchTest.test_json_paths): Ditto.
1746         (CheckerDispatcherDispatchTest.test_python_paths): Ditto.
1747         (CheckerDispatcherDispatchTest.test_text_paths): Ditto.
1748         (CheckerDispatcherDispatchTest.test_xml_paths): Ditto.
1749         (StyleProcessor_CodeCoverageTest._create_carriage_checker_class): Ditto.
1750         (StyleProcessor_CodeCoverageTest): Ditto.
1751         (StyleProcessor_CodeCoverageTest.test_should_process__skip_without_warning): Ditto.
1752         (StyleProcessor_CodeCoverageTest.test_should_process__skip_with_warning): Ditto.
1753         (StyleProcessor_CodeCoverageTest.test_should_process__true_result): Ditto.
1754         * Scripts/webkitpy/w3c/test_parser_unittest.py: Uses os.path.join rather than
1755         manual string concatenation of paths.
1756
1757 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
1758
1759         Add bugzilla addresses of committers to contributors.json
1760         https://bugs.webkit.org/show_bug.cgi?id=149520
1761
1762         Reviewed by Darin Adler.
1763
1764         * Scripts/webkitpy/common/config/contributors.json:
1765
1766 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
1767
1768         validate-committer-lists -b shouldn't need edituser privileges
1769         https://bugs.webkit.org/show_bug.cgi?id=149519
1770
1771         Reviewed by Darin Adler.
1772
1773         * Scripts/validate-committer-lists:
1774         (CommitterListBugzillaChecker._has_invalid_bugzilla_email):
1775         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1776         (BugzillaQueries.is_invalid_bugzilla_email):
1777         (BugzillaQueries): Deleted.
1778         (BugzillaQueries.fetch_logins_matching_substring): Deleted.
1779
1780 2015-09-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1781
1782         Unreviewed. Gardening: skip media stream tests failing after r190262.
1783
1784         * Scripts/run-gtk-tests:
1785         (TestRunner):
1786
1787 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
1788
1789         [Mac] USE_INTERNAL_SDK is used undefined in tools projects
1790         https://bugs.webkit.org/show_bug.cgi?id=149571
1791
1792         Reviewed by Dan Bernstein.
1793
1794         Use the same pattern as in Source directory configurations (so, also get rid of AspenFamily.xcconfig). 
1795
1796         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1797         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1798         * LayoutTestRelay/Configurations/Base.xcconfig:
1799         * MiniBrowser/Configurations/Base.xcconfig:
1800         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1801         * TestWebKitAPI/Configurations/Base.xcconfig:
1802         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1803         * WebEditingTester/Configurations/Base.xcconfig:
1804         * WebEditingTester/Configurations/DebugRelease.xcconfig:
1805         * WebKitTestRunner/Configurations/Base.xcconfig:
1806         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1807         * WebKitTestRunner/iOS.xcconfig: Removed.
1808
1809 2015-09-25  Eric Carlson  <eric.carlson@apple.com>
1810
1811         Clean up user media request internal API
1812         https://bugs.webkit.org/show_bug.cgi?id=149527
1813
1814         Reviewed by Tim Horton.
1815
1816         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
1817         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): Update for API changes.
1818
1819         * WebKitTestRunner/TestController.cpp:
1820         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Ditto.
1821
1822 2015-09-25  Simon Fraser  <simon.fraser@apple.com>
1823
1824         [iOS WK2] Add viewport tests and fix runUIScript() timing issues
1825         https://bugs.webkit.org/show_bug.cgi?id=149577
1826
1827         Reviewed by Tim Horton.
1828         
1829         When calling testRunner.runUIScript() from a page load event, the script could run
1830         in the UI process before the current remote layer tree transaction had been handled
1831         there. This meant that runUIScript() could query state which was about to change.
1832         
1833         Fix by delaying the execution of the UI script until a layer tree transaction has
1834         been handled by the UI process, leveraging the existing DrawingAreaProxy::dispatchAfterEnsuringDrawing().
1835
1836         * WebKitTestRunner/TestInvocation.cpp:
1837         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1838         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
1839         * WebKitTestRunner/TestInvocation.h:
1840
1841 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
1842
1843         [Mac] Media tests start to time out after a few days of bot uptime
1844         https://bugs.webkit.org/show_bug.cgi?id=149468
1845
1846         Reviewed by Darin Adler.
1847
1848         Delete cache directory in addition to the temporary one. Don't delete /private/tmp/MediaCache,
1849         as it's not longer used by tests. Set TMPDIR and DIRHELPER_USER_DIR_SUFFIX to make
1850         all temporary and cache files go to a custom location.
1851
1852         * Scripts/webkitpy/port/base.py:
1853         * Scripts/webkitpy/port/driver.py:
1854         * Scripts/webkitpy/port/mac.py:
1855         * Scripts/webkitpy/port/win.py:
1856         (WinPort._driver_tempdir_for_environment): Deleted unused function.
1857
1858 2015-09-25  Dan Bernstein  <mitz@apple.com>
1859
1860         Removed MiniBrowser.entitlements.
1861
1862         Rubber-stamped by Anders Carlsson.
1863
1864         The entitlements weren’t used anyway.
1865
1866         * MiniBrowser/MiniBrowser.entitlements: Removed.
1867         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1868
1869 2015-09-24  Daniel Bates  <dabates@apple.com>
1870
1871         Add WebKitSystemInterface for iOS 9.0
1872         https://bugs.webkit.org/show_bug.cgi?id=149550
1873
1874         Rubber-stamped by Alexey Proskuryakov.
1875
1876         * Scripts/copy-webkitlibraries-to-product-directory:
1877
1878 2015-09-24  Daniel Bates  <dabates@apple.com>
1879
1880         Support building for arbitrary architectures
1881         https://bugs.webkit.org/show_bug.cgi?id=149539
1882
1883         Reviewed by Alexey Proskuryakov.
1884
1885         Teach buildbot to pass the architectures associated with the builder to build-webkit
1886         when building on OS X and iOS. As a side effect of this change we now support building
1887         universal binaries when multiples architectures are specified.
1888
1889         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1890         (CompileWebKit.start):
1891
1892 2015-09-24  Daniel Bates  <dabates@apple.com>
1893
1894         Fix the build after <http://trac.webkit.org/changeset/190212>
1895         (http://trac.webkit.org/changeset/190212)
1896
1897         I inadvertently did not remove the fullPlatform argument from one of the callers of archiveBuiltProduct().
1898
1899         * BuildSlaveSupport/built-product-archive:
1900         (main):
1901
1902 2015-09-24  Daniel Bates  <dabates@apple.com>
1903
1904         Support running unit tests on iOS Simulator test bot
1905         https://bugs.webkit.org/show_bug.cgi?id=149536
1906
1907         Reviewed by Alexey Proskuryakov.
1908
1909         Implements support for running unit tests on a iOS test bot. At the time of writing,
1910         the script run-api-tests supports running unit tests on Mac, Windows and iOS Simulator.
1911
1912         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1913         (RunUnitTests.start): Append appropriate command line flag when invoking script run-api-tests.
1914         (TestFactory.__init__): Add step RunUnitTests when the test bot is for the iOS Simulator platform.
1915
1916 2015-09-24  Daniel Bates  <dabates@apple.com>
1917
1918         Add support infrastructure for OpenSource iOS builders and testers
1919         https://bugs.webkit.org/show_bug.cgi?id=149534
1920
1921         Reviewed by Darin Adler.
1922
1923         Towards setting up OpenSource iOS build bots, teach buildbot and its support
1924         scripts about iOS.
1925
1926         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1927         (appendCustomBuildFlags): Require the caller to pass parameter fullPlatform and append
1928         --ios-simulator or --device for a builder/tester whose full platform name begins with
1929         "ios-simulator" or "ios", respectively.
1930         (RunJavaScriptCoreTests.start): Pass the full platform name to appendCustomBuildFlags().
1931         * BuildSlaveSupport/built-product-archive:
1932         (main): Pass the full platform name to determineWebKitBuildDirectory().
1933         (determineWebKitBuildDirectory): Call script webkit-build-directory with the appropriate
1934         command line flag when building for iOS.
1935         (archiveBuiltProduct): Use the same logic for iOS as we do for Mac. Also, remove unused
1936         parameter fullPlatform. This parameter was originally added in r125066 to support the
1937         Chromium Android port, which has since been removed from the OpenSource WebKit Project.
1938         (extractBuiltProduct): Use the same logic for iOS as we do for Mac.
1939         * BuildSlaveSupport/clean-build:
1940         (main): Call script webkit-build-directory with the appropriate command line flag when
1941         building for iOS.
1942         * BuildSlaveSupport/delete-stale-build-files:
1943         (main): Use the same logic for iOS as we do for Mac.
1944         (webkitBuildDirectory): Call script webkit-build-directory with the appropriate command line
1945         flag when building for iOS.
1946         * BuildSlaveSupport/test-result-archive:
1947         (archiveTestResults): Use the same logic for iOS as we do for Mac.
1948
1949 2015-09-24  Daniel Bates  <dabates@apple.com>
1950
1951         Remove Chromium-specific changes to script built-product-archive
1952         https://bugs.webkit.org/show_bug.cgi?id=149530
1953
1954         Rubber-stamped by Csaba Osztrogonác.
1955
1956         Reverts changes made in r113074 and r113067 to support Chromium testers. The
1957         Chromium code has long since been removed from the OpenSource WebKit Project.
1958
1959         * BuildSlaveSupport/built-product-archive:
1960         (createZipManually):
1961         (createZip):
1962         (archiveBuiltProduct):
1963
1964 2015-09-24  Dan Bernstein  <mitz@apple.com>
1965
1966         Build fix.
1967
1968         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1969
1970 2015-09-24  Mark Lam  <mark.lam@apple.com>
1971
1972         Unreviewed. Make Lucas Forschler a WebKit reviewer.
1973
1974         * Scripts/webkitpy/common/config/contributors.json:
1975
1976 2015-09-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1977
1978         Unreviewed. Fix GObject DOM API breaks after r190120.
1979
1980         Bring back code removed in r169931 to handle documentation of
1981         deleted classes.
1982
1983         * gtk/webkitdom.py:
1984         (WebKitDOMDocGenerator):
1985         (WebKitDOMDocGenerator.write_deleted_classes):
1986         (WebKitDOMDocGenerator.generate):
1987         (write_deleted_classes):
1988         (WebKitDOMDocGeneratorSections._deleted_class):
1989         (WebKitDOMDocGeneratorSections._deleted_class.in):
1990         (WebKitDOMDocGeneratorSections.write_deleted_classes):
1991         (WebKitDOMDocGeneratorSections.write_deleted_classes.with):
1992
1993 2015-09-23  Myles C. Maxfield  <mmaxfield@apple.com>
1994
1995         [Cocoa] [Font Features] Implement font-variant-*
1996         https://bugs.webkit.org/show_bug.cgi?id=148413
1997
1998         Reviewed by Darin Adler.
1999
2000         Update test font to use "lnum" feature.
2001
2002         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
2003         (Generator::appendGSUBTable):
2004
2005 2015-09-22  Andy Estes  <aestes@apple.com>
2006
2007         ContentFiltering.AllowDownloadAfterAddData is very flaky
2008         https://bugs.webkit.org/show_bug.cgi?id=148885
2009         <rdar://problem/22729563>
2010
2011         Reviewed by Alexey Proskuryakov.
2012
2013         The AllowDownload* tests were relying on -_downloadDidStart: being called before -webView:didFinishNavigation:,
2014         but there is no guarantee of this. For tests that should allow a download, spin the runloop until
2015         -_downloadDidStart: is called. The test will now timeout on failure, but will no longer produce false failures.
2016
2017         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
2018         (downloadTest):
2019
2020 2015-09-22  Alexey Proskuryakov  <ap@apple.com>
2021
2022         Mavericks: Media tests start to time out after a few days of bot uptime
2023         https://bugs.webkit.org/show_bug.cgi?id=149468
2024
2025         Reviewed by Chris Dumez.
2026
2027         * Scripts/webkitpy/port/base.py:
2028         * Scripts/webkitpy/port/driver.py:
2029         * Scripts/webkitpy/port/mac.py:
2030
2031 2015-09-22  Nan Wang  <n_wang@apple.com>
2032
2033         Unreviewed, add myself to the committers list.
2034
2035         * Scripts/webkitpy/common/config/contributors.json:
2036
2037 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
2038
2039         Remove 'nullable' to fix older iOS builds.
2040
2041         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2042         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
2043
2044 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
2045
2046         [Win] Show tiled drawing debug overlay on Windows
2047         https://bugs.webkit.org/show_bug.cgi?id=149426
2048
2049         Reviewed by Dean Jackson.
2050
2051         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Add new menu option.
2052         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Ditto.
2053         * MiniBrowser/win/Common.cpp:
2054         (::ToggleMenuItem): Recognize new menu item and toggle the 'showTiledScrollingIndicator'
2055         flag if needed.
2056         * MiniBrowser/win/MiniBrowser.h: Update to use new IWebPreferencesPrivate3 class.
2057
2058 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
2059
2060         [Win] Use command-line argument to launch in regular or High DPI mode.
2061         https://bugs.webkit.org/show_bug.cgi?id=149417
2062
2063         Reviewed by Dean Jackson.
2064
2065         * MiniBrowser/win/Common.cpp:
2066         (parseCommandLine): Ignore the '--highDPI' argument. It's used at the
2067         very start of execution, before the MiniBrowser.dll is loaded.
2068         * win/DLLLauncher/DLLLauncherMain.cpp:
2069         (shouldUseHighDPI): Check for '--highDPI', and use this mode if
2070         present. On WinCairo, always use High DPI.
2071
2072 2015-09-21  Ryosuke Niwa  <rniwa@webkit.org>
2073
2074         32-bit Mac build fix attempt after r190065.
2075
2076         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2077
2078 2015-09-21  Alexey Proskuryakov  <ap@apple.com>
2079
2080         [OS X] Update for Xcode 7.0 on Yosemite
2081         https://bugs.webkit.org/show_bug.cgi?id=149389
2082
2083         Reviewed by Dan Bernstein.
2084
2085         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
2086         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
2087         Removed unneeded declarations - conforming to a protocol is sufficient.
2088
2089         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2090         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
2091         Changed the definitions to be compiled whenever the SDK requires it (so we will have
2092         dead code compiled in when building for 10.10 with 10.11 SDK, somewhat unfortunately).
2093
2094 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
2095
2096         Add the ability for tests to run script in the UI process in WebKitTestRunner
2097         https://bugs.webkit.org/show_bug.cgi?id=149356
2098
2099         Reviewed by Tim Horton.
2100
2101         This change adds testRunner.runUIScript(script, callback), which allows a test
2102         to execute script in a JSContext which runs in the UI process. That context
2103         has bindings exposed through the UIScriptController interface; currently one test
2104         function, and some iOS-specific functions are included. UIScriptController can be
2105         async with a callback, and runUIScript() itself is asynchronous. When the UI 
2106         script is complete, it calls uiController.uiScriptComplete(result), where 'result'
2107         is a string passed back to the web process, and given to the runUIScript()
2108         callback function.
2109         
2110         Thanks to Gyuyoung Kim for help with the Gtk/Efl build.
2111
2112         * WebKitTestRunner/DerivedSources.make: Build UIScriptController.idl.
2113         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Add runUIScript().
2114         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2115         (WTR::InjectedBundle::didReceiveMessageToPage): When the UI-side script is
2116         complete, call back into TestRunner.
2117         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2118         (WTR::nextUIScriptCallbackID):
2119         (WTR::TestRunner::runUIScript): Post a message to the injected bundle to run the UI script.
2120         (WTR::TestRunner::runUIScriptCallback): When the UI script is done, execute its callback function.
2121         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2122         * WebKitTestRunner/PlatformWebView.h:
2123         * WebKitTestRunner/TestController.cpp:
2124         (WTR::updateTestOptionsFromTestHeader):
2125         (WTR::TestController::testOptionsForTest): Support "useFlexibleViewport" as a test argument.
2126         (WTR::shouldUseFixedLayout): Deleted. Moved to a TestInvocation function.
2127         * WebKitTestRunner/TestInvocation.cpp:
2128         (WTR::TestInvocation::shouldUseFixedLayout):
2129         (WTR::TestInvocation::shouldUseThreadedScrolling):
2130         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2131         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2132         (WTR::TestInvocation::runUISideScript): Run the UI-side script!
2133         (WTR::TestInvocation::uiScriptDidComplete): Send a message back to the injected bundle.
2134         * WebKitTestRunner/TestInvocation.h:
2135         * WebKitTestRunner/TestOptions.h:
2136         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2137         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2138         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
2139         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Added.
2140         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
2141         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
2142         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
2143         (-[TestRunnerWKWebView onDidEndZooming:]): Allow a test to hook into the end of zooming.
2144         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2145         (WTR::PlatformWebView::PlatformWebView): Make a TestRunnerWKWebView on iOS.
2146         * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Added.
2147         (WTR::UIScriptController::doAsyncTask):
2148         (WTR::UIScriptController::zoomToScale):
2149         (WTR::UIScriptController::zoomScale):
2150         (WTR::UIScriptController::minimumZoomScale):
2151         (WTR::UIScriptController::maximumZoomScale):
2152         (WTR::UIScriptController::contentVisibleRect):
2153         * WebKitTestRunner/mac/EventSenderProxy.mm:
2154         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2155         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): Deleted.
2156         * WebKitTestRunner/mac/TestControllerMac.mm:
2157         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2158         (WTR::shouldUseThreadedScrolling): Deleted. Moved to TestInvocation.
2159         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
2160         * WebKitTestRunner/uiscriptcontext/UIScriptContext.cpp: Added. Owns the JS context in the UI process.
2161         (UIScriptContext::UIScriptContext):
2162         (UIScriptContext::~UIScriptContext):
2163         (UIScriptContext::runUIScript): Entrypoint to running the UI script. If the script didn't do anything
2164         asynchronous, call the callback.
2165         (UIScriptContext::nextTaskCallbackID):
2166         (UIScriptContext::prepareForAsyncTask): Do setup for one async task (i.e. a UIScriptController function
2167         that has a callback). Has to store the callbackID of the script, so code called from the completion
2168         callback knows which UI script invoked it.
2169         (UIScriptContext::asyncTaskComplete): Called when one task is finished.
2170         (UIScriptContext::uiScriptComplete):
2171         (UIScriptContext::objectFromRect): Make a JS object from a rect.
2172         * WebKitTestRunner/uiscriptcontext/UIScriptContext.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
2173         (WTR::UIScriptContext::hasOutstandingAsyncTasks):
2174         * WebKitTestRunner/uiscriptcontext/UIScriptController.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
2175         (WTR::UIScriptController::UIScriptController):
2176         (WTR::UIScriptController::makeWindowObject):
2177         (WTR::UIScriptController::wrapperClass):
2178         (WTR::UIScriptController::doAsyncTask):
2179         (WTR::UIScriptController::zoomToScale):
2180         (WTR::UIScriptController::zoomScale):
2181         (WTR::UIScriptController::minimumZoomScale):
2182         (WTR::UIScriptController::maximumZoomScale):
2183         (WTR::UIScriptController::contentVisibleRect):
2184         (WTR::UIScriptController::uiScriptComplete):
2185         * WebKitTestRunner/uiscriptcontext/UIScriptController.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
2186         (WTR::UIScriptController::create):
2187         * WebKitTestRunner/uiscriptcontext/bindings/UIScriptController.idl: Copied from Tools/WebKitTestRunner/TestOptions.h.
2188
2189 2015-09-21  Tim Horton  <timothy_horton@apple.com>
2190
2191         Turn on threaded scrolling by default in the tests
2192         https://bugs.webkit.org/show_bug.cgi?id=149377
2193
2194         Reviewed by Simon Fraser.
2195
2196         * WebKitTestRunner/mac/TestControllerMac.mm:
2197         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2198         (WTR::shouldUseThreadedScrolling): Deleted.
2199         Turn on threaded scrolling by default.
2200
2201 2015-09-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2202
2203         [GTK] run-gtk-tests doesn't provide feedback about crashing google tests
2204         https://bugs.webkit.org/show_bug.cgi?id=149252
2205
2206         Reviewed by Darin Adler.
2207
2208         In case of glib tests the test runner notifies about tests
2209         crashing, but for google tests we don't get any feedback, which
2210         means that in case of a test crashing we get a list of **PASS**
2211         messages and at the summary we are notified that the test suite
2212         has failed, but it's impossible to know which test cases have failed.
2213
2214         * Scripts/run-gtk-tests:
2215         (TestRunner._run_google_test): Add a **CRASH** message if test
2216         case crashed.
2217
2218 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
2219
2220         WebKitTestRunner can leak user content script results between tests
2221         https://bugs.webkit.org/show_bug.cgi?id=149391
2222
2223         Reviewed by Sam Weinig.
2224
2225         Move WKBundlePageRemoveAllUserContent call so that it's executed before loading
2226         about:blank, and thus about:blank doesn't have unintended side effects.
2227
2228         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2229         (WTR::InjectedBundle::beginTesting):
2230         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2231         (WTR::InjectedBundlePage::resetAfterTest):
2232
2233 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
2234
2235         [Mac, iOS] AccessibilityController doesn't uninstall global notification handler
2236         https://bugs.webkit.org/show_bug.cgi?id=149384
2237
2238         Reviewed by Chris Fleizach.
2239
2240         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
2241         (AccessibilityController::addNotificationListener): Fixed a leak, and cleaned up the code.
2242         (AccessibilityController::platformResetToConsistentState): Actually remove the handler,
2243         regardless of whether someone else holds a reference (we also call -stopListening in
2244         -dealloc).
2245
2246         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2247         (AccessibilityController::platformResetToConsistentState):
2248         (AccessibilityController::addNotificationListener):
2249         Ditto.
2250
2251 2015-09-20  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2252
2253         Remove XHR_TIMEOUT compilation guard
2254         https://bugs.webkit.org/show_bug.cgi?id=149260
2255
2256         Reviewed by Benjamin Poulain.
2257
2258         * Scripts/webkitperl/FeatureList.pm:
2259
2260 2015-09-19  Dan Bernstein  <mitz@apple.com>
2261
2262         Attempted build fix.
2263
2264         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
2265
2266 2015-09-18  Commit Queue  <commit-queue@webkit.org>
2267
2268         Unreviewed, rolling out r189908.
2269         https://bugs.webkit.org/show_bug.cgi?id=149368
2270
2271         Broke run-webkit-tests --pixel (Requested by ap on #webkit).
2272
2273         Reverted changeset:
2274
2275         "printing does not use minimum page zoom factor"
2276         https://bugs.webkit.org/show_bug.cgi?id=108507
2277         http://trac.webkit.org/changeset/189908
2278
2279 2015-09-18  Andy Estes  <aestes@apple.com>
2280
2281         [iOS] did{Start,Finish}LoadForQuickLookDocumentInMainFrame is never called on WKNavigationDelegate
2282         https://bugs.webkit.org/show_bug.cgi?id=149360
2283
2284         Reviewed by Tim Horton.
2285
2286         Added an API test.
2287
2288         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2289         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm: Added.
2290         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2291         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2292         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]):
2293         (TEST):
2294         * TestWebKitAPI/ios/pages.pages: Added.
2295
2296 2015-09-18  Nan Wang  <n_wang@apple.com>
2297
2298         AX: Implement ARIA 1.1 @aria-current on iOS
2299         https://bugs.webkit.org/show_bug.cgi?id=149297
2300
2301         Reviewed by Chris Fleizach.
2302
2303         Added support to test aria-current on iOS.
2304
2305         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2306         (AccessibilityUIElement::stringAttributeValue):
2307         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2308         (WTR::AccessibilityUIElement::stringAttributeValue):
2309
2310 2015-09-18  Alexey Proskuryakov  <ap@apple.com>
2311
2312         iOS WebKitTestRunner frequently crashes in WKContextGetIconDatabase
2313         https://bugs.webkit.org/show_bug.cgi?id=149352
2314
2315         Reviewed by Simon Fraser.
2316
2317         * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
2318         m_context can be null. This may indicate a bug in webkitpy too, but
2319         WebKitTestRunner should handle this situation nicely, there is nothing intrinsically
2320         wrong with opening and immediately closing it.
2321
2322 2015-09-18  Daniel Bates  <dabates@apple.com>
2323
2324         isGitSVNDirectory() returns true when Git is not installed
2325         https://bugs.webkit.org/show_bug.cgi?id=149351
2326
2327         Reviewed by Alexey Proskuryakov.
2328
2329         Fixes an issue where VCSUtils::isGitSVNDirectory() returns true for any arbitrary directory if
2330         Git is not installed on the machine.
2331
2332         * Scripts/VCSUtils.pm:
2333         (isGitSVNDirectory): Ensure that `git config --get svn-remote.svn.fetch 2>& 1` exits with
2334         status code 0 (success).
2335
2336 2015-09-18  Alex Christensen  <achristensen@webkit.org>
2337
2338         Prevent build-webkit from building four times on Windows 
2339         https://bugs.webkit.org/show_bug.cgi?id=149336
2340
2341         Reviewed by Brent Fulgham.
2342
2343         * Scripts/build-webkit:
2344         Move the Windows code out of the for loop iterating over each subdirectory to be build.
2345         They're built all at once.
2346         * Scripts/webkitdirs.pm:
2347         (buildVisualStudioProject):
2348         (cmakeGeneratedBuildfile):
2349         Don't generate the Visual Studio solution if it already exists.
2350         It will run CMake again if necessary.
2351
2352 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
2353
2354         [iOS WK2] WTR fails to set the key window in the UIKit sense
2355         https://bugs.webkit.org/show_bug.cgi?id=149325
2356
2357         Reviewed by Tim Horton.
2358
2359         -[WebKitTestRunnerWindow isKeyWindow] just returned _platformWebView->windowIsKey().
2360         This causes UIKit to bypass code that actually sets the key window, resulting in
2361         [UIAppliation sharedApplication].keyWindow always being nil.
2362
2363         Fix by PlatformWebView::setWindowIsKey() actually call -makeKeyWindow, and having
2364         -[WebKitTestRunnerWindow isKeyWindow] call super.
2365
2366         * WebKitTestRunner/PlatformWebView.h:
2367         (WTR::PlatformWebView::setWindowIsKey): Deleted.
2368         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2369         (WTR::PlatformWebView::setWindowIsKey):
2370         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2371         (WTR::PlatformWebView::setWindowIsKey):
2372         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2373         (-[WebKitTestRunnerWindow isKeyWindow]):
2374         (WTR::PlatformWebView::PlatformWebView):
2375         (WTR::PlatformWebView::~PlatformWebView):
2376         (WTR::PlatformWebView::setWindowIsKey):
2377         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2378         (WTR::PlatformWebView::setWindowIsKey):
2379
2380 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
2381
2382         [iOS WK2] When loading viewport tests, use the normal web page viewport configuration
2383         https://bugs.webkit.org/show_bug.cgi?id=149321
2384
2385         Reviewed by Tim Horton.
2386         
2387         InjectedBundlePage::platformDidStartProvisionalLoadForFrame() unconditionally 
2388         enabled the "testing" viewport configuration, which disables page scaling.
2389         
2390         If we're running viewport tests, we want the normal web page configuration.
2391         Do that by passing a flag in the dictionary sent to InjectedBundle::beginTesting(),
2392         based on whether the test is in a "viewport" directory.
2393
2394         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2395         (WTR::InjectedBundle::beginTesting):
2396         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2397         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Deleted.
2398         * WebKitTestRunner/TestInvocation.cpp:
2399         (WTR::TestInvocation::shouldLogFrameLoadDelegates):
2400         (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
2401         (WTR::TestInvocation::shouldMakeViewportFlexible):
2402         (WTR::TestInvocation::invoke):
2403         * WebKitTestRunner/TestInvocation.h:
2404         * WebKitTestRunner/ios/TestControllerIOS.mm:
2405         (WTR::TestController::platformConfigureViewForTest):
2406         (WTR::shouldMakeViewportFlexible): Deleted.
2407
2408 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
2409
2410         Give iOS WebKitTestRunner a launch storyboard
2411         https://bugs.webkit.org/show_bug.cgi?id=149314
2412
2413         Reviewed by Dan Bates.
2414         
2415         Add a launch storyboard to iOS WebKitTestRunner so that Springboard recognizes
2416         that it's been built for specific device configurations, and puts the window
2417         at the top of the screen. This simplifies coordinate conversions in a future patch.
2418
2419         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2420         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
2421         * WebKitTestRunner/ios/Launch.storyboard: Added.
2422
2423 2015-09-17  Myles C. Maxfield  <mmaxfield@apple.com>
2424
2425         Update licence in r189890
2426         https://bugs.webkit.org/show_bug.cgi?id=149306
2427
2428         Reviewed by Dean Jackson.
2429
2430         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
2431         * FontWithFeatures/FontWithFeatures/FontCreator.h:
2432         * FontWithFeatures/FontWithFeatures/main.cpp:
2433
2434 2015-09-17  Mark Lam  <mark.lam@apple.com>
2435
2436         Add the ability to skip JIT stress tests in run-javascriptcore-tests.
2437         https://bugs.webkit.org/show_bug.cgi?id=149285
2438
2439         Reviewed by Saam Barati.
2440
2441         Just need to add an option to pass --no-jit to run-jsc-stress-test.
2442
2443         * Scripts/run-javascriptcore-tests:
2444         (runJSCStressTests):
2445
2446 2015-09-17  Alex Christensen  <achristensen@webkit.org>
2447
2448         Switch AppleWin build to use CMake
2449         https://bugs.webkit.org/show_bug.cgi?id=149163
2450
2451         Reviewed by Brent Fulgham.
2452
2453         * Scripts/build-webkit:
2454         * Scripts/run-api-tests:
2455         (runTest):
2456         (listAllTests):
2457         (prepareEnvironmentForRunningTestTool):
2458         (testToolPaths):
2459         (testToolPath): Deleted.
2460         Run the API tests as separate executables on Windows.
2461         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
2462         * Scripts/webkitdirs.pm:
2463         (checkRequiredSystemConfig):
2464         (jhbuildWrapperPrefixIfNeeded):
2465         (generateBuildSystemFromCMakeProject):
2466         Fix configuration quirks.
2467
2468 2015-09-17  Dean Johnson  <dean_johnson@apple.com>
2469
2470         Added toggle options for hiding and showing certain platform families on the dashboard.
2471         https://bugs.webkit.org/show_bug.cgi?id=148403
2472
2473         Reviewed by David Kilzer.
2474
2475         This patch removes "hiddenPlatforms" from use in the code and local storage. We also removed
2476         individual hide/show buttons for platforms because we've added toggle options to hide/show entire
2477         families. Examples of these are "mac", "ios", and "linux". "Show All Platforms" was also removed
2478         in lieu of an "all" button in the toggle menu.
2479
2480         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2481         (parsePlatformFamily): Helper function to parse out a platform family.
2482         (initPlatformsByFamily): Initializes platformsByFamily, which organizes platforms on the
2483         page by platformsByFamily[<family>] = <list of platforms belonging to that family>.
2484         (updateToggleButtons): Updates the status of the toggle buttons.
2485         (updateHiddenPlatforms): Changed to work with the new implementation of hiding/showing platforms.
2486         (documentReady): Added creation of toggle buttons.
2487         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
2488         (unhiddenQueues): Updated to search by platform family instead of the individual platform name.
2489         (documentReady): Changed hiddenPlatforms => hiddenPlatformFamilies.
2490         (updateHiddenPlatforms): Deleted. After removing the individual hide button code, 
2491         this did the exact same thing as the updateHiddenPlatforms in Scripts/Main.js so it was removed.
2492         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
2493         (QueueView): Updated to use hiddenPlatformFamilies.
2494         (QueueView.prototype._updateHiddenState): Updated to use hiddenPlatformFamilies.
2495         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
2496         (Settings.prototype.toggleHiddenPlatformFamily): Renamed function and some variables.
2497         (Settings.prototype.clearHiddenPlatformFamilies): Now uses hiddenPlatformFamilies for events.
2498         (Settings.prototype.toggleHiddenPlatform): Deleted.
2499         (Settings.prototype.clearHiddenPlatforms): Deleted.
2500         (Settings.prototype.toggleShowPlatformFamily): Deleted.
2501         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2502         (div.cellButton, div.accessibilityButton, div.platformFamilyToggleButton):
2503         (div.cellButton.unhide, div.accessibilityButton.unhide, div.platformFamilyToggleButton.unhide):
2504         (.settings-visible div.settingsWrapper.hide, .settings-visible div.settingsWrapper):
2505         (table.queue-grid tr.headers th):
2506         (div.settingsWrapper.hide):
2507         (div.settingsWrapper):
2508         (div.familyToggleWrapper):
2509         (div.platformFamilyToggleButton):
2510         (div.platformFamilyShowToggleButton:not(:last-child)):
2511         (div.familyShown):
2512         (div.accessibilityButton):
2513         (div.cellButton, div.accessibilityButton): Added platformFamilyToggleButton class.
2514         (div.cellButton.unhide, div.accessibilityButton.unhide): Added platformFamilyToggleButton class.
2515         (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide): Added
2516         platformFamilyToggleButton and settingsWrapper class.
2517         (.accessibilityButton): Deleted.
2518
2519 2015-09-17  Tim Horton  <timothy_horton@apple.com>
2520
2521         Add a test ensuring that scrolling in the middle of a page can't start a swipe gesture
2522         https://bugs.webkit.org/show_bug.cgi?id=148904
2523
2524         Reviewed by Myles Maxfield.
2525
2526         * WebKitTestRunner/TestController.cpp:
2527         (WTR::parseBooleanTestHeaderValue):
2528         (WTR::updateViewOptionsFromTestHeader):
2529         Check for the key "useThreadedScrolling".
2530         Add some code to check for "true" and "false" for boolean options.
2531
2532         (WTR::TestController::viewOptionsForTest):
2533         Apply the test's overrides last, even after the platform's.
2534
2535 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
2536
2537         printing does not use minimum page zoom factor
2538         https://bugs.webkit.org/show_bug.cgi?id=108507
2539
2540         Reviewed by Darin Adler.
2541
2542         WebKitTestRunner always takes the snapshots from the UI process
2543         (expect for IOS), so in the case of printing, the layout in the
2544         web view is not the expected one. When printing, we need to take
2545         the snapshot in the web process and ensure it's rendered with a
2546         PrintContext.
2547
2548         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2549         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
2550         kWKSnapshotOptionsPrinting option to
2551         WKBundlePageCreateSnapshotWithOptions() when printing. When not
2552         printing, don't even create the snapshot, since it will be ignored
2553         by the UI process that always creates its own from the WebView (expect for IOS platform)
2554         * WebKitTestRunner/TestInvocation.cpp:
2555         (WTR::TestInvocation::dumpResults): Use always the snapshot image
2556         received from the web process if any when comparing pixel
2557         results. Now we only receive a snapshot from the web process in
2558         case of printing, or when platform is IOS. Otherwhise, generate
2559         the snapshot from the WebView as usual.
2560         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
2561         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
2562         is created by the caller now, but the CG implementation needs to
2563         know if it's a Web or UI process snapshot.
2564         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2565         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
2566         cairo surface for the given image.
2567         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2568         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
2569         CGContext for the given image.
2570
2571 2015-09-16  Myles C. Maxfield  <mmaxfield@apple.com>
2572
2573         Create a font which can be used for testing font features
2574         https://bugs.webkit.org/show_bug.cgi?id=149237
2575
2576         Reviewed by Simon Fraser.
2577
2578         This patch adds a new project in the Tools/ directory which generates a font which can
2579         be used for testing font features. This is a standalone project consisting of two files:
2580         1. A file which actually generates the byte vector representing the font. This file has
2581         a single public function: std::vector<uint8_t> generateFont(). This file is not platform
2582         specific, and only relies on the C++ STL.
2583         2. A file with a main() which calls generateFont() and writes out the font, as well as
2584         uses the font to render some demonstration text into a .png file. This file is platform
2585         specific.
2586
2587         The font itself only supports the following characters:
2588         ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
2589         However, the shape of these letters are either an X or a check mark.
2590
2591         The letter "A" always is a check mark.
2592         The letter "B" always is an X.
2593         Without any font features turned on, the rest of the letters are shown as X.
2594
2595         Each font feature has an letter associated with it. When the font feature is enabled,
2596         that letter is shown as a check mark. For example, when "smcp" is enabled, "J" is shown
2597         as a check mark.
2598
2599         Here are the mappings of font features to letters:
2600         liga: C
2601         clig: D
2602         dlig: E
2603         hlig: F
2604         calt: G
2605         subs: H
2606         sups: I
2607         smcp: J
2608         c2sc: K
2609         pcap: L
2610         c2pc: M
2611         unic: N
2612         titl: O
2613         onum: P
2614         pnum: Q
2615         tnum: R
2616         frac: S
2617         afrc: T
2618         ordn: U
2619         zero: V
2620         hist: W
2621         jp78: X
2622         jp83: Y
2623         jp90: Z
2624         jp04: a
2625         smpl: b
2626         trad: c
2627         fwid: d
2628         pwid: e
2629         ruby: f
2630
2631         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj: Added.
2632         * FontWithFeatures/FontWithFeatures/FontCreator.cpp: Added.
2633         (integralLog2):
2634         (roundDownToPowerOfTwo):
2635         (isFourByteAligned):
2636         (clampTo):
2637         (append32):
2638         (writeCFFEncodedNumber):
2639         (CFFBuilder::CFFBuilder):
2640         (CFFBuilder::takeResult):
2641         (CFFBuilder::moveTo):
2642         (CFFBuilder::lineTo):
2643         (CFFBuilder::curveToCubic):
2644         (CFFBuilder::closePath):
2645         (CFFBuilder::writePoint):
2646         (generateBoxCharString):
2647         (generateCheckCharString):
2648         (generateXCharString):
2649         (charStringForGlyph):
2650         (Generator::generate):
2651         (Generator::Placeholder::Placeholder):
2652         (Generator::Placeholder::populate):
2653         (Generator::Placeholder::~Placeholder):
2654         (Generator::placeholder):
2655         (Generator::append16):
2656         (Generator::append32):
2657         (Generator::append32BitCode):
2658         (Generator::overwrite16):
2659         (Generator::overwrite32):
2660         (Generator::appendCFFTable):
2661         (Generator::appendSubstitutionSubtable):
2662         (Generator::appendScriptSubtable):
2663         (Generator::appendGSUBTable):
2664         (Generator::appendOS2Table):
2665         (Generator::appendFormat12CMAPTable):
2666         (Generator::appendFormat4CMAPTable):
2667         (Generator::appendCMAPTable):
2668         (Generator::appendHEADTable):
2669         (Generator::appendHHEATable):
2670         (Generator::appendHMTXTable):
2671         (Generator::appendMAXPTable):
2672         (Generator::appendNAMETable):
2673         (Generator::appendPOSTTable):
2674         (Generator::calculateChecksum):
2675         (Generator::appendTable):
2676         (generateFont):
2677         * FontWithFeatures/FontWithFeatures/FontCreator.h: Added.
2678         * FontWithFeatures/FontWithFeatures/main.cpp: Added.
2679         (drawTextWithFeature):
2680         (main):
2681
2682 2015-09-16  Commit Queue  <commit-queue@webkit.org>
2683
2684         Unreviewed, rolling out r189875 and r189878.
2685         https://bugs.webkit.org/show_bug.cgi?id=149235
2686
2687         cygwin cmake build not ready yet (Requested by alexchristensen
2688         on #webkit).
2689
2690         Reverted changesets:
2691
2692         "Switch AppleWin build to use CMake"
2693         https://bugs.webkit.org/show_bug.cgi?id=149163
2694         http://trac.webkit.org/changeset/189875
2695
2696         "Cygwin build fix after r189875"
2697         http://trac.webkit.org/changeset/189878
2698
2699 2015-09-16  Alex Christensen  <achristensen@webkit.org>
2700
2701         Cygwin build fix after r189875
2702
2703         * Scripts/build-webkit:
2704         * Scripts/webkitdirs.pm:
2705         (jhbuildWrapperPrefixIfNeeded):
2706         (generateBuildSystemFromCMakeProject):
2707         Make things work with cygwin and cmake.
2708
2709 2015-09-16  Alex Christensen  <achristensen@webkit.org>
2710
2711         Switch AppleWin build to use CMake
2712         https://bugs.webkit.org/show_bug.cgi?id=149163
2713
2714         Reviewed by Brent Fulgham.
2715
2716         * Scripts/build-webkit:
2717         Build with CMake.
2718         * Scripts/run-api-tests:
2719         (runTest):
2720         (listAllTests):
2721         (prepareEnvironmentForRunningTestTool):
2722         (testToolPaths):
2723         (testToolPath): Deleted.
2724         Run the API tests as separate executables on Windows.
2725         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
2726
2727 2015-09-16  Alexey Proskuryakov  <ap@apple.com>
2728
2729         Add newer build.webkit.org pages to robots.txt
2730         https://bugs.webkit.org/show_bug.cgi?id=149219
2731
2732         Reviewed by Darin Adler.
2733
2734         Indexing bot watcher's dashboard can't be good.
2735
2736         * BuildSlaveSupport/build.webkit.org-config/public_html/robots.txt:
2737
2738 2015-09-16  Alex Christensen  <achristensen@webkit.org>
2739
2740         Rollout r189851 and 189853 because they didn’t actually fix the permissions issue
2741
2742         * BuildSlaveSupport/built-product-archive:
2743         (unzipArchive):
2744
2745 2015-09-16  Csaba Osztrogonác  <ossy@webkit.org>
2746
2747         [EFL] Fix the help message of separated web process option of MiniBrowser
2748         https://bugs.webkit.org/show_bug.cgi?id=149212
2749
2750         Reviewed by Gyuyoung Kim.
2751
2752         * MiniBrowser/efl/main.c:
2753
2754 2015-09-16  Alex Christensen  <achristensen@webkit.org>
2755
2756         Fix python syntax after r189851.
2757
2758         * BuildSlaveSupport/built-product-archive:
2759         (unzipArchive):
2760         For loops need a colon.
2761
2762 2015-09-15  Alex Christensen  <achristensen@webkit.org>
2763
2764         Fix Windows test bots after changing to non-cygwin build
2765         https://bugs.webkit.org/show_bug.cgi?id=149196
2766
2767         Reviewed by Daniel Bates.
2768
2769         * BuildSlaveSupport/built-product-archive:
2770         (unzipArchive):
2771         Using different versions of python makes what I think is https://bugs.python.org/issue15795
2772         prevent us from executing files from the archive on the test bots.
2773
2774 2015-09-15  Ryosuke Niwa  <rniwa@webkit.org>
2775
2776         Add ShadowRoot interface and Element.prototype.attachShadow
2777         https://bugs.webkit.org/show_bug.cgi?id=149187
2778
2779         Reviewed by Antti Koivisto.
2780
2781         * Scripts/webkitperl/FeatureList.pm:
2782
2783 2015-09-15  Aakash Jain  <aakash_jain@apple.com>
2784
2785         Appscale queue status json output lacks bots
2786         https://bugs.webkit.org/show_bug.cgi?id=149194
2787         <rdar://problem/22171089>
2788
2789         Reviewed by Alexey Proskuryakov.
2790
2791         * QueueStatusServer/handlers/queuestatusjson.py:
2792         (QueueStatusJSON._bots): Order the results by date so as to get latest events, this was default in AppEngine.
2793         * QueueStatusServer/index.yaml: Index according to appscale requirements.
2794
2795 2015-09-15  Brent Fulgham  <bfulgham@apple.com>
2796
2797         [Win] Provide a means for viewing the layer tree
2798         https://bugs.webkit.org/show_bug.cgi?id=149165
2799
2800         Reviewed by Simon Fraser.
2801
2802         Update MiniBrowser with a new Debug menu option that will
2803         dump the current layer tree to the debug console.
2804         
2805         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc:
2806         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h:
2807         * MiniBrowser/win/Common.cpp:
2808         (WndProc): Add handler for 'Print Layer Tree' menu option.
2809         * MiniBrowser/win/MiniBrowser.cpp:
2810         (MiniBrowser::printLayerTree): Added Handler.
2811         * MiniBrowser/win/MiniBrowser.h:
2812
2813 2015-09-14  Myles C. Maxfield  <mmaxfield@apple.com>
2814
2815         WebKitTestRunner declarative language setting is broken for iOS
2816         https://bugs.webkit.org/show_bug.cgi?id=149119
2817
2818         Unreviewed.
2819
2820         In all of the patches on webkit.org/b/189669, my patch to get this working on iOS was
2821         lost in the final version which got committed. This simply implements the existing
2822         OS X behavior on iOS.
2823
2824         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
2825         (WTR::InjectedBundle::platformInitialize):
2826
2827 2015-09-14  Dewei Zhu  <dewei_zhu@apple.com>
2828
2829         Unreviewed, add myself to committers list.
2830
2831         * Scripts/webkitpy/common/config/contributors.json:
2832
2833 2015-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
2834
2835         [Cocoa] Allow testing with the system language
2836         https://bugs.webkit.org/show_bug.cgi?id=148671
2837
2838         Reviewed by Anders Carlsson and Alexey Proskuryakov.
2839
2840         React to tests marked with language=lang1,lang2,etc in their header.
2841         Once this information is parsed, pass it to
2842         WKContextConfigurationSetOverrideLanguages().
2843
2844         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2845         (WTR::InjectedBundle::platformInitialize): Don't clobber the language
2846         list.
2847         * WebKitTestRunner/TestController.cpp:
2848         (WTR::TestController::createWebViewWithOptions): Call
2849         WKContextConfigurationSetOverrideLanguages().
2850         (WTR::updateTestOptionsFromTestHeader): Inspect the language option.
2851         * WebKitTestRunner/TestOptions.h:
2852         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2853         (WTR::PlatformWebView::viewSupportsOptions): Cause a differing language
2854         option to restart the web process.
2855         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2856         (WTR::PlatformWebView::viewSupportsOptions): Ditto.
2857
2858 2015-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
2859
2860         [WKTR] Allow changing the WKContextConfiguration between successive tests
2861         https://bugs.webkit.org/show_bug.cgi?id=148833
2862
2863         Reviewed by Tim Horton.
2864
2865         Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
2866         However, there are certain tests which require specifying options in this object. This patch makes
2867         our existing code for recreating the test runner web view also recreate the WKContext.
2868
2869         As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
2870         class.
2871
2872         * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
2873         * WebKitTestRunner/PlatformWebView.h:
2874         (WTR::PlatformWebView::options):
2875         * WebKitTestRunner/TestController.cpp:
2876         (WTR::TestController::initialize):
2877         (WTR::TestController::generateContextConfiguration):
2878         (WTR::TestController::generatePageConfiguration):
2879         (WTR::TestController::createWebViewWithOptions):
2880         (WTR::TestController::ensureViewSupportsOptionsForTest):
2881         (WTR::updateContextConfigurationOptionsFromTestHeader):
2882         (WTR::TestController::contextConfigurationOptionsForTest):
2883         (WTR::TestController::platformCreateWebView):
2884         (WTR::TestController::platformCreateOtherPage):
2885         (WTR::updateViewOptionsFromTestHeader): Deleted.
2886         (WTR::TestController::viewOptionsForTest): Deleted.
2887         * WebKitTestRunner/TestController.h:
2888         (WTR::TestController::injectedBundlePath):
2889         (WTR::TestController::testPluginDirectory):
2890         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2891         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2892         (WTR::TestController::platformCreateWebView):
2893         (WTR::TestController::platformCreateOtherPage):
2894         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2895         (WTR::PlatformWebView::PlatformWebView):
2896         (WTR::PlatformWebView::viewSupportsOptions):
2897         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2898         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2899         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2900         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2901         (WTR::PlatformWebView::PlatformWebView):
2902         (WTR::PlatformWebView::viewSupportsOptions):
2903         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2904         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2905         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2906         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2907         (WTR::PlatformWebView::PlatformWebView):
2908         (WTR::PlatformWebView::viewSupportsOptions):
2909         * WebKitTestRunner/ios/TestControllerIOS.mm:
2910         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2911         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2912         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2913         (WTR::PlatformWebView::PlatformWebView):
2914         (WTR::PlatformWebView::viewSupportsOptions):
2915         * WebKitTestRunner/mac/TestControllerMac.mm:
2916         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2917         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2918
2919 2015-09-11  Michael Saboff  <msaboff@apple.com>
2920
2921         LayoutTestHelper crashes if a color profile isn't set for a 3rd party monitor
2922         https://bugs.webkit.org/show_bug.cgi?id=149083
2923
2924         Reviewed by Alexey Proskuryakov.
2925
2926         Check to make sure that we have a valid factoryProfile CFDictionaryRef before using it.
2927
2928         * DumpRenderTree/mac/LayoutTestHelper.m:
2929         (colorProfileURLForDisplay):
2930
2931 2015-09-11  Saam barati  <sbarati@apple.com>
2932
2933         There should be a defaultSpotCheck-like mode that doesn't run the MaximalFlushInsertionPhase in run-jsc-stress-tests
2934         https://bugs.webkit.org/show_bug.cgi?id=149058
2935
2936         Reviewed by Geoffrey Garen.
2937
2938         * Scripts/run-jsc-stress-tests:
2939
2940 2015-09-10  Commit Queue  <commit-queue@webkit.org>
2941
2942         Unreviewed, rolling out r189595.
2943         https://bugs.webkit.org/show_bug.cgi?id=149052
2944
2945         The tests still fail (Requested by ap on #webkit).
2946
2947         Reverted changeset:
2948
2949         "Spurious output on Windows tests: AQMEIOManager::FindIOUnit:
2950         error -1"
2951         https://bugs.webkit.org/show_bug.cgi?id=142929
2952         http://trac.webkit.org/changeset/189595
2953
2954 2015-09-10  Alexey Proskuryakov  <ap@apple.com>
2955
2956         Spurious output on Windows tests: AQMEIOManager::FindIOUnit: error -1
2957         https://bugs.webkit.org/show_bug.cgi?id=142929
2958
2959         Reviewed by Brent Fulgham.
2960
2961         Silence the logging. We'll track fixing the root cause in Radar.
2962
2963         * Scripts/webkitpy/port/mac.py:
2964         (MacPort.stderr_patterns_to_strip): Added a FIXME.
2965
2966         * Scripts/webkitpy/port/win.py:
2967         (WinPort.logging_patterns_to_strip): Added.
2968
2969 2015-09-09  Andy Estes  <aestes@apple.com>
2970
2971         [iOS] Teach run-webkit-tests how to parse simulator runtimes when version numbers contain a revision
2972         https://bugs.webkit.org/show_bug.cgi?id=149022
2973
2974         Reviewed by Daniel Bates.
2975
2976         Simulator runtime versions can contain a revision number (e.g. 8.4.1), but the regex for matching runtimes
2977         did not account for this.
2978
2979         * Scripts/webkitpy/xcode/simulator.py:
2980         (Simulator): Optionally matched a revision at the end of a runtime version number.
2981         * Scripts/webkitpy/xcode/simulator_unittest.py: Added a test.
2982
2983 2015-09-09  Andy Estes  <aestes@apple.com>
2984
2985         [iOS] Teach run-webkit-tests how to parse `simctl list` when a tvOS SDK is installed
2986         https://bugs.webkit.org/show_bug.cgi?id=149029
2987         <rdar://problem/22432624>
2988
2989         Reviewed by Daniel Bates.
2990
2991         * Scripts/webkitpy/xcode/simulator.py:
2992         (Simulator): Taught to parse tvOS runtimes.
2993         * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
2994
2995 2015-09-09  Alexey Proskuryakov  <ap@apple.com>
2996
2997         Fix bit rot on bot watcher's dashboard page
2998         https://bugs.webkit.org/show_bug.cgi?id=149012
2999
3000         Reviewed by Tim Horton.
3001
3002         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3003         The code path used by the metrics page was trying to add properties to an undefined.
3004
3005         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
3006         Silence an expection that would occur when the step has no logs. This should never
3007         happen, but it did (perhaps buildbot was misconfigured for a while).
3008
3009 2015-09-09  Alexey Proskuryakov  <ap@apple.com>
3010
3011         Update LayoutTestRelay xcconfig file.
3012
3013         Rubber-stamped by Dan Bernstein.
3014
3015         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
3016
3017 2015-09-09  Saam barati  <sbarati@apple.com>
3018
3019         DFG should have a debugging option that runs a phase that flushes all locals
3020         https://bugs.webkit.org/show_bug.cgi?id=148916
3021
3022         Reviewed by Filip Pizlo.
3023
3024         * Scripts/run-jsc-stress-tests:
3025
3026 2015-09-09  Commit Queue  <commit-queue@webkit.org>
3027
3028         Unreviewed, rolling out r189530 and r189534.
3029         https://bugs.webkit.org/show_bug.cgi?id=148996
3030
3031         Caused assertion failures on Yosemite (Requested by litherum
3032         on #webkit).
3033
3034         Reverted changesets:
3035
3036         "[WKTR] Allow changing the WKContextConfiguration between
3037         successive tests"
3038         https://bugs.webkit.org/show_bug.cgi?id=148833
3039         http://trac.webkit.org/changeset/189530
3040
3041         "[Cocoa] Fix the tests after r189530"
3042         http://trac.webkit.org/changeset/189534
3043
3044 2015-09-08  Myles C. Maxfield  <mmaxfield@apple.com>
3045
3046         [Cocoa] Fix the tests after r189530
3047
3048         Unreviewed.
3049
3050         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3051         (WTR::initializeWebViewConfiguration):
3052
3053 2015-09-08  Myles C. Maxfield  <mmaxfield@apple.com>
3054
3055         [WKTR] Allow changing the WKContextConfiguration between successive tests
3056         https://bugs.webkit.org/show_bug.cgi?id=148833
3057
3058         Reviewed by Tim Horton.
3059
3060         Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
3061         However, there are certain tests which require specifying options in this object. This patch makes
3062         our existing code for recreating the test runner web view also recreate the WKContext.
3063
3064         As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
3065         class.
3066
3067         * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
3068         * WebKitTestRunner/PlatformWebView.h:
3069         (WTR::PlatformWebView::options):
3070         * WebKitTestRunner/TestController.cpp:
3071         (WTR::TestController::initialize):
3072         (WTR::TestController::generateContextConfiguration):
3073         (WTR::TestController::generatePageConfiguration):
3074         (WTR::TestController::createWebViewWithOptions):
3075         (WTR::TestController::ensureViewSupportsOptionsForTest):
3076         (WTR::updateContextConfigurationOptionsFromTestHeader):
3077         (WTR::TestController::contextConfigurationOptionsForTest):
3078         (WTR::TestController::platformCreateWebView):
3079         (WTR::TestController::platformCreateOtherPage):
3080         (WTR::updateViewOptionsFromTestHeader): Deleted.
3081         (WTR::TestController::viewOptionsForTest): Deleted.
3082         * WebKitTestRunner/TestController.h:
3083         (WTR::TestController::injectedBundlePath):
3084         (WTR::TestController::testPluginDirectory):
3085         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3086         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3087         (WTR::TestController::platformCreateWebView):
3088         (WTR::TestController::platformCreateOtherPage):
3089         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3090         (WTR::PlatformWebView::PlatformWebView):
3091         (WTR::PlatformWebView::viewSupportsOptions):
3092         * WebKitTestRunner/efl/TestControllerEfl.cpp:
3093         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
3094         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
3095         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3096         (WTR::PlatformWebView::PlatformWebView):
3097         (WTR::PlatformWebView::viewSupportsOptions):
3098         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3099         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
3100         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
3101         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3102         (WTR::PlatformWebView::PlatformWebView):
3103         (WTR::PlatformWebView::viewSupportsOptions):
3104         * WebKitTestRunner/ios/TestControllerIOS.mm:
3105         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
3106         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
3107         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3108         (WTR::PlatformWebView::PlatformWebView):
3109         (WTR::PlatformWebView::viewSupportsOptions):
3110         * WebKitTestRunner/mac/TestControllerMac.mm:
3111         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
3112         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
3113
3114 2015-09-08  Daniel Bates  <dabates@apple.com>
3115
3116         [Mac] Expose Enable/Disable Accelerated Drawing in MiniBrowser
3117         https://bugs.webkit.org/show_bug.cgi?id=148980
3118
3119         Reviewed by Alexey Proskuryakov.
3120
3121         Add setting to enable/disable accelerated drawing so as to support testing
3122         this feature in MiniBrowser on Mac.
3123
3124         * MiniBrowser/mac/SettingsController.h:
3125         * MiniBrowser/mac/SettingsController.m:
3126         (-[SettingsController _populateMenu]): Add menu item.
3127         (-[SettingsController validateMenuItem:]): Update setting when menu item is toggled.
3128         (-[SettingsController toggleAcceleratedDrawingEnabled:]): Added.
3129         (-[SettingsController acceleratedDrawingEnabled]): Added.
3130         * MiniBrowser/mac/WK1BrowserWindowController.m:
3131         (-[WK1BrowserWindowController didChangeSettings]): Apply setting in WebKit1.
3132         * MiniBrowser/mac/WK2BrowserWindowController.m:
3133         (-[WK2BrowserWindowController didChangeSettings]): Apply setting in WebKit2.
3134
3135 2015-09-08  Jason Marcell  <jmarcell@apple.com>
3136
3137         Unreviewed. Added myself as a commiter in contributors.json.
3138
3139         * Scripts/webkitpy/common/config/contributors.json:
3140
3141 2015-09-08  Keith Miller  <keith_miller@apple.com>
3142
3143         Unreviewed, added myself to the list of contributors.
3144
3145         * Scripts/webkitpy/common/config/contributors.json:
3146
3147 2015-09-08  Daniel Bates  <dabates@apple.com>
3148
3149         Dashboard: Remove use of z-index for ring overlay; use DOM ordering
3150         https://bugs.webkit.org/show_bug.cgi?id=148921
3151
3152         Reviewed by Alexey Proskuryakov.
3153
3154         The ring image is positioned above the platform icon in markup and we specify the CSS
3155         property z-index for the ring image so that it is painted on top of the platform icon
3156         instead of below it (by DOM ordering). Instead we can take advantage of the transparency
3157         of the ring image, switch the order of these DOM elements and remove the use of the CSS
3158         property z-index to achieve a similar effect.
3159
3160         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3161         (documentReady): Create the platform icon image element before the ring image such that
3162         the ring image is painted on top of the platform icon.
3163         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3164         (table.queue-grid td.logo img.ring): Removed property z-index.
3165
3166 2015-09-08  Daniel Bates  <dabates@apple.com>
3167
3168         Dashboard: Remove duplicate gear icon data URLs
3169         https://bugs.webkit.org/show_bug.cgi?id=148920
3170
3171         Reviewed by Alexey Proskuryakov.
3172
3173         Currently we duplicate the SVG data URL for the gear icon up to its fill color in the CSS property
3174         background-image associated with each of the three gear icon states: collapsed (.settings), hover
3175         (.settings:hover), and expanded (.settings-visible .settings). Instead we should use the gear icon
3176         as a mask and make use of the CSS background-color to define the fill color for each of these three
3177         states.
3178
3179         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3180         (.settings): Use gear icon as mask and define CSS background-color for collapsed state. 
3181         (.settings:hover): Override CSS background-color for hover state.
3182         (.settings-visible .settings): Override CSS background-color for expanded state.
3183
3184 2015-09-07  Andy Estes  <aestes@apple.com>
3185
3186         [Mac] DebugRelease builds should link against libWebKitSystemInterfaceElCapitan.a on 10.11
3187         https://bugs.webkit.org/show_bug.cgi?id=148946
3188         <rdar://problem/22603981>
3189
3190         Reviewed by Dan Bernstein.
3191
3192         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3193         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3194
3195 2015-09-07  Hunseop Jeong  <hs85.jeong@samsung.com>
3196
3197         [EFL] Many of the css3/device-adapt/* tests failed after r188548.
3198         https://bugs.webkit.org/show_bug.cgi?id=148927
3199
3200         Reviewed by Csaba Osztrogonác.
3201
3202         device-adapt/* tests need the fixedLayout option but useFixedLayout option is
3203         overwritten by updatePlatformSpecificViewOptionsForTest after r188548.
3204
3205         * WebKitTestRunner/TestController.cpp:
3206         (WTR::shouldUseFixedLayout): Removed the unnecessary indentations.
3207         * WebKitTestRunner/efl/TestControllerEfl.cpp:
3208         (WTR::shouldUseFixedLayout): Return true if the test is related with 'device-adapt'.
3209
3210 2015-09-07  Andy Estes  <aestes@apple.com>
3211
3212         Fix the Production build after r189455.
3213
3214         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Somehow I added the All target using the
3215         In-App Purchase template instead of the Aggregate template. Whoops.
3216
3217 2015-09-06  Andy Estes  <aestes@apple.com>
3218
3219         WebKit.xcworkspace should be be able to build iOS platforms
3220         https://bugs.webkit.org/show_bug.cgi?id=148881
3221
3222         Reviewed by Daniel Bates.
3223
3224         Since we don't want to create platform-specific schemes, all projects in the workspace's schemes need to build
3225         for all supported platforms.
3226
3227         * MiniBrowser/Configurations/Base.xcconfig: Included iphoneos and iphonesimulator in SUPPORTED_PLATFORMS.
3228         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Excluded all source files on iOS, and linked Cocoa and WebKit on Mac.
3229         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Ditto.
3230         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Stopped linking frameworks in Link Binaries With Libraries.
3231
3232 2015-09-06  Andy Estes  <aestes@apple.com>
3233
3234         WebKitTestRunner should build for iOS using the default target
3235         https://bugs.webkit.org/show_bug.cgi?id=148918
3236
3237         Reviewed by Daniel Bates.
3238
3239         When WebKitTestRunner was ported to iOS, a separate target (WebKitTestRunnerApp) was created for building the
3240         iOS variant. This is annoying because (1) all tools that invoke xcodebuild need to be taught to build this
3241         non-default target, and (2) a single Xcode scheme cannot be used to build both Mac and iOS variants.
3242
3243         This change adds a new default target (All) and makes it work for both Mac and iOS. Files that were built for
3244         both WebKitTestRunner and WebKitTestRunnerApp are now built in a static library target (WebKitTestRunner (Library)),
3245         and both apps now link this library. Files that are specific to Mac or iOS are excluded on the other platform.
3246         WebKitTestRunnerApp.app (which should be renamed to WebKitTestRunner.app) is skipped when installing on Mac, and
3247         WebKitTestRunner is skipped when installing on iOS.
3248
3249         The target dependency graph now looks like this:
3250
3251             All
3252                 WebKitTestRunnerApp
3253                     WebKitTestRunner (Library)
3254                         WebKitTestRunnerInjectedBundle
3255                             Derived Sources
3256                 WebKitTestRunner
3257                     WebKitTestRunner (Library)
3258                         WebKitTestRunnerInjectedBundle
3259                             Derived Sources
3260
3261         * Scripts/build-webkit: Stopped building the WebKitTestRunnerApp target on iOS.
3262         * Scripts/build-webkittestrunner: Ditto.
3263         * WebKitTestRunner/Configurations/Base.xcconfig: Set SUPPORTED_PLATFORMS to macosx, iphoneos, and iphonesimulator.
3264         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Set INSTALL_PATH here since it is the same for all targets.
3265         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Stopped setting INSTALL_PATH.
3266         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Moved frameworks from the build phase to here,
3267         excluded iOS-only files, and skipped installing on iOS.
3268         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Moved frameworks from the build phase to here,
3269         excluded Mac-only files, and skipped installing on Mac.
3270         * WebKitTestRunner/Configurations/WebKitTestRunnerLibrary.xcconfig: Skipped installing always.
3271         * WebKitTestRunner/Makefile: Stopped building the WebKitTestRunnerApp target on iOS.
3272         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added new targets, removed frameworks from
3273         Link Binary With Libraries builds phases, moved common files to the WebKitTestRunner (Library) target, and added
3274         new configuration files.
3275
3276 2015-09-05  Joseph Pecoraro  <pecoraro@apple.com>
3277
3278         Web Inspector: Improve prepare-ChangeLog for multiple cases
3279         https://bugs.webkit.org/show_bug.cgi?id=148875
3280
3281         Reviewed by Timothy Hatcher.
3282
3283         * Scripts/prepare-ChangeLog:
3284         (get_function_line_ranges_for_javascript):
3285         - We were ignoring everything inside of an anonymous function expression,
3286           such as (function(){ ... }), which made InjectedScriptSource produce nothing.
3287           Better handle this by inserting a few tweaks.
3288         - Allow method syntax outside of classes as long as they are at the global level.
3289         - Avoid treating "get" and "set" as getter/setter functions in bad contexts.
3290
3291         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
3292         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
3293         (Foo.prototype.method1):
3294         (Foo.prototype.method2):
3295         (Foo.prototype.method3.innerFunction):
3296         (Foo.prototype.method3):
3297         (insideGlobalAnonymousFunctionExpression):
3298         (foo.insideGlobalFunctionExpression):
3299         (IssueWithMapGetAndSet.prototype.method1.nestedFunctionInsideMethod1):
3300         (IssueWithMapGetAndSet.prototype.method1):
3301         (IssueWithMapGetAndSet.prototype.method2):
3302         (IssueWithMapGetAndSet.prototype.method3):
3303         (IssueWithMapGetAndSet):
3304
3305 2015-09-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3306
3307         [ES6] Enable ES6 Module in JSC shell by default
3308         https://bugs.webkit.org/show_bug.cgi?id=148689
3309
3310         Reviewed by Geoffrey Garen.
3311
3312         * Scripts/run-javascriptcore-tests:
3313         (runJSCStressTests):
3314         * Scripts/run-jsc-stress-tests:
3315
3316 2015-09-04  Basile Clement  <basile_clement@apple.com>
3317
3318         Unreviewed, change my email address.
3319
3320         * Scripts/webkitpy/common/config/contributors.json:
3321
3322 2015-09-04  Beth Dakin  <bdakin@apple.com>
3323
3324         Should have a test to make sure links don't navigate after a cancelled force 
3325         click
3326         https://bugs.webkit.org/show_bug.cgi?id=148846
3327
3328         Reviewed by Tim Horton.
3329
3330         New EventSender function for a started then cancelled force click.
3331         * WebKitTestRunner/EventSenderProxy.h:
3332         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3333         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3334         (WTR::EventSendingController::mouseForceClick):
3335         (WTR::EventSendingController::startAndCancelMouseForceClick):
3336         (WTR::EventSendingController::mouseForceDown):
3337         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3338         * WebKitTestRunner/TestController.cpp:
3339         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3340         * WebKitTestRunner/mac/EventSenderProxy.mm:
3341         (WTR::EventSenderProxy::mouseForceClick):
3342         (WTR::EventSenderProxy::startAndCancelMouseForceClick):
3343         (WTR::EventSenderProxy::mouseForceDown):
3344         (WTR::EventSenderProxy::mouseMoveTo):
3345
3346 2015-09-04  Tim Horton  <timothy_horton@apple.com>
3347
3348         Add a test for r179736 (programmatic navigation during swipe causing a crash)
3349         https://bugs.webkit.org/show_bug.cgi?id=148830
3350
3351         Reviewed by Beth Dakin.
3352
3353         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3354         (WTR::InjectedBundle::beginTesting):
3355         Make sure that TestRunner callbacks don't leak between tests!
3356
3357 2015-09-04  Anders Carlsson  <andersca@apple.com>
3358
3359         It should be possible to pass relative HTTP test paths to DumpRenderTree
3360         https://bugs.webkit.org/show_bug.cgi?id=148825
3361         <rdar://problem/22583866>
3362
3363         Reviewed by Tim Horton.
3364
3365         Convert the path to an absolute path if needed.
3366
3367         * DumpRenderTree/mac/DumpRenderTree.mm:
3368         (computeTestURL):
3369
3370 2015-09-04  Jason Marcell  <jmarcell@apple.com>
3371
3372         Fix Swift unit tests for prepare-ChangeLog.
3373         https://bugs.webkit.org/show_bug.cgi?id=148817
3374
3375         Reviewed by Alexey Proskuryakov.
3376
3377         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Fixed
3378         Swift unit tests for prepare-ChangeLog.
3379
3380 2015-09-04  Lucas Forschler  <lforschler@apple.com>
3381
3382         Modifications to the webkit-nightly logic.
3383         
3384         * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
3385         (updateAlertPanel):
3386         * WebKitLauncher/main.m:
3387         (displayErrorAndQuit):
3388
3389 2015-09-04  Beth Dakin  <bdakin@apple.com>
3390
3391         Speculative build fix.
3392
3393         * WebKitTestRunner/mac/EventSenderProxy.mm:
3394
3395 2015-09-04  Brian Burg  <bburg@apple.com>
3396
3397         Web Inspector: InspectorController should support multiple frontend channels
3398         https://bugs.webkit.org/show_bug.cgi?id=148538
3399
3400         Reviewed by Joseph Pecoraro.
3401
3402         InspectorClients must explicitly disconnect their frontend channel(s) from the
3403         inspected page's InspectorController.
3404
3405         To make this possible, DumpRenderTree should not destroy non-primary views until
3406         it has tried to close any abandoned Web Inspector instances. Performing teardown
3407         in the reverse order prevents disconnection of the frontend channel because that
3408         prematurely destroys the inspector frontend client.
3409
3410         * DumpRenderTree/mac/DumpRenderTree.mm:
3411         (runTest):
3412         * DumpRenderTree/win/DumpRenderTree.cpp:
3413         (runTest):
3414
3415 2015-09-04  Beth Dakin  <bdakin@apple.com>
3416
3417         Need to be able to test default behaviors on force click
3418         https://bugs.webkit.org/show_bug.cgi?id=148758
3419
3420         Reviewed by Tim Horton.
3421
3422         This patch adds a new eventSender method to do a full, completed force click, 
3423         and it re-works all of the existing force methods to dispatch their events in 
3424         such a way that they will trigger the NSImmediateAction gesture recognizer. 
3425         To do this, first we need to send the events to the app rather than straight 
3426         to the view, and also needed to tweak some state and send the events in a 
3427         delayed fashion.
3428
3429         New public function mouseForceClick() and private helper functions to make 
3430         NSEvents.
3431         * WebKitTestRunner/EventSenderProxy.h:
3432
3433         New public function mouseForceClick().
3434         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3435         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3436         (WTR::EventSendingController::mouseMoveTo):
3437         (WTR::EventSendingController::mouseForceClick):
3438         (WTR::EventSendingController::mouseForceDown):
3439         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3440         * WebKitTestRunner/TestController.cpp:
3441         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3442
3443         initPressureEventAtLocation needs to take a stageTransition and a window.
3444         * WebKitTestRunner/mac/EventSenderProxy.mm:
3445         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
3446         (-[EventSenderSyntheticEvent stageTransition]):
3447         (-[EventSenderSyntheticEvent timestamp]):
3448         (-[EventSenderSyntheticEvent _cgsEventRecord]):
3449         (-[EventSenderSyntheticEvent window]):
3450
3451         In order to enter the gesture recognizer, we need to start with a mouse down 
3452         that has a NSEventMaskPressure modifier.
3453         (WTR::EventSenderProxy::sendMouseDownToStartPressureEvents):
3454
3455         This ensures that the events queue properly for the force monitor in AppKit.
3456         (WTR::spinRunLoopForForce):
3457
3458          We need to start the pressure change events with a began.
3459         (WTR::EventSenderProxy::beginPressureEvent):
3460
3461         These functions can be used to create the NSEvent for a pressure change every 
3462         time we need one.
3463         (WTR::EventSenderProxy::pressureChangeEvent):
3464
3465         Send the right series of events to emulate a full, completed force click.
3466         (WTR::EventSenderProxy::mouseForceClick):
3467
3468         Use all of the new things for these existing functions.
3469         (WTR::EventSenderProxy::mouseForceDown):
3470         (WTR::EventSenderProxy::mouseForceUp):
3471         (WTR::EventSenderProxy::mouseForceChanged):
3472
3473         Set NSFakeForceTouchDevice to YES.
3474         * WebKitTestRunner/mac/main.mm:
3475         (setDefaultsToConsistentValuesForTesting):
3476
3477 2015-09-04  Jason Marcell  <jmarcell@apple.com>
3478
3479         prepare-ChangeLog needs to know how to parse Swift files.
3480         https://bugs.webkit.org/show_bug.cgi?id=148784
3481         <rdar://problem/22510062>
3482
3483         Reviewed by Darin Adler.
3484
3485         * Scripts/prepare-ChangeLog:
3486         (get_function_line_ranges): Added entry for get_function_line_ranges_for_swift.
3487         (get_function_line_ranges_for_swift): Added function that knows how to parse Swift code.
3488         (parseSwiftFunctionArgs): Added function that knows how to parse Swift function arguments.
3489         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl: Added.
3490         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Ditto.
3491         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests.swift: Ditto.
3492         (freeFunction): Ditto.
3493         (MyClass.function): Ditto.
3494         (MyClass.functionWithArgument(_:)): Ditto.
3495         (MyClass.functionWithMoreArguments(_:arg2:)): Ditto.
3496         (MyClass.functionWithNamedFirstArgument(argument:)): Ditto.
3497         (MyClass.functionWithNamedFirstAndSecondArgument(first:second:)): Ditto.
3498         (MyClass.classFunction): Ditto.
3499         (MyClass.readWriteComputedVariable): Ditto.
3500         (MyClass.readOnlyComputedVariable): Ditto.
3501
3502 2015-09-04  Ryosuke Niwa  <rniwa@webkit.org>
3503
3504         Import css/css-color-3
3505         https://bugs.webkit.org/show_bug.cgi?id=148803
3506
3507         Reviewed by Chris Dumez.
3508
3509         Fixed a bug that the imported reference files used the same extention as tests.
3510         This would result in parsing errors if the tests were XML and references were HTML and vice versa.
3511
3512         * Scripts/webkitpy/w3c/test_importer.py:
3513         (TestImporter.find_importable_tests):
3514
3515 2015-09-03  Commit Queue  <commit-queue@webkit.org>
3516
3517         Unreviewed, rolling out r189338.
3518         https://bugs.webkit.org/show_bug.cgi?id=148785
3519
3520         Caused tons of crashes (Requested by cdumez on #webkit).
3521
3522         Reverted changeset:
3523
3524         "Web Inspector: InspectorController should support multiple
3525         frontend channels"
3526         https://bugs.webkit.org/show_bug.cgi?id=148538
3527         http://trac.webkit.org/changeset/189338
3528
3529 2015-09-03  Brian Burg  <bburg@apple.com>
3530
3531         Web Inspector: InspectorController should support multiple frontend channels
3532         https://bugs.webkit.org/show_bug.cgi?id=148538
3533
3534         Reviewed by Joseph Pecoraro.
3535
3536         InspectorClients must explicitly disconnect their frontend channel(s) from the
3537         inspected page's InspectorController.
3538
3539         To make this possible, DumpRenderTree should not destroy non-primary views until
3540         it has tried to close any abandoned Web Inspector instances. Performing teardown
3541         in the reverse order prevents disconnection of the frontend channel because that
3542         prematurely destroys the inspector frontend client.
3543
3544         * DumpRenderTree/mac/DumpRenderTree.mm:
3545         (runTest):
3546         * DumpRenderTree/win/DumpRenderTree.cpp:
3547         (runTest):
3548
3549 2015-09-03  Timothy Hatcher  <timothy@apple.com>
3550
3551         Update WebKit nightly icon to be more like Safari
3552         https://bugs.webkit.org/show_bug.cgi?id=148768
3553
3554         Reviewed by Joseph Pecoraro.
3555
3556         * WebKitLauncher/webkit.icns:
3557
3558 2015-09-03  Geoffrey Garen  <ggaren@apple.com>
3559
3560         JavaScriptCore should have some ES6 conformance tests
3561         https://bugs.webkit.org/show_bug.cgi?id=148771
3562
3563         Reviewed by Chris Dumez.
3564
3565         * Scripts/run-javascriptcore-tests:
3566         (runJSCStressTests): Added es6 as a test suite.
3567
3568         * Scripts/run-jsc-stress-tests: Added es6 as a test suite.
3569
3570         Some of these tests currently fail, so I also added a way to expect
3571         failure for now. We'll migrate failing tests to expected passes as we
3572         fix them.
3573
3574 2015-09-03  Tim Horton  <timothy_horton@apple.com>
3575
3576         Add a test for swipe-start hysteresis