Don't treat NSLocalizedDescriptionKey and NSLocalizedRecoverySuggestionErrorKey as...
[WebKit-https.git] / Tools / ChangeLog
1 2013-08-24  Anders Carlsson  <andersca@apple.com>
2
3         Don't treat NSLocalizedDescriptionKey and NSLocalizedRecoverySuggestionErrorKey as NSLocalized macros
4         https://bugs.webkit.org/show_bug.cgi?id=120249
5
6         Reviewed by Andreas Kling.
7
8         * Scripts/extract-localizable-strings:
9
10 2013-08-24  Carlos Garcia Campos  <cgarcia@igalia.com>
11
12         [GTK] Expose WebKitFrame in WebKit2GTK+ web extensions API
13         https://bugs.webkit.org/show_bug.cgi?id=119743
14
15         Reviewed by Anders Carlsson.
16
17         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
18         (WTR::InjectedBundlePage::InjectedBundlePage): Add
19         willDestroyFrame.
20
21 2013-08-23  Thiago de Barros Lacerda  <thiago.lacerda@openbossa.org>
22
23         Move TestWebKitAPI_LIBRARIES before platform specific cmake include
24         https://bugs.webkit.org/show_bug.cgi?id=120220
25
26         Reviewed by Martin Robinson.
27
28         * TestWebKitAPI/CMakeLists.txt:
29
30 2013-08-22  Filip Pizlo  <fpizlo@apple.com>
31
32         build-jsc --ftl-jit should work
33         https://bugs.webkit.org/show_bug.cgi?id=120194
34
35         Reviewed by Oliver Hunt.
36
37         * Scripts/build-jsc: Need to pass the feature flag to xcodebuild
38
39 2013-08-23  Commit Queue  <commit-queue@webkit.org>
40
41         Unreviewed, rolling out r153534.
42         http://trac.webkit.org/changeset/153534
43         https://bugs.webkit.org/show_bug.cgi?id=120216
44
45         Too many tests failing just WinEWS bots (Requested by rfong on
46         #webkit).
47
48         * Scripts/webkitpy/common/config/ews.json:
49
50 2013-08-23  Alex Christensen  <alex.christensen@flexsim.com>
51
52         Unreviewed.  Added my webkit.org email address.
53
54         * Scripts/webkitpy/common/config/contributors.json:
55
56 2013-08-23  Peter Gal  <galpeter@inf.u-szeged.hu>
57
58         [WTR] Should dump as text when the mimetype is text/plain
59         https://bugs.webkit.org/show_bug.cgi?id=118306
60
61         Reviewed by Christophe Dumez.
62
63         Check for the text/plain mimetype and if true then mark it as
64         text dump.
65
66         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
67         (WTR::InjectedBundlePage::dump):
68
69 2013-08-22  Filip Pizlo  <fpizlo@apple.com>
70
71         Update LLVM binary drops and scripts to the latest version from SVN
72         https://bugs.webkit.org/show_bug.cgi?id=120184
73
74         Reviewed by Mark Hahnenberg.
75
76         * ReducedFTL/build.sh:
77         * Scripts/configure-llvm: Added.
78         * Scripts/copy-webkitlibraries-to-product-directory:
79         * Scripts/export-llvm-build:
80
81 2013-08-22  Andy Estes  <aestes@apple.com>
82
83         <https://webkit.org/b/120180> Fix issues with OTHER_LDFLAGS in various .xcconfig files
84
85         Reviewed by David Kilzer.
86
87         * TestWebKitAPI/Configurations/Base.xcconfig: Removed the definition of
88         OTHER_CPLUSPLUSFLAGS since -ftemplate-depth=256 is already set in
89         DebugRelease.xcconfig and TestWebKitAPI isn't built in Production.
90
91 2013-08-22  Ryosuke Niwa  <rniwa@webkit.org>
92
93         NRWT: Add the ability to upload test results to new test results server
94         https://bugs.webkit.org/show_bug.cgi?id=120146
95
96         Reviewed by Andreas Kling.
97         
98         For the upcoming replacement for webkit-test-results.appspot.com, new-run-webkit-tests needs to use a new JSON format
99         that contains the full summary of the test run including information about passed tests.
100
101         Add this ability to NRWT so that I can start testing this feature. This patch adds the following optoins to NRWT:
102         --build-slave
103         --got-revision
104         --results-server-host
105
106         The last option is somewhat ambigious with --test-results-server but we're intending to deprecate the old server
107         so we should be able to delete --test-results-server in time.
108
109         * Scripts/webkitpy/layout_tests/controllers/manager.py:
110         (Manager.run):
111         (Manager._upload_json_files):
112         (Manager):
113         (Manager.upload_results):
114         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
115         (summarize_results):
116         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
117         (summarized_results):
118         (SummarizedResultsTest.test_summarized_results_wontfix):
119         (SummarizedResultsTest):
120         (SummarizedResultsTest.test_summarized_results_include_passes):
121         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
122         (parse_args):
123
124 2013-08-22  Ryosuke Niwa  <rniwa@webkit.org>
125
126         WKR build fix. Somehow tool.bugs.quips() doesn't work in WKR so work around that.
127
128         * Scripts/webkitpy/tool/bot/irc_command.py:
129         (Hi.execute):
130
131 2013-08-22  Allan Sandfeld Jensen  <allan.jensen@digia.com>
132
133         [Qt] DRT bug revealed/caused by r154300
134         https://bugs.webkit.org/show_bug.cgi?id=120151
135
136         Reviewed by Simon Hausmann.
137
138         Since QtInstance had an implementation of getOwnPropertySlot and not getOwnPropertyDescriptor,
139         the behavior of getOwnPropertyDescriptor changed when it got implemented using getOwnPropertySlot
140         in r154300.
141
142         DRT relied on getOwnPropertyDescriptor returning undefined for JS set properties to distinguish
143         between native Qt methods and JSC bound methods. This patch changes the check to see if the 
144         property is writable since the Qt methods are ReadOnly.
145
146         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
147         (DumpRenderTree::initJSObjects):
148
149 2013-08-21  Joseph Pecoraro  <pecoraro@apple.com>
150
151         <https://webkit.org/b/120134> [Tools] lldb_webkit.py helpers is incorrectly printing 8bit Strings
152
153         Reviewed by Benjamin Poulain.
154
155         WTFString moved the is8bit bit by one in r152201.
156
157         * lldb/lldb_webkit.py:
158         (WTFStringImplProvider.is_8bit):
159
160 2013-08-21  Tim Horton  <timothy_horton@apple.com>
161
162         Revert http://trac.webkit.org/changeset/154022, as it failed to update
163         a variety of scripts that depended on the old format.
164
165         See https://bugs.webkit.org/show_bug.cgi?id=120131 for one such example.
166
167         * Scripts/prepare-ChangeLog:
168         (main):
169         (generateNewChangeLogs):
170
171 2013-08-21  Brent Fulgham  <bfulgham@apple.com>
172
173         [Windows] Unreviewed gardening: WebInspector should always be enabled for WinLauncher.
174
175         * WinLauncher/WinLauncher.cpp:
176         (setToDefaultPreferences): Activate Developer Extras on Release (as well as Debug) builds.
177
178 2013-08-21  Zan Dobersek  <zdobersek@igalia.com>
179
180         <https://webkit.org/b/120116> [GTK] Fix a typo in ActivateFontsGtk.cpp
181
182         Reviewed by Andreas Kling.
183
184         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
185         (WTR::initializeFontConfigSetting): Fix a typo - inititialize -> initialize.
186         (WTR::activateFonts): Ditto.
187
188 2013-08-21  Brian Holt  <brian.holt@samsung.com>
189
190         [GTK] Suppress irrelevant or known leaks for Valgrind
191         https://bugs.webkit.org/show_bug.cgi?id=119448
192
193         Reviewed by Martin Robinson.
194
195         Add a suppressions file to suppress known leaks for Valgrind.
196         Valgrind also takes longer when using suppressions and
197         times out unless the driver timeout is increased.
198
199         * Scripts/valgrind/suppressions.txt: Added.
200         * Scripts/webkitpy/port/gtk.py:
201         (GtkPort.driver_stop_timeout):
202         (GtkPort.setup_environ_for_server):
203
204 2013-08-20  Alex Christensen  <achristensen@apple.com>
205
206         [Windows] Linking fix for Win64.
207
208         Rubberstamped by Brent Fulgham.
209
210         * win/DLLLauncher/DLLLauncherMain.cpp:
211         (wWinMain): Corrected 64-bit linker symbol for dllLauncherEntryPoint.
212
213 2013-08-20  Brent Fulgham  <bfulgham@apple.com>
214
215         <https://webkit.org/b/120090> Report better error messages from WinLauncher/DRT
216
217         Reviewed by Tim Horton.
218
219         * win/DLLLauncher/DLLLauncherMain.cpp:
220         (getLastErrorString): New method to convert GetLastError to text.
221         (wWinMain): Use new error formatter to provide useful diagnostic text to user.
222
223 2013-08-19  Gustavo Noronha Silva  <gns@gnome.org>
224
225         <https://webkit.org/b/120048> [GTK] Add stubs for APIs that went missing in the DOM bindings
226
227         Reviewed by Martin Robinson.
228
229         * Scripts/webkitpy/style/checker.py: add the bindings custom implementation files to be exempt
230         from naming/enum_casing rules, since it needs to provide GObject-style APIs.
231
232 2013-08-20  Anton Obzhirov  <a.obzhirov@samsung.com>
233
234         <https://webkit.org/b/120009> [GTK] Stop button should be added to MiniBrowser
235
236         Reviewed by Martin Robinson.
237
238         Added stop button in MiniBrowser
239
240         * MiniBrowser/gtk/BrowserWindow.c:
241         (reloadOrStopCallback): Callback to handle stop or reload button click.
242         (webViewLoadProgressChanged): Update reload or stop button icon.
243         (browser_window_init): Save button pointer for further icon updates.
244
245 2013-08-20  Simon Pena  <simon.pena@samsung.com>
246
247         <https://webkit.org/b/117584> [GTK][WK1] http/tests/loading/unfinished-load-back-to-cached-page-callbacks.html is failing
248
249         Reviewed by Alexey Proskuryakov.
250
251         Update DumpRenderTree to handle the WEBKIT_LOAD_FAILED status,
252         printing didFailLoadWithError.
253
254         Behave like other ports, and handle WEBKIT_LOAD_FAILED status in
255         DumpRenderTree, printing didFailLoadWithError.
256
257         * DumpRenderTree/gtk/DumpRenderTree.cpp:
258         (webFrameLoadStatusNotified):
259
260 2013-08-19  Ryosuke Niwa  <rniwa@webkit.org>
261
262         <https://webkit.org/b/120049> Delete code for Snow Leopard
263
264         Reviewed by Benjamin Poulain.
265
266         * DumpRenderTree/mac/CheckedMalloc.cpp:
267         (protectionOfRegion):
268         (makeLargeMallocFailSilently):
269         * DumpRenderTree/mac/DumpRenderTree.mm:
270         (resetDefaultsToConsistentValues):
271         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
272         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
273         * DumpRenderTree/mac/FrameLoadDelegate.mm:
274         (testPathFromURL):
275         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
276         * DumpRenderTree/mac/LayoutTestHelper.m:
277         * DumpRenderTree/mac/TestRunnerMac.mm:
278         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
279         (WTR::InjectedBundle::platformInitialize):
280         * WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
281         (WTR::testPathFromURL):
282         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
283
284 2013-08-19  Alexey Proskuryakov  <ap@apple.com>
285
286         https://bugs.webkit.org/show_bug.cgi?id=119915
287         REGRESSION(r154144): ASSERTION FAILED: m_history->provisionalItem() == m_requestedHistoryItem.get()
288
289         Reviewed by Darin Adler.
290
291         The issue was that we ended up having no CFNetwork cache in the testing session due
292         to an incorrect cache model. There is a number of things not implemented when it
293         comes to dynamically changing cache model as attempted by WebKitTestRunner, but
294         the easiest way to get this going is to initialize it to correct value upfront.
295
296         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
297
298 2013-08-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
299
300         REGRESSION(r154275): webkitpy tests failing
301         https://bugs.webkit.org/show_bug.cgi?id=120010
302
303         Reviewed by Jocelyn Turcotte.
304
305         Update unit-tests to tests the new search-path structure,
306         but reverting the architecture search path addition.
307
308         * Scripts/webkitpy/port/qt.py:
309         (QtPort):
310         (QtPort.__init__):
311         (QtPort._generate_all_test_configurations):
312         (QtPort.qt_architecture):
313         * Scripts/webkitpy/port/qt_unittest.py:
314         (QtPortTest):
315         (QtPortTest._assert_search_path):
316         (QtPortTest._assert_expectations_files):
317         (QtPortTest._qt_version):
318
319 2013-08-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
320
321         [Qt] Keep the qt-5.0-wk2 search path until the expectation migration is completed
322
323         Unreviewed meta gardening.
324
325         We need to keep using the qt-5.0-wk2 path until it is fully migrated.
326
327         * Scripts/webkitpy/port/qt.py:
328         (QtPort._search_paths):
329
330 2013-08-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
331
332         Restructure Qt test expectations
333
334         Unreviewed meta gardening.
335
336         Removed 5.0 name from WK1 and WK2 results and made it possible to set
337         expectations by both Qt version and mayor architectures.
338
339         * Scripts/webkitpy/port/qt.py:
340         (QtPort._wk2_port_name):
341         (QtPort.__init__):
342         (QtPort.qt_version):
343         (QtPort.architecture):
344         (QtPort._search_paths):
345         (QtPort._port_specific_expectations_files):
346
347 2013-08-16  Brent Fulgham  <bfulgham@apple.com>
348
349         [Windows] DRT is not using the same preferences as the Mac build.
350         https://bugs.webkit.org/show_bug.cgi?id=119822
351
352         Reviewed by Darin Adler.
353
354         * DumpRenderTree/win/DumpRenderTree.cpp:
355         (runTest): Process Windows message queue using CFRunLoop to allow
356         dispatch routines to run properly.
357         (dllLauncherEntryPoint): Wrap CG-specific setup code in a macro
358         to prevent problems on WinCairo port.
359
360 2013-08-16  Brent Fulgham  <bfulgham@apple.com>
361
362         [Windows] URL printing code in DRT doesn't match WTR or Mac DRT
363         https://bugs.webkit.org/show_bug.cgi?id=119583
364
365         Reviewed by Alexey Proskuryakov.
366
367         * DumpRenderTree/win/DumpRenderTree.cpp:
368         (urlSuitableForTestResult): Revise URL output to match Mac DRT by emiting last path
369         component if the URL does not contain the expected base URL.
370
371 2013-08-16  Pratik Solanki  <psolanki@apple.com>
372
373         <https://webkit.org/b/119852> Frame::scriptController() should return a reference
374
375         Reviewed by Andreas Kling.
376
377         m_script is never NULL so we can just return a reference. Also remove some pointless null
378         checks as a result of doing this.
379
380         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
381         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
382
383 2013-08-15  Alexey Proskuryakov  <ap@apple.com>
384
385         [WK2] NetworkProcess should use a temporary storage session for test
386         https://bugs.webkit.org/show_bug.cgi?id=119855
387
388         Reviewed by Darin Adler.
389
390         Use a new API that takes care of both WebProcess and NetworkProcess.
391
392         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
393         (WTR::InjectedBundle::initialize):
394         * WebKitTestRunner/TestController.cpp:
395         (WTR::TestController::initialize):
396
397 2013-08-15  Bem Jones-Bey  <bjonesbe@adobe.com>
398
399         <https://webkit.org/b/119850> Speed up test importing by doing all the regex matching in a single pass
400
401         Reviewed by Dirk Pranke.
402
403         This is a port from Blink of
404         https://src.chromium.org/viewvc/blink?revision=155647&view=revision
405         originally by Dirk Pranke.
406
407         From the original commit:
408
409         This gives something like a 15x speedup over compiling and matching
410         one property at a time and doing multiple passes over the file.
411
412         * Scripts/webkitpy/w3c/test_converter.py:
413         (W3CTestConverter.__init__):
414         (W3CTestConverter.convert_prefixed_properties):
415         (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
416
417 2013-08-15  Dan Bernstein  <mitz@apple.com>
418
419         <https://webkit.org/b/119856> Improve extract-localizable-strings messages
420
421         Reviewed by Darin Adler.
422
423         * Scripts/extract-localizable-strings: When the strings file disagrees with the source code,
424         added a message that points to the source code. Removed some unnecessary repetition of what
425         is already in the file.
426
427 2013-08-15  Andy Estes  <aestes@apple.com>
428
429         <https://webkit.org/b/119853> REGRESSION (r139343): WebKit crashes when canceling a load inside webView:resource:didFinishLoadingFromDataSource:
430
431         Reviewed by Brady Eidson.
432
433         Wrote an API test that verifies -[WebView stopLoading:] can be called
434         inside webView:resource:didFinishLoadingFromDataSource: without crashing.
435
436         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
437         * TestWebKitAPI/Tests/mac/StopLoadingFromDidFinishLoading.mm: Added.
438         (-[StopLoadingFromDidFinishLoadingDelegate webView:resource:didFinishLoadingFromDataSource:]):
439         (TestWebKitAPI::TEST):
440
441 2013-08-15  Alexey Proskuryakov  <ap@apple.com>
442
443         Adding Myles Maxfield to contributors.json.
444
445         Oops, wrong section, fixing.
446
447         * Scripts/webkitpy/common/config/contributors.json:
448
449 2013-08-15  Alexey Proskuryakov  <ap@apple.com>
450
451         Adding Myles Maxfield to contributors.json.
452
453         * Scripts/webkitpy/common/config/contributors.json:
454
455 2013-08-15  Allan Sandfeld Jensen  <allan.jensen@digia.com>
456
457         [Qt] Do not check specifically for version 5.0
458         https://bugs.webkit.org/show_bug.cgi?id=119846
459
460         Reviewed by Jocelyn Turcotte.
461
462         For Qt 5.x we should always use both wk1 and wk2 basepath results.
463
464         * Scripts/webkitpy/port/qt.py:
465         (QtPort._search_paths):
466
467 2013-08-15  Simon Pena  <simon.pena@samsung.com>
468
469         <https://webkit.org/b/119584> [Gtk] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT
470
471         Reviewed by Gustavo Noronha Silva.
472
473         Following a similar approach as in r153977, return a path string
474         that is relative to main frame URL or just file name if the
475         resource is not in the same directory subtree, and replace empty
476         strings with "(null)".
477
478         Update pathFromSoupURI so it behaves more closely to the other
479         ports, and remove the unused code after we no longer print
480         <unknown> in certain cases. Also move
481         soupURIToStringPreservingPassword to DumpRenderTreeGtk so it can
482         be used both in TestRunnerGtk and in DumpRenderTree.
483
484         * DumpRenderTree/gtk/DumpRenderTree.cpp:
485         (soupURIToStringPreservingPassword): Moved from TestRunnerGtk so
486         we can print Soup URIs with the password, since soup_uri_to_string
487         doesn't preserve them.
488         (pathFromSoupURI): Updated following EFL implementation in
489         r153977, and return a WTFString instead of a CString.
490         (convertSoupMessageToURLPath): Return "(null)" instead of empty
491         strings, and handle the new return type of pathFromSoupURI.
492         (convertWebResourceToURLPath): Use a GOwnPtr to hold the Soup URI
493         reference, and handle the new return type of pathFromSoupURI.
494         (descriptionSuitableForTestResult): Remove unused code.
495         (didFinishLoading): Use convertResourceToURLPath.
496         (didFailLoadingWithError): Use convertResourceToURLPath.
497         (authenticationCallback): Display the URL of the authentication
498         challenge.
499         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Declare
500         soupURIToStringPreservingPassword.
501         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove
502         soupURIToStringPreservingPassword.
503
504 2013-08-14  Tim Horton  <timothy_horton@apple.com>
505
506         Un-inline dataLog dumpers for IntSize and IntPoint
507         https://bugs.webkit.org/show_bug.cgi?id=119697
508
509         Reviewed by Sam Weinig.
510
511         * TestWebKitAPI/GNUmakefile.am:
512
513 2013-08-14  Ryosuke Niwa  <rniwa@webkit.org>
514
515         Flakiness dashboard build fix.
516
517         * TestResultServer/static-dashboards/flakiness_dashboard.js:
518         (processTestRunsForBuilder):
519
520 2013-08-14  Martin Robinson  <mrobinson@igalia.com>
521
522         [GTK] [CMake] Add support for building TestWebKitAPI
523         https://bugs.webkit.org/show_bug.cgi?id=116987
524
525         Reviewed by Philippe Normand.
526
527         * TestWebKitAPI/CMakeLists.txt: Move the library listings to before the inclusion of the
528         platform-specific file, so that GTK+ can override them.
529         * TestWebKitAPI/PlatformGTK.cmake: Added.
530
531 2013-08-14  Brent Fulgham  <bfulgham@apple.com>
532
533         [Windows] Simplify Setting WebKit Debugging Options in WinLauncher
534         https://bugs.webkit.org/show_bug.cgi?id=119775
535
536         This bug updates the WinLauncher program with a few useful menu
537         options to toggle certain debugging and development features of
538         WebKit.
539
540         Reviewed by Tim Horton.
541
542         * WinLauncher/WinLauncher.cpp:
543         (dllLauncherEntryPoint): Clean up preference objects on exit.
544         (ToggleMenuItem): New function.
545         (LaunchInspector): New function.
546         (WndProc): Add handler for new menu items. Also properly terminate
547         CFRunLoop operation on program exit.
548         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add new
549         menu items.
550         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Add
551         resource folder to search path.
552         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Update
553         for new menu items.
554
555 2013-08-14  Ryosuke Niwa  <rniwa@webkit.org>
556
557         Add a hyperlink from build.webkit.org to the flakiness dashboard.
558
559         Rubbers-tamped by Simon Fraser.
560
561         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
562
563 2013-08-14  Benjamin Dupont   <bdupont@nds.com>
564
565         [Qt] Activate visibility API layout tests
566         https://bugs.webkit.org/show_bug.cgi?id=119790
567
568         Reviewed by Allan Sandfeld Jensen.
569
570         * DumpRenderTree/qt/TestRunnerQt.cpp:
571         (TestRunner::resetPageVisibility):
572         (TestRunner::setPageVisibility):
573
574 2013-08-13  Xabier Rodriguez Calvar  <calvaris@igalia.com>
575
576         [GTK] WK does not link properly against libxslt
577         https://bugs.webkit.org/show_bug.cgi?id=119688
578
579         Reviewed by Gustavo Noronha Silva.
580
581         * MiniBrowser/gtk/GNUmakefile.am: Added LIBXSLT_LIBS to
582         MiniBrowser.
583         * WebKitTestRunner/GNUmakefile.am: Added LIBXSLT_LIBS to WTR.
584
585 2013-08-13  Alexey Proskuryakov  <ap@apple.com>
586
587         [Mac] fast/dom/attr-style-too-lazy.html is flaky
588         https://bugs.webkit.org/show_bug.cgi?id=119763
589
590         Reviewed by Darin Adler.
591
592         * DumpRenderTree/mac/UIDelegate.mm:
593         (-[UIDelegate webView:setStatusText:]): Don't dump anything when not running
594         a test, it would just semi-randomly leak to the next one.
595         (-[UIDelegate webView:didPressMissingPluginButton:]): Added same check here, just
596         for good measure.
597
598 2013-08-13  Tim Horton  <timothy_horton@apple.com>
599
600         [mac] Give MiniBrowser a reasonable bundle identifier
601         https://bugs.webkit.org/show_bug.cgi?id=119773
602
603         Rubber-stamped by Simon Fraser.
604
605         Give MiniBrowser the bundle identifier org.webkit.MiniBrowser.
606
607         * MiniBrowser/mac/Info.plist:
608         * MiniBrowser/mac/WebBundle/Info.plist:
609
610 2013-08-13  Dean Jackson  <dino@apple.com>
611
612         <https://webkit.org/b/119766> Make bug url more human friendly in ChangeLog
613
614         Reviewed by Mark Rowe.
615
616         Have prepare-ChangeLog produce webkit.org/b/id style
617         URLs rather than exposing the inner workings of our
618         cgi. I was going to use the term "Future Proofing"
619         but that seems excessive :)
620
621         * Scripts/prepare-ChangeLog:
622         (main): Generate a more human readable form.
623         (generateNewChangeLogs): Use it when printing out the ChangeLog entry.
624
625 2013-08-13  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
626
627         [EFL][DRT] Simplify call to reverseFind()
628         https://bugs.webkit.org/show_bug.cgi?id=119746
629
630         Reviewed by Christophe Dumez.
631
632         Follow-up to r153977.
633
634         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
635         (pathSuitableForTestResult): Instead of defining a static variable
636         that's only used in a single place, pass '/' to reverseFind() directly.
637
638 2013-08-13  Alberto Garcia  <berto@igalia.com>
639
640         [GTK] Closing inspector window crashes wk
641         https://bugs.webkit.org/show_bug.cgi?id=110865
642
643         Reviewed by Carlos Garcia Campos.
644
645         Disconnect all signal handlers if the inspector window is
646         destroyed.
647
648         * GtkLauncher/LauncherInspectorWindow.c:
649         (inspectorWindowDestroyed):
650         (launcherInspectorWindowNew):
651
652 2013-08-12  Dan Bernstein  <mitz@apple.com>
653
654         extract-localizable-strings output is not suited for parsing by Xcode
655         https://bugs.webkit.org/show_bug.cgi?id=119728
656
657         Reviewed by Darin Adler.
658
659         Added spaces where needed after “path:line:” to allow Xcode to recognize the file reference,
660         removed “ERROR” since messages that refer to a line in a file are shown as error by default,
661         added “warning: ” in messages that aren’t errors (i.e. don’t prevent the script from exiting
662         with 0).
663
664         * Scripts/extract-localizable-strings:
665
666 2013-08-12  Ryuan Choi  <ryuan.choi@samsung.com>
667
668         [EFL][WK1] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT
669         https://bugs.webkit.org/show_bug.cgi?id=119585
670
671         Reviewed by Gyuyoung Kim.
672
673         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
674         (pathSuitableForTestResult):
675         Return path string that's relative to main frame URL, or just file name if
676         the resource is not in the same directory subtree.
677         Referenced WebKitTestRunner code in r153852.
678         (descriptionSuitableForTestResult):
679         (DumpRenderTreeChrome::onFrameRedirectRequested):
680         (DumpRenderTreeChrome::onNewResourceRequest): Followed changes of r153903.
681
682 2013-08-12  Dan Bernstein  <mitz@apple.com>
683
684         extract-localizable-strings doesn't know how to verify an existing strings file
685         https://bugs.webkit.org/show_bug.cgi?id=119704
686
687         Reviewed by Darin Adler.
688
689         * Scripts/extract-localizable-strings: Added an --exceptions option for specifying the
690         exceptions file, changing the way “no exceptions file” is expressed from passing “-” as the
691         exceptions file name to omitting the --exceptions option. Added a --skip option, changing
692         the way directories to skip are specified from prefixing the directory with a “-” to
693         specifying it with --skip.
694         Finally, added a --verify option. When specified, the strings file is not written to, but
695         instead read in and checked for consistency with the comments, keys and values derived from
696         the source files and the exceptions file. Missing keys, unused keys, mismatching values and
697         mismatching comments are reported as errors.
698         * Scripts/update-webkit-localizable-strings: Updated for the new way of specifying
699         directories to skip and no exceptions file.
700
701 2013-08-12  Alexey Proskuryakov  <ap@apple.com>
702
703         http/tests/security/sandboxed-iframe-invalid.html is flaky on Mac
704         https://bugs.webkit.org/show_bug.cgi?id=85522
705
706         Reviewed by Andy Estes.
707
708         * DumpRenderTree/mac/UIDelegate.mm:
709         (-[UIDelegate webView:addMessageToConsole:withSource:]): Don't print console messages
710         when already done with a test. We already had this check in all UI delegate functions,
711         except for -webView:addMessageToConsole:withSource: somehow.
712
713 2013-08-12  Alexey Proskuryakov  <ap@apple.com>
714
715         https://bugs.webkit.org/show_bug.cgi?id=119693
716         [Mac] security/contentSecurityPolicy/connect-src-websocket-blocked.html is flaky
717         because of connect-src-websocket-allowed.html
718
719         Reviewed by Darin Adler.
720
721         Starting a load of about:blank and immediately stopping it cancels outstanding
722         resource loads, but the page has to transition to committed state to have timers
723         or WebSockets stopped too.
724
725         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Use a synchronous load to
726         ensure that transition to committed state happens before we start the next test.
727
728 2013-08-12  Beth Dakin  <bdakin@apple.com>
729
730         The LayoutMilestones didLayout callback should only fire for the main frame
731         https://bugs.webkit.org/show_bug.cgi?id=119457
732
733         Reviewed by Sam Weinig.
734
735         Now that the didLayout callback only fires for the main frame, we want to make 
736         sure it will fire even when all of the content is in a subframe.
737
738         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
739         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp: Added.
740         (TestWebKitAPI::didLayout):
741         (TestWebKitAPI::TEST):
742         * TestWebKitAPI/Tests/WebKit2/all-content-in-one-iframe.html: Added.
743
744 2013-08-12  Beth Dakin  <bdakin@apple.com>
745
746         Remove didNewFirstVisuallyNonEmptyLayout from WebKit2
747         https://bugs.webkit.org/show_bug.cgi?id=119658
748
749         Reviewed by Darin Adler.
750
751         * MiniBrowser/mac/WK2BrowserWindowController.m:
752         (-[WK2BrowserWindowController awakeFromNib]):
753         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
754         (WTR::InjectedBundlePage::InjectedBundlePage):
755         * WebKitTestRunner/TestController.cpp:
756         (WTR::TestController::createWebViewWithOptions):
757
758 2013-08-12  Seokju Kwon  <seokju@webkit.org>
759
760         Remove glu's libtest rule from checker.py
761         https://bugs.webkit.org/show_bug.cgi?id=119674
762
763         Reviewed by Darin Adler.
764
765         * Scripts/webkitpy/style/checker.py: It is no longer used after r148032.
766
767 2013-08-11  ChangSeok Oh  <changseok.oh@collabora.com>
768
769         Unreviewed. Change my primary mail address.
770
771         * Scripts/webkitpy/common/config/contributors.json:
772
773 2013-08-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
774
775         [GTK] Misses mod_ssl and php in the list of packages required for tests for yum
776         https://bugs.webkit.org/show_bug.cgi?id=115751
777
778         Reviewed by Martin Robinson.
779
780         * gtk/install-dependencies: add mod_ssl and php to the packages installed for tests
781         with yum.
782
783 2013-08-09  Beth Dakin  <bdakin@apple.com>
784
785         AX: Not able to use arrow keys to read text in a WK2 app
786         https://bugs.webkit.org/show_bug.cgi?id=119605
787         -and corresponding-
788         <rdar://problem/14281275>
789
790         Reviewed by Darin Adler.
791
792         New test verifies that didNotHandleKeyEvent will be called when there is nothing 
793         to scroll. 
794         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
795         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp: Added.
796         (TestWebKitAPI::didFinishLoadForFrame):
797         (TestWebKitAPI::didNotHandleKeyEventCallback):
798         (TestWebKitAPI::TEST):
799
800 2013-08-09  Christophe Dumez  <ch.dumez@sisa.samsung.com>
801
802         Add support for KeyboardEvent.location attribute
803         https://bugs.webkit.org/show_bug.cgi?id=119326
804
805         Reviewed by Benjamin Poulain.
806
807         Rename the deprecated 'keyLocation' to 'location' in Mac's DRT code.
808
809         * DumpRenderTree/mac/EventSendingController.mm:
810         (-[EventSendingController keyDown:withModifiers:withLocation:]):
811         (-[EventSendingController keyDownWrapper:withModifiers:withLocation:]):
812         (-[EventSendingController scheduleAsynchronousKeyDown:withModifiers:withLocation:]):
813         (-[EventSendingController handleEvent:]):
814         (-[EventSendingController fireKeyboardEventsToElement:]):
815
816 2013-08-09  Alexey Proskuryakov  <ap@apple.com>
817
818         <unknown> is often dumped instead of path in test output
819         https://bugs.webkit.org/show_bug.cgi?id=119590
820
821         Reviewed by Anders Carlsson.
822
823         There were two reasons for <unknown>:
824         1. When delegate logging is enabled via a testRunner call, that obviously happens
825         after main resource load starts, so we don't record its URL.
826         2. Authentication delegate logging relied on URL recording, but it's only turned on
827         when enabling resource loading delegate logging, not auth one.
828
829         URL recording was made conditional in <http://trac.webkit.org/r19316>, which was
830         landed without posted rationale and unreviewed. Just undoing that change now.
831
832         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
833         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
834         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
835         (WTR::InjectedBundlePage::didInitiateLoadForResource):
836
837 2013-08-08  Alex Christensen  <achristensen@apple.com>
838
839         Windows build fixes.
840
841         Rubberstamped by Brent Fulgham.
842
843         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
844         Removed /SAFESEH link option which doesn't work with x64.
845
846 2013-08-08  Daniel Bates  <dabates@apple.com>
847
848         Add iOS support to run-javascriptcore-tests
849         https://bugs.webkit.org/show_bug.cgi?id=119602
850
851         Reviewed by Joseph Pecoraro.
852
853         Make run-javascriptcore-tests work for iOS WebKit.
854
855         * Scripts/run-javascriptcore-tests:
856
857 2013-08-08  Alexey Proskuryakov  <ap@apple.com>
858
859         [WK2] loader/go-back-cached-main-resource.html fails
860         https://bugs.webkit.org/show_bug.cgi?id=116491
861
862         Reviewed by Tim Horton.
863
864         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
865         * DumpRenderTree/gtk/DumpRenderTree.cpp:
866         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
867         * DumpRenderTree/win/DumpRenderTree.cpp:
868         Added FIXMEs about making path printing normalization more compatible.
869
870         * DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[NSURL _drt_descriptionSuitableForTestResult]):
871         Return last path component in cases where we used to return a full path, which is
872         never desirable. Added a null check to basePath to prevent potentially getting
873         an Objective C exception.
874
875         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
876         (WTR::pathSuitableForTestResult): Changed to use path for main test window, not
877         for a currently loading one (which is different for tests that use multiple windows).
878         Changed to return "(null)" for empty URLs to match WK1 output. Changed to return
879         last path component as last fallback.
880         (WTR::dumpRequestDescriptionSuitableForTestResult): We no longer need to pass main
881         frame URL here, and it was potentially a wrong frame.
882         (WTR::dumpResponseDescriptionSuitableForTestResult): Ditto.
883         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Ditto.
884         (WTR::InjectedBundlePage::didInitiateLoadForResource): Ditto.
885         (WTR::InjectedBundlePage::willSendRequestForFrame): Ditto.
886         (WTR::InjectedBundlePage::didReceiveResponseForResource): Ditto.
887
888 2013-08-08  Alex Christensen  <achristensen@apple.com>
889
890         WTR::pathSuitableForTestResult should behave the same as _drt_descriptionSuitableForTestResult so we can unskip tests.
891         https://bugs.webkit.org/show_bug.cgi?id=116125
892
893         Reviewed by Tim Horton. Tweaked and re-landed by Alexey Proskuryakov.
894
895         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
896         (WTR::pathSuitableForTestResult):
897         Changed string operations to match _drt_descriptionSuitableForTestResult.
898         (WTR::dumpRequestDescriptionSuitableForTestResult):
899         (WTR::dumpResponseDescriptionSuitableForTestResult):
900         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
901         (WTR::InjectedBundlePage::didInitiateLoadForResource):
902         (WTR::InjectedBundlePage::willSendRequestForFrame):
903         (WTR::InjectedBundlePage::didReceiveResponseForResource):
904         Pass the main frame's URL to pathSuitableForTestResult.
905         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
906         Added WKBundlePageRef to willPerformClientRedirectForFrame.
907
908 2013-08-07  Simon Fraser  <simon.fraser@apple.com>
909
910         Allow the DumpRenderTree runloop to be idle while waiting for a test to complete
911         https://bugs.webkit.org/show_bug.cgi?id=119317
912
913         Reviewed by Tim Horton.
914         
915         The change in r55200 made DumpRenderTree spin a busy-loop while waiting for
916         the test to complete, which is not power friendly. Although DRT instances
917         are generally busy anyway, not sitting in a busy loop should free up some CPU
918         cycles for other instances of DRT.
919         
920         Editing tests continue to pass. All Java tests are skipped and were not
921         tested, but when run fail similarly with and without the patch.
922
923         * DumpRenderTree/mac/DumpRenderTree.mm:
924         (dump):
925         (runTest):
926
927 2013-08-07  Daniel Bates  <dabates@apple.com>
928
929         Clean up: Simplifying the printing of the command line arguments passed to jsDriver.pl
930         <https://bugs.webkit.org/show_bug.cgi?id=119558>
931
932         Reviewed by Martin Robinson.
933
934         Currently we build the command line to execute jsDriver.pl twice so as to both
935         print it to standard output and actually execute it. We should only build up
936         this command line once. Moreover, we should print to standard output the actual
937         command line that we are going to use including the GTK- and EFL-specific call
938         to /Tools/jhbuild/jhbuild-wrapper.
939
940         * Scripts/run-javascriptcore-tests:
941
942 2013-08-07  Mario Sanchez Prada  <mario.prada@samsung.com>
943
944         [EFL] REGRESSION after r153432: some accessibility tests crash.
945         https://bugs.webkit.org/show_bug.cgi?id=119333
946
947         Reviewed by Darin Adler.
948
949         Use a RefPtr to store a reference to the parent element of
950         an AccessibilityUIElement instead of the raw pointer, so we
951         never derefence a function from an invalid pointer.
952
953         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
954         (WTR::attributesOfElement): Use a RefPtr instead of a raw pointer.
955
956 2013-08-07  Cosmin Truta  <ctruta@blackberry.com>
957
958         Unreviewed. Add myself as a committer.
959
960         * Scripts/webkitpy/common/config/contributors.json:
961
962 2013-08-04  Sam Weinig  <sam@webkit.org>
963
964         Remove support for HTML5 MicroData
965         https://bugs.webkit.org/show_bug.cgi?id=119480
966
967         Reviewed by Anders Carlsson.
968
969         * Scripts/webkitperl/FeatureList.pm:
970         * qmake/mkspecs/features/features.pri:
971
972 2013-07-23  David Farler  <dfarler@apple.com>
973
974         Provide optional OTHER_CFLAGS, OTHER_CPPFLAGS, OTHER_LDFLAGS additions for building with ASAN
975         https://bugs.webkit.org/show_bug.cgi?id=117762
976
977         Reviewed by Mark Rowe.
978
979         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
980         Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
981         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
982         Add ASAN_OTHER_LDFLAGS.
983         * MiniBrowser/Configurations/DebugRelease.xcconfig:
984         Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
985         * Scripts/check-for-weak-vtables-and-externals:
986         Ignore ___asan externals, these are populated by compiler-rt.
987         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
988         Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
989         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
990         Add ASAN_OTHER_LDFLAGS.
991         * WebKitLauncher/Configurations/Base.xcconfig:
992         Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
993         * WebKitLauncher/Configurations/WebKitNightlyEnabler.xcconfig:
994         Add ASAN_OTHER_LDFLAGS.
995         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
996         Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
997         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
998         Add ASAN_OTHER_LDFLAGS.
999         * asan/asan.xcconfig: Added.
1000         * asan/webkit-asan-ignore.txt: Added.
1001
1002 2013-08-05  Brian Holt  <brian.holt@samsung.com>
1003
1004         [GTK] Implement leak checking with valgrind
1005         https://bugs.webkit.org/show_bug.cgi?id=118785
1006
1007         Reviewed by Dirk Pranke.
1008
1009         Launch the DRT under Valgrind to generate xml files with details
1010         of leaks found.
1011
1012         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1013         (parse_args):
1014         * Scripts/webkitpy/port/gtk.py:
1015         (GtkPort.__init__):
1016         (GtkPort.default_timeout_ms): Allow extra time to run under
1017         Valgrind.
1018         (GtkPort.setup_environ_for_server): Pass Valgrind instructions
1019         using environment variables.
1020
1021 2013-08-02  Mario Sanchez Prada  <mario.prada@samsung.com>
1022
1023         [EFL] REGRESSION after r153432: some accessibility tests crash.
1024         https://bugs.webkit.org/show_bug.cgi?id=119333
1025
1026         Reviewed by Gustavo Noronha Silva.
1027
1028         Add missing null-check to avoid dereferencing a non-existent parent.
1029
1030         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1031         (WTR::attributesOfElement): Ditto.
1032
1033 2013-08-02  Patrick Gansterer  <paroga@webkit.org>
1034
1035         Add --rmdir option to git svn dcommit
1036         https://bugs.webkit.org/show_bug.cgi?id=119398
1037
1038         Reviewed by Ryosuke Niwa.
1039
1040         Add this option tells git-svn to remove empty directories
1041         from the svn tree so they do not leave over there.
1042
1043         * Scripts/webkitpy/common/checkout/scm/git.py:
1044         (Git.push_local_commits_to_server):
1045
1046 2013-08-01  Brent Fulgham  <bfulgham@apple.com>
1047
1048         [Windows] WebKit1 Fullscreen Video Play is Broken
1049         https://bugs.webkit.org/show_bug.cgi?id=119415
1050
1051         Reviewed by Jer Noble.
1052
1053         * WinLauncher/WinLauncher.cpp:
1054         (dllLauncherEntryPoint): Activate full screen mode via
1055         IWebPreferencesInternal interface.
1056
1057 2013-08-01  ChangSeok Oh  <changseok.oh@collabora.com>
1058
1059         Unreviewed. Add an alternative address to show my affiliation in team.html.
1060
1061         * Scripts/webkitpy/common/config/contributors.json:
1062
1063 2013-08-01  Bem Jones-Bey  <bjonesbe@adobe.com>
1064
1065         Duplicate property names can cause test to fail
1066         https://bugs.webkit.org/show_bug.cgi?id=119399
1067
1068         Reviewed by Dirk Pranke.
1069
1070         This problem was noticed when porting the patch for
1071         http://wkb.ug/119357 to Blink: a test would fail because the converted
1072         and test property lists weren't the same length, but they contained
1073         all of the same property names. It looks like this is actually caused
1074         by a bug in converting the HTML, which is being currently rewritten.
1075         In the meantime, as long as this compares the number of unique
1076         properties, it makes the test more robust.
1077
1078         * Scripts/webkitpy/w3c/test_converter_unittest.py:
1079         (verify_prefixed_properties):
1080
1081 2013-08-01  Bem Jones-Bey  <bjonesbe@adobe.com>
1082
1083         Unreviewed. Adding my expertise.
1084
1085         * Scripts/webkitpy/common/config/contributors.json:
1086
1087 2013-08-01  ChangSeok Oh  <changseok.oh@collabora.com>
1088
1089         Unreviewed. Add myself as a committer. Yoo-hoo! \o/
1090
1091         * Scripts/webkitpy/common/config/contributors.json:
1092
1093 2013-08-01  Commit Queue  <commit-queue@webkit.org>
1094
1095         Unreviewed, rolling out r153518.
1096         http://trac.webkit.org/changeset/153518
1097         https://bugs.webkit.org/show_bug.cgi?id=119386
1098
1099         The Jhbuild dep bump of GTK+ is not actually required by
1100         layout testing, is causing pango dep problems (Requested by
1101         zdobersek on #webkit).
1102
1103         * gtk/jhbuild.modules:
1104
1105 2013-08-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1106
1107         Unreviewed. Add myself as a committer.
1108
1109         * Scripts/webkitpy/common/config/contributors.json:
1110
1111 2013-08-01  Jaehun Lim  <ljaehun.lim@samsung.com>
1112
1113         Unreviewed. Add myself as a committer.
1114
1115         * Scripts/webkitpy/common/config/contributors.json:
1116
1117 2013-07-31  Jinwoo Song  <jinwoo7.song@samsung.com>
1118
1119         Unreviewed. Add myself as a committer.
1120
1121         * Scripts/webkitpy/common/config/contributors.json:
1122
1123 2013-08-01  Alberto Garcia  <berto@igalia.com>
1124
1125         Unreviewed. Add myself as a committer.
1126
1127         * Scripts/webkitpy/common/config/contributors.json:
1128
1129 2013-07-31  Seokju Kwon  <seokju@webkit.org>
1130
1131         Unreviewed. Add myself as a committer.
1132
1133         * Scripts/webkitpy/common/config/contributors.json:
1134
1135 2013-07-31  Bem Jones-Bey  <bjonesbe@adobe.com>
1136
1137         W3C test import script prefixes some properties that it shouldn't
1138         https://bugs.webkit.org/show_bug.cgi?id=119357
1139
1140         Reviewed by Dirk Pranke.
1141
1142         Some prefixed properties also have unprefixed implemetations, but when
1143         the implementations aren't identical, they aren't declared in
1144         CSSPropertyNames.in on the same line. This fixes the import script so
1145         that it catches all instances of prefixed properties that have an
1146         unprefixed variant, and does not add the prefix in those cases.
1147
1148         * Scripts/webkitpy/w3c/test_converter.py:
1149         (W3CTestConverter.read_webkit_prefixed_css_property_list): Read all of
1150         the properties on every line and record if they are prefixed or not.
1151         Use this information to only return prefixed properties that do not
1152         have any unprefixed variant. The prefixed property list has also
1153         changed to not include the '-webkit-' prefix, making it much easier to
1154         do the comparison, and removing the need to remove the prefix later.
1155         (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties): This no
1156         longer needs to remove the '-webkit-' prefix, but needs to add it in
1157         the case where a property that needs a prefix is found.
1158         * Scripts/webkitpy/w3c/test_converter_unittest.py:
1159         (W3CTestConverterTest.test_read_prefixed_property_list): Remove assert
1160         for '-webkit-' prefix, as it is no longer included in the properties
1161         in the prefixed property list.
1162
1163 2013-07-31  Bem Jones-Bey  <bjonesbe@adobe.com>
1164
1165         Update location of w3c shapes tests to reflect new import location
1166         https://bugs.webkit.org/show_bug.cgi?id=118156
1167
1168         Reviewed by Dirk Pranke.
1169
1170         Partial imports should not be imported to the same place as the full
1171         import, so this adds an option to allow importing to a different
1172         location than the default. In doing that, I found that imports from
1173         contributor directories didn't seem to be working correctly, so I
1174         updated the import to be smarter about both contributor directories
1175         and the test status directories. It should now be more likely that the
1176         script guesses the root directory properly.
1177
1178         * Scripts/webkitpy/w3c/test_importer.py: Remove comment about the
1179             script not working with the full set of contributors, as that is
1180             no longer true, and I didn't see a good way to keep that behavior.
1181             Also update documentation to properly explain what happens when a
1182             contributor dir is imported.
1183         (main): Attempt to find the proper repo dir by looking at the
1184             directory above the "test status" in the given path, this is still
1185             not exactly right, but is less error prone than just trimming.
1186         (parse_args): Add -d option to set the import directory.
1187         (TestImporter.__init__): Stop appending the subdirs to the
1188             destination_directory because it was making things more complex
1189             and isn't really needed.
1190         (TestImporter.update_test_status): Remove hardcoded strings and use
1191             the TEST_STATUS constants instead.
1192         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1193         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg): Add
1194             support for new option.
1195         (TestImporterTest.test_import_dir_with_no_tests): Ditto.
1196
1197 2013-07-31  Brent Fulgham  <bfulgham@apple.com>
1198
1199         [Windows] Winlauncher shouldn't look for Safari Install Directory
1200         https://bugs.webkit.org/show_bug.cgi?id=119351
1201
1202         Reviewed by Darin Adler.
1203
1204         * win/DLLLauncher/DLLLauncherMain.cpp: Don't check registry for
1205         the Safari install location. Instead, use the proper support
1206         library path for the build architecture.
1207
1208 2013-07-31  Bem Jones-Bey  <bjonesbe@adobe.com>
1209
1210         Update scripts to reference contributors.json instead of committers.py in messaging
1211         https://bugs.webkit.org/show_bug.cgi?id=119342
1212
1213         Reviewed by Ryosuke Niwa.
1214
1215         Change the scripts to point people to contributors.json instead of
1216         committers.py since the latter no longer contains the list of
1217         contributors.
1218
1219         * Scripts/webkitpy/common/config/committervalidator.py:
1220         (CommitterValidator._contributors_json_path):
1221         (CommitterValidator._flag_permission_rejection_message):
1222         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
1223         (CommitterValidatorTest.test_flag_permission_rejection_message):
1224         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1225         (Bugzilla._commit_queue_flag):
1226         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
1227         (WatchListParser._validate):
1228         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
1229         (WatchListParserTest.test_cc_rule_with_invalid_email):
1230         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1231         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1232         * Scripts/webkitpy/tool/steps/validatereviewer.py:
1233         (ValidateReviewer.run):
1234
1235 2013-07-31  Roger Fong  <roger_fong@apple.com>
1236
1237         Unreviewed. Re-enable WinEWS tests following r153527.
1238
1239         * Scripts/webkitpy/common/config/ews.json:
1240
1241 2013-07-31  Bem Jones-Bey  <bjonesbe@adobe.com>
1242
1243         Unreviewed: Adding myself to the committers' list.
1244
1245         * Scripts/webkitpy/common/config/contributors.json:
1246
1247 2013-07-31  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1248
1249         [Qt] Build WebKit with C++11
1250         https://bugs.webkit.org/show_bug.cgi?id=119337
1251
1252         Reviewed by Csaba Osztrogonác.
1253
1254         Enable building with C++11.
1255
1256         * qmake/mkspecs/features/default_pre.prf:
1257         * qmake/mkspecs/features/unix/default_post.prf:
1258         * qmake/mkspecs/features/unix/default_pre.prf:
1259
1260 2013-07-31  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1261
1262         [Qt] ASSERTS trigger in release builds
1263         https://bugs.webkit.org/show_bug.cgi?id=119336
1264
1265         Reviewed by Jocelyn Turcotte.
1266
1267         Ensure the qmake also defaults to release if no configuration is known.
1268
1269         * qmake/mkspecs/features/default_post.prf:
1270
1271 2013-07-31  Zan Dobersek  <zdobersek@igalia.com>
1272
1273         [texmap][GStreamer][GTK] composited video shows tearing
1274         https://bugs.webkit.org/show_bug.cgi?id=118253
1275
1276         Reviewed by Martin Robinson.
1277
1278         * gtk/jhbuild.modules: Bump the Jhbuild versions of the Gdk-Pixbuf and GTK+ packages to 2.27.3 and 3.8.2, respectively.
1279         The first is required by the second, and the GTK+ bump introduces proper display framerate synchronization that removes
1280         screen tearing when enabling accelerated compositing and performing graphically heavy operations like viewing HD videos.
1281
1282 2013-07-30  Ruth Fong  <ruth_fong@apple.com>
1283
1284         Unreviewed: Adding myself to the committers' list.
1285
1286         * Scripts/webkitpy/common/config/contributors.json:
1287
1288 2013-07-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1289
1290         Unreviewed, add my new email to contributors.json.
1291
1292         * Scripts/webkitpy/common/config/contributors.json:
1293
1294 2013-07-30  Krzysztof Czech  <k.czech@samsung.com>
1295
1296         [EFL] REGRESSION after r153439: layout tests do not run.
1297         https://bugs.webkit.org/show_bug.cgi?id=119240
1298
1299         Reviewed by Christophe Dumez.
1300
1301         Changed attribute name from check_xvfb to check_driver.
1302
1303         * Scripts/webkitpy/port/efl.py:
1304         (EflPort.check_sys_deps):
1305
1306 2013-07-29  Commit Queue  <commit-queue@webkit.org>
1307
1308         Unreviewed, rolling out r152860.
1309         http://trac.webkit.org/changeset/152860
1310         https://bugs.webkit.org/show_bug.cgi?id=119227
1311
1312         Disable WinEWS tests until tests stop crashing (Requested by
1313         rfong on #webkit).
1314
1315         * Scripts/webkitpy/common/config/ews.json:
1316
1317 2013-07-29  Zan Dobersek  <zdobersek@igalia.com>
1318
1319         [GTK] Add WestonDriver, use it when appropriate
1320         https://bugs.webkit.org/show_bug.cgi?id=119100
1321
1322         Reviewed by Dirk Pranke.
1323
1324         Introduce the WestonDriver, a Driver-implementing class that sets up an instance of Weston, the Wayland compositor,
1325         and sets up an environment that enables the test runner to run inside it.
1326
1327         The design very much mimics the XvfbDriver class. It is currently used by the GTK port when the WAYLAND_DISPLAY
1328         environment variable is set, that is when NRWT is being run under a Wayland display.
1329
1330         * Scripts/webkitpy/port/base.py:
1331         (Port.to.setup_environ_for_server): Also copy the XDG_RUNTIME_DIR env from the original environment for Linux-using ports.
1332         * Scripts/webkitpy/port/gtk.py:
1333         (GtkPort):
1334         (GtkPort._driver_class): Make the method memoized - the display type is not going to change during the testing, so we
1335         should only check once for the presence of the WAYLAND_DISPLAY env and determine the proper driver class to use based on that.
1336         (GtkPort.check_sys_deps): Call the static check_driver method on the class as returned by the _driver_class method
1337         instead of hard-coding the XvfbDriver class in the check.
1338         * Scripts/webkitpy/port/westondriver.py: Added.
1339         (WestonDriver):
1340         (WestonDriver.check_driver): Similarly to XvfbDriver, this checks for existance of the weston executable.
1341         (WestonDriver.__init__): Again, like in XvfbDriver, we use a small delay between launching the Weston display and launching the driver.
1342         (WestonDriver._start): Sets up the driver-specific temporary directory, launches the Weston display, sets up the environment for the
1343         driver and then launches the driver in said environment, using the driver's Weston display.
1344         (WestonDriver.stop): Cleans up the Weston instance and the temporary directory.
1345         (WestonDriver._ensure_driver_tmpdir_subdirectory): A helper function that creates a subdirectory in the driver's temporary directory
1346         and returns the absolute path to it.
1347         * Scripts/webkitpy/port/xvfbdriver.py:
1348         (XvfbDriver.check_driver): Renamed from check_xvfb.
1349         (XvfbDriver._start): Access the FileSystem object through the Port's Host object, instead of the Port's private member.
1350
1351 2013-07-29  Mario Sanchez Prada  <mario.prada@samsung.com>
1352
1353         [ATK] Implement attributesOfChildren() for AccessibilityUIElement
1354         https://bugs.webkit.org/show_bug.cgi?id=118967
1355
1356         Reviewed by Gustavo Noronha Silva.
1357
1358         Implemented AccessibilityUIElement::attributesOfChildren() both
1359         in DumpRenderTree and the WebKitTestRunner.
1360
1361         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1362         (AccessibilityUIElement::attributesOfChildren): Implemented.
1363
1364         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1365         (WTR::AccessibilityUIElement::attributesOfChildren): Implemented.
1366
1367 2013-07-29  Mario Sanchez Prada  <mario.prada@samsung.com>
1368
1369         [ATK] Implement allAttributes() for AccessibilityUIElement
1370         https://bugs.webkit.org/show_bug.cgi?id=118966
1371
1372         Reviewed by Gustavo Noronha Silva.
1373
1374         Implemented AccessibilityUIElement::allAttributes() both in
1375         DumpRenderTree and the WebKitTestRunner.
1376
1377         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1378         (getAtkAttributeSetAsString): Moved up in the file, and refactored
1379         to use StringBuilder and return a String instead of a gchar*.
1380         (roleToString): Changed not to return the "AXRole: " prefix, so
1381         we can use it as well from attributesOfElement().
1382         (attributesOfElement): New function to dump attributes for an object.
1383         (AccessibilityUIElement::allAttributes): Call attributesOfElement().
1384         (AccessibilityUIElement::role): Updated to prefix "AXRole: ".
1385
1386         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1387         (getAtkAttributeSetAsString): Refactored to use StringBuilder and return
1388         a String instead of a gchar*.
1389
1390         (WTF::roleToString): Changed not to return the "AXRole: " prefix,
1391         so we can use it as well from attributesOfElement().
1392         (WTF::attributesOfElement): New function to dump attributes for an object.
1393         (WTR::AccessibilityUIElement::allAttributes): Call attributesOfElement().
1394         (WTR::AccessibilityUIElement::role): Updated to prefix "AXRole: ".
1395
1396 2013-07-29  Daniel Bates  <dabates@apple.com>
1397
1398         Add support infrastructure for iOS WebKit port
1399         https://bugs.webkit.org/show_bug.cgi?id=119168
1400
1401         Reviewed by Ryosuke Niwa.
1402
1403         Implement support infrastructure towards building iOS WebKit.
1404
1405         * Scripts/webkitdirs.pm:
1406         (xcodeSDKPlatformName): Added.
1407         (determineConfigurationProductDir):
1408         (builtDylibPathForName):
1409         (willUseIOSDeviceSDKWhenBuilding): Added.
1410         (willUseIOSSimulatorSDKWhenBuilding): Added.
1411         (isIOSWebKit): Added.
1412         (copyInspectorFrontendFiles):
1413
1414 2013-07-29  Sergio Correia  <sergio.correia@openbossa.org>
1415
1416         CoordinatedGraphics: Add API to get and set the active state of a WebView
1417         https://bugs.webkit.org/show_bug.cgi?id=119067
1418
1419         Reviewed by Noam Rosenthal.
1420
1421         Added API tests for WKViewIsActive and WKViewSetIsActive.
1422
1423         * TestWebKitAPI/PlatformEfl.cmake:
1424         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp: Added.
1425         (TestWebKitAPI::didFinishLoadForFrame):
1426         (TestWebKitAPI::webProcessCrashed):
1427         (TestWebKitAPI::webProcessRelaunched):
1428         (TestWebKitAPI::TEST):
1429         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp:
1430         Bundle added to allow crashing the WebProcess and testing the active state of a view
1431         under such condition.
1432         (TestWebKitAPI::WKViewIsActiveSetIsActiveTest::WKViewIsActiveSetIsActiveTest):
1433         (TestWebKitAPI::WKViewIsActiveSetIsActiveTest::didReceiveMessage):
1434
1435 2013-07-29  Zan Dobersek  <zdobersek@igalia.com>
1436
1437         [Automake] Remove references to non-existent *_CFLAGS and *_LIBS variables
1438         https://bugs.webkit.org/show_bug.cgi?id=119212
1439
1440         Reviewed by Carlos Garcia Campos.
1441
1442         * GNUmakefile.am: Remove references to GLOBALDEPS_(CFLAGS|LIBS) and CLUTTER_(CFLAGS|LIBS)
1443         variables that are not defined during the configuration process.
1444         * TestWebKitAPI/GNUmakefile.am: Ditto.
1445         * WebKitTestRunner/GNUmakefile.am: Ditto.
1446
1447 2013-07-28  Andy Estes  <aestes@apple.com>
1448
1449         Include <stdio.h> to declare perror()
1450         https://bugs.webkit.org/show_bug.cgi?id=119198
1451
1452         Reviewed by Andreas Kling.
1453
1454         Silences an implicit declaration warning.
1455
1456         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport.c:
1457
1458 2013-07-27  Ryuan Choi  <ryuan.choi@samsung.com>
1459
1460         [EFL] Bump required version of EFL to 1.7
1461         https://bugs.webkit.org/show_bug.cgi?id=119144
1462
1463         Reviewed by Christophe Dumez.
1464
1465         * MiniBrowser/efl/CMakeLists.txt: Bumped EFL to 1.7
1466
1467 2013-07-26  Filip Pizlo  <fpizlo@apple.com>
1468
1469         WKTR should know about the JSC extensions to testRunner
1470         https://bugs.webkit.org/show_bug.cgi?id=119154
1471
1472         Reviewed by Mark Hahnenberg and Geoffrey Garen.
1473         
1474         This makes some fast/js tests pass.
1475
1476         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1477         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1478         (WTR::TestRunner::numberOfDFGCompiles):
1479         (WTR::TestRunner::neverInlineFunction):
1480         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1481
1482 2013-07-25  Mark Rowe  <mrowe@apple.com>
1483
1484         Fix build of DumpRenderTree and WebKitTestRunner when building against an SDK.
1485
1486         * DumpRenderTree/mac/Configurations/Base.xcconfig: Fix framework search path when building against an SDK.
1487         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto. Also fix where our scripts look for WebCore.framework
1488         so they pull the version out of the SDK.
1489
1490 2013-07-25  Anders Carlsson  <andersca@apple.com>
1491
1492         Localizable.strings generated by extract-localizable-strings should be UTF-8
1493         https://bugs.webkit.org/show_bug.cgi?id=119106
1494
1495         Reviewed by Mark Rowe.
1496
1497         Output strings as UTF-8.
1498
1499         * Scripts/extract-localizable-strings:
1500
1501 2013-07-25  Sam Weinig  <sam@webkit.org>
1502
1503         -[WebHTMLView attributedSubstringForProposedRange:actualRange:] does not include strikethrough attribute in the returned attributed string
1504         https://bugs.webkit.org/show_bug.cgi?id=119099
1505         <rdar://problem/13439291>
1506
1507         Reviewed by Enrica Casucci.
1508
1509         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1510         * TestWebKitAPI/Tests/mac/AttributedString.mm:
1511         (TestWebKitAPI::attributedString):
1512         (TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
1513         (TestWebKitAPI::AttributedStringTest_CustomFont::url):
1514         (TestWebKitAPI::AttributedStringTest_CustomFont::runTest):
1515         (TestWebKitAPI::TEST_F):
1516         (TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
1517         (TestWebKitAPI::AttributedStringTest_Strikethrough::url):
1518         (TestWebKitAPI::AttributedStringTest_Strikethrough::runTest):
1519         * TestWebKitAPI/Tests/mac/attributedStringStrikethrough.html: Added.
1520         Add tests for attributed strings with strikethrough.  Refactor the attributed string tests
1521         to make adding more easier in the future.
1522
1523 2013-07-20  Filip Pizlo  <fpizlo@apple.com>
1524
1525         fourthTier: FTL should be able to generate LLVM IR that uses an intrinsic for OSR exit
1526         https://bugs.webkit.org/show_bug.cgi?id=118948
1527
1528         Reviewed by Sam Weinig.
1529         
1530         - Make ReducedFTL capable of dealing with code that uses the fake OSR exit intrinsic,
1531           by exporting it as a function.
1532         
1533         - Make combineModules.rb idempotent. Sometimes it's convenient to run a file through
1534           it even if you know that you've already done so. See processIRDump.sh.
1535         
1536         - Add a script, processIRDump.sh, that takes the output of --dumpLLVMIR=true and
1537           runs it through ReducedFTL automatically. You typically want to say something like:
1538           
1539           jsc --dumpLLVMIR=true <program(s)> > jsc-output.txt
1540           ./processIRDump.sh --timing < jsc-output.txt
1541
1542         * ReducedFTL/ReducedFTL.c:
1543         (webkit_osr_exit):
1544         * ReducedFTL/combineModules.rb:
1545         * ReducedFTL/processIRDump.sh: Added.
1546
1547 2013-07-20  Filip Pizlo  <fpizlo@apple.com>
1548
1549         fourthTier: We should use the no-asserts build of LLVM if that's what the user configured
1550         https://bugs.webkit.org/show_bug.cgi?id=118947
1551
1552         Reviewed by Dan Bernstein.
1553
1554         * Scripts/copy-webkitlibraries-to-product-directory:
1555
1556 2013-07-16  Filip Pizlo  <fpizlo@apple.com>
1557
1558         fourthTier: We should have a reduced FTL LLVM pipeline tool in the repository
1559         https://bugs.webkit.org/show_bug.cgi?id=118647
1560
1561         Rubber stamped by Geoffrey Garen and Mark Hahnenberg.
1562
1563         Add a tool that takes in an LLVM bitcode file and JITs it in exactly the same
1564         way that the FTL would.
1565         
1566         Also add a tool that combines multiple LLVM modules generated by FTL into a
1567         single module.
1568
1569         * ReducedFTL: Added.
1570         * ReducedFTL/ReducedFTL.c: Added.
1571         (usage):
1572         (currentTime):
1573         (MemorySection):
1574         (mmAllocateCodeSection):
1575         (mmAllocateDataSection):
1576         (mmApplyPermissions):
1577         (mmDestroy):
1578         (symbolLookupCallback):
1579         (main):
1580         * ReducedFTL/build.sh: Added.
1581         * ReducedFTL/combineModules.rb: Added.
1582
1583 2013-06-09  Filip Pizlo  <fpizlo@apple.com>
1584
1585         Unreviewed, fix minor goof in profiling output layout. We weren't accounting
1586         for the "/" that is printed between engine counts.
1587
1588         * Scripts/display-profiler-output:
1589
1590 2013-05-28  Filip Pizlo  <fpizlo@apple.com>
1591
1592         testRunner should have a way of disabling inlining of functions
1593         https://bugs.webkit.org/show_bug.cgi?id=116875
1594
1595         Reviewed by Mark Hahnenberg.
1596
1597         * DumpRenderTree/TestRunner.cpp:
1598         (neverInlineFunction):
1599         (TestRunner::staticFunctions):
1600
1601 2013-05-27  Filip Pizlo  <fpizlo@apple.com>
1602
1603         testRunner should be able to tell you if a function is DFG compiled
1604         https://bugs.webkit.org/show_bug.cgi?id=116847
1605
1606         Reviewed by Mark Hahnenberg.
1607
1608         * DumpRenderTree/TestRunner.cpp:
1609         (numberOfDFGCompiles):
1610         (TestRunner::staticFunctions):
1611
1612 2013-05-21  Filip Pizlo  <fpizlo@apple.com>
1613
1614         fourthTier: display-profiler-output should make it even easier to diff the compilation story between two different runs
1615         https://bugs.webkit.org/show_bug.cgi?id=116556
1616
1617         Reviewed by Oliver Hunt.
1618         
1619         This adds three new capabilities:
1620         
1621         - 'display' now accepts negative compilation indices, and allows specifying
1622           wildcard hashes combined with combination indices. Previously you could say
1623           'display <hash>', 'display <hash>-<index>-<engine>', or 'display *'. The
1624           latter would display every compilation. This improves this so that you can
1625           say 'display *-<index>-<engine>'. It also makes it so that you can give a
1626           negative index, which allows you to say things like 'display blah--1-dfg',
1627           which displays just the last DFG compilation. Also you can say
1628           'display *--1-dfg', which displays the last DFG compilation for each code
1629           block. I realize that this is kind of ugly, but gosh is it practical.
1630         
1631         - You can now say 'sort hash', which will henceforth sort all of the output
1632           by code hash rather than by the time when it was compiled. This means that
1633           if you're doing 'dispay *--1-dfg' and then want to diff the results against
1634           something else, you can ensure that this doesn't get confused just by
1635           changes in compilation order.
1636         
1637         - You can now say 'counts off', which will henceforth disable the display of
1638           execution counts from 'bytecode' and 'display'. This is also useful for
1639           diffs, since if you're trying to figure out why two compilations are
1640           different, they probably have radically different counts. 'counts off' gets
1641           this out of the output so that it doesn't confuse your diff.
1642         
1643         Note that to use this effectively you should also have a script that scrubs
1644         pointers from text so that the diff doesn't get confused by pointers. I'll
1645         post my elimptr script to the bug. Maybe at some point I'll integrate that
1646         into display-profiler-output.
1647         
1648         Put together this is pretty awesome. I was able to do the following:
1649         
1650         (echo "counts off" && echo "sort hash" && echo "d *--1-dfg") | Tools/Scripts/display-profiler-output richards-serial.profile | elimptr > richards-serial.asm
1651         (echo "counts off" && echo "sort hash" && echo "d *--1-dfg") | Tools/Scripts/display-profiler-output richards-concurrent.profile | elimptr > richards-concurrent.asm
1652         diff -u richards-serial.asm richards-concurrent.asm
1653         
1654         And this immediately told me that the reason why richards is slower in the
1655         concurrent compilation case is just that we end up compiling *tons* more
1656         functions, most of which are trivially inlineable. Basically, concurrent
1657         compilation breaks our previous heuristics for delaying compilation of
1658         inlineables just enough that they never trigger compilation. We should fix
1659         that in a separate bug.
1660
1661         * Scripts/display-profiler-output:
1662
1663 2013-04-30  Filip Pizlo  <fpizlo@apple.com>
1664
1665         fourthTier: Use hw.availcpu instead of hw.ncpu, and configure LLVM with --enable-zlib=no
1666
1667         Rubber stamped by Mark Rowe.
1668
1669         * Scripts/copy-webkitlibraries-to-product-directory:
1670
1671 2013-07-16  Oliver Hunt <oliver@apple.com>
1672
1673         Merge dfgFourthTier r148853
1674
1675     2013-04-21  Filip Pizlo  <fpizlo@apple.com>
1676
1677         fourthTier: tandem WebKit and LLVM builds should ./configure LLVM if needed
1678         https://bugs.webkit.org/show_bug.cgi?id=114933
1679
1680         Reviewed by Andy Estes.
1681         
1682         This makes it easy to get set up for tandem LLVM builds.
1683
1684         * Scripts/copy-webkitlibraries-to-product-directory:
1685
1686 2013-07-16  Oliver Hunt <oliver@apple.com>
1687
1688         Merge dfgFourthTier r148850
1689
1690     2013-04-21  Filip Pizlo  <fpizlo@apple.com>
1691
1692         fourthTier: WebKit's build system should relink JavaScriptCore if LLVM's libraries changed but its headers didn't
1693         https://bugs.webkit.org/show_bug.cgi?id=114926
1694
1695         Reviewed by Geoffrey Garen.
1696         
1697         If the LLVM libraries change, then touch a phony header, which will force relink
1698         of JavaScriptCore.
1699
1700         * Scripts/copy-webkitlibraries-to-product-directory:
1701         (unpackIfNecessary):
1702
1703 2013-07-16  Oliver Hunt <oliver@apple.com>
1704
1705         Merge dfgFourthTier r148848
1706
1707     2013-04-21  Filip Pizlo  <fpizlo@apple.com>
1708
1709         fourthTier: developing LLVM in tandem with WebKit should be fun and easy
1710         https://bugs.webkit.org/show_bug.cgi?id=114925
1711
1712         Reviewed by Geoffrey Garen.
1713         
1714         This enables building LLVM along with WebKit, so that build-jsc and build-webkit
1715         will also optionally build LLVM and quickly symlink LLVM's built products into
1716         the right places.
1717         
1718         Most WebKit and JSC hackers will want to rely on the checked-in already-built
1719         versions of LLVM in WebKitLibraries. But developing both systems in tandem is an
1720         increasingly common use-case for me, and it may become a common use case for a
1721         handful of others. Currently, this is really painful: you first have to build
1722         LLVM, then you have to export-llvm-build (which takes a while), and then you
1723         have to make sure that your LLVM_LIBRARY_PACKAGE and LLVM_INCLUDE_PACKAGE
1724         variables are set to point to the thing you exported. The whole process loses
1725         track of dependencies very quickly: making a tiny change in LLVM requires
1726         packaging, and then unpackaging, a large number of potentially large headers and
1727         static libraries. Not only is this slow but it then causes the WebKit build
1728         system to rebuild anything that transitively includes any LLVM header, which is
1729         now quite a few files. While this sort of use pattern is still worthwhile if
1730         you're trying to package a binary drop and test it, it's not great if you're
1731         just trying to do experimental development that involves making small changes
1732         in both trees.
1733         
1734         This change fixes this use case while keeping the old use cases intact. You can
1735         do tandem development using one of two modes:
1736         
1737         Your own LLVM directory: just set LLVM_SOURCE_PATH to the *absolute* path of
1738         the LLVM directory you're using. Once this is done, any invocation of a WebKit
1739         build via build-jsc or build-webkit will also build LLVM, and then quickly
1740         symlink things into place without perturbing dependency tracking.
1741         
1742         Internal LLVM directory: if you check out llvm into a directory called 'llvm'
1743         right off of the WebKit source tree, then the build system will automatically
1744         use this.
1745         
1746         Here's how this takes care of dependencies:
1747         
1748         Headers: the include/llvm and include/llvm-c directories are symlinked into
1749         $productsDir/usr/local/include. And then everything just works.
1750         
1751         Libraries: the build system detects, by reading LLVM's Makefile.config, which
1752         mode LLVM is built in (like Release+Asserts or Debug+Asserts) and symlinks
1753         the .a files into $productsDir/<thingy>. It will ranlib those libraries only
1754         if they have changed, by checking both the modification time and also whether
1755         the last time we had a symlink, that symlink was from the same directory.
1756         This helps if you switch to an *older* LLVM build (using LLVM_SOURCE_PATH)
1757         but that build wasn't yet ranlib'd.
1758         
1759         One problem that this does not yet solve is that xcodebuild will not relink
1760         JavaScriptCore if the only thing that changed was the libraries. I will work
1761         on this problem separately: https://bugs.webkit.org/show_bug.cgi?id=114926.
1762
1763         * Scripts/copy-webkitlibraries-to-product-directory:
1764         (unpackIfNecessary):
1765         (fileContains):
1766         (fileContentsEquals):
1767
1768 2013-04-15  Filip Pizlo  <fpizlo@apple.com>
1769
1770         fourthTier: Update LLVM-related build scripts to copy generated headers as well
1771         https://bugs.webkit.org/show_bug.cgi?id=114551
1772
1773         Reviewed by Oliver Hunt.
1774         
1775         Also added the ability to use something other than bzip2 compression, since although
1776         it is great for checking things into the tree, it increases turn-around times when
1777         experimenting.
1778
1779         * Scripts/copy-webkitlibraries-to-product-directory:
1780         (unpackIfNecessary):
1781         * Scripts/export-llvm-build:
1782
1783 2013-04-03  Filip Pizlo  <fpizlo@apple.com>
1784
1785         fourthTier: Include LLVM headers with surrounding #pragmas instead of using my #define
1786         https://bugs.webkit.org/show_bug.cgi?id=113921
1787
1788         Reviewed by Oliver Hunt.
1789
1790         The LLVM community wants us to continue including all of LLVM's C++ headers. Change
1791         the export script to do this.
1792         
1793         * Scripts/export-llvm-build:
1794
1795 2013-03-29  Filip Pizlo  <fpizlo@apple.com>
1796
1797         fourthTier: Check in a known-good build of LLVM into WebKitLibraries, and have a story for updating it
1798         https://bugs.webkit.org/show_bug.cgi?id=113452
1799
1800         Rubber stamped by Mark Hahnenberg.
1801
1802         * Scripts/copy-webkitlibraries-to-product-directory:
1803         * Scripts/export-llvm-build:
1804
1805 2013-03-29  Filip Pizlo  <fpizlo@apple.com>
1806
1807         fourthTier: FTL JIT should be able run some simple function
1808         https://bugs.webkit.org/show_bug.cgi?id=113481
1809
1810         Reviewed by Geoffrey Garen.
1811         
1812         Give the scripts the ability to find an LLVM build and use it.
1813         
1814         Also added a script, export-llvm-build, that allows you to take your
1815         own build of LLVM and package it for use by WebKit's build system.
1816         
1817         The build system treats a "build" of LLVM as a pair of .tar.bz2's,
1818         one for the library archives and one for the headers. It then unpacks
1819         them into your built products directory in a mannner that is mostly
1820         analogous to how WebKitSystemInterface works.
1821
1822         * Scripts/build-jsc:
1823         * Scripts/copy-webkitlibraries-to-product-directory:
1824         (unpackIfNecessary):
1825         (dittoHeaders):
1826         * Scripts/export-llvm-build: Added.
1827
1828 2013-07-24  Anders Carlsson  <andersca@apple.com>
1829
1830         Crash when calling WKPageGetProcessIdentifier after aborted process launch
1831         https://bugs.webkit.org/show_bug.cgi?id=119069
1832         <rdar://problem/14494064>
1833
1834         Reviewed by Andreas Kling.
1835
1836         Add a test.
1837
1838         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1839         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp: Added.
1840         (TestWebKitAPI::didFinishLoadForFrame):
1841         (TestWebKitAPI::TEST):
1842
1843 2013-07-24  Zan Dobersek  <zdobersek@igalia.com>
1844
1845         Make KURL::hasPath private
1846         https://bugs.webkit.org/show_bug.cgi?id=118279
1847
1848         Reviewed by Darin Adler.
1849
1850         * TestWebKitAPI/Tests/WebCore/KURL.cpp:
1851         (TestWebKitAPI::TEST_F): Remove references to KURL::hasPath the method is now private and thus not accessible for testing.
1852
1853 2013-07-24  Anton Obzhirov  <a.obzhirov@samsung.com>
1854
1855         [GTK] TestInspectorServer unit test is timing out
1856         https://bugs.webkit.org/show_bug.cgi?id=105866
1857
1858         Reviewed by Gustavo Noronha Silva.
1859
1860         * Scripts/run-gtk-tests:
1861         (TestRunner):
1862
1863 2013-07-24  Anton Obzhirov  <a.obzhirov@samsung.com>
1864
1865         [GTK] [WK2] Handle wheel event with delta zero
1866         https://bugs.webkit.org/show_bug.cgi?id=118973
1867
1868         Reviewed by Gustavo Noronha Silva.
1869
1870         Added handling of zero mouse scroll deltas in EventSenderProxy similar
1871         to WK1 and Qt/EFL ports.
1872
1873         fast/events/platform-wheelevent-with-delta-zero-crash.html is no longer
1874         failing on WK2.
1875
1876         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1877         (WTR::EventSenderProxy::mouseScrollBy):
1878
1879 2013-07-23  Andreas Kling  <akling@apple.com>
1880
1881         REGRESSION(r150867): FrameView auto-sizing + delegate denied image load may cause StyleResolver to re-enter itself.
1882         <rdar://problem/14324895>
1883         <http://webkit.org/b/119023>
1884
1885         Reviewed by Simon Fraser.
1886
1887         Add a test for this rather specific problem.
1888
1889         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1890         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm: Added.
1891         (TestWebKitAPI::TEST):
1892         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp: Added.
1893         (TestWebKitAPI::DenyWillSendRequestTest::DenyWillSendRequestTest):
1894         (TestWebKitAPI::DenyWillSendRequestTest::willSendRequestForFrame):
1895         (TestWebKitAPI::DenyWillSendRequestTest::didCreatePage):
1896
1897 2013-07-23  Tim Horton  <timothy_horton@apple.com>
1898
1899         Add a test for plug-in unavailability indicator obscurity detection
1900         https://bugs.webkit.org/show_bug.cgi?id=119007
1901
1902         Reviewed by Anders Carlsson.
1903
1904         Expose the ability to block plug-ins via pluginLoadPolicy to testRunner.
1905
1906         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1907         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1908         (WTR::TestRunner::setBlockAllPlugins):
1909         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1910         * WebKitTestRunner/TestInvocation.cpp:
1911         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1912         Add testRunner.setBlockAllPlugins function (and corresponding message to
1913         forward it through to TestController).
1914
1915         * WebKitTestRunner/TestController.cpp:
1916         Initialize m_shouldBlockAllPlugins to false (and drive-by initialize m_handlesAuthenticationChallenges).
1917
1918         (WTR::TestController::createWebViewWithOptions):
1919         Register our pluginLoadPolicy callback.
1920
1921         (WTR::TestController::resetStateToConsistentValues):
1922         Reset m_shouldBlockAllPlugins to false.
1923
1924         (WTR::TestController::pluginLoadPolicy):
1925         Return the existing plugin load policy, unless setBlockAllPlugins(true)
1926         was called, in which case we reject all plugins with kWKPluginLoadPolicyBlocked.
1927
1928         * WebKitTestRunner/TestController.h:
1929         (WTR::TestController::setBlockAllPlugins):
1930
1931 2013-07-21  Andreas Kling  <akling@apple.com>
1932
1933         KURL creates duplicate strings when completing data: URIs.
1934         <http://webkit.org/b/118952>
1935         <rdar://problem/14504480>
1936
1937         Reviewed by Anders Carlsson.
1938
1939         * TestWebKitAPI/Tests/WebCore/KURL.cpp:
1940         (TestWebKitAPI::TEST_F):
1941
1942 2013-07-19  Chris Fleizach  <cfleizach@apple.com>
1943
1944         AX: VoiceOver not detecting misspelled words don't work in all cases
1945         https://bugs.webkit.org/show_bug.cgi?id=118924
1946
1947         Reviewed by Tim Horton.
1948
1949         Make the misspelled detection dependent on both types of attributes being present.
1950
1951         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1952         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
1953         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1954         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
1955
1956 2013-07-19  Alex Christensen  <achristensen@apple.com>
1957
1958         Improved code coverage generation.
1959         https://bugs.webkit.org/show_bug.cgi?id=118926
1960
1961         Reviewed by Tim Horton.
1962
1963         * Scripts/build-webkit: Removed exception preventing ANGLE code coverage support.
1964         * Scripts/generate-coverage-data: Added --no-build to run-javascriptcore-tests call.
1965         (generateReport): Moved report generation to a subroutine.
1966
1967 2013-07-19  Stephanie Lewis  <slewis@apple.com>
1968
1969         <rdar://problem/14499595> pagination wk2 api test failing on ML (118928)
1970
1971         Unreviewed.
1972
1973         Rebaseline pagination test after http://trac.webkit.org/changeset/152911
1974
1975         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
1976         (TestWebKitAPI::didLayout):
1977
1978 2013-07-19  Daniel Bates  <dabates@apple.com>
1979
1980         Make Perl tools work when using git bisect with Git branch build setup
1981         https://bugs.webkit.org/show_bug.cgi?id=118512
1982
1983         Reviewed by Martin Robinson.
1984
1985         The various Perl tools (run-webkit-app, {debug, run}-safari, et cetera) don't work
1986         during a git bisect session with a Git branch build setup (i.e. git config
1987         core.webKitBranchBuild true). Specifically, the tools cannot find the branch-
1988         specific build of WebKit because they cannot determine the branch Git is on (since
1989         git bisect puts Git into a detached HEAD state). We should teach our tooling to
1990         parse the file .git/BISECT_START (created by git bisect start) for the name of the
1991         branch Git was on when we began a git bisect session. Then the tools can determine
1992         the path to the built WebKit.
1993
1994         * Scripts/VCSUtils.pm:
1995         (gitDirectory): Added.
1996         (gitBisectStartBranch): Added.
1997         (gitBranch): Modified to call gitBisectStartBranch() when we have a detached
1998         HEAD (e.g. running git bisect).
1999         (determineVCSRoot): Modified to call gitDirectory() to determine the path to
2000         the .git directory in the Git checkout.
2001
2002 2013-07-19  Alex Christensen  <achristensen@apple.com>
2003
2004         Added x64 configuration to Visual Studio build.
2005         https://bugs.webkit.org/show_bug.cgi?id=118888
2006
2007         Reviewed by Brent Fulgham.
2008
2009         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2010         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters:
2011         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
2012         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2013         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2014         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2015         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2016         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
2017         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
2018         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
2019         * win/record-memory/record-memory.vcxproj:
2020
2021 2013-07-19  Martin Robinson  <mrobinson@igalia.com>
2022
2023         Add a couple people to the MathML watchlist
2024         https://bugs.webkit.org/show_bug.cgi?id=118909
2025
2026         Reviewed by Andreas Kling.
2027
2028         Add a couple people to the MathML watchlist and add Kalyan's other
2029         email address to fix style checker warnings about the watchlist
2030         contents.
2031
2032         * Scripts/webkitpy/common/config/contributors.json: Add Frédéric to the
2033         list of contributors and add Kalyan's second email address.
2034         * Scripts/webkitpy/common/config/watchlist: Add myself and Frédéric to the MathML
2035         watchlist.
2036
2037 2013-07-19  Simon Pena  <simon.pena@samsung.com>
2038
2039         [GTK] Fix regression in DumpRenderTree introduced in r152782 by checking if uri is valid
2040         https://bugs.webkit.org/show_bug.cgi?id=118895
2041
2042         Reviewed by Philippe Normand.
2043
2044         In r152782 an uri is used to create an string representation without checking first if it
2045         is valid. That fails later when the string is used to check for existing redirections. This
2046         patch ensures that the uri is valid before using it.
2047
2048         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2049         (willSendRequestCallback): Ensure an uri is valid before using it.
2050
2051 2013-07-18  Timothy Hatcher  <timothy@apple.com>
2052
2053         Add extract-localizable-js-strings and use it for WebInspectorUI.
2054
2055         https://bugs.webkit.org/show_bug.cgi?id=118851
2056
2057         Reviewed by Joseph Pecoraro.
2058
2059         * Scripts/extract-localizable-js-strings: Added.
2060         * Scripts/extract-localizable-strings: Drive-by-fix: disable deprecated warnings about "goto".
2061         * Scripts/update-webkit-localizable-strings: Use extract-localizable-js-strings for
2062         the WebInspectorUI project.
2063
2064 2013-07-18  Brent Fulgham  <bfulgham@apple.com>
2065
2066         [Windows] Build correction #2 after r152861.
2067
2068         * WinLauncher/WinLauncher.cpp: Declare proper linkage.
2069
2070 2013-07-18  Brent Fulgham  <bfulgham@apple.com>
2071
2072         [Windows] Build correction after r152861.
2073
2074         * WinLauncher/WinLauncher.cpp: Don't reference private header.
2075
2076 2013-07-16  Brent Fulgham  <bfulgham@apple.com>
2077
2078         [Win] Support in-band text tracks.
2079         https://bugs.webkit.org/show_bug.cgi?id=103770
2080
2081         Reviewed by Eric Carlson.
2082
2083         Update WinLauncher to run in a CFRunLoop (rather than a hand-written Windows event loop) so that
2084         libdispatch and CFRunLoop elements are services during the run loop.
2085
2086         * WinLauncher/WinLauncher.cpp:
2087         (dllLauncherEntryPoint): Use CFRunLoopRun (rather than a Windows message loop) if running with
2088         a CoreFoundation (or CFLite) support library.
2089         * WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props: Added.
2090         * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props: Added.
2091         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add references to WinLauncherCF.props
2092         and WinLauncherCFLite.props.
2093
2094 2013-07-18  Roger Fong  <roger_fong@apple.com>
2095
2096         Unreviewed. Test enabling WinEWS tests now that queue is at a good state and NRWT with multiple processes is enabled.
2097
2098         * Scripts/webkitpy/common/config/ews.json:
2099
2100 2013-07-18  Daniel Bates  <dabates@apple.com>
2101
2102         REGRESSION (r132678): Tests that use SSL or port 8080 time out when run using old-run-webkit-tests
2103         https://bugs.webkit.org/show_bug.cgi?id=118854
2104         <rdar://problem/14081339>
2105
2106         Reviewed by David Kilzer.
2107
2108         Following <http://trac.webkit.org/changeset/132678> (https://bugs.webkit.org/show_bug.cgi?id=98602)
2109         Apache no longer listens to ports 8443 (SSL) and 8080. So, tests that use these ports time out when
2110         run using old-run-webkit-tests. We need to update old-run-webkit-tests to explicitly tell Apache to
2111         listen on these ports so that we can run tests that use port 8443 and 8080.
2112
2113         * Scripts/old-run-webkit-tests:
2114         (configureAndOpenHTTPDIfNeeded):
2115
2116 2013-07-17  Tim Horton  <timothy_horton@apple.com>
2117
2118         Update blocked/missing plug-in UI
2119         https://bugs.webkit.org/show_bug.cgi?id=118347
2120         <rdar://problem/14209318>
2121
2122         Reviewed by Sam Weinig.
2123
2124         * MiniBrowser/mac/WK2BrowserWindowController.m:
2125         (-[WK2BrowserWindowController awakeFromNib]):
2126         * WebKitTestRunner/TestController.cpp:
2127         (WTR::TestController::createWebViewWithOptions):
2128         Match new WKPageLoaderClient entry.
2129
2130 2013-07-17  Commit Queue  <commit-queue@webkit.org>
2131
2132         Unreviewed, rolling out r152701, r152703, r152739, r152754,
2133         and r152756.
2134         http://trac.webkit.org/changeset/152701
2135         http://trac.webkit.org/changeset/152703
2136         http://trac.webkit.org/changeset/152739
2137         http://trac.webkit.org/changeset/152754
2138         http://trac.webkit.org/changeset/152756
2139         https://bugs.webkit.org/show_bug.cgi?id=118821
2140
2141         this was a buggy fix and we're going to try something
2142         different (Requested by thorton on #webkit).
2143
2144         * MiniBrowser/mac/WK2BrowserWindowController.m:
2145         (-[WK2BrowserWindowController awakeFromNib]):
2146         * WebKitTestRunner/TestController.cpp:
2147         (WTR::TestController::createWebViewWithOptions):
2148
2149 2013-07-17  Commit Queue  <commit-queue@webkit.org>
2150
2151         Unreviewed, rolling out r151535.
2152         http://trac.webkit.org/changeset/151535
2153         https://bugs.webkit.org/show_bug.cgi?id=118804
2154
2155         Re-disable WinEWS tests (Requested by rfong on #webkit).
2156
2157         * Scripts/webkitpy/common/config/ews.json:
2158
2159 2013-07-17  Simon Pena  <simon.pena@samsung.com>
2160
2161         [GTK] Make DRT obbey testRunner's addURLToRedirect
2162         https://bugs.webkit.org/show_bug.cgi?id=118239
2163
2164         Reviewed by Gustavo Noronha Silva.
2165
2166         Support testRunner's addURLToRedirect in GTK's DRT, so it redirects
2167         to the proper URI when indicated.
2168
2169         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2170         (willSendRequestCallback):
2171
2172 2013-07-17  Gabor Abraham  <abrhm@inf.u-szeged.hu>
2173
2174         Add a new find-resolved-bugs command to webkit-patch.
2175         https://bugs.webkit.org/show_bug.cgi?id=118060
2176
2177         Reviewed by Csaba Osztrogonác.
2178
2179         * Scripts/webkitpy/tool/commands/queries.py:
2180         (PrintBaselines._platform_for_path):
2181         (FindResolvedBugs):
2182         (FindResolvedBugs.execute):
2183
2184 2013-07-16  Balazs Kelemen  <kbalazs@webkit.org>
2185
2186         [CMake] Undefined references should be detected at build time
2187         https://bugs.webkit.org/show_bug.cgi?id=110236
2188
2189         Reviewed by Christophe Dumez.
2190
2191         Add library dependencies that were not defined explicitly before.
2192
2193         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2194         * TestWebKitAPI/CMakeLists.txt:
2195         * WebKitTestRunner/CMakeLists.txt:
2196
2197 2013-07-16  Kwang Yul Seo  <skyul@company100.net>
2198
2199         check-webkit-style: "using namespace foo;" should be flagged as an error only in headers
2200         https://bugs.webkit.org/show_bug.cgi?id=118755
2201
2202         Reviewed by Ryosuke Niwa.
2203
2204         Fix r152719 to check "using namespace foo;" only in headers.
2205
2206         * Scripts/webkitpy/style/checkers/cpp.py:
2207         (check_using_namespace):
2208         (check_style):
2209         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2210         (WebKitStyleTest.test_using_namespace):
2211
2212 2013-07-16  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2213
2214         Get rid of multiple inheritance support from the bindings generators
2215         https://bugs.webkit.org/show_bug.cgi?id=118353
2216
2217         Reviewed by Kentaro Hara.
2218
2219         Update CodeGeneratorTestRunner.pm to use domInterface->parent instead of
2220         deprecated domInterface->parents.
2221
2222         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2223         (_parentInterface):
2224
2225 2013-07-16  Brian Holt  <brian.holt@samsung.com>
2226
2227         check-webkit-style: "using namespace foo;" should be flagged as an error in headers
2228         https://bugs.webkit.org/show_bug.cgi?id=57241
2229
2230         Reviewed by Ryosuke Niwa.
2231
2232         Added check for "using namespace foo" and unit test.
2233
2234         * Scripts/webkitpy/style/checkers/cpp.py:
2235         (check_using_namespace):
2236         (check_style):
2237         (CppChecker):
2238         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2239         (WebKitStyleTest.test_using_namespace):
2240
2241 2013-07-16  Anton Obzhirov  <a.obzhirov@samsung.com>
2242
2243         [GTK] fast/events/platform-wheelevent-with-delta-zero-crash.html is crashing
2244         https://bugs.webkit.org/show_bug.cgi?id=110222
2245
2246         Reviewed by Gustavo Noronha Silva.
2247
2248         Added handling of zero mouse scroll deltas in EventSender.
2249
2250         * DumpRenderTree/gtk/EventSender.cpp:
2251         (mouseScrollByCallback):
2252
2253 2013-07-16  Brian Holt  <brian.holt@samsung.com>
2254
2255         webkitpy: replace urllib with urllib2 for downloading additional modules
2256         https://bugs.webkit.org/show_bug.cgi?id=118671
2257
2258         Reviewed by Ryosuke Niwa.
2259
2260         Urllib2 is available whereever urllib is, but has better proxy support.
2261
2262         * Scripts/webkitpy/common/system/autoinstall.py:
2263         (AutoInstaller._download_to_stream):
2264
2265 2013-07-16  Krzysztof Czech  <k.czech@samsung.com>
2266
2267         [ATK] Adds support for aria-haspopup property.
2268         https://bugs.webkit.org/show_bug.cgi?id=117834
2269
2270         Reviewed by Christophe Dumez.
2271
2272         Adds implementation for testing aria-haspopup property.
2273
2274         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2275         (getAttributeSetValueForId):
2276         (AccessibilityUIElement::stringAttributeValue):
2277         (AccessibilityUIElement::hasPopup):
2278         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2279         (WTR::getAttributeSetValueForId):
2280         (WTR::AccessibilityUIElement::stringAttributeValue):
2281         (WTR::AccessibilityUIElement::hasPopup):
2282
2283 2013-07-16  Michael Brüning  <michael.bruning@digia.com>
2284
2285         [Qt] Replace Nokia references.
2286         https://bugs.webkit.org/show_bug.cgi?id=118728
2287
2288         Reviewed by Simon Hausmann.
2289
2290         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2291         (MiniBrowserApplication::MiniBrowserApplication):
2292         * QtTestBrowser/qttestbrowser.cpp:
2293         (LauncherApplication::LauncherApplication):
2294
2295 2013-07-15  Tim Horton  <timothy_horton@apple.com>
2296
2297         Update blocked/missing plug-in UI
2298         https://bugs.webkit.org/show_bug.cgi?id=118347
2299         <rdar://problem/14209318>
2300
2301         Reviewed by Sam Weinig.
2302
2303         * MiniBrowser/mac/WK2BrowserWindowController.m:
2304         (-[WK2BrowserWindowController awakeFromNib]):
2305         * WebKitTestRunner/TestController.cpp:
2306         (WTR::TestController::createWebViewWithOptions):
2307         Match new WKPageLoaderClient entry.
2308
2309 2013-07-15  Chris Fleizach  <cfleizach@apple.com>
2310
2311         Update James Craig's email address.
2312
2313         * Scripts/webkitpy/common/config/contributors.json:
2314
2315 2013-07-15  Dong-Gwan Kim  <donggwan.kim@samsung.com>
2316
2317         [EFL] Add fallback for TestWebKitAPI if opengl is not available.
2318         https://bugs.webkit.org/show_bug.cgi?id=118583
2319
2320         Reviewed by Christophe Dumez.
2321
2322         There're many fails on efl webkit2 API test if opengl is not available.
2323         So, add fallback to non-opengl evas engine.
2324
2325         * TestWebKitAPI/efl/PlatformWebView.cpp:
2326         (TestWebKitAPI::initEcoreEvas):
2327
2328 2013-07-15  Brian Holt  <brian.holt@samsung.com>
2329
2330         check-webkit-style: Ignore false positive: Instance of 'Popen' has no 'pid' member
2331         https://bugs.webkit.org/show_bug.cgi?id=118592
2332
2333         Reviewed by Martin Robinson.
2334
2335         Added a suppression for pylint false positives and a unit test.
2336
2337         * Scripts/webkitpy/style/checkers/python.py:
2338         (Pylinter):
2339         * Scripts/webkitpy/style/checkers/python_unittest.py:
2340         (PythonCheckerTest.test_check):
2341         (PythonCheckerTest):
2342         (PythonCheckerTest.test_pylint_false_positives):
2343         (PythonCheckerTest.test_pylint_false_positives._mock_handle_style_error):
2344         * Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Added.
2345         (test_popen):
2346
2347 2013-07-15  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2348
2349         [GTK] Increase the JHBuild version of GStreamer to 1.0.7
2350         https://bugs.webkit.org/show_bug.cgi?id=115166
2351
2352         Reviewed by Philippe Normand.
2353
2354         * gtk/jhbuild.modules: Bumping GStreamer version up to 1.0.8.
2355
2356 2013-07-12  Kwang Yul Seo  <skyul@company100.net>
2357
2358         Unreviewed. Add an email address and update my domain of experts.
2359
2360         * Scripts/webkitpy/common/config/contributors.json:
2361
2362 2013-07-12  Emanuele Aina  <emanuele.aina@collabora.com>
2363
2364         [jhbuild] Avoid restarting from scratch failed initial checkouts
2365         https://bugs.webkit.org/show_bug.cgi?id=118603
2366
2367         Reviewed by Martin Robinson.
2368
2369         If the initial checkout is interrupted midway (eg. because the internet
2370         connection went down) config files do not get generated and that causes
2371         the next checkout to start from scratch (the missing files cause the
2372         script to delete the build root and the downloaded sources).
2373
2374         By generating the files before invoking jhbuild, subsequent runs are able
2375         to start where the previous run left.
2376
2377         * Scripts/update-webkit-libs-jhbuild:
2378         (saveJhbuildMd5): invoke it before runJhbuild().
2379
2380 2013-07-12  Brent Fulgham  <bfulgham@apple.com>
2381
2382         [Windows] Remove single-worker restriction on tests.
2383
2384         * Scripts/webkitpy/port/win.py: Remove restriction of one worker.
2385
2386 2013-07-12  Commit Queue  <commit-queue@webkit.org>
2387
2388         Unreviewed, rolling out r152599.
2389         http://trac.webkit.org/changeset/152599
2390         https://bugs.webkit.org/show_bug.cgi?id=118612
2391
2392         This patch includes a failing unit test (Requested by
2393         mrobinson on #webkit).
2394
2395         * Scripts/webkitpy/style/checkers/python.py:
2396         (Pylinter):
2397         * Scripts/webkitpy/style/checkers/python_unittest.py:
2398         (PythonCheckerTest.test_check):
2399         * Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Removed.
2400
2401 2013-07-12  Emanuele Aina  <emanuele.aina@collabora.com>
2402
2403         [Tools] Ignore missing GNUmakefile when detecting previous arch in build-webkit
2404         https://bugs.webkit.org/show_bug.cgi?id=91223
2405
2406         Reviewed by Martin Robinson.
2407
2408         When run on a clean checkout, `build-webkit` complains that no
2409         GNUmakefile exists when trying to detect the previously configured
2410         architecture, but in this case there's no previous configuration so
2411         the warning is pointless.
2412
2413         * Scripts/webkitdirs.pm:
2414         (determineArchitecture): Redirect grep stderr to /dev/null.
2415
2416 2013-07-12  Brian Holt  <brian.holt@samsung.com>
2417
2418         check-webkit-style: Ignore false positive: Instance of 'Popen' has no 'pid' member
2419         https://bugs.webkit.org/show_bug.cgi?id=118592
2420
2421         Reviewed by Martin Robinson.
2422
2423         Added a suppression for pylint false positives and a unit test.
2424
2425         * Scripts/webkitpy/style/checkers/python.py:
2426         (Pylinter):
2427         * Scripts/webkitpy/style/checkers/python_unittest.py:
2428         (PythonCheckerTest.test_check):
2429         (PythonCheckerTest):
2430         (PythonCheckerTest.test_pylint_false_positives):
2431         (PythonCheckerTest.test_pylint_false_positives._mock_handle_pylint_false_positives):
2432         * Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Added.
2433         (test_popen):
2434
2435 2013-07-11  Arnaud Renevier  <a.renevier@samsung.com>
2436
2437         Unreviewed. Add myself as a committer.
2438
2439         * Scripts/webkitpy/common/config/contributors.json:
2440
2441 2013-07-10  Sergio Correia  <sergio.correia@openbossa.org>
2442
2443         Handle "load,provisional,failed" with the on_error callback on EFL MiniBrowser
2444         https://bugs.webkit.org/show_bug.cgi?id=118538
2445
2446         Reviewed by Christophe Dumez.
2447
2448         When attempting some odd url such as ``foo'', MiniBrowser will now show an
2449         error message such as "Cannot resolve hostname (foo)".
2450
2451         Previously, it had the following behavior if MiniBrowser was started with
2452         such urls, e.g ``./MiniBrowser foo'':
2453
2454         - Debug:
2455         It wouldt hit WebKit2/Platform/CoreIPC/unix/ConnectionUnix.cpp(460) and crash.
2456
2457         - Release:
2458         No asserts, naturally, but the view would remain blank, even if we tried to
2459         change to a valid url.
2460
2461         * MiniBrowser/efl/main.c:
2462         (window_create):
2463
2464 2013-07-10  Simon Pena  <simon.pena@samsung.com>
2465
2466         [GTK] WebKitTestRunner tries to remove an already deleted event in EventSenderProxy::replaySavedEvents
2467         https://bugs.webkit.org/show_bug.cgi?id=118509
2468
2469         Reviewed by Martin Robinson.
2470
2471         In EventSenderProxy::replaySavedEvents WebKitTestRunner can crash
2472         when trying to remove an event already removed, if another event is
2473         processed in the middle. By using a Deque's takeFirst, we ensure the
2474         element is removed before we dispatch it.
2475
2476         fast/events/mousedown-inside-dragstart-should-not-cause-crash.html no longer
2477         crashes after this fix is added.
2478
2479         * WebKitTestRunner/EventSenderProxy.h: Use a Deque instead of Vector in GTK
2480         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2481         (WTR::EventSenderProxy::replaySavedEvents): Use takeFirst to retrieve the event
2482         from the queue.
2483
2484 2013-07-09  Ryuan Choi  <ryuan.choi@samsung.com>
2485
2486         [EFL] Add ewk_view_device_pixel_ratio_set
2487         https://bugs.webkit.org/show_bug.cgi?id=118521
2488
2489         Reviewed by Gyuyoung Kim.
2490
2491         * EWebLauncher/main.c: Added new option(-r) to test device pixel ratio.
2492         (windowCreate):
2493         (parseUserArguments):
2494
2495 2013-07-09  Bruno de Oliveira Abinader  <brunoabinader@gmail.com>
2496
2497         Unreviewed change of my email addresses.
2498         https://bugs.webkit.org/show_bug.cgi?id=100122
2499
2500         * Scripts/webkitpy/common/config/contributors.json:
2501
2502 2013-07-09  Anders Carlsson  <andersca@apple.com>
2503
2504         DumpRenderTree should stop sending unsupported URLs to NSWorkspace
2505         https://bugs.webkit.org/show_bug.cgi?id=118514
2506         <rdar://problem/13686836>
2507
2508         Reviewed by Sam Weinig.
2509
2510         Add a new default policy delegate and override decidePolicyForNavigationAction: to not pass unhandled URLs to NSWorkspace.
2511
2512         * DumpRenderTree/DefaultPolicyDelegate.h: Added.
2513         * DumpRenderTree/DefaultPolicyDelegate.m: Added.
2514         (-[DefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2515         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2516         Add DefaultPolicyDelegate.h and DefaultPolicyDelegate.m.
2517
2518         * DumpRenderTree/mac/DumpRenderTree.mm:
2519         (allocateGlobalControllers):
2520         Allocate a DefaultPolicyDelegate object.
2521
2522         (resetWebViewToConsistentStateBeforeTesting):
2523         Set the policy delegate to the default policy delegate.
2524
2525         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2526         Declare the defaultPolicyDelegate object.
2527
2528         * DumpRenderTree/mac/TestRunnerMac.mm:
2529         (TestRunner::setCustomPolicyDelegate):
2530         Set the policy delegate to the default delegate if setDelegate is false.
2531
2532 2013-07-08  Zan Dobersek  <zdobersek@igalia.com>
2533
2534         KURL unit test fixture class should have a meaningful name
2535         https://bugs.webkit.org/show_bug.cgi?id=118467
2536
2537         Reviewed by Sam Weinig.
2538
2539         * TestWebKitAPI/Tests/WebCore/KURL.cpp:
2540         (TestWebKitAPI::TEST_F): Use 'KURLTest' as the name for the KURL unit test's fixture class
2541         instead of the generic and inappropriate 'WebCore' name.
2542
2543 2013-07-08  Antti Koivisto  <antti@apple.com>
2544
2545         Add Deque::removeLast
2546         https://bugs.webkit.org/show_bug.cgi?id=118466
2547
2548         Reviewed by Andreas Kling.
2549
2550         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2551         * TestWebKitAPI/Tests/WTF/Deque.cpp: Added.
2552         (TestWebKitAPI::TEST):
2553
2554 2013-07-08  Brian Holt  <brian.holt@samsung.com>
2555
2556         [GTK] Leak: GFile* leaking in beginDragWithFilesCallback
2557         https://bugs.webkit.org/show_bug.cgi?id=118412
2558
2559         Reviewed by Martin Robinson.
2560
2561         An adoptRef is required to balance ref and deref calls.
2562
2563         * DumpRenderTree/gtk/EventSender.cpp:
2564         (beginDragWithFilesCallback):
2565
2566 2013-07-06  Sergio Correia  <sergio.correia@openbossa.org>
2567
2568         Update list of EFL WK2 API tests
2569         https://bugs.webkit.org/show_bug.cgi?id=118443
2570
2571         Reviewed by Christophe Dumez.
2572
2573         The following tests were included:
2574
2575         Passing:
2576         - CloseThenTerminate
2577         - DidAssociateFormControls
2578         - PageVisibilityState
2579         - ResponsivenessTimerDoesntFireEarly
2580         - TerminateTwice
2581         - WillLoad
2582
2583         Failing:
2584         - ResizeReversePaginatedWebView
2585         - ScrollPinningBehaviors
2586
2587         This patch also modified ``test_webkit2_api_BINARIES'' list so that it is in
2588         alphabetical order.
2589
2590         * TestWebKitAPI/CMakeLists.txt: Added Bundles for included tests.
2591         * TestWebKitAPI/PlatformEfl.cmake: Added a few tests.
2592
2593 2013-07-05  Tim Horton  <timothy_horton@apple.com>
2594
2595         Fix r152265: FrameView's pagination mode is only one of two, and the logic was totally wrong
2596         https://bugs.webkit.org/show_bug.cgi?id=118439
2597         <rdar://problem/14366120>
2598
2599         Reviewed by Anders Carlsson.
2600
2601         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
2602         (TestWebKitAPI::didLayout):
2603         (TestWebKitAPI::TEST):
2604         - Make use of EXPECT_JS_EQ instead of manually doing JavaScript stuff.
2605         - Assert that we got the right number of pages for sanity.
2606         - Reduce the page gap size so that DrawingAreaImpl doesn't try to allocate
2607             so much memory that SharedMemory asserts and makes the test time out.
2608         - Use didFirstLayoutAfterSuppressedIncrementalRendering instead of Paint
2609             because paint doesn't fire if the window is offscreen.
2610
2611 2013-07-05  Tim Horton  <timothy_horton@apple.com>
2612
2613         [wk2] Add API to lock the scroll position at the top or bottom of the page
2614         https://bugs.webkit.org/show_bug.cgi?id=118429
2615         <rdar://problem/14120323>
2616
2617         Reviewed by Anders Carlsson.
2618
2619         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2620         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp: Added.
2621         (TestWebKitAPI::didFinishDocumentLoadForFrame):
2622         (TestWebKitAPI::TEST):
2623         Add a test that ensures that the three pinning modes (DoNotPin, PinToTop, PinToBottom)
2624         all work correctly in the face of resizing the view and scrolling from JS.
2625
2626 2013-07-05  Michael Pruett  <michael@68k.org>
2627
2628         Unreviewed. Add myself as a committer.
2629
2630         * Scripts/webkitpy/common/config/contributors.json:
2631
2632 2013-07-05  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2633
2634         [GTK] WebKit2 test TestWebKitFaviconDatabase times out with recent glib
2635         https://bugs.webkit.org/show_bug.cgi?id=111434
2636
2637         Reviewed by Carlos Garcia Campos.
2638
2639         * Scripts/run-gtk-tests:
2640         (TestRunner): Unskipped TestWebKitFaviconDatabase tests.
2641
2642 2013-07-04  Viatcheslav Ostapenko  <sl.ostapenko@samsung.com>
2643
2644         [EFL] DumpRenderTree doesn't run if "opengl_x11" engine is not available
2645         https://bugs.webkit.org/show_bug.cgi?id=118370
2646
2647         Reviewed by Christophe Dumez.
2648
2649         Add fallback to software X11 engine if opengl_x11 engine creation fails.
2650
2651         * DumpRenderTree/efl/DumpRenderTree.cpp:
2652         (initEcoreEvas):
2653
2654 2013-07-04  Brian Holt  <brian.holt@samsung.com>
2655
2656         [ATK] Leak: AtkAttributeSet* should be freed
2657         https://bugs.webkit.org/show_bug.cgi?id=118307
2658
2659         Reviewed by Christophe Dumez.
2660
2661         Fixed memory leaks for AtkAttributeSet by calling
2662         atk_attribute_set_free().
2663
2664         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
2665         (AccessibilityController::childElementById):
2666         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2667         (getAtkAttributeSetAsString):
2668         (AccessibilityUIElement::allAttributes):
2669         (AccessibilityUIElement::stringAttributeValue):
2670         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2671         (WTR::childElementById):
2672         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2673         (WTR::getAtkAttributeSetAsString):
2674         (WTR::AccessibilityUIElement::allAttributes):
2675         (WTR::AccessibilityUIElement::stringAttributeValue):
2676
2677 2013-07-03  David Farler  <dfarler@apple.com>
2678
2679         Add Makefile to WebKitLauncher
2680         https://bugs.webkit.org/show_bug.cgi?id=118365
2681
2682         Reviewed by Mark Rowe.
2683
2684         * WebKitLauncher/Makefile: Added.
2685
2686 2013-07-03  Brian Holt  <brian.holt@samsung.com>
2687
2688         [ATK] Leak: more leaks in AccessibilityUIElement
2689         https://bugs.webkit.org/show_bug.cgi?id=118362
2690
2691         Reviewed by Christophe Dumez.
2692
2693         Free the memory created by g_strdup_printf.
2694
2695         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2696         (AccessibilityUIElement::language):
2697         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2698         (WTR::AccessibilityUIElement::language):
2699
2700 2013-07-03  Jer Noble  <jer.noble@apple.com>
2701
2702         Xcode often gets in a state where the debugger is completely unresponsive
2703         https://bugs.webkit.org/show_bug.cgi?id=118157
2704
2705         The GetPointeeData() operations we use to retrieve strings is extremely expensive.
2706         Rather than pull the character data out of the debugger one byte at a time
2707         through the GetPointeeData() API, retrieve the memory contents of the string through
2708         the ReadMemory() API, and convert the retrieved memory into a python string.
2709
2710         Reviewed by Anders Carlsson.
2711
2712         * lldb/lldb_webkit.py:
2713         (__lldb_init_module.lldb_webkit):
2714         (guess_string_length):
2715         (ustring_to_string):
2716         (lstring_to_string):
2717
2718 2013-07-03  Morten Stenshorne  <mstensho@opera.com>
2719
2720         [GTK] Let F5 refresh the page in MiniBrowser
2721         https://bugs.webkit.org/show_bug.cgi?id=117638
2722
2723         Reviewed by Carlos Garcia Campos.
2724
2725         Also use the correct icon for the refresh button that was already there.
2726
2727         * MiniBrowser/gtk/BrowserWindow.c:
2728         (browser_window_init):
2729
2730 2013-07-02  Kondapally Kalyan  <kalyan.kondapally@intel.com>
2731
2732         Unreviewed. Add my email to a few watchlists.
2733
2734         * Scripts/webkitpy/common/config/watchlist:
2735
2736 2013-07-02  David Farler  <dfarler@apple.com>
2737
2738         Unreviewed. Adding myself to contributors.json.
2739
2740         * Scripts/webkitpy/common/config/contributors.json:
2741
2742 2013-07-02  Brian Holt  <brian.holt@samsung.com>
2743
2744         [ATK] Leak: leaks in AccessibilityUIElement
2745         https://bugs.webkit.org/show_bug.cgi?id=118297
2746
2747         Fixed memory leak.
2748
2749         Reviewed by Christophe Dumez.
2750
2751         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2752         (AccessibilityUIElement::stringValue):
2753
2754 2013-07-02  Byungwoo Lee  <bw80.lee@samsung.com>
2755
2756         Fix WebKitTestRunner crashes.
2757         https://bugs.webkit.org/show_bug.cgi?id=117630
2758
2759         Reviewed by Darin Adler.
2760
2761         Create static function to dump for WebProcess unresponsiveness status,
2762         and use it before calling TestController::runTest().
2763
2764         Accessing TestController::m_currentInvocation before calling
2765         TestController::runTest() can make crash because the invocation
2766         instance will be assigned at the function.
2767
2768         * WebKitTestRunner/TestController.cpp:
2769         (WTR::TestController::run):
2770         * WebKitTestRunner/TestInvocation.cpp:
2771         (WTR::TestInvocation::dumpWebProcessUnresponsiveness):
2772         * WebKitTestRunner/TestInvocation.h:
2773
2774 2013-07-02  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2775
2776         [Qt][WK1] Support WebGL with EGL on Linux
2777         https://bugs.webkit.org/show_bug.cgi?id=118251
2778
2779         Reviewed by Kenneth Rohde Christiansen.
2780
2781         * qmake/mkspecs/features/features.prf:
2782
2783 2013-07-01  Nick Diego Yamane  <nick.yamane@openbossa.org>
2784
2785         [Efl][Gtk] Look at WEBKIT_OUTPUTDIR instead of WEBKITOUTPUTDIR in jhbuildrc
2786         https://bugs.webkit.org/show_bug.cgi?id=118267
2787
2788         Reviewed by Gyuyoung Kim.
2789
2790         After r152226 (from https://bugs.webkit.org/show_bug.cgi?id=117249)
2791         WEBKIT_OUTPUTDIR should be used instead of WEBKITOUPUTDIR. However
2792         Efl's jhbuildrc is still using the WEBKITOUTPUTDIR environment variable.
2793
2794         * efl/jhbuildrc:
2795         * gtk/jhbuildrc:
2796
2797 2013-07-01  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
2798
2799         [GTK] Remove unsupported AC backends
2800         https://bugs.webkit.org/show_bug.cgi?id=117362
2801
2802         Reviewed by Martin Robinson.
2803
2804         * gtk/jhbuild-optional.modules: no longer needs clutter-gtk, clutter
2805         and cogl, so removed.
2806
2807 2013-07-01  Timothy Hatcher  <timothy@apple.com>
2808
2809         Link to WebInspectorUI.framework at build time instead of soft linking.
2810
2811         https://bugs.webkit.org/show_bug.cgi?id=118261
2812
2813         Reviewed by Joseph Pecoraro.
2814
2815         * Scripts/build-webkit: Build WebInspectorUI before WebKit and WebKit2.
2816
2817 2013-07-01  Tim Horton  <timothy_horton@apple.com>
2818
2819         Maximum scroll position can be negative in some cases
2820         https://bugs.webkit.org/show_bug.cgi?id=118175
2821         <rdar://problem/14301217>
2822
2823         Reviewed by Anders Carlsson.
2824
2825         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2826         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp: Added.
2827         (TestWebKitAPI::didRunJavaScript):
2828         (TestWebKitAPI::didLayout):
2829         (TestWebKitAPI::TEST):
2830         * TestWebKitAPI/Tests/WebKit2/lots-of-text-vertical-lr.html: Added.
2831         Add a test that loads a vertical-lr document, paginates it horizontally
2832         from right to left, resizes the view to fit the entire document, and
2833         verifies that the scroll position is negative, as it must be for the
2834         document to be enclosed by the view.
2835
2836 2013-07-01  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2837
2838         [EFL][GTK] Migrate from WEBKITOUTPUTDIR to WEBKIT_OUTPUTDIR
2839         https://bugs.webkit.org/show_bug.cgi?id=117249
2840
2841         Reviewed by Brent Fulgham.
2842
2843         Finish converting all use cases of WEBKITOUTPUTDIR to
2844         WEBKIT_OUTPUTDIR, which seems to be preferred these days.
2845
2846         * DumpRenderTree/efl/FontManagement.cpp:
2847         (getCustomBuildDir):
2848         (getPlatformFontsPath):
2849         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2850         (getOutputDir):
2851         * Scripts/webkitdirs.pm:
2852         (determineBaseProductDir):
2853         (usesPerConfigurationBuildDirectory):
2854         * Scripts/webkitpy/port/base.py:
2855         (Port.to.setup_environ_for_server):
2856         * Scripts/webkitpy/port/driver.py:
2857         (Driver._setup_environ_for_driver):
2858         * Scripts/webkitpy/port/gtk.py:
2859         (GtkPort.setup_environ_for_server):
2860         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2861         (WTR::getOutputDir):
2862         * jhbuild/jhbuildutils.py:
2863         (get_dependencies_path):
2864
2865 2013-07-01  Rafael Brandao  <rafael.lobo@webkit.org>
2866
2867         Unreviewed change of my email address.
2868
2869         * Scripts/webkitpy/common/config/contributors.json:
2870
2871 2013-06-28  Andreas Kling  <akling@apple.com>
2872
2873         Fix Windows builds after deprecatedCharactersWithNullTermination() removal.
2874
2875         * DumpRenderTree/win/DumpRenderTree.cpp:
2876         (addFontFallbackIfPresent):
2877         (removeFontFallbackIfPresent):
2878
2879 2013-06-28  Anders Carlsson  <andersca@apple.com>
2880
2881         Remove String::deprecatedCharactersWithNullTermination() and related code
2882         https://bugs.webkit.org/show_bug.cgi?id=118211
2883
2884         Reviewed by Benjamin Poulain.
2885
2886         Remove all hasTerminatingNullCharacter() checks.
2887
2888         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
2889         (TestWebKitAPI::TEST):
2890         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2891         (TestWebKitAPI::TEST):
2892         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2893         (TestWebKitAPI::TEST):
2894
2895 2013-06-28  Alexey Proskuryakov  <ap@apple.com>
2896
2897         [Mac] Crash when loading is stopped from -didReceiveResponse
2898         https://bugs.webkit.org/show_bug.cgi?id=118209
2899         <rdar://problem/14259249>
2900
2901         Reviewed by Brady Eidson.
2902
2903         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2904         * TestWebKitAPI/Tests/mac/StopLoadingFromDidReceiveResponse.html: Added.
2905         * TestWebKitAPI/Tests/mac/StopLoadingFromDidReceiveResponse.mm: Added.
2906         (-[StopLoadingFromDidReceiveResponse webView:resource:didReceiveResponse:fromDataSource:]):
2907         (TestWebKitAPI::TEST):
2908
2909 2013-06-28  Andy Estes  <aestes@apple.com>
2910
2911         [Mac] Newer versions of clang use a default template instantiation depth that is too small for TestWebKitAPI
2912         https://bugs.webkit.org/show_bug.cgi?id=118208
2913
2914         Reviewed by Mark Rowe.
2915
2916         Newer versions of clang use a default template depth of 128, but this
2917         is too small for Tests/WTF/HashSet.cpp. Use 256 instead, which was the
2918         previous default.
2919
2920         Clang lowered the default to keep recursive template instantiation
2921         from overflowing the stack (see <rdar://problem/13935016>), but
2922         TestWebKitAPI's C++ files don't trigger a stack overflow even with the
2923         higher limit. If for some reason this starts happening then we can
2924         lower the limit back down.
2925
2926         * TestWebKitAPI/Configurations/Base.xcconfig: Build TestWebKitAPI with -ftemplate-depth=256.
2927
2928 2013-06-28  Nick Diego Yamane  <nick.yamane@openbossa.org>
2929
2930         [Tools] Add support for "webKitBranchBuild" git option when calculating jhbuildPath
2931         https://bugs.webkit.org/show_bug.cgi?id=118195
2932
2933         Reviewed by Daniel Bates.
2934
2935         Currently, ports that use jhbuild fail to determine jhbuild directory
2936         when "webKitBranchBuild" git configuration property is enabled. To reproduce
2937         that issue in Efl port, enable that flag in .git/config, switch to a git branch
2938         other than "master" and try to build webkit. The build will fail to
2939         locate dependencies due to lack of pkg-config paths which should be set
2940         by jhbuild.
2941
2942         For more details about "webKitBranchBuild" option, see:
2943         https://trac.webkit.org/wiki/UsingGitWithWebKit
2944
2945         * Scripts/webkitdirs.pm:
2946         (getJhbuildPath):
2947
2948 2013-06-28  Jessie Berlin  <jberlin@apple.com>
2949
2950         WebKitTestRunner should disable automatic quote and dash substitution like DumpRenderTree does
2951         https://bugs.webkit.org/show_bug.cgi?id=118201
2952
2953         Reviewed by Dean Jackson.
2954
2955         * WebKitTestRunner/mac/main.mm:
2956         (main):
2957         Modify NSUserDefaults directly since setAutomaticQuoteSubstitutionEnabled and
2958         setAutomaticDashSubstitutionEnabled are not exposed on WKView.
2959
2960 2013-06-28  David Farler  <dfarler@apple.com>
2961
2962         Upstream WebKit Nightly’s WebKitLauncher
2963         https://bugs.webkit.org/show_bug.cgi?id=117418
2964
2965         Reviewed by Mark Rowe.
2966
2967         Literal patch from Nightly's OpenSource repo.
2968
2969         * WebKitLauncher/Configurations/Base.xcconfig:
2970         * WebKitLauncher/Configurations/WebKitLauncher.xcconfig:
2971         * WebKitLauncher/Info.plist:
2972         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2973         * WebKitLauncher/WebKitLauncherURLProtocol.m:
2974         (+[WebKitLauncherURLProtocol load]):
2975         (+[WebKitLauncherURLProtocol canInitWithRequest:]):
2976         (-[WebKitLauncherURLProtocol startLoading]):
2977         (-[WebKitLauncherURLProtocol handleWebKitVersionInformation]):
2978         (-[WebKitLauncherURLProtocol resourceNotFound]):
2979         * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
2980         (initializeSparkle):
2981         * WebKitLauncher/main.m:
2982         (determineExecutablePath):
2983         (currentMacOSXVersion):
2984         (main):
2985         * WebKitLauncher/start.html:
2986
2987 2013-06-28  Balazs Kelemen  <b.kelemen@samsung.com>
2988
2989         [EFL] back/forward keyboard shortcuts are non-intuitive
2990         https://bugs.webkit.org/show_bug.cgi?id=118193
2991
2992         Reviewed by Christophe Dumez.
2993
2994         Changed shortcuts for go-back/go-forward to alt+left and alt+right.
2995
2996         * EWebLauncher/main.c:
2997         (on_key_down):
2998         * MiniBrowser/efl/main.c:
2999         (on_key_down):
3000
3001 2013-06-28  Roger Fong  <roger_fong@apple.com>
3002
3003         Enable AVFoundation in Web Prefs for WinLauncher and DumpRenderTree on Windows.
3004         https://bugs.webkit.org/show_bug.cgi?id=118194.
3005
3006         Reviewed by Brent Fulgham.
3007
3008         * DumpRenderTree/win/DumpRenderTree.cpp:
3009         (dllLauncherEntryPoint):
3010         * WinLauncher/WinLauncher.cpp:
3011         (dllLauncherEntryPoint):
3012
3013 2013-06-28  Roger Fong  <roger_fong@apple.com>
3014
3015         Unreviewed build fix for AppleWin port. Fix some file paths.
3016
3017         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
3018         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
3019
3020 2013-06-27  Roger Fong  <roger_fong@apple.com>
3021
3022         Add IAccessibilityDelegate implementation to WinLauncher for testing purposes.
3023         https://bugs.webkit.org/show_bug.cgi?id=118160.
3024
3025         Reviewed by Brent Fulgham.
3026
3027         * WinLauncher/AccessibilityDelegate.cpp: Added.
3028         (AccessibilityDelegate::QueryInterface):
3029         (AccessibilityDelegate::AddRef):
3030         (AccessibilityDelegate::Release):
3031         (AccessibilityDelegate::fireFrameLoadStartedEvents): Just returns S_OK;
3032         (AccessibilityDelegate::fireFrameLoadFinishedEvents): Ditto.
3033         * WinLauncher/AccessibilityDelegate.h: Added.
3034         (AccessibilityDelegate::AccessibilityDelegate):
3035         * WinLauncher/WinLauncher.cpp:
3036         (dllLauncherEntryPoint):
3037         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
3038         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
3039
3040 2013-06-28  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3041
3042         Clean up temporary files created by the bindings test script
3043         https://bugs.webkit.org/show_bug.cgi?id=118189
3044
3045         Reviewed by Kentaro Hara.
3046
3047         Remove temporary files created by preprocess-idls.pl script after
3048         the bindings tests are executed.
3049
3050         Based on Blink 153236 by Kentaro Hara <haraken@chromium.org>.
3051
3052         * Scripts/webkitpy/bindings/main.py:
3053         (BindingsTests.main):
3054
3055 2013-06-26  Dean Jackson  <dino@apple.com>
3056
3057         [Mac] Add Mavericks system font to Test systems
3058         https://bugs.webkit.org/show_bug.cgi?id=118109
3059
3060         Reviewed by Simon Fraser.
3061
3062         OS X Mavericks uses a different font for system controls. Tell DRT and
3063         WKTR about them otherwise they use a fallback font. Unfortunately the
3064         fonts are hidden (not found in the list of available fonts) so I
3065         had to add them manually.
3066
3067         Even though there is only one at the moment, I implemented this
3068         as a set so it will be easier to add new fonts if necessary.
3069
3070         * DumpRenderTree/mac/DumpRenderTree.mm:
3071         (allowedFontFamilySet): Fixed typo.
3072         (systemHiddenFontFamilySet): New method that returns the system control font.
3073         (drt_NSFontManager_availableFonts): Merge the hidden fonts.
3074         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3075         (WTR::allowedFontFamilySet): Fixed typo.
3076         (WTR::systemHiddenFontFamilySet): As above.
3077         (WTR::wtr_NSFontManager_availableFonts):
3078
3079 2013-06-27  Anders Carlsson  <andersca@apple.com>
3080
3081         Get rid of the last uses of deprecatedCharactersWithNullTermination()
3082         https://bugs.webkit.org/show_bug.cgi?id=118159
3083
3084         Reviewed by Andreas Kling.
3085
3086         Replace calls to deprecatedCharactersWithNullTermination() with charactersWithNullTermination().data().
3087
3088         * DumpRenderTree/win/DumpRenderTree.cpp:
3089         (findFontFallback):
3090
3091 2013-06-27  Bem Jones-Bey  <bjonesbe@adobe.com>
3092
3093         Sync up w3c import script with changes in Blink
3094         https://bugs.webkit.org/show_bug.cgi?id=118149
3095
3096         Reviewed by Dirk Pranke.
3097
3098         This is a port of the following blink changes:
3099
3100         https://codereview.chromium.org/15366004
3101         https://chromiumcodereview.appspot.com/15592005
3102         https://codereview.chromium.org/16021006
3103         https://codereview.chromium.org/15590004
3104         https://codereview.chromium.org/15901008
3105         https://codereview.chromium.org/16171009
3106         https://codereview.chromium.org/16465007
3107         https://codereview.chromium.org/15981013
3108
3109         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3110         (setUp):
3111         (test_commit_message_for_this_commit):
3112         * Scripts/webkitpy/port/base.py:
3113         (Port):
3114         * Scripts/webkitpy/port/test.py:
3115         * Scripts/webkitpy/w3c/test_converter.py:
3116         (W3CTestConverter.__init__):
3117         (W3CTestConverter.read_webkit_prefixed_css_property_list):
3118         (W3CTestConverter.convert_for_webkit):
3119         (W3CTestConverter.convert_css):
3120         (W3CTestConverter.convert_html):
3121         (W3CTestConverter.convert_testharness_paths):
3122         (W3CTestConverter.convert_prefixed_properties):
3123         (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
3124         * Scripts/webkitpy/w3c/test_converter_unittest.py:
3125         * Scripts/webkitpy/w3c/test_importer.py:
3126         (main):
3127         (configure_logging):
3128         (configure_logging.LogHandler):
3129         (configure_logging.LogHandler.format):
3130         (parse_args):
3131         (TestImporter.__init__):
3132         (TestImporter.find_importable_tests):
3133         (TestImporter.import_tests):
3134         (TestImporter.setup_destination_directory):
3135         (TestImporter.remove_deleted_files):
3136         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3137         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
3138         (TestImporterTest.test_import_dir_with_no_tests):
3139         (TestImporterTest):
3140         * Scripts/webkitpy/w3c/test_parser.py:
3141         (TestParser.load_file):
3142         (TestParser.analyze_test):
3143         (TestParser.support_files):
3144         * Scripts/webkitpy/w3c/test_parser_unittest.py:
3145
3146 2013-06-27  Csaba Osztrogonác  <ossy@webkit.org>
3147
3148         [webkitpy] AbstractPatchSequencingCommand should have _prepare_state
3149         https://bugs.webkit.org/show_bug.cgi?id=118128
3150
3151         Reviewed by Ryosuke Niwa.
3152
3153         It is a preparation for a new webkit-patch command: run-tests-touched-by-attachment
3154         https://bugs.webkit.org/show_bug.cgi?id=117831
3155
3156         * Scripts/webkitpy/tool/commands/download.py:
3157         (AbstractPatchSequencingCommand):
3158         (AbstractPatchSequencingCommand._prepare_to_process): Call _prepare_state before prepare_steps.
3159         (AbstractPatchSequencingCommand._process_patch): Use the same initial state for each patch.
3160         (AbstractPatchSequencingCommand._prepare_state): Added.
3161
3162 2013-06-27  Brendan Long  <b.long@cablelabs.com>
3163
3164         [Qt] Build overrides -j when given --makeargs="-sj40"
3165         https://bugs.webkit.org/show_bug.cgi?id=116897
3166
3167         Reviewed by Csaba Osztrogonác.
3168
3169         * Scripts/webkitdirs.pm:
3170         (buildQMakeProjects):
3171         Change regex checking for -j* to also check for -*j*
3172
3173 2013-06-27  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3174
3175         Remove [NoInterfaceObject] from WorkerGlobalScope
3176         https://bugs.webkit.org/show_bug.cgi?id=118071
3177
3178         Reviewed by Kentaro Hara.
3179
3180         Update bindings test script to pass 2 additional parameters
3181         now needed by the preprocess-idls.pl script.
3182
3183         * Scripts/webkitpy/bindings/main.py:
3184         (BindingsTests.generate_supplemental_dependency):
3185         (BindingsTests.main):
3186
3187 2013-06-27  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3188
3189         Fixing some compiler warnings
3190         https://bugs.webkit.org/show_bug.cgi?id=117791
3191
3192         Reviewed by Martin Robinson.
3193
3194         * GNUmakefile.am: Silenced format warning.
3195         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
3196         (TestWebKitAPI::DOMWindowExtensionNoCache::globalObjectIsAvailableForFrame):
3197         Solved warning about uninitialized variable.
3198
3199 2013-06-27  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3200
3201         Fix bindings tests after r152080
3202         https://bugs.webkit.org/show_bug.cgi?id=118118
3203
3204         Reviewed by Gyuyoung Kim.
3205
3206         r152080 renamed argument to preprocess-idls.pl from --workerContextConstructorsFile
3207         to --workerGlobalScopeConstructorsFile. This patch updates to bindings test script
3208         accordingly.
3209
3210         * Scripts/webkitpy/bindings/main.py:
3211         (BindingsTests.generate_supplemental_dependency):
3212         (BindingsTests.main):
3213
3214 2013-06-26  Carlos Garcia Campos  <cargarcia@blackberry.com>
3215
3216         [BlackBerry] Handle testRunner.setCustomPolicyDelegate()
3217         https://bugs.webkit.org/show_bug.cgi?id=117982
3218
3219         Reviewed by Rob Buis.
3220
3221         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3222         (BlackBerry::WebKit::DumpRenderTree::DumpRenderTree): Initialize
3223         m_policyDelegateIsPermissive.
3224         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
3225         Reset m_policyDelegateIsPermissive.
3226         (BlackBerry::WebKit::DumpRenderTree::setCustomPolicyDelegate): Set
3227         m_policyDelegateIsPermissive.
3228         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
3229         (BlackBerry::WebKit::DumpRenderTree::policyDelegateEnabled):
3230         Return whether custom policy is enabled.
3231         (BlackBerry::WebKit::DumpRenderTree::policyDelegateIsPermissive):
3232         Return whether custom policy is permissive.
3233
3234 2013-06-26  Anders Carlsson  <andersca@apple.com>
3235
3236         Deprecate StringImpl::charactersWithNullTermination
3237         https://bugs.webkit.org/show_bug.cgi?id=118108
3238
3239         Reviewed by Beth Dakin.
3240
3241         Rename calls to charactersWithNullTermination to deprecatedCharactersWithNullTermination.
3242
3243         * DumpRenderTree/win/DumpRenderTree.cpp:
3244         (findFontFallback):
3245         (addFontFallbackIfPresent):
3246         (removeFontFallbackIfPresent):
3247
3248 2013-06-26  Nico Weber  <thakis@chromium.org>
3249
3250         Remove detect-mismached-virtual-const.
3251         https://bugs.webkit.org/show_bug.cgi?id=117999
3252
3253         Reviewed by Anders Carlsson.
3254
3255         Clang warns on mismatched virtual const, so there's no need for this
3256         script any more.
3257
3258         * Scripts/detect-mismatched-virtual-const: Removed.
3259
3260 2013-06-26  Alex Christensen  <achristensen@apple.com>
3261
3262         Added a code coverage report.
3263         https://bugs.webkit.org/show_bug.cgi?id=117941
3264
3265         Reviewed by Joseph Pecoraro.
3266
3267         * CodeCoverage: Added.
3268         * CodeCoverage/results-template.html: Added.
3269         * Scripts/generate-coverage-data: Generate and open the new report.
3270
3271 2013-06-25  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3272
3273         gdb: Remove the webcore.py pretty printer.
3274         https://bugs.webkit.org/show_bug.cgi?id=117992
3275
3276         Reviewed by Jochen Eisinger.
3277
3278         webcore.py has been only a placeholder for backwards compatibility
3279         for almost 3 years. It should be safe enough to remove it now.
3280
3281         * gdb/webcore.py: Removed.
3282
3283 2013-05-26  Peter Gal  <galpeter@inf.u-szeged.hu>
3284
3285         Creating cURL watchlist and adding myself to it.
3286
3287         Reviewed by Csaba Osztrogonác.
3288
3289         * Scripts/webkitpy/common/config/watchlist:
3290
3291 2013-06-25  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3292
3293         Unreviewed, change my email address for watch list.
3294
3295         * Scripts/webkitpy/common/config/watchlist:
3296
3297 2013-06-25  Byungwoo Lee  <bw80.lee@samsung.com>
3298
3299         [EFL] Add a script to install dependencies.
3300         https://bugs.webkit.org/show_bug.cgi?id=117968
3301
3302         Reviewed by Christophe Dumez.
3303
3304         Add a script which installs basic dependencies for building WebKit EFL.
3305
3306         The dependencies are from the current EFLWebKit wiki page.
3307         After this patch is landed, the wiki page will be updated to use
3308         this script.
3309
3310         * efl/install-dependencies: Added.
3311
3312 2013-06-24  Dean Jackson  <dino@apple.com>
3313
3314         [Mac] Update font used for Chinese in test systems
3315         https://bugs.webkit.org/show_bug.cgi?id=117970
3316
3317         Reviewed by Alexey Proskuryakov.
3318
3319         Add "Songti TC" and "Songti SC" to the list of allowed fonts
3320         in DRT and WKTR.
3321
3322         * DumpRenderTree/mac/DumpRenderTree.mm:
3323         (allowedFontFamilySet):
3324         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3325         (WTR::allowedFontFamilySet):
3326
3327 2013-06-24  Tim Horton  <timothy_horton@apple.com>
3328
3329         Make MiniBrowser paginated mode work with WebKit1
3330         https://bugs.webkit.org/show_bug.cgi?id=117950
3331
3332         Reviewed by Beth Dakin.
3333
3334         * MiniBrowser/mac/WK1BrowserWindowController.m:
3335         (-[WK1BrowserWindowController isPaginated]):
3336         (-[WK1BrowserWindowController togglePaginationMode:]):
3337         Hook up isPaginated and togglePaginationMode just as for WebKit2.
3338
3339 2013-06-24  David Kilzer  <ddkilzer@apple.com>
3340
3341         bisect-builds: improve heuristic for choosing the next build after a broken build
3342         <http://webkit.org/b/117918>
3343
3344         Reviewed by Simon Fraser.
3345
3346         * Scripts/bisect-builds: When a build is broken, use a heuristic
3347         that "bisects" the left side or the right side of the remaining
3348         revisions to pick a revision that's sufficiently different from
3349         the revision of the broken build.  This heuristic assumes there
3350         is a sequential range of broken builds whenever one broken build
3351         is found.
3352
3353 2013-06-24  Chris Rogers  <crogers@google.com>
3354
3355         WaveTable name has changed to PeriodicWave
3356         https://bugs.webkit.org/show_bug.cgi?id=117748
3357
3358         Reviewed by Jer Noble.
3359
3360         * Scripts/do-webcore-rename:
3361
3362 2013-06-22  Santosh Mahto  <santosh.ma@samsung.com>
3363
3364         [EFL] Add support for MHTML save/load feature to MiniBrowser
3365         https://bugs.webkit.org/show_bug.cgi?id=106620
3366
3367         Reviewed by Christophe Dumez.
3368
3369         Enable CTRL + S as save page in mhtml and CTRL + L to load any page
3370         from filesystem.
3371
3372         * MiniBrowser/efl/CMakeLists.txt:
3373         * MiniBrowser/efl/main.c:
3374         (page_contents_callback):
3375         (on_key_down):
3376         (show_file_entry_dialog): generic function to show file enrty
3377         selector dialogue
3378
3379 2013-06-21  Brent Fulgham  <bfulgham@apple.com>
3380
3381         [Windows] Unreviewed crash protection for DRT
3382
3383         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Check for null elements in routines
3384         to avoid crashing during test runs.
3385
3386 2013-06-21  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3387
3388         REGRESSION (r150663): Using webkitAudioContext in Inspector makes it undefined everywhere
3389         https://bugs.webkit.org/show_bug.cgi?id=117825
3390
3391         Reviewed by Kentaro Hara.
3392
3393         DumpRenderTreeSupportEfl::setWebAudioEnabled() now requires an additional view argument.
3394
3395         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3396         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3397         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3398         (TestRunner::overridePreference):
3399
3400 2013-06-21  Krzysztof Czech  <k.czech@samsung.com>
3401
3402         [ATK] Added support for aria-required attribute.
3403         https://bugs.webkit.org/show_bug.cgi?id=117730
3404
3405         Reviewed by Chris Fleizach.
3406
3407         Added support for testing aria-required attribute.
3408
3409         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3410         (AccessibilityUIElement::isRequired):
3411         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3412         (WTR::AccessibilityUIElement::isRequired):
3413
3414 2013-06-20  Ryuan Choi  <ryuan.choi@samsung.com>
3415
3416         [CMAKE][EFL] Enable DOM4 Events Constructor
3417         https://bugs.webkit.org/show_bug.cgi?id=117858
3418
3419         Reviewed by Laszlo Gombos.
3420
3421         * Scripts/webkitperl/FeatureList.pm: Enable the feature for the EFL port.
3422
3423 2013-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3424
3425         [BlackBerry] Handle testRunner.setWillSendRequestReturnsNull() in DRT
3426         https://bugs.webkit.org/show_bug.cgi?id=117827
3427
3428         Reviewed by Rob Buis.
3429
3430         Reset the passed in request if willSendRequestReturnsNull() is
3431         true or willSendRequestReturnsNullOnRedirect() is true and it's a
3432         redirection.
3433
3434         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3435         (BlackBerry::WebKit::DumpRenderTree::willSendRequestForFrame):
3436         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
3437
3438 2013-06-20  Csaba Osztrogonác  <ossy@webkit.org>
3439
3440         Commit queue shouldn't reopen unrelated bugs because of flakiness
3441         https://bugs.webkit.org/show_bug.cgi?id=117503
3442
3443         Reviewed by Ryosuke Niwa.
3444
3445         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3446         (_follow_duplicate_chain):
3447         (_update_bug_for_flaky_test):
3448
3449 2013-06-19  Brent Fulgham  <bfulgham@apple.com>
3450
3451         [Windows] AX: Expand notification support.
3452         https://bugs.webkit.org/show_bug.cgi?id=117761
3453
3454         Reviewed by Anders Carlsson.
3455
3456         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3457         (AccessibilityUIElement::isPressActionSupported): Provide implementation.
3458         (AccessibilityUIElement::press): Provide implementation.
3459
3460 2013-06-19  Benjamin Poulain  <bpoulain@apple.com>
3461
3462         Use the PlatformEvent timestamp when creating a DOM Event
3463         https://bugs.webkit.org/show_bug.cgi?id=117179
3464
3465         Reviewed by Darin Adler.
3466
3467         * WebKitTestRunner/mac/EventSenderProxy.mm:
3468         (WTR::EventSenderProxy::mouseDown):
3469         (WTR::EventSenderProxy::mouseUp):
3470         (WTR::EventSenderProxy::mouseMoveTo):
3471         (WTR::EventSenderProxy::keyDown):
3472
3473 2013-06-18  Alex Christensen  <achristensen@apple.com>
3474
3475         Working on coverage script, added xml to json data extraction script.
3476         https://bugs.webkit.org/show_bug.cgi?id=117648
3477
3478         This is part of a new test code coverage analysis tool.  This compiles WebKit to generate
3479         coverage data, runs the tests, and collects all of the data in json format.
3480
3481         Reviewed by Stephanie Lewis.
3482
3483         * Scripts/generate-coverage-data:
3484         (parseGcovrOutput):
3485         (getFileHitsAndBranches):
3486         (addLineCounts):
3487         (createResultName):
3488         * Scripts/webkitpy/tool/gcovr: Added.
3489
3490 2013-06-18  Ryuan Choi  <ryuan.choi@samsung.com>
3491
3492         Unreviewed build fix after r151699.
3493
3494         * TestWebKitAPI/CMakeLists.txt:
3495         * WebKitTestRunner/CMakeLists.txt:
3496         Added include dir for InjectedBundleHitTestResultMediaType.h and WKBundleHitTestResult.h
3497
3498 2013-06-18  Roger Fong  <roger_fong@apple.com>
3499
3500         Replace tools32 folder with tools and update WebKit Windows solution accordingly.
3501         <rdar://problem/14118143>.
3502
3503         Rubberstamped by Brent Fulgham.
3504
3505         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
3506         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebug.props:
3507         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
3508         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
3509         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherDebug.props:
3510         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props:
3511         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props:
3512         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props:
3513         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props:
3514         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
3515         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
3516         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebug.props:
3517         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props:
3518         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
3519         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherDebug.props:
3520         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props:
3521         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props:
3522         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props:
3523         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props:
3524         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props:
3525         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
3526         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginDebug.props:
3527         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props:
3528         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props:
3529         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3530         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebug.props:
3531         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
3532         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props:
3533         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props:
3534         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
3535         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
3536         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props:
3537         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
3538         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props:
3539         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props:
3540         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props:
3541         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props:
3542         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props:
3543         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
3544         * win/record-memory/record-memory.vcxproj:
3545         * win/record-memory/record-memoryDebug.props:
3546         * win/record-memory/record-memoryDebugWinCairo.props:
3547         * win/record-memory/record-memoryProduction.props:
3548         * win/record-memory/record-memoryRelease.props:
3549         * win/record-memory/record-memoryReleaseWinCairo.props:
3550
3551 2013-06-17  Kangil Han  <kangil.han@samsung.com>
3552
3553         Unreviewed. Add my email to a DOM watchlist.
3554
3555         * Scripts/webkitpy/common/config/watchlist:
3556
3557 2013-06-17  Zan Dobersek  <zdobersek@igalia.com>
3558
3559         Unreviewed GTK gardening.
3560
3561         * Scripts/run-gtk-tests:
3562         (TestRunner): Skip three WebKit2APITests suites that are currently timing out.
3563
3564 2013-06-15  Bruno de Oliveira Abinader  <brunoabinader@gmail.com>
3565
3566         Unreviewed. Reorder my email addresses.
3567         https://bugs.webkit.org/show_bug.cgi?id=100122
3568
3569         * Scripts/webkitpy/common/config/contributors.json:
3570
3571 2013-06-14  Enrica Casucci  <enrica@apple.com>
3572
3573         WKPageFindStringMatches ignores the kWKFindOptionsBackwards option.
3574         https://bugs.webkit.org/show_bug.cgi?id=117647
3575         <rdar://problem/13881024>
3576
3577         Reviewed by Darin Adler.
3578         
3579         The test now uses content with a selection and tests both
3580         forwards and backward find as well as the case of a find
3581         that has no matches after the user selection.
3582
3583         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3584         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
3585         (TestWebKitAPI::didFindStringMatches):
3586         * TestWebKitAPI/Tests/WebKit2/findRanges.html: Added.
3587
3588 2013-06-14  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
3589
3590         Remove myself from Qt build system watchlist
3591
3592         Reviewed by Simon Hausmann.
3593
3594         * Scripts/webkitpy/common/config/watchlist:
3595
3596 2013-06-13  Michael Brüning  <michael.bruning@digia.com>
3597
3598         [Qt][Mac] Disable QTKit video on OS X.
3599         https://bugs.webkit.org/show_bug.cgi?id=117591
3600
3601         Reviewed by Tor Arne Vestbø.
3602
3603         Deployment of Qt binaries to different Mac OS X
3604         platform version makes it impossible to link against
3605         the correct version of the WebKitSystemInterface library,
3606         so we need to disable QTKit for media elements.
3607
3608         * qmake/mkspecs/features/features.prf:
3609
3610 2013-06-13  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
3611
3612         [EFL][WK2] Wrong context menu and popup menu positions when scroll is applied
3613         https://bugs.webkit.org/show_bug.cgi?id=116610
3614
3615         Reviewed by Noam Rosenthal.
3616
3617         Remove unnecessary code adjusting context menu position to webview position.
3618         Now position is calculcated in EwkView.
3619
3620         * MiniBrowser/efl/main.c:
3621         (on_context_menu_show):
3622
3623 2013-06-12  Roger Fong  <roger_fong@apple.com>
3624
3625         Unreviewed. Turn on WinEWS test now that AppleWin port uses new-run-webkit-tests.
3626
3627         * Scripts/webkitpy/common/config/ews.json:
3628
3629 2013-06-12  Eduardo Lima Mitev  <elima@igalia.com>
3630
3631         [atk] Replace deprecated call to atk_document_get_locale() in DumpRenderTree
3632         https://bugs.webkit.org/show_bug.cgi?id=115647
3633
3634         Reviewed by Martin Robinson.
3635
3636         Locale resolution is moved to WebKitAccessibleWrapperAtk using
3637         AtkObject::get_object_locale() API. Now, implementation of
3638         AccessibilityUIElement::language() in both DumpRenderTree and WebKitTestRunner can
3639         be leveraged to get_object_locale() of AtkObject.
3640
3641         Apart from improving encapsulation, this avoids calling deprecated get_document_locale()
3642         method.
3643
3644         No new functionality, no new tests.
3645
3646         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3647         (AccessibilityUIElement::language): Leverage locale resolution to
3648         AtkObject::get_object_locale().
3649         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3650         (WTR::AccessibilityUIElement::language): Leverage locale resolution to
3651         AtkObject::get_object_locale().
3652
3653 2013-06-12  Hugo Parente Lima  <hugo.lima@openbossa.org>
3654
3655         Remove last bits of GYP from build-webkit and update-webkit scripts
3656         https://bugs.webkit.org/show_bug.cgi?id=117557
3657
3658         Reviewed by Ryosuke Niwa.
3659
3660         * Scripts/build-webkit:
3661         * Scripts/update-webkit:
3662
3663 2013-06-12  Hugo Parente Lima  <hugo.lima@openbossa.org>
3664
3665         Remove forgotten unused Tools/Script/make-gypi script
3666         https://bugs.webkit.org/show_bug.cgi?id=117558
3667
3668         Reviewed by Ryosuke Niwa.