CodeBlock crashes when dumping op_push_name_scope
[WebKit-https.git] / Tools / ChangeLog
1 2015-02-25  Benjamin Poulain  <bpoulain@apple.com>
2
3         CodeBlock crashes when dumping op_push_name_scope
4         https://bugs.webkit.org/show_bug.cgi?id=141953
5
6         Reviewed by Filip Pizlo.
7
8         * Scripts/run-jsc-stress-tests:
9
10 2015-02-25  Youenn Fablet  <youenn.fablet@crf.canon.fr>
11
12         W3C test importer should use argparse instead of optparse
13         https://bugs.webkit.org/show_bug.cgi?id=142013
14
15         Reviewed by Bem Jones-Bey.
16
17         * Scripts/webkitpy/w3c/test_importer.py:
18         (main): Updating according argparse.
19         (parse_args): Moving from optparse to argparse.
20
21 2015-02-25  Brady Eidson  <beidson@apple.com>
22
23         Get rid of TestInvocation::pathOrURL
24         https://bugs.webkit.org/show_bug.cgi?id=142021
25
26         Reviewed by Tim Horton.
27
28         The pathOrURL string is a relative path used as an argument to WebKitTestRunner,
29         but most code that uses it expected an absolute path.
30
31         This gets rid of the member and replaces all uses with a more descriptive "urlContains" method.
32
33         * WebKitTestRunner/TestController.cpp:
34         (WTR::TestController::updateWebViewSizeForTest):
35         (WTR::TestController::updateWindowScaleForTest):
36         (WTR::shouldUseFixedLayout):
37         (WTR::TestController::updateLayoutTypeForTest):
38
39         * WebKitTestRunner/TestInvocation.cpp:
40         (WTR::TestInvocation::TestInvocation):
41         (WTR::TestInvocation::urlContains):
42         (WTR::TestInvocation::shouldLogFrameLoadDelegates):
43         (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
44         (WTR::TestInvocation::invoke):
45         (WTR::shouldLogFrameLoadDelegates): Deleted.
46         (WTR::shouldLogHistoryClientCallbacks): Deleted.
47         * WebKitTestRunner/TestInvocation.h:
48         (WTR::TestInvocation::pathOrURL): Deleted.
49
50         * WebKitTestRunner/ios/TestControllerIOS.mm:
51         (WTR::shouldMakeViewportFlexible):
52         (WTR::TestController::platformConfigureViewForTest):
53
54         * WebKitTestRunner/mac/TestControllerMac.mm:
55         (WTR::shouldUseThreadedScrolling):
56         (WTR::TestController::platformConfigureViewForTest):
57
58 2015-02-25  Brady Eidson  <beidson@apple.com>
59
60         Layout test support for user content filters
61         https://bugs.webkit.org/show_bug.cgi?id=142018
62
63         Reviewed by Tim Horton.
64
65         * WebKitTestRunner/TestController.cpp:
66         (WTR::TestController::resetStateToConsistentValues): Clear all user content filters between tests.
67
68         * WebKitTestRunner/mac/TestControllerMac.mm:
69         (WTR::TestController::platformConfigureViewForTest): For all tests with usercontentfilter/ in their path try to load a matching .json
70           file before loading the test itself.
71
72 2015-02-24  Sam Weinig  <sam@webkit.org>
73
74         Convert WebEditingTester to use xcconfig files
75         https://bugs.webkit.org/show_bug.cgi?id=141879
76
77         Reviewed by Darin Adler.
78
79         Add xcconfig files to WebEditingTester based on the ones used by MiniBrowser.
80
81         * WebEditingTester/Configurations: Added.
82         * WebEditingTester/Configurations/Base.xcconfig: Added.
83         * WebEditingTester/Configurations/DebugRelease.xcconfig: Added.
84         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
85
86 2015-02-24  Andy Estes  <aestes@apple.com>
87
88         Teach MiniBrowser how to disable per-window web processes
89         https://bugs.webkit.org/show_bug.cgi?id=141988
90
91         Reviewed by Darin Adler.
92
93         * MiniBrowser/mac/AppDelegate.m:
94         (defaultConfiguration): Created a _WKProcessPoolConfiguration with maximumProcessCount == 1 if per-window web processes are disabled.
95         * MiniBrowser/mac/SettingsController.h:
96         * MiniBrowser/mac/SettingsController.m:
97         (-[SettingsController _populateMenu]): Added a new Settings menu item.
98         (-[SettingsController validateMenuItem:]): Validated the new Settings menu item.
99         (-[SettingsController togglePerWindowWebProcessesDisabled:]): Displayed an alert informing the user that MiniBrowser must be restarted for the setting to take effect.
100         (-[SettingsController perWindowWebProcessesDisabled]): Returned the value from user defaults.
101
102 2015-02-24  Alexey Proskuryakov  <ap@apple.com>
103
104         Bot watcher's dashboard sometimes hits an assertion: data.num_missing === this.layoutTestResults.testsWithMissingResults.length
105         https://bugs.webkit.org/show_bug.cgi?id=141889
106
107         Reviewed by Darin Adler.
108
109         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
110
111 2015-02-24  Yusuke Suzuki  <utatane.tea@gmail.com>
112
113         REGRESSION(r179429): Can't type comments in Facebook
114         https://bugs.webkit.org/show_bug.cgi?id=141859
115
116         Reviewed by Brent Fulgham.
117
118         Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags.
119
120         * DumpRenderTree/mac/DumpRenderTree.mm:
121         (resetWebPreferencesToConsistentValues):
122         * DumpRenderTree/win/DumpRenderTree.cpp:
123         (resetWebPreferencesToConsistentValues):
124         * WebKitTestRunner/TestController.cpp:
125         (WTR::TestController::resetPreferencesToConsistentValues):
126
127 2015-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
128
129         Crash loading local file with WebPageProxy::loadAlternateHTMLString
130         https://bugs.webkit.org/show_bug.cgi?id=141867
131
132         Reviewed by Anders Carlsson.
133
134         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
135         (TestWebKitAPI::loadAlternateHTMLString): Split most of this test into a function so it can
136         be shared with the new test.
137         (TestWebKitAPI::TEST): Add a cross-platform test for this crash.
138         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: Add a GTK+ test for this crash.
139         (testLoadAlternateHTMLForLocalPage):
140         (beforeAll):
141
142 2015-02-24  David Kilzer  <ddkilzer@apple.com>
143
144         [iOS] Implement WTR::activateFonts() to fix missing fonts in WebKit2 test runs
145         <http://webkit.org/b/141900>
146
147         Reviewed by Myles C. Maxfield.
148
149         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
150         (OTHER_LDFLAGS_BASE): Link to CoreText.framework.
151         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm: Rename from Tools/WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm.
152         - Rename to share code with iOS.
153         - Add USE(APPKIT) around AppKit-specific headers and code.
154         - Fix a check-webkit-style warning.
155         * WebKitTestRunner/InjectedBundle/ios/ActivateFontsIOS.mm: Remove.
156         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
157         - Rename mac/ActivateFonts.mm to cocoa/ActivateFontsCocoa.mm.
158         - Remove ios/ActivateFontsIOS.mm.
159         - Fix InjectedBundle/cocoa group to represent the directory on
160           disk.  Includes a change to InjectedBundlePageCocoa.mm.
161
162 2015-02-23  Commit Queue  <commit-queue@webkit.org>
163
164         Unreviewed, rolling out r180547 and r180550.
165         https://bugs.webkit.org/show_bug.cgi?id=141957
166
167         Broke 10 Windows tests. (Requested by bfulgham_ on #webkit).
168
169         Reverted changesets:
170
171         "REGRESSION(r179429): Can't type comments in Facebook"
172         https://bugs.webkit.org/show_bug.cgi?id=141859
173         http://trac.webkit.org/changeset/180547
174
175         "Constructor returning null should construct an object instead
176         of null"
177         https://bugs.webkit.org/show_bug.cgi?id=141640
178         http://trac.webkit.org/changeset/180550
179
180 2015-02-23  Yusuke Suzuki  <utatane.tea@gmail.com>
181
182         REGRESSION(r179429): Can't type comments in Facebook
183         https://bugs.webkit.org/show_bug.cgi?id=141859
184
185         Reviewed by Geoffrey Garen.
186
187         Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags.
188
189         * DumpRenderTree/mac/DumpRenderTree.mm:
190         (resetWebPreferencesToConsistentValues):
191         * WebKitTestRunner/TestController.cpp:
192         (WTR::TestController::resetPreferencesToConsistentValues):
193
194 2015-02-23  KwangHyuk Kim  <hyuki.kim@samsung.com>
195
196         [EFL] fix eo errors
197         https://bugs.webkit.org/show_bug.cgi?id=141909
198
199         Reviewed by Gyuyoung Kim.
200
201         Fix eo errors that occur whenever minibrowser is launched.
202         - elm_obj_entry_text_style_user_push can only be applied for elm_entry
203         - elm_obj_win_resize_object_add's first parameter should be elm_win
204
205         * MiniBrowser/efl/main.c:
206         (window_create):
207
208 2015-02-23  Ryosuke Niwa  <rniwa@webkit.org>
209
210         Unreviewed build fix after r180535. Removed the test case that wasn't compiling.
211
212         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
213         (TestWebKitAPI::TEST):
214
215 2015-02-23  Brent Fulgham  <bfulgham@apple.com>
216
217         WTF::WeakPtr should rename 'forgot' to 'clear' and support nullptr assignment
218         https://bugs.webkit.org/show_bug.cgi?id=141935
219
220         Reviewed by Myles C. Maxfield.
221
222         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
223         (TestWebKitAPI::TEST): Updated for 'clear' method rename, and added a few
224         tests for assigning from nullptr.
225
226 2015-02-23  Brent Fulgham  <bfulgham@apple.com>
227
228         WTF::WeakPtr should have a 'forget' method.
229         https://bugs.webkit.org/show_bug.cgi?id=141923
230
231         Reviewed by Myles C. Maxfield.
232
233         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
234         (TestWebKitAPI::TEST): Added 'Forget' tests case.
235
236 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
237
238         build.webkit.org/dashboard CrashOnly queues should not show two green bubbles
239         https://bugs.webkit.org/show_bug.cgi?id=141920
240
241         Reviewed by Tim Horton.
242
243         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
244         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
245         Do the same thing as we do for regular green bubbles.
246
247 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
248
249         Bot watcher's dashboard doesn't show a popover for commit history when all commits were to another branch
250         https://bugs.webkit.org/show_bug.cgi?id=141925
251
252         Reviewed by Tim Horton.
253
254         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
255         (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
256
257 2015-02-23  Anders Carlsson  <andersca@apple.com>
258
259         Add API for fetching website data records to _WKWebsiteDataStore
260         https://bugs.webkit.org/show_bug.cgi?id=141926
261
262         Reviewed by Beth Dakin.
263
264         * MiniBrowser/mac/MainMenu.xib:
265         * MiniBrowser/mac/WK2BrowserWindowController.m:
266         (-[WK2BrowserWindowController fetchWebsiteData:]):
267         Add menu item to fetch and dump website data.
268
269 2015-02-23  David Kilzer  <ddkilzer@apple.com>
270
271         [iOS] run-webkit-tests --leaks is broken because IOSSimulatorPort has no is_snowleopard attribute
272         <http://webkit.org/b/141884>
273
274         Reviewed by Alexey Proskuryakov.
275
276         * Scripts/webkitpy/port/leakdetector.py:
277         (LeakDetector._callstacks_to_exclude_from_leaks): Remove
278         snowleopard, lion and older leaks.  Add known leak for
279         mavericks, but check Port.operating_system before calling
280         Port.is_mavericks.
281         * Scripts/webkitpy/port/mac.py:
282         (MacPort.is_snowleopard): Delete.
283         (MacPort.is_lion): Delete.
284         (MacPort.is_mavericks): Add.
285
286 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
287
288         build.webkit.org/dashboard should filter out commits to other branches
289         https://bugs.webkit.org/show_bug.cgi?id=140362
290
291         Reviewed by Tim Horton.
292
293         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
294         (BuildbotQueue):
295         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
296         (BuildbotQueueView.prototype._presentPopoverForPendingCommits):
297         (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
298         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration):
299         (BuildbotQueueView.prototype.revisionContentForIteration):
300         (BuildbotQueueView.prototype._appendPendingRevisionCount): Deleted.
301         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Deleted.
302         (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Deleted.
303         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
304         (Trac.prototype.get oldestRecordedRevisionNumber):
305         (Trac.prototype.commitsOnBranch):
306         (Trac.prototype._xmlTimelineURL):
307         (Trac.prototype._convertCommitInfoElementToObject):
308         (Trac.prototype._update):
309         (Trac.prototype.startPeriodicUpdates):
310         (Trac.prototype.loadMoreHistoricalData):
311         (Trac.prototype.update): Deleted.
312
313 2015-02-21  Youenn Fablet  <youenn.fablet@crf.canon.fr>
314
315         Tests don't work on some bots: Failed to stop wptwk
316         https://bugs.webkit.org/show_bug.cgi?id=141235
317
318         Reviewed by Ryosuke Niwa.
319
320         Logging of server subprocesses in launcher script.
321         Killing of server subprocesses when stopping/before starting.
322         Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore.
323
324         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
325         (main): Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore. Added logging in a file of server subprocesses to clean them in case of abnormal shutdown. 
326         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
327         (WebPlatformTestServer.__init__):
328         (WebPlatformTestServer._stop_running_subservers): Kill server subprocesses based on file created by wpt launcher.
329         (WebPlatformTestServer):
330         (WebPlatformTestServer.stop): Overriden to ensure killing subprocesses in case of orphaned process.
331         (WebPlatformTestServer._stop_running_server): Killing of wpt launcher process after regular shutdown. 
332         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
333         (TestWebPlatformTestServer.test_server_closes_previously_spawned_instance): Reworked the test to call start/stop with an existing pid file.
334         (TestWebPlatformTestServer.test_import_web_platform_test_modules): No change.
335         (TestWebPlatformTestServer):
336         (TestWebPlatformTestServer.test_corrupted_subserver_files): Checked that server subprocess cleaning does not throw in case of bad server pid file.
337
338 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
339
340         [WebEditingTester] Allow dropping HTML files on the app
341         https://bugs.webkit.org/show_bug.cgi?id=141834
342
343         Reviewed by Simon Fraser.
344
345         * WebEditingTester/AppDelegate.m:
346         (-[WebEditingAppDelegate openDocument:]):
347         (-[WebEditingAppDelegate application:openFile:]):
348         Implement application:openFile:, factoring file loading code out of openDocument.
349
350         * WebEditingTester/Info.plist:
351         Register as an editor for HTML files.
352
353         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
354         Enrica is not an organization.
355
356 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
357
358         [WebEditingTester] Expand "WK" to "WebKit" in a few places
359         https://bugs.webkit.org/show_bug.cgi?id=141833
360
361         Reviewed by Anders Carlsson.
362
363         * WebEditingTester/AppDelegate.h:
364         * WebEditingTester/AppDelegate.m:
365         (-[WebEditingAppDelegate newEditor:]):
366         (-[WebEditingAppDelegate toggleUseWebKit2ByDefault:]):
367         (-[WebEditingAppDelegate validateMenuItem:]):
368         (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
369         (-[WebEditingAppDelegate applicationDidFinishLaunching:]): Deleted.
370         (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.
371         (-[WebEditingAppDelegate showOperations:]): Deleted.
372         * WebEditingTester/MainMenu.xib:
373         The WK abbreviation is unnaturally grating in menu items for some reason.
374
375 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
376
377         [WebEditingTester] Add a custom protocol for loading canned content
378         https://bugs.webkit.org/show_bug.cgi?id=141830
379
380         Reviewed by Enrica Casucci.
381
382         Add a canned:// protocol handler, which can be used to emulate behaviors
383         in WebKit client apps (like Mail) that use custom protocol handlers,
384         which can have important effects on editing (mostly, the URLs are only
385         valid inside of the client application, but not when copied/dragged out).
386
387         For now, we only support two canned files:
388
389             canned://dice is a PNG of dice (stolen from LayoutTests/)
390             canned://text is the string "canned text" served as text/html
391
392         In the future we could support things like very large (generated) files,
393         progressive loading, etc. to further simulate conditions in other apps.
394
395         * WebEditingTester/AppDelegate.m:
396         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
397         Register the protocol with CFNetwork, and the scheme with WebKit2.
398
399         * WebEditingTester/Canned Content/dice.png: Added.
400         * WebEditingTester/CannedContent.h: Added.
401         * WebEditingTester/CannedContent.m: Added.
402         (-[CannedContent initWithRequest:cachedResponse:client:]):
403         (+[CannedContent canonicalRequestForRequest:]):
404         (+[CannedContent canInitWithRequest:]):
405         We only want to handle canned:// URLs.
406
407         (-[CannedContent startLoading]):
408         For now, immediately load the two files we know about.
409         Otherwise, immediately fail the load.
410
411         (-[CannedContent stopLoading]):
412         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
413
414 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
415
416         [WebEditingTester] Implement an open panel
417         https://bugs.webkit.org/show_bug.cgi?id=141829
418
419         Reviewed by Simon Fraser.
420
421         * WebEditingTester/AppDelegate.m:
422         (-[WebEditingAppDelegate _useWebKit1ForOpeningDocument:]):
423         (-[WebEditingAppDelegate _useWebKit2ForOpeningDocument:]):
424         (-[WebEditingAppDelegate openDocument:]):
425         Add an open panel (with radio buttons to pick which WebKit to open with).
426         Loads the file as an HTML string.
427
428 2015-02-20  Simon Fraser  <simon.fraser@apple.com>
429
430         [WebEditingTester] @properties, dot syntax, and remember the window position
431         https://bugs.webkit.org/show_bug.cgi?id=141843
432
433         Reviewed by Tim Horton.
434         
435         Modernize a bit with more dot syntax, use @property for the web views,
436         and give the main window an Autosave name so it remembers the widow position.
437
438         * WebEditingTester/WK1WebDocumentController.m:
439         (-[WK1WebDocumentController awakeFromNib]):
440         (-[WK1WebDocumentController loadHTMLString:]):
441         * WebEditingTester/WK2WebDocumentController.m:
442         (-[WK2WebDocumentController awakeFromNib]):
443         * WebEditingTester/WebDocument.xib:
444
445 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
446
447         [WebEditingTester] Hook up key equivalents for new window action
448         https://bugs.webkit.org/show_bug.cgi?id=141828
449
450         Reviewed by Enrica Casucci.
451
452         * WebEditingTester/AppDelegate.h:
453         * WebEditingTester/AppDelegate.m:
454         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
455         (-[WebEditingAppDelegate newEditor:]):
456         (-[WebEditingAppDelegate _defaultWebDocumentControllerClass]):
457         (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
458         (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
459         (defaultConfiguration): Deleted.
460         (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.
461         Move WKWebViewConfiguration setup into WK2WebDocumentController.
462         Remove unused application termination code.
463         Update new-window menu item key equivalents when launching and when
464         changing the use-WebKit2-by-default setting.
465         Make WebDocumentController subclasses all initialized the same way,
466         and use that to factor out alloc/init.
467         Rename loadContent to loadHTMLString for future use.
468
469         * WebEditingTester/MainMenu.xib:
470         Add default key equivalents.
471         Cmd-N will always make the default kind of window (controlled by the pref).
472         Cmd-Opt-N will always make the other kind.
473         The menu items are configured as alternates so they only show up if you
474         press alt (just like in MiniBrowser).
475
476         * WebEditingTester/WK1WebDocumentController.m:
477         (-[WK1WebDocumentController loadHTMLString:]):
478         (-[WK1WebDocumentController loadContent]): Deleted.
479         * WebEditingTester/WK2WebDocumentController.h:
480         * WebEditingTester/WK2WebDocumentController.m:
481         (defaultConfiguration):
482         (-[WK2WebDocumentController awakeFromNib]):
483         (-[WK2WebDocumentController loadHTMLString:]):
484         (-[WK2WebDocumentController initWithConfiguration:]): Deleted.
485         (-[WK2WebDocumentController dealloc]): Deleted.
486         * WebEditingTester/WebDocumentController.h:
487         * WebEditingTester/WebDocumentController.m:
488         (-[WebDocumentController init]):
489         (-[WebDocumentController initWithWindow:]):
490         (+[WebDocumentController defaultEditingSource]):
491         (-[WebDocumentController loadHTMLString:]):
492         (-[WebDocumentController windowDidLoad]): Deleted.
493         (-[WebDocumentController defaultEditingSource]): Deleted.
494         (-[WebDocumentController applicationTerminating]): Deleted.
495         (-[WebDocumentController loadContent]): Deleted.
496
497 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
498
499         [WebEditingTester] ARC-ify WebEditingTester
500         https://bugs.webkit.org/show_bug.cgi?id=141827
501
502         Reviewed by Sam Weinig.
503
504         * WebEditingTester/AppDelegate.m:
505         (-[WebEditingAppDelegate showOperations:]):
506         * WebEditingTester/EditingOperations.m:
507         (editingOperations):
508         * WebEditingTester/WK1WebDocumentController.m:
509         (-[WK1WebDocumentController dealloc]): Deleted.
510         * WebEditingTester/WK2WebDocumentController.m:
511         (-[WK2WebDocumentController dealloc]): Deleted.
512         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
513         Turn on ARC and remove a few retain/release/autorelease calls.
514         We don't need to implement dealloc in either document controller
515         because WebView and WKWebView's UIDelegate property does not hold a
516         strong reference.
517
518 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
519
520         [WebEditingTester] Factor out list of editing operations
521         https://bugs.webkit.org/show_bug.cgi?id=141826
522
523         Reviewed by Sam Weinig.
524
525         * WebEditingTester/AppDelegate.m:
526         (-[WebEditingAppDelegate showOperations:]):
527         * WebEditingTester/EditingOperations.h: Added.
528         * WebEditingTester/EditingOperations.m: Added.
529         (editingOperations):
530         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
531         Move EditingOperations array to its own file, and make it an NSArray
532         instead of a C array. Adjust accordingly in showOperations:.
533
534 2015-02-20  Michael Saboff  <msaboff@apple.com>
535
536         DFG JIT needs to check for stack overflow at the start of Program and Eval execution
537         https://bugs.webkit.org/show_bug.cgi?id=141676
538
539         Reviewed by Filip Pizlo.
540
541         Set the newly added --maximumEvalCacheableSourceLength option for eager test runs.  This is needed
542         to allow the eval out of stack tests to tier up.  Without this option, we don't cache the likely
543         large string expression that we want to eval.
544
545         * Scripts/run-jsc-stress-tests:
546
547 2015-02-19  Daniel Bates  <dabates@apple.com>
548
549         REGRESSION (r180239): run-webkit-test fails to boot simulator device that was booted by previous test run
550         https://bugs.webkit.org/show_bug.cgi?id=141815
551         <rdar://problem/19893933>
552
553         Reviewed by Simon Fraser.
554
555         Fixes an issue where run-webkit-tests would fail to boot the WebKit Tester simulator device if it
556         was booted by iOS Simulator in a previous run of run-webkit-test.
557
558         * Scripts/webkitpy/port/ios.py:
559         (IOSSimulatorPort.check_sys_deps): Added logic moved from IOSSimulatorPort.setup_test_run().
560         (IOSSimulatorPort.setup_test_run): Moved logic to quit the iOS Simulator app and wait for the
561         testing device to be in the shutdown state from here to IOSSimulatorPort.check_sys_deps().
562
563 2015-02-19  David Kilzer  <ddkilzer@apple.com>
564
565         check-webkit-style: do not warn about missing primary header for *SoftLink.cpp files
566         <http://webkit.org/b/141799>
567
568         Reviewed by Alex Christensen.
569
570         * Scripts/webkitpy/style/checkers/cpp.py:
571         (_IncludeState.check_next_include_order): Don't emit a warning
572         if the primary header exists and the source file name ends with
573         "SoftLink.cpp".  Add 'filename' argument to method.
574         (check_include_line): Pass in 'filename'.
575
576         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
577         (OrderOfIncludesTest.test_check_next_include_order__no_config):
578         (OrderOfIncludesTest.test_check_next_include_order__no_self):
579         (OrderOfIncludesTest.test_check_next_include_order__likely_then_config):
580         (OrderOfIncludesTest.test_check_next_include_order__other_then_config):
581         (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely):
582         - Add test filename arguments for calls to
583           check_next_include_order().
584         (OrderOfIncludesTest.test_primary_header): Add test for a file
585         name ending in "SoftLink.cpp".
586
587 2015-02-18  Enrica Casucci  <enrica@apple.com>
588
589         Add new tool to test editable Webviews.
590         https://bugs.webkit.org/show_bug.cgi?id=141772
591
592         Reviewed by Tim Horton.
593
594         Adding WebEditingTester, a Cocoa application to
595         test WK1 and Wk2 views in editable mode.
596
597         * WebEditingTester: Added.
598         * WebEditingTester/AppDelegate.h: Added.
599         * WebEditingTester/AppDelegate.m: Added.
600         (-[WebEditingAppDelegate init]):
601         (defaultConfiguration):
602         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
603         (-[WebEditingAppDelegate applicationWillTerminate:]):
604         (-[WebEditingAppDelegate newEditor:]):
605         (-[WebEditingAppDelegate showOperations:]):
606         (-[WebEditingAppDelegate useWebKit2ByDefault]):
607         (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
608         (-[WebEditingAppDelegate validateMenuItem:]):
609         * WebEditingTester/Info.plist: Added.
610         * WebEditingTester/MainMenu.xib: Added.
611         * WebEditingTester/WK1WebDocumentController.h: Added.
612         * WebEditingTester/WK1WebDocumentController.m: Added.
613         (-[WK1WebDocumentController awakeFromNib]):
614         (-[WK1WebDocumentController loadContent]):
615         (-[WK1WebDocumentController dealloc]):
616         (-[WK1WebDocumentController pasteAsMarkup:]):
617         * WebEditingTester/WK2WebDocumentController.h: Added.
618         * WebEditingTester/WK2WebDocumentController.m: Added.
619         (-[WK2WebDocumentController initWithConfiguration:]):
620         (-[WK2WebDocumentController pasteAsMarkup:]):
621         (-[WK2WebDocumentController awakeFromNib]):
622         (-[WK2WebDocumentController dealloc]):
623         (-[WK2WebDocumentController loadContent]):
624         * WebEditingTester/WebDocument.xib: Added.
625         * WebEditingTester/WebDocumentController.h: Added.
626         * WebEditingTester/WebDocumentController.m: Added.
627         (-[WebDocumentController initWithWindow:]):
628         (-[WebDocumentController windowDidLoad]):
629         (-[WebDocumentController defaultEditingSource]):
630         (-[WebDocumentController applicationTerminating]):
631         (-[WebDocumentController loadContent]):
632         * WebEditingTester/WebEditingTester.xcodeproj: Added.
633         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj: Added.
634         * WebEditingTester/main.m: Added.
635         (main):
636
637 2015-02-18  Csaba Osztrogonác  <ossy@webkit.org>
638
639         Run JSC tests on ARM EFL bots
640         https://bugs.webkit.org/show_bug.cgi?id=141165
641
642         Reviewed by Alexey Proskuryakov.
643
644         * BuildSlaveSupport/build.webkit.org-config/config.json:
645         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
646         (RunJavaScriptCoreTests.countFailures):
647         (RunRemoteJavaScriptCoreTests):
648         (RunRemoteJavaScriptCoreTests.start):
649         (BuildAndRemoteJSCTestsFactory):
650         (BuildAndRemoteJSCTestsFactory.__init__):
651
652 2015-02-18  Alexey Proskuryakov  <ap@apple.com>
653
654         Streamline unexported function build fixes
655         https://bugs.webkit.org/show_bug.cgi?id=141761
656
657         Reviewed by Alex Christensen.
658
659         * Scripts/check-for-weak-vtables-and-externals: (readXcode5SymbolsToIgnore): Deleted.
660         We don't need to ignore symbols that are not exported due to the .unexp file.
661
662 2015-02-18  Timothy Horton  <timothy_horton@apple.com>
663
664         Remove more references to WebCore.exp.in
665         https://bugs.webkit.org/show_bug.cgi?id=141747
666
667         Reviewed by Alexey Proskuryakov.
668
669         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
670         (ShouldBuildTest):
671
672 2015-02-17  Myles C. Maxfield  <mmaxfield@apple.com>
673
674         Windows test results should not fall back to mac-mountainlion after r180176
675         https://bugs.webkit.org/show_bug.cgi?id=141719
676
677         Reviewed by Brent Fulgham.
678
679         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
680         (_should_file_trigger_build):
681         * Scripts/webkitpy/port/win.py:
682         (WinPort.default_baseline_search_path):
683         * Scripts/webkitpy/port/win_unittest.py:
684         (WinPortTest.test_baseline_search_path):
685
686 2015-02-17  Daniel Bates  <dabates@apple.com>
687
688         [iOS] run-webkit-tests should check that simctl can boot and shutdown simulator device before running tests
689         https://bugs.webkit.org/show_bug.cgi?id=141718
690
691         Reviewed by Alex Christensen.
692
693         We should only run layout tests if simctl can successfully boot and shutdown the testing device.
694
695         * Scripts/webkitpy/port/ios.py:
696         (IOSSimulatorPort.check_sys_deps): Modified to call Simulator.check_simulator_device_and_erase_if_needed().
697         Log a error and return False if we are unable to boot the simulator device so that the caller can take
698         appropriate action, say exit(3) before running any layout tests.
699         * Scripts/webkitpy/xcode/simulator.py:
700         (Simulator._boot_and_shutdown_simulator_device): Added. Boot and then shut down the simulator device
701         with the specified UDID.
702         (Simulator.check_simulator_device_and_erase_if_needed): Added. Checks that simulator device
703         with the specified UDID can successfully boot and shut down. We make at most two attempts to
704         boot and shut down the device, erasing the device between tries so as to restore the device
705         to a known good state.
706
707 2015-02-17  Daniel Bates  <dabates@apple.com>
708
709         run_webkit_tests.py should not know about iOS Simulator details
710         https://bugs.webkit.org/show_bug.cgi?id=141711
711
712         Reviewed by Alex Christensen.
713
714         Run_webkit_tests.py should only parse the iOS-specific command
715         line options --runtime and --device-type. Let the port-specific
716         logic in ios.py validate the parsed options and instantiate
717         internal data structures.
718
719         Currently run_webkit_tests.py parses the iOS-specific command
720         line options --runtime and --device-type, validates them, and
721         instantiates internal data structures from the parsed strings.
722         Instead the validation logic and instantiation of internal
723         data structures should be handled by the iOS port object.
724
725         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
726         (_set_up_derived_options): Remove logic to validate --runtime and --device-type
727         and instantiate internal data structures for them.
728         * Scripts/webkitpy/port/driver.py:
729         (IOSSimulatorDriver.cmd_line): Modified to reference IOSSimulatorPort.simulator_runtime
730         and IOSSimulatorPort.simulator_device_type for the iOS Simulator runtime and device type,
731         respectively.
732         * Scripts/webkitpy/port/ios.py: Sort the list of imports.
733         (IOSSimulatorPort.simulator_runtime): Added. Instantiates a Runtime
734         object from --runtime, if specified. Otherwise, instantiates a Runtime
735         object for the latest installed iphonesimulator SDK version.
736         (IOSSimulatorPort.simulator_device_type): Added. Instantiates a DeviceType
737         object from --device-type, if specified. Otherwise, instantiates
738         a DeviceType object for a iPhone 5 or iPhone 5s when on a 32-bit and 64-bit
739         machine, respectively.
740         (IOSSimulatorPort.check_sys_deps): Added. Validate if the chosen iOS simulator
741         runtime is available to use.
742         (IOSSimulatorPort.testing_device): Modified to make use of properties simulator_device_type
743         and simulator_runtime for the iOS Simulator device type and runtime, respectively.
744         * Scripts/webkitpy/xcode/simulator.py:
745         (Runtime.from_version_string): Added. Turns around and calls Runtime.from_identifier()
746         with a runtime identifier for the specified iOS version.
747
748 2015-02-17  Dana Burkart  <dburkart@apple.com>
749
750         ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack
751         https://bugs.webkit.org/show_bug.cgi?id=141672
752
753         Reviewed by David Kilzer.
754
755         * asan/webkit-asan-ignore.txt:
756
757 2015-02-17  Alex Christensen  <achristensen@webkit.org>
758
759         Remove WebCore.exp.in and clean up.
760         https://bugs.webkit.org/show_bug.cgi?id=141491
761
762         Reviewed by Andreas Kling.
763
764         * Scripts/sort-export-file: Removed.
765         * Scripts/webkitpy/style/checker.py:
766         (_all_categories):
767         (FileType):
768         (CheckerDispatcher._file_type):
769         (CheckerDispatcher._create_checker):
770         Don't check if the export files are sorted.
771         * Scripts/webkitpy/style/checkers/exportfile.py: Removed.
772         * Scripts/webkitpy/style/checkers/exportfile_unittest.py: Removed.
773
774 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
775
776         Unreviewed. Fix GTK+ make distcheck.
777
778         Do not exclude bmalloc directory from the tarball.
779
780         * gtk/manifest.txt.in:
781
782 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
783
784         Unreviewed. Fix /webkit2/WebKitDOMNode/dom-cache after r180214.
785
786         I forgot to add the return of a bool function.
787
788         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
789         (WebKitDOMNodeTest::testDOMCache):
790
791 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
792
793         [GTK] GObject DOM bindings object are cached forever
794         https://bugs.webkit.org/show_bug.cgi?id=141558
795
796         Reviewed by Sergio Villar Senin.
797
798         Add checks for all DOM objects to ensure they are not leaked. Also
799         add a dedicated test for the DOM Object Cache.
800
801         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
802         (WebKitDOMNodeFilterTest::testTreeWalker):
803         (WebKitDOMNodeFilterTest::testNodeIterator):
804         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
805         (WebKitDOMNodeTest::testHierarchyNavigation):
806         (WebKitDOMNodeTest::testInsertion):
807         (WebKitDOMNodeTest::testTagNames):
808         (WebKitDOMNodeTest::testDOMCache):
809         (registerTests):
810         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
811         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
812         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
813         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
814         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
815         (testWebKitDOMObjectCache):
816         (beforeAll):
817         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
818         (documentLoadedCallback):
819
820 2015-02-16  Carlos Garcia Campos  <cgarcia@igalia.com>
821
822         [GTK] WebKitFrame objects are never released
823         https://bugs.webkit.org/show_bug.cgi?id=141641
824
825         Reviewed by Martin Robinson.
826
827         Add a way to check GObjects leaks for WebProcess tests and check
828         WebKitFrame objects are not leaked.
829
830         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:
831         (WebKitFrameTest::testMainFrame):
832         (WebKitFrameTest::testURI):
833         (WebKitFrameTest::testJavaScriptContext):
834         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
835         (WebProcessTest::assertObjectIsDeletedWhenTestFinishes):
836         (runTest):
837         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
838
839 2015-02-16  Tim Horton  <timothy_horton@apple.com>
840
841         Fix the MiniBrowser build with newer clang
842
843         * MiniBrowser/mac/SettingsController.m:
844         (-[SettingsController _toggleBooleanDefault:]):
845         * MiniBrowser/mac/WK1BrowserWindowController.m:
846         (-[WK1BrowserWindowController windowWillClose:]):
847         * MiniBrowser/mac/WK2BrowserWindowController.m:
848         (-[WK2BrowserWindowController windowWillClose:]):
849         NSApp is id and clang gets confused about which -delegate we're talking about.
850
851 2015-02-16  Antti Koivisto  <antti@apple.com>
852
853         Develop/Disable Caches does not properly disable disk cache
854         https://bugs.webkit.org/show_bug.cgi?id=141636
855
856         Reviewed by Anders Carlsson.
857
858         Make testRunner.setCacheModel() use the WKContext interface so the model gets passed to
859         the network process too.
860
861         This makes setCacheModel asynchronous but there don't seem to be any tests that expect otherwise.
862
863         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
864         (WTR::InjectedBundle::beginTesting):
865         (WTR::InjectedBundle::setCacheModel):
866         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
867         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
868
869             Forward to TestController.
870
871         (WTR::TestRunner::setCacheModel):
872         * WebKitTestRunner/TestInvocation.cpp:
873         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
874
875 2015-02-16  Andrzej Badowski  <a.badowski@samsung.com>
876
877         Unreviewed. Add myself as a committer.
878
879         * Scripts/webkitpy/common/config/contributors.json:
880
881 2015-02-15  David Kilzer  <ddkilzer@apple.com>
882
883         REGRESSION (r180082): WebCore Debug builds fail on Mavericks due to weak export symbols
884         <http://webkit.org/b/141607>
885
886         * Scripts/check-for-weak-vtables-and-externals: Ignore weak
887         externals in Source/WebCore/Configurations/WebCore.unexp when
888         building with Xcode 5.x.
889         (readXcode5SymbolsToIgnore): Add.
890
891 2015-02-15  KwangHyuk Kim  <hyuki.kim@samsung.com>
892
893         [EFL] fix Evas GL engine error.
894         https://bugs.webkit.org/show_bug.cgi?id=141621
895
896         Reviewed by Gyuyoung Kim.
897
898         As new elm engine api was added from efl 1.10, replace elm_config_preferred_engine_set with elm_config_accel_preference_set.
899
900         * MiniBrowser/efl/main.c:
901         (elm_main):
902
903 2015-02-14  Csaba Osztrogonác  <ossy@webkit.org>
904
905         [buildbot] Enable run-api-tests on release Mac bots
906         https://bugs.webkit.org/show_bug.cgi?id=141518
907
908         Reviewed by Darin Adler.
909
910         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
911         (RunUnitTests):
912         (BuildFactory.__init__):
913         (TestFactory.__init__):
914         (BuildAndTestFactory.__init__):
915         (RunUnitTests.start): Deleted.
916         (unitTestsSupported): Deleted.
917
918 2015-02-13  Anders Carlsson  <andersca@apple.com>
919
920         Add a move constructor and move assignment operator to Deque
921         https://bugs.webkit.org/show_bug.cgi?id=141571
922
923         Reviewed by Andreas Kling.
924
925         * TestWebKitAPI/Tests/WTF/Deque.cpp:
926         (TestWebKitAPI::TEST):
927
928 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
929
930         run-jsc-stress-tests --remote should skip profiler tests
931         https://bugs.webkit.org/show_bug.cgi?id=141470
932
933         Reviewed by Filip Pizlo.
934
935         * Scripts/run-jsc-stress-tests:
936
937 2015-02-13  Anders Carlsson  <andersca@apple.com>
938
939         Add an initializer list constructor to Deque
940         https://bugs.webkit.org/show_bug.cgi?id=141565
941
942         Reviewed by Andreas Kling.
943
944         * TestWebKitAPI/Tests/WTF/Deque.cpp:
945         (TestWebKitAPI::TEST):
946
947 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
948
949         [buildbot] Remove buildJSCTool cruft from master.cfg
950         https://bugs.webkit.org/show_bug.cgi?id=141513
951
952         Reviewed by Alexey Proskuryakov.
953
954         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
955         (RunJavaScriptCoreTests):
956         (RunJavaScriptCoreTests.start):
957         (RunWebKitTests):
958         (RunWebKitTests.start):
959         (TestFactory.__init__):
960         (TestLeaksFactory.__init__):
961         (RunJavaScriptCoreTests.__init__): Deleted.
962         (RunWebKitTests.__init__): Deleted.
963
964 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
965
966         Unreviewed, remove empty directories.
967
968         * DumpRenderTree/gtk: Removed.
969         * DumpRenderTree/gtk/fonts: Removed.
970         * DumpRenderTree/unix: Removed.
971         * DumpRenderTree/unix/TestNetscapePlugin: Removed.
972         * GtkLauncher: Removed.
973         * TestWebKitAPI/Tests/WebKitGtk: Removed.
974         * TestWebKitAPI/Tests/WebKitGtk/resources: Removed.
975         * WebKitTestRunner/WebKitTestRunnerAppTests: Removed.
976         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj: Removed.
977
978 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
979
980         Remove Windows cruft from Tools/Scripts/build-webkittestrunner
981         https://bugs.webkit.org/show_bug.cgi?id=141519
982
983         Reviewed by Alexey Proskuryakov.
984
985         * Scripts/build-webkittestrunner:
986
987 2015-02-12  Alex Christensen  <achristensen@webkit.org>
988
989         Removed empty directory.
990
991         * WinCELauncher: Removed.
992
993 2015-02-12  Csaba Osztrogonác  <ossy@webkit.org>
994
995         run-jsc-stress-tests --remote should be able add the necessary libraries to the bundle on Linux
996         https://bugs.webkit.org/show_bug.cgi?id=141202
997
998         Reviewed by Darin Adler.
999
1000         * Scripts/run-jsc-stress-tests:
1001
1002 2015-02-12  Brent Fulgham  <bfulgham@apple.com>
1003
1004         [Win] Test bot infrastructure should not try to find/use old Safari DLLs
1005         https://bugs.webkit.org/show_bug.cgi?id=141517
1006
1007         Reviewed by Anders Carlsson.
1008
1009         We do not need to locate or use the DLL's that came with Safari, so stop
1010         failing when we cannot find them. Also remove some old Qt cruft from this
1011         script.
1012
1013         * BuildSlaveSupport/built-product-archive:
1014         (archiveBuiltProduct): 
1015         (extractBuiltProduct):
1016
1017 2015-02-11  Brent Fulgham  <bfulgham@apple.com>
1018
1019         [Win] [64-bit] Work around MSVC2013 Runtime Bug
1020         https://bugs.webkit.org/show_bug.cgi?id=141498
1021         <rdar://problem/19803642>
1022
1023         Reviewed by Anders Carlsson.
1024
1025         Disable FMA3 instruction use in the MSVC math library to
1026         work around a VS2013 runtime crash. We can remove this
1027         workaround when we switch to VS2015.
1028
1029         * DumpRenderTree/cg/ImageDiffCG.cpp: Call _set_FMA3_enable(0) to
1030         disable FMA3 support.
1031         * DumpRenderTree/win/DumpRenderTree.cpp: Ditto.
1032         * DumpRenderTree/win/ImageDiffCairo.cpp: Ditto.
1033         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
1034         * Scripts/webkitperl/httpd.pm: Ditto.
1035         * TestWebKitAPI/win/main.cpp: Ditto.
1036         * WinLauncher/Common.cpp: Ditto.
1037         * win/DLLLauncher/DLLLauncherMain.cpp: Ditto.
1038
1039 2015-02-12  Csaba Osztrogonác  <ossy@webkit.org>
1040
1041         run-jsc-stress-tests should accept remote host config from JSON file
1042         https://bugs.webkit.org/show_bug.cgi?id=141509
1043
1044         Reviewed by Michael Saboff.
1045
1046         * Scripts/run-javascriptcore-tests:
1047         (runJSCStressTests):
1048         * Scripts/run-jsc-stress-tests:
1049
1050 2015-02-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1051
1052         [GTK] Add API to allow overriding the default color chooser implementation
1053         https://bugs.webkit.org/show_bug.cgi?id=98935
1054
1055         Reviewed by Gustavo Noronha Silva.
1056
1057         Add a color chooser implementation for MiniBrowser using
1058         GtkPopover when the GTK+ version is recent enough.
1059         And a test case to check the new color chooser API.
1060
1061         * MiniBrowser/gtk/BrowserWindow.c:
1062         (colorChooserRGBAChanged):
1063         (popoverColorClosed):
1064         (colorChooserRequestFinished):
1065         (runColorChooserCallback):
1066         (browserWindowConstructed):
1067         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1068         (testWebViewColorChooserRequest):
1069         (beforeAll):
1070
1071 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
1072
1073         Make run-jsc-stress-tests --remote work with make-based runner
1074         https://bugs.webkit.org/show_bug.cgi?id=141079
1075
1076         Reviewed by Darin Adler.
1077
1078         * Scripts/run-javascriptcore-tests:
1079         (runJSCStressTests): Pass through the --shell-runner and --make-runner arguments.
1080         * Scripts/run-jsc-stress-tests: Made the make-based runner the default runner,
1081         except for remote testing on Darwin. Unified runShellTestRunner and runMakeTestRunner
1082         to avoid code duplication.
1083
1084 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
1085
1086         run-jsc-stress tests should detect the number of processors on the remote machine too
1087         https://bugs.webkit.org/show_bug.cgi?id=141196
1088
1089         Reviewed by Darin Adler.
1090
1091         * Scripts/run-javascriptcore-tests:
1092         (runJSCStressTests): Pass through the --child-processes argument.
1093         * Scripts/run-jsc-stress-tests: Added determineNumberOfProcessors function
1094         to detect the number of local and remote processors with the same algorithm.
1095         Additionally introduced $numChildProcesses to emphasize it isn't necessarily
1096         same as $numProcessors.
1097
1098 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
1099
1100         run-jsc-stress-tests should pass JSC_timeout to remote hosts
1101         https://bugs.webkit.org/show_bug.cgi?id=141164
1102
1103         Reviewed by Darin Adler.
1104
1105         Additonally removed IMPORTANT_ENVS, since JSC_timeout was the only one.
1106
1107         * Scripts/run-jsc-stress-tests:
1108
1109 2015-02-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1110
1111         [GTK] Add default color chooser implementation using GtkColorChooserDialog
1112         https://bugs.webkit.org/show_bug.cgi?id=141392
1113
1114         Reviewed by Gustavo Noronha Silva.
1115
1116         Enable INPUT_TYPE_COLOR by default for GTK+ port.
1117
1118         * Scripts/webkitperl/FeatureList.pm:
1119
1120 2015-02-09  Csaba Osztrogonác  <ossy@webkit.org>
1121
1122         run-jsc-stress-tests shell test runner should run tests in fixed order
1123         https://bugs.webkit.org/show_bug.cgi?id=141383
1124
1125         Reviewed by Darin Adler.
1126
1127         * Scripts/jsc-stress-test-helpers/shell-runner.sh:
1128
1129 2015-02-08  Chris Fleizach  <cfleizach@apple.com>
1130
1131         AX: VoiceOver appears unresponsive when JavaScript alerts are triggered via focus or blur events
1132         https://bugs.webkit.org/show_bug.cgi?id=140485
1133
1134         Reviewed by Anders Carlsson.
1135
1136         Implement takeFocus() as a way to set focus through accessibility wrappers.
1137
1138         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1139         (AccessibilityUIElement::takeFocus):
1140         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1141         (WTR::AccessibilityUIElement::takeFocus):
1142
1143 2015-02-08  Darin Adler  <darin@apple.com>
1144
1145         Remove the SVG instance tree
1146         https://bugs.webkit.org/show_bug.cgi?id=140602
1147
1148         Reviewed by Dean Jackson.
1149
1150         * Scripts/check-for-global-initializers: Removed special case for
1151         SVGElementInstance.o.
1152
1153 2015-02-07  David Kilzer  <ddkilzer@apple.com>
1154
1155         [iOS] run-webkit-tests fails due to simulator devices from previous SDK installs being marked as unavailable
1156         <http://webkit.org/b/141365>
1157
1158         Reviewed by Daniel Bates.
1159
1160         * Scripts/webkitpy/xcode/simulator.py:
1161         (Simulator): Add unavailable_version_re precompiled regex.
1162         (Simulator._parse_devices): Check for unavailable versions and
1163         ignore them if found when parsing the output of
1164         `xcrun simctl list`.
1165         * Scripts/webkitpy/xcode/simulator_unittest.py:
1166         (test_unavailable_devices): Add test with output from
1167         `xcrun simctl list` with unavailable runtimes that fails before
1168         the fix.
1169
1170 2015-02-07  Chris Dumez  <cdumez@apple.com>
1171
1172         Add Vector::removeFirstMatching() / removeAllMatching() methods taking lambda functions
1173         https://bugs.webkit.org/show_bug.cgi?id=141321
1174
1175         Reviewed by Darin Adler.
1176
1177         Use new Vector::removeFirstMatching() / removeAllMatching() methods.
1178
1179 2015-02-07  David Kilzer  <ddkilzer@apple.com>
1180
1181         [iOS] Make Simulator class testable
1182         <http://webkit.org/b/141358>
1183
1184         Rubber-stamped by Darin Adler.
1185
1186         * Scripts/webkitpy/common/system/platforminfo.py:
1187         (PlatformInfo.xcode_simctl_list): Move `xcrun simctl list`
1188         command to here from Simulator.refresh() in xcode/simulator.py
1189         so that the output of the command can be mocked.
1190
1191         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1192         (MockPlatformInfo.__init__): Set self.expected_xcode_simctl_list
1193         to None.
1194         (MockPlatformInfo.xcode_simctl_list): Add method that returns
1195         self.expected_xcode_simctl_list expectation.
1196
1197         * Scripts/webkitpy/xcode/simulator.py: Add missing copyright
1198         and license header.
1199         (Simulator.__init__): Add optional 'host' parameter to make it
1200         possible to pass in a mock object for testing.  Set self._host
1201         to 'host' parameter or create Host() object.
1202         (Simulator.refresh): Call new PlatformInfo.xcode_simctl_list()
1203         method.
1204
1205         * Scripts/webkitpy/xcode/simulator_unittest.py: Add unit test
1206         for current code.
1207         (SimulatorTest):
1208         (SimulatorTest.setUp):
1209         (SimulatorTest._set_expected_xcrun_simctl_list):
1210         (SimulatorTest.test_simulator_device_types):
1211         (test_invalid_device_types_header):
1212         (test_invalid_runtimes_header):
1213         (test_invalid_devices_header):
1214
1215 2015-02-07  Csaba Osztrogonác  <ossy@webkit.org>
1216
1217         run-jsc-stress-tests --remote should use the default ssh port
1218         https://bugs.webkit.org/show_bug.cgi?id=141287
1219
1220         Reviewed by Darin Adler.
1221
1222         * Scripts/run-jsc-stress-tests: Extended URI module to be able to handle ssh scheme with the default 22 port number.
1223
1224 2015-02-06  Dana Burkart  <dburkart@apple.com>
1225
1226         dashboard: BuildbotTesterQueueView crashesOnly logic is wrong
1227         https://bugs.webkit.org/show_bug.cgi?id=141349
1228
1229         Reviewed by Alexey Proskuryakov.
1230
1231         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1232         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1233         (BuildbotTesterQueueView.prototype.update):
1234
1235 2015-02-06  Alexey Proskuryakov  <ap@apple.com>
1236
1237         Report network process crashes during layout tests
1238         https://bugs.webkit.org/show_bug.cgi?id=139646
1239
1240         Reviewed by Anders Carlsson.
1241
1242         * WebKitTestRunner/TestController.cpp:
1243         (WTR::TestController::initialize):
1244         (WTR::TestController::networkProcessName):
1245         (WTR::TestController::networkProcessDidCrash):
1246         * WebKitTestRunner/TestController.h:
1247
1248 2015-02-06  Csaba Osztrogonác  <ossy@webkit.org>
1249
1250         run-jsc-stress-tests --remote should create remote directory before copying the bundle
1251         https://bugs.webkit.org/show_bug.cgi?id=141329
1252
1253         Reviewed by Michael Saboff.
1254
1255         * Scripts/run-jsc-stress-tests:
1256
1257 2015-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1258
1259         [GTK] Remove WebKitWebView::close-notification signal
1260         https://bugs.webkit.org/show_bug.cgi?id=141330
1261
1262         Reviewed by Gustavo Noronha Silva.
1263
1264         Update notifications unit tests according to the API changes, and
1265         add a test case to check that onclose event is fired when a
1266         notification is closed by the user.
1267
1268         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1269         (testWebViewNotification):
1270
1271 2015-02-05  Alexey Proskuryakov  <ap@apple.com>
1272
1273         Dashboard doesn't consider building ASan a productive step
1274         https://bugs.webkit.org/show_bug.cgi?id=141312
1275
1276         Reviewed by Simon Fraser.
1277
1278         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1279
1280 2015-02-05  Daniel Bates  <dabates@apple.com>
1281
1282         [iOS] webkitpy.xcode.simulator.Runtime.from_identifier() returns wrong result for non-existent runtime
1283         https://bugs.webkit.org/show_bug.cgi?id=141306
1284
1285         Reviewed by Alexey Proskuryakov.
1286
1287         The function webkitpy.xcode.simulator.Runtime.from_identifier always returns a Runtime object
1288         corresponding to the last-most runtime parsed from the output of `simctl list` for any non-
1289         existent runtime.
1290
1291         * Scripts/webkitpy/xcode/simulator.py:
1292         (Runtime.from_identifier):
1293
1294 2015-02-05  Daniel Bates  <dabates@apple.com>
1295
1296         LayoutTestRelay does not install DumpRenderTree.app/WebKitTestRunnerApp.app
1297         https://bugs.webkit.org/show_bug.cgi?id=139746
1298         <rdar://problem/19283658>
1299
1300         Reviewed by Alexey Proskuryakov.
1301
1302         Fixes an issues where LayoutTestRelay may fail to install DumpRenderTree.app/WebKitTestRunnerApp.app
1303         if the simulator device is not in state Booted.
1304
1305         Currently run-webkit-test --ios-sim executes LayoutTestRelay immediately after
1306         launching/relaunching the iOS Simulator app and a simulator app can only be installed
1307         on a device that is in the Booted state. LayoutTestRelay may run before the
1308         device is booted and hence fail to install DumpRenderTree.app/WebKitTestRunnerApp.app.
1309         We should defer executing LayoutTestRelay until the simulator device booted by
1310         iOS Simulator is in the Booted state.
1311
1312         * Scripts/webkitpy/port/ios.py: Import webkitpy.xcode.simulator.Simulator to avoid prefixing
1313         Simulator methods with the module name, simulator.
1314         (IOSSimulatorPort.setup_test_run): Wait for the simulator device to be in the Booted state
1315         after launching iOS Simulator. Also, wait until the simulator device is in the Shutdown state
1316         before launching iOS Simulator to boot it.
1317         (IOSSimulatorPort.testing_device): Fix up caller since we now import webkitpy.xcode.simulator.Simulator.
1318         (IOSSimulatorPort.simulator_path): Deleted; moved this function to class Simulator and renamed to device_directory().
1319         * Scripts/webkitpy/xcode/simulator.py:
1320         (Device.__init__): Remove parameter state and an instance variable of the same name, which represented
1321         the state of the device when we created this object as part of parsing the output of `simctl list`. Callers
1322         interested in the state of the device are more likely interested in the current state of the device as
1323         opposed to the state of the device when the Device object was created.
1324         (Device.state): Added; turn around and call Simulator.device_state() for the current state of the device.
1325         (Device.path): Extracted implementation into Simulator.device_directory() so that it can be called
1326         from both this function and Simulator.device_state().
1327         (Device.create): Use Simulator.wait_until_device_is_in_state() to simplify the implementation of this function.
1328         (Simulator.DeviceState): Added; class of constants.
1329         (Simulator.wait_until_device_is_in_state): Added; this function does not return until the specified
1330         device is in the specified state.
1331         (Simulator.device_state): Added; parses the state of the device from the appropriate CoreSimulator device.plist file.
1332         (Simulator.device_directory): Added.
1333         (Simulator._parse_devices): Do not pass argument state to Device constructor as it no longer accepts it.
1334
1335 2015-02-05  Alexey Proskuryakov  <ap@apple.com>
1336
1337         Disable retries on Mac debug testers
1338         https://bugs.webkit.org/show_bug.cgi?id=141296
1339
1340         Reviewed by Simon Fraser.
1341
1342         * BuildSlaveSupport/build.webkit.org-config/config.json:
1343
1344 2015-02-05  Dan Bernstein  <mitz@apple.com>
1345
1346         Need a way to force $xcodeSDK in webkitdirs.pm
1347         https://bugs.webkit.org/show_bug.cgi?id=141291
1348
1349         Reviewed by Anders Carlsson.
1350
1351         * Scripts/webkitdirs.pm:
1352         (setXcodeSDK): Added.
1353
1354 2015-02-05  Youenn Fablet  <youenn.fablet@crf.canon.fr> and Xabier Rodriguez Calvar <calvaris@igalia.com>
1355
1356         [Streams API] Implement a barebone ReadableStream interface
1357         https://bugs.webkit.org/show_bug.cgi?id=141045
1358
1359         Reviewed by Benjamin Poulain.
1360
1361         * Scripts/webkitperl/FeatureList.pm: Added streams-api compilation switch.
1362
1363 2015-02-04  Joseph Pecoraro  <pecoraro@apple.com>
1364
1365         filter-build-webkit: reduce more unfiltered output
1366         https://bugs.webkit.org/show_bug.cgi?id=141282
1367
1368         Reviewed by Daniel Bates.
1369
1370         * Scripts/filter-build-webkit:
1371         Report CompileDTraceScript and Preprocess lines as successful.
1372
1373 2015-02-04  Dana Burkart  <dburkart@apple.com>
1374
1375         Botwatcher's Dashboard is cramped
1376         https://bugs.webkit.org/show_bug.cgi?id=140273
1377
1378         Reviewed by Alexey Proskuryakov.
1379
1380         Add a heading key which will allow for arbitrary headings in builder queues.
1381
1382         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
1383         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
1384         (BuildbotBuilderQueueView.prototype.update):
1385         (BuildbotBuilderQueueView.prototype.update.appendBuildArchitecture): Deleted.
1386         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1387         (BuildbotIteration.prototype._parseData):
1388         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
1389         (BuildbotLeaksQueueView.prototype.update):
1390         (BuildbotLeaksQueueView.prototype.update.appendBuild): Deleted.
1391         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
1392         (BuildbotPerformanceQueueView.prototype.update):
1393         (BuildbotPerformanceQueueView.prototype.update.appendBuild): Deleted.
1394         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1395         (BuildbotQueue):
1396         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1397         (BuildbotQueueView.prototype._unauthorizedAccess):
1398         (BuildbotQueueView.prototype._appendBuild):
1399         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1400         (BuildbotTestResults):
1401         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1402         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1403         (BuildbotTesterQueueView.prototype.update):
1404         (BuildbotTesterQueueView.prototype.update.appendBuild): Deleted.
1405
1406 2015-02-04  Simon Fraser  <simon.fraser@apple.com>
1407
1408         WKTR should not use -mainScreen to pick a color profile
1409         https://bugs.webkit.org/show_bug.cgi?id=141265
1410
1411         Reviewed by Tim Horton.
1412         
1413         -[NSScreen mainScreen] depends on the active window, so use the first screen
1414         (which is the one we put the window on anyway).
1415         
1416         Do some cleanup in DRT that makes the code look similar.
1417
1418         * DumpRenderTree/mac/DumpRenderTree.mm:
1419         (createWebViewAndOffscreenWindow):
1420         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1421         (WTR::PlatformWebView::PlatformWebView):
1422
1423 2015-02-04  Simon Fraser  <simon.fraser@apple.com>
1424
1425         LayoutTestHelper should set the color profile of all displays
1426         https://bugs.webkit.org/show_bug.cgi?id=141260
1427
1428         Reviewed by Tim Horton.
1429         
1430         WebKitTestRunner can (erroneously) grab the colorspace of the "main" screen.
1431         which is the screen with the active window. Make things more robust by changing
1432         the colorspace of all displays, not just the main screen, when running layout tests.
1433
1434         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig: Enable ARC
1435         * DumpRenderTree/mac/LayoutTestHelper.m: 
1436         (originalColorProfileURLs):
1437         (colorProfileURLForDisplay):
1438         (displayUUIDStrings):
1439         (saveDisplayColorProfiles):
1440         (setDisplayColorProfile):
1441         (restoreDisplayColorProfiles):
1442         (installLayoutTestColorProfile):
1443         (restoreUserColorProfile):
1444         (main):        
1445         Store display color profiles by map of UUID strings to URLs (NSUUID and CFUUID are not
1446         toll-free bridged, sadly). Use the map to restore all profiles on exit.
1447         Convert to use more Obj-C types.
1448
1449 2015-02-04  Daniel Bates  <dabates@apple.com>
1450
1451         test-webkitpy fails on Mac without iphoneos SDK
1452         https://bugs.webkit.org/show_bug.cgi?id=141255
1453         <rdar://problem/19619691>
1454
1455         I inadvertently committed the wrong exception message. Fix up the exception message
1456         to instruct a person to install the iOS SDK when it cannot be found.
1457
1458         * Scripts/webkitpy/port/ios.py:
1459         (IOSPort.determine_full_port_name):
1460
1461 2015-02-04  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1462
1463         W3C test importer should sort the list of files when generating the w3c-import.log
1464         https://bugs.webkit.org/show_bug.cgi?id=141156
1465
1466         Reviewed by Bem Jones-Bey.
1467
1468         Sort explicitly the list of imported files written in the w3c-import.log.
1469         Removed logging of the import date.
1470
1471         * Scripts/webkitpy/w3c/test_importer.py:
1472         (TestImporter.write_import_log):
1473
1474 2015-02-04  Daniel Bates  <dabates@apple.com>
1475
1476         test-webkitpy fails on Mac without iphoneos SDK
1477         https://bugs.webkit.org/show_bug.cgi?id=141255
1478         <rdar://problem/19619691>
1479
1480         Reviewed by David Kilzer and Alexey Proskuryakov.
1481
1482         Fixes an issue where test-webkitpy fails on a Mac without the iOS SDK. We should
1483         should not require the iphoneos SDK to be installed to run the webkitpy tests.
1484
1485         * Scripts/webkitpy/common/system/platforminfo.py:
1486         (PlatformInfo.xcode_sdk_version): Added; return the version of the specified SDK, if
1487         installed. We take advantage of the behavior that xcrun --show-sdk-version only writes
1488         to standard output if the SDK is installed to return the empty string if the SDK is
1489         not installed.
1490         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1491         (MockPlatformInfo.xcode_sdk_version): Added.
1492         * Scripts/webkitpy/port/ios.py:
1493         (IOSPort.determine_full_port_name): Modified to call PlatformInfo.xcode_sdk_version()
1494         to get the version of the iphoneos SDK, if installed.
1495
1496 2015-02-04  Alexey Proskuryakov  <ap@apple.com>
1497
1498         run-webkit-tests doesn't always capture ASan violation reports
1499         https://bugs.webkit.org/show_bug.cgi?id=141231
1500
1501         Reviewed by Darin Adler.
1502
1503         * Scripts/webkitpy/port/driver.py:
1504         (Driver.run_test): Don't look for CrashReporter crash logs if a log was provided
1505         by the driver already (as is the case with ASan violations, which are printed to
1506         stderr).
1507         (Driver._check_for_address_sanitizer_violation): Check if the line is a start of ASan
1508         report.
1509         (Driver._read_block): Give ASan enough time to symbolicate a crash, and put it into
1510         a separate variable for reporting.
1511
1512 2015-02-03  Ryosuke Niwa  <rniwa@webkit.org>
1513
1514         [webkitpy] Add platform specific Skipped file mechanism for performance tests
1515         https://bugs.webkit.org/show_bug.cgi?id=141152
1516
1517         Reviewed by Csaba Osztrogonác.
1518
1519         Support a test-expectation-like syntax in performance tests' skipped files.
1520         e.g. [Mac] Parsed/BadTest.html will skip Parsed/BadTest.html on Mac ports.
1521
1522         * Scripts/webkitpy/port/base.py:
1523         (Port.skipped_perf_tests): Implemented the syntax support by a regular expression.
1524
1525         * Scripts/webkitpy/port/base_unittest.py:
1526         (PortTest.test_skipped_perf_tests): Test the new syntax.
1527
1528 2015-02-04  Alexey Proskuryakov  <ap@apple.com>
1529
1530         When tests fail on leaks bot so much that there are no leaks detected, dashboard erroneously shows green
1531         https://bugs.webkit.org/show_bug.cgi?id=141236
1532
1533         Reviewed by Sam Weinig.
1534
1535         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
1536         (BuildbotLeaksQueueView.prototype.update.appendLeaksQueueStatus):
1537
1538 2015-02-04  Chris Dumez  <cdumez@apple.com>
1539
1540         Add removeFirst(value) / removeAll(value) methods to WTF::Vector
1541         https://bugs.webkit.org/show_bug.cgi?id=141192
1542
1543         Reviewed by Benjamin Poulain.
1544
1545         Add API tests for Vector::removeFirst(value) and
1546         Vector::removeAll(value).
1547
1548         * TestWebKitAPI/Tests/WTF/Vector.cpp:
1549         (TestWebKitAPI::TEST):
1550
1551 2015-02-03  Tim Horton  <timothy_horton@apple.com>
1552
1553         Add WKPageNavigationClient as C SPI around API::NavigationClient, and adopt in WKTR
1554         https://bugs.webkit.org/show_bug.cgi?id=141217
1555
1556         Reviewed by Sam Weinig.
1557
1558         * WebKitTestRunner/TestController.cpp:
1559         (WTR::copyWebCryptoMasterKey):
1560         (WTR::TestController::createOtherPage):
1561         (WTR::TestController::createWebViewWithOptions):
1562         (WTR::TestController::ensureViewSupportsOptions):
1563         (WTR::TestController::didCommitNavigation):
1564         (WTR::TestController::didFinishNavigation):
1565         (WTR::TestController::canAuthenticateAgainstProtectionSpace):
1566         (WTR::TestController::didReceiveAuthenticationChallenge):
1567         (WTR::TestController::decidePolicyForPluginLoad):
1568         (WTR::TestController::decidePolicyForNavigationAction):
1569         (WTR::TestController::decidePolicyForNavigationResponse):
1570         (WTR::TestController::didCommitLoadForFrame): Deleted.
1571         (WTR::TestController::didFinishLoadForFrame): Deleted.
1572         * WebKitTestRunner/TestController.h:
1573         Adopt WKPageNavigationClient and adjust to its semantics (navigations are main-frame-only, etc.)
1574
1575 2015-02-03  Dhi Aurrahman  <diorahman@rockybars.com>
1576
1577         Unreviewed. Add myself as a committer.
1578
1579         * Scripts/webkitpy/common/config/contributors.json:
1580
1581 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
1582
1583         [Win] Unreviewed test fix.
1584
1585         * DumpRenderTree/win/PolicyDelegate.cpp:
1586         (PolicyDelegate::unableToImplementPolicyWithError): The message was missing a linefeed,
1587         so was not matching expected output.
1588
1589 2015-02-03  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1590
1591         Unreviewed. Moving myself to the committer section at last.
1592
1593         * Scripts/webkitpy/common/config/contributors.json:
1594
1595 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
1596
1597         [Win] Tests fail because DRT reports '(null)' instead of an empty string
1598         https://bugs.webkit.org/show_bug.cgi?id=141205
1599
1600         Reviewed by Anders Carlsson.
1601
1602         * DumpRenderTree/win/HistoryDelegate.cpp:
1603         (HistoryDelegate::didNavigateWithNavigationData): Deal with empty BSTR values
1604         properly so that we match expected DumpRenderTree output.
1605
1606 2015-02-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1607
1608         [GTK] TestWebKitAccessibility is not skipped
1609         https://bugs.webkit.org/show_bug.cgi?id=141179
1610
1611         Reviewed by Carlos Garcia Campos.
1612
1613         Don't attempt to skip TestWebKitAccessibility. This path is wrong so it was not being
1614         skipped, and it apparently works reliably on the bots.
1615
1616         * Scripts/run-gtk-tests:
1617         (TestRunner):
1618
1619 2015-02-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1620
1621         run-perf-tests: allow to specify a wrapper command.
1622         https://bugs.webkit.org/show_bug.cgi?id=141172
1623
1624         Reviewed by Ryosuke Niwa.
1625
1626         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1627         (parse_args): Update text to indicate is also valid for WTR.
1628         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1629         (PerfTestsRunner._parse_args): Add wrapper command.
1630
1631 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
1632
1633         [Win] Correct version parsing warning in update-webkit
1634         https://bugs.webkit.org/show_bug.cgi?id=141200
1635
1636         Reviewed by Anders Carlsson.
1637
1638         * Scripts/webkitdirs.pm:
1639         (setupAppleWinEnv): Strip out any specific version build level
1640         from the Cygwin version information.
1641   
1642
1643 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
1644
1645         [Win] Attempt to improve the reliability of HTTP service
1646         https://bugs.webkit.org/show_bug.cgi?id=141191
1647
1648         Reviewed by Darin Adler.
1649
1650         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1651         (LayoutTestApacheHttpd.__init__): Use default XAMPP pidfile location.
1652         (LayoutTestApacheHttpd._stop_running_server): Delete the abandoned PID file
1653         when stopping the service doesn't do so on its own (for Windows runs).
1654
1655 2015-02-03  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1656
1657         Web platform test server should not need to create __init__.py files
1658         https://bugs.webkit.org/show_bug.cgi?id=141030
1659
1660         Reviewed by Ryosuke Niwa.
1661
1662         W3C TestImporter ensures that copied __init__.py files are not empty.
1663         If needed, a comment is inserted in __init__.py files.
1664         Added a unit test to check that web-platform-tests tools and scripts python modules can be imported.
1665
1666         * Scripts/webkitpy/common/system/filesystem.py:
1667         (FileSystem.getsize):
1668         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
1669         (TestWebPlatformTestServer.test_start_cmd):
1670         (TestWebPlatformTestServer):
1671         (TestWebPlatformTestServer.test_import_web_platform_test_modules):
1672         * Scripts/webkitpy/w3c/test_importer.py:
1673         (TestImporter.import_tests):
1674
1675 2015-01-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1676
1677         Unreviewed. Moving myself to the committer section.
1678
1679         * Scripts/webkitpy/common/config/contributors.json:
1680
1681 2015-02-02  Saam Barati  <saambarati1@gmail.com>
1682
1683         Create tests for JSC's Control Flow Profiler
1684         https://bugs.webkit.org/show_bug.cgi?id=141123
1685
1686         Reviewed by Filip Pizlo.
1687
1688         * Scripts/run-javascriptcore-tests:
1689         (runJSCStressTests):
1690         * Scripts/run-jsc-stress-tests:
1691
1692 2015-02-02  Csaba Osztrogonác  <ossy@webkit.org>
1693
1694         Remove copy/paste code from run-jsc-stress-tests to determine numberOfTests
1695         https://bugs.webkit.org/show_bug.cgi?id=141158
1696
1697         Reviewed by Darin Adler.
1698
1699         * Scripts/run-jsc-stress-tests:
1700
1701 2015-02-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1702
1703         [GTK] MiniBrowser should close itself on Ctrl+W or Ctrl+Q
1704         https://bugs.webkit.org/show_bug.cgi?id=141142
1705
1706         Reviewed by Carlos Garcia Campos.
1707
1708         * MiniBrowser/gtk/BrowserWindow.c:
1709         (browser_window_init): Quit on Ctrl+W or Ctrl+Q
1710
1711 2015-02-01  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1712
1713         Web platform test server is not always launching properly on Mac EWS bots
1714         https://bugs.webkit.org/show_bug.cgi?id=141141
1715
1716         Unreviewed.
1717
1718         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
1719         (create_wpt_empty_file_if_needed): Removed creation of empty __init.py__ files from AutoInstalled modules.
1720
1721 2015-01-31  Sam Weinig  <sam@webkit.org>
1722
1723         Remove even more Mountain Lion support
1724         https://bugs.webkit.org/show_bug.cgi?id=141124
1725
1726         Reviewed by Alexey Proskuryakov.
1727
1728         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1729         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
1730         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1731         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1732         * DumpRenderTree/mac/DumpRenderTree.mm:
1733         (activateTestingFonts):
1734         (prepareConsistentTestingEnvironment):
1735         * DumpRenderTree/mac/EventSendingController.mm:
1736         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
1737         (-[EventSendingController contextClick]):
1738         * DumpRenderTree/mac/TextInputController.m:
1739         * LayoutTestRelay/Configurations/Base.xcconfig:
1740         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1741         * MiniBrowser/Configurations/Base.xcconfig:
1742         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1743         * MiniBrowser/mac/WK2BrowserWindowController.m:
1744         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1745         (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
1746         (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
1747         * TestWebKitAPI/Configurations/Base.xcconfig:
1748         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1749         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1750         (-[DownloadDelegate _downloadDidFinish:]):
1751         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
1752         (TestWebKitAPI::TEST):
1753         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
1754         (TestWebKitAPI::InjectedBundleController::platformInitialize):
1755         * WebKitLauncher/Configurations/Base.xcconfig:
1756         * WebKitTestRunner/Configurations/Base.xcconfig:
1757         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1758         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1759         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
1760         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
1761         (WTR::activateFonts):
1762         * WebKitTestRunner/TestController.cpp:
1763         (WTR::TestController::initialize):
1764         (WTR::TestController::webProcessName):
1765         * WebKitTestRunner/mac/EventSenderProxy.mm:
1766         * asan/asan.xcconfig:
1767
1768 2015-01-31  Commit Queue  <commit-queue@webkit.org>
1769
1770         Unreviewed, rolling out r179408.
1771         https://bugs.webkit.org/show_bug.cgi?id=141117
1772
1773         This didn't fully fix the issue (Requested by anttik on
1774         #webkit).
1775
1776         Reverted changeset:
1777
1778         "OSObjectPtr does not work with dispatch_data_t on Maverics"
1779         https://bugs.webkit.org/show_bug.cgi?id=141081
1780         http://trac.webkit.org/changeset/179408
1781
1782 2015-01-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1783
1784         https://trac.webkit.org/changeset/179439 breaks a python test
1785         https://bugs.webkit.org/show_bug.cgi?id=141114
1786
1787         Unreviewed.
1788
1789         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1790         (WebPlatformTestServer._install_modules): Checks whether WPTModules file exists before reading it as no such file exists in mock tests.  
1791
1792 2015-01-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1793
1794         Import W3C web platform tests infrastructure
1795         https://bugs.webkit.org/show_bug.cgi?id=140934
1796
1797         Reviewed by Ryosuke Niwa.
1798
1799         Loading necessary web platform tests modules before launching server.
1800         Ensuring that some empty __init__.py files are present and create them if necessary. 
1801
1802         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
1803         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1804
1805 2015-01-30  Brent Fulgham  <bfulgham@apple.com>
1806
1807         [Win] Another unreviewed test fix.
1808
1809         Correct copy/paste error in buildbot handling.
1810
1811         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1812         (LayoutTestApacheHttpd.__init__):
1813         (LayoutTestApacheHttpd._get_apache_config_file_path):
1814
1815 2015-01-30  Brent Fulgham  <bfulgham@apple.com>
1816
1817         [Win] Unreviewed test fix.
1818
1819         Correct path handling based on failures on test bots to get things running again.
1820
1821         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1822         (LayoutTestApacheHttpd.__init__):
1823         (LayoutTestApacheHttpd._get_apache_config_file_path):
1824
1825 2015-01-30  Chris Dumez  <cdumez@apple.com>
1826
1827         Unreviewed. Fix Windows build after r179409.
1828
1829         * DumpRenderTree/win/TestRunnerWin.cpp:
1830         (TestRunner::notifyDone):
1831         (TestRunner::queueLoad):
1832
1833 2015-01-30  Chris Dumez  <cdumez@apple.com>
1834
1835         Rename shared() static member functions to singleton() for singleton classes.
1836         https://bugs.webkit.org/show_bug.cgi?id=141088
1837
1838         Reviewed by Ryosuke Niwa and Benjamin Poulain.
1839
1840         Rename shared() static member functions to singleton() for singleton
1841         classes as per the recent coding style change.
1842
1843 2015-01-30  Antti Koivisto  <antti@apple.com>
1844
1845         OSObjectPtr does not work with dispatch_data_t on Maverics
1846         https://bugs.webkit.org/show_bug.cgi?id=141081
1847
1848         Reviewed by Pratik Solanki.
1849
1850         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp:
1851         (TestWebKitAPI::TEST):
1852
1853 2015-01-30  Brent Fulgham  <bfulgham@apple.com>
1854
1855         [Win] Switch to Apache on Windows
1856         https://bugs.webkit.org/show_bug.cgi?id=141060
1857
1858         Reviewed by Alexey Proskuryakov.
1859
1860         Update our scripts under Windows (and Cygwin) to locate and use
1861         the XAMPP installation of Apache for running tests.
1862
1863         * Scripts/run-webkit-httpd:
1864         * Scripts/webkitperl/httpd.pm:
1865         (getHTTPDPath):
1866         (getDefaultConfigForTestDirectory):
1867         (getHTTPDConfigPathForTestDirectory):
1868         * Scripts/webkitpy/common/system/executive_unittest.py:
1869         (ExecutiveTest.serial_test_kill_process):
1870         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1871         (LayoutTestApacheHttpd.__init__):
1872         (LayoutTestApacheHttpd._get_apache_config_file_path):
1873         (LayoutTestApacheHttpd._stop_running_server):
1874         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1875         (HttpServerBase._is_server_running_on_all_ports):
1876         * Scripts/webkitpy/port/base.py:
1877         (Port._apache_config_file_name_for_platform):
1878         * Scripts/webkitpy/port/port_testcase.py:
1879         (test_apache_config_file_name_for_platform):
1880         * Scripts/webkitpy/port/win.py:
1881         (WinPort.show_results_html_file):
1882         (WinPort._uses_apache):
1883         (WinPort):
1884         (WinPort._path_to_apache):
1885
1886 2015-01-29  Alexey Proskuryakov  <ap@apple.com>
1887
1888         Built result takes too long to be compressed on bots
1889         https://bugs.webkit.org/show_bug.cgi?id=141056
1890
1891         Reviewed by Daniel Bates.
1892
1893         Reduces compression time from ~3.5 min to ~1.5 min. Archive size gets 2% bigger.
1894
1895         * BuildSlaveSupport/test-result-archive: (archiveTestResults):
1896
1897 2015-01-29  Sam Weinig  <sam@webkit.org>
1898
1899         Remove support for screen font substitution
1900         https://bugs.webkit.org/show_bug.cgi?id=141038
1901
1902         Reviewed by Tim Horton.
1903
1904         * DumpRenderTree/win/DumpRenderTree.cpp:
1905         (resetWebPreferencesToConsistentValues):
1906         Remove call to now setScreenFontSubstitutionEnabled() which is a no-op.
1907
1908 2015-01-29  Csaba Osztrogonác  <ossy@webkit.org>
1909
1910         Make run-jsc-stress-tests --remote work on Linux too
1911         https://bugs.webkit.org/show_bug.cgi?id=141000
1912
1913         Reviewed by Darin Adler.
1914
1915         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Omit error message of sysctl,
1916         use bash/dash compatible signal names, use Linux/Mac compatible find options,
1917         use bash/dash compatible functions.
1918         * Scripts/run-jsc-stress-tests: Use Linux/Mac compatible find options.
1919
1920 2015-01-29  Csaba Osztrogonác  <ossy@webkit.org>
1921
1922         [buildbot] Simplify jscore-test buildstep
1923         https://bugs.webkit.org/show_bug.cgi?id=140821
1924
1925         Reviewed by Alexey Proskuryakov.
1926
1927         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1928         (RunJavaScriptCoreTests): Inherited from TestWithFailureCount and removed useless actual.html logfile.
1929         (RunJavaScriptCoreTests.countFailures): Added.
1930         (RunJavaScriptCoreTests.commandComplete): Deleted.
1931         (RunJavaScriptCoreTests.evaluateCommand): Deleted.
1932         (RunJavaScriptCoreTests.getText): Deleted.
1933         (RunJavaScriptCoreTests.getText2): Deleted.
1934         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated.
1935         (RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output):
1936         (RunJavaScriptCoreTestsTest.test_mozilla_failures_old_output):
1937         (RunJavaScriptCoreTestsTest.test_jsc_stress_failure_new_output):
1938         (RunJavaScriptCoreTestsTest.test_jsc_stress_failures_new_output):
1939
1940 2015-01-29  Csaba Osztrogonác  <ossy@webkit.org>
1941
1942         Unreviewed, revert r179337, we don't need this dependency.
1943
1944         * efl/install-dependencies:
1945         * gtk/install-dependencies:
1946
1947 2015-01-28  Shivakumar JM  <shiva.jm@samsung.com>
1948
1949         Unreviewed. Moving myself to the committer section.
1950
1951         * Scripts/webkitpy/common/config/contributors.json:
1952
1953 2015-01-28  Csaba Osztrogonác  <ossy@webkit.org>
1954
1955         URTBF after r179326, added uuid-dev package as new dependency.
1956
1957         * efl/install-dependencies:
1958         * gtk/install-dependencies:
1959
1960 2015-01-28  Timothy Horton  <timothy_horton@apple.com>
1961
1962         Add a WebKitMessageRecorder DTrace provider, exposing IPC details to DTrace
1963         https://bugs.webkit.org/show_bug.cgi?id=140673
1964
1965         Reviewed by Sam Weinig.
1966
1967         * Scripts/dtrace/trace-webkit2-messages.d: Added.
1968         Add a DTrace script that outputs a small blob of JSON per message.
1969
1970 2015-01-28  Geoffrey Garen  <ggaren@apple.com>
1971
1972         Removed fastMallocForbid / fastMallocAllow
1973         https://bugs.webkit.org/show_bug.cgi?id=141012
1974
1975         Reviewed by Mark Hahnenberg.
1976
1977         Fixed a test bug I noticed while testing.
1978
1979         * DumpRenderTree/JavaScriptThreading.cpp:
1980         (stopJavaScriptThreads): Lock the javaScriptThreads lock before
1981         accessing javaScriptThreads -- otherwise, you'll ASSERT.
1982
1983 2015-01-28  Dana Burkart  <dburkart@apple.com>
1984
1985         asan.xcconfig should use CLANG_ADDRESS_SANITIZER=YES instead of -fsanitize=address
1986         https://bugs.webkit.org/show_bug.cgi?id=141015
1987
1988         Reviewed by Alexey Proskuryakov.
1989
1990         * asan/asan.xcconfig:
1991
1992 2015-01-28  Sam Weinig  <sam@webkit.org>
1993
1994         Fix the build.
1995
1996         * Scripts/copy-webkitlibraries-to-product-directory:
1997
1998 2015-01-28  Lucas Forschler  <lforschler@apple.com>
1999
2000         Increase the FileUpload block size in an attempt to improve network performance.
2001         
2002         Reviewed by Alexey Proskuryakov.
2003         
2004         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2005         (UploadBuiltProduct.__init__):
2006
2007 2015-01-28  Dana Burkart  <dburkart@apple.com>
2008
2009         Move ASan flag settings from DebugRelease.xcconfig to Base.xcconfig
2010         https://bugs.webkit.org/show_bug.cgi?id=136765
2011
2012         Reviewed by Alexey Proskuryakov.
2013
2014         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2015         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2016         * LayoutTestRelay/Configurations/Base.xcconfig:
2017         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
2018         * MiniBrowser/Configurations/Base.xcconfig:
2019         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2020         * TestWebKitAPI/Configurations/Base.xcconfig:
2021         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2022         * WebKitLauncher/Configurations/Base.xcconfig:
2023         * WebKitTestRunner/Configurations/Base.xcconfig:
2024         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2025
2026 2015-01-28  Joanmarie Diggs  <jdiggs@igalia.com>
2027
2028         AX: [ATK] Implement support for new AtkRole types for MathML
2029         https://bugs.webkit.org/show_bug.cgi?id=140916
2030
2031         Reviewed by Chris Fleizach.
2032
2033         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: Add mapping for new ATK roles
2034         * gtk/jhbuild.modules: Bump minimum version of ATK used by jhbuild to 2.15.4
2035
2036 2015-01-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2037
2038         [GTK] Stop removing color marks from unit tests output
2039         https://bugs.webkit.org/show_bug.cgi?id=140996
2040
2041         Reviewed by Philippe Normand.
2042
2043         Since r178236 google tests use a custom simplified output without
2044         any colors, so we don't need to handle the case of non ttys to
2045         remove the color marks.
2046
2047         * Scripts/run-gtk-tests:
2048         (TestRunner.__init__):
2049         (TestRunner._run_test_command.parse_line):
2050
2051 2015-01-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2052
2053         [GTK] Unit test /webkit2/WebKitWebView/page-visibility from WebKit2Gtk/TestWebKitWebView fails
2054         https://bugs.webkit.org/show_bug.cgi?id=131731
2055
2056         Reviewed by Žan Doberšek.
2057
2058         A web page loaded offscreen is in prerender state not hidden.
2059
2060         * Scripts/run-gtk-tests:
2061         (TestRunner): Unskip /webkit2/WebKitWebView/page-visibility.
2062         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2063         (testWebViewPageVisibility):
2064
2065 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
2066
2067         Partially revert r178802.
2068
2069         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png:
2070         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png:
2071
2072 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
2073
2074         build.webkit.org/dashboard asserts on some commits
2075         https://bugs.webkit.org/show_bug.cgi?id=140926
2076
2077         Reviewed by Tim Horton.
2078
2079         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2080         (Trac.prototype._convertCommitInfoElementToObject): Added a case for another root directory.
2081
2082 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
2083
2084         Make flakiness dashboard OS list actually match test_expectations.py
2085         https://bugs.webkit.org/show_bug.cgi?id=140969
2086
2087         Reviewed by Ryosuke Niwa.
2088
2089         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2090
2091 2015-01-27  Brent Fulgham  <bfulgham@apple.com>
2092
2093         [Win] WinLauncher crashes on eleventh site visited
2094         https://bugs.webkit.org/show_bug.cgi?id=140960
2095
2096         Reviewed by Anders Carlsson.
2097
2098         * WinLauncher/WinLauncher.cpp:
2099         (WinLauncher::showLastVisitedSites): Don't access off the end of
2100         the history array.
2101
2102 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
2103
2104         [Mac] Disable building Java applets by default
2105         https://bugs.webkit.org/show_bug.cgi?id=140957
2106         rdar://problem/19619529
2107
2108         Reviewed by Anders Carlsson.
2109
2110         It was actually already disabled unconditionally, by accident.
2111
2112         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args):
2113         * Scripts/webkitpy/port/mac.py:
2114         (MacPort._check_port_build):
2115         (MacPort._build_java_test_support):
2116
2117 2015-01-27  Daniel Bates  <dabates@apple.com>
2118
2119         [iOS] run-webkit-tests --platform=ios* --lint-test-files does not work
2120         https://bugs.webkit.org/show_bug.cgi?id=140949
2121
2122         Reviewed by Alexey Proskuryakov.
2123
2124         Add "ios-simulator" and "ios-simulator-wk2" to the list of ports without
2125         builders so that run-webkit-tests can lint the appropriate TestExpectation
2126         files.
2127
2128         * Scripts/webkitpy/port/builders.py:
2129         * Scripts/webkitpy/port/ios.py:
2130         (IOSSimulatorPort.__init__): Move logic to query for the Mac build directory from here...
2131         (IOSSimulatorPort.relay_path): to here as this is the only caller that makes use of that
2132         information to find the LayoutTestRelay tool. Otherwise, "self.assertEqual(len(calls), 1)"
2133         in unit test webkitpy.tool.commands.rebaseline_unittest.TestRebaselineExpectations.test_rebaseline_expectations
2134         will fail because IOSSimulatorPort.__init__() ultimately calls Tools/Scripts/webkit-build-directory
2135         to determine the Mac build directory for each instantiation of IOSSimulatorPort. And this unit
2136         test instantiates a port object for each builder listed in file Scripts/webkitpy/port/builders.py.
2137
2138
2139 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
2140
2141         Update bots on the flakiness dashboard
2142         https://bugs.webkit.org/show_bug.cgi?id=140956
2143
2144         Reviewed by Ryosuke Niwa.
2145
2146         * TestResultServer/static-dashboards/builders.jsonp:
2147         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2148
2149 2015-01-27  Daniel Bates  <dabates@apple.com>
2150
2151         [iOS WK2] Add directory LayoutTests/platform/wk2 to the list of baseline search paths
2152         https://bugs.webkit.org/show_bug.cgi?id=140942
2153
2154         Reviewed by Alexey Proskuryakov.
2155
2156         The directory LayoutTests/platform/wk2 contains test expectations and test results that
2157         are applicable to all WebKit2 ports. We should make use of this information when
2158         running layout tests using iOS WebKit2.
2159
2160         Additionally, make use of the convenience function Port._wk2_port_name() for the name
2161         of the WebKit2 port instead of directly using string concatenation.
2162
2163         * Scripts/webkitpy/port/ios.py:
2164         (IOSSimulatorPort.default_baseline_search_path):
2165
2166 2015-01-27  Csaba Osztrogonác  <ossy@webkit.org>
2167
2168         [Win] Disable FTL stress tests
2169         https://bugs.webkit.org/show_bug.cgi?id=140932
2170
2171         Reviewed by Brent Fulgham.
2172
2173         * Scripts/run-javascriptcore-tests:
2174
2175 2015-01-27  Daniel Bates  <dabates@apple.com>
2176
2177         REGRESSION (r179130): Perl warns about subroutine redefinition when running configure-xcode-for-ios-development
2178         https://bugs.webkit.org/show_bug.cgi?id=140939
2179
2180         Reviewed by Eric Carlson.
2181
2182         Fixes the Perl warning: "Subroutine wanted redefined at Tools/Scripts/configure-xcode-for-ios-development line 106."
2183
2184         * Scripts/webkitdirs.pm:
2185         (hasUserInstalledAppInSimulatorDevice): Pass a reference to an anonymous function instead
2186         of a named function to find() to avoid redefinition warnings in scripts that include webkitdirs.pm
2187         and define a function called wanted.
2188
2189 2015-01-27  Daniel Bates  <dabates@apple.com>
2190
2191         Teach run-webkit-app --simulator how to install custom built app
2192         https://bugs.webkit.org/show_bug.cgi?id=140691
2193
2194         Fix inadvertent omission of directory test flag in expression to check for the
2195         existence of the iOS simulator device-specific directory for user installed apps.
2196
2197         * Scripts/webkitdirs.pm:
2198         (hasUserInstalledAppInSimulatorDevice):
2199
2200 2015-01-26  Brent Fulgham  <bfulgham@apple.com>
2201
2202         [Win] ASSERTION FAILED !m_ptr under AccessibilityController::winAddNotificationListener
2203         https://bugs.webkit.org/show_bug.cgi?id=87426
2204         <rdar://problem/11527899>
2205
2206         Reviewed by Darin Adler.
2207
2208         Revise COMPtr to work better with our HashMap implementation. Use
2209         modern loop syntax.
2210
2211         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2212         (AccessibilityController::~AccessibilityController):
2213         (AccessibilityController::winNotificationReceived):
2214         * DumpRenderTree/win/DumpRenderTree.cpp:
2215         (dumpBackForwardListForAllWindows):
2216
2217 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
2218
2219         [Win] Enable JSC stress tests by default
2220         https://bugs.webkit.org/show_bug.cgi?id=128307
2221
2222         Reviewed by Brent Fulgham.
2223
2224         * Scripts/run-javascriptcore-tests:
2225
2226 2015-01-26  Simon Fraser  <simon.fraser@apple.com>
2227
2228         [iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim) in
2229         arguments for build and test scripts
2230         https://bugs.webkit.org/show_bug.cgi?id=139748
2231
2232         Reviewed by Daniel Bates.
2233
2234         There was much confusion resulting from the multitude of aliases used to build/test for
2235         the iOS simulator. Standardize on "--ios-simulator", which is also the name of the layout
2236         tests directory.
2237
2238         This fixes an issue where run-api-tests and some other scripts failed when run with
2239         --simulator.
2240
2241         * Scripts/build-webkit:
2242         * Scripts/package-root:
2243         (usage):
2244         * Scripts/webkitdirs.pm:
2245         (argumentsForConfiguration):
2246         (determineXcodeSDK):
2247         * Scripts/webkitpy/port/factory.py:
2248         (platform_options):
2249
2250 2015-01-26  Simon Fraser  <simon.fraser@apple.com>
2251
2252         [iOS WK2] Fix possible crash when -[WKWebView evaluateJavaScript:completionHandler:] was called then the WKWebView is destroyed
2253         https://bugs.webkit.org/show_bug.cgi?id=140203
2254         rdar://problem/19198492
2255
2256         Reviewed by Sam Weinig.
2257
2258         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2259         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm: Added.
2260         (TEST):
2261
2262 2015-01-26  David Kilzer  <ddkilzer@apple.com>
2263
2264         Add iOS EWS to build.webkit.org/dashboard
2265         <http://webkit.org/b/140627>
2266
2267         Reviewed by Alexey Proskuryakov.
2268
2269         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice.png: Add.
2270         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice@2x.png: Add.
2271         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2272         (BubbleQueueServer): Add ios-ews queue info.
2273         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2274         Add iOS8Device platform.
2275         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2276         (table.queue-grid tr.platform.ios-8 img.logo): Add CSS to draw
2277         iOS device logo.
2278
2279 2015-01-26  Filip Pizlo  <fpizlo@apple.com>
2280
2281         copy-webkitlibraries-to-product-directory's hack to build LLVM from source should be hardened for Xcode deciding it needs SDKROOT set
2282         https://bugs.webkit.org/show_bug.cgi?id=140896
2283
2284         Reviewed by Michael Saboff.
2285         
2286         I've encountered some Xcode setups where you need to set SDKROOT to get llvm to build. This
2287         makes our script do this.
2288         
2289         Note that an alternative would be to run clang via "xcrun clang" rather than directly, but
2290         this would be harder given llvm's autoconf setup.
2291
2292         * Scripts/copy-webkitlibraries-to-product-directory:
2293
2294 2015-01-26  Alexey Proskuryakov  <ap@apple.com>
2295
2296         Update bot assignments.
2297
2298         * BuildSlaveSupport/build.webkit.org-config/config.json:
2299
2300 2015-01-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2301
2302         Integrate WP python server into WebKit test framework
2303         https://bugs.webkit.org/show_bug.cgi?id=127094
2304
2305         Reviewed by Ryosuke Niwa.
2306
2307         This patch adds W3C web server (wptserver) as a new HTTP server.
2308         wptserver is used to serve all tests inside LayoutTests/imported/w3c/wpt.
2309         wptserver implementation should be imported within the import of the Web Platform Test suite (to ensure keeping server and tests in sync) in LayoutTests/imported/w3c/wpt.
2310
2311         Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py serves as main entry point to wpt spawned process.
2312         Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py is responsible to start/stop the wpt server process.
2313         It also sets up the server config and testharness.js/testharnessreport.js files at start and stop of the wpt server.
2314
2315         * Scripts/webkitpy/common/system/executive_mock.py:
2316         (MockProcess.communicate):
2317         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py: Adding start/stop of web platform test server according boolean parameter.
2318         (LayoutTestRunner.__init__):
2319         (LayoutTestRunner.run_tests):
2320         (LayoutTestRunner.start_servers):
2321         (LayoutTestRunner.stop_servers):
2322         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py: Updated to check for wpt server start/stop.
2323         (LayoutTestRunnerTests._run_tests):
2324         (LayoutTestRunnerTests.test_servers_started.start_web_platform_test_server):
2325         (LayoutTestRunnerTests.test_servers_started.stop_web_platform_test_server):
2326         (LayoutTestRunnerTests):
2327         (LayoutTestRunnerTests.test_servers_started):
2328         * Scripts/webkitpy/layout_tests/controllers/manager.py:  Updated to check whether a test is a wpt test and whether wpt server launch is needed.
2329         (Manager.__init__):
2330         (Manager._is_http_test):
2331         (Manager._is_web_platform_test):
2332         (Manager._run_tests):
2333         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2334         (ManagerTest.test_needs_servers.get_wpt_doc_root):
2335         (ManagerTest.test_needs_servers.get_manager):
2336         (ManagerTest.test_needs_servers):
2337         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Added an option to control the doc_root of the wpt server.
2338         (parse_args):
2339         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py: Added.
2340         (main):
2341         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py: Added.
2342         (doc_root):
2343         (base_url):
2344         (WebPlatformTestServer):
2345         (WebPlatformTestServer.__init__):
2346         (WebPlatformTestServer._set_start_cmd):
2347         (WebPlatformTestServer._copy_webkit_test_files):
2348         (WebPlatformTestServer._clean_webkit_test_files):
2349         (WebPlatformTestServer._prepare_config):
2350         (WebPlatformTestServer._spawn_process):
2351         (WebPlatformTestServer._stop_running_server):
2352         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py: Added.
2353         (TestWebPlatformTestServer):
2354         (TestWebPlatformTestServer.test_start_cmd):
2355         * Scripts/webkitpy/port/base.py:
2356         (Port.__init__):
2357         (Port.to.start_web_platform_test_server):
2358         (Port.to):
2359         (Port.to.web_platform_test_server_doc_root):
2360         (Port.to.web_platform_test_server_base_url):
2361         (Port.to.stop_web_platform_test_server):
2362         * Scripts/webkitpy/port/driver.py: Updated the test name <-> test URL conversion routines.
2363         (Driver.__init__):
2364         (Driver.is_web_platform_test):
2365         (Driver.test_to_uri):
2366         (Driver.uri_to_test):
2367         (Driver._command_from_driver_input):
2368         * Scripts/webkitpy/port/driver_unittest.py:  Updated tests according new conversion rules.
2369         (DriverTest.test_test_to_uri):
2370         (DriverTest.test_uri_to_test):
2371
2372 2015-01-26  Daniel Bates  <dabates@apple.com>
2373
2374         Teach run-webkit-app --simulator how to install custom built app
2375         https://bugs.webkit.org/show_bug.cgi?id=140691
2376
2377         Reviewed by David Kilzer.
2378
2379         We should teach run-webkit-app --simulator how to install a custom built app.
2380
2381         Currently run-webkit-app --simulator can only run a system app or an app that
2382         was installed using the simctl command line tool. For convenience we should
2383         teach run-webkit-app --simulator how to install a custom built app.
2384
2385         As a side effect of this change run-safari --simulator will install and run
2386         a custom built of MobileSafari (if it exists).
2387
2388         * Scripts/webkitdirs.pm:
2389         (iOSSimulatorDevices): Added FIXME comment to decouple device representation in
2390         Perl from the structure of the device.plist file.
2391         (plistPathFromBundle): Fix if-statement condition so that we actually perform a
2392         file system check to determine the plist path for a Mac app bundle.
2393         (appIdentifierFromBundle): Pass absolute files system path to defaults(1). Otherwise,
2394         it will complain that it cannot find the file: "Domain ... does not exist".
2395         (appDisplayNameFromBundle): Ditto.
2396         (waitUntilIOSSimulatorDeviceIsInState): Added; helper function that does not return
2397         until a simulator device is the specified state.
2398         (relaunchIOSSimulator): Renamed; formerly named openIOSSimulator. Quits iOS Simulator
2399         (if it's open) before opening it again so as to ensure that the iOS Simulator boots
2400         the specified device.
2401         (quitIOSSimulator): Added optional parameter, $waitForShutdownOfSimulatedDeviceUDID.
2402         As implied by its name, this function will not return until the specified simulator
2403         device UDID is in the shutdown state.
2404         (iosSimulatorDeviceByUDID): Added; returns the device dictionary object for the simulator
2405         device with the specified UDID.
2406         (isIOSSimulatorSystemInstalledApp): Resolve symbolic links in iosSimulatorApplicationsPath()
2407         before using it as part of a prefix match to avoid a mismatch. In the public iOS 8.1 SDK the
2408         return value of iosSimulatorApplicationsPath(), which returns a result analogous to the shell
2409         expression echo `xcrun --sdk iphonesimulator --show-sdk-path`/Applications/, contains a
2410         symbolic link. Specifically, echo `xcrun --sdk iphonesimulator --show-sdk-path` returns
2411         /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator8.1.sdk,
2412         which is a symbolic link to /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator.sdk.
2413         (hasUserInstalledAppInSimulatorDevice): Added.
2414         (isSimulatorDeviceBooted): Added; returns whether the specified simulator device is in the
2415         "Booted" state.
2416         (runIOSWebKitAppInSimulator): Modified to install a custom built app (if needed). For now,
2417         switching between a system installed app and a custom built version of the same app (e.g.
2418         custom build of MobileSafari) will erase all contents and settings in the simulator device.
2419         (eraseIOSSimulatorDevice): Deleted; inline implementation into runIOSWebKitAppInSimulator()
2420         as that was the only caller of this function.
2421         (bootedIOSSimulatorDevice): Deleted.
2422         (openIOSSimulator): Deleted.
2423
2424 2015-01-26  Alexey Proskuryakov  <ap@apple.com>
2425
2426         Update bot assignments.
2427
2428         * BuildSlaveSupport/build.webkit.org-config/config.json:
2429
2430 2015-01-26  Alexey Proskuryakov  <ap@apple.com>
2431
2432         Leaks bot shouldn't run JSC tests
2433         https://bugs.webkit.org/show_bug.cgi?id=140877
2434
2435         Reviewed by Darin Adler.
2436
2437         Shaves off 48 minutes of time.
2438
2439         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2440         (TestLeaksFactory): Slim down the leaks queue.
2441
2442         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2443         * Scripts/webkitpy/port/ios.py:
2444         (IOSSimulatorPort.print_leaks_summary):
2445         * Scripts/webkitpy/port/mac.py:
2446         (MacPort.print_leaks_summary):
2447         Don't yell when leaks are detected.
2448
2449 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
2450
2451         Refactor run-javascriptcore-tests
2452         https://bugs.webkit.org/show_bug.cgi?id=140824
2453
2454         Reviewed by Darin Adler.
2455
2456         Separated mozilla, stress test code paths and
2457         determining skipped mozilla tests into subroutines.
2458
2459         * Scripts/run-javascriptcore-tests:
2460         (runMozillaTests):
2461         (runJSCStressTests):
2462         (defaultJsDriverArgsForMozillaTests):
2463
2464 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
2465
2466         [buildbot] Fix grammar of TestWithFailureCount
2467         https://bugs.webkit.org/show_bug.cgi?id=140884
2468
2469         Reviewed by Alexey Proskuryakov.
2470
2471         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2472         (TestWithFailureCount):
2473         (TestWithFailureCount.commandComplete):
2474         (TestWithFailureCount.getText2):
2475         (RunUnitTests):
2476         (RunPythonTests):
2477         (RunPerlTests):
2478         (RunLLINTCLoopTests):
2479         (Run32bitJSCTests):
2480         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2481         (RunLLINTCLoopTestsTest.test_failure):
2482         (Run32bitJSCTestsTest.test_failure):
2483         (RunUnitTestsTest.assertFailures):
2484
2485 2015-01-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2486
2487         Unreviewed. Moving myself to the committer section.
2488
2489         * Scripts/webkitpy/common/config/contributors.json:
2490
2491 2015-01-26  Michael Catanzaro  <mcatanzaro@igalia.com> and Carlos Garcia Campos  <cgarcia@igalia.com>
2492
2493         [GTK] gtkdoc does not appear in DevHelp
2494         https://bugs.webkit.org/show_bug.cgi?id=139369
2495
2496         Reviewed by Philippe Normand.
2497
2498         * gtk/generate-gtkdoc: Create the generators in the main function
2499         and use them to get the local cross renference dependencies. Also
2500         pass the generator module name to webkitdom.write_doc_files().
2501         (get_gtkdoc_module_paths): Receive a list of local cross reference
2502         dependencies.
2503         (get_generator_for_config): Set the main_sgml_file property of the
2504         GtkDoc object from the configuration file.
2505         (generate_documentation): Generate the documentation for the given
2506         generator.
2507         (generate_documentation_for_config): Deleted.
2508         * gtk/manifest.txt.in: Expect the API version in the gtkdoc filenames.
2509         * gtk/webkitdom.py:
2510         (write_doc_files): Receive the module name used to build the
2511         -sections.txt filename.
2512
2513 2015-01-26  Commit Queue  <commit-queue@webkit.org>
2514
2515         Unreviewed, rolling out r179107.
2516         https://bugs.webkit.org/show_bug.cgi?id=140880
2517
2518         The GCC in the bots doesn't support the AsyncTask
2519         implementation (Requested by KaL on #webkit).
2520
2521         Reverted changeset:
2522
2523         "[GTK] Enable IndexedDB"
2524         https://bugs.webkit.org/show_bug.cgi?id=98932
2525         http://trac.webkit.org/changeset/179107
2526
2527 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
2528
2529         [EFL] Bump libseccomp version to 2.1.1
2530         https://bugs.webkit.org/show_bug.cgi?id=140357
2531
2532         Reviewed by Gyuyoung Kim.
2533
2534         * efl/jhbuild.modules:
2535
2536 2015-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2537
2538         [GTK] Enable IndexedDB
2539         https://bugs.webkit.org/show_bug.cgi?id=98932
2540
2541         Reviewed by Žan Doberšek.
2542
2543         * Scripts/webkitperl/FeatureList.pm: Enable IndexedDB for the GTK port.
2544
2545 2015-01-25  Alexey Proskuryakov  <ap@apple.com>
2546
2547         Would like leaks bot results at build.webkit.org/dashboard
2548         https://bugs.webkit.org/show_bug.cgi?id=122657
2549
2550         Reviewed by Darin Adler.
2551
2552         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2553         Record links provided by buildbot steps. Currently, the dashboard hardcodes more links
2554         than necessary, could use the ones from buildbot in more places.
2555
2556         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2557         (BuildbotQueue): Reflect configuration option for leaks queues.
2558
2559         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2560         Add leaks queues to performance column. First, leaks are about performance indeed,
2561         and second, this is where we have some space to spare.
2562
2563         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2564         (WebKitBuildbot): Added Yosemite Leaks queue, which was sitting neglected for at
2565         least a year.
2566
2567         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2568         (table.queue-grid td): Moved height from queue-view - we can now have more than one
2569         queue view per cell. The heigt is needed to avoid ugly overlapping while loading
2570         results - once the results are loaded, all rows are currently higher than that.
2571
2572         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
2573         (.leaks-popover): Added.
2574
2575         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
2576         Added.
2577
2578         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
2579         Load BuildbotLeaksQueueView.js.
2580
2581 2015-01-25  peavo@outlook.com  <peavo@outlook.com>
2582
2583         [Win] Add WebKit message loop interface.
2584         https://bugs.webkit.org/show_bug.cgi?id=140857
2585
2586         Reviewed by Brent Fulgham.
2587
2588         Added message loop interface which will run the message loop,
2589         and perform required tasks (like calling CFRunLoopRunInMode)
2590         on each iteration of the loop.
2591
2592         * WinLauncher/WinMain.cpp:
2593         (wWinMain): Use new message loop interface.
2594
2595 2015-01-24  Dan Bernstein  <mitz@apple.com>
2596
2597         update-webkit’s --internal option is unused
2598         https://bugs.webkit.org/show_bug.cgi?id=140861
2599
2600         Reviewed by Anders Carlsson.
2601
2602         * Scripts/update-webkit: Removed the option.
2603
2604 2015-01-24  Brent Fulgham  <bfulgham@apple.com>
2605
2606         DumpRenderTree needs to run with Windows native controls on Windows
2607         https://bugs.webkit.org/show_bug.cgi?id=25592
2608
2609         Reviewed by Anders Carlsson.
2610
2611         * DumpRenderTree/win/DumpRenderTree.cpp:
2612         (resetWebPreferencesToConsistentValues): Tell DRT to use native controls.
2613         (prepareConsistentTestingEnvironment): Ditto.
2614
2615 2015-01-23  David Kilzer  <ddkilzer@apple.com>
2616
2617         test-webkitpy: webkitpy.tool.commands.earlywarningsystem_unittest.EarlyWarningSystemTest.test_ewses fails on EFL, GTK, Win ports
2618         <http://webkit.org/b/140787>
2619
2620         Reviewed by Daniel Bates.
2621
2622         * Scripts/webkitpy/port/ios.py:
2623         (IOSPort.determine_full_port_name): Instead of checking the type
2624         of the current host, test if /usr/bin/xcrun exists before trying
2625         to use it.
2626
2627 2015-01-23  Csaba Osztrogonác  <ossy@webkit.org>
2628
2629         Fix the false positive build failures on the Windows buildbots
2630         https://bugs.webkit.org/show_bug.cgi?id=140819
2631
2632         Reviewed by Brent Fulgham.
2633
2634         Increase the build timeout (without producing output) to 2 hours for Windows bots,
2635         the default 20 minutes is enough for others since they produce output during the build.
2636
2637         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2638         (BuildFactory.__init__):
2639
2640 2015-01-23  Brent Fulgham  <bfulgham@apple.com>
2641
2642         [Win] Teach WebKit to provide IAccessible2 'get_language' and access AXLanguage
2643         https://bugs.webkit.org/show_bug.cgi?id=140839
2644
2645         Reviewed by Dean Jackson.
2646
2647         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2648         (AccessibilityUIElement::language): Retrieve the 'language' BSTR
2649         from the IA2Locale structure and pass it to DRT.
2650
2651 2015-01-23  Brent Fulgham  <bfulgham@apple.com>
2652
2653         [Win] Update DRT Accessibility implementation to better match Mac.
2654         https://bugs.webkit.org/show_bug.cgi?id=140830
2655
2656         Reviewed by Dean Jackson.
2657
2658         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2659         (AccessibilityUIElement::titleUIElement):
2660         (AccessibilityUIElement::parentElement):
2661         (convertToDRTLabel):
2662         (AccessibilityUIElement::role):
2663         (AccessibilityUIElement::title):
2664         (AccessibilityUIElement::description):
2665         (AccessibilityUIElement::stringValue):
2666         (AccessibilityUIElement::helpText):
2667         (AccessibilityUIElement::isFocused):
2668
2669 2015-01-23  Sergio Villar Senin  <svillar@igalia.com>
2670
2671         REGRESSION: run-perf-tests --profiler= seems to have broken
2672         https://bugs.webkit.org/show_bug.cgi?id=113528
2673
2674         Reviewed by Daniel Bates.
2675
2676         The problem is that "perf --record" (or the equivalent call for
2677         other profilers) is never called whenever there is a wrapper
2678         option in the port. We should inject the profiler call first
2679         (should it exists) and then use the port wrapper.
2680
2681         * Scripts/webkitpy/port/driver.py:
2682         (Driver._command_wrapper):
2683         * Scripts/webkitpy/port/driver_unittest.py:
2684         (DriverTest.test_profiler_and_wrapper): New unit test.
2685
2686 2015-01-22  David Kilzer  <ddkilzer@apple.com>
2687
2688         configure-xcode-for-ios-development needs to import webkitdirs.pm
2689         <http://webkit.org/b/140704>
2690
2691         Fixes the following runtime error:
2692
2693             Undefined subroutine &main::exitStatus called at ./Tools/Scripts/configure-xcode-for-ios-development line 167.
2694
2695         * Scripts/configure-xcode-for-ios-development: Add back code to
2696         import webkitdirs.pm for the exitStatus() method.  Not sure why
2697         I removed it before patch review.
2698
2699 2015-01-22  Timothy Horton  <timothy_horton@apple.com>
2700
2701         REGRESSION (r178847): Yosemite 32-bit bot isn't doing any work
2702         https://bugs.webkit.org/show_bug.cgi?id=140795
2703
2704         Reviewed by Jon Honeycutt.
2705
2706         * BuildSlaveSupport/build.webkit.org-config/config.json:
2707         r178847 accidentally remove the scheduler for this bot. Re-add it to the
2708         Yosemite scheduler.
2709
2710 2015-01-22  Brent Fulgham  <bfulgham@apple.com>
2711
2712         [Win] Expose missing editing features through WebView interface
2713         https://bugs.webkit.org/show_bug.cgi?id=140773
2714         <rdar://problem/19565421>
2715
2716         Reviewed by Dean Jackson.
2717
2718         Connect the various WebView editing delegate methods to our
2719         test infrastructure. Also prefer _bstr_t to raw BSTR types
2720         to simplify life cycle management.
2721
2722         * DumpRenderTree/win/DumpRenderTree.cpp:
2723         (resetWebViewToConsistentStateBeforeTesting):
2724         * DumpRenderTree/win/EditingDelegate.cpp:
2725         (EditingDelegate::QueryInterface):
2726         (dumpPath):
2727         (dump):
2728         (EditingDelegate::shouldBeginEditingInDOMRange):
2729         (EditingDelegate::shouldEndEditingInDOMRange):
2730         (EditingDelegate::shouldInsertNode):
2731         (EditingDelegate::shouldInsertText):
2732         (EditingDelegate::shouldDeleteDOMRange):
2733         (EditingDelegate::shouldChangeSelectedDOMRange):
2734         (EditingDelegate::shouldApplyStyle):
2735         (EditingDelegate::shouldChangeTypingStyle):
2736         (EditingDelegate::doPlatformCommand):
2737         (EditingDelegate::webViewDidBeginEditing):
2738         (EditingDelegate::webViewDidChange):
2739         (EditingDelegate::webViewDidEndEditing):
2740         (EditingDelegate::webViewDidChangeTypingStyle):
2741         (EditingDelegate::webViewDidChangeSelection):
2742         (EditingDelegate::checkSpellingOfString):
2743         (EditingDelegate::onNotify):
2744         * DumpRenderTree/win/EditingDelegate.h:
2745
2746 2015-01-22  Ryosuke Niwa  <rniwa@webkit.org>
2747
2748         Add a build flag for ES6 class syntax
2749         https://bugs.webkit.org/show_bug.cgi?id=140760
2750
2751         Reviewed by Michael Saboff.
2752
2753         * Scripts/webkitperl/FeatureList.pm:
2754
2755 2015-01-22  Daniel Bates  <dabates@apple.com>
2756
2757         [iOS] run-webkit-tests --ios-sim dies with an error; fails to parse Apple Internal
2758         runtime in simctl output
2759         https://bugs.webkit.org/show_bug.cgi?id=140751
2760
2761         Reviewed by David Kilzer.
2762
2763         Following the fix for <rdar://problem/19444383>, run-webkit-tests --ios-sim dies
2764         with an error because it does not know how to parse the output of the simctl tool
2765         to identify an Apple Internal runtime.
2766
2767         * Scripts/webkitpy/xcode/simulator.py:
2768         (Runtime.__init__): Add parameter is_internal_runtime (defaults to False).
2769         (Runtime.__eq__): Take is_internal_runtime when comparing two Runtime objects for equality.
2770         (Runtime.__repr__): Update printable representation of Runtime object to indicate whether
2771         the runtime is an internal runtime.
2772         (Simulator): Update regular expressions runtime_re and version_re to match an internal runtime.
2773         (Simulator._parse_runtimes): Pass is_internal_runtime to the Runtime constructor with the
2774         appropriate value.
2775         (Simulator._parse_devices): Pass argument is_internal_runtime to Simulator.runtime() so that
2776         it updates the appropriate Runtime object.
2777         (Simulator.runtime): Added optional parameter, is_internal_runtime. Modified to support
2778         looking up a Runtime object for an internal runtime.
2779
2780 2015-01-22  Alexey Proskuryakov  <ap@apple.com>
2781
2782         LeaksViewer doesn't show recent builds if there are less than 10
2783         https://bugs.webkit.org/show_bug.cgi?id=140716
2784
2785         Reviewed by Tim Horton.
2786
2787         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
2788
2789 2015-01-22  Lucas Forschler  <lforschler@apple.com>
2790
2791         Add Apple build slaves.
2792         Fixed text alignment for slave list.
2793         
2794         Unreviewed.
2795         
2796         * BuildSlaveSupport/build.webkit.org-config/config.json:
2797
2798 2015-01-21  Lucas Forschler  <lforschler@apple.com>
2799
2800         Teach build.webkit.org about bot308 and bot309.
2801         
2802         Unreviewed.
2803         
2804         * BuildSlaveSupport/build.webkit.org-config/config.json:
2805
2806 2015-01-21  Lucas Forschler  <lforschler@apple.com>
2807
2808         Add two Apple Mavericks slaves.
2809         
2810         Unreviewed.
2811         
2812         * BuildSlaveSupport/build.webkit.org-config/config.json:
2813
2814 2015-01-21  Daniel Bates  <dabates@apple.com>
2815
2816         Add iOS WebKit1 TestExpectation file
2817         https://bugs.webkit.org/show_bug.cgi?id=140739
2818
2819         Reviewed by David Kilzer.
2820
2821         Teach run-webkit-tests to look for iOS WebKit1-specific test results and
2822         expectations in directory LayoutTests/platform/ios-simulator-wk1.
2823
2824         * Scripts/webkitpy/port/ios.py:
2825         (IOSSimulatorPort.default_baseline_search_path):
2826
2827 2015-01-21  David Kilzer  <ddkilzer@apple.com>
2828
2829         [iOS] Update configure-xcode-for-ios-development to copy missing headers to iphoneos SDK
2830         <http://webkit.org/b/140704>
2831
2832         Reviewed by Daniel Bates.
2833
2834         * Scripts/configure-xcode-for-ios-development:
2835         - Update copyright.
2836         - Remove FIXME addressed by r178709.
2837         - Call copyMissingHeadersToIPhoneOSSDKIfNeeded().
2838         (copyMissingHeadersToIPhoneOSSDKIfNeeded): Add method to copy
2839         missing headers from iphonesimulator SDK to iphoneos SDK.
2840         (sdkDirectory): Add method that returns SDK directory.
2841         (sdkPlatformDirectory): Extract method from
2842         xcodeSDKSpecificationsPath() that returns SDK platform
2843         directory.
2844         (xcodeSDKSpecificationsPath): Update to use
2845         sdkPlatformDirectory().
2846
2847 2015-01-21  Alexey Proskuryakov  <ap@apple.com>
2848
2849         https://build.webkit.org/dashboard/metrics.html fails because of ios-ews
2850         https://bugs.webkit.org/show_bug.cgi?id=140731
2851
2852         Reviewed by Tim Horton.
2853
2854         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2855         (Analyzer.prototype._analyzeAllBubblesPerformance): Corrected a typo.
2856
2857 2015-01-21  Brent Fulgham  <bfulgham@apple.com>
2858
2859         [Win] eventSender does not support scalePageBy
2860         https://bugs.webkit.org/show_bug.cgi?id=140726
2861         <rdar://problem/19549865>
2862
2863         Reviewed by Dean Jackson.
2864
2865         * DumpRenderTree/win/EventSender.cpp:
2866         (scalePageByCallback): Provide implementation using new WebView method.
2867
2868 2015-01-21  Lucas Forschler  <lforschler@apple.com>
2869
2870         Remove Apple Mountain Lion Build & Test slaves.
2871         
2872         Unreviewed.
2873
2874         * BuildSlaveSupport/build.webkit.org-config/config.json:
2875
2876 2015-01-21  Csaba Osztrogonác  <ossy@webkit.org>
2877
2878         Remove ENABLE(INSPECTOR) ifdef guards
2879         https://bugs.webkit.org/show_bug.cgi?id=140668
2880
2881         Reviewed by Darin Adler.
2882
2883         * DumpRenderTree/mac/TestRunnerMac.mm:
2884         (TestRunner::showWebInspector):
2885         (TestRunner::closeWebInspector):
2886         (TestRunner::evaluateInWebInspector):
2887         * Scripts/webkitperl/FeatureList.pm:
2888         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2889         (WTR::TestRunner::showWebInspector):
2890         (WTR::TestRunner::closeWebInspector):
2891         (WTR::TestRunner::evaluateInWebInspector):
2892         * WebKitTestRunner/TestInvocation.cpp:
2893         (WTR::TestInvocation::invoke):
2894
2895 2015-01-20  Alexey Proskuryakov  <ap@apple.com>
2896
2897         Update build.webkit.org/dashboard to match current Mac queues.
2898
2899         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion.png: Removed.
2900         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion@2x.png: Removed.
2901         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png: Removed.
2902         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png: Removed.
2903         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2904         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2905         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2906         (table.queue-grid tr.platform.mac-os-x-mountain-lion img.logo): Deleted.
2907         (table.queue-grid tr.platform.mac-os-x-lion img.logo): Deleted.
2908
2909 2015-01-20  Lucas Forschler  <lforschler@apple.com>
2910
2911         Update Apple MountainLion Leaks slave to Yosemite
2912         Update Apple MountainLion Release (32-bit) Build slave to Yosemite
2913         
2914         Unreviewed.
2915
2916         * BuildSlaveSupport/build.webkit.org-config/config.json:
2917
2918 2015-01-20  Lucas Forschler  <lforschler@apple.com>
2919
2920         Update LeaksViewer from MountainLion to Yosemite
2921         
2922         Reviewed by Alexey Proskuryakov.
2923
2924         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2925         (LeaksViewer._displayURLPrompt):
2926
2927 2015-01-20  Jake Nielsen  <jacob_nielsen@apple.com>
2928
2929         Fix EWS python unit tests and address code comments as per 140476
2930         https://bugs.webkit.org/show_bug.cgi?id=140637
2931
2932         Reviewed by David Kilzer.
2933
2934         * Scripts/webkitpy/port/base.py:
2935         (Port):
2936         (Port.__init__):
2937         Adds DEFAULT_ARCHITECTURE member.
2938         (Port.architecture):
2939         Removes architecture member and instead uses
2940         self.get_option('architecture'). Also removes redundant architecture
2941         method.
2942         (Port.set_architecture):
2943         Adds a setter for the architecture variable to be able to set a flag
2944         upon modification.
2945         (Port.test_configuration):
2946         Uses self.architecture() instead of self._architecture.
2947         * Scripts/webkitpy/port/ios.py:
2948         Overrides DEFAULT_ARCHITECTURE.
2949         (IOSPort):
2950         (IOSPort.determine_full_port_name):
2951         Uses subprocess.check_output instead of Popen. Uses rstrip instead of
2952         strip. Fixes regex to not match arbitrary characters after the
2953         relevent digits are matched.
2954         (IOSPort.__init__):
2955         Removes old _architecture defaulting strategy.
2956         (IOSPort._build_driver_flags):
2957         Uses self.architecture() instead of self._architecture.
2958         (IOSSimulatorPort):
2959         Overrides DEFAULT_ARCHITECTURE.
2960         (IOSSimulatorPort.__init__):
2961         Removes old _architecture defaulting strategy.
2962         * Scripts/webkitpy/port/mac.py:
2963         (MacPort):
2964         Overrides DEFAULT_ARCHITECTURE.
2965         (MacPort.__init__):
2966         Removes old _architecture defaulting strategy.
2967         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2968         (AbstractEarlyWarningSystem.run_command):
2969         Checks the did_override_architecture flag to determine whether to add
2970         the --architecture option.
2971         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2972         Uses ews.architecture rather than trying to discern the correct
2973         architecture using a port object.
2974         (EarlyWarningSystemTest._default_expected_logs):
2975         * Scripts/webkitpy/tool/commands/queues.py:
2976         Removes use of optparse, and removes the import statement.
2977         (AbstractQueue.__init__):
2978         (PatchProcessingQueue.begin_work_queue):
2979
2980 2015-01-20  Sam Weinig  <sam@webkit.org>
2981
2982         Attempt to fix Mountain Lion and EFL tests.
2983
2984         * WebKitTestRunner/TestController.cpp:
2985         (WTR::TestController::initialize):
2986         Disable Process-per-tab and network process on Mountain Lion and EFL.
2987
2988 2015-01-20  Darin Adler  <darin@apple.com>
2989
2990         Remove SVGElementInstanceList, m_instanceUnderMouse, DUMP_INSTANCE_TREE, DUMP_SHADOW_TREE
2991         https://bugs.webkit.org/show_bug.cgi?id=140679
2992
2993         Reviewed by Anders Carlsson.
2994
2995         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
2996         Removed a reference to SVGElementInstanceList.
2997
2998 2015-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2999
3000         [GTK] WebViewTest should prohibit overriding initializeWebExtensions()
3001         https://bugs.webkit.org/show_bug.cgi?id=140028
3002
3003         Reviewed by Carlos Garcia Campos.
3004
3005         This won't work as expected, since this function is called before the
3006         WebViewTest constructor completes.
3007
3008         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
3009
3010 2015-01-20  David Kilzer  <ddkilzer@apple.com>
3011
3012         configure-xcode-for-ios-development needs to update iPhoneOS SDK
3013         <http://webkit.org/b/140661>
3014
3015         Reviewed by Daniel Bates.
3016
3017         * Scripts/configure-xcode-for-ios-development: Add for() loop to
3018         run createXcodeSpecificationFilesForSDKIfNeeded() for both
3019         "iphoneos" and "iphonesimulator" SDKs.
3020         (createXcodeSpecificationFilesForSDKIfNeeded): Extracted from
3021         the main body of the script.
3022
3023 2015-01-20  Tomas Popela  <tpopela@redhat.com>
3024
3025         [GTK] Add API to set the web view editable into WebKit2 GTK+ API
3026         https://bugs.webkit.org/show_bug.cgi?id=139443
3027
3028         Reviewed by Carlos Garcia Campos.
3029
3030         Create the new test cases for setting the editable property on the web
3031         view and on the contenteditable enabled document. Also rework the
3032         current tests that are expecting that the web view is editable.
3033
3034         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
3035         (loadTestHtml):
3036         (testWebViewEditorCutCopyPasteNonEditable):
3037         (testWebViewEditorCutCopyPasteEditable):
3038         (testWebViewEditorSelectAllNonEditable):
3039         (testWebViewEditorSelectAllEditable):
3040         (runEditorEditableCutTests):
3041         (testWebViewEditorEditableOnNonEditable):
3042         (testWebViewEditorEditableOnContentEditable):
3043         (testWebViewEditorNonEditable):
3044         (beforeAll):
3045         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
3046         (WebViewTest::isEditable):
3047         (WebViewTest::setEditable):
3048
3049 2015-01-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3050
3051         [GTK] Add an option to create WebKitWebView snapshots with transparent background
3052         https://bugs.webkit.org/show_bug.cgi?id=140617
3053
3054         Reviewed by Gustavo Noronha Silva.
3055
3056         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3057         (testWebViewSnapshot): Check that the same snapshot with
3058         transparent background is different than the default one filled
3059         with white.
3060
3061 2015-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3062
3063         [GTK] Add API to change the WebKitWebView background color
3064         https://bugs.webkit.org/show_bug.cgi?id=140610
3065
3066         Reviewed by Gustavo Noronha Silva.
3067
3068         Add --bg-color command line option to MiniBrowser to be able to
3069         manually test the API passing any RGBA color to MiniBrowser.
3070         Also add a simple unit test to check that getting and setting
3071         colors from the API point of view.
3072
3073         * MiniBrowser/gtk/BrowserWindow.c:
3074         (browser_window_set_background_color):
3075         * MiniBrowser/gtk/BrowserWindow.h:
3076         * MiniBrowser/gtk/main.c:
3077         (createBrowserWindow):
3078         (parseBackgroundColor):
3079         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3080         (testWebViewBackgroundColor):
3081         (beforeAll):
3082
3083 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
3084
3085         [Win] Layout Test fast/xmlhttprequest/xmlhttprequest-no-file-access.html is failing
3086         https://bugs.webkit.org/show_bug.cgi?id=140665
3087
3088         Reviewed by Brian Burg.
3089
3090         * DumpRenderTree/win/UIDelegate.cpp:
3091         (UIDelegate::webViewAddMessageToConsole): Correct string search and concatenation to
3092         match expected test output.
3093
3094 2015-01-19  Benjamin Poulain  <bpoulain@apple.com>
3095
3096         Remove the support for custom suffixes on ChangeLog
3097         https://bugs.webkit.org/show_bug.cgi?id=140648
3098
3099         Reviewed by David Kilzer.
3100
3101         Custom suffixes were used for the iOS branch of WebKit.
3102         Now that everything is opensource, there is no need for it.
3103
3104         * Scripts/VCSUtils.pm:
3105         (changeLogSuffix): Deleted.
3106         (changeLogFileName): Deleted.
3107         * Scripts/commit-log-editor:
3108         * Scripts/prepare-ChangeLog:
3109         (getLatestChangeLogs):
3110         (generateNewChangeLogs):
3111         (generateFileList):
3112         * Scripts/resolve-ChangeLogs:
3113         (findChangeLog):
3114
3115 2015-01-19  Timothy Horton  <timothy_horton@apple.com>
3116
3117         Adjust naming of action menu SPI
3118         https://bugs.webkit.org/show_bug.cgi?id=140644
3119         <rdar://problem/19448129>
3120
3121         Reviewed by Brian Weinstein.
3122
3123         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
3124         (-[ActionMenusTestWKView runMenuSequenceAtPoint:preDidCloseMenuHandler:]):
3125         (TestWebKitAPI::TEST):
3126
3127 2015-01-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3128
3129         [GTK] Generate the make dist manifest from a CMake template file
3130         https://bugs.webkit.org/show_bug.cgi?id=139387
3131
3132         Reviewed by Martin Robinson.
3133
3134         Remove the code that performs variable substitution on manifest.txt.
3135         Replace the custom variables used in that file with CMake variables.
3136
3137         * gtk/make-dist.py:
3138         (Manifest.add_directory):
3139         (Manifest.get_full_source_path):
3140         (Manifest.process_line):
3141         (Manifest.resolve_variables): Deleted.
3142         (Manifest.get_full_tarball_path): Deleted.
3143         * gtk/manifest.txt.in: Renamed from Tools/gtk/manifest.txt.
3144
3145 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
3146
3147         [Win] Correct merge error in last commit.
3148
3149         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3150         (findAccessibleObjectById): Undo accidental paste made during landing.
3151
3152 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
3153
3154         [Win] Periodic failure in DumpRenderTree related to WebActionPropertyBag::Read
3155         https://bugs.webkit.org/show_bug.cgi?id=139906
3156
3157         Reviewed by Dean Jackson.
3158
3159         WebKit on Windows was creating uninitialized VARIANT structures, then attempting
3160         to use them. This patch fixes that.
3161
3162         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3163         (findAccessibleObjectById):
3164         (AccessibilityController::focusedElement):
3165         (logEventProc):
3166         (notificationListenerProc):
3167         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3168         (AccessibilityUIElement::getChildAtIndex):
3169         (AccessibilityUIElement::titleUIElement):
3170         (self):
3171         (AccessibilityUIElement::role):
3172         (AccessibilityUIElement::valueDescription):
3173         (accessibilityState):
3174         (AccessibilityUIElement::isChecked):
3175         * DumpRenderTree/win/DumpRenderTree.cpp:
3176         (dumpFrameScrollPosition):
3177         (dumpFramesAsText):
3178         * DumpRenderTree/win/PolicyDelegate.cpp:
3179         (PolicyDelegate::decidePolicyForNavigationAction):
3180         * DumpRenderTree/win/UIDelegate.cpp:
3181         (UIDelegate::exceededDatabaseQuota):
3182         * WinLauncher/Common.cpp:
3183         (setWindowText):
3184
3185 2015-01-19  Dean Jackson  <dino@apple.com>
3186
3187         Add "override" to fix the build with newer clangs.
3188
3189         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
3190         (TestWebKitAPI::CalculationDeletionTestNode::operator==):
3191
3192 2015-01-19  David Kilzer  <ddkilzer@apple.com>
3193
3194         [iOS] Do not hard-code iphoneos.internal SDK in buildXCodeProject()
3195         <http://webkit.org/b/140623>
3196
3197         Reviewed by Daniel Bates.
3198
3199         * Scripts/build-webkit: Update help for --device switch.
3200         * Scripts/webkitdirs.pm:
3201         (determineXcodeSDK): When passing --device, prefer the internal
3202         iOS SDK if it exists, else fall back to the external iOS SDK.
3203         (buildXCodeProject): Use xcodeSDK() as -sdk argument for
3204         xcodebuild instead of trying to sanitize values.
3205
3206 2015-01-19  Alexey Proskuryakov  <ap@apple.com>
3207
3208         "Unknown option: sharedworkerglobalscopeconstructorsfile" when running bindings tests.
3209         https://bugs.webkit.org/show_bug.cgi?id=140606
3210
3211         Reviewed by Csaba Osztrogonác.
3212
3213         * Scripts/webkitpy/bindings/main.py:
3214         (BindingsTests.generate_supplemental_dependency):
3215         (BindingsTests.main):
3216
3217 2015-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3218
3219         [GTK] [WK2] TestWebKitWebView snapshot fails
3220         https://bugs.webkit.org/show_bug.cgi?id=120404
3221
3222         Reviewed by Žan Doberšek.
3223
3224         Rework the test to make sure the snapshot is always created at the
3225         desired size.
3226
3227         * Scripts/run-gtk-tests:
3228         (TestRunner): Unskip /webkit2/WebKitWebView/snapshot.
3229         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3230         (testWebViewSnapshot): Use a fixed size for the document, and
3231         disable scrollbars to make sure the visible area is always the
3232         WebView size.
3233         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
3234         (WebViewTest::showInWindowAndWaitUntilMapped): Add optional width
3235         and height parameters to create the window with a given size.
3236         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
3237
3238 2015-01-18  David Kilzer  <ddkilzer@apple.com>
3239
3240         iOS EWS queue name should be consistent
3241         <http://webkit.org/b/140585>
3242
3243         Reviewed by Daniel Bates.
3244
3245         * Scripts/webkitpy/common/config/ews.json: Rename 'ios-device'
3246         to 'ios'.
3247         * Scripts/webkitpy/common/config/ports.py: Ditto.
3248         (DeprecatedPort.port):
3249         (IOSPort):
3250         * Scripts/webkitpy/port/ios.py: Ditto.
3251         (IOSPort):
3252
3253         * Scripts/webkitpy/port/factory.py:
3254         (PortFactory): Re-order PORT_CLASSES so ios.IOSSimulatorPort
3255         appears before ios.IOSPort.  If this is not done,
3256         `run-webkit-tests --ios-simulator` will get the wrong Port class
3257         (IOSPort instead of IOSSimulatorPort) due to the way that
3258         PortFactory.get() uses prefix matching of <Port>.port_name to
3259         find the correct class to use.
3260
3261 2015-01-18  Alexey Proskuryakov  <ap@apple.com>
3262
3263         build.webkit.org/dashboard: OS X EWS is now on Mavericks
3264         https://bugs.webkit.org/show_bug.cgi?id=140595
3265
3266         Reviewed by Csaba Osztrogonác.
3267
3268         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3269         (BubbleQueueServer):
3270
3271 2015-01-17  David Kilzer  <ddkilzer@apple.com>
3272
3273         Attempt to fix webkitpy tests on Mountain Lion, Mavericks bots
3274
3275         * Scripts/webkitpy/port/ios.py:
3276         (IOSPort): Add 'ios-device-7' to VERSION_FALLBACK_ORDER so that
3277         test-webkitpy doesn't fail since iOS 7.x SDKs are installed on
3278         the Mountain Lion and Mavericks bots.
3279
3280 2015-01-17  David Kilzer  <ddkilzer@apple.com>
3281
3282         Attempt to fix webkitpy tests on GTK Linux ports
3283
3284         * Scripts/webkitpy/port/ios.py:
3285         (IOSPort.determine_full_port_name): Set a sensible default if
3286         not running on a Mac platform or if no iOS SDK is installed.
3287
3288 2015-01-17  Jake Nielsen  <jacob_nielsen@apple.com>
3289
3290         Create iOS-EWS client queue
3291         https://bugs.webkit.org/show_bug.cgi?id=140476
3292
3293         Reviewed by Alexey Proskuryakov.
3294
3295         * EWSTools/start-queue-mac.sh:
3296         Adds call to configure-xcode-for-ios-development for iOS EWS.
3297         * Scripts/webkitpy/common/config/ews.json:
3298         Adds the iOS EWS config entry.
3299         * Scripts/webkitpy/common/config/ports.py:
3300         (DeprecatedPort.port):
3301         Adds IOSPort to the port map.
3302         (IOSPort):
3303         (IOSPort.build_webkit_command):
3304         Adds --sdk=iphoneos to the webkit build command.
3305         * Scripts/webkitpy/port/base.py:
3306         (Port.architecture):
3307         Adds an accessor for the architecture member variable.
3308         * Scripts/webkitpy/port/factory.py:
3309         (PortFactory):
3310         Adds IOSPort to the port class list.
3311         * Scripts/webkitpy/port/ios.py:
3312         Adds the IOSPort to encapsulate iOS-specific things.
3313         (IOSPort):
3314         (IOSPort.determine_full_port_name):
3315         (IOSPort.__init__):
3316         (IOSPort._build_driver_flags):
3317         (IOSPort.operating_system):
3318         * Scripts/webkitpy/tool/commands/download_unittest.py:
3319         Adds the archetecture option to the mock options.
3320         (DownloadCommandsTest._default_options):
3321         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3322         Appends the archetecture option into calls to webkit-patch.
3323         (AbstractEarlyWarningSystem.review_patch):
3324         (AbstractEarlyWarningSystem.run_command):
3325         (AbstractEarlyWarningSystem.load_ews_classes):
3326         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3327         Adds logic to soothe the unittest now that --architecture is being
3328         thrown around everywhere.
3329         (EarlyWarningSystemTest._default_expected_logs):
3330         * Scripts/webkitpy/tool/commands/queues.py:
3331         Adds glue code to ferry the --architecture option around.
3332         (AbstractQueue.__init__):
3333         (PatchProcessingQueue.begin_work_queue):
3334         * Scripts/webkitpy/tool/steps/abstractstep.py:
3335         Adds the archetecture option to all AbstractSteps so that
3336         EarlyWarningSystem doesn't start shoving --architecture into
3337         unsuspecting commands.
3338         (AbstractStep.options):
3339         * Scripts/webkitpy/tool/steps/build.py:
3340         Translates the --architecture option into an ARCHS= format to pass to
3341         build-webkit.
3342         (Build.build):
3343         * Scripts/webkitpy/tool/steps/options.py:
3344         Adds a definition for the --architecture option.
3345         (Options):
3346
3347 2015-01-16  Sam Weinig  <sam@webkit.org>
3348
3349         Add a basic configuration object for WKView
3350         https://bugs.webkit.org/show_bug.cgi?id=140559
3351
3352         Reviewed by Anders Carlsson.
3353
3354         Add tests for WKPageConfigurationRef.
3355
3356         * TestWebKitAPI/PlatformWebView.h:
3357         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3358         * TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp: Added.
3359         (TestWebKitAPI::TEST):
3360         (TestWebKitAPI::didFinishLoadForFrame):
3361         (TestWebKitAPI::setPageLoaderClient):
3362         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3363         (TestWebKitAPI::PlatformWebView::initialize):
3364         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3365
3366 2015-01-16  Myles C. Maxfield  <mmaxfield@apple.com>
3367
3368         WeakPtr functions crash when created with default constructor
3369         https://bugs.webkit.org/show_bug.cgi?id=140479
3370
3371         Reviewed by Andreas Kling.
3372
3373         Add WeakPtr API tests.
3374
3375         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3376         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: Added.
3377         * TestWebKitAPI/Tests/WTF/Ref.cpp: Update to not use copy constructor.
3378
3379 2015-01-16  Chris Dumez  <cdumez@apple.com>
3380
3381         Regression(r178586): Caused webkitpy.w3c.test_converter_unittest.W3CTestConverterTest.test_convert_prefixed_properties to fail
3382         https://bugs.webkit.org/show_bug.cgi?id=140568
3383
3384         Reviewed by Alexey Proskuryakov.
3385
3386         Fix the script parsing CSSPropertyNames.in to stop splitting lines
3387         on '=' sign. The '=' sign is also used in StyleBuilder parameters:
3388         e.g. "Longhands=background-position-x|background-position-y".
3389         This would confuse the script and treat this as a CSS property:
3390         "background-position-x|background-position-y".
3391
3392         We now split on white space and treat the first string on the line
3393         to be the property name (this is the syntax in this file).
3394
3395         * Scripts/webkitpy/w3c/test_converter.py:
3396         (_W3CTestConverter.__init__):
3397         (_W3CTestConverter.read_webkit_prefixed_css_property_list):
3398
3399 2015-01-16  Daniel Bates  <dabates@apple.com>
3400
3401         REGRESSION (r171968): run-safari --simulator fails to launch Safari on iOS
3402         https://bugs.webkit.org/show_bug.cgi?id=135589
3403
3404         Reviewed by David Kilzer.
3405
3406         Derived from a patch by David Farler.
3407
3408         Following the removal IPhoneSimulatorNotification.pm in <http://trac.webkit.org/changeset/171968>
3409         run-safari --simulator fails to launch Safari on iOS. We need to implement run-safari
3410         in terms of the simctl command line utility.
3411
3412         * Scripts/webkitdirs.pm: Added constant SIMULATOR_DEVICE_STATE_BOOTED.
3413         (eraseIOSSimulatorDevice): Added.
3414         (bootedIOSSimulatorDevice): Added.
3415         (iosSimulatorApplicationsPath): Added.
3416         (installedMobileSafariBundle): Implemented in terms of iosSimulatorApplicationsPath().
3417         (openIOSSimulator): Modified to launch iOS Simulator using OPEN(1).
3418         (quitIOSSimulator): Added.
3419         (iosSimulatorDeviceByName): Modified to find the first simulator device that matches
3420         the specified name and currently selected iOS runtime.
3421         (isIOSSimulatorSystemInstalledApp): Added.
3422         (runIOSWebKitAppInSimulator): Modified to use simctl launch to launch an app in the simulator.
3423         (deleteiOSSimulatorDevice): Deleted.
3424         (loadIPhoneSimulatorNotificationIfNeeded): Deleted.
3425         (installAndLaunchIOSWebKitAppInSimulator): Deleted.
3426
3427 2015-01-16  Alex Christensen  <alex.christensen@flexsim.com>
3428
3429         Resurrect the WinCairo bot.
3430         https://bugs.webkit.org/show_bug.cgi?id=139908
3431
3432         Reviewed by Csaba Osztrogonác.
3433
3434         * BuildSlaveSupport/build.webkit.org-config/config.json:
3435         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3436         (appendCustomBuildFlags):
3437         * BuildSlaveSupport/test-result-archive:
3438         (archiveTestResults):
3439         Add WinCairo buildbot.
3440
3441 2015-01-16  Chris Dumez  <cdumez@apple.com>
3442
3443         webkit-patch should auto-install the keyring python module
3444         https://bugs.webkit.org/show_bug.cgi?id=140547
3445
3446         Reviewed by David Kilzer.
3447
3448         Auto-install the keyring python module. This is the module that
3449         webkit-patch uses for cross-platform access to the keyring
3450         service.
3451
3452         Without this module, if the password if not in the keychain,
3453         webkit-patch will keep asking for your username / password and
3454         never remember them.
3455
3456         * Scripts/webkitpy/common/net/credentials.py:
3457         * Scripts/webkitpy/thirdparty/__init__.py:
3458         (AutoinstallImportHook.find_module):
3459         (AutoinstallImportHook._install_keyring):
3460
3461 2015-01-15  Csaba Osztrogonác  <ossy@webkit.org>
3462
3463         Remove ENABLE(SQL_DATABASE) guards
3464         https://bugs.webkit.org/show_bug.cgi?id=140434
3465
3466         Reviewed by Darin Adler.
3467
3468         * Scripts/webkitperl/FeatureList.pm:
3469
3470 2015-01-15  Daniel Bates  <dabates@apple.com>
3471
3472         [iOS] REGRESSION (r174642): DumpRenderTree.app test may dump result twice
3473         https://bugs.webkit.org/show_bug.cgi?id=139685
3474         <rdar://problem/19281317>
3475
3476         Reviewed by Simon Fraser.
3477
3478         Fixes an issue where a test in DumpRenderTree.app may dump its result twice. In particular,
3479         the test LayoutTests/fast/dom/gc-10.html may dump its result twice.
3480
3481         Following <http://trac.webkit.org/changeset/174642>, we dump the test result asynchronously
3482         as opposed to synchronously. So, the WebThread or the main thread may perform other tasks
3483         before DRT dumps the output of a test. In particular, the WebThread may start a new page
3484         load (say, as a result of continued JavaScript execution), which will ultimately lead to
3485         dumping the test result again. Instead we want DRT to dump the test result synchronously
3486         such that we capture the state of the web page either when the page is loaded or when
3487         window.testRunner.notifyDone() is called.
3488
3489         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3490         (createBitmapContextFromWebView): Moved logic to re-enable tile painting and update the
3491         state of the display from here to updateDisplay(). Added call to -[CATransaction flush] to
3492         flush CA transactions to the window.
3493         * DumpRenderTree/mac/DumpRenderTree.mm:
3494         (updateDisplay): Added iOS-specific code to update tiles and tell WebKit to flush
3495         compositing changes to ensure that we have up-to-date tile content for a pixel/ref-test.
3496         (dump): Renamed; formerly named dumpTestResults().
3497         (displayWebView): Removed outdated FIXME comment. Added FIXME comment to investigate
3498         enabling repaint support on iOS.
3499         (-[DumpRenderTree _deferDumpToMainThread]): Deleted.
3500         (-[DumpRenderTree _waitForWebThreadThenDump]): Deleted.
3501         (dumpTestResults): Deleted.
3502
3503 2015-01-15  Brent Fulgham  <bfulgham@apple.com>
3504
3505         [Win] Miscellaneous DRT fixes
3506         https://bugs.webkit.org/show_bug.cgi?id=116562
3507
3508         Reviewed by Tim Horton.
3509
3510         While investigating the cause of several Windows crashes, I found:
3511         (1) Messy conversions to and from BSTR types
3512         (2) Weird mixes of wide-string and narrow string conversions
3513         (3) Passing nullptr to some CoreFoundation routines that do not
3514             permit null arguments.
3515         (4) Commands to link the executable to the VS2005 runtime.
3516
3517         This patch cleans up these issues to improve DRT reliability on
3518         Windows.
3519
3520         * DumpRenderTree/cg/ImageDiffCG.cpp:
3521         (main): Get rid of VS2005 runtime linking.
3522         * DumpRenderTree/win/DumpRenderTree.cpp:
3523         (urlSuitableForTestResult): Protect against being asked
3524         to process an empty URL.
3525         (dumpHistoryItem): Do BSTR string building using _bstr_t, rather
3526         than converting to/from wchar_t buffers.
3527         (runTest): Simplify string and BSTR handling.
3528         (createWebViewAndOffscreenWindow): Ditto.
3529         (main): Get rid of VS2005 runtime linking.
3530         * DumpRenderTree/win/TestRunnerWin.cpp:
3531         (jsStringRefToWString): Simplify code.
3532         (TestRunner::pathToLocalResource):
3533         (TestRunner::setUserStyleSheetLocation):
3534         * TestWebKitAPI/win/main.cpp: Get rid of
3535         VS2005 runtime linking.
3536         * win/DLLLauncher/DLLLauncherMain.cpp:
3537         (wWinMain): Ditto.
3538
3539 2015-01-15  Alexey Proskuryakov  <ap@apple.com>
3540
3541         Stop hardcoding mac-mountainlion in commit queue
3542         https://bugs.webkit.org/show_bug.cgi?id=140492
3543
3544         Reviewed by Anders Carlsson.
3545
3546         Use "mac", not "mac-<platform>". This matches how EWS queues are initialized, and
3547         there should be no change in behavior, because:
3548         1. PatchProcessingQueue converts the name with _new_port_name_from_old() before
3549         using it to create a port object.
3550         2. Although it doesn't convert the name before using DeprecatedPort.port(), it
3551         is actually correct to use "mac" for the name there. We only used to get the expected
3552         behavior with "mac-mountainlion" accidentally, because of a fallback to "mac"
3553         for unknown deprecated port names.
3554
3555         * Scripts/webkitpy/tool/commands/queues.py: (CommitQueue):
3556
3557 2015-01-14  Jake Nielsen  <jacob_nielsen@apple.com>
3558
3559         Create iOS-EWS server queue
3560         https://bugs.webkit.org/show_bug.cgi?id=140473
3561
3562         Reviewed by Benjamin Poulain.
3563
3564         * QueueStatusServer/app.yaml: Updates the SVN version number.
3565         * QueueStatusServer/config/queues.py: Add ios-ews queue.
3566         * QueueStatusServer/model/queues.py:         
3567         (Queue.display_name): Makes sure the display name is pretty!
3568
3569 2015-01-14  Daniel Bates  <dabates@apple.com>
3570
3571         [iOS] run-webkit-tests --ios hangs trying to launch iOS Simulator with unavailable runtime
3572         https://bugs.webkit.org/show_bug.cgi?id=140301
3573         <rdar://problem/19389266>
3574
3575         Reviewed by Jon Honeycutt.
3576
3577         Fixes an issue where run-webkit-tests --ios will hang when trying to launch iOS Simulator
3578         with an unavailable runtime.
3579
3580         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3581         (_set_up_derived_options): Modified to access property Simulator.latest_available_runtime,
3582         which was formerly called Simulator.latest_runtime. Additionally, raise an exception if the
3583         specified runtime cannot be used because it is unavailable.
3584         * Scripts/webkitpy/port/ios.py:
3585         (IOSSimulatorPort.testing_device): Modified to call Simulator.lookup_or_create_device(),
3586         which was formerly named testing_device.
3587         * Scripts/webkitpy/xcode/simulator.py:
3588         (Device.create): Modified to lookup created device by the UDID returned by simctl, which is
3589         more robust than looking up the simulator device by name and runtime. This approach also
3590         avoids returning the wrong device due to <rdar://problem/19444383> (simctl list shows
3591         unavailable runtimes under the same iOS heading it would use to show it as available).
3592         (Simulator.find_device_by_udid): Added.
3593         (Simulator.device): Added optional parameter should_ignore_unavailable_devices (defaults
3594         to False) to ignore devices that are unavailable (say, because their runtime is unavailable).
3595         (Simulator.available_runtimes): Added.
3596         (Simulator.latest_available_runtime): Renamed; formerly named latest_runtime. Take advantage
3597         of the reverse=True argument to sorted() to sort the list of available runtimes such that the
3598         first element of the sorted list is the runtime with the highest version number.
3599         (Simulator.lookup_or_create_device): Renamed; formerly named testing_device.
3600
3601 2015-01-14  Csaba Osztrogonác  <ossy@webkit.org>
3602
3603         Remove WK2 Windows cruft
3604         https://bugs.webkit.org/show_bug.cgi?id=140440
3605
3606         Reviewed by Anders Carlsson.
3607
3608         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp: Removed.
3609         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp: Removed.
3610         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp: Removed.
3611
3612 2015-01-13  Hunseop Jeong  <hs85.jeong@samsung.com>
3613
3614         Fix TestWTF failed in TestWebKitAPI
3615         https://bugs.webkit.org/show_bug.cgi?id=140333
3616
3617         Reviewed by Sam Weinig.
3618
3619         Clear the std::ostringstream before starting test.
3620
3621         * TestWebKitAPI/Tests/WTF/RefLogger.h:
3622         (TestWebKitAPI::DerivedRefLogger::DerivedRefLogger):
3623
3624 2015-01-13  Michael Catanzaro  <mcatanzaro@igalia.com>
3625
3626         TestWebKitWebContext depends on British English spellcheck dictionary
3627         https://bugs.webkit.org/show_bug.cgi?id=140403
3628
3629         Reviewed by Martin Robinson.
3630
3631         Install all English hunspell dictionaries on Fedora and Arch.
3632
3633         * gtk/install-dependencies:
3634
3635 2015-01-13  Michael Catanzaro  <mcatanzar