Release assert in Document::updateLayout() in WebPage::determinePrimarySnapshottedPlu...
[WebKit-https.git] / Tools / ChangeLog
1 2018-06-07  Thibault Saunier  <tsaunier@igalia.com>
2
3         [GTK][WPE] Start implementing MediaStream API
4         https://bugs.webkit.org/show_bug.cgi?id=185787
5
6         Reviewed by Philippe Normand.
7
8         * Scripts/webkitpy/style/checker.py: Apply special formatting rules for new GObject subclasses.
9         * gstreamer/jhbuild.modules: Added a patch for the gst-plugins-base.
10         * gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTION-on-EVENT_STREAM_COLL.patch:
11         Added this fix to gst-plugings-base to fix the decodebin3. Merged as 89d0e9cc92a86aa0227ee87406737b6d31670aea
12
13 2018-06-07  Brendan McLoughlin  <brendan@bocoup.com>
14
15         Update web-platform-tests github location in webkitpy.w3c.test_importer
16         https://bugs.webkit.org/show_bug.cgi?id=186392
17
18         Reviewed by Youenn Fablet.
19
20         * Scripts/webkitpy/w3c/test_importer.py:
21         (TestImporter.write_import_log):
22
23 2018-06-07  Jonathan Bedard  <jbedard@apple.com>
24
25         webkitperl: Generalize .internal SDK suffix
26         https://bugs.webkit.org/show_bug.cgi?id=186352
27         <rdar://problem/40853947>
28
29         Reviewed by Alexey Proskuryakov.
30
31         * Scripts/build-webkit:
32         * Scripts/package-root:
33         (usage):
34         * Scripts/webkitdirs.pm:
35         (parseAvailableXcodeSDKS): Parse 'xcodebuild -showsdks' output.
36         (availableXcodeSDKS): Generate a list of all available Xcode SDKs on this machine.
37         (determineXcodeSDK): Always prefer .internal SDKs if available.
38         * Scripts/webkitperl/webkitdirs_unittest/availableXcodeSDKS.pl:
39         
40 2018-06-07  Fujii Hironori  <Hironori.Fujii@sony.com>
41
42         [Win][MiniBrowser] Support multiple windows properly
43         https://bugs.webkit.org/show_bug.cgi?id=186263
44
45         Reviewed by Ryosuke Niwa.
46
47         The current implementation of
48         PrintWebUIDelegate::createWebViewWithRequest is wrong. It is using
49         CreateProcess to open a new window, and doesn't return the new
50         instance of IWebView. As the result, for example, window.close
51         doesn't work as expected.
52
53         In this change, a new MainWindow is created and return the
54         IWebView in PrintWebUIDelegate::createWebViewWithRequest.
55
56         In addition to it, this change unifies the lifetime of MiniBrowser
57         and its delegates AccessibilityDelegate, PrintWebUIDelegate,
58         ResourceLoadDelegate and WebDownloadDelegate in order to keep
59         MiniBrowser alive as long as the delegates live. Because the
60         window of webview keeps references of such delegates and accesses
61         those after MiniBrowser destruction.
62
63         * MiniBrowser/win/MainWindow.h: Added s_numInstances class member
64         to count the number of instance to close the application. Do not
65         use unique_ptr for m_browserWindow because it has ref count now.
66         * MiniBrowser/win/MainWindow.cpp:
67         (MainWindow::MainWindow): Increment s_numInstances.
68         (MainWindow::~MainWindow): Decrement s_numInstances.
69         (MainWindow::create):
70         (MainWindow::init):
71         (MainWindow::WndProc): Rename thiz to thisWindow. Keep this
72         instance alive during this function by using RefPtr<MainWindow>.
73         Deref the MainWindow instance on WM_DESTROY. Quit the application
74         when the last MainWindow is closed.
75         (MainWindow::cachesDialogProc): Rename thiz to thisWindow.
76         (MainWindow::customUserAgentDialogProc): Ditto.
77         * MiniBrowser/win/MiniBrowser.h: Added declarations AddRef and Release.
78         * MiniBrowser/win/MiniBrowser.cpp:
79         (MiniBrowser::create):
80         (MiniBrowser::AddRef):
81         (MiniBrowser::Release):
82         (MiniBrowser::init): Passes this to the constructors of delegates.
83         * MiniBrowser/win/AccessibilityDelegate.cpp:
84         (AccessibilityDelegate::AddRef): Delegate to MiniBrowser.
85         (AccessibilityDelegate::Release): Ditto.
86         * MiniBrowser/win/AccessibilityDelegate.h: Removed m_refCount.
87         (AccessibilityDelegate::AccessibilityDelegate):
88         * MiniBrowser/win/MiniBrowserWebHost.cpp:
89         (MiniBrowserWebHost::AddRef): Delegate to MiniBrowser.
90         (MiniBrowserWebHost::Release): Ditto.
91         * MiniBrowser/win/MiniBrowserWebHost.h: Removed m_refCount.
92         * MiniBrowser/win/PrintWebUIDelegate.cpp:
93         (PrintWebUIDelegate::createWebViewWithRequest): Create a new
94         MainWindow and return the IWebView.
95         (PrintWebUIDelegate::AddRef): Delegate to MiniBrowser.
96         (PrintWebUIDelegate::Release): Ditto.
97         * MiniBrowser/win/PrintWebUIDelegate.h: Removed m_refCount.
98         (PrintWebUIDelegate::PrintWebUIDelegate):
99         * MiniBrowser/win/ResourceLoadDelegate.cpp:
100         (ResourceLoadDelegate::AddRef): Delegate to MiniBrowser.
101         (ResourceLoadDelegate::Release): Ditto.
102         * MiniBrowser/win/ResourceLoadDelegate.h: Removed m_refCount.
103         * MiniBrowser/win/WebDownloadDelegate.cpp:
104         (WebDownloadDelegate::WebDownloadDelegate):
105         (WebDownloadDelegate::AddRef): Delegate to MiniBrowser.
106         (WebDownloadDelegate::Release): Ditto.
107         * MiniBrowser/win/WebDownloadDelegate.h: Removed m_refCount.
108
109 2018-06-06  Fujii Hironori  <Hironori.Fujii@sony.com>
110
111         [Win][MiniBrowser] Remove gMainWindow global variable
112         https://bugs.webkit.org/show_bug.cgi?id=186378
113
114         Reviewed by Ryosuke Niwa.
115
116         I'm going to support multiple MainWindow in Bug 186263. It should
117         not be assumed that MainWindow has only one instance. gMainWindow
118         is used only in DisplayAuthDialog.
119
120         * MiniBrowser/win/Common.cpp:
121         (authDialogProc): Use DWLP_USER to store the dialog data.
122         (displayAuthDialog): Moved and renamed from
123         MainWindow::displayAuthDialog. Use DialogBoxParam instead of
124         DialogBox to pass a data pointer. Do not return S_OK if
125         DialogBoxParam returns -1. Take a HWND argument as the parent
126         window.
127         (DisplayAuthDialog): Deleted.
128         * MiniBrowser/win/Common.h:
129         * MiniBrowser/win/MainWindow.cpp:
130         (authDialogProc): Moved to Common.cpp.
131         (MainWindow::displayAuthDialog): Ditto.
132         * MiniBrowser/win/MainWindow.h:
133         * MiniBrowser/win/ResourceLoadDelegate.cpp:
134         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
135         * MiniBrowser/win/WinMain.cpp:
136         (wWinMain): Added a local variable mainWindow instead of using
137         gMainWindow.
138
139 2018-06-06  Dan Bernstein  <mitz@apple.com>
140
141         [Xcode] Opt out of the New Build System
142         https://bugs.webkit.org/show_bug.cgi?id=186380
143
144         Reviewed by Alexey Proskuryakov.
145
146         * Scripts/webkitdirs.pm:
147         (XcodeOptions): Have -UseNewBuildSystem=NO passed to xcodebuild.
148
149 2018-06-06  Antoine Quint  <graouts@apple.com>
150
151         Rename color-filter to -apple-color-filter and do not expose it to Web content
152         https://bugs.webkit.org/show_bug.cgi?id=186306
153         <rdar://problem/39874167>
154
155         Reviewed by Simon Fraser.
156
157         Adding an option to turn support for the -apple-color-filter property on via an HTML comment.
158
159         * DumpRenderTree/TestOptions.cpp:
160         (TestOptions::TestOptions):
161         * DumpRenderTree/TestOptions.h:
162         * DumpRenderTree/mac/DumpRenderTree.mm:
163         (setWebPreferencesForTestOptions):
164         * WebKitTestRunner/TestController.cpp:
165         (WTR::TestController::resetPreferencesToConsistentValues):
166         (WTR::updateTestOptionsFromTestHeader):
167         * WebKitTestRunner/TestOptions.h:
168         (WTR::TestOptions::hasSameInitializationOptions const):
169         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
170         (WTR::TestController::platformCreateWebView):
171
172 2018-06-06  Brent Fulgham  <bfulgham@apple.com>
173
174         Adjust compile and runtime flags to match shippable state of features (Part 2)
175         https://bugs.webkit.org/show_bug.cgi?id=186319
176         <rdar://problem/40352045>
177
178         Unreviewed test fix.
179
180         TestWebKitAPI was timing out because 'color' input types are no longer support. I also discovered that the
181         ASSERT_STREQ macro returns on error, which causes tests to time out whenever a 'done = true' call (needed to
182         end the test) is done after ASSERT_STREQ, which might fail and return early, preventing the flag from being
183         set.
184
185         * TestWebKitAPI/Tests/WebKitCocoa/InjectedBundleNodeHandleIsTextField.mm:
186         (-[InjectedBundleNodeHandleIsTextField webProcessPlugIn:didCreateBrowserContextController:]): Make testing of
187         the 'color' input type conditional on the feature being part of the build.
188         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
189         (-[AutoFillDelegate _webView:didClickAutoFillButtonWithUserInfo:]): Set the 'done=true' state before performing
190         string equality assertions, since they do an early return and bypass the end state of the test.
191         (-[DidResignInputElementStrongPasswordAppearanceDelegate _webView:didResignInputElementStrongPasswordAppearanceWithUserInfo:]): Ditto.
192         (-[AutoFillAvailableDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Ditto.
193         (-[InjectedBundleNodeHandleIsTextFieldDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Ditto.
194
195 2018-06-05  Chris Dumez  <cdumez@apple.com>
196
197         Regression(r232082): Websites get loaded inside of Messages App chat transcript
198         https://bugs.webkit.org/show_bug.cgi?id=186331
199         <rdar://problem/40735446>
200
201         Reviewed by Darin Adler.
202
203         Add API test coverage.
204
205         * TestWebKitAPI/Tests/mac/NoPolicyDelegateResponse.mm:
206         (-[NoDecidePolicyForNavigationActionDecisionDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
207         (-[NoDecidePolicyForNavigationActionDecisionDelegate webView:didStartProvisionalLoadForFrame:]):
208         (TestWebKitAPI::TEST):
209         (-[NoPolicyDelegateDecisionDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]): Deleted.
210         (-[NoPolicyDelegateDecisionDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]): Deleted.
211         (-[NoPolicyDelegateDecisionDelegate webView:didFinishLoadForFrame:]): Deleted.
212
213 2018-06-05  Wenson Hsieh  <wenson_hsieh@apple.com>
214
215         DataInteractionTests ContentEditableToTextarea and ContentEditableToContentEditable are failing on recent iOS 12
216         https://bugs.webkit.org/show_bug.cgi?id=186325
217         <rdar://problem/40527850>
218
219         Reviewed by Tim Horton.
220
221         Tweak these API tests so that they're robust against changes to how NSAttributedStrings are serialized in item
222         providers ("public.rtf" vs. "com.apple.flat-rtfd"). Across all versions of iOS, just verify that either rich
223         text type is present in the list of dragged type identifiers, and that the rich text type is placed at a higher
224         fidelity than plain text.
225
226         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
227         (checkRichTextTypePrecedesPlainTextType):
228         (TestWebKitAPI::TEST):
229         (checkTypeIdentifierPrecedesOtherTypeIdentifier): Deleted.
230
231 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
232
233         Adjust compile and runtime flags to match shippable state of features
234         https://bugs.webkit.org/show_bug.cgi?id=186319
235         <rdar://problem/40352045>
236
237         Reviewed by Maciej Stachowiak, Jon Lee, and others.
238
239         This patch revises the compile time and runtime state for various features to match their
240         suitability for end-user releases.
241
242         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Update to match WebKit definition of
243         WK_RELOCATABLE_FRAMEWORKS so that ENABLE(EXPERIMENTAL_FEATURES) is defined properly for
244         Cocoa builds.
245         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Don't build ENABLE_INPUT_TYPE_COLOR
246         or ENABLE_INPUT_TYPE_COLOR_POPOVER.
247
248 2018-06-05  Saam Barati  <sbarati@apple.com>
249
250         run-testmem should have a dry run option and an option to parse the stdout of executing the dry run
251         https://bugs.webkit.org/show_bug.cgi?id=186293
252
253         Reviewed by Mark Lam.
254
255         This makes it easier to execute run-testmem on a device that doesn't have ruby
256         on it. run-testmem now has a --dry option that will output commands to execute
257         in bash. To run on a device that doesn't have ruby, just put its output into
258         a bash script, and copy the PerformanceTests/testmem directory onto that device,
259         and execute the bash script. Running that bash script will give you raw output.
260         Make a file with that output and pass it into run-testmem using the --parse option.
261         run-testmem will parse the raw output and compute the benchmark score.
262
263         * Scripts/run-testmem:
264
265 2018-06-05  Youenn Fablet  <youenn@apple.com>
266
267         ServiceWorker registration should store any script fetched through importScripts
268         https://bugs.webkit.org/show_bug.cgi?id=182444
269         <rdar://problem/37164835>
270
271         Reviewed by Chris Dumez.
272
273         Add support to crash the storage process from Internals.
274
275         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
276         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
277         (WTR::TestRunner::terminateStorageProcess):
278         * WebKitTestRunner/InjectedBundle/TestRunner.h:
279         * WebKitTestRunner/TestController.cpp:
280         (WTR::TestController::terminateStorageProcess):
281         * WebKitTestRunner/TestController.h:
282         * WebKitTestRunner/TestInvocation.cpp:
283         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
284
285 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
286
287         Revise DEFAULT_EXPERIMENTAL_FEATURES_ENABLED to work properly on Apple builds
288         https://bugs.webkit.org/show_bug.cgi?id=186286
289         <rdar://problem/40782992>
290
291         Reviewed by Dan Bernstein.
292
293         Use the WK_RELOCATABLE_FRAMEWORKS flag (which is always defined for non-production builds)
294         to define ENABLE(EXPERIMENTAL_FEATURES) so that we do not need to manually
295         change this flag when preparing for a production release.
296
297         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Use WK_RELOCATABLE_FRAMEWORKS to
298         determine whether experimental features should be enabled, and use it to properly define
299         the feature flag.
300
301 2018-06-05  Robin Morisset  <rmorisset@apple.com>
302
303         Add a grammar (in antlr4 format) to the WSL spec.
304         https://bugs.webkit.org/show_bug.cgi?id=186310
305
306         Rubberstamped by Filip Pizlo
307
308         It is just the raw rules, without much comments and no typesetting.
309         Compiles to any of Java/JS/C++/etc.. with antlr4 (requires a JDK)
310
311         It does not exactly match the parser of the current js implementation of WSL, it:
312         - Accepts negative literals
313         - Reserves keywords fallthrough/auto
314         - Refuses '_' as a valid identifier
315         - Accepts several capitalizations for Null/True/False
316         - Accepts variable declarations at the top-level
317         - Correctly parses ternary expressions
318         - Forbids empty extension list for protocols
319         - Does not allow a space between '[' and ']' in type suffixes
320         - Correctly parses nested generics
321         - Accepts a 'fallthrough;' statement (for switches)
322         - Refuses chained relational operator (e.g. x < y < z)
323         - Generally a completely different structure for parsing effectful expressions, although it probably accepts about the same language
324         - Currently only accepts literals and identifiers as constexpr (while the js parser accepts way too much, including '(x += 42)')
325         There are probably more differences that I missed. The js parser will probably have to be mostly rewritten to follow the spec more closely (and fix all the bugs).
326         I will try to see if it can be automatically derived from the antlr4 grammar.
327
328         * WebGPUShadingLanguageRI/SpecWork/WSL.g4: Added.
329
330 2018-06-04  Frederic Wang  <fwang@igalia.com>
331
332         import-w3c-tests should rely on <meta name="flags"> to detect CSS manual tests
333         https://bugs.webkit.org/show_bug.cgi?id=186261
334
335         Reviewed by Youenn Fablet.
336
337         * Scripts/webkitpy/w3c/test_parser.py:
338         (TestParser.is_wpt_manualtest): Add code to detect whether a file is a manual test
339         from its <meta name="flags"> tags. This is based on SourceFile::content_is_css_manual from
340         the WPT repository.
341         * Scripts/webkitpy/w3c/test_parser_unittest.py: Add a test to verify whether files with
342         <meta name="flags"> are manual or non-manual according to CSS WG rules.
343
344 2018-06-04  Dan Bernstein  <mitz@apple.com>
345
346         Fixed building ImageDiff with the default build system in the Xcode 10 developer beta.
347
348         * ImageDiff/cg/Configurations/Base.xcconfig: Use #include? to include
349           HaveInternalSDK.xcconfig, since it may not be preent.
350
351 2018-06-04  Dan Bernstein  <mitz@apple.com>
352
353         Fixed building TestWebKitAPI with a shared build directory with XCBuild, which is the
354         default build system in the Xcode 10 developer beta.
355
356         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Changed the reference to the
357           built libWTF.a to be relative to the built products directory.
358
359 2018-06-04  Chris Dumez  <cdumez@apple.com>
360
361         Rename "Cross-Origin-Options" HTTP header to "Cross-Origin-Window-Policy"
362         https://bugs.webkit.org/show_bug.cgi?id=186287
363         <rdar://problem/40783352>
364
365         Reviewed by Youenn Fablet.
366
367         * DumpRenderTree/mac/DumpRenderTree.mm:
368         (enableExperimentalFeatures):
369         * DumpRenderTree/win/DumpRenderTree.cpp:
370         (enableExperimentalFeatures):
371
372 2018-06-04  Daniel Bates  <dabates@apple.com>
373
374         Typo in MockBugzillaQueries.fetch_attachment_ids_from_review_queue()
375         https://bugs.webkit.org/show_bug.cgi?id=186290
376
377         Reviewed by Aakash Jain.
378
379         Although the usefulness of the code in MockBugzillaQueries.fetch_attachment_ids_from_review_queue() is
380         questionable we should fix a typo when calling this mocked function with argument since.
381
382         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
383         (MockBugzillaQueries.fetch_attachment_ids_from_review_queue):
384
385 2018-06-04  Dan Bernstein  <mitz@apple.com>
386
387         Fixed building with the macOS Mojave seed SDK.
388
389         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm:
390
391 2018-06-04  Alexey Proskuryakov  <ap@apple.com>
392
393         Add Mojave support to WebKit tools
394         https://bugs.webkit.org/show_bug.cgi?id=186282
395
396         Reviewed by Daniel Bates.
397
398         Nightly build support will be added separately.
399
400         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mojave.png: Added.
401         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mojave@2x.png: Added.
402         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
403         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
404         Added dashboard support.
405
406         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
407         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
408         Trigger the right build queues on check-in.
409
410         * Scripts/webkitpy/common/version_name_map.py:
411         * Scripts/webkitpy/common/version_name_map_unittest.py:
412         The main version mapping class updated.
413
414         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
415         * Scripts/webkitpy/port/mac_unittest.py:
416         Updated for more platforms in unit tests.
417
418         * TestResultServer/static-dashboards/flakiness_dashboard.js:
419         Added the new platform to flakiness dashboard.
420
421 2018-06-04  Wenson Hsieh  <wenson_hsieh@apple.com>
422
423         [WebKit on watchOS] Remove all uses of the EXTRA_ZOOM_MODE compiler flag
424         https://bugs.webkit.org/show_bug.cgi?id=186279
425
426         Reviewed by Tim Horton.
427
428         Replaces uses of ENABLE(EXTRA_ZOOM_MODE) with PLATFORM(WATCHOS).
429
430         * TestWebKitAPI/Tests/ios/RenderingProgressTests.mm:
431
432 2018-06-03  Fujii Hironori  <Hironori.Fujii@sony.com>
433
434         [Win][MiniBrowser] Remove gMiniBrowser global variable
435         https://bugs.webkit.org/show_bug.cgi?id=186134
436
437         Reviewed by Brent Fulgham.
438
439         It should not be assumed there is only one main window and one browser
440         window to support multiple windows properly. gMainWindow and
441         gMiniBrowser global variables should be removed. This change
442         removes gMiniBrowser.
443
444         * MiniBrowser/win/Common.cpp: Removed gMiniBrowser global variable.
445         * MiniBrowser/win/Common.h: Ditto.
446         * MiniBrowser/win/MainWindow.cpp:
447         (MainWindow::init):
448         (MainWindow::WndProc):
449         (EditProc): Post WM_COMMAND if the enter key is pressed in URL bar.
450         (MainWindow::cachesDialogProc): Renamed from Caches.
451         (MainWindow::customUserAgentDialogProc): Renamed from CustomUserAgent.
452         (MainWindow::onURLBarEnter): Extracted from EditProc.
453         (BackButtonProc): Deleted.
454         (ForwardButtonProc): Deleted.
455         (Caches): Renamed to MainWindow::cachesDialogProc.
456         (CustomUserAgent): Renamed to MainWindow::customUserAgentDialogProc.
457         * MiniBrowser/win/MainWindow.h: Convert hCacheWnd global variable to a member variable of MainWindow.
458         * MiniBrowser/win/MiniBrowserLibResource.h:
459         * MiniBrowser/win/WinMain.cpp:
460         (wWinMain):
461
462 2018-06-02  Darin Adler  <darin@apple.com>
463
464         [Cocoa] Update some code to be more ARC-compatible to prepare for future ARC adoption
465         https://bugs.webkit.org/show_bug.cgi?id=186227
466
467         Reviewed by Dan Bernstein.
468
469         * DumpRenderTree/mac/AccessibilityCommonMac.mm:
470         (+[NSString stringWithJSStringRef:]): Use CFBridgingRelease instead of autorelease.
471         (-[NSString createJSStringRef]): Add __bridge to a bridging typecast.
472
473         * DumpRenderTree/mac/AccessibilityControllerMac.mm: Add a missing include.
474
475         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
476         (-[NSString createJSStringRef]): Add __bridge to a bridging typecast.
477         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
478         (AccessibilityTextMarker::isEqual): Ditto.
479         (AccessibilityTextMarkerRange::isEqual): Ditto.
480
481         * DumpRenderTree/mac/DumpRenderTree.mm:
482         (-[DumpRenderTree _waitForWebThread]): Use @autoreleasepool instead of NSAutoreleasePool.
483         (DumpRenderTreeMain): Ditto.
484         (WebThreadLockAfterDelegateCallbacksHaveCompleted): Ditto.
485         (runTest): Ditto.
486
487         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
488         (copyFile): Use a std::pair to return both a URL and an error rather than using an
489         out argument for the NSError.
490         (-[DumpRenderTreeFilePromiseReceiver receivePromisedFilesAtDestination:options:operationQueue:reader:]):
491         Updated for the above change.
492
493         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
494         (-[DumpRenderTreeWindow _addToOpenWindows]): Add __bridge to a bridging typecast.
495         (-[DumpRenderTreeWindow close]): Ditto.
496         * DumpRenderTree/mac/LayoutTestHelper.m:
497         (setDisplayColorProfile): Ditto.
498
499         * DumpRenderTree/mac/PolicyDelegate.mm: Add a missing include.
500
501         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
502         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
503         Add __bridge to a bridging typecast.
504         * DumpRenderTree/mac/TestRunnerMac.mm:
505         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]): Ditto.
506         (TestRunner::apiTestNewWindowDataLoadBaseURL): Use @autoreleasepool instead of NSAutoreleasePool.
507
508         * DumpRenderTree/mac/TextInputControllerMac.m: Fix a comment.
509
510         * DumpRenderTree/mac/UIScriptControllerMac.mm:
511         (WTR::UIScriptController::replaceTextAtRange): Add __bridge to a bridging typecast.
512         (WTR::UIScriptController::contentsOfUserInterfaceItem const): Ditto.
513         (WTR::UIScriptController::overridePreference): Ditto.
514         * DumpRenderTree/mac/WorkQueueItemMac.mm:
515         (LoadItem::invoke const): Ditto.
516         (LoadHTMLStringItem::invoke const): Ditto.
517         (ScriptItem::invoke const): Ditto.
518
519         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
520         (+[NSString stringWithJSStringRef:]): Use CFBridgingRelease instead of autorelease.
521         (-[NSString createJSStringRef]): Add __bridge to a bridging typecast.
522
523         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
524         (+[NSString stringWithJSStringRef:]): Use CFBridgingRelease instead of autorelease.
525         (-[NSString createJSStringRef]): Add __bridge to a bridging typecast.
526
527         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
528         (WTR::AccessibilityController::accessibleElementById): Add __bridge to a bridging typecast.
529         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
530         (-[NSString createJSStringRef]): Ditto.
531         * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerMac.mm:
532         (WTR::AccessibilityTextMarker::isEqual): Ditto.
533         * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerRangeMac.mm:
534         (WTR::AccessibilityTextMarkerRange::isEqual): Ditto.
535         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
536         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange): Ditto.
537         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker): Ditto.
538         (WTR::AccessibilityUIElement::textMarkerRangeLength): Ditto.
539         (WTR::AccessibilityUIElement::previousTextMarker): Ditto.
540         (WTR::AccessibilityUIElement::nextTextMarker): Ditto.
541         (WTR::AccessibilityUIElement::stringForTextMarkerRange): Ditto.
542         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers): Ditto.
543         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange): Ditto.
544         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange): Ditto.
545         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker): Ditto.
546         (WTR::createJSStringRef): Ditto.
547         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
548         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
549         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute): Ditto.
550         (WTR::AccessibilityUIElement::indexForTextMarker): Ditto.
551         (WTR::AccessibilityUIElement::isTextMarkerValid): Ditto.
552         (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker): Ditto.
553         (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker): Ditto.
554         (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker): Ditto.
555         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker): Ditto.
556         (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker): Ditto.
557         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker): Ditto.
558         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker): Ditto.
559         (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker): Ditto.
560         (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker): Ditto.
561         (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker): Ditto.
562         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
563         (WTR::initializeWebViewConfiguration): Ditto.
564         (WTR::TestController::platformContext): Ditto.
565         (WTR::TestController::platformPreferences): Ditto.
566         (WTR::TestController::platformAdjustContext): Ditto.
567         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
568         (WTR::PlatformWebView::PlatformWebView): Ditto.
569         * WebKitTestRunner/mac/TestControllerMac.mm:
570         (WTR::TestController::initializeInjectedBundlePath): Ditto.
571         (WTR::TestController::initializeTestPluginDirectory): Ditto.
572         (WTR::TestController::platformConfigureViewForTest): Ditto.
573
574         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
575         (WTR::nsString): Use CFBridgingRelease instead of autorelease.
576         (WTR::UIScriptController::platformPlayBackEventStream): Add __bridge to a bridging
577         typecast.
578
579         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm: Add a missing include.
580
581         * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm:
582         (-[LocalPasteboard setPropertyList:forType:]): Add _bridge to a bridging typecast.
583         (-[LocalPasteboard setString:forType:]): Ditto.
584
585         * WebKitTestRunner/mac/main.mm:
586         (main): Use @autoreleasepool instead of NSAutoreleasePool.
587
588 2018-06-02  Keith Miller  <keith_miller@apple.com>
589
590         run-jsc should pass the option to use dollar vm by default
591         https://bugs.webkit.org/show_bug.cgi?id=186170
592
593         Reviewed by Yusuke Suzuki.
594
595         * Scripts/run-jsc:
596
597 2018-06-02  Commit Queue  <commit-queue@webkit.org>
598
599         Unreviewed, rolling out r232421.
600         https://bugs.webkit.org/show_bug.cgi?id=186240
601
602         Breaks webkitpy tests (Requested by aakashjain on #webkit).
603
604         Reverted changeset:
605
606         "Add some tests for lldb_webkit.py"
607         https://bugs.webkit.org/show_bug.cgi?id=183744
608         https://trac.webkit.org/changeset/232421
609
610 2018-06-01  Daniel Bates  <dabates@apple.com>
611
612         Add some tests for lldb_webkit.py
613         https://bugs.webkit.org/show_bug.cgi?id=183744
614
615         Reviewed by Alexey Proskuryakov.
616
617         Adds some tests to ensure we do not regress LLDB pretty-printing of WTF::StringImpl
618         and WTF::String objects.
619
620         The tests make use of the LLDB Python API (lldb.py) and a simple debug-built test
621         program, lldbWebKitTester, to run. For now, we only support building lldbWebKitTester
622         on Mac.
623
624         * Makefile: Build the simple test tool lldbWebKitTester on Mac.
625         * Scripts/build-lldbwebkittester: Added.
626         (buildProjectOrDie):
627         * Scripts/dump-class-layout: Extract logic to compute the path to the LLDB Python module
628         from here to Scripts/webkitpy/common/system/systemhost.py so that it can used by both
629         this script and lldb/lldb_webkit_unittest.py. Also import the lldb module at the top of
630         the file and take advantage of Python's default error semantics to throw an exception
631         if the import fails instead of handling it ourself. This has the side effect that we
632         now always import the LLDB Python module even if this script is invoked with --help.
633         If this turns out to be a significant annoyance then we can look to dynamically import
634         the module as we did before this change.
635         (webkit_build_dir):
636         (main):
637         (developer_dir): Deleted.
638         (import_lldb): Deleted.
639         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Update FIXME comment to reflect
640         that fact that test-webkitpy does not support class and module fixtures. This is because
641         test-webkitpy currently implements parallelism by breaking down existing test classes
642         into individual test methods itself and having each worker run exactly one test method (via
643         unittest.TestLoader.loadTestsFromName()) at a time. As a result of this reorganization,
644         setUpModule()/setUpClass() are called for each test method as opposed to once per test
645         class/test module.
646         (remove_dir): Ditto.
647         * Scripts/webkitpy/common/system/systemhost.py:
648         (SystemHost):
649         (SystemHost.path_to_lldb_python_directory): Added.
650         * Scripts/webkitpy/test/main.py:
651         (_find_lldb_webkit_tester): Returns whether there exists a Debug or Release-built lldbWebKitTester.
652         (_build_lldb_webkit_tester): Builds lldbWebKitTester. For now, we only support building
653         lldbWebKitTester on Mac.
654         (main): Add Tools/lldb to the test search path if the platform has lldb.py.
655         (Tester.run): Pass a boolean as to whether we will run the lldb_webkit unit tests.
656         (Tester._run_tests): Modified to take a boolean as to whether to run the lldb_webkit unit tests.
657         If we will run these tests then build lldbWebKitTester if it has not already been built as the
658         unit tests depend on this program.
659         * lldb/lldbWebKitTester/Configurations/Base.xcconfig: Added.
660         * lldb/lldbWebKitTester/Configurations/DebugRelease.xcconfig: Added.
661         * lldb/lldbWebKitTester/Configurations/lldbWebKitTester.xcconfig: Added.
662         * lldb/lldbWebKitTester/Makefile: Added.
663         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj: Added.
664         * lldb/lldbWebKitTester/main.cpp: Added.
665         (breakForTestingSummaryProviders):
666         (utf16String):
667         (testSummaryProviders):
668         (main):
669         * lldb/lldb_webkit_unittest.py: Added.
670         (destroy_cached_debug_session):
671         (LLDBDebugSession):
672         (LLDBDebugSession.setup):
673         (LLDBDebugSession.tearDown):
674         (TestSummaryProviders):
675         (TestSummaryProviders.setUpClass):
676         (TestSummaryProviders._sbFrame):
677         (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_null_string):
678         (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_empty_string):
679         (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_8bit_string):
680         (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_16bit_string):
681         (TestSummaryProviders.serial_test_WTFString_SummaryProvider_null_string):
682         (TestSummaryProviders.serial_test_WTFString_SummaryProvider_empty_string):
683         (TestSummaryProviders.serial_test_WTFString_SummaryProvider_8bit_string):
684         (TestSummaryProviders.serial_test_WTFString_SummaryProvider_16bit_string):
685
686 2018-06-01  Frederic Wang  <fwang@igalia.com>
687
688         export-w3c-test-changes cannot apply patches when some w3c-import.log files are changed
689         https://bugs.webkit.org/show_bug.cgi?id=186133
690
691         Reviewed by Youenn Fablet.
692
693         * Scripts/webkitpy/w3c/test_exporter.py: Exclude w3c-import.log from the diff.
694         * Scripts/webkitpy/w3c/test_exporter_unittest.py: Add unit test.
695
696 2018-05-31  Frederic Wang  <fwang@igalia.com>
697
698         export-w3c-test-changes should use the new location & name of the WPT repo
699         https://bugs.webkit.org/show_bug.cgi?id=186135
700
701         Reviewed by Youenn Fablet.
702
703         Web platform tests have been moved to GitHub's web-platform-tests/wpt. This patch updates the
704         corresponding variables to use the new organization and repository name. It also refactors a
705         bit the code to reduce the amount of hardcoded strings.
706
707         * Scripts/webkitpy/w3c/common.py: Use org web-platform-tests, repo name wpt. Also removes the
708         final slash to WPT_GH_URL, so it can be used for repo URL too.
709         * Scripts/webkitpy/w3c/test_exporter.py: Import more symbols and define WPT_PR_URL from
710         WPT_GH_URL.
711         (WebPlatformTestExporter._wpt_fork_branch_github_url): Use WPT_GH_REPO_NAME.
712         (WebPlatformTestExporter._wpt_fork_push_url): Use WPT_GH_REPO_NAME.
713         (WebPlatformTestExporter._git): Use  WPT_GH_URL.
714         (WebPlatformTestExporter._ensure_username_and_token): Use WPT_GH_ORG, WPT_GH_REPO_NAME.
715         (WebPlatformTestExporter.make_pull_request): Use WPT_GH_ORG, WPT_GH_REPO_NAME.
716         (parse_args): Use WPT_GH_REPO_NAME, WPT_GH_URL.
717         * Scripts/webkitpy/w3c/test_exporter_unittest.py:
718         (TestExporterTest.test_export): Update organization and repository names for the remote
719         branch and pull request.
720         (TestExporterTest.test_export_with_specific_branch): Update repository name.
721
722 2018-05-31  Ryan Haddad  <ryanhaddad@apple.com>
723
724         Update expected results for BuildStepsConstructorTest
725         https://bugs.webkit.org/show_bug.cgi?id=186119
726
727         Reviewed by Alex Christensen.
728
729         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Add missing entries for 'WinCairo 64-bit' bots.
730
731 2018-05-31  Sihui Liu  <sihui_liu@apple.com>
732
733         [iOS] TestWebKitAPI.WebKit.WKHTTPCookieStoreWithoutProcessPool fails because cookies use different files with/without processpool
734         https://bugs.webkit.org/show_bug.cgi?id=185831
735         <rdar://problem/40468716>
736
737         Reviewed by David Kilzer.
738
739         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
740         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
741         (TEST):
742
743 2018-05-31  Chris Dumez  <cdumez@apple.com>
744
745         [iOS] API test ScrollViewInsetTests.InnerHeightWithLargeTopContentInset is a flaky failure
746         https://bugs.webkit.org/show_bug.cgi?id=184893
747         <rdar://problem/39747271>
748
749         Reviewed by Wenson Hsieh.
750
751         Update test to wait until the view is the expected height instead of
752         calling waitForNextPresentationUpdate once and expect the view to
753         have the right height. This fixes the flakiness.
754
755         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
756         (TestWebKitAPI::waitUntilInnerHeightIs):
757         (TestWebKitAPI::TEST):
758
759 2018-05-31  Leo Balter  <leonardo.balter@gmail.com>
760
761         test262-runner should run in verbose mode in automation
762         https://bugs.webkit.org/show_bug.cgi?id=186115
763
764         Reviewed by Yusuke Suzuki.
765
766         This patch toggles the verbose mode in the build bot and reports every test file
767         in order to avoid the '1200 seconds without output' issue.
768         * BuildSlaveSupport/build.webkit.org-config/steps.py:
769         (RunTest262Tests):
770         * Scripts/test262/Runner.pm:
771         (processResult):
772
773 2018-05-30  Fujii Hironori  <Hironori.Fujii@sony.com>
774
775         [Win][MiniBrowser] Move MainWindow related code from Common.cpp to MainWindow.cpp
776         https://bugs.webkit.org/show_bug.cgi?id=186079
777
778         Reviewed by Alex Christensen.
779
780         This is a sub task of Bug 184770.
781
782         This change is partial. I'm going to remove global variables
783         gMainWindow and gMiniBrowser and convert more functions to
784         MainWindow's methods in follow-up patches.
785
786         * MiniBrowser/win/CMakeLists.txt: Added Common.cpp
787         * MiniBrowser/win/Common.cpp:
788         (menuItemIsChecked): Moved to MainWindow.cpp.
789         (turnOffOtherUserAgents): Ditto.
790         (EditProc): Ditto.
791         (BackButtonProc): Ditto.
792         (ForwardButtonProc): Ditto.
793         (About): Ditto.
794         (Caches): Ditto.
795         (CustomUserAgent): Ditto.
796         (AuthDialogProc): Ditto.
797         (DisplayAuthDialog): Converted to MainWindow's method.
798         (ToggleMenuItem): Ditto.
799         (loadURL): Ditto.
800         * MiniBrowser/win/Common.h:
801         * MiniBrowser/win/MainWindow.cpp:
802         (MainWindow::init): Call SetFocus at the end of the construction.
803         (MainWindow::WndProc):
804         (menuItemIsChecked): Moved from Common.cpp.
805         (turnOffOtherUserAgents): Ditto.
806         (EditProc): Ditto.
807         (BackButtonProc): Ditto.
808         (ForwardButtonProc): Ditto.
809         (About): Ditto.
810         (Caches): Ditto.
811         (CustomUserAgent): Ditto.
812         (authDialogProc): Ditto.
813         (MainWindow::displayAuthDialog): Converted from a function of Common.cpp.
814         (MainWindow::toggleMenuItem): Ditto.
815         (MainWindow::loadURL): Ditto.
816         * MiniBrowser/win/MainWindow.h: Added method declarations.
817         * MiniBrowser/win/MiniBrowser.h: Added pragma once.
818         * MiniBrowser/win/WinMain.cpp:
819         (wWinMain): Include Common.h instead of Common.cpp.
820
821 2018-05-30  Brady Eidson  <beidson@apple.com>
822
823         REGRESSION (r224684): User-agent seen by page does not change when modified by the develop menu options after reloading.
824         <rdar://problem/34918109> and https://bugs.webkit.org/show_bug.cgi?id=186111
825
826         Reviewed by Andy Estes.
827
828         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
829         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
830         (WTR::TestRunner::setCustomUserAgent):
831         * WebKitTestRunner/InjectedBundle/TestRunner.h:
832         * WebKitTestRunner/TestController.cpp:
833         (WTR::TestController::resetStateToConsistentValues):
834         * WebKitTestRunner/TestInvocation.cpp:
835         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
836
837 2018-05-30  Youenn Fablet  <youenn@apple.com>
838
839         Rename CrossOriginResourcePolicy same to same-origin
840         https://bugs.webkit.org/show_bug.cgi?id=186080
841
842         Reviewed by Chris Dumez.
843
844         * TestWebKitAPI/Tests/WebCore/HTTPParsers.cpp:
845         (TestWebKitAPI::TEST):
846
847 2018-05-30  Ms2ger  <Ms2ger@igalia.com>
848
849         [GTK] Unreviewed test gardening
850         https://bugs.webkit.org/show_bug.cgi?id=186098
851
852         Unreviewed gardening.
853
854         * TestWebKitAPI/glib/TestExpectations.json: update expectations.
855
856 2018-05-29  Youenn Fablet  <youenn@apple.com>
857
858         Add a consistency check between URL and CFURL
859         https://bugs.webkit.org/show_bug.cgi?id=182444
860         <rdar://problem/37164835>
861
862         Reviewed by Geoff Garen.
863
864         DRT code expected a non null URL which is no longer the case now.
865         Updated DRT to remove that assumption.
866
867         * DumpRenderTree/TestRunner.cpp:
868         (TestRunner::redirectionDestinationForURL):
869         * DumpRenderTree/TestRunner.h:
870         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
871         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
872
873 2018-05-29  Brendan McLoughlin  <brendan@bocoup.com>
874
875         Export changes to web-platform-test as part of the webkit-patch upload workflow
876         https://bugs.webkit.org/show_bug.cgi?id=184914
877
878         Reviewed by Youenn Fablet.
879
880         * Scripts/webkitpy/tool/commands/upload.py:
881         (Upload):
882         (CreateBug.execute):
883         (WPTChangeExport):
884         * Scripts/webkitpy/tool/steps/__init__.py:
885         * Scripts/webkitpy/tool/steps/wptchangeexport.py: Added.
886         (WPTChangeExport):
887         (WPTChangeExport.options):
888         (WPTChangeExport.run):
889         * Scripts/webkitpy/w3c/common.py:
890         * Scripts/webkitpy/w3c/test_exporter.py:
891         (WebPlatformTestExporter):
892         (WebPlatformTestExporter.__init__):
893         (WebPlatformTestExporter.username):
894         (WebPlatformTestExporter.token):
895         (WebPlatformTestExporter._github):
896         (WebPlatformTestExporter._wpt_fork_branch_github_url):
897         (WebPlatformTestExporter._wpt_fork_remote):
898         (WebPlatformTestExporter._wpt_fork_push_url):
899         (WebPlatformTestExporter._git):
900         (WebPlatformTestExporter._branch_name):
901         (WebPlatformTestExporter._public_branch_name):
902         (WebPlatformTestExporter._wpt_patch):
903         (WebPlatformTestExporter.has_wpt_changes):
904         (WebPlatformTestExporter._find_filename):
905         (WebPlatformTestExporter._is_ignored_file):
906         (WebPlatformTestExporter._strip_ignored_files_from_diff):
907         (WebPlatformTestExporter.write_git_patch_file):
908         (WebPlatformTestExporter._prompt_for_token):
909         (WebPlatformTestExporter._prompt_for_username):
910         (WebPlatformTestExporter._ensure_username_and_token):
911         (WebPlatformTestExporter._validate_and_save_token):
912         (WebPlatformTestExporter.create_branch_with_patch):
913         (WebPlatformTestExporter.push_to_wpt_fork):
914         (WebPlatformTestExporter.make_pull_request):
915         (WebPlatformTestExporter.delete_local_branch):
916         (WebPlatformTestExporter.create_upload_remote_if_needed):
917         (WebPlatformTestExporter.do_export):
918         (parse_args):
919         (TestExporter): Deleted.
920         (TestExporter.__init__): Deleted.
921         (TestExporter._ensure_wpt_repository): Deleted.
922         (TestExporter._fetch_wpt_repository): Deleted.
923         (TestExporter._ensure_new_branch_name): Deleted.
924         (TestExporter.download_and_commit_patch): Deleted.
925         (TestExporter.clean): Deleted.
926         (TestExporter.create_branch_with_patch): Deleted.
927         (TestExporter.push_to_wpt_fork): Deleted.
928         (TestExporter.make_pull_request): Deleted.
929         (TestExporter.create_wpt_pull_request): Deleted.
930         (TestExporter.delete_local_branch): Deleted.
931         (TestExporter.create_git_patch): Deleted.
932         (TestExporter.create_upload_remote): Deleted.
933         (TestExporter.do_export): Deleted.
934         * Scripts/webkitpy/w3c/test_exporter_unittest.py:
935         (TestExporterTest.MockGit):
936         (TestExporterTest.MockGit.create_patch):
937         (TestExporterTest.test_export):
938         (TestExporterTest.test_export_with_specific_branch):
939         (TestExporterTest):
940         (TestExporterTest.test_export_interactive_mode):
941         (TestExporterTest.test_export_invalid_token):
942         (TestExporterTest.test_export_wrong_token):
943         (TestExporterTest.test_has_wpt_changes):
944         (TestExporterTest.test_has_no_wpt_changes_for_no_diff):
945         (TestExporterTest.test_ignore_changes_to_expected_file):
946
947 2018-05-29  Fujii Hironori  <Hironori.Fujii@sony.com>
948
949         [Win][MiniBrowser] Move WK1 specific code from Common.cpp to MiniBrowser.cpp
950         https://bugs.webkit.org/show_bug.cgi?id=186029
951
952         Reviewed by Alex Christensen.
953
954         This is a sub task of Bug 184770.
955
956         * MiniBrowser/win/Common.cpp:
957         (ToggleMenuItem): Extracted WK1 specific code to MiniBrowser::setPreference.
958         (Caches): Call MiniBrowser::updateStatistics instead of updateStatistics.
959         (AbortProc): Moved to MiniBrowser.cpp.
960         (getPrinterDC): Ditto.
961         (initDocStruct): Ditto.
962         (PrintView): Ditto.
963         (ToggleMenuFlag): Ditto.
964         (setWindowText): Ditto.
965         (updateStatistics): Ditto.
966         * MiniBrowser/win/MainWindow.cpp:
967         (MainWindow::WndProc): Call MiniBrowser::print instead of PrintView.
968         * MiniBrowser/win/MiniBrowser.cpp:
969         (AbortProc): Moved from Common.cpp.
970         (getPrinterDC): Moved from Common.cpp.
971         (initDocStruct): Moved from Common.cpp.
972         (setWindowText): Moved from Common.cpp.
973         (MiniBrowser::print): Renamed from PrintView of Common.cpp.
974         (MiniBrowser::updateStatistics): Renamed from updateStatistics of Common.cpp.
975         (MiniBrowser::setPreference): Extracted from ToggleMenuItem of Common.cpp.
976         * MiniBrowser/win/MiniBrowser.h: Add method declarations.
977         * MiniBrowser/win/MiniBrowserWebHost.cpp: Removed duplicated IWebFramePtr typedef.
978
979 2018-05-29  Saam Barati  <sbarati@apple.com>
980
981         JSC should put bmalloc's scavenger into mini mode
982         https://bugs.webkit.org/show_bug.cgi?id=185988
983
984         Reviewed by Michael Saboff.
985
986         This patch makes it so that we turn off the JIT when running run-testmem
987         that way we make JSC use its mini mode.
988
989         * Scripts/run-testmem:
990
991 2018-05-29  Sihui Liu  <sihui_liu@apple.com>
992
993         Unable to remove IndexedDB Databases with Cocoa API removeDataOfTypes
994         https://bugs.webkit.org/show_bug.cgi?id=185835
995         <rdar://problem/39142257>
996
997         Reviewed by Chris Dumez.
998
999         Add API test coverage.
1000
1001         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
1002         (TEST):
1003
1004 2018-05-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1005
1006         [Extra zoom mode] "Significant area painted" rendering progress event is rarely fired
1007         https://bugs.webkit.org/show_bug.cgi?id=186042
1008         <rdar://problem/40604182>
1009
1010         Reviewed by Tim Horton.
1011
1012         Adds a new API test to check that the "significant area painting" rendering milestone is dispatched when a
1013         significant portion of the page has been painted before document load is finished.
1014
1015         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1016         * TestWebKitAPI/Tests/WebKitCocoa/paint-significant-area-milestone.html: Added.
1017         * TestWebKitAPI/Tests/ios/RenderingProgressTests.mm: Added.
1018         (-[MissingResourceSchemeHandler webView:stopURLSchemeTask:]):
1019         (-[MissingResourceSchemeHandler webView:startURLSchemeTask:]):
1020         (-[RenderingProgressHandler initWithHandler:]):
1021         (-[RenderingProgressHandler _webView:renderingProgressDidChange:]):
1022         (TEST):
1023
1024 2018-05-29  Thibault Saunier  <tsaunier@igalia.com>
1025
1026         [GStreamer] Update "qtdemux: Clarify field name about stream-encryption-system" patch
1027         https://bugs.webkit.org/show_bug.cgi?id=186040
1028
1029         The patch we merge contained a type and was merged in upstream GStreamer fixing that
1030         (s/avalaible/available/).
1031
1032         Reviewed by Xabier Rodriguez-Calvar.
1033
1034         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch:
1035
1036 2018-05-28  Sihui Liu  <sihui_liu@apple.com>
1037
1038         Add an API test to check process privilege when using Cookie API
1039         https://bugs.webkit.org/show_bug.cgi?id=185406
1040
1041         Reviewed by Geoffrey Garen.
1042
1043         Add API test coverage.
1044
1045         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1046         (TEST):
1047
1048 2018-05-28  Thibault Saunier  <tsaunier@igalia.com>
1049
1050         [GStreamer] Handle changes in the "drm-preferred-decryption-system-id" NEED_CONTEXT message.
1051         https://bugs.webkit.org/show_bug.cgi?id=185948
1052
1053         Reviewed by Xabier Rodriguez-Calvar.
1054
1055         When the patch introducing gst_protection_filter_systems_by_available_decryptors was merged, we changed sensibly its behaviour
1056         concerning the way empty results is represented (now returning NULL instead of an array of 1(NULL) element) and this change was not
1057         properly taken into account in the qtdemux patch that uses it and got upstreamed. Those 3 new patches fixe that and change the
1058         NEED_CONTEXT field names to clarify the meaning of "stream-encryption-systems".
1059
1060         * gstreamer/jhbuild.modules:
1061         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Added. Merged upstream as 3e063703b3a51b8aaa7f75f36c4660c583a60e93
1062         * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Added. Merged upstream as 43a540b1cd9f162d3dae5d50e36703dfaf558a3e
1063         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Added.
1064
1065 2018-05-27  Dan Bernstein  <mitz@apple.com>
1066
1067         Reverted the changes made for https://webkit.org/b/186016
1068
1069         They broke the USE(APPLE_INTERNAL_SDK) Sierra build.
1070
1071 2018-05-27  Dan Bernstein  <mitz@apple.com>
1072
1073         [Cocoa] Avoid importing directly from subumbrella frameworks
1074         https://bugs.webkit.org/show_bug.cgi?id=186016
1075
1076         Reviewed by Sam Weinig.
1077
1078         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
1079           LaunchServices header.
1080         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1081           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1082         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
1083           when using SDKs earlier than 10.13.
1084         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
1085           and OTHER_CPLUSPLUSFLAGS.
1086         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm: Import Carbon.h instead of an
1087           HIToolbox header.
1088         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1089           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1090         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
1091           LaunchServices header.
1092
1093 2018-05-27  Fujii Hironori  <Hironori.Fujii@sony.com>
1094
1095         [Win][MiniBrowser] Add MainWindow class
1096         https://bugs.webkit.org/show_bug.cgi?id=185814
1097
1098         Reviewed by Per Arne Vollan.
1099
1100         This is a sub task of Bug 184770. Added a new class MainWindow to
1101         represent the main window which will be shared among WK1 and WK2.
1102
1103         This change is partial so that it's easy to review this patch.
1104         I'll move more functions into MainWindow.cpp, and remove more
1105         global variables in forthcoming patches.
1106
1107         * MiniBrowser/win/CMakeLists.txt: Added MainWindow.cpp.
1108         * MiniBrowser/win/Common.cpp: Removed MainWindow related global
1109         variables hMainWnd, hURLBarWnd, hBackButtonWnd and
1110         hForwardButtonWnd. Added a new global variable gMainWindow.
1111         (WndProc): Moved to MainWindow.cpp.
1112         (resizeSubViews): Ditto.
1113         (ToggleMenuFlag): Removed static to be called from MainWindow.cpp.
1114         (ToggleMenuItem): Ditto.
1115         (CustomUserAgent): Follow the global variables removal.
1116         (DisplayAuthDialog): Ditto.
1117         (loadURL): Ditto.
1118         (WndProc): Renamed to MainWindow::WndProc.
1119         * MiniBrowser/win/MainWindow.cpp: Added.
1120         (MainWindow::registerClass): Renamed from MyRegisterClass of WinMain.cpp.
1121         (MainWindow::init): Extracted MainWindow initialization code from wWinMain.
1122         (MainWindow::resizeSubViews): Moved from Common.cpp.
1123         (MainWindow::WndProc): Ditto.
1124         * MiniBrowser/win/MainWindow.h: Added.
1125         (MainWindow::hwnd):
1126         (MainWindow::browserWindow):
1127         * MiniBrowser/win/MiniBrowser.cpp:
1128         (MiniBrowser::init):
1129         (MiniBrowser::prepareViews): Extract some code into MiniBrowser::loadDefaultHTML.
1130         (MiniBrowser::loadDefaultHTML): Extracted from MiniBrowser::prepareViews.
1131         * MiniBrowser/win/MiniBrowser.h:
1132         * MiniBrowser/win/WinMain.cpp:
1133         (wWinMain): Extracted MainWindow initialization code into MainWindow::init.
1134         (MyRegisterClass): Moved to MainWindow.cpp.
1135
1136 2018-05-27  Fujii Hironori  <Hironori.Fujii@sony.com>
1137
1138         [Win][MiniBrowser] Remove URL argument of MiniBrowser::init
1139         https://bugs.webkit.org/show_bug.cgi?id=185969
1140
1141         Reviewed by Alex Christensen.
1142
1143         MiniBrowser::init takes URL argument, but it's used only for
1144         loading default HTML if URL is not given.
1145
1146         - Add a new method MiniBrowser::loadHTMLString
1147         - Remove loadHTMLString process from MiniBrowser::prepareViews
1148
1149         * MiniBrowser/win/MiniBrowser.cpp:
1150         (MiniBrowser::init): Removed `requestedURL` argument.
1151         (MiniBrowser::prepareViews): Ditto.
1152         (MiniBrowser::loadHTMLString): New.
1153         (MiniBrowser::loadURL): Return E_INVALIDARG if passedURL is null instead of calling loadHTMLString.
1154         * MiniBrowser/win/MiniBrowser.h: Removed URL argument. Added loadHTMLString.
1155         * MiniBrowser/win/WinMain.cpp:
1156         (wWinMain): Call MiniBrowser::loadHTMLString if URL is not given.
1157
1158 2018-05-27  David Kilzer  <ddkilzer@apple.com>
1159
1160         svn-apply fails when a patch has an empty file
1161         <https://webkit.org/b/29684>
1162
1163         Reviewed by Daniel Bates.
1164
1165         Prior to this change, applying the following patches resulted in:
1166         - svn: add empty file     (failure)
1167         - svn: delete empty file  (failure)
1168         - svn: rename empty file  (failure)
1169         - git: add empty file     (false-positive success)
1170         - git: delete empty file  (success)
1171         - git: rename empty file  (failure)
1172
1173         * Scripts/VCSUtils.pm:
1174         (parseSvnDiffHeader): Handle the case when there is no patch
1175         following the header.  If the file exists and is empty, that
1176         means it's a deletion.  If the file does not exist, that means
1177         it's an addition. Everything else is a fatal error.
1178         * Scripts/svn-apply:
1179         (patch):
1180         - Only apply a patch for deletion if it has one or more text
1181           chunks.
1182         - Add a case to handle adding an empty file (an addition with no
1183           text chunks), and verify the file doesn't exist yet.
1184         - Any unhandled patch is a fatal error.
1185         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
1186         Add tests for adding an empty file and deleting an empty file.
1187         * Scripts/webkitperl/VCSUtils_unittest/resources/empty.txt: Add.
1188         Used by parseSvnDiffHeader.pl unit test for "add an empty file"
1189         test case.
1190
1191 2018-05-25  Aakash Jain  <aakash_jain@apple.com>
1192
1193         Display detailed error logs when a script fails in EWS
1194         https://bugs.webkit.org/show_bug.cgi?id=175696
1195         <rdar://problem/34841885>
1196
1197         Reviewed by Darin Adler.
1198
1199         * Scripts/webkitpy/tool/bot/queueengine.py: Set output_limit to 5000 characters instead of default 500 characters.
1200         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py: Ditto.
1201         * Scripts/webkitpy/tool/commands/download.py: Ditto.
1202         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: Ditto.
1203         * Scripts/webkitpy/tool/commands/queues.py: Ditto.
1204         * Scripts/webkitpy/tool/commands/stepsequence.py: Ditto.
1205
1206 2018-05-25  Daniel Bates  <dabates@apple.com>
1207
1208         test-webkitpy messages logged using __main__ logger are not displayed
1209         https://bugs.webkit.org/show_bug.cgi?id=185823
1210
1211         Rubber-stamped by Aakash Jain.
1212
1213         Configure the logger for __main__ so that messages that are logged before it parses its
1214         command line arguments are printed to standard error.
1215
1216         Currently test-webkitpy creates a named logger (__main__) for its logging. However it does
1217         not configure a stream to use for printing until after it parses its command line arguments
1218         via webkitpy.test.printer.Printer.configure(). Messages logged until then are never written
1219         to the console. We explicitly configure the __main__ logger instead of calling webkitpy.test.printer.Printer.configure()
1220         earlier because the latter both configures a stream and filters logged messages based on
1221         the specified verbosity. Logged messaged from code in __main__ should not be subject to
1222         such filtering. So, we explicitly configure the __main__ logger.
1223
1224         * Scripts/webkitpy/test/main.py:
1225         (main):
1226
1227 2018-05-25  Saam Barati  <sbarati@apple.com>
1228
1229         Make JSC have a mini mode that kicks in when the JIT is disabled
1230         https://bugs.webkit.org/show_bug.cgi?id=185931
1231
1232         Reviewed by Mark Lam.
1233
1234         This renames a variable for clarity.
1235
1236         * Scripts/run-testmem:
1237
1238 2018-05-25  Alex Christensen  <achristensen@webkit.org>
1239
1240         URL::host should return a StringView to reduce allocations
1241         https://bugs.webkit.org/show_bug.cgi?id=185986
1242
1243         Reviewed by Geoff Garen.
1244
1245         * TestWebKitAPI/Tests/WebCore/URL.cpp:
1246         (TestWebKitAPI::TEST_F):
1247         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1248         (TestWebKitAPI::eq):
1249         * TestWebKitAPI/Tests/mac/SSLKeyGenerator.mm:
1250         (TestWebKitAPI::SSLKeyGeneratorTest::TearDown):
1251
1252 2018-05-25  Ms2ger  <Ms2ger@igalia.com>
1253
1254         Minor improvements to wpt exporter.
1255         https://bugs.webkit.org/show_bug.cgi?id=185978
1256
1257         Reviewed by Youenn Fablet.
1258
1259         * Scripts/webkitpy/w3c/test_exporter.py:
1260         (TestExporter.push_to_wpt_fork): Update call to create_upload_remote().
1261         (TestExporter.make_pull_request): Improve the description of the created PR.
1262         (TestExporter.create_upload_remote): Always update the remote to override any obsolete state.
1263
1264 2018-05-25  Saam Barati  <sbarati@apple.com>
1265
1266         Have a memory test where we can validate JSCs mini memory mode
1267         https://bugs.webkit.org/show_bug.cgi?id=185932
1268
1269         Reviewed by Mark Lam.
1270
1271         This patch adds the run-testmem script. This runs the new testmem
1272         CLI against the contents in the testmem benchmark. The contents of testmem
1273         contain tests from ARES-6, Sunspider, Octane, and JetStream.
1274         
1275         One iteration of the benchmark comprises of running each testmem test for
1276         a certain number of iterations. We collect the peak memory usage, the memory
1277         usage after running all the iterations, and the time it takes to run all the
1278         iterations. We then run the entire benchmark 3 times over. For each test, we
1279         compute the arithmetic mean over each iteration for time, peak memory, and
1280         end memory. The benchmark then computes a time score and memory score.
1281         
1282         peak memory score = geomean({peak memory of each individual test})
1283         end memory score = geomean({end memory of each individual test})
1284         memory score = geomean({peak memory score, end memory score})
1285         time score = geomean({time score of each individual test})
1286         
1287         We want the memory score to weigh improvements to peak memory usage and
1288         memory usage at the end equally.
1289         
1290         We plan to tune this benchmark in JSC's mini mode by improving the memory
1291         score while ensuring the time score is not more than 10-15% regressed.
1292
1293         * Scripts/run-testmem: Added.
1294
1295 2018-05-25  Sihui Liu  <sihui_liu@apple.com>
1296
1297         [WKHTTPCookieStore getAllCookies] returns inconsistent creation time
1298         https://bugs.webkit.org/show_bug.cgi?id=185041
1299         <rdar://problem/34684214>
1300
1301         Reviewed by Geoffrey Garen.
1302
1303         Add API test coverage.
1304
1305         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1306         (TEST):
1307
1308 2018-05-24  Chris Dumez  <cdumez@apple.com>
1309
1310         Reduce copying of FontCascadeDescription objects by moving them around
1311         https://bugs.webkit.org/show_bug.cgi?id=185963
1312
1313         Reviewed by Simon Fraser.
1314
1315         Reduce copying of FontCascadeDescription objects by moving them around when possible.
1316
1317         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1318         (TestWebKitAPI::TEST_F):
1319
1320 2018-05-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1321
1322         WebDriver: implement maximize, minimize and fullscreen window commands
1323         https://bugs.webkit.org/show_bug.cgi?id=180398
1324
1325         Reviewed by Brian Burg.
1326
1327         * Scripts/webkitpy/port/xvfbdriver.py:
1328         (XvfbDriver._setup_environ_for_test): Set UNDER_XVFB environment variable when running under Xvfb.
1329
1330 2018-05-24  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1331
1332         [GStreamer] Save some time disabling some compile options in the dependencies
1333         https://bugs.webkit.org/show_bug.cgi?id=185909
1334
1335         Reviewed by Philippe Normand.
1336
1337         * gstreamer/jhbuild.modules: Added  --disable-tests to gstreamer
1338         and --disable-examples --disable-gtk-doc to gstreamer-vaapi.
1339
1340 2018-05-23  Roy Reapor  <rreapor@apple.com>
1341
1342         Use Helvetica on build.webkit.org webpages
1343         https://bugs.webkit.org/show_bug.cgi?id=185894
1344
1345         Reviewed by Aakash Jain.
1346
1347         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1348         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
1349         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html:
1350
1351 2018-05-23  Aakash Jain  <aakash_jain@apple.com>
1352
1353         Add Buildbot configuration for Opensource EWS
1354         https://bugs.webkit.org/show_bug.cgi?id=185484
1355
1356         Rubber-stamped by Alexey Proskuryakov.
1357
1358         * BuildSlaveSupport/ews-build/config.json: Added, config file.
1359         * BuildSlaveSupport/ews-build/factories.py: Added, basic template for factories.
1360         * BuildSlaveSupport/ews-build/loadConfig.py: Added.
1361         (loadBuilderConfig): Loads the configuration.
1362         (checkValidWorker): Checks if the worker is valid.
1363         (checkValidBuilder): Checks if the builder is valid.
1364         (checkWorkersAndBuildersForConsistency): Check if workers and builders are consistent.
1365         (checkWorkersAndBuildersForConsistency._find_worker_with_name):
1366         (getBlackListedTags): Returns a list of keywords which should not be listed as tags.
1367         (getValidTags): Returns a list of valid tags.
1368         (getTagsForBuilder): Return a list of tags for given builder.
1369         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: unit-tests for loadConfig.py.
1370         * BuildSlaveSupport/ews-build/master.cfg: Configuration for buildbot.
1371
1372 2018-05-23  Michael Catanzaro  <mcatanzaro@igalia.com>
1373
1374         [GTK] Silence GCC 8 warnings
1375         https://bugs.webkit.org/show_bug.cgi?id=185556
1376
1377         Reviewed by Žan Doberšek.
1378
1379         GCC is complaining about this strncpy. It's guaranteed to be safe, because the length of
1380         source and destination are always identical. But switching to snprintf avoids the warning.
1381
1382         * DumpRenderTree/TestNetscapePlugIn/Tests/FormValue.cpp:
1383         (FormValue::NPP_GetValue):
1384
1385 2018-05-23  Ryan Haddad  <ryanhaddad@apple.com>
1386
1387         Unreviewed, rolling out r232112.
1388
1389         The tests added with this change  are failing on the bots.
1390
1391         Reverted changeset:
1392
1393         "test262/Runner.pm: add unit tests"
1394         https://bugs.webkit.org/show_bug.cgi?id=185783
1395         https://trac.webkit.org/changeset/232112
1396
1397 2018-05-23  Valerie R Young  <valerie@bocoup.com>
1398
1399         test262/Runner.pm: add unit tests
1400         https://bugs.webkit.org/show_bug.cgi?id=185783
1401
1402         Reviewed by Aakash Jain.
1403
1404         Add unit tests to be run by test-webkitperl
1405
1406         * Scripts/test262/Runner.pm:
1407         (main):
1408          - If harness files cannot be found in a custom, supplies test262 path,
1409            then sure the webkit test262 harness files.
1410          - Lazily create the test262-results directory.
1411          - If an expectation file is supplied via command line, save to the
1412            supplied location instead of the detault webkit location.
1413         (compileTest):
1414         (processResult):
1415         (getHarness):
1416         * Scripts/webkitperl/test262_unittest/README: Added.
1417         * Scripts/webkitperl/test262_unittest/fixtures/expectations-compare.yaml: Added.
1418         * Scripts/webkitperl/test262_unittest/fixtures/expectations.yaml: Added.
1419         * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-fail-now-failing-with-new-error.js: Added.
1420         * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-fail-now-failing.js: Added.
1421         * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-fail-now-passing.js: Added.
1422         (f):
1423         * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-pass-now-failing.js: Added.
1424         * Scripts/webkitperl/test262_unittest/fixtures/test/fail.js: Added.
1425         * Scripts/webkitperl/test262_unittest/fixtures/test/pass.js: Added.
1426         (f):
1427         * Scripts/webkitperl/test262_unittest/test262-runner-tests.pl: Added.
1428
1429 2018-05-22  Roy Reapor  <rreapor@apple.com>
1430
1431         Test infrastructure websites should use jQuery and jQuery UI hosted on webkit.org
1432         https://bugs.webkit.org/show_bug.cgi?id=185788
1433
1434         Reviewed by Aakash Jain.
1435
1436         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1437         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
1438         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html:
1439         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
1440         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html:
1441         * TestResultServer/static-dashboards/run-embedded-unittests.html:
1442         * TestResultServer/static-dashboards/run-unittests.html:
1443
1444 2018-05-22  Sihui Liu  <sihui_liu@apple.com>
1445
1446         [iOS] TestWebKitAPI.WebKit.WKHTTPCookieStoreWithoutProcessPool is crashing with reason: 'Completion handler passed to -[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:] was not called'
1447         https://bugs.webkit.org/show_bug.cgi?id=185831
1448
1449         Reviewed by Chris Dumez.
1450
1451         Updated the test to prevent crash after assertion fails.
1452
1453         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1454         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1455
1456 2018-05-22  Chris Dumez  <cdumez@apple.com>
1457
1458         Regression(AsyncPolicyDelegates): Box.app login Window is blank
1459         https://bugs.webkit.org/show_bug.cgi?id=185832
1460         <rdar://problem/40307871>
1461
1462         Reviewed by Geoffrey Garen.
1463
1464         Add API test coverage.
1465
1466         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1467         * TestWebKitAPI/Tests/WebKit/cocoa/WeakObjCPtr.mm:
1468         * TestWebKitAPI/Tests/mac/NoPolicyDelegateResponse.mm: Added.
1469         (-[NoPolicyDelegateDecisionDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
1470         (-[NoPolicyDelegateDecisionDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
1471         (-[NoPolicyDelegateDecisionDelegate webView:didFinishLoadForFrame:]):
1472         (TestWebKitAPI::TEST):
1473         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1474         (-[WKWebView _isBackground]):
1475
1476 2018-05-22  Sihui Liu  <sihui_liu@apple.com>
1477
1478         Conversion between SecurityOriginData and DatabaseIdentifier is asymmetric when port is null
1479         https://bugs.webkit.org/show_bug.cgi?id=185715
1480
1481         Reviewed by Geoffrey Garen.
1482
1483         Add API test coverage.
1484
1485         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1486         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageDatabaseTracker.mm: Added.
1487         (-[LocalStorageUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1488         (TEST):
1489
1490 2018-05-22  Sihui Liu  <sihui_liu@apple.com>
1491
1492         Unreviewed, added myself as a WebKit committer.
1493
1494         * Scripts/webkitpy/common/config/contributors.json:
1495
1496 2018-05-22  Ryan Haddad  <ryanhaddad@apple.com>
1497
1498         Unreviewed, rolling out r232052.
1499
1500         Breaks internal builds.
1501
1502         Reverted changeset:
1503
1504         "Use more C++17"
1505         https://bugs.webkit.org/show_bug.cgi?id=185176
1506         https://trac.webkit.org/changeset/232052
1507
1508 2018-05-22  Thibault Saunier  <tsaunier@igalia.com>
1509
1510         [GStreamer] Update to GStreamer 1.14.1 in jhbuild
1511         https://bugs.webkit.org/show_bug.cgi?id=185689
1512
1513         Reviewed by Philippe Normand.
1514
1515         And update the patches, removing the ones that have been merged upstream.
1516
1517         * gstreamer/jhbuild.modules:
1518         * gstreamer/patches/gst-plugins-good-0001-gstgdkpixbufdec-stop-pretending-to-decode-gifs.patch: Removed.
1519         * gstreamer/patches/gst-plugins-good-0001-souphttpsrc-cookie-jar-and-context-query-support.patch: Removed. Not needed anymore and closed as OBSELETE upstream.
1520         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gstreamer/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch
1521         This patch has now been merged in GStreamer master and will be there in GStreamer 1.16.
1522         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Renamed from Tools/gstreamer/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch.
1523         This patch has now been merged in GStreamer master and will be there in GStreamer 1.16.
1524         * gstreamer/patches/gst-plugins-good-0009-qtdemux-fix-assert-when-moof-contains-one-sample.patch: Removed.
1525         * gstreamer/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Removed.
1526
1527 2018-05-21  Yusuke Suzuki  <utatane.tea@gmail.com>
1528
1529         Use more C++17
1530         https://bugs.webkit.org/show_bug.cgi?id=185176
1531
1532         Reviewed by JF Bastien.
1533
1534         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1535         * ImageDiff/cg/Configurations/Base.xcconfig:
1536         * MiniBrowser/Configurations/Base.xcconfig:
1537         * MobileMiniBrowser/Configurations/Base.xcconfig:
1538         * TestWebKitAPI/Configurations/Base.xcconfig:
1539         * WebKitTestRunner/Configurations/Base.xcconfig:
1540
1541 2018-05-21  Fujii Hironori  <Hironori.Fujii@sony.com>
1542
1543         [WinCairo] Enable WebKit build by default
1544         https://bugs.webkit.org/show_bug.cgi?id=185141
1545
1546         Reviewed by Per Arne Vollan.
1547
1548         TestWTF, TestWebCore and TestWebKitLegacy need a dependency to
1549         WebKitForwardingHeaders because config.h includes a header of WK2.
1550
1551         * TestWebKitAPI/PlatformWin.cmake: Make TestWTFLib, TestWebCoreLib and TestWebKitLegacyLib depend on WebKitForwardingHeaders.
1552         * TestWebKitAPI/config.h: Use PLATFORM(WIN_CAIRO) instead of BUILDING_WIN_CAIRO_WEBKIT.
1553
1554 2018-05-21  Jer Noble  <jer.noble@apple.com>
1555
1556         Complete fix for enabling modern EME by default
1557         https://bugs.webkit.org/show_bug.cgi?id=185770
1558         <rdar://problem/40368220>
1559
1560         Reviewed by Eric Carlson.
1561
1562         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1563
1564 2018-05-18  Christopher Reid  <chris.reid@sony.com>
1565
1566         Unreviewed, add myself as a WebKit committer.
1567
1568         * Scripts/webkitpy/common/config/contributors.json:
1569
1570 2018-05-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1571
1572         Unreviewed, rolling out r222967.
1573
1574         It's not ready yet
1575
1576         Reverted changeset:
1577
1578         "[GTK][WPE] Add API to configure and enable resource load
1579         statistics"
1580         https://bugs.webkit.org/show_bug.cgi?id=177943
1581         https://trac.webkit.org/changeset/222967
1582
1583 2018-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1584
1585         [GTK] MiniBrowser crashes when loading twice quickly
1586         https://bugs.webkit.org/show_bug.cgi?id=185763
1587
1588         Reviewed by Michael Catanzaro.
1589
1590         This is very difficult to reproduce manually, but it happens when running WebDriver tests where loads are very
1591         fast and multiple loads are done quickly. The problem is that we use an idle to reset the progress bar, but we
1592         don't reset it when a new load starts. We always reset the last idle on destroy, but if there's another one
1593         leaked, it will crash when scheduled if the window has already been destroyed.
1594
1595         * MiniBrowser/gtk/BrowserWindow.c:
1596         (webViewLoadProgressChanged): Stop any pending reset task when progress != 1.
1597
1598 2018-05-19  Sihui Liu  <sihui_liu@apple.com>
1599
1600         Flaky API test WebKit.WKHTTPCookieStoreWithoutProcessPool: incorrect order of cookies
1601         https://bugs.webkit.org/show_bug.cgi?id=185624
1602         <rdar://problem/39111626>
1603
1604         Reviewed by Chris Dumez.
1605
1606         Modified expectation to make test more robust as cookies can be returned in different orders.
1607
1608         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1609         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1610         (TEST):
1611
1612 2018-05-18  Commit Queue  <commit-queue@webkit.org>
1613
1614         Unreviewed, rolling out r231982.
1615         https://bugs.webkit.org/show_bug.cgi?id=185793
1616
1617         Caused layout test failures (Requested by realdawei on
1618         #webkit).
1619
1620         Reverted changeset:
1621
1622         "Complete fix for enabling modern EME by default"
1623         https://bugs.webkit.org/show_bug.cgi?id=185770
1624         https://trac.webkit.org/changeset/231982
1625
1626 2018-05-18  Eric Carlson  <eric.carlson@apple.com>
1627
1628         Handle failure to extend sandbox gracefully
1629         https://bugs.webkit.org/show_bug.cgi?id=185779
1630         <rdar://problem/40316349>
1631
1632         Unreviewed, fix test results.
1633
1634         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
1635         (TEST_F):
1636
1637 2018-05-18  Jer Noble  <jer.noble@apple.com>
1638
1639         Complete fix for enabling modern EME by default
1640         https://bugs.webkit.org/show_bug.cgi?id=185770
1641         <rdar://problem/40368220>
1642
1643         Reviewed by Eric Carlson.
1644
1645         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1646
1647 2018-05-18  Eric Carlson  <eric.carlson@apple.com>
1648
1649         Handle failure to extend sandbox gracefully
1650         https://bugs.webkit.org/show_bug.cgi?id=185779
1651         <rdar://problem/40316349>
1652
1653         Reviewed by Brent Fulgham.
1654
1655         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1656         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm: Added.
1657         (-[SimulateFailedSandboxMessageHandler userContentController:didReceiveScriptMessage:]):
1658         (-[SimulateFailedSandboxUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1659         (-[SimulateFailedSandboxUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1660         (MediaCaptureSimulateFailedSandbox::SetUp):
1661         (MediaCaptureSimulateFailedSandbox::loadTestAndWaitForMessage):
1662         (TEST_F):
1663         * TestWebKitAPI/Tests/WebKitCocoa/disableGetUserMedia.html:
1664
1665 2018-05-18  Daniel Bates  <dabates@apple.com>
1666
1667         "debug-safari --ios-simulator" creates lldb target to launch Mac Safari
1668         https://bugs.webkit.org/show_bug.cgi?id=185774
1669
1670         Reviewed by Andy Estes.
1671
1672         For now, the script debug-safari is not supported for WebKit for iOS. To
1673         fix this we differentiate between the Apple Mac port and Apple embedded
1674         ports.
1675
1676         * Scripts/webkitdirs.pm:
1677         (safariPath): Substitute isAppleMacWebKit() for isAppleCocoaWebKit().
1678         (isAppleMacWebKit): Added.
1679         (isAppleCocoaWebKit): Write in terms of isAppleMacWebKit() and isEmbeddedWebKit().
1680         (launcherName): Substitute isAppleMacWebKit() for isAppleCocoaWebKit().
1681         (mobileSafariBundle): Substitute isIOSWebKit() for isAppleCocoaWebKit().
1682         (debugSafari): Substitute isAppleMacWebKit() for isAppleCocoaWebKit().
1683         (runSafari): Ditto.
1684         (runMiniBrowser): Ditto.
1685         (debugMiniBrowser): Ditto.
1686         (runWebKitTestRunner): Ditto.
1687         (debugWebKitTestRunner): Ditto.
1688
1689 2018-05-18  Antoine Quint  <graouts@apple.com>
1690
1691         [Web Animations] Turn Web Animations with CSS integration on for test runners
1692         https://bugs.webkit.org/show_bug.cgi?id=184819
1693         <rdar://problem/39597337>
1694
1695         Unreviewed. Rolling out the patch for this bug, it caused some flaky timeouts for animation suspension tests.
1696
1697         * DumpRenderTree/TestOptions.cpp:
1698         (TestOptions::TestOptions):
1699         * DumpRenderTree/TestOptions.h:
1700         * DumpRenderTree/mac/DumpRenderTree.mm:
1701         (runTest):
1702         (shouldOverrideAndDisableWebAnimationsCSSIntegrationPreference): Deleted.
1703         * WebKitTestRunner/TestController.cpp:
1704         (WTR::TestController::resetPreferencesToConsistentValues):
1705         (WTR::updateTestOptionsFromTestHeader):
1706         * WebKitTestRunner/TestOptions.cpp:
1707         (WTR::TestOptions::TestOptions):
1708         (WTR::isLegacyAnimationEngineTestPath): Deleted.
1709         * WebKitTestRunner/TestOptions.h:
1710
1711 2018-05-18  Fujii Hironori  <Hironori.Fujii@sony.com>
1712
1713         [Win][MiniBrowser] Create MainWindow even in transparent mode
1714         https://bugs.webkit.org/show_bug.cgi?id=185597
1715
1716         Reviewed by Per Arne Vollan.
1717
1718         The current implementations doesn't create the MainWindow in
1719         transparent mode. The screenshot is in Bug 58300.
1720
1721         There were three problems:
1722         - Can't control the WebView. ie. going backward and forward.
1723         - Can't quit the program.
1724         - It makes implementation complicated.
1725
1726         * MiniBrowser/win/Common.cpp (resizeSubViews): Resize sub views
1727         even in the transparent mode.
1728         * MiniBrowser/win/WinMain.cpp:
1729         (wWinMain): Create the main window even in the transparent mode.
1730
1731 2018-05-18  Antoine Quint  <graouts@apple.com>
1732
1733         [Web Animations] Turn Web Animations with CSS integration on for test runners
1734         https://bugs.webkit.org/show_bug.cgi?id=184819
1735         <rdar://problem/39597337>
1736
1737         Reviewed by Jon Lee.
1738
1739         Make the test runners turn both the main Web Animations flag and the Web Animations CSS
1740         integration flag on.
1741
1742         We also remove the ability to toggle the Web Animations CSS integration flag using an HTML
1743         comment directly at the top of the file since test runners now set the flag on by default
1744         and a dedicated directory exists for tests that need to run with this flag off.
1745
1746         * DumpRenderTree/TestOptions.cpp:
1747         (TestOptions::TestOptions):
1748         * DumpRenderTree/TestOptions.h:
1749         * DumpRenderTree/mac/DumpRenderTree.mm:
1750         (shouldOverrideAndDisableWebAnimationsCSSIntegrationPreference):
1751         (runTest):
1752         * WebKitTestRunner/TestController.cpp:
1753         (WTR::TestController::resetPreferencesToConsistentValues):
1754         (WTR::updateTestOptionsFromTestHeader):
1755         * WebKitTestRunner/TestOptions.cpp:
1756         (WTR::isLegacyAnimationEngineTestPath):
1757         (WTR::TestOptions::TestOptions):
1758         * WebKitTestRunner/TestOptions.h:
1759
1760 2018-05-17  Nan Wang  <n_wang@apple.com>
1761
1762         AX: [macOS] Expose the primary screen height through AX API
1763         https://bugs.webkit.org/show_bug.cgi?id=185742
1764
1765         Reviewed by Chris Fleizach.
1766
1767         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1768         (attributesOfElement):
1769         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1770         (WTR::attributesOfElement):
1771
1772 2018-05-17  Commit Queue  <commit-queue@webkit.org>
1773
1774         Unreviewed, rolling out r231912.
1775         https://bugs.webkit.org/show_bug.cgi?id=185750
1776
1777         It is prompting the user when there is no WPT changes
1778         (Requested by bmac on #webkit).
1779
1780         Reverted changeset:
1781
1782         "Export changes to web-platform-test as part of the webkit-
1783         patch upload workflow"
1784         https://bugs.webkit.org/show_bug.cgi?id=184914
1785         https://trac.webkit.org/changeset/231912
1786
1787 2018-05-17  Valerie R Young  <valerie@bocoup.com>
1788
1789         test262/Runner.pm: expand $INC to find webkitdirs.pm
1790         https://bugs.webkit.org/show_bug.cgi?id=185739
1791
1792         Reviewed by Michael Saboff.
1793
1794         * Scripts/test262/Runner.pm:
1795         (getBuildPath):
1796
1797 2018-05-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1798
1799         [WPE] Implement and enable FULLSCREEN_API
1800         https://bugs.webkit.org/show_bug.cgi?id=185676
1801
1802         Reviewed by Žan Doberšek.
1803
1804         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
1805         (testWebViewFullScreen):
1806
1807 2018-05-17  Brendan McLoughlin  <brendan@bocoup.com>
1808
1809         Export changes to web-platform-test as part of the webkit-patch upload workflow
1810         https://bugs.webkit.org/show_bug.cgi?id=184914
1811
1812         Reviewed by Youenn Fablet.
1813
1814         * Scripts/webkitpy/tool/commands/upload.py:
1815         (Upload):
1816         (CreateBug.execute):
1817         (WPTChangeExport):
1818         * Scripts/webkitpy/tool/steps/__init__.py:
1819         * Scripts/webkitpy/tool/steps/wptchangeexport.py: Added.
1820         (WPTChangeExport):
1821         (WPTChangeExport.options):
1822         (WPTChangeExport.run):
1823         * Scripts/webkitpy/w3c/common.py:
1824         * Scripts/webkitpy/w3c/test_exporter.py:
1825         (WebPlatformTestExporter):
1826         (WebPlatformTestExporter.__init__):
1827         (WebPlatformTestExporter.username):
1828         (WebPlatformTestExporter.token):
1829         (WebPlatformTestExporter._github):
1830         (WebPlatformTestExporter._wpt_fork_branch_github_url):
1831         (WebPlatformTestExporter._wpt_fork_remote):
1832         (WebPlatformTestExporter._wpt_fork_push_url):
1833         (WebPlatformTestExporter._git):
1834         (WebPlatformTestExporter._branch_name):
1835         (WebPlatformTestExporter._public_branch_name):
1836         (WebPlatformTestExporter.has_wpt_changes):
1837         (WebPlatformTestExporter._create_patch):
1838         (WebPlatformTestExporter.create_git_patch):
1839         (WebPlatformTestExporter._prompt_for_token):
1840         (WebPlatformTestExporter._prompt_for_username):
1841         (WebPlatformTestExporter._ensure_username_and_token):
1842         (WebPlatformTestExporter._validate_and_save_token):
1843         (WebPlatformTestExporter.push_to_wpt_fork):
1844         (WebPlatformTestExporter.make_pull_request):
1845         (WebPlatformTestExporter.delete_local_branch):
1846         (parse_args):
1847         (TestExporter): Deleted.
1848         (TestExporter.__init__): Deleted.
1849         (TestExporter._ensure_wpt_repository): Deleted.
1850         (TestExporter._fetch_wpt_repository): Deleted.
1851         (TestExporter._ensure_new_branch_name): Deleted.
1852         (TestExporter.download_and_commit_patch): Deleted.
1853         (TestExporter.clean): Deleted.
1854         (TestExporter.create_branch_with_patch): Deleted.
1855         (TestExporter.push_to_wpt_fork): Deleted.
1856         (TestExporter.make_pull_request): Deleted.
1857         (TestExporter.create_wpt_pull_request): Deleted.
1858         (TestExporter.delete_local_branch): Deleted.
1859         (TestExporter.create_git_patch): Deleted.
1860         (TestExporter.create_upload_remote_if_needed): Deleted.
1861         (TestExporter.do_export): Deleted.
1862         * Scripts/webkitpy/w3c/test_exporter_unittest.py:
1863         (TestExporterTest.test_export):
1864         (TestExporterTest.test_export_with_specific_branch):
1865         (TestExporterTest):
1866         (TestExporterTest.test_export_interactive_mode):
1867         (TestExporterTest.test_export_invalid_token):
1868         (TestExporterTest.test_export_wrong_token):
1869
1870 2018-05-17  Valerie R Young  <valerie@bocoup.com>
1871
1872         test262/Runner.pm: look for jsc in path if cannot call webkit-build-directory
1873         https://bugs.webkit.org/show_bug.cgi?id=185650
1874
1875         Reviewed by Michael Saboff.
1876
1877         First, use jsc from CLI arg, then try to use webkit-build-directory,
1878         if that doesn't work, look for jsc in the $PATH
1879
1880         * Scripts/test262/Runner.pm:
1881         (processCLI):
1882         (getBuildPath):
1883         (runTest):
1884
1885 2018-05-16  Leo Balter  <leonardo.balter@gmail.com>
1886
1887         Test262-Runner: Adds a --timeout option
1888         https://bugs.webkit.org/show_bug.cgi?id=185696
1889
1890         Reviewed by Michael Saboff.
1891
1892         The timeout option is used to set a timeout execution in ms for each test run in JSC.
1893         The passed value - if defined - will be used as the value for the JSC --watchdog arg.
1894         * Scripts/test262/Runner.pm:
1895         (processCLI):
1896         (runTest):
1897
1898 2018-05-16  Leo Balter  <leonardo.balter@gmail.com>
1899
1900         Test262-Runner: Set timer for each test run
1901         https://bugs.webkit.org/show_bug.cgi?id=185692
1902
1903         Reviewed by Michael Saboff.
1904
1905         Sets a high resolution timer for each execution call of JSC, reporting
1906         the time in the results report to allow identifying slow tests.
1907         * Scripts/test262/Runner.pm:
1908         (main):
1909         (processFile):
1910         (runTest):
1911         (processResult):
1912
1913 2018-05-16  Andy VanWagoner  <andy@vanwagoner.family>
1914
1915         Add support for Intl NumberFormat formatToParts
1916         https://bugs.webkit.org/show_bug.cgi?id=185375
1917
1918         Reviewed by Yusuke Suzuki.
1919
1920         Add flag for NumberFormat formatToParts.
1921
1922         * Scripts/webkitperl/FeatureList.pm:
1923         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1924
1925 2018-05-14  Yusuke Suzuki  <utatane.tea@gmail.com>
1926
1927         [Win] Use C++17 in MSVC
1928         https://bugs.webkit.org/show_bug.cgi?id=185232
1929
1930         Reviewed by Alex Christensen.
1931
1932         Do not use `using namespace std;`. In C++17, we have std::byte. This "byte"
1933         conflicts with ::byte defined in Windows' header.
1934
1935         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp:
1936         (WindowedPluginTest::WindowedPluginTest):
1937         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1938         (logEventProc):
1939         (stringEvent):
1940         (AccessibilityController::winNotificationReceived):
1941         * DumpRenderTree/win/TextInputController.cpp:
1942         (markedRangeCallback):
1943         (firstRectForCharacterRangeCallback):
1944         (selectedRangeCallback):
1945         * DumpRenderTree/win/TextInputController.h:
1946         * DumpRenderTree/win/TextInputControllerWin.cpp:
1947         (TextInputController::markedRange):
1948         (TextInputController::firstRectForCharacterRange):
1949         (TextInputController::selectedRange):
1950
1951 2018-05-16  Sihui Liu  <sihui_liu@apple.com>
1952
1953         Session cookies aren't reliably set when using default WKWebSiteDataStore
1954         https://bugs.webkit.org/show_bug.cgi?id=185624
1955         <rdar://problem/39111626>
1956
1957         Reviewed by Geoffrey Garen.
1958
1959         Modified and enabled WebKit.WKHTTPCookieStoreWithoutProcessPool.
1960
1961         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1962         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1963         (TEST):
1964
1965 2018-05-16  Valerie R Young  <valerie@bocoup.com>
1966
1967         test262/Runner.pm: save to supplied expectation file if supplied
1968         https://bugs.webkit.org/show_bug.cgi?id=185660
1969
1970         Reviewed by Michael Saboff.
1971
1972         * Scripts/test262/Runner.pm:
1973         (processCLI):
1974         (main):
1975
1976 2018-05-15  Ryan Haddad  <ryanhaddad@apple.com>
1977
1978         Unreviewed, rolling out r231763.
1979
1980         The test added with this change is failing an assertion.
1981
1982         Reverted changeset:
1983
1984         "NSEvent event trackers don't work from WebKitTestRunner"
1985         https://bugs.webkit.org/show_bug.cgi?id=185383
1986         https://trac.webkit.org/changeset/231763
1987
1988 2018-05-15  David Kilzer  <ddkilzer@apple.com>
1989
1990         TestWebKitAPI: Fix warnings found by new clang compiler
1991         <https://webkit.org/b/185631>
1992
1993         Reviewed by Michael Catanzaro.
1994
1995         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
1996         (TestWebKitAPI::TEST):
1997         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
1998         (TestWebKitAPI::TEST):
1999         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
2000         (TestWebKitAPI::TEST):
2001         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
2002         (TestWebKitAPI::TEST):
2003         - Add #pragma statements to ignore the new
2004           -Wself-assign-overloaded warning and to ignore
2005           this as an unknown warning on older clang versions.  We want
2006           to keep these self assigments as this code is designed to test
2007           that use case.
2008
2009         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
2010         (TestWebKitAPI::didFindStringMatches):
2011         - Replace the "rect = rect;" statement that was used to avoid an
2012           unused variable warning with two expectations.
2013
2014         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2015         (-[PinnedStateObserver observeValueForKeyPath:ofObject:change:context:]):
2016         - Switch from -integerValue to -unsignedIntegerValue when
2017           comparing against _WKRectEdgeAll since it's an enum declared
2018           as an NSUInteger.
2019
2020 2018-05-15  Michael Catanzaro  <mcatanzaro@igalia.com>
2021
2022         Unreviewed, rolling out r230749
2023
2024         This did not work as desired.
2025
2026         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2027         (TestWebKitAPI::TEST):
2028
2029 2018-05-15  Antoine Quint  <graouts@apple.com>
2030
2031         [Web Animations] Expose Web Animations CSS integration as an experimental feature
2032         https://bugs.webkit.org/show_bug.cgi?id=185647
2033
2034         Reviewed by Dean Jackson.
2035
2036         Rename the Web Animations CSS integration flag.
2037
2038         * DumpRenderTree/TestOptions.cpp:
2039         (TestOptions::TestOptions):
2040         * DumpRenderTree/TestOptions.h:
2041         * DumpRenderTree/mac/DumpRenderTree.mm:
2042         (setWebPreferencesForTestOptions):
2043         * WebKitTestRunner/TestController.cpp:
2044         (WTR::TestController::resetPreferencesToConsistentValues):
2045         (WTR::updateTestOptionsFromTestHeader):
2046         * WebKitTestRunner/TestOptions.h:
2047         (WTR::TestOptions::hasSameInitializationOptions const):
2048
2049 2018-05-14  Brady Eidson  <beidson@apple.com>
2050
2051         Add an API test to guard against regressions while re-entering setDefersLoading:.
2052         <rdar://problem/37033737> and https://bugs.webkit.org/show_bug.cgi?id=185630
2053
2054         Reviewed by Chris Dumez.
2055
2056         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2057         * TestWebKitAPI/Tests/WebKitCocoa/DoubleDefersLoading.mm: Added.
2058         (-[DoubleDefersNavigationDelegate _webView:navigation:didSameDocumentNavigation:]):
2059         (-[DoubleDefersNavigationDelegate webView:didFinishNavigation:]):
2060         (-[DefersScheme initWithBytes:]):
2061         (-[DefersScheme webView:startURLSchemeTask:]):
2062         (-[DefersScheme webView:stopURLSchemeTask:]):
2063         * TestWebKitAPI/Tests/WebKitCocoa/DoubleDefersLoadingPlugin.mm: Added.
2064         (-[DoubleDefersLoadingPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2065         (-[DoubleDefersLoadingPlugIn webProcessPlugInBrowserContextController:didSameDocumentNavigation:forFrame:]):
2066         (-[DoubleDefersLoadingPlugIn dealloc]):
2067
2068 2018-05-14  Daniel Bates  <dabates@apple.com>
2069
2070         [iOS] Add a test to ensure that setTimeout() does not fire more than expected when using UIWebView
2071         https://bugs.webkit.org/show_bug.cgi?id=185599
2072         <rdar://problem/22493890>
2073
2074         Reviewed by Simon Fraser.
2075
2076         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2077         * TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm: Added.
2078         (-[SetTimeoutFunctionWebViewDelegate webViewDidFinishLoad:]):
2079         (-[SetTimeoutFunctionWebViewDelegate webView:didFailLoadWithError:]):
2080         (-[SetTimeoutFunctionWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
2081         (TestWebKitAPI::TEST):
2082         * TestWebKitAPI/ios/set-timeout-function.html: Added.
2083
2084 2018-05-14  Valerie R Young  <valerie@bocoup.com>
2085
2086         test262/Runner.pm: small bugs in CLI and error codes
2087         https://bugs.webkit.org/show_bug.cgi?id=185629
2088
2089         Reviewed by Michael Saboff.
2090
2091         Fix two commandline args with use '-f', correct
2092         error code of failures.
2093
2094         * Scripts/test262/Runner.pm:
2095         (processCLI):
2096         (main):
2097
2098 2018-05-14  Ryan Haddad  <ryanhaddad@apple.com>
2099
2100         Disable API tests that time out after pointer poisioning was disabled.
2101         https://bugs.webkit.org/show_bug.cgi?id=185586
2102
2103         Unreviewed test gardening.
2104
2105         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
2106         (TestWebKitAPI::TEST):
2107         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
2108         (TestWebKitAPI::TEST):
2109         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
2110         (TestWebKitAPI::TEST):
2111         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
2112         (TestWebKitAPI::TEST):
2113
2114 2018-05-14  Leo Balter  <leonardo.balter@gmail.com>
2115
2116         Test262-Runner: Fix RegExp for capturing tests metadata"
2117         https://bugs.webkit.org/show_bug.cgi?id=185622
2118
2119         Reviewed by Michael Saboff.
2120
2121         This patch fixes the RegExp used to capture each test metadata regarding their EOL characters for
2122         both LF and CRLF forms.
2123
2124         The fix also allows the runner to capture the proper results from two specific files using CR and
2125         CRLF line terminators. They are updated in the expectations file.
2126         * Scripts/test262/Runner.pm:
2127         (parseData):
2128
2129 2018-05-14  Jeremy Jones  <jeremyj@apple.com>
2130
2131         NSEvent event trackers don't work from WebKitTestRunner
2132         https://bugs.webkit.org/show_bug.cgi?id=185383
2133         rdar://problem/40025045
2134
2135         Reviewed by Simon Fraser.
2136
2137         Post simulated wheel events to _sendEventToObservers: so they can be handled by NSEvent observers.
2138         NSEvent swipe tracking is used for webkit swipe navigation.
2139
2140         * WebKitTestRunner/mac/EventSenderProxy.mm:
2141         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2142
2143 2018-05-11  Leo Balter  <leonardo.balter@gmail.com>
2144
2145         Test262 Runner should search for the Debug JSC by default
2146         https://bugs.webkit.org/show_bug.cgi?id=185562
2147
2148         Reviewed by Michael Saboff.
2149
2150         The Test262 Runner is now searching for the Debug build of JSC by
2151         default, not the Release build.
2152
2153         This fix allows a similar call from the previous runner, making
2154         it compatible with the current build bot configuration parameters.
2155
2156         This patch also adds some minor improvements the verbose mode output.
2157
2158         * Scripts/test262/Runner.pm:
2159         (processCLI):
2160         (main):
2161         (getBuildPath):
2162         (processResult):
2163
2164 2018-05-11  Charles Vazac  <cvazac@gmail.com>
2165
2166         Runtime feature flag for Server-Timing
2167         https://bugs.webkit.org/show_bug.cgi?id=184758
2168
2169         Reviewed by Youenn Fablet.
2170
2171         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: added ENABLE_SERVER_TIMING.
2172         * DumpRenderTree/win/DumpRenderTree.cpp: enable Server Timing
2173
2174 2018-05-11  Fujii Hironori  <Hironori.Fujii@sony.com>
2175
2176         [Win][MiniBrowser] Move WK1 related code into MiniBrowser
2177         https://bugs.webkit.org/show_bug.cgi?id=185418
2178
2179         Reviewed by Alex Christensen.
2180
2181         All WK1 related code should be moved into MiniBrowser for the preparation
2182         of Bug 184770.
2183
2184         This change moves the initilization code of MiniBrowse into MiniBrowser::init().
2185
2186         * MiniBrowser/win/Common.cpp:
2187         (getAppDataFolder): Removed `static` keyword to be called from MiniBrowser.cpp.
2188         (setCacheFolder): This is only for WK1. Moved into MiniBrowser.cpp.
2189         * MiniBrowser/win/Common.h: Added.
2190         * MiniBrowser/win/MiniBrowser.cpp:
2191         (MiniBrowser::init): Moved the initilization code from wWinMain.
2192         (MiniBrowser::setCacheFolder): Moved from Common.cpp and made it a method.
2193         * MiniBrowser/win/MiniBrowser.h:
2194         (MiniBrowser::setCacheFolder): Changed to a private method.
2195         (MiniBrowser::subclassForLayeredWindow): Changed to a private method.
2196         * MiniBrowser/win/WinMain.cpp:
2197         (wWinMain): Moved MiniBrowse initilization code into MiniBrowser.cpp.
2198
2199 2018-05-11  Brady Eidson  <beidson@apple.com>
2200
2201         Make sure history navigations reuse the existing process when necessary.
2202         <rdar://problem/39746516> and https://bugs.webkit.org/show_bug.cgi?id=185532
2203
2204         Reviewed by Ryosuke Niwa.
2205
2206         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2207
2208 2018-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
2209
2210         [JSC][GLIB] Add introspectable alternatives to functions using vargars
2211         https://bugs.webkit.org/show_bug.cgi?id=185508
2212
2213         Reviewed by Michael Catanzaro.
2214
2215         Add test cases for the new API.
2216
2217         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2218         (testJSCFunction):
2219         (testJSCObject):
2220
2221 2018-05-10  Leo Balter  <leonardo.balter@gmail.com>
2222
2223         [Build Bot] Restore configuration options to the Test262 Runner
2224
2225         During the switch from the previous Test262 runner to the new one,
2226         a call for an extra configurations options got removed.
2227
2228         This call is important to inform the script to find the debug or
2229         release build of JSC. It's being restored in this patch.
2230
2231         https://bugs.webkit.org/show_bug.cgi?id=185513
2232
2233         Reviewed by Yusuke Suzuki.
2234
2235         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2236         (RunTest262Tests):
2237
2238 2018-05-10  Jonathan Bedard  <jbedard@apple.com>
2239
2240         REGRESSION (r230998): Cannot stream API test output
2241         https://bugs.webkit.org/show_bug.cgi?id=185090
2242
2243         Reviewed by Ryosuke Niwa.
2244
2245         Change run-api-tests so that the stdout and stderr of a test will be printed
2246         before it's result. If -v is passed, the output of single test runs will be
2247         streamed. 
2248
2249         * Scripts/webkitpy/api_tests/run_api_tests.py:
2250         (run): Use print_timestamps flag.
2251         (parse_args): Add timestamps option to print timestamps in the log.
2252         * Scripts/webkitpy/api_tests/runner.py:
2253         (Runner): Add running status.
2254         (Runner.__init__): Add number of workers and a flag to detect if a newline
2255         is needed at the beginning of a log line.
2256         (Runner.run): Turn off most logging coming from server process since it is
2257         not constructive for API tests.
2258         (Runner.handle): Add new log message to stream stdout and stderr instead of
2259         caching values until the test run finished.
2260         (_Worker._run_single_test): Log stdout and stderr in real time.
2261         (_Worker._run_shard_with_binary): Log stderr and stdout buffer before ending
2262         the test.
2263         (_Worker.post): Provide a post with explicitly enumerated argument names.
2264         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
2265         (MeteredStream.__init__): Differentiate verbose logging and logging with timestamps.
2266         (MeteredStream.write): Allow for verbose logging without timestamps.
2267         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
2268         (RegularTest): Add print_timestamps flag.
2269         (RegularTest.setUp):
2270         (RegularTest.test_logging_not_included):
2271         (VerboseTest.test_log_args):
2272         (VerboseWithOutTimestamp):
2273         (VerboseWithOutTimestamp.test_basic): Add test for verbose logging without timestamps.
2274
2275 2018-05-10  Ryosuke Niwa  <rniwa@webkit.org>
2276
2277         build-webkit can erroneously warn about Xcode being too old
2278         https://bugs.webkit.org/show_bug.cgi?id=185533
2279
2280         Reviewed by Dan Bernstein.
2281
2282         Don't assume the version number is always a single digit.
2283
2284         * Scripts/webkitdirs.pm:
2285         (determineXcodeVersion):
2286
2287 2018-05-10  Ross Kirsling  <ross.kirsling@sony.com>
2288
2289         [WinCairo][Buildbot] Test bots need to acquire WinCairoRequirements.
2290         https://bugs.webkit.org/show_bug.cgi?id=185528
2291
2292         Reviewed by Lucas Forschler.
2293
2294         * BuildSlaveSupport/build.webkit.org-config/factories.py:
2295         (TestFactory.__init__):
2296         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2297         (InstallWinCairoDependencies):
2298
2299 2018-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2300
2301         Fix some -Wstring-op-truncation warnings
2302         https://bugs.webkit.org/show_bug.cgi?id=185496
2303
2304         Reviewed by Alex Christensen.
2305
2306         We have an off-by-one in the use of strncpy. The strings would not be null-terminated if
2307         the input was too long. Ensure the buffers are zero-initialized so we don't need to manually
2308         set the last bucket to NUL.
2309
2310         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
2311         (TestWebKitAPI::testAtomicStringNumber):
2312         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2313         (TestWebKitAPI::testStringNumberFixedPrecision):
2314         (TestWebKitAPI::testStringNumberFixedWidth):
2315         (TestWebKitAPI::testStringNumber):
2316
2317 2018-05-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2318
2319         [Win][MiniBrowser] Add a separate WndProc for the layered window
2320         https://bugs.webkit.org/show_bug.cgi?id=185460
2321
2322         Reviewed by Brent Fulgham.
2323
2324         All WK1 related code should be moved into MiniBrowser for the
2325         preparation of Bug 184770.
2326
2327         The layered window was using WndProc of the main window. The
2328         layered window is specific only for WK1. the main window will be
2329         shared among WK1 and WK2.
2330
2331         This change add a new WndProc for the layer window.
2332
2333         * MiniBrowser/win/Common.cpp:
2334         (WndProc): Removed code for the layered windows.
2335         (subclassForLayeredWindow): Moved into MiniBrowser.cpp.
2336         * MiniBrowser/win/MiniBrowser.cpp:
2337         (MiniBrowser::prepareViews): Removed the fourth argument `viewHwnd`.
2338         (viewWndProc): New WndProc for the layered windows.
2339         (MiniBrowser::subclassForLayeredWindow): Moved from Common.cpp.
2340         * MiniBrowser/win/MiniBrowser.h:
2341         (MiniBrowser::hwnd):
2342         * MiniBrowser/win/WinMain.cpp:
2343         (wWinMain): Added m_viewWnd.
2344
2345 2018-05-10  Stephan Szabo  <stephan.szabo@sony.com>
2346
2347         Support --verbose in run-javascriptcore-tests
2348         https://bugs.webkit.org/show_bug.cgi?id=185492
2349
2350         Reviewed by Daniel Bates.
2351
2352         * Scripts/run-javascriptcore-tests:
2353         (runJSCStressTests):
2354
2355 2018-05-10  Valerie R Young  <valerie@bocoup.com>
2356
2357         test262/Runner.pm: --failing-files uses results file not expectations
2358         https://bugs.webkit.org/show_bug.cgi?id=185395
2359
2360         Reviewed by Michael Saboff.
2361
2362         --failing-files arg now uses results file to find failing tests
2363         to rerun. It will look in the test262-results directory from whereever
2364         the script is run, or a results.yaml file can be supplied via command
2365         line argument.
2366         --expectations arg added for suppling expectation file.
2367
2368         * Scripts/test262/Runner.pm:
2369         (processCLI):
2370         (main):
2371         (loadImportFile):
2372         (findAllFailing):
2373
2374 2018-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
2375
2376         [GTK] Add support for settings cookies policy and storage type in MiniBrowser
2377         https://bugs.webkit.org/show_bug.cgi?id=185506
2378
2379         Reviewed by Philippe Normand.
2380
2381         Useful for testing and debugging.
2382
2383         * MiniBrowser/gtk/main.c:
2384         (main):
2385
2386 2018-05-09  Chris Dumez  <cdumez@apple.com>
2387
2388         Unreviewed Windows build fix after r231622.
2389
2390         * DumpRenderTree/win/DumpRenderTree.cpp:
2391         (enableExperimentalFeatures):
2392
2393 2018-05-09  Sihui Liu  <sihui_liu@apple.com>
2394
2395         Update WebKit.WebsiteDataStoreCustomPaths after r231536
2396         https://bugs.webkit.org/show_bug.cgi?id=185486
2397         <rdar://problem/37214391>
2398
2399         Reviewed by Chris Dumez.
2400
2401         Update WebKit.WebsiteDataStoreCustomPaths as _syncNetworkProcessCookies is async now.
2402
2403         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2404         (TEST):
2405
2406 2018-05-09  Leo Balter  <leonardo.balter@gmail.com>
2407
2408         Test262-Runner: Improve the verbose output
2409         https://bugs.webkit.org/show_bug.cgi?id=185491
2410
2411         Reviewed by Michael Saboff.
2412
2413         * Scripts/test262/Import.pm:
2414         (transferFiles):
2415         * Scripts/test262/Runner.pm:
2416         (processResult):
2417
2418 2018-05-09  Leo Balter  <leonardo.balter@gmail.com>
2419
2420         Fix Test262 Runner to have DYLD_FRAMEWORK_PATH always set
2421         https://bugs.webkit.org/show_bug.cgi?id=185488
2422
2423         Reviewed by Michael Saboff.
2424
2425         * Scripts/test262/Runner.pm:
2426         (processCLI):
2427         (getBuildPath):
2428         (runTest):
2429
2430 2018-05-09  Richard Houle  <rhoule@apple.com>
2431
2432         [Cocoa] Some fields are not identified as [WKWebProcessPlugInNodeHandle isTextField]
2433         https://bugs.webkit.org/show_bug.cgi?id=185260
2434         <rdar://problem/39290394>
2435
2436         Reviewed by Tim Horton.
2437
2438         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2439         * TestWebKitAPI/Tests/WebKitCocoa/InjectedBundleNodeHandleIsTextField.mm: Added.
2440         (-[InjectedBundleNodeHandleIsTextField isTextFieldForHTMLInputType:document:jsContext:]):
2441         (-[InjectedBundleNodeHandleIsTextField webProcessPlugIn:didCreateBrowserContextController:]):
2442         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2443         (-[InjectedBundleNodeHandleIsTextFieldDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2444
2445 2018-05-09  Thibault Saunier  <tsaunier@igalia.com>
2446
2447         [tests][GStreamer]: Pass USE_PLAYBIN3 to the tests subprocess
2448         https://bugs.webkit.org/show_bug.cgi?id=185481
2449
2450         Reviewed by Philippe Normand.
2451
2452         [tests][GStreamer]: Pass USE_PLAYBIN3 to the tests subprocess
2453
2454         * Scripts/webkitpy/port/gtk.py:
2455         (GtkPort.setup_environ_for_server):
2456
2457 2018-05-09  Leo Balter  <leonardo.balter@gmail.com>
2458
2459         Set build.webkit.org to use the new Test262-runner
2460         https://bugs.webkit.org/show_bug.cgi?id=184933
2461
2462         Reviewed by Aakash Jain.
2463
2464         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2465         (RunTest262Tests):
2466         (RunTest262Tests.countFailures):
2467         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2468
2469 2018-05-09  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
2470
2471         [GTK][JHBuild] LLVM 3.7.0 build is broken with GCC 8.1
2472         https://bugs.webkit.org/show_bug.cgi?id=185461
2473
2474         Reviewed by Michael Catanzaro.
2475
2476         JHBuild now compiles LLVM 6 and Mesa 18.0.3.
2477
2478         * gtk/jhbuild.modules:
2479
2480 2018-05-09  Michael Catanzaro  <mcatanzaro@igalia.com>
2481
2482         Unreviewed. Update OptionsWPE.cmake and NEWS for 2.21.1 release.
2483
2484         * wpe/manifest.txt.in: Distribute the NEWS.
2485
2486 2018-05-09  Michael Catanzaro  <mcatanzaro@igalia.com>
2487
2488         [WPE] Build cleanly with GCC 8 and ICU 60
2489         https://bugs.webkit.org/show_bug.cgi?id=185462
2490
2491         Reviewed by Carlos Alberto Lopez Perez.
2492
2493         * TestWebKitAPI/CMakeLists.txt: Fix weird build failure, we were missing a directory. Not
2494         sure why this was never noticed until now or why the bots are OK.
2495         * gtk/jhbuild.modules: Add upstream patch to avoid warnings inside G_DEFINE_TYPE.
2496         * gtk/patches/glib-cast-function-type.patch: Added.
2497         * wpe/jhbuild.modules: Add upstream patch to avoid warnings inside G_DEFINE_TYPE.
2498         * wpe/patches/glib-cast-function-type.patch: Added.
2499
2500 2018-05-06  Yusuke Suzuki  <utatane.tea@gmail.com>
2501
2502         [JSC][GTK][JSCONLY] Use capstone disassembler
2503         https://bugs.webkit.org/show_bug.cgi?id=185283
2504
2505         Reviewed by Michael Catanzaro.
2506
2507         * gtk/manifest.txt.in:
2508         * wpe/manifest.txt.in:
2509
2510 2018-05-09  Antti Koivisto  <antti@apple.com>
2511
2512         Add OptionSet::operator& and operator bool
2513         https://bugs.webkit.org/show_bug.cgi?id=185306
2514
2515         Reviewed by Anders Carlsson.
2516
2517         * TestWebKitAPI/Tests/WTF/OptionSet.cpp:
2518         (TestWebKitAPI::TEST):
2519
2520 2018-05-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2521
2522         Consolidate WebContentReaderIOS and WebContentReaderMac into WebContentReaderCocoa
2523         https://bugs.webkit.org/show_bug.cgi?id=185340
2524
2525         Reviewed by Tim Horton.
2526
2527         Adds a new API test to verify that URLs written using -[NSPasteboard writeObjects:] are pasted as anchors with
2528         non-empty text in a contenteditable.
2529
2530         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
2531         (TestWebKitAPI::TEST):
2532
2533 2018-05-08  Valerie R Young  <valerie@bocoup.com>
2534
2535         test262/Runner.pm: create results dir for results of test262 run
2536         https://bugs.webkit.org/show_bug.cgi?id=185392
2537
2538         Reviewed by Michael Saboff.
2539
2540         New directory test262-results created from where ever script is
2541         called.
2542
2543         * Scripts/test262/Runner.pm:
2544         (processCLI):
2545
2546 2018-05-08  Valerie R Young  <valerie@bocoup.com>
2547
2548         test262/Runner.pm: lower number of processes per core
2549         https://bugs.webkit.org/show_bug.cgi?id=185426
2550
2551         Reviewed by Michael Saboff.
2552
2553         * Scripts/test262/Runner.pm:
2554         (getProcesses):
2555
2556 2018-05-08  Leo Balter  <leonardo.balter@gmail.com>
2557
2558         Test262-Runner: Add base Perl UnicodeData
2559         https://bugs.webkit.org/show_bug.cgi?id=185444
2560
2561         Reviewed by Michael Saboff.
2562
2563         * Scripts/test262/local/lib/perl5/unicore/lib/gc_sc/SpacePer.pl: Added.
2564         * Scripts/test262/local/lib/perl5/unicore/lib/gc_sc/Word.pl: Added.
2565
2566 2018-05-08  Daniel Bates  <dabates@apple.com>
2567
2568         Add tests to ensure that the Strong Password appearance is removed on form reset
2569         https://bugs.webkit.org/show_bug.cgi?id=185440
2570
2571         Reviewed by Ryosuke Niwa.
2572
2573         * TestWebKitAPI/Tests/WebKitCocoa/DidResignInputElementStrongPasswordAppearance.mm:
2574         (-[DidResignInputElementStrongPasswordAppearance webProcessPlugIn:didCreateBrowserContextController:]):
2575         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2576         (TEST):
2577
2578 2018-05-08  Daniel Bates  <dabates@apple.com>
2579
2580         Resign Strong Password appearance when text field value changes
2581         https://bugs.webkit.org/show_bug.cgi?id=185433
2582         <rdar://problem/39958508>
2583
2584         Reviewed by Ryosuke Niwa.
2585
2586         Add a unit test to ensure the injected bundle API and WebKit UI delegate SPI is invoked
2587         when the field has the Strong Password button and its value changes.
2588
2589         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2590         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2591         (TEST):
2592
2593 2018-05-06  Filip Pizlo  <fpizlo@apple.com>
2594
2595         InPlaceAbstractState::beginBasicBlock shouldn't have to clear any abstract values
2596         https://bugs.webkit.org/show_bug.cgi?id=185365
2597
2598         Reviewed by Saam Barati.
2599         
2600         Make it possible to measure compile times.
2601         
2602         Rolling back in after fixing cloop builds.
2603
2604         * Scripts/run-jsc-benchmarks:
2605
2606 2018-05-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2607
2608         [iOS] WKAttachmentTestsIOS.InsertDroppedItemProvidersInOrder fails after r231396
2609         https://bugs.webkit.org/show_bug.cgi?id=185414
2610
2611         Reviewed by Tim Horton.
2612
2613         Adjust a test expectation to check that the resulting DOM contains an attachment element,
2614         anchor element, and another attachment element in that order. This ensures that the test
2615         still passes, even after the anchor element is followed by a line break.
2616
2617         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2618         (TestWebKitAPI::TEST):
2619
2620 2018-05-08  Commit Queue  <commit-queue@webkit.org>
2621
2622         Unreviewed, rolling out r231491.
2623         https://bugs.webkit.org/show_bug.cgi?id=185434
2624
2625         Setting the Created key on a cookie does not work yet, due a
2626         bug in CFNetwork (Requested by ggaren on #webkit).
2627
2628         Reverted changeset:
2629
2630         "[WKHTTPCookieStore getAllCookies] returns inconsistent
2631         creation time"
2632         https://bugs.webkit.org/show_bug.cgi?id=185041
2633         https://trac.webkit.org/changeset/231491
2634
2635 2018-05-08  Valerie R Young  <valerie@bocoup.com>
2636
2637         test262/Runner.pm: move input files to JSTests/test262
2638         https://bugs.webkit.org/show_bug.cgi?id=185389
2639
2640         Reviewed by Michael Saboff.
2641
2642         * Scripts/test262/Runner.pm:
2643         (processCLI):
2644
2645 2018-05-08  Chris Dumez  <cdumez@apple.com>
2646
2647         Unreviewed, simplify Speedometer fixes landed in r231489, r231483 & r231474.
2648
2649         * Scripts/webkitpy/performance_tests/perftest.py:
2650         (PerfTest):
2651
2652 2018-05-08  Ryan Haddad  <ryanhaddad@apple.com>
2653
2654         Unreviewed, rolling out r231468.
2655
2656         Broke the CLoop build
2657
2658         Reverted changeset:
2659
2660         "InPlaceAbstractState::beginBasicBlock shouldn't have to clear
2661         any abstract values"
2662         https://bugs.webkit.org/show_bug.cgi?id=185365
2663         https://trac.webkit.org/changeset/231468
2664
2665 2018-05-08  Sihui Liu  <sihui_liu@apple.com>
2666
2667         [WKHTTPCookieStore getAllCookies] returns inconsistent creation time
2668         https://bugs.webkit.org/show_bug.cgi?id=185041
2669         <rdar://problem/34684214>
2670
2671         Reviewed by Geoffrey Garen.
2672
2673         Add API test Coverage.
2674
2675         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2676         (TEST):
2677
2678 2018-05-08  Chris Dumez  <cdumez@apple.com>
2679
2680         Unreviewed, fix issue with running Speedometer PerfTest after r231450.
2681
2682         * Scripts/webkitpy/performance_tests/perftest.py:
2683         (PerfTest):
2684
2685 2018-05-08  Chris Dumez  <cdumez@apple.com>
2686
2687         Unreviewed, fix issue with running Speedometer PerfTest after r231450.
2688
2689         * Scripts/webkitpy/performance_tests/perftest.py:
2690         (PerfTest):
2691
2692 2018-05-07  Chris Dumez  <cdumez@apple.com>
2693
2694         Unreviewed, fix issue with running Speedometer PerfTest after r231450.
2695
2696         * Scripts/webkitpy/performance_tests/perftest.py:
2697         (PerfTest):
2698
2699 2018-05-06  Filip Pizlo  <fpizlo@apple.com>
2700
2701         InPlaceAbstractState::beginBasicBlock shouldn't have to clear any abstract values
2702         https://bugs.webkit.org/show_bug.cgi?id=185365
2703
2704         Reviewed by Saam Barati.
2705         
2706         Make it possible to measure compile times.
2707
2708         * Scripts/run-jsc-benchmarks:
2709
2710 2018-05-07  Leo Balter  <leonardo.balter@gmail.com>
2711
2712         Test262-Runner: Add base module to the local deps - unicore/Exact.pl
2713         https://bugs.webkit.org/show_bug.cgi?id=185390
2714
2715         Reviewed by Michael Saboff.
2716
2717         * Scripts/test262/local/lib/perl5/unicore/Exact.pl: Added.
2718
2719 2018-05-07  Jonathan Bedard  <jbedard@apple.com>
2720
2721         Check for com.apple.datamigrator before declaring simulators booted
2722         https://bugs.webkit.org/show_bug.cgi?id=185315
2723         <rdar://problem/39986261>
2724
2725         Reviewed by David Kilzer.
2726
2727         * Scripts/webkitdirs.pm:
2728         (waitUntilProcessNotRunning): Wait until a process is not found.
2729         (relaunchIOSSimulator): Wait until com.apple.datamigrator stops running to declare
2730         a simulator booted.
2731         * Scripts/webkitpy/common/system/executive_mock.py:
2732         (MockExecutive2.__init__): Define _running_pids.
2733         * Scripts/webkitpy/xcode/simulated_device.py:
2734         (SimulatedDeviceManager.initialize_devices): Call wait_until_data_migration_is_done before
2735         declaring that devices have been booted, increase the timeout since data migration will frequently
2736         take longer than 60 seconds, especially with multiple simulators booting.
2737         (SimulatedDeviceManager.swap): Ditto.
2738         (SimulatedDeviceManager):
2739         (SimulatedDeviceManager.wait_until_data_migration_is_done): Wait until there are no com.apple.datamigrator
2740         processes running.
2741
2742 2018-05-07  Daniel Bates  <dabates@apple.com>
2743
2744         REGRESSION (r229955): run-webkit-tests runs tests in skipped directories and subdirectories of directory given on command line
2745         https://bugs.webkit.org/show_bug.cgi?id=185054
2746         <rdar://problem/39773209>
2747
2748         Reviewed by Ryosuke Niwa.
2749
2750         Fallback to MacPort.CURRENT_VERSION if we are not using a known named macOS and do not have Apple Additions.
2751
2752         Darwin-based ports have OS version-specific test expectations and are certified to support running tests using
2753         the currently shipping OS by way of a hardcoded class variable CURRENT_VERSION. The run-webkit-tests script
2754         depends on the OS version to find the applicable TestExpectations files to parse to compute the list of skipped
2755         tests for the port.
2756
2757         * Scripts/webkitpy/port/mac.py:
2758         (MacPort.__init__): Fall back to MacPort.CURRENT_VERSION if we are not using a known named macOS and do not
2759         have Apple Additions.
2760         * Scripts/webkitpy/port/mac_unittest.py:
2761         (MacTest.test_factory_with_future_version): Added.
2762         (MacTest.test_factory_with_future_version_and_apple_additions): Renamed from MacTest.test_factory_with_future_version()
2763         and added code to use the mock Apple Additions so that running this code with- and without- the real Apple Additions
2764         produces consistent results now that the Mac port's OS version falls back to MacPort.CURRENT_VERSION when Apple Additions
2765         is absent.
2766
2767 2018-05-07  Brian Burg  <bburg@apple.com>
2768
2769         Web Inspector: opt out of process swap on navigation if a Web Inspector frontend is connected
2770         https://bugs.webkit.org/show_bug.cgi?id=184861
2771         <rdar://problem/39153768>
2772
2773         Reviewed by Timothy Hatcher.
2774
2775         Add a new test that checks whether a new process is used for navigation when
2776         an Inspector is shown. Also check that the behavior reverts to normal after
2777         the Inspector has been closed.
2778
2779         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2780
2781 2018-05-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2782
2783         [iOS] Multiple links in Mail are dropped in a single line, and are difficult to tell apart
2784         https://bugs.webkit.org/show_bug.cgi?id=185289
2785         <rdar://problem/35756912>
2786
2787         Reviewed by Tim Horton and Darin Adler.
2788
2789         Augment and rebaseline some iOS drag-and-drop API tests that handle dropping URLs as a part of multi-item drop
2790         sessions.
2791
2792         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2793         (TestWebKitAPI::TEST):
2794
2795 2018-05-04  Timothy Hatcher  <timothy@apple.com>
2796
2797         Deprecate legacy WebView and friends
2798         https://bugs.webkit.org/show_bug.cgi?id=185279
2799         rdar://problem/33268700
2800
2801         Reviewed by Tim Horton.
2802
2803         * MiniBrowser/Configurations/Base.xcconfig: Added GCC_PREPROCESSOR_DEFINITIONS
2804         to define DISABLE_LEGACY_WEBKIT_DEPRECATIONS.
2805
2806 2018-05-04  Leo Balter  <leonardo.balter@gmail.com>
2807
2808         Test262-Runner: Add base module to the local deps - unicore/PVA.pl
2809         https://bugs.webkit.org/show_bug.cgi?id=185314
2810
2811         Reviewed by Michael Saboff.
2812
2813         * Scripts/test262/local/lib/perl5/unicore/PVA.pl: Added.
2814
2815 2018-05-04  Wenson Hsieh  <whsieh@berkeley.edu>
2816
2817         REGRESSION: [ios-simulator] 3 WKWebViewAutofillTests API test failures seen with 11.3 SDK
2818         https://bugs.webkit.org/show_bug.cgi?id=184196
2819         <rdar://problem/39054481>
2820
2821         Reviewed by Tim Horton.
2822
2823         Removes some unnecessary workarounds to enable running app autofill tests against iOS versions
2824         earlier than 11.3. Also re-enables these tests.
2825
2826         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2827         (TestWebKitAPI::TEST):
2828         (-[UITextAutofillSuggestion initWithUsername:password:]): Deleted.
2829         (+[UITextAutofillSuggestion autofillSuggestionWithUsername:password:]): Deleted.
2830
2831 2018-05-04  Myles C. Maxfield  <mmaxfield@apple.com>
2832
2833         Text shaping in the simple path is flipped in the y direction
2834         https://bugs.webkit.org/show_bug.cgi?id=185062
2835         <rdar://problem/39778678>
2836
2837         Reviewed by Simon Fraser.
2838
2839         Huge thanks to Ulrike Rausch of LiebeFonts for contributing the test fonts!!!
2840
2841         * Scripts/webkitpy/common/config/contributors.json:
2842
2843 2018-05-04  Leo Balter  <leonardo.balter@gmail.com>
2844
2845         Test262-Runner: place the processCLI inside the main call
2846         https://bugs.webkit.org/show_bug.cgi?id=185304
2847
2848         Reviewed by Michael Saboff.
2849
2850         * Scripts/test262/Runner.pm:
2851         (main):
2852
2853 2018-05-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2854
2855         [GTK] Epiphany (GNOME Web) says "Error downloading: Service Unavailable." when trying to download an image from discogs.com
2856         https://bugs.webkit.org/show_bug.cgi?id=174730
2857
2858         Reviewed by Michael Catanzaro.
2859
2860         Update unit tests to check that User-Agent header is included in HTTP download requests.
2861
2862         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
2863         (testDownloadRemoteFile):
2864         (testWebViewDownloadURI):
2865         (testPolicyResponseDownload):
2866         (testPolicyResponseDownloadCancel):
2867         (testDownloadMIMEType):
2868         (testContextMenuDownloadActions):
2869
2870 2018-05-03  Ross Kirsling  <ross.kirsling@sony.com>
2871
2872         [WinCairo] Test archive must use Python zipfile, just like build product.
2873         https://bugs.webkit.org/show_bug.cgi?id=185265
2874
2875         Reviewed by Per Arne Vollan.
2876
2877         * BuildSlaveSupport/test-result-archive:
2878         (archive_test_results):
2879         Copy over Win32-oriented archiving logic from built-product-archive.
2880
2881 2018-05-03  Leo Balter  <leonardo.balter@gmail.com>
2882
2883         cleanup modules usage for the Test262-Runner
2884         https://bugs.webkit.org/show_bug.cgi?id=185263
2885
2886         Reviewed by Michael Saboff.
2887
2888         * Scripts/test262-runner:
2889         * Scripts/test262/Runner.pm:
2890         (processCLI):
2891
2892 2018-05-03  Valerie R Young  <valerie@bocoup.com>
2893
2894         test262/Runner.pm: minor fixes
2895         https://bugs.webkit.org/show_bug.cgi?id=185250
2896
2897         Reviewed by Michael Saboff.
2898
2899         Add comments, change output and fix bug: unintended interpolation
2900         of filename when running jsc.
2901
2902         * Scripts/test262/Runner.pm:
2903         (processCLI):
2904         (main):
2905         (runTest):
2906
2907 2018-05-03  Chris Dumez  <cdumez@apple.com>
2908
2909         Load hangs if the WebProcess fails to launch
2910         https://bugs.webkit.org/show_bug.cgi?id=185225
2911         <rdar://problem/38249058>
2912
2913         Reviewed by Geoff Garen.
2914
2915         Add API test coverage.
2916
2917         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2918         * TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm: Added.
2919         (-[CrashOnStartNavigationDelegate _webView:webContentProcessDidTerminateWithReason:]):
2920         (-[CrashOnStartNavigationDelegate webView:didFinishNavigation:]):
2921         (-[CrashRecoveryScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2922         (TEST):
2923
2924 2018-05-03  Don Olmstead  <don.olmstead@sony.com>
2925
2926         [WinCairo] Add JSC test bots
2927         https://bugs.webkit.org/show_bug.cgi?id=185234
2928
2929         Reviewed by Per Arne Vollan.
2930
2931         * BuildSlaveSupport/build.webkit.org-config/config.json:
2932         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2933         (RunJavaScriptCoreTests.start):
2934
2935 2018-05-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2936
2937         WebKit should send fake macOS user agent to docs.google.com
2938         https://bugs.webkit.org/show_bug.cgi?id=185165
2939
2940         Reviewed by Carlos Garcia Campos.
2941
2942         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2943         (TestWebKitAPI::TEST):
2944
2945 2018-05-03  Valerie R Young  <valerie@bocoup.com>
2946
2947         test262/Runner.pm: performance improvements
2948         https://bugs.webkit.org/show_bug.cgi?id=185202
2949
2950         Reviewed by Michael Saboff.
2951
2952         Batch the tests by the number of processes, and give each process
2953         a file to save results to to avoid threading. Do not parallelize
2954         when running small sets of tests.
2955
2956         * Scripts/test262/Runner.pm:
2957         (processCLI):
2958         (main):
2959         (processFile):
2960         (processResult):
2961
2962 2018-05-03  Ryan Haddad  <ryanhaddad@apple.com>
2963
2964         Unreviewed, rolling out r231253.
2965
2966         The API test added with this change is crashing on the bots.
2967
2968         Reverted changeset:
2969
2970         "Web Inspector: opt out of process swap on navigation if a Web
2971         Inspector frontend is connected"
2972         https://bugs.webkit.org/show_bug.cgi?id=184861
2973         https://trac.webkit.org/changeset/231253
2974
2975 2018-05-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2976
2977         REGRESSION(r222772): [GTK][WPE] WebProcess from WebKitGtk+ 2.19.9x SIGSEVs in WebKit::WebProcess::ensureNetworkProcessConnection() at Source/WebKit/WebProcess/WebProcess.cpp:1127
2978         https://bugs.webkit.org/show_bug.cgi?id=183348
2979
2980         Reviewed by Michael Catanzaro.
2981
2982         Add a test case to reproduce the crash.
2983
2984         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2985         (testWebViewCloseQuickly):
2986         (beforeAll):
2987
2988 2018-05-02  Aditya Keerthi  <akeerthi@apple.com>
2989
2990         Can't copy and paste URLs that have no title into Mail (macOS)
2991         https://bugs.webkit.org/show_bug.cgi?id=185205
2992         <rdar://problem/36352406>
2993
2994         Reviewed by Tim Horton.
2995
2996         Added test to verify behavior when copying and pasting a URL without a title.
2997
2998         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html:
2999         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
3000         (TestWebKitAPI::TEST):
3001
3002 2018-05-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3003
3004         [GTK] Generate a JSC bundle on the 64 and 32 bit release bots and upload it to webkitgtk.org (follow-up fix)
3005         https://bugs.webkit.org/show_bug.cgi?id=184699
3006
3007         Unreviewed follow-up fix after r231230.
3008
3009         * Scripts/generate-jsc-bundle:
3010         (generate_wrapper_script): Quote the arguments passed to jsc.
3011
3012 2018-05-02  Brian Burg  <bburg@apple.com>
3013
3014         Web Inspector: opt out of process swap on navigation if a Web Inspector frontend is connected
3015         https://bugs.webkit.org/show_bug.cgi?id=184861
3016         <rdar://problem/39153768>
3017
3018         Reviewed by Ryosuke Niwa.
3019
3020         Add a new test that checks whether a new process is used for navigation when
3021         an Inspector is shown. Also check that the behavior reverts to normal after
3022         the Inspector has been closed.
3023
3024         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3025
3026 2018-05-02  Valerie R Young  <valerie@bocoup.com>
3027
3028         test262/Runner.pm: save summary to file
3029         https://bugs.webkit.org/show_bug.cgi?id=185200
3030
3031         Reviewed by Michael Saboff.
3032
3033         * Scripts/test262/Runner.pm:
3034         (processCLI):
3035         (main):
3036         (summarizeResults):
3037
3038 2018-05-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3039
3040         [GTK] Generate a JSC bundle on the 64 and 32 bit release bots and upload it to webkitgtk.org
3041         https://bugs.webkit.org/show_bug.cgi?id=184699
3042
3043         Reviewed by Gustavo Noronha Silva.
3044
3045         This adds a new step for the GTK 64-bit release build bot and the
3046         GTK 32-bit release build&test bot.
3047
3048         This step will be run as one of the lasts ones (after the product
3049         is built) and will execute the script generate-jsc-bundle.
3050         This script will take care of creating a JSC bundle and uploading
3051         it to a server defined on a configuration file that has to be
3052         deployed on the bots with the required server data and credentials
3053         for this upload.
3054
3055         In this case, the built products should then be accessible at
3056         <https://webkitgtk.org/jsc-built-products>. But the implementation
3057         is not tied to any specific server. All the details about where
3058         to upload the file is done in configuration file that is kept
3059         private on each bot outside of the WebKit source tree.
3060
3061         The script also supports generating a JSC bundle locally and not
3062         uploading it anywhere. This is the default mode of running.
3063         The remote upload will only be activated if a --remote-config-file
3064         parameter is passed (which is done from the buildbot config)
3065
3066         * BuildSlaveSupport/build.webkit.org-config/config.json:
3067         * BuildSlaveSupport/build.webkit.org-config/factories.py:
3068         (BuildFactory):
3069         (BuildFactory.__init__):
3070         (TestFactory):
3071         (TestFactory.__init__):
3072         (BuildAndGenerateJSCBundleFactory):
3073         (BuildAndNonLayoutTestAndGenerateJSCBundleFactory):
3074         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3075         (GenerateJSCBundle):
3076         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3077         * Scripts/generate-jsc-bundle: Added.
3078         (ldd_get_libs_and_interpreter):
3079         (generate_readme):
3080         (generate_wrapper_script):
3081         (copy_and_remove_rpath):
3082         (createJSCBundle):
3083         (sha256sum):
3084         (uploadJSCBundle):
3085         (main):
3086
3087 2018-05-01  Ryosuke Niwa  <rniwa@webkit.org>
3088
3089         PSON: Make WebKitTestRunner work with process swap on navigation turned on
3090         https://bugs.webkit.org/show_bug.cgi?id=185111
3091
3092         Reviewed by Chris Dumez.
3093
3094         Add the basic support for running layout tests with process-swap-on-navigation turned on.
3095
3096         First, move m_whatToDump, m_dumpPixels, m_waitToDump, and m_dumpFrameLoadCallbacks from WebContent process
3097         to UI process so that calls to waitUntilDone, dumpAsText, etc... persist across process swaps.
3098
3099         In addition, initialize the injected bundle inside a new WebContent process when the first page is created.
3100         This instantiates objects such as TestRunner, GCController, etc... in the new process. The initialization
3101         can't be done in InjectedBundle::beginTesting because some steps in InjectedBundle::initialize require
3102         the current PageGroup and Page objects. We avoid clearing databases and app cache in this case.
3103
3104         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3105         (WTR::InjectedBundle::didCreatePage): Send "Initialization" message to UI process. This message returns
3106         all the dictionary values usually present in "BeginTest" message from UI process as well as "ResumeTesting"
3107         boolean which is set when this process was created as a result of a process swap on navgation. Invoke
3108         beginTesting with BegingTestingMode::Resume when this boolean is set.
3109         (WTR::InjectedBundle::didReceiveMessageToPage):
3110         (WTR::InjectedBundle::beginTesting): Don't clear database, app cache, etc... when initializing an injected
3111         bundle after a process swap on navigation.
3112         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3113         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3114         (WTR::InjectedBundlePage::dump):
3115         (WTR::InjectedBundlePage::frameDidChangeLocation):
3116         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3117         (WTR::TestRunner::TestRunner):
3118         (WTR::TestRunner::shouldDumpPixels const): Added.
3119         (WTR::TestRunner::setDumpPixels): Added.
3120         (WTR::TestRunner::dumpAsText):
3121         (WTR::TestRunner::whatToDump const): Added.
3122         (WTR::TestRunner::setWhatToDump): Added.
3123         (WTR::TestRunner::waitUntilDone):
3124         (WTR::TestRunner::setWaitUntilDone): Added.
3125         (WTR::TestRunner::shouldWaitUntilDone): Added.
3126         (WTR::TestRunner::notifyDone):
3127         (WTR::TestRunner::forceImmediateCompletion):
3128         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks): Added.
3129         (WTR::TestRunner::shouldDumpFrameLoadCallbacks): Added.
3130         (WTR::TestRunner::setAudioResult):
3131         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3132         (WTR::TestRunner::dumpChildFramesAsText):
3133         (WTR::TestRunner::dumpDOMAsWebArchive):
3134         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks): Moved to cpp.
3135         (WTR::TestRunner::whatToDump const): Moved to cpp.
3136         (WTR::TestRunner::shouldDumpMainFrameScrollPosition const):
3137         (WTR::TestRunner::shouldDumpPixels const): Moved to cpp.
3138         (WTR::TestRunner::shouldDumpFrameLoadCallbacks const): Moved to cpp.
3139         (WTR::TestRunner::waitToDump const): Renamed to shouldWaitUntilDone and moved to cpp.
3140         * WebKitTestRunner/TestInvocation.cpp:
3141         (WTR::TestInvocation::TestInvocation): Initialize m_dumpFrameLoadCallbacks here.
3142         (WTR::TestInvocation::shouldLogFrameLoadDelegates const): Deleted.
3143         (WTR::TestInvocation::createTestSettingsDictionary): Extracted from invoke().
3144         (WTR::TestInvocation::invoke): Sets m_startedTesting to true immediately afte sending "BeginTest" message.
3145         m_startedTesting is later used in didReceiveSynchronousMessageFromInjectedBundle to detect whether a given
3146         "Initialization" message is sent from a regular WebContent process (m_startedTesting is false) or the one
3147         started as a result of a process swap on navigation (m_startedTesting is true).
3148         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): Added a bunch of new messgaes to
3149         support initializing the injected bundle in a process swapped after navigation and set/get messages for
3150         the states which must persist across process swaps within a test.
3151         * WebKitTestRunner/TestInvocation.h:
3152         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3153         * Tools/WebKitTestRunner/WhatToDump.h:
3154         (WTR::WhatToDump): Added.
3155
3156 2018-05-01  Leo Balter  <leonardo.balter@gmail.com>
3157
3158         Auto save the results for Test262
3159         https://bugs.webkit.org/show_bug.cgi?id=184926
3160
3161         Reviewed by Michael Saboff.
3162
3163         * Scripts/test262/Runner.pm:
3164         (processCLI):
3165         (main):
3166         (parseError):
3167         (processResult):
3168         (summarizeResults):
3169         * Scripts/test262/config.yaml: Renamed from Tools/Scripts/test262/test262-config.yaml.
3170
3171 2018-05-01  Jonathan Bedard  <jbedard@apple.com>
3172
3173         webkitpy: SIGKILL right after SIGTERM causes orphaned processes with 'xcrun simctl spawn'
3174         https://bugs.webkit.org/show_bug.cgi?id=185164
3175
3176         Reviewed by David Kilzer.
3177
3178         * Scripts/webkitpy/common/system/executive.py:
3179         (Executive.kill_process): First attempt will always send a SIGTERM, all subsequent attempts will
3180         send a SIGKILL. A SIGKILL with not be sent if the process is not running to avoid orphaning childen.
3181
3182 2018-05-01  Chris Dumez  <cdumez@apple.com>
3183
3184         REGRESSION (r230919): API test WebKit.AutoLayoutIntegration is a flaky failure
3185         https://bugs.webkit.org/show_bug.cgi?id=184918
3186         <rdar://problem/39705516>
3187
3188         Reviewed by Wenson Hsieh.
3189
3190         Make sure provisional load has started before calling beginLayoutAtMinimumWidth
3191         on the AutoLayoutWKWebView to restore pre-r230919 behavior. The load now starts
3192         asynchronously because we ask the client if it is OK to do the load and the policy
3193         delegates are asynchronous nowadays.
3194
3195         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
3196         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]):
3197         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3198         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3199         (-[TestNavigationDelegate webView:didStartProvisionalNavigation:]):
3200         (-[TestNavigationDelegate waitForDidStartProvisionalNavigation]):
3201         (-[WKWebView _test_waitForDidStartProvisionalNavigation]):
3202
3203 2018-05-01  Ross Kirsling  <ross.kirsling@sony.com>
3204
3205         [WinCairo] Align buildbot test stages with AppleWin.
3206         https://bugs.webkit.org/show_bug.cgi?id=185094
3207
3208         Reviewed by Brent Fulgham.
3209
3210         * BuildSlaveSupport/build.webkit.org-config/factories.py:
3211         (TestFactory.__init__):
3212         Do run API tests, don't run dashboard tests.
3213
3214         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3215         (RunUnitTests):
3216         Call run-api-tests with Python, not Perl (bugfix for r230998).
3217
3218         * Scripts/webkitpy/port/win.py:
3219         (WinPort.environment_for_api_tests):
3220         Retrieve necessary Windows environment variables.
3221
3222 2018-05-01  Eric Carlson  <eric.carlson@apple.com>
3223
3224         [MediaStream] remove WK1 support
3225         https://bugs.webkit.org/show_bug.cgi?id=185136
3226
3227         Reviewed by Youenn Fablet.
3228
3229         * DumpRenderTree/mac/UIDelegate.mm:
3230         (-[UIDelegate webView:decidePolicyForUserMediaRequestFromOrigin:listener:]): Deleted.
3231
3232 2018-05-01  Chris Dumez  <cdumez@apple.com>
3233
3234         [WKTR] Move navigation policy for response decision from InjectedBundle to UIProcess
3235         https://bugs.webkit.org/show_bug.cgi?id=185157
3236
3237         Reviewed by Geoffrey Garen.
3238
3239         Move navigation policy for response decision from InjectedBundle to UIProcess. This is a more
3240         common configuration and should therefore be the configuration we test by default.
3241
3242         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3243         (WTR::InjectedBundlePage::decidePolicyForResponse):
3244
3245 2018-05-01  Oleksandr Skachkov  <gskachkov@gmail.com>
3246
3247         WebAssembly: add support for stream APIs - JavaScript API
3248         https://bugs.webkit.org/show_bug.cgi?id=183442
3249
3250         Reviewed by Yusuke Suzuki and JF Bastien.
3251
3252         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3253
3254 2018-04-30  Mark Lam  <mark.lam@apple.com>
3255
3256         Apply PtrTags to the MetaAllocator and friends.
3257         https://bugs.webkit.org/show_bug.cgi?id=185110
3258         <rdar://problem/39533895>
3259
3260         Reviewed by Saam Barati.
3261
3262         Update the test to match MetaAllocator changes in WTF.
3263
3264         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3265         (TestWebKitAPI::TEST_F):
3266         (WTF::tagForPtr):
3267         (WTF::ptrTagName):
3268
3269 2018-04-30  Alex Christensen  <achristensen@webkit.org>
3270
3271         Add WKUIDelegatePrivate equivalent of WKPageContextMenuClient getContextMenuFromProposedMenuAsync
3272         https://bugs.webkit.org/show_bug.cgi?id=180955
3273
3274         Reviewed by Andy Estes.
3275
3276         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuImgWithVideo.mm:
3277         (-[ContextMenuImgWithVideoDelegate _webView:contextMenu:forElement:]):
3278         (-[ContextMenuImgWithVideoDelegate _webView:getContextMenuFromProposedMenu:forElement:userInfo:completionHandler:]):
3279
3280 2018-04-30  JF Bastien  <jfbastien@apple.com>
3281
3282         Use some C++17 features
3283         https://bugs.webkit.org/show_bug.cgi?id=185135
3284
3285         Reviewed by Alex Christensen.
3286
3287         * DumpRenderTree/PlatformMac.cmake:
3288         * gtk/ycm_extra_conf.py:
3289         (FlagsForFile):
3290
3291 2018-04-30  Yusuke Suzuki  <utatane.tea@gmail.com>
3292
3293         Use WordLock instead of std::mutex for Threading
3294         https://bugs.webkit.org/show_bug.cgi?id=185121
3295
3296         Reviewed by Geoffrey Garen.
3297
3298         * TestWebKitAPI/Tests/WTF/Signals.cpp:
3299         (TEST):
3300
3301 2018-04-30  Michael Catanzaro  <mcatanzaro@igalia.com>
3302
3303         [GTK] Webkit should spoof as Safari on a Mac when on Chase.com
3304         https://bugs.webkit.org/show_bug.cgi?id=185103
3305
3306         Reviewed by Carlos Garcia Campos.
3307
3308         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3309         (TestWebKitAPI::TEST):
3310
3311 2018-04-28  Sihui Liu  <sihui_liu@apple.com>
3312
3313         [Cocoa] Set HTTPOnly flag when converting Cookie to NSHTTPCookie
3314         https://bugs.webkit.org/show_bug.cgi?id=185052
3315
3316         Reviewed by Geoffrey Garen.
3317
3318         Modified API test to provide correct test cases for HTTPOnly flag.
3319
3320         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
3321         (TEST):
3322
3323 2018-04-28  Rick Waldron  <waldron.rick@gmail.com>
3324
3325         Token misspelled "tocken" in error message string
3326         https://bugs.webkit.org/show_bug.cgi?id=185030
3327
3328         Reviewed by Saam Barati.
3329
3330         * Scripts/test262/test262-expectations.yaml: Fix typo "tocken" => "token"
3331
3332 2018-04-27  Stephan Szabo  <stephan.szabo@sony.com>
3333
3334         [WinCairo] Support --no-copy for jsc tests in wincairo tests, add copying of dlls for copy case
3335         https://bugs.webkit.org/show_bug.cgi?id=185049
3336
3337         Reviewed by Keith Miller.
3338
3339         * Scripts/run-javascriptcore-tests:
3340         (runJSCStressTests):
3341         * Scripts/run-jsc-stress-tests:
3342
3343 2018-04-26  Ryosuke Niwa  <rniwa@webkit.org>
3344
3345         PSON: Triggering a navigation to an invalid URL creates a new WebContent process
3346         https://bugs.webkit.org/show_bug.cgi?id=185066
3347
3348         Reviewed by Youenn Fablet.
3349
3350         Added a new test case (ProcessSwap.NavigateToInvalidURL) for navigating to an invalid URL.
3351         WebKit should not swap WebContent process in this case.
3352
3353         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3354         (-[PSONNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3355         (-[PSONUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3356
3357 2018-04-27  Nan Wang  <n_wang@apple.com>
3358
3359         AX: Accessibility needs to know which part of the content view is visible on iOS
3360         https://bugs.webkit.org/show_bug.cgi?id=185085
3361         <rdar://problem/39801363>
3362
3363         Reviewed by Chris Fleizach.
3364
3365         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3366         (WTR::AccessibilityUIElement::stringAttributeValue):
3367
3368 2018-04-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3369
3370         [Extra zoom mode] Add a mechanism to override default viewport behaviors in extra zoom mode
3371         https://bugs.webkit.org/show_bug.cgi?id=185050
3372         <rdar://problem/39624038>
3373
3374         Reviewed by Tim Horton.
3375
3376         Remove a test that's no longer useful, now that the SPI it was testing is gone. This functionality is now
3377         tested by the layout test added in this patch.
3378
3379         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3380         * TestWebKitAPI/Tests/ios/ViewportSizingTests.mm: Removed.
3381
3382 2018-04-26  Ryan Haddad  <ryanhaddad@apple.com>
3383
3384         REGRESSION (r231039): RunUnitTests step reports disabled tests as failures
3385         https://bugs.webkit.org/show_bug.cgi?id=185061
3386
3387         Reviewed by Aakash Jain.
3388
3389         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3390         (RunUnitTests.countFailures): Return the difference between the total number of tests run and the number that passed.
3391         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Add a test.
3392
3393 2018-04-26  Ross Kirsling  <ross.kirsling@sony.com>
3394
3395         Add release bots for WinCairo.
3396         https://bugs.webkit.org/show_bug.cgi?id=185042
3397
3398         Reviewed by Lucas Forschler.
3399
3400         * BuildSlaveSupport/build.webkit.org-config/config.json:
3401         Add a release build bot and two test bots, replacing the outdated WinCairo release bots.
3402
3403 2018-04-26  Sihui Liu  <sihui_liu@apple.com>
3404
3405         -[WKHTTPCookieStore deleteCookie:completionHandler:] doesn't delete cookies
3406         https://bugs.webkit.org/show_bug.cgi?id=184938
3407         <rdar://problem/34737395>
3408
3409         Reviewed by Geoffrey Garen.
3410
3411         Add API test coverage.
3412
3413         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
3414         (TEST):
3415
3416 2018-04-26  Ross Kirsling  <ross.kirsling@sony.com>
3417
3418         WinCairo test bots should run JSC tests with options for Windows command prompt.
3419         https://bugs.webkit.org/show_bug.cgi?id=185019
3420
3421         Reviewed by Per Arne Vollan.
3422
3423         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3424         (RunJavaScriptCoreTests.start):
3425
3426 2018-04-26  Ross Kirsling  <ross.kirsling@sony.com>
3427
3428         WinCairo WKL Debug Test bot is not using DRT.
3429         https://bugs.webkit.org/show_bug.cgi?id=185009
3430
3431         Reviewed by Per Arne Vollan.
3432
3433         * BuildSlaveSupport/build.webkit.org-config/config.json:
3434
3435 2018-04-26  Per Arne Vollan  <pvollan@apple.com>
3436
3437         Disable content filtering in minimal simulator mode
3438         https://bugs.webkit.org/show_bug.cgi?id=185027
3439         <rdar://problem/39736091>
3440
3441         Reviewed by Jer Noble.
3442
3443         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3444
3445 2018-04-26  Brady Eidson  <beidson@apple.com>
3446
3447         Add a setting for keeping around all processes and always reusing them per-origin.
3448         <rdar://problem/39695798> and https://bugs.webkit.org/show_bug.cgi?id=185020
3449
3450         Reviewed by Andy Estes.
3451
3452         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3453
3454 2018-04-26  Andy VanWagoner  <thetalecrafter@gmail.com>
3455
3456         [INTL] Implement Intl.PluralRules
3457         https://bugs.webkit.org/show_bug.cgi?id=184312
3458
3459         Reviewed by JF Bastien.
3460
3461         Added Intl.PluralRules feature flag.
3462
3463         * Scripts/webkitperl/FeatureList.pm:
3464         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3465
3466 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
3467
3468         [WPE] Build and link against latest WPEBackend and WPEBackend-fdo
3469         https://bugs.webkit.org/show_bug.cgi?id=184643
3470
3471         Reviewed by Žan Doberšek.
3472
3473         Add missing INCLUDE_DIRS in many places.
3474
3475         Adapt to single-header WPE includes.
3476
3477         Null-initialize padding to silence -Wmissing-field-initializers. (Yuck.)
3478
3479         * TestWebKitAPI/PlatformWPE.cmake:
3480         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3481         (testWebViewWebBackend):
3482         * TestWebKitAPI/glib/PlatformWPE.cmake:
3483         * WebKitTestRunner/EventSenderProxy.h:
3484         * WebKitTestRunner/PlatformWPE.cmake:
3485         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
3486         * wpe/HeadlessViewBackend/CMakeLists.txt:
3487         * wpe/HeadlessViewBackend/HeadlessViewBackend.cpp:
3488         * wpe/HeadlessViewBackend/HeadlessViewBackend.h:
3489         * wpe/jhbuild.modules:
3490
3491 2018-04-25  Jonathan Bedard  <jbedard@apple.com>
3492
3493         REGRESSION (r230998): Bot watcher's dashboard doesn't display number of API test failures
3494         https://bugs.webkit.org/show_bug.cgi?id=184982
3495
3496         Rubber-stamped by Aakash Jain.
3497
3498         Correctly count the number of API test failures.
3499
3500         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3501         (RunUnitTests.countFailures): Count the number of test failures for the new run-api-tests.
3502         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3503         * Scripts/webkitpy/api_tests/manager.py:
3504         (Manager.run): Disabled tests are not run.
3505
3506 2018-04-25  Jiewen Tan  <jiewen_tan@apple.com>
3507
3508         Remove access to keychain from the WebContent process
3509         https://bugs.webkit.org/show_bug.cgi?id=184428
3510         <rdar://problem/13150903>
3511
3512         Reviewed by Brent Fulgham.
3513
3514         This patch does the followings:
3515         1. Added an API test for this patch.
3516         2. Instrument DumpRenderTree and WebKitTestRunner to take advantages of new SPIs.
3517
3518         * DumpRenderTree/mac/UIDelegate.mm:
3519         (-[UIDelegate signedPublicKeyAndChallengeStringForWebView:]):
3520         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3521         * TestWebKitAPI/Tests/mac/SSLKeyGenerator.mm: Added.
3522         (TestWebKitAPI::SSLKeyGeneratorTest::SetUp):
3523         (TestWebKitAPI::SSLKeyGeneratorTest::TearDown):
3524         (TestWebKitAPI::TEST_F):
3525         * WebKitTestRunner/TestController.cpp:
3526         (WTR::copySignedPublicKeyAndChallengeString):
3527         (WTR::TestController::createOtherPage):
3528         (WTR::TestController::createWebViewWithOptions):
3529
3530 2018-04-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3531
3532         [Extra zoom mode] The search field on www.bing.com is missing label text
3533         https://bugs.webkit.org/show_bug.cgi?id=184975
3534         <rdar://problem/39723081>
3535
3536         Reviewed by Tim Horton.
3537
3538         Adds UIScriptController.formInputLabel, which asynchronously requests the input label text for the currently
3539         focused element in extra zoom mode.
3540
3541         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3542         (WTR::UIScriptController::formInputLabel const):
3543         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3544         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3545         (WTR::UIScriptController::formInputLabel const):
3546         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3547         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3548         (WTR::UIScriptController::formInputLabel const):
3549
3550 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
3551
3552         [WPE] Should load injected bundle from builddir in developer builds
3553         https://bugs.webkit.org/show_bug.cgi?id=184983
3554
3555         Reviewed by Carlos Alberto Lopez Perez.
3556
3557         Set WEBKIT_INJECTED_BUNDLE_PATH when running WPE MiniBrowser.
3558
3559         * Scripts/run-minibrowser:
3560
3561 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
3562
3563         [WPE] libgstggtk.so broken in jhbuild environment
3564         https://bugs.webkit.org/show_bug.cgi?id=184984
3565
3566         Reviewed by Carlos Alberto Lopez Perez.
3567
3568         Don't pass --enable-glx=no when building libepoxy, to ensure it's compatible with
3569         gst-plugins-good.
3570
3571         * wpe/jhbuild.modules:
3572
3573 2018-04-25  Ryosuke Niwa  <rniwa@webkit.org>
3574
3575         PSON: Don't create a new process when navigating to a blob URL, data URL, and about:blank
3576         https://bugs.webkit.org/show_bug.cgi?id=184962
3577
3578         Reviewed by Youenn Fablet.
3579
3580         Added four test cases for navigating to a blob URL, data URL, and about:blank with process-swap-on-navigation turned on.
3581
3582         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3583         (ProcessSwap.SameOriginBlobNavigation): Added.
3584         (ProcessSwap.CrossOriginBlobNavigation): Added.
3585         (ProcessSwap.NavigateToAboutBlank): Added.
3586         (ProcessSwap.NavigateToDataURL): Added.
3587
3588 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
3589
3590         [WPE] Remove deprecated functions and properties from the API
3591         https://bugs.webkit.org/show_bug.cgi?id=179295
3592
3593         Reviewed by Žan Doberšek.
3594
3595         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
3596         (testWebViewAuthenticationStorage): Disable this test for now. It will require some effort
3597         to rewrite LoadTrackingTest to not require the web view at construction time.
3598         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3599         (testWebKitSettings): Don't test private browsing setting, which is gone.
3600         * TestWebKitAPI/glib/CMakeLists.txt: Disable TestCookieManager for now.
3601
3602 2018-04-25  Andy Estes  <aestes@apple.com>
3603
3604         [Mac] Number of drop items is always 0 when performing a DHTML drag
3605         https://bugs.webkit.org/show_bug.cgi?id=184943
3606
3607         Reviewed by Ryosuke Niwa.
3608
3609         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3610         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:
3611         (-[DragInfo numberOfValidItemsForDrop]):
3612         (-[DragInfo setNumberOfValidItemsForDrop:]):
3613         (TestWebKitAPI::TEST):
3614         * TestWebKitAPI/Tests/mac/full-page-dropzone.html: Added.
3615
3616 2018-04-25  Jonathan Bedard  <jbedard@apple.com>
3617
3618         API test harness should be Python
3619         https://bugs.webkit.org/show_bug.cgi?id=181043
3620         <rdar://problem/36164410>
3621
3622         Reviewed by David Kilzer.
3623
3624         Run API tes