2011-05-31 Mikhail Naganov <mnaganov@chromium.org>
[WebKit-https.git] / Tools / ChangeLog
1 2011-05-31  Hao Zheng  <zhenghao@chromium.org>
2
3         Reviewed by Dirk Pranke.
4
5         Fix exception in verbose printing mode.
6         https://bugs.webkit.org/show_bug.cgi?id=61723
7
8         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
9
10 2011-05-31  Yong Li  <yoli@rim.com>
11
12         Reviewed by Eric Seidel.
13
14         https://bugs.webkit.org/show_bug.cgi?id=54807
15         We have been assuming plain bitfields (like "int a : 31") are always signed integers.
16         However some compilers can treat them as unsigned. For example, RVCT 4.0 states plain
17         bitfields (declared without either signed or unsigned qualifiers) are treats as unsigned.
18         http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0348c/Babjddhe.html
19         Although we can use "--signed-bitfields" flag to make RVCT 4.0 behave as most other compilers,
20         always using "signed"/"unsigned" qualifier to declare integral type bitfields is still a good
21         rule we should have in order to make our code independent from compilers and compiler flags.
22
23         * Scripts/webkitpy/style/checkers/cpp.py:
24
25 2011-05-31  Hironori Bono  <hbono@chromium.org>
26
27         Reviewed by Eric Seidel.
28
29         Add a JavaScript function layoutTestController.setTextDirection().
30         https://bugs.webkit.org/show_bug.cgi?id=50952
31
32         This change adds a new JavaScript function setTextDirection() to the
33         LayoutTestController class of Safari and Chrome to write layout tests
34         that changes the text direction of an editable element.
35
36         * DumpRenderTree/LayoutTestController.cpp:
37         (setTextDirectionCallback):
38         (LayoutTestController::staticFunctions):
39         * DumpRenderTree/LayoutTestController.h:
40         * DumpRenderTree/chromium/LayoutTestController.cpp:
41         (LayoutTestController::LayoutTestController):
42         (LayoutTestController::setTextDirection):
43         * DumpRenderTree/chromium/LayoutTestController.h:
44         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
45         (LayoutTestController::setTextDirection):
46         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
47         (LayoutTestController::setTextDirection):
48         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
49         (LayoutTestController::setTextDirection):
50
51 2011-05-31  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
52
53         Reviewed by Simon Hausmann.
54
55         [Qt] User-agent list of Qt test browsers is very outdated
56         https://bugs.webkit.org/show_bug.cgi?id=61531
57
58         The user can edit the user-agent manually, so there's no need to have
59         a super complete and up to date list, but it's nice to have it
60         minimally updated.
61
62         * MiniBrowser/qt/useragentlist.txt:
63         * QtTestBrowser/useragentlist.txt:
64
65 2011-03-30  Martin Robinson  <mrobinson@igalia.com>
66
67         Reviewed by Adam Roben.
68
69         [GTK] [WebKit2] Implement a basic WebKitTestRunner
70         https://bugs.webkit.org/show_bug.cgi?id=57068
71
72         Add an implementation of WebKitTestRunner for GTK+.
73
74         * Scripts/build-webkittestrunner: Added knowledge of GTK+ TestRunner.
75         * Scripts/old-run-webkit-tests: Ditto.
76         * Scripts/run-launcher: Ditto.
77         * Scripts/webkitdirs.pm: Ditto.
78         * WebKitTestRunner/GNUmakefile.am: Added.
79         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
80         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp: Added.
81         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
82         * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
83         * WebKitTestRunner/PlatformWebView.h:
84         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Added.
85         * WebKitTestRunner/gtk/TestControllerGtk.cpp: Added.
86         * WebKitTestRunner/gtk/TestInvocationGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
87         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
88         * WebKitTestRunner/gtk/main.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
89         (main): Added.
90
91 2011-05-31  Dirk Pranke  <dpranke@chromium.org>
92
93         Reviewed by Tony Chang.
94
95         new-run-webkit-tests: doesn't wait for children if it gets a ctrl-c
96         https://bugs.webkit.org/show_bug.cgi?id=60241
97
98         * Scripts/new-run-webkit-tests:
99
100 2011-05-31  Eric Seidel  <eric@webkit.org>
101
102         Reviewed by David Kilzer.
103
104         webkitpy should create zips with zip -9
105         https://bugs.webkit.org/show_bug.cgi?id=61789
106
107         Dave Kilzer suggested we add this to make zips uploaded to bugzilla smaller.
108
109         * Scripts/webkitpy/common/system/workspace.py:
110         * Scripts/webkitpy/common/system/workspace_unittest.py:
111
112 2011-05-31  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
113
114         Reviewed by Csaba Osztrogonác.
115
116         [Qt] Implement find feature for QtTestBrowser
117         https://bugs.webkit.org/show_bug.cgi?id=61425
118
119         Buildfix for --minimal and CONFIG+=qt_minimal build.
120
121         * QtTestBrowser/launcherwindow.cpp:
122         (LauncherWindow::LauncherWindow):
123         (LauncherWindow::createChrome):
124         * QtTestBrowser/launcherwindow.h:
125
126 2011-05-31  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
127
128         Reviewed by Csaba Osztrogonác.
129
130         [Qt] Implement find feature for QtTestBrowser
131         https://bugs.webkit.org/show_bug.cgi?id=61425
132
133         * QtTestBrowser/launcherwindow.cpp:
134         (LauncherWindow::LauncherWindow):
135         (LauncherWindow::createChrome):
136         (LauncherWindow::showFindBar):
137         (LauncherWindow::find):
138         * QtTestBrowser/launcherwindow.h:
139
140 2011-05-30  Carlos Garcia Campos  <cgarcia@igalia.com>
141
142         Reviewed by Martin Robinson.
143
144         [GTK] Implement JavaScript dialogs in MiniBrowser
145         https://bugs.webkit.org/show_bug.cgi?id=61725
146
147         * MiniBrowser/gtk/BrowserWindow.c:
148         (WKStringGetCString): Helper function to get a UTF-8 c string from
149         a WKStringRef.
150         (WKURLGetCString): Helper function to get a UTF-8 c string from a
151         WKURLRef.
152         (browserWindowUpdateURL): Update to use WKURLGetCString.
153         (didReceiveTitleForFrame): Update to use WKStringGetCString.
154         (createMessageDialog): Create a GtkMessageDialog.
155         (runJavaScriptAlert):
156         (runJavaScriptConfirm):
157         (runJavaScriptPrompt):
158         (browserWindowUIClientInit):
159
160 2011-05-29  Yuta Kitamura  <yutak@chromium.org>
161
162         Reviewed by Kent Tamura.
163
164         WebSocket closing handshake
165         https://bugs.webkit.org/show_bug.cgi?id=35721
166
167         * Scripts/webkitpy/thirdparty/__init__.py:
168         Pull in pywebsocket 0.6b1. We need to update pywebsocket
169         to get the right behavior of closing handshake.
170
171 2011-05-29  Daniel Bates  <dbates@rim.com>
172
173         Reviewed by David Kilzer.
174
175         REGRESSION (r86515): svn-apply ignores diffs that omit line count in chunk range
176         https://bugs.webkit.org/show_bug.cgi?id=61162
177
178         Fixes an issue where svn-apply may ignore a diff that contains a chunk range line
179         that omits a line count. In particular, the chunk range regular expression does
180         not match a chunk range line that omits a line count. GNU diff(1) will omit the
181         line count in the chunk range if the line count is exactly 1. For example, appending
182         a new line to the end of an existing file F that contains exactly one line of text will
183         be represented in a diff with a chunk range line that omits the line count for F.
184
185         * Scripts/VCSUtils.pm:
186           (parseChunkRange): Added.
187         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl: Added.
188         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
189           - Added unit test "Git: Append new line to the end of an existing file".
190
191 2011-05-28  Adam Barth  <abarth@webkit.org>
192
193         Reviewed by Eric Seidel.
194
195         EWS builds patches that fail to build twice, which seems useless and slows down the bots
196         https://bugs.webkit.org/show_bug.cgi?id=55585
197
198         This patch switches all the early warning system bots over to the new
199         PatchAnalysisTask-based infrastructure.  This patch makes these bots
200         more efficient (in the case where patches fail to build) and paves the
201         way for running tests on these bots!
202
203         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
204         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
205         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
206         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
207         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
208         * Scripts/webkitpy/tool/commands/queues.py:
209
210 2011-05-28  Kenichi Ishibashi  <bashi@chromium.org>
211
212         Reviewed by Kent Tamura.
213
214         Add bashi as a committer.
215
216         https://bugs.webkit.org/show_bug.cgi?id=61685
217
218         * Scripts/webkitpy/common/config/committers.py:
219
220 2011-05-27  Adam Barth  <abarth@webkit.org>
221
222         Reviewed by Eric Seidel.
223
224         When checking whether the tree is red, the EWS posts a link to the wrong log
225         https://bugs.webkit.org/show_bug.cgi?id=61072
226
227         We need to cache the original script error because that contains the
228         failure log we want to upload.  If we don't cache that script error,
229         self._script_error will get overwritten when we sanity check the clean
230         tree (and it also has test failures).
231
232         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
233             - This testing approach is slightly goofy.  We'd like to use
234               assertRaisesRegexp, but that's not available until Python 2.7.
235         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
236
237 2011-05-27  Jochen Eisinger  <jochen@chromium.org>
238
239         Reviewed by Adam Barth.
240
241         Add layoutTestController.setStorageAllowed() to control whether access
242         to the localStorage API is enabled via the WebPermissionClient
243         https://bugs.webkit.org/show_bug.cgi?id=61581
244
245         * DumpRenderTree/chromium/LayoutTestController.cpp:
246         (LayoutTestController::LayoutTestController):
247         (LayoutTestController::setStorageAllowed):
248         * DumpRenderTree/chromium/LayoutTestController.h:
249         * DumpRenderTree/chromium/TestShell.cpp:
250         (TestShell::TestShell):
251         (TestShell::createNewWindow):
252         * DumpRenderTree/chromium/TestShell.h:
253         * DumpRenderTree/chromium/WebPermissions.h: Added.
254         (WebPermissions::WebPermissions):
255         (WebPermissions::allowStorage):
256         (WebPermissions::setStorageAllowed):
257         (WebPermissions::reset):
258
259 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
260
261         Reviewed by Eric Seidel.
262
263         NRWT: clean up metered_stream code in preparation for 'nooverwriting' patch
264         https://bugs.webkit.org/show_bug.cgi?id=60326
265
266         This patch removes a lot of the complexity from the
267         metered_stream implementation that was unnecessary since there
268         was only one caller and the logic could be coordinated better.
269
270         There should be no functional changes in this patch, just code
271         getting deleted and cleaned up.
272
273         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
274         * Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py:
275         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
276         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
277
278 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
279
280         Reviewed by Eric Seidel.
281
282         NRWT: minor cleanup in printing module
283         https://bugs.webkit.org/show_bug.cgi?id=60329
284
285         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
286
287 2011-05-27  Steve Lacey  <sjl@chromium.org>
288
289         Reviewed by David Levin.
290
291         Add sjl@chromium.org as a committer.
292
293         https://bugs.webkit.org/show_bug.cgi?id=61672
294
295         * Scripts/webkitpy/common/config/committers.py:
296
297 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
298
299         Reviewed by Adam Barth.
300
301         NRWT: remove --print detailed-progress
302         https://bugs.webkit.org/show_bug.cgi?id=60324
303
304         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
305         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
306         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
307         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
308
309 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
310
311         Reviewed by Ojan Vafai.
312
313         NRWT: debug messages from the workers are being logged twice
314         https://bugs.webkit.org/show_bug.cgi?id=60428
315
316         It looks like when the workers are run in separate processes
317         we end up getting two copies of every log message they print.
318         This has to do with the multiprocessing module on UNIX cloning
319         the log configuration in a way I wasn't expecting, and so two
320         log handlers end up getting registered.
321
322         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
323         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
324         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
325         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
326
327 2011-05-27  Adam Roben  <aroben@apple.com>
328
329         Always decode tester names from location.hash
330
331         When navigating directly to a tester-specific URL (e.g.,
332         <http://build.webkit.org/TestFailures/#/Windows%207%20Release%20(Tests)>), you could end up
333         with a URL-encoded tester name in the page, and then the encoded name could make its way
334         into Bugzilla bugs. Bad!
335
336         Reviewed by David Kilzer.
337
338         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
339         (ViewController.prototype.parseHash): Pass the tester name we got from location.hash through
340         decodeURIComponent before trying to use it.
341
342 2011-05-27  Adam Roben  <aroben@apple.com>
343
344         Remove testing code that snuck into r87528
345
346         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
347         (ViewController.prototype._domForNewBugLink): Remove a line I was using for some testing.
348
349 2011-05-27  Adam Roben  <aroben@apple.com>
350
351         Add links to TestFailures to easily file bugs about failing tests
352
353         Fixes <http://webkit.org/b/61636> <rdar://problem/9514886> TestFailures page should have
354         links to file bugs for failing tests
355
356         Reviewed by David Kilzer.
357
358         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
359         (Builder.prototype.resultsPageURL): New helper function to return the URL to results.html
360         for a particular build.
361         (Builder.prototype._getFailingTests): Use resultsPageURL.
362
363         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
364         (ViewController.prototype._displayBuilder): Add links to file bugs about each set of
365         failures.
366         (ViewController.prototype._domForBuildName): Use resultsPageURL.
367         (ViewController.prototype._domForNewBugLink): Added. Creates an element that represents the
368         new bug link. The bug has a title, description, and URL already filled in for you!
369
370 2011-05-27  Sheriff Bot  <webkit.review.bot@gmail.com>
371
372         Unreviewed, rolling out r87464.
373         http://trac.webkit.org/changeset/87464
374         https://bugs.webkit.org/show_bug.cgi?id=61643
375
376         client-close/server-close tests are flaky on Chromium Mac and
377         Windows (Requested by aklein on #webkit).
378
379         * Scripts/webkitpy/thirdparty/__init__.py:
380
381 2011-05-27  Alexey Proskuryakov  <ap@apple.com>
382
383         Added Douglas Davidson to contributors list for easier CC'ing.
384
385         * Scripts/webkitpy/common/config/committers.py:
386
387 2011-05-26  Mihai Parparita  <mihaip@chromium.org>
388
389         Reviewed by Adam Barth.
390
391         Fix worldID and destinationDomain argument names
392         https://bugs.webkit.org/show_bug.cgi?id=61571
393
394         As part of working on r87423, I noticed a couple of inconsistencies in
395         argument names:
396         - We would use worldId in .h files but worldID in .cpp files.
397           Standardize on the latter
398         - SecurityOrigin::addOriginAccessWhitelistEntry would take a
399           destinationDomains argument, even though the actual parameter was for
400           a single domain (renamed to be singular).
401
402         * DumpRenderTree/LayoutTestController.h:
403         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
404         (LayoutTestController::evaluateScriptInIsolatedWorld):
405
406 2011-05-26  Yuta Kitamura  <yutak@chromium.org>
407
408         Reviewed by Kent Tamura.
409
410         WebSocket closing handshake
411         https://bugs.webkit.org/show_bug.cgi?id=35721
412
413         * Scripts/webkitpy/thirdparty/__init__.py:
414         Pull in pywebsocket 0.6b1. We need to update pywebsocket
415         to get the right behavior of closing handshake.
416
417 2011-05-26  Qi Zhang  <qi.2.zhang@nokia.com>
418
419         Reviewed by Andreas Kling.
420
421         WebKitTestRunner needs layoutTestController.setAuthorAndUserStylesEnabled
422         https://bugs.webkit.org/show_bug.cgi?id=42676
423
424         Implemented layoutTestController.setAuthorAndUserStylesEnabled for WebKitTestRunner.
425
426         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
427         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
428         (WTR::InjectedBundle::beginTesting):
429         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
430         (WTR::LayoutTestController::setAuthorAndUserStylesEnabled):
431         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
432
433 2011-05-26  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
434
435         Reviewed by Andreas Kling.
436
437         [Qt] QtTestBrowser "Switch User Agent" dialog is broken
438         https://bugs.webkit.org/show_bug.cgi?id=61527
439
440         The setMaximumHeight() call is unecessary and breaks the dialog at
441         least on my setup.
442
443         * QtTestBrowser/launcherwindow.cpp:
444         (LauncherWindow::showUserAgentDialog):
445
446 2011-05-02  Robert Hogan  <robert@webkit.org>
447
448         Reviewed by Adam Roben.
449
450         [Qt] Allow popup windows from plugins when initiated by a user gesture
451
452         https://bugs.webkit.org/show_bug.cgi?id=41292
453
454         Support parameters introduced in plugin-initiate-popup-window.html
455
456         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
457         (webkit_test_plugin_new_instance):
458         (webkit_test_plugin_handle_event):
459
460 2011-05-26  Mihai Parparita  <mihaip@chromium.org>
461
462         Reviewed by Adam Barth.
463
464         Support cross-origin XMLHttpRequest in isolated worlds
465         https://bugs.webkit.org/show_bug.cgi?id=59843
466
467         Expose setIsolatedWorldSecurityOrigin in LayoutTestController.
468
469         * DumpRenderTree/chromium/LayoutTestController.cpp:
470         (LayoutTestController::LayoutTestController):
471         (LayoutTestController::setIsolatedWorldSecurityOrigin):
472         * DumpRenderTree/chromium/LayoutTestController.h:
473
474 2011-05-25  Brian Weinstein  <bweinstein@apple.com>
475
476         Reviewed by Adam Roben.
477
478         WebKit2: Status bar, toolbar, and menu bar checks should be in the injected bundle
479         https://bugs.webkit.org/show_bug.cgi?id=61474
480         <rdar://problem/9468337>
481
482         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
483         (WTR::InjectedBundlePage::InjectedBundlePage): Add empty entries in the WKBundlePageUIClient.
484
485 2011-05-26  Andreas Kling  <kling@webkit.org>
486
487         Unreviewed, correct address to webkit-committers mailing list.
488
489         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
490
491 2011-05-25  Adam Roben  <aroben@apple.com>
492
493         Don't assume that builds finish in the order they were started
494
495         Fixes <http://webkit.org/b/61464> TestFailures page shows failures from a not-most-recent
496         build when one slave is taking a long time to finish a build
497
498         Reviewed by Antti Koivisto.
499
500         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
501         (Builder.prototype.getMostRecentCompletedBuildNumber): Don't assume that all builds that are
502         newer than the oldest in-progress build are also themselves in progress. Just check whether
503         each build is actually in progress (as signified by its presence in the currentBuilds set).
504
505 2011-05-25  Adam Roben  <aroben@apple.com>
506
507         Correctly detect cases where only a single test failed/crashed/timed out
508
509         Fixes <http://webkit.org/b/61463> TestFailures page doesn't show testers with only a single
510         failing test
511
512         Reviewed by Darin Adler.
513
514         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
515         (Builder.prototype.getNumberOfFailingTests): Don't require "test cases" to be plural. It
516         will be singular when only a single test fails/crashes/times out.
517
518         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
519         (ViewController.prototype._displayTesters): Only pluralize "test" when more than one test
520         failed/crashed/timed out.
521
522 2011-05-26  Tom Hudson  <tomhudson@google.com>
523
524         Reviewed by Tony Chang.
525
526         Add flags to Chromium ImageDiff to write image comparison metrics on
527         stdout.
528         https://bugs.webkit.org/show_bug.cgi?id=60569
529
530         * DumpRenderTree/chromium/ImageDiff.cpp:
531         (Image::createFromStdin): Fix spelling.
532         (maxOf3): New function to do 3-way maximum.
533         (getRedComponent): Extract red component from ABGR packed encoding.
534         (getGreenComponent): Extract green component from ABGR packed encoding.
535         (getBlueComponent): Extract blue component from ABGR packed encoding.
536         (weightedPercentageDifferent): Determine % of pixels different in two
537         images multiplied by intensity difference of each pixel.
538         (printHelp): Document new arguments.
539         (compareImages): Parameterize.
540         (untestedCompareImages): Parameterize.
541         (diffImages): Parameterize; write results on stdout if requested.
542         (main): Parse new arguments.
543
544 2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>
545
546         Reviewed by Simon Hausmann.
547
548         WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
549         https://bugs.webkit.org/show_bug.cgi?id=42697
550
551         Implemented layoutTestController.setPrivateBrowsingEnabled for WebKitTestRunner.
552
553         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
554         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
555         (WTR::InjectedBundle::beginTesting):
556         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
557         (WTR::LayoutTestController::setPrivateBrowsingEnabled):
558         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
559
560 2011-05-25  Jon Honeycutt  <jhoneycutt@apple.com>
561
562         REGRESSION (WebKit2): Crash in Flash on USA Today photo gallery
563         https://bugs.webkit.org/show_bug.cgi?id=61428
564         <rdar://problem/9457006>
565
566         Reviewed by Adam Roben.
567
568         The crash occurs when Flash posts a message to a window that it
569         creates, and in processing the message, it calls NPN_Evaluate to
570         evaluate JavaScript that removes the plug-in from the page. Flash then
571         crashes when we return to Flash code.
572
573         This test emulates that behavior.
574
575         * DumpRenderTree/TestNetscapePlugIn/win/CallJSThatDestroysPlugin.cpp: Added.
576         (CallJSThatDestroysPlugin::CallJSThatDestroysPlugin):
577         Initialize member vars.
578         (CallJSThatDestroysPlugin::~CallJSThatDestroysPlugin):
579         Remove our custom property from the message window, and destroy it.
580         (CallJSThatDestroysPlugin::NPP_Destroy):
581         Set m_isDestroyed, log that the plug-in was destroyed, and notify the
582         layout test controller that we're done.
583         (wndProc):
584         Get the PluginTest object, and call its runTest() function.
585         (CallJSThatDestroysPlugin::NPP_New):
586         Setup the test: register a class for the message-only window, create
587         it, and post a message to it to run the test.
588         (CallJSThatDestroysPlugin::runTest):
589         Execute JS that removes the plug-in from the page, and if we're not
590         destroyed, log a success message.
591
592         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
593         Add new test to project.
594
595 2011-05-25  Tony Chang  <tony@chromium.org>
596
597         Reviewed by Adam Barth.
598
599         webkitpy's NetworkTransaction shouldn't use mechanize
600         https://bugs.webkit.org/show_bug.cgi?id=61450
601
602         mechanize.HTTPError is just an alias for urllib2.HTTPError, so
603         use urllib2 directly.  Re-add NetworkTransaction to
604         test_results_uploader.py (reverting r87124).
605
606         * Scripts/webkitpy/common/net/networktransaction.py:
607         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
608
609 2011-05-25  Kevin Ollivier  <kevino@theolliviers.com>
610
611         [Chromium] Unreviewed build fix. Do not define WTF/JS_EXPORT_PRIVATE to JS_EXPORTDATA
612         until the port begins using those export macros.
613
614         * DumpRenderTree/chromium/config.h:
615
616 2011-05-25  Sheriff Bot  <webkit.review.bot@gmail.com>
617
618         Unreviewed, rolling out r87257.
619         http://trac.webkit.org/changeset/87257
620         https://bugs.webkit.org/show_bug.cgi?id=61457
621
622         This broke layout tests, see bug 61431. (Requested by
623         hwennborg on #webkit).
624
625         * DumpRenderTree/chromium/LayoutTestController.cpp:
626         (LayoutTestController::LayoutTestController):
627         (LayoutTestController::clearAllDatabases):
628         * DumpRenderTree/chromium/LayoutTestController.h:
629
630 2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>
631
632         Reviewed by Andreas Kling.
633
634         [Qt] fast/css/disabled-author-styles.html failed
635         https://bugs.webkit.org/show_bug.cgi?id=61438
636
637         Implemented API setAuthorAndUserStylesEnabled in LayoutTestControllerQt.
638
639         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
640         (WebCore::WebPage::resetSettings):
641         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
642         (LayoutTestController::setAuthorAndUserStylesEnabled):
643         * DumpRenderTree/qt/LayoutTestControllerQt.h:
644
645 2011-05-25  Adam Roben  <aroben@apple.com>
646
647         Identify, rather than skip, builds where run-webkit-tests exited early due to too many failures
648
649         Fixes <http://webkit.org/b/61441> TestFailures page should show when run-webkit-tests
650         started exiting early due to too many crashes, timeouts, or failures
651
652         Reviewed by David Kilzer.
653
654         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
655         (Builder.prototype.getNumberOfFailingTests): Rather than returning -1 ("unknown") when
656         run-webkit-tests exits early due to too many failures, pass that information in another
657         argument to the callback.
658         (Builder.prototype.startFetchingBuildHistory): Updated the documentation comment to reflect
659         the new structure of the object passed to the callback.
660         (Builder.prototype._getFailingTests): Updated to expect a tooManyFailures boolean from
661         getNumberOfFailingTests and to pass that along to our own callbacks.
662         (Builder.prototype._incorporateBuildHistory): Updated to expect a tooManyFailures boolean
663         from _getFailingTests and to store that value in the history object.
664
665         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
666         (.info): Added.
667
668         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
669         (ViewController.prototype._displayBuilder): Updated for change in structure to the history
670         object and to add a note when run-webkit-tests exited early due to too many failures.
671         (ViewController.prototype._displayTesters): Renamed testersAndFailureCounts to
672         latestBuildInfos since each entry now contains more than just the tester and failure count.
673         Now displays a message for testers where the latest build exited early due to too many
674         failures. Updated to expect a tooManyFailures boolean from getNumberOfFailingTests and to
675         store that value in latestBuildInfos.
676
677 2011-05-24  Keishi Hattori  <keishi@webkit.org>
678
679         Reviewed by Kent Tamura.
680
681         Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
682         https://bugs.webkit.org/show_bug.cgi?id=61273
683
684         * Scripts/build-webkit: Added INPUT_COLOR feature flag.
685
686 2011-05-24  Greg Simon  <gregsimon@chromium.org>
687
688         Reviewed by Dimitri Glazkov.
689
690         Control Indexeddb backends from LayoutTestController
691         https://bugs.webkit.org/show_bug.cgi?id=61000
692
693         * DumpRenderTree/chromium/LayoutTestController.cpp:
694         (LayoutTestController::LayoutTestController):
695         (LayoutTestController::setOverrideIndexedDBBackingStore):
696         (LayoutTestController::clearAllDatabases):
697         * DumpRenderTree/chromium/LayoutTestController.h:
698
699 2011-05-24  Robert Hogan  <robert@webkit.org>
700
701         Reviewed by Ryosuke Niwa.
702
703         [Qt] Fix fast/events/selectstart-by-single-click-with-shift.html
704         https://bugs.webkit.org/show_bug.cgi?id=61393
705
706         * DumpRenderTree/qt/EventSenderQt.h:
707         * DumpRenderTree/qt/EventSenderQt.cpp:
708         (getModifiers): static function for interpreting modifiers
709         (EventSender::mouseDown): Respect keyboard modifiers
710         (EventSender::keyDown): use new static function
711         (EventSender::sendOrQueueEvent): whitespace fix
712
713 2011-05-24  Jay Civelli  <jcivelli@chromium.org>
714
715         Reviewed by Adam Barth.
716
717         Adding MHTML reading support.
718         https://bugs.webkit.org/show_bug.cgi?id=7168
719
720         * Scripts/build-webkit:
721         * Scripts/old-run-webkit-tests:
722         * Scripts/webkitperl/features.pm:
723         * Scripts/webkitpy/layout_tests/port/test_files.py:
724         * Scripts/webkitpy/layout_tests/port/webkit.py:
725
726 2011-05-24  Stephen White  <senorblanco@chromium.org>
727
728         Reviewed by Kenneth Russell.
729
730         Remove most style checks on Source/ThirdParty/glu, since it doesn't
731         follow WebKit style.
732         https://bugs.webkit.org/show_bug.cgi?id=61365
733
734         * Scripts/webkitpy/style/checker.py:
735
736 2011-05-24  Adam Roben  <aroben@apple.com>
737
738         Don't allow forcing builds through the build.webkit.org web interface
739
740         Someone has been forcing bogus builds.
741
742         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
743
744 2011-05-24  Qi Zhang  <qi.2.zhang@nokia.com>
745
746         Reviewed by Adam Roben.
747
748         WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
749         https://bugs.webkit.org/show_bug.cgi?id=42669
750
751         Fixes the regression issue caused by patch 94265. The patch didn't intialize the setting before the 
752         layouttest starting, it will make the test cases after editing/execCommand/clipboard-access.html failed.
753         Because that case changed the setting.
754
755         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
756         (WTR::InjectedBundle::beginTesting):
757
758 2011-05-24  Csaba Osztrogonác  <ossy@webkit.org>
759
760         Reviewed by Kenneth Rohde Christiansen.
761
762         [ORWT]Make --skipped=only option work with parameters with LayoutTests/ prefix
763         https://bugs.webkit.org/show_bug.cgi?id=61052
764
765         * Scripts/old-run-webkit-tests:
766
767 2011-05-24  Adam Roben  <aroben@apple.com>
768
769         Make TestFailures show how many tests are failing on each tester, and omit testers with no failures
770
771         Fixes <http://webkit.org/b/61063> <rdar://problem/9460533> TestFailures page shows testers
772         that don't have any failing tests, which isn't useful
773
774         Reviewed by David Kilzer.
775
776         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js:
777         (Buildbot.prototype.getTesters): Renamed from getTesterNames. Now returns Builder objects
778         instead of name strings.
779         (Buildbot.prototype._buildersForNames): Added. Helper function to convert an array of
780         builder names into an array of builders.
781
782         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
783         (Builder.prototype.getMostRecentCompletedBuildNumber): Added. Returns the build number of
784         the most recently completed build, or -1 if there is no such build.
785         (Builder.prototype.getNumberOfFailingTests): Added. Returns the number of tests that failed
786         in the given build, or -1 if the number could not be determined. Some of this code came from
787         _getFailingTests.
788         (Builder.prototype._getBuildJSON): Added. Code came from _getFailingTests.
789         (Builder.prototype._getFailingTests): Changed to use new _getBuildJSON and
790         getNumberOfFailingTests functions.
791
792         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
793         (ViewController.prototype._displayTesters): Get the current number of test failures for each
794         tester and show it in the list. Omit testers that have no failures at all. We keep the
795         testers and failure counts in an array and sort it before displaying the current data, as
796         the order in which data will be fetched is unpredictable.
797
798 2011-05-23  Tony Chang  <tony@chromium.org>
799
800         Reviewed by Ojan Vafai.
801
802         [nrwt] don't use NetworkTranslation when uploading results
803         https://bugs.webkit.org/show_bug.cgi?id=61315
804
805         This avoids autoinstalling mechanize.  It didn't matter anyway
806         because test_results_uploader.py wasn't using mechanize to make the
807         request so NetworkTransaction::run wasn't doing anything extra
808         (it only matters if it catches mechanize.HTTPError).
809
810         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
811
812 2011-05-23  Tony Chang  <tony@chromium.org>
813
814         Reviewed by Dirk Pranke.
815
816         [chromium] fix the rebaseline tool to work with Linux GPU failures
817         https://bugs.webkit.org/show_bug.cgi?id=61312
818
819         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
820
821 2011-05-23  Darin Adler  <darin@apple.com>
822
823         Ignore generated .pyc files in a directory full of python code.
824
825         * Scripts/webkitpy/common/checkout/scm: Added property svn:ignore.
826
827 2011-05-23  Adam Barth  <abarth@webkit.org>
828
829         Reviewed by Eric Seidel.
830
831         sheriffbot should give more details about the failures in IRC
832         https://bugs.webkit.org/show_bug.cgi?id=61233
833
834         With this patch, sheriffbot will annonce the set of failing tests,
835         which might help folks triage the problem.
836
837         * Scripts/webkitpy/tool/commands/sheriffbot.py:
838         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
839
840 2011-05-23  Sheriff Bot  <webkit.review.bot@gmail.com>
841
842         Unreviewed, rolling out r87078.
843         http://trac.webkit.org/changeset/87078
844         https://bugs.webkit.org/show_bug.cgi?id=61294
845
846         Patch contains errors and seems likely to break a bunch of
847         bots (Requested by abarth on #webkit).
848
849         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
850         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
851         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
852
853 2011-05-23  Alice Boxhall  <aboxhall@chromium.org>
854
855         Reviewed by Ojan Vafai.
856
857         Convert json_results_generator.py to output version 4 JSON.
858         https://bugs.webkit.org/show_bug.cgi?id=60869
859
860         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
861         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
862         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
863
864 2011-05-23  Patrick Gansterer  <paroga@webkit.org>
865
866         Reviewed by Adam Barth.
867
868         Move generation of shell_command from port to executive
869         https://bugs.webkit.org/show_bug.cgi?id=61251
870
871         After move it's possible to use the code in other places too.
872
873         * Scripts/webkitpy/common/config/ports.py:
874         * Scripts/webkitpy/common/system/executive.py:
875
876 2011-05-23  Qi Zhang  <qi.2.zhang@nokia.com>
877
878         Reviewed by Darin Adler.
879
880         WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
881         https://bugs.webkit.org/show_bug.cgi?id=42669
882
883         Implement setJavaScriptCanAccessClipboard in WebKitTestRunner.
884
885         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
886         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
887         (WTR::LayoutTestController::setJavaScriptCanAccessClipboard):
888         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
889
890 2011-05-22  Robert Hogan  <robert@webkit.org>
891
892         Reviewed by Kenneth Rohde Christiansen.
893
894         Fix policyDelegate in Qt DRT
895         https://bugs.webkit.org/show_bug.cgi?id=61247
896
897         Use the 'policy delegate' implemented in FrameLoaderClient
898         for layout tests. The partial implementation in DumpRenderTreeQt
899         is redundant, so remove it.
900
901         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
902         (WebCore::WebPage::acceptNavigationRequest):
903         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
904         (LayoutTestController::waitForPolicyDelegate):
905
906 2011-05-22  Patrick Gansterer  <paroga@webkit.org>
907
908         Reviewed by Darin Adler.
909
910         Use double quotes for filename arguments
911         https://bugs.webkit.org/show_bug.cgi?id=61250
912
913         Windows does not support single quotes on the command line,
914         so replace them with double quotes.
915
916         * Scripts/prepare-ChangeLog:
917
918 2011-05-20  Simon Fraser  <simon.fraser@apple.com>
919
920         Reviewed by Sam Weinig.
921
922         WebKitTestRunner needs layoutTestController.pauseTransitionAtTimeOnElementWithId
923         https://bugs.webkit.org/show_bug.cgi?id=42550
924         
925         Implement pauseTransitionAtTimeOnElementWithId in WebKitTestRunner.
926
927         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
928         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
929         Copy the code for pausing animations, FIXME comments and all.
930         (WTR::LayoutTestController::pauseTransitionAtTimeOnElementWithId):
931         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
932
933 2011-05-20  Alok Priyadarshi  <alokp@chromium.org>
934
935         Reviewed by Stephen White.
936
937         Adding myself to the committers list.
938
939         * Scripts/webkitpy/common/config/committers.py:
940
941 2011-05-19  Adam Roben  <aroben@apple.com>
942
943         Test that the WebKit2 UI process doesn't crash when starting a download
944
945         Test for <http://webkit.org/b/61142> <rdar://problem/9471680> REGRESSION (r86812): Crash
946         (preceded by assertion) in fastMalloc when downloading a file
947
948         Reviewed by Darin Adler.
949
950         * TestWebKitAPI/Tests/WebKit2/18-characters.html: Added.
951
952         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp: Added.
953         (TestWebKitAPI::decidePolicyForNavigationAction): Start a download.
954         (TestWebKitAPI::decideDestinationWithSuggestedFilename): Record that the download was
955         started, cancel the download, and return a bogus string.
956
957         (TestWebKitAPI::setContextDownloadClient):
958         (TestWebKitAPI::setPagePolicyClient):
959         Simple helper functions.
960
961         (TestWebKitAPI::TEST): Load 18-characters.html, which should trigger a download thanks to
962         our policy client, and run until we know that the download was started. If we haven't
963         crashed, we win!
964
965         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
966         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
967         * TestWebKitAPI/win/copy-resources.cmd:
968         Added new files.
969
970 2011-05-20  Kent Tamura  <tkent@chromium.org>
971
972         Reviewed by Ryosuke Niwa.
973
974         Fix style errors in DumpRenderTree/chromium/.
975         https://bugs.webkit.org/show_bug.cgi?id=61172
976
977         * DumpRenderTree/chromium/CppBoundClass.cpp:
978         (CppBoundClass::getAsCppVariant):
979         (CppBoundClass::bindToJavascript):
980         * DumpRenderTree/chromium/CppBoundClass.h:
981         (CppBoundClass::GetterCallback::~GetterCallback):
982         (CppBoundClass::CppBoundClass):
983         (CppBoundClass::Callback::~Callback):
984         (CppBoundClass::MemberCallback::MemberCallback):
985         (CppBoundClass::MemberCallback::~MemberCallback):
986         (CppBoundClass::MemberGetterCallback::MemberGetterCallback):
987         (CppBoundClass::MemberGetterCallback::~MemberGetterCallback):
988         * DumpRenderTree/chromium/CppVariant.h:
989         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
990         (DRTDevToolsAgent::~DRTDevToolsAgent):
991         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
992         (DRTDevToolsClient::sendFrontendLoaded):
993         * DumpRenderTree/chromium/DRTDevToolsClient.h:
994         * DumpRenderTree/chromium/DumpRenderTree.cpp:
995         (main):
996         * DumpRenderTree/chromium/EventSender.cpp:
997         (SavedEvent::SavedEvent):
998         (EventSender::EventSender):
999         (EventSender::keyDown):
1000         * DumpRenderTree/chromium/EventSender.h:
1001         * DumpRenderTree/chromium/ImageDiff.cpp:
1002         (Image::Image):
1003         * DumpRenderTree/chromium/LayoutTestController.cpp:
1004         (LayoutTestController::LayoutTestController):
1005         (LayoutTestController::WorkQueue::reset):
1006         (WorkItemBackForward::WorkItemBackForward):
1007         (WorkItemLoadingScript::WorkItemLoadingScript):
1008         (WorkItemNonLoadingScript::WorkItemNonLoadingScript):
1009         (WorkItemLoad::WorkItemLoad):
1010         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
1011         (LayoutTestController::pathToLocalResource):
1012         * DumpRenderTree/chromium/LayoutTestController.h:
1013         (LayoutTestController::WorkItem::~WorkItem):
1014         (LayoutTestController::WorkQueue::WorkQueue):
1015         * DumpRenderTree/chromium/MockSpellCheck.cpp:
1016         (MockSpellCheck::MockSpellCheck):
1017         (MockSpellCheck::~MockSpellCheck):
1018         * DumpRenderTree/chromium/MockSpellCheck.h:
1019         * DumpRenderTree/chromium/NotificationPresenter.h:
1020         (NotificationPresenter::NotificationPresenter):
1021         * DumpRenderTree/chromium/Task.cpp:
1022         (WebTask::WebTask):
1023         * DumpRenderTree/chromium/Task.h:
1024         (TaskList::TaskList):
1025         * DumpRenderTree/chromium/TestEventPrinter.cpp:
1026         (DRTPrinter::DRTPrinter):
1027         (TestShellPrinter::TestShellPrinter):
1028         * DumpRenderTree/chromium/TestNavigationController.cpp:
1029         (TestNavigationEntry::TestNavigationEntry):
1030         (TestNavigationEntry::~TestNavigationEntry):
1031         (TestNavigationController::TestNavigationController):
1032         (TestNavigationController::reload):
1033         (TestNavigationController::loadEntry):
1034         (TestNavigationController::didNavigateToEntry):
1035         * DumpRenderTree/chromium/TestNavigationController.h:
1036         (TestShellExtraData::TestShellExtraData):
1037         * DumpRenderTree/chromium/TestShell.cpp:
1038         (dumpHistoryItem):
1039         * DumpRenderTree/chromium/TestShell.h:
1040         (TestParams::TestParams):
1041         * DumpRenderTree/chromium/TestShellWin.cpp:
1042         (TestShell::waitTestFinished):
1043         * DumpRenderTree/chromium/TestWebWorker.h:
1044         (TestWebWorker::startWorkerContext):
1045         (TestWebWorker::terminateWorkerContext):
1046         (TestWebWorker::postMessageToWorkerContext):
1047         (TestWebWorker::clientDestroyed):
1048         (TestWebWorker::postMessageToWorkerObject):
1049         (TestWebWorker::postExceptionToWorkerObject):
1050         (TestWebWorker::postConsoleMessageToWorkerObject):
1051         (TestWebWorker::confirmMessageFromWorkerObject):
1052         (TestWebWorker::reportPendingActivity):
1053         (TestWebWorker::workerContextClosed):
1054         (TestWebWorker::~TestWebWorker):
1055         * DumpRenderTree/chromium/TextInputController.cpp:
1056         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
1057         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
1058         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
1059         (WebThemeEngineDRTWin::paintButton):
1060         (WebThemeEngineDRTWin::paintMenuList):
1061         (WebThemeEngineDRTWin::paintTrackbar):
1062         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
1063         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
1064         * DumpRenderTree/chromium/WebViewHost.cpp:
1065         (WebViewHost::navigate):
1066         (WebViewHost::updateSessionHistory):
1067         (WebViewHost::paintInvalidatedRegion):
1068         * DumpRenderTree/chromium/WebViewHost.h:
1069
1070 2011-05-19  Dmitry Lomov  <dslomov@google.com>
1071
1072         Reviewed by Adam Roben.
1073
1074         Detect hangs in run-api-tests
1075         https://bugs.webkit.org/show_bug.cgi?id=48043
1076
1077         * Scripts/run-api-tests: Added test timeouts
1078
1079 2011-05-19  Dmitry Lomov  <dslomov@google.com>
1080
1081         Reviewed by Adam Roben.
1082
1083         run-api-tests should run one test per process
1084         https://bugs.webkit.org/show_bug.cgi?id=61088
1085
1086         * Scripts/run-api-tests: Resurrecting the previous revison of this file, with fixes to system call under Windows, 
1087         return code, and parsing GTest output format.
1088
1089 2011-05-15  Robert Hogan  <robert@webkit.org>
1090
1091         Reviewed by Antonio Gomes.
1092
1093         [Qt][GTK] plugins/get-url-with-javascript-url.html fails
1094         https://bugs.webkit.org/show_bug.cgi?id=60834
1095         Fix unix test plugin for plugins/get-url-with-javascript-url.html
1096
1097         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1098         (webkit_test_plugin_new_stream):
1099         (webkit_test_plugin_write_ready):
1100         (webkit_test_plugin_write):
1101
1102 2011-05-19  Sheriff Bot  <webkit.review.bot@gmail.com>
1103
1104         Unreviewed, rolling out r86869, r86873, r86875, and r86877.
1105         http://trac.webkit.org/changeset/86869
1106         http://trac.webkit.org/changeset/86873
1107         http://trac.webkit.org/changeset/86875
1108         http://trac.webkit.org/changeset/86877
1109         https://bugs.webkit.org/show_bug.cgi?id=61139
1110
1111         broke builds and debug DRT (Requested by rniwa on #webkit).
1112
1113         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1114         * DumpRenderTree/chromium/TestShell.cpp:
1115         (TestShell::bindJSObjectsToWindow):
1116         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1117         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1118
1119 2011-05-18  Dimitri Glazkov  <dglazkov@chromium.org>
1120
1121         Reviewed by Darin Adler.
1122
1123         Add build logistics and plumbing for window.internals object.
1124         https://bugs.webkit.org/show_bug.cgi?id=60313
1125
1126         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
1127         * DumpRenderTree/chromium/TestShell.cpp:
1128         (TestShell::bindJSObjectsToWindow): Added injection code.
1129         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1130         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
1131
1132 2011-05-19  Zsolt Fehér  <h490267@stud.u-szeged.hu>
1133
1134         Reviewed by Csaba Osztrogonác.
1135
1136         [Qt] Implement eventSender.scalePageBy
1137         https://bugs.webkit.org/show_bug.cgi?id=60015
1138
1139         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1140         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1141         * DumpRenderTree/qt/EventSenderQt.cpp:
1142         (EventSender::scalePageBy):
1143         * DumpRenderTree/qt/EventSenderQt.h:
1144
1145 2011-05-19  Kenichi Ishibashi  <bashi@chromium.org>
1146
1147         Reviewed by Kent Tamura.
1148
1149         [Chromium] IME candidate window appears wrong position in an iframe
1150         https://bugs.webkit.org/show_bug.cgi?id=61023
1151
1152         Call the focused frame's firstRectForCharacterRange() instead of the
1153         main frame so that DRT behaves as the same as Chromium.
1154
1155         * DumpRenderTree/chromium/TextInputController.cpp:
1156         (TextInputController::firstRectForCharacterRange):
1157
1158 2011-05-18  Adam Roben  <aroben@apple.com>
1159
1160         Add a new page to build.webkit.org to help find when tests started failing
1161
1162         The page is accessible at <http://build.webkit.org/TestFailures/>. It is pretty minimalist
1163         right now, but already shows some useful information. It's somewhat similar to webkit-patch
1164         failure-reason and sheriffbot, and perhaps can be combined with them eventually. It's a
1165         little more convenient than either of them, though, because it's all done in the browser
1166         (and thus it's easy to go directly to the relevant test results).
1167
1168         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Added.
1169         (Buildbot): This class represents a Buildbot server.
1170         (Buildbot.prototype.buildURL): Returns the URL for the summary page for a particular build.
1171         (Buildbot.prototype.builderNamed): Returns a Builder with the given name.
1172         (Buildbot.prototype.getTesterNames): Fetches the names of all testers and passes them to the
1173         callback.
1174         (Buildbot.prototype.parseBuildName): Breaks up a build name into its constituent parts. Must
1175         be implemented by a derived class that understands this server's build naming scheme.
1176         (Buildbot.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
1177         particular build.
1178
1179         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Added.
1180         (Builder): This class represents one builder on the buildbot.
1181         (Builder.prototype.buildURL): Returns the URL for the summary page for a particular build.
1182         (Builder.prototype.failureDiagnosisTextAndURL): Returns data that provides a little more
1183         information about a particular test failure.
1184         (Builder.prototype.startFetchingBuildHistory): Periodically calls the callback with
1185         information about when tests started failing.
1186         (Builder.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
1187         particular build.
1188         (Builder.prototype._getBuildNames): Fetches the names of all builds and passes them to the
1189         callback.
1190         (Builder.prototype._getFailingTests): Fetches the results.html page for the given build and
1191         extracts all the failing tests listed in it, passing them to the callback.
1192         (Builder.prototype._incorporateBuildHistory): Gets the failing tests for the specified
1193         build, merges them into the build history, and calls the callback telling it whether the
1194         next build should be fetched to provide more information.
1195
1196         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
1197         Added. Just some simple styles.
1198
1199         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Added.
1200         (createDefinitionList): Takes an array of pairs and turns them into a DL element.
1201         (getResource): Wrapper around XMLHttpRequest.
1202         (Array.prototype.findFirst): Finds the first element matching the given predicate and
1203         returns it.
1204         (Array.prototype.last): Returns the last element of the array.
1205
1206         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Added.
1207         (ViewController): This class contains the main logic for displaying the page.
1208         (ViewController.loaded): Just calls through to parseHash.
1209         (ViewController.parseHash): Either starts analyzing failures on a particular builder, or
1210         shows the list of all testers so one can be chosen. This function is called when the page
1211         loads and whenever we get a hashchange event.
1212         (ViewController._displayBuilder): Asks the builder to fetch build history, and displays it
1213         as it is fetched. The display ends up grouping tests by when they started failing.
1214         (ViewController._displayTesters): Gets the list of testers and displays it.
1215
1216         (ViewController._domForBuildName):
1217         (ViewController._domForFailedTest):
1218         Helper functions to create descriptions and links for a particular build or failed test.
1219
1220         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Added.
1221         (WebKitBuildbot): Calls up to the base class constructor with the correct base URL.
1222         (WebKitBuildbot.prototype.parseBuildName): Parses a build.webkit.org-style build name.
1223
1224         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Added. Just
1225         loads all the files and sets up a ViewController, which does the rest.
1226
1227         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Added a link to the new
1228         page.
1229
1230 2011-05-18  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
1231
1232         Reviewed by Csaba Osztrogonác.
1233
1234         [Qt] Implement layoutTestController.setValueForUser()
1235         https://bugs.webkit.org/show_bug.cgi?id=60956
1236
1237         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1238         (LayoutTestController::setValueForUser):
1239         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1240
1241 2011-05-16  Robert Hogan  <robert@webkit.org>
1242
1243         Reviewed by Kenneth Rohde Christiansen.
1244
1245         plugins/invalidate_rect.html fails on linux ports
1246
1247         - Make the unix test netscape plugin recognize the onPaintEvent
1248           and windowedPlugin parameters.
1249
1250         https://bugs.webkit.org/show_bug.cgi?id=54051
1251
1252         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1253         (handleEventX11):
1254         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1255         (LayoutTestController::displayInvalidatedRegion):
1256         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1257         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1258         (webkit_test_plugin_new_instance):
1259         (webkit_test_plugin_handle_event):
1260
1261 2011-05-17  Tony Chang  <tony@chromium.org>
1262
1263         Reviewed by Ojan Vafai.
1264
1265         [chromium] move Lucid 64 bit results into LayoutTests/platform/chromium-linux
1266         https://bugs.webkit.org/show_bug.cgi?id=60895
1267
1268         Update the tools to handle the move.  Lucid 32 results now go in
1269         chromium-linux-x86 and the default platform on Linux is now x86_64.
1270
1271         * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Default to x86_64
1272         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1273         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Default to Lucid
1274         * Scripts/webkitpy/layout_tests/port/base.py: ditto
1275         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Update directory fallback and default to Lucid 64
1276         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1277         * Scripts/webkitpy/layout_tests/port/test.py: Update tests to default to x86_64
1278         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Update bot names.
1279         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: Whitespace cleanup.
1280
1281 2011-05-17  Adam Roben  <aroben@apple.com>
1282
1283         Make run-api-tests work on Windows when there are spaces in the path
1284
1285         Fixes <http://webkit.org/b/60954> REGRESSION (r86511): run-api-tests fails if there are
1286         spaces in the path to TestWebKitAPI.exe
1287
1288         Reviewed by David Levin.
1289
1290         * Scripts/run-api-tests:
1291         (runTestTool): Use the "direct object" form of system() to avoid having the path to
1292         TestWebKitAPI.exe be split by the shell.
1293
1294 2011-05-16  Ian Henderson  <ianh@apple.com>
1295
1296         Reviewed by Joseph Pecoraro.
1297
1298         Page::goToItem doesn't work while loading is deferred
1299         https://bugs.webkit.org/show_bug.cgi?id=60412
1300
1301         Add setDefersLoading and goBack methods to LayoutTestController.  We
1302         need to use goBack() instead of history.back() because the latter goes
1303         through NavigationScheduler, hence doesn't exhibit the bug.
1304
1305         * DumpRenderTree/LayoutTestController.cpp:
1306         (goBackCallback):
1307         (setDefersLoadingCallback):
1308         (LayoutTestController::staticFunctions):
1309         * DumpRenderTree/LayoutTestController.h:
1310         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1311         (LayoutTestController::goBack):
1312         (LayoutTestController::setDefersLoading):
1313         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1314         (LayoutTestController::goBack):
1315         (LayoutTestController::setDefersLoading):
1316         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1317         (LayoutTestController::goBack):
1318         (LayoutTestController::setDefersLoading):
1319         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1320         (LayoutTestController::goBack):
1321         (LayoutTestController::setDefersLoading):
1322
1323 2011-05-16  Sam Weinig  <sam@webkit.org>
1324
1325         Reviewed by Anders Carlsson.
1326
1327         TestWebKitAPI should build with clang if it can
1328         https://bugs.webkit.org/show_bug.cgi?id=60918
1329
1330         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
1331         Update CompilerVersion.xcconfig to match others.
1332
1333         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1334         Add CompilerVersion.xcconfig to the project.
1335
1336         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
1337         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
1338         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1339         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1340         Add some casts to quiet warnings from clang.
1341
1342 2011-05-16  Dirk Pranke  <dpranke@chromium.org>
1343
1344         Reviewed by David Levin.
1345
1346         add dpranke as a reviewer
1347         https://bugs.webkit.org/show_bug.cgi?id=60919
1348
1349         * Scripts/webkitpy/common/config/committers.py:
1350
1351 2011-05-16  Robert Hogan  <robert@webkit.org>
1352
1353         Reviewed by Anders Carlsson.
1354
1355         [Gtk] plugins/get-url-notify-with-url-that-fails-to-load.html crashes on buildbot
1356
1357         https://bugs.webkit.org/show_bug.cgi?id=60838
1358
1359         The unix test plugin needs to call the test's NPP_URLNotify
1360         rather than the browsers.
1361
1362         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1363         (webkit_test_plugin_url_notify):
1364
1365 2011-05-16  Brent Fulgham  <bfulgham@webkit.org>
1366
1367         Rubber-stamped by Adam Roben.
1368
1369         Adding myself as a reviewer.
1370         * Scripts/webkitpy/common/config/committers.py:
1371
1372 2011-05-16  Sam Weinig  <sam@webkit.org>
1373
1374         Fix typo pointed out by Dave Levin.
1375
1376         * TestWebKitAPI/PlatformUtilities.h:
1377         (TestWebKitAPI::Util::assertWKStringEqual):
1378         Strig -> String.
1379
1380 2011-05-16  Sam Weinig  <sam@webkit.org>
1381
1382         Reviewed by David Levin.
1383
1384         Convert api tester over to using gtest expectations directly
1385         https://bugs.webkit.org/show_bug.cgi?id=60862
1386
1387         * TestWebKitAPI/PlatformUtilities.cpp:
1388         (TestWebKitAPI::Util::toSTD):
1389         * TestWebKitAPI/PlatformUtilities.h:
1390         (TestWebKitAPI::Util::assertWKStrigEqual):
1391         Add convenience macro to compare WK2 strings. Add some overloads of toSTD to make
1392         the implementation of the macro simpler.
1393
1394         * TestWebKitAPI/Test.h:
1395         Remove TEST_ASSERT forwarder.
1396
1397         [Test changes elided]
1398
1399 2011-05-16  David Kilzer  <ddkilzer@apple.com>
1400
1401         <http://webkit.org/b/60913> C++ exceptions should not be enabled when building with llvm-gcc-4.2
1402         <rdar://problem/9446430>
1403
1404         Reviewed by Mark Rowe.
1405
1406         * MiniBrowser/Configurations/Base.xcconfig: Fixed typo.
1407         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
1408         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
1409
1410 2011-05-16  Jon Lee  <jonlee@apple.com>
1411
1412         Reviewed by Simon Fraser.
1413
1414         Can't horizontally scroll iframes and overflow because wheel events are always accepted
1415         https://bugs.webkit.org/show_bug.cgi?id=60779
1416
1417         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1418         (WTR::InjectedBundlePage::InjectedBundlePage): Set new default method to nil.
1419
1420 2011-05-16  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
1421
1422         Reviewed by Csaba Osztrogonác.
1423
1424         [Qt] Tools.pro misses include(common.pri)
1425         https://bugs.webkit.org/show_bug.cgi?id=60883
1426
1427         It includes features.pri, which depends on common.pri (the build is
1428         not broken today with the default options, but this is the right
1429         thing to do).
1430
1431         * Tools.pro:
1432
1433 2011-05-15  Dominic Cooney  <dominicc@chromium.org>
1434
1435         Unreviewed: adding myself to committers.py.
1436
1437         * Scripts/webkitpy/common/config/committers.py:
1438
1439 2011-05-15  Daniel Bates  <dbates@webkit.org>
1440
1441         Reviewed by Chris Jerdonek.
1442
1443         svn-apply can't handle Git diff that only changes executable bit
1444         https://bugs.webkit.org/show_bug.cgi?id=60848
1445
1446         Fixes an issue where svn-{apply, unapply} fail to handle a Git diff for a file
1447         that only has an executable bit change.
1448
1449         * Scripts/VCSUtils.pm:
1450           - Modified regex $chunkRangeRegEx to match chunk range with ending text, say: @@ -2,6 +2,18 @@ foo().
1451         (parseDiff): Modified to count the number of text chunks in the diff. This should also help towards
1452         fixing <https://bugs.webkit.org/show_bug.cgi?id=29684>.
1453         * Scripts/svn-apply:
1454         (patch): Only use standard patch tool if the patch is non-empty and for a text file (i.e. not a binary patch).
1455         * Scripts/svn-unapply:
1456         (patch): Ditto.
1457         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
1458           - Updated expected results for test cases to account for numTextChunks.
1459           - Fixed malformed chunk range in test cases: "Git: simple", and "Git: Git diff followed by SVN diff".
1460           - Added test case "Git: file that only has an executable bit change".
1461         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
1462           - Updated expected results for test cases to account for numTextChunks.
1463
1464 2011-05-15  Sam Weinig  <sam@webkit.org>
1465
1466         Fix windows build.
1467
1468         * TestWebKitAPI/win/main.cpp:
1469         (main):
1470
1471 2011-05-15  Sam Weinig  <sam@webkit.org>
1472
1473         Reviewed by David Levin.
1474
1475         Make API tester more gtest friendly
1476         https://bugs.webkit.org/show_bug.cgi?id=60859
1477
1478         * Scripts/run-api-tests:
1479         Numerous changes:
1480         - Remove logic to run tests one at a time.
1481         - Remove logic to build up a list of tests, instead just pass --gtest_list_tests to 
1482           the test runner and allow gtest to print it for us.
1483         - Forward stdout from the test tool to stdout, even in non-verbose runs.
1484         - Run test tool from the current working directory instead of the root webkit
1485           directory.
1486
1487         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1488         Move plist to be with other bundle sources.
1489
1490         * TestWebKitAPI/TestsController.cpp:
1491         (TestWebKitAPI::TestsController::TestsController):
1492         (TestWebKitAPI::TestsController::run):
1493         * TestWebKitAPI/TestsController.h:
1494         * TestWebKitAPI/mac/main.mm:
1495         Simplify TestController down to a single run function. We should consider removing the class
1496         entirely at some point.
1497
1498 2011-05-15  Sheriff Bot  <webkit.review.bot@gmail.com>
1499
1500         Unreviewed, rolling out r86504.
1501         http://trac.webkit.org/changeset/86504
1502         https://bugs.webkit.org/show_bug.cgi?id=60853
1503
1504         "Broke Qt EventSender in editing/selection tests" (Requested
1505         by mwenge on #webkit).
1506
1507         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1508         (WebCore::WebPage::WebPage):
1509         (WebCore::DumpRenderTree::DumpRenderTree):
1510         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1511         (WebCore::DumpRenderTree::initJSObjects):
1512         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1513         (WebCore::DumpRenderTree::eventSender):
1514         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1515         (webkit_test_plugin_new_instance):
1516         (webkit_test_plugin_set_window):
1517         (webkit_test_plugin_handle_event):
1518
1519 2011-05-12  Robert Hogan  <robert@webkit.org>
1520
1521         Reviewed by Benjamin Poulain.
1522
1523         [Qt] fix http/tests/plugins/plugin-document-has-focus.html
1524
1525         The support for this test added to the unix test plugin here
1526         may allow other platforms to pass it (nearly everyone
1527         skips it). On Qt it required a bit of trickiness with
1528         the page's EventSender object to get it working fully though,
1529         so only unskipping Qt here.
1530
1531         https://bugs.webkit.org/show_bug.cgi?id=60722
1532
1533         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1534         (WebCore::WebPage::WebPage):
1535         (WebCore::WebPage::eventSender):
1536         (WebCore::DumpRenderTree::DumpRenderTree):
1537         (WebCore::DumpRenderTree::initJSObjects):
1538         (WebCore::DumpRenderTree::createWindow):
1539         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1540         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1541         (webkit_test_plugin_new_instance):
1542         (webkit_test_plugin_set_window):
1543         (webkit_test_plugin_handle_event):
1544
1545 2011-05-14  Arno Renevier  <arno@renevier.net>
1546
1547         Reviewed by Martin Robinson.
1548
1549         make run-gtk-tests executable
1550         https://bugs.webkit.org/show_bug.cgi?id=59278
1551
1552         * Scripts/run-gtk-tests:
1553
1554 2011-05-14  Anders Carlsson  <andersca@apple.com>
1555
1556         Reviewed by Kevin Decker.
1557
1558         NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
1559         https://bugs.webkit.org/show_bug.cgi?id=60823
1560         <rdar://problem/9430386>
1561
1562         Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.
1563
1564         * DumpRenderTree/DumpRenderTree.gypi:
1565         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1566         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added.
1567         (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad):
1568         (GetURLNotifyWithURLThatFailsToLoad::NPP_New):
1569         (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
1570         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1571         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1572         * GNUmakefile.am:
1573
1574 2011-05-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1575
1576         Unreviewed, rolling out r86476.
1577         http://trac.webkit.org/changeset/86476
1578         https://bugs.webkit.org/show_bug.cgi?id=60832
1579
1580         It made plugins/get-url-notify-with-url-that-fails-to-
1581         load.html crash on GTK (Requested by Ossy on #webkit).
1582
1583         * DumpRenderTree/DumpRenderTree.gypi:
1584         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1585         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Removed.
1586         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1587         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1588         * GNUmakefile.am:
1589
1590 2011-05-13  Anders Carlsson  <andersca@apple.com>
1591
1592         Reviewed by Sam Weinig.
1593
1594         NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
1595         https://bugs.webkit.org/show_bug.cgi?id=60823
1596         <rdar://problem/9430386>
1597
1598         Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.
1599
1600         * DumpRenderTree/DumpRenderTree.gypi:
1601         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1602         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added.
1603         (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad):
1604         (GetURLNotifyWithURLThatFailsToLoad::NPP_New):
1605         (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
1606         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1607         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1608         * GNUmakefile.am:
1609
1610 2011-05-13  Anders Carlsson  <andersca@apple.com>
1611
1612         Build fix.
1613
1614         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp:
1615
1616 2011-05-13  Anders Carlsson  <andersca@apple.com>
1617
1618         Reviewed by Sam Weinig.
1619
1620         NPN_GetURL with a javascript: URL doesn't send back the result in the stream
1621         https://bugs.webkit.org/show_bug.cgi?id=60810
1622
1623         Add a test that calls NPN_GetURL on a javascript: URL and checks that it gets back the expected result.
1624
1625         * DumpRenderTree/DumpRenderTree.gypi:
1626         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1627         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1628         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1629         * GNUmakefile.am:
1630         Add files.
1631
1632         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1633         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1634         Add new NPN and NPP wrappers and sort them according to the order they appear in npfunctions.h
1635
1636         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp: Added.
1637         (GetURLWithJavaScriptURL::GetURLWithJavaScriptURL):
1638         (GetURLWithJavaScriptURL::NPP_New):
1639         (GetURLWithJavaScriptURL::NPP_NewStream):
1640         (GetURLWithJavaScriptURL::NPP_DestroyStream):
1641         (GetURLWithJavaScriptURL::NPP_WriteReady):
1642         (GetURLWithJavaScriptURL::NPP_Write):
1643         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1644         (NPP_NewStream):
1645         (NPP_WriteReady):
1646         (NPP_Write):
1647         (NPP_URLNotify):
1648         call the PluginTest NPP wrappers.
1649
1650 2011-05-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1651
1652         Unreviewed, rolling out r86447.
1653         http://trac.webkit.org/changeset/86447
1654         https://bugs.webkit.org/show_bug.cgi?id=60809
1655
1656         "Broke some uses of EventSender object on Qt" (Requested by
1657         mwenge on #webkit).
1658
1659         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1660         (WebCore::WebPage::WebPage):
1661         (WebCore::DumpRenderTree::DumpRenderTree):
1662         (WebCore::DumpRenderTree::initJSObjects):
1663         (WebCore::DumpRenderTree::createWindow):
1664         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1665         (WebCore::DumpRenderTree::eventSender):
1666         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1667         (webkit_test_plugin_new_instance):
1668         (webkit_test_plugin_set_window):
1669         (webkit_test_plugin_handle_event):
1670
1671 2011-05-13  Robert Hogan  <robert@webkit.org>
1672
1673         Reviewed by Benjamin Poulain.
1674
1675         [Qt] fix http/tests/plugins/plugin-document-has-focus.html
1676
1677         The support for this test added to the unix test plugin here
1678         may allow other platforms to pass it (nearly everyone
1679         skips it). On Qt it required a bit of trickiness with
1680         the page's EventSender object to get it working fully though,
1681         so only unskipping Qt here.
1682
1683         https://bugs.webkit.org/show_bug.cgi?id=60722
1684
1685         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1686         (WebCore::WebPage::WebPage):
1687         (WebCore::WebPage::eventSender):
1688         (WebCore::DumpRenderTree::DumpRenderTree):
1689         (WebCore::DumpRenderTree::initJSObjects):
1690         (WebCore::DumpRenderTree::createWindow):
1691         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1692         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1693         (webkit_test_plugin_new_instance):
1694         (webkit_test_plugin_set_window):
1695         (webkit_test_plugin_handle_event):
1696
1697 2011-05-13  Adam Roben  <aroben@apple.com>
1698
1699         Exclude the Leopard NRWT bot from the core builder set
1700
1701         Fixes <http://webkit.org/b/60392> Leopard Intel Release (NRWT) shouldn't be a core builder
1702
1703         Reviewed by Darin Adler.
1704
1705         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1706         (BuildBot.__init__): Tighten up the Leopard regexp to only allow the non-NRWT Leopard bots
1707         in the core builder set.
1708
1709         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1710         (BuildBotTest.test_builder_name_regexps): Updated to match the current set of builders and
1711         regexps.
1712
1713 2011-05-13  Adam Roben  <aroben@apple.com>
1714
1715         Group all the NRWT bots together
1716
1717         This also gets the new NRWT bots out of the middle of Apple's bots. Since these new NRWT
1718         bots are experimental, it seems best not to clutter up the non-experimental bots with
1719         experimental ones.
1720
1721         Fixes <http://webkit.org/b/60769> New "(NRWT)" bots are right in the middle of Apple's bots
1722         on build.webkit.org
1723
1724         Reviewed by Dan Bernstein.
1725
1726         * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the "(NRWT)" bots next to the
1727         Chromium testers, which also use new-run-webkit-tests.
1728
1729 2011-05-13  Adam Roben  <aroben@apple.com>
1730
1731         Add a plugin test that dumps the plugin window's rect
1732
1733         Part of the test for <http://webkit.org/b/60194> <rdar://problem/9383760> REGRESSION
1734         (r79167): Windowed plugins in Google Reader don't move when the article list is scrolled
1735
1736         Reviewed by Dan Bernstein.
1737
1738         * DumpRenderTree/TestNetscapePlugIn/Tests/win/DumpWindowRect.cpp: Added.
1739         (DumpWindowRect::DumpWindowRect): Just call up to the base class.
1740         (DumpWindowRect::performWindowGeometryTest): Find our window rect relative to the test
1741         harness window and log it.
1742
1743         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added DumpWindowRect.
1744
1745 2011-05-13  Adam Roben  <aroben@apple.com>
1746
1747         Move code required for most tests of plugin window geometry into a base class
1748
1749         WebKit2's asynchronous plugin window positioning makes testing window geometry tricky. By
1750         having all the trickiness in a shared base class, writing new window geometry tests will be
1751         much easier.
1752
1753         Fixes <http://webkit.org/b/60776> It's hard to write tests that check plugin window geometry
1754
1755         Reviewed by Anders Carlsson.
1756
1757         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp:
1758         (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Changed to inherit from the new
1759         WindowGeometryTest base class. Most of the code from this class was moved to the new base
1760         class.
1761         (WindowRegionIsSetToClipRect::performWindowGeometryTest): Renamed from checkWindowRegion.
1762         This is called by the base class when it is safe to check the window's geometry. Note that
1763         the m_didCheckWindowRegion logic was removed completely; it has never been needed and was
1764         just vestigial code from an earlier version of this test.
1765
1766         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added new
1767         WindowGeometryTest class.
1768
1769         * DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.cpp: Added. Code came from
1770         WindowRegionIsSetToClipRect.
1771         (WindowGeometryTest::finishTest): This is the only change from WindowRegionIsSetToClipRect.
1772         We now call the new virtual performWindowGeometryTest function instead of checkWindowRegion.
1773         Subclasses can implement that function to perform their own tests.
1774
1775         * DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.h: Added.
1776
1777 2011-05-13  Zoltan Herczeg  <zherczeg@webkit.org>
1778
1779         Reviewed by Csaba Osztrogonác.
1780
1781         Missing 2nd #EOF if WebProcess is killed.
1782         https://bugs.webkit.org/show_bug.cgi?id=60761
1783
1784         If the WebProcess is killed, only one #EOF is yielded
1785         by WebKitTestRunner. However, run-webkit-test wait for
1786         a second #EOF, which signals the finishing of pixel dump.
1787         Since this never happens, run-webkit-test waits forever.
1788
1789         * WebKitTestRunner/TestInvocation.cpp:
1790         (WTR::TestInvocation::dump):
1791         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1792         * WebKitTestRunner/TestInvocation.h:
1793
1794 2011-05-13  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
1795
1796         Reviewed by Csaba Osztrogonác.
1797
1798         [NRWT] chromium-linux tests shouldn't run on other platforms
1799         https://bugs.webkit.org/show_bug.cgi?id=60162
1800
1801         Remove _tests_for_other_platforms defs because r82753
1802         implemented it properly in the baseclass in webkit.py.
1803
1804         * Scripts/webkitpy/layout_tests/port/gtk.py:
1805         * Scripts/webkitpy/layout_tests/port/qt.py:
1806         * Scripts/webkitpy/layout_tests/port/win.py:
1807
1808 2011-05-12  Ryuan Choi  <ryuan.choi@samsung.com>
1809
1810         Reviewed by Antonio Gomes.
1811
1812         [EFL] Remove unused option of EWeblauncher
1813         https://bugs.webkit.org/show_bug.cgi?id=60747
1814
1815         Remove sudo-workaround option.
1816         This option is not used and make other option wrong.
1817
1818         * EWebLauncher/main.c:
1819
1820 2011-05-12  Lucas Forschler  <lforschler@apple.com>
1821
1822         Reviewed by Stephanie Lewis.
1823
1824         Fix config.json to address missing WK2 builder/tester config.
1825         Fix naming of machines (xserve not macpro)
1826
1827         * BuildSlaveSupport/build.webkit.org-config/config.json:
1828
1829 2011-05-12  Lucas Forschler  <lforschler@apple.com>
1830
1831         Reviewed by Stephanie Lewis.
1832
1833         Add SnowLeopard Debug builder and Test bot.
1834         apple-xserve-8 = SL Debug Tester.
1835         apple-xserve-9 = SL Debug Builder.
1836         
1837         * BuildSlaveSupport/build.webkit.org-config/config.json:
1838
1839 2011-05-12  Adam Barth  <abarth@webkit.org>
1840
1841         This patch disables sheriffbot's bug postings.  He's just been way too
1842         spammy recently due to test flakiness.
1843
1844         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1845         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1846
1847 2011-05-11  Brian Weinstein  <bweinstein@apple.com>
1848
1849         Reviewed by Anders Carlsson.
1850
1851         After relaunching an unresponsive web process, web page stops responding to mouse movement
1852         https://bugs.webkit.org/show_bug.cgi?id=60669
1853         <rdar://problem/9409934>
1854         
1855         This test follows the steps needed to reproduce this bug:
1856         1) Hang the web process
1857         2) While the web process is hung, move the mouse (so WebPageProxy thinks it is processing a mouse move event)
1858         3) Kill and restart the WebProcess
1859         4) Move the mouse
1860         
1861         We are testing that we receive mouse move events after the WebProcess has restarted.
1862
1863         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp: Added.
1864         (TestWebKitAPI::didFinishLoadForFrame): Set a flag that we finished loading.
1865         (TestWebKitAPI::processDidBecomeUnresponsive): Kill the web process once we become unresponsive.
1866         (TestWebKitAPI::processDidCrash): Reload the page when the process crashes, which restarts the web process.
1867         (TestWebKitAPI::setPageLoaderClient):
1868         (TestWebKitAPI::TEST):
1869         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp: Added.
1870         (TestWebKitAPI::MouseMoveAfterCrashTest::MouseMoveAfterCrashTest):
1871         (TestWebKitAPI::MouseMoveAfterCrashTest::didReceiveMessage):
1872         * TestWebKitAPI/Tests/WebKit2/mouse-move-listener.html: Added.
1873
1874         * TestWebKitAPI/PlatformWebView.h:
1875         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1876         (TestWebKitAPI::PlatformWebView::simulateMouseMove): Sends the messages that simulate a mouse move.
1877         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
1878         (TestWebKitAPI::PlatformWebView::simulateMouseMove): Ditto.
1879
1880         Add new files.
1881         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1882         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1883         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
1884         * TestWebKitAPI/win/copy-resources.cmd:
1885
1886 2011-05-12  Tomasz Morawski  <t.morawski@samsung.com>
1887
1888         Reviewed by Antonio Gomes.
1889
1890         [EFL] Added initialization/shutdown for ecore_file library
1891         https://bugs.webkit.org/show_bug.cgi?id=60457
1892
1893         Added initialization and shuthown for ecore_file library and replaced
1894         realpath function to ecore_file_realpath.
1895
1896         * EWebLauncher/main.c:
1897         (quit):
1898         (findThemePath):
1899         (main):
1900
1901 2011-05-12  Young Han Lee  <joybro@company100.net>
1902
1903         Reviewed by Kenneth Rohde Christiansen.
1904
1905         [Qt] Implement layoutTestController.layerTreeAsText()
1906         https://bugs.webkit.org/show_bug.cgi?id=60367
1907
1908         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1909         (LayoutTestController::layerTreeAsText):
1910         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1911
1912 2011-05-11  Eric Seidel  <eric@webkit.org>
1913
1914         Reviewed by David Levin.
1915
1916         Teach validate-committer-lists how to validate committers bugzilla_email()
1917         https://bugs.webkit.org/show_bug.cgi?id=60651
1918
1919         It turns out we currently have 9 committers with invalid values for their
1920         bugzilla_email field (meaning we don't know what email is their bugzilla account).
1921         "Alexander Kellett" <lypanov@mac.com>
1922         "Andre Boule" <aboule@apple.com>
1923         "Cameron McCormack" <cam@webkit.org>
1924         "Chris Petersen" <cpetersen@apple.com>
1925         "Eli Fidler" <eli@staikos.net>
1926         "Matt Lilek" <webkit@mattlilek.com>
1927         "Pierre d'Herbemont" <pdherbemont@free.fr>
1928         "Scott Violet" <sky@chromium.org>
1929         "Adam Treat" <treat@kde.org>
1930
1931         Most of those haven't committed in a very long time, so it's not suprising
1932         that we haven't noticed that their bugzilla emails are bogus.
1933
1934         * Scripts/validate-committer-lists:
1935         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1936         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1937
1938 2011-05-11  Dmitry Lomov  <dslomov@google.com>
1939
1940         Reviewed by David Levin.
1941
1942         https://bugs.webkit.org/show_bug.cgi?id=59561
1943         Switch TestWebKitAPI to GTest
1944
1945         Fixes Makefiles and WinCairo build as well
1946
1947         * Makefile:
1948         * Scripts/build-api-tests:
1949         * Scripts/run-api-tests:
1950         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
1951         * TestWebKitAPI/Test.h:
1952         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1953         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
1954         (TestWebKitAPI::TEST):
1955         * TestWebKitAPI/TestsController.cpp:
1956         (TestWebKitAPI::TestsController::TestsController):
1957         (TestWebKitAPI::TestsController::dumpTestNames):
1958         (TestWebKitAPI::TestsController::runTestNamed):
1959         (TestWebKitAPI::TestsController::runAllTests):
1960         * TestWebKitAPI/TestsController.h:
1961         * TestWebKitAPI/mac/main.mm:
1962         (main):
1963
1964 2011-05-11  Eric Seidel  <eric@webkit.org>
1965
1966         Reviewed by Alexey Proskuryakov.
1967
1968         Add Luke Macpherson to committers.py as a Contributor
1969         https://bugs.webkit.org/show_bug.cgi?id=60639
1970
1971         * Scripts/webkitpy/common/config/committers.py:
1972
1973 2011-05-11  Noam Rosenthal  <noam.rosenthal@nokia.com>
1974
1975         Reviewed by Kenneth Rohde Christiansen.
1976
1977         [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
1978         https://bugs.webkit.org/show_bug.cgi?id=60439
1979
1980         Patch 4/12: Update the build script to enable 3D rendering by default for Qt.
1981
1982         * Scripts/build-webkit:
1983
1984 2011-05-11  Brian Weinstein  <bweinstein@apple.com>
1985
1986         Reviewed by Adam Roben.
1987
1988         REGRESSION (r86161): WKPreferences API test failing on Windows
1989         https://bugs.webkit.org/show_bug.cgi?id=60658
1990
1991         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1992         (TestWebKitAPI::TEST):
1993
1994 2011-05-11  Alice Boxhall  <aboxhall@chromium.org>
1995
1996         Reviewed by Ojan Vafai.
1997
1998         Modify jsonresults_unittest.py to use a dict format for its test data, and modify jsonresults.py to flatten hierarchical directory structures in input JSON.
1999         https://bugs.webkit.org/show_bug.cgi?id=60521
2000
2001         First steps towards making the results JSON all hierarchical.
2002
2003         * TestResultServer/model/jsonresults.py:
2004         * TestResultServer/model/jsonresults_unittest.py:
2005
2006 2011-05-11  Kevin Ollivier  <kevino@theolliviers.com>
2007
2008         [wx] Build fix, adding new LayoutTestController method stubs.
2009
2010         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2011         (LayoutTestController::localStorageDiskUsageForOrigin):
2012         (LayoutTestController::applicationCacheDiskUsageForOrigin):
2013
2014 2011-05-11  Jessie Berlin  <jberlin@apple.com>
2015
2016         Reviewed by Darin Adler.
2017
2018         [WebKit2] exceededDatabaseQuota function on WKPageUIClient needs to provide information
2019         about the usage for both the origin overall and the database in question.
2020         https://bugs.webkit.org/show_bug.cgi?id=60573
2021
2022         * WebKitTestRunner/TestController.cpp:
2023         (WTR::exceededDatabaseQuota):
2024
2025 2011-05-10  Stephen White  <senorblanco@chromium.org>
2026
2027         Reviewed by David Levin.
2028
2029         Adding myself as a reviewer.
2030         https://bugs.webkit.org/show_bug.cgi?id=60587
2031
2032         * Scripts/webkitpy/common/config/committers.py:
2033
2034 2011-05-11  Eric Seidel  <eric@webkit.org>
2035
2036         Reviewed by Csaba Osztrogonác.
2037
2038         queues.webkit.org should show 1000+ instead of 1000 when we hit the query limit
2039         https://bugs.webkit.org/show_bug.cgi?id=60614
2040
2041         AppEngine has a result limit of 1000.  We hit that when trying
2042         to find out how many patches the style-queue (and other queues)
2043         have passed in the last 30 days.  So lets display 1000+ instead
2044         of 1000 to avoid confusion. (Ossy was asking about this in #webkit tonight.)
2045
2046         I also made the status pages show "never" instead of just "ago" when we
2047         haven't seen a pass or boot message in the last 1000 messages.
2048
2049         * QueueStatusServer/handlers/queuestatus.py:
2050         * QueueStatusServer/templates/queuestatus.html:
2051
2052 2011-05-11  Adam Barth  <abarth@webkit.org>
2053
2054         Reviewed by Eric Seidel.
2055
2056         sheriffbot shouldn't spam bugs when it can't figure out who to blame
2057         https://bugs.webkit.org/show_bug.cgi?id=60613
2058
2059         This patch limits the number of bugs sheriffbot will spam to three.
2060         Ideally, we'd come up with some smarter huerstics, but hopefully this
2061         will cut down on the bugmail spam for slow bots.
2062
2063         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2064
2065 2011-05-10  Eric Seidel  <eric@webkit.org>
2066
2067         Reviewed by Adam Barth.
2068
2069         EWS bots should be robust against test-webkitpy hangs
2070         https://bugs.webkit.org/show_bug.cgi?id=60579
2071
2072         Added a killAfterTimeout subroutine, which takes a child_pid
2073         and timeout, and will setup a watchdog process to kill that child
2074         after the timeout.  killAfterTimeout will waitpid on the child.
2075
2076         * EWSTools/start-queue.sh:
2077
2078 2011-05-10  MORITA Hajime  <morrita@google.com>
2079
2080         Unreviewed, moved myself to the reviewers list.
2081
2082         * Scripts/webkitpy/common/config/committers.py:
2083
2084 2011-05-10  Anton D'Auria  <adauria@apple.com>
2085
2086         Reviewed by David Levin.
2087
2088         StorageTracker should report actual local storage usage on disk
2089         https://bugs.webkit.org/show_bug.cgi?id=60558
2090
2091         * DumpRenderTree/LayoutTestController.cpp:
2092         (localStorageDiskUsageForOriginCallback):
2093         (LayoutTestController::staticFunctions):
2094         * DumpRenderTree/LayoutTestController.h:
2095         * DumpRenderTree/chromium/LayoutTestController.cpp:
2096         (LayoutTestController::LayoutTestController):
2097         (LayoutTestController::localStorageDiskUsageForOrigin):
2098         * DumpRenderTree/chromium/LayoutTestController.h:
2099         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2100         (LayoutTestController::localStorageDiskUsageForOrigin):
2101         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2102         (LayoutTestController::localStorageDiskUsageForOrigin):
2103         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2104         (LayoutTestController::localStorageDiskUsageForOrigin):
2105         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2106         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2107         (LayoutTestController::localStorageDiskUsageForOrigin):
2108
2109 2011-05-10  Anton D'Auria  <adauria@apple.com>
2110
2111         Reviewed by Alexey Proskuryakov.
2112
2113         Add ApplicationCache API to get disk usage per origin
2114         https://bugs.webkit.org/show_bug.cgi?id=57127
2115
2116         Added test that loads two frames with ~15Kb image, checks usage,
2117         deletes app cache, verifies usage is 0.
2118
2119         * DumpRenderTree/LayoutTestController.cpp:
2120         (applicationCacheDiskUsageForOriginCallback):
2121         (LayoutTestController::staticFunctions):
2122         * DumpRenderTree/LayoutTestController.h:
2123         * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
2124         (LayoutTestController::LayoutTestController):
2125         (LayoutTestController::applicationCacheDiskUsageForOrigin):
2126         * DumpRenderTree/chromium/LayoutTestController.h:
2127         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
2128         (LayoutTestController::applicationCacheDiskUsageForOrigin):
2129         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2130         (LayoutTestController::applicationCacheDiskUsageForOrigin):
2131         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
2132         (LayoutTestController::applicationCacheDiskUsageForOrigin):
2133         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2134         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
2135         (LayoutTestController::applicationCacheDiskUsageForOrigin):
2136
2137 2011-05-10  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2138
2139         Unreviewed, adding Rafael Antognolli as a committer.
2140
2141         * Scripts/webkitpy/common/config/committers.py:
2142
2143 2011-05-10  Chris Evans  <cevans@chromium.org>
2144
2145         Reviewed by Adam Barth.
2146
2147         Add WebCore::Setting to block displaying and/or running insecure content on secure pages
2148         https://bugs.webkit.org/show_bug.cgi?id=58378
2149
2150         * DumpRenderTree/chromium/LayoutTestController.cpp:
2151         (LayoutTestController::LayoutTestController):
2152         (LayoutTestController::setAllowDisplayOfInsecureContent):
2153         (LayoutTestController::setAllowRunningOfInsecureContent):
2154         * DumpRenderTree/chromium/LayoutTestController.h:
2155         * DumpRenderTree/chromium/WebPreferences.cpp:
2156         (WebPreferences::reset):
2157         (WebPreferences::applyTo):
2158         * DumpRenderTree/chromium/WebPreferences.h:
2159         Add plumbing for new settings to Chromium DRT.
2160
2161 2011-05-10  Enrica Casucci  <enrica@apple.com>
2162
2163         Reviewed by Beth Dakin.
2164
2165         Added my name to the reviewers list and removed my name from
2166         to committer-only list.
2167
2168         * Scripts/webkitpy/common/config/committers.py:
2169
2170 2011-05-10  David Levin  <levin@chromium.org>
2171
2172         Reviewed by Shinichiro Hamaji.
2173
2174         check-webkit-style shouldn't filter the errors using the modified lines for the xml and test expectations checkers.
2175         https://bugs.webkit.org/show_bug.cgi?id=60466
2176
2177         * Scripts/webkitpy/style/checker.py: (unrelated) style fix.
2178         * Scripts/webkitpy/style/checker_unittest.py: Remove the file_path check since
2179           that property was removed.
2180         * Scripts/webkitpy/style/checkers/test_expectations.py: Turn off the line
2181           filtering for errors.
2182         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Add testing to
2183           verify that the line filtering is turned off.
2184         * Scripts/webkitpy/style/checkers/xml.py: Turn off the line filtering for errors
2185           and remove the unused file_path parameter.
2186         * Scripts/webkitpy/style/checkers/xml_unittest.py: Add testing to verify that the
2187           line filtering is turned off (and fix test_no_error).
2188         * Scripts/webkitpy/style/error_handlers.py: Added a way to turn off the filtering
2189           of errors based on the lines changed in the patch.
2190         * Scripts/webkitpy/style/error_handlers_unittest.py: Added a test for turning off
2191           the filtering.
2192
2193 2011-05-10  Adam Roben  <aroben@apple.com>
2194
2195         Update some plugin tests to work with WebKit2's asynchronous windowed plugin positioning on Windows
2196
2197         Fixes <http://webkit.org/b/60442> <rdar://problem/9403200> REGRESSION (r85795):
2198         platform/win/plugins/window-geometry-initialized-before-set-window.html and
2199         platform/win/plugins/window-region-is-set-to-clip-rect.html failing on Windows 7 Release
2200         (WebKit2 Tests)
2201
2202         Reviewed by Anders Carlsson.
2203
2204         * DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp:
2205         (NPNInvalidateRectInvalidatesWindow::NPP_SetWindow): Moved some code from here to the new
2206         WindowedPluginTest::testHarnessWindow function.
2207
2208         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp:
2209         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Only check the window's size, not
2210         its position. In WebKit2, the position won't have been set yet, so we can't test it. But it
2211         turns out only the size mattered for <http://webkit.org/b/46716>, which this test was
2212         created for.
2213
2214         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp:
2215         (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Converted to be a
2216         WindowedPluginTest, and initialized new members.
2217         (WindowRegionIsSetToClipRect::startTest): Make our plugin window visible, and set things up
2218         to ensure we get a WM_WINDOWPOSCHANGED message about it becoming visible.
2219         (WindowRegionIsSetToClipRect::finishTest): Check that the window region is what we expect,
2220         then clean up and tell the test harness we're done.
2221         (WindowRegionIsSetToClipRect::checkWindowRegion): Moved code to check the window region here
2222         from NPP_SetWindow. Changed to use the fancy new log() function instead of pluginLog().
2223         (WindowRegionIsSetToClipRect::showTestHarnessWindowIfNeeded): Show the test harness's window
2224         if it is hidden. This is needed to ensure we get a WM_WINDOWPOSCHANGED message when our own
2225         window becomes visible.
2226         (WindowRegionIsSetToClipRect::hideTestHarnessWindowIfNeeded): Hide the test harness's window
2227         if it was hidden at the start of the test.
2228         (WindowRegionIsSetToClipRect::wndProc): When our timer fires, tell the UI process to paint.
2229         This should cause our window to become visible and our window region to get set. When we get
2230         a WM_WINDOWPOSCHANGED message, we can finally finish the test.
2231         (WindowRegionIsSetToClipRect::NPP_GetValue): Return our script object.
2232         (WindowRegionIsSetToClipRect::ScriptObject::hasMethod): We only have one method:
2233         "startTest".
2234         (WindowRegionIsSetToClipRect::ScriptObject::invoke): Call through to the PluginTest object.
2235
2236         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp:
2237         (WindowedPluginTest::testHarnessWindow):
2238         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.h:
2239         Added this helper function. Code came from NPNInvalidateRectInvalidatesWindow.
2240
2241 2011-05-10  Csaba Osztrogonác  <ossy@webkit.org>
2242
2243         Reviewed by Kenneth Rohde Christiansen.
2244
2245         [Qt] Add new qt-4.8 platform for layout testing
2246         https://bugs.webkit.org/show_bug.cgi?id=60544
2247
2248         * Scripts/old-run-webkit-tests:
2249         * Scripts/webkitdirs.pm:
2250
2251 2011-05-09  Sheriff Bot  <webkit.review.bot@gmail.com>
2252
2253         Unreviewed, rolling out r86108.
2254         http://trac.webkit.org/changeset/86108
2255         https://bugs.webkit.org/show_bug.cgi?id=60533
2256
2257         Broke makefile based builds and Cairo (Requested by weinig on
2258         #webkit).
2259
2260         * Scripts/build-api-tests:
2261         * Scripts/run-api-tests:
2262         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2263         * TestWebKitAPI/Test.h:
2264         (TestWebKitAPI::Test::~Test):
2265         (TestWebKitAPI::Test::name):
2266         (TestWebKitAPI::Test::Register::Register):
2267         (TestWebKitAPI::Test::Register::create):
2268         (TestWebKitAPI::Test::Test):
2269         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2270         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
2271         (TestWebKitAPI::TEST):
2272         * TestWebKitAPI/TestsController.cpp:
2273         (TestWebKitAPI::TestsController::TestsController):
2274         (TestWebKitAPI::TestsController::dumpTestNames):
2275         (TestWebKitAPI::TestsController::runTestNamed):
2276         (TestWebKitAPI::TestsController::testFailed):
2277         (TestWebKitAPI::TestsController::registerCreateTestFunction):
2278         * TestWebKitAPI/TestsController.h:
2279         * TestWebKitAPI/mac/main.mm:
2280         (main):
2281
2282 2011-05-09  Hayato Ito  <hayato@chromium.org>
2283
2284         Reviewed by Ojan Vafai.
2285
2286         Skip reftests if pixel tests are disabled.
2287
2288         https://bugs.webkit.org/show_bug.cgi?id=59078
2289
2290         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2291         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
2292         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
2293         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2294
2295 2011-05-09  Chang Shu  <cshu@webkit.org>
2296
2297         Reviewed by Kenneth Rohde Christiansen.
2298
2299         [Qt] DumpRenderTreeQt needs an implementation of unmarkText
2300         https://bugs.webkit.org/show_bug.cgi?id=60499
2301
2302         The implementation is similar to gtk.
2303
2304         * DumpRenderTree/qt/TextInputControllerQt.cpp:
2305         (TextInputController::unmarkText):
2306         * DumpRenderTree/qt/TextInputControllerQt.h:
2307
2308 2011-05-09  James Robinson  <jamesr@chromium.org>
2309
2310         Reviewed by Eric Seidel.
2311
2312         [chromium] Teach new-run-webkit-tests to follow symlinks when trying to determine the arch of DumpRenderTree on linux
2313         https://bugs.webkit.org/show_bug.cgi?id=60520
2314
2315         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2316
2317 2011-05-09  Dmitry Lomov  <dslomov@google.com>
2318
2319         Reviewed by Sam Weinig.
2320
2321         Switch TestWebKitAPI to GTest
2322         https://bugs.webkit.org/show_bug.cgi?id=59561
2323
2324         * Scripts/build-api-tests:
2325         * Scripts/run-api-tests:
2326         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2327         * TestWebKitAPI/Test.h:
2328         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2329         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
2330         (TestWebKitAPI::TEST):
2331         * TestWebKitAPI/TestsController.cpp:
2332         (TestWebKitAPI::TestsController::TestsController):
2333         (TestWebKitAPI::TestsController::dumpTestNames):
2334         (TestWebKitAPI::TestsController::runTestNamed):
2335         (TestWebKitAPI::TestsController::runAllTests):
2336         * TestWebKitAPI/TestsController.h:
2337         * TestWebKitAPI/mac/main.mm:
2338         (main):
2339
2340 2011-05-09  Igor Oliveira  <igor.oliveira@openbossa.org>
2341
2342         Reviewed by Andreas Kling.
2343
2344         [Qt] DRT eventSender.addTouchPoint method is not setting the start position
2345         https://bugs.webkit.org/show_bug.cgi?id=60487
2346
2347         When adding a new touch point, the start position of this point needs to be set.
2348
2349         * DumpRenderTree/qt/EventSenderQt.cpp:
2350         (EventSender::addTouchPoint):
2351
2352 2011-05-09  Robert Hogan  <robert@webkit.org>
2353
2354         Reviewed by Adam Roben.
2355
2356         https://bugs.webkit.org/show_bug.cgi?id=57137
2357
2358         Unskip plugins/embed-prefers-plugins-for-images.html
2359
2360         Add image/png mime-type to test netscape plugin on Unix.
2361
2362         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2363         (NP_GetMIMEDescription):
2364
2365 2011-05-09  Alice Boxhall  <aboxhall@chromium.org>
2366
2367         Reviewed by Ojan Vafai.
2368
2369         Pull jsonresults_unittest test cases out into separate test methods.
2370         https://bugs.webkit.org/show_bug.cgi?id=60418
2371
2372         * TestResultServer/model/jsonresults_unittest.py:
2373
2374 2011-05-09  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2375
2376         Reviewed by Andreas Kling.
2377
2378         [Qt] fix fast/dom/Geolocation/window-close-crash.html
2379         https://bugs.webkit.org/show_bug.cgi?id=60458
2380
2381         Update all pages with Mock position/error/permission.
2382
2383         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2384         (LayoutTestController::setGeolocationPermission):
2385         (LayoutTestController::setMockGeolocationError):
2386         (LayoutTestController::setMockGeolocationPosition):
2387
2388 2011-05-09  Shishir Agrawal  <shishir@chromium.org>
2389
2390         Reviewed by Tony Gentilcore.
2391
2392         Implement Page Visibility API.
2393         https://bugs.webkit.org/show_bug.cgi?id=54181
2394
2395         * DumpRenderTree/LayoutTestController.cpp:
2396         (setPageVisibilityCallback):
2397         (resetPageVisibilityCallback):
2398         (LayoutTestController::staticFunctions):
2399         * DumpRenderTree/LayoutTestController.h:
2400         (LayoutTestController::setPageVisibility):
2401         (LayoutTestController::resetPageVisibility):
2402         * DumpRenderTree/chromium/LayoutTestController.cpp:
2403         (LayoutTestController::LayoutTestController):
2404         (LayoutTestController::resetPageVisibility):
2405         (LayoutTestController::setPageVisibility):
2406         * DumpRenderTree/chromium/LayoutTestController.h:
2407
2408 2011-05-07  Adam Barth  <abarth@webkit.org>
2409
2410         Reviewed by Eric Seidel.
2411
2412         Testing EWS spins on patches with a large number of failures
2413         https://bugs.webkit.org/show_bug.cgi?id=60441
2414
2415         In cases where the tree has a small number of persistent failures but a
2416         patch has a large number of failures, we weren't believing any results.
2417         That lead to us retrying the patch forever while we waited for
2418         trustworthy results that would never come.
2419
2420         This patch loosens the semantics of unexpected_failures to return a
2421         subset (rather than the exact set) of unexpected failures.  In the case
2422         where the tree has a bounded number of failures and the patch has an
2423         unbounded number of failures, we can accurately compute such a subset
2424         and reject the patch.
2425
2426         * Scripts/webkitpy/tool/bot/expectedfailures.py:
2427         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
2428         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2429         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2430         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2431
2432 2011-05-07  Joe Mason  <jmason@rim.com>
2433
2434         Reviewed by Daniel Bates.
2435
2436         FrameLoader::isProcessingUserGesture is wrong in dispatchWillPerformClientRedirect
2437         https://bugs.webkit.org/show_bug.cgi?id=52211
2438
2439         Dump isUserProcessingGesture in willPerformClientRedirect so that the layout tests can be extended.
2440         (For the Mac and Chromium ports - other ports don't support dumping user gestures in DRT.)
2441
2442         * DumpRenderTree/chromium/WebViewHost.cpp:
2443         (WebViewHost::willPerformClientRedirect):
2444         (WebViewHost::didStartProvisionalLoad):
2445         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2446         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
2447
2448 2011-05-07  Daniel Bates  <dbates@webkit.org>
2449
2450         Attempt to fix the build; remove some more references to isTiger(), which was removed in changeset 86007
2451         <http://trac.webkit.org/changeset/86007> (bug #60438).
2452
2453         * Scripts/old-run-webkit-tests:
2454           - Removed reference to isTiger() from openDumpTool(), captureSavedCrashLog(), and
2455             file local variable. 
2456
2457 2011-05-07  Pratik Solanki  <psolanki@apple.com>
2458
2459         Reviewed by Darin Adler.
2460
2461         Remove references to Tiger in scripts
2462         https://bugs.webkit.org/show_bug.cgi?id=60438
2463
2464         Remove isTiger() and all of the code that depends on it.
2465
2466         * Scripts/build-webkit:
2467         * Scripts/ensure-valid-python:
2468         * Scripts/gdb-safari:
2469         * Scripts/webkitdirs.pm:
2470
2471 2011-05-06  David Grogan  <dgrogan@chromium.org>
2472
2473         Reviewed by Eric Seidel.
2474
2475         update link to message about mac 64bit git binaries
2476         https://bugs.webkit.org/show_bug.cgi?id=60411
2477
2478         The original message implied (correctly, at-the-time) that
2479         http://code.google.com/p/git-osx-installer/ doesn't provide 64-bit
2480         binaries. The new message notes that they do. This might prevent someone
2481         else from spending a few minutes confused.
2482
2483         * Scripts/webkitpy/common/checkout/scm/git.py:
2484
2485 2011-05-06  Dirk Pranke  <dpranke@chromium.org>
2486
2487         Reviewed by Ojan Vafai.
2488
2489         new-run-webkit-tests: crashes in race with crashing DRT
2490         https://bugs.webkit.org/show_bug.cgi?id=60238
2491
2492         This fixes a race where if we wrote the URL to DRT and
2493         DRT crashed immediately, we could get a broken pipe
2494         error back during the write() and not handle it correctly,
2495         causing NRWT to also crash.
2496
2497         * Scripts/webkitpy/layout_tests/port/server_process.py:
2498         * Scripts/webkitpy/layout_tests/port/webkit.py:
2499
2500 2011-05-06  Adam Barth  <abarth@webkit.org>
2501
2502         Reviewed by Eric Seidel.
2503
2504         Add a --skip-integrationtests mode to test-webkitpy
2505         https://bugs.webkit.org/show_bug.cgi?id=60354
2506
2507         These two test suites account for 2/3 of test-webkitpy's running time
2508         because they're not actually unit tests.  They're integration tests.
2509         This patch adds the ability to skip integration tests by passing a
2510         command line argument to test-webkitpy.  The buildbots will continue to
2511         run these integration tests to make sure they don't regress.  This
2512         option is for use by developers when working on parts of the code that
2513         are well-covered by unit tests.
2514
2515         * Scripts/webkitpy/common/system/file_lock_integrationtest.py: Copied from Tools/Scripts/webkitpy/common/system/file_lock_unittest.py.
2516         * Scripts/webkitpy/common/system/file_lock_unittest.py: Removed.
2517         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Copied from Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py.
2518         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: Removed.
2519         * Scripts/webkitpy/test/main.py:
2520
2521 2011-05-06  Adam Barth  <abarth@webkit.org>
2522
2523         Reviewed by Eric Seidel.
2524
2525         The results.zip generated by the Chromium EWS are too big
2526         https://bugs.webkit.org/show_bug.cgi?id=60352
2527
2528         Currently results.zip created by the Chromium EWS bot contain roughly
2529         1000 tests that we expect to fail.  These test results are not helpful
2530         to contributors.
2531
2532         There are several approaches to solving this problem:
2533
2534         1) We could be more selective about which files to include in the zip.
2535         2) We could ask new-run-webkit-tests not to generate results for
2536            expected failures.
2537         3) We could ask new-run-webkit-tests not to run tests that we expect to
2538            fail.
2539
2540         This patch takes approach (3).  Currently, we're ignoring the outcome
2541         of failing tests anyway, so there's not much point in actually running
2542         them.  As a side benefit, this will speed up the test run by about 6%.
2543         In the future, we might revisit this decision and choose another
2544         approach.
2545
2546         * Scripts/webkitpy/common/config/ports.py:
2547         * Scripts/webkitpy/common/config/ports_unittest.py:
2548
2549 2011-05-06  Gabor Rapcsanyi  <rgabor@webkit.org>
2550
2551         Reviewed by Csaba Osztrogonác.
2552
2553         [Qt] Use qt-arm platform instead of qt-linux on ARM platform.
2554
2555         * Scripts/old-run-webkit-tests:
2556
2557 2011-05-06  Adam Barth  <abarth@webkit.org>
2558
2559         Reviewed by Ojan Vafai.
2560
2561         Add an option to NRWT to skip failing tests
2562         https://bugs.webkit.org/show_bug.cgi?id=60295
2563
2564         This option is similar to the way old-run-webkit-tests works.  We're
2565         planning to use this option on the testing EWS bots because they don't
2566         use information from failing tests yet.
2567
2568         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2569         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2570         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2571
2572 2011-05-04  Philippe Normand  <pnormand@igalia.com>
2573
2574         Reviewed by Dimitri Glazkov.
2575
2576         Implement LayoutTestController::pseudoShadowId()
2577         https://bugs.webkit.org/show_bug.cgi?id=60034
2578
2579         shadowPseudoId support in the various LayoutTestController
2580         implementations.
2581
2582         * DumpRenderTree/LayoutTestController.cpp:
2583         (shadowPseudoIdCallback):
2584         (LayoutTestController::staticFunctions):
2585         * DumpRenderTree/LayoutTestController.h:
2586         * DumpRenderTree/chromium/LayoutTestController.cpp:
2587         (LayoutTestController::LayoutTestController):
2588         (LayoutTestController::shadowPseudoId):
2589         * DumpRenderTree/chromium/LayoutTestController.h:
2590         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2591         (LayoutTestController::shadowPseudoId):
2592         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2593         (LayoutTestController::shadowPseudoId):
2594         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2595         (LayoutTestController::shadowPseudoId):
2596         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2597         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2598         (LayoutTestController::shadowPseudoId):
2599         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2600         (LayoutTestController::shadowPseudoId):
2601         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2602         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2603         (WTR::LayoutTestController::shadowPseudoId):
2604         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2605
2606 2011-05-06  Adam Barth  <abarth@webkit.org>
2607
2608         EWS can't reject patches
2609         https://bugs.webkit.org/show_bug.cgi?id=60345
2610
2611         We're supposed to use patch.id() for the attachment ID, silly.
2612
2613         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2614         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2615
2616 2011-05-05  Steve Lacey  <sjl@chromium.org>
2617
2618         Reviewed by Ojan Vafai.
2619
2620         Fix generation of results html file by passing relative path to scm
2621         methods.
2622         Generate diff images for results html file.
2623
2624         https://bugs.webkit.org/show_bug.cgi?id=60086
2625
2626         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2627         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2628
2629 2011-05-05  Andy Estes  <aestes@apple.com>
2630
2631         Reviewed by Daniel Bates.
2632
2633         update-webkit should handle Internal using a different VCS than OpenSource.
2634         https://bugs.webkit.org/show_bug.cgi?id=60310
2635
2636         isGit() and isSVN() cache their results, so Internal will always be
2637         updated using the VCS commands used for OpenSource. If Internal uses a
2638         different VCS, this will fail. Fix this by calling isGitDirectory() and
2639         isSVNDirectory() instead, which do not cache their results.
2640
2641         * Scripts/update-webkit:
2642
2643 2011-05-05  Dirk Pranke  <dpranke@chromium.org>
2644
2645         Reviewed by Ojan Vafai.
2646
2647         nrwt: revamp integration tests incl. tests for servers
2648         https://bugs.webkit.org/show_bug.cgi?id=59985
2649
2650         This change adds the ability to run "integration tests" that
2651         depend on (and affect) the local environment on your machine.
2652         These tests can be run manually by invoking python on the
2653         test file in question and passing the '-i' flag, but are
2654         not run automatically as part of test-webkitpy.
2655
2656         Integration tests are identified by being methods named as
2657         "integration_test_*" instead of "test_*", and we use a
2658         custom TestLoader instead of the default one provided by
2659         unittest.
2660
2661         This change also adds a protected "_default_to_apache" method
2662         to the port object so we can do the right thing when starting
2663         and stopping web servers with less mechanism.
2664
2665         * Scripts/webkitpy/layout_tests/port/base.py:
2666         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2667         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2668         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2669         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2670         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2671
2672 2011-05-05  Adam Roben  <aroben@apple.com>
2673
2674         Robustify DRT's pixel-dumping code against semi-random alpha channel values on Windows
2675
2676         DRT generates a pixel dump on Windows using the WM_PRINT message. This message (just like
2677         most of GDI) doesn't write anything meaningful into the alpha channel. In some cases, the
2678         alpha channel will even get filled with zeros (like when ::GradientFill is used). To
2679         safeguard against this, we fill the alpha channel with constant full opacity after the
2680         WM_PRINT message is handled to ensure we end up with an opaque image. (Note that we can't
2681         just ignore the alpha channel when creating the PNG; Mac's pixel results have an alpha
2682         channel, and we want to be able to compare Mac and Windows pixel results, so Windows pixel
2683         results need an alpha channel, too.)
2684
2685         Fixes <http://webkit.org/b/60300> draws-gradient.html's pixel results can't be correctly
2686         generated due to alpha channel weirdness
2687
2688         Reviewed by Sam Weinig.
2689
2690         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
2691         (makeAlphaChannelOpaque): Added this helper function to fill a bitmap's alpha channel with
2692         constant full opacity.
2693         (createBitmapContextFromWebView): Make the bitmap's alpha channel opaque before wrapping it
2694         in a CGContext or cairo_surface.
2695
2696 2011-05-05  Adam Roben  <aroben@apple.com>
2697
2698         Add support for layoutTestController.dumpAsText(true) to WebKitTestRunner
2699
2700         Passing true tells the test harness to dump pixels even though we're not dumping a render
2701         tree.
2702
2703         Fixes <http://webkit.org/b/60298> Calling layoutTestController.dumpAsText(true) in
2704         WebKitTestRunner doesn't result in pixel results being generated
2705
2706         Reviewed by Sam Weinig.
2707
2708         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added dumpPixels
2709         argument to dumpAsText.
2710
2711         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2712         (WTR::InjectedBundlePage::dump): Updated for dumpAsText change.
2713
2714         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2715         (WTR::LayoutTestController::dumpAsText): Store the dumpPixels argument.
2716
2717         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Updated for IDL change.
2718
2719         * WebKitTestRunner/win/InjectedBundle.vcproj: Added .idl files as a convenience for Windows
2720         developers.
2721
2722 2011-05-05  Dirk Pranke  <dpranke@chromium.org>
2723
2724         Reviewed by Ojan Vafai.
2725
2726         new-run-webkit-tests: merge os, version fields in test config
2727         https://bugs.webkit.org/show_bug.cgi?id=60004
2728
2729         This change removes the 'o/s' field from the TestConfiguration
2730         object, and changes the 'MAC', 'WIN', and 'LINUX' modifiers in
2731         the expectations file to macros that expand to the version names
2732         for each platform.
2733
2734         This means that you can once again put any subset of the
2735         operating system versions on a single line, e.g.:
2736           BUGX LEOPARD XP LINUX : fast/html/foo.html = FAIL
2737
2738         This change will break any existing test_expectations.txt
2739         file that uses the "OS-VERSION" macros, which are no longer
2740         needed. It turns out they were never needed, as just VERSION
2741         by itself was sufficient. The test_expectations.txt file should
2742         be updated accordingly prior to landing this change.
2743
2744         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2745         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2746         * Scripts/webkitpy/layout_tests/port/base.py:
2747
2748 2011-05-05  Tony Chang  <tony@chromium.org>
2749
2750         Reviewed by Adam Barth.
2751
2752         [chromium] switch from Lucida to free fonts for Hindi and Thai
2753         https://bugs.webkit.org/show_bug.cgi?id=60287
2754
2755         The fonts are provided by the ttf-thai-tlwg and ttf-indic-fonts
2756         packages on Lucid. There are actually multiple Thai fonts in the
2757         package, so I just picked one.
2758
2759         * DumpRenderTree/chromium/TestShellGtk.cpp:
2760         (setupFontconfig):
2761
2762 2011-05-05  Tony Chang  <tony@chromium.org>
2763
2764         Reviewed by Ojan Vafai.
2765
2766         [chromium] google-chrome-64 builds should now fallback to chromium-linux-x86_64 results
2767         https://bugs.webkit.org/show_bug.cgi?id=60290
2768
2769         It used to be that google-chrome-32 was hardy32, google-chrome-64 was
2770         hardy64, chromium-linux was hardy32 and chromium-linux-x86_64 was
2771         lucid64.  Because of that, google-chrome-64 used to skip the
2772         chromium-linux-x86_64 results since they were more incorrect.
2773
2774         Now that we're switching to lucid for google-chrome, we want
2775         google-chrome-64 to fall back to chromium-linux-x86_64.
2776
2777         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2778
2779 2011-05-05  Dirk Pranke  <dpranke@chromium.org>
2780
2781         Reviewed by Ojan Vafai.
2782
2783         new-run-webkit-tests: merge TestExpectations, TestExpectationsFile classes
2784         https://bugs.webkit.org/show_bug.cgi?id=60002
2785
2786         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2787         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2788         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
2789         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2790         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2791         * Scripts/webkitpy/style/checkers/test_expectations.py:
2792
2793 2011-05-05  Eric Seidel  <eric@webkit.org>
2794
2795         Reviewed by Adam Barth.
2796
2797         commit-queue should reject patches which fail ewses
2798         https://bugs.webkit.org/show_bug.cgi?id=47534
2799
2800         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2801         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2802         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2803
2804 2011-05-05  Chang Shu  <cshu@webkit.org>
2805
2806         Reviewed by Andreas Kling.
2807
2808         [Qt][WK2] Support PageGroup in QGraphicsWKView/QWKPage constructors
2809         https://bugs.webkit.org/show_bug.cgi?id=59638
2810
2811         1. Call QGraphicsWKView constructor with pageGroupRef.
2812         2. Disable setFontFamily calls as it breaks Qt test fonts.
2813
2814         * WebKitTestRunner/TestController.cpp:
2815         (WTR::TestController::resetStateToConsistentValues):
2816         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2817         (WTR::WebView::WebView):
2818         (WTR::PlatformWebView::PlatformWebView):
2819
2820 2011-05-05  Joseph Pecoraro  <joepeck@webkit.org>
2821
2822         Reviewed by David Kilzer.
2823
2824         Add --only-webkit option to build-webkit
2825         https://bugs.webkit.org/show_bug.cgi?id=60245
2826
2827         * Scripts/build-webkit: If --only-webkit was specified
2828         just build the WebKit project, and not its dependencies.
2829
2830 2011-05-05  Jeff Miller  <jeffm@apple.com>
2831
2832         Reviewed by Darin Adler.
2833
2834         Add didNotHandleWheelEvent callback to WKPageUIClient
2835         https://bugs.webkit.org/show_bug.cgi?id=60203
2836
2837         * MiniBrowser/gtk/BrowserWindow.c:
2838         (browserWindowUIClientInit): Stub out didNotHandleWheelEvent callback.
2839         * MiniBrowser/mac/BrowserWindowController.m:
2840         (-[BrowserWindowController awakeFromNib]): Stub out didNotHandleWheelEvent callback.
2841         * MiniBrowser/win/BrowserView.cpp:
2842         (BrowserView::create): Stub out didNotHandleWheelEvent callback.
2843         * WebKitTestRunner/TestController.cpp:
2844         (WTR::TestController::createOtherPage): Stub out didNotHandleWheelEvent callback.
2845         (WTR::TestController::initialize): Stub out didNotHandleWheelEvent callback.
2846
2847 2011-05-04  Eric Seidel  <eric@webkit.org>
2848
2849         Reviewed by Adam Barth.
2850
2851         Add more missing imports from scm refactor
2852         https://bugs.webkit.org/show_bug.cgi?id=60239
2853
2854         * Scripts/webkitpy/common/checkout/scm/git.py:
2855         * Scripts/webkitpy/common/checkout/scm/svn.py:
2856
2857 2011-05-04  Eric Seidel  <eric@webkit.org>
2858
2859         Reviewed by Adam Barth.
2860
2861         sheriff-bot is having more exception trouble
2862         https://bugs.webkit.org/show_bug.cgi?id=60233
2863
2864         A webpage-forced build was causing SB to throw an exception.
2865         We've long had this bug, but we just didn't notice it until now.
2866
2867         In debugging this I found we fetch an absurd amount of data now
2868         that we use buildbot's json (instead of xmlrpc), so I added
2869         the filter=1 parameter to reduce it a little.  That required
2870         me to handle the case where filter=1 would strip
2871         result=0 in some cases (it's unclear why it does that).
2872
2873         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2874         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2875
2876 2011-05-04  Cris Neckar  <cdn@chromium.org>
2877
2878         Unreviewed, Adding Cris Neckar as a committer
2879
2880         * Scripts/webkitpy/common/config/committers.py:
2881
2882 2011-05-04  Siddharth Mathur  <siddharth.mathur@nokia.com>
2883
2884         Reviewed by Laszlo Gombos.
2885
2886         [Qt][Wk2][Symbian] Capabilities for Qt MiniBrowser and QtWebProcess on Symbian
2887         https://bugs.webkit.org/show_bug.cgi?id=59462
2888
2889         * MiniBrowser/qt/MiniBrowser.pro: Add Symbian OS capabilities to executable. Also enable data paging. 
2890
2891 2011-05-04  Eric Seidel  <eric@webkit.org>
2892
2893         Reviewed by Adam Barth.
2894
2895         The testing EWS bots should upload layout-test-results.zip to bugs after failures
2896         https://bugs.webkit.org/show_bug.cgi?id=60223
2897
2898         This required sharing a bit of code between the commit-queue
2899         (which already knew how to do this) and the new EWS testing bots.
2900
2901         In the process I also cleaned up EWS testing a little and
2902         removed some dead code from the commit-queue.
2903
2904         * Scripts/webkitpy/common/config/committervalidator.py:
2905         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2906         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2907         * Scripts/webkitpy/tool/commands/queues.py:
2908         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2909
2910 2011-05-04  James Kozianski  <koz@chromium.org>
2911
2912         Reviewed by Eric Seidel.
2913
2914         Add method to make a Port able to retrieve TestOutputSets from its builders.
2915         https://bugs.webkit.org/show_bug.cgi?id=58211
2916
2917         This will be used in the new rebaseline script - TestOutputs are
2918         potential new baselines.
2919
2920         * Scripts/webkitpy/common/config/urls.py:
2921         * Scripts/webkitpy/layout_tests/port/base.py:
2922         * Scripts/webkitpy/layout_tests/port/chromium.py:
2923         * Scripts/webkitpy/layout_tests/port/factory.py:
2924         * Scripts/webkitpy/layout_tests/port/webkit.py:
2925
2926 2011-05-04  Eric Seidel  <eric@webkit.org>
2927
2928         Reviewed by Ojan Vafai.
2929
2930         sheriff-bot can't parse results.html
2931         https://bugs.webkit.org/show_bug.cgi?id=60196
2932
2933         The problem was that the NRWT bots are currently core
2934         and so sheriff-bot was trying to diagnose failures on
2935         them.  It was trying to parse their results.html file
2936         and BeautifulSoup was throwing an exception.
2937
2938         It seems our version of BeautifulSoup was quite old
2939         and unable to handle <script> tags correctly.
2940         This moves us to 3.2 which doesn't seem to have this bug.
2941
2942         * Scripts/webkitpy/thirdparty/BeautifulSoup.py:
2943
2944 2011-05-04  Adam Barth  <abarth@webkit.org>
2945
2946         Reviewed by Eric Seidel.
2947
2948         Make the EWS test logging less verbose
2949         https://bugs.webkit.org/show_bug.cgi?id=60201
2950
2951         This should help us generate less than a hundred MB of logs per hour.
2952
2953         * Scripts/webkitpy/common/config/ports.py:
2954         * Scripts/webkitpy/common/config/ports_unittest.py:
2955
2956 2011-05-04  Tao Bai  <michaelbai@chromium.org>
2957
2958         Reviewed by David Kilzer.
2959
2960         Populate touch-icon url to FrameLoaderClient
2961         https://bugs.webkit.org/show_bug.cgi?id=59143
2962
2963         Disable touch icon by default. 
2964
2965         * Scripts/build-webkit:
2966
2967 2011-05-04  Justin Novosad  <junov@chromium.org>
2968
2969         Reviewed by Kenneth Russell.
2970
2971         [Chromium] Add gpu acceleration flags to DumpRenderTree
2972         https://bugs.webkit.org/show_bug.cgi?id=60168
2973         Adding support for command line flags 
2974         enable-accelerated-2d-canvas an
2975         enable-accelerated-drawing in DumpRenderTree.
2976
2977         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2978         (main):
2979         * DumpRenderTree/chromium/TestShell.cpp:
2980         (TestShell::TestShell):
2981         (TestShell::resetWebSettings):
2982         * DumpRenderTree/chromium/TestShell.h:
2983         (TestShell::setLegacyAccelerated2dCanvasEnabled):
2984         (TestShell::setAcceleratedDrawingEnabled):
2985         * DumpRenderTree/chromium/WebPreferences.cpp:
2986         (WebPreferences::reset):
2987         (WebPreferences::applyTo):
2988         * DumpRenderTree/chromium/WebPreferences.h:
2989
2990 2011-05-04  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
2991
2992         Reviewed by Csaba Osztrogonác.
2993
2994         [Qt] run-qtwebkit-tests misses exec bit
2995         https://bugs.webkit.org/show_bug.cgi?id=60188
2996
2997         Also removing an unecessary import (mostly to let this bugfix goes
2998         through the system, as this is just a chmod).
2999
3000         * Scripts/run-qtwebkit-tests:
3001
3002 2011-05-04  Adam Barth  <abarth@webkit.org>
3003
3004         Fix import of ircproxy module to actually import the module.  I don't
3005         really understand how this code could have worked before.
3006
3007         * Scripts/webkitpy/common/host.py:
3008
3009 2011-05-04  Siddharth Mathur  <siddharth.mathur@nokia.com>
3010
3011         Reviewed by Andreas Kling.
3012
3013         [Qt][Wk2][Symbian] Minor UI facelift for MiniBrowser
3014         https://bugs.webkit.org/show_bug.cgi?id=60172
3015
3016         * MiniBrowser/qt/BrowserWindow.cpp: Bring in UI layout changes from QtTestBrowser
3017         (BrowserWindow::BrowserWindow):
3018
3019 2011-05-04  Mihai Parparita  <mihaip@chromium.org>
3020
3021         Reviewed by Ojan Vafai.
3022
3023         [NRWT] --new-baseline should put baselines in the directory specified by --additional-platform-directory
3024         https://bugs.webkit.org/show_bug.cgi?id=60088
3025         
3026         Makes --new-baseline put new baselines into the first entry in the
3027         baseline search path, including any additional directories passed in via
3028         --additional-platform-directory.
3029         
3030         Simplifies baseline_path() by making it return the first entry in the
3031         baseline search path instead of requiring each port to have an
3032         implementation (should not result in any behavior change).
3033
3034         * Scripts/webkitpy/layout_tests/port/base.py:
3035         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3036         * Scripts/webkitpy/layout_tests/port/chromium.py:
3037         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3038         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3039         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3040         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3041         * Scripts/webkitpy/layout_tests/port/mac.py:
3042         * Scripts/webkitpy/layout_tests/port/test.py:
3043         * Scripts/webkitpy/layout_tests/port/webkit.py:
3044
3045 2011-05-04  Adam Barth  <abarth@webkit.org>
3046
3047         Reviewed by Eric Seidel.
3048
3049         Fix circular dependency in webkitpy
3050         https://bugs.webkit.org/show_bug.cgi?id=60075
3051
3052         These functions don't belong in bugzilla.py.  They only exist there
3053         because they are old.  Really, these functions shouldn't be free
3054         functions at all, but that's a patch for another day.
3055
3056         * Scripts/webkitpy/common/checkout/changelog.py:
3057         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3058         * Scripts/webkitpy/common/checkout/checkout.py:
3059         * Scripts/webkitpy/common/config/urls.py:
3060         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
3061         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3062         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3063         * Scripts/webkitpy/style/checkers/changelog.py:
3064         * Scripts/webkitpy/tool/bot/irc_command.py:
3065         * Scripts/webkitpy/tool/bot/sheriff.py:
3066         * Scripts/webkitpy/tool/commands/upload.py:
3067
3068 2011-05-03  Pratik Solanki  <psolanki@apple.com>
3069
3070         Reviewed by Dan Bernstein.
3071
3072         https://bugs.webkit.org/show_bug.cgi?id=60141
3073         Remove reference to libWebKitSystemInterfaceTiger.a from build-webkit
3074
3075         * Scripts/build-webkit:
3076
3077 2011-05-03  Mihai Parparita  <mihaip@chromium.org>
3078
3079         Reviewed by Ojan Vafai.
3080
3081         Update rebaseline queue server to handle hierarchical test results
3082         https://bugs.webkit.org/show_bug.cgi?id=60063
3083         
3084         Update test result parsing done by the rebaseline queue server to handle
3085         the hierarchical test result output that is generated as of r85254.
3086
3087         * RebaselineQueueServer/templates/builder-queue-edit.html:
3088
3089 2011-05-03  Eric Seidel  <eric@webkit.org>
3090
3091         Reviewed by Adam Roben.
3092
3093         webkit-patch post-commits HEAD^.. throws an exception
3094         https://bugs.webkit.org/show_bug.cgi?id=60027
3095
3096         * Scripts/webkitpy/common/checkout/scm/git.py:
3097
3098 2011-05-03  Luiz Agostini  <luiz.agostini@openbossa.org>
3099
3100         Reviewed by Kenneth Rohde Christiansen.
3101
3102         [Qt] Layout tests may timeout if loadFinished receives false
3103         https://bugs.webkit.org/show_bug.cgi?id=60064
3104
3105         When using layoutTestController.queueLoad(), if QWebPage::loadFinished(bool) receives false
3106         then the layout test may timout. It happens that QWebPage::loadFinished() receives false when
3107         a response is ignored, like it should be for 204 responses. It is a problem for creating
3108         tests for 204 responses for example.
3109
3110         This change has been tested and it causes no regressions in layout tests.
3111
3112         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3113         (LayoutTestController::maybeDump):
3114
3115 2011-05-03  Dirk Pranke  <dpranke@chromium.org>
3116
3117         Unreviewed, rolling out r85659.
3118         http://trac.webkit.org/changeset/85659
3119         https://bugs.webkit.org/show_bug.cgi?id=59977
3120
3121         restarting isn't working correctly
3122
3123         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
3124         * Scripts/webkitpy/layout_tests/port/http_server.py:
3125         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
3126         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
3127
3128 2011-05-03  Dirk Pranke  <dpranke@chromium.org>
3129
3130         Reviewed by Ojan Vafai.
3131
3132         new-run-webkit-tests: fix http server startup/shutdown
3133
3134         Previous versions of the code had three problems that made startup
3135         and shutdown flaky. The first is that it would throw exceptions
3136         if it couldn't delete stale log files, which was overly
3137         paranoid. The second is that some of the exceptions weren't
3138         defined properly. The third, and most important, is that it was
3139         using urllib to check if ports were available, which was leaving
3140         sockets in a half-closed state, and keeping ports from being
3141         reused. By switching to raw sockets, we are able to now reliably
3142         restart.
3143
3144         This change also switches the code to using Executives to stop
3145         processes, which will let us delete a bunch of code in the
3146         port/* implementations and fix a weird layering problem in a
3147         subsequent patch.
3148
3149         https://bugs.webkit.org/show_bug.cgi?id=59977
3150
3151         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
3152         * Scripts/webkitpy/layout_tests/port/http_server.py:
3153         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
3154         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
3155
3156 2011-05-03  Dirk Pranke  <dpranke@chromium.org>
3157
3158         Reviewed by Adam Barth.
3159
3160         fix failing printing_unittest on win32
3161         https://bugs.webkit.org/show_bug.cgi?id=59963
3162
3163         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3164
3165 2011-05-03  Adam Roben  <aroben@apple.com>
3166
3167         Fix most strict PassOwnPtr violations on Windows
3168
3169         Fixes <http://webkit.org/b/60025> Windows should (almost) build with strict PassOwnPtr
3170         enabled
3171
3172         Reviewed by Anders Carlsson.
3173
3174         * WebKitAPITest/Test.h: Use adoptPtr.
3175
3176 2011-05-03  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
3177
3178         Reviewed by Andreas Kling.
3179
3180         Add myself to the committers list.
3181
3182         * Scripts/webkitpy/common/config/committers.py:
3183
3184 2011-05-03  James Robinson  <jamesr@chromium.org>
3185
3186         Reviewed by Kenneth Russell.
3187
3188         [chromium] Layout test animations/3d/replace-filling-transform.html failing
3189         https://bugs.webkit.org/show_bug.cgi?id=59839
3190
3191         Add animations/3d to the list of tests run in the chromium-gpu configuration since these tests exercise the compositor.
3192
3193         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3194
3195 2011-05-03  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3196
3197         Unreviewed, rolling out r85471.
3198         http://trac.webkit.org/changeset/85471
3199         https://bugs.webkit.org/show_bug.cgi?id=59922
3200
3201         The rule of thumb in EFL is that you init in all the places
3202         you use it. So, if in your application you call ecore_evas_*
3203         functions, you have to call ecore_evas_init() first.
3204
3205         * EWebLauncher/main.c: always call *_init() functions when you use
3206         that namespace.
3207         (quit):
3208         (main):
3209
3210 2011-05-02  Ojan Vafai  <ojan@chromium.org>
3211
3212         Reviewed by Tony Chang.
3213
3214         remove no longer used method
3215         https://bugs.webkit.org/show_bug.cgi?id=59981
3216
3217         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3218         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3219
3220 2011-05-02  Ojan Vafai  <ojan@chromium.org>
3221
3222         Reviewed by Tony Chang.
3223
3224         add image toggling behavior from old-run-webkit-tests
3225         https://bugs.webkit.org/show_bug.cgi?id=59978
3226
3227         Output -diffs.html files. This matches old-run-webkit-tests.
3228         In theory, we could use data urls in the results.html file, but
3229         data urls don't currently have access to local files.
3230
3231         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
3232
3233 2011-05-02  Tony Chang  <tony@chromium.org>
3234
3235         Reviewed by Ojan Vafai.
3236
3237         [nrwt] remove some obsolete references to .checksum files
3238         https://bugs.webkit.org/show_bug.cgi?id=59971
3239
3240         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3241         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
3242         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3243         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
3244         * Scripts/webkitpy/layout_tests/port/test.py:
3245         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3246
3247 2011-05-02  Adam Roben  <aroben@apple.com>
3248
3249         Take advantage of implicit nullptr_t -> PassOwnPtr conversion
3250
3251         Fixes <http://webkit.org/b/59964> Implicit conversion from std::nullptr_t to PassOwnPtr
3252         doesn't work, but should
3253
3254         Reviewed by Adam Barth.
3255
3256         * DumpRenderTree/chromium/CppBoundClass.h:
3257         * DumpRenderTree/chromium/WebViewHost.cpp:
3258
3259 2011-05-02  Martin Robinson  <mrobinson@igalia.com>
3260
3261         Reviewed by Xan Lopez.
3262
3263         [GTK] Compiler warning in Tools/MiniBrowser/main.c
3264         https://bugs.webkit.org/show_bug.cgi?id=59986
3265
3266         Remove a compiler warning.
3267
3268         * MiniBrowser/gtk/main.c: Use full array initializers to prevent some compilers
3269         from complaining.
3270
3271 2011-05-02  Adam Barth  <abarth@webkit.org>
3272
3273         Reviewed by Eric Seidel.
3274
3275         Add runtests_unittest.py
3276         https://bugs.webkit.org/show_bug.cgi?id=59955
3277
3278         I forgot to add this file in a previous patch.
3279
3280         * Scripts/webkitpy/tool/steps/runtests_unittest.py: Added.
3281
3282 2011-05-02  Adam Barth  <abarth@webkit.org>
3283
3284         Change the testing EWS to log failures explicitly to avoid an infinite loop.
3285
3286         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3287
3288 2011-05-02  Adrienne Walker  <enne@google.com>
3289
3290         Unreviewed, fix misspelled contributor name.
3291
3292         * Scripts/webkitpy/common/config/committers.py:
3293
3294 2011-05-02  Adam Barth  <abarth@webkit.org>
3295
3296         Reviewed by Eric Seidel.
3297
3298         cr-linux-ews should run tests
3299         https://bugs.webkit.org/show_bug.cgi?id=59272
3300
3301         This patch turns on testing for the cr-linux-ews.  Yay!
3302
3303         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3304         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3305         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3306         * Scripts/webkitpy/tool/steps/runtests.py:
3307         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3308
3309 2011-05-02  Martin Robinson  <mrobinson@igalia.com>
3310
3311         Incorporate a review comment that I mistakenly omitted from my last commit.
3312
3313         * DumpRenderTree/gtk/EventSender.cpp: Use unsigned here instead of unsigned int.
3314
3315 2011-05-02  Adam Barth  <abarth@webkit.org>
3316
3317         Reviewed by Eric Seidel.
3318
3319         EWS should report the list of unexpected failures
3320         https://bugs.webkit.org/show_bug.cgi?id=59923
3321
3322         We cache the results of the first layout test results run on the task
3323         so the EWS can grab them later.  Another option is to include them in
3324         the exception that's thrown, but this approach seemed slightly more
3325         aesthetic.
3326
3327         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3328         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3329
3330 2011-05-02  Adam Barth  <abarth@webkit.org>
3331
3332         Reviewed by Eric Seidel.
3333
3334         Add base case for a test-running EWS
3335         https://bugs.webkit.org/show_bug.cgi?id=59920
3336
3337         Later I will subclass this to run the Chromium Linux EWS.
3338
3339         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py: Added.
3340         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3341         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3342
3343 2011-05-02  Anders Carlsson  <andersca@apple.com>
3344
3345         Build fix.
3346
3347         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3348         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3349
3350 2011-05-02  Nico Weber  <thakis@chromium.org>
3351
3352         Reviewed by Mihai Parparita.
3353
3354         Add --no-webkit2 to the output of "build-webkit -h"
3355         https://bugs.webkit.org/show_bug.cgi?id=59942
3356
3357         * Scripts/build-webkit:
3358
3359 2011-05-02  Martin Robinson  <mrobinson@igalia.com>
3360
3361         Reviewed by Xan Lopez.
3362
3363         [GTK] old-run-webkit-tests should disable the Ubuntu overlay scrollbar
3364         https://bugs.webkit.org/show_bug.cgi?id=59943
3365
3366         Disable the Ubuntu overlay scrollbar while testing, by injecting the
3367         LIBOVERLAY_SCROLLBAR=0 environment variable.
3368
3369         * Scripts/old-run-webkit-tests:
3370
3371 2011-05-02  Martin Robinson  <mrobinson@igalia.com>
3372
3373         Reviewed by Eric Seidel.
3374
3375         [GTK] editing/selection/select-out-of-editable.html failing after r83967
3376         https://bugs.webkit.org/show_bug.cgi?id=58667
3377
3378         Do not trigger mouse down events when the EventSender knows that a mouse button is
3379         already down. These type of situations can confuse Xvfb and cause dragging failures.
3380
3381         * DumpRenderTree/gtk/EventSender.cpp:
3382         (mouseDownCallback): Do not trigger another mouse button down event if the mouse button
3383         is already down. This can interfere with drags in Xvfb.
3384
3385 2011-05-02  Zsolt Fehér  <h490267@stud.u-szeged.hu>
3386
3387         Reviewed by Csaba Osztrogonác.
3388
3389         DRT sideeffect revealed by r71268.
3390         https://bugs.webkit.org/show_bug.cgi?id=48958
3391
3392         Reset QWebSettings::ZoomTextOnly attribute before all tests. 
3393
3394         Call setTextSizeMultiplier(1.0) to reset TextZoomFactor and 
3395         PageZoomFactor too. It should be done before resetsettings() 
3396         to guarantee resetting QWebSettings::ZoomTextOnly correctly.
3397
3398         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3399         (WebCore::WebPage::resetSettings):
3400         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3401
3402 2011-05-02  Sheriff Bot  <webkit.review.bot@gmail.com>
3403
3404         Unreviewed, rolling out r85469.
3405         http://trac.webkit.org/changeset/85469
3406         https://bugs.webkit.org/show_bug.cgi?id=59928
3407
3408         Broke  webkitpy-tests on Windows 7, GTK and Qt. (Requested by
3409         bbandix on #webkit).
3410
3411         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py: Removed.
3412         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3413         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3414
3415 2011-05-02  Tomasz Morawski  <t.morawski@samsung.com>
3416
3417         Reviewed by Kenneth Rohde Christiansen.
3418
3419         Cleanup EFL initialization/shutdown in the EWebLauncher
3420         https://bugs.webkit.org/show_bug.cgi?id=59922
3421
3422         Removed ecore_evas_init and edje_init form main function due to they
3423         are also called in the ewk_init. Moved ewk_shutdown to quit function.
3424
3425         * EWebLauncher/main.c:
3426         (quit):
3427         (main):
3428
3429 2011-05-02  Adam Barth  <abarth@webkit.org>
3430
3431         Reviewed by Eric Seidel.
3432
3433         Add base case for a test-running EWS
3434         https://bugs.webkit.org/show_bug.cgi?id=59920
3435
3436         Later I will subclass this to run the Chromium Linux EWS.
3437
3438         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py: Added.
3439         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3440         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3441
3442 2011-05-02  Adam Barth  <abarth@webkit.org>
3443
3444         Reviewed by Eric Seidel.
3445
3446         Add the ability to skip python and perl unit tests on EC2
3447         https://bugs.webkit.org/show_bug.cgi?id=59918
3448
3449         * Scripts/webkitpy/common/config/ports.py:
3450             - This is slightly ugly, but it's useful...
3451         * Scripts/webkitpy/common/config/ports_unittest.py:
3452         * Scripts/webkitpy/tool/mocktool.py:
3453         * Scripts/webkitpy/tool/steps/runtests.py:
3454
3455 2011-05-02  Adam Barth  <abarth@webkit.org>
3456
3457         Reviewed by Eric Seidel.
3458
3459         webkit-patch --non-interactive is incompatible with new-run-webkit-tests
3460         https://bugs.webkit.org/show_bug.cgi?id=59919
3461
3462         new-run-webkit-tests doesn't support --wait-for-httpd (because it
3463         always waits for HTTPD, as I understand things).  It turns out we're
3464         not really using this flag for anything, so we should just remove it.
3465
3466         * Scripts/webkitpy/tool/steps/runtests.py:
3467         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3468
3469 2011-05-01  Eric Seidel  <eric@webkit.org>
3470
3471         Reviewed by Adam Barth.
3472
3473         The bots should learn from expected failures without having to retry
3474         https://bugs.webkit.org/show_bug.cgi?id=59279
3475
3476         Rather than re-trying the whole patch, we can just check whether we now
3477         expect the failures we see with the patch applied, saving a lot of time.
3478
3479         This patch also teaches the CommitQueue how to reject patches even
3480         when the tree is red using the new unexpected_failures() method on
3481         ExpectedFailures.
3482
3483         Finally in testing we found a bug in ExpectedFailures where it would
3484         "trust" results which had many many failures, due to using an
3485         equal sign instead of a less-than sign.
3486
3487         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py
3488         * Scripts/webkitpy/tool/bot/expectedfailures.py
3489         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py
3490         * Scripts/webkitpy/tool/bot/patchanalysistask.py
3491
3492
3493 2011-05-02  Adam Barth  <abarth@webkit.org>
3494
3495         Reviewed by Eric Seidel.
3496
3497         workspace.py fails to import ScriptError
3498         https://bugs.webkit.org/show_bug.cgi?id=59915
3499
3500         If the workspace fails to create a zip, webkitpy crashes instead of
3501         handling the error as expected.
3502
3503         * Scripts/webkitpy/common/system/workspace.py:
3504         * Scripts/webkitpy/common/system/workspace_unittest.py:
3505         * Scripts/webkitpy/tool/mocktool.py:
3506
3507 2011-05-01  Adam Barth  <abarth@webkit.org>
3508
3509         Remove unadvertantly added file.
3510
3511         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3512
3513 2011-05-01  Adam Barth  <abarth@webkit.org>
3514
3515         Reviewed by Eric Seidel.
3516
3517         expectedfailures.py should report the unexpected failures when asked
3518         https://bugs.webkit.org/show_bug.cgi?id=59916
3519
3520         This information is useful when the EWS runs tests.
3521
3522         * Scripts/webkitpy/tool/bot/expectedfailures.py:
3523         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
3524
3525 2011-05-01  Adam Barth  <abarth@webkit.org>
3526
3527         Reviewed by Eric Seidel.
3528
3529         JSONTestResult needs to handle multiple results
3530         https://bugs.webkit.org/show_bug.cgi?id=59269
3531
3532         This case occurs when a test is flaky because NRWT will run the test
3533         twice and report both results as "actual."
3534
3535         * Scripts/webkitpy/common/net/resultsjsonparser.py:
3536         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
3537
3538 2011-05-01  Adam Barth  <abarth@webkit.org>
3539
3540         Reviewed by Eric Seidel.
3541
3542         Move checkout/api.py to checkout/checkout.py
3543         https://bugs.webkit.org/show_bug.cgi?id=59906
3544
3545         This is more consistent with Python style.
3546
3547         * Scripts/webkitpy/common/checkout/__init__.py:
3548         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3549         * Scripts/webkitpy/common/host.py:
3550         * Scripts/webkitpy/tool/main.py:
3551
3552 2011-05-01  Eric Seidel  <eric@webkit.org>
3553
3554         Reviewed by Adam Barth.
3555
3556         scm.py should be split into many pieces
3557         https://bugs.webkit.org/show_bug.cgi?id=59908
3558
3559         Forgot an AuthenticationError import.
3560
3561         * Scripts/webkitpy/common/checkout/scm/git.py:
3562         * Scripts/webkitpy/common/checkout/scm/svn.py:
3563
3564 2011-05-01  Arno Renevier  <arno@renevier.net>
3565
3566         Reviewed by Eric Seidel.
3567
3568         wrong exception raised in Lighttpd start method
3569         https://bugs.webkit.org/show_bug.cgi?id=59283
3570
3571         raise standard Exception instead of non existent
3572         google.httpd_utils.HttpdNotStarted
3573
3574         * Scripts/webkitpy/layout_tests/port/http_server.py:
3575
3576 2011-05-01  Eric Seidel  <eric@webkit.org>
3577
3578         Reviewed by Adam Barth.
3579
3580         scm.py should be split into many pieces
3581         https://bugs.webkit.org/show_bug.cgi?id=59908
3582
3583         * Scripts/webkitpy/common/checkout/scm/__init__.py:
3584         * Scripts/webkitpy/common/checkout/scm/commitmessage.py: Added.
3585         * Scripts/webkitpy/common/checkout/scm/git.py: Added.
3586         * Scripts/webkitpy/common/checkout/scm/scm.py:
3587         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3588         * Scripts/webkitpy/common/checkout/scm/svn.py: Added.
3589
3590 2011-05-01  Eric Seidel  <eric@webkit.org>
3591
3592         Reviewed by Adam Barth.
3593
3594         Make most scm.py tests pass in preparation for splitting them up
3595         https://bugs.webkit.org/show_bug.cgi?id=59904
3596
3597         There is one remaining failure:
3598         webkitpy.common.checkout.scm.scm_unittest.GitTestWithMock.test_create_patch
3599         which identifies a difference between the SVN and Git versions of the
3600         SCM api.  I'm not going to bother fixing that until we split out all
3601         the tests.
3602
3603         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3604
3605 2011-05-01  Patrick Gansterer  <paroga@webkit.org>
3606
3607         [WIN] Unreviewed buildfix after r85440.
3608
3609         * DumpRenderTree/win/UIDelegate.cpp:
3610         (UIDelegate::UIDelegate): Removed accidental added adoptPtr.
3611
3612 2011-05-01  Patrick Gansterer  <paroga@webkit.org>
3613
3614         [WIN] Unreviewed buildfix after r85434.
3615
3616         * DumpRenderTree/win/FrameLoadDelegate.cpp: Added missing header.
3617         * DumpRenderTree/win/UIDelegate.cpp: Ditto.
3618
3619 2011-05-01  Patrick Gansterer  <paroga@webkit.org>
3620
3621         [WIN] Unreviewed buildfix after r85434.
3622
3623         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3624         (FrameLoadDelegate::FrameLoadDelegate):
3625         * DumpRenderTree/win/UIDelegate.cpp:
3626         (DRTUndoManager::DRTUndoManager):
3627         (UIDelegate::UIDelegate):
3628         (UIDelegate::resetUndoManager):
3629
3630 2011-05-01  Eric Seidel  <eric@webkit.org>
3631
3632         Reviewed by Adam Barth.
3633
3634         Move scm.py into its own module in preparation for splitting it up
3635         https://bugs.webkit.org/show_bug.cgi?id=59884
3636
3637         * Scripts/webkitpy/common/checkout/scm/__init__.py: Added.
3638         * Scripts/webkitpy/common/checkout/scm/scm.py: Moved.
3639         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Moved.
3640         * Scripts/webkitpy/test/main.py:
3641
3642 2011-05-01  Adam Barth  <abarth@webkit.org>
3643
3644         Reviewed by Eric Seidel.
3645
3646         webkit-patch fails when not run from root
3647         https://bugs.webkit.org/show_bug.cgi?id=59882
3648
3649         We need to set the CWD when running svn so that svn interprets file
3650         paths relative to&nb