Unreviewed, fix build failure
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-17  Tim Horton  <timothy_horton@apple.com>
2
3         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
4         https://bugs.webkit.org/show_bug.cgi?id=197028
5         <rdar://problem/49985290>
6
7         Reviewed by Wenson Hsieh.
8
9         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
10         (TEST):
11         Liberal application of waitForNextPresentationUpdate works around a race
12         where if the page rapidly changes its viewport arguments (or an API client
13         rapidly changes its viewport arguments), we'd get stuck thinking that the
14         user had intentionally zoomed the page, and stop resetting the initial scale.
15         This deserves a separate bug, but no need to keep the test failing while
16         we think about it.
17
18 2019-04-17  Tim Horton  <timothy_horton@apple.com>
19
20         REGRESSION (r241988): Switching tabs is slow
21         https://bugs.webkit.org/show_bug.cgi?id=197037
22         <rdar://problem/49951473>
23
24         Reviewed by Simon Fraser.
25
26         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
27         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
28         (TEST):
29         * TestWebKitAPI/cocoa/TestWKWebView.h:
30         * TestWebKitAPI/cocoa/TestWKWebView.mm:
31         (-[TestWKWebView addToTestWindow]):
32         Add a test that hangs without this fix.
33
34 2019-04-17  Truitt Savell  <tsavell@apple.com>
35
36         Unreviewed, rolling out r244400.
37
38         Caused testing to exit early with assertionon Debug WK2
39
40         Reverted changeset:
41
42         "UI↔Web deadlock when printing with a JavaScript alert
43         visible"
44         https://bugs.webkit.org/show_bug.cgi?id=196839
45         https://trac.webkit.org/changeset/244400
46
47 2019-04-17  Brady Eidson  <beidson@apple.com>
48
49         Link clicks in PDFs shouldn't send referrer headers.
50         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
51
52         Reviewed by Tim Horton.
53
54         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
55         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
56         (putPDFBytesCallback):
57         (emptyReleaseInfoCallback):
58         (createPDFWithLinkToURL):
59         (TEST):
60
61 2019-04-17  Tim Horton  <timothy_horton@apple.com>
62
63         UI↔Web deadlock when printing with a JavaScript alert visible
64         https://bugs.webkit.org/show_bug.cgi?id=196839
65         <rdar://problem/49157642>
66
67         Reviewed by Andy Estes.
68
69         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
70         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
71         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
72         (TEST):
73
74 2019-04-17  Alex Christensen  <achristensen@webkit.org>
75
76         WKRetainPtr's adoption constructor should be private
77         https://bugs.webkit.org/show_bug.cgi?id=197019
78
79         Reviewed by Tim Horton.
80
81         * DumpRenderTree/mac/DumpRenderTree.mm:
82         (dumpFramesAsText):
83         * TestWebKitAPI/InjectedBundleController.cpp:
84         (TestWebKitAPI::InjectedBundleController::initialize):
85         * TestWebKitAPI/PlatformUtilities.cpp:
86         (TestWebKitAPI::Util::createContextWithInjectedBundle):
87         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
88         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
89         (TestWebKitAPI::Util::toWK):
90         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
91         (TestWebKitAPI::TEST):
92         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
93         (TestWebKitAPI::TEST):
94         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
95         (TestWebKitAPI::TEST):
96         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
97         (TestWebKitAPI::TEST):
98         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
99         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
100         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
101         (TestWebKitAPI::TEST):
102         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
103         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
104         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
105         (TestWebKitAPI::TEST):
106         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
107         (TestWebKitAPI::TEST):
108         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
109         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
110         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
111         (TestWebKitAPI::TEST):
112         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
113         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
114         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
115         (TestWebKitAPI::TEST):
116         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
117         (TestWebKitAPI::TEST):
118         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
119         (TestWebKitAPI::TEST):
120         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
121         (TestWebKitAPI::TEST):
122         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
123         (TestWebKitAPI::TEST):
124         * TestWebKitAPI/Tests/WebKit/Find.cpp:
125         (TestWebKitAPI::TEST):
126         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
127         (TestWebKitAPI::TEST):
128         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
129         (TestWebKitAPI::TEST):
130         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
131         (TestWebKitAPI::TEST):
132         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
133         (TestWebKitAPI::TEST):
134         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
135         (TestWebKitAPI::TEST):
136         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
137         (TestWebKitAPI::TEST):
138         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
139         (TestWebKitAPI::TEST):
140         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
141         (TestWebKitAPI::TEST):
142         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
143         (TestWebKitAPI::TEST):
144         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
145         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
146         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
147         (TestWebKitAPI::TEST):
148         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
149         (TestWebKitAPI::TEST):
150         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
151         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
152         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
153         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
154         (TestWebKitAPI::TEST):
155         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
156         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
157         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
158         (TestWebKitAPI::TEST):
159         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
160         (TestWebKitAPI::TEST):
161         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
162         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
163         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
164         (TestWebKitAPI::TEST):
165         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
166         (TestWebKitAPI::loadAlternateHTMLString):
167         (TestWebKitAPI::TEST):
168         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
169         (TestWebKitAPI::TEST):
170         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
171         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
172         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
173         (TestWebKitAPI::buildAndPerformTest):
174         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
175         (TestWebKitAPI::TEST):
176         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
177         (TestWebKitAPI::TEST):
178         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
179         (TestWebKitAPI::TEST):
180         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
181         (TestWebKitAPI::TEST):
182         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
183         (TestWebKitAPI::TEST):
184         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
185         (TestWebKitAPI::TEST):
186         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
187         (TestWebKitAPI::TEST):
188         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
189         (TestWebKitAPI::TEST):
190         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
191         (TestWebKitAPI::TEST):
192         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
193         (TestWebKitAPI::TEST):
194         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
195         (TestWebKitAPI::TEST):
196         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
197         (TestWebKitAPI::TEST):
198         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
199         (TestWebKitAPI::TEST):
200         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
201         (TestWebKitAPI::TEST):
202         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
203         (TestWebKitAPI::TEST):
204         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
205         (TestWebKitAPI::TEST):
206         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
207         (TestWebKitAPI::TEST):
208         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
209         (TestWebKitAPI::TEST):
210         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
211         (TestWebKitAPI::TEST):
212         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
213         (TestWebKitAPI::TEST):
214         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
215         (TestWebKitAPI::TEST):
216         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
217         (TestWebKitAPI::TEST):
218         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
219         (TestWebKitAPI::TEST):
220         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
221         (TestWebKitAPI::TEST):
222         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
223         (TestWebKitAPI::TEST):
224         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
225         (TestWebKitAPI::TEST):
226         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
227         (TestWebKitAPI::TEST):
228         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
229         (TestWebKitAPI::TEST):
230         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
231         (TestWebKitAPI::TEST):
232         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
233         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
234         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
235         (TestWebKitAPI::TEST):
236         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
237         (TestWebKitAPI::TEST):
238         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
239         (TestWebKitAPI::TEST):
240         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
241         (TestWebKitAPI::TEST):
242         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
243         (TestWebKitAPI::TEST):
244         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
245         (TestWebKitAPI::TEST):
246         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
247         (TestWebKitAPI::TEST):
248         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
249         (TestWebKitAPI::TEST):
250         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
251         (TestWebKitAPI::TEST):
252         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
253         (TestWebKitAPI::TEST):
254         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
255         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
256         (TEST):
257         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
258         (TEST):
259         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
260         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
261         (TEST):
262         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
263         (TestWebKitAPI::TEST):
264         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
265         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
266         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
267         (WTR::getMenuItemTitleCallback):
268         (WTR::createMouseMessageBody):
269         (WTR::EventSendingController::mouseDown):
270         (WTR::EventSendingController::mouseUp):
271         (WTR::EventSendingController::mouseMoveTo):
272         (WTR::EventSendingController::mouseForceClick):
273         (WTR::EventSendingController::startAndCancelMouseForceClick):
274         (WTR::EventSendingController::mouseForceDown):
275         (WTR::EventSendingController::mouseForceUp):
276         (WTR::EventSendingController::mouseForceChanged):
277         (WTR::EventSendingController::leapForward):
278         (WTR::EventSendingController::scheduleAsynchronousClick):
279         (WTR::createKeyDownMessageBody):
280         (WTR::EventSendingController::keyDown):
281         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
282         (WTR::EventSendingController::mouseScrollBy):
283         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
284         (WTR::EventSendingController::continuousMouseScrollBy):
285         (WTR::EventSendingController::addTouchPoint):
286         (WTR::EventSendingController::updateTouchPoint):
287         (WTR::EventSendingController::setTouchModifier):
288         (WTR::EventSendingController::setTouchPointRadius):
289         (WTR::EventSendingController::touchStart):
290         (WTR::EventSendingController::touchMove):
291         (WTR::EventSendingController::touchEnd):
292         (WTR::EventSendingController::touchCancel):
293         (WTR::EventSendingController::clearTouchPoints):
294         (WTR::EventSendingController::releaseTouchPoint):
295         (WTR::EventSendingController::cancelTouchPoint):
296         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
297         (WTR::InjectedBundle::didCreatePage):
298         (WTR::InjectedBundle::didReceiveMessage):
299         (WTR::InjectedBundle::didReceiveMessageToPage):
300         (WTR::InjectedBundle::booleanForKey):
301         (WTR::InjectedBundle::done):
302         (WTR::InjectedBundle::dumpToStdErr):
303         (WTR::InjectedBundle::outputText):
304         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
305         (WTR::InjectedBundle::postAddChromeInputField):
306         (WTR::InjectedBundle::postRemoveChromeInputField):
307         (WTR::InjectedBundle::postFocusWebView):
308         (WTR::InjectedBundle::postSetBackingScaleFactor):
309         (WTR::InjectedBundle::postSetWindowIsKey):
310         (WTR::InjectedBundle::postSetViewSize):
311         (WTR::InjectedBundle::postSimulateWebNotificationClick):
312         (WTR::InjectedBundle::postSetAddsVisitedLinks):
313         (WTR::InjectedBundle::setGeolocationPermission):
314         (WTR::InjectedBundle::setMockGeolocationPosition):
315         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
316         (WTR::InjectedBundle::isGeolocationProviderActive const):
317         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
318         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
319         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
320         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
321         (WTR::InjectedBundle::setCustomPolicyDelegate):
322         (WTR::InjectedBundle::setHidden):
323         (WTR::InjectedBundle::setCacheModel):
324         (WTR::InjectedBundle::shouldProcessWorkQueue const):
325         (WTR::InjectedBundle::processWorkQueue):
326         (WTR::InjectedBundle::queueBackNavigation):
327         (WTR::InjectedBundle::queueForwardNavigation):
328         (WTR::InjectedBundle::queueLoad):
329         (WTR::InjectedBundle::queueLoadHTMLString):
330         (WTR::InjectedBundle::queueReload):
331         (WTR::InjectedBundle::queueLoadingScript):
332         (WTR::InjectedBundle::queueNonLoadingScript):
333         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
334         (WTR::frameToStr):
335         (WTR::InjectedBundlePage::InjectedBundlePage):
336         (WTR::dumpFrameDescriptionSuitableForTestResult):
337         (WTR::dumpFrameScrollPosition):
338         (WTR::dumpDescendantFrameScrollPositions):
339         (WTR::dumpFrameText):
340         (WTR::dumpDescendantFramesText):
341         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
342         (WTR::TestRunner::shouldDumpPixels const):
343         (WTR::TestRunner::setDumpPixels):
344         (WTR::TestRunner::whatToDump const):
345         (WTR::TestRunner::setWhatToDump):
346         (WTR::TestRunner::setWaitUntilDone):
347         (WTR::TestRunner::shouldWaitUntilDone const):
348         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
349         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
350         (WTR::TestRunner::clearAllDatabases):
351         (WTR::TestRunner::setIDBPerOriginQuota):
352         (WTR::TestRunner::originsWithApplicationCache):
353         (WTR::TestRunner::setCanOpenWindows):
354         (WTR::TestRunner::setXSSAuditorEnabled):
355         (WTR::TestRunner::setMediaDevicesEnabled):
356         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
357         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
358         (WTR::TestRunner::setCustomUserAgent):
359         (WTR::TestRunner::setWebAPIStatisticsEnabled):
360         (WTR::TestRunner::setModernMediaControlsEnabled):
361         (WTR::TestRunner::setWebGL2Enabled):
362         (WTR::TestRunner::setWritableStreamAPIEnabled):
363         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
364         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
365         (WTR::TestRunner::setAllowsAnySSLCertificate):
366         (WTR::TestRunner::setPluginsEnabled):
367         (WTR::TestRunner::setValueForUser):
368         (WTR::TestRunner::setAudioResult):
369         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
370         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
371         (WTR::TestRunner::setAlwaysAcceptCookies):
372         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
373         (WTR::TestRunner::isDoingMediaCapture const):
374         (WTR::TestRunner::queueLoad):
375         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
376         (WTR::TestRunner::setHandlesAuthenticationChallenges):
377         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
378         (WTR::TestRunner::setShouldLogDownloadCallbacks):
379         (WTR::TestRunner::setAuthenticationUsername):
380         (WTR::TestRunner::setAuthenticationPassword):
381         (WTR::TestRunner::secureEventInputIsEnabled const):
382         (WTR::TestRunner::setBlockAllPlugins):
383         (WTR::TestRunner::setPluginSupportedMode):
384         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
385         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
386         (WTR::TestRunner::setNavigationGesturesEnabled):
387         (WTR::TestRunner::setIgnoresViewportScaleLimits):
388         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
389         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
390         (WTR::TestRunner::terminateNetworkProcess):
391         (WTR::TestRunner::terminateServiceWorkerProcess):
392         (WTR::TestRunner::runUIScript):
393         (WTR::TestRunner::setStatisticsDebugMode):
394         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
395         (WTR::TestRunner::setStatisticsLastSeen):
396         (WTR::TestRunner::setStatisticsPrevalentResource):
397         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
398         (WTR::TestRunner::dumpResourceLoadStatistics):
399         (WTR::TestRunner::isStatisticsPrevalentResource):
400         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
401         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
402         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
403         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
404         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
405         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
406         (WTR::TestRunner::setStatisticsGrandfathered):
407         (WTR::TestRunner::isStatisticsGrandfathered):
408         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
409         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
410         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
411         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
412         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
413         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
414         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
415         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
416         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
417         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
418         (WTR::TestRunner::statisticsUpdateCookieBlocking):
419         (WTR::TestRunner::statisticsSubmitTelemetry):
420         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
421         (WTR::TestRunner::setStatisticsIsRunningTest):
422         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
423         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
424         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
425         (WTR::TestRunner::setStatisticsGrandfatheringTime):
426         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
427         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
428         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
429         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
430         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
431         (WTR::TestRunner::statisticsDeleteCookiesForHost):
432         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
433         (WTR::TestRunner::statisticsResetToConsistentState):
434         (WTR::TestRunner::setStorageAccessAPIEnabled):
435         (WTR::TestRunner::getAllStorageAccessEntries):
436         (WTR::TestRunner::addMockMediaDevice):
437         (WTR::TestRunner::clearMockMediaDevices):
438         (WTR::TestRunner::removeMockMediaDevice):
439         (WTR::TestRunner::resetMockMediaDevices):
440         (WTR::TestRunner::connectMockGamepad):
441         (WTR::TestRunner::disconnectMockGamepad):
442         (WTR::TestRunner::setMockGamepadDetails):
443         (WTR::TestRunner::setMockGamepadAxisValue):
444         (WTR::TestRunner::setMockGamepadButtonValue):
445         (WTR::TestRunner::removeAllSessionCredentials):
446         (WTR::TestRunner::clearDOMCache):
447         (WTR::TestRunner::clearDOMCaches):
448         (WTR::TestRunner::hasDOMCache):
449         (WTR::TestRunner::domCacheSize):
450         (WTR::TestRunner::setAllowStorageQuotaIncrease):
451         (WTR::TestRunner::getApplicationManifestThen):
452         (WTR::TestRunner::injectUserScript):
453         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
454         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
455         (WTR::TestRunner::addTestKeyToKeychain):
456         (WTR::TestRunner::cleanUpKeychain):
457         (WTR::TestRunner::keyExistsInKeychain):
458         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
459         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
460         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
461         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
462         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
463         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
464         * WebKitTestRunner/TestController.cpp:
465         (WTR::TestController::initialize):
466         (WTR::parseStringTestHeaderValueAsRelativePath):
467         (WTR::updateTestOptionsFromTestHeader):
468         (WTR::TestController::runTest):
469         (WTR::TestController::didReceiveLiveDocumentsList):
470         (WTR::TestController::didReceiveMessageFromInjectedBundle):
471         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
472         (WTR::TestController::didFinishNavigation):
473         (WTR::TestController::didReceiveAuthenticationChallenge):
474         * WebKitTestRunner/TestInvocation.cpp:
475         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
476         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
477         (WTR::TestInvocation::uiScriptDidComplete):
478         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
479         * WebKitTestRunner/WebNotificationProvider.cpp:
480         (WTR::WebNotificationProvider::closeWebNotification):
481         * WebKitTestRunner/WorkQueueManager.cpp:
482         (WTR::ScriptItem::ScriptItem):
483         (WTR::WorkQueueManager::queueLoad):
484         (WTR::WorkQueueManager::queueLoadHTMLString):
485
486 2019-04-17  Alex Christensen  <achristensen@webkit.org>
487
488         Add a comment to make my test from r244139 less mysterious.
489         https://bugs.webkit.org/show_bug.cgi?id=196744
490
491         As suggested by Darin Adler.
492
493         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
494         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
495
496 2019-04-17  Chris Dumez  <cdumez@apple.com>
497
498         Remember device orientation permission for the duration of the browsing session
499         https://bugs.webkit.org/show_bug.cgi?id=196992
500         <rdar://problem/49946067>
501
502         Reviewed by Alex Christensen.
503
504         Add API test coverage.
505
506         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
507         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
508         (TEST):
509
510 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
511
512         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
513         https://bugs.webkit.org/show_bug.cgi?id=196675
514
515         Reviewed by Lucas Forschler.
516
517         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
518         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
519
520 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
521
522         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
523         https://bugs.webkit.org/show_bug.cgi?id=196919
524         <rdar://problem/41630459>
525
526         Reviewed by Tim Horton.
527
528         Add iOS support for several new testing hooks. See below for more detail.
529
530         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
531         (WTR::UIScriptController::isDismissingMenu const):
532
533         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
534         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
535         by UIKit when dismissing the callout bar (i.e. UIMenuController).
536
537         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
538         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
539         (WTR::UIScriptController::isDismissingMenu const):
540         * TestRunnerShared/UIScriptContext/UIScriptController.h:
541         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
542         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
543         (WTR::InjectedBundle::didReceiveMessageToPage):
544         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
545         (WTR::TestRunner::setAllowedMenuActions):
546
547         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
548         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
549         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
550         against the name of the custom action.
551
552         (WTR::TestRunner::installCustomMenuAction):
553
554         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
555         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
556         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
557         triggered.
558
559         (WTR::TestRunner::performCustomMenuAction):
560
561         Invoked when the custom menu action is triggered.
562
563         * WebKitTestRunner/InjectedBundle/TestRunner.h:
564         * WebKitTestRunner/TestController.cpp:
565         (WTR::TestController::installCustomMenuAction):
566         (WTR::TestController::setAllowedMenuActions):
567         * WebKitTestRunner/TestController.h:
568         * WebKitTestRunner/TestInvocation.cpp:
569         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
570         (WTR::TestInvocation::performCustomMenuAction):
571
572         Add plumbing to call back into the injected bundle when performing the custom action.
573
574         * WebKitTestRunner/TestInvocation.h:
575         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
576         (WTR::TestController::installCustomMenuAction):
577         (WTR::TestController::setAllowedMenuActions):
578         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
579         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
580         (-[TestRunnerWKWebView initWithFrame:configuration:]):
581         (-[TestRunnerWKWebView becomeFirstResponder]):
582         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
583
584         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
585         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
586         in the Mail app on iOS.
587
588         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
589         (-[TestRunnerWKWebView setAllowedMenuActions:]):
590         (-[TestRunnerWKWebView resetCustomMenuAction]):
591         (-[TestRunnerWKWebView performCustomAction:]):
592         (-[TestRunnerWKWebView canPerformAction:withSender:]):
593         (-[TestRunnerWKWebView _willHideMenu]):
594         (-[TestRunnerWKWebView _didHideMenu]):
595         * WebKitTestRunner/ios/TestControllerIOS.mm:
596         (WTR::TestController::platformResetStateToConsistentValues):
597
598         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
599         if specified.
600
601         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
602         (WTR::UIScriptController::isDismissingMenu const):
603
604 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
605
606         Allow sharing from imageSheet on an image document
607         https://bugs.webkit.org/show_bug.cgi?id=196891
608         <rdar://problem/25377386>
609
610         Reviewed by Tim Horton.
611
612         Test to make sure that the correct imageURL is extracted from an image element.
613
614         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
615         (TestWebKitAPI::TEST):
616
617 2019-04-16  Alex Christensen  <achristensen@webkit.org>
618
619         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
620         https://bugs.webkit.org/show_bug.cgi?id=196995
621
622         Reviewed by Brady Eidson.
623
624         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
625         (TEST):
626
627 2019-04-16  Chris Dumez  <cdumez@apple.com>
628
629         URL set by document.open() is not communicated to the UIProcess
630         https://bugs.webkit.org/show_bug.cgi?id=196941
631         <rdar://problem/49237544>
632
633         Reviewed by Geoff Garen.
634
635         Add API test coverage.
636
637         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
638         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
639         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
640         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
641         (TEST):
642
643 2019-04-16  Commit Queue  <commit-queue@webkit.org>
644
645         Unreviewed, rolling out r244321.
646         https://bugs.webkit.org/show_bug.cgi?id=196968
647
648         Causing all WK2 Debug builds to exit early after Assertion
649         failures. (Requested by ShawnRoberts on #webkit).
650
651         Reverted changeset:
652
653         "URL set by document.open() is not communicated to the
654         UIProcess"
655         https://bugs.webkit.org/show_bug.cgi?id=196941
656         https://trac.webkit.org/changeset/244321
657
658 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
659
660         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
661         https://bugs.webkit.org/show_bug.cgi?id=196948
662
663         Reviewed by Zalan Bujtas.
664
665         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
666         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
667
668 2019-04-15  Chris Dumez  <cdumez@apple.com>
669
670         URL set by document.open() is not communicated to the UIProcess
671         https://bugs.webkit.org/show_bug.cgi?id=196941
672         <rdar://problem/49237544>
673
674         Reviewed by Geoffrey Garen.
675
676         Add API test coverage.
677
678         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
679         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
680         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
681         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
682         (TEST):
683
684 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
685
686         Using Tools/Scripts/clean-webkit should not install requests
687         https://bugs.webkit.org/show_bug.cgi?id=196940
688
689         Reviewed by Lucas Forschler.
690
691         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
692         existing, depending on the path autoinstalled is run through.
693         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
694         needed.
695         (Port.configuration_for_upload):
696         (Port.commits_for_upload):
697
698 2019-04-15  Alex Christensen  <achristensen@webkit.org>
699
700         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
701         https://bugs.webkit.org/show_bug.cgi?id=196773
702
703         Reviewed by Jer Noble.
704
705         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
706         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
707         (TEST):
708
709 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
710
711         ews-build should clearly indicate flaky test failures
712         https://bugs.webkit.org/show_bug.cgi?id=196947
713
714         Reviewed by Lucas Forschler.
715
716         * BuildSlaveSupport/ews-build/steps.py:
717         (AnalyzeAPITestsResults.analyzeResults):
718
719 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
720
721         InjectedBundle parameters often need initialization function called before unarchiving
722         https://bugs.webkit.org/show_bug.cgi?id=189709
723         <rdar://problem/44573653>
724
725         Reviewed by Ryosuke Niwa.
726
727         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
728         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
729
730 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
731
732         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
733         https://bugs.webkit.org/show_bug.cgi?id=196681
734
735         Reviewed by Darin Adler.
736
737         Added tests.
738
739         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
740         (WTF_HashSet.RemoveIf):
741         (WTF_HashSet.RemoveIfShrinkToBestSize):
742
743 2019-04-15  John Wilander  <wilander@apple.com>
744
745         Send delayed Ad Click Attribution conversion requests to the click source
746         https://bugs.webkit.org/show_bug.cgi?id=196838
747         <rdar://problem/47650157>
748
749         Reviewed by Chris Dumez and Youenn Fablet.
750
751         This patch adds test infrastructure to override the default behavior in
752         WebKit::NetworkAdClickAttribution.
753
754         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
755         (TestWebKitAPI::TEST):
756         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
757         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
758         (WTR::TestRunner::dumpAdClickAttribution):
759         (WTR::TestRunner::clearAdClickAttribution):
760         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
761         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
762         * WebKitTestRunner/InjectedBundle/TestRunner.h:
763         * WebKitTestRunner/TestController.cpp:
764         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
765         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
766         * WebKitTestRunner/TestController.h:
767         * WebKitTestRunner/TestInvocation.cpp:
768         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
769
770 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
771
772         [ews-app] status-bubble should display position in queue
773         https://bugs.webkit.org/show_bug.cgi?id=196607
774
775         Reviewed by Lucas Forschler.
776
777         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
778         (StatusBubble._build_bubble):
779         (StatusBubble._queue_position): Method to calculate patch's position in queue.
780
781 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
782
783         [ews-build] Do not run clean build by default on EWS builders
784         https://bugs.webkit.org/show_bug.cgi?id=196897
785
786         Reviewed by Lucas Forschler.
787
788         * BuildSlaveSupport/ews-build/steps.py:
789         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
790         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
791         untracked directories like WebKitBuild).
792         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
793         untracked files/directories (like WebKitBuild).
794
795 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
796
797         TestRunner::notifyDone() should be safely reentrant
798         https://bugs.webkit.org/show_bug.cgi?id=196898
799
800         Reviewed by Darin Adler.
801
802         It is currently possible that TestRunner::notifyDone() will call itself, since
803         notifyDone() will force a repaint, which can start executing JavaScript, which
804         may call notifyDone() again. This can lead to test failures and flakiness.
805         Fix this by setting the m_waitToDump flag before calling the dump() method.
806
807         * DumpRenderTree/mac/TestRunnerMac.mm:
808         (TestRunner::notifyDone):
809         (TestRunner::forceImmediateCompletion):
810         * DumpRenderTree/win/TestRunnerWin.cpp:
811         (TestRunner::notifyDone):
812         (TestRunner::forceImmediateCompletion):
813
814 2019-04-15  Philippe Normand  <pnormand@igalia.com>
815
816         [GTK][WPE] Add enable-media websetting
817         https://bugs.webkit.org/show_bug.cgi?id=196863
818
819         Reviewed by Michael Catanzaro.
820
821         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
822         (testWebKitSettings): Add test for the enable-media web-setting.
823
824 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
825
826         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
827         https://bugs.webkit.org/show_bug.cgi?id=196905
828         <rdar://problem/49886096>
829
830         Reviewed by Tim Horton.
831
832         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
833         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
834         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
835         delay timer, we end up with this sequence of events in the problematic (failure) case:
836
837         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
838             ...IPC from UI to web process...
839         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
840             ...IPC from web to UI process...
841         (c) [UI]    Invoke completion handler for script #1
842         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
843             ...IPC from UI to web process...
844         (e) [Web]   Evaluate script #2 in the web process
845         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
846
847         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
848         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
849         #2 is run in step (e).
850
851         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
852         the UI process by waiting on a script message posted by the web process, after attachment updates are
853         dispatched.
854
855         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
856         (TestWebKitAPI::TEST):
857
858 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
859
860         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
861         https://bugs.webkit.org/show_bug.cgi?id=196909
862
863         Reviewed by Wenson Hsieh.
864
865         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
866         (TestWebKitAPI::TEST):
867
868 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
869
870         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
871         https://bugs.webkit.org/show_bug.cgi?id=196880
872
873         Reviewed by Yusuke Suzuki.
874
875         Add a new function for bytecode cache tests that does not forceDiskCache
876         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
877         test added in this patch, since the code is invalid and therefore won't be
878         cached. It should also be useful for tests that evaluate dynamically
879         generated code.
880
881         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
882         * Scripts/run-jsc-stress-tests:
883
884 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
885
886         Update AudioSession route sharing policy
887         https://bugs.webkit.org/show_bug.cgi?id=196776
888         <rdar://problem/46501611>
889
890         Reviewed by Jer Noble.
891
892         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
893         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
894         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
895         (TestWebKitAPI::TEST):
896
897 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
898
899         [iOS] Software keyboard is shown too frequently on some websites
900         https://bugs.webkit.org/show_bug.cgi?id=195856
901         <rdar://problem/49191395>
902
903         Reviewed by Darin Adler.
904
905         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
906
907         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
908         (WTR::UIScriptController::setHardwareKeyboardAttached):
909         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
910         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
911         (WTR::UIScriptController::setHardwareKeyboardAttached):
912         * TestRunnerShared/UIScriptContext/UIScriptController.h:
913         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
914
915         Additionally link against GraphicsServices in WebKitTestRunner.
916
917         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
918         (WTR::TestController::platformResetStateToConsistentValues):
919         (WTR::UIScriptController::setHardwareKeyboardAttached):
920
921 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
922
923         [GTK][WPE] Fix pacman install-dependencies packages
924         https://bugs.webkit.org/show_bug.cgi?id=196817
925
926         Reviewed by Žan Doberšek.
927         
928         python3-setuptools is called python-setuptools
929         ruby-highline is only available on AUR
930         libv4l-devel is incorporated in v4l-utils
931
932         * gtk/install-dependencies:
933         * wpe/install-dependencies:
934
935 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
936
937         [GTK] REGRESSION(r243860): Many tests failing
938         https://bugs.webkit.org/show_bug.cgi?id=196791
939
940         Reviewed by Joanmarie Diggs.
941
942         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
943         multiple documents and check that accessibility hierarchy is updated after a navigation.
944
945         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
946         (loadChangedCallback):
947         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
948         (AccessibilityTest::AccessibilityTest):
949         (AccessibilityTest::~AccessibilityTest):
950         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
951         (AccessibilityTest::findTestServerApplication):
952         (AccessibilityTest::findDocumentWeb):
953         (AccessibilityTest::findRootObject):
954         (AccessibilityTest::waitUntilChildrenRemoved):
955         (AccessibilityTest::ensureProxy):
956         (testAtspiBasicHierarchy):
957         (beforeAll):
958         (afterAll):
959
960 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
961
962         [ews-build] Handle bug titles with unicode characters
963         https://bugs.webkit.org/show_bug.cgi?id=196802
964
965         Reviewed by Dewei Zhu.
966
967         * BuildSlaveSupport/ews-build/steps.py:
968         (ValidatePatch._is_bug_closed):
969
970 2019-04-11  Michael Saboff  <msaboff@apple.com>
971
972         Improve the Inline Cache Stats code
973         https://bugs.webkit.org/show_bug.cgi?id=196836
974
975         Reviewed by Saam Barati.
976
977         Added a new script to consolidate and arrange the output of --useICStats option.
978
979         This script merges the output from every group into one large table and sorts it from most common to
980         least common.  It also counts the slow path GetById and PutById variants and then calculates the
981         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
982         Put together, this is useful to see what property accesses are not getting cached.
983
984         * Scripts/ic-stats.py: Added.
985         (ICStats):
986         (ICStats.__init__):
987         (ICStats.parse):
988         (ICStats.dumpStats):
989         (usage):
990
991 2019-04-10  Alex Christensen  <achristensen@webkit.org>
992
993         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
994         https://bugs.webkit.org/show_bug.cgi?id=196809
995         <rdar://49800762>
996
997         Reviewed by Brady Eidson.
998
999         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1000         (TEST):
1001
1002 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
1003
1004         requestAnimationFrame should execute before the next frame
1005         https://bugs.webkit.org/show_bug.cgi?id=177484
1006
1007         Reviewed by Simon Fraser.
1008
1009         Add trace points for the page RenderingUpdate.
1010
1011         * Tracing/SystemTracePoints.plist:
1012
1013 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
1014
1015         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
1016         https://bugs.webkit.org/show_bug.cgi?id=196760
1017
1018         Reviewed by Don Olmstead.
1019
1020         vswhere.exe has been bundled since Visual Studio 2017 version
1021         15.2. We shouldn't download vswhere.exe.
1022
1023         * Scripts/build-jsc: Do not call update-vswhere.py.
1024         * Scripts/build-webkit: Ditto.
1025         * Scripts/update-vswhere.py: Removed.
1026         * Scripts/webkitdirs.pm:
1027         (requireModulesForVSWhere): Deleted.
1028         (pickCurrentVisualStudioInstallation): Deleted.
1029         (visualStudioInstallDirVSWhere): Return the latest installed VS
1030         installation path by using the bundled vswhere.exe.
1031         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
1032         (visualStudioInstallDirFallback): Removed.
1033
1034 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
1035
1036         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
1037         https://bugs.webkit.org/show_bug.cgi?id=196780
1038
1039         Reviewed by Alexey Proskuryakov.
1040
1041         * BuildSlaveSupport/ews-build/steps.py:
1042         * BuildSlaveSupport/ews-build/steps_unittest.py:
1043
1044 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1045
1046         Add SPI WKNavigationResponse._downloadAttribute
1047         https://bugs.webkit.org/show_bug.cgi?id=196755
1048         <rdar://49587365>
1049
1050         Reviewed by Brady Eidson.
1051
1052         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1053         (-[NavigationResponseTestDelegate navigationResponse]):
1054         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
1055         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
1056         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1057         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
1058         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1059         (readRequest):
1060         (writeResponse):
1061         (TEST):
1062
1063 2019-04-10  Tim Horton  <timothy_horton@apple.com>
1064
1065         Add modern API for overriding the page's specified viewport configuration
1066         https://bugs.webkit.org/show_bug.cgi?id=167734
1067         <rdar://problem/30331795>
1068
1069         Reviewed by Simon Fraser.
1070
1071         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1072         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
1073
1074 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
1075
1076         Add support for incremental bytecode cache updates
1077         https://bugs.webkit.org/show_bug.cgi?id=195000
1078
1079         Reviewed by Filip Pizlo.
1080
1081         Exit when the initial run to generate bytecode fails.
1082
1083         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
1084
1085 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1086
1087         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
1088         https://bugs.webkit.org/show_bug.cgi?id=196744
1089         <rdar://49415309>
1090
1091         Reviewed by Chris Dumez.
1092
1093         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
1094         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1095
1096 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
1097
1098         Add a way to opt into modern compatibility mode in layout tests
1099         https://bugs.webkit.org/show_bug.cgi?id=196770
1100         <rdar://problem/49777550>
1101
1102         Reviewed by Antoine Quint.
1103
1104         Add a new test option to enable modern compatibility mode in layout tests.
1105
1106         * WebKitTestRunner/TestController.cpp:
1107         (WTR::updateTestOptionsFromTestHeader):
1108         * WebKitTestRunner/TestController.h:
1109         * WebKitTestRunner/TestOptions.h:
1110         (WTR::TestOptions::hasSameInitializationOptions const):
1111         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1112         (WTR::TestController::platformCreateWebView):
1113         (WTR::TestController::enableModernCompatibilityMode):
1114
1115 2019-04-10  Andy Estes  <aestes@apple.com>
1116
1117         Try to fix the 32-bit watchOS build.
1118
1119         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1120         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
1121
1122 2019-04-10  Antoine Quint  <graouts@apple.com>
1123
1124         Enable Pointer Events on watchOS
1125         https://bugs.webkit.org/show_bug.cgi?id=196771
1126         <rdar://problem/49040909>
1127
1128         Reviewed by Dean Jackson.
1129
1130         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1131
1132 2019-04-10  Philippe Normand  <pnormand@igalia.com>
1133
1134         Unreviewed. Fix WPE accessibility tests after r244059.
1135
1136         We are failing to load the injected bundle due to undefined symbol
1137         AccessibilityUIElement::replaceTextInRange().
1138
1139         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
1140         (WTR::AccessibilityUIElement::replaceTextInRange):
1141
1142 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
1143
1144         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
1145         https://bugs.webkit.org/show_bug.cgi?id=196727
1146
1147         Reviewed by Fujii Hironori.
1148
1149         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1150         (WebKitBrowserWindow::create):
1151
1152 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
1153
1154         [ews-build] Add unit tests for PrintConfiguration
1155         https://bugs.webkit.org/show_bug.cgi?id=196752
1156
1157         Reviewed by Dewei Zhu.
1158
1159         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1160
1161 2019-04-09  Keith Rollin  <krollin@apple.com>
1162
1163         Unreviewed build maintenance -- update .xcfilelists.
1164
1165         * DumpRenderTree/DerivedSources-input.xcfilelist:
1166         * DumpRenderTree/DerivedSources-output.xcfilelist:
1167
1168 2019-04-09  Zalan Bujtas  <zalan@apple.com>
1169
1170         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
1171         https://bugs.webkit.org/show_bug.cgi?id=196743
1172         <rdar://problem/43897551>
1173
1174         Reviewed by Tim Horton.
1175
1176         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
1177         (TEST):
1178
1179 2019-04-09  Youenn Fablet  <youenn@apple.com>
1180
1181         Close service worker database on network process suspension
1182         https://bugs.webkit.org/show_bug.cgi?id=196623
1183         <rdar://problem/48930869>
1184
1185         Reviewed by Alex Christensen.
1186
1187         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1188
1189 2019-04-09  Daniel Bates  <dabates@apple.com>
1190
1191         [iPad] Should open popover when the spacebar is pressed
1192         https://bugs.webkit.org/show_bug.cgi?id=196360
1193         <rdar://problem/49389129>
1194
1195         Reviewed by Brent Fulgham.
1196
1197         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
1198
1199         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1200         (WTR::UIScriptController::isShowingPopover const): Added.
1201         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1202         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1203         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1204         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1205         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1206         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
1207         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
1208         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
1209         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
1210         (WTR::UIScriptController::isShowingPopover const): Added.
1211         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1212         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1213         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1214         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1215         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1216         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
1217         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
1218         (-[TestRunnerWKWebView _willPresentPopover]): Added.
1219         (-[TestRunnerWKWebView _didDismissPopover]): Added.
1220         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1221         (WTR::UIScriptController::isShowingPopover const): Added.
1222         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1223         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1224
1225 2019-04-09  Alex Christensen  <achristensen@webkit.org>
1226
1227         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
1228         https://bugs.webkit.org/show_bug.cgi?id=196665
1229         <rdar://45115669>
1230
1231         Reviewed by Geoff Garen.
1232
1233         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1234         (goBack):
1235         (+[SimpleLookupContext sharedLookupContext]):
1236         (-[SimpleLookupContext lookUpURL:completionHandler:]):
1237         (TEST):
1238         (+[Simple3LookupContext sharedLookupContext]): Deleted.
1239         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
1240
1241 2019-04-09  John Wilander  <wilander@apple.com>
1242
1243         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
1244         https://bugs.webkit.org/show_bug.cgi?id=196558
1245         <rdar://problem/47650245>
1246
1247         Reviewed by Youenn Fablet.
1248
1249         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1250         (TestWebKitAPI::TEST):
1251             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
1252
1253 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
1254
1255         [CMake] Apple builds should use ICU_INCLUDE_DIRS
1256         https://bugs.webkit.org/show_bug.cgi?id=196720
1257
1258         Reviewed by Konstantin Tokarev.
1259
1260         * TestWebKitAPI/PlatformMac.cmake:
1261
1262 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
1263
1264         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
1265         https://bugs.webkit.org/show_bug.cgi?id=196694
1266         <rdar://problem/48388734>
1267
1268         Rubber-stamped by Aakash Jain.
1269
1270         * Scripts/webkitpy/port/image_diff.py:
1271         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
1272         * Scripts/webkitpy/port/server_process.py:
1273         (ServerProcess.has_available_stdout): Check if stdout has data in it.
1274         (ServerProcess._wait_for_data_and_update_buffers_using_select):
1275         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
1276         * Scripts/webkitpy/port/server_process_mock.py:
1277         (MockServerProcess.has_available_stdout):
1278         * Scripts/webkitpy/port/server_process_unittest.py:
1279         (TestServerProcess.serial_test_basic):
1280
1281 2019-04-09  Jer Noble  <jer.noble@apple.com>
1282
1283         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1284         https://bugs.webkit.org/show_bug.cgi?id=196097
1285
1286         Reviewed by Eric Carlson.
1287
1288         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1289
1290         * DumpRenderTree/mac/DumpRenderTree.mm:
1291         (resetWebPreferencesToConsistentValues):
1292         * WebKitTestRunner/TestController.cpp:
1293         (WTR::TestController::resetPreferencesToConsistentValues):
1294
1295 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
1296
1297         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
1298         https://bugs.webkit.org/show_bug.cgi?id=196690
1299
1300         Reviewed by Michael Catanzaro.
1301
1302         * QueueStatusServer/config/queues.py:
1303         * Scripts/webkitpy/common/config/ews.json:
1304         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1305         (test_ews_name):
1306
1307 2019-04-09  Chris Dumez  <cdumez@apple.com>
1308
1309         Loads using loadHTMLString() cause flashing when process-swapping
1310         https://bugs.webkit.org/show_bug.cgi?id=196714
1311         <rdar://problem/49637354>
1312
1313         Reviewed by Antti Koivisto.
1314
1315         Add API test coverage.
1316
1317         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1318
1319 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1320
1321         Unreviewed. Fix ATK accessibility tests after r244059.
1322
1323         We are failing to load the injected bundle due to undefined symbol
1324         AccessibilityUIElement::replaceTextInRange().
1325
1326         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1327         (WTR::AccessibilityUIElement::replaceTextInRange):
1328
1329 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
1330
1331         AX: Support API: accessibilityReplaceRange:withText
1332         https://bugs.webkit.org/show_bug.cgi?id=196636
1333
1334         Unreviewed build fix for Windows port.
1335
1336         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
1337         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
1338
1339 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
1340
1341         [CMake][WinCairo] Separate copied headers into different directories
1342         https://bugs.webkit.org/show_bug.cgi?id=196655
1343
1344         Reviewed by Michael Catanzaro.
1345
1346         * DumpRenderTree/CMakeLists.txt:
1347         * MiniBrowser/win/CMakeLists.txt:
1348         * TestWebKitAPI/CMakeLists.txt:
1349         * TestWebKitAPI/PlatformWin.cmake:
1350
1351 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
1352
1353         Log stack-trace for run-webkit-tests when interrupted
1354         https://bugs.webkit.org/show_bug.cgi?id=176393
1355         <rdar://problem/34262310>
1356
1357         Reviewed by Lucas Forschler.
1358
1359         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
1360         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
1361         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
1362         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
1363         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
1364         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1365         (main): Set handlers to log stack trace on interruption.
1366
1367 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
1368
1369         AX: Support API: accessibilityReplaceRange:withText
1370         https://bugs.webkit.org/show_bug.cgi?id=196636
1371
1372         Unreviewed build fix for Windows port.
1373
1374         * DumpRenderTree/AccessibilityUIElement.cpp:
1375         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
1376
1377 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
1378
1379         [ews-build] Scripts using Buildbot API have CORS error
1380         https://bugs.webkit.org/show_bug.cgi?id=196709
1381
1382         Reviewed by Alexey Proskuryakov.
1383
1384         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
1385
1386 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
1387
1388         AX: Support API: accessibilityReplaceRange:withText
1389         https://bugs.webkit.org/show_bug.cgi?id=196636
1390
1391         Reviewed by Daniel Bates.
1392
1393         * DumpRenderTree/AccessibilityUIElement.cpp:
1394         (replaceTextInRangeCallback):
1395         (AccessibilityUIElement::replaceTextInRange):
1396         (AccessibilityUIElement::getJSClass):
1397         * DumpRenderTree/AccessibilityUIElement.h:
1398         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1399         (AccessibilityUIElement::replaceTextInRange):
1400         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1401         (AccessibilityUIElement::replaceTextInRange):
1402         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1403         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1404         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1405         (WTR::AccessibilityUIElement::replaceTextInRange):
1406         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1407         (WTR::AccessibilityUIElement::replaceTextInRange):
1408
1409 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1410
1411         [iOS] Do not allow starting selection drags when selection views are not visible
1412         https://bugs.webkit.org/show_bug.cgi?id=196686
1413         <rdar://problem/49399192>
1414
1415         Reviewed by Tim Horton.
1416
1417         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
1418         also add some new API tests to cover scenarios where the web view is not first responder.
1419
1420         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1421         (TestWebKitAPI::TEST):
1422         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1423
1424         Add a switch to optionally make the web view first responder when starting the simulated drag.
1425
1426         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1427         (-[DragAndDropSimulator initWithWebView:]):
1428         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
1429
1430 2019-04-08  Justin Fan  <justin_fan@apple.com>
1431
1432         [Web GPU] Fix Web GPU experimental feature on iOS
1433         https://bugs.webkit.org/show_bug.cgi?id=196632
1434
1435         Reviewed by Myles C. Maxfield.
1436
1437         Properly make Web GPU available on iOS 11+.
1438
1439         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1440
1441 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
1442
1443         [ews-build] Do not upload archive when Compile Fails
1444         https://bugs.webkit.org/show_bug.cgi?id=196674
1445
1446         Reviewed by Alexey Proskuryakov.
1447
1448         * BuildSlaveSupport/ews-build/factories.py:
1449         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
1450         * BuildSlaveSupport/ews-build/steps.py:
1451         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
1452         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
1453         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
1454
1455 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
1456
1457         Enable DFG on MIPS
1458         https://bugs.webkit.org/show_bug.cgi?id=196689
1459
1460         Reviewed by Žan Doberšek.
1461
1462         Since the bytecode change, we enabled the baseline JIT on mips in
1463         r240432, but DFG is still missing. With this change, all tests are
1464         passing on a ci20 board.
1465
1466         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
1467
1468 2019-04-08  Philippe Normand  <pnormand@igalia.com>
1469
1470         [Flatpak] Second run update-webkitwpe-flatpak fails
1471         https://bugs.webkit.org/show_bug.cgi?id=192702
1472
1473         Reviewed by Carlos Garcia Campos.
1474
1475         * flatpak/flatpakutils.py:
1476         (FlatpakObject.flatpak): Fix typo.
1477         (FlatpakPackage.install): When installing, also update to the configured remote commit.
1478         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
1479
1480 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
1481
1482         [GTK][WPE] outlook.live.com displays old-fashioned UI
1483         https://bugs.webkit.org/show_bug.cgi?id=196642
1484
1485         Reviewed by Carlos Garcia Campos.
1486
1487         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1488         (TestWebKitAPI::TEST): New Mac platform quirk test.
1489
1490 2019-04-07  Commit Queue  <commit-queue@webkit.org>
1491
1492         Unreviewed, rolling out r243956.
1493         https://bugs.webkit.org/show_bug.cgi?id=196688
1494
1495         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
1496         by aakashjain on #webkit).
1497
1498         Reverted changeset:
1499
1500         "Clicking "Go Back" from a safe browsing warning from an
1501         iframe should navigate the WKWebView back to the previous
1502         page"
1503         https://bugs.webkit.org/show_bug.cgi?id=196665
1504         https://trac.webkit.org/changeset/243956
1505
1506 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
1507
1508         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
1509         https://bugs.webkit.org/show_bug.cgi?id=196669
1510
1511         Reviewed by Geoffrey Garen.
1512
1513         Added three new unit tests for WeakHashSet.
1514
1515         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1516         (WTF_WeakPtr.WeakHashSetConstObjects):
1517         (WTF_WeakPtr.WeakHashSetComputesEmpty):
1518         (WTF_WeakPtr.WeakHashSetComputeSize):
1519
1520 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1521
1522         Hide next and previous form control buttons when WKWebView is editable
1523         https://bugs.webkit.org/show_bug.cgi?id=196672
1524         <rdar://problem/35625321>
1525
1526         Reviewed by Tim Horton.
1527
1528         Add a new API test.
1529
1530         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1531         (-[TestWKWebView lastTrailingBarButtonGroup]):
1532         (TestWebKitAPI::TEST):
1533         * TestWebKitAPI/ios/UIKitSPI.h:
1534
1535 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
1536
1537         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
1538         https://bugs.webkit.org/show_bug.cgi?id=196077
1539         <rdar://problem/49108202>
1540
1541         Reviewed by Chris Dumez.
1542
1543         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
1544         on new web view.
1545
1546         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1547
1548 2019-04-05  Saam Barati  <sbarati@apple.com>
1549
1550         Make compare-results understand MotionMark
1551         https://bugs.webkit.org/show_bug.cgi?id=196666
1552
1553         Reviewed by Yusuke Suzuki.
1554
1555         * Scripts/compare-results:
1556         (PLT5Results):
1557         (detectMotionMark):
1558         (detectMotionMark1_1):
1559         (motionMarkResults):
1560         (motionMark1_1Results):
1561         (detectBenchmark):
1562         (biggerIsBetter):
1563         (main):
1564
1565 2019-04-05  Alex Christensen  <achristensen@webkit.org>
1566
1567         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
1568         https://bugs.webkit.org/show_bug.cgi?id=196665
1569         <rdar://45115669>
1570
1571         Reviewed by Geoff Garen.
1572
1573         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1574         (goBack):
1575         (+[SimpleLookupContext sharedLookupContext]):
1576         (-[SimpleLookupContext lookUpURL:completionHandler:]):
1577         (TEST):
1578         (+[Simple3LookupContext sharedLookupContext]): Deleted.
1579         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
1580
1581 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
1582
1583         [ews-build] Add configuration and architecture for windows builders
1584         https://bugs.webkit.org/show_bug.cgi?id=196660
1585
1586         Reviewed by Lucas Forschler.
1587
1588         * BuildSlaveSupport/ews-build/config.json:
1589
1590 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
1591
1592         webkitpy: Don't run subsequent rounds if interrupted
1593         https://bugs.webkit.org/show_bug.cgi?id=196646
1594
1595         Reviewed by Aakash Jain.
1596
1597         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1598         (Manager.run): Bail out if interrupted.
1599
1600 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
1601
1602         Test sessionStorage in PSON private browsing mode
1603         https://bugs.webkit.org/show_bug.cgi?id=196561
1604
1605         Reviewed by Alex Christensen.
1606
1607         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1608
1609 2019-04-05  Commit Queue  <commit-queue@webkit.org>
1610
1611         Unreviewed, rolling out r243833.
1612         https://bugs.webkit.org/show_bug.cgi?id=196645
1613
1614         This change breaks build of WPE and GTK ports (Requested by
1615         annulen on #webkit).
1616
1617         Reverted changeset:
1618
1619         "[CMake][WTF] Mirror XCode header directories"
1620         https://bugs.webkit.org/show_bug.cgi?id=191662
1621         https://trac.webkit.org/changeset/243833
1622
1623 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
1624
1625         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
1626         https://bugs.webkit.org/show_bug.cgi?id=196635
1627
1628         Reviewed by Antti Koivisto.
1629         
1630         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
1631         for a test to enable async frame scrolling via:
1632             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
1633         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
1634         
1635         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
1636
1637         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1638         (WTR::InjectedBundle::beginTesting):
1639         * WebKitTestRunner/TestController.cpp:
1640         (WTR::TestController::resetPreferencesToConsistentValues):
1641
1642 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
1643
1644         Use a correct LC_RPATH when building with ASan
1645         https://bugs.webkit.org/show_bug.cgi?id=196576
1646
1647         Reviewed by David Kilzer.
1648
1649         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
1650         so that ../Frameworks is checked. This is simpler and more reliable than updating
1651         each SPC service xcconfig.
1652
1653 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1654
1655         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
1656         https://bugs.webkit.org/show_bug.cgi?id=196629
1657
1658         Reviewed by Lucas Forschler.
1659
1660         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1661
1662 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1663
1664         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
1665         https://bugs.webkit.org/show_bug.cgi?id=196618
1666
1667         Reviewed by Lucas Forschler.
1668
1669         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1670         (StatusBubble): Added QUEUE_TRIGGERS.
1671         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
1672         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
1673         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
1674         its parent(builder).
1675
1676 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1677
1678         [ews-app] Status-bubble steps are sometimes displayed in reverse order
1679         https://bugs.webkit.org/show_bug.cgi?id=196625
1680
1681         Reviewed by Lucas Forschler.
1682
1683         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1684         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
1685
1686 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1687
1688         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
1689         https://bugs.webkit.org/show_bug.cgi?id=196630
1690
1691         Reviewed by Wenson Hsieh.
1692
1693         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1694
1695 2019-04-04  Youenn Fablet  <youenn@apple.com>
1696
1697         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
1698         https://bugs.webkit.org/show_bug.cgi?id=196543
1699
1700         Reviewed by Alex Christensen.
1701
1702         * WebKitTestRunner/TestController.cpp:
1703         (WTR::TestController::generatePageConfiguration):
1704
1705 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1706
1707         [ews-app] Status bubble should not display skipped buildbot steps
1708         https://bugs.webkit.org/show_bug.cgi?id=196584
1709
1710         Reviewed by Lucas Forschler.
1711
1712         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1713
1714 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1715
1716         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
1717         https://bugs.webkit.org/show_bug.cgi?id=196620
1718
1719         Reviewed by Lucas Forschler.
1720
1721         * BuildSlaveSupport/ews-app/ews/config.py:
1722
1723 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
1724
1725         [Win] DumpRenderTreeWatchDog.py is not checked into source
1726         https://bugs.webkit.org/show_bug.cgi?id=196567
1727         <rdar://problem/49525901>
1728
1729         Reviewed by Lucas Forschler.
1730
1731         This script is used on Win EWS bots to terminate hanging DRT processes.
1732
1733         * EWSTools/dumprendertreewatchdog.py: Added.
1734
1735 2019-04-04  Chris Dumez  <cdumez@apple.com>
1736
1737         Unreviewed, roll out r243858 which made tests time out.
1738
1739         Disable new API tests on Windows instead.
1740
1741         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1742         (TestWebKitAPI::TEST):
1743
1744 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1745
1746         [ATK] Cleanup WebPageAccessibilityObjectAtk
1747         https://bugs.webkit.org/show_bug.cgi?id=196537
1748
1749         Reviewed by Michael Catanzaro.
1750
1751         Also consider files under atk directories as exceptions for GObject conventions.
1752
1753         * Scripts/webkitpy/style/checkers/cpp.py:
1754         (check_identifier_name_in_declaration):
1755
1756 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1757
1758         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1759         https://bugs.webkit.org/show_bug.cgi?id=196588
1760         <rdar://problem/49365787>
1761
1762         Unreviewed build fix for Windows port.
1763
1764         error C3861: 'kill': identifier not found
1765
1766         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1767         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
1768
1769 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1770
1771         [ews-build] Cancel build and similar operations should have authentication
1772         https://bugs.webkit.org/show_bug.cgi?id=196520
1773
1774         Reviewed by Dewei Zhu.
1775
1776         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
1777         environment variables.
1778
1779 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1780
1781         [ews-build] Do not trigger queues which are not in production yet
1782         https://bugs.webkit.org/show_bug.cgi?id=196581
1783
1784         Reviewed by Dewei Zhu.
1785
1786         * BuildSlaveSupport/ews-build/config.json:
1787
1788 2019-04-03  Chris Dumez  <cdumez@apple.com>
1789
1790         Unreviewed, fix typo in the name of API test added in r243848.
1791
1792         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1793         (TestWebKitAPI::TEST):
1794
1795 2019-04-03  Chris Dumez  <cdumez@apple.com>
1796
1797         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1798         https://bugs.webkit.org/show_bug.cgi?id=196588
1799         <rdar://problem/49365787>
1800
1801         Reviewed by Ryosuke Niwa.
1802
1803         Add API test coverage.
1804
1805         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1806         (TestWebKitAPI::nullJavaScriptCallback):
1807         (TestWebKitAPI::didCrashCheckFrames):
1808         (TestWebKitAPI::TEST):
1809
1810 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1811
1812         run-webkit-tests: Upload test results (new results database)
1813         https://bugs.webkit.org/show_bug.cgi?id=196577
1814         <rdar://problem/34841155>
1815
1816         Reviewed by Lucas Forschler.
1817
1818         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1819         (Manager.run): Upload results after each device shard, since the configuration will be
1820         different for each device.
1821         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
1822         uploaded to a results database.
1823         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1824         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
1825
1826 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1827
1828         -apple-trailing-word is needed for browser detection
1829         https://bugs.webkit.org/show_bug.cgi?id=196575
1830
1831         Unreviewed.
1832
1833         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1834
1835 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
1836
1837         [CMake][WTF] Mirror XCode header directories
1838         https://bugs.webkit.org/show_bug.cgi?id=191662
1839
1840         Reviewed by Konstantin Tokarev.
1841
1842         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
1843         builds.
1844
1845         * CMakeLists.txt:
1846         * DumpRenderTree/CMakeLists.txt:
1847         * DumpRenderTree/PlatformWin.cmake:
1848         * MiniBrowser/win/CMakeLists.txt:
1849         * TestWebKitAPI/CMakeLists.txt:
1850         * TestWebKitAPI/PlatformWin.cmake:
1851         * WebKitTestRunner/PlatformGTK.cmake:
1852         * WebKitTestRunner/PlatformWin.cmake:
1853
1854 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1855
1856         [ews-app] Status bubble should not display certain infrastructure status messages
1857         https://bugs.webkit.org/show_bug.cgi?id=196550
1858
1859         Reviewed by Lucas Forschler.
1860
1861         Do not display the steps which are un-needed for end-user. This information is still avaiable
1862         if the user click on the bubble and look at the Buildbot build.
1863         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1864         (StatusBubble._steps_messages):
1865         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
1866
1867 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1868
1869         [ews-build] Use https for sending data to ews-app
1870         https://bugs.webkit.org/show_bug.cgi?id=196492
1871
1872         Reviewed by Lucas Forschler.
1873
1874         * BuildSlaveSupport/ews-build/events.py:
1875
1876 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1877
1878         Remove support for -apple-trailing-word
1879         https://bugs.webkit.org/show_bug.cgi?id=196525
1880
1881         Reviewed by Zalan Bujtas.
1882
1883         This CSS property is nonstandard and not used.
1884
1885         * Scripts/webkitperl/FeatureList.pm:
1886         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1887
1888 2019-04-03  Youenn Fablet  <youenn@apple.com>
1889
1890         Add a test for DOMCache on multiple browsing in case of private browsing
1891         https://bugs.webkit.org/show_bug.cgi?id=196524
1892
1893         Reviewed by Alex Christensen.
1894
1895         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1896         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
1897
1898 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1899
1900         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
1901         https://bugs.webkit.org/show_bug.cgi?id=196540
1902
1903         Reviewed by Aakash Jain.
1904
1905         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
1906
1907 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1908
1909         Add plumbing for a compatibility mode preference in WebKit
1910         https://bugs.webkit.org/show_bug.cgi?id=196005
1911
1912         Reviewed by Tim Horton.
1913
1914         Add new API tests.
1915
1916         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1917         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
1918
1919 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
1920
1921         [WPE][GTK] Update libsrtp dependency package for Debian
1922         https://bugs.webkit.org/show_bug.cgi?id=196528
1923
1924         Reviewed by Frédéric Wang.
1925
1926         * gtk/install-dependencies:
1927         * wpe/install-dependencies:
1928
1929 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1930
1931         [WK2] Add support for Window's beforeprint / afterprint events
1932         https://bugs.webkit.org/show_bug.cgi?id=196478
1933         <rdar://problem/49535124>
1934
1935         Unreviewed build fix for MSVC.
1936
1937         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
1938
1939         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
1940
1941         * WebKitTestRunner/TestController.cpp:
1942         (WTR::printFrame): Use int and float literals.
1943
1944 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1945
1946         [ews-build] Reassign bots to queues
1947
1948         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
1949
1950 2019-04-02  Chris Dumez  <cdumez@apple.com>
1951
1952         [WK2] Add support for Window's beforeprint / afterprint events
1953         https://bugs.webkit.org/show_bug.cgi?id=196478
1954
1955         Reviewed by Alex Christensen.
1956
1957         Add minimal implementation for printFrame in WebKitTestRunner.
1958
1959         * WebKitTestRunner/TestController.cpp:
1960         (WTR::printFrame):
1961         (WTR::TestController::createOtherPage):
1962         (WTR::TestController::createWebViewWithOptions):
1963
1964 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1965
1966         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
1967         https://bugs.webkit.org/show_bug.cgi?id=196491
1968
1969         Reviewed by Lucas Forschler.
1970
1971         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1972
1973 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1974
1975         [ews-build] Configure buildbot try credentials in environment variables
1976         https://bugs.webkit.org/show_bug.cgi?id=196501
1977
1978         Reviewed by Lucas Forschler.
1979
1980         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
1981         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
1982         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
1983
1984 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1985
1986         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
1987         https://bugs.webkit.org/show_bug.cgi?id=196496
1988         <rdar://problem/49521634>
1989
1990         Reviewed by Chris Dumez.
1991
1992         Add new API tests (see WebKit ChangeLog for more detail).
1993
1994         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1995         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1996         (TEST):
1997
1998 2019-04-02  David Kilzer  <ddkilzer@apple.com>
1999
2000         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
2001         <https://webkit.org/b/196499>
2002
2003         Reviewed by Alexey Proskuryakov.
2004
2005         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
2006         ENABLE_ADDRESS_SANITIZER.
2007
2008 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2009
2010         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
2011         https://bugs.webkit.org/show_bug.cgi?id=182757
2012
2013         Reviewed by Don Olmstead.
2014
2015         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
2016         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
2017
2018 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
2019
2020         run-api-tests: Upload test results
2021         https://bugs.webkit.org/show_bug.cgi?id=196323
2022         <rdar://problem/49356714>
2023
2024         Reviewed by Lucas Forschler.
2025
2026         * Scripts/webkitpy/api_tests/manager.py:
2027         (Manager):
2028         (Manager.run): Upload results to a results database.
2029         * Scripts/webkitpy/api_tests/run_api_tests.py:
2030         (parse_args): Add upload arguments.
2031         * Scripts/webkitpy/port/base.py:
2032         (Port):
2033         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
2034         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
2035         with commits from any other associated repositories.
2036         * Scripts/webkitpy/port/device.py:
2037         (Device):
2038         (Device.build_version): Access build_versoin of underlying platform device.
2039         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2040         (IOSSimulatorTest):
2041         (IOSSimulatorTest.test_configuration_for_upload):
2042         * Scripts/webkitpy/port/device_port.py:
2043         (DevicePort):
2044         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
2045         the same as the machine uploading results.
2046         * Scripts/webkitpy/port/mac.py:
2047         (MacPort):
2048         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
2049         * Scripts/webkitpy/port/mac_unittest.py:
2050         (MacTest):
2051         (MacTest.test_configuration_for_upload):
2052         * Scripts/webkitpy/xcode/simulated_device.py:
2053         (SimulatedDeviceManager._create_device_with_runtime):
2054         (SimulatedDevice.__init__): Create simulated device with a build_version.
2055         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
2056         (test_existing_simulator):
2057
2058 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2059
2060         Remove extra newline characters (Follow-up fix to r243707)
2061
2062         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2063
2064 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2065
2066         [ews-app] Use API_KEY to accept results data
2067         https://bugs.webkit.org/show_bug.cgi?id=196461
2068
2069         Reviewed by Dewei Zhu.
2070
2071         * BuildSlaveSupport/ews-app/ews/views/results.py:
2072         (Results.post): Validate EWS_API_KEY before accepting any data.
2073         * BuildSlaveSupport/ews-build/events.py:
2074         (Events.sendData): Send EWS_API_KEY if available along with event data.
2075
2076 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2077
2078         Unable to copy and paste a PDF from Notes into Mail compose body
2079         https://bugs.webkit.org/show_bug.cgi?id=196442
2080         <rdar://problem/48573098>
2081
2082         Reviewed by Tim Horton.
2083
2084         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
2085         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
2086         to be specified on the item providers.
2087
2088         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2089         (TestWebKitAPI::mapItemForTesting):
2090         (TestWebKitAPI::contactItemForTesting):
2091
2092 2019-04-01  Tim Horton  <timothy_horton@apple.com>
2093
2094         Make UIWKDocumentContext rects per-character instead of per-word
2095         https://bugs.webkit.org/show_bug.cgi?id=196459
2096
2097         Reviewed by Wenson Hsieh.
2098
2099         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2100         (TEST):
2101         Adjust test results due to switching to per-character rects.
2102
2103 2019-04-01  Chris Dumez  <cdumez@apple.com>
2104
2105         UIProcess crash when a prewarmed process is terminated
2106         https://bugs.webkit.org/show_bug.cgi?id=196451
2107         <rdar://problem/49245471>
2108
2109         Reviewed by Geoffrey Garen.
2110
2111         Add API test coverage.
2112
2113         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2114         (TEST):
2115
2116 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2117
2118         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
2119         https://bugs.webkit.org/show_bug.cgi?id=196449
2120
2121         Reviewed by Lucas Forschler.
2122
2123         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2124         (StatusBubble.get_os_details): Method to get OS and Xcode details.
2125         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
2126         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
2127
2128 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2129
2130         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
2131         https://bugs.webkit.org/show_bug.cgi?id=196444
2132
2133         Reviewed by Lucas Forschler.
2134
2135         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
2136
2137 2019-04-01  Alex Christensen  <achristensen@webkit.org>
2138
2139         Add SPI to canonicalize NSURLs with WTF::URL
2140         https://bugs.webkit.org/show_bug.cgi?id=196415
2141         <rdar://problem/44980271>
2142
2143         Reviewed by Darin Adler.
2144
2145         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2146         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
2147         (TestWebKitAPI::TEST):
2148
2149 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
2150
2151         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
2152         https://bugs.webkit.org/show_bug.cgi?id=196441
2153
2154         Reviewed by Carlos Garcia Campos.
2155
2156         Don't cache the wpe_view_backend object that might not exist yet at the
2157         time of EventSenderProxy constructor invocation, but instead retrieve
2158         that object whenever it's required for event dispatching. This should
2159         avoid crashes in this constructor now that it's invoked before any
2160         PlatformWindow has been set up (as changed in r243496).
2161
2162         * WebKitTestRunner/EventSenderProxy.h:
2163         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2164         (WTR::viewBackend):
2165         (WTR::EventSenderProxy::EventSenderProxy):
2166         (WTR::EventSenderProxy::mouseDown):
2167         (WTR::EventSenderProxy::mouseUp):
2168         (WTR::EventSenderProxy::mouseMoveTo):
2169         (WTR::EventSenderProxy::mouseScrollBy):
2170         (WTR::EventSenderProxy::keyDown):
2171         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
2172
2173 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
2174
2175         [Win][WebKit] MiniBrowser should support high DPI display
2176         https://bugs.webkit.org/show_bug.cgi?id=196391
2177
2178         Reviewed by Alex Christensen.
2179
2180         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2181         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
2182         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
2183         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
2184
2185 2019-03-31  Sam Weinig  <weinig@apple.com>
2186
2187         Remove more i386 specific configurations
2188         https://bugs.webkit.org/show_bug.cgi?id=196430
2189
2190         Reviewed by Alexey Proskuryakov.
2191
2192         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2193         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
2194
2195 2019-03-31  Andy Estes  <aestes@apple.com>
2196
2197         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
2198         https://bugs.webkit.org/show_bug.cgi?id=196433
2199         <rdar://problem/49293305>
2200
2201         Reviewed by Tim Horton.
2202
2203         Enhanced API test coverage to include all navigation response policy decisions in both
2204         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
2205
2206         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2207         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
2208         (TestWebKitAPI::TEST):
2209         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
2210         (readFile):
2211         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
2212         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
2213         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2214         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2215         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2216         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
2217         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
2218         (-[QuickLookDelegate _downloadDidStart:]):
2219         (-[QuickLookDelegate _download:didReceiveResponse:]):
2220         (-[QuickLookDelegate _download:didReceiveData:]):
2221         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2222         (-[QuickLookDelegate _downloadDidFinish:]):
2223         (-[QuickLookDelegate _download:didFailWithError:]):
2224         (-[QuickLookDelegate _downloadDidCancel:]):
2225         (-[QuickLookDelegate verifyDownload]):
2226         (runTest):
2227         (runTestDecideBeforeLoading):
2228         (runTestDecideAfterLoading):
2229         (TEST):
2230         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2231         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
2232         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
2233         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
2234         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
2235         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
2236         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2237         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
2238         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
2239         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
2240         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2241         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
2242         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
2243         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
2244
2245 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
2246
2247         [CMake] add testdfg as target with build-jsc
2248         https://bugs.webkit.org/show_bug.cgi?id=196393
2249
2250         Reviewed by Saam Barati.
2251
2252         Added testdfg as one of the targets to build when
2253         using CMake.
2254
2255         * Scripts/build-jsc:
2256
2257 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
2258
2259         Delete WebMetal implementation in favor of WebGPU
2260         https://bugs.webkit.org/show_bug.cgi?id=195418
2261
2262         Reviewed by Dean Jackson.
2263
2264         * DumpRenderTree/mac/DumpRenderTree.mm:
2265         (enableExperimentalFeatures):
2266         (resetWebPreferencesToConsistentValues):
2267         * Scripts/webkitperl/FeatureList.pm:
2268         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2269         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2270         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
2271         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
2272         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
2273         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
2274         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
2275         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
2276         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
2277         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2278         (WTR::InjectedBundle::beginTesting):
2279         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2280         (WTR::TestRunner::setWebMetalEnabled): Deleted.
2281         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2282
2283 2019-03-29  Chris Dumez  <cdumez@apple.com>
2284
2285         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
2286         https://bugs.webkit.org/show_bug.cgi?id=196405
2287         <rdar://problem/49428130>
2288
2289         Reviewed by Wenson Hsieh.
2290
2291         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
2292         the popover presentation methods to be no-ops. Use this in the new test added in
2293         r243523 so that we do not swizzle those methods for all tests. This is needed because
2294         those WatchOS tests rely on the popover getting presented and interactive.
2295
2296         * WebKitTestRunner/TestController.cpp:
2297         (WTR::updateTestOptionsFromTestHeader):
2298         * WebKitTestRunner/TestController.h:
2299         * WebKitTestRunner/TestOptions.h:
2300         (WTR::TestOptions::hasSameInitializationOptions const):
2301         * WebKitTestRunner/ios/TestControllerIOS.mm:
2302         (WTR::TestController::platformInitialize):
2303         (WTR::TestController::platformResetStateToConsistentValues):
2304
2305 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
2306
2307         [Curl] Add Server Trust Evaluation Support.
2308         https://bugs.webkit.org/show_bug.cgi?id=191646
2309
2310         Reviewed by Fujii Hironori.
2311
2312         Implemented MiniBrowser UI for asking if user trusts the server.
2313
2314         * MiniBrowser/win/Common.cpp:
2315         (askServerTrustEvaluation):
2316         (replaceString):
2317         * MiniBrowser/win/Common.h:
2318         * MiniBrowser/win/MiniBrowserLib.rc:
2319         * MiniBrowser/win/MiniBrowserLibResource.h:
2320         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2321         (createPEMString):
2322         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
2323         (WebKitBrowserWindow::canTrustServerCertificate):
2324         * MiniBrowser/win/WebKitBrowserWindow.h:
2325
2326 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
2327
2328         Implement ResizeObserver.
2329         https://bugs.webkit.org/show_bug.cgi?id=157743
2330
2331         Reviewed by Simon Fraser.
2332
2333         Support resizeObserverEnabled webPreferences.
2334
2335         * DumpRenderTree/TestOptions.cpp:
2336         (TestOptions::TestOptions):
2337         * DumpRenderTree/TestOptions.h:
2338         * DumpRenderTree/mac/DumpRenderTree.mm:
2339         (setWebPreferencesForTestOptions):
2340         * DumpRenderTree/win/DumpRenderTree.cpp:
2341         (enableExperimentalFeatures):
2342         * Scripts/webkitperl/FeatureList.pm:
2343         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2344
2345 2019-03-28  John Wilander  <wilander@apple.com>
2346
2347         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
2348         https://bugs.webkit.org/show_bug.cgi?id=196281
2349         <rdar://problem/48938748>
2350
2351         Reviewed by Alex Christensen.
2352
2353         This patch adds the function isStatisticsHasLocalStorage() to the
2354         TestRunner. With it, the page can query the WebsiteDataStore in the
2355         UI process to make sure that it sees LocalStorage.
2356
2357         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2358         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2359         (WTR::TestRunner::isStatisticsHasLocalStorage):
2360         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2361         * WebKitTestRunner/TestController.cpp:
2362         (WTR::TestController::isStatisticsHasLocalStorage):
2363         * WebKitTestRunner/TestController.h:
2364         * WebKitTestRunner/TestInvocation.cpp:
2365         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2366
2367 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
2368
2369         API::Data::createWithoutCopying should do a null check before calling CFRelease
2370         https://bugs.webkit.org/show_bug.cgi?id=196276
2371         <rdar://problem/48059859>
2372
2373         Reviewed by Alex Christensen.
2374
2375         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
2376
2377         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2378         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
2379         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
2380         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
2381         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2382         (TestWebKitAPI::TEST):
2383
2384 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2385
2386         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
2387         https://bugs.webkit.org/show_bug.cgi?id=186276
2388
2389         Reviewed by Carlos Garcia Campos.
2390
2391         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
2392         (webViewLoadChanged):
2393         (testWebResourceGetDataError):
2394         (testWebResourceGetDataEmpty):
2395         (beforeAll):
2396         (webViewloadChanged): Deleted.
2397
2398 2019-03-27  Andy Estes  <aestes@apple.com>
2399
2400         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
2401         https://bugs.webkit.org/show_bug.cgi?id=196317
2402
2403         Reviewed by Dan Bernstein.
2404
2405         package-root copies built products into a staging directory using ditto(1), which does not
2406         follow symbolic links as it traverses a directory. Now that the files in
2407         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
2408         itself, these become broken links when ditto'd into the staging directory.
2409
2410         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
2411
2412         * Scripts/package-root:
2413
2414 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
2415
2416         [ews-app] Update display text of Submit for ews analysis
2417         https://bugs.webkit.org/show_bug.cgi?id=196309
2418
2419         Reviewed by Dewei Zhu.
2420
2421         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2422
2423 2019-03-27  David Kilzer  <ddkilzer@apple.com>
2424
2425         run-webkit-tests should check for leaks in WebKit processes
2426         <https://webkit.org/b/193772>
2427         <rdar://problem/46526680>
2428
2429         Reviewed by Ryosuke Niwa.
2430
2431         This works by doing the following:
2432         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
2433           The list of child processes are returned one per line:
2434           process.name: pid
2435         - Run the "#LIST CHILD PROCESSES" command just before the
2436           "#CHECK FOR WORLD LEAKS" command, and store the list of child
2437           processes on the ServerProcess object.
2438         - When the `--leaks` switch is handled, run check_for_leaks() on
2439           each child process after the main test harness.
2440
2441         * DumpRenderTree/mac/DumpRenderTree.mm:
2442         (handleControlCommand):
2443         - Use strncmp() instead of strcmp().
2444         - Add support for handling "#LIST CHILD PROCESSES" command.
2445
2446         * Scripts/webkitpy/port/base.py:
2447         (Port.check_for_leaks):
2448         * Scripts/webkitpy/port/darwin.py:
2449         (DarwinPort.check_for_leaks):
2450         - Rename redundant 'process_pid' argument to 'process_id'.
2451
2452         * Scripts/webkitpy/port/driver.py:
2453         (Driver.do_post_tests_work):
2454         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
2455           longer the only command this sends to WebKitTestRunner.
2456         - If the `--leaks` switch is present, send the
2457           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
2458           result using Port.set_webkit_processes().
2459         (Driver._parse_child_processes_output):
2460         - Add helper method to parse list of child process names and
2461           process IDs returned from WebKitTestRunner.
2462
2463         * Scripts/webkitpy/port/ios_device.py:
2464         (IOSDevicePort.check_for_leaks):
2465         - Rename redundant 'process_pid' argument to 'process_id'.
2466
2467         * Scripts/webkitpy/port/leakdetector.py:
2468         (LeakDetector._parse_leaks_output):
2469         - Return early if there is no leaks_output.
2470         (LeakDetector.check_for_leaks):
2471         - Rename redundant 'process_pid' argument to 'process_id'.
2472
2473         * Scripts/webkitpy/port/server_process.py:
2474         (ServerProcess.__init__):
2475         (ServerProcess.child_processes):
2476         (ServerProcess.set_child_processes):
2477         - Add instance variable to Port to store list of child process
2478           names and process IDs returned from WebKitTestRunner.
2479         (ServerProcess._start):
2480         - Clear self._child_processes.
2481         (ServerProcess.stop):
2482         - If self._child_processes is set, call
2483           self._port.check_for_leaks() for each child process.
2484
2485         * Scripts/webkitpy/port/server_process_unittest.py:
2486         (TrivialMockPort.check_for_leaks):
2487         - Rename redundant 'process_pid' argument to 'process_id'.
2488
2489         * Scripts/webkitpy/port/simulator_process.py:
2490         (SimulatorProcess.stop):
2491         - If self._child_processes is set, call
2492           self._port.check_for_leaks() for each child process.
2493
2494         * Scripts/webkitpy/port/watch_device.py:
2495         (WatchDevicePort.check_for_leaks):
2496         - Rename redundant 'process_pid' argument to 'process_id'.
2497
2498         * WebKitTestRunner/TestController.cpp:
2499         (WTR::TestController::dumpResponse):
2500         - Extract method from findAndDumpWorldLeaks() so that it may be
2501           reused by findAndDumpWebKitProcessIdentifiers().
2502         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
2503         - Add method to output process name and process ID of both the
2504           WebContent and Networking processes.
2505         (WTR::TestController::findAndDumpWorldLeaks):
2506         - Fix missing newline in output when there were no abandoned
2507           documents.
2508         - Call dumpResponse() for extracted code.
2509         (WTR::TestController::handleControlCommand):
2510         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
2511         - Use strncmp() instead of strcmp().
2512         - Call findAndDumpWebKitProcessIdentifiers() when
2513           "#LIST CHILD PROCESSES" command is sent.
2514         * WebKitTestRunner/TestController.h:
2515         (WTR::TestController::dumpResponse):
2516         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
2517         - Declare methods.
2518
2519 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2520
2521         Unreviewed. Add GLib API test cases after r243434.
2522
2523         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2524         (testWebViewActiveURI):
2525         (serverCallback):
2526         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2527         (sendRequestCallback):
2528
2529 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2530
2531         Geolocation request not complete when watch request was started in a different web process
2532         https://bugs.webkit.org/show_bug.cgi?id=195996
2533
2534         Reviewed by Alex Christensen.
2535
2536         Add a test case.
2537
2538         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
2539         (TestWebKitAPI::runJavaScriptAlert):
2540         (TestWebKitAPI::TEST):
2541
2542 2019-03-26  Keith Rollin  <krollin@apple.com>
2543
2544         Update the way generate-xcfilelists returns strings from functions
2545         https://bugs.webkit.org/show_bug.cgi?id=195975
2546         <rdar://problem/49040807>
2547
2548         Reviewed by Dean Jackson.
2549
2550         There are places where generate-xcfilelists executes assignments with
2551         statements like:
2552
2553             FOO=$(some_function)
2554
2555         where "some_function" return a string by echoing it. E.g.
2556
2557             some_function()
2558             {
2559                 echo "Hello, World"
2560             }
2561
2562         This is a common idiom, but it has a problem if "some_function" needs
2563         to call "exit" in an attempt to halt the entire script right then and
2564         there. Since "some_function" is called inside of $(), it's being
2565         executed in a sub-shell. Calling exit in that sub-shell simply exits
2566         that shell; it doesn't not exit the outer shell in which the main part
2567         of the script is still running. As such, the main script keeps
2568         executing when the intent was for the script to halt.
2569
2570         The solution to this is to use a different idiom for returning
2571         strings. The one we now is to pass in the name of the variable to
2572         receive the string result:
2573
2574             some_function()
2575             {
2576                 variable_name=$1
2577                 eval $variable_name ="Hello, World"
2578             }
2579
2580         The call site now looks like
2581
2582             some_function FOO
2583
2584         Because there's no invocation of a sub-shell, some_function can now
2585         call "exit" if it wants to, and the entire script will exit at that
2586         point.
2587
2588         * Scripts/generate-xcfilelists:
2589
2590 2019-03-26  Chris Dumez  <cdumez@apple.com>
2591
2592         Add basic layout test coverage for File Picker on iOS
2593         https://bugs.webkit.org/show_bug.cgi?id=196265
2594
2595         Reviewed by Wenson Hsieh.
2596
2597         Add layout test infrastructure to test the file picker on iOS.
2598
2599         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2600         (WTR::UIScriptController::dismissFilePicker):
2601         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2602         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2603         (WTR::UIScriptController::dismissFilePicker):
2604         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2605         * WebKitTestRunner/TestController.cpp:
2606         (WTR::TestController::createWebViewWithOptions):
2607         (WTR::updateTestOptionsFromTestHeader):
2608         * WebKitTestRunner/TestOptions.h:
2609         (WTR::TestOptions::hasSameInitializationOptions const):
2610         * WebKitTestRunner/ios/TestControllerIOS.mm:
2611         (overridePresentViewController):
2612         (WTR::TestController::platformInitialize):
2613         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2614         (WTR::UIScriptController::dismissFilePicker):
2615
2616 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
2617
2618         Implement async paste method on UIWKInteractionViewProtocol
2619         https://bugs.webkit.org/show_bug.cgi?id=196267
2620         <rdar://problem/49236346>
2621
2622         Reviewed by Tim Horton.
2623
2624         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
2625         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
2626         are now a part of all iOS 12 internal SDKs.
2627
2628         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2629
2630         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
2631         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
2632
2633         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2634         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2635         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
2636         * TestWebKitAPI/ios/UIKitSPI.h:
2637
2638 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2639
2640         [ews-build] Use PostgreSQL for ews.webkit.org database
2641         https://bugs.webkit.org/show_bug.cgi?id=196270
2642
2643         Reviewed by Lucas Forschler.
2644
2645         * BuildSlaveSupport/ews-app/ews-app/settings.py:
2646
2647 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
2648
2649         [ews] Reset simctl states on reboot
2650         https://bugs.webkit.org/show_bug.cgi?id=196260
2651
2652         Rubber-stamped by Aakash Jain.
2653
2654         * EWSTools/start-queue-mac.sh:
2655
2656 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2657
2658         [ews-build] Use PostgreSQL for ews-build database
2659         https://bugs.webkit.org/show_bug.cgi?id=196229
2660
2661         Reviewed by Lucas Forschler.
2662
2663         * BuildSlaveSupport/ews-build/master.cfg:
2664
2665 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2666
2667         [ews-build] Get master_hostname dynamically in master.cfg
2668         https://bugs.webkit.org/show_bug.cgi?id=196255
2669
2670         Reviewed by Lucas Forschler.
2671
2672         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
2673         send events data in test mode.
2674
2675 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2676
2677         [ews-app] Set db_constraint to False for Foreign Keys
2678         https://bugs.webkit.org/show_bug.cgi?id=196252
2679
2680         Reviewed by Lucas Forschler.
2681
2682         * BuildSlaveSupport/ews-app/ews/models/build.py:
2683         * BuildSlaveSupport/ews-app/ews/models/step.py:
2684
2685 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2686
2687         [ews-build] is_test_mode_enabled should default to True
2688         https://bugs.webkit.org/show_bug.cgi?id=196248
2689
2690         Reviewed by Lucas Forschler.
2691
2692         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
2693
2694 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2695
2696         [ews-app] Add webkitperl to ENABLED_QUEUES
2697         https://bugs.webkit.org/show_bug.cgi?id=196253
2698
2699         Reviewed by Lucas Forschler.
2700
2701         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2702
2703 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
2704
2705         Address NSWindow sometimes using WebKitTestRunnerEvent too early
2706         https://bugs.webkit.org/show_bug.cgi?id=196211
2707         rdar://problem/49110552
2708
2709         Reviewed by Tim Horton.
2710
2711         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
2712         Make sure that EventSenderProxy always exists when running tests. We used to create
2713         it when resetting before the first test, which is a bit too late.
2714
2715         * WebKitTestRunner/TestController.h:
2716         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2717         (WTR::TestController::platformCreateWebView):
2718         (WTR::TestController::platformCreateOtherPage):
2719         (WTR::TestController::finishCreatingPlatformWebView):
2720         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2721         (WTR::PlatformWebView::PlatformWebView):
2722         Moved some code that made NSWindow use NSEvent during web view creation. We may
2723         need to move more if some other case us found, but this is enough for now.
2724
2725 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2726
2727         Unreviewed. Fix typo in GLib geolocation API after r243285.
2728
2729         gelocation -> geolocation.
2730
2731         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
2732         (testGeolocationManagerWatchPosition):
2733
2734 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2735
2736         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2737         https://bugs.webkit.org/show_bug.cgi?id=196213
2738
2739         Reviewed by Geoff Garen.
2740
2741         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2742         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2743         (credentialWithIdentityAndKeychainPath):
2744         (-[ChallengeDelegate webView:didFinishNavigation:]):
2745         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2746         (TestWebKitAPI::TEST):
2747
2748 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2749
2750         Expected shouldn't assume its contained types are copyable
2751         https://bugs.webkit.org/show_bug.cgi?id=195986
2752
2753         Reviewed by JF Bastien.
2754
2755         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2756         (TestWebKitAPI::NonCopyable::operator== const):
2757         (TestWebKitAPI::NonCopyable::operator!= const):
2758         (TestWebKitAPI::TEST):
2759
2760 2019-03-25  Tim Horton  <timothy_horton@apple.com>
2761
2762         Remove some now-unnecessary dynamic class lookup
2763         https://bugs.webkit.org/show_bug.cgi?id=196237
2764
2765         Reviewed by Simon Fraser.
2766
2767         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2768         (makeRequest):
2769         (TEST):
2770
2771 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
2772
2773         Unreviewed, rolling out r243450.
2774
2775         AppleWin and WinCairo port builds get broken.
2776
2777         Reverted changeset:
2778
2779         "Add test for fix of #196095"
2780         https://bugs.webkit.org/show_bug.cgi?id=196097
2781         https://trac.webkit.org/changeset/243450
2782
2783 2019-03-25  Commit Queue  <commit-queue@webkit.org>
2784
2785         Unreviewed, rolling out r243465.
2786         https://bugs.webkit.org/show_bug.cgi?id=196226
2787
2788         the test doesn't build (Requested by thorton on #webkit).
2789
2790         Reverted changeset:
2791
2792         "Do not terminate the NetworkProcess if a third party
2793         application sends a NSCredential with a SecIdentityRef"
2794         https://bugs.webkit.org/show_bug.cgi?id=196213
2795         https://trac.webkit.org/changeset/243465
2796
2797 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2798
2799         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2800         https://bugs.webkit.org/show_bug.cgi?id=196213
2801
2802         Reviewed by Geoff Garen.
2803
2804         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2805         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2806         (credentialWithIdentityAndKeychainPath):
2807         (-[ChallengeDelegate webView:didFinishNavigation:]):
2808         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2809         (TestWebKitAPI::TEST):
2810
2811 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2812
2813         [ews-build] Gracefully handle missing patch_id in events
2814         https://bugs.webkit.org/show_bug.cgi?id=196216
2815
2816         Reviewed by Lucas Forschler.
2817
2818         * BuildSlaveSupport/ews-build/events.py:
2819
2820 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2821
2822         [ews-build] use lz4 compression for improving buildbot performance
2823         https://bugs.webkit.org/show_bug.cgi?id=196155
2824
2825         Reviewed by Lucas Forschler.
2826
2827         * BuildSlaveSupport/ews-build/master.cfg:
2828
2829 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2830
2831         Pull some API testing helper methods out of TestWKWebView
2832         https://bugs.webkit.org/show_bug.cgi?id=196212
2833
2834         Reviewed by Tim Horton.
2835
2836         Refactor some more API testing utility methods, so that they can be used in
2837         tests that do not use TestWKWebView.
2838
2839         * TestWebKitAPI/cocoa/TestWKWebView.h:
2840         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2841         (-[WKWebView loadTestPageNamed:]):
2842         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
2843         (-[WKWebView synchronouslyLoadHTMLString:]):
2844         (-[WKWebView synchronouslyLoadTestPageNamed:]):
2845         (-[TestWKWebView loadTestPageNamed:]): Deleted.
2846         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
2847         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
2848         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
2849
2850 2019-03-25  Jer Noble  <jer.noble@apple.com>
2851
2852         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2853         https://bugs.webkit.org/show_bug.cgi?id=196097
2854
2855         Reviewed by Eric Carlson.
2856
2857         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2858
2859         * DumpRenderTree/mac/DumpRenderTree.mm:
2860         (resetWebPreferencesToConsistentValues):
2861         * WebKitTestRunner/TestController.cpp:
2862         (WTR::TestController::resetPreferencesToConsistentValues):
2863
2864 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2865
2866         Pull IPadUserInterfaceSwizzler out into a separate header file
2867         https://bugs.webkit.org/show_bug.cgi?id=196193
2868
2869         Reviewed by Anders Carlsson.
2870
2871         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
2872         be used in other API tests.
2873
2874         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2875         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2876         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
2877         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
2878         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
2879         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
2880         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
2881
2882 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2883
2884         Remove NavigatorContentUtils in WebCore/Modules
2885         https://bugs.webkit.org/show_bug.cgi?id=196070
2886
2887         Reviewed by Alex Christensen.
2888
2889         NavigatorContentUtils was to support the custom scheme spec [1].
2890         However, in WebKit side, no port has supported the feature in
2891         WebKit layer after EFL port was removed. So there has been the
2892         only IDL implementation of the NavigatorContentUtils in WebCore.
2893         So we don't need to keep the implementation in WebCore anymore.
2894
2895         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
2896
2897         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2898
2899 2019-03-24  Andy Estes  <aestes@apple.com>
2900
2901         [watchOS] Remove unused Proximity Networking code
2902         https://bugs.webkit.org/show_bug.cgi?id=196188
2903
2904         Reviewed by Tim Horton.
2905
2906         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2907         (TEST):
2908
2909 2019-03-23  Keith Miller  <keith_miller@apple.com>
2910
2911         Refactor clz/ctz and fix getLSBSet.
2912         https://bugs.webkit.org/show_bug.cgi?id=196162
2913
2914         Reviewed by Saam Barati.
2915
2916         Add tests for clz, ctz, getLSBSet, and getMSBSet.
2917
2918         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2919         (TestWebKitAPI::TEST):
2920
2921 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2922
2923         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
2924         https://bugs.webkit.org/show_bug.cgi?id=196143
2925
2926         Reviewed by Michael Catanzaro.
2927
2928         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
2929         directories.
2930
2931         * Scripts/webkitpy/style/checkers/cpp.py:
2932         (check_identifier_name_in_declaration):
2933         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2934         (WebKitStyleTest.test_names):
2935
2936 2019-03-22  Philippe Normand  <pnormand@igalia.com>
2937
2938         [Flatpak] Manifest expanding fails for qt WPE extension
2939         https://bugs.webkit.org/show_bug.cgi?id=196148
2940
2941         Reviewed by Alex Christensen.
2942
2943         * flatpak/flatpakutils.py:
2944         (expand_submodules_recurse): The last recurse manifest expand
2945         iteration might lead to a single module so take it into account
2946         and don't try to recurse further.
2947
2948 2019-03-22  Chris Dumez  <cdumez@apple.com>
2949
2950         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
2951         https://bugs.webkit.org/show_bug.cgi?id=195348
2952         <rdar://problem/48622090>
2953
2954         Reviewed by Alex Christensen.
2955
2956         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
2957         to NO when test.options().shouldIgnoreMetaViewport is false.
2958
2959         * WebKitTestRunner/ios/TestControllerIOS.mm:
2960         (WTR::TestController::platformConfigureViewForTest):
2961
2962 2019-03-22  Chris Dumez  <cdumez@apple.com>
2963
2964         Prewarmed processes should be usable with any website data store
2965         https://bugs.webkit.org/show_bug.cgi?id=196104
2966
2967         Reviewed by Alex Christensen.
2968
2969         Add API test coverage.
2970
2971         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2972         (runInitialWarmedProcessUsedTest):
2973         (TEST):
2974
2975 2019-03-22  David Kilzer  <ddkilzer@apple.com>
2976
2977         Back out local changes to Alex's Subversion working directory
2978
2979         They were accidentally committed.
2980
2981         * Scripts/webkitpy/common/system/abstractexecutive.py:
2982         (AbstractExecutive.wait_newest):
2983         * Scripts/webkitpy/common/system/executive.py:
2984         (Executive.running_pids):
2985         * Scripts/webkitpy/common/system/executive_mock.py:
2986         (MockExecutive.running_pids):
2987         * Scripts/webkitpy/common/system/executive_unittest.py:
2988         (ExecutiveTest.serial_test_running_pids):
2989         * Scripts/webkitpy/port/darwin.py:
2990         (DarwinPort.check_for_leaks):
2991         * Scripts/webkitpy/port/leakdetector.py:
2992         (LeakDetector.check_for_leaks):
2993         - This was the hack attached to Bug 193772.
2994
2995         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
2996         (+[WebKitTestRunnerEvent mouseLocation]):
2997         - This works around a crash on an internal build.
2998
2999 2019-03-22  Tim Horton  <timothy_horton@apple.com>
3000
3001         Fix the build after r243354
3002         https://bugs.webkit.org/show_bug.cgi?id=196138
3003         <rdar://problem/49145951>
3004
3005         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3006         (TEST):
3007         * TestWebKitAPI/ios/UIKitSPI.h:
3008
3009 2019-03-21  Tim Horton  <timothy_horton@apple.com>
3010
3011         Adopt UIWKDocumentContext
3012         https://bugs.webkit.org/show_bug.cgi?id=196040
3013         <rdar://problem/48642440>
3014
3015         Reviewed by Ryosuke Niwa.
3016
3017         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3018         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
3019         (makeRequest):
3020         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
3021         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
3022         (applyStyle):
3023         (TEST):
3024         Add tests for UIWKDocumentContext.
3025
3026         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
3027         (TEST):
3028         (recursiveFindWKContentView): Deleted.
3029         * TestWebKitAPI/cocoa/TestWKWebView.h:
3030         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3031         (recursiveFindWKContentView):
3032         (-[TestWKWebView wkContentView]):
3033         * TestWebKitAPI/ios/UIKitSPI.h:
3034         Share the WKContentView finding code between tests.
3035
3036 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
3037
3038         [iOS WK2] Turn on async overflow scrolling by default
3039         https://bugs.webkit.org/show_bug.cgi?id=196011
3040         rdar://problem/48453859
3041
3042         Reviewed by Antti Koivisto.
3043         
3044         Explicitly turn off the async overflow scrolling internal feature for tests by default,
3045         since so many basic layout tests have different results when compositing is triggered for
3046         overflow.
3047         
3048         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
3049
3050         * WebKitTestRunner/TestController.cpp:
3051         (WTR::TestController::resetPreferencesToConsistentValues):
3052
3053 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3054
3055         [ews-build] Retry API test in case of failures
3056         https://bugs.webkit.org/show_bug.cgi?id=196004
3057
3058         Reviewed by Lucas Forschler.
3059
3060         * BuildSlaveSupport/ews-build/steps.py:
3061         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
3062         (CompileWebKitToT.doStepIf): Ditto.
3063         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
3064         (ReRunAPITests): Re-run API tests.
3065         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
3066         (RunAPITestsWithoutPatch): Run API tests without patch.
3067         (RunAPITestsWithoutPatch.doStepIf):
3068         (RunAPITestsWithoutPatch.hideStepIf):
3069         (RunAPITestsWithoutPatch.evaluateCommand):
3070         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
3071         (AnalyzeAPITestsResults.start):
3072         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
3073         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
3074         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
3075         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
3076
3077 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3078
3079         [ews-build] Update queues configurations
3080         https://bugs.webkit.org/show_bug.cgi?id=196074
3081
3082         Reviewed by Dewei Zhu.
3083
3084         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
3085         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
3086
3087 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3088
3089         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
3090         https://bugs.webkit.org/show_bug.cgi?id=195680
3091         <rdar://problem/48903534>
3092
3093         Unreviewed infrastructure fix.
3094
3095         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3096         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
3097
3098 2019-03-21  Andy Estes  <aestes@apple.com>
3099
3100         [iOS] Apple Pay should be available in documents with no user agent scripts
3101         https://bugs.webkit.org/show_bug.cgi?id=196061
3102         <rdar://problem/48649391>
3103
3104         Reviewed by Brady Eidson.
3105
3106         Added API tests and related infrastructure.
3107
3108         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3109         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
3110         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
3111         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
3112         (TestWebKitAPI::TEST):
3113         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
3114         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
3115         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
3116         * TestWebKitAPI/cocoa/TestProtocol.mm:
3117         (-[TestProtocol startLoading]):
3118         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
3119         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
3120         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
3121         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
3122
3123 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
3124
3125         REGRESSSION (r243297): webkitpy tests broken
3126         https://bugs.webkit.org/show_bug.cgi?id=196108
3127
3128         Reviewed by Aakash Jain.
3129
3130         r243297 updated contributors.json, which broke a few unit tests.
3131
3132         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3133         (IRCCommandTest.test_whois):
3134         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
3135
3136 2019-03-21  Chris Dumez  <cdumez@apple.com>
3137
3138         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
3139         https://bugs.webkit.org/show_bug.cgi?id=196041
3140         <rdar://problem/49083230>
3141
3142         Reviewed by Alex Christensen.
3143
3144         Add API test coverage.
3145
3146         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
3147         (TEST):
3148
3149 2019-03-21  Alex Christensen  <achristensen@webkit.org>
3150
3151         Add SPI to inform applications of WKContentRuleList actions
3152         https://bugs.webkit.org/show_bug.cgi?id=195965
3153         <rdar://problem/42664365>
3154
3155         Reviewed by Geoff Garen.
3156
3157         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3158         (TestWebKitAPI::allActionsForResourceLoad):
3159         (TestWebKitAPI::testRequest):
3160         (TestWebKitAPI::TEST_F):
3161         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
3162         (Notification::description):
3163         (Notification::operator== const):
3164         (toVector):
3165         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
3166         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
3167         (makeContentRuleList):
3168         (TEST):
3169         (makeWarnContentRuleList): Deleted.
3170
3171 2019-03-21  Timothy Hatcher  <timothy@apple.com>
3172
3173         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
3174         https://bugs.webkit.org/show_bug.cgi?id=196088
3175
3176         Reviewed by Brian Burg.
3177
3178         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
3179         Support checks when only one platform is specified. Also deprecate macosx() and
3180         force the use of macos() instead.
3181
3182         * Scripts/webkitpy/style/checkers/cpp.py:
3183         (check_min_versions_of_wk_api_available):
3184         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3185         (WebKitStyleTest.test_min_versions_of_wk_api_available):
3186
3187 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
3188
3189         Update status inactive committers' status to 'contributor'.
3190
3191         * Scripts/webkitpy/common/config/contributors.json:
3192
3193 2019-03-21  Xan Lopez  <xan@igalia.com>
3194
3195         [JSC][x86] Drop support for x87 floating point
3196         https://bugs.webkit.org/show_bug.cgi?id=194853
3197
3198         Reviewed by Don Olmstead.
3199
3200         Force SSE2 on x86/32bit builds.
3201
3202         * Scripts/webkitdirs.pm:
3203         (generateBuildSystemFromCMakeProject):
3204
3205 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3206
3207         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
3208         https://bugs.webkit.org/show_bug.cgi?id=196073
3209
3210         Reviewed by Michael Catanzaro.
3211
3212         Add test cases to check functions and constructors with no arguments but receiving user data.
3213
3214         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3215         (checkUserData):
3216         (testJSCFunction):
3217         (fooCreateWithUserData):
3218         (testJSCClass):
3219
3220 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3221
3222         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
3223
3224         Add g_assert_cmpfloat_with_epsilon macro if not defined.
3225
3226         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3227
3228 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3229
3230         [GTK][WPE] Add API to provide geolocation information
3231         https://bugs.webkit.org/show_bug.cgi?id=195940
3232
3233         Reviewed by Michael Catanzaro.
3234
3235         Add a new test to check the new API.
3236
3237         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
3238         (testGeolocationManagerCurrentPosition):
3239         (testGeolocationManagerWatchPosition):
3240         (beforeAll):
3241         (afterAll):
3242         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3243         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
3244         (beforeAll): Ditto.
3245         * TestWebKitAPI/glib/CMakeLists.txt:
3246
3247 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3248
3249         [GLib] Returning G_TYPE_OBJECT from a method does not work
3250         https://bugs.webkit.org/show_bug.cgi?id=195574
3251
3252         Reviewed by Michael Catanzaro.
3253
3254         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
3255
3256         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3257         (getGFile):
3258         (getParent):
3259         (createGString):
3260         (getGString):
3261         (getGStringCopyWillRaise):
3262         (getGStringCopy):
3263         (getGStringStr):
3264         (getGStringLen):
3265         (freeGString):
3266         (testJSCClass):
3267
3268 2019-03-20  Saam Barati  <sbarati@apple.com>
3269
3270         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
3271         https://bugs.webkit.org/show_bug.cgi?id=195721
3272
3273         Reviewed by Filip Pizlo.
3274
3275         * Scripts/run-javascriptcore-tests:
3276
3277 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
3278
3279         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
3280         https://bugs.webkit.org/show_bug.cgi?id=196049
3281
3282         Reviewed by Tim Horton.
3283
3284         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
3285         overflow scrolling in general, so rename it.
3286
3287         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3288
3289 2019-03-20  Daniel Bates  <dabates@apple.com>
3290
3291         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
3292         https://bugs.webkit.org/show_bug.cgi?id=196031
3293         <rdar://problem/49078172>
3294
3295         Reviewed by Tim Horton.
3296
3297         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
3298         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
3299         same code path used when the Done button is pressed to dismiss the <select> picker.
3300
3301         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
3302         (TestWebKitAPI::TEST):
3303
3304 2019-03-20  Chris Dumez  <cdumez@apple.com>
3305
3306         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
3307         https://bugs.webkit.org/show_bug.cgi?id=196029
3308         <rdar://problem/48954651>
3309
3310         Reviewed by Tim Horton.
3311
3312         Add API test coverage.
3313
3314         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3315
3316 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
3317
3318         [ews-build] Improve failure summary string for ApplyPatch step
3319         https://bugs.webkit.org/show_bug.cgi?id=195995
3320
3321         Reviewed by Alexey Proskuryakov.
3322
3323         * BuildSlaveSupport/ews-build/steps.py:
3324         (ApplyPatch.getResultSummary): Override getResultSummary.
3325
3326 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
3327
3328         AX: Implement support for new meter ARIA role
3329         https://bugs.webkit.org/show_bug.cgi?id=195966
3330
3331         Reviewed by Chris Fleizach.
3332
3333         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
3334         to AXLevelIndicator.
3335
3336         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3337
3338 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
3339
3340         [WebAuthN] Implement FIDO AppID extension
3341         https://bugs.webkit.org/show_bug.cgi?id=143491
3342         <rdar://problem/48298273>
3343
3344         Reviewed by Brent Fulgham.
3345
3346         Add a test that covers the new flag of convertToU2fSignCommand.
3347
3348         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
3349         (TestWebKitAPI::TEST):
3350         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
3351         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
3352         (TestWebKitAPI::TEST):
3353
3354 2019-03-19  Keith Rollin  <krollin@apple.com>
3355
3356         Add support for more platforms to generate-xcfilelists
3357         https://bugs.webkit.org/show_bug.cgi?id=195977
3358
3359         Reviewed by Alexey Proskuryakov.
3360
3361         generate-xcfilelists incorrectly complains when involved with building
3362         WebKit for iphonesimulator:
3363
3364             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
3365             …
3366             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
3367
3368         Address this by teaching generate-xcfilelists about more platforms.
3369
3370         * Scripts/generate-xcfilelists:
3371
3372 2019-03-19  John Wilander  <wilander@apple.com>
3373
3374         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
3375         https://bugs.webkit.org/show_bug.cgi?id=195923
3376         <rdar://problem/49001272>
3377
3378         Reviewed by Alex Christensen.
3379
3380         This patch does the following to the TestRunner:
3381         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
3382         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
3383         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
3384
3385         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3386         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3387         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
3388         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3389         * WebKitTestRunner/TestController.cpp:
3390         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
3391         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
3392         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
3393         * WebKitTestRunner/TestController.h:
3394         * WebKitTestRunner/TestInvocation.cpp:
3395         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3396
3397 2019-03-19  Christopher Reid  <chris.reid@sony.com>
3398
3399         [CMake] Support more clang and gcc sanitizers
3400         https://bugs.webkit.org/show_bug.cgi?id=195956
3401
3402         Reviewed by Michael Catanzaro.
3403
3404         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
3405
3406 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
3407
3408         [ews-build] Improve summary for PrintConfiguration step
3409         https://bugs.webkit.org/show_bug.cgi?id=195945
3410
3411         Reviewed by Lucas Forschler.
3412
3413         * BuildSlaveSupport/ews-build/steps.py:
3414         (PrintConfiguration.getResultSummary): Override getResultSummary.
3415
3416 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
3417
3418         [ews-build] Improve summary for CheckOutSource step
3419         https://bugs.webkit.org/show_bug.cgi?id=195963
3420
3421         Reviewed by Lucas Forschler.
3422
3423         * BuildSlaveSupport/ews-build/steps.py:
3424         (CheckOutSource.getResultSummary):
3425
3426 2019-03-19  Daniel Bates  <dabates@apple.com>
3427
3428         [iOS] Focus not preserved when switching between tabs
3429         https://bugs.webkit.org/show_bug.cgi?id=195820
3430         <rdar://problem/43614450>
3431
3432         Reviewed by Brent Fulgham.
3433
3434         Add tests to ensure that we restore focus when resigning and becoming first responder.
3435
3436         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3437         (TestWebKitAPI::TEST):
3438
3439 2019-03-19  Alex Christensen  <achristensen@webkit.org>
3440
3441         Make WTFLogChannelState and WTFLogLevel enum classes
3442         https://bugs.webkit.org/show_bug.cgi?id=195904
3443
3444         Reviewed by Eric Carlson.
3445
3446         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3447         (TestWebKitAPI::TEST_F):
3448
3449 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3450
3451         [GStreamer][EME] Backported mssdemux protection data crash fix
3452         https://bugs.webkit.org/show_bug.cgi?id=195918
3453
3454         Reviewed by Philippe Normand.
3455
3456         * gstreamer/jhbuild.modules:
3457         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
3458
3459 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3460
3461         Unreviewed, rolling out r243132.
3462
3463         Broke GTK build
3464
3465         Reverted changeset:
3466
3467         "Make WTFLogChannelState and WTFLogLevel enum classes"
3468         https://bugs.webkit.org/show_bug.cgi?id=195904
3469         https://trac.webkit.org/changeset/243132
3470
3471 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
3472
3473         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
3474
3475         * Scripts/webkitdirs.pm:
3476         (builtDylibPathForName): Adjust the shared library name that's changed
3477         with the API version bump in r243073.
3478
3479 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3480
3481         Make WTFLogChannelState and WTFLogLevel enum classes
3482         https://bugs.webkit.org/show_bug.cgi?id=195904
3483
3484         Reviewed by Eric Carlson.
3485
3486         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3487         (TestWebKitAPI::TEST_F):
3488
3489 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3490
3491         Disable flaky test added in r2431100
3492         https://webkit.org/b/195785
3493
3494         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3495         (TestWebKitAPI::TEST):
3496         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
3497
3498 2019-03-18  Timothy Hatcher  <timothy@apple.com>
3499
3500         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
3501         https://bugs.webkit.org/show_bug.cgi?id=195916
3502
3503         Reviewed by Tim Horton.
3504
3505         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3506         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
3507
3508 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
3509
3510         Add a secondary e-mail address for Fujii Hironori to make tools happier.
3511
3512         * Scripts/webkitpy/common/config/contributors.json:
3513
3514 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3515
3516         Implement DownloadMonitor to prevent long-running slow downloads from background apps
3517         https://bugs.webkit.org/show_bug.cgi?id=195785
3518
3519         Reviewed by Geoffrey Garen.
3520
3521         * TestWebKitAPI/TCPServer.cpp: Added.
3522         (TestWebKitAPI::TCPServer::TCPServer):
3523         (TestWebKitAPI::TCPServer::~TCPServer):
3524         (TestWebKitAPI::TCPServer::socketBindListen):
3525         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
3526         * TestWebKitAPI/TCPServer.h: Added.
3527         (TestWebKitAPI::TCPServer::port const):
3528         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3529         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3530         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
3531         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
3532         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3533         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
3534         (TestWebKitAPI::respondSlowly):
3535         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
3536         (TestWebKitAPI::downloadAtRate):
3537         (TestWebKitAPI::TEST):
3538
3539 2019-03-18  Saam Barati  <sbarati@apple.com>
3540
3541         Add a plan file for JetStream 2
3542         https://bugs.webkit.org/show_bug.cgi?id=190734
3543
3544         Reviewed by Mark Lam.
3545
3546         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
3547
3548 2019-03-18  Chris Dumez  <cdumez@apple.com>
3549
3550         Delay WebProcess launch until a load is triggered in a Web view
3551         https://bugs.webkit.org/show_bug.cgi?id=195758
3552         <rdar://problem/48126013>
3553
3554         Reviewed by Geoff Garen.
3555
3556         Add API test coverage. Also update some existing API tests to not expect
3557         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
3558
3559         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
3560         (TestWebKitAPI::TEST):
3561         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
3562         (TestWebKitAPI::TEST):
3563         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3564         (TEST):
3565         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3566         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3567         (TEST):
3568         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3569         (TEST):
3570         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
3571
3572 2019-03-18  Xan Lopez  <xan@igalia.com>
3573
3574         [CMake] Prevent potential warning when determining $architecture
3575         https://bugs.webkit.org/show_bug.cgi?id=195891
3576
3577         Reviewed by Michael Catanzaro.
3578
3579         It's possible for generateBuildSystemForCMakeProject to be called
3580         before determineArchitecture() is ever called. This will make the
3581         first eq check with $architecture to be bogus (and print a
3582         warning). Change that to an eq check with architecture(), which
3583         implicitly calls determineArchitecture() if needed, and change all
3584         the other similar cases in the method in the same way to prevent
3585         future bugs like this one.
3586
3587         * Scripts/webkitdirs.pm:
3588         (generateBuildSystemFromCMakeProject):
3589
3590 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3591
3592         [WPE] Tarballs generated with “make dist” cannot build documentation
3593         https://bugs.webkit.org/show_bug.cgi?id=195885
3594
3595         Reviewed by Carlos Garcia Campos.
3596
3597         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
3598
3599 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3600
3601         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
3602         https://bugs.webkit.org/show_bug.cgi?id=195883
3603
3604         Reviewed by Carlos Garcia Campos.
3605
3606         * gtkdoc/gtkdoc.py:
3607         (GTKDoc._run_command): When commands fail to run, include the full command line for
3608         the program invocation and the output it has generated on the standard error stream.
3609
3610 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3611
3612         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
3613         https://bugs.webkit.org/show_bug.cgi?id=195786
3614
3615         Reviewed by Philippe Normand.
3616
3617         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
3618         * wpe/jhbuild.modules: Ditto.
3619
3620 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
3621
3622         [ews-build] Don't run clean builds on EWS builders
3623         https://bugs.webkit.org/show_bug.cgi?id=195851
3624
3625         Reviewed by Geoffrey Garen.
3626
3627         * BuildSlaveSupport/ews-build/factories.py:
3628
3629 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
3630
3631         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
3632         https://bugs.webkit.org/show_bug.cgi?id=195849
3633
3634         Reviewed by Chris Dumez.
3635
3636         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
3637
3638         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3639         (runWebsiteDataStoreCustomPaths):
3640
3641 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
3642
3643         webkitpy: Upload test results
3644         https://bugs.webkit.org/show_bug.cgi?id=195755
3645         <rdar://problem/48896182>
3646
3647         Reviewed by Aakash Jain.
3648
3649         Establish a new format for uploading results that is not tied to layout tests, apply
3650         that format to webkitpy tests.
3651
3652         * Scripts/webkitpy/common/checkout/scm/git.py:
3653         (Git.native_branch): Return what branch the current checkout is on.
3654         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3655         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3656         * Scripts/webkitpy/common/checkout/scm/svn.py:
3657         (SVN.native_branch): Ditto.
3658         * Scripts/webkitpy/common/system/platforminfo.py:
3659         (PlatformInfo.build_version): Return a build version for Mac.
3660         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3661         (MockPlatformInfo.__init__):
3662         (MockPlatformInfo.build_version):
3663         * Scripts/webkitpy/results: Added.
3664         * Scripts/webkitpy/results/__init__.py: Added.
3665         * Scripts/webkitpy/results/options.py:&nb