db72aaa87f872a7088e37c6e275b08c099b0ab72
[WebKit-https.git] / Tools / ChangeLog
1 2019-05-08  Adrian Perez de Castro  <aperez@igalia.com>
2
3         [WPE] Update dependencies to use libwpe + WPEBackend-fdo 1.3.0
4         https://bugs.webkit.org/show_bug.cgi?id=197697
5
6         Reviewed by Žan Doberšek.
7
8         * flatpak/org.webkit.WPEModules.yaml: Bump version and update checksums.
9         * wpe/jhbuild.modules: Ditto.
10
11 2019-05-08  Don Olmstead  <don.olmstead@sony.com>
12
13         Update ANGLE
14         https://bugs.webkit.org/show_bug.cgi?id=197676
15
16         Reviewed by Alex Christensen.
17
18         * TestWebKitAPI/PlatformWin.cmake:
19         Remove unnecessary library linkage.
20
21 2019-05-08  Stephan Szabo  <stephan.szabo@sony.com> and Fujii Hironori  <Hironori.Fujii@sony.com>
22
23         [Win] build-webkit should be ready for Visual Studio 2019
24         https://bugs.webkit.org/show_bug.cgi?id=196622
25
26         Reviewed by Ross Kirsling.
27
28         1. Accommodated to the new msbuild.exe location of VS 2019.
29         2. Removed the hard coded "Visual Studio 15" generator.
30
31         build-webkit is going to choose a Visual Studio generator version
32         matching with the latest installed VS. If you invoke vcvars.bat
33         before build-webkit, it chooses the corresponding Visual Studio
34         generator version by cheking 'VisualStudioVersion' env var which
35         is set by vcvars.bat.
36
37         * Scripts/webkitdirs.pm: Renamed $vcBuildPath to $msBuildPath. Removed $msBuildInstallDir.
38         (msBuildPath): When looking for MSBuild, look in
39         "MSBuild\Current\bin" (the new expected location) and fallback
40         to "MSBuild\15.0\bin" if we can't find an MSBuild.exe in the
41         first location.
42         (msBuildInstallDir): Renamed to msBuildPath.
43         (generateBuildSystemFromCMakeProject): Use -A switch to specify x64.
44         Add -G "Visual Studio " switch if a env var 'VisualStudioVersion'
45
46 2019-05-08  Don Olmstead  <don.olmstead@sony.com>
47
48         [PlayStation] Update port options
49         https://bugs.webkit.org/show_bug.cgi?id=197723
50
51         Reviewed by Ross Kirsling.
52
53         ICU headers were missing from TestWTF.
54
55         * TestWebKitAPI/PlatformPlayStation.cmake:
56
57 2019-05-08  Alex Christensen  <achristensen@webkit.org>
58
59         Don't crash when DOMNode.addEventListener:listener:useCapture: is called with a nil listener
60         https://bugs.webkit.org/show_bug.cgi?id=197712
61         <rdar://problem/50429770>
62
63         Reviewed by Tim Horton.
64
65         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm:
66         (TestWebKitAPI::TEST):
67
68 2019-05-08  Jonathan Bedard  <jbedard@apple.com>
69
70         Change my status to be a WebKit reviewer.
71
72         * Scripts/webkitpy/common/config/contributors.json:
73
74 2019-05-08  Ryan Haddad  <ryanhaddad@apple.com>
75
76         Unreviewed, rolling out r244952.
77
78         Caused inspector to appear blank.
79
80         Reverted changeset:
81
82         "Web Inspector: Provide UIString descriptions to improve
83         localizations"
84         https://bugs.webkit.org/show_bug.cgi?id=195132
85         https://trac.webkit.org/changeset/244952
86
87 2019-05-08  Wenson Hsieh  <wenson_hsieh@apple.com>
88
89         TestRunnerWKWebView's menu callbacks should be cleared upon UI script completion
90         https://bugs.webkit.org/show_bug.cgi?id=197685
91
92         Reviewed by Alex Christensen.
93
94         Fixes a bug in the test runner wherein didShowMenuCallback and didHideMenuCallback are not reset upon UI script
95         completion. See LayoutTests/ChangeLog for more details.
96
97         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
98         (WTR::UIScriptController::platformClearAllCallbacks):
99
100 2019-05-07  Oriol Brufau  <obrufau@igalia.com>
101
102         Unreviewed. Add myself as a committer.
103
104         * Scripts/webkitpy/common/config/contributors.json:
105
106 2019-05-07  Ryan Haddad  <ryanhaddad@apple.com>
107
108         Unreviewed, rolling out r245038.
109
110         Breaks internal builds.
111
112         Reverted changeset:
113
114         "Add SPI to set a list of hosts to which to send custom header
115         fields cross-origin"
116         https://bugs.webkit.org/show_bug.cgi?id=197397
117         https://trac.webkit.org/changeset/245038
118
119 2019-05-07  Joonghun Park  <pjh0718@gmail.com>
120
121         Unreviewed. Add myself as a committer.
122
123         * Scripts/webkitpy/common/config/contributors.json:
124
125 2019-05-07  Eric Carlson  <eric.carlson@apple.com>
126
127         Define media buffering policy
128         https://bugs.webkit.org/show_bug.cgi?id=196979
129         <rdar://problem/28383861>
130
131         Reviewed by Jer Noble.
132
133         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
134         * TestWebKitAPI/Tests/WebKitCocoa/MediaBufferingPolicy.mm: Added.
135         (waitUntilBufferingPolicyIsEqualTo):
136         (TEST):
137
138 2019-05-07  Alex Christensen  <achristensen@webkit.org>
139
140         Add SPI to set a list of hosts to which to send custom header fields cross-origin
141         https://bugs.webkit.org/show_bug.cgi?id=197397
142
143         Reviewed by Geoff Garen.
144
145         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
146         (TEST):
147         (expectLegacyHeaders):
148         (expectHeaders):
149         (-[CustomHeaderFieldsDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
150         (-[CustomHeaderFieldsDelegate webView:startURLSchemeTask:]):
151         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
152
153 2019-05-07  Keith Rollin  <krollin@apple.com>
154
155         Add option to build-webkit to control whether or not XCBuild is used
156         https://bugs.webkit.org/show_bug.cgi?id=197668
157         <rdar://problem/50549728>
158
159         Reviewed by Tim Horton.
160
161         Add --[no-]xcbuild to build-webkit to force the use of XCBuild or not.
162         Also update build-webkit and the makefiles with the foundation for
163         automatically using XCBuild when the conditions allow it. This latter
164         facility is currently turned off until Xcode fully supports building
165         WebKit with XCBuild.
166
167         * Scripts/build-webkit:
168         * Scripts/webkitdirs.pm:
169         (XcodeOptions):
170         (canUseXCBuild):
171
172 2019-05-07  Andy Estes  <aestes@apple.com>
173
174         run-bindings-tests should test global scope constructor generation
175         https://bugs.webkit.org/show_bug.cgi?id=197669
176
177         Reviewed by Alex Christensen.
178
179         * Scripts/webkitpy/bindings/main.py:
180         Updated to specify --testGlobalContextName and --testGlobalScopeConstructorsFile when
181         invoking preprocess-idls.pl.
182
183 2019-05-07  Youenn Fablet  <youenn@apple.com>
184
185         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageDefaultDirectories
186         https://bugs.webkit.org/show_bug.cgi?id=195997
187         <rdar://problem/50509884>
188
189         Reviewed by Chris Dumez.
190
191         Spin test until successful.
192
193         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
194
195 2019-05-07  Adrian Perez de Castro  <aperez@igalia.com>
196
197         [Flatpak] webkit-build fails due to missing GTK2 in build environment
198         https://bugs.webkit.org/show_bug.cgi?id=197352
199
200         Reviewed by Philippe Normand.
201
202         The Flatpak runtimes do not include GTK 2.x anymore, which means that we need
203         to build it ourselves on top in order to be able to build the GTK 2.x plugin
204         process.
205
206         * flatpak/org.webkit.GTK.yaml: Add gtk2 package.
207
208 2019-05-07  Wenson Hsieh  <wenson_hsieh@apple.com>
209
210         [macOS] Avoid crashing the UI process when writing empty data to the pasteboard
211         https://bugs.webkit.org/show_bug.cgi?id=197644
212         <rdar://problem/50526364>
213
214         Reviewed by Tim Horton.
215
216         Add a new API test to exercise a possible scenario where we may crash while writing data to the pasteboard.
217
218         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegate.mm:
219         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
220         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
221         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:pasteboardDataForRange:]):
222
223 2019-05-07  Carlos Garcia Campos  <cgarcia@igalia.com>
224
225         [GTK][WPE] MiniBrowser: load about:blank for new web views in automation mode
226         https://bugs.webkit.org/show_bug.cgi?id=197651
227
228         Reviewed by Žan Doberšek.
229
230         This is required since the process creation was delayed until something is loaded in the view.
231
232         * MiniBrowser/gtk/BrowserWindow.c:
233         (browser_window_get_or_create_web_view_for_automation):
234         * MiniBrowser/wpe/main.cpp:
235         (main):
236
237 2019-05-06  Tim Horton  <timothy_horton@apple.com>
238
239         _overrideViewportWithArguments does not work when called before loading
240         https://bugs.webkit.org/show_bug.cgi?id=197638
241         <rdar://problem/50505111>
242
243         Reviewed by Wenson Hsieh.
244
245         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
246         (TEST):
247
248 2019-05-04  Per Arne Vollan  <pvollan@apple.com>
249
250         -[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
251         https://bugs.webkit.org/show_bug.cgi?id=197510
252
253         Reviewed by Alex Christensen.
254
255         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
256         (TestWebKitAPI::TEST):
257
258 2019-05-06  Keith Rollin  <krollin@apple.com>
259
260         Temporarily disable generate-xcfilelists
261         https://bugs.webkit.org/show_bug.cgi?id=197619
262         <rdar://problem/50507392>
263
264         Reviewed by Alex Christensen.
265
266         We need to perform a significant update to the generate-xcfilelist
267         scripts. This work involves coordinated work with another facility. If
268         the work does not occur in tandem, the build will be broken. To avoid
269         this, disable the invoking of the scripts during the transition. The
270         checking will be restored once the new scripts are in place.
271
272         * DumpRenderTree/Scripts/check-xcfilelists.sh:
273         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
274
275 2019-05-04  Alex Christensen  <achristensen@webkit.org>
276
277         Revert r244953 and r244954 because they broke internal builds.
278         https://bugs.webkit.org/show_bug.cgi?id=197534
279
280         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
281         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
282         * DumpRenderTree/mac/DumpRenderTree.mm:
283         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
284         * DumpRenderTree/mac/TestRunnerMac.mm:
285         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
286         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
287         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
288         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
289         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
290         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
291         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
292         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
293         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
294         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
295         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
296         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
297         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
298         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
299         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
300         * TestWebKitAPI/cocoa/TestWKWebView.mm:
301         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
302         * TestWebKitAPI/ios/UIKitSPI.h: Added.
303         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
304         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
305         * WebKitTestRunner/ios/HIDEventGenerator.h:
306         * WebKitTestRunner/ios/HIDEventGenerator.mm:
307         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
308         * WebKitTestRunner/ios/TestControllerIOS.mm:
309         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
310         * WebKitTestRunner/ios/mainIOS.mm:
311
312 2019-05-04  Alex Christensen  <achristensen@webkit.org>
313
314         Merge the three UIKitSPI.h files into a single one in PAL
315         https://bugs.webkit.org/show_bug.cgi?id=197534
316
317         Reviewed by Darin Adler.
318
319         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
320         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
321         * DumpRenderTree/mac/DumpRenderTree.mm:
322         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
323         * DumpRenderTree/mac/TestRunnerMac.mm:
324         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
325         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
326         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
327         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
328         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
329         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
330         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
331         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
332         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
333         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
334         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
335         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
336         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
337         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
338         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
339         * TestWebKitAPI/cocoa/TestWKWebView.mm:
340         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
341         * TestWebKitAPI/ios/UIKitSPI.h: Removed.
342         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
343         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
344         * WebKitTestRunner/ios/HIDEventGenerator.h:
345         * WebKitTestRunner/ios/HIDEventGenerator.mm:
346         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
347         * WebKitTestRunner/ios/TestControllerIOS.mm:
348         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
349         * WebKitTestRunner/ios/mainIOS.mm:
350
351 2019-05-04  Nikita Vasilyev  <nvasilyev@apple.com>
352
353         Web Inspector: Provide UIString descriptions to improve localizations
354         https://bugs.webkit.org/show_bug.cgi?id=195132
355         <rdar://problem/48457817>
356
357         Reviewed by Devin Rousso.
358
359         Allow WI.UIString to take:
360         - WI.UIString(string, key, comment)
361         - WI.UIString(string, comment)
362         - WI.UIString(string)
363
364         * Scripts/extract-localizable-js-strings:
365
366 2019-05-03  Wenson Hsieh  <wenson_hsieh@apple.com>
367
368         REGRESSION (r244897): Caret may appear wider than normal after zooming to focus an editable element
369         https://bugs.webkit.org/show_bug.cgi?id=197579
370
371         Reviewed by Tim Horton.
372
373         Fixes a couple of flaky layout tests (ModifyInputAssistantItemBarButtonGroups and
374         OverrideInputAssistantItemBarButtonGroups) by programmatically blurring focused elements and waiting for the
375         input session to change, rather than relying on -resignFirstResponder and -waitForNextPresentationUpdate to
376         ensure that the the focused element has been blurred.
377
378         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
379
380 2019-05-02  Alexey Proskuryakov  <ap@apple.com>
381
382         Add a tool to block spammer accounts
383         https://bugs.webkit.org/show_bug.cgi?id=197537
384
385         Reviewed by Darin Adler.
386
387         Usage: block-spammers email1 email2 ...
388
389         The tool finds and hides all bugs and comments from this account. Before any work
390         is done, these bugs and comments are displayed for confirmation.
391
392         * Scripts/block-spammers: Added.
393         (get_bugzilla_token):
394         (invalidate_bugzilla_token):
395         (get_user_info):
396         (get_user_info_self):
397         (can_use_this_tool):
398         (disable_user):
399         (get_bugs_created_by_user):
400         (get_bugs_commented_on_by_user):
401         (get_comments):
402         (hide_bug):
403         (hide_comments):
404         (ask_yes_no):
405         (sanitized_string):
406         (main):
407
408 2019-05-03  Jonathan Bedard  <jbedard@apple.com>
409
410         run-apit-tests: Add --iterations and --repeat-each
411         https://bugs.webkit.org/show_bug.cgi?id=197563
412
413         Reviewed by Aakash Jain.
414
415         * Scripts/webkitpy/api_tests/manager.py:
416         (Manager.run): Add --iterations and --repeat-each/
417         * Scripts/webkitpy/api_tests/run_api_tests.py:
418         (parse_args): Duplicate the test list based on --iterations and --repeat-each.
419
420 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
421
422         New EWS: Clicking on white bubble navigates to page with only bubbles
423         https://bugs.webkit.org/show_bug.cgi?id=197520
424
425         Reviewed by Lucas Forschler.
426
427         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Disable clicking if bubble doesn't have any url.
428
429 2019-05-03  Daniel Bates  <dabates@apple.com>
430
431         [lldb-webkit] Support adding pretty-printing for qualified types
432         https://bugs.webkit.org/show_bug.cgi?id=197518
433
434         Reviewed by Darin Adler.
435
436         Remove all "::"s from the name of the specified type when computing the name for the Python classes
437         that will provide summary and synthetic details as LLDB is not happy about registering such classes
438         when they contain :: in their name.
439
440         * lldb/lldb_webkit.py:
441         (addSummaryAndSyntheticFormattersForRawBitmaskType):
442
443 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
444
445         New EWS: patches on recently added queues listed as #1 for older bugs
446         https://bugs.webkit.org/show_bug.cgi?id=197496
447
448         Reviewed by Lucas Forschler.
449
450         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
451         (StatusBubble._build_bubble):
452         (StatusBubble._queue_position):
453
454 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
455
456         webkit-patch --no-review upload does not submit patch to New EWS
457         https://bugs.webkit.org/show_bug.cgi?id=197519
458         <rdar://problem/50424887>
459
460         Reviewed by Lucas Forschler.
461
462         * Scripts/webkitpy/tool/steps/submittoews.py:
463         (SubmitToEWS.run): Submit to both old and new EWS.
464         * Scripts/webkitpy/common/config/urls.py: Added url for new EWS server.
465         * Scripts/webkitpy/common/net/ewsserver.py: Added.
466         (EWSServer._server_url): Method to return server url.
467         (EWSServer._post_patch_to_ews): Method to post patch to ews.
468         (EWSServer.submit_to_ews): Method to submit the patch to ews using NetworkTransaction.
469         * Scripts/webkitpy/common/net/ewsserver_mock.py: Added Mock EWS Server.
470         * Scripts/webkitpy/common/net/ewsserver_unittest.py: Added unit-test for EWS Server.
471         * Scripts/webkitpy/common/net/statusserver_mock.py:
472         (MockStatusServer.submit_to_ews): Updated the log text.
473         * Scripts/webkitpy/tool/commands/queues_unittest.py: Updated unit-tests.
474         * Scripts/webkitpy/tool/commands/upload_unittest.py: Ditto.
475         * Scripts/webkitpy/tool/main.py:
476         (WebKitPatch.__init__): Initialize ews_server. 
477         * Scripts/webkitpy/tool/mocktool.py:
478         (MockTool.__init__): Ditto.
479
480 2019-05-03  Chris Dumez  <cdumez@apple.com>
481
482         ASSERTION FAILED: [weakThis->m_view window] == weakThis->m_targetWindowForMovePreparation
483         https://bugs.webkit.org/show_bug.cgi?id=197574
484         <rdar://problem/50453181>
485
486         Reviewed by Tim Horton.
487
488         Add API test coverage.
489
490         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
491         (TEST):
492
493 2019-05-03  Yusuke Suzuki  <ysuzuki@apple.com>
494
495         [JSC] Generator CodeBlock generation should be idempotent
496         https://bugs.webkit.org/show_bug.cgi?id=197552
497
498         Reviewed by Keith Miller.
499
500         * Scripts/run-javascriptcore-tests:
501         (runJSCStressTests):
502         * Scripts/run-jsc-stress-tests:
503
504 2019-05-03  Commit Queue  <commit-queue@webkit.org>
505
506         Unreviewed, rolling out r244881.
507         https://bugs.webkit.org/show_bug.cgi?id=197559
508
509         Breaks compilation of jsconly on linux, breaking compilation
510         for jsc-i386-ews, jsc-mips-ews and jsc-armv7-ews (Requested by
511         guijemont on #webkit).
512
513         Reverted changeset:
514
515         "[CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into
516         WEBKIT_COPY_FILES"
517         https://bugs.webkit.org/show_bug.cgi?id=197174
518         https://trac.webkit.org/changeset/244881
519
520 2019-05-03  Zan Dobersek  <zdobersek@igalia.com>
521
522         Unreviewed WPE build fix after r244898.
523
524         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
525         (WTR::TestController::abortModal): Add the missing (no-op) definition.
526
527 2019-05-02  Alex Christensen  <achristensen@webkit.org>
528
529         Mark U+01C0 as a homograph of U+006C
530         https://bugs.webkit.org/show_bug.cgi?id=197526
531         <rdar://problem/50301904>
532
533         Reviewed by Tim Horton.
534
535         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
536         (TestWebKitAPI::TEST):
537
538 2019-05-02  Chris Dumez  <cdumez@apple.com>
539
540         Add test coverage for <rdar://problem/49731231>
541         https://bugs.webkit.org/show_bug.cgi?id=196730
542         <rdar://problem/49731231>
543
544         Reviewed by Ryosuke Niwa.
545
546         Add support for testRunner.abortModal() in macOS's WebKitTestRunner in order
547         to match DumpRenderTree.
548
549         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
550         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
551         (WTR::TestRunner::abortModal):
552         * WebKitTestRunner/InjectedBundle/TestRunner.h:
553         * WebKitTestRunner/TestController.cpp:
554         (WTR::TestController::runModal):
555         * WebKitTestRunner/TestController.h:
556         * WebKitTestRunner/TestInvocation.cpp:
557         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
558         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
559         (WTR::TestController::abortModal):
560         * WebKitTestRunner/ios/TestControllerIOS.mm:
561         (WTR::TestController::abortModal):
562         * WebKitTestRunner/mac/TestControllerMac.mm:
563         (WTR::TestController::abortModal):
564         * WebKitTestRunner/win/TestControllerWin.cpp:
565         (WTR::TestController::abortModal):
566
567 2019-05-02  Christopher Reid  <chris.reid@sony.com>
568
569         [CMake] Add support for LTO builds
570         https://bugs.webkit.org/show_bug.cgi?id=188986
571
572         Reviewed by Don Olmstead.
573
574         Add support to configure --lto-mode with cmake builds.
575
576         * Scripts/build-webkit:
577         * Scripts/webkitdirs.pm:
578         (generateBuildSystemFromCMakeProject):
579
580 2019-05-02  John Wilander  <wilander@apple.com>
581
582         Make both filterForRegistrableDomains() in WebKit::NetworkProcess use WebCore::RegistrableDomain::uncheckedCreateFromHost()
583         https://bugs.webkit.org/show_bug.cgi?id=197521
584         <rdar://problem/49651503>
585
586         Reviewed by Brent Fulgham.
587
588         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
589         (TestWebKitAPI::TEST):
590            Added a test for host strings with leading dots since they are
591            often used for the domain attribute in cookies.
592
593 2019-05-02  Per Arne Vollan  <pvollan@apple.com>
594
595         -[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
596         https://bugs.webkit.org/show_bug.cgi?id=197510
597
598         Reviewed by Alex Christensen.
599
600         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
601         (TestWebKitAPI::TEST):
602
603 2019-05-02  Don Olmstead  <don.olmstead@sony.com>
604
605         [CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into WEBKIT_COPY_FILES
606         https://bugs.webkit.org/show_bug.cgi?id=197174
607
608         Reviewed by Alex Christensen.
609
610         Make TestJSC dependent on JavaScriptCorePrivateFrameworkHeaders.
611
612         * TestWebKitAPI/PlatformGTK.cmake:
613         * TestWebKitAPI/PlatformWPE.cmake:
614
615 2019-05-02  Alex Christensen  <achristensen@webkit.org>
616
617         Build fix for internal branch.
618
619         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
620         RetainPtr.h was not explicitly included.
621
622 2019-05-02  Jonathan Bedard  <jbedard@apple.com>
623
624         webkitpy: Ignore errors when shutting down an already shutdown simulator
625         <https://bugs.webkit.org/show_bug.cgi?id=197514>
626         <rdar://problem/50390247>
627
628         Reviewed by Lucas Forschler.
629
630         * Scripts/webkitpy/xcode/simulated_device.py:
631         (SimulatedDevice._shut_down):
632
633 2019-05-02  Frederic Wang  <fwang@igalia.com>
634
635         [GTK][WPE] Disable "thin", "thick", "medium" values of mfrac@linethickness at runtime
636         https://bugs.webkit.org/show_bug.cgi?id=196142
637
638         This patch introduces some experimental runtime flag to let users
639         disable MathML features that are removed from MathML Core [1]. For now,
640         these features are only disabled on GTK and WPE ports.
641
642         [1] https://mathml-refresh.github.io/mathml-core/
643
644         Reviewed by Rob Buis.
645
646         * DumpRenderTree/TestOptions.cpp:
647         (TestOptions::TestOptions):
648         * DumpRenderTree/TestOptions.h:
649         * DumpRenderTree/mac/DumpRenderTree.mm:
650         (setWebPreferencesForTestOptions):
651
652 2019-05-01  Don Olmstead  <don.olmstead@sony.com>
653
654         TestWebKitAPI config.h should be aware of what suite is being built
655         https://bugs.webkit.org/show_bug.cgi?id=196583
656
657         Reviewed by Konstantin Tokarev.
658
659         Migrate to WEBKIT_EXECUTABLE to define the Test* executables. As an added
660         benefit the macro defines BUILDING_* for the executable which allows the includes
661         of the config.h to be tailored to the test suite being built. Because of that the
662         dependencies of the Test* executable are specific to the test suite which may
663         speed up the build.
664
665         Some source files were including "PlatformUtilities.h" which includes WebKit headers
666         when "Utilities.h" is what was needed.
667
668         * TestWebKitAPI/CMakeLists.txt:
669         * TestWebKitAPI/PlatformGTK.cmake:
670         * TestWebKitAPI/PlatformJSCOnly.cmake:
671         * TestWebKitAPI/PlatformMac.cmake:
672         * TestWebKitAPI/PlatformPlayStation.cmake:
673         * TestWebKitAPI/PlatformUtilities.h:
674         * TestWebKitAPI/PlatformWPE.cmake:
675         * TestWebKitAPI/PlatformWin.cmake:
676         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
677         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
678         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
679         * TestWebKitAPI/Tests/WebCore/LineBreaking.mm:
680         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
681         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
682         * TestWebKitAPI/config.h:
683
684 2019-05-01  Jiewen Tan  <jiewen_tan@apple.com>
685
686         Move Document::domainIsRegisterable to SecurityOrigin::isMatchingRegistrableDomainSuffix
687         https://bugs.webkit.org/show_bug.cgi?id=181950
688         <rdar://problem/43357371>
689
690         Reviewed by Brent Fulgham.
691
692         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
693         (TestWebKitAPI::TEST_F):
694
695 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
696
697         Remove webkitpy and bindings EWS queues from dashboard
698         https://bugs.webkit.org/show_bug.cgi?id=197475
699
700         Reviewed by Alexey Proskuryakov.
701
702         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
703
704 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
705
706         Remove webkitpy and bindings test queues from old EWS
707         https://bugs.webkit.org/show_bug.cgi?id=197468
708
709         Reviewed by Alexey Proskuryakov.
710
711         * QueueStatusServer/config/queues.py:
712
713 2019-04-30  Tim Horton  <timothy_horton@apple.com>
714
715         Fix the WebKitTestRunner build
716         https://bugs.webkit.org/show_bug.cgi?id=197449
717         <rdar://problem/50334169>
718
719         Reviewed by Alexey Proskuryakov.
720
721         * WebKitTestRunner/mac/EventSenderProxy.mm:
722         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
723         (WTR::EventSenderProxy::mouseForceChanged):
724         Use some SPI instead of IPI.
725
726 2019-04-30  Chris Dumez  <cdumez@apple.com>
727
728         Regression(PSON) URL scheme handlers can no longer respond asynchronously
729         https://bugs.webkit.org/show_bug.cgi?id=197426
730         <rdar://problem/50256169>
731
732         Reviewed by Brady Eidson.
733
734         Add API test coverage.
735
736         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
737         (-[PSONScheme setShouldRespondAsynchronously:]):
738         (-[PSONScheme webView:startURLSchemeTask:]):
739         (-[PSONScheme webView:stopURLSchemeTask:]):
740
741 2019-04-30  Chris Dumez  <cdumez@apple.com>
742
743         Unreviewed, rolling out r244802.
744
745         Caused an API test failure
746
747         Reverted changeset:
748
749         "Regression(PSON) URL scheme handlers can no longer respond
750         asynchronously"
751         https://bugs.webkit.org/show_bug.cgi?id=197426
752         https://trac.webkit.org/changeset/244802
753
754 2019-04-30  Chris Dumez  <cdumez@apple.com>
755
756         Regression(PSON) URL scheme handlers can no longer respond asynchronously
757         https://bugs.webkit.org/show_bug.cgi?id=197426
758         <rdar://problem/50256169>
759
760         Reviewed by Brady Eidson.
761
762         Add API test coverage.
763
764         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
765         (-[PSONScheme setShouldRespondAsynchronously:]):
766         (-[PSONScheme webView:startURLSchemeTask:]):
767         (-[PSONScheme webView:stopURLSchemeTask:]):
768
769 2019-04-30  Chris Dumez  <cdumez@apple.com>
770
771         Only use a related page's process if that page has not been closed yet
772         https://bugs.webkit.org/show_bug.cgi?id=197393
773         <rdar://problem/50302423>
774
775         Reviewed by Tim Horton.
776
777         Add API test coverage.
778
779         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
780
781 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
782
783         [ews-build] Enable Bindings tests queue on new EWS
784         https://bugs.webkit.org/show_bug.cgi?id=197424
785
786         Reviewed by Lucas Forschler.
787
788         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
789         (StatusBubble):
790         * BuildSlaveSupport/ews-build/config.json:
791
792 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
793
794         [ews-build] Configure ews151 for running various tests
795         https://bugs.webkit.org/show_bug.cgi?id=197419
796
797         Reviewed by Lucas Forschler.
798
799         * BuildSlaveSupport/ews-build/config.json:
800
801 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
802
803         [ews-build] Parse and display bindings test failures
804         https://bugs.webkit.org/show_bug.cgi?id=197423
805
806         Reviewed by Lucas Forschler.
807
808         * BuildSlaveSupport/ews-build/steps.py:
809         (RunBindingsTests.__init__): Set timeout of 5 minutes.
810         (RunBindingsTests.start): Initialize log_observer for json output.
811         (RunBindingsTests.getResultSummary): Update step and build summary based on bindings test results.
812         (RunBindingsTests._addToLog): Method to add message to log.
813         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
814
815 2019-04-30  Pablo Saavedra  <psaavedra@igalia.com>
816
817         Unreviewed. Add myself as a committer.
818
819         * Scripts/webkitpy/common/config/contributors.json:
820
821 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
822
823         [ews-build] Enable webkitpy queue on new EWS
824         https://bugs.webkit.org/show_bug.cgi?id=197396
825
826         Reviewed by Lucas Forschler.
827
828         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
829         (StatusBubble):
830         * BuildSlaveSupport/ews-build/config.json:
831
832 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
833
834         [ews-build] Parse and display webkitpy failures
835         https://bugs.webkit.org/show_bug.cgi?id=197395
836
837         Reviewed by Lucas Forschler.
838
839         * BuildSlaveSupport/ews-build/steps.py:
840         (RunWebKitPyTests.start): Initialize log_observer for json output.
841         (RunWebKitPyTests.getResultSummary): Update step and build summary based on webkitpy results.
842         (RunWebKitPyTests._addToLog): Method to add message to log.
843         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
844
845 2019-04-29  Alex Christensen  <achristensen@webkit.org>
846
847         <rdar://problem/50299396> Fix internal High Sierra build
848         https://bugs.webkit.org/show_bug.cgi?id=197388
849
850         * DumpRenderTree/mac/Configurations/Base.xcconfig:
851         * MiniBrowser/Configurations/Base.xcconfig:
852         * MobileMiniBrowser/Configurations/Base.xcconfig:
853         * TestWebKitAPI/Configurations/Base.xcconfig:
854         * WebKitTestRunner/Configurations/Base.xcconfig:
855
856 2019-04-29  Youenn Fablet  <youenn@apple.com>
857
858         Remove spurious GVA printf logging
859         https://bugs.webkit.org/show_bug.cgi?id=197368
860         <rdar://problem/35975256>
861
862         Reviewed by Alexey Proskuryakov.
863
864         * Scripts/webkitpy/port/mac.py:
865         (MacPort.logging_patterns_to_strip):
866
867 2019-04-29  Youenn Fablet  <youenn@apple.com>
868
869         getDisplayMedia should be called on user gesture
870         https://bugs.webkit.org/show_bug.cgi?id=197356
871         <rdar://problem/50296074>
872
873         Reviewed by Eric Carlson.
874
875         Update test configuration to inject internals
876         so that we can use it to simulate a user click to call getDisplayMedia.
877
878         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
879         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
880         (TestWebKitAPI::GetDisplayMediaTest::SetUp):
881
882 2019-04-26  Stephanie Lewis  <slewis@apple.com>
883
884         run-benchmarks should have an intial prep and restore env call for tasks that are too expensive to do for every iteration
885         https://bugs.webkit.org/show_bug.cgi?id=197339
886
887         Reviewed by Dewei Zhu.
888
889         Add two new functions prepare_inital_env and restore_env_after_all_testing around the entire
890         test run for setup steps that are too expensive to do every iteration.
891
892         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
893         (BenchmarkRunner._run_benchmark):
894         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
895         (BrowserDriver):
896         (BrowserDriver.prepare_initial_env):
897         (BrowserDriver.restore_env_after_all_testing):
898         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
899         (LinuxBrowserDriver.prepare_initial_env):
900         (LinuxBrowserDriver.restore_env_after_all_testing):
901         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
902         (OSXBrowserDriver.prepare_initial_env):
903         (OSXBrowserDriver.restore_env_after_all_testing):
904
905 2019-04-28  Andy Estes  <aestes@apple.com>
906
907         Fix the watchOS engineering build.
908
909         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
910         (TestWebKitAPI::TEST): AVVideoPerformanceMetrics does not exist on watchOS.
911
912 2019-04-27  Chris Dumez  <cdumez@apple.com>
913
914         [WKTR] Move test timeout handling to the UIProcess
915         https://bugs.webkit.org/show_bug.cgi?id=197333
916
917         Reviewed by Darin Adler.
918
919         Move test timeout handling in WebKitTestRunner to the UIProcess to play nicely with PSON. Previously,
920         we'd start the timeout timer in the InjectedBundle, which would fail to account of the time spent in
921         every WebContent process in the case of swapping.
922
923         Also, because of process caching, the timeout timer would sometime fire in a cached process and it
924         would lead to crashes when firing the timer.
925
926         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
927         (WTR::InjectedBundle::didReceiveMessageToPage):
928         (WTR::InjectedBundle::done):
929         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
930         (WTR::InjectedBundle::shouldDumpPixels const):
931         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
932         (WTR::TestRunner::TestRunner):
933         (WTR::TestRunner::waitUntilDone):
934         (WTR::TestRunner::setWaitUntilDone):
935         * WebKitTestRunner/InjectedBundle/TestRunner.h:
936         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
937         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
938         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
939         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp:
940         * WebKitTestRunner/TestInvocation.cpp:
941         (WTR::TestInvocation::TestInvocation):
942         (WTR::TestInvocation::createTestSettingsDictionary):
943         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
944         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
945         (WTR::TestInvocation::initializeWaitToDumpWatchdogTimerIfNeeded):
946         (WTR::TestInvocation::invalidateWaitToDumpWatchdogTimer):
947         (WTR::TestInvocation::waitToDumpWatchdogTimerFired):
948         (WTR::TestInvocation::setWaitUntilDone):
949         (WTR::TestInvocation::done):
950         * WebKitTestRunner/TestInvocation.h:
951
952 2019-04-25  Yusuke Suzuki  <ysuzuki@apple.com>
953
954         [JSC] linkPolymorphicCall now does GC
955         https://bugs.webkit.org/show_bug.cgi?id=197306
956
957         Reviewed by Saam Barati.
958
959         The test is sensitive to allocations and even adding $vm makes it non-reproducible.
960         To add this test, we add `runWithoutBaseOption`.
961
962         * Scripts/run-jsc-stress-tests:
963
964 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
965
966         Update inactive reviewers' status to 'contributor'.
967
968         Accidentally skipped one at first.
969
970         * Scripts/webkitpy/common/config/contributors.json:
971
972 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
973
974         Update inactive reviewers' status to 'contributor'.
975
976         * Scripts/webkitpy/common/config/contributors.json: The change.
977
978         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
979         * Scripts/webkitpy/common/checkout/checkout_mock.py:
980         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
981         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
982         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
983         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
984         * Scripts/webkitpy/tool/commands/queries_unittest.py:
985         * Scripts/webkitpy/tool/commands/upload_unittest.py:
986         Sadly, regression tests operate on a crazy mix of mock and live data for
987         contributors.json. It would be a substantial project to mock all code paths,
988         so changing the tests instead.
989
990 2019-04-26  Eric Carlson  <eric.carlson@apple.com>
991
992         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
993         https://bugs.webkit.org/show_bug.cgi?id=197171
994         <rdar://problem/47454979>
995
996         Reviewed by Youenn Fablet.
997
998         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
999         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
1000         (TestWebKitAPI::TEST):
1001
1002 2019-04-26  David Kilzer  <ddkilzer@apple.com>
1003
1004         WebKitTestRunner leaks an NSDictionary and multiple JSStringRef objects
1005         <https://webkit.org/b/197314>
1006         <rdar://problem/50245252>
1007
1008         Reviewed by Simon Fraser.
1009
1010         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1011         (WTR::UIScriptController::lastUndoLabel const):
1012         (WTR::UIScriptController::firstRedoLabel const):
1013         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
1014
1015         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1016         (-[HIDEventGenerator sendEventStream:completionBlock:]):
1017         - Call -autorelease to fix leak of NSDictionary.
1018
1019         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1020         (WTR::UIScriptController::accessibilitySpeakSelectionContent const):
1021         (WTR::UIScriptController::selectFormPopoverTitle const):
1022         (WTR::UIScriptController::textContentType const):
1023         (WTR::UIScriptController::formInputLabel const):
1024         (WTR::UIScriptController::scrollingTreeAsText const):
1025         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
1026
1027 2019-04-26  Jonathan Bedard  <jbedard@apple.com>
1028
1029         webkitpy: Running a single test will always use the default device
1030         https://bugs.webkit.org/show_bug.cgi?id=195472
1031         <rdar://problem/48724825>
1032
1033         Reviewed by Lucas Forschler.
1034
1035         It makes more sense to have the Manager class handle the case where a user specifically requests a test which is
1036         skipped on the current configuration. This changes the behavior when running part of a test shard, now tests explicitly
1037         requested will be run regardless of what shard they are in.
1038
1039         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
1040         (LayoutTestFinder.skip_tests): Caller should manage running skipped tests which were explicitly requested.
1041         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1042         (Manager.run): If a test is marked as skipped for the configuration, but was specifically requested, run it anyways
1043         on the default device type.
1044         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1045         (RunTest.test_run_chunk): Explicitly requesting a test will override sharing behavior.
1046         (RunTest.test_run_part): Ditto.
1047
1048 2019-04-26  Alex Christensen  <achristensen@webkit.org>
1049
1050         Add ENABLE(CONTENT_EXTENSIONS) and namespace ContentExtensions to ResourceLoadInfo.h
1051         https://bugs.webkit.org/show_bug.cgi?id=197165
1052
1053         Reviewed by Youenn Fablet.
1054
1055         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1056
1057 2019-04-26  Ryan Haddad  <ryanhaddad@apple.com>
1058
1059         Replace iOS build queue hardware
1060         https://bugs.webkit.org/show_bug.cgi?id=197312
1061
1062         Reviewed by Aakash Jain.
1063
1064         * BuildSlaveSupport/build.webkit.org-config/config.json:
1065         Use newer hardware that supports macOS Mojave.
1066
1067 2019-04-26  Yoshiaki Jitsukawa  <yoshiaki.jitsukawa@sony.com>
1068
1069         check-webkit-style complains the first block in while loop.
1070         https://bugs.webkit.org/show_bug.cgi?id=197307
1071
1072         The style checker shouldn't complain about an open brace on
1073         its own line if the last non-whitespace character on the previous
1074         non-blank line is another open brace, because it's likely to
1075         indicate the begining of a nested code block.
1076
1077         Reviewed by Alex Christensen.
1078
1079         * Scripts/webkitpy/style/checkers/cpp.py:
1080         (check_braces):
1081         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1082         (WebKitStyleTest.test_braces):
1083
1084 2019-04-26  Sihui Liu  <sihui_liu@apple.com>
1085
1086         Stop IDB transactions to release locked database files when network process is ready to suspend
1087         https://bugs.webkit.org/show_bug.cgi?id=196372
1088         <rdar://problem/48930116>
1089
1090         Reviewed by Brady Eidson.
1091
1092         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1093         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.html: Added.
1094         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm: Added.
1095         (-[IndexedDBSuspendImminentlyMessageHandler userContentController:didReceiveScriptMessage:]):
1096         (runTestAndCheckResult):
1097         (keepNetworkProcessActive):
1098         (TEST):
1099
1100 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
1101
1102         REGRESSION (r234330): 3 legacy-animation-engine/compositing tests are flaky failures
1103         https://bugs.webkit.org/show_bug.cgi?id=188357
1104         <rdar://problem/42986633>
1105
1106         Reviewed by Dean Jackson.
1107
1108         DumpRenderTree had no code that set page.setCompositingPolicyOverride() to Normal, so some
1109         tests would fall into low memory mode and have different behavior.
1110         
1111         Fix by moving the code that calls setCompositingPolicyOverride(Normal) from the WK2 layer
1112         to Internals, so it's shared by DRT and WTR.
1113         
1114         We no longer need the WK2 C SPI glue.
1115
1116         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1117         (WTR::InjectedBundlePage::prepare):
1118
1119 2019-04-25  Jonathan Bedard  <jbedard@apple.com>
1120
1121         webkitpy: Including skipped tests in the final count
1122         https://bugs.webkit.org/show_bug.cgi?id=197298
1123         <rdar://problem/49705424>
1124
1125         Reviewed by Lucas Forschler.
1126
1127         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
1128         (BuildBotPrinter.print_run_results): The total number of tests run should exclude delibrately skipped tests.
1129
1130 2019-04-25  Timothy Hatcher  <timothy@apple.com>
1131
1132         Disable date and time inputs on iOSMac.
1133         https://bugs.webkit.org/show_bug.cgi?id=197287
1134         rdar://problem/46794376
1135
1136         Reviewed by Wenson Hsieh.
1137
1138         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1139
1140 2019-04-25  Alex Christensen  <achristensen@webkit.org>
1141
1142         Fix test-webkitpy after r244653
1143         https://bugs.webkit.org/show_bug.cgi?id=197131
1144
1145         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1146         Also use C++17.
1147
1148 2019-04-25  Per Arne Vollan  <pvollan@apple.com>
1149
1150         -[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:] never returns _WKWebsiteDataTypeCredentials
1151         https://bugs.webkit.org/show_bug.cgi?id=196991
1152         <rdar://problem/45507423>
1153
1154         Reviewed by Alex Christensen.
1155
1156         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1157         (-[NavigationTestDelegate init]):
1158         (-[NavigationTestDelegate waitForDidFinishNavigation]):
1159         (-[NavigationTestDelegate webView:didFinishNavigation:]):
1160         (-[NavigationTestDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1161         (TestWebKitAPI::TEST):
1162         (TEST): Deleted.
1163
1164 2019-04-25  Alex Christensen  <achristensen@webkit.org>
1165
1166         Revert some code accidentally committed with r244653
1167         https://bugs.webkit.org/show_bug.cgi?id=197131
1168
1169         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
1170         (TestWebKitAPI::TEST):
1171
1172 2019-04-25  Alex Christensen  <achristensen@webkit.org>
1173
1174         Start using C++17
1175         https://bugs.webkit.org/show_bug.cgi?id=197131
1176
1177         Reviewed by Darin Adler.
1178
1179         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1180         * MiniBrowser/Configurations/Base.xcconfig:
1181         * MobileMiniBrowser/Configurations/Base.xcconfig:
1182         * TestWebKitAPI/Configurations/Base.xcconfig:
1183         * WebKitTestRunner/Configurations/Base.xcconfig:
1184
1185 2019-04-25  Commit Queue  <commit-queue@webkit.org>
1186
1187         Unreviewed, rolling out r244627.
1188         https://bugs.webkit.org/show_bug.cgi?id=197282
1189
1190         Causing internal build failures (Requested by ShawnRoberts on
1191         #webkit).
1192
1193         Reverted changeset:
1194
1195         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
1196         https://bugs.webkit.org/show_bug.cgi?id=197171
1197         https://trac.webkit.org/changeset/244627
1198
1199 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1200
1201         [GTK] Hardcoded text color in input fields
1202         https://bugs.webkit.org/show_bug.cgi?id=126907
1203
1204         Reviewed by Michael Catanzaro.
1205
1206         Add dark-mode command line option to MiniBrowser.
1207
1208         * MiniBrowser/gtk/main.c:
1209         (main):
1210
1211 2019-04-24  Zalan Bujtas  <zalan@apple.com>
1212
1213         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
1214         https://bugs.webkit.org/show_bug.cgi?id=196948
1215         <rdar://problem/49927131>
1216
1217         Reviewed by Tim Horton.
1218
1219         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
1220         (TEST):
1221         The expected order of incoming events is
1222         1. didInvalidateIntrinsicContentSize
1223         2. didFirstLayout
1224         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
1225         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
1226         (and remember, all we care about is ordering).
1227
1228 2019-04-24  Eric Carlson  <eric.carlson@apple.com>
1229
1230         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
1231         https://bugs.webkit.org/show_bug.cgi?id=197171
1232         <rdar://problem/47454979>
1233
1234         Reviewed by Youenn Fablet.
1235
1236         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1237         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
1238         (TestWebKitAPI::TEST):
1239
1240 2019-04-24  Brady Eidson  <beidson@apple.com>
1241
1242         XMLHTTPRequest POSTs to a custom WKURLSchemeHandler protocol are missing the HTTP body.
1243         https://bugs.webkit.org/show_bug.cgi?id=191362
1244
1245         Reviewed by Alex Christensen.
1246
1247         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm: Add a test that POSTs all sorts of things
1248           from an XHR to a custom protocol.
1249
1250 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
1251
1252         DumpRenderTree doesn't call Internals::resetToConsistentState() before the first test
1253         https://bugs.webkit.org/show_bug.cgi?id=197273
1254
1255         Reviewed by Dean Jackson.
1256
1257         Reorder code so that we create gTestRunner before calling resetWebViewToConsistentStateBeforeTesting(),
1258         so that WebCoreTestSupport::resetInternalsObject() is always run.
1259
1260         * DumpRenderTree/mac/DumpRenderTree.mm:
1261         (resetWebViewToConsistentStateBeforeTesting):
1262         (runTest):
1263
1264 2019-04-24  John Wilander  <wilander@apple.com>
1265
1266         Age out unconverted Ad Click Attributions after one week.
1267         https://bugs.webkit.org/show_bug.cgi?id=197238
1268         <rdar://problem/50177349>
1269
1270         Reviewed by Chris Dumez.
1271
1272         This patch adds infrastructure to allow tests to expire all unconverted
1273         attributions early.
1274
1275         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1276         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1277         (WTR::TestRunner::markAdClickAttributionsAsExpiredForTesting):
1278         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1279         * WebKitTestRunner/TestController.cpp:
1280         (WTR::TestController::markAdClickAttributionsAsExpiredForTesting):
1281         * WebKitTestRunner/TestController.h:
1282         * WebKitTestRunner/TestInvocation.cpp:
1283         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1284
1285 2019-04-24  Chris Dumez  <cdumez@apple.com>
1286
1287         Fix flaky crashes in a couple of PSON API tests
1288         https://bugs.webkit.org/show_bug.cgi?id=197239
1289
1290         Reviewed by Tim Horton.
1291
1292         Do not adopt the NSURLRequest returned by [NSURLRequest requestWithURL:].
1293
1294         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1295
1296 2019-04-24  Simon Fraser  <simon.fraser@apple.com>
1297
1298         Make it possible to control the renderTreeAsText output by setting options on testRunner
1299         https://bugs.webkit.org/show_bug.cgi?id=197133
1300
1301         Reviewed by Sam Weinig.
1302
1303         Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
1304         that make sense in testing (those that don't dump unstable data like addresses), and plumb
1305         these flags through the various framework layers.
1306
1307         Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.
1308
1309         Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
1310         and hand-code DumpRenderTree bindings.
1311
1312         Some cleanup of the TestRunners, using member initializers.
1313
1314         * DumpRenderTree/TestRunner.cpp:
1315         (TestRunner::TestRunner):
1316         (setRenderTreeDumpOptionsCallback):
1317         (TestRunner::staticFunctions):
1318         (TestRunner::setRenderTreeDumpOptions):
1319         * DumpRenderTree/TestRunner.h:
1320         (TestRunner::renderTreeDumpOptions const):
1321         * DumpRenderTree/mac/DumpRenderTree.mm:
1322         (dump):
1323         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1324         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1325         (WTR::InjectedBundlePage::dump):
1326         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1327         (WTR::TestRunner::TestRunner):
1328         (WTR::TestRunner::setRenderTreeDumpOptions):
1329         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1330         (WTR::TestRunner::renderTreeDumpOptions const):
1331
1332 2019-04-24  Alex Christensen  <achristensen@webkit.org>
1333
1334         WKContentRuleLists should have a maximum FileProtection of CompleteUnlessOpen
1335         https://bugs.webkit.org/show_bug.cgi?id=197078
1336         <rdar://problem/49564348>
1337
1338         Reviewed by Geoff Garen.
1339
1340         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
1341         (TEST_F):
1342         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]): Deleted.
1343         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]): Deleted.
1344         Unfortunately, setting the NSFileProtectionKey attribute is only supported on iOS devices.
1345
1346 2019-04-24  Alex Christensen  <achristensen@webkit.org>
1347
1348         Add unit test for r239322
1349         https://bugs.webkit.org/show_bug.cgi?id=197236
1350
1351         Reviewed by Chris Dumez.
1352
1353         I initially developed this as a unit test for rdar://problem/48797895 but it seems that isn't quite ready.
1354         May as well add the test infrastructure which was needed before and will be needed in the future.
1355
1356         * TestWebKitAPI/TCPServer.cpp:
1357         (TestWebKitAPI::TCPServer::TCPServer):
1358         * TestWebKitAPI/TCPServer.h:
1359         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1360         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1361         (TestWebKitAPI::TEST):
1362         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1363         (TestWebKitAPI::downloadAtRate):
1364         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
1365         (TEST):
1366         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm: Added.
1367         (-[ProxyDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1368         (-[ProxyDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1369         (TestWebKitAPI::TEST):
1370         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1371         (TEST):
1372
1373 2019-04-24  Chris Dumez  <cdumez@apple.com>
1374
1375         URL set by document.open() is communicated with the WebPageProxy but not the WebFrameProxy
1376         https://bugs.webkit.org/show_bug.cgi?id=197214
1377         <rdar://problem/49237544>
1378
1379         Reviewed by Alex Christensen.
1380
1381         Extend API test coverage.
1382
1383         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
1384         (TEST):
1385
1386 2019-04-24  Philippe Normand  <pnormand@igalia.com>
1387
1388         [Build][GStreamer] Update to 1.16.0
1389         https://bugs.webkit.org/show_bug.cgi?id=197157
1390
1391         Reviewed by Xabier Rodriguez-Calvar.
1392
1393         The upstreamed patches were removed and a new one was added for a
1394         regression detected in the scaletempo GStreamer element. The GNOME
1395         Flatpak was migrated to 3.32 and I switched a few modules to Meson
1396         on the way, as it is the preferred build system now in GStreamer
1397         1.16.
1398
1399         * flatpak/files/httpd-autogen.sh:
1400         * flatpak/flatpakutils.py:
1401         (FlatpakPackage.install):
1402         (WebkitFlatpak.run_in_sandbox):
1403         * flatpak/org.webkit.CommonModules.yaml:
1404         * flatpak/org.webkit.WebKit.yaml:
1405         * gstreamer/jhbuild.modules:
1406         * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Removed.
1407         * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Removed.
1408         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Removed.
1409         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Removed.
1410         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Removed.
1411         * gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTION-on-EVENT_STREAM_COLL.patch: Removed.
1412         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Removed.
1413         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Removed.
1414         * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Removed.
1415         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
1416         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Removed.
1417         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
1418         * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Removed.
1419         * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Removed.
1420         * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Removed.
1421         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Removed.
1422         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Removed.
1423         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Removed.
1424         * gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch: Removed.
1425         * gstreamer/patches/gst-plugins-good-scaletempo-Advertise-interleaved-layout-in-caps-temp.patch: Added.
1426         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Removed.
1427         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Removed.
1428
1429 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1430
1431         [GTK] MiniBrowser: also set the passed bg-color when receiving arguments
1432         https://bugs.webkit.org/show_bug.cgi?id=197156
1433
1434         Reviewed by Michael Catanzaro.
1435
1436         The background color is only set when MiniBrowser is launched without arguments. This regressed when tabs
1437         support was added.
1438
1439         * MiniBrowser/gtk/BrowserTab.c:
1440         (browser_tab_set_background_color): Set the passed in color as web view background color.
1441         * MiniBrowser/gtk/BrowserTab.h:
1442         * MiniBrowser/gtk/BrowserWindow.c:
1443         (browser_window_init): Initialize backgroundColor.
1444         (browser_window_append_view): Call browser_tab_set_background_color().
1445         (browser_window_set_background_color): Save the passed in color. This function should now be called before tabs
1446         are added.
1447         * MiniBrowser/gtk/main.c:
1448         (main): Call browser_window_set_background_color() before creating the tabs.
1449
1450 2019-04-23  John Wilander  <wilander@apple.com>
1451
1452         Move Ad Click Attribution from internal feature to experimental feature
1453         https://bugs.webkit.org/show_bug.cgi?id=197218
1454         <rdar://problem/47651691>
1455
1456         Reviewed by Brent Fulgham.
1457
1458         * DumpRenderTree/TestOptions.cpp:
1459         (TestOptions::TestOptions):
1460
1461 2019-04-23  Andy Estes  <aestes@apple.com>
1462
1463         [iOS] QuickLook documents loaded from file: URLs should be allowed to perform same-document navigations
1464         https://bugs.webkit.org/show_bug.cgi?id=196749
1465         <rdar://problem/35773454>
1466
1467         Reviewed by Daniel Bates.
1468
1469         Added a new QuickLook API test and added new expectations to existing QuickLook tests.
1470
1471         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1472         (-[QuickLookDelegate webView:didStartProvisionalNavigation:]):
1473         (-[QuickLookDelegate webView:didFinishNavigation:]):
1474         (-[QuickLookDelegate _webView:didFailNavigation:withError:userInfo:]):
1475         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1476         (runTest):
1477         (runTestDecideBeforeLoading):
1478         (runTestDecideAfterLoading):
1479         (TEST):
1480
1481 2019-04-23  John Wilander  <wilander@apple.com>
1482
1483         Remove Ad Click Attribution data when removing website data
1484         https://bugs.webkit.org/show_bug.cgi?id=197215
1485         <rdar://problem/47668988>
1486
1487         Reviewed by Chris Dumez.
1488
1489         This patch adds test infrastructure to delete Ad Click Attribution data
1490         through WebsiteDataStore::removeData().
1491
1492         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1493         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1494         (WTR::TestRunner::clearAdClickAttribution):
1495         (WTR::TestRunner::clearAdClickAttributionsThroughWebsiteDataRemoval):
1496         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1497         * WebKitTestRunner/TestController.cpp:
1498         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
1499         * WebKitTestRunner/TestController.h:
1500         * WebKitTestRunner/TestInvocation.cpp:
1501         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1502
1503 2019-04-23  Jonathan Bedard  <jbedard@apple.com>
1504
1505         webkitpy: Kill unresponsive worker processes
1506         https://bugs.webkit.org/show_bug.cgi?id=197205
1507         <rdar://problem/50104388>
1508
1509         Reviewed by Lucas Forschler.
1510
1511         * Scripts/webkitpy/common/message_pool.py:
1512         (_MessagePool.__init__): Add close timeout.
1513         (_MessagePool._close): Send termination before joining workers, kill unresponsive workers.
1514
1515 2019-04-23  Alex Christensen  <achristensen@webkit.org>
1516
1517         Add unit tests for WKWebView.serverTrust
1518         https://bugs.webkit.org/show_bug.cgi?id=197202
1519
1520         Reviewed by Youenn Fablet
1521
1522         * TestWebKitAPI/TCPServer.cpp:
1523         (TestWebKitAPI::deleter<BIO>::operator()):
1524         (TestWebKitAPI::deleter<SSL>::operator()):
1525         (TestWebKitAPI::deleter<X509>::operator()):
1526         (TestWebKitAPI::deleter<SSL_CTX>::operator()):
1527         (TestWebKitAPI::deleter<EVP_PKEY>::operator()):
1528         (TestWebKitAPI::TCPServer::TCPServer):
1529         (TestWebKitAPI::TCPServer::listenForConnections):
1530         * TestWebKitAPI/TCPServer.h:
1531         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1532         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1533         (TestWebKitAPI::TEST):
1534         (verifyCertificateAndPublicKey):
1535         (-[ServerTrustDelegate webView:didFinishNavigation:]):
1536         (-[ServerTrustDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1537         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1538         (TestWebKitAPI::downloadAtRate):
1539         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
1540         (TEST):
1541         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1542         (TEST):
1543
1544 2019-04-23  Commit Queue  <commit-queue@webkit.org>
1545
1546         Unreviewed, rolling out r244556.
1547         https://bugs.webkit.org/show_bug.cgi?id=197212
1548
1549         Causing build failures on multiple builders (Requested by
1550         ShawnRoberts on #webkit).
1551
1552         Reverted changeset:
1553
1554         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
1555         https://bugs.webkit.org/show_bug.cgi?id=197171
1556         https://trac.webkit.org/changeset/244556
1557
1558 2019-04-23  Alex Christensen  <achristensen@webkit.org>
1559
1560         Fix iOS build.
1561         https://bugs.webkit.org/show_bug.cgi?id=195537
1562
1563         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1564         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
1565         AdoptWK constructor is private now.  Use adoptWK instead.
1566
1567 2019-04-23  Andres Gonzalez  <andresg_22@apple.com>
1568
1569         Accessibility text search and selection API enhancements.
1570         https://bugs.webkit.org/show_bug.cgi?id=197095
1571         <rdar://problem/48181791>
1572
1573         Reviewed by Chris Fleizach.
1574
1575         Added new API JS binding code for searchTextWithCriteria to both WTR and DRT.
1576
1577         * DumpRenderTree/AccessibilityTextMarker.h:
1578         * DumpRenderTree/AccessibilityUIElement.cpp:
1579         (searchTextWithCriteriaCallback):
1580         (AccessibilityUIElement::getJSClass):
1581         * DumpRenderTree/AccessibilityUIElement.h:
1582         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1583         (convertVectorToObjectArray):
1584         (convertNSArrayToVector):
1585         (searchTextParameterizedAttributeForCriteria):
1586         (AccessibilityUIElement::getLinkedUIElements):
1587         (AccessibilityUIElement::getDocumentLinks):
1588         (AccessibilityUIElement::getChildren):
1589         (AccessibilityUIElement::getChildrenWithRange):
1590         (AccessibilityUIElement::rowHeaders const):
1591         (AccessibilityUIElement::columnHeaders const):
1592         (AccessibilityUIElement::uiElementArrayAttributeValue const):
1593         (AccessibilityUIElement::searchTextWithCriteria):
1594         (AccessibilityUIElement::attributesOfColumnHeaders):
1595         (AccessibilityUIElement::attributesOfRowHeaders):
1596         (AccessibilityUIElement::attributesOfColumns):
1597         (AccessibilityUIElement::attributesOfRows):
1598         (AccessibilityUIElement::attributesOfVisibleCells):
1599         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1600         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1601         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1602         (WTR::convertVectorToObjectArray):
1603         (WTR::convertNSArrayToVector):
1604         (WTR::searchTextParameterizedAttributeForCriteria):
1605         (WTR::AccessibilityUIElement::getLinkedUIElements):
1606         (WTR::AccessibilityUIElement::getDocumentLinks):
1607         (WTR::AccessibilityUIElement::getUIElementsWithAttribute const):
1608         (WTR::AccessibilityUIElement::getChildren):
1609         (WTR::AccessibilityUIElement::getChildrenWithRange):
1610         (WTR::AccessibilityUIElement::rowHeaders const):
1611         (WTR::AccessibilityUIElement::columnHeaders const):
1612         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
1613         (WTR::AccessibilityUIElement::searchTextWithCriteria):
1614         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
1615         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
1616         (WTR::AccessibilityUIElement::attributesOfColumns):
1617         (WTR::AccessibilityUIElement::attributesOfRows):
1618         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
1619         (WTR::convertElementsToObjectArray): Deleted.
1620
1621 2019-04-23  Guy Lewin  <guy@lewin.co.il>
1622
1623         Multiple File Input Icon Set Regardless of File List
1624         https://bugs.webkit.org/show_bug.cgi?id=195537
1625
1626         Reviewed by Alexey Proskuryakov.
1627
1628         Add setOpenPanelFilesMediaIcon to TestRunner in order to test icon and
1629         display string in iOS file inputs
1630
1631         * DumpRenderTree/TestRunner.cpp:
1632         (SetOpenPanelFilesMediaIconCallback):
1633         (TestRunner::staticFunctions):
1634         (TestRunner::setOpenPanelFilesMediaIcon):
1635         * DumpRenderTree/TestRunner.h:
1636         (TestRunner::openPanelFilesMediaIcon const):
1637         * DumpRenderTree/mac/UIDelegate.mm:
1638         (-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
1639         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1640         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1641         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
1642         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1643         * WebKitTestRunner/TestController.cpp:
1644         (WTR::runOpenPanel):
1645         (WTR::TestController::resetStateToConsistentValues):
1646         * WebKitTestRunner/TestController.h:
1647         (WTR::TestController::openPanelFileURLsMediaIcon const):
1648         (WTR::TestController::setOpenPanelFileURLsMediaIcon):
1649         * WebKitTestRunner/TestInvocation.cpp:
1650         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1651
1652 2019-04-23  Eric Carlson  <eric.carlson@apple.com>
1653
1654         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
1655         https://bugs.webkit.org/show_bug.cgi?id=197171
1656         <rdar://problem/47454979>
1657
1658         Reviewed by Youenn Fablet.
1659
1660         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1661         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
1662         (TestWebKitAPI::TEST):
1663
1664 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1665
1666         [ews-build] Add unit tests for UnApplyPatchIfRequired
1667         https://bugs.webkit.org/show_bug.cgi?id=197197
1668
1669         Reviewed by Lucas Forschler.
1670
1671         * BuildSlaveSupport/ews-build/steps_unittest.py:
1672         (TestUnApplyPatchIfRequired):
1673         (TestUnApplyPatchIfRequired.test_success):
1674         (TestUnApplyPatchIfRequired.test_failure):
1675         (TestUnApplyPatchIfRequired.test_skip):
1676
1677 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1678
1679         [ews-build] Add unit tests for CleanWorkingDirectory
1680         https://bugs.webkit.org/show_bug.cgi?id=197195
1681
1682         Reviewed by Lucas Forschler.
1683
1684         * BuildSlaveSupport/ews-build/steps_unittest.py:
1685         (TestCleanWorkingDirectory):
1686         (TestCleanWorkingDirectory.test_success):
1687         (TestCleanWorkingDirectory.test_failure):
1688
1689 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1690
1691         [ews-build] Use explicit imports instead of wildcard imports
1692         https://bugs.webkit.org/show_bug.cgi?id=197194
1693
1694         Reviewed by Lucas Forschler.
1695
1696         * BuildSlaveSupport/ews-build/factories.py:
1697         * BuildSlaveSupport/ews-build/loadConfig.py:
1698         * BuildSlaveSupport/ews-build/steps_unittest.py:
1699
1700 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1701
1702         [ews-build] Add unit tests for DownloadBuiltProduct
1703         https://bugs.webkit.org/show_bug.cgi?id=197193
1704
1705         Reviewed by Lucas Forschler.
1706
1707         * BuildSlaveSupport/ews-build/steps_unittest.py:
1708         (TestDownloadBuiltProduct):
1709         (TestDownloadBuiltProduct.setUp):
1710         (TestDownloadBuiltProduct.tearDown):
1711         (TestDownloadBuiltProduct.test_success):
1712         (TestDownloadBuiltProduct.test_failure):
1713
1714 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1715
1716         [ews-app] Exception while loading status-bubble when no build step has started
1717         https://bugs.webkit.org/show_bug.cgi?id=196676
1718
1719         Reviewed by Lucas Forschler.
1720
1721         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1722         (StatusBubble.get_build_timestamp): Check if build step is present before accessing its timestamp.
1723
1724 2019-04-23  Stephan Szabo  <stephan.szabo@sony.com>
1725
1726         [PlayStation] Support running of JSC tests on remote playstation devices
1727         https://bugs.webkit.org/show_bug.cgi?id=197170
1728
1729         Reviewed by Ross Kirsling.
1730
1731         Script changes
1732
1733         * Scripts/run-javascriptcore-tests:
1734         (runJSCStressTests): Pass arguments for playstation to
1735         run-jsc-stress-tests
1736         * Scripts/run-jsc-stress-tests:
1737         Handle $hostOS=="playstation" for determineArchitecture, turning
1738         off $isFTLPlatform and runProfiler and defaulting test writer.
1739         * Scripts/webkitdirs.pm:
1740         (jscPath): PlayStation WebKit executables have .elf extension
1741         (executableProductDir): PlayStation builds on Windows hosts but
1742         uses bin directory rather than bin64/bin32 for executable output
1743         location.
1744         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb: Added.
1745
1746 2019-04-23  Don Olmstead  <don.olmstead@sony.com>
1747
1748         [CMake][Win] Use target oriented design for WebKit
1749         https://bugs.webkit.org/show_bug.cgi?id=197173
1750
1751         Reviewed by Alex Christensen.
1752
1753         * TestWebKitAPI/PlatformWin.cmake: Add WebKitFrameworkHeaders as a dependency.
1754         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp: Remove unused header.
1755
1756 2019-04-23  Chris Dumez  <cdumez@apple.com>
1757
1758         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
1759         https://bugs.webkit.org/show_bug.cgi?id=197097
1760         <rdar://problem/50048318>
1761
1762         Reviewed by Alex Christensen.
1763
1764         Add API test coverage.
1765
1766         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1767         (-[PSONScheme webView:startURLSchemeTask:]):
1768
1769 2019-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1770
1771         [ATK] Implement AtkComponentIface scroll_to methods
1772         https://bugs.webkit.org/show_bug.cgi?id=196856
1773
1774         Reviewed by Michael Catanzaro.
1775
1776         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1777         (WTR::AccessibilityUIElement::scrollToMakeVisible): Call atk_component_scroll_to().
1778         (WTR::AccessibilityUIElement::scrollToGlobalPoint): Call atk_component_scroll_to_point().
1779         * gtk/jhbuild.modules: Bump atk, at-spi2-core and at-spi2-atk to their latest stable version.
1780
1781 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1782
1783         [ews-build] Improve summary for UploadBuiltProduct step
1784         https://bugs.webkit.org/show_bug.cgi?id=197182
1785
1786         Reviewed by Lucas Forschler.
1787
1788         * BuildSlaveSupport/ews-build/steps.py:
1789         (UploadBuiltProduct): Added descriptionDone.
1790         (UploadBuiltProduct.getResultSummary): Overrided getResultSummary.
1791         * BuildSlaveSupport/ews-build/steps_unittest.py:
1792         (TestUploadBuiltProduct.test_success): Updated unit-test.
1793         (TestUploadBuiltProduct.test_failure): Added unit-test for failure case.
1794
1795 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1796
1797         [ews-build] Trigger queues only after uploading the archive
1798         https://bugs.webkit.org/show_bug.cgi?id=197180
1799
1800         Reviewed by Lucas Forschler.
1801
1802         * BuildSlaveSupport/ews-build/factories.py:
1803         (Factory.__init__):
1804         (BuildFactory.__init__): Remove trigger step from factories.
1805         (BuildFactory.propertiesToPassToTriggers): Deleted.
1806         * BuildSlaveSupport/ews-build/steps.py:
1807         (ConfigureBuild.__init__): Confiure triggers property.
1808         (Trigger): Step to trigger other queues.
1809         (Trigger.propertiesToPassToTriggers): Method to construct properties to pass to triggerred builds.
1810         (UploadBuiltProduct.finished): Trigger builds after upload is successful.
1811
1812 2019-04-22  Alex Christensen  <achristensen@webkit.org>
1813
1814         Deprecate WKContextCreateWithInjectedBundlePath
1815         https://bugs.webkit.org/show_bug.cgi?id=197169
1816
1817         Reviewed by Youenn Fablet.
1818
1819         * TestWebKitAPI/PlatformUtilities.cpp:
1820         (TestWebKitAPI::Util::createContextWithInjectedBundle):
1821         Use WKContextCreateWithConfiguration instead of WKContextCreateWithInjectedBundlePath after having set its injected bundle path.
1822
1823 2019-04-22  Alex Christensen  <achristensen@webkit.org>
1824
1825         REGRESSION(r230681) Do not use stored credentials if WKBundlePageResourceLoadClient.shouldUseCredentialStorage returns false
1826         https://bugs.webkit.org/show_bug.cgi?id=197093
1827         <rdar://problem/49708268>
1828
1829         Reviewed by Chris Dumez.
1830
1831         Add a test that does two loads.  The first load shouldUseCredentialStorage returns true and we provide a persistent credential.
1832         The second load shouldUseCredentialStorage returns false and we verify that a challenge is received with no suggested credential.
1833         We also need to make the TCPServer able to handle more than one connection because we need these two loads to come from the same protection space,
1834         and our current Cocoa implementation of NetworkSession uses two NSURLSessions that don't share a connection cache, one for loads with credentials
1835         and one for loads without credentials, so there are two TCP connections to the same server in this test.
1836
1837         * TestWebKitAPI/TCPServer.cpp:
1838         (TestWebKitAPI::TCPServer::TCPServer):
1839         (TestWebKitAPI::TCPServer::~TCPServer):
1840         (TestWebKitAPI::TCPServer::socketBindListen):
1841         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests): Deleted.
1842         * TestWebKitAPI/TCPServer.h:
1843         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1844         * TestWebKitAPI/Tests/WebKitCocoa/BasicProposedCredentialPlugIn.mm: Added.
1845         (-[BasicProposedCredentialPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1846         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1847         (respondWithChallengeThenOK):
1848         (TestWebKitAPI::TEST):
1849         (-[ProposedCredentialDelegate webView:didFinishNavigation:]):
1850         (-[ProposedCredentialDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1851         (TEST):
1852
1853 2019-04-22  Chris Dumez  <cdumez@apple.com>
1854
1855         Delayed WebProcessLaunch may break the _relatedWebView SPI
1856         https://bugs.webkit.org/show_bug.cgi?id=197160
1857
1858         Reviewed by Alex Christensen.
1859
1860         Add API test coverage.
1861
1862         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1863
1864 2019-04-22  Dean Johnson  <dean_johnson@apple.com>
1865
1866         Use curl to download packages for webkitpy autoinstaller
1867         https://bugs.webkit.org/show_bug.cgi?id=197164
1868
1869         Reviewed by Darin Adler.
1870
1871         * Scripts/webkitpy/common/system/autoinstall.py:
1872         (AutoInstaller._download): Use curl(1) to download packages necessary for
1873         webkitpy/thirdparty/autoinstalled since Python2's urllib2 module can result in unnecessary
1874         errors which are not present when using curl(1).
1875
1876 2019-04-22  Chris Dumez  <cdumez@apple.com>
1877
1878         Unreviewed, rolling out r244502.
1879
1880         Caused crashes on the bots
1881
1882         Reverted changeset:
1883
1884         "Delayed WebProcessLaunch may break the _relatedWebView SPI"
1885         https://bugs.webkit.org/show_bug.cgi?id=197160
1886         https://trac.webkit.org/changeset/244502
1887
1888 2019-04-22  Ryan Haddad  <ryanhaddad@apple.com>
1889
1890         Unreviewed, rolling out r244437.
1891
1892         Still breaks internal tests.
1893
1894         Reverted changeset:
1895
1896         "InjectedBundle parameters often need initialization function
1897         called before unarchiving"
1898         https://bugs.webkit.org/show_bug.cgi?id=189709
1899         https://trac.webkit.org/changeset/244437
1900
1901 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1902
1903         [ews-build] Use singular verb in failure description in case of single api test failure
1904         https://bugs.webkit.org/show_bug.cgi?id=197013
1905
1906         Reviewed by Lucas Forschler.
1907
1908         * BuildSlaveSupport/ews-build/steps.py:
1909         (AnalyzeAPITestsResults.analyzeResults):
1910
1911 2019-04-22  Chris Dumez  <cdumez@apple.com>
1912
1913         Delayed WebProcessLaunch may break the _relatedWebView SPI
1914         https://bugs.webkit.org/show_bug.cgi?id=197160
1915
1916         Reviewed by Alex Christensen.
1917
1918         Add API test coverage.
1919
1920         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1921
1922 2019-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1923
1924         REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
1925         https://bugs.webkit.org/show_bug.cgi?id=194630
1926
1927         Reviewed by Michael Catanzaro.
1928
1929         Return early from getAttributeSet() is passed in accessible is nullptr.
1930
1931         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1932
1933 2019-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1934
1935         Defer EditorState updates until the next layer tree flush in a few additional circumstances
1936         https://bugs.webkit.org/show_bug.cgi?id=197145
1937         <rdar://problem/50078170>
1938
1939         Reviewed by Darin Adler.
1940
1941         Adjusts several editing API tests to wait for a presentation update following a selection change, programmatic
1942         focus, or showing the font manager.
1943
1944         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1945         (TestWebKitAPI::TEST):
1946         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
1947         (TEST):
1948         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
1949         (TestWebKitAPI::TEST):
1950
1951 2019-04-21  Brian Burg  <bburg@apple.com>
1952
1953         WebDriver: add hooks to make it possible to easily run WPT WebDriver web server by itself
1954         https://bugs.webkit.org/show_bug.cgi?id=197125
1955         <rdar://problem/50061468>
1956
1957         Reviewed by Darin Adler.
1958
1959         Sometimes I want to run wptserve independently of tests. Make it easier to script that
1960         using this class rather than making our own ./wpt serve invocation.
1961
1962         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
1963         (WebDriverW3CWebServer):
1964         (WebDriverW3CWebServer.document_root): Expose this to clients.
1965         (WebDriverW3CWebServer.wait): Add a method that blocks until the server dies.
1966
1967         (WebDriverW3CWebServer.__enter__):
1968         (WebDriverW3CWebServer.__exit__):
1969         Make it possible to use the web server with a 'with' statement.
1970
1971 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
1972
1973         [CMake][Win] Use target oriented design for WebKitLegacy
1974         https://bugs.webkit.org/show_bug.cgi?id=197112
1975
1976         Reviewed by Konstantin Tokarev.
1977
1978         Fix includes and libraries for DumpRenderTree after changes to WebKitLegacy targets.
1979
1980         * DumpRenderTree/CMakeLists.txt:
1981         * DumpRenderTree/PlatformWin.cmake:
1982         * DumpRenderTree/win/EventSender.cpp:
1983
1984 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
1985
1986         Update text for old EWS submit button
1987         https://bugs.webkit.org/show_bug.cgi?id=197140
1988
1989         Reviewed by Alexey Proskuryakov.
1990
1991         * QueueStatusServer/templates/statusbubble.html:
1992
1993 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
1994
1995         [ews-app] New EWS should poll bugzilla more frequently
1996         https://bugs.webkit.org/show_bug.cgi?id=197138
1997
1998         Reviewed by Alexey Proskuryakov.
1999
2000         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2001         (FetchLoop.__init__):
2002
2003 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
2004
2005         [ews-app] Submit to EWS buttons are not aligned properly with status-bubbles
2006         https://bugs.webkit.org/show_bug.cgi?id=197139
2007
2008         Reviewed by Alexey Proskuryakov.
2009
2010         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2011         * QueueStatusServer/templates/statusbubble.html:
2012
2013 2019-04-20  Chris Dumez  <cdumez@apple.com>
2014
2015         Unreviewed, fix iOS build with recent SDKs.
2016
2017         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2018
2019 2019-04-19  Keith Miller  <keith_miller@apple.com>
2020
2021         Add script to merge run_benchmark jsons
2022         https://bugs.webkit.org/show_bug.cgi?id=197107
2023
2024         Reviewed by Michael Saboff.
2025
2026         The script basically recursively decends through all json objects until it gets
2027         to an array or JSON primitive and concats or takes the first value, respectively.
2028
2029         This patch also adds +x bits to the compare-results script so it
2030         can be run directly from the command line. I had to add a new line so that svn
2031         will accept the change... yay svn!
2032
2033         * Scripts/compare-results:
2034         * Scripts/merge-result-jsons: Added.
2035         (readJSONFile):
2036         (deepAppend):
2037         (mergeJSONs):
2038         (main):
2039
2040 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
2041
2042         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
2043         https://bugs.webkit.org/show_bug.cgi?id=197079
2044
2045         Reviewed by Darin Adler.
2046
2047         Added a regression test. It hits a slightly different backtrace but of the same class of issues.
2048
2049         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2050         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
2051
2052 2019-04-18  Commit Queue  <commit-queue@webkit.org>
2053
2054         Unreviewed, rolling out r244434.
2055         https://bugs.webkit.org/show_bug.cgi?id=197089
2056
2057         caused 1 API test failure (Requested by zalan on #webkit).
2058
2059         Reverted changeset:
2060
2061         "Regression (r244291): Broken API Test
2062         AutoLayoutRenderingProgressRelativeOrdering"
2063         https://bugs.webkit.org/show_bug.cgi?id=196948
2064         https://trac.webkit.org/changeset/244434
2065
2066 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2067
2068         Add new compatibility mode API on WKNavigation
2069         https://bugs.webkit.org/show_bug.cgi?id=197069
2070         <rdar://problem/50025800>
2071
2072         Reviewed by Tim Horton.
2073
2074         Add a block property for -didCommitNavigation to TestNavigationDelegate.
2075
2076         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
2077         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2078         (-[TestNavigationDelegate webView:didCommitNavigation:]):
2079
2080 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
2081
2082         [CMake] Make WebCore headers copies
2083         https://bugs.webkit.org/show_bug.cgi?id=182512
2084         <rdar://problem/37510435>
2085
2086         Reviewed by Alex Christensen.
2087
2088         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
2089         ports.
2090
2091         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
2092         of WebCore headers using "*.h" were modified to <WebCore/*.h>
2093
2094         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2095         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
2096         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
2097         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
2098         * TestWebKitAPI/CMakeLists.txt:
2099         * TestWebKitAPI/PlatformWin.cmake:
2100         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
2101         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
2102         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2103
2104 2019-04-18  Jer Noble  <jer.noble@apple.com>
2105
2106         Add support for parsing FairPlayStreaming PSSH boxes.
2107         https://bugs.webkit.org/show_bug.cgi?id=197064
2108
2109         Reviewed by Eric Carlson.
2110
2111         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
2112         (TestWebKitAPI::TEST):
2113
2114 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
2115
2116         InjectedBundle parameters often need initialization function called before unarchiving
2117         https://bugs.webkit.org/show_bug.cgi?id=189709
2118         <rdar://problem/44573653>
2119
2120         Reviewed by Ryosuke Niwa.
2121
2122         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
2123         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
2124
2125 2019-04-18  Zalan Bujtas  <zalan@apple.com>
2126
2127         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
2128         https://bugs.webkit.org/show_bug.cgi?id=196948
2129         <rdar://problem/49927131>
2130
2131         Reviewed by Tim Horton.
2132
2133         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
2134         (TEST): 
2135         The expected order of incoming events is
2136         1. didInvalidateIntrinsicContentSize
2137         2. didFirstLayout
2138         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
2139         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
2140         (and remember, all we care about is ordering).
2141
2142 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
2143
2144         Unreviewed, rolling out r244299.
2145
2146         Breaks internal tests.
2147
2148         Reverted changeset:
2149
2150         "InjectedBundle parameters often need initialization function
2151         called before unarchiving"
2152         https://bugs.webkit.org/show_bug.cgi?id=189709
2153         https://trac.webkit.org/changeset/244299
2154
2155 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
2156
2157         [WTF] StringBuilder should set correct m_is8Bit flag when merging
2158         https://bugs.webkit.org/show_bug.cgi?id=197053
2159
2160         Reviewed by Saam Barati.
2161
2162         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2163         (TestWebKitAPI::TEST):
2164
2165 2019-04-17  Tim Horton  <timothy_horton@apple.com>
2166
2167         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
2168         https://bugs.webkit.org/show_bug.cgi?id=197028
2169         <rdar://problem/49985290>
2170
2171         Reviewed by Wenson Hsieh.
2172
2173         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
2174         (TEST):
2175         Liberal application of waitForNextPresentationUpdate works around a race
2176         where if the page rapidly changes its viewport arguments (or an API client
2177         rapidly changes its viewport arguments), we'd get stuck thinking that the
2178         user had intentionally zoomed the page, and stop resetting the initial scale.
2179         This deserves a separate bug, but no need to keep the test failing while
2180         we think about it.
2181
2182 2019-04-17  Tim Horton  <timothy_horton@apple.com>
2183
2184         REGRESSION (r241988): Switching tabs is slow
2185         https://bugs.webkit.org/show_bug.cgi?id=197037
2186         <rdar://problem/49951473>
2187
2188         Reviewed by Simon Fraser.
2189
2190         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2191         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
2192         (TEST):
2193         * TestWebKitAPI/cocoa/TestWKWebView.h:
2194         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2195         (-[TestWKWebView addToTestWindow]):
2196         Add a test that hangs without this fix.
2197
2198 2019-04-17  Truitt Savell  <tsavell@apple.com>
2199
2200         Unreviewed, rolling out r244400.
2201
2202         Caused testing to exit early with assertionon Debug WK2
2203
2204         Reverted changeset:
2205
2206         "UI↔Web deadlock when printing with a JavaScript alert
2207         visible"
2208         https://bugs.webkit.org/show_bug.cgi?id=196839
2209         https://trac.webkit.org/changeset/244400
2210
2211 2019-04-17  Brady Eidson  <beidson@apple.com>
2212
2213         Link clicks in PDFs shouldn't send referrer headers.
2214         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
2215
2216         Reviewed by Tim Horton.
2217
2218         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2219         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
2220         (putPDFBytesCallback):
2221         (emptyReleaseInfoCallback):
2222         (createPDFWithLinkToURL):
2223         (TEST):
2224
2225 2019-04-17  Tim Horton  <timothy_horton@apple.com>
2226
2227         UI↔Web deadlock when printing with a JavaScript alert visible
2228         https://bugs.webkit.org/show_bug.cgi?id=196839
2229         <rdar://problem/49157642>
2230
2231         Reviewed by Andy Estes.
2232
2233         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2234         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
2235         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2236         (TEST):
2237
2238 2019-04-17  Alex Christensen  <achristensen@webkit.org>
2239
2240         WKRetainPtr's adoption constructor should be private
2241         https://bugs.webkit.org/show_bug.cgi?id=197019
2242
2243         Reviewed by Tim Horton.
2244
2245         * DumpRenderTree/mac/DumpRenderTree.mm:
2246         (dumpFramesAsText):
2247         * TestWebKitAPI/InjectedBundleController.cpp:
2248         (TestWebKitAPI::InjectedBundleController::initialize):
2249         * TestWebKitAPI/PlatformUtilities.cpp:
2250         (TestWebKitAPI::Util::createContextWithInjectedBundle):
2251         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
2252         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
2253         (TestWebKitAPI::Util::toWK):
2254         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
2255         (TestWebKitAPI::TEST):
2256         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
2257         (TestWebKitAPI::TEST):
2258         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
2259         (TestWebKitAPI::TEST):
2260         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
2261         (TestWebKitAPI::TEST):
2262         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
2263         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
2264         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
2265         (TestWebKitAPI::TEST):
2266         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
2267         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
2268         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
2269         (TestWebKitAPI::TEST):
2270         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
2271         (TestWebKitAPI::TEST):
2272         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
2273         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
2274         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
2275         (TestWebKitAPI::TEST):
2276         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
2277         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
2278         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
2279         (TestWebKitAPI::TEST):
2280         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
2281         (TestWebKitAPI::TEST):
2282         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
2283         (TestWebKitAPI::TEST):
2284         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
2285         (TestWebKitAPI::TEST):
2286         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
2287         (TestWebKitAPI::TEST):
2288         * TestWebKitAPI/Tests/WebKit/Find.cpp:
2289         (TestWebKitAPI::TEST):
2290         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
2291         (TestWebKitAPI::TEST):
2292         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
2293         (TestWebKitAPI::TEST):
2294         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
2295         (TestWebKitAPI::TEST):
2296         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
2297         (TestWebKitAPI::TEST):
2298         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
2299         (TestWebKitAPI::TEST):
2300         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
2301         (TestWebKitAPI::TEST):
2302         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
2303         (TestWebKitAPI::TEST):
2304         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
2305         (TestWebKitAPI::TEST):
2306         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
2307         (TestWebKitAPI::TEST):
2308         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
2309         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
2310         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
2311         (TestWebKitAPI::TEST):
2312         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
2313         (TestWebKitAPI::TEST):
2314         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
2315         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
2316         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
2317         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
2318         (TestWebKitAPI::TEST):
2319         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
2320         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
2321         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
2322         (TestWebKitAPI::TEST):
2323         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
2324         (TestWebKitAPI::TEST):
2325         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
2326         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
2327         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2328         (TestWebKitAPI::TEST):
2329         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
2330         (TestWebKitAPI::loadAlternateHTMLString):
2331         (TestWebKitAPI::TEST):
2332         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
2333         (TestWebKitAPI::TEST):
2334         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
2335         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
2336         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
2337         (TestWebKitAPI::buildAndPerformTest):
2338         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
2339         (TestWebKitAPI::TEST):
2340         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
2341         (TestWebKitAPI::TEST):
2342         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
2343         (TestWebKitAPI::TEST):
2344         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
2345         (TestWebKitAPI::TEST):
2346         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
2347         (TestWebKitAPI::TEST):
2348         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
2349         (TestWebKitAPI::TEST):
2350         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
2351         (TestWebKitAPI::TEST):
2352         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2353         (TestWebKitAPI::TEST):
2354         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
2355         (TestWebKitAPI::TEST):
2356         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
2357         (TestWebKitAPI::TEST):
2358         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
2359         (TestWebKitAPI::TEST):
2360         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
2361         (TestWebKitAPI::TEST):
2362         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
2363         (TestWebKitAPI::TEST):
2364         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2365         (TestWebKitAPI::TEST):
2366         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
2367         (TestWebKitAPI::TEST):
2368         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
2369         (TestWebKitAPI::TEST):
2370         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
2371         (TestWebKitAPI::TEST):
2372         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
2373         (TestWebKitAPI::TEST):
2374         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
2375         (TestWebKitAPI::TEST):
2376         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
2377         (TestWebKitAPI::TEST):
2378         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
2379         (TestWebKitAPI::TEST):
2380         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
2381         (TestWebKitAPI::TEST):
2382         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
2383         (TestWebKitAPI::TEST):
2384         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2385         (TestWebKitAPI::TEST):
2386         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
2387         (TestWebKitAPI::TEST):
2388         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
2389         (TestWebKitAPI::TEST):
2390         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
2391         (TestWebKitAPI::TEST):
2392         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
2393         (TestWebKitAPI::TEST):
2394         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
2395         (TestWebKitAPI::TEST):
2396         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
2397         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2398         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
2399         (TestWebKitAPI::TEST):
2400         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
2401         (TestWebKitAPI::TEST):
2402         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
2403         (TestWebKitAPI::TEST):
2404         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
2405         (TestWebKitAPI::TEST):
2406         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
2407         (TestWebKitAPI::TEST):
2408         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
2409         (TestWebKitAPI::TEST):
2410         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
2411         (TestWebKitAPI::TEST):
2412         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
2413         (TestWebKitAPI::TEST):
2414         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
2415         (TestWebKitAPI::TEST):
2416         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
2417         (TestWebKitAPI::TEST):
2418         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
2419         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
2420         (TEST):
2421         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2422         (TEST):
2423         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2424         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2425         (TEST):
2426         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
2427         (TestWebKitAPI::TEST):
2428         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2429         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
2430         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2431         (WTR::getMenuItemTitleCallback):
2432         (WTR::createMouseMessageBody):
2433         (WTR::EventSendingController::mouseDown):
2434         (WTR::EventSendingController::mouseUp):
2435         (WTR::EventSendingController::mouseMoveTo):
2436         (WTR::EventSendingController::mouseForceClick):
2437         (WTR::EventSendingController::startAndCancelMouseForceClick):
2438         (WTR::EventSendingController::mouseForceDown):
2439         (WTR::EventSendingController::mouseForceUp):
2440         (WTR::EventSendingController::mouseForceChanged):
2441         (WTR::EventSendingController::leapForward):
2442         (WTR::EventSendingController::scheduleAsynchronousClick):
2443         (WTR::createKeyDownMessageBody):
2444         (WTR::EventSendingController::keyDown):
2445         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
2446         (WTR::EventSendingController::mouseScrollBy):
2447         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
2448         (WTR::EventSendingController::continuousMouseScrollBy):
2449         (WTR::EventSendingController::addTouchPoint):
2450         (WTR::EventSendingController::updateTouchPoint):
2451         (WTR::EventSendingController::setTouchModifier):
2452         (WTR::EventSendingController::setTouchPointRadius):
2453         (WTR::EventSendingController::touchStart):
2454         (WTR::EventSendingController::touchMove):
2455         (WTR::EventSendingController::touchEnd):
2456         (WTR::EventSendingController::touchCancel):
2457         (WTR::EventSendingController::clearTouchPoints):
2458         (WTR::EventSendingController::releaseTouchPoint):
2459         (WTR::EventSendingController::cancelTouchPoint):
2460         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2461         (WTR::InjectedBundle::didCreatePage):
2462         (WTR::InjectedBundle::didReceiveMessage):
2463         (WTR::InjectedBundle::didReceiveMessageToPage):
2464         (WTR::InjectedBundle::booleanForKey):
2465         (WTR::InjectedBundle::done):
2466         (WTR::InjectedBundle::dumpToStdErr):
2467         (WTR::InjectedBundle::outputText):
2468         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
2469         (WTR::InjectedBundle::postAddChromeInputField):
2470         (WTR::InjectedBundle::postRemoveChromeInputField):
2471         (WTR::InjectedBundle::postFocusWebView):
2472         (WTR::InjectedBundle::postSetBackingScaleFactor):
2473         (WTR::InjectedBundle::postSetWindowIsKey):
2474         (WTR::InjectedBundle::postSetViewSize):
2475         (WTR::InjectedBundle::postSimulateWebNotificationClick):
2476         (WTR::InjectedBundle::postSetAddsVisitedLinks):
2477         (WTR::InjectedBundle::setGeolocationPermission):
2478         (WTR::InjectedBundle::setMockGeolocationPosition):
2479         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
2480         (WTR::InjectedBundle::isGeolocationProviderActive const):
2481         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
2482         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
2483         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
2484         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
2485         (WTR::InjectedBundle::setCustomPolicyDelegate):
2486         (WTR::InjectedBundle::setHidden):
2487         (WTR::InjectedBundle::setCacheModel):
2488         (WTR::InjectedBundle::shouldProcessWorkQueue const):
2489         (WTR::InjectedBundle::processWorkQueue):
2490         (WTR::InjectedBundle::queueBackNavigation):
2491         (WTR::InjectedBundle::queueForwardNavigation):
2492         (WTR::InjectedBundle::queueLoad):
2493         (WTR::InjectedBundle::queueLoadHTMLString):
2494         (WTR::InjectedBundle::queueReload):
2495         (WTR::InjectedBundle::queueLoadingScript):
2496         (WTR::InjectedBundle::queueNonLoadingScript):
2497         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2498         (WTR::frameToStr):
2499         (WTR::InjectedBundlePage::InjectedBundlePage):
2500         (WTR::dumpFrameDescriptionSuitableForTestResult):
2501         (WTR::dumpFrameScrollPosition):
2502         (WTR::dumpDescendantFrameScrollPositions):
2503         (WTR::dumpFrameText):
2504         (WTR::dumpDescendantFramesText):
2505         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2506         (WTR::TestRunner::shouldDumpPixels const):
2507         (WTR::TestRunner::setDumpPixels):
2508         (WTR::TestRunner::whatToDump const):
2509         (WTR::TestRunner::setWhatToDump):
2510         (WTR::TestRunner::setWaitUntilDone):
2511         (WTR::TestRunner::shouldWaitUntilDone const):
2512         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
2513         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
2514         (WTR::TestRunner::clearAllDatabases):
2515         (WTR::TestRunner::setIDBPerOriginQuota):
2516         (WTR::TestRunner::originsWithApplicationCache):
2517         (WTR::TestRunner::setCanOpenWindows):
2518         (WTR::TestRunner::setXSSAuditorEnabled):
2519         (WTR::TestRunner::setMediaDevicesEnabled):
2520         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
2521         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
2522         (WTR::TestRunner::setCustomUserAgent):
2523         (WTR::TestRunner::setWebAPIStatisticsEnabled):
2524         (WTR::TestRunner::setModernMediaControlsEnabled):
2525         (WTR::TestRunner::setWebGL2Enabled):
2526         (WTR::TestRunner::setWritableStreamAPIEnabled):
2527         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
2528         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
2529         (WTR::TestRunner::setAllowsAnySSLCertificate):
2530         (WTR::TestRunner::setPluginsEnabled):
2531         (WTR::TestRunner::setValueForUser):
2532         (WTR::TestRunner::setAudioResult):
2533         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
2534         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
2535         (WTR::TestRunner::setAlwaysAcceptCookies):
2536         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
2537         (WTR::TestRunner::isDoingMediaCapture const):
2538         (WTR::TestRunner::queueLoad):
2539         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2540         (WTR::TestRunner::setHandlesAuthenticationChallenges):
2541         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
2542         (WTR::TestRunner::setShouldLogDownloadCallbacks):
2543         (WTR::TestRunner::setAuthenticationUsername):
2544         (WTR::TestRunner::setAuthenticationPassword):
2545         (WTR::TestRunner::secureEventInputIsEnabled const):
2546         (WTR::TestRunner::setBlockAllPlugins):
2547         (WTR::TestRunner::setPluginSupportedMode):
2548         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
2549         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
2550         (WTR::TestRunner::setNavigationGesturesEnabled):
2551         (WTR::TestRunner::setIgnoresViewportScaleLimits):
2552         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
2553         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
2554         (WTR::TestRunner::terminateNetworkProcess):
2555         (WTR::TestRunner::terminateServiceWorkerProcess):
2556         (WTR::TestRunner::runUIScript):
2557         (WTR::TestRunner::setStatisticsDebugMode):
2558         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
2559         (WTR::TestRunner::setStatisticsLastSeen):
2560         (WTR::TestRunner::setStatisticsPrevalentResource):
2561         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
2562         (WTR::TestRunner::dumpResourceLoadStatistics):
2563         (WTR::TestRunner::isStatisticsPrevalentResource):
2564         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
2565         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
2566         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
2567         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
2568         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
2569         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
2570         (WTR::TestRunner::setStatisticsGrandfathered):
2571         (WTR::TestRunner::isStatisticsGrandfathered):
2572         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
2573         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
2574         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
2575         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
2576         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
2577         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
2578         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2579         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
2580         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
2581         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
2582         (WTR::TestRunner::statisticsUpdateCookieBlocking):
2583         (WTR::TestRunner::statisticsSubmitTelemetry):
2584         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
2585         (WTR::TestRunner::setStatisticsIsRunningTest):
2586         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
2587         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2588         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
2589         (WTR::TestRunner::setStatisticsGrandfatheringTime):
2590         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
2591         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
2592         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
2593         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
2594         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
2595         (WTR::TestRunner::statisticsDeleteCookiesForHost):
2596         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
2597         (WTR::TestRunner::statisticsResetToConsistentState):
2598         (WTR::TestRunner::setStorageAccessAPIEnabled):
2599         (WTR::TestRunner::getAllStorageAccessEntries):
2600         (WTR::TestRunner::addMockMediaDevice):
2601         (WTR::TestRunner::clearMockMediaDevices):
2602         (WTR::TestRunner::removeMockMediaDevice):
2603         (WTR::TestRunner::resetMockMediaDevices):
2604         (WTR::TestRunner::connectMockGamepad):
2605         (WTR::TestRunner::disconnectMockGamepad):
2606         (WTR::TestRunner::setMockGamepadDetails):
2607         (WTR::TestRunner::setMockGamepadAxisValue):
2608         (WTR::TestRunner::setMockGamepadButtonValue):
2609         (WTR::TestRunner::removeAllSessionCredentials):
2610         (WTR::TestRunner::clearDOMCache):
2611         (WTR::TestRunner::clearDOMCaches):
2612         (WTR::TestRunner::hasDOMCache):
2613         (WTR::TestRunner::domCacheSize):
2614         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2615         (WTR::TestRunner::getApplicationManifestThen):
2616         (WTR::TestRunner::injectUserScript):
2617         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
2618         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
2619         (WTR::TestRunner::addTestKeyToKeychain):
2620         (WTR::TestRunner::cleanUpKeychain):
2621         (WTR::TestRunner::keyExistsInKeychain):
2622         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
2623         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
2624         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
2625         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
2626         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
2627         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
2628         * WebKitTestRunner/TestController.cpp:
2629         (WTR::TestController::initialize):
2630         (WTR::parseStringTestHeaderValueAsRelativePath):
2631         (WTR::updateTestOptionsFromTestHeader):
2632         (WTR::TestController::runTest):
2633         (WTR::TestController::didReceiveLiveDocumentsList):
2634         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2635         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2636         (WTR::TestController::didFinishNavigation):
2637         (WTR::TestController::didReceiveAuthenticationChallenge):
2638         * WebKitTestRunner/TestInvocation.cpp:
2639         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2640         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2641         (WTR::TestInvocation::uiScriptDidComplete):
2642         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
2643         * WebKitTestRunner/WebNotificationProvider.cpp:
2644         (WTR::WebNotificationProvider::closeWebNotification):
2645         * WebKitTestRunner/WorkQueueManager.cpp:
2646         (WTR::ScriptItem::ScriptItem):
2647         (WTR::WorkQueueManager::queueLoad):
2648         (WTR::WorkQueueManager::queueLoadHTMLString):
2649
2650 2019-04-17  Alex Christensen  <achristensen@webkit.org>
2651
2652         Add a comment to make my test from r244139 less mysterious.
2653         https://bugs.webkit.org/show_bug.cgi?id=196744
2654
2655         As suggested by Darin Adler.
2656
2657         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
2658         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2659
2660 2019-04-17  Chris Dumez  <cdumez@apple.com>
2661
2662         Remember device orientation permission for the duration of the browsing session
2663         https://bugs.webkit.org/show_bug.cgi?id=196992
2664         <rdar://problem/49946067>
2665
2666         Reviewed by Alex Christensen.
2667
2668         Add API test coverage.
2669
2670         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
2671         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2672         (TEST):
2673
2674 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
2675
2676         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
2677         https://bugs.webkit.org/show_bug.cgi?id=196675
2678
2679         Reviewed by Lucas Forschler.
2680
2681         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
2682         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
2683
2684 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
2685
2686         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
2687         https://bugs.webkit.org/show_bug.cgi?id=196919
2688         <rdar://problem/41630459>
2689
2690         Reviewed by Tim Horton.
2691
2692         Add iOS support for several new testing hooks. See below for more detail.
2693
2694         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2695         (WTR::UIScriptController::isDismissingMenu const):
2696
2697         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
2698         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
2699         by UIKit when dismissing the callout bar (i.e. UIMenuController).
2700
2701         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2702         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2703         (WTR::UIScriptController::isDismissingMenu const):
2704         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2705         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2706         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2707         (WTR::InjectedBundle::didReceiveMessageToPage):
2708         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2709         (WTR::TestRunner::setAllowedMenuActions):
2710
2711         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
2712         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
2713         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
2714         against the name of the custom action.
2715
2716         (WTR::TestRunner::installCustomMenuAction):
2717
2718         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
2719         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
2720         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
2721         triggered.
2722
2723         (WTR::TestRunner::performCustomMenuAction):
2724
2725         Invoked when the custom menu action is triggered.
2726
2727         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2728         * WebKitTestRunner/TestController.cpp:
2729         (WTR::TestController::installCustomMenuAction):
2730         (WTR::TestController::setAllowedMenuActions):
2731         * WebKitTestRunner/TestController.h:
2732         * WebKitTestRunner/TestInvocation.cpp:
2733         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2734         (WTR::TestInvocation::performCustomMenuAction):
2735
2736         Add plumbing to call back into the injected bundle when performing the custom action.
2737
2738         * WebKitTestRunner/TestInvocation.h:
2739         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2740         (WTR::TestController::installCustomMenuAction):
2741         (WTR::TestController::setAllowedMenuActions):
2742         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2743         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2744         (-[TestRunnerWKWebView initWithFrame:configuration:]):
2745         (-[TestRunnerWKWebView becomeFirstResponder]):
2746         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
2747
2748         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
2749         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
2750         in the Mail app on iOS.
2751
2752         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
2753         (-[TestRunnerWKWebView setAllowedMenuActions:]):
2754         (-[TestRunnerWKWebView resetCustomMenuAction]):
2755         (-[TestRunnerWKWebView performCustomAction:]):
2756         (-[TestRunnerWKWebView canPerformAction:withSender:]):
2757         (-[TestRunnerWKWebView _willHideMenu]):
2758         (-[TestRunnerWKWebView _didHideMenu]):
2759         * WebKitTestRunner/ios/TestControllerIOS.mm:
2760         (WTR::TestController::platformResetStateToConsistentValues):
2761
2762         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
2763         if specified.
2764
2765         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2766         (WTR::UIScriptController::isDismissingMenu const):
2767
2768 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
2769
2770         Allow sharing from imageSheet on an image document
2771         https://bugs.webkit.org/show_bug.cgi?id=196891
2772         <rdar://problem/25377386>
2773
2774         Reviewed by Tim Horton.
2775
2776         Test to make sure that the correct imageURL is extracted from an image element.
2777
2778         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
2779         (TestWebKitAPI::TEST):
2780
2781 2019-04-16  Alex Christensen  <achristensen@webkit.org>
2782
2783         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
2784         https://bugs.webkit.org/show_bug.cgi?id=196995
2785
2786         Reviewed by Brady Eidson.
2787
2788         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
2789         (TEST):
2790
2791 2019-04-16  Chris Dumez  <cdumez@apple.com>
2792
2793         URL set by document.open() is not communicated to the UIProcess
2794         https://bugs.webkit.org/show_bug.cgi?id=196941
2795         <rdar://problem/49237544>
2796
2797         Reviewed by Geoff Garen.
2798
2799         Add API test coverage.
2800
2801         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2802         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
2803         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
2804         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2805         (TEST):
2806
2807 2019-04-16  Commit Queue  <commit-queue@webkit.org>
2808
2809         Unreviewed, rolling out r244321.
2810         https://bugs.webkit.org/show_bug.cgi?id=196968
2811
2812         Causing all WK2 Debug builds to exit early after Assertion
2813         failures. (Requested by ShawnRoberts on #webkit).
2814
2815         Reverted changeset:
2816
2817         "URL set by document.open() is not communicated to the
2818         UIProcess"
2819         https://bugs.webkit.org/show_bug.cgi?id=196941
2820         https://trac.webkit.org/changeset/244321
2821
2822 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2823
2824         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
2825         https://bugs.webkit.org/show_bug.cgi?id=196948
2826
2827         Reviewed by Zalan Bujtas.
2828
2829         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
2830         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
2831
2832 2019-04-15  Chris Dumez  <cdumez@apple.com>
2833
2834         URL set by document.open() is not communicated to the UIProcess
2835         https://bugs.webkit.org/show_bug.cgi?id=196941
2836         <rdar://problem/49237544>
2837
2838         Reviewed by Geoffrey Garen.
2839
2840         Add API test coverage.
2841
2842         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2843         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
2844         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
2845         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2846         (TEST):
2847
2848 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
2849
2850         Using Tools/Scripts/clean-webkit should not install requests
2851         https://bugs.webkit.org/show_bug.cgi?id=196940
2852
2853         Reviewed by Lucas Forschler.
2854
2855         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
2856         existing, depending on the path autoinstalled is run through.
2857         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
2858         needed.
2859         (Port.configuration_for_upload):
2860         (Port.commits_for_upload):
2861
2862 2019-04-15  Alex Christensen  <achristensen@webkit.org>
2863
2864         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
2865         https://bugs.webkit.org/show_bug.cgi?id=196773
2866
2867         Reviewed by Jer Noble.
2868
2869         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
2870         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
2871         (TEST):
2872
2873 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2874
2875         ews-build should clearly indicate flaky test failures
2876         https://bugs.webkit.org/show_bug.cgi?id=196947
2877
2878         Reviewed by Lucas Forschler.
2879
2880         * BuildSlaveSupport/ews-build/steps.py:
2881         (AnalyzeAPITestsResults.analyzeResults):
2882
2883 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
2884
2885         InjectedBundle parameters often need initialization function called before unarchiving
2886         https://bugs.webkit.org/show_bug.cgi?id=189709
2887         <rdar://problem/44573653>
2888
2889         Reviewed by Ryosuke Niwa.
2890
2891         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
2892         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
2893
2894 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
2895
2896         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
2897         https://bugs.webkit.org/show_bug.cgi?id=196681
2898
2899         Reviewed by Darin Adler.
2900
2901         Added tests.
2902
2903         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2904         (WTF_HashSet.RemoveIf):
2905         (WTF_HashSet.RemoveIfShrinkToBestSize):
2906
2907 2019-04-15  John Wilander  <wilander@apple.com>
2908
2909         Send delayed Ad Click Attribution conversion requests to the click source
2910         https://bugs.webkit.org/show_bug.cgi?id=196838
2911         <rdar://problem/47650157>
2912
2913         Reviewed by Chris Dumez and Youenn Fablet.
2914
2915         This patch adds test infrastructure to override the default behavior in
2916         WebKit::NetworkAdClickAttribution.
2917
2918         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2919         (TestWebKitAPI::TEST):
2920         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2921         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2922         (WTR::TestRunner::dumpAdClickAttribution):
2923         (WTR::TestRunner::clearAdClickAttribution):
2924         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
2925         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
2926         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2927         * WebKitTestRunner/TestController.cpp:
2928         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
2929         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
2930         * WebKitTestRunner/TestController.h:
2931         * WebKitTestRunner/TestInvocation.cpp:
2932         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2933
2934 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2935
2936         [ews-app] status-bubble should display position in queue
2937         https://bugs.webkit.org/show_bug.cgi?id=196607
2938
2939         Reviewed by Lucas Forschler.
2940
2941         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2942         (StatusBubble._build_bubble):
2943         (StatusBubble._queue_position): Method to calculate patch's position in queue.
2944
2945 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2946
2947         [ews-build] Do not run clean build by default on EWS builders
2948         https://bugs.webkit.org/show_bug.cgi?id=196897
2949
2950         Reviewed by Lucas Forschler.
2951
2952         * BuildSlaveSupport/ews-build/steps.py:
2953         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
2954         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
2955         untracked directories like WebKitBuild).
2956         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
2957         untracked files/directories (like WebKitBuild).
2958
2959 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
2960
2961         TestRunner::notifyDone() should be safely reentrant
2962         https://bugs.webkit.org/show_bug.cgi?id=196898
2963
2964         Reviewed by Darin Adler.
2965
2966         It is currently possible that TestRunner::notifyDone() will call itself, since
2967         notifyDone() will force a repaint, which can start executing JavaScript, which
2968         may call notifyDone() again. This can lead to test failures and flakiness.
2969         Fix this by setting the m_waitToDump flag before calling the dump() method.
2970
2971         * DumpRenderTree/mac/TestRunnerMac.mm:
2972         (TestRunner::notifyDone):
2973         (TestRunner::forceImmediateCompletion):
2974         * DumpRenderTree/win/TestRunnerWin.cpp:
2975         (TestRunner::notifyDone):
2976         (TestRunner::forceImmediateCompletion):
2977
2978 2019-04-15  Philippe Normand  <pnormand@igalia.com>
2979
2980         [GTK][WPE] Add enable-media websetting
2981         https://bugs.webkit.org/show_bug.cgi?id=196863
2982
2983         Reviewed by Michael Catanzaro.
2984
2985         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2986         (testWebKitSettings): Add test for the enable-media web-setting.
2987
2988 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
2989
2990         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
2991         https://bugs.webkit.org/show_bug.cgi?id=196905
2992         <rdar://problem/49886096>
2993
2994         Reviewed by Tim Horton.
2995
2996         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
2997         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
2998         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
2999         delay timer, we end up with this sequence of events in the problematic (failure) case:
3000
3001         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
3002             ...IPC from UI to web process...
3003         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
3004             ...IPC from web to UI process...
3005         (c) [UI]    Invoke completion handler for script #1
3006         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
3007             ...IPC from UI to web process...
3008         (e) [Web]   Evaluate script #2 in the web process
3009         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
3010
3011         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
3012         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
3013         #2 is run in step (e).
3014
3015         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
3016         the UI process by waiting on a script message posted by the web process, after attachment updates are
3017         dispatched.
3018
3019         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3020         (TestWebKitAPI::TEST):
3021
3022 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
3023
3024         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
3025         https://bugs.webkit.org/show_bug.cgi?id=196909
3026
3027         Reviewed by Wenson Hsieh.
3028
3029         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3030         (TestWebKitAPI::TEST):
3031
3032 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
3033
3034         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
3035         https://bugs.webkit.org/show_bug.cgi?id=196880
3036
3037         Reviewed by Yusuke Suzuki.
3038
3039         Add a new function for bytecode cache tests that does not forceDiskCache
3040         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
3041         test added in this patch, since the code is invalid and therefore won't be
3042         cached. It should also be useful for tests that evaluate dynamically
3043         generated code.
3044
3045         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
3046         * Scripts/run-jsc-stress-tests:
3047
3048 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
3049
3050         Update AudioSession route sharing policy
3051         https://bugs.webkit.org/show_bug.cgi?id=196776
3052         <rdar://problem/46501611>
3053
3054         Reviewed by Jer Noble.
3055
3056         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
3057         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
3058         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
3059         (TestWebKitAPI::TEST):
3060
3061 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
3062
3063         [iOS] Software keyboard is shown too frequently on some websites
3064         https://bugs.webkit.org/show_bug.cgi?id=195856
3065         <rdar://problem/49191395>
3066
3067         Reviewed by Darin Adler.
3068
3069         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
3070
3071         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3072         (WTR::UIScriptController::setHardwareKeyboardAttached):
3073         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3074         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3075         (WTR::UIScriptController::setHardwareKeyboardAttached):
3076         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3077         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
3078
3079         Additionally link against GraphicsServices in WebKitTestRunner.
3080
3081         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3082         (WTR::TestController::platformResetStateToConsistentValues):
3083         (WTR::UIScriptController::setHardwareKeyboardAttached):
3084
3085 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
3086
3087         [GTK][WPE] Fix pacman install-dependencies packages
3088         https://bugs.webkit.org/show_bug.cgi?id=196817
3089
3090         Reviewed by Žan Doberšek.
3091         
3092         python3-setuptools is called python-setuptools
3093         ruby-highline is only available on AUR
3094         libv4l-devel is incorporated in v4l-utils
3095
3096         * gtk/install-dependencies:
3097         * wpe/install-dependencies:
3098
3099 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3100
3101         [GTK] REGRESSION(r243860): Many tests failing
3102         https://bugs.webkit.org/show_bug.cgi?id=196791
3103
3104         Reviewed by Joanmarie Diggs.
3105
3106         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
3107         multiple documents and check that accessibility hierarchy is updated after a navigation.
3108
3109         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
3110         (loadChangedCallback):
3111         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
3112         (AccessibilityTest::AccessibilityTest):
3113         (AccessibilityTest::~AccessibilityTest):
3114         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
3115         (AccessibilityTest::findTestServerApplication):
3116         (AccessibilityTest::findDocumentWeb):
3117         (AccessibilityTest::findRootObject):
3118         (AccessibilityTest::waitUntilChildrenRemoved):
3119         (AccessibilityTest::ensureProxy):
3120         (testAtspiBasicHierarchy):
3121         (beforeAll):
3122         (afterAll):
3123
3124 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
3125
3126         [ews-build] Handle bug titles with unicode characters
3127         https://bugs.webkit.org/show_bug.cgi?id=196802
3128
3129         Reviewed by Dewei Zhu.
3130
3131         * BuildSlaveSupport/ews-build/steps.py:
3132         (ValidatePatch._is_bug_closed):
3133
3134 2019-04-11  Michael Saboff  <msaboff@apple.com>
3135
3136         Improve the Inline Cache Stats code
3137         https://bugs.webkit.org/show_bug.cgi?id=196836
3138
3139         Reviewed by Saam Barati.
3140
3141         Added a new script to consolidate and arrange the output of --useICStats option.
3142
3143         This script merges the output from every group into one large table and sorts it from most common to
3144         least common.  It also counts the slow path GetById and PutById variants and then calculates the
3145         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
3146         Put together, this is useful to see what property accesses are not getting cached.
3147
3148         * Scripts/ic-stats.py: Added.
3149         (ICStats):
3150         (ICStats.__init__):
3151         (ICStats.parse):
3152         (ICStats.dumpStats):
3153         (usage):
3154
3155 2019-04-10  Alex Christensen  <achristensen@webkit.org>
3156
3157         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
3158         https://bugs.webkit.org/show_bug.cgi?id=196809
3159         <rdar://49800762>
3160
3161         Reviewed by Brady Eidson.
3162
3163         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
3164         (TEST):
3165
3166 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
3167
3168         requestAnimationFrame should execute before the next frame
3169         https://bugs.webkit.org/show_bug.cgi?id=177484
3170
3171         Reviewed by Simon Fraser.
3172
3173         Add trace points for the page RenderingUpdate.
3174
3175         * Tracing/SystemTracePoints.plist:
3176
3177 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
3178
3179         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
3180         https://bugs.webkit.org/show_bug.cgi?id=196760
3181
3182         Reviewed by Don Olmstead.
3183
3184         vswhere.exe has been bundled since Visual Studio 2017 version
3185         15.2. We shouldn't download vswhere.exe.
3186
3187         * Scripts/build-jsc: Do not call update-vswhere.py.
3188         * Scripts/build-webkit: Ditto.
3189         * Scripts/update-vswhere.py: Removed.
3190         * Scripts/webkitdirs.pm:
3191         (requireModulesForVSWhere): Deleted.
3192         (pickCurrentVisualStudioInstallation): Deleted.
3193         (visualStudioInstallDirVSWhere): Return the latest installed VS
3194         installation path by using the bundled vswhere.exe.
3195         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
3196         (visualStudioInstallDirFallback): Removed.
3197
3198 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
3199
3200         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
3201         https://bugs.webkit.org/show_bug.cgi?id=196780
3202
3203         Reviewed by Alexey Proskuryakov.
3204
3205         * BuildSlaveSupport/ews-build/steps.py:
3206         * BuildSlaveSupport/ews-build/steps_unittest.py:
3207
3208 2019-04-10  Alex Christensen  <achristensen@webkit.org>
3209
3210         Add SPI WKNavigationResponse._downloadAttribute
3211         https://bugs.webkit.org/show_bug.cgi?id=196755
3212         <rdar://49587365>
3213
3214         Reviewed by Brady Eidson.
3215
3216         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
3217         (-[NavigationResponseTestDelegate navigationResponse]):
3218         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
3219         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
3220         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3221         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
3222         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3223         (readRequest):
3224         (writeResponse):
3225         (TEST):
3226
3227 2019-04-10  Tim Horton  <timothy_horton@apple.com>
3228
3229         Add modern API for overriding the page's specified viewport configuration
3230         https://bugs.webkit.org/show_bug.cgi?id=167734
3231         <rdar://problem/30331795>
3232
3233         Reviewed by Simon Fraser.
3234
3235         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3236         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
3237
3238 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
3239
3240         Add support for incremental bytecode cache updates
3241         https://bugs.webkit.org/show_bug.cgi?id=195000
3242
3243         Reviewed by Filip Pizlo.
3244
3245         Exit when the initial run to generate bytecode fails.
3246
3247         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
3248
3249 2019-04-10  Alex Christensen  <achristensen@webkit.org>
3250
3251         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
3252         https://bugs.webkit.org/show_bug.cgi?id=196744
3253         <rdar://49415309>
3254
3255         Reviewed by Chris Dumez.
3256
3257         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
3258         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3259
3260 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
3261
3262         Add a way to opt into modern compatibility mode in layout tests
3263         https://bugs.webkit.org/show_bug.cgi?id=196770
3264         <rdar://problem/49777550>
3265
3266         Reviewed by Antoine Quint.
3267
3268         Add a new test option to enable modern compatibility mode in layout tests.
3269
3270         * WebKitTestRunner/TestController.cpp:
3271         (WTR::updateTestOptionsFromTestHeader):
3272         * WebKitTestRunner/TestController.h:
3273         * WebKitTestRunner/TestOptions.h:
3274         (WTR::TestOptions::hasSameInitializationOptions const):
3275         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3276         (WTR::TestController::platformCreateWebView):
3277         (WTR::TestController::enableModernCompatibilityMode):
3278
3279 2019-04-10  Andy Estes  <aestes@apple.com>
3280
3281         Try to fix the 32-bit watchOS build.
3282
3283         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3284         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
3285
3286 2019-04-10  Antoine Quint  <graouts@apple.com>
3287
3288         Enable Pointer Events on watchOS
3289         https://bugs.webkit.org/show_bug.cgi?id=196771
3290         <rdar://problem/49040909>
3291
3292         Reviewed by Dean Jackson.
3293
3294         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3295
3296 2019-04-10  Philippe Normand  <pnormand@igalia.com>
3297
3298         Unreviewed. Fix WPE accessibility tests after r244059.
3299
3300         We are failing to load the injected bundle due to undefined symbol
3301         AccessibilityUIElement::replaceTextInRange().
3302
3303         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
3304         (WTR::AccessibilityUIElement::replaceTextInRange):
3305
3306 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
3307
3308         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
3309         https://bugs.webkit.org/show_bug.cgi?id=196727
3310
3311         Reviewed by Fujii Hironori.
3312
3313         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3314         (WebKitBrowserWindow::create):
3315
3316 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
3317
3318         [ews-build] Add unit tests for PrintConfiguration
3319         https://bugs.webkit.org/show_bug.cgi?id=196752
3320
3321         Reviewed by Dewei Zhu.
3322
3323         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3324
3325 2019-04-09  Keith Rollin  <krollin@apple.com>
3326
3327         Unreviewed build maintenance -- update .xcfilelists.
3328
3329         * DumpRenderTree/DerivedSources-input.xcfilelist:
3330         * DumpRenderTree/DerivedSources-output.xcfilelist:
3331
3332 2019-04-09  Zalan Bujtas  <zalan@apple.com>
3333
3334         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
3335         https://bugs.webkit.org/show_bug.cgi?id=196743
3336         <rdar://problem/43897551>
3337
3338         Reviewed by Tim Horton.
3339
3340         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
3341         (TEST):
3342
3343 2019-04-09  Youenn Fablet  <youenn@apple.com>
3344
3345         Close service worker database on network process suspension
3346         https://bugs.webkit.org/show_bug.cgi?id=196623
3347         <rdar://problem/48930869>
3348
3349         Reviewed by Alex Christensen.
3350
3351         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3352
3353 2019-04-09  Daniel Bates  <dabates@apple.com>
3354
3355         [iPad] Should open popover when the spacebar is pressed
3356         https://bugs.webkit.org/show_bug.cgi?id=196360
3357         <rdar://problem/49389129>
3358
3359         Reviewed by Brent Fulgham.
3360
3361         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
3362
3363         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3364         (WTR::UIScriptController::isShowingPopover const): Added.
3365         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
3366         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
3367         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3368         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
3369         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3370         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
3371         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
3372         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
3373         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
3374         (WTR::UIScriptController::isShowingPopover const): Added.
3375         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
3376         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
3377         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3378         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3379         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3380         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
3381         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
3382         (-[TestRunnerWKWebView _willPresentPopover]): Added.
3383         (-[TestRunnerWKWebView _didDismissPopover]): Added.
3384         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3385         (WTR::UIScriptController::isShowingPopover const): Added.
3386         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
3387         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
3388
3389 2019-04-09  Alex Christensen  <achristensen@webkit.org>
3390
3391         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
3392         https://bugs.webkit.org/show_bug.cgi?id=196665
3393         <rdar://45115669>
3394
3395         Reviewed by Geoff Garen.
3396
3397         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3398         (goBack):
3399         (+[SimpleLookupContext sharedLookupContext]):
3400         (-[SimpleLookupContext lookUpURL:completionHandler:]):
3401         (TEST):
3402         (+[Simple3LookupContext sharedLookupContext]): Deleted.
3403         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
3404
3405 2019-04-09  John Wilander  <wilander@apple.com>
3406
3407         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
3408         https://bugs.webkit.org/show_bug.cgi?id=196558
3409         <rdar://problem/47650245>
3410
3411         Reviewed by Youenn Fablet.
3412
3413         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3414         (TestWebKitAPI::TEST):
3415             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
3416
3417 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
3418
3419         [CMake] Apple builds should use ICU_INCLUDE_DIRS
3420         https://bugs.webkit.org/show_bug.cgi?id=196720
3421
3422         Reviewed by Konstantin Tokarev.
3423
3424         * TestWebKitAPI/PlatformMac.cmake:
3425
3426 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
3427
3428         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
3429         https://bugs.webkit.org/show_bug.cgi?id=196694
3430         <rdar://problem/48388734>
3431
3432         Rubber-stamped by Aakash Jain.
3433
3434         * Scripts/webkitpy/port/image_diff.py:
3435         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
3436         * Scripts/webkitpy/port/server_process.py:
3437         (ServerProcess.has_available_stdout): Check if stdout has data in it.
3438         (ServerProcess._wait_for_data_and_update_buffers_using_select):
3439         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
3440         * Scripts/webkitpy/port/server_process_mock.py:
3441         (MockServerProcess.has_available_stdout):
3442         * Scripts/webkitpy/port/server_process_unittest.py:
3443         (TestServerProcess.serial_test_basic):
3444
3445 2019-04-09  Jer Noble  <jer.noble@apple.com>
3446
3447         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
3448         https://bugs.webkit.org/show_bug.cgi?id=196097
3449
3450         Reviewed by Eric Carlson.
3451
3452         Drive-by bug fix: allow tests to play audio without a user gesture by default.
3453
3454         * DumpRenderTree/mac/DumpRenderTree.mm:
3455         (resetWebPreferencesToConsistentValues):
3456         * WebKitTestRunner/TestController.cpp:
3457         (WTR::TestController::resetPreferencesToConsistentValues):
3458
3459 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
3460
3461         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
3462         https://bugs.webkit.org/show_bug.cgi?id=196690
3463
3464         Reviewed by Michael Catanzaro.
3465
3466         * QueueStatusServer/config/queues.py:
3467         * Scripts/webkitpy/common/config/ews.json:
3468         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3469         (test_ews_name):
3470
3471 2019-04-09  Chris Dumez  <cdumez@apple.com>
3472
3473         Loads using loadHTMLString() cause flashing when process-swapping
3474         https://bugs.webkit.org/show_bug.cgi?id=196714
3475         <rdar://problem/49637354>
3476
3477         Reviewed by Antti Koivisto.
3478
3479         Add API test coverage.
3480
3481         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3482
3483 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
3484
3485         Unreviewed. Fix ATK accessibility tests after r244059.
3486
3487         We are failing to load the injected bundle due to undefined symbol
3488         AccessibilityUIElement::replaceTextInRange().
3489
3490         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3491         (WTR::AccessibilityUIElement::replaceTextInRange):
3492
3493 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
3494
3495         AX: Support API: accessibilityReplaceRange:withText
3496         https://bugs.webkit.org/show_bug.cgi?id=196636
3497
3498         Unreviewed build fix for Windows port.
3499
3500         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
3501         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
3502
3503 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
3504
3505         [CMake][WinCairo] Separate copied headers into different directories
3506         https://bugs.webkit.org/show_bug.cgi?id=196655
3507
3508         Reviewed by Michael Catanzaro.
3509
3510         * DumpRenderTree/CMakeLists.txt:
3511         * MiniBrowser/win/CMakeLists.txt:
3512         * TestWebKitAPI/CMakeLists.txt:
3513         * TestWebKitAPI/PlatformWin.cmake:
3514
3515 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
3516
3517         Log stack-trace for run-webkit-tests when interrupted
3518         https://bugs.webkit.org/show_bug.cgi?id=176393
3519         <rdar://problem/34262310>
3520
3521         Reviewed by Lucas Forschler.
3522
3523         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
3524         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
3525         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
3526         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
3527         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
3528         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3529         (main): Set handlers to log stack trace on interruption.
3530
3531 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
3532
3533         AX: Support API: accessibilityReplaceRange:withText
3534         https://bugs.webkit.org/show_bug.cgi?id=196636
3535
3536         Unreviewed build fix for Windows port.
3537
3538         * DumpRenderTree/AccessibilityUIElement.cpp:
3539         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
3540
3541 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
3542
3543         [ews-build] Scripts using Buildbot API have CORS error
3544         https://bugs.webkit.org/show_bug.cgi?id=196709
3545
3546         Reviewed by Alexey Proskuryakov.
3547
3548         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
3549
3550 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
3551
3552         AX: Support API: accessibilityReplaceRange:withText
3553         https://bugs.webkit.org/show_bug.cgi?id=196636
3554
3555         Reviewed by Daniel Bates.
3556
3557         * DumpRenderTree/AccessibilityUIElement.cpp:
3558         (replaceTextInRangeCallback):
3559         (AccessibilityUIElement::replaceTextInRange):
3560         (AccessibilityUIElement::getJSClass):
3561         * DumpRenderTree/AccessibilityUIElement.h:
3562         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3563         (AccessibilityUIElement::replaceTextInRange):
3564         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3565         (AccessibilityUIElement::replaceTextInRange):
3566         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3567         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3568         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3569         (WTR::AccessibilityUIElement::replaceTextInRange):
3570         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3571         (WTR::AccessibilityUIElement::replaceTextInRange):
3572
3573 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3574
3575         [iOS] Do not allow starting selection drags when selection views are not visible
3576         https://bugs.webkit.org/show_bug.cgi?id=196686
3577         <rdar://problem/49399192>
3578
3579         Reviewed by Tim Horton.
3580
3581         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
3582         also add some new API tests to cover scenarios where the web view is not first responder.
3583
3584         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3585         (TestWebKitAPI::TEST):
3586         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
3587
3588         Add a switch to optionally make the web view first responder when starting the simulated drag.
3589
3590         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3591         (-[DragAndDropSimulator initWithWebView:]):
3592         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
3593
3594 2019-04-08  Justin Fan  <justin_fan@apple.com>
3595
3596         [Web GPU] Fix Web GPU experimental feature on iOS
3597         https://bugs.webkit.org/show_bug.cgi?id=196632
3598
3599         Reviewed by Myles C. Maxfield.
3600
3601         Properly make Web GPU available on iOS 11+.
3602
3603         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3604
3605 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
3606
3607         [ews-build] Do not upload archive when Compile Fails
3608         https://bugs.webkit.org/show_bug.cgi?id=196674
3609
3610         Reviewed by Alexey Proskuryakov.
3611
3612         * BuildSlaveSupport/ews-build/factories.py:
3613         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
3614         * BuildSlaveSupport/ews-build/steps.py:
3615         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
3616         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
3617         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
3618
3619 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
3620
3621         Enable DFG on MIPS
3622         https://bugs.webkit.org/show_bug.cgi?id=196689
3623
3624         Reviewed by Žan Doberšek.
3625
3626         Since the bytecode change, we enabled the baseline JIT on mips in
3627         r240432, but DFG is still missing. With this change, all tests are
3628         passing on a ci20 board.
3629
3630         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
3631
3632 2019-04-08  Philippe Normand  <pnormand@igalia.com>
3633
3634         [Flatpak] Second run update-webkitwpe-flatpak fails
3635         https://bugs.webkit.org/show_bug.cgi?id=192702
3636
3637         Reviewed by Carlos Garcia Campos.
3638
3639         * flatpak/flatpakutils.py:
3640         (FlatpakObject.flatpak): Fix typo.
3641         (FlatpakPackage.install): When installing, also update to the configured remote commit.
3642         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
3643
3644 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
3645
3646         [GTK][WPE] outlook.live.com displays old-fashioned UI
3647         https://bugs.webkit.org/show_bug.cgi?id=196642
3648
3649         Reviewed by Carlos Garcia Campos.
3650
3651         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3652         (TestWebKitAPI::TEST): New Mac platform quirk test.
3653
3654 2019-04-07  Commit Queue  <commit-queue@webkit.org>
3655
3656         Unreviewed, rolling out r243956.
3657         https://bugs.webkit.org/show_bug.cgi?id=196688
3658
3659         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested