1 2015-01-22 Ryosuke Niwa <rniwa@webkit.org>
3 Add a build flag for ES6 class syntax
4 https://bugs.webkit.org/show_bug.cgi?id=140760
6 Reviewed by Michael Saboff.
8 * Scripts/webkitperl/FeatureList.pm:
10 2015-01-22 Daniel Bates <dabates@apple.com>
12 [iOS] run-webkit-tests --ios-sim dies with an error; fails to parse Apple Internal
13 runtime in simctl output
14 https://bugs.webkit.org/show_bug.cgi?id=140751
16 Reviewed by David Kilzer.
18 Following the fix for <rdar://problem/19444383>, run-webkit-tests --ios-sim dies
19 with an error because it does not know how to parse the output of the simctl tool
20 to identify an Apple Internal runtime.
22 * Scripts/webkitpy/xcode/simulator.py:
23 (Runtime.__init__): Add parameter is_internal_runtime (defaults to False).
24 (Runtime.__eq__): Take is_internal_runtime when comparing two Runtime objects for equality.
25 (Runtime.__repr__): Update printable representation of Runtime object to indicate whether
26 the runtime is an internal runtime.
27 (Simulator): Update regular expressions runtime_re and version_re to match an internal runtime.
28 (Simulator._parse_runtimes): Pass is_internal_runtime to the Runtime constructor with the
30 (Simulator._parse_devices): Pass argument is_internal_runtime to Simulator.runtime() so that
31 it updates the appropriate Runtime object.
32 (Simulator.runtime): Added optional parameter, is_internal_runtime. Modified to support
33 looking up a Runtime object for an internal runtime.
35 2015-01-22 Alexey Proskuryakov <ap@apple.com>
37 LeaksViewer doesn't show recent builds if there are less than 10
38 https://bugs.webkit.org/show_bug.cgi?id=140716
40 Reviewed by Tim Horton.
42 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
44 2015-01-22 Lucas Forschler <lforschler@apple.com>
46 Add Apple build slaves.
47 Fixed text alignment for slave list.
51 * BuildSlaveSupport/build.webkit.org-config/config.json:
53 2015-01-21 Lucas Forschler <lforschler@apple.com>
55 Teach build.webkit.org about bot308 and bot309.
59 * BuildSlaveSupport/build.webkit.org-config/config.json:
61 2015-01-21 Lucas Forschler <lforschler@apple.com>
63 Add two Apple Mavericks slaves.
67 * BuildSlaveSupport/build.webkit.org-config/config.json:
69 2015-01-21 Daniel Bates <dabates@apple.com>
71 Add iOS WebKit1 TestExpectation file
72 https://bugs.webkit.org/show_bug.cgi?id=140739
74 Reviewed by David Kilzer.
76 Teach run-webkit-tests to look for iOS WebKit1-specific test results and
77 expectations in directory LayoutTests/platform/ios-simulator-wk1.
79 * Scripts/webkitpy/port/ios.py:
80 (IOSSimulatorPort.default_baseline_search_path):
82 2015-01-21 David Kilzer <ddkilzer@apple.com>
84 [iOS] Update configure-xcode-for-ios-development to copy missing headers to iphoneos SDK
85 <http://webkit.org/b/140704>
87 Reviewed by Daniel Bates.
89 * Scripts/configure-xcode-for-ios-development:
91 - Remove FIXME addressed by r178709.
92 - Call copyMissingHeadersToIPhoneOSSDKIfNeeded().
93 (copyMissingHeadersToIPhoneOSSDKIfNeeded): Add method to copy
94 missing headers from iphonesimulator SDK to iphoneos SDK.
95 (sdkDirectory): Add method that returns SDK directory.
96 (sdkPlatformDirectory): Extract method from
97 xcodeSDKSpecificationsPath() that returns SDK platform
99 (xcodeSDKSpecificationsPath): Update to use
100 sdkPlatformDirectory().
102 2015-01-21 Alexey Proskuryakov <ap@apple.com>
104 https://build.webkit.org/dashboard/metrics.html fails because of ios-ews
105 https://bugs.webkit.org/show_bug.cgi?id=140731
107 Reviewed by Tim Horton.
109 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
110 (Analyzer.prototype._analyzeAllBubblesPerformance): Corrected a typo.
112 2015-01-21 Brent Fulgham <bfulgham@apple.com>
114 [Win] eventSender does not support scalePageBy
115 https://bugs.webkit.org/show_bug.cgi?id=140726
116 <rdar://problem/19549865>
118 Reviewed by Dean Jackson.
120 * DumpRenderTree/win/EventSender.cpp:
121 (scalePageByCallback): Provide implementation using new WebView method.
123 2015-01-21 Lucas Forschler <lforschler@apple.com>
125 Remove Apple Mountain Lion Build & Test slaves.
129 * BuildSlaveSupport/build.webkit.org-config/config.json:
131 2015-01-21 Csaba Osztrogonác <ossy@webkit.org>
133 Remove ENABLE(INSPECTOR) ifdef guards
134 https://bugs.webkit.org/show_bug.cgi?id=140668
136 Reviewed by Darin Adler.
138 * DumpRenderTree/mac/TestRunnerMac.mm:
139 (TestRunner::showWebInspector):
140 (TestRunner::closeWebInspector):
141 (TestRunner::evaluateInWebInspector):
142 * Scripts/webkitperl/FeatureList.pm:
143 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
144 (WTR::TestRunner::showWebInspector):
145 (WTR::TestRunner::closeWebInspector):
146 (WTR::TestRunner::evaluateInWebInspector):
147 * WebKitTestRunner/TestInvocation.cpp:
148 (WTR::TestInvocation::invoke):
150 2015-01-20 Alexey Proskuryakov <ap@apple.com>
152 Update build.webkit.org/dashboard to match current Mac queues.
154 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion.png: Removed.
155 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion@2x.png: Removed.
156 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png: Removed.
157 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png: Removed.
158 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
159 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
160 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
161 (table.queue-grid tr.platform.mac-os-x-mountain-lion img.logo): Deleted.
162 (table.queue-grid tr.platform.mac-os-x-lion img.logo): Deleted.
164 2015-01-20 Lucas Forschler <lforschler@apple.com>
166 Update Apple MountainLion Leaks slave to Yosemite
167 Update Apple MountainLion Release (32-bit) Build slave to Yosemite
171 * BuildSlaveSupport/build.webkit.org-config/config.json:
173 2015-01-20 Lucas Forschler <lforschler@apple.com>
175 Update LeaksViewer from MountainLion to Yosemite
177 Reviewed by Alexey Proskuryakov.
179 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
180 (LeaksViewer._displayURLPrompt):
182 2015-01-20 Jake Nielsen <jacob_nielsen@apple.com>
184 Fix EWS python unit tests and address code comments as per 140476
185 https://bugs.webkit.org/show_bug.cgi?id=140637
187 Reviewed by David Kilzer.
189 * Scripts/webkitpy/port/base.py:
192 Adds DEFAULT_ARCHITECTURE member.
194 Removes architecture member and instead uses
195 self.get_option('architecture'). Also removes redundant architecture
197 (Port.set_architecture):
198 Adds a setter for the architecture variable to be able to set a flag
200 (Port.test_configuration):
201 Uses self.architecture() instead of self._architecture.
202 * Scripts/webkitpy/port/ios.py:
203 Overrides DEFAULT_ARCHITECTURE.
205 (IOSPort.determine_full_port_name):
206 Uses subprocess.check_output instead of Popen. Uses rstrip instead of
207 strip. Fixes regex to not match arbitrary characters after the
208 relevent digits are matched.
210 Removes old _architecture defaulting strategy.
211 (IOSPort._build_driver_flags):
212 Uses self.architecture() instead of self._architecture.
214 Overrides DEFAULT_ARCHITECTURE.
215 (IOSSimulatorPort.__init__):
216 Removes old _architecture defaulting strategy.
217 * Scripts/webkitpy/port/mac.py:
219 Overrides DEFAULT_ARCHITECTURE.
221 Removes old _architecture defaulting strategy.
222 * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
223 (AbstractEarlyWarningSystem.run_command):
224 Checks the did_override_architecture flag to determine whether to add
225 the --architecture option.
226 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
227 Uses ews.architecture rather than trying to discern the correct
228 architecture using a port object.
229 (EarlyWarningSystemTest._default_expected_logs):
230 * Scripts/webkitpy/tool/commands/queues.py:
231 Removes use of optparse, and removes the import statement.
232 (AbstractQueue.__init__):
233 (PatchProcessingQueue.begin_work_queue):
235 2015-01-20 Sam Weinig <sam@webkit.org>
237 Attempt to fix Mountain Lion and EFL tests.
239 * WebKitTestRunner/TestController.cpp:
240 (WTR::TestController::initialize):
241 Disable Process-per-tab and network process on Mountain Lion and EFL.
243 2015-01-20 Darin Adler <darin@apple.com>
245 Remove SVGElementInstanceList, m_instanceUnderMouse, DUMP_INSTANCE_TREE, DUMP_SHADOW_TREE
246 https://bugs.webkit.org/show_bug.cgi?id=140679
248 Reviewed by Anders Carlsson.
250 * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
251 Removed a reference to SVGElementInstanceList.
253 2015-01-20 Michael Catanzaro <mcatanzaro@igalia.com>
255 [GTK] WebViewTest should prohibit overriding initializeWebExtensions()
256 https://bugs.webkit.org/show_bug.cgi?id=140028
258 Reviewed by Carlos Garcia Campos.
260 This won't work as expected, since this function is called before the
261 WebViewTest constructor completes.
263 * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
265 2015-01-20 David Kilzer <ddkilzer@apple.com>
267 configure-xcode-for-ios-development needs to update iPhoneOS SDK
268 <http://webkit.org/b/140661>
270 Reviewed by Daniel Bates.
272 * Scripts/configure-xcode-for-ios-development: Add for() loop to
273 run createXcodeSpecificationFilesForSDKIfNeeded() for both
274 "iphoneos" and "iphonesimulator" SDKs.
275 (createXcodeSpecificationFilesForSDKIfNeeded): Extracted from
276 the main body of the script.
278 2015-01-20 Tomas Popela <tpopela@redhat.com>
280 [GTK] Add API to set the web view editable into WebKit2 GTK+ API
281 https://bugs.webkit.org/show_bug.cgi?id=139443
283 Reviewed by Carlos Garcia Campos.
285 Create the new test cases for setting the editable property on the web
286 view and on the contenteditable enabled document. Also rework the
287 current tests that are expecting that the web view is editable.
289 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
291 (testWebViewEditorCutCopyPasteNonEditable):
292 (testWebViewEditorCutCopyPasteEditable):
293 (testWebViewEditorSelectAllNonEditable):
294 (testWebViewEditorSelectAllEditable):
295 (runEditorEditableCutTests):
296 (testWebViewEditorEditableOnNonEditable):
297 (testWebViewEditorEditableOnContentEditable):
298 (testWebViewEditorNonEditable):
300 * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
301 (WebViewTest::isEditable):
302 (WebViewTest::setEditable):
304 2015-01-20 Carlos Garcia Campos <cgarcia@igalia.com>
306 [GTK] Add an option to create WebKitWebView snapshots with transparent background
307 https://bugs.webkit.org/show_bug.cgi?id=140617
309 Reviewed by Gustavo Noronha Silva.
311 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
312 (testWebViewSnapshot): Check that the same snapshot with
313 transparent background is different than the default one filled
316 2015-01-19 Carlos Garcia Campos <cgarcia@igalia.com>
318 [GTK] Add API to change the WebKitWebView background color
319 https://bugs.webkit.org/show_bug.cgi?id=140610
321 Reviewed by Gustavo Noronha Silva.
323 Add --bg-color command line option to MiniBrowser to be able to
324 manually test the API passing any RGBA color to MiniBrowser.
325 Also add a simple unit test to check that getting and setting
326 colors from the API point of view.
328 * MiniBrowser/gtk/BrowserWindow.c:
329 (browser_window_set_background_color):
330 * MiniBrowser/gtk/BrowserWindow.h:
331 * MiniBrowser/gtk/main.c:
332 (createBrowserWindow):
333 (parseBackgroundColor):
334 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
335 (testWebViewBackgroundColor):
338 2015-01-19 Brent Fulgham <bfulgham@apple.com>
340 [Win] Layout Test fast/xmlhttprequest/xmlhttprequest-no-file-access.html is failing
341 https://bugs.webkit.org/show_bug.cgi?id=140665
343 Reviewed by Brian Burg.
345 * DumpRenderTree/win/UIDelegate.cpp:
346 (UIDelegate::webViewAddMessageToConsole): Correct string search and concatenation to
347 match expected test output.
349 2015-01-19 Benjamin Poulain <bpoulain@apple.com>
351 Remove the support for custom suffixes on ChangeLog
352 https://bugs.webkit.org/show_bug.cgi?id=140648
354 Reviewed by David Kilzer.
356 Custom suffixes were used for the iOS branch of WebKit.
357 Now that everything is opensource, there is no need for it.
359 * Scripts/VCSUtils.pm:
360 (changeLogSuffix): Deleted.
361 (changeLogFileName): Deleted.
362 * Scripts/commit-log-editor:
363 * Scripts/prepare-ChangeLog:
364 (getLatestChangeLogs):
365 (generateNewChangeLogs):
367 * Scripts/resolve-ChangeLogs:
370 2015-01-19 Timothy Horton <timothy_horton@apple.com>
372 Adjust naming of action menu SPI
373 https://bugs.webkit.org/show_bug.cgi?id=140644
374 <rdar://problem/19448129>
376 Reviewed by Brian Weinstein.
378 * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
379 (-[ActionMenusTestWKView runMenuSequenceAtPoint:preDidCloseMenuHandler:]):
380 (TestWebKitAPI::TEST):
382 2015-01-19 Michael Catanzaro <mcatanzaro@igalia.com>
384 [GTK] Generate the make dist manifest from a CMake template file
385 https://bugs.webkit.org/show_bug.cgi?id=139387
387 Reviewed by Martin Robinson.
389 Remove the code that performs variable substitution on manifest.txt.
390 Replace the custom variables used in that file with CMake variables.
393 (Manifest.add_directory):
394 (Manifest.get_full_source_path):
395 (Manifest.process_line):
396 (Manifest.resolve_variables): Deleted.
397 (Manifest.get_full_tarball_path): Deleted.
398 * gtk/manifest.txt.in: Renamed from Tools/gtk/manifest.txt.
400 2015-01-19 Brent Fulgham <bfulgham@apple.com>
402 [Win] Correct merge error in last commit.
404 * DumpRenderTree/win/AccessibilityControllerWin.cpp:
405 (findAccessibleObjectById): Undo accidental paste made during landing.
407 2015-01-19 Brent Fulgham <bfulgham@apple.com>
409 [Win] Periodic failure in DumpRenderTree related to WebActionPropertyBag::Read
410 https://bugs.webkit.org/show_bug.cgi?id=139906
412 Reviewed by Dean Jackson.
414 WebKit on Windows was creating uninitialized VARIANT structures, then attempting
415 to use them. This patch fixes that.
417 * DumpRenderTree/win/AccessibilityControllerWin.cpp:
418 (findAccessibleObjectById):
419 (AccessibilityController::focusedElement):
421 (notificationListenerProc):
422 * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
423 (AccessibilityUIElement::getChildAtIndex):
424 (AccessibilityUIElement::titleUIElement):
426 (AccessibilityUIElement::role):
427 (AccessibilityUIElement::valueDescription):
428 (accessibilityState):
429 (AccessibilityUIElement::isChecked):
430 * DumpRenderTree/win/DumpRenderTree.cpp:
431 (dumpFrameScrollPosition):
433 * DumpRenderTree/win/PolicyDelegate.cpp:
434 (PolicyDelegate::decidePolicyForNavigationAction):
435 * DumpRenderTree/win/UIDelegate.cpp:
436 (UIDelegate::exceededDatabaseQuota):
437 * WinLauncher/Common.cpp:
440 2015-01-19 Dean Jackson <dino@apple.com>
442 Add "override" to fix the build with newer clangs.
444 * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
445 (TestWebKitAPI::CalculationDeletionTestNode::operator==):
447 2015-01-19 David Kilzer <ddkilzer@apple.com>
449 [iOS] Do not hard-code iphoneos.internal SDK in buildXCodeProject()
450 <http://webkit.org/b/140623>
452 Reviewed by Daniel Bates.
454 * Scripts/build-webkit: Update help for --device switch.
455 * Scripts/webkitdirs.pm:
456 (determineXcodeSDK): When passing --device, prefer the internal
457 iOS SDK if it exists, else fall back to the external iOS SDK.
458 (buildXCodeProject): Use xcodeSDK() as -sdk argument for
459 xcodebuild instead of trying to sanitize values.
461 2015-01-19 Alexey Proskuryakov <ap@apple.com>
463 "Unknown option: sharedworkerglobalscopeconstructorsfile" when running bindings tests.
464 https://bugs.webkit.org/show_bug.cgi?id=140606
466 Reviewed by Csaba Osztrogonác.
468 * Scripts/webkitpy/bindings/main.py:
469 (BindingsTests.generate_supplemental_dependency):
470 (BindingsTests.main):
472 2015-01-19 Carlos Garcia Campos <cgarcia@igalia.com>
474 [GTK] [WK2] TestWebKitWebView snapshot fails
475 https://bugs.webkit.org/show_bug.cgi?id=120404
477 Reviewed by Žan Doberšek.
479 Rework the test to make sure the snapshot is always created at the
482 * Scripts/run-gtk-tests:
483 (TestRunner): Unskip /webkit2/WebKitWebView/snapshot.
484 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
485 (testWebViewSnapshot): Use a fixed size for the document, and
486 disable scrollbars to make sure the visible area is always the
488 * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
489 (WebViewTest::showInWindowAndWaitUntilMapped): Add optional width
490 and height parameters to create the window with a given size.
491 * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
493 2015-01-18 David Kilzer <ddkilzer@apple.com>
495 iOS EWS queue name should be consistent
496 <http://webkit.org/b/140585>
498 Reviewed by Daniel Bates.
500 * Scripts/webkitpy/common/config/ews.json: Rename 'ios-device'
502 * Scripts/webkitpy/common/config/ports.py: Ditto.
503 (DeprecatedPort.port):
505 * Scripts/webkitpy/port/ios.py: Ditto.
508 * Scripts/webkitpy/port/factory.py:
509 (PortFactory): Re-order PORT_CLASSES so ios.IOSSimulatorPort
510 appears before ios.IOSPort. If this is not done,
511 `run-webkit-tests --ios-simulator` will get the wrong Port class
512 (IOSPort instead of IOSSimulatorPort) due to the way that
513 PortFactory.get() uses prefix matching of <Port>.port_name to
514 find the correct class to use.
516 2015-01-18 Alexey Proskuryakov <ap@apple.com>
518 build.webkit.org/dashboard: OS X EWS is now on Mavericks
519 https://bugs.webkit.org/show_bug.cgi?id=140595
521 Reviewed by Csaba Osztrogonác.
523 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
526 2015-01-17 David Kilzer <ddkilzer@apple.com>
528 Attempt to fix webkitpy tests on Mountain Lion, Mavericks bots
530 * Scripts/webkitpy/port/ios.py:
531 (IOSPort): Add 'ios-device-7' to VERSION_FALLBACK_ORDER so that
532 test-webkitpy doesn't fail since iOS 7.x SDKs are installed on
533 the Mountain Lion and Mavericks bots.
535 2015-01-17 David Kilzer <ddkilzer@apple.com>
537 Attempt to fix webkitpy tests on GTK Linux ports
539 * Scripts/webkitpy/port/ios.py:
540 (IOSPort.determine_full_port_name): Set a sensible default if
541 not running on a Mac platform or if no iOS SDK is installed.
543 2015-01-17 Jake Nielsen <jacob_nielsen@apple.com>
545 Create iOS-EWS client queue
546 https://bugs.webkit.org/show_bug.cgi?id=140476
548 Reviewed by Alexey Proskuryakov.
550 * EWSTools/start-queue-mac.sh:
551 Adds call to configure-xcode-for-ios-development for iOS EWS.
552 * Scripts/webkitpy/common/config/ews.json:
553 Adds the iOS EWS config entry.
554 * Scripts/webkitpy/common/config/ports.py:
555 (DeprecatedPort.port):
556 Adds IOSPort to the port map.
558 (IOSPort.build_webkit_command):
559 Adds --sdk=iphoneos to the webkit build command.
560 * Scripts/webkitpy/port/base.py:
562 Adds an accessor for the architecture member variable.
563 * Scripts/webkitpy/port/factory.py:
565 Adds IOSPort to the port class list.
566 * Scripts/webkitpy/port/ios.py:
567 Adds the IOSPort to encapsulate iOS-specific things.
569 (IOSPort.determine_full_port_name):
571 (IOSPort._build_driver_flags):
572 (IOSPort.operating_system):
573 * Scripts/webkitpy/tool/commands/download_unittest.py:
574 Adds the archetecture option to the mock options.
575 (DownloadCommandsTest._default_options):
576 * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
577 Appends the archetecture option into calls to webkit-patch.
578 (AbstractEarlyWarningSystem.review_patch):
579 (AbstractEarlyWarningSystem.run_command):
580 (AbstractEarlyWarningSystem.load_ews_classes):
581 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
582 Adds logic to soothe the unittest now that --architecture is being
583 thrown around everywhere.
584 (EarlyWarningSystemTest._default_expected_logs):
585 * Scripts/webkitpy/tool/commands/queues.py:
586 Adds glue code to ferry the --architecture option around.
587 (AbstractQueue.__init__):
588 (PatchProcessingQueue.begin_work_queue):
589 * Scripts/webkitpy/tool/steps/abstractstep.py:
590 Adds the archetecture option to all AbstractSteps so that
591 EarlyWarningSystem doesn't start shoving --architecture into
592 unsuspecting commands.
593 (AbstractStep.options):
594 * Scripts/webkitpy/tool/steps/build.py:
595 Translates the --architecture option into an ARCHS= format to pass to
598 * Scripts/webkitpy/tool/steps/options.py:
599 Adds a definition for the --architecture option.
602 2015-01-16 Sam Weinig <sam@webkit.org>
604 Add a basic configuration object for WKView
605 https://bugs.webkit.org/show_bug.cgi?id=140559
607 Reviewed by Anders Carlsson.
609 Add tests for WKPageConfigurationRef.
611 * TestWebKitAPI/PlatformWebView.h:
612 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
613 * TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp: Added.
614 (TestWebKitAPI::TEST):
615 (TestWebKitAPI::didFinishLoadForFrame):
616 (TestWebKitAPI::setPageLoaderClient):
617 * TestWebKitAPI/mac/PlatformWebViewMac.mm:
618 (TestWebKitAPI::PlatformWebView::initialize):
619 (TestWebKitAPI::PlatformWebView::PlatformWebView):
621 2015-01-16 Myles C. Maxfield <mmaxfield@apple.com>
623 WeakPtr functions crash when created with default constructor
624 https://bugs.webkit.org/show_bug.cgi?id=140479
626 Reviewed by Andreas Kling.
628 Add WeakPtr API tests.
630 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
631 * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: Added.
632 * TestWebKitAPI/Tests/WTF/Ref.cpp: Update to not use copy constructor.
634 2015-01-16 Chris Dumez <cdumez@apple.com>
636 Regression(r178586): Caused webkitpy.w3c.test_converter_unittest.W3CTestConverterTest.test_convert_prefixed_properties to fail
637 https://bugs.webkit.org/show_bug.cgi?id=140568
639 Reviewed by Alexey Proskuryakov.
641 Fix the script parsing CSSPropertyNames.in to stop splitting lines
642 on '=' sign. The '=' sign is also used in StyleBuilder parameters:
643 e.g. "Longhands=background-position-x|background-position-y".
644 This would confuse the script and treat this as a CSS property:
645 "background-position-x|background-position-y".
647 We now split on white space and treat the first string on the line
648 to be the property name (this is the syntax in this file).
650 * Scripts/webkitpy/w3c/test_converter.py:
651 (_W3CTestConverter.__init__):
652 (_W3CTestConverter.read_webkit_prefixed_css_property_list):
654 2015-01-16 Daniel Bates <dabates@apple.com>
656 REGRESSION (r171968): run-safari --simulator fails to launch Safari on iOS
657 https://bugs.webkit.org/show_bug.cgi?id=135589
659 Reviewed by David Kilzer.
661 Derived from a patch by David Farler.
663 Following the removal IPhoneSimulatorNotification.pm in <http://trac.webkit.org/changeset/171968>
664 run-safari --simulator fails to launch Safari on iOS. We need to implement run-safari
665 in terms of the simctl command line utility.
667 * Scripts/webkitdirs.pm: Added constant SIMULATOR_DEVICE_STATE_BOOTED.
668 (eraseIOSSimulatorDevice): Added.
669 (bootedIOSSimulatorDevice): Added.
670 (iosSimulatorApplicationsPath): Added.
671 (installedMobileSafariBundle): Implemented in terms of iosSimulatorApplicationsPath().
672 (openIOSSimulator): Modified to launch iOS Simulator using OPEN(1).
673 (quitIOSSimulator): Added.
674 (iosSimulatorDeviceByName): Modified to find the first simulator device that matches
675 the specified name and currently selected iOS runtime.
676 (isIOSSimulatorSystemInstalledApp): Added.
677 (runIOSWebKitAppInSimulator): Modified to use simctl launch to launch an app in the simulator.
678 (deleteiOSSimulatorDevice): Deleted.
679 (loadIPhoneSimulatorNotificationIfNeeded): Deleted.
680 (installAndLaunchIOSWebKitAppInSimulator): Deleted.
682 2015-01-16 Alex Christensen <alex.christensen@flexsim.com>
684 Resurrect the WinCairo bot.
685 https://bugs.webkit.org/show_bug.cgi?id=139908
687 Reviewed by Csaba Osztrogonác.
689 * BuildSlaveSupport/build.webkit.org-config/config.json:
690 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
691 (appendCustomBuildFlags):
692 * BuildSlaveSupport/test-result-archive:
693 (archiveTestResults):
694 Add WinCairo buildbot.
696 2015-01-16 Chris Dumez <cdumez@apple.com>
698 webkit-patch should auto-install the keyring python module
699 https://bugs.webkit.org/show_bug.cgi?id=140547
701 Reviewed by David Kilzer.
703 Auto-install the keyring python module. This is the module that
704 webkit-patch uses for cross-platform access to the keyring
707 Without this module, if the password if not in the keychain,
708 webkit-patch will keep asking for your username / password and
711 * Scripts/webkitpy/common/net/credentials.py:
712 * Scripts/webkitpy/thirdparty/__init__.py:
713 (AutoinstallImportHook.find_module):
714 (AutoinstallImportHook._install_keyring):
716 2015-01-15 Csaba Osztrogonác <ossy@webkit.org>
718 Remove ENABLE(SQL_DATABASE) guards
719 https://bugs.webkit.org/show_bug.cgi?id=140434
721 Reviewed by Darin Adler.
723 * Scripts/webkitperl/FeatureList.pm:
725 2015-01-15 Daniel Bates <dabates@apple.com>
727 [iOS] REGRESSION (r174642): DumpRenderTree.app test may dump result twice
728 https://bugs.webkit.org/show_bug.cgi?id=139685
729 <rdar://problem/19281317>
731 Reviewed by Simon Fraser.
733 Fixes an issue where a test in DumpRenderTree.app may dump its result twice. In particular,
734 the test LayoutTests/fast/dom/gc-10.html may dump its result twice.
736 Following <http://trac.webkit.org/changeset/174642>, we dump the test result asynchronously
737 as opposed to synchronously. So, the WebThread or the main thread may perform other tasks
738 before DRT dumps the output of a test. In particular, the WebThread may start a new page
739 load (say, as a result of continued JavaScript execution), which will ultimately lead to
740 dumping the test result again. Instead we want DRT to dump the test result synchronously
741 such that we capture the state of the web page either when the page is loaded or when
742 window.testRunner.notifyDone() is called.
744 * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
745 (createBitmapContextFromWebView): Moved logic to re-enable tile painting and update the
746 state of the display from here to updateDisplay(). Added call to -[CATransaction flush] to
747 flush CA transactions to the window.
748 * DumpRenderTree/mac/DumpRenderTree.mm:
749 (updateDisplay): Added iOS-specific code to update tiles and tell WebKit to flush
750 compositing changes to ensure that we have up-to-date tile content for a pixel/ref-test.
751 (dump): Renamed; formerly named dumpTestResults().
752 (displayWebView): Removed outdated FIXME comment. Added FIXME comment to investigate
753 enabling repaint support on iOS.
754 (-[DumpRenderTree _deferDumpToMainThread]): Deleted.
755 (-[DumpRenderTree _waitForWebThreadThenDump]): Deleted.
756 (dumpTestResults): Deleted.
758 2015-01-15 Brent Fulgham <bfulgham@apple.com>
760 [Win] Miscellaneous DRT fixes
761 https://bugs.webkit.org/show_bug.cgi?id=116562
763 Reviewed by Tim Horton.
765 While investigating the cause of several Windows crashes, I found:
766 (1) Messy conversions to and from BSTR types
767 (2) Weird mixes of wide-string and narrow string conversions
768 (3) Passing nullptr to some CoreFoundation routines that do not
769 permit null arguments.
770 (4) Commands to link the executable to the VS2005 runtime.
772 This patch cleans up these issues to improve DRT reliability on
775 * DumpRenderTree/cg/ImageDiffCG.cpp:
776 (main): Get rid of VS2005 runtime linking.
777 * DumpRenderTree/win/DumpRenderTree.cpp:
778 (urlSuitableForTestResult): Protect against being asked
779 to process an empty URL.
780 (dumpHistoryItem): Do BSTR string building using _bstr_t, rather
781 than converting to/from wchar_t buffers.
782 (runTest): Simplify string and BSTR handling.
783 (createWebViewAndOffscreenWindow): Ditto.
784 (main): Get rid of VS2005 runtime linking.
785 * DumpRenderTree/win/TestRunnerWin.cpp:
786 (jsStringRefToWString): Simplify code.
787 (TestRunner::pathToLocalResource):
788 (TestRunner::setUserStyleSheetLocation):
789 * TestWebKitAPI/win/main.cpp: Get rid of
790 VS2005 runtime linking.
791 * win/DLLLauncher/DLLLauncherMain.cpp:
794 2015-01-15 Alexey Proskuryakov <ap@apple.com>
796 Stop hardcoding mac-mountainlion in commit queue
797 https://bugs.webkit.org/show_bug.cgi?id=140492
799 Reviewed by Anders Carlsson.
801 Use "mac", not "mac-<platform>". This matches how EWS queues are initialized, and
802 there should be no change in behavior, because:
803 1. PatchProcessingQueue converts the name with _new_port_name_from_old() before
804 using it to create a port object.
805 2. Although it doesn't convert the name before using DeprecatedPort.port(), it
806 is actually correct to use "mac" for the name there. We only used to get the expected
807 behavior with "mac-mountainlion" accidentally, because of a fallback to "mac"
808 for unknown deprecated port names.
810 * Scripts/webkitpy/tool/commands/queues.py: (CommitQueue):
812 2015-01-14 Jake Nielsen <jacob_nielsen@apple.com>
814 Create iOS-EWS server queue
815 https://bugs.webkit.org/show_bug.cgi?id=140473
817 Reviewed by Benjamin Poulain.
819 * QueueStatusServer/app.yaml: Updates the SVN version number.
820 * QueueStatusServer/config/queues.py: Add ios-ews queue.
821 * QueueStatusServer/model/queues.py:
822 (Queue.display_name): Makes sure the display name is pretty!
824 2015-01-14 Daniel Bates <dabates@apple.com>
826 [iOS] run-webkit-tests --ios hangs trying to launch iOS Simulator with unavailable runtime
827 https://bugs.webkit.org/show_bug.cgi?id=140301
828 <rdar://problem/19389266>
830 Reviewed by Jon Honeycutt.
832 Fixes an issue where run-webkit-tests --ios will hang when trying to launch iOS Simulator
833 with an unavailable runtime.
835 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
836 (_set_up_derived_options): Modified to access property Simulator.latest_available_runtime,
837 which was formerly called Simulator.latest_runtime. Additionally, raise an exception if the
838 specified runtime cannot be used because it is unavailable.
839 * Scripts/webkitpy/port/ios.py:
840 (IOSSimulatorPort.testing_device): Modified to call Simulator.lookup_or_create_device(),
841 which was formerly named testing_device.
842 * Scripts/webkitpy/xcode/simulator.py:
843 (Device.create): Modified to lookup created device by the UDID returned by simctl, which is
844 more robust than looking up the simulator device by name and runtime. This approach also
845 avoids returning the wrong device due to <rdar://problem/19444383> (simctl list shows
846 unavailable runtimes under the same iOS heading it would use to show it as available).
847 (Simulator.find_device_by_udid): Added.
848 (Simulator.device): Added optional parameter should_ignore_unavailable_devices (defaults
849 to False) to ignore devices that are unavailable (say, because their runtime is unavailable).
850 (Simulator.available_runtimes): Added.
851 (Simulator.latest_available_runtime): Renamed; formerly named latest_runtime. Take advantage
852 of the reverse=True argument to sorted() to sort the list of available runtimes such that the
853 first element of the sorted list is the runtime with the highest version number.
854 (Simulator.lookup_or_create_device): Renamed; formerly named testing_device.
856 2015-01-14 Csaba Osztrogonác <ossy@webkit.org>
858 Remove WK2 Windows cruft
859 https://bugs.webkit.org/show_bug.cgi?id=140440
861 Reviewed by Anders Carlsson.
863 * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp: Removed.
864 * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp: Removed.
865 * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp: Removed.
867 2015-01-13 Hunseop Jeong <hs85.jeong@samsung.com>
869 Fix TestWTF failed in TestWebKitAPI
870 https://bugs.webkit.org/show_bug.cgi?id=140333
872 Reviewed by Sam Weinig.
874 Clear the std::ostringstream before starting test.
876 * TestWebKitAPI/Tests/WTF/RefLogger.h:
877 (TestWebKitAPI::DerivedRefLogger::DerivedRefLogger):
879 2015-01-13 Michael Catanzaro <mcatanzaro@igalia.com>
881 TestWebKitWebContext depends on British English spellcheck dictionary
882 https://bugs.webkit.org/show_bug.cgi?id=140403
884 Reviewed by Martin Robinson.
886 Install all English hunspell dictionaries on Fedora and Arch.
888 * gtk/install-dependencies:
890 2015-01-13 Michael Catanzaro <mcatanzaro@igalia.com>
892 [GTK] install-dependencies should grok dnf
893 https://bugs.webkit.org/show_bug.cgi?id=140396
895 Reviewed by Martin Robinson.
897 Fedora: install dependencies with dnf if yum is not installed.
899 * gtk/install-dependencies:
901 2015-01-12 Hunseop Jeong <hs85.jeong@samsung.com>
903 [EFL][GTK] Fix build after r178309
904 https://bugs.webkit.org/show_bug.cgi?id=140381
906 Reviewed by Gyuyoung Kim.
908 * TestWebKitAPI/CMakeLists.txt: Added the API directory
910 2015-01-11 Sam Weinig <sam@webkit.org>
912 Remove support for SharedWorkers
913 https://bugs.webkit.org/show_bug.cgi?id=140344
915 Reviewed by Anders Carlsson.
917 * Scripts/webkitperl/FeatureList.pm:
919 2015-01-12 Anders Carlsson <andersca@apple.com>
921 Make delegates conform to formal delegate protocols
922 https://bugs.webkit.org/show_bug.cgi?id=140370
924 Reviewed by Dan Bernstein.
926 * DumpRenderTree/mac/TestRunnerMac.mm:
927 (TestRunner::numberOfPendingGeolocationPermissionRequests):
928 (TestRunner::setGeolocationPermission):
930 2015-01-10 Michael Catanzaro <mcatanzaro@igalia.com>
932 build-webkit: silence output of 'which'
933 https://bugs.webkit.org/show_bug.cgi?id=140278
935 Reviewed by Daniel Bates.
937 Use a more elegent test for the existance of ninja and eclipse.
939 * Scripts/webkitdirs.pm:
940 (commandExists): Don't assume the command supports --version
941 (canUseNinja): Use commandExists()
942 (canUseEclipse): Use commandExists()
944 2015-01-09 Sam Weinig <sam@webkit.org>
946 Update the output format for run-api-tests
947 https://bugs.webkit.org/show_bug.cgi?id=140332
949 Reviewed by Dan Bernstein.
951 Changes the output format for run-api-tests be a bit simpler (no longer
952 indented based on suite, as we were not really using suite very well) but
953 also include details in the case of failure.
955 Changes verbose mode to no longer spew out the gtest default printer output,
956 as the custom printer now includes the failure information.
958 * Scripts/run-api-tests:
961 Augment the custom gtest printer by replacing the tokens "**PASS**" and "**FAIL**"
962 with colorized variants and strip out leaks spew (the leaks can be added back using
963 the new --show-leaks argument).
965 * TestWebKitAPI/TestsController.cpp:
966 (TestWebKitAPI::Printer::OnTestPartResult):
967 (TestWebKitAPI::Printer::OnTestEnd):
968 (TestWebKitAPI::TestsController::run):
969 Implement a custom result printer that just prints out the information we want.
971 2015-01-09 Sam Weinig <sam@webkit.org>
973 TestWebKitAPI should print out the lists that fail at the end
974 https://bugs.webkit.org/show_bug.cgi?id=140329
976 Reviewed by Tim Horton.
978 * Scripts/run-api-tests:
980 Print out failures and timeouts in all modes, not just verbose.
982 2015-01-07 Geoffrey Garen <ggaren@apple.com>
984 Make bmalloc work with ASan
985 https://bugs.webkit.org/show_bug.cgi?id=140194
987 Reviewed by Mark Lam.
989 * asan/asan.xcconfig: No need to disable FastMalloc; bmalloc supports
990 ASan automatically (by forwarding to system malloc at runtime).
992 2015-01-09 Daniel Bates <dabates@apple.com>
994 [iOS] Make DumpRenderTree build with public SDK
995 https://bugs.webkit.org/show_bug.cgi?id=140311
997 Reviewed by Sam Weinig.
999 Use CGRound() instead of the obsolete macro function _ROUNDF_ (defined in
1000 header UIKit/UIMath.h), and std::max() instead of the macro function MAX.
1001 Additionally, remove unused header CoreGraphics/CGFontDB.h.
1003 * DumpRenderTree/mac/DumpRenderTree.mm:
1004 (-[ScrollViewResizerDelegate view:didSetFrame:oldFrame:asResultOfZoom:]):
1006 2015-01-09 Alexey Proskuryakov <ap@apple.com>
1008 platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html fails on Retina machines
1009 https://bugs.webkit.org/show_bug.cgi?id=140300
1011 Reviewed by Simon Fraser.
1013 * WebKitTestRunner/TestController.cpp:
1014 (WTR::TestController::createOtherPage):
1015 (WTR::TestController::updateWindowScaleForTest):
1016 (WTR::TestController::configureViewForTest):
1017 * WebKitTestRunner/TestController.h:
1019 2015-01-09 Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com>
1021 Unreviewed. Moving myself to the committer section.
1023 * Scripts/webkitpy/common/config/contributors.json:
1025 2015-01-09 Carlos Garcia Campos <cgarcia@igalia.com>
1027 Add a script to check for platform layering violations
1028 https://bugs.webkit.org/show_bug.cgi?id=140248
1030 Reviewed by Darin Adler.
1032 It prints all the cases where files inside platform include
1033 headers that are not in platform directory.
1035 * Scripts/check-for-platform-layering-violations: Added.
1036 (get_platform_headers):
1037 (check_source_file):
1039 2015-01-08 Alexey Proskuryakov <ap@apple.com>
1041 [Mac WK2] Test snapshots are 1600x1200 on Retina devices
1042 https://bugs.webkit.org/show_bug.cgi?id=139884
1044 Reviewed by Tim Horton.
1046 * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
1047 Tell CGWindowListCreateImage to use the correct resolution. I don't really understand
1048 what the "nominal resolution" is, but this appears to work in practice.
1050 2015-01-08 Brent Fulgham <bfulgham@apple.com>
1052 [Win] DumpRenderTree is always using 800x600 size, even if tests need other size.
1053 https://bugs.webkit.org/show_bug.cgi?id=140256
1055 Reviewed by Anders Carlsson.
1057 * DumpRenderTree/win/DumpRenderTree.cpp:
1058 (resetWebPreferencesToConsistentValues): Drive-by fix of a buffer overrun found while
1059 running with heap validation checks.
1060 (sizeWebViewForCurrentTest): Check both path separators ('/' and '\\') when checking for
1061 the "svg\\W3C-SVG-1.1" test directory.
1062 (removeFontFallbackIfPresent): Use nullptr instead of 0.
1063 * DumpRenderTree/win/TestRunnerWin.cpp:
1064 (TestRunner::clearPersistentUserStyleSheet): Ditto.
1066 2015-01-08 Alexey Proskuryakov <ap@apple.com>
1068 Follow-up to: When WebProcess is slow to respond to IPC, that's mistakenly reported as crash
1069 https://bugs.webkit.org/show_bug.cgi?id=140218
1071 * Scripts/webkitpy/port/driver.py: (Driver._check_for_driver_crash_or_unresponsiveness):
1072 Undone an accidental change - check for self.has_crashed() again. This code path
1073 is for ports that don't have a signal handler printing #CRASHED when main process
1076 * Scripts/webkitpy/port/driver_unittest.py:
1077 (DriverTest.test_check_for_driver_crash.assert_crash):
1078 (DriverTest.test_check_for_driver_crash):
1079 Updated the tests, all changes are expected.
1081 2015-01-08 Alexey Proskuryakov <ap@apple.com>
1083 When WebProcess is slow to respond to IPC, that's mistakenly reported as crash
1084 https://bugs.webkit.org/show_bug.cgi?id=140218
1086 Reviewed by Darin Adler.
1088 * Scripts/webkitpy/port/driver.py:
1089 (Driver.__init__): Removed _subprocess_was_unresponsive that was a modifier for
1090 "process crashed" condition. These don't make sense together - it's either a crash
1091 or a timeout, and we should detect those properly at a much lower level.
1092 (Driver.run_test): Ditto.
1093 (Driver._check_for_driver_crash_or_unresponsiveness): Split crash and unresponsiveness
1096 * WebKitTestRunner/TestController.h:
1097 * WebKitTestRunner/TestController.cpp:
1098 (WTR::TestController::webProcessName):
1099 (WTR::TestController::processDidCrash):
1100 Factored out hardcoded child process names, as we now use these in two places.
1102 * WebKitTestRunner/TestInvocation.cpp:
1103 (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Dump an accurate child
1104 process name, so that it can be sampled (fixes sampling on Mavericks and above).
1106 2015-01-08 Zan Dobersek <zdobersek@igalia.com>
1108 Reorder my list of email addresses, keeping the Bugzilla address at the
1109 top since Bugzilla and other webkitpy scripts rely on that ordering.
1111 * Scripts/webkitpy/common/config/contributors.json:
1113 2015-01-08 Zan Dobersek <zdobersek@igalia.com>
1115 Moving myself to the reviewers section and updating
1116 the list of my email addresses.
1118 * Scripts/webkitpy/common/config/contributors.json:
1120 2015-01-07 Michael Catanzaro <mcatanzaro@igalia.com>
1122 [GTK] Build gtk-doc without gtkdoc-mktmpl
1123 https://bugs.webkit.org/show_bug.cgi?id=140225
1125 Reviewed by Darin Adler.
1127 Stop calling gtkdoc-mktmpl. It's being removed upstream, and since we
1128 don't modify the tmpl files that it generates, it's not doing anything
1133 (GTKDoc._run_gtkdoc_scangobj):
1134 (GTKDoc._run_gtkdoc_mktmpl): Deleted.
1136 2015-01-07 Gwang Yoon Hwang <yoon@igalia.com>
1138 [GTK][ThreadedCompositor] Add support for threaded compositor.
1139 https://bugs.webkit.org/show_bug.cgi?id=118265
1141 Reviewed by Martin Robinson.
1143 Added the ENABLE_THREADED_COMPOSITOR feature flag to the cmake and
1144 autotools build systems. The feature is disabled by default.
1145 And remove deprecated the WTF_USE_TILED_BACKING_STORE feature flag
1146 from the feature flags.
1148 * Scripts/webkitperl/FeatureList.pm:
1150 2015-01-07 Daniel Bates <dabates@apple.com>
1152 [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
1153 https://bugs.webkit.org/show_bug.cgi?id=137371
1155 Reviewed by David Kilzer.
1157 Use SPI wrapper headers instead of directly referencing private SPI headers.
1159 * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
1160 * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1161 * DumpRenderTree/mac/Configurations/Base.xcconfig: Append directory Source/WebKit2/Platform/spi/ios
1162 to the list of iOS header search directories so that we can include header UIKitSPI.h.
1163 * DumpRenderTree/mac/DumpRenderTree.mm:
1164 * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1165 * DumpRenderTree/mac/EventSendingController.mm:
1166 * DumpRenderTree/mac/TestRunnerMac.mm:
1168 2015-01-07 Commit Queue <commit-queue@webkit.org>
1170 Unreviewed, rolling out r178068.
1171 https://bugs.webkit.org/show_bug.cgi?id=140235
1173 Breaks the iOS build (Requested by enrica on #webkit).
1177 "[iOS] Make WebKit2 build with public iOS SDK and more build
1179 https://bugs.webkit.org/show_bug.cgi?id=137371
1180 http://trac.webkit.org/changeset/178068
1182 2015-01-07 Daniel Bates <dabates@apple.com>
1184 [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
1185 https://bugs.webkit.org/show_bug.cgi?id=137371
1187 Reviewed by David Kilzer.
1189 Use SPI wrapper headers instead of directly referencing private SPI headers.
1191 * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
1192 * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1193 * DumpRenderTree/mac/Configurations/Base.xcconfig: Append directory Source/WebKit2/Platform/spi/ios
1194 to the list of header search directories so that we can include header UIKitSPI.h.
1195 * DumpRenderTree/mac/DumpRenderTree.mm:
1196 * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1197 * DumpRenderTree/mac/EventSendingController.mm:
1198 * DumpRenderTree/mac/TestRunnerMac.mm:
1200 2015-01-07 Brent Fulgham <bfulgham@apple.com>
1202 [Win] Unreviewed test change to improve run reproducibility
1204 * Scripts/webkitpy/port/win.py:
1205 (WinPort.default_child_processes): Run a single DRT instance to help
1206 identify failures caused by earlier test runs.
1208 2015-01-07 Myles C. Maxfield <mmaxfield@apple.com>
1210 Myles C. Maxfield is a reviewer now
1211 https://bugs.webkit.org/show_bug.cgi?id=140196
1213 Reviewed by Dean Jackson.
1215 * Scripts/webkitpy/common/config/contributors.json:
1217 2015-01-07 Myles C. Maxfield <mmaxfield@apple.com>
1219 Make webkit-patch try harder to find keychain credentials
1220 https://bugs.webkit.org/show_bug.cgi?id=140170
1222 Reviewed by Ryosuke Niwa.
1224 When the user manually enters a password into webkit-patch, we hand that off to the
1225 Keyring Python module. However, that module creates a generic password entry instead
1226 of an internet password entry. We should look for both kinds.
1228 * Scripts/webkitpy/common/net/credentials.py:
1229 (Credentials._run_security_tool):
1230 (Credentials._credentials_from_keychain):
1231 * Scripts/webkitpy/common/net/credentials_unittest.py:
1232 (test_security_output_parse_entry_not_found):
1233 (_assert_security_call):
1235 2015-01-06 Anders Carlsson <andersca@apple.com>
1237 Try to fix the Mountain Lion build.
1239 * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
1240 (TestWebKitAPI::didGetImageForMatchResult):
1242 2015-01-06 Alexey Proskuryakov <ap@apple.com>
1244 Debug ASan builds frequently crash in Register::jsValue under DFG::prepareOSREntry
1245 https://bugs.webkit.org/show_bug.cgi?id=140095
1247 Reviewed by Anders Carlsson.
1249 * asan/webkit-asan-ignore.txt: Blacklist a function that gets inlined in release
1250 builds, but not in debug ones.
1252 2015-01-06 Brent Fulgham <bfulgham@apple.com>
1254 [Win] Extend WinLauncher with support for Page Zoom
1255 https://bugs.webkit.org/show_bug.cgi?id=140152
1257 Reviewed by Anders Carlsson.
1259 * WinLauncher/Common.cpp:
1261 * WinLauncher/WinLauncher.cpp:
1262 (WinLauncher::resetZoom):
1263 (WinLauncher::zoomIn):
1264 (WinLauncher::zoomOut):
1265 * WinLauncher/WinLauncher.h:
1266 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc:
1267 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
1268 * win/DLLLauncher/DLLLauncherMain.cpp:
1271 2015-01-06 Anders Carlsson <andersca@apple.com>
1273 Fix API tests that are broken under HiDPI
1274 https://bugs.webkit.org/show_bug.cgi?id=140146
1276 Reviewed by Tim Horton.
1278 * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
1279 (TestWebKitAPI::didGetImageForMatchResult):
1280 NSImages are measured in points, so grab the underlying bitmap image and get its size in pixels.
1282 * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
1283 (TestWebKitAPI::DeviceScaleFactorOnBack::runTest):
1284 Don't assume that a web view not in a window has a backing scale factor of 1. Instead, always have web views start
1285 out in a window that has a backing scale factor of 1.
1287 * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
1288 (TestWebKitAPI::DynamicDeviceScaleFactor::runTest):
1291 2015-01-06 Alexey Proskuryakov <ap@apple.com>
1293 ADDRESS_SANITIZER macro is overloaded
1294 https://bugs.webkit.org/show_bug.cgi?id=140130
1296 Reviewed by Anders Carlsson.
1298 * WebKitTestRunner/TestController.cpp: Use the new macro.
1300 2015-01-05 Joseph Pecoraro <pecoraro@apple.com>
1302 Remove some stale class names in check-for-inappropriate-objc-class-names
1303 https://bugs.webkit.org/show_bug.cgi?id=140104
1305 Reviewed by Darin Adler.
1307 * Scripts/check-for-inappropriate-objc-class-names:
1308 These UIWK* classes no longer exist.
1310 2015-01-05 Anders Carlsson <andersca@apple.com>
1312 heap-buffer-overflow on fast/loader/reload-zero-byte-plugin.html
1313 https://bugs.webkit.org/show_bug.cgi?id=140096
1314 rdar://problem/19368938
1316 Reviewed by Alexey Proskuryakov.
1318 When creating a new page, don't pass clientInfo when setting up the frame and policy clients,
1319 since clientInfo points to a web view, not the test controller.
1321 * WebKitTestRunner/TestController.cpp:
1322 (WTR::TestController::createOtherPage):
1324 2015-01-05 Hunseop Jeong <hs85.jeong@samsung.com>
1326 [EFL][GTK] WKPreferencesDefaults test failed after r177506
1327 https://bugs.webkit.org/show_bug.cgi?id=140077
1329 Reviewed by Csaba Osztrogonác.
1331 WebKit C SPI is available on EFL,GTK.
1332 Changed the define order to pass the API test.
1334 * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1335 (TestWebKitAPI::TEST):
1337 2015-01-01 Alexey Proskuryakov <ap@apple.com>
1339 Simplify WebKitTestRunner timeout tracking
1340 https://bugs.webkit.org/show_bug.cgi?id=140036
1342 Reviewed by Darin Adler.
1344 The code for configuring timeouts was mostly dead, because run-webkit-tests never
1345 passes the --timeout option to WebKitTestRunner.
1347 * WebKitTestRunner/Options.h:
1348 * WebKitTestRunner/Options.cpp:
1349 (WTR::Options::Options):
1350 (WTR::OptionsHandler::OptionsHandler):
1351 (WTR::handleOptionTimeout): Deleted.
1352 Removed support for --timeout. Timeouts are passed for each test individually,
1353 and defaults are good enough for the rare cases where WebKitTestRunner is run
1354 manually without run-webkit-tests.
1356 * WebKitTestRunner/TestController.cpp:
1357 (WTR::TestController::TestController):
1358 (WTR::TestController::initialize):
1359 (WTR::TestController::resetStateToConsistentValues):
1360 (WTR::TestController::reattachPageToWebProcess):
1361 (WTR::TestController::runUntil):
1362 * WebKitTestRunner/TestController.h:
1363 Simplified runUntil by passing the actual timeout, not an enum.
1364 Increased short timeout for ASan enabled builds, as WebProcess launching takes
1367 * WebKitTestRunner/TestInvocation.cpp:
1368 (WTR::TestInvocation::invoke): Removed dead code that handled a timeout from NoTimeout.
1370 * WebKitTestRunner/efl/TestControllerEfl.cpp:
1371 (WTR::TestController::platformRunUntil):
1372 * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1373 (WTR::TestController::platformRunUntil):
1376 2015-01-02 Anders Carlsson <andersca@apple.com>
1378 Remove now unused storage tracker glue from DumpRenderTree
1379 https://bugs.webkit.org/show_bug.cgi?id=140045
1381 Reviewed by Darin Adler.
1383 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1384 * DumpRenderTree/StorageTrackerDelegate.h: Removed.
1385 * DumpRenderTree/StorageTrackerDelegate.mm: Removed.
1386 * DumpRenderTree/TestRunner.cpp:
1387 (TestRunner::staticFunctions):
1388 (syncLocalStorageCallback): Deleted.
1389 (observeStorageTrackerNotificationsCallback): Deleted.
1390 (deleteAllLocalStorageCallback): Deleted.
1391 (deleteLocalStorageForOriginCallback): Deleted.
1392 (localStorageDiskUsageForOriginCallback): Deleted.
1393 (originsWithLocalStorageCallback): Deleted.
1394 * DumpRenderTree/TestRunner.h:
1395 * DumpRenderTree/mac/DumpRenderTree.mm:
1396 (allocateGlobalControllers):
1397 (releaseGlobalControllers):
1398 * DumpRenderTree/mac/DumpRenderTreeMac.h:
1399 * DumpRenderTree/mac/TestRunnerMac.mm:
1400 (TestRunner::syncLocalStorage): Deleted.
1401 (TestRunner::localStorageDiskUsageForOrigin): Deleted.
1402 (TestRunner::observeStorageTrackerNotifications): Deleted.
1403 (TestRunner::deleteAllLocalStorage): Deleted.
1404 (TestRunner::originsWithLocalStorage): Deleted.
1405 (TestRunner::deleteLocalStorageForOrigin): Deleted.
1406 * DumpRenderTree/win/TestRunnerWin.cpp:
1407 (TestRunner::syncLocalStorage): Deleted.
1408 (TestRunner::localStorageDiskUsageForOrigin): Deleted.
1409 (TestRunner::observeStorageTrackerNotifications): Deleted.
1410 (TestRunner::deleteAllLocalStorage): Deleted.
1411 (TestRunner::originsWithLocalStorage): Deleted.
1412 (TestRunner::deleteLocalStorageForOrigin): Deleted.
1414 2015-01-01 Darin Adler <darin@apple.com>
1416 We often misspell identifier as "identifer"
1417 https://bugs.webkit.org/show_bug.cgi?id=140025
1419 Reviewed by Michael Saboff.
1421 * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1422 * Scripts/webkitdirs.pm:
1423 (appIdentifierFromBundle):
1424 (installAndLaunchIOSWebKitAppInSimulator):
1427 2015-01-01 Zalan Bujtas <zalan@apple.com>
1429 Saturated arithmetics: Incorrect float/double clamping.
1430 https://bugs.webkit.org/show_bug.cgi?id=139888
1431 rdar://problem/19330885
1433 Reviewed by Simon Fraser.
1435 Clamp float and double values correctly when applying saturated arithmetics.
1437 * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
1438 (TestWebKitAPI::TEST):
1440 2014-12-30 Krzysztof Czech <k.czech@samsung.com>
1442 [EFL] Bump version of ATK used by jhbuild to 2.15.2
1443 https://bugs.webkit.org/show_bug.cgi?id=139816
1445 Reviewed by Gyuyoung Kim.
1447 Bump version of ATK used by jhbuild to 2.15.2
1449 * efl/jhbuild.modules:
1451 2014-12-29 Fabien Vallée <fvallee@connected-labs.com>
1453 [jhBuild] cairo build error (-flto)
1454 https://bugs.webkit.org/show_bug.cgi?id=139056
1456 Reviewed by Philippe Normand.
1458 cairo fails to link with gcc 4.9 due to lto
1459 related issue. This problem has been partially
1461 http://cgit.freedesktop.org/cairo/commit/?id=c3645d97ebd24c6f7ad850785d585aebc706a11c
1462 use the cairo --disable-lto option and remove jhbuild
1463 makeargs fixes the issue.
1465 * gtk/jhbuild.modules:
1466 * gtk/patches/cairo-1.12.8-add_disable-lto.patch: Added.
1468 2014-12-27 Myles C. Maxfield <mmaxfield@apple.com>
1469 [Mac] Enable kerning, ligatures, and printer fonts
1470 https://bugs.webkit.org/show_bug.cgi?id=139970
1472 Rubber stamped by Simon Fraser.
1476 * DumpRenderTree/mac/DumpRenderTree.mm:
1477 * WebKitTestRunner/TestController.cpp:
1478 * WebKitTestRunner/mac/main.mm:
1480 2014-12-26 Dan Bernstein <mitz@apple.com>
1482 <rdar://problem/19348208> REGRESSION (r177027): iOS builds use the wrong toolchain
1483 https://bugs.webkit.org/show_bug.cgi?id=139950
1485 Reviewed by David Kilzer.
1487 * asan/asan.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
1488 in a manner that works with Xcode 5.1.1.
1490 2014-12-24 Dan Bernstein <mitz@apple.com>
1492 Engineering builds of MiniBrowser ignore deprecated declaration warnings
1493 https://bugs.webkit.org/show_bug.cgi?id=139941
1495 Reviewed by Darin Adler.
1497 * MiniBrowser/Configurations/Base.xcconfig: Added semicolon.
1498 * MiniBrowser/Configurations/DebugRelease.xcconfig: Set GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS
1500 * MiniBrowser/mac/AppDelegate.m:
1501 (-[BrowserAppDelegate openDocument:]): Use NSFileHandlingPanelOKButton instead of
1502 deprecated NSOKButton.
1504 2014-12-24 Youenn Fablet <youenn.fablet@crf.canon.fr>
1506 W3C test importer should have an option to disable testharness.js/testharnessreport.js link conversion
1507 https://bugs.webkit.org/show_bug.cgi?id=134763
1509 Reviewed by Ryosuke Niwa.
1511 Adding an option to disable test harness link conversion.
1513 * Scripts/webkitpy/w3c/test_converter.py:
1514 (convert_for_webkit):
1515 (_W3CTestConverter.__init__):
1516 (_W3CTestConverter.convert_attributes_if_needed):
1517 * Scripts/webkitpy/w3c/test_importer.py:
1519 (TestImporter.import_tests):
1521 2014-12-23 Alexey Proskuryakov <ap@apple.com>
1523 DumpRenderTree crashes are mis-reported as timeouts on Yosemite
1524 https://bugs.webkit.org/show_bug.cgi?id=139933
1526 Reviewed by Daniel Bates.
1528 Crash logs take a very long time to be generated on Yosemite (rdar://problem/18701447),
1529 and there is no way for run-webkit-tests to tell a crashed process from a frozen one
1530 until ReportCrash lets it go.
1532 Reuse existing machinery that tells run-webkit-tests about crashes. The script may
1533 even get the actual crash log eventually - even when it times out waiting for the log, it
1534 makes a second lookup at the very end, after all tests finish. There may be further
1535 improvements needed here, but this small fix addresses most cases that happen in practice.
1537 * DumpRenderTree/mac/DumpRenderTree.mm:
1538 (writeCrashedMessageOnFatalError):
1540 Removed PLATFORM(IOS) ifdefs, this code is just as helpful on Mac.
1542 * Scripts/webkitpy/port/driver.py: (Driver._check_for_driver_crash): Removed an
1545 2014-12-23 Alexey Proskuryakov <ap@apple.com>
1547 Don't force -O1 for debug ASan builds
1548 https://bugs.webkit.org/show_bug.cgi?id=139926
1550 Reviewed by Darin Adler.
1552 * asan/asan.xcconfig:
1554 2014-12-23 Alexey Proskuryakov <ap@apple.com>
1556 Simplify building with ASan
1557 https://bugs.webkit.org/show_bug.cgi?id=139916
1559 Reviewed by Mark Rowe.
1561 * Scripts/set-webkit-configuration: Store ASan state into a new configuration file.
1562 We could also update Configuration file format, but that's a little scary because
1563 of how many places in code read it.
1565 * Scripts/webkitdirs.pm:
1566 (determineASanIsEnabled): Read it from ASan configuration file.
1567 (argumentsForConfiguration): Added a FIXME.
1568 (asanIsEnabled): A caching wrapper similar to what we have for other configuration options.
1569 (XcodeOptions): Pass the options needed for ASan.
1571 * asan/asan.xcconfig: Use the right toolchains. Made warnings fatal again, as there
1572 no warnings to avoid. Removed explicit linking options, as -fsanitize=address does
1575 2014-12-23 Alexey Proskuryakov <ap@apple.com>
1577 TestWebKitAPI build is broken when ASan is enabled
1578 https://bugs.webkit.org/show_bug.cgi?id=139902
1580 Reviewed by Darin Adler.
1582 * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
1583 * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig:
1584 Inherit linker flags from DebugRelease, which respects ASAN.
1586 2014-12-22 Simon Fraser <simon.fraser@apple.com>
1588 Sort the Xcode project file.
1590 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1592 2014-12-22 Lucas Forschler <lforschler@apple.com>
1594 Update apple-mac-114 to bot629.
1598 * BuildSlaveSupport/build.webkit.org-config/config.json:
1600 2014-12-22 Lucas Forschler <lforschler@apple.com>
1602 Replace Apple bot104 with bot124.
1606 * BuildSlaveSupport/build.webkit.org-config/config.json:
1608 2014-12-22 Csaba Osztrogonác <ossy@webkit.org>
1610 URTBF after r177639.
1612 * TestWebKitAPI/CMakeLists.txt:
1614 2014-12-22 Grzegorz Czajkowski <g.czajkowski@samsung.com>
1616 [EFL] MiniBrowser steals web view's focus
1617 https://bugs.webkit.org/show_bug.cgi?id=139482
1619 Reviewed by Gyuyoung Kim.
1621 Although we set focus on ewk_view while MiniBrowser initialization
1622 Ecore steals it in a favor of main window. As a result
1623 focused element on web page is unable to receive events.
1625 * MiniBrowser/efl/main.c:
1627 Prevent window from stealing web view's focus on start up.
1629 2014-12-19 Brent Fulgham <bfulgham@apple.com>
1631 [Win] Revise DRT logic to match Mac.
1633 Rubberstamped by Anders Carlsson.
1635 Update the Windows logic to perform initialization of preferences and WebKit
1636 settings to match Mac. Also make sure that we only ever emit #EOF tokens under
1637 the same circumstances as the Mac version.
1639 * DumpRenderTree/win/DumpRenderTree.cpp:
1641 (resetWebPreferencesToConsistentValues):
1642 (setDefaultsToConsistentValuesForTesting):
1643 (resetWebViewToConsistentStateBeforeTesting):
1644 (sizeWebViewForCurrentTest):
1646 (createWebViewAndOffscreenWindow):
1647 (allocateGlobalControllers):
1648 (prepareConsistentTestingEnvironment):
1650 (resetDefaultsToConsistentValues): Deleted.
1652 2014-12-19 Roger Fong <roger_fong@apple.com>
1654 Unreviewed. Rollout r177605.
1656 * EWSTools/start-queue-win.sh:
1658 2014-12-19 Roger Fong <roger_fong@apple.com>
1660 Unreviewed. Try running EWS scripts without —no-confirm, since it defaults to true.
1662 * EWSTools/start-queue-win.sh:
1664 2014-12-19 Daniel Bates <dabates@apple.com>
1666 [iOS] Add WebKitSystemInterface for iOS 8.1
1667 https://bugs.webkit.org/show_bug.cgi?id=139831
1669 Reviewed by Alexey Proskuryakov.
1671 Implement support in copy-webkitlibraries-to-product-directory to copy
1672 WebKitSystemInterface for iOS to the product directory and have build-webkit
1673 pass --wksi to copy-webkitlibraries-to-product-directory when building for iOS.
1675 * Scripts/build-webkit:
1676 * Scripts/copy-webkitlibraries-to-product-directory:
1678 2014-12-19 Daniel Bates <dabates@apple.com>
1680 copy-webkitlibraries-to-product-directory uses wrong SDK when called from build-webkit
1681 https://bugs.webkit.org/show_bug.cgi?id=139829
1683 Reviewed by Alexey Proskuryakov.
1685 The script build-webkit calls script copy-webkitlibraries-to-product-directory with
1686 argument --sdk to specify the Xcode SDK to use, but copy-webkitlibraries-to-product-directory
1687 expects the Xcode SDK to be specified using the --sdk-name command line argument.
1689 Currently copy-webkitlibraries-to-product-directory has its own logic to handle
1690 parsing for a specified Xcode SDK. Instead we should make use of the webkitdirs.pm
1691 logic to both avoid duplicating effort and make the command line options for
1692 copy-webkitlibraries-to-product-directory for specify the Xcode SDK consistent
1693 with the approach used in other WebKit tools.
1695 As a side effect of making use of the webkitdirs.pm logic for determining the Xcode SDK
1696 copy-webkitlibraries-to-product-directory now recognizes --device and --simulator
1697 shorthands for --sdk=iphoneos.internal and --sdk=iphonesimulator, respectively.
1699 * Scripts/copy-webkitlibraries-to-product-directory: Also, renamed some variables to
1700 improve the readability of the code.
1701 (executeRanlib): Added; convenience function that calls the RANLIB(1) with the appropriate
1702 Xcode SDK. We pass -no_warning_for_no_symbols to RANLIB(1) when using an Xcode SDK
1703 for iOS since it's acceptable that an empty object file (say, for a Mac-specific feature)
1704 be included in a library.
1705 (unpackIfNecessary): Modified to call executeRanlib().
1707 2014-12-19 Alexey Proskuryakov <ap@apple.com>
1709 REGRESSION (177368): Some tests started to immediately time out
1710 https://bugs.webkit.org/show_bug.cgi?id=139826
1712 Reviewed by Daniel Bates.
1714 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::done):
1715 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::dump):
1716 Move invalidateWaitToDumpWatchdogTimer() call from dump() to done(). When a test
1717 ends in a load failure, we don't dump, so we used to leak the timer.
1719 * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::notifyDone):
1722 2014-12-19 Brent Fulgham <bfulgham@apple.com>
1724 [Win] Add accessor for serializing HTTP loads
1725 https://bugs.webkit.org/show_bug.cgi?id=139817
1727 Reviewed by Mark Lam.
1729 * DumpRenderTree/win/DumpRenderTree.cpp: Reset serialized HTTP loads in our reset method.
1730 * DumpRenderTree/win/TestRunnerWin.cpp: Provide implementation for serializing HTTP. Also
1731 remove some redundant code from the destructor.
1733 2014-12-19 Alexey Proskuryakov <ap@apple.com>
1735 Clean up a fix for performance test bot failing to build
1736 https://bugs.webkit.org/show_bug.cgi?id=139818
1738 Reviewed by Csaba Osztrogonác.
1740 The "_1" in step name was annoying.
1742 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1743 (CleanBuildIfScheduled.start):
1744 (RunAndUploadPerfTests):
1745 (DownloadAndPerfTestFactory.__init__):
1746 (DownloadAndPerfTestWebKit2Factory.__init__):
1747 (CleanBuildUnconditionally): Deleted.
1748 (CleanBuildUnconditionally.start): Deleted.
1750 2014-12-19 Csaba Osztrogonác <ossy@webkit.org>
1752 REGRESSION(r177535): It broke the GTK performance bot
1753 https://bugs.webkit.org/show_bug.cgi?id=139811
1755 Reviewed by Carlos Garcia Campos.
1757 Trigger clean build only on mac platform.
1759 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1760 (DownloadAndPerfTestFactory.__init__):
1761 (DownloadAndPerfTestWebKit2Factory.__init__):
1763 2014-12-18 KwangHyuk Kim <hyuki.kim@samsung.com>
1765 Unreviewed, moved myself to the list of committers.
1767 * Scripts/webkitpy/common/config/contributors.json:
1769 2014-12-18 Brent Fulgham <bfulgham@apple.com>
1771 [Win] Update DumpRenderTree to more closely match Mac version
1772 https://bugs.webkit.org/show_bug.cgi?id=139799
1774 Reviewed by Tim Horton.
1776 * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1777 (AccessibilityController::accessibleElementById): Correct
1778 use of BSTR to avoid leak.
1779 * DumpRenderTree/win/DumpRenderTree.cpp: Reorder methods and
1780 update to match Mac version more closely.
1783 (resetDefaultsToConsistentValues):
1784 (resetWebViewToConsistentStateBeforeTesting):
1785 (sizeWebViewForCurrentTest):
1788 (windowToWebViewMap):
1789 (createWebViewAndOffscreenWindow):
1791 (initializeGlobalsFromCommandLineOptions):
1793 * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
1794 (TestRunner::addDisallowedURL):
1795 (TestRunner::applicationCacheDiskUsageForOrigin):
1796 (TestRunner::syncLocalStorage):
1797 (TestRunner::localStorageDiskUsageForOrigin):
1798 (TestRunner::observeStorageTrackerNotifications):
1799 (TestRunner::clearApplicationCacheForOrigin):
1800 (TestRunner::originsWithApplicationCache):
1801 (TestRunner::deleteAllLocalStorage):
1802 (TestRunner::setStorageDatabaseIdleInterval):
1803 (TestRunner::closeIdleLocalStorageDatabases):
1804 (TestRunner::originsWithLocalStorage):
1805 (TestRunner::deleteLocalStorageForOrigin):
1806 (TestRunner::copyDecodedHostName):
1807 (TestRunner::copyEncodedHostName):
1808 (TestRunner::keepWebHistory):
1809 (TestRunner::numberOfPendingGeolocationPermissionRequests):
1810 (TestRunner::setAppCacheMaximumSize):
1811 (TestRunner::setCustomPolicyDelegate):
1812 (TestRunner::goBack):
1813 (TestRunner::setDefersLoading):
1814 (TestRunner::setDomainRelaxationForbiddenForURLScheme):
1815 (TestRunner::setMockDeviceOrientation):
1816 (TestRunner::setMockGeolocationPosition):
1817 (TestRunner::setMockGeolocationPositionUnavailableError):
1818 (TestRunner::setIconDatabaseEnabled):
1819 (TestRunner::setMainFrameIsFirstResponder):
1820 (TestRunner::setSpatialNavigationEnabled):
1821 (TestRunner::setPluginsEnabled):
1822 (TestRunner::setAutomaticLinkDetectionEnabled):
1823 (TestRunner::setUseDashboardCompatibilityMode):
1824 (TestRunner::dispatchPendingLoadRequests):
1825 (TestRunner::findString):
1826 (TestRunner::setCacheModel):
1827 (TestRunner::apiTestNewWindowDataLoadBaseURL):
1828 (TestRunner::setWebViewEditable):
1829 (TestRunner::authenticateSession):
1830 (TestRunner::abortModal):
1831 (TestRunner::setSerializeHTTPLoads):
1832 (TestRunner::addChromeInputField):
1833 (TestRunner::removeChromeInputField):
1834 (TestRunner::focusWebView):
1835 (TestRunner::setBackingScaleFactor):
1836 (TestRunner::grantWebNotificationPermission):
1837 (TestRunner::denyWebNotificationPermission):
1838 (TestRunner::removeAllWebNotificationPermissions):
1839 (TestRunner::simulateWebNotificationClick):
1841 2014-12-18 Gavin Barraclough <barraclough@apple.com>
1843 Add strong typing to RefCounter interface, return value as a bool.
1844 https://bugs.webkit.org/show_bug.cgi?id=139776
1846 Reviewed by Geoff Garen.
1848 Currently all token vended by a RefCounter have the same type - Ref<RefCounter::Count>.
1849 This means there is no compile time type checking to prevent mistakes. Update the count()
1850 method to token<>(), templated on type used to identify the token being returned.
1851 Calls to token<T>() will return a result of type RefCounter::Token<T>.
1853 There are a few problems with the fact the counter will return you an exact count of the
1854 number of outstanding tokens:
1855 - It is desirable to only fire the callback on zero-edge changes; it is more consistent
1856 to do so if the value is only readable as a boolean.
1857 - It is desirable to provide the value as an argument to the callback, however to make
1858 this useful for integer values it is also necessary to indicate the direction of change
1859 (0->1 is often interesting where 2->1 is not).
1860 - There is a mismatch between the precision of returning a count, and the inherent
1861 imprecision of a token based mechanism, where it may be difficult to guarantee
1862 absolutely no unnecessary refcount churn, and thus unintentional counter values.
1864 * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
1865 (TestWebKitAPI::TEST):
1868 2014-12-18 Alexey Proskuryakov <ap@apple.com>
1870 Disable retries on Mac Release WK2 testers
1871 https://bugs.webkit.org/show_bug.cgi?id=139798
1873 Reviewed by Simon Fraser.
1875 * BuildSlaveSupport/build.webkit.org-config/config.json:
1877 2014-12-18 Alexey Proskuryakov <ap@apple.com>
1879 Perf tests frequently fail saying "build not up to date"
1880 https://bugs.webkit.org/show_bug.cgi?id=139786
1882 Illegitimately yet authoritatively reviewed by Lucas Forschler.
1884 Undo the rest of the first fix, and implement the behavior differently.
1886 is_clean isn't automatically forwarded from config.json to properties.
1888 * BuildSlaveSupport/build.webkit.org-config/config.json:
1889 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1890 (CleanBuildUnconditionally):
1891 (CleanBuildUnconditionally.start):
1892 (DownloadAndPerfTestFactory.__init__):
1893 (DownloadAndPerfTestWebKit2Factory.__init__):
1895 2014-12-18 Alexey Proskuryakov <ap@apple.com>
1897 Roll out part of the previous patch - BuildAndPerfTestWebKit2 is used by Efl.
1898 I thought that it was unused because grepping for BuildAndPerfTestWebKit2Factory
1901 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1902 (BuildAndPerfTestFactory):
1903 (BuildAndPerfTestWebKit2Factory):
1905 2014-12-18 Alexey Proskuryakov <ap@apple.com>
1907 Perf tests frequently fail saying "build not up to date"
1908 https://bugs.webkit.org/show_bug.cgi?id=139786
1910 Reviewed by Ryosuke Niwa.
1912 Perf tests only build DumpRenderTree, not WebKit itself. Just clean the build
1913 directory to get rid of stale precompiled headers, and let it rebuild
1914 DumpRenderTree each time, that's fast.
1916 Also, removed unused "build and perf test" code.
1918 * BuildSlaveSupport/build.webkit.org-config/config.json:
1920 2014-12-18 Brent Fulgham <bfulgham@apple.com>
1922 [Win] Unreviewed gardening. Reorder file contents to match Mac version.
1924 Reorder the contents of the TestRunnerWin so that it matches TestRunnerMac. This makes
1925 it easier to see what steps are missing when running under Windows.
1927 * DumpRenderTree/win/TestRunnerWin.cpp:
1928 (TestRunner::callShouldCloseOnWebView):
1929 (TestRunner::clearAllApplicationCaches):
1930 (TestRunner::applicationCacheDiskUsageForOrigin):
1931 (TestRunner::syncLocalStorage):
1932 (TestRunner::localStorageDiskUsageForOrigin):
1933 (TestRunner::observeStorageTrackerNotifications):
1934 (TestRunner::clearApplicationCacheForOrigin):
1935 (TestRunner::originsWithApplicationCache):
1936 (TestRunner::clearAllDatabases):
1937 (TestRunner::deleteAllLocalStorage):
1938 (TestRunner::setStorageDatabaseIdleInterval):
1939 (TestRunner::closeIdleLocalStorageDatabases):
1940 (TestRunner::originsWithLocalStorage):
1941 (TestRunner::deleteLocalStorageForOrigin):
1942 (TestRunner::numberOfPendingGeolocationPermissionRequests):
1943 (jsStringRefToWString):
1944 (TestRunner::setAppCacheMaximumSize):
1945 (TestRunner::setDatabaseQuota):
1946 (TestRunner::goBack):
1947 (TestRunner::setDefersLoading):
1948 (TestRunner::setDomainRelaxationForbiddenForURLScheme):
1949 (TestRunner::setAutomaticLinkDetectionEnabled):
1950 (TestRunner::dispatchPendingLoadRequests):
1951 (TestRunner::overridePreference):
1952 (TestRunner::removeAllVisitedLinks):
1953 (TestRunner::waitForPolicyDelegate):
1954 (TestRunner::resetPageVisibility):
1955 (TestRunner::setPageVisibility):
1956 (TestRunner::grantWebNotificationPermission):
1957 (TestRunner::denyWebNotificationPermission):
1958 (TestRunner::removeAllWebNotificationPermissions):
1959 (TestRunner::simulateWebNotificationClick):
1960 (TestRunner::simulateLegacyWebNotificationClick):
1962 2014-12-18 Brent Fulgham <bfulgham@apple.com>
1964 [Win] Correct Windows tests after Bug 139149 (edit)
1965 https://bugs.webkit.org/show_bug.cgi?id=139781
1967 Reviewed by Anders Carlsson.
1969 * DumpRenderTree/win/TestRunnerWin.cpp:
1970 (TestRunner::clearAllApplicationCaches): Use new WebApplicationCache
1973 2014-12-18 Simon Fraser <simon.fraser@apple.com>
1975 [iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim) in arguments for build and test scripts
1976 https://bugs.webkit.org/show_bug.cgi?id=139748
1978 Reviewed by Daniel Bates.
1980 Staging change to support --ios-sim and --ios-simulator temporarily until the bots
1981 have all been updated.
1983 * Scripts/webkitpy/port/factory.py:
1986 2014-12-18 Simon Fraser <simon.fraser@apple.com>
1988 Build more of TestWebKitAPI for iOS
1989 https://bugs.webkit.org/show_bug.cgi?id=139747
1991 Reviewed by Daniel Bates.
1993 Base.xcconfig removed many test files from the iOS build via EXCLUDED_SOURCE_FILE_NAMES,
1994 which excluded some tests that should be run for iOS.
1996 Fix by removing some patterns from EXCLUDED_SOURCE_FILE_NAMES, and #ifdeffing
1997 source files instead. config.h defines WK_HAVE_C_SPI when the WebKit C SPI is
1998 available (i.e. Mac OS X), and most files use that. Some files with Mac-only
1999 functionality (ActionMenus, Downloads) use #if PLATFORM(MAC).
2001 Added PlatformUtilitiesCocoa.mm and moved WeakObjCPtr.mm into a cocoa directory
2002 to share code between Mac and iOS.
2004 * TestWebKitAPI/Configurations/Base.xcconfig:
2005 * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
2006 * TestWebKitAPI/InjectedBundleController.cpp:
2007 * TestWebKitAPI/InjectedBundleMain.cpp:
2008 * TestWebKitAPI/JavaScriptTest.cpp:
2009 * TestWebKitAPI/PlatformUtilities.cpp:
2010 * TestWebKitAPI/PlatformUtilities.h:
2011 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2012 * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
2013 * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
2014 * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
2015 * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
2016 * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp:
2017 * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp:
2018 * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
2019 * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
2020 * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
2021 * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
2022 * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
2023 * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp:
2024 * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
2025 * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
2026 * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
2027 * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
2028 * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
2029 * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
2030 * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
2031 * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
2032 * TestWebKitAPI/Tests/WebKit2/Find.cpp:
2033 * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
2034 * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
2035 * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
2036 * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
2037 * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2038 * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
2039 * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp:
2040 * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
2041 * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
2042 * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
2043 * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
2044 * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
2045 * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
2046 * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
2047 * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp:
2048 * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
2049 * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
2050 * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
2051 * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
2052 * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
2053 * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
2054 * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp:
2055 * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
2056 * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
2057 * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
2058 * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
2059 * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp:
2060 * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
2061 * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
2062 * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
2063 * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2064 * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2065 * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
2066 * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
2067 * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
2068 * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
2069 * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
2070 * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
2071 * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
2072 * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
2073 * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
2074 * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
2075 * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp:
2076 * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
2077 * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
2078 * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
2079 * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
2080 * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:
2081 * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
2082 * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
2083 * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
2084 * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp:
2085 * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp:
2086 * TestWebKitAPI/Tests/WebKit2/UserMessage_Bundle.cpp:
2087 * TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp:
2088 * TestWebKitAPI/Tests/WebKit2/WKPageGetScaleFactorNotZero.cpp:
2089 * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
2090 * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2091 (TestWebKitAPI::TEST):
2092 * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
2093 * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
2094 * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
2095 * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
2096 * TestWebKitAPI/Tests/WebKit2/WebCoreStatisticsWithNoWebProcess.cpp:
2097 * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
2098 * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
2099 * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent.cpp:
2100 * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
2101 * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm.
2103 * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2104 * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
2105 * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
2106 * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm:
2107 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
2108 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
2109 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2110 * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
2111 * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
2112 * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
2113 * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp.
2114 (TestWebKitAPI::Util::run):
2115 (TestWebKitAPI::Util::sleep):
2116 (TestWebKitAPI::Util::toSTD):
2117 * TestWebKitAPI/config.h:
2118 * TestWebKitAPI/mac/JavaScriptTestMac.mm:
2119 * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2120 (TestWebKitAPI::Util::run): Deleted.
2121 (TestWebKitAPI::Util::sleep): Deleted.
2122 (TestWebKitAPI::Util::toSTD): Deleted.
2124 2014-12-18 Dániel Bátyai <dbatyai.u-szeged@partner.samsung.com>
2126 [GTK] Add support for FTL JIT on ARM64
2127 https://bugs.webkit.org/show_bug.cgi?id=139677
2129 Reviewed by Csaba Osztrogonác.
2131 * gtk/jhbuild-optional.modules:
2132 * gtk/patches/llvm-elf-add-stackmaps-arm64.patch: Added.
2133 * gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range-arm64.patch: Added.
2135 2014-12-18 Adrian Perez de Castro <aperez@igalia.com>
2137 [GTK] Implement webkit_web_view_is_playing_audio()
2138 https://bugs.webkit.org/show_bug.cgi?id=138918
2140 Reviewed by Carlos Garcia Campos.
2142 Add test case case for webkit_web_view_is_playing_audio() and the
2143 WebKitWebView::is-playing-audio property.
2145 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2146 (urlForResource): Utility function to get URLs pointing to resources
2147 under the Tools/TestWebKitAPI/Tests/WebKit2/ directory.
2148 (testWebViewIsPlayingAudio): Added.
2150 * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2151 (getResourcesDir): Allow passing a flag to choose from the WebKit2 GTK
2152 API tests resources directory, or the WebKit2 C API tests resources
2153 directory. The default value of the flag is to use the WebKit2 GTK
2154 one, to avoid having to change existing tests.
2155 * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2156 (isPlayingAudioChanged): Added.
2157 (WebViewTest::waitUntilIsPlayingAudioChanged): Added.
2158 * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2160 2014-12-18 Carlos Alberto Lopez Perez <clopez@igalia.com>
2162 [GTK] [EFL] Enable per_test_timeout
2163 https://bugs.webkit.org/show_bug.cgi?id=139771
2165 Reviewed by Csaba Osztrogonác.
2167 This is needed to make WKTR use either the default port timeout, or the
2168 user supplied timeout via the "--time-out-ms" parameter of run-webkit-tests.
2169 Otherwise WTR will use the default (30 seconds after r177363 and r177471).
2171 * Scripts/webkitpy/port/efl.py:
2172 (EflPort.supports_per_test_timeout): Enabled.
2173 * Scripts/webkitpy/port/gtk.py:
2174 (GtkPort.supports_per_test_timeout): Enabled.
2176 2014-12-17 Lucas Forschler <lforschler@apple.com>
2178 Move Apple buildbot slaves to their new home.
2180 Reviewed by Roger Fong.
2182 * BuildSlaveSupport/build.webkit.org-config/config.json:
2184 2014-12-17 Alexey Proskuryakov <ap@apple.com>
2186 REGRESSION (r177363): Gtk and Efl testing is broken
2187 https://bugs.webkit.org/show_bug.cgi?id=139734
2189 Reviewed by Simon Fraser.
2191 * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2192 (SingleTestRunner.__init__): Remove timeout adjustment from here, because it
2193 affected both script and tool timeout. This is still the right place for this logic,
2194 but it would be a larger refactoring than I can do right now.
2196 * Scripts/webkitpy/port/base.py:
2197 (Port.supports_per_test_timeout): Added a FIXME.
2198 (Port.default_timeout_ms): Now that the effective timeout is longer, change this
2199 to avoid making tests take more time.
2201 * Scripts/webkitpy/port/driver.py:
2202 (Driver.run_test): Adjust script timeout here.
2203 (Driver._check_for_driver_timeout): Fix the timeout detection.
2204 (Driver._read_block): Actually use the timeout detection code.
2206 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):
2207 Use TestRunner default timeout when there isn't a timeout passed from command line for the test.
2209 * Scripts/webkitpy/port/port_testcase.py: (PortTestCase.test_default_timeout_ms):
2210 Update results for the new default.
2212 * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2213 (RunTest.test_hung_thread): Restore a test that I previously deleted, it was
2214 actually a good one.
2216 2014-12-17 Commit Queue <commit-queue@webkit.org>
2218 Unreviewed, rolling out r177456.
2219 https://bugs.webkit.org/show_bug.cgi?id=139749
2221 Broke webkitpy and Mac tests (Requested by ap on #webkit).
2225 "REGRESSION (r177363): Gtk and Efl testing is broken"
2226 https://bugs.webkit.org/show_bug.cgi?id=139734
2227 http://trac.webkit.org/changeset/177456
2229 2014-12-17 Alexey Proskuryakov <ap@apple.com>
2231 REGRESSION (r177363): Gtk and Efl testing is broken
2232 https://bugs.webkit.org/show_bug.cgi?id=139734
2234 Reviewed by Simon Fraser.
2236 * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2237 (SingleTestRunner.__init__): Remove timeout adjustment from here, because it
2238 affected both script and tool timeout. This is still the right place for this logic,
2239 but it would be a larger refactoring than I can do right now.
2241 * Scripts/webkitpy/port/base.py:
2242 (Port.supports_per_test_timeout): Added a FIXME.
2243 (Port.default_timeout_ms): Now that the effective timeout is longer, change this
2244 to avoid making tests take more time.
2246 * Scripts/webkitpy/port/driver.py: (Driver.run_test): Adjust script timeout here.
2248 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):
2249 Use TestRunner default timeout when there isn't a timeout passed from command line for the test.
2251 2014-12-17 Carlos Garcia Campos <cgarcia@igalia.com>
2253 [GTK] Simplify timeout handling in TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded
2254 https://bugs.webkit.org/show_bug.cgi?id=139725
2256 Reviewed by Martin Robinson.
2258 The timeout is already in milliseconds, so we don't need to do any conversion.
2260 * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2261 (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2263 2014-12-17 Hunseop Jeong <hs85.jeong@samsung.com>
2265 [EFL]Fix build warning in MiniBrowser
2266 https://bugs.webkit.org/show_bug.cgi?id=139723
2268 Reviewed by Darin Adler.
2270 The warning is caused by the compiler wanting the first argument to be a
2271 string literal, not a dynamically created string.
2273 * MiniBrowser/efl/main.c:
2276 2014-12-16 Sam Weinig <sam@webkit.org>
2278 TestWebKitAPI should use a static lib to support both Mac and iOS cleanly
2279 https://bugs.webkit.org/show_bug.cgi?id=139718
2281 Reviewed by Mark Rowe.
2283 Change TestWebKitAPI to be more like DumpRenderTree by moving all the source
2284 files into a static lib which the command line utility can link link against.
2285 This will allow us to create a TestWebKitAPI.app that can run on iOS.
2287 * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2288 * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig: Added.
2289 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2291 2014-12-16 Alexey Proskuryakov <ap@apple.com>
2293 Sort out timeout implementations in DRT and WKTR
2294 https://bugs.webkit.org/show_bug.cgi?id=139671
2296 Remove an obsolete test that doesn't capture how run-webkit-tests interacts
2299 * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2300 (RunTest.test_hung_thread):
2302 2014-12-15 Alexey Proskuryakov <ap@apple.com>
2304 Sort out timeout implementations in DRT and WKTR
2305 https://bugs.webkit.org/show_bug.cgi?id=139671
2307 Reviewed by Simon Fraser.
2309 Test timeout implementation had many deficiencies, please see the bug for details.
2310 Most notably, we shouldn't have the tool confused about timeouts vs. failures, and
2311 [ Slow ] modifiers should work a lot better.
2313 * DumpRenderTree/TestRunner.cpp: (TestRunner::TestRunner):
2314 * DumpRenderTree/TestRunner.h: (TestRunner::setCustomTimeout):
2315 * DumpRenderTree/mac/DumpRenderTree.mm: (runTest):
2316 * DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::setWaitToDump):
2317 DumpRenderTree already read the --timeout option from command line, and webkitpy
2318 was already configured to pass it on Mac and iOS. Let's actually use it.
2319 TestCommand already had the same 30 second default, so this doesn't change behavior
2320 when DRT is ran manually without the option.
2321 Windows DumpRenderTree will need to be fixed separately (that's easy).
2323 * DumpRenderTree/TestRunner.cpp: (TestRunner::waitToDumpWatchdogTimerFired()):
2324 Don't print the timeout message to stdout to match WebKitTestRunner. It would be
2325 slightly better to use stderr in both, as this is an out of band message, but
2326 that's a larger refactoring, and the difference is minimal in practice.
2328 * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2329 (SingleTestRunner.__init__): Ensure that script and tool timeouts are substantially
2330 different. We want the tool to reliably detect timeouts that can be detected, and
2331 not race with the script for that.
2333 * Scripts/webkitpy/port/base.py: (Port.default_timeout_ms): Don't make WebKit2
2334 timeout longer than WebKit1 one, I doubt that this is necessary. Now that the value
2335 is honored inmore cases, that could make tests run slower.
2336 * Scripts/webkitpy/port/driver.py:
2340 (Driver._check_for_driver_timeout):
2341 Detect tests that have the timeout output, and make these have the proper Timeout result.
2343 * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.default_timeout_ms): Remove an
2344 incorrect recent change - 80 * 1000 is 80 seconds, not 80 milliseconds.
2346 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2347 (WTR::TestRunner::setCustomTimeout): Deleted.
2348 * WebKitTestRunner/InjectedBundle/TestRunner.h:
2349 (WTR::TestRunner::setCustomTimeout):
2350 * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
2351 (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2352 * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2353 (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2354 * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
2355 (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2356 * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2357 (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2358 Updated to use a timeout passed from UI process, which used to be ignored.
2360 * WebKitTestRunner/TestController.cpp:
2361 (WTR::TestController::TestController):
2362 (WTR::TestController::runUntil):
2363 (WTR::TestController::getCustomTimeout): Deleted.
2364 * WebKitTestRunner/TestController.h:
2365 Delete unused m_timeout. First, it was always 0, and second, we don't need it at all.
2366 Changed default message timeouts to match new run-webkit-tests timeout. These don't
2367 affect ports where timeout is passed per test (shouldn't they all be like that?).
2369 * WebKitTestRunner/TestInvocation.cpp:
2370 (WTR::TestInvocation::invoke):
2371 (WTR::TestInvocation::setCustomTimeout): Deleted.
2372 * WebKitTestRunner/TestInvocation.h:
2373 (WTR::TestInvocation::setCustomTimeout):
2374 (WTR::TestInvocation::customTimeout):
2377 2014-12-16 Grzegorz Czajkowski <g.czajkowski@samsung.com>
2379 [EFL] Add logging domain for MiniBrowser
2380 https://bugs.webkit.org/show_bug.cgi?id=139642
2382 Reviewed by Gyuyoung Kim.
2384 Similarly to EWebKit2, provide logging facility for MiniBrowser
2385 based on Eina Log module to have a convenient way to display
2386 all/subset/none messages for EFL based libraries and MiniBrowser.
2389 1. Disable all messages:
2390 EINA_LOG_LEVEL=0 ./Tools/Scripts/run-launcher --efl
2392 2. Enable all messages:
2393 EINA_LOG_LEVEL=7 ./Tools/Scripts/run-launcher --efl
2395 3. Enable MiniBrowser and EWebkit2 messages only:
2396 EINA_LOG_LEVELS="minibrowser:7,ewebkit2:7" ./Tools/Scripts/run-launcher --efl
2398 More information and examples you can find here:
2399 http://docs.enlightenment.org/auto/eet/tutorial_log_page.html
2401 * MiniBrowser/efl/main.c:
2404 (save_page_contents_callback):
2405 (script_execute_callback):
2407 (on_download_request):
2408 (on_download_finished):
2409 (on_download_failed):
2411 (on_refresh_button_clicked):
2412 (on_stop_button_clicked):
2413 (navigation_button_longpress_process):
2414 (on_popup_menu_item_clicked):
2415 (popup_menu_populate):
2416 (on_popup_menu_show):
2418 (context_menu_item_selected_cb):
2419 (context_menu_populate):
2420 (on_context_menu_show):
2421 (on_context_menu_hide):
2422 (on_navigation_policy_decision):
2424 (parse_cookies_policy):
2427 (list_item_label_get):
2428 (on_popup_menu_hide):
2430 (on_home_button_clicked):
2431 Replace locally info() macro with newly introduced
2432 one which uses Eina Log module. There is no logic change.
2434 2014-12-15 Dániel Bátyai <dbatyai.u-szeged@partner.samsung.com>
2436 [EFL] FTL JIT not working on ARM64
2437 https://bugs.webkit.org/show_bug.cgi?id=139295
2439 Reviewed by Michael Saboff.
2441 Added patches for llvm to add ARM64 support for FTL JIT
2443 * efl/jhbuild.modules:
2444 * efl/patches/llvm-elf-add-stackmaps-arm64.patch: Added.
2445 * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range-arm64.patch: Added.
2447 2014-12-15 Timothy Horton <timothy_horton@apple.com>
2449 Move Said to the committers section.
2451 * Scripts/webkitpy/common/config/contributors.json:
2453 2014-12-15 Timothy Horton <timothy_horton@apple.com>
2455 Implement Data Detectors immediate actions for WebKit2
2456 https://bugs.webkit.org/show_bug.cgi?id=139617
2457 <rdar://problem/19198539>
2459 Reviewed by Beth Dakin.
2461 * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
2462 (TestWebKitAPI::TEST):
2463 Temporarily disable the action menu tests while the
2464 underlying code is in flux.
2466 2014-12-14 Andreas Kling <akling@apple.com>
2468 Replace PassRef with Ref/Ref&& across the board.
2469 <https://webkit.org/b/139587>
2471 Reviewed by Darin Adler.
2473 * TestWebKitAPI/Tests/WTF/Ref.cpp:
2474 (TestWebKitAPI::passWithRef):
2475 (TestWebKitAPI::TEST):
2476 (TestWebKitAPI::passWithPassRef): Deleted.
2477 * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
2478 (TestWebKitAPI::TEST):
2479 * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
2480 (TestWebKitAPI::TEST):
2481 * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
2482 (TestWebKitAPI::createTestValue):
2484 2014-12-13 Grzegorz Czajkowski <g.czajkowski@samsung.com>
2486 [EFL] MiniBrowser's window_create may return NULL
2487 https://bugs.webkit.org/show_bug.cgi?id=139585
2489 Reviewed by Gyuyoung Kim.
2491 Move NULL checking before using object which window_create
2494 * MiniBrowser/efl/main.c:
2497 2014-12-12 Alexey Proskuryakov <ap@apple.com>
2499 Layout Test http/tests/loading/307-after-303-after-post.html is flaky
2500 https://bugs.webkit.org/show_bug.cgi?id=73030
2502 Reviewed by Anders Carlsson.
2504 * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): Set icon
2505 database to empty to avoid having it fetch default favicons at random times.
2506 DumpRenderTree also disables it, and also it has a way for tests to temporarily
2509 2014-12-12 Lucas Forschler <lforschler@apple.com>
2511 Update Apple owned build slaves after infrastructure update.
2513 Reviewed by Ryosuke Niwa.
2515 * BuildSlaveSupport/build.webkit.org-config/config.json:
2517 2014-12-11 Carlos Alberto Lopez Perez <clopez@igalia.com>
2519 [GTK] REGRESSION(r175555) GTK API Tests run outside the JHBuild.
2520 https://bugs.webkit.org/show_bug.cgi?id=139537
2522 Reviewed by Carlos Garcia Campos.
2524 * jhbuild/jhbuild-wrapper: Pass the port name in the invocation
2525 of get_dependencies_path().
2526 * jhbuild/jhbuildutils.py:
2527 (get_dependencies_path): Fix the function to return the new
2528 dependencies path: DependenciesPORT.
2529 (enter_jhbuild_environment_if_available): Pass the port name
2530 when invoking get_dependencies_path().
2532 2014-12-10 Lucas Forschler <lforschler@apple.com>
2534 Update Apple owned build slaves.
2536 Rubber-stamped by Dana Burkart.
2538 * BuildSlaveSupport/build.webkit.org-config/config.json:
2540 2014-12-10 Daniel Bates <dabates@apple.com>
2542 [iOS] REGRESSION (r174642): Watchdog timer expiration reported as DumpRenderTree.app
2543 timeout instead of test failure
2544 https://bugs.webkit.org/show_bug.cgi?id=139525
2546 Reviewed by Zalan Bujtas.
2548 Increase the default process timeout limit in run-webkit-tests to 80ms to prevent
2549 run-webkit-tests from prematurely terminating DumpRenderTree.app before it dumps
2552 Following <http://trac.webkit.org/changeset/174642>, DumpRenderTree.app waits
2553 for the WebThread to spin its run loop before dumping its output. A test that
2554 calls testRunner.waitUntilDone() and does not subsequently call testRunner.notifyDone()
2555 before DumpRenderTree.app's watchdog timer expires may be incorrectly reported
2556 by run-webkit-tests as a DumpRenderTree.app timeout instead of a test failure
2557 because run-webkit-tests may terminate a DumpRenderTree.app process when it
2558 exceeds its process time limit (defaults to 35ms) regardless of whether such
2559 a DumpRenderTree.app process was waiting for the WebThread to run so as to dump output.
2561 * Scripts/webkitpy/port/ios.py:
2562 (IOSSimulatorPort.default_timeout_ms):
2564 2014-12-09 Gustavo Noronha Silva <gustavo.noronha@collabora.com>
2566 [GTK][WK2] Add HTML5 Notifications support
2567 https://bugs.webkit.org/show_bug.cgi?id=61140
2569 Reviewed by Carlos Garcia Campos.
2571 * Scripts/webkitperl/FeatureList.pm: enable notifications for GTK+.
2572 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2573 (testWebViewNotification):
2575 * MiniBrowser/gtk/BrowserWindow.c: also handle notification permission requests.
2576 (permissionRequestDialogCallback):
2577 (webViewDecidePermissionRequest):
2578 (geolocationRequestDialogCallback): Deleted.
2580 2014-12-09 Benjamin Poulain <bpoulain@apple.com>
2582 Fix webkitpy test expectation
2584 Not sure what I messed up, but TOTAL_SKIPS was not right.
2586 * Scripts/webkitpy/port/test.py:
2588 2014-12-09 Benjamin Poulain <bpoulain@apple.com>
2590 Remove virtual test support from webkitpy
2591 https://bugs.webkit.org/show_bug.cgi?id=139427
2593 Reviewed by Alexey Proskuryakov.
2595 It seems that the only concrete client of virtual tests is the unit tests :D
2597 This patch tries to clean as much useless code as possible.
2599 * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2600 (RunTest.test_tolerance):
2601 (RunTest.test_virtual): Deleted.
2602 * Scripts/webkitpy/layout_tests/views/printing.py:
2603 (Printer._print_test_trace):
2604 * Scripts/webkitpy/port/base.py:
2605 (Port.expected_filename):
2609 (Port.sample_process):
2610 (Port.find_system_pid):
2611 (Port.test_expectations_file_position):
2612 (Port.virtual_test_suites): Deleted.
2614 (Port.populated_virtual_test_suites): Deleted.
2615 (Port._virtual_tests): Deleted.
2616 (Port.lookup_virtual_test_base): Deleted.
2617 (Port.lookup_virtual_test_args): Deleted.
2618 (VirtualTestSuite): Deleted.
2619 (VirtualTestSuite.__init__): Deleted.
2620 (VirtualTestSuite.__repr__): Deleted.
2621 * Scripts/webkitpy/port/base_unittest.py:
2622 (PortTest.test_test_exists):
2623 (PortTest.test_test_isfile):
2624 (PortTest.test_test_isdir):
2625 (PortTest.test_tests):
2626 * Scripts/webkitpy/port/driver.py:
2627 (DriverProxy.run_test): Deleted.
2628 * Scripts/webkitpy/port/test.py:
2629 (TestPort._skipped_tests_for_unsupported_features):
2630 (TestPort.all_baseline_variants):
2631 (TestPort.virtual_test_suites): Deleted.
2632 * Scripts/webkitpy/tool/commands/queries.py:
2633 (PrintBaselines.__init__):
2634 (PrintBaselines.execute):
2635 * Scripts/webkitpy/tool/commands/queries_unittest.py:
2636 (PrintBaselinesTest.test_basic):
2637 (PrintBaselinesTest.test_multiple):
2638 (PrintBaselinesTest.test_csv):
2640 2014-12-09 Csaba Osztrogonác <ossy@webkit.org>
2642 Blink Merge: Remove 'http_lock' code from webkitpy
2643 https://bugs.webkit.org/show_bug.cgi?id=136722
2645 Reviewed by Alexey Proskuryakov.
2647 Based on Blink commit by Dirk Pranke <dpranke@chromium.org>
2648 https://chromium.googlesource.com/chromium/blink/+/196f8146a948275c2f1594b13e30ab19a6e6fd66
2650 * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2651 (LayoutTestRunner.__init__):
2652 (LayoutTestRunner.run_tests):
2653 (LayoutTestRunner.start_servers): Renamed from start_servers_with_lock.
2654 (LayoutTestRunner.stop_servers): Renamed from stop_servers_with_lock.
2655 * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
2656 (FakePrinter.flush):
2657 (LayoutTestRunnerTests._runner):
2658 (LayoutTestRunnerTests._run_tests):
2659 (LayoutTestRunnerTests.test_servers_started):
2660 (LockCheckingRunner): Deleted.
2661 (LockCheckingRunner.__init__): Deleted.
2662 (LockCheckingRunner.handle_finished_list): Deleted.
2663 (LayoutTestRunnerTests.test_http_locking): Deleted.
2664 * Scripts/webkitpy/port/base.py:
2666 (Port.to.http_server_supports_ipv6):
2667 (Port.to.stop_websocket_server):
2668 (Port.to.acquire_http_lock): Deleted.
2669 (Port.to.release_http_lock): Deleted.
2670 * Scripts/webkitpy/port/http_lock.py: Removed.
2671 * Scripts/webkitpy/port/http_lock_unittest.py: Removed.
2672 * Scripts/webkitpy/port/ios.py:
2673 (IOSSimulatorPort.show_results_html_file):
2674 (IOSSimulatorPort.acquire_http_lock): Deleted.
2675 (IOSSimulatorPort): Deleted.
2676 (IOSSimulatorPort.release_http_lock): Deleted.
2677 * Scripts/webkitpy/port/mac.py:
2678 (MacPort.show_results_html_file):
2680 (MacPort.acquire_http_lock): Deleted.
2681 (MacPort.release_http_lock): Deleted.
2682 * Scripts/webkitpy/port/mock_drt.py:
2683 (MockDRTPort.start_websocket_server):
2684 (MockDRTPort.stop_websocket_server):
2685 (MockDRTPort.acquire_http_lock): Deleted.
2686 (MockDRTPort.release_http_lock): Deleted.
2687 * Scripts/webkitpy/port/mock_drt_unittest.py:
2688 (MockDRTPortTest.test_uses_apache):
2689 (MockDRTPortTest.integration_test_http_lock): Deleted.
2690 * Scripts/webkitpy/port/port_testcase.py:
2691 (PortTestCase.assert_servers_are_up):
2692 (PortTestCase.integration_test_http_lock): Deleted.
2693 * Scripts/webkitpy/port/test.py:
2694 (TestPort.start_websocket_server):
2695 (TestPort.stop_websocket_server):
2696 (TestPort.acquire_http_lock): Deleted.
2697 (TestPort.release_http_lock): Deleted.
2699 2014-12-09 Alberto Garcia <berto@igalia.com>
2701 convertToUTF8String converts null string to empty string
2702 https://bugs.webkit.org/show_bug.cgi?id=133904
2704 Reviewed by Carlos Garcia Campos.
2706 Test that trying to get the value of a non-existent attribute
2707 returns 0 instead of an empty string.
2709 * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
2710 (WebKitDOMNodeTest::testInsertion):
2712 2014-12-09 Joanmarie Diggs <jdiggs@igalia.com>
2714 [GTK] Bump minimum version of ATK used by jhbuild to at least 2.15.2
2715 https://bugs.webkit.org/show_bug.cgi?id=139070
2717 Reviewed by Carlos Garcia Campos.
2719 * gtk/jhbuild.modules:
2721 2014-12-08 Tim Horton <timothy_horton@apple.com>
2723 Add action menu tests
2724 https://bugs.webkit.org/show_bug.cgi?id=139156
2726 Reviewed by Dean Jackson.
2728 * TestWebKitAPI/PlatformWebView.h:
2729 * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2730 (TestWebKitAPI::PlatformWebView::PlatformWebView):
2731 Add a mechanism allowing tests to provide their own WKView subclass.
2733 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2734 * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Added.
2735 Add a file with lots of menu targets.
2737 * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: Added.
2738 (-[ActionMenusTestWKView _actionMenuItemsForHitTestResult:withType:defaultActionMenuItems:userData:]):
2739 (-[ActionMenusTestWKView runMenuSequenceAtPoint:preMenuNeedsUpdateHandler:preWillOpenMenuHandler:preDidCloseMenuHandler:]):
2740 (-[ActionMenusTestWKView runMenuSequenceAtPoint:preDidCloseMenuHandler:]):
2741 Run through the normal sequence of callbacks, recording what items and type were returned, and give clients a chance to do work at various points in the process.
2743 (-[ActionMenusTestWKView _setOverrideActionMenuItems:]):
2745 (TestWebKitAPI::didFinishLoadForFrameCallback):
2746 (TestWebKitAPI::didFinishDownloadCallback):
2747 (TestWebKitAPI::didCreateDownloadDestinationCallback):
2748 Watch downloads and ensure that they match the content we expect.
2750 (TestWebKitAPI::watchPasteboardForString):
2751 (TestWebKitAPI::watchPasteboardForImage):
2752 (TestWebKitAPI::JavaScriptStringCallbackContext::JavaScriptStringCallbackContext):
2753 (TestWebKitAPI::JavaScriptBoolCallbackContext::JavaScriptBoolCallbackContext):
2754 (TestWebKitAPI::javaScriptStringCallback):
2755 (TestWebKitAPI::javaScriptBoolCallback):
2756 (TestWebKitAPI::callJavaScriptReturningString):
2757 (TestWebKitAPI::callJavaScriptReturningBool):
2758 (TestWebKitAPI::watchEditableAreaForString):
2759 (TestWebKitAPI::waitForVideoReady):
2760 (TestWebKitAPI::retrieveSelection):
2761 (TestWebKitAPI::retrieveSelectionInElement):
2762 (TestWebKitAPI::performMenuItemAtIndexOfTypeAsync):
2763 (TestWebKitAPI::ensureMenuItemAtIndexOfTypeIsDisabled):
2764 Add many helpers for testing, especially to make asynchronous things synchronous.
2766 (TestWebKitAPI::windowPointForTarget):
2767 (TestWebKitAPI::inset8):
2768 Hard-code points in action-menu-targets.html for hit testing.
2770 (TestWebKitAPI::TEST):
2771 Add a suite of tests for WebKit2 action menus.
2773 * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm: Added.
2774 (TestWebKitAPI::createActionContextForPhoneNumber):
2775 (TestWebKitAPI::ActionMenuTest::ActionMenuTest):
2776 (TestWebKitAPI::ActionMenuTest::prepareForActionMenu):
2777 (TestWebKitAPI::ActionMenuTest::actionContextForResultAtPoint):
2778 (TestWebKitAPI::ActionMenuTest::drawRect):
2779 (TestWebKitAPI::ActionMenuTest::didCreatePage):
2780 Add a bundle with a PageOverlay and a actionContextForResultAtPoint override,
2781 so that we can test that infrastructure.
2783 2014-12-08 Philippe Normand <pnormand@igalia.com>
2785 [GTK] UserMedia Permission Request API
2786 https://bugs.webkit.org/show_bug.cgi?id=136449
2788 Reviewed by Carlos Garcia Campos.
2790 The GTK version of the MiniBrowser has gained UserMedia permission
2793 * MiniBrowser/gtk/BrowserWindow.c: Show a popup when the page
2794 requires user permission to access audio/video devices.
2795 (permissionRequestDialogCallback):
2796 (webViewDecidePermissionRequest):
2797 (geolocationRequestDialogCallback): Deleted.
2799 2014-12-08 Anders Carlsson <andersca@apple.com>
2801 Add a stubbed out method for clearing out the website data store
2802 https://bugs.webkit.org/show_bug.cgi?id=139404
2804 Reviewed by Antti Koivisto.
2806 Add a debug menu item for testing clearing of website data.
2808 * MiniBrowser/mac/MainMenu.xib:
2809 * MiniBrowser/mac/WK2BrowserWindowController.m:
2810 (-[WK2BrowserWindowController clearWebsiteData:]):
2812 2014-12-07 Gwang Yoon Hwang <yoon@igalia.com>
2814 Update style checker to deal with "const override"
2815 https://bugs.webkit.org/show_bug.cgi?id=139371
2817 Reviewed by Csaba Osztrogonác.
2819 check-webkit-style shouldn't complain about an open brace to start a
2820 line after a function definition with const override.
2822 * Scripts/webkitpy/style/checkers/cpp.py:
2824 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2825 (CppStyleTest.test_brace_at_begin_of_line):
2827 2014-12-07 Carlos Garcia Campos <cgarcia@igalia.com>
2829 [GTK] Fix GObject DOM bindings API break tests after r176920
2830 https://bugs.webkit.org/show_bug.cgi?id=139368
2832 Reviewed by Gustavo Noronha Silva.
2834 Remove the @version from the symbol name before comparing.
2836 * gtk/check-for-webkitdom-api-breaks:
2837 (read_expected_api):
2839 2014-12-07 Carlos Garcia Campos <cgarcia@igalia.com>
2841 Remove the option to automatically update the GObject DOM bindings symbols file
2842 https://bugs.webkit.org/show_bug.cgi?id=139366
2844 Reviewed by Martin Robinson.
2846 It's currently broken, because symbols now need to be in a
2847 specific order. Now that the symbols file only contains stable
2848 API, it's not a problem to manually update it every time new API
2851 * gtk/check-for-webkitdom-api-breaks:
2852 (read_expected_api):
2854 (write_expected_api): Deleted.
2856 2014-12-07 Carlos Garcia Campos <cgarcia@igalia.com>
2858 [GTK] Use GMainLoopSource in WebKitTestRunner
2859 https://bugs.webkit.org/show_bug.cgi?id=138831
2861 Reviewed by Sergio Villar Senin.
2863 * WebKitTestRunner/InjectedBundle/TestRunner.h:
2864 * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2865 (WTR::TestRunner::platformInitialize):
2866 (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
2867 (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2868 (WTR::waitToDumpWatchdogTimerCallback): Deleted.
2869 * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2870 (WTR::TestController::notifyDone):
2871 (WTR::TestController::platformRunUntil):
2872 (WTR::cancelTimeout): Deleted.
2874 2014-12-07 Carlos Garcia Campos <cgarcia@igalia.com>
2876 [GTK] Missing API detected in GObject DOM bindings after r176630
2877 https://bugs.webkit.org/show_bug.cgi?id=139201
2879 Reviewed by Gustavo Noronha Silva.
2881 Handle deprecated symbols again when generating the GObject DOM
2882 bindings documentation.
2885 (WebKitDOMDocGenerator):
2886 (WebKitDOMDocGenerator.is_deprecated_symbol_file):
2887 (WebKitDOMDocGenerator.generate):
2888 (WebKitDOMDocGeneratorSections.__init__):
2889 (WebKitDOMDocGeneratorSections._find_deprecated_symbols):
2890 (WebKitDOMDocGeneratorSections.write_section):
2892 2014-12-07 Csaba Osztrogonác <ossy@webkit.org>
2894 [EFL][jhbuild] Fix libsoup build with clang
2895 https://bugs.webkit.org/show_bug.cgi?id=139088
2897 Reviewed by Gyuyoung Kim.
2899 * efl/jhbuild.modules:
2900 * efl/patches/soup-clang-warning-fix1.patch: Added.
2901 * efl/patches/soup-clang-warning-fix2.patch: Added.
2903 2014-12-06 Alexey Proskuryakov <ap@apple.com>
2905 [Mac] DumpRenderTree sets storage directory incorrectly
2906 https://bugs.webkit.org/show_bug.cgi?id=139347
2908 Reviewed by Dan Bernstein.
2910 * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
2911 Don't use user defaults to pass per-instance paths, as user defaults are shared
2912 across all instances.
2914 2014-12-05 Chris Fleizach <cfleizach@apple.com>
2916 AX: I cannot activate links on the mobile version of news.google.com
2917 https://bugs.webkit.org/show_bug.cgi?id=139330
2919 Reviewed by Simon Fraser.
2921 Implement press for iOS.
2923 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2924 (AccessibilityUIElement::press):
2926 2014-12-05 Daniel Bates <dabates@apple.com>
2928 [iOS] Query -[WAKWindow screenScale] instead of using WKGetScreenScaleFactor()
2929 https://bugs.webkit.org/show_bug.cgi?id=139326
2931 Reviewed by Anders Carlsson.
2933 Ask the window for its screen scale factor instead of calling WKGetScreenScaleFactor()
2934 to query the OS for it. This approach will ensure DumpRenderTree takes the snapshot
2935 using the same scale factor as used in WebKit.
2937 * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2938 (createBitmapContextFromWebView):
2940 2014-12-05 Anders Carlsson <andersca@apple.com>
2942 REGRESSION (r176677): All tests crash on Windows
2943 https://bugs.webkit.org/show_bug.cgi?id=139321
2945 Reviewed by Alexey Proskuryakov.
2947 * DumpRenderTree/win/DumpRenderTree.cpp:
2949 Don't call CFRelease on the url while we have an outstanding pointer to its string,
2950 and use the right number of bytes when allocating the testURL buffer.
2952 2014-12-05 Daniel Bates <dabates@apple.com>
2954 [iOS] DumpRenderTree produces many reference test mismatches
2955 https://bugs.webkit.org/show_bug.cgi?id=139314
2957 Reviewed by Simon Fraser.
2959 Fixes an issue where the scale factor used to render the snapshot taken by
2960 DumpRenderTree may differ from the device scale factor. In particular, the
2961 scale factor used to render a snapshot of a test may differ from the scale
2962 factor used to render the snapshot of its expected result.
2964 Currently DumpRenderTree uses SPI, -[UIView newSnapshotForRect], on iOS to
2965 snapshot the UIWebBrowserView. This SPI always render using a scale factor
2966 of one when the backing store for the LegacyTileLayer objects were out-of-
2967 date regardless of the device scale factor. Instead we should use UIImage
2968 and CALayer API to perform the snapshot with respect to the device scale
2971 Additionally write iOS pixel dump support logic in terms of existing
2972 DumpRenderTree abstractions so as to support generating and comparing
2973 pixel dump checksums as well as make the iOS code more consistent with
2974 the logic used by other ports.
2976 * DumpRenderTree/PixelDumpSupport.cpp:
2977 (dumpWebViewAsPixelsAndCompareWithExpected): Removed !PLATFORM(IOS)-guard.
2978 * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2979 (BitmapContext::createFromUIImage): Added.
2980 (BitmapContext::pixelData): Added.
2981 (BitmapContext::BitmapContext): Added.
2982 (computeMD5HashStringForBitmapContext): Added.
2983 (dumpBitmap): Added.
2984 (createBitmapContextFromWebView): Moved logic from dumpWebViewAsPixelsAndCompareWithExpected() to here.
2985 (dumpWebViewAsPixelsAndCompareWithExpected): Deleted.
2987 2014-12-05 Anders Carlsson <andersca@apple.com>
2989 Give all web pages a website data store
2990 https://bugs.webkit.org/show_bug.cgi?id=139317
2992 Reviewed by Tim Horton.
2994 * MiniBrowser/mac/AppDelegate.m:
2995 (-[BrowserAppDelegate newPrivateWindow:]):
2996 Don't release the controller - it's implicitly retained by the window.
2998 2014-12-05 Daniel Bates <dabates@apple.com>
3000 [iOS] DumpRenderTree fails to render every other test when pixel tests are on
3001 https://bugs.webkit.org/show_bug.cgi?id=137581
3002 <rdar://problem/18642906>
3004 Reviewed by Simon Fraser.
3006 Fixes an issue where the DumpRenderTree snapshot may reflect the rendered content
3007 of the test that proceeded the currently running test.
3009 * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3010 (dumpWebViewAsPixelsAndCompareWithExpected): Ensure that UIKit has performed a layout
3011 of the UIWebBrowserView view. Also, remove unnecessary call to -[UIWebDocumentView layoutTilesNow]
3012 as -[UIWebDocumentView newSnapshotWithRect] will layout the tiles.
3014 2014-12-05 Jer Noble <jer.noble@apple.com>
3016 [WTF] MediaTime should support round-tripping from and to doubles.
3017 https://bugs.webkit.org/show_bug.cgi?id=139248
3019 Reviewed by Eric Carlson.
3021 Add API tests for new features of MediaTime. Update the LLDB python provider to correctly display
3022 the MediaTimes after this change.
3024 * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
3026 (TestWebKitAPI::TEST):
3027 * lldb/lldb_webkit.py:
3028 (WTFMediaTime_SummaryProvider):
3029 (WTFMediaTimeProvider.timeValueAsDouble):
3030 (WTFMediaTimeProvider.isIndefinite):
3031 (WTFMediaTimeProvider):
3032 (WTFMediaTimeProvider.hasDoubleValue):
3034 2014-12-05 Anders Carlsson <andersca@apple.com>
3036 Add a private browsing mode to MiniBrowser
3037 https://bugs.webkit.org/show_bug.cgi?id=139308
3039 Reviewed by Sam Weinig.
3041 * MiniBrowser/mac/AppDelegate.m:
3042 (defaultConfiguration):
3043 (-[BrowserAppDelegate newWindow:]):
3044 (-[BrowserAppDelegate newPrivateWindow:]):
3045 * MiniBrowser/mac/MainMenu.xib:
3046 * MiniBrowser/mac/WK2BrowserWindowController.h:
3047 * MiniBrowser/mac/WK2BrowserWindowController.m:
3048 (-[WK2BrowserWindowController awakeFromNib]):
3049 (-[WK2BrowserWindowController initWithConfiguration:]):
3050 (-[WK2BrowserWindowController dealloc]):
3051 (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
3053 2014-12-04 Alexey Proskuryakov <ap@apple.com>
3055 Run http tests parallel
3056 https://bugs.webkit.org/show_bug.cgi?id=138958
3058 Reviewed by Daniel Bates.
3060 Remove the concept of "locked shard". Now http tests are just like any other tests.
3061 We start HTTP and WebSocket servers at the start if we need them, and terminate them
3062 when done with all the tests (not when the last http test runs, which is unnecessarily
3065 This makes debug tests run in 8 minutes and 12 seconds on my Mac Pro. Without the
3066 patch, they used to take over 15 minutes.
3068 As part of the fix, we no longer pass the number of servers to Apache. I don't
3069 think that these parameters did what we wanted them to do; Apache handles the load
3070 just fine without them.
3072 The change applies to all platforms. I fixed everything I could find on Mac, and
3073 Ossy told me that he's been running http tests in parallel for a long time. If
3074 there is increased instability for some ports, it will need to be fixed - there is
3075 generally nothing special about http tests at this point, and most code is
3076 cross-platform in WebKit2.
3078 * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3079 (LayoutTestRunner.__init__):
3080 (LayoutTestRunner.run_tests):
3081 (LayoutTestRunner.start_servers_with_lock):
3082 (LayoutTestRunner._handle_started_test):
3085 (Sharder.shard_tests):
3086 (Sharder._shard_every_file):
3087 (Sharder._shard_by_directory):
3088 (LayoutTestRunner._handle_finished_test_list): Deleted.
3089 (LayoutTestRunner._handle_finished_test_list.find): Deleted.
3090 (Sharder._shard_in_two): Deleted.
3092 (Sharder._resize_shards): Deleted.
3093 (Sharder._resize_shards.divide_and_round_up): Deleted.
3094 (Sharder._resize_shards.extract_and_flatten): Deleted.
3095 (Sharder._resize_shards.split_at): Deleted.
3096 * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
3097 (FakePrinter.print_workers_and_shards):
3098 (LayoutTestRunnerTests.test_servers_started.start_http_server):
3099 (LayoutTestRunnerTests.test_servers_started):
3100 (SharderTests.get_shards):
3101 (SharderTests.test_shard_by_dir):
3102 (SharderTests.test_shard_every_file):
3103 (SharderTests): Deleted.
3104 (SharderTests.test_shard_in_two): Deleted.
3105 (SharderTests.test_shard_in_two_has_no_locked_shards): Deleted.
3106 (SharderTests.test_shard_in_two_has_no_unlocked_shards): Deleted.
3107 (SharderTests.test_multiple_locked_shards): Deleted.
3108 * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3109 (ManagerTest.test_needs_servers.get_manager):
3110 (ManagerTest.integration_test_needs_servers.get_manager):
3111 (ManagerTest.test_look_for_new_crash_logs.get_manager):
3113 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3114 (_set_up_derived_options):
3115 * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3116 (RunTest.test_batch_size):
3117 (RunTest.test_max_locked_shards): Deleted.
3118 * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3119 (LayoutTestApacheHttpd.__init__):
3120 * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
3121 (TestLayoutTestApacheHttpd.test_start_cmd):
3122 * Scripts/webkitpy/layout_tests/servers/http_server.py:
3123 (Lighttpd.__init__):
3124 * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
3125 (HttpServerBase.__init__):
3126 * Scripts/webkitpy/layout_tests/views/printing.py:
3127 (Printer.print_workers_and_shards):
3128 * Scripts/webkitpy/port/base.py:
3129 (Port.default_child_processes):
3130 (Port.to.start_http_server):
3131 (Port.default_max_locked_shards): Deleted.
3132 * Scripts/webkitpy/port/port_testcase.py:
3133 (PortTestCase.make_port):
3134 (PortTestCase.test_default_max_locked_shards): Deleted.
3135 * Scripts/webkitpy/port/test.py:
3136 (TestPort.start_http_server):
3138 2014-12-04 Alexey Proskuryakov <ap@apple.com>
3140 Don't lock perf tests in run-webkit-tests
3141 https://bugs.webkit.org/show_bug.cgi?id=139264
3143 Reviewed by Daniel Bates.
3145 * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3146 * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
3147 * Scripts/webkitpy/layout_tests/controllers/manager.py:
3148 * Scripts/webkitpy/layout_tests/models/test_input.py:
3149 * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3151 2014-12-03 Alexey Proskuryakov <ap@apple.com>
3153 http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html fails unless certain other tests run before it
3154 https://bugs.webkit.org/show_bug.cgi?id=139243
3156 Reviewed by Anders Carlsson.
3158 We didn't get WKPageLoaderClient calls in secondary windows, so we didn't have a
3159 chance to allow untrusted certificates.
3161 * WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage):
3162 Set up more client objects for secondary windows. We may be able to share some of the
3163 code with main view creation function, but it's not exactly the same (notably, we
3164 do not focus a secondary window when it's done loading).
3166 2014-12-03 Joanmarie Diggs <jdiggs@igalia.com>
3168 AX: [ATK] Inline text elements with accessible object attributes and/or event handlers are not exposed
3169 https://bugs.webkit.org/show_bug.cgi?id=139071
3171 Reviewed by Chris Fleizach.
3173 Add string value for ATK_ROLE_STATIC in roleToString.
3175 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3177 2014-12-03 Renato Nagy <rnagy@inf.u-szeged.hu>
3179 check-webkit-style is confused by ternary expression inside first member initializer
3180 https://bugs.webkit.org/show_bug.cgi?id=136442
3182 Reviewed by Csaba Osztrogonác.
3184 * Scripts/webkitpy/style/checkers/cpp.py:
3185 (check_member_initialization_list):
3187 2014-12-03 Carlos Alberto Lopez Perez <clopez@igalia.com>
3189 [GTK] [JHBuild] gst-plugins-bad fails to build if the GNUStep libraries are installed.
3190 https://bugs.webkit.org/show_bug.cgi?id=139220
3192 Reviewed by Philippe Normand.
3194 * gtk/jhbuild.modules:
3195 * gtk/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
3197 2014-12-03 Zsolt Borbely <zsborbely.u-szeged@partner.samsung.com>
3199 Remove unused JSC runtime options
3200 https://bugs.webkit.org/show_bug.cgi?id=133070
3202 Reviewed by Csaba Osztrogonác.
3204 * Scripts/run-jsc-stress-tests:
3206 2014-12-03 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
3208 [EFL] Add subtle crypto to the build system
3209 https://bugs.webkit.org/show_bug.cgi?id=138612
3211 Reviewed by Csaba Osztrogonác.
3213 * Scripts/webkitperl/FeatureList.pm:
3215 2014-12-02 Joanmarie Diggs <jdiggs@igalia.com>
3217 AX: [ATK] Table captions and table rows are missing from the accessible hierarchy
3218 https://bugs.webkit.org/show_bug.cgi?id=139005
3220 Reviewed by Chris Fleizach.
3222 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3223 Add mapping for ATK_ROLE_CAPTION to roleToString
3225 2014-12-02 Alexey Proskuryakov <ap@apple.com>
3227 http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests
3228 https://bugs.webkit.org/show_bug.cgi?id=139149
3230 Reviewed by Anders Carlsson.
3232 WebKit2 already cleared application caches between runs (although it wasn't entirely
3233 effective without WebCore changes in this patch).
3235 * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Clear applicaiton caches between runs.
3237 * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ditto (unfortunately, this
3238 function is not implemented on Windows, see below).
3240 * DumpRenderTree/win/TestRunnerWin.cpp: (TestRunner::clearAllApplicationCaches):
3243 2014-12-02 Gavin Barraclough <barraclough@apple.com>
3245 Generalize PageActivityAssertionToken
3246 https://bugs.webkit.org/show_bug.cgi?id=139106
3248 Reviewed by Sam Weinig.
3250 Add an API test for WTF::RefCounter.
3252 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3253 * TestWebKitAPI/Tests/WTF/RefCounter.cpp: Added.
3254 (TestWebKitAPI::TEST):
3255 - added RefCounter test.
3257 2014-12-02 Alexey Proskuryakov <ap@apple.com>
3259 [Mac, iOS] Crash log application information contains latest main frame URL instead of test URL
3260 https://bugs.webkit.org/show_bug.cgi?id=139174
3262 Reviewed by Simon Fraser.
3264 * DumpRenderTree/TestRunner.cpp:
3265 * DumpRenderTree/TestRunner.h:
3266 Renamed testPathOrURL to testURL, because this variable always contains a URL.
3268 * DumpRenderTree/mac/DumpRenderTree.mm:
3269 (sizeWebViewForCurrentTest): Updated for testPathOrURL renaming.
3270 (testPathFromURL): Moved from FrameLoadDelegate.mm.
3271 (runTest): Set crash reporter information here, as we know the exact test URL.
3273 * DumpRenderTree/mac/FrameLoadDelegate.mm:
3274 (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): Don't set crash
3275 reporter information here.
3277 * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3278 * DumpRenderTree/mac/TestRunnerMac.mm:
3279 Updated for testPathOrURL renaming.
3281 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3282 (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): WebProcess doesn't know
3283 test URL until load starts, so save it into TestRunner now. A new TestRunner object
3284 is created for each test.
3286 * WebKitTestRunner/InjectedBundle/TestRunner.h:
3287 (WTR::TestRunner::testURL):
3288 (WTR::TestRunner::setTestURL):
3289 Make TestRunner know the test name. For now, it's good enough to have it once load
3290 starts, but if we ever need it earlier, we can send it with BeginTest message.
3292 * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
3293 (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
3294 Use test URL, not currently loading URL for CrashReporter.
3296 * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
3297 (WTR::setCrashReportApplicationSpecificInformationToURL): Added a space after colon
3298 (WebKit1 already had it right).
3300 * DumpRenderTree/win/DumpRenderTree.cpp:
3301 (sizeWebViewForCurrentTest):
3303 * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3304 (ResourceLoadDelegate::willSendRequest):
3305 Changed Windows DumpRenderTree to also use URL in TestRunner.
3307 2014-12-02 Daniel Bates <dabates@apple.com>
3309 [iOS] run-webkit-tests records most DumpRenderTree.app crashes as time-outs
3310 https://bugs.webkit.org/show_bug.cgi?id=139143
3312 Reviewed by David Kilzer.
3314 Similar to the Windows-specific fix in <https://bugs.webkit.org/show_bug.cgi?id=37859>,
3315 teach DumpRenderTree for iOS to write "#CRASHED" to the standard error stream when it
3316 crashes. Run-webkit-tests will record as crashing the test associated with the
3317 DumpRenderTree instance that wrote that string.
3319 Currently almost all of the DumpRenderTree.app crashes are recorded by run-
3320 webkit-tests as a time-out because ReportCrash(8) delays delivery of the
3321 process exit notification for DumpRenderTree.app to LayoutTestRelay, which
3322 launched DumpRenderTree.app, past the time-out time limit. Notice LayoutTestRelay
3323 was launched by run-webkit-tests. So, run-webkit-tests kills LayoutTestRelay
3324 (since it exceeded the time-out time limit) before it can inform rub-webkit-tests
3327 Additionally, update the crash message format written to standard error when LayoutTestRelay
3328 detects that {WebKitTestRunner, DumpRenderTree}.app crashed so as to be similar to the
3329 crash message format used by WebKitTestRunner when it detects that the WebProcess crashed.
3330 Then run-webkit-tests will collect the crash logs for {WebKitTestRunner, DumpRenderTree}.app
3331 when they crash in their test machinery logic/UI process code.
3333 * DumpRenderTree/mac/DumpRenderTree.mm:
3334 (writeCrashedMessageOnFatalError): Added.
3335 (dumpRenderTree): Register signal handler, writeCrashedMessageOnFatalError(), for signals:
3336 SIGILL, SIGFPE, SIGBUS and SIGSEGV.
3337 * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3338 (-[LTRelayController didCrashWithMessage:]): Emit a crash message with a format
3339 similar to the format used by WebKitTestRunner so that run-webkit-tests will collect
3340 the crash logs for WebKitTestRunner/DumpRenderTree.app.
3341 * Scripts/webkitpy/port/driver.py:
3342 (Driver.__init__): Update comment.
3343 (Driver._check_for_driver_crash): Ditto.
3344 * Scripts/webkitpy/port/ios.py:
3345 (IOSSimulatorPort): Add class constant SUBPROCESS_CRASH_REGEX, which represents a compiled
3346 regular expression. This constant is used as an optimization to avoid compiling the same
3347 regular expression across invocations of _get_crash_log().
3348 (IOSSimulatorPort._get_crash_log): Modified to parse the WebKitTestRunner-like crash message
3349 for the subprocess name and pid. Also, moved variables crash_log, crash_logs, and now to be
3350 closer to where they are used.
3352 2014-12-01 Anders Carlsson <andersca@apple.com>
3354 Remove WKBundleRemoveAllVisitedLinks
3355 https://bugs.webkit.org/show_bug.cgi?id=139163
3357 Reviewed by Sam Weinig.
3359 Remove the call to WKBundleRemoveAllVisitedLinks and add a FIXME instead.
3361 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3362 (WTR::InjectedBundle::beginTesting):
3363 * WebKitTestRunner/TestInvocation.cpp:
3364 (WTR::TestInvocation::invoke):
3366 2014-12-02 Anders Carlsson <andersca@apple.com>
3370 * DumpRenderTree/win/DumpRenderTree.cpp:
3371 (setAlwaysAcceptCookies):
3373 2014-12-02 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
3375 [EFL] Remove edbus dependency from jhbuild
3376 https://bugs.webkit.org/show_bug.cgi?id=139130
3378 Reviewed by Gyuyoung Kim.
3380 After http://trac.webkit.org/changeset/176555 we
3381 don't need it anymore.
3383 * efl/jhbuild.modules:
3385 2014-12-02 Philippe Normand <pnormand@igalia.com>
3387 [jhbuild] wrong Dependencies path
3388 https://bugs.webkit.org/show_bug.cgi?id=139176
3390 Reviewed by Martin Robinson.
3392 * Scripts/webkitpy/port/base.py:
3393 (Port._should_use_jhbuild):
3395 2014-12-02 Philippe Normand <pnormand@igalia.com>
3397 [GStreamer] Bump internal jhbuild versions to 1.4.4
3398 https://bugs.webkit.org/show_bug.cgi?id=138866
3400 Reviewed by Carlos Garcia Campos.
3402 * gtk/jhbuild.modules:
3403 * gtk/patches/gst-events-arent-gstobjects.patch: Removed.
3404 * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Removed.
3405 * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
3407 2014-12-01 Commit Queue <commit-queue@webkit.org>
3409 Unreviewed, rolling out r176566.
3410 https://bugs.webkit.org/show_bug.cgi?id=139124
3412 It broke the GTK performance tests. (Requested by clopez on
3417 "[GTK] Use GMainLoopSource in WebKitTestRunner"
3418 https://bugs.webkit.org/show_bug.cgi?id=138831
3419 http://trac.webkit.org/changeset/176566
3421 2014-11-29 Anders Carlsson <andersca@apple.com>
3423 Crash when calling WKPageClose on the originated page from within createNewPage callback
3424 https://bugs.webkit.org/show_bug.cgi?id=139099
3425 <rdar://problem/19052564>
3427 Reviewed by Sam Weinig.
3431 * TestWebKitAPI/PlatformWebView.h:
3432 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3433 * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp: Added.
3434 (TestWebKitAPI::runJavaScriptAlert):
3435 (TestWebKitAPI::createNewPage):
3436 (TestWebKitAPI::TEST):
3437 * TestWebKitAPI/Tests/WebKit2/close-from-within-create-page.html: Added.
3438 * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3439 (TestWebKitAPI::PlatformWebView::PlatformWebView):
3441 2014-11-28 Commit Queue <commit-queue@webkit.org>
3443 Unreviewed, rolling out r176564.
3444 https://bugs.webkit.org/show_bug.cgi?id=139093
3446 massive failures on release test bot (Requested by philn on
3451 "[GStreamer] Bump internal jhbuild versions to 1.4.4"
3452 https://bugs.webkit.org/show_bug.cgi?id=138866
3453 http://trac.webkit.org/changeset/176564
3455 2014-11-28 Carlos Garcia Campos <cgarcia@igalia.com>
3457 [GTK] Use GMainLoopSource in WebKitTestRunner
3458 https://bugs.webkit.org/show_bug.cgi?id=138831
3460 Reviewed by Sergio Villar Senin.
3462 * WebKitTestRunner/InjectedBundle/TestRunner.h:
3463 * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
3464 (WTR::TestRunner::platformInitialize):
3465 (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
3466 (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
3467 (WTR::waitToDumpWatchdogTimerCallback): Deleted.
3468 * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3469 (WTR::TestController::notifyDone):
3470 (WTR::TestController::platformRunUntil):
3471 (WTR::cancelTimeout): Deleted.
3473 2014-11-24 Philippe Normand <pnormand@igalia.com>
3475 [GStreamer] Bump internal jhbuild versions to 1.4.4
3476 https://bugs.webkit.org/show_bug.cgi?id=138866
3478 Reviewed by Carlos Garcia Campos.
3480 * gtk/jhbuild.modules:
3481 * gtk/patches/gst-events-arent-gstobjects.patch: Removed.
3482 * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Removed.
3483 * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
3485 2014-11-28 Carlos Garcia Campos <cgarcia@igalia.com>
3487 [GTK] Use custom JavaScript instead of DBus to implement WebProcess tests
3488 https://bugs.webkit.org/show_bug.cgi?id=138834
3490 Reviewed by Sergio Villar Senin.
3492 It makes everyting simpler and the tests run faster too, since we
3493 don't need to spawn the private bus and wait until the DBus name
3494 is registered. The web extension registers a new JavaSCript class
3495 with a status method to run the tests, similar to the DBus
3496 method. In the UI process side, tests use webkit_web_view_run_java_script()
3497 instead of sending a DBus message.
3499 * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3500 * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
3501 (WebKitDOMNodeFilterTest::create):
3502 (WebKitDOMNodeFilterTest::testTreeWalker):
3503 (WebKitDOMNodeFilterTest::testNodeIterator):
3504 (WebKitDOMNodeFilterTest::webPageFromArgs): Deleted.
3505 (WebKitDOMNodeFilterTest::runTest): Deleted.
3506 * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
3507 (WebKitDOMNodeTest::create):
3508 (WebKitDOMNodeTest::testHierarchyNavigation):
3509 (WebKitDOMNodeTest::testInsertion):
3510 (WebKitDOMNodeTest::testTagNames):
3511 (WebKitDOMNodeTest::webPageFromArgs): Deleted.
3512 (WebKitDOMNodeTest::runTest): Deleted.
3513 * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
3514 (WebKitDOMXPathNSResolverTest::create):
3515 (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
3516 (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
3517 (WebKitDOMXPathNSResolverTest::webPageFromArgs): Deleted.
3518 (WebKitDOMXPathNSResolverTest::runTest): Deleted.
3519 * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:
3520 (WebKitFrameTest::create):
3521 (WebKitFrameTest::testMainFrame):
3522 (WebKitFrameTest::testURI):
3523 (WebKitFrameTest::testJavaScriptContext):
3524 (WebKitFrameTest::webPageFromArgs): Deleted.
3525 (WebKitFrameTest::runTest): Deleted.
3526 * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
3527 (testWebKitDOMNodeHierarchyNavigation):
3528 (testWebKitDOMNodeInsertion):
3529 (testWebKitDOMNodeTagNames):
3532 * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp:
3536 * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
3537 (testWebKitDOMXPathNSResolverNative):
3538 (testWebKitDOMXPathNSResolverCustom):
3542 * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp:
3543 (webkitFrameTestRun):
3546 * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
3548 (WebProcessTest::add):
3549 (WebProcessTest::create):
3551 (windowObjectClearedCallback):
3552 (webkit_web_extension_initialize):
3553 (methodCallCallback): Deleted.
3554 (webkit_web_extension_initialize_with_user_data): Deleted.
3555 * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
3556 * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp: Removed.
3557 * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.h: Removed.
3558 * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
3559 (WebViewTest::runWebProcessTest):
3560 * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
3562 2014-11-28 Csaba Osztrogonác <ossy@webkit.org>
3564 [EFL] libseccomp should pick up CC environment variable to be conform to other jhbuild modules
3565 https://bugs.webkit.org/show_bug.cgi?id=139086
3567 Reviewed by Gyuyoung Kim.
3569 * efl/jhbuild.modules:
3570 * efl/patches/libseccomp-pick-up-CC.patch: Added.
3572 2014-11-28 Bartlomiej Gajda <b.gajda@samsung.com>
3574 [EFL] Add warning if CMake version is too old for building with ninja.
3575 https://bugs.webkit.org/show_bug.cgi?id=139055
3577 Reviewed by Gyuyoung Kim.
3579 CMake need to be >= 2.8.10 to build WebKit using ninja, some repos don't have
3580 that version in their repositories.
3582 * efl/install-dependencies:
3584 2014-11-28 Andrzej Badowski <a.badowski@samsung.com>
3586 [ATK] Allowing the use of AccessibilityUIElement::columnHeaders method for table.
3587 https://bugs.webkit.org/show_bug.cgi?id=139044
3589 Reviewed by Chris Fleizach.
3591 ATK method AccessibilityUIElement::columnHeaders currently focused only on the object table cell.
3592 The proposed solution will enable the use of this method for the object table.
3593 Existing test shows the result.
3595 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3596 (WTR::AccessibilityUIElement::columnHeaders):
3598 2014-11-27 Ryuan Choi <ryuan.choi@navercorp.com>
3600 [EFL] Remove E_Dbus dependency
3601 https://bugs.webkit.org/show_bug.cgi?id=136355
3603 Reviewed by Gyuyoung Kim.
3605 * MiniBrowser/efl/CMakeLists.txt: Removed E_DBUS includes.
3607 2014-11-26 Akos Kiss <akiss@inf.u-szeged.hu>
3609 [EFL][GTK] Bump up FDE relocation fixing patch to version accepted to LLVM trunk.
3610 https://bugs.webkit.org/show_bug.cgi?id=139047
3612 Reviewed by Carlos Garcia Campos.
3614 * efl/jhbuild.modules:
3615 * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added.
3616 * efl/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed.
3617 * gtk/jhbuild-optional.modules:
3618 * gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added.
3619 * gtk/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed.
3621 2014-11-25 Tanay C <tanay.c@samsung.com>
3623 [GTK] Minibrowser: Add support for zoom using Control Key + Mouse scroll
3624 https://bugs.webkit.org/show_bug.cgi?id=138090