Tools/ChangeLog

   1 2013-05-21  Jessie Berlin  <jberlin@apple.com>
   2
   3         Revert r149635, it was too optimistic.
   4
   5         Rubber-stamped by Andreas Kling.
   6
   7         We are not at the point where we can always use more descriptive macros instead of PLATFORM()
   8         #ifdefs in WebCore code outside of WebCore/platform.
   9
  10         * Scripts/webkitpy/style/checkers/cpp.py:
  11         (check_invalid_increment):
  12         (process_line):
  13         (CppChecker):
  14         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
  15         (CppStyleTest.test_plain_integral_bitfields):
  16
  17 2013-05-21  Jer Noble  <jer.noble@apple.com>
  18
  19         Unreviewed; fix lldb synthetic representation of WTF::Vector after r148891.
  20
  21         * lldb/lldb_webkit.py:
  22         (WTFVectorProvider.num_children):
  23         (WTFVectorProvider.get_child_index):
  24         (WTFVectorProvider.get_child_at_index):
  25         (WTFVectorProvider.update):
  26
  27 2013-05-21  Jessie Berlin  <jberlin@apple.com>
  28
  29         Expose a way to know when forms are added to a page or when form controls are added to a form
  30         in the injected bundle
  31         https://bugs.webkit.org/show_bug.cgi?id=116334
  32
  33         Reviewed by Alexey Proskuryakov.
  34
  35         Add tests for the new callbacks.
  36
  37         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  38         Add DidAssociateFormControls/_Bundle.cpp and associate-form-controls.html
  39
  40         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Added.
  41         (TestWebKitAPI::nullJavaScriptCallback):
  42         A "null" callback to handle the fact that WKPageRunJavaScriptInMainFrame cannot handle null
  43         being passed in for the callback.
  44         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
  45         After receiving the message that didAssociateFormControls callback was invoked from adding
  46         the form in the onload handler, tell the page to add a password field to the form, which
  47         should also invoke didAssociateFormControls callback.
  48         (TestWebKitAPI::setInjectedBundleClient):
  49         Register to receive messages.
  50         (TestWebKitAPI::TEST):
  51         Load associate-form-controls.html and wait until the didAssociateFormControls callback has
  52         been invoked for both adding the form and for adding a password field to the form.
  53
  54         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Added.
  55         (TestWebKitAPI::shouldNotifyOnFormChanges):
  56         Return true so the didAssociateFormControls callback is invoked.
  57         (TestWebKitAPI::didAssociateFormControls):
  58         Tell the UI process.
  59         (TestWebKitAPI::DidAssociateFormControlsTest::DidAssociateFormControlsTest):
  60         (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
  61         Register for the shouldNotifyOnFormChanges and didAssociateFormControls callbacks.
  62
  63         * TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Added.
  64         Add a form in response to the onload event. Add a button that will add the password field
  65         for manual testing.
  66
  67 2013-05-21  Krzysztof Czech  <k.czech@samsung.com>
  68
  69         [GTK][WK2] accessibility/label-for-control-hittest.html is failing
  70         https://bugs.webkit.org/show_bug.cgi?id=106341
  71
  72         Reviewed by Martin Robinson.
  73
  74         Adds support for retrieving accessibility element at exact point.
  75
  76         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
  77         (WTR::AccessibilityUIElement::elementAtPoint):
  78
  79 2013-05-21  Krzysztof Czech  <k.czech@samsung.com>
  80
  81         [ATK] [WebKit2] AccessibilityUIElement often leaks its AtkObject
  82         https://bugs.webkit.org/show_bug.cgi?id=112913
  83
  84         Reviewed by Martin Robinson.
  85
  86         AccessibilityUIElement is often created by passing new reference to AtkObject (transfer full).
  87         AccessibilityUIElement::~AccessibilityUIElement does not decrement the reference of the element,
  88         so the leak appears.
  89
  90         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
  91         (WTR):
  92         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
  93         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
  94         (WTR::AccessibilityController::rootElement):
  95         (WTR):
  96         (WTR::AccessibilityController::focusedElement):
  97         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
  98         (WTR::checkElementState):
  99         (WTR::indexRangeInTable):
 100         (WTR::alterCurrentValue):
 101         (WTR::AccessibilityUIElement::getChildren):
 102         (WTR::AccessibilityUIElement::getChildrenWithRange):
 103         (WTR::AccessibilityUIElement::childrenCount):
 104         (WTR::AccessibilityUIElement::indexOfChild):
 105         (WTR::AccessibilityUIElement::titleUIElement):
 106         (WTR::AccessibilityUIElement::parentElement):
 107         (WTR::AccessibilityUIElement::allAttributes):
 108         (WTR::AccessibilityUIElement::role):
 109         (WTR::AccessibilityUIElement::title):
 110         (WTR::AccessibilityUIElement::description):
 111         (WTR::AccessibilityUIElement::orientation):
 112         (WTR::AccessibilityUIElement::stringValue):
 113         (WTR::AccessibilityUIElement::language):
 114         (WTR::AccessibilityUIElement::x):
 115         (WTR::AccessibilityUIElement::y):
 116         (WTR::AccessibilityUIElement::width):
 117         (WTR::AccessibilityUIElement::height):
 118         (WTR::AccessibilityUIElement::intValue):
 119         (WTR::AccessibilityUIElement::minValue):
 120         (WTR::AccessibilityUIElement::maxValue):
 121         (WTR::AccessibilityUIElement::isEnabled):
 122         (WTR::AccessibilityUIElement::isFocused):
 123         (WTR::AccessibilityUIElement::isSelected):
 124         (WTR::AccessibilityUIElement::isExpanded):
 125         (WTR::AccessibilityUIElement::isChecked):
 126         (WTR::AccessibilityUIElement::rowCount):
 127         (WTR::AccessibilityUIElement::columnCount):
 128         (WTR::AccessibilityUIElement::rowIndexRange):
 129         (WTR::AccessibilityUIElement::columnIndexRange):
 130         (WTR::AccessibilityUIElement::cellForColumnAndRow):
 131         (WTR::AccessibilityUIElement::increment):
 132         (WTR::AccessibilityUIElement::decrement):
 133         (WTR::AccessibilityUIElement::press):
 134         (WTR::AccessibilityUIElement::documentEncoding):
 135         (WTR::AccessibilityUIElement::documentURI):
 136         (WTR::AccessibilityUIElement::isFocusable):
 137         (WTR::AccessibilityUIElement::isSelectable):
 138         (WTR::AccessibilityUIElement::isMultiSelectable):
 139         (WTR::AccessibilityUIElement::isVisible):
 140
 141 2013-05-20  Lucas Forschler  <lforschler@apple.com>
 142
 143     Rollout 150398.
 144
 145 2013-05-20  Zan Dobersek  <zdobersek@igalia.com>
 146
 147         [GTK] Fix concatenations of string literals that are not C++11-compliant
 148         https://bugs.webkit.org/show_bug.cgi?id=116449
 149
 150         Reviewed by Martin Robinson.
 151
 152         Fix the problematic concatenations of string literals so they are compilable under the C++11 standard. This
 153         is simply a matter of separating the string and the string literal that are being concatenated with a space.
 154
 155         * ImageDiff/gtk/ImageDiff.cpp:
 156         (printImage):
 157
 158 2013-05-20  Zan Dobersek  <zdobersek@igalia.com>
 159
 160         [GTK] Pass GTEST_HAS_RTTI=0 cppflag to TestWebKitAPI programs at compilation-time
 161         https://bugs.webkit.org/show_bug.cgi?id=116450
 162
 163         Reviewed by Martin Robinson.
 164
 165         The -fno-rtti flag is used when compiling C++ source code throughout the project. The TestWebKitAPI
 166         programs fail to compile because of this when using the C++11 standard as the GTest headers assume by
 167         default that the RTTI support is available. This can be turned off by passing GTEST_HAS_RTTI=0 to the
 168         TestWebKitAPI programs when compiling them.
 169
 170         * TestWebKitAPI/GNUmakefile.am:
 171
 172 2013-05-20  Ryosuke Niwa  <rniwa@webkit.org>
 173
 174         Remove DriverProxy._running_drivers from webkitpy.layout_tests.port
 175         https://bugs.webkit.org/show_bug.cgi?id=116492
 176
 177         Reviewed by Dirk Pranke.
 178
 179         Merge https://chromium.googlesource.com/chromium/blink/+/1af2f0be5a1746784ff114952f29f7b8fa9895f3.
 180
 181         The DriverProxy class had the concept of keeping a pool of started DRTs around (indexed by command line)
 182         so that we didn't necessarily need to restart DRT when the command line for a test changed (e.g., when
 183         starting to run tests in a virtual suite). However, the pool was per-worker (so not shared across the machine)
 184         and we didn't cap the number of processes started, so we would end up with a whole bunch of DRTs (3x-4x
 185         the number of workers started). If anything, this seemed to make the tests slightly slower and probably added
 186         to memory pressure on the machine.
 187
 188         This change removes the pool code; now we'll simply restart DRT when the command line changes. With this change,
 189         we can actually fold the restarting code into Driver itself (and get rid of DriverProxy), but I'll leave that
 190         for a subsequent patch just to make things easier to follow.
 191
 192         * Scripts/webkitpy/port/driver.py:
 193         (DriverProxy.__init__):
 194         (DriverProxy.run_test):
 195         (DriverProxy.has_crashed):
 196         (DriverProxy.stop):
 197
 198 2013-05-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 199
 200         Change EFL Linux 64-bit Release with EFL Linux 64-bit Release WK1
 201         https://bugs.webkit.org/show_bug.cgi?id=116423
 202
 203         Reviewed by Ryosuke Niwa.
 204
 205         EFL Linux 64-bit Release starts to support WK1's build and layout test from now on.
 206
 207         * BuildSlaveSupport/build.webkit.org-config/config.json:
 208
 209 2013-05-20  Seokju Kwon  <seokju.kwon@gmail.com>
 210
 211         Remove remaining link-prerender code
 212         https://bugs.webkit.org/show_bug.cgi?id=116429
 213
 214         Reviewed by Darin Adler.
 215
 216         Link prerendering code was removed in r150356.
 217
 218         * Scripts/webkitperl/FeatureList.pm:
 219         * qmake/mkspecs/features/features.pri:
 220
 221 2013-05-20  Ryosuke Niwa  <rniwa@webkit.org>
 222
 223         commit-queue should check for oops in changelog entries
 224         https://bugs.webkit.org/show_bug.cgi?id=116395
 225
 226         Reviewed by Martin Robinson.
 227
 228         Make changelog validation fail when it contains oops!.
 229
 230         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
 231         (CommitQueueTask._validate_changelog):
 232         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
 233         (CommitQueueTaskTest._run_through_task):
 234         * Scripts/webkitpy/tool/commands/queues_unittest.py:
 235         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
 236         (ValidateChangeLogs.options):
 237         (ValidateChangeLogs._check_changelog_diff):
 238         (ValidateChangeLogs._changelog_contains_oops):
 239         (ValidateChangeLogs.run):
 240         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
 241         (ValidateChangeLogsTest._assert_start_line_produces_output):
 242         (ValidateChangeLogsTest.test_check_changelog_diff):
 243         (ValidateChangeLogsTest):
 244         (ValidateChangeLogsTest.test_changelog_contains_oops):
 245
 246 2013-05-20  Jessie Berlin  <jberlin@apple.com>
 247
 248         Expose a way to know when forms are added to a page or when form controls are added to a form
 249         in the injected bundle
 250         https://bugs.webkit.org/show_bug.cgi?id=116334
 251
 252         Reviewed by Alexey Proskuryakov.
 253
 254         Add tests for the new callbacks.
 255
 256         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 257         Add DidAssociateFormControls/_Bundle.cpp and associate-form-controls.html
 258
 259         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Added.
 260         (TestWebKitAPI::nullJavaScriptCallback):
 261         A "null" callback to handle the fact that WKPageRunJavaScriptInMainFrame cannot handle null
 262         being passed in for the callback.
 263         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
 264         After receiving the message that didAssociateFormControls callback was invoked from adding
 265         the form in the onload handler, tell the page to add a password field to the form, which
 266         should also invoke didAssociateFormControls callback.
 267         (TestWebKitAPI::setInjectedBundleClient):
 268         Register to receive messages.
 269         (TestWebKitAPI::TEST):
 270         Load associate-form-controls.html and wait until the didAssociateFormControls callback has
 271         been invoked for both adding the form and for adding a password field to the form.
 272
 273         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Added.
 274         (TestWebKitAPI::shouldNotifyOnFormChanges):
 275         Return true so the didAssociateFormControls callback is invoked.
 276         (TestWebKitAPI::didAssociateFormControls):
 277         Tell the UI process.
 278         (TestWebKitAPI::DidAssociateFormControlsTest::DidAssociateFormControlsTest):
 279         (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
 280         Register for the shouldNotifyOnFormChanges and didAssociateFormControls callbacks.
 281
 282         * TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Added.
 283         Add a form in response to the onload event. Add a button that will add the password field
 284         for manual testing.
 285
 286 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
 287
 288         [EFL][JHBUILD] Make sure eet is built before evas
 289         https://bugs.webkit.org/show_bug.cgi?id=116440
 290
 291         Reviewed by Gyuyoung Kim.
 292
 293         Mark eet as a dependency of evas since evas requires eet to enable some of its
 294         functionality.
 295
 296         * efl/jhbuild.modules:
 297
 298 2013-05-20  Alex Christensen  <achristensen@apple.com>
 299
 300         WTR::pathSuitableForTestResult should behave the same as _drt_descriptionSuitableForTestResult so we can unskip tests.
 301         https://bugs.webkit.org/show_bug.cgi?id=116125
 302
 303         Reviewed by Tim Horton.
 304
 305         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 306         (WTR::pathSuitableForTestResult):
 307         Changed string operations to match _drt_descriptionSuitableForTestResult.
 308         (WTR::dumpRequestDescriptionSuitableForTestResult):
 309         (WTR::dumpResponseDescriptionSuitableForTestResult):
 310         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
 311         (WTR::InjectedBundlePage::didInitiateLoadForResource):
 312         (WTR::InjectedBundlePage::willSendRequestForFrame):
 313         (WTR::InjectedBundlePage::didReceiveResponseForResource):
 314         Pass the main frame's URL to pathSuitableForTestResult.
 315         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
 316         Added WKBundlePageRef to willPerformClientRedirectForFrame.
 317
 318 2013-05-20  Dirk Pranke  <dpranke@chromium.org>
 319
 320         fix w3c test importer unit tests after r150324
 321         https://bugs.webkit.org/show_bug.cgi?id=116459
 322
 323         Reviewed by Ryosuke Niwa.
 324
 325         This patch fixes the unit tests to not actually call out to
 326         'hg' (by using a mock executive) and also changes the real
 327         directory we crawl from Source/WebCore/css to
 328         Tools/Scripts/webkitpy/w3c to run much more quickly. We should
 329         still change this to a mock filesystem, but that's a separate change.
 330
 331         * Scripts/webkitpy/w3c/test_importer.py:
 332         (main):
 333         (TestImporter.__init__):
 334         (TestImporter.load_changeset):
 335         * Scripts/webkitpy/w3c/test_importer_unittest.py:
 336         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
 337         (TestImporterTest.test_import_dir_with_no_tests):
 338
 339 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
 340
 341         Unreviewed EFL build fix.
 342
 343         Fix linking errors due to undefined symbols on Ubuntu 13.04.
 344
 345         * DumpRenderTree/efl/CMakeLists.txt:
 346         * EWebLauncher/CMakeLists.txt:
 347         * MiniBrowser/efl/CMakeLists.txt:
 348
 349 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
 350
 351         [EFL] Reenabled INDEXED_DATABASE after r150344
 352         https://bugs.webkit.org/show_bug.cgi?id=116430
 353
 354         Reviewed by Gyuyoung Kim.
 355
 356         Reenable INDEXED_DATABASE flag for EFL port now that WebKit2
 357         build was fixed in r150344.
 358
 359         * Scripts/webkitperl/FeatureList.pm:
 360
 361 2013-05-19  Ryuan Choi  <ryuan.choi@samsung.com>
 362
 363         [EFL] init/shutdown should be paired in EWebLauncher
 364         https://bugs.webkit.org/show_bug.cgi?id=116427
 365
 366         Reviewed by Christophe Dumez.
 367
 368         Added ecore_file_shutdown() for cleanup of ecore_file.
 369         Removed edje_init and ecore_evas_init because it was in ewk_init().
 370
 371         * EWebLauncher/main.c:
 372         (main):
 373
 374 2013-05-19  Jinwoo Song  <jinwoo7.song@samsung.com>
 375
 376         [EFL] Add command line option to MiniBrowser to set user agent
 377         https://bugs.webkit.org/show_bug.cgi?id=116387
 378
 379         Reviewed by Christophe Dumez.
 380
 381         We need this option to compare the rendering differences according to different user agents.
 382
 383         * MiniBrowser/efl/main.c:
 384         (window_create):
 385         (elm_main):
 386
 387 2013-05-19  Zan Dobersek  <zdobersek@igalia.com>
 388
 389         Unreviewed, addressing test-webkitpy failures after r150317.
 390
 391         * Scripts/webkitpy/w3c/test_converter.py:
 392         (W3CTestConverter.read_webkit_prefixed_css_property_list): CssPropertyNames.in doesn't exist, but CSSPropertyNames.in does.
 393
 394 2013-05-18  Patrick Gansterer  <paroga@webkit.org>
 395
 396         [CMake] Replace *_LIBRARY_NAME with *_OUTPUT_NAME
 397         https://bugs.webkit.org/show_bug.cgi?id=114554
 398
 399         Reviewed by Gyuyoung Kim.
 400
 401         Using variables as target names is very uncommon in CMake.
 402         The usual way to specify the name of the resulting binary
 403         is to set the OUTPUT_NAME target property.
 404
 405         * DumpRenderTree/efl/CMakeLists.txt:
 406         * EWebLauncher/CMakeLists.txt:
 407         * ImageDiff/CMakeLists.txt:
 408         * MiniBrowser/efl/CMakeLists.txt:
 409         * TestWebKitAPI/CMakeLists.txt:
 410         * WebKitTestRunner/CMakeLists.txt:
 411         * WebKitTestRunner/PlatformEfl.cmake:
 412         * WinCELauncher/CMakeLists.txt:
 413
 414 2013-05-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
 415
 416         Unreviewed EFL build fix.
 417
 418         Temporarily disabled INDEXED_DATABASE at compile-time as it breaks
 419         WK2 build after r150305.
 420
 421         * Scripts/webkitperl/FeatureList.pm:
 422
 423 2013-05-18  Alberto Garcia  <agarcia@igalia.com>
 424
 425         [GTK] Parallel build fails if gtk-doc is enabled
 426         https://bugs.webkit.org/show_bug.cgi?id=116227
 427
 428         Reviewed by Martin Robinson.
 429
 430         * GNUmakefile.am:
 431         Don't use the 'all' target to generate the documentation.
 432         The prerequisites of this target must be files that need to be
 433         built _before_ the actual compilation of WebKit starts. Since the
 434         documentation depends on WebKit being built first, this means in
 435         practice that the code will be built in parallel with the
 436         generation of its dependencies, potentially making the build fail.
 437
 438 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
 439
 440         Don't run hg.
 441
 442         * Scripts/webkitpy/w3c/test_importer_unittest.py:
 443         (TestImporterTest):
 444
 445 2013-05-17  Dirk Pranke  <dpranke@chromium.org>
 446
 447         Create a script to import W3C tests
 448         https://bugs.webkit.org/show_bug.cgi?id=111513
 449
 450         Reviewed by Ryosuke Niwa.
 451
 452         This patch attempts to re-land the 'import-w3c-tests'
 453         script and accompanying modules.  The tests and code have
 454         been cleaned up so that we do not log anything to stdout/stderr
 455         while running the tests (thanks to outputcapture) and do not
 456         write into the source tree while running the tests, and much
 457         but not all of the code has been converted over to using the webkitpy
 458
 459         * Scripts/import-w3c-tests: Added.
 460         * Scripts/webkitpy/w3c/__init__.py: Added.
 461         * Scripts/webkitpy/w3c/test_converter.py: Added.
 462         (W3CTestConverter):
 463         (W3CTestConverter.__init__):
 464         (W3CTestConverter.path_from_webkit_root):
 465         (W3CTestConverter.read_webkit_prefixed_css_property_list):
 466         (W3CTestConverter.convert_for_webkit):
 467         (W3CTestConverter.convert_css):
 468         (W3CTestConverter.convert_html):
 469         (W3CTestConverter.convert_testharness_paths):
 470         (W3CTestConverter.convert_prefixed_properties):
 471         (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
 472         (W3CTestConverter.replace_tag):
 473         * Scripts/webkitpy/w3c/test_converter_unittest.py: Added.
 474         (W3CTestConverterTest):
 475         (W3CTestConverterTest.fake_dir_path):
 476         (W3CTestConverterTest.test_read_prefixed_property_list):
 477         (W3CTestConverterTest.test_convert_for_webkit_nothing_to_convert):
 478         (test_convert_for_webkit_harness_only):
 479         (test_convert_for_webkit_properties_only):
 480         (test_convert_for_webkit_harness_and_properties):
 481         (test_convert_test_harness_paths):
 482         (test_convert_prefixed_properties):
 483         (verify_conversion_happened):
 484         (verify_no_conversion_happened):
 485         (verify_test_harness_paths):
 486         (verify_prefixed_properties):
 487         (generate_test_content):
 488         * Scripts/webkitpy/w3c/test_importer.py: Added.
 489         (main):
 490         (parse_args):
 491         (validate_import_directory):
 492         (TestImporter):
 493         (TestImporter.__init__):
 494         (TestImporter.path_from_webkit_root):
 495         (TestImporter.do_import):
 496         (TestImporter.load_changeset):
 497         (TestImporter.find_importable_tests):
 498         (TestImporter.import_tests):
 499         (TestImporter.setup_destination_directory):
 500         (TestImporter.update_test_status):
 501         (TestImporter.remove_deleted_files):
 502         (TestImporter.write_import_log):
 503         * Scripts/webkitpy/w3c/test_importer_unittest.py: Added.
 504         (TestImporterTest):
 505         (TestImporterTest.test_import_dir_with_no_tests):
 506         * Scripts/webkitpy/w3c/test_parser.py: Added.
 507         (TestParser):
 508         (TestParser.__init__):
 509         (TestParser.load_file):
 510         (TestParser.analyze_test):
 511         (TestParser.reference_links_of_type):
 512         (TestParser.is_jstest):
 513         (TestParser.support_files):
 514         * Scripts/webkitpy/w3c/test_parser_unittest.py: Added.
 515         (TestParserTest):
 516         (TestParserTest.test_analyze_test_reftest_one_match):
 517         (test_analyze_test_reftest_multiple_matches):
 518         (test_analyze_test_reftest_match_and_mismatch):
 519         (test_analyze_test_reftest_with_ref_support_Files):
 520         (test_analyze_jstest):
 521         (test_analyze_pixel_test_all_true):
 522         (test_analyze_pixel_test_all_false):
 523         (test_analyze_non_html_file):
 524
 525 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
 526
 527         Leaks builders exit early frequently
 528         https://bugs.webkit.org/show_bug.cgi?id=116355
 529
 530         Reviewed by Stephanie Lewis.
 531
 532         Throttle the number of processes to use, and also bump up the number of crashes/timeouts
 533         we tolerate from 20 to 50.
 534
 535         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 536         (RunWebKitTests.start):
 537         * Scripts/webkitpy/port/mac.py:
 538         (MacPort.default_child_processes):
 539
 540 2013-05-17  Peter Gal  <galpeter@inf.u-szeged.hu>
 541
 542         Remove chrome-channels command from the webkit-patch
 543         https://bugs.webkit.org/show_bug.cgi?id=116303
 544
 545         Reviewed by Ryosuke Niwa.
 546
 547         * Scripts/webkitpy/common/config/urls.py: Removed omahaproxy url.
 548         * Scripts/webkitpy/common/net/omahaproxy.py: Removed.
 549         * Scripts/webkitpy/common/net/omahaproxy_unittest.py: Removed.
 550         * Scripts/webkitpy/tool/commands/__init__.py: Removed chromechannels import.
 551         * Scripts/webkitpy/tool/commands/chromechannels.py: Removed.
 552         * Scripts/webkitpy/tool/commands/chromechannels_unittest.py: Removed.
 553
 554 2013-05-17  David Kilzer  <ddkilzer@apple.com>
 555
 556         filter-build-webkit: Don't filter out the location of the missing symbol when linking fails
 557         Part 3 of 3: <http://webkit.org/b/116247>
 558
 559         Reviewed by Benjamin Poulain.
 560
 561         * Scripts/filter-build-webkit: Change while() loop to for() loop
 562         to track $previousLine, then pass $previousLine into
 563         shouldIgnoreLine().
 564         (shouldIgnoreLine): Add $previousLine argument. Do not skip a
 565         line that begins with four spaces if the previous line is a
 566         linker error message.
 567         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
 568         - Add "Ignored: " to test descriptions to document expected
 569           behavior.
 570         - Add comment blocks for various groups of tests.
 571         - Expand "Build settings" tests since we're changing the code in
 572           shouldIgnoreLine() that ignores those lines.
 573         - Add tests for undefined symbols error message.
 574         (description): Add.  Extract from global code.
 575
 576 2013-05-17  David Kilzer  <ddkilzer@apple.com>
 577
 578         Add tests for shouldIgnoreLine() in filter-build-webkit
 579         Part 2 of 3: <http://webkit.org/b/116247>
 580
 581         Reviewed by Benjamin Poulain.
 582
 583         * Scripts/filter-build-webkit:
 584         (shouldIgnoreLine): Add.  Extract code from global scope into
 585         subroutine to make it testable.
 586         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl: Add.
 587         Tests shouldIgnoreLine() using output from a real build
 588         transcript.
 589
 590 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
 591
 592         Rename "WebKit Queues" to explicitly call out for EWS and CQ on build.webkit.org
 593         https://bugs.webkit.org/show_bug.cgi?id=116341
 594
 595         Reviewed by Brady Eidson.
 596
 597         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
 598
 599 2013-05-17  Brent Fulgham  <bfulgham@apple.com>
 600
 601         [Windows] Don't use pdevenv when building with VS2010.
 602         https://bugs.webkit.org/show_bug.cgi?id=116338.
 603
 604         Reviewed by Adam Roben.
 605
 606         * Scripts/webkitdirs.pm:
 607         (setupCygwinEnv): Check if we are using VS2005, and only use
 608         the 'pdevenv' hack if we are. Otherwise, just build with
 609         our standard project since it uses VS2010+'s native
 610         parallel building features.
 611
 612 2013-05-17  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
 613
 614         Unreviewed. Disable accelerated compositing until we figure out why it does not work
 615         properly in the 64 bits release bot.
 616
 617         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 618         (resetDefaultsToConsistentValues):
 619
 620 2013-05-17  David Kilzer  <ddkilzer@apple.com>
 621
 622         Make filter-build-webkit testable using LoadAsModule
 623         Part 1 of 3: <http://webkit.org/b/116247>
 624
 625         Reviewed by Benjamin Poulain.
 626
 627         * Scripts/filter-build-webkit: Change global variables that are
 628         used in subroutines from 'my' to 'our' to make it possible to
 629         evaluate the script in a package context in LoadAsModule.pm.
 630
 631 2013-05-14  Sam Weinig  <sam@webkit.org>
 632
 633         Add variants of the loading APIs that take user data and a way for the injected bundle to find out about them
 634         https://bugs.webkit.org/show_bug.cgi?id=116132
 635
 636         Reviewed by Anders Carlsson.
 637
 638         Adds "WithUserData" versions of all the load APIs and two new WKBundlePageLoaderClient functions,
 639         willLoadURLRequest and willLoadDataRequest to let the bundle access them.
 640
 641         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 642         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Added.
 643         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp: Added.
 644         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 645
 646 2013-05-16  Seokju Kwon  <seokju.kwon@gmail.com>
 647
 648         [EFL] inspector-protocol/page/javascriptDialogEvents.html is failing
 649         https://bugs.webkit.org/show_bug.cgi?id=114781
 650
 651         Reviewed by Christophe Dumez.
 652
 653         Add run_before_unload_confirm and
 654         Print the log message with "CONFIRM NAVIGATION: " in console.
 655
 656         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
 657         (onBeforeUnloadConfirm):
 658         (drtViewAdd):
 659
 660 2013-05-16  Peter Gal  <galpeter@inf.u-szeged.hu>
 661
 662         Fix Analyze ChangeLog's entry processing
 663         https://bugs.webkit.org/show_bug.cgi?id=116219
 664
 665         Reviewed by Ryosuke Niwa.
 666
 667         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
 668         (ChangeLogAnalyzer._analyze_entries): Fix the counter initialization.
 669
 670 2013-05-16  Hyungchan Kim  <hyungchan2.kim@lge.com>
 671
 672         [Qt] UrlLoader::loadNext is broken in MiniBrowser
 673         https://bugs.webkit.org/show_bug.cgi?id=116099
 674
 675         Reviewed by Jocelyn Turcotte.
 676
 677         QQuickWebView's 3 signals(loadStarted, loadSucceeded, loadFailed)
 678         are not available any more. So, UrlLoader::loadNext was broken
 679         because it failed to connect to those signals.
 680
 681         * MiniBrowser/qt/UrlLoader.cpp:
 682         (UrlLoader::UrlLoader):
 683         (UrlLoader::loadingChanged):
 684         * MiniBrowser/qt/UrlLoader.h:
 685         (UrlLoader):
 686
 687 2013-05-16  Lamarque V. Souza  <Lamarque.Souza@basyskom.com>
 688
 689         [WebSocket] Update pywebsocket to r760
 690         https://bugs.webkit.org/show_bug.cgi?id=115863
 691
 692         Reviewed by Alexey Proskuryakov.
 693
 694         Version r760 supports a newer draft of message compression.
 695         We need this update to finish the permessage compression patch in
 696         bug 98840. This patch also fixes failing unit tests after the update.
 697
 698         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_base.py:
 699         (StreamBase._read):
 700         (StreamBase._read.of):
 701         (StreamBase._write):
 702         (StreamBase.receive_bytes):
 703         (StreamBase._read_until):
 704         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py:
 705         (parse_frame):
 706         (StreamOptions.__init__):
 707         (Stream.__init__):
 708         (Stream._receive_frame_as_frame_object):
 709         (Stream._get_message_from_frame):
 710         (Stream._process_close_message):
 711         (Stream.close_connection):
 712         (Stream.get_last_received_opcode):
 713         * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py:
 714         * Scripts/webkitpy/thirdparty/mod_pywebsocket/dispatch.py:
 715         (Dispatcher.do_extra_handshake):
 716         (Dispatcher.transfer_data):
 717         * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py:
 718         (ExtensionProcessorInterface.__init__):
 719         (ExtensionProcessorInterface.request):
 720         (ExtensionProcessorInterface):
 721         (ExtensionProcessorInterface.name):
 722         (ExtensionProcessorInterface.check_consistency_with_other_processors):
 723         (ExtensionProcessorInterface.set_active):
 724         (ExtensionProcessorInterface.is_active):
 725         (ExtensionProcessorInterface._get_extension_response_internal):
 726         (ExtensionProcessorInterface.get_extension_response):
 727         (ExtensionProcessorInterface._setup_stream_options_internal):
 728         (ExtensionProcessorInterface.setup_stream_options):
 729         (_log_outgoing_compression_ratio):
 730         (_log_incoming_compression_ratio):
 731         (_parse_window_bits):
 732         (_AverageRatioCalculator):
 733         (_AverageRatioCalculator.__init__):
 734         (_AverageRatioCalculator.add_original_bytes):
 735         (_AverageRatioCalculator.add_result_bytes):
 736         (_AverageRatioCalculator.get_average_ratio):
 737         (DeflateFrameExtensionProcessor):
 738         (DeflateFrameExtensionProcessor.__init__):
 739         (DeflateFrameExtensionProcessor._get_extension_response_internal):
 740         (DeflateFrameExtensionProcessor._setup_stream_options_internal):
 741         (DeflateFrameExtensionProcessor._outgoing_filter):
 742         (DeflateFrameExtensionProcessor._incoming_filter):
 743         (CompressionExtensionProcessorBase.for):
 744         (CompressionExtensionProcessorBase.__init__):
 745         (CompressionExtensionProcessorBase._get_extension_response_internal):
 746         (CompressionExtensionProcessorBase._setup_stream_options_internal):
 747         (PerFrameCompressExtensionProcessor):
 748         (PerMessageDeflateExtensionProcessor):
 749         (PerMessageDeflateExtensionProcessor.__init__):
 750         (PerMessageDeflateExtensionProcessor._get_extension_response_internal):
 751         (PerMessageDeflateExtensionProcessor._setup_stream_options_internal):
 752         (PerMessageDeflateExtensionProcessor.set_c2s_max_window_bits):
 753         (PerMessageDeflateExtensionProcessor.set_c2s_max_window_bits.adds):
 754         (PerMessageDeflateExtensionProcessor.set_c2s_no_context_takeover):
 755         (PerMessageDeflateExtensionProcessor.set_c2s_no_context_takeover.adds):
 756         (PerMessageDeflateExtensionProcessor.set_bfinal):
 757         (PerMessageDeflateExtensionProcessor.enable_outgoing_compression):
 758         (PerMessageDeflateExtensionProcessor.disable_outgoing_compression):
 759         (_PerMessageDeflateFramer):
 760         (_PerMessageDeflateFramer.__init__):
 761         (_PerMessageDeflateFramer.set_compress_outgoing_enabled):
 762         (_PerMessageDeflateFramer._process_incoming_message):
 763         (_PerMessageDeflateFramer._process_outgoing_message):
 764         (_PerMessageDeflateFramer.setup_stream_options):
 765         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter):
 766         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter.__init__):
 767         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter.filter):
 768         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter):
 769         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.__init__):
 770         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.decompress_next_message):
 771         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.filter):
 772         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter):
 773         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.__init__):
 774         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.set_compression_bit):
 775         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.filter):
 776         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter):
 777         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter.__init__):
 778         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter.filter):
 779         (PerMessageCompressExtensionProcessor):
 780         (PerMessageCompressExtensionProcessor._lookup_compression_processor):
 781         (MuxExtensionProcessor.__init__):
 782         (MuxExtensionProcessor.check_consistency_with_other_processors):
 783         (MuxExtensionProcessor):
 784         (MuxExtensionProcessor._get_extension_response_internal):
 785         (MuxExtensionProcessor._setup_stream_options_internal):
 786         (MuxExtensionProcessor.set_quota):
 787         (MuxExtensionProcessor.quota):
 788         (MuxExtensionProcessor.set_extensions):
 789         (MuxExtensionProcessor.extensions):
 790         (is_compression_extension):
 791         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py:
 792         (validate_subprotocol):
 793         (parse_host_header):
 794         (format_header):
 795         (check_request_line):
 796         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py:
 797         (Handshaker.do_handshake):
 798         (Handshaker._create_handshake_response):
 799         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi00.py:
 800         (_validate_subprotocol):
 801         (_check_header_lines):
 802         (_build_location):
 803         (Handshaker.do_handshake):
 804         (Handshaker._set_subprotocol):
 805         (Handshaker._set_location):
 806         * Scripts/webkitpy/thirdparty/mod_pywebsocket/headerparserhandler.py:
 807         (_create_dispatcher):
 808         (headerparserhandler):
 809         * Scripts/webkitpy/thirdparty/mod_pywebsocket/mux.py:
 810         (_create_add_channel_response):
 811         (_create_drop_channel):
 812         (_create_flow_control):
 813         (_create_new_channel_slot):
 814         (_create_fallback_new_channel_slot):
 815         (_MuxFramePayloadParser._read_number):
 816         (_MuxFramePayloadParser._read_size_and_contents):
 817         (_MuxFramePayloadParser._read_flow_control):
 818         (_MuxFramePayloadParser._read_new_channel_slot):
 819         (_LogicalConnection.__init__):
 820         (_LogicalConnection.write):
 821         (_LogicalConnection.on_write_data_done):
 822         (_LogicalConnection):
 823         (_LogicalConnection.on_writer_done):
 824         (_InnerMessage):
 825         (_InnerMessage.__init__):
 826         (_InnerMessageBuilder):
 827         (_InnerMessageBuilder.that):
 828         (_InnerMessageBuilder.__init__):
 829         (_InnerMessageBuilder._handle_first):
 830         (_InnerMessageBuilder._process_first_fragmented_control):
 831         (_InnerMessageBuilder._process_first_fragmented_message):
 832         (_InnerMessageBuilder._handle_fragmented_control):
 833         (_InnerMessageBuilder._reassemble_fragmented_control):
 834         (_InnerMessageBuilder._handle_fragmented_message):
 835         (_InnerMessageBuilder._reassemble_fragmented_message):
 836         (_InnerMessageBuilder.build):
 837         (_LogicalStream.__init__):
 838         (_LogicalStream._create_inner_frame):
 839         (_LogicalStream._write_inner_frame):
 840         (_LogicalStream.replenish_send_quota):
 841         (_LogicalStream.send_message):
 842         (_LogicalStream._receive_frame):
 843         (_LogicalStream._get_message_from_frame):
 844         (_LogicalStream.stop_sending):
 845         (_PhysicalConnectionWriter.__init__):
 846         (_PhysicalConnectionWriter._write_data):
 847         (_PhysicalConnectionWriter.run):
 848         (_PhysicalConnectionWriter.stop):
 849         (_Worker.run):
 850         (_MuxHandshaker.__init__):
 851         (_MuxHandshaker._create_stream):
 852         (_MuxHandshaker._create_handshake_response):
 853         (_HandshakeDeltaBase.create_headers):
 854         (_MuxHandler.start):
 855         (_MuxHandler.wait_until_done):
 856         (_MuxHandler.notify_write_data_done):
 857         (_MuxHandler._process_drop_channel):
 858         (_MuxHandler._process_logical_frame):
 859         (_MuxHandler.notify_reader_done):
 860         (_MuxHandler):
 861         (_MuxHandler.notify_writer_done):
 862         (_MuxHandler.fail_physical_connection):
 863         (_MuxHandler.fail_logical_channel):
 864         (use_mux):
 865         * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py:
 866         (_StandaloneRequest.get_uri):
 867         (_StandaloneRequest.get_unparsed_uri):
 868         (_StandaloneRequest):
 869         (_StandaloneRequest.is_https):
 870         (_import_ssl):
 871         (_import_pyopenssl):
 872         (_StandaloneSSLConnection.for):
 873         (_StandaloneSSLConnection):
 874         (_StandaloneSSLConnection.__getattribute__):
 875         (_StandaloneSSLConnection.__setattr__):
 876         (_StandaloneSSLConnection.makefile):
 877         (_StandaloneSSLConnection.shutdown):
 878         (_StandaloneSSLConnection.recv):
 879         (WebSocketServer.__init__):
 880         (WebSocketServer._create_sockets):
 881         (WebSocketServer.handle_error):
 882         (WebSocketServer.get_request):
 883         (WebSocketServer.get_request.default_callback):
 884         (WebSocketRequestHandler.parse_request):
 885         (_build_option_parser):
 886         (_main):
 887         (_main.if):
 888         * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py:
 889         (RepeatedXorMasker.__init__):
 890         (RepeatedXorMasker._mask_using_swig):
 891         (RepeatedXorMasker):
 892         (RepeatedXorMasker._mask_using_array):
 893         (_Deflater.compress_and_finish):
 894         (_RFC1979Deflater.filter):
 895         (DeflateSocket.send):
 896
 897 2013-05-16  Jonathan Liu  <net147@gmail.com>
 898
 899         Fix testing if program exists in PATH
 900         https://bugs.webkit.org/show_bug.cgi?id=116216
 901
 902         Reviewed by Jocelyn Turcotte.
 903
 904         functions.prf incorrectly uses win_cmd_shell to test whether to
 905         add .exe to the executable name when checking if it exists in
 906         the PATH environment variable. This works correctly when
 907         building using Windows Command Prompt but not under MSYS shell.
 908
 909         To resolve this, check the win32 platform scope instead of
 910         win_cmd_shell so that it correctly adds .exe to the executable
 911         name on Windows regardless of the shell used when testing if
 912         it exists in PATH.
 913
 914         * qmake/mkspecs/features/functions.prf:
 915
 916 2013-05-16  Ryosuke Niwa  <rniwa@webkit.org>
 917
 918         Fix the hard-coded names of EWS bots that run tests.
 919
 920         * Scripts/webkitpy/tool/commands/queues.py:
 921         (CommitQueue.did_pass_testing_ews):
 922
 923 2013-05-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
 924
 925         [GTK] Build Xvfb with jhbuild
 926         https://bugs.webkit.org/show_bug.cgi?id=115907
 927
 928         Reviewed by Martin Robinson.
 929
 930         Build our own Xvfb so that we can avoid problems with the system Xvfb
 931         relying on symbols not present in our jhbuilt libraries such as pixman,
 932         and also to ensure we have the fix for a GLX module crasher.
 933
 934         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 935         (resetDefaultsToConsistentValues): enable accelerated compositing.
 936         * gtk/install-dependencies: list packages required for building Xvfb.
 937         * gtk/jhbuild.modules: add xserver as a jhbuild module.
 938         * gtk/patches/xserver-remove-bogus-dependencies.patch: Added.
 939         * gtk/patches/xserver-fix-glx-init.patch: Added. Fixes a crash while
 940         initializing the GLX module for Xvfb.
 941
 942 2013-05-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
 943
 944         [jhbuild] Should remove the sources directory as well when cleaning
 945         https://bugs.webkit.org/show_bug.cgi?id=116229
 946
 947         Reviewed by Martin Robinson.
 948
 949         * Scripts/update-webkit-libs-jhbuild:
 950         (cleanJhbuild): remove the Source directory as well when cleaning.
 951
 952 2013-05-15  Dominik Röttsches  <dominik.rottsches@intel.com>
 953
 954         [EFL] Remove Intel Wk2 Buildbots from Master
 955         https://bugs.webkit.org/show_bug.cgi?id=116149
 956
 957         Removing Intel maintained EFL Wk2 bots except the handle for efl-linux-slave-2
 958         since Gyuyoung Kim from Samsung plans to take over and maintain it.
 959
 960         Reviewed by Benjamin Poulain.
 961
 962         * BuildSlaveSupport/build.webkit.org-config/config.json:
 963
 964 2013-05-15  Brent Fulgham  <bfulgham@apple.com>
 965
 966         [Windows] Update various build tools to understand VS2010 environment.
 967         https://bugs.webkit.org/show_bug.cgi?id=116169.
 968
 969         Reviewed by Anders Carlsson.
 970
 971         * Scripts/build-api-tests: Identify VS2010 environment.
 972         * Scripts/build-dumprendertree: Ditto.
 973         * Scripts/build-webkit: Ditto.
 974         * Scripts/webkitdirs.pm:
 975         (dieIfWindowsPlatformSDKNotInstalled): Update to recognize a wider
 976         range of acceptable SDK's.
 977
 978 2013-05-15  Peter Gal  <galpeter@inf.u-szeged.hu>
 979
 980         Allow http tests on Arch Linux
 981         https://bugs.webkit.org/show_bug.cgi?id=116155
 982
 983         Reviewed by Ryosuke Niwa.
 984
 985         * Scripts/webkitpy/port/base.py:
 986         (Port._is_arch_based): Added check for /etc/arch-release file.
 987         (Port._apache_config_file_name_for_platform): Call the check.
 988         * Scripts/webkitpy/port/port_testcase.py:
 989         (test_linux_distro_detection): Testcase added.
 990
 991 2013-05-15  Peter Gal  <galpeter@inf.u-szeged.hu>
 992
 993         Remove a leftover v8 file from the watchlist
 994         https://bugs.webkit.org/show_bug.cgi?id=116158
 995
 996         Reviewed by Csaba Osztrogonác.
 997
 998         * Scripts/webkitpy/common/config/watchlist: Removed a v8 entry from the watchlist.
 999
1000 2013-05-15  Alberto Garcia  <agarcia@igalia.com>
1001
1002         [GTK] Fails to build while generating gtkdoc
1003         https://bugs.webkit.org/show_bug.cgi?id=115612
1004
1005         Reviewed by Philippe Normand.
1006
1007         Fix typo in the prerequisites of docs-build.stamp.
1008
1009         * GNUmakefile.am:
1010
1011 2013-05-15  Zan Dobersek  <zdobersek@igalia.com>
1012
1013         Unreviewed, fixing the current test-webkitpy failure.
1014
1015         * Scripts/webkitpy/port/mac_unittest.py:
1016         (test_setup_environ_for_server): Adjusting the expected DYLD_INSERT_LIBRARIES environment variable value
1017         in webkitpy.port.mac_unittest.test_setup_environ_for_server after r150089.
1018
1019 2013-05-14  Jaehun Lim  <ljaehun.lim@samsung.com>
1020
1021         Fix build after r150090.
1022         https://bugs.webkit.org/show_bug.cgi?id=116129
1023
1024         Unreviewed build fix after r150090.
1025
1026         * WebKitTestRunner/TestInvocation.cpp:
1027         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1028
1029 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
1030
1031         [Windows, others] Unreviewed build fix after r150090.
1032
1033         * DumpRenderTree/TestRunner.cpp:
1034         (getSecureEventInputIsEnabledCallback): IsSecureEventInputEnabled
1035         doesn't exist on other platforms.
1036
1037 2013-05-14  Brent Fulgham  <bfulgham@webkit.org>
1038
1039         [Windows] Expunge pthreads2VC.dll from DumpRenderTree Project
1040         https://bugs.webkit.org/show_bug.cgi?id=115889
1041
1042         Reviewed by Benjamin Poulain.
1043
1044         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
1045         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
1046
1047 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
1048
1049         [Windows] Identify proper run environment for scripts.
1050         https://bugs.webkit.org/show_bug.cgi?id=116114
1051
1052         Reviewed by David Kilzer.
1053
1054         Determine (based on Visual Studio version) which path to use for
1055         executables (bin versus bin32).
1056
1057         * Scripts/webkitdirs.pm:
1058         (determineVisualStudioInstallDir): Added.
1059         (determineVisualStudioVersion): Added.
1060         (determineConfigurationProductDir): Modified to choose proper bin
1061         or bin32 directory.
1062         (visualStudioVersion): Added
1063         (setupCygwinEnv): Modified to use new determineVisualStudioInstallDir
1064
1065 2013-05-14  Alexey Proskuryakov  <ap@apple.com>
1066
1067         [Mac] Add tests for secure event input
1068         https://bugs.webkit.org/show_bug.cgi?id=116121
1069
1070         Reviewed by Mark Rowe.
1071
1072         * DumpRenderTree/TestRunner.cpp:
1073         (getSecureEventInputIsEnabledCallback):
1074         (TestRunner::staticValues):
1075         Expose an accessor for current secure event input state.
1076
1077         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1078         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1079         (WTR::TestRunner::secureEventInputIsEnabled):
1080         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1081         * WebKitTestRunner/TestInvocation.cpp:
1082         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1083         Expose an accessor for current secure event input state. This has to be done in
1084         UI process, as this is where it's changed by WebKit.
1085
1086 2013-05-14  Alexey Proskuryakov  <ap@apple.com>
1087
1088         [Mac] Add a testing shim for secure event input functions
1089         https://bugs.webkit.org/show_bug.cgi?id=116122
1090
1091         Reviewed by Mark Rowe.
1092
1093         * Scripts/webkitpy/port/mac.py: (MacPort.setup_environ_for_server):
1094         Inject WebCore testing shim library to override system framework functions.
1095
1096 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
1097
1098         [Windows] Switch to embedded manifest commands for launcher executables.
1099         https://bugs.webkit.org/show_bug.cgi?id=116109
1100
1101         Reviewed by Darin Adler.
1102
1103         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Remove the
1104         now-unused WinLauncher.exe.manifest file.
1105         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Ditto.
1106         * win/DLLLauncher/DLLLauncherMain.cpp: Add embedded manifest command
1107         when building with VS2010 or newer.
1108
1109 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
1110
1111         [Windows] Update ORWT to know about the Windows 8 SDK and Debug Tools.
1112         https://bugs.webkit.org/show_bug.cgi?id=116079
1113
1114         Reviewed by David Kilzer.
1115
1116         * Scripts/old-run-webkit-tests:
1117         (setUpWindowsCrashLogSaving): Locate ntsd.exe and use it.
1118
1119 2013-05-14  Zan Dobersek  <zdobersek@igalia.com>
1120
1121         [GTK] Move generated ColorData.cpp, WebKitFontFamilyNames.(cpp|h) build targets into libPlatform
1122         https://bugs.webkit.org/show_bug.cgi?id=115921
1123
1124         Reviewed by Gustavo Noronha Silva.
1125
1126         * GNUmakefile.am: Add platform_cppflags to the list of CPPFLAGS for libWebCoreInternals and DumpRenderTree.
1127         * TestWebKitAPI/GNUmakefile.am: Add platform_cppflags to the list of TestGtk CPPFLAGS.
1128
1129 2013-05-13  Alex Christensen  <achristensen@apple.com>
1130
1131         Added testRunner.setPrinting.
1132         https://bugs.webkit.org/show_bug.cgi?id=42693
1133         rdar://problem/8213845
1134
1135         Reviewed by Darin Adler.
1136
1137         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1138         Added setPrinting JavaScript function.
1139         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1140         (WTR::InjectedBundlePage::dump):
1141         Dump the external representation for printing if setPrinting has been called.
1142         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1143         (WTR::TestRunner::isPrinting): Added.
1144         (WTR::TestRunner::setPrinting): Added.
1145         Added and initialized m_isPrinting member boolean.
1146
1147 2013-05-13  Csaba Osztrogonác  <ossy@webkit.org>
1148
1149         [webkitpy] Make FileInfo.repository_name support SVN version > 1.6
1150         https://bugs.webkit.org/show_bug.cgi?id=116016
1151
1152         Reviewed by Dirk Pranke.
1153
1154         Same fix as in the upstream style checker, but without hg support.
1155         ( http://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py )
1156
1157         * Scripts/webkitpy/style/checkers/cpp.py:
1158         (FileInfo.repository_name):
1159
1160 2013-05-13  Zan Dobersek  <zdobersek@igalia.com>
1161
1162         [GTK] Use WebCore layer archives for TestWebCore, WebKitPluginProcess
1163         https://bugs.webkit.org/show_bug.cgi?id=115918
1164
1165         Reviewed by Gustavo Noronha Silva.
1166
1167         Due to layer violations and circular dependencies the TestWebCores requires for the libraries containing
1168         the built code of the intertwining Platform and WebCore layers to be specified multiple times when linking.
1169         This can be avoided by packing the two layers' archives into one big archive, named after the WebCore layer
1170         due to no clear boundary between it and the Platform layer. The big archive can then be specified only once
1171         when linking, simplifying the code and suppressing all the layering violations so they do not cause build
1172         problems.
1173
1174         First the libtool libraries that the WebCore layer (as required by the TestWebCore) depends on are specified.
1175         These are then used as dependencies for the archive creation rule as well as the list from which the archive
1176         file paths are constructed and then used to dump the member files from these archives. The member files are
1177         then added to the big archive. The latter is added to the list of libraries the TestWebCore requires to
1178         successfully link.
1179
1180         * TestWebKitAPI/GNUmakefile.am:
1181
1182 2013-05-13  Anders Carlsson  <andersca@apple.com>
1183
1184         Remove UnusedParam.h
1185         https://bugs.webkit.org/show_bug.cgi?id=116029
1186
1187         Reviewed by Andreas Kling.
1188
1189         Stop including UnusedParam.h.
1190
1191         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1192         * WebKitTestRunner/qt/TestInvocationQt.cpp:
1193
1194 2013-05-12  Commit Queue  <commit-queue@webkit.org>
1195
1196         Unreviewed, rolling out r149955.
1197         http://trac.webkit.org/changeset/149955
1198         https://bugs.webkit.org/show_bug.cgi?id=115990
1199
1200         Broke lots of tests (Requested by smfr on #webkit).
1201
1202         * Scripts/webkitpy/port/mac.py:
1203
1204 2013-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1205
1206         [GTK] Remove unnecessary GTK_CHECK_VERSION #ifdefs
1207         https://bugs.webkit.org/show_bug.cgi?id=115914
1208
1209         Reviewed by Martin Robinson.
1210
1211         * GtkLauncher/main.c:
1212         (createToolbar):
1213         * MiniBrowser/gtk/BrowserWindow.c:
1214         (_BrowserWindow):
1215         (browserWindowSetStatusText):
1216         (fullScreenMessageTimeoutCallback):
1217         (webViewEnterFullScreen):
1218         (webViewLeaveFullScreen):
1219         (browserWindowFinalize):
1220         (browserWindowConstructed):
1221         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1222         (WTR::EventSenderProxy::mouseScrollBy):
1223         (WTR::EventSenderProxy::continuousMouseScrollBy):
1224
1225 2013-05-11  Anders Carlsson  <andersca@apple.com>
1226
1227         Crash when terminating a process that has not been fully launched
1228         https://bugs.webkit.org/show_bug.cgi?id=115962
1229         <rdar://problem/13660916>
1230
1231         Reviewed by Andreas Kling.
1232
1233         Add TerminateTwice, a test that terminates a page, then reloads it and terminates it again
1234         before the process has had a chance to be fully launched.
1235
1236         * TestWebKitAPI/GNUmakefile.am:
1237         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1238         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp: Added.
1239         (TestWebKitAPI):
1240         (TestWebKitAPI::didFinishLoadForFrame):
1241         (TestWebKitAPI::TEST):
1242         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro:
1243
1244 2013-05-10  Laszlo Gombos  <l.gombos@samsung.com>
1245
1246         Remove Mac OS X Leopard (10.5) support
1247         https://bugs.webkit.org/show_bug.cgi?id=107964
1248
1249         Reviewed by Ryosuke Niwa.
1250
1251         Removed the code for 10.5 and removed if-def for 10.6.
1252
1253         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
1254         (convertMIMEType):
1255         (createXMLStringFromWebArchiveData):
1256         * DumpRenderTree/mac/TestRunnerMac.mm:
1257         (TestRunner::authenticateSession):
1258         (TestRunner::setTextDirection):
1259         * WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:
1260         (convertMIMEType):
1261         (createXMLStringFromWebArchiveData):
1262
1263 2013-05-10  Brent Fulgham  <bfulgham@apple.com>
1264
1265         [Windows] Allow VS2010 Build to use VS2005 Support Libraries
1266         https://bugs.webkit.org/show_bug.cgi?id=115935
1267
1268         Reviewed by Jer Noble.
1269
1270         * WinLauncher/WinLauncher.vcxproj/WinLauncher.exe.manifest: Added.
1271         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add reference
1272         to the new manifest file.
1273         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Ditto.
1274
1275 2013-05-10  Jacky Jiang  <zhajiang@blackberry.com>
1276
1277         Fix some compiler warnings (miscellaneous)
1278         https://bugs.webkit.org/show_bug.cgi?id=80790
1279
1280         Reviewed by Rob Buis.
1281
1282         Fix the following warnings for BlackBerry:
1283         DumpRenderTree.cpp:357:42: warning: suggest parentheses around assignment
1284         used as truth value [-Wparentheses].
1285
1286         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1287         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
1288
1289 2013-05-10  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1290
1291         [WK2][CoordinatedGraphics] WKViewSetThemePath is EFL specific
1292         https://bugs.webkit.org/show_bug.cgi?id=115928
1293
1294         Reviewed by Kenneth Rohde Christiansen.
1295
1296         WKViewSetThemePath was moved to WKViewEfl.h.
1297
1298         * TestWebKitAPI/efl/PlatformWebView.cpp:
1299
1300 2013-05-10  Andreas Kling  <akling@apple.com>
1301
1302         I accidentally the Java testing.
1303
1304         * Scripts/webkitpy/port/mac.py:
1305
1306 2013-05-10  Brian Holt  <brian.holt@samsung.com>
1307
1308         [GTK] Module Cairo fails to build under jhbuild
1309         https://bugs.webkit.org/show_bug.cgi?id=115854
1310
1311         Reviewed by Martin Robinson.
1312
1313         Make cairo depend on glib in jhbuild.modules.
1314
1315         * gtk/jhbuild.modules:
1316
1317 2013-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1318
1319         [GTK] Remove unnecessary GLIB_CHECK_VERSION #ifdefs
1320         https://bugs.webkit.org/show_bug.cgi?id=115904
1321
1322         Reviewed by Martin Robinson.
1323
1324         * ImageDiff/gtk/ImageDiff.cpp:
1325         (main):
1326
1327 2013-05-10  Balazs Kelemen  <kbalazs@webkit.org>
1328
1329         Add my new address to contributors.json. (Unreviewed)
1330
1331         * Scripts/webkitpy/common/config/contributors.json:
1332
1333 2013-05-10  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1334
1335         Unreviewed. Move myself to the reviewers list.
1336
1337         * Scripts/webkitpy/common/config/contributors.json:
1338
1339 2013-05-10  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1340
1341         Unreviewed. Add my email to a few watchlists.
1342
1343         * Scripts/webkitpy/common/config/watchlist:
1344
1345 2013-05-10  Simon Pena  <simon.pena@samsung.com>
1346
1347         Unicode support missing from string representation of Contributors in committers.py
1348         https://bugs.webkit.org/show_bug.cgi?id=115859
1349
1350         Reviewed by Darin Adler.
1351
1352         Contributors, in committers.py, provided a string representation in __str__ which
1353         didn't support unicode characters, so printing a contributor would fail in that case.
1354         This patch implements __unicode__ and makes __str__ use it to represent a contributor.
1355         The unit tests are updated accordingly, so they ensure that a unicode name can be shown.
1356
1357         * Scripts/webkitpy/common/config/committers.py: Move the existing string representation
1358         to the newly implemented method __unicode__, and make __str__ display its utf-8 encoded
1359         representation.
1360         (Contributor.__str__):
1361         (Contributor):
1362         (Contributor.__unicode__):
1363         * Scripts/webkitpy/common/config/committers_unittest.py: Add a new test that checks that
1364         a contributor with unicode characters can be represented as a string.
1365         (CommittersTest):
1366         (CommittersTest.test_contributor_encoding):
1367
1368 2013-05-09  Patrick Gansterer  <paroga@webkit.org>
1369
1370         [WIN][DRT] Remove duplicated (start|stop)JavaScriptThreads()
1371         https://bugs.webkit.org/show_bug.cgi?id=92371
1372
1373         Reviewed by Brent Fulgham.
1374
1375         Use JavaScriptThreading.cpp where the same functionality is
1376         implemented too. This reduces the dependency on the pthread
1377         library. Also replace assert() with WebKit ASSERT().
1378
1379         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1380         * DumpRenderTree/win/DumpRenderTree.cpp:
1381         (dumpHistoryItem):
1382         (dumpBackForwardList):
1383         * DumpRenderTree/win/DumpRenderTree.vcproj:
1384
1385 2013-05-09  Patrick Gansterer  <paroga@webkit.org>
1386
1387         [DRT] Replace JavaScriptThreadingPthreads.cpp with JavaScriptThreading.cpp
1388         https://bugs.webkit.org/show_bug.cgi?id=92505
1389
1390         Reviewed by Brent Fulgham.
1391
1392         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1393         * DumpRenderTree/JavaScriptThreading.cpp: Copied from DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp.
1394         (javaScriptThreadsMutex):
1395         (javaScriptThreads):
1396         (runJavaScriptThread):
1397         (startJavaScriptThreads):
1398         (stopJavaScriptThreads):
1399         * DumpRenderTree/pthreads: Removed.
1400         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Removed.
1401
1402 2013-05-09  Mario Sanchez Prada  <mario.prada@samsung.com>
1403
1404         Unreviewed. Update Simon Pena email on his behalf.
1405
1406         * Scripts/webkitpy/common/config/contributors.json:
1407
1408 2013-05-09  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1409
1410         Add support for [NoInterfaceObject] Web IDL extended attribute
1411         https://bugs.webkit.org/show_bug.cgi?id=115714
1412
1413         Reviewed by Kentaro Hara.
1414
1415         Update BindingsTests.generate_supplemental_dependency() to pass an
1416         additional windowConstructorsFile argument to preprocess-idls.pl.
1417
1418         * Scripts/webkitpy/bindings/main.py:
1419         (BindingsTests.generate_supplemental_dependency):
1420         (BindingsTests.main):
1421
1422 2013-05-09  ChangSeok Oh  <changseok.oh@collabora.com>
1423
1424         [GTK][AC] Buildfix after r149694
1425         https://bugs.webkit.org/show_bug.cgi?id=115797
1426
1427         Reviewed by Gustavo Noronha Silva.
1428
1429         Add CLUTTER_LIBS for linking TestWebCore.
1430
1431         * TestWebKitAPI/GNUmakefile.am:
1432
1433 2013-05-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1434
1435         [EFL] Remove unnecessary pkgs in EFL jhbuild
1436         https://bugs.webkit.org/show_bug.cgi?id=114908
1437
1438         Reviewed by Laszlo Gombos.
1439
1440         p11-kit, libgpg-error and libgcrypt don't influence on layout test. So, we don't need to
1441         handle them using jhbuild. We can reduce build time when using --update-efl.
1442
1443         * efl/jhbuild.modules:
1444
1445 2013-05-08  Seokju Kwon  <seokju.kwon@gmail.com>
1446
1447         [EFL] Disable SHADOW DOM feature in FeatureList.pm
1448         https://bugs.webkit.org/show_bug.cgi?id=115834
1449
1450         Reviewed by Gyuyoung Kim.
1451
1452         * Scripts/webkitperl/FeatureList.pm:
1453
1454 2013-05-08  Lucas Forschler  <lforschler@apple.com>
1455
1456         Add Scheduler for Mac MtnLion 32bit Release builder.
1457
1458         Unreviewed.
1459
1460         * BuildSlaveSupport/build.webkit.org-config/config.json:
1461
1462 2013-05-08  Denis Nomiyama  <d.nomiyama@samsung.com>
1463
1464         Update JSCIdentifier pretty printer in Tools/gdb/webkit.py
1465         https://bugs.webkit.org/show_bug.cgi?id=115808
1466
1467         Reviewed by Darin Adler.
1468
1469         The pretty printer for the JSCIdentifier in Tools/gdb/webkit.py
1470         was left outdated after r127191, when the m_string member was changed
1471         from UString to String. This patch calls the right pretty printer for it.
1472
1473         * gdb/webkit.py:
1474         (JSCIdentifierPrinter.to_string): Use WTFPrettyPrinter instead of
1475         WTFImplPrettyPrinter.
1476
1477 2013-05-08  Andy Estes  <aestes@apple.com>
1478
1479         [WebKit2] REGRESSION (Custom Protocols): Reproducible crash when navigating to URL with an invalid scheme
1480         https://bugs.webkit.org/show_bug.cgi?id=115790
1481
1482         Reviewed by Alexey Proskuryakov.
1483
1484         Added two API tests:
1485
1486         1) Verify that +[WKBrowsingContextController (un)registerSchemeForCustomProtocol:] can be called with a nil NSString without crashing.
1487         2) Verify that +[WKCustomProtocol canInitWithRequest:] does not crash when passed an NSURLRequest with an invalid scheme.
1488
1489         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1490         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm: Added.
1491         (TestWebKitAPI):
1492         (TestWebKitAPI::TEST):
1493         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp: Added.
1494         (TestWebKitAPI):
1495         (TestWebKitAPI::decidePolicyForNavigationAction):
1496         (CustomProtocolInvalidSchemeTest):
1497         (TestWebKitAPI::CustomProtocolInvalidSchemeTest::CustomProtocolInvalidSchemeTest):
1498
1499 2013-05-08  Lucas Forschler  <lforschler@apple.com>
1500
1501         Teach buildbot how to compile 32-bit on Mac.
1502
1503         Reviewed by Ryosuke Niwa.
1504
1505         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1506         (CompileWebKit.start):
1507         (ExtractTestResultsAndLeaks):
1508
1509 2013-05-08  Eli Fidler  <efidler@blackberry.com>
1510
1511         [BlackBerry] Fix usage of BlackBerry::Platform::String
1512         https://bugs.webkit.org/show_bug.cgi?id=115781
1513
1514         Reviewed by Rob Buis.
1515
1516         BlackBerry PRs 304193 and 327181
1517         Internally Reviewed by Mike Lattanzio, Arvid Nilsson, Joe Mason, Jeff Rogers, and George Staikos
1518
1519         We currently have a problem where we're passing UTF-8 encoded data into
1520         the char* constructors of BlackBerry::Platform::String. This means the string
1521         thinks its data is not UTF-8.
1522
1523         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1524         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
1525         (BlackBerry::WebKit::dumpHistoryItem):
1526         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1527         (TestRunner::setUserStyleSheetLocation):
1528         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
1529         (LoadHTMLStringItem::invoke):
1530
1531 2013-05-08  Alberto Garcia  <agarcia@igalia.com>
1532
1533         Tools: add new BlackBerry include dirs.
1534         https://bugs.webkit.org/show_bug.cgi?id=115514
1535
1536         Reviewed by Rob Buis.
1537
1538         iType include dirs are missing, and HarfBuzz needs to be fixed.
1539
1540         * Scripts/webkitdirs.pm:
1541         (blackberryCMakeArguments):
1542
1543 2013-05-08  José Dapena Paz  <jdapena@igalia.com> and Zan Dobersek  <zdobersek@igalia.com>
1544
1545         [GTK] Plumb the Automake build system for the Battery Status API feature
1546         https://bugs.webkit.org/show_bug.cgi?id=115718
1547
1548         Reviewed by Martin Robinson.
1549
1550         * Scripts/webkitdirs.pm:
1551         (buildAutotoolsProject): List battery-status as a configurable feature, meaning its value will be adjusted
1552         through the --(enable|disable)-battery-status flag passed to configure.
1553
1554 2013-05-08  Ryosuke Niwa  <rniwa@webkit.org>
1555
1556         new-run-webkit-websocketserver doesn't work after Chromium removal
1557         https://bugs.webkit.org/show_bug.cgi?id=115816
1558
1559         Reviewed by Joseph Pecoraro.
1560
1561         Fix the bug by instantiating the correct port object.
1562
1563         * Scripts/new-run-webkit-websocketserver:
1564         (main):
1565
1566 2013-05-07  Lucas Forschler  <lforschler@apple.com>
1567
1568         Configure buildbot for 32bit builder.
1569         https://bugs.webkit.org/show_bug.cgi?id=115769
1570
1571         Reviewed by Ryosuke Niwa.
1572
1573         * BuildSlaveSupport/build.webkit.org-config/config.json:
1574
1575 2013-05-08  Brent Fulgham  <bfulgham@webkit.org>
1576
1577         Unreviewed. Update to show my apple.com address.
1578
1579         * Scripts/webkitpy/common/config/contributors.json: Added
1580         my apple.com e-mail address.
1581
1582 2013-05-08  David Kilzer  <ddkilzer@apple.com>
1583
1584         BUILD FIX (r149579): Use Vector::appendVector() instead of Vector::append()
1585
1586         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1587         (concatenateAttributeAndValue): Switch to appendVector().
1588
1589 2013-05-08  Andras Becsi  <andras.becsi@digia.com>
1590
1591         [Qt][WTR] Fix the build on Mac after r149692
1592
1593         Unreviewed build fix.
1594
1595         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1596         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
1597
1598 2013-05-08  Mario Sanchez Prada  <mario.prada@samsung.com>
1599
1600         Unreviewed. Added Anton Obzhirov to the list of contributors and myself
1601         to the watchlist for Accessibility.
1602
1603         * Scripts/webkitpy/common/config/contributors.json: Added Anton Obzhirov.
1604         * Scripts/webkitpy/common/config/watchlist: Added myself.
1605
1606 2013-05-08  Andras Becsi  <andras.becsi@digia.com>
1607
1608         [Qt] Build fails with clang
1609         https://bugs.webkit.org/show_bug.cgi?id=115741
1610
1611         Reviewed by Benjamin Poulain.
1612
1613         Since r149112 std::move is used in AtomicString for compilers that
1614         support rvalue references and this requires a standard library
1615         implementing c++11 move semantics.
1616         We only explicitely require c++11 for WebKit2, but since clang supports
1617         rvalue references the build of subtargets using AtomicString fails because
1618         of missing std::move.
1619         It is safe to add CONFIG += c++11 for the whole project when using clang
1620         since we explicitely disable c++11 for ANGLE that had probems with libc++.
1621
1622         * qmake/mkspecs/features/unix/default_pre.prf:
1623
1624 2013-05-08  Darin Adler  <darin@apple.com>
1625
1626         Fix one more place that needed to use adoptCF/NS
1627         https://bugs.webkit.org/show_bug.cgi?id=115778
1628
1629         Reviewed by Benjamin Poulain.
1630
1631         Not sure why I missed this code last time, but found a bit more code that needs
1632         to switch to the newer style adoptCF/NS.
1633
1634         * WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:
1635         (convertWebResourceDataToString): Use adoptCF.
1636         (convertWebResourceResponseToDictionary): Ditto.
1637         (createXMLStringFromWebArchiveData): Ditto.
1638         * WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm:
1639         (createCFURLResponseFromResponseData): Use adoptNS and adoptCF.
1640
1641 2013-05-08  Commit Queue  <commit-queue@webkit.org>
1642
1643         Unreviewed, rolling out r149271.
1644         http://trac.webkit.org/changeset/149271
1645         https://bugs.webkit.org/show_bug.cgi?id=115780
1646
1647         The mangled symbols are now enforced through LDFLAGS
1648         (Requested by zdobersek on #webkit).
1649
1650         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
1651
1652 2013-05-08  Zan Dobersek  <zdobersek@igalia.com>
1653
1654         [Flakiness Dashboard] Remove the Chromium fallback platforms listing from the legend popup
1655         https://bugs.webkit.org/show_bug.cgi?id=115636
1656
1657         Reviewed by Ryosuke Niwa.
1658
1659         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1660         (showLegend): Remove the listing of the Chromium fallback platforms from the legend popup. The code iterated
1661         through the platforms in the g_fallbacksMap dictionary to construct this part of the legend, but the dictionary,
1662         while Chromium-specific, can't be removed just yet as there's more code that uses it.
1663
1664 2013-05-06  Darin Adler  <darin@apple.com>
1665
1666         Use adoptCF and adoptNS in more places, test code and code not compiled on Mac
1667         https://bugs.webkit.org/show_bug.cgi?id=115657
1668
1669         Reviewed by Sam Weinig.
1670
1671         This is similar to my last set of changes, but covers code that I missed with
1672         global replace using the Safari Xcode workspace.
1673
1674         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
1675         (convertWebResourceDataToString):
1676         (convertWebResourceResponseToDictionary):
1677         (createXMLStringFromWebArchiveData):
1678         * DumpRenderTree/cg/ImageDiffCG.cpp:
1679         (createImageFromStdin):
1680         (createDifferenceImage):
1681         (main):
1682         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1683         (printPNG):
1684         (dumpBitmap):
1685         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1686         (BitmapContext::BitmapContext):
1687         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
1688         (-[MockWebNotificationProvider init]):
1689         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1690         (createBitmapContext):
1691         * DumpRenderTree/mac/TestRunnerMac.mm:
1692         (TestRunner::addDisallowedURL):
1693         (TestRunner::applicationCacheDiskUsageForOrigin):
1694         (TestRunner::localStorageDiskUsageForOrigin):
1695         (TestRunner::clearApplicationCacheForOrigin):
1696         (TestRunner::deleteLocalStorageForOrigin):
1697         (TestRunner::copyDecodedHostName):
1698         (TestRunner::copyEncodedHostName):
1699         (TestRunner::queueLoad):
1700         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
1701         (TestRunner::setMockGeolocationPositionUnavailableError):
1702         (TestRunner::setUserStyleSheetLocation):
1703         (TestRunner::setValueForUser):
1704         (TestRunner::overridePreference):
1705         (TestRunner::setPersistentUserStyleSheetLocation):
1706         (TestRunner::execCommand):
1707         (TestRunner::findString):
1708         (TestRunner::isCommandEnabled):
1709         (TestRunner::addOriginAccessWhitelistEntry):
1710         (TestRunner::removeOriginAccessWhitelistEntry):
1711         (TestRunner::addUserScript):
1712         (TestRunner::addUserStyleSheet):
1713         (TestRunner::evaluateInWebInspector):
1714         (TestRunner::evaluateScriptInIsolatedWorld):
1715         (TestRunner::apiTestNewWindowDataLoadBaseURL):
1716         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
1717         (TestRunner::authenticateSession):
1718         (TestRunner::grantWebNotificationPermission):
1719         (TestRunner::denyWebNotificationPermission):
1720         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
1721         (createCFURLResponseFromResponseData):
1722         * DumpRenderTree/mac/WorkQueueItemMac.mm:
1723         (LoadItem::invoke):
1724         (LoadHTMLStringItem::invoke):
1725         (ScriptItem::invoke):
1726         * DumpRenderTree/win/DumpRenderTree.cpp:
1727         (substringFromIndex):
1728         (urlSuitableForTestResult):
1729         (lastPathComponent):
1730         (sharedCFURLCache):
1731         * DumpRenderTree/win/ImageDiffCairo.cpp:
1732         (createImageFromStdin):
1733         (main):
1734         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
1735         (createBitmapContextFromWebView):
1736         * DumpRenderTree/win/TestRunnerWin.cpp:
1737         (TestRunner::setUserStyleSheetLocation):
1738         (TestRunner::setPersistentUserStyleSheetLocation):
1739         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1740         (TestWebKitAPI::TEST):
1741         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
1742         (TestWebKitAPI::TEST):
1743         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
1744         (TestWebKitAPI::TEST):
1745         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
1746         (TestWebKitAPI::TEST):
1747         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
1748         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1749         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
1750         (TestWebKitAPI::createWindow):
1751         (TestWebKitAPI::TEST):
1752         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
1753         (TestWebKitAPI::TEST):
1754         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
1755         (TestWebKitAPI::AcceptsFirstMouse::runTest):
1756         * TestWebKitAPI/Tests/mac/AttributedString.mm:
1757         (TestWebKitAPI::TEST):
1758         * TestWebKitAPI/Tests/mac/BackForwardList.mm:
1759         (TestWebKitAPI::TEST):
1760         * TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.mm:
1761         (TestWebKitAPI::TEST):
1762         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
1763         (TestWebKitAPI::TEST):
1764         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm:
1765         (TestWebKitAPI::TEST):
1766         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
1767         (TestWebKitAPI::TEST):
1768         * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm:
1769         (TestWebKitAPI::TEST):
1770         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
1771         (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
1772         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
1773         (TestWebKitAPI::DynamicDeviceScaleFactor::createWindow):
1774         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
1775         (TestWebKitAPI::TEST):
1776         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
1777         (TestWebKitAPI::TEST):
1778         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
1779         (TestWebKitAPI::TEST):
1780         * TestWebKitAPI/Tests/mac/MemoryCacheDisableWithinResourceLoadDelegate.mm:
1781         (TestWebKitAPI::TEST):
1782         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm:
1783         (TestWebKitAPI::TEST):
1784         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1785         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
1786         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
1787         (TestWebKitAPI::TEST):
1788         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
1789         (TestWebKitAPI::TEST):
1790         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
1791         (TestWebKitAPI::TEST):
1792         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
1793         (TestWebKitAPI::TEST):
1794         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
1795         (TestWebKitAPI::TEST):
1796         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
1797         (TestWebKitAPI::TEST):
1798         * TestWebKitAPI/Tests/mac/WindowlessWebViewWithMedia.mm:
1799         (TestWebKitAPI::TEST):
1800         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1801         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
1802         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
1803         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
1804         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
1805         * WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
1806         (WTR::testPathFromURL):
1807         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1808         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1809         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1810         (WTR::createCGContextFromImage):
1811         (WTR::dumpBitmap):
1812         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1813         * WebKitTestRunner/mac/EventSenderProxy.mm:
1814         (WTR::EventSenderProxy::mouseScrollBy):
1815         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1816         (WTR::PlatformWebView::windowSnapshotImage):
1817         * WebKitTestRunner/win/TestControllerWin.cpp:
1818         (WTR::TestController::initializeTestPluginDirectory):
1819         Use adoptCF and adoptNS.
1820
1821 2013-05-07  Alex Christensen  <achristensen@apple.com>
1822
1823         Fix a memory leak introduced in r149692
1824         https://bugs.webkit.org/show_bug.cgi?id=115766
1825
1826         Reviewed by Mark Rowe.
1827
1828         In r149692, the fix for <http://webkit.org/b/42324>, a call to WKBundleFrameCopyWebArchive was added without any
1829         matching call to WKRelease. An earlier attempted fix in r149697 introduced a RetainPtr but failed to adopt the object.
1830
1831         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1832         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
1833         Fix the memory leak by switching to WKRetainPtr and adopting the returned object.
1834
1835 2013-05-07  Darin Adler  <darin@apple.com>
1836
1837         [Win] Fix storage leak in Windows DumpRenderTree
1838         https://bugs.webkit.org/show_bug.cgi?id=115651
1839
1840         Reviewed by Sam Weinig.
1841
1842         * DumpRenderTree/win/DumpRenderTree.cpp:
1843         (lastPathComponent): Added a missing call to adoptCF.
1844
1845 2013-05-07  Alex Christensen  <achristensen@apple.com>
1846
1847         fixed a memory leak introduced by bug 42324 by using a RetainPtr
1848         https://bugs.webkit.org/show_bug.cgi?id=115760
1849
1850         Reviewed by Tim Horton.
1851
1852         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1853         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
1854         fixed memory leak, added UNUSED_PARAM macros
1855
1856 2013-05-07  Alex Christensen  <achristensen@apple.com>
1857
1858         WebKitTestRunner needs testRunner.dumpDOMAsWebArchive
1859         https://bugs.webkit.org/show_bug.cgi?id=42324
1860         <rdar://problem/8193633>
1861
1862         Reviewed by Tim Horton.
1863
1864         * Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1865         Added dumpDOMAsWebArchive JavaScript function to be called by test cases.
1866         * Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1867         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
1868         Added dumpDOMAsWebArchive code that is called when dumping.
1869         (WTR::InjectedBundlePage::dump):
1870         Made DOMAsWebArchive case when dumping call dumpDOMAsWebArchive.
1871         * Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1872         (InjectedBundlePage):
1873         Added dumpDOMAsWebArchive declaration.
1874         * Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:
1875         (WTR::TestRunner::dumpDOMAsWebArchive):
1876         Added dumpDOMAsWebArchive JS callback function that sets m_whatToDump to DOMAsWebArchive.
1877         * Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1878         Added WebArchiveDumpSupport.cpp, WebArchiveDumpSupport.h, WebArchiveDumpSupportMac.mm to project.
1879         * Tools/WebKitTestRunner/cf: Added.
1880         * Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.cpp: Added.
1881         Copied from Tools/DumpRenderTree/cf for createXMLStringFromWebArchiveData and other functions it uses.
1882         (convertMIMEType):
1883         (convertWebResourceDataToString):
1884         (normalizeHTTPResponseHeaderFields):
1885         (normalizeWebResourceURL):
1886         (convertWebResourceResponseToDictionary):
1887         (compareResourceURLs):
1888         (createXMLStringFromWebArchiveData):
1889         * Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.h: Added.
1890         Copied from Tools/DumpRenderTree/cf for used symbol declarations.
1891         * Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm: Added.
1892         Copied from Tools/DumpRenderTree/mac for used functions.
1893         (createCFURLResponseFromResponseData):
1894         (supportedNonImageMIMETypes):
1895
1896 2013-05-07  Alex Christensen  <achristensen@apple.com>
1897
1898         Updated style of WebArchiveDumpSupport before putting it into WebKitTestRunner.
1899         https://bugs.webkit.org/show_bug.cgi?id=115745
1900
1901         Reviewed by Tim Horton.
1902
1903         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
1904         (compareResourceURLs):
1905         Updated style.
1906
1907 2013-05-06  Ryosuke Niwa  <rniwa@webkit.org>
1908
1909         Add an 'isReadOnly' member to IDL parse tree structure
1910         https://bugs.webkit.org/show_bug.cgi?id=115704
1911
1912         Reviewed by Kentaro Hara.
1913
1914         Use newly added isReadOnly attribute.
1915
1916         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1917         (_generateHeaderFile):
1918         (_generateImplementationFile):
1919         (_staticValuesGetterImplementation):
1920
1921 2013-05-07  Anders Carlsson  <andersca@apple.com>
1922
1923         Remove AlwaysInline.h from WTF
1924         https://bugs.webkit.org/show_bug.cgi?id=115727
1925
1926         Reviewed by Brent Fulgham.
1927
1928         The macro that used to be in AlwaysInline.h is now in Compiler.h so there's no reason
1929         to keep AlwaysInline.h around anymore.
1930
1931         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
1932         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
1933
1934 2013-05-07  Andras Becsi  <andras.becsi@digia.com>
1935
1936         [Qt][WTR] QQuickWindowPrivate::setRenderWithoutShowing has been removed from Qt 5
1937         https://bugs.webkit.org/show_bug.cgi?id=114808
1938
1939         Reviewed by Jocelyn Turcotte.
1940
1941         QQuickWindow::grabWindow() has been implemented for isVisible=false for Qt 5.1.
1942         (https://codereview.qt-project.org/#change,54234)
1943
1944         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1945         (WTR::WrapperWindow::handleStatusChanged):
1946
1947 2013-05-06  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1948
1949         Unreviewed. Add my email to EFL and BindingsScripts watchlists.
1950
1951         * Scripts/webkitpy/common/config/watchlist:
1952
1953 2013-05-06  Kangil Han  <kangil.han@samsung.com>
1954
1955         [EFL][WK1][PerformanceTests] Adopt --no-timeout option implementation to DumpRenderTree
1956         https://bugs.webkit.org/show_bug.cgi?id=115645
1957
1958         Reviewed by Gyuyoung Kim.
1959
1960         To run performance tests in wk1, we need --no-timeout option implementation.
1961         So adopt it from gtk+ port.
1962
1963         * DumpRenderTree/efl/DumpRenderTree.cpp:
1964         (shouldSetWaitToDumpWatchdog):
1965         (parseCommandLineOptions):
1966         * DumpRenderTree/efl/DumpRenderTreeEfl.h:
1967         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1968         (TestRunner::setWaitToDump):
1969
1970 2013-05-06  Commit Queue  <commit-queue@webkit.org>
1971
1972         Unreviewed, rolling out r149547.
1973         http://trac.webkit.org/changeset/149547
1974         https://bugs.webkit.org/show_bug.cgi?id=115682
1975
1976         Added unittests that fail on bots and spits out text into
1977         stdout (Requested by rniwa on #webkit).
1978
1979         * Scripts/import-w3c-tests: Removed.
1980         * Scripts/webkitpy/w3c/__init__.py: Removed.
1981         * Scripts/webkitpy/w3c/test_converter.py: Removed.
1982         * Scripts/webkitpy/w3c/test_converter_unittest.py: Removed.
1983         * Scripts/webkitpy/w3c/test_importer.py: Removed.
1984         * Scripts/webkitpy/w3c/test_importer_unittest.py: Removed.
1985         * Scripts/webkitpy/w3c/test_parser.py: Removed.
1986         * Scripts/webkitpy/w3c/test_parser_unittest.py: Removed.
1987
1988 2013-05-03  Gustavo Noronha Silva  <gns@gnome.org>
1989
1990         [jhbuild] bump jhbuild version to take advantage of new improvements
1991         https://bugs.webkit.org/show_bug.cgi?id=115558
1992
1993         Reviewed by Martin Robinson.
1994
1995         One of the important improvements is jhbuild no longer fetches git
1996         repositories if they are already at the expected revision, which should
1997         make the EWS bots more robust to git servers unavailability.
1998
1999         * jhbuild/jhbuild-wrapper: bump jhbuild to 496974221c3a8ac4fbbc3b0a577c71cac224130d.
2000
2001 2013-05-06  Manuel Rego Casasnovas  <rego@igalia.com>
2002
2003         [GTK] Add webkit_uri_scheme_request_finish_error
2004         https://bugs.webkit.org/show_bug.cgi?id=94316
2005
2006         Reviewed by Anders Carlsson.
2007
2008         * MiniBrowser/gtk/main.c:
2009         (miniBrowserErrorQuark): Add function to create a global quark for
2010         MiniBrowser.
2011         (aboutURISchemeRequestCallback): Update MiniBrowser to use the new
2012         function webkit_uri_scheme_request_finish_error().
2013
2014 2013-05-06  Mike Lattanzio  <mlattanzio@blackberry.com>
2015
2016         [BlackBerry] Enable and Expose Text Autosizing through BlackBerry::WebKit::WebSettings
2017         https://bugs.webkit.org/show_bug.cgi?id=113808
2018
2019         Reviewed by Rob Buis.
2020
2021         Modify FeatureList.pm and set ENABLE_TEXT_AUTOSIZING to default
2022         to true for BlackBerry.
2023
2024         * Scripts/webkitperl/FeatureList.pm:
2025
2026 2013-05-06  Jessie Berlin  <jberlin@apple.com>
2027
2028         check-webkit-style should complain about a layering violation if platform-specific guards are
2029         used in WebCore outside of the platform directory
2030         https://bugs.webkit.org/show_bug.cgi?id=115567
2031
2032         Reviewed by Benjamin Poulain.
2033
2034         * Scripts/webkitpy/style/checkers/cpp.py:
2035         (check_for_webcore_platform_layering_violation):
2036         If the file is in WebCore but not in platform and contains #if PLATFORM(SOMETHING), emit an error.
2037         (process_line):
2038         Add the check_for_webcore_platform_layering_violation.
2039         (CppChecker):
2040         List the new check.
2041
2042         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2043         (CppStyleTest.test_webcore_platform_layering_violation):
2044         Add tests.
2045
2046 2013-05-06  David Kilzer  <ddkilzer@apple.com>
2047
2048         webkit-patch: fix 'upload' command with Bugzilla 4.2.5
2049         <http://webkit.org/b/115667>
2050
2051         Reviewed by Dirk Pranke.
2052
2053         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2054         (Bugzilla._check_create_bug_response): Update regex to work with
2055         Bugzilla 3.2.3 and 4.2.5.
2056         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2057         (test__check_create_bug_response): Add new test that covers both
2058         old and new <title> variations.
2059
2060 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
2061
2062         [Flakiness Dashboard] Stop decoding SnowLeopard builder names into platforms
2063         https://bugs.webkit.org/show_bug.cgi?id=115661
2064
2065         Reviewed by Ryosuke Niwa.
2066
2067         The Apple Mac Snow Leopard builders are no long present so there's no need to try to decode such
2068         builders into the APPLE_MAC_SNOW_LEOPARD platforms. Instead, check for the Mountain Lion builders
2069         and decode their names into the APPLE_MAC_MOUNTAIN_LION platforms.
2070
2071         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2072         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2073
2074 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
2075
2076         [Flakiness Dashboard] Remove everything Chromium from the builders.json-generating script
2077         https://bugs.webkit.org/show_bug.cgi?id=114603
2078
2079         Reviewed by Ryosuke Niwa.
2080
2081         * TestResultServer/generate_builders_json.py:
2082         (insert_builder_and_test_data): Only process the 'layout-tests' steps, but force the name that's used
2083         to represent these to be 'layout-test', for backwards compatibility.
2084         (main): Remove all the build.chromium.org masters.
2085         * TestResultServer/generate_builders_json_unittest.py: Clean up the Chromium-related test cases and update other ones.
2086         (GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
2087         (GenerateBuildersJsonTest):
2088         (GenerateBuildersJsonTest.test_generate_json_data):
2089         * TestResultServer/static-dashboards/builders.jsonp: Updated after changes to the script, now only lists the
2090         test-running builders from the webkit.org master.
2091
2092 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
2093
2094         [Flakiness Dashboard] Update expected outcome in a couple of unit tests after r148778
2095         https://bugs.webkit.org/show_bug.cgi?id=114988
2096
2097         Reviewed by Ryosuke Niwa.
2098
2099         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Update the expected platforms list, the Chromium
2100         and Apple Mac Snow Leopard platforms were removed with the Apple Mac Mountain Lion platform being added.
2101         * TestResultServer/static-dashboards/loader_unittests.js: Update the list of the expected loaded expectations platforms,
2102         mac-snowleopard isn't loaded anymore due to the support for the platform being removed, while the mac-wk2 is loaded twice,
2103         once for the Apple Mac Lion and once for the Apple Mac Mountain Lion platform.
2104
2105 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
2106
2107         [Flakiness Dashboard] Remove the remaining traces of platform modifier unions
2108         https://bugs.webkit.org/show_bug.cgi?id=114954
2109
2110         Reviewed by Ryosuke Niwa.
2111
2112         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2113         (processExpectationsForPlatform): Remove the platform tree traversal that checked for presence of the platform
2114         modifier unions in the list of modifiers.
2115         (generatePageForExpectationsUpdate): Only filter through the modifiers that do not represent build types or bug references.
2116         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Adjust the test cases for the realModifiers unit test.
2117
2118 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
2119
2120         [Flakiness Dashboard] Simplify builder-name-based platform recognition
2121         https://bugs.webkit.org/show_bug.cgi?id=114957
2122
2123         Reviewed by Ryosuke Niwa.
2124
2125         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2126         (determineBuilderPlatform): Renamed from nonChromiumPlatform.
2127         (chromiumPlatform): Removed, unnecessary.
2128         (platformAndBuildType): With Chromium builders are gone, meaning determineBuilderPlatform can be called by default
2129         to determine the platform of the builder. No need to check for 'DBG' substring in the builder name to determine whether
2130         the builder operates with debug builds, no webkit.org builders are named this way.
2131         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2132         (platformAndBuildTypes): Remove Chromium-specific test cases, reducing the number of expected assertions this test will make.
2133
2134 2013-05-06  Andy Estes  <aestes@apple.com>
2135
2136         Added two files I neglected to commit in r149589.
2137
2138         * TestWebKitAPI/Tests/mac/CloseNewWindowInNavigationPolicyDelegate.mm: Added.
2139         * TestWebKitAPI/Tests/mac/OpenNewWindow.html: Added.
2140
2141 2013-05-04  Andy Estes  <aestes@apple.com>
2142
2143         REGRESSION (r125592): Reproducible crash in DOMWindow::open when a delegate closes the new window in decidePolicyForNavigationAction
2144         https://bugs.webkit.org/show_bug.cgi?id=115609
2145
2146         Reviewed by Oliver Hunt.
2147
2148         Added an API test.
2149
2150         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2151         * TestWebKitAPI/Tests/mac/CloseNewWindowInNavigationPolicyDelegate.mm: Added.
2152         (+[TestDelegate shared]):
2153         (-[TestDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2154         (-[TestDelegate webView:createWebViewWithRequest:]):
2155         (TestWebKitAPI):
2156         (TestWebKitAPI::TEST):
2157         * TestWebKitAPI/Tests/mac/OpenNewWindow.html: Added.
2158
2159 2013-05-06  Antoine Quint  <graouts@apple.com>
2160
2161         Manage the presentation of the snapshotted plug-in using JavaScript
2162         https://bugs.webkit.org/show_bug.cgi?id=115548
2163
2164         Reviewed by Dean Jackson.
2165
2166         Take into account the new plugInExtraScript method added to support
2167         the injection of a JS file from the chrome client to customize the
2168         rendering of a snapshotted plug-in's shadow tree.
2169
2170         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2171         (WTR::InjectedBundlePage::InjectedBundlePage):
2172
2173 2013-05-05  Anders Carlsson  <andersca@apple.com>
2174
2175         Remove the Vector::append overload that takes a Vector
2176         https://bugs.webkit.org/show_bug.cgi?id=115535
2177
2178         Reviewed by Andreas Kling.
2179
2180         Use Vector::appendVector instead.
2181
2182         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2183         (concatenateAttributeAndValue):
2184         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2185         (WTR::concatenateAttributeAndValue):
2186
2187 2013-05-04  Sam Weinig  <sam@webkit.org>
2188
2189         REGRESSION(r148312): Crash when calling WKPageClose(page) followed by WKPageTerminate(page)
2190         <rdar://problem/13702008>
2191         https://bugs.webkit.org/show_bug.cgi?id=115607
2192
2193         Reviewed by Benjamin Poulain.
2194
2195         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2196         * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp: Added.
2197         (TestWebKitAPI::didFinishLoadForFrame):
2198         (TestWebKitAPI::TEST):
2199         Add test that calls WKPageClose, follow by WKPageTerminate. If it crashes, its not working.
2200
2201 2013-05-04  Zan Dobersek  <zdobersek@igalia.com>
2202
2203         Unreviewed.
2204
2205         * Scripts/webkitpy/common/config/contributors.json: Correcting my igalia.com email address.
2206
2207 2013-05-04  Mihnea Ovidenie  <mihnea@adobe.com>
2208
2209         Unreviewed. Adding Radu Stavila as an Adobe contributor, working on CSSRegions.
2210
2211         * Scripts/webkitpy/common/config/contributors.json:
2212
2213 2013-05-04  Zan Dobersek  <zdobersek@igalia.com>
2214
2215         [GTK] Catch select.error exceptions in parse_output_lines
2216         https://bugs.webkit.org/show_bug.cgi?id=115253
2217
2218         Reviewed by Gustavo Noronha Silva.
2219
2220         Catch any select.error exceptions when waiting for the file descriptor to become readable when parsing the
2221         output lines in common.parse_output_lines. These are currently being thrown when running the GTK unit tests on
2222         builders, but are not fatal. Because of that they are at the moment only logged (writing out the file descriptor,
2223         error code and the error message) and the loop is re-entered.
2224
2225         * gtk/common.py:
2226         (parse_output_lines):
2227
2228 2013-05-04  Zan Dobersek  <zdobersek@igalia.com>
2229
2230         [GTK] Set up the TestWebCore in TestWebKitAPI
2231         https://bugs.webkit.org/show_bug.cgi?id=115237
2232
2233         Reviewed by Gustavo Noronha Silva.
2234
2235         Set up the WebCore unit test program, consisting of the unit tests under the TestWebKitAPI/Tests/WebCore directory.
2236         Again the approach of specifying libtool libraries multiple times in the TestWebCore program's LDFLAGS is used as
2237         a workaround for the layer violations and circular dependencies between various static libraries. Linking against
2238         either libwebkitgtk or libwebkit2gtk shared libraries is avoided due to the unit tests covering WebCore, which
2239         shouldn't rely on neither of the two distributable libraries (hence the dirty workaround).
2240
2241         * TestWebKitAPI/GNUmakefile.am:
2242
2243 2013-05-03  Rebecca Hauck  <rhauck@adobe.com>
2244
2245         Create a script to import W3C tests
2246         https://bugs.webkit.org/show_bug.cgi?id=111513
2247
2248         Reviewed by Dirk Pranke.
2249
2250         Script to automate the import of W3C tests into WebKit.
2251         For the full description of how it works, see the comments
2252         at the top of test_importer.py.
2253
2254         * Scripts/import-w3c-tests: Added.
2255         * Scripts/webkitpy/w3c/__init__.py: Added.
2256         * Scripts/webkitpy/w3c/test_converter.py: Added.
2257         (TestConverter):
2258         (TestConverter.__init__):
2259         (TestConverter.load_prefixed_prop_list):
2260         (TestConverter.load_file):
2261         (TestConverter.convert_for_webkit):
2262         (TestConverter.convert_testharness_paths):
2263         (TestConverter.convert_prefixed_properties):
2264         (TestConverter.scrub_unprefixed_props):
2265         (TestConverter.replace_tag):
2266         * Scripts/webkitpy/w3c/test_converter_unittest.py: Added.
2267         (TestConverterTest):
2268         (TestConverterTest.testLoadPrefixedPropList):
2269         (TestConverterTest.test_convertForWebkitNothingToConvert):
2270         (test_convertForWebkitHarnessOnly):
2271         (test_convertForWebkitPropsOnly):
2272         (test_convertForWebkitHarnessAndProps):
2273         (test_convertTestHarnessPaths):
2274         (test_convertPrefixedProperties):
2275         (verifyTestHarnessPaths):
2276         (verifyPrefixedProperties):
2277         (generateTestContent):
2278         * Scripts/webkitpy/w3c/test_importer.py: Added.
2279         (main):
2280         (parse_args):
2281         (validate_import_directory):
2282         (TestImporter):
2283         (TestImporter.__init__):
2284         (TestImporter.do_import):
2285         (TestImporter.get_changeset):
2286         (TestImporter.scan_source_directory):
2287         (TestImporter.import_tests):
2288         (TestImporter.setup_destination_directory):
2289         (TestImporter.get_test_status):
2290         (TestImporter.remove_deleted_files):
2291         (TestImporter.write_import_log):
2292         * Scripts/webkitpy/w3c/test_importer_unittest.py: Added.
2293         (TestImporterTest):
2294         (TestImporterTest.test_ImportDirWithNoTests):
2295         * Scripts/webkitpy/w3c/test_parser.py: Added.
2296         (TestParser):
2297         (TestParser.__init__):
2298         (TestParser.load_file):
2299         (TestParser.analyze_test):
2300         (TestParser.get_reftests):
2301         (TestParser.is_jstest):
2302         (TestParser.get_support_files):
2303         * Scripts/webkitpy/w3c/test_parser_unittest.py: Added.
2304         (TestParserTest):
2305         (TestParserTest.test_analyzeTestReftestOneMatch):
2306         (test_analyzeTestReftestMultipleMatches):
2307         (test_analyzeTestReftestMatchAndMismatch):
2308         (test_analyzeTestReftestWithRefSupportFiles):
2309         (test_analyzeJSTest):
2310         (test_analyzePixelTestAllTrue):
2311         (test_analyzePixelTestAllFalse):
2312         (test_analyzeNonHTMLFile):
2313
2314 2013-05-03  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2315
2316         Unreviewed. Update Viatcheslav Ostapenko's email in contributors.json.
2317
2318         * Scripts/webkitpy/common/config/contributors.json:
2319
2320 2013-05-02  Nico Weber  <thakis@chromium.org>
2321
2322         Remove a stale script file.
2323         https://bugs.webkit.org/show_bug.cgi?id=115521
2324
2325         Reviewed by Anders Carlsson.
2326
2327         This script was added in
2328         https://bugs.webkit.org/show_bug.cgi?id=17507, but it relies on the
2329         Bakefile system that was removed in
2330         https://bugs.webkit.org/show_bug.cgi?id=49983 . As a result, this
2331         script just asserts when it's run and is useless.
2332
2333         * Scripts/update-sources-list.py: Removed.
2334
2335 2013-05-01  Glenn Adams  <glenn@skynav.com>
2336
2337         [webkitpy] Need abstract base class for commands that analyze commit logs
2338         https://bugs.webkit.org/show_bug.cgi?id=115391
2339
2340         Reviewed by Benjamin Poulain.
2341
2342         Move commit log parsing functions into new abstract base class AbstractCommitLogCommand
2343         in preparation for adding two new commands that will reuse this functionality along with
2344         suggest-nominations. See https://bugs.webkit.org/show_bug.cgi?id=115387 and
2345         https://bugs.webkit.org/show_bug.cgi?id=115388.
2346
2347         No new tests as this patch does not change existing functionality or behavior.
2348
2349         * Scripts/webkitpy/tool/commands/suggestnominations.py:
2350         (AbstractCommitLogCommand): Add abstract base class for commands that analyze commit logs.
2351         (AbstractCommitLogCommand.__init__):
2352         (AbstractCommitLogCommand._init_options):
2353         (AbstractCommitLogCommand._parse_commit_message):
2354         (SuggestNominations): Move generic commit log parsing into new base class. Use new base class.
2355         (SuggestNominations.__init__):
2356         (SuggestNominations._init_options):
2357
2358 2013-05-01  Seokju Kwon  <seokju.kwon@gmail.com>
2359
2360         Web Inspector: Fix check-inspector-strings script and fix localized strings
2361         https://bugs.webkit.org/show_bug.cgi?id=115495
2362
2363         Reviewed by Joseph Pecoraro.
2364
2365         * Scripts/check-inspector-strings:
2366
2367 2013-05-01  Zan Dobersek  <zdobersek@igalia.com>
2368
2369         [TestWebKitAPI] <WebKit2/WebKit2_C.h> being included in GTK WK1-only builds
2370         https://bugs.webkit.org/show_bug.cgi?id=115470
2371
2372         Reviewed by Martin Robinson.
2373
2374         In the TestWebKitAPI's config.h header, only include the <WebKit2/WebKit2_C.h> header when
2375         not building either of the IOS, Windows or GTK-WK1 platforms.
2376
2377         Up until now the header was included for everything but the IOS and Windows platforms due to
2378         an incorrectly stated condition regarding the GTK platform.
2379
2380         * TestWebKitAPI/config.h:
2381
2382 2013-05-01  Zan Dobersek  <zdobersek@igalia.com>
2383
2384         [GTK] Split the forwarding headers stamp in the TestWebKitAPI GNUmakefile.am
2385         https://bugs.webkit.org/show_bug.cgi?id=115469
2386
2387         Reviewed by Martin Robinson.
2388
2389         Split the stamp-testwebkitapi-forwarding-headers into two stamps, one covering forwarding headers
2390         for the WebCore tests (under the Tests/WebCore directory) and the other covering forwarding headers
2391         for the WebKit2 tests and the injected bundle required by them.
2392
2393         This makes it possible for the WebCore tests to compile when the WebKit2 build is disabled, i.e. the WebCore
2394         tests shouldn't depend on the WebKit2 build (though the forwarding headers generation script is stored
2395         under the WebKit2 code).
2396
2397         The WebCore forwarding headers are generated by scanning only the files under the Tests/WebCore directory,
2398         while the WebKit2 forwarding headers generation should keep on scanning the complete root directory of the
2399         TestWebKitAPI subproject, though the target directory should be narrowed down if at all possible.
2400
2401         * TestWebKitAPI/GNUmakefile.am:
2402
2403 2013-04-30  Glenn Adams  <glenn@skynav.com>
2404
2405         Unreviewed. Add myself to watchlist entries.
2406
2407         * Scripts/webkitpy/common/config/watchlist:
2408
2409 2013-04-30  Glenn Adams  <glenn@skynav.com>
2410
2411         [webkitpy] suggest-nominations doesn't count all qualified patches
2412         https://bugs.webkit.org/show_bug.cgi?id=115285
2413
2414         Reviewed by Benjamin Poulain.
2415
2416         Fix commit analysis so that patches made by an existing committer are counted towards reviewer
2417         nomination. Improve commit log parsing.
2418
2419         * Scripts/webkitpy/tool/commands/suggestnominations.py:
2420         (CommitLogError):
2421         (CommitLogError.__init__):
2422         (CommitLogMissingReviewer):
2423         (CommitLogMissingReviewer.__init__):
2424         (SuggestNominations):
2425         (SuggestNominations.__init__):
2426         (SuggestNominations._recent_commit_messages):
2427         (SuggestNominations._author_name_from_email):
2428         (SuggestNominations._contributor_from_email):
2429         (SuggestNominations._parse_commit_message):
2430         (SuggestNominations._count_commit):
2431         (SuggestNominations._count_recent_patches):
2432         (SuggestNominations._collect_nominations):
2433         (SuggestNominations._print_nominations):
2434         (SuggestNominations.execute):
2435         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2436         (_make_options):
2437         (test_recent_commit_messages):
2438         (test_basic):
2439
2440 2013-04-30  Commit Queue  <rniwa@webkit.org>
2441
2442         Unreviewed, rolling out r149309.
2443         http://trac.webkit.org/changeset/149309
2444         https://bugs.webkit.org/show_bug.cgi?id=115430
2445
2446         The patch does not build on WK1-only builds of the GTK port
2447         (Requested by zdobersek on #webkit).
2448
2449         * TestWebKitAPI/GNUmakefile.am:
2450
2451 2013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2452
2453         Stop using "in" keyword in IDL files
2454         https://bugs.webkit.org/show_bug.cgi?id=115418
2455
2456         Reviewed by Kentaro Hara.
2457
2458         Remove "in" keyword from IDL files as this is no longer part of the Web
2459         IDL specification.
2460
2461         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
2462         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl:
2463         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl:
2464         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2465         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2466         * WebKitTestRunner/InjectedBundle/Bindings/GCController.idl:
2467         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2468         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
2469
2470 2013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2471
2472         [EFL] Enable scaled cursors
2473         https://bugs.webkit.org/show_bug.cgi?id=106242
2474
2475         Reviewed by Gyuyoung Kim.
2476
2477         Enable ENABLE_MOUSE_CURSOR_SCALE for EFL port.
2478
2479         * Scripts/webkitperl/FeatureList.pm:
2480
2481 2013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2482
2483         Replace "Optional" extended attribute by proper Web IDL "optional" keyword
2484         https://bugs.webkit.org/show_bug.cgi?id=115380
2485
2486         Reviewed by Kentaro Hara.
2487
2488         Replace WebKit-specific [Optional] extended attribute by Web IDL "optional"
2489         keyword.
2490
2491         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2492         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2493
2494 2013-04-30  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
2495
2496         Fix the USE(3D_GRAPHICS) build with the standard OpenGL on Windows
2497         https://bugs.webkit.org/show_bug.cgi?id=114684
2498
2499         Reviewed by Simon Hausmann.
2500
2501         Remove the ANGLE requirement for USE(3D_GRAPHICS).
2502         This enables WebKit2 in the build when using a "-opengl desktop" configured Qt.
2503
2504         * qmake/mkspecs/features/features.prf:
2505
2506 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
2507
2508         [GTK] Disable Shadow DOM feature
2509         https://bugs.webkit.org/show_bug.cgi?id=115374
2510
2511         Reviewed by Martin Robinson.
2512
2513         Disable the Shadow DOM feature on the GTK port, the feature is planned for removal.
2514
2515         * Scripts/webkitperl/FeatureList.pm:
2516
2517 2013-04-29  Glenn Adams  <glenn@skynav.com>
2518
2519         [webkitpy] Add missing contributor email addresses
2520         https://bugs.webkit.org/show_bug.cgi?id=115394
2521
2522         Reviewed by Ryosuke Niwa.
2523
2524         * Scripts/webkitpy/common/config/contributors.json:
2525
2526 2013-04-29  Alberto Garcia  <agarcia@igalia.com>
2527
2528         Remove all remaining Skia code
2529         https://bugs.webkit.org/show_bug.cgi?id=115263
2530
2531         Reviewed by Benjamin Poulain.
2532
2533         Remove all remaining references to Skia.
2534
2535         * Scripts/webkitdirs.pm:
2536         (blackberryCMakeArguments):
2537         * Scripts/webkitpy/common/config/contributionareas.py:
2538         * Scripts/webkitpy/common/config/watchlist:
2539
2540 2013-04-29  Seokju Kwon  <seokju.kwon@gmail.com>
2541
2542         Get rid of unused options in Tools/Scripts/webkit-build-directory
2543         https://bugs.webkit.org/show_bug.cgi?id=115383
2544
2545         Reviewed by Darin Adler.
2546
2547         * Scripts/webkit-build-directory:
2548
2549 2013-04-29  Alexey Proskuryakov  <ap@apple.com>
2550
2551         [WK2][Mac] Test with NetworkProcess enabled.
2552
2553         Fix the build for non-Mac.
2554
2555         * WebKitTestRunner/TestController.cpp:
2556         (WTR::TestController::initialize):
2557
2558 2013-04-29  Alexey Proskuryakov  <ap@apple.com>
2559
2560         [WK2][Mac] Test with NetworkProcess enabled.
2561
2562         Reviewed by Sam Weinig.
2563
2564         * WebKitTestRunner/TestController.cpp:
2565         (WTR::TestController::initialize):
2566
2567 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
2568
2569         [GTK] Set up the TestWebCore in TestWebKitAPI
2570         https://bugs.webkit.org/show_bug.cgi?id=115237
2571
2572         Reviewed by Gustavo Noronha Silva.
2573
2574         Set up the WebCore unit test program, consisting of the unit tests under the TestWebKitAPI/Tests/WebCore directory.
2575         Again the approach of specifying libtool libraries multiple times in the TestWebCore program's LDFLAGS is used as
2576         a workaround for the layer violations and circular dependencies between various static libraries. Linking against
2577         either libwebkitgtk or libwebkit2gtk shared libraries is avoided due to the unit tests covering WebCore, which
2578         shouldn't rely on neither of the two distributable libraries (hence the dirty workaround).
2579
2580         * TestWebKitAPI/GNUmakefile.am:
2581
2582 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
2583
2584         [GTK] Set up the TestJavaScriptCore in TestWebKitAPI
2585         https://bugs.webkit.org/show_bug.cgi?id=115236
2586
2587         Reviewed by Gustavo Noronha Silva.
2588
2589         Set up the TestJavaScriptCore unit test program, consisting of the unit tests
2590         under the TestWebKitAPI/Tests/JavaScriptCore directory.
2591
2592         * TestWebKitAPI/GNUmakefile.am:
2593
2594 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
2595
2596         [GTK] Export the COLLECT_NO_DEMANGLE variable on the builders
2597         https://bugs.webkit.org/show_bug.cgi?id=115323
2598
2599         Reviewed by Philippe Normand.
2600
2601         Export the COLLECT_NO_DEMANGLE environment variable on the GTK BuildBot builders.
2602         Its presence enforces linkers to output mangled symbols when reporting linking failures
2603         due to unresolved references. People trying to fix the build can then simply copy
2604         the printed mangled symbol into the symbols.filter file instead of doing a manual build
2605         or connecting to the builders to discover the mangled version of the missing symbol.
2606
2607         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
2608
2609 2013-04-28  Zan Dobersek  <zdobersek@igalia.com>
2610
2611         Remove Chromium code from Tools/BuildSlaveSupport
2612         https://bugs.webkit.org/show_bug.cgi?id=115325
2613
2614         Reviewed by Benjamin Poulain.
2615
2616         Remove the two Chromium-specific scripts and the Chromium-specific parts from the code
2617         covering archiving test results and built products.
2618
2619         * BuildSlaveSupport/built-product-archive:
2620         (archiveBuiltProduct):
2621         (extractBuiltProduct):
2622         * BuildSlaveSupport/chromium/output-android-device-status: Removed.
2623         * BuildSlaveSupport/chromium/remove-crash-logs: Removed.
2624         * BuildSlaveSupport/test-result-archive:
2625         (archiveTestResults):
2626
2627 2013-04-28  Seokju Kwon  <seokju.kwon@gmail.com>
2628
2629         Remove support for Chromium from webkitdirs.pm
2630         https://bugs.webkit.org/show_bug.cgi?id=115338
2631
2632         Reviewed by Darin Adler.
2633
2634         * Scripts/webkitdirs.pm:
2635         (determineBaseProductDir):
2636         (argumentsForConfiguration):
2637         (builtDylibPathForName):
2638         (determineIsQt):
2639         (isAppleWebKit):
2640
2641 2013-04-28  Zan Dobersek  <zdobersek@igalia.com>
2642
2643         Rename TestRunner's setAudioData to setAudioResult
2644         https://bugs.webkit.org/show_bug.cgi?id=115326
2645
2646         Reviewed by Darin Adler.
2647
2648         Rename the TestRunner's setAudioData method to setAudioResult. The new name better conveys the method's purpose
2649         than the previous one. The change is a simple rename, there's no change in the method's functionality. The
2650         affected tests are adjusted accordingly.
2651
2652         * DumpRenderTree/qt/TestRunnerQt.cpp:
2653         (TestRunnerQt::setAudioResult):
2654         * DumpRenderTree/qt/TestRunnerQt.h:
2655         (TestRunnerQt):
2656         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2657         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2658         (WTR::TestRunner::setAudioResult):
2659         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2660         (TestRunner):
2661
2662 2013-04-28  Zan Dobersek  <zdobersek@igalia.com>
2663
2664         [WKTR] Tests dumping audio data shouldn't dump pixels
2665         https://bugs.webkit.org/show_bug.cgi?id=115270
2666
2667         Reviewed by Benjamin Poulain.
2668
2669         Prevent dumping the pixel output when Web Audio tests are dumping output data
2670         as the testing output. Pixel output in these tests has no real meaning and is
2671         as such unnecessary.
2672
2673         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2674         (WTR::TestRunner::setAudioData):
2675
2676 2013-04-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2677
2678         [EFL] Unreviewed Intel bots fix after r149231.
2679
2680         * efl/jhbuild.modules: Disable the libxml Python bindings since the
2681         bots don't have Python's development files installed. libxml should
2682         detect this kind of thing better.
2683
2684 2013-04-26  Ryuan Choi  <ryuan.choi@samsung.com>
2685
2686         [EFL] Build break using jhbuild on ubuntu 13.04
2687         https://bugs.webkit.org/show_bug.cgi?id=115225
2688
2689         Reviewed by Gyuyoung Kim.
2690
2691         libxslt in Ubuntu 13.04 requires libxml 2.9.0 or higher and
2692         libxml 2.9.0 has a bug to make regression which r138422 mentioned.
2693         So this patch bumped libxml version to 2.9.1.
2694
2695         * efl/jhbuild.modules:
2696
2697 2013-04-26  Jeffrey Pfau  <jpfau@apple.com>
2698
2699         delete-stale-build-files does not clear .d files
2700         http://bugs.webkit.org/show_bug.cgi?id=115293
2701
2702         Reviewed by Ryosuke Niwa.
2703
2704         * BuildSlaveSupport/delete-stale-build-files:
2705         (main): Add .d to the file type list
2706
2707 2013-04-26  Roger Fong  <roger_fong@apple.com>
2708
2709         Make Apple Windows VS2010 build results into and get dependencies from __32 suffixed folders.
2710         Make the DebugSuffix configuration use _debug dependencies.
2711
2712         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2713         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeApple.props:
2714         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
2715         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebug.props:
2716         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
2717         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
2718         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherCommon.props:
2719         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherDebug.props:
2720         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props:
2721         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props:
2722         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd:
2723         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props:
2724         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props:
2725         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
2726         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2727         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props:
2728         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebug.props:
2729         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props:
2730         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2731         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherCommon.props:
2732         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherDebug.props:
2733         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props:
2734         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props:
2735         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props:
2736         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props:
2737         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props:
2738         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.def:
2739         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2740         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
2741         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
2742         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginDebug.props:
2743         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props:
2744         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props:
2745         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin_debug.def: Removed.
2746         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2747         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
2748         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
2749         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebug.props:
2750         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
2751         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props:
2752         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props:
2753         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
2754         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
2755         * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props:
2756         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props:
2757         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
2758         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props:
2759         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props:
2760         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props:
2761         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props:
2762         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props:
2763         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props:
2764         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
2765         * win/AssembleBuildLogs/AssembleLogs.cmd:
2766         * win/record-memory/record-memory.vcxproj:
2767         * win/record-memory/record-memoryDebug.props:
2768         * win/record-memory/record-memoryDebugWinCairo.props:
2769         * win/record-memory/record-memoryProduction.props:
2770         * win/record-memory/record-memoryRelease.props:
2771         * win/record-memory/record-memoryReleaseWinCairo.props:
2772
2773 2013-04-26  Zan Dobersek  <zdobersek@igalia.com>
2774
2775         [GTK] Clean up the TestWebKitAPI GNUmakefile.am
2776         https://bugs.webkit.org/show_bug.cgi?id=115233
2777
2778         Reviewed by Martin Robinson.
2779
2780         Specify unconditional, non-installable program targets in one declaration. Only conditionally specify
2781         WebKit2-specific targets, not the complete target setups (i.e. targets' sources, cppflags listings etc.).
2782         Add missing unit test source files to the TestWTF program, namely HashSet.cpp and MetaAllocator.cpp.
2783         Specify the TestWTF program's CXXFLAGS to be the same as the global cxxflags as the source files need to
2784         be compiled with the -fno-rtti flag that's present in the global_cxxflags variable.
2785
2786         * TestWebKitAPI/GNUmakefile.am:
2787
2788 2013-04-25  Andy Estes  <aestes@apple.com>
2789
2790         [WebKit2] Loading a resource from a custom protocol in a synchronous XHR times out
2791         https://bugs.webkit.org/show_bug.cgi?id=115223
2792
2793         Reviewed by Darin Adler.
2794
2795         Added an API test.
2796
2797         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
2798         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm: Added.
2799         (TestWebKitAPI::TEST): Tested that a synchronous XHR does not time out
2800         when it loads a request with a custom protocol.
2801         * TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Added.
2802         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm: Moved the
2803         NSURLProtocol subclass to TestProtocol.{h, mm} and did some
2804         miscellaneous cleanup.
2805         * TestWebKitAPI/mac/TestProtocol.h: Copied from Source/WebKit2/WebProcess/WebProcessSupplement.h.
2806         * TestWebKitAPI/mac/TestProtocol.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm.
2807         (+[TestProtocol canInitWithRequest:]):
2808         (+[TestProtocol canonicalRequestForRequest:]):
2809         (+[TestProtocol requestIsCacheEquivalent:toRequest:]):
2810         (+[TestProtocol scheme]):
2811         (-[TestProtocol startLoading]):
2812         (-[TestProtocol stopLoading]):
2813
2814 2013-04-26  Martin Robinson  <mrobinson@igalia.com>
2815
2816         Remove the remaining Skia #ifdefs
2817         https://bugs.webkit.org/show_bug.cgi?id=114886
2818
2819         Reviewed by Benjamin Poulain.
2820
2821         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
2822         (createBitmapContextFromWebView): Remove Skia #ifdef references.
2823
2824 2013-04-26  Mary Wu  <mary.wu@torchmobile.com.cn>
2825
2826         [BlackBerry] Clean up load interface in WebPage
2827         https://bugs.webkit.org/show_bug.cgi?id=113267
2828
2829         Reviewed by Rob Buis.
2830
2831         Update DumpRenderTree with change of load() interface in WebPage.
2832         RIM Bug# 315535, internally reviewed by Joe Mason.
2833
2834         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2835         (BlackBerry::WebKit::DumpRenderTree::runTest):
2836
2837 2013-04-26  Zan Dobersek  <zdobersek@igalia.com>
2838
2839         Remove the HeapGraphSerializer unit test
2840         https://bugs.webkit.org/show_bug.cgi?id=115231
2841
2842         Reviewed by Andreas Kling.
2843
2844         Remove the HeapGraphSerializer unit test. The code it was testing was removed in r148921,
2845         specifically the Source/WebCore/inspector/HeapGraphSerializer.(cpp|h) files.
2846
2847         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Removed.
2848
2849 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
2850
2851         Remove support for Chromium from build/update scripts
2852         https://bugs.webkit.org/show_bug.cgi?id=115218
2853
2854         Reviewed by Darin Adler.
2855
2856         * Scripts/build-webkit:
2857         (writeCongrats):
2858         * Scripts/update-webkit:
2859
2860 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
2861
2862         Remove support for Chromium from api-test
2863         https://bugs.webkit.org/show_bug.cgi?id=115211
2864
2865         Reviewed by Dirk Pranke.
2866
2867         * Scripts/build-api-tests:
2868         * Scripts/run-api-tests:
2869         (isSupportedPlatform):
2870
2871 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
2872
2873         Get rid of Chromium in build-dumprendertree
2874         https://bugs.webkit.org/show_bug.cgi?id=115212
2875
2876         Reviewed by Dirk Pranke.
2877
2878         * Scripts/build-dumprendertree:
2879
2880 2013-04-25  Alexey Proskuryakov  <ap@apple.com>
2881
2882         Pass relatedPage when creating a page in WebKitTestRunner
2883         https://bugs.webkit.org/show_bug.cgi?id=115206
2884
2885         Reviewed by Geoffrey Garen.
2886
2887         To make sure that window.open() opens in the same process even when using multiple processes.
2888
2889         * WebKitTestRunner/PlatformWebView.h:
2890         * WebKitTestRunner/TestController.cpp:
2891         (WTR::TestController::createOtherPage):
2892         (WTR::TestController::createWebViewWithOptions):
2893         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2894         (WTR::PlatformWebView::PlatformWebView):
2895         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2896         (WTR::PlatformWebView::PlatformWebView):
2897         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2898         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useTiledDrawing:]):
2899         (WTR::PlatformWebView::PlatformWebView):
2900         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2901         (WTR::PlatformWebView::PlatformWebView):
2902         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2903         (WTR::PlatformWebView::PlatformWebView):
2904
2905 2013-04-25  Ryosuke Niwa  <rniwa@webkit.org>
2906
2907         Fix autocompletion for Benjamin. The Bugzilla email address must come first.
2908
2909         * Scripts/webkitpy/common/config/contributors.json:
2910
2911 2013-04-25  Ryosuke Niwa  <rniwa@webkit.org>
2912
2913         Build fix. Forgot to merge args.
2914
2915         * Scripts/webkitpy/tool/bot/irc_command.py:
2916         (Hi.execute):
2917
2918 2013-04-25  Ryosuke Niwa  <rniwa@webkit.org>
2919
2920         webkitbot should recognize its own nickname in greetings.
2921         https://bugs.webkit.org/show_bug.cgi?id=115196
2922
2923         Reviewed by Andreas Kling.
2924
2925         Make webkitbot recognize other forms of its nick. Also be tolerant of spaces between the nick and !.
2926
2927         * Scripts/webkitpy/tool/bot/irc_command.py:
2928         (Hi.execute):
2929
2930 2013-04-25  Xavier Castano  <xcastanho@igalia.com>
2931
2932         [GTK] Tools/gtk/install-dependencies added ragel dependency
2933         https://bugs.webkit.org/show_bug.cgi?id=115163
2934
2935         Reviewed by Xan Lopez.
2936
2937         The install-dependencies script was missing a dependency on ragel
2938         which is expected when building HarfBuzz.
2939
2940         * gtk/install-dependencies: Added a dependency on ragel for both
2941         apt and yum.
2942
2943 2013-04-25  Eduardo Lima Mitev  <elima@igalia.com>
2944
2945         [GTK] Remove pango from optional jhbuild dependencies
2946         https://bugs.webkit.org/show_bug.cgi?id=115162
2947
2948         Reviewed by Martin Robinson.
2949
2950         Pango is not needed since revision r148293 that lowers the pango
2951         dependency to 1.30, which is available in most distributions.
2952
2953         * gtk/jhbuild-optional.modules: Removes description of pango module.
2954
2955 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
2956
2957         Remove Chromium-specific cases from FeatureList.pm
2958         https://bugs.webkit.org/show_bug.cgi?id=115169
2959
2960         Reviewed by Andreas Kling.
2961
2962         * Scripts/webkitperl/FeatureList.pm:
2963
2964 2013-04-24  Seokju Kwon  <seokju.kwon@gmail.com>
2965
2966         Remove checking chromium from run-webkit-tests
2967         https://bugs.webkit.org/show_bug.cgi?id=115139
2968
2969         Reviewed by Benjamin Poulain.
2970
2971         * Scripts/run-webkit-tests:
2972         (useNewRunWebKitTests):
2973
2974 2013-04-24  Simon Fraser  <simon.fraser@apple.com>
2975
2976         Pixel tests in SVG are all broken in WK2
2977         https://bugs.webkit.org/show_bug.cgi?id=114218
2978
2979         Reviewed by Darin Adler.
2980
2981         Window snapshots in WebKitTestRunner on Mac are window-sized
2982         (800x600), which is wrong for the W3C SVG tests that require a
2983         480x360 snapshot.
2984
2985         Fix by resizing the window, as well as the web view in
2986         PlatformWebView::resizeTo() so that window snapshots are correctly
2987         sized.
2988
2989         Also do some drive-by cleanup of the window size constants in both
2990         DRT and WTR to remove magic numbers, and make the code more similar.
2991
2992         * DumpRenderTree/TestRunner.cpp:
2993         (TestRunner::setShouldPaintBrokenImage):
2994         * DumpRenderTree/TestRunner.h:
2995         * DumpRenderTree/efl/DumpRenderTree.cpp:
2996         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2997         (webInspectorShowWindow):
2998         * DumpRenderTree/mac/DumpRenderTree.mm:
2999         (createWebViewAndOffscreenWindow):
3000         (sizeWebViewForCurrentTest):
3001         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3002         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3003         (createPagedBitmapContext):
3004         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3005         (DumpRenderTree::DumpRenderTree):
3006         (DumpRenderTree::open):
3007         * DumpRenderTree/qt/TestRunnerQt.cpp:
3008         * DumpRenderTree/qt/TestRunnerQt.h:
3009         * DumpRenderTree/win/DumpRenderTree.cpp:
3010         (sizeWebViewForCurrentTest):
3011         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
3012         * WebKitTestRunner/TestController.cpp:
3013         (WTR::TestController::resetStateToConsistentValues):
3014         * WebKitTestRunner/TestController.h:
3015         * WebKitTestRunner/TestInvocation.cpp:
3016         (WTR::sizeWebViewForCurrentTest):
3017         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3018         (WTR::PlatformWebView::PlatformWebView):
3019         (WTR::PlatformWebView::resizeTo):
3020
3021 2013-04-24  Byungwoo Lee  <bw80.lee@samsung.com>
3022
3023         [EFL] Fix build error after r148963.
3024         https://bugs.webkit.org/show_bug.cgi?id=115126
3025
3026         Reviewed by Laszlo Gombos.
3027
3028         Generate forwarding headers for 'CoordinatedGraphics' to generate WKView.h
3029
3030         * TestWebKitAPI/PlatformEfl.cmake:
3031
3032 2013-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3033
3034         [GTK] Use stamp files for generate-forwarding-headers makefile rules
3035         https://bugs.webkit.org/show_bug.cgi?id=115118
3036
3037         Reviewed by Martin Robinson.
3038
3039         Use a stamp file for the TestWebKitAPI and WebKitTestRunner
3040         forwarding generator rules and don't call it for soup since there
3041         aren't soup directories in TestWebKitAPI and WebKitTestRunner.
3042
3043         * TestWebKitAPI/GNUmakefile.am:
3044         * WebKitTestRunner/GNUmakefile.am:
3045
3046 2013-04-24  Simon Pena  <simon.pena@samsung.com>
3047
3048         [GTK] Update build dependencies
3049         https://bugs.webkit.org/show_bug.cgi?id=115111
3050
3051         Reviewed by Martin Robinson.
3052
3053         The install-dependencies script was missing a dependency on EGL,
3054         which is expected when building Cairo.
3055
3056         * gtk/install-dependencies: Added a dependency on libegl1-mesa
3057         for both apt and yum.
3058
3059 2013-04-24  Seokju Kwon  <seokju.kwon@gmail.com>
3060
3061         Remove the Chromium-specific helper from run_webkit_tests.py
3062         https://bugs.webkit.org/show_bug.cgi?id=114996
3063
3064         Reviewed by Dirk Pranke.
3065
3066         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3067         (parse_args):
3068
3069 2013-04-24  Sergio Correia  <sergio.correia@openbossa.org>
3070
3071         [EFL][WK2]: Fix WKViewClientWebProcessCallbacks WK2 API test
3072         https://bugs.webkit.org/show_bug.cgi?id=114850
3073
3074         Reviewed by Andreas Kling.
3075
3076         Revision r148312 fixed WebPageProxy cleanup and also changed the process
3077         termination semantics when requested by the user so that a client is not
3078         notified of a crash anymore, since there was no crash anyway.
3079
3080         That change broke WKViewClientWebProcessCallbacks WK2 API test, since it
3081         relied on being notified of a crash after calling WKPageTerminate(). As
3082         a result of not being notified of such non-existent crash, the test would
3083         timeout right after making the terminate call.
3084
3085         This patch adds an InjectedBundle to be used for simulating a crash, by
3086         calling abort() upon receiving a "Crash" message, and thus we are able to
3087         keep testing the crash callback.
3088
3089         This patch also re-enables the WKViewClientWebProcessCallbacks test, which
3090         had been disabled in revisions r148858 and r148855, since it was failing.
3091
3092         * TestWebKitAPI/PlatformEfl.cmake:
3093         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
3094         (TestWebKitAPI::TEST):
3095         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp: Added.
3096         (TestWebKitAPI):
3097         (WKViewClientWebProcessCallbacksTest):
3098         (TestWebKitAPI::WKViewClientWebProcessCallbacksTest::WKViewClientWebProcessCallbacksTest):
3099         (TestWebKitAPI::WKViewClientWebProcessCallbacksTest::didReceiveMessage):
3100
3101 2013-04-24  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3102
3103         [EFL][WK2] WebKitTestRunner failures due to IconDatabase assertions
3104         https://bugs.webkit.org/show_bug.cgi?id=115095
3105
3106         Reviewed by Antonio Gomes.
3107
3108         Use different subfolders under DumpRenderTree Temp folder for every
3109         functionality (icon database, cache, localstorage, ...). This makes
3110         sure there is no conflict between the functionalities.
3111
3112         In EFL's case, libsoup cache was causing problems for the icon
3113         database if sharing the same folder.
3114
3115         * WebKitTestRunner/TestController.cpp:
3116         (WTR::TestController::initialize):
3117
3118 == Rolled over to ChangeLog-2013-04-24 ==