[Qt] Set WebCore imagedecoders as default and add fallback to QImageDecoder
[WebKit-https.git] / Tools / ChangeLog
1 2012-05-04  Zoltan Horvath  <zoltan@webkit.org>
2
3         [Qt] Set WebCore imagedecoders as default and add fallback to QImageDecoder
4         https://bugs.webkit.org/show_bug.cgi?id=80400
5
6         Remove WTF_USE_QT_IMAGE_DECODER macro.
7
8         Reviewed by Simon Hausmann.
9
10         * qmake/mkspecs/features/features.prf:
11
12 2012-05-03  Christophe Dumez  <christophe.dumez@intel.com>
13
14         [EFL] DRT should obey layoutTestController's addURLToRedirect()
15         https://bugs.webkit.org/show_bug.cgi?id=82722
16
17         Reviewed by Maciej Stachowiak.
18
19         Implement support for layoutTestController's addURLToRedirect()
20         in EFL's DRT so that it redirects properly when indicated.
21
22         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
23         (DumpRenderTreeChrome::onWillSendRequest):
24
25 2012-05-03  Christophe Dumez  <christophe.dumez@intel.com>
26
27         [EFL] DRT should support LayoutTestController's willSendRequestReturnsNullOnRedirect()
28         https://bugs.webkit.org/show_bug.cgi?id=82704
29
30         Reviewed by Antonio Gomes.
31
32         EFL's DRT needs to obey LayoutTestController's
33         willSendRequestReturnsNullOnRedirect().
34
35         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
36         (DumpRenderTreeChrome::onWillSendRequest):
37
38 2012-05-03  Raphael Kubo da Costa  <rakuco@webkit.org>
39
40         git-add-reviewer: Do not put the bug title and its URL in the same line in the commit message.
41         https://bugs.webkit.org/show_bug.cgi?id=85570
42
43         Reviewed by Adam Roben.
44
45         The standard format of commit messages and ChangeLog entries has a
46         short summary in the first line, followed by the bug URL in
47         Bugzilla. Passing "%s" in the pretty format line to git-rev-list
48         merges these two lines into a single one separated by a space
49         character, which is not what we want.
50
51         Since "%s%n%n%b" is in practice "%B" (raw message), use it
52         instead, as the first two lines do not end up being merged
53         together.
54
55         * Scripts/git-add-reviewer:
56         (writeCommitMessageToFile):
57
58 2012-05-03  Ojan Vafai  <ojan@chromium.org>
59
60         Improve UI for garden-o-matic examine view when there are fewer than 5 tests.
61         https://bugs.webkit.org/show_bug.cgi?id=85566
62
63         Reviewed by Adam Barth.
64
65         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
66         (.):
67         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
68         (.):
69         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
70
71 2012-05-03  Raphael Kubo da Costa  <rakuco@webkit.org>
72
73         webkitpy: Recognize FreeBSD as a valid platform.
74         https://bugs.webkit.org/show_bug.cgi?id=81467
75
76         Reviewed by Adam Barth.
77
78         Add PlatformInfo.is_freebsd() so that trying to use webkit-patch
79         on FreeBSD does not raise an "unrecognized platform" exception.
80
81         Most of this patch contains some unit tests for the mentioned
82         method, as currently platform-specific code is needed only on
83         Windows.
84
85         * Scripts/webkitpy/common/system/platforminfo.py:
86         (PlatformInfo.__init__):
87         (PlatformInfo.is_freebsd):
88         (PlatformInfo._determine_os_name):
89         * Scripts/webkitpy/common/system/platforminfo_mock.py:
90         (MockPlatformInfo.is_freebsd):
91         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
92         (fake_platform):
93         (fake_platform.FakePlatformModule.release):
94         (TestPlatformInfo.test_real_code):
95         (TestPlatformInfo.test_os_name_and_wrappers):
96         (TestPlatformInfo.test_os_version):
97         (TestPlatformInfo.test_display_name):
98         (TestPlatformInfo.test_total_bytes_memory):
99         (TestPlatformInfo.test_free_bytes_memory):
100         * Scripts/webkitpy/layout_tests/port/factory.py:
101         (PortFactory._default_port):
102
103 2012-05-03  Ojan Vafai  <ojan@chromium.org>
104
105         Make the table headers white-space:nowrap. This decreases the vertical size,
106         which makes for more minimal embedding in garden-o-matic.
107
108         * TestResultServer/static-dashboards/flakiness_dashboard_tests.css:
109         (.table-header-content *):
110
111 2012-05-03  Eric Seidel  <eric@webkit.org>
112
113         Split build-webkit's feature option list off into its own module in preparation for autogeneration
114         https://bugs.webkit.org/show_bug.cgi?id=85548
115
116         Reviewed by Daniel Bates.
117
118         My Perl-fu is very weak.  This moves the feature option list off into a separate module
119         file so that I can easily autogenerate just that file with the fancy new generate-feature-files command.
120         It's a bit odd to have an array which we return out to build-webkit to modify, but it turns out
121         not to matter.  Also, build-webkit doesn't actually use any of the variables we're using to
122         store the results from the option parse, so those end up inaccessible from build-webkit (except by reference)
123         which is actually cleaner.  Callers can't assume that they would get a new array every time, but someone
124         with more Perl-fu than I could create something fancier than this if we need in the future.
125
126         * Scripts/build-webkit:
127         * Scripts/webkitperl/FeatureList.pm: Added.
128         (getFeatureOptionList):
129
130 2012-05-03  Dirk Pranke  <dpranke@chromium.org>
131
132         REGRESSION: run-webkit-tests failing on Chromium Mac
133         https://bugs.webkit.org/show_bug.cgi?id=85459
134
135         Unreviewed, build fix.
136
137         Turns out select doesn't throw IOErrors, it has it's own kind of
138         error :(. Trap that instead.
139
140         * Scripts/webkitpy/layout_tests/port/server_process.py:
141         (ServerProcess._wait_for_data_and_update_buffers_using_select):
142
143 2012-05-03  Raphael Kubo da Costa  <rakuco@webkit.org>
144
145         [CMake] Rewrite FindCairo.cmake.
146         https://bugs.webkit.org/show_bug.cgi?id=84895
147
148         Reviewed by Daniel Bates.
149
150         The old approach relied on pkg-config for finding Cairo (which
151         introduced a dependency on pkg-config that could be avoided), used
152         the LibFindMacros code that we should probably remove in the
153         future and did not use the FindPackageHandleStandardArguments
154         module.
155
156         Change all that by rewriting the module.
157         - Use the pkg-config output optionally instead of requiring it
158         like LibFindMacros did.
159         - Remove the implicit dependency on FreeType which often found it
160         the wrong way via pkg-config and without considering
161         CMAKE_PREFIX_PATH.
162         - Retrieve the Cairo version by looking at cairo-version.h instead
163         of relying on pkg-config. It requires some additional code for
164         checking if the desired version has been found, but that will not
165         be needed once we start depending on CMake 2.8.3 or later.
166
167         The only downside is that FPHSA sets <UPPERCASED_NAME>_FOUND
168         instead of <Name>_FOUND, and to keep things consistent
169         Cairo_LIBRARIES and Cairo_INCLUDE_DIRS have become CAIRO_LIBRARIES
170         and CAIRO_INCLUDE_DIRS.
171
172         * DumpRenderTree/efl/CMakeLists.txt: Use CAIRO_FOO instead of
173         Cairo_FOO.
174         * EWebLauncher/CMakeLists.txt: Ditto.
175
176 2012-05-03  Ojan Vafai  <ojan@chromium.org>
177
178         Fix modifier and bug sorting on the flakiness dashboard
179         https://bugs.webkit.org/show_bug.cgi?id=85554
180
181         Reviewed by Dirk Pranke.
182
183         The sorting assumes that the column header name matches a field
184         in the testResults object and uses that field for sorting.
185         Filter the bugs out of the modifiers list and put them in a bugs field
186         and only put the non-bug modifiers in the modifiers list.
187
188         * TestResultServer/static-dashboards/flakiness_dashboard.js:
189         (populateExpectationsData):
190         (htmlForSingleTestRow):
191         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
192
193 2012-05-03  Ojan Vafai  <ojan@chromium.org>
194
195         Fix some state resetting when running unittests. HtmlForSingleTestRow
196         was flaky.
197
198         * TestResultServer/static-dashboards/flakiness_dashboard.js:
199         (htmlForSingleTestRow):
200         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
201         (resetGlobals):
202
203 2012-05-03  Raphael Kubo da Costa  <rakuco@webkit.org>
204
205         webkitpy: Use PlatformInfo wherever possible in the User class.
206         https://bugs.webkit.org/show_bug.cgi?id=85549
207
208         Reviewed by Dirk Pranke.
209
210         Instead of relying on sys.platform to detect whether the current
211         platform is a Mac, use the PlatformInfo class instead.
212
213         * Scripts/webkitpy/common/system/user.py:
214         (User.__init__):
215         (User.edit_changelog):
216
217 2012-05-03  Ojan Vafai  <ojan@chromium.org>
218
219         Remove the percent failed column from the flakiness dashboard
220         https://bugs.webkit.org/show_bug.cgi?id=85552
221
222         Reviewed by Dirk Pranke.
223
224         This column isn't useful enough to justify the visual noise.
225
226         * TestResultServer/static-dashboards/flakiness_dashboard.js:
227         (processMissingAndExtraExpectations):
228         (tableHeaders):
229         (htmlForSingleTestRow):
230         (sortTests):
231         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
232         (test):
233
234 2012-05-03  Eric Seidel  <eric@webkit.org>
235
236         --coverage should not not use the "feature" options system in build-webkit, similarly remove special-casing for WTF_URL
237         https://bugs.webkit.org/show_bug.cgi?id=85542
238
239         Reviewed by Daniel Bates.
240
241         Remove these last two odd-men-out, so that we can generate the default feature options
242         for build-webkit using the new generate-feature-files command.
243         The Mac build system has some special casing for ENABLE_ defines which gets them
244         defined as -D on the build command, even though initially they start out as
245         environment variables ENABLE_FOO = ENABLE_FOO.  The Feature options in build-webkit
246         depend on this support, but it doesn't work for WTF_USE_ defines like WTF_USE_WTF_URL.
247         I'm told that WTF_URL is not actively being worked on, so just removing it for now.
248         It should probably come back to life as an ENABLE_, or build-webkit or the Xcode projects
249         should be made generically smarter about these USE_WTF defines.
250         (There is still WTF_USE_TILED_BACKING_STORE in the feature list, but it only seems
251         used by Qt.  If someone tried build-webkit --tiled-backing-store on Mac today it
252         would not work!)
253
254         * Scripts/build-webkit:
255
256 2012-05-03  Eric Seidel  <eric@webkit.org>
257
258         Remove the last bits of Leopard support from our perl scripts
259         https://bugs.webkit.org/show_bug.cgi?id=85545
260
261         Reviewed by Daniel Bates.
262
263         Chromium still supports Leopard (for a little while yet), but AppleMacWebKit dropped
264         Leopard support several months ago.  Remove the last bits of isLeopard() branching
265         in our Perl scripts, since no one is using this (Chromium has never used this Perl code).
266
267         * Scripts/build-webkit:
268         * Scripts/old-run-webkit-tests:
269         (countAndPrintLeaks):
270         (captureSavedCrashLog):
271         * Scripts/webkitdirs.pm:
272         (determineArchitecture):
273         (argumentsForRunAndDebugMacWebKitApp):
274
275 2012-05-03  Ojan Vafai  <ojan@chromium.org>
276
277         [Chromium] Don't show the WebKit Linux ASAN bot on the flakiness dashboard.
278         https://bugs.webkit.org/show_bug.cgi?id=85551
279
280         Reviewed by Dirk Pranke.
281
282         It's not uploading results and in the short term we don't plan to have it start.
283
284         * TestResultServer/static-dashboards/builders.js:
285         (isChromiumWebkitTipOfTreeTestRunner):
286         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
287
288 2012-05-03  Ojan Vafai  <ojan@chromium.org>
289
290         Show the test name in the dashboard if showChrome==false and we're showing multiple tests
291         https://bugs.webkit.org/show_bug.cgi?id=85243
292
293         Reviewed by Dirk Pranke.
294
295         This happens for cases where a test name matches multiple tests.
296         In practice, this only happens for virtual test suites (e.g. the canvas tests).
297
298         * TestResultServer/static-dashboards/flakiness_dashboard.js:
299         (htmlForIndividualTestOnAllBuildersWithChrome):
300         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
301         (testHtmlForIndividualTestOnAllBuildersWithChromeNonexistant):
302         (testHtmlForIndividualTestOnAllBuildersWithChrome):
303         (testHtmlForIndividualTestOnAllBuildersWithChromeWebkitMaster):
304         (testHtmlForIndividualTests):
305
306 2012-05-03  Ojan Vafai  <ojan@chromium.org>
307
308         Port the flakiness dashboard unittests to qunit
309         https://bugs.webkit.org/show_bug.cgi?id=85544
310
311         Reviewed by Adam Barth.
312
313         * TestResultServer/static-dashboards/dashboard_base.js:
314         (appendJSONScriptElements):
315         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
316         (resetGlobals):
317         (runExpectationsTest):
318         (test):
319         * TestResultServer/static-dashboards/run-unittests.html: Added.
320
321 2012-05-03  Raphael Kubo da Costa  <rakuco@webkit.org>
322
323         webkitpy: Remove check for readline on Mac.
324         https://bugs.webkit.org/show_bug.cgi?id=85547
325
326         Reviewed by Eric Seidel.
327
328         Python 2.5 is not supported by the WebKit project anymore, and
329         Python's readline documentation does not mention the module not
330         being available in the supported versions.
331
332         * Scripts/webkitpy/common/system/user.py:
333
334 2012-05-03  Thiago Marcos P. Santos  <thiago.santos@intel.com>
335
336         [NRWT] Run performance tests with lock
337         https://bugs.webkit.org/show_bug.cgi?id=78628
338
339         Reviewed by Tony Chang.
340
341         Locking performance tests (like we do for http tests) will force them
342         to run in serial. This reduces the load of the machine when running perf
343         tests and minimizes the chances of the tests to fail, specially
344         timeouts.
345
346         * Scripts/webkitpy/layout_tests/controllers/manager.py:
347         (Manager.__init__):
348         (Manager._is_perf_test):
349         (Manager._test_requires_lock):
350         * Scripts/webkitpy/layout_tests/port/http_lock.py:
351
352 2012-05-03  Dirk Pranke  <dpranke@chromium.org>
353
354         Attempt to fix a crash on SL ...
355
356         Unreviewed, build fix.
357
358         It looks like we may be getting an IOError raised during
359         select() on chromium mac, and that error isn't being caught.
360         Pushing it into the try/catch block will hopefully catch this
361         and allow us to see why the subprocess is crashing.
362
363         * Scripts/webkitpy/layout_tests/port/server_process.py:
364         (ServerProcess._wait_for_data_and_update_buffers_using_select):
365
366 2012-05-02  Jon Honeycutt  <jhoneycutt@apple.com>
367
368         WebFrameLoaderClient::dispatchWillSendSubmitEvent() needs to be
369         implemented for WebKit2
370         https://bugs.webkit.org/show_bug.cgi?id=84304
371
372         Reviewed by Jessie Berlin.
373
374         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
375         Added new files to project.
376
377         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent.cpp: Added.
378         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
379         Look for the "DidReceiveWillSendSubmitEvent" message. The message body
380         will be the dictionary of form control names and values passed to the
381         injected bundle's willSendSubmitEvent handler; look for the pairs
382         "textField" -> "text field" and "passwordField" -> "password field".
383         Check that "hiddenField" is not included.
384         (TestWebKitAPI::setInjectedBundleClient):
385         (TestWebKitAPI::TEST):
386
387         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp: Added.
388         (TestWebKitAPI::willSendSubmitEvent):
389         Post a message to the TestWebKitAPI process with the dictionary of form
390         control names and values that we received.
391         (TestWebKitAPI::WillSendSubmitEventTest::WillSendSubmitEventTest):
392         (TestWebKitAPI::WillSendSubmitEventTest::didCreatePage):
393         Set up the page's form client.
394
395         * TestWebKitAPI/Tests/WebKit2/auto-submitting-form.html: Added.
396
397 2012-05-03  Eric Seidel  <eric@webkit.org>
398
399         Remove dead code from build-webkit for working around old XCode dependency bug
400         https://bugs.webkit.org/show_bug.cgi?id=85535
401
402         Reviewed by Adam Barth.
403
404         Xcode used to have a bug whereby it didn't notice if you changed the #defines
405         passed on the command line to xcodebuild.  I wrote code to work around this
406         while bringing up SVG support 5-6 years ago.  I think we can finally remove this
407         code from build-webkit, since SVG is the only feature flag to ever use it
408         (modern in-progress features like MathML don't seem to be using the support)
409         an I suspect the XCode bug has long been fixed.
410
411         * Scripts/build-webkit:
412         * Scripts/webkitperl/features.pm:
413
414 2012-05-03  Andy Estes  <aestes@apple.com>
415
416         InjectedBundleControllerMac.mm needs to include config.h
417         https://bugs.webkit.org/show_bug.cgi?id=85531
418
419         Reviewed by Andreas Kling.
420
421         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
422
423 2012-05-03  Raphael Kubo da Costa  <rakuco@webkit.org>
424
425         webkitpy: Use PlatformInfo whenever possible in server_process.py.
426         https://bugs.webkit.org/show_bug.cgi?id=85516
427
428         Reviewed by Eric Seidel.
429
430         Eliminate direct access to sys.platform wherever possible by using
431         PlatformInfo.is_win() instead.
432
433         * Scripts/webkitpy/layout_tests/port/server_process.py:
434         (ServerProcess.__init__): Remove the executive parameter as it was
435         not passed by any caller, obtain a SystemHost from port_obj
436         instead.
437         (ServerProcess._log): Style, remove extra empty line.
438         (ServerProcess._start):
439         (ServerProcess.stop):
440         (ServerProcess.kill):
441         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
442         (TrivialMockPort.__init__): Create a MockSystemHost used by
443         ServerProcess.
444         (TestServerProcess.test_broken_pipe): Test different platforms.
445
446 2012-05-03  Thiago Marcos P. Santos  <thiago.santos@intel.com>
447
448         webkitpy: Style checker broken when committing a PNG
449         https://bugs.webkit.org/show_bug.cgi?id=85504
450
451         Reviewed by Dirk Pranke.
452
453         * Scripts/webkitpy/style/checkers/png.py:
454         (PNGChecker.__init__):
455
456 2012-05-03  Philippe Normand  <pnormand@igalia.com>
457
458         Unreviewed, fix another call to join(), similar to the ones landed
459         in r115975.
460
461         * Scripts/webkitdirs.pm:
462         (jhbuildConfigurationChanged):
463
464 2012-05-03  Raphael Kubo da Costa  <rakuco@webkit.org>
465
466         webkitpy: Remove sys.platform accesses in CrashLogs.
467         https://bugs.webkit.org/show_bug.cgi?id=85436
468
469         Reviewed by Dirk Pranke.
470
471         Instead of directly checking for sys.platform == 'darwin', use a
472         SystemHost and call PlatformInfo.is_mac().
473
474         * Scripts/webkitpy/common/system/crashlogs.py:
475         (CrashLogs.__init__):
476         (CrashLogs.find_newest_log):
477         (CrashLogs._log_directory_darwin):
478         (CrashLogs._find_newest_log_darwin):
479         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
480         (CrashLogsTest.test_find_log_darwin):
481         * Scripts/webkitpy/layout_tests/port/mac.py:
482         (MacPort._get_crash_log):
483         * Scripts/webkitpy/layout_tests/port/test.py:
484         (TestDriver.run_test):
485         * Scripts/webkitpy/tool/commands/queries.py:
486         (execute):
487
488 2012-05-03  Philippe Normand  <pnormand@igalia.com>
489
490         [GTK] join() is wrongly used in webkitdirs.pm since r115532
491         https://bugs.webkit.org/show_bug.cgi?id=85501
492
493         Reviewed by Martin Robinson.
494
495         * Scripts/webkitdirs.pm:
496         (getJhbuildPath):
497         (buildAutotoolsProject):
498
499 2012-05-03  Zan Dobersek  <zandobersek@gmail.com>
500
501         [Gtk] ImageDiff crashes when it can't open a display
502         https://bugs.webkit.org/show_bug.cgi?id=85476
503
504         Reviewed by Martin Robinson.
505
506         Replace gdk_init() initialization call with the g_type_init()
507         call. GdkPixbufLoader doesn't actually need the current call to be
508         made and this change will also remove crashes when ImageDiff
509         is started in an environment without a DISPLAY env.
510
511         * DumpRenderTree/gtk/ImageDiff.cpp:
512         (main):
513
514 2012-05-03  Zan Dobersek  <zandobersek@gmail.com>
515
516         ImageDiff should be run inside a properly established environment
517         https://bugs.webkit.org/show_bug.cgi?id=85292
518
519         Reviewed by Martin Robinson.
520
521         When creating the ImageDiff server process, pass along a freshly-set-up environment
522         in which the process should be executed in.
523
524         * Scripts/webkitpy/layout_tests/port/webkit.py:
525         (WebKitPort._start_image_diff_process):
526
527 2012-05-03  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
528
529         [Qt] Allow the web process and WTR to be paused on startup
530
531         Makes it easier to debug the web process or run-webkit-tests -2, as you
532         have ample time to attach gdb to the process.
533
534         Reviewed by Simon Hausmann.
535
536         * Scripts/webkitpy/layout_tests/port/qt.py:
537         (QtPort.setup_environ_for_server):
538         * WebKitTestRunner/qt/main.cpp:
539         (main):
540
541 2012-05-03  Csaba Osztrogonác  <ossy@webkit.org>
542
543         Password protect "Stop build" button
544         https://bugs.webkit.org/show_bug.cgi?id=81982
545
546         Reviewed by Ryosuke Niwa.
547
548         Only authenticated users should be able to use stopBuild, stopAllBuilds, cancelPendingBuild
549         features to prevent killing builds on build.webkit.org by SPAM bots.
550
551         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
552
553 2012-05-03  Dongwoo Im  <dw.im@samsung.com>
554
555         [DRT] Remove the name of parameter, visibility, from the setPageVisibility stub implementations.
556         https://bugs.webkit.org/show_bug.cgi?id=85468
557
558         Reviewed by Nikolas Zimmermann.
559
560         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
561         (LayoutTestController::setPageVisibility): Remove the name of parameter, visibility.
562         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
563         (LayoutTestController::setPageVisibility): Remove the name of parameter, visibility.
564         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
565         (LayoutTestController::setPageVisibility): Remove the name of parameter, visibility.
566         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
567         (LayoutTestController::setPageVisibility): Remove the name of parameter, visibility.
568         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
569         (LayoutTestController::setPageVisibility): Remove the name of parameter, visibility.
570
571 2012-05-03  Stephanie Lewis  <slewis@apple.com>
572
573         https://bugs.webkit.org/show_bug.cgi?id=85450 unbounded growth of JSDOMWindowShells loading pages in the same window
574         <rdar://problem/11320059> REGRESSION (r115083): PLT3 shows linear memory growth and gets slower with each run
575
576         Reviewed by Brady Eidson.
577
578         The API added for DOMWindowExtension, didCreateGlobalObjectForFrame, would create a global object
579         for every world, even those that did not need the callback.  This had the side effect of creating a
580         JSDOMWindowShell that the associated world didn't necessarily know to clean up.  Instead of creating
581         unnecessary objects change the API to globalObjectIsAvailableForFrame and do not pass the global object
582         in the API.  The object can be accessed later by those worlds which require it.
583
584         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
585         (TestWebKitAPI):
586         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
587         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
588         (TestWebKitAPI):
589         (DOMWindowExtensionBasic):
590         (TestWebKitAPI::DOMWindowExtensionBasic::didCreatePage):
591         (TestWebKitAPI::DOMWindowExtensionBasic::globalObjectIsAvailableForFrame):
592         (TestWebKitAPI::globalObjectIsAvailableForFrameCallback):
593
594 2012-05-03  Nikolas Zimmermann  <nzimmermann@rim.com>
595
596         Not reviewed. Fix mac build, it was missing setPageVisibility/resetPageVisibility stub implementations.
597
598         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
599         (LayoutTestController::resetPageVisibility):
600         (LayoutTestController::setPageVisibility):
601
602 2012-05-02  Alexander Færøy  <ahf@0x90.dk>
603
604         Rename deviceDPI to devicePixelRatio
605         https://bugs.webkit.org/show_bug.cgi?id=85049
606
607         Reviewed by Kenneth Rohde Christiansen.
608
609         Use 1.5 as device pixel ratio for the Qt MiniBrowser.
610
611         * MiniBrowser/qt/qml/BrowserWindow.qml:
612
613 2012-05-03  Dongwoo Im  <dw.im@samsung.com>
614
615         [EFL][DRT] Implement the LayoutTestController's methods related to the Page Visibility API.
616         https://bugs.webkit.org/show_bug.cgi?id=85347
617
618         Reviewed by Nikolas Zimmermann.
619
620         * DumpRenderTree/LayoutTestController.h:
621         (LayoutTestController):
622         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
623         (LayoutTestController::resetPageVisibility): Not implemented.
624         (LayoutTestController::setPageVisibility): Not implemented.
625         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
626         (LayoutTestController::resetPageVisibility): Reset the page visibility.
627         (LayoutTestController::setPageVisibility): Set the page visibility.
628         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
629         (LayoutTestController::resetPageVisibility): Not implemented.
630         (LayoutTestController::setPageVisibility): Not implemented.
631         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
632         (LayoutTestController::resetPageVisibility): Not implemented.
633         (LayoutTestController::setPageVisibility): Not implemented.
634         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
635         (LayoutTestController::resetPageVisibility): Not implemented.
636         (LayoutTestController::setPageVisibility): Not implemented.
637         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
638         (LayoutTestController::resetPageVisibility): Not implemented.
639         (LayoutTestController::setPageVisibility): Not implemented.
640
641 2012-05-02  Sheriff Bot  <webkit.review.bot@gmail.com>
642
643         Unreviewed, rolling out r115918.
644         http://trac.webkit.org/changeset/115918
645         https://bugs.webkit.org/show_bug.cgi?id=85452
646
647         "Broke test-webkitpy on Apple Lion bots" (Requested by estes
648         on #webkit).
649
650         * Scripts/webkitpy/common/system/crashlogs.py:
651         (CrashLogs.__init__):
652         (CrashLogs.find_newest_log):
653         (CrashLogs._log_directory_darwin):
654         (CrashLogs._find_newest_log_darwin):
655         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
656         (CrashLogsTest.test_find_log_darwin):
657         * Scripts/webkitpy/layout_tests/port/mac.py:
658         (MacPort._get_crash_log):
659         * Scripts/webkitpy/layout_tests/port/test.py:
660         (TestDriver.run_test):
661         * Scripts/webkitpy/tool/commands/queries.py:
662         (execute):
663
664 2012-05-02  Raphael Kubo da Costa  <rakuco@webkit.org>
665
666         webkitpy: Remove sys.platform accesses in CrashLogs.
667         https://bugs.webkit.org/show_bug.cgi?id=85436
668
669         Reviewed by Dirk Pranke.
670
671         Instead of directly checking for sys.platform == 'darwin', use a
672         SystemHost and call PlatformInfo.is_mac().
673
674         * Scripts/webkitpy/common/system/crashlogs.py:
675         (CrashLogs.__init__):
676         (CrashLogs.find_newest_log):
677         (CrashLogs._log_directory_darwin):
678         (CrashLogs._find_newest_log_darwin):
679         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
680         (CrashLogsTest.test_find_log_darwin):
681         * Scripts/webkitpy/layout_tests/port/mac.py:
682         (MacPort._get_crash_log):
683         * Scripts/webkitpy/layout_tests/port/test.py:
684         (TestDriver.run_test):
685         * Scripts/webkitpy/tool/commands/queries.py:
686         (execute):
687
688 2012-05-02  Raphael Kubo da Costa  <rakuco@webkit.org>
689
690         webkitpy: Special-case win32 calls in file_lock and executive.
691         https://bugs.webkit.org/show_bug.cgi?id=85431
692
693         Reviewed by Dirk Pranke.
694
695         Simplify accesses to sys.platform by only checking if sys.platform
696         is "win32" and removing explicit checks for the else case.
697
698         * Scripts/webkitpy/common/system/executive.py:
699         (Executive.check_running_pid):
700         * Scripts/webkitpy/common/system/file_lock.py:
701         (FileLock._create_lock):
702         (FileLock._remove_lock):
703
704 2012-05-02  Ojan Vafai  <ojan@chromium.org>
705
706         Remove pink from flakiness dashboard
707         https://bugs.webkit.org/show_bug.cgi?id=85422
708
709         Reviewed by Dirk Pranke.
710
711         The pink indicates that the test doesn't match it's listing in test_expectations.txt.
712         In practice, this just added noise and confused people.
713
714         * TestResultServer/static-dashboards/flakiness_dashboard.js:
715         (htmlForSingleTestRow):
716         (showLegend):
717         * TestResultServer/static-dashboards/flakiness_dashboard_tests.css:
718         (#legend-contents *):
719         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
720         (testHtmlForSingleTestRow):
721
722 2012-05-02  Gustavo Noronha Silva  <gns@gnome.org>
723
724         Unreviewed. Fix mistake I committed when applying review comments.
725
726         * jhbuild/jhbuild-wrapper: dependencies_path was getting 'Root'
727         appended to its path, so jhbuild itself was being cloned and
728         installed in the wrong place when using WEBKITOUTPUTDIR.
729
730 2012-05-02  Dirk Pranke  <dpranke@chromium.org>
731
732         nrwt: make ServerProcess work on chromium win
733         https://bugs.webkit.org/show_bug.cgi?id=85333
734
735         Reviewed by Ojan Vafai.
736
737         This change implements a poor man's select() that will
738         slow-spin doing non-blocking reads on the stdout and stderr
739         named pipes connecting the worker to the driver. Seems to work
740         and I have yet to see much overhead or ill effects but it
741         probably needs more testing.
742
743         * Scripts/webkitpy/layout_tests/port/chromium.py:
744         (ChromiumDriver.__init__):
745         * Scripts/webkitpy/layout_tests/port/server_process.py:
746         (ServerProcess._start):
747         (ServerProcess._wait_for_data_and_update_buffers_using_select):
748         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
749         (ServerProcess):
750         (ServerProcess._non_blocking_read_win32):
751         (ServerProcess._read):
752         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
753         (TestServerProcess.test_basic): Added.
754
755 2012-05-02  Raphael Kubo da Costa  <rakuco@webkit.org>
756
757         webkitpy: Use a SystemHost instead of PlatformInfo in the PNG checker.
758         https://bugs.webkit.org/show_bug.cgi?id=85426
759
760         Reviewed by Dirk Pranke.
761
762         r115880 replaced the direct use of sys.platform with a
763         PlatformInfo object. Dirk Pranke later told me SystemHost objects
764         should be preferred, as nothing out of webkitpy.common.system
765         should create its own PlatformInfo instances.
766
767         * Scripts/webkitpy/common/system/systemhost_mock.py:
768         (MockSystemHost.__init__): Make it possible to specify a custom
769         filesystem object.
770         * Scripts/webkitpy/style/checkers/png.py:
771         (PNGChecker.__init__): Accept a host object instead of a
772         filesystem one, which is now obtained from host.
773         (PNGChecker._config_file_path): Retrieve PlatformInfo from
774         SystemHost.
775         * Scripts/webkitpy/style/checkers/png_unittest.py:
776         (PNGCheckerTest.test_init): Adjust calls to PNGChecker to its new
777         constructor signature.
778         (PNGCheckerTest.test_check): Ditto.
779
780 2012-05-02  Raphael Kubo da Costa  <rakuco@webkit.org>
781
782         webkitpy: Remove direct checks for sys.platform == 'darwin' in the layout test classes.
783         https://bugs.webkit.org/show_bug.cgi?id=85424
784
785         Reviewed by Tony Chang.
786
787         We should reduce direct usage of sys.platform in webkitpy and use
788         PlatformInfo instead.
789
790         * Scripts/webkitpy/layout_tests/servers/http_server.py:
791         (Lighttpd._prepare_config): Call PlatformInfo.is_mac() instead of
792         checking for 'darwin' directly.
793         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
794         (HttpServerBase.__init__): Ditto.
795
796 2012-05-02  Raphael Kubo da Costa  <rakuco@webkit.org>
797
798         webkitpy: Remove direct sys.platform usage in run_webkit_tests_integrationtest.
799         https://bugs.webkit.org/show_bug.cgi?id=85419
800
801         Reviewed by Dirk Pranke.
802
803         As pointed out by Dirk Pranke, a PlatformInfo is not supposed to
804         be created directly, we should should a SystemHost instead.
805
806         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
807         (MainTest.setUp): Create a SystemHost and obtain the PlatformInfo
808         object from it instead of creating PlatformInfo directly.
809
810 2012-05-02  Raphael Kubo da Costa  <rakuco@webkit.org>
811
812         webkitpy: Remove direct sys.platform usage in run_webkit_tests_integrationtest.
813         https://bugs.webkit.org/show_bug.cgi?id=85419
814
815         Rubber-stamped by Dirk Pranke.
816
817         Follow-up patch to r115887 which fixes some capitalization problems
818         pointed out in comments 2 and 4.
819
820         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
821         (MainTest.setUp):
822         (MainTest.test_child_processes_2):
823         (MainTest.test_child_processes_min):
824         (MainTest.test_exception_raised):
825         (MainTest.test_keyboard_interrupt):
826
827 2012-05-02  Raphael Kubo da Costa  <rakuco@webkit.org>
828
829         webkitpy: Remove direct sys.platform usage in run_webkit_tests_integrationtest.
830         https://bugs.webkit.org/show_bug.cgi?id=85419
831
832         Reviewed by Dirk Pranke.
833
834         Another part of the work towards replacing direct sys.platform
835         usage with PlatformInfo.
836
837         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
838         (MainTest.setUp): Move the setting of SHOULD_TEST_PROCESSES
839         here. Even though it is costlier, unittest.setUpClass was
840         introduced in Python 2.7.
841         (MainTest.test_child_processes_2): Use self.SHOULD_TEST_PROCESSES.
842         (MainTest.test_child_processes_min): Ditto.
843         (MainTest.test_exception_raised): Ditto.
844         (MainTest.test_keyboard_interrupt): Ditto.
845         (MainTest.test_crash_log): Check for PlatformInfo.is_mac().
846         (MainTest.test_web_process_crash_log): Ditto, and remove duplicate
847         check at the end.
848         (MainTest.test_no_http_tests): Remove check for (cygwin && Python
849         2.5.2), as we only support Python 2.6+.
850
851 2012-05-02  Raphael Kubo da Costa  <rakuco@webkit.org>
852
853         webkitpy: Remove direct sys.platform usage in the PNG checker.
854         https://bugs.webkit.org/show_bug.cgi?id=85407
855
856         Reviewed by Tony Chang.
857
858         Work towards replacing direct sys.platform usage with
859         PlatformInfo.
860
861         * Scripts/webkitpy/common/system/platforminfo_mock.py:
862         (MockPlatformInfo.__init__): Accept os_name and os_version as
863         arguments.
864         * Scripts/webkitpy/style/checkers/png.py:
865         (PNGChecker.__init__): Create a PlatformInfo object instead of
866         using sys.platform when needed.
867         (PNGChecker._config_file_path): Check for the current platform via
868         PlatformInfo.
869         * Scripts/webkitpy/style/checkers/png_unittest.py:
870         (PNGCheckerTest.test_check): Update tests after the changes above.
871
872 2012-05-02  Raphael Kubo da Costa  <rakuco@webkit.org>
873
874         [watchlist] Update watchlist rules for EFL-related patches.
875         http://bugs.webkit.org/show_bug.cgi?id=85160
876
877         Reviewed by Eric Seidel.
878
879         * Scripts/webkitpy/common/config/watchlist: Monitor
880         Source/WTF/wtf/efl and LayoutTests/platform/efl as well.
881
882 2012-05-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
883
884         Revert r115191 - "Make the web view's url property follow the active url"
885
886         It uncovered/caused issues in the icon-implementation that can't be
887         easily fixed, so rolling out instead.
888
889         https://bugs.webkit.org/show_bug.cgi?id=77554
890
891         Rubber-stamped by Simon Hausmann.
892
893         * MiniBrowser/qt/qml/BrowserWindow.qml:
894         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
895         (TestWebKitAPI::TEST):
896
897 2012-05-02  Zan Dobersek  <zandobersek@gmail.com>
898
899         Reftest mismatches are providing undefined diff percent in results.html
900         https://bugs.webkit.org/show_bug.cgi?id=85283
901
902         Reviewed by Ojan Vafai.
903
904         When writing test results for a reftest mismatch, also take into account the
905         difference percent that is produced when generating image diff. This value is
906         then used when creating test results in the form of dictionaries, stored under
907         the 'image_diff_percent' key. It ultimately ends up in JSON results data,
908         providing additional information about the reftest difference.
909
910         * Scripts/webkitpy/layout_tests/controllers/manager.py:
911         (interpret_test_failures): Store the diff percent for reftest failure under the
912         'image_diff_percent' key.
913         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
914         (write_test_result): Also set the new diff_percent attribute of the reftest
915         mismatch failure to the value of the difference percent ImageDiff outputs.
916         * Scripts/webkitpy/layout_tests/models/test_failures.py:
917         (FailureReftestMismatch.__init__): Add the new diff_percent attribute with the
918         default value of None.
919         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
920         (EndToEndTest.test_reftest_with_two_notrefs): Update the test case expected results.
921
922 2012-05-02  Terry Anderson  <tdanderson@chromium.org>
923
924         Addition of a contributor to committers.py
925         https://bugs.webkit.org/show_bug.cgi?id=85324
926
927         Reviewed by Unreviewed.
928
929         * Scripts/webkitpy/common/config/committers.py:
930
931 2012-05-02  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
932
933         [EFL] EFL's LayoutTestController overridePreference implementation
934         https://bugs.webkit.org/show_bug.cgi?id=83007
935
936         Reviewed by Antonio Gomes.
937
938         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
939         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
940         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
941         (toBool): aux function converting JSStringRef to bool
942         (toInt): aux function converting JSStringRef to int
943         (LayoutTestController::overridePreference): added implementation
944
945 2012-05-01  Raphael Kubo da Costa  <rakuco@webkit.org>
946
947         webkitpy: Fix sys.platform check in find_files_unittest.
948         https://bugs.webkit.org/show_bug.cgi?id=85339
949
950         Reviewed by Ryosuke Niwa.
951
952         Follow-up to r101618 -- 'win' is not a valid sys.platform value,
953         'win32' should be used instead. The check always returned false
954         due to this, so assert_normalize() was never called.
955
956         * Scripts/webkitpy/common/find_files_unittest.py:
957         (TestWinNormalize.test_win): Add the missing import for the
958         FileSystem class and fix the sys.platform check.
959
960 2012-05-02  Zan Dobersek  <zandobersek@gmail.com>
961
962         [GTK] drag&drop related failures
963         https://bugs.webkit.org/show_bug.cgi?id=84675
964
965         Reviewed by Philippe Normand.
966
967         Rather than checking options to see whether we're running pixel tests
968         the pixel_tests argument passed to GtkDriver._start should be used as
969         it also covers cases when pixel tests should be run because of testing
970         reftests. This again creates different Xvfb processes with proper
971         display IDs for a worker that's performing both ordinary and pixel
972         tests, as was the case before changes made in r114788.
973
974         * Scripts/webkitpy/layout_tests/port/gtk.py:
975         (GtkDriver._start):
976
977 2012-05-02  Simon Hausmann  <simon.hausmann@nokia.com>
978
979         [Qt] Enable device orientation/motion with Qt 5
980
981         Reviewed by Tor Arne Vestbø.
982
983         Enable device orientation/motion features with Qt 5 if Qt Sensors is available.
984
985         * qmake/mkspecs/features/features.prf:
986
987 2012-05-01  Raphael Kubo da Costa  <rakuco@webkit.org>
988
989         webkitpy: Remove unused platform imports.
990         https://bugs.webkit.org/show_bug.cgi?id=85341
991
992         Reviewed by Eric Seidel.
993
994         Remove a few uses of `import platform' which were either rendered
995         unneeded after r105931 or were never needed at all.
996
997         * Scripts/webkitpy/common/system/executive.py:
998         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
999
1000 2012-05-01  Terry Anderson  <tdanderson@chromium.org>
1001
1002         [chromium] Accept four parameters when dispatching a WebInputEvent::GestureTap in chromium DRT eventSender
1003         https://bugs.webkit.org/show_bug.cgi?id=85289
1004
1005         Reviewed by Eric Seidel.
1006
1007         * DumpRenderTree/chromium/EventSender.cpp:
1008         (EventSender::gestureEvent):
1009             This change will allow for testing of WK85101. Currently
1010             no tests use the extra parameters deltaX and deltaY. Added
1011             a check for the size of |arguments|.
1012
1013 2012-05-01  Eric Seidel  <eric@webkit.org>
1014
1015         Add myself to the watchlist to watch all rendering changes, as well as sort the watchers in the list
1016         https://bugs.webkit.org/show_bug.cgi?id=85305
1017
1018         Reviewed by Adam Barth.
1019
1020         * Scripts/webkitpy/common/config/watchlist:
1021
1022 2012-05-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1023
1024         Unreviewed, rolling out r115735.
1025         http://trac.webkit.org/changeset/115735
1026         https://bugs.webkit.org/show_bug.cgi?id=85314
1027
1028         cause two tests to crash due to an ASSERTION failure
1029         (Requested by zhenyao on #webkit).
1030
1031         * DumpRenderTree/chromium/EventSender.cpp:
1032         (EventSender::gestureEvent):
1033
1034 2012-05-01  Terry Anderson  <tdanderson@chromium.org>
1035
1036         [chromium] Accept four parameters when dispatching a WebInputEvent::GestureTap in chromium DRT eventSender
1037         https://bugs.webkit.org/show_bug.cgi?id=85289
1038
1039         Reviewed by Eric Seidel.
1040
1041         * DumpRenderTree/chromium/EventSender.cpp:
1042         (EventSender::gestureEvent):
1043             This change will allow for testing of WK85101. Currently no tests use the extra
1044             parameters deltaX and deltaY.
1045
1046 2012-05-01  Zan Dobersek  <zandobersek@gmail.com>
1047
1048         Print out stderr output of ImageDiff if it is present
1049         https://bugs.webkit.org/show_bug.cgi?id=85285
1050
1051         Reviewed by Philippe Normand.
1052
1053         Log the stderr output of ImageDiff as a warning if present. This is
1054         especially helpful when ImageDiff crashes and stderr data might contain
1055         relevant information about what caused the crash.
1056
1057         * Scripts/webkitpy/layout_tests/port/webkit.py:
1058         (WebKitPort._read_image_diff):
1059
1060 2012-05-01  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1061
1062         [Qt] Add an experimental extension to set the min. contents width
1063         https://bugs.webkit.org/show_bug.cgi?id=85281
1064
1065         Reviewed by Antonio Gomes.
1066
1067         * MiniBrowser/qt/qml/BrowserWindow.qml:
1068
1069         Set the value of preferredMinimumContentsWidth to 980.
1070
1071 2012-04-30  Ojan Vafai  <ojan@chromium.org>
1072
1073         Fix tests to not depend on the actual list of builders at build.chromium.org.
1074
1075         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1076         (testHtmlForIndividualTestOnAllBuildersWithChrome):
1077         (testHtmlForIndividualTestOnAllBuildersWithChromeWebkitMaster):
1078
1079 2012-04-29  Sam Weinig  <sam@webkit.org>
1080
1081         Remove BlobBuilder
1082         https://bugs.webkit.org/show_bug.cgi?id=84036
1083
1084         Reviewed by Anders Carlsson.
1085
1086         * Scripts/build-webkit:
1087         * qmake/mkspecs/features/features.prf:
1088         Make exposing the WebKitBlobBuilder JS object conditional on a new
1089         ENABLE_LEGACY_WEBKIT_BLOB_BUILDER flag. Don't enable this for the Mac,
1090         but do for everyone else.
1091
1092 2012-04-30  Amruth Raj Padmanabhuni  <amruthraj@motorola.com>
1093
1094         [GTK] Add glib as a dependency to build glib-networking
1095         https://bugs.webkit.org/show_bug.cgi?id=85181
1096
1097         Reviewed by Martin Robinson.
1098
1099         * gtk/jhbuild.modules:
1100
1101 2012-04-30  Alexis Menard  <alexis.menard@openbossa.org>
1102
1103         Move myself to reviewers.
1104
1105         Reviewed by Andreas Kling.
1106
1107         * Scripts/webkitpy/common/config/committers.py:
1108
1109 2012-04-30  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1110
1111         Unreviewed, move myself to reviewers
1112
1113         * Scripts/webkitpy/common/config/committers.py:
1114
1115 2012-04-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1116
1117         Unreviewed. Fix make distcheck.
1118
1119         * TestWebKitAPI/GNUmakefile.am: Add missing headers to compilation
1120         and resources to EXTRA_DIST.
1121
1122 2012-04-30  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1123
1124         [GTK] DRT support for layoutTestController.removeOriginAccessWhitelistEntry
1125         https://bugs.webkit.org/show_bug.cgi?id=85156
1126
1127         Reviewed by Martin Robinson.
1128
1129         Add missing implementation removeOriginAccessWhitelistEntry to
1130         GTK's LayoutTestController.
1131
1132         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1133         (LayoutTestController::removeOriginAccessWhitelistEntry):
1134
1135 2012-04-29  Maciej Stachowiak  <mjs@apple.com>
1136
1137         REGRESSION: On Lion, run-webkit-tests changes the display color profile even when not running pixel tests
1138         https://bugs.webkit.org/show_bug.cgi?id=81729
1139
1140         Reviewed by Dan Bernstein.
1141
1142         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1143         (Manager._set_up_run): Only launch LayoutTestHelper when running pixel tests.
1144
1145 2012-04-29  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1146
1147         [GTK] DRT needs an implementation of layoutTestController.setDomainRelaxationForbiddenForURLScheme
1148         https://bugs.webkit.org/show_bug.cgi?id=85131
1149
1150         Reviewed by Martin Robinson.
1151
1152         Add missing implementation setDomainRelaxationForbiddenForURLScheme to
1153         GTK's LayoutTestController.
1154
1155         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1156         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
1157
1158 2012-04-28  Sam Weinig  <sam@webkit.org>
1159
1160         Smooth scrolling needs a new key
1161         <rdar://problem/11331632>
1162
1163         Reviewed by Dan Bernstein.
1164
1165         * DumpRenderTree/mac/DumpRenderTree.mm:
1166         (resetDefaultsToConsistentValues):
1167         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
1168         (TestWebKitAPI::InjectedBundleController::platformInitialize):
1169         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1170         (WTR::InjectedBundle::platformInitialize):
1171         Update for new key.
1172
1173 2012-04-28  Zan Dobersek  <zandobersek@gmail.com>
1174
1175         [WK2] http/tests/navigation/anchor-frames-gbk.html fails
1176         https://bugs.webkit.org/show_bug.cgi?id=76896
1177
1178         Reviewed by Darin Adler.
1179
1180         Only dump as text if currently dumping render tree. This ensures that
1181         calling dumpAsText in a test with dumpChildFramesAsText already being
1182         called doesn't override the first decision, possibly making tests fail.
1183
1184         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1185         (WTR::LayoutTestController::dumpAsText):
1186
1187 2012-04-28  Dan Winship  <danw@gnome.org>
1188
1189         Unreviewed; Add me to the SoupNetwork watchlist
1190
1191         * Scripts/webkitpy/common/config/watchlist:
1192
1193 2012-04-27  Gustavo Noronha Silva  <gns@gnome.org>
1194
1195         [GTK] jhbuild cloning is not following WEBKITOUTPUTDIR.
1196         https://bugs.webkit.org/show_bug.cgi?id=76161
1197
1198         Reviewed by Martin Robinson.
1199
1200         * Scripts/webkitdirs.pm:
1201         (getJhbuildPath): New method to obtain the jhbuild base directory,
1202         using the product base directory
1203         (jhbuildConfigurationChanged): Use the new method
1204         (buildAutotoolsProject): Ditto.
1205         * efl/jhbuildrc: Use WEBKITOUTPUTDIR when calculating the path.
1206         * gtk/jhbuildrc: Ditto.
1207         * jhbuild/jhbuild-wrapper: Ditto.
1208
1209 2012-04-27  Scott Graham  <scottmg@chromium.org>
1210
1211         [chromium] make case of npTestNetscapePlugIn.dll match case in copy rule
1212         https://bugs.webkit.org/show_bug.cgi?id=85083
1213
1214         Reviewed by Dirk Pranke.
1215
1216         Make output product_name for npTestNetscapePlugIn.dll match the case
1217         of the copy_TestNetscapePlugIn rule. This is required for ninja, which
1218         is more particular about case matching in rules than the VS build.
1219
1220         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1221
1222 2012-04-27  Dirk Pranke  <dpranke@chromium.org>
1223
1224         [chromium] use "drt-style" output, not "test-shell-style" output, on mac and linux DRT
1225         https://bugs.webkit.org/show_bug.cgi?id=84917
1226
1227         Unreviewed, build fix.
1228
1229         Reland the change in r115453 with a fix for chromium win.
1230         The logic in ChromiumDriver was busted on windows, causing DRT
1231         to get launched without the --test-shell flag.
1232
1233         * Scripts/webkitpy/layout_tests/port/chromium.py:
1234         (ChromiumDriver):
1235         (ChromiumDriver.__init__):
1236         (ChromiumDriver._wrapper_options):
1237         (ChromiumDriver.cmd_line):
1238         (ChromiumDriver._start):
1239         (ChromiumDriver.has_crashed):
1240         (ChromiumDriver.run_test):
1241         (ChromiumDriver.stop):
1242         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1243         (ChromiumDriverTest.setUp):
1244         (ChromiumDriverTest.test_stop):
1245         (ChromiumDriverTest.test_two_drivers.MockDriver.__init__):
1246         (ChromiumDriverTest.test_two_drivers):
1247
1248 2012-04-27  Peter Beverloo  <peter@chromium.org>
1249
1250         Add John Grabowski as a non-committer to committers.py
1251         https://bugs.webkit.org/show_bug.cgi?id=85080
1252
1253         Reviewed by Dirk Pranke.
1254
1255         He's being CC'ed often enough because of his involvement in the Chromium
1256         side of Chrome for Android upstreaming.
1257
1258         * Scripts/webkitpy/common/config/committers.py:
1259           add jrg@chromium.org
1260
1261 2012-04-27  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
1262
1263         [Qt] Fix minimal build.
1264         https://bugs.webkit.org/show_bug.cgi?id=85045
1265
1266         Reviewed by Tor Arne Vestbø.
1267
1268         Do not set conflicting values of ENABLE_XSLT.
1269
1270         * qmake/mkspecs/features/features.prf:
1271
1272 2012-04-27  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
1273
1274         [EFL][DRT] EFL should sanitize pulseaudio module configuration too
1275         https://bugs.webkit.org/show_bug.cgi?id=85047
1276
1277         Reviewed by Dirk Pranke.
1278
1279         PulseAudio test setup sanitization shared between EFL and GTK.
1280
1281         * Scripts/webkitpy/layout_tests/port/efl.py:
1282         (EflPort):
1283         (EflPort.setup_test_run):
1284         (EflPort.clean_up_test_run):
1285         * Scripts/webkitpy/layout_tests/port/gtk.py:
1286         (GtkPort): Moving pulseaudio unload/restore out to shared class.
1287         * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer.py: Added.
1288         (PulseAudioSanitizer):
1289         (PulseAudioSanitizer._unload_pulseaudio_module):
1290         (PulseAudioSanitizer._restore_pulseaudio_module):
1291
1292 2012-04-27  Dirk Pranke  <dpranke@chromium.org>
1293
1294         Unreviewed, revert r115453 - broke chromium win bots
1295
1296         * Scripts/webkitpy/layout_tests/port/chromium.py:
1297         (ChromiumPort._path_to_image_diff):
1298         (ChromiumDriver):
1299         (ChromiumDriver.__init__):
1300         (ChromiumDriver._wrapper_options):
1301         (ChromiumDriver.cmd_line):
1302         (ChromiumDriver.stop):
1303         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1304         (ChromiumDriverTest.setUp):
1305         (ChromiumDriverTest.test_stop):
1306         (ChromiumDriverTest.test_two_drivers):
1307         (ChromiumDriverTest.test_two_drivers.MockDriver.__init__):
1308
1309 2012-04-27  Ryosuke Niwa  <rniwa@webkit.org>
1310
1311         Chromium Windows Perf bots timeout due to not output
1312         https://bugs.webkit.org/show_bug.cgi?id=84940
1313
1314         Reviewed by Dirk Pranke.
1315
1316         Dirk and I investigated the issue on the bot but we couldn't figure out what is going wrong.
1317         Since we run-perf-tests don't need any of fancy feature printer provides, just use python's
1318         built-in logging module instead. Printing out to stdout and stderr seem to work so hopefully
1319         this will fix the issue on the bot.
1320
1321         * Scripts/run-perf-tests:
1322         * Scripts/webkitpy/performance_tests/perftest.py:
1323         (PerfTest.run):
1324         (PerfTest.run_failed):
1325         (PerfTest.parse_output):
1326         (PerfTest.output_statistics):
1327         (ChromiumStylePerfTest.parse_output):
1328         (PageLoadingPerfTest.run):
1329         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1330         (MainTest.test_parse_output):
1331         (MainTest.test_parse_output_with_failing_line):
1332         (TestPageLoadingPerfTest):
1333         (TestPageLoadingPerfTest.test_run):
1334         (TestPageLoadingPerfTest.test_run_with_bad_output):
1335         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1336         (PerfTestsRunner.__init__):
1337         (PerfTestsRunner._parse_args):
1338         (PerfTestsRunner.run):
1339         (PerfTestsRunner._upload_json):
1340         (PerfTestsRunner._print_status):
1341         (PerfTestsRunner._run_tests_set):
1342         (PerfTestsRunner._run_single_test):
1343         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1344         (create_runner):
1345         (test_run_test_set):
1346         (test_run_test_set_kills_drt_per_run):
1347         (test_run_test_pause_before_testing):
1348         (test_run_test_set_for_parser_tests):
1349         (test_run_test_set_with_json_output):
1350         (test_run_test_set_with_json_source):
1351         (test_run_test_set_with_multiple_repositories):
1352         (test_upload_json):
1353         (test_parse_args):
1354
1355 2012-04-27  Dirk Pranke  <dpranke@chromium.org>
1356
1357         [chromium] use "drt-style" output, not "test-shell-style" output, on mac and linux DRT
1358         https://bugs.webkit.org/show_bug.cgi?id=84917
1359
1360         Reviewed by Ojan Vafai.
1361
1362         This change changes the chromium new-run-webkit-tests
1363         implementation to use the code in WebKitDriver and ServerProcess
1364         by default on Mac and Linux, instead of using the old-style
1365         Chromium/test_shell style of output.
1366
1367         We will still use the test_shell style on Windows for now
1368         and you can still get the old style of behavior with
1369         new-run-webkit-tests --additional-drt-flag --test-shell
1370
1371         * Scripts/webkitpy/layout_tests/port/chromium.py:
1372         (ChromiumDriver):
1373         (ChromiumDriver.__init__):
1374         (ChromiumDriver._wrapper_options):
1375         (ChromiumDriver.cmd_line):
1376         (ChromiumDriver._start):
1377         (ChromiumDriver.has_crashed):
1378         (ChromiumDriver.run_test):
1379         (ChromiumDriver.stop):
1380         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1381         (ChromiumDriverTest.setUp):
1382         (ChromiumDriverTest.test_stop):
1383         (ChromiumDriverTest.test_two_drivers.MockDriver.__init__):
1384         (ChromiumDriverTest.test_two_drivers):
1385
1386 2012-04-27  Dirk Pranke  <dpranke@chromium.org>
1387
1388         webkitpy: fix race in unit tests for manager_worker_broker
1389         https://bugs.webkit.org/show_bug.cgi?id=84925
1390
1391         Reviewed by Ojan Vafai.
1392
1393         I have been intermittently seeing hangs when running
1394         test-webkitpy on Mac SL; it appears that there's a bug (?) in
1395         the multiprocessing module where queue references are getting
1396         leaked or not cleaned up somehow. By explicitly closing the
1397         queues, things seem to be happy, so this patch adds a cleanup()
1398         method to the message broker and modifies the manager (and the
1399         unit tests) to call it. This may get rid of the intermittent
1400         error on shutdown on Linux I've seen as well.
1401
1402         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1403         (Manager._run_tests):
1404         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1405         (_Broker.__del__):
1406         (_Broker):
1407         (_Broker.cleanup):
1408         (_BrokerConnection.cleanup):
1409         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
1410         (_TestsMixin.test_name):
1411         (_TestsMixin.test_cancel):
1412         (_TestsMixin.test_done):
1413         (_TestsMixin.test_unknown_message):
1414
1415 2012-04-27  Gavin Peters  <gavinp@chromium.org>
1416
1417         Add new ENABLE_LINK_PRERENDER define to control the Prerendering API
1418         https://bugs.webkit.org/show_bug.cgi?id=84871
1419
1420         Reviewed by Adam Barth.
1421
1422         Prerendering is currently covered by the ENABLE_LINK_PREFETCH macro, but the new Prerendering
1423         API separates it from prefetching.  Having separate include guards lets ports enable prefetching,
1424         a relatively easy change, without needing to build the infrastructure for prerendering, which
1425         is considerably more complicated.
1426
1427 2012-04-27  Philippe Normand  <pnormand@igalia.com>
1428
1429         Unreviewed, GTK gardening.
1430
1431         * Scripts/run-gtk-tests:
1432         (TestRunner): Skip flaky WebKit2 API test.
1433
1434 2012-04-27  Philippe Normand  <pnormand@igalia.com>
1435
1436         Unreviewed, GTK gardening.
1437
1438         * Scripts/run-gtk-tests:
1439         (TestRunner): Fix another typo. So easy to get confused by a Test
1440         name and the actual name of the executable...
1441
1442 2012-04-27  Philippe Normand  <pnormand@igalia.com>
1443
1444         Unreviewed, GTK gardening.
1445
1446         * Scripts/run-gtk-tests:
1447         (TestRunner): Skip failing WebKit2 API test.
1448
1449 2012-04-27  Christophe Dumez  <christophe.dumez@intel.com>
1450
1451         [EFL] DRT should support LayoutTestController's dumpResourceLoadCallbacks()
1452         https://bugs.webkit.org/show_bug.cgi?id=81891
1453
1454         Reviewed by Philippe Normand.
1455
1456         Implement support for LayoutTestController's
1457         dumpResourceLoadCallbacks() in EFL's DumpRenderTree by catching new
1458         ewk_view signals about resource loading and print out the expected
1459         information. This allows for several test cases to be removed from the
1460         skip list.
1461
1462         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1463         (DumpRenderTreeChrome::createView):
1464         (descriptionSuitableForTestResult):
1465         (DumpRenderTreeChrome::onResponseReceived):
1466         (DumpRenderTreeChrome::onResourceLoadFinished):
1467         (DumpRenderTreeChrome::onResourceLoadFailed):
1468         (DumpRenderTreeChrome::onNewResourceRequest):
1469         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1470         (DumpRenderTreeChrome):
1471
1472 2012-04-27  Philippe Normand  <pnormand@igalia.com>
1473
1474         Unreviewed, GTK typo fix.
1475
1476         * Scripts/run-gtk-tests:
1477         (TestRunner): Fix-up skipped WebKit2 API test name TestWKConnection.
1478
1479 2012-04-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1480
1481         [SOUP] Add a way to register custom uri schemes in WebKit2
1482         https://bugs.webkit.org/show_bug.cgi?id=84130
1483
1484         Reviewed by Martin Robinson.
1485
1486         * Scripts/webkitpy/style/checkers/cpp.py:
1487         (check_identifier_name_in_declaration): Add webkit_soup prefix to
1488         the list of exceptions to the underscores in identifiers rule.
1489
1490 2012-04-26  Ryosuke Niwa  <rniwa@webkit.org>
1491
1492         Extract PerfTestFactory
1493         https://bugs.webkit.org/show_bug.cgi?id=83944
1494
1495         Reviewed by Dirk Pranke.
1496         
1497         Extracted PerfTestFactory out of PerfTest. This class creates appropriate PerfTest object given
1498         a test name and a path. Also removed dirname from the constructors of PerfTest and its subclasses.
1499
1500         Also added simple test cases to sanity check PerfTestFactory.
1501
1502         * Scripts/webkitpy/performance_tests/perftest.py:
1503         (PerfTest.__init__):
1504         (PerfTest.test_name):
1505         (ChromiumStylePerfTest.__init__):
1506         (PageLoadingPerfTest.__init__):
1507         (PageLoadingPerfTest.run):
1508         (PerfTestFactory):
1509         (PerfTestFactory.create_perf_test):
1510         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1511         (MainTest.test_parse_output):
1512         (MainTest.test_parse_output_with_failing_line):
1513         (TestPageLoadingPerfTest.test_run):
1514         (TestPageLoadingPerfTest.test_run_with_bad_output):
1515         (TestPerfTestFactory):
1516         (TestPerfTestFactory.test_regular_test):
1517         (TestPerfTestFactory.test_inspector_test):
1518         (TestPerfTestFactory.test_page_loading_test):
1519         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1520         (PerfTestsRunner):
1521         (PerfTestsRunner._collect_tests):
1522         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1523         (run_test):
1524         (_tests_for_runner):
1525
1526 2012-04-26  Dirk Pranke  <dpranke@chromium.org>
1527
1528         nrwt: clean up server process, webkit driver so chromium can use it
1529         https://bugs.webkit.org/show_bug.cgi?id=84910
1530
1531         Reviewed by Ojan Vafai.
1532
1533         This change moves the "sample a process" logic out of
1534         server_process.py and into a port-specific class (where really
1535         only the mac has an implementation), and also preemptively kills
1536         DRT when a test times out in WebKitDriver (rather than waiting through the
1537         additional delays caused by calling stop() when we would want to
1538         restart the driver generically in worker.py).
1539
1540         These changes will make it possible for the chromium port to
1541         switch over to the stock WebKitDriver implementation, at least
1542         on mac and linux.
1543
1544         * Scripts/webkitpy/layout_tests/port/base.py:
1545         (Port.sample_process):
1546         * Scripts/webkitpy/layout_tests/port/mac.py:
1547         (MacPort.sample_process):
1548         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1549         (test_helper_fails_to_stop):
1550         (test_sample_process):
1551         (test_sample_process.logging_run_command):
1552         (test_sample_process_throws_exception):
1553         (test_sample_process_throws_exception.throwing_run_command):
1554         * Scripts/webkitpy/layout_tests/port/server_process.py:
1555         (ServerProcess._log):
1556         (ServerProcess._handle_timeout):
1557         (ServerProcess.stop):
1558         (ServerProcess):
1559         (ServerProcess.kill): Here we add a method to immediately stop
1560         the process rather than trying to shut it down cleanly.
1561         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
1562         (TestServerProcess.test_broken_pipe):
1563         * Scripts/webkitpy/layout_tests/port/webkit.py:
1564         (WebKitDriver.run_test): Fix an issue where we weren't passing
1565         along any per-test args (only needed for Chromium, but still).
1566         Also, kill the driver immediately if we time out a test.
1567
1568 2012-04-26  Benjamin Poulain  <bpoulain@apple.com>
1569
1570         ObjcClass::methodsNamed() can leak if buffer is dynamically allocated
1571         https://bugs.webkit.org/show_bug.cgi?id=84668
1572
1573         Reviewed by Alexey Proskuryakov.
1574
1575         Extend ObjCPlugin to support the new layout tests of the Objective-C bridge.
1576
1577         * DumpRenderTree/mac/ObjCPlugin.m:
1578         (+[ObjCPlugin isSelectorExcludedFromWebScript:]):
1579         (+[ObjCPlugin webScriptNameForSelector:]):
1580         (-[ObjCPlugin methodMappedToLongName]):
1581         (-[ObjCPlugin testConversionColon:]):
1582         (-[ObjCPlugin _:]):
1583
1584 2012-04-26  Dimitri Glazkov  <dglazkov@chromium.org>
1585
1586         Unreviewed, rolling out r115340.
1587         http://trac.webkit.org/changeset/115340
1588         https://bugs.webkit.org/show_bug.cgi?id=83048
1589
1590         Does not work with Windows.
1591
1592         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1593         (SingleTestRunner._run_reftest):
1594         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1595         (copy_file):
1596         * Scripts/webkitpy/layout_tests/port/base.py:
1597         (Port._parse_reftest_list):
1598         (Port.reference_files):
1599         (Port._real_tests):
1600         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1601         (PortTest.test_reference_files):
1602         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1603         (ChromiumDriverTest.test_write_command_and_read_line):
1604
1605 2012-04-26  Christophe Dumez  <christophe.dumez@intel.com>
1606
1607         [EFL] Enable VIDEO_TRACK feature
1608         https://bugs.webkit.org/show_bug.cgi?id=84830
1609
1610         Reviewed by Gustavo Noronha Silva.
1611
1612         Enable VIDEO_TRACK by default on EFL port whenever build-webkit is
1613         used.
1614
1615         * Scripts/build-webkit:
1616
1617 2012-04-08  Robert Hogan  <robert@webkit.org>
1618
1619         new-webkit-run-tests: handle ref tests from the CSS test suite
1620         https://bugs.webkit.org/show_bug.cgi?id=83048
1621
1622         Reviewed by Ryosuke Niwa.
1623
1624         This allows new-run-webkit-tests to run reference tests created for the CSS test suite. It removes a big swathe
1625         of pixel and text results that are no longer required now that the reference results are used and adds in the support
1626         files from the CSS test suite that allow the ref tests to run.
1627
1628         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1629         (SingleTestRunner._run_reftest): Assert that the reference result exists. Previously the test would
1630          run without it and report a pass!
1631         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1632         (copy_file): ensure the output directory exists, it may not if the reference test is
1633           contained in a folder that contains nothing but reference tests.
1634         * Scripts/webkitpy/layout_tests/port/base.py:
1635         (Port.available_reference_files): Add as a helper. Handle embedded relative paths, e.g: some/../path
1636         (Port.reference_files): Only return reference results in the reftest list that actually exist on
1637           disk. Also, don't ignore potential reference results on disk that are not in the reftest list, and
1638           don't ignore them just because we have a reftest list for the test's directory.
1639         (Port._real_tests): ignore anything that looks like a test in a 'support' directory, this semantic
1640           is used by the CSS 2.1 test suite.
1641         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1642         (PortTest.test_reference_files_when_reftestlist_and_reference_file_present): Ensure that a test with a reference result
1643           on disk but no reference result listed in the directory's reftest list picks up its reference result.
1644         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1645         (ChromiumDriverTest.test_strip_uri): Test that some/test.html and some/other/../test.html are treated
1646          as the same file.
1647
1648 2012-04-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1649
1650         Unreviewed. Fix GTK+ build after r115314.
1651
1652         For some reason it fails while bulding GtkVersioning for WTR, but
1653         it didn't fail neither in EWS nor in my laptop. We don't really
1654         need GtkVersioning in WTR since it already depends on GTK+3
1655         unconditionally.
1656
1657         * WebKitTestRunner/GNUmakefile.am: Remove GtkVersioning.c from
1658         compilation.
1659         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1660         (WTR::EventSenderProxy::createMouseButtonEvent): Use GTK+ 3 API
1661         directly instead of getDefaultGDKPointerDevice() helper.
1662         (WTR::EventSenderProxy::keyDown): Ditto.
1663         (WTR::EventSenderProxy::mouseMoveTo): Ditto.
1664
1665 2012-04-24  Ojan Vafai  <ojan@chromium.org>
1666
1667         Show flakiness dashboard data in garden-o-matic
1668         https://bugs.webkit.org/show_bug.cgi?id=83716
1669
1670         Reviewed by Dimitri Glazkov.
1671
1672         Put an iframe below the expected/actual results in the Results view.
1673         Size the iframe to it's height.
1674
1675         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1676         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
1677         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1678         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1679         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
1680         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
1681         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
1682
1683 2012-04-26  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1684
1685         [EFL] [DRT] LayoutTestController needs implementation of setJavaScriptProfilingEnabled
1686         https://bugs.webkit.org/show_bug.cgi?id=84576
1687
1688         Reviewed by Martin Robinson.
1689
1690         Add missing implementation setJavaScriptProfilingEnabled to EFL's
1691         LayoutTestController in order to unskip tests rely on this setting.
1692
1693         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1694         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1695         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1696         (LayoutTestController::setJavaScriptProfilingEnabled):
1697
1698 2012-04-26  Xianzhu Wang  <wangxianzhu@chromium.org>
1699
1700         Add Jing Zhao, Min Qin, Tien-Ren Chen and Hao Zheng into contributors list.
1701
1702         Not reviewed.
1703
1704         * Scripts/webkitpy/common/config/committers.py:
1705
1706 2012-04-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1707
1708         [GTK] Test TestWebKitAPI/WebKit2/TestNewFirstVisuallyNonEmptyLayout times out
1709         https://bugs.webkit.org/show_bug.cgi?id=84957
1710
1711         Reviewed by Martin Robinson.
1712
1713         * Scripts/run-gtk-tests:
1714         (TestRunner): Unskip TestNewFirstVisuallyNonEmptyLayout and
1715         TestNewFirstVisuallyNonEmptyLayoutForImages.
1716         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
1717         (TestWebKitAPI::PlatformWebView::PlatformWebView): Show the
1718         toplevel window containing the web view to make sure events are
1719         received.
1720
1721 2012-04-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1722
1723         Unreviewed. Add bug numbers to skipped tests.
1724
1725         * Scripts/run-gtk-tests:
1726         (TestRunner):
1727
1728 2012-04-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1729
1730         [GTK] Build and run TestWebKitAPI WebKit2 unit tests
1731         https://bugs.webkit.org/show_bug.cgi?id=84446
1732
1733         Reviewed by Philippe Normand.
1734
1735         * Scripts/run-gtk-tests:
1736         (TestRunner): Add TestWebKitAPI/WebKit2 to the list of directories
1737         containing tests. Unskip FunctionalTest.RefCountedStorage, since
1738         we are now using a custom main that initializes WTF threading.
1739         (TestRunner._setup_testing_environment): Set environment variables
1740         required to run WebKit2 tests.
1741         * TestWebKitAPI/GNUmakefile.am:
1742         * TestWebKitAPI/JavaScriptTest.cpp: Use
1743         JavaScriptCore/JSContextRef.h instead of
1744         JavaScriptCore/JavaScriptCore.h since it includes JSStringRefCF.h
1745         unconditionally.
1746         * TestWebKitAPI/PlatformWebView.h: Define PlatformWKView and
1747         PlatformWindow for GTK.
1748         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp: Remove
1749         unneded header that breaks the build of GTK port.
1750         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp: Use
1751         JavaScriptCore/JSContextRef.h instead of
1752         JavaScriptCore/JavaScriptCore.h since it includes JSStringRefCF.h
1753         unconditionally.
1754         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1755         (TestWebKitAPI::TEST): Add expected values for GTK+ port.
1756         * TestWebKitAPI/gtk/InjectedBundleControllerGtk.cpp:
1757         (TestWebKitAPI):
1758         (TestWebKitAPI::InjectedBundleController::platformInitialize):
1759         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp: Added.
1760         (TestWebKitAPI::Util::checkTestFinished):
1761         (TestWebKitAPI::Util::run):
1762         (TestWebKitAPI::Util::sleep):
1763         (TestWebKitAPI::Util::getFilenameFromEnvironmentVariableAsUTF8):
1764         (TestWebKitAPI::Util::createInjectedBundlePath):
1765         (TestWebKitAPI::Util::createURLForResource):
1766         (TestWebKitAPI::Util::URLForNonExistentResource):
1767         (TestWebKitAPI::Util::isKeyDown):
1768         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp: Added.
1769         (TestWebKitAPI::PlatformWebView::PlatformWebView):
1770         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
1771         (TestWebKitAPI::PlatformWebView::page):
1772         (TestWebKitAPI::PlatformWebView::resizeTo):
1773         (TestWebKitAPI::doKeyStroke):
1774         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
1775         (TestWebKitAPI::PlatformWebView::simulateAltKeyPress):
1776         (TestWebKitAPI::doMouseButtonEvent):
1777         (TestWebKitAPI::PlatformWebView::simulateRightClick):
1778         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
1779         * TestWebKitAPI/gtk/main.cpp:
1780         (main):
1781
1782 2012-04-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1783
1784         [GTK] run-gtk-tests: Use a timeout per test instead of a global timeout
1785         https://bugs.webkit.org/show_bug.cgi?id=84695
1786
1787         Reviewed by Philippe Normand.
1788
1789         It also adds a command line option to be able to pass a custom
1790         timeout value, instead of hard-coding it. The default timeout is 10
1791         seconds if no other value is passed to the script.
1792
1793         * Scripts/run-gtk-tests:
1794         (TestTimeout): Exception raised when a test times out.
1795         (TestRunner._get_child_pid_from_test_output): Helper function to
1796         get the pid of the running test from gtester output.
1797         (TestRunner._kill_process): Helper funtion ot kill a process
1798         ignoring exceptions if the process is already died.
1799         (TestRunner._run_test_command): Run the test command raising
1800         TestTimeout exception if the test doesn't finish before the given
1801         timeout in seconds.
1802         (TestRunner._run_test_command.alarm_handler): Alarm handler that
1803         raises TestTimeout exception.
1804         (TestRunner._run_test_glib): Use _run_test_command() to run the test.
1805         (TestRunner._run_test_google): Ditto.
1806         (TestRunner.run_tests): Add current test to the list of timed out
1807         test if TestTimeout exception is raised. Show the list of timed
1808         out test at the end.
1809
1810 2012-04-26  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1811
1812         [EFL] [DRT] LayoutTestController needs implementation of addOriginAccessWhitelistEntry and removeOriginAccessWhitelistEntry
1813         https://bugs.webkit.org/show_bug.cgi?id=83880
1814
1815         Reviewed by Antonio Gomes.
1816
1817         Add missing implementation addOriginAccessWhitelistEntry and
1818         removeOriginAccessWhitelistEntry to EFL's LayoutTestController
1819         in order to unskip tests which rely on this.
1820
1821         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1822         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1823         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1824         (LayoutTestController::addOriginAccessWhitelistEntry):
1825         (LayoutTestController::removeOriginAccessWhitelistEntry):
1826
1827 2012-04-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1828
1829         [GTK] Add downloads support to MiniBrowser
1830         https://bugs.webkit.org/show_bug.cgi?id=73662
1831
1832         Reviewed by Philippe Normand.
1833
1834         * MiniBrowser/gtk/BrowserDownloadsBar.c: Added.
1835         (browserDownloadsBarChildRemoved): Close the downloads bar if
1836         there aren't active downloads.
1837         (browserDownloadsBarResponse): Destroy the downloads bar when
1838         closed.
1839         (browser_downloads_bar_init):
1840         (browser_downloads_bar_class_init):
1841         (browser_downloads_bar_new): Create a new downloads bar.
1842         (actionButtonClicked): Cancel the download if cancel button was
1843         clicked, or open the downloaded file if the download finished.
1844         (browserDownloadFinalize):
1845         (browser_download_init):
1846         (browser_download_class_init):
1847         (downloadReceivedResponse): Update download message using the
1848         response URI.
1849         (remainingTime): Helper function to get human readable remaining
1850         time.
1851         (downloadProgress): Update downloads progress.
1852         (downloadReceivedData):
1853         (downloadFinished): Update download message and turn download
1854         button into open.
1855         (downloadFailed): Show error message or destroy the download UI if
1856         it was cancelled.
1857         (browserDownloadNew): Create a new download widget for the given
1858         WebKitDownload.
1859         (browser_downloads_bar_add_download): Add download widget to the
1860         downloads bar.
1861         * MiniBrowser/gtk/BrowserDownloadsBar.h: Added.
1862         * MiniBrowser/gtk/BrowserWindow.c:
1863         (downloadStarted): Create a download widget and add it to the
1864         downloads bar when a new download is started.
1865         (browserWindowConstructed): Connect to
1866         WebKitWebContext::download-started signal.
1867         * MiniBrowser/gtk/GNUmakefile.am: Add new files to compilation.
1868
1869 2012-04-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1870
1871         Unreviewed. Skip unit test failing in debug bot.
1872
1873         * Scripts/run-gtk-tests:
1874         (TestRunner):
1875
1876 2012-04-26  Christophe Dumez  <christophe.dumez@intel.com>
1877
1878         [EFL][DRT] "resource,request,willsend" signal needs to provide more information
1879         https://bugs.webkit.org/show_bug.cgi?id=84670
1880
1881         Reviewed by Andreas Kling.
1882
1883         Handle in EFL's DumpRenderTree the new Ewk_Frame_Resource_Messages now
1884         passed with the "resource,request,willsend" signal and dump
1885         information about the network request and the possible network
1886         response if LayoutTestController's dumpResourceLoadCallbacks() returns
1887         true.
1888
1889         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1890         (pathSuitableForTestResult):
1891         (urlSuitableForTestResult):
1892         (descriptionSuitableForTestResult):
1893         (DumpRenderTreeChrome::onWillSendRequest):
1894
1895 2012-04-25  Csaba Osztrogonác  <ossy@webkit.org>
1896
1897         [Qt][WK2] Unreviewed, rolling out r113703 because of crashing tests.
1898         http://trac.webkit.org/changeset/113703
1899         https://bugs.webkit.org/show_bug.cgi?id=83024
1900
1901         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1902         * Tools.pro:
1903         * qmake/mkspecs/features/features.prf:
1904         * qmake/mkspecs/features/functions.prf:
1905
1906 2012-04-25  Maciej Stachowiak  <mjs@apple.com>
1907
1908         Teach LayoutTestHelper to correctly restore the color profile when it's a factory profile
1909         https://bugs.webkit.org/show_bug.cgi?id=84931
1910
1911         Reviewed by Filip Pizlo.
1912
1913         * DumpRenderTree/mac/LayoutTestHelper.m:
1914         (installLayoutTestColorProfile): Account for the possibility of the default
1915         profile being a factory profile.
1916
1917 2012-04-25  Sheriff Bot  <webkit.review.bot@gmail.com>
1918
1919         Unreviewed, rolling out r115240.
1920         http://trac.webkit.org/changeset/115240
1921         https://bugs.webkit.org/show_bug.cgi?id=84928
1922
1923         It broke everything (Requested by Ossy_HOME on #webkit).
1924
1925         * Scripts/webkitpy/layout_tests/port/gtk.py:
1926         (GtkDriver):
1927         (GtkDriver._start):
1928         (GtkDriver._start.x_filter):
1929         (GtkDriver.stop):
1930         (GtkPort._driver_class):
1931         * Scripts/webkitpy/layout_tests/port/qt.py:
1932         (QtPort._build_driver):
1933         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py: Removed.
1934
1935 2012-04-25  Dirk Pranke  <dpranke@chromium.org>
1936
1937         [chromium] change DRT's "DRT" output to match the other ports
1938         https://bugs.webkit.org/show_bug.cgi?id=84904
1939
1940         Reviewed by Kent Tamura.
1941
1942         Since we run Chromium's DRT in --test-shell mode, the
1943         non-test-shell output has never been really beaten on to make
1944         sure it's right. This fixes a few issues and will be tested
1945         with upcoming NRWT changes that'll land in a separate patch.
1946         In particular we should never output framing text like "\n"
1947         or "#EOF" outside of something outside of TestEventPrinter,
1948         and we weren't handling audio output properly at all.
1949
1950         * DumpRenderTree/chromium/TestEventPrinter.cpp:
1951         (DRTPrinter):
1952         (TestShellPrinter):
1953         (DRTPrinter::handleTextFooter):
1954         (DRTPrinter::handleAudioFooter):
1955         (DRTPrinter::handleTestFooter):
1956         (TestShellPrinter::handleAudioFooter):
1957         * DumpRenderTree/chromium/TestEventPrinter.h:
1958         (TestEventPrinter):
1959         * DumpRenderTree/chromium/TestShell.cpp:
1960         (TestShell::TestShell):
1961         (TestShell::dump):
1962
1963 2012-04-25  Joshua Bell  <jsbell@chromium.org>
1964
1965         Unreviewed: Adding Alec Flett as a contributor (non-committer).
1966
1967         * Scripts/webkitpy/common/config/committers.py:
1968
1969 2012-04-25  Abhishek Arya  <inferno@chromium.org>
1970
1971         Mark myself as a reviewer.
1972         https://bugs.webkit.org/show_bug.cgi?id=84902
1973
1974         Reviewed by Dimitri Glazkov.
1975
1976         * Scripts/webkitpy/common/config/committers.py:
1977
1978 2012-04-25  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1979
1980         [Qt][NRWT] Run each DRT in it's own xvfb
1981         https://bugs.webkit.org/show_bug.cgi?id=77335
1982
1983         Reviewed by Dirk Pranke.
1984
1985         * Scripts/webkitpy/layout_tests/port/gtk.py:
1986         (GtkPort._driver_class):
1987         * Scripts/webkitpy/layout_tests/port/qt.py:
1988         (QtPort._driver_class):
1989         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py: Added.
1990         (XvfbDriver):
1991         (XvfbDriver._start):
1992         (XvfbDriver._start.x_filter):
1993         (XvfbDriver.stop):
1994
1995 2012-04-25  Sheriff Bot  <webkit.review.bot@gmail.com>
1996
1997         Unreviewed, rolling out r115222.
1998         http://trac.webkit.org/changeset/115222
1999         https://bugs.webkit.org/show_bug.cgi?id=84874
2000
2001         Caused test regressions on the EFL build (Requested by rakuco
2002         on #webkit).
2003
2004         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2005         (LayoutTestController::addOriginAccessWhitelistEntry):
2006         (LayoutTestController::removeOriginAccessWhitelistEntry):
2007
2008 2012-04-25  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2009
2010         [EFL] [DRT] LayoutTestController needs implementation of addOriginAccessWhitelistEntry and removeOriginAccessWhitelistEntry
2011         https://bugs.webkit.org/show_bug.cgi?id=83880
2012
2013         Reviewed by Antonio Gomes.
2014
2015         Add missing implementation addOriginAccessWhitelistEntry and
2016         removeOriginAccessWhitelistEntry to EFL's LayoutTestController
2017         in order to unskip tests which rely on this.
2018
2019         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2020         (LayoutTestController::addOriginAccessWhitelistEntry):
2021         (LayoutTestController::removeOriginAccessWhitelistEntry):
2022
2023 2012-04-25  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2024
2025         [EFL] [DRT] Reset text zoom factor before running a test
2026         https://bugs.webkit.org/show_bug.cgi?id=84861
2027
2028         Reviewed by Antonio Gomes.
2029
2030         This fix eliminates most of the current flakiness on EFL build
2031         bots, although some CSS tests will now need rebasiling.
2032
2033         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2034         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2035
2036 2012-04-25  Milian Wolff  <milian.wolff@kdab.com>
2037
2038         [Qt] add LayoutTestController::setPrinting support to Qt unit tests
2039         https://bugs.webkit.org/show_bug.cgi?id=84246
2040
2041         Reviewed by Simon Hausmann.
2042
2043         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2044         (WebCore::DumpRenderTree::dump):
2045
2046 2012-04-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2047
2048         [Qt] Make the web view's url property follow the active url
2049
2050         https://bugs.webkit.org/show_bug.cgi?id=77554
2051
2052         Update  the location bar in the minibrowser to behave
2053         a bit more like normal browsers in terms of when the url will change
2054         and how active focus is handled.
2055
2056         Reviewed by Simon Hausmann.
2057
2058         * MiniBrowser/qt/qml/BrowserWindow.qml:
2059
2060 2012-04-25  Philippe Normand  <pnormand@igalia.com>
2061
2062         Webkit build fails due to missing gstreamer include file on Kubuntu 8.04
2063         https://bugs.webkit.org/show_bug.cgi?id=81913
2064
2065         Reviewed by Tor Arne Vestbø.
2066
2067         * qmake/mkspecs/features/features.prf: Check for gstreamer-0.10
2068         and gstreamer-plugins-base >= 0.10.30 just like the GTK port
2069         does. 0.10.27 is unfortunately not recent enough to get the media
2070         player working reliably.
2071
2072
2073 2012-04-25  Xiaobo Wang  <xbwang@torchmobile.com.cn>
2074
2075         [BlackBerry] Run tests in '/http/tests/local' with local URI
2076         https://bugs.webkit.org/show_bug.cgi?id=84820
2077
2078         Reviewed by Nikolas Zimmermann.
2079
2080         Currently we run all tests under folder "/http/tests/" as HTTP
2081         tests (http://...). However in WebKit ORWT and NRWT scripts, tests in
2082         'http/tests/local' are run with local path (like '/developer/LayoutTests
2083         /http/tests/local/absolute-url-strip-whitespace.html').
2084         With this patch we can keep the same behaviour as other portings.
2085
2086         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2087         (BlackBerry::WebKit::DumpRenderTree::isHTTPTest):
2088
2089 2012-04-25  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2090
2091         [EFL][DRT] Reset DRT settings to their default values after a testcase was executed.
2092         https://bugs.webkit.org/show_bug.cgi?id=84709
2093
2094         Reviewed by Eric Seidel.
2095
2096         Not all the settings that can be changed by layout testcases through a JS API were 
2097         reset in DumpRenderTreeChrome::resetDefaultsToConsistentValues().
2098
2099         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2100         (defaultEditingBehavior): returns editing behavior depending on current platform.
2101         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): reset some missed DRT settings
2102
2103 2012-04-24  Dirk Pranke  <dpranke@chromium.org>
2104
2105         nrwt: add ASAN handling to chromium crash logs
2106         https://bugs.webkit.org/show_bug.cgi?id=84664
2107
2108         Reviewed by Ojan Vafai.
2109
2110         * Scripts/webkitpy/layout_tests/port/chromium.py:
2111         (ChromiumPort._get_crash_log):
2112
2113 2012-04-24  Dirk Pranke  <dpranke@chromium.org>
2114
2115         webkit-patch rebaseline-test is retrieving stale expectations
2116         https://bugs.webkit.org/show_bug.cgi?id=84762
2117
2118         Reviewed by Ojan Vafai.
2119
2120         webkit-patch rebaseline-expectations is fetching files directly
2121         from the layout-test-results directory on the buildbots, rather
2122         than fetching them from the archive. This is problematic because
2123         we don't clobber the directory after each run and so you can end
2124         up fetching stale failing results.
2125
2126         This change temporarily changes the code to fetch the zip file
2127         instead -- making things much slower -- until I can confer w/
2128         abarth and ojan over the best way to fix this for the long-term.
2129
2130         * Scripts/webkitpy/tool/commands/rebaseline.py:
2131         (RebaselineTest.__init__):
2132         (RebaselineTest._zip_file_set):
2133         (RebaselineTest):
2134         (RebaselineTest._fetch_baseline):
2135         (RebaselineTest._rebaseline_test):
2136         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2137         (TestRebaseline.stub_rebaseline_test_command_and_tool):
2138         (TestRebaseline.stub_rebaseline_test_command_and_tool.FakeZipFileSet):
2139         (TestRebaseline.stub_rebaseline_test_command_and_tool.FakeZipFileSet.read):
2140         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
2141         (test_rebaseline_updates_expectations_file):
2142         (test_rebaseline_test):
2143         (test_rebaseline_and_copy_test):
2144         (test_rebaseline_and_copy_test_no_existing_result):
2145         (test_rebaseline_and_copy_test_with_lion_result):
2146         (test_rebaseline_and_copy_no_overwrite_test):
2147
2148 2012-04-24  Ojan Vafai  <ojan@chromium.org>
2149
2150         Improve code for embedding flakiness dashboard as an iframe
2151         https://bugs.webkit.org/show_bug.cgi?id=84782
2152
2153         Reviewed by Dirk Pranke.
2154
2155         -Include the horizontal scrollbar height in the measured height of the page.
2156         -Post a message everytime the height changes instead of in response to a queryContentHeight message.
2157         This way, the embedder doesn't need to poll.
2158
2159         No new tests. This is hard to test because it involves postMessage and iframes.
2160         Once we switch the dashboard tests over to qunit, we should be able to write an
2161         asyncTest for this.
2162
2163         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2164         (generatePage):
2165         (appendHTML):
2166         (appendExpectations):
2167         (postHeightChangedMessage):
2168         (generatePageForIndividualTests.if):
2169         (generatePageForIndividualTests):
2170         * TestResultServer/static-dashboards/flakiness_dashboard_embedded.html: Added.
2171
2172 2012-04-16  Ojan Vafai  <ojan@chromium.org>
2173
2174         Replace garden-o-matic accordion UI with a panel UI
2175         https://bugs.webkit.org/show_bug.cgi?id=84081
2176
2177         Reviewed by Dimitri Glazkov.
2178
2179         This is a nicer UI to work with and makes it easier to embed the flakiness dashboard,
2180         since we can reuse the same iframe without moving it in the DOM.
2181
2182         Also, excise unnecessary jquery-isms.
2183
2184         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2185         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
2186         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
2187
2188 2012-04-24  Peter Beverloo  <peter@chromium.org>
2189
2190         [Chromium] DumpRenderTree should depend on base.gyp:test_support_base
2191         https://bugs.webkit.org/show_bug.cgi?id=84729
2192
2193         Reviewed by Dirk Pranke.
2194
2195         This dependency is necessary for Android since it'll soon be
2196         calling InitAndroidOSPathStub() in it's platform support. The
2197         TestWebKitAPI and webkit_unit_tests already have this dependency.
2198
2199         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2200
2201 2012-04-24  Ojan Vafai  <ojan@chromium.org>
2202
2203         Replace vague informative statement with the list of builders where the test isn't listed
2204         https://bugs.webkit.org/show_bug.cgi?id=84779
2205
2206         Reviewed by Dirk Pranke.
2207
2208         This is more informative and more likely to be noticed. With the old UI, people never
2209         read the line and if they did, they didn't really understand what it meant. Hopefully
2210         have the list of builders will be more clear.
2211
2212         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2213         * TestResultServer/static-dashboards/flakiness_dashboard_tests.css:
2214         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2215
2216 2012-04-24  Tommy Widenflycht  <tommyw@google.com>
2217
2218         MediaStream API: Create a new flag for PeerConnection
2219         https://bugs.webkit.org/show_bug.cgi?id=84723
2220
2221         Reviewed by Dimitri Glazkov.
2222
2223         To allow Chrome to make the GetUserMedia functionality available by default we
2224         need another flag for the PeerConnection related parts. This new flag is in
2225         addition to the general media stream flag, and both need to be enabled for
2226         PeerConnection object creation.
2227
2228         * DumpRenderTree/chromium/TestShell.cpp:
2229         (TestShell::TestShell):
2230
2231 2012-04-24  Joe Mason  <jmason@rim.com>
2232
2233         [BlackBerry] Revert broken changes to authentication dialog
2234         https://bugs.webkit.org/show_bug.cgi?id=80135
2235
2236         Reviewed by Antonio Gomes.
2237
2238         The previous patches from this bug caused an infinite loop when using digest auth;
2239         apparently they were only tested with basic.
2240
2241         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2242         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
2243         (WebCore):
2244
2245 2012-04-24  Zan Dobersek  <zandobersek@gmail.com>
2246
2247         [TestResultsServer] Add a unit test for changes in r114868
2248         https://bugs.webkit.org/show_bug.cgi?id=84713
2249
2250         Reviewed by Ojan Vafai.
2251
2252         Add a new unit test to test the isToTWebKit attribute of a BuilderGroup object
2253         that is created for either DEPS or ToT builder groups. The unit test covers changes
2254         made in r114868.
2255
2256         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2257         (testBuilderGroupIsToTWebKitAttribute.g_handleBuildersListLoaded):
2258         (testBuilderGroupIsToTWebKitAttribute.assertEquals):
2259
2260 2012-04-24  Brady Eidson  <beidson@apple.com>
2261
2262         <rdar://problem/10120155> and https://bugs.webkit.org/show_bug.cgi?id=82664
2263          Need DOMWindow mechanism to supplement UserScripts for page cache notifications
2264
2265         Reviewed by Sam Weinig.
2266
2267         Add a new bundle test that stresses the basics of the WKBundleDOMWindowExtension API.
2268
2269         It makes sure new extensions can be added at the right times, and that all of the expected
2270         callbacks are made.
2271
2272         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp: Added.
2273         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Record all messages sent from the bundle.
2274         (TestWebKitAPI::TEST): Run a page through some basic exercises, then compared messages sent from the
2275            bundle to a set of known expected messages.
2276
2277         Listen to all the new client callbacks, create some extensions, and monitor their lifetimes:
2278         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp: Added.
2279         (TestWebKitAPI::DOMWindowExtensionBasic::DOMWindowExtensionBasic):
2280         (TestWebKitAPI::DOMWindowExtensionBasic::frameLoadFinished):
2281         (TestWebKitAPI::DOMWindowExtensionBasic::sendExtensionStateMessage):
2282         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
2283         (TestWebKitAPI::DOMWindowExtensionBasic::didCreatePage):
2284         (TestWebKitAPI::DOMWindowExtensionBasic::updateExtensionStateRecord):
2285         (TestWebKitAPI::DOMWindowExtensionBasic::sendBundleMessage):
2286         (TestWebKitAPI::DOMWindowExtensionBasic::didCreateGlobalObjectForFrame):
2287         (TestWebKitAPI::DOMWindowExtensionBasic::willDisconnectDOMWindowExtensionFromGlobalObject):
2288         (TestWebKitAPI::DOMWindowExtensionBasic::didReconnectDOMWindowExtensionToGlobalObject):
2289         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyGlobalObjectForDOMWindowExtension):
2290         (TestWebKitAPI::didFinishLoadForFrameCallback):
2291         (TestWebKitAPI::didCreateGlobalObjectForFrameCallback):
2292         (TestWebKitAPI::willDisconnectDOMWindowExtensionFromGlobalObjectCallback):
2293         (TestWebKitAPI::didReconnectDOMWindowExtensionToGlobalObjectCallback):
2294         (TestWebKitAPI::willDestroyGlobalObjectForDOMWindowExtensionCallback):
2295
2296         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
2297         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Make this method static, as it always should have been.
2298
2299         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2300
2301 2012-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2302
2303         [GTK] Build and run TestWebKitAPI unit tests
2304         https://bugs.webkit.org/show_bug.cgi?id=84325
2305
2306         Reviewed by Philippe Normand.
2307
2308         We only build WTF unit tests for now. WebKit2 tests will be
2309         enabled in a follow up patch.
2310
2311         * Scripts/run-gtk-tests:
2312         (TestRunner): Add TestWebKitAPI/WTF to the list of directories
2313         containing unit tests.
2314         (TestRunner._run_test_glib): Run glib tests using gtester.
2315         (TestRunner._run_test_google): Run google tests.
2316         (TestRunner._run_test): Use _run_test_glib or _run_test_google
2317         depending on whether given test is glib or google test
2318         * TestWebKitAPI/GNUmakefile.am: Added.
2319         * TestWebKitAPI/config.h: Use #ifdef instead of # to fix a compile
2320         warning with -Wundef. Include WebKit2 headers only when building
2321         WebKit2.
2322
2323 2012-04-24  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
2324
2325         [Qt][WK2] Convert touch-point area
2326         https://bugs.webkit.org/show_bug.cgi?id=84434
2327
2328         Reviewed by Kenneth Rohde Christiansen.
2329
2330         Fix failing test after r114917 by also adding the new EventSender API
2331         to WebKitTestRunner.
2332
2333         * WebKitTestRunner/EventSenderProxy.h:
2334         (EventSenderProxy):
2335         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2336         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2337         (WTR::EventSendingController::setTouchPointRadius):
2338         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2339         (EventSendingController):
2340         * WebKitTestRunner/TestController.cpp:
2341         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2342         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
2343         (WTR::EventSenderProxy::addTouchPoint):
2344         (WTR::EventSenderProxy::updateTouchPoint):
2345         (WTR::EventSenderProxy::setTouchPointRadius):
2346         (WTR::EventSenderProxy::clearTouchPoints):
2347
2348 2012-04-24  Mikhail Naganov  <mnaganov@chromium.org>
2349
2350         [Chromium] Unreviewed test expectations update.
2351         https://bugs.webkit.org/show_bug.cgi?id=84726
2352
2353         Mark webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer.test_start_cmd as failing on Windows.
2354
2355         * Scripts/webkitpy/test/test_finder.py:
2356         (TestFinder._default_names):
2357
2358 2012-04-24  Christophe Dumez  <christophe.dumez@intel.com>
2359
2360         [EFL] Enable Web Timing
2361         https://bugs.webkit.org/show_bug.cgi?id=84705
2362
2363         Reviewed by Tony Gentilcore.
2364
2365         Enable web timing by default whenever build-webkit is used.
2366
2367         * Scripts/build-webkit:
2368
2369 2012-04-23  Eriq Augustine  <eaugusti@chromium.org>
2370
2371         Return value from executed script in Chromium.
2372         https://bugs.webkit.org/show_bug.cgi?id=79851
2373
2374         Reviewed by Adam Barth.
2375
2376         Adding a function to LayoutTestController that evaluates a script in
2377         an isolated wold an returns the result of the evaluation.
2378
2379         * DumpRenderTree/LayoutTestController.cpp:
2380         (evaluateScriptInIsolatedWorldAndReturnValue):
2381         (LayoutTestController::staticFunctions):
2382         * DumpRenderTree/LayoutTestController.h:
2383         (LayoutTestController):
2384         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2385         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
2386         * DumpRenderTree/chromium/LayoutTestController.cpp:
2387         (LayoutTestController::LayoutTestController):
2388         (LayoutTestController::setXSSAuditorEnabled):
2389         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
2390         * DumpRenderTree/chromium/LayoutTestController.h:
2391         (LayoutTestController):
2392         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2393         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
2394         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2395         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
2396         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2397         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
2398         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2399         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
2400         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2401         (LayoutTestController):
2402         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2403         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
2404         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2405         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
2406
2407 2012-04-23  Dirk Pranke  <dpranke@chromium.org>
2408
2409         run-perf-tests fail intermittently with an exception
2410         https://bugs.webkit.org/show_bug.cgi?id=83532
2411
2412         Reviewed by Ryosuke Niwa.
2413
2414         This bulletproofs port.get_option('child_processes')
2415         against the case where the option wasn't set.
2416
2417         * Scripts/webkitpy/layout_tests/port/mac.py:
2418         (MacPort._get_crash_log):
2419         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2420         (test_get_crash_log):
2421         (test_get_crash_log.fake_time_cb):
2422
2423 2012-04-23  Balazs Kelemen  <kbalazs@webkit.org>
2424
2425         [Qt] Add desktop zooming support for QQuickWebView
2426         https://bugs.webkit.org/show_bug.cgi?id=82337
2427
2428         Unreviewed typo fix after r114900.
2429
2430         * MiniBrowser/qt/BrowserWindow.cpp:
2431         (BrowserWindow::BrowserWindow): Fix the mistyped
2432         value of a zoom level.
2433
2434 2012-04-23  Hao Zheng  <zhenghao@chromium.org>
2435
2436         [chromium-android] Get rid of the trick that replaces system fallback font with DejaVuSans.
2437         https://bugs.webkit.org/show_bug.cgi?id=84580
2438
2439         Reviewed by Ojan Vafai.
2440
2441         Android's first fallback font is changed to DroidSansArabic.ttf in JB.
2442         Take the opportunity to get rid of the trick.
2443
2444         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2445         (ChromiumAndroidPort.start_helper):
2446         (ChromiumAndroidPort._push_fonts):
2447
2448 2012-04-23  Dirk Pranke  <dpranke@chromium.org>
2449
2450         test-webkitpy is failing
2451         https://bugs.webkit.org/show_bug.cgi?id=84617
2452
2453         Reviewed by Eric Seidel.
2454
2455         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
2456         (HttpLockTestWithRealFileSystem.clean_all_lockfile):
2457
2458 2012-04-23  Ojan Vafai  <ojan@chromium.org>
2459
2460         Split up flakiness_dashboard.html into multiple files. This is a step in the direction
2461         of making the code more maintainable (e.g. being able to use qunit for testing).
2462
2463         * TestResultServer/static-dashboards/dashboard_base.js:
2464         * TestResultServer/static-dashboards/flakiness_dashboard.css: Added.
2465         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2466         * TestResultServer/static-dashboards/flakiness_dashboard.js: Copied from Tools/TestResultServer/static-dashboards/flakiness_dashboard.html.
2467         * TestResultServer/static-dashboards/flakiness_dashboard_tests.css: Added.
2468         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Renamed from Tools/TestResultServer/static-dashboards/flakiness_dashboard_tests.js.
2469
2470 2012-04-23  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
2471
2472         [Qt][WK2] Convert touch-point area.
2473         https://bugs.webkit.org/show_bug.cgi?id=84434
2474
2475         Reviewed by Kenneth Rohde Christiansen.
2476
2477         Add feature to set touch-point radius for emitted touch-events.
2478
2479         * DumpRenderTree/qt/EventSenderQt.cpp:
2480         (EventSender::addTouchPoint):
2481         (EventSender::updateTouchPoint):
2482         (EventSender::setTouchPointRadius):
2483         (EventSender::clearTouchPoints):
2484         * DumpRenderTree/qt/EventSenderQt.h:
2485         (EventSender):
2486
2487 2012-04-23  Christophe Dumez  <christophe.dumez@intel.com>
2488
2489         [EFL] EFL's LayoutTestController does not implement elementDoesAutoCompleteForElementWithId
2490         https://bugs.webkit.org/show_bug.cgi?id=84425
2491
2492         Reviewed by Antonio Gomes.
2493
2494         Use the new helper in DumpRenderTreeSupportEfl to properly
2495         test whether an element performs autocompletion.
2496
2497         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2498         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
2499
2500 2012-04-23  Csaba Osztrogonác  <ossy@webkit.org>
2501
2502         master.cfg cleanup, remove dead codes after r92792.
2503         https://bugs.webkit.org/show_bug.cgi?id=84433
2504
2505         Relanding r114881 after typo fix in UploadBuiltProduct.
2506
2507         Reviewed by Ryosuke Niwa.
2508
2509         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2510
2511 2012-04-23  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
2512
2513         [EFL][DRT] Need to support requestAnimationFrame
2514         https://bugs.webkit.org/show_bug.cgi?id=84585
2515
2516         Reviewed by Martin Robinson.
2517
2518         Making requestAnimationFrame() support a default on the EFL build.
2519
2520         * Scripts/build-webkit:
2521
2522 2012-04-23  Balazs Kelemen  <kbalazs@webkit.org>
2523
2524         [Qt] Add desktop zooming support for QQuickWebView
2525         https://bugs.webkit.org/show_bug.cgi?id=82337
2526
2527         Reviewed by Simon Hausmann.
2528
2529         Add zooming support for MiniBrowser to
2530         test the new API.
2531
2532         * MiniBrowser/qt/BrowserWindow.cpp:
2533         (BrowserWindow::BrowserWindow):
2534         (BrowserWindow::zoomIn):
2535         (BrowserWindow::zoomOut):
2536         (BrowserWindow::keyPressEvent):
2537         (BrowserWindow::wheelEvent):
2538         * MiniBrowser/qt/BrowserWindow.h:
2539         (BrowserWindow):
2540
2541 2012-04-23  Csaba Osztrogonác  <ossy@webkit.org>
2542
2543         Unreviewed rolling out r114881, because it broke upload buildstep.
2544
2545         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2546         (ConfigureBuild.__init__):
2547         (ConfigureBuild.start):
2548         (CompileWebKit.start):
2549         (UploadBuiltProduct):
2550         (UploadBuiltProduct.determineExtraFeatures):
2551         (Factory.__init__):
2552         (BuildFactory.__init__):
2553         (TestFactory.__init__):
2554         (loadBuilderConfig):
2555
2556 2012-04-23  Csaba Osztrogonác  <ossy@webkit.org>
2557
2558         master.cfg cleanup, remove dead codes after r92792.
2559         https://bugs.webkit.org/show_bug.cgi?id=84433
2560
2561         Reviewed by Ryosuke Niwa.
2562
2563         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2564
2565 2012-04-23  Milian Wolff  <mail@milianw.de>
2566
2567         [Qt] Make DRT not dump pixel results if test is calling layoutTestController.dumpAsText()
2568         https://bugs.webkit.org/show_bug.cgi?id=84327
2569
2570         Reviewed by Csaba Osztrogonác.
2571
2572         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2573         (WebCore::DumpRenderTree::dump):
2574
2575 2012-04-22  Sriram Neelakandan  <sriram.neelakandan@gmail.com>
2576
2577         [Gtk] Added MOZ_X11 build flag for TARGET_X11
2578         https://bugs.webkit.org/show_bug.cgi?id=40785
2579
2580         Reviewed by Anders Carlsson.
2581
2582         * GNUmakefile.am:
2583
2584 2012-04-22  Zan Dobersek  <zandobersek@gmail.com>
2585
2586         [TestResultsServer] Impossible to inspect builds on non-Chromium builders
2587         https://bugs.webkit.org/show_bug.cgi?id=84544
2588
2589         Reviewed by Ryosuke Niwa.
2590
2591         Use the groupEnum parameter that is passed through to the onBuilderListLoad
2592         function rather than an undefined attribute of the BuilderGroup object. This
2593         makes it again possible to inspect builds on non-Chromium builders in the
2594         test results server by not trying to always add Chromium revision links.
2595
2596         * TestResultServer/static-dashboards/builders.js:
2597
2598 2012-04-20  Martin Robinson  <mrobinson@igalia.com>
2599
2600         [GTK] Revert changes that disabled Cairo fonts metrics hinting
2601         https://bugs.webkit.org/show_bug.cgi?id=84502
2602
2603         Reviewed by Daniel Bates.
2604
2605         Re-enable Cairo metrics hinting, which seems to ensure consistent results in
2606         reference and pixel test results. This makes our font metrics a bit different
2607         than the Mac port's, but it's a decent price to pay for consistent results.
2608
2609         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2610         (initializeGtkFontSettings):
2611         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2612         (WTR::initializeGtkSettings):
2613
2614 2012-04-04  Jer Noble  <jer.noble@apple.com>
2615
2616         apple.com top navigation bar appears inside video during full screen exit animation
2617         https://bugs.webkit.org/show_bug.cgi?id=83095
2618
2619         Reviewed by Eric Carlson.
2620
2621         Add a new LayoutTestController function, setHasCustomFullScreenBehavior(), which allows scripts to
2622         disable the standard full screen behavior, and replace it with explicit callbacks to the relevant
2623         Document methods from within the script.  This allows subtle timing bugs to be consistently reproduced
2624         from within LayoutTests.
2625
2626         Add the new methods, hasCustomFullScreenBehavior() and setHasCustomFullScreenBehavior():
2627         * DumpRenderTree/LayoutTestController.cpp:
2628         (setHasCustomFullScreenBehaviorCallback):
2629         (LayoutTestController::staticFunctions):
2630         * DumpRenderTree/LayoutTestController.h:
2631         (LayoutTestController::setHasCustomFullScreenBehavior):
2632         (LayoutTestController::hasCustomFullScreenBehavior):
2633         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2634         (WTR::InjectedBundlePage::enterFullScreenForElement):
2635         (WTR::InjectedBundlePage::exitFullScreenForElement):
2636         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2637         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2638         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2639         (WTR::LayoutTestController::setHasCustomFullScreenBehavior):
2640         (WTR::LayoutTestController::hasCustomFullScreenBehavior):
2641         * DumpRenderTree/chromium/LayoutTestController.cpp:
2642         (LayoutTestController::LayoutTestController):
2643         (LayoutTestController::reset):
2644         * DumpRenderTree/chromium/LayoutTestController.h:
2645         (LayoutTestController::setHasCustomFullScreenBehavior):
2646         (LayoutTestController::hasCustomFullScreenBehavior):
2647
2648         Query the new methods before calling will/did/Enter/ExitFullScreen:
2649         * DumpRenderTree/chromium/WebViewHost.cpp:
2650         (WebViewHost::enterFullScreenNow):
2651         (WebViewHost::exitFullScreenNow):
2652         * DumpRenderTree/mac/UIDelegate.mm:
2653         (-[UIDelegate webView:enterFullScreenForElement:listener:]):
2654         (-[UIDelegate webView:exitFullScreenForElement:listener:]):
2655
2656 2012-04-20  Nandor Huszka  <hnandor@inf.u-szeged.hu>
2657
2658         NRWT: option --skip-pixel-test-if-no-baseline support on DRT
2659         https://bugs.webkit.org/show_bug.cgi?id=72841
2660
2661         Reviewed by Dirk Pranke
2662
2663         This patch implements support for --skip-pixel-test-if-no-baseline generically in NRWT,
2664         instead of in every DRT and WTR implementation. We add 'should_run_pixel_test'
2665         and 'reference_files' fields to the TestInput objects, and use those flags
2666         to select the right driver to use in the DriverProxy.
2667
2668         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2669         (SingleTestRunner.__init__):
2670         (SingleTestRunner._driver_input):
2671         (SingleTestRunner._run_reftest):
2672         * Scripts/webkitpy/layout_tests/controllers/worker.py:
2673         (Worker.handle_test_list):
2674         (Worker._update_test_input):
2675         * Scripts/webkitpy/layout_tests/models/test_input.py:
2676         (TestInput):
2677         (TestInput.__init__):
2678         (TestInput.__repr__):
2679         * Scripts/webkitpy/layout_tests/port/chromium.py:
2680         (ChromiumDriver._wrapper_options):
2681         (ChromiumDriver.run_test):
2682         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2683         (ChromiumDriverTest.test_crash_log):
2684         * Scripts/webkitpy/layout_tests/port/driver.py:
2685         (DriverInput.__init__):
2686         (Driver.__init__):
2687         (DriverProxy.__init__):
2688         (DriverProxy.run_test):
2689         (DriverProxy.start):
2690         (DriverProxy.cmd_line):
2691         * Scripts/webkitpy/layout_tests/port/gtk.py:
2692         (GtkDriver._start):
2693         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2694         (MockDRT.run):
2695         (MockDRT.input_from_line):
2696         (MockDRT.output_for_test):
2697         (MockDRT.write_test_output):
2698         (MockChromiumDRT.input_from_line):
2699         (MockChromiumDRT.output_for_test):
2700         (MockChromiumDRT.write_test_output):
2701         * Scripts/webkitpy/layout_tests/port/webkit.py:
2702         (WebKitDriver.cmd_line):
2703         (WebKitDriver.run_test):
2704         * WebKitTestRunner/TestController.cpp:
2705         (WTR::TestController::TestController):
2706         (WTR::TestController::initialize):
2707         (WTR::TestController::runTest):
2708         * WebKitTestRunner/TestController.h:
2709         (TestController):
2710         * WebKitTestRunner/TestInvocation.cpp:
2711         (WTR::TestInvocation::TestInvocation):
2712         (WTR::TestInvocation::setIsPixelTest):
2713         * WebKitTestRunner/TestInvocation.h:
2714         (TestInvocation):
2715
2716 2012-04-20  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2717
2718         [EFL] Make it possible to define offline storage quota per origin
2719         https://bugs.webkit.org/show_bug.cgi?id=84170
2720
2721         Improved LayoutTestController::setDatabaseQuota to set quota based on
2722         origin which was causing some tests to fail. Also align the default
2723         quota for testing (5MB) with others ports.
2724
2725         When dumpDatabaseCallbacks is set to true by, also dump some database
2726         information when quota is exceed, which is also required by some tests.
2727
2728         Reviewed by Antonio Gomes.
2729
2730         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2731         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2732         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2733         (onExceededDatabaseQuota):
2734         (drtViewAdd):
2735         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2736         (LayoutTestController::setDatabaseQuota):
2737
2738 2012-04-20  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2739
2740         [EFL] [DRT] Send double click event from EventSender
2741         https://bugs.webkit.org/show_bug.cgi?id=82867
2742
2743         Reviewed by Daniel Bates.
2744
2745         Add support for EFL DumpRenderTree EventSender to send
2746         double click events.
2747
2748         * DumpRenderTree/efl/EventSender.cpp:
2749         (sendMouseEvent):
2750
2751 2012-04-20  Sergio Villar Senin  <svillar@igalia.com>
2752
2753         [GTK] Enable Web Timing
2754         https://bugs.webkit.org/show_bug.cgi?id=42432
2755
2756         Reviewed by Gustavo Noronha Silva.
2757
2758         Build web timing by default whenever build-webkit is used.
2759
2760         * Scripts/build-webkit:
2761
2762 2012-04-20  Kamil Blank  <k.blank@samsung.com>
2763
2764         [EFL] Add missing reset for setAuthorAndUserStylesEnabled inside DRT.
2765         https://bugs.webkit.org/show_bug.cgi?id=84430
2766
2767         Reviewed by Daniel Bates.
2768
2769         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2770         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2771
2772 2012-04-20  Ryosuke Niwa  <rniwa@webkit.org>
2773
2774         REGRESSION(r112781): Windows build slaves are no longer including .pdb files in archives handed to testers
2775         https://bugs.webkit.org/show_bug.cgi?id=84424
2776
2777         Reviewed by Mark Rowe.
2778
2779         Let Windows and Chromium have their own list of files to copy.
2780
2781         * BuildSlaveSupport/built-product-archive:
2782         (removeDirectoryIfExists):
2783         (copyBuildFiles):
2784         (archiveBuiltProduct):
2785
2786 2012-04-20  Kamil Blank  <k.blank@samsung.com>
2787
2788         [EFL] Add setting API for author and user styles.
2789         https://bugs.webkit.org/show_bug.cgi?id=82860
2790
2791         Reviewed by Daniel Bates.
2792
2793         Implementation of setAuthorAndUserStylesEnabled.
2794
2795         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2796         (LayoutTestController::setAuthorAndUserStylesEnabled):
2797
2798 2012-04-19  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2799
2800         [EFL] Missing keycode translation for space key
2801         https://bugs.webkit.org/show_bug.cgi?id=84153
2802
2803         Reviewed by Antonio Gomes.
2804
2805         Set keyname for space key before dispatching event.
2806
2807         * DumpRenderTree/efl/EventSender.cpp:
2808         (keyNameFromJSValue):
2809
2810 2012-04-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2811
2812         [GTK] Allow to use WebInspector in GtkLauncher
2813         https://bugs.webkit.org/show_bug.cgi?id=84143
2814
2815         Reviewed by Martin Robinson.
2816
2817         * GNUmakefile.am: Add new files to compilation.
2818         * GtkLauncher/LauncherInspectorWindow.c: Added.
2819         (launcherInspectorWindowFinalize):
2820         (launcher_inspector_window_init):
2821         (launcher_inspector_window_class_init):
2822         (inspectedURIChanged): Update the window title based on current
2823         inspected URI.
2824         (showInspectorWindow): Show inspector window.
2825         (closeInspectorWindow): Hide inspector window.
2826         (launcherInspectorWindowNew): Create an inspector window.
2827         (launcherInspectorWindowGetWebView): Return the inspected web view.
2828         * GtkLauncher/LauncherInspectorWindow.h: Added.
2829         * GtkLauncher/main.c:
2830         (inspectorInspectWebViewCb): Create an inspector window.
2831         (createBrowser): Connect to inspect-web-view signal of the view
2832         inspector.
2833
2834 2012-04-19  Jeremy Mao  <yujie.mao@intel.com>
2835
2836         Media Stream API: Piece of code cleanup for the chromium port
2837         https://bugs.webkit.org/show_bug.cgi?id=84328
2838
2839         Reviewed by Kent Tamura.
2840
2841         WebUserMediaClientMock use an old requestUserMedia interface and
2842         Replace it with the new interface.
2843
2844         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
2845         (WebKit::WebUserMediaClientMock::requestUserMedia):
2846         Remove the old requestUserMedia and replace it with the new.
2847         * DumpRenderTree/chromium/WebUserMediaClientMock.h:
2848         (WebUserMediaClientMock):
2849
2850 2012-04-19  Christophe Dumez  <christophe.dumez@intel.com>
2851
2852         [EFL] DRT console messages should contain only the file name part of local URIs
2853         https://bugs.webkit.org/show_bug.cgi?id=84236
2854
2855         Reviewed by Kentaro Hara.
2856
2857         Process console messages before printing them in EFL's DumpRenderTree
2858         them so that they contain only the file name part of local URIs. This
2859         is what is expected by test cases.
2860
2861         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2862         (urlSuitableForTestResult):
2863         (onConsoleMessage):
2864
2865 2012-04-19  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2866
2867         [EFL] [DRT] Should create offline storage inside DUMPRENDERTREE_TEMP
2868         https://bugs.webkit.org/show_bug.cgi?id=84169
2869
2870         All databases were being created inside ~/.webkit which was causing
2871         flaky tests when running multiple tests in parallel, specially timeouts
2872         due to concurrency.
2873
2874         Reviewed by Eric Seidel.
2875
2876         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2877         (DumpRenderTreeChrome::initialize):
2878
2879 2012-04-19  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
2880
2881         [GTK] 3 fast/ layout tests failing after upgrading libsoup to 2.37.92
2882         https://bugs.webkit.org/show_bug.cgi?id=82484
2883
2884         Reviewed by Martin Robinson.
2885
2886         Bumping libsoup to version 2.38.1 which fixes the above WebKit bug.
2887
2888         * efl/jhbuild.modules:
2889         * gtk/jhbuild.modules:
2890
2891 2012-04-19  Lucas Forschler  <lforschler@apple.com>
2892
2893         Move apple-xserve-10 from Lion Test to SnowLeopard Debug Build
2894         
2895         * BuildSlaveSupport/build.webkit.org-config/config.json:
2896
2897 2012-04-19  Christophe Dumez  <christophe.dumez@intel.com>
2898
2899         [EFL] dispatchDidCancelClientRedirect needs implementation
2900         https://bugs.webkit.org/show_bug.cgi?id=83669
2901
2902         Reviewed by Antonio Gomes.
2903
2904         Catch the new ewk_frame "redirect,cancelled" signal in EFL's DRT and
2905         and print out information that is expected by several test cases if
2906         LayoutTestController's dumpFrameLoadCallback() returns true.
2907
2908         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2909         (DumpRenderTreeChrome::createView):
2910         (DumpRenderTreeChrome::onFrameCreated):
2911         (DumpRenderTreeChrome::onFrameRedirectCancelled):
2912         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
2913         (DumpRenderTreeChrome):
2914
2915 2012-04-18  Hironori Bono  <hbono@chromium.org>
2916
2917         Split SpellChecker::didCheck() to SpellChecker::didCheckSucceeded() and SpellChecker::didCheckCanceled()
2918         https://bugs.webkit.org/show_bug.cgi?id=83748
2919
2920         Reviewed by Ryosuke Niwa.
2921
2922         This change replaces a call for SpellChecker::didCheck() with one for
2923         SpellChecker::didCheckCenceled() because didCheck() has been split into
2924         didCheckSucceeded() and didCheckCanceled().
2925
2926         * DumpRenderTree/chromium/WebViewHost.cpp:
2927         (WebViewHost::requestCheckingOfText): Replaced didCheck with didCheckCanceled.
2928
2929 2012-04-18  Dirk Pranke  <dpranke@chromium.org>
2930
2931         Fix failure in test-webkitpy after r114583.
2932
2933         Unreviewed, build fix.
2934
2935         Updating the call site in r114583 w/o updating the test caused
2936         the test to fail. Somehow I forgot to run the unit tests :(.
2937
2938         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2939         (ChromiumDriverTest.test_crash_log):
2940
2941 2012-04-18  Filip Pizlo  <fpizlo@apple.com>
2942
2943         JSC testing should have complete coverage over typed array types
2944         https://bugs.webkit.org/show_bug.cgi?id=84302
2945
2946         Reviewed by Geoff Garen.
2947         
2948         Made run-fast-jsc print something and a newline if jsc threw an exception or
2949         otherwise returned with an error code, but did not crash.
2950
2951         * Scripts/run-fast-jsc:
2952
2953 2012-04-18  Dirk Pranke  <dpranke@chromium.org>
2954
2955         Fix crash in chromium.py after r114877.
2956
2957         Unreviewed, build fix.
2958
2959         Missed updating one call site for get_crash_log() :(.
2960
2961         * Scripts/webkitpy/layout_tests/port/chromium.py:
2962         (ChromiumDriver.run_test):
2963
2964 2012-04-18  Philippe Normand  <pnormand@igalia.com>
2965
2966         [GTK] NRWT bails out if more than one X server runs on the machine
2967         https://bugs.webkit.org/show_bug.cgi?id=84276
2968
2969         Reviewed by Dirk Pranke.
2970
2971         Set up GTK driver's Xvfb display number based on Xorg servers
2972         currently running.
2973
2974         * Scripts/webkitpy/layout_tests/port/gtk.py:
2975         (GtkDriver._start):
2976         (GtkDriver._start.x_filter):
2977
2978 2012-04-18  Dirk Pranke  <dpranke@chromium.org>
2979
2980         run-webkit-tests picked up an old crash log
2981         https://bugs.webkit.org/show_bug.cgi?id=84196
2982
2983         Reviewed by Ryosuke Niwa.
2984
2985         Modify the crash log-finding code so that we can
2986         limit our search to logs newer than X - this prevents
2987         us from finding old crash logs for a given process/pid
2988         combination even when the PIDs might've wrapped.
2989  
2990         Also fix a bug in filesystem_mock where files_under() would
2991         return paths that didn't exist.
2992
2993         * Scripts/webkitpy/common/system/crashlogs.py:
2994         (CrashLogs.find_newest_log):
2995         (CrashLogs._find_newest_log_darwin):
2996         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2997         (CrashLogsTest.test_find_log_darwin):
2998         (CrashLogsTest.test_find_log_darwin.bad_read):
2999         (CrashLogsTest):
3000         * Scripts/webkitpy/common/system/filesystem_mock.py:
3001         (MockFileSystem.files_under):
3002         * Scripts/webkitpy/layout_tests/port/base.py:
3003         (Port._get_crash_log):
3004         * Scripts/webkitpy/layout_tests/port/gtk.py:
3005         (GtkPort._get_crash_log):
3006         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3007         * Scripts/webkitpy/layout_tests/port/mac.py:
3008         (MacPort._get_crash_log):
3009         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3010         (PortTestCase.test_get_crash_log):
3011         * Scripts/webkitpy/layout_tests/port/webkit.py:
3012         (WebKitDriver.run_test):
3013
3014 2012-04-18  Dirk Pranke  <dpranke@chromium.org>
3015
3016         nrwt: support additional test expectations files
3017         https://bugs.webkit.org/show_bug.cgi?id=84222
3018
3019         Reviewed by Ojan Vafai.
3020
3021         This patch adds an --additional-expectations flag that can be
3022         used to point to more files that will override the default set
3023         of expectations. This will allow us to remove the
3024         'google_chrome' ports and eventually help to clean up override
3025         handling in the chromium ports and unify expectations files and
3026         Skipped files; this can also be used to specify overrides for
3027         tests that run differently on a given machine.
3028
3029         * Scripts/webkitpy/layout_tests/port/base.py:
3030         (Port.test_expectations_overrides):
3031         * Scripts/webkitpy/layout_tests/port/chromium.py:
3032         (ChromiumPort.test_expectations_overrides):
3033         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3034         (parse_args):
3035         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3036         (MainTest.test_additional_expectations):
3037
3038 2012-04-18  Jer Noble  <jer.noble@apple.com>
3039
3040         Lion Production Test failing with error: "Failed to stop httpd: pid file still exists"
3041         https://bugs.webkit.org/show_bug.cgi?id=84177
3042
3043         Reviewed by Dirk Pranke.
3044
3045         Try to delete the pid file left by Apache in the case it was killed forcefully.
3046
3047         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3048         (LayoutTestApacheHttpd._stop_running_server):
3049
3050 2012-04-18  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
3051
3052         Clean-up WheelEvent Conversion.
3053         https://bugs.webkit.org/show_bug.cgi?id=84243
3054
3055         Reviewed by Simon Hausmann.
3056         
3057         Calculate proper wheel-delta from pixel-delta given.
3058
3059         * DumpRenderTree/qt/EventSenderQt.cpp:
3060         (EventSender::EventSender):
3061         (EventSender::mouseScrollBy):
3062         (EventSender::continuousMouseScrollBy):
3063
3064 2012-04-18  Sheriff Bot  <webkit.review.bot@gmail.com>
3065
3066         Unreviewed, rolling out r114506.
3067         http://trac.webkit.org/changeset/114506
3068         https://bugs.webkit.org/show_bug.cgi?id=84254
3069
3070         Seems to be making gtk's DumpRenderTree crash occasionally
3071         (Requested by tomz on #webkit).
3072
3073         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3074         (resetDefaultsToConsistentValues):
3075
3076 2012-04-18  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3077
3078         [CMake] Use jsc target instead of ONLY_BUILD_JAVASCRIPTCORE
3079         https://bugs.webkit.org/show_bug.cgi?id=84229
3080
3081         CMake caches ONLY_BUILD_JAVASCRIPTCORE=1 and will reuse the setting for
3082         subsequent builds, stopping WebCore from being built ever again.
3083
3084         Instead of trying to emulate a build target using command line options,
3085         just build the existing jsc target directly.
3086
3087         Reviewed by Rob Buis.
3088
3089         * Scripts/build-jsc:
3090
3091 2012-04-18  Simon Pena  <spena@igalia.com>
3092
3093         [GTK] r114021 triggered media flakyness
3094         https://bugs.webkit.org/show_bug.cgi?id=83874
3095
3096         Reviewed by Philippe Normand.
3097
3098         Now that there is gtk API to update the
3099         MediaPlaybackRequiresUserGesture property, set it to false from the
3100         DumpRenderTree tool when resetting defaults to consistent values.
3101
3102         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3103         (resetDefaultsToConsistentValues):
3104
3105 2012-04-18  Vivek Galatage  <vivekgalatage@gmail.com>
3106
3107         Web Inspector: Disabling Inspector causes build failure on Windows
3108         https://bugs.webkit.org/show_bug.cgi?id=83557
3109
3110         Reviewed by Pavel Feldman.
3111
3112         The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
3113         This change brings all such API calls under the guard.
3114
3115         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3116         (WTR::LayoutTestController::showWebInspector):
3117         (WTR::LayoutTestController::closeWebInspector):
3118         (WTR::LayoutTestController::evaluateInWebInspector):
3119         (WTR::LayoutTestController::setJavaScriptProfilingEnabled):
3120         * WebKitTestRunner/TestInvocation.cpp:
3121         (WTR::TestInvocation::invoke):
3122
3123 2012-04-18  Mario Sanchez Prada  <msanchez@igalia.com>
3124
3125         [GTK] atk/textChangedNotifications API test fails
3126         https://bugs.webkit.org/show_bug.cgi?id=84010
3127
3128         Unreviewed, unskipping test after bug being fixed by r114311.
3129
3130         * Scripts/run-gtk-tests:
3131         (TestRunner): Unskip now passing test.
3132
3133 2012-04-17  Jacky Jiang  <zhajiang@rim.com>
3134
3135         [BlackBerry] Viewport metatag doesn't disable double-tap zoom
3136         https://bugs.webkit.org/show_bug.cgi?id=84199
3137
3138         Reviewed by George Staikos.
3139
3140         Revert a part of the change master_32/SHA:fa0f8ee9 and use
3141         WebPage::setUserScalable instead.
3142
3143         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3144         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
3145
3146 2012-04-17  Dirk Pranke  <dpranke@chromium.org>
3147
3148         build-webkit: make ninja work with chromium linux
3149         https://bugs.webkit.org/show_bug.cgi?id=84213
3150
3151         Reviewed by Eric Seidel.
3152
3153         Fix typos so that build-webkit will use ninja to
3154         build chromium if a build.ninja file exists and is up-to-date.
3155
3156         * Scripts/webkitdirs.pm:
3157         (determineIsChromiumNinja):
3158
3159 2012-04-17  Ojan Vafai  <ojan@chromium.org>
3160
3161         Add caching to the flakiness dashboard json files
3162         https://bugs.webkit.org/show_bug.cgi?id=84198
3163
3164         Reviewed by Dirk Pranke.
3165
3166         * TestResultServer/handlers/testfilehandler.py:
3167         (GetFile._get_file_list):
3168         (GetFile._get_file_content):
3169         (GetFile._get_file_content_from_key):
3170         (GetFile._get_test_list_json):
3171         (GetFile._serve_json):
3172         Add a Last-Modified header and handle If-Modified-Since headers.
3173         (GetFile.get):
3174
3175 2012-04-17  Anders Carlsson  <andersca@apple.com>
3176
3177         Need a client callback for when the user tries to interact with an already unresponsive page
3178         https://bugs.webkit.org/show_bug.cgi?id=84201
3179         <rdar://problem/11140862>
3180
3181         Reviewed by Andreas Kling.
3182
3183         Add new client functions.
3184
3185         * MiniBrowser/mac/BrowserWindowController.m:
3186         (-[BrowserWindowController awakeFromNib]):
3187         * WebKitTestRunner/TestController.cpp:
3188         (WTR::TestController::initialize):
3189
3190 2012-04-17  Dirk Pranke  <dpranke@chromium.org>
3191
3192         nrwt: handle stopping layout test helper after a ctrl-c cleanly on the chromium port
3193         https://bugs.webkit.org/show_bug.cgi?id=84190
3194
3195         Reviewed by Ojan Vafai.
3196
3197         LayoutTestHelper would exit when the user typed ctrl-c, but we
3198         would attempt to write to it to shut it down, generating an
3199         IOError.
3200
3201         * Scripts/webkitpy/layout_tests/port/chromium.py:
3202         (ChromiumPort.stop_helper):
3203
3204 2012-04-17  Dirk Pranke  <dpranke@chromium.org>
3205
3206         rename --experimental-fully-parallel
3207         https://bugs.webkit.org/show_bug.cgi?id=84188
3208
3209         Reviewed by Ojan Vafai.
3210
3211         I thought this was done long ago; rename
3212         --experimental-fully-parallel to just --fully-parallel and
3213         remove the --no- switch that AFAIK no one uses.
3214
3215         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3216         (Manager._run_tests):
3217         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3218         (parse_args):
3219
3220 2012-04-17  Christophe Dumez  <christophe.dumez@intel.com>
3221
3222         EFL's LayoutTestController does not implement callShouldCloseOnWebView
3223         https://bugs.webkit.org/show_bug.cgi?id=82301
3224
3225         Reviewed by Martin Robinson.
3226
3227         Implement callShouldCloseOnWebView in EFL's LayoutTestController by
3228         calling shouldClose() on the FrameLoader, allowing the related test
3229         to be removed from the skip list.
3230
3231         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3232         (LayoutTestController::callShouldCloseOnWebView):
3233
3234 2012-04-17  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3235
3236         [EFL] Add setting API to enable/disable XSSAuditor
3237         https://bugs.webkit.org/show_bug.cgi?id=83281
3238
3239         Add missing implementation setXSSAuditorEnabled to EFL's LayoutTestController
3240         in order to unskip tests in http/tests/security/xssAuditor. Also, catch the signal 
3241         'xss,detected' in DRT to enable a test, which is expecting a line containing
3242         'didDetectXSS' in the output when reflected XSS is encountered in the page.
3243
3244         Reviewed by Antonio Gomes.
3245
3246         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3247         (DumpRenderTreeChrome::createView):
3248         (DumpRenderTreeChrome::onFrameCreated):
3249         (DumpRenderTreeChrome::onDidDetectXSS):
3250         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
3251         (DumpRenderTreeChrome):
3252         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3253         (LayoutTestController::setXSSAuditorEnabled):
3254
3255 2012-04-17  Nandor Huszka  <hnandor@inf.u-szeged.hu>
3256
3257         [Qt] JSC build should handle --no-webkit2 option to avoid unwanted clean-builds
3258         https://bugs.webkit.org/show_bug.cgi?id=77533
3259
3260         Reviewed by Simon Hausmann.
3261
3262         Pick up the --no-webkit2 option from BUILD_WEBKIT_ARGS and pass on
3263         the corresponding parameter to the buildQMakeProjects function.
3264
3265         * Scripts/build-jsc:
3266
3267 2012-04-17  Christophe Dumez  <christophe.dumez@intel.com>
3268
3269         [EFL] DRT should support LayoutTestController's dumpFrameLoadCallbacks()
3270         https://bugs.webkit.org/show_bug.cgi?id=83030
3271
3272         Reviewed by Antonio Gomes.
3273
3274         Implement support for LayoutTestController's dumpFrameLoadCallbacks()
3275         in EFL's DumpRenderTree. Make use of the new frame argument passed to
3276         the "load,started" and "load,finished" signals.
3277
3278         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3279         (DumpRenderTreeChrome::createView):
3280         (DumpRenderTreeChrome::onLoadStarted):
3281         (DumpRenderTreeChrome::processWork):
3282         (DumpRenderTreeChrome::topLoadingFrameLoadFinished):
3283         (DumpRenderTreeChrome::onWebViewOnloadEvent):
3284         (DumpRenderTreeChrome::onInsecureContentRun):
3285         (DumpRenderTreeChrome::onInsecureContentDisplayed):
3286         (DumpRenderTreeChrome::onFrameCreated):
3287         (DumpRenderTreeChrome::onFrameProvisionalLoad):
3288         (DumpRenderTreeChrome::onFrameLoadCommitted):
3289         (DumpRenderTreeChrome::onFrameLoadFinished):
3290         (DumpRenderTreeChrome::onFrameLoadError):
3291         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
3292         (DumpRenderTreeChrome):
3293
3294 2012-04-17  Sheriff Bot  <webkit.review.bot@gmail.com>
3295
3296         Unreviewed, rolling out r114376.
3297         http://trac.webkit.org/changeset/114376
3298         https://bugs.webkit.org/show_bug.cgi?id=84155
3299
3300         Wrong patch version committed, asked by the patch author.
3301         (Requested by rakuco on #webkit).
3302
3303         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3304         (DumpRenderTreeChrome::createView):
3305         (DumpRenderTreeChrome::processWork):
3306         (DumpRenderTreeChrome::onLoadFinished):
3307         (DumpRenderTreeChrome::onWillSendRequest):
3308         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
3309         (DumpRenderTreeChrome):
3310
3311 2012-04-17  Christophe Dumez  <christophe.dumez@intel.com>
3312
3313         [EFL] DRT should support LayoutTestController's dumpFrameLoadCallbacks()
3314         https://bugs.webkit.org/show_bug.cgi?id=83030
3315
3316         Reviewed by Antonio Gomes.
3317
3318         Implement support for LayoutTestController's dumpFrameLoadCallbacks()
3319         in EFL's DumpRenderTree.
3320
3321         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3322         (DumpRenderTreeChrome::createView):
3323         (DumpRenderTreeChrome::processWork):
3324         (DumpRenderTreeChrome::topLoadingFrameLoadFinished):
3325         (DumpRenderTreeChrome::onWebViewOnloadEvent):
3326         (DumpRenderTreeChrome::onInsecureContentRun):
3327         (DumpRenderTreeChrome::onInsecureContentDisplayed):
3328         (DumpRenderTreeChrome::onFrameCreated):
3329         (DumpRenderTreeChrome::onFrameProvisionalLoad):
3330         (DumpRenderTreeChrome::onFrameLoadCommitted):
3331         (DumpRenderTreeChrome::onFrameLoadFinished):
3332         (DumpRenderTreeChrome::onFrameLoadError):
3333         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
3334         (DumpRenderTreeChrome):
3335
3336 2012-04-17  Michael Brüning  <michael.bruning@nokia.com>
3337
3338         [Qt] Fix builds with force_static_libs_as_shared for non-linux builds.
3339         https://bugs.webkit.org/show_bug.cgi?id=83035
3340
3341         Reviewed by Simon Hausmann.
3342
3343         The force_static_libs_as_shared feature for the Qt port will remove
3344         hide_symbols from Qt's CONFIG in order to make them visible to other
3345         libraries again.
3346
3347         Due to an evaluation order problem in qmake, the flags for the C++ compiler
3348         that are set by adding hide_symbols to the CONFIG variables get applied
3349         to qmake's C++ compiler flags directly and hence trying to remove these
3350         later will not work and cause build failures when using the force_static_libs_as_shared
3351         feature of the Qt port.
3352
3353         This is fixed by removing the flags that hide the exports from the compiler flags directly.
3354
3355         * qmake/mkspecs/features/force_static_libs_as_shared.prf:
3356
3357 2012-04-16  Ryosuke Niwa  <rniwa@webkit.org>
3358
3359         Remove CreateWebKitBuildDirectory step to fix Chromium Windows Perf bot
3360         https://bugs.webkit.org/show_bug.cgi?id=84068
3361
3362         Reviewed by Eric Seidel.
3363
3364         Remove CreateWebKitBuildDirectory from master.cfg since download-built-product
3365         automatically creates the build directory if needed.
3366
3367         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3368         (DownloadAndPerfTestFactory.__init__):
3369         (DownloadAndPerfTestWebKit2Factory.__init__):
3370
3371 2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>
3372
3373         [GTK] Use configure instead of autogen.sh for gtk+
3374         https://bugs.webkit.org/show_bug.cgi?id=84112
3375
3376         Rubber-stamped by Martin Robinson.
3377
3378         * gtk/jhbuild.modules: GTK+'s autogen requires gobject-introspection;
3379         we don't want to depend on that for now, so run configure instead - we
3380         can, since we are using a tarball
3381
3382 2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>
3383
3384         Unreviewed, rolling out r114322.
3385         http://trac.webkit.org/changeset/114322
3386         https://bugs.webkit.org/show_bug.cgi?id=84096
3387
3388         Didn't make the debug bot happy, so back out
3389
3390         * gtk/jhbuild.modules:
3391
3392 2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>
3393
3394         [GTK] Try to fix debug bot by adding gobject-introspection to the build
3395         https://bugs.webkit.org/show_bug.cgi?id=84096
3396
3397         Unreviewed speculative build fix.
3398
3399         * gtk/jhbuild.modules: Added gobject-introspection, since modules need
3400         an up-to-date introspection m4 for running autogen.
3401
3402 2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>
3403
3404         [GTK] Add pango to jhbuild
3405         https://bugs.webkit.org/show_bug.cgi?id=84086
3406
3407         Unreviewed build fix.
3408
3409         * gtk/jhbuild.modules: Add pango's latest stable release, 1.30, to our
3410         jhbuild environment. It's required for latest stable GTK+ and some
3411         systems may lack it.
3412
3413 2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>
3414
3415         [GTK] fonts jhbuild module needs an empty clean target
3416         https://bugs.webkit.org/show_bug.cgi?id=84085
3417
3418         Rubber-stamped by Martin Robinson.
3419
3420         * gtk/jhbuild.modules: update to webkitgtk-test-fonts 0.0.2, which
3421         includes a phony clean target that should make warnings and errors go
3422         away.
3423
3424 2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>
3425
3426         [GTK] Bump dependency on GTK+ 3.x to match reality
3427         https://bugs.webkit.org/show_bug.cgi?id=84060
3428
3429         Rubber-stamped by Martin Robinson.
3430
3431         * gtk/jhbuild.modules: Bump GTK+ to 3.4.0, plus glib and gdk-pixbuf
3432         to their GNOME 3.4 versions.
3433         * gtk/patches/gtk+-3.0.12-gtkprinter.patch: Removed. This patch
3434         is applied upstream.
3435
3436 2012-04-16  Vincent Scheib  <scheib@chromium.org>
3437
3438         Adding Contributors Brian Salomon and Tom Hudson to committers.py.
3439
3440         Unreviewed.
3441
3442         * Scripts/webkitpy/common/config/committers.py:
3443
3444 2012-04-16  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
3445
3446         [BlackBerry] Add ability for DRT to handle HTTP authentication challenges.
3447         https://bugs.webkit.org/show_bug.cgi?id=84031
3448
3449         Reviewed by Rob Buis.
3450
3451         Implemented interface function didReceiveAuthenticationChallenge in class
3452         DumpRenderTree.
3453
3454         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3455         (drtCredentialDescription):
3456         (BlackBerry::WebKit::DumpRenderTree::didReceiveAuthenticationChallenge):
3457         (WebKit):
3458         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
3459         (WebCore):
3460         (DumpRenderTree):
3461
3462 2012-04-16  Philippe Normand  <pnormand@igalia.com>
3463
3464         build-webkit --gtk --no-webkit2 builds WK2
3465         https://bugs.webkit.org/show_bug.cgi?id=83977
3466
3467         Reviewed by Martin Robinson.
3468
3469         * Scripts/build-webkit: Fixup ./configure option to disable
3470         WebKit2 build.
3471
3472 2012-04-16  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3473
3474         [EFL] [DRT] Feeding key events with invalid keyName
3475         https://bugs.webkit.org/show_bug.cgi?id=83797
3476
3477         Keep the keyName valid within scope of KeyEventInfo to avoid
3478         feeding key events with invalid keyName.
3479
3480         Reviewed by Philippe Normand.
3481
3482         * DumpRenderTree/efl/EventSender.cpp:
3483         (KeyEventInfo::KeyEventInfo):
3484         (KeyEventInfo):
3485         (keyPadNameFromJSValue):
3486         (keyNameFromJSValue):
3487         (createKeyEventInfo):
3488         (sendKeyDown):
3489
3490 2012-04-16  Andras Piroska  <pandras@inf.u-szeged.hu>
3491
3492         [Qt] Replace QtXmlPatterns usage with libxslt dependency
3493         <https://bugs.webkit.org/show_bug.cgi?id=76820>
3494
3495         Reviewed by Simon Hausmann.
3496
3497         The features.prf file was modified, in order to use libxml and libxslt by default.
3498         This modification only work at Qt5.
3499
3500         * qmake/config.tests/libxml2/libxml2.cpp: Added.
3501         (main):
3502         * qmake/config.tests/libxml2/libxml2.pro: Added.
3503         * qmake/config.tests/libxslt/libxslt.cpp: Added.
3504         (main):
3505         * qmake/config.tests/libxslt/libxslt.pro: Added.
3506         * qmake/mkspecs/features/features.prf:
3507         * qmake/sync.profile:
3508
3509 2012-04-16  Seokju Kwon  <seokju.kwon@samsung.com>
3510
3511         [EFL] EWebLaucher : Fix wrong parameter order in function call for multiple windows.
3512         https://bugs.webkit.org/show_bug.cgi?id=83862
3513
3514         Reviewed by Kenneth Rohde Christiansen.
3515
3516         EWebLauncher creates multiple windows, like multiple tabs when pressing F9 key.
3517         It doesn't work properly because of wrong parameter order in function call.
3518
3519         * EWebLauncher/main.c:
3520
3521 2012-04-16  Philippe Normand  <pnormand@igalia.com>
3522
3523         Unreviewed, GTK gardening.
3524
3525         * Scripts/run-gtk-tests:
3526         (TestRunner): Skip /webkit/atk/textChangedNotifications.
3527
3528 2012-04-13  Ryosuke Niwa  <rniwa@webkit.org>
3529
3530         Chromium perf bots should not build
3531         https://bugs.webkit.org/show_bug.cgi?id=83641
3532
3533         Reviewed by Eric Seidel.
3534
3535         Don't build on perf bots to improve the cycle time.
3536
3537         * BuildSlaveSupport/build.webkit.org-config/config.json:
3538
3539 2012-04-14  Zalan Bujtas  <zbujtas@gmail.com>
3540
3541         [WK2] Set WebKitTestRunner's WebProcess cache model to DocumentBrowser.
3542         https://bugs.webkit.org/show_bug.cgi?id=81945
3543
3544         Reviewed by Dan Bernstein.
3545
3546         WebProcess's default cache model is DocumentViewer. When DocumentViewer model is on,
3547         the PageCache's capacity is set to 0. Tests that are enabling 'WebKitUsesPageCachePreferenceKey' expect
3548         PageCache to be functional.
3549
3550         * WebKitTestRunner/TestController.cpp:
3551         (WTR::TestController::resetStateToConsistentValues):
3552
3553 2012-04-11  James Robinson  <jamesr@chromium.org>
3554
3555         [chromium] Remove unused compositeToTexture / compositeOffscreen setting
3556         https://bugs.webkit.org/show_bug.cgi?id=83733
3557
3558         Reviewed by Adrienne Walker.
3559
3560         Remove compositeOffscreen / compositeToTexture setting. This was an experiment that is no longer needed.
3561
3562         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3563         (main):
3564         * DumpRenderTree/chromium/TestShell.cpp:
3565         (TestShell::TestShell):
3566         (TestShell::resetWebSettings):
3567         * DumpRenderTree/chromium/TestShell.h:
3568         (TestShell):
3569         * DumpRenderTree/chromium/WebPreferences.cpp:
3570         (WebPreferences::reset):
3571         (WebPreferences::applyTo):
3572         * DumpRenderTree/chromium/WebPreferences.h:
3573         (WebPreferences):
3574
3575 2012-04-13  Ryosuke Niwa  <rniwa@webkit.org>
3576
3577         webkitpy build fix. Revert the debug change (number of runs was 2 instead of 20),
3578         and also rebaseline the test results since we ignore the first run now.
3579
3580         * Scripts/webkitpy/performance_tests/perftest.py:
3581         (PageLoadingPerfTest.run):
3582         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3583         (TestPageLoadingPerfTest.test_run):
3584
3585 2012-04-12  Ryosuke Niwa  <rniwa@webkit.org>
3586
3587         Enable SVG page loading performance tests
3588         https://bugs.webkit.org/show_bug.cgi?id=83861
3589
3590         Reviewed by Adam Barth.
3591
3592         Add support for page loading tests. These are tests without any test running harnesses, and we use
3593         DriverOutput's test_timeout to measure the loading time.
3594
3595         Extracted PerfTest.run and PerfTest.run_failed from PerfTestRunner._run_single_test.
3596
3597         * Scripts/webkitpy/performance_tests/perftest.py:
3598         (PerfTest.run):
3599         (PerfTest):
3600         (PerfTest.run_failed):
3601         (PerfTest.parse_output):
3602         (PerfTest.output_statistics):
3603         (ChromiumStylePerfTest.parse_output):
3604         (PageLoadingPerfTest): Added.
3605         (PageLoadingPerfTest.__init__):
3606         (PageLoadingPerfTest.run): Run the driver 20 times to get the statistics for the loading time.
3607         * Scripts/webkitpy/performance_tests/perftest_unittest.py: Added.
3608         (MockPrinter):
3609         (MockPrinter.__init__):
3610         (MockPrinter.write):
3611         (MainTest):
3612         (MainTest.test_parse_output):
3613         (MainTest.test_parse_output_with_failing_line):
3614         (TestPageLoadingPerfTest):
3615         (TestPageLoadingPerfTest.assertWritten):
3616         (TestPageLoadingPerfTest.MockDriver):
3617         (TestPageLoadingPerfTest.MockDriver.__init__):
3618         (TestPageLoadingPerfTest.MockDriver.run_test):
3619         (TestPageLoadingPerfTest.test_run):
3620         (TestPageLoadingPerfTest.test_run_with_bad_output):
3621         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3622         (PerfTestsRunner):
3623         (PerfTestsRunner._collect_tests._is_test_file): Now recognizes svg tests.
3624         (PerfTestsRunner._collect_tests):
3625         (PerfTestsRunner._run_tests_set):
3626         (PerfTestsRunner._run_single_test):
3627         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3628         (test_collect_tests_with_page_load_svg):
3629         (test_collect_tests_with_page_load_svg.add_file):
3630
3631 2012-04-10  Brady Eidson  <beidson@apple.com>
3632
3633         <rdar://problem/11176921> and https://bugs.webkit.org/show_bug.cgi?id=83600
3634         Need WebKit2 API to notify whether history loads are in the page cache
3635
3636         Add a test ShouldGoToBackForwardListItem that exercises the new BundlePageLoaderClient
3637         callback as well as the new WKBundleBackForwardListItemIsInPageCache() API.
3638
3639         Reviewed by Darin Adler.
3640
3641         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp: Added.
3642         (TestWebKitAPI::didFinishLoadForFrame):
3643         (TestWebKitAPI::willGoToBackForwardListItem):
3644         (TestWebKitAPI::setPageLoaderClient):
3645         (TestWebKitAPI::TEST):
3646         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp: Added.
3647         (ShouldGoToBackForwardListItemTest):
3648         (TestWebKitAPI::shouldGoToBackForwardListItemCallback):
3649         (TestWebKitAPI::ShouldGoToBackForwardListItemTest::ShouldGoToBackForwardListItemTest):
3650         (TestWebKitAPI::ShouldGoToBackForwardListItemTest::didCreatePage):
3651         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3652
3653         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3654         (WTR::InjectedBundlePage::InjectedBundlePage): Update for the new client.
3655
3656 2012-04-13  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
3657