Clicking "Go Back" from a safe browsing warning from an iframe should navigate the...
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-05  Alex Christensen  <achristensen@webkit.org>
2
3         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
4         https://bugs.webkit.org/show_bug.cgi?id=196665
5         <rdar://45115669>
6
7         Reviewed by Geoff Garen.
8
9         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
10         (goBack):
11         (+[SimpleLookupContext sharedLookupContext]):
12         (-[SimpleLookupContext lookUpURL:completionHandler:]):
13         (TEST):
14         (+[Simple3LookupContext sharedLookupContext]): Deleted.
15         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
16
17 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
18
19         [ews-build] Add configuration and architecture for windows builders
20         https://bugs.webkit.org/show_bug.cgi?id=196660
21
22         Reviewed by Lucas Forschler.
23
24         * BuildSlaveSupport/ews-build/config.json:
25
26 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
27
28         webkitpy: Don't run subsequent rounds if interrupted
29         https://bugs.webkit.org/show_bug.cgi?id=196646
30
31         Reviewed by Aakash Jain.
32
33         * Scripts/webkitpy/layout_tests/controllers/manager.py:
34         (Manager.run): Bail out if interrupted.
35
36 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
37
38         Test sessionStorage in PSON private browsing mode
39         https://bugs.webkit.org/show_bug.cgi?id=196561
40
41         Reviewed by Alex Christensen.
42
43         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
44
45 2019-04-05  Commit Queue  <commit-queue@webkit.org>
46
47         Unreviewed, rolling out r243833.
48         https://bugs.webkit.org/show_bug.cgi?id=196645
49
50         This change breaks build of WPE and GTK ports (Requested by
51         annulen on #webkit).
52
53         Reverted changeset:
54
55         "[CMake][WTF] Mirror XCode header directories"
56         https://bugs.webkit.org/show_bug.cgi?id=191662
57         https://trac.webkit.org/changeset/243833
58
59 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
60
61         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
62         https://bugs.webkit.org/show_bug.cgi?id=196635
63
64         Reviewed by Antti Koivisto.
65         
66         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
67         for a test to enable async frame scrolling via:
68             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
69         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
70         
71         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
72
73         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
74         (WTR::InjectedBundle::beginTesting):
75         * WebKitTestRunner/TestController.cpp:
76         (WTR::TestController::resetPreferencesToConsistentValues):
77
78 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
79
80         Use a correct LC_RPATH when building with ASan
81         https://bugs.webkit.org/show_bug.cgi?id=196576
82
83         Reviewed by David Kilzer.
84
85         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
86         so that ../Frameworks is checked. This is simpler and more reliable than updating
87         each SPC service xcconfig.
88
89 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
90
91         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
92         https://bugs.webkit.org/show_bug.cgi?id=196629
93
94         Reviewed by Lucas Forschler.
95
96         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
97
98 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
99
100         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
101         https://bugs.webkit.org/show_bug.cgi?id=196618
102
103         Reviewed by Lucas Forschler.
104
105         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
106         (StatusBubble): Added QUEUE_TRIGGERS.
107         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
108         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
109         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
110         its parent(builder).
111
112 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
113
114         [ews-app] Status-bubble steps are sometimes displayed in reverse order
115         https://bugs.webkit.org/show_bug.cgi?id=196625
116
117         Reviewed by Lucas Forschler.
118
119         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
120         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
121
122 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
123
124         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
125         https://bugs.webkit.org/show_bug.cgi?id=196630
126
127         Reviewed by Wenson Hsieh.
128
129         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
130
131 2019-04-04  Youenn Fablet  <youenn@apple.com>
132
133         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
134         https://bugs.webkit.org/show_bug.cgi?id=196543
135
136         Reviewed by Alex Christensen.
137
138         * WebKitTestRunner/TestController.cpp:
139         (WTR::TestController::generatePageConfiguration):
140
141 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
142
143         [ews-app] Status bubble should not display skipped buildbot steps
144         https://bugs.webkit.org/show_bug.cgi?id=196584
145
146         Reviewed by Lucas Forschler.
147
148         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
149
150 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
151
152         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
153         https://bugs.webkit.org/show_bug.cgi?id=196620
154
155         Reviewed by Lucas Forschler.
156
157         * BuildSlaveSupport/ews-app/ews/config.py:
158
159 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
160
161         [Win] DumpRenderTreeWatchDog.py is not checked into source
162         https://bugs.webkit.org/show_bug.cgi?id=196567
163         <rdar://problem/49525901>
164
165         Reviewed by Lucas Forschler.
166
167         This script is used on Win EWS bots to terminate hanging DRT processes.
168
169         * EWSTools/dumprendertreewatchdog.py: Added.
170
171 2019-04-04  Chris Dumez  <cdumez@apple.com>
172
173         Unreviewed, roll out r243858 which made tests time out.
174
175         Disable new API tests on Windows instead.
176
177         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
178         (TestWebKitAPI::TEST):
179
180 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
181
182         [ATK] Cleanup WebPageAccessibilityObjectAtk
183         https://bugs.webkit.org/show_bug.cgi?id=196537
184
185         Reviewed by Michael Catanzaro.
186
187         Also consider files under atk directories as exceptions for GObject conventions.
188
189         * Scripts/webkitpy/style/checkers/cpp.py:
190         (check_identifier_name_in_declaration):
191
192 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
193
194         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
195         https://bugs.webkit.org/show_bug.cgi?id=196588
196         <rdar://problem/49365787>
197
198         Unreviewed build fix for Windows port.
199
200         error C3861: 'kill': identifier not found
201
202         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
203         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
204
205 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
206
207         [ews-build] Cancel build and similar operations should have authentication
208         https://bugs.webkit.org/show_bug.cgi?id=196520
209
210         Reviewed by Dewei Zhu.
211
212         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
213         environment variables.
214
215 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
216
217         [ews-build] Do not trigger queues which are not in production yet
218         https://bugs.webkit.org/show_bug.cgi?id=196581
219
220         Reviewed by Dewei Zhu.
221
222         * BuildSlaveSupport/ews-build/config.json:
223
224 2019-04-03  Chris Dumez  <cdumez@apple.com>
225
226         Unreviewed, fix typo in the name of API test added in r243848.
227
228         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
229         (TestWebKitAPI::TEST):
230
231 2019-04-03  Chris Dumez  <cdumez@apple.com>
232
233         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
234         https://bugs.webkit.org/show_bug.cgi?id=196588
235         <rdar://problem/49365787>
236
237         Reviewed by Ryosuke Niwa.
238
239         Add API test coverage.
240
241         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
242         (TestWebKitAPI::nullJavaScriptCallback):
243         (TestWebKitAPI::didCrashCheckFrames):
244         (TestWebKitAPI::TEST):
245
246 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
247
248         run-webkit-tests: Upload test results (new results database)
249         https://bugs.webkit.org/show_bug.cgi?id=196577
250         <rdar://problem/34841155>
251
252         Reviewed by Lucas Forschler.
253
254         * Scripts/webkitpy/layout_tests/controllers/manager.py:
255         (Manager.run): Upload results after each device shard, since the configuration will be
256         different for each device.
257         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
258         uploaded to a results database.
259         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
260         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
261
262 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
263
264         -apple-trailing-word is needed for browser detection
265         https://bugs.webkit.org/show_bug.cgi?id=196575
266
267         Unreviewed.
268
269         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
270
271 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
272
273         [CMake][WTF] Mirror XCode header directories
274         https://bugs.webkit.org/show_bug.cgi?id=191662
275
276         Reviewed by Konstantin Tokarev.
277
278         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
279         builds.
280
281         * CMakeLists.txt:
282         * DumpRenderTree/CMakeLists.txt:
283         * DumpRenderTree/PlatformWin.cmake:
284         * MiniBrowser/win/CMakeLists.txt:
285         * TestWebKitAPI/CMakeLists.txt:
286         * TestWebKitAPI/PlatformWin.cmake:
287         * WebKitTestRunner/PlatformGTK.cmake:
288         * WebKitTestRunner/PlatformWin.cmake:
289
290 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
291
292         [ews-app] Status bubble should not display certain infrastructure status messages
293         https://bugs.webkit.org/show_bug.cgi?id=196550
294
295         Reviewed by Lucas Forschler.
296
297         Do not display the steps which are un-needed for end-user. This information is still avaiable
298         if the user click on the bubble and look at the Buildbot build.
299         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
300         (StatusBubble._steps_messages):
301         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
302
303 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
304
305         [ews-build] Use https for sending data to ews-app
306         https://bugs.webkit.org/show_bug.cgi?id=196492
307
308         Reviewed by Lucas Forschler.
309
310         * BuildSlaveSupport/ews-build/events.py:
311
312 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
313
314         Remove support for -apple-trailing-word
315         https://bugs.webkit.org/show_bug.cgi?id=196525
316
317         Reviewed by Zalan Bujtas.
318
319         This CSS property is nonstandard and not used.
320
321         * Scripts/webkitperl/FeatureList.pm:
322         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
323
324 2019-04-03  Youenn Fablet  <youenn@apple.com>
325
326         Add a test for DOMCache on multiple browsing in case of private browsing
327         https://bugs.webkit.org/show_bug.cgi?id=196524
328
329         Reviewed by Alex Christensen.
330
331         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
332         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
333
334 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
335
336         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
337         https://bugs.webkit.org/show_bug.cgi?id=196540
338
339         Reviewed by Aakash Jain.
340
341         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
342
343 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
344
345         Add plumbing for a compatibility mode preference in WebKit
346         https://bugs.webkit.org/show_bug.cgi?id=196005
347
348         Reviewed by Tim Horton.
349
350         Add new API tests.
351
352         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
353         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
354
355 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
356
357         [WPE][GTK] Update libsrtp dependency package for Debian
358         https://bugs.webkit.org/show_bug.cgi?id=196528
359
360         Reviewed by Frédéric Wang.
361
362         * gtk/install-dependencies:
363         * wpe/install-dependencies:
364
365 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
366
367         [WK2] Add support for Window's beforeprint / afterprint events
368         https://bugs.webkit.org/show_bug.cgi?id=196478
369         <rdar://problem/49535124>
370
371         Unreviewed build fix for MSVC.
372
373         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
374
375         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
376
377         * WebKitTestRunner/TestController.cpp:
378         (WTR::printFrame): Use int and float literals.
379
380 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
381
382         [ews-build] Reassign bots to queues
383
384         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
385
386 2019-04-02  Chris Dumez  <cdumez@apple.com>
387
388         [WK2] Add support for Window's beforeprint / afterprint events
389         https://bugs.webkit.org/show_bug.cgi?id=196478
390
391         Reviewed by Alex Christensen.
392
393         Add minimal implementation for printFrame in WebKitTestRunner.
394
395         * WebKitTestRunner/TestController.cpp:
396         (WTR::printFrame):
397         (WTR::TestController::createOtherPage):
398         (WTR::TestController::createWebViewWithOptions):
399
400 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
401
402         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
403         https://bugs.webkit.org/show_bug.cgi?id=196491
404
405         Reviewed by Lucas Forschler.
406
407         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
408
409 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
410
411         [ews-build] Configure buildbot try credentials in environment variables
412         https://bugs.webkit.org/show_bug.cgi?id=196501
413
414         Reviewed by Lucas Forschler.
415
416         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
417         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
418         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
419
420 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
421
422         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
423         https://bugs.webkit.org/show_bug.cgi?id=196496
424         <rdar://problem/49521634>
425
426         Reviewed by Chris Dumez.
427
428         Add new API tests (see WebKit ChangeLog for more detail).
429
430         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
431         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
432         (TEST):
433
434 2019-04-02  David Kilzer  <ddkilzer@apple.com>
435
436         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
437         <https://webkit.org/b/196499>
438
439         Reviewed by Alexey Proskuryakov.
440
441         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
442         ENABLE_ADDRESS_SANITIZER.
443
444 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
445
446         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
447         https://bugs.webkit.org/show_bug.cgi?id=182757
448
449         Reviewed by Don Olmstead.
450
451         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
452         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
453
454 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
455
456         run-api-tests: Upload test results
457         https://bugs.webkit.org/show_bug.cgi?id=196323
458         <rdar://problem/49356714>
459
460         Reviewed by Lucas Forschler.
461
462         * Scripts/webkitpy/api_tests/manager.py:
463         (Manager):
464         (Manager.run): Upload results to a results database.
465         * Scripts/webkitpy/api_tests/run_api_tests.py:
466         (parse_args): Add upload arguments.
467         * Scripts/webkitpy/port/base.py:
468         (Port):
469         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
470         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
471         with commits from any other associated repositories.
472         * Scripts/webkitpy/port/device.py:
473         (Device):
474         (Device.build_version): Access build_versoin of underlying platform device.
475         * Scripts/webkitpy/port/ios_simulator_unittest.py:
476         (IOSSimulatorTest):
477         (IOSSimulatorTest.test_configuration_for_upload):
478         * Scripts/webkitpy/port/device_port.py:
479         (DevicePort):
480         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
481         the same as the machine uploading results.
482         * Scripts/webkitpy/port/mac.py:
483         (MacPort):
484         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
485         * Scripts/webkitpy/port/mac_unittest.py:
486         (MacTest):
487         (MacTest.test_configuration_for_upload):
488         * Scripts/webkitpy/xcode/simulated_device.py:
489         (SimulatedDeviceManager._create_device_with_runtime):
490         (SimulatedDevice.__init__): Create simulated device with a build_version.
491         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
492         (test_existing_simulator):
493
494 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
495
496         Remove extra newline characters (Follow-up fix to r243707)
497
498         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
499
500 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
501
502         [ews-app] Use API_KEY to accept results data
503         https://bugs.webkit.org/show_bug.cgi?id=196461
504
505         Reviewed by Dewei Zhu.
506
507         * BuildSlaveSupport/ews-app/ews/views/results.py:
508         (Results.post): Validate EWS_API_KEY before accepting any data.
509         * BuildSlaveSupport/ews-build/events.py:
510         (Events.sendData): Send EWS_API_KEY if available along with event data.
511
512 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
513
514         Unable to copy and paste a PDF from Notes into Mail compose body
515         https://bugs.webkit.org/show_bug.cgi?id=196442
516         <rdar://problem/48573098>
517
518         Reviewed by Tim Horton.
519
520         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
521         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
522         to be specified on the item providers.
523
524         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
525         (TestWebKitAPI::mapItemForTesting):
526         (TestWebKitAPI::contactItemForTesting):
527
528 2019-04-01  Tim Horton  <timothy_horton@apple.com>
529
530         Make UIWKDocumentContext rects per-character instead of per-word
531         https://bugs.webkit.org/show_bug.cgi?id=196459
532
533         Reviewed by Wenson Hsieh.
534
535         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
536         (TEST):
537         Adjust test results due to switching to per-character rects.
538
539 2019-04-01  Chris Dumez  <cdumez@apple.com>
540
541         UIProcess crash when a prewarmed process is terminated
542         https://bugs.webkit.org/show_bug.cgi?id=196451
543         <rdar://problem/49245471>
544
545         Reviewed by Geoffrey Garen.
546
547         Add API test coverage.
548
549         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
550         (TEST):
551
552 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
553
554         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
555         https://bugs.webkit.org/show_bug.cgi?id=196449
556
557         Reviewed by Lucas Forschler.
558
559         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
560         (StatusBubble.get_os_details): Method to get OS and Xcode details.
561         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
562         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
563
564 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
565
566         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
567         https://bugs.webkit.org/show_bug.cgi?id=196444
568
569         Reviewed by Lucas Forschler.
570
571         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
572
573 2019-04-01  Alex Christensen  <achristensen@webkit.org>
574
575         Add SPI to canonicalize NSURLs with WTF::URL
576         https://bugs.webkit.org/show_bug.cgi?id=196415
577         <rdar://problem/44980271>
578
579         Reviewed by Darin Adler.
580
581         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
582         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
583         (TestWebKitAPI::TEST):
584
585 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
586
587         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
588         https://bugs.webkit.org/show_bug.cgi?id=196441
589
590         Reviewed by Carlos Garcia Campos.
591
592         Don't cache the wpe_view_backend object that might not exist yet at the
593         time of EventSenderProxy constructor invocation, but instead retrieve
594         that object whenever it's required for event dispatching. This should
595         avoid crashes in this constructor now that it's invoked before any
596         PlatformWindow has been set up (as changed in r243496).
597
598         * WebKitTestRunner/EventSenderProxy.h:
599         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
600         (WTR::viewBackend):
601         (WTR::EventSenderProxy::EventSenderProxy):
602         (WTR::EventSenderProxy::mouseDown):
603         (WTR::EventSenderProxy::mouseUp):
604         (WTR::EventSenderProxy::mouseMoveTo):
605         (WTR::EventSenderProxy::mouseScrollBy):
606         (WTR::EventSenderProxy::keyDown):
607         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
608
609 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
610
611         [Win][WebKit] MiniBrowser should support high DPI display
612         https://bugs.webkit.org/show_bug.cgi?id=196391
613
614         Reviewed by Alex Christensen.
615
616         * MiniBrowser/win/WebKitBrowserWindow.cpp:
617         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
618         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
619         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
620
621 2019-03-31  Sam Weinig  <weinig@apple.com>
622
623         Remove more i386 specific configurations
624         https://bugs.webkit.org/show_bug.cgi?id=196430
625
626         Reviewed by Alexey Proskuryakov.
627
628         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
629         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
630
631 2019-03-31  Andy Estes  <aestes@apple.com>
632
633         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
634         https://bugs.webkit.org/show_bug.cgi?id=196433
635         <rdar://problem/49293305>
636
637         Reviewed by Tim Horton.
638
639         Enhanced API test coverage to include all navigation response policy decisions in both
640         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
641
642         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
643         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
644         (TestWebKitAPI::TEST):
645         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
646         (readFile):
647         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
648         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
649         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
650         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
651         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
652         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
653         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
654         (-[QuickLookDelegate _downloadDidStart:]):
655         (-[QuickLookDelegate _download:didReceiveResponse:]):
656         (-[QuickLookDelegate _download:didReceiveData:]):
657         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
658         (-[QuickLookDelegate _downloadDidFinish:]):
659         (-[QuickLookDelegate _download:didFailWithError:]):
660         (-[QuickLookDelegate _downloadDidCancel:]):
661         (-[QuickLookDelegate verifyDownload]):
662         (runTest):
663         (runTestDecideBeforeLoading):
664         (runTestDecideAfterLoading):
665         (TEST):
666         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
667         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
668         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
669         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
670         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
671         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
672         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
673         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
674         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
675         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
676         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
677         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
678         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
679         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
680
681 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
682
683         [CMake] add testdfg as target with build-jsc
684         https://bugs.webkit.org/show_bug.cgi?id=196393
685
686         Reviewed by Saam Barati.
687
688         Added testdfg as one of the targets to build when
689         using CMake.
690
691         * Scripts/build-jsc:
692
693 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
694
695         Delete WebMetal implementation in favor of WebGPU
696         https://bugs.webkit.org/show_bug.cgi?id=195418
697
698         Reviewed by Dean Jackson.
699
700         * DumpRenderTree/mac/DumpRenderTree.mm:
701         (enableExperimentalFeatures):
702         (resetWebPreferencesToConsistentValues):
703         * Scripts/webkitperl/FeatureList.pm:
704         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
705         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
706         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
707         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
708         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
709         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
710         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
711         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
712         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
713         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
714         (WTR::InjectedBundle::beginTesting):
715         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
716         (WTR::TestRunner::setWebMetalEnabled): Deleted.
717         * WebKitTestRunner/InjectedBundle/TestRunner.h:
718
719 2019-03-29  Chris Dumez  <cdumez@apple.com>
720
721         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
722         https://bugs.webkit.org/show_bug.cgi?id=196405
723         <rdar://problem/49428130>
724
725         Reviewed by Wenson Hsieh.
726
727         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
728         the popover presentation methods to be no-ops. Use this in the new test added in
729         r243523 so that we do not swizzle those methods for all tests. This is needed because
730         those WatchOS tests rely on the popover getting presented and interactive.
731
732         * WebKitTestRunner/TestController.cpp:
733         (WTR::updateTestOptionsFromTestHeader):
734         * WebKitTestRunner/TestController.h:
735         * WebKitTestRunner/TestOptions.h:
736         (WTR::TestOptions::hasSameInitializationOptions const):
737         * WebKitTestRunner/ios/TestControllerIOS.mm:
738         (WTR::TestController::platformInitialize):
739         (WTR::TestController::platformResetStateToConsistentValues):
740
741 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
742
743         [Curl] Add Server Trust Evaluation Support.
744         https://bugs.webkit.org/show_bug.cgi?id=191646
745
746         Reviewed by Fujii Hironori.
747
748         Implemented MiniBrowser UI for asking if user trusts the server.
749
750         * MiniBrowser/win/Common.cpp:
751         (askServerTrustEvaluation):
752         (replaceString):
753         * MiniBrowser/win/Common.h:
754         * MiniBrowser/win/MiniBrowserLib.rc:
755         * MiniBrowser/win/MiniBrowserLibResource.h:
756         * MiniBrowser/win/WebKitBrowserWindow.cpp:
757         (createPEMString):
758         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
759         (WebKitBrowserWindow::canTrustServerCertificate):
760         * MiniBrowser/win/WebKitBrowserWindow.h:
761
762 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
763
764         Implement ResizeObserver.
765         https://bugs.webkit.org/show_bug.cgi?id=157743
766
767         Reviewed by Simon Fraser.
768
769         Support resizeObserverEnabled webPreferences.
770
771         * DumpRenderTree/TestOptions.cpp:
772         (TestOptions::TestOptions):
773         * DumpRenderTree/TestOptions.h:
774         * DumpRenderTree/mac/DumpRenderTree.mm:
775         (setWebPreferencesForTestOptions):
776         * DumpRenderTree/win/DumpRenderTree.cpp:
777         (enableExperimentalFeatures):
778         * Scripts/webkitperl/FeatureList.pm:
779         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
780
781 2019-03-28  John Wilander  <wilander@apple.com>
782
783         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
784         https://bugs.webkit.org/show_bug.cgi?id=196281
785         <rdar://problem/48938748>
786
787         Reviewed by Alex Christensen.
788
789         This patch adds the function isStatisticsHasLocalStorage() to the
790         TestRunner. With it, the page can query the WebsiteDataStore in the
791         UI process to make sure that it sees LocalStorage.
792
793         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
794         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
795         (WTR::TestRunner::isStatisticsHasLocalStorage):
796         * WebKitTestRunner/InjectedBundle/TestRunner.h:
797         * WebKitTestRunner/TestController.cpp:
798         (WTR::TestController::isStatisticsHasLocalStorage):
799         * WebKitTestRunner/TestController.h:
800         * WebKitTestRunner/TestInvocation.cpp:
801         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
802
803 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
804
805         API::Data::createWithoutCopying should do a null check before calling CFRelease
806         https://bugs.webkit.org/show_bug.cgi?id=196276
807         <rdar://problem/48059859>
808
809         Reviewed by Alex Christensen.
810
811         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
812
813         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
814         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
815         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
816         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
817         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
818         (TestWebKitAPI::TEST):
819
820 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
821
822         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
823         https://bugs.webkit.org/show_bug.cgi?id=186276
824
825         Reviewed by Carlos Garcia Campos.
826
827         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
828         (webViewLoadChanged):
829         (testWebResourceGetDataError):
830         (testWebResourceGetDataEmpty):
831         (beforeAll):
832         (webViewloadChanged): Deleted.
833
834 2019-03-27  Andy Estes  <aestes@apple.com>
835
836         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
837         https://bugs.webkit.org/show_bug.cgi?id=196317
838
839         Reviewed by Dan Bernstein.
840
841         package-root copies built products into a staging directory using ditto(1), which does not
842         follow symbolic links as it traverses a directory. Now that the files in
843         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
844         itself, these become broken links when ditto'd into the staging directory.
845
846         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
847
848         * Scripts/package-root:
849
850 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
851
852         [ews-app] Update display text of Submit for ews analysis
853         https://bugs.webkit.org/show_bug.cgi?id=196309
854
855         Reviewed by Dewei Zhu.
856
857         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
858
859 2019-03-27  David Kilzer  <ddkilzer@apple.com>
860
861         run-webkit-tests should check for leaks in WebKit processes
862         <https://webkit.org/b/193772>
863         <rdar://problem/46526680>
864
865         Reviewed by Ryosuke Niwa.
866
867         This works by doing the following:
868         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
869           The list of child processes are returned one per line:
870           process.name: pid
871         - Run the "#LIST CHILD PROCESSES" command just before the
872           "#CHECK FOR WORLD LEAKS" command, and store the list of child
873           processes on the ServerProcess object.
874         - When the `--leaks` switch is handled, run check_for_leaks() on
875           each child process after the main test harness.
876
877         * DumpRenderTree/mac/DumpRenderTree.mm:
878         (handleControlCommand):
879         - Use strncmp() instead of strcmp().
880         - Add support for handling "#LIST CHILD PROCESSES" command.
881
882         * Scripts/webkitpy/port/base.py:
883         (Port.check_for_leaks):
884         * Scripts/webkitpy/port/darwin.py:
885         (DarwinPort.check_for_leaks):
886         - Rename redundant 'process_pid' argument to 'process_id'.
887
888         * Scripts/webkitpy/port/driver.py:
889         (Driver.do_post_tests_work):
890         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
891           longer the only command this sends to WebKitTestRunner.
892         - If the `--leaks` switch is present, send the
893           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
894           result using Port.set_webkit_processes().
895         (Driver._parse_child_processes_output):
896         - Add helper method to parse list of child process names and
897           process IDs returned from WebKitTestRunner.
898
899         * Scripts/webkitpy/port/ios_device.py:
900         (IOSDevicePort.check_for_leaks):
901         - Rename redundant 'process_pid' argument to 'process_id'.
902
903         * Scripts/webkitpy/port/leakdetector.py:
904         (LeakDetector._parse_leaks_output):
905         - Return early if there is no leaks_output.
906         (LeakDetector.check_for_leaks):
907         - Rename redundant 'process_pid' argument to 'process_id'.
908
909         * Scripts/webkitpy/port/server_process.py:
910         (ServerProcess.__init__):
911         (ServerProcess.child_processes):
912         (ServerProcess.set_child_processes):
913         - Add instance variable to Port to store list of child process
914           names and process IDs returned from WebKitTestRunner.
915         (ServerProcess._start):
916         - Clear self._child_processes.
917         (ServerProcess.stop):
918         - If self._child_processes is set, call
919           self._port.check_for_leaks() for each child process.
920
921         * Scripts/webkitpy/port/server_process_unittest.py:
922         (TrivialMockPort.check_for_leaks):
923         - Rename redundant 'process_pid' argument to 'process_id'.
924
925         * Scripts/webkitpy/port/simulator_process.py:
926         (SimulatorProcess.stop):
927         - If self._child_processes is set, call
928           self._port.check_for_leaks() for each child process.
929
930         * Scripts/webkitpy/port/watch_device.py:
931         (WatchDevicePort.check_for_leaks):
932         - Rename redundant 'process_pid' argument to 'process_id'.
933
934         * WebKitTestRunner/TestController.cpp:
935         (WTR::TestController::dumpResponse):
936         - Extract method from findAndDumpWorldLeaks() so that it may be
937           reused by findAndDumpWebKitProcessIdentifiers().
938         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
939         - Add method to output process name and process ID of both the
940           WebContent and Networking processes.
941         (WTR::TestController::findAndDumpWorldLeaks):
942         - Fix missing newline in output when there were no abandoned
943           documents.
944         - Call dumpResponse() for extracted code.
945         (WTR::TestController::handleControlCommand):
946         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
947         - Use strncmp() instead of strcmp().
948         - Call findAndDumpWebKitProcessIdentifiers() when
949           "#LIST CHILD PROCESSES" command is sent.
950         * WebKitTestRunner/TestController.h:
951         (WTR::TestController::dumpResponse):
952         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
953         - Declare methods.
954
955 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
956
957         Unreviewed. Add GLib API test cases after r243434.
958
959         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
960         (testWebViewActiveURI):
961         (serverCallback):
962         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
963         (sendRequestCallback):
964
965 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
966
967         Geolocation request not complete when watch request was started in a different web process
968         https://bugs.webkit.org/show_bug.cgi?id=195996
969
970         Reviewed by Alex Christensen.
971
972         Add a test case.
973
974         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
975         (TestWebKitAPI::runJavaScriptAlert):
976         (TestWebKitAPI::TEST):
977
978 2019-03-26  Keith Rollin  <krollin@apple.com>
979
980         Update the way generate-xcfilelists returns strings from functions
981         https://bugs.webkit.org/show_bug.cgi?id=195975
982         <rdar://problem/49040807>
983
984         Reviewed by Dean Jackson.
985
986         There are places where generate-xcfilelists executes assignments with
987         statements like:
988
989             FOO=$(some_function)
990
991         where "some_function" return a string by echoing it. E.g.
992
993             some_function()
994             {
995                 echo "Hello, World"
996             }
997
998         This is a common idiom, but it has a problem if "some_function" needs
999         to call "exit" in an attempt to halt the entire script right then and
1000         there. Since "some_function" is called inside of $(), it's being
1001         executed in a sub-shell. Calling exit in that sub-shell simply exits
1002         that shell; it doesn't not exit the outer shell in which the main part
1003         of the script is still running. As such, the main script keeps
1004         executing when the intent was for the script to halt.
1005
1006         The solution to this is to use a different idiom for returning
1007         strings. The one we now is to pass in the name of the variable to
1008         receive the string result:
1009
1010             some_function()
1011             {
1012                 variable_name=$1
1013                 eval $variable_name ="Hello, World"
1014             }
1015
1016         The call site now looks like
1017
1018             some_function FOO
1019
1020         Because there's no invocation of a sub-shell, some_function can now
1021         call "exit" if it wants to, and the entire script will exit at that
1022         point.
1023
1024         * Scripts/generate-xcfilelists:
1025
1026 2019-03-26  Chris Dumez  <cdumez@apple.com>
1027
1028         Add basic layout test coverage for File Picker on iOS
1029         https://bugs.webkit.org/show_bug.cgi?id=196265
1030
1031         Reviewed by Wenson Hsieh.
1032
1033         Add layout test infrastructure to test the file picker on iOS.
1034
1035         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1036         (WTR::UIScriptController::dismissFilePicker):
1037         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1038         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1039         (WTR::UIScriptController::dismissFilePicker):
1040         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1041         * WebKitTestRunner/TestController.cpp:
1042         (WTR::TestController::createWebViewWithOptions):
1043         (WTR::updateTestOptionsFromTestHeader):
1044         * WebKitTestRunner/TestOptions.h:
1045         (WTR::TestOptions::hasSameInitializationOptions const):
1046         * WebKitTestRunner/ios/TestControllerIOS.mm:
1047         (overridePresentViewController):
1048         (WTR::TestController::platformInitialize):
1049         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1050         (WTR::UIScriptController::dismissFilePicker):
1051
1052 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1053
1054         Implement async paste method on UIWKInteractionViewProtocol
1055         https://bugs.webkit.org/show_bug.cgi?id=196267
1056         <rdar://problem/49236346>
1057
1058         Reviewed by Tim Horton.
1059
1060         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1061         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1062         are now a part of all iOS 12 internal SDKs.
1063
1064         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1065
1066         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1067         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1068
1069         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1070         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1071         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1072         * TestWebKitAPI/ios/UIKitSPI.h:
1073
1074 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1075
1076         [ews-build] Use PostgreSQL for ews.webkit.org database
1077         https://bugs.webkit.org/show_bug.cgi?id=196270
1078
1079         Reviewed by Lucas Forschler.
1080
1081         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1082
1083 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1084
1085         [ews] Reset simctl states on reboot
1086         https://bugs.webkit.org/show_bug.cgi?id=196260
1087
1088         Rubber-stamped by Aakash Jain.
1089
1090         * EWSTools/start-queue-mac.sh:
1091
1092 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1093
1094         [ews-build] Use PostgreSQL for ews-build database
1095         https://bugs.webkit.org/show_bug.cgi?id=196229
1096
1097         Reviewed by Lucas Forschler.
1098
1099         * BuildSlaveSupport/ews-build/master.cfg:
1100
1101 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1102
1103         [ews-build] Get master_hostname dynamically in master.cfg
1104         https://bugs.webkit.org/show_bug.cgi?id=196255
1105
1106         Reviewed by Lucas Forschler.
1107
1108         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1109         send events data in test mode.
1110
1111 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1112
1113         [ews-app] Set db_constraint to False for Foreign Keys
1114         https://bugs.webkit.org/show_bug.cgi?id=196252
1115
1116         Reviewed by Lucas Forschler.
1117
1118         * BuildSlaveSupport/ews-app/ews/models/build.py:
1119         * BuildSlaveSupport/ews-app/ews/models/step.py:
1120
1121 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1122
1123         [ews-build] is_test_mode_enabled should default to True
1124         https://bugs.webkit.org/show_bug.cgi?id=196248
1125
1126         Reviewed by Lucas Forschler.
1127
1128         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1129
1130 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1131
1132         [ews-app] Add webkitperl to ENABLED_QUEUES
1133         https://bugs.webkit.org/show_bug.cgi?id=196253
1134
1135         Reviewed by Lucas Forschler.
1136
1137         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1138
1139 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1140
1141         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1142         https://bugs.webkit.org/show_bug.cgi?id=196211
1143         rdar://problem/49110552
1144
1145         Reviewed by Tim Horton.
1146
1147         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1148         Make sure that EventSenderProxy always exists when running tests. We used to create
1149         it when resetting before the first test, which is a bit too late.
1150
1151         * WebKitTestRunner/TestController.h:
1152         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1153         (WTR::TestController::platformCreateWebView):
1154         (WTR::TestController::platformCreateOtherPage):
1155         (WTR::TestController::finishCreatingPlatformWebView):
1156         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1157         (WTR::PlatformWebView::PlatformWebView):
1158         Moved some code that made NSWindow use NSEvent during web view creation. We may
1159         need to move more if some other case us found, but this is enough for now.
1160
1161 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1162
1163         Unreviewed. Fix typo in GLib geolocation API after r243285.
1164
1165         gelocation -> geolocation.
1166
1167         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1168         (testGeolocationManagerWatchPosition):
1169
1170 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1171
1172         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1173         https://bugs.webkit.org/show_bug.cgi?id=196213
1174
1175         Reviewed by Geoff Garen.
1176
1177         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1178         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1179         (credentialWithIdentityAndKeychainPath):
1180         (-[ChallengeDelegate webView:didFinishNavigation:]):
1181         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1182         (TestWebKitAPI::TEST):
1183
1184 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1185
1186         Expected shouldn't assume its contained types are copyable
1187         https://bugs.webkit.org/show_bug.cgi?id=195986
1188
1189         Reviewed by JF Bastien.
1190
1191         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1192         (TestWebKitAPI::NonCopyable::operator== const):
1193         (TestWebKitAPI::NonCopyable::operator!= const):
1194         (TestWebKitAPI::TEST):
1195
1196 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1197
1198         Remove some now-unnecessary dynamic class lookup
1199         https://bugs.webkit.org/show_bug.cgi?id=196237
1200
1201         Reviewed by Simon Fraser.
1202
1203         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1204         (makeRequest):
1205         (TEST):
1206
1207 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1208
1209         Unreviewed, rolling out r243450.
1210
1211         AppleWin and WinCairo port builds get broken.
1212
1213         Reverted changeset:
1214
1215         "Add test for fix of #196095"
1216         https://bugs.webkit.org/show_bug.cgi?id=196097
1217         https://trac.webkit.org/changeset/243450
1218
1219 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1220
1221         Unreviewed, rolling out r243465.
1222         https://bugs.webkit.org/show_bug.cgi?id=196226
1223
1224         the test doesn't build (Requested by thorton on #webkit).
1225
1226         Reverted changeset:
1227
1228         "Do not terminate the NetworkProcess if a third party
1229         application sends a NSCredential with a SecIdentityRef"
1230         https://bugs.webkit.org/show_bug.cgi?id=196213
1231         https://trac.webkit.org/changeset/243465
1232
1233 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1234
1235         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1236         https://bugs.webkit.org/show_bug.cgi?id=196213
1237
1238         Reviewed by Geoff Garen.
1239
1240         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1241         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1242         (credentialWithIdentityAndKeychainPath):
1243         (-[ChallengeDelegate webView:didFinishNavigation:]):
1244         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1245         (TestWebKitAPI::TEST):
1246
1247 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1248
1249         [ews-build] Gracefully handle missing patch_id in events
1250         https://bugs.webkit.org/show_bug.cgi?id=196216
1251
1252         Reviewed by Lucas Forschler.
1253
1254         * BuildSlaveSupport/ews-build/events.py:
1255
1256 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1257
1258         [ews-build] use lz4 compression for improving buildbot performance
1259         https://bugs.webkit.org/show_bug.cgi?id=196155
1260
1261         Reviewed by Lucas Forschler.
1262
1263         * BuildSlaveSupport/ews-build/master.cfg:
1264
1265 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1266
1267         Pull some API testing helper methods out of TestWKWebView
1268         https://bugs.webkit.org/show_bug.cgi?id=196212
1269
1270         Reviewed by Tim Horton.
1271
1272         Refactor some more API testing utility methods, so that they can be used in
1273         tests that do not use TestWKWebView.
1274
1275         * TestWebKitAPI/cocoa/TestWKWebView.h:
1276         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1277         (-[WKWebView loadTestPageNamed:]):
1278         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1279         (-[WKWebView synchronouslyLoadHTMLString:]):
1280         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1281         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1282         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1283         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1284         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1285
1286 2019-03-25  Jer Noble  <jer.noble@apple.com>
1287
1288         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1289         https://bugs.webkit.org/show_bug.cgi?id=196097
1290
1291         Reviewed by Eric Carlson.
1292
1293         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1294
1295         * DumpRenderTree/mac/DumpRenderTree.mm:
1296         (resetWebPreferencesToConsistentValues):
1297         * WebKitTestRunner/TestController.cpp:
1298         (WTR::TestController::resetPreferencesToConsistentValues):
1299
1300 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1301
1302         Pull IPadUserInterfaceSwizzler out into a separate header file
1303         https://bugs.webkit.org/show_bug.cgi?id=196193
1304
1305         Reviewed by Anders Carlsson.
1306
1307         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1308         be used in other API tests.
1309
1310         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1311         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1312         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1313         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1314         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1315         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1316         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1317
1318 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1319
1320         Remove NavigatorContentUtils in WebCore/Modules
1321         https://bugs.webkit.org/show_bug.cgi?id=196070
1322
1323         Reviewed by Alex Christensen.
1324
1325         NavigatorContentUtils was to support the custom scheme spec [1].
1326         However, in WebKit side, no port has supported the feature in
1327         WebKit layer after EFL port was removed. So there has been the
1328         only IDL implementation of the NavigatorContentUtils in WebCore.
1329         So we don't need to keep the implementation in WebCore anymore.
1330
1331         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1332
1333         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1334
1335 2019-03-24  Andy Estes  <aestes@apple.com>
1336
1337         [watchOS] Remove unused Proximity Networking code
1338         https://bugs.webkit.org/show_bug.cgi?id=196188
1339
1340         Reviewed by Tim Horton.
1341
1342         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1343         (TEST):
1344
1345 2019-03-23  Keith Miller  <keith_miller@apple.com>
1346
1347         Refactor clz/ctz and fix getLSBSet.
1348         https://bugs.webkit.org/show_bug.cgi?id=196162
1349
1350         Reviewed by Saam Barati.
1351
1352         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1353
1354         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1355         (TestWebKitAPI::TEST):
1356
1357 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1358
1359         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1360         https://bugs.webkit.org/show_bug.cgi?id=196143
1361
1362         Reviewed by Michael Catanzaro.
1363
1364         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1365         directories.
1366
1367         * Scripts/webkitpy/style/checkers/cpp.py:
1368         (check_identifier_name_in_declaration):
1369         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1370         (WebKitStyleTest.test_names):
1371
1372 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1373
1374         [Flatpak] Manifest expanding fails for qt WPE extension
1375         https://bugs.webkit.org/show_bug.cgi?id=196148
1376
1377         Reviewed by Alex Christensen.
1378
1379         * flatpak/flatpakutils.py:
1380         (expand_submodules_recurse): The last recurse manifest expand
1381         iteration might lead to a single module so take it into account
1382         and don't try to recurse further.
1383
1384 2019-03-22  Chris Dumez  <cdumez@apple.com>
1385
1386         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1387         https://bugs.webkit.org/show_bug.cgi?id=195348
1388         <rdar://problem/48622090>
1389
1390         Reviewed by Alex Christensen.
1391
1392         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1393         to NO when test.options().shouldIgnoreMetaViewport is false.
1394
1395         * WebKitTestRunner/ios/TestControllerIOS.mm:
1396         (WTR::TestController::platformConfigureViewForTest):
1397
1398 2019-03-22  Chris Dumez  <cdumez@apple.com>
1399
1400         Prewarmed processes should be usable with any website data store
1401         https://bugs.webkit.org/show_bug.cgi?id=196104
1402
1403         Reviewed by Alex Christensen.
1404
1405         Add API test coverage.
1406
1407         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1408         (runInitialWarmedProcessUsedTest):
1409         (TEST):
1410
1411 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1412
1413         Back out local changes to Alex's Subversion working directory
1414
1415         They were accidentally committed.
1416
1417         * Scripts/webkitpy/common/system/abstractexecutive.py:
1418         (AbstractExecutive.wait_newest):
1419         * Scripts/webkitpy/common/system/executive.py:
1420         (Executive.running_pids):
1421         * Scripts/webkitpy/common/system/executive_mock.py:
1422         (MockExecutive.running_pids):
1423         * Scripts/webkitpy/common/system/executive_unittest.py:
1424         (ExecutiveTest.serial_test_running_pids):
1425         * Scripts/webkitpy/port/darwin.py:
1426         (DarwinPort.check_for_leaks):
1427         * Scripts/webkitpy/port/leakdetector.py:
1428         (LeakDetector.check_for_leaks):
1429         - This was the hack attached to Bug 193772.
1430
1431         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1432         (+[WebKitTestRunnerEvent mouseLocation]):
1433         - This works around a crash on an internal build.
1434
1435 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1436
1437         Fix the build after r243354
1438         https://bugs.webkit.org/show_bug.cgi?id=196138
1439         <rdar://problem/49145951>
1440
1441         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1442         (TEST):
1443         * TestWebKitAPI/ios/UIKitSPI.h:
1444
1445 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1446
1447         Adopt UIWKDocumentContext
1448         https://bugs.webkit.org/show_bug.cgi?id=196040
1449         <rdar://problem/48642440>
1450
1451         Reviewed by Ryosuke Niwa.
1452
1453         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1454         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1455         (makeRequest):
1456         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1457         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1458         (applyStyle):
1459         (TEST):
1460         Add tests for UIWKDocumentContext.
1461
1462         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1463         (TEST):
1464         (recursiveFindWKContentView): Deleted.
1465         * TestWebKitAPI/cocoa/TestWKWebView.h:
1466         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1467         (recursiveFindWKContentView):
1468         (-[TestWKWebView wkContentView]):
1469         * TestWebKitAPI/ios/UIKitSPI.h:
1470         Share the WKContentView finding code between tests.
1471
1472 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1473
1474         [iOS WK2] Turn on async overflow scrolling by default
1475         https://bugs.webkit.org/show_bug.cgi?id=196011
1476         rdar://problem/48453859
1477
1478         Reviewed by Antti Koivisto.
1479         
1480         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1481         since so many basic layout tests have different results when compositing is triggered for
1482         overflow.
1483         
1484         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1485
1486         * WebKitTestRunner/TestController.cpp:
1487         (WTR::TestController::resetPreferencesToConsistentValues):
1488
1489 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1490
1491         [ews-build] Retry API test in case of failures
1492         https://bugs.webkit.org/show_bug.cgi?id=196004
1493
1494         Reviewed by Lucas Forschler.
1495
1496         * BuildSlaveSupport/ews-build/steps.py:
1497         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1498         (CompileWebKitToT.doStepIf): Ditto.
1499         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1500         (ReRunAPITests): Re-run API tests.
1501         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1502         (RunAPITestsWithoutPatch): Run API tests without patch.
1503         (RunAPITestsWithoutPatch.doStepIf):
1504         (RunAPITestsWithoutPatch.hideStepIf):
1505         (RunAPITestsWithoutPatch.evaluateCommand):
1506         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1507         (AnalyzeAPITestsResults.start):
1508         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1509         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1510         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1511         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1512
1513 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1514
1515         [ews-build] Update queues configurations
1516         https://bugs.webkit.org/show_bug.cgi?id=196074
1517
1518         Reviewed by Dewei Zhu.
1519
1520         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1521         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1522
1523 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1524
1525         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1526         https://bugs.webkit.org/show_bug.cgi?id=195680
1527         <rdar://problem/48903534>
1528
1529         Unreviewed infrastructure fix.
1530
1531         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1532         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1533
1534 2019-03-21  Andy Estes  <aestes@apple.com>
1535
1536         [iOS] Apple Pay should be available in documents with no user agent scripts
1537         https://bugs.webkit.org/show_bug.cgi?id=196061
1538         <rdar://problem/48649391>
1539
1540         Reviewed by Brady Eidson.
1541
1542         Added API tests and related infrastructure.
1543
1544         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1545         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1546         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1547         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1548         (TestWebKitAPI::TEST):
1549         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1550         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1551         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1552         * TestWebKitAPI/cocoa/TestProtocol.mm:
1553         (-[TestProtocol startLoading]):
1554         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1555         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1556         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1557         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1558
1559 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1560
1561         REGRESSSION (r243297): webkitpy tests broken
1562         https://bugs.webkit.org/show_bug.cgi?id=196108
1563
1564         Reviewed by Aakash Jain.
1565
1566         r243297 updated contributors.json, which broke a few unit tests.
1567
1568         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1569         (IRCCommandTest.test_whois):
1570         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1571
1572 2019-03-21  Chris Dumez  <cdumez@apple.com>
1573
1574         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1575         https://bugs.webkit.org/show_bug.cgi?id=196041
1576         <rdar://problem/49083230>
1577
1578         Reviewed by Alex Christensen.
1579
1580         Add API test coverage.
1581
1582         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1583         (TEST):
1584
1585 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1586
1587         Add SPI to inform applications of WKContentRuleList actions
1588         https://bugs.webkit.org/show_bug.cgi?id=195965
1589         <rdar://problem/42664365>
1590
1591         Reviewed by Geoff Garen.
1592
1593         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1594         (TestWebKitAPI::allActionsForResourceLoad):
1595         (TestWebKitAPI::testRequest):
1596         (TestWebKitAPI::TEST_F):
1597         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1598         (Notification::description):
1599         (Notification::operator== const):
1600         (toVector):
1601         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1602         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1603         (makeContentRuleList):
1604         (TEST):
1605         (makeWarnContentRuleList): Deleted.
1606
1607 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1608
1609         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1610         https://bugs.webkit.org/show_bug.cgi?id=196088
1611
1612         Reviewed by Brian Burg.
1613
1614         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1615         Support checks when only one platform is specified. Also deprecate macosx() and
1616         force the use of macos() instead.
1617
1618         * Scripts/webkitpy/style/checkers/cpp.py:
1619         (check_min_versions_of_wk_api_available):
1620         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1621         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1622
1623 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1624
1625         Update status inactive committers' status to 'contributor'.
1626
1627         * Scripts/webkitpy/common/config/contributors.json:
1628
1629 2019-03-21  Xan Lopez  <xan@igalia.com>
1630
1631         [JSC][x86] Drop support for x87 floating point
1632         https://bugs.webkit.org/show_bug.cgi?id=194853
1633
1634         Reviewed by Don Olmstead.
1635
1636         Force SSE2 on x86/32bit builds.
1637
1638         * Scripts/webkitdirs.pm:
1639         (generateBuildSystemFromCMakeProject):
1640
1641 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1642
1643         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1644         https://bugs.webkit.org/show_bug.cgi?id=196073
1645
1646         Reviewed by Michael Catanzaro.
1647
1648         Add test cases to check functions and constructors with no arguments but receiving user data.
1649
1650         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1651         (checkUserData):
1652         (testJSCFunction):
1653         (fooCreateWithUserData):
1654         (testJSCClass):
1655
1656 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1657
1658         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1659
1660         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1661
1662         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1663
1664 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1665
1666         [GTK][WPE] Add API to provide geolocation information
1667         https://bugs.webkit.org/show_bug.cgi?id=195940
1668
1669         Reviewed by Michael Catanzaro.
1670
1671         Add a new test to check the new API.
1672
1673         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1674         (testGeolocationManagerCurrentPosition):
1675         (testGeolocationManagerWatchPosition):
1676         (beforeAll):
1677         (afterAll):
1678         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1679         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1680         (beforeAll): Ditto.
1681         * TestWebKitAPI/glib/CMakeLists.txt:
1682
1683 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1684
1685         [GLib] Returning G_TYPE_OBJECT from a method does not work
1686         https://bugs.webkit.org/show_bug.cgi?id=195574
1687
1688         Reviewed by Michael Catanzaro.
1689
1690         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1691
1692         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1693         (getGFile):
1694         (getParent):
1695         (createGString):
1696         (getGString):
1697         (getGStringCopyWillRaise):
1698         (getGStringCopy):
1699         (getGStringStr):
1700         (getGStringLen):
1701         (freeGString):
1702         (testJSCClass):
1703
1704 2019-03-20  Saam Barati  <sbarati@apple.com>
1705
1706         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1707         https://bugs.webkit.org/show_bug.cgi?id=195721
1708
1709         Reviewed by Filip Pizlo.
1710
1711         * Scripts/run-javascriptcore-tests:
1712
1713 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1714
1715         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
1716         https://bugs.webkit.org/show_bug.cgi?id=196049
1717
1718         Reviewed by Tim Horton.
1719
1720         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
1721         overflow scrolling in general, so rename it.
1722
1723         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1724
1725 2019-03-20  Daniel Bates  <dabates@apple.com>
1726
1727         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
1728         https://bugs.webkit.org/show_bug.cgi?id=196031
1729         <rdar://problem/49078172>
1730
1731         Reviewed by Tim Horton.
1732
1733         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
1734         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
1735         same code path used when the Done button is pressed to dismiss the <select> picker.
1736
1737         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1738         (TestWebKitAPI::TEST):
1739
1740 2019-03-20  Chris Dumez  <cdumez@apple.com>
1741
1742         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
1743         https://bugs.webkit.org/show_bug.cgi?id=196029
1744         <rdar://problem/48954651>
1745
1746         Reviewed by Tim Horton.
1747
1748         Add API test coverage.
1749
1750         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1751
1752 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
1753
1754         [ews-build] Improve failure summary string for ApplyPatch step
1755         https://bugs.webkit.org/show_bug.cgi?id=195995
1756
1757         Reviewed by Alexey Proskuryakov.
1758
1759         * BuildSlaveSupport/ews-build/steps.py:
1760         (ApplyPatch.getResultSummary): Override getResultSummary.
1761
1762 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
1763
1764         AX: Implement support for new meter ARIA role
1765         https://bugs.webkit.org/show_bug.cgi?id=195966
1766
1767         Reviewed by Chris Fleizach.
1768
1769         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
1770         to AXLevelIndicator.
1771
1772         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1773
1774 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
1775
1776         [WebAuthN] Implement FIDO AppID extension
1777         https://bugs.webkit.org/show_bug.cgi?id=143491
1778         <rdar://problem/48298273>
1779
1780         Reviewed by Brent Fulgham.
1781
1782         Add a test that covers the new flag of convertToU2fSignCommand.
1783
1784         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
1785         (TestWebKitAPI::TEST):
1786         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1787         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
1788         (TestWebKitAPI::TEST):
1789
1790 2019-03-19  Keith Rollin  <krollin@apple.com>
1791
1792         Add support for more platforms to generate-xcfilelists
1793         https://bugs.webkit.org/show_bug.cgi?id=195977
1794
1795         Reviewed by Alexey Proskuryakov.
1796
1797         generate-xcfilelists incorrectly complains when involved with building
1798         WebKit for iphonesimulator:
1799
1800             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
1801             …
1802             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
1803
1804         Address this by teaching generate-xcfilelists about more platforms.
1805
1806         * Scripts/generate-xcfilelists:
1807
1808 2019-03-19  John Wilander  <wilander@apple.com>
1809
1810         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
1811         https://bugs.webkit.org/show_bug.cgi?id=195923
1812         <rdar://problem/49001272>
1813
1814         Reviewed by Alex Christensen.
1815
1816         This patch does the following to the TestRunner:
1817         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
1818         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
1819         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
1820
1821         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1822         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1823         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1824         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1825         * WebKitTestRunner/TestController.cpp:
1826         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1827         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1828         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1829         * WebKitTestRunner/TestController.h:
1830         * WebKitTestRunner/TestInvocation.cpp:
1831         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1832
1833 2019-03-19  Christopher Reid  <chris.reid@sony.com>
1834
1835         [CMake] Support more clang and gcc sanitizers
1836         https://bugs.webkit.org/show_bug.cgi?id=195956
1837
1838         Reviewed by Michael Catanzaro.
1839
1840         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
1841
1842 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1843
1844         [ews-build] Improve summary for PrintConfiguration step
1845         https://bugs.webkit.org/show_bug.cgi?id=195945
1846
1847         Reviewed by Lucas Forschler.
1848
1849         * BuildSlaveSupport/ews-build/steps.py:
1850         (PrintConfiguration.getResultSummary): Override getResultSummary.
1851
1852 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1853
1854         [ews-build] Improve summary for CheckOutSource step
1855         https://bugs.webkit.org/show_bug.cgi?id=195963
1856
1857         Reviewed by Lucas Forschler.
1858
1859         * BuildSlaveSupport/ews-build/steps.py:
1860         (CheckOutSource.getResultSummary):
1861
1862 2019-03-19  Daniel Bates  <dabates@apple.com>
1863
1864         [iOS] Focus not preserved when switching between tabs
1865         https://bugs.webkit.org/show_bug.cgi?id=195820
1866         <rdar://problem/43614450>
1867
1868         Reviewed by Brent Fulgham.
1869
1870         Add tests to ensure that we restore focus when resigning and becoming first responder.
1871
1872         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1873         (TestWebKitAPI::TEST):
1874
1875 2019-03-19  Alex Christensen  <achristensen@webkit.org>
1876
1877         Make WTFLogChannelState and WTFLogLevel enum classes
1878         https://bugs.webkit.org/show_bug.cgi?id=195904
1879
1880         Reviewed by Eric Carlson.
1881
1882         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1883         (TestWebKitAPI::TEST_F):
1884
1885 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1886
1887         [GStreamer][EME] Backported mssdemux protection data crash fix
1888         https://bugs.webkit.org/show_bug.cgi?id=195918
1889
1890         Reviewed by Philippe Normand.
1891
1892         * gstreamer/jhbuild.modules:
1893         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
1894
1895 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1896
1897         Unreviewed, rolling out r243132.
1898
1899         Broke GTK build
1900
1901         Reverted changeset:
1902
1903         "Make WTFLogChannelState and WTFLogLevel enum classes"
1904         https://bugs.webkit.org/show_bug.cgi?id=195904
1905         https://trac.webkit.org/changeset/243132
1906
1907 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
1908
1909         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
1910
1911         * Scripts/webkitdirs.pm:
1912         (builtDylibPathForName): Adjust the shared library name that's changed
1913         with the API version bump in r243073.
1914
1915 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1916
1917         Make WTFLogChannelState and WTFLogLevel enum classes
1918         https://bugs.webkit.org/show_bug.cgi?id=195904
1919
1920         Reviewed by Eric Carlson.
1921
1922         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1923         (TestWebKitAPI::TEST_F):
1924
1925 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1926
1927         Disable flaky test added in r2431100
1928         https://webkit.org/b/195785
1929
1930         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1931         (TestWebKitAPI::TEST):
1932         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
1933
1934 2019-03-18  Timothy Hatcher  <timothy@apple.com>
1935
1936         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
1937         https://bugs.webkit.org/show_bug.cgi?id=195916
1938
1939         Reviewed by Tim Horton.
1940
1941         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1942         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
1943
1944 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
1945
1946         Add a secondary e-mail address for Fujii Hironori to make tools happier.
1947
1948         * Scripts/webkitpy/common/config/contributors.json:
1949
1950 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1951
1952         Implement DownloadMonitor to prevent long-running slow downloads from background apps
1953         https://bugs.webkit.org/show_bug.cgi?id=195785
1954
1955         Reviewed by Geoffrey Garen.
1956
1957         * TestWebKitAPI/TCPServer.cpp: Added.
1958         (TestWebKitAPI::TCPServer::TCPServer):
1959         (TestWebKitAPI::TCPServer::~TCPServer):
1960         (TestWebKitAPI::TCPServer::socketBindListen):
1961         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
1962         * TestWebKitAPI/TCPServer.h: Added.
1963         (TestWebKitAPI::TCPServer::port const):
1964         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1965         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1966         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
1967         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
1968         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1969         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
1970         (TestWebKitAPI::respondSlowly):
1971         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
1972         (TestWebKitAPI::downloadAtRate):
1973         (TestWebKitAPI::TEST):
1974
1975 2019-03-18  Saam Barati  <sbarati@apple.com>
1976
1977         Add a plan file for JetStream 2
1978         https://bugs.webkit.org/show_bug.cgi?id=190734
1979
1980         Reviewed by Mark Lam.
1981
1982         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
1983
1984 2019-03-18  Chris Dumez  <cdumez@apple.com>
1985
1986         Delay WebProcess launch until a load is triggered in a Web view
1987         https://bugs.webkit.org/show_bug.cgi?id=195758
1988         <rdar://problem/48126013>
1989
1990         Reviewed by Geoff Garen.
1991
1992         Add API test coverage. Also update some existing API tests to not expect
1993         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
1994
1995         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
1996         (TestWebKitAPI::TEST):
1997         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
1998         (TestWebKitAPI::TEST):
1999         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2000         (TEST):
2001         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2002         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2003         (TEST):
2004         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2005         (TEST):
2006         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2007
2008 2019-03-18  Xan Lopez  <xan@igalia.com>
2009
2010         [CMake] Prevent potential warning when determining $architecture
2011         https://bugs.webkit.org/show_bug.cgi?id=195891
2012
2013         Reviewed by Michael Catanzaro.
2014
2015         It's possible for generateBuildSystemForCMakeProject to be called
2016         before determineArchitecture() is ever called. This will make the
2017         first eq check with $architecture to be bogus (and print a
2018         warning). Change that to an eq check with architecture(), which
2019         implicitly calls determineArchitecture() if needed, and change all
2020         the other similar cases in the method in the same way to prevent
2021         future bugs like this one.
2022
2023         * Scripts/webkitdirs.pm:
2024         (generateBuildSystemFromCMakeProject):
2025
2026 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2027
2028         [WPE] Tarballs generated with “make dist” cannot build documentation
2029         https://bugs.webkit.org/show_bug.cgi?id=195885
2030
2031         Reviewed by Carlos Garcia Campos.
2032
2033         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2034
2035 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2036
2037         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2038         https://bugs.webkit.org/show_bug.cgi?id=195883
2039
2040         Reviewed by Carlos Garcia Campos.
2041
2042         * gtkdoc/gtkdoc.py:
2043         (GTKDoc._run_command): When commands fail to run, include the full command line for
2044         the program invocation and the output it has generated on the standard error stream.
2045
2046 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2047
2048         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2049         https://bugs.webkit.org/show_bug.cgi?id=195786
2050
2051         Reviewed by Philippe Normand.
2052
2053         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2054         * wpe/jhbuild.modules: Ditto.
2055
2056 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2057
2058         [ews-build] Don't run clean builds on EWS builders
2059         https://bugs.webkit.org/show_bug.cgi?id=195851
2060
2061         Reviewed by Geoffrey Garen.
2062
2063         * BuildSlaveSupport/ews-build/factories.py:
2064
2065 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2066
2067         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2068         https://bugs.webkit.org/show_bug.cgi?id=195849
2069
2070         Reviewed by Chris Dumez.
2071
2072         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2073
2074         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2075         (runWebsiteDataStoreCustomPaths):
2076
2077 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2078
2079         webkitpy: Upload test results
2080         https://bugs.webkit.org/show_bug.cgi?id=195755
2081         <rdar://problem/48896182>
2082
2083         Reviewed by Aakash Jain.
2084
2085         Establish a new format for uploading results that is not tied to layout tests, apply
2086         that format to webkitpy tests.
2087
2088         * Scripts/webkitpy/common/checkout/scm/git.py:
2089         (Git.native_branch): Return what branch the current checkout is on.
2090         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2091         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2092         * Scripts/webkitpy/common/checkout/scm/svn.py:
2093         (SVN.native_branch): Ditto.
2094         * Scripts/webkitpy/common/system/platforminfo.py:
2095         (PlatformInfo.build_version): Return a build version for Mac.
2096         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2097         (MockPlatformInfo.__init__):
2098         (MockPlatformInfo.build_version):
2099         * Scripts/webkitpy/results: Added.
2100         * Scripts/webkitpy/results/__init__.py: Added.
2101         * Scripts/webkitpy/results/options.py: Added.
2102         (upload_options): OptParse list for upload options.
2103         * Scripts/webkitpy/results/upload.py: Added.
2104         (Upload): Class which enforces the upload format expected by the results server.
2105         (Upload.Expectations):
2106         (Upload.create_configuration):
2107         (Upload.create_commit):
2108         (Upload.create_details):
2109         (Upload.create_run_stats):
2110         (Upload.create_test_result):
2111         (Upload.__init__):
2112         (Upload.Encoder): Encode Upload object as json.
2113         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2114         * Scripts/webkitpy/results/upload_unittest.py: Added.
2115         * Scripts/webkitpy/test/main.py:
2116         (Tester._parse_args): Add upload arguments.
2117         (Tester._run_tests): Allow results to be uploaded.
2118         * Scripts/webkitpy/test/runner.py:
2119         (Runner.__init__): Record which tests were run, rather than just counting them.
2120         (Runner.handle):
2121         * Scripts/webkitpy/test/runner_unittest.py:
2122         (RunnerTest.test_run):
2123         * Scripts/webkitpy/thirdparty/__init__.py:
2124         (AutoinstallImportHook.find_module): Add requests auto-install.
2125         (AutoinstallImportHook._install_requests):
2126         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2127         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2128
2129 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2130
2131         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2132         https://bugs.webkit.org/show_bug.cgi?id=195810
2133
2134         Reviewed by Tim Horton.
2135
2136         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2137         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2138         ending certain layout tests.
2139
2140         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2141         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2142         (-[TestRunnerWKWebView dealloc]):
2143         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2144
2145         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2146         helper method when destroying the web view, and when resetting state between tests.
2147
2148         * WebKitTestRunner/ios/TestControllerIOS.mm:
2149         (WTR::TestController::platformResetStateToConsistentValues):
2150
2151         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2152
2153 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2154
2155         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2156         https://bugs.webkit.org/show_bug.cgi?id=190350
2157         <rdar://problem/45089503>
2158
2159         Reviewed by Geoffrey Garen.
2160
2161         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2162         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2163         (TEST):
2164         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2165         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2166         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2167         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2168         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2169         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2170         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2171         (runTest):
2172         (createDirectories):
2173         (TEST):
2174         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2175         (TEST):
2176         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2177         (TEST):
2178
2179 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2180
2181         Add support to WebPage for getting the contents as an attributed string.
2182         https://bugs.webkit.org/show_bug.cgi?id=195636
2183         rdar://problem/45055697
2184
2185         Reviewed by Tim Horton.
2186
2187         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2188         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2189
2190 2019-03-15  Chris Dumez  <cdumez@apple.com>
2191
2192         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2193         https://bugs.webkit.org/show_bug.cgi?id=195747
2194
2195         Reviewed by Geoff Garen.
2196
2197         Add API test coverage.
2198
2199         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2200
2201 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2202
2203         Unreviewed, rolling out r242952.
2204
2205         Causing API failures on iOS Simulator
2206
2207         Reverted changeset:
2208
2209         "[PSON] Make sure the WebProcessCache is leverage when
2210         relaunching a process after termination"
2211         https://bugs.webkit.org/show_bug.cgi?id=195747
2212         https://trac.webkit.org/changeset/242952
2213
2214 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2215
2216         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2217         https://bugs.webkit.org/show_bug.cgi?id=195740
2218
2219         Reviewed by Ross Kirsling.
2220
2221         window.open doesn't work for WebKitBrowserWindow because it is not
2222         implemented yet.
2223
2224         1. Implemented createNewPage callback of WKPageUIClient.
2225         2. Changed MainWindow to take a BrowserWindow factory function
2226           instead of BrowserWindowType to be flexible to create
2227           BrowserWindow with extra settings.
2228         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2229           because it is not relevant with MainWindow anymore.
2230
2231         * MiniBrowser/win/Common.cpp:
2232         (parseCommandLine):
2233         * MiniBrowser/win/Common.h:
2234         (CommandLineOptions::CommandLineOptions):
2235         * MiniBrowser/win/MainWindow.cpp:
2236         (MainWindow::MainWindow):
2237         (MainWindow::create):
2238         (MainWindow::init):
2239         (MainWindow::WndProc):
2240         * MiniBrowser/win/MainWindow.h:
2241         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2242         (PrintWebUIDelegate::createWebViewWithRequest):
2243         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2244         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2245         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2246         (WebKitBrowserWindow::updateProxySettings):
2247         (WebKitBrowserWindow::createNewPage):
2248         * MiniBrowser/win/WebKitBrowserWindow.h:
2249         * MiniBrowser/win/WinMain.cpp:
2250         (wWinMain):
2251
2252 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2253
2254         Make it possible to test scrolling tree layer manipulation more easily
2255         https://bugs.webkit.org/show_bug.cgi?id=195780
2256
2257         Reviewed by Tim Horton.
2258         
2259         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2260         cuts off communication of scrolling tree scrolls back to the web process
2261         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2262         allows tests to trigger scrolls which run the scrolling tree layer positioning
2263         logic, but never get another commit from the web process that might mask
2264         scrolling tree bugs.
2265         
2266         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2267         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2268         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2269
2270         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2271         (WTR::UIScriptController::scrollUpdatesDisabled const):
2272         (WTR::UIScriptController::setScrollUpdatesDisabled):
2273         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2274         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2275         (WTR::UIScriptController::scrollUpdatesDisabled const):
2276         (WTR::UIScriptController::setScrollUpdatesDisabled):
2277         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2278         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2279         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2280         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2281         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2282         * WebKitTestRunner/ios/TestControllerIOS.mm:
2283         (WTR::TestController::platformResetStateToConsistentValues):
2284         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2285         (WTR::UIScriptController::scrollUpdatesDisabled const):
2286         (WTR::UIScriptController::setScrollUpdatesDisabled):
2287
2288 2019-03-14  Youenn Fablet  <youenn@apple.com>
2289
2290         Move IDB storage in private browsing mode to NetworkProcess
2291         https://bugs.webkit.org/show_bug.cgi?id=195602
2292
2293         Reviewed by Brady Eidson.
2294
2295         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2296         (TEST):
2297
2298 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2299
2300         [ews-build] Make descriptionDone messages more readable
2301         https://bugs.webkit.org/show_bug.cgi?id=195760
2302
2303         Reviewed by Lucas Forschler.
2304
2305         * BuildSlaveSupport/ews-build/steps.py:
2306         * BuildSlaveSupport/ews-build/steps_unittest.py:
2307
2308 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2309
2310         [ews-build] Generate status-bubble hover-over messages
2311         https://bugs.webkit.org/show_bug.cgi?id=195680
2312
2313         Reviewed by Lucas Forschler.
2314
2315         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2316         (StatusBubble):
2317         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2318         on hover-over.
2319         (StatusBubble._iso_time):
2320         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2321         hover-over message.
2322         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2323
2324 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2325
2326         [ews-app] Gracefully handle the case when state_string is None
2327         https://bugs.webkit.org/show_bug.cgi?id=195753
2328
2329         Reviewed by Lucas Forschler.
2330
2331         * BuildSlaveSupport/ews-app/ews/models/build.py:
2332         * BuildSlaveSupport/ews-app/ews/models/step.py:
2333
2334 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2335
2336         [ews-app] Status bubble display pending for currently running build step
2337         https://bugs.webkit.org/show_bug.cgi?id=195744
2338
2339         Reviewed by Lucas Forschler.
2340
2341         * BuildSlaveSupport/ews-build/events.py:
2342         (Events.stepStarted): If state_string is pending, replace it with step name.
2343
2344 2019-03-14  Chris Dumez  <cdumez@apple.com>
2345
2346         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2347         https://bugs.webkit.org/show_bug.cgi?id=195750
2348
2349         Reviewed by Geoffrey Garen.
2350
2351         Add API test coverage.
2352
2353         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2354         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2355         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2356         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2357
2358 2019-03-14  Chris Dumez  <cdumez@apple.com>
2359
2360         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2361         https://bugs.webkit.org/show_bug.cgi?id=195747
2362
2363         Reviewed by Geoff Garen.
2364
2365         Add API test coverage.
2366
2367         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2368
2369 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2370
2371         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2372         https://bugs.webkit.org/show_bug.cgi?id=195725
2373         <rdar://problem/48545062>
2374
2375         Reviewed by Tim Horton.
2376
2377         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2378         handler is nil.
2379
2380         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2381         (TestWebKitAPI::TEST):
2382
2383 2019-03-13  Sam Weinig  <sam@webkit.org>
2384
2385         Add utility function to allow easy reverse range-based iteration of a container
2386         https://bugs.webkit.org/show_bug.cgi?id=195542
2387
2388         Reviewed by Antti Koivisto.
2389
2390         * TestWebKitAPI/CMakeLists.txt:
2391         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2392         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2393         (TestWebKitAPI::TEST):
2394         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2395
2396 2019-03-13  Chris Dumez  <cdumez@apple.com>
2397
2398         Use a ServiceWorker process per registrable domain
2399         https://bugs.webkit.org/show_bug.cgi?id=195649
2400
2401         Reviewed by Youenn Fablet.
2402
2403         Update API test coverage.
2404
2405         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2406
2407 2019-03-13  Chris Dumez  <cdumez@apple.com>
2408
2409         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2410         https://bugs.webkit.org/show_bug.cgi?id=195684
2411         <rdar://problem/48294714>
2412
2413         Reviewed by Antti Koivisto.
2414
2415         Add API test coverage.
2416
2417         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2418
2419 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2420
2421         [ews-app] Remove unused patch view
2422         https://bugs.webkit.org/show_bug.cgi?id=195669
2423
2424         Reviewed by Lucas Forschler.
2425
2426         * BuildSlaveSupport/ews-app/ews/urls.py:
2427         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2428
2429 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2430
2431         [ews-app] Use Buildbot result code variables
2432         https://bugs.webkit.org/show_bug.cgi?id=195668
2433
2434         Reviewed by Alexey Proskuryakov.
2435
2436         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2437         (Buildbot): Added Buildbot result code variables.
2438         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2439         (StatusBubble._build_bubble): Used Buildbot result code variables.
2440
2441 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2442
2443         [Flatpak] Expand submodule recursively
2444         https://bugs.webkit.org/show_bug.cgi?id=195672
2445
2446         Building WPE with flatpak was impossible without that as it was raising an exception.
2447         Also update wpebackend-fdo to match what is built in jhbuild
2448
2449         Reviewed by Philippe Normand.
2450
2451         * flatpak/flatpakutils.py:
2452         (expand_submodules_recurse):
2453         (expand_manifest):
2454         * flatpak/org.webkit.WPEModules.yaml:
2455
2456 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2457
2458         [ews-app] status bubble should be hidden for certain builds
2459         https://bugs.webkit.org/show_bug.cgi?id=194597
2460
2461         Reviewed by Dewei Zhu.
2462
2463         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2464         (StatusBubble._build_bubble):
2465         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2466         because the patch didn't have relevant changes.
2467         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2468         in production yet.
2469
2470 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2471
2472         [Win] Fix a slew of simple clang-cl warnings.
2473         https://bugs.webkit.org/show_bug.cgi?id=195652
2474
2475         Reviewed by Don Olmstead.
2476
2477         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2478         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2479
2480 2019-03-12  Justin Fan  <justin_fan@apple.com>
2481
2482         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2483         https://bugs.webkit.org/show_bug.cgi?id=195518
2484         <rdar://problem/46322356>
2485
2486         Reviewed by Myles C. Maxfield.
2487
2488         * DumpRenderTree/DerivedSources-input.xcfilelist:
2489         * DumpRenderTree/DerivedSources-output.xcfilelist:
2490
2491 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2492
2493         Unreviewed, rolling out r242825.
2494         https://bugs.webkit.org/show_bug.cgi?id=195648
2495
2496         "Broke webkitpy tests with my change to
2497         lldb_dump_class_layout.py" (Requested by rmorisset on
2498         #webkit).
2499
2500         Reverted changeset:
2501
2502         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2503         classes with suspicious padding"
2504         https://bugs.webkit.org/show_bug.cgi?id=195573
2505         https://trac.webkit.org/changeset/242825
2506
2507 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2508
2509         [ews-build] Show status bubbles while the patch is waiting in queue
2510         https://bugs.webkit.org/show_bug.cgi?id=195618
2511
2512         Reviewed by Lucas Forschler.
2513
2514         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2515         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2516         enabled in initial deployment.
2517         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2518         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2519         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2520         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2521         (StatusBubble._build_bubbles_for_patch):
2522
2523 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2524
2525         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2526         https://bugs.webkit.org/show_bug.cgi?id=195573
2527
2528         Reviewed by Simon Fraser.
2529
2530         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2531
2532         * Scripts/dump-class-layout:
2533         (main):
2534         * lldb/lldb_dump_class_layout.py:
2535         (ClassLayout.__init__):
2536         (ClassLayout._compute_padding_recursive):
2537         (LLDBDebuggerInstance.dump_layout_for_classname):
2538         (LLDBDebuggerInstance):
2539         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2540         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2541
2542 2019-03-12  Chris Dumez  <cdumez@apple.com>
2543
2544         Device Orientation access permission should be denied unless explicitly granted by the client
2545         https://bugs.webkit.org/show_bug.cgi?id=195625
2546
2547         Reviewed by Youenn Fablet.
2548
2549         add API test coverage.
2550
2551         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2552         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2553         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2554         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2555         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2556         (runDeviceOrientationTest):
2557         (TEST):
2558         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2559         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2560
2561 2019-03-12  Jer Noble  <jer.noble@apple.com>
2562
2563         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2564         https://bugs.webkit.org/show_bug.cgi?id=195137
2565         <rdar://problem/48810307>
2566
2567         Reviewed by Eric Carlson.
2568
2569         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2570         (TestWebKitAPI::TEST):
2571
2572 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2573
2574         [ews-build] Change urls from uat to production
2575         https://bugs.webkit.org/show_bug.cgi?id=195566
2576
2577         Reviewed by Lucas Forschler.
2578
2579         * BuildSlaveSupport/ews-app/ews/config.py:
2580         * BuildSlaveSupport/ews-build/events.py:
2581         * BuildSlaveSupport/ews-build/steps.py:
2582
2583 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2584
2585         [ews-build] change max_builds for local-worker to 1
2586         https://bugs.webkit.org/show_bug.cgi?id=195568
2587
2588         Reviewed by Lucas Forschler.
2589
2590         * BuildSlaveSupport/ews-build/loadConfig.py:
2591
2592 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2593
2594         Fix the build
2595
2596         * TestRunnerShared/spi/PencilKitTestSPI.h:
2597         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2598
2599 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2600
2601         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2602         https://bugs.webkit.org/show_bug.cgi?id=194131
2603
2604         Reviewed by Michael Catanzaro.
2605
2606         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2607         (uriChanged):
2608         (testUnfinishedSubresourceLoad):
2609         (serverCallback):
2610         (beforeAll):
2611
2612 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2613
2614         WTF::Expected should use std::addressof instead of operator&
2615         https://bugs.webkit.org/show_bug.cgi?id=195604
2616
2617         Reviewed by Myles Maxfield.
2618
2619         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2620         (TestWebKitAPI::Unique::Unique):
2621         (TestWebKitAPI::Unique::operator&):
2622         (TestWebKitAPI::TEST):
2623
2624 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2625
2626         Add Optional to Forward.h.
2627         https://bugs.webkit.org/show_bug.cgi?id=195586
2628
2629         Reviewed by Darin Adler.
2630
2631         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2632         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2633         Remove unnecessary includes from headers.
2634
2635 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2636
2637         Add testing API to hit-test and scroll overflow scrollers
2638         https://bugs.webkit.org/show_bug.cgi?id=195278
2639
2640         Reviewed by Antti Koivisto.
2641         
2642         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2643         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2644         
2645         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2646
2647         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2648         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2649         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2650         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2651         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2652         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2653         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2654         (WTR::enclosingScrollViewIncludingSelf):
2655         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2656
2657 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2658
2659         API test WebKit.RequestTextInputContext fails on iOS
2660         https://bugs.webkit.org/show_bug.cgi?id=195585
2661
2662         Reviewed by Wenson Hsieh and Simon Fraser.
2663
2664         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2665         (applyStyle):
2666         (TEST):
2667         Add a viewport, so that the coordinates match up on iOS.
2668         Scroll by moving the UIScrollView's contentOffset.
2669
2670 2019-03-11  Chris Dumez  <cdumez@apple.com>
2671
2672         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2673         https://bugs.webkit.org/show_bug.cgi?id=195506
2674         <rdar://problem/48733477>
2675
2676         Reviewed by Alex Christensen.
2677
2678         Add API test coverage.
2679
2680         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2681
2682 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2683
2684         Adding myself to contributors.json
2685
2686         Unreviewed, addming myself to contributors.json .
2687
2688         * Scripts/webkitpy/common/config/contributors.json:
2689
2690 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2691
2692         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2693         https://bugs.webkit.org/show_bug.cgi?id=195511
2694         <rdar://problem/44873269>
2695
2696         Reviewed by Darin Adler.
2697
2698         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2699         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2700         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2701         (TEST_F):
2702
2703 2019-03-11  Chris Dumez  <cdumez@apple.com>
2704
2705         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2706         https://bugs.webkit.org/show_bug.cgi?id=195561
2707
2708         Reviewed by Youenn Fablet.
2709
2710         Make sure the JS in the test requests for permission to receive device orientation events.
2711
2712         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2713
2714 2019-03-11  Youenn Fablet  <youenn@apple.com>
2715
2716         Allow storage quota increase by default in WTR
2717         https://bugs.webkit.org/show_bug.cgi?id=195541
2718
2719         Reviewed by Geoffrey Garen.
2720
2721         Allow storage quota increase by default in WTR.
2722         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
2723         Use this for tests that explicitly need cache increase.
2724
2725         Instead of increasing quota by 2, make sure the next request is
2726         granted by adding all given parameters.
2727
2728         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2729         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2730         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2731         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
2732         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2733         * WebKitTestRunner/TestController.cpp:
2734         (WTR::TestController::setAllowStorageQuotaIncrease):
2735         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2736         * WebKitTestRunner/TestController.h:
2737         * WebKitTestRunner/TestInvocation.cpp:
2738         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2739         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2740         (WTR::TestController::cocoaResetStateToConsistentValues):
2741         (WTR::TestController::setAllowStorageQuotaIncrease):
2742         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2743         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2744         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2745
2746 2019-03-11  Xan Lopez  <xan@igalia.com>
2747
2748         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
2749         https://bugs.webkit.org/show_bug.cgi?id=194147
2750
2751         Reviewed by Michael Saboff.
2752
2753         To make --32-bit work correctly on Linux/64bit we need to:
2754
2755         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
2756         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
2757         unfortunately CMake only allows us to do this during
2758         crosscompilation, which is overkill here.
2759         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
2760         pkg-config detection module uses the x86 .pc files instead of the
2761         x86_64 ones.
2762         - Set the -m32 flags for the compiler.
2763
2764         * Scripts/webkitdirs.pm:
2765         (generateBuildSystemFromCMakeProject):
2766
2767 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
2768
2769         Add MotionMark-1.1 plan file for run-benchmark script.
2770         https://bugs.webkit.org/show_bug.cgi?id=195481
2771
2772         Rubber-stamped by Darin Adler.
2773
2774         Run-benchmark script should support MontionMark-1.1.
2775
2776         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
2777
2778 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2779
2780         [ews-app] Add support for submit-to-ews url
2781         https://bugs.webkit.org/show_bug.cgi?id=195477
2782
2783         Reviewed by Lucas Forschler.
2784
2785         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2786         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2787         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
2788         * BuildSlaveSupport/ews-app/ews/urls.py:
2789         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
2790
2791 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
2792
2793         Unreviewed, rolling out r242688, r242643, r242624.
2794
2795         Caused multiple layout test failures and crashes on iOS and macOS.
2796
2797         Reverted changeset:
2798
2799         "requestAnimationFrame should execute before the next frame"
2800         https://bugs.webkit.org/show_bug.cgi?id=177484
2801         https://trac.webkit.org/changeset/242624/webkit
2802
2803         * Tracing/SystemTracePoints.plist:
2804
2805 2019-03-11  John Wilander  <wilander@apple.com>
2806
2807         Resource Load Statistics: Make it possible exclude localhost from classification
2808         https://bugs.webkit.org/show_bug.cgi?id=195474
2809         <rdar://problem/47520577>
2810
2811         Reviewed by Brent Fulgham.
2812
2813         This patch allows for localhost to be excluded from classification and
2814         treatment as a prevalent resource.
2815
2816         The WebKit Tools change adds a new function called
2817         testRunner.setStatisticsIsRunningTest() which can be used to control this
2818         behavior.
2819
2820         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2821         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2822         (WTR::TestRunner::setStatisticsIsRunningTest):
2823         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2824         * WebKitTestRunner/TestController.cpp:
2825         (WTR::TestController::setStatisticsIsRunningTest):
2826         * WebKitTestRunner/TestController.h:
2827         * WebKitTestRunner/TestInvocation.cpp:
2828         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2829
2830 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2831
2832         [ews-build] Disable waterfall and console view for ews-build.webkit.org
2833         https://bugs.webkit.org/show_bug.cgi?id=195560
2834
2835         Reviewed by Lucas Forschler.
2836
2837         * BuildSlaveSupport/ews-build/master.cfg:
2838
2839 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2840
2841         Unreviewed, rolling out r242698.
2842
2843         API test crashes on bots.
2844
2845         Reverted changeset:
2846
2847         "Add a WKContentRuleList variant that uses copied memory
2848         instead of mmap'd shared memory for class A containerized
2849         apps"
2850         https://bugs.webkit.org/show_bug.cgi?id=195511
2851         https://trac.webkit.org/changeset/242698
2852
2853 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2854
2855         [WPE] Enable web process sandbox
2856         https://bugs.webkit.org/show_bug.cgi?id=195169
2857
2858         Reviewed by Daniel Bates.
2859
2860         * wpe/install-dependencies:
2861         * wpe/jhbuild.modules:
2862
2863 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2864
2865         [ews-app] Use port 17000 for worker communication
2866         https://bugs.webkit.org/show_bug.cgi?id=195558
2867
2868         Reviewed by Lucas Forschler.
2869
2870         * BuildSlaveSupport/ews-build/master.cfg:
2871
2872 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2873
2874         [ews-build] unit-tests fail when passwords.json is missing
2875         https://bugs.webkit.org/show_bug.cgi?id=195557
2876
2877         Reviewed by Lucas Forschler.
2878
2879         * BuildSlaveSupport/ews-build/loadConfig.py:
2880         (loadBuilderConfig):
2881         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2882         (ConfigDotJSONTest.test_configuration):
2883         * BuildSlaveSupport/ews-build/master.cfg:
2884
2885 2019-03-11  Truitt Savell  <tsavell@apple.com>
2886
2887         Unreviewed, rolling out r242702.
2888
2889         Broke High Sierra builders.
2890
2891         Reverted changeset:
2892
2893         "Add utility function to allow easy reverse range-based
2894         iteration of a container"
2895         https://bugs.webkit.org/show_bug.cgi?id=195542
2896         https://trac.webkit.org/changeset/242702
2897
2898 2019-03-11  Sam Weinig  <sam@webkit.org>
2899
2900         Add utility function to allow easy reverse range-based iteration of a container
2901         https://bugs.webkit.org/show_bug.cgi?id=195542
2902
2903         Reviewed by Antti Koivisto.
2904
2905         * TestWebKitAPI/CMakeLists.txt:
2906         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2907         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2908         (TestWebKitAPI::TEST):
2909         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2910
2911 2019-03-10  Alex Christensen  <achristensen@webkit.org>
2912
2913         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2914         https://bugs.webkit.org/show_bug.cgi?id=195511
2915         <rdar://problem/44873269>
2916
2917         Reviewed by Darin Adler.
2918
2919         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2920         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2921         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2922         (TEST_F):
2923
2924 2019-03-10  Tim Horton  <timothy_horton@apple.com>
2925
2926         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
2927         https://bugs.webkit.org/show_bug.cgi?id=195499
2928
2929         Reviewed by Darin Adler.
2930
2931         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2932         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
2933         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
2934         (-[WKWebView synchronouslyFocusTextInputContext:]):
2935         (applyStyle):
2936         (applyIframe):
2937         (TEST):
2938         Add some tests for this SPI.
2939
2940 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
2941
2942         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
2943         https://bugs.webkit.org/show_bug.cgi?id=181151
2944
2945         Reviewed by Don Olmstead.
2946
2947         * TestWebKitAPI/CMakeLists.txt:
2948         * TestWebKitAPI/PlatformWin.cmake:
2949         Enable TestWTF RunLoop tests in all platforms.
2950
2951         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
2952         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
2953         (TestWebKitAPI::DerivedOneShotTimer::fired):
2954         (TestWebKitAPI::TEST):
2955         Only a few platforms support nested RunLoop.
2956
2957         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
2958         (TestWebKitAPI::DerivedRepeatingTimer::fired):
2959
2960 2019-03-10  David Quesada  <david_quesada@apple.com>
2961
2962         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
2963         https://bugs.webkit.org/show_bug.cgi?id=152480
2964
2965         Reviewed by Chris Dumez.
2966
2967         Add a unit test based on Daniel Bates's test case that starts a download, ensures
2968         there are no additional references to the process pool besides the one held by
2969         the download, waits for the download to finish (in the sense that the
2970         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
2971         measure, also check that the process pool has been deallocated at the end of the
2972         test. The test wouldn't be meaningful if the process pool were still alive.
2973
2974         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2975         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
2976         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
2977             The download will be canceled because the delegate does not implement the
2978             method to decide the download's destination, so this is where we know the
2979             DownloadProxyMap is done with the DownloadProxy.
2980         (TEST):
2981
2982 2019-03-08  Chris Dumez  <cdumez@apple.com>
2983
2984         Add support for Device Orientation / Motion permission API
2985         https://bugs.webkit.org/show_bug.cgi?id=195329
2986         <rdar://problem/47645367>
2987
2988         Reviewed by Geoffrey Garen.
2989
2990         Add test infrastructure to help test the Device Orientation / Motion permission API.
2991
2992         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2993         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2994         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
2995         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2996         * WebKitTestRunner/TestController.cpp:
2997         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
2998         (WTR::TestController::createWebViewWithOptions):
2999         (WTR::TestController::resetStateToConsistentValues):
3000         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3001         * WebKitTestRunner/TestController.h:
3002         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3003         * WebKitTestRunner/TestInvocation.cpp:
3004         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3005
3006 2019-03-08  Saam barati  <sbarati@apple.com>
3007
3008         Add a compare-results script to compare benchmark results
3009         https://bugs.webkit.org/show_bug.cgi?id=195486
3010         <rdar://problem/48723397>
3011
3012         Reviewed by Geoffrey Garen.
3013
3014         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3015         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3016         to extend it to learn about our other benchmarks.
3017
3018         * Scripts/compare-results: Added.
3019         (readJSONFile):
3020         (detectJetStream2):
3021         (JetStream2Results):
3022         (detectSpeedometer2):
3023         (Speedometer2Results):
3024         (detectPLT5):
3025         (PLT5Results):
3026         (detectBenchmark):
3027         (biggerIsBetter):
3028         (ttest):
3029         (getOptions):
3030         (main):
3031
3032 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3033
3034         Ensure old tab state is cleared between iterations of run-benchmark
3035         https://bugs.webkit.org/show_bug.cgi?id=195393
3036         <rdar://problem/46885583>
3037
3038         Reviewed by Dewei Zhu.
3039
3040         a) ensure the default to restore state is not set
3041         b) terminate Safari correctly
3042         c) Set the system default to ignore Persistent State in Safari
3043
3044         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3045         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3046         (OSXBrowserDriver.prepare_env): 
3047         (OSXBrowserDriver.restore_env):
3048         (OSXBrowserDriver.close_browsers):
3049         (OSXBrowserDriver._terminate_processes):
3050         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3051         (OSXChromeDriver):
3052         (OSXChromeCanaryDriver):
3053         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3054         (OSXFirefoxDriver):
3055         (OSXFirefoxNightlyDriver):
3056         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3057         (OSXSafariDriver):
3058         (OSXSafariDriver.prepare_env):
3059
3060 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3061
3062         [GTK] Several InputMethodFilter tests are failing
3063         https://bugs.webkit.org/show_bug.cgi?id=195408
3064
3065         Reviewed by Carlos Garcia Campos.
3066
3067         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3068         Regressed in r241751.
3069         Hexadecimal values of keycodes are expressed now in upper letters.
3070         Composited characters should be cast to UTF8 strings.
3071
3072         (TestWebKitAPI::TEST):
3073
3074 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3075
3076         [GTK] Make Tools/gtkdoc python3 compatible
3077         https://bugs.webkit.org/show_bug.cgi?id=195359
3078
3079         Reviewed by Carlos Garcia Campos.
3080
3081         * gtkdoc/generate-gtkdoc:
3082         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3083         work with Python 2 and 3.
3084         (get_gtkdoc_module_paths):
3085         The iteritems() was removed in Python 3, so let's use items() that's
3086         available in Python 2 and 3.
3087         (get_generator_for_config):
3088         * gtkdoc/gtkdoc.py:
3089         (GTKDoc._run_command):
3090         The sys.stdout.write() is expecting str in Python 3 and not bytes
3091         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3092         for passing the bytes there.
3093
3094 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3095
3096         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3097         https://bugs.webkit.org/show_bug.cgi?id=195346
3098         <rdar://problem/48667048>
3099
3100         Unreviewed build fix for clang-cl.
3101
3102         * DumpRenderTree/win/DumpRenderTree.cpp:
3103         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3104
3105 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3106
3107         requestAnimationFrame should execute before the next frame
3108         https://bugs.webkit.org/show_bug.cgi?id=177484
3109
3110         Reviewed by Simon Fraser.
3111
3112         Add trace points for the page RenderingUpdate.
3113
3114         * Tracing/SystemTracePoints.plist:
3115
3116 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3117
3118         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3119         https://bugs.webkit.org/show_bug.cgi?id=195353
3120         <rdar://problem/48626394>
3121
3122         Reviewed by Simon Fraser.
3123
3124         * WebKitTestRunner/ios/TestControllerIOS.mm:
3125         (WTR::TestController::platformResetPreferencesToConsistentValues):
3126
3127 2019-03-07  John Wilander  <wilander@apple.com>
3128
3129         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3130         https://bugs.webkit.org/show_bug.cgi?id=195383
3131         <rdar://problem/48570136>
3132
3133         Reviewed by Brent Fulgham.
3134
3135         This patch adds test infrastructure to purge only script-accessible cookies,
3136         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3137
3138         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3139         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3140         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3141         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3142         * WebKitTestRunner/TestController.cpp:
3143         (WTR::TestController::statisticsDeleteCookiesForHost):
3144         * WebKitTestRunner/TestController.h:
3145         * WebKitTestRunner/TestInvocation.cpp:
3146         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3147
3148 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3149
3150         Unreviewed, rolling out r242354.
3151         https://bugs.webkit.org/show_bug.cgi?id=195402
3152
3153         breaks layout tests in all configurations (Requested by
3154         zdobersek on #webkit).
3155
3156         Reverted changeset:
3157
3158         "[WPE] Enable web process sandbox"
3159         https://bugs.webkit.org/show_bug.cgi?id=195169
3160         https://trac.webkit.org/changeset/242354
3161
3162 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3163
3164         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3165         https://bugs.webkit.org/show_bug.cgi?id=195346
3166
3167         Reviewed by Fujii Hironori.
3168
3169         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3170         (TestWebKitAPI::TEST):
3171         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3172
3173         * DumpRenderTree/win/DumpRenderTree.cpp:
3174         (findFontFallback):
3175         (addFontFallbackIfPresent):
3176         (removeFontFallbackIfPresent):
3177         (main):
3178         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3179         (TestWebKitAPI::Util::moduleDirectory):
3180         (TestWebKitAPI::Util::createInjectedBundlePath):
3181         Use wchar helpers as needed.
3182
3183 2019-03-06  Rob Buis  <rbuis@igalia.com>
3184
3185         Consider supporting the `referrerpolicy` attribute.
3186         https://bugs.webkit.org/show_bug.cgi?id=179053
3187
3188         Reviewed by Darin Adler.
3189
3190         Add a runtime flag for referrerpolicy attribute.
3191
3192         * DumpRenderTree/mac/DumpRenderTree.mm:
3193         (enableExperimentalFeatures):
3194
3195 2019-03-05  Daniel Bates  <dabates@apple.com>
3196
3197         Update expected API test result following r242379
3198         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3199
3200         Update expected x-coordinate of selection rect now that the left padding of
3201         a textarea is sized in ems (so dependent on the font size) just like the left
3202         padding of a text field.
3203
3204         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3205         (TestWebKitAPI::TEST):
3206
3207 2019-03-05  David Quesada  <david_quesada@apple.com>
3208
3209         [WK2] It should be possible to follow links with 'download' attributes
3210         https://bugs.webkit.org/show_bug.cgi?id=195145
3211         rdar://problem/48462642
3212
3213         Reviewed by Alex Christensen.
3214
3215         Add a unit test to verify that activating links with 'download' attributes now
3216         navigates to the linked resource, rather than starts downloading it. Add another
3217         to verify that it is still possible to explicitly download the link via the
3218         'Download' navigation action policy.
3219
3220         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3221         (-[DownloadAttributeTestDelegate init]):
3222         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3223         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3224         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3225         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3226         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3227         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3228         (TEST):
3229         * WebKitTestRunner/TestController.cpp:
3230         (WTR::TestController::decidePolicyForNavigationAction):
3231         * WebKitTestRunner/TestController.h:
3232
3233 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3234
3235         [Curl] Implement Cookie Accept Policy.
3236         https://bugs.webkit.org/show_bug.cgi?id=191645
3237
3238         Reviewed by Fujii Hironori.
3239
3240         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3241         (TestWebKitAPI::Curl::TEST_F):
3242
3243 2019-03-05  Youenn Fablet  <youenn@apple.com>
3244
3245         Rename requestCacheStorageSpace to requestStorageSpace
3246         https://bugs.webkit.org/show_bug.cgi?id=195282
3247
3248         Reviewed by Chris Dumez.
3249
3250         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3251         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3252         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3253
3254 2019-03-05  Brady Eidson  <beidson@apple.com>
3255
3256         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3257         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3258
3259         Reviewed by Tim Horton.
3260
3261         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3262         different directory into that same WKWebView should work.
3263
3264         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3265         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3266
3267 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3268
3269         Add WeakHashSet
3270         https://bugs.webkit.org/show_bug.cgi?id=195152
3271
3272         Reviewed by Antti Koivisto.
3273
3274         Added tests for WeakHashSet.
3275
3276         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3277         (TestWebKitAPI::Base::Base): Moved.
3278         (TestWebKitAPI::Derived::foo): Moved.
3279         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3280         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3281         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3282         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3283
3284 2019-03-04  Chris Dumez  <cdumez@apple.com>
3285
3286         Do not share WebProcesses between private and regular sessions
3287         https://bugs.webkit.org/show_bug.cgi?id=195189
3288         <rdar://problem/48421064>
3289
3290         Reviewed by Alex Christensen.
3291
3292         Add API test coverage.
3293
3294         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3295         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3296
3297 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3298
3299         [WPE] Enable web process sandbox
3300         https://bugs.webkit.org/show_bug.cgi?id=195169
3301
3302         Reviewed by Daniel Bates.
3303
3304         * wpe/install-dependencies:
3305         * wpe/jhbuild.modules:
3306
3307 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3308
3309         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3310         https://bugs.webkit.org/show_bug.cgi?id=195206
3311
3312         Reviewed by Žan Doberšek.
3313
3314         Add a new test case.
3315
3316         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3317         (testJSCClass):
3318
3319 2019-03-04  Charlie Turner  <cturner@igalia.com>
3320
3321         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3322         https://bugs.webkit.org/show_bug.cgi?id=194898
3323
3324         Reviewed by Žan Doberšek.
3325
3326         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3327         a GCC extension that permits arithmetic on void* pointer. Inline
3328         the macro until this issue is fixed upstream.
3329
3330 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3331
3332         Rid the world of WK_API_ENABLED
3333         https://bugs.webkit.org/show_bug.cgi?id=195263
3334
3335         Reviewed by Dan Bernstein.
3336
3337         List of changed files elided because it's useless.
3338
3339 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3340
3341         Unreviewed follow-up to r242292.
3342
3343         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3344
3345         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3346         (TestWebKitAPI::testStrip): Renamed from strip.
3347         (TestWebKitAPI::TEST):
3348
3349 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3350
3351         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3352
3353         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3354         and bug #194272 for details.
3355
3356         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3357
3358 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3359
3360         Remove some more unused 32-bit code
3361         https://bugs.webkit.org/show_bug.cgi?id=195255
3362
3363         Reviewed by Darin Adler.
3364
3365         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3366         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3367         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3368         (NPP_New):
3369         (NPP_HandleEvent):
3370         (handleEventCarbon): Deleted.
3371
3372 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3373
3374         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3375
3376         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3377         (TestWebKitAPI::TEST):
3378
3379 2019-03-01  Darin Adler  <darin@apple.com>
3380
3381         Finish removing String::format
3382         https://bugs.webkit.org/show_bug.cgi?id=194893
3383
3384         Reviewed by Daniel Bates.
3385 '
3386         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3387
3388 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3389
3390         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3391         https://bugs.webkit.org/show_bug.cgi?id=195229
3392         <rdar://problem/48520362>
3393
3394         Reviewed by Chris Dumez.
3395
3396         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3397         (TEST):
3398
3399 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3400
3401         Add a system trace scope for event region building
3402         https://bugs.webkit.org/show_bug.cgi?id=195226
3403
3404         Reviewed by Jon Lee.
3405
3406         This trace scope measures the time spend converting element rects into Region objects,
3407         which can be large on some pages.
3408
3409         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3410
3411         * Tracing/SystemTracePoints.plist:
3412
3413 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3414
3415         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3416         https://bugs.webkit.org/show_bug.cgi?id=194612
3417
3418         Reviewed by Alex Christensen.
3419
3420         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3421         Just test the new string-processing function and don't touch the actual environment.
3422         (Test cases are all as before, but based on operator== instead of strcmp.)
3423
3424 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3425
3426         [ews-app] Update primary keys for handling multiple Buildbot instances
3427         https://bugs.webkit.org/show_bug.cgi?id=195120
3428
3429         Reviewed by Stephanie Lewis.
3430
3431         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3432         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3433         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3434
3435         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3436         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3437         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3438         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3439         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3440         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3441
3442 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3443
3444         [WinCairo] Enable service worker
3445         https://bugs.webkit.org/show_bug.cgi?id=188318
3446
3447         Reviewed by Youenn Fablet.
3448
3449         * DumpRenderTree/DumpRenderTreePrefix.h:
3450         * TestWebKitAPI/PlatformWin.cmake:
3451         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3452         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3453         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3454
3455 2019-03-01  Justin Fan  <justin_fan@apple.com>
3456
3457         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3458         https://bugs.webkit.org/show_bug.cgi?id=195191
3459
3460         Rubber-stamped by Dean Jackson.
3461
3462         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3463
3464         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3465
3466 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3467
3468         Unreviewed, fix lldb webkitpy tests
3469         https://bugs.webkit.org/show_bug.cgi?id=194375
3470
3471         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3472
3473         * lldb/lldb_webkit.py:
3474         (WTFStringImplProvider.is_8bit):
3475
3476 2019-02-28  David Quesada  <david_quesada@apple.com>
3477
3478         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3479         https://bugs.webkit.org/show_bug.cgi?id=195121
3480         rdar://problem/48450302
3481
3482         Reviewed by Alex Christensen.
3483
3484         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3485         configurations where the 'download' attribute is absent, blank, or populated
3486         with a filename, and where the anchor element is same-origin or cross-origin
3487         (meaning the 'download' attribute shouldn't be honored).
3488
3489         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3490         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3491         (-[NavigationActionTestDelegate init]):
3492         (-[NavigationActionTestDelegate navigationAction]):
3493         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3494         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3495         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3496         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3497         (TEST):
3498
3499 2019-02-28  Antoine Quint  <graouts@apple.com>
3500
3501         Enable the Pointer Events runtime flag by default
3502         https://bugs.webkit.org/show_bug.cgi?id=195156
3503
3504         Reviewed by Dean Jackson.
3505
3506         * DumpRenderTree/mac/DumpRenderTree.mm:
3507         (enableExperimentalFeatures):
3508
3509 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3510
3511         Several PasteImage API tests are flaky
3512         https://bugs.webkit.org/show_bug.cgi?id=195160
3513
3514         Reviewed by Tim Horton.
3515
3516         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3517         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3518         listening for a "load" event after image load is already complete.
3519
3520         To address this, make these tests first register a "load" event handler, then run script to insert an image
3521         element into the document, and finally wait until the load event is observed before checking image size.
3522
3523         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3524
3525 2019-02-28  Chris Dumez  <cdumez@apple.com>
3526
3527         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3528         https://bugs.webkit.org/show_bug.cgi?id=195107
3529
3530         Reviewed by Alex Christensen.
3531
3532         Give some time for the zoom level to get restored.
3533
3534         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3535
3536 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3537
3538         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3539         https://bugs.webkit.org/show_bug.cgi?id=194958
3540
3541         Reviewed by Geoffrey Garen.
3542
3543         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3544         (TEST):
3545
3546 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3547
3548         [ews-app] Update method to save build to handle builder_display_name
3549         https://bugs.webkit.org/show_bug.cgi?id=195047
3550
3551         Reviewed by Dewei Zhu.
3552
3553         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3554         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3555
3556 2019-02-28  Justin Fan  <justin_fan@apple.com>
3557
3558         [Web GPU] Enable Web GPU only on 64-bit
3559         https://bugs.webkit.org/show_bug.cgi?id=195139
3560
3561         Because Metal is only supported on 64 bit apps.
3562
3563         Unreviewed build fix.
3564
3565         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3566
3567 2019-02-27  Youenn Fablet  <youenn@apple.com>
3568
3569         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3570         https://bugs.webkit.org/show_bug.cgi?id=194959
3571
3572         Reviewed by Chris Dumez.
3573
3574         Spin loop until getting the condition to remove flakiness.
3575
3576         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3577
3578 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3579
3580         [ews-build] Buildbot should include builder_display_name in the build events
3581         https://bugs.webkit.org/show_bug.cgi?id=195045
3582
3583         Reviewed by Dewei Zhu.
3584
3585         * BuildSlaveSupport/ews-build/events.py:
3586         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3587         buildername to builder_name to be consistent in naming style.
3588         (Events.buildFinished): Ditto.
3589
3590 2019-02-27  Chris Dumez  <cdumez@apple.com>
3591
3592         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3593         https://bugs.webkit.org/show_bug.cgi?id=194480
3594
3595         Reviewed by Brady Eidson.
3596
3597         Update existing API test to make it more likely to reproduce the issue.
3598
3599         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3600
3601 2019-02-27  Brady Eidson  <beidson@apple.com>
3602
3603         Universal links from Google search results pages don't open the app.
3604         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3605
3606         Reviewed by Geoffrey Garen.
3607
3608         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3609         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3610         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3611         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3612
3613 2019-02-27  Chris Dumez  <cdumez@apple.com>
3614
3615         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3616         https://bugs.webkit.org/show_bug.cgi?id=195102
3617
3618         Reviewed by Geoffrey Garen.
3619
3620         If the number of processes is not yet what we expect, wait a bit and check again to give
3621         processes some time to exit.
3622
3623         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3624
3625 2019-02-27  Chris Dumez  <cdumez@apple.com>
3626
3627         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3628         https://bugs.webkit.org/show_bug.cgi?id=194545
3629
3630         Reviewed by Brady Eidson.
3631
3632         Make sure the test navigates forward and then back only once. Previously, navigating
3633         back would trigger a navigation again in a timer.
3634
3635         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3636
3637 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3638
3639         High Sierra Debug JSC test queue should use faster hardware
3640         https://bugs.webkit.org/show_bug.cgi?id=194603
3641
3642         Rubber-stamped by Alexey Proskuryakov.
3643
3644         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3645
3646         * BuildSlaveSupport/build.webkit.org-config/config.json:
3647         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3648         (BubbleQueueServer):
3649         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3650         (WebKitBuildbot):
3651         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3652         * QueueStatusServer/config/queues.py:
3653         * Scripts/webkitpy/common/config/ews.json:
3654         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3655         (test_ews_name):
3656
3657 2019-02-27  John Wilander  <wilander@apple.com>
3658
3659         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3660         https://bugs.webkit.org/show_bug.cgi?id=195071
3661         <rdar://problem/48417690>
3662
3663         Reviewed by Alex Christensen and Brent Fulgham.
3664
3665         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3666         (TestWebKitAPI::createURL):
3667             Convenience function.
3668         (TestWebKitAPI::TEST):
3669             WebCore::AdClickAttribution now takes a URL when creating Source and
3670             Destination.
3671         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3672         (TestWebKitAPI::TEST):
3673             WebCore::AdClickAttribution now takes a URL when creating Source and
3674             Destination.
3675
3676 2019-02-27  Antoine Quint  <graouts@apple.com>
3677
3678         Support Pointer Events on macOS
3679         https://bugs.webkit.org/show_bug.cgi?id=195008
3680         <rdar://problem/47454419>
3681
3682         Reviewed by Dean Jackson.
3683
3684         * DumpRenderTree/mac/DumpRenderTree.mm:
3685         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3686         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3687
3688 2019-02-26  Mark Lam  <mark.lam@apple.com>
3689
3690         Remove remaining poisoning code.
3691         https://bugs.webkit.org/show_bug.cgi?id=194138
3692
3693         Reviewed by Saam Barati.
3694
3695         * TestWebKitAPI/CMakeLists.txt:
3696         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3697         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
3698         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
3699         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
3700         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
3701         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.