Remove El Capitan queues from flakiness dashboard
[WebKit-https.git] / Tools / ChangeLog
1 2018-01-19  Ryan Haddad  <ryanhaddad@apple.com>
2
3         Remove El Capitan queues from flakiness dashboard
4         https://bugs.webkit.org/show_bug.cgi?id=181860
5
6         Reviewed by Aakash Jain.
7
8         * TestResultServer/static-dashboards/builders.jsonp:
9
10 2018-01-19  Keith Miller  <keith_miller@apple.com>
11
12         HaveInternalSDK includes should be "#include?"
13         https://bugs.webkit.org/show_bug.cgi?id=179670
14
15         Reviewed by Dan Bernstein.
16
17         * MiniBrowser/Configurations/Base.xcconfig:
18         * MobileMiniBrowser/Configurations/Base.xcconfig:
19         * TestWebKitAPI/Configurations/Base.xcconfig:
20         * WebKitTestRunner/Configurations/Base.xcconfig:
21
22 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
23
24         WebDriver: driver environment not passed to pytest when running w3c tests
25         https://bugs.webkit.org/show_bug.cgi?id=181852
26
27         Reviewed by Carlos Alberto Lopez Perez.
28
29         That's why color codes are not used in the bots log for selenium tests but they appear in w3c tests.
30
31         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
32         (WebDriverW3CExecutor.run):
33
34 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
35
36         [GTK] WebDriver: wayland display no used in wayland bot
37         https://bugs.webkit.org/show_bug.cgi?id=181851
38
39         Reviewed by Carlos Alberto Lopez Perez.
40
41         We need to handle the additionalArguments property in the WebDriverTests step.
42
43         * BuildSlaveSupport/build.webkit.org-config/steps.py:
44         (RunWebDriverTests.start):
45
46 2018-01-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
47
48         [GTK] TERM environment variable is not passed to the test driver.
49         https://bugs.webkit.org/show_bug.cgi?id=181847
50
51         Rubber-stamped by by Carlos Garcia Campos.
52
53         * Scripts/webkitpy/port/base.py:
54         (Port.to.setup_environ_for_server):
55
56 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
57
58         WebDriver: run-webdriver-tests is crashing in the bots when creating results json file
59         https://bugs.webkit.org/show_bug.cgi?id=181844
60
61         Reviewed by Carlos Alberto Lopez Perez.
62
63         We always try to create the directory where to store the json file, but when the filename is given directly,
64         like in the bots, the current dir is used.
65
66         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
67         (WebDriverTestRunner.dump_results_to_json_file): Do not try to create the directory if dirname() returns an
68         empty string.
69
70 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
71
72         [GTK] WebDriver tests are running outside the jhbuild env
73         https://bugs.webkit.org/show_bug.cgi?id=181842
74
75         Reviewed by Žan Doberšek.
76
77         We need to enter jhbuild env in run-webdriver-tests.
78
79         * Scripts/run-webdriver-tests:
80
81 2018-01-18  Carlos Garcia Campos  <cgarcia@igalia.com>
82
83         [GTK] Run WebDriver tests in the bots
84         https://bugs.webkit.org/show_bug.cgi?id=181787
85
86         Reviewed by Michael Catanzaro.
87
88         Add a step to run WebDriver tests in the GTK test bots. The new step is not GTK specific, but only added to the
89         factory for the GTK port for now.
90
91         * BuildSlaveSupport/build.webkit.org-config/factories.py:
92         (TestFactory.__init__):
93         * BuildSlaveSupport/build.webkit.org-config/steps.py:
94         (RunWebDriverTests):
95         (RunWebDriverTests.start):
96         (RunWebDriverTests.commandComplete):
97         (RunWebDriverTests.evaluateCommand):
98         (RunWebDriverTests.getText):
99         (RunWebDriverTests.getText2):
100
101 2018-01-18  Basuke Suzuki  <Basuke.Suzuki@sony.com>
102
103         [WinCairo] Pass correct url for http test to test driver.
104         https://bugs.webkit.org/show_bug.cgi?id=181814
105
106         Reviewed by Alex Christensen.
107
108         * Scripts/webkitpy/port/driver.py:
109         (Driver):
110         (Driver.http_test_path_to_uri):
111         (Driver.is_secure_path):
112         (Driver.http_base_url):
113         (Driver.uri_to_test):
114
115 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
116
117         Unreviewed, update the triggerable name for 'sierra-release-perf-tests'
118
119         * BuildSlaveSupport/build.webkit.org-config/config.json:
120
121 2018-01-18  Dan Bernstein  <mitz@apple.com>
122
123         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
124         https://bugs.webkit.org/show_bug.cgi?id=181803
125
126         Reviewed by Tim Horton.
127
128         * DumpRenderTree/mac/Configurations/Base.xcconfig: Updated.
129         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Ditto.
130         * ImageDiff/cg/Configurations/Base.xcconfig: Ditto.
131         * ImageDiff/cg/Configurations/DebugRelease.xcconfig: Ditto.
132         * MiniBrowser/Configurations/Base.xcconfig: Ditto.
133         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
134         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
135         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
136         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals
137           helpers.
138         * TestWebKitAPI/Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build
139           settings useful for defining settings that depend on the target macOS version.
140         * WebKitTestRunner/Configurations/Base.xcconfig: Updated.
141         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Updated.
142
143 2018-01-18  Ling Ho  <lingcherd_ho@apple.com>
144
145         Remove Opensource El Capitan queues from buildbot
146         https://bugs.webkit.org/show_bug.cgi?id=181712
147
148         Reviewed by Aakash Jain.
149
150         * BuildSlaveSupport/build.webkit.org-config/config.json:
151         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
152         (WebKitBuildbot):
153         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
154
155 2018-01-18  Chris Dumez  <cdumez@apple.com>
156
157         Service Workers restored from persistent storage have 'redundant' state
158         https://bugs.webkit.org/show_bug.cgi?id=181749
159         <rdar://problem/36556486>
160
161         Reviewed by Youenn Fablet.
162
163         Add API test coverage.
164
165         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
166         (-[SWMessageHandlerForFetchTest userContentController:didReceiveScriptMessage:]):
167
168 2018-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
169
170         [GTK] AX: Two layout tests crash with error 'g_strstr_len: assertion 'haystack != NULL' failed' in Accessibility::UIElement::url
171         https://bugs.webkit.org/show_bug.cgi?id=176796
172
173         Reviewed by Chris Fleizach.
174
175         Add sanity check that we have a URL before calling g_strstr_len().
176
177         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
178         (WTR::AccessibilityUIElement::url):
179
180 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
181
182         Add triggers for Sierra test262 and perf queues
183         https://bugs.webkit.org/show_bug.cgi?id=181799
184
185         Reviewed by Aakash Jain.
186
187         * BuildSlaveSupport/build.webkit.org-config/config.json:
188
189 2018-01-18  Wenson Hsieh  <wenson_hsieh@apple.com>
190
191         [iOS] Specify -[NSURL _title] for the associated URL when copying an image element
192         https://bugs.webkit.org/show_bug.cgi?id=181783
193         <rdar://problem/35785445>
194
195         Reviewed by Ryosuke Niwa.
196
197         Augments an existing API test and adds a new test to make sure that the resulting NSItemProvider's NSURL when
198         copying an image contains a relevant title.
199
200         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
201         (TestWebKitAPI::TEST):
202         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
203         * TestWebKitAPI/ios/UIKitSPI.h:
204
205 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
206
207         WebDriver: ignore the driver in selenium test names when getting expectations
208         https://bugs.webkit.org/show_bug.cgi?id=181738
209
210         Reviewed by Carlos Alberto Lopez Perez.
211
212         In selenium tests, the driver is added as a parameter to every test which results in tests names like
213         foo[DriverName] or foo[DriverName-param2] in case of tests using more parameters. We don't want to include the
214         driver name in the test expectations file, so we need to remove it when querying the expectations.
215
216         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
217         (TestExpectationsMarker.__init__): Save the param to ignore.
218         (TestExpectationsMarker._item_name): Return the name of the test without the para to ignore.
219         (TestExpectationsMarker.pytest_collection_modifyitems): Use _item_name().
220         (run): Pass param to ignore to TestExpectationsMarker().
221         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
222         (WebDriverSeleniumExecutor.__init__): Save the driver name.
223         (WebDriverSeleniumExecutor.run): Pass the driver name as param to ignore.
224
225 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
226
227         [GTK][WPE] Show unit tests unexpectedly passing in the bots
228         https://bugs.webkit.org/show_bug.cgi?id=181726
229
230         Reviewed by Michael Catanzaro.
231
232         Now that we have the info, let's show it also in the bots.
233
234         * BuildSlaveSupport/build.webkit.org-config/steps.py:
235         (RunGLibAPITests.commandComplete):
236
237 2018-01-17  Ling Ho  <lingcherd_ho@apple.com>
238
239         Fix broken unittest after r227048
240         https://bugs.webkit.org/show_bug.cgi?id=181760
241
242         Reviewed by Aakash Jain.
243
244
245 2018-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
246
247         WEBKIT_FRAMEWORK should not modify file-global include directories
248         https://bugs.webkit.org/show_bug.cgi?id=181656
249
250         Reviewed by Konstantin Tokarev.
251
252         * TestWebKitAPI/PlatformWPE.cmake:
253         * TestWebKitAPI/glib/CMakeLists.txt:
254
255 2018-01-17  Alicia Boya García  <aboya@igalia.com>
256
257         Unreviewed, mark Alicia as committer in contributors.json
258
259         * Scripts/webkitpy/common/config/contributors.json:
260
261 2018-01-17  Youenn Fablet  <youenn@apple.com>
262
263         Put fetch Request.keepalive behind a runtime flag
264         https://bugs.webkit.org/show_bug.cgi?id=181592
265
266         Reviewed by Chris Dumez.
267
268         * DumpRenderTree/mac/DumpRenderTree.mm:
269         (enableExperimentalFeatures):
270         * DumpRenderTree/win/DumpRenderTree.cpp:
271         (enableExperimentalFeatures):
272         * WebKitTestRunner/TestController.cpp:
273         (WTR::TestController::resetPreferencesToConsistentValues):
274
275 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
276
277         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
278         https://bugs.webkit.org/show_bug.cgi?id=181637
279         <rdar://problem/36508471>
280
281         Reviewed by Tim Horton.
282
283         Add 2 new API tests to exercise injected bundle SPI for supplying replacement URLs when pasting an image, and an
284         attributed string containing multiple NSTextAttachments. See WebKit and WebCore ChangeLogs for more detail.
285
286         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
287         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
288         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]):
289
290         Implement the new Objective-C bundle SPI to look up the incoming MIME type in the dictionary supplied via the
291         "MIMETypeToReplacementURLMap" bundle initialization parameter, and return it.
292
293         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
294         (webViewForTestingAttachments):
295         (-[TestWKWebView tagsInBody]):
296         (-[TestWKWebView expectElementTagsInOrder:]):
297         (-[TestWKWebView expectElementTag:toComeBefore:]):
298
299         Add a test helper to check that the given list of element tags appears in the document body. Also, reimplement
300         the existing -expectElementTag:toComeBefore: as a special case of -expectElementTagsInOrder:.
301
302         (TestWebKitAPI::TEST):
303         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
304         (WTR::InjectedBundlePage::InjectedBundlePage):
305
306 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
307
308         WebDriver: add support for test expectations
309         https://bugs.webkit.org/show_bug.cgi?id=180420
310
311         Reviewed by Carlos Alberto Lopez Perez.
312
313         Add support for parsing test expectations from a JSON file and mark tests on collection accordingly.
314
315         * Scripts/run-webdriver-tests: Get the retval from process_results().
316         * Scripts/webkitpy/thirdparty/__init__.py:
317         (AutoinstallImportHook._install_pytest): Install also py because pytest needs it.
318         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
319         (TestExpectationsMarker): Plugin to mark tests based on given expectations.
320         (TestExpectationsMarker.__init__): Initialize expectations.
321         (TestExpectationsMarker.pytest_collection_modifyitems): Mark tests if needed,
322         (run): Create and use TestExpectationsMarker plugin.
323         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
324         (WebDriverSeleniumExecutor.run): Pass expectations to pytest_runner.
325         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
326         (WebDriverTestRunner.__init__): Create a TestExpectations and pass it to the runners.
327         (WebDriverTestRunner.run): Do not count results here.
328         (WebDriverTestRunner.process_results): Rename print_results() as process_results() since it now returns the
329         amount of failures. Printing the test summary while processing results will be made optional in a follow up
330         patch.
331         (WebDriverTestRunner.process_results.report): Return the amount of failures.
332         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
333         (WebDriverTestRunnerSelenium.__init__): Initialize _expectations.
334         (WebDriverTestRunnerSelenium.collect_tests): Do not include skipped tests.
335         (WebDriverTestRunnerSelenium.run): Stop returning the tests count.
336         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
337         (WebDriverTestRunnerW3C.__init__): Initialize _expectations.
338         (WebDriverTestRunnerW3C.collect_tests): Do not include skipped tests.
339         (WebDriverTestRunnerW3C._scan_directory): Ditto.
340         (WebDriverTestRunnerW3C.run): Stop returning the tests count.
341         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
342         (WebDriverW3CExecutor.run): Pass expectations to pytest_runner.
343
344 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
345
346         Unreviewed WPE gardening. Mark some known unit test failures.
347
348         * TestWebKitAPI/glib/TestExpectations.json:
349
350 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
351
352         [GTK][WPE] Use the same subtest names in GTK and WPE unit tests
353         https://bugs.webkit.org/show_bug.cgi?id=181724
354
355         Reviewed by Philippe Normand.
356
357         We currently use /webkit2/foo/bar for GTK and /wpe/foo/bar for WPE. Many of the tests are common, so there's no
358         reason to use different names. This way we can refer to the same test names for both and we can share the
359         expectations in the TestExpectations.json file.
360
361         * TestWebKitAPI/glib/TestExpectations.json:
362         * TestWebKitAPI/glib/WebKitGLib/TestMain.h: Use /webkit/foo/bar in GTK and WPE.
363
364 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
365
366         Unreviewed. Increase the slow timeout of GTK and WPE unit tests.
367
368         We are using now a lower default timeout, so multiplying by 5 is no longer enough for some of the WTF
369         tests. Multiply by 10 so that we get the same slow timeout as before, 50.
370
371         * glib/api_test_runner.py:
372         (TestRunner._run_test_glib):
373         (TestRunner._run_google_test):
374
375 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
376
377         [GTK] Duplicated symbols in libjavascriptcoregtk and libwebkit2gtk can cause crashes in production builds
378         https://bugs.webkit.org/show_bug.cgi?id=179914
379
380         Reviewed by Žan Doberšek.
381
382         Add two scripts to be run by dist-check step when releasing. One is to detect symbols duplicated in
383         libjavascriptcoregtk and libwebkit2gtk that should be included to the version script. The other one is to ensure
384         all symbols listed in the script are present in the library.
385
386         * Scripts/check-for-global-bss-symbols-in-webkigtk-libs: Added.
387         (bss_symbols):
388         * Scripts/check-for-invalid-symbols-in-version-script: Added.
389         (script_symbols):
390         * Scripts/make-dist:
391         (Distcheck.build):
392         (Distcheck):
393         (Distcheck.check_symbols):
394         (Distcheck.check):
395
396 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
397
398         [GTK][WPE] Propagate the parameters when restarting glib api tests after a crash
399         https://bugs.webkit.org/show_bug.cgi?id=181722
400
401         Reviewed by Žan Doberšek.
402
403         I forgot to pass the parameters to run() when restarting.
404
405         * glib/glib_test_runner.py:
406         (GLibTestRunner.run):
407
408 2018-01-16  Fujii Hironori  <Hironori.Fujii@sony.com>
409
410         [CMake] Remove WebCoreDerivedSources library target
411         https://bugs.webkit.org/show_bug.cgi?id=181664
412
413         Reviewed by Carlos Garcia Campos.
414
415         * TestWebKitAPI/PlatformWPE.cmake: Do not link WebCoreDerivedSources.
416         * TestWebKitAPI/PlatformWin.cmake: Ditto.
417
418 2018-01-16  Ling Ho  <lingcherd_ho@apple.com>
419
420         Move Debug Test262, Release Test262 and Performance queues to Sierra
421         https://bugs.webkit.org/show_bug.cgi?id=181692
422
423         Unreviewed
424
425 2018-01-16  Zach Li  <zachli@apple.com>
426
427         Add pop-up policy support in website policies.
428         https://bugs.webkit.org/show_bug.cgi?id=181544.
429         rdar://problem/30521400.
430
431         Reviewed by Alex Christensen.
432
433         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
434         Added pop-up-check.html.
435
436         * TestWebKitAPI/Tests/WebKit/pop-up-check.html: Added.
437
438         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
439         (-[PopUpPoliciesDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
440         (-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
441         (-[PopUpPoliciesDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
442         (TEST):
443
444 2018-01-16  Wenson Hsieh  <wenson_hsieh@apple.com>
445
446         [Attachment Support] Provide the `src` of an attachment to the UI delegate when an attachment is inserted
447         https://bugs.webkit.org/show_bug.cgi?id=181638
448         <rdar://problem/36508702>
449
450         Reviewed by Dan Bernstein.
451
452         Tweak an existing API test to check that the `src` of an attachment element inserted via script matches the
453         `source` provided to the UI delegate via -[WKUIDelegate _webView:didInsertAttachment:withSource:].
454
455         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
456         (-[AttachmentUpdateObserver init]):
457         (-[AttachmentUpdateObserver sourceForIdentifier:]):
458         (-[AttachmentUpdateObserver _webView:didInsertAttachment:withSource:]):
459         (TestWebKitAPI::ObserveAttachmentUpdatesForScope::expectSourceForIdentifier):
460         (TestWebKitAPI::TEST):
461         (-[AttachmentUpdateObserver _webView:didInsertAttachment:]): Deleted.
462
463 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
464
465         Unreviewed. Fix GTK unit tests execution in the bots after r226967.
466
467         I forgot to pass the environment to the GLibTestRunner and Xvfb was not used in the bots.
468
469         * glib/api_test_runner.py:
470         (TestRunner._run_test_glib): Pass env to GLibTestRunner.
471         * glib/glib_test_runner.py:
472         (GLibTestRunner.run): Use given env.
473
474 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
475
476         [GTK][WPE] Stop passing --verbose to run-api-tests from the bots
477         https://bugs.webkit.org/show_bug.cgi?id=181676
478
479         Reviewed by Carlos Alberto Lopez Perez.
480
481         The option was removed in r226967.
482
483         * BuildSlaveSupport/build.webkit.org-config/steps.py:
484         (RunGtkAPITests):
485         (RunWPEAPITests):
486
487 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
488
489         Unreviewed. Temporarily bring back --verbose option of api_test_runner.py.
490
491         The bots are still passing that option and the step is failing because it was removed in r226967.
492
493         * glib/api_test_runner.py:
494         (add_options):
495
496 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
497
498         [GTK][WPE] Improve the way glib tests are run
499         https://bugs.webkit.org/show_bug.cgi?id=181674
500
501         Reviewed by Žan Doberšek.
502
503         Stop using gtester external program and use our own tester from python directly. This way we no longer need to
504         parse the tests output to get the results which is causing problems in WPE bot. We can now differentiate between
505         tests failing due to an expected assert in the test and unexpected crashes.
506         This also fixes a bug in previous code where we failed to properly detect tests timing out, because gtester was
507         not showing the subtest name in stdout in case of timeouts.
508         I've lowered the default timeout from 10 to 5, since we are now properly handling the timeout for every test
509         case. I've also removed the verbose option, since it was only used by gtester and we now always show the result
510         of every test case.
511
512         * glib/api_test_runner.py:
513         (TestRunner._run_test_glib): Use GLibTestRunner.
514         (TestRunner._run_google_test): Wrote tests timing out to stdout too.
515         (add_options):
516         * glib/glib_test_runner.py: Added.
517         (TestTimeout):
518         (Message):
519         (Message.__init__):
520         (Message.create):
521         (Message.create.read_unsigned):
522         (Message.create.read_double):
523         (Message.create.read_string):
524         (GLibTestRunner):
525         (GLibTestRunner.__init__):
526         (GLibTestRunner._process_data):
527         (GLibTestRunner._process_message):
528         (GLibTestRunner._read_from_pipe):
529         (GLibTestRunner._read_from_stderr):
530         (GLibTestRunner._start_timeout):
531         (GLibTestRunner._start_timeout._alarm_handler):
532         (GLibTestRunner._stop_timeout):
533         (GLibTestRunner._subtest_start):
534         (GLibTestRunner._subtest_message):
535         (GLibTestRunner._subtest_stderr):
536         (GLibTestRunner._subtest_end):
537         (GLibTestRunner.run):
538
539 2018-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
540
541         Unreviewed, add Thibault to contributors.json
542
543         It's a bit weird to add someone here before their first contribution, but this affects
544         Bugzilla autocomplete, and that is serious business.
545
546         * Scripts/webkitpy/common/config/contributors.json:
547
548 2018-01-15  JF Bastien  <jfbastien@apple.com>
549
550         Remove makePoisonedUnique
551         https://bugs.webkit.org/show_bug.cgi?id=181630
552         <rdar://problem/36498623>
553
554         Reviewed by Mark Lam.
555
556         Update tests.
557
558         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
559         (TestWebKitAPI::TEST):
560         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
561         (TestWebKitAPI::TEST):
562
563 2018-01-15  Adrian Perez de Castro  <aperez@igalia.com>
564
565         [GTK][JHBuild] Tools/gtk/install-dependencies: Package libxfont does not exist anymore in Arch Linux
566         https://bugs.webkit.org/show_bug.cgi?id=181476
567
568         Reviewed by Michael Catanzaro.
569
570         Update to xorg-server 1.19.6 which depends on libxfont2, and change
571         the lists of packages to install libxfont2-devel (or equivalent).
572
573         * gtk/install-dependencies:
574         * gtk/jhbuild.modules:
575
576 2018-01-15  Carlos Garcia Campos  <cgarcia@igalia.com>
577
578         [GTK][WPE] Add support for unit test expectations
579         https://bugs.webkit.org/show_bug.cgi?id=181589
580
581         Reviewed by Michael Catanzaro.
582
583         We currently have a way to skip tests by annotating them in the api test runner script. The main problem of this
584         approach is that we skip tests when they fail in the bots and we never notice if they stop failing, keeping the
585         tests skipped forever. This is indeed the case of several WebKit2 C API tests. Annotating skipped tests in the
586         script itself is not a good idea either.
587
588         This patch adds a generic TestExpectations class for simple tests based on tests with subtests, like our unit
589         tests, but also WebDriver tests. It parses a json file with the tests and subtests expectations and provides
590         convenient methods to query them.
591
592         * Scripts/run-gtk-tests:
593         (GtkTestRunner): Remove all Skipped and Slow tests marked here.
594         * Scripts/run-wpe-tests:
595         (WPETestRunner): Ditto.
596         * Scripts/webkitpy/common/test_expectations.py: Added.
597         (TestExpectations):
598         (TestExpectations.__init__):
599         (TestExpectations._port_name_for_expected):
600         (TestExpectations._expected_value):
601         (TestExpectations.skipped_tests):
602         (TestExpectations.skipped_subtests):
603         (TestExpectations._expectation_value):
604         (TestExpectations.is_slow):
605         (TestExpectations.get_expectation):
606         * Scripts/webkitpy/common/test_expectations_unittest.py: Added.
607         (MockTestExpectations):
608         (MockTestExpectations.__init__):
609         (MockTestExpectations.is_skip):
610         (ExpectationsTest):
611         (assert_exp):
612         (assert_not_exp):
613         (assert_bad_exp):
614         (assert_skip):
615         (test_basic):
616         (test_skip):
617         (test_flaky):
618         (test_build_type):
619         * TestWebKitAPI/glib/TestExpectations.json: Added.
620         * glib/api_test_runner.py:
621         (TestRunner): Remove SkippedTest implementation.
622         (TestRunner.__init__): Create a TestExpectations.
623         (TestRunner._test_cases_to_skip): Use TestExpectations to check skipped tests.
624         (TestRunner._should_run_test_program): Ditto.
625         (TestRunner._run_test_glib): Use TestExpectations to check if test suite is slow.
626         (TestRunner._run_test_glib.parse_line.set_test_result): Register also tests passing.
627         (TestRunner._run_google_test): Use TestExpectations to check if test cases is slow and register tests passing.
628         (TestRunner.run_tests): Check if actual result is the expected one and register also unexpected passes.
629         (TestRunner.run_tests.report): Helper to write report to stdout.
630
631 2018-01-13  Mark Lam  <mark.lam@apple.com>
632
633         Replace all use of ConstExprPoisoned with Poisoned.
634         https://bugs.webkit.org/show_bug.cgi?id=181542
635         <rdar://problem/36442138>
636
637         Reviewed by JF Bastien.
638
639         1. Converted tests to using new uintptr_t& poison type.
640         2. Added tests for Poisoned comparison operators.
641
642         * TestWebKitAPI/CMakeLists.txt:
643         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
644         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp: Removed.
645         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
646         (TestWebKitAPI::TEST):
647         (TestWebKitAPI::initializeTestPoison): Deleted.
648         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
649         (TestWebKitAPI::TEST):
650         (TestWebKitAPI::passWithRef):
651         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
652         (TestWebKitAPI::TEST):
653         (TestWebKitAPI::f1):
654         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
655         (TestWebKitAPI::TEST):
656         (TestWebKitAPI::poisonedPtrFoo):
657         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
658         (TestWebKitAPI::TEST):
659         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
660         (TestWebKitAPI::TEST):
661
662 2018-01-13  David Kilzer  <ddkilzer@apple.com>
663
664         check-webkit-style: false positive for [whitespace/braces] with os_log format string
665         <https://webkit.org/b/181606>
666
667         Reviewed by Darin Adler.
668
669         * Scripts/webkitpy/style/checkers/cpp.py:
670         (check_spacing): Modify regular expression to ignore
671         os_log format strings like '%{public}'.
672         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
673         (CppStyleTest.test_spacing_before_braces): Add os_log
674         format string test.
675
676 2018-01-12  Wenson Hsieh  <wenson_hsieh@apple.com>
677
678         [macOS] API tests ChangeAttachmentDataUpdatesWithInPlaceDisplay and InPlaceVideoAttachmentInsertionWithinList are failing
679         https://bugs.webkit.org/show_bug.cgi?id=181626
680
681         Reviewed by Joseph Pecoraro.
682
683         Make the web view for WKAttachmentTests slightly bigger to avoid size clamping behavior introduced in r226915.
684         Additionally, write a new API test covering the change in r226915.
685
686         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
687         (webViewForTestingAttachments):
688         (TestWebKitAPI::TEST):
689
690 2018-01-12  Alex Christensen  <achristensen@webkit.org>
691
692         History state should be updated during client redirects with asynchronous policy decisions
693         https://bugs.webkit.org/show_bug.cgi?id=181358
694         <rdar://problem/35547689>
695
696         Reviewed by Andy Estes.
697
698         * TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm:
699         (-[AsyncPolicyDecisionDelegate webView:didFinishNavigation:]):
700         (-[AsyncPolicyDecisionDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
701         (TEST):
702
703 2018-01-12  Jonathan Bedard  <jbedard@apple.com>
704
705         webkitpy: Refactor simulator code (Part 4)
706         https://bugs.webkit.org/show_bug.cgi?id=180555
707         <rdar://problem/36131381>
708
709         Reviewed by Aakash Jain.
710
711         Move new_simulated_device.py to simulated_device.py.
712
713         * Scripts/webkitpy/port/ios_simulator.py: Update import statement.
714         * Scripts/webkitpy/xcode/new_simulated_device.py: Removed.
715         * Scripts/webkitpy/xcode/new_simulated_device_unittest.py: Removed.
716         * Scripts/webkitpy/xcode/simulated_device.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device.py.
717         * Scripts/webkitpy/xcode/simulated_device_unittest.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device_unittest.py.
718
719 2018-01-12  Alex Christensen  <achristensen@webkit.org>
720
721         REGRESSION (r226818): API test WebKitLegacy.LoadInvalidURLRequest is failing
722         https://bugs.webkit.org/show_bug.cgi?id=181595
723
724         This test was testing behavior of an invalid URL that WebCore parses but NSURL does not.
725         It was using example.com<> but after r226479 < and > are considered invalid by WebCore.
726         I change the < and > to $ to make this test pass and continue to test what it used to.
727
728         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.html:
729         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
730         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
731
732 2018-01-11  Keith Miller  <keith_miller@apple.com>
733
734         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
735         https://bugs.webkit.org/show_bug.cgi?id=181573
736
737         Reviewed by Simon Fraser.
738
739         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
740
741 2018-01-11  Jiewen Tan  <jiewen_tan@apple.com>
742
743         [WebAuthN] Import a CBOR coder from Chromium
744         https://bugs.webkit.org/show_bug.cgi?id=181522
745         <rdar://problem/36055729>
746
747         Reviewed by Brent Fulgham.
748
749         This patch also imports all unit tests into our API tests to ensure all
750         workarounds and modification against the original codebase doesn't change
751         any original functionalities.
752
753         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
754         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp: Added.
755         (TestWebKitAPI::TEST):
756         * TestWebKitAPI/Tests/WebCore/CBORValueTest.cpp: Added.
757         (TestWebKitAPI::TEST):
758         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp: Added.
759         (TestWebKitAPI::eq):
760         Workarounds applied.
761         (TestWebKitAPI::TEST):
762
763 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
764
765         webkitpy: Use partially disambiguated type in SimulatedDeviceManager._disambiguate_device_type
766         https://bugs.webkit.org/show_bug.cgi?id=181538
767         <rdar://problem/36440580>
768
769         Reviewed by Aakash Jain.
770
771         When disambiguating a device type, it is possible that the provided device type is sufficiently
772         ambiguous that the comparisons against complete device types without a disambiguated hardware_family
773         will result in a failure to disambiguate the type.
774
775         * Scripts/webkitpy/xcode/new_simulated_device.py:
776         (SimulatedDeviceManager._disambiguate_device_type):
777
778 2018-01-11  Brent Fulgham  <bfulgham@apple.com>
779
780         REGRESSION(r219530): ResourceLoadStatisticsPersistentStorage should be read-only in ephemeral sessions
781         https://bugs.webkit.org/show_bug.cgi?id=181136
782         <rdar://problem/36116604>
783
784         Reviewed by Chris Dumez.
785
786         Add a new API test to confirm that ResourceLoadStatistics can be turned on safely for ephemeral
787         browsing sessions.
788
789         * Scripts/run-gtk-tests:
790         (GtkTestRunner): Unskip test now that it passes.
791         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
792         (TEST): Add new WebsiteDataStoreEphemeral test.
793
794 2018-01-11  Ryan Haddad  <ryanhaddad@apple.com>
795
796         Unreviewed, rolling out r226816.
797
798         This change broke LayoutTests on the bots.
799
800         Reverted changeset:
801
802         "run-webkit-tests fails when there is a curly brace in Xcode
803         build output"
804         https://bugs.webkit.org/show_bug.cgi?id=181254
805         https://trac.webkit.org/changeset/226816
806
807 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
808
809         webkitpy: Fix flakey webserver tests
810         https://bugs.webkit.org/show_bug.cgi?id=181555
811         <rdar://problem/36448273>
812
813         Reviewed by Aakash Jain.
814
815         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
816         (LayoutTestRunnerTests.test_servers_started): Add and bind custom checks to
817         determine if a specific server is running.
818
819 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
820
821         Commit queue failed to land a bug, 'NoneType' object has no attribute 'strip'
822         https://bugs.webkit.org/show_bug.cgi?id=181561
823         <rdar://problem/36452652>
824
825         Reviewed by Aakash Jain.
826
827         BeautifulSoup.find may return None, this case should be gracefully handled.
828
829         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
830         (BugzillaQueries._parse_result_count):
831         (BugzillaQueries._fetch_bugs_from_advanced_query): Added logging.
832
833 2018-01-11  Alexey Proskuryakov  <ap@apple.com>
834
835         run-webkit-tests fails when there is a curly brace in Xcode build output
836         https://bugs.webkit.org/show_bug.cgi?id=181254
837
838         Reviewed by Daniel Bates.
839
840         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
841         (MeteredStream.write):
842
843 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
844
845         webkitpy: Reimplement simulator code (Part 3)
846         https://bugs.webkit.org/show_bug.cgi?id=180555
847         <rdar://problem/36131381>
848
849         Reviewed by Aakash Jain.
850
851         Remove old simulator code.
852
853         * Scripts/webkitpy/xcode/__init__.py: Remove import statement.
854         * Scripts/webkitpy/xcode/simulated_device.py: Removed.
855         * Scripts/webkitpy/xcode/simulator.py: Removed.
856         * Scripts/webkitpy/xcode/simulator_unittest.py: Removed.
857
858 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
859
860         [Attachment Support] Support moving attachment elements in editable areas using drag and drop
861         https://bugs.webkit.org/show_bug.cgi?id=181337
862         <rdar://problem/36324813>
863
864         Reviewed by Tim Horton.
865
866         Add 3 new API tests for attachment element dragging.
867
868         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
869         (-[TestWKWebView expectElementTag:toComeBefore:]):
870         (-[NSItemProvider expectType:withData:]):
871         (TestWebKitAPI::TEST):
872
873 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
874
875         REGRESSION(r225856): Incorrectly managing 'future' baseline_search_paths. 
876         https://bugs.webkit.org/show_bug.cgi?id=179621
877         <rdar://problem/35589585>
878
879         Unreviewed infrastructure fix.
880
881         * Scripts/webkitpy/port/mac.py:
882         (MacPort.default_baseline_search_path): Include 'future' in the version_fallback
883         list if we are the VERSION_MAX, which usually corresponds with future.
884
885 2018-01-11  Filip Pizlo  <fpizlo@apple.com>
886
887         CodeBlocks should be in IsoSubspaces
888         https://bugs.webkit.org/show_bug.cgi?id=180884
889
890         Reviewed by Saam Barati.
891         
892         Remove some less important benchmarks from the default run. Doing run-jsc-benchmarks
893         shouldn't take a long time due to benchmarks we don't optimize for.
894         
895         * Scripts/run-jsc-benchmarks:
896
897 2018-01-11  Ms2ger  <Ms2ger@igalia.com>
898
899         Test gardening for GTK.
900         https://bugs.webkit.org/show_bug.cgi?id=181477
901
902         Unreviewed test gardening.
903
904         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Correct the file name.
905         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Adjust the expected console message.
906
907 2018-01-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
908
909         Add the new JSCOnly bot to the scheduler.
910         https://bugs.webkit.org/show_bug.cgi?id=181487
911
912         Unreviewed follow-up patch after r226729
913
914         On r226729 I missed to add the new JSCOnly bot the default scheduler.
915         This is needed to make the bot automatically pick each commit for testing.
916
917         * BuildSlaveSupport/build.webkit.org-config/config.json:
918
919 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
920
921         [Attachment Support] Support dragging attachment elements out as files on iOS
922         https://bugs.webkit.org/show_bug.cgi?id=181199
923         <rdar://problem/36299316>
924
925         Reviewed by Tim Horton, Andy Estes and Joseph Pecoraro.
926
927         Add support in the drag and drop simulator for testing blob-backed attachment element dragging, and also add new
928         attachment API tests.
929
930         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
931         (-[NSItemProvider expectType:withData:]):
932         (TestWebKitAPI::TEST):
933
934         Add two new WKAttachmentTests to exercise dragging data- and file-backed blobs via attachment elements. These
935         tests first insert attachments via drop or WKWebView SPI, and then drag these attachments out and use the
936         -expectType:withData: helper to inspect the item providers created from the drag source.
937
938         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
939         (TestWebKitAPI::TEST):
940         * TestWebKitAPI/ios/DataInteractionSimulator.h:
941         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
942         (-[MockDragSession localContext]):
943         (-[MockDragSession setLocalContext:]):
944         (-[DataInteractionSimulator _resetSimulatedState]):
945         (-[DataInteractionSimulator simulateAllTouchesCanceled:]):
946         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
947         (-[DataInteractionSimulator _advanceProgress]):
948         (-[DataInteractionSimulator endDataTransfer]):
949
950         Make some tweaks to the iOS drag and drop simulator. In particular, this patch (1) adds a new hook to tell
951         WebKit that data transfers have been completed, (2) fixes incorrect drop proposal handling when returning
952         UIDropOperationForbidden by replacing _shouldPerformOperation with a UIDropProposal, and (3) teach the
953         MockDragSession to hold on to a localContext.
954
955 2018-01-11  Ali Juma  <ajuma@chromium.org>
956
957         Unreviewed. Add Ali Juma as contributor
958
959         * Scripts/webkitpy/common/config/contributors.json:
960
961 2018-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
962
963         Unreviewed. Update Selenium WebDriver imported tests.
964
965         New version of selenium uses command line options to pass driver and browser binaries to pytest instead of
966         environment variables.
967
968         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
969         (collect): Reorder the arguments to make pytest happy.
970         (run): Ditto.
971         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
972         (WebDriverSeleniumExecutor.__init__): Add driver binary, browser binary and browser args as arguments.
973
974 2018-01-11  Ling Ho  <lingcherd_ho@apple.com>
975
976         Move Commit Queue and EWS Queues to Sierra on Bot Watcher's Dasboard
977         https://bugs.webkit.org/show_bug.cgi?id=181492
978         <rdar://problem/36359679>
979
980         Reviewed by Alexey Proskuryakov. 
981
982 2018-01-10  Adrian Perez de Castro  <aperez@igalia.com>
983
984         [GTK] Tools/gtk/install-dependencies: Packages geoclue, ruby-highline, xorg-utils do not exist in Arch Linux
985         https://bugs.webkit.org/show_bug.cgi?id=181475
986
987         Reviewed by Michael Catanzaro.
988
989         * gtk/install-dependencies: Update package list for Arch Linux, extend
990         message shown at end of installation with additional tips.
991
992 2018-01-10  Wenson Hsieh  <wenson_hsieh@apple.com>
993
994         REGRESSION(r222507): Composition highlight doesn't render when using IME
995         https://bugs.webkit.org/show_bug.cgi?id=181485
996         <rdar://problem/35896516>
997
998         Reviewed by Ryosuke Niwa.
999
1000         Add a `suppressUnderline` argument to TextInputController.setMarkedText. This suppresses the custom underlines
1001         rendered when testing IME on iOS in WebKit2. In this new test, suppressing underline rendering is needed to
1002         allow rendering composition backgrounds (see InlineTextBox::paint).
1003
1004         * DumpRenderTree/ios/TextInputControllerIOS.m:
1005         (+[TextInputController isSelectorExcludedFromWebScript:]):
1006         (+[TextInputController webScriptNameForSelector:]):
1007         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
1008         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
1009         * DumpRenderTree/mac/TextInputControllerMac.m:
1010         (+[TextInputController isSelectorExcludedFromWebScript:]):
1011         (+[TextInputController webScriptNameForSelector:]):
1012         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
1013         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
1014         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
1015         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
1016         (WTR::TextInputController::setMarkedText):
1017         * WebKitTestRunner/InjectedBundle/TextInputController.h:
1018
1019 2018-01-10  JF Bastien  <jfbastien@apple.com>
1020
1021         Poison small JSObject derivatives which only contain pointers
1022         https://bugs.webkit.org/show_bug.cgi?id=181483
1023         <rdar://problem/36407127>
1024
1025         Reviewed by Mark Lam.
1026
1027         Test the new move-assign and move-copy from unique_ptr, as well as
1028         nullptr_t ctors.
1029
1030         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
1031         (TestWebKitAPI::TEST):
1032         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
1033         (TestWebKitAPI::TEST):
1034         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
1035         (TestWebKitAPI::TEST):
1036
1037 2018-01-10  Chris Dumez  <cdumez@apple.com>
1038
1039         Multiple http/wpt/beacon/contentextensions/ test are flaky.
1040         https://bugs.webkit.org/show_bug.cgi?id=179256
1041         <rdar://problem/35401978>
1042
1043         Reviewed by Alex Christensen.
1044
1045         Update WebKitTestRunner to set a temporary path for content extensions so that its WKTR
1046         instance gets its own folder to avoid conflicts and flakiness.
1047
1048         * WebKitTestRunner/mac/TestControllerMac.mm:
1049         (WTR::TestController::platformConfigureViewForTest):
1050
1051 2018-01-10  Tim Horton  <timothy_horton@apple.com>
1052
1053         REGRESSION (r213590): Swipe from edge to go to previous page is significantly slower than tapping back button on Twitter
1054         https://bugs.webkit.org/show_bug.cgi?id=181269
1055         <rdar://problem/35110344>
1056
1057         Reviewed by Simon Fraser.
1058
1059         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1060         (WTR::UIScriptController::beginBackSwipe):
1061         (WTR::UIScriptController::completeBackSwipe):
1062         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1063         (WTR::UIScriptController::beginBackSwipe):
1064         (WTR::UIScriptController::completeBackSwipe):
1065         (WTR::UIScriptController::overridePreference):
1066         (WTR::UIScriptController::replaceTextAtRange):
1067         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1068         (WTR::PlatformWebView::setNavigationGesturesEnabled):
1069         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1070         (WTR::UIScriptController::beginBackSwipe):
1071         (WTR::UIScriptController::completeBackSwipe):
1072         Implement beginBackSwipe and completeBackSwipe on iOS (they already
1073         exist on Mac) in terms of the new WKWebView testing SPI.
1074
1075 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
1076
1077         REGRESSION (r226715): ignore WARNING output in linter tests
1078         https://bugs.webkit.org/show_bug.cgi?id=181486
1079         <rdar://problem/36408847>
1080
1081         Reviewed by Aakash Jain.
1082
1083         Linter unit tests should not be interested in logs at the the INFO or WARNING levels.
1084
1085         * Scripts/webkitpy/common/system/outputcapture.py:
1086         (OutputCapture.__init__): Pass logging level to be captured.
1087         * Scripts/webkitpy/style/main_unittest.py:
1088         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors): Capture logging at the ERROR level.
1089         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Ditto.
1090         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit): Ditto.
1091         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Ditto.
1092         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Ditto.
1093         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Ditto.
1094         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file): Ditto.
1095         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit): Ditto.
1096
1097 2018-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1098
1099         Add a JSCOnly MIPS buildbot
1100         https://bugs.webkit.org/show_bug.cgi?id=181487
1101
1102         Reviewed by Michael Catanzaro.
1103
1104         Add the new bot configs definitions for the master and update the unit tests.
1105
1106         * BuildSlaveSupport/build.webkit.org-config/config.json:
1107         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1108
1109 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
1110
1111         REGRESSION (r226715): don't re-check number of simulators in child processes
1112         https://bugs.webkit.org/show_bug.cgi?id=181484
1113         <rdar://problem/36407151>
1114
1115         Reviewed by Aakash Jain.
1116
1117         * Scripts/webkitpy/port/ios_simulator.py:
1118         (IOSSimulatorPort.__init__): Skip the number of simulators check if simulators
1119         are already initialized.
1120
1121 2018-01-10  Commit Queue  <commit-queue@webkit.org>
1122
1123         Unreviewed, rolling out r226667 and r226673.
1124         https://bugs.webkit.org/show_bug.cgi?id=181488
1125
1126         This caused a flaky crash. (Requested by mlewis13 on #webkit).
1127
1128         Reverted changesets:
1129
1130         "CodeBlocks should be in IsoSubspaces"
1131         https://bugs.webkit.org/show_bug.cgi?id=180884
1132         https://trac.webkit.org/changeset/226667
1133
1134         "REGRESSION (r226667): CodeBlocks should be in IsoSubspaces"
1135         https://bugs.webkit.org/show_bug.cgi?id=180884
1136         https://trac.webkit.org/changeset/226673
1137
1138 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
1139
1140         Follow-up fix to r226715
1141         https://bugs.webkit.org/show_bug.cgi?id=180555
1142         <rdar://problem/36131381>
1143
1144         Unreviewed infrastructure fix.
1145
1146         * Scripts/webkitpy/xcode/new_simulated_device.py:
1147         (SimulatedDeviceManager._create_or_find_device_for_request): Use _delete instead
1148         of delete.
1149
1150 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
1151
1152         webkitpy: Refactor simulator code (Part 2)
1153         https://bugs.webkit.org/show_bug.cgi?id=180555
1154         <rdar://problem/36131381>
1155
1156         Reviewed by Aakash Jain.
1157
1158         The patch leverages the SimulatedDeviceManager when running layout tests.
1159         This patch is primarily code removal, since much of the IOSSimulatorPort
1160         was dedicated to managing simulators. The removed code is either now owned by the
1161         SimulatedDeviceManager (and committed in Part 1) or supported a technique to
1162         boot multiple simulators which was made obsolete in Xcode 9.
1163
1164         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1165         (Manager._custom_device_for_test.in): Device names now have spaces in them,
1166         strip those spaces.
1167         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1168         (parse_args): Remove '--runtime' flag, this is achieved with the --version flag.
1169         * Scripts/webkitpy/port/ios.py:
1170         (IOSPort.__init__): The _current_device idiom is no longer required since the
1171         SimulatedDeviceManager keeps track of any previously booted devices.
1172         (IOSPort.target_host): Even when only a single device is used, it will be accessed
1173         through the array of managed devices.
1174         (IOSPort.using_multiple_devices): Deleted.
1175         * Scripts/webkitpy/port/ios_device.py:
1176         (IOSDevicePort.using_multiple_devices): Deleted.
1177         * Scripts/webkitpy/port/ios_simulator.py:
1178         (IOSSimulatorPort): Remove constants required to manage simulators, change device
1179         class strings so they can be parsed by the DeviceType class.
1180         (IOSSimulatorPort.__init__): Determine the number of processes to use by checking
1181         the number of simulators currently booted, the number of child processes specified
1182         and the maximum number of simulators supported by this system.
1183         (IOSSimulatorPort._device_for_worker_number_map):Return the array of initialized
1184         devices owned by the SimulatedDeviceManager.
1185         (IOSSimulatorPort.ios_version): Remove support for the --runtime option.
1186         (IOSSimulatorPort.default_child_processes): Use the SimulatedDeviceManager to check
1187         the maximum number of supported simulators on this system.
1188         (IOSSimulatorPort._create_devices): Construct a list of device requests with a
1189         request for each child process and send this list to the SimulatedDeviceManager to
1190         initialize the devices.
1191         (IOSSimulatorPort.clean_up_test_run):
1192         (IOSSimulatorPort.check_sys_deps): Check that there are simulators running the
1193         specified version of iOS.
1194         (IOSSimulatorPort.reset_preferences):
1195         (IOSSimulatorPort.simulator_runtime): Deleted.
1196         (IOSSimulatorPort.simulator_device_type): Deleted.
1197         (IOSSimulatorPort._teardown_managed_simulators): Deleted.
1198         (IOSSimulatorPort.use_multiple_simulator_apps): Deleted.
1199         (IOSSimulatorPort._create_simulators): Deleted.
1200         (IOSSimulatorPort._quit_ios_simulator): Deleted.
1201         (IOSSimulatorPort._using_dedicated_simulators): Deleted.
1202         (IOSSimulatorPort.using_multiple_devices): Deleted.
1203         (IOSSimulatorPort._create_device): Deleted.
1204         (IOSSimulatorPort.get_simulator_path): Deleted.
1205         (IOSSimulatorPort._createSimulatorApps): Deleted.
1206         (IOSSimulatorPort._createSimulatorApp): Deleted.
1207         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1208         (TestRebaseline.test_rebaseline): Filter out commands run when determining the
1209         maximum number of simulators run on this system.
1210         (TestRebaselineExpectations.test_rebaseline_expectations): Ditto.
1211         * Scripts/webkitpy/xcode/new_simulated_device.py:
1212         (SimulatedDeviceManager._does_fulfill_request): Fixed log statement.
1213
1214 2018-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1215
1216         WebDriver: run-webdriver-tests doesn't handle test names with a '/' correctly
1217         https://bugs.webkit.org/show_bug.cgi?id=181474
1218
1219         Reviewed by Carlos Alberto Lopez Perez.
1220
1221         We use os.path.basename() to get the subtest name. If the test name contains a slash we get part of the subtest
1222         name as the name.
1223
1224         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1225         (WebDriverTestRunnerW3C._subtest_name): Helper function to get the subtest name.
1226         (WebDriverTestRunnerW3C.run): Use _subtest_name() instead of os.path.basename().
1227
1228 2018-01-09  Andy Estes  <aestes@apple.com>
1229
1230         [Xcode] Use the Apple Internal SDK if available when building ImageDiff
1231         https://bugs.webkit.org/show_bug.cgi?id=181459
1232
1233         Reviewed by Dan Bernstein.
1234
1235         * ImageDiff/cg/Configurations/Base.xcconfig:
1236
1237 2018-01-09  Myles C. Maxfield  <mmaxfield@apple.com>
1238
1239         font-display:fallback can cause a visual flash (which is supposed to be impossible)
1240         https://bugs.webkit.org/show_bug.cgi?id=181374
1241
1242         Reviewed by Simon Fraser.
1243
1244         The test requires Palatino.
1245
1246         * DumpRenderTree/mac/DumpRenderTree.mm:
1247         (allowedFontFamilySet):
1248         * WebKitTestRunner/mac/TestControllerMac.mm:
1249         (WTR::allowedFontFamilySet):
1250
1251 2018-01-09  Saam Barati  <sbarati@apple.com>
1252
1253         Give some slack in display-profiler-outputs computation of the terminal window's number of columns
1254         https://bugs.webkit.org/show_bug.cgi?id=181449
1255
1256         Reviewed by JF Bastien.
1257
1258         This allows me to Cmd+f in my terminal to search for things without
1259         having the results become misaligned.
1260
1261         * Scripts/display-profiler-output:
1262
1263 2018-01-09  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1264
1265         [webkitpy] PlatformInfo should have default argument for casual use
1266         https://bugs.webkit.org/show_bug.cgi?id=180827
1267
1268         Reviewed by David Kilzer.
1269
1270         PlatformInfo should be the only way to check platform specific thing instead
1271         of sys.platform or other various checks. If there is something you want to check,
1272         it should be placed in PlatformInfo.
1273
1274         Currently to instantiate PlatformInfo, it requires arguments, which is usually
1275         sys, platform and Executive(). They are straight forward and should be handled
1276         by default arguments. Then we can instantiate PlatformInfo more casual.
1277
1278         * Scripts/webkitpy/common/system/platforminfo.py:
1279         (PlatformInfo): Use relative module path import
1280         (PlatformInfo.__init__):
1281         (PlatformInfo.executive): Lazy instantiation of Executive()
1282         (PlatformInfo.total_bytes_memory): Accessing via above property
1283         (PlatformInfo.xcode_sdk_version): Ditto
1284         (PlatformInfo.xcode_simctl_list): Ditto
1285         (PlatformInfo.xcode_version): Ditto
1286         (PlatformInfo._win_version_str): Ditto
1287         * Scripts/webkitpy/common/system/systemhost.py:
1288         (SystemHost.__init__):
1289         * Scripts/webkitpy/common/system/user.py:
1290         (User.__init__):
1291
1292 2018-01-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1293
1294         [Win] Remove workaround for Bug 176442 after stopping MSVC 2015 support
1295         https://bugs.webkit.org/show_bug.cgi?id=176443
1296
1297         Reviewed by Darin Adler.
1298
1299         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
1300         (TEST):
1301
1302 2018-01-09  Frederic Wang  <fwang@igalia.com.fr>
1303
1304         check-webkit-style: Verify syntax for WK_API_AVAILABLE
1305         https://bugs.webkit.org/show_bug.cgi?id=181394
1306
1307         Reviewed by Darin Adler.
1308
1309         A common syntax error for WK_API_AVAILABLE is to write ios(WK_MAC_TBA)
1310         as the second parameter instead of ios(WK_IOS_TBA). This generally
1311         builds for iOS on EWS but not when using the public SDK. See r224057,
1312         r223207 and r226211 for example. This patch adds a basic style check
1313         for that macro to prevent this kind of mistake.
1314
1315         * Scripts/webkitpy/style/checkers/cpp.py:
1316         (check_min_versions_of_wk_api_available): New function to verify the parameters of WX_API_AVAILABLE.
1317         (check_style): Run new style check.
1318         (CppChecker): Add build type for the new style check.
1319         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1320         (WebKitStyleTest.test_min_versions_of_wk_api_available): Add tests for the new style check.
1321
1322 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1323
1324         [Attachment Support] Expose HTMLAttachmentElement.uniqueIdentifier to bindings
1325         https://bugs.webkit.org/show_bug.cgi?id=181420
1326         <rdar://problem/36365827>
1327
1328         Reviewed by Alex Christensen.
1329
1330         Adjusts some existing API tests to verify that attachment elements' uniqueIdentifiers match the uniqueIdentifier
1331         of corresponding _WKAttachments.
1332
1333         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1334         (TestWebKitAPI::TEST):
1335
1336 2018-01-08  Alex Christensen  <achristensen@webkit.org>
1337
1338         Add WKNavigationDelegate SPI exposing WebProcess crash reason
1339         https://bugs.webkit.org/show_bug.cgi?id=181410
1340         <rdar://problem/36167199>
1341
1342         Reviewed by Wenson Hsieh.
1343
1344         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
1345         (-[CrashReasonDelegate _webView:webContentProcessDidTerminateWithReason:]):
1346         (TEST):
1347
1348 2018-01-08  Alex Christensen  <achristensen@webkit.org>
1349
1350         Add SPI for WKOpenPanelParameters._acceptedMIMETypes and _acceptedFileExtensions
1351         https://bugs.webkit.org/show_bug.cgi?id=181408
1352         <rdar://problem/35884960>
1353
1354         Reviewed by Tim Horton.
1355
1356         * TestWebKitAPI/Tests/WebKitCocoa/RunOpenPanel.mm:
1357         (-[RunOpenPanelUIDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
1358
1359 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1360
1361         [Attachment Support] Expose file name and content type of WKAttachment
1362         https://bugs.webkit.org/show_bug.cgi?id=181390
1363         <rdar://problem/36336837>
1364
1365         Reviewed by Tim Horton.
1366
1367         Adjusts some existing tests in WKAttachmentTests to exercise -requestInfo:.
1368
1369         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1370         (-[_WKAttachment synchronouslyRequestInfo:]):
1371         (-[_WKAttachment synchronouslyRequestData:]):
1372
1373         Reimplement this in terms of -synchronouslyRequestInfo:.
1374
1375         (-[_WKAttachment expectRequestedDataToBe:]):
1376         (TestWebKitAPI::TEST):
1377
1378 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1379
1380         Copying, pasting, and then deleting an attachment element breaks attachment data requests
1381         https://bugs.webkit.org/show_bug.cgi?id=181365
1382         <rdar://problem/36340647>
1383
1384         Reviewed by Tim Horton.
1385
1386         Adds two new attachment API tests to verify that copying and pasting an existing attachment inserts an
1387         attachment element that may be edited independently of the original attachment. See WebCore/ChangeLog for more
1388         detail.
1389
1390         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1391         (TestWebKitAPI::TEST):
1392
1393 2018-01-08  Youenn Fablet  <youenn@apple.com>
1394
1395         navigator.onLine does not work inside service workers
1396         https://bugs.webkit.org/show_bug.cgi?id=181079
1397         <rdar://problem/36178606>
1398
1399         Reviewed by Darin Adler.
1400
1401         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1402         (WTR::InjectedBundle::initialize): Setting service worker creation callback to inject ServiceWorkerInternals object.
1403
1404 2018-01-07  Saam Barati  <sbarati@apple.com>
1405
1406         Add total exits and total compilations sorting mode to the "full" command in display-profiler-output
1407         https://bugs.webkit.org/show_bug.cgi?id=181372
1408
1409         Reviewed by Filip Pizlo.
1410
1411         Adding these sorting modes makes it easier to analyze functions
1412         that recompile a lot and exit a lot.
1413
1414         * Scripts/display-profiler-output:
1415
1416 2018-01-06  Julien Brianceau  <julien.brianceau@gmail.com>
1417
1418         Unreviewed, remove my Cisco email from contributors.json
1419
1420         * Scripts/webkitpy/common/config/contributors.json:
1421
1422 2018-01-05  JF Bastien  <jfbastien@apple.com>
1423
1424         WebAssembly: poison JS object's secrets
1425         https://bugs.webkit.org/show_bug.cgi?id=181339
1426         <rdar://problem/36325001>
1427
1428         Reviewed by Mark Lam.
1429
1430         Update tests for swap(Poisoned<k, T>, T*)
1431
1432         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp:
1433         (TestWebKitAPI::TEST):
1434         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
1435         (TestWebKitAPI::TEST):
1436         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
1437         (TestWebKitAPI::TEST):
1438
1439 2018-01-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1440
1441         REGRESSION(r226396) DataInteractionTests: ContentEditableToContentEditable and ContentEditableToTextarea are failing
1442         https://bugs.webkit.org/show_bug.cgi?id=181359
1443
1444         Reviewed by Tim Horton.
1445
1446         Ensure that these tests still pass using older SDKs.
1447
1448         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1449         (TestWebKitAPI::TEST):
1450
1451 2018-01-05  Alex Christensen  <achristensen@webkit.org>
1452
1453         Rebase API test after r226469
1454         https://bugs.webkit.org/show_bug.cgi?id=181308
1455
1456         * TestWebKitAPI/Tests/WebKitCocoa/LoadInvalidURLRequest.mm:
1457         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
1458         A URL with < or > in it is now recognized as invalid by WebKit.  This is intentional, and matches our behavior before enabling the new URLParser.
1459
1460 2018-01-05  Alex Christensen  <achristensen@webkit.org>
1461
1462         Restrict navigation-time WKWebsiteDataStore swapping to main frame navigations
1463         https://bugs.webkit.org/show_bug.cgi?id=181217
1464
1465         Reviewed by Tim Horton.
1466
1467         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1468         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1469         (TEST):
1470
1471 2018-01-05  Alex Christensen  <achristensen@webkit.org>
1472
1473         Add WKBundleFrameCreateFrameHandle
1474         https://bugs.webkit.org/show_bug.cgi?id=181232
1475         <rdar://problem/35926696>
1476
1477         Reviewed by Tim Horton.
1478
1479         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1480         * TestWebKitAPI/Tests/WebKitCocoa/FrameHandleSerialization.mm: Added.
1481         (mouseDidMoveOverElement):
1482         (-[FrameHandleSerialization webProcessPlugIn:didCreateBrowserContextController:]):
1483         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1484         (-[MouseMoveOverElementDelegate _webView:mouseDidMoveOverElement:withFlags:userInfo:]):
1485         (TEST):
1486
1487 2018-01-05  Chris Fleizach  <cfleizach@apple.com>
1488
1489         iOS: Build fix after r226432.
1490         
1491         Unreviewed. Stop duplicating speakAs symbols for iOS.
1492
1493         * DumpRenderTree/AccessibilityUIElement.cpp:
1494         (AccessibilityUIElement::speakAs):
1495
1496 2018-01-05  Javier Fernandez  <jfernandez@igalia.com>
1497
1498         Unreviewed, added myself as WebKit reviewer
1499
1500         * Scripts/webkitpy/common/config/contributors.json:
1501
1502 2018-01-05  Claudio Saavedra  <csaavedra@igalia.com>
1503
1504         WPE: Build fix after r226432.
1505
1506         Unreviewed. Rename ::speak() to ::speakAs().
1507         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
1508         (WTR::AccessibilityUIElement::speakAs):
1509         (WTR::AccessibilityUIElement::speak): Deleted.
1510
1511 2018-01-04  Chris Fleizach  <cfleizach@apple.com>
1512
1513         AX: Implement updated CSS3 Speech for 'speak' and 'speak-as' properties
1514         https://bugs.webkit.org/show_bug.cgi?id=180361
1515
1516         Reviewed by Zalan Bujtas.
1517
1518         * DumpRenderTree/AccessibilityUIElement.cpp:
1519         (speakAsCallback):
1520         (AccessibilityUIElement::speakAs):
1521         (AccessibilityUIElement::getJSClass):
1522         (speakCallback): Deleted.
1523         (AccessibilityUIElement::speak): Deleted.
1524         * DumpRenderTree/AccessibilityUIElement.h:
1525         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1526         (AccessibilityUIElement::speakAs):
1527         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1528         (AccessibilityUIElement::speakAs):
1529         (AccessibilityUIElement::speak): Deleted.
1530         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1531         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1532         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1533         (WTR::AccessibilityUIElement::speakAs):
1534         (WTR::AccessibilityUIElement::speak): Deleted.
1535         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1536         (WTR::AccessibilityUIElement::speakAs):
1537         (WTR::AccessibilityUIElement::speak): Deleted.
1538
1539 2018-01-04  Jonathan Bedard  <jbedard@apple.com>
1540
1541         REGRESSION (r226395): test-webkitperl test expectations incorrect
1542         https://bugs.webkit.org/show_bug.cgi?id=181307
1543         <rdar://problem/36306558>
1544
1545         Rubber-stamped by Aakash Jain.
1546
1547         r226395 added two lines towards the beginning of
1548         Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl, the line
1549         numbers in the test expectations need to update.
1550
1551         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
1552
1553 2018-01-04  Tim Horton  <timothy_horton@apple.com>
1554
1555         WKWebView loses minimum layout size overrides that happen while the process is terminated
1556         https://bugs.webkit.org/show_bug.cgi?id=181306
1557         <rdar://problem/34398288>
1558
1559         Reviewed by Dan Bernstein.
1560
1561         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
1562         (TEST):
1563         Add a test that calling _overrideLayoutParametersWithMinimumLayoutSize
1564         while the process is terminated results in the page getting the correct
1565         minimum layout size.
1566
1567 2018-01-04  Eric Carlson  <eric.carlson@apple.com>
1568
1569         [MediaStream] Add Mock screen capture source
1570         https://bugs.webkit.org/show_bug.cgi?id=181291
1571         <rdar://problem/36298164>
1572
1573         Reviewed by Dean Jackson.
1574
1575         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test.
1576         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
1577         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
1578
1579 2018-01-04  Lucas Forschler  <lforschler@apple.com>
1580
1581         <rdar://problem/36300930> Change proxy server setting on master config to reach s3 servers
1582
1583         Reviewed by Ling Ho.
1584
1585         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1586
1587 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1588
1589         [Attachment Support] Create attachment elements when dropping files on iOS
1590         https://bugs.webkit.org/show_bug.cgi?id=181192
1591         <rdar://problem/36280945>
1592
1593         Reviewed by Tim Horton.
1594
1595         Adds 3 new API tests to exercise different use cases of dropping content as attachment elements when the runtime
1596         switch is enabled. See below for more details.
1597
1598         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1599         (-[NSItemProvider registerData:type:]):
1600         (platformCopyPNG):
1601         (TestWebKitAPI::TEST):
1602         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1603
1604         Fix some currently failing iOS drag and drop tests. In this case, there's no reason RTFD should appear in the
1605         source item provider when dragging rich text *without* attachments, so this should have been a check for just
1606         kUTTypeRTF instead.
1607
1608         (TestWebKitAPI::TEST):
1609
1610         Tests a few cases of inserting attachment elements via drop:
1611         1.  We should distinguish between drops containing rich/plain text files from just dropping rich/plain text.
1612             Instead of inserting the contents as inline web content, this should generate attachment elements.
1613         2.  Test the fallback mechanism for inserting attachment elements. If the preferred presentation style is not
1614             explicitly set, but there's nothing WebKit would otherwise do with the dropped content, then we should fall
1615             back to inserting the content as an attachment.
1616         3.  Test that if multiple attachments and inline item providers are present, WebKit will respect the order in
1617             which they were inserted by the source (as opposed to, for instance, putting all of the attachments in front
1618             or at the end).
1619
1620         * TestWebKitAPI/cocoa/TestWKWebView.h:
1621         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1622         (-[TestWKWebView objectByEvaluatingJavaScript:]):
1623
1624         Add a helper method to return an object that represents the result of evaluating some given script, and rewrite
1625         -stringByEvaluatingJavaScript to just turn around and call this.
1626
1627         (-[TestWKWebView stringByEvaluatingJavaScript:]):
1628
1629 2018-01-03  Ting-Wei Lan  <lantw44@gmail.com>
1630
1631         Replace hard-coded paths in shebangs with #!/usr/bin/env
1632         https://bugs.webkit.org/show_bug.cgi?id=181040
1633
1634         Reviewed by Alex Christensen.
1635
1636         * BuildSlaveSupport/build-launcher-app:
1637         * BuildSlaveSupport/build-launcher-dmg:
1638         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1639         * BuildSlaveSupport/built-product-archive:
1640         * BuildSlaveSupport/clean-build:
1641         * BuildSlaveSupport/delete-stale-build-files:
1642         * BuildSlaveSupport/download-built-product:
1643         * BuildSlaveSupport/gtk/buildbot/log/run:
1644         * BuildSlaveSupport/gtk/buildbot/run:
1645         * BuildSlaveSupport/gtk/pulseaudio/run:
1646         * BuildSlaveSupport/kill-old-processes:
1647         * BuildSlaveSupport/test-result-archive:
1648         * BuildSlaveSupport/win/kill-old-processes:
1649         * Scripts/SpacingHeuristics.pm:
1650         * Scripts/add-include:
1651         * Scripts/build-api-tests:
1652         * Scripts/build-dumprendertree:
1653         * Scripts/build-imagediff:
1654         * Scripts/build-jsc:
1655         * Scripts/build-webkit:
1656         * Scripts/build-webkittestrunner:
1657         * Scripts/check-Xcode-source-file-types:
1658         * Scripts/check-dom-results:
1659         * Scripts/check-for-exit-time-destructors:
1660         * Scripts/check-for-global-initializers:
1661         * Scripts/check-for-inappropriate-objc-class-names:
1662         * Scripts/check-for-weak-vtables-and-externals:
1663         * Scripts/clean-header-guards:
1664         * Scripts/compare-timing-files:
1665         * Scripts/configure-xcode-for-ios-development:
1666         * Scripts/copy-webkitlibraries-to-product-directory:
1667         * Scripts/create-exports:
1668         * Scripts/debug-minibrowser:
1669         * Scripts/debug-safari:
1670         * Scripts/debug-test-runner:
1671         * Scripts/do-file-rename:
1672         * Scripts/do-webcore-rename:
1673         * Scripts/dump-webkit-tests-run:
1674         * Scripts/ensure-valid-python:
1675         * Scripts/execAppWithEnv:
1676         * Scripts/extract-localizable-js-strings:
1677         * Scripts/filter-build-webkit:
1678         * Scripts/find-extra-includes:
1679         * Scripts/fix-blink-patch:
1680         * Scripts/generate-coverage-data:
1681         * Scripts/git-add-reviewer:
1682         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
1683         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
1684         * Scripts/jsc-stress-test-helpers/js-osr-exit-fuzz:
1685         * Scripts/make-new-script-test:
1686         * Scripts/make-script-test-wrappers:
1687         * Scripts/package-root:
1688         * Scripts/parse-malloc-history:
1689         * Scripts/report-include-statistics:
1690         * Scripts/resolve-ChangeLogs:
1691         * Scripts/run-api-tests:
1692         * Scripts/run-bindings-tests:
1693         * Scripts/run-content-extension-tester:
1694         * Scripts/run-iexploder-tests:
1695         * Scripts/run-javascriptcore-tests:
1696         * Scripts/run-jsc:
1697         * Scripts/run-leaks:
1698         * Scripts/run-mangleme-tests:
1699         * Scripts/run-minibrowser:
1700         * Scripts/run-pageloadtest:
1701         * Scripts/run-regexp-tests:
1702         * Scripts/run-safari:
1703         * Scripts/run-sunspider:
1704         * Scripts/run-test-runner:
1705         * Scripts/run-webkit-app:
1706         * Scripts/run-webkit-httpd:
1707         * Scripts/run-webkit-websocketserver:
1708         * Scripts/set-webkit-configuration:
1709         * Scripts/show-pretty-diff:
1710         * Scripts/sort-Xcode-project-file:
1711         * Scripts/split-file-by-class:
1712         * Scripts/sunspider-compare-results:
1713         * Scripts/svn-apply:
1714         * Scripts/svn-unapply:
1715         * Scripts/test-webkit-scripts:
1716         * Scripts/test-webkitperl:
1717         * Scripts/update-iexploder-cssproperties:
1718         * Scripts/update-javascriptcore-test-results:
1719         * Scripts/update-webkit:
1720         * Scripts/update-webkit-auxiliary-libs:
1721         * Scripts/update-webkit-dependency:
1722         * Scripts/update-webkit-libs-jhbuild:
1723         * Scripts/update-webkit-localizable-strings:
1724         * Scripts/update-webkit-support-libs:
1725         * Scripts/update-webkitgtk-libs:
1726         * Scripts/update-webkitwpe-libs:
1727         * Scripts/webkit-build-directory:
1728         * Scripts/webkitperl/LoadAsModule.pm:
1729         * Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
1730         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
1731         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl:
1732         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl:
1733         * Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl:
1734         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
1735         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
1736         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
1737         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
1738         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
1739         * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl:
1740         * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
1741         * Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl:
1742         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
1743         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
1744         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
1745         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
1746         * Scripts/webkitperl/VCSUtils_unittest/parseUnifiedDiffHeader.pl:
1747         * Scripts/webkitperl/VCSUtils_unittest/prepareParsedPatch.pl:
1748         * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl:
1749         * Scripts/webkitperl/VCSUtils_unittest/runCommand.pl:
1750         * Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl:
1751         * Scripts/webkitperl/VCSUtils_unittest/setChangeLogDateAndReviewer.pl:
1752         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl:
1753         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl:
1754         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
1755         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl:
1756         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl:
1757         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl:
1758         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
1759         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
1760         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
1761         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl:
1762         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl:
1763         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl:
1764         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
1765         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
1766         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl:
1767         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl:
1768         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
1769         * ccache/ccache-clang:
1770         * ccache/ccache-clang++:
1771         * ccache/ccache-wrapper:
1772         * gtk/install-dependencies:
1773         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi:
1774         * iExploder/iexploder-1.3.2/htdocs/webserver.rb:
1775         * iExploder/iexploder-1.3.2/tools/lasthit.rb:
1776         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb:
1777         * iExploder/iexploder-1.3.2/tools/showtest.rb:
1778         * iExploder/iexploder-1.7.2/src/browser_harness.rb:
1779         * iExploder/iexploder-1.7.2/src/iexploder.cgi:
1780         * iExploder/iexploder-1.7.2/src/webserver.rb:
1781         * iExploder/iexploder-1.7.2/tools/lasthit.rb:
1782         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb:
1783         * wpe/install-dependencies:
1784
1785 2018-01-03  Simon Fraser  <simon.fraser@apple.com>
1786
1787         filter-build-webkit filters out useful compiler error lines
1788         https://bugs.webkit.org/show_bug.cgi?id=179864
1789
1790         Reviewed by Tim Horton.
1791
1792         Don't filter out lines that contain information about build errors by always showing lines
1793         after a line that contains "note:" or "error:".
1794
1795         * Scripts/filter-build-webkit:
1796         (shouldShowSubsequentLine):
1797         (shouldIgnoreLine):
1798
1799 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1800
1801         REGRESSION(r226366): [GTK] Broke TestBackForwardList and TestWebKitWebView
1802         https://bugs.webkit.org/show_bug.cgi?id=173915
1803
1804         Unreviewed follow-up. Fix /webkit2/WebKitWebView/session-state-with-form-data and
1805         /webkit2/WebKitWebView/submit-form. The form ID may be NULL, but we can't put NULL into a
1806         GVariant unless we use maybe types, and maybe types are incompatible with D-Bus. So use an
1807         empty string in this case.
1808
1809         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1810         (emitFormSubmissionEvent):
1811
1812 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1813
1814         [GTK] Add web process API to detect when form is submitted via JavaScript
1815         https://bugs.webkit.org/show_bug.cgi?id=173915
1816
1817         Reviewed by Carlos Garcia Campos.
1818
1819         Test it.
1820
1821         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1822         (FormSubmissionTest::FormSubmissionTest):
1823         (FormSubmissionTest::~FormSubmissionTest):
1824         (FormSubmissionTest::testFormSubmissionResult):
1825         (FormSubmissionTest::willSendDOMEventCallback):
1826         (FormSubmissionTest::willCompleteCallback):
1827         (FormSubmissionTest::runJavaScriptAndWaitUntilFormSubmitted):
1828         (testWebExtensionFormSubmissionSteps):
1829         (beforeAll):
1830         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1831         (DelayedSignal::DelayedSignal):
1832         (emitFormSubmissionEvent):
1833         (handleFormSubmissionCallback):
1834         (willSubmitFormCallback):
1835         (pageCreatedCallback):
1836
1837 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1838
1839         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/databases
1840         https://bugs.webkit.org/show_bug.cgi?id=181251
1841
1842         * Scripts/run-gtk-tests:
1843         (GtkTestRunner):
1844
1845 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1846
1847         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/ephemeral
1848         https://bugs.webkit.org/show_bug.cgi?id=181136
1849
1850         * Scripts/run-gtk-tests:
1851         (GtkTestRunner):
1852
1853 2018-01-02  Brent Fulgham  <bfulgham@apple.com>
1854
1855         [macOS, iOS] Adopt new secure coding APIs in WebKit
1856         https://bugs.webkit.org/show_bug.cgi?id=181085
1857         <rdar://problem/34837397>
1858
1859         Reviewed by Tim Horton.
1860
1861         Update API tests to use secure coding wherever possible. Currently, NSView/UIView-based classes are not
1862         capable of supporting NSSecureCoding, so pass through the current coding routines.
1863
1864         * TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm: Updated for NSSecureCoding.
1865         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm:
1866         (encodeAndDecode): Check if class supports the NSSecureCoding protocol and use non-secure coding
1867         routines if necessary.
1868         (TEST): Updated for NSSecureCoding.
1869         * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm:
1870         (TestWebKitAPI::TEST): Updated for NSSecureCoding.
1871
1872 2017-12-28  Yusuke Suzuki  <utatane.tea@gmail.com>
1873
1874         Remove std::chrono completely
1875         https://bugs.webkit.org/show_bug.cgi?id=181186
1876
1877         Reviewed by Alex Christensen.
1878
1879         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1880         (WTR::TestController::platformRunUntil):
1881
1882 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1883
1884         REGRESSION(r223253): Broke ResourceLoadStatistics layout tests for non-Cocoa ports
1885         https://bugs.webkit.org/show_bug.cgi?id=181231
1886
1887         Reviewed by Alex Christensen.
1888
1889         Implement TestController APIs needed by ResourceLoadStatistics tests.
1890
1891         * WebKitTestRunner/TestController.cpp:
1892         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
1893         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
1894
1895 2018-01-02  Tim Horton  <timothy_horton@apple.com>
1896
1897         Disable WKAttachmentTests if UIPasteboard.itemProviders is not available
1898         https://bugs.webkit.org/show_bug.cgi?id=181219
1899
1900         Reviewed by Wenson Hsieh.
1901
1902         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1903
1904 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1905
1906         Add a WebAuthentication runtime feature flag
1907         https://bugs.webkit.org/show_bug.cgi?id=181220
1908         <rdar://problem/36055305>
1909
1910         Reviewed by Brent Fulgham.
1911
1912         Renames the CredentialManagement runtime feature flag into WebAuthentication.
1913
1914         * DumpRenderTree/TestOptions.h:
1915         * DumpRenderTree/TestOptions.mm:
1916         (TestOptions::TestOptions):
1917         * DumpRenderTree/mac/DumpRenderTree.mm:
1918         (enableExperimentalFeatures):
1919         (setWebPreferencesForTestOptions):
1920         * WebKitTestRunner/TestController.cpp:
1921         (WTR::TestController::resetPreferencesToConsistentValues):
1922         (WTR::updateTestOptionsFromTestHeader):
1923         * WebKitTestRunner/TestOptions.h:
1924         (WTR::TestOptions::hasSameInitializationOptions const):
1925
1926 2018-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1927
1928         [Attachment Support] Don't Blob-convert images and attachments with https:, http: or data: urls
1929         https://bugs.webkit.org/show_bug.cgi?id=181143
1930         <rdar://problem/36200381>
1931
1932         Reviewed by Tim Horton.
1933
1934         Add a new API test to ensure that a copied image with a data URL does not get pasted as an attachment when
1935         attachment elements are enabled.
1936
1937         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1938         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1939         (TestWebKitAPI::TEST):
1940
1941 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1942
1943         Update Credential Management API for WebAuthentication
1944         https://bugs.webkit.org/show_bug.cgi?id=181082
1945         <rdar://problem/36055239>
1946
1947         Reviewed by Brent Fulgham.
1948
1949         Enable Credential Management API for testing.
1950
1951         * DumpRenderTree/TestOptions.h:
1952         * WebKitTestRunner/TestOptions.h:
1953
1954 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1955
1956         [GTK] Test /webkit2/WebKitWebExtension/form-controls-associated-signal is flaky
1957         https://bugs.webkit.org/show_bug.cgi?id=168194
1958
1959         Reviewed by Carlos Garcia Campos.
1960
1961         Fix an assertion and unskip the test. The order that form controls are associated is not
1962         guaranteed.
1963
1964         * Scripts/run-gtk-tests:
1965         (GtkTestRunner):
1966         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1967         (didAssociateFormControlsCallback):
1968
1969 2018-01-02  Alex Christensen  <achristensen@webkit.org>
1970
1971         Use new WebsiteDataStore passed in through decidePolicyForNavigation SPI
1972         https://bugs.webkit.org/show_bug.cgi?id=180897
1973         <rdar://problem/35535328>
1974
1975         Reviewed by Brent Fulgham.
1976
1977         Test two forms of storage to be sure we are using a different WebsiteDataStore: cookies and sessionStorage.
1978
1979         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1980         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1981         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:startURLSchemeTask:]):
1982         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1983         (websiteDataStoreTestWebView):
1984         (TEST):
1985
1986 == Rolled over to ChangeLog-2018-01-01 ==