Remove WebKitSystemInterface for iOS SDK < 9
[WebKit-https.git] / Tools / ChangeLog
1 2016-01-27  Daniel Bates  <dabates@apple.com>
2
3         Remove WebKitSystemInterface for iOS SDK < 9
4         https://bugs.webkit.org/show_bug.cgi?id=153570
5
6         Reviewed by Andy Estes.
7
8         * Scripts/copy-webkitlibraries-to-product-directory:
9
10 2016-01-27  Jason Marcell  <jmarcell@apple.com>
11
12         Fix bugs caused by incorrect usage of "branch" vs. "branchName".
13         https://bugs.webkit.org/show_bug.cgi?id=153330
14
15         Reviewed by Daniel Bates.
16
17         In an earlier patch we started using the name "branch" to indicate a branch object, whereas
18         "branchName" implies that the variable or property in question is simply a string. We fixed some
19         inconsistencies regarding this issue in 152982 but further bugs and inconsistencies were recently
20         spotted in BuildbotQueueView.js.
21
22         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
23         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Change branchName to branch in method signature.
24         Changed branchName to branch.name in call to commitsOnBranch.
25         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Change branch.name to branch in call to
26         _popoverLinesForCommitRange.
27         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Changed context.branchName to context.branch.name.
28         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Changed branch.name to branch.
29         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests to verify
30         fix.
31
32 2016-01-27  Ryosuke Niwa  <rniwa@webkit.org>
33
34         Add API to access closed shadowRoot in InjectedBundle
35         https://bugs.webkit.org/show_bug.cgi?id=153533
36
37         Reviewed by Antti Koivisto.
38
39         Added WebKit2 API test for WKBundleScriptWorldMakeAllShadowRootsOpen.
40
41         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
42         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp: Added.
43         (TestWebKitAPI::runJavaScriptAlert):
44         (TestWebKitAPI::TEST):
45         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakrAllShadowRootOpen_Bundle.cpp: Added.
46         (TestWebKitAPI::InjectedBundleMakrAllShadowRootOpenTest::InjectedBundleMakrAllShadowRootOpenTest):
47         (TestWebKitAPI::InjectedBundleMakrAllShadowRootOpenTest::initialize):
48
49 2016-01-27  Jason Marcell  <jmarcell@apple.com>
50
51         Refactor logic for parsing Trac revisions into its own function and add logic for parsing git hashes.
52         https://bugs.webkit.org/show_bug.cgi?id=153332
53
54         Reviewed by Alexey Proskuryakov.
55
56         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
57         (Trac.prototype._xmlTimelineURL): Uses new function.
58         (Trac.prototype._parseRevisionFromURL): Added. Pulled out logic for parsing revisions from a URL. Also added
59         logic for parsing git hashes.
60         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests for
61         Trac._parseRevisionFromURL.
62
63 2016-01-27  Alexey Proskuryakov  <ap@apple.com>
64
65         Remove Mavericks from the flakiness dashboard
66         https://bugs.webkit.org/show_bug.cgi?id=153521
67
68         Reviewed by Dan Bernstein.
69
70         * TestResultServer/static-dashboards/builders.jsonp:
71         * TestResultServer/static-dashboards/flakiness_dashboard.js:
72
73 2016-01-27  Alexey Proskuryakov  <ap@apple.com>
74
75         Remove ENABLE_CURRENTSRC
76         https://bugs.webkit.org/show_bug.cgi?id=153545
77
78         Reviewed by Simon Fraser.
79
80         * Scripts/webkitperl/FeatureList.pm:
81
82 2016-01-26  Jason Marcell  <jmarcell@apple.com>
83
84         Sort incoming commits via date instead of revision number.
85         https://bugs.webkit.org/show_bug.cgi?id=153467
86
87         Reviewed by Alexey Proskuryakov.
88
89         Future Trac instances may use Git or other revision control systems where we cannnot rely on the revision number
90         for sorting revisions. Instead we use the commit date to sort revisions chronologically.
91
92         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
93         (Trac.prototype._loaded): Sort via date instead of revision number.
94         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
95         (MockTrac): Fix up the mock data to look more like real-world data.
96         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-trac-rss.xml: Added.
97         Fake RSS feed that adds three more commits.
98         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit tests to test
99         Trac._loaded().
100
101 2016-01-26  I-Ting Liu  <iting_liu@apple.com>
102
103         Add a test for WebKit::stringMatchesWildcardString.
104         https://bugs.webkit.org/show_bug.cgi?id=153090
105
106         Reviewed by Darin Adler.
107
108         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
109         Add the file to the project.
110
111         * TestWebKitAPI/Tests/WebKit2/mac/StringUtilities.mm: Added.
112         (TestWebKitAPI::TEST):
113         Test that a string matches another string that may contain wildcard characters.
114
115 2016-01-26  Konstantin Tokarev  <annulen@yandex.ru>
116
117         [webkitdirs] Removed check for bison, gperf, and flex.
118         https://bugs.webkit.org/show_bug.cgi?id=153496
119
120         Reviewed by Alex Christensen.
121
122         This prerequisites are checked in WebKitCommon.cmake and don't
123         have to be in $PATH.
124
125         * Scripts/webkitdirs.pm:
126         (checkRequiredSystemConfig):
127
128 2016-01-26  Konstantin Tokarev  <annulen@yandex.ru>
129
130         [webkitdirs] isCMakeBuild should be true by default
131         https://bugs.webkit.org/show_bug.cgi?id=153497
132
133         Reviewed by Michael Catanzaro.
134
135         * Scripts/webkitdirs.pm:
136         (isCMakeBuild):
137
138 2016-01-26  Daniel Bates  <dabates@apple.com>
139
140         Add WebKitSystemInterface for iOS 9.2
141         https://bugs.webkit.org/show_bug.cgi?id=153355
142
143         Rubber-stamped by David Kilzer.
144
145         * Scripts/copy-webkitlibraries-to-product-directory:
146
147 2016-01-26  Daniel Bates  <dabates@apple.com>
148
149         WebKitTestRunner: Credential cache is not cleared between tests
150         https://bugs.webkit.org/show_bug.cgi?id=153407
151         <rdar://problem/24280834>
152
153         Reviewed by Alexey Proskuryakov.
154
155         * WebKitTestRunner/TestController.cpp:
156         (WTR::TestController::resetStateToConsistentValues): Call WKContextClearCachedCredentials()
157         to clear cached credentials.
158
159 2016-01-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
160
161         kill-old-processes: allow to specify on the environment of the bot a list of process that should be killed.
162         https://bugs.webkit.org/show_bug.cgi?id=153483
163
164         Reviewed by Csaba Osztrogonác.
165
166         * BuildSlaveSupport/kill-old-processes:
167         (main): Allow to specify extra tasks to kill via the environment variable WEBKITBOT_TASKSTOKILL
168
169 2016-01-25  Simon Fraser  <simon.fraser@apple.com>
170
171         Give the layout test results file a <title> showing the date and time the tests were run
172         https://bugs.webkit.org/show_bug.cgi?id=153187
173
174         Reviewed by Darin Adler.
175         
176         Include a 'date' property in the JSON with the date and time the tests completed.
177
178         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
179         (summarize_results):
180
181 2016-01-25  Commit Queue  <commit-queue@webkit.org>
182
183         Unreviewed, rolling out r195543.
184         https://bugs.webkit.org/show_bug.cgi?id=153451
185
186         regressed performance of test bots by ~6% (Requested by dydz
187         on #webkit).
188
189         Reverted changeset:
190
191         "WebKitTestRunner: Credential cache is not cleared between
192         tests"
193         https://bugs.webkit.org/show_bug.cgi?id=153407
194         http://trac.webkit.org/changeset/195543
195
196 2016-01-25  Aakash Jain  <aakash_jain@apple.com>
197
198         Failing to upload to flakiness dashboard should not be a hard error
199         https://bugs.webkit.org/show_bug.cgi?id=153444
200         <rdar://problem/22146294>
201
202         Reviewed by Alexey Proskuryakov.
203
204         * Scripts/webkitpy/layout_tests/controllers/manager.py:
205         (Manager._upload_json_files): If JSON file is not generated, do not try to upload it.
206
207 2016-01-25  Daniel Bates  <dabates@apple.com>
208
209         WebKitTestRunner: Credential cache is not cleared between tests
210         https://bugs.webkit.org/show_bug.cgi?id=153407
211         <rdar://problem/24280834>
212
213         Reviewed by Brady Eidson.
214
215         * WebKitTestRunner/TestController.cpp:
216         (WTR::TestController::resetStateToConsistentValues): Reset testing network session
217         to clear cached credentials.
218
219 2016-01-24  Dan Bernstein  <mitz@apple.com>
220
221         Added project.xcworkspace and xcuserdata to this project’s svn:ignore.
222
223         * LayoutTestRelay/LayoutTestRelay.xcodeproj: Added property svn:ignore.
224
225 2016-01-22  Enrica Casucci  <enrica@apple.com>
226
227         Unreviewed build fix after http://trac.webkit.org/changeset/195474.
228
229         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
230         (WTR::TestController::platformCreateWebView):
231
232 2016-01-22  Tim Horton  <timothy_horton@apple.com>
233
234         Add a test for iOS arrow-key repeat
235         https://bugs.webkit.org/show_bug.cgi?id=152857
236         <rdar://problem/24017380>
237
238         Reviewed by Darin Adler.
239
240         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
241         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
242         (WTR::UIScriptController::keyUpUsingHardwareKeyboard):
243         (WTR::UIScriptController::keyDownUsingHardwareKeyboard):
244         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
245         * WebKitTestRunner/ios/HIDEventGenerator.h:
246         * WebKitTestRunner/ios/HIDEventGenerator.mm:
247         (-[HIDEventGenerator keyPress:completionBlock:]):
248         (-[HIDEventGenerator keyDown:completionBlock:]):
249         (-[HIDEventGenerator keyUp:completionBlock:]):
250         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
251         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
252         (WTR::UIScriptController::keyDownUsingHardwareKeyboard):
253         (WTR::UIScriptController::keyUpUsingHardwareKeyboard):
254         Make it possible to independently send keyUp/keyDown, instead of just paired.
255
256 2016-01-22  Tim Horton  <timothy_horton@apple.com>
257
258         Reproducible "Unhanded web process message 'WebUserContentController:AddUserScripts'" and friends
259         https://bugs.webkit.org/show_bug.cgi?id=153193
260         <rdar://problem/24222034>
261
262         Reviewed by Darin Adler.
263
264         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
265         (webViewForScriptMessageHandlerMultipleHandlerRemovalTest):
266         (TEST):
267         Add a test that exhibits the problems we're fixing here.
268         Before, it would both log and assert in debug, and crash in release.
269         Now it runs happily to completion.
270
271 2016-01-22  Enrica Casucci  <enrica@apple.com>
272
273         Add support for testing data detection.
274         https://bugs.webkit.org/show_bug.cgi?id=153360
275
276         Reviewed by Tim Horton.
277
278         Adding a new testing option (useDataDetection) to turn on
279         data detection when running the a test.
280
281         * WebKitTestRunner/TestController.cpp:
282         (WTR::updateTestOptionsFromTestHeader):
283         * WebKitTestRunner/TestOptions.h:
284         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
285         (WTR::TestController::platformCreateWebView):
286
287 2016-01-21  Simon Fraser  <simon.fraser@apple.com>
288
289         Fix the lldb WebCoreLayoutUnitProvider to not dynamically look up the LayoutUnit denominator
290         https://bugs.webkit.org/show_bug.cgi?id=153334
291
292         Reviewed by Zalan Bujtas.
293         
294         Evaluating expressions in the LayoutUnit summary provider seems to cause
295         re-entrancy problems in lldb python bindings, so just hardcode the LayoutUnit
296         denominator to 64.
297
298         * lldb/lldb_webkit.py:
299         (WebCoreLayoutUnitProvider.to_string):
300
301 2016-01-21  Filip Pizlo  <fpizlo@apple.com>
302
303         display-profiler-output should be able to display code blocks sorted by machine counts
304         https://bugs.webkit.org/show_bug.cgi?id=153298
305
306         Reviewed by Oliver Hunt.
307
308         * Scripts/display-profiler-output:
309
310 2016-01-21  Julien Isorce  <j.isorce@samsung.com>
311
312         Ensure to use compatible liborc version with wanted gstreamer version
313         https://bugs.webkit.org/show_bug.cgi?id=153276
314
315         For example gst-plugins-base-1.4.4 fails to build with liborc-0.4.24.
316         The user may have a very recent liborc installed on his system.
317
318         Reviewed by Philippe Normand.
319
320         * efl/jhbuild.modules: add liborc-0.4.17 and make it a gst dependency.
321         * gtk/jhbuild.modules: add liborc-0.4.17 and make it a gst depencendy.
322
323 2016-01-21  Nan Wang  <n_wang@apple.com>
324
325         AX: [IOS] Implement next/previous text marker functions using TextIterator
326         https://bugs.webkit.org/show_bug.cgi?id=153292
327         <rdar://problem/24268243>
328
329         Reviewed by Chris Fleizach.
330
331         Made text marker tests available on iOS.
332
333         * DumpRenderTree/AccessibilityTextMarker.h:
334         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
335         * DumpRenderTree/ios/AccessibilityTextMarkerIOS.mm: Added.
336         (AccessibilityTextMarker::AccessibilityTextMarker):
337         (AccessibilityTextMarker::~AccessibilityTextMarker):
338         (AccessibilityTextMarker::isEqual):
339         (AccessibilityTextMarker::platformTextMarker):
340         (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
341         (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
342         (AccessibilityTextMarkerRange::isEqual):
343         (AccessibilityTextMarkerRange::platformTextMarkerRange):
344         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
345         (AccessibilityUIElement::pathDescription):
346         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
347         (AccessibilityUIElement::textMarkerRangeForElement):
348         (AccessibilityUIElement::selectedTextMarkerRange):
349         (AccessibilityUIElement::resetSelectedTextMarkerRange):
350         (AccessibilityUIElement::textMarkerRangeLength):
351         (AccessibilityUIElement::textMarkerRangeForMarkers):
352         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
353         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
354         (AccessibilityUIElement::accessibilityElementForTextMarker):
355         (AccessibilityUIElement::endTextMarkerForBounds):
356         (AccessibilityUIElement::startTextMarkerForBounds):
357         (AccessibilityUIElement::textMarkerForPoint):
358         (AccessibilityUIElement::previousTextMarker):
359         (AccessibilityUIElement::nextTextMarker):
360         (AccessibilityUIElement::stringForTextMarkerRange):
361         (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
362         (AccessibilityUIElement::indexForTextMarker):
363         (AccessibilityUIElement::isTextMarkerValid):
364         (AccessibilityUIElement::textMarkerForIndex):
365         (AccessibilityUIElement::startTextMarker):
366         (AccessibilityUIElement::endTextMarker):
367         (AccessibilityUIElement::setSelectedVisibleTextRange):
368         (AccessibilityUIElement::getLinkedUIElements):
369         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
370         (AccessibilityTextMarkerRange::platformTextMarkerRange):
371         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
372         (AccessibilityUIElement::removeSelection):
373         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
374         (AccessibilityUIElement::setSelectedVisibleTextRange):
375         (AccessibilityUIElement::supportedActions):
376         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
377         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
378         (WTR::AccessibilityUIElement::textMarkerRangeLength):
379         (WTR::AccessibilityUIElement::previousTextMarker):
380         (WTR::AccessibilityUIElement::nextTextMarker):
381         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
382         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
383         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
384         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
385         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
386         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
387         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
388
389 2016-01-20  Filip Pizlo  <fpizlo@apple.com>
390
391         Unreviewed, revert accidental unreviewed commit.
392
393         * Scripts/display-profiler-output:
394
395 2016-01-20  Jason Marcell  <jmarcell@apple.com>
396
397         Refactor compareIterations to remove duplicate code.
398         https://bugs.webkit.org/show_bug.cgi?id=152913
399
400         Reviewed by Daniel Bates.
401
402         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
403         (BuildbotQueue.prototype.compareIterations): Refactored to remove duplicate code.
404         (BuildbotQueue.prototype.sortIterations): Add binding to call to compareIterations.
405         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests in order to ensure
406         the same behavior before and after refactor.
407
408 2016-01-20  Dana Burkart  <dburkart@apple.com>
409
410         Botwatcher's dashboard should show an 'X' when the build is broken
411         https://bugs.webkit.org/show_bug.cgi?id=152507
412
413         Reviewed by David Kilzer.
414
415         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
416         (BuildbotStaticAnalyzerQueueView.prototype.appendStaticAnalyzerQueueStatus):
417         (BuildbotStaticAnalyzerQueueView.prototype.update):
418
419 2016-01-19  Jason Marcell  <jmarcell@apple.com>
420
421         Remove assertion from revisionContentForIteration that is causing errors on the dashboard.
422         https://bugs.webkit.org/show_bug.cgi?id=153262
423
424         Reviewed by Alexey Proskuryakov.
425
426         Occasionaly some buildbot iterations will not have their "got_revisions" property populated. In
427         such cases this revisionContentForIteration method does not have any content to return, thus the
428         assertion fails.
429
430         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
431         (BuildbotQueueView.prototype.revisionContentForIteration): Removed assertion that was causing errors.
432
433 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
434
435         [GTK] Runtime critical warnings when loading a URL after a session restore
436         https://bugs.webkit.org/show_bug.cgi?id=153233
437
438         Reviewed by Michael Catanzaro.
439
440         Add new test case.
441
442         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
443         (viewLoadChanged):
444         (testWebKitWebViewNavigationAfterSessionRestore):
445         (beforeAll):
446
447 2016-01-19  Michael Catanzaro  <mcatanzaro@igalia.com>
448
449         [GTK] Remove jhbuild-optional.modules
450         https://bugs.webkit.org/show_bug.cgi?id=152964
451
452         Reviewed by Alex Christensen.
453
454         * gtk/jhbuild-optional.modules: Removed.
455         * gtk/jhbuild.modules:
456
457 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
458
459         [GTK] Add support to load/save session in MiniBrowser
460         https://bugs.webkit.org/show_bug.cgi?id=153201
461
462         Reviewed by Michael Catanzaro.
463
464         It makes it easier to test the new WebView session API.
465
466         * MiniBrowser/gtk/BrowserWindow.c:
467         (browserWindowFinalize): Free the session file path.
468         (browserWindowSaveSession): Save the current WebView session if
469         there's a session file path.
470         (browserWindowDeleteEvent): Call browserWindowSaveSession().
471         (browser_window_load_session): Try to load the session from the
472         given file path, otherwise fall back to homepage and keep the
473         session file to save the session on window close.
474         * MiniBrowser/gtk/BrowserWindow.h:
475         * MiniBrowser/gtk/main.c:
476         (createBrowserWindow): Pass the given session file path when
477         shouldLoadSession is TRUE.
478         (main): Only allow to restore/save session when MiniBrowser is
479         launched without URL arguments.
480
481 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
482
483         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/geolocation-permission-requests after r195075.
484
485         Geolocation is no longer allowed for unique origins after r195075.
486
487         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
488         (testWebViewGeolocationPermissionRequests):
489
490 2016-01-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>
491
492         [GTK][EFL] Layout tests abort with PulseAudioSanitizer instance has no attribute '_pa_module_index' when the build is not ready.
493         https://bugs.webkit.org/show_bug.cgi?id=153216
494
495         Reviewed by Michael Catanzaro.
496
497         * Scripts/webkitpy/port/pulseaudio_sanitizer.py:
498         (PulseAudioSanitizer.__init__): initialize _pa_module_index in the constructor.
499
500 2016-01-18  Nan Wang  <n_wang@apple.com>
501
502         AX: [Mac] Implement next/previous text marker functions using TextIterator
503         https://bugs.webkit.org/show_bug.cgi?id=152728
504
505         Reviewed by Chris Fleizach.
506
507         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
508         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
509
510 2016-01-18  Csaba Osztrogonác  <ossy@webkit.org>
511
512         [cmake] Add testair to the build system
513         https://bugs.webkit.org/show_bug.cgi?id=153126
514
515         Reviewed by Michael Catanzaro.
516
517         * Scripts/build-jsc:
518
519 2016-01-16  Myles C. Maxfield  <mmaxfield@apple.com>
520
521         Remove TextRun::allowsRoundingHacks()
522         https://bugs.webkit.org/show_bug.cgi?id=153185
523
524         Reviewed by Simon Fraser.
525
526         * DumpRenderTree/mac/DumpRenderTree.mm:
527         (resetWebViewToConsistentStateBeforeTesting): Deleted.
528
529 2016-01-15  Konstantin Tokarev  <annulen@yandex.ru>
530
531         [webkitdirs] Avoid list form of open because it broke WinCairo
532         https://bugs.webkit.org/show_bug.cgi?id=153106
533
534         Reviewed by Alex Christensen.
535
536         * Scripts/webkitdirs.pm:
537         (determineArchitecture):
538
539 2016-01-15  Simon Fraser  <simon.fraser@apple.com>
540
541         Add kdebug_trace signposts for a few WebCore operations
542         https://bugs.webkit.org/show_bug.cgi?id=153136
543         rdar://problem/24208487
544
545         Reviewed by Sam Weinig.
546         
547         Plist used by kdebug_trace() viewing tools.
548
549         * Tracing/SystemTracePoints.plist: Added.
550
551 2016-01-14  Konstantin Tokarev  <annulen@yandex.ru>
552
553         [webkitdirs] Replaced grep invocation with perl code
554         https://bugs.webkit.org/show_bug.cgi?id=153106
555
556         Reviewed by Alex Christensen.
557
558         * Scripts/webkitdirs.pm:
559         (determineArchitecture):
560
561 2016-01-14  Brian Burg  <bburg@apple.com>
562
563         prepare-changelog does not read paths containing spaces properly
564         https://bugs.webkit.org/show_bug.cgi?id=137982
565
566         Reviewed by Joseph Pecoraro.
567
568         Escape whitespace in filenames before passing the file path to other functions.
569
570         * Scripts/prepare-ChangeLog:
571         (generateFunctionLists): Use the more explicit 3-argument form of 'open'.
572
573 2016-01-14  Jason Marcell  <jmarcell@apple.com>
574
575         Standardize the usage of "branch" vs. "branchName".
576         https://bugs.webkit.org/show_bug.cgi?id=152982
577
578         Reviewed by Daniel Bates.
579
580         In an earlier patch we started using the name "branch" to indicate a branch object, whereas
581         "branchName" implies that the variable or property in question is simply a string.
582
583         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
584         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Change branch to branchName.
585         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Change branch to branch.name.
586         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Change branch to branchName.
587         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
588         (Trac.prototype.commitsOnBranch): Change branch to branchName.
589         (Trac.prototype._convertCommitInfoElementToObject): Ditto.
590         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
591         (MockTrac): Ditto.
592
593 2016-01-14  Jason Marcell  <jmarcell@apple.com>
594
595         Add a unit test to test BuildbotQueueView._appendPendingRevisionCount.
596         https://bugs.webkit.org/show_bug.cgi?id=152910
597
598         Reviewed by Daniel Bates.
599
600         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueue.js: Added.
601         (MockBuildbotQueue): Added. Mock BuildbotQueue object that doesn't need to talk to an actual Buildbot server.
602         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js: Added.
603         (MockBuildbotQueueView): Added. Mock BuildbotQueueView object that returns a pre-specified _latestProductiveIteration without
604         the need to talk to a real Buildbot server.
605         (MockBuildbotQueueView.prototype._latestProductiveIteration): Added. Returns a pre-specified _latestProductiveIteration
606         without the need to talk to a real Buildbot server.
607         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js: Added.
608         (MockTrac): Added. Mock Trac constructor that has pre-populated "recordedCommits" and does not need to talk to a real Trac
609         server.
610         (MockTrac.prototype.get oldestRecordedRevisionNumber): Added. Returns a pre-specified revision.
611         (MockTrac.prototype.get latestRecordedRevisionNumber): Ditto.
612         (MockTrac.prototype.loadMoreHistoricalData): Added. Overrides the real loadMoreHistoricalData so that we don't waste time
613         trying to talk to Trac.
614         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Added. Web page container for
615         QUnit unit tests.
616         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added. QUnit unit tests.
617
618 2016-01-14  Nikos Andronikos  <nikos.andronikos-webkit@cisra.canon.com.au>
619
620         [CMake][GTK] CMake Error: Could not create named generator Eclipse CDT4 - Ninja
621         https://bugs.webkit.org/show_bug.cgi?id=132599
622
623         Reviewed by Michael Catanzaro.
624
625         Check if cmake Ninja generators are installed.
626
627         * Scripts/webkitdirs.pm:
628         (canUseNinjaGenerator):
629         (canUseEclipseNinjaGenerator):
630         (generateBuildSystemFromCMakeProject):
631         (canUseEclipse): Deleted.
632
633 2016-01-13  Myles C. Maxfield  <mmaxfield@apple.com>
634
635         [Cocoa] Testing with font family name "System Font" is unused
636         https://bugs.webkit.org/show_bug.cgi?id=153073
637         <rdar://problem/24091683>
638
639         Reviewed by Brent Fulgham.
640
641         * DumpRenderTree/mac/DumpRenderTree.mm:
642         (allowedFontFamilySet): Deleted.
643         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
644         (WTR::allowedFontFamilySet): Deleted.
645         * WebKitTestRunner/mac/TestControllerMac.mm:
646         (WTR::allowedFontFamilySet): Deleted.
647
648 2016-01-13  Daniel Bates  <dabates@apple.com>
649
650         [XSS Auditor] Add test when XSS payload is in the path portion of the URL
651         https://bugs.webkit.org/show_bug.cgi?id=152871
652
653         Reviewed by Brent Fulgham.
654
655         Merged from Blink (patch by Tom Sepez <tsepez@chromium.org>):
656         <https://src.chromium.org/viewvc/blink?revision=164746&view=revision>
657
658         * Scripts/webkitpy/layout_tests/servers/lighttpd.conf:
659
660 2016-01-08  Andy Estes  <aestes@apple.com>
661
662         [Content Filtering] Lazily load platform frameworks
663         https://bugs.webkit.org/show_bug.cgi?id=152881
664         rdar://problem/23270886
665
666         Reviewed by Brady Eidson.
667
668         Added an API test that verifies that the Parental Controls and Network Extension frameworks are loaded at the
669         expected times. The test verifies that they are not loaded after creating a WKWebView, loading an HTML string,
670         loading NSData, loading a file, or loading from a custom protocol. It verifies that Network Extension on Mac/iOS
671         and Parental Controls on iOS are loaded after an HTTP request. It finally verifies that Parental Controls on Mac
672         is loaded after an HTTPS request.
673
674         To accomplish this, TestProtocol was generalized to allow tests to specify the scheme they wish to use.
675         Other tests that used TestProtocol were updated to account for this change. TestProtocol was removed from
676         WebKit2.PreventImageLoadWithAutoResizingTest, which didn't actually need to use it. ContentFiltering tests were
677         also re-enabled on iOS after mistakenly being disabled by r188892.
678
679         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
680         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
681         (TestWebKitAPI::TEST):
682         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.h: Added.
683         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.html: Added.
684         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
685         (TEST):
686         (downloadTest):
687         (-[LazilyLoadPlatformFrameworksController init]):
688         (-[LazilyLoadPlatformFrameworksController webView]):
689         (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
690         (-[LazilyLoadPlatformFrameworksController webView:didFinishNavigation:]):
691         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
692         (-[ContentFilteringPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
693         (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]):
694         (-[ContentFilteringPlugIn checkIfPlatformFrameworksAreLoaded:]):
695         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
696         (TestWebKitAPI::TEST):
697         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
698         (TestWebKitAPI::TEST): Deleted.
699         * TestWebKitAPI/cocoa/TestProtocol.h:
700         * TestWebKitAPI/cocoa/TestProtocol.mm:
701         (+[TestProtocol registerWithScheme:]):
702         (+[TestProtocol unregister]):
703
704 2016-01-12  Dewei Zhu  <dewei_zhu@apple.com>
705
706         Fix the Sunpider converage in slow device.
707         https://bugs.webkit.org/show_bug.cgi?id=152938
708         <rdar://problem/22511411>
709
710         Reviewed by Ryosuke Niwa.
711
712         Updated the patch for RunBenchmark to resume sunspider coverage by removing unused subresources in sub-tests.
713
714         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch:
715
716 2016-01-12  Ryosuke Niwa  <rniwa@webkit.org>
717
718         Add a build flag for custom element
719         https://bugs.webkit.org/show_bug.cgi?id=153005
720
721         Reviewed by Alex Christensen.
722
723         Added --custom-elements option to enable custom elements support.
724
725         * Scripts/webkitperl/FeatureList.pm:
726
727 2016-01-12  Benjamin Poulain  <bpoulain@apple.com>
728
729         [JSC] Add a help message when run-jsc-stress-tests fails
730         https://bugs.webkit.org/show_bug.cgi?id=153014
731
732         Reviewed by Csaba Osztrogonác.
733
734         * Scripts/run-jsc-stress-tests:
735
736 2016-01-11  Saam barati  <sbarati@apple.com>
737
738         run-jsc-stress-tests should try to figure out a JSC path
739         https://bugs.webkit.org/show_bug.cgi?id=152971
740
741         Reviewed by Yusuke Suzuki.
742
743         This patch now allows run-jsc-stress-tests to be run
744         without a "--jsc <jsc-path>" argument. It tries
745         to take its best guess at a <jsc-path> automagically.
746         
747         This makes it much easier to just run run-jsc-stress-tests
748         with a directory or a yaml file as an argument.
749         You now just do this:
750         `run-jsc-stress-tests <path-to-yaml>`
751         or
752         `run-jsc-stress-tests <path-to-directory-of-js-files>`
753         
754         I wrote this patch because I'd often find myself hacking the 
755         run-javascriptcore-tests file just to run a particular subset of tests.
756         Because I always forget the arguments to run-jsc-stress-tests (which means
757         I always forgot to provide a --jsc argument), I always found it easier to 
758         just hack on that file instead of calling run-jsc-stress-tests directly.
759         No longer is this true!
760
761         * Scripts/run-jsc-stress-tests:
762
763 2016-01-09  Andy Estes  <aestes@apple.com>
764
765         [Cocoa] Add SPI to opt out a URL scheme from the memory cache
766         https://bugs.webkit.org/show_bug.cgi?id=152950
767         rdar://problem/24066652
768
769         Reviewed by Tim Horton.
770
771         Added an API test.
772
773         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
774         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
775         (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
776         (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
777         (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
778         (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
779         (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
780         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
781         (TEST):
782
783 2016-01-11  Commit Queue  <commit-queue@webkit.org>
784
785         Unreviewed, rolling out r194866.
786         https://bugs.webkit.org/show_bug.cgi?id=152986
787
788         This change broke the mac build (Requested by ryanhaddad on
789         #webkit).
790
791         Reverted changeset:
792
793         "[Cocoa] Add SPI to opt out a URL scheme from the memory
794         cache"
795         https://bugs.webkit.org/show_bug.cgi?id=152950
796         http://trac.webkit.org/changeset/194866
797
798 2016-01-11  Andy Estes  <aestes@apple.com>
799
800         [Cocoa] Add SPI to opt out a URL scheme from the memory cache
801         https://bugs.webkit.org/show_bug.cgi?id=152950
802         rdar://problem/24066652
803
804         Reviewed by Tim Horton.
805
806         Added an API test.
807
808         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
809         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
810         (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
811         (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
812         (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
813         (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
814         (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
815         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
816         (TEST):
817
818 2016-01-11  Konstantin Tokarev  <annulen@yandex.ru>
819
820         [webkitdirs] Use CMake to determine architecture on isCMakeBuild()
821         https://bugs.webkit.org/show_bug.cgi?id=152959
822
823         Reviewed by Brent Fulgham.
824
825         * Scripts/webkitdirs.pm:
826         (determineArchitecture):
827
828 2016-01-11  Michael Catanzaro  <mcatanzaro@igalia.com>
829
830         [GTK] W3C CSS2.1 anonymous table tests are failing
831         https://bugs.webkit.org/show_bug.cgi?id=152455
832
833         Reviewed by Mario Sanchez Prada.
834
835         Add shared-mime-info to the jhbuild environment, since it affects the results of layout
836         tests. Add upstream patches to fix detection of XHTML files.
837
838         * gtk/jhbuild.modules:
839         * gtk/patches/shared-mime-info-xht-glob.patch: Added.
840         * gtk/patches/shared-mime-info-xhtml-magic.patch: Added.
841
842 2016-01-10  Saam barati  <sbarati@apple.com>
843
844         Implement a sampling profiler
845         https://bugs.webkit.org/show_bug.cgi?id=151713
846
847         Reviewed by Filip Pizlo.
848
849         * Scripts/run-jsc-stress-tests:
850
851 2016-01-10  Konstantin Tokarev  <annulen@yandex.ru>
852
853         [webkitdirs] Try arch and uname commands on non-windows OS
854         https://bugs.webkit.org/show_bug.cgi?id=152958
855
856         Reviewed by Michael Catanzaro.
857
858         Right now, determineArchitecture()  uses `arch` and `uname -m`
859         commands to determine architecture in case of condition (isGtk() ||
860         isAppleMacWebKit() || isEfl()) is true. This should be !anyWindows()
861         instead, because this code is applicable to any non-windows OS WebKit
862         supports (even Haiku which once was supported is moderately
863         POSIX-compliant and has uname command).
864
865         * Scripts/webkitdirs.pm:
866         (determineArchitecture):
867
868 2016-01-08  Aakash Jain  <aakash_jain@apple.com>
869
870         run-webkit-tests mis-counts totals when there are other crashes
871         https://bugs.webkit.org/show_bug.cgi?id=152894
872         <rdar://problem/24098697>
873
874         Reviewed by Alexey Proskuryakov.
875
876         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
877         (TestRunResults.add): Do not update result counters for other crashes.
878
879 2016-01-08  Youenn Fablet  <youenn.fablet@crf.canon.fr>
880
881         webkit-patch build-and-test should have an option to iterate over new tests
882         https://bugs.webkit.org/show_bug.cgi?id=143093
883
884         Reviewed by Michael Catanzaro.
885
886         This patch introduces the --iterate-on-new-tests option to webkit-patch build-and-test.
887         It allows running run-webkit-tests on modified or new paths in LayoutTests.
888         Computation of new or modified tests is done by LayoutTestFinder.find_touched_tests
889         It implements the translation of -expected.* paths to their related tests.
890         It also implements the removal of skipped tests.
891
892         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
893         (LayoutTestFinder.find_touched_tests):
894         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py: Added.
895         (MockPort):
896         (MockPort.__init__):
897         (MockPort.tests):
898         (LayoutTestFinderTests):
899         (LayoutTestFinderTests.touched_files):
900         (LayoutTestFinderTests.test_touched_test):
901         (LayoutTestFinderTests.test_expected_touched_test):
902         (LayoutTestFinderTests.test_platform_expected_touched_test):
903         (LayoutTestFinderTests.test_platform_duplicate_touched_test):
904         (LayoutTestFinderTests.test_touched_but_skipped_test):
905         * Scripts/webkitpy/port/base.py:
906         (Port.potential_test_names_from_expected_file):
907         * Scripts/webkitpy/tool/commands/download_unittest.py:
908         (DownloadCommandsTest._default_options):
909         * Scripts/webkitpy/tool/steps/options.py:
910         (Options):
911         * Scripts/webkitpy/tool/steps/runtests.py:
912         (RunTests.options):
913         (RunTests.run):
914         (RunTests):
915         (RunTests._new_or_modified_tests):
916         (RunTests._run_webkit_tests):
917         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
918         (RunTestsTest.test_webkit_run_unit_tests):
919         * Scripts/webkitpy/tool/steps/steps_unittest.py:
920         (StepsTest._step_options):
921
922 2016-01-07  Joseph Pecoraro  <pecoraro@apple.com>
923
924         prepare-ChangeLog should include radar number
925         https://bugs.webkit.org/show_bug.cgi?id=152839
926         <rdar://problem/24093563>
927
928         Reviewed by Daniel Bates.
929
930         When running `prepare-ChangeLog -b ###`, check for a bugzilla comment that
931         starts with a "<rdar://problem/####>" URL. If found, include that radar URL
932         in the ChangeLog description after the bug URL.
933
934         * Scripts/prepare-ChangeLog:
935         (main): Update signatures.
936         (fetchBugXMLData): XML Data is now used for multiple reasons. Extract this to just get the data.
937         (fetchBugDescriptionFromBugXMLData): Search data for <short_desc>.
938         (fetchRadarURLFromBugXMLData): Search comment text for radar URL.
939         (generateNewChangeLogs): Include radar URL if we found one.
940
941         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl: Added.
942         Tests for the radar URL extraction.
943
944 2016-01-07  Alexey Proskuryakov  <ap@apple.com>
945
946         testRunner.runUIScript crashes while running multiple tests in a row that invokes the same UIScript
947         https://bugs.webkit.org/show_bug.cgi?id=152390
948         <rdar://problem/23948321>
949
950         Reviewed by Simon Fraser.
951
952         Fix two use-after-frees.
953
954         1. WKPageCallAfterNextPresentationUpdate's callback has a pointer to TestInvocation,
955         but we may have already progressed to another test by the time the callback fires,
956         having destroyed the TestInvocation.
957         2. UIScriptController is a RefCounted object, but it has a raw pointer to
958         UIScriptContext which has the same lifetime as a TestInvocation.
959         As a result, completion blocks of UIScriptController actions would use a destroyed
960         TestInvocation.
961
962         * WebKitTestRunner/TestInvocation.cpp:
963         (WTR::TestInvocation::~TestInvocation):
964         (WTR::TestInvocation::url):
965         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
966         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
967         (WTR::TestInvocation::runUISideScript):
968         * WebKitTestRunner/TestInvocation.h:
969         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
970         (UIScriptContext::UIScriptContext):
971         (UIScriptContext::~UIScriptContext):
972         (UIScriptContext::runUIScript):
973         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
974         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
975         (WTR::UIScriptController::UIScriptController):
976         (WTR::UIScriptController::contextDestroyed):
977         (WTR::UIScriptController::makeWindowObject):
978         (WTR::UIScriptController::setWillBeginZoomingCallback):
979         (WTR::UIScriptController::willBeginZoomingCallback):
980         (WTR::UIScriptController::setDidEndZoomingCallback):
981         (WTR::UIScriptController::didEndZoomingCallback):
982         (WTR::UIScriptController::setDidEndScrollingCallback):
983         (WTR::UIScriptController::didEndScrollingCallback):
984         (WTR::UIScriptController::setDidShowKeyboardCallback):
985         (WTR::UIScriptController::didShowKeyboardCallback):
986         (WTR::UIScriptController::setDidHideKeyboardCallback):
987         (WTR::UIScriptController::didHideKeyboardCallback):
988         (WTR::UIScriptController::uiScriptComplete):
989         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
990         (WTR::UIScriptController::create):
991         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
992         (WTR::UIScriptController::doAsyncTask):
993         (WTR::UIScriptController::zoomToScale):
994         (WTR::UIScriptController::singleTapAtPoint):
995         (WTR::UIScriptController::doubleTapAtPoint):
996         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
997         (WTR::UIScriptController::contentVisibleRect):
998         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
999         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
1000         (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
1001         (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
1002         (WTR::UIScriptController::platformSetDidEndScrollingCallback):
1003         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1004         (WTR::UIScriptController::doAsyncTask):
1005
1006 2016-01-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1007
1008         [buildbot] clean-build script should remove untracked files and revert local changes too
1009         https://bugs.webkit.org/show_bug.cgi?id=142400
1010
1011         Reviewed by Ryosuke Niwa.
1012
1013         This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
1014         A helper routine SCM.discard_untracked_files is added for that purpose.
1015
1016         * BuildSlaveSupport/clean-build:
1017         (main): Making call to Scripts/clean-webkit
1018         * Scripts/clean-webkit: Added.
1019         (main): Revert changes and delete untracked files.
1020         * Scripts/webkitpy/common/checkout/scm/scm.py:
1021         (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
1022         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1023         (SCMTest._shared_test_discard_untracked_files):
1024         (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
1025
1026 2016-01-06  Simon Fraser  <simon.fraser@apple.com>
1027
1028         Add a setting and preferences to enable display-list drawing. Does nothing yet.
1029         https://bugs.webkit.org/show_bug.cgi?id=152807
1030
1031         Reviewed by Zalan Bujtas.
1032         
1033         Add an item to the Settings menu to toggle display-list drawing.
1034
1035         * MiniBrowser/mac/SettingsController.h:
1036         * MiniBrowser/mac/SettingsController.m:
1037         (-[SettingsController _populateMenu]):
1038         (-[SettingsController validateMenuItem:]):
1039         (-[SettingsController toggleDisplayListDrawingEnabled:]):
1040         (-[SettingsController displayListDrawingEnabled]):
1041         * MiniBrowser/mac/WK2BrowserWindowController.m:
1042         (-[WK2BrowserWindowController didChangeSettings]):
1043
1044 2016-01-06  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1045
1046         Python SCM should be able to retrieve untracked files - Add GIT support
1047         https://bugs.webkit.org/show_bug.cgi?id=143135
1048
1049         Reviewed by Michael Catanzaro.
1050
1051         * Scripts/webkitpy/common/checkout/scm/git.py:
1052         (Git.untracked_files): Adding support for git.
1053         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1054         (GitTest.setUp):
1055         (GitTest.test_untracked_files): Adding test.
1056
1057 2016-01-05  Mark Lam  <mark.lam@apple.com>
1058
1059         Rename badly named JSC_timeout env var to JSCTEST_timeout.
1060         https://bugs.webkit.org/show_bug.cgi?id=152748
1061
1062         Reviewed by Geoffrey Garen.
1063
1064         Now that we validate JSC options, the badly named JSC_timeout env var causes the
1065         bots to have a bad time.
1066
1067         * Scripts/run-javascriptcore-tests:
1068         * Scripts/run-jsc-stress-tests:
1069
1070 2016-01-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1071
1072         [GTK] Allow to save and restore session
1073         https://bugs.webkit.org/show_bug.cgi?id=115600
1074
1075         Reviewed by Michael Catanzaro.
1076
1077         Add test case to check the new session API.
1078
1079         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
1080         (testWebKitWebViewSessionState):
1081         (testWebKitWebViewSessionStateWithFormData):
1082         (beforeAll):
1083
1084 2016-01-04  Csaba Osztrogonác  <ossy@webkit.org>
1085
1086         [EFL] Bump EFL version to 1.16.1
1087         https://bugs.webkit.org/show_bug.cgi?id=152688
1088
1089         Reviewed by Gyuyoung Kim.
1090
1091         * efl/jhbuild.modules:
1092
1093 2016-01-04  Aakash Jain  <aakash_jain@apple.com>
1094
1095         error running layout tests on iOS simulator on latest build
1096         https://bugs.webkit.org/show_bug.cgi?id=152719
1097         <rdar://problem/24009549>
1098
1099         Reviewed by Alexey Proskuryakov.
1100
1101         * Scripts/webkitpy/xcode/simulator.py:
1102         (Simulator.wait_until_device_is_booted): Ensure that simulator device is in booted state
1103           before running simctl spawn command.
1104
1105 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1106
1107         Unreviewed, move Frédéric Wang to committers list
1108
1109         He seems to be on the contributors list by accident. He has been landing his own commits for
1110         about two years now.
1111
1112         * Scripts/webkitpy/common/config/contributors.json:
1113
1114 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1115
1116         Unreviewed, move Sebastian Dröge to committers list harder
1117
1118         He accidentally added himself to the reviewers list because the file is confusing. Then I
1119         accidentially moved him to the contributors list because the file is confusing, even though
1120         I knew the contributors list existed in this file and was attempting to add him to the
1121         committers list. Really move him to the committers list now.
1122
1123         * Scripts/webkitpy/common/config/contributors.json:
1124
1125 2016-01-02  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1126
1127         Python SCM should be able to retrieve untracked files - Add SVN support
1128         https://bugs.webkit.org/show_bug.cgi?id=152546
1129
1130         Reviewed by Michael Catanzaro.
1131
1132         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1133         (test_untracked_files): Activating test for SVN.
1134         * Scripts/webkitpy/common/checkout/scm/svn.py:
1135         (SVN.untracked_files): Implementing untracked files retrieval for SVN.
1136
1137 2015-12-31  Andy Estes  <aestes@apple.com>
1138
1139         Replace WTF::move with WTFMove
1140         https://bugs.webkit.org/show_bug.cgi?id=152601
1141
1142         Reviewed by Brady Eidson.
1143
1144         * DumpRenderTree/TestRunner.h:
1145         (TestRunner::setAllowedHosts):
1146         * DumpRenderTree/win/DRTDataObject.cpp:
1147         (DRTDataObject::SetData):
1148         * TestWebKitAPI/Tests/WTF/Deque.cpp:
1149         (TestWebKitAPI::TEST):
1150         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1151         (TestWebKitAPI::TEST):
1152         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1153         (TestWebKitAPI::TEST):
1154         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
1155         (TestWebKitAPI::TEST):
1156         * TestWebKitAPI/Tests/WTF/Ref.cpp:
1157         (TestWebKitAPI::passWithRef):
1158         (TestWebKitAPI::TEST):
1159         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
1160         (TestWebKitAPI::TEST):
1161         * TestWebKitAPI/Tests/WTF/Vector.cpp:
1162         (TestWebKitAPI::TEST):
1163         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1164         (TestWebKitAPI::TEST):
1165         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
1166         (TestWebKitAPI::TEST):
1167         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
1168         (TestWebKitAPI::createTestValue):
1169         (TestWebKitAPI::TEST):
1170         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1171         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
1172         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
1173         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
1174         (TestWebKitAPI::createNFAs):
1175         (TestWebKitAPI::TEST_F):
1176         * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp:
1177         (TestWebKitAPI::combine):
1178         * TestWebKitAPI/Tests/WebCore/DFAHelpers.h:
1179         (TestWebKitAPI::createNFAs):
1180         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm:
1181         (TEST):
1182         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
1183         (WebProcessTest::add):
1184
1185 2016-01-01  Michael Catanzaro  <mcatanzaro@igalia.com>
1186
1187         [SOUP] REGRESSION(r192761): Broke resource URIs for applications that use g_resource_load in a web extension
1188         https://bugs.webkit.org/show_bug.cgi?id=152634
1189
1190         Reviewed by Carlos Garcia Campos.
1191
1192         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
1193         (testLoadFromGResource): Added test.
1194         (beforeAll):
1195         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1196         (registerGResource): Added.
1197         (webkit_web_extension_initialize_with_user_data): Load the test gresource.
1198         * TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html: Added.
1199         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Add an HTML file.
1200
1201 2015-12-31  David Kilzer  <ddkilzer@apple.com>
1202
1203         REGRESSION (r194470): Fix warnings uncovered by migrating to WTF_MOVE
1204         <https://bugs.webkit.org/show_bug.cgi?id=152601>
1205
1206         Ignore unknown pragmas on older clangs.  Fixes the following
1207         build failure:
1208
1209             Tools/TestWebKitAPI/Tests/WTF/NakedPtr.cpp:184:34: error: unknown warning group '-Wself-move', ignored [-Werror,-Wunknown-pragmas]
1210             #pragma clang diagnostic ignored "-Wself-move"
1211                                              ^
1212             1 error generated.
1213
1214         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
1215         (TestWebKitAPI::TEST):
1216         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
1217         (TestWebKitAPI::TEST):
1218
1219 2015-12-31  Andy Estes  <aestes@apple.com>
1220
1221         Update the style checker to advise using WTFMove() instead of WTF::move()
1222         https://bugs.webkit.org/show_bug.cgi?id=152601
1223
1224         Reviewed by Daniel Bates.
1225
1226         * Scripts/webkitpy/style/checkers/cpp.py:
1227         (check_wtf_move):
1228         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1229         (WebKitStyleTest.test_wtf_move):
1230
1231 2015-12-31  Andy Estes  <aestes@apple.com>
1232
1233         Fix warnings uncovered by migrating to WTF_MOVE
1234         https://bugs.webkit.org/show_bug.cgi?id=152601
1235
1236         Reviewed by Daniel Bates.
1237
1238         Ignored -Wself-move warnings in these two API tests. It's useful to test that these classes properly handle
1239         self-move, even if doing so would trigger a warning.
1240
1241         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
1242         (TestWebKitAPI::TEST):
1243         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
1244         (TestWebKitAPI::TEST):
1245
1246 2015-12-31  Martin Robinson  <mrobinson@igalia.com>
1247
1248         [GTK] The install-dependencies script has a syntax error
1249         https://bugs.webkit.org/show_bug.cgi?id=152613
1250
1251         Reviewed by Michael Catanzaro.
1252
1253         * gtk/install-dependencies: Add the missing 'then.'
1254
1255 2015-12-30  Philippe Normand  <pnormand@igalia.com>
1256
1257         [Mac][GTK] Jhbuild support for OSX
1258         https://bugs.webkit.org/show_bug.cgi?id=150799
1259
1260         Reviewed by Michael Catanzaro.
1261
1262         * gtk/install-dependencies: Install dependencies on OSX with Homebrew.
1263         * gtk/jhbuild.modules: Moved platform-specific build settings in condition tags.
1264         * gtk/patches/foxbntconfig-fix-osx-cache.diff: Added.
1265         * gtk/jhbuildrc: GTK+ makeargs clean-up, the 3.0.12 hack is no longer needed.
1266
1267 2015-12-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1268
1269         Unreviewed, move Sebastian Dröge to committers list
1270
1271         He accidentally added himself to the reviewers list because the file is confusing.
1272
1273         * Scripts/webkitpy/common/config/contributors.json:
1274
1275 2015-12-24  Simon Fraser  <simon.fraser@apple.com>
1276
1277         Remove the unused #define _USE_MATH_DEFINES
1278         https://bugs.webkit.org/show_bug.cgi?id=152034
1279
1280         Reviewed by Tim Horton.
1281         
1282         Update this test to use piDouble from MathExtras.h, and
1283         std::numeric_limits<>.
1284
1285         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1286
1287 2015-12-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1288
1289         Python SCM should be able to retrieve untracked files - Generic changes
1290         https://bugs.webkit.org/show_bug.cgi?id=152536
1291
1292         Reviewed by Brent Fulgham.
1293
1294         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
1295         No support is yet added to GIT and SVN specific implementations.
1296
1297         * Scripts/webkitpy/common/checkout/scm/scm.py:
1298         (SCM.untracked_files):
1299         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1300         (SCMTest._shared_test_untracked_files):
1301
1302 2015-12-23  Dewei Zhu  <dewei_zhu@apple.com>
1303
1304         SVN checkout used by RunBenchmark should be non-interactive
1305         https://bugs.webkit.org/show_bug.cgi?id=152542
1306
1307         Reviewed by Ryosuke Niwa.
1308
1309         RunBenchmark should not require user interaction while running.
1310
1311         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
1312         (BenchmarkBuilder._checkout_with_subversion):
1313
1314 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
1315
1316         Web Inspector: add support for running protocol-test.js tests on Windows
1317         https://bugs.webkit.org/show_bug.cgi?id=148037
1318         <rdar://problem/22292237>
1319
1320         Reviewed by Simon Fraser.
1321
1322         * DumpRenderTree/win/TestRunnerWin.cpp:
1323         (TestRunner::inspectorTestStubURL): Provide implementation.
1324
1325 2015-12-23  Eric Carlson  <eric.carlson@apple.com>
1326
1327         [MediaStream] MediaDeviceInfo.label must be empty in some situations
1328         https://bugs.webkit.org/show_bug.cgi?id=152000
1329
1330         Reviewed by Brent Fulgham.
1331
1332         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1333         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1334         (WTR::InjectedBundle::setUserMediaPermission):
1335         (WTR::InjectedBundle::setUserMediaPermissionForOrigin): New.
1336         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1337
1338         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1339         (WTR::TestRunner::setUserMediaPermissionForOrigin): New.
1340         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1341
1342         * WebKitTestRunner/TestController.cpp:
1343         (WTR::TestController::setUserMediaPermissionForOrigin):
1344         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Add NULL check.
1345         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Don't add 
1346           persistent permission for origin, that can be done from script now.
1347         * WebKitTestRunner/TestController.h:
1348
1349         * WebKitTestRunner/TestInvocation.cpp:
1350         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Add support for
1351           SetUserMediaPermissionForOrigin.
1352
1353 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
1354
1355         [Win] Unreviewed build fix: Recognize Windows 10 variants.
1356
1357         * Scripts/webkitpy/common/system/platforminfo.py:
1358         (PlatformInfo._determine_win_version):
1359
1360 2015-12-23  Chris Aljoudi <chris@chrismatic.io> and Alex Christensen <achristensen@webkit.org>
1361
1362         Content blockers should be able to promote http to https
1363         https://bugs.webkit.org/show_bug.cgi?id=148966
1364
1365         Reviewed by Benjamin Poulain.
1366
1367         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1368         (WebCore::ContentExtensions::operator<<):
1369         (TestWebKitAPI::TEST_F):
1370
1371 2015-12-22  Hunseop Jeong  <hs85.jeong@samsung.com>
1372
1373         [EFL] MiniBrowser should be able to choose the offline-web-application-cache option
1374         https://bugs.webkit.org/show_bug.cgi?id=152516
1375
1376         Reviewed by Gyuyoung Kim.
1377
1378         * MiniBrowser/efl/main.c:
1379
1380 2015-12-22  Brent Fulgham  <bfulgham@apple.com>
1381
1382         Unreviewed: Add John Wilander as a contributor.
1383
1384         * Scripts/webkitpy/common/config/contributors.json:
1385
1386 2015-12-22  Chris Fleizach  <cfleizach@apple.com>
1387
1388         [WK2] Looping in testcase: fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
1389         https://bugs.webkit.org/show_bug.cgi?id=152482
1390
1391         Reviewed by Brent Fulgham.
1392
1393         vertical/horizontalScrollbar returns an accessibility element. That element can also be queried
1394         for the same property. On WK2, the element returned will not be valid, but is still present and
1395         that can lead to looping.
1396
1397         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1398         (AccessibilityUIElement::horizontalScrollbar):
1399         (AccessibilityUIElement::verticalScrollbar):
1400         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1401         (WTR::AccessibilityUIElement::horizontalScrollbar):
1402         (WTR::AccessibilityUIElement::verticalScrollbar):
1403
1404 2015-12-22  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1405
1406         Unreviewed.
1407
1408         * Scripts/webkitpy/common/config/contributors.json: Marking myself as reviewer.
1409
1410 2015-12-21  Hunseop Jeong  <hs85.jeong@samsung.com>
1411
1412         [EFL] test_ewk2_context failed after r192808
1413         https://bugs.webkit.org/show_bug.cgi?id=151846
1414
1415         Reviewed by Gyuyoung Kim.
1416
1417         Used the added ewk_context_web_process_count_limit_set api
1418         instead of the deprecated ewk_context_process_model_set.
1419
1420         * MiniBrowser/efl/main.c:
1421         (elm_main):
1422
1423 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
1424
1425         Unreviewed, move myself to reviewer list.
1426
1427         * Scripts/webkitpy/common/config/contributors.json:
1428
1429 2015-12-21  Aakash Jain  <aakash_jain@apple.com>
1430
1431         Unreviewed, add myself to the committers list.
1432
1433         * Scripts/webkitpy/common/config/contributors.json:
1434
1435 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
1436
1437         [GTK] jquery.min.js violates DFSG
1438         https://bugs.webkit.org/show_bug.cgi?id=152428
1439
1440         Reviewed by Joseph Pecoraro.
1441
1442         Stop distributing Source/WebInspectorUI/Tools. It is not needed in tarballs. This brings us
1443         into compliance with DFSG by removing a bundled, minified copy of jQuery from our tarball.
1444
1445         * gtk/manifest.txt.in:
1446
1447 2015-12-19  Dan Bernstein  <mitz@apple.com>
1448
1449         [Mac] WebKit contains dead source code for OS X Mavericks and earlier
1450         https://bugs.webkit.org/show_bug.cgi?id=152462
1451
1452         Reviewed by Alexey Proskuryakov.
1453
1454         - Removed definitions of MACOSX_DEPLOYMENT_TARGET and WEBKIT_SYSTEM_INTERFACE_LIBRARY for
1455           OS X 10.9:
1456
1457         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1458         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1459         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1460         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1461         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1462
1463         - Simplified expressions involving __MAC_OS_X_VERSION_MIN_REQUIRED and removed code that was
1464           never getting compiled:
1465
1466         * DumpRenderTree/mac/TextInputController.m:
1467         * MiniBrowser/mac/BrowserWindowController.m:
1468         * TestWebKitAPI/Tests/mac/AttributedString.mm:
1469         * WebKitTestRunner/mac/EventSenderProxy.mm:
1470
1471 2015-12-18  Michael Catanzaro  <mcatanzaro@igalia.com>
1472
1473         Unreviewed, add WebKitGTK+ Bugzilla email to committers list
1474
1475         This is to make it easy to CC it on Bugzilla.
1476
1477         * Scripts/webkitpy/common/config/contributors.json:
1478
1479 2015-12-18  Aakash Jain  <aakash_jain@apple.com>
1480
1481         Pasteboard get messed up after running kill-old-processes
1482         https://bugs.webkit.org/show_bug.cgi?id=152426
1483
1484         Reviewed by Alexey Proskuryakov.
1485
1486         * BuildSlaveSupport/kill-old-processes:
1487         (main): Do not kill pasteboard anymore.
1488
1489 2015-12-17  Aakash Jain  <aakash_jain@apple.com>
1490
1491         run-webkit-tests shouldn't start multiple iOS simulators while only running one test
1492         https://bugs.webkit.org/show_bug.cgi?id=152157
1493         <rdar://problem/23851817>
1494
1495         Reviewed by Alexey Proskuryakov.
1496
1497         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1498         (LayoutTestRunner.get_worker_count): Calculate required number of workers.
1499         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1500         (Manager._get_test_inputs): Common method to calculate test_inputs.
1501         (Manager._update_worker_count): Calculate and update required number of workers.
1502
1503 2015-12-16  Aakash Jain  <aakash_jain@apple.com>
1504
1505         run-webkit-tests fails to delete Simulator device during cleanup
1506         https://bugs.webkit.org/show_bug.cgi?id=152363
1507
1508         Reviewed by Alexey Proskuryakov.
1509
1510         * Scripts/webkitpy/xcode/simulator.py:
1511         (Simulator.delete_device): Ensure that device is Shutdown before deleting it.
1512
1513 2015-12-16  Tim Horton  <timothy_horton@apple.com>
1514
1515         [mac-wk2] fast/events force click tests crashing
1516         https://bugs.webkit.org/show_bug.cgi?id=152339
1517
1518         Reviewed by Beth Dakin.
1519
1520         * WebKitTestRunner/mac/EventSenderProxy.mm:
1521         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
1522         Set the NSEvent's _type member in addition to overriding -type,
1523         because there are assertions in touch event handling code that depend on it.
1524
1525 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1526
1527         Enforce temporarily bots to sync WebKit and WPT testharness.js
1528         https://bugs.webkit.org/show_bug.cgi?id=152334
1529
1530         Reviewed by Darin Adler.
1531
1532         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1533         (WebPlatformTestServer._copy_webkit_test_files): Temporarily overwrite wpt testharness.js with WebKit testharness.js.
1534
1535 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1536
1537         [Fetch API] Add fetch API compile time flag
1538         https://bugs.webkit.org/show_bug.cgi?id=152254
1539
1540         Reviewed by Darin Adler.
1541
1542         * Scripts/webkitperl/FeatureList.pm:
1543
1544 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1545
1546         Unreviewed.
1547
1548         Added files that have impact in building Streams API to the watchlist.
1549
1550         * Scripts/webkitpy/common/config/watchlist:
1551
1552 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1553
1554         Unreviewed.
1555
1556         Added imported tests to Streams API watchlist.
1557
1558         * Scripts/webkitpy/common/config/watchlist:
1559
1560 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1561
1562         Remove default copy of wpt testharness.js when launching wpt server
1563         https://bugs.webkit.org/show_bug.cgi?id=152298
1564
1565         Reviewed by Darin Adler.
1566
1567         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1568         (WebPlatformTestServer._copy_webkit_test_files): Deleted default copy of WebKit testharness.js to WPT.
1569
1570 2015-12-15  David Kilzer  <ddkilzer@apple.com>
1571
1572         REGRESSION (r192375): DumpRenderTree.app exits immediately with no error
1573         <http://webkit.org/b/152314>
1574
1575         Reviewed by Daniel Bates.
1576
1577         The change to DumpRenderTreeMain.mm in r192375 caused the iOS
1578         code path to exit immediately when calling main().
1579         Unfortunately, DumpRenderTreeMain.mm was used for both
1580         DumpRenderTree command-line binary and DumpRenderTree.app, which
1581         meant that the app would exit immediately with no error code
1582         when run!
1583
1584         The workaround is to introduce a separate source file called
1585         DumpRenderTreeAppMain.mm, similar to what WebKitTestRunner
1586         already does.
1587
1588         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add
1589         DumpRenderTreeAppMain.mm to the project.  Make it the only
1590         compiled source for the DumpRenderTree.app target.
1591         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm: Copied from Tools/DumpRenderTree/mac/DumpRenderTreeMain.mm.
1592         (main): Call DumpRenderTreeMain() on iOS.  Assert on OS X in
1593         case someone tries mistakenly to use the app.
1594         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1595         Link to JavaScriptCore.framework on iOS for the assert.
1596         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1597         Link to JavaScriptCore.framework on OS X for the assert.  Remove
1598         unneeded EXCLUDED_SOURCE_FILE_NAMES setting.
1599         * DumpRenderTree/mac/DumpRenderTreeMain.mm:
1600         (main): Add assert for iOS so that a crash occurs if someone
1601         tries to run the wrong command.
1602
1603 2015-12-14  Tim Horton  <timothy_horton@apple.com>
1604
1605         Frequent crash under -[WKPDFView web_setMinimumSize:]_block_invoke
1606         https://bugs.webkit.org/show_bug.cgi?id=152266
1607         <rdar://problem/22092676>
1608
1609         Reviewed by Simon Fraser.
1610
1611         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1612         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm: Added.
1613         Add a test that crashed before this change, and doesn't crash after.
1614
1615 2015-12-14  Chris Fleizach  <cfleizach@apple.com>
1616
1617         AX: iOS: Text field variations do not have the correct traits
1618         https://bugs.webkit.org/show_bug.cgi?id=152237
1619
1620         Reviewed by Mario Sanchez Prada.
1621
1622         Add iOS calls for determing if an object is a search field or a text area.
1623
1624         * DumpRenderTree/AccessibilityUIElement.cpp:
1625         (getIsSearchFieldCallback):
1626         (getIsTextAreaCallback):
1627         (stringForSelectionCallback):
1628         (AccessibilityUIElement::getJSClass):
1629         * DumpRenderTree/AccessibilityUIElement.h:
1630         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1631         (AccessibilityUIElement::identifier):
1632         (AccessibilityUIElement::isTextArea):
1633         (AccessibilityUIElement::isSearchField):
1634         (AccessibilityUIElement::traits):
1635         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1636         (WTR::AccessibilityUIElement::scrollPageRight):
1637         (WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
1638         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
1639         (WTR::AccessibilityUIElement::isSearchField):
1640         (WTR::AccessibilityUIElement::isTextArea):
1641         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1642         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1643         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1644         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
1645         (WTR::AccessibilityUIElement::isTextArea):
1646         (WTR::AccessibilityUIElement::isSearchField):
1647         (WTR::AccessibilityUIElement::rowCount):
1648
1649 2015-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1650
1651         [GTK] [JHBuild] package libtool-bin is now required on Debian systems.
1652         https://bugs.webkit.org/show_bug.cgi?id=152252
1653
1654         Reviewed by Sergio Villar Senin.
1655
1656         * gtk/install-dependencies: Add libtool-bin to the list of packages required
1657         for building the JHBuild on Debian systems.
1658
1659 2015-12-11  Joseph Pecoraro  <pecoraro@apple.com>
1660
1661         check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones
1662         https://bugs.webkit.org/show_bug.cgi?id=152156
1663
1664         Reviewed by Dan Bernstein.
1665
1666         Our frameworks should appropriately prefix all ObjC classes,
1667         not just external symbols.
1668
1669         * Scripts/check-for-inappropriate-objc-class-names:
1670         Remove the -g switch to check all ObjC class names.
1671
1672 2015-12-10  Eric Carlson  <eric.carlson@apple.com>
1673
1674         [MediaStream] Expose media capture devices persistent permissions to WebCore
1675         https://bugs.webkit.org/show_bug.cgi?id=152087
1676
1677         Add support for the new user media permission checker page UI client method.
1678
1679         Reviewed by Chris Dumez.
1680
1681         * WebKitTestRunner/TestController.cpp:
1682         (WTR::decidePolicyForUserMediaPermissionRequest):
1683         (WTR::checkUserMediaPermissionForOrigin):
1684         (WTR::TestController::createOtherPage): Add checkUserMediaPermissionForOrigin.
1685         (WTR::TestController::createWebViewWithOptions): Ditto.
1686         (WTR::TestController::resetStateToConsistentValues): Clear m_userMediaOriginPermissions.
1687         (WTR::originUserVisibleName): New, create a string for the origin.
1688         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Set the WKUserMediaPermissionCheckRef
1689           according to the state of the origin permission map.
1690         (WTR::TestController::handleUserMediaPermissionRequest): Remember both the origin and the
1691           request so we can update the origin permission map in decidePolicyForUserMediaPermissionRequestIfPossible.
1692         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update the
1693           origin permission map.
1694         * WebKitTestRunner/TestController.h:
1695
1696 2015-12-10  Alex Christensen  <achristensen@webkit.org>
1697
1698         REGRESSION (r192796) WKBundlePageResourceLoadClient should be able to setHTTPBody in willSendRequestForFrame
1699         https://bugs.webkit.org/show_bug.cgi?id=152022
1700         rdar://problem/23763584
1701
1702         Reviewed by Darin Adler.
1703
1704         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1705         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1706         (WTR::InjectedBundlePage::willSendRequestForFrame):
1707         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1708         (WTR::TestRunner::setWillSendRequestReturnsNull):
1709         (WTR::TestRunner::willSendRequestReturnsNullOnRedirect):
1710         (WTR::TestRunner::setWillSendRequestReturnsNullOnRedirect):
1711         (WTR::TestRunner::setWillSendRequestAddsHTTPBody):
1712         (WTR::TestRunner::willSendRequestHTTPBody):
1713         Added setWillSendRequestAddsHTTPBody that uses new SPI for testing.
1714
1715 2015-12-10  Aakash Jain  <aakash_jain@apple.com>
1716
1717         Remove additional simulator checks before running layout-tests
1718         https://bugs.webkit.org/show_bug.cgi?id=152146
1719
1720         Reviewed by Darin Adler.
1721
1722         * Scripts/webkitpy/port/ios.py:
1723         (IOSSimulatorPort.check_sys_deps): Removed additional simulators verifications.
1724         * Scripts/webkitpy/xcode/simulator.py:
1725         (Simulator._boot_and_shutdown_simulator_device): Deleted.
1726         (Simulator.check_simulator_device_and_erase_if_needed): Deleted.
1727
1728 2015-12-09  Aakash Jain  <aakash_jain@apple.com>
1729
1730         Run atleast one simulator even if max process limit is low
1731         https://bugs.webkit.org/show_bug.cgi?id=152081
1732         <rdar://problem/23819694>
1733
1734         Reviewed by Alexey Proskuryakov.
1735
1736 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
1737
1738         [GTK] Crash in WebProcess when loading large content with custom URI schemes
1739         https://bugs.webkit.org/show_bug.cgi?id=144262
1740
1741         Reviewed by Carlos Garcia Campos.
1742
1743         Added new unit test to check the additional scenarios we now
1744         handle for custom URI schemes.
1745
1746         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1747         (generateHTMLContent): New helper function to generate big enough content.
1748         (testWebContextURIScheme): New unit test.
1749
1750 2015-12-09  Ryuan Choi  <ryuan.choi@navercorp.com>
1751
1752         [EFL] Fix unhandled web process message when launching MiniBrowser
1753         https://bugs.webkit.org/show_bug.cgi?id=152048
1754
1755         Reviewed by Gyuyoung Kim.
1756
1757         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
1758         (TestWebKitAPI::TEST):
1759
1760 2015-12-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1761
1762         [GTK] Add API to handle beforeunload events
1763         https://bugs.webkit.org/show_bug.cgi?id=139090
1764
1765         Reviewed by Gustavo Noronha Silva.
1766
1767         * MiniBrowser/gtk/BrowserWindow.c:
1768         (browserWindowConstructed):
1769         (browserWindowDeleteEvent):
1770         (browser_window_class_init):
1771         Handle delete-event to prevent the window from being closed when
1772         the page has beforeunload handlers. Use
1773         webkit_web_view_try_close() when the window is requested to be
1774         closed.
1775         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1776         (testWebViewJavaScriptDialogs):
1777         Add a test case for the WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM
1778         script dialog type.
1779
1780 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
1781
1782         Refactored initialization code in LoadTrackingTest.
1783
1784         Rubber-stamped by Carlos Garcia Campos.
1785
1786         Small refactoring to make sure that the state of a LoadTrackingTest
1787         gets properly reset before loading new web content.
1788
1789         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
1790         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
1791         (LoadTrackingTest::reset): New, refactored code from *load*() and go*()
1792         functions and reset the remaining local variables.
1793         (LoadTrackingTest::loadURI): Call reset();
1794         (LoadTrackingTest::loadHtml): Ditto.
1795         (LoadTrackingTest::loadPlainText): Ditto.
1796         (LoadTrackingTest::loadBytes): Ditto.
1797         (LoadTrackingTest::loadRequest): Ditto.
1798         (LoadTrackingTest::reload): Ditto.
1799         (LoadTrackingTest::goBack): Ditto.
1800         (LoadTrackingTest::goForward): Ditto.
1801
1802 2015-12-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1803
1804         [EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
1805         https://bugs.webkit.org/show_bug.cgi?id=151942
1806
1807         Reviewed by Darin Adler.
1808
1809         * MiniBrowser/efl/main.c:
1810         (window_create): Enable offline web application cache feature on MiniBrowser.
1811         (elm_main):
1812
1813 2015-12-08  Aakash Jain  <aakash_jain@apple.com>
1814
1815         https://bugs.webkit.org/show_bug.cgi?id=151243
1816         <rdar://problem/22955197>
1817
1818         Reviewed by Alexey Proskuryakov.
1819
1820         * LayoutTestRelay/LayoutTestRelay/main.m:
1821         (getTestingSimDevice): Use separate testing device for each worker.
1822         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1823         (Manager.run): Perform cleanup even if setup fails.
1824         * Scripts/webkitpy/port/ios.py:
1825         (IOSSimulatorPort.default_child_processes): Calculate number of simulators to use.
1826         (IOSSimulatorPort.child_processes): Gets the number of simulators from options variable.
1827         (IOSSimulatorPort.setup_test_run): Handle mulitple simulators.
1828         (IOSSimulatorPort._quit_ios_simulator): Same
1829         (IOSSimulatorPort.clean_up_test_run): Same
1830         (IOSSimulatorPort.check_sys_deps): Same
1831         (IOSSimulatorPort.testing_device): Same
1832         (IOSSimulatorPort.reset_preferences): Same
1833         (IOSSimulatorPort.get_simulator_path): Return simulator path.
1834         (IOSSimulatorPort._createSimulatorApp): Create the copy of simulator app.
1835         * Scripts/webkitpy/xcode/simulator.py:
1836         (Device.delete): Delete the simulator device.
1837         (Simulator.delete_device): Same
1838         (Simulator.wait_until_device_is_booted): Wait for device booting.
1839
1840 2015-12-08  Ryuan Choi  <ryuan.choi@navercorp.com>
1841
1842         [EFL] Add API to provide preferences before creating ewk_view
1843         https://bugs.webkit.org/show_bug.cgi?id=151587
1844
1845         Reviewed by Gyuyoung Kim.
1846
1847         * MiniBrowser/efl/main.c:
1848         (on_key_down):
1849         (quit):
1850         (window_create):
1851         Moved settings related code to configuration() not to update settings
1852         whenever ewk_view is created.
1853         (configuration):
1854         (elm_main):
1855
1856 2015-12-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1857
1858         Unreviewed. Fix GTK+ API tests after r193639.
1859
1860         The new jhbuild version needs some more variables ot be present in
1861         the builtin dict, even if they are set to None.
1862
1863         * jhbuild/jhbuildutils.py:
1864         (enter_jhbuild_environment_if_available):
1865
1866 2015-12-07  Gustavo Noronha Silva  <gns@gnome.org>
1867
1868         [GTK] Notify WebCore when notification is clicked
1869         https://bugs.webkit.org/show_bug.cgi?id=151951
1870
1871         Reviewed by Carlos Garcia Campos.
1872
1873         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1874         (testWebViewNotification): test the new API.
1875
1876 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1877
1878         'jhbuild build' should fail immediately when building any module fails
1879         https://bugs.webkit.org/show_bug.cgi?id=145697
1880
1881         Reviewed by Carlos Garcia Campos.
1882
1883         * efl/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
1884         * gtk/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
1885         Everything is placed under lib instead of lib64 now.
1886         * jhbuild/jhbuild-wrapper: Update jhbuild to the latest upstream commit, and pass
1887         --exit-on-error when running 'jhbuild build'.
1888         * jhbuild/jhbuildrc_common.py:
1889         (init): Don't override PKG_CONFIG_PATH, CMAKE_PREFIX_PATH, or CMAKE_LIBRARY_PATH. Modern
1890         jhbuild should be able to handle these for us without breaking things....
1891
1892 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1893
1894         Add support to import w3c tests from a repository with a different root that the main repo dir
1895         https://bugs.webkit.org/show_bug.cgi?id=151751
1896
1897         Reviewed by Ryosuke Niwa and Youenn Fablet.
1898
1899         We should be able to import tests from repositories that are not pure test repositories and where tests are kept
1900         in a different directory than the repository root.
1901
1902         This patch introduces a new parameter tests_directory that we will use as root directory to search for
1903         tests. All paths will be flattened when copying tests to have a less complicated directory structure. This
1904         requires having the copy_path lists including tuples of origin and destination directories.
1905
1906         * Scripts/webkitpy/w3c/test_downloader.py:
1907         (TestDownloader._add_test_suite_paths): Adds the paths as a tuple of origin and destination directory.
1908         (TestDownloader.copy_tests): Uses the origin and destination tuple for the paths to copy when copying files.
1909         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1910         (TestImporterTest.test_tests_directory): Test.
1911
1912 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1913
1914         Mock TestRepositories in W3C importer tests
1915         https://bugs.webkit.org/show_bug.cgi?id=151938
1916
1917         Reviewed by Youenn Fablet.
1918
1919         The test importer tests should use a fake repository instead of using the real one. The reason why this happened
1920         is because the test repository method reading the file was using the filesystem directly instead of taking the
1921         host one. This patch changes that.
1922
1923         * Scripts/webkitpy/w3c/test_downloader.py:
1924         (TestDownloader.load_test_repositories): Take a filesystem and use it. If we get no filesystem, we use the
1925         default one.
1926         (TestDownloader.__init__): When loading the repositories, pass the host filesystem.
1927         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1928         (TestImporterTest.test_harnesslinks_conversion):
1929         (TestImporterTest.test_submodules_generation): Use a fake test repository file.
1930
1931 2015-12-07  David Kilzer  <ddkilzer@apple.com>
1932
1933         TestNetscapePlugIn: Address review comment on 193607
1934         <http://webkit.org/b/151881>
1935
1936         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1937         (testSetStatus): Initializing std::unique_ptr<char[]> with
1938         nullptr is redundant.
1939
1940 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1941
1942         [GTK] Add webkit_uri_request_get_http_method
1943         https://bugs.webkit.org/show_bug.cgi?id=151601
1944
1945         Reviewed by Martin Robinson.
1946
1947         Add test case to check HTTP method of WebKitURIRequest.
1948
1949         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
1950         (testURIRequestHTTPMethod):
1951         (serverCallback):
1952         (beforeAll):
1953         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1954         (sendRequestCallback):
1955
1956 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1957
1958         [GTK] Add WebKitWebPage::console-message-sent signal to Web Extensions API
1959         https://bugs.webkit.org/show_bug.cgi?id=79918
1960
1961         Reviewed by Gustavo Noronha Silva.
1962
1963         Add unit tests to check the different console messages.
1964
1965         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1966         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp: Added.
1967         (ConsoleMessageTest::ConsoleMessage::operator==):
1968         (ConsoleMessageTest::consoleMessageReceivedCallback):
1969         (ConsoleMessageTest::ConsoleMessageTest):
1970         (ConsoleMessageTest::~ConsoleMessageTest):
1971         (ConsoleMessageTest::waitUntilConsoleMessageReceived):
1972         (testWebKitConsoleMessageConsoleAPI):
1973         (testWebKitConsoleMessageJavaScriptException):
1974         (testWebKitConsoleMessageNetworkError):
1975         (testWebKitConsoleMessageSecurityError):
1976         (beforeAll):
1977         (afterAll):
1978         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1979         (consoleMessageSentCallback):
1980         (pageCreatedCallback):
1981
1982 2015-12-07  Ryuan Choi  <ryuan.choi@navercorp.com>
1983
1984         [EFL] MiniBrowser doesn't exit when called ewk_view_try_close()
1985         https://bugs.webkit.org/show_bug.cgi?id=151934
1986
1987         Reviewed by Csaba Osztrogonác.
1988
1989         * MiniBrowser/efl/main.c:
1990         (on_window_deletion): Revert the changes of r192767.
1991
1992 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1993
1994         [GTK] update-webkitgtk-libs cannot build mesa
1995         https://bugs.webkit.org/show_bug.cgi?id=151535
1996
1997         Reviewed by Martin Robinson.
1998
1999         Upgrade to newer mesa in order to build successfully against LLVM 3.7. Add missing
2000         dependency of mesa on LLVM, to ensure LLVM is built first. Build LLVM unconditionally, even
2001         on architectures where FTL is not supported, to ensure mesa is always buildable, since LLVM
2002         does not have a stable API and we cannot expect mesa to be buildable unless we control the
2003         LLVM version. Build mesa with --disable-egl since --enable-egl conflicts with
2004         --enable-xlib-glx. This fixes update-webkitgtk-libs on distros with LLVM 3.7.
2005
2006         * gtk/jhbuild.modules:
2007
2008 2015-12-07  Philippe Normand  <pnormand@igalia.com>
2009
2010         [GTK][Mac] libWebExtensionTest link error
2011         https://bugs.webkit.org/show_bug.cgi?id=150802
2012
2013         Reviewed by Carlos Garcia Campos.
2014
2015         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: add dependencies to the webextension library.
2016
2017 2015-12-06  David Kilzer  <ddkilzer@apple.com>
2018
2019         TestNetscapePlugIn: Fix leaks found by static analyzer
2020         <http://webkit.org/b/151881>
2021
2022         Reviewed by Darin Adler.
2023
2024         Fixes the following leaks found by the static analyzer:
2025             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'path'
2026                     return false;
2027                            ^~~~~
2028             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'target'
2029                     return false;
2030                            ^~~~~
2031             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'url'
2032                     return false;
2033                            ^~~~~
2034
2035         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2036         (toCString): Switch to returning std::unique_ptr<char[]>.  Add
2037         early return if allocation fails.
2038         (testPostURLFile): Switch to using std::unique_ptr<char[]>.
2039         Make sure to call fclose() on filehandle, even for an early
2040         return.
2041         (testSetStatus): Switch to using std::unique_ptr<char[]>.
2042
2043 2015-12-05  David Kilzer  <ddkilzer@apple.com>
2044
2045         prepare-ChangeLog: Fix some warning messages when using svn
2046         <http://webkit.org/b/151914>
2047
2048         Reviewed by Daniel Bates.
2049
2050         * Scripts/prepare-ChangeLog:
2051         (generateFunctionLists): Simplify logic so that we never call
2052         normalizePath() with an undefined value.
2053         (attributeCommand): Quote $subPath for the shell so that we
2054         don't try to run "svn propget" on invalid paths.
2055
2056 2015-12-04  David Kilzer  <ddkilzer@apple.com>
2057
2058         TestNetscapePlugIn: Fix remaining static analyzer warnings
2059         <http://webkit.org/b/151888>
2060
2061         Reviewed by Alexey Proskuryakov.
2062
2063         Fixes the following static analyzer warnings:
2064             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:101:9: warning: Called function pointer is null (null dereference)
2065                     CRASH();
2066                     ^~~~~~~
2067             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:46:5: note: expanded from macro 'CRASH'
2068                 ((void(*)())0)(); /* More reliable, but doesn't say BBADBEEF */ \
2069                 ^~~~~~~~~~~~~~~~
2070             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:375:12: warning: Access to field 'pluginTest' results in a dereference of a null pointer (loaded from variable 'obj')
2071                 return obj->pluginTest->NPP_SetWindow(window);
2072                        ^~~~~~~~~~~~~~~
2073             2 warnings generated.
2074
2075         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2076         (CRASH): Use __builtin_trap() for gcc/clang.
2077         (NPP_SetWindow): Add early return if obj is nullptr.
2078
2079 2015-12-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2080
2081         [GTK] Test /webkit2/WebKitWebResource/get-data is flaky
2082         https://bugs.webkit.org/show_bug.cgi?id=151797
2083
2084         Reviewed by Martin Robinson.
2085
2086         Since we switched to use the network process to run the unit tests
2087         the test /webkit2/WebKitWebResource/get-data sometimes fails and
2088         sometimes passes. We are now also getting the notification for the
2089         css image. Since we wait for 3 resources, sometimes the css image
2090         is loaded before and then checkResourceData is called for it, but
2091         not handled. When the css image is the last one loaded the test
2092         passes. So, we just need to wait for the 4 resources.
2093
2094         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2095         (testWebResourceGetData):
2096
2097 2015-12-03  David Kilzer  <ddkilzer@apple.com>
2098
2099         DumpRenderTree: Use-after-free in createBitmapContext() in PixelDumpSupportMac.mm
2100         <http://webkit.org/b/151845>
2101
2102         Reviewed by Simon Fraser.
2103
2104         Fixes the following static analyzer warning:
2105             DumpRenderTree/mac/PixelDumpSupportMac.mm:67:9: warning: Use of memory after it is freed
2106                     WTFLogAlways("DumpRenderTree: CGBitmapContextCreate(%p, %llu, %llu, 8, %llu, %p, 0x%x) failed\n", buffer, pixelsHigh, pixelsWide, rowBytes, colorSpace.get(), kCGImageAlphaPremultipliedFirst | kCGBitmapByteOrder32Host);
2107                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2108
2109         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2110         (createBitmapContext): Free 'buffer' after using it in logging
2111         to fix the use-after-free.  Assign a value of nullptr to buffer
2112         so we don't return with it set to a freed address.
2113
2114 2015-12-03  Jer Noble  <jer.noble@apple.com>
2115
2116         Expose WebCore's InvisibleAutoplayNotPermitted setting to WebKit & WebKit2
2117         https://bugs.webkit.org/show_bug.cgi?id=151830
2118
2119         Reviewed by Anders Carlsson.
2120
2121         Set invisibleAutoplayNotPermitted to NO by default both in WKTR and DRT.
2122
2123         * DumpRenderTree/mac/DumpRenderTree.mm:
2124         (resetWebPreferencesToConsistentValues):
2125         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2126         (WTR::initializeWebViewConfiguration):
2127
2128 2015-12-03  Anders Carlsson  <andersca@apple.com>
2129
2130         Remove Objective-C GC support
2131         https://bugs.webkit.org/show_bug.cgi?id=151819
2132         rdar://problem/23746991
2133
2134         Reviewed by Dan Bernstein.
2135
2136         * asan/asan.xcconfig:
2137
2138 2015-12-02  Yusuke Suzuki  <utatane.tea@gmail.com>
2139
2140         Allow nil for unspecified benchmark pathes
2141         https://bugs.webkit.org/show_bug.cgi?id=151784
2142
2143         Reviewed by Filip Pizlo.
2144
2145         `Pathname.new(nil)` will raise an error.
2146         Only generate Pathname if the benchmark path is specified.
2147
2148         * Scripts/run-jsc-benchmarks:
2149
2150 2015-12-02  Brent Fulgham  <bfulgham@apple.com>
2151
2152         [Win] Run non-http tests without Cygwin
2153         https://bugs.webkit.org/show_bug.cgi?id=151721
2154
2155         Reviewed by Andy Estes.
2156
2157         Support native 32-bit and 64-bit Python (and Perl) builds
2158         for running tests:
2159
2160         1. Use "startswith('win')", rather than "== 'win32'" to support
2161         various Windows build types.
2162         2. Supply full path for some native Windows utilities, since the
2163         path environment does not always have the specified, and they are
2164         guaranteed to exist in those specific locations.
2165         3. Make sure native Windows Python test runs pass proper environment
2166         variables to run programs.
2167         4. Append 'exe' suffix when running Windows executables.
2168         5. Use the _winreg Python module on Windows, since the Cygwin 'regtool'
2169         command doesn't exist.
2170         
2171         * Scripts/update-webkit: Use Perl $^X command to refer to the path of
2172         the current Perl executable, rather than requiring a new path search.
2173         * Scripts/webkitpy/common/find_files_unittest.py:
2174         (TestWinNormalize.test_win): Use startswith('win').
2175         * Scripts/webkitpy/common/prettypatch_unittest.py:
2176         (test_pretty_diff_encodings): Ditto.
2177         * Scripts/webkitpy/common/system/executive.py:
2178         (Executive._should_close_fds): Ditto.
2179         (Executive.shell_command_for_script): Use startswith('win').
2180         (Executive.kill_process): Use full path to killall executable.
2181         (Executive.check_running_pid): Use startswith('win').
2182         (Executive.running_pids): Ditto.
2183         (Executive.kill_all): Ditto. Also use path to 'killall' executable when
2184         running under native Windows Python.
2185         (Executive._child_process_encoding): Use startswith('win').
2186         (Executive._should_encode_child_process_arguments): Ditto.
2187         (Executive.popen): Recognize proper script engine on Windows, since it
2188         does not support the shebang syntax.
2189         (Executive.run_in_parallel): Use startswith('win').
2190         * Scripts/webkitpy/common/system/executive_unittest.py:
2191         (never_ending_command): Ditto.
2192         (ExecutiveTest.test_run_command_with_unicode): Ditto.
2193         (ExecutiveTest.serial_test_kill_process): Ditto.
2194         (ExecutiveTest.serial_test_kill_all): Ditto.
2195         (ExecutiveTest.serial_test_check_running_pid): Ditto.
2196         (ExecutiveTest.serial_test_run_in_parallel): Ditto.
2197         (main): Ditto.
2198         * Scripts/webkitpy/common/system/file_lock.py:
2199         (FileLock._create_lock): Ditto.
2200         (FileLock._remove_lock): Ditto.
2201         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2202         (RealFileSystemTest.test_chdir): Ditto.
2203         (RealFileSystemTest.test_chdir__notexists): Ditto.
2204         (RealFileSystemTest.test_maybe_make_directory__failure): Ditto.
2205         * Scripts/webkitpy/common/system/path_unittest.py:
2206         (AbspathTest.test_abspath_to_uri_win): Ditto.
2207         * Scripts/webkitpy/common/system/platforminfo.py:
2208         (PlatformInfo._determine_os_name): Ditto.
2209         * Scripts/webkitpy/common/system/user.py: Ditto.
2210         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2211         (ManagerTest.integration_test_needs_servers): Ditto.
2212         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2213         (LayoutTestApacheHttpd.__init__): Handle upper and lower-case
2214         driver letters.
2215         (LayoutTestApacheHttpd._get_apache_config_file_path): Ditto.
2216         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
2217         (TestLayoutTestApacheHttpd.test_start_cmd): Ditto.
2218         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2219         (HttpServerBase._check_that_all_ports_are_available): Ditto.
2220         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2221         (TestHttpServer.test_start_cmd): Ditto.
2222         * Scripts/webkitpy/port/base.py:
2223         (Port.to.setup_environ_for_server): Include 'COMSPEC', 'SYSTEMDRIVE',
2224         and 'SYSTEMROOT' in environment passed to test runners.
2225         (Port._apache_config_file_name_for_platform): Use startswith('win').
2226         (Port._build_path): Ditto.
2227         (Port._path_to_driver): Include 'exe' suffix when running under native
2228         Windows.
2229         * Scripts/webkitpy/port/driver.py:
2230         (Driver._setup_environ_for_driver): Explicitly make some environment
2231         variables strings.
2232         * Scripts/webkitpy/port/server_process.py:
2233         (ServerProcess.__init__): Use startswith('win').
2234         * Scripts/webkitpy/port/win.py:
2235         (WinPort): Use the win32 registry utilities on Windows, and appropriate
2236         registry key formats.
2237         (WinPort._ntsd_location): Revise tool search paths for Windows 10.
2238         (WinPort.read_registry_value): Revise to use _winreg library on Windows,
2239         and regtool on Cygwin.
2240         (WinPort.write_registry_value): Ditto.
2241         (WinPort.setup_crash_log_saving): Ditto.
2242         (WinPort.restore_crash_log_saving): Ditto.
2243         (WinPort.prevent_error_dialogs): Ditto.
2244         (WinPort.allow_error_dialogs): Ditto.
2245         (WinPort.find_system_pid): Revise to use Windows management
2246         infrastructure on native Windows, continue using 'ps' on Cygwin.
2247         (WinPort.read_registry_string): Deleted.
2248         (WinPort.write_registry_string): Deleted.
2249         * Scripts/webkitpy/test/main.py:
2250         (main): Use startswith('win').
2251         (Tester._parse_args): Ditto.
2252
2253 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
2254
2255         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
2256         https://bugs.webkit.org/show_bug.cgi?id=150792
2257
2258         Reviewed by Saam Barati.
2259
2260         * Scripts/webkitperl/FeatureList.pm:
2261
2262 2015-12-01  Commit Queue  <commit-queue@webkit.org>
2263
2264         Unreviewed, rolling out r192914.
2265         https://bugs.webkit.org/show_bug.cgi?id=151734
2266
2267         JSC tests for this change are failing on 32 and 64-bit bots
2268         (Requested by ryanhaddad on #webkit).
2269
2270         Reverted changeset:
2271
2272         "[ES6] Implement LLInt/Baseline Support for ES6 Generators and
2273         enable this feature"
2274         https://bugs.webkit.org/show_bug.cgi?id=150792
2275         http://trac.webkit.org/changeset/192914
2276
2277 2015-12-01  David Kilzer  <ddkilzer@apple.com>
2278
2279         EventSenderProxy::swipeGestureWithWheelAndMomentumPhases() leaks an EventSenderSyntheticEvent
2280         <http://webkit.org/b/151726>
2281
2282         Reviewed by Simon Fraser.
2283
2284         * WebKitTestRunner/mac/EventSenderProxy.mm:
2285         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
2286         Deploy RetainPtr<EventSenderSyntheticEvent> to fix leak.
2287
2288 2015-12-01  Myles C. Maxfield  <mmaxfield@apple.com>
2289
2290         Give String and AtomicString an existingHash() function
2291         https://bugs.webkit.org/show_bug.cgi?id=151717
2292
2293         Reviewed by Andreas Kling.
2294
2295         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
2296         (TestWebKitAPI::TEST):
2297         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2298         (TestWebKitAPI::TEST):
2299
2300 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
2301
2302         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
2303         https://bugs.webkit.org/show_bug.cgi?id=150792
2304
2305         Reviewed by Saam Barati.
2306
2307         * Scripts/webkitperl/FeatureList.pm:
2308
2309 2015-12-01  Sam Weinig  <sam@webkit.org>
2310
2311         Need completionHandler-based WebKit C SPI for alert, confirm, and prompt
2312         <rdar://problem/23320863>
2313         https://bugs.webkit.org/show_bug.cgi?id=151708
2314
2315         Reviewed by Anders Carlsson.
2316
2317         * WebKitTestRunner/TestController.cpp:
2318         (WTR::TestController::createOtherPage):
2319         (WTR::TestController::createWebViewWithOptions):
2320         Update for new WKPageUIClient.
2321
2322 2015-12-01  Anders Carlsson  <andersca@apple.com>
2323
2324         Remove WebKit2.framework
2325         https://bugs.webkit.org/show_bug.cgi?id=151715
2326
2327         Reviewed by Dan Bernstein.
2328
2329         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
2330         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
2331         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
2332         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2333         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
2334         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
2335         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
2336
2337 2015-12-01  Joseph Pecoraro  <pecoraro@apple.com>
2338
2339         Unreviewed common typo fix "occurance" => "occurrence".
2340
2341         * Scripts/webkitpy/tool/commands/queries.py:
2342         (FindFlakyTests._print_statistics):
2343
2344 2015-11-30  Alex Christensen  <achristensen@webkit.org>
2345
2346         Make ProcessModel always MultipleSecondaryProcesses
2347         https://bugs.webkit.org/show_bug.cgi?id=151662
2348
2349         Reviewed by Antti Koivisto.
2350
2351         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2352         (TestWebKitAPI::TEST):
2353         * WebKitTestRunner/TestController.cpp:
2354         (WTR::TestController::generatePageConfiguration):
2355
2356 2015-11-30  Alex Christensen  <achristensen@webkit.org>
2357
2358         Make usesNetworkProcess always true
2359         https://bugs.webkit.org/show_bug.cgi?id=151580
2360
2361         Reviewed by Darin Adler.
2362
2363         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2364         (TestWebKitAPI::TEST):
2365         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
2366         (TestWebKitAPI::TEST):
2367         * WebKitTestRunner/TestController.cpp:
2368         (WTR::TestController::generatePageConfiguration):
2369
2370 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2371
2372         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/editable/editable in Debug.
2373
2374         Add a way to skip unit tests only for Debug or Release builds and
2375         skipt the test /webkit2/WebKitWebView/editable/editable only for Debug.
2376
2377         * Scripts/run-gtk-tests:
2378         (SkippedTest):
2379         (SkippedTest.__init__):
2380         (SkippedTest.__str__):
2381         (SkippedTest.skip_entire_suite):
2382         (SkippedTest.skip_for_build_type):
2383         (TestRunner):
2384         (TestRunner.__init__):
2385
2386 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2387
2388         Unreviewed. Fix a crash in GTK+ test /webkit2/WebKitWebView/custom-charset.
2389
2390         It's an assert hit because we are reloading a view loaded with
2391         HTML data which is not supported. Use loadURI instead.
2392
2393         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2394         (testWebViewCustomCharset):
2395
2396 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2397
2398         [GLIB] Remove GMainLoopSource and GThreadSafeMainLoopSource
2399         https://bugs.webkit.org/show_bug.cgi?id=151633
2400
2401         Reviewed by Csaba Osztrogonác.
2402
2403         * TestWebKitAPI/PlatformGTK.cmake:
2404         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Removed.
2405
2406 2015-11-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2407
2408         [GTK] Remove the remaining uses of GMainLoopSource
2409         https://bugs.webkit.org/show_bug.cgi?id=151632
2410
2411         Reviewed by Žan Doberšek.
2412
2413         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2414         (testWebViewSyncRequestOnMaxConns):
2415         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2416         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2417         (WTR::TestRunner::TestRunner):
2418         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2419         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2420         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
2421         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2422         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2423         (WTR::timeoutSource):
2424         (WTR::TestController::notifyDone):
2425         (WTR::TestController::platformRunUntil):
2426
2427 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
2428
2429         [cmake] Add testb3 to the build system
2430         https://bugs.webkit.org/show_bug.cgi?id=151619
2431
2432         Reviewed by Gyuyoung Kim.
2433
2434         * Scripts/build-jsc:
2435
2436 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
2437
2438         [jhbuild] Fix pixman build with clang
2439         https://bugs.webkit.org/show_bug.cgi?id=151441
2440
2441         Reviewed by Carlos Garcia Campos.
2442
2443         * efl/jhbuild.modules:
2444         * gtk/jhbuild.modules:
2445
2446 2015-11-26  David Kilzer  <ddkilzer@apple.com>
2447
2448         Extract prependToEnvironmentVariableList
2449         <http://webkit.org/b/151536>
2450
2451         Reviewed by Daniel Bates.
2452
2453         Tests: webkitdirs_unittest/appendToEnvironmentVariableList.pl
2454                webkitdirs_unittest/prependToEnvironmentVariableList.pl
2455
2456         * Scripts/webkitdirs.pm: Export appendToEnvironmentVariableList
2457         and prependToEnvironmentVariableList.
2458         (appendToEnvironmentVariableList): Simplify variable name.
2459         Switch to use $Config{path_sep}.
2460         (prependToEnvironmentVariableList): Add new method.
2461         (setupMacWebKitEnvironment): Switch to use
2462         prependToEnvironmentVariableList().
2463         (setupIOSWebKitEnvironment): Ditto.
2464
2465         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl: Added.
2466         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl: Added.
2467
2468 2015-11-24  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2469
2470         REGRESSION(r192053): MiniBrowser doesn't exit when clicking on the close-window button
2471         https://bugs.webkit.org/show_bug.cgi?id=151567
2472
2473         Reviewed by Darin Adler.
2474
2475         * MiniBrowser/efl/main.c: Call window_close() instead of ewk_view_try_close().
2476         (on_window_deletion):
2477
2478 2015-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2479
2480         [GTK] Use the network process unconditionally
2481         https://bugs.webkit.org/show_bug.cgi?id=151541
2482
2483         Reviewed by Alex Christensen.
2484
2485         Fix TestInspectorServer test. Do not assume we already have the
2486         title we want when the page has been loaded, since the title is
2487         changed afterwards. So, check if the title has already been set,
2488         and if not wait for it.
2489
2490         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
2491         (openRemoteDebuggingSession):
2492
2493 2015-11-23  Alex Christensen  <achristensen@webkit.org>
2494
2495         Fix crash in ~WebProcessPool when using Geolocation with useNetworkProcess=true
2496         https://bugs.webkit.org/show_bug.cgi?id=151532
2497
2498         Reviewed by Benjamin Poulain.
2499
2500         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2501         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
2502         (TestWebKitAPI::TEST):
2503         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
2504         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker): Deleted.
2505         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker): Deleted.
2506         Properly load about:blank in all WebViews to clean up.  Without this change, we had a 
2507         Geolocation provider stopping after its state tracker was destroyed with its stack frame,
2508         so it was calling a function on a test object that had gone out of scope.
2509         Also, call WKContextSetUsesNetworkProcess(context, true) to show what crash this fixed,
2510         but that will become the default soon and that call will be removed.
2511
2512 2015-11-22  David Kilzer  <ddkilzer@apple.com>
2513
2514         run-webkit-tests: http server for imported W3C tests doesn't work with --layout-tests-directory switch
2515         <http://webkit.org/b/151542>
2516
2517         Reviewed by Daniel Bates.
2518
2519         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2520         (base_url): Use the Port object (already passed in) to give us
2521         the path to the LayoutTests directory, which already checks for a
2522         --layout-tests-directory command-line switch.
2523         (WebPlatformTestServer.__init__): Remove layout_test_results_dir
2524         argument since we can get this from the Port object already
2525         passed in via Port.results_directory().  Also switch to use
2526         Port.layout_tests_dir() to get the LayoutTests directory.
2527
2528         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
2529         (TestWebPlatformTestServer.test_custom_layout_tests_directory):
2530         Add test case for custom LayoutTests directory.
2531         (TestWebPlatformTestServer.test_previously_spawned_instance):
2532         Update Port object to set mock results directory as if it was
2533         set on the command-line.  Remove unneeded argument from
2534         WebPlatformTestServer constructor.
2535         (TestWebPlatformTestServer.test_corrupted_subserver_files): Ditto.
2536
2537         * Scripts/webkitpy/port/base.py:
2538         (Port.to.start_web_platform_test_server): Remove unneeded
2539         argument from WebPlatformTestServer constuctor.
2540
2541 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2542
2543         [GTK] Some unit tests fail when using the network process
2544         https://bugs.webkit.org/show_bug.cgi?id=151490
2545
2546         Reviewed by Martin Robinson.
2547
2548         Run the soup server in a separate thread in TestResources test to
2549         avoid deadlocks.
2550
2551         This fixes /webkit2/WebKitWebView/sync-request-on-max-conns and
2552         /webkit2/WebKitWebResource/get-data when using the network process.
2553
2554         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2555         (beforeAll): Create the WebKitTestServer with ServerRunInThread flag.
2556         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
2557         (WebKitTestServer::WebKitTestServer): When ServerRunInThread is
2558         present, create a WorkQueue to run the server.
2559         (WebKitTestServer::run): Run the server in the work queue if it
2560         has been created.
2561         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h: Convert server
2562         type into server options as flags.
2563
2564 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2565
2566         [GTK] ImageDiff should normalize the diff image
2567         https://bugs.webkit.org/show_bug.cgi?id=151261
2568
2569         Reviewed by Sergio Villar Senin.
2570
2571         * ImageDiff/gtk/ImageDiff.cpp:
2572         (readPixbufFromStdin): Fix memory leak.
2573         (differenceImageFromDifferenceBuffer): Normalize diff buffer.
2574         (calculateDifference): Pass max distance to differenceImageFromDifferenceBuffer.
2575
2576 == Rolled over to ChangeLog-2015-11-21 ==