[PSON] Introduce a WebContent Process cache
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-14  Chris Dumez  <cdumez@apple.com>
2
3         [PSON] Introduce a WebContent Process cache
4         https://bugs.webkit.org/show_bug.cgi?id=194594
5         <rdar://problem/46793397>
6
7         Reviewed by Geoff Garen.
8
9         Update API tests to turn on the WebContent Process cache.
10
11         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
12
13 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
14
15         Unreviewed, build fix after r241480
16
17         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
18         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
19         (-[DragAndDropSimulator initWithWebView:]):
20
21 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
22
23         AX: ARIA Reflection was disabled in error
24         https://bugs.webkit.org/show_bug.cgi?id=194647
25         <rdar://problem/48068336>
26
27         Reviewed by Ryosuke Niwa.
28
29         Remove test override now that this feature should be enabled by default.
30
31         * WebKitTestRunner/TestController.cpp:
32         (WTR::TestController::resetPreferencesToConsistentValues):
33
34 2019-02-14  Commit Queue  <commit-queue@webkit.org>
35
36         Unreviewed, rolling out r241486.
37         https://bugs.webkit.org/show_bug.cgi?id=194655
38
39         causing API failures in builds (Requested by ShawnRoberts on
40         #webkit).
41
42         Reverted changeset:
43
44         "[Cocoa] Media elements will restart network buffering just
45         before suspending"
46         https://bugs.webkit.org/show_bug.cgi?id=193691
47         https://trac.webkit.org/changeset/241486
48
49 2019-02-14  Zalan Bujtas  <zalan@apple.com>
50
51         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
52         https://bugs.webkit.org/show_bug.cgi?id=194622
53
54         Reviewed by Antti Koivisto.
55
56         * LayoutReloaded/misc/LFC-passing-tests.txt:
57
58 2019-02-14  Zalan Bujtas  <zalan@apple.com>
59
60         [LFC] Shrink-to-fit-width should be constrained by min/max width
61         https://bugs.webkit.org/show_bug.cgi?id=194653
62
63         Reviewed by Antti Koivisto.
64
65         * LayoutReloaded/misc/LFC-passing-tests.txt:
66
67 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
68
69         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
70         https://bugs.webkit.org/show_bug.cgi?id=194641
71
72         Reviewed by Geoffrey Garen.
73
74         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
75         so that the test would fail without this fix.
76
77         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
78         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
79
80 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
81
82         [ews-app] Change log level for a log statement
83
84         Unreviewed minor fix.
85
86         * BuildSlaveSupport/ews-app/ews/models/patch.py:
87         (Patch.save_patch):
88
89 2019-02-13  Jer Noble  <jer.noble@apple.com>
90
91         [Cocoa] Media elements will restart network buffering just before suspending
92         https://bugs.webkit.org/show_bug.cgi?id=193691
93
94         Reviewed by Eric Carlson.
95
96         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
97         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
98         (TEST):
99
100 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
101
102         [ews-app] Fetch builder id to name mapping
103         https://bugs.webkit.org/show_bug.cgi?id=194355
104
105         Reviewed by Lucas Forschler.
106
107         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
108         (Buildbot.get_builder_id_to_name_mapping):
109         (Buildbot._get_display_name_from_builder_name):
110
111 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
112
113         Further restricting webarchive loads
114         https://bugs.webkit.org/show_bug.cgi?id=194567
115         <rdar://problem/47610130>
116
117         Reviewed by Youenn Fablet.
118
119         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
120         navigations on drop.
121
122         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
123         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
124         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
125         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
126         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
127         (TestWebKitAPI::TEST):
128         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
129         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
130         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
131         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
132         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
133         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
134         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
135
136 2019-02-13  John Wilander  <wilander@apple.com>
137
138         Store Ad Click Attribution requests in the network process
139         https://bugs.webkit.org/show_bug.cgi?id=194510
140         <rdar://problem/47650118>
141
142         Reviewed by Alex Christensen and Daniel Bates.
143
144         This patch adds two TestRunner functions:
145         - dumpAdClickAttribution()
146         - clearAdClickAttribution()
147
148         They call into the network process to dump and clear Ad Click
149         Attribution state, respectively.
150
151         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
152         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
153         (WTR::TestRunner::dumpAdClickAttribution):
154         (WTR::TestRunner::clearAdClickAttribution):
155         * WebKitTestRunner/InjectedBundle/TestRunner.h:
156         * WebKitTestRunner/TestController.cpp:
157         (WTR::TestController::resetStateToConsistentValues):
158         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
159         (WTR::adClickAttributionStringResultCallback):
160         (WTR::TestController::dumpAdClickAttribution):
161         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
162         (WTR::adClickAttributionVoidCallback):
163         (WTR::TestController::clearAdClickAttribution):
164         * WebKitTestRunner/TestController.h:
165         * WebKitTestRunner/TestInvocation.cpp:
166         (WTR::TestInvocation::dumpResults):
167         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
168         (WTR::TestInvocation::dumpAdClickAttribution):
169         * WebKitTestRunner/TestInvocation.h:
170
171 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
172
173         [ews-app] Generate status-bubble
174         https://bugs.webkit.org/show_bug.cgi?id=194572
175
176         Reviewed by Lucas Forschler.
177
178         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
179         (StatusBubble._build_bubble):
180         (StatusBubble._should_show_bubble_for):
181         (StatusBubble._build_bubbles_for_patch):
182
183 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
184
185         [ews-app] Add status bubble html template
186         https://bugs.webkit.org/show_bug.cgi?id=194571
187
188         Reviewed by Lucas Forschler.
189
190         * BuildSlaveSupport/ews-app/ews/templates: Added.
191         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
192
193 2019-02-12  Chris Dumez  <cdumez@apple.com>
194
195         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
196         https://bugs.webkit.org/show_bug.cgi?id=194568
197         <rdar://problem/47944490>
198
199         Reviewed by Ryosuke Niwa.
200
201         Add API test coverage.
202
203         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
204         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
205
206 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
207
208         webkitpy: Remove bug_dummy from parsed test expectations
209         https://bugs.webkit.org/show_bug.cgi?id=194562
210         <rdar://problem/47853999>
211
212         Reviewed by Lucas Forschler.
213
214         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
215         (TestExpectationParser):
216         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
217         skipped tests.
218         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
219
220 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
221
222         [ews-app] Add method to fetch patch
223         https://bugs.webkit.org/show_bug.cgi?id=194518
224
225         Reviewed by Lucas Forschler.
226
227         * BuildSlaveSupport/ews-app/ews/models/patch.py:
228         (Patch.get_patch):
229
230 2019-02-12  Zalan Bujtas  <zalan@apple.com>
231
232         [LFC] Expand tests coverage (60 new tests -> 860)
233
234         Unreviewed test gardening (run-singly, --child-processes=1).
235
236         * LayoutReloaded/misc/LFC-passing-tests.txt:
237
238 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
239
240         Allow pages to trigger programmatic paste from script on iOS
241         https://bugs.webkit.org/show_bug.cgi?id=194271
242         <rdar://problem/47808810>
243
244         Reviewed by Tim Horton.
245
246         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
247
248         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
249         (WTR::UIScriptController::platformSetDidShowMenuCallback):
250         (WTR::UIScriptController::platformSetDidHideMenuCallback):
251         (WTR::UIScriptController::rectForMenuAction const):
252
253         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
254         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
255         for when the menu is shown or hidden.
256
257         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
258         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
259         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
260         (WTR::UIScriptController::setDidShowMenuCallback):
261         (WTR::UIScriptController::didShowMenuCallback const):
262         (WTR::UIScriptController::setDidHideMenuCallback):
263         (WTR::UIScriptController::didHideMenuCallback const):
264         (WTR::UIScriptController::platformSetDidShowMenuCallback):
265         (WTR::UIScriptController::platformSetDidHideMenuCallback):
266         (WTR::UIScriptController::rectForMenuAction const):
267         * TestRunnerShared/UIScriptContext/UIScriptController.h:
268         * WebKitTestRunner/TestController.cpp:
269         (WTR::TestController::resetPreferencesToConsistentValues):
270         (WTR::updateTestOptionsFromTestHeader):
271         * WebKitTestRunner/TestOptions.h:
272
273         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
274         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
275
276         (WTR::TestOptions::hasSameInitializationOptions const):
277         * WebKitTestRunner/UIScriptControllerCocoa.mm:
278         (WTR::UIScriptController::calendarType const):
279         (WTR::UIScriptController::platformUndoManager const):
280         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
281         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
282         (-[TestRunnerWKWebView initWithFrame:configuration:]):
283         (-[TestRunnerWKWebView dealloc]):
284         (-[TestRunnerWKWebView _didShowMenu]):
285         (-[TestRunnerWKWebView _didHideMenu]):
286
287         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
288
289         * WebKitTestRunner/ios/TestControllerIOS.mm:
290         (WTR::handleMenuWillHideNotification):
291         (WTR::handleMenuDidHideNotification):
292         (WTR::TestController::platformInitialize):
293         (WTR::TestController::platformDestroy):
294         (WTR::TestController::platformResetStateToConsistentValues):
295
296         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
297         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
298
299         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
300         (WTR::forEachViewInHierarchy):
301         (WTR::findViewInHierarchyOfType):
302
303         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
304         functions that dig through a given view's hierarchy in search of a view of a given class.
305
306         (WTR::UIScriptController::selectionStartGrabberViewRect const):
307         (WTR::UIScriptController::selectionEndGrabberViewRect const):
308         (WTR::UIScriptController::selectionCaretViewRect const):
309         (WTR::UIScriptController::selectionRangeViewRects const):
310         (WTR::UIScriptController::platformSetDidShowMenuCallback):
311         (WTR::UIScriptController::platformSetDidHideMenuCallback):
312
313         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
314
315         (WTR::UIScriptController::rectForMenuAction const):
316
317         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
318         callout bar) whose label matches the given string.
319
320         (WTR::UIScriptController::platformContentView const):
321
322         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
323         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
324         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
325
326         (WTR::UIScriptController::platformUndoManager const): Deleted.
327         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
328         (WTR::UIScriptController::platformContentView const):
329         (WTR::UIScriptController::platformUndoManager const): Deleted.
330
331 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
332
333         webkitpy: No option to only show unexpected failures in results.html for iPad
334         https://bugs.webkit.org/show_bug.cgi?id=194554
335         <rdar://problem/47922442>
336
337         Rubber-stamped by Aakash Jain.
338
339         Just because a TestExpecations file does not exist for a specific platform does not mean that
340         TestExpecations are not being used, given that platforms inherit test expectations.
341
342         * Scripts/webkitpy/port/base.py:
343         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
344         * Scripts/webkitpy/port/base_unittest.py:
345         (PortTest.test_uses_test_expectations_file):
346
347 2019-02-12  Alex Christensen  <achristensen@webkit.org>
348
349         Remove setDefersLoading infrastructure from WebKit2
350         https://bugs.webkit.org/show_bug.cgi?id=194506
351
352         Reviewed by Brady Eidson.
353
354         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
355         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
356         (WTR::TestRunner::setDefersLoading): Deleted.
357         * WebKitTestRunner/InjectedBundle/TestRunner.h:
358
359 2019-02-12  Alex Christensen  <achristensen@webkit.org>
360
361         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
362         https://bugs.webkit.org/show_bug.cgi?id=194522
363         <rdar://problem/47789393>
364
365         Reviewed by Chris Dumez.
366
367         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
368         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
369         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
370         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
371
372 2019-02-12  Andy Estes  <aestes@apple.com>
373
374         [iOSMac] Enable Parental Controls Content Filtering
375         https://bugs.webkit.org/show_bug.cgi?id=194521
376         <rdar://39732376>
377
378         Reviewed by Tim Horton.
379
380         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
381
382 2019-02-12  Zalan Bujtas  <zalan@apple.com>
383
384         [LFC][IFC] Add intrinsic width support for float boxes.
385         https://bugs.webkit.org/show_bug.cgi?id=194528
386
387         Reviewed by Antti Koivisto.
388
389         Expand tests coverage (2 new tests -> 800).
390         (This is the correct test ordering --runs-singly --child-processes=1)
391
392         * LayoutReloaded/misc/LFC-passing-tests.txt:
393
394 2019-02-12  Rob Buis  <rbuis@igalia.com>
395
396         Implement serializing in MIME type parser
397         https://bugs.webkit.org/show_bug.cgi?id=193909
398
399         Reviewed by Darin Adler.
400
401         Add various tests involving upper case, non-ASCII, control/null characters,
402         various HTTP whitespace, single quotes and an unpaired surrogate.
403
404         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
405         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
406         (TestWebKitAPI::serializeIfValid):
407         (TestWebKitAPI::TEST):
408
409 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
410
411         [Cocoa] Ask platform for generic font family mappings
412         https://bugs.webkit.org/show_bug.cgi?id=187723
413         <rdar://problem/41892438>
414
415         Reviewed by Brent Fulgham.
416
417         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
418
419         * DumpRenderTree/mac/DumpRenderTree.mm:
420         (allowedFontFamilySet):
421         * WebKitTestRunner/mac/TestControllerMac.mm:
422         (WTR::allowedFontFamilySet):
423
424 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
425
426         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
427         https://bugs.webkit.org/show_bug.cgi?id=193622
428
429         Reviewed by Michael Catanzaro.
430
431         This adds support for loading content extension rule sets from the JSON files which
432         accompany the corresponding layout test, using the C API. The Cocoa specific parts
433         of WKTR for this could be removed, but that is left for a follow-up patch with
434         cleanups.
435
436         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
437         * WebKitTestRunner/TestController.cpp:
438         (WTR::testPath): Subtract one from the length when constructing the result std::string to
439         avoid having the null-terminator copied into the result.
440         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
441         part of the preparations to run a test.
442         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
443         (WTR::contentExtensionStoreCallback): Added.
444         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
445         used for content extensions test.
446         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
447         extensions and compiling the JSON rule set for tests involving content extensions.
448         (WTR::TestController::resetContentExtensions): Removes the content extension built for
449         testing and disables content extensions.
450         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
451         resetContentExtensions().
452         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
453         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
454         configureContentExtensionForTest(), and userContentController().
455
456 2019-02-11  Daniel Bates  <dabates@apple.com>
457
458         [iOS] Mouse/Touch/Pointer events are missing modifier keys
459         https://bugs.webkit.org/show_bug.cgi?id=191446
460         <rdar://problem/45929460>
461
462         Reviewed by Tim Horton.
463
464         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
465
466         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
467         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
468         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
469         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
470         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
471         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
472         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
473         * TestRunnerShared/UIScriptContext/UIScriptController.h:
474         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
475         (WTR::arrayLength):
476         (WTR::parseModifierArray):
477         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
478         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
479         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
480         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
481
482 2019-02-11  Commit Queue  <commit-queue@webkit.org>
483
484         Unreviewed, rolling out r241272 and r241276.
485         https://bugs.webkit.org/show_bug.cgi?id=194514
486
487         Broke the Apple Internal build and the fix requires human
488         intervention :( (Requested by dydz on #webkit).
489
490         Reverted changesets:
491
492         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
493         https://bugs.webkit.org/show_bug.cgi?id=191446
494         https://trac.webkit.org/changeset/241272
495
496         "Fix internal iOS build after r241272"
497         https://bugs.webkit.org/show_bug.cgi?id=191446
498         https://trac.webkit.org/changeset/241276
499
500 2019-02-11  Truitt Savell  <tsavell@apple.com>
501
502         Unreviewed, rolling out r241269.
503
504         Caused 5 layout tests crashes on Mac WK1
505
506         Reverted changeset:
507
508         "DumpRenderTree should report unknown options"
509         https://bugs.webkit.org/show_bug.cgi?id=191303
510         https://trac.webkit.org/changeset/241269
511
512 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
513
514         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
515         https://bugs.webkit.org/show_bug.cgi?id=194313
516
517         Reviewed by Tim Horton.
518
519         Add a helper to determine whether the web view is presenting modal UI.
520
521         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
522         (WTR::UIScriptController::isPresentingModally const):
523         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
524         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
525         (WTR::UIScriptController::isPresentingModally const):
526         * TestRunnerShared/UIScriptContext/UIScriptController.h:
527         * WebKitTestRunner/UIScriptControllerCocoa.mm:
528         (WTR::UIScriptController::calendarType const): Deleted.
529         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
530         (WTR::UIScriptController::isPresentingModally const):
531         (WTR::UIScriptController::calendarType const):
532         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
533         (WTR::UIScriptController::calendarType const):
534
535 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
536
537         GCHeapInspector: Show the retained sizes in more places
538         https://bugs.webkit.org/show_bug.cgi?id=194464
539
540         Reviewed by Simon Fraser.
541
542         * GCHeapInspector/gc-heap-inspector.html:
543         * GCHeapInspector/script/interface.js:
544         (HeapInspectorUtils.humanReadableSize):
545         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
546         (HeapInspectorUtils.spanForNode.span.span):
547         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
548         (HeapSnapshotInspector.prototype.buildRoots):
549
550 2019-02-11  Daniel Bates  <dabates@apple.com>
551
552         [iOS] Mouse/Touch/Pointer events are missing modifier keys
553         https://bugs.webkit.org/show_bug.cgi?id=191446
554         <rdar://problem/45929460>
555
556         Reviewed by Tim Horton.
557
558         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
559
560         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
561         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
562         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
563         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
564         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
565         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
566         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
567         * TestRunnerShared/UIScriptContext/UIScriptController.h:
568         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
569         (WTR::arrayLength):
570         (WTR::parseModifierArray):
571         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
572         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
573         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
574         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
575
576 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
577
578         DumpRenderTree should report unknown options
579         https://bugs.webkit.org/show_bug.cgi?id=191303
580
581         Reviewed by Frédéric Wang.
582
583         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
584         to report unknown options.
585         Added and assigned test options which are currently used in tests.
586
587         * DumpRenderTree/TestOptions.cpp:
588         (TestOptions::TestOptions):
589
590 2019-02-11  Truitt Savell  <tsavell@apple.com>
591
592         Unreviewed, rolling out r241229.
593
594         Revision broke internal builds for watchOS.
595
596         Reverted changeset:
597
598         "[Cocoa] Ask platform for generic font family mappings"
599         https://bugs.webkit.org/show_bug.cgi?id=187723
600         https://trac.webkit.org/changeset/241229
601
602 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
603
604         [WinCairo][MiniBrowser] Basic authentication always fails.
605         https://bugs.webkit.org/show_bug.cgi?id=194496
606
607         Reviewed by Don Olmstead.
608
609         * MiniBrowser/win/DialogHelper.h:
610         (Dialog::getText):
611
612 2019-02-11  Philippe Normand  <pnormand@igalia.com>
613
614         [GStreamer] GstMappedBuffer testsuite build fails
615         https://bugs.webkit.org/show_bug.cgi?id=194495
616
617         Reviewed by Carlos Garcia Campos.
618
619         Fix the build by explicitely adding the gstreamer1.0-audio include
620         directories to the include path.
621
622         * TestWebKitAPI/PlatformGTK.cmake:
623         * TestWebKitAPI/PlatformWPE.cmake:
624
625 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
626
627         [GTK][WPE] Add enable-javascript-markup setting
628         https://bugs.webkit.org/show_bug.cgi?id=193439
629
630         Reviewed by Michael Catanzaro.
631
632         Add test cases to check the new setting.
633
634         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
635         (testWebKitSettings):
636         (testWebKitSettingsJavaScriptMarkup):
637         (beforeAll):
638
639 2019-02-10  Darin Adler  <darin@apple.com>
640
641         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
642         https://bugs.webkit.org/show_bug.cgi?id=194485
643
644         Reviewed by Daniel Bates.
645
646         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
647
648 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
649
650         Add more tests for clampTo<>()
651         https://bugs.webkit.org/show_bug.cgi?id=194462
652
653         Reviewed by Geoffrey Garen.
654
655         Darin suggested to test the very last floating point number
656         at the boundaries when truncating to integer.
657         I added test for max/min and max-1/min-1.
658
659         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
660         (TestWebKitAPI::TEST):
661
662 2019-02-09  Darin Adler  <darin@apple.com>
663
664         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
665         https://bugs.webkit.org/show_bug.cgi?id=194021
666
667         Reviewed by Geoffrey Garen.
668
669         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
670         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
671         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
672
673 2019-02-09  Zalan Bujtas  <zalan@apple.com>
674
675         [LFC][IFC] Add intrinsic width support for basic inline containers
676         https://bugs.webkit.org/show_bug.cgi?id=194473
677
678         Reviewed by Antti Koivisto.
679
680         Expand tests coverage (11 new tests -> 798)
681
682         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
683
684 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
685
686         Fix MiniBrowser's entitlements
687         https://bugs.webkit.org/show_bug.cgi?id=192431
688
689         Reviewed by Joseph Pecoraro.
690
691         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
692         files, making it impossible to load any extension.
693
694         * MiniBrowser/MiniBrowser.entitlements:
695
696 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
697
698         [Cocoa] Ask platform for generic font family mappings
699         https://bugs.webkit.org/show_bug.cgi?id=187723
700         <rdar://problem/41892438>
701
702         Reviewed by Brent Fulgham.
703
704         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
705
706         * DumpRenderTree/mac/DumpRenderTree.mm:
707         (allowedFontFamilySet):
708         * WebKitTestRunner/mac/TestControllerMac.mm:
709         (WTR::allowedFontFamilySet):
710
711 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
712
713         [GTK] Implement back/forward touchpad gesture
714         https://bugs.webkit.org/show_bug.cgi?id=193919
715
716         Reviewed by Michael Catanzaro.
717
718         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
719         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
720
721 2019-02-08  Alex Christensen  <achristensen@webkit.org>
722
723         Add SPI to use networking daemon instead of XPC service
724         https://bugs.webkit.org/show_bug.cgi?id=194427
725
726         Reviewed by Geoffrey Garen
727
728         * MiniBrowser/MiniBrowser.entitlements:
729
730 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
731
732         [ews-build] Ensure that every builder in config.json has short name
733         https://bugs.webkit.org/show_bug.cgi?id=194461
734
735         Reviewed by Lucas Forschler.
736
737         * BuildSlaveSupport/ews-build/loadConfig.py:
738         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
739
740 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
741
742         [ews-build] Add short name to config.json
743         https://bugs.webkit.org/show_bug.cgi?id=194456
744
745         Reviewed by Lucas Forschler.
746
747         * BuildSlaveSupport/ews-build/config.json: Added short name.
748         * BuildSlaveSupport/ews-build/loadConfig.py:
749         (loadBuilderConfig): Set the short name as the builder description.
750
751 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
752
753         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
754         https://bugs.webkit.org/show_bug.cgi?id=194418
755
756         Reviewed by Lucas Forschler.
757
758         Do not include errors trying when finding crashlogs at the end of
759         a run-webkit-tests run since we don't process those errors.
760
761         * Scripts/webkitpy/port/darwin.py:
762         (DarwinPort._look_for_all_crash_logs_in_log_dir):
763         * Scripts/webkitpy/port/ios_device.py:
764         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
765         * Scripts/webkitpy/port/watch_device.py:
766         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
767
768 2019-02-08  Beth Dakin  <bdakin@apple.com>
769
770         Add afterScreenUpdates to WKSnapshotConfiguration
771         https://bugs.webkit.org/show_bug.cgi?id=194362
772         -and corresponding-
773         <rdar://problem/40655528> Please add an "after screen updates" property to 
774         WKSnapshotConfiguration (to solve blank snapshots)
775
776         Reviewed by Tim Horton.
777
778         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
779         (TEST):
780
781 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
782
783         clampTo(): do not convert the input to double when dealing with integers
784         https://bugs.webkit.org/show_bug.cgi?id=194263
785         <rdar://problem/47692312>
786
787         Reviewed by Darin Adler.
788
789         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
790         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
791         (TestWebKitAPI::testClampFloatingPointToInteger):
792         (TestWebKitAPI::testClampSameSignIntegers):
793         (TestWebKitAPI::testClampUnsignedToSigned):
794         (TestWebKitAPI::testClampSignedToUnsigned):
795
796 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
797
798         webkitpy: Respect --dedicated-simulators flag
799         https://bugs.webkit.org/show_bug.cgi?id=194416
800         <rdar://problem/47894722>
801
802         Reviewed by Lucas Forschler.
803
804         * Scripts/webkitpy/port/device_port.py:
805         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
806         available devices can be safely ignored.
807
808 2019-02-07  Keith Rollin  <krollin@apple.com>
809
810         Remove extra copy of 100x100-red.tga
811         https://bugs.webkit.org/show_bug.cgi?id=194371
812         <rdar://problem/47873465>
813
814         Reviewed by Said Abou-Hallawa.
815
816         In order to help it pass its tests, Bug 194190 added a second copy of
817         the file 100x100-red.tga. However, it turns out that this additional
818         file wasn't actually needed, and that that sole previous copy was
819         sufficient. At the same time, this second copy -- which was copied to
820         the same location in the build output as the first copy -- now caused
821         XCBuild to complain because there were two production rules for the
822         same output file. Address this by removing the newly-added extra copy.
823
824         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
825         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
826
827 2019-02-07  Alex Christensen  <achristensen@webkit.org>
828
829         Deprecate WKBundlePageSetDefersLoading
830         https://bugs.webkit.org/show_bug.cgi?id=191394
831
832         Reviewed by Dean Jackson.
833
834         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
835         (WTR::TestRunner::setDefersLoading):
836
837 2019-02-07  Zalan Bujtas  <zalan@apple.com>
838
839         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
840         https://bugs.webkit.org/show_bug.cgi?id=194391
841
842         Reviewed by Antti Koivisto.
843
844         * LayoutReloaded/misc/LFC-passing-tests.txt:
845
846 2019-02-06  Keith Rollin  <krollin@apple.com>
847
848         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
849         https://bugs.webkit.org/show_bug.cgi?id=193975
850         <rdar://problem/47643306>
851
852         Reviewed by Tim Horton.
853
854         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
855         the Info.plist file into the bundle. This step is not necessary as the
856         implicit "bundle up all the build products into a framework" build
857         phase does this already. Having the Copy Bundle Resources phase do
858         this causes a conflict under XCBuild, which objects to two build
859         phases producing the same file (Info.plist). Address this by removing
860         Info.plist from the Copy Bundle Resources phase.
861
862         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
863
864 2019-02-06  Keith Rollin  <krollin@apple.com>
865
866         Really enable the automatic checking and regenerations of .xcfilelists during builds
867         https://bugs.webkit.org/show_bug.cgi?id=194357
868         <rdar://problem/47861231>
869
870         Reviewed by Chris Dumez.
871
872         Bug 194124 was supposed to enable the automatic checking and
873         regenerating of .xcfilelist files during the build. While related
874         changes were included in that patch, the change to actually enable the
875         operation somehow was omitted. This patch actually enables the
876         operation. The check-xcfilelist.sh scripts now check
877         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
878         from the checking.
879
880         * DumpRenderTree/Scripts/check-xcfilelists.sh:
881         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
882
883 2019-02-06  David Kilzer  <ddkilzer@apple.com>
884
885         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
886         <https://webkit.org/b/194286>
887         <rdar://problem/47815558>
888
889         Reviewed by Alexey Proskuryakov.
890
891         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
892         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
893         WKRetainPtr<> to avoid leaking the WKDataRef.
894
895 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
896
897         Unreviewed, fix a typo
898
899         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
900
901 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
902
903         [GTK][WPE] force libpsl build to use ICU in jhbuild
904         https://bugs.webkit.org/show_bug.cgi?id=194288
905
906         Reviewed by Carlos Garcia Campos.
907
908         * gtk/jhbuild.modules:
909         Require ICU for libpsl build in jhbuild, like done in WPE.
910
911 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
912
913         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
914         https://bugs.webkit.org/show_bug.cgi?id=194209
915
916         Reviewed by Carlos Garcia Campos.
917
918         Enhance TestCookieManager to ensure this doesn't happen again.
919
920         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
921         (testCookieManagerPersistentStorage):
922         (beforeAll):
923
924 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
925
926         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
927         https://bugs.webkit.org/show_bug.cgi?id=194324
928
929         Reviewed by Andy Estes.
930
931         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
932         part of the name is already implicit, since this is in testing code in TestOptions.
933
934         * WebKitTestRunner/TestController.cpp:
935         (WTR::TestController::generateContextConfiguration const):
936         (WTR::updateTestOptionsFromTestHeader):
937         * WebKitTestRunner/TestOptions.h:
938         (WTR::TestOptions::hasSameInitializationOptions const):
939
940 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
941
942         [ews-build] Allow * as platform for builders and workers
943         https://bugs.webkit.org/show_bug.cgi?id=188533
944
945         Reviewed by Lucas Forschler.
946
947         * BuildSlaveSupport/ews-build/loadConfig.py:
948         (checkWorkersAndBuildersForConsistency):
949
950 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
951
952         [ews-build] Add few bots to config.json
953         https://bugs.webkit.org/show_bug.cgi?id=194304
954
955         Reviewed by Lucas Forschler.
956
957         * BuildSlaveSupport/ews-build/config.json:
958
959 2019-02-05  Keith Rollin  <krollin@apple.com>
960
961         Enable the automatic checking and regenerations of .xcfilelists during builds
962         https://bugs.webkit.org/show_bug.cgi?id=194124
963         <rdar://problem/47721277>
964
965         Reviewed by Tim Horton.
966
967         Bug 193790 add a facility for checking -- during build time -- that
968         any needed .xcfilelist files are up-to-date and for updating them if
969         they are not. This facility was initially opt-in by setting
970         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
971         the process seemed robust. Its now time to enable this facility and
972         make it opt-out. If there is a need to disable this facility, set and
973         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
974         running `make` or `build-webkit`, or before running Xcode from the
975         command line.
976
977         Additionally, remove the step that generates a list of source files
978         going into the UnifiedSources build step. It's only necessarily to
979         specify Sources.txt and SourcesCocoa.txt as inputs.
980
981         * Scripts/generate-xcfilelists:
982
983 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
984
985         [GTK][WPE] force libpsl build to use ICU in jhbuild
986         https://bugs.webkit.org/show_bug.cgi?id=194288
987
988         Reviewed by Philippe Normand.
989
990         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
991         This can cause build failures if libidn is detected but libunistring is not available.
992
993         Make sure that ICU is used for runtime and builtin PSL data.
994
995         * gtk/jhbuild.modules:
996         * wpe/jhbuild.modules:
997
998 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
999
1000         [ews-app] Modified timestamp should be updated on updating data
1001         https://bugs.webkit.org/show_bug.cgi?id=194295
1002
1003         Reviewed by Lucas Forschler.
1004
1005         * BuildSlaveSupport/ews-app/ews/models/build.py:
1006         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1007         * BuildSlaveSupport/ews-app/ews/models/step.py:
1008
1009 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
1010
1011         Unreviewed, rolling out r240742.
1012
1013         Causes crashes on iOS simulator.
1014
1015         Reverted changeset:
1016
1017         "[iOS] Keyups for non-modifier keys identified as "Dead" when
1018         not focused in a content-editable element"
1019         https://bugs.webkit.org/show_bug.cgi?id=192824
1020         https://trac.webkit.org/changeset/240742
1021
1022 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
1023
1024         run-webkit-tests emits message "...running None" when running tests
1025         https://bugs.webkit.org/show_bug.cgi?id=194133
1026         <rdar://problem/47724738>
1027
1028         Reviewed by Lucas Forschler.
1029
1030         * Scripts/webkitpy/xcode/device_type.py:
1031         (DeviceType.__str__): Use both version mapping tables and use just the variant
1032         name if no version name is available.
1033         * Scripts/webkitpy/xcode/device_type_unittest.py:
1034         (DeviceTypeTest):
1035         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
1036         an associated named.
1037
1038 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1039
1040         [WPE] require python3-setuptools for meson build in jhbuild
1041         https://bugs.webkit.org/show_bug.cgi?id=194287
1042
1043         Reviewed by Philippe Normand.
1044
1045         python3-setuptools is needed to build meson in jhbuild.
1046         It is already required by the GTK port.
1047
1048         * wpe/install-dependencies:
1049
1050 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1051
1052         [ews-app] Add method to save BuilderMapping to database
1053         https://bugs.webkit.org/show_bug.cgi?id=194264
1054
1055         Reviewed by Lucas Forschler.
1056
1057         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1058         (BuilderMapping.__str__):
1059         (BuilderMapping):
1060         (BuilderMapping.save_mapping):
1061         (BuilderMapping.update_mapping):
1062         (BuilderMapping.get_existing_mapping):
1063         (BuilderMapping.is_valid_mapping):
1064
1065 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1066
1067         [ews-app] Add timestamp fields for BuilderMappings
1068         https://bugs.webkit.org/show_bug.cgi?id=194266
1069
1070         Reviewed by Lucas Forschler.
1071
1072         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1073         (BuilderMapping):
1074
1075 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
1076
1077         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
1078         https://bugs.webkit.org/show_bug.cgi?id=174816
1079
1080         Reviewed by Michael Catanzaro.
1081
1082         Add tests for webkit_uri_for_display().
1083
1084         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
1085         (testURIForDisplayUnaffected):
1086         (testURIForDisplayAffected):
1087         (beforeAll):
1088         (afterAll):
1089         * TestWebKitAPI/glib/CMakeLists.txt:
1090
1091 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
1092
1093         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
1094         https://bugs.webkit.org/show_bug.cgi?id=194158
1095         <rdar://problem/47737268>
1096
1097         Rubber-stamped by Aakash Jain.
1098
1099         * Scripts/webkitpy/port/device_port.py:
1100         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
1101
1102 2019-02-04  Said Abou-Hallawa  <said@apple.com>
1103
1104         [CG] Enable setAdditionalSupportedImageTypes for WK1
1105         https://bugs.webkit.org/show_bug.cgi?id=194190
1106
1107         Reviewed by Tim Horton.
1108
1109         Add a test similar to the one under WebKit Cocoa but make it create a
1110         WebView instead of a WKWebView.
1111
1112         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1113         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
1114         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
1115         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
1116         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
1117         (TestWebKitAPI::runTest):
1118         (TestWebKitAPI::TEST):
1119
1120 2019-02-04  Zalan Bujtas  <zalan@apple.com>
1121
1122         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
1123         https://bugs.webkit.org/show_bug.cgi?id=194168
1124
1125         Reviewed by Simon Fraser.
1126
1127         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
1128
1129         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1130         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
1131         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
1132         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
1133         (TEST):
1134         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
1135         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
1136
1137 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
1138
1139         REGRESSION (r237269): webkit-patch what-broke is broken 
1140         https://bugs.webkit.org/show_bug.cgi?id=193025
1141
1142         Reviewed by Aakash Jain.
1143
1144         * Scripts/webkitpy/common/host.py:
1145         (Host.buildbot):
1146         (Host.bugzilla): Renamed to 'buildbot'.
1147
1148 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1149
1150         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
1151         https://bugs.webkit.org/show_bug.cgi?id=194207
1152
1153         Reviewed by Tim Horton.
1154
1155         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
1156         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
1157         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
1158         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
1159         start and delete forwards to remove the original attachment.
1160
1161         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1162         (TestWebKitAPI::TEST):
1163
1164 2019-02-04  Youenn Fablet  <youenn@apple.com>
1165
1166         Capture state should be managed consistently when doing process swapping
1167         https://bugs.webkit.org/show_bug.cgi?id=194122
1168         <rdar://problem/47609293>
1169
1170         Reviewed by Eric Carlson.
1171
1172         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1173         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1174         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1175         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
1176         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1177         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1178         (WTR::TestRunner::isDoingMediaCapture const):
1179         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1180         * WebKitTestRunner/TestController.cpp:
1181         (WTR::TestController::isDoingMediaCapture const):
1182         * WebKitTestRunner/TestController.h:
1183         * WebKitTestRunner/TestInvocation.cpp:
1184         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1185         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1186         (WTR::TestController::isDoingMediaCapture const):
1187
1188 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1189
1190         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
1191         https://bugs.webkit.org/show_bug.cgi?id=194142
1192
1193         Reviewed by Ross Kirsling.
1194
1195         There three 'separator' variables in TestController.cpp. Renamed
1196         it 'pathSeparator', and unified them.
1197
1198         * WebKitTestRunner/TestController.cpp:
1199         (WTR::TestController::generateContextConfiguration const):
1200         (WTR::createTestURL):
1201         (WTR::TestController::platformAdjustContext):
1202
1203 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
1204
1205         Make setNeedsLayout on the root more explicitly about triggering its side-effects
1206         https://bugs.webkit.org/show_bug.cgi?id=194198
1207
1208         Reviewed by Antti Koivisto.
1209
1210         No need to set the banner heights on navigation now, since Page stores them.
1211
1212         * MiniBrowser/mac/WK2BrowserWindowController.m:
1213         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
1214
1215 2019-02-03  John Wilander  <wilander@apple.com>
1216
1217         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
1218         https://bugs.webkit.org/show_bug.cgi?id=194104
1219         <rdar://problem/47649991>
1220
1221         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
1222
1223         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1224         (TestWebKitAPI::TEST):
1225             Changed numeric types from unsigned short to uint32_t.
1226
1227 2019-02-02  David Kilzer  <ddkilzer@apple.com>
1228
1229         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
1230         <https://webkit.org/b/194178>
1231         <rdar://problem/47753473>
1232
1233         Reviewed by Alexey Proskuryakov.
1234
1235         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1236         (WTR::uninstallFakeHelvetica): Pass nullptr into
1237         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
1238
1239 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1240
1241         [LFC] Initialize ICB's style with fixed width/height.
1242         https://bugs.webkit.org/show_bug.cgi?id=194188
1243
1244         Reviewed by Antti Koivisto.
1245
1246         * LayoutReloaded/misc/LFC-passing-tests.txt:
1247
1248 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1249
1250         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
1251         https://bugs.webkit.org/show_bug.cgi?id=194185
1252
1253         Reviewed by Antti Koivisto.
1254
1255         * LayoutReloaded/misc/LFC-passing-tests.txt:
1256
1257 2018-12-16  Darin Adler  <darin@apple.com>
1258
1259         Convert additional String::format clients to alternative approaches
1260         https://bugs.webkit.org/show_bug.cgi?id=192746
1261
1262         Reviewed by Alexey Proskuryakov.
1263
1264         * WebKitTestRunner/TestController.cpp:
1265         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
1266         as an intermediate in code that ultimately constructs a WTF::String.
1267         (WTR::userMediaOriginHash): Use makeString.
1268         (WTR::TestController::didNavigateWithNavigationData): More of the same.
1269         (WTR::TestController::didPerformClientRedirect): Ditto.
1270         (WTR::TestController::didPerformServerRedirect): Ditto.
1271         (WTR::TestController::didUpdateHistoryTitle): Ditto.
1272
1273 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1274
1275         [ews-build] Add unit test to verify builder keys
1276         https://bugs.webkit.org/show_bug.cgi?id=194152
1277
1278         Reviewed by Lucas Forschler.
1279
1280         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1281         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
1282
1283 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1284
1285         [LFC] Expand tests coverage (12 new tests -> 787)
1286
1287         Unreviewed test gardening.
1288
1289         * LayoutReloaded/misc/LFC-passing-tests.txt:
1290
1291 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1292
1293         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
1294         https://bugs.webkit.org/show_bug.cgi?id=194163
1295
1296         Reviewed by Simon Fraser.
1297
1298         775
1299
1300         * LayoutReloaded/misc/LFC-passing-tests.txt:
1301
1302 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1303
1304         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
1305         https://bugs.webkit.org/show_bug.cgi?id=194140
1306         <rdar://problem/47728098>
1307
1308         Reviewed by Tim Horton.
1309
1310         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1311         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1312         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
1313
1314         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
1315         test to induce an IPC deadlock when presenting a modal alert during touch start.
1316
1317         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1318         * WebKitTestRunner/TestController.cpp:
1319         (WTR::runJavaScriptAlert):
1320
1321         Add a client callback function for running JavaScript alerts.
1322
1323         (WTR::TestController::createOtherPage):
1324         (WTR::TestController::generateContextConfiguration const):
1325
1326         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
1327         the fix in this patch.
1328
1329         (WTR::TestController::createWebViewWithOptions):
1330
1331         Plumb TestOptions to generateContextConfiguration.
1332
1333         (WTR::TestController::resetPreferencesToConsistentValues):
1334         (WTR::TestController::resetStateToConsistentValues):
1335         (WTR::updateTestOptionsFromTestHeader):
1336         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
1337         (WTR::TestController::handleJavaScriptAlert):
1338         * WebKitTestRunner/TestController.h:
1339         * WebKitTestRunner/TestInvocation.cpp:
1340         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1341         * WebKitTestRunner/TestOptions.h:
1342         (WTR::TestOptions::hasSameInitializationOptions const):
1343
1344 2019-02-01  Chris Dumez  <cdumez@apple.com>
1345
1346         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
1347         https://bugs.webkit.org/show_bug.cgi?id=193740
1348         <rdar://problem/47527267>
1349
1350         Reviewed by Alex Christensen.
1351
1352         Add API test coverage.
1353
1354         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1355
1356 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1357
1358         [ews-app] Add display name field to BuilderMapping model
1359         https://bugs.webkit.org/show_bug.cgi?id=194153
1360
1361         Reviewed by Lucas Forschler.
1362
1363         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1364         (BuilderMapping):
1365
1366 2019-02-01  Youenn Fablet  <youenn@apple.com>
1367
1368         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
1369         https://bugs.webkit.org/show_bug.cgi?id=194155
1370
1371         Reviewed by Eric Carlson.
1372
1373         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1374         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
1375         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
1376
1377 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1378
1379         [LFC] Adjust replaced element's intrinsic ratio
1380         https://bugs.webkit.org/show_bug.cgi?id=194154
1381
1382         Reviewed by Antti Koivisto.
1383
1384         761
1385
1386         * LayoutReloaded/misc/LFC-passing-tests.txt:
1387
1388 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1389
1390         [WPE] Show test results in minibrowser
1391         https://bugs.webkit.org/show_bug.cgi?id=194150
1392
1393         Reviewed by Žan Doberšek.
1394
1395         * Scripts/webkitpy/port/wpe.py:
1396         (WPEPort.show_results_html_file):
1397
1398 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1399
1400         [WPE] MiniBrowser: add ky bindings for back/forward navigation
1401         https://bugs.webkit.org/show_bug.cgi?id=194151
1402
1403         Reviewed by Žan Doberšek.
1404
1405         ALT + <- go back
1406         ALT + -> go forward
1407
1408         * MiniBrowser/wpe/main.cpp:
1409         (main):
1410
1411 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1412
1413         [LFC] Set intrinsic size on Layout::Replaced
1414         https://bugs.webkit.org/show_bug.cgi?id=194139
1415
1416         Reviewed by Antti Koivisto.
1417
1418         744
1419
1420         * LayoutReloaded/misc/LFC-passing-tests.txt:
1421
1422 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1423
1424         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
1425         https://bugs.webkit.org/show_bug.cgi?id=194146
1426
1427         Reviewed by Xabier Rodriguez-Calvar.
1428
1429         It allows to open relative paths.
1430
1431         * MiniBrowser/wpe/main.cpp:
1432         (main):
1433
1434 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
1435
1436         Update flakiness dashboard configuration after recent queue changes
1437         https://bugs.webkit.org/show_bug.cgi?id=194127
1438
1439         Rubber-stamped by Aakash Jain.
1440
1441         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
1442
1443         * TestResultServer/static-dashboards/builders.jsonp:
1444
1445 2019-01-31  Youenn Fablet  <youenn@apple.com>
1446
1447         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
1448         https://bugs.webkit.org/show_bug.cgi?id=194106
1449         <rdar://problem/47676333>
1450
1451         Reviewed by Ryosuke Niwa.
1452
1453         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1454         (TestWebKitAPI::didFinishNavigation):
1455         (TestWebKitAPI::TEST):
1456         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1457
1458 2019-01-31  Chris Dumez  <cdumez@apple.com>
1459
1460         Page zoom level is lost after a process swap or a crash
1461         https://bugs.webkit.org/show_bug.cgi?id=194105
1462         <rdar://problem/47610781>
1463
1464         Reviewed by Alex Christensen.
1465
1466         Add API test coverage.
1467
1468         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1469         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
1470
1471 2019-01-31  Alex Christensen  <achristensen@webkit.org>
1472
1473         Revert r238819 which is unneeded and caused a performance regression.
1474         https://bugs.webkit.org/show_bug.cgi?id=192272
1475         <rdar://problem/46664625>
1476
1477         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
1478         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
1479         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
1480
1481 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
1482
1483         Formalize WebKitAdditions mechanism of LoadOptimizer
1484         https://bugs.webkit.org/show_bug.cgi?id=193886
1485         <rdar://problem/47696809>
1486
1487         Reviewed by Brent Fulgham.
1488
1489         * MiniBrowser/MiniBrowser.entitlements:
1490         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
1491
1492 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1493
1494         [LFC] Margin before/after/start/end initial value is 0 and not auto.
1495         https://bugs.webkit.org/show_bug.cgi?id=194090
1496
1497         Reviewed by Antti Koivisto.
1498
1499         * LayoutReloaded/misc/LFC-passing-tests.txt:
1500
1501 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1502
1503         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
1504         https://bugs.webkit.org/show_bug.cgi?id=194074
1505
1506         Reviewed by Antti Koivisto.
1507
1508         * LayoutReloaded/misc/LFC-passing-tests.txt:
1509
1510 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1511
1512         [LFC][BFC] Add support for block level replaced box.
1513         https://bugs.webkit.org/show_bug.cgi?id=194071
1514
1515         Reviewed by Antti Koivisto.
1516
1517         * LayoutReloaded/misc/LFC-passing-tests.txt:
1518
1519 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1520
1521         Fix WebKitTestRunner's testPath with Windows full paths
1522         https://bugs.webkit.org/show_bug.cgi?id=194012
1523
1524         Reviewed by Alex Christensen.
1525
1526         updateTestOptionsFromTestHeader failed to open test files because
1527         testPath returned wrong file paths. It returned a path "/C:/..."
1528         if a URL "file:///C:/..." was given.
1529
1530         * WebKitTestRunner/TestController.cpp:
1531         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
1532
1533 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1534
1535         [WPE] Bump font related dependencies to match the GTK+ port
1536         https://bugs.webkit.org/show_bug.cgi?id=194017
1537
1538         Reviewed by Žan Doberšek.
1539
1540         * wpe/jhbuild.modules:
1541         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1542         * wpe/patches/icudata-stdlibs.patch: Added.
1543
1544 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1545
1546         Enable swipe tests on iOS
1547         https://bugs.webkit.org/show_bug.cgi?id=194076
1548
1549         Reviewed by Geoffrey Garen.
1550
1551         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
1552         it causes a debug assertion failure in runUIScript.
1553
1554         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1555         (WTR::UIScriptController::beginBackSwipe):
1556         (WTR::UIScriptController::completeBackSwipe):
1557
1558 2019-01-30  Keith Rollin  <krollin@apple.com>
1559
1560         Use correct printf format specifier
1561         https://bugs.webkit.org/show_bug.cgi?id=194062
1562         <rdar://problem/47686167>
1563
1564         Reviewed by Alexey Proskuryakov.
1565
1566         LayoutTestSpellChecker.mm is trying to format a variable of type
1567         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
1568         actually an unsigned long long. Fix this by formatting with %llu.
1569
1570         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
1571         (-[LayoutTestTextCheckingResult description]):
1572
1573 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1574
1575         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
1576         https://bugs.webkit.org/show_bug.cgi?id=193979
1577
1578         Reviewed by Wenson Hsieh.
1579
1580         Fix the test for iOS. Make the test work with iOS UA string.
1581
1582         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1583
1584 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
1585
1586         Replace High Sierra LLINT CLoop bot due to hardware failure
1587         https://bugs.webkit.org/show_bug.cgi?id=194066
1588
1589         Reviewed by Aakash Jain.
1590
1591         * BuildSlaveSupport/build.webkit.org-config/config.json:
1592
1593 2019-01-30  Keith Rollin  <krollin@apple.com>
1594
1595         [NSDragItem init] is unavailable
1596         https://bugs.webkit.org/show_bug.cgi?id=194059
1597         <rdar://problem/47685715>
1598
1599         Reviewed by Wenson Hsieh.
1600
1601         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
1602         DumpRenderTree and TestWebKitAPI, which both try to create an
1603         NSDragItem in a manner that invokes this method. Address this by using
1604         -initWithPasteboardWriter instead.
1605
1606         Note that the parameter passed to initWithPasteboardWriter is likely
1607         incorrect. In both cases, the object passed does not conform to
1608         NSPasteboardWriting. However, with this fix, we're no worse off than
1609         before, and can now perform builds with newer compilers and SDKs until
1610         a real fix can be crafted. That work is tracked in
1611         https://bugs.webkit.org/show_bug.cgi?id=194060
1612
1613         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1614         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1615         * TestWebKitAPI/mac/TestDraggingInfo.mm:
1616         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1617
1618 2019-01-30  Daniel Bates  <dabates@apple.com>
1619
1620         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1621         https://bugs.webkit.org/show_bug.cgi?id=192824
1622         <rdar://problem/47100332>
1623
1624         Reviewed by Wenson Hsieh.
1625
1626         Fix a bug where the wrong usage code was used for F13 thru F24.
1627
1628         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1629         (keyCodeForDOMFunctionKey):
1630
1631 2019-01-30  Chris Dumez  <cdumez@apple.com>
1632
1633         Regression(PSON) Load hang can occur on history navigation
1634         https://bugs.webkit.org/show_bug.cgi?id=194030
1635         <rdar://problem/47656939>
1636
1637         Reviewed by Antti Koivisto.
1638
1639         Add API test coverage.
1640
1641         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1642
1643 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1644
1645         [LFC] Expand tests coverage.
1646
1647         Unreviewed test gardening.
1648
1649         * LayoutReloaded/misc/LFC-passing-tests.txt:
1650
1651 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
1652
1653         [Flatpak] Add openjpeg support
1654         https://bugs.webkit.org/show_bug.cgi?id=194019
1655
1656         Reviewed by Michael Catanzaro.
1657
1658         * flatpak/org.webkit.CommonModules.yaml:
1659
1660 2019-01-30  Commit Queue  <commit-queue@webkit.org>
1661
1662         Unreviewed, rolling out r240708.
1663         https://bugs.webkit.org/show_bug.cgi?id=194022
1664
1665         It broke WPE build (Requested by KaL on #webkit).
1666
1667         Reverted changeset:
1668
1669         "[WPE] Bump font related dependencies to match the GTK+ port"
1670         https://bugs.webkit.org/show_bug.cgi?id=194017
1671         https://trac.webkit.org/changeset/240708
1672
1673 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1674
1675         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
1676         https://bugs.webkit.org/show_bug.cgi?id=194001
1677
1678         Reviewed by Antti Koivisto.
1679
1680         * LayoutReloaded/misc/LFC-passing-tests.txt:
1681
1682 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1683
1684         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
1685         https://bugs.webkit.org/show_bug.cgi?id=194020
1686
1687         Reviewed by Antti Koivisto.
1688
1689         * LayoutReloaded/misc/LFC-passing-tests.txt:
1690
1691 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
1692
1693         AX: Support color well on iOS
1694         https://bugs.webkit.org/show_bug.cgi?id=194010
1695
1696         Reviewed by Joanmarie Diggs.
1697
1698         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1699         (WTR::AccessibilityUIElement::stringAttributeValue):
1700
1701 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1702
1703         [WPE] Bump font related dependencies to match the GTK+ port
1704         https://bugs.webkit.org/show_bug.cgi?id=194017
1705
1706         Reviewed by Žan Doberšek.
1707
1708         * wpe/jhbuild.modules:
1709         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1710         * wpe/patches/icudata-stdlibs.patch: Added.
1711
1712 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
1713
1714         [Mac] Update window scale API usage
1715         https://bugs.webkit.org/show_bug.cgi?id=193991
1716         rdar://problem/47614795
1717
1718         Reviewed by Tim Horton.
1719
1720         * DumpRenderTree/mac/DumpRenderTree.mm:
1721         (changeWindowScaleIfNeeded):
1722         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1723         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1724         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1725
1726 2019-01-29  Chris Dumez  <cdumez@apple.com>
1727
1728         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
1729         https://bugs.webkit.org/show_bug.cgi?id=193977
1730         <rdar://problem/47643716>
1731
1732         Reviewed by Geoff Garen.
1733
1734         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
1735         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
1736         to the previous provisional committing *before* we make the last load. 
1737
1738         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1739
1740 2019-01-29  Youenn Fablet  <youenn@apple.com>
1741
1742         Adopt new SPI to evaluate server certificate trust
1743         https://bugs.webkit.org/show_bug.cgi?id=193355
1744
1745         Reviewed by Alex Christensen.
1746
1747         Add infrastructure to handle HTTPS server trust evaluation testing.
1748
1749         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1750         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1751         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
1752         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
1753         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
1754         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1755         * WebKitTestRunner/TestController.cpp:
1756         (WTR::TestController::resetPreferencesToConsistentValues):
1757         (WTR::TestController::didReceiveAuthenticationChallenge):
1758         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1759         * WebKitTestRunner/TestController.h:
1760         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
1761         * WebKitTestRunner/TestInvocation.cpp:
1762         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1763         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1764         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1765
1766 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1767
1768         [ews-build] Add build step to print bot Configuration
1769         https://bugs.webkit.org/show_bug.cgi?id=193887
1770
1771         Reviewed by Lucas Forschler.
1772
1773         * BuildSlaveSupport/ews-build/steps.py:
1774         (PrintConfiguration): Build step to print configuration.
1775         * BuildSlaveSupport/ews-build/factories.py:
1776
1777 2019-01-29  Chris Dumez  <cdumez@apple.com>
1778
1779         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
1780         https://bugs.webkit.org/show_bug.cgi?id=193967
1781         <rdar://problem/47635348>
1782
1783         Reviewed by Alex Christensen.
1784
1785         Add API test coverage.
1786
1787         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1788         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
1789
1790 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1791
1792         [ews-app] Handle incoming results data
1793         https://bugs.webkit.org/show_bug.cgi?id=193973
1794
1795         Reviewed by Lucas Forschler.
1796
1797         * BuildSlaveSupport/ews-app/ews/views/results.py:
1798
1799 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1800
1801         [ews-app] Make the results url generic
1802         https://bugs.webkit.org/show_bug.cgi?id=193928
1803
1804         Reviewed by Lucas Forschler.
1805
1806         * BuildSlaveSupport/ews-app/ews/urls.py:
1807
1808 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1809
1810         [ews-build] Configure buildbot to send events to ews-app
1811         https://bugs.webkit.org/show_bug.cgi?id=193968
1812
1813         Reviewed by Lucas Forschler.
1814
1815         * BuildSlaveSupport/ews-build/events.py: Added.
1816         * BuildSlaveSupport/ews-build/master.cfg:
1817
1818 2019-01-29  Keith Rollin  <krollin@apple.com>
1819
1820         Add .xcfilelists to Run Script build phases
1821         https://bugs.webkit.org/show_bug.cgi?id=193792
1822         <rdar://problem/47201785>
1823
1824         Reviewed by Alex Christensen.
1825
1826         As part of supporting XCBuild, update the necessary Run Script build
1827         phases in their Xcode projects to refer to their associated
1828         .xcfilelist files.
1829
1830         Note that the addition of these files bumps the Xcode project version
1831         number to something that's Xcode 10 compatible. This change means that
1832         older versions of the Xcode IDE can't read these projects. Nor can it
1833         fully load workspaces that refer to these projects (the updated
1834         projects are shown as non-expandable placeholders). `xcodebuild` can
1835         still build these projects; it's just that the IDE can't open them.
1836
1837         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1838         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1839
1840 2019-01-29  John Wilander  <wilander@apple.com>
1841
1842         Add data abstraction and validation for Ad Click Attribution
1843         https://bugs.webkit.org/show_bug.cgi?id=193916
1844         <rdar://problem/47603481>
1845
1846         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
1847
1848         Ad click attribution has two steps. First, the storage of an ad
1849         campaign ID for a click that takes the user to a destination
1850         site. Second, a conversion on the destination site that can be
1851         attributed to the ad click.
1852
1853         This patch adds a class that represents a request for ad click
1854         attribution. Validation makes sure that the bits of entropy
1855         reported through this mechanism is limited.
1856
1857         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1858         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
1859         (TestWebKitAPI::TEST):
1860
1861 2019-01-29  Chris Dumez  <cdumez@apple.com>
1862
1863         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
1864         https://bugs.webkit.org/show_bug.cgi?id=193932
1865         <rdar://problem/47598947>
1866
1867         Reviewed by Brady Eidson.
1868
1869         Add API test coverage.
1870
1871         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1872
1873 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1874
1875         Adding new passing LFC tests.
1876
1877         Unreviewed test gardening.
1878
1879         * LayoutReloaded/misc/LFC-passing-tests.txt:
1880
1881 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1882
1883         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
1884         https://bugs.webkit.org/show_bug.cgi?id=193964
1885
1886         Reviewed by Antti Koivisto.
1887
1888         * LayoutReloaded/misc/LFC-passing-tests.txt:
1889
1890 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1891
1892         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
1893         https://bugs.webkit.org/show_bug.cgi?id=193954
1894
1895         Reviewed by Antti Koivisto.
1896
1897         * LayoutReloaded/misc/LFC-passing-tests.txt:
1898
1899 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1900
1901         WebDriver: add support for running subtests
1902         https://bugs.webkit.org/show_bug.cgi?id=193904
1903
1904         Reviewed by Michael Catanzaro.
1905
1906         pytest already supports it by passing test.py::subtest, so we can do the same.
1907
1908         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1909         (get_item_name): Made this global.
1910         (CollectRecorder.__init__): Receive the parameter to ignore.
1911         (CollectRecorder.pytest_collectreport): Collect also the subtests.
1912         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
1913         (collect): Add parameter to ignore.
1914         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1915         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
1916         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
1917         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
1918         (WebDriverTestRunnerSelenium.run): Ditto.
1919         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1920         (WebDriverTestRunnerW3C.collect_tests): Ditto.
1921         (WebDriverTestRunnerW3C.run): Ditto.
1922
1923 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
1924
1925         User agent string override for navigator.userAgent should be site specific quirks
1926         https://bugs.webkit.org/show_bug.cgi?id=193950
1927
1928         Reviewed by Brent Fulgham.
1929
1930         Updated per the _WKWebsitePolicies rename.
1931
1932         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1933         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1934
1935 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
1936
1937         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
1938         https://bugs.webkit.org/show_bug.cgi?id=193941
1939
1940         Reviewed by Alex Christensen.
1941
1942         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
1943         * TestWebKitAPI/Tests/WTF/Condition.cpp:
1944         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1945         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1946         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1947         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1948         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
1949         * TestWebKitAPI/Tests/WTF/Time.cpp:
1950         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
1951         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
1952         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1953         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1954
1955 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
1956
1957         Unreviewed, reorder my emails to fix autocomplete in bugzilla
1958
1959         * Scripts/webkitpy/common/config/contributors.json:
1960
1961 2019-01-28  Andy Estes  <aestes@apple.com>
1962
1963         [watchOS] Enable Parental Controls content filtering
1964         https://bugs.webkit.org/show_bug.cgi?id=193939
1965         <rdar://problem/46641912>
1966
1967         Reviewed by Ryosuke Niwa.
1968
1969         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1970
1971 2019-01-28  David Kilzer  <ddkilzer@apple.com>
1972
1973         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
1974         <https://webkit.org/b/193884>
1975
1976         Reviewed by Jiewen Tan.
1977
1978         * Scripts/webkitpy/style/checkers/cpp.py:
1979         (check_language): Add LocalAuthentication to
1980         `frameworks_with_soft_links`.
1981
1982 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
1983
1984         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
1985         https://bugs.webkit.org/show_bug.cgi?id=193891
1986
1987         Reviewed by Ross Kirsling.
1988
1989         There were three problems in window sizes of WebView and the host window.
1990         1. The sizes of pixel image output were incorrect.
1991         2. The host window is going to appear after window.resize was invoked.
1992         3. window.resize resized only the host window, not WebView.
1993
1994         This change solves them with a following approach.
1995         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
1996         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
1997            as well as DumpRenderTree in order to match the client area and the window area.
1998         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
1999         d. PlatformWebView::setWindowFrame changes both window sizes.
2000         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
2001
2002         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2003         (WTR::PlatformWebView::PlatformWebView): Create the host window
2004         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
2005         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
2006         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
2007
2008 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2009
2010         [ews-app] Add method to save Step data to database
2011         https://bugs.webkit.org/show_bug.cgi?id=193890
2012
2013         Reviewed by Lucas Forschler.
2014
2015         * BuildSlaveSupport/ews-app/ews/models/step.py:
2016         (Step.save_step): Method to save step data.
2017         (Step.update_step): Method to update step data.
2018         (Step.get_existing_step): Method to fetch existing step from database.
2019         (Step.is_valid_result): Method to validate valid step result.
2020
2021 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2022
2023         [ews-app] Add method to save Build data to database
2024         https://bugs.webkit.org/show_bug.cgi?id=193735
2025
2026         Reviewed by Lucas Forschler.
2027
2028         * BuildSlaveSupport/ews-app/ews/models/build.py:
2029         (Build.save_build): Method to save build information to database.
2030         (Build.get_existing_build): Method to fetch existing build from database.
2031         (Build.is_valid_result): Method to validate build result.
2032         * BuildSlaveSupport/ews-app/ews/common/util.py:
2033         (is_valid_int_id): Method to validate valid id.
2034
2035 2019-01-28  Chris Dumez  <cdumez@apple.com>
2036
2037         Regression(PSON) Crash under WebPageProxy::didStartProgress()
2038         https://bugs.webkit.org/show_bug.cgi?id=193915
2039         <rdar://problem/47560907>
2040
2041         Reviewed by Alex Christensen.
2042
2043         Add API test coverage.
2044
2045         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2046
2047 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2048
2049         [ews-app] Rename id variables
2050         https://bugs.webkit.org/show_bug.cgi?id=193883
2051
2052         Reviewed by Lucas Forschler.
2053
2054         * BuildSlaveSupport/ews-app/ews/models/build.py:
2055         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2056         * BuildSlaveSupport/ews-app/ews/models/step.py:
2057         * BuildSlaveSupport/ews-app/ews/urls.py:
2058         * BuildSlaveSupport/ews-app/ews/views/patch.py:
2059         * BuildSlaveSupport/ews-app/ews/views/results.py:
2060         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2061
2062 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2063
2064         [ews-app] Allow certain fields to be empty
2065         https://bugs.webkit.org/show_bug.cgi?id=193892
2066
2067         Reviewed by Lucas Forschler.
2068
2069         * BuildSlaveSupport/ews-app/ews/models/build.py:
2070         * BuildSlaveSupport/ews-app/ews/models/step.py:
2071
2072 2019-01-28  Rob Buis  <rbuis@igalia.com>
2073
2074         Update MIME type parser
2075         https://bugs.webkit.org/show_bug.cgi?id=180526
2076
2077         Reviewed by Frédéric Wang.
2078
2079         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2080         (TestWebKitAPI::TEST):
2081
2082 2019-01-28  Zalan Bujtas  <zalan@apple.com>
2083
2084         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
2085         https://bugs.webkit.org/show_bug.cgi?id=193896
2086
2087         Reviewed by Antti Koivisto.
2088
2089         * LayoutReloaded/misc/LFC-passing-tests.txt:
2090
2091 2018-12-15  Darin Adler  <darin@apple.com>
2092
2093         Replace many uses of String::format with more type-safe alternatives
2094         https://bugs.webkit.org/show_bug.cgi?id=192742
2095
2096         Reviewed by Mark Lam.
2097
2098         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2099         (WTR::cacheTestRunnerCallback): Use makeString.
2100         * WebKitTestRunner/TestController.cpp:
2101         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
2102         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
2103
2104 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
2105
2106         Use a load optimizer for some sites
2107         https://bugs.webkit.org/show_bug.cgi?id=193881
2108         <rdar://problem/46325455>
2109
2110         Reviewed by Brent Fulgham.
2111
2112         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2113         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
2114
2115 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
2116
2117         AX: Introduce a static accessibility tree
2118         https://bugs.webkit.org/show_bug.cgi?id=193348
2119         <rdar://problem/47203295>
2120
2121         Reviewed by Ryosuke Niwa.
2122
2123         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2124
2125 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2126
2127         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
2128         https://bugs.webkit.org/show_bug.cgi?id=193867
2129
2130         Reviewed by Antti Koivisto.
2131
2132         * LayoutReloaded/misc/LFC-passing-tests.txt:
2133
2134 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2135
2136         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
2137         https://bugs.webkit.org/show_bug.cgi?id=193865
2138
2139         Reviewed by Antti Koivisto.
2140
2141         * LayoutReloaded/misc/LFC-passing-tests.txt:
2142
2143 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2144
2145         Need a mechanism to override navigator.userAgent
2146         https://bugs.webkit.org/show_bug.cgi?id=193762
2147         <rdar://problem/47504939>
2148
2149         Reviewed by Brent Fulgham.
2150
2151         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
2152
2153         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2154         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2155         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
2156
2157 2019-01-25  Dean Jackson  <dino@apple.com>
2158
2159         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
2160         https://bugs.webkit.org/show_bug.cgi?id=193831
2161         <rdar://problem/47399263>
2162
2163         Reviewed by Chris Dumez.
2164
2165         Two new tests that exercise cross-origin and same-origin System
2166         Previews.
2167
2168         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2169
2170 2019-01-25  Keith Rollin  <krollin@apple.com>
2171
2172         Update Xcode projects with "Check .xcfilelists" build phase
2173         https://bugs.webkit.org/show_bug.cgi?id=193790
2174         <rdar://problem/47201374>
2175
2176         Reviewed by Alex Christensen.
2177
2178         Support for XCBuild includes specifying inputs and outputs to various
2179         Run Script build phases. These inputs and outputs are specified as
2180         .xcfilelist files. Once created, these .xcfilelist files need to be
2181         kept up-to-date. In order to check that they are up-to-date or not,
2182         add an Xcode build step that invokes an external script that performs
2183         the checking. If the .xcfilelists are found to be out-of-date, update
2184         them, halt the build, and instruct the developer to restart the build
2185         with up-to-date files.
2186
2187         At this time, the checking and regenerating is performed only if the
2188         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
2189         who want to use this facility can set this variable and test out the
2190         checking/regenerating. Once it seems like there are no egregious
2191         issues that upset a developer's workflow, we'll unconditionally enable
2192         this facility.
2193
2194         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2195         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
2196         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
2197         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2198
2199 2019-01-25  Keith Rollin  <krollin@apple.com>
2200
2201         Update Xcode projects with "Apply Configuration to XCFileLists" build target
2202         https://bugs.webkit.org/show_bug.cgi?id=193781
2203         <rdar://problem/47201153>
2204
2205         Reviewed by Alex Christensen.
2206
2207         Part of generating the .xcfilelists used as part of adopting XCBuild
2208         includes running `make DerivedSources.make` from a standalone script.
2209         It’s important for this invocation to have the same environment as
2210         when the actual build invokes `make DerivedSources.make`. If the
2211         environments are different, then the two invocations will provide
2212         different results. In order to get the same environment in the
2213         standalone script, have the script launch xcodebuild targeting the
2214         "Apply Configuration to XCFileLists" build target, which will then
2215         re-invoke our standalone script. The script is now running again, this
2216         time in an environment with all workspace, project, target, xcconfig
2217         and other environment variables established.
2218
2219         The "Apply Configuration to XCFileLists" build target accomplishes
2220         this task via a small embedded shell script that consists only of:
2221
2222             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
2223
2224         The process that invokes "Apply Configuration to XCFileLists" first
2225         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
2226         evaluated and exports it into the shell environment. When xcodebuild
2227         is invoked, it inherits the value of this variable and can `eval` the
2228         contents of that variable. Our external standalone script can then set
2229         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
2230         of command-line parameters needed to restart itself in the appropriate
2231         state.
2232
2233         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2234         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2235
2236 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2237
2238         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
2239         https://bugs.webkit.org/show_bug.cgi?id=193802
2240         <rdar://problem/46010580>
2241
2242         Reviewed by Andy Estes.
2243
2244         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2245         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
2246         (TEST):
2247
2248 2019-01-25  Daniel Bates  <dabates@apple.com>
2249
2250         [iOS] uiController.keyDown() does not translate Control modified key
2251         https://bugs.webkit.org/show_bug.cgi?id=192898
2252
2253         Reviewed by Wenson Hsieh.
2254
2255         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
2256         key translation, as applicable. Among other cases, key translation occurs when performing
2257         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
2258         also makes the behavior of uiController.keyDown() more closely match the behavior of a
2259         human pressing down and releasing key(s) using a hardware keyboard.
2260
2261         * WebKitTestRunner/ios/HIDEventGenerator.h:
2262         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2263         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
2264
2265         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
2266         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
2267         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2268         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2269         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
2270         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2271         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
2272         (-[HIDEventGenerator longPress:completionBlock:]):
2273         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
2274         Update code for above renaming.
2275
2276         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
2277         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
2278
2279         (-[HIDEventGenerator keyDown:]): Added.
2280         (-[HIDEventGenerator keyUp:]): Added.
2281         (-[HIDEventGenerator keyPress:completionBlock:]):
2282         (-[HIDEventGenerator eventDispatchThreadEntry:]):
2283         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
2284         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2285         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
2286         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
2287         (WTR::parseModifier): Deleted.
2288
2289 2019-01-25  Keith Rollin  <krollin@apple.com>
2290
2291         Complete the implementation of generate-xcfilelists
2292         https://bugs.webkit.org/show_bug.cgi?id=193782
2293
2294         Reviewed by Alex Christensen.
2295
2296         A preliminary version of generate-xcfilelists was added in r238008.
2297         This patch updates that script in order to:
2298
2299         - Support checking of .xcfilelists
2300         - Perform better execution of `make DerivedSources.make` by
2301           relaunching generate-xcfilelists under xcodebuild
2302         - Support incremental generation and checking of .xcfilelists
2303         - Support supplementary .xcfilelists files from WebKitAdditions
2304         - Support being wrapped by parallel version of generate-xcfilelists in
2305           Internal that adds support for (re)generating WebKit projects in
2306           that repo.
2307         - Support builds that have been performed in WebKitBuild as well as
2308           ~/Library/Developer/code/DerivedData
2309         - Increase robustness and debugging facilities.
2310
2311         * Scripts/generate-xcfilelists:
2312
2313 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2314
2315         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2316         https://bugs.webkit.org/show_bug.cgi?id=193297
2317         <rdar://problem/47158841>
2318
2319         Unreviewed test case fix.
2320
2321         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
2322         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
2323
2324         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2325         (TEST):
2326
2327 2019-01-25  Keith Rollin  <krollin@apple.com>
2328
2329         Update existing .xcfilelists
2330         https://bugs.webkit.org/show_bug.cgi?id=193791
2331         <rdar://problem/47201706>
2332
2333         Reviewed by Alex Christensen.
2334
2335         Many .xcfilelist files were added in r238824 in order to support
2336         XCBuild. Update these with recent changes to the set of build files
2337         and with the current generate-xcfilelist script.
2338
2339         * DumpRenderTree/DerivedSources-input.xcfilelist:
2340         * DumpRenderTree/DerivedSources-output.xcfilelist:
2341         * WebKitTestRunner/DerivedSources-input.xcfilelist:
2342         * WebKitTestRunner/DerivedSources-output.xcfilelist:
2343
2344 2019-01-25  Keith Rollin  <krollin@apple.com>
2345
2346         Fix missing dependencies in extract-dependencies-from-makefile
2347         https://bugs.webkit.org/show_bug.cgi?id=193783
2348         <rdar://problem/47201571>
2349
2350         Reviewed by Alex Christensen.
2351
2352         The extract-dependencies-from-makefile script generates .xcfilelists
2353         for XCBuild by invoking a makefile in --debug mode, parsing the
2354         dependency information in the output, and extracting information
2355         regarding targets and dependents. However, the way `make` emits this
2356         dependency information is not rigorous, and so we need to determine
2357         what lines to look for and parse by trial and error. This approach
2358         didn't coriginally atch all the information we needed to collect, so
2359         update the script to look for the additional lines we now know to look
2360         for.
2361
2362         * Scripts/extract-dependencies-from-makefile:
2363         (Parser):
2364         (Parser.addTarget):
2365         (Parser.addPrereq):
2366         (Parser.doParse):
2367
2368 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2369
2370         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2371         https://bugs.webkit.org/show_bug.cgi?id=193297
2372         <rdar://problem/47158841>
2373
2374         Reviewed by Alex Christensen.
2375
2376         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
2377             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
2378         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2379         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2380         activating the message used to trigger the callback when it is set.
2381
2382 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2383
2384         WKWebView.goBack should reload if there is a safe browsing warning
2385         https://bugs.webkit.org/show_bug.cgi?id=193805
2386         <rdar://problem/46908216>
2387
2388         Reviewed by Geoff Garen.
2389
2390         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2391         (+[Simple3LookupContext sharedLookupContext]):
2392         (-[Simple3LookupContext lookUpURL:completionHandler:]):
2393         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
2394         (TEST):
2395
2396 2019-01-25  Chris Dumez  <cdumez@apple.com>
2397
2398         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
2399         https://bugs.webkit.org/show_bug.cgi?id=193788
2400         <rdar://problem/47531231>
2401
2402         Reviewed by Alex Christensen.
2403
2404         Add API test coverage.
2405
2406         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2407         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
2408
2409 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
2410
2411         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
2412         https://bugs.webkit.org/show_bug.cgi?id=193771
2413
2414         Unreviewed infrastructure fix.
2415
2416         * Scripts/webkitpy/port/darwin.py:
2417         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
2418
2419 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2420
2421         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
2422
2423 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2424
2425         Add contributors.json entries for Ling Ho and for a new bot watchers group.
2426
2427         * Scripts/webkitpy/common/config/contributors.json:
2428
2429 2019-01-25  Chris Dumez  <cdumez@apple.com>
2430
2431         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
2432         https://bugs.webkit.org/show_bug.cgi?id=193779
2433         <rdar://problem/46170903>
2434
2435         Reviewed by Antti Koivisto.
2436
2437         Add API test that quickly navigates forward to a previous process without waiting for it to
2438         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
2439         the process' previous page when reconnecting the it for the forward navigation.
2440
2441         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2442
2443 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2444
2445         Need a way for JavaScript (or bundle) code to participate in undo
2446         https://bugs.webkit.org/show_bug.cgi?id=190009
2447         <rdar://problem/44807048>
2448
2449         Reviewed by Ryosuke Niwa.
2450
2451         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
2452         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
2453
2454         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2455         (WTR::UIScriptController::lastUndoLabel const):
2456         (WTR::UIScriptController::firstRedoLabel const):
2457         (WTR::UIScriptController::platformUndoManager const):
2458         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2459         (WTR::UIScriptController::lastUndoLabel const):
2460         (WTR::UIScriptController::firstRedoLabel const):
2461         (WTR::UIScriptController::platformUndoManager const):
2462         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2463         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2464         (WTR::UIScriptController::lastUndoLabel const):
2465         (WTR::UIScriptController::firstRedoLabel const):
2466         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2467         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2468         (WTR::UIScriptController::lastUndoLabel const):
2469         (WTR::UIScriptController::firstRedoLabel const):
2470         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2471         (WTR::UIScriptController::platformUndoManager const):
2472         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2473         (WTR::UIScriptController::platformUndoManager const):
2474
2475 2019-01-25  Zalan Bujtas  <zalan@apple.com>
2476
2477         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
2478         https://bugs.webkit.org/show_bug.cgi?id=193824
2479
2480         Reviewed by Antti Koivisto.
2481
2482         * LayoutReloaded/misc/LFC-passing-tests.txt:
2483
2484 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
2485
2486         Update macOS JSC bot configurations
2487         https://bugs.webkit.org/show_bug.cgi?id=193739
2488
2489         Reviewed by Alexey Proskuryakov.
2490
2491         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
2492         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2493         (BubbleQueueServer): Move JSC EWS to Mojave section.
2494         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2495         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
2496         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
2497
2498 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
2499
2500         [Win][WebKitTestRunner] Implement EventSenderProxy
2501         https://bugs.webkit.org/show_bug.cgi?id=193755
2502
2503         Reviewed by Don Olmstead.
2504
2505         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
2506         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
2507         (WTR::EventSenderProxy::dispatchMessage):
2508         (WTR::EventSenderProxy::EventSenderProxy):
2509         (WTR::EventSenderProxy::mouseDown):
2510         (WTR::EventSenderProxy::mouseUp):
2511         (WTR::EventSenderProxy::mouseMoveTo):
2512         (WTR::EventSenderProxy::mouseScrollBy):
2513         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2514
2515 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2516
2517         Unreviewed fix for API test failure after r240437.
2518
2519         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
2520
2521         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
2522
2523 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2524
2525         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
2526         https://bugs.webkit.org/show_bug.cgi?id=193787
2527         <rdar://problem/47497634>
2528
2529         Reviewed by Alexey Proskuryakov.
2530
2531         * Scripts/webkitdirs.pm:
2532         (iosSimulatorApplicationsPath): Pick from available runtime directories.
2533
2534 2019-01-24  Truitt Savell  <tsavell@apple.com>
2535
2536         Unreviewed, rolling out r240446.
2537
2538         Casued 5 API failures
2539
2540         Reverted changeset:
2541
2542         "Activate the WebResourceLoadStatisticsStore in the
2543         NetworkProcess and deactivate it in the UIProcess."
2544         https://bugs.webkit.org/show_bug.cgi?id=193297
2545         https://trac.webkit.org/changeset/240446
2546
2547 2019-01-24  Zalan Bujtas  <zalan@apple.com>
2548
2549         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
2550         https://bugs.webkit.org/show_bug.cgi?id=193741
2551         <rdar://problem/47135030>
2552
2553         Reviewed by Antti Koivisto and Simon Fraser.
2554
2555         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2556         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2557         (TestWebKitAPI::TEST):
2558
2559 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
2560
2561         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2562         https://bugs.webkit.org/show_bug.cgi?id=193297
2563         <rdar://problem/47158841>
2564
2565         Reviewed by Alex Christensen.
2566
2567         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2568         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2569         activating the message used to trigger the callback when it is set.
2570
2571 2019-01-24  John Wilander  <wilander@apple.com>
2572
2573         Add Ad Click Attribution as an internal/experimental feature
2574         https://bugs.webkit.org/show_bug.cgi?id=193685
2575         <rdar://problem/47450399>
2576
2577         Reviewed by Brent Fulgham.
2578
2579         Added test option adClickAttributionEnabled.
2580
2581         * DumpRenderTree/TestOptions.cpp:
2582         (TestOptions::TestOptions):
2583         * DumpRenderTree/TestOptions.h:
2584         * DumpRenderTree/mac/DumpRenderTree.mm:
2585         (setWebPreferencesForTestOptions):
2586
2587 2019-01-24  Antti Koivisto  <antti@apple.com>
2588
2589         [PSON] Flash on back navigation on Mac
2590         https://bugs.webkit.org/show_bug.cgi?id=193716
2591         <rdar://problem/47148458>
2592
2593         Reviewed by Chris Dumez.
2594
2595         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2596
2597         Closing of the previous page is delayed so waiting for didFinishNavigation is
2598         not sufficient to guarantee we have received all the messages. Wait for them.
2599
2600 2019-01-24  Chris Dumez  <cdumez@apple.com>
2601
2602         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
2603         https://bugs.webkit.org/show_bug.cgi?id=193761
2604         <rdar://problem/47456405>
2605
2606         Reviewed by Alex Christensen.
2607
2608         Add API test coverage.
2609
2610         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2611
2612 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2613
2614         webkitpy: Missing PID in crashlog name should not be fatal
2615         https://bugs.webkit.org/show_bug.cgi?id=193771
2616
2617         If we can't determine the PID of a crashlog, just ignore the crashlog instead
2618         of raising an exception.
2619
2620         Reviewed by Lucas Forschler.
2621
2622         * Scripts/webkitpy/port/darwin.py:
2623         (DarwinPort._merge_crash_logs):
2624
2625 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2626
2627         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
2628         https://bugs.webkit.org/show_bug.cgi?id=193746
2629
2630         Reviewed by Youenn Fablet.
2631
2632         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
2633         so we'd best just not call it.
2634
2635         * Scripts/webkitpy/w3c/test_exporter.py:
2636         (WebPlatformTestExporter.create_branch_with_patch):
2637
2638 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2639
2640         Move FileSystem to WTF
2641         https://bugs.webkit.org/show_bug.cgi?id=193602
2642
2643         Reviewed by Yusuke Suzuki.
2644
2645         * DumpRenderTree/win/DumpRenderTree.cpp:
2646         * TestWebKitAPI/CMakeLists.txt:
2647         * TestWebKitAPI/PlatformGTK.cmake:
2648         * TestWebKitAPI/PlatformJSCOnly.cmake:
2649         * TestWebKitAPI/PlatformPlayStation.cmake:
2650         * TestWebKitAPI/PlatformWPE.cmake:
2651         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2652         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
2653         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
2654         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2655         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
2656         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
2657         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
2658         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2659         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
2660         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2661
2662 2019-01-24  Philippe Normand  <pnormand@igalia.com>
2663
2664         [WPE] Remove hard dependency on subprocess32 for the API tests
2665
2666         Rubber-stamped by Carlos Garcia Campos.
2667
2668         * glib/api_test_runner.py:
2669         (TestRunner._run_test_qt): Lazily import subprocess32 and check
2670         its presence only when running WPEQt tests.
2671
2672 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2673
2674         [GLIB] Expose JavaScriptCore options in GLib public API
2675         https://bugs.webkit.org/show_bug.cgi?id=188742
2676
2677         Reviewed by Michael Catanzaro.
2678
2679         Add a test for the new API.
2680
2681         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2682         (testsJSCOptions):
2683         (main):
2684
2685 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2686
2687         [GTK][WPE] Support JPEG 2000 images
2688         https://bugs.webkit.org/show_bug.cgi?id=186272
2689
2690         Reviewed by Žan Doberšek.
2691
2692         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
2693
2694         * gtk/jhbuild.modules:
2695         * wpe/jhbuild.modules:
2696
2697 2019-01-23  David Kilzer  <ddkilzer@apple.com>
2698
2699         check-webkit-style should warn when using soft-linking macros in a header
2700         <https://webkit.org/b/193750>
2701
2702         Reviewed by Darin Adler.
2703
2704         * Scripts/webkitpy/style/checkers/cpp.py:
2705         (check_language): Add softlink/header check by refactoring the
2706         softlink/framework check.
2707         (CppChecker): Enable softlink/header check by default.
2708         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2709         (CppStyleTest.test_softlink_framework): Rename from
2710         CppStyleTest.test_softlink() and change test framework name in
2711         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
2712         files. Set file_name for macros that only appear in headers.
2713         (CppStyleTest.test_softlink_header): Add tests for using
2714         soft-link macros in headers.
2715
2716 2019-01-23  Chris Dumez  <cdumez@apple.com>
2717
2718         Deprecate API to limit the maximum number of WebProcesses
2719         https://bugs.webkit.org/show_bug.cgi?id=193725
2720         <rdar://problem/47464879>
2721
2722         Reviewed by Geoff Garen.
2723
2724         Update existing API tests to stop using deprecated API.
2725
2726         * MiniBrowser/mac/AppDelegate.m:
2727         (defaultConfiguration):
2728         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2729         (TestWebKitAPI::TEST):
2730         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
2731         (TestWebKitAPI::TEST):
2732         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2733         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
2734         (TEST):
2735         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2736         (TEST):
2737
2738 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2739
2740         [ews-app] Rename ews model buildermappings to buildermapping
2741         https://bugs.webkit.org/show_bug.cgi?id=193729
2742
2743         Reviewed by Lucas Forschler.
2744
2745         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
2746         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
2747         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
2748
2749 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2750
2751         [ews-app] Rename ews model steps to step
2752         https://bugs.webkit.org/show_bug.cgi?id=193697
2753
2754         Reviewed by Lucas Forschler.
2755
2756         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
2757         (Step): Renamed Steps to Step.
2758
2759 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
2760
2761         Clean up IndexedDB files between tests
2762         https://bugs.webkit.org/show_bug.cgi?id=192796
2763         <rdar://problem/46824999>
2764
2765         Reviewed by Geoffrey Garen.
2766
2767         * DumpRenderTree/mac/DumpRenderTree.mm:
2768         (runTest):
2769         * WebKitTestRunner/TestController.cpp:
2770         (WTR::TestController::resetStateToConsistentValues):
2771         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
2772         (WTR::RemoveAllIndexedDatabasesCallback):
2773         (WTR::TestController::ClearIndexedDatabases):
2774         * WebKitTestRunner/TestController.h:
2775         * WebKitTestRunner/TestInvocation.cpp:
2776         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2777
2778 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2779
2780         [ews-app] Rename ews model Builds to Build
2781         https://bugs.webkit.org/show_bug.cgi?id=193695
2782
2783         Reviewed by Lucas Forschler.
2784
2785         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
2786         (Build): Renamed Builds to Build.
2787
2788 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2789
2790         webkitpy: Wait longer when launching WebKitTestRunner
2791         https://bugs.webkit.org/show_bug.cgi?id=193734
2792
2793         Reviewed by Aakash Jain.
2794
2795         * Scripts/webkitpy/port/simulator_process.py:
2796         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
2797
2798 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2799
2800         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
2801         https://bugs.webkit.org/show_bug.cgi?id=193182
2802         <rdar://problem/47452154>
2803
2804         Reviewed by Tim Horton.
2805
2806         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
2807         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
2808         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
2809
2810         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
2811         preventing later tests from recognizing gestures.
2812
2813         * WebKitTestRunner/ios/TestControllerIOS.mm:
2814         (WTR::TestController::platformResetStateToConsistentValues):
2815
2816         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
2817
2818 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2819
2820         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
2821         https://bugs.webkit.org/show_bug.cgi?id=193722
2822         <rdar://problem/47481475>
2823
2824         Reviewed by Lucas Forschler.
2825
2826         iPhone and iPad ports should both use the iOS config.
2827
2828         * Scripts/webkitpy/port/ios_simulator.py:
2829         (IPhoneSimulatorPort.__init__):
2830         (IPadSimulatorPort.__init__):
2831
2832 2019-01-23  Rob Buis  <rbuis@igalia.com>
2833
2834         Update MIME type parser
2835         https://bugs.webkit.org/show_bug.cgi?id=180526
2836
2837         Reviewed by Frédéric Wang.
2838
2839         Add unit tests for both parse modes of ParsedContentType.
2840
2841         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2842         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
2843         (TestWebKitAPI::TEST):
2844
2845 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2846
2847         [ews-app] fetch loop should not stop on network issues
2848         https://bugs.webkit.org/show_bug.cgi?id=193666
2849
2850         Reviewed by Lucas Forschler.
2851
2852         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2853         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
2854
2855 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2856
2857         [iOS] Multiple WKWebViewAutofillTests are flaky failures
2858         https://bugs.webkit.org/show_bug.cgi?id=189165
2859         <rdar://problem/47433765>
2860
2861         Reviewed by Tim Horton.
2862
2863         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
2864         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
2865         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
2866         process in sufficient to ensure that any previous action that blurred the focused element in the web process
2867         would make its way to the UI process by the time the layer tree commit is finished.
2868
2869         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
2870         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
2871         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
2872         will fail because it asks for -_autofillContext too early.
2873
2874         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
2875         is handled in the UI process.
2876
2877         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2878
2879         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
2880         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
2881         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
2882         input session.
2883
2884         (-[AutofillTestView textInputHasAutofillContext]):
2885
2886         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
2887
2888         * TestWebKitAPI/cocoa/TestWKWebView.h:
2889         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2890         (nextInputSessionChangeCount):
2891
2892         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
2893         This includes changing the focused element from one to another.
2894
2895         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
2896         (-[TestWKWebView didStartFormControlInteraction]):
2897         (-[TestWKWebView didEndFormControlInteraction]):
2898         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
2899
2900         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
2901         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
2902         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
2903         that doesn't require an input session to one that doesn't.
2904
2905 2019-01-22  David Kilzer  <ddkilzer@apple.com>
2906
2907         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
2908         <https://webkit.org/b/193676>
2909
2910         Reviewed by Alexey Proskuryakov.
2911
2912         * Scripts/webkitpy/style/checkers/cpp.py:
2913         (check_member_initialization_list):
2914         - Don't report missing whitespace around colon if the colon at
2915           the start of the line is formatted correctly.
2916         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2917         (WebKitStyleTest.test_member_initialization_list):
2918         - Add a test for a missing permutation of existing tests.
2919         - Add a test this false-positive.
2920         - Add blank lines between subtests to make them easier to read.
2921
2922 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2923
2924         [build.webkit.org] Unit-test failure after r237113
2925         https://bugs.webkit.org/show_bug.cgi?id=193669
2926
2927         Reviewed by Michael Catanzaro.
2928
2929         * BuildSlaveSupport/build.webkit.org-config/factories.py:
2930         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
2931         multiple or zero flags.
2932
2933 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
2934
2935         Cache bytecode to disk
2936         https://bugs.webkit.org/show_bug.cgi?id=192782
2937         <rdar://problem/46084932>
2938
2939         Reviewed by Keith Miller.
2940
2941         Add test helper to execute bytecode-cache tests: it executes each test
2942         twice, the first with JSC_diskCachePath set to a temporary directory
2943         and second with JSC_forceDiskCache=true (in addition to the cache path)
2944         to guarantee that only the disk cache is being used and no new
2945         UnlinkedCodeBlocks are being created.
2946
2947         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
2948         * Scripts/run-jsc-stress-tests:
2949
2950 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
2951
2952         [css-logical] Implement flow-relative margin, padding and border shorthands
2953         https://bugs.webkit.org/show_bug.cgi?id=188697
2954
2955         Reviewed by Simon Fraser and Antti Koivisto.
2956
2957         * DumpRenderTree/TestOptions.cpp:
2958         (TestOptions::TestOptions):
2959         * DumpRenderTree/TestOptions.h:
2960         * DumpRenderTree/mac/DumpRenderTree.mm:
2961         (setWebPreferencesForTestOptions):
2962         Allow tests to enable the CSSLogicalEnabled flag in WK1.
2963
2964         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2965         (JSONCSSPropertiesChecker.check_codegen_properties):
2966         Allow CSS property definitions to have a 'runtime-flag' parameter which
2967         disables the property when the specified runtime flag is disabled.
2968
2969 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
2970
2971         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
2972         https://bugs.webkit.org/show_bug.cgi?id=193643
2973
2974         Reviewed by Michael Catanzaro.
2975
2976         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
2977         * wpe/jhbuild.modules: Ditto.
2978
2979 2019-01-21  Zalan Bujtas  <zalan@apple.com>
2980
2981         [LFC][Floats] Take float top position into account when computing containing block height.
2982         https://bugs.webkit.org/show_bug.cgi?id=193655
2983
2984         Reviewed by Antti Koivisto.
2985
2986         * LayoutReloaded/misc/LFC-passing-tests.txt:
2987
2988 2019-01-21  David Kilzer  <ddkilzer@apple.com>
2989
2990         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
2991         <https://webkit.org/b/193645>
2992         <rdar://problem/47421574>
2993
2994         Reviewed by Alex Christensen.
2995
2996         - Now checks for local soft-linking of all frameworks that have
2997           their own *SoftLinking.{cpp,h,mm} files.
2998         - Changes softlink/uikit warning to softlink/framework.
2999
3000         * Scripts/webkitpy/style/checkers/cpp.py:
3001         (check_language):
3002         (CppChecker):
3003         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3004         (CppStyleTest):
3005
3006 2019-01-20  Saam Barati  <sbarati@apple.com>
3007
3008         Rollout r240210: It broke tests on iOS
3009         https://bugs.webkit.org/show_bug.cgi?id=193640
3010
3011         Unreviewed.
3012
3013         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
3014         * Scripts/run-jsc-stress-tests:
3015
3016 2019-01-20  chris fleizach  <cfleizach@apple.com>
3017
3018         AX: Support returning relative frames for accessibility
3019         https://bugs.webkit.org/show_bug.cgi?id=193414
3020         <rdar://problem/47268501>
3021
3022         Reviewed by Zalan Bujtas.
3023
3024         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3025         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3026         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3027         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3028         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3029         (WTR::attributesOfElement):
3030         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3031
3032 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
3033
3034         Unreviewed, add my new email address
3035
3036         * Scripts/webkitpy/common/config/contributors.json:
3037
3038 2019-01-19  Zalan Bujtas  <zalan@apple.com>
3039
3040         [LFC][BFC] <body>'s overflow property value is propagated to viewport
3041         https://bugs.webkit.org/show_bug.cgi?id=193617
3042
3043         Reviewed by Antti Koivisto.
3044
3045         * LayoutReloaded/misc/LFC-passing-tests.txt:
3046
3047 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
3048
3049         Unreviewed, rolling out r240209.
3050
3051         Broke GTK/WPE injected bundle
3052
3053         Reverted changeset:
3054
3055         "AX: Support returning relative frames for accessibility"
3056         https://bugs.webkit.org/show_bug.cgi?id=193414
3057         https://trac.webkit.org/changeset/240209
3058
3059 2019-01-12  Dan Bernstein  <mitz@apple.com>
3060
3061         [Cocoa] Avoid importing directly from subumbrella frameworks
3062         https://bugs.webkit.org/show_bug.cgi?id=186016
3063         <rdar://problem/40591038>
3064
3065         Reviewed by Sam Weinig.
3066
3067         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
3068           LaunchServices header.
3069         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3070           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3071         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
3072           when using SDKs earlier than 10.13.
3073         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
3074           and OTHER_CPLUSPLUSFLAGS.
3075         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3076           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3077         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
3078           LaunchServices header.
3079
3080 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
3081
3082         Cache bytecode to disk
3083         https://bugs.webkit.org/show_bug.cgi?id=192782
3084         <rdar://problem/46084932>
3085
3086         Reviewed by Keith Miller.
3087
3088         Add test helper to execute bytecode-cache tests: it executes each test
3089         twice, the first with JSC_diskCachePath set to a temporary directory
3090         and second with JSC_forceDiskCache=true (in addition to the cache path)
3091         to guarantee that only the disk cache is being used and no new
3092         UnlinkedCodeBlocks are being created.
3093
3094         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
3095         * Scripts/run-jsc-stress-tests:
3096
3097 2019-01-20  chris fleizach  <cfleizach@apple.com>
3098
3099         AX: Support returning relative frames for accessibility
3100         https://bugs.webkit.org/show_bug.cgi?id=193414
3101         <rdar://problem/47268501>
3102
3103         Reviewed by Zalan Bujtas.
3104
3105         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3106         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3107         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3108         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3109         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3110         (WTR::attributesOfElement):
3111         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3112
3113 2019-01-20  Antoine Quint  <graouts@apple.com>
3114
3115         Add a POINTER_EVENTS feature flag
3116         https://bugs.webkit.org/show_bug.cgi?id=193577
3117         <rdar://problem/47408511>
3118
3119         Unreviewed. Also enable Pointer Events for iosmac.
3120
3121         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3122
3123 2019-01-19  Zalan Bujtas  <zalan@apple.com>
3124
3125         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
3126         https://bugs.webkit.org/show_bug.cgi?id=193613
3127
3128         Reviewed by Antti Koivisto.
3129
3130         * LayoutReloaded/misc/LFC-passing-tests.txt:
3131
3132 2019-01-19  Antoine Quint  <graouts@apple.com>
3133
3134         Add a POINTER_EVENTS feature flag
3135         https://bugs.webkit.org/show_bug.cgi?id=193577
3136
3137         Reviewed by Dean Jackson.
3138
3139         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3140
3141 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
3142
3143         Disable the run-jsc-stress-test remote host key check [second round].
3144         https://bugs.webkit.org/show_bug.cgi?id=192988
3145
3146         Reviewed by Dewei Zhu.
3147
3148         * Scripts/run-jsc-stress-tests:
3149
3150 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3151
3152         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
3153         https://bugs.webkit.org/show_bug.cgi?id=193597
3154
3155         Reviewed by Lucas Forschler.
3156
3157         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3158
3159 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3160
3161         [build.webkit.org] api tests failures are incorrectly named as unit test failures
3162         https://bugs.webkit.org/show_bug.cgi?id=193595
3163
3164         Reviewed by Lucas Forschler.
3165
3166         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
3167         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
3168         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
3169
3170 2019-01-18  Chris Dumez  <cdumez@apple.com>
3171
3172         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
3173         https://bugs.webkit.org/show_bug.cgi?id=193588
3174         <rdar://problem/47131566>
3175
3176         Reviewed by Alex Christensen.
3177
3178         Add layout test coverage.
3179
3180         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3181
3182 2019-01-18  Jer Noble  <jer.noble@apple.com>
3183
3184         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3185         https://bugs.webkit.org/show_bug.cgi?id=189553
3186
3187         Reviewed by Tim Horton.
3188
3189         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3190
3191         * ContentExtensionTester/Configurations/Base.xcconfig:
3192         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3193         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3194         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3195         * ImageDiff/cg/Configurations/Base.xcconfig:
3196         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3197         * MiniBrowser/Configurations/Base.xcconfig:
3198         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3199         * MobileMiniBrowser/Configurations/Base.xcconfig:
3200         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3201         * Scripts/webkitpy/style/checker.py:
3202         (_all_categories):
3203         (FileType):
3204         (CheckerDispatcher._file_type):
3205         (CheckerDispatcher._create_checker):
3206         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3207         (SDKVariantChecker):
3208         (SDKVariantChecker.__init__):
3209         (SDKVariantChecker.check):
3210         * TestWebKitAPI/Configurations/Base.xcconfig:
3211         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3212         * WebEditingTester/Configurations/Base.xcconfig:
3213         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3214         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3215         * WebKitTestRunner/Configurations/Base.xcconfig:
3216         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3217         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3218         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3219
3220 2019-01-18  David Kilzer  <ddkilzer@apple.com>
3221
3222         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
3223         <https://webkit.org/b/193568>
3224         <rdar://problem/47381130>
3225
3226         Reviewed by Alex Christensen.
3227
3228         Make sure no one re-introduces UIKit soft-linking by adding a
3229         style rule.
3230
3231         * Scripts/webkitpy/style/checkers/cpp.py:
3232         (check_language): Add softlink/uikit check.
3233         (CppChecker): Enable softlink/uikit check.
3234         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3235         (CppStyleTest): Add test for softlink/uikit.
3236
3237 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
3238
3239         [GTK] install-dependencies tool looks for libunistring-dev for dnf
3240         https://bugs.webkit.org/show_bug.cgi?id=193584
3241
3242         Change "-dev" to "-devel".
3243
3244         Reviewed by Michael Catanzaro.
3245
3246         * gtk/install-dependencies:
3247
3248 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3249
3250         webkitpy: Add iPhone and iPad ports
3251         https://bugs.webkit.org/show_bug.cgi?id=193537
3252         <rdar://problem/47353390>
3253
3254         Reviewed by Lucas Forschler.
3255
3256         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
3257         ports. Note that this separation is optional, the --ios-simulator command remains.
3258
3259         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3260         (RunTest.test_device_type_test_division): Drive-by fix.
3261         (RunTest.test_device_type_specific_listing): Ditto.
3262         (RunTest.test_ipad_test_division):
3263         (RunTest):
3264         (RunTest.test_ipad_listing):
3265         * Scripts/webkitpy/port/factory.py:
3266         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
3267         (PortFactory):
3268         * Scripts/webkitpy/port/ios_simulator.py:
3269         (IPhoneSimulatorPort):
3270         (IPadSimulatorPort):
3271
3272 2019-01-18  Chris Dumez  <cdumez@apple.com>
3273
3274         Regression(PSON) Scroll position is not always restored properly when navigating back
3275         https://bugs.webkit.org/show_bug.cgi?id=193578
3276         <rdar://problem/47386331>
3277
3278         Reviewed by Tim Horton.
3279
3280         Add API test coverage.
3281
3282         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3283
3284 2019-01-18  Youenn Fablet  <youenn@apple.com>
3285
3286         Add a new SPI to request for cache storage quota increase
3287         https://bugs.webkit.org/show_bug.cgi?id=193323
3288
3289         Reviewed by Alex Christensen.
3290
3291         Implement WebsiteDataStore quota delegate to handle quota requests.
3292         By default, do not update quota.
3293         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
3294
3295         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3296         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3297         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
3298         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3299         * WebKitTestRunner/TestController.cpp:
3300         (WTR::TestController::allowCacheStorageQuotaIncrease):
3301         * WebKitTestRunner/TestController.h:
3302         * WebKitTestRunner/TestInvocation.cpp:
3303         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3304         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3305         (-[CacheStorageQuotaManager init]):
3306         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3307         (WTR::initializeWebViewConfiguration):
3308         (WTR::TestController::cocoaResetStateToConsistentValues):
3309         (WTR::TestController::allowCacheStorageQuotaIncrease):
3310
3311 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3312
3313         [ews-build] Pass owner to the triggered builds
3314         https://bugs.webkit.org/show_bug.cgi?id=193574
3315
3316         Reviewed by Lucas Forschler.
3317
3318         * BuildSlaveSupport/ews-build/factories.py:
3319         (BuildFactory.propertiesToPassToTriggers):
3320
3321 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3322
3323         [ews-app] Send patch author as a build property
3324         https://bugs.webkit.org/show_bug.cgi?id=193560
3325
3326         Reviewed by Lucas Forschler.
3327
3328         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3329         (BugzillaPatchFetcher.fetch):
3330
3331 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3332
3333         webkitpy: Implement device type specific expected results (Follow-up fix)
3334         https://bugs.webkit.org/show_bug.cgi?id=192162
3335         <rdar://problem/46345449>
3336
3337         Unreviewed infrastructure fix.
3338
3339         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3340         (Manager.run): Don't boot a device if no tests are available to run on it.
3341
3342 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3343
3344         webkitpy: Implement device type specific expected results (Follow-up fix)
3345         https://bugs.webkit.org/show_bug.cgi?id=192162
3346         <rdar://problem/46345449>
3347
3348         Unreviewed infrastructure fix.
3349
3350         * Scripts/webkitpy/api_tests/manager.py:
3351         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
3352
3353 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3354
3355         webkitpy: Implement device type specific expected results (Part 2)
3356         https://bugs.webkit.org/show_bug.cgi?id=192162
3357         <rdar://problem/46345449>
3358
3359         Rubber-stamped by Aakash Jain.
3360
3361         This change uses device_type to select a different set of TestExpectation files based on the type of device running
3362         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
3363         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
3364
3365         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
3366         (LayoutTestFinder.find_tests): Pass device_type through.
3367         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
3368         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
3369         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3370         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
3371         (Manager._collect_tests): Pass device type to test finder.
3372         (Manager._needs_web_platform_test):
3373         (Manager._prepare_lists): Index _expectations by device type.
3374         (Manager._test_input_for_file):
3375         (Manager._test_is_slow): Ditto.
3376         (Manager._test_should_dump_jsconsolelog_in_stderr):
3377         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
3378         (Manager._get_test_inputs):
3379         (Manager._update_worker_count):
3380         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
3381         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
3382         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
3383         the one which runs the test.
3384         (Manager._run_test_subset):
3385         (Manager._run_tests): Index _expectations by current_device_type.
3386         (Manager._print_expectation_line_for_test): Ditto.
3387         (Manager._print_expectations_for_subset): Ditto.
3388         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
3389         Unlike run, this function will behave the same regardless of what devices are available.
3390         (Manager._custom_device_for_test): Deleted.
3391         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3392         (ManagerTest.test_uses_custom_device): Deleted.
3393         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
3394         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3395         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
3396         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
3397         all of the expectations.
3398         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
3399         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
3400         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3401         (TestExpectations.__init__): Allow device_type to be passed through.
3402         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
3403         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
3404         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3405         (summarize_results):
3406         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
3407         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
3408         a test ran with, one must check all expectations to find the first non-skip expectation.
3409         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3410         (RunTest.test_device_type_test_division):
3411         (RunTest):
3412         (RunTest.test_device_type_specific_listing):
3413         * Scripts/webkitpy/port/base.py:
3414         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
3415         (Port.supported_device_types): The result of this function will change based on what devices are available.
3416         * Scripts/webkitpy/port/device_port.py:
3417         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
3418         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
3419         can be used.
3420         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
3421         any, or the DEFAULT_DEVICE_TYPES of the port.
3422         * Scripts/webkitpy/port/ios.py:
3423         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
3424         * Scripts/webkitpy/port/ios_simulator.py:
3425         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
3426         * Scripts/webkitpy/port/watch.py:
3427         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
3428         * Scripts/webkitpy/port/watch_simulator.py:
3429         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
3430         * Scripts/webkitpy/xcode/device_type.py:
3431         (DeviceType):
3432         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
3433
3434 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3435
3436         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
3437         https://bugs.webkit.org/show_bug.cgi?id=193575
3438
3439         Reviewed by Michael Catanzaro.
3440
3441         Allow the script to run without explicit port argument because
3442         it's specific to the WPE port anyway.
3443
3444         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
3445         and simplify the rest of the code accordingly.
3446
3447 2019-01-18  Charlie Turner  <cturner@igalia.com>
3448
3449         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
3450         https://bugs.webkit.org/show_bug.cgi?id=192229
3451
3452         Reviewed by Xabier Rodriguez-Calvar.
3453
3454         * MiniBrowser/wpe/main.cpp:
3455         (main): Enable encrypted-media by default.
3456
3457 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3458
3459         [Flatpak] Missing KeyboardInterrupt exception handler
3460         https://bugs.webkit.org/show_bug.cgi?id=193570
3461
3462         Reviewed by Michael Catanzaro.
3463
3464         * flatpak/flatpakutils.py:
3465         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
3466
3467 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3468
3469         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
3470         https://bugs.webkit.org/show_bug.cgi?id=193564
3471
3472         Reviewed by Antti Koivisto.
3473
3474         * LayoutReloaded/misc/LFC-passing-tests.txt:
3475
3476 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3477
3478         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
3479         https://bugs.webkit.org/show_bug.cgi?id=193562
3480
3481         Reviewed by Antti Koivisto.
3482
3483         * LayoutReloaded/misc/LFC-passing-tests.txt:
3484
3485 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3486
3487         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
3488         https://bugs.webkit.org/show_bug.cgi?id=193555
3489
3490         Reviewed by Antti Koivisto.
3491
3492         * LayoutReloaded/misc/LFC-passing-tests.txt:
3493
3494 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3495
3496         [WPE] Add Qt extension
3497         https://bugs.webkit.org/show_bug.cgi?id=191464
3498
3499         Reviewed by Carlos Garcia Campos.
3500
3501         MiniBrowser and API tests for the WPE Qt API. To run the
3502         MiniBrowser a new script is introduced. Example invocation:
3503
3504         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
3505
3506         Also note-worthy is the introduction of the python2-subprocess32
3507         dependency to run the GLib API tests.
3508
3509         * MiniBrowser/wpe/CMakeLists.txt:
3510         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
3511         * MiniBrowser/wpe/qt/main.cpp: Added.
3512         (main):
3513         * MiniBrowser/wpe/qt/main.qml: Added.
3514         * MiniBrowser/wpe/qt/qml.qrc: Added.
3515         * Scripts/run-gtk-tests:
3516         (GtkTestRunner.is_google_test):
3517         (GtkTestRunner):
3518         (GtkTestRunner.is_qt_test):
3519         * Scripts/run-qt-wpe-minibrowser: Added.
3520         * Scripts/run-wpe-tests:
3521         (WPETestRunner):
3522         (WPETestRunner.is_google_test):
3523         (WPETestRunner.is_qt_test):
3524         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
3525         (TestLoad::main):
3526         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
3527         (TestLoadHtml::main):
3528         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
3529         (TestLoadRequest::main):
3530         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
3531         (TestRunJavaScript::main):
3532         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
3533         (waitForSignal):
3534         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
3535         (LoadSpy::LoadSpy):
3536         (LoadSpy::~LoadSpy):
3537         (LoadSpy::onLoadingChanged):
3538         (LoadStartedCatcher::LoadStartedCatcher):
3539         (LoadStartedCatcher::~LoadStartedCatcher):
3540         (LoadStartedCatcher::onLoadingChanged):
3541         (waitForLoadSucceeded):
3542         (waitForLoadFailed):
3543         * TestWebKitAPI/glib/CMakeLists.txt:
3544         * flatpak/flatpakutils.py:
3545         (WebkitFlatpak.load_from_args):
3546         (WebkitFlatpak.__init__):
3547         (WebkitFlatpak.clean_args):
3548         (WebkitFlatpak.run_in_sandbox):
3549         * flatpak/org.webkit.CommonModules.yaml:
3550         * flatpak/org.webkit.WPE.yaml:
3551         * flatpak/org.webkit.WPEModules.yaml:
3552         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
3553         * flatpak/org.webkit.WebKit.yaml:
3554         * glib/api_test_runner.py:
3555         (TestRunner._run_test_qt):
3556         (TestRunner.is_qt_test):
3557         (TestRunner._run_test):
3558
3559 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3560
3561         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
3562         https://bugs.webkit.org/show_bug.cgi?id=193494
3563         <rdar://problem/46859627>
3564
3565         Reviewed by Simon Fraser and Tim Horton.
3566
3567         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
3568         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
3569
3570         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3571         (WTR::UIScriptController::contentOffsetX const):
3572         (WTR::UIScriptController::contentOffsetY const):
3573         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3574         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3575         (WTR::UIScriptController::contentOffsetX const):
3576         (WTR::UIScriptController::contentOffsetY const):
3577         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3578
3579         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
3580
3581         * WebKitTestRunner/TestController.cpp:
3582         (WTR::updateTestOptionsFromTestHeader):
3583         * WebKitTestRunner/TestOptions.h:
3584         (WTR::TestOptions::hasSameInitializationOptions const):
3585         * WebKitTestRunner/ios/TestControllerIOS.mm:
3586         (WTR::TestController::platformResetStateToConsistentValues):
3587         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3588         (WTR::UIScriptController::contentOffsetX const):
3589         (WTR::UIScriptController::contentOffsetY const):
3590
3591 2019-01-17  Truitt Savell  <tsavell@apple.com>
3592
3593         Unreviewed, rolling out r240124.
3594
3595         This commit broke an internal build.
3596
3597         Reverted changeset:
3598
3599         "SDK_VARIANT build destinations should be separate from non-
3600         SDK_VARIANT builds"
3601         https://bugs.webkit.org/show_bug.cgi?id=189553
3602         https://trac.webkit.org/changeset/240124
3603
3604 2019-01-17  Alex Christensen  <achristensen@webkit.org>
3605
3606         Fix string concatenation API test after r239920
3607         https://bugs.webkit.org/show_bug.cgi?id=193551
3608         <rdar://problem/47359304>
3609
3610         Reviewed by Youenn Fablet.
3611
3612         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
3613         (TestWebKitAPI::TEST):
3614         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
3615         in WebKit's build configuration like it apparently is on Linux.
3616
3617 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3618
3619         [ews-build] validate-patch should handle the case when bug_id is None
3620         https://bugs.webkit.org/show_bug.cgi?id=193547
3621
3622         Reviewed by Lucas Forschler.
3623
3624         * BuildSlaveSupport/ews-build/steps.py:
3625         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
3626         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
3627
3628 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3629
3630         [ews-build] Add patch author information in build
3631         https://bugs.webkit.org/show_bug.cgi?id=193465
3632
3633         Reviewed by Lucas Forschler.
3634
3635         * BuildSlaveSupport/ews-build/steps.py:
3636         (ValidatePatch._is_patch_obsolete):
3637
3638 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3639
3640         [ews-build] Pass bug_id to the triggered builds
3641         https://bugs.webkit.org/show_bug.cgi?id=193548
3642
3643         Reviewed by Lucas Forschler.
3644
3645         * BuildSlaveSupport/ews-build/factories.py:
3646         (BuildFactory.propertiesToPassToTriggers):
3647
3648 2019-01-17  Jer Noble  <jer.noble@apple.com>
3649
3650         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3651         https://bugs.webkit.org/show_bug.cgi?id=189553
3652
3653         Reviewed by Tim Horton.
3654
3655         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3656
3657         * ContentExtensionTester/Configurations/Base.xcconfig:
3658         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3659         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3660         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3661         * ImageDiff/cg/Configurations/Base.xcconfig:
3662         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3663         * MiniBrowser/Configurations/Base.xcconfig:
3664         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3665         * MobileMiniBrowser/Configurations/Base.xcconfig:
3666         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3667         * Scripts/webkitpy/style/checker.py:
3668         (_all_categories):
3669         (FileType):
3670         (CheckerDispatcher._file_type):
3671         (CheckerDispatcher._create_checker):
3672         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3673         (SDKVariantChecker):
3674         (SDKVariantChecker.__init__):
3675         (SDKVariantChecker.check):
3676         * TestWebKitAPI/Configurations/Base.xcconfig:
3677         *&nbs