d9179aaa2326264c26eed6343c15dc54ff85853a
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-17  David Kilzer  <ddkilzer@apple.com>
2
3         Unreviewed, rolling out r241620.
4
5         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
6         (Requested by ddkilzer on #webkit.)
7
8         Reverted changeset:
9
10         "[WTF] Add environment variable helpers"
11         https://bugs.webkit.org/show_bug.cgi?id=192405
12         https://trac.webkit.org/changeset/241620
13
14 2019-02-16  Zalan Bujtas  <zalan@apple.com>
15
16         [LFC] RenderImage's default intrinsic size is 0.
17         https://bugs.webkit.org/show_bug.cgi?id=194745
18
19         Reviewed by Antti Koivisto.
20
21         * LayoutReloaded/misc/LFC-passing-tests.txt:
22
23 2019-02-16  Zalan Bujtas  <zalan@apple.com>
24
25         [LFC][BFC] Add support for block replaced intrinsic width.
26         https://bugs.webkit.org/show_bug.cgi?id=194705
27
28         Reviewed by Simon Fraser.
29
30         * LayoutReloaded/misc/LFC-passing-tests.txt:
31
32 2019-02-16  Zalan Bujtas  <zalan@apple.com>
33
34         [LFC] Apply min/max width constraints to preferred width computation
35         https://bugs.webkit.org/show_bug.cgi?id=194739
36
37         Reviewed by Simon Fraser.
38
39         * LayoutReloaded/misc/LFC-passing-tests.txt:
40
41 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
42
43         [WTF] Add environment variable helpers
44         https://bugs.webkit.org/show_bug.cgi?id=192405
45
46         Reviewed by Michael Catanzaro.
47
48         * DumpRenderTree/mac/DumpRenderTree.mm:
49         (libraryPathForDumpRenderTree):
50         * DumpRenderTree/win/DumpRenderTree.cpp:
51         (libraryPathForDumpRenderTree):
52         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
53         (setUpIOSLayoutTestCommunication):
54         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
55         (beforeAll):
56         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
57         (main):
58         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
59         (WebKitTestBus::run):
60         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
61         (WTR::getOutputDir):
62         (WTR::initializeFontConfigSetting):
63         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
64         (WTR::InjectedBundle::platformInitialize):
65         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
66         (WTR::topLevelPath):
67         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
68         (WTR::topLevelPath):
69         (WTR::getOutputDir):
70         (WTR::activateFonts):
71         * WebKitTestRunner/TestController.cpp:
72         (WTR::TestController::libraryPathForTesting):
73         (WTR::TestController::generateContextConfiguration const):
74         (WTR::TestController::generatePageConfiguration):
75         (WTR::TestController::decideDestinationWithSuggestedFilename):
76         (WTR::TestController::platformAdjustContext):
77         * WebKitTestRunner/TestController.h:
78         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
79         (WTR::TestController::cocoaPlatformInitialize):
80         (WTR::TestController::platformAdjustContext):
81         * WebKitTestRunner/gtk/main.cpp:
82         (main):
83         * WebKitTestRunner/mac/TestControllerMac.mm:
84         (WTR::TestController::configureContentExtensionForTest):
85         * WebKitTestRunner/wpe/main.cpp:
86         (main):
87         Utilize WTF::Environment where possible.
88
89 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
90
91         [iOS] WKWebView callout bar is missing Change Writing Direction item
92         https://bugs.webkit.org/show_bug.cgi?id=190015
93         <rdar://problem/44810366>
94
95         Reviewed by Tim Horton.
96
97         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
98         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
99
100         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
101         (TestWebKitAPI::TEST):
102
103 2019-02-15  Chris Dumez  <cdumez@apple.com>
104
105         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
106         https://bugs.webkit.org/show_bug.cgi?id=194717
107         <rdar://problem/47884404>
108
109         Reviewed by Brady Eidson.
110
111         Add API test coverage.
112
113         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
114
115 2019-02-15  Youenn Fablet  <youenn@apple.com>
116
117         Make navigator.mediaDevices SecureContext
118         https://bugs.webkit.org/show_bug.cgi?id=194666
119
120         Reviewed by Eric Carlson.
121
122         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
123         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
124         (TEST_F):
125
126 2019-02-15  Brian Burg  <bburg@apple.com>
127
128         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
129         https://bugs.webkit.org/show_bug.cgi?id=194411
130         <rdar://problem/47787614>
131
132         Reviewed by Joseph Pecoraro.
133
134         Remove unnecessary soft linking macro usage.
135
136         * DumpRenderTree/mac/TestRunnerMac.mm:
137         (TestRunner::inspectorTestStubURL):
138         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
139         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
140         (WTR::TestRunner::inspectorTestStubURL):
141
142 2019-02-15  Commit Queue  <commit-queue@webkit.org>
143
144         Unreviewed, rolling out r241559 and r241566.
145         https://bugs.webkit.org/show_bug.cgi?id=194710
146
147         Causes layout test crashes under GuardMalloc (Requested by
148         ryanhaddad on #webkit).
149
150         Reverted changesets:
151
152         "[WTF] Add environment variable helpers"
153         https://bugs.webkit.org/show_bug.cgi?id=192405
154         https://trac.webkit.org/changeset/241559
155
156         "Unreviewed build fix for WinCairo Debug after r241559."
157         https://trac.webkit.org/changeset/241566
158
159 2019-02-15  Zalan Bujtas  <zalan@apple.com>
160
161         [LFC] Out-of-flow box is never a float box
162         https://bugs.webkit.org/show_bug.cgi?id=194704
163
164         Reviewed by Antti Koivisto.
165
166         * LayoutReloaded/misc/LFC-passing-tests.txt:
167
168 2019-02-10  Darin Adler  <darin@apple.com>
169
170         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
171         https://bugs.webkit.org/show_bug.cgi?id=194487
172
173         Reviewed by Daniel Bates.
174
175         * DumpRenderTree/win/DumpRenderTree.cpp:
176         (applicationId): Use makeString instead of String::format.
177         (main): Ditto.
178         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
179         (TestWebKitAPI::Util::createURLForResource): Ditto.
180         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
181         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
182
183         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
184         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
185         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
186         (WTR::createStringWithAttributes): Use appendLiteral.
187         (WTR::AccessibilityUIElement::helpText const): Ditto.
188         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
189         directly instead of using String::format.
190         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
191         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
192
193 2019-02-15  Truitt Savell  <tsavell@apple.com>
194
195         Unreviewed, rolling out r241564.
196
197         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
198
199         Reverted changeset:
200
201         "[Mac] WebInspectorUI.framework does not need to be soft-
202         linked anymore"
203         https://bugs.webkit.org/show_bug.cgi?id=194411
204         https://trac.webkit.org/changeset/241564
205
206 2019-02-15  Saam barati  <sbarati@apple.com>
207
208         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
209         https://bugs.webkit.org/show_bug.cgi?id=194036
210
211         Reviewed by Yusuke Suzuki.
212
213         * Scripts/run-jsc-stress-tests:
214
215 2019-02-14  Tim Horton  <timothy_horton@apple.com>
216
217         Fix the build.
218
219         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
220         (WTR::UIScriptController::drawSquareInEditableImage):
221         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
222         (TestWebKitAPI::drawSquareInEditableImage):
223
224 2019-02-14  Tim Horton  <timothy_horton@apple.com>
225
226         Fix the build.
227
228         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
229         (WTR::UIScriptController::drawSquareInEditableImage):
230         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
231         (TestWebKitAPI::drawSquareInEditableImage):
232
233 2019-02-14  Brian Burg  <bburg@apple.com>
234
235         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
236         https://bugs.webkit.org/show_bug.cgi?id=194411
237         <rdar://problem/47787614>
238
239         Reviewed by Joseph Pecoraro.
240
241         Remove unnecessary soft linking macro usage.
242
243         * DumpRenderTree/mac/TestRunnerMac.mm:
244         (TestRunner::inspectorTestStubURL):
245         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
246         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
247         (WTR::TestRunner::inspectorTestStubURL):
248
249 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
250
251         [ews-app] status bubble should fetch builder name info from BuilderMapping table
252         https://bugs.webkit.org/show_bug.cgi?id=194599
253
254         Reviewed by Lucas Forschler.
255
256         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
257         (StatusBubble._build_bubble):
258
259 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
260
261         [ews-app] Set Foreign Key in Django build model
262         https://bugs.webkit.org/show_bug.cgi?id=194667
263
264         Reviewed by Lucas Forschler.
265
266         * BuildSlaveSupport/ews-app/ews/models/build.py:
267         (Build):
268
269 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
270
271         [WTF] Add environment variable helpers
272         https://bugs.webkit.org/show_bug.cgi?id=192405
273
274         Reviewed by Michael Catanzaro.
275
276         * DumpRenderTree/mac/DumpRenderTree.mm:
277         (libraryPathForDumpRenderTree):
278         * DumpRenderTree/win/DumpRenderTree.cpp:
279         (libraryPathForDumpRenderTree):
280         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
281         (setUpIOSLayoutTestCommunication):
282         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
283         (TestWebKitAPI::strip):
284         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
285         (beforeAll):
286         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
287         (main):
288         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
289         (WebKitTestBus::run):
290         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
291         (WTR::getOutputDir):
292         (WTR::initializeFontConfigSetting):
293         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
294         (WTR::InjectedBundle::platformInitialize):
295         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
296         (WTR::topLevelPath):
297         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
298         (WTR::topLevelPath):
299         (WTR::getOutputDir):
300         (WTR::activateFonts):
301         * WebKitTestRunner/TestController.cpp:
302         (WTR::TestController::libraryPathForTesting):
303         (WTR::TestController::generateContextConfiguration const):
304         (WTR::TestController::generatePageConfiguration):
305         (WTR::TestController::decideDestinationWithSuggestedFilename):
306         (WTR::TestController::platformAdjustContext):
307         * WebKitTestRunner/TestController.h:
308         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
309         (WTR::TestController::cocoaPlatformInitialize):
310         (WTR::TestController::platformAdjustContext):
311         * WebKitTestRunner/gtk/main.cpp:
312         (main):
313         * WebKitTestRunner/mac/TestControllerMac.mm:
314         (WTR::TestController::configureContentExtensionForTest):
315         * WebKitTestRunner/wpe/main.cpp:
316         (main):
317         Utilize WTF::Environment where possible.
318
319 2019-02-14  Chris Dumez  <cdumez@apple.com>
320
321         [PSON] Introduce a WebContent Process cache
322         https://bugs.webkit.org/show_bug.cgi?id=194594
323         <rdar://problem/46793397>
324
325         Reviewed by Geoff Garen.
326
327         Update API tests to turn on the WebContent Process cache.
328
329         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
330
331 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
332
333         Unreviewed, build fix after r241480
334
335         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
336         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
337         (-[DragAndDropSimulator initWithWebView:]):
338
339 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
340
341         AX: ARIA Reflection was disabled in error
342         https://bugs.webkit.org/show_bug.cgi?id=194647
343         <rdar://problem/48068336>
344
345         Reviewed by Ryosuke Niwa.
346
347         Remove test override now that this feature should be enabled by default.
348
349         * WebKitTestRunner/TestController.cpp:
350         (WTR::TestController::resetPreferencesToConsistentValues):
351
352 2019-02-14  Commit Queue  <commit-queue@webkit.org>
353
354         Unreviewed, rolling out r241486.
355         https://bugs.webkit.org/show_bug.cgi?id=194655
356
357         causing API failures in builds (Requested by ShawnRoberts on
358         #webkit).
359
360         Reverted changeset:
361
362         "[Cocoa] Media elements will restart network buffering just
363         before suspending"
364         https://bugs.webkit.org/show_bug.cgi?id=193691
365         https://trac.webkit.org/changeset/241486
366
367 2019-02-14  Zalan Bujtas  <zalan@apple.com>
368
369         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
370         https://bugs.webkit.org/show_bug.cgi?id=194622
371
372         Reviewed by Antti Koivisto.
373
374         * LayoutReloaded/misc/LFC-passing-tests.txt:
375
376 2019-02-14  Zalan Bujtas  <zalan@apple.com>
377
378         [LFC] Shrink-to-fit-width should be constrained by min/max width
379         https://bugs.webkit.org/show_bug.cgi?id=194653
380
381         Reviewed by Antti Koivisto.
382
383         * LayoutReloaded/misc/LFC-passing-tests.txt:
384
385 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
386
387         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
388         https://bugs.webkit.org/show_bug.cgi?id=194641
389
390         Reviewed by Geoffrey Garen.
391
392         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
393         so that the test would fail without this fix.
394
395         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
396         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
397
398 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
399
400         [ews-app] Change log level for a log statement
401
402         Unreviewed minor fix.
403
404         * BuildSlaveSupport/ews-app/ews/models/patch.py:
405         (Patch.save_patch):
406
407 2019-02-13  Jer Noble  <jer.noble@apple.com>
408
409         [Cocoa] Media elements will restart network buffering just before suspending
410         https://bugs.webkit.org/show_bug.cgi?id=193691
411
412         Reviewed by Eric Carlson.
413
414         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
415         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
416         (TEST):
417
418 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
419
420         [ews-app] Fetch builder id to name mapping
421         https://bugs.webkit.org/show_bug.cgi?id=194355
422
423         Reviewed by Lucas Forschler.
424
425         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
426         (Buildbot.get_builder_id_to_name_mapping):
427         (Buildbot._get_display_name_from_builder_name):
428
429 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
430
431         Further restricting webarchive loads
432         https://bugs.webkit.org/show_bug.cgi?id=194567
433         <rdar://problem/47610130>
434
435         Reviewed by Youenn Fablet.
436
437         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
438         navigations on drop.
439
440         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
441         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
442         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
443         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
444         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
445         (TestWebKitAPI::TEST):
446         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
447         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
448         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
449         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
450         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
451         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
452         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
453
454 2019-02-13  John Wilander  <wilander@apple.com>
455
456         Store Ad Click Attribution requests in the network process
457         https://bugs.webkit.org/show_bug.cgi?id=194510
458         <rdar://problem/47650118>
459
460         Reviewed by Alex Christensen and Daniel Bates.
461
462         This patch adds two TestRunner functions:
463         - dumpAdClickAttribution()
464         - clearAdClickAttribution()
465
466         They call into the network process to dump and clear Ad Click
467         Attribution state, respectively.
468
469         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
470         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
471         (WTR::TestRunner::dumpAdClickAttribution):
472         (WTR::TestRunner::clearAdClickAttribution):
473         * WebKitTestRunner/InjectedBundle/TestRunner.h:
474         * WebKitTestRunner/TestController.cpp:
475         (WTR::TestController::resetStateToConsistentValues):
476         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
477         (WTR::adClickAttributionStringResultCallback):
478         (WTR::TestController::dumpAdClickAttribution):
479         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
480         (WTR::adClickAttributionVoidCallback):
481         (WTR::TestController::clearAdClickAttribution):
482         * WebKitTestRunner/TestController.h:
483         * WebKitTestRunner/TestInvocation.cpp:
484         (WTR::TestInvocation::dumpResults):
485         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
486         (WTR::TestInvocation::dumpAdClickAttribution):
487         * WebKitTestRunner/TestInvocation.h:
488
489 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
490
491         [ews-app] Generate status-bubble
492         https://bugs.webkit.org/show_bug.cgi?id=194572
493
494         Reviewed by Lucas Forschler.
495
496         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
497         (StatusBubble._build_bubble):
498         (StatusBubble._should_show_bubble_for):
499         (StatusBubble._build_bubbles_for_patch):
500
501 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
502
503         [ews-app] Add status bubble html template
504         https://bugs.webkit.org/show_bug.cgi?id=194571
505
506         Reviewed by Lucas Forschler.
507
508         * BuildSlaveSupport/ews-app/ews/templates: Added.
509         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
510
511 2019-02-12  Chris Dumez  <cdumez@apple.com>
512
513         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
514         https://bugs.webkit.org/show_bug.cgi?id=194568
515         <rdar://problem/47944490>
516
517         Reviewed by Ryosuke Niwa.
518
519         Add API test coverage.
520
521         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
522         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
523
524 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
525
526         webkitpy: Remove bug_dummy from parsed test expectations
527         https://bugs.webkit.org/show_bug.cgi?id=194562
528         <rdar://problem/47853999>
529
530         Reviewed by Lucas Forschler.
531
532         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
533         (TestExpectationParser):
534         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
535         skipped tests.
536         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
537
538 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
539
540         [ews-app] Add method to fetch patch
541         https://bugs.webkit.org/show_bug.cgi?id=194518
542
543         Reviewed by Lucas Forschler.
544
545         * BuildSlaveSupport/ews-app/ews/models/patch.py:
546         (Patch.get_patch):
547
548 2019-02-12  Zalan Bujtas  <zalan@apple.com>
549
550         [LFC] Expand tests coverage (60 new tests -> 860)
551
552         Unreviewed test gardening (run-singly, --child-processes=1).
553
554         * LayoutReloaded/misc/LFC-passing-tests.txt:
555
556 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
557
558         Allow pages to trigger programmatic paste from script on iOS
559         https://bugs.webkit.org/show_bug.cgi?id=194271
560         <rdar://problem/47808810>
561
562         Reviewed by Tim Horton.
563
564         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
565
566         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
567         (WTR::UIScriptController::platformSetDidShowMenuCallback):
568         (WTR::UIScriptController::platformSetDidHideMenuCallback):
569         (WTR::UIScriptController::rectForMenuAction const):
570
571         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
572         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
573         for when the menu is shown or hidden.
574
575         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
576         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
577         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
578         (WTR::UIScriptController::setDidShowMenuCallback):
579         (WTR::UIScriptController::didShowMenuCallback const):
580         (WTR::UIScriptController::setDidHideMenuCallback):
581         (WTR::UIScriptController::didHideMenuCallback const):
582         (WTR::UIScriptController::platformSetDidShowMenuCallback):
583         (WTR::UIScriptController::platformSetDidHideMenuCallback):
584         (WTR::UIScriptController::rectForMenuAction const):
585         * TestRunnerShared/UIScriptContext/UIScriptController.h:
586         * WebKitTestRunner/TestController.cpp:
587         (WTR::TestController::resetPreferencesToConsistentValues):
588         (WTR::updateTestOptionsFromTestHeader):
589         * WebKitTestRunner/TestOptions.h:
590
591         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
592         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
593
594         (WTR::TestOptions::hasSameInitializationOptions const):
595         * WebKitTestRunner/UIScriptControllerCocoa.mm:
596         (WTR::UIScriptController::calendarType const):
597         (WTR::UIScriptController::platformUndoManager const):
598         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
599         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
600         (-[TestRunnerWKWebView initWithFrame:configuration:]):
601         (-[TestRunnerWKWebView dealloc]):
602         (-[TestRunnerWKWebView _didShowMenu]):
603         (-[TestRunnerWKWebView _didHideMenu]):
604
605         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
606
607         * WebKitTestRunner/ios/TestControllerIOS.mm:
608         (WTR::handleMenuWillHideNotification):
609         (WTR::handleMenuDidHideNotification):
610         (WTR::TestController::platformInitialize):
611         (WTR::TestController::platformDestroy):
612         (WTR::TestController::platformResetStateToConsistentValues):
613
614         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
615         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
616
617         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
618         (WTR::forEachViewInHierarchy):
619         (WTR::findViewInHierarchyOfType):
620
621         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
622         functions that dig through a given view's hierarchy in search of a view of a given class.
623
624         (WTR::UIScriptController::selectionStartGrabberViewRect const):
625         (WTR::UIScriptController::selectionEndGrabberViewRect const):
626         (WTR::UIScriptController::selectionCaretViewRect const):
627         (WTR::UIScriptController::selectionRangeViewRects const):
628         (WTR::UIScriptController::platformSetDidShowMenuCallback):
629         (WTR::UIScriptController::platformSetDidHideMenuCallback):
630
631         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
632
633         (WTR::UIScriptController::rectForMenuAction const):
634
635         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
636         callout bar) whose label matches the given string.
637
638         (WTR::UIScriptController::platformContentView const):
639
640         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
641         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
642         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
643
644         (WTR::UIScriptController::platformUndoManager const): Deleted.
645         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
646         (WTR::UIScriptController::platformContentView const):
647         (WTR::UIScriptController::platformUndoManager const): Deleted.
648
649 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
650
651         webkitpy: No option to only show unexpected failures in results.html for iPad
652         https://bugs.webkit.org/show_bug.cgi?id=194554
653         <rdar://problem/47922442>
654
655         Rubber-stamped by Aakash Jain.
656
657         Just because a TestExpecations file does not exist for a specific platform does not mean that
658         TestExpecations are not being used, given that platforms inherit test expectations.
659
660         * Scripts/webkitpy/port/base.py:
661         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
662         * Scripts/webkitpy/port/base_unittest.py:
663         (PortTest.test_uses_test_expectations_file):
664
665 2019-02-12  Alex Christensen  <achristensen@webkit.org>
666
667         Remove setDefersLoading infrastructure from WebKit2
668         https://bugs.webkit.org/show_bug.cgi?id=194506
669
670         Reviewed by Brady Eidson.
671
672         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
673         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
674         (WTR::TestRunner::setDefersLoading): Deleted.
675         * WebKitTestRunner/InjectedBundle/TestRunner.h:
676
677 2019-02-12  Alex Christensen  <achristensen@webkit.org>
678
679         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
680         https://bugs.webkit.org/show_bug.cgi?id=194522
681         <rdar://problem/47789393>
682
683         Reviewed by Chris Dumez.
684
685         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
686         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
687         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
688         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
689
690 2019-02-12  Andy Estes  <aestes@apple.com>
691
692         [iOSMac] Enable Parental Controls Content Filtering
693         https://bugs.webkit.org/show_bug.cgi?id=194521
694         <rdar://39732376>
695
696         Reviewed by Tim Horton.
697
698         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
699
700 2019-02-12  Zalan Bujtas  <zalan@apple.com>
701
702         [LFC][IFC] Add intrinsic width support for float boxes.
703         https://bugs.webkit.org/show_bug.cgi?id=194528
704
705         Reviewed by Antti Koivisto.
706
707         Expand tests coverage (2 new tests -> 800).
708         (This is the correct test ordering --runs-singly --child-processes=1)
709
710         * LayoutReloaded/misc/LFC-passing-tests.txt:
711
712 2019-02-12  Rob Buis  <rbuis@igalia.com>
713
714         Implement serializing in MIME type parser
715         https://bugs.webkit.org/show_bug.cgi?id=193909
716
717         Reviewed by Darin Adler.
718
719         Add various tests involving upper case, non-ASCII, control/null characters,
720         various HTTP whitespace, single quotes and an unpaired surrogate.
721
722         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
723         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
724         (TestWebKitAPI::serializeIfValid):
725         (TestWebKitAPI::TEST):
726
727 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
728
729         [Cocoa] Ask platform for generic font family mappings
730         https://bugs.webkit.org/show_bug.cgi?id=187723
731         <rdar://problem/41892438>
732
733         Reviewed by Brent Fulgham.
734
735         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
736
737         * DumpRenderTree/mac/DumpRenderTree.mm:
738         (allowedFontFamilySet):
739         * WebKitTestRunner/mac/TestControllerMac.mm:
740         (WTR::allowedFontFamilySet):
741
742 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
743
744         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
745         https://bugs.webkit.org/show_bug.cgi?id=193622
746
747         Reviewed by Michael Catanzaro.
748
749         This adds support for loading content extension rule sets from the JSON files which
750         accompany the corresponding layout test, using the C API. The Cocoa specific parts
751         of WKTR for this could be removed, but that is left for a follow-up patch with
752         cleanups.
753
754         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
755         * WebKitTestRunner/TestController.cpp:
756         (WTR::testPath): Subtract one from the length when constructing the result std::string to
757         avoid having the null-terminator copied into the result.
758         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
759         part of the preparations to run a test.
760         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
761         (WTR::contentExtensionStoreCallback): Added.
762         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
763         used for content extensions test.
764         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
765         extensions and compiling the JSON rule set for tests involving content extensions.
766         (WTR::TestController::resetContentExtensions): Removes the content extension built for
767         testing and disables content extensions.
768         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
769         resetContentExtensions().
770         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
771         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
772         configureContentExtensionForTest(), and userContentController().
773
774 2019-02-11  Daniel Bates  <dabates@apple.com>
775
776         [iOS] Mouse/Touch/Pointer events are missing modifier keys
777         https://bugs.webkit.org/show_bug.cgi?id=191446
778         <rdar://problem/45929460>
779
780         Reviewed by Tim Horton.
781
782         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
783
784         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
785         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
786         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
787         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
788         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
789         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
790         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
791         * TestRunnerShared/UIScriptContext/UIScriptController.h:
792         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
793         (WTR::arrayLength):
794         (WTR::parseModifierArray):
795         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
796         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
797         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
798         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
799
800 2019-02-11  Commit Queue  <commit-queue@webkit.org>
801
802         Unreviewed, rolling out r241272 and r241276.
803         https://bugs.webkit.org/show_bug.cgi?id=194514
804
805         Broke the Apple Internal build and the fix requires human
806         intervention :( (Requested by dydz on #webkit).
807
808         Reverted changesets:
809
810         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
811         https://bugs.webkit.org/show_bug.cgi?id=191446
812         https://trac.webkit.org/changeset/241272
813
814         "Fix internal iOS build after r241272"
815         https://bugs.webkit.org/show_bug.cgi?id=191446
816         https://trac.webkit.org/changeset/241276
817
818 2019-02-11  Truitt Savell  <tsavell@apple.com>
819
820         Unreviewed, rolling out r241269.
821
822         Caused 5 layout tests crashes on Mac WK1
823
824         Reverted changeset:
825
826         "DumpRenderTree should report unknown options"
827         https://bugs.webkit.org/show_bug.cgi?id=191303
828         https://trac.webkit.org/changeset/241269
829
830 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
831
832         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
833         https://bugs.webkit.org/show_bug.cgi?id=194313
834
835         Reviewed by Tim Horton.
836
837         Add a helper to determine whether the web view is presenting modal UI.
838
839         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
840         (WTR::UIScriptController::isPresentingModally const):
841         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
842         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
843         (WTR::UIScriptController::isPresentingModally const):
844         * TestRunnerShared/UIScriptContext/UIScriptController.h:
845         * WebKitTestRunner/UIScriptControllerCocoa.mm:
846         (WTR::UIScriptController::calendarType const): Deleted.
847         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
848         (WTR::UIScriptController::isPresentingModally const):
849         (WTR::UIScriptController::calendarType const):
850         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
851         (WTR::UIScriptController::calendarType const):
852
853 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
854
855         GCHeapInspector: Show the retained sizes in more places
856         https://bugs.webkit.org/show_bug.cgi?id=194464
857
858         Reviewed by Simon Fraser.
859
860         * GCHeapInspector/gc-heap-inspector.html:
861         * GCHeapInspector/script/interface.js:
862         (HeapInspectorUtils.humanReadableSize):
863         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
864         (HeapInspectorUtils.spanForNode.span.span):
865         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
866         (HeapSnapshotInspector.prototype.buildRoots):
867
868 2019-02-11  Daniel Bates  <dabates@apple.com>
869
870         [iOS] Mouse/Touch/Pointer events are missing modifier keys
871         https://bugs.webkit.org/show_bug.cgi?id=191446
872         <rdar://problem/45929460>
873
874         Reviewed by Tim Horton.
875
876         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
877
878         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
879         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
880         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
881         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
882         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
883         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
884         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
885         * TestRunnerShared/UIScriptContext/UIScriptController.h:
886         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
887         (WTR::arrayLength):
888         (WTR::parseModifierArray):
889         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
890         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
891         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
892         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
893
894 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
895
896         DumpRenderTree should report unknown options
897         https://bugs.webkit.org/show_bug.cgi?id=191303
898
899         Reviewed by Frédéric Wang.
900
901         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
902         to report unknown options.
903         Added and assigned test options which are currently used in tests.
904
905         * DumpRenderTree/TestOptions.cpp:
906         (TestOptions::TestOptions):
907
908 2019-02-11  Truitt Savell  <tsavell@apple.com>
909
910         Unreviewed, rolling out r241229.
911
912         Revision broke internal builds for watchOS.
913
914         Reverted changeset:
915
916         "[Cocoa] Ask platform for generic font family mappings"
917         https://bugs.webkit.org/show_bug.cgi?id=187723
918         https://trac.webkit.org/changeset/241229
919
920 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
921
922         [WinCairo][MiniBrowser] Basic authentication always fails.
923         https://bugs.webkit.org/show_bug.cgi?id=194496
924
925         Reviewed by Don Olmstead.
926
927         * MiniBrowser/win/DialogHelper.h:
928         (Dialog::getText):
929
930 2019-02-11  Philippe Normand  <pnormand@igalia.com>
931
932         [GStreamer] GstMappedBuffer testsuite build fails
933         https://bugs.webkit.org/show_bug.cgi?id=194495
934
935         Reviewed by Carlos Garcia Campos.
936
937         Fix the build by explicitely adding the gstreamer1.0-audio include
938         directories to the include path.
939
940         * TestWebKitAPI/PlatformGTK.cmake:
941         * TestWebKitAPI/PlatformWPE.cmake:
942
943 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
944
945         [GTK][WPE] Add enable-javascript-markup setting
946         https://bugs.webkit.org/show_bug.cgi?id=193439
947
948         Reviewed by Michael Catanzaro.
949
950         Add test cases to check the new setting.
951
952         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
953         (testWebKitSettings):
954         (testWebKitSettingsJavaScriptMarkup):
955         (beforeAll):
956
957 2019-02-10  Darin Adler  <darin@apple.com>
958
959         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
960         https://bugs.webkit.org/show_bug.cgi?id=194485
961
962         Reviewed by Daniel Bates.
963
964         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
965
966 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
967
968         Add more tests for clampTo<>()
969         https://bugs.webkit.org/show_bug.cgi?id=194462
970
971         Reviewed by Geoffrey Garen.
972
973         Darin suggested to test the very last floating point number
974         at the boundaries when truncating to integer.
975         I added test for max/min and max-1/min-1.
976
977         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
978         (TestWebKitAPI::TEST):
979
980 2019-02-09  Darin Adler  <darin@apple.com>
981
982         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
983         https://bugs.webkit.org/show_bug.cgi?id=194021
984
985         Reviewed by Geoffrey Garen.
986
987         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
988         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
989         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
990
991 2019-02-09  Zalan Bujtas  <zalan@apple.com>
992
993         [LFC][IFC] Add intrinsic width support for basic inline containers
994         https://bugs.webkit.org/show_bug.cgi?id=194473
995
996         Reviewed by Antti Koivisto.
997
998         Expand tests coverage (11 new tests -> 798)
999
1000         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
1001
1002 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
1003
1004         Fix MiniBrowser's entitlements
1005         https://bugs.webkit.org/show_bug.cgi?id=192431
1006
1007         Reviewed by Joseph Pecoraro.
1008
1009         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
1010         files, making it impossible to load any extension.
1011
1012         * MiniBrowser/MiniBrowser.entitlements:
1013
1014 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
1015
1016         [Cocoa] Ask platform for generic font family mappings
1017         https://bugs.webkit.org/show_bug.cgi?id=187723
1018         <rdar://problem/41892438>
1019
1020         Reviewed by Brent Fulgham.
1021
1022         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1023
1024         * DumpRenderTree/mac/DumpRenderTree.mm:
1025         (allowedFontFamilySet):
1026         * WebKitTestRunner/mac/TestControllerMac.mm:
1027         (WTR::allowedFontFamilySet):
1028
1029 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
1030
1031         [GTK] Implement back/forward touchpad gesture
1032         https://bugs.webkit.org/show_bug.cgi?id=193919
1033
1034         Reviewed by Michael Catanzaro.
1035
1036         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1037         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
1038
1039 2019-02-08  Alex Christensen  <achristensen@webkit.org>
1040
1041         Add SPI to use networking daemon instead of XPC service
1042         https://bugs.webkit.org/show_bug.cgi?id=194427
1043
1044         Reviewed by Geoffrey Garen
1045
1046         * MiniBrowser/MiniBrowser.entitlements:
1047
1048 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1049
1050         [ews-build] Ensure that every builder in config.json has short name
1051         https://bugs.webkit.org/show_bug.cgi?id=194461
1052
1053         Reviewed by Lucas Forschler.
1054
1055         * BuildSlaveSupport/ews-build/loadConfig.py:
1056         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
1057
1058 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1059
1060         [ews-build] Add short name to config.json
1061         https://bugs.webkit.org/show_bug.cgi?id=194456
1062
1063         Reviewed by Lucas Forschler.
1064
1065         * BuildSlaveSupport/ews-build/config.json: Added short name.
1066         * BuildSlaveSupport/ews-build/loadConfig.py:
1067         (loadBuilderConfig): Set the short name as the builder description.
1068
1069 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
1070
1071         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
1072         https://bugs.webkit.org/show_bug.cgi?id=194418
1073
1074         Reviewed by Lucas Forschler.
1075
1076         Do not include errors trying when finding crashlogs at the end of
1077         a run-webkit-tests run since we don't process those errors.
1078
1079         * Scripts/webkitpy/port/darwin.py:
1080         (DarwinPort._look_for_all_crash_logs_in_log_dir):
1081         * Scripts/webkitpy/port/ios_device.py:
1082         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
1083         * Scripts/webkitpy/port/watch_device.py:
1084         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
1085
1086 2019-02-08  Beth Dakin  <bdakin@apple.com>
1087
1088         Add afterScreenUpdates to WKSnapshotConfiguration
1089         https://bugs.webkit.org/show_bug.cgi?id=194362
1090         -and corresponding-
1091         <rdar://problem/40655528> Please add an "after screen updates" property to 
1092         WKSnapshotConfiguration (to solve blank snapshots)
1093
1094         Reviewed by Tim Horton.
1095
1096         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
1097         (TEST):
1098
1099 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
1100
1101         clampTo(): do not convert the input to double when dealing with integers
1102         https://bugs.webkit.org/show_bug.cgi?id=194263
1103         <rdar://problem/47692312>
1104
1105         Reviewed by Darin Adler.
1106
1107         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1108         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
1109         (TestWebKitAPI::testClampFloatingPointToInteger):
1110         (TestWebKitAPI::testClampSameSignIntegers):
1111         (TestWebKitAPI::testClampUnsignedToSigned):
1112         (TestWebKitAPI::testClampSignedToUnsigned):
1113
1114 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
1115
1116         webkitpy: Respect --dedicated-simulators flag
1117         https://bugs.webkit.org/show_bug.cgi?id=194416
1118         <rdar://problem/47894722>
1119
1120         Reviewed by Lucas Forschler.
1121
1122         * Scripts/webkitpy/port/device_port.py:
1123         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
1124         available devices can be safely ignored.
1125
1126 2019-02-07  Keith Rollin  <krollin@apple.com>
1127
1128         Remove extra copy of 100x100-red.tga
1129         https://bugs.webkit.org/show_bug.cgi?id=194371
1130         <rdar://problem/47873465>
1131
1132         Reviewed by Said Abou-Hallawa.
1133
1134         In order to help it pass its tests, Bug 194190 added a second copy of
1135         the file 100x100-red.tga. However, it turns out that this additional
1136         file wasn't actually needed, and that that sole previous copy was
1137         sufficient. At the same time, this second copy -- which was copied to
1138         the same location in the build output as the first copy -- now caused
1139         XCBuild to complain because there were two production rules for the
1140         same output file. Address this by removing the newly-added extra copy.
1141
1142         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1143         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
1144
1145 2019-02-07  Alex Christensen  <achristensen@webkit.org>
1146
1147         Deprecate WKBundlePageSetDefersLoading
1148         https://bugs.webkit.org/show_bug.cgi?id=191394
1149
1150         Reviewed by Dean Jackson.
1151
1152         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1153         (WTR::TestRunner::setDefersLoading):
1154
1155 2019-02-07  Zalan Bujtas  <zalan@apple.com>
1156
1157         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
1158         https://bugs.webkit.org/show_bug.cgi?id=194391
1159
1160         Reviewed by Antti Koivisto.
1161
1162         * LayoutReloaded/misc/LFC-passing-tests.txt:
1163
1164 2019-02-06  Keith Rollin  <krollin@apple.com>
1165
1166         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
1167         https://bugs.webkit.org/show_bug.cgi?id=193975
1168         <rdar://problem/47643306>
1169
1170         Reviewed by Tim Horton.
1171
1172         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
1173         the Info.plist file into the bundle. This step is not necessary as the
1174         implicit "bundle up all the build products into a framework" build
1175         phase does this already. Having the Copy Bundle Resources phase do
1176         this causes a conflict under XCBuild, which objects to two build
1177         phases producing the same file (Info.plist). Address this by removing
1178         Info.plist from the Copy Bundle Resources phase.
1179
1180         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1181
1182 2019-02-06  Keith Rollin  <krollin@apple.com>
1183
1184         Really enable the automatic checking and regenerations of .xcfilelists during builds
1185         https://bugs.webkit.org/show_bug.cgi?id=194357
1186         <rdar://problem/47861231>
1187
1188         Reviewed by Chris Dumez.
1189
1190         Bug 194124 was supposed to enable the automatic checking and
1191         regenerating of .xcfilelist files during the build. While related
1192         changes were included in that patch, the change to actually enable the
1193         operation somehow was omitted. This patch actually enables the
1194         operation. The check-xcfilelist.sh scripts now check
1195         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
1196         from the checking.
1197
1198         * DumpRenderTree/Scripts/check-xcfilelists.sh:
1199         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
1200
1201 2019-02-06  David Kilzer  <ddkilzer@apple.com>
1202
1203         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
1204         <https://webkit.org/b/194286>
1205         <rdar://problem/47815558>
1206
1207         Reviewed by Alexey Proskuryakov.
1208
1209         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1210         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
1211         WKRetainPtr<> to avoid leaking the WKDataRef.
1212
1213 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1214
1215         Unreviewed, fix a typo
1216
1217         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1218
1219 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
1220
1221         [GTK][WPE] force libpsl build to use ICU in jhbuild
1222         https://bugs.webkit.org/show_bug.cgi?id=194288
1223
1224         Reviewed by Carlos Garcia Campos.
1225
1226         * gtk/jhbuild.modules:
1227         Require ICU for libpsl build in jhbuild, like done in WPE.
1228
1229 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1230
1231         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
1232         https://bugs.webkit.org/show_bug.cgi?id=194209
1233
1234         Reviewed by Carlos Garcia Campos.
1235
1236         Enhance TestCookieManager to ensure this doesn't happen again.
1237
1238         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1239         (testCookieManagerPersistentStorage):
1240         (beforeAll):
1241
1242 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1243
1244         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
1245         https://bugs.webkit.org/show_bug.cgi?id=194324
1246
1247         Reviewed by Andy Estes.
1248
1249         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
1250         part of the name is already implicit, since this is in testing code in TestOptions.
1251
1252         * WebKitTestRunner/TestController.cpp:
1253         (WTR::TestController::generateContextConfiguration const):
1254         (WTR::updateTestOptionsFromTestHeader):
1255         * WebKitTestRunner/TestOptions.h:
1256         (WTR::TestOptions::hasSameInitializationOptions const):
1257
1258 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1259
1260         [ews-build] Allow * as platform for builders and workers
1261         https://bugs.webkit.org/show_bug.cgi?id=188533
1262
1263         Reviewed by Lucas Forschler.
1264
1265         * BuildSlaveSupport/ews-build/loadConfig.py:
1266         (checkWorkersAndBuildersForConsistency):
1267
1268 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1269
1270         [ews-build] Add few bots to config.json
1271         https://bugs.webkit.org/show_bug.cgi?id=194304
1272
1273         Reviewed by Lucas Forschler.
1274
1275         * BuildSlaveSupport/ews-build/config.json:
1276
1277 2019-02-05  Keith Rollin  <krollin@apple.com>
1278
1279         Enable the automatic checking and regenerations of .xcfilelists during builds
1280         https://bugs.webkit.org/show_bug.cgi?id=194124
1281         <rdar://problem/47721277>
1282
1283         Reviewed by Tim Horton.
1284
1285         Bug 193790 add a facility for checking -- during build time -- that
1286         any needed .xcfilelist files are up-to-date and for updating them if
1287         they are not. This facility was initially opt-in by setting
1288         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
1289         the process seemed robust. Its now time to enable this facility and
1290         make it opt-out. If there is a need to disable this facility, set and
1291         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
1292         running `make` or `build-webkit`, or before running Xcode from the
1293         command line.
1294
1295         Additionally, remove the step that generates a list of source files
1296         going into the UnifiedSources build step. It's only necessarily to
1297         specify Sources.txt and SourcesCocoa.txt as inputs.
1298
1299         * Scripts/generate-xcfilelists:
1300
1301 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1302
1303         [GTK][WPE] force libpsl build to use ICU in jhbuild
1304         https://bugs.webkit.org/show_bug.cgi?id=194288
1305
1306         Reviewed by Philippe Normand.
1307
1308         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
1309         This can cause build failures if libidn is detected but libunistring is not available.
1310
1311         Make sure that ICU is used for runtime and builtin PSL data.
1312
1313         * gtk/jhbuild.modules:
1314         * wpe/jhbuild.modules:
1315
1316 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1317
1318         [ews-app] Modified timestamp should be updated on updating data
1319         https://bugs.webkit.org/show_bug.cgi?id=194295
1320
1321         Reviewed by Lucas Forschler.
1322
1323         * BuildSlaveSupport/ews-app/ews/models/build.py:
1324         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1325         * BuildSlaveSupport/ews-app/ews/models/step.py:
1326
1327 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
1328
1329         Unreviewed, rolling out r240742.
1330
1331         Causes crashes on iOS simulator.
1332
1333         Reverted changeset:
1334
1335         "[iOS] Keyups for non-modifier keys identified as "Dead" when
1336         not focused in a content-editable element"
1337         https://bugs.webkit.org/show_bug.cgi?id=192824
1338         https://trac.webkit.org/changeset/240742
1339
1340 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
1341
1342         run-webkit-tests emits message "...running None" when running tests
1343         https://bugs.webkit.org/show_bug.cgi?id=194133
1344         <rdar://problem/47724738>
1345
1346         Reviewed by Lucas Forschler.
1347
1348         * Scripts/webkitpy/xcode/device_type.py:
1349         (DeviceType.__str__): Use both version mapping tables and use just the variant
1350         name if no version name is available.
1351         * Scripts/webkitpy/xcode/device_type_unittest.py:
1352         (DeviceTypeTest):
1353         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
1354         an associated named.
1355
1356 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1357
1358         [WPE] require python3-setuptools for meson build in jhbuild
1359         https://bugs.webkit.org/show_bug.cgi?id=194287
1360
1361         Reviewed by Philippe Normand.
1362
1363         python3-setuptools is needed to build meson in jhbuild.
1364         It is already required by the GTK port.
1365
1366         * wpe/install-dependencies:
1367
1368 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1369
1370         [ews-app] Add method to save BuilderMapping to database
1371         https://bugs.webkit.org/show_bug.cgi?id=194264
1372
1373         Reviewed by Lucas Forschler.
1374
1375         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1376         (BuilderMapping.__str__):
1377         (BuilderMapping):
1378         (BuilderMapping.save_mapping):
1379         (BuilderMapping.update_mapping):
1380         (BuilderMapping.get_existing_mapping):
1381         (BuilderMapping.is_valid_mapping):
1382
1383 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1384
1385         [ews-app] Add timestamp fields for BuilderMappings
1386         https://bugs.webkit.org/show_bug.cgi?id=194266
1387
1388         Reviewed by Lucas Forschler.
1389
1390         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1391         (BuilderMapping):
1392
1393 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
1394
1395         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
1396         https://bugs.webkit.org/show_bug.cgi?id=174816
1397
1398         Reviewed by Michael Catanzaro.
1399
1400         Add tests for webkit_uri_for_display().
1401
1402         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
1403         (testURIForDisplayUnaffected):
1404         (testURIForDisplayAffected):
1405         (beforeAll):
1406         (afterAll):
1407         * TestWebKitAPI/glib/CMakeLists.txt:
1408
1409 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
1410
1411         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
1412         https://bugs.webkit.org/show_bug.cgi?id=194158
1413         <rdar://problem/47737268>
1414
1415         Rubber-stamped by Aakash Jain.
1416
1417         * Scripts/webkitpy/port/device_port.py:
1418         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
1419
1420 2019-02-04  Said Abou-Hallawa  <said@apple.com>
1421
1422         [CG] Enable setAdditionalSupportedImageTypes for WK1
1423         https://bugs.webkit.org/show_bug.cgi?id=194190
1424
1425         Reviewed by Tim Horton.
1426
1427         Add a test similar to the one under WebKit Cocoa but make it create a
1428         WebView instead of a WKWebView.
1429
1430         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1431         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
1432         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
1433         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
1434         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
1435         (TestWebKitAPI::runTest):
1436         (TestWebKitAPI::TEST):
1437
1438 2019-02-04  Zalan Bujtas  <zalan@apple.com>
1439
1440         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
1441         https://bugs.webkit.org/show_bug.cgi?id=194168
1442
1443         Reviewed by Simon Fraser.
1444
1445         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
1446
1447         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1448         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
1449         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
1450         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
1451         (TEST):
1452         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
1453         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
1454
1455 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
1456
1457         REGRESSION (r237269): webkit-patch what-broke is broken 
1458         https://bugs.webkit.org/show_bug.cgi?id=193025
1459
1460         Reviewed by Aakash Jain.
1461
1462         * Scripts/webkitpy/common/host.py:
1463         (Host.buildbot):
1464         (Host.bugzilla): Renamed to 'buildbot'.
1465
1466 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1467
1468         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
1469         https://bugs.webkit.org/show_bug.cgi?id=194207
1470
1471         Reviewed by Tim Horton.
1472
1473         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
1474         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
1475         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
1476         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
1477         start and delete forwards to remove the original attachment.
1478
1479         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1480         (TestWebKitAPI::TEST):
1481
1482 2019-02-04  Youenn Fablet  <youenn@apple.com>
1483
1484         Capture state should be managed consistently when doing process swapping
1485         https://bugs.webkit.org/show_bug.cgi?id=194122
1486         <rdar://problem/47609293>
1487
1488         Reviewed by Eric Carlson.
1489
1490         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1491         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1492         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1493         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
1494         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1495         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1496         (WTR::TestRunner::isDoingMediaCapture const):
1497         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1498         * WebKitTestRunner/TestController.cpp:
1499         (WTR::TestController::isDoingMediaCapture const):
1500         * WebKitTestRunner/TestController.h:
1501         * WebKitTestRunner/TestInvocation.cpp:
1502         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1503         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1504         (WTR::TestController::isDoingMediaCapture const):
1505
1506 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1507
1508         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
1509         https://bugs.webkit.org/show_bug.cgi?id=194142
1510
1511         Reviewed by Ross Kirsling.
1512
1513         There three 'separator' variables in TestController.cpp. Renamed
1514         it 'pathSeparator', and unified them.
1515
1516         * WebKitTestRunner/TestController.cpp:
1517         (WTR::TestController::generateContextConfiguration const):
1518         (WTR::createTestURL):
1519         (WTR::TestController::platformAdjustContext):
1520
1521 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
1522
1523         Make setNeedsLayout on the root more explicitly about triggering its side-effects
1524         https://bugs.webkit.org/show_bug.cgi?id=194198
1525
1526         Reviewed by Antti Koivisto.
1527
1528         No need to set the banner heights on navigation now, since Page stores them.
1529
1530         * MiniBrowser/mac/WK2BrowserWindowController.m:
1531         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
1532
1533 2019-02-03  John Wilander  <wilander@apple.com>
1534
1535         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
1536         https://bugs.webkit.org/show_bug.cgi?id=194104
1537         <rdar://problem/47649991>
1538
1539         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
1540
1541         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1542         (TestWebKitAPI::TEST):
1543             Changed numeric types from unsigned short to uint32_t.
1544
1545 2019-02-02  David Kilzer  <ddkilzer@apple.com>
1546
1547         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
1548         <https://webkit.org/b/194178>
1549         <rdar://problem/47753473>
1550
1551         Reviewed by Alexey Proskuryakov.
1552
1553         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1554         (WTR::uninstallFakeHelvetica): Pass nullptr into
1555         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
1556
1557 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1558
1559         [LFC] Initialize ICB's style with fixed width/height.
1560         https://bugs.webkit.org/show_bug.cgi?id=194188
1561
1562         Reviewed by Antti Koivisto.
1563
1564         * LayoutReloaded/misc/LFC-passing-tests.txt:
1565
1566 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1567
1568         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
1569         https://bugs.webkit.org/show_bug.cgi?id=194185
1570
1571         Reviewed by Antti Koivisto.
1572
1573         * LayoutReloaded/misc/LFC-passing-tests.txt:
1574
1575 2018-12-16  Darin Adler  <darin@apple.com>
1576
1577         Convert additional String::format clients to alternative approaches
1578         https://bugs.webkit.org/show_bug.cgi?id=192746
1579
1580         Reviewed by Alexey Proskuryakov.
1581
1582         * WebKitTestRunner/TestController.cpp:
1583         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
1584         as an intermediate in code that ultimately constructs a WTF::String.
1585         (WTR::userMediaOriginHash): Use makeString.
1586         (WTR::TestController::didNavigateWithNavigationData): More of the same.
1587         (WTR::TestController::didPerformClientRedirect): Ditto.
1588         (WTR::TestController::didPerformServerRedirect): Ditto.
1589         (WTR::TestController::didUpdateHistoryTitle): Ditto.
1590
1591 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1592
1593         [ews-build] Add unit test to verify builder keys
1594         https://bugs.webkit.org/show_bug.cgi?id=194152
1595
1596         Reviewed by Lucas Forschler.
1597
1598         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1599         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
1600
1601 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1602
1603         [LFC] Expand tests coverage (12 new tests -> 787)
1604
1605         Unreviewed test gardening.
1606
1607         * LayoutReloaded/misc/LFC-passing-tests.txt:
1608
1609 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1610
1611         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
1612         https://bugs.webkit.org/show_bug.cgi?id=194163
1613
1614         Reviewed by Simon Fraser.
1615
1616         775
1617
1618         * LayoutReloaded/misc/LFC-passing-tests.txt:
1619
1620 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1621
1622         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
1623         https://bugs.webkit.org/show_bug.cgi?id=194140
1624         <rdar://problem/47728098>
1625
1626         Reviewed by Tim Horton.
1627
1628         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1629         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1630         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
1631
1632         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
1633         test to induce an IPC deadlock when presenting a modal alert during touch start.
1634
1635         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1636         * WebKitTestRunner/TestController.cpp:
1637         (WTR::runJavaScriptAlert):
1638
1639         Add a client callback function for running JavaScript alerts.
1640
1641         (WTR::TestController::createOtherPage):
1642         (WTR::TestController::generateContextConfiguration const):
1643
1644         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
1645         the fix in this patch.
1646
1647         (WTR::TestController::createWebViewWithOptions):
1648
1649         Plumb TestOptions to generateContextConfiguration.
1650
1651         (WTR::TestController::resetPreferencesToConsistentValues):
1652         (WTR::TestController::resetStateToConsistentValues):
1653         (WTR::updateTestOptionsFromTestHeader):
1654         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
1655         (WTR::TestController::handleJavaScriptAlert):
1656         * WebKitTestRunner/TestController.h:
1657         * WebKitTestRunner/TestInvocation.cpp:
1658         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1659         * WebKitTestRunner/TestOptions.h:
1660         (WTR::TestOptions::hasSameInitializationOptions const):
1661
1662 2019-02-01  Chris Dumez  <cdumez@apple.com>
1663
1664         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
1665         https://bugs.webkit.org/show_bug.cgi?id=193740
1666         <rdar://problem/47527267>
1667
1668         Reviewed by Alex Christensen.
1669
1670         Add API test coverage.
1671
1672         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1673
1674 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1675
1676         [ews-app] Add display name field to BuilderMapping model
1677         https://bugs.webkit.org/show_bug.cgi?id=194153
1678
1679         Reviewed by Lucas Forschler.
1680
1681         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1682         (BuilderMapping):
1683
1684 2019-02-01  Youenn Fablet  <youenn@apple.com>
1685
1686         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
1687         https://bugs.webkit.org/show_bug.cgi?id=194155
1688
1689         Reviewed by Eric Carlson.
1690
1691         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1692         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
1693         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
1694
1695 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1696
1697         [LFC] Adjust replaced element's intrinsic ratio
1698         https://bugs.webkit.org/show_bug.cgi?id=194154
1699
1700         Reviewed by Antti Koivisto.
1701
1702         761
1703
1704         * LayoutReloaded/misc/LFC-passing-tests.txt:
1705
1706 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1707
1708         [WPE] Show test results in minibrowser
1709         https://bugs.webkit.org/show_bug.cgi?id=194150
1710
1711         Reviewed by Žan Doberšek.
1712
1713         * Scripts/webkitpy/port/wpe.py:
1714         (WPEPort.show_results_html_file):
1715
1716 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1717
1718         [WPE] MiniBrowser: add ky bindings for back/forward navigation
1719         https://bugs.webkit.org/show_bug.cgi?id=194151
1720
1721         Reviewed by Žan Doberšek.
1722
1723         ALT + <- go back
1724         ALT + -> go forward
1725
1726         * MiniBrowser/wpe/main.cpp:
1727         (main):
1728
1729 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1730
1731         [LFC] Set intrinsic size on Layout::Replaced
1732         https://bugs.webkit.org/show_bug.cgi?id=194139
1733
1734         Reviewed by Antti Koivisto.
1735
1736         744
1737
1738         * LayoutReloaded/misc/LFC-passing-tests.txt:
1739
1740 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1741
1742         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
1743         https://bugs.webkit.org/show_bug.cgi?id=194146
1744
1745         Reviewed by Xabier Rodriguez-Calvar.
1746
1747         It allows to open relative paths.
1748
1749         * MiniBrowser/wpe/main.cpp:
1750         (main):
1751
1752 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
1753
1754         Update flakiness dashboard configuration after recent queue changes
1755         https://bugs.webkit.org/show_bug.cgi?id=194127
1756
1757         Rubber-stamped by Aakash Jain.
1758
1759         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
1760
1761         * TestResultServer/static-dashboards/builders.jsonp:
1762
1763 2019-01-31  Youenn Fablet  <youenn@apple.com>
1764
1765         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
1766         https://bugs.webkit.org/show_bug.cgi?id=194106
1767         <rdar://problem/47676333>
1768
1769         Reviewed by Ryosuke Niwa.
1770
1771         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1772         (TestWebKitAPI::didFinishNavigation):
1773         (TestWebKitAPI::TEST):
1774         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1775
1776 2019-01-31  Chris Dumez  <cdumez@apple.com>
1777
1778         Page zoom level is lost after a process swap or a crash
1779         https://bugs.webkit.org/show_bug.cgi?id=194105
1780         <rdar://problem/47610781>
1781
1782         Reviewed by Alex Christensen.
1783
1784         Add API test coverage.
1785
1786         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1787         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
1788
1789 2019-01-31  Alex Christensen  <achristensen@webkit.org>
1790
1791         Revert r238819 which is unneeded and caused a performance regression.
1792         https://bugs.webkit.org/show_bug.cgi?id=192272
1793         <rdar://problem/46664625>
1794
1795         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
1796         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
1797         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
1798
1799 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
1800
1801         Formalize WebKitAdditions mechanism of LoadOptimizer
1802         https://bugs.webkit.org/show_bug.cgi?id=193886
1803         <rdar://problem/47696809>
1804
1805         Reviewed by Brent Fulgham.
1806
1807         * MiniBrowser/MiniBrowser.entitlements:
1808         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
1809
1810 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1811
1812         [LFC] Margin before/after/start/end initial value is 0 and not auto.
1813         https://bugs.webkit.org/show_bug.cgi?id=194090
1814
1815         Reviewed by Antti Koivisto.
1816
1817         * LayoutReloaded/misc/LFC-passing-tests.txt:
1818
1819 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1820
1821         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
1822         https://bugs.webkit.org/show_bug.cgi?id=194074
1823
1824         Reviewed by Antti Koivisto.
1825
1826         * LayoutReloaded/misc/LFC-passing-tests.txt:
1827
1828 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1829
1830         [LFC][BFC] Add support for block level replaced box.
1831         https://bugs.webkit.org/show_bug.cgi?id=194071
1832
1833         Reviewed by Antti Koivisto.
1834
1835         * LayoutReloaded/misc/LFC-passing-tests.txt:
1836
1837 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1838
1839         Fix WebKitTestRunner's testPath with Windows full paths
1840         https://bugs.webkit.org/show_bug.cgi?id=194012
1841
1842         Reviewed by Alex Christensen.
1843
1844         updateTestOptionsFromTestHeader failed to open test files because
1845         testPath returned wrong file paths. It returned a path "/C:/..."
1846         if a URL "file:///C:/..." was given.
1847
1848         * WebKitTestRunner/TestController.cpp:
1849         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
1850
1851 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1852
1853         [WPE] Bump font related dependencies to match the GTK+ port
1854         https://bugs.webkit.org/show_bug.cgi?id=194017
1855
1856         Reviewed by Žan Doberšek.
1857
1858         * wpe/jhbuild.modules:
1859         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1860         * wpe/patches/icudata-stdlibs.patch: Added.
1861
1862 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1863
1864         Enable swipe tests on iOS
1865         https://bugs.webkit.org/show_bug.cgi?id=194076
1866
1867         Reviewed by Geoffrey Garen.
1868
1869         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
1870         it causes a debug assertion failure in runUIScript.
1871
1872         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1873         (WTR::UIScriptController::beginBackSwipe):
1874         (WTR::UIScriptController::completeBackSwipe):
1875
1876 2019-01-30  Keith Rollin  <krollin@apple.com>
1877
1878         Use correct printf format specifier
1879         https://bugs.webkit.org/show_bug.cgi?id=194062
1880         <rdar://problem/47686167>
1881
1882         Reviewed by Alexey Proskuryakov.
1883
1884         LayoutTestSpellChecker.mm is trying to format a variable of type
1885         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
1886         actually an unsigned long long. Fix this by formatting with %llu.
1887
1888         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
1889         (-[LayoutTestTextCheckingResult description]):
1890
1891 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1892
1893         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
1894         https://bugs.webkit.org/show_bug.cgi?id=193979
1895
1896         Reviewed by Wenson Hsieh.
1897
1898         Fix the test for iOS. Make the test work with iOS UA string.
1899
1900         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1901
1902 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
1903
1904         Replace High Sierra LLINT CLoop bot due to hardware failure
1905         https://bugs.webkit.org/show_bug.cgi?id=194066
1906
1907         Reviewed by Aakash Jain.
1908
1909         * BuildSlaveSupport/build.webkit.org-config/config.json:
1910
1911 2019-01-30  Keith Rollin  <krollin@apple.com>
1912
1913         [NSDragItem init] is unavailable
1914         https://bugs.webkit.org/show_bug.cgi?id=194059
1915         <rdar://problem/47685715>
1916
1917         Reviewed by Wenson Hsieh.
1918
1919         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
1920         DumpRenderTree and TestWebKitAPI, which both try to create an
1921         NSDragItem in a manner that invokes this method. Address this by using
1922         -initWithPasteboardWriter instead.
1923
1924         Note that the parameter passed to initWithPasteboardWriter is likely
1925         incorrect. In both cases, the object passed does not conform to
1926         NSPasteboardWriting. However, with this fix, we're no worse off than
1927         before, and can now perform builds with newer compilers and SDKs until
1928         a real fix can be crafted. That work is tracked in
1929         https://bugs.webkit.org/show_bug.cgi?id=194060
1930
1931         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1932         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1933         * TestWebKitAPI/mac/TestDraggingInfo.mm:
1934         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1935
1936 2019-01-30  Daniel Bates  <dabates@apple.com>
1937
1938         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1939         https://bugs.webkit.org/show_bug.cgi?id=192824
1940         <rdar://problem/47100332>
1941
1942         Reviewed by Wenson Hsieh.
1943
1944         Fix a bug where the wrong usage code was used for F13 thru F24.
1945
1946         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1947         (keyCodeForDOMFunctionKey):
1948
1949 2019-01-30  Chris Dumez  <cdumez@apple.com>
1950
1951         Regression(PSON) Load hang can occur on history navigation
1952         https://bugs.webkit.org/show_bug.cgi?id=194030
1953         <rdar://problem/47656939>
1954
1955         Reviewed by Antti Koivisto.
1956
1957         Add API test coverage.
1958
1959         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1960
1961 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1962
1963         [LFC] Expand tests coverage.
1964
1965         Unreviewed test gardening.
1966
1967         * LayoutReloaded/misc/LFC-passing-tests.txt:
1968
1969 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
1970
1971         [Flatpak] Add openjpeg support
1972         https://bugs.webkit.org/show_bug.cgi?id=194019
1973
1974         Reviewed by Michael Catanzaro.
1975
1976         * flatpak/org.webkit.CommonModules.yaml:
1977
1978 2019-01-30  Commit Queue  <commit-queue@webkit.org>
1979
1980         Unreviewed, rolling out r240708.
1981         https://bugs.webkit.org/show_bug.cgi?id=194022
1982
1983         It broke WPE build (Requested by KaL on #webkit).
1984
1985         Reverted changeset:
1986
1987         "[WPE] Bump font related dependencies to match the GTK+ port"
1988         https://bugs.webkit.org/show_bug.cgi?id=194017
1989         https://trac.webkit.org/changeset/240708
1990
1991 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1992
1993         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
1994         https://bugs.webkit.org/show_bug.cgi?id=194001
1995
1996         Reviewed by Antti Koivisto.
1997
1998         * LayoutReloaded/misc/LFC-passing-tests.txt:
1999
2000 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2001
2002         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
2003         https://bugs.webkit.org/show_bug.cgi?id=194020
2004
2005         Reviewed by Antti Koivisto.
2006
2007         * LayoutReloaded/misc/LFC-passing-tests.txt:
2008
2009 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
2010
2011         AX: Support color well on iOS
2012         https://bugs.webkit.org/show_bug.cgi?id=194010
2013
2014         Reviewed by Joanmarie Diggs.
2015
2016         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2017         (WTR::AccessibilityUIElement::stringAttributeValue):
2018
2019 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2020
2021         [WPE] Bump font related dependencies to match the GTK+ port
2022         https://bugs.webkit.org/show_bug.cgi?id=194017
2023
2024         Reviewed by Žan Doberšek.
2025
2026         * wpe/jhbuild.modules:
2027         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
2028         * wpe/patches/icudata-stdlibs.patch: Added.
2029
2030 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
2031
2032         [Mac] Update window scale API usage
2033         https://bugs.webkit.org/show_bug.cgi?id=193991
2034         rdar://problem/47614795
2035
2036         Reviewed by Tim Horton.
2037
2038         * DumpRenderTree/mac/DumpRenderTree.mm:
2039         (changeWindowScaleIfNeeded):
2040         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2041         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2042         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2043
2044 2019-01-29  Chris Dumez  <cdumez@apple.com>
2045
2046         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
2047         https://bugs.webkit.org/show_bug.cgi?id=193977
2048         <rdar://problem/47643716>
2049
2050         Reviewed by Geoff Garen.
2051
2052         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
2053         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
2054         to the previous provisional committing *before* we make the last load. 
2055
2056         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2057
2058 2019-01-29  Youenn Fablet  <youenn@apple.com>
2059
2060         Adopt new SPI to evaluate server certificate trust
2061         https://bugs.webkit.org/show_bug.cgi?id=193355
2062
2063         Reviewed by Alex Christensen.
2064
2065         Add infrastructure to handle HTTPS server trust evaluation testing.
2066
2067         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2068         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2069         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
2070         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
2071         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
2072         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2073         * WebKitTestRunner/TestController.cpp:
2074         (WTR::TestController::resetPreferencesToConsistentValues):
2075         (WTR::TestController::didReceiveAuthenticationChallenge):
2076         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2077         * WebKitTestRunner/TestController.h:
2078         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
2079         * WebKitTestRunner/TestInvocation.cpp:
2080         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2081         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2082         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2083
2084 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2085
2086         [ews-build] Add build step to print bot Configuration
2087         https://bugs.webkit.org/show_bug.cgi?id=193887
2088
2089         Reviewed by Lucas Forschler.
2090
2091         * BuildSlaveSupport/ews-build/steps.py:
2092         (PrintConfiguration): Build step to print configuration.
2093         * BuildSlaveSupport/ews-build/factories.py:
2094
2095 2019-01-29  Chris Dumez  <cdumez@apple.com>
2096
2097         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
2098         https://bugs.webkit.org/show_bug.cgi?id=193967
2099         <rdar://problem/47635348>
2100
2101         Reviewed by Alex Christensen.
2102
2103         Add API test coverage.
2104
2105         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2106         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
2107
2108 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2109
2110         [ews-app] Handle incoming results data
2111         https://bugs.webkit.org/show_bug.cgi?id=193973
2112
2113         Reviewed by Lucas Forschler.
2114
2115         * BuildSlaveSupport/ews-app/ews/views/results.py:
2116
2117 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2118
2119         [ews-app] Make the results url generic
2120         https://bugs.webkit.org/show_bug.cgi?id=193928
2121
2122         Reviewed by Lucas Forschler.
2123
2124         * BuildSlaveSupport/ews-app/ews/urls.py:
2125
2126 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2127
2128         [ews-build] Configure buildbot to send events to ews-app
2129         https://bugs.webkit.org/show_bug.cgi?id=193968
2130
2131         Reviewed by Lucas Forschler.
2132
2133         * BuildSlaveSupport/ews-build/events.py: Added.
2134         * BuildSlaveSupport/ews-build/master.cfg:
2135
2136 2019-01-29  Keith Rollin  <krollin@apple.com>
2137
2138         Add .xcfilelists to Run Script build phases
2139         https://bugs.webkit.org/show_bug.cgi?id=193792
2140         <rdar://problem/47201785>
2141
2142         Reviewed by Alex Christensen.
2143
2144         As part of supporting XCBuild, update the necessary Run Script build
2145         phases in their Xcode projects to refer to their associated
2146         .xcfilelist files.
2147
2148         Note that the addition of these files bumps the Xcode project version
2149         number to something that's Xcode 10 compatible. This change means that
2150         older versions of the Xcode IDE can't read these projects. Nor can it
2151         fully load workspaces that refer to these projects (the updated
2152         projects are shown as non-expandable placeholders). `xcodebuild` can
2153         still build these projects; it's just that the IDE can't open them.
2154
2155         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2156         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2157
2158 2019-01-29  John Wilander  <wilander@apple.com>
2159
2160         Add data abstraction and validation for Ad Click Attribution
2161         https://bugs.webkit.org/show_bug.cgi?id=193916
2162         <rdar://problem/47603481>
2163
2164         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
2165
2166         Ad click attribution has two steps. First, the storage of an ad
2167         campaign ID for a click that takes the user to a destination
2168         site. Second, a conversion on the destination site that can be
2169         attributed to the ad click.
2170
2171         This patch adds a class that represents a request for ad click
2172         attribution. Validation makes sure that the bits of entropy
2173         reported through this mechanism is limited.
2174
2175         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2176         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
2177         (TestWebKitAPI::TEST):
2178
2179 2019-01-29  Chris Dumez  <cdumez@apple.com>
2180
2181         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
2182         https://bugs.webkit.org/show_bug.cgi?id=193932
2183         <rdar://problem/47598947>
2184
2185         Reviewed by Brady Eidson.
2186
2187         Add API test coverage.
2188
2189         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2190
2191 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2192
2193         Adding new passing LFC tests.
2194
2195         Unreviewed test gardening.
2196
2197         * LayoutReloaded/misc/LFC-passing-tests.txt:
2198
2199 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2200
2201         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
2202         https://bugs.webkit.org/show_bug.cgi?id=193964
2203
2204         Reviewed by Antti Koivisto.
2205
2206         * LayoutReloaded/misc/LFC-passing-tests.txt:
2207
2208 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2209
2210         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
2211         https://bugs.webkit.org/show_bug.cgi?id=193954
2212
2213         Reviewed by Antti Koivisto.
2214
2215         * LayoutReloaded/misc/LFC-passing-tests.txt:
2216
2217 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2218
2219         WebDriver: add support for running subtests
2220         https://bugs.webkit.org/show_bug.cgi?id=193904
2221
2222         Reviewed by Michael Catanzaro.
2223
2224         pytest already supports it by passing test.py::subtest, so we can do the same.
2225
2226         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
2227         (get_item_name): Made this global.
2228         (CollectRecorder.__init__): Receive the parameter to ignore.
2229         (CollectRecorder.pytest_collectreport): Collect also the subtests.
2230         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
2231         (collect): Add parameter to ignore.
2232         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
2233         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
2234         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
2235         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
2236         (WebDriverTestRunnerSelenium.run): Ditto.
2237         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
2238         (WebDriverTestRunnerW3C.collect_tests): Ditto.
2239         (WebDriverTestRunnerW3C.run): Ditto.
2240
2241 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
2242
2243         User agent string override for navigator.userAgent should be site specific quirks
2244         https://bugs.webkit.org/show_bug.cgi?id=193950
2245
2246         Reviewed by Brent Fulgham.
2247
2248         Updated per the _WKWebsitePolicies rename.
2249
2250         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2251         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2252
2253 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
2254
2255         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
2256         https://bugs.webkit.org/show_bug.cgi?id=193941
2257
2258         Reviewed by Alex Christensen.
2259
2260         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
2261         * TestWebKitAPI/Tests/WTF/Condition.cpp:
2262         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2263         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
2264         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2265         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2266         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
2267         * TestWebKitAPI/Tests/WTF/Time.cpp:
2268         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
2269         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
2270         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2271         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2272
2273 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
2274
2275         Unreviewed, reorder my emails to fix autocomplete in bugzilla
2276
2277         * Scripts/webkitpy/common/config/contributors.json:
2278
2279 2019-01-28  Andy Estes  <aestes@apple.com>
2280
2281         [watchOS] Enable Parental Controls content filtering
2282         https://bugs.webkit.org/show_bug.cgi?id=193939
2283         <rdar://problem/46641912>
2284
2285         Reviewed by Ryosuke Niwa.
2286
2287         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2288
2289 2019-01-28  David Kilzer  <ddkilzer@apple.com>
2290
2291         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
2292         <https://webkit.org/b/193884>
2293
2294         Reviewed by Jiewen Tan.
2295
2296         * Scripts/webkitpy/style/checkers/cpp.py:
2297         (check_language): Add LocalAuthentication to
2298         `frameworks_with_soft_links`.
2299
2300 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
2301
2302         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
2303         https://bugs.webkit.org/show_bug.cgi?id=193891
2304
2305         Reviewed by Ross Kirsling.
2306
2307         There were three problems in window sizes of WebView and the host window.
2308         1. The sizes of pixel image output were incorrect.
2309         2. The host window is going to appear after window.resize was invoked.
2310         3. window.resize resized only the host window, not WebView.
2311
2312         This change solves them with a following approach.
2313         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
2314         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
2315            as well as DumpRenderTree in order to match the client area and the window area.
2316         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
2317         d. PlatformWebView::setWindowFrame changes both window sizes.
2318         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
2319
2320         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2321         (WTR::PlatformWebView::PlatformWebView): Create the host window
2322         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
2323         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
2324         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
2325
2326 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2327
2328         [ews-app] Add method to save Step data to database
2329         https://bugs.webkit.org/show_bug.cgi?id=193890
2330
2331         Reviewed by Lucas Forschler.
2332
2333         * BuildSlaveSupport/ews-app/ews/models/step.py:
2334         (Step.save_step): Method to save step data.
2335         (Step.update_step): Method to update step data.
2336         (Step.get_existing_step): Method to fetch existing step from database.
2337         (Step.is_valid_result): Method to validate valid step result.
2338
2339 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2340
2341         [ews-app] Add method to save Build data to database
2342         https://bugs.webkit.org/show_bug.cgi?id=193735
2343
2344         Reviewed by Lucas Forschler.
2345
2346         * BuildSlaveSupport/ews-app/ews/models/build.py:
2347         (Build.save_build): Method to save build information to database.
2348         (Build.get_existing_build): Method to fetch existing build from database.
2349         (Build.is_valid_result): Method to validate build result.
2350         * BuildSlaveSupport/ews-app/ews/common/util.py:
2351         (is_valid_int_id): Method to validate valid id.
2352
2353 2019-01-28  Chris Dumez  <cdumez@apple.com>
2354
2355         Regression(PSON) Crash under WebPageProxy::didStartProgress()
2356         https://bugs.webkit.org/show_bug.cgi?id=193915
2357         <rdar://problem/47560907>
2358
2359         Reviewed by Alex Christensen.
2360
2361         Add API test coverage.
2362
2363         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2364
2365 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2366
2367         [ews-app] Rename id variables
2368         https://bugs.webkit.org/show_bug.cgi?id=193883
2369
2370         Reviewed by Lucas Forschler.
2371
2372         * BuildSlaveSupport/ews-app/ews/models/build.py:
2373         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2374         * BuildSlaveSupport/ews-app/ews/models/step.py:
2375         * BuildSlaveSupport/ews-app/ews/urls.py:
2376         * BuildSlaveSupport/ews-app/ews/views/patch.py:
2377         * BuildSlaveSupport/ews-app/ews/views/results.py:
2378         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2379
2380 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2381
2382         [ews-app] Allow certain fields to be empty
2383         https://bugs.webkit.org/show_bug.cgi?id=193892
2384
2385         Reviewed by Lucas Forschler.
2386
2387         * BuildSlaveSupport/ews-app/ews/models/build.py:
2388         * BuildSlaveSupport/ews-app/ews/models/step.py:
2389
2390 2019-01-28  Rob Buis  <rbuis@igalia.com>
2391
2392         Update MIME type parser
2393         https://bugs.webkit.org/show_bug.cgi?id=180526
2394
2395         Reviewed by Frédéric Wang.
2396
2397         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2398         (TestWebKitAPI::TEST):
2399
2400 2019-01-28  Zalan Bujtas  <zalan@apple.com>
2401
2402         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
2403         https://bugs.webkit.org/show_bug.cgi?id=193896
2404
2405         Reviewed by Antti Koivisto.
2406
2407         * LayoutReloaded/misc/LFC-passing-tests.txt:
2408
2409 2018-12-15  Darin Adler  <darin@apple.com>
2410
2411         Replace many uses of String::format with more type-safe alternatives
2412         https://bugs.webkit.org/show_bug.cgi?id=192742
2413
2414         Reviewed by Mark Lam.
2415
2416         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2417         (WTR::cacheTestRunnerCallback): Use makeString.
2418         * WebKitTestRunner/TestController.cpp:
2419         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
2420         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
2421
2422 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
2423
2424         Use a load optimizer for some sites
2425         https://bugs.webkit.org/show_bug.cgi?id=193881
2426         <rdar://problem/46325455>
2427
2428         Reviewed by Brent Fulgham.
2429
2430         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2431         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
2432
2433 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
2434
2435         AX: Introduce a static accessibility tree
2436         https://bugs.webkit.org/show_bug.cgi?id=193348
2437         <rdar://problem/47203295>
2438
2439         Reviewed by Ryosuke Niwa.
2440
2441         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2442
2443 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2444
2445         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
2446         https://bugs.webkit.org/show_bug.cgi?id=193867
2447
2448         Reviewed by Antti Koivisto.
2449
2450         * LayoutReloaded/misc/LFC-passing-tests.txt:
2451
2452 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2453
2454         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
2455         https://bugs.webkit.org/show_bug.cgi?id=193865
2456
2457         Reviewed by Antti Koivisto.
2458
2459         * LayoutReloaded/misc/LFC-passing-tests.txt:
2460
2461 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2462
2463         Need a mechanism to override navigator.userAgent
2464         https://bugs.webkit.org/show_bug.cgi?id=193762
2465         <rdar://problem/47504939>
2466
2467         Reviewed by Brent Fulgham.
2468
2469         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
2470
2471         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2472         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2473         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
2474
2475 2019-01-25  Dean Jackson  <dino@apple.com>
2476
2477         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
2478         https://bugs.webkit.org/show_bug.cgi?id=193831
2479         <rdar://problem/47399263>
2480
2481         Reviewed by Chris Dumez.
2482
2483         Two new tests that exercise cross-origin and same-origin System
2484         Previews.
2485
2486         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2487
2488 2019-01-25  Keith Rollin  <krollin@apple.com>
2489
2490         Update Xcode projects with "Check .xcfilelists" build phase
2491         https://bugs.webkit.org/show_bug.cgi?id=193790
2492         <rdar://problem/47201374>
2493
2494         Reviewed by Alex Christensen.
2495
2496         Support for XCBuild includes specifying inputs and outputs to various
2497         Run Script build phases. These inputs and outputs are specified as
2498         .xcfilelist files. Once created, these .xcfilelist files need to be
2499         kept up-to-date. In order to check that they are up-to-date or not,
2500         add an Xcode build step that invokes an external script that performs
2501         the checking. If the .xcfilelists are found to be out-of-date, update
2502         them, halt the build, and instruct the developer to restart the build
2503         with up-to-date files.
2504
2505         At this time, the checking and regenerating is performed only if the
2506         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
2507         who want to use this facility can set this variable and test out the
2508         checking/regenerating. Once it seems like there are no egregious
2509         issues that upset a developer's workflow, we'll unconditionally enable
2510         this facility.
2511
2512         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2513         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
2514         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
2515         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2516
2517 2019-01-25  Keith Rollin  <krollin@apple.com>
2518
2519         Update Xcode projects with "Apply Configuration to XCFileLists" build target
2520         https://bugs.webkit.org/show_bug.cgi?id=193781
2521         <rdar://problem/47201153>
2522
2523         Reviewed by Alex Christensen.
2524
2525         Part of generating the .xcfilelists used as part of adopting XCBuild
2526         includes running `make DerivedSources.make` from a standalone script.
2527         It’s important for this invocation to have the same environment as
2528         when the actual build invokes `make DerivedSources.make`. If the
2529         environments are different, then the two invocations will provide
2530         different results. In order to get the same environment in the
2531         standalone script, have the script launch xcodebuild targeting the
2532         "Apply Configuration to XCFileLists" build target, which will then
2533         re-invoke our standalone script. The script is now running again, this
2534         time in an environment with all workspace, project, target, xcconfig
2535         and other environment variables established.
2536
2537         The "Apply Configuration to XCFileLists" build target accomplishes
2538         this task via a small embedded shell script that consists only of:
2539
2540             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
2541
2542         The process that invokes "Apply Configuration to XCFileLists" first
2543         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
2544         evaluated and exports it into the shell environment. When xcodebuild
2545         is invoked, it inherits the value of this variable and can `eval` the
2546         contents of that variable. Our external standalone script can then set
2547         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
2548         of command-line parameters needed to restart itself in the appropriate
2549         state.
2550
2551         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2552         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2553
2554 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2555
2556         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
2557         https://bugs.webkit.org/show_bug.cgi?id=193802
2558         <rdar://problem/46010580>
2559
2560         Reviewed by Andy Estes.
2561
2562         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2563         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
2564         (TEST):
2565
2566 2019-01-25  Daniel Bates  <dabates@apple.com>
2567
2568         [iOS] uiController.keyDown() does not translate Control modified key
2569         https://bugs.webkit.org/show_bug.cgi?id=192898
2570
2571         Reviewed by Wenson Hsieh.
2572
2573         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
2574         key translation, as applicable. Among other cases, key translation occurs when performing
2575         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
2576         also makes the behavior of uiController.keyDown() more closely match the behavior of a
2577         human pressing down and releasing key(s) using a hardware keyboard.
2578
2579         * WebKitTestRunner/ios/HIDEventGenerator.h:
2580         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2581         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
2582
2583         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
2584         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
2585         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2586         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2587         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
2588         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2589         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
2590         (-[HIDEventGenerator longPress:completionBlock:]):
2591         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
2592         Update code for above renaming.
2593
2594         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
2595         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
2596
2597         (-[HIDEventGenerator keyDown:]): Added.
2598         (-[HIDEventGenerator keyUp:]): Added.
2599         (-[HIDEventGenerator keyPress:completionBlock:]):
2600         (-[HIDEventGenerator eventDispatchThreadEntry:]):
2601         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
2602         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2603         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
2604         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
2605         (WTR::parseModifier): Deleted.
2606
2607 2019-01-25  Keith Rollin  <krollin@apple.com>
2608
2609         Complete the implementation of generate-xcfilelists
2610         https://bugs.webkit.org/show_bug.cgi?id=193782
2611
2612         Reviewed by Alex Christensen.
2613
2614         A preliminary version of generate-xcfilelists was added in r238008.
2615         This patch updates that script in order to:
2616
2617         - Support checking of .xcfilelists
2618         - Perform better execution of `make DerivedSources.make` by
2619           relaunching generate-xcfilelists under xcodebuild
2620         - Support incremental generation and checking of .xcfilelists
2621         - Support supplementary .xcfilelists files from WebKitAdditions
2622         - Support being wrapped by parallel version of generate-xcfilelists in
2623           Internal that adds support for (re)generating WebKit projects in
2624           that repo.
2625         - Support builds that have been performed in WebKitBuild as well as
2626           ~/Library/Developer/code/DerivedData
2627         - Increase robustness and debugging facilities.
2628
2629         * Scripts/generate-xcfilelists:
2630
2631 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2632
2633         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2634         https://bugs.webkit.org/show_bug.cgi?id=193297
2635         <rdar://problem/47158841>
2636
2637         Unreviewed test case fix.
2638
2639         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
2640         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
2641
2642         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2643         (TEST):
2644
2645 2019-01-25  Keith Rollin  <krollin@apple.com>
2646
2647         Update existing .xcfilelists
2648         https://bugs.webkit.org/show_bug.cgi?id=193791
2649         <rdar://problem/47201706>
2650
2651         Reviewed by Alex Christensen.
2652
2653         Many .xcfilelist files were added in r238824 in order to support
2654         XCBuild. Update these with recent changes to the set of build files
2655         and with the current generate-xcfilelist script.
2656
2657         * DumpRenderTree/DerivedSources-input.xcfilelist:
2658         * DumpRenderTree/DerivedSources-output.xcfilelist:
2659         * WebKitTestRunner/DerivedSources-input.xcfilelist:
2660         * WebKitTestRunner/DerivedSources-output.xcfilelist:
2661
2662 2019-01-25  Keith Rollin  <krollin@apple.com>
2663
2664         Fix missing dependencies in extract-dependencies-from-makefile
2665         https://bugs.webkit.org/show_bug.cgi?id=193783
2666         <rdar://problem/47201571>
2667
2668         Reviewed by Alex Christensen.
2669
2670         The extract-dependencies-from-makefile script generates .xcfilelists
2671         for XCBuild by invoking a makefile in --debug mode, parsing the
2672         dependency information in the output, and extracting information
2673         regarding targets and dependents. However, the way `make` emits this
2674         dependency information is not rigorous, and so we need to determine
2675         what lines to look for and parse by trial and error. This approach
2676         didn't coriginally atch all the information we needed to collect, so
2677         update the script to look for the additional lines we now know to look
2678         for.
2679
2680         * Scripts/extract-dependencies-from-makefile:
2681         (Parser):
2682         (Parser.addTarget):
2683         (Parser.addPrereq):
2684         (Parser.doParse):
2685
2686 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2687
2688         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2689         https://bugs.webkit.org/show_bug.cgi?id=193297
2690         <rdar://problem/47158841>
2691
2692         Reviewed by Alex Christensen.
2693
2694         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
2695             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
2696         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2697         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2698         activating the message used to trigger the callback when it is set.
2699
2700 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2701
2702         WKWebView.goBack should reload if there is a safe browsing warning
2703         https://bugs.webkit.org/show_bug.cgi?id=193805
2704         <rdar://problem/46908216>
2705
2706         Reviewed by Geoff Garen.
2707
2708         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2709         (+[Simple3LookupContext sharedLookupContext]):
2710         (-[Simple3LookupContext lookUpURL:completionHandler:]):
2711         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
2712         (TEST):
2713
2714 2019-01-25  Chris Dumez  <cdumez@apple.com>
2715
2716         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
2717         https://bugs.webkit.org/show_bug.cgi?id=193788
2718         <rdar://problem/47531231>
2719
2720         Reviewed by Alex Christensen.
2721
2722         Add API test coverage.
2723
2724         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2725         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
2726
2727 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
2728
2729         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
2730         https://bugs.webkit.org/show_bug.cgi?id=193771
2731
2732         Unreviewed infrastructure fix.
2733
2734         * Scripts/webkitpy/port/darwin.py:
2735         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
2736
2737 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2738
2739         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
2740
2741 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2742
2743         Add contributors.json entries for Ling Ho and for a new bot watchers group.
2744
2745         * Scripts/webkitpy/common/config/contributors.json:
2746
2747 2019-01-25  Chris Dumez  <cdumez@apple.com>
2748
2749         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
2750         https://bugs.webkit.org/show_bug.cgi?id=193779
2751         <rdar://problem/46170903>
2752
2753         Reviewed by Antti Koivisto.
2754
2755         Add API test that quickly navigates forward to a previous process without waiting for it to
2756         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
2757         the process' previous page when reconnecting the it for the forward navigation.
2758
2759         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2760
2761 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2762
2763         Need a way for JavaScript (or bundle) code to participate in undo
2764         https://bugs.webkit.org/show_bug.cgi?id=190009
2765         <rdar://problem/44807048>
2766
2767         Reviewed by Ryosuke Niwa.
2768
2769         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
2770         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
2771
2772         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2773         (WTR::UIScriptController::lastUndoLabel const):
2774         (WTR::UIScriptController::firstRedoLabel const):
2775         (WTR::UIScriptController::platformUndoManager const):
2776         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2777         (WTR::UIScriptController::lastUndoLabel const):
2778         (WTR::UIScriptController::firstRedoLabel const):
2779         (WTR::UIScriptController::platformUndoManager const):
2780         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2781         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2782         (WTR::UIScriptController::lastUndoLabel const):
2783         (WTR::UIScriptController::firstRedoLabel const):
2784         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2785         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2786         (WTR::UIScriptController::lastUndoLabel const):
2787         (WTR::UIScriptController::firstRedoLabel const):
2788         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2789         (WTR::UIScriptController::platformUndoManager const):
2790         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2791         (WTR::UIScriptController::platformUndoManager const):
2792
2793 2019-01-25  Zalan Bujtas  <zalan@apple.com>
2794
2795         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
2796         https://bugs.webkit.org/show_bug.cgi?id=193824
2797
2798         Reviewed by Antti Koivisto.
2799
2800         * LayoutReloaded/misc/LFC-passing-tests.txt:
2801
2802 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
2803
2804         Update macOS JSC bot configurations
2805         https://bugs.webkit.org/show_bug.cgi?id=193739
2806
2807         Reviewed by Alexey Proskuryakov.
2808
2809         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
2810         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2811         (BubbleQueueServer): Move JSC EWS to Mojave section.
2812         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2813         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
2814         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
2815
2816 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
2817
2818         [Win][WebKitTestRunner] Implement EventSenderProxy
2819         https://bugs.webkit.org/show_bug.cgi?id=193755
2820
2821         Reviewed by Don Olmstead.
2822
2823         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
2824         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
2825         (WTR::EventSenderProxy::dispatchMessage):
2826         (WTR::EventSenderProxy::EventSenderProxy):
2827         (WTR::EventSenderProxy::mouseDown):
2828         (WTR::EventSenderProxy::mouseUp):
2829         (WTR::EventSenderProxy::mouseMoveTo):
2830         (WTR::EventSenderProxy::mouseScrollBy):
2831         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2832
2833 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2834
2835         Unreviewed fix for API test failure after r240437.
2836
2837         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
2838
2839         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
2840
2841 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2842
2843         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
2844         https://bugs.webkit.org/show_bug.cgi?id=193787
2845         <rdar://problem/47497634>
2846
2847         Reviewed by Alexey Proskuryakov.
2848
2849         * Scripts/webkitdirs.pm:
2850         (iosSimulatorApplicationsPath): Pick from available runtime directories.
2851
2852 2019-01-24  Truitt Savell  <tsavell@apple.com>
2853
2854         Unreviewed, rolling out r240446.
2855
2856         Casued 5 API failures
2857
2858         Reverted changeset:
2859
2860         "Activate the WebResourceLoadStatisticsStore in the
2861         NetworkProcess and deactivate it in the UIProcess."
2862         https://bugs.webkit.org/show_bug.cgi?id=193297
2863         https://trac.webkit.org/changeset/240446
2864
2865 2019-01-24  Zalan Bujtas  <zalan@apple.com>
2866
2867         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
2868         https://bugs.webkit.org/show_bug.cgi?id=193741
2869         <rdar://problem/47135030>
2870
2871         Reviewed by Antti Koivisto and Simon Fraser.
2872
2873         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2874         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2875         (TestWebKitAPI::TEST):
2876
2877 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
2878
2879         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2880         https://bugs.webkit.org/show_bug.cgi?id=193297
2881         <rdar://problem/47158841>
2882
2883         Reviewed by Alex Christensen.
2884
2885         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2886         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2887         activating the message used to trigger the callback when it is set.
2888
2889 2019-01-24  John Wilander  <wilander@apple.com>
2890
2891         Add Ad Click Attribution as an internal/experimental feature
2892         https://bugs.webkit.org/show_bug.cgi?id=193685
2893         <rdar://problem/47450399>
2894
2895         Reviewed by Brent Fulgham.
2896
2897         Added test option adClickAttributionEnabled.
2898
2899         * DumpRenderTree/TestOptions.cpp:
2900         (TestOptions::TestOptions):
2901         * DumpRenderTree/TestOptions.h:
2902         * DumpRenderTree/mac/DumpRenderTree.mm:
2903         (setWebPreferencesForTestOptions):
2904
2905 2019-01-24  Antti Koivisto  <antti@apple.com>
2906
2907         [PSON] Flash on back navigation on Mac
2908         https://bugs.webkit.org/show_bug.cgi?id=193716
2909         <rdar://problem/47148458>
2910
2911         Reviewed by Chris Dumez.
2912
2913         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2914
2915         Closing of the previous page is delayed so waiting for didFinishNavigation is
2916         not sufficient to guarantee we have received all the messages. Wait for them.
2917
2918 2019-01-24  Chris Dumez  <cdumez@apple.com>
2919
2920         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
2921         https://bugs.webkit.org/show_bug.cgi?id=193761
2922         <rdar://problem/47456405>
2923
2924         Reviewed by Alex Christensen.
2925
2926         Add API test coverage.
2927
2928         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2929
2930 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2931
2932         webkitpy: Missing PID in crashlog name should not be fatal
2933         https://bugs.webkit.org/show_bug.cgi?id=193771
2934
2935         If we can't determine the PID of a crashlog, just ignore the crashlog instead
2936         of raising an exception.
2937
2938         Reviewed by Lucas Forschler.
2939
2940         * Scripts/webkitpy/port/darwin.py:
2941         (DarwinPort._merge_crash_logs):
2942
2943 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2944
2945         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
2946         https://bugs.webkit.org/show_bug.cgi?id=193746
2947
2948         Reviewed by Youenn Fablet.
2949
2950         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
2951         so we'd best just not call it.
2952
2953         * Scripts/webkitpy/w3c/test_exporter.py:
2954         (WebPlatformTestExporter.create_branch_with_patch):
2955
2956 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2957
2958         Move FileSystem to WTF
2959         https://bugs.webkit.org/show_bug.cgi?id=193602
2960
2961         Reviewed by Yusuke Suzuki.
2962
2963         * DumpRenderTree/win/DumpRenderTree.cpp:
2964         * TestWebKitAPI/CMakeLists.txt:
2965         * TestWebKitAPI/PlatformGTK.cmake:
2966         * TestWebKitAPI/PlatformJSCOnly.cmake:
2967         * TestWebKitAPI/PlatformPlayStation.cmake:
2968         * TestWebKitAPI/PlatformWPE.cmake:
2969         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2970         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
2971         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
2972         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2973         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
2974         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
2975         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
2976         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2977         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
2978         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2979
2980 2019-01-24  Philippe Normand  <pnormand@igalia.com>
2981
2982         [WPE] Remove hard dependency on subprocess32 for the API tests
2983
2984         Rubber-stamped by Carlos Garcia Campos.
2985
2986         * glib/api_test_runner.py:
2987         (TestRunner._run_test_qt): Lazily import subprocess32 and check
2988         its presence only when running WPEQt tests.
2989
2990 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2991
2992         [GLIB] Expose JavaScriptCore options in GLib public API
2993         https://bugs.webkit.org/show_bug.cgi?id=188742
2994
2995         Reviewed by Michael Catanzaro.
2996
2997         Add a test for the new API.
2998
2999         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3000         (testsJSCOptions):
3001         (main):
3002
3003 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3004
3005         [GTK][WPE] Support JPEG 2000 images
3006         https://bugs.webkit.org/show_bug.cgi?id=186272
3007
3008         Reviewed by Žan Doberšek.
3009
3010         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
3011
3012         * gtk/jhbuild.modules:
3013         * wpe/jhbuild.modules:
3014
3015 2019-01-23  David Kilzer  <ddkilzer@apple.com>
3016
3017         check-webkit-style should warn when using soft-linking macros in a header
3018         <https://webkit.org/b/193750>
3019
3020         Reviewed by Darin Adler.
3021
3022         * Scripts/webkitpy/style/checkers/cpp.py:
3023         (check_language): Add softlink/header check by refactoring the
3024         softlink/framework check.
3025         (CppChecker): Enable softlink/header check by default.
3026         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3027         (CppStyleTest.test_softlink_framework): Rename from
3028         CppStyleTest.test_softlink() and change test framework name in
3029         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
3030         files. Set file_name for macros that only appear in headers.
3031         (CppStyleTest.test_softlink_header): Add tests for using
3032         soft-link macros in headers.
3033
3034 2019-01-23  Chris Dumez  <cdumez@apple.com>
3035
3036         Deprecate API to limit the maximum number of WebProcesses
3037         https://bugs.webkit.org/show_bug.cgi?id=193725
3038         <rdar://problem/47464879>
3039
3040         Reviewed by Geoff Garen.
3041
3042         Update existing API tests to stop using deprecated API.
3043
3044         * MiniBrowser/mac/AppDelegate.m:
3045         (defaultConfiguration):
3046         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3047         (TestWebKitAPI::TEST):
3048         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
3049         (TestWebKitAPI::TEST):
3050         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3051         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
3052         (TEST):
3053         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3054         (TEST):
3055
3056 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3057
3058         [ews-app] Rename ews model buildermappings to buildermapping
3059         https://bugs.webkit.org/show_bug.cgi?id=193729
3060
3061         Reviewed by Lucas Forschler.
3062
3063         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
3064         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
3065         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
3066
3067 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3068
3069         [ews-app] Rename ews model steps to step
3070         https://bugs.webkit.org/show_bug.cgi?id=193697
3071
3072         Reviewed by Lucas Forschler.
3073
3074         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
3075         (Step): Renamed Steps to Step.
3076
3077 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
3078
3079         Clean up IndexedDB files between tests
3080         https://bugs.webkit.org/show_bug.cgi?id=192796
3081         <rdar://problem/46824999>
3082
3083         Reviewed by Geoffrey Garen.
3084
3085         * DumpRenderTree/mac/DumpRenderTree.mm:
3086         (runTest):
3087         * WebKitTestRunner/TestController.cpp:
3088         (WTR::TestController::resetStateToConsistentValues):
3089         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
3090         (WTR::RemoveAllIndexedDatabasesCallback):
3091         (WTR::TestController::ClearIndexedDatabases):
3092         * WebKitTestRunner/TestController.h:
3093         * WebKitTestRunner/TestInvocation.cpp:
3094         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3095
3096 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3097
3098         [ews-app] Rename ews model Builds to Build
3099         https://bugs.webkit.org/show_bug.cgi?id=193695
3100
3101         Reviewed by Lucas Forschler.
3102
3103         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
3104         (Build): Renamed Builds to Build.
3105
3106 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
3107
3108         webkitpy: Wait longer when launching WebKitTestRunner
3109         https://bugs.webkit.org/show_bug.cgi?id=193734
3110
3111         Reviewed by Aakash Jain.
3112
3113         * Scripts/webkitpy/port/simulator_process.py:
3114         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
3115
3116 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
3117
3118         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
3119         https://bugs.webkit.org/show_bug.cgi?id=193182
3120         <rdar://problem/47452154>
3121
3122         Reviewed by Tim Horton.
3123
3124         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
3125         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
3126         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
3127
3128         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
3129         preventing later tests from recognizing gestures.
3130
3131         * WebKitTestRunner/ios/TestControllerIOS.mm:
3132         (WTR::TestController::platformResetStateToConsistentValues):
3133
3134         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
3135
3136 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
3137
3138         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
3139         https://bugs.webkit.org/show_bug.cgi?id=193722
3140         <rdar://problem/47481475>
3141
3142         Reviewed by Lucas Forschler.
3143
3144         iPhone and iPad ports should both use the iOS config.
3145
3146         * Scripts/webkitpy/port/ios_simulator.py:
3147         (IPhoneSimulatorPort.__init__):
3148         (IPadSimulatorPort.__init__):
3149
3150 2019-01-23  Rob Buis  <rbuis@igalia.com>
3151
3152         Update MIME type parser
3153         https://bugs.webkit.org/show_bug.cgi?id=180526
3154
3155         Reviewed by Frédéric Wang.
3156
3157         Add unit tests for both parse modes of ParsedContentType.
3158
3159         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3160         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
3161         (TestWebKitAPI::TEST):
3162
3163 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
3164
3165         [ews-app] fetch loop should not stop on network issues
3166         https://bugs.webkit.org/show_bug.cgi?id=193666
3167
3168         Reviewed by Lucas Forschler.
3169
3170         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3171         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
3172
3173 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3174
3175         [iOS] Multiple WKWebViewAutofillTests are flaky failures
3176         https://bugs.webkit.org/show_bug.cgi?id=189165
3177         <rdar://problem/47433765>
3178
3179         Reviewed by Tim Horton.
3180
3181         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
3182         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
3183         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
3184         process in sufficient to ensure that any previous action that blurred the focused element in the web process
3185         would make its way to the UI process by the time the layer tree commit is finished.
3186
3187         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
3188         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
3189         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
3190         will fail because it asks for -_autofillContext too early.
3191
3192         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
3193         is handled in the UI process.
3194
3195         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
3196
3197         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
3198         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
3199         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
3200         input session.
3201
3202         (-[AutofillTestView textInputHasAutofillContext]):
3203
3204         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
3205
3206         * TestWebKitAPI/cocoa/TestWKWebView.h:
3207         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3208         (nextInputSessionChangeCount):
3209
3210         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
3211         This includes changing the focused element from one to another.
3212
3213         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
3214         (-[TestWKWebView didStartFormControlInteraction]):
3215         (-[TestWKWebView didEndFormControlInteraction]):
3216         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
3217
3218         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
3219         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
3220         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
3221         that doesn't require an input session to one that doesn't.
3222
3223 2019-01-22  David Kilzer  <ddkilzer@apple.com>
3224
3225         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
3226         <https://webkit.org/b/193676>
3227
3228         Reviewed by Alexey Proskuryakov.
3229
3230         * Scripts/webkitpy/style/checkers/cpp.py:
3231         (check_member_initialization_list):
3232         - Don't report missing whitespace around colon if the colon at
3233           the start of the line is formatted correctly.
3234         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3235         (WebKitStyleTest.test_member_initialization_list):
3236         - Add a test for a missing permutation of existing tests.
3237         - Add a test this false-positive.
3238         - Add blank lines between subtests to make them easier to read.
3239
3240 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
3241
3242         [build.webkit.org] Unit-test failure after r237113
3243         https://bugs.webkit.org/show_bug.cgi?id=193669
3244
3245         Reviewed by Michael Catanzaro.
3246
3247         * BuildSlaveSupport/build.webkit.org-config/factories.py:
3248         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
3249         multiple or zero flags.
3250
3251 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
3252
3253         Cache bytecode to disk
3254         https://bugs.webkit.org/show_bug.cgi?id=192782
3255         <rdar://problem/46084932>
3256
3257         Reviewed by Keith Miller.
3258
3259         Add test helper to execute bytecode-cache tests: it executes each test
3260         twice, the first with JSC_diskCachePath set to a temporary directory
3261         and second with JSC_forceDiskCache=true (in addition to the cache path)
3262         to guarantee that only the disk cache is being used and no new
3263         UnlinkedCodeBlocks are being created.
3264
3265         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
3266         * Scripts/run-jsc-stress-tests:
3267
3268 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
3269
3270         [css-logical] Implement flow-relative margin, padding and border shorthands
3271         https://bugs.webkit.org/show_bug.cgi?id=188697
3272
3273         Reviewed by Simon Fraser and Antti Koivisto.
3274
3275         * DumpRenderTree/TestOptions.cpp:
3276         (TestOptions::TestOptions):
3277         * DumpRenderTree/TestOptions.h:
3278         * DumpRenderTree/mac/DumpRenderTree.mm:
3279         (setWebPreferencesForTestOptions):
3280         Allow tests to enable the CSSLogicalEnabled flag in WK1.
3281
3282         * Scripts/webkitpy/style/checkers/jsonchecker.py:
3283         (JSONCSSPropertiesChecker.check_codegen_properties):
3284         Allow CSS property definitions to have a 'runtime-flag' parameter which
3285         disables the property when the specified runtime flag is disabled.
3286
3287 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
3288
3289         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
3290         https://bugs.webkit.org/show_bug.cgi?id=193643
3291
3292         Reviewed by Michael Catanzaro.
3293
3294         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
3295         * wpe/jhbuild.modules: Ditto.
3296
3297 2019-01-21  Zalan Bujtas  <zalan@apple.com>
3298
3299         [LFC][Floats] Take float top position into account when computing containing block height.
3300         https://bugs.webkit.org/show_bug.cgi?id=193655
3301
3302         Reviewed by Antti Koivisto.
3303
3304         * LayoutReloaded/misc/LFC-passing-tests.txt:
3305
3306 2019-01-21  David Kilzer  <ddkilzer@apple.com>
3307
3308         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
3309         <https://webkit.org/b/193645>
3310         <rdar://problem/47421574>
3311
3312         Reviewed by Alex Christensen.
3313
3314         - Now checks for local soft-linking of all frameworks that have
3315           their own *SoftLinking.{cpp,h,mm} files.
3316         - Changes softlink/uikit warning to softlink/framework.
3317
3318         * Scripts/webkitpy/style/checkers/cpp.py:
3319         (check_language):
3320         (CppChecker):
3321         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3322         (CppStyleTest):
3323
3324 2019-01-20  Saam Barati  <sbarati@apple.com>
3325
3326         Rollout r240210: It broke tests on iOS
3327         https://bugs.webkit.org/show_bug.cgi?id=193640
3328
3329         Unreviewed.
3330
3331         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
3332         * Scripts/run-jsc-stress-tests:
3333
3334 2019-01-20  chris fleizach  <cfleizach@apple.com>
3335
3336         AX: Support returning relative frames for accessibility
3337         https://bugs.webkit.org/show_bug.cgi?id=193414
3338         <rdar://problem/47268501>
3339
3340         Reviewed by Zalan Bujtas.
3341
3342         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3343         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3344         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3345         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3346         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3347         (WTR::attributesOfElement):
3348         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3349
3350 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
3351
3352         Unreviewed, add my new email address
3353
3354         * Scripts/webkitpy/common/config/contributors.json:
3355
3356 2019-01-19  Zalan Bujtas  <zalan@apple.com>
3357
3358         [LFC][BFC] <body>'s overflow property value is propagated to viewport
3359         https://bugs.webkit.org/show_bug.cgi?id=193617
3360
3361         Reviewed by Antti Koivisto.
3362
3363         * LayoutReloaded/misc/LFC-passing-tests.txt:
3364
3365 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
3366
3367         Unreviewed, rolling out r240209.
3368
3369         Broke GTK/WPE injected bundle
3370
3371         Reverted changeset:
3372
3373         "AX: Support returning relative frames for accessibility"
3374         https://bugs.webkit.org/show_bug.cgi?id=193414
3375         https://trac.webkit.org/changeset/240209
3376
3377 2019-01-12  Dan Bernstein  <mitz@apple.com>
3378
3379         [Cocoa] Avoid importing directly from subumbrella frameworks
3380         https://bugs.webkit.org/show_bug.cgi?id=186016
3381         <rdar://problem/40591038>
3382
3383         Reviewed by Sam Weinig.
3384
3385         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
3386           LaunchServices header.
3387         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3388           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3389         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
3390           when using SDKs earlier than 10.13.
3391         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
3392           and OTHER_CPLUSPLUSFLAGS.
3393         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3394           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3395         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
3396           LaunchServices header.
3397
3398 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
3399
3400         Cache bytecode to disk
3401         https://bugs.webkit.org/show_bug.cgi?id=192782
3402         <rdar://problem/46084932>
3403
3404         Reviewed by Keith Miller.
3405
3406         Add test helper to execute bytecode-cache tests: it executes each test
3407         twice, the first with JSC_diskCachePath set to a temporary directory
3408         and second with JSC_forceDiskCache=true (in addition to the cache path)
3409         to guarantee that only the disk cache is being used and no new
3410         UnlinkedCodeBlocks are being created.
3411
3412         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
3413         * Scripts/run-jsc-stress-tests:
3414
3415 2019-01-20  chris fleizach  <cfleizach@apple.com>
3416
3417         AX: Support returning relative frames for accessibility
3418         https://bugs.webkit.org/show_bug.cgi?id=193414
3419         <rdar://problem/47268501>
3420
3421         Reviewed by Zalan Bujtas.
3422
3423         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3424         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3425         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3426         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3427         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3428         (WTR::attributesOfElement):
3429         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3430
3431 2019-01-20  Antoine Quint  <graouts@apple.com>
3432
3433         Add a POINTER_EVENTS feature flag
3434         https://bugs.webkit.org/show_bug.cgi?id=193577
3435         <rdar://problem/47408511>
3436
3437         Unreviewed. Also enable Pointer Events for iosmac.
3438
3439         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3440
3441 2019-01-19  Zalan Bujtas  <zalan@apple.com>
3442
3443         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
3444         https://bugs.webkit.org/show_bug.cgi?id=193613
3445
3446         Reviewed by Antti Koivisto.
3447
3448         * LayoutReloaded/misc/LFC-passing-tests.txt:
3449
3450 2019-01-19  Antoine Quint  <graouts@apple.com>
3451
3452         Add a POINTER_EVENTS feature flag
3453         https://bugs.webkit.org/show_bug.cgi?id=193577
3454
3455         Reviewed by Dean Jackson.
3456
3457         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3458
3459 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
3460
3461         Disable the run-jsc-stress-test remote host key check [second round].
3462         https://bugs.webkit.org/show_bug.cgi?id=192988
3463
3464         Reviewed by Dewei Zhu.
3465
3466         * Scripts/run-jsc-stress-tests:
3467
3468 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3469
3470         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
3471         https://bugs.webkit.org/show_bug.cgi?id=193597
3472
3473         Reviewed by Lucas Forschler.
3474
3475         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3476
3477 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3478
3479         [build.webkit.org] api tests failures are incorrectly named as unit test failures
3480         https://bugs.webkit.org/show_bug.cgi?id=193595
3481
3482         Reviewed by Lucas Forschler.
3483
3484         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
3485         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
3486         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
3487
3488 2019-01-18  Chris Dumez  <cdumez@apple.com>
3489
3490         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
3491         https://bugs.webkit.org/show_bug.cgi?id=193588
3492         <rdar://problem/47131566>
3493
3494         Reviewed by Alex Christensen.
3495
3496         Add layout test coverage.
3497
3498         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3499
3500 2019-01-18  Jer Noble  <jer.noble@apple.com>
3501
3502         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3503         https://bugs.webkit.org/show_bug.cgi?id=189553
3504
3505         Reviewed by Tim Horton.
3506
3507         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3508
3509         * ContentExtensionTester/Configurations/Base.xcconfig:
3510         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3511         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3512         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3513         * ImageDiff/cg/Configurations/Base.xcconfig:
3514         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3515         * MiniBrowser/Configurations/Base.xcconfig:
3516         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3517         * MobileMiniBrowser/Configurations/Base.xcconfig:
3518         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3519         * Scripts/webkitpy/style/checker.py:
3520         (_all_categories):
3521         (FileType):
3522         (CheckerDispatcher._file_type):
3523         (CheckerDispatcher._create_checker):
3524         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3525         (SDKVariantChecker):
3526         (SDKVariantChecker.__init__):
3527         (SDKVariantChecker.check):
3528         * TestWebKitAPI/Configurations/Base.xcconfig:
3529         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3530         * WebEditingTester/Configurations/Base.xcconfig:
3531         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3532         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3533         * WebKitTestRunner/Configurations/Base.xcconfig:
3534         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3535         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3536         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3537
3538 2019-01-18  David Kilzer  <ddkilzer@apple.com>
3539
3540         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
3541         <https://webkit.org/b/193568>
3542         <rdar://problem/47381130>
3543
3544         Reviewed by Alex Christensen.
3545
3546         Make sure no one re-introduces UIKit soft-linking by adding a
3547         style rule.
3548
3549         * Scripts/webkitpy/style/checkers/cpp.py:
3550         (check_language): Add softlink/uikit check.
3551         (CppChecker): Enable softlink/uikit check.
3552         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3553         (CppStyleTest): Add test for softlink/uikit.
3554
3555 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
3556
3557         [GTK] install-dependencies tool looks for libunistring-dev for dnf
3558         https://bugs.webkit.org/show_bug.cgi?id=193584
3559
3560         Change "-dev" to "-devel".
3561
3562         Reviewed by Michael Catanzaro.
3563
3564         * gtk/install-dependencies:
3565
3566 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3567
3568         webkitpy: Add iPhone and iPad ports
3569         https://bugs.webkit.org/show_bug.cgi?id=193537
3570         <rdar://problem/47353390>
3571
3572         Reviewed by Lucas Forschler.
3573
3574         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
3575         ports. Note that this separation is optional, the --ios-simulator command remains.
3576
3577         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3578         (RunTest.test_device_type_test_division): Drive-by fix.
3579         (RunTest.test_device_type_specific_listing): Ditto.
3580         (RunTest.test_ipad_test_division):
3581         (RunTest):
3582         (RunTest.test_ipad_listing):
3583         * Scripts/webkitpy/port/factory.py:
3584         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
3585         (PortFactory):
3586         * Scripts/webkitpy/port/ios_simulator.py:
3587         (IPhoneSimulatorPort):
3588         (IPadSimulatorPort):
3589
3590 2019-01-18  Chris Dumez  <cdumez@apple.com>
3591
3592         Regression(PSON) Scroll position is not always restored properly when navigating back
3593         https://bugs.webkit.org/show_bug.cgi?id=193578
3594         <rdar://problem/47386331>
3595
3596         Reviewed by Tim Horton.
3597
3598         Add API test coverage.
3599
3600         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3601
3602 2019-01-18  Youenn Fablet  <youenn@apple.com>
3603
3604         Add a new SPI to request for cache storage quota increase
3605         https://bugs.webkit.org/show_bug.cgi?id=193323
3606
3607         Reviewed by Alex Christensen.
3608
3609         Implement WebsiteDataStore quota delegate to handle quota requests.
3610         By default, do not update quota.
3611         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
3612
3613         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3614         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3615         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
3616         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3617         * WebKitTestRunner/TestController.cpp:
3618         (WTR::TestController::allowCacheStorageQuotaIncrease):
3619         * WebKitTestRunner/TestController.h:
3620         * WebKitTestRunner/TestInvocation.cpp:
3621         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3622         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3623         (-[CacheStorageQuotaManager init]):
3624         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3625         (WTR::initializeWebViewConfiguration):
3626         (WTR::TestController::cocoaResetStateToConsistentValues):
3627         (WTR::TestController::allowCacheStorageQuotaIncrease):
3628
3629 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3630
3631         [ews-build] Pass owner to the triggered builds
3632         https://bugs.webkit.org/show_bug.cgi?id=193574
3633
3634         Reviewed by Lucas Forschler.
3635
3636         * BuildSlaveSupport/ews-build/factories.py:
3637         (BuildFactory.propertiesToPassToTriggers):
3638
3639 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3640
3641         [ews-app] Send patch author as a build property
3642         https://bugs.webkit.org/show_bug.cgi?id=193560
3643
3644         Reviewed by Lucas Forschler.
3645
3646         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3647         (BugzillaPatchFetcher.fetch):
3648
3649 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3650
3651         webkitpy: Implement device type specific expected results (Follow-up fix)
3652         https://bugs.webkit.org/show_bug.cgi?id=192162
3653         <rdar://problem/46345449>
3654
3655         Unreviewed infrastructure fix.
3656
3657         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3658         (Manager.run): Don't boot a device if no tests are available to run on it.
3659
3660 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3661
3662         webkitpy: Implement device type specific expected results (Follow-up fix)
3663         https://bugs.webkit.org/show_bug.cgi?id=192162
3664         <rdar://problem/46345449>
3665
3666         Unreviewed infrastructure fix.
3667
3668         * Scripts/webkitpy/api_tests/manager.py:
3669         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
3670
3671 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3672
3673         webkitpy: Implement device type specific expected results (Part 2)
3674         https://bugs.webkit.org/show_bug.cgi?id=192162
3675         <rdar://problem/46345449>
3676
3677         Rubber-stamped by Aakash Jain.
3678
3679         This change uses device_type to select a different set of TestExpectation files based on the type of device running
3680         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
3681         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
3682
3683         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
3684         (LayoutTestFinder.find_tests): Pass device_type through.
3685         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
3686         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
3687         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3688         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
3689         (Manager._collect_tests): Pass device type to test finder.
3690         (Manager._needs_web_platform_test):
3691         (Manager._prepare_lists): Index _expectations by device type.
3692         (Manager._test_input_for_file):
3693         (Manager._test_is_slow): Ditto.
3694         (Manager._test_should_dump_jsconsolelog_in_stderr):
3695         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
3696         (Manager._get_test_inputs):
3697         (Manager._update_worker_count):
3698         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
3699         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
3700         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
3701         the one which runs the test.
3702         (Manager._run_test_subset):
3703         (Manager._run_tests): Index _expectations by current_device_type.
3704         (Manager._print_expectation_line_for_test): Ditto.
3705         (Manager._print_expectations_for_subset): Ditto.
3706         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
3707         Unlike run, this function will behave the same regardless of what devices are available.
3708         (Manager._custom_device_for_test): Deleted.
3709         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3710         (ManagerTest.test_uses_custom_device): Deleted.
3711         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
3712         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3713         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
3714         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
3715         all of the expectations.
3716         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
3717         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
3718         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3719         (TestExpectations.__init__): Allow device_type to be passed through.
3720         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
3721         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
3722         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3723         (summarize_results):
3724         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
3725         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
3726         a test ran with, one must check all expectations to find the first non-skip expectation.
3727         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3728         (RunTest.test_device_type_test_division):
3729         (RunTest):
3730         (RunTest.test_device_type_specific_listing):
3731         * Scripts/webkitpy/port/base.py:
3732         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
3733         (Port.supported_device_types): The result of this function will change based on what devices are available.
3734         * Scripts/webkitpy/port/device_port.py:
3735         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
3736         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
3737         can be used.
3738         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
3739         any, or the DEFAULT_DEVICE_TYPES of the port.
3740         * Scripts/webkitpy/port/ios.py:
3741         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
3742         * Scripts/webkitpy/port/ios_simulator.py:
3743         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
3744         * Scripts/webkitpy/port/watch.py:
3745         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
3746         * Scripts/webkitpy/port/watch_simulator.py:
3747         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
3748         * Scripts/webkitpy/xcode/device_type.py:
3749         (DeviceType):
3750         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
3751
3752 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3753
3754         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
3755         https://bugs.webkit.org/show_bug.cgi?id=193575
3756
3757         Reviewed by Michael Catanzaro.
3758
3759         Allow the script to run without explicit port argument because
3760         it's specific to the WPE port anyway.
3761
3762         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
3763         and simplify the rest of the code accordingly.
3764
3765 2019-01-18  Charlie Turner  <cturner@igalia.com>
3766
3767         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
3768         https://bugs.webkit.org/show_bug.cgi?id=192229
3769
3770         Reviewed by Xabier Rodriguez-Calvar.
3771
3772         * MiniBrowser/wpe/main.cpp:
3773         (main): Enable encrypted-media by default.
3774
3775 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3776
3777         [Flatpak] Missing KeyboardInterrupt exception handler
3778         https://bugs.webkit.org/show_bug.cgi?id=193570
3779
3780         Reviewed by Michael Catanzaro.
3781
3782         * flatpak/flatpakutils.py:
3783         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
3784
3785 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3786
3787         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
3788         https://bugs.webkit.org/show_bug.cgi?id=193564
3789
3790         Reviewed by Antti Koivisto.
3791
3792         * LayoutReloaded/misc/LFC-passing-tests.txt:
3793
3794 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3795
3796         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
3797         https://bugs.webkit.org/show_bug.cgi?id=193562
3798
3799         Reviewed by Antti Koivisto.
3800
3801         * LayoutReloaded/misc/LFC-passing-tests.txt:
3802
3803 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3804
3805         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
3806         https://bugs.webkit.org/show_bug.cgi?id=193555
3807
3808         Reviewed by Antti Koivisto.
3809
3810         * LayoutReloaded/misc/LFC-passing-tests.txt:
3811
3812 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3813
3814         [WPE] Add Qt extension
3815         https://bugs.webkit.org/show_bug.cgi?id=191464
3816
3817         Reviewed by Carlos Garcia Campos.
3818
3819         MiniBrowser and API tests for the WPE Qt API. To run the
3820         MiniBrowser a new script is introduced. Example invocation:
3821
3822         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
3823
3824         Also note-worthy is the introduction of the python2-subprocess32
3825         dependency to run the GLib API tests.
3826
3827         * MiniBrowser/wpe/CMakeLists.txt:
3828         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
3829         * MiniBrowser/wpe/qt/main.cpp: Added.
3830         (main):
3831         * MiniBrowser/wpe/qt/main.qml: Added.
3832         * MiniBrowser/wpe/qt/qml.qrc: Added.
3833         * Scripts/run-gtk-tests:
3834         (GtkTestRunner.is_google_test):
3835         (GtkTestRunner):
3836         (GtkTestRunner.is_qt_test):
3837         * Scripts/run-qt-wpe-minibrowser: Added.
3838         * Scripts/run-wpe-tests:
3839         (WPETestRunner):
3840         (WPETestRunner.is_google_test):
3841         (WPETestRunner.is_qt_test):
3842         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
3843         (TestLoad::main):
3844         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
3845         (TestLoadHtml::main):
3846         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
3847         (TestLoadRequest::main):
3848         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
3849         (TestRunJavaScript::main):
3850         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
3851         (waitForSignal):
3852         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
3853         (LoadSpy::LoadSpy):
3854         (LoadSpy::~LoadSpy):
3855         (LoadSpy::onLoadingChanged):
3856         (LoadStartedCatcher::LoadStartedCatcher):
3857         (LoadStartedCatcher::~LoadStartedCatcher):
3858         (LoadStartedCatcher::onLoadingChanged):
3859         (waitForLoadSucceeded):
3860         (waitForLoadFailed):
3861         * TestWebKitAPI/glib/CMakeLists.txt:
3862         * flatpak/flatpakutils.py:
3863         (WebkitFlatpak.load_from_args):
3864         (WebkitFlatpak.__init__):
3865         (WebkitFlatpak.clean_args):
3866         (WebkitFlatpak.run_in_sandbox):
3867         * flatpak/org.webkit.CommonModules.yaml:
3868         * flatpak/org.webkit.WPE.yaml:
3869         * flatpak/org.webkit.WPEModules.yaml:
3870         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
3871         * flatpak/org.webkit.WebKit.yaml:
3872         * glib/api_test_runner.py:
3873         (TestRunner._run_test_qt):
3874         (TestRunner.is_qt_test):
3875         (TestRunner._run_test):
3876
3877 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3878
3879         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
3880         https://bugs.webkit.org/show_bug.cgi?id=193494
3881         <rdar://problem/46859627>
3882
3883         Reviewed by Simon Fraser and Tim Horton.
3884
3885         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
3886         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
3887
3888         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3889         (WTR::UIScriptController::contentOffsetX const):
3890         (WTR::UIScriptController::contentOffsetY const):
3891         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3892         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3893         (WTR::UIScriptController::contentOffsetX const):
3894         (WTR::UIScriptController::contentOffsetY const):
3895         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3896
3897         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
3898
3899         * WebKitTestRunner/TestController.cpp:
3900         (WTR::updateTestOptionsFromTestHeader):
3901         * WebKitTestRunner/TestOptions.h:
3902         (WTR::TestOptions::hasSameInitializationOptions const):
3903         * WebKitTestRunner/ios/TestControllerIOS.mm:
3904         (WTR::TestController::platformResetStateToConsistentValues):
3905         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3906         (WTR::UIScriptController::contentOffsetX const):
3907         (WTR::UIScriptController::contentOffsetY const):
3908
3909 2019-01-17  Truitt Savell  <tsavell@apple.com>
3910
3911         Unreviewed, rolling out r240124.
3912
3913         This commit broke an internal build.
3914
3915         Reverted changeset:
3916
3917         "SDK_VARIANT build destinations should be separate from non-
3918         SDK_VARIANT builds"
3919         https://bugs.webkit.org/show_bug.cgi?id=189553
3920         https://trac.webkit.org/changeset/240124
3921
3922 2019-01-17  Alex Christensen  <achristensen@webkit.org>
3923
3924         Fix string concatenation API test after r239920
3925         https://bugs.webkit.org/show_bug.cgi?id=193551
3926         <rdar://problem/47359304>
3927
3928         Reviewed by Youenn Fablet.
3929
3930         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
3931         (TestWebKitAPI::TEST):
3932         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
3933         in WebKit's build configuration like it apparently is on Linux.
3934
3935 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3936
3937         [ews-build] validate-patch should handle the case when bug_id is None
3938         https://bugs.webkit.org/show_bug.cgi?id=193547
3939
3940         Reviewed by Lucas Forschler.
3941
3942         * BuildSlaveSupport/ews-build/steps.py:
3943         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
3944         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
3945
3946 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3947
3948         [ews-build] Add patch author information in build
3949         https://bugs.webkit.org/show_bug.cgi?id=193465
3950
3951         Reviewed by Lucas Forschler.
3952
3953         * BuildSlaveSupport/ews-build/steps.py:
3954         (ValidatePatch._is_patch_obsolete):
3955
3956 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3957
3958         [ews-build] Pass bug_id to the triggered builds
3959         https://bugs.webkit.org/show_bug.cgi?id=193548
3960
3961         Reviewed by Lucas Forschler.
3962
3963         * BuildSlaveSupport/ews-build/factories.py:
3964         (BuildFactory.propertiesToPassToTriggers):
3965
3966 2019-01-17  Jer Noble  <jer.noble@apple.com>
3967
3968         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3969         https://bugs.webkit.org/show_bug.cgi?id=189553
3970
3971         Reviewed by Tim Horton.
3972
3973         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3974
3975         * ContentExtensionTester/Configurations/Base.xcconfig:
3976         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3977         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3978         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3979         * ImageDiff/cg/Configurations/Base.xcconfig:
3980         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3981         * MiniBrowser/Configurations/Base.xcconfig:
3982         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3983         * MobileMiniBrowser/Configurations/Base.xcconfig:
3984         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3985         * Scripts/webkitpy/style/checker.py:
3986         (_all_categories):
3987         (FileType):
3988         (CheckerDispatcher._file_type):
3989         (CheckerDispatcher._create_checker):
3990         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3991         (SDKVariantChecker):
3992         (SDKVariantChecker.__init__):
3993         (SDKVariantChecker.check):
3994         * TestWebKitAPI/Configurations/Base.xcconfig:
3995         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3996         * WebEditingTester/Configurations/Base.xcconfig:
3997         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3998         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3999         * WebKitTestRunner/Configurations/Base.xcconfig:
4000         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
4001         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
4002         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
4003
4004 2019-01-17  Zalan Bujtas  <zalan@apple.com>
4005
4006         [LFC][BFC] An element with transform is a containing block for positioned descendants.
4007         https://bugs.webkit.org/show_bug.cgi?id=193534
4008
4009         Reviewed by Antti Koivisto.
4010
4011         * LayoutReloaded/misc/LFC-passing-tests.txt:
4012
4013 2019-01-17  Zalan Bujtas  <zalan@apple.com>
4014
4015         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
4016         https://bugs.webkit.org/show_bug.cgi?id=193528
4017
4018         Reviewed by Antti Koivisto.
4019
4020         * LayoutReloaded/misc/LFC-passing-tests.txt:
4021
4022 2019-01-17  Zalan Bujtas  <zalan@apple.com>
4023
4024         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
4025         https://bugs.webkit.org/show_bug.cgi?id=193520
4026
4027         Reviewed by Antti Koivisto.
4028
4029         * LayoutReloaded/misc/LFC-passing-tests.txt:
4030
4031 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
4032
4033         [ews-build] unapply-patch step should not update source
4034         https://bugs.webkit.org/show_bug.cgi?id=193234
4035
4036         Reviewed by Lucas Forschler.
4037
4038         * BuildSlaveSupport/ews-build/steps.py:
4039         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
4040         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
4041
4042 2019-01-16  Youenn Fablet  <youenn@apple.com>
4043
4044         Add a new SPI for controlling getUserMedia
4045         https://bugs.webkit.org/show_bug.cgi?id=192793
4046
4047         Reviewed by Eric Carlson.
4048
4049         * MiniBrowser/mac/WK2BrowserWindowController.m:
4050         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
4051         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
4052         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
4053         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
4054         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
4055         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
4056         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
4057         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
4058         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
4059         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
4060         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
4061         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
4062         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
4063         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
4064
4065 2019-01-16  Zalan Bujtas  <zalan@apple.com>
4066
4067         [LFC][BFC] Inflow non-replaced used width should not be negative.
4068         https://bugs.webkit.org/show_bug.cgi?id=193495
4069
4070         Reviewed by Antti Koivisto.
4071
4072         * LayoutReloaded/misc/LFC-passing-tests.txt:
4073
4074 2019-01-16  Chris Dumez  <cdumez@apple.com>
4075
4076         Regression(PSON) View becomes blank after click a cross-site download link
4077         https://bugs.webkit.org/show_bug.cgi?id=193361
4078         <rdar://problem/47099573>
4079
4080         Reviewed by Geoffrey Garen.
4081
4082         Add API test coverage.
4083
4084         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4085         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
4086
4087 2019-01-16  Zalan Bujtas  <zalan@apple.com>
4088
4089         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
4090         https://bugs.webkit.org/show_bug.cgi?id=193470
4091
4092         Reviewed by Antti Koivisto.
4093
4094         * LayoutReloaded/misc/LFC-passing-tests.txt:
4095
4096 2019-01-16  Zalan Bujtas  <zalan@apple.com>
4097
4098         [LFC] Adjust margin box verification.
4099         https://bugs.webkit.org/show_bug.cgi?id=193482
4100
4101         Reviewed by Antti Koivisto.
4102
4103         * LayoutReloaded/misc/LFC-passing-tests.txt:
4104
4105 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
4106
4107         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
4108         https://bugs.webkit.org/show_bug.cgi?id=193451
4109
4110         Reviewed by Geoffrey Garen.
4111
4112         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
4113         (TEST):
4114         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
4115         (runWebsiteDataStoreCustomPaths):
4116
4117 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
4118
4119         webkitpy: Support boolean simctl isAvailable
4120         https://bugs.webkit.org/show_bug.cgi?id=193472
4121         <rdar://problem/47296150>
4122
4123         Reviewed by Ryosuke Niwa.
4124
4125         * Scripts/webkitpy/xcode/simulated_device.py:
4126         (SimulatedDeviceManager._create_runtimes):
4127         (SimulatedDeviceManager._create_device_with_runtime):
4128
4129 2019-01-15  Chris Dumez  <cdumez@apple.com>
4130
4131         Unreviewed, rolling out r239993, r239995, r239997, and
4132         r239999.
4133
4134         Caused assertions under
4135         ViewGestureController::disconnectFromProcess()
4136
4137         Reverted changesets:
4138
4139         "Regression(PSON) View becomes blank after click a cross-site
4140         download link"
4141         https://bugs.webkit.org/show_bug.cgi?id=193361
4142         https://trac.webkit.org/changeset/239993
4143
4144         "Unreviewed iOS build fix after r239993."
4145         https://trac.webkit.org/changeset/239995
4146
4147         "Fix iOS build after r239993"
4148         https://bugs.webkit.org/show_bug.cgi?id=193361
4149         https://trac.webkit.org/changeset/239997
4150
4151         "Unreviewed, revert part of r239997 as it is not needed to fix
4152         the build."
4153         https://trac.webkit.org/changeset/239999
4154
4155 2019-01-15  Tim Horton  <timothy_horton@apple.com>
4156
4157         Cannot tab out of WKWebView on macOS
4158         https://bugs.webkit.org/show_bug.cgi?id=161448
4159         <rdar://problem/28100085>
4160
4161         Reviewed by Dean Jackson.
4162
4163         Add a test that tabbing into and out of WKWebView works correctly.
4164
4165         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4166         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
4167         (WebKit2_CommandBackForwardTest::SetUp):
4168         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
4169         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
4170         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
4171         (-[FocusableView canBecomeKeyView]):
4172         (TEST):
4173         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
4174         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
4175         (-[OffscreenWindow initWithSize:]):
4176         (-[OffscreenWindow isKeyWindow]):
4177         (-[OffscreenWindow isVisible]):
4178         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
4179         (TestWebKitAPI::PlatformWebView::initialize):
4180         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
4181         (-[ActiveOffscreenWindow isVisible]): Deleted.
4182         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
4183
4184 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
4185
4186         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
4187         https://bugs.webkit.org/show_bug.cgi?id=193459
4188
4189         Reviewed by Mark Lam.
4190
4191         * BuildSlaveSupport/build.webkit.org-config/steps.py:
4192         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
4193
4194 2019-01-15  Chris Dumez  <cdumez@apple.com>
4195
4196         Regression(PSON) View becomes blank after click a cross-site download link
4197         https://bugs.webkit.org/show_bug.cgi?id=193361
4198         <rdar://problem/47099573>
4199
4200         Reviewed by Geoff Garen.
4201
4202         Add API test coverage.
4203
4204         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4205         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
4206
4207 2019-01-15  Zalan Bujtas  <zalan@apple.com>
4208
4209         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
4210         https://bugs.webkit.org/show_bug.cgi?id=193448
4211
4212         Reviewed by Antti Koivisto.
4213
4214         * LayoutReloaded/misc/LFC-passing-tests.txt:
4215
4216 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
4217
4218         webkitpy: Implement device type specific expected results (Part 1)
4219         https://bugs.webkit.org/show_bug.cgi?id=192162
4220
4221         Reviewed by Lucas Forschler.
4222
4223         Device type specific expected results covers two related ideas. The first (covered by this change)
4224         is where to search for -expected.* files. The second is which tests to run based on the
4225         TestExpectations.txt file.
4226
4227         After this change, the baseline search path will be determined by the type of device running a
4228         test. Device type will be passed into any function which picks a file based on the baseline search
4229         path.
4230
4231         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
4232         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
4233         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4234         (Manager.run): Print baseline search path for each round of devices.
4235         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
4236         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
4237         (SingleTestRunner._expected_driver_output): Ditto.
4238         (SingleTestRunner._driver_input): Ditto.
4239         * Scripts/webkitpy/layout_tests/views/printing.py:
4240         (Printer.print_config): Move printing of baseline search path to a separate function.
4241         (Printer.print_baseline_search_path): Moved from Printer.print_config.
4242         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
4243         (Testprinter.test_print_config):
4244         (Testprinter.test_print_baseline_search_path):
4245         * Scripts/webkitpy/port/base.py:
4246         (Port.baseline_search_path): Pass device_type through.
4247         (Port._expected_baselines_for_suffixes): Ditto.
4248         (Port.expected_baselines): Ditto.
4249         (Port.expected_filename): Ditto.
4250         (Port.expected_checksum): Ditto.
4251         (Port.expected_image): Ditto.
4252         (Port.expected_audio): Ditto.
4253         (Port.expected_text): Ditto.
4254         (Port.reference_files): Ditto.
4255         (Port.tests): Ditto.
4256         (Port._expanded_paths): Ditto.
4257         (Port.skipped_layout_tests): Ditto.
4258         (Port.expectations_dict): Ditto.
4259         (Port._port_specific_expectations_files): Ditto.
4260         (Port.expectations_files): Ditto.
4261         (Port.test_search_path): Ditto.
4262         (Port._tests_for_other_platforms): Ditto.
4263         * Scripts/webkitpy/port/base_unittest.py:
4264         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
4265         (PortTest.test_nonexistant_expectations): Ditto.
4266         (test_ref_tests_platform_directory): Ditto.
4267         * Scripts/webkitpy/port/darwin.py:
4268         (DarwinPort._port_specific_expectations_files): Accept device_type.
4269         * Scripts/webkitpy/port/driver.py:
4270         (DriverProxy):
4271         (DriverProxy.host): Expose _target_host for device_type information.
4272         * Scripts/webkitpy/port/gtk.py:
4273         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
4274         * Scripts/webkitpy/port/ios.py:
4275         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
4276         * Scripts/webkitpy/port/mac.py:
4277         (MacPort. default_baseline_search_path): Ditto.
4278         * Scripts/webkitpy/port/port_testcase.py:
4279         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
4280         * Scripts/webkitpy/port/test.py:
4281         * Scripts/webkitpy/port/watch.py:
4282         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
4283         * Scripts/webkitpy/port/win.py:
4284         (WinPort.test_search_path): Accept, but do not use, device_type.
4285         * Scripts/webkitpy/port/wpe.py:
4286         (WPEPort._port_specific_expectations_files): Ditto.
4287         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
4288         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
4289
4290 2019-01-15  Zalan Bujtas  <zalan@apple.com>
4291
4292         [LFC] Use the containing block's padding box to position out-of-flow elements.
4293         https://bugs.webkit.org/show_bug.cgi?id=193431
4294
4295         Reviewed by Antti Koivisto.
4296
4297         * LayoutReloaded/misc/LFC-passing-tests.txt:
4298
4299 2019-01-14  Tim Horton  <timothy_horton@apple.com>
4300
4301         Move a test implementation file that got misplaced in the Xcode project
4302
4303         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4304
4305 2019-01-14  Commit Queue  <commit-queue@webkit.org>
4306
4307         Unreviewed, rolling out r239901, r239909, r239910, r239912,
4308         r239913, and r239914.
4309         https://bugs.webkit.org/show_bug.cgi?id=193407
4310
4311         These revisions caused an internal failure (Requested by
4312         Truitt on #webkit).
4313
4314         Reverted changesets:
4315
4316         "[Cocoa] Avoid importing directly from subumbrella frameworks"
4317         https://bugs.webkit.org/show_bug.cgi?id=186016
4318         https://trac.webkit.org/changeset/239901
4319
4320         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
4321         https://trac.webkit.org/changeset/239909
4322
4323         "Tried to fix the build."
4324         https://trac.webkit.org/changeset/239910
4325
4326         "Fixed iOS builds after r239910."
4327         https://trac.webkit.org/changeset/239912
4328
4329         "More build fixing."
4330         https://trac.webkit.org/changeset/239913
4331
4332         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
4333         https://trac.webkit.org/changeset/239914
4334
4335 2019-01-14  Mark Lam  <mark.lam@apple.com>
4336
4337         Re-enable ability to build --cloop builds.
4338         https://bugs.webkit.org/show_bug.cgi?id=192955
4339         <rdar://problem/46882363>
4340
4341         Reviewed by Saam barati and Keith Miller.
4342
4343         The --cloop build option was being ignored this whole time since r236381.
4344         This patch makes it possible to build CLoop builds again.
4345
4346         * Scripts/build-jsc:
4347         * Scripts/webkitperl/FeatureList.pm:
4348         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4349
4350 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
4351
4352         webkitpy: Expose device_type from host-like objects
4353         https://bugs.webkit.org/show_bug.cgi?id=193406
4354         <rdar://problem/47262305>
4355
4356         Reviewed by Lucas Forschler.
4357
4358         Devices should expose device_type. As a result, all host objects should
4359         provide a device_type property, even if they do not yet define a&nb