d86bdcc28608c6b619a91f7e6a66dd30d4bec118
[WebKit-https.git] / Tools / ChangeLog
1 2014-02-04  Gabor Rapcsanyi  <rgabor@webkit.org>
2
3         Fine tuning the ARM EFL bots
4         https://bugs.webkit.org/show_bug.cgi?id=128168
5
6         Reviewed by Csaba Osztrogonác.
7
8         * BuildSlaveSupport/build.webkit.org-config/config.json: Add custom SVN mirror.
9         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
10         (WaitForSVNServer): Make it not to halt before the first repository checkout.
11         (WaitForSVNServer.evaluateCommand):
12         (Factory.__init__): Disable kill-old-processes step on EFL ARM bots, because these
13         bots run on the same machine and they kill the processes of each other.
14
15 2014-02-03  Ryosuke Niwa  <rniwa@webkit.org>
16
17         kill-old-processes doesn't kill plugin processes
18         https://bugs.webkit.org/show_bug.cgi?id=128138
19
20         Reviewed by Andreas Kling.
21
22         Add plugin process names to the list of processes to kill.
23
24         * BuildSlaveSupport/kill-old-processes:
25         (main):
26
27 2014-02-03  Dean Jackson  <dino@apple.com>
28
29         Feature flag for shape-inside
30         https://bugs.webkit.org/show_bug.cgi?id=128001
31
32         Reviewed by Simon Fraser.
33
34         Add CSS_SHAPE_INSIDE flag, and -css-shape-inside build
35         flag.
36
37         * Scripts/webkitperl/FeatureList.pm:
38
39 2014-02-03  Zoltan Horvath  <zoltan@webkit.org>
40
41         Unreviewed. Reorder my e-mail addresses in contributors.json,
42         so bugzilla will auto complete my actual bugzilla username.
43
44         * Scripts/webkitpy/common/config/contributors.json:
45
46 2014-02-03  Daniel Bates  <dabates@apple.com>
47
48         WebKit Bot Watcher's Dashboard: Defer subsequent resource loads from access-restricted build bot when
49         iteration fails to load with HTTP 401 status code
50         https://bugs.webkit.org/show_bug.cgi?id=128077
51
52         Reviewed by Alexey Proskuryakov.
53
54         Similar to the fix for <https://bugs.webkit.org/show_bug.cgi?id=127849>, we should only prompt for
55         the HTTP credentials of a build bot so long as an earlier authentication request wasn't cancelled
56         (i.e. failed with an HTTP 401 Unauthorized status code). Currently an authentication dialog will be
57         presented for an iteration each time the update queue timer fires until a person successfully
58         authenticates. Instead we should update the authentication status of the build bot on receiving an
59         HTTP 401 response code such that we defer subsequent requests to load any resource from the access-
60         restricted build bot when the queue update timer fires.
61
62         A person must explicitly click the "unauthorized" status line shown for the queue associated with the
63         iteration in the dashboard and authenticate successfully for the iteration to be loaded once an
64         authentication request for an iteration is cancelled.
65
66         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
67         (BuildbotIteration.prototype.update): Early return if the associated Buildbot was given invalid credentials.
68         Also notify the associated Buildbot and update the queue view when a load failed with an HTTP 401 status code.
69         (BuildbotIteration.prototype.loadLayoutTestResults): Ditto.
70         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
71         (BuildbotQueueView): Modified to call BuildbotQueueView.prototype._unauthorizedAccess instead of
72         QueueView.prototype._updateSoon when event BuildbotQueue.Event.UnauthorizedAccess is received.
73         (BuildbotQueueView.prototype._unauthorizedAccess): Added.
74
75 2014-02-03  Daniel Bates  <dabates@apple.com>
76
77         WebKit Bot Watcher's Dashboard: Teach JSON.load() to interpret third argument as either an
78         option dictionary or a failure callback
79         https://bugs.webkit.org/show_bug.cgi?id=128080
80
81         Reviewed by Alexey Proskuryakov.
82
83         Currently JSON.load() takes a failure callback function as its third argument and
84         an option dictionary as its fourth argument. So, a caller that wants to ignore errors
85         and pass an option dictionary must pass null or a reference to an empty function for
86         the value of third argument. Instead, we should make the third argument polymorphic for
87         convenience. Then a caller can either pass a failure callback function or an option dictionary.
88
89         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
90
91 2014-02-03  Krzysztof Czech  <k.czech@samsung.com>
92
93         [ATK] Expose aria-controls through ATK_RELATION_CONTROLLER_FOR
94         https://bugs.webkit.org/show_bug.cgi?id=127908
95
96         Reviewed by Chris Fleizach.
97
98         Updated AccessibilityUIElement both in WKTR and DRT so that aria-controls support could be tested properly.
99         Added empty stubs to not break mac builds.
100
101         * DumpRenderTree/AccessibilityUIElement.cpp:
102         (ariaControlsElementAtIndexCallback):
103         (AccessibilityUIElement::getJSClass):
104         * DumpRenderTree/AccessibilityUIElement.h:
105         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
106         (accessibilityElementAtIndex):
107         (AccessibilityUIElement::disclosedRowAtIndex):
108         (AccessibilityUIElement::ariaOwnsElementAtIndex):
109         (AccessibilityUIElement::ariaFlowToElementAtIndex):
110         (AccessibilityUIElement::ariaControlsElementAtIndex):
111         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
112         (AccessibilityUIElement::ariaControlsElementAtIndex):
113         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
114         (AccessibilityUIElement::ariaControlsElementAtIndex):
115         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
116         (AccessibilityUIElement::ariaControlsElementAtIndex):
117         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
118         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
119         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
120         (WTR::accessibilityElementAtIndex):
121         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
122         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
123         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
124         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
125         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
126         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
127         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
128         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
129
130 2014-02-02  Daniel Bates  <dabates@apple.com>
131
132         WebKit Bot Watcher's Dashboard: Access restricted queue should only prompt for HTTP credentials once per page load
133         https://bugs.webkit.org/show_bug.cgi?id=127849
134
135         I inadvertently used the equality operator instead of the identity operator when comparing the
136         value of the error HTTP status code with the numeric literal 401.
137
138         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
139         (BuildbotQueue.prototype.update):
140
141 2014-02-02  Daniel Bates  <dabates@apple.com>
142
143         Attempt to fix production dashboard after <http://trac.webkit.org/changeset/163222>
144
145         Actually pass option dictionary to JSON.load(); JSON.load() takes four arguments with the
146         last-most argument being the option dictionary.
147
148         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
149         (BuildbotIteration.prototype.update):
150
151 2014-02-01  Filip Pizlo  <fpizlo@apple.com>
152
153         JSC profiler's stub info profiling support should work again
154         https://bugs.webkit.org/show_bug.cgi?id=128057
155
156         Reviewed by Mark Lam.
157
158         * Scripts/display-profiler-output: Just make sure that there's always a space between the origin stack dump and the top bytecode index.
159
160 2014-02-01  Filip Pizlo  <fpizlo@apple.com>
161
162         JSC profiler should show reasons for jettison
163         https://bugs.webkit.org/show_bug.cgi?id=128047
164
165         Reviewed by Geoffrey Garen.
166         
167         Gave the tool a "log" command, that tells you all of the interesting things
168         that happened to a piece of bytecode, from the standpoint of optimization.
169         It's a great summary view for seeing how our tier-up machinery works.
170         
171         This uses a lot of information that was already available, plus the newly
172         added jettisonReason field.
173
174         * Scripts/display-profiler-output:
175
176 2014-01-31  Ryosuke Niwa  <rniwa@webkit.org>
177
178         Remove inline member functions of FrameSelection that access m_selection
179         https://bugs.webkit.org/show_bug.cgi?id=127986
180
181         Reviewed by Enrica Casucci.
182
183         * TestWebKitAPI/Configurations/Base.xcconfig:
184
185 2014-01-31  Anders Carlsson  <andersca@apple.com>
186
187         Another attempt at fixing the build.
188
189         * TestWebKitAPI/Configurations/Base.xcconfig:
190
191 2014-01-31  Oliver Hunt  <oliver@apple.com>
192
193         Rollout r163195 and related patches
194
195         * DumpRenderTree/CMakeLists.txt:
196         * WebKitTestRunner/CMakeLists.txt:
197         * WinCELauncher/CMakeLists.txt:
198
199 2014-01-31  Daniel Bates  <dabates@apple.com>
200
201         Attempt to fix Production Dashboard after <http://trac.webkit.org/changeset/163213>
202         (https://bugs.webkit.org/show_bug.cgi?id=127849)
203
204         Reviewed by David Farler.
205
206         Pass credentials when querying build bot iteration. 
207
208         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
209         (BuildbotIteration.prototype.update):
210         (BuildbotIteration.prototype.loadLayoutTestResults):
211
212 2014-01-31  Anders Carlsson  <andersca@apple.com>
213
214         Fix iOS build.
215
216         * TestWebKitAPI/Configurations/Base.xcconfig:
217
218 2014-01-31  Simon Fraser  <simon.fraser@apple.com>
219
220         WebKitTestRunner project doesn't show Mac as a valid destination architecture.
221         
222         Make sure that SUPPORTED_PLATFORMS is defined in Base.xcconfig.
223         
224         Also add BaseTarget.xcconfig to the project.
225
226         * WebKitTestRunner/Configurations/Base.xcconfig:
227         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
228
229 2014-01-31  Daniel Bates  <dabates@apple.com>
230
231         WebKit Bot Watcher's Dashboard: Access restricted queue should only prompt for HTTP credentials once per page load
232         https://bugs.webkit.org/show_bug.cgi?id=127849
233
234         Reviewed by Alexey Proskuryakov.
235
236         Currently whenever the dashboard updates the status of a queue whose Buildbot requires authentication
237         it will cause a browser to prompt for credentials once per update until valid credentials are provided.
238         Instead we should keep track of Buildbots that respond with an HTTP 401 Unauthorized status code to avoid
239         subsequently querying them and hence cause a browser to prompt for credentials. Together with an optional
240         hint provided when instantiating a Buildbot object as to whether it requires authentication, we can make
241         the dashboard prompt for HTTP credentials exactly once per page load for each queue whose associated
242         Buildbot requires authentication.
243
244         Queues whose Buildbot wasn't authenticated will show in the dashboard as "unauthorized". Clicking on
245         this status message will cause the browser to prompt for credentials.
246
247         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
248         (Buildbot): Initialize instance variable authenticationStatus to Buildbot.AuthenticationStatus.Unauthenticated.
249         (Buildbot.prototype.get needsAuthentication): Added.
250         (Buildbot.prototype.get authenticationStatus): Added.
251         (Buildbot.prototype.get isAuthenticated): Added.
252         (Buildbot.prototype.set isAuthenticated): Added.
253         (Buildbot.prototype.updateQueues): Added.
254         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
255         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Modified to call
256         BuildbotQueueView.prototype._appendUnauthorizedLineView() to update the view and show status of the queue as
257         "unauthorized" if the Buildbot associated with the queue is either unauthenticated or was given invalid credentials.
258         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
259         (BuildbotQueue.prototype.update): Return immediately if the associated Buildbot requires authentication.
260         Additionally, if the JSON load fails with an HTTP 401 Unauthorized access error (say, credentials were
261         invalidated) then update the authentication status of the Buildbot to avoid subsequently prompting a
262         person for credentials the next time the queue update timer fires.
263         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
264         (BuildbotQueueView): Register as a listener for event BuildbotQueue.Event.UnauthorizedAccess on each queue
265         so that the view can be updated to show status "unauthorized".
266         (BuildbotQueueView.prototype._appendUnauthorizedLineView): Added.
267         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
268         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
269         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js: Added new status, StatusLineView.Status.Unauthorized.
270         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
271         (.status-line.unauthorized .bubble): Added.
272         (.status-line.unauthorized .bubble.pictogram): Added.
273         (.status-line.unauthorized .message): Added.
274
275 2014-01-31  Filip Pizlo  <fpizlo@apple.com>
276
277         Unreviewed, really make --copy-libraries a no-able option.
278         
279         * Scripts/build-jsc:
280
281 2014-01-31  Filip Pizlo  <fpizlo@apple.com>
282
283         Unreviewed, really add the --copy-libraries option.
284
285         * Scripts/build-jsc:
286
287 2014-01-31  Filip Pizlo  <fpizlo@apple.com>
288
289         Unreviewed, fix the script for older Rubies.
290
291         * Scripts/export-llvm-build:
292
293 2014-01-31  Filip Pizlo  <fpizlo@apple.com>
294
295         Having a custom LLVM checkout should always override all other ways of getting LLVM
296         https://bugs.webkit.org/show_bug.cgi?id=128015
297
298         Reviewed by Oliver Hunt.
299
300         * Scripts/copy-webkitlibraries-to-product-directory:
301
302 2014-01-31  Daniel Bates  <dabates@apple.com>
303
304         WebKit Bot Watcher's Dashboard: Teach JSON.load() to take optional failure callback function
305         https://bugs.webkit.org/show_bug.cgi?id=127924
306
307         Reviewed by Alexey Proskuryakov.
308
309         Towards providing better error handling when a JSON load fails with a non-200 HTTP status
310         code, we should teach JSON.load() to take an optional failure callback function and invoke
311         it when either a load error or a JSON parsing error occurs.
312
313         As a side benefit of having a failure callback function a caller can separate the error handling
314         logic for a JSON load or parse error from the logic of handling a successful parsing of JSON content.
315
316         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
317         (BuildbotIteration.prototype.loadLayoutTestResults): Move JSON parser error logic into failure
318         callback function.
319         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
320         (JSON.load): Modified to take optional failure callback function called failureCallback.
321
322 2014-01-29  Oliver Hunt  <oliver@apple.com>
323
324         Make it possible to implement JS builtins in JS
325         https://bugs.webkit.org/show_bug.cgi?id=127887
326
327         Reviewed by Michael Saboff.
328
329         CMake updates
330
331         * DumpRenderTree/CMakeLists.txt:
332         * WebKitTestRunner/CMakeLists.txt:
333         * WinCELauncher/CMakeLists.txt:
334
335 2014-01-31  Filip Pizlo  <fpizlo@apple.com>
336
337         Allow more flexibility for copy-webkitlibraries-to-product-directory
338         https://bugs.webkit.org/show_bug.cgi?id=128010
339
340         Reviewed by Oliver Hunt.
341         
342         It's now the case that copy-webkitlibraries-to-product-directory does nothing by
343         default, but you can tell it to either copy WebKitSystemInterface (--wksi) or LLVM
344         (--llvm). You can also tell it where to get LLVM from.
345
346         * Scripts/build-jsc:
347         * Scripts/build-webkit:
348         * Scripts/copy-webkitlibraries-to-product-directory:
349
350 2014-01-31  David Farler  <dfarler@apple.com>
351
352         DumpRenderTree iOS fails to link: missing rowHeaders and columnHeaders in AccessibilityUIElement
353         https://bugs.webkit.org/show_bug.cgi?id=128004
354
355         Reviewed by Chris Fleizach.
356
357         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
358         (AccessibilityUIElement::columnHeaders): Stub added.
359         (AccessibilityUIElement::rowHeaders): Stub added.
360
361 2014-01-31  Zoltan Horvath  <zoltan@webkit.org>
362
363         Unreviewed. Update my contributors.json entry.
364
365         * Scripts/webkitpy/common/config/contributors.json:
366
367 2014-01-31  Anders Carlsson  <andersca@apple.com>
368
369         REGRESSION: WebKit2.PageLoadBasic API test is failing
370         https://bugs.webkit.org/show_bug.cgi?id=127892
371
372         Reviewed by Dan Bernstein.
373
374         Re-enable test.
375
376         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
377
378 2014-01-31  Csaba Osztrogonác  <ossy@webkit.org>
379
380         [jhbuild] Disable escape sequences in EWS output
381         https://bugs.webkit.org/show_bug.cgi?id=127922
382
383         Reviewed by Alexey Proskuryakov.
384
385         * Scripts/webkitpy/common/system/environment.py:
386         (Environment.disable_gcc_smartquotes):
387         (Environment):
388         (Environment.disable_jhbuild_VT100_output):
389         * Scripts/webkitpy/tool/commands/download_unittest.py:
390         * Scripts/webkitpy/tool/steps/build.py:
391         (Build.build):
392
393 2014-01-30  Martin Robinson  <mrobinson@igalia.com>
394
395         [GTK] [CMake] Add support for building against GTK+ 2
396         https://bugs.webkit.org/show_bug.cgi?id=127959
397
398         Reviewed by Anders Carlsson.
399
400         * DumpRenderTree/PlatformGTK.cmake: Use the new API version variable and don't use GTK3 directly.
401         * GtkLauncher/CMakeLists.txt: Ditto.
402         * ImageDiff/PlatformGTK.cmake: Ditto.
403         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Ditto.
404
405 2014-01-30  Anders Carlsson  <andersca@apple.com>
406
407         Add webView:didFinishLoadingNavigation: delegate method
408         https://bugs.webkit.org/show_bug.cgi?id=127976
409
410         Reviewed by Dan Bernstein.
411
412         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
413         (-[NavigationDelegate webView:didCommitNavigation:]):
414         (-[NavigationDelegate webView:didFinishLoadingNavigation:]):
415
416 2014-01-30  Anders Carlsson  <andersca@apple.com>
417
418         Add a webView:didCommitNavigation: delegate method
419         https://bugs.webkit.org/show_bug.cgi?id=127972
420
421         Reviewed by Dan Bernstein.
422
423         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
424         (-[NavigationDelegate webView:didStartProvisionalNavigation:]):
425         (-[NavigationDelegate webView:didCommitNavigation:]):
426
427 2014-01-30  Anders Carlsson  <andersca@apple.com>
428
429         Add a webView:didFailProvisionalNavigation:withError: delegate method
430         https://bugs.webkit.org/show_bug.cgi?id=127968
431
432         Reviewed by Dan Bernstein.
433
434         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
435         (-[DidFailProvisionalNavigationDelegate webView:didStartProvisionalNavigation:]):
436         (-[DidFailProvisionalNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
437         (TEST):
438
439 2014-01-30  Ryosuke Niwa  <rniwa@webkit.org>
440
441         The test server build fixes.
442
443         * TestResultServer/model/jsonresults.py:
444         (JsonResults.merge):
445         * TestResultServer/static-dashboards/flakiness_dashboard.js:
446
447 2014-01-30  Ryosuke Niwa  <rniwa@webkit.org>
448
449         NRWT shouldn't say "Finished writing JSON files" if it failed to to so
450         https://bugs.webkit.org/show_bug.cgi?id=127966
451
452         Reviewed by Alexey Proskuryakov.
453
454         Don't say "Finished writing JSON files" if we had failed to generate the JSON file.
455         Also explicitly say this is for test results server as we're generating two JSON files.
456
457         * Scripts/webkitpy/layout_tests/controllers/manager.py:
458         (Manager._upload_json_files):
459         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
460         (JSONLayoutResultsGenerator.__init__): Don't generate JSON file implicitly inside the constructor.
461         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
462         (JSONResultsGenerator.generate_json_output): Return a boolean indicating whether the generation
463         had succeeded or not.
464
465 2014-01-30  Filip Pizlo  <fpizlo@apple.com>
466
467         copy-webkitlibraries-to-product-directory should accept command-line arguments for extra work required for optional features rather than relying on environment variables
468         https://bugs.webkit.org/show_bug.cgi?id=120221
469
470         Reviewed by Mark Hahnenberg.
471
472         * Scripts/build-jsc:
473         * Scripts/build-webkit:
474         * Scripts/copy-webkitlibraries-to-product-directory:
475
476 2014-01-30  Anders Carlsson  <andersca@apple.com>
477
478         Add a webView:didStartProvisionalNavigation: delegate method
479         https://bugs.webkit.org/show_bug.cgi?id=127965
480
481         Reviewed by Dan Bernstein.
482
483         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
484         (-[NavigationDelegate webView:didStartProvisionalNavigation:]):
485         (TEST):
486
487 2014-01-30  Chris Fleizach  <cfleizach@apple.com>
488
489         WebKitTestRunner fails to link - missing rowHeaders and columnHeaders
490         https://bugs.webkit.org/show_bug.cgi?id=127917
491
492         Reviewed by Andy Estes.
493
494         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
495         (WTR::AccessibilityUIElement::rowHeaders):
496         (WTR::AccessibilityUIElement::columnHeaders):
497
498 2014-01-30  Martin Robinson  <mrobinson@igalia.com>
499
500         [GTK] [CMake] Add a "make dist" target
501         https://bugs.webkit.org/show_bug.cgi?id=116378
502
503         Reviewed by Gustavo Noronha Silva.
504
505         Added a script that reads a manifest file an produces a tarball. Also add
506         the manifest.
507
508         * gtk/make-dist.py: Added.
509         * gtk/manifest.txt: Added.
510
511 2014-01-30  David Farler  <dfarler@apple.com>
512
513         Move OTHER_LDFLAGS erasure to DumpRenderTreeLibrary.xcconfig.
514         https://bugs.webkit.org/show_bug.cgi?id=127935
515
516         Reviewed by Andy Estes.
517
518         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
519         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig:
520         Move OTHER_LDFLAGS erasure to the static library's xcconfig.
521
522 2014-01-30  David Farler  <dfarler@apple.com>
523
524         DumpRenderTree fails to build with ASAN: -fsanitize=address passed to static DRT target
525         https://bugs.webkit.org/show_bug.cgi?id=127935
526
527         Reviewed by Andy Estes.
528
529         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
530         Clear OTHER_LDFLAGS at the project level for the static library target.
531         No other linker flags were inherited from DebugRelease.
532
533 2014-01-30  David Farler  <dfarler@apple.com>
534
535         package-root shouldn't prefix simulator roots with the SDK path
536         http://bugs.webkit.org/show_bug.cgi?id=127923
537
538         Reviewed by Dan Bernstein.
539
540         * Scripts/package-root: Don't add an install path prefix.
541
542 2014-01-30  Gabor Rapcsanyi  <rgabor@webkit.org>
543
544         Add ARM EFL Linux builder bots to Apple buildmaster
545         https://bugs.webkit.org/show_bug.cgi?id=127472
546
547         Reviewed by Csaba Osztrogonác.
548
549         There is no ARM buildslaves after removing the Qt builders.
550
551         * BuildSlaveSupport/build.webkit.org-config/config.json:
552
553 2014-01-30  Andy Estes  <aestes@apple.com>
554
555         REGRESSION (r163037): WebKit2.PageLoadBasic API test failing on Mountain Lion
556         https://bugs.webkit.org/show_bug.cgi?id=127934
557
558         Disable the failing test on Mountain Lion.
559
560         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
561         (TestWebKitAPI::TEST):
562
563 2014-01-30  Anders Carlsson  <andersca@apple.com>
564
565         Add WKNavigationDelegate class
566         https://bugs.webkit.org/show_bug.cgi?id=127927
567
568         Reviewed by Dan Bernstein.
569
570         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
571         (TEST):
572
573 2014-01-30  David Farler  <dfarler@apple.com>
574
575         Enable iOS Tools builds by default
576         https://bugs.webkit.org/show_bug.cgi?id=127919
577
578         Reviewed by Andy Estes.
579
580         * Makefile:
581         Build all the tools except MiniBrowser on iOS
582         * Scripts/build-webkit:
583         Ditto.
584         Build WebKitTestRunnerApp target on iOS.
585
586 2014-01-30  David Farler  <dfarler@apple.com>
587
588         Make TestWebKitAPI build and run for iOS
589         https://bugs.webkit.org/show_bug.cgi?id=127925
590
591         Reviewed by Andy Estes.
592
593         * TestWebKitAPI/Configurations/Base.xcconfig:
594         - Don't warn on 64-32 bit conversion on x86_64 and arm64
595         - Don't build mac/*
596         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
597         - Link WebKit2 on all platforms
598
599 2014-01-30  David Farler  <dfarler@apple.com>
600
601         package-root should copy ./usr from the build products directory
602         https://bugs.webkit.org/show_bug.cgi?id=127878
603
604         Reviewed by Daniel Bates.
605
606         * Scripts/package-root:
607         Copy ./usr in addition to the frameworks.
608
609 2014-01-30  Andrei Bucur  <abucur@adobe.com>
610
611         Remove the ACCELERATED_COMPOSITING flag
612         https://bugs.webkit.org/show_bug.cgi?id=127833
613
614         Reviewed by Antti Koivisto.
615
616         Remove the USE(ACCELERATED_COMPOSITING) conditionals from the code base and make AC
617         mandatory.
618
619         * DumpRenderTree/efl/DumpRenderTree.cpp:
620         (initEcoreEvas):
621         * EWebLauncher/main.c:
622         (windowCreate):
623         * MiniBrowser/efl/main.c:
624         (elm_main):
625         * TestWebKitAPI/efl/PlatformWebView.cpp:
626         (TestWebKitAPI::initEcoreEvas):
627         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
628         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
629         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
630         (WTR::initEcoreEvas):
631
632 2014-01-29  Csaba Osztrogonác  <ossy@webkit.org>
633
634         Remove ENABLE(JAVASCRIPT_DEBUGGER) leftovers
635         https://bugs.webkit.org/show_bug.cgi?id=127845
636
637         Reviewed by Joseph Pecoraro.
638
639         * Scripts/webkitperl/FeatureList.pm:
640
641 2014-01-29  Anders Carlsson  <andersca@apple.com>
642
643         -[WKWebView loadRequest:] should return a WKNavigation
644         https://bugs.webkit.org/show_bug.cgi?id=127873
645
646         Reviewed by Dan Bernstein.
647
648         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
649         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm: Added.
650         (TEST):
651
652 2014-01-29  Tim Horton  <timothy_horton@apple.com>
653
654         WebKit2 View Gestures (Swipe): Update rubberBandsAt{Left,Right} when WebKit swipe is enabled
655         https://bugs.webkit.org/show_bug.cgi?id=127855
656         <rdar://problem/15933878>
657
658         Reviewed by Anders Carlsson.
659
660         * MiniBrowser/mac/WK2BrowserWindowController.m:
661         (-[WK2BrowserWindowController awakeFromNib]):
662         Enable swipe in MiniBrowser for testing purposes.
663
664 2014-01-29  Daniel Bates  <dabates@apple.com>
665
666         Fix JSONP requests made by the WebKit Bot Watcher's Dashboard following <http://trac.webkit.org/changeset/163034>
667         (https://bugs.webkit.org/show_bug.cgi?id=127784)
668
669         Use dot-notation instead of array index notation to access the dictionary value for key jsonpCallbackName
670         in the specified options dictionary.
671
672         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
673         (JSON.load):
674
675 2014-01-29  Daniel Bates  <dabates@apple.com>
676
677         WebKit Bot Watcher's Dashboard: Add support for using HTTP authentication with Buildbot
678         https://bugs.webkit.org/show_bug.cgi?id=127784
679
680         Reviewed by Alexey Proskuryakov.
681
682         Implement support for querying a Buildbot that requires HTTP authentication to access it.
683
684         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
685         (Buildbot): Add optional argument, options, to pass a dictionary of Buildbot options.
686         For now, we only support a single option, needsAuthentication, to indicate whether the
687         Buildbots requires HTTP authentication (defaults to false - HTTP authentication is
688         not required).
689         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
690         (BuildbotIteration.prototype.loadLayoutTestResults): Modified to pass JSONP callback name
691         to JSON.load() using the option dictionary.
692         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
693         (BuildbotQueue.prototype.update): Modified to pass withCredentials to JSON.load().
694         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
695         (JSON.load): Removed optional argument jsonpCallbackName and added optional argument options,
696         which is a dictionary. The argument jsonpCallbackName is now specified as an entry in the
697         options dictionary. Added boolean options withCredentials to toggle querying with HTTP
698         authentication credentials.
699
700 2014-01-29  Alexey Proskuryakov  <ap@apple.com>
701
702         build.webkit.org/dashboard links to an old failing build rather than the most recent
703         https://bugs.webkit.org/show_bug.cgi?id=127765
704         <rdar://problem/15795228>
705
706         Reviewed by Timothy Hatcher.
707
708         This patch changes builder view to not show how many failures there were in a row,
709         because it is not very relevant, and complicates the UI. Instead, we just show the
710         latest failing build and the latest successful one.
711
712         The patch also removes commit history popovers from revisions that can not be correlated
713         with any change. These popovers are only helpful in the first line, when there is
714         another line for comparison below. In this case, it's useful to see what changed
715         between the revisions, but even then, only if it was an actual failure, not a buildbot
716         exception.
717
718         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
719         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
720         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
721         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
722         (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
723         (BuildbotQueueView.prototype._revisionPopoverContentForIteration):
724         (BuildbotQueueView.prototype.revisionContentForIteration):
725         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
726         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
727
728 2014-01-29  Csaba Osztrogonác  <ossy@webkit.org>
729
730         Remove ENABLE(JAVASCRIPT_DEBUGGER) guards
731         https://bugs.webkit.org/show_bug.cgi?id=127840
732
733         Reviewed by Mark Lam.
734
735         * Scripts/webkitperl/FeatureList.pm:
736
737 2014-01-29  Krzysztof Czech  <k.czech@samsung.com>
738
739         [ATK] Expose aria-describedby with ATK_RELATION_DESCRIBED_BY
740         https://bugs.webkit.org/show_bug.cgi?id=121684
741
742         Reviewed by Mario Sanchez Prada.
743
744         Implementing helpText by using relation ATK_RELATION_DESCRIBED_BY.
745
746         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
747         (AccessibilityUIElement::helpText):
748         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
749         (WTR::AccessibilityUIElement::helpText):
750
751 2014-01-27  Chris Fleizach  <cfleizach@apple.com>
752
753         AX: Support @scope in HTML tables
754         https://bugs.webkit.org/show_bug.cgi?id=127688
755
756         Reviewed by Mario Sanchez Prada.
757
758         Add support for rowHeaders and columnHeaders.
759
760         * DumpRenderTree/AccessibilityUIElement.cpp:
761         (convertElementsToObjectArray):
762         (columnHeadersCallback):
763         (rowHeadersCallback):
764         (uiElementArrayAttributeValueCallback):
765         (AccessibilityUIElement::columnHeaders):
766         (AccessibilityUIElement::rowHeaders):
767         (AccessibilityUIElement::getJSClass):
768         * DumpRenderTree/AccessibilityUIElement.h:
769         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
770         (AccessibilityUIElement::rowHeaders):
771         (AccessibilityUIElement::columnHeaders):
772         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
773         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
774         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
775         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
776         (WTR::AccessibilityUIElement::rowHeaders):
777         (WTR::AccessibilityUIElement::columnHeaders):
778         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
779         (WTR::convertElementsToObjectArray):
780         (WTR::AccessibilityUIElement::rowHeaders):
781         (WTR::AccessibilityUIElement::columnHeaders):
782         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
783
784 2014-01-28  Daniel Bates  <dabates@apple.com>
785
786         Teach Buildbot dashboard to parse alternative revision format
787         https://bugs.webkit.org/show_bug.cgi?id=127561
788
789         Reviewed by Alexey Proskuryakov.
790
791         Add support for extracting the OpenSource and Internal revision numbers when Buildbot
792         returns a dictionary for the value of property got_revision.
793
794         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
795         (isMultiCodebaseGotRevisionProperty): Added.
796         (parseRevisionProperty): Added; parses Buildbot revision property, which can either be a
797         string or a dictionary.
798         (BuildbotIteration.prototype.update.): Modified to call parseRevisionProperty() to determine
799         the OpenSource and Internal revision numbers.
800
801 2014-01-28  Adrian Perez de Castro  <aperez@igalia.com>
802
803         [GTK] Add API to allow setting the process model in WebKitWebContext
804         https://bugs.webkit.org/show_bug.cgi?id=125463
805
806         Reviewed by Carlos Garcia Campos.
807
808         Implements accessors in WebKitWebContext for the process model.
809         The default behavior is unchanged, and a single web process is
810         used. Using WEBKIT_PROCESS_MODEL_ONE_SECONDARY_PROCESS_PER_WEB_VIEW
811         as the process model will make use one web process for each
812         WebKitWebView. This also enables the network process. Setting
813         the process model must be done as early as possible, before the
814         very first web process is spawned.
815
816         * MiniBrowser/gtk/main.c:
817         (main):
818         Enable multiple process mode if the MINIBROWSER_MULTIPROCESS
819         environment variable is defined and not empty.
820         * TestWebKitAPI/GNUmakefile.am:
821         Add new TestMultiprocess test case.
822         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
823         Add new TestMultiprocess test case.
824         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp: Added.
825         (loadChanged):
826         (testMultipleSecondaryProcesses):
827         (initializeWebExtensions):
828         (beforeAll):
829         (afterAll):
830         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
831         (methodCallCallback):
832         Implement the GetProcessIdentifier D-Bus method.
833         (makeBusName):
834         Choose a different bus name when the web extension is used
835         from TestMultiprocess.
836         (webkit_web_extension_initialize_with_user_data):
837         Use makeBusName() to choose the bus name.
838
839 2014-01-28  Carlos Garcia Campos  <cgarcia@igalia.com>
840
841         [SOUP] Remove soupURIToKURL
842         https://bugs.webkit.org/show_bug.cgi?id=127104
843
844         Reviewed by Martin Robinson.
845
846         * TestWebKitAPI/GNUmakefile.am: Add soup cppflags to WebCore unit
847         tests, because URL.h now includes GUniquePtrSoup.h.
848         * TestWebKitAPI/CMakeLists.txt: Ditto.
849         * WebKitTestRunner/PlatformEfl.cmake: Add soup cppflags to WTR,
850         because URL.h now includes GUniquePtrSoup.h.
851
852 2014-01-27  Carlos Garcia Campos  <cgarcia@igalia.com>
853
854         [GTK] Make webkit_uri_scheme_request_get_web_view() work with CustomProtocols
855         https://bugs.webkit.org/show_bug.cgi?id=127614
856
857         Reviewed by Gustavo Noronha Silva.
858
859         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: Bring
860         back the custom URI scheme WebView check.
861
862 2014-01-27  Tim Horton  <timothy_horton@apple.com>
863
864         Revert yet one more tiny part of r162629 that didn't get reverted in r162883
865
866         * WebKitTestRunner/TestController.cpp:
867         (WTR::TestController::pluginLoadPolicy):
868         * WebKitTestRunner/TestController.h:
869
870 2014-01-27  Tim Horton  <timothy_horton@apple.com>
871
872         Revert one more tiny part of r162629 that didn't get reverted in r162883.
873
874         ... which was also causing test failures!
875
876         * WebKitTestRunner/TestController.cpp:
877         (WTR::TestController::createWebViewWithOptions):
878
879 2014-01-27  David Farler  <dfarler@apple.com>
880
881         iOS DumpRenderTree.app dies loading fonts
882         https://bugs.webkit.org/show_bug.cgi?id=127730
883
884         Reviewed by Daniel Bates.
885
886         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
887         - Add Ahem to the __DATA section
888         * DumpRenderTree/mac/DumpRenderTree.mm:
889         (activateFontsIOS):
890         - Load "WeightWatcher100" instead.
891
892 2014-01-27  Alexey Proskuryakov  <ap@apple.com>
893
894         [Mac] Extra logging output from run-safari --no-saved-state
895         https://bugs.webkit.org/show_bug.cgi?id=127732
896
897         Reviewed by Daniel Bates.
898
899         * Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp): Use an option that
900         disables saved state without logging.
901
902 2014-01-27  Tim Horton  <timothy_horton@apple.com>
903
904         Revert the parts of r162629 that add a new pluginLoadPolicy and the context menu item.
905
906         We're leaving the parts that make us use PDFPlugin instead of showing the blocked
907         plugin indicator intact, though.
908
909         * WebKitTestRunner/TestController.cpp:
910         (WTR::TestController::createWebViewWithOptions):
911
912 2014-01-27  Andy Estes  <aestes@apple.com>
913
914         Scrub WebKit API headers of WTF macros
915         https://bugs.webkit.org/show_bug.cgi?id=127706
916
917         Reviewed by David Kilzer.
918
919         * Scripts/check-for-inappropriate-macros-in-external-headers: Modified
920         the regex to require a '(' after the macro name in order to be
921         considered a match. This prevents things like 'ENABLE_SOME_FEATURE'
922         from being flagged as an ENABLE() macro.
923
924 2014-01-27  Commit Queue  <commit-queue@webkit.org>
925
926         Unreviewed, rolling out r162846.
927         http://trac.webkit.org/changeset/162846
928         https://bugs.webkit.org/show_bug.cgi?id=127695
929
930         "Broke the WebKit Bot Watcher's Dashboard; will fix offline"
931         (Requested by dydz on #webkit).
932
933         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
934         (BuildbotIteration.prototype.update.):
935
936 2014-01-27  Daniel Bates  <dabates@apple.com>
937
938         Add support for displaying results from multiple Buildbots on WebKit Bot Watcher's Dashboard
939         https://bugs.webkit.org/show_bug.cgi?id=127564
940
941         Reviewed by Alexey Proskuryakov.
942
943         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
944         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
945
946 2014-01-27  Daniel Bates  <dabates@apple.com>
947
948         Teach Buildbot dashboard to parse alternative revision format
949         https://bugs.webkit.org/show_bug.cgi?id=127561
950
951         Reviewed by Alexey Proskuryakov.
952
953         Add support for extracting the OpenSource and Internal revision numbers when Buildbot
954         returns a dictionary for the value of property got_revision.
955
956         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
957         (parseRevisionProperty): Added; parses Buildbot revision property, which can either be a
958         string or a dictionary.
959         (BuildbotIteration.prototype.update.): Modified to call parseRevisionProperty() to determine
960         the OpenSource and Internal revision numbers.
961
962 2014-01-27  Carlos Garcia Campos  <cgarcia@igalia.com>
963
964         [GTK] Implement custom URI schemes with CustomProtocols
965         https://bugs.webkit.org/show_bug.cgi?id=127091
966
967         Reviewed by Gustavo Noronha Silva.
968
969         Temporarily disable the WebKitWebView check until we figure out
970         how to implement it with CustomProtocols.
971
972         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
973
974 2014-01-26  Alexey Proskuryakov  <ap@apple.com>
975
976         REGRESSION(r127412): http/tests/misc/link-rel-icon-beforeload.html is broken.
977
978         * DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::setIconDatabaseEnabled):
979         Fixed an incorrect ifdef.
980
981 2014-01-26  Brendan Long  <b.long@cablelabs.com>
982
983         [GTK] DumpRenderTree prints out suggesting to set WEBKIT_TOP_LEVEL when fonts are missing but doesn't use it.
984         https://bugs.webkit.org/show_bug.cgi?id=110602
985
986         Reviewed by Philippe Normand.
987
988         * DumpRenderTree/gtk/DumpRenderTree.cpp:
989         (getTopLevelPath): Use WEBKIT_TOP_LEVEL environment variable if it exists.
990         (initializeFonts): Fix printing of expected font path (fontPath is guaranteed to be null here).
991
992 2014-01-24  Andy Estes  <aestes@apple.com>
993
994         [iOS] Upstream changes in Tools/DumpRenderTree
995         https://bugs.webkit.org/show_bug.cgi?id=127412
996
997         Reviewed by Simon Fraser.
998
999         Upstream all iOS changes. Added a new target called DumpRenderTree.app,
1000         which builds the DumpRenderTree static library into an app bundle as
1001         expected by the iOS Simulator.
1002
1003         * DumpRenderTree/AccessibilityTextMarker.h:
1004         * DumpRenderTree/AccessibilityUIElement.h:
1005         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1006         * DumpRenderTree/DumpRenderTreeFileDraggingSource.h:
1007         * DumpRenderTree/DumpRenderTreePrefix.h:
1008         * DumpRenderTree/PixelDumpSupport.cpp:
1009         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1010         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
1011         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
1012         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1013         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1014         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
1015         * DumpRenderTree/TestNetscapePlugIn/TestObject.h:
1016         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp:
1017         * DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSAfterRemovingPluginElement.cpp:
1018         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
1019         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp:
1020         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:
1021         * DumpRenderTree/TestNetscapePlugIn/Tests/NullNPPGetValuePointer.cpp:
1022         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
1023         * DumpRenderTree/TestNetscapePlugIn/Tests/PluginScriptableNPObjectInvokeDefault.cpp:
1024         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1025         * DumpRenderTree/TestRunner.cpp:
1026         * DumpRenderTree/TestRunner.h:
1027         * DumpRenderTree/cg/ImageDiffCG.cpp:
1028         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1029         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
1030         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1031         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h: Added.
1032         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm: Added.
1033         * DumpRenderTree/ios/Info.plist: Added.
1034         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport.c: Added.
1035         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Added.
1036         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Added.
1037         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Changes: Added.
1038         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/IPhoneSimulatorNotification.xs: Added.
1039         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/MANIFEST: Added.
1040         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL: Added.
1041         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/README: Added.
1042         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm: Added.
1043         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/ppport.h: Added.
1044         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/t/IPhoneSimulatorNotification.t: Added.
1045         * DumpRenderTree/ios/PerlSupport/Makefile: Added.
1046         * DumpRenderTree/ios/PixelDumpSupportIOS.mm: Added.
1047         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
1048         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
1049         * DumpRenderTree/mac/AppleScriptController.m:
1050         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1051         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1052         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1053         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Added.
1054         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig:
1055         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
1056         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig: Added.
1057         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
1058         * DumpRenderTree/mac/DumpRenderTree.mm:
1059         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
1060         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1061         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1062         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
1063         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
1064         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1065         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1066         * DumpRenderTree/mac/EditingDelegate.h:
1067         * DumpRenderTree/mac/EventSendingController.h:
1068         * DumpRenderTree/mac/EventSendingController.mm:
1069         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1070         * DumpRenderTree/mac/HistoryDelegate.h:
1071         * DumpRenderTree/mac/LayoutTestHelper.m:
1072         * DumpRenderTree/mac/MockGeolocationProvider.mm:
1073         * DumpRenderTree/mac/NavigationController.h:
1074         * DumpRenderTree/mac/ObjCPlugin.h:
1075         * DumpRenderTree/mac/ObjCPlugin.m:
1076         * DumpRenderTree/mac/ObjCPluginFunction.h:
1077         * DumpRenderTree/mac/PolicyDelegate.h:
1078         * DumpRenderTree/mac/ResourceLoadDelegate.h:
1079         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1080         * DumpRenderTree/mac/TestRunnerMac.mm:
1081         * DumpRenderTree/mac/TextInputController.h:
1082         * DumpRenderTree/mac/TextInputController.m:
1083         * DumpRenderTree/mac/UIDelegate.h:
1084         * DumpRenderTree/mac/UIDelegate.mm:
1085
1086 2014-01-25  Darin Adler  <darin@apple.com>
1087
1088         Call deprecatedCharacters instead of characters at more call sites
1089         https://bugs.webkit.org/show_bug.cgi?id=127631
1090
1091         Reviewed by Sam Weinig.
1092
1093         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1094         (TestWebKitAPI::expectBuilderContent):
1095         (TestWebKitAPI::expectEmpty):
1096         (TestWebKitAPI::TEST):
1097         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1098         (TestWebKitAPI::TEST):
1099         Use the new name.
1100
1101 2014-01-25  Anders Carlsson  <andersca@apple.com>
1102
1103         Modernize HashTable threading code
1104         https://bugs.webkit.org/show_bug.cgi?id=127621
1105
1106         Reviewed by Darin Adler.
1107
1108         Explicitly include headers that used to be brought in by HashTable.h
1109
1110         * DumpRenderTree/JavaScriptThreading.cpp:
1111
1112 2014-01-24  Eric Carlson  <eric.carlson@apple.com>
1113
1114         Unreviewed. Add Philip Jägenstedt to watch and contributor lists.
1115
1116         * Scripts/webkitpy/common/config/contributors.json:
1117         * Scripts/webkitpy/common/config/watchlist:
1118
1119 2014-01-23  David Farler  <dfarler@apple.com>
1120
1121         Make WebKitTestRunner work with iOS
1122         https://bugs.webkit.org/show_bug.cgi?id=127448
1123
1124         Reviewed by Simon Fraser.
1125
1126         Combined patch from Simon below with some additional xcconfig cleanups,
1127         rebasing and stubbing out a couple of new functions that popped up
1128         since then.
1129
1130         2013-12-03  Simon Fraser  <simon.fraser@apple.com>
1131
1132                 <rdar://problem/15515469> Get WebKitTestRunner working on iOS
1133
1134                 Get WebKitTestRunner limping on iOS. Main parts:
1135                 - Stub out lots of accessibility-related functions.
1136                 - Stub out EventSender
1137                 - Create target to make a bundled app that runs in the simulator,
1138                   and copy the injected bundle library into it.
1139                 - Make a UIWindow and WKView to load tests in
1140
1141                 It runs, load tests, and dumps results to output. More work will be
1142                 required once we can execute it via the webkitpy scripts.
1143
1144         * WebKitTestRunner/Configurations/Base.xcconfig:
1145         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1146         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
1147         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1148         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm: Added.
1149         (WTR::AccessibilityController::addNotificationListener):
1150         (WTR::AccessibilityController::removeNotificationListener):
1151         (WTR::AccessibilityController::platformName):
1152         (WTR::AccessibilityController::logAccessibilityEvents):
1153         (WTR::AccessibilityController::resetToConsistentState):
1154         (WTR::findAccessibleObjectById):
1155         (WTR::AccessibilityController::accessibleElementById):
1156         * WebKitTestRunner/InjectedBundle/ios/AccessibilityNotificationHandler.h: Added.
1157         * WebKitTestRunner/InjectedBundle/ios/AccessibilityTextMarkerIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
1158         (WTR::AccessibilityTextMarker::isEqual):
1159         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm: Added.
1160         (WTR::AccessibilityUIElement::AccessibilityUIElement):
1161         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
1162         (WTR::AccessibilityUIElement::isEqual):
1163         (WTR::AccessibilityUIElement::getLinkedUIElements):
1164         (WTR::AccessibilityUIElement::getDocumentLinks):
1165         (WTR::AccessibilityUIElement::getChildren):
1166         (WTR::AccessibilityUIElement::getChildrenWithRange):
1167         (WTR::AccessibilityUIElement::childrenCount):
1168         (WTR::AccessibilityUIElement::elementAtPoint):
1169         (WTR::AccessibilityUIElement::indexOfChild):
1170         (WTR::AccessibilityUIElement::childAtIndex):
1171         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
1172         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
1173         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
1174         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
1175         (WTR::AccessibilityUIElement::rowAtIndex):
1176         (WTR::AccessibilityUIElement::selectedChildAtIndex):
1177         (WTR::AccessibilityUIElement::selectedChildrenCount):
1178         (WTR::AccessibilityUIElement::selectedRowAtIndex):
1179         (WTR::AccessibilityUIElement::titleUIElement):
1180         (WTR::AccessibilityUIElement::parentElement):
1181         (WTR::AccessibilityUIElement::disclosedByRow):
1182         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
1183         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
1184         (WTR::AccessibilityUIElement::attributesOfChildren):
1185         (WTR::AccessibilityUIElement::allAttributes):
1186         (WTR::AccessibilityUIElement::stringAttributeValue):
1187         (WTR::AccessibilityUIElement::numberAttributeValue):
1188         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
1189         (WTR::AccessibilityUIElement::uiElementAttributeValue):
1190         (WTR::AccessibilityUIElement::boolAttributeValue):
1191         (WTR::AccessibilityUIElement::isAttributeSettable):
1192         (WTR::AccessibilityUIElement::isAttributeSupported):
1193         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
1194         (WTR::AccessibilityUIElement::role):
1195         (WTR::AccessibilityUIElement::subrole):
1196         (WTR::AccessibilityUIElement::roleDescription):
1197         (WTR::AccessibilityUIElement::title):
1198         (WTR::AccessibilityUIElement::description):
1199         (WTR::AccessibilityUIElement::orientation):
1200         (WTR::AccessibilityUIElement::stringValue):
1201         (WTR::AccessibilityUIElement::language):
1202         (WTR::AccessibilityUIElement::helpText):
1203         (WTR::AccessibilityUIElement::x):
1204         (WTR::AccessibilityUIElement::y):
1205         (WTR::AccessibilityUIElement::width):
1206         (WTR::AccessibilityUIElement::height):
1207         (WTR::AccessibilityUIElement::clickPointX):
1208         (WTR::AccessibilityUIElement::clickPointY):
1209         (WTR::AccessibilityUIElement::intValue):
1210         (WTR::AccessibilityUIElement::minValue):
1211         (WTR::AccessibilityUIElement::maxValue):
1212         (WTR::AccessibilityUIElement::valueDescription):
1213         (WTR::AccessibilityUIElement::insertionPointLineNumber):
1214         (WTR::AccessibilityUIElement::isPressActionSupported):
1215         (WTR::AccessibilityUIElement::isIncrementActionSupported):
1216         (WTR::AccessibilityUIElement::isDecrementActionSupported):
1217         (WTR::AccessibilityUIElement::isEnabled):
1218         (WTR::AccessibilityUIElement::isRequired):
1219         (WTR::AccessibilityUIElement::isFocused):
1220         (WTR::AccessibilityUIElement::isSelected):
1221         (WTR::AccessibilityUIElement::isSelectedOptionActive):
1222         (WTR::AccessibilityUIElement::isIndeterminate):
1223         (WTR::AccessibilityUIElement::isExpanded):
1224         (WTR::AccessibilityUIElement::isChecked):
1225         (WTR::AccessibilityUIElement::hierarchicalLevel):
1226         (WTR::AccessibilityUIElement::classList):
1227         (WTR::AccessibilityUIElement::speak):
1228         (WTR::AccessibilityUIElement::ariaIsGrabbed):
1229         (WTR::AccessibilityUIElement::ariaDropEffects):
1230         (WTR::AccessibilityUIElement::lineForIndex):
1231         (WTR::AccessibilityUIElement::rangeForLine):
1232         (WTR::AccessibilityUIElement::rangeForPosition):
1233         (WTR::AccessibilityUIElement::boundsForRange):
1234         (WTR::AccessibilityUIElement::stringForRange):
1235         (WTR::AccessibilityUIElement::attributedStringForRange):
1236         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
1237         (WTR::uiElementCountForSearchPredicate):
1238         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
1239         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1240         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
1241         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
1242         (WTR::AccessibilityUIElement::attributesOfColumns):
1243         (WTR::AccessibilityUIElement::attributesOfRows):
1244         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
1245         (WTR::AccessibilityUIElement::attributesOfHeader):
1246         (WTR::AccessibilityUIElement::rowCount):
1247         (WTR::AccessibilityUIElement::columnCount):
1248         (WTR::AccessibilityUIElement::indexInTable):
1249         (WTR::AccessibilityUIElement::rowIndexRange):
1250         (WTR::AccessibilityUIElement::columnIndexRange):
1251         (WTR::AccessibilityUIElement::cellForColumnAndRow):
1252         (WTR::AccessibilityUIElement::horizontalScrollbar):
1253         (WTR::AccessibilityUIElement::verticalScrollbar):
1254         (WTR::AccessibilityUIElement::scrollToMakeVisible):
1255         (WTR::AccessibilityUIElement::selectedTextRange):
1256         (WTR::AccessibilityUIElement::setSelectedTextRange):
1257         (WTR::AccessibilityUIElement::increment):
1258         (WTR::AccessibilityUIElement::decrement):
1259         (WTR::AccessibilityUIElement::showMenu):
1260         (WTR::AccessibilityUIElement::press):
1261         (WTR::AccessibilityUIElement::setSelectedChild):
1262         (WTR::AccessibilityUIElement::accessibilityValue):
1263         (WTR::AccessibilityUIElement::documentEncoding):
1264         (WTR::AccessibilityUIElement::documentURI):
1265         (WTR::AccessibilityUIElement::url):
1266         (WTR::AccessibilityUIElement::addNotificationListener):
1267         (WTR::AccessibilityUIElement::removeNotificationListener):
1268         (WTR::AccessibilityUIElement::isFocusable):
1269         (WTR::AccessibilityUIElement::isSelectable):
1270         (WTR::AccessibilityUIElement::isMultiSelectable):
1271         (WTR::AccessibilityUIElement::isVisible):
1272         (WTR::AccessibilityUIElement::isOffScreen):
1273         (WTR::AccessibilityUIElement::isCollapsed):
1274         (WTR::AccessibilityUIElement::isIgnored):
1275         (WTR::AccessibilityUIElement::hasPopup):
1276         (WTR::AccessibilityUIElement::takeFocus):
1277         (WTR::AccessibilityUIElement::takeSelection):
1278         (WTR::AccessibilityUIElement::addSelection):
1279         (WTR::AccessibilityUIElement::removeSelection):
1280         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
1281         (WTR::AccessibilityUIElement::textMarkerRangeLength):
1282         (WTR::AccessibilityUIElement::previousTextMarker):
1283         (WTR::AccessibilityUIElement::nextTextMarker):
1284         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
1285         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
1286         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
1287         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
1288         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
1289         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
1290         (WTR::AccessibilityUIElement::textMarkerForPoint):
1291         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
1292         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
1293         (WTR::AccessibilityUIElement::indexForTextMarker):
1294         (WTR::AccessibilityUIElement::isTextMarkerValid):
1295         (WTR::AccessibilityUIElement::textMarkerForIndex):
1296         (WTR::AccessibilityUIElement::startTextMarker):
1297         (WTR::AccessibilityUIElement::endTextMarker):
1298         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
1299         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
1300         (WTR::AccessibilityUIElement::pathDescription):
1301         (WTR::AccessibilityUIElement::supportedActions):
1302         * WebKitTestRunner/InjectedBundle/ios/ActivateFontsIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
1303         (WTR::activateFonts):
1304         * WebKitTestRunner/InjectedBundle/ios/EventSenderProxyIOS.mm: Added.
1305         (WTR::EventSenderProxy::EventSenderProxy):
1306         (WTR::EventSenderProxy::~EventSenderProxy):
1307         (WTR::EventSenderProxy::updateClickCountForButton):
1308         (WTR::EventSenderProxy::mouseDown):
1309         (WTR::EventSenderProxy::mouseUp):
1310         (WTR::EventSenderProxy::mouseMoveTo):
1311         (WTR::EventSenderProxy::leapForward):
1312         (WTR::EventSenderProxy::keyDown):
1313         (WTR::EventSenderProxy::mouseScrollBy):
1314         (WTR::EventSenderProxy::continuousMouseScrollBy):
1315         (WTR::EventSenderProxy::addTouchPoint):
1316         (WTR::EventSenderProxy::updateTouchPoint):
1317         (WTR::EventSenderProxy::setTouchModifier):
1318         (WTR::EventSenderProxy::setTouchPointRadius):
1319         (WTR::EventSenderProxy::touchStart):
1320         (WTR::EventSenderProxy::touchMove):
1321         (WTR::EventSenderProxy::touchEnd):
1322         (WTR::EventSenderProxy::touchCancel):
1323         (WTR::EventSenderProxy::clearTouchPoints):
1324         (WTR::EventSenderProxy::releaseTouchPoint):
1325         (WTR::EventSenderProxy::cancelTouchPoint):
1326         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
1327         (WTR::InjectedBundle::platformInitialize):
1328         * WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
1329         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
1330         * WebKitTestRunner/Makefile:
1331         * WebKitTestRunner/TestController.cpp:
1332         (WTR::TestController::initialize):
1333         * WebKitTestRunner/TestController.h:
1334         * WebKitTestRunner/TestInvocation.cpp:
1335         (WTR::TestInvocation::invoke):
1336         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1337         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1338         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Added.
1339         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Added.
1340         (-[AppDelegate application:didFinishLaunchingWithOptions:]):
1341         (-[AppDelegate applicationWillResignActive:]):
1342         (-[AppDelegate applicationDidEnterBackground:]):
1343         (-[AppDelegate applicationWillEnterForeground:]):
1344         (-[AppDelegate applicationDidBecomeActive:]):
1345         (-[AppDelegate applicationWillTerminate:]):
1346         * WebKitTestRunner/WebKitTestRunnerApp/Images.xcassets/AppIcon.appiconset/Contents.json: Added.
1347         * WebKitTestRunner/WebKitTestRunnerApp/Images.xcassets/LaunchImage.launchimage/Contents.json: Added.
1348         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist: Added.
1349         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Prefix.pch: Added.
1350         * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Added.
1351         * WebKitTestRunner/WebKitTestRunnerApp/main.m: Added.
1352         (main):
1353         * WebKitTestRunner/WebKitTestRunnerAppTests-Info.plist: Added.
1354         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests-Info.plist: Added.
1355         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests.m: Added.
1356         (-[WebKitTestRunnerAppTests setUp]):
1357         (-[WebKitTestRunnerAppTests tearDown]):
1358         (-[WebKitTestRunnerAppTests testExample]):
1359         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj/InfoPlist.strings: Added.
1360         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1361         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1362         * WebKitTestRunner/iOS.xcconfig: Added.
1363         * WebKitTestRunner/ios/PlatformWebViewIOS.mm: Added.
1364         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useTiledDrawing:]):
1365         (-[TestRunnerWKView _shouldUseTiledDrawingArea]):
1366         (-[WebKitTestRunnerWindow isKeyWindow]):
1367         (-[WebKitTestRunnerWindow setFrameOrigin:]):
1368         (-[WebKitTestRunnerWindow setFrame:]):
1369         (-[WebKitTestRunnerWindow frameRespectingFakeOrigin]):
1370         (-[WebKitTestRunnerWindow backingScaleFactor]):
1371         (WTR::PlatformWebView::PlatformWebView):
1372         (WTR::PlatformWebView::resizeTo):
1373         (WTR::PlatformWebView::~PlatformWebView):
1374         (WTR::PlatformWebView::page):
1375         (WTR::PlatformWebView::focus):
1376         (WTR::PlatformWebView::windowFrame):
1377         (WTR::PlatformWebView::setWindowFrame):
1378         (WTR::PlatformWebView::didInitializeClients):
1379         (WTR::PlatformWebView::addChromeInputField):
1380         (WTR::PlatformWebView::removeChromeInputField):
1381         (WTR::PlatformWebView::makeWebViewFirstResponder):
1382         (WTR::PlatformWebView::windowSnapshotImage):
1383         (WTR::PlatformWebView::viewSupportsOptions):
1384         * WebKitTestRunner/ios/TestControllerIOS.mm: Added.
1385         (WTR::TestController::notifyDone):
1386         (WTR::TestController::platformInitialize):
1387         (WTR::TestController::platformDestroy):
1388         (WTR::TestController::initializeInjectedBundlePath):
1389         (WTR::TestController::initializeTestPluginDirectory):
1390         (WTR::TestController::platformRunUntil):
1391         (WTR::TestController::platformInitializeContext):
1392         (WTR::TestController::runModal):
1393         (WTR::TestController::platformLibraryPathForTesting):
1394         * WebKitTestRunner/ios/WebArchiveDumpSupportIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
1395         (createCFURLResponseFromResponseData):
1396         (supportedNonImageMIMETypes):
1397         * WebKitTestRunner/ios/mainIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
1398         (-[WebKitTestRunnerApp _runTestController]):
1399         (-[WebKitTestRunnerApp applicationDidFinishLaunching:]):
1400         (main):
1401
1402 2014-01-24  Enrique Ocaña González  <eocanha@igalia.com>
1403
1404         [GTK] Put cache files in XDG_CACHE_HOME
1405         https://bugs.webkit.org/show_bug.cgi?id=123458
1406
1407         Reviewed by Martin Robinson.
1408
1409         * GtkLauncher/main.c:
1410         (createBrowser):
1411
1412 2014-01-23  Max Vujovic  <mvujovic@adobe.com>
1413
1414         Remove CSS Custom Filters code and tests
1415         https://bugs.webkit.org/show_bug.cgi?id=127382
1416
1417         Reviewed by Simon Fraser.
1418
1419         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1420         (resetDefaultsToConsistentValues):
1421         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1422         (TestRunner::overridePreference):
1423
1424 2014-01-23  Tim Horton  <timothy_horton@apple.com>
1425
1426         PDFPlugin: Use PDFPlugin even if there's an external plugin installed, if it's blocked
1427         https://bugs.webkit.org/show_bug.cgi?id=127415
1428         <rdar://problem/12482452>
1429
1430         Reviewed by Sam Weinig.
1431
1432         Adopt the new page loader client plugin load callback.
1433
1434         * WebKitTestRunner/TestController.cpp:
1435         (WTR::TestController::createWebViewWithOptions):
1436         (WTR::TestController::pluginLoadPolicy):
1437         * WebKitTestRunner/TestController.h:
1438
1439 2014-01-23  peavo@outlook.com  <peavo@outlook.com>
1440
1441         [Curl] There is no way to specify cache folder.
1442         https://bugs.webkit.org/show_bug.cgi?id=125028
1443
1444         Reviewed by Brent Fulgham.
1445
1446         Enable disc cache in WinLauncher by setting cache folder location.
1447
1448         * WinLauncher/WinLauncher.cpp:
1449         (getAppDataFolder): Added function to get app data folder.
1450         (setCacheFolder): Added function to set cache folder.
1451         (createCrashReport): Use new getAppDataFolder function.
1452         (wWinMain): Use function setCacheFolder to set cache folder location.
1453
1454 2014-01-23  Daniel Bates  <dabates@apple.com>
1455
1456         build-webkit --sdk=iphonesimulator doesn't think it's building iOS
1457         https://bugs.webkit.org/show_bug.cgi?id=127379
1458
1459         Reviewed by Simon Fraser.
1460
1461         Teach build-webkit to recognize --sdk=X.
1462
1463         Currently, build-webkit recognizes --sdk X to specify X as the Xcode SDK to use, which is also
1464         considered when determining the WebKit port to build. But build-webkit advertises --sdk=X in its
1465         help message. We should teach build-webkit to recognize both --sdk X and --sdk=X to make its handling
1466         of --sdk more consistent with the handling of other build-webkit options that take a value (e.g. --prefix).
1467
1468         * Scripts/webkitdirs.pm:
1469         (checkForArgumentAndRemoveFromArrayRefGettingValue): Added.
1470         (checkForArgumentAndRemoveFromARGVGettingValue): Modified to call checkForArgumentAndRemoveFromArrayRefGettingValue().
1471         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl: Added.
1472
1473 2014-01-23  Commit Queue  <commit-queue@webkit.org>
1474
1475         Unreviewed, rolling out r162612.
1476         http://trac.webkit.org/changeset/162612
1477         https://bugs.webkit.org/show_bug.cgi?id=127488
1478
1479         broke the build (Requested by mhahnenberg on #webkit).
1480
1481         * Scripts/build-jsc:
1482         * jsc-cli/jsc-cli.xcodeproj/project.pbxproj: Removed.
1483         * jsc-cli/jsc-cli/CLIInstance.h: Removed.
1484         * jsc-cli/jsc-cli/CLIInstance.m: Removed.
1485         * jsc-cli/jsc-cli/JSModule.h: Removed.
1486         * jsc-cli/jsc-cli/JSModule.m: Removed.
1487         * jsc-cli/jsc-cli/JSRunLoopThread.h: Removed.
1488         * jsc-cli/jsc-cli/JSRunLoopThread.m: Removed.
1489         * jsc-cli/jsc-cli/ReadEvalPrintLoop.h: Removed.
1490         * jsc-cli/jsc-cli/ReadEvalPrintLoop.m: Removed.
1491         * jsc-cli/jsc-cli/RunLoopThread.h: Removed.
1492         * jsc-cli/jsc-cli/RunLoopThread.m: Removed.
1493         * jsc-cli/jsc-cli/ScriptInputSource.h: Removed.
1494         * jsc-cli/jsc-cli/ScriptInputSource.m: Removed.
1495         * jsc-cli/jsc-cli/main.m: Removed.
1496
1497 2014-01-23  Mark Hahnenberg  <mhahnenberg@apple.com>
1498
1499         Basic framework for a modern jsc CLI
1500         https://bugs.webkit.org/show_bug.cgi?id=127435
1501
1502         Reviewed by Geoffrey Garen.
1503
1504         The most basic components of a modern jsc command line interface consist of the following:
1505
1506         - A simple REPL to enter commands and receive results
1507         - The ability to define a module (which consists of various internal methods as well as a 
1508           set of externally visible methods)
1509         - The ability to load other modules at runtime
1510         - The ability to interact with the underlying platform to perform various "privileged" 
1511           functions (e.g. opening files, printing to the stdout, etc.)
1512         
1513         The basic architecture will look something like the following:
1514         - If the tool is run in REPL mode (i.e. no command line arguments), it will start the REPL 
1515           on the main thread and start a secondary thread with a run loop to handle various inputs 
1516           from the REPL thread.
1517         - If the tool is given a script to run, it will evaluate that script (and any scripts that 
1518           it might transitively load) within the run loop on the secondary thread while the main 
1519           thread blocks until it has completed.
1520
1521         * Scripts/build-jsc:
1522         * jsc-cli: Added.
1523         * jsc-cli/jsc-cli: Added.
1524         * jsc-cli/jsc-cli.xcodeproj: Added.
1525         * jsc-cli/jsc-cli.xcodeproj/project.pbxproj: Added.
1526         * jsc-cli/jsc-cli/CLIInstance.h: Added.
1527         * jsc-cli/jsc-cli/CLIInstance.m: Added.
1528         (-[CLIInstance init]):
1529         (-[CLIInstance loadFile:]):
1530         (-[CLIInstance run]):
1531         * jsc-cli/jsc-cli/JSModule.h: Added.
1532         * jsc-cli/jsc-cli/JSModule.m: Added.
1533         (coreModules):
1534         (isCoreModule):
1535         (classForModule):
1536         (coreModuleFullPath):
1537         (resolveModuleAsFile):
1538         (resolveModuleAsDirectory):
1539         (nodeModulePaths):
1540         (resolveAsNodeModule):
1541         (+[JSModule resolve:atPath:]):
1542         (globalModuleCache):
1543         (isCached):
1544         (cachedModule):
1545         (cacheModule):
1546         (+[JSModule require:atPath:]):
1547         (+[JSModule require:atPath:inContext:]):
1548         (-[JSModule platformObjectInContext:]):
1549         (-[JSModule initWithId:filename:context:]):
1550         (-[JSModule dealloc]):
1551         (-[JSModule didStartLoading]):
1552         (-[JSModule didFinishLoading]):
1553         (-[JSModule require:]):
1554         (-[JSModule exports]):
1555         * jsc-cli/jsc-cli/JSRunLoopThread.h: Added.
1556         * jsc-cli/jsc-cli/JSRunLoopThread.m: Added.
1557         (jsThreadMain):
1558         (+[JSRunLoopThread threadMain]):
1559         (-[JSRunLoopThread initWithFiles:andContext:]):
1560         (-[JSRunLoopThread startRunLoop]):
1561         (-[JSRunLoopThread start]):
1562         (-[JSRunLoopThread join]):
1563         (-[JSRunLoopThread didReceiveInput:]):
1564         (-[JSRunLoopThread performCallback:withError:]):
1565         (-[JSRunLoopThread performCallback:withArguments:]):
1566         (-[JSRunLoopThread didFinishRunLoopInitialization]):
1567         * jsc-cli/jsc-cli/ReadEvalPrintLoop.h: Added.
1568         * jsc-cli/jsc-cli/ReadEvalPrintLoop.m: Added.
1569         (-[ReadEvalPrintLoop initWithJSThread:]):
1570         (prompt):
1571         (escapeStringForOutput):
1572         (-[ReadEvalPrintLoop processNextInput]):
1573         (-[ReadEvalPrintLoop run]):
1574         * jsc-cli/jsc-cli/RunLoopThread.h: Added.
1575         * jsc-cli/jsc-cli/RunLoopThread.m: Added.
1576         (+[RunLoopThread threadMain]):
1577         (-[RunLoopThread init]):
1578         (-[RunLoopThread dealloc]):
1579         (-[RunLoopThread didFinishRunLoopInitialization]):
1580         (-[RunLoopThread start]):
1581         (-[RunLoopThread join]):
1582         * jsc-cli/jsc-cli/ScriptInputSource.h: Added.
1583         * jsc-cli/jsc-cli/ScriptInputSource.m: Added.
1584         (scriptInputSourceScheduleRoutine):
1585         (scriptInputSourcePerformRoutine):
1586         (scriptInputSourceCancelRoutine):
1587         (-[ScriptInputSource initWithContext:]):
1588         (-[ScriptInputSource dealloc]):
1589         (-[ScriptInputSource addToCurrentRunLoop]):
1590         (-[ScriptInputSource removeFromRemoteRunLoop]):
1591         (-[ScriptInputSource didReceiveScript:]):
1592         (-[ScriptInputSource didReceiveSignal]):
1593         (-[ScriptInputSource runScriptRemotely:]):
1594         (-[ScriptInputSource finishAsyncCallback:withResult:]):
1595         * jsc-cli/jsc-cli/main.m: Added.
1596         (main):
1597
1598 2014-01-23  László Langó  <llango.u-szeged@partner.samsung.com>
1599
1600         Remove a FIXME comment that is already fixed.
1601         https://bugs.webkit.org/show_bug.cgi?id=127468
1602
1603         Reviewed by Csaba Osztrogonác.
1604
1605         * Scripts/webkitpy/style/filereader.py:
1606         (TextFileReader.__init__):
1607
1608 2014-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1609
1610         [GLIB] Use GUniquePtr instead of GOwnPtr
1611         https://bugs.webkit.org/show_bug.cgi?id=127431
1612
1613         Reviewed by Martin Robinson.
1614
1615         GUniquePtr is a template alias of std::unique_ptr with a custom
1616         deleter that replaces GOwnPtr. GOwnPtr is still used for the cases
1617         where the output pointer is needed, but it will also be replaced soon.
1618
1619         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
1620         (printAccessibilityEvent):
1621         (axObjectEventListener):
1622         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1623         (indexRangeInTable):
1624         (AccessibilityUIElement::role):
1625         (AccessibilityUIElement::title):
1626         (AccessibilityUIElement::description):
1627         (AccessibilityUIElement::stringValue):
1628         (AccessibilityUIElement::language):
1629         (AccessibilityUIElement::lineForIndex):
1630         (AccessibilityUIElement::selectedTextRange):
1631         (AccessibilityUIElement::url):
1632         * DumpRenderTree/efl/AccessibilityControllerEfl.cpp:
1633         (AccessibilityController::accessibleElementById):
1634         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1635         (AccessibilityController::accessibleElementById):
1636         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1637         (getOutputDir):
1638         (getFontsPath):
1639         (initializeFonts):
1640         (dumpFramesAsText):
1641         (compareHistoryItems):
1642         (dumpHistoryItem):
1643         (soupURIToStringPreservingPassword):
1644         (resetDefaultsToConsistentValues):
1645         (temporaryDatabaseDirectory):
1646         (webViewTitleChanged):
1647         (webFrameLoadStatusNotified):
1648         (pathFromSoupURI):
1649         (convertWebResourceToURLPath):
1650         (urlSuitableForTestResult):
1651         (descriptionSuitableForTestResult):
1652         (willSendRequestCallback):
1653         (frameLoadEventCallback):
1654         * DumpRenderTree/gtk/EditingCallbacks.cpp:
1655         (dumpNodePath):
1656         (dumpRange):
1657         (shouldApplyStyle):
1658         * DumpRenderTree/gtk/EventSender.cpp:
1659         (contextClickCallback):
1660         (beginDragWithFilesCallback):
1661         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1662         (TestRunner::pathToLocalResource):
1663         (TestRunner::queueLoad):
1664         (TestRunner::removeOriginAccessWhitelistEntry):
1665         (TestRunner::setMockGeolocationPositionUnavailableError):
1666         (TestRunner::setIconDatabaseEnabled):
1667         (TestRunner::findString):
1668         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
1669         (TestRunner::overridePreference):
1670         (TestRunner::addUserScript):
1671         (TestRunner::addUserStyleSheet):
1672         (TestRunner::setTextDirection):
1673         * DumpRenderTree/gtk/TextInputController.cpp:
1674         (setMarkedTextCallback):
1675         (insertTextCallback):
1676         (doCommandCallback):
1677         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
1678         (LoadHTMLStringItem::invoke):
1679         * TestWebKitAPI/PlatformGTK.cmake:
1680         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
1681         (WebKitDOMNodeTest::testTagNames):
1682         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
1683         (testBackForwardListLimitAndCache):
1684         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
1685         (testContextMenuSmartSeparators):
1686         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
1687         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1688         (testDownloadLocalFile):
1689         (testDownloadLocalFileError):
1690         (addContentDispositionHTTPHeaderToResponse):
1691         (serverCallback):
1692         (testDownloadRemoteFileError):
1693         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
1694         (startTestServer):
1695         (testInspectorServerPageList):
1696         (openRemoteDebuggingSession):
1697         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
1698         (testPrintOperationPrint):
1699         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1700         (addCacheHTTPHeadersToResponse):
1701         (serverCallback):
1702         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1703         (httpsServerCallback):
1704         (httpServerCallback):
1705         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1706         (testWebViewJavaScriptDialogs):
1707         (testWebViewWindowProperties):
1708         (testWebViewFileChooserRequest):
1709         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
1710         (testWebExtensionWindowObjectCleared):
1711         (testWebExtensionIsolatedWorld):
1712         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp:
1713         (startTestServer):
1714         (checkAtspiAccessible):
1715         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
1716         (serverCallback):
1717         (testClearDatabase):
1718         (testGetFaviconURI):
1719         (webkitFaviconDatabaseFinalizedCallback):
1720         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1721         (testWebContextGetPlugins):
1722         (testWebContextURIScheme):
1723         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1724         (testWebViewRunJavaScript):
1725         (testWebViewMode):
1726         (testWebViewPageVisibility):
1727         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp:
1728         (isStyleSheetInjectedForURLAtPath):
1729         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
1730         (testWebViewEditorCutCopyPasteNonEditable):
1731         (testWebViewEditorCutCopyPasteEditable):
1732         (testWebViewEditorSelectAllNonEditable):
1733         (testWebViewEditorSelectAllEditable):
1734         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1735         (sendRequestCallback):
1736         (methodCallCallback):
1737         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
1738         (TestWebKitAPI::Util::createInjectedBundlePath):
1739         (TestWebKitAPI::Util::createURLForResource):
1740         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
1741         (TestWebKitAPI::doKeyStroke):
1742         (TestWebKitAPI::doMouseButtonEvent):
1743         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
1744         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
1745         (loadFailedCallback):
1746         (LoadTrackingTest::loadURI):
1747         (LoadTrackingTest::loadHtml):
1748         (LoadTrackingTest::loadPlainText):
1749         (LoadTrackingTest::loadRequest):
1750         (LoadTrackingTest::reload):
1751         (LoadTrackingTest::goBack):
1752         (LoadTrackingTest::goForward):
1753         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
1754         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:
1755         (registerGResource):
1756         (removeNonEmptyDirectory):
1757         (main):
1758         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1759         (Test::getWebKit1TestResoucesDir):
1760         (Test::getResourcesDir):
1761         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp:
1762         (WebKitTestBus::run):
1763         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
1764         (WebKitTestServer::WebKitTestServer):
1765         (WebKitTestServer::getURIForPath):
1766         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp:
1767         (WebProcessTestRunner::runTest):
1768         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1769         (resourceGetDataCallback):
1770         (WebViewTest::mainResourceData):
1771         (WebViewTest::mouseMoveTo):
1772         (WebViewTest::keyStroke):
1773         (WebViewTest::doMouseButtonEvent):
1774         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
1775         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1776         (WTR::AccessibilityController::accessibleElementById):
1777         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1778         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1779         (WTR::AccessibilityUIElement::role):
1780         (WTR::AccessibilityUIElement::title):
1781         (WTR::AccessibilityUIElement::description):
1782         (WTR::AccessibilityUIElement::stringValue):
1783         (WTR::AccessibilityUIElement::language):
1784         (WTR::AccessibilityUIElement::lineForIndex):
1785         (WTR::AccessibilityUIElement::selectedTextRange):
1786         (WTR::AccessibilityUIElement::url):
1787         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1788         (WTR::getOutputDir):
1789         (WTR::getFontsPath):
1790         (WTR::initializeFontConfigSetting):
1791         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1792         (WTR::topLevelPath):
1793         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1794         (WTR::TestRunner::pathToLocalResource):
1795         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1796         (WTR::TestController::initializeInjectedBundlePath):
1797         (WTR::TestController::initializeTestPluginDirectory):
1798
1799 2014-01-05  Martin Robinson  <mrobinson@igalia.com>
1800
1801         [GTK] [CMake] run-webkit-tests should support the CMake build
1802         https://bugs.webkit.org/show_bug.cgi?id=126503
1803
1804         Reviewed by Daniel Bates.
1805
1806         Update run-launcher and gtk.py to work properly when dealing with the CMake port.
1807         run-webkit-tests does not need the --gtkcmake flag, but run-launcher does.
1808
1809         * Scripts/run-launcher: Work properly with the gtkcmake flag.
1810         * Scripts/webkitpy/port/gtk.py:
1811         (GtkPort._is_cmake_build): Added this helper which looks for the CMakeCache
1812         file to detect a CMake build.
1813         (GtkPort._built_executables_path): Added this helper to locate the built executable path.
1814         (GtkPort._built_libraries_path): Added this helper to locate the built library path.
1815         (GtkPort._port_flag_for_scripts): Use --gtkcmake when appropriate.
1816         (GtkPort.setup_environ_for_server): The way CMake builds libraries differs from GTK+.
1817         (GtkPort._path_to_driver): Use the new helper.
1818         (GtkPort._path_to_image_diff): Use the new helper.
1819         (GtkPort._path_to_webcore_library): Use the new helper.
1820         (GtkPort.build_webkit_command): Use --gtkcmake when appropriate.
1821
1822 2014-01-22  Ryuan Choi  <ryuan.choi@samsung.com>
1823
1824         [EFL] Remove unnecessary smart method since ewk_view_tiled removed
1825         https://bugs.webkit.org/show_bug.cgi?id=127417
1826
1827         Reviewed by Gyuyoung Kim.
1828
1829         * EWebLauncher/main.c:
1830         (on_key_down): Removed shortcut to test pre render.
1831
1832 2014-01-22  Myles C. Maxfield  <mmaxfield@apple.com>
1833
1834         Remove CSS3_TEXT_DECORATION define
1835         https://bugs.webkit.org/show_bug.cgi?id=127333
1836
1837         This is required for unprefixing the text-decoration-* CSS properties.
1838
1839         Reviewed by Simon Fraser.
1840
1841         * Configurations/FeatureDefines.xcconfig:
1842
1843 2014-01-22  Andy Estes  <aestes@apple.com>
1844
1845         [iOS] Prepare for upstreaming DumpRenderTree changes
1846         https://bugs.webkit.org/show_bug.cgi?id=127412
1847
1848         Reviewed by Simon Fraser.
1849
1850         Unlike on Mac where DumpRenderTree is a command-line tool, on iOS it is
1851         an application bundle. Instead of upstreaming a separate target for the
1852         app that duplicates the 'Compile Sources' phase of the tool, separate
1853         out the compilation into a static library target that both the
1854         command-line tool and the app can link against. Also, perform some
1855         unrelated cleanup.
1856
1857         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Updated the
1858         project file format from 2.4- to 3.2-compatible. Removed the
1859         'Copy Headers' build phase and removed all files from the
1860         'Compile Sources' build phase of DumpRenderTree. Added some files that
1861         were missing from the project. Created a 'DumpRenderTree (Library)'
1862         target for building the static library and made the 'DumpRenderTree'
1863         target depend on it. Added a 'Compile Sources' build phase to this
1864         target that builds the same files the DumpRenderTree target used to.
1865         Created DumpRenderTreeMain.mm as the only source file of the
1866         DumpRenderTree target, since targets won't link a binary without at
1867         least one source file. Made DumpRenderTree (Library) use
1868         DumpRenderTreeLibrary.xcconfig and made LayoutTestHelper use
1869         BaseTarget.xcconfig (so that it doesn't try to link libDumpRenderTree.a).
1870         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Moved
1871         definitions of GCC_ENABLE_OBJC_EXCEPTIONS and GCC_PREFIX_HEADER from
1872         DumpRenderTree.xcconfig to here so that LayoutTestHelper can use them.
1873         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Passed
1874         -force_load $(BUILT_PRODUCTS_DIR)libDumpRenderTree.a to OTHER_LDFLAGS.
1875         This is needed to correctly link a static library containing an Objective-C
1876         category (see <https://developer.apple.com/library/mac/qa/qa1490/_index.html>).
1877         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Added.
1878         * DumpRenderTree/mac/DumpRenderTree.mm:
1879         (DumpRenderTreeMain): Renamed from main.
1880         * DumpRenderTree/mac/DumpRenderTreeMac.h: Added declaration of DumpRenderTreeMain.
1881         * DumpRenderTree/mac/DumpRenderTreeMain.mm: Added.
1882         (main): Called DumpRenderTreeMain from main.
1883
1884 2014-01-15  Martin Robinson  <mrobinson@igalia.com>
1885
1886         [GTK][CMake] build-webkit should try harder to avoid re-running cmake
1887         https://bugs.webkit.org/show_bug.cgi?id=127073
1888
1889         Reviewed by Daniel Bates.
1890
1891         * Scripts/build-webkit: Unify all the ports that call buildCMakeProjectOrExit with
1892         the new isCMakeBuild conditional. This allows us to share more code between ports.
1893         Pass the build arguments to the removeCMakeCache function.
1894         * Scripts/webkitdirs.pm:
1895         (runAutogenForAutotoolsProjectIfNecessary): Renamed mustReRunAutogen to cachedArgumentFileOutOfDate
1896         because it's now shared with the CMake build.
1897         (cachedArgumentFileOutOfDate): Renamed.
1898         (cmakeCachePath): Added this helper which gets the CMakeCache.txt path.
1899         (shouldRemoveCMakeCache): Tries to preserve current behavior for all ports, 
1900         except GTK+ which examines the OptionsGTK.cmake and OptionsCommon.cmake file
1901         as well as checking if build-webkit has been run with different arguments.
1902         (removeCMakeCache): Call shouldRemoveCMakeCache now.
1903         (generateBuildSystemFromCMakeProject): Exit early if CMakeCache.txt exists for GTK+.
1904         (isCMakeBuild): Added.
1905
1906 2014-01-22  Thiago de Barros Lacerda  <thiago.lacerda@openbossa.org>
1907
1908         [EFL][GTK] Get EFL and GTK compiling with ACCESSIBILITY disabled
1909         https://bugs.webkit.org/show_bug.cgi?id=127119
1910
1911         Reviewed by Mario Sanchez Prada.
1912
1913         Guarding ACCESSIBILITY code in DumpRenderTree and WebKitTestRunner with HAVE(ACCESSIBILITY).
1914
1915         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1916         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1917         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1918         (resetDefaultsToConsistentValues):
1919         (webViewWindowObjectCleared):
1920         (main):
1921         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1922         (WTR::AccessibilityController::platformName):
1923         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1924         (WTR::AccessibilityUIElement::isIndeterminate):
1925
1926 2014-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1927
1928
1929         [GTK] Add GUniquePtr
1930         https://bugs.webkit.org/show_bug.cgi?id=127170
1931
1932         Reviewed by Gustavo Noronha Silva.
1933
1934         Add unit tests for GUniquePtr.
1935
1936         * TestWebKitAPI/GNUmakefile.am: Add new file to compilation.
1937         * TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp: Added.
1938         (log):
1939         (takeLogStr):
1940         (TestWebKitAPI::TEST):
1941
1942 2014-01-22  Jinwoo Song  <jinwoo7.song@samsung.com>
1943
1944         Remove Nix files from Tools
1945         https://bugs.webkit.org/show_bug.cgi?id=127418
1946
1947         Reviewed by Csaba Osztrogonác.
1948
1949         * Scripts/build-webkit:
1950         * Scripts/update-webkit-libs-jhbuild:
1951         * Scripts/webkitdirs.pm:
1952         (determineArchitecture):
1953         (argumentsForConfiguration):
1954         (jscProductDir):
1955         (builtDylibPathForName):
1956         (isAppleWebKit):
1957         (launcherPath):
1958         (launcherName):
1959         (checkRequiredSystemConfig):
1960         (copyInspectorFrontendFiles):
1961         (jhbuildWrapperPrefixIfNeeded):
1962         (buildCMakeProjectOrExit):
1963         (cmakeBasedPortName):
1964         * Scripts/webkitpy/common/config/ports.py:
1965         (DeprecatedPort.port):
1966         (EflWK2Port.build_webkit_command):
1967         * Scripts/webkitpy/port/factory.py:
1968         (platform_options):
1969         (PortFactory):
1970         * Scripts/webkitpy/port/nix.py: Removed.
1971         * Scripts/webkitpy/port/nix_unittest.py: Removed.
1972
1973 2014-01-21  Benjamin Poulain  <benjamin@webkit.org>
1974
1975         Add Ian and Ricky to the contributor list
1976
1977         * Scripts/webkitpy/common/config/contributors.json:
1978         I am too old to remember all those email addresses :)
1979
1980 2014-01-21  David Farler  <dfarler@apple.com>
1981
1982         Upstream package-root for iOS
1983
1984         Reviewed by Daniel bates.
1985
1986         * Scripts/package-root: Added.
1987         (usage):
1988         * Scripts/webkitdirs.pm:
1989         (XcodeSDKPath): Added function.
1990
1991 2014-01-21  Daniel Bates  <dabates@apple.com>
1992
1993         [iOS] Tools/Makefile shouldn't build modules DumpRenderTree, gtest, or TestWebKitAPI
1994         https://bugs.webkit.org/show_bug.cgi?id=127368
1995
1996         Reviewed by Tim Horton.
1997
1998         Similar to the build-webkit change in <https://bugs.webkit.org/show_bug.cgi?id=127364>,
1999         we don't want to build DumpRenderTree, gtest, or TestWebKitAPI when running make in
2000         Tools.
2001
2002         * Makefile:
2003
2004 2014-01-21  Daniel Bates  <dabates@apple.com>
2005
2006         [iOS] Don't build DumpRenderTree, gtest, or TestWebKitAPI
2007         https://bugs.webkit.org/show_bug.cgi?id=127364
2008
2009         Reviewed by Simon Fraser.
2010
2011         For now, don't build DumpRenderTree and TestWebKitAPI for iOS as these
2012         projects fail to build because we need to upstream the relevant iOS changes.
2013         Also, don't build gtest, which is a dependency of TestWebKitAPI since we
2014         aren't building TestWebKitAPI.
2015
2016         * Scripts/build-webkit:
2017
2018 2014-01-21  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2019
2020         Unreviewed, remove myself from some watchlist entries.
2021
2022         * Scripts/webkitpy/common/config/watchlist:
2023
2024 2014-01-21  Zalan Bujtas  <zalan@apple.com>
2025
2026         Use 64 as the default value for the subpixel denominator.
2027
2028         Reviewed by Simon Fraser.
2029
2030         * lldb/lldb_webkit.py:
2031         (WebCoreLayoutUnitProvider.to_string):
2032
2033 2014-01-21  ChangSeok Oh  <changseok.oh@collabora.com>
2034
2035         [GTK] Fix a c++11 compliance issue for fontconfig
2036         https://bugs.webkit.org/show_bug.cgi?id=127283
2037
2038         Reviewed by Martin Robinson.
2039
2040         fontconfig-2.8.0 is not compliant with C++11. So I propose to apply a
2041         hotfix until bumping fontconfig up.
2042
2043         * gtk/jhbuild.modules:
2044         * gtk/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
2045
2046 2014-01-21  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2047
2048         run-jsc-stress-tests should accept --child-processes option and WEBKIT_TEST_CHILD_PROCESSES env.var
2049         like run_webkit_test does
2050         https://bugs.webkit.org/show_bug.cgi?id=127349
2051
2052         Reviewed by Csaba Osztrogonác.
2053
2054         * Scripts/run-jsc-stress-tests:
2055
2056 2014-01-21  Adrian Perez de Castro  <aperez@igalia.com>
2057
2058         [GTK] Allow passing extra data to web extensions
2059         https://bugs.webkit.org/show_bug.cgi?id=125990
2060
2061         Reviewed by Carlos Garcia Campos.
2062
2063         Allow passing additional information to the injected bundle. On top
2064         of the string containing the path to the web extensions directory,
2065         a GVariant can be set with additional data using
2066         webkit_web_context_set_web_extensions_initialization_user_data().
2067         Also, a new initialize-web-extensions signal is emitted before
2068         launching a new WebProcess to allow setting different user data
2069         for each process. The GVariant is serialized as a string, passed
2070         to the injected bundle, and the injected bundle deserializes back
2071         the data, which is passed to web extensions which define the
2072         webkit_web_extension_initialize_with_user_data() function (for
2073         backwards compatibility, webkit_web_extension_initialize() is
2074         used as a fallback.)
2075
2076         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
2077         (initializeWebExtensions): Handles the initialize-web-extensions
2078         signal, and sets the web extensions directory and the initialization
2079         user data.
2080         (testWebExtensionInitializationUserData): New test case for checking
2081         the user data passed on initialization to web extensions.
2082         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2083         (methodCallCallback): Added implementation for the
2084         GetInitializationUserData D-Bus method, used by
2085         testWebExtensionInitializationUserData().
2086         (webkit_web_extension_initialize_with_user_data): Define the
2087         initialization function with the additional user data parameter.
2088
2089 2014-01-21  Siddharth Mathur  <s.mathur@ieee.org>
2090
2091         Change my email address in contributors.json.
2092
2093         Unreviewed.
2094
2095         * Scripts/webkitpy/common/config/contributors.json:
2096
2097 2014-01-21  Krzysztof Czech  <k.czech@samsung.com>
2098
2099         [ATK] Expose aria-flowto through ATK_RELATION_FLOWS_TO
2100         https://bugs.webkit.org/show_bug.cgi?id=127291
2101
2102         Reviewed by Mario Sanchez Prada.
2103
2104         Implemented AccessibilityUIElement::ariaFlowToElementAtIndex method.
2105
2106         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2107         (AccessibilityUIElement::ariaFlowToElementAtIndex):
2108         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2109         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
2110
2111 2014-01-20  Zalan Bujtas  <zalan@apple.com>
2112
2113         Force float division when calculating CSS px value.
2114
2115         Reviewed by Simon Fraser.
2116
2117         Note that in Python 3, this is the default behavior.
2118
2119         * lldb/lldb_webkit.py:
2120         (WebCoreLayoutUnitProvider.to_string):
2121
2122 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
2123
2124         build.webkit.org/dashboard should display information about patches in EWS
2125         https://bugs.webkit.org/show_bug.cgi?id=127006
2126
2127         Reviewed by Ryosuke Niwa.
2128
2129         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
2130         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Bugzilla.js: Added.
2131         (Bugzilla.prototype.detailsURLForAttachment):
2132         Added a class for Bugzilla. So far, the only thing it can do is build patch URLs,
2133         which is needed when one wants to do something with a patch EWS is stuck on.
2134
2135         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
2136         Create a Bugzilla instance.
2137
2138         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
2139         (EWS.prototype.jsonQueueLengthURL):
2140         (EWS.prototype.jsonQueueStatusURL):
2141         Build JSON ULRs here, not in EWSQueue, as this is how other classes are structured.
2142
2143         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
2144         (EWSQueue.prototype.get statusPageURL): Changed to use a URL provided by EWS instead
2145         of second guessing.
2146         (EWSQueue.prototype.get chartsPageURL): Added.
2147         (EWSQueue.prototype.get loadedDetailedStatus): Tells whether we currently have
2148         additional data already loaded (it's reset with every update).
2149         (EWSQueue.prototype.get patches): Get patch queue.
2150         (EWSQueue.prototype.get bots): Get bots.
2151         (EWSQueue.prototype.update): Changed to use a specialized cheaper URL.
2152         (EWSQueue.prototype.loadDetailedStatus): Load and transform detailed status JSON.
2153
2154         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
2155         (EWSQueueView.prototype.update.appendQueue): Add a popover is there are any patches
2156         in the queue.
2157         (EWSQueueView.prototype.addLinkToRow): A helper to build the popover.
2158         (EWSQueueView.prototype.addTextToRow): Ditto.
2159         (EWSQueueView.prototype._addQueueHeadingToPopover): Ditto.
2160         (EWSQueueView.prototype._addBotsHeadingToPopover): Ditto.
2161         (EWSQueueView.prototype._addDividerToPopover): Ditto.
2162         (EWSQueueView.prototype._timeIntervalString): A helper to format a timestamp into a
2163         relative string.
2164         (EWSQueueView.prototype._popoverContentForEWSQueue): Build the popover.
2165         (EWSQueueView.prototype._presentPopoverForEWSQueue): Start loading data, and present
2166         it when done.
2167
2168         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
2169         Added rules for EWS popover. Removed a duplicate rule for build-logs-popover.
2170         Changed a few difficult to read padding styles to padding-left.
2171
2172 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
2173
2174         Fix webkitpy tests.
2175
2176         * Scripts/webkitpy/common/net/web_mock.py: (MockBrowser.set_handle_robots):
2177         Added a mock implementation, as we now call this function.
2178
2179 2014-01-20  Darin Adler  <darin@apple.com>
2180
2181         Update style checker and tests to deal with override instead of OVERRIDE
2182         https://bugs.webkit.org/show_bug.cgi?id=127175
2183
2184         Reviewed by Anders Carlsson.
2185
2186         * Scripts/webkitpy/style/checkers/cpp.py:
2187         (check_braces): Use override instead of OVERRIDE.
2188         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2189         (CppStyleTest.test_brace_at_begin_of_line): Ditto.
2190
2191 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
2192
2193         EWS should provide better information to Dashboard via JSON
2194         https://bugs.webkit.org/show_bug.cgi?id=127265
2195
2196         Reviewed by Ryosuke Niwa.
2197
2198         * QueueStatusServer/app.yaml: Updated version.
2199
2200         * QueueStatusServer/main.py:
2201         * QueueStatusServer/handlers/queuelengthjson.py:
2202         Added a way to cheaply get only the queue length, which is all the dashboard
2203         needs unless a popover is opened.
2204
2205         * QueueStatusServer/handlers/queuestatusjson.py: Updated to return more information
2206         that we will need. Changed some field names to be more meaningful. Fixed bot listing
2207         to understand that a bot can be reprurposed and used in a different queue.
2208
2209 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
2210
2211         Make uploading results to EWS work despite robots.txt
2212         https://bugs.webkit.org/show_bug.cgi?id=127296
2213
2214         Reviewed by Ryosuke Niwa.
2215
2216         * Scripts/webkitpy/common/net/statusserver.py: (StatusServer.__init__): Disable
2217         checking robots.txt.
2218
2219         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: (Bugzilla._get_browser):
2220         Removed a comment saying that we would want to stop doing this. Not checking
2221         robots.txt is more efficient than checking it.
2222
2223 2014-01-19  Ryuan Choi  <ryuan.choi@samsung.com>
2224
2225         [EFL][WK1] Remove and refactor the APIs which use single and base keyword
2226         https://bugs.webkit.org/show_bug.cgi?id=127214
2227
2228         Reviewed by Gyuyoung Kim.
2229
2230         Followed the changes of API.
2231
2232         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2233         (drtViewAdd):
2234         * EWebLauncher/main.c:
2235         (windowCreate):
2236
2237 2014-01-19  Eunmi Lee  <eunmi15.lee@samsung.com>
2238
2239         [EFL][WK2] Add touch events option to MiniBrowser.
2240         https://bugs.webkit.org/show_bug.cgi?id=127262
2241
2242         Reviewed by Gyuyoung Kim.
2243
2244         As a default, touch events are disabled and mouse events are enabled.
2245         If touch events option sets to true, touch events are enabled and mouse
2246         events are disabled.
2247
2248         * MiniBrowser/efl/main.c:
2249         (window_create):
2250         (elm_main):
2251
2252 2014-01-19  Zalan Bujtas  <zalan@apple.com>
2253
2254         Pretty print LayoutUnit, LayoutPoint, and LayoutSize in lldb and gdb.
2255         https://bugs.webkit.org/show_bug.cgi?id=126080
2256
2257         Reviewed by Sam Weinig.
2258
2259         This changes the output of printing LayoutUnits to be in px but it also
2260         preserves the original LayoutUnit value.
2261
2262         This will lead to lldb output like: (and it works even when subpixel is disabled)
2263
2264         (const WebCore::LayoutRect) $0 = {
2265             m_location = { x = 2.25px (144), y = 1px (64)}
2266             m_size = { width = 13.75px (880), height = 20px (1280) }
2267
2268
2269         And gdb output like:
2270
2271         m_frameRect = {
2272             m_location = LayoutPoint(0px (0), 0px(0)),
2273             m_size = LayoutSize(8px (512), 5px (320))
2274         }
2275
2276         This patch is based on patch by bjonesbe@adobe.com and for Blink by cbiesinger@chromium.org.
2277
2278         * gdb/webkit.py:
2279         (WebCoreLayoutUnitPrinter):
2280         (WebCoreLayoutUnitPrinter.__init__):
2281         (WebCoreLayoutUnitPrinter.to_string):
2282         (WebCoreLayoutSizePrinter):
2283         (WebCoreLayoutSizePrinter.__init__):
2284         (WebCoreLayoutSizePrinter.to_string):
2285         (WebCoreLayoutPointPrinter):
2286         (WebCoreLayoutPointPrinter.__init__):
2287         (WebCoreLayoutPointPrinter.to_string):
2288         (add_pretty_printers):
2289         * lldb/lldb_webkit.py:
2290         (__lldb_init_module):
2291         (WebCoreLayoutUnit_SummaryProvider):
2292         (WebCoreLayoutSize_SummaryProvider):
2293         (WebCoreLayoutPoint_SummaryProvider):
2294         (WebCoreLayoutUnitProvider):
2295         (WebCoreLayoutUnitProvider.__init__):
2296         (WebCoreLayoutUnitProvider.to_string):
2297         (WebCoreLayoutSizeProvider):
2298         (WebCoreLayoutSizeProvider.__init__):
2299         (WebCoreLayoutSizeProvider.get_width):
2300         (WebCoreLayoutSizeProvider.get_height):
2301         (WebCoreLayoutPointProvider):
2302         (WebCoreLayoutPointProvider.__init__):
2303         (WebCoreLayoutPointProvider.get_x):
2304         (WebCoreLayoutPointProvider.get_y):
2305
2306 2014-01-18  Alexey Proskuryakov  <ap@apple.com>
2307
2308         Add robots.txt to http://webkit-queues.appspot.com
2309         https://bugs.webkit.org/show_bug.cgi?id=127240
2310
2311         * QueueStatusServer/app.yaml: Added required "upload" attribute for robots.txt.
2312
2313 2014-01-18  Alexey Proskuryakov  <ap@apple.com>
2314
2315         Add robots.txt to http://webkit-queues.appspot.com
2316         https://bugs.webkit.org/show_bug.cgi?id=127240
2317
2318         Reviewed by Ryosuke Niwa.
2319
2320         * QueueStatusServer/app.yaml: Added robots.txt as a static file. Updated version.
2321
2322         * QueueStatusServer/robots.txt: Added.
2323
2324 2014-01-18  Alberto Garcia  <berto@igalia.com>
2325
2326         Tools/Scripts/test-webkitperl fails: 'tempdir' can't be called as a method
2327         https://bugs.webkit.org/show_bug.cgi?id=127217
2328
2329         Reviewed by Daniel Bates.
2330
2331         The syntax File::Temp->tempdir() was explicitly made invalid
2332         following <https://github.com/Perl-Toolchain-Gang/File-Temp/commit/c8920b2161ab6900a09e02b9410e0e4c3d74f565>
2333         which was included in File::Temp v2.30, shipped with Perl v5.18.0.
2334
2335         Use File::Temp::tempdir() instead.
2336
2337         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
2338
2339 2014-01-18  Alexey Proskuryakov  <ap@apple.com>
2340
2341         build.webkit.org/dashboard should have image diff links in test results popovers
2342         https://bugs.webkit.org/show_bug.cgi?id=127188
2343
2344         Reviewed by Timothy Hatcher.
2345
2346         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2347         (Buildbot.prototype.layoutTestImagesURLForIteration):
2348         (Buildbot.prototype.layoutTestImageDiffURLForIteration):
2349         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2350         (BuildbotIteration.prototype.loadLayoutTestResults):
2351         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2352         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions.addFailureInfoLink):
2353         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions.addFailureInfoText):
2354         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
2355
2356 2014-01-18  Anders Carlsson  <andersca@apple.com>
2357
2358         Remove ENABLE_THREADED_HTML_PARSER defines everywhere
2359         https://bugs.webkit.org/show_bug.cgi?id=127225
2360
2361         Reviewed by Andreas Kling.
2362
2363         This concludes the removal of over 8.8 million lines of threaded parser code.
2364
2365         * Scripts/webkitperl/FeatureList.pm:
2366
2367 2014-01-17  Alexey Proskuryakov  <ap@apple.com>
2368
2369         build.webkit.org/dashboard should have diff links in test results popovers
2370         https://bugs.webkit.org/show_bug.cgi?id=126986
2371
2372         Reviewed by Tim Horton.
2373
2374         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2375         (Buildbot.prototype.layoutTestCrashLogURLForIteration):
2376         (Buildbot.prototype.layoutTestStderrURLForIteration):
2377         (Buildbot.prototype.layoutTestDiffURLForIteration):
2378         (Buildbot.prototype.layoutTestPrettyDiffURLForIteration):
2379         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2380         (BuildbotIteration.prototype.loadLayoutTestResults):
2381         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2382         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
2383
2384 2014-01-17  Matthew Hanson  <matthew_hanson@apple.com>
2385
2386         Add the bare minimum support for branches to the bot-watchers dashboard
2387         https://bugs.webkit.org/show_bug.cgi?id=127124
2388
2389         This patch simply introduces the notion of branches into the bot-watchers dashboard.
2390         Subsequent patches will build functionality on top of this simple bit of infrastructure.
2391
2392         Reviewed by Timothy Hatcher.
2393
2394         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2395         (BuildbotQueue): store the branch property in the BuildbotQueue constructor
2396         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2397         Initialize the Dashboard.Branch object
2398
2399 2014-01-17  Chris Fleizach  <cfleizach@apple.com>
2400
2401         platform/mac/accessibility/aria-multiline.html sometimes asserts in AccessibilityController::removeNotificationListener
2402         https://bugs.webkit.org/show_bug.cgi?id=127141
2403
2404         Reviewed by Alexey Proskuryakov.
2405
2406         Make sure to reset the notification handler each time.
2407
2408         * DumpRenderTree/AccessibilityController.cpp:
2409         (AccessibilityController::resetToConsistentState):
2410         * DumpRenderTree/AccessibilityController.h:
2411         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
2412         (AccessibilityController::platformResetToConsistentState):
2413         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
2414         (AccessibilityController::platformResetToConsistentState):
2415         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2416         (AccessibilityController::~AccessibilityController):
2417         (AccessibilityController::platformResetToConsistentState):
2418         (AccessibilityController::removeNotificationListener):
2419         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2420         (AccessibilityController::platformResetToConsistentState):
2421
2422 2014-01-17  Alberto Garcia  <berto@igalia.com>
2423
2424         [GTK] Test /webkit/download/not-found fails in GTK Linux 64-bit Release bot
2425         https://bugs.webkit.org/show_bug.cgi?id=82329
2426
2427         Reviewed by Carlos Garcia Campos.
2428
2429         Unskip, this is working fine now.
2430
2431         * Scripts/run-gtk-tests:
2432         (TestRunner):
2433
2434 2014-01-17  Alberto Garcia  <berto@igalia.com>
2435
2436         [GTK] Test /webkit/webview/icon-uri times out in GTK Linux 64-bit Release bot
2437         https://bugs.webkit.org/show_bug.cgi?id=82328
2438
2439         Reviewed by Carlos Garcia Campos.
2440
2441         This was caused by the icon database being corrupted in the
2442         Release bot. After removing it the test works fine so it can be
2443         run again.
2444
2445         * Scripts/run-gtk-tests:
2446         (TestRunner):
2447
2448 2014-01-16  Alexey Proskuryakov  <ap@apple.com>
2449
2450         Test results popovers at http://build.webkit.org/dashboard should link to stderr
2451         https://bugs.webkit.org/show_bug.cgi?id=126929
2452
2453         Reviewed by Timothy Hatcher.
2454
2455         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2456         (Buildbot.prototype.layoutTestCrashLogURLForIteration): Renamed for consistency.
2457         (Buildbot.prototype.layoutTestStderrURLForIteration): Added.
2458
2459         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2460         (BuildbotIteration.prototype.loadLayoutTestResults): Store has_stderr attribute.
2461
2462         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2463         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
2464         Add a link to stderr output if present.
2465
2466         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
2467         (.test-results-popover .additional-link): Style with light grey (will use the same style
2468         for diff links).
2469
2470 2014-01-16  Ryosuke Niwa  <rniwa@webkit.org>
2471
2472         Automate DoYouEvenBench
2473         https://bugs.webkit.org/show_bug.cgi?id=124497
2474
2475         Reviewed by Geoffrey Garen.
2476
2477         * Scripts/webkitpy/performance_tests/perftest.py:
2478         (PerfTestMetric.__init__): Added the aggregator name as an argument.
2479         (PerfTestMetric.aggregator): Added.
2480         (PerfTest._metrics_regex): Made the subtest name match non-greedy so that the metric names will be
2481         won't be eagerly parsed as a part of the subtest name. e.g. "Time" and "Total" in "a:Time:Total"
2482         should be parsed as the metric and the aggregator respectively.
2483         (PerfTest._run_with_driver): Pass in the aggregator name.
2484         (PerfTest._ensure_metrics): Ditto. Also split the subtest name by / as required by DoYouEvenBench
2485         which generates subtests of subtests within a single test file.
2486
2487         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2488         (test_parse_output_with_subtests_and_total): Added.
2489
2490         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2491         (_generate_results_dict): Add the aggregator name to the JSON when one is available.
2492
2493         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2494         (TestWithSubtestsData): Added a sub test with an aggregator and a sub-sub test.
2495
2496 2014-01-16  Chris Fleizach  <cfleizach@apple.com>
2497
2498         platform/mac/accessibility/aria-multiline.html sometimes asserts in AccessibilityController::removeNotificationListener
2499         https://bugs.webkit.org/show_bug.cgi?id=127141
2500
2501         Reviewed by Alexey Proskuryakov.
2502
2503         Don't assert that the notification handler needs to be cleaned up. Deallocing the controller should be enough to clean up as it is.
2504
2505         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2506         (AccessibilityController::~AccessibilityController):
2507
2508 2014-01-16  Ryosuke Niwa  <rniwa@webkit.org>
2509
2510         EWS shouldn't comment on Bugzilla for failing builds or style errors
2511         https://bugs.webkit.org/show_bug.cgi?id=127079
2512
2513         Reviewed by Anders Carlsson.
2514
2515         Since patch authors and reviewers could retrieve this information from bubbles,
2516         we shouldn't spam the Bugzilla with useless comments.
2517
2518         We still post style errors but not python paths we used since it's a pure noise.
2519
2520         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2521         (AbstractEarlyWarningSystem._post_reject_message_on_bug):
2522         * Scripts/webkitpy/tool/commands/queues.py:
2523         (StyleQueue.review_patch):
2524
2525 2014-01-15  Roger Fong  <roger_fong@apple.com>
2526
2527         Add support for handling WebGL load policies.
2528         https://bugs.webkit.org/show_bug.cgi?id=126935
2529         <rdar://problem/15790448>.
2530
2531         Reviewed by Timothy Horton.
2532
2533         * WebKitTestRunner/TestController.cpp: Update WKPageLoaderClient to V4.
2534         (WTR::TestController::createWebViewWithOptions):
2535
2536 2014-01-16  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2537
2538         Remove workaround for compilers not supporting explicit override control
2539         https://bugs.webkit.org/show_bug.cgi?id=127111
2540
2541         Reviewed by Anders Carlsson.
2542
2543         Now all compilers support explicit override control, this workaround can be removed.
2544
2545         * DumpRenderTree/gtk/fonts/fonts.conf:
2546         * Scripts/do-webcore-rename:
2547         Removed this rename operation from the list of contemplated future renames.
2548         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
2549         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
2550         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
2551         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
2552         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2553
2554 2014-01-16  Oliver Hunt  <oliver@apple.com>
2555
2556         Stop run-jsc from consuming stderr output
2557         https://bugs.webkit.org/show_bug.cgi?id=127115
2558
2559         Reviewed by Mark Lam.
2560
2561         Simple patch to make run-jsc easier to deal with
2562
2563         * Scripts/run-jsc:
2564
2565 2014-01-16  Eva Balazsfalvi  <balazsfalvi.eva@stud.u-szeged.hu>
2566
2567         Tools/gtk/generate-feature-defines-files doesn't work with older versions of python
2568         https://bugs.webkit.org/show_bug.cgi?id=126323
2569
2570         Reviewed by Csaba Osztrogonác.
2571
2572         * gtk/generate-feature-defines-files:
2573
2574 2014-01-16  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
2575
2576         [EFL][WK2] Implement TestController::setHidden
2577         https://bugs.webkit.org/show_bug.cgi?id=127036
2578
2579         Reviewed by Gyuyoung Kim.
2580
2581         WebKitTestRunner needs TestController::setHidden implementation to
2582         properly handle page visibility API layout tests after r161105.
2583
2584         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2585         (WTR::TestController::setHidden):
2586
2587 2014-01-16  Zan Dobersek  <zdobersek@igalia.com>
2588
2589         [GTK][MiniBrowser] The progress entry reset callback can be fired after the BrowserWindow is destroyed
2590         https://bugs.webkit.org/show_bug.cgi?id=127083
2591
2592         Reviewed by Carlos Garcia Campos.
2593
2594         When the load progress reaches 1.0 (i.e. 100%), a timeout callback is set up in webViewLoadProgressChanged.
2595         The progress entry is then reset back to 0 in that callback and the timeout source is removed.
2596
2597         The callback can be fired after the relevant BrowserWindow and its progress entry are destroyed, causing
2598         assertion failures in gtk_entry_set_progress_fraction due to an invalid GtkEntry object. To avoid that,
2599         To avoid that, the ID of the timeout source is stored on the BrowserWindow and is destroyed when the
2600         BrowserWindow object is being finalized, preventing the callback from firing.
2601
2602         * MiniBrowser/gtk/BrowserWindow.c:
2603         (resetEntryProgress):
2604         (webViewLoadProgressChanged):
2605         (browserWindowFinalize):
2606
2607 2014-01-15  Alexey Proskuryakov  <ap@apple.com>
2608
2609         DumpRenderTree doesn't disable web preferences autosave
2610         https://bugs.webkit.org/show_bug.cgi?id=127062
2611
2612         Reviewed by Dan Bernstein.
2613
2614         * DumpRenderTree/mac/DumpRenderTree.mm: (prepareConsistentTestingEnvironment):
2615         Do it.
2616
2617 2014-01-15  Dean Jackson  <dino@apple.com>
2618
2619         Improve filter-build-webkit, especially for iOS builds
2620         https://bugs.webkit.org/show_bug.cgi?id=81046
2621
2622         Reviewed by Joseph Pecoraro.
2623
2624         Lots of updates to the filtering rules, mostly from the
2625         iOS build output. Other highlights include:
2626         - ignoring escape sequences for color ouput
2627         - detecting escaped spaces in file name regexps
2628
2629         * Scripts/filter-build-webkit:
2630         (shouldIgnoreLine):
2631
2632 2014-01-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2633
2634         [GTK] Web process sometimes crashes when printing in synchronous mode
2635         https://bugs.webkit.org/show_bug.cgi?id=126979
2636
2637         Reviewed by Gustavo Noronha Silva.
2638
2639         * Scripts/run-gtk-tests:
2640         (TestRunner): Unskip
2641         /webkit2/WebKitPrintOperation/close-after-print.
2642
2643 2014-01-15  ChangSeok Oh  <changseok.oh@collabora.com>
2644
2645         [EFL] Change test font installed path to webkitgtk-font-tests
2646         https://bugs.webkit.org/show_bug.cgi?id=126723
2647
2648         Reviewed by Gyuyoung Kim.
2649
2650         I'd like to change the test fonts installed directory from 'webkitgtk-test-fonts-0.0.3'
2651         to 'webkitgtk-test-fonts'. webkitgtk-test-fonts-0.0.3 doesn't match the path
2652         hard-coded in FontManagement.cpp#105
2653
2654         * DumpRenderTree/PlatformEfl.cmake:
2655         * WebKitTestRunner/PlatformEfl.cmake:
2656         * efl/jhbuild.modules:
2657
2658 2014-01-14  Ryosuke Niwa  <rniwa@webkit.org>
2659
2660         Make DoYouEvenBench runnable by run-perf-tests
2661         https://bugs.webkit.org/show_bug.cgi?id=127030
2662
2663         Reviewed by Andreas Kling.
2664
2665         Ignore console messages spit out by DoYouEvenBench and support aggregator names such as
2666         ":Total" to appear at the end of a test name. We don't do anything with it for now.
2667
2668         * Scripts/webkitpy/performance_tests/perftest.py:
2669         (PerfTest._metrics_regex): Handle aggregator names such as ":Total". We'll pass it down
2670         to the JSON in a follow up patch for the perf dashboard.
2671         (PerfTest._lines_to_ignore_in_parser_result): Added lines to ignore for DoYouEvenBench.
2672
2673 2014-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
2674
2675         [GTK] UI process crashes when the web process crashes while printing
2676         https://bugs.webkit.org/show_bug.cgi?id=126977
2677
2678         Reviewed by Gustavo Noronha Silva.
2679
2680         Add new test case to check that closing the window right after
2681         printing works. It's skipped for now, because this patch only
2682         fixes the UI process crash, but not the web process one.
2683
2684         * Scripts/run-gtk-tests:
2685         (TestRunner): Skip
2686         /webkit2/WebKitPrintOperation/close-after-print.
2687         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
2688         (testPrintOperationPrintPrinter):
2689         (findPrintToFilePrinter):
2690         (testPrintOperationPrint):
2691         (testPrintOperationErrors):
2692         (testPrintOperationCloseAfterPrint):
2693         (beforeAll):
2694
2695 2014-01-14  Brent Fulgham  <bfulgham@apple.com>
2696
2697         [WIN] Set MSBuild environment variable to avoid long-lived processes locking log files
2698         https://bugs.webkit.org/show_bug.cgi?id=127002
2699
2700         Reviewed by David Kilzer.
2701
2702         * Scripts/webkitdirs.pm:
2703         (setupAppleWinEnv): Export MSBUILDDISABLENODEREUSE=1 to the environment.
2704
2705 2014-01-14  Commit Queue  <commit-queue@webkit.org>
2706
2707         Unreviewed, rolling out r162000.
2708         http://trac.webkit.org/changeset/162000
2709         https://bugs.webkit.org/show_bug.cgi?id=127009
2710
2711         API versioning is wrong (Requested by rfong on #webkit).
2712
2713         * MiniBrowser/mac/WK2BrowserWindowController.m:
2714         (-[WK2BrowserWindowController awakeFromNib]):
2715         * WebKitTestRunner/TestController.cpp:
2716         (WTR::TestController::createOtherPage):
2717         (WTR::TestController::createWebViewWithOptions):
2718
2719 2014-01-13  Roger Fong  <roger_fong@apple.com>
2720
2721         Add support for handling WebGL load policies.
2722         https://bugs.webkit.org/show_bug.cgi?id=126935
2723         <rdar://problem/15790448>.
2724
2725         Reviewed by Brent Fulgham.
2726
2727         * MiniBrowser/mac/WK2BrowserWindowController.m:
2728         (-[WK2BrowserWindowController awakeFromNib]):
2729         * WebKitTestRunner/TestController.cpp:
2730         (WTR::TestController::createWebViewWithOptions):
2731
2732 2014-01-14  Zan Dobersek  <zdobersek@igalia.com>
2733
2734         [GTK] Skip FontConfig initialization in WebKitTestRunner if requested
2735         https://bugs.webkit.org/show_bug.cgi?id=120110
2736
2737         Reviewed by Martin Robinson.
2738
2739         Skip the FontConfig settings initialization in WebKitTestRunner if the
2740         WEBKIT_SKIP_WEBKITTESTRUNNER_FONTCONFIG_INITIALIZATION environment variable is set.
2741         This is useful when profiling the WebKitTestRunner execution, where at the startup
2742         this step takes considerable amount of time and disturbs the profiling output.
2743
2744         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2745         (WTR::initializeFontConfigSetting):
2746
2747 2014-01-14  Brian J. Burg  <burg@cs.washington.edu>
2748
2749         Add ENABLE(WEB_REPLAY) feature flag to the build system
2750         https://bugs.webkit.org/show_bug.cgi?id=126949
2751
2752         Reviewed by Joseph Pecoraro.
2753
2754         * Scripts/webkitperl/FeatureList.pm:
2755
2756 2014-01-14  László Langó  <llango.u-szeged@partner.samsung.com>
2757
2758         REGRESSION (r160085): check-webkit-style: utf8' codec can't decode byte 0x89 in position 0: invalid start byte.
2759         https://bugs.webkit.org/show_bug.cgi?id=126702
2760
2761         Reviewed by Alexey Proskuryakov.
2762
2763         Resolve regression and remove a FIXME comment that is already fixed.
2764
2765         * Scripts/webkitpy/common/system/filesystem.py:
2766         (FileSystem.open_text_file_for_reading):
2767         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2768         (RealFileSystemTest.test_read_and_write_file):
2769         * Scripts/webkitpy/style/filereader.py:
2770         (TextFileReader._read_lines):
2771         * Scripts/webkitpy/style/filereader_unittest.py:
2772         (TextFileReaderTest.test_count_delete_only_file):
2773         (TextFileReaderTest):
2774         (TextFileReaderTest.test_process_malformed_file):
2775
2776 2014-01-02  Brian Holt  <brian.holt@samsung.com>
2777
2778         [GTK] Parse Valgrind xml leak files
2779         https://bugs.webkit.org/show_bug.cgi?id=119446
2780
2781         Reviewed by Alejandro G. Castro.
2782
2783         Parse the xml files generated by Valgrind to yield useful
2784         information about the memory leaks.
2785
2786         * Scripts/webkitpy/port/gtk.py:
2787         (GtkPort.__init__):
2788         (GtkPort.setup_test_run): Clear the previous output files before new
2789         run.
2790         (GtkPort.print_leaks_summary):
2791
2792         * Scripts/webkitpy/port/leakdetector_valgrind.py: Added.
2793         Parse the xml files generated by Valgrind and summarise leaks
2794         into an easily understandable list.
2795         (get_text_of):
2796         (get_CDATA_of):
2797         (gather_frames):
2798         (ValgrindError):
2799         (ValgrindError.__init__):
2800         (ValgrindError.__str__):
2801         (ValgrindError.unique_string):
2802         (ValgrindError.error_hash):
2803         (ValgrindError.__hash__):
2804         (ValgrindError.__eq__):
2805         (LeakDetectorValgrind):
2806         (LeakDetectorValgrind.__init__):
2807         (LeakDetectorValgrind._parse_leaks_output):
2808         (LeakDetectorValgrind.leaks_files_in_results_directory):
2809         (LeakDetectorValgrind.clean_leaks_files_from_results_directory):
2810         (LeakDetectorValgrind.parse_and_print_leaks_detail):
2811
2812         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Added.
2813         (make_mock_valgrind_output):
2814         (make_mock_incomplete_valgrind_output):
2815         (make_mock_valgrind_results):
2816         (make_mock_valgrind_results_incomplete):
2817         (make_mock_valgrind_results_empty):
2818         (make_mock_valgrind_results_misformatted):
2819         (mock_run_cppfilt_command):
2820         (LeakDetectorValgrindTest):
2821         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
2822         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
2823         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
2824         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
2825         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
2826         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
2827         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
2828         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
2829
2830 2014-01-13  Lucas Forschler  <lforschler@apple.com>
2831
2832         Update the LLINT CLoop Bot build infrastructure
2833         https://bugs.webkit.org/show_bug.cgi?id=126604
2834         
2835         Unreviewed.
2836         
2837         * BuildSlaveSupport/build.webkit.org-config/config.json:
2838         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2839         (CompileLLINTCLoop):
2840         (RunLLINTCLoopTests):
2841         (BuildAndTestLLINTCLoopFactory):
2842         (BuildAndTestLLINTCLoopFactory.__init__):
2843
2844 2014-01-13  Jinwoo Song  <jinwoo7.song@samsung.com>
2845
2846         [EFL][WK2] Disable failing API tests
2847         https://bugs.webkit.org/show_bug.cgi?id=126960
2848
2849         Reviewed by Gyuyoung Kim.
2850
2851         Disable WKViewUserViewportToContents test until bug 126261 is resolved.
2852
2853         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
2854         (TestWebKitAPI::TEST):
2855
2856 2014-01-13  Daniel Batyai  <dbatyai.u-szeged@partner.samsung.com>
2857
2858         Remove wdiff
2859         https://bugs.webkit.org/show_bug.cgi?id=124766
2860
2861         Reviewed by Ryosuke Niwa.
2862
2863         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
2864         (ResultsJSONParserTest):
2865         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2866         (TestResultWriter):
2867         (TestResultWriter.create_text_diff_and_write_result):
2868         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2869         (summarize_results):
2870         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2871         (RunTest.test_output_diffs):
2872         * Scripts/webkitpy/port/base.py:
2873         (Port.__init__):
2874         (Port.driver_stop_timeout):
2875         (Port.check_image_diff):
2876         (Port.repository_paths):
2877         (Port._path_to_lighttpd_php):
2878         * Scripts/webkitpy/port/base_unittest.py:
2879         (PortTest.test_default_child_processes):
2880         (PortTest.test_pretty_patch_script_error):
2881         * Scripts/webkitpy/port/port_testcase.py:
2882         (PortTestCase.test_diff_image_crashed):
2883         * Scripts/webkitpy/port/test.py:
2884         (TestPort.operating_system):
2885
2886 2014-01-13  Martin Robinson  <mrobinson@igalia.com>
2887
2888         Build fix for the GTK+ CMake port
2889
2890         * TestWebKitAPI/PlatformGTK.cmake: The WKConnection test is no longer with us.
2891
2892 2014-01-13  Adrian Perez de Castro  <aperez@igalia.com>
2893
2894         [GTK] Add cast in call to g_object_add_weak_pointer in MiniBrowser
2895         https://bugs.webkit.org/show_bug.cgi?id=126881
2896
2897         Reviewed by Carlos Garcia Campos.
2898
2899         * MiniBrowser/gtk/BrowserWindow.c:
2900         (browser_window_new):
2901         Explicitly cast GtkWindow** to gpointer* in call to
2902         g_object_add_weak_pointer to avoid compiler warnings.
2903
2904 2014-01-13  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2905
2906         Remove parsing of old-run-webkit-tests output from master.cfg
2907         https://bugs.webkit.org/show_bug.cgi?id=126690
2908
2909         Reviewed by Csaba Osztrogonác.
2910
2911         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2912         Removed parsing of ORWT output, as it is not used anymore.
2913         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2914         Updated unit tests accordingly.
2915
2916 2014-01-13  Commit Queue  <commit-queue@webkit.org>
2917
2918         Unreviewed, rolling out r161808.
2919         http://trac.webkit.org/changeset/161808
2920         https://bugs.webkit.org/show_bug.cgi?id=126874
2921
2922         This patch make several files to be always regenerated on
2923         every make (Requested by KaL on #webkit).
2924
2925         * WebKitTestRunner/GNUmakefile.am:
2926
2927 2014-01-13  Adrian Perez de Castro  <aperez@igalia.com>
2928
2929         [GTK] Make MiniBrowser windows non-transient by default
2930         https://bugs.webkit.org/show_bug.cgi?id=126840
2931
2932         Reviewed by Carlos Garcia Campos.
2933
2934         Instead of making new browser windows transient as soon as they are
2935         created, save the pointer to the parent window and set the transient
2936         state later on when handling the "run-as-modal" signal. This makes
2937         it easier to use the MiniBrowser to do tests involving multiple
2938         windows, and will be useful as well when multi-web-process mode is
2939         enabled for the GTK port.
2940
2941         * MiniBrowser/gtk/BrowserWindow.c:
2942         (webViewRunAsModal): Set the parent window using
2943         gtk_window_set_transient_for() using the saved parent
2944         window.
2945         (browser_window_new): Save the parent window using
2946         g_object_set_data() instead of making the new window
2947         transient immediately.
2948
2949 2014-01-12  Sergio Correia  <sergio.correia@openbossa.org>
2950
2951         [EFL][WK2] Make API tests work again
2952         https://bugs.webkit.org/show_bug.cgi?id=126769
2953
2954         Reviewed by Gyuyoung Kim.
2955
2956         The EFL and WK2 test binaries are currently being generated at *TestWebKitAPI/
2957         [E]WebKit2, respectively, and this causes problems because the logic to find
2958         where WebProcess is to look in the same directory of the running process and
2959         then proceed to use LIBEXECDIR (typically /usr/loca/bin).
2960
2961         This patch introduces a WEBKIT_EXEC_PATH environment variable, inspired in the
2962         Gtk port, which allows us to look for WebProcess initially in this directory,
2963         if it's defined.
2964
2965         * TestWebKitAPI/efl/main.cpp:
2966         (main): Define WEBKIT_EXEC_PATH to be used by WebKit2 API tests.
2967
2968 2014-01-12  Daniel Bates  <dabates@apple.com>
2969
2970         [iOS] Fix the build
2971
2972         For now, ensure we build WebKit System Interface before we build WebKit.
2973         We'll remove this constraint and the constraint to build WebKit Additions
2974         in a subsequent commit.
2975
2976         * Scripts/build-webkit:
2977
2978 2014-01-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2979
2980         Unreviewed. Fix make distcheck.
2981
2982         * gtk/GNUmakefile.am: Add generate-inspector-gresource-manifest.py
2983         to EXTRA_DIST.
2984
2985 2014-01-12  Tobias Mueller  <tobiasmue@gnome.org>
2986
2987         --disable-dependency-tracking causes build failure due to missing directories
2988         https://bugs.webkit.org/show_bug.cgi?id=94488
2989
2990         Reviewed by Gustavo Noronha Silva.
2991
2992         Autotools build fix: Ensure output directory existing
2993         before generating DerivedSources. This allows for
2994         --disable-dependency-tracking to be run.
2995
2996
2997         * WebKitTestRunner/GNUmakefile.am: Added a new target of the directory in which files are meant to be stored.
2998
2999 2014-01-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3000
3001         [GTK] Fix return value of WebKitDownload::created-destination
3002         https://bugs.webkit.org/show_bug.cgi?id=126741
3003
3004         Reviewed by Martin Robinson.
3005
3006         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp: Fix return
3007         value of several callbacks.
3008
3009 2014-01-11  Sam Weinig  <sam@webkit.org>
3010
3011         Add support for null StringViews
3012         https://bugs.webkit.org/show_bug.cgi?id=126827
3013
3014         Reviewed by Anders Carlsson.
3015
3016         Add new test for StringView.
3017
3018         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3019         * TestWebKitAPI/Tests/WTF/StringView.cpp: Added.
3020         (TestWebKitAPI::TEST):
3021
3022 2014-01-10  Benjamin Poulain  <bpoulain@apple.com>
3023
3024         Remove the BlackBerry port from trunk
3025         https://bugs.webkit.org/show_bug.cgi?id=126715
3026
3027         Reviewed by Anders Carlsson.
3028
3029         * DumpRenderTree/DumpRenderTree.h:
3030         * DumpRenderTree/PixelDumpSupport.cpp:
3031
3032 2014-01-10  Daniel Bates  <dabates@apple.com>
3033
3034         [iOS] Fix project build order
3035
3036         Ensure we build WebKitAdditions before WebCore (if applicable). Also, we don't
3037         build WebInspectorUI, Tools/MiniBrowser, or Tools/WebKitTestRunner on iOS at the
3038         time of writing.
3039
3040         * Scripts/build-webkit:
3041
3042 2014-01-10  Mario Sanchez Prada  <mario.prada@samsung.com>
3043
3044         Move platformName property from testRunner to accessibilityController
3045         https://bugs.webkit.org/show_bug.cgi?id=126689
3046
3047         Reviewed by Chris Fleizach.
3048
3049         Move the platformName property from the testRunner into
3050         accessibilityController, since this is a concept that has only be
3051         used by accessibility tests since it got added, and also because
3052         the real intention was not to distinguish among "ports" (mac, win,
3053         gtk, efl) but between platforms (atk, mac, win).
3054
3055         This change will be very useful to merge GTK's roles-exposed.html
3056         and Mac's role-subrole-roledescription.html into one single test,
3057         since we will be specifying in the test itself which elements are
3058         supported in which accessibility "platform". In this context,
3059         being able to check accessibilityController.platformName directly
3060         against a list of supported accessibility platforms (e.g. "atk,mac")
3061         will certainly maintain the code cleaner and simpler.
3062
3063         * DumpRenderTree/TestRunner.h:
3064         (TestRunner::platformName): Removed.
3065         * DumpRenderTree/TestRunner.cpp:
3066         (getPlatformNameCallback): Removed.
3067         (TestRunner::staticValues): Removed platformName
3068         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3069         (TestRunner::platformName): Removed.
3070         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3071         (TestRunner::platformName): Removed.
3072         * DumpRenderTree/mac/TestRunnerMac.mm:
3073         (TestRunner::platformName): Removed.
3074         * DumpRenderTree/win/TestRunnerWin.cpp:
3075         (TestRunner::platformName): Removed.
3076
3077         * DumpRenderTree/AccessibilityController.h:
3078         (AccessibilityController::platformName): Added.
3079         * DumpRenderTree/AccessibilityController.cpp:
3080         (getPlatformNameCallback): Added.
3081         (AccessibilityController::getJSClass): Added platformName.
3082         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
3083         (AccessibilityController::platformName): Added, returning "atk".
3084         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3085         (AccessibilityController::platformName): Ditto, returning "mac".
3086         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
3087         (AccessibilityController::platformName): Ditto, returning "ios".
3088         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3089         (AccessibilityController::platformName): Ditto, returning "win".
3090
3091         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3092         (platformName): Removed.
3093         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3094         (TestRunner::platformName): Removed.
3095         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
3096         (TestRunner::platformName): Removed.
3097         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
3098         (TestRunner::platformName): Removed.
3099         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
3100         (TestRunner::platformName): Removed.
3101         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
3102         (TestRunner::platformName): Removed.
3103
3104         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
3105         (WTR:AccessibilityController::platformName): Added.
3106         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
3107         (platformName): Added.
3108         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
3109         (WTR::AccessibilityController::platformName): Added, returning "atk".
3110         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
3111         (WTR::AccessibilityController::platformName): Added, returning "mac".
3112
3113 2014-01-10  Benjamin Poulain  <bpoulain@apple.com>
3114
3115         Remove the BlackBerry port from trunk
3116         https://bugs.webkit.org/show_bug.cgi?id=126715
3117
3118         Reviewed by Anders Carlsson.
3119
3120         * Scripts/webkitpy/common/config/watchlist:
3121
3122 2014-01-09  Benjamin Poulain  <bpoulain@apple.com>
3123
3124         Remove the BlackBerry files outside WebCore
3125         https://bugs.webkit.org/show_bug.cgi?id=126715
3126
3127         Reviewed by Anders Carlsson.
3128
3129         * DumpRenderTree/blackberry: Removed.
3130
3131 2014-01-10  Simon Fraser  <simon.fraser@apple.com>
3132
3133         Remove knowledge of Blackberry from build scripts
3134         https://bugs.webkit.org/show_bug.cgi?id=126766
3135
3136         Reviewed by Anders Carlsson.
3137         
3138         Remove isBlackBerry() and references to it, and rmeove
3139         blackberry-related stuff from the watchlist.
3140
3141         * Scripts/build-webkit:
3142         * Scripts/webkit-build-directory:
3143         * Scripts/webkitdirs.pm:
3144         (determineBaseProductDir):
3145         (argumentsForConfiguration):
3146         (builtDylibPathForName):
3147         (isAppleWebKit):
3148         (buildCMakeProjectOrExit):
3149         (cmakeBasedPortArguments):
3150         (cmakeBasedPortName):
3151         * Scripts/webkitperl/FeatureList.pm:
3152         * Scripts/webkitpy/common/config/watchlist:
3153
3154 2014-01-10  Daniel Bates  <dabates@apple.com>
3155
3156         [iOS] Fix up simulator build and enable default features
3157
3158         Rubber-stamped by Joseph Pecoraro.
3159
3160         * Scripts/webkitdirs.pm:
3161         (determineArchitecture):
3162         (determinePassedArchitecture):
3163         * Scripts/webkitperl/FeatureList.pm: Also expose command line option to toggle ENABLE_PLUGIN_PROXY_FOR_VIDEO (enabled
3164         by default only in iOS).
3165
3166 2014-01-10  Daniel Bates  <dabates@apple.com>
3167
3168         [iOS] Upstream WebCore and Tools miscellaneous changes
3169         https://bugs.webkit.org/show_bug.cgi?id=126698
3170
3171         Reviewed by David Kilzer.
3172
3173         * Scripts/check-for-inappropriate-objc-class-names:
3174         * Scripts/check-for-webkit-framework-include-consistency:
3175
3176 2014-01-09  Dan Bernstein  <mitz@apple.com>
3177
3178         [Cocoa] Promote WKBackForwardList{,Item}.h to public
3179         https://bugs.webkit.org/show_bug.cgi?id=126707
3180
3181         Reviewed by Sam Weinig.
3182
3183         * Scripts/check-for-webkit-framework-include-consistency: Account for stale private headers
3184         left behind in the build products directory after a private header is made public.
3185
3186 2014-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
3187
3188         [SOUP] Partial file left on disk after a download fails or is cancelled in WebKit2
3189         https://bugs.webkit.org/show_bug.cgi?id=126686
3190
3191         Reviewed by Martin Robinson.
3192
3193         Test that partial files are not left on disk after a download has
3194         been cancelled after the destination has been decided. To make
3195         sure the download is cancelled after the destination has been
3196         decided and before the operation finishes, we cancel the download
3197         in the destination decided callback, and we use an infinite
3198         resource that writes chunks to the response body and never
3199         completes the body.
3200
3201         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
3202         (addContentDispositionHTTPHeaderToResponse): Helper function to
3203         add the Content-Disposition to the response headers.
3204         (writeNextChunkIdle): Write next chunk to response body.
3205         (writeNextChunk): Write next chunk in an idle to avoid flooding
3206         the network with the inifnite resource.
3207         (serverCallback): Add an inifinite resource.
3208         (testDownloadRemoteFileError): Check that partial file is not
3209         present after the download has been cancelled.
3210
3211 2014-01-09  Roland Takacs  <rtakacs@inf.u-szeged.hu>
3212
3213         Move myself to the committers list.
3214
3215         Unreviewed.
3216
3217         * Scripts/webkitpy/common/config/contributors.json:
3218
3219 2014-01-08  Seokju Kwon  <seokju@webkit.org>
3220
3221         [GTK] Unreviewed build fix after r161522.
3222
3223         * TestWebKitAPI/GNUmakefile.am: Remove WKConnection.cpp and WKConnection_Bundle.cpp.
3224
3225 2014-01-08  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
3226
3227         Missleading style error when mixing system and non-system header include lines.
3228         https://bugs.webkit.org/show_bug.cgi?id=126564
3229
3230         Reviewed by Ryosuke Niwa.
3231
3232         * Scripts/webkitpy/style/checkers/cpp.py:
3233         (check_include_line):
3234         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3235         (OrderOfIncludesTest.test_check_alphabetical_include_order):
3236         (OrderOfIncludesTest.test_public_primary_header):
3237
3238 2014-01-08  Seokju Kwon  <seokju@webkit.org>
3239
3240         [EFL] Unreviewed build fix after r161522.
3241
3242         * TestWebKitAPI/CMakeLists.txt:
3243         * TestWebKitAPI/PlatformEfl.cmake:
3244
3245 2014-01-08  Anders Carlsson  <andersca@apple.com>
3246
3247         Remove WKConnectionRef tests
3248         https://bugs.webkit.org/show_bug.cgi?id=126666
3249
3250         Reviewed by Dan Bernstein.
3251
3252         The WKConnectionRef is poorly designed but thankfully not used anywhere. 
3253         Remove the API tests as a first step towards killing the entire thing.
3254
3255         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3256         * TestWebKitAPI/Tests/WebKit2/WKConnection.cpp: Removed.
3257         * TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp: Removed.
3258
3259 2014-01-08  Commit Queue  <commit-queue@webkit.org>
3260
3261         Unreviewed, rolling out r161512.
3262         http://trac.webkit.org/changeset/161512
3263         https://bugs.webkit.org/show_bug.cgi?id=126655
3264
3265         Broke webkitpy tests (Requested by ap on #webkit).
3266
3267         * Scripts/webkitpy/port/gtk.py:
3268         (GtkPort.__init__):
3269         (GtkPort.setup_test_run):
3270         (GtkPort._port_specific_expectations_files):
3271         * Scripts/webkitpy/port/leakdetector_valgrind.py: Removed.
3272         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Removed.
3273
3274 2014-01-08  Commit Queue  <commit-queue@webkit.org>
3275
3276         Unreviewed, rolling out r161517.
3277         http://trac.webkit.org/changeset/161517
3278         https://bugs.webkit.org/show_bug.cgi?id=126659
3279
3280         The fix didn't completely remove the problem and is now
3281         standing in the way of the rollout of the offending patch
3282         (Requested by zdobersek on #webkit).
3283
3284         * Scripts/webkitpy/port/gtk.py:
3285         (GtkPort.__init__):
3286
3287 2014-01-08  Zan Dobersek  <zdobersek@igalia.com>
3288
3289         Unreviewed. Attempting to fix webkitpy tests after r161512.
3290
3291         * Scripts/webkitpy/port/gtk.py:
3292         (GtkPort.__init__): Construct LeakDetectorValgrin only if leak detection is enabled.
3293
3294 2014-01-08  Brian Holt  <brian.holt@samsung.com>
3295
3296         [GTK] Parse Valgrind xml leak files
3297         https://bugs.webkit.org/show_bug.cgi?id=119446
3298
3299         Reviewed by Alejandro G. Castro.
3300
3301         Parse the xml files generated by Valgrind to yield useful
3302         information about the memory leaks.
3303
3304         * Scripts/webkitpy/port/gtk.py:
3305         (GtkPort.__init__):
3306         (GtkPort.setup_test_run): Clear the previous output files before new
3307         run.
3308         (GtkPort.print_leaks_summary):
3309
3310         * Scripts/webkitpy/port/leakdetector_valgrind.py: Added.
3311         Parse the xml files generated by Valgrind and summarise leaks
3312         into an easily understandable list.
3313         (get_text_of):
3314         (get_CDATA_of):
3315         (gather_frames):
3316         (ValgrindError):
3317         (ValgrindError.__init__):
3318         (ValgrindError.__str__):
3319         (ValgrindError.unique_string):
3320         (ValgrindError.error_hash):
3321         (ValgrindError.__hash__):
3322         (ValgrindError.__eq__):
3323         (LeakDetectorValgrind):
3324         (LeakDetectorValgrind.__init__):
3325         (LeakDetectorValgrind._parse_leaks_output):
3326         (LeakDetectorValgrind.leaks_files_in_results_directory):
3327         (LeakDetectorValgrind.clean_leaks_files_from_results_directory):
3328         (LeakDetectorValgrind.parse_and_print_leaks_detail):
3329
3330         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Added.
3331         (make_mock_valgrind_output):
3332         (make_mock_incomplete_valgrind_output):
3333         (make_mock_valgrind_results):
3334         (make_mock_valgrind_results_incomplete):
3335         (make_mock_valgrind_results_empty):
3336         (make_mock_valgrind_results_misformatted):
3337         (LeakDetectorValgrindTest):
3338         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
3339         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
3340         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
3341         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
3342         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
3343         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
3344         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
3345         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
3346
3347 2014-01-08  Commit Queue  <commit-queue@webkit.org>
3348
3349         Unreviewed, rolling out r161427.
3350         http://trac.webkit.org/changeset/161427
3351         https://bugs.webkit.org/show_bug.cgi?id=126645
3352
3353         Emits a stye error on any newly added files (Requested by ap
3354         on #webkit).
3355
3356         * Scripts/webkitpy/style/checkers/cpp.py:
3357         (check_style):
3358         (CppChecker):
3359         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3360         (WebKitStyleTest.test_other):
3361
3362 2014-01-08  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
3363
3364         Remove run-webkit-tests wrapper script as all platform are using NRWT now.
3365         https://bugs.webkit.org/show_bug.cgi?id=126580
3366
3367         Reviewed by Csaba Osztrogonác.
3368
3369         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3370         (RunWebKitTests): Passing --debug-rwt-logging here instead of the
3371         run-webkit-tests script.
3372         * Scripts/new-run-webkit-tests: Renamed to run-webkit-tests.
3373         * Scripts/run-webkit-tests: Removed, as it was just a temporary hack.
3374
3375 2014-01-08  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
3376
3377         Update the list of non-committer u-szeged contributors
3378         https://bugs.webkit.org/show_bug.cgi?id=126640
3379
3380         Reviewed by Csaba Osztrogonác.
3381
3382         * Scripts/webkitpy/common/config/contributors.json:
3383
3384 2014-01-08  Alberto Garcia  <berto@igalia.com>
3385
3386         Fix some compilation warnings
3387         https://bugs.webkit.org/show_bug.cgi?id=126635
3388
3389         Reviewed by Csaba Osztrogonác.
3390
3391         * GtkLauncher/main.c:
3392         (createWindow): This function is not supposed to receive any
3393         parameter, yet we are passing one.
3394
3395 2014-01-08  Brian Holt  <brian.holt@samsung.com>
3396
3397         [GTK][WK2] unskip passing unit tests
3398         https://bugs.webkit.org/show_bug.cgi?id=126637
3399
3400         Reviewed by Carlos Garcia Campos.
3401
3402         Unskip TestResources and TestAuthentication unit tests since they
3403         are passing both under Xvfb and X.
3404
3405         * Scripts/run-gtk-tests:
3406         (TestRunner):
3407
3408 2014-01-08  Alberto Garcia  <berto@igalia.com>
3409
3410         REGRESSION(r160304): [GTK] Disable libtool fast install
3411         https://bugs.webkit.org/show_bug.cgi?id=126381
3412
3413         Reviewed by Gustavo Noronha Silva.
3414
3415         Disable the libtool fast-install mode in developer/test builds.
3416
3417         In this mode binaries are generated ready to be used directly from
3418         the build tree. Otherwise they would need to be relinked when they
3419         are executed, which can take a lot of resources, particularly in
3420         debug builds.
3421
3422         * Scripts/webkitdirs.pm:
3423         (runAutogenForAutotoolsProjectIfNecessary):
3424
3425 2014-01-08  Zan Dobersek  <zdobersek@igalia.com>
3426
3427         Unreviewed GTK gardening.
3428
3429         * Scripts/run-gtk-tests:
3430         (TestRunner): Skipping the snapshot test case from the TestWebKitWebView test suite.
3431         The test is failing due to issues with Xvfb, with the problem being handled in bug #120404.
3432
3433 2014-01-07  Lucas Forschler  <lforschler@apple.com>
3434
3435         Add buildbot infrasctructure for building and testing JSC cloop
3436         https://bugs.webkit.org/show_bug.cgi?id=126604
3437
3438         Reviewed by Geoffrey Garen.
3439
3440         * BuildSlaveSupport/build.webkit.org-config/config.json:
3441         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3442         (CompileCLOOP):
3443         (RunCLOOPTests):
3444         (RunCLOOPTests.countFailures):
3445         (BuildAndTestCLOOP):
3446
3447 2014-01-07  Brian Burg  <bburg@apple.com>
3448
3449         Unreviewed. Add myself as a committer.
3450
3451         * Scripts/webkitpy/common/config/contributors.json:
3452
3453 2014-01-07  Alexey Proskuryakov  <ap@apple.com>
3454
3455         Popovers at build.webkit.org/dashboard could have titles
3456         https://bugs.webkit.org/show_bug.cgi?id=126495
3457
3458         Reviewed by Timothy Hatcher.
3459
3460         Added titles to all popovers except for pending revisions one, which I would like
3461         to improve more (probably add an ETA).
3462
3463         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
3464         (BuildbotBuilderQueueView.prototype._presentPopoverFailureLogs): Moved code for 
3465         adding a title to base class.
3466
3467         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3468         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Moved code for inserting
3469         a divider to a separate function.
3470         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Added a title.
3471         (BuildbotQueueView.prototype._presentNoChangePopover): Updated the text to match
3472         title from above function.
3473         (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Renamed "contentElement"
3474         variable to "content" to match all other code.
3475         (BuildbotQueueView.prototype._addIterationHeadingToPopover): Added.
3476         (BuildbotQueueView.prototype._addDividerToPopover): Added.
3477
3478         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3479         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions): Add a title.
3480         (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions): Ditto.
3481         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): Ditto.
3482
3483         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
3484
3485 2014-01-07  Alexey Proskuryakov  <ap@apple.com>
3486
3487         There should be a delay when quickly switching to a different popover at build.webkit.org/dashboard
3488         https://bugs.webkit.org/show_bug.cgi?id=126472
3489
3490         Reviewed by Timothy Hatcher.
3491
3492         Added a delay when quickly switching to a different popover, making it easier to
3493         move mouse pointer from active element to its popover without accidentally opening
3494         a different popover.
3495
3496         Used this code to add a delay before creating a popover. This doesn't change UI
3497         behavior, as there was alerady a delay before it became visible, but it avoids
3498         flooding buildbot server with http requests when quickly moving the mouse over
3499         dashboard page.
3500
3501         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js:
3502         Fixed a case where popover could get stuck. If content was updated while fade-out
3503         transition was already in place, the transition was removed for no good reason.
3504
3505         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
3506         (PopoverTracker._onblur): While at it, also taught popovers to disappear on window blur.
3507
3508         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:
3509         (.popover.step-in): Now that PopoverTracker has a 200ms delay of its own, reduced
3510         popover delay from 1s to 800ms.
3511
3512 2014-01-07  Alexey Proskuryakov  <ap@apple.com>
3513
3514         Improve display of failed builds at build.webkit.org/dashboard
3515         https://bugs.webkit.org/show_bug.cgi?id=126542
3516         <rdar://problem/15753550>
3517
3518         Reviewed by Timothy Hatcher.
3519
3520         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
3521         Instead of hardcoding step name, look for the first step that failed.
3522         While at it, added a popover with more links. There are multiple, and it's good
3523         to have a choice of which one to look at in each situation.
3524
3525         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3526         (BuildbotIteration.prototype.get successful): Being successful is not the opposite
3527         of having failed. Many iterations are interrupted for whatever reason internal to
3528         Buildbot, and these are suppoed to be orange, not red.
3529         (BuildbotIteration.prototype.get productive): Changed to exclude inerrupted iterations,
3530         not only WillRetry ones.
3531         (BuildbotIteration.prototype.get failed): Changed to only include iterations that
3532         actually failed, more likely indicating a problem with code base.
3533         (BuildbotIteration.prototype.get firstFailedStepName):
3534         (BuildbotIteration.prototype.failureLogURL): Expose informaiton about failure.
3535         (BuildbotIteration.prototype.get failureLogs): Ditto.
3536         (BuildbotIteration.prototype.update): Store complete results for the failed step.
3537         Not every failure stops the iteration, so we could have multiple failed steps,
3538         but let's see if seeing just the first one will be enough.
3539
3540         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3541         (BuildbotQueue.prototype.get firstRecentUnsuccessfulIteration): Updated to work in
3542         terms of successful iterations.
3543         (BuildbotQueue.prototype.get mostRecentSuccessfulIteration): Ditto.
3544
3545         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3546         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Updated to work in
3547         terms of successful iterations.
3548
3549         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3550         Removed code to create a path to build output, we now take it from results JSON.
3551
3552         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
3553         Added styles for the new popover.
3554
3555 2014-01-07  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
3556
3557         defined constants should use all uppercase names with words separated by underscores.
3558         https://bugs.webkit.org/show_bug.cgi?id=126055
3559
3560         Reviewed by Alexey Proskuryakov.
3561
3562         * Scripts/webkitpy/style/checkers/cpp.py:
3563         (check_style):
3564         (CppChecker):
3565         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3566         (WebKitStyleTest.test_define_constants):
3567
3568 2014-01-07  Brian Holt  <brian.holt@samsung.com>
3569
3570         Unreviewed. Add myself as a committer.
3571
3572         * Scripts/webkitpy/common/config/contributors.json:
3573
3574 2014-01-07  Csaba Osztrogonác  <ossy@webkit.org>
3575
3576         Remove the WinCE buildbot from build.webkit.org
3577         https://bugs.webkit.org/show_bug.cgi?id=126517
3578
3579         Reviewed by Alexey Proskuryakov.
3580
3581         * BuildSlaveSupport/build.webkit.org-config/config.json:
3582         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3583         (appendCustomBuildFlags):
3584
3585 2014-01-07  Krzysztof Czech  <k.czech@samsung.com>
3586
3587         [EFL] Change ATK version to 2.11.4
3588         https://bugs.webkit.org/show_bug.cgi?id=126573
3589
3590         Reviewed by Gyuyoung Kim.
3591
3592         ATK 2.11.4 introduces some new roles, that are already being used by WebKit.
3593
3594         * efl/jhbuild.modules:
3595
3596 2014-01-07  Alberto Garcia  <berto@igalia.com>
3597
3598         [GTK][EFL] Use function jhbuildWrapperPrefixIfNeeded to run launcher
3599         https://bugs.webkit.org/show_bug.cgi?id=117275
3600
3601         Reviewed by Carlos Garcia Campos.
3602
3603         If we are not using the internal jhbuild we must not use the
3604         jhbuild-wrapper script, else it will try to download and install
3605         it.
3606
3607         * Scripts/run-launcher:
3608
3609 2014-01-07  Krzysztof Czech  <k.czech@samsung.com>
3610
3611         [ATK] Expose aria-checked mixed state as ATK_STATE_INDETERMINATE
3612         https://bugs.webkit.org/show_bug.cgi?id=125855
3613
3614         Reviewed by Mario Sanchez Prada.
3615
3616         Added new function isIndeterminate for testing aria-checked mixed state.
3617         I provided respective, but empty function in mac port. Mac testing it differently.
3618
3619         * DumpRenderTree/AccessibilityUIElement.cpp:
3620         (getIsIndeterminate):
3621         (AccessibilityUIElement::getJSClass):
3622         * DumpRenderTree/AccessibilityUIElement.h:
3623         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3624         (AccessibilityUIElement::isIndeterminate):
3625         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: Added empty function.
3626         (AccessibilityUIElement::isIndeterminate):
3627         * DumpRenderTree/mac/AccessibilityUIElementMac.mm: Added empty function.
3628         (AccessibilityUIElement::isIndeterminate):
3629         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Added empty function.
3630         (AccessibilityUIElement::isIndeterminate):
3631         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3632         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3633         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3634         (WTR::AccessibilityUIElement::isIndeterminate):
3635         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3636         (WTR::AccessibilityUIElement::isIndeterminate):
3637
3638 2014-01-06  Mark Rowe  <mrowe@apple.com>
3639
3640         <https://webkit.org/b/126560> Fix incorrectness in use of some AppKit enums
3641
3642         Reviewed by Ryosuke Niwa.
3643
3644         * DumpRenderTree/mac/DumpRenderTree.mm:
3645         (-[DRTMockScroller rectForPart:]): Move to using an if with early return instead of a switch
3646         with a single case. This avoids the potential for warnings about unhandled cases.
3647         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3648         (WTR::PlatformWebView::PlatformWebView): Cast the argument to NSBackingStoreType.
3649
3650 2014-01-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3651
3652         [GTK] Move all GTK/GObject unit tests to Tools/TestWebKitAPI
3653         https://bugs.webkit.org/show_bug.cgi?id=126342
3654
3655         Reviewed by Gustavo Noronha Silva.
3656
3657         * CMakeLists.txt: Include the new unit tests subdirectories.
3658         * Scripts/run-gtk-tests: Update to refer to the new build locations.
3659         * Scripts/webkitpy/style/checker.py: Update the style checker.
3660         * Scripts/webkitpy/style/checker_unittest.py:
3661         * TestWebKitAPI/GNUmakefile.am:
3662         * TestWebKitAPI/Tests/WebKit2Gtk/AccessibilityTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/AccessibilityTestServer.cpp.
3663         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Added.
3664         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp: Added.
3665         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/DOMNodeTest.cpp.
3666         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/FrameTest.cpp.
3667         * TestWebKitAPI/Tests/WebKit2Gtk/InspectorTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/InspectorTestServer.cpp.
3668         * TestWebKitAPI/Tests/WebKit2Gtk/LoadTrackingTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/LoadTrackingTest.cpp.
3669         * TestWebKitAPI/Tests/WebKit2Gtk/LoadTrackingTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/LoadTrackingTest.h.
3670         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestAuthentication.cpp.
3671         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestBackForwardList.cpp.
3672         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestContextMenu.cpp.
3673         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestCookieManager.cpp.
3674         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMDOMWindow.cpp: Added.
3675         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestDOMNode.cpp.
3676         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestDownloads.cpp.
3677         * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestFrame.cpp.
3678         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestInspector.cpp.
3679         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestInspectorServer.cpp.
3680         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestLoaderClient.cpp.
3681         * TestWebKitAPI/Tests/WebKit2Gtk/TestMain.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestMain.cpp.
3682         * TestWebKitAPI/Tests/WebKit2Gtk/TestMain.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestMain.h.
3683         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestPrinting.cpp.
3684         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestResources.cpp.
3685         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestSSL.cpp.
3686         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestUIClient.cpp.
3687         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebExtensions.cpp.
3688         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitAccessibility.cpp.
3689         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp.
3690         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFindController.cpp.
3691         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitPolicyClient.cpp.
3692         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitSettings.cpp.
3693         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitVersion.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitVersion.cpp.
3694         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebContext.cpp.
3695         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp.
3696         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebViewGroup.cpp.
3697         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebViewEditor.cpp.
3698         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebExtensionTest.cpp.
3699         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestBus.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestBus.cpp.
3700         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestBus.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestBus.h.
3701         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestServer.cpp.
3702         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestServer.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestServer.h.
3703         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.cpp.
3704         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.h.
3705         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTestRunner.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTestRunner.cpp.
3706         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTestRunner.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTestRunner.h.
3707         * TestWebKitAPI/Tests/WebKit2Gtk/WebViewTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.cpp.
3708         * TestWebKitAPI/Tests/WebKit2Gtk/WebViewTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.h.
3709         * TestWebKitAPI/Tests/WebKit2Gtk/resources/link-title.js: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/link-title.js.
3710         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test-cert.pem: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/test-cert.pem.
3711         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test-key.pem: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/test-key.pem.
3712         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/webkit2gtk-tests.gresource.xml.
3713         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Added.
3714         * TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Renamed from Source/WebKit/gtk/tests/resources/blank.ico.
3715         * TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Renamed from Source/WebKit/gtk/tests/resources/test.html.
3716         * TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Renamed from Source/WebKit/gtk/tests/resources/test.ogg.
3717         * TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Renamed from Source/WebKit/gtk/tests/resources/test.pdf.
3718         * TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Renamed from Source/WebKit/gtk/tests/resources/test.txt.
3719         * TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Renamed from Source/WebKit/gtk/tests/test_utils.c.
3720         * TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Renamed from Source/WebKit/gtk/tests/test_utils.h.
3721         * TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Renamed from Source/WebKit/gtk/tests/testapplicationcache.c.
3722         * TestWebKitAPI/Tests/WebKitGtk/testatk.c: Renamed from Source/WebKit/gtk/tests/testatk.c.
3723         * TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Renamed from Source/WebKit/gtk/tests/testatkroles.c.
3724         * TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Renamed from Source/WebKit/gtk/tests/testcontextmenu.c.
3725         * TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Renamed from Source/WebKit/gtk/tests/testcopyandpaste.c.
3726         * TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Renamed from Source/WebKit/gtk/tests/testdomdocument.c.
3727         * TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Renamed from Source/WebKit/gtk/tests/testdomdomwindow.c.
3728         * TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Renamed from Source/WebKit/gtk/tests/testdomnode.c.
3729         * TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Renamed from Source/WebKit/gtk/tests/testdownload.c.
3730         * TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Renamed from Source/WebKit/gtk/tests/testfavicondatabase.c.
3731         * TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Renamed from Source/WebKit/gtk/tests/testglobals.c.
3732         * TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Renamed from Source/WebKit/gtk/tests/testhittestresult.c.
3733         * TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Renamed from Source/WebKit/gtk/tests/testhttpbackend.c.
3734         * TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Renamed from Source/WebKit/gtk/tests/testkeyevents.c.
3735         * TestWebKitAPI/Tests/WebKitGtk/testloading.c: Renamed from Source/WebKit/gtk/tests/testloading.c.
3736         * TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Renamed from Source/WebKit/gtk/tests/testmimehandling.c.
3737         * TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Renamed from Source/WebKit/gtk/tests/testnetworkrequest.c.
3738         * TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Renamed from Source/WebKit/gtk/tests/testnetworkresponse.c.
3739         * TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Renamed from Source/WebKit/gtk/tests/testwebbackforwardlist.c.
3740         * TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Renamed from Source/WebKit/gtk/tests/testwebdatasource.c.
3741         * TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Renamed from Source/WebKit/gtk/tests/testwebframe.c.
3742         * TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Renamed from Source/WebKit/gtk/tests/testwebhistoryitem.c.
3743         * TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Renamed from Source/WebKit/gtk/tests/testwebinspector.c.
3744         * TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Renamed from Source/WebKit/gtk/tests/testwebplugindatabase.c.
3745         * TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Renamed from Source/WebKit/gtk/tests/testwebresource.c.
3746         * TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Renamed from Source/WebKit/gtk/tests/testwebsettings.c.
3747         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Renamed from Source/WebKit/gtk/tests/testwebview.c.
3748         * TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Renamed from Source/WebKit/gtk/tests/testwindow.c.
3749
3750 2014-01-06  Alexey Proskuryakov  <ap@apple.com>
3751
3752         Gtk and Efl API test results confuse the dashboard
3753         https://bugs.webkit.org/show_bug.cgi?id=126535
3754
3755         Reviewed by Tim Horton.
3756
3757         Added "API tests" step as "platform api tests".
3758
3759         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3760         (Buildbot.prototype.platformAPITestResultsURLForIteration):
3761         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3762         (BuildbotIteration):
3763         (BuildbotIteration.prototype.update):
3764         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3765         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
3766         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
3767
3768 2014-01-06  Tim Horton  <timothy_horton@apple.com>
3769
3770         build.webkit.org/dashboard should still function if localStorage is disabled
3771         https://bugs.webkit.org/show_bug.cgi?id=126511
3772
3773         Reviewed by Alexey Proskuryakov.
3774
3775         If localStorage is disabled, we should carry on with a warning.
3776
3777         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3778         Don't show the gear if localStorage isn't working.
3779
3780         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
3781         (QueueView.prototype._updateHiddenState):
3782         Bail if localStorage isn't working.
3783
3784         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
3785         (Settings.prototype.available):
3786
3787 2014-01-02  Roger Fong  <roger_fong@apple.com>
3788
3789         Set VSINSTALLDIR in win ews start script.
3790         https://bugs.webkit.org/show_bug.cgi?id=126407
3791
3792         Reviewed by Brent Fulgham.
3793
3794         * EWSTools/start-queue-win.sh:
3795
3796 2014-01-06  Bem Jones-Bey  <bjonesbe@adobe.com>
3797
3798         Adding myself as a reviewer.
3799
3800         Unreviewed.
3801
3802         * Scripts/webkitpy/common/config/contributors.json:
3803
3804 2014-01-06  Zan Dobersek  <zdobersek@igalia.com>
3805
3806         Unreviewed. Unbreaking JSC tests after r161328.
3807
3808         * Scripts/webkitdirs.pm:
3809         (cmakeBasedPortName): Only recognize the GTK port as CMake-based if actually building
3810         through the CMake build system (i.e. passing --gtkcmake to build-webkit).
3811
3812 2014-01-05  Martin Robinson  <mrobinson@igalia.com>
3813
3814         [GTK][CMake] Add support for building the GTK+ port with cmake to build-webkit
3815         https://bugs.webkit.org/show_bug.cgi?id=126212
3816
3817         Reviewed by Daniel Bates.
3818
3819         Allow building the GTK+ cmake port with --gtkcmake.
3820
3821         * Scripts/build-webkit: Use the new isGtkCMake function to head down the CMake path
3822         when appropriate. Skip the autotoos path when isGtkAutotools is false.
3823         * Scripts/webkitdirs.pm: Add an isGtkCMake path in addition to the newly renamed isGtkAutotools.
3824         Add isGtk which checks isGtkCMake || isGtkAutotools
3825         (determineArchitecture): Use the CMake path for GTK+ when appropriate.
3826         (argumentsForConfiguration): use --gtkcmake when appropriate.
3827         (jscProductDir): Look in the CMake directory when appropriate.
3828         (builtDylibPathForName): CMake builds the library into a different directory, so handle that.
3829         (determineIsGtkCMake): Added.
3830         (isGtkCMake): Added.
3831         (isGtkAutotools): Renamed from isGtk.
3832         (isGtk): New function which returns isGtkAutotools || isGtkCMake.
3833         (determineIsGtkAutotools): Renamed from determineIsGtk.
3834         (cmakeBasedPortName): Added a GTK+ path.
3835
3836 2014-01-04  Martin Robinson  <mrobinson@igalia.com>
3837
3838         [GTK] [CMake] Fix the video and audio build
3839         https://bugs.webkit.org/show_bug.cgi?id=126464
3840
3841         Reviewed by Philippe Normand.
3842
3843         * GtkLauncher/CMakeLists.txt: Add GStreamer includes and libraries, since GtkLauncher uses it.
3844
3845 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
3846
3847         It's confusing to have two elements link to the same URL at build.webkit.org/dashboard
3848         https://bugs.webkit.org/show_bug.cgi?id=126467
3849
3850         Reviewed by Geoffrey Garen.
3851
3852         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
3853         (StatusLineView): Don't linkify the label text, the bubble is easier to target with mouse
3854         pointer, or to tap.
3855
3856 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
3857
3858         build.webkit.org/dashboard says "failed build" even if it's another step that failed
3859         https://bugs.webkit.org/show_bug.cgi?id=126461
3860
3861         Reviewed by Geoffrey Garen.
3862
3863         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
3864         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Link to main
3865         build page if it's not the compilation that failed. Use text from buildbot for description.
3866         Show a yellow icon if it's a different kind of failure.
3867
3868         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3869         (BuildbotIteration.prototype.update): Record whether it was compile-webkit step that failed.
3870
3871 2014-01-03  Bem Jones-Bey  <bjonesbe@adobe.com>
3872
3873         setup-git-clone fails to get email address from git
3874         https://bugs.webkit.org/show_bug.cgi?id=126446
3875
3876         Reviewed by Ryosuke Niwa.
3877
3878         The setup-git-clone command fails to get an email address from git
3879         because of a bug in VCSUtils. This patch fixes that bug, and also
3880         makes it so that when VCSUtils fails for real because of a local
3881         misconfiguration, the error message is actually presented to the user
3882         of setup-git-clone.
3883
3884         * Scripts/VCSUtils.pm:
3885         (gitConfig): Call isGit() instead of accessing $isGit directly to make
3886             sure that $isGit is properly initialized.
3887         * Scripts/webkitpy/tool/commands/setupgitclone.py:
3888         (SetupGitClone.execute): Pull out username and email acquistion to
3889             it's own method.
3890         (SetupGitClone._get_username_and_email): Catch the exception thrown
3891             when VCSUtils fails and print out the error message so that the
3892             user actually knows why the command failed.
3893
3894 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
3895
3896         It feels too hard to get rid of a popover at build.webkit.org/dashboard
3897         https://bugs.webkit.org/show_bug.cgi?id=126451
3898
3899         Reviewed by Simon Fraser.
3900
3901         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:
3902         (.popover.fade-out): Reduced the timeout - 200 ms is enough to not have flicker
3903         when moving the mouse from an element to its popover.
3904
3905 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
3906
3907         Please add a way to quick peek at failing tests at build.webkit.org/dashboard
3908         https://bugs.webkit.org/show_bug.cgi?id=122181
3909
3910         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3911         (BuildbotQueueView.prototype._presentNoChangePopover): Update one more place for
3912         popover.present signature change.
3913
3914 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
3915
3916         Please add a way to quick peek at failing tests at build.webkit.org/dashboard
3917         https://bugs.webkit.org/show_bug.cgi?id=122181
3918
3919         Reviewed by Timothy Hatcher and Timothy Horton.
3920
3921         Detailed results are saved by run-webkit-tests to full_results.json (which is actually
3922         JSONP). Dashboard will load them on demand.
3923
3924         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3925         (Buildbot.prototype.layoutTestResultsURLForIteration): Moved from WebKitBuildbot.js
3926         and made it use a function from WebKitBuildbot that builds results directory path.
3927         (Buildbot.prototype.layoutTestFullResultsURLForIteration): Added a function that builds
3928         a URL for full_results.json.
3929         (Buildbot.prototype.layoutTestCrashLogForIteration): Added a function that builds
3930         a URL for a crash log.
3931
3932         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3933         (BuildbotIteration.prototype.loadLayoutTestResults): Load and cache layout test results for
3934         the iteration.
3935
3936         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:        
3937         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Updated for changed
3938         popover API (see below).
3939         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Ditto.
3940
3941         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3942         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Added a check
3943         for iterations that were interrupted (previously, they were displayed incorrectly,
3944         often as passes). Install popover trackers for failure bubbles for which we can currently
3945         display something useful.
3946         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions): Build
3947         a popover for layout test regressions when we have the data loaded on demand.
3948         We have test paths, special indicators for crashes/timeouts, and links to test history
3949         at flakiness dashboard.
3950         (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions): Show
3951         the popover for layout test regressions. Just shows "Loading..." until the data is
3952         loaded.
3953         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): List
3954         types of failures if there are multiple. There is a lot of similarity with
3955         appendBuilderQueueStatus(), but I couldn't find a good way to share the code.
3956
3957         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
3958         Create a global test history object, which is used for links in layout test popover.
3959
3960         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js:
3961         Changed the API to be more like WebInspector again, allowing for changing content
3962         of an existing popover. As the size of a popover can change, making the mouse pointer
3963         enter it without a mousenter event, install a handler for mousewheel instead, and block
3964         document scrolling from this event handler when needed.
3965
3966         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
3967         (StatusLineView.prototype.get statusBubbleElement): Added an accessor for status
3968         bubble element, making it possible to install a popover on it.
3969
3970         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
3971         (JSON.load): Added the ability to load JSONP by providing an optional callback name.
3972
3973         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3974         (WebKitBuildbot.prototype.layoutTestResultsDirectoryURLForIteration): Switched from
3975         building a complete results URL to only building one for root results path. This is
3976         the part that depends on specific buildbot installation, everything relative to it
3977         is the same.
3978
3979         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js: Added.
3980         Build a path to test history page. In the future, we may consider adding code to
3981         load the data and display it inline.
3982
3983         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
3984         Added styles for this new popover.
3985
3986         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added
3987         a new file, WebKitTestHistory.js.
3988
3989 2014-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3990
3991         REGRESSION(r161214): [GTK] WebKit2 C API tests fail to run after r161214
3992         https://bugs.webkit.org/show_bug.cgi?id=126430
3993
3994         Reviewed by Martin Robinson.
3995
3996         * Scripts/run-gtk-tests:
3997         (TestRunner._setup_testing_environment):
3998         * gtk/common.py: Use common.tests_library_build_path() instead.
3999         (tests_library_build_path): Helper funtion that returns the path
4000         where the tests libraries are built.
4001
4002 2014-01-03  Martin Robinson  <mrobinson@igalia.com>
4003
4004         [CMake] Build TestWebKitAPI tests into a directory structure
4005         https://bugs.webkit.org/show_bug.cgi?id=126358
4006
4007         Reviewed by Gyuyoung Kim.
4008
4009         WebKitGTK+ builds the TestWebKitAPI tests into a "TestWebKitAPI" directory. This
4010         is useful for keeping the "bin" directory tidy during building and will make it easier
4011         to integrate the CMake build into the existing WebKitGTK+ scripts.
4012
4013         * TestWebKitAPI/CMakeLists.txt: Set the output directory of all TestWebKitAPI binaries
4014         and make the names simpler now that the directory identifies what category the test is in.
4015
4016 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
4017
4018         Provide a visual clue when element has a popover at build.webkit.org/dashboard
4019         https://bugs.webkit.org/show_bug.cgi?id=126281
4020
4021         Reviewed by Timothy Hatcher.
4022
4023         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
4024         (PopoverTracker): Add a class name to elements with popovers.
4025
4026         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
4027         (*): We have -webkit-user-select:none, so let's also not show text selection cursor.
4028         I might have broke that recently.
4029         (*:link): Show hand cursor over links.
4030         (.popover-tracking:hover): Put a shadow on hover over element with popovers.
4031
4032         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
4033         (.status-line .message .revision-number): Show text selection cursor on our only
4034         selectable text element.
4035         (.status-line .bubble.popover-tracking:hover): Text in a bubble looks better with
4036         a white shadow than with a dark one on hover.
4037
4038 2014-01-02  Carlos Garcia Campos  <cgarcia@igalia.com>
4039
4040         [GTK] Add API to WebKitResponsePolicyDecision to check if the MIME type can be shown
4041         https://bugs.webkit.org/show_bug.cgi?id=124652
4042
4043         Reviewed by Martin Robinson.
4044
4045         * MiniBrowser/gtk/BrowserWindow.c:
4046         (webViewDecidePolicy): Use the new API instead of
4047         webkit_web_view_can_show_mime_type().
4048
4049 2014-01-02  Carlos Garcia Campos  <cgarcia@igalia.com>
4050
4051         REGRESSION(r160304): [GTK] Disable libtool fast install
4052         https://bugs.webkit.org/show_bug.cgi?id=126381
4053
4054         Reviewed by Martin Robinson.
4055
4056         Remove -no-fast-install ld flag since fast install is now disabled
4057         globally.
4058
4059         * GNUmakefile.am:
4060         * GtkLauncher/GNUmakefile.am:
4061         * MiniBrowser/gtk/GNUmakefile.am:
4062         * TestWebKitAPI/GNUmakefile.am:
4063         * WebKitTestRunner/GNUmakefile.am:
4064
4065 2014-01-02  Ryuan Choi  <ryuan.choi@samsung.com>
4066
4067         Unreviewed. Add myself to EFL and related watch lists.
4068
4069         * Scripts/webkitpy/common/config/watchlist:
4070
4071 2014-01-02  Danilo Cesar Lemes de Paula  <danilo.cesar@collabora.co.uk>
4072
4073         [GTK] fixing ycm_extra_conf.py file
4074         https://bugs.webkit.org/show_bug.cgi?id=126371
4075
4076         It's an attempt to fix three problems with the current ycm_extra_conf file.
4077         The current implementation assumes that it's a symlink, which is not true.
4078         Usually python creates a pyc file, and this is what you get in __file__.
4079         the .pyc is not a symlink, and the current implementation doesn't work
4080         if that's the case.
4081
4082         It also assumes that the user is in the root folder.
4083         If the user is in WebkitBuild/Debug and open a file as ../../Source/* it won't work.
4084
4085         Last but not least, "elif flag in FLAGS_PRECEDING_PATHS" emits an
4086         exception since "flag" doesn't exists.
4087
4088         All those things were fixed.
4089
4090         Reviewed by Martin Robinson.
4091
4092         * gtk/ycm_extra_conf.py:
4093         (transform_relative_paths_to_absolute_paths):
4094
4095 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
4096
4097         Bindings tests results links are broken at build.webkit.org/dashboard
4098         https://bugs.webkit.org/show_bug.cgi?id=126402
4099
4100         Reviewed by Tim Horton.
4101
4102         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
4103         (Buildbot.prototype.bindingsTestResultsURLForIteration): Fixed a typo that was there
4104         since the beginning.
4105
4106 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
4107
4108         "+" is very confusing at http://build.webkit.org/dashboard
4109         https://bugs.webkit.org/show_bug.cgi?id=126400
4110
4111         Reviewed by Tim Horton.
4112
4113         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
4114         (BuildbotQueueView.prototype._appendPendingRevisionCount): Instead of listing open
4115         source and internal counts separately, simply add them. One can always open a popover
4116         for more detail.
4117
4118 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
4119
4120         Accessing Trac from build.webkit.org/dashboard should enable XMLHttpRequest.withCredentials
4121         https://bugs.webkit.org/show_bug.cgi?id=126391
4122
4123         Reviewed by Dan Bernstein.
4124
4125         Make it conditional, as trac.webkit.org doesn't work when withCredentials is enabled.
4126         One can request credentials use via Initialization.js.
4127
4128         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
4129         (Trac):
4130         (Trac.prototype.update):
4131         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
4132         (loadXML):
4133
4134 2014-01-02  Commit Queue  <commit-queue@webkit.org>
4135
4136         Unreviewed, rolling out r160846.
4137         http://trac.webkit.org/changeset/160846
4138         https://bugs.webkit.org/show_bug.cgi?id=126395
4139
4140         Breaks build scripts for Windows when Visual Studio is not
4141         installed in Program Files (Requested by rfong on #webkit).
4142
4143         * Scripts/webkitdirs.pm:
4144         (visualStudioInstallDir):
4145
4146 2014-01-02  Martin Robinson  <mrobinson@igalia.com>
4147
4148         [GTK] [CMake] run-gtk-tests should run with the cmake build
4149         https://bugs.webkit.org/show_bug.cgi?id=126341
4150
4151         Reviewed by Carlos Garcia Campos.
4152
4153         * Scripts/run-gtk-tests:
4154         (TestRunner.__init__): Use the new calling conventions for the common script.
4155         (TestRunner._setup_testing_environment): Ditto.
4156         * gtk/common.py:
4157         (set_build_types): Added set_build_types, to avoid having build_type arguments
4158         for all functions in common.
4159         (binary_build_path): Added this function which gets the path to the built binaries.
4160         (get_build_path): Removed the build_types argument.
4161         (build_path): Removed the build_types argument and call get_build_path directly now.
4162
4163 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
4164
4165         https://bugs.webkit.org/show_bug.cgi?id=126391
4166         Accessing Trac from build.webkit.org/dashboard should enable XMLHttpRequest.withCredentials
4167
4168         Rubber-stamped by Dan Bernstein.
4169
4170         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
4171         (loadXML): Quick and dirty fix, with a FIXME.
4172
4173 2014-01-01  Martin Robinson  <mrobinson@igalia.com>
4174
4175         [GTK] Rename libtestnetscapeplugin to libTestNetscapePlugin
4176         https://bugs.webkit.org/show_bug.cgi?id=126349
4177
4178         Reviewed by Carlos Garcia Campos.
4179
4180         All CMake ports use "libTestNetscapePlugin," so choosing the same
4181         name in the autotools port will make the transition easier.
4182
4183         * GNUmakefile.am: Rename the plugin library.
4184
4185 2014-01-01  ChangSeok Oh  <changseok.oh@collabora.com>
4186
4187         [GTK][WK2] Back items are shown in reverse order in MiniBrowser
4188         https://bugs.webkit.org/show_bug.cgi?id=126354
4189
4190         Reviewed by Carlos Garcia Campos.
4191
4192         The latest visited site for backward history should be placed on the top of a history stack
4193         as a common behavior. However currently its order is reverse.
4194
4195         * MiniBrowser/gtk/BrowserWindow.c:
4196         (browserWindowUpdateNavigationActions):
4197
4198 2013-12-30  Martin Robinson  <mrobinson@igalia.com>
4199
4200         [GTK] Make the output directory of GObject unit tests binaries consistent with the CMake build
4201         https://bugs.webkit.org/show_bug.cgi?id=126297
4202
4203         Reviewed by Philippe Normand.
4204
4205         * Scripts/run-gtk-tests: Looks for the tests in the new directories.
4206         (TestRunner): Ditto.
4207         (TestRunner._run_test): Ditto.
4208
4209 2013-12-30  Alexey Proskuryakov  <ap@apple.com>
4210
4211         full_results.json should distinguish unexpected failures from expected ones
4212         https://bugs.webkit.org/show_bug.cgi?id=126300