d848dc82764c0572d7c0be64e8312b20f1748ab0
[WebKit-https.git] / Tools / ChangeLog
1 2018-06-02  Commit Queue  <commit-queue@webkit.org>
2
3         Unreviewed, rolling out r232421.
4         https://bugs.webkit.org/show_bug.cgi?id=186240
5
6         Breaks webkitpy tests (Requested by aakashjain on #webkit).
7
8         Reverted changeset:
9
10         "Add some tests for lldb_webkit.py"
11         https://bugs.webkit.org/show_bug.cgi?id=183744
12         https://trac.webkit.org/changeset/232421
13
14 2018-06-01  Daniel Bates  <dabates@apple.com>
15
16         Add some tests for lldb_webkit.py
17         https://bugs.webkit.org/show_bug.cgi?id=183744
18
19         Reviewed by Alexey Proskuryakov.
20
21         Adds some tests to ensure we do not regress LLDB pretty-printing of WTF::StringImpl
22         and WTF::String objects.
23
24         The tests make use of the LLDB Python API (lldb.py) and a simple debug-built test
25         program, lldbWebKitTester, to run. For now, we only support building lldbWebKitTester
26         on Mac.
27
28         * Makefile: Build the simple test tool lldbWebKitTester on Mac.
29         * Scripts/build-lldbwebkittester: Added.
30         (buildProjectOrDie):
31         * Scripts/dump-class-layout: Extract logic to compute the path to the LLDB Python module
32         from here to Scripts/webkitpy/common/system/systemhost.py so that it can used by both
33         this script and lldb/lldb_webkit_unittest.py. Also import the lldb module at the top of
34         the file and take advantage of Python's default error semantics to throw an exception
35         if the import fails instead of handling it ourself. This has the side effect that we
36         now always import the LLDB Python module even if this script is invoked with --help.
37         If this turns out to be a significant annoyance then we can look to dynamically import
38         the module as we did before this change.
39         (webkit_build_dir):
40         (main):
41         (developer_dir): Deleted.
42         (import_lldb): Deleted.
43         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Update FIXME comment to reflect
44         that fact that test-webkitpy does not support class and module fixtures. This is because
45         test-webkitpy currently implements parallelism by breaking down existing test classes
46         into individual test methods itself and having each worker run exactly one test method (via
47         unittest.TestLoader.loadTestsFromName()) at a time. As a result of this reorganization,
48         setUpModule()/setUpClass() are called for each test method as opposed to once per test
49         class/test module.
50         (remove_dir): Ditto.
51         * Scripts/webkitpy/common/system/systemhost.py:
52         (SystemHost):
53         (SystemHost.path_to_lldb_python_directory): Added.
54         * Scripts/webkitpy/test/main.py:
55         (_find_lldb_webkit_tester): Returns whether there exists a Debug or Release-built lldbWebKitTester.
56         (_build_lldb_webkit_tester): Builds lldbWebKitTester. For now, we only support building
57         lldbWebKitTester on Mac.
58         (main): Add Tools/lldb to the test search path if the platform has lldb.py.
59         (Tester.run): Pass a boolean as to whether we will run the lldb_webkit unit tests.
60         (Tester._run_tests): Modified to take a boolean as to whether to run the lldb_webkit unit tests.
61         If we will run these tests then build lldbWebKitTester if it has not already been built as the
62         unit tests depend on this program.
63         * lldb/lldbWebKitTester/Configurations/Base.xcconfig: Added.
64         * lldb/lldbWebKitTester/Configurations/DebugRelease.xcconfig: Added.
65         * lldb/lldbWebKitTester/Configurations/lldbWebKitTester.xcconfig: Added.
66         * lldb/lldbWebKitTester/Makefile: Added.
67         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj: Added.
68         * lldb/lldbWebKitTester/main.cpp: Added.
69         (breakForTestingSummaryProviders):
70         (utf16String):
71         (testSummaryProviders):
72         (main):
73         * lldb/lldb_webkit_unittest.py: Added.
74         (destroy_cached_debug_session):
75         (LLDBDebugSession):
76         (LLDBDebugSession.setup):
77         (LLDBDebugSession.tearDown):
78         (TestSummaryProviders):
79         (TestSummaryProviders.setUpClass):
80         (TestSummaryProviders._sbFrame):
81         (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_null_string):
82         (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_empty_string):
83         (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_8bit_string):
84         (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_16bit_string):
85         (TestSummaryProviders.serial_test_WTFString_SummaryProvider_null_string):
86         (TestSummaryProviders.serial_test_WTFString_SummaryProvider_empty_string):
87         (TestSummaryProviders.serial_test_WTFString_SummaryProvider_8bit_string):
88         (TestSummaryProviders.serial_test_WTFString_SummaryProvider_16bit_string):
89
90 2018-06-01  Frederic Wang  <fwang@igalia.com>
91
92         export-w3c-test-changes cannot apply patches when some w3c-import.log files are changed
93         https://bugs.webkit.org/show_bug.cgi?id=186133
94
95         Reviewed by Youenn Fablet.
96
97         * Scripts/webkitpy/w3c/test_exporter.py: Exclude w3c-import.log from the diff.
98         * Scripts/webkitpy/w3c/test_exporter_unittest.py: Add unit test.
99
100 2018-05-31  Frederic Wang  <fwang@igalia.com>
101
102         export-w3c-test-changes should use the new location & name of the WPT repo
103         https://bugs.webkit.org/show_bug.cgi?id=186135
104
105         Reviewed by Youenn Fablet.
106
107         Web platform tests have been moved to GitHub's web-platform-tests/wpt. This patch updates the
108         corresponding variables to use the new organization and repository name. It also refactors a
109         bit the code to reduce the amount of hardcoded strings.
110
111         * Scripts/webkitpy/w3c/common.py: Use org web-platform-tests, repo name wpt. Also removes the
112         final slash to WPT_GH_URL, so it can be used for repo URL too.
113         * Scripts/webkitpy/w3c/test_exporter.py: Import more symbols and define WPT_PR_URL from
114         WPT_GH_URL.
115         (WebPlatformTestExporter._wpt_fork_branch_github_url): Use WPT_GH_REPO_NAME.
116         (WebPlatformTestExporter._wpt_fork_push_url): Use WPT_GH_REPO_NAME.
117         (WebPlatformTestExporter._git): Use  WPT_GH_URL.
118         (WebPlatformTestExporter._ensure_username_and_token): Use WPT_GH_ORG, WPT_GH_REPO_NAME.
119         (WebPlatformTestExporter.make_pull_request): Use WPT_GH_ORG, WPT_GH_REPO_NAME.
120         (parse_args): Use WPT_GH_REPO_NAME, WPT_GH_URL.
121         * Scripts/webkitpy/w3c/test_exporter_unittest.py:
122         (TestExporterTest.test_export): Update organization and repository names for the remote
123         branch and pull request.
124         (TestExporterTest.test_export_with_specific_branch): Update repository name.
125
126 2018-05-31  Ryan Haddad  <ryanhaddad@apple.com>
127
128         Update expected results for BuildStepsConstructorTest
129         https://bugs.webkit.org/show_bug.cgi?id=186119
130
131         Reviewed by Alex Christensen.
132
133         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Add missing entries for 'WinCairo 64-bit' bots.
134
135 2018-05-31  Sihui Liu  <sihui_liu@apple.com>
136
137         [iOS] TestWebKitAPI.WebKit.WKHTTPCookieStoreWithoutProcessPool fails because cookies use different files with/without processpool
138         https://bugs.webkit.org/show_bug.cgi?id=185831
139         <rdar://problem/40468716>
140
141         Reviewed by David Kilzer.
142
143         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
144         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
145         (TEST):
146
147 2018-05-31  Chris Dumez  <cdumez@apple.com>
148
149         [iOS] API test ScrollViewInsetTests.InnerHeightWithLargeTopContentInset is a flaky failure
150         https://bugs.webkit.org/show_bug.cgi?id=184893
151         <rdar://problem/39747271>
152
153         Reviewed by Wenson Hsieh.
154
155         Update test to wait until the view is the expected height instead of
156         calling waitForNextPresentationUpdate once and expect the view to
157         have the right height. This fixes the flakiness.
158
159         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
160         (TestWebKitAPI::waitUntilInnerHeightIs):
161         (TestWebKitAPI::TEST):
162
163 2018-05-31  Leo Balter  <leonardo.balter@gmail.com>
164
165         test262-runner should run in verbose mode in automation
166         https://bugs.webkit.org/show_bug.cgi?id=186115
167
168         Reviewed by Yusuke Suzuki.
169
170         This patch toggles the verbose mode in the build bot and reports every test file
171         in order to avoid the '1200 seconds without output' issue.
172         * BuildSlaveSupport/build.webkit.org-config/steps.py:
173         (RunTest262Tests):
174         * Scripts/test262/Runner.pm:
175         (processResult):
176
177 2018-05-30  Fujii Hironori  <Hironori.Fujii@sony.com>
178
179         [Win][MiniBrowser] Move MainWindow related code from Common.cpp to MainWindow.cpp
180         https://bugs.webkit.org/show_bug.cgi?id=186079
181
182         Reviewed by Alex Christensen.
183
184         This is a sub task of Bug 184770.
185
186         This change is partial. I'm going to remove global variables
187         gMainWindow and gMiniBrowser and convert more functions to
188         MainWindow's methods in follow-up patches.
189
190         * MiniBrowser/win/CMakeLists.txt: Added Common.cpp
191         * MiniBrowser/win/Common.cpp:
192         (menuItemIsChecked): Moved to MainWindow.cpp.
193         (turnOffOtherUserAgents): Ditto.
194         (EditProc): Ditto.
195         (BackButtonProc): Ditto.
196         (ForwardButtonProc): Ditto.
197         (About): Ditto.
198         (Caches): Ditto.
199         (CustomUserAgent): Ditto.
200         (AuthDialogProc): Ditto.
201         (DisplayAuthDialog): Converted to MainWindow's method.
202         (ToggleMenuItem): Ditto.
203         (loadURL): Ditto.
204         * MiniBrowser/win/Common.h:
205         * MiniBrowser/win/MainWindow.cpp:
206         (MainWindow::init): Call SetFocus at the end of the construction.
207         (MainWindow::WndProc):
208         (menuItemIsChecked): Moved from Common.cpp.
209         (turnOffOtherUserAgents): Ditto.
210         (EditProc): Ditto.
211         (BackButtonProc): Ditto.
212         (ForwardButtonProc): Ditto.
213         (About): Ditto.
214         (Caches): Ditto.
215         (CustomUserAgent): Ditto.
216         (authDialogProc): Ditto.
217         (MainWindow::displayAuthDialog): Converted from a function of Common.cpp.
218         (MainWindow::toggleMenuItem): Ditto.
219         (MainWindow::loadURL): Ditto.
220         * MiniBrowser/win/MainWindow.h: Added method declarations.
221         * MiniBrowser/win/MiniBrowser.h: Added pragma once.
222         * MiniBrowser/win/WinMain.cpp:
223         (wWinMain): Include Common.h instead of Common.cpp.
224
225 2018-05-30  Brady Eidson  <beidson@apple.com>
226
227         REGRESSION (r224684): User-agent seen by page does not change when modified by the develop menu options after reloading.
228         <rdar://problem/34918109> and https://bugs.webkit.org/show_bug.cgi?id=186111
229
230         Reviewed by Andy Estes.
231
232         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
233         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
234         (WTR::TestRunner::setCustomUserAgent):
235         * WebKitTestRunner/InjectedBundle/TestRunner.h:
236         * WebKitTestRunner/TestController.cpp:
237         (WTR::TestController::resetStateToConsistentValues):
238         * WebKitTestRunner/TestInvocation.cpp:
239         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
240
241 2018-05-30  Youenn Fablet  <youenn@apple.com>
242
243         Rename CrossOriginResourcePolicy same to same-origin
244         https://bugs.webkit.org/show_bug.cgi?id=186080
245
246         Reviewed by Chris Dumez.
247
248         * TestWebKitAPI/Tests/WebCore/HTTPParsers.cpp:
249         (TestWebKitAPI::TEST):
250
251 2018-05-30  Ms2ger  <Ms2ger@igalia.com>
252
253         [GTK] Unreviewed test gardening
254         https://bugs.webkit.org/show_bug.cgi?id=186098
255
256         Unreviewed gardening.
257
258         * TestWebKitAPI/glib/TestExpectations.json: update expectations.
259
260 2018-05-29  Youenn Fablet  <youenn@apple.com>
261
262         Add a consistency check between URL and CFURL
263         https://bugs.webkit.org/show_bug.cgi?id=182444
264         <rdar://problem/37164835>
265
266         Reviewed by Geoff Garen.
267
268         DRT code expected a non null URL which is no longer the case now.
269         Updated DRT to remove that assumption.
270
271         * DumpRenderTree/TestRunner.cpp:
272         (TestRunner::redirectionDestinationForURL):
273         * DumpRenderTree/TestRunner.h:
274         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
275         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
276
277 2018-05-29  Brendan McLoughlin  <brendan@bocoup.com>
278
279         Export changes to web-platform-test as part of the webkit-patch upload workflow
280         https://bugs.webkit.org/show_bug.cgi?id=184914
281
282         Reviewed by Youenn Fablet.
283
284         * Scripts/webkitpy/tool/commands/upload.py:
285         (Upload):
286         (CreateBug.execute):
287         (WPTChangeExport):
288         * Scripts/webkitpy/tool/steps/__init__.py:
289         * Scripts/webkitpy/tool/steps/wptchangeexport.py: Added.
290         (WPTChangeExport):
291         (WPTChangeExport.options):
292         (WPTChangeExport.run):
293         * Scripts/webkitpy/w3c/common.py:
294         * Scripts/webkitpy/w3c/test_exporter.py:
295         (WebPlatformTestExporter):
296         (WebPlatformTestExporter.__init__):
297         (WebPlatformTestExporter.username):
298         (WebPlatformTestExporter.token):
299         (WebPlatformTestExporter._github):
300         (WebPlatformTestExporter._wpt_fork_branch_github_url):
301         (WebPlatformTestExporter._wpt_fork_remote):
302         (WebPlatformTestExporter._wpt_fork_push_url):
303         (WebPlatformTestExporter._git):
304         (WebPlatformTestExporter._branch_name):
305         (WebPlatformTestExporter._public_branch_name):
306         (WebPlatformTestExporter._wpt_patch):
307         (WebPlatformTestExporter.has_wpt_changes):
308         (WebPlatformTestExporter._find_filename):
309         (WebPlatformTestExporter._is_ignored_file):
310         (WebPlatformTestExporter._strip_ignored_files_from_diff):
311         (WebPlatformTestExporter.write_git_patch_file):
312         (WebPlatformTestExporter._prompt_for_token):
313         (WebPlatformTestExporter._prompt_for_username):
314         (WebPlatformTestExporter._ensure_username_and_token):
315         (WebPlatformTestExporter._validate_and_save_token):
316         (WebPlatformTestExporter.create_branch_with_patch):
317         (WebPlatformTestExporter.push_to_wpt_fork):
318         (WebPlatformTestExporter.make_pull_request):
319         (WebPlatformTestExporter.delete_local_branch):
320         (WebPlatformTestExporter.create_upload_remote_if_needed):
321         (WebPlatformTestExporter.do_export):
322         (parse_args):
323         (TestExporter): Deleted.
324         (TestExporter.__init__): Deleted.
325         (TestExporter._ensure_wpt_repository): Deleted.
326         (TestExporter._fetch_wpt_repository): Deleted.
327         (TestExporter._ensure_new_branch_name): Deleted.
328         (TestExporter.download_and_commit_patch): Deleted.
329         (TestExporter.clean): Deleted.
330         (TestExporter.create_branch_with_patch): Deleted.
331         (TestExporter.push_to_wpt_fork): Deleted.
332         (TestExporter.make_pull_request): Deleted.
333         (TestExporter.create_wpt_pull_request): Deleted.
334         (TestExporter.delete_local_branch): Deleted.
335         (TestExporter.create_git_patch): Deleted.
336         (TestExporter.create_upload_remote): Deleted.
337         (TestExporter.do_export): Deleted.
338         * Scripts/webkitpy/w3c/test_exporter_unittest.py:
339         (TestExporterTest.MockGit):
340         (TestExporterTest.MockGit.create_patch):
341         (TestExporterTest.test_export):
342         (TestExporterTest.test_export_with_specific_branch):
343         (TestExporterTest):
344         (TestExporterTest.test_export_interactive_mode):
345         (TestExporterTest.test_export_invalid_token):
346         (TestExporterTest.test_export_wrong_token):
347         (TestExporterTest.test_has_wpt_changes):
348         (TestExporterTest.test_has_no_wpt_changes_for_no_diff):
349         (TestExporterTest.test_ignore_changes_to_expected_file):
350
351 2018-05-29  Fujii Hironori  <Hironori.Fujii@sony.com>
352
353         [Win][MiniBrowser] Move WK1 specific code from Common.cpp to MiniBrowser.cpp
354         https://bugs.webkit.org/show_bug.cgi?id=186029
355
356         Reviewed by Alex Christensen.
357
358         This is a sub task of Bug 184770.
359
360         * MiniBrowser/win/Common.cpp:
361         (ToggleMenuItem): Extracted WK1 specific code to MiniBrowser::setPreference.
362         (Caches): Call MiniBrowser::updateStatistics instead of updateStatistics.
363         (AbortProc): Moved to MiniBrowser.cpp.
364         (getPrinterDC): Ditto.
365         (initDocStruct): Ditto.
366         (PrintView): Ditto.
367         (ToggleMenuFlag): Ditto.
368         (setWindowText): Ditto.
369         (updateStatistics): Ditto.
370         * MiniBrowser/win/MainWindow.cpp:
371         (MainWindow::WndProc): Call MiniBrowser::print instead of PrintView.
372         * MiniBrowser/win/MiniBrowser.cpp:
373         (AbortProc): Moved from Common.cpp.
374         (getPrinterDC): Moved from Common.cpp.
375         (initDocStruct): Moved from Common.cpp.
376         (setWindowText): Moved from Common.cpp.
377         (MiniBrowser::print): Renamed from PrintView of Common.cpp.
378         (MiniBrowser::updateStatistics): Renamed from updateStatistics of Common.cpp.
379         (MiniBrowser::setPreference): Extracted from ToggleMenuItem of Common.cpp.
380         * MiniBrowser/win/MiniBrowser.h: Add method declarations.
381         * MiniBrowser/win/MiniBrowserWebHost.cpp: Removed duplicated IWebFramePtr typedef.
382
383 2018-05-29  Saam Barati  <sbarati@apple.com>
384
385         JSC should put bmalloc's scavenger into mini mode
386         https://bugs.webkit.org/show_bug.cgi?id=185988
387
388         Reviewed by Michael Saboff.
389
390         This patch makes it so that we turn off the JIT when running run-testmem
391         that way we make JSC use its mini mode.
392
393         * Scripts/run-testmem:
394
395 2018-05-29  Sihui Liu  <sihui_liu@apple.com>
396
397         Unable to remove IndexedDB Databases with Cocoa API removeDataOfTypes
398         https://bugs.webkit.org/show_bug.cgi?id=185835
399         <rdar://problem/39142257>
400
401         Reviewed by Chris Dumez.
402
403         Add API test coverage.
404
405         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
406         (TEST):
407
408 2018-05-29  Wenson Hsieh  <wenson_hsieh@apple.com>
409
410         [Extra zoom mode] "Significant area painted" rendering progress event is rarely fired
411         https://bugs.webkit.org/show_bug.cgi?id=186042
412         <rdar://problem/40604182>
413
414         Reviewed by Tim Horton.
415
416         Adds a new API test to check that the "significant area painting" rendering milestone is dispatched when a
417         significant portion of the page has been painted before document load is finished.
418
419         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
420         * TestWebKitAPI/Tests/WebKitCocoa/paint-significant-area-milestone.html: Added.
421         * TestWebKitAPI/Tests/ios/RenderingProgressTests.mm: Added.
422         (-[MissingResourceSchemeHandler webView:stopURLSchemeTask:]):
423         (-[MissingResourceSchemeHandler webView:startURLSchemeTask:]):
424         (-[RenderingProgressHandler initWithHandler:]):
425         (-[RenderingProgressHandler _webView:renderingProgressDidChange:]):
426         (TEST):
427
428 2018-05-29  Thibault Saunier  <tsaunier@igalia.com>
429
430         [GStreamer] Update "qtdemux: Clarify field name about stream-encryption-system" patch
431         https://bugs.webkit.org/show_bug.cgi?id=186040
432
433         The patch we merge contained a type and was merged in upstream GStreamer fixing that
434         (s/avalaible/available/).
435
436         Reviewed by Xabier Rodriguez-Calvar.
437
438         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch:
439
440 2018-05-28  Sihui Liu  <sihui_liu@apple.com>
441
442         Add an API test to check process privilege when using Cookie API
443         https://bugs.webkit.org/show_bug.cgi?id=185406
444
445         Reviewed by Geoffrey Garen.
446
447         Add API test coverage.
448
449         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
450         (TEST):
451
452 2018-05-28  Thibault Saunier  <tsaunier@igalia.com>
453
454         [GStreamer] Handle changes in the "drm-preferred-decryption-system-id" NEED_CONTEXT message.
455         https://bugs.webkit.org/show_bug.cgi?id=185948
456
457         Reviewed by Xabier Rodriguez-Calvar.
458
459         When the patch introducing gst_protection_filter_systems_by_available_decryptors was merged, we changed sensibly its behaviour
460         concerning the way empty results is represented (now returning NULL instead of an array of 1(NULL) element) and this change was not
461         properly taken into account in the qtdemux patch that uses it and got upstreamed. Those 3 new patches fixe that and change the
462         NEED_CONTEXT field names to clarify the meaning of "stream-encryption-systems".
463
464         * gstreamer/jhbuild.modules:
465         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Added. Merged upstream as 3e063703b3a51b8aaa7f75f36c4660c583a60e93
466         * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Added. Merged upstream as 43a540b1cd9f162d3dae5d50e36703dfaf558a3e
467         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Added.
468
469 2018-05-27  Dan Bernstein  <mitz@apple.com>
470
471         Reverted the changes made for https://webkit.org/b/186016
472
473         They broke the USE(APPLE_INTERNAL_SDK) Sierra build.
474
475 2018-05-27  Dan Bernstein  <mitz@apple.com>
476
477         [Cocoa] Avoid importing directly from subumbrella frameworks
478         https://bugs.webkit.org/show_bug.cgi?id=186016
479
480         Reviewed by Sam Weinig.
481
482         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
483           LaunchServices header.
484         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
485           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
486         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
487           when using SDKs earlier than 10.13.
488         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
489           and OTHER_CPLUSPLUSFLAGS.
490         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm: Import Carbon.h instead of an
491           HIToolbox header.
492         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
493           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
494         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
495           LaunchServices header.
496
497 2018-05-27  Fujii Hironori  <Hironori.Fujii@sony.com>
498
499         [Win][MiniBrowser] Add MainWindow class
500         https://bugs.webkit.org/show_bug.cgi?id=185814
501
502         Reviewed by Per Arne Vollan.
503
504         This is a sub task of Bug 184770. Added a new class MainWindow to
505         represent the main window which will be shared among WK1 and WK2.
506
507         This change is partial so that it's easy to review this patch.
508         I'll move more functions into MainWindow.cpp, and remove more
509         global variables in forthcoming patches.
510
511         * MiniBrowser/win/CMakeLists.txt: Added MainWindow.cpp.
512         * MiniBrowser/win/Common.cpp: Removed MainWindow related global
513         variables hMainWnd, hURLBarWnd, hBackButtonWnd and
514         hForwardButtonWnd. Added a new global variable gMainWindow.
515         (WndProc): Moved to MainWindow.cpp.
516         (resizeSubViews): Ditto.
517         (ToggleMenuFlag): Removed static to be called from MainWindow.cpp.
518         (ToggleMenuItem): Ditto.
519         (CustomUserAgent): Follow the global variables removal.
520         (DisplayAuthDialog): Ditto.
521         (loadURL): Ditto.
522         (WndProc): Renamed to MainWindow::WndProc.
523         * MiniBrowser/win/MainWindow.cpp: Added.
524         (MainWindow::registerClass): Renamed from MyRegisterClass of WinMain.cpp.
525         (MainWindow::init): Extracted MainWindow initialization code from wWinMain.
526         (MainWindow::resizeSubViews): Moved from Common.cpp.
527         (MainWindow::WndProc): Ditto.
528         * MiniBrowser/win/MainWindow.h: Added.
529         (MainWindow::hwnd):
530         (MainWindow::browserWindow):
531         * MiniBrowser/win/MiniBrowser.cpp:
532         (MiniBrowser::init):
533         (MiniBrowser::prepareViews): Extract some code into MiniBrowser::loadDefaultHTML.
534         (MiniBrowser::loadDefaultHTML): Extracted from MiniBrowser::prepareViews.
535         * MiniBrowser/win/MiniBrowser.h:
536         * MiniBrowser/win/WinMain.cpp:
537         (wWinMain): Extracted MainWindow initialization code into MainWindow::init.
538         (MyRegisterClass): Moved to MainWindow.cpp.
539
540 2018-05-27  Fujii Hironori  <Hironori.Fujii@sony.com>
541
542         [Win][MiniBrowser] Remove URL argument of MiniBrowser::init
543         https://bugs.webkit.org/show_bug.cgi?id=185969
544
545         Reviewed by Alex Christensen.
546
547         MiniBrowser::init takes URL argument, but it's used only for
548         loading default HTML if URL is not given.
549
550         - Add a new method MiniBrowser::loadHTMLString
551         - Remove loadHTMLString process from MiniBrowser::prepareViews
552
553         * MiniBrowser/win/MiniBrowser.cpp:
554         (MiniBrowser::init): Removed `requestedURL` argument.
555         (MiniBrowser::prepareViews): Ditto.
556         (MiniBrowser::loadHTMLString): New.
557         (MiniBrowser::loadURL): Return E_INVALIDARG if passedURL is null instead of calling loadHTMLString.
558         * MiniBrowser/win/MiniBrowser.h: Removed URL argument. Added loadHTMLString.
559         * MiniBrowser/win/WinMain.cpp:
560         (wWinMain): Call MiniBrowser::loadHTMLString if URL is not given.
561
562 2018-05-27  David Kilzer  <ddkilzer@apple.com>
563
564         svn-apply fails when a patch has an empty file
565         <https://webkit.org/b/29684>
566
567         Reviewed by Daniel Bates.
568
569         Prior to this change, applying the following patches resulted in:
570         - svn: add empty file     (failure)
571         - svn: delete empty file  (failure)
572         - svn: rename empty file  (failure)
573         - git: add empty file     (false-positive success)
574         - git: delete empty file  (success)
575         - git: rename empty file  (failure)
576
577         * Scripts/VCSUtils.pm:
578         (parseSvnDiffHeader): Handle the case when there is no patch
579         following the header.  If the file exists and is empty, that
580         means it's a deletion.  If the file does not exist, that means
581         it's an addition. Everything else is a fatal error.
582         * Scripts/svn-apply:
583         (patch):
584         - Only apply a patch for deletion if it has one or more text
585           chunks.
586         - Add a case to handle adding an empty file (an addition with no
587           text chunks), and verify the file doesn't exist yet.
588         - Any unhandled patch is a fatal error.
589         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
590         Add tests for adding an empty file and deleting an empty file.
591         * Scripts/webkitperl/VCSUtils_unittest/resources/empty.txt: Add.
592         Used by parseSvnDiffHeader.pl unit test for "add an empty file"
593         test case.
594
595 2018-05-25  Aakash Jain  <aakash_jain@apple.com>
596
597         Display detailed error logs when a script fails in EWS
598         https://bugs.webkit.org/show_bug.cgi?id=175696
599         <rdar://problem/34841885>
600
601         Reviewed by Darin Adler.
602
603         * Scripts/webkitpy/tool/bot/queueengine.py: Set output_limit to 5000 characters instead of default 500 characters.
604         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py: Ditto.
605         * Scripts/webkitpy/tool/commands/download.py: Ditto.
606         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: Ditto.
607         * Scripts/webkitpy/tool/commands/queues.py: Ditto.
608         * Scripts/webkitpy/tool/commands/stepsequence.py: Ditto.
609
610 2018-05-25  Daniel Bates  <dabates@apple.com>
611
612         test-webkitpy messages logged using __main__ logger are not displayed
613         https://bugs.webkit.org/show_bug.cgi?id=185823
614
615         Rubber-stamped by Aakash Jain.
616
617         Configure the logger for __main__ so that messages that are logged before it parses its
618         command line arguments are printed to standard error.
619
620         Currently test-webkitpy creates a named logger (__main__) for its logging. However it does
621         not configure a stream to use for printing until after it parses its command line arguments
622         via webkitpy.test.printer.Printer.configure(). Messages logged until then are never written
623         to the console. We explicitly configure the __main__ logger instead of calling webkitpy.test.printer.Printer.configure()
624         earlier because the latter both configures a stream and filters logged messages based on
625         the specified verbosity. Logged messaged from code in __main__ should not be subject to
626         such filtering. So, we explicitly configure the __main__ logger.
627
628         * Scripts/webkitpy/test/main.py:
629         (main):
630
631 2018-05-25  Saam Barati  <sbarati@apple.com>
632
633         Make JSC have a mini mode that kicks in when the JIT is disabled
634         https://bugs.webkit.org/show_bug.cgi?id=185931
635
636         Reviewed by Mark Lam.
637
638         This renames a variable for clarity.
639
640         * Scripts/run-testmem:
641
642 2018-05-25  Alex Christensen  <achristensen@webkit.org>
643
644         URL::host should return a StringView to reduce allocations
645         https://bugs.webkit.org/show_bug.cgi?id=185986
646
647         Reviewed by Geoff Garen.
648
649         * TestWebKitAPI/Tests/WebCore/URL.cpp:
650         (TestWebKitAPI::TEST_F):
651         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
652         (TestWebKitAPI::eq):
653         * TestWebKitAPI/Tests/mac/SSLKeyGenerator.mm:
654         (TestWebKitAPI::SSLKeyGeneratorTest::TearDown):
655
656 2018-05-25  Ms2ger  <Ms2ger@igalia.com>
657
658         Minor improvements to wpt exporter.
659         https://bugs.webkit.org/show_bug.cgi?id=185978
660
661         Reviewed by Youenn Fablet.
662
663         * Scripts/webkitpy/w3c/test_exporter.py:
664         (TestExporter.push_to_wpt_fork): Update call to create_upload_remote().
665         (TestExporter.make_pull_request): Improve the description of the created PR.
666         (TestExporter.create_upload_remote): Always update the remote to override any obsolete state.
667
668 2018-05-25  Saam Barati  <sbarati@apple.com>
669
670         Have a memory test where we can validate JSCs mini memory mode
671         https://bugs.webkit.org/show_bug.cgi?id=185932
672
673         Reviewed by Mark Lam.
674
675         This patch adds the run-testmem script. This runs the new testmem
676         CLI against the contents in the testmem benchmark. The contents of testmem
677         contain tests from ARES-6, Sunspider, Octane, and JetStream.
678         
679         One iteration of the benchmark comprises of running each testmem test for
680         a certain number of iterations. We collect the peak memory usage, the memory
681         usage after running all the iterations, and the time it takes to run all the
682         iterations. We then run the entire benchmark 3 times over. For each test, we
683         compute the arithmetic mean over each iteration for time, peak memory, and
684         end memory. The benchmark then computes a time score and memory score.
685         
686         peak memory score = geomean({peak memory of each individual test})
687         end memory score = geomean({end memory of each individual test})
688         memory score = geomean({peak memory score, end memory score})
689         time score = geomean({time score of each individual test})
690         
691         We want the memory score to weigh improvements to peak memory usage and
692         memory usage at the end equally.
693         
694         We plan to tune this benchmark in JSC's mini mode by improving the memory
695         score while ensuring the time score is not more than 10-15% regressed.
696
697         * Scripts/run-testmem: Added.
698
699 2018-05-25  Sihui Liu  <sihui_liu@apple.com>
700
701         [WKHTTPCookieStore getAllCookies] returns inconsistent creation time
702         https://bugs.webkit.org/show_bug.cgi?id=185041
703         <rdar://problem/34684214>
704
705         Reviewed by Geoffrey Garen.
706
707         Add API test coverage.
708
709         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
710         (TEST):
711
712 2018-05-24  Chris Dumez  <cdumez@apple.com>
713
714         Reduce copying of FontCascadeDescription objects by moving them around
715         https://bugs.webkit.org/show_bug.cgi?id=185963
716
717         Reviewed by Simon Fraser.
718
719         Reduce copying of FontCascadeDescription objects by moving them around when possible.
720
721         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
722         (TestWebKitAPI::TEST_F):
723
724 2018-05-24  Carlos Garcia Campos  <cgarcia@igalia.com>
725
726         WebDriver: implement maximize, minimize and fullscreen window commands
727         https://bugs.webkit.org/show_bug.cgi?id=180398
728
729         Reviewed by Brian Burg.
730
731         * Scripts/webkitpy/port/xvfbdriver.py:
732         (XvfbDriver._setup_environ_for_test): Set UNDER_XVFB environment variable when running under Xvfb.
733
734 2018-05-24  Xabier Rodriguez Calvar  <calvaris@igalia.com>
735
736         [GStreamer] Save some time disabling some compile options in the dependencies
737         https://bugs.webkit.org/show_bug.cgi?id=185909
738
739         Reviewed by Philippe Normand.
740
741         * gstreamer/jhbuild.modules: Added  --disable-tests to gstreamer
742         and --disable-examples --disable-gtk-doc to gstreamer-vaapi.
743
744 2018-05-23  Roy Reapor  <rreapor@apple.com>
745
746         Use Helvetica on build.webkit.org webpages
747         https://bugs.webkit.org/show_bug.cgi?id=185894
748
749         Reviewed by Aakash Jain.
750
751         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
752         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
753         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html:
754
755 2018-05-23  Aakash Jain  <aakash_jain@apple.com>
756
757         Add Buildbot configuration for Opensource EWS
758         https://bugs.webkit.org/show_bug.cgi?id=185484
759
760         Rubber-stamped by Alexey Proskuryakov.
761
762         * BuildSlaveSupport/ews-build/config.json: Added, config file.
763         * BuildSlaveSupport/ews-build/factories.py: Added, basic template for factories.
764         * BuildSlaveSupport/ews-build/loadConfig.py: Added.
765         (loadBuilderConfig): Loads the configuration.
766         (checkValidWorker): Checks if the worker is valid.
767         (checkValidBuilder): Checks if the builder is valid.
768         (checkWorkersAndBuildersForConsistency): Check if workers and builders are consistent.
769         (checkWorkersAndBuildersForConsistency._find_worker_with_name):
770         (getBlackListedTags): Returns a list of keywords which should not be listed as tags.
771         (getValidTags): Returns a list of valid tags.
772         (getTagsForBuilder): Return a list of tags for given builder.
773         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: unit-tests for loadConfig.py.
774         * BuildSlaveSupport/ews-build/master.cfg: Configuration for buildbot.
775
776 2018-05-23  Michael Catanzaro  <mcatanzaro@igalia.com>
777
778         [GTK] Silence GCC 8 warnings
779         https://bugs.webkit.org/show_bug.cgi?id=185556
780
781         Reviewed by Žan Doberšek.
782
783         GCC is complaining about this strncpy. It's guaranteed to be safe, because the length of
784         source and destination are always identical. But switching to snprintf avoids the warning.
785
786         * DumpRenderTree/TestNetscapePlugIn/Tests/FormValue.cpp:
787         (FormValue::NPP_GetValue):
788
789 2018-05-23  Ryan Haddad  <ryanhaddad@apple.com>
790
791         Unreviewed, rolling out r232112.
792
793         The tests added with this change  are failing on the bots.
794
795         Reverted changeset:
796
797         "test262/Runner.pm: add unit tests"
798         https://bugs.webkit.org/show_bug.cgi?id=185783
799         https://trac.webkit.org/changeset/232112
800
801 2018-05-23  Valerie R Young  <valerie@bocoup.com>
802
803         test262/Runner.pm: add unit tests
804         https://bugs.webkit.org/show_bug.cgi?id=185783
805
806         Reviewed by Aakash Jain.
807
808         Add unit tests to be run by test-webkitperl
809
810         * Scripts/test262/Runner.pm:
811         (main):
812          - If harness files cannot be found in a custom, supplies test262 path,
813            then sure the webkit test262 harness files.
814          - Lazily create the test262-results directory.
815          - If an expectation file is supplied via command line, save to the
816            supplied location instead of the detault webkit location.
817         (compileTest):
818         (processResult):
819         (getHarness):
820         * Scripts/webkitperl/test262_unittest/README: Added.
821         * Scripts/webkitperl/test262_unittest/fixtures/expectations-compare.yaml: Added.
822         * Scripts/webkitperl/test262_unittest/fixtures/expectations.yaml: Added.
823         * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-fail-now-failing-with-new-error.js: Added.
824         * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-fail-now-failing.js: Added.
825         * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-fail-now-passing.js: Added.
826         (f):
827         * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-pass-now-failing.js: Added.
828         * Scripts/webkitperl/test262_unittest/fixtures/test/fail.js: Added.
829         * Scripts/webkitperl/test262_unittest/fixtures/test/pass.js: Added.
830         (f):
831         * Scripts/webkitperl/test262_unittest/test262-runner-tests.pl: Added.
832
833 2018-05-22  Roy Reapor  <rreapor@apple.com>
834
835         Test infrastructure websites should use jQuery and jQuery UI hosted on webkit.org
836         https://bugs.webkit.org/show_bug.cgi?id=185788
837
838         Reviewed by Aakash Jain.
839
840         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
841         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
842         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html:
843         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
844         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html:
845         * TestResultServer/static-dashboards/run-embedded-unittests.html:
846         * TestResultServer/static-dashboards/run-unittests.html:
847
848 2018-05-22  Sihui Liu  <sihui_liu@apple.com>
849
850         [iOS] TestWebKitAPI.WebKit.WKHTTPCookieStoreWithoutProcessPool is crashing with reason: 'Completion handler passed to -[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:] was not called'
851         https://bugs.webkit.org/show_bug.cgi?id=185831
852
853         Reviewed by Chris Dumez.
854
855         Updated the test to prevent crash after assertion fails.
856
857         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
858         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
859
860 2018-05-22  Chris Dumez  <cdumez@apple.com>
861
862         Regression(AsyncPolicyDelegates): Box.app login Window is blank
863         https://bugs.webkit.org/show_bug.cgi?id=185832
864         <rdar://problem/40307871>
865
866         Reviewed by Geoffrey Garen.
867
868         Add API test coverage.
869
870         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
871         * TestWebKitAPI/Tests/WebKit/cocoa/WeakObjCPtr.mm:
872         * TestWebKitAPI/Tests/mac/NoPolicyDelegateResponse.mm: Added.
873         (-[NoPolicyDelegateDecisionDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
874         (-[NoPolicyDelegateDecisionDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
875         (-[NoPolicyDelegateDecisionDelegate webView:didFinishLoadForFrame:]):
876         (TestWebKitAPI::TEST):
877         * TestWebKitAPI/cocoa/TestWKWebView.mm:
878         (-[WKWebView _isBackground]):
879
880 2018-05-22  Sihui Liu  <sihui_liu@apple.com>
881
882         Conversion between SecurityOriginData and DatabaseIdentifier is asymmetric when port is null
883         https://bugs.webkit.org/show_bug.cgi?id=185715
884
885         Reviewed by Geoffrey Garen.
886
887         Add API test coverage.
888
889         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
890         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageDatabaseTracker.mm: Added.
891         (-[LocalStorageUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
892         (TEST):
893
894 2018-05-22  Sihui Liu  <sihui_liu@apple.com>
895
896         Unreviewed, added myself as a WebKit committer.
897
898         * Scripts/webkitpy/common/config/contributors.json:
899
900 2018-05-22  Ryan Haddad  <ryanhaddad@apple.com>
901
902         Unreviewed, rolling out r232052.
903
904         Breaks internal builds.
905
906         Reverted changeset:
907
908         "Use more C++17"
909         https://bugs.webkit.org/show_bug.cgi?id=185176
910         https://trac.webkit.org/changeset/232052
911
912 2018-05-22  Thibault Saunier  <tsaunier@igalia.com>
913
914         [GStreamer] Update to GStreamer 1.14.1 in jhbuild
915         https://bugs.webkit.org/show_bug.cgi?id=185689
916
917         Reviewed by Philippe Normand.
918
919         And update the patches, removing the ones that have been merged upstream.
920
921         * gstreamer/jhbuild.modules:
922         * gstreamer/patches/gst-plugins-good-0001-gstgdkpixbufdec-stop-pretending-to-decode-gifs.patch: Removed.
923         * gstreamer/patches/gst-plugins-good-0001-souphttpsrc-cookie-jar-and-context-query-support.patch: Removed. Not needed anymore and closed as OBSELETE upstream.
924         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gstreamer/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch
925         This patch has now been merged in GStreamer master and will be there in GStreamer 1.16.
926         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Renamed from Tools/gstreamer/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch.
927         This patch has now been merged in GStreamer master and will be there in GStreamer 1.16.
928         * gstreamer/patches/gst-plugins-good-0009-qtdemux-fix-assert-when-moof-contains-one-sample.patch: Removed.
929         * gstreamer/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Removed.
930
931 2018-05-21  Yusuke Suzuki  <utatane.tea@gmail.com>
932
933         Use more C++17
934         https://bugs.webkit.org/show_bug.cgi?id=185176
935
936         Reviewed by JF Bastien.
937
938         * DumpRenderTree/mac/Configurations/Base.xcconfig:
939         * ImageDiff/cg/Configurations/Base.xcconfig:
940         * MiniBrowser/Configurations/Base.xcconfig:
941         * MobileMiniBrowser/Configurations/Base.xcconfig:
942         * TestWebKitAPI/Configurations/Base.xcconfig:
943         * WebKitTestRunner/Configurations/Base.xcconfig:
944
945 2018-05-21  Fujii Hironori  <Hironori.Fujii@sony.com>
946
947         [WinCairo] Enable WebKit build by default
948         https://bugs.webkit.org/show_bug.cgi?id=185141
949
950         Reviewed by Per Arne Vollan.
951
952         TestWTF, TestWebCore and TestWebKitLegacy need a dependency to
953         WebKitForwardingHeaders because config.h includes a header of WK2.
954
955         * TestWebKitAPI/PlatformWin.cmake: Make TestWTFLib, TestWebCoreLib and TestWebKitLegacyLib depend on WebKitForwardingHeaders.
956         * TestWebKitAPI/config.h: Use PLATFORM(WIN_CAIRO) instead of BUILDING_WIN_CAIRO_WEBKIT.
957
958 2018-05-21  Jer Noble  <jer.noble@apple.com>
959
960         Complete fix for enabling modern EME by default
961         https://bugs.webkit.org/show_bug.cgi?id=185770
962         <rdar://problem/40368220>
963
964         Reviewed by Eric Carlson.
965
966         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
967
968 2018-05-18  Christopher Reid  <chris.reid@sony.com>
969
970         Unreviewed, add myself as a WebKit committer.
971
972         * Scripts/webkitpy/common/config/contributors.json:
973
974 2018-05-21  Carlos Garcia Campos  <cgarcia@igalia.com>
975
976         Unreviewed, rolling out r222967.
977
978         It's not ready yet
979
980         Reverted changeset:
981
982         "[GTK][WPE] Add API to configure and enable resource load
983         statistics"
984         https://bugs.webkit.org/show_bug.cgi?id=177943
985         https://trac.webkit.org/changeset/222967
986
987 2018-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
988
989         [GTK] MiniBrowser crashes when loading twice quickly
990         https://bugs.webkit.org/show_bug.cgi?id=185763
991
992         Reviewed by Michael Catanzaro.
993
994         This is very difficult to reproduce manually, but it happens when running WebDriver tests where loads are very
995         fast and multiple loads are done quickly. The problem is that we use an idle to reset the progress bar, but we
996         don't reset it when a new load starts. We always reset the last idle on destroy, but if there's another one
997         leaked, it will crash when scheduled if the window has already been destroyed.
998
999         * MiniBrowser/gtk/BrowserWindow.c:
1000         (webViewLoadProgressChanged): Stop any pending reset task when progress != 1.
1001
1002 2018-05-19  Sihui Liu  <sihui_liu@apple.com>
1003
1004         Flaky API test WebKit.WKHTTPCookieStoreWithoutProcessPool: incorrect order of cookies
1005         https://bugs.webkit.org/show_bug.cgi?id=185624
1006         <rdar://problem/39111626>
1007
1008         Reviewed by Chris Dumez.
1009
1010         Modified expectation to make test more robust as cookies can be returned in different orders.
1011
1012         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1013         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1014         (TEST):
1015
1016 2018-05-18  Commit Queue  <commit-queue@webkit.org>
1017
1018         Unreviewed, rolling out r231982.
1019         https://bugs.webkit.org/show_bug.cgi?id=185793
1020
1021         Caused layout test failures (Requested by realdawei on
1022         #webkit).
1023
1024         Reverted changeset:
1025
1026         "Complete fix for enabling modern EME by default"
1027         https://bugs.webkit.org/show_bug.cgi?id=185770
1028         https://trac.webkit.org/changeset/231982
1029
1030 2018-05-18  Eric Carlson  <eric.carlson@apple.com>
1031
1032         Handle failure to extend sandbox gracefully
1033         https://bugs.webkit.org/show_bug.cgi?id=185779
1034         <rdar://problem/40316349>
1035
1036         Unreviewed, fix test results.
1037
1038         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
1039         (TEST_F):
1040
1041 2018-05-18  Jer Noble  <jer.noble@apple.com>
1042
1043         Complete fix for enabling modern EME by default
1044         https://bugs.webkit.org/show_bug.cgi?id=185770
1045         <rdar://problem/40368220>
1046
1047         Reviewed by Eric Carlson.
1048
1049         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1050
1051 2018-05-18  Eric Carlson  <eric.carlson@apple.com>
1052
1053         Handle failure to extend sandbox gracefully
1054         https://bugs.webkit.org/show_bug.cgi?id=185779
1055         <rdar://problem/40316349>
1056
1057         Reviewed by Brent Fulgham.
1058
1059         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1060         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm: Added.
1061         (-[SimulateFailedSandboxMessageHandler userContentController:didReceiveScriptMessage:]):
1062         (-[SimulateFailedSandboxUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1063         (-[SimulateFailedSandboxUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1064         (MediaCaptureSimulateFailedSandbox::SetUp):
1065         (MediaCaptureSimulateFailedSandbox::loadTestAndWaitForMessage):
1066         (TEST_F):
1067         * TestWebKitAPI/Tests/WebKitCocoa/disableGetUserMedia.html:
1068
1069 2018-05-18  Daniel Bates  <dabates@apple.com>
1070
1071         "debug-safari --ios-simulator" creates lldb target to launch Mac Safari
1072         https://bugs.webkit.org/show_bug.cgi?id=185774
1073
1074         Reviewed by Andy Estes.
1075
1076         For now, the script debug-safari is not supported for WebKit for iOS. To
1077         fix this we differentiate between the Apple Mac port and Apple embedded
1078         ports.
1079
1080         * Scripts/webkitdirs.pm:
1081         (safariPath): Substitute isAppleMacWebKit() for isAppleCocoaWebKit().
1082         (isAppleMacWebKit): Added.
1083         (isAppleCocoaWebKit): Write in terms of isAppleMacWebKit() and isEmbeddedWebKit().
1084         (launcherName): Substitute isAppleMacWebKit() for isAppleCocoaWebKit().
1085         (mobileSafariBundle): Substitute isIOSWebKit() for isAppleCocoaWebKit().
1086         (debugSafari): Substitute isAppleMacWebKit() for isAppleCocoaWebKit().
1087         (runSafari): Ditto.
1088         (runMiniBrowser): Ditto.
1089         (debugMiniBrowser): Ditto.
1090         (runWebKitTestRunner): Ditto.
1091         (debugWebKitTestRunner): Ditto.
1092
1093 2018-05-18  Antoine Quint  <graouts@apple.com>
1094
1095         [Web Animations] Turn Web Animations with CSS integration on for test runners
1096         https://bugs.webkit.org/show_bug.cgi?id=184819
1097         <rdar://problem/39597337>
1098
1099         Unreviewed. Rolling out the patch for this bug, it caused some flaky timeouts for animation suspension tests.
1100
1101         * DumpRenderTree/TestOptions.cpp:
1102         (TestOptions::TestOptions):
1103         * DumpRenderTree/TestOptions.h:
1104         * DumpRenderTree/mac/DumpRenderTree.mm:
1105         (runTest):
1106         (shouldOverrideAndDisableWebAnimationsCSSIntegrationPreference): Deleted.
1107         * WebKitTestRunner/TestController.cpp:
1108         (WTR::TestController::resetPreferencesToConsistentValues):
1109         (WTR::updateTestOptionsFromTestHeader):
1110         * WebKitTestRunner/TestOptions.cpp:
1111         (WTR::TestOptions::TestOptions):
1112         (WTR::isLegacyAnimationEngineTestPath): Deleted.
1113         * WebKitTestRunner/TestOptions.h:
1114
1115 2018-05-18  Fujii Hironori  <Hironori.Fujii@sony.com>
1116
1117         [Win][MiniBrowser] Create MainWindow even in transparent mode
1118         https://bugs.webkit.org/show_bug.cgi?id=185597
1119
1120         Reviewed by Per Arne Vollan.
1121
1122         The current implementations doesn't create the MainWindow in
1123         transparent mode. The screenshot is in Bug 58300.
1124
1125         There were three problems:
1126         - Can't control the WebView. ie. going backward and forward.
1127         - Can't quit the program.
1128         - It makes implementation complicated.
1129
1130         * MiniBrowser/win/Common.cpp (resizeSubViews): Resize sub views
1131         even in the transparent mode.
1132         * MiniBrowser/win/WinMain.cpp:
1133         (wWinMain): Create the main window even in the transparent mode.
1134
1135 2018-05-18  Antoine Quint  <graouts@apple.com>
1136
1137         [Web Animations] Turn Web Animations with CSS integration on for test runners
1138         https://bugs.webkit.org/show_bug.cgi?id=184819
1139         <rdar://problem/39597337>
1140
1141         Reviewed by Jon Lee.
1142
1143         Make the test runners turn both the main Web Animations flag and the Web Animations CSS
1144         integration flag on.
1145
1146         We also remove the ability to toggle the Web Animations CSS integration flag using an HTML
1147         comment directly at the top of the file since test runners now set the flag on by default
1148         and a dedicated directory exists for tests that need to run with this flag off.
1149
1150         * DumpRenderTree/TestOptions.cpp:
1151         (TestOptions::TestOptions):
1152         * DumpRenderTree/TestOptions.h:
1153         * DumpRenderTree/mac/DumpRenderTree.mm:
1154         (shouldOverrideAndDisableWebAnimationsCSSIntegrationPreference):
1155         (runTest):
1156         * WebKitTestRunner/TestController.cpp:
1157         (WTR::TestController::resetPreferencesToConsistentValues):
1158         (WTR::updateTestOptionsFromTestHeader):
1159         * WebKitTestRunner/TestOptions.cpp:
1160         (WTR::isLegacyAnimationEngineTestPath):
1161         (WTR::TestOptions::TestOptions):
1162         * WebKitTestRunner/TestOptions.h:
1163
1164 2018-05-17  Nan Wang  <n_wang@apple.com>
1165
1166         AX: [macOS] Expose the primary screen height through AX API
1167         https://bugs.webkit.org/show_bug.cgi?id=185742
1168
1169         Reviewed by Chris Fleizach.
1170
1171         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1172         (attributesOfElement):
1173         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1174         (WTR::attributesOfElement):
1175
1176 2018-05-17  Commit Queue  <commit-queue@webkit.org>
1177
1178         Unreviewed, rolling out r231912.
1179         https://bugs.webkit.org/show_bug.cgi?id=185750
1180
1181         It is prompting the user when there is no WPT changes
1182         (Requested by bmac on #webkit).
1183
1184         Reverted changeset:
1185
1186         "Export changes to web-platform-test as part of the webkit-
1187         patch upload workflow"
1188         https://bugs.webkit.org/show_bug.cgi?id=184914
1189         https://trac.webkit.org/changeset/231912
1190
1191 2018-05-17  Valerie R Young  <valerie@bocoup.com>
1192
1193         test262/Runner.pm: expand $INC to find webkitdirs.pm
1194         https://bugs.webkit.org/show_bug.cgi?id=185739
1195
1196         Reviewed by Michael Saboff.
1197
1198         * Scripts/test262/Runner.pm:
1199         (getBuildPath):
1200
1201 2018-05-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1202
1203         [WPE] Implement and enable FULLSCREEN_API
1204         https://bugs.webkit.org/show_bug.cgi?id=185676
1205
1206         Reviewed by Žan Doberšek.
1207
1208         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
1209         (testWebViewFullScreen):
1210
1211 2018-05-17  Brendan McLoughlin  <brendan@bocoup.com>
1212
1213         Export changes to web-platform-test as part of the webkit-patch upload workflow
1214         https://bugs.webkit.org/show_bug.cgi?id=184914
1215
1216         Reviewed by Youenn Fablet.
1217
1218         * Scripts/webkitpy/tool/commands/upload.py:
1219         (Upload):
1220         (CreateBug.execute):
1221         (WPTChangeExport):
1222         * Scripts/webkitpy/tool/steps/__init__.py:
1223         * Scripts/webkitpy/tool/steps/wptchangeexport.py: Added.
1224         (WPTChangeExport):
1225         (WPTChangeExport.options):
1226         (WPTChangeExport.run):
1227         * Scripts/webkitpy/w3c/common.py:
1228         * Scripts/webkitpy/w3c/test_exporter.py:
1229         (WebPlatformTestExporter):
1230         (WebPlatformTestExporter.__init__):
1231         (WebPlatformTestExporter.username):
1232         (WebPlatformTestExporter.token):
1233         (WebPlatformTestExporter._github):
1234         (WebPlatformTestExporter._wpt_fork_branch_github_url):
1235         (WebPlatformTestExporter._wpt_fork_remote):
1236         (WebPlatformTestExporter._wpt_fork_push_url):
1237         (WebPlatformTestExporter._git):
1238         (WebPlatformTestExporter._branch_name):
1239         (WebPlatformTestExporter._public_branch_name):
1240         (WebPlatformTestExporter.has_wpt_changes):
1241         (WebPlatformTestExporter._create_patch):
1242         (WebPlatformTestExporter.create_git_patch):
1243         (WebPlatformTestExporter._prompt_for_token):
1244         (WebPlatformTestExporter._prompt_for_username):
1245         (WebPlatformTestExporter._ensure_username_and_token):
1246         (WebPlatformTestExporter._validate_and_save_token):
1247         (WebPlatformTestExporter.push_to_wpt_fork):
1248         (WebPlatformTestExporter.make_pull_request):
1249         (WebPlatformTestExporter.delete_local_branch):
1250         (parse_args):
1251         (TestExporter): Deleted.
1252         (TestExporter.__init__): Deleted.
1253         (TestExporter._ensure_wpt_repository): Deleted.
1254         (TestExporter._fetch_wpt_repository): Deleted.
1255         (TestExporter._ensure_new_branch_name): Deleted.
1256         (TestExporter.download_and_commit_patch): Deleted.
1257         (TestExporter.clean): Deleted.
1258         (TestExporter.create_branch_with_patch): Deleted.
1259         (TestExporter.push_to_wpt_fork): Deleted.
1260         (TestExporter.make_pull_request): Deleted.
1261         (TestExporter.create_wpt_pull_request): Deleted.
1262         (TestExporter.delete_local_branch): Deleted.
1263         (TestExporter.create_git_patch): Deleted.
1264         (TestExporter.create_upload_remote_if_needed): Deleted.
1265         (TestExporter.do_export): Deleted.
1266         * Scripts/webkitpy/w3c/test_exporter_unittest.py:
1267         (TestExporterTest.test_export):
1268         (TestExporterTest.test_export_with_specific_branch):
1269         (TestExporterTest):
1270         (TestExporterTest.test_export_interactive_mode):
1271         (TestExporterTest.test_export_invalid_token):
1272         (TestExporterTest.test_export_wrong_token):
1273
1274 2018-05-17  Valerie R Young  <valerie@bocoup.com>
1275
1276         test262/Runner.pm: look for jsc in path if cannot call webkit-build-directory
1277         https://bugs.webkit.org/show_bug.cgi?id=185650
1278
1279         Reviewed by Michael Saboff.
1280
1281         First, use jsc from CLI arg, then try to use webkit-build-directory,
1282         if that doesn't work, look for jsc in the $PATH
1283
1284         * Scripts/test262/Runner.pm:
1285         (processCLI):
1286         (getBuildPath):
1287         (runTest):
1288
1289 2018-05-16  Leo Balter  <leonardo.balter@gmail.com>
1290
1291         Test262-Runner: Adds a --timeout option
1292         https://bugs.webkit.org/show_bug.cgi?id=185696
1293
1294         Reviewed by Michael Saboff.
1295
1296         The timeout option is used to set a timeout execution in ms for each test run in JSC.
1297         The passed value - if defined - will be used as the value for the JSC --watchdog arg.
1298         * Scripts/test262/Runner.pm:
1299         (processCLI):
1300         (runTest):
1301
1302 2018-05-16  Leo Balter  <leonardo.balter@gmail.com>
1303
1304         Test262-Runner: Set timer for each test run
1305         https://bugs.webkit.org/show_bug.cgi?id=185692
1306
1307         Reviewed by Michael Saboff.
1308
1309         Sets a high resolution timer for each execution call of JSC, reporting
1310         the time in the results report to allow identifying slow tests.
1311         * Scripts/test262/Runner.pm:
1312         (main):
1313         (processFile):
1314         (runTest):
1315         (processResult):
1316
1317 2018-05-16  Andy VanWagoner  <andy@vanwagoner.family>
1318
1319         Add support for Intl NumberFormat formatToParts
1320         https://bugs.webkit.org/show_bug.cgi?id=185375
1321
1322         Reviewed by Yusuke Suzuki.
1323
1324         Add flag for NumberFormat formatToParts.
1325
1326         * Scripts/webkitperl/FeatureList.pm:
1327         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1328
1329 2018-05-14  Yusuke Suzuki  <utatane.tea@gmail.com>
1330
1331         [Win] Use C++17 in MSVC
1332         https://bugs.webkit.org/show_bug.cgi?id=185232
1333
1334         Reviewed by Alex Christensen.
1335
1336         Do not use `using namespace std;`. In C++17, we have std::byte. This "byte"
1337         conflicts with ::byte defined in Windows' header.
1338
1339         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp:
1340         (WindowedPluginTest::WindowedPluginTest):
1341         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1342         (logEventProc):
1343         (stringEvent):
1344         (AccessibilityController::winNotificationReceived):
1345         * DumpRenderTree/win/TextInputController.cpp:
1346         (markedRangeCallback):
1347         (firstRectForCharacterRangeCallback):
1348         (selectedRangeCallback):
1349         * DumpRenderTree/win/TextInputController.h:
1350         * DumpRenderTree/win/TextInputControllerWin.cpp:
1351         (TextInputController::markedRange):
1352         (TextInputController::firstRectForCharacterRange):
1353         (TextInputController::selectedRange):
1354
1355 2018-05-16  Sihui Liu  <sihui_liu@apple.com>
1356
1357         Session cookies aren't reliably set when using default WKWebSiteDataStore
1358         https://bugs.webkit.org/show_bug.cgi?id=185624
1359         <rdar://problem/39111626>
1360
1361         Reviewed by Geoffrey Garen.
1362
1363         Modified and enabled WebKit.WKHTTPCookieStoreWithoutProcessPool.
1364
1365         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1366         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1367         (TEST):
1368
1369 2018-05-16  Valerie R Young  <valerie@bocoup.com>
1370
1371         test262/Runner.pm: save to supplied expectation file if supplied
1372         https://bugs.webkit.org/show_bug.cgi?id=185660
1373
1374         Reviewed by Michael Saboff.
1375
1376         * Scripts/test262/Runner.pm:
1377         (processCLI):
1378         (main):
1379
1380 2018-05-15  Ryan Haddad  <ryanhaddad@apple.com>
1381
1382         Unreviewed, rolling out r231763.
1383
1384         The test added with this change is failing an assertion.
1385
1386         Reverted changeset:
1387
1388         "NSEvent event trackers don't work from WebKitTestRunner"
1389         https://bugs.webkit.org/show_bug.cgi?id=185383
1390         https://trac.webkit.org/changeset/231763
1391
1392 2018-05-15  David Kilzer  <ddkilzer@apple.com>
1393
1394         TestWebKitAPI: Fix warnings found by new clang compiler
1395         <https://webkit.org/b/185631>
1396
1397         Reviewed by Michael Catanzaro.
1398
1399         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
1400         (TestWebKitAPI::TEST):
1401         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
1402         (TestWebKitAPI::TEST):
1403         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
1404         (TestWebKitAPI::TEST):
1405         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
1406         (TestWebKitAPI::TEST):
1407         - Add #pragma statements to ignore the new
1408           -Wself-assign-overloaded warning and to ignore
1409           this as an unknown warning on older clang versions.  We want
1410           to keep these self assigments as this code is designed to test
1411           that use case.
1412
1413         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
1414         (TestWebKitAPI::didFindStringMatches):
1415         - Replace the "rect = rect;" statement that was used to avoid an
1416           unused variable warning with two expectations.
1417
1418         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1419         (-[PinnedStateObserver observeValueForKeyPath:ofObject:change:context:]):
1420         - Switch from -integerValue to -unsignedIntegerValue when
1421           comparing against _WKRectEdgeAll since it's an enum declared
1422           as an NSUInteger.
1423
1424 2018-05-15  Michael Catanzaro  <mcatanzaro@igalia.com>
1425
1426         Unreviewed, rolling out r230749
1427
1428         This did not work as desired.
1429
1430         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1431         (TestWebKitAPI::TEST):
1432
1433 2018-05-15  Antoine Quint  <graouts@apple.com>
1434
1435         [Web Animations] Expose Web Animations CSS integration as an experimental feature
1436         https://bugs.webkit.org/show_bug.cgi?id=185647
1437
1438         Reviewed by Dean Jackson.
1439
1440         Rename the Web Animations CSS integration flag.
1441
1442         * DumpRenderTree/TestOptions.cpp:
1443         (TestOptions::TestOptions):
1444         * DumpRenderTree/TestOptions.h:
1445         * DumpRenderTree/mac/DumpRenderTree.mm:
1446         (setWebPreferencesForTestOptions):
1447         * WebKitTestRunner/TestController.cpp:
1448         (WTR::TestController::resetPreferencesToConsistentValues):
1449         (WTR::updateTestOptionsFromTestHeader):
1450         * WebKitTestRunner/TestOptions.h:
1451         (WTR::TestOptions::hasSameInitializationOptions const):
1452
1453 2018-05-14  Brady Eidson  <beidson@apple.com>
1454
1455         Add an API test to guard against regressions while re-entering setDefersLoading:.
1456         <rdar://problem/37033737> and https://bugs.webkit.org/show_bug.cgi?id=185630
1457
1458         Reviewed by Chris Dumez.
1459
1460         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1461         * TestWebKitAPI/Tests/WebKitCocoa/DoubleDefersLoading.mm: Added.
1462         (-[DoubleDefersNavigationDelegate _webView:navigation:didSameDocumentNavigation:]):
1463         (-[DoubleDefersNavigationDelegate webView:didFinishNavigation:]):
1464         (-[DefersScheme initWithBytes:]):
1465         (-[DefersScheme webView:startURLSchemeTask:]):
1466         (-[DefersScheme webView:stopURLSchemeTask:]):
1467         * TestWebKitAPI/Tests/WebKitCocoa/DoubleDefersLoadingPlugin.mm: Added.
1468         (-[DoubleDefersLoadingPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1469         (-[DoubleDefersLoadingPlugIn webProcessPlugInBrowserContextController:didSameDocumentNavigation:forFrame:]):
1470         (-[DoubleDefersLoadingPlugIn dealloc]):
1471
1472 2018-05-14  Daniel Bates  <dabates@apple.com>
1473
1474         [iOS] Add a test to ensure that setTimeout() does not fire more than expected when using UIWebView
1475         https://bugs.webkit.org/show_bug.cgi?id=185599
1476         <rdar://problem/22493890>
1477
1478         Reviewed by Simon Fraser.
1479
1480         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1481         * TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm: Added.
1482         (-[SetTimeoutFunctionWebViewDelegate webViewDidFinishLoad:]):
1483         (-[SetTimeoutFunctionWebViewDelegate webView:didFailLoadWithError:]):
1484         (-[SetTimeoutFunctionWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
1485         (TestWebKitAPI::TEST):
1486         * TestWebKitAPI/ios/set-timeout-function.html: Added.
1487
1488 2018-05-14  Valerie R Young  <valerie@bocoup.com>
1489
1490         test262/Runner.pm: small bugs in CLI and error codes
1491         https://bugs.webkit.org/show_bug.cgi?id=185629
1492
1493         Reviewed by Michael Saboff.
1494
1495         Fix two commandline args with use '-f', correct
1496         error code of failures.
1497
1498         * Scripts/test262/Runner.pm:
1499         (processCLI):
1500         (main):
1501
1502 2018-05-14  Ryan Haddad  <ryanhaddad@apple.com>
1503
1504         Disable API tests that time out after pointer poisioning was disabled.
1505         https://bugs.webkit.org/show_bug.cgi?id=185586
1506
1507         Unreviewed test gardening.
1508
1509         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
1510         (TestWebKitAPI::TEST):
1511         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
1512         (TestWebKitAPI::TEST):
1513         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
1514         (TestWebKitAPI::TEST):
1515         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
1516         (TestWebKitAPI::TEST):
1517
1518 2018-05-14  Leo Balter  <leonardo.balter@gmail.com>
1519
1520         Test262-Runner: Fix RegExp for capturing tests metadata"
1521         https://bugs.webkit.org/show_bug.cgi?id=185622
1522
1523         Reviewed by Michael Saboff.
1524
1525         This patch fixes the RegExp used to capture each test metadata regarding their EOL characters for
1526         both LF and CRLF forms.
1527
1528         The fix also allows the runner to capture the proper results from two specific files using CR and
1529         CRLF line terminators. They are updated in the expectations file.
1530         * Scripts/test262/Runner.pm:
1531         (parseData):
1532
1533 2018-05-14  Jeremy Jones  <jeremyj@apple.com>
1534
1535         NSEvent event trackers don't work from WebKitTestRunner
1536         https://bugs.webkit.org/show_bug.cgi?id=185383
1537         rdar://problem/40025045
1538
1539         Reviewed by Simon Fraser.
1540
1541         Post simulated wheel events to _sendEventToObservers: so they can be handled by NSEvent observers.
1542         NSEvent swipe tracking is used for webkit swipe navigation.
1543
1544         * WebKitTestRunner/mac/EventSenderProxy.mm:
1545         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
1546
1547 2018-05-11  Leo Balter  <leonardo.balter@gmail.com>
1548
1549         Test262 Runner should search for the Debug JSC by default
1550         https://bugs.webkit.org/show_bug.cgi?id=185562
1551
1552         Reviewed by Michael Saboff.
1553
1554         The Test262 Runner is now searching for the Debug build of JSC by
1555         default, not the Release build.
1556
1557         This fix allows a similar call from the previous runner, making
1558         it compatible with the current build bot configuration parameters.
1559
1560         This patch also adds some minor improvements the verbose mode output.
1561
1562         * Scripts/test262/Runner.pm:
1563         (processCLI):
1564         (main):
1565         (getBuildPath):
1566         (processResult):
1567
1568 2018-05-11  Charles Vazac  <cvazac@gmail.com>
1569
1570         Runtime feature flag for Server-Timing
1571         https://bugs.webkit.org/show_bug.cgi?id=184758
1572
1573         Reviewed by Youenn Fablet.
1574
1575         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: added ENABLE_SERVER_TIMING.
1576         * DumpRenderTree/win/DumpRenderTree.cpp: enable Server Timing
1577
1578 2018-05-11  Fujii Hironori  <Hironori.Fujii@sony.com>
1579
1580         [Win][MiniBrowser] Move WK1 related code into MiniBrowser
1581         https://bugs.webkit.org/show_bug.cgi?id=185418
1582
1583         Reviewed by Alex Christensen.
1584
1585         All WK1 related code should be moved into MiniBrowser for the preparation
1586         of Bug 184770.
1587
1588         This change moves the initilization code of MiniBrowse into MiniBrowser::init().
1589
1590         * MiniBrowser/win/Common.cpp:
1591         (getAppDataFolder): Removed `static` keyword to be called from MiniBrowser.cpp.
1592         (setCacheFolder): This is only for WK1. Moved into MiniBrowser.cpp.
1593         * MiniBrowser/win/Common.h: Added.
1594         * MiniBrowser/win/MiniBrowser.cpp:
1595         (MiniBrowser::init): Moved the initilization code from wWinMain.
1596         (MiniBrowser::setCacheFolder): Moved from Common.cpp and made it a method.
1597         * MiniBrowser/win/MiniBrowser.h:
1598         (MiniBrowser::setCacheFolder): Changed to a private method.
1599         (MiniBrowser::subclassForLayeredWindow): Changed to a private method.
1600         * MiniBrowser/win/WinMain.cpp:
1601         (wWinMain): Moved MiniBrowse initilization code into MiniBrowser.cpp.
1602
1603 2018-05-11  Brady Eidson  <beidson@apple.com>
1604
1605         Make sure history navigations reuse the existing process when necessary.
1606         <rdar://problem/39746516> and https://bugs.webkit.org/show_bug.cgi?id=185532
1607
1608         Reviewed by Ryosuke Niwa.
1609
1610         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1611
1612 2018-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1613
1614         [JSC][GLIB] Add introspectable alternatives to functions using vargars
1615         https://bugs.webkit.org/show_bug.cgi?id=185508
1616
1617         Reviewed by Michael Catanzaro.
1618
1619         Add test cases for the new API.
1620
1621         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1622         (testJSCFunction):
1623         (testJSCObject):
1624
1625 2018-05-10  Leo Balter  <leonardo.balter@gmail.com>
1626
1627         [Build Bot] Restore configuration options to the Test262 Runner
1628
1629         During the switch from the previous Test262 runner to the new one,
1630         a call for an extra configurations options got removed.
1631
1632         This call is important to inform the script to find the debug or
1633         release build of JSC. It's being restored in this patch.
1634
1635         https://bugs.webkit.org/show_bug.cgi?id=185513
1636
1637         Reviewed by Yusuke Suzuki.
1638
1639         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1640         (RunTest262Tests):
1641
1642 2018-05-10  Jonathan Bedard  <jbedard@apple.com>
1643
1644         REGRESSION (r230998): Cannot stream API test output
1645         https://bugs.webkit.org/show_bug.cgi?id=185090
1646
1647         Reviewed by Ryosuke Niwa.
1648
1649         Change run-api-tests so that the stdout and stderr of a test will be printed
1650         before it's result. If -v is passed, the output of single test runs will be
1651         streamed. 
1652
1653         * Scripts/webkitpy/api_tests/run_api_tests.py:
1654         (run): Use print_timestamps flag.
1655         (parse_args): Add timestamps option to print timestamps in the log.
1656         * Scripts/webkitpy/api_tests/runner.py:
1657         (Runner): Add running status.
1658         (Runner.__init__): Add number of workers and a flag to detect if a newline
1659         is needed at the beginning of a log line.
1660         (Runner.run): Turn off most logging coming from server process since it is
1661         not constructive for API tests.
1662         (Runner.handle): Add new log message to stream stdout and stderr instead of
1663         caching values until the test run finished.
1664         (_Worker._run_single_test): Log stdout and stderr in real time.
1665         (_Worker._run_shard_with_binary): Log stderr and stdout buffer before ending
1666         the test.
1667         (_Worker.post): Provide a post with explicitly enumerated argument names.
1668         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
1669         (MeteredStream.__init__): Differentiate verbose logging and logging with timestamps.
1670         (MeteredStream.write): Allow for verbose logging without timestamps.
1671         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
1672         (RegularTest): Add print_timestamps flag.
1673         (RegularTest.setUp):
1674         (RegularTest.test_logging_not_included):
1675         (VerboseTest.test_log_args):
1676         (VerboseWithOutTimestamp):
1677         (VerboseWithOutTimestamp.test_basic): Add test for verbose logging without timestamps.
1678
1679 2018-05-10  Ryosuke Niwa  <rniwa@webkit.org>
1680
1681         build-webkit can erroneously warn about Xcode being too old
1682         https://bugs.webkit.org/show_bug.cgi?id=185533
1683
1684         Reviewed by Dan Bernstein.
1685
1686         Don't assume the version number is always a single digit.
1687
1688         * Scripts/webkitdirs.pm:
1689         (determineXcodeVersion):
1690
1691 2018-05-10  Ross Kirsling  <ross.kirsling@sony.com>
1692
1693         [WinCairo][Buildbot] Test bots need to acquire WinCairoRequirements.
1694         https://bugs.webkit.org/show_bug.cgi?id=185528
1695
1696         Reviewed by Lucas Forschler.
1697
1698         * BuildSlaveSupport/build.webkit.org-config/factories.py:
1699         (TestFactory.__init__):
1700         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1701         (InstallWinCairoDependencies):
1702
1703 2018-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
1704
1705         Fix some -Wstring-op-truncation warnings
1706         https://bugs.webkit.org/show_bug.cgi?id=185496
1707
1708         Reviewed by Alex Christensen.
1709
1710         We have an off-by-one in the use of strncpy. The strings would not be null-terminated if
1711         the input was too long. Ensure the buffers are zero-initialized so we don't need to manually
1712         set the last bucket to NUL.
1713
1714         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
1715         (TestWebKitAPI::testAtomicStringNumber):
1716         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1717         (TestWebKitAPI::testStringNumberFixedPrecision):
1718         (TestWebKitAPI::testStringNumberFixedWidth):
1719         (TestWebKitAPI::testStringNumber):
1720
1721 2018-05-10  Fujii Hironori  <Hironori.Fujii@sony.com>
1722
1723         [Win][MiniBrowser] Add a separate WndProc for the layered window
1724         https://bugs.webkit.org/show_bug.cgi?id=185460
1725
1726         Reviewed by Brent Fulgham.
1727
1728         All WK1 related code should be moved into MiniBrowser for the
1729         preparation of Bug 184770.
1730
1731         The layered window was using WndProc of the main window. The
1732         layered window is specific only for WK1. the main window will be
1733         shared among WK1 and WK2.
1734
1735         This change add a new WndProc for the layer window.
1736
1737         * MiniBrowser/win/Common.cpp:
1738         (WndProc): Removed code for the layered windows.
1739         (subclassForLayeredWindow): Moved into MiniBrowser.cpp.
1740         * MiniBrowser/win/MiniBrowser.cpp:
1741         (MiniBrowser::prepareViews): Removed the fourth argument `viewHwnd`.
1742         (viewWndProc): New WndProc for the layered windows.
1743         (MiniBrowser::subclassForLayeredWindow): Moved from Common.cpp.
1744         * MiniBrowser/win/MiniBrowser.h:
1745         (MiniBrowser::hwnd):
1746         * MiniBrowser/win/WinMain.cpp:
1747         (wWinMain): Added m_viewWnd.
1748
1749 2018-05-10  Stephan Szabo  <stephan.szabo@sony.com>
1750
1751         Support --verbose in run-javascriptcore-tests
1752         https://bugs.webkit.org/show_bug.cgi?id=185492
1753
1754         Reviewed by Daniel Bates.
1755
1756         * Scripts/run-javascriptcore-tests:
1757         (runJSCStressTests):
1758
1759 2018-05-10  Valerie R Young  <valerie@bocoup.com>
1760
1761         test262/Runner.pm: --failing-files uses results file not expectations
1762         https://bugs.webkit.org/show_bug.cgi?id=185395
1763
1764         Reviewed by Michael Saboff.
1765
1766         --failing-files arg now uses results file to find failing tests
1767         to rerun. It will look in the test262-results directory from whereever
1768         the script is run, or a results.yaml file can be supplied via command
1769         line argument.
1770         --expectations arg added for suppling expectation file.
1771
1772         * Scripts/test262/Runner.pm:
1773         (processCLI):
1774         (main):
1775         (loadImportFile):
1776         (findAllFailing):
1777
1778 2018-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1779
1780         [GTK] Add support for settings cookies policy and storage type in MiniBrowser
1781         https://bugs.webkit.org/show_bug.cgi?id=185506
1782
1783         Reviewed by Philippe Normand.
1784
1785         Useful for testing and debugging.
1786
1787         * MiniBrowser/gtk/main.c:
1788         (main):
1789
1790 2018-05-09  Chris Dumez  <cdumez@apple.com>
1791
1792         Unreviewed Windows build fix after r231622.
1793
1794         * DumpRenderTree/win/DumpRenderTree.cpp:
1795         (enableExperimentalFeatures):
1796
1797 2018-05-09  Sihui Liu  <sihui_liu@apple.com>
1798
1799         Update WebKit.WebsiteDataStoreCustomPaths after r231536
1800         https://bugs.webkit.org/show_bug.cgi?id=185486
1801         <rdar://problem/37214391>
1802
1803         Reviewed by Chris Dumez.
1804
1805         Update WebKit.WebsiteDataStoreCustomPaths as _syncNetworkProcessCookies is async now.
1806
1807         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1808         (TEST):
1809
1810 2018-05-09  Leo Balter  <leonardo.balter@gmail.com>
1811
1812         Test262-Runner: Improve the verbose output
1813         https://bugs.webkit.org/show_bug.cgi?id=185491
1814
1815         Reviewed by Michael Saboff.
1816
1817         * Scripts/test262/Import.pm:
1818         (transferFiles):
1819         * Scripts/test262/Runner.pm:
1820         (processResult):
1821
1822 2018-05-09  Leo Balter  <leonardo.balter@gmail.com>
1823
1824         Fix Test262 Runner to have DYLD_FRAMEWORK_PATH always set
1825         https://bugs.webkit.org/show_bug.cgi?id=185488
1826
1827         Reviewed by Michael Saboff.
1828
1829         * Scripts/test262/Runner.pm:
1830         (processCLI):
1831         (getBuildPath):
1832         (runTest):
1833
1834 2018-05-09  Richard Houle  <rhoule@apple.com>
1835
1836         [Cocoa] Some fields are not identified as [WKWebProcessPlugInNodeHandle isTextField]
1837         https://bugs.webkit.org/show_bug.cgi?id=185260
1838         <rdar://problem/39290394>
1839
1840         Reviewed by Tim Horton.
1841
1842         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1843         * TestWebKitAPI/Tests/WebKitCocoa/InjectedBundleNodeHandleIsTextField.mm: Added.
1844         (-[InjectedBundleNodeHandleIsTextField isTextFieldForHTMLInputType:document:jsContext:]):
1845         (-[InjectedBundleNodeHandleIsTextField webProcessPlugIn:didCreateBrowserContextController:]):
1846         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1847         (-[InjectedBundleNodeHandleIsTextFieldDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1848
1849 2018-05-09  Thibault Saunier  <tsaunier@igalia.com>
1850
1851         [tests][GStreamer]: Pass USE_PLAYBIN3 to the tests subprocess
1852         https://bugs.webkit.org/show_bug.cgi?id=185481
1853
1854         Reviewed by Philippe Normand.
1855
1856         [tests][GStreamer]: Pass USE_PLAYBIN3 to the tests subprocess
1857
1858         * Scripts/webkitpy/port/gtk.py:
1859         (GtkPort.setup_environ_for_server):
1860
1861 2018-05-09  Leo Balter  <leonardo.balter@gmail.com>
1862
1863         Set build.webkit.org to use the new Test262-runner
1864         https://bugs.webkit.org/show_bug.cgi?id=184933
1865
1866         Reviewed by Aakash Jain.
1867
1868         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1869         (RunTest262Tests):
1870         (RunTest262Tests.countFailures):
1871         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1872
1873 2018-05-09  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
1874
1875         [GTK][JHBuild] LLVM 3.7.0 build is broken with GCC 8.1
1876         https://bugs.webkit.org/show_bug.cgi?id=185461
1877
1878         Reviewed by Michael Catanzaro.
1879
1880         JHBuild now compiles LLVM 6 and Mesa 18.0.3.
1881
1882         * gtk/jhbuild.modules:
1883
1884 2018-05-09  Michael Catanzaro  <mcatanzaro@igalia.com>
1885
1886         Unreviewed. Update OptionsWPE.cmake and NEWS for 2.21.1 release.
1887
1888         * wpe/manifest.txt.in: Distribute the NEWS.
1889
1890 2018-05-09  Michael Catanzaro  <mcatanzaro@igalia.com>
1891
1892         [WPE] Build cleanly with GCC 8 and ICU 60
1893         https://bugs.webkit.org/show_bug.cgi?id=185462
1894
1895         Reviewed by Carlos Alberto Lopez Perez.
1896
1897         * TestWebKitAPI/CMakeLists.txt: Fix weird build failure, we were missing a directory. Not
1898         sure why this was never noticed until now or why the bots are OK.
1899         * gtk/jhbuild.modules: Add upstream patch to avoid warnings inside G_DEFINE_TYPE.
1900         * gtk/patches/glib-cast-function-type.patch: Added.
1901         * wpe/jhbuild.modules: Add upstream patch to avoid warnings inside G_DEFINE_TYPE.
1902         * wpe/patches/glib-cast-function-type.patch: Added.
1903
1904 2018-05-06  Yusuke Suzuki  <utatane.tea@gmail.com>
1905
1906         [JSC][GTK][JSCONLY] Use capstone disassembler
1907         https://bugs.webkit.org/show_bug.cgi?id=185283
1908
1909         Reviewed by Michael Catanzaro.
1910
1911         * gtk/manifest.txt.in:
1912         * wpe/manifest.txt.in:
1913
1914 2018-05-09  Antti Koivisto  <antti@apple.com>
1915
1916         Add OptionSet::operator& and operator bool
1917         https://bugs.webkit.org/show_bug.cgi?id=185306
1918
1919         Reviewed by Anders Carlsson.
1920
1921         * TestWebKitAPI/Tests/WTF/OptionSet.cpp:
1922         (TestWebKitAPI::TEST):
1923
1924 2018-05-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1925
1926         Consolidate WebContentReaderIOS and WebContentReaderMac into WebContentReaderCocoa
1927         https://bugs.webkit.org/show_bug.cgi?id=185340
1928
1929         Reviewed by Tim Horton.
1930
1931         Adds a new API test to verify that URLs written using -[NSPasteboard writeObjects:] are pasted as anchors with
1932         non-empty text in a contenteditable.
1933
1934         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
1935         (TestWebKitAPI::TEST):
1936
1937 2018-05-08  Valerie R Young  <valerie@bocoup.com>
1938
1939         test262/Runner.pm: create results dir for results of test262 run
1940         https://bugs.webkit.org/show_bug.cgi?id=185392
1941
1942         Reviewed by Michael Saboff.
1943
1944         New directory test262-results created from where ever script is
1945         called.
1946
1947         * Scripts/test262/Runner.pm:
1948         (processCLI):
1949
1950 2018-05-08  Valerie R Young  <valerie@bocoup.com>
1951
1952         test262/Runner.pm: lower number of processes per core
1953         https://bugs.webkit.org/show_bug.cgi?id=185426
1954
1955         Reviewed by Michael Saboff.
1956
1957         * Scripts/test262/Runner.pm:
1958         (getProcesses):
1959
1960 2018-05-08  Leo Balter  <leonardo.balter@gmail.com>
1961
1962         Test262-Runner: Add base Perl UnicodeData
1963         https://bugs.webkit.org/show_bug.cgi?id=185444
1964
1965         Reviewed by Michael Saboff.
1966
1967         * Scripts/test262/local/lib/perl5/unicore/lib/gc_sc/SpacePer.pl: Added.
1968         * Scripts/test262/local/lib/perl5/unicore/lib/gc_sc/Word.pl: Added.
1969
1970 2018-05-08  Daniel Bates  <dabates@apple.com>
1971
1972         Add tests to ensure that the Strong Password appearance is removed on form reset
1973         https://bugs.webkit.org/show_bug.cgi?id=185440
1974
1975         Reviewed by Ryosuke Niwa.
1976
1977         * TestWebKitAPI/Tests/WebKitCocoa/DidResignInputElementStrongPasswordAppearance.mm:
1978         (-[DidResignInputElementStrongPasswordAppearance webProcessPlugIn:didCreateBrowserContextController:]):
1979         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1980         (TEST):
1981
1982 2018-05-08  Daniel Bates  <dabates@apple.com>
1983
1984         Resign Strong Password appearance when text field value changes
1985         https://bugs.webkit.org/show_bug.cgi?id=185433
1986         <rdar://problem/39958508>
1987
1988         Reviewed by Ryosuke Niwa.
1989
1990         Add a unit test to ensure the injected bundle API and WebKit UI delegate SPI is invoked
1991         when the field has the Strong Password button and its value changes.
1992
1993         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1994         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
1995         (TEST):
1996
1997 2018-05-06  Filip Pizlo  <fpizlo@apple.com>
1998
1999         InPlaceAbstractState::beginBasicBlock shouldn't have to clear any abstract values
2000         https://bugs.webkit.org/show_bug.cgi?id=185365
2001
2002         Reviewed by Saam Barati.
2003         
2004         Make it possible to measure compile times.
2005         
2006         Rolling back in after fixing cloop builds.
2007
2008         * Scripts/run-jsc-benchmarks:
2009
2010 2018-05-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2011
2012         [iOS] WKAttachmentTestsIOS.InsertDroppedItemProvidersInOrder fails after r231396
2013         https://bugs.webkit.org/show_bug.cgi?id=185414
2014
2015         Reviewed by Tim Horton.
2016
2017         Adjust a test expectation to check that the resulting DOM contains an attachment element,
2018         anchor element, and another attachment element in that order. This ensures that the test
2019         still passes, even after the anchor element is followed by a line break.
2020
2021         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2022         (TestWebKitAPI::TEST):
2023
2024 2018-05-08  Commit Queue  <commit-queue@webkit.org>
2025
2026         Unreviewed, rolling out r231491.
2027         https://bugs.webkit.org/show_bug.cgi?id=185434
2028
2029         Setting the Created key on a cookie does not work yet, due a
2030         bug in CFNetwork (Requested by ggaren on #webkit).
2031
2032         Reverted changeset:
2033
2034         "[WKHTTPCookieStore getAllCookies] returns inconsistent
2035         creation time"
2036         https://bugs.webkit.org/show_bug.cgi?id=185041
2037         https://trac.webkit.org/changeset/231491
2038
2039 2018-05-08  Valerie R Young  <valerie@bocoup.com>
2040
2041         test262/Runner.pm: move input files to JSTests/test262
2042         https://bugs.webkit.org/show_bug.cgi?id=185389
2043
2044         Reviewed by Michael Saboff.
2045
2046         * Scripts/test262/Runner.pm:
2047         (processCLI):
2048
2049 2018-05-08  Chris Dumez  <cdumez@apple.com>
2050
2051         Unreviewed, simplify Speedometer fixes landed in r231489, r231483 & r231474.
2052
2053         * Scripts/webkitpy/performance_tests/perftest.py:
2054         (PerfTest):
2055
2056 2018-05-08  Ryan Haddad  <ryanhaddad@apple.com>
2057
2058         Unreviewed, rolling out r231468.
2059
2060         Broke the CLoop build
2061
2062         Reverted changeset:
2063
2064         "InPlaceAbstractState::beginBasicBlock shouldn't have to clear
2065         any abstract values"
2066         https://bugs.webkit.org/show_bug.cgi?id=185365
2067         https://trac.webkit.org/changeset/231468
2068
2069 2018-05-08  Sihui Liu  <sihui_liu@apple.com>
2070
2071         [WKHTTPCookieStore getAllCookies] returns inconsistent creation time
2072         https://bugs.webkit.org/show_bug.cgi?id=185041
2073         <rdar://problem/34684214>
2074
2075         Reviewed by Geoffrey Garen.
2076
2077         Add API test Coverage.
2078
2079         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2080         (TEST):
2081
2082 2018-05-08  Chris Dumez  <cdumez@apple.com>
2083
2084         Unreviewed, fix issue with running Speedometer PerfTest after r231450.
2085
2086         * Scripts/webkitpy/performance_tests/perftest.py:
2087         (PerfTest):
2088
2089 2018-05-08  Chris Dumez  <cdumez@apple.com>
2090
2091         Unreviewed, fix issue with running Speedometer PerfTest after r231450.
2092
2093         * Scripts/webkitpy/performance_tests/perftest.py:
2094         (PerfTest):
2095
2096 2018-05-07  Chris Dumez  <cdumez@apple.com>
2097
2098         Unreviewed, fix issue with running Speedometer PerfTest after r231450.
2099
2100         * Scripts/webkitpy/performance_tests/perftest.py:
2101         (PerfTest):
2102
2103 2018-05-06  Filip Pizlo  <fpizlo@apple.com>
2104
2105         InPlaceAbstractState::beginBasicBlock shouldn't have to clear any abstract values
2106         https://bugs.webkit.org/show_bug.cgi?id=185365
2107
2108         Reviewed by Saam Barati.
2109         
2110         Make it possible to measure compile times.
2111
2112         * Scripts/run-jsc-benchmarks:
2113
2114 2018-05-07  Leo Balter  <leonardo.balter@gmail.com>
2115
2116         Test262-Runner: Add base module to the local deps - unicore/Exact.pl
2117         https://bugs.webkit.org/show_bug.cgi?id=185390
2118
2119         Reviewed by Michael Saboff.
2120
2121         * Scripts/test262/local/lib/perl5/unicore/Exact.pl: Added.
2122
2123 2018-05-07  Jonathan Bedard  <jbedard@apple.com>
2124
2125         Check for com.apple.datamigrator before declaring simulators booted
2126         https://bugs.webkit.org/show_bug.cgi?id=185315
2127         <rdar://problem/39986261>
2128
2129         Reviewed by David Kilzer.
2130
2131         * Scripts/webkitdirs.pm:
2132         (waitUntilProcessNotRunning): Wait until a process is not found.
2133         (relaunchIOSSimulator): Wait until com.apple.datamigrator stops running to declare
2134         a simulator booted.
2135         * Scripts/webkitpy/common/system/executive_mock.py:
2136         (MockExecutive2.__init__): Define _running_pids.
2137         * Scripts/webkitpy/xcode/simulated_device.py:
2138         (SimulatedDeviceManager.initialize_devices): Call wait_until_data_migration_is_done before
2139         declaring that devices have been booted, increase the timeout since data migration will frequently
2140         take longer than 60 seconds, especially with multiple simulators booting.
2141         (SimulatedDeviceManager.swap): Ditto.
2142         (SimulatedDeviceManager):
2143         (SimulatedDeviceManager.wait_until_data_migration_is_done): Wait until there are no com.apple.datamigrator
2144         processes running.
2145
2146 2018-05-07  Daniel Bates  <dabates@apple.com>
2147
2148         REGRESSION (r229955): run-webkit-tests runs tests in skipped directories and subdirectories of directory given on command line
2149         https://bugs.webkit.org/show_bug.cgi?id=185054
2150         <rdar://problem/39773209>
2151
2152         Reviewed by Ryosuke Niwa.
2153
2154         Fallback to MacPort.CURRENT_VERSION if we are not using a known named macOS and do not have Apple Additions.
2155
2156         Darwin-based ports have OS version-specific test expectations and are certified to support running tests using
2157         the currently shipping OS by way of a hardcoded class variable CURRENT_VERSION. The run-webkit-tests script
2158         depends on the OS version to find the applicable TestExpectations files to parse to compute the list of skipped
2159         tests for the port.
2160
2161         * Scripts/webkitpy/port/mac.py:
2162         (MacPort.__init__): Fall back to MacPort.CURRENT_VERSION if we are not using a known named macOS and do not
2163         have Apple Additions.
2164         * Scripts/webkitpy/port/mac_unittest.py:
2165         (MacTest.test_factory_with_future_version): Added.
2166         (MacTest.test_factory_with_future_version_and_apple_additions): Renamed from MacTest.test_factory_with_future_version()
2167         and added code to use the mock Apple Additions so that running this code with- and without- the real Apple Additions
2168         produces consistent results now that the Mac port's OS version falls back to MacPort.CURRENT_VERSION when Apple Additions
2169         is absent.
2170
2171 2018-05-07  Brian Burg  <bburg@apple.com>
2172
2173         Web Inspector: opt out of process swap on navigation if a Web Inspector frontend is connected
2174         https://bugs.webkit.org/show_bug.cgi?id=184861
2175         <rdar://problem/39153768>
2176
2177         Reviewed by Timothy Hatcher.
2178
2179         Add a new test that checks whether a new process is used for navigation when
2180         an Inspector is shown. Also check that the behavior reverts to normal after
2181         the Inspector has been closed.
2182
2183         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2184
2185 2018-05-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2186
2187         [iOS] Multiple links in Mail are dropped in a single line, and are difficult to tell apart
2188         https://bugs.webkit.org/show_bug.cgi?id=185289
2189         <rdar://problem/35756912>
2190
2191         Reviewed by Tim Horton and Darin Adler.
2192
2193         Augment and rebaseline some iOS drag-and-drop API tests that handle dropping URLs as a part of multi-item drop
2194         sessions.
2195
2196         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2197         (TestWebKitAPI::TEST):
2198
2199 2018-05-04  Timothy Hatcher  <timothy@apple.com>
2200
2201         Deprecate legacy WebView and friends
2202         https://bugs.webkit.org/show_bug.cgi?id=185279
2203         rdar://problem/33268700
2204
2205         Reviewed by Tim Horton.
2206
2207         * MiniBrowser/Configurations/Base.xcconfig: Added GCC_PREPROCESSOR_DEFINITIONS
2208         to define DISABLE_LEGACY_WEBKIT_DEPRECATIONS.
2209
2210 2018-05-04  Leo Balter  <leonardo.balter@gmail.com>
2211
2212         Test262-Runner: Add base module to the local deps - unicore/PVA.pl
2213         https://bugs.webkit.org/show_bug.cgi?id=185314
2214
2215         Reviewed by Michael Saboff.
2216
2217         * Scripts/test262/local/lib/perl5/unicore/PVA.pl: Added.
2218
2219 2018-05-04  Wenson Hsieh  <whsieh@berkeley.edu>
2220
2221         REGRESSION: [ios-simulator] 3 WKWebViewAutofillTests API test failures seen with 11.3 SDK
2222         https://bugs.webkit.org/show_bug.cgi?id=184196
2223         <rdar://problem/39054481>
2224
2225         Reviewed by Tim Horton.
2226
2227         Removes some unnecessary workarounds to enable running app autofill tests against iOS versions
2228         earlier than 11.3. Also re-enables these tests.
2229
2230         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2231         (TestWebKitAPI::TEST):
2232         (-[UITextAutofillSuggestion initWithUsername:password:]): Deleted.
2233         (+[UITextAutofillSuggestion autofillSuggestionWithUsername:password:]): Deleted.
2234
2235 2018-05-04  Myles C. Maxfield  <mmaxfield@apple.com>
2236
2237         Text shaping in the simple path is flipped in the y direction
2238         https://bugs.webkit.org/show_bug.cgi?id=185062
2239         <rdar://problem/39778678>
2240
2241         Reviewed by Simon Fraser.
2242
2243         Huge thanks to Ulrike Rausch of LiebeFonts for contributing the test fonts!!!
2244
2245         * Scripts/webkitpy/common/config/contributors.json:
2246
2247 2018-05-04  Leo Balter  <leonardo.balter@gmail.com>
2248
2249         Test262-Runner: place the processCLI inside the main call
2250         https://bugs.webkit.org/show_bug.cgi?id=185304
2251
2252         Reviewed by Michael Saboff.
2253
2254         * Scripts/test262/Runner.pm:
2255         (main):
2256
2257 2018-05-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2258
2259         [GTK] Epiphany (GNOME Web) says "Error downloading: Service Unavailable." when trying to download an image from discogs.com
2260         https://bugs.webkit.org/show_bug.cgi?id=174730
2261
2262         Reviewed by Michael Catanzaro.
2263
2264         Update unit tests to check that User-Agent header is included in HTTP download requests.
2265
2266         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
2267         (testDownloadRemoteFile):
2268         (testWebViewDownloadURI):
2269         (testPolicyResponseDownload):
2270         (testPolicyResponseDownloadCancel):
2271         (testDownloadMIMEType):
2272         (testContextMenuDownloadActions):
2273
2274 2018-05-03  Ross Kirsling  <ross.kirsling@sony.com>
2275
2276         [WinCairo] Test archive must use Python zipfile, just like build product.
2277         https://bugs.webkit.org/show_bug.cgi?id=185265
2278
2279         Reviewed by Per Arne Vollan.
2280
2281         * BuildSlaveSupport/test-result-archive:
2282         (archive_test_results):
2283         Copy over Win32-oriented archiving logic from built-product-archive.
2284
2285 2018-05-03  Leo Balter  <leonardo.balter@gmail.com>
2286
2287         cleanup modules usage for the Test262-Runner
2288         https://bugs.webkit.org/show_bug.cgi?id=185263
2289
2290         Reviewed by Michael Saboff.
2291
2292         * Scripts/test262-runner:
2293         * Scripts/test262/Runner.pm:
2294         (processCLI):
2295
2296 2018-05-03  Valerie R Young  <valerie@bocoup.com>
2297
2298         test262/Runner.pm: minor fixes
2299         https://bugs.webkit.org/show_bug.cgi?id=185250
2300
2301         Reviewed by Michael Saboff.
2302
2303         Add comments, change output and fix bug: unintended interpolation
2304         of filename when running jsc.
2305
2306         * Scripts/test262/Runner.pm:
2307         (processCLI):
2308         (main):
2309         (runTest):
2310
2311 2018-05-03  Chris Dumez  <cdumez@apple.com>
2312
2313         Load hangs if the WebProcess fails to launch
2314         https://bugs.webkit.org/show_bug.cgi?id=185225
2315         <rdar://problem/38249058>
2316
2317         Reviewed by Geoff Garen.
2318
2319         Add API test coverage.
2320
2321         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2322         * TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm: Added.
2323         (-[CrashOnStartNavigationDelegate _webView:webContentProcessDidTerminateWithReason:]):
2324         (-[CrashOnStartNavigationDelegate webView:didFinishNavigation:]):
2325         (-[CrashRecoveryScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2326         (TEST):
2327
2328 2018-05-03  Don Olmstead  <don.olmstead@sony.com>
2329
2330         [WinCairo] Add JSC test bots
2331         https://bugs.webkit.org/show_bug.cgi?id=185234
2332
2333         Reviewed by Per Arne Vollan.
2334
2335         * BuildSlaveSupport/build.webkit.org-config/config.json:
2336         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2337         (RunJavaScriptCoreTests.start):
2338
2339 2018-05-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2340
2341         WebKit should send fake macOS user agent to docs.google.com
2342         https://bugs.webkit.org/show_bug.cgi?id=185165
2343
2344         Reviewed by Carlos Garcia Campos.
2345
2346         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2347         (TestWebKitAPI::TEST):
2348
2349 2018-05-03  Valerie R Young  <valerie@bocoup.com>
2350
2351         test262/Runner.pm: performance improvements
2352         https://bugs.webkit.org/show_bug.cgi?id=185202
2353
2354         Reviewed by Michael Saboff.
2355
2356         Batch the tests by the number of processes, and give each process
2357         a file to save results to to avoid threading. Do not parallelize
2358         when running small sets of tests.
2359
2360         * Scripts/test262/Runner.pm:
2361         (processCLI):
2362         (main):
2363         (processFile):
2364         (processResult):
2365
2366 2018-05-03  Ryan Haddad  <ryanhaddad@apple.com>
2367
2368         Unreviewed, rolling out r231253.
2369
2370         The API test added with this change is crashing on the bots.
2371
2372         Reverted changeset:
2373
2374         "Web Inspector: opt out of process swap on navigation if a Web
2375         Inspector frontend is connected"
2376         https://bugs.webkit.org/show_bug.cgi?id=184861
2377         https://trac.webkit.org/changeset/231253
2378
2379 2018-05-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2380
2381         REGRESSION(r222772): [GTK][WPE] WebProcess from WebKitGtk+ 2.19.9x SIGSEVs in WebKit::WebProcess::ensureNetworkProcessConnection() at Source/WebKit/WebProcess/WebProcess.cpp:1127
2382         https://bugs.webkit.org/show_bug.cgi?id=183348
2383
2384         Reviewed by Michael Catanzaro.
2385
2386         Add a test case to reproduce the crash.
2387
2388         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2389         (testWebViewCloseQuickly):
2390         (beforeAll):
2391
2392 2018-05-02  Aditya Keerthi  <akeerthi@apple.com>
2393
2394         Can't copy and paste URLs that have no title into Mail (macOS)
2395         https://bugs.webkit.org/show_bug.cgi?id=185205
2396         <rdar://problem/36352406>
2397
2398         Reviewed by Tim Horton.
2399
2400         Added test to verify behavior when copying and pasting a URL without a title.
2401
2402         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html:
2403         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
2404         (TestWebKitAPI::TEST):
2405
2406 2018-05-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2407
2408         [GTK] Generate a JSC bundle on the 64 and 32 bit release bots and upload it to webkitgtk.org (follow-up fix)
2409         https://bugs.webkit.org/show_bug.cgi?id=184699
2410
2411         Unreviewed follow-up fix after r231230.
2412
2413         * Scripts/generate-jsc-bundle:
2414         (generate_wrapper_script): Quote the arguments passed to jsc.
2415
2416 2018-05-02  Brian Burg  <bburg@apple.com>
2417
2418         Web Inspector: opt out of process swap on navigation if a Web Inspector frontend is connected
2419         https://bugs.webkit.org/show_bug.cgi?id=184861
2420         <rdar://problem/39153768>
2421
2422         Reviewed by Ryosuke Niwa.
2423
2424         Add a new test that checks whether a new process is used for navigation when
2425         an Inspector is shown. Also check that the behavior reverts to normal after
2426         the Inspector has been closed.
2427
2428         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2429
2430 2018-05-02  Valerie R Young  <valerie@bocoup.com>
2431
2432         test262/Runner.pm: save summary to file
2433         https://bugs.webkit.org/show_bug.cgi?id=185200
2434
2435         Reviewed by Michael Saboff.
2436
2437         * Scripts/test262/Runner.pm:
2438         (processCLI):
2439         (main):
2440         (summarizeResults):
2441
2442 2018-05-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2443
2444         [GTK] Generate a JSC bundle on the 64 and 32 bit release bots and upload it to webkitgtk.org
2445         https://bugs.webkit.org/show_bug.cgi?id=184699
2446
2447         Reviewed by Gustavo Noronha Silva.
2448
2449         This adds a new step for the GTK 64-bit release build bot and the
2450         GTK 32-bit release build&test bot.
2451
2452         This step will be run as one of the lasts ones (after the product
2453         is built) and will execute the script generate-jsc-bundle.
2454         This script will take care of creating a JSC bundle and uploading
2455         it to a server defined on a configuration file that has to be
2456         deployed on the bots with the required server data and credentials
2457         for this upload.
2458
2459         In this case, the built products should then be accessible at
2460         <https://webkitgtk.org/jsc-built-products>. But the implementation
2461         is not tied to any specific server. All the details about where
2462         to upload the file is done in configuration file that is kept
2463         private on each bot outside of the WebKit source tree.
2464
2465         The script also supports generating a JSC bundle locally and not
2466         uploading it anywhere. This is the default mode of running.
2467         The remote upload will only be activated if a --remote-config-file
2468         parameter is passed (which is done from the buildbot config)
2469
2470         * BuildSlaveSupport/build.webkit.org-config/config.json:
2471         * BuildSlaveSupport/build.webkit.org-config/factories.py:
2472         (BuildFactory):
2473         (BuildFactory.__init__):
2474         (TestFactory):
2475         (TestFactory.__init__):
2476         (BuildAndGenerateJSCBundleFactory):
2477         (BuildAndNonLayoutTestAndGenerateJSCBundleFactory):
2478         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2479         (GenerateJSCBundle):
2480         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2481         * Scripts/generate-jsc-bundle: Added.
2482         (ldd_get_libs_and_interpreter):
2483         (generate_readme):
2484         (generate_wrapper_script):
2485         (copy_and_remove_rpath):
2486         (createJSCBundle):
2487         (sha256sum):
2488         (uploadJSCBundle):
2489         (main):
2490
2491 2018-05-01  Ryosuke Niwa  <rniwa@webkit.org>
2492
2493         PSON: Make WebKitTestRunner work with process swap on navigation turned on
2494         https://bugs.webkit.org/show_bug.cgi?id=185111
2495
2496         Reviewed by Chris Dumez.
2497
2498         Add the basic support for running layout tests with process-swap-on-navigation turned on.
2499
2500         First, move m_whatToDump, m_dumpPixels, m_waitToDump, and m_dumpFrameLoadCallbacks from WebContent process
2501         to UI process so that calls to waitUntilDone, dumpAsText, etc... persist across process swaps.
2502
2503         In addition, initialize the injected bundle inside a new WebContent process when the first page is created.
2504         This instantiates objects such as TestRunner, GCController, etc... in the new process. The initialization
2505         can't be done in InjectedBundle::beginTesting because some steps in InjectedBundle::initialize require
2506         the current PageGroup and Page objects. We avoid clearing databases and app cache in this case.
2507
2508         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2509         (WTR::InjectedBundle::didCreatePage): Send "Initialization" message to UI process. This message returns
2510         all the dictionary values usually present in "BeginTest" message from UI process as well as "ResumeTesting"
2511         boolean which is set when this process was created as a result of a process swap on navgation. Invoke
2512         beginTesting with BegingTestingMode::Resume when this boolean is set.
2513         (WTR::InjectedBundle::didReceiveMessageToPage):
2514         (WTR::InjectedBundle::beginTesting): Don't clear database, app cache, etc... when initializing an injected
2515         bundle after a process swap on navigation.
2516         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2517         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2518         (WTR::InjectedBundlePage::dump):
2519         (WTR::InjectedBundlePage::frameDidChangeLocation):
2520         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2521         (WTR::TestRunner::TestRunner):
2522         (WTR::TestRunner::shouldDumpPixels const): Added.
2523         (WTR::TestRunner::setDumpPixels): Added.
2524         (WTR::TestRunner::dumpAsText):
2525         (WTR::TestRunner::whatToDump const): Added.
2526         (WTR::TestRunner::setWhatToDump): Added.
2527         (WTR::TestRunner::waitUntilDone):
2528         (WTR::TestRunner::setWaitUntilDone): Added.
2529         (WTR::TestRunner::shouldWaitUntilDone): Added.
2530         (WTR::TestRunner::notifyDone):
2531         (WTR::TestRunner::forceImmediateCompletion):
2532         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks): Added.
2533         (WTR::TestRunner::shouldDumpFrameLoadCallbacks): Added.
2534         (WTR::TestRunner::setAudioResult):
2535         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2536         (WTR::TestRunner::dumpChildFramesAsText):
2537         (WTR::TestRunner::dumpDOMAsWebArchive):
2538         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks): Moved to cpp.
2539         (WTR::TestRunner::whatToDump const): Moved to cpp.
2540         (WTR::TestRunner::shouldDumpMainFrameScrollPosition const):
2541         (WTR::TestRunner::shouldDumpPixels const): Moved to cpp.
2542         (WTR::TestRunner::shouldDumpFrameLoadCallbacks const): Moved to cpp.
2543         (WTR::TestRunner::waitToDump const): Renamed to shouldWaitUntilDone and moved to cpp.
2544         * WebKitTestRunner/TestInvocation.cpp:
2545         (WTR::TestInvocation::TestInvocation): Initialize m_dumpFrameLoadCallbacks here.
2546         (WTR::TestInvocation::shouldLogFrameLoadDelegates const): Deleted.
2547         (WTR::TestInvocation::createTestSettingsDictionary): Extracted from invoke().
2548         (WTR::TestInvocation::invoke): Sets m_startedTesting to true immediately afte sending "BeginTest" message.
2549         m_startedTesting is later used in didReceiveSynchronousMessageFromInjectedBundle to detect whether a given
2550         "Initialization" message is sent from a regular WebContent process (m_startedTesting is false) or the one
2551         started as a result of a process swap on navigation (m_startedTesting is true).
2552         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): Added a bunch of new messgaes to
2553         support initializing the injected bundle in a process swapped after navigation and set/get messages for
2554         the states which must persist across process swaps within a test.
2555         * WebKitTestRunner/TestInvocation.h:
2556         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2557         * Tools/WebKitTestRunner/WhatToDump.h:
2558         (WTR::WhatToDump): Added.
2559
2560 2018-05-01  Leo Balter  <leonardo.balter@gmail.com>
2561
2562         Auto save the results for Test262
2563         https://bugs.webkit.org/show_bug.cgi?id=184926
2564
2565         Reviewed by Michael Saboff.
2566
2567         * Scripts/test262/Runner.pm:
2568         (processCLI):
2569         (main):
2570         (parseError):
2571         (processResult):
2572         (summarizeResults):
2573         * Scripts/test262/config.yaml: Renamed from Tools/Scripts/test262/test262-config.yaml.
2574
2575 2018-05-01  Jonathan Bedard  <jbedard@apple.com>
2576
2577         webkitpy: SIGKILL right after SIGTERM causes orphaned processes with 'xcrun simctl spawn'
2578         https://bugs.webkit.org/show_bug.cgi?id=185164
2579
2580         Reviewed by David Kilzer.
2581
2582         * Scripts/webkitpy/common/system/executive.py:
2583         (Executive.kill_process): First attempt will always send a SIGTERM, all subsequent attempts will
2584         send a SIGKILL. A SIGKILL with not be sent if the process is not running to avoid orphaning childen.
2585
2586 2018-05-01  Chris Dumez  <cdumez@apple.com>
2587
2588         REGRESSION (r230919): API test WebKit.AutoLayoutIntegration is a flaky failure
2589         https://bugs.webkit.org/show_bug.cgi?id=184918
2590         <rdar://problem/39705516>
2591
2592         Reviewed by Wenson Hsieh.
2593
2594         Make sure provisional load has started before calling beginLayoutAtMinimumWidth
2595         on the AutoLayoutWKWebView to restore pre-r230919 behavior. The load now starts
2596         asynchronously because we ask the client if it is OK to do the load and the policy
2597         delegates are asynchronous nowadays.
2598
2599         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
2600         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]):
2601         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
2602         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2603         (-[TestNavigationDelegate webView:didStartProvisionalNavigation:]):
2604         (-[TestNavigationDelegate waitForDidStartProvisionalNavigation]):
2605         (-[WKWebView _test_waitForDidStartProvisionalNavigation]):
2606
2607 2018-05-01  Ross Kirsling  <ross.kirsling@sony.com>
2608
2609         [WinCairo] Align buildbot test stages with AppleWin.
2610         https://bugs.webkit.org/show_bug.cgi?id=185094
2611
2612         Reviewed by Brent Fulgham.
2613
2614         * BuildSlaveSupport/build.webkit.org-config/factories.py:
2615         (TestFactory.__init__):
2616         Do run API tests, don't run dashboard tests.
2617
2618         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2619         (RunUnitTests):
2620         Call run-api-tests with Python, not Perl (bugfix for r230998).
2621
2622         * Scripts/webkitpy/port/win.py:
2623         (WinPort.environment_for_api_tests):
2624         Retrieve necessary Windows environment variables.
2625
2626 2018-05-01  Eric Carlson  <eric.carlson@apple.com>
2627
2628         [MediaStream] remove WK1 support
2629         https://bugs.webkit.org/show_bug.cgi?id=185136
2630
2631         Reviewed by Youenn Fablet.
2632
2633         * DumpRenderTree/mac/UIDelegate.mm:
2634         (-[UIDelegate webView:decidePolicyForUserMediaRequestFromOrigin:listener:]): Deleted.
2635
2636 2018-05-01  Chris Dumez  <cdumez@apple.com>
2637
2638         [WKTR] Move navigation policy for response decision from InjectedBundle to UIProcess
2639         https://bugs.webkit.org/show_bug.cgi?id=185157
2640
2641         Reviewed by Geoffrey Garen.
2642
2643         Move navigation policy for response decision from InjectedBundle to UIProcess. This is a more
2644         common configuration and should therefore be the configuration we test by default.
2645
2646         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2647         (WTR::InjectedBundlePage::decidePolicyForResponse):
2648
2649 2018-05-01  Oleksandr Skachkov  <gskachkov@gmail.com>
2650
2651         WebAssembly: add support for stream APIs - JavaScript API
2652         https://bugs.webkit.org/show_bug.cgi?id=183442
2653
2654         Reviewed by Yusuke Suzuki and JF Bastien.
2655
2656         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2657
2658 2018-04-30  Mark Lam  <mark.lam@apple.com>
2659
2660         Apply PtrTags to the MetaAllocator and friends.
2661         https://bugs.webkit.org/show_bug.cgi?id=185110
2662         <rdar://problem/39533895>
2663
2664         Reviewed by Saam Barati.
2665
2666         Update the test to match MetaAllocator changes in WTF.
2667
2668         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
2669         (TestWebKitAPI::TEST_F):
2670         (WTF::tagForPtr):
2671         (WTF::ptrTagName):
2672
2673 2018-04-30  Alex Christensen  <achristensen@webkit.org>
2674
2675         Add WKUIDelegatePrivate equivalent of WKPageContextMenuClient getContextMenuFromProposedMenuAsync
2676         https://bugs.webkit.org/show_bug.cgi?id=180955
2677
2678         Reviewed by Andy Estes.
2679
2680         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuImgWithVideo.mm:
2681         (-[ContextMenuImgWithVideoDelegate _webView:contextMenu:forElement:]):
2682         (-[ContextMenuImgWithVideoDelegate _webView:getContextMenuFromProposedMenu:forElement:userInfo:completionHandler:]):
2683
2684 2018-04-30  JF Bastien  <jfbastien@apple.com>
2685
2686         Use some C++17 features
2687         https://bugs.webkit.org/show_bug.cgi?id=185135
2688
2689         Reviewed by Alex Christensen.
2690
2691         * DumpRenderTree/PlatformMac.cmake:
2692         * gtk/ycm_extra_conf.py:
2693         (FlagsForFile):
2694
2695 2018-04-30  Yusuke Suzuki  <utatane.tea@gmail.com>
2696
2697         Use WordLock instead of std::mutex for Threading
2698         https://bugs.webkit.org/show_bug.cgi?id=185121
2699
2700         Reviewed by Geoffrey Garen.
2701
2702         * TestWebKitAPI/Tests/WTF/Signals.cpp:
2703         (TEST):
2704
2705 2018-04-30  Michael Catanzaro  <mcatanzaro@igalia.com>
2706
2707         [GTK] Webkit should spoof as Safari on a Mac when on Chase.com
2708         https://bugs.webkit.org/show_bug.cgi?id=185103
2709
2710         Reviewed by Carlos Garcia Campos.
2711
2712         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2713         (TestWebKitAPI::TEST):
2714
2715 2018-04-28  Sihui Liu  <sihui_liu@apple.com>
2716
2717         [Cocoa] Set HTTPOnly flag when converting Cookie to NSHTTPCookie
2718         https://bugs.webkit.org/show_bug.cgi?id=185052
2719
2720         Reviewed by Geoffrey Garen.
2721
2722         Modified API test to provide correct test cases for HTTPOnly flag.
2723
2724         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2725         (TEST):
2726
2727 2018-04-28  Rick Waldron  <waldron.rick@gmail.com>
2728
2729         Token misspelled "tocken" in error message string
2730         https://bugs.webkit.org/show_bug.cgi?id=185030
2731
2732         Reviewed by Saam Barati.
2733
2734         * Scripts/test262/test262-expectations.yaml: Fix typo "tocken" => "token"
2735
2736 2018-04-27  Stephan Szabo  <stephan.szabo@sony.com>
2737
2738         [WinCairo] Support --no-copy for jsc tests in wincairo tests, add copying of dlls for copy case
2739         https://bugs.webkit.org/show_bug.cgi?id=185049
2740
2741         Reviewed by Keith Miller.
2742
2743         * Scripts/run-javascriptcore-tests:
2744         (runJSCStressTests):
2745         * Scripts/run-jsc-stress-tests:
2746
2747 2018-04-26  Ryosuke Niwa  <rniwa@webkit.org>
2748
2749         PSON: Triggering a navigation to an invalid URL creates a new WebContent process
2750         https://bugs.webkit.org/show_bug.cgi?id=185066
2751
2752         Reviewed by Youenn Fablet.
2753
2754         Added a new test case (ProcessSwap.NavigateToInvalidURL) for navigating to an invalid URL.
2755         WebKit should not swap WebContent process in this case.
2756
2757         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2758         (-[PSONNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2759         (-[PSONUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2760
2761 2018-04-27  Nan Wang  <n_wang@apple.com>
2762
2763         AX: Accessibility needs to know which part of the content view is visible on iOS
2764         https://bugs.webkit.org/show_bug.cgi?id=185085
2765         <rdar://problem/39801363>
2766
2767         Reviewed by Chris Fleizach.
2768
2769         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2770         (WTR::AccessibilityUIElement::stringAttributeValue):
2771
2772 2018-04-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2773
2774         [Extra zoom mode] Add a mechanism to override default viewport behaviors in extra zoom mode
2775         https://bugs.webkit.org/show_bug.cgi?id=185050
2776         <rdar://problem/39624038>
2777
2778         Reviewed by Tim Horton.
2779
2780         Remove a test that's no longer useful, now that the SPI it was testing is gone. This functionality is now
2781         tested by the layout test added in this patch.
2782
2783         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2784         * TestWebKitAPI/Tests/ios/ViewportSizingTests.mm: Removed.
2785
2786 2018-04-26  Ryan Haddad  <ryanhaddad@apple.com>
2787
2788         REGRESSION (r231039): RunUnitTests step reports disabled tests as failures
2789         https://bugs.webkit.org/show_bug.cgi?id=185061
2790
2791         Reviewed by Aakash Jain.
2792
2793         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2794         (RunUnitTests.countFailures): Return the difference between the total number of tests run and the number that passed.
2795         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Add a test.
2796
2797 2018-04-26  Ross Kirsling  <ross.kirsling@sony.com>
2798
2799         Add release bots for WinCairo.
2800         https://bugs.webkit.org/show_bug.cgi?id=185042
2801
2802         Reviewed by Lucas Forschler.
2803
2804         * BuildSlaveSupport/build.webkit.org-config/config.json:
2805         Add a release build bot and two test bots, replacing the outdated WinCairo release bots.
2806
2807 2018-04-26  Sihui Liu  <sihui_liu@apple.com>
2808
2809         -[WKHTTPCookieStore deleteCookie:completionHandler:] doesn't delete cookies
2810         https://bugs.webkit.org/show_bug.cgi?id=184938
2811         <rdar://problem/34737395>
2812
2813         Reviewed by Geoffrey Garen.
2814
2815         Add API test coverage.
2816
2817         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2818         (TEST):
2819
2820 2018-04-26  Ross Kirsling  <ross.kirsling@sony.com>
2821
2822         WinCairo test bots should run JSC tests with options for Windows command prompt.
2823         https://bugs.webkit.org/show_bug.cgi?id=185019
2824
2825         Reviewed by Per Arne Vollan.
2826
2827         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2828         (RunJavaScriptCoreTests.start):
2829
2830 2018-04-26  Ross Kirsling  <ross.kirsling@sony.com>
2831
2832         WinCairo WKL Debug Test bot is not using DRT.
2833         https://bugs.webkit.org/show_bug.cgi?id=185009
2834
2835         Reviewed by Per Arne Vollan.
2836
2837         * BuildSlaveSupport/build.webkit.org-config/config.json:
2838
2839 2018-04-26  Per Arne Vollan  <pvollan@apple.com>
2840
2841         Disable content filtering in minimal simulator mode
2842         https://bugs.webkit.org/show_bug.cgi?id=185027
2843         <rdar://problem/39736091>
2844
2845         Reviewed by Jer Noble.
2846
2847         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2848
2849 2018-04-26  Brady Eidson  <beidson@apple.com>
2850
2851         Add a setting for keeping around all processes and always reusing them per-origin.
2852         <rdar://problem/39695798> and https://bugs.webkit.org/show_bug.cgi?id=185020
2853
2854         Reviewed by Andy Estes.
2855
2856         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2857
2858 2018-04-26  Andy VanWagoner  <thetalecrafter@gmail.com>
2859
2860         [INTL] Implement Intl.PluralRules
2861         https://bugs.webkit.org/show_bug.cgi?id=184312
2862
2863         Reviewed by JF Bastien.
2864
2865         Added Intl.PluralRules feature flag.
2866
2867         * Scripts/webkitperl/FeatureList.pm:
2868         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2869
2870 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
2871
2872         [WPE] Build and link against latest WPEBackend and WPEBackend-fdo
2873         https://bugs.webkit.org/show_bug.cgi?id=184643
2874
2875         Reviewed by Žan Doberšek.
2876
2877         Add missing INCLUDE_DIRS in many places.
2878
2879         Adapt to single-header WPE includes.
2880
2881         Null-initialize padding to silence -Wmissing-field-initializers. (Yuck.)
2882
2883         * TestWebKitAPI/PlatformWPE.cmake:
2884         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2885         (testWebViewWebBackend):
2886         * TestWebKitAPI/glib/PlatformWPE.cmake:
2887         * WebKitTestRunner/EventSenderProxy.h:
2888         * WebKitTestRunner/PlatformWPE.cmake:
2889         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2890         * wpe/HeadlessViewBackend/CMakeLists.txt:
2891         * wpe/HeadlessViewBackend/HeadlessViewBackend.cpp:
2892         * wpe/HeadlessViewBackend/HeadlessViewBackend.h:
2893         * wpe/jhbuild.modules:
2894
2895 2018-04-25  Jonathan Bedard  <jbedard@apple.com>
2896
2897         REGRESSION (r230998): Bot watcher's dashboard doesn't display number of API test failures
2898         https://bugs.webkit.org/show_bug.cgi?id=184982
2899
2900         Rubber-stamped by Aakash Jain.
2901
2902         Correctly count the number of API test failures.
2903
2904         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2905         (RunUnitTests.countFailures): Count the number of test failures for the new run-api-tests.
2906         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2907         * Scripts/webkitpy/api_tests/manager.py:
2908         (Manager.run): Disabled tests are not run.
2909
2910 2018-04-25  Jiewen Tan  <jiewen_tan@apple.com>
2911
2912         Remove access to keychain from the WebContent process
2913         https://bugs.webkit.org/show_bug.cgi?id=184428
2914         <rdar://problem/13150903>
2915
2916         Reviewed by Brent Fulgham.
2917
2918         This patch does the followings:
2919         1. Added an API test for this patch.
2920         2. Instrument DumpRenderTree and WebKitTestRunner to take advantages of new SPIs.
2921
2922         * DumpRenderTree/mac/UIDelegate.mm:
2923         (-[UIDelegate signedPublicKeyAndChallengeStringForWebView:]):
2924         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2925         * TestWebKitAPI/Tests/mac/SSLKeyGenerator.mm: Added.
2926         (TestWebKitAPI::SSLKeyGeneratorTest::SetUp):
2927         (TestWebKitAPI::SSLKeyGeneratorTest::TearDown):
2928         (TestWebKitAPI::TEST_F):
2929         * WebKitTestRunner/TestController.cpp:
2930         (WTR::copySignedPublicKeyAndChallengeString):
2931         (WTR::TestController::createOtherPage):
2932         (WTR::TestController::createWebViewWithOptions):
2933
2934 2018-04-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2935
2936         [Extra zoom mode] The search field on www.bing.com is missing label text
2937         https://bugs.webkit.org/show_bug.cgi?id=184975
2938         <rdar://problem/39723081>
2939
2940         Reviewed by Tim Horton.
2941
2942         Adds UIScriptController.formInputLabel, which asynchronously requests the input label text for the currently
2943         focused element in extra zoom mode.
2944
2945         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2946         (WTR::UIScriptController::formInputLabel const):
2947         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2948         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2949         (WTR::UIScriptController::formInputLabel const):
2950         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2951         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2952         (WTR::UIScriptController::formInputLabel const):
2953
2954 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
2955
2956         [WPE] Should load injected bundle from builddir in developer builds
2957         https://bugs.webkit.org/show_bug.cgi?id=184983
2958
2959         Reviewed by Carlos Alberto Lopez Perez.
2960
2961         Set WEBKIT_INJECTED_BUNDLE_PATH when running WPE MiniBrowser.
2962
2963         * Scripts/run-minibrowser:
2964
2965 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
2966
2967         [WPE] libgstggtk.so broken in jhbuild environment
2968         https://bugs.webkit.org/show_bug.cgi?id=184984
2969
2970         Reviewed by Carlos Alberto Lopez Perez.
2971
2972         Don't pass --enable-glx=no when building libepoxy, to ensure it's compatible with
2973         gst-plugins-good.
2974
2975         * wpe/jhbuild.modules:
2976
2977 2018-04-25  Ryosuke Niwa  <rniwa@webkit.org>
2978
2979         PSON: Don't create a new process when navigating to a blob URL, data URL, and about:blank
2980         https://bugs.webkit.org/show_bug.cgi?id=184962
2981
2982         Reviewed by Youenn Fablet.
2983
2984         Added four test cases for navigating to a blob URL, data URL, and about:blank with process-swap-on-navigation turned on.
2985
2986         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2987         (ProcessSwap.SameOriginBlobNavigation): Added.
2988         (ProcessSwap.CrossOriginBlobNavigation): Added.
2989         (ProcessSwap.NavigateToAboutBlank): Added.
2990         (ProcessSwap.NavigateToDataURL): Added.
2991
2992 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
2993
2994         [WPE] Remove deprecated functions and properties from the API
2995         https://bugs.webkit.org/show_bug.cgi?id=179295
2996
2997         Reviewed by Žan Doberšek.
2998
2999         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
3000         (testWebViewAuthenticationStorage): Disable this test for now. It will require some effort
3001         to rewrite LoadTrackingTest to not require the web view at construction time.
3002         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3003         (testWebKitSettings): Don't test private browsing setting, which is gone.
3004         * TestWebKitAPI/glib/CMakeLists.txt: Disable TestCookieManager for now.
3005
3006 2018-04-25  Andy Estes  <aestes@apple.com>
3007
3008         [Mac] Number of drop items is always 0 when performing a DHTML drag
3009         https://bugs.webkit.org/show_bug.cgi?id=184943
3010
3011         Reviewed by Ryosuke Niwa.
3012
3013         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3014         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:
3015         (-[DragInfo numberOfValidItemsForDrop]):
3016         (-[DragInfo setNumberOfValidItemsForDrop:]):
3017         (TestWebKitAPI::TEST):
3018         * TestWebKitAPI/Tests/mac/full-page-dropzone.html: Added.
3019
3020 2018-04-25  Jonathan Bedard  <jbedard@apple.com>
3021
3022         API test harness should be Python
3023         https://bugs.webkit.org/show_bug.cgi?id=181043
3024         <rdar://problem/36164410>
3025
3026         Reviewed by David Kilzer.
3027
3028         Run API tests from a Python script rather than Perl. The Python API tests have
3029         the same structure as the layout tests.
3030
3031         * Scripts/run-api-tests: Changed from Perl to Python.
3032         * Scripts/webkitpy/api_tests: Added.
3033         * Scripts/webkitpy/api_tests/__init__.py: Added.
3034         * Scripts/webkitpy/api_tests/manager.py: Added.
3035         (Manager):
3036         (Manager.__init__):
3037         (Manager._test_list_from_output): Construct a list of tests from the output of
3038         TestWTF and TestWebKitAPI.
3039         (Manager._find_test_subset): Given a list of all possible tests and command line
3040         arguments, return a list of tests which match the provided arguments.
3041         (Manager._collect_tests): Run TestWTF and TestWebKitAPI with --gtest_list_tests
3042         to determine which tests will be run.
3043         (Manager._print_test_result): Formatted print of a test with it's output.
3044         (Manager._print_tests_result_with_status): Print all tests and output for tests
3045         which ran with a specified exit status.
3046         (Manager.run): Collect all tests, run them and then print results from the run.
3047         * Scripts/webkitpy/api_tests/run_api_tests.py: Added.
3048         (main): Parse arguments, construct a port, early exit for illegal ports and
3049         then run tests.
3050         (run): Setup logging and printing before using the Manager to run tests.
3051         (parse_args): Use argparse to define all options used by run-api-tests.
3052         * Scripts/webkitpy/api_tests/runner.py: Added.
3053         (Runner):
3054         (Runner.__init__):
3055         (Runner._shard_tests): Split tests so that each suite runs together.
3056         (Runner.command_for_port): Run a command on the device specified by the given
3057         port object. Once <https://bugs.webkit.org/show_bug.cgi?id=175204> is completed,
3058         this function would be entirely replaced by the server_process factory owned
3059         by the port object.
3060         (Runner.run): Run all shards in the message_pool.
3061         (Runner.handle): Handle reports from child processes.
3062         (Runner.result_map_by_status): Return a mapping of tests to output for tests
3063         which exit with a specific status.
3064         (_Worker):
3065         (_Worker.__init__):
3066         (_Worker._filter_noisy_output): Filter out objc warnings since these polite the log.
3067         (_Worker._run_single_test): Runs a single test in a single child process.
3068         (_Worker._run_shard_with_binary): Attempts to run a group of tests in the same
3069         child process. If this technique fails, the remaining tests are run singly.
3070         (_Worker.handle): Run the specified shard.
3071         * Scripts/webkitpy/port/base.py:
3072         (Port):
3073         (Port.check_api_test_build): Check if TestWTF and TestWebKitAPI are built.
3074         (Port.environment_for_api_tests): Return the environment needed to run
3075         the TestWebKitAPI binary.
3076         (Port. path_to_api_test_binaries): Return a list of the path to all binaries
3077         used when running API tests.
3078         (Port._build_api_tests): Build TestWTF and TestWebKitAPI if required.
3079         * Scripts/webkitpy/port/mac.py:
3080         (MacPort.environment_for_api_tests): Enable GuardMalloc for API tests.
3081         * Scripts/webkitpy/port/server_process.py: 
3082         (ServerProcess.pop_all_buffered_stdout):
3083
3084 2018-04-25  Carlos Garcia Campos  <cgarcia@igalia.com>
3085
3086         Incorrect number of WebDriver test failures shown in the bots
3087         https://bugs.webkit.org/show_bug.cgi?id=184959
3088
3089         Reviewed by Michael Catanzaro.
3090
3091         The regular expression we are using to get the number of failures from the log is matching a particular test
3092         error output. Improve the regular expression to avoid matching other strings in the log. Ensure that only
3093         matches at the beginning of lines and add spaces after Unexpected and before the (<failures>).
3094
3095         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3096         (RunWebDriverTests.commandComplete):
3097
3098 2018-04-25  Carlos Garcia Campos  <cgarcia@igalia.com>
3099
3100         [GTK] Implement MouseEvent.buttons
3101         https://bugs.webkit.org/show_bug.cgi?id=184913
3102
3103         Reviewed by Žan Doberšek.
3104
3105         Include the mouse buttons state in WTR synthesized events.
3106
3107         * WebKitTestRunner/EventSenderProxy.h:
3108         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3109         (WTR::EventSenderProxy::EventSenderProxy):
3110         (WTR::EventSenderProxy::createMouseButtonEvent):
3111         (WTR::EventSenderProxy::mouseDown):
3112         (WTR::EventSenderProxy::mouseUp):
3113         (WTR::EventSenderProxy::mouseMoveTo):
3114
3115 2018-04-24  Pablo Saavedra  <psaavedra@igalia.com>
3116
3117         [GTK][WPE] Fix triggered bot name on the WPE Debug Build bot
3118         https://bugs.webkit.org/show_bug.cgi?id=184954
3119
3120         Reviewed by Michael Catanzaro.
3121
3122         * BuildSlaveSupport/build.webkit.org-config/config.json:
3123
3124 2018-04-24  Saam Barati  <sbarati@apple.com>
3125
3126         Keep around a pre-warmed process when doing process swap on navigation
3127         https://bugs.webkit.org/show_bug.cgi?id=184765
3128         <rdar://problem/39685099>
3129
3130         Reviewed by Ryosuke Niwa and Brady Eidson.
3131
3132         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3133
3134 2018-04-24  Aakash Jain  <aakash_jain@apple.com>
3135
3136         [build.webkit.org] unit-tests fail when passwords.json is missing
3137         https://bugs.webkit.org/show_bug.cgi?id=180390
3138
3139         Reviewed by Carlos Alberto Lopez Perez.
3140
3141         * BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
3142         (loadBuilderConfig): Add support for test_mode. Load mock passwords in test_mode.
3143         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3144         (BuildBotConfigLoader._add_dependant_modules_to_sys_modules): Call _add_webkitpy_to_sys_path as well.
3145         (BuildBotConfigLoader._mock_open): Deleted.
3146         (BuildBotConfigLoader.load_config): Deleted.
3147
3148 2018-04-24  John Wilander  <wilander@apple.com>
3149
3150         From-Origin: Support for 'same' and 'same-site' response header, nested frame origin check
3151         https://bugs.webkit.org/show_bug.cgi?id=184560
3152         <rdar://problem/38901344>
3153
3154         Reviewed by Youenn Fablet and Daniel Bates.
3155
3156         This patch implements significant parts of https://github.com/whatwg/fetch/issues/687.
3157         We consume the From-Origin response header and only load the resource if:
3158         - The header is non-existent, empty, or invalid.
3159         - The header specifies 'same' and the resource's origin matches the originating
3160           document's origin and the origins up the frame tree.
3161         - The header specifies 'same-site' and the resource's eTLD+1 matches the originating
3162           document's eTLD+1 and the eTLD+1 of the documents up the frame tree.
3163
3164         This feature is experimental and off by default.
3165
3166         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3167         * TestWebKitAPI/Tests/WebCore/HTTPParsers.cpp: Added.
3168         (TestWebKitAPI::TEST):
3169             Tests for From-Origin header parsing.
3170
3171 2018-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3172
3173         Unreviewed. Update W3C WebDriver imported tests.
3174
3175         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
3176         (WebDriverW3CExecutor.__init__):
3177
3178 2018-04-24  Zan Dobersek  <zdobersek@igalia.com>
3179
3180         [WPE] Remove libgbm dependency
3181         https://bugs.webkit.org/show_bug.cgi?id=184906
3182
3183         Reviewed by Carlos Garcia Campos.
3184
3185         Stop searching for libgbm, using its compiler flags for the
3186         HeadlessViewBackend compilation and linking against the .so object.
3187         This is not necessary anymore after r230562 switched to a different
3188         backend implementation for testing.
3189
3190         * wpe/HeadlessViewBackend/CMakeLists.txt:
3191         * wpe/install-dependencies:
3192
3193 2018-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3194
3195         [GLIB] Make it possible to use a different timeout for slow test cases in GLib tests
3196         https://bugs.webkit.org/show_bug.cgi?id=184816
3197
3198         Reviewed by Michael Catanzaro.
3199
3200         Pass a function from api test runner to glib test runner to check if a test is slow and use the given slow
3201         timeout.
3202
3203         * TestWebKitAPI/glib/TestExpectations.json:
3204         * glib/api_test_runner.py:
3205         (TestRunner._run_test_glib.is_slow_test):
3206         (TestRunner._run_test_glib):
3207         * glib/glib_test_runner.py:
3208         (GLibTestRunner.__init__):
3209         (GLibTestRunner._stop_timeout):
3210         (GLibTestRunner._subtest_start):
3211         (GLibTestRunner._subtest_end):
3212
3213 2018-04-23  Wenson Hsieh  <wenson_hsieh@apple.com>
3214
3215         [Extra zoom mode] REGRESSION(230860) Unable to change time input values using UI
3216         https://bugs.webkit.org/show_bug.cgi?id=184901
3217         <rdar://problem/39664797>
3218
3219         Reviewed by Tim Horton.
3220
3221         Introduce a new UIScriptController method to set the value of a currently focused input of type time, by
3222         interacting with the UI. See WebKit ChangeLogs for more detail.
3223
3224         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3225         (WTR::UIScriptController::setTimePickerValue):
3226         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3227         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3228         (WTR::UIScriptController::setTimePickerValue):
3229         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3230         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3231         (WTR::UIScriptController::setTimePickerValue):
3232
3233 2018-04-23  Zalan Bujtas  <zalan@apple.com>
3234
3235         [LayoutFormattingContext] Initial commit.
3236         https://bugs.webkit.org/show_bug.cgi?id=184896
3237
3238         Reviewed by Antti Koivisto.
3239
3240         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3241
3242 2018-04-23  Chris Dumez  <cdumez@apple.com>
3243
3244         [WKTR] Move navigation policy decision from the injected bundle to the UIProcess
3245         https://bugs.webkit.org/show_bug.cgi?id=184801
3246
3247         Reviewed by Geoffrey Garen.
3248
3249         Move navigation policy decision from the injected bundle to the UIProcess in WebKitTestRunner.
3250         This is a more common configuration and therefore should be the default testing configuration.
3251
3252         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3253         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
3254         Always respond with 'PassThrough' in the InjectedBundle so the UIProcess
3255         is now asked for the policy decision.
3256
3257 2018-04-23  Pablo Saavedra  <psaavedra@igalia.com>
3258
3259         [GTK][WPE] Add Debug bots (build and tests) for WPE
3260         https://bugs.webkit.org/show_bug.cgi?id=184887
3261
3262         Reviewed by Carlos Alberto Lopez Perez.
3263
3264         Deployed 2 new bots for WPE Debug: wpe-linux-bot-3 and
3265         wpe-linux-bot-4
3266
3267         Both bots have already the credentials ready to authenticated against
3268         build.webkit.org. They provides the bots for the "debug" configuration over
3269         the "WPE" platform and building for the "x86_64" architecture:
3270         WPE Linux 64-bit Debug (Build) and WPE Linux 64-bit Debug (Tests) 
3271
3272         * BuildSlaveSupport/build.webkit.org-config/config.json:
3273         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3274
3275 2018-04-23  Chris Dumez  <cdumez@apple.com>
3276
3277         HTML String load cannot be prevented by responding 'Cancel' asynchronously in decidePolicyForNavigationAction
3278         https://bugs.webkit.org/show_bug.cgi?id=184848
3279         <rdar://problem/39145306>
3280
3281         Reviewed by Brady Eidson.
3282
3283         Add API test coverage.
3284
3285         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
3286         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
3287         (TEST):
3288
3289 2018-04-23  Michael Catanzaro  <mcatanzaro@igalia.com>
3290
3291         [GTK][WPE] TestSSL fails due to additional TLS errors returned
3292         https://bugs.webkit.org/show_bug.cgi?id=184860
3293
3294         Reviewed by Carlos Garcia Campos.
3295
3296         Add script and config file for regenerating the test certificate.
3297         Regenerate it. TestSSL no longer fails on my machine.
3298
3299         I do see a ton of network process crashes and JavaScript errors, none of
3300         which prevent the test from passing, but this commit only claims to fix
3301         the certificate validation portion of the test.
3302
3303         * TestWebKitAPI/Tests/WebKitGLib/resources/generate-test-cert.sh: Added.
3304         * TestWebKitAPI/Tests/WebKitGLib/resources/test-cert.conf: Added.
3305         * TestWebKitAPI/Tests/WebKitGLib/resources/test-cert.pem:
3306
3307 2018-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3308
3309         [GLIB] ERROR: Thread was unable to be detached when running /jsc/vm test in debug
3310         https://bugs.webkit.org/show_bug.cgi?id=184815
3311
3312         Reviewed by Michael Catanzaro.
3313
3314         This is because in the test we are calling both join and detach. We should only call join.
3315
3316         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3317         (testsJSCVirtualMachine):
3318
3319 2018-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3320
3321         [GLIB] Test /jsc/prototypes crashes in debug
3322         https://bugs.webkit.org/show_bug.cgi?id=184814
3323
3324         Reviewed by Michael Catanzaro.
3325
3326         We should also call the constructor/destructor of Bar struct to ensure Foo is constructed.
3327
3328         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3329         (barCreate):
3330         (barFree):
3331
3332 2018-04-20  Michael Catanzaro  <mcatanzaro@igalia.com>
3333
3334         REGRESSION(r228088): [SOUP] Check TLS errors for WebSockets on GTlsConnection::accept-certificate
3335         https://bugs.webkit.org/show_bug.cgi?id=184804
3336
3337         Reviewed by Carlos Garcia Campos.
3338
3339         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
3340         (WebSocketTest::WebSocketTest):
3341         (WebSocketTest::~WebSocketTest):
3342         (WebSocketTest::serverWebSocketCallback):
3343         (WebSocketTest::webSocketTestResultCallback):
3344         (WebSocketTest::connectToServerAndWaitForEvents):
3345         (testWebSocketTLSErrors):
3346         (beforeAll):
3347
3348 2018-04-20  Chris Dumez  <cdumez@apple.com>
3349
3350         Unreviewed, update 2 more API tests after r230876.
3351
3352         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
3353         (TEST):
3354         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
3355         (TestWebKitAPI::TEST):
3356
3357 2018-04-20  Tim Horton  <timothy_horton@apple.com>
3358
3359         Adjust geolocation feature flag
3360         https://bugs.webkit.org/show_bug.cgi?id=184856
3361
3362         Reviewed by Wenson Hsieh.
3363
3364         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3365
3366 2018-04-20  Chris Dumez  <cdumez@apple.com>
3367
3368         REGRESSION (r229828): web view doesn’t update or respond to resizing until client calls policy decision handler
3369         https://bugs.webkit.org/show_bug.cgi?id=184210
3370         <rdar://problem/39072354>
3371
3372         Reviewed by Wenson Hsieh.
3373
3374         * TestWebKitAPI/Tests/WebKit/large-red-square-image.html:
3375         * TestWebKitAPI/Tests/WebKitCocoa/dragstart-change-selection-offscreen.html:
3376         Add viewport meta tags.
3377
3378         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3379         (-[WKWebView _test_waitForDidFinishNavigation]):
3380         Update _test_waitForDidFinishNavigation to wait for the next presentation update
3381         to make iOS API tests happy without having to modify each of them.
3382
3383 2018-04-20  Timothy Hatcher  <timothy@apple.com>
3384
3385         REGRESSION: API test WebKit.BackgroundColorSystemColor is failing
3386
3387         https://bugs.webkit.org/show_bug.cgi?id=184849
3388         rdar://problem/39386405
3389
3390         Reviewed by Brian Burg.
3391
3392         * TestWebKitAPI/Tests/mac/BackgroundColor.mm:
3393         (TestWebKitAPI::TEST): Use CGColorEqualToColor since we might get a different
3394         CGColor pointer from NSColor each time.
3395
3396 2018-04-20  Wenson Hsieh  <wenson_hsieh@apple.com>
3397
3398         [Extra zoom mode] Injected bundle form client should be notified when editing text fields
3399         https://bugs.webkit.org/show_bug.cgi?id=184822
3400         <rdar://problem/38807319>
3401
3402         Reviewed by Tim Horton.
3403
3404         Add WebKitTestRunner support for listening to form editing SPI hooks in the injected bundle. The new layout test
3405         installs callbacks that listen for "begin editing", "end editing", and "text changed" calls to injected bundle
3406         SPI. See other ChangeLogs for more detail.
3407
3408         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3409         (WTR::UIScriptController::enterText):
3410         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3411
3412         Add UIScriptController support for simulating text entry in the currently focused element.
3413
3414         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3415         (WTR::UIScriptController::enterText):
3416         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3417         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3418
3419         Add TestRunner bindings for registering injected bundle form client callbacks.
3420
3421         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3422         (WTR::handleTextDidChangeInTextField):
3423         (WTR::handleTextFieldDidBeginEditing):
3424         (WTR::handleTextFieldDidEndEditing):
3425         (WTR::InjectedBundle::didCreatePage):
3426
3427         Set the injected bundle form editor client.
3428
3429         (WTR::InjectedBundle::setUpInjectedBundleClients):
3430         (WTR::InjectedBundle::textDidChangeInTextField):
3431         (WTR::InjectedBundle::textFieldDidBeginEditing):
3432         (WTR::InjectedBundle::textFieldDidEndEditing):
3433         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3434         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3435         (WTR::TestRunner::installTextDidChangeInTextFieldCallback):
3436         (WTR::TestRunner::textDidChangeInTextFieldCallback):
3437         (WTR::TestRunner::installTextFieldDidBeginEditingCallback):
3438         (WTR::TestRunner::textFieldDidBeginEditingCallback):
3439         (WTR::TestRunner::installTextFieldDidEndEditingCallback):
3440         (WTR::TestRunner::textFieldDidEndEditingCallback):
3441         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3442         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3443         (WTR::UIScriptController::enterText):
3444
3445 2018-04-20  Youenn Fablet  <youenn@apple.com>
3446
3447         WebPage sometimes incorrectly rules out PDF as a mime type that can be showed
3448         https://bugs.webkit.org/show_bug.cgi?id=184369
3449
3450         Reviewed by Chris Dumez.
3451
3452         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
3453         (TEST):
3454
3455 2018-04-20  Daniel Bates  <dabates@apple.com>
3456
3457         Remove Strong Password decoration when text field type changes
3458         https://bugs.webkit.org/show_bug.cgi?id=184795
3459         <rdar://problem/38325108>
3460
3461         Reviewed by Antti Koivisto.
3462
3463         Add a unit test to ensure the injected bundle API and WebKit UI delegate SPI is invoked
3464         when the field has the Strong Password button and its type changes.
3465
3466         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3467         * TestWebKitAPI/Tests/WebKitCocoa/DidResignInputElementStrongPasswordAppearance.mm: Added.
3468         (didResignInputElementStrongPasswordAppearance):
3469         (-[DidResignInputElementStrongPasswordAppearance webProcessPlugIn:didCreateBrowserContextController:]):
3470         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3471         (-[DidResignInputElementStrongPasswordAppearanceDelegate _webView:didResignInputElementStrongPasswordAppearanceWithUserInfo:]):
3472         (-[DidResignInputElementStrongPasswordAppearanceDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3473         (TEST):
3474
3475 2018-04-20  Brady Eidson  <beidson@apple.com>
3476
3477         Add a test to verify load/unload/pageshow/pagehide all work with process swapping.
3478         https://bugs.webkit.org/show_bug.cgi?id=184807
3479
3480         Reviewed by Chris Dumez.
3481
3482         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3483         (-[PSONMessageHandler userContentController:didReceiveScriptMessage:]):
3484
3485 2018-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3486
3487         Unreviewed. Mark TestJSC as slow in debug.
3488
3489         Only /jsc/vm is slow, but GLib API test runner only checks the test binary for GLib tests.
3490
3491         * TestWebKitAPI/glib/TestExpectations.json:
3492
3493 2018-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3494
3495         [GTK] Local cross references are broken in API documentation
3496         https://bugs.webkit.org/show_bug.cgi?id=184771
3497
3498         Reviewed by Michael Catanzaro.
3499
3500         The problem is that gtkdoc-fixxref expects the links to be in the form html/modulename (like the installed
3501         ones), but we generate the documentation as modulename/html. So, links to WebKitDOM or JSC are generated as
3502         ../html/Foo. The rebase command considers html to be the module name in this case, creating broken links in all
3503         the cases.
3504
3505         * gtk/gtkdoc.py:
3506         (GTKDoc._copy_doc_files_to_output_dir): We don't have any html dir in the source tree so, we are not copying
3507         anything here.
3508         (GTKDoc._run_gtkdoc_mkhtml): Create the html dir here using html/modulename instead now.
3509         (GTKDoc._run_gtkdoc_fixxref): Pass the new directory as module dir to gtkdoc-fixxref and fix several links for
3510         which gtkdoc-fixxref always uses absolute paths.
3511         * gtk/manifest.txt.in: Update the documentation html paths and include the JSC GLib API in the tarball too.
3512
3513 2018-04-19  Brady Eidson  <beidson@apple.com>
3514
3515         Make back forward cache work with process swapping.
3516         <rdar://problem/38676604> and https://bugs.webkit.org/show_bug.cgi?id=184793
3517
3518         Reviewed by Chris Dumez.
3519
3520         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3521
3522 2018-04-19  David Kilzer  <ddkilzer@apple.com>
3523
3524         Enable Objective-C weak references
3525         <https://webkit.org/b/184789>
3526         <rdar://problem/39571716>
3527
3528         Reviewed by Dan Bernstein.
3529
3530         * ContentExtensionTester/Configurations/Base.xcconfig:
3531         (CLANG_ENABLE_OBJC_WEAK): Enable.
3532         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3533         (CLANG_ENABLE_OBJC_WEAK): Enable.
3534         * ImageDiff/cg/Configurations/Base.xcconfig:
3535         (CLANG_ENABLE_OBJC_WEAK): Enable.
3536         * MiniBrowser/Configurations/Base.xcconfig:
3537         (CLANG_ENABLE_OBJC_WEAK): Enable.
3538         * TestWebKitAPI/Configurations/Base.xcconfig:
3539         (CLANG_ENABLE_OBJC_WEAK): Enable.
3540         * WebEditingTester/Configurations/Base.xcconfig:
3541         (CLANG_ENABLE_OBJC_ARC): Re-order.
3542         * WebKitLauncher/Configurations/Base.xcconfig: Add newline at
3543         end of file.
3544         (CLANG_ENABLE_OBJC_WEAK): Enable.
3545         * WebKitTestRunner/Configurations/Base.xcconfig:
3546         (CLANG_ENABLE_OBJC_WEAK): Enable.
3547
3548 2018-04-19  Chris Dumez  <cdumez@apple.com>
3549
3550         REGRESSION (r229133): decidePolicyForNavigationAction not called for loading an HTML string
3551         https://bugs.webkit.org/show_bug.cgi?id=184209
3552         <rdar://problem/39145306>
3553
3554         Reviewed by Ryosuke Niwa.
3555
3556         Add API test coverage.
3557
3558         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
3559         (TEST):
3560
3561 2018-04-18  Ross Kirsling  <ross.kirsling@sony.com>
3562
3563         [WinCairo][EWS] Build bot should clean user temp directory each time.
3564         https://bugs.webkit.org/show_bug.cgi?id=184761
3565
3566         Reviewed by Lucas Forschler.
3567
3568         * EWSTools/Start-Queue.ps1:
3569         Clean user's temp directory before each build, so that Windows git doesn't fill it up over time.
3570
3571 2018-04-18  Ross Kirsling  <ross.kirsling@sony.com>
3572
3573         Buildbots using Python zipfile should enable compression
3574         https://bugs.webkit.org/show_bug.cgi?id=184759
3575
3576         Reviewed by Lucas Forschler.
3577
3578         * BuildSlaveSupport/built-product-archive:
3579         (createZipManually):
3580         Default is to archive without compressing, so tell it to compress as well. 
3581
3582 2018-04-18  Nan Wang  <n_wang@apple.com>
3583
3584         AX: [macOS] WebKit hangs when triggering an alert from an AOM increment event
3585         https://bugs.webkit.org/show_bug.cgi?id=184742
3586
3587         Reviewed by Chris Fleizach.
3588
3589         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3590         (AccessibilityUIElement::increment):
3591         (AccessibilityUIElement::decrement):
3592         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3593         (WTR::AccessibilityUIElement::asyncIncrement):
3594         (WTR::AccessibilityUIElement::asyncDecrement):
3595         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3596         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3597         (WTR::AccessibilityUIElement::increment):
3598         (WTR::AccessibilityUIElement::decrement):
3599         (WTR::AccessibilityUIElement::asyncIncrement):
3600         (WTR::AccessibilityUIElement::asyncDecrement):
3601
3602 2018-04-18  Ross Kirsling  <ross.kirsling@sony.com>
3603
3604         Fix archive step for WinCairo build bot.
3605         https://bugs.webkit.org/show_bug.cgi?id=184715
3606
3607         Reviewed by Lucas Forschler.
3608
3609         * BuildSlaveSupport/built-product-archive:
3610         (archiveBuiltProduct):
3611         (extractBuiltProduct):
3612
3613 2018-04-18  Sihui Liu  <sihui_liu@apple.com>
3614
3615         REGRESSION: Using the reload button while offline pushes identical pages onto the back/forward list
3616         https://bugs.webkit.org/show_bug.cgi?id=184570
3617         <rdar://problem/34807323>
3618
3619         Reviewed by Chris Dumez.
3620
3621         Add API test coverage.
3622
3623         * TestWebKitAPI/Tests/WebKitCocoa/LoadAlternateHTMLString.mm:
3624         (TEST):
3625
3626 2018-04-18  Chris Dumez  <cdumez@apple.com>
3627
3628         Add support for converting a local window to a remote window
3629         https://bugs.webkit.org/show_bug.cgi?id=184515
3630         <rdar://problem/39011318>
3631
3632         Reviewed by Ryosuke Niwa.
3633
3634         * MiniBrowser/mac/AppDelegate.m:
3635         (defaultConfiguration):
3636         * MiniBrowser/mac/SettingsController.h:
3637         * MiniBrowser/mac/SettingsController.m:
3638         (-[SettingsController _populateMenu]):
3639         (-[SettingsController validateMenuItem:]):
3640         (-[SettingsController processSwapOnWindowOpenWithOpenerEnabled]):
3641         (-[SettingsController toggleProcessSwapOnWindowOpenWithOpener:]):
3642         Add menu entry in minibrowser to turn on process swap on cross-origin window.open().
3643
3644         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3645         Turn on process swap on cross-origin window.open() for corresponding test and update
3646         test to expect that a new WebProcess is created.
3647
3648         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3649         (WTR::InjectedBundlePage::decidePolicyForResponse):
3650         Add null checks for injectedBundle.testRunner(). When we swap process on navigation,
3651         the InjectedBundlePage::decidePolicyForResponse() gets called in the new process.
3652         In this new process, we have constructed a InjectedBundlePage for the page but we
3653         have not initialized the InjectedBundle members such as testRunner.
3654
3655         * WebKitTestRunner/TestController.cpp:
3656         (WTR::TestController::createWebViewWithOptions):
3657         (WTR::updateTestOptionsFromTestHeader):
3658         * WebKitTestRunner/TestOptions.h:
3659         (WTR::TestOptions::hasSameInitializationOptions const):
3660         Add a way for layout tests to turn on process swap on navigation via a test header.
3661
3662 2018-04-18  Yusuke Suzuki  <utatane.tea@gmail.com>
3663
3664         Unreviewed, reland r230697, r230720, and r230724.
3665         https://bugs.webkit.org/show_bug.cgi?id=184600
3666
3667         * Scripts/run-jsc-stress-tests:
3668
3669 2018-04-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3670
3671         [GLIB] Make it possible to handle JSCClass external properties not added to the prototype
3672         https://bugs.webkit.org/show_bug.cgi?id=184687
3673
3674         Reviewed by Michael Catanzaro.
3675
3676         Add test cases for the new API.
3677
3678         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3679         (fooCreate):
3680         (fooFree):
3681         (fooGetProperty):
3682         (fooSetProperty):
3683         (testJSCPromises):
3684         (testJSCGarbageCollector):
3685         (testsJSCVirtualMachine):
3686         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
3687         (windowObjectClearedCallback):
3688
3689 2018-04-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3690
3691         [Extra zoom mode] Programmatically changing focus when an element already has focus is a confusing experience
3692         https://bugs.webkit.org/show_bug.cgi?id=184635
3693         <rdar://problem/39440642>
3694
3695         Reviewed by Tim Horton.
3696
3697         Add plumbing to support invoking `didHideKeyboardCallback` and `didShowKeyboardCallback` when (respectively)
3698         dismissing or presenting fullscreen input view controllers in extra zoom mode.
3699
3700         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3701         (-[TestRunnerWKWebView initWithFrame:configuration:]):
3702         (-[TestRunnerWKWebView dealloc]):
3703         (-[TestRunnerWKWebView _invokeShowKeyboardCallbackIfNecessary]):
3704         (-[TestRunnerWKWebView _invokeHideKeyboardCallbackIfNecessary]):
3705         (-[TestRunnerWKWebView _keyboardDidShow:]):
3706         (-[TestRunnerWKWebView _keyboardDidHide:]):
3707         (-[TestRunnerWKWebView _webView:didPresentFocusedElementViewController:]):
3708         (-[TestRunnerWKWebView _webView:didDismissFocusedElementViewController:]):
3709
3710 2018-04-17  Michael Catanzaro  <mcatanzaro@igalia.com>
3711
3712         [GTK] Webkit should spoof as Safari on a Mac for Outlook.com
3713         https://bugs.webkit.org/show_bug.cgi?id=184573
3714
3715         Reviewed by Carlos Alberto Lopez Perez.
3716
3717         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3718         (TestWebKitAPI::TEST):
3719
3720 2018-04-17  Fujii Hironori  <Hironori.Fujii@sony.com>
3721
3722         [WinCairo][TestWebKitAPI] Implement PlatformWebView for TestWebKit
3723         https://bugs.webkit.org/show_bug.cgi?id=184524
3724
3725         Reviewed by Alex Christensen.
3726
3727         Resurrect PlatformWebView for Windows port which was removed in Bug 104607.
3728
3729         * TestWebKitAPI/PlatformWebView.h:
3730         * TestWebKitAPI/PlatformWin.cmake:
3731         * TestWebKitAPI/win/InjectedBundleControllerWin.cpp: Added.
3732         (TestWebKitAPI::InjectedBundleController::platformInitialize):
3733         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Added.
3734         (TestWebKitAPI::Util::moduleDirectory):
3735         (TestWebKitAPI::Util::createInjectedBundlePath):
3736         (TestWebKitAPI::Util::createURLForResource):
3737         (TestWebKitAPI::Util::URLForNonExistentResource):
3738         (TestWebKitAPI::Util::isKeyDown):
3739         * TestWebKitAPI/win/PlatformWebViewWin.cpp: Added.
3740         (TestWebKitAPI::PlatformWebView::registerWindowClass):
3741         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3742         (TestWebKitAPI::PlatformWebView::initialize):
3743         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
3744         (TestWebKitAPI::PlatformWebView::page const):
3745         (TestWebKitAPI::PlatformWebView::resizeTo):
3746         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
3747         (TestWebKitAPI::PlatformWebView::simulateAltKeyPress):
3748         (TestWebKitAPI::PlatformWebView::simulateRightClick):
3749         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
3750         (TestWebKitAPI::PlatformWebView::wndProc):
3751         * TestWebKitAPI/win/UtilitiesWin.cpp: Added.
3752         (TestWebKitAPI::Util::run):
3753         (TestWebKitAPI::Util::spinRunLoop):
3754         (TestWebKitAPI::Util::sleep):
3755
3756 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
3757
3758         Fix hasher tests for system with 32 bit longs
3759         https://bugs.webkit.org/show_bug.cgi?id=184708
3760         <rdar://problem/39459977>
3761
3762         Reviewed by Mark Lam.
3763
3764         Some systems have 32 bit longs. The Hasher WTF tests should handle this case.
3765
3766         * TestWebKitAPI/Tests/WTF/Hasher.cpp:
3767         (TestWebKitAPI::TEST):
3768
3769 2018-04-17  Commit Queue  <commit-queue@webkit.org>
3770
3771         Unreviewed, rolling out r230697, r230720, and r230724.
3772         https://bugs.webkit.org/show_bug.cgi?id=184717
3773
3774         These caused multiple failures on the Test262 testers.
3775         (Requested by mlewis13 on #webkit).
3776
3777         Reverted changesets:
3778
3779         "[WebAssembly][Modules] Prototype wasm import"
3780         https://bugs.webkit.org/show_bug.cgi?id=184600
3781         https://trac.webkit.org/changeset/230697
3782
3783         "[WebAssembly][Modules] Implement function import from wasm
3784         modules"
3785         https://bugs.webkit.org/show_bug.cgi?id=184689
3786         https://trac.webkit.org/changeset/230720
3787
3788         "[JSC] Rename runWebAssembly to runWebAssemblySuite"
3789         https://bugs.webkit.org/show_bug.cgi?id=184703
3790         https://trac.webkit.org/changeset/230724
3791
3792 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
3793
3794         Unreviewed rollout of r230632. Regression in memory usage.
3795
3796         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
3797
3798         * DumpRenderTree/TestOptions.h:
3799         * DumpRenderTree/mac/DumpRenderTree.mm:
3800         (runTest):
3801         (shouldOverrideAndDisableCSSAnimationsAndCSSTransitionsBackedByWebAnimationsPreference): Deleted.
3802         * WebKitTestRunner/TestController.cpp:
3803         (WTR::TestController::resetPreferencesToConsistentValues):
3804         * WebKitTestRunner/TestOptions.cpp:
3805         (WTR::TestOptions::TestOptions):
3806         (WTR::isLegacyAnimationEngineTestPath): Deleted.
3807         * WebKitTestRunner/TestOptions.h:
3808
3809 2018-04-17  Yusuke Suzuki  <utatane.tea@gmail.com>
3810
3811         [JSC] Rename runWebAssembly to runWebAssemblySuite
3812         https://bugs.webkit.org/show_bug.cgi?id=184703
3813
3814         Reviewed by JF Bastien.
3815
3816         * Scripts/run-jsc-stress-tests:
3817
3818 2018-04-17  Yusuke Suzuki  <utatane.tea@gmail.com>
3819
3820         [WebAssembly][Modules] Implement function import from wasm modules
3821         https://bugs.webkit.org/show_bug.cgi?id=184689
3822
3823         Reviewed by JF Bastien.
3824
3825         Add runWebAssemblyDirect, which runs wasm file directly.
3826
3827         * Scripts/run-jsc-stress-tests:
3828
3829 2018-04-17  Saam Barati  <sbarati@apple.com>
3830
3831         Add system trace points for process launch and for initializeWebProcess
3832         https://bugs.webkit.org/show_bug.cgi?id=184669
3833
3834         Reviewed by Simon Fraser.
3835
3836         * Tracing/SystemTracePoints.plist:
3837
3838 2018-04-17  Ross Kirsling  <ross.kirsling@sony.com>
3839
3840         Add debug bots for WinCairo.
3841         https://bugs.webkit.org/show_bug.cgi?id=184663
3842
3843         Reviewed by Lucas Forschler.
3844
3845         * BuildSlaveSupport/build.webkit.org-config/config.json:
3846         Add a debug build bot and two debug test bots.
3847
3848         * BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
3849         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3850         Add a WinCairo category to build.webkit.org.
3851
3852 2018-04-17  Zalan Bujtas  <zalan@apple.com>
3853
3854         [LayoutReloaded] Set inline-block box position.
3855         https://bugs.webkit.org/show_bug.cgi?id=184690
3856
3857         Reviewed by Antti Koivisto.
3858
3859         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3860         (InlineFormattingContext.prototype._handleInlineBlock):
3861         * LayoutReloaded/Utils.js:
3862         (Utils._dumpBox):
3863         * LayoutReloaded/test/inline-block-with-fixed-width-height.html:
3864
3865 2018-04-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3866
3867         [GLIB] Add API to clear JSCContext uncaught exception
3868         https://bugs.webkit.org/show_bug.cgi?id=184685
3869
3870         Reviewed by Žan Doberšek.
3871
3872         Add test cases for the new API.
3873
3874         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3875         (testJSCExceptions):
3876
3877 2018-04-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3878
3879         [GLIB] Add API to query, delete and enumerate properties
3880         https://bugs.webkit.org/show_bug.cgi?id=184647
3881
3882         Reviewed by Michael Catanzaro.
3883
3884         Add test cases for the new API.
3885
3886         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3887         (testJSCObject):
3888         (testJSCClass):
3889         (testJSCPrototypes):
3890
3891 2018-04-16  Zalan Bujtas  <zalan@apple.com>
3892
3893         [LayoutReloaded] Add support for replaced box.
3894         https://bugs.webkit.org/show_bug.cgi?id=184680
3895
3896         Reviewed by Antti Koivisto.
3897
3898         Basic support for inline replaced.
3899
3900         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3901         (InlineFormattingContext.prototype._handleInlineBox):
3902         (InlineFormattingContext.prototype._handleInlineBlock):
3903         (InlineFormattingContext.prototype._handleReplaced):
3904         * LayoutReloaded/FormattingContext/InlineFormatting/Line.js:
3905         (Line.prototype.lastLineBox):
3906         (Line.prototype.addInlineBox):
3907         (Line.prototype.addInlineContainerBox): Deleted.
3908         * LayoutReloaded/TreeBuilder.js:
3909         (TreeBuilder.prototype._createAndAttachBox):
3910         * LayoutReloaded/Utils.js:
3911         (Utils._dumpBox):
3912         * LayoutReloaded/test/index.html:
3913         * LayoutReloaded/test/inline-simple-replaced.html: Added.
3914
3915 2018-04-16  Zalan Bujtas  <zalan@apple.com>
3916
3917         [LayoutReloaded] Minor InlineFormattingContext::layout() cleanup.
3918         https://bugs.webkit.org/show_bug.cgi?id=184679
3919
3920         Reviewed by Antti Koivisto.
3921
3922         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3923         (InlineFormattingContext):
3924         (InlineFormattingContext.prototype.layout):
3925         (InlineFormattingContext.prototype._handleInlineContainer):
3926         (InlineFormattingContext.prototype._handleInlineContent):
3927         (InlineFormattingContext.prototype._handleInlineBlock):
3928         (InlineFormattingContext.prototype._handleReplacedBox):
3929         (InlineFormattingContext.prototype._clearNeedsLayoutAndMoveToNextSibling):
3930         (InlineFormattingContext.prototype._handleInlineBlockContainer): Deleted.
3931         (InlineFormattingContext.prototype._clearAndMoveToNext): Deleted.
3932
3933 2018-04-16  Zalan Bujtas  <zalan@apple.com>
3934
3935         [LayoutReloaded] Introduce fragmentation state/context.
3936         https://bugs.webkit.org/show_bug.cgi?id=184677
3937
3938         Reviewed by Antti Koivisto.
3939
3940         State/context for fragmented content (multicol, regions, pagination etc).
3941
3942         * LayoutReloaded/FormattingContext/FragmentationContext.js: Added.
3943         (FragmentationContext):
3944         * LayoutReloaded/FormattingState/FragmentationState.js: Added.
3945         (FragmentationState):
3946         (FragmentationState.prototype.formattingState):
3947
3948 2018-04-16  Andy Estes  <aestes@apple.com>
3949
3950         [iOS] Enable WKPDFView by default
3951         https://bugs.webkit.org/show_bug.cgi?id=184675
3952         <rdar://problem/27885452>
3953
3954         Reviewed by Darin Adler.
3955
3956         * TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm:
3957
3958 2018-04-16  Leo Balter  <leonardo.balter@gmail.com>
3959
3960         Perl-based Test262 runner
3961         https://bugs.webkit.org/show_bug.cgi?id=183343
3962
3963         Reviewed by Michael Saboff.
3964
3965         * Scripts/test262-helpers/README.md: Added.
3966         * Scripts/test262-helpers/agent.js: Added.
3967         (262.getGlobal):
3968         (262.setGlobal):
3969         (262.destroy):
3970         (262.IsHTMLDDA):
3971         * Scripts/test262-helpers/cpanfile: Added.
3972         * Scripts/test262-helpers/cpanfile.snapshot: Added.
3973         * Scripts/test262-helpers/test262-runner.pl: Added.
3974         (main):
3975         (processFile):
3976         (getScenarios):
3977         (addScenario):
3978         (compileTest):
3979         (runTest):
3980         (processResult):
3981         (getTempFile):
3982         (getContents):
3983         (parseData):
3984         (getHarness):
3985         * Scripts/test262-helpers/tests.log: Added.
3986
3987 2018-04-15  Andy Estes  <aestes@apple.com>
3988
3989         [iOS] Add API tests for PDF find-in-page
3990         https://bugs.webkit.org/show_bug.cgi?id=184634
3991
3992         Reviewed by Dan Bernstein.
3993
3994         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3995         * TestWebKitAPI/Tests/WebKit/find.pdf: Added.
3996         * TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm:
3997         (-[TestFindDelegate findString]):
3998         (-[TestFindDelegate _webView:didCountMatches:forString:]):
3999         (-[TestFindDelegate _webView:didFindMatches:forString:withMatchIndex:]):
4000         (-[TestFindDelegate _webView:didFailToFindString:]):
4001         (loadWebView):
4002         (TEST):
4003
4004 2018-04-13  Zalan Bujtas  <zalan@apple.com>
4005
4006         [LayoutReloaded] Update class documentation
4007         https://bugs.webkit.org/show_bug.cgi?id=184625
4008
4009         Reviewed by Antti Koivisto.
4010
4011         * LayoutReloaded/DisplayTree/Box.js:
4012         * LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
4013         * LayoutReloaded/FormattingContext/BlockFormatting/BlockMarginCollapse.js:
4014         * LayoutReloaded/FormattingContext/FloatingContext.js:
4015         * LayoutReloaded/FormattingContext/FormattingContext.js:
4016         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
4017         * LayoutReloaded/FormattingContext/InlineFormatting/Line.js:
4018         * LayoutReloaded/FormattingState/BlockFormattingState.js:
4019         * LayoutReloaded/FormattingState/FloatingState.js:
4020         * LayoutReloaded/FormattingState/FormattingState.js:
4021         * LayoutReloaded/FormattingState/InlineFormattingState.js:
4022         * LayoutReloaded/LayoutState.js:
4023         * LayoutReloaded/LayoutTree/BlockContainer.js:
4024         * LayoutReloaded/LayoutTree/Box.js:
4025         * LayoutReloaded/LayoutTree/Container.js:
4026         * LayoutReloaded/LayoutTree/InlineBox.js:
4027         * LayoutReloaded/LayoutTree/InlineContainer.js:
4028         * LayoutReloaded/LayoutTree/Text.js:
4029         * LayoutReloaded/misc/headers/BlockContainer.h: Removed.
4030         * LayoutReloaded/misc/headers/BlockFormattingContext.h: Removed.
4031         * LayoutReloaded/misc/headers/BlockMarginCollapse.h: Removed.
4032         * LayoutReloaded/misc/headers/Box.h: Removed.
4033         * LayoutReloaded/misc/headers/Container.h: Removed.
4034         * LayoutReloaded/misc/headers/FloatingContext.h: Removed.
4035         * LayoutReloaded/misc/headers/FormattingContext.h: Removed.
4036         * LayoutReloaded/misc/headers/InitialBlockContainer.h: Removed.
4037         * LayoutReloaded/misc/headers/InlineBox.h: Removed.
4038         * LayoutReloaded/misc/headers/LayoutContext.h: Removed.
4039         * LayoutReloaded/misc/headers/Line.h: Removed.
4040         * LayoutReloaded/misc/headers/Text.h: Removed.
4041
4042 2018-04-13  Zalan Bujtas  <zalan@apple.com>
4043
4044         [LayoutReloaded] Add simple implementation for FormattingState::markNeedsLayout()
4045         https://bugs.webkit.org/show_bug.cgi?id=184621
4046
4047         Reviewed by Antti Koivisto.
4048
4049         This is just a simple, mark ancestors dirty implementation.
4050
4051         * LayoutReloaded/FormattingState/FormattingState.js:
4052         (FormattingState.prototype.markNeedsLayout):
4053         * LayoutReloaded/LayoutState.js:
4054         (LayoutState.prototype.markNeedsLayout):
4055         (LayoutState.prototype.setNeedsLayoutById): Deleted.
4056         (LayoutState.prototype.setNeedsLayout): Deleted.
4057         * LayoutReloaded/TreeBuilder.js:
4058         (TreeBuilder.prototype._createAndAttachBox):
4059         (TreeBuilder.prototype._findBox): Deleted.
4060         * LayoutReloaded/Utils.js:
4061         (Utils.layoutBoxById):
4062         * LayoutReloaded/test/index.html:
4063         * LayoutReloaded/test/simple-incremental-layout-with-static-content.html:
4064
4065 2018-04-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4066
4067         [WPE] [webkitpy] The driver requirements should be checked before starting the tests
4068         https://bugs.webkit.org/show_bug.cgi?id=184595
4069
4070         Reviewed by Michael Catanzaro.
4071
4072         Ensure Driver.check_driver() is checked at check_sys_deps() time.
4073
4074         * Scripts/webkitpy/port/wpe.py:
4075         (WPEPort.check_sys_deps):
4076
4077 2018-04-13  Zalan Bujtas  <zalan@apple.com>
4078
4079         Rebaseline LayoutReloaded patch file (collectRenderersWithNeedsLayout).
4080
4081         * LayoutReloaded/misc/LayoutReloadedWebKit.patch:
4082
4083 2018-04-13  Jonathan Bedard  <jbedard@apple.com>
4084
4085         Boot fewer simulators in CI/EWS machines
4086         https://bugs.webkit.org/show_bug.cgi?id=184594
4087         <rdar://problem/39188082>
4088
4089         Reviewed by Alexey Proskuryakov.
4090
4091         This is a temporary workaround fro <rdar://problem/39393590>.
4092
4093         * Scripts/webkitpy/xcode/simulated_device.py:
4094         (SimulatedDeviceManager): Treat simulators as taking 6 gigs instead of 2.
4095
4096 2018-04-13  Brady Eidson  <beidson@apple.com>
4097
4098         Introduce SuspendedPageProxy to keep old web processes around after their WebPageProxy has been swapped to a new one.
4099         https://bugs.webkit.org/show_bug.cgi?id=184559
4100
4101         Reviewed by Alex Christensen.
4102
4103         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4104
4105 2018-04-13  Chris Dumez  <cdumez@apple.com>
4106
4107         input.webkitEntries does not work as expected when folder contains accented chars
4108         https://bugs.webkit.org/show_bug.cgi?id=184517
4109         <rdar://problem/39265537>
4110
4111         Reviewed by Alex Christensen.
4112
4113         Add API test coverage.
4114
4115         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
4116         (TestWebKitAPI::TEST_F):
4117
4118 2018-04-13  Thibault Saunier  <tsaunier@igalia.com>
4119
4120         Update my emails ordering in contributors.json
4121         https://bugs.webkit.org/show_bug.cgi?id=184587
4122
4123         Rubber-stamped by Philippe Normand.
4124
4125         Bugzilla seems to pick up tsaunier@igalia.com which is not the one I use there.
4126
4127         * Scripts/webkitpy/common/config/contributors.json:
4128
4129 2018-04-13  Michael Catanzaro  <mcatanzaro@igalia.com>
4130
4131         [WPE] xkbcommon: ERROR: failed to add default include path /home/mcatanzaro/Projects/WebKit/WebKitBuild/DependenciesWPE/Root/share/X11/xkb
4132         https://bugs.webkit.org/show_bug.cgi?id=184388
4133
4134         Reviewed by Carlos Alberto Lopez Perez.
4135
4136         Remove libxkbcommon from the JHBuild environment. We could alternatively add
4137         xkeyboard-config, but there doesn't seem to be any need to build libxkbcommon because I do
4138         not believe it depends on anything else in the JHBuild environment.
4139
4140         * wpe/install-dependencies:
4141         * wpe/jhbuild.modules:
4142
4143 2018-04-12  Antoine Quint  <graouts@apple.com>
4144
4145         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
4146         https://bugs.webkit.org/show_bug.cgi?id=184569
4147         <rdar://problem/38671301>
4148
4149         Reviewed by Jon Lee.
4150
4151         We set the default value for the CSS Animations and CSS Transitions as Web Animations flag to true
4152         but override it to be false always in the LayoutTests/legacy-animation-engine directory.
4153
4154         * DumpRenderTree/TestOptions.h:
4155         * DumpRenderTree/mac/DumpRenderTree.mm:
4156         (shouldOverrideAndDisableCSSAnimationsAndCSSTransitionsBackedByWebAnimationsPreference):
4157         (runTest):
4158         * WebKitTestRunner/TestController.cpp:
4159         (WTR::TestController::resetPreferencesToConsistentValues):
4160         * WebKitTestRunner/TestOptions.cpp:
4161         (WTR::isLegacyAnimationEngineTestPath):
4162         (WTR::TestOptions::TestOptions):
4163         * WebKitTestRunner/TestOptions.h:
4164
4165 2018-04-13  Carlos Garcia Campos  <cgarcia@igalia.com>
4166
4167         [GLIB] Tests WTF_RefPtr.ReleaseInNonMainThread and WTF_RefPtr.ReleaseInNonMainThreadDestroyInMainThread are crashing since they were added
4168         https://bugs.webkit.org/show_bug.cgi?id=184531
4169
4170         Reviewed by Michael Catanzaro.
4171
4172         It's not a bug in WebKit, but in the tests. The problem is that those tests are using RunLoop::main() but main
4173         run loop hasn't been initialized. ReleaseInNonMainThread doesn't really need to initialize the main run loop if
4174         we change Util::run() to always use RunLop::current() instead of RunLoop::main(). But
4175         ReleaseInNonMainThreadDestroyInMainThread ends up scheduling a task to the main thread, and the generic
4176         implementation fo that uses RunLoop::main(), so we need to initialize the main loop in this case.
4177
4178         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
4179         (TestWebKitAPI::TEST): Call RunLoop::initializeMainRunLoop().
4180         * TestWebKitAPI/glib/UtilitiesGLib.cpp:
4181         (TestWebKitAPI::Util::run): Use RunLop::current() to stop the current run loop.
4182         (TestWebKitAPI::Util::sleep): Ditto.
4183
4184 2018-04-12  Zalan Bujtas  <zalan@apple.com>
4185
4186         [LayoutReloaded] Add support for incremental layout
4187         https://bugs.webkit.org/show_bug.cgi?id=184578
4188
4189         Reviewed by Antti Koivisto.
4190
4191         * LayoutReloaded/Layout.js:
4192         (layout):
4193         * LayoutReloaded/LayoutState.js:
4194         (LayoutState.prototype.rootContainer):
4195         (LayoutState.prototype.setNeedsLayoutById):
4196         * LayoutReloaded/Utils.js:
4197         (Utils.layoutTreeDump):
4198         * LayoutReloaded/test/TestHarness.js:
4199         (verifyLayout):
4200         (runLayout):
4201         (verifyLayoutTreeDump): Deleted.
4202         * LayoutReloaded/test/index.html:
4203         * LayoutReloaded/test/simple-incremental-layout-with-static-content.html: Added.
4204
4205 2018-04-12  Zalan Bujtas  <zalan@apple.com>
4206
4207         [LayoutReloaded] Move root container ownership to layout state
4208         https://bugs.webkit.org/show_bug.cgi?id=184575
4209
4210         Reviewed by Antti Koivisto.
4211
4212         Now the root container is on the associated layout state (ICB only at this point though).
4213
4214         * LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
4215         (BlockFormattingContext.prototype.layout):
4216         * LayoutReloaded/FormattingContext/FormattingContext.js:
4217         (FormattingContext.prototype._layoutOutOfFlowDescendants):
4218         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
4219         (InlineFormattingContext.prototype._handleInlineBlockContainer):
4220         (InlineFormattingContext.prototype._handleFloatingBox):
4221         * LayoutReloaded/Layout.js:
4222         (layout):
4223         * LayoutReloaded/LayoutState.js:
4224         (LayoutState):
4225         (LayoutState.prototype.formattingContext):
4226         (LayoutState.prototype.establishedFormattingState):
4227         (LayoutState.prototype.formattingStateForBox):
4228         (LayoutState.prototype.needsLayout):
4229         (LayoutState.prototype.displayBox):
4230         (LayoutState.prototype._formattingContext):
4231         (LayoutState.prototype.layout): Deleted.
4232         (LayoutState.prototype.formattingStates): Deleted.
4233         (LayoutState.prototype.initialDisplayBox): Deleted.
4234         * LayoutReloaded/Utils.js:
4235         (Utils._dumpBox):
4236         (Utils._findDisplayBox): Deleted.
4237
4238 2018-04-12  Jonathan Bedard  <jbedard@apple.com>
4239
4240         Fix --build-directory flag for run-webkit-tests
4241         https://bugs.webkit.org/show_bug.cgi?id=184545
4242         <rdar://problem/39385080>
4243
4244         Rubber-stamped by Aakash Jain.
4245
4246         The --build-directory path does not work with iOS-Simulator.
4247
4248         * Scripts/webkitpy/port/base.py:
4249         (Port._build_path): Use the port configuration to calculate the root directory.
4250         * Scripts/webkitpy/port/base_unittest.py:
4251         (PortTest.test_build_path): Test build directories for embedded configurations.
4252
4253 2018-04-12  Ross Kirsling  <ross.kirsling@sony.com>
4254
4255         pemfile.py should not assume POSIX line endings
4256         https://bugs.webkit.org/show_bug.cgi?id=184507
4257
4258         Reviewed by Daniel Bates.
4259
4260         * Scripts/webkitpy/common/system/pemfile.py:
4261         (_parse_pem_format):
4262         * Scripts/webkitpy/common/system/pemfile_unittest.py:
4263         (PemFileTest.test_parse_crlf):
4264         (PemFileTest.test_parse_cr):
4265
4266 2018-04-12  Zalan Bujtas  <zalan@apple.com>
4267
4268         [LayoutReloaded] Minor cleanup in LayoutSate
4269         https://bugs.webkit.org/show_bug.cgi?id=184546
4270
4271         Reviewed by Antti Koivisto.
4272
4273         * LayoutReloaded/FormattingContext/FormattingContext.js:
4274         (FormattingContext.isInFormattingContext):
4275         * LayoutReloaded/FormattingState/FormattingState.js:
4276         (FormattingState.prototype.displayBoxes):
4277         (FormattingState.prototype.displayBox):
4278         (FormattingState.prototype._markSubTreeNeedsLayout):
4279         (FormattingState):
4280         (FormattingState.prototype.displayBoxMap): Deleted.
4281         * LayoutReloaded/LayoutState.js:
4282         (LayoutState.prototype.formattingStateForBox):
4283         (LayoutState.prototype.needsLayout):
4284         (LayoutState.prototype.displayBox):
4285         (LayoutState.prototype._createFormattingState):
4286         (LayoutState):
4287         * LayoutReloaded/LayoutTree/Box.js:
4288         (Layout.Box.prototype.isFormattingContextDescendant): Deleted.
4289         * LayoutReloaded/LayoutTree/Container.js:
4290         (Layout.Container.prototype.isContainingBlockDescendant): Deleted.
4291         * LayoutReloaded/Utils.js:
4292         (Utils._findDisplayBox):
4293
4294 2018-04-12  Zalan Bujtas  <zalan@apple.com>
4295
4296         [LayoutReloaded] Introduce needsLayout to InlineFormattingContext
4297         https://bugs.webkit.org/show_bug.cgi?id=184538
4298
4299         Reviewed by Antti Koivisto.
4300
4301         * LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
4302         (BlockFormattingContext.prototype._adjustBottomWithFIXME):
4303         (BlockFormattingContext):
4304         (BlockFormattingContext.prototype._firstInFlowChildWithNeedsLayout): Deleted.
4305         (BlockFormattingContext.prototype._nextInFlowSiblingWithNeedsLayout): Deleted.
4306         * LayoutReloaded/FormattingContext/FormattingContext.js:
4307         (FormattingContext.prototype._firstInFlowChildWithNeedsLayout):
4308         (FormattingContext.prototype._nextInFlowSiblingWithNeedsLayout):
4309         (FormattingContext):
4310         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
4311         (InlineFormattingContext.prototype.layout):
4312         (InlineFormattingContext.prototype._handleInlineContainer):
4313         (InlineFormattingContext.prototype._handleInlineBlockContainer):
4314         (InlineFormattingContext.prototype._handleInlineContent):
4315         (InlineFormattingContext.prototype._clearAndMoveToNext):
4316         (InlineFormattingContext):
4317
4318 2018-04-12  Xabier Rodriguez Calvar  <calvaris@igalia.com>
4319