Unreviewed, another attempt to fix the Windows build after r227479.
[WebKit-https.git] / Tools / ChangeLog
1 2018-01-22  Ryosuke Niwa  <rniwa@webkit.org>
2
3         Mac Sierra perf bots have been failing due to CG errors
4         https://bugs.webkit.org/show_bug.cgi?id=181955
5
6         Reviewed by Antti Koivisto.
7
8         Ignore the CoreGraphics error messages on macOS Sierra.
9
10         Also added tests for ignoring lines in stdout and stderr.
11
12         * Scripts/webkitpy/performance_tests/perftest.py:
13         (PerfTest.run_failed): Refactored for clarity.
14         (PerfTest):
15         (PerfTest.filter_ignored_lines): Added.
16         (PerfTest._lines_to_ignore): Renamed from _lines_to_ignore_in_parser_result since these regular expressions
17         are now used to ignore lines in other kinds of tests than parser tests.
18         (PerfTest._errors_to_ignore_in_sierra): Added.
19         (PerfTest._filter_output): Added the code to ignore errors only on macOS Sierra.
20         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
21         (test_parse_output_with_ignored_stdout): Added.
22         (test_parse_output_with_ignored_stderr): Added.
23         (test_parse_output_with_ignored_stderr.MockPortWithSierraName): Added.
24
25 2018-01-23  Eric Carlson  <eric.carlson@apple.com>
26
27         Resign NowPlaying status when no media element is eligible
28         https://bugs.webkit.org/show_bug.cgi?id=181914
29         <rdar://problem/35294116>
30
31         Reviewed by Jer Noble.
32
33         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
34         (-[NowPlayingTestWebView hasActiveNowPlayingSession]):
35         (TestWebKitAPI::TEST):
36         * TestWebKitAPI/Tests/WebKitCocoa/large-video-test-now-playing.html:
37
38 2018-01-23  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
39
40         [WinCairo] Use 64-bit toolset
41         https://bugs.webkit.org/show_bug.cgi?id=181979
42
43         Reviewed by Alex Christensen.
44
45         Use 64-bit toolset for 64-bit build in order to improve build time. 
46
47         * Scripts/webkitdirs.pm:
48         (generateBuildSystemFromCMakeProject):
49
50 2018-01-23  Simon Fraser  <simon.fraser@apple.com>
51
52         Element with position:fixed stops scrolling at the bottom of the page, but is painted in the right place on Chacos.com.
53         https://bugs.webkit.org/show_bug.cgi?id=181741
54         rdar://problem/36593581
55
56         Reviewed by Tim Horton.
57         
58         If zoomToScale:animated: is called with the current zoom level, call the callback
59         rather than doing nothing.
60
61         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
62         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
63
64 2018-01-23  Basuke Suzuki  <Basuke.Suzuki@sony.com>
65
66         Add ignore_errors keyword argument to Executive.run_command() for replacing the common pattern of error_handler usage
67         https://bugs.webkit.org/show_bug.cgi?id=180820
68
69         Reviewed by David Kilzer.
70
71         * Scripts/webkitpy/common/checkout/scm/git.py:
72         (Git.in_working_directory):
73         (Git.clone):
74         (Git.read_git_config):
75         (Git.apply_reverse_diff):
76         * Scripts/webkitpy/common/checkout/scm/scm.py:
77         (SCM.run):
78         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
79         * Scripts/webkitpy/common/checkout/scm/svn.py:
80         (SVNRepository.has_authorization_for_realm):
81         * Scripts/webkitpy/common/net/credentials_unittest.py:
82         * Scripts/webkitpy/common/system/abstractexecutive.py:
83         (AbstractExecutive.run_command):
84         * Scripts/webkitpy/common/system/executive.py:
85         (Executive.kill_process.is):
86         (Executive.running_pids):
87         (Executive.kill_all):
88         (Executive.run_command):
89         * Scripts/webkitpy/common/system/executive_mock.py:
90         (MockExecutive.run_command):
91         (MockExecutive2.run_command):
92         * Scripts/webkitpy/common/system/executive_unittest.py:
93         (ExecutiveTest.test_run_command_with_bad_command.run_bad_command):
94         * Scripts/webkitpy/common/system/platforminfo.py:
95         (PlatformInfo.xcode_sdk_version):
96         * Scripts/webkitpy/layout_tests/servers/http_server.py:
97         (Lighttpd._check_and_kill):
98         * Scripts/webkitpy/port/base.py:
99         (Port._symbols_string):
100         * Scripts/webkitpy/port/gtk.py:
101         (GtkPort.setup_environ_for_server):
102         * Scripts/webkitpy/port/win.py:
103         (WinPort._runtime_feature_list):
104         (WinPort.read_registry_value):
105         * Scripts/webkitpy/port/win_unittest.py:
106         (WinPortTest.test_runtime_feature_list):
107         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
108         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py:
109
110 2018-01-23  Commit Queue  <commit-queue@webkit.org>
111
112         Unreviewed, rolling out r227279 and r227373.
113         https://bugs.webkit.org/show_bug.cgi?id=181988
114
115         The LayoutTest crash fix introduced an API test failure.
116         (Requested by ryanhaddad on #webkit).
117
118         Reverted changesets:
119
120         "Resign NowPlaying status when no media element is eligible"
121         https://bugs.webkit.org/show_bug.cgi?id=181914
122         https://trac.webkit.org/changeset/227279
123
124         "Resign NowPlaying status when no media element is eligible"
125         https://bugs.webkit.org/show_bug.cgi?id=181914
126         https://trac.webkit.org/changeset/227373
127
128 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
129
130         Unreviewed. Add test case for slow in test_expectations.py.
131
132         I forgot to also check slow tests in test_expectations.py unit tests.
133
134         * Scripts/webkitpy/common/test_expectations_unittest.py:
135         (assert_slow):
136         (test_build_type):
137         (test_slow):
138
139 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
140
141         Unreviewed. Mark test WTF_Lock.ManyContendedShortSections as slow.
142
143         * TestWebKitAPI/glib/TestExpectations.json:
144
145 2018-01-22  Ryosuke Niwa  <rniwa@webkit.org>
146
147         Blob conversion and sanitization doesn't work with Microsoft Word for Mac 2011
148         https://bugs.webkit.org/show_bug.cgi?id=181616
149         <rdar://problem/36484908>
150
151         Reviewed by Wenson Hsieh.
152
153         Added tests to make sure we sanitize plain HTML, not just web archives,
154         when and only when custom pasteboard data is enabled.
155
156         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
157         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm: Added.
158         (writeHTMLToPasteboard): Added.
159         (createWebViewWithCustomPasteboardDataSetting): Added.
160
161 2018-01-22  Alexey Proskuryakov  <ap@apple.com>
162
163         REGRESSION (r226485): Many new wasm leaks detected by the leaks bot
164         https://bugs.webkit.org/show_bug.cgi?id=181400
165         rdar://problem/36358768
166
167         Reviewed by JF Bastien.
168
169         * BuildSlaveSupport/build.webkit.org-config/config.json: Disable poisoning on the leaks bot.
170
171 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
172
173         [GTK] Test /webkit/WebKitWebsiteData/resource-load-statistics is failing since r227223
174         https://bugs.webkit.org/show_bug.cgi?id=181929
175
176         Reviewed by Michael Catanzaro.
177
178         The test is checking that the resource load stats file is deleted after clearing website data. Since r227223,
179         the website data completion callback is not called immediately, and a new file is created when the operation
180         finishes. We need to check that the file was removing after calling clear.
181
182         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
183         (fileChangedCallback):
184         (testWebsiteDataResourceLoadStatistics):
185
186 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
187
188         Reviewed GTK gardening. Mark /webkit/WebKitWebView/mouse-target as fail too.
189
190         * TestWebKitAPI/glib/TestExpectations.json:
191
192 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
193
194         Unreviewed GTK+ gardening. Fix /webkit/WebKitConsoleMessage/network-error.
195
196         Partially revert r226782, the fix was wrong for the GLib version we currently use.
197
198         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
199         (testWebKitConsoleMessageNetworkError):
200
201 2018-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
202
203         Unreviewed. Remove unused verbose mode from GLib API tests runner.
204
205         * glib/api_test_runner.py:
206         (add_options):
207
208 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
209
210         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
211         https://bugs.webkit.org/show_bug.cgi?id=181918
212
213         Reviewed by Tim Horton.
214
215         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
216
217         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
218
219 2018-01-21  Eric Carlson  <eric.carlson@apple.com>
220
221         Resign NowPlaying status when no media element is eligible
222         https://bugs.webkit.org/show_bug.cgi?id=181914
223         <rdar://problem/35294116>
224
225         Reviewed by Jer Noble.
226
227         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
228         (-[NowPlayingTestWebView hasActiveNowPlayingSession]):
229         (TestWebKitAPI::TEST):
230         * TestWebKitAPI/Tests/WebKitCocoa/large-video-test-now-playing.html:
231
232 2018-01-21  Aakash Jain  <aakash_jain@apple.com>
233
234         Fix broken unit-tests after r227192
235         https://bugs.webkit.org/show_bug.cgi?id=181909
236
237         Reviewed by Carlos Garcia Campos.
238
239         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
240
241 2018-01-20  Chris Dumez  <cdumez@apple.com>
242
243         API test URLSchemeHandler.Leaks1 is timing out on iOS simulator debug
244         https://bugs.webkit.org/show_bug.cgi?id=174984
245         <rdar://problem/33665676>
246
247         Reviewed by Alexey Proskuryakov.
248
249         Disable URLSchemeHandler.Leaks1 API test on iOS as it sometimes times out.
250
251         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-leaks.mm:
252         (TEST):
253
254 2018-01-20  Brian Burg  <bburg@apple.com>
255
256         WebDriver: fix some nits that prevent running W3C tests on Mac
257         https://bugs.webkit.org/show_bug.cgi?id=181864
258
259         Reviewed by Carlos Garcia Campos.
260
261         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
262         (WebDriverW3CWebServer.__init__): _wsout needs to always be defined,
263         as we assume that the property exists later.
264
265         (WebDriverW3CWebServer.stop): If the temporary file doesn't
266         exist for some reason, the remove call will raise and exception.
267         Gracefully handle the case where the file isn't created due to
268         a problem/exception that happened elsewhere.
269
270 2018-01-19  Ling Ho  <lingcherd_ho@apple.com>
271
272         Move Bingdings EWS and Webkitpy EWS queues to High Sierra on buildbot dashboard.
273         https://bugs.webkit.org/show_bug.cgi?id=181881
274
275         Reviewed by Alexey Proskuryakov.
276
277         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
278         (BubbleQueueServer):
279         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
280         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
281         (table.queue-grid tr.platform.mac-os-x-elcapitan img.logo): Deleted.
282
283 2018-01-19  Youenn Fablet  <youenn@apple.com>
284
285         Do not go to the storage process when registering a service worker client if there is no service worker registered
286         https://bugs.webkit.org/show_bug.cgi?id=181740
287         <rdar://problem/36650400>
288
289         Reviewed by Chris Dumez.
290
291         Add support for internals inside API tests.
292
293         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
294         * TestWebKitAPI/Tests/InjectInternals_Bundle.cpp: Added.
295         (TestWebKitAPI::InternalsInjectedBundleTest::InternalsInjectedBundleTest):
296         (TestWebKitAPI::InternalsInjectedBundleTest::initialize):
297         (TestWebKitAPI::InternalsInjectedBundleTest::didCreatePage):
298         (TestWebKitAPI::InternalsInjectedBundleTest::didClearWindowForFrame):
299         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
300         (setConfigurationInjectedBundlePath):
301         (-[RegularPageMessageHandler userContentController:didReceiveScriptMessage:]):
302
303 2018-01-19  John Wilander  <wilander@apple.com>
304
305         Resource Load Statistics: Implement callback support for removal of WebsiteDataType::ResourceLoadStatistics
306         https://bugs.webkit.org/show_bug.cgi?id=181822
307         https://bugs.webkit.org/show_bug.cgi?id=175263
308         https://bugs.webkit.org/show_bug.cgi?id=178536
309         https://bugs.webkit.org/show_bug.cgi?id=181223
310         https://bugs.webkit.org/show_bug.cgi?id=181482
311         <rdar://problem/33491222>
312         <rdar://problem/33805293>
313         <rdar://problem/36332683>
314         <rdar://problem/36549026>
315
316         Reviewed by Alex Christensen.
317
318         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
319         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
320         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
321         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
322         * WebKitTestRunner/InjectedBundle/TestRunner.h:
323         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
324         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
325         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
326
327 2018-01-19  Jonathan Bedard  <jbedard@apple.com>
328
329         run-webkit-tests fails when there is a curly brace in Xcode build output
330         https://bugs.webkit.org/show_bug.cgi?id=181254
331         <rdar://problem/36453374>
332
333         Reviewed by Daniel Bates.
334
335         * Scripts/webkitpy/port/base.py:
336         (Port._run_script): Encode script output before logging it.
337
338 2018-01-19  Chris Dumez  <cdumez@apple.com>
339
340         Service worker registrations restored from disk may not be reused when the JS calls register() again
341         https://bugs.webkit.org/show_bug.cgi?id=181810
342         <rdar://problem/36591711>
343
344         Reviewed by Youenn Fablet.
345
346         Add API test coverage.
347
348         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
349         (-[SWMessageHandlerForRestoreFromDiskTest initWithExpectedMessage:]):
350         (-[SWMessageHandlerForRestoreFromDiskTest userContentController:didReceiveScriptMessage:]):
351
352 2018-01-19  Ryan Haddad  <ryanhaddad@apple.com>
353
354         Remove El Capitan queues from flakiness dashboard
355         https://bugs.webkit.org/show_bug.cgi?id=181860
356
357         Reviewed by Aakash Jain.
358
359         * TestResultServer/static-dashboards/builders.jsonp:
360
361 2018-01-19  Keith Miller  <keith_miller@apple.com>
362
363         HaveInternalSDK includes should be "#include?"
364         https://bugs.webkit.org/show_bug.cgi?id=179670
365
366         Reviewed by Dan Bernstein.
367
368         * MiniBrowser/Configurations/Base.xcconfig:
369         * MobileMiniBrowser/Configurations/Base.xcconfig:
370         * TestWebKitAPI/Configurations/Base.xcconfig:
371         * WebKitTestRunner/Configurations/Base.xcconfig:
372
373 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
374
375         WebDriver: driver environment not passed to pytest when running w3c tests
376         https://bugs.webkit.org/show_bug.cgi?id=181852
377
378         Reviewed by Carlos Alberto Lopez Perez.
379
380         That's why color codes are not used in the bots log for selenium tests but they appear in w3c tests.
381
382         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
383         (WebDriverW3CExecutor.run):
384
385 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
386
387         [GTK] WebDriver: wayland display no used in wayland bot
388         https://bugs.webkit.org/show_bug.cgi?id=181851
389
390         Reviewed by Carlos Alberto Lopez Perez.
391
392         We need to handle the additionalArguments property in the WebDriverTests step.
393
394         * BuildSlaveSupport/build.webkit.org-config/steps.py:
395         (RunWebDriverTests.start):
396
397 2018-01-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
398
399         [GTK] TERM environment variable is not passed to the test driver.
400         https://bugs.webkit.org/show_bug.cgi?id=181847
401
402         Rubber-stamped by by Carlos Garcia Campos.
403
404         * Scripts/webkitpy/port/base.py:
405         (Port.to.setup_environ_for_server):
406
407 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
408
409         WebDriver: run-webdriver-tests is crashing in the bots when creating results json file
410         https://bugs.webkit.org/show_bug.cgi?id=181844
411
412         Reviewed by Carlos Alberto Lopez Perez.
413
414         We always try to create the directory where to store the json file, but when the filename is given directly,
415         like in the bots, the current dir is used.
416
417         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
418         (WebDriverTestRunner.dump_results_to_json_file): Do not try to create the directory if dirname() returns an
419         empty string.
420
421 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
422
423         [GTK] WebDriver tests are running outside the jhbuild env
424         https://bugs.webkit.org/show_bug.cgi?id=181842
425
426         Reviewed by Žan Doberšek.
427
428         We need to enter jhbuild env in run-webdriver-tests.
429
430         * Scripts/run-webdriver-tests:
431
432 2018-01-18  Carlos Garcia Campos  <cgarcia@igalia.com>
433
434         [GTK] Run WebDriver tests in the bots
435         https://bugs.webkit.org/show_bug.cgi?id=181787
436
437         Reviewed by Michael Catanzaro.
438
439         Add a step to run WebDriver tests in the GTK test bots. The new step is not GTK specific, but only added to the
440         factory for the GTK port for now.
441
442         * BuildSlaveSupport/build.webkit.org-config/factories.py:
443         (TestFactory.__init__):
444         * BuildSlaveSupport/build.webkit.org-config/steps.py:
445         (RunWebDriverTests):
446         (RunWebDriverTests.start):
447         (RunWebDriverTests.commandComplete):
448         (RunWebDriverTests.evaluateCommand):
449         (RunWebDriverTests.getText):
450         (RunWebDriverTests.getText2):
451
452 2018-01-18  Basuke Suzuki  <Basuke.Suzuki@sony.com>
453
454         [WinCairo] Pass correct url for http test to test driver.
455         https://bugs.webkit.org/show_bug.cgi?id=181814
456
457         Reviewed by Alex Christensen.
458
459         * Scripts/webkitpy/port/driver.py:
460         (Driver):
461         (Driver.http_test_path_to_uri):
462         (Driver.is_secure_path):
463         (Driver.http_base_url):
464         (Driver.uri_to_test):
465
466 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
467
468         Unreviewed, update the triggerable name for 'sierra-release-perf-tests'
469
470         * BuildSlaveSupport/build.webkit.org-config/config.json:
471
472 2018-01-18  Dan Bernstein  <mitz@apple.com>
473
474         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
475         https://bugs.webkit.org/show_bug.cgi?id=181803
476
477         Reviewed by Tim Horton.
478
479         * DumpRenderTree/mac/Configurations/Base.xcconfig: Updated.
480         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Ditto.
481         * ImageDiff/cg/Configurations/Base.xcconfig: Ditto.
482         * ImageDiff/cg/Configurations/DebugRelease.xcconfig: Ditto.
483         * MiniBrowser/Configurations/Base.xcconfig: Ditto.
484         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
485         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
486         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
487         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals
488           helpers.
489         * TestWebKitAPI/Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build
490           settings useful for defining settings that depend on the target macOS version.
491         * WebKitTestRunner/Configurations/Base.xcconfig: Updated.
492         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Updated.
493
494 2018-01-18  Ling Ho  <lingcherd_ho@apple.com>
495
496         Remove Opensource El Capitan queues from buildbot
497         https://bugs.webkit.org/show_bug.cgi?id=181712
498
499         Reviewed by Aakash Jain.
500
501         * BuildSlaveSupport/build.webkit.org-config/config.json:
502         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
503         (WebKitBuildbot):
504         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
505
506 2018-01-18  Chris Dumez  <cdumez@apple.com>
507
508         Service Workers restored from persistent storage have 'redundant' state
509         https://bugs.webkit.org/show_bug.cgi?id=181749
510         <rdar://problem/36556486>
511
512         Reviewed by Youenn Fablet.
513
514         Add API test coverage.
515
516         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
517         (-[SWMessageHandlerForFetchTest userContentController:didReceiveScriptMessage:]):
518
519 2018-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
520
521         [GTK] AX: Two layout tests crash with error 'g_strstr_len: assertion 'haystack != NULL' failed' in Accessibility::UIElement::url
522         https://bugs.webkit.org/show_bug.cgi?id=176796
523
524         Reviewed by Chris Fleizach.
525
526         Add sanity check that we have a URL before calling g_strstr_len().
527
528         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
529         (WTR::AccessibilityUIElement::url):
530
531 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
532
533         Add triggers for Sierra test262 and perf queues
534         https://bugs.webkit.org/show_bug.cgi?id=181799
535
536         Reviewed by Aakash Jain.
537
538         * BuildSlaveSupport/build.webkit.org-config/config.json:
539
540 2018-01-18  Wenson Hsieh  <wenson_hsieh@apple.com>
541
542         [iOS] Specify -[NSURL _title] for the associated URL when copying an image element
543         https://bugs.webkit.org/show_bug.cgi?id=181783
544         <rdar://problem/35785445>
545
546         Reviewed by Ryosuke Niwa.
547
548         Augments an existing API test and adds a new test to make sure that the resulting NSItemProvider's NSURL when
549         copying an image contains a relevant title.
550
551         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
552         (TestWebKitAPI::TEST):
553         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
554         * TestWebKitAPI/ios/UIKitSPI.h:
555
556 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
557
558         WebDriver: ignore the driver in selenium test names when getting expectations
559         https://bugs.webkit.org/show_bug.cgi?id=181738
560
561         Reviewed by Carlos Alberto Lopez Perez.
562
563         In selenium tests, the driver is added as a parameter to every test which results in tests names like
564         foo[DriverName] or foo[DriverName-param2] in case of tests using more parameters. We don't want to include the
565         driver name in the test expectations file, so we need to remove it when querying the expectations.
566
567         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
568         (TestExpectationsMarker.__init__): Save the param to ignore.
569         (TestExpectationsMarker._item_name): Return the name of the test without the para to ignore.
570         (TestExpectationsMarker.pytest_collection_modifyitems): Use _item_name().
571         (run): Pass param to ignore to TestExpectationsMarker().
572         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
573         (WebDriverSeleniumExecutor.__init__): Save the driver name.
574         (WebDriverSeleniumExecutor.run): Pass the driver name as param to ignore.
575
576 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
577
578         [GTK][WPE] Show unit tests unexpectedly passing in the bots
579         https://bugs.webkit.org/show_bug.cgi?id=181726
580
581         Reviewed by Michael Catanzaro.
582
583         Now that we have the info, let's show it also in the bots.
584
585         * BuildSlaveSupport/build.webkit.org-config/steps.py:
586         (RunGLibAPITests.commandComplete):
587
588 2018-01-17  Ling Ho  <lingcherd_ho@apple.com>
589
590         Fix broken unittest after r227048
591         https://bugs.webkit.org/show_bug.cgi?id=181760
592
593         Reviewed by Aakash Jain.
594
595
596 2018-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
597
598         WEBKIT_FRAMEWORK should not modify file-global include directories
599         https://bugs.webkit.org/show_bug.cgi?id=181656
600
601         Reviewed by Konstantin Tokarev.
602
603         * TestWebKitAPI/PlatformWPE.cmake:
604         * TestWebKitAPI/glib/CMakeLists.txt:
605
606 2018-01-17  Alicia Boya García  <aboya@igalia.com>
607
608         Unreviewed, mark Alicia as committer in contributors.json
609
610         * Scripts/webkitpy/common/config/contributors.json:
611
612 2018-01-17  Youenn Fablet  <youenn@apple.com>
613
614         Put fetch Request.keepalive behind a runtime flag
615         https://bugs.webkit.org/show_bug.cgi?id=181592
616
617         Reviewed by Chris Dumez.
618
619         * DumpRenderTree/mac/DumpRenderTree.mm:
620         (enableExperimentalFeatures):
621         * DumpRenderTree/win/DumpRenderTree.cpp:
622         (enableExperimentalFeatures):
623         * WebKitTestRunner/TestController.cpp:
624         (WTR::TestController::resetPreferencesToConsistentValues):
625
626 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
627
628         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
629         https://bugs.webkit.org/show_bug.cgi?id=181637
630         <rdar://problem/36508471>
631
632         Reviewed by Tim Horton.
633
634         Add 2 new API tests to exercise injected bundle SPI for supplying replacement URLs when pasting an image, and an
635         attributed string containing multiple NSTextAttachments. See WebKit and WebCore ChangeLogs for more detail.
636
637         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
638         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
639         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]):
640
641         Implement the new Objective-C bundle SPI to look up the incoming MIME type in the dictionary supplied via the
642         "MIMETypeToReplacementURLMap" bundle initialization parameter, and return it.
643
644         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
645         (webViewForTestingAttachments):
646         (-[TestWKWebView tagsInBody]):
647         (-[TestWKWebView expectElementTagsInOrder:]):
648         (-[TestWKWebView expectElementTag:toComeBefore:]):
649
650         Add a test helper to check that the given list of element tags appears in the document body. Also, reimplement
651         the existing -expectElementTag:toComeBefore: as a special case of -expectElementTagsInOrder:.
652
653         (TestWebKitAPI::TEST):
654         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
655         (WTR::InjectedBundlePage::InjectedBundlePage):
656
657 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
658
659         WebDriver: add support for test expectations
660         https://bugs.webkit.org/show_bug.cgi?id=180420
661
662         Reviewed by Carlos Alberto Lopez Perez.
663
664         Add support for parsing test expectations from a JSON file and mark tests on collection accordingly.
665
666         * Scripts/run-webdriver-tests: Get the retval from process_results().
667         * Scripts/webkitpy/thirdparty/__init__.py:
668         (AutoinstallImportHook._install_pytest): Install also py because pytest needs it.
669         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
670         (TestExpectationsMarker): Plugin to mark tests based on given expectations.
671         (TestExpectationsMarker.__init__): Initialize expectations.
672         (TestExpectationsMarker.pytest_collection_modifyitems): Mark tests if needed,
673         (run): Create and use TestExpectationsMarker plugin.
674         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
675         (WebDriverSeleniumExecutor.run): Pass expectations to pytest_runner.
676         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
677         (WebDriverTestRunner.__init__): Create a TestExpectations and pass it to the runners.
678         (WebDriverTestRunner.run): Do not count results here.
679         (WebDriverTestRunner.process_results): Rename print_results() as process_results() since it now returns the
680         amount of failures. Printing the test summary while processing results will be made optional in a follow up
681         patch.
682         (WebDriverTestRunner.process_results.report): Return the amount of failures.
683         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
684         (WebDriverTestRunnerSelenium.__init__): Initialize _expectations.
685         (WebDriverTestRunnerSelenium.collect_tests): Do not include skipped tests.
686         (WebDriverTestRunnerSelenium.run): Stop returning the tests count.
687         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
688         (WebDriverTestRunnerW3C.__init__): Initialize _expectations.
689         (WebDriverTestRunnerW3C.collect_tests): Do not include skipped tests.
690         (WebDriverTestRunnerW3C._scan_directory): Ditto.
691         (WebDriverTestRunnerW3C.run): Stop returning the tests count.
692         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
693         (WebDriverW3CExecutor.run): Pass expectations to pytest_runner.
694
695 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
696
697         Unreviewed WPE gardening. Mark some known unit test failures.
698
699         * TestWebKitAPI/glib/TestExpectations.json:
700
701 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
702
703         [GTK][WPE] Use the same subtest names in GTK and WPE unit tests
704         https://bugs.webkit.org/show_bug.cgi?id=181724
705
706         Reviewed by Philippe Normand.
707
708         We currently use /webkit2/foo/bar for GTK and /wpe/foo/bar for WPE. Many of the tests are common, so there's no
709         reason to use different names. This way we can refer to the same test names for both and we can share the
710         expectations in the TestExpectations.json file.
711
712         * TestWebKitAPI/glib/TestExpectations.json:
713         * TestWebKitAPI/glib/WebKitGLib/TestMain.h: Use /webkit/foo/bar in GTK and WPE.
714
715 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
716
717         Unreviewed. Increase the slow timeout of GTK and WPE unit tests.
718
719         We are using now a lower default timeout, so multiplying by 5 is no longer enough for some of the WTF
720         tests. Multiply by 10 so that we get the same slow timeout as before, 50.
721
722         * glib/api_test_runner.py:
723         (TestRunner._run_test_glib):
724         (TestRunner._run_google_test):
725
726 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
727
728         [GTK] Duplicated symbols in libjavascriptcoregtk and libwebkit2gtk can cause crashes in production builds
729         https://bugs.webkit.org/show_bug.cgi?id=179914
730
731         Reviewed by Žan Doberšek.
732
733         Add two scripts to be run by dist-check step when releasing. One is to detect symbols duplicated in
734         libjavascriptcoregtk and libwebkit2gtk that should be included to the version script. The other one is to ensure
735         all symbols listed in the script are present in the library.
736
737         * Scripts/check-for-global-bss-symbols-in-webkigtk-libs: Added.
738         (bss_symbols):
739         * Scripts/check-for-invalid-symbols-in-version-script: Added.
740         (script_symbols):
741         * Scripts/make-dist:
742         (Distcheck.build):
743         (Distcheck):
744         (Distcheck.check_symbols):
745         (Distcheck.check):
746
747 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
748
749         [GTK][WPE] Propagate the parameters when restarting glib api tests after a crash
750         https://bugs.webkit.org/show_bug.cgi?id=181722
751
752         Reviewed by Žan Doberšek.
753
754         I forgot to pass the parameters to run() when restarting.
755
756         * glib/glib_test_runner.py:
757         (GLibTestRunner.run):
758
759 2018-01-16  Fujii Hironori  <Hironori.Fujii@sony.com>
760
761         [CMake] Remove WebCoreDerivedSources library target
762         https://bugs.webkit.org/show_bug.cgi?id=181664
763
764         Reviewed by Carlos Garcia Campos.
765
766         * TestWebKitAPI/PlatformWPE.cmake: Do not link WebCoreDerivedSources.
767         * TestWebKitAPI/PlatformWin.cmake: Ditto.
768
769 2018-01-16  Ling Ho  <lingcherd_ho@apple.com>
770
771         Move Debug Test262, Release Test262 and Performance queues to Sierra
772         https://bugs.webkit.org/show_bug.cgi?id=181692
773
774         Unreviewed
775
776 2018-01-16  Zach Li  <zachli@apple.com>
777
778         Add pop-up policy support in website policies.
779         https://bugs.webkit.org/show_bug.cgi?id=181544.
780         rdar://problem/30521400.
781
782         Reviewed by Alex Christensen.
783
784         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
785         Added pop-up-check.html.
786
787         * TestWebKitAPI/Tests/WebKit/pop-up-check.html: Added.
788
789         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
790         (-[PopUpPoliciesDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
791         (-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
792         (-[PopUpPoliciesDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
793         (TEST):
794
795 2018-01-16  Wenson Hsieh  <wenson_hsieh@apple.com>
796
797         [Attachment Support] Provide the `src` of an attachment to the UI delegate when an attachment is inserted
798         https://bugs.webkit.org/show_bug.cgi?id=181638
799         <rdar://problem/36508702>
800
801         Reviewed by Dan Bernstein.
802
803         Tweak an existing API test to check that the `src` of an attachment element inserted via script matches the
804         `source` provided to the UI delegate via -[WKUIDelegate _webView:didInsertAttachment:withSource:].
805
806         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
807         (-[AttachmentUpdateObserver init]):
808         (-[AttachmentUpdateObserver sourceForIdentifier:]):
809         (-[AttachmentUpdateObserver _webView:didInsertAttachment:withSource:]):
810         (TestWebKitAPI::ObserveAttachmentUpdatesForScope::expectSourceForIdentifier):
811         (TestWebKitAPI::TEST):
812         (-[AttachmentUpdateObserver _webView:didInsertAttachment:]): Deleted.
813
814 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
815
816         Unreviewed. Fix GTK unit tests execution in the bots after r226967.
817
818         I forgot to pass the environment to the GLibTestRunner and Xvfb was not used in the bots.
819
820         * glib/api_test_runner.py:
821         (TestRunner._run_test_glib): Pass env to GLibTestRunner.
822         * glib/glib_test_runner.py:
823         (GLibTestRunner.run): Use given env.
824
825 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
826
827         [GTK][WPE] Stop passing --verbose to run-api-tests from the bots
828         https://bugs.webkit.org/show_bug.cgi?id=181676
829
830         Reviewed by Carlos Alberto Lopez Perez.
831
832         The option was removed in r226967.
833
834         * BuildSlaveSupport/build.webkit.org-config/steps.py:
835         (RunGtkAPITests):
836         (RunWPEAPITests):
837
838 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
839
840         Unreviewed. Temporarily bring back --verbose option of api_test_runner.py.
841
842         The bots are still passing that option and the step is failing because it was removed in r226967.
843
844         * glib/api_test_runner.py:
845         (add_options):
846
847 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
848
849         [GTK][WPE] Improve the way glib tests are run
850         https://bugs.webkit.org/show_bug.cgi?id=181674
851
852         Reviewed by Žan Doberšek.
853
854         Stop using gtester external program and use our own tester from python directly. This way we no longer need to
855         parse the tests output to get the results which is causing problems in WPE bot. We can now differentiate between
856         tests failing due to an expected assert in the test and unexpected crashes.
857         This also fixes a bug in previous code where we failed to properly detect tests timing out, because gtester was
858         not showing the subtest name in stdout in case of timeouts.
859         I've lowered the default timeout from 10 to 5, since we are now properly handling the timeout for every test
860         case. I've also removed the verbose option, since it was only used by gtester and we now always show the result
861         of every test case.
862
863         * glib/api_test_runner.py:
864         (TestRunner._run_test_glib): Use GLibTestRunner.
865         (TestRunner._run_google_test): Wrote tests timing out to stdout too.
866         (add_options):
867         * glib/glib_test_runner.py: Added.
868         (TestTimeout):
869         (Message):
870         (Message.__init__):
871         (Message.create):
872         (Message.create.read_unsigned):
873         (Message.create.read_double):
874         (Message.create.read_string):
875         (GLibTestRunner):
876         (GLibTestRunner.__init__):
877         (GLibTestRunner._process_data):
878         (GLibTestRunner._process_message):
879         (GLibTestRunner._read_from_pipe):
880         (GLibTestRunner._read_from_stderr):
881         (GLibTestRunner._start_timeout):
882         (GLibTestRunner._start_timeout._alarm_handler):
883         (GLibTestRunner._stop_timeout):
884         (GLibTestRunner._subtest_start):
885         (GLibTestRunner._subtest_message):
886         (GLibTestRunner._subtest_stderr):
887         (GLibTestRunner._subtest_end):
888         (GLibTestRunner.run):
889
890 2018-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
891
892         Unreviewed, add Thibault to contributors.json
893
894         It's a bit weird to add someone here before their first contribution, but this affects
895         Bugzilla autocomplete, and that is serious business.
896
897         * Scripts/webkitpy/common/config/contributors.json:
898
899 2018-01-15  JF Bastien  <jfbastien@apple.com>
900
901         Remove makePoisonedUnique
902         https://bugs.webkit.org/show_bug.cgi?id=181630
903         <rdar://problem/36498623>
904
905         Reviewed by Mark Lam.
906
907         Update tests.
908
909         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
910         (TestWebKitAPI::TEST):
911         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
912         (TestWebKitAPI::TEST):
913
914 2018-01-15  Adrian Perez de Castro  <aperez@igalia.com>
915
916         [GTK][JHBuild] Tools/gtk/install-dependencies: Package libxfont does not exist anymore in Arch Linux
917         https://bugs.webkit.org/show_bug.cgi?id=181476
918
919         Reviewed by Michael Catanzaro.
920
921         Update to xorg-server 1.19.6 which depends on libxfont2, and change
922         the lists of packages to install libxfont2-devel (or equivalent).
923
924         * gtk/install-dependencies:
925         * gtk/jhbuild.modules:
926
927 2018-01-15  Carlos Garcia Campos  <cgarcia@igalia.com>
928
929         [GTK][WPE] Add support for unit test expectations
930         https://bugs.webkit.org/show_bug.cgi?id=181589
931
932         Reviewed by Michael Catanzaro.
933
934         We currently have a way to skip tests by annotating them in the api test runner script. The main problem of this
935         approach is that we skip tests when they fail in the bots and we never notice if they stop failing, keeping the
936         tests skipped forever. This is indeed the case of several WebKit2 C API tests. Annotating skipped tests in the
937         script itself is not a good idea either.
938
939         This patch adds a generic TestExpectations class for simple tests based on tests with subtests, like our unit
940         tests, but also WebDriver tests. It parses a json file with the tests and subtests expectations and provides
941         convenient methods to query them.
942
943         * Scripts/run-gtk-tests:
944         (GtkTestRunner): Remove all Skipped and Slow tests marked here.
945         * Scripts/run-wpe-tests:
946         (WPETestRunner): Ditto.
947         * Scripts/webkitpy/common/test_expectations.py: Added.
948         (TestExpectations):
949         (TestExpectations.__init__):
950         (TestExpectations._port_name_for_expected):
951         (TestExpectations._expected_value):
952         (TestExpectations.skipped_tests):
953         (TestExpectations.skipped_subtests):
954         (TestExpectations._expectation_value):
955         (TestExpectations.is_slow):
956         (TestExpectations.get_expectation):
957         * Scripts/webkitpy/common/test_expectations_unittest.py: Added.
958         (MockTestExpectations):
959         (MockTestExpectations.__init__):
960         (MockTestExpectations.is_skip):
961         (ExpectationsTest):
962         (assert_exp):
963         (assert_not_exp):
964         (assert_bad_exp):
965         (assert_skip):
966         (test_basic):
967         (test_skip):
968         (test_flaky):
969         (test_build_type):
970         * TestWebKitAPI/glib/TestExpectations.json: Added.
971         * glib/api_test_runner.py:
972         (TestRunner): Remove SkippedTest implementation.
973         (TestRunner.__init__): Create a TestExpectations.
974         (TestRunner._test_cases_to_skip): Use TestExpectations to check skipped tests.
975         (TestRunner._should_run_test_program): Ditto.
976         (TestRunner._run_test_glib): Use TestExpectations to check if test suite is slow.
977         (TestRunner._run_test_glib.parse_line.set_test_result): Register also tests passing.
978         (TestRunner._run_google_test): Use TestExpectations to check if test cases is slow and register tests passing.
979         (TestRunner.run_tests): Check if actual result is the expected one and register also unexpected passes.
980         (TestRunner.run_tests.report): Helper to write report to stdout.
981
982 2018-01-13  Mark Lam  <mark.lam@apple.com>
983
984         Replace all use of ConstExprPoisoned with Poisoned.
985         https://bugs.webkit.org/show_bug.cgi?id=181542
986         <rdar://problem/36442138>
987
988         Reviewed by JF Bastien.
989
990         1. Converted tests to using new uintptr_t& poison type.
991         2. Added tests for Poisoned comparison operators.
992
993         * TestWebKitAPI/CMakeLists.txt:
994         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
995         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp: Removed.
996         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
997         (TestWebKitAPI::TEST):
998         (TestWebKitAPI::initializeTestPoison): Deleted.
999         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
1000         (TestWebKitAPI::TEST):
1001         (TestWebKitAPI::passWithRef):
1002         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
1003         (TestWebKitAPI::TEST):
1004         (TestWebKitAPI::f1):
1005         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
1006         (TestWebKitAPI::TEST):
1007         (TestWebKitAPI::poisonedPtrFoo):
1008         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
1009         (TestWebKitAPI::TEST):
1010         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
1011         (TestWebKitAPI::TEST):
1012
1013 2018-01-13  David Kilzer  <ddkilzer@apple.com>
1014
1015         check-webkit-style: false positive for [whitespace/braces] with os_log format string
1016         <https://webkit.org/b/181606>
1017
1018         Reviewed by Darin Adler.
1019
1020         * Scripts/webkitpy/style/checkers/cpp.py:
1021         (check_spacing): Modify regular expression to ignore
1022         os_log format strings like '%{public}'.
1023         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1024         (CppStyleTest.test_spacing_before_braces): Add os_log
1025         format string test.
1026
1027 2018-01-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1028
1029         [macOS] API tests ChangeAttachmentDataUpdatesWithInPlaceDisplay and InPlaceVideoAttachmentInsertionWithinList are failing
1030         https://bugs.webkit.org/show_bug.cgi?id=181626
1031
1032         Reviewed by Joseph Pecoraro.
1033
1034         Make the web view for WKAttachmentTests slightly bigger to avoid size clamping behavior introduced in r226915.
1035         Additionally, write a new API test covering the change in r226915.
1036
1037         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1038         (webViewForTestingAttachments):
1039         (TestWebKitAPI::TEST):
1040
1041 2018-01-12  Alex Christensen  <achristensen@webkit.org>
1042
1043         History state should be updated during client redirects with asynchronous policy decisions
1044         https://bugs.webkit.org/show_bug.cgi?id=181358
1045         <rdar://problem/35547689>
1046
1047         Reviewed by Andy Estes.
1048
1049         * TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm:
1050         (-[AsyncPolicyDecisionDelegate webView:didFinishNavigation:]):
1051         (-[AsyncPolicyDecisionDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1052         (TEST):
1053
1054 2018-01-12  Jonathan Bedard  <jbedard@apple.com>
1055
1056         webkitpy: Refactor simulator code (Part 4)
1057         https://bugs.webkit.org/show_bug.cgi?id=180555
1058         <rdar://problem/36131381>
1059
1060         Reviewed by Aakash Jain.
1061
1062         Move new_simulated_device.py to simulated_device.py.
1063
1064         * Scripts/webkitpy/port/ios_simulator.py: Update import statement.
1065         * Scripts/webkitpy/xcode/new_simulated_device.py: Removed.
1066         * Scripts/webkitpy/xcode/new_simulated_device_unittest.py: Removed.
1067         * Scripts/webkitpy/xcode/simulated_device.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device.py.
1068         * Scripts/webkitpy/xcode/simulated_device_unittest.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device_unittest.py.
1069
1070 2018-01-12  Alex Christensen  <achristensen@webkit.org>
1071
1072         REGRESSION (r226818): API test WebKitLegacy.LoadInvalidURLRequest is failing
1073         https://bugs.webkit.org/show_bug.cgi?id=181595
1074
1075         This test was testing behavior of an invalid URL that WebCore parses but NSURL does not.
1076         It was using example.com<> but after r226479 < and > are considered invalid by WebCore.
1077         I change the < and > to $ to make this test pass and continue to test what it used to.
1078
1079         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.html:
1080         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
1081         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1082
1083 2018-01-11  Keith Miller  <keith_miller@apple.com>
1084
1085         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
1086         https://bugs.webkit.org/show_bug.cgi?id=181573
1087
1088         Reviewed by Simon Fraser.
1089
1090         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1091
1092 2018-01-11  Jiewen Tan  <jiewen_tan@apple.com>
1093
1094         [WebAuthN] Import a CBOR coder from Chromium
1095         https://bugs.webkit.org/show_bug.cgi?id=181522
1096         <rdar://problem/36055729>
1097
1098         Reviewed by Brent Fulgham.
1099
1100         This patch also imports all unit tests into our API tests to ensure all
1101         workarounds and modification against the original codebase doesn't change
1102         any original functionalities.
1103
1104         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1105         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp: Added.
1106         (TestWebKitAPI::TEST):
1107         * TestWebKitAPI/Tests/WebCore/CBORValueTest.cpp: Added.
1108         (TestWebKitAPI::TEST):
1109         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp: Added.
1110         (TestWebKitAPI::eq):
1111         Workarounds applied.
1112         (TestWebKitAPI::TEST):
1113
1114 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
1115
1116         webkitpy: Use partially disambiguated type in SimulatedDeviceManager._disambiguate_device_type
1117         https://bugs.webkit.org/show_bug.cgi?id=181538
1118         <rdar://problem/36440580>
1119
1120         Reviewed by Aakash Jain.
1121
1122         When disambiguating a device type, it is possible that the provided device type is sufficiently
1123         ambiguous that the comparisons against complete device types without a disambiguated hardware_family
1124         will result in a failure to disambiguate the type.
1125
1126         * Scripts/webkitpy/xcode/new_simulated_device.py:
1127         (SimulatedDeviceManager._disambiguate_device_type):
1128
1129 2018-01-11  Brent Fulgham  <bfulgham@apple.com>
1130
1131         REGRESSION(r219530): ResourceLoadStatisticsPersistentStorage should be read-only in ephemeral sessions
1132         https://bugs.webkit.org/show_bug.cgi?id=181136
1133         <rdar://problem/36116604>
1134
1135         Reviewed by Chris Dumez.
1136
1137         Add a new API test to confirm that ResourceLoadStatistics can be turned on safely for ephemeral
1138         browsing sessions.
1139
1140         * Scripts/run-gtk-tests:
1141         (GtkTestRunner): Unskip test now that it passes.
1142         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1143         (TEST): Add new WebsiteDataStoreEphemeral test.
1144
1145 2018-01-11  Ryan Haddad  <ryanhaddad@apple.com>
1146
1147         Unreviewed, rolling out r226816.
1148
1149         This change broke LayoutTests on the bots.
1150
1151         Reverted changeset:
1152
1153         "run-webkit-tests fails when there is a curly brace in Xcode
1154         build output"
1155         https://bugs.webkit.org/show_bug.cgi?id=181254
1156         https://trac.webkit.org/changeset/226816
1157
1158 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
1159
1160         webkitpy: Fix flakey webserver tests
1161         https://bugs.webkit.org/show_bug.cgi?id=181555
1162         <rdar://problem/36448273>
1163
1164         Reviewed by Aakash Jain.
1165
1166         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1167         (LayoutTestRunnerTests.test_servers_started): Add and bind custom checks to
1168         determine if a specific server is running.
1169
1170 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
1171
1172         Commit queue failed to land a bug, 'NoneType' object has no attribute 'strip'
1173         https://bugs.webkit.org/show_bug.cgi?id=181561
1174         <rdar://problem/36452652>
1175
1176         Reviewed by Aakash Jain.
1177
1178         BeautifulSoup.find may return None, this case should be gracefully handled.
1179
1180         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1181         (BugzillaQueries._parse_result_count):
1182         (BugzillaQueries._fetch_bugs_from_advanced_query): Added logging.
1183
1184 2018-01-11  Alexey Proskuryakov  <ap@apple.com>
1185
1186         run-webkit-tests fails when there is a curly brace in Xcode build output
1187         https://bugs.webkit.org/show_bug.cgi?id=181254
1188
1189         Reviewed by Daniel Bates.
1190
1191         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
1192         (MeteredStream.write):
1193
1194 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
1195
1196         webkitpy: Reimplement simulator code (Part 3)
1197         https://bugs.webkit.org/show_bug.cgi?id=180555
1198         <rdar://problem/36131381>
1199
1200         Reviewed by Aakash Jain.
1201
1202         Remove old simulator code.
1203
1204         * Scripts/webkitpy/xcode/__init__.py: Remove import statement.
1205         * Scripts/webkitpy/xcode/simulated_device.py: Removed.
1206         * Scripts/webkitpy/xcode/simulator.py: Removed.
1207         * Scripts/webkitpy/xcode/simulator_unittest.py: Removed.
1208
1209 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1210
1211         [Attachment Support] Support moving attachment elements in editable areas using drag and drop
1212         https://bugs.webkit.org/show_bug.cgi?id=181337
1213         <rdar://problem/36324813>
1214
1215         Reviewed by Tim Horton.
1216
1217         Add 3 new API tests for attachment element dragging.
1218
1219         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1220         (-[TestWKWebView expectElementTag:toComeBefore:]):
1221         (-[NSItemProvider expectType:withData:]):
1222         (TestWebKitAPI::TEST):
1223
1224 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
1225
1226         REGRESSION(r225856): Incorrectly managing 'future' baseline_search_paths. 
1227         https://bugs.webkit.org/show_bug.cgi?id=179621
1228         <rdar://problem/35589585>
1229
1230         Unreviewed infrastructure fix.
1231
1232         * Scripts/webkitpy/port/mac.py:
1233         (MacPort.default_baseline_search_path): Include 'future' in the version_fallback
1234         list if we are the VERSION_MAX, which usually corresponds with future.
1235
1236 2018-01-11  Filip Pizlo  <fpizlo@apple.com>
1237
1238         CodeBlocks should be in IsoSubspaces
1239         https://bugs.webkit.org/show_bug.cgi?id=180884
1240
1241         Reviewed by Saam Barati.
1242         
1243         Remove some less important benchmarks from the default run. Doing run-jsc-benchmarks
1244         shouldn't take a long time due to benchmarks we don't optimize for.
1245         
1246         * Scripts/run-jsc-benchmarks:
1247
1248 2018-01-11  Ms2ger  <Ms2ger@igalia.com>
1249
1250         Test gardening for GTK.
1251         https://bugs.webkit.org/show_bug.cgi?id=181477
1252
1253         Unreviewed test gardening.
1254
1255         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Correct the file name.
1256         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Adjust the expected console message.
1257
1258 2018-01-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1259
1260         Add the new JSCOnly bot to the scheduler.
1261         https://bugs.webkit.org/show_bug.cgi?id=181487
1262
1263         Unreviewed follow-up patch after r226729
1264
1265         On r226729 I missed to add the new JSCOnly bot the default scheduler.
1266         This is needed to make the bot automatically pick each commit for testing.
1267
1268         * BuildSlaveSupport/build.webkit.org-config/config.json:
1269
1270 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1271
1272         [Attachment Support] Support dragging attachment elements out as files on iOS
1273         https://bugs.webkit.org/show_bug.cgi?id=181199
1274         <rdar://problem/36299316>
1275
1276         Reviewed by Tim Horton, Andy Estes and Joseph Pecoraro.
1277
1278         Add support in the drag and drop simulator for testing blob-backed attachment element dragging, and also add new
1279         attachment API tests.
1280
1281         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1282         (-[NSItemProvider expectType:withData:]):
1283         (TestWebKitAPI::TEST):
1284
1285         Add two new WKAttachmentTests to exercise dragging data- and file-backed blobs via attachment elements. These
1286         tests first insert attachments via drop or WKWebView SPI, and then drag these attachments out and use the
1287         -expectType:withData: helper to inspect the item providers created from the drag source.
1288
1289         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1290         (TestWebKitAPI::TEST):
1291         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1292         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1293         (-[MockDragSession localContext]):
1294         (-[MockDragSession setLocalContext:]):
1295         (-[DataInteractionSimulator _resetSimulatedState]):
1296         (-[DataInteractionSimulator simulateAllTouchesCanceled:]):
1297         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
1298         (-[DataInteractionSimulator _advanceProgress]):
1299         (-[DataInteractionSimulator endDataTransfer]):
1300
1301         Make some tweaks to the iOS drag and drop simulator. In particular, this patch (1) adds a new hook to tell
1302         WebKit that data transfers have been completed, (2) fixes incorrect drop proposal handling when returning
1303         UIDropOperationForbidden by replacing _shouldPerformOperation with a UIDropProposal, and (3) teach the
1304         MockDragSession to hold on to a localContext.
1305
1306 2018-01-11  Ali Juma  <ajuma@chromium.org>
1307
1308         Unreviewed. Add Ali Juma as contributor
1309
1310         * Scripts/webkitpy/common/config/contributors.json:
1311
1312 2018-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1313
1314         Unreviewed. Update Selenium WebDriver imported tests.
1315
1316         New version of selenium uses command line options to pass driver and browser binaries to pytest instead of
1317         environment variables.
1318
1319         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1320         (collect): Reorder the arguments to make pytest happy.
1321         (run): Ditto.
1322         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1323         (WebDriverSeleniumExecutor.__init__): Add driver binary, browser binary and browser args as arguments.
1324
1325 2018-01-11  Ling Ho  <lingcherd_ho@apple.com>
1326
1327         Move Commit Queue and EWS Queues to Sierra on Bot Watcher's Dasboard
1328         https://bugs.webkit.org/show_bug.cgi?id=181492
1329         <rdar://problem/36359679>
1330
1331         Reviewed by Alexey Proskuryakov. 
1332
1333 2018-01-10  Adrian Perez de Castro  <aperez@igalia.com>
1334
1335         [GTK] Tools/gtk/install-dependencies: Packages geoclue, ruby-highline, xorg-utils do not exist in Arch Linux
1336         https://bugs.webkit.org/show_bug.cgi?id=181475
1337
1338         Reviewed by Michael Catanzaro.
1339
1340         * gtk/install-dependencies: Update package list for Arch Linux, extend
1341         message shown at end of installation with additional tips.
1342
1343 2018-01-10  Wenson Hsieh  <wenson_hsieh@apple.com>
1344
1345         REGRESSION(r222507): Composition highlight doesn't render when using IME
1346         https://bugs.webkit.org/show_bug.cgi?id=181485
1347         <rdar://problem/35896516>
1348
1349         Reviewed by Ryosuke Niwa.
1350
1351         Add a `suppressUnderline` argument to TextInputController.setMarkedText. This suppresses the custom underlines
1352         rendered when testing IME on iOS in WebKit2. In this new test, suppressing underline rendering is needed to
1353         allow rendering composition backgrounds (see InlineTextBox::paint).
1354
1355         * DumpRenderTree/ios/TextInputControllerIOS.m:
1356         (+[TextInputController isSelectorExcludedFromWebScript:]):
1357         (+[TextInputController webScriptNameForSelector:]):
1358         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
1359         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
1360         * DumpRenderTree/mac/TextInputControllerMac.m:
1361         (+[TextInputController isSelectorExcludedFromWebScript:]):
1362         (+[TextInputController webScriptNameForSelector:]):
1363         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
1364         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
1365         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
1366         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
1367         (WTR::TextInputController::setMarkedText):
1368         * WebKitTestRunner/InjectedBundle/TextInputController.h:
1369
1370 2018-01-10  JF Bastien  <jfbastien@apple.com>
1371
1372         Poison small JSObject derivatives which only contain pointers
1373         https://bugs.webkit.org/show_bug.cgi?id=181483
1374         <rdar://problem/36407127>
1375
1376         Reviewed by Mark Lam.
1377
1378         Test the new move-assign and move-copy from unique_ptr, as well as
1379         nullptr_t ctors.
1380
1381         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
1382         (TestWebKitAPI::TEST):
1383         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
1384         (TestWebKitAPI::TEST):
1385         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
1386         (TestWebKitAPI::TEST):
1387
1388 2018-01-10  Chris Dumez  <cdumez@apple.com>
1389
1390         Multiple http/wpt/beacon/contentextensions/ test are flaky.
1391         https://bugs.webkit.org/show_bug.cgi?id=179256
1392         <rdar://problem/35401978>
1393
1394         Reviewed by Alex Christensen.
1395
1396         Update WebKitTestRunner to set a temporary path for content extensions so that its WKTR
1397         instance gets its own folder to avoid conflicts and flakiness.
1398
1399         * WebKitTestRunner/mac/TestControllerMac.mm:
1400         (WTR::TestController::platformConfigureViewForTest):
1401
1402 2018-01-10  Tim Horton  <timothy_horton@apple.com>
1403
1404         REGRESSION (r213590): Swipe from edge to go to previous page is significantly slower than tapping back button on Twitter
1405         https://bugs.webkit.org/show_bug.cgi?id=181269
1406         <rdar://problem/35110344>
1407
1408         Reviewed by Simon Fraser.
1409
1410         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1411         (WTR::UIScriptController::beginBackSwipe):
1412         (WTR::UIScriptController::completeBackSwipe):
1413         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1414         (WTR::UIScriptController::beginBackSwipe):
1415         (WTR::UIScriptController::completeBackSwipe):
1416         (WTR::UIScriptController::overridePreference):
1417         (WTR::UIScriptController::replaceTextAtRange):
1418         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1419         (WTR::PlatformWebView::setNavigationGesturesEnabled):
1420         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1421         (WTR::UIScriptController::beginBackSwipe):
1422         (WTR::UIScriptController::completeBackSwipe):
1423         Implement beginBackSwipe and completeBackSwipe on iOS (they already
1424         exist on Mac) in terms of the new WKWebView testing SPI.
1425
1426 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
1427
1428         REGRESSION (r226715): ignore WARNING output in linter tests
1429         https://bugs.webkit.org/show_bug.cgi?id=181486
1430         <rdar://problem/36408847>
1431
1432         Reviewed by Aakash Jain.
1433
1434         Linter unit tests should not be interested in logs at the the INFO or WARNING levels.
1435
1436         * Scripts/webkitpy/common/system/outputcapture.py:
1437         (OutputCapture.__init__): Pass logging level to be captured.
1438         * Scripts/webkitpy/style/main_unittest.py:
1439         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors): Capture logging at the ERROR level.
1440         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Ditto.
1441         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit): Ditto.
1442         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Ditto.
1443         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Ditto.
1444         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Ditto.
1445         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file): Ditto.
1446         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit): Ditto.
1447
1448 2018-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1449
1450         Add a JSCOnly MIPS buildbot
1451         https://bugs.webkit.org/show_bug.cgi?id=181487
1452
1453         Reviewed by Michael Catanzaro.
1454
1455         Add the new bot configs definitions for the master and update the unit tests.
1456
1457         * BuildSlaveSupport/build.webkit.org-config/config.json:
1458         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1459
1460 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
1461
1462         REGRESSION (r226715): don't re-check number of simulators in child processes
1463         https://bugs.webkit.org/show_bug.cgi?id=181484
1464         <rdar://problem/36407151>
1465
1466         Reviewed by Aakash Jain.
1467
1468         * Scripts/webkitpy/port/ios_simulator.py:
1469         (IOSSimulatorPort.__init__): Skip the number of simulators check if simulators
1470         are already initialized.
1471
1472 2018-01-10  Commit Queue  <commit-queue@webkit.org>
1473
1474         Unreviewed, rolling out r226667 and r226673.
1475         https://bugs.webkit.org/show_bug.cgi?id=181488
1476
1477         This caused a flaky crash. (Requested by mlewis13 on #webkit).
1478
1479         Reverted changesets:
1480
1481         "CodeBlocks should be in IsoSubspaces"
1482         https://bugs.webkit.org/show_bug.cgi?id=180884
1483         https://trac.webkit.org/changeset/226667
1484
1485         "REGRESSION (r226667): CodeBlocks should be in IsoSubspaces"
1486         https://bugs.webkit.org/show_bug.cgi?id=180884
1487         https://trac.webkit.org/changeset/226673
1488
1489 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
1490
1491         Follow-up fix to r226715
1492         https://bugs.webkit.org/show_bug.cgi?id=180555
1493         <rdar://problem/36131381>
1494
1495         Unreviewed infrastructure fix.
1496
1497         * Scripts/webkitpy/xcode/new_simulated_device.py:
1498         (SimulatedDeviceManager._create_or_find_device_for_request): Use _delete instead
1499         of delete.
1500
1501 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
1502
1503         webkitpy: Refactor simulator code (Part 2)
1504         https://bugs.webkit.org/show_bug.cgi?id=180555
1505         <rdar://problem/36131381>
1506
1507         Reviewed by Aakash Jain.
1508
1509         The patch leverages the SimulatedDeviceManager when running layout tests.
1510         This patch is primarily code removal, since much of the IOSSimulatorPort
1511         was dedicated to managing simulators. The removed code is either now owned by the
1512         SimulatedDeviceManager (and committed in Part 1) or supported a technique to
1513         boot multiple simulators which was made obsolete in Xcode 9.
1514
1515         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1516         (Manager._custom_device_for_test.in): Device names now have spaces in them,
1517         strip those spaces.
1518         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1519         (parse_args): Remove '--runtime' flag, this is achieved with the --version flag.
1520         * Scripts/webkitpy/port/ios.py:
1521         (IOSPort.__init__): The _current_device idiom is no longer required since the
1522         SimulatedDeviceManager keeps track of any previously booted devices.
1523         (IOSPort.target_host): Even when only a single device is used, it will be accessed
1524         through the array of managed devices.
1525         (IOSPort.using_multiple_devices): Deleted.
1526         * Scripts/webkitpy/port/ios_device.py:
1527         (IOSDevicePort.using_multiple_devices): Deleted.
1528         * Scripts/webkitpy/port/ios_simulator.py:
1529         (IOSSimulatorPort): Remove constants required to manage simulators, change device
1530         class strings so they can be parsed by the DeviceType class.
1531         (IOSSimulatorPort.__init__): Determine the number of processes to use by checking
1532         the number of simulators currently booted, the number of child processes specified
1533         and the maximum number of simulators supported by this system.
1534         (IOSSimulatorPort._device_for_worker_number_map):Return the array of initialized
1535         devices owned by the SimulatedDeviceManager.
1536         (IOSSimulatorPort.ios_version): Remove support for the --runtime option.
1537         (IOSSimulatorPort.default_child_processes): Use the SimulatedDeviceManager to check
1538         the maximum number of supported simulators on this system.
1539         (IOSSimulatorPort._create_devices): Construct a list of device requests with a
1540         request for each child process and send this list to the SimulatedDeviceManager to
1541         initialize the devices.
1542         (IOSSimulatorPort.clean_up_test_run):
1543         (IOSSimulatorPort.check_sys_deps): Check that there are simulators running the
1544         specified version of iOS.
1545         (IOSSimulatorPort.reset_preferences):
1546         (IOSSimulatorPort.simulator_runtime): Deleted.
1547         (IOSSimulatorPort.simulator_device_type): Deleted.
1548         (IOSSimulatorPort._teardown_managed_simulators): Deleted.
1549         (IOSSimulatorPort.use_multiple_simulator_apps): Deleted.
1550         (IOSSimulatorPort._create_simulators): Deleted.
1551         (IOSSimulatorPort._quit_ios_simulator): Deleted.
1552         (IOSSimulatorPort._using_dedicated_simulators): Deleted.
1553         (IOSSimulatorPort.using_multiple_devices): Deleted.
1554         (IOSSimulatorPort._create_device): Deleted.
1555         (IOSSimulatorPort.get_simulator_path): Deleted.
1556         (IOSSimulatorPort._createSimulatorApps): Deleted.
1557         (IOSSimulatorPort._createSimulatorApp): Deleted.
1558         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1559         (TestRebaseline.test_rebaseline): Filter out commands run when determining the
1560         maximum number of simulators run on this system.
1561         (TestRebaselineExpectations.test_rebaseline_expectations): Ditto.
1562         * Scripts/webkitpy/xcode/new_simulated_device.py:
1563         (SimulatedDeviceManager._does_fulfill_request): Fixed log statement.
1564
1565 2018-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1566
1567         WebDriver: run-webdriver-tests doesn't handle test names with a '/' correctly
1568         https://bugs.webkit.org/show_bug.cgi?id=181474
1569
1570         Reviewed by Carlos Alberto Lopez Perez.
1571
1572         We use os.path.basename() to get the subtest name. If the test name contains a slash we get part of the subtest
1573         name as the name.
1574
1575         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1576         (WebDriverTestRunnerW3C._subtest_name): Helper function to get the subtest name.
1577         (WebDriverTestRunnerW3C.run): Use _subtest_name() instead of os.path.basename().
1578
1579 2018-01-09  Andy Estes  <aestes@apple.com>
1580
1581         [Xcode] Use the Apple Internal SDK if available when building ImageDiff
1582         https://bugs.webkit.org/show_bug.cgi?id=181459
1583
1584         Reviewed by Dan Bernstein.
1585
1586         * ImageDiff/cg/Configurations/Base.xcconfig:
1587
1588 2018-01-09  Myles C. Maxfield  <mmaxfield@apple.com>
1589
1590         font-display:fallback can cause a visual flash (which is supposed to be impossible)
1591         https://bugs.webkit.org/show_bug.cgi?id=181374
1592
1593         Reviewed by Simon Fraser.
1594
1595         The test requires Palatino.
1596
1597         * DumpRenderTree/mac/DumpRenderTree.mm:
1598         (allowedFontFamilySet):
1599         * WebKitTestRunner/mac/TestControllerMac.mm:
1600         (WTR::allowedFontFamilySet):
1601
1602 2018-01-09  Saam Barati  <sbarati@apple.com>
1603
1604         Give some slack in display-profiler-outputs computation of the terminal window's number of columns
1605         https://bugs.webkit.org/show_bug.cgi?id=181449
1606
1607         Reviewed by JF Bastien.
1608
1609         This allows me to Cmd+f in my terminal to search for things without
1610         having the results become misaligned.
1611
1612         * Scripts/display-profiler-output:
1613
1614 2018-01-09  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1615
1616         [webkitpy] PlatformInfo should have default argument for casual use
1617         https://bugs.webkit.org/show_bug.cgi?id=180827
1618
1619         Reviewed by David Kilzer.
1620
1621         PlatformInfo should be the only way to check platform specific thing instead
1622         of sys.platform or other various checks. If there is something you want to check,
1623         it should be placed in PlatformInfo.
1624
1625         Currently to instantiate PlatformInfo, it requires arguments, which is usually
1626         sys, platform and Executive(). They are straight forward and should be handled
1627         by default arguments. Then we can instantiate PlatformInfo more casual.
1628
1629         * Scripts/webkitpy/common/system/platforminfo.py:
1630         (PlatformInfo): Use relative module path import
1631         (PlatformInfo.__init__):
1632         (PlatformInfo.executive): Lazy instantiation of Executive()
1633         (PlatformInfo.total_bytes_memory): Accessing via above property
1634         (PlatformInfo.xcode_sdk_version): Ditto
1635         (PlatformInfo.xcode_simctl_list): Ditto
1636         (PlatformInfo.xcode_version): Ditto
1637         (PlatformInfo._win_version_str): Ditto
1638         * Scripts/webkitpy/common/system/systemhost.py:
1639         (SystemHost.__init__):
1640         * Scripts/webkitpy/common/system/user.py:
1641         (User.__init__):
1642
1643 2018-01-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1644
1645         [Win] Remove workaround for Bug 176442 after stopping MSVC 2015 support
1646         https://bugs.webkit.org/show_bug.cgi?id=176443
1647
1648         Reviewed by Darin Adler.
1649
1650         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
1651         (TEST):
1652
1653 2018-01-09  Frederic Wang  <fwang@igalia.com.fr>
1654
1655         check-webkit-style: Verify syntax for WK_API_AVAILABLE
1656         https://bugs.webkit.org/show_bug.cgi?id=181394
1657
1658         Reviewed by Darin Adler.
1659
1660         A common syntax error for WK_API_AVAILABLE is to write ios(WK_MAC_TBA)
1661         as the second parameter instead of ios(WK_IOS_TBA). This generally
1662         builds for iOS on EWS but not when using the public SDK. See r224057,
1663         r223207 and r226211 for example. This patch adds a basic style check
1664         for that macro to prevent this kind of mistake.
1665
1666         * Scripts/webkitpy/style/checkers/cpp.py:
1667         (check_min_versions_of_wk_api_available): New function to verify the parameters of WX_API_AVAILABLE.
1668         (check_style): Run new style check.
1669         (CppChecker): Add build type for the new style check.
1670         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1671         (WebKitStyleTest.test_min_versions_of_wk_api_available): Add tests for the new style check.
1672
1673 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1674
1675         [Attachment Support] Expose HTMLAttachmentElement.uniqueIdentifier to bindings
1676         https://bugs.webkit.org/show_bug.cgi?id=181420
1677         <rdar://problem/36365827>
1678
1679         Reviewed by Alex Christensen.
1680
1681         Adjusts some existing API tests to verify that attachment elements' uniqueIdentifiers match the uniqueIdentifier
1682         of corresponding _WKAttachments.
1683
1684         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1685         (TestWebKitAPI::TEST):
1686
1687 2018-01-08  Alex Christensen  <achristensen@webkit.org>
1688
1689         Add WKNavigationDelegate SPI exposing WebProcess crash reason
1690         https://bugs.webkit.org/show_bug.cgi?id=181410
1691         <rdar://problem/36167199>
1692
1693         Reviewed by Wenson Hsieh.
1694
1695         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
1696         (-[CrashReasonDelegate _webView:webContentProcessDidTerminateWithReason:]):
1697         (TEST):
1698
1699 2018-01-08  Alex Christensen  <achristensen@webkit.org>
1700
1701         Add SPI for WKOpenPanelParameters._acceptedMIMETypes and _acceptedFileExtensions
1702         https://bugs.webkit.org/show_bug.cgi?id=181408
1703         <rdar://problem/35884960>
1704
1705         Reviewed by Tim Horton.
1706
1707         * TestWebKitAPI/Tests/WebKitCocoa/RunOpenPanel.mm:
1708         (-[RunOpenPanelUIDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
1709
1710 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1711
1712         [Attachment Support] Expose file name and content type of WKAttachment
1713         https://bugs.webkit.org/show_bug.cgi?id=181390
1714         <rdar://problem/36336837>
1715
1716         Reviewed by Tim Horton.
1717
1718         Adjusts some existing tests in WKAttachmentTests to exercise -requestInfo:.
1719
1720         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1721         (-[_WKAttachment synchronouslyRequestInfo:]):
1722         (-[_WKAttachment synchronouslyRequestData:]):
1723
1724         Reimplement this in terms of -synchronouslyRequestInfo:.
1725
1726         (-[_WKAttachment expectRequestedDataToBe:]):
1727         (TestWebKitAPI::TEST):
1728
1729 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1730
1731         Copying, pasting, and then deleting an attachment element breaks attachment data requests
1732         https://bugs.webkit.org/show_bug.cgi?id=181365
1733         <rdar://problem/36340647>
1734
1735         Reviewed by Tim Horton.
1736
1737         Adds two new attachment API tests to verify that copying and pasting an existing attachment inserts an
1738         attachment element that may be edited independently of the original attachment. See WebCore/ChangeLog for more
1739         detail.
1740
1741         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1742         (TestWebKitAPI::TEST):
1743
1744 2018-01-08  Youenn Fablet  <youenn@apple.com>
1745
1746         navigator.onLine does not work inside service workers
1747         https://bugs.webkit.org/show_bug.cgi?id=181079
1748         <rdar://problem/36178606>
1749
1750         Reviewed by Darin Adler.
1751
1752         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1753         (WTR::InjectedBundle::initialize): Setting service worker creation callback to inject ServiceWorkerInternals object.
1754
1755 2018-01-07  Saam Barati  <sbarati@apple.com>
1756
1757         Add total exits and total compilations sorting mode to the "full" command in display-profiler-output
1758         https://bugs.webkit.org/show_bug.cgi?id=181372
1759
1760         Reviewed by Filip Pizlo.
1761
1762         Adding these sorting modes makes it easier to analyze functions
1763         that recompile a lot and exit a lot.
1764
1765         * Scripts/display-profiler-output:
1766
1767 2018-01-06  Julien Brianceau  <julien.brianceau@gmail.com>
1768
1769         Unreviewed, remove my Cisco email from contributors.json
1770
1771         * Scripts/webkitpy/common/config/contributors.json:
1772
1773 2018-01-05  JF Bastien  <jfbastien@apple.com>
1774
1775         WebAssembly: poison JS object's secrets
1776         https://bugs.webkit.org/show_bug.cgi?id=181339
1777         <rdar://problem/36325001>
1778
1779         Reviewed by Mark Lam.
1780
1781         Update tests for swap(Poisoned<k, T>, T*)
1782
1783         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp:
1784         (TestWebKitAPI::TEST):
1785         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
1786         (TestWebKitAPI::TEST):
1787         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
1788         (TestWebKitAPI::TEST):
1789
1790 2018-01-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1791
1792         REGRESSION(r226396) DataInteractionTests: ContentEditableToContentEditable and ContentEditableToTextarea are failing
1793         https://bugs.webkit.org/show_bug.cgi?id=181359
1794
1795         Reviewed by Tim Horton.
1796
1797         Ensure that these tests still pass using older SDKs.
1798
1799         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1800         (TestWebKitAPI::TEST):
1801
1802 2018-01-05  Alex Christensen  <achristensen@webkit.org>
1803
1804         Rebase API test after r226469
1805         https://bugs.webkit.org/show_bug.cgi?id=181308
1806
1807         * TestWebKitAPI/Tests/WebKitCocoa/LoadInvalidURLRequest.mm:
1808         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
1809         A URL with < or > in it is now recognized as invalid by WebKit.  This is intentional, and matches our behavior before enabling the new URLParser.
1810
1811 2018-01-05  Alex Christensen  <achristensen@webkit.org>
1812
1813         Restrict navigation-time WKWebsiteDataStore swapping to main frame navigations
1814         https://bugs.webkit.org/show_bug.cgi?id=181217
1815
1816         Reviewed by Tim Horton.
1817
1818         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1819         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1820         (TEST):
1821
1822 2018-01-05  Alex Christensen  <achristensen@webkit.org>
1823
1824         Add WKBundleFrameCreateFrameHandle
1825         https://bugs.webkit.org/show_bug.cgi?id=181232
1826         <rdar://problem/35926696>
1827
1828         Reviewed by Tim Horton.
1829
1830         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1831         * TestWebKitAPI/Tests/WebKitCocoa/FrameHandleSerialization.mm: Added.
1832         (mouseDidMoveOverElement):
1833         (-[FrameHandleSerialization webProcessPlugIn:didCreateBrowserContextController:]):
1834         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1835         (-[MouseMoveOverElementDelegate _webView:mouseDidMoveOverElement:withFlags:userInfo:]):
1836         (TEST):
1837
1838 2018-01-05  Chris Fleizach  <cfleizach@apple.com>
1839
1840         iOS: Build fix after r226432.
1841         
1842         Unreviewed. Stop duplicating speakAs symbols for iOS.
1843
1844         * DumpRenderTree/AccessibilityUIElement.cpp:
1845         (AccessibilityUIElement::speakAs):
1846
1847 2018-01-05  Javier Fernandez  <jfernandez@igalia.com>
1848
1849         Unreviewed, added myself as WebKit reviewer
1850
1851         * Scripts/webkitpy/common/config/contributors.json:
1852
1853 2018-01-05  Claudio Saavedra  <csaavedra@igalia.com>
1854
1855         WPE: Build fix after r226432.
1856
1857         Unreviewed. Rename ::speak() to ::speakAs().
1858         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
1859         (WTR::AccessibilityUIElement::speakAs):
1860         (WTR::AccessibilityUIElement::speak): Deleted.
1861
1862 2018-01-04  Chris Fleizach  <cfleizach@apple.com>
1863
1864         AX: Implement updated CSS3 Speech for 'speak' and 'speak-as' properties
1865         https://bugs.webkit.org/show_bug.cgi?id=180361
1866
1867         Reviewed by Zalan Bujtas.
1868
1869         * DumpRenderTree/AccessibilityUIElement.cpp:
1870         (speakAsCallback):
1871         (AccessibilityUIElement::speakAs):
1872         (AccessibilityUIElement::getJSClass):
1873         (speakCallback): Deleted.
1874         (AccessibilityUIElement::speak): Deleted.
1875         * DumpRenderTree/AccessibilityUIElement.h:
1876         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1877         (AccessibilityUIElement::speakAs):
1878         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1879         (AccessibilityUIElement::speakAs):
1880         (AccessibilityUIElement::speak): Deleted.
1881         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1882         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1883         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1884         (WTR::AccessibilityUIElement::speakAs):
1885         (WTR::AccessibilityUIElement::speak): Deleted.
1886         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1887         (WTR::AccessibilityUIElement::speakAs):
1888         (WTR::AccessibilityUIElement::speak): Deleted.
1889
1890 2018-01-04  Jonathan Bedard  <jbedard@apple.com>
1891
1892         REGRESSION (r226395): test-webkitperl test expectations incorrect
1893         https://bugs.webkit.org/show_bug.cgi?id=181307
1894         <rdar://problem/36306558>
1895
1896         Rubber-stamped by Aakash Jain.
1897
1898         r226395 added two lines towards the beginning of
1899         Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl, the line
1900         numbers in the test expectations need to update.
1901
1902         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
1903
1904 2018-01-04  Tim Horton  <timothy_horton@apple.com>
1905
1906         WKWebView loses minimum layout size overrides that happen while the process is terminated
1907         https://bugs.webkit.org/show_bug.cgi?id=181306
1908         <rdar://problem/34398288>
1909
1910         Reviewed by Dan Bernstein.
1911
1912         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
1913         (TEST):
1914         Add a test that calling _overrideLayoutParametersWithMinimumLayoutSize
1915         while the process is terminated results in the page getting the correct
1916         minimum layout size.
1917
1918 2018-01-04  Eric Carlson  <eric.carlson@apple.com>
1919
1920         [MediaStream] Add Mock screen capture source
1921         https://bugs.webkit.org/show_bug.cgi?id=181291
1922         <rdar://problem/36298164>
1923
1924         Reviewed by Dean Jackson.
1925
1926         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test.
1927         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
1928         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
1929
1930 2018-01-04  Lucas Forschler  <lforschler@apple.com>
1931
1932         <rdar://problem/36300930> Change proxy server setting on master config to reach s3 servers
1933
1934         Reviewed by Ling Ho.
1935
1936         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1937
1938 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1939
1940         [Attachment Support] Create attachment elements when dropping files on iOS
1941         https://bugs.webkit.org/show_bug.cgi?id=181192
1942         <rdar://problem/36280945>
1943
1944         Reviewed by Tim Horton.
1945
1946         Adds 3 new API tests to exercise different use cases of dropping content as attachment elements when the runtime
1947         switch is enabled. See below for more details.
1948
1949         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1950         (-[NSItemProvider registerData:type:]):
1951         (platformCopyPNG):
1952         (TestWebKitAPI::TEST):
1953         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1954
1955         Fix some currently failing iOS drag and drop tests. In this case, there's no reason RTFD should appear in the
1956         source item provider when dragging rich text *without* attachments, so this should have been a check for just
1957         kUTTypeRTF instead.
1958
1959         (TestWebKitAPI::TEST):
1960
1961         Tests a few cases of inserting attachment elements via drop:
1962         1.  We should distinguish between drops containing rich/plain text files from just dropping rich/plain text.
1963             Instead of inserting the contents as inline web content, this should generate attachment elements.
1964         2.  Test the fallback mechanism for inserting attachment elements. If the preferred presentation style is not
1965             explicitly set, but there's nothing WebKit would otherwise do with the dropped content, then we should fall
1966             back to inserting the content as an attachment.
1967         3.  Test that if multiple attachments and inline item providers are present, WebKit will respect the order in
1968             which they were inserted by the source (as opposed to, for instance, putting all of the attachments in front
1969             or at the end).
1970
1971         * TestWebKitAPI/cocoa/TestWKWebView.h:
1972         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1973         (-[TestWKWebView objectByEvaluatingJavaScript:]):
1974
1975         Add a helper method to return an object that represents the result of evaluating some given script, and rewrite
1976         -stringByEvaluatingJavaScript to just turn around and call this.
1977
1978         (-[TestWKWebView stringByEvaluatingJavaScript:]):
1979
1980 2018-01-03  Ting-Wei Lan  <lantw44@gmail.com>
1981
1982         Replace hard-coded paths in shebangs with #!/usr/bin/env
1983         https://bugs.webkit.org/show_bug.cgi?id=181040
1984
1985         Reviewed by Alex Christensen.
1986
1987         * BuildSlaveSupport/build-launcher-app:
1988         * BuildSlaveSupport/build-launcher-dmg:
1989         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1990         * BuildSlaveSupport/built-product-archive:
1991         * BuildSlaveSupport/clean-build:
1992         * BuildSlaveSupport/delete-stale-build-files:
1993         * BuildSlaveSupport/download-built-product:
1994         * BuildSlaveSupport/gtk/buildbot/log/run:
1995         * BuildSlaveSupport/gtk/buildbot/run:
1996         * BuildSlaveSupport/gtk/pulseaudio/run:
1997         * BuildSlaveSupport/kill-old-processes:
1998         * BuildSlaveSupport/test-result-archive:
1999         * BuildSlaveSupport/win/kill-old-processes:
2000         * Scripts/SpacingHeuristics.pm:
2001         * Scripts/add-include:
2002         * Scripts/build-api-tests:
2003         * Scripts/build-dumprendertree:
2004         * Scripts/build-imagediff:
2005         * Scripts/build-jsc:
2006         * Scripts/build-webkit:
2007         * Scripts/build-webkittestrunner:
2008         * Scripts/check-Xcode-source-file-types:
2009         * Scripts/check-dom-results:
2010         * Scripts/check-for-exit-time-destructors:
2011         * Scripts/check-for-global-initializers:
2012         * Scripts/check-for-inappropriate-objc-class-names:
2013         * Scripts/check-for-weak-vtables-and-externals:
2014         * Scripts/clean-header-guards:
2015         * Scripts/compare-timing-files:
2016         * Scripts/configure-xcode-for-ios-development:
2017         * Scripts/copy-webkitlibraries-to-product-directory:
2018         * Scripts/create-exports:
2019         * Scripts/debug-minibrowser:
2020         * Scripts/debug-safari:
2021         * Scripts/debug-test-runner:
2022         * Scripts/do-file-rename:
2023         * Scripts/do-webcore-rename:
2024         * Scripts/dump-webkit-tests-run:
2025         * Scripts/ensure-valid-python:
2026         * Scripts/execAppWithEnv:
2027         * Scripts/extract-localizable-js-strings:
2028         * Scripts/filter-build-webkit:
2029         * Scripts/find-extra-includes:
2030         * Scripts/fix-blink-patch:
2031         * Scripts/generate-coverage-data:
2032         * Scripts/git-add-reviewer:
2033         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
2034         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
2035         * Scripts/jsc-stress-test-helpers/js-osr-exit-fuzz:
2036         * Scripts/make-new-script-test:
2037         * Scripts/make-script-test-wrappers:
2038         * Scripts/package-root:
2039         * Scripts/parse-malloc-history:
2040         * Scripts/report-include-statistics:
2041         * Scripts/resolve-ChangeLogs:
2042         * Scripts/run-api-tests:
2043         * Scripts/run-bindings-tests:
2044         * Scripts/run-content-extension-tester:
2045         * Scripts/run-iexploder-tests:
2046         * Scripts/run-javascriptcore-tests:
2047         * Scripts/run-jsc:
2048         * Scripts/run-leaks:
2049         * Scripts/run-mangleme-tests:
2050         * Scripts/run-minibrowser:
2051         * Scripts/run-pageloadtest:
2052         * Scripts/run-regexp-tests:
2053         * Scripts/run-safari:
2054         * Scripts/run-sunspider:
2055         * Scripts/run-test-runner:
2056         * Scripts/run-webkit-app:
2057         * Scripts/run-webkit-httpd:
2058         * Scripts/run-webkit-websocketserver:
2059         * Scripts/set-webkit-configuration:
2060         * Scripts/show-pretty-diff:
2061         * Scripts/sort-Xcode-project-file:
2062         * Scripts/split-file-by-class:
2063         * Scripts/sunspider-compare-results:
2064         * Scripts/svn-apply:
2065         * Scripts/svn-unapply:
2066         * Scripts/test-webkit-scripts:
2067         * Scripts/test-webkitperl:
2068         * Scripts/update-iexploder-cssproperties:
2069         * Scripts/update-javascriptcore-test-results:
2070         * Scripts/update-webkit:
2071         * Scripts/update-webkit-auxiliary-libs:
2072         * Scripts/update-webkit-dependency:
2073         * Scripts/update-webkit-libs-jhbuild:
2074         * Scripts/update-webkit-localizable-strings:
2075         * Scripts/update-webkit-support-libs:
2076         * Scripts/update-webkitgtk-libs:
2077         * Scripts/update-webkitwpe-libs:
2078         * Scripts/webkit-build-directory:
2079         * Scripts/webkitperl/LoadAsModule.pm:
2080         * Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
2081         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
2082         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl:
2083         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl:
2084         * Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl:
2085         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
2086         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
2087         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
2088         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
2089         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
2090         * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl:
2091         * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
2092         * Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl:
2093         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
2094         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
2095         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
2096         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
2097         * Scripts/webkitperl/VCSUtils_unittest/parseUnifiedDiffHeader.pl:
2098         * Scripts/webkitperl/VCSUtils_unittest/prepareParsedPatch.pl:
2099         * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl:
2100         * Scripts/webkitperl/VCSUtils_unittest/runCommand.pl:
2101         * Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl:
2102         * Scripts/webkitperl/VCSUtils_unittest/setChangeLogDateAndReviewer.pl:
2103         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl:
2104         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl:
2105         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
2106         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl:
2107         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl:
2108         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl:
2109         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
2110         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
2111         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
2112         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl:
2113         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl:
2114         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl:
2115         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
2116         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
2117         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl:
2118         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl:
2119         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
2120         * ccache/ccache-clang:
2121         * ccache/ccache-clang++:
2122         * ccache/ccache-wrapper:
2123         * gtk/install-dependencies:
2124         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi:
2125         * iExploder/iexploder-1.3.2/htdocs/webserver.rb:
2126         * iExploder/iexploder-1.3.2/tools/lasthit.rb:
2127         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb:
2128         * iExploder/iexploder-1.3.2/tools/showtest.rb:
2129         * iExploder/iexploder-1.7.2/src/browser_harness.rb:
2130         * iExploder/iexploder-1.7.2/src/iexploder.cgi:
2131         * iExploder/iexploder-1.7.2/src/webserver.rb:
2132         * iExploder/iexploder-1.7.2/tools/lasthit.rb:
2133         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb:
2134         * wpe/install-dependencies:
2135
2136 2018-01-03  Simon Fraser  <simon.fraser@apple.com>
2137
2138         filter-build-webkit filters out useful compiler error lines
2139         https://bugs.webkit.org/show_bug.cgi?id=179864
2140
2141         Reviewed by Tim Horton.
2142
2143         Don't filter out lines that contain information about build errors by always showing lines
2144         after a line that contains "note:" or "error:".
2145
2146         * Scripts/filter-build-webkit:
2147         (shouldShowSubsequentLine):
2148         (shouldIgnoreLine):
2149
2150 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2151
2152         REGRESSION(r226366): [GTK] Broke TestBackForwardList and TestWebKitWebView
2153         https://bugs.webkit.org/show_bug.cgi?id=173915
2154
2155         Unreviewed follow-up. Fix /webkit2/WebKitWebView/session-state-with-form-data and
2156         /webkit2/WebKitWebView/submit-form. The form ID may be NULL, but we can't put NULL into a
2157         GVariant unless we use maybe types, and maybe types are incompatible with D-Bus. So use an
2158         empty string in this case.
2159
2160         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2161         (emitFormSubmissionEvent):
2162
2163 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2164
2165         [GTK] Add web process API to detect when form is submitted via JavaScript
2166         https://bugs.webkit.org/show_bug.cgi?id=173915
2167
2168         Reviewed by Carlos Garcia Campos.
2169
2170         Test it.
2171
2172         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
2173         (FormSubmissionTest::FormSubmissionTest):
2174         (FormSubmissionTest::~FormSubmissionTest):
2175         (FormSubmissionTest::testFormSubmissionResult):
2176         (FormSubmissionTest::willSendDOMEventCallback):
2177         (FormSubmissionTest::willCompleteCallback):
2178         (FormSubmissionTest::runJavaScriptAndWaitUntilFormSubmitted):
2179         (testWebExtensionFormSubmissionSteps):
2180         (beforeAll):
2181         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2182         (DelayedSignal::DelayedSignal):
2183         (emitFormSubmissionEvent):
2184         (handleFormSubmissionCallback):
2185         (willSubmitFormCallback):
2186         (pageCreatedCallback):
2187
2188 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2189
2190         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/databases
2191         https://bugs.webkit.org/show_bug.cgi?id=181251
2192
2193         * Scripts/run-gtk-tests:
2194         (GtkTestRunner):
2195
2196 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2197
2198         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/ephemeral
2199         https://bugs.webkit.org/show_bug.cgi?id=181136
2200
2201         * Scripts/run-gtk-tests:
2202         (GtkTestRunner):
2203
2204 2018-01-02  Brent Fulgham  <bfulgham@apple.com>
2205
2206         [macOS, iOS] Adopt new secure coding APIs in WebKit
2207         https://bugs.webkit.org/show_bug.cgi?id=181085
2208         <rdar://problem/34837397>
2209
2210         Reviewed by Tim Horton.
2211
2212         Update API tests to use secure coding wherever possible. Currently, NSView/UIView-based classes are not
2213         capable of supporting NSSecureCoding, so pass through the current coding routines.
2214
2215         * TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm: Updated for NSSecureCoding.
2216         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm:
2217         (encodeAndDecode): Check if class supports the NSSecureCoding protocol and use non-secure coding
2218         routines if necessary.
2219         (TEST): Updated for NSSecureCoding.
2220         * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm:
2221         (TestWebKitAPI::TEST): Updated for NSSecureCoding.
2222
2223 2017-12-28  Yusuke Suzuki  <utatane.tea@gmail.com>
2224
2225         Remove std::chrono completely
2226         https://bugs.webkit.org/show_bug.cgi?id=181186
2227
2228         Reviewed by Alex Christensen.
2229
2230         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2231         (WTR::TestController::platformRunUntil):
2232
2233 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
2234
2235         REGRESSION(r223253): Broke ResourceLoadStatistics layout tests for non-Cocoa ports
2236         https://bugs.webkit.org/show_bug.cgi?id=181231
2237
2238         Reviewed by Alex Christensen.
2239
2240         Implement TestController APIs needed by ResourceLoadStatistics tests.
2241
2242         * WebKitTestRunner/TestController.cpp:
2243         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
2244         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
2245
2246 2018-01-02  Tim Horton  <timothy_horton@apple.com>
2247
2248         Disable WKAttachmentTests if UIPasteboard.itemProviders is not available
2249         https://bugs.webkit.org/show_bug.cgi?id=181219
2250
2251         Reviewed by Wenson Hsieh.
2252
2253         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2254
2255 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
2256
2257         Add a WebAuthentication runtime feature flag
2258         https://bugs.webkit.org/show_bug.cgi?id=181220
2259         <rdar://problem/36055305>
2260
2261         Reviewed by Brent Fulgham.
2262
2263         Renames the CredentialManagement runtime feature flag into WebAuthentication.
2264
2265         * DumpRenderTree/TestOptions.h:
2266         * DumpRenderTree/TestOptions.mm:
2267         (TestOptions::TestOptions):
2268         * DumpRenderTree/mac/DumpRenderTree.mm:
2269         (enableExperimentalFeatures):
2270         (setWebPreferencesForTestOptions):
2271         * WebKitTestRunner/TestController.cpp:
2272         (WTR::TestController::resetPreferencesToConsistentValues):
2273         (WTR::updateTestOptionsFromTestHeader):
2274         * WebKitTestRunner/TestOptions.h:
2275         (WTR::TestOptions::hasSameInitializationOptions const):
2276
2277 2018-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2278
2279         [Attachment Support] Don't Blob-convert images and attachments with https:, http: or data: urls
2280         https://bugs.webkit.org/show_bug.cgi?id=181143
2281         <rdar://problem/36200381>
2282
2283         Reviewed by Tim Horton.
2284
2285         Add a new API test to ensure that a copied image with a data URL does not get pasted as an attachment when
2286         attachment elements are enabled.
2287
2288         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2289         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2290         (TestWebKitAPI::TEST):
2291
2292 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
2293
2294         Update Credential Management API for WebAuthentication
2295         https://bugs.webkit.org/show_bug.cgi?id=181082
2296         <rdar://problem/36055239>
2297
2298         Reviewed by Brent Fulgham.
2299
2300         Enable Credential Management API for testing.
2301
2302         * DumpRenderTree/TestOptions.h:
2303         * WebKitTestRunner/TestOptions.h:
2304
2305 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
2306
2307         [GTK] Test /webkit2/WebKitWebExtension/form-controls-associated-signal is flaky
2308         https://bugs.webkit.org/show_bug.cgi?id=168194
2309
2310         Reviewed by Carlos Garcia Campos.
2311
2312         Fix an assertion and unskip the test. The order that form controls are associated is not
2313         guaranteed.
2314
2315         * Scripts/run-gtk-tests:
2316         (GtkTestRunner):
2317         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
2318         (didAssociateFormControlsCallback):
2319
2320 2018-01-02  Alex Christensen  <achristensen@webkit.org>
2321
2322         Use new WebsiteDataStore passed in through decidePolicyForNavigation SPI
2323         https://bugs.webkit.org/show_bug.cgi?id=180897
2324         <rdar://problem/35535328>
2325
2326         Reviewed by Brent Fulgham.
2327
2328         Test two forms of storage to be sure we are using a different WebsiteDataStore: cookies and sessionStorage.
2329
2330         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2331         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
2332         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:startURLSchemeTask:]):
2333         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2334         (websiteDataStoreTestWebView):
2335         (TEST):
2336
2337 == Rolled over to ChangeLog-2018-01-01 ==