d43838e82b6d6356bef3193fa8c500993fe93bf7
[WebKit-https.git] / Tools / ChangeLog
1 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
2
3         Reviewed by Darin Adler.
4
5         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
6         https://bugs.webkit.org/show_bug.cgi?id=51846
7
8         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
9         back to GRefPtr.
10
11 2011-01-04  Zhe Su  <suzhe@chromium.org>
12
13         Reviewed by Kenneth Russell.
14
15         Fix insertText, setMarkedText and unmarkText methods of
16         TextInputController to call corresponding methods of WebKit::WebView
17         rather than WebKit::WebFrame. This change matches the behavior of
18         chromium browser.
19         insertText corresponds to WebView::confirmComposition(text)
20         setMarkedText corresponds to WebView::setComposition(...)
21         unmarkText corresponds to WebView::confirmComposition()
22         https://bugs.webkit.org/show_bug.cgi?id=51693
23
24         * DumpRenderTree/chromium/TextInputController.cpp:
25         (TextInputController::insertText):
26         (TextInputController::setMarkedText):
27         (TextInputController::unmarkText):
28
29 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
30
31         Reviewed by Laszlo Gombos.
32
33         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
34
35         On Symbian productDir points to the source directory. Removing all the
36         empty files from the productDir directory corrupts the svn repository.
37
38         * Scripts/build-webkit:
39
40 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
41
42         Reviewed by Adam Barth.
43
44         [Qt] Add SelectAll option to the context menu for the editor
45         https://bugs.webkit.org/show_bug.cgi?id=50049
46
47         Set shortcut for the SelectAll action.
48
49         * QtTestBrowser/mainwindow.cpp:
50         (MainWindow::buildUI):
51
52 2011-01-03  David Levin  <levin@chromium.org>
53
54         Reviewed by Eric Seidel.
55
56         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
57         https://bugs.webkit.org/show_bug.cgi?id=51842
58
59         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
60         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
61
62 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
63
64         Reviewed by David Kilzer.
65
66         [WINCE] Adds a build slave.
67         https://bugs.webkit.org/show_bug.cgi?id=50523
68
69         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
70         entry for a release build of the WinCE port.
71         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
72         flag to build the WinCE port.
73
74 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
75
76         Reviewed by David Kilzer.
77
78         Add WinCE support to build-webkit
79         https://bugs.webkit.org/show_bug.cgi?id=51642
80
81         * Scripts/build-webkit:
82         * Scripts/webkitdirs.pm:
83
84 2011-01-03  Eric Seidel  <eric@webkit.org>
85
86         Reviewed by Adam Barth.
87
88         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
89         https://bugs.webkit.org/show_bug.cgi?id=51802
90
91         I'm not the biggest fan of the test_failures or test_results classes,
92         but it's better to have one shared set of classes, than separate ones
93         for new vs. old run-webkit-test result handling.
94
95         This moves the ORWT results class "LayoutTestResults" over to using
96         TestResult and TestFailure classes, making it easy for us to
97         make all our sheriff-bot and other webkitpy code NRWT ready.
98
99         This also makes it a trivial patch to generate results.json information
100         from ORWT results.html files (for flaky test analysis, etc.) as well
101         as making it a one-liner to report test failure types when the
102         commit-queue sees flaky tests.
103
104         This patch tried not to add new functionality, but only to replace
105         the guts of LayoutTestResults, while adding unit tests and hoping
106         not to break anything.
107
108         I also moved callers which assumed User.prompt* were static/class methods
109         to using them as instance methods (since we'll eventually want to make them such).
110
111         In the process of re-writing things, I broke the rebaseline command, so I wrote
112         a unit test to catch my breakage were I do do so again in the future.
113
114         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
115         * Scripts/webkitpy/common/net/layouttestresults.py:
116         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
117         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
118         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
119         * Scripts/webkitpy/tool/commands/queries.py:
120         * Scripts/webkitpy/tool/commands/rebaseline.py:
121         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
122         * Scripts/webkitpy/tool/mocktool.py:
123
124 2011-01-03  Adam Barth  <abarth@webkit.org>
125
126         Reviewed by Simon Fraser.
127
128         webkit-patch shouldn't waste time cleaning a working directory that's already clean
129         https://bugs.webkit.org/show_bug.cgi?id=51840
130
131         * Scripts/webkitpy/common/checkout/scm.py:
132
133 2011-01-03  Adam Barth  <abarth@webkit.org>
134
135         Reviewed by Simon Fraser.
136
137         webkit-patch should only hide update output if --quiet
138         https://bugs.webkit.org/show_bug.cgi?id=51838
139
140         As requested by smfr.
141
142         * Scripts/webkitpy/tool/steps/update.py:
143
144 2011-01-03  Adam Barth  <abarth@webkit.org>
145
146         Reviewed by David Levin.
147
148         commit-queue shouldn't reject patches twice if two bots process the same patch
149         https://bugs.webkit.org/show_bug.cgi?id=51805
150
151         Before raising an error, we first check whether the patch is still in
152         the commit-queue.  This check is still racy, of course, but the time
153         window is much smaller.
154
155         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
156
157 2011-01-03  Sam Weinig  <sam@webkit.org>
158
159         Reviewed by Anders Carlsson.
160
161         Make run-api-tests less chatty.
162         https://bugs.webkit.org/show_bug.cgi?id=51831
163
164         - Make script quiet by default and add --verbose option (replacing --quiet).
165         - When not verbose, pipe stdout and stderr to devnull.
166
167         * Scripts/run-api-tests:
168
169 2011-01-03  Pratik Solanki  <psolanki@apple.com>
170
171         Unreviewed. Adding myself to committers.py.
172
173         * Scripts/webkitpy/common/config/committers.py:
174
175 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
176
177         Reviewed by Xan Lopez.
178
179         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
180         https://bugs.webkit.org/show_bug.cgi?id=51806
181
182         Originally, the $libraryName is 'JavaScriptCore'. When building release 
183         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
184         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
185         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
186         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
187         so make it 'WebKitBuild/Release/.libs'
188
189         * Scripts/webkitdirs.pm: 
190
191 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
192
193         Reviewed by Adam Barth.
194
195         Make EFL a core builder
196         https://bugs.webkit.org/show_bug.cgi?id=51804
197
198         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
199         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
200
201 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
202
203         [Qt] Unreviewed fix after r74855 and r74875.
204
205         * BuildSlaveSupport/built-product-archive:
206          - Create directories explicitly.
207          - Pass shell=True to subprocess.call().
208
209 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
210
211         [Qt] Unreviewed fix after r74855.
212
213         Move JavaScriptCore to Source
214         https://bugs.webkit.org/show_bug.cgi?id=51604
215
216         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
217
218 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
219
220         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
221
222         Move JavaScriptCore to Source
223         https://bugs.webkit.org/show_bug.cgi?id=51604
224
225         * Scripts/webkitdirs.pm:
226
227 2011-01-02  Robert Hogan  <robert@webkit.org>
228
229         Unreviewed, build fix.
230
231         [Qt] Fix DRT build after 74855
232
233         * DumpRenderTree/qt/DumpRenderTree.pro:
234
235 2011-01-01  Adam Barth  <abarth@webkit.org>
236
237         Remove the assumption from the Qt and Gtk builds that every project is
238         in the root directory.
239
240         * Scripts/build-webkit:
241
242 2011-01-01  Adam Barth  <abarth@webkit.org>
243
244         Reviewed by Eric Seidel.
245
246         Teach svn-apply how to apply patches even though JavaScriptCore has moved
247         https://bugs.webkit.org/show_bug.cgi?id=51796
248
249         After this change, svn-apply will magically apply patches to
250         JavaScriptCore/foo to Source/JavaScriptCore/foo.
251
252         * Scripts/VCSUtils.pm:
253
254 2011-01-01  Adam Barth  <abarth@webkit.org>
255
256         Reviewed by Eric Seidel.
257
258         Move JavaScriptCore to Source
259         https://bugs.webkit.org/show_bug.cgi?id=51604
260
261         Update references to JavaScriptCore to point to the new location.
262
263         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
264         * DumpRenderTree/qt/DumpRenderTree.pro:
265         * DumpRenderTree/qt/ImageDiff.pro:
266         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
267         * DumpRenderTree/wscript:
268         * Scripts/build-jsc:
269         * Scripts/build-webkit:
270         * Scripts/do-file-rename:
271         * Scripts/do-webcore-rename:
272         * Scripts/run-javascriptcore-tests:
273         * Scripts/update-javascriptcore-test-results:
274         * Scripts/webkitdirs.pm:
275         * Scripts/webkitpy/common/config/build_unittest.py:
276         * Scripts/webkitpy/style/checker.py:
277         * Scripts/webkitpy/style/checker_unittest.py:
278         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
279         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
280         * WebKitTestRunner/qt/WebKitTestRunner.pro:
281         * wx/build/settings.py:
282
283 2011-01-01  Adam Barth  <abarth@webkit.org>
284
285         Reviewed by Eric Seidel.
286
287         Move Sources to Source
288         https://bugs.webkit.org/show_bug.cgi?id=51794
289
290         Update scripts to point to the new location.
291
292         * Scripts/build-webkit:
293         * Scripts/do-file-rename:
294         * Scripts/do-webcore-rename:
295         * Scripts/webkitpy/common/config/build.py:
296         * Scripts/webkitpy/common/config/build_unittest.py:
297
298 2010-12-31  Kent Tamura  <tkent@chromium.org>
299
300         Reviewed by Eric Seidel.
301
302         [DRT/Chromium] Enable mock spell checker on non-OSX
303         https://bugs.webkit.org/show_bug.cgi?id=51401
304
305         * DumpRenderTree/chromium/WebViewHost.cpp:
306         (WebViewHost::spellCheck):
307
308 2010-12-31  Adam Barth  <abarth@webkit.org>
309
310         Reviewed by Ariya Hidayat.
311
312         Remove Tools/Scripts/wkstyle
313         https://bugs.webkit.org/show_bug.cgi?id=51774
314
315         This script appears to not have been touched in a while and seems to
316         have been replaced by check-webkit-style.
317
318         * Scripts/wkstyle: Removed.
319
320 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
321
322         Unreviewed. Coding style fix.
323
324         * DumpRenderTree/chromium/TestShell.h:
325
326 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
327
328         Reviewed by Pavel Feldman.
329
330         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
331
332         It was a problem with Chromium DRT. DevToolsAgent object instance was
333         attached not only to the inspected page but to the DevTools window too.
334         As result all the inspector files were interpreted as a content of inspected page
335         and were transfered to the DevTools scripts panel for debugging etc.
336
337         https://bugs.webkit.org/show_bug.cgi?id=51735
338
339         * DumpRenderTree/chromium/TestShell.cpp:
340         (TestShell::TestShell):
341         (TestShell::bindJSObjectsToWindow):
342         (TestShell::createNewWindow):
343         * DumpRenderTree/chromium/TestShell.h:
344
345 2010-12-31  Adam Barth  <abarth@webkit.org>
346
347         Rubber-stamped by Eric Seidel.
348
349         Move PageLoadTests to PerformanceTests/PageLoad
350         https://bugs.webkit.org/show_bug.cgi?id=51771
351
352         Update references to PageLoadTests to point to the new location.
353
354         * Scripts/run-pageloadtest:
355         * Scripts/webkitpy/common/config/build.py:
356
357 2010-12-31  Adam Barth  <abarth@webkit.org>
358
359         Rubber-stamped by Eric Seidel.
360
361         Move SunSpider into PerformanceTests
362         https://bugs.webkit.org/show_bug.cgi?id=51769
363
364         Update these scripts to point to the new location.
365
366         * Scripts/run-sunspider:
367         * Scripts/sunspider-compare-results:
368
369 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
370
371         Reviewed by Kent Tamura.
372
373         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
374         https://bugs.webkit.org/show_bug.cgi?id=51728
375         
376         Add implementation of the Mac WebThemeEngine that uses an NSScroller
377         to render top-level scrollbars. This makes them match the Mac port's
378         use of an NSScrollView, which means that we'll be able to share more
379         pixel baselines.
380         
381         The new rendering code will not be activated until the 
382         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
383         ScrollbarThemeChromiumMac.
384
385         * DumpRenderTree/DumpRenderTree.gypi:
386         * DumpRenderTree/chromium/TestShellMac.mm:
387         (platformInit):
388         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
389         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
390         (+[FakeActiveWindow alwaysActiveWindow]):
391         (+[FakeActiveWindow alwaysInactiveWindow]):
392         (-[FakeActiveWindow initWithActiveControls:]):
393         (-[FakeActiveWindow _hasActiveControls]):
394         (WebThemeEngineDRTMac::paintScrollbarThumb):
395         (stateToHIEnableState):
396         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
397         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
398
399 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
400
401         Reviewed by David Kilzer.
402
403         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
404         used
405         https://bugs.webkit.org/show_bug.cgi?id=51672
406
407         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
408         with USE_SYSTEM_MALLOC=1
409         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
410         with USE_SYSTEM_MALLOC=1
411
412 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
413
414         Reviewed by David Kilzer.
415
416         [Qt] [Symbian] Fix build-webkit script for Symbian
417         https://bugs.webkit.org/show_bug.cgi?id=51509
418
419         Set the OUTPUT_DIR for Symbian to be the same as the source
420         directory.
421
422         * Scripts/webkitdirs.pm:
423
424 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
425
426         Reviewed by Darin Adler.
427
428         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
429         https://bugs.webkit.org/show_bug.cgi?id=51758
430
431         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
432
433         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
434         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
435
436 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
437
438         Unreviewed WinCE buildfix.
439
440         * WinCELauncher/main.cpp: Add missing include.
441
442 2010-12-29  Daniel Bates  <dbates@rim.com>
443
444         Reviewed by Darin Adler.
445
446         svn-apply updates date of wrong change log entry for a change log diff that
447         contains two consecutive entries with the same author and date
448         https://bugs.webkit.org/show_bug.cgi?id=46061
449
450         Fixes an issue where the date of the wrong change log entry may be modified.
451         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
452         in a ChangeLog file to the top of the file.
453
454         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
455         diff when it detects that the diff inserts a change log entry earlier in a
456         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
457         change. With the advent of the commit-queue this functionality of bailing out
458         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
459         Instead, we should always move the change log entry to the top of the ChangeLog file.
460
461         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
462         the date line of the correct change log entry in a ChangeLog diff.
463
464         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
465
466         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
467           Updated the following unit tests now that we move entries inserted earlier to the top:
468           - "fixChangeLogPatch: New entry inserted in middle."
469             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
470
471           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
472             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
473
474         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
475
476 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
477
478         Reviewed by Eric Seidel.
479
480         [Qt] Fixed compatibility with gold linker on X11 platforms
481         https://bugs.webkit.org/show_bug.cgi?id=51700
482
483         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
484         Linked TestNetscapePlugin with libX11 on Unix platforms
485
486 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
487
488         Reviewed by Darin Adler.
489
490         Circular dependency in webkitpy.common.checkout.changelog module
491         https://bugs.webkit.org/show_bug.cgi?id=50475
492
493         Remove automatic import of api.Checkout module when any checkout/
494         submodule is imported (e.g.: when checkout.scm.Git is imported).
495
496         * Scripts/webkitpy/common/checkout/__init__.py:
497
498 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
499
500         Reviewed by Ojan Vafai.
501
502         prepare-ChangeLog should support the -g option for specifying the git-commit
503         https://bugs.webkit.org/show_bug.cgi?id=51708
504
505         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
506         webkit-patch, though the exact meaning of the two options remain different.
507
508         * Scripts/prepare-ChangeLog: Add -g.
509
510 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
511
512         Reviewed by Simon Hausmann.
513
514         [Qt] Fix compilation with Qt in namespace
515         https://bugs.webkit.org/show_bug.cgi?id=51701
516
517         * QtTestBrowser/webview.h:
518
519 2010-12-28  Daniel Bates  <dbates@rim.com>
520
521         Reviewed by Sam Weinig.
522
523         Substitute // MARK: for compiler-specific #pragma mark
524         https://bugs.webkit.org/show_bug.cgi?id=51657
525
526         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
527         substituting  "// MARK:" for "#pragma mark", which provides
528         analogous code-bookmarking functionality under Xcode.
529
530         Also, for consistency, we should substitute "// MARK:" for compiler-
531         specific "#pragma mark" in the source files for the Mac port.
532
533         * DumpRenderTree/AccessibilityTextMarker.cpp:
534         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
535         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
536         * DumpRenderTree/mac/ObjCController.m:
537         * MiniBrowser/mac/AppDelegate.m:
538         * MiniBrowser/mac/BrowserWindowController.m:
539
540 2010-12-28  Xan Lopez  <xlopez@igalia.com>
541
542         Reviewed by Eric Seidel.
543
544         Add --no-build option to run-sunspider
545         https://bugs.webkit.org/show_bug.cgi?id=51658
546
547         * Scripts/run-sunspider: add --no-build flag to skip building
548         phase.
549
550 2010-12-27  Daniel Bates  <dbates@rim.com>
551
552         Rubber-stamped by Martin Robinson.
553
554         Append the directory Tools/DumpRenderTree to the list of directories that
555         do-webcore-rename should search so that it can rename DRT files and
556         source code.
557
558         * Scripts/do-webcore-rename:
559
560 2010-12-27  Eric Seidel  <eric@webkit.org>
561
562         Reviewed by Adam Barth.
563
564         build-webkit should detect missing Java SDK and explain how to install it
565         https://bugs.webkit.org/show_bug.cgi?id=51651
566
567         * Scripts/build-webkit:
568
569 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
570
571         Reviewed by Daniel Bates.
572
573         [GTK] Add support for build-jsc
574         https://bugs.webkit.org/show_bug.cgi?id=51625
575
576         Add GTK+ support to build-jsc now that building the jsc executable as
577         a standalone target is easy.
578
579         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
580         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
581         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
582         and pass it along to buildAutotoolsProject.
583
584 2010-12-27  David Levin  <levin@chromium.org>
585
586         Reviewed by Eric Seidel.
587
588         check-webkit-style check for meaningless variable names in function declarations.
589         https://bugs.webkit.org/show_bug.cgi?id=51523
590
591         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
592         from the new check and whitespace/parens because the syntax is unusual and
593         produced a fair number of positives for these checks.
594         * Scripts/webkitpy/style/checkers/cpp.py:
595         (_convert_to_lower_with_underscores): Used as a canonical form for type names
596         and parameter names when determining if the parameter name is useless.
597         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
598         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
599         format.
600         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
601         text or an acronym of it.
602         (check_function_definition): Checks function definitions for meaningless variable names.
603         (process_line): Added call to check_function_definition.
604         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
605         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
606         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
607         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
608         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
609         because when only checking a snippet, there are a lot of bogus functions.
610         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
611         that I put there previously and just noticed.
612         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
613         check_function_definition and process_line.
614
615 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
616
617         Reviewed by Martin Robinson.
618
619         [GTK] Disable flash plugin in GtkLauncher when using gtk3
620         https://bugs.webkit.org/show_bug.cgi?id=51591
621
622         Flash plugin uses gtk2 that is incompatible with gtk3 making
623         webkit crash when it's built with gtk3.
624
625         * GtkLauncher/main.c:
626         (main):
627
628 2010-12-25  Adam Barth  <abarth@webkit.org>
629
630         Reviewed by Eric Seidel.
631
632         Move ANGLE to Sources/ThirdParty
633         https://bugs.webkit.org/show_bug.cgi?id=51605
634
635         * Scripts/build-webkit:
636           - Point to the new ANGLE location.
637
638 2010-12-26  David Levin  <levin@chromium.org>
639
640         Reviewed by Eric Seidel.
641
642         check-webkit-style should be able to parse function declaration parameters.
643         https://bugs.webkit.org/show_bug.cgi?id=51451
644
645         * Scripts/webkitpy/style/checkers/cpp.py:
646         (Position.__init__): Holds simple position information (row, column).
647         (Parameter.__init__): Holds information about a parameter.
648         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
649         (SingleLineView.convert_column_to_row): Returns the original row given a column.
650         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
651         (find_parameter_name_index): Finds where the parameter name is.
652         (parameter_list): Generates the list of parameters for a function.
653         (_FunctionState.begin): Added information to allow determining the parameters
654         on demand.
655         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
656         (detect_functions): Improve function detection for operator functions and
657         determine where the parameters end and pass that to _FunctionState.begin.
658         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
659         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
660         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
661         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
662         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
663         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
664         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
665         (FunctionDetectionTest.perform_function_detection): Added support for verifying
666         the parameters found.
667         (FunctionDetectionTest.test_function_declaration_detection): Added more function
668         detection test to verify that we catch the operator functions.
669         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
670         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
671         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
672         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
673         test_function_length_check_definition_severity1_for_test.
674
675 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
676
677         Unreviewed WinCE buildfix after r74334.
678
679         * CMakeListsWinCE.txt:
680
681 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
682
683         Unreviewed, rolling out r74632.
684         http://trac.webkit.org/changeset/74632
685         https://bugs.webkit.org/show_bug.cgi?id=51600
686
687         makes test-webkitpy hang forever on GTK (Requested by philn-tp
688         on #webkit).
689
690         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
691         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
692
693 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
694
695         Reviewed by Kenneth Rohde Christiansen.
696
697         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
698         https://bugs.webkit.org/show_bug.cgi?id=43528
699
700         Remove on_resize because ewk_view_fixed_layout_size_set should not be
701         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
702         FrameView, rendering was ignored when _ewk_view_smart_calculate was
703         called.
704
705         * EWebLauncher/main.c:
706         (browserCreate):
707
708 2010-12-24  Eric Seidel  <eric@webkit.org>
709
710         Reviewed by Adam Barth.
711
712         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
713         https://bugs.webkit.org/show_bug.cgi?id=28291
714
715         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
716         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
717         to strings with find in the diff.
718         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
719
720         * Scripts/webkitpy/common/checkout/api.py:
721         * Scripts/webkitpy/common/checkout/diff_parser.py:
722         * Scripts/webkitpy/tool/steps/abstractstep.py:
723         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
724         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
725         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
726         * Scripts/webkitpy/tool/steps/validatereviewer.py:
727
728 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
729
730         Reviewed by Kenneth Russell.
731
732         Modify new-run-webkit-tests to shut up and exit when all the threads
733         are wedged so that test runs complete faster and we don't end up
734         w/ enormous log files.
735
736         https://bugs.webkit.org/show_bug.cgi?id=51572
737
738         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
739         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
740
741 2010-12-24  Eric Seidel  <eric@webkit.org>
742
743         Reviewed by David Levin.
744
745         commit-queue should better explain how it will re-open bugs and follow duplicate chains
746         https://bugs.webkit.org/show_bug.cgi?id=51549
747
748         I've had multiple people ask me about the commit-queue's behavior
749         regarding reporting flaky tests.  I figured it would be best to just
750         have the queue explain itself in the bugs it files.
751
752         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
753         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
754
755 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
756
757         Reviewed by Eric Seidel.
758
759         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
760         https://bugs.webkit.org/show_bug.cgi?id=51467
761
762         * Scripts/webkitpy/style/checker.py:
763         * Scripts/webkitpy/style/checker_unittest.py:
764
765 2010-12-23  Adam Barth  <abarth@webkit.org>
766
767         Rubber-stamped by Eric Seidel.
768
769         Move JavaScriptGlue into Sources
770         https://bugs.webkit.org/show_bug.cgi?id=51583
771
772         These tools refer to JavaScriptGlue and need to be updated to its new
773         location.
774
775         * Scripts/build-webkit:
776         * Scripts/do-file-rename:
777         * Scripts/do-webcore-rename:
778         * Scripts/webkitpy/common/config/build.py:
779         * Scripts/webkitpy/common/config/build_unittest.py:
780
781 2010-12-23  Lucas Forschler  <lforschler@apple.com>
782
783         Reviewed by Eric Seidel.
784
785         Bug 51539 - update iexploder scripts to point to new location
786
787         * Scripts/run-iexploder-tests:
788         * Scripts/update-iexploder-cssproperties:
789
790 2010-12-23  Evan Martin  <evan@chromium.org>
791
792         Reviewed by Ryosuke Niwa.
793
794         [chromium] LayoutTestController warning in float->int conversion
795         https://bugs.webkit.org/show_bug.cgi?id=51553
796
797         Rather than reading an int, converting to a float, then getting a compiler
798         warning on passing the float to something that expects an int, instead
799         just pass around ints.
800
801         No tests, fixes a compiler warning.
802
803         * DumpRenderTree/chromium/LayoutTestController.cpp:
804         (parsePageSizeParameters):
805         (LayoutTestController::pageNumberForElementById):
806         (LayoutTestController::numberOfPages):
807
808 2010-12-23  Lucas Forschler  <lforschler@apple.com>
809
810         Reviewed by Darin Adler.
811
812         Bug 51537 - iexploder needs cleanup
813         
814         * iExploder/htdocs: Removed.
815         * iExploder/htdocs/config.rb: Removed.
816         * iExploder/htdocs/cssproperties.in: Removed.
817         * iExploder/htdocs/cssvalues.in: Removed.
818         * iExploder/htdocs/htmlattrs.in: Removed.
819         * iExploder/htdocs/htmltags.in: Removed.
820         * iExploder/htdocs/htmlvalues.in: Removed.
821         * iExploder/htdocs/iexploder.cgi: Removed.
822         * iExploder/htdocs/iexploder.rb: Removed.
823         * iExploder/htdocs/index.html: Removed.
824         * iExploder/htdocs/webserver.rb: Removed.
825         * iExploder/iexploder-1.7.2/output: Removed.
826         * iExploder/tools: Removed.
827         * iExploder/tools/lasthit.rb: Removed.
828         * iExploder/tools/osx_last_crash.rb: Removed.
829         * iExploder/tools/showtest.rb: Removed.
830
831 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
832
833         Reviewed by Kenneth Rohde Christiansen.
834
835         [EFL] Make 'single' the default backing store in EWebLauncher
836         https://bugs.webkit.org/show_bug.cgi?id=51534
837
838         'single' is the simplest backing store and the one intended to be the
839         default in the test browser. By mistake the tiled backing store was
840         left as default in r72617.
841
842         * EWebLauncher/main.c:
843         (browserCreate): ditto.
844
845 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
846
847         Reviewed by Kenneth Rohde Christiansen.
848
849         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
850         https://bugs.webkit.org/show_bug.cgi?id=51533
851
852         There's no point in concatenating env("HOME") with "blah", so remove
853         option from EWebLauncher.
854
855         * EWebLauncher/main.c:
856         (main): ditto.
857
858 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
859
860         Reviewed by Eric Seidel.
861
862         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
863
864         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
865         I just discovered that we have two additional GC runs per each WebViewHost.
866         Test_shell had no such calls.
867         These gc runs eat 15% of cpu time.
868
869         https://bugs.webkit.org/show_bug.cgi?id=51479
870
871         * DumpRenderTree/chromium/WebViewHost.cpp:
872         (WebViewHost::~WebViewHost):
873
874 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
875
876         Reviewed by Ojan Vafai.
877
878         This change splits out the TestRunner class into its own file.
879         When we fork the code for message passing, we will create a new
880         TestRunner, and this change will allow that to be more modular.
881
882         While we're at it, split out TestInput and ResultSummary into
883         their own files, to reduce the size of run_webkit_tests to
884         something more managable.
885
886         https://bugs.webkit.org/show_bug.cgi?id=51092
887
888         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
889         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
890         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
891         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
892         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
893         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
894         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
895
896  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
897
898         Reviewed by Ojan Vafai.
899
900         nrwt multiprocessing - start over, prepare to fork the code
901  
902         This code cleans up the signatures and implementation of the
903         TestRunner class so we can easily fork it to run either the
904         stable implementation or the new, unstable message-passing
905         implementation. The two variants will have different
906         implementations of the run_tests() method. We will switch
907         between the two based on the setting for the '--worker-model'
908         switch. We rename the two currently valid values to 'old-inline'
909         and 'old-threads'.
910
911         https://bugs.webkit.org/show_bug.cgi?id=51081
912
913         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
914         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
915
916 2010-12-22  Victor Wang  <victorw@chromium.org>
917
918         Reviewed by Darin Fisher.
919
920         [Chromium] Update chromium archive test result url in rebaseline script.
921
922         https://bugs.webkit.org/show_bug.cgi?id=51503
923
924         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
925
926 2010-12-22  Lucas Forschler  <lforschler@apple.com>
927
928         Reviewed by Alice Liu.
929
930         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
931         Verified on Chrome, Safari, and IE.
932         With this change, we will record memory from a parent browser window and all child processes.
933
934         * record-memory-win/main.cpp:
935         (ProcessArgs):
936         (PrintUsage):
937         (getMemoryInfo):
938         (printProcessInfo):
939         (evalProcesses):
940         (UseImage):
941         (QueryContinuously):
942         (ElapsedTime):
943
944 2010-12-22  Lucas Forschler  <lforschler@apple.com>
945
946         Unreviewed rollout r74489, because it was missing changelog.
947
948         * record-memory-win/main.cpp:
949         
950 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
951
952         Adding myself as a reviewer.
953
954         * Scripts/webkitpy/common/config/committers.py:
955
956 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
957
958         Unreviewed.  Adding myself to committers.py.
959
960         * Scripts/webkitpy/common/config/committers.py:
961
962 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
963
964         Reviewed by Kenneth Rohde Christiansen.
965
966         TestNetscapePlugIn should use #if defined
967         https://bugs.webkit.org/show_bug.cgi?id=51471
968
969         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
970         (NP_Initialize):
971         (NPP_New):
972
973 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
974
975         Reviewed by Yury Semikhatsky.
976
977         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
978
979         DevTools window should be closed explicitly because it has custom deinitialization code.
980
981         https://bugs.webkit.org/show_bug.cgi?id=50722
982
983         * DumpRenderTree/chromium/TestShell.cpp:
984         (TestShell::closeRemainingWindows):
985
986 2010-12-22  David Levin  <levin@chromium.org>
987
988         Reviewed by Shinichiro Hamaji.
989
990         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
991         https://bugs.webkit.org/show_bug.cgi?id=51452
992
993         * Scripts/webkitpy/style/checkers/cpp.py:
994         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
995         Using the file extension if possible but falling back to the file contents if we have a header file.
996         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
997         (_FileState.is_c_or_objective_c):
998         (check_using_std): Changed to using _FileState to determine the file type.
999         (check_max_min_macros): Ditto.
1000         (check_for_null): Ditto.
1001         (check_style): Changed the parameters to various calls since they now need _FileState
1002         to determine the file type.
1003         (check_language): Added the file_state parameter so it could be passed
1004         to check_identifier_name_in_declaration.
1005         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
1006         this is an Objective C file.
1007         (_process_lines): Added information for the _FileState constructor (and moved the
1008         call to a place that had the information).
1009         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1010         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
1011         its functionality.
1012         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
1013
1014 2010-12-21  Andy Estes  <aestes@apple.com>
1015
1016         Reviewed by Mark Rowe.
1017
1018         Do not build non-Intel architectures for WebKit2-related projects.
1019         https://bugs.webkit.org/show_bug.cgi?id=51440
1020
1021         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
1022         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
1023         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
1024
1025 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
1026
1027         Reviewed by Darin Fisher.
1028
1029         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
1030         https://bugs.webkit.org/show_bug.cgi?id=51406 
1031         
1032         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
1033         to WebThemeEngineDRTWin and update references everywhere.
1034
1035         * DumpRenderTree/DumpRenderTree.gypi:
1036         * DumpRenderTree/chromium/TestShellWin.cpp:
1037         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
1038         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
1039         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
1040         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
1041
1042 2010-12-21  Anders Carlsson  <andersca@apple.com>
1043
1044         Reviewed by John Sullivan.
1045
1046         Clicking missing plug-in text does not show a sheet
1047         https://bugs.webkit.org/show_bug.cgi?id=51403
1048
1049         Update for changes to the WebPageUIClient.
1050
1051         * MiniBrowser/mac/BrowserWindowController.m:
1052         (-[BrowserWindowController awakeFromNib]):
1053         * WebKitTestRunner/TestController.cpp:
1054         (WTR::createOtherPage):
1055         (WTR::TestController::initialize):
1056
1057 2010-12-21  Eric Seidel  <eric@webkit.org>
1058
1059         Reviewed by Adam Barth.
1060
1061         commit-queue will report constant failures as flaky if other tests flake
1062         https://bugs.webkit.org/show_bug.cgi?id=51272
1063
1064         This patch just removes functionality and adds testing.
1065         Previously we attempted to report flaky tests when we had
1066         two different tests fail in a row.  However, since we stop
1067         running the tests at the first failure, our code was wrong in
1068         trying to determine flakiness from the incomplete runs.
1069
1070         Originally I posted an alternate patch:
1071         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
1072         which fixed our flaky logic in this case, however it was decided
1073         that that patch would be too difficult to maintain, so now
1074         I'm just removing the broken logic.
1075
1076         This will dramatically cut-down on our flaky-test false positives
1077         at the (small) cost of the queues being unable to report
1078         any flakiness if the tree is very flaky.  (With at least one test
1079         flaking on every run, we'll never report failures anymore.)  I think
1080         this is a tradeoff worth making.
1081
1082         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1083         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1084
1085 2010-12-20  Eric Seidel  <eric@webkit.org>
1086
1087         Reviewed by Adam Barth.
1088
1089         commit-queue wrongly rejects patches when it can't update itself
1090         https://bugs.webkit.org/show_bug.cgi?id=46636
1091
1092         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1093         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1094         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1095
1096 2010-12-20  Adam Barth  <abarth@webkit.org>
1097
1098         Move web sites to Websites directory
1099         https://bugs.webkit.org/show_bug.cgi?id=51323
1100
1101         Update references to BugsSite to point to the new location.
1102
1103         This patch was never officially reviewed (because it was too large to
1104         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
1105         Rowe gave me the green light.
1106
1107         * Scripts/old-run-webkit-tests:
1108         * Scripts/webkitpy/common/config/build.py:
1109         * Scripts/webkitpy/common/config/build_unittest.py:
1110         * Scripts/webkitpy/common/prettypatch.py:
1111         * Scripts/webkitpy/layout_tests/port/base.py:
1112         * Scripts/webkitpy/style/main.py:
1113
1114 2010-12-20  Adrienne Walker  <enne@google.com>
1115
1116         Unreviewed. Adding myself to the list of committers.
1117
1118         * webkitpy/common/config/committers.py:
1119
1120 2010-12-20  Mark Rowe  <mrowe@apple.com>
1121
1122         Reviewed by Dan Bernstein.
1123
1124         <rdar://problem/8757601> Don't install header files in to the Resources directory.
1125
1126         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
1127         Resources directory.
1128
1129 2010-12-20  Eric Seidel  <eric@webkit.org>
1130
1131         Reviewed by Adam Barth.
1132
1133         commit-queue should include bot id when attaching failure diffs
1134         https://bugs.webkit.org/show_bug.cgi?id=51280
1135
1136         This is a tiny change to include the bot id in the name of the attachment.
1137         Most of this diff is just changing the unit test expectations
1138         now that I hid the comment printing when the comment is None.
1139
1140         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1141         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1142         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1143         * Scripts/webkitpy/tool/mocktool.py:
1144
1145 2010-12-20  Jeff Miller  <jeffm@apple.com>
1146
1147         Reviewed by Dan Bernstein.
1148
1149         Tools/vcbin/midl.exe needs to be rebuilt
1150         https://bugs.webkit.org/show_bug.cgi?id=51347
1151
1152         * vcbin/midl.exe: Rebuilt.
1153
1154 2010-12-20  David Levin  <levin@chromium.org>
1155
1156         Reviewed by Ariya Hidayat.
1157
1158         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
1159         https://bugs.webkit.org/show_bug.cgi?id=51343
1160
1161         Follow up from the WebKitTools -> Tools rename.
1162
1163         * Scripts/webkit-tools-completion.sh:
1164
1165 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
1166
1167         Reviewed by James Robinson.
1168
1169         new-run-webkit-tests ignores trailing EOL differences in text tests
1170         https://bugs.webkit.org/show_bug.cgi?id=36983
1171
1172         Changed the handling of new-line characters within new-run-webkit-tests
1173         to match old-run-webkit-tests.  Differences in leading and trailing empty
1174         lines in text expectation files are no longer ignored.
1175
1176         * Scripts/webkitpy/layout_tests/port/base.py:
1177         * Scripts/webkitpy/layout_tests/port/test.py:
1178         Added unit tests.  Removed old duplicate unit test entries.
1179         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1180
1181 2010-12-20  David Levin  <levin@chromium.org>
1182
1183         Reviewed by Shinichiro Hamaji.
1184
1185         check-webkit-style should detect function declarations (and trivial functions).
1186         https://bugs.webkit.org/show_bug.cgi?id=51303
1187
1188         * Scripts/webkitpy/style/checkers/cpp.py:
1189         (_FunctionState.begin): Add is_declaration and changed the line count
1190         start to begin at -1 (which will keep the results consistent, since
1191         the starting line number passed in is one less in this change).
1192         (detect_functions): changed function detection to now catch trivial
1193         functions and declarations.
1194         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
1195         of the function as this may look at return values (when processing
1196         a declaration).
1197         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1198         (FunctionDetectionTest.perform_function_detection): Basic mechanics
1199         of testing the function detection.
1200         (FunctionDetectionTest.test_basic_function_detection): Test a simple
1201         function.
1202         (FunctionDetectionTest.test_function_declaration_detection): Test a
1203         declaration.
1204         (FunctionDetectionTest.test_non_functions): A test case for a case
1205         that caused the code to fail due to the { being in quotes.
1206         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
1207         cases to help catch false alarms for return values.
1208         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
1209         we don't get false alarms for member variables either.
1210
1211 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
1212
1213         Reviewed by Antonio Gomes.
1214
1215         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
1216         https://bugs.webkit.org/show_bug.cgi?id=51319
1217
1218         * CMakeListsEfl.txt:
1219
1220 2010-12-18  Adam Barth  <abarth@webkit.org>
1221
1222         Reviewed by Sam Weinig.
1223
1224         Move WebKitExamplePlugins to Examples
1225         https://bugs.webkit.org/show_bug.cgi?id=51291
1226
1227         * Scripts/webkitpy/common/config/build.py:
1228
1229 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
1230
1231         Unreviewed Qt buildfix after r74301.
1232
1233         Rename WebKitTools to Tools
1234         https://bugs.webkit.org/show_bug.cgi?id=49861
1235
1236         * MiniBrowser/DerivedSources.pro:
1237         * MiniBrowser/qt/MiniBrowser.pro:
1238
1239 2010-12-17  Dan Bernstein  <mitz@apple.com>
1240
1241         Reviewed by Simon Fraser.
1242
1243         Rename WebKitTools to Tools
1244         https://bugs.webkit.org/show_bug.cgi?id=49861
1245
1246         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1247         * CodeCoverage/README:
1248         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1249         (WebCore::DumpRenderTree::initializeFonts):
1250         * EWSTools/start-commit-queue.sh:
1251         * EWSTools/start-queue.sh:
1252         * GNUmakefile.am:
1253         * MIDLWrapper/MIDLWrapper.cpp:
1254         (wmain):
1255         * MiniBrowser/qt/MiniBrowser.pro:
1256         * Scripts/build-api-tests:
1257         * Scripts/build-dumprendertree:
1258         * Scripts/build-webkit:
1259         * Scripts/build-webkittestrunner:
1260         * Scripts/generate-coverage-data:
1261         * Scripts/old-run-webkit-tests:
1262         * Scripts/run-api-tests:
1263         * Scripts/run-iexploder-tests:
1264         * Scripts/run-javascriptcore-tests:
1265         * Scripts/run-mangleme-tests:
1266         * Scripts/run-sunspider:
1267         * Scripts/run-webkit-websocketserver:
1268         * Scripts/sunspider-compare-results:
1269         * Scripts/test-webkitperl:
1270         * Scripts/test-webkitpy:
1271         * Scripts/update-iexploder-cssproperties:
1272         * Scripts/update-webkit:
1273         * Scripts/update-webkit-localizable-strings:
1274         * Scripts/webkitdirs.pm:
1275         * Scripts/webkitpy/common/checkout/scm.py:
1276         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1277         * Scripts/webkitpy/common/config/committervalidator.py:
1278         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
1279         * Scripts/webkitpy/common/config/ports.py:
1280         * Scripts/webkitpy/common/config/ports_unittest.py:
1281         * Scripts/webkitpy/common/system/logutils_unittest.py:
1282         * Scripts/webkitpy/common/system/ospath_unittest.py:
1283         * Scripts/webkitpy/layout_tests/port/chromium.py:
1284         * Scripts/webkitpy/layout_tests/port/config.py:
1285         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1286         * Scripts/webkitpy/layout_tests/port/http_server.py:
1287         * Scripts/webkitpy/layout_tests/port/test.py:
1288         * Scripts/webkitpy/style/checker.py:
1289         * Scripts/webkitpy/style/checker_unittest.py:
1290         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1291         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1292         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1293         * WebKitTestRunner/DerivedSources.pro:
1294         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1295         (WTR::activateFonts):
1296         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1297         * wx/build/build_utils.py:
1298
1299 2010-12-16  Antonio Gomes  <agomes@rim.com>
1300
1301         Reviewed by Martin Robinson.
1302
1303         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
1304         https://bugs.webkit.org/show_bug.cgi?id=51163
1305
1306         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
1307         GTK+'s DRT should also reset to UNIX after each test execution.
1308
1309         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1310         (resetDefaultsToConsistentValues):
1311
1312 2010-12-17  David Levin  <levin@chromium.org>
1313
1314         Reviewed by Eric Seidel.
1315
1316         check-webkit-style should understand WTF #include guards
1317         https://bugs.webkit.org/show_bug.cgi?id=44911
1318
1319         * Scripts/webkitpy/style/checkers/cpp.py:
1320         (get_header_guard_cpp_variable): modify to suggest the WTF style
1321         of header guard when appropriate.
1322         (check_for_header_guard): handle multiple return values from
1323         get_header_guard_cpp_variable
1324         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1325         (CppStyleTest.test_build_header_guard): Added tests for the WTF
1326         header style.
1327
1328 2010-12-16  David Levin  <levin@chromium.org>
1329
1330         Reviewed by Eric Seidel.
1331
1332         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
1333         https://bugs.webkit.org/show_bug.cgi?id=51210
1334
1335         The error only shows up when using python 2.6 or later.
1336
1337         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
1338         the decprecated field error,message with something equivalent.
1339
1340 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
1341
1342         Reviewed by Eric Seidel.
1343
1344         Add --exit-after-n-failures/crashes to NRWT
1345         https://bugs.webkit.org/show_bug.cgi?id=51160
1346         
1347         Abort test run (in a similar way to how control-C is handled) when
1348         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
1349         that number of unexpected failures/crashes/timeouts.
1350
1351         * Scripts/webkitpy/layout_tests/port/test.py:
1352         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1353         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1354
1355 2010-12-16  David Levin  <levin@chromium.org>
1356
1357         Reviewed by Shinichiro Hamaji.
1358
1359         check-webkit-style unit tests has some duplicate boilerplate code.
1360         https://bugs.webkit.org/show_bug.cgi?id=49519
1361
1362         * Scripts/webkitpy/style/checkers/cpp.py:
1363         (update_include_state): Replaced the "io" parameter with the global
1364         configuration _unit_test_config. This allowed not calling into
1365         functions at a low level and also not plumbing through the injection
1366         information through many levels of code.
1367         (check_for_include_what_you_use): Ditto.
1368         (process_file_data): Added the ability to set up the unit test config
1369         to allow for injection.
1370         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1371         (ErrorCollector.__init__): Added support for having a filter for errors.
1372         (ErrorCollector.__call__): Ditto.
1373         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
1374         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
1375         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
1376         functions in the cpp.py with generic processing and a filter that
1377         indicates what errors should be kept.
1378         (CppStyleTestBase.perform_multi_line_lint): Ditto.
1379         (CppStyleTestBase.perform_language_rules_check): Ditto.
1380         (CppStyleTestBase.perform_function_lengths_check): Ditto.
1381         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
1382         (CppStyleTestBase.perform_include_what_you_use): Ditto.
1383         (CppStyleTest.test_multi_line_comments): Added another
1384         error message which applies to the test case.
1385         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
1386         to not have config.h, since it is processed as a header file.
1387         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
1388         style and indentation in checked code.
1389         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
1390         Fixed line number.
1391         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
1392         Ditto.
1393
1394 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
1395
1396         Unreviewed, rolling out r74136.
1397         http://trac.webkit.org/changeset/74136
1398         https://bugs.webkit.org/show_bug.cgi?id=51135
1399
1400         r74136 breaks chromium canary bots because some tests are not
1401         rebaselined correctly to resolve EOL differences (Requested by
1402         jianli on #webkit).
1403
1404         * Scripts/webkitpy/layout_tests/port/base.py:
1405         * Scripts/webkitpy/layout_tests/port/test.py:
1406         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1407
1408 2010-12-15  Adam Roben  <aroben@apple.com>
1409
1410         Teach check-webkit-style to check .vcproj and .vsprops files for XML
1411         syntax errors
1412
1413         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
1414         XML syntax errors in .vcproj/.vsprops files
1415
1416         Reviewed by Dave Levin.
1417
1418         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
1419         that should be treated as XML and that should be allowed to contain
1420         carriage returns. (These lists happen to be identical currently.)
1421         (FileType): Added a new XML type.
1422         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
1423         Just does a simple file extension check.
1424         (CheckerDispatcher._file_type): Added a case for XML files.
1425         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
1426         files (surprise!).
1427         (StyleProcessor.process): Ask the dispatcher whether we should pass the
1428         lines through the carriage checker.
1429
1430         * Scripts/webkitpy/style/checker_unittest.py:
1431         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
1432         Added. Checks a few file names to see if carriage returns are allowed
1433         or not.
1434         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
1435         other assert_checker_* functions.
1436         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
1437         test_*_paths functions.
1438         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
1439         test_*_paths functions.
1440         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
1441         file from this test case, as vcproj files now have a type.
1442         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
1443         Added. Similar to the other should_* functions.
1444         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
1445         Added. Checks that carriage returns aren't checked for or stripped for
1446         allowed files.
1447
1448         * Scripts/webkitpy/style/checkers/xml.py: Added.
1449         (XMLChecker.__init__): Simple init method.
1450         (XMLChecker.check): Pass each line through the expat parser, and record
1451         a style error for any errors thrown by the parser.
1452
1453         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
1454         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
1455         produce a style error.
1456         (XMLCheckerTest.assert_error): Checks that the given XML produces an
1457         error of the given category on the given line.
1458         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
1459         checking that the XMLChecker constructor works properly.
1460         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
1461         cause a style error (see, e.g., r73887).
1462         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
1463         cause a style error (see, e.g., r73773).
1464         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
1465         properly.
1466         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
1467         tags cause a style error (see, e.g., r72795).
1468         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
1469         style error.
1470
1471 2010-12-15  Lucas Forschler  <lforschler@apple.com>
1472
1473         Reviewed by Stephanie Lewis.
1474
1475         https://bugs.webkit.org/show_bug.cgi?id=51117
1476         Add a new leopard test bot
1477         really really commit to trunk this time.
1478
1479         * BuildSlaveSupport/build.webkit.org-config/config.json:
1480
1481 2010-12-15  Sam Weinig  <sam@webkit.org>
1482
1483         Reviewed by Anders Carlsson.
1484
1485         WebKit2: Can't add files to an <input type=file>
1486         https://bugs.webkit.org/show_bug.cgi?id=51087
1487
1488         * MiniBrowser/mac/BrowserWindowController.m:
1489         (runOpenPanel):
1490         (-[BrowserWindowController awakeFromNib]):
1491         Add simple implementation of runOpenPanel callback.
1492
1493         * MiniBrowser/win/BrowserView.cpp:
1494         (BrowserView::create):
1495         * WebKitTestRunner/TestController.cpp:
1496         (WTR::createOtherPage):
1497         (WTR::TestController::initialize):
1498         Stub out runOpenPanel callback. 
1499
1500 2010-12-14  Eric Seidel  <eric@webkit.org>
1501
1502         Reviewed by Adam Barth.
1503
1504         commit-queue should upload failure diffs when tests flake
1505         https://bugs.webkit.org/show_bug.cgi?id=51051
1506
1507         To make this testable I needed to pipe FileSystem down onto tool.
1508         We've wanted it there for a long time anyway.
1509
1510         This patch is kinda a big hack.  But we don't have a nice
1511         way to read results.html files.  I think this will need further
1512         revision before this code actually feels clean.
1513
1514         As part of testing this change, I had to make MockBugzilla.create_bug
1515         actually return an id (like it should) which required updating
1516         a few other unit test results (for the better).
1517
1518         The results_matching_keys change in layouttestresults/rebasline
1519         was an alternate path which I decided not to use in the end, but
1520         I left the change as it seemed an improvement.
1521
1522         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1523         * Scripts/webkitpy/common/net/layouttestresults.py:
1524         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1525         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1526         * Scripts/webkitpy/tool/commands/queues.py:
1527         * Scripts/webkitpy/tool/commands/rebaseline.py:
1528         * Scripts/webkitpy/tool/main.py:
1529         * Scripts/webkitpy/tool/mocktool.py:
1530
1531 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
1532
1533         Reviewed by James Robinson.
1534
1535         new-run-webkit-tests ignores trailing EOL differences in text tests
1536         https://bugs.webkit.org/show_bug.cgi?id=36983
1537
1538         Changed the handling of new-line characters within new-run-webkit-tests
1539         to match old-run-webkit-tests.  Differences in leading and trailing empty
1540         lines in text expectation files are no longer ignored.
1541
1542         * Scripts/webkitpy/layout_tests/port/base.py:
1543         * Scripts/webkitpy/layout_tests/port/test.py:
1544         Added unit tests.  Removed old duplicate unit test entries.
1545         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1546
1547 2010-12-15  Ojan Vafai  <ojan@chromium.org>
1548
1549         Reviewed by Adam Barth.
1550
1551         make status-bubble white-space:nowrap so we can measure it's width without wrapping
1552         https://bugs.webkit.org/show_bug.cgi?id=51149
1553
1554         * QueueStatusServer/templates/statusbubble.html:
1555
1556 2010-12-15  Ojan Vafai  <ojan@chromium.org>
1557
1558         Reviewed by Adam Barth.
1559
1560         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
1561         https://bugs.webkit.org/show_bug.cgi?id=51125
1562
1563         * QueueStatusServer/templates/statusbubble.html:
1564
1565 2010-12-15  Darin Adler  <darin@apple.com>
1566
1567         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
1568
1569 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
1570
1571         Unreviewed, rolling out r74117.
1572         http://trac.webkit.org/changeset/74117
1573         https://bugs.webkit.org/show_bug.cgi?id=51113
1574
1575         This broke the GTK1 build. (Requested by mrobinson on
1576         #webkit).
1577
1578         * Scripts/webkitdirs.pm:
1579
1580 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
1581
1582         Reviewed by Martin Robinson.
1583
1584         Change generate-forwarding-headers.pl for GTK port usage 
1585         (https://bugs.webkit.org/show_bug.cgi?id=37369)
1586
1587         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
1588
1589 2010-12-14  Kent Tamura  <tkent@chromium.org>
1590
1591         Reviewed by Jian Li.
1592
1593         [DRT/Chromium] Remove another unnecessary error message
1594         https://bugs.webkit.org/show_bug.cgi?id=51083
1595
1596         * DumpRenderTree/chromium/WebViewHost.cpp:
1597         (WebViewHost::didInvalidateRect):
1598
1599 2010-12-14  Lucas Forschler  <lforschler@apple.com>
1600
1601         Reviewed by Stephanie Lewis.
1602
1603         Add a new Leopard Debug Test WK2 Bot
1604
1605         * BuildSlaveSupport/build.webkit.org-config/config.json:
1606
1607 2010-12-14  Ojan Vafai  <ojan@chromium.org>
1608
1609         Fix python unittests after http://trac.webkit.org/changeset/74070.
1610
1611         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1612
1613 2010-12-14  Kent Tamura  <tkent@chromium.org>
1614
1615         Reviewed by Jian Li.
1616
1617         [DRT/Chromium] Remove a unnecessary error message
1618         https://bugs.webkit.org/show_bug.cgi?id=51069
1619
1620         * DumpRenderTree/chromium/WebViewHost.cpp:
1621         (WebViewHost::paintInvalidatedRegion):
1622
1623 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
1624
1625         Reviewed by Ojan Vafai.
1626
1627         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
1628         https://bugs.webkit.org/show_bug.cgi?id=48926
1629
1630         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1631         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
1632
1633 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1634
1635         Reviewed by Eric Seidel.
1636
1637         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
1638         https://bugs.webkit.org/show_bug.cgi?id=50231
1639
1640         Guard CONFIG+=link_pkgconfig with !symbian.
1641
1642         * DumpRenderTree/qt/DumpRenderTree.pro:
1643         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1644         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1645
1646 2010-12-14  Philippe Normand  <pnormand@igalia.com>
1647
1648         Reviewed by Ojan Vafai.
1649
1650         [new-run-webkit-tests] expectations parsing is slow
1651         https://bugs.webkit.org/show_bug.cgi?id=50635
1652
1653         Avoid expensive iteration of all the tests when checking if a test
1654         file is to be skipped or not.
1655
1656         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1657         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1658         * Scripts/webkitpy/layout_tests/port/test.py:
1659
1660 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
1661
1662         Reviewed by Xan Lopez.
1663
1664         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
1665         https://bugs.webkit.org/show_bug.cgi?id=27048
1666
1667         Add support in DRT for checking whether an accessibility UI
1668         element is focusable and/or focused. Implemented for GTK.
1669
1670         * DumpRenderTree/AccessibilityUIElement.cpp:
1671         (getIsFocusedCallback): New.
1672         (getIsFocusableCallback): New.
1673         (AccessibilityUIElement::getJSClass): Add the new available
1674         callbacks for isFocused and isFocusable.
1675         * DumpRenderTree/AccessibilityUIElement.h:
1676         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1677         (AccessibilityUIElement::isFocused): New, implemented by checking
1678         whether the related AtkState value is in the object's state set.
1679         (AccessibilityUIElement::isFocusable): Ditto.
1680         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1681         (AccessibilityUIElement::isFocused): New, dummy implementation.
1682         (AccessibilityUIElement::isFocusable): Ditto.
1683         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1684         (AccessibilityUIElement::isFocused): Ditto.
1685         (AccessibilityUIElement::isFocusable): Ditto.
1686
1687 2010-12-14  Eric Seidel  <eric@webkit.org>
1688
1689         Reviewed by Ojan Vafai.
1690
1691         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
1692         https://bugs.webkit.org/show_bug.cgi?id=50715
1693
1694         This patch makes webkit-patch print the following:
1695
1696         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
1697         Install a 64-bit git for better performance, see:
1698         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
1699
1700         I wrote this mostly because I have approximately 8 machines that I use
1701         and making sure each one is using a good Git install seemed folly.
1702         webkit-patch makes a lot of git calls, so using a fast git can shave
1703         several seconds in every invocation.  See the webkit-dev thread for more info.
1704
1705         This message will print twice during 'webkit-patch upload',
1706         once from webkit-patch and once from check-webkit-style.
1707
1708         Unfortunately there is no good way to test this due to how machine-dependent
1709         the code is.  I considered writing a test for the log message, but it seemed not worth it.
1710
1711         * Scripts/webkitpy/common/checkout/scm.py:
1712
1713 2010-12-13  Eric Seidel  <eric@webkit.org>
1714
1715         Reviewed by Adam Barth.
1716
1717         FlakyTestReporter doesn't understand bots running from multiple email addresses
1718         https://bugs.webkit.org/show_bug.cgi?id=50960
1719
1720         This explains at least one of the dupes of:
1721         https://bugs.webkit.org/show_bug.cgi?id=50863
1722         that we saw filed by the commit-queue this morning.
1723         I think the other one was explained by my previous fix to result counting code.
1724
1725         Since this is really hard to test with a unit test, instead I
1726         create a new (possibly useful in the future) command
1727         which given a layout test path will return you
1728         the one bug which our tools would assume it the flaky test bug.
1729         If some other script wants to use bug-for-test we'll
1730         need to extend it with some options like --create-if-missing or similar.
1731
1732         * Scripts/webkitpy/common/net/bugzilla/bug.py:
1733         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1734         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1735         * Scripts/webkitpy/tool/commands/__init__.py:
1736         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
1737
1738 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
1739
1740         Reviewed by James Robinson.
1741
1742         Add option to build-webkit to not build WebKit2
1743         https://bugs.webkit.org/show_bug.cgi?id=50988
1744         
1745         Add support for a --no-webkit2 option to build-webkit. It seems to save
1746         ~1 minute from clean builds and ~10 seconds from no-op builds.
1747
1748         * Scripts/build-webkit:
1749
1750 2010-12-13  Lucas Forschler  <lforschler@apple.com>
1751
1752         Reviewed by Dave Kilzer.
1753
1754         Update iexploder from 1.3.2 to 1.7.2
1755         Move 1.3.2 into its own subdir
1756         Add 1.7.2 into its own subdir
1757         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
1758
1759         * Scripts/run-iexploder-tests:
1760         * Scripts/update-iexploder-cssproperties:
1761         * iExploder/CHANGELOG.txt: Removed.
1762         * iExploder/LICENSE.txt: Removed.
1763         * iExploder/README.txt: Removed.
1764         * iExploder/htdocs: Removed.
1765         * iExploder/iexploder-1.3.2: Added.
1766         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
1767         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
1768         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
1769         * iExploder/iexploder-1.3.2/htdocs: Added.
1770         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
1771         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
1772         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
1773         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
1774         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
1775         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
1776         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
1777         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
1778         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
1779         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
1780         * iExploder/iexploder-1.3.2/tools: Added.
1781         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
1782         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
1783         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
1784         * iExploder/iexploder-1.7.2: Added.
1785         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
1786         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
1787         * iExploder/iexploder-1.7.2/README.txt: Added.
1788         * iExploder/iexploder-1.7.2/output: Added.
1789         * iExploder/iexploder-1.7.2/src: Added.
1790         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
1791         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
1792         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
1793         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
1794         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
1795         * iExploder/iexploder-1.7.2/src/css-properties: Added.
1796         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
1797         * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
1798         * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
1799         * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
1800         * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
1801         * iExploder/iexploder-1.7.2/src/css-pseudo: Added.
1802         * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
1803         * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
1804         * iExploder/iexploder-1.7.2/src/css-values: Added.
1805         * iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
1806         * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
1807         * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
1808         * iExploder/iexploder-1.7.2/src/css-values/other: Added.
1809         * iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
1810         * iExploder/iexploder-1.7.2/src/headers: Added.
1811         * iExploder/iexploder-1.7.2/src/headers/dillo: Added.
1812         * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
1813         * iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
1814         * iExploder/iexploder-1.7.2/src/headers/webkit: Added.
1815         * iExploder/iexploder-1.7.2/src/html-attrs: Added.
1816         * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
1817         * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
1818         * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
1819         * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
1820         * iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
1821         * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
1822         * iExploder/iexploder-1.7.2/src/html-tags: Added.
1823         * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
1824         * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
1825         * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
1826         * iExploder/iexploder-1.7.2/src/html-tags/other: Added.
1827         * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
1828         * iExploder/iexploder-1.7.2/src/html-values: Added.
1829         * iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
1830         * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
1831         * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
1832         * iExploder/iexploder-1.7.2/src/html-values/other: Added.
1833         * iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
1834         * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
1835         * iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
1836         * iExploder/iexploder-1.7.2/src/index.html: Added.
1837         * iExploder/iexploder-1.7.2/src/media: Added.
1838         * iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
1839         * iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
1840         * iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
1841         * iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
1842         * iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
1843         * iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
1844         * iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
1845         * iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
1846         * iExploder/iexploder-1.7.2/src/media/bug.png: Added.
1847         * iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
1848         * iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
1849         * iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
1850         * iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
1851         * iExploder/iexploder-1.7.2/src/mime-types: Added.
1852         * iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
1853         * iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
1854         * iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
1855         * iExploder/iexploder-1.7.2/src/protocols: Added.
1856         * iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
1857         * iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
1858         * iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
1859         * iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
1860         * iExploder/iexploder-1.7.2/src/scanner.rb: Added.
1861         * iExploder/iexploder-1.7.2/src/version.rb: Added.
1862         * iExploder/iexploder-1.7.2/src/webserver.rb: Added.
1863         * iExploder/iexploder-1.7.2/testcases: Added.
1864         * iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
1865         * iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
1866         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added.
1867         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added.
1868         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added.
1869         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added.
1870         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added.
1871         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added.
1872         * iExploder/iexploder-1.7.2/tools: Added.
1873         * iExploder/iexploder-1.7.2/tools/lasthit.rb: Added.
1874         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added.
1875         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added.
1876         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added.
1877         * iExploder/tools: Removed.
1878
1879 2010-12-13  Sam Weinig  <sam@webkit.org>
1880
1881         Reviewed by Anders Carlsson.
1882
1883         Remove associated page concept from WKView constructor
1884         https://bugs.webkit.org/show_bug.cgi?id=50983
1885
1886         Step 1: Remove associate page constructors from WKView and make
1887         all views use the shared namespace for the context.
1888
1889         * TestWebKitAPI/PlatformWebView.h:
1890         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1891         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
1892         * WebKitTestRunner/PlatformWebView.h:
1893         * WebKitTestRunner/TestController.cpp:
1894         (WTR::createOtherPage):
1895         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1896         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1897         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1898
1899 2010-12-13  Sam Weinig  <sam@webkit.org>
1900
1901         Reviewed by Anders Carlsson.
1902
1903         Change the WebKit2 public API so there is no explicit WKPageNamespace object
1904         https://bugs.webkit.org/show_bug.cgi?id=50898
1905
1906         * MiniBrowser/mac/AppDelegate.h:
1907         * MiniBrowser/mac/AppDelegate.m:
1908         * MiniBrowser/mac/BrowserWindowController.h:
1909         * MiniBrowser/mac/BrowserWindowController.m:
1910         * MiniBrowser/win/BrowserView.cpp:
1911         Convert MiniBrowser to not use PageNamespaces.
1912
1913         * TestWebKitAPI/PlatformWebView.h:
1914         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
1915         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
1916         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
1917         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
1918         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
1919         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
1920         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
1921         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1922         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1923         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
1924         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1925         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
1926         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
1927         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1928         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
1929         Convert TestWebKitAPI to not use PageNamespaces.
1930
1931         * WebKitTestRunner/PlatformWebView.h:
1932         * WebKitTestRunner/TestController.cpp:
1933         * WebKitTestRunner/TestController.h:
1934         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1935         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1936         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1937         Convert WebKitTestRunner to not use PageNamespaces.
1938
1939 2010-12-13  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1940
1941         Reviewed by Eric Seidel.
1942
1943         webkit-patch rollout should be able to do multi-revision rollouts
1944         https://bugs.webkit.org/show_bug.cgi?id=33336
1945
1946         Make it possible to pass more than one revision to webkit-patch.
1947
1948         * Scripts/webkitpy/common/checkout/api.py:
1949         * Scripts/webkitpy/common/checkout/changelog.py:
1950         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1951         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
1952         * Scripts/webkitpy/tool/commands/download.py:
1953         * Scripts/webkitpy/tool/commands/download_unittest.py:
1954         * Scripts/webkitpy/tool/mocktool.py:
1955         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1956         * Scripts/webkitpy/tool/steps/revertrevision.py:
1957
1958 2010-12-13  Eric Seidel  <eric@webkit.org>
1959
1960         Unreviewed.
1961
1962         Teach webkit-patch how to search bugzilla
1963         https://bugs.webkit.org/show_bug.cgi?id=50500
1964
1965         webkit-patch bug-search fails when there is only one result.
1966         Turns out we needed a bit more logic in our result count parsing code.
1967
1968         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1969         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1970
1971 2010-12-13  Antti Koivisto  <antti@apple.com>
1972
1973         Reviewed by Alexey Proskuryakov.
1974
1975         Add setSerializeHTTPLoads function to allow testing resource load order on OS X.
1976         https://bugs.webkit.org/show_bug.cgi?id=50758
1977
1978         * DumpRenderTree/LayoutTestController.cpp:
1979         (setSerializeHTTPLoadsCallback):
1980         (LayoutTestController::staticFunctions):
1981         * DumpRenderTree/LayoutTestController.h:
1982         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1983         (LayoutTestController::setSerializeHTTPLoads):
1984         * DumpRenderTree/mac/DumpRenderTree.mm:
1985         (resetDefaultsToConsistentValues):
1986         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1987         (LayoutTestController::setSerializeHTTPLoads):
1988         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1989         (LayoutTestController::setSerializeHTTPLoads):
1990
1991 2010-12-13  Dimitri Glazkov  <dglazkov@chromium.org>
1992
1993         Reviewed by Ojan Vafai.
1994
1995         Remove "use-drt" option from test step command line, since the option was removed in r73748.
1996         https://bugs.webkit.org/show_bug.cgi?id=50936
1997
1998         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed the option.
1999
2000 2010-12-13  Patrick Gansterer  <paroga@webkit.org>
2001
2002         Reviewed by Csaba Osztrogonác.
2003
2004         Add revlink to BuildBot status
2005         https://bugs.webkit.org/show_bug.cgi?id=50914
2006
2007         This adds a hyperlink to trac changeset on the revision numbers. 
2008
2009         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2010
2011 2010-12-13  Andras Becsi  <abecsi@webkit.org>
2012
2013         Reviewed by Csaba Osztrogonác.
2014
2015         [Qt][WK2] Fix build if WebKitTools are not available
2016         https://bugs.webkit.org/show_bug.cgi?id=50242
2017
2018         * MiniBrowser/qt/MiniBrowser.pro: Correct the comment.
2019         * Scripts/webkitdirs.pm: Added WebKitTools/MiniBrowser to $subdirs.
2020         * MiniBrowser/DerivedSources.pro: Added.
2021
2022 2010-12-13  Eric Seidel  <eric@webkit.org>
2023
2024         Reviewed by Adam Barth.
2025
2026         EWS Queues should remove orpahned pyc files before starting
2027         https://bugs.webkit.org/show_bug.cgi?id=50904
2028
2029         A previous check added a platform.py which caused
2030         EWS bots on some platforms to hit an import exception.
2031         The platform.py file was removed in a subsequent commit, but
2032         the EWS bots in question stayed stuck.  This change will
2033         fix those bots once restarted (and prevent this in the future).
2034
2035         I also went ahead and unified start-queue and start-commit-queue
2036         since they were nearly identical.  I also added bot_id support
2037         to both force all EWSes to have bot ids as well as get rid of the one
2038         remaining reason why I had my own copies of these scripts.
2039         Hopefully this will be enough to get all the other bot admins
2040         (ahem, Adam, ahem) to move to using these checked in copies as well.
2041
2042         * EWSTools/start-commit-queue.sh: Removed.
2043         * EWSTools/start-queue.sh:
2044
2045 2010-10-28  MORITA Hajime  <morrita@google.com>
2046
2047         Reviewed by Ojan Vafai.
2048
2049         spellcheck does not check pasted text
2050         https://bugs.webkit.org/show_bug.cgi?id=40092
2051
2052         Added LayoutTestController::setAsynchronousSpellCheckingEnabled()
2053         to control the setting.
2054
2055         * DumpRenderTree/LayoutTestController.cpp:
2056         (setAsynchronousSpellCheckingEnabledCallback):
2057         (LayoutTestController::staticFunctions):
2058         * DumpRenderTree/LayoutTestController.h:
2059         * DumpRenderTree/chromium/LayoutTestController.h:
2060         * DumpRenderTree/chromium/LayoutTestController.cpp:
2061         (LayoutTestController::LayoutTestController):
2062         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
2063         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2064         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
2065         * DumpRenderTree/mac/DumpRenderTree.mm:
2066         (resetDefaultsToConsistentValues):
2067         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2068         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
2069         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2070         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2071         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
2072         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2073         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
2074         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2075         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
2076
2077 2010-12-12  Sam Weinig  <sam@webkit.org>
2078
2079         Reviewed by Anders Carlsson.
2080
2081         Fix failing API test. It turns out that a pop-state event
2082         is sent before every fragment navigation, so we have to test
2083         for it in addition in PageLoadDidChangeLocationWithinPageForFrame.
2084
2085         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2086         (TestWebKitAPI::didSameDocumentNavigationForFrame):
2087
2088 2010-12-12  Alejandro G. Castro  <alex@igalia.com>
2089
2090         Reviewed by Eric Seidel.
2091
2092         [GTK] Add new-run-webkit-tests support to gtk
2093         https://bugs.webkit.org/show_bug.cgi?id=50681
2094
2095         Adding the basic support to run the new-run-webkit-tests.
2096
2097         * Scripts/webkitpy/layout_tests/port/gtk.py:
2098
2099 2010-10-11  Diego Gonzalez  <diegohcg@webkit.org>
2100
2101         Reviewed by Kenneth Rohde Christiansen.
2102
2103         [Qt] Mock DeviceOrientation client for DRT
2104         https://bugs.webkit.org/show_bug.cgi?id=47490
2105
2106         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2107         (WebCore::DumpRenderTree::DumpRenderTree):
2108         (WebCore::DumpRenderTree::~DumpRenderTree):
2109         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2110         (LayoutTestController::setMockDeviceOrientation):
2111
2112 2010-12-11  Philippe Normand  <pnormand@igalia.com>
2113
2114         Reviewed by Gustavo Noronha Silva.
2115
2116         [GTK] launcher: disable the Mozilla-style fullscreen API
2117         https://bugs.webkit.org/show_bug.cgi?id=50874
2118
2119         Disabling the fullscreen API until its implementation for GTK is
2120         mature enough. The webview setting for it is already FALSE by
2121         default.
2122
2123         * GtkLauncher/main.c:
2124         (createWindow):
2125
2126 2010-12-10  Eric Seidel  <eric@webkit.org>
2127
2128         Reviewed by Adam Barth.
2129
2130         commit-queue flaky test messages show cryptic version information for mac os x
2131         https://bugs.webkit.org/show_bug.cgi?id=50864
2132
2133         Turns out platform.platform() returns kernel version information
2134         which isn't helpful, and just plain confusing on Mac
2135         (OS X 10.6.5 uses Darwin Kernel 10.5.0).
2136
2137         So I've updated PlatformInfo.display_name() to special case
2138         mac.  I also found a bad use of sys.platform in the process
2139         and fixed that.  (sys.platform always returns 'darwin' on mac).
2140
2141         * Scripts/webkitpy/common/system/platforminfo.py:
2142         * Scripts/webkitpy/common/system/user.py:
2143         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2144         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2145         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2146
2147 2010-12-10  Eric Seidel  <eric@webkit.org>
2148
2149         Unreviewed.
2150
2151         Exception seen while reporting flaky test with commit-queue.
2152         Just a missing include.
2153
2154         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2155         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2156
2157 2010-12-10  Kinuko Yasuda  <kinuko@chromium.org>
2158
2159         Reviewed by Eric Seidel.
2160
2161         [Chromium] Remove old JSONResultsGenerator script that existed for backward-compatibility
2162         https://bugs.webkit.org/show_bug.cgi?id=50796
2163
2164         Also updating the test code to use JSONResultsGeneratorBase and
2165         to improve test coverage for incremental cases.
2166
2167         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2168         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2169
2170 2010-12-10  Joseph Pecoraro  <joepeck@webkit.org>
2171
2172         Reviewed by Darin Adler.
2173
2174         prepare-ChangeLog --help doesn't mention --bug shorthand -b
2175         https://bugs.webkit.org/show_bug.cgi?id=50835
2176
2177         * Scripts/prepare-ChangeLog: be more explicit about -b and match file style.
2178
2179 2010-12-10  Eric Seidel  <eric@webkit.org>
2180
2181         Reviewed by Adam Barth.
2182
2183         Bugs created by the commit-queue should all block on a master bug
2184         https://bugs.webkit.org/show_bug.cgi?id=50857
2185
2186         This makes all bugs created by the commit-queue block on:
2187         https://bugs.webkit.org/show_bug.cgi?id=50856
2188
2189         In the process of testing this, I found that the existing
2190         create_bug code was wrong.  I also found that existing
2191         unit tests for create-rollout used invalid values
2192         for options.blocks.  I fixed both issues and tested.
2193
2194         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2195         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2196         * Scripts/webkitpy/tool/commands/commandtest.py:
2197         * Scripts/webkitpy/tool/commands/download_unittest.py:
2198         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2199         * Scripts/webkitpy/tool/mocktool.py:
2200         * Scripts/webkitpy/tool/steps/options.py:
2201
2202 2010-12-10  Eric Seidel  <eric@webkit.org>
2203
2204         Reviewed by Adam Barth.
2205
2206         Teach webkitpy how to follow duplicate chains when posting comments on flake bugs
2207         https://bugs.webkit.org/show_bug.cgi?id=50853
2208
2209         I also discovered when doing this that the code was posting
2210         the comment on the wrong bug, but that's fixed here too.
2211
2212         * Scripts/webkitpy/common/net/bugzilla/bug.py:
2213         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2214         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2215         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2216         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2217         * Scripts/webkitpy/tool/mocktool.py:
2218
2219 2010-12-10  Anders Carlsson  <andersca@apple.com>
2220
2221         Reviewed by John Sullivan.
2222
2223         Make WKContextGetStatistics gather global statistics
2224         https://bugs.webkit.org/show_bug.cgi?id=50850
2225
2226         Remove the code that gets the statistics and fills in the per context
2227         statistics information for now.
2228
2229         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
2230         (-[BrowserStatisticsWindowController refreshStatistics:]):
2231
2232 2010-12-10  Eric Seidel  <eric@webkit.org>
2233
2234         Unreviewed.
2235
2236         commit-queue should report port/platform information when commenting on flaky test bugs
2237         https://bugs.webkit.org/show_bug.cgi?id=50839
2238
2239         Renamed platform.py to platforminfo.py.  This broke import platform in executive.py
2240         which was only used by new run webkit tests (and clearly not unit tested).
2241
2242         * Scripts/webkitpy/common/system/platforminfo.py: Renamed from WebKitTools/Scripts/webkitpy/common/system/platform.py.
2243         * Scripts/webkitpy/tool/main.py:
2244         * Scripts/webkitpy/tool/mocktool.py:
2245
2246 2010-12-10  Eric Seidel  <eric@webkit.org>
2247
2248         Reviewed by Tony Chang.
2249
2250         commit-queue should report port/platform information when commenting on flaky test bugs
2251         https://bugs.webkit.org/show_bug.cgi?id=50839
2252
2253         This was a suggestion from Tony Chang this morning.
2254         I added a platform.py class so I could easily mock the platform call,
2255         but that may not be the final solution for this mocking.
2256         We'll try it and see.
2257
2258         * Scripts/webkitpy/common/system/platform.py: Added.
2259         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2260         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2261         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2262         * Scripts/webkitpy/tool/main.py:
2263         * Scripts/webkitpy/tool/mocktool.py:
2264
2265 2010-12-10  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>
2266
2267         Reviewed by Joseph Pecoraro.
2268
2269         Bug 43455 - [Qt]: Implement Application Cache Quotas
2270         https://bugs.webkit.org/show_bug.cgi?id=43455
2271
2272         Introduce functions to allow new appcache layout test origin-quota.html
2273         to work correctly under Qt.
2274
2275         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2276         (WebCore::DumpRenderTree::DumpRenderTree):
2277         (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
2278         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2279
2280         Introduce functions to allow new appcache layout test origin-quota.html
2281         to be successful under qt. Changes required because LayoutTestControllerQt
2282         does not inherit from LayoutController.
2283
2284         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2285         (LayoutTestController::reset):
2286         (LayoutTestController::clearAllApplicationCaches):
2287         (LayoutTestController::setApplicationCacheOriginQuota):
2288         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2289         (LayoutTestController::shouldDumpApplicationCacheDelegateCallbacks):
2290         (LayoutTestController::dumpApplicationCacheDelegateCallbacks):
2291
2292 2010-12-10  Eric Seidel  <eric@webkit.org>
2293
2294         Reviewed by Adam Barth.
2295
2296         Move buildbot.py into its own module so we can split it out into one-file-per-class
2297         https://bugs.webkit.org/show_bug.cgi?id=50806
2298
2299         We're adding more buildbot logic these days, so it makes sense
2300         to give buildbot its own module.
2301
2302         * Scripts/webkitpy/common/net/buildbot/__init__.py: Added.
2303         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot.py.
2304         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot_unittest.py.
2305         * Scripts/webkitpy/common/net/failuremap.py:
2306         * Scripts/webkitpy/common/net/regressionwindow.py:
2307         * Scripts/webkitpy/tool/commands/rebaseline.py:
2308
2309 2010-12-10  Tony Chang  <tony@chromium.org>
2310
2311         Reviewed by Eric Seidel.
2312
2313         Use FileSystem::remove when cleaning up http lock files
2314         https://bugs.webkit.org/show_bug.cgi?id=50830
2315
2316         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2317
2318 2010-12-10  Joone Hur  <joone@kldp.org>
2319
2320         Reviewed by Martin Robinson.
2321
2322         [GTK] DRT needs layoutTestController.setCacheModel
2323         https://bugs.webkit.org/show_bug.cgi?id=50705
2324         
2325         webkit_set_cache_mode() is called to set the cache model.
2326         
2327         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2328         (LayoutTestController::setCacheModel): Set the cache model. 
2329
2330 2010-12-10  Tony Chang  <tony@chromium.org>
2331
2332         Reviewed by Ojan Vafai.
2333
2334         [chromium] remove --use-drt and add --use-test-shell
2335         https://bugs.webkit.org/show_bug.cgi?id=50701
2336
2337         * Scripts/webkitpy/common/config/ports.py:
2338         * Scripts/webkitpy/common/config/ports_unittest.py:
2339         * Scripts/webkitpy/layout_tests/port/chromium.py:
2340         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2341         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2342         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2343         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2344         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2345         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2346         * Scripts/webkitpy/layout_tests/port/webkit.py:
2347         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2348         * Scripts/webkitpy/style/checkers/test_expectations.py:
2349         * Scripts/webkitpy/tool/commands/queries.py:
2350
2351 2010-12-10  John Knottenbelt  <jknotten@chromium.org>
2352
2353         Reviewed by Steve Block.
2354
2355         [Chromium] Implement mocks for client-based geolocation
2356         https://bugs.webkit.org/show_bug.cgi?id=46895
2357
2358         * DumpRenderTree/chromium/LayoutTestController.cpp:
2359         (LayoutTestController::setGeolocationPermission):
2360         (LayoutTestController::setMockGeolocationPosition):
2361         (LayoutTestController::setMockGeolocationError):
2362         * DumpRenderTree/chromium/LayoutTestController.h:
2363         * DumpRenderTree/chromium/WebViewHost.cpp:
2364         (WebViewHost::geolocationClient):
2365         (WebViewHost::geolocationClientMock):
2366         (WebViewHost::reset):
2367         * DumpRenderTree/chromium/WebViewHost.h:
2368
2369 2010-12-10  Alejandro G. Castro  <alex@igalia.com>
2370
2371         Reviewed by Martin Robinson.
2372
2373         [GTK] Add hasSpellingMarker support to the DRT
2374         https://bugs.webkit.org/show_bug.cgi?id=50739
2375
2376         Implemented the hasSpellingMarker to support spelling tests.
2377
2378         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2379         (LayoutTestController::hasSpellingMarker):
2380
2381 2010-12-10  Eric Seidel  <eric@webkit.org>
2382
2383         Reviewed by Ojan Vafai.
2384
2385         webkit-patch: not possible to use build-and-test with local commits
2386         https://bugs.webkit.org/show_bug.cgi?id=33378
2387
2388         Make --no-clean not even check if we have local commits.
2389         It's unclear to me why the code was originally written this way.
2390         I was unable to dig up a reason from svn history.
2391
2392         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
2393         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
2394
2395 2010-12-10  Mario Sanchez Prada  <msanchez@igalia.com>
2396
2397         Reviewed by Martin Robinson.
2398
2399         [GTK] AX: implement isEnabled in DRT
2400         https://bugs.webkit.org/show_bug.cgi?id=50814
2401
2402         Implement AccessibilityUIElement::isEnabled() for GTK.
2403
2404         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2405         (checkElementState): New function to refactor common code.
2406         (AccessibilityUIElement::isEnabled): Implement this by checking
2407         the current state of the AtkObject.
2408         (AccessibilityUIElement::isSelected): Use the new
2409         checkElementState function.
2410
2411 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2412
2413         Reviewed by Kenneth Rohde Christiansen.
2414
2415         [Qt][WK2] Add the QWKContext API class to wrap the WebContext.
2416         https://bugs.webkit.org/show_bug.cgi?id=50750
2417
2418         * MiniBrowser/qt/BrowserView.cpp:
2419         (BrowserView::BrowserView):
2420         * MiniBrowser/qt/BrowserView.h:
2421         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2422         (WTR::WebView::WebView):
2423
2424 2010-12-10  Joone Hur  <joone@kldp.org>
2425
2426         Reviewed by Xan Lopez.
2427
2428         [GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet
2429         https://bugs.webkit.org/show_bug.cgi?id=50808
2430
2431         Unskipping the following test cases:
2432         userscripts/mixed-case-stylesheet.html
2433         userscripts/simple-stylesheet.html
2434         userscripts/user-style-all-frames.html
2435
2436         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2437         (LayoutTestController::addUserStyleSheet):
2438
2439 2010-12-10  Joone Hur  <joone@kldp.org>
2440
2441         Reviewed by Eric Seidel.
2442
2443         [GTK] Add DRT support for pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet
2444         https://bugs.webkit.org/show_bug.cgi?id=50783
2445
2446         This patch allows to unskip the following test cases:
2447         printing/page-rule-selection.html
2448         printing/page-format-data.html
2449
2450         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2451         (LayoutTestController::pageProperty): Added.
2452         (LayoutTestController::isPageBoxVisible): Ditto.
2453         (LayoutTestController::pageSizeAndMarginsInPixels): Ditto.
2454         (LayoutTestController::addUserStyleSheet): Ditto.
2455
2456 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2457
2458         Reviewed by Kenneth Rohde Christiansen.
2459
2460         [Qt] Make QtTestBrowser spawn QNAM in a secondary thread.
2461
2462         A menu allows to switch QNAM back to the same thread.
2463
2464         * QtTestBrowser/launcherwindow.cpp:
2465         (LauncherWindow::initializeView):
2466         (LauncherWindow::createChrome):
2467         (LauncherWindow::toggleThreadedQnam):
2468         * QtTestBrowser/launcherwindow.h:
2469         (WindowOptions::WindowOptions):
2470         * QtTestBrowser/webpage.cpp:
2471         (WebPage::WebPage):
2472         (WebPage::setQnamThreaded):
2473         * QtTestBrowser/webpage.h:
2474         (QnamThread::QnamThread):
2475         (QnamThread::~QnamThread):
2476         (QnamThread::networkAccessManager):
2477         (QnamThread::run):
2478
2479 2010-12-10  Martin Robinson  <mrobinson@igalia.com>
2480
2481         Reviewed by Xan Lopez.
2482
2483         [Gtk] style="font-family: courier" makes text disappear
2484         https://bugs.webkit.org/show_bug.cgi?id=47452
2485
2486         Add a test that verifies that fonts without valid charmaps are
2487         never selected.
2488
2489         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2490         (initializeFonts): Initialize DRT with our font (derived from Ahem)
2491         that has no valid charmap.
2492         * DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon: Added.
2493         * DumpRenderTree/gtk/fonts/fonts.conf: Updated settings to override users'
2494         settings which may disable selection of bitmap fonts.
2495
2496 2010-12-10  Eric Seidel  <eric@webkit.org>
2497
2498         Unreviewed.
2499
2500         The commit-queue should file bugs about flaky tests it encounters
2501         https://bugs.webkit.org/show_bug.cgi?id=50803
2502
2503         create_bug_for_flaky_test was insufficiently tested, thus buggy.
2504         Now it's tested.
2505
2506         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2507         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2508
2509 2010-12-10  Eric Seidel  <eric@webkit.org>
2510
2511         Unreviewed.  Somehow this last-minute edit didn't quite get committed.
2512
2513         The commit-queue should file bugs about flaky tests it encounters
2514         https://bugs.webkit.org/show_bug.cgi?id=50803
2515
2516         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2517
2518 2010-12-09  Eric Seidel  <eric@webkit.org>
2519
2520         Reviewed by Adam Barth.
2521
2522         The commit-queue should file bugs about flaky tests it encounters
2523         https://bugs.webkit.org/show_bug.cgi?id=50803
2524
2525         This change got a bit big.  I also added a new config.urls file
2526         because I needed to share the view_source_url code with committervalidator.py.
2527
2528         This adds a new class FlakyTestReporter which holds all the logic about
2529         reporting flaky tests to bugzilla.
2530
2531         Right now this code knows how to look up bugs for flaky tests.
2532         If it can't find a bug filed from the commit-queue, it will open a new
2533         one, ccing the relevant people and adding information about the failure.
2534
2535         It is not yet smart enough to chase down duplicate chains, or to include
2536         the actual failure diff.  But those can be added in later iterations.
2537
2538         * Scripts/webkitpy/common/checkout/api.py:
2539         * Scripts/webkitpy/common/checkout/changelog.py:
2540         * Scripts/webkitpy/common/checkout/commitinfo.py:
2541         * Scripts/webkitpy/common/config/committervalidator.py:
2542         * Scripts/webkitpy/common/config/urls.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
2543         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2544         * Scripts/webkitpy/tool/bot/flakytestreporter.py: Added.
2545         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
2546         * Scripts/webkitpy/tool/bot/irc_command.py:
2547         * Scripts/webkitpy/tool/bot/sheriff.py:
2548         * Scripts/webkitpy/tool/commands/download.py:
2549         * Scripts/webkitpy/tool/commands/queues.py:
2550         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2551         * Scripts/webkitpy/tool/comments.py:
2552         * Scripts/webkitpy/tool/mocktool.py:
2553         * Scripts/webkitpy/tool/steps/commit.py:
2554
2555 2010-12-09  Eric Seidel  <eric@webkit.org>
2556
2557         Reviewed by Adam Barth.
2558
2559         Teach webkit-patch how to search bugzilla
2560         https://bugs.webkit.org/show_bug.cgi?id=50500
2561
2562         This is a step towards teaching webkitpy how to file
2563         new bugs for flaky tests and update them when new flakes occur.
2564
2565         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2566         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2567         * Scripts/webkitpy/tool/commands/__init__.py:
2568         * Scripts/webkitpy/tool/commands/bugsearch.py: Added.
2569
2570 2010-12-09  Adam Barth  <abarth@webkit.org>
2571
2572         Reviewed by Ojan Vafai.
2573
2574         commit-queue errors out due to local commits
2575         https://bugs.webkit.org/show_bug.cgi?id=50766
2576
2577         We seem to be tripping over having local commits in the working copy a
2578         lot recently.  I don't quite fully understand what the issue is, but
2579         this patch attempts to solve the problem by adding an explicit clean
2580         step before processing a patch.  Previously, we did the cleaning as
2581         part of the apply-attachment step, so this might not actually fix the
2582         problem.
2583
2584         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2585         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2586         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2587
2588 2010-12-09  Dirk Pranke  <dpranke@chromium.org>
2589
2590         Reviewed by Ojan Vafai.
2591
2592         Make new-run-webkit-tests --lint-test-files log slightly better
2593         messages and return -1 if lint fails. Remove the
2594         'suppress_errors' keyword param to the TestExpectationsFile
2595         class, and clean up logging and exception raising for error
2596         handling. Also add more unit tests and clean up the unit test code a bit.
2597
2598         https://bugs.webkit.org/show_bug.cgi?id=50205
2599
2600         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2601         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2602         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py
2603         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py
2604         * Scripts/webkitpy/layout_tests/port/chromium.py:
2605         * Scripts/webkitpy/style/checkers/test_expectations.py:
2606         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2607
2608 2010-12-09  Tony Chang  <tony@chromium.org>
2609
2610         Unreviewed, fix for windows code.  We were catching the wrong
2611         exception in Windows.
2612
2613         * Scripts/webkitpy/common/system/filesystem.py:
2614
2615 2010-12-09  Antonio Gomes  <agomes@rim.com>
2616
2617         Reviewed by Martin Robinson.
2618
2619         [Gtk] Populate DumpRenderTreeSupportGtk (part IV)
2620         https://bugs.webkit.org/show_bug.cgi?id=48429
2621
2622         Adjust call sites of webkit_thread_count to use the DumpRenderTreeSupportGtk version now.
2623
2624         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2625         (LayoutTestController::workerThreadCount):
2626
2627 2010-12-06  Philippe Normand  <pnormand@igalia.com>
2628
2629         Reviewed by Martin Robinson.
2630
2631         [GTK] Support the Mozilla-style Fullscreen Javascript API
2632         https://bugs.webkit.org/show_bug.cgi?id=50572
2633
2634         Enable the Javascript Fullscreen support in the GtkLauncher. Also
2635         make DRT update the Chrome when the WebView settings have been
2636         reset to consistent values.
2637
2638         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2639         (resetDefaultsToConsistentValues):
2640         * GtkLauncher/main.c:
2641         (create_window):
2642         * Scripts/build-webkit:
2643
2644 2010-12-09  Koan-Sin Tan  <koansin.tan@gmail.com>
2645
2646         Reviewed by Tor Arne Vestbø
2647
2648         [Qt] run-launcher doesn't start the browser on Mac OS X 10.6
2649         https://bugs.webkit.org/show_bug.cgi?id=50742
2650
2651         check not only QtWebKit.framework/QtWebKit but also libQtWebKit.dylib
2652
2653         * Scripts/webkitdirs.pm:
2654
2655 2010-12-09  Joone Hur  <joone@kldp.org>
2656
2657          Reviewed by Martin Robinson.
2658
2659          [GTK] Support for viewport meta tag
2660          https://bugs.webkit.org/show_bug.cgi?id=45443
2661
2662          Add support for testing the viewport properties for WebKitGtk.
2663
2664          * DumpRenderTree/LayoutTestController.cpp:
2665          (dumpConfigurationForViewportCallback): Added this JS callback to set the size of the visible viewport.
2666          (LayoutTestController::staticFunctions):
2667          * DumpRenderTree/LayoutTestController.h:
2668          * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2669          (LayoutTestController::dumpConfigurationForViewport): Added this function to test the viewport properties.
2670          * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2671          (LayoutTestController::dumpConfigurationForViewport): Ditto.
2672          * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2673          (LayoutTestController::dumpConfigurationForViewport): Ditto.
2674          * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2675          (LayoutTestController::dumpConfigurationForViewport): Ditto.
2676          * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2677          (LayoutTestController::dumpConfigurationForViewport): Ditto.
2678
2679 2010-12-08  William Siegrist <wsiegrist@apple.com>
2680
2681         Reviewed by Eric Seidel.
2682
2683         Migrate buildbot.py from xmlrpc to json.
2684         https://bugs.webkit.org/show_bug.cgi?id=50647
2685
2686         * Scripts/webkitpy/common/net/buildbot.py:
2687
2688 2010-12-08  Tony Chang  <tony@chromium.org>
2689
2690         Reviewed by Eric Seidel.
2691
2692         make starting the websocket server more reliable on windows
2693         https://bugs.webkit.org/show_bug.cgi?id=50712
2694
2695         * Scripts/webkitpy/common/system/filesystem.py:
2696         (remove): Substitute method for os.remove to retry on error on Windows
2697         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2698         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Use FileSystem.remove
2699
2700 2010-12-08  Jessie Berlin  <jberlin@apple.com>
2701
2702         Reviewed by Adam Roben.
2703
2704         WebKit2: Implement WebChromeClient::exceededDatabaseQuota
2705         https://bugs.webkit.org/show_bug.cgi?id=50656
2706
2707         * MiniBrowser/mac/BrowserWindowController.m:
2708         (-[BrowserWindowController awakeFromNib]):
2709         Indicate that exceededDatabaseQuota is not implemented.
2710         * MiniBrowser/win/BrowserView.cpp:
2711         (BrowserView::create):
2712         Ditto.
2713         * WebKitTestRunner/TestController.cpp:
2714         (WTR::createOtherPage):
2715         Ditto.
2716         (WTR::TestController::initialize):
2717         Ditto.
2718
2719 2010-12-08  Antonio Gomes  <agomes@rim.com>
2720
2721         Reviewed by Martin Robinson.
2722
2723         [Gtk] Populate DumpRenderTreeSupportGtk (part III)
2724         https://bugs.webkit.org/show_bug.cgi?id=48429
2725
2726         Moved the following methods from webkitprivate.h to DumpRenderTreeSupportGtk.cpp|h:
2727         * webkit_gc_collect_javascript_objects;
2728         * webkit_gc_collect_javascript_objects_on_alternate_thread;
2729         * webkit_gc_count_javascript_objects;
2730         * webkit_web_frame_layout.
2731
2732         These were all only used by GTK+ DRT.
2733
2734         * DumpRenderTree/gtk/EventSender.cpp:
2735         (dispatchEvent):
2736         * DumpRenderTree/gtk/GCControllerGtk.cpp:
2737         (GCController::collect):
2738         (GCController::collectOnAlternateThread):
2739         (GCController::getJSObjectCount):
2740
2741 2010-12-07  Tony Chang  <tony@chromium.org>
2742
2743         Reviewed by Ojan Vafai.
2744
2745         [chromium] force NRWT to use DRT
2746         https://bugs.webkit.org/show_bug.cgi?id=50359
2747
2748         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2749
2750 2010-12-06  Sam Weinig  <sam@webkit.org>
2751
2752         Reviewed by Anders Carlsson.
2753
2754         Generalize didChangeLocationWithinPageForFrame for all same document navigations
2755         https://bugs.webkit.org/show_bug.cgi?id=50584
2756
2757         * MiniBrowser/mac/BrowserWindowController.m:
2758         (didSameDocumentNavigationForFrame):
2759         (-[BrowserWindowController awakeFromNib]):
2760         (-[BrowserWindowController didSameDocumentNavigationForFrame:]):
2761         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2762         (TestWebKitAPI::didSameDocumentNavigationForFrame):
2763         (TestWebKitAPI::TEST):
2764         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2765         (WTR::InjectedBundlePage::InjectedBundlePage):
2766         (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame):
2767         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2768         * WebKitTestRunner/TestController.cpp:
2769         (WTR::TestController::initialize):
2770
2771 2010-12-06  Kinuko Yasuda  <kinuko@chromium.org>
2772
2773         Reviewed by Ojan Vafai.
2774
2775         Make TestResultsServer return 404 for non-existing results files.
2776         https://bugs.webkit.org/show_bug.cgi?id=50581
2777
2778         * TestResultServer/handlers/testfilehandler.py:
2779
2780 2010-12-06  Tony Chang  <tony@chromium.org>
2781
2782         Reviewed by Ojan Vafai.
2783
2784         [chromium] fix an assert hit in DRT
2785         https://bugs.webkit.org/show_bug.cgi?id=50575
2786
2787         This class uses WTF's RefPtr, but expects chrome's base::RefPtr
2788         semantics.
2789
2790         Otherwise, we hit ASSERTION FAILED: !m_adoptionIsRequired
2791         (third_party/WebKit/JavaScriptCore/wtf/RefCounted.h:37 void
2792         WTF::RefCountedBase::ref()).
2793
2794         * DumpRenderTree/chromium/TestWebWorker.h:
2795         (TestWebWorker::TestWebWorker):
2796
2797 2010-12-02  Ojan Vafai  <ojan@chromium.org>
2798
2799         Reviewed by Eric Seidel.
2800
2801         make webkit-patch command work when the git branch is not synced to the remote svn branch
2802         https://bugs.webkit.org/show_bug.cgi?id=50424
2803
2804         * Scripts/webkitpy/common/checkout/scm.py:
2805         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2806
2807 2010-12-06  Patrick Gansterer  <paroga@webkit.org>
2808
2809         Reviewed by Andreas Kling.
2810
2811         [WINCE] Add build system
2812         https://bugs.webkit.org/show_bug.cgi?id=50522
2813
2814         * CMakeListsWinCE.txt: Added.
2815
2816 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
2817
2818         Reviewed by Tony Chang.
2819
2820         Allow the Chromium port to have Leopard-specific baselines
2821         https://bugs.webkit.org/show_bug.cgi?id=50506
2822
2823         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2824
2825 2010-12-03  Tony Chang  <tony@chromium.org>
2826
2827         Reviewed by Kent Tamura.
2828
2829         [chromium] fix 2 bugs with inspector tests in DRT
2830         https://bugs.webkit.org/show_bug.cgi?id=50492
2831
2832         Tasks can outlive the tasklist (even when canceled) so this was
2833         causing a crash when ~WebTask() ran.  Avoid this by unregistering
2834         when a task is canceled.
2835
2836         Also fix an assert when closing devtool windows by copying some
2837         logic from test_shell.
2838
2839         * DumpRenderTree/chromium/Task.cpp:
2840         (WebTask::~WebTask):
2841         (TaskList::revokeAll):
2842         * DumpRenderTree/chromium/Task.h: Canceling a task now removes it from
2843             the tasklist (since the task can outlive the tasklist).
2844         * DumpRenderTree/chromium/TestShell.h:
2845         (TestShell::devToolsWebView):
2846         * DumpRenderTree/chromium/WebViewHost.cpp:
2847         (WebViewHost::~WebViewHost): Don't load about:blank when closing
2848             a window if the window has devtools loaded.  This avoids an
2849             ASSERT and matches test_shell.
2850
2851 2010-12-06  Alejandro G. Castro  <alex@igalia.com>
2852
2853         Reviewed by Martin Robinson.
2854
2855         [GTK] Fix GtkLauncher.c style, use webkit style
2856         https://bugs.webkit.org/show_bug.cgi?id=50542
2857
2858         * GtkLauncher/main.c:
2859         (activateUriEntryCb):
2860         (updateTitle):
2861         (linkHoverCb):
2862         (notifyTitleCb):
2863         (notifyLoadStatusCb):
2864         (notifyProgressCb):
2865         (destroyCb):
2866         (goBackCb):
2867         (goForwardCb):
2868         (create_webViewCb):
2869         (webViewReadyCb):
2870         (closeWebViewCb):
2871         (createBrowser):
2872         (createStatusbar):
2873         (createToolbar):
2874         (createWindow):
2875         (main):
2876
2877 2010-12-04  Antonio Gomes  <agomes@rim.com>
2878
2879         Reviewed by Martin Robinson.
2880
2881         [Gtk] Populate DumpRenderTreeSupportGtk (Part II)
2882         https://bugs.webkit.org/show_bug.cgi?id=48429
2883
2884         Moved more private method declared with WEBKIT_API to
2885         DumpRenderTreeSupportGtk, since they were only being used by DRT.
2886
2887         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2888         (resetDefaultsToConsistentValues):
2889         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2890         (LayoutTestController::addOriginAccessWhitelistEntry):
2891         (LayoutTestController::execCommand):
2892         (LayoutTestController::isCommandEnabled):
2893
2894 2010-12-04  Antonio Gomes  <agomes@rim.com>
2895
2896         Reviewed by Andreas Kling.
2897
2898         Removed extern webkit_web_view_set_group_name from gtk/DumpRenderTree.cpp
2899
2900         Method was removed by http://trac.webkit.org/changeset/71604
2901
2902         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2903
2904 2010-12-05  Alejandro G. Castro  <alex@igalia.com>
2905
2906         Reviewed by Xan Lopez.
2907
2908         [GTK] Fix compilation warnings reported by clang
2909         https://bugs.webkit.org/show_bug.cgi?id=50252
2910
2911         * GtkLauncher/main.c:
2912         (create_window): The create_statusbar function does not have
2913         parameters.
2914
2915 2010-12-05  Robert Hogan  <robert@webkit.org>
2916
2917         Reviewed by Andreas Kling.
2918
2919         [Qt] Zero-sized font does not yet work
2920
2921         Fix fast/text/font-size-zero.html
2922
2923         Copy other ports by setting minimumFontSize to 0 for DRT runs.
2924
2925         https://bugs.webkit.org/show_bug.cgi?id=49759
2926
2927         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2928         (WebCore::WebPage::WebPage):
2929
2930 2010-12-04  Sam Weinig  <sam@webkit.org>
2931
2932         Reviewed by Jon Honeycutt.
2933
2934         WebKit2: Need client functions to notify app when the url changes due to a fragment navigation
2935         https://bugs.webkit.org/show_bug.cgi?id=50511
2936
2937         Update tools for new didChangeLocationWithinPageForFrame client function (and changed bundle
2938         signature) and added a test for the functionality (PageLoadDidChangeLocationWithinPageForFrame.cpp)
2939
2940         * MiniBrowser/mac/BrowserWindowController.m:
2941         (didChangeLocationWithinPageForFrame):
2942         (-[BrowserWindowController awakeFromNib]):
2943         (-[BrowserWindowController didChangeLocationWithinPageForFrame:]):
2944         * TestWebKitAPI/PlatformUtilities.cpp:
2945         (TestWebKitAPI::Util::toWK):
2946         * TestWebKitAPI/PlatformUtilities.h:
2947         (TestWebKitAPI::Util::adoptWK):
2948         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2949         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp: Added.
2950         (TestWebKitAPI::nullJavaScriptCallback):
2951         (TestWebKitAPI::didFinishLoadForFrame):
2952         (TestWebKitAPI::didChangeLocationWithinPageForFrame):
2953         (TestWebKitAPI::TEST):
2954         * TestWebKitAPI/Tests/WebKit2/file-with-anchor.html: Added.
2955         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2956         * TestWebKitAPI/win/copy-resources.cmd:
2957         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2958         (WTR::InjectedBundlePage::InjectedBundlePage):
2959         (WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
2960         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2961         * WebKitTestRunner/TestController.cpp:
2962         (WTR::TestController::initialize):
2963
2964 2010-11-08  Antonio Gomes  <agomes@rim.com>
2965
2966         Reviewed by Martin Robinson.
2967
2968         [Gtk] Populate DumpRenderTreeSupportGtk
2969         https://bugs.webkit.org/show_bug.cgi?id=48429
2970
2971         Made the previous calls to webkit_web_frame* functions defined as private
2972         APIs in webkitprivate.h go through DRTSupportGtk.
2973
2974         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2975         (AccessibilityController::focusedElement):
2976         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2977         (dumpFramesAsText):
2978         (resetDefaultsToConsistentValues):
2979         (dump):
2980         (webViewDocumentLoadFinished):
2981         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2982         (LayoutTestController::counterValueForElementById):
2983         (LayoutTestController::pageNumberForElementById):
2984         (LayoutTestController::numberOfPages):
2985         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
2986         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2987         (LayoutTestController::sampleSVGAnimationForElementAtTime):
2988         (LayoutTestController::numberOfActiveAnimations):
2989         (LayoutTestController::suspendAnimations):
2990         (LayoutTestController::resumeAnimations):
2991         (LayoutTestController::markerTextForListItem):
2992
2993 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
2994
2995         Reviewed by Tony Chang.
2996
2997         Rebaseline server: use pretty text diff output
2998         https://bugs.webkit.org/show_bug.cgi?id=50484
2999         
3000         Serve *-pretty-diff.html for text diff output.
3001
3002         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
3003         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
3004         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
3005         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3006
3007 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
3008
3009         Unreviewed, rolling out r73302.
3010         http://trac.webkit.org/changeset/73302
3011         https://bugs.webkit.org/show_bug.cgi?id=50499
3012
3013         Causes crashes in debug LayoutTests (Requested by xan_ on
3014         #webkit).
3015
3016         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3017         (AccessibilityUIElement::AccessibilityUIElement):
3018         (AccessibilityUIElement::parentElementCallback):
3019         * DumpRenderTree/chromium/AccessibilityUIElement.h:
3020         * DumpRenderTree/chromium/CppBoundClass.cpp:
3021         * DumpRenderTree/chromium/CppBoundClass.h:
3022
3023 2010-12-03  Sam Weinig  <sam@webkit.org>
3024
3025         Reviewed by Maciej Stachowiak.
3026
3027         Enable <a ping> for Mac/Windows/WebKit2 builds
3028         <rdar://problem/8504473>
3029         https://bugs.webkit.org/show_bug.cgi?id=50488
3030
3031         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3032         (TestWebKitAPI::TEST): Test that the default value of
3033         WKPreferencesGetHyperlinkAuditingEnabled is true.
3034
3035 2010-12-03  Chris Guillory  <chris.guillory@google.com>
3036
3037         Reviewed by Chris Fleizach.
3038
3039         Include the FrameView widget of a RenderWidget in the accessibility tree.
3040         https://bugs.webkit.org/show_bug.cgi?id=49106
3041
3042         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3043         (AccessibilityUIElement::AccessibilityUIElement):
3044         (AccessibilityUIElement::parentElementCallback):
3045         (AccessibilityUIElement::isEqualCallback):
3046         * DumpRenderTree/chromium/AccessibilityUIElement.h:
3047         * DumpRenderTree/chromium/CppBoundClass.cpp:
3048         (CppBoundClass::getFromCppVariant):
3049         * DumpRenderTree/chromium/CppBoundClass.h:
3050
3051 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
3052
3053         Reviewed by Tony Chang.
3054
3055         Rebaseline server: organize tests by state, add dry run mode
3056         https://bugs.webkit.org/show_bug.cgi?id=50473
3057         
3058         Group tests in the menu by state, so that it's easier to see after
3059         processing the queue which failed.
3060         
3061         Add support for the --dry-run flag so that it's easier to test changes
3062         such as this (stubs out filesystem and SCM operations).
3063
3064         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
3065         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
3066         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3067
3068 2010-12-03  Brady Eidson  <beidson@apple.com>
3069
3070         Reviewed by Anders Carlsson.
3071
3072         Groundwork for <rdar://problem/7660733> and https://bugs.webkit.org/show_bug.cgi?id=50191
3073         WebKit2 Authentication Support
3074
3075         Keep these builds working:
3076         * MiniBrowser/mac/BrowserWindowController.m:
3077         (-[BrowserWindowController awakeFromNib]):
3078
3079         * WebKitTestRunner/TestController.cpp:
3080         (WTR::TestController::initialize):
3081
3082 2010-12-02  Mihai Parparita  <mihaip@chromium.org>
3083
3084         Reviewed by Tony Chang.
3085
3086         Rebaseline server: move existing baselines
3087         https://bugs.webkit.org/show_bug.cgi?id=50421
3088         
3089         Implement moving of existing baselines: move all files that are about
3090         to be overwriten by update baselines.
3091         
3092         Also fix a typo in the UI JS.
3093
3094         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
3095         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3096         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
3097
3098 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
3099
3100         Unreviewed, rolling out r73211.
3101         http://trac.webkit.org/changeset/73211
3102         https://bugs.webkit.org/show_bug.cgi?id=50450
3103
3104         Broke Chromium's "Webkit Win (dbg)(2)" bot. (Requested by
3105         yutak on #webkit).
3106
3107         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3108
3109 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
3110
3111         Unreviewed, rolling out r73222.
3112         http://trac.webkit.org/changeset/73222
3113         https://bugs.webkit.org/show_bug.cgi?id=50449
3114
3115         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
3116         (Requested by yutak on #webkit).
3117
3118         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3119         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3120         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3121         * Scripts/webkitpy/layout_tests/port/base.py:
3122         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3123         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3124
3125 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
3126
3127         Unreviewed, rolling out r73228.
3128         http://trac.webkit.org/changeset/73228
3129         https://bugs.webkit.org/show_bug.cgi?id=50448
3130
3131         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
3132         (Requested by yutak on #webkit).
3133
3134         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3135         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
3136         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
3137         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
3138         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3139
3140 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
3141
3142         Unreviewed, rolling out r73231.
3143         http://trac.webkit.org/changeset/73231
3144         https://bugs.webkit.org/show_bug.cgi?id=50443
3145
3146         r73211 seemed to broke Chromium's "Webkit Win (dbg)(2)" bot.
3147         (Requested by yutak on #webkit).
3148
3149         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3150         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3151         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3152         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3153
3154 2010-12-03  David Levin  <levin@chromium.org>
3155
3156         Reviewed by Shinichiro Hamaji.
3157
3158         check-webkit-style: false positive reported for #if macro
3159         https://bugs.webkit.org/show_bug.cgi?id=48242
3160
3161         * Scripts/webkitpy/style/checkers/cpp.py: Adjusted check to avoid
3162           all preprocessor commands.
3163         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test.
3164
3165 2010-12-02  Eric Seidel  <eric@webkit.org>
3166
3167         Reviewed by Adam Barth.
3168
3169         Update the EWSTools scripts to use modern-style git repos
3170         https://bugs.webkit.org/show_bug.cgi?id=50402
3171
3172         * EWSTools/create-webkit-git:
3173         * EWSTools/start-commit-queue.sh:
3174         * EWSTools/start-queue.sh:
3175
3176 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
3177
3178         Fix Chromium Linux plugin tests by not logging
3179         unconditionally from the event handling code.
3180
3181         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3182         (handleEventX11):
3183
3184 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
3185
3186         Reviewed by Tony Chang.
3187
3188         nrwt multiprocessing - move logic back into run_webkit_tests
3189
3190         This change moves a bunch of logic that I had put into
3191         message_broker back into run_webkit_tests, in a slightly
3192         different format. WorkerMessageBroker needed to become less aware of
3193         the logic the TestRunner class uses, and more generic.
3194         Eventually the MessageBroker will only do generic messaging and
3195         thread/process-pooling, and (almost) all of the
3196         run-webkit-tests-specific logic will be moved to
3197         run_webkit_tests.py and dump_render_tree_thread.py.
3198         
3199         The biggest changes are that the Broker can now start a single
3200         worker, but the responsibility for starting all of them is pushed
3201         back to the TestRunner (Manager), and the logic for checking if
3202         the threads are done or wedged is moved back to TestRunner. We
3203         also remove WorkerMessageBroker.cleanup (not needed) and
3204         cancel_workers (they have to be cancelled individually).
3205         
3206         The  message_broker is now encapsulated inside
3207         TestRunner._run_tests(); it only needs to exist while actually
3208         running the tests.
3209
3210         Also, delete a bunch of tests in message_broker_unittest that no
3211         longer make much sense.
3212
3213         This patch depends on bug 50372.
3214
3215         https://bugs.webkit.org/show_bug.cgi?id=50374
3216
3217         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3218         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3219         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3220         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3221         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3222
3223 2010-12-02  Hayato Ito  <hayato@chromium.org>
3224
3225         Reviewed by Eric Seidel.
3226
3227         Refactor test_types's compare_output() method so that it takes a
3228         TestInput object.
3229
3230         compare_output() will need additional information included in a TestInput
3231         object to support reftests. This change is a pre-requirement of that.
3232
3233         https://bugs.webkit.org/show_bug.cgi?id=50362
3234
3235         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3236         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
3237         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
3238         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
3239         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3240
3241 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
3242
3243         Reviewed by Anders Carlsson.
3244
3245         Add the ability to run script on 'new' and 'paint' in the test plugin
3246         https://bugs.webkit.org/show_bug.cgi?id=50425
3247         
3248         Add "onnew" and "onpaintevent" attributes to the test plugin,
3249         so that tests can run JS at these times.
3250
3251         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3252         (pluginAllocate):
3253         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
3254         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3255         (NPP_New):
3256         (NPP_Destroy):
3257         (handleEventCarbon):
3258         (handleEventCocoa):
3259         (NPP_HandleEvent):
3260
3261 2010-12-02  Sam Weinig  <sam@webkit.org>
3262
3263         Fix Qt build.
3264
3265         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3266         (WTR::PlatformWebView::PlatformWebView):
3267
3268 2010-12-02  Sam Weinig  <sam@webkit.org>
3269
3270         Reviewed by Anders Carlsson.
3271
3272         WebKit2 Preferences should be held off the PageGroup, not the Context
3273         https://bugs.webkit.org/show_bug.cgi?id=50414
3274
3275         Update for API changes.
3276
3277         * WebKitTestRunner/PlatformWebView.h:
3278         * WebKitTestRunner/TestController.cpp:
3279         (WTR::createOtherPage):
3280         (WTR::TestController::initialize):
3281         (WTR::TestController::resetStateToConsistentValues):
3282         * WebKitTestRunner/TestController.h:
3283         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3284         (WTR::PlatformWebView::PlatformWebView):
3285         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3286         (WTR::PlatformWebView::PlatformWebView):
3287
3288 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
3289
3290         Reviewed by Tony Chang.
3291
3292         new-run-webkit-tests: minor cleanup for multiprocessing work
3293
3294         This change:
3295         * moves worker naming into TestShellThread, eliminating a
3296           parameter to the constructor and putting the responsibility in
3297           the correct place.
3298         * eliminates the _WorkerState() class in message_broker, because
3299           it turns out that state really needs to be in run_webkit_tests
3300         * renames the Broker classes to be module-private.
3301         * fixes a bunch of minor commenting and whitespace issues to
3302           make subsequent patches a bit clearer.
3303         * Adds a Port hook for default_worker_model() so that we can
3304           accomodate the potential for different worker models on
3305           different ports.
3306         * merge in the fix from 50420 for the brokenness introduced in
3307           bug 50367.
3308
3309         This patch depends on bug 50367.
3310
3311         https://bugs.webkit.org/show_bug.cgi?id=50372
3312
3313         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3314         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3315         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3316         * Scripts/webkitpy/layout_tests/port/base.py:
3317         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3318         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3319
3320 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
3321
3322         Reviewed by Tony Chang.
3323
3324         This change is a bunch of cleanup / refactoring of the file
3325         below. It moves a bunch of free functions to methods on the
3326         TestShellThread class, and restructures other methods to be
3327         closer to the structure we'll need for the multiprocessing
3328         rewrite.
3329
3330         It also makes the logic of --run-singly a *lot* easier to follow
3331         by nestling all of the separate-thread logic into a single
3332         routine.
3333
3334         There should be no semantic changes in this patch, just cleanup.
3335
3336         https://bugs.webkit.org/show_bug.cgi?id=50367
3337
3338         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3339
3340 2010-12-02  Tony Chang  <tony@chromium.org>
3341
3342         Unreviewed, rolling out r73164.
3343         http://trac.webkit.org/changeset/73164
3344         https://bugs.webkit.org/show_bug.cgi?id=50359
3345
3346         broke debugger tests on win
3347
3348         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3349
3350 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
3351
3352         Reviewed by Tony Chang.
3353
3354         Rebaseline server: add updating of baselines
3355         https://bugs.webkit.org/show_bug.cgi?id=50305
3356         
3357         Implements updating of baselines, where we copy -actual.* files over
3358         the current -expected.* files. To do this, we need a
3359         _get_actual_result_files method to get test results files and a
3360         _rebaseline_test method to actually do the file copy and SCM operation.
3361         _rebaseline_test logs output into a buffer, this is useful for both
3362         showing result in the UI and for unit tests.
3363         
3364         To make passing around of the various test environment properties
3365         (results directory, filesystem, SCM, etc) easier, add a TestConfig
3366         class for them.
3367         
3368         Moving of existing baselines is not implemented yet, this patch is big
3369         enough as it is.
3370
3371         * Scripts/webkitpy/common/system/filesystem.py:
3372         * Scripts/webkitpy/common/system/filesystem_mock.py:
3373         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
3374         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3375         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
3376         * Scripts/webkitpy/tool/mocktool.py:
3377
3378 2010-12-02  Brent Fulgham  <bfulgham@webkit.org>
3379
3380         Unreviewed build fix after vcproj updates.
3381
3382         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Make sure
3383         that WIN_CAIRO is defined for this build.
3384         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Update file
3385         to reflect new 'Debug_Cairo_CFLite' and 'Release_Cairo_CFLite'
3386         (these were previously 'Debug_Cairo' and 'Release_Cairo'
3387
3388 2010-12-02  Sam Weinig  <sam@webkit.org>
3389
3390         Reviewed by Anders Carlsson.
3391
3392         WebKit2 needs API to turn on popup blocking
3393         https://bugs.webkit.org/show_bug.cgi?id=50407
3394
3395         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3396         (TestWebKitAPI::TEST):
3397         * WebKitTestRunner/TestController.cpp:
3398         (WTR::TestController::resetStateToConsistentValues):
3399
3400 2010-12-01  Tony Chang  <tony@chromium.org>
3401
3402         Reviewed by Ojan Vafai.
3403
3404         [chromium] force NRWT to use DRT
3405         https://bugs.webkit.org/show_bug.cgi?id=50359
3406
3407         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3408
3409 2010-12-02  Martin Robinson  <mrobinson@igalia.com>
3410
3411         Reviewed by Xan Lopez.
3412
3413         [GTK] DumpRenderTree has two copies of JavaScriptCore
3414         https://bugs.webkit.org/show_bug.cgi?id=49877
3415
3416         * GNUmakefile.am: Remove the second copy of JavaScriptCore from the
3417         LDADD list for DumpRenderTree.
3418
3419 2010-12-02  Sergio Villar Senin  <svillar@igalia.com>
3420
3421         Unreviewed: Added myself to list of Committers.
3422
3423         * Scripts/webkitpy/common/config/committers.py:
3424
3425 2010-12-01  Mihai Parparita  <mihaip@chromium.org>
3426
3427         Reviewed by Adam Barth.
3428
3429         build-webkit --chromium always updates DEPS and re-generates project files
3430         https://bugs.webkit.org/show_bug.cgi?id=50340
3431         
3432         Make build-webkit --chromium invoke update-webkit-chromium only when
3433         --update-chromium is passed in, so that we don't add 20 seconds to all
3434         builds.
3435         
3436         Making all invocations update was added with r61883, with the goal of
3437         making EWS bots always update. The bots will switch to using this flag
3438         (as will all other webkit-patch build steps) so nothing should change
3439         for them.
3440
3441         * Scripts/webkitdirs.pm:
3442         * Scripts/webkitpy/common/config/ports.py:
3443         * Scripts/webkitpy/common/config/ports_unittest.py:
3444
3445 2010-12-01  Dirk Pranke  <dpranke@chromium.org>
3446
3447         Reviewed by Tony Chang.
3448
3449         new-run-webkit-tests: add a --dry-run / -n flag
3450         https://bugs.webkit.org/show_bug.cgi?id=50045
3451
3452         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3453         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3454
3455 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
3456
3457         Reviewed by Adam Roben.
3458
3459         WinCairo build should not use link-time code generation (LTCG)
3460         https://bugs.webkit.org/show_bug.cgi?id=50353
3461
3462         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3463         * DumpRenderTree/win/DumpRenderTree.vcproj:
3464         * DumpRenderTree/win/ImageDiff.vcproj:
3465         * FindSafari/FindSafari.vcproj:
3466         * MiniBrowser/MiniBrowser.vcproj:
3467         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3468         * WebKitAPITest/WebKitAPITest.vcproj:
3469         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3470         * WebKitTestRunner/win/InjectedBundle.vcproj:
3471         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3472         * WinLauncher/WinLauncher.vcproj:
3473         * record-memory-win/record-memory-win.vcproj:
3474
3475 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
3476
3477         Touch GetUserAgentWithNullNPPFromNPPNew.cpp in an effort to force
3478         a rebuild of TestNetscapePlugin.la on GTK+. It seems that simply
3479         adding the file to the sources list was not enough to force the rebuild.
3480
3481         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
3482         Remove an empty line at the end of this file to force a rebuild.
3483
3484 2010-12-01  Sam Weinig  <sam@webkit.org>
3485
3486         Fix windows build.
3487
3488         * MiniBrowser/win/BrowserView.cpp:
3489         (BrowserView::create):
3490
3491 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
3492
3493         Add missing file to the TestNetscapePlugin sources list after r73057.
3494
3495         * GNUmakefile.am: Add missing file.
3496
3497 2010-12-01  Sam Weinig  <sam@webkit.org>
3498
3499         Reviewed by Anders Carlsson.
3500
3501         Add PageGrouping to WebKit2 API
3502         https://bugs.webkit.org/show_bug.cgi?id=50332
3503
3504         - Update testing harnesses to deal with new PageGroup API.
3505
3506         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3507         (WKBundleInitialize):
3508         * TestWebKitAPI/InjectedBundleController.cpp:
3509         (TestWebKitAPI::InjectedBundleController::initialize):
3510         (TestWebKitAPI::InjectedBundleController::didInitializePageGroup):
3511         (TestWebKitAPI::InjectedBundleController::initializeTestNamed):
3512         * TestWebKitAPI/InjectedBundleController.h:
3513         * TestWebKitAPI/InjectedBundleTest.h:
3514         (TestWebKitAPI::InjectedBundleTest::initialize):
3515         (TestWebKitAPI::InjectedBundleTest::didInitializePageGroup):
3516         * TestWebKitAPI/PlatformUtilities.cpp:
3517         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
3518         * TestWebKitAPI/PlatformUtilities.h:
3519         * TestWebKitAPI/PlatformWebView.h:
3520         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
3521         (TestWebKitAPI::TEST):
3522         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
3523         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
3524         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3525         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3526         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3527         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3528         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3529         (WTR::InjectedBundle::didInitializePageGroup):
3530         (WTR::InjectedBundle::initialize):
3531         (WTR::InjectedBundle::beginTesting):
3532         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3533         (WTR::InjectedBundle::pageGroup):
3534         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3535         (WTR::LayoutTestController::addUserScript):
3536         (WTR::LayoutTestController::addUserStyleSheet):
3537         (WTR::LayoutTestController::setXSSAuditorEnabled):
3538         * WebKitTestRunner/TestController.cpp:
3539         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3540         (WTR::PlatformWebView::PlatformWebView):
3541
3542 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
3543
3544         Reviewed by Adam Roben.
3545
3546         vcproj changes can't be applied cleanly by the Windows EWS bot
3547         https://bugs.webkit.org/show_bug.cgi?id=50328
3548
3549         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
3550         * CLWrapper/CLWrapper.vcproj: Modified property svn:eol-style.
3551         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
3552         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added property svn:eol-style.
3553         * DumpRenderTree/win/DumpRenderTree.vcproj: Modified property svn:eol-style.
3554         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added property svn:eol-style.
3555         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added property svn:eol-style.
3556         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added property svn:eol-style.
3557         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added property svn:eol-style.
3558         * DumpRenderTree/win/ImageDiff.vcproj: Modified property svn:eol-style.
3559         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added property svn:eol-style.
3560         * FindSafari/FindSafari.vcproj: Modified property svn:eol-style.
3561         * FindSafari/FindSafariCommon.vsprops: Added property svn:eol-style.
3562         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
3563         * MIDLWrapper/MIDLWrapper.vcproj: Modified property svn:eol-style.
3564         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added property svn:eol-style.
3565         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added property svn:eol-style.
3566         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added property svn:eol-style.
3567         * MiniBrowser/MiniBrowser.vcproj: Added property svn:eol-style.
3568         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added property svn:eol-style.
3569         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added property svn:eol-style.
3570         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops: Added property svn:eol-style.
3571         * TestWebKitAPI/win/TestWebKitAPI.sln: Added property svn:eol-style.
3572         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added property svn:eol-style.
3573         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added property svn:eol-style.
3574         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added property svn:eol-style.
3575         * WebKitAPITest/WebKitAPITest.vcproj: Added property svn:eol-style.
3576         * WebKitAPITest/WebKitAPITestCommon.vsprops: Added property svn:eol-style.
3577         * WebKitLauncherWin/WebKitLauncherWin.vcproj: Modified property svn:eol-style.
3578         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added property svn:eol-style.
3579         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added property svn:eol-style.
3580         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added property svn:eol-style.
3581         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops: Added property svn:eol-style.
3582         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added property svn:eol-style.
3583         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added property svn:eol-style.
3584         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added property svn:eol-style.
3585         * WebKitTestRunner/WebKitTestRunner.sln: Added property svn:eol-style.
3586         * WebKitTestRunner/win/InjectedBundle.vcproj: Added property svn:eol-style.
3587         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added property svn:eol-style.
3588         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added property svn:eol-style.
3589         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Added property svn:eol-style.
3590         * WinLauncher/WinLauncher.vcproj: Modified property svn:eol-style.
3591         * WinLauncher/WinLauncherCommon.vsprops: Added property svn:eol-style.
3592         * record-memory-win/record-memory-win-common.vsprops: Added property svn:eol-style.
3593         * record-memory-win/record-memory-win.vcproj: Modified property svn:eol-style.
3594
3595 2010-12-01  Anders Carlsson  <andersca@apple.com>
3596
3597         Reviewed by Darin Adler.
3598
3599         Return a correct user agent if NPN_UserAgent is called with a null NPP from NPP_New.
3600         https://bugs.webkit.org/show_bug.cgi?id=50336
3601
3602         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3603         Add new test.
3604
3605         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3606         (PluginTest::NPP_New):
3607         Add default implementation/
3608
3609         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3610         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp: Added.
3611         (GetUserAgentWithNullNPPFromNPPNew::GetUserAgentWithNullNPPFromNPPNew):
3612         (GetUserAgentWithNullNPPFromNPPNew::NPP_New):
3613         Get the user agent.
3614
3615         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3616         (NPP_New):
3617         Call PluginTest::NPP_New.
3618
3619         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3620         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3621         Add new files.
3622
3623         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3624         (webkit_test_plugin_new_instance):
3625         Call PluginTest::NPP_New.
3626
3627 2010-12-01  Kevin Ollivier  <kevino@theolliviers.com>
3628
3629         [wx] Build fixes after recent trunk changes.
3630
3631         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3632         (LayoutTestController::findString):
3633         * wx/build/settings.py:
3634
3635 2010-12-01  Dan Bernstein  <mitz@apple.com>
3636
3637         Reviewed by Darin Adler.
3638
3639         WebKitTestRunner needs layoutTestController.findString
3640         https://bugs.webkit.org/show_bug.cgi?id=50238
3641
3642         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added findString().
3643         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3644         (WTR::LayoutTestController::findString): Updated signature for autogenerated bindings.
3645         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
3646
3647 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
3648
3649         Try using svn:eol-style native on a vcproj file.
3650
3651         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Modified property svn:eol-style.
3652
3653 2010-12-01  Patrick Gansterer  <paroga@webkit.org>
3654
3655         Reviewed by Adam Roben.
3656
3657         [WINCE] Add WinCELauncher
3658         https://bugs.webkit.org/show_bug.cgi?id=50217
3659
3660         * WinCELauncher/main.cpp: Added.
3661
3662 2010-11-30  Benjamin Poulain  <benjamin.poulain@nokia.com>
3663
3664         Reviewed by Kenneth Rohde Christiansen.
3665
3666         [Qt] Implement layoutTestController.findString
3667         https://bugs.webkit.org/show_bug.cgi?id=50236
3668
3669         Add the missing function to the LayoutTestController.
3670
3671         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3672         (LayoutTestController::findString):
3673         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3674
3675 2010-11-30  Tony Chang  <tony@chromium.org>
3676
3677         Reviewed by Adam Barth.
3678
3679         [chromium] fix get-int-identifier-special-values.html using TestNetscapePlugIn
3680         https://bugs.webkit.org/show_bug.cgi?id=49036
3681
3682         * DumpRenderTree/chromium/LayoutTestController.cpp: Use IsNumber instead of IsInt32
3683             for CppVariants.
3684         (LayoutTestController::cppVariantToBool):
3685         (LayoutTestController::cppVariantToInt32):
3686         (LayoutTestController::setDatabaseQuota):
3687         (LayoutTestController::evaluateInWebInspector):
3688         (LayoutTestController::setMockGeolocationError):
3689
3690 2010-11-30  Eric Seidel  <eric@webkit.org>
3691
3692         Reviewed by Tony Chang.
3693
3694         update-webkit should call git fetch before git svn rebase
3695         https://bugs.webkit.org/show_bug.cgi?id=50273
3696
3697         After discussion on webkit-dev, we've decided to move the "default"
3698         git setup to pulling updates from git.webkit.org in preference
3699         to rebuilding the local svn index using git svn fetch every time.
3700
3701         This change should have no effect on people using the "old" git setup
3702         and should dramatically increase the speed of updates for those using
3703         the "new" git setup along with update-webkit.  I'm about to move the
3704         EWS and other queues over to this setup once this lands.
3705
3706         * Scripts/update-webkit:
3707
3708 2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>
3709
3710         Reviewed by Xan Lopez.
3711
3712         GTK: AX: implement press in DRT
3713         https://bugs.webkit.org/show_bug.cgi?id=36146
3714
3715         Implement AccessibilityUIElement::press() for GTK.
3716
3717         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3718         (AccessibilityUIElement::press): Implemented.
3719
3720 2010-11-29  Mihai Parparita  <mihaip@chromium.org>
3721
3722         Reviewed by Tony Chang.
3723
3724         config.webkit_base_dir returns a path with a trailing slash
3725         https://bugs.webkit.org/show_bug.cgi?id=50197
3726         
3727         config.webkit_base_dir() should return a path without a trailing slash,
3728         like all the other methods that return paths.
3729         
3730         Undoes MockFileSytem changes by r72640, since they're no longer
3731         necessary for GetBaselinesTest to pass.
3732
3733         * Scripts/webkitpy/common/system/filesystem_mock.py:
3734         * Scripts/webkitpy/layout_tests/port/base.py:
3735         * Scripts/webkitpy/layout_tests/port/config.py:
3736         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3737
3738 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
3739
3740         Reviewed by Tony Chang.
3741
3742         Rebaseline server: baseline display tweaks
3743         https://bugs.webkit.org/show_bug.cgi?id=50207
3744         
3745         Determine which baselines were used when running the tests and highlight
3746         them in the UI. Sort platform names alphabetically.
3747         
3748         Also makes the server URL be launched in the user's browser
3749         automatically.
3750
3751         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
3752         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
3753         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
3754         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3755         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
3756
3757 2010-11-30  Dan Bernstein  <mitz@apple.com>
3758
3759         Reviewed by Anders Carlsson.
3760
3761         <rdar://problem/8710645> WebKitTestRunner needs layoutTestController.findString
3762         https://bugs.webkit.org/show_bug.cgi?id=50238
3763
3764         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3765         (WTR::LayoutTestController::findString): Added.
3766         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3767
3768 2010-11-30  Steve Falkenburg  <sfalken@apple.com>
3769
3770         Reviewed by Adam Roben.
3771
3772         All projects on Windows should use cmd files for build events
3773         https://bugs.webkit.org/show_bug.cgi?id=50213
3774
3775         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
3776         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Added.
3777         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Added.
3778         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
3779         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Added.
3780         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Added.
3781         * DumpRenderTree/win/ImageDiffCommon.vsprops:
3782         * DumpRenderTree/win/ImageDiffPostBuild.cmd: Added.
3783         * DumpRenderTree/win/ImageDiffPreBuild.cmd: Added.
3784         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops:
3785         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
3786         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops:
3787         * MiniBrowser/MiniBrowserPostBuild.cmd: Added.
3788         * MiniBrowser/MiniBrowserPreBuild.cmd: Added.
3789         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3790         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Added.
3791         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Added.
3792         * WebKitAPITest/WebKitAPITestCommon.vsprops:
3793         * WebKitAPITest/WebKitAPITestPostBuild.cmd: Added.
3794         * WebKitAPITest/WebKitAPITestPreBuild.cmd: Added.
3795         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
3796         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
3797         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd: Added.
3798         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd: Added.
3799         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd: Added.
3800         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd: Added.
3801         * WinLauncher/WinLauncherCommon.vsprops:
3802         * WinLauncher/WinLauncherPostBuild.cmd: Added.
3803         * WinLauncher/WinLauncherPreBuild.cmd: Added.
3804
3805 2010-11-29  Dan Bernstein  <mitz@apple.com>
3806
3807         GTK DumpRenderTree build fix after r72887.
3808
3809         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3810         (LayoutTestController::findString):
3811
3812 2010-11-29  Dan Bernstein  <mitz@apple.com>
3813
3814         Windows DumpRenderTree build fix after r72887.
3815
3816         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3817         (LayoutTestController::findString): Added empty implementation.
3818
3819 2010-11-29  Dan Bernstein  <mitz@apple.com>
3820
3821         Reviewed by Darin Adler.
3822
3823         DumpRenderTree changes for testing the text search API.
3824         https://bugs.webkit.org/show_bug.cgi?id=50038
3825
3826         * DumpRenderTree/LayoutTestController.cpp:
3827         (findStringCallback):
3828         (LayoutTestController::staticFunctions):
3829         * DumpRenderTree/LayoutTestController.h:
3830         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3831         (LayoutTestController::findString):
3832         * MiniBrowser/mac/BrowserWindowController.m:
3833         (-[BrowserWindowController find:]):
3834
3835 2010-11-29  Johnny Ding  <jnd@chromium.org>
3836
3837         Unreviewed: Add myself to the list of Committers.
3838
3839         * Scripts/webkitpy/common/config/committers.py:
3840
3841 2010-11-29  Mark Rowe  <mrowe@apple.com>
3842
3843         Reviewed by Adele Peterson.
3844
3845         <rdar://problem/8694997> DumpRenderTree fails to build.
3846
3847         * DumpRenderTree/mac/PerlSupport/Makefile: Skip generating wrappers.
3848
3849 2010-11-29  Mark Rowe  <mrowe@apple.com>
3850
3851         Reviewed by Adele Peterson.
3852
3853         <rdar://problem/8694997> DumpRenderTree fails to build.
3854
3855         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm.
3856         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapTiger.c.
3857         * DumpRenderTree/mac/PerlSupport/Makefile:
3858
3859 2010-11-29  Mario Sanchez Prada  <msanchez@igalia.com>
3860
3861         Reviewed by Martin Robinson.
3862
3863         [GTK] Null-check needed in DRT's AccessibilityUIElement::allAtributes()
3864         https://bugs.webkit.org/show_bug.cgi?id=50154
3865
3866         Added missing checks to allAttributes().
3867
3868         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3869         (AccessibilityUIElement::allAttributes): Added missing checks.
3870
3871 2010-11-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3872
3873         Reviewed by Kenneth Rohde Christiansen.
3874
3875         [Qt] Allow pre-generation for package builds for WebKit2
3876         https://bugs.webkit.org/show_bug.cgi?id=50139
3877
3878         Use a build variable for the generated directory path and set the
3879         value based on CONFIG just like for WebKit1.
3880
3881         For non-package builds use a relative base path for the
3882         genrated directory just like for WebKit1.
3883
3884         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3885         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3886
3887 2010-11-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3888
3889         Reviewed by Kenneth Rohde Christiansen.
3890
3891         [Qt] Move some build logic from Qt to platform independent code
3892         https://bugs.webkit.org/show_bug.cgi?id=50134
3893
3894         Create target directories inside generate-forwarding-headers.pl.
3895
3896         * Scripts/generate-forwarding-headers.pl:
3897
3898 2010-11-24  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
3899
3900         Reviewed by Martin Robinson.
3901
3902         [GTK] Windowless plugins gets broken key input
3903         https://bugs.webkit.org/show_bug.cgi?id=49927
3904
3905         Convert the XEvent::keycode to ASCII before printing it. Not
3906         doing this was causing false positive in 
3907         plugins/keyboard-events.html.
3908
3909         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3910         (keycode_to_char):
3911         (webkit_test_plugin_handle_event):
3912
3913 2010-11-24  Jan Erik Hanssen  <jhanssen@sencha.com>
3914
3915         Reviewed by Antonio Gomes.
3916
3917         [Qt] Html autofocus not working with QGraphicsWebView
3918         https://bugs.webkit.org/show_bug.cgi?id=43169
3919
3920         Tell the scene to set the webview item as the currently
3921         focused item. This makes the input field with autofocus get
3922         focus as it should.
3923
3924         * QtTestBrowser/webview.cpp:
3925         (WebViewGraphicsBased::WebViewGraphicsBased):
3926
3927 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
3928
3929         Reviewed by Tony Chang.
3930
3931         nrwt - clean up create_driver interface and print out the
3932         command line used for DumpRenderTree/TestShell.
3933
3934         This patch adds a driver_cmd_line() call to the Port class in
3935         order to retrive the command line to print it out (as part of
3936         --print config).
3937
3938         In addition, this patch cleans up the Port.create_driver()
3939         signature and the Driver constructor interface to take a worker
3940         number and no longer require the image_path argument (Chromium's
3941         drivers now synthesize the image_path from the worker number
3942         internally).
3943
3944         https://bugs.webkit.org/show_bug.cgi?id=49934
3945
3946         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3947         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3948         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3949         * Scripts/webkitpy/layout_tests/port/base.py:
3950         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3951         * Scripts/webkitpy/layout_tests/port/chromium.py:
3952         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3953         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3954         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3955         * Scripts/webkitpy/layout_tests/port/test.py:
3956         * Scripts/webkitpy/layout_tests/port/webkit.py:
3957         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3958         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3959
3960 2010-11-24  Ojan Vafai  <ojan@chromium.org>
3961
3962         Reviewed by Tony Chang.
3963
3964         [chromium] improve memory usage for test results server and store fewer runs
3965         https://bugs.webkit.org/show_bug.cgi?id=50035
3966
3967         Store fewer runs and don't pass full files around when we only need bools.
3968         Greatly improves error rates on test-results.appspot.com.
3969
3970         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3971         * TestResultServer/handlers/testfilehandler.py:
3972         * TestResultServer/model/dashboardfile.py:
3973         * TestResultServer/model/jsonresults.py:
3974
3975 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
3976
3977         Reviewed by Tony Chang.
3978
3979         This patch implements the first part of the manager side of the
3980         Broker objects - it handles creating threads, waiting for them
3981         to complete, and running a single-threaded loop as well.
3982
3983         https://bugs.webkit.org/show_bug.cgi?id=49779
3984
3985         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3986         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3987         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3988         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3989
3990 2010-11-24  Mihai Parparita  <mihaip@chromium.org>
3991
3992         Reviewed by David Levin.
3993
3994         DRT should not generate pixel output for text/plain tests
3995         https://bugs.webkit.org/show_bug.cgi?id=50002
3996         
3997         Modify Mac, Windows and GTK DRT implementations to disable pixel output
3998         when encountering a text/plain response (the Chromium one already does
3999         this, and none of the other ports special-case text/plain output in
4000         the first place).
4001
4002         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4003         (dump):
4004         * DumpRenderTree/mac/DumpRenderTree.mm:
4005         (dump):
4006         * DumpRenderTree/win/DumpRenderTree.cpp:
4007         (dump):
4008
4009 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
4010
4011         Unreviewed.
4012
4013         Add my other email address to committers.py.
4014
4015         * Scripts/webkitpy/common/config/committers.py:
4016
4017 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
4018
4019         Reviewed by Csaba Osztrogonác.
4020
4021         Make build-webkit --minimal build with ENABLE_INSPECTOR=0
4022         https://bugs.webkit.org/show_bug.cgi?id=49975
4023
4024         * Scripts/build-webkit: Add ENABLE_INSPECTOR define to features,
4025         to enable the script to define it 0 in case of a minimal build.
4026
4027 2010-11-24  Martin Robinson  <mrobinson@igalia.com>
4028
4029         Reviewed by Xan Lopez.
4030
4031         [GTK] The WebKitWebView should expose a set of signals encapsulating the behavior of the EditorClient
4032         https://bugs.webkit.org/show_bug.cgi?id=49143
4033
4034         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4035         (createWebView): Call the new connectEditingCallbacks function.
4036         * DumpRenderTree/gtk/EditingCallbacks.cpp: Added.
4037         (dumpNodePath):
4038         (dumpRange):
4039         (insertActionString):
4040         (selectionAffinityString):
4041         (shouldBeginEditing):
4042         (shouldEndEditing):
4043         (shouldInsertNode):
4044         (shouldInsertText):
4045         (shouldDeleteRange):
4046         (shouldShowDeleteInterfaceForElement):
4047         (shouldChangeSelectedRange):
4048         (shouldApplyStyle):
4049         (editingBegan):
4050         (userChangedContents):
4051         (editingEnded):
4052         (selectionChanged):
4053         (connectEditingCallbacks):
4054         * DumpRenderTree/gtk/EditingCallbacks.h: Added.
4055         * GNUmakefile.am: Added EditingCallbacks.{h,cpp} to the source list.
4056
4057 2010-11-24  Yi Shen  <yi.4.shen@nokia.com>
4058
4059         Reviewed by Andreas Kling.
4060
4061         [Qt] Make QtTestBrowser remember the selected user agent
4062         https://bugs.webkit.org/show_bug.cgi?id=50021
4063
4064         Set user agent for a new page by using the old page's
4065
4066         * QtTestBrowser/mainwindow.cpp:
4067         (MainWindow::setPage):
4068
4069 2010-11-24 Patrick Gansterer <paroga@webkit.org>
4070
4071         Reviewed by Csaba Osztrogonác.
4072
4073         Remove Bakefile build system files
4074         https://bugs.webkit.org/show_bug.cgi?id=49983
4075
4076         r53757 only removed the content, but not the files.
4077         This patch removes that empty files.
4078
4079         * DumpRenderTree/wx/DumpRenderTree.bkl: Removed.
4080         * wx/browser/browser.bkl: Removed.
4081         * wx/build-wxwebkit: Removed.
4082
4083 2010-11-23  Dirk Pranke  <dpranke@chromium.org>
4084
4085         Reviewed by Tony Chang.
4086
4087         This patch cleans up the logic used to shard tests into groups a
4088         bit and adds the --worker-model flag to NRWT. The flag is only
4089         used at the moment to control whether to run single-threaded or
4090         not, but eventually will also allow toggling between threads and
4091         processes.
4092
4093         Also add a minor cleanup with _test_is_slow(), which just
4094         eliminates some repetition and gives slightly better encapsulation.
4095
4096         https://bugs.webkit.org/show_bug.cgi?id=49773
4097
4098         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4099         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
4100
4101 2010-11-23  Mihai Parparita  <mihaip@chromium.org>
4102
4103         Reviewed by Tony Chang.
4104
4105         Rebaseline server: list current baselines and platforms
4106         https://bugs.webkit.org/show_bug.cgi?id=49991
4107         
4108         List existing baselines (with Trac links) for tests.
4109         
4110         Add dropdowns for choosing with platform baselines to target (and what
4111         to do with existing ones).
4112
4113         Also fix MockFileSystem.join to behave more like os.path.join (unit
4114         test was ending up with two consecutive slashes in a layout test
4115         path).        
4116
4117         * Scripts/webkitpy/common/system/filesystem_mock.py:
4118         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
4119         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
4120         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
4121         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
4122         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
4123         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
4124         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py: Added.
4125
4126 2010-11-23  Ojan Vafai  <ojan@chromium.org>
4127
4128         Reviewed by Tony Chang.
4129
4130         remove timeout argument to urlopen
4131         https://bugs.webkit.org/show_bug.cgi?id=49995
4132
4133         Apparently the version of python we have on the bots doesn't accept a timeout argument.
4134
4135         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
4136
4137 2010-11-23  Sheriff Bot  <webkit.review.bot@gmail.com>
4138
4139         Unreviewed, rolling out r72628.
4140         http://trac.webkit.org/changeset/72628
4141         https://bugs.webkit.org/show_bug.cgi?id=49994
4142
4143         This patch is causing layout-test failtures on GTK Linux
4144         64-bit Debug (Requested by ctguil on #webkit).
4145
4146         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
4147         (AccessibilityUIElement::AccessibilityUIElement):
4148         (AccessibilityUIElement::parentElementCallback):
4149         * DumpRenderTree/chromium/AccessibilityUIElement.h:
4150         * DumpRenderTree/chromium/CppBoundClass.cpp:
4151         * DumpRenderTree/chromium/CppBoundClass.h:
4152
4153 2010-11-22  Ojan Vafai  <ojan@chromium.org>
4154
4155         Reviewed by Tony Chang.
4156
4157         speculative fix for upload errors: stop using mechanize to upload to test-results.appspot.com
4158         https://bugs.webkit.org/show_bug.cgi?id=49944
4159
4160         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
4161
4162 2010-11-23  Chris Guillory  <chris.guillory@google.com>
4163
4164         Reviewed by Dimitri Glazkov.
4165
4166         Include the FrameView widget of a RenderWidget in the accessibility tree.
4167         https://bugs.webkit.org/show_bug.cgi?id=49106
4168
4169         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
4170         (AccessibilityUIElement::AccessibilityUIElement):
4171         (AccessibilityUIElement::parentElementCallback):
4172         (AccessibilityUIElement::isEqualCallback):
4173         * DumpRenderTree/chromium/AccessibilityUIElement.h:
4174         * DumpRenderTree/chromium/CppBoundClass.cpp:
4175         (CppBoundClass::getFromCppVariant):
4176         * DumpRenderTree/chromium/CppBoundClass.h:
4177
4178 2010-11-23  Alex Grilo  <abgrilo@profusion.mobi>
4179
4180         Reviewed by Kenneth Rohde Christiansen.
4181
4182         [EFL] Add tiled backing store to EWebLauncher
4183         https://bugs.webkit.org/show_bug.cgi?id=45777
4184
4185         Allow EWebLauncher to choose between single and tiled backing store
4186
4187         * EWebLauncher/main.c:
4188         (on_key_down):
4189         (browserCreate):
4190         (main):
4191
4192 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
4193
4194         Reviewed by Tor Arne Vestbø.
4195
4196         [Qt] Review the setUserPermission & friends API
4197         https://bugs.webkit.org/show_bug.cgi?id=46810
4198
4199         Renamed requestPermissionFromUser to featurePermissionRequested
4200         and cancelRequestsForPermission to featurePermissionRequestCanceled.
4201
4202         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4203         (WebCore::WebPage::WebPage):
4204         * QtTestBrowser/webpage.cpp:
4205         (WebPage::WebPage):
4206         (WebPage::featurePermissionRequestCanceled):
4207         * QtTestBrowser/webpage.h:
4208
4209 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
4210
4211         Reviewed by Tor Arne Vestbø.
4212
4213         [Qt] Review the setUserPermission & friends API
4214         https://bugs.webkit.org/show_bug.cgi?id=46810
4215
4216         Rename setUserPermission to setFeaturePermission
4217
4218         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4219         (WebCore::WebPage::requestPermission):
4220         (WebCore::WebPage::permissionSet):
4221         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4222         (LayoutTestController::grantDesktopNotificationPermission):
4223         * QtTestBrowser/webpage.cpp:
4224         (WebPage::requestPermission):
4225
4226 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
4227
4228         Reviewed by Tor Arne Vestbø.
4229
4230         [Qt] Review the setUserPermission & friends API
4231         https://bugs.webkit.org/show_bug.cgi?id=46810
4232
4233         Rename PermissionDomain to Feature, NotificationsPermissionDomain to Notifications
4234         and GeolocationPermissionDomain to Geolocation.
4235
4236         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4237         (WebCore::WebPage::WebPage):
4238         (WebCore::WebPage::requestPermission):
4239         (WebCore::WebPage::cancelPermission):
4240         (WebCore::WebPage::permissionSet):
4241         (WebCore::DumpRenderTree::geolocationPermissionSet):
4242         * DumpRenderTree/qt/DumpRenderTreeQt.h:
4243         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4244         (LayoutTestController::grantDesktopNotificationPermission):
4245         * QtTestBrowser/webpage.cpp:
4246         (WebPage::WebPage):
4247         (WebPage::requestPermission):
4248         (WebPage::cancelRequestsForPermission):
4249         * QtTestBrowser/webpage.h:
4250
4251 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
4252
4253         Reviewed by Tor Arne Vestbø.
4254
4255         [Qt] Review the setUserPermission & friends API
4256         https://bugs.webkit.org/show_bug.cgi?id=46810
4257
4258         Add a ByUser suffix to PermissionGranted/Denied. In the future
4259         we can add PermissionGrantedByDefault.
4260
4261
4262         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4263         (WebCore::WebPage::requestPermission):
4264         (WebCore::WebPage::permissionSet):
4265         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4266         (LayoutTestController::grantDesktopNotificationPermission):
4267         * QtTestBrowser/webpage.cpp:
4268         (WebPage::requestPermission):
4269
4270 2010-11-18  Satish Sampath  <satish@chromium.org>
4271
4272         Reviewed by Jeremy Orlow.
4273
4274         For speech input event, send an event object containing all the recognition results and metadata.
4275         https://bugs.webkit.org/show_bug.cgi?id=49736
4276
4277         Updated DRT by renaming the mock result method on all platforms to the new signature.
4278
4279         * DumpRenderTree/LayoutTestController.cpp:
4280         (addMockSpeechInputResultCallback):
4281         (LayoutTestController::staticFunctions):
4282         * DumpRenderTree/LayoutTestController.h:
4283         * DumpRenderTree/chromium/LayoutTestController.cpp:
4284         (LayoutTestController::LayoutTestController):
4285         (LayoutTestController::addMockSpeechInputResult):
4286         * DumpRenderTree/chromium/LayoutTestController.h:
4287         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4288         (LayoutTestController::addMockSpeechInputResult):
4289         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4290         (LayoutTestController::addMockSpeechInputResult):
4291         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4292         (LayoutTestController::addMockSpeechInputResult):
4293         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4294         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4295         (LayoutTestController::addMockSpeechInputResult):
4296         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4297         (LayoutTestController::addMockSpeechInputResult):
4298
4299 2010-11-22  Dirk Pranke  <dpranke@chromium.org>
4300
4301         Reviewed by Tony Chang.
4302
4303         Fix some spacing issues with log messages with
4304         new-run-webkit-tests --verbose.
4305
4306         https://bugs.webkit.org/show_bug.cgi?id=49936
4307
4308         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
4309
4310 2010-11-22  Ojan Vafai  <ojan@chromium.org>
4311
4312         Reviewed by Adam Barth.
4313
4314         update scm to work with different remote branches
4315         https://bugs.webkit.org/show_bug.cgi?id=49949