Tools/ChangeLog

   1 2013-03-04  Kinuko Yasuda  <kinuko@chromium.org>
   2
   3         [chromium] TestWebKitAPI WTF.StringHasher_addCharacters is broken on Chromium Android
   4         https://bugs.webkit.org/show_bug.cgi?id=111284
   5
   6         Disabling the failing two tests on Android.
   7
   8         Reviewed by Jochen Eisinger.
   9
  10         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
  11         (TestWebKitAPI):
  12         (TestWebKitAPI::TEST):
  13
  14 2013-03-04  Kunihiko Sakamoto  <ksakamoto@chromium.org>
  15
  16         Add build flag for FontLoader
  17         https://bugs.webkit.org/show_bug.cgi?id=111289
  18
  19         Reviewed by Benjamin Poulain.
  20
  21         Add ENABLE_FONT_LOAD_EVENTS build flag (disabled by default).
  22
  23         * Scripts/webkitperl/FeatureList.pm:
  24         * qmake/mkspecs/features/features.pri:
  25
  26 2013-03-03  Benjamin Poulain  <benjamin@webkit.org>
  27
  28         [Mac] Get rid of a useless method from DOMHTMLInputElement
  29         https://bugs.webkit.org/show_bug.cgi?id=111279
  30
  31         Reviewed by Sam Weinig.
  32
  33         * DumpRenderTree/mac/TestRunnerMac.mm:
  34         (TestRunner::setValueForUser):
  35         The method _setValueForUser: was added for testing. This feature is already
  36         exposed by DOMHTMLInputElement as a private API and it is how this code is exercised
  37         in real use cases. Get rid of the method created for testing, use the real thing
  38         instead.
  39
  40 2013-03-03  Ryosuke Niwa  <rniwa@webkit.org>
  41
  42         Some perf. tests have variances that differ greatly between runs
  43         https://bugs.webkit.org/show_bug.cgi?id=97510
  44
  45         Reviewed by Benjamin Poulain.
  46
  47         Use multiple instances of DumpRenderTree or WebKitTestRunner to amortize the effect of the runtime
  48         environment on test results (we run each instance after one another, not in parallel).
  49
  50         We use 4 instances of the test runner, each executing 5 in-process iterations, for the total of 20
  51         iterations as it was done previously in single process. These values are hard-coded in perftest.py
  52         and runner.js but they are to be configurable in the future.
  53
  54         Set of 5 iterations obtained by the same test runner is treated as an "iteration group" and each
  55         metric now reports an array of the length 4 with each element containing an array of 5 iteration
  56         values obtained by each test runner instance as opposed to a flattened array of 20 iteration values.
  57
  58         Unfortunately, we can use the same trick on Dromaeo because we're already doing only 5 iterations
  59         and repeating the entire Dromaeo 4 times will take too long. We need to disable more Dromaeo tests
  60         as needed. To this end, added SingleProcessPerfTest to preserve the old behavior.
  61
  62         * Scripts/webkitpy/performance_tests/perftest.py:
  63         (PerfTestMetric.append_group): Renamed from append.
  64         (PerfTestMetric.grouped_iteration_values): Added.
  65         (PerfTestMetric.flattened_iteration_values): Renamed from iteration_values.
  66
  67         (PerfTest.__init__): Takes the number of processes (drivers) to run tests with.
  68         This parameter is only used by SingleProcessPerfTest.
  69
  70         (PerfTest.run): Repeat tests using different driver processes.
  71         (PerfTest._run_with_driver): Returns a boolean instead of a list of measured metrics
  72         since metrics are shared between multiple drivers (i.e. multiple calls to _run_with_driver).
  73         We instead use _ensure_metrics to obtain the matched metrics and store the data there.
  74         (PerfTest._ensure_metrics): Added.
  75
  76         (SingleProcessPerfTest): Added. Used to run Dromaeo tests where running it on 4 different
  77         instances of DumpRenderTree/WebKitTestRunner takes too long.
  78         (SingleProcessPerfTest.__init__):
  79
  80         (ReplayPerfTest._run_with_driver): Updated to use _ensure_metrics.
  81
  82         (PerfTestFactory): Use SingleProcessPerfTest to run Dromaeo tests.
  83
  84         * Scripts/webkitpy/performance_tests/perftest_unittest.py: Updated various tests that expect
  85         _run_with_driver to return a list of metrics. Now it returns a boolean indicating whether
  86         the test succeeded or not. Obtain the dictionary of metrics via test._metrics instead.
  87
  88         (TestPerfTestMetric.test_append): Updated per name and added some test cases for
  89         grouped_iteration_values.
  90
  91         (TestPerfTest._assert_results_are_correct):
  92
  93         (TestSingleProcessPerfTest): Added.
  94         (TestSingleProcessPerfTest.test_use_only_one_process):
  95         (TestSingleProcessPerfTest.test_use_only_one_process.run_single):
  96
  97         (TestReplayPerfTest.test_run_with_driver_accumulates_results):
  98         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):
  99
 100         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py: Updated values of
 101         sample standard deviations since we're now running tests 4 times.
 102         (MainTest._test_run_with_json_output.mock_upload_json):
 103         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):
 104
 105 2013-03-03  Alexandre Elias  <aelias@chromium.org>
 106
 107         [chromium] Remove WebLayerTreeView::setViewportSize call
 108         https://bugs.webkit.org/show_bug.cgi?id=110727
 109
 110         Reviewed by James Robinson.
 111
 112         After https://codereview.chromium.org/12328080 lands,
 113         setViewportSize is called from the Chromium side. The multiplication
 114         by deviceScaleFactor here was prone to off-by-one errors.
 115         The layoutSize() function was only used here so delete it as well.
 116
 117         DumpRenderTree WebViewHost must now call this method as well.
 118
 119         * DumpRenderTree/chromium/WebViewHost.cpp:
 120         (WebViewHost::initializeLayerTreeView):
 121         (WebViewHost::setWindowRect):
 122         (WebViewHost::setDeviceScaleFactor):
 123         (WebViewHost::updateViewportSize):
 124         * DumpRenderTree/chromium/WebViewHost.h:
 125         (WebViewHost):
 126
 127 2013-02-27  Darin Adler  <darin@apple.com>
 128
 129         StringHasher functions require alignment that call sites do not all guarantee
 130         https://bugs.webkit.org/show_bug.cgi?id=110171
 131
 132         Reviewed by Benjamin Poulain.
 133
 134         * TestWebKitAPI/CMakeLists.txt:
 135         * TestWebKitAPI/GNUmakefile.am:
 136         * TestWebKitAPI/TestWebKitAPI.gypi:
 137         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
 138         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
 139         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 140         * TestWebKitAPI/Tests/WTF/WTF.pro:
 141         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
 142         Added the StringHasher.cpp file.
 143
 144         * TestWebKitAPI/Tests/WTF/StringHasher.cpp: Added. Contains a bunch of tests
 145         for the functions in the StringHasher class.
 146
 147 2013-03-02  Benjamin Poulain  <bpoulain@apple.com>
 148
 149         Move computedStyleIncludingVisitedInfo from TestRunner to Internals
 150         https://bugs.webkit.org/show_bug.cgi?id=109772
 151
 152         Reviewed by Andreas Kling.
 153
 154         * DumpRenderTree/TestRunner.cpp:
 155         (TestRunner::staticFunctions):
 156         * DumpRenderTree/TestRunner.h:
 157         (TestRunner):
 158         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
 159         * DumpRenderTree/efl/TestRunnerEfl.cpp:
 160         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
 161         * DumpRenderTree/mac/TestRunnerMac.mm:
 162         * DumpRenderTree/qt/TestRunnerQt.cpp:
 163         * DumpRenderTree/qt/TestRunnerQt.h:
 164         (TestRunner):
 165         * DumpRenderTree/win/TestRunnerWin.cpp:
 166         * DumpRenderTree/wx/TestRunnerWx.cpp:
 167         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
 168         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
 169         * WebKitTestRunner/InjectedBundle/TestRunner.h:
 170         (TestRunner):
 171
 172 2013-03-01  Ilya Tikhonovsky  <loislo@chromium.org>
 173
 174         Web Inspector: Native Memory Instrumentation: do not visit raw pointers by default.
 175         https://bugs.webkit.org/show_bug.cgi?id=110943
 176
 177         Reviewed by Yury Semikhatsky.
 178
 179         Unfortunately in many cases raw pointer may point to an object that has been deleted.
 180         There is no working solution to solve this problem in general.
 181         It could be solved only on case by case basis.
 182
 183         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
 184         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:
 185         (TestWebKitAPI::TEST):
 186
 187 2013-03-01  Jason Anderssen  <janderssen@gmail.com>
 188
 189         Move markerTextForListItem from TestRunner to Internals
 190         https://bugs.webkit.org/show_bug.cgi?id=110939
 191
 192         Reviewed by Benjamin Poulain.
 193
 194         * DumpRenderTree/TestRunner.cpp:
 195         (TestRunner::staticFunctions):
 196         * DumpRenderTree/TestRunner.h:
 197         (TestRunner):
 198         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
 199         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
 200         (WebTestRunner::TestRunner::TestRunner):
 201         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
 202         (TestRunner):
 203         * DumpRenderTree/efl/TestRunnerEfl.cpp:
 204         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
 205         * DumpRenderTree/mac/TestRunnerMac.mm:
 206         * DumpRenderTree/qt/TestRunnerQt.cpp:
 207         * DumpRenderTree/qt/TestRunnerQt.h:
 208         (TestRunnerQt):
 209         * DumpRenderTree/win/TestRunnerWin.cpp:
 210         * DumpRenderTree/wx/TestRunnerWx.cpp:
 211         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
 212         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
 213         * WebKitTestRunner/InjectedBundle/TestRunner.h:
 214         (TestRunner):
 215
 216 2013-03-01  Ryosuke Niwa  <rniwa@webkit.org>
 217
 218         Don't use legacy test names when returning results from PerfTest.run
 219         https://bugs.webkit.org/show_bug.cgi?id=111148
 220
 221         Reviewed by Dirk Pranke.
 222
 223         * Scripts/webkitpy/performance_tests/perftest.py:
 224         (PerfTestMetric.name): Renamed from metric.
 225         (PerfTest.test_name_without_file_extension): Extracted from legacy_chromium_bot_compatible_test_name.
 226         (PerfTest.run): Use metric name instead of the legacy name to store iteration values.
 227         (ChromiumStylePerfTest.parse_and_log_output): Use the metric name to store results as done in PerfTest.run.
 228
 229         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
 230         (TestPerfTestMetric.test_init_set_time_metric):
 231         (TestPerfTestMetric.legacy_chromium_bot_compatible_test_name): Removed. The integration tests test this.
 232         (TestReplayPerfTest.test_run_with_driver_accumulates_results):
 233         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):
 234
 235         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
 236         (PerfTestsRunner.__init__):
 237         (PerfTestsRunner._generate_results_dict): Updated to iterate over (test, metrics) pair. Use view_source_url
 238         to obtain the trac URL instead of hard coding it.
 239         (PerfTestsRunner._run_tests_set):
 240
 241 2013-03-01  Roger Fong  <roger_fong@apple.com>
 242
 243         Unreviewed. Add an extra project that assembles all project build logs on Windows into a single file.
 244         https://bugs.webkit.org/show_bug.cgi?id=111202
 245
 246         This is useful for running VCExpress builds from command line because there is
 247         no unified solution output, only per project build logs.
 248         The project will be run as the last project in the solution.
 249
 250         * win/AssembleBuildLogs: Added.
 251         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj: Added.
 252         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj.filters: Added.
 253         * win/AssembleBuildLogs/AssembleLogs.cmd: Added.
 254         * win/AssembleBuildLogs/README: Added.
 255
 256 2013-03-01  Roger Fong  <roger_fong@apple.com>
 257
 258         Unreviewed. Increase number of patches processed before clean building on WinEWS bots.
 259
 260         * EWSTools/start-queue-win.sh:
 261
 262 2013-03-01  Ryosuke Niwa  <rniwa@webkit.org>
 263
 264         Don't return statistics in PerfTest.run
 265         https://bugs.webkit.org/show_bug.cgi?id=111145
 266
 267         Reviewed by Dirk Pranke.
 268
 269         Simply return a list of values obtained in each iteration from PerfTest.run.
 270         Also simplify various methods as needed.
 271
 272         * Scripts/webkitpy/performance_tests/perftest.py:
 273         (PerfTestMetric.__init__): Moved the code to convert 'Time' metric to 'FrameRate' and 'Runs'
 274         as needed from PerfTestsRunner._generate_results_dict.
 275
 276         (PerfTestMetric.legacy_chromium_bot_compatible_test_name): Always append the metric name now
 277         that we don't have to worry about the backward compatibility here.
 278
 279         (PerfTestMetric.iteration_values): Added.
 280         (PerfTestMetric.unit): Added.
 281         (PerfTestMetric.metric_to_unit):
 282         (PerfTestMetric.time_unit_to_metric): Extracted from PerfTestsRunner._generate_results_dict.
 283
 284         (PerfTest.run):
 285         (PerfTest.log_statistics): Merged compute_statistics and self.output_statistics.
 286
 287         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
 288         (TestPerfTestMetric.test_init_set_missing_unit):
 289         (TestPerfTestMetric.test_init_set_time_metric): Added.
 290         (TestPerfTestMetric.test_legacy_chromium_bot_compatible_test_name):
 291         (TestPerfTestMetric.test_append):
 292         (TestPerfTestMetric.test_compute_statistics): Removed. Integration tests check some of these
 293         test cases and it's not critical to keep math right as they're not used in output JSON anymore.
 294         (TestPerfTest._assert_results_are_correct):
 295         (TestReplayPerfTest.test_run_with_driver_accumulates_results):
 296         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):
 297
 298         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
 299         (PerfTestsRunner._generate_results_dict):
 300
 301         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
 302         (EventTargetWrapperTestData): The metric name shows up at the end of the test name as expected.
 303         (SomeParserTestData): Ditto.
 304         (MemoryTestData): Ditto.
 305
 306 2013-03-01  Allan Sandfeld Jensen  <allan.jensen@digia.com>
 307
 308         [Qt] Enable LINK_PREFETCH
 309         https://bugs.webkit.org/show_bug.cgi?id=111158
 310
 311         Reviewed by Simon Hausmann.
 312
 313         * qmake/mkspecs/features/features.pri:
 314
 315 2013-03-01  Allan Sandfeld Jensen  <allan.jensen@digia.com>
 316
 317         [Qt] Update features.pri with new features
 318         https://bugs.webkit.org/show_bug.cgi?id=111157
 319
 320         Reviewed by Jocelyn Turcotte.
 321
 322         * qmake/mkspecs/features/features.pri:
 323
 324 2013-03-01  Jochen Eisinger  <jochen@chromium.org>
 325
 326         [chromium] put WebTestProxy::scheduleComposite back in place
 327         https://bugs.webkit.org/show_bug.cgi?id=111146
 328
 329         Reviewed by Nico Weber.
 330
 331         The call was removed in http://trac.webkit.org/changeset/144398 because
 332         DRT doesn't need it. However, content shell depends on this call.
 333
 334         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
 335         (WebTestRunner::WebTestProxy::scheduleComposite):
 336
 337 2013-02-28  Ryosuke Niwa  <rniwa@webkit.org>
 338
 339         Merge PerfTestRunner._run_single_test into PerfTestRunner._run_tests_set
 340         https://bugs.webkit.org/show_bug.cgi?id=111142
 341
 342         Reviewed by Adam Barth.
 343
 344         Merged _run_single_test into _run_tests_set. The code looks much cleaner now.
 345
 346         Also removed _print_status since it's never used anywhere.
 347
 348         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
 349         (PerfTestsRunner.run):
 350         (PerfTestsRunner._run_tests_set):
 351         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
 352         (MainTest.run_test):
 353         (MainTest.test_run_test_set):
 354         (MainTest.test_run_test_set_kills_drt_per_run):
 355         (MainTest.test_run_test_set_for_parser_tests):
 356
 357 2013-02-28  Kiran Muppala  <cmuppala@apple.com>
 358
 359         Disable window occlusion detection for WebKitTestRunner Web View on Mac
 360         https://bugs.webkit.org/show_bug.cgi?id=111116
 361
 362         Reviewed by Simon Fraser.
 363
 364         Window occlusion notifications were causing WebKitTestRunner's Web View
 365         to be detected as occluded and causing a few JavaScript timer layout
 366         tests to fail.  https://bugs.webkit.org/show_bug.cgi?id=111025, fixed this
 367         by initializing the page visibility to "visible" after creating the view.
 368         But a better solution is to disable window occlusion detection, so that
 369         not only the page but also the view is treated as visible.
 370
 371         * WebKitTestRunner/TestController.cpp:
 372         (WTR::TestController::createWebViewWithOptions): Remove call to
 373         setVisibilityState, since it is no longer necessary.
 374         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
 375         (WTR::PlatformWebView::PlatformWebView): Disable window occlusion
 376         detection for the created WKView.
 377
 378 2013-02-28  Li Yin  <li.yin@intel.com>
 379
 380         [chromium] Events can't be triggered on MediaStreamTrack
 381         https://bugs.webkit.org/show_bug.cgi?id=110930
 382
 383         Reviewed by Kentaro Hara.
 384
 385         Related code was moved to MediaStreamCenterChromium::didStopLocalMediaStream
 386
 387         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp:
 388         (WebTestRunner::MockWebMediaStreamCenter::didStopLocalMediaStream):
 389
 390 2013-02-27  James Robinson  <jamesr@chromium.org>
 391
 392         [chromium] Use DumpRenderTree-specific interface for DRT's compositor embedding
 393         https://bugs.webkit.org/show_bug.cgi?id=111017
 394
 395         Reviewed by Adam Barth.
 396
 397         This decouples DumpRenderTree from WebLayerTreeViewClient.
 398
 399         * DumpRenderTree/chromium/WebViewHost.cpp:
 400         (WebViewHostDRTLayerTreeViewClient):
 401         (WebViewHostDRTLayerTreeViewClient::WebViewHostDRTLayerTreeViewClient):
 402         (WebViewHostDRTLayerTreeViewClient::~WebViewHostDRTLayerTreeViewClient):
 403         (WebViewHostDRTLayerTreeViewClient::Layout):
 404         (WebViewHostDRTLayerTreeViewClient::ScheduleComposite):
 405         (WebViewHost::initializeLayerTreeView):
 406         * DumpRenderTree/chromium/WebViewHost.h:
 407         (webkit_support):
 408         (WebViewHost):
 409
 410 2013-02-28  Ryuan Choi  <ryuan.choi@samsung.com>
 411
 412         Unreviewed, add my secondary email address to the list.
 413
 414         * Scripts/webkitpy/common/config/committers.py:
 415
 416 2013-02-28  Philip Rogers  <pdr@google.com>
 417
 418         Add Philip Rogers as a reviewer.
 419
 420         Unreviewed update of committers.py.
 421
 422         * Scripts/webkitpy/common/config/committers.py:
 423
 424 2013-02-28  Ryosuke Niwa  <rniwa@webkit.org>
 425
 426         Merge more methods on PerfTest
 427         https://bugs.webkit.org/show_bug.cgi?id=111030
 428
 429         Reviewed by Dirk Pranke.
 430
 431         Merged parse_output into _run_with_driver as it was the only caller. Also merged _should_ignore_line_in_stderr
 432         and _should_ignore_line_in_parser_test_result into _filter_output since it was their only caller.
 433
 434         This makes the control flow a lot more comprehensible.
 435
 436         * Scripts/webkitpy/performance_tests/perftest.py:
 437         (PerfTest._run_with_driver):
 438         (PerfTest._should_ignore_line):
 439         (PerfTest._filter_output):
 440
 441         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
 442         (TestPerfTest._assert_results_are_correct):
 443         (test_ignored_stderr_lines):
 444
 445 2013-02-28  Robert Hogan  <robert@webkit.org>
 446
 447         Update my IRC nick
 448
 449         Unreviewed.
 450
 451         * Scripts/webkitpy/common/config/committers.py:
 452
 453 2013-02-28  Andras Becsi  <andras.becsi@digia.com>
 454
 455         [Qt] Enable thin archives before parsing the project files
 456
 457         Rubber-stamped by Simon Hausmann.
 458
 459         The targetSubDir() function can be called before default_post.prf has been
 460         parsed therefore the gnu_thin_archives option has to be set in default_pre.prf
 461         which is parsed before the main project file.
 462         This issue was revealed by r144299 and fixes the clean build.
 463
 464         * qmake/mkspecs/features/default_post.prf:
 465         * qmake/mkspecs/features/default_pre.prf:
 466
 467 2013-02-28  Allan Sandfeld Jensen  <allan.jensen@digia.com>
 468
 469         [Qt] Enable CANVAS_PATH flag
 470         https://bugs.webkit.org/show_bug.cgi?id=108508
 471
 472         Reviewed by Simon Hausmann.
 473
 474         Also enable CANVAS_PATH flag for Qt.
 475
 476         * qmake/mkspecs/features/features.pri:
 477
 478 2013-02-28  Andras Becsi  <andras.becsi@digia.com>
 479
 480         [Qt][TestWebKitAPI] The activeBuildConfig() function has been replaced with targetSubDir()
 481
 482         Rubber-stamped by Csaba Osztrogonác.
 483
 484         Besides suppressing a warning about the non-existing function this
 485         fixes the build if there is a subdirectory (eg. debug-and-release).
 486
 487         * TestWebKitAPI/InjectedBundle.pri:
 488         * TestWebKitAPI/TestWebKitAPI.pri:
 489
 490 2013-02-28  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
 491
 492         [EFL][WTR] WTR cannot load injected bundle
 493         https://bugs.webkit.org/show_bug.cgi?id=111063
 494
 495         Reviewed by Csaba Osztrogonác.
 496
 497         WTR was not able to load injected bundle because of undefined
 498         symbols for AccessibilityUIElement::scrollToMakeVisible().
 499         Adding empty implementation of this function to AccessibilityUIElementAtk.cpp
 500         solves the problem.
 501
 502         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
 503         (WTR::AccessibilityUIElement::scrollToMakeVisible):
 504
 505 2013-02-28  Alberto Garcia  <albgarcia@rim.com>
 506
 507         [BlackBerry] TestRunnerBlackBerry: remove layerTreeAsText, it's gone from upstream
 508         https://bugs.webkit.org/show_bug.cgi?id=110464
 509
 510         Reviewed by Rob Buis.
 511
 512         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
 513
 514 2013-02-28  Xan Lopez  <xlopez@rim.com>
 515
 516         [BlackBerry] DumpRenderTreeSupport: update the set position methods
 517         https://bugs.webkit.org/show_bug.cgi?id=110578
 518
 519         Reviewed by Rob Buis.
 520
 521         TestRunner::setMockGeolocationPosition() changed in r130416:
 522         http://trac.webkit.org/changeset/130416/trunk/Tools/DumpRenderTree/TestRunner.h
 523
 524         DumpRenderTreeSupport::setMockGeolocationError() was renamed to
 525         setMockGeolocationPositionUnavailableError() in r129444:
 526         http://trac.webkit.org/changeset/129444/trunk/Source/WebKit/blackberry/WebKitSupport/DumpRenderTreeSupport.h
 527
 528         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
 529         (TestRunner::setMockGeolocationPosition):
 530         (TestRunner::setMockGeolocationPositionUnavailableError):
 531
 532 2013-02-28  Xan Lopez  <xlopez@rim.com>
 533
 534         [BlackBerry] WorkQueueItemBlackBerry: use the new FrameLoader API
 535         https://bugs.webkit.org/show_bug.cgi?id=110465
 536
 537         Reviewed by Rob Buis.
 538
 539         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
 540         (LoadItem::invoke):
 541
 542 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
 543
 544         PerfTestRunner doesn't need _needs_http and _has_http_lock
 545         https://bugs.webkit.org/show_bug.cgi?id=111037
 546
 547         Reviewed by Adam Barth.
 548
 549         Delete these variables in favor of using a local variable.
 550
 551         Member variables are like global variables. They introduce implicit dependencies
 552         between member functions.
 553
 554         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
 555         (PerfTestsRunner.__init__):
 556         (PerfTestsRunner._start_http_servers):
 557         (PerfTestsRunner):
 558         (PerfTestsRunner._stop_http_servers):
 559         (PerfTestsRunner.run):
 560
 561 2013-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
 562
 563         Unreviewed, rolling out r144224.
 564         http://trac.webkit.org/changeset/144224
 565         https://bugs.webkit.org/show_bug.cgi?id=111045
 566
 567         Caused plugins/pass-different-npp-struct.html to time out
 568         (Requested by abarth on #webkit).
 569
 570         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
 571         (PassDifferentNPPStruct::NPP_SetWindow):
 572         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
 573         (NPP_SetWindow):
 574
 575 2013-02-27  Adam Barth  <abarth@webkit.org>
 576
 577         [Chromium] Enable threaded HTML parser by default in DumpRenderTree
 578         https://bugs.webkit.org/show_bug.cgi?id=110907
 579
 580         Reviewed by Eric Seidel.
 581
 582         This patch changes --enable-threaded-html-parser into
 583         --disable-threaded-html-parser and thereby enables the threaded HTML
 584         parser by default for the Chromium port.
 585
 586         * DumpRenderTree/chromium/DumpRenderTree.cpp:
 587         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
 588         (WebTestRunner::WebPreferences::reset):
 589         * DumpRenderTree/chromium/TestShell.cpp:
 590         (TestShell::TestShell):
 591
 592 2013-02-27  Kiran Muppala  <cmuppala@apple.com>
 593
 594         Initialize page visibility after creating WebKitTestRunner WebView on Mac
 595         https://bugs.webkit.org/show_bug.cgi?id=111025
 596
 597         Reviewed by Simon Fraser.
 598
 599         Set page visibility to "visible" after creating WebView to override
 600         visibility state inferred from window occlusion notifications on Mac.
 601
 602         * WebKitTestRunner/TestController.cpp:
 603         (WTR::TestController::createWebViewWithOptions): Add call to
 604         setVisibilityState.
 605
 606 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
 607
 608         Merge PageLoadingPerfTest into ReplayPerfTest
 609         https://bugs.webkit.org/show_bug.cgi?id=111027
 610
 611         Reviewed by Dirk Pranke.
 612
 613         Merged two classes.
 614
 615         We should really move ahead with the bug 100991 and get rid of PageLoadingPerfTest
 616         part of ReplayPerfTest.
 617
 618         * Scripts/webkitpy/performance_tests/perftest.py:
 619         (ReplayPerfTest): Moved _FORCE_GC_FILE here.
 620         (ReplayPerfTest.__init__):
 621         (ReplayPerfTest._run_with_driver): Moved from PageLoadingPerfTest.
 622         (ReplayPerfTest.run_single): Load the GC page as run_single on PageLoadingPerfTest did.
 623         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
 624         (TestReplayPerfTest):
 625         (TestReplayPerfTest.test_run_single.run_test):
 626         (TestReplayPerfTest.test_run_single): Make sure test_time is passed down properly from output.
 627         (TestReplayPerfTest.test_run_with_driver_accumulates_results): Renamed from
 628         TestPageLoadingPerfTest.test_run.
 629         (TestReplayPerfTest.test_run_with_driver_accumulates_results.mock_run_signle):
 630         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results): Renamed from
 631         TestPageLoadingPerfTest.test_run_with_memory_output
 632         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results.mock_run_signle):
 633         (TestReplayPerfTest.test_prepare_calls_run_single):
 634
 635 2013-02-27  Eric Seidel  <eric@webkit.org>
 636
 637         Add --additional-drt-flag option to run-perf-tests to make it easy to test runtime options
 638         https://bugs.webkit.org/show_bug.cgi?id=111021
 639
 640         Reviewed by Dirk Pranke.
 641
 642         The underlying code (which is shared with run-webkit-tests)
 643         already knew how to support this option, it just wasn't exposed
 644         via the run-perf-tests front-end.  This patch fixes that.
 645
 646         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
 647         (PerfTestsRunner._parse_args):
 648
 649 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
 650
 651         Stop uploading results to webkit-perf.appspot.com
 652         https://bugs.webkit.org/show_bug.cgi?id=110954
 653
 654         Reviewed by Benjamin Poulain.
 655
 656         Pass in perf.webkit.org instead of webkit-perf.appspot.com as the test results server.
 657
 658         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 659         (RunAndUploadPerfTests):
 660
 661 2013-02-27  James Simonsen  <simonjam@chromium.org>
 662
 663         [chromium] Lower priority of preloaded images
 664         https://bugs.webkit.org/show_bug.cgi?id=110527
 665
 666         Plumb the didChangePriority signal into DRT so it can be tested.
 667
 668         Reviewed by Nate Chapin.
 669
 670         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
 671         (WebKit):
 672         (WebTestRunner::WebTestProxy::didChangeResourcePriority):
 673         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
 674         (WebTestRunner::TestRunner::TestRunner):
 675         (WebTestRunner::TestRunner::reset):
 676         (WebTestRunner::TestRunner::shouldDumpResourcePriorities):
 677         (WebTestRunner):
 678         (WebTestRunner::TestRunner::dumpResourceRequestPriorities):
 679         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
 680         (TestRunner):
 681         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
 682         (WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
 683         (WebTestRunner::WebTestProxyBase::willSendRequest):
 684         (WebTestRunner::WebTestProxyBase::didChangeResourcePriority):
 685         (WebTestRunner):
 686
 687 2013-02-27  Chris Fleizach  <cfleizach@apple.com>
 688
 689         AX: Mac platform should support ability to scroll an element into visible
 690         https://bugs.webkit.org/show_bug.cgi?id=109860
 691
 692         Reviewed by Beth Dakin.
 693
 694         * DumpRenderTree/AccessibilityUIElement.cpp:
 695         (scrollToMakeVisibleCallback):
 696         (AccessibilityUIElement::getJSClass):
 697         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
 698         (AccessibilityUIElement::scrollToMakeVisible):
 699         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
 700         (WTR::AccessibilityUIElement::scrollToMakeVisible):
 701         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
 702         (AccessibilityUIElement):
 703         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
 704         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
 705         (WTR::AccessibilityUIElement::scrollToMakeVisible):
 706         (WTR):
 707
 708 2013-02-27  John Bauman  <jbauman@chromium.org>
 709
 710         Plugin in iframe may not display
 711         https://bugs.webkit.org/show_bug.cgi?id=109879
 712
 713         Reviewed by Simon Fraser.
 714
 715         LogNPPSetWindow will be used with other ports as well.
 716
 717         * DumpRenderTree/DumpRenderTree.gypi:
 718         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
 719
 720 2013-02-27  Jochen Eisinger  <jochen@chromium.org>
 721
 722         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
 723         https://bugs.webkit.org/show_bug.cgi?id=110973
 724
 725         Reviewed by Adam Barth.
 726
 727         There is nothing that ensures that the log messages from the plugin
 728         come in before the layout test finished loading.
 729
 730         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
 731         (PassDifferentNPPStruct::NPP_SetWindow):
 732         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
 733         (NPP_SetWindow):
 734
 735 2013-02-27  Glenn Adams  <glenn@skynav.com>
 736
 737         Add ENABLE_CSS3_TEXT_LINE_BREAK flag.
 738         https://bugs.webkit.org/show_bug.cgi?id=110944
 739
 740         Reviewed by Dean Jackson.
 741
 742         * Scripts/webkitperl/FeatureList.pm:
 743         * qmake/mkspecs/features/features.pri:
 744
 745 2013-02-27  Yong Li  <yong.li.webkit@outlook.com>
 746
 747         Unreviewed. Remove myself from watchlist.
 748
 749         * Scripts/webkitpy/common/config/watchlist:
 750
 751 2013-02-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>
 752
 753         Switch QtWebKit to GStreamer 1.0.
 754         https://bugs.webkit.org/show_bug.cgi?id=106669.
 755
 756         Original patch by Sebastian Dröge.
 757         Reviewed by Csaba Osztrogonác.
 758
 759         Build with GStreamer 1.0 if available, but support GStreamer 0.10
 760         temporarily to make upgrading easy and the patch suitable for Qt5.
 761
 762         * qmake/mkspecs/features/features.prf:
 763
 764 2013-02-27  Szilard Ledan  <szledan@inf.u-szeged.hu>
 765
 766         Unreviewed. Added myself to committers.py
 767
 768         * Scripts/webkitpy/common/config/committers.py:
 769
 770 2013-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
 771
 772         Unreviewed, rolling out r144192.
 773         http://trac.webkit.org/changeset/144192
 774         https://bugs.webkit.org/show_bug.cgi?id=110984
 775
 776         Stored svn password on wrong computer (Requested by kkristof
 777         on #webkit).
 778
 779         * Scripts/webkitpy/common/config/committers.py:
 780
 781 2013-02-27  Szilard Ledan  <szledan@inf.u-szeged.hu>
 782
 783         Unreviewed. Added myself to committers.py
 784
 785         * Scripts/webkitpy/common/config/committers.py:
 786
 787 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
 788
 789         Build fix after r144155. The report page is located at /api/report, not /api/test/report.
 790
 791         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
 792         (PerfTestsRunner._upload_json):
 793
 794 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
 795
 796         Stop uploading results to webkit-perf.appspot.com
 797         https://bugs.webkit.org/show_bug.cgi?id=110954
 798
 799         Reviewed by Benjamin Poulain.
 800
 801         When the specified test results server was webkit-perf.appspot.com, replace it by perf.webkit.org.
 802         Also, always use the new JSON format. Removed the code to generate the old format.
 803
 804         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
 805         (PerfTestsRunner._generate_and_show_results):
 806         (PerfTestsRunner._generate_results_dict):
 807         (PerfTestsRunner._merge_slave_config_json):
 808         (PerfTestsRunner._generate_output_files):
 809
 810 2013-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
 811
 812         Unreviewed, rolling out r144136, r144143, and r144147.
 813         http://trac.webkit.org/changeset/144136
 814         http://trac.webkit.org/changeset/144143
 815         http://trac.webkit.org/changeset/144147
 816         https://bugs.webkit.org/show_bug.cgi?id=110950
 817
 818         Caused some timeouts and flaky crashes (Requested by abarth on
 819         #webkit).
 820
 821         * DumpRenderTree/chromium/DumpRenderTree.cpp:
 822         (main):
 823         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
 824         (WebTestRunner::WebPreferences::reset):
 825         * DumpRenderTree/chromium/TestShell.cpp:
 826         (TestShell::TestShell):
 827
 828 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
 829
 830         Use perf.webkit.org JSON format in results page
 831         https://bugs.webkit.org/show_bug.cgi?id=110842
 832
 833         Reviewed by Benjamin Poulain.
 834
 835         Change the default JSON format from that of webkit-perf.appspot.com to that of perf.webkit.org.
 836
 837         A whole bunch of integration tests have been updated to use the new JSON format.
 838
 839         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
 840         (PerfTestsRunner._generate_and_show_results): Renamed output and output_path to legacy_output
 841         and legacy_output_json_path respectively.
 842         (PerfTestsRunner._generate_results_dict): Don't assume meta build information is always available.
 843         (PerfTestsRunner._generate_output_files): Make json_output, which is used to generate the default
 844         JSON file and the results page out of perf_webkit_output instead of legacy_output.
 845
 846         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
 847         (MainTest.test_run_memory_test):
 848         (MainTest._test_run_with_json_output.mock_upload_json):
 849         (MainTest):
 850         (MainTest.test_run_with_json_output):
 851         (MainTest.test_run_with_description):
 852         (MainTest.test_run_generates_json_by_default):
 853         (MainTest.test_run_merges_output_by_default):
 854         (MainTest.test_run_respects_reset_results):
 855         (MainTest.test_run_generates_and_show_results_page):
 856         (MainTest.test_run_with_slave_config_json):
 857         (MainTest.test_run_with_multiple_repositories):
 858         (MainTest.test_run_with_upload_json):
 859         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):
 860
 861 2013-02-26  Adam Barth  <abarth@webkit.org>
 862
 863         [Chromium] Enable threaded HTML parser by default in DumpRenderTree
 864         https://bugs.webkit.org/show_bug.cgi?id=110907
 865
 866         Reviewed by Eric Seidel.
 867
 868         This patch changes --enable-threaded-html-parser into
 869         --disable-threaded-html-parser and thereby enables the threaded HTML
 870         parser by default for the Chromium port.
 871
 872         * DumpRenderTree/chromium/DumpRenderTree.cpp:
 873         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
 874         (WebTestRunner::WebPreferences::reset):
 875         * DumpRenderTree/chromium/TestShell.cpp:
 876         (TestShell::TestShell):
 877
 878 2013-02-26  Dirk Pranke  <dpranke@chromium.org>
 879
 880         [chromium] Re-enable the fixed version of freetype on linux
 881         https://bugs.webkit.org/show_bug.cgi?id=110542
 882
 883         Reviewed by Tony Chang.
 884
 885         Re-land the change in r143794 to switch to building with a fixed
 886         version of FreeType for just DumpRenderTree. This allows us to share
 887         one version of pixel baselines for both Lucid and Precise, and run the
 888         layout tests in a stock Precise install (instead of a Lucid chroot).
 889         Going forward, this approach isolates us from os-level changes to the
 890         version of FreeType. Note that Chromium itself still uses the system
 891         FreeType and is unaffected by this change.
 892
 893         This setting can still be turned off (at compile/gyp-time) by
 894         manually setting use_custom_freetype=0.
 895
 896         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
 897
 898 2013-02-26  Nico Weber  <thakis@chromium.org>
 899
 900         [chromium] content shell drt: Enable WebKit::setLayoutTestMode()
 901         https://bugs.webkit.org/show_bug.cgi?id=110890
 902
 903         Reviewed by Jochen Eisinger.
 904
 905         Several functions in webkit check that bit to change rendering
 906         in layout test mode. For example, platform/graphics/skia/FrontSkia.cpp
 907         disables font smoothing in this mode. TestShell and DRT both set
 908         this flag, so content shell drt should set it too.
 909
 910         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
 911         (WebTestRunner::TestInterfaces::TestInterfaces):
 912
 913 2013-02-26  Vivek Galatage  <vivek.vg@samsung.com>
 914
 915         new-commit-bot: Fix the unit test newcommitbot-unittest.py due to r144040
 916         https://bugs.webkit.org/show_bug.cgi?id=110884
 917
 918         Reviewed by Csaba Osztrogonác.
 919
 920         Adding the missing spaces before ':' in the unit test.
 921
 922         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
 923
 924 2013-02-26  Vivek Galatage  <vivek.vg@samsung.com>
 925
 926         new-commit-bot: Some IRC clients doesn't linkify rollout messages
 927         https://bugs.webkit.org/show_bug.cgi?id=110861
 928
 929         Reviewed by Ryosuke Niwa.
 930
 931         Adding the space before ':' in order to fix the links shown for the rollout message.
 932
 933         * Scripts/webkitpy/tool/commands/newcommitbot.py:
 934         (NewCommitBot._summarize_commit_log):
 935
 936 2013-02-26  Joone Hur  <joone.hur@intel.com>
 937
 938         [GTK] Add Clutter to jhbuild
 939         https://bugs.webkit.org/show_bug.cgi?id=110245
 940
 941         Reviewed by Martin Robinson.
 942
 943         Add clutter, cogl, clutter-gtk, and atk to the optional moduleset.
 944         This allows to build WebKitGtk+ with clutter as an acceleration backend
 945         within the jhbuild environment.
 946
 947         * gtk/jhbuild-optional.modules:
 948
 949 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
 950
 951         Another fix attempt after r143991 since having \r? after a greedy match doesn't help.
 952
 953         * Scripts/webkitpy/common/checkout/scm/svn.py:
 954         (SVN.value_from_svn_info):
 955
 956 2013-02-25  Alan Cutter  <alancutter@chromium.org>
 957
 958         GCE EWS bots failing intermittently on HTTP 502 error while updating their status
 959         https://bugs.webkit.org/show_bug.cgi?id=110845
 960
 961         Unreviewed EWS bot fix.
 962
 963         Switch the Queue Status Server address the EWS bots use to a more direct URL that
 964         doesn't seem to be having problems from GCE like queues.webkit.org.
 965
 966         * Scripts/webkitpy/common/net/statusserver.py:
 967         (StatusServer):
 968
 969 2013-02-25  Dirk Pranke  <dpranke@chromium.org>
 970
 971         Forgot to delete a no-longer-needed unit test after r143980.
 972
 973         Unreviewed, build fix.
 974
 975         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
 976         (ChromiumWinTest.test_path_to_image_diff):
 977
 978 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
 979
 980         Build fix. run-perf-tests was reporting with revision numbers ending with \r.
 981         Don't include \r at the end of svn info lines on Windows.
 982
 983         This is similar to r143839.
 984
 985         * Scripts/webkitpy/common/checkout/scm/svn.py:
 986         (SVN.value_from_svn_info):
 987
 988 2013-02-25  James Simonsen  <simonjam@chromium.org>
 989
 990         [Resource Timing] Update test suite so it can be exported to the W3C
 991         https://bugs.webkit.org/show_bug.cgi?id=107343
 992
 993         Reviewed by Tony Gentilcore.
 994
 995         * Scripts/export-w3c-performance-wg-tests: Clean up output.
 996         * Scripts/import-w3c-performance-wg-tests:
 997
 998 2013-02-25  Anders Carlsson  <andersca@apple.com>
 999
1000         Add a new unavailablePluginButtonClicked callback that takes a WKDictionary of plug-in information
1001         https://bugs.webkit.org/show_bug.cgi?id=110821
1002         <rdar://problem/13265303>
1003
1004         Reviewed by Beth Dakin.
1005
1006         Update for WebKit2 changes.
1007
1008         * MiniBrowser/mac/WK2BrowserWindowController.m:
1009         (-[WK2BrowserWindowController awakeFromNib]):
1010         * WebKitTestRunner/TestController.cpp:
1011         (WTR::TestController::createOtherPage):
1012         (WTR::TestController::createWebViewWithOptions):
1013         (WTR::TestController::unavailablePluginButtonClicked):
1014         * WebKitTestRunner/TestController.h:
1015         (TestController):
1016
1017 2013-02-21  Jeffrey Pfau  <jpfau@apple.com>
1018
1019         Optionally partition cache to prevent using cache for tracking
1020         https://bugs.webkit.org/show_bug.cgi?id=110269
1021
1022         Reviewed by Maciej Stachowiak.
1023
1024         Add test suite for public suffix functions on Mac.
1025
1026         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1027         * TestWebKitAPI/Tests/mac/PublicSuffix.mm: Added.
1028         (TestWebKitAPI):
1029         (TestWebKitAPI::TEST_F):
1030
1031 2013-02-25  Dirk Pranke  <dpranke@chromium.org>
1032
1033         nrwt: reenable multiple http shards on chromium win
1034         https://bugs.webkit.org/show_bug.cgi?id=110814
1035
1036         Reviewed by Tony Chang.
1037
1038         The underlying bug in DumpRenderTree that was causing us to look for a
1039         pac file and timeout under load was fixed a while ago.
1040
1041         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1042         (ChromiumWinPort.relative_test_filename):
1043
1044 2013-02-25  Dirk Pranke  <dpranke@chromium.org>
1045
1046         Make ninja the default w/ build-webkit --chromium on windows.
1047         https://bugs.webkit.org/show_bug.cgi?id=110731
1048
1049         Unreviewed - TBR'ing thakis :).
1050
1051         * Scripts/update-webkit-chromium:
1052
1053 2013-02-25  Anders Carlsson  <andersca@apple.com>
1054
1055         Add a new pluginDidFail callback that takes a WKDictionary of plug-in information
1056         https://bugs.webkit.org/show_bug.cgi?id=110793
1057         <rdar://problem/13265303>
1058
1059         Reviewed by Sam Weinig.
1060
1061         Update for WebKit2 API changes.
1062
1063         * MiniBrowser/mac/WK2BrowserWindowController.m:
1064         (-[WK2BrowserWindowController awakeFromNib]):
1065         * WebKitTestRunner/TestController.cpp:
1066         (WTR::TestController::createWebViewWithOptions):
1067
1068 2013-02-25  Nico Weber  <thakis@chromium.org>
1069
1070         Fix python unit tests after yoli's email address update in http://trac.webkit.org/changeset/143922
1071         https://bugs.webkit.org/show_bug.cgi?id=110775
1072
1073         Unreviewed, basically a rebaseline.
1074
1075         * Scripts/webkitpy/common/config/watchlist:
1076
1077 2013-02-25  Nico Weber  <thakis@chromium.org>
1078
1079         [chromium] Try to get the webkit builder to use msvs again
1080         https://bugs.webkit.org/show_bug.cgi?id=110771
1081
1082         Reviewed by Eric Seidel.
1083
1084         The msvs gyp generator apparently doesn't write the sln file on every
1085         run, so check the vcxproj file instead.
1086
1087         * Scripts/webkitdirs.pm:
1088         (determineIsChromiumNinja):
1089
1090 2013-02-25  Nico Weber  <thakis@chromium.org>
1091
1092         [chromium] try to unbreak run-chromium-webkit-unit-tests on the mac bots
1093         https://bugs.webkit.org/show_bug.cgi?id=110767
1094
1095         Reviewed by Eric Seidel.
1096
1097         The tester runs gyp, which generates out/Release/build.ninja. The bot
1098         scripts use existence (and timestamp) of that file to decide if the
1099         current build is supposed to be ninja or xcodebuild. The file exists,
1100         so the snapshot is extracted to out/Release. The snapshot doesn't
1101         contain build.ninja however due to
1102         http://trac.webkit.org/changeset/140375 , so after extracting the
1103         snapshot the scripts think that this is an xcodebuild build. So remove
1104         the part of that revision that removed ninja files from the archive,
1105         and the bots should be happy again.
1106
1107         * BuildSlaveSupport/built-product-archive:
1108         (archiveBuiltProduct):
1109
1110 2013-02-25  Nico Weber  <thakis@chromium.org>
1111
1112         Fix tests after r143910
1113         https://bugs.webkit.org/show_bug.cgi?id=110757
1114
1115         Reviewed by Andreas Kling.
1116
1117         While here, also add a test for the bug r143910 fixed.
1118
1119         * Scripts/webkitpy/common/system/executive_unittest.py:
1120         (ScriptErrorTest.test_message_with_output):
1121         (ScriptErrorTest):
1122         (ScriptErrorTest.test_message_with_tuple):
1123
1124 2013-02-25  Nico Weber  <thakis@chromium.org>
1125
1126         [chromium] Apparently built-product-archive is written in Python, not Perl :-/
1127         https://bugs.webkit.org/show_bug.cgi?id=110755
1128
1129         Reviewed by Jochen Eisinger.
1130
1131         * BuildSlaveSupport/built-product-archive:
1132         (archiveBuiltProduct):
1133         (extractBuiltProduct):
1134
1135 2013-02-25  Sheriff Bot  <webkit.review.bot@gmail.com>
1136
1137         Unreviewed, rolling out r143895.
1138         http://trac.webkit.org/changeset/143895
1139         https://bugs.webkit.org/show_bug.cgi?id=110758
1140
1141         broke a bunch of tests (Requested by thakis__ on #webkit).
1142
1143         * Scripts/update-webkit-chromium:
1144
1145 2013-02-25  Andreas Kling  <akling@apple.com>
1146
1147         Unreviewed, fix simple mistake in r143903.
1148         <http://webkit.org/b/110746>
1149
1150         Reviewed by Andreas Kling.
1151
1152         Pass git revision, not svn revision, to git shell command.
1153
1154         * Scripts/webkitpy/common/checkout/scm/git.py:
1155         (Git.timestamp_of_latest_commit):
1156
1157 2013-02-25  Nico Weber  <thakis@chromium.org>
1158
1159         [chromium] Let built-product-archive log which directory it's archiving from and extracting to
1160         https://bugs.webkit.org/show_bug.cgi?id=110748
1161
1162         Reviewed by Jochen Eisinger.
1163
1164         One of the mac testers runs DRT from out/ but WebKitUnitTests from
1165         xcodebuild. I'm trying to understand what's going on.
1166
1167         * BuildSlaveSupport/built-product-archive:
1168         (archiveBuiltProduct):
1169         (extractBuiltProduct):
1170
1171 2013-02-23  Ilya Tikhonovsky  <loislo@chromium.org>
1172
1173         Web Inspector: Native Memory Instrumentation: replace String with const char* in MemoryObjectInfo
1174         https://bugs.webkit.org/show_bug.cgi?id=110599
1175
1176         Reviewed by Yury Semikhatsky.
1177
1178         Due to potentially dynamic nature of names and classNames we need to make a copy of the strings
1179         that were given us via MemoryInstrumentation calls.
1180         So I extended client api with registerString method that pushes the strings
1181         down to the serializer.
1182
1183         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
1184         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:
1185         (TestWebKitAPI::Helper::Helper):
1186         (Helper):
1187         (TestWebKitAPI::Helper::addNode):
1188         (TestWebKitAPI::TEST):
1189
1190 2013-02-25  Nico Weber  <thakis@chromium.org>
1191
1192         Make ScriptError not crash when args is a tuple
1193         https://bugs.webkit.org/show_bug.cgi?id=110747
1194
1195         Reviewed by Jochen Eisinger.
1196
1197         I'm trying to understand the error on
1198         http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29/builds/34563/steps/layout-test/logs/stdio
1199         better. I'll likely have to revert the ninja switch on windows, but
1200         having error reporting code that doesn't itself crash sounds like a
1201         good thing to have anyways.
1202
1203         The problem is that '%s' % (1, 2) errors out, and args is sometimes a
1204         tuple not a list.
1205
1206         * Scripts/run-chromium-webkit-unit-tests:
1207         * Scripts/webkitpy/common/system/executive.py:
1208         (ScriptError.__init__):
1209
1210 2013-02-25  Laszlo Gombos  <l.gombos@samsung.com>
1211
1212         [EFL] Align feature defaults
1213         https://bugs.webkit.org/show_bug.cgi?id=110715
1214
1215         Enable 3D_RENDERING in FeatureList.pm as it is enabled by default in
1216         OptionsEfl.cmake.
1217
1218         Reviewed by Gyuyoung Kim.
1219
1220         * Scripts/webkitperl/FeatureList.pm:
1221
1222 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
1223
1224         run-perf-tests reports wrong commit time
1225         https://bugs.webkit.org/show_bug.cgi?id=110746
1226
1227         Reviewed by Andreas Kling.
1228
1229         The bug was caused by running "svn info" on a subdirectory, which returns a timestamp
1230         of when the subdirectory was last modified.
1231
1232         Run "svn info -r <revision> <repository root>" instead. Specifying revision number is
1233         insufficient since running "svn log -r <revision>" on a partial checkout only returns
1234         an empty result if the revision didn't modify the subdirectory.
1235
1236         For git, there is no partial checkout, so we just need to pass in "-r" option to keep
1237         the interface compatible with svn.
1238
1239         * Scripts/webkitpy/common/checkout/scm/git.py:
1240         (Git.timestamp_of_latest_commit):
1241         * Scripts/webkitpy/common/checkout/scm/scm.py:
1242         (SCM.timestamp_of_latest_commit):
1243         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1244         (MockSCM.timestamp_of_latest_commit):
1245         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1246         (test_timestamp_of_latest_commit):
1247         * Scripts/webkitpy/common/checkout/scm/svn.py:
1248         (SVN.timestamp_of_latest_commit):
1249         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1250         (PerfTestsRunner._generate_results_dict):
1251
1252 2013-02-25  Jochen Eisinger  <jochen@chromium.org>
1253
1254         [chromium] move WebRuntimeFeatures configuration to TestRunner library
1255         https://bugs.webkit.org/show_bug.cgi?id=110712
1256
1257         Reviewed by Nico Weber.
1258
1259         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1260         (WebTestRunner::TestInterfaces::TestInterfaces):
1261         * DumpRenderTree/chromium/TestShell.cpp:
1262         (TestShell::TestShell):
1263
1264 2013-02-25  Nico Weber  <thakis@chromium.org>
1265
1266         Make ninja the default build system for build-webkit --chromium on windows
1267         https://bugs.webkit.org/show_bug.cgi?id=110731
1268
1269         Reviewed by Jochen Eisinger.
1270
1271         With http://crbug.com/169945 fixed, this should now work.
1272
1273         * Scripts/update-webkit-chromium:
1274
1275 2013-02-24  Gustavo Noronha Silva  <gns@gnome.org>
1276
1277         [GTK] GTK+ 2 build broken since GTK_API_VERSION_2 moved to autoconfig.h
1278         https://bugs.webkit.org/show_bug.cgi?id=110702
1279
1280         Reviewed by Martin Robinson.
1281
1282         * GtkLauncher/main.c: include autotoolsconfig.h.
1283         * Scripts/webkitpy/style/checker.py: make GtkLauncher/main.c exempt of
1284         the include ordering check, since it uses autotoolsconfig.h which needs to
1285         come first.
1286
1287 2013-02-24  Hajime Morrita  <morrita@google.com>
1288
1289         [Custom Elements] Implement bare-bone document.register()
1290         https://bugs.webkit.org/show_bug.cgi?id=100229
1291
1292         Reviewed by Adam Barth.
1293
1294         Added enableCustomDOMElements flag.
1295
1296         * DumpRenderTree/chromium/TestShell.cpp:
1297         (TestShell::TestShell):
1298
1299 2013-02-23  Mark Pilgrim  <pilgrim@chromium.org>
1300
1301         [Chromium] DumpRenderTree TestShell::initialize should take Platform* now that WebKitPlatformSupport is empty
1302         https://bugs.webkit.org/show_bug.cgi?id=110606
1303
1304         Reviewed by Adam Barth.
1305
1306         Part of a larger refactoring series; see tracking bug 82948.
1307
1308         * DumpRenderTree/DumpRenderTree.gypi:
1309         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1310         (WebKitSupportTestEnvironment::WebKitSupportTestEnvironment):
1311         (WebKitSupportTestEnvironment::mockPlatform):
1312         (WebKitSupportTestEnvironment):
1313         * DumpRenderTree/chromium/MockPlatform.cpp: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp.
1314         (MockPlatform::create):
1315         (MockPlatform::MockPlatform):
1316         (MockPlatform::~MockPlatform):
1317         (MockPlatform::setInterfaces):
1318         (MockPlatform::cryptographicallyRandomValues):
1319         (MockPlatform::createMediaStreamCenter):
1320         (MockPlatform::createRTCPeerConnectionHandler):
1321         * DumpRenderTree/chromium/MockPlatform.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h.
1322         (MockPlatform):
1323         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp: Removed.
1324         * DumpRenderTree/chromium/MockWebKitPlatformSupport.h: Removed.
1325         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1326         (WebTestDelegate):
1327         * DumpRenderTree/chromium/TestShell.cpp:
1328         (TestShell::initialize):
1329         * DumpRenderTree/chromium/TestShell.h:
1330         (TestShell):
1331
1332 2013-02-23  Ryosuke Niwa  <rniwa@webkit.org>
1333
1334         Chromium Windows Perf bot fix. Tolerate CR at the end of the line that contains the timestamp.
1335
1336         * Scripts/webkitpy/common/checkout/scm/svn.py:
1337         (SVN.timestamp_of_latest_commit):
1338
1339 2013-02-23  Jason Anderssen  <janderssen@gmail.com>
1340
1341         Move setAutofilled from TestRunner to WebCore
1342         https://bugs.webkit.org/show_bug.cgi?id=110521
1343
1344         Reviewed by Benjamin Poulain.
1345
1346         * DumpRenderTree/TestRunner.cpp:
1347         (TestRunner::staticFunctions):
1348         * DumpRenderTree/TestRunner.h:
1349         (TestRunner):
1350         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1351         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1352         (WebTestRunner::TestRunner::TestRunner):
1353         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1354         (TestRunner):
1355         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1356         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1357         * DumpRenderTree/mac/TestRunnerMac.mm:
1358         * DumpRenderTree/qt/TestRunnerQt.cpp:
1359         * DumpRenderTree/qt/TestRunnerQt.h:
1360         (TestRunnerQt):
1361         * DumpRenderTree/win/TestRunnerWin.cpp:
1362         * DumpRenderTree/wx/TestRunnerWx.cpp:
1363
1364 2013-02-22  Ryosuke Niwa  <rniwa@webkit.org>
1365
1366         Upload results to perf.webkit.org in addition to the one specified by --test-results-server
1367         https://bugs.webkit.org/show_bug.cgi?id=108577
1368
1369         Reviewed by Dirk Pranke.
1370
1371         Upload results to perf.webkit.org using new JSON format as well as the host specified by
1372         --test-results-server. The new format is needed to provide extra information perf.webkit.org
1373         need such as the subversion commit time and test URLs. This is a temporarily measure until
1374         we complete the transition and the old JSON format and the code to upload results to
1375         webkit-perf.appspot.com can be deleted.
1376
1377         This patch adds scm.timestamp_of_latest_commit to obtain the timestamp of the latest commit present
1378         in a svn checkout or a git clone. This information is embedded in JSON submitted to perf.webkit.org
1379         so that the app can sort performance test results based on the timestamp of the last commit.
1380
1381         It also changes the repository names returned by port objects to be properly capitalized
1382         human readable names such as WebKit instead of lowercased names such as webkit since these names
1383         are displayed on perf.webkit.org for humans. Several users of this feature has been updated
1384         to explicitly lowercase the names.
1385
1386
1387         * Scripts/webkitpy/common/checkout/scm/git.py:
1388         (Git.timestamp_of_latest_commit): Added. Obtains the timestamp of the last commit. Unfortunately,
1389         git's timestamp granularity is seconds so we're losing some information compared to using a regular
1390         subversion client. To make matters worse, git doesn't have any option to show ISO-format timestamp in
1391         UTC so we're going to manually fiddle with timezone.
1392
1393         * Scripts/webkitpy/common/checkout/scm/scm.py:
1394         (SCM.timestamp_of_latest_commit): Added.
1395
1396         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1397         (MockSCM.timestamp_of_latest_commit): Added.
1398
1399         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1400         (test_timestamp_of_latest_commit): Added a test for Git.timestamp_of_latest_commit.
1401
1402         * Scripts/webkitpy/common/checkout/scm/svn.py:
1403         (SVN.timestamp_of_latest_commit): Added. With svn, all we need to do is to use --xml option and parse
1404         the timestamp which is always in UTC.
1405
1406         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1407         (JSONResultsGeneratorBase._insert_generic_metadata): Lowercase the name. Note that the name
1408         'chromium' needs to be substituted by 'chrome' for historical reasons.
1409
1410         * Scripts/webkitpy/layout_tests/port/base.py:
1411         (Port.repository_paths): Return WebKit instead of webkit as noted above.
1412
1413         * Scripts/webkitpy/layout_tests/port/chromium.py:
1414         (ChromiumPort.repository_paths): Return Chromium instead of chromium as noted above.
1415
1416         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1417         (PerfTestsRunner.__init__): Store the current time in UTC as well as in local time.
1418         (PerfTestsRunner._collect_tests):
1419
1420         (PerfTestsRunner._generate_and_show_results): Retrieve both regular output and one for perf.webkit.org,
1421         and upload them appropriately.
1422
1423         (PerfTestsRunner._generate_results_dict): Store WebKit and Chromium revisions at which tests were ran
1424         in revisions_for_perf_webkit and construct an output for perf.webkit.org.
1425
1426         (PerfTestsRunner._datetime_in_ES5_compatible_iso_format): Added.
1427
1428         (PerfTestsRunner._merge_slave_config_json): Merge slave configuration files into both regular output
1429         and one for perf.webkit.org. Here, we prefix each key with "builder" for perf.webkit.org.
1430         e.g. "processor" would be renamed to "builderProcessor".
1431
1432         (PerfTestsRunner._generate_output_files):
1433
1434         (PerfTestsRunner._upload_json): Added a remote path as an argument since we upload JSONs to /api/report
1435         on perf.webkit.org whereas we upload it to /api/test/report on webkit-perf.appspot.com. Also added the code
1436         to parse response as JSON when possible since perf.webkit.org returns a JSON response as opposed to
1437         webkit-perf.appspot.com which spits out a plaintext response.
1438
1439         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1440         (MainTest._test_run_with_json_output.mock_upload_json): Tolerate perf.webkit.org/api/report for now.
1441         (MainTest._test_run_with_json_output): Store a UTC time as perftestrunner would do.
1442         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json): Added.
1443
1444         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1445         (MainTest.test_upload_json): Moved from itegrationtest.py since it really is a unit test. Also added test
1446         cases to parse JSON responses.
1447         (MainTest.test_upload_json.MockFileUploader): Refactored.
1448         (MainTest.test_upload_json.MockFileUploader.reset): Added.
1449         (MainTest.test_upload_json.MockFileUploader.__init__):
1450         (MainTest.test_upload_json.MockFileUploader.upload_single_text_file):
1451
1452 2013-02-22  Roger Fong  <roger_fong@apple.com>
1453
1454         Unreviewed. Update bot config for OpenSource bots to add two new Win7 Debug testers and get rid of WinXP Debug testers.
1455
1456         * BuildSlaveSupport/build.webkit.org-config/config.json:
1457
1458 2013-02-22  Dirk Pranke  <dpranke@chromium.org>
1459
1460         Unreviewed, rolling out r143794.
1461         http://trac.webkit.org/changeset/143794
1462         https://bugs.webkit.org/show_bug.cgi?id=110542
1463
1464         debug linux builds broken?
1465
1466         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1467
1468 2013-02-22  Dirk Pranke  <dpranke@chromium.org>
1469
1470         [chromium] enable the fixed version of freetype on linux
1471         https://bugs.webkit.org/show_bug.cgi?id=110542
1472
1473         Reviewed by Tony Chang.
1474
1475         Switch to building with a fixed version of FreeType for
1476         just DumpRenderTree. This allows us to share one version
1477         of pixel baselines for both Lucid and Precise, and run
1478         the layout tests in a stock Precise install (instead of a Lucid
1479         chroot). Going forward, this approach isolates us from os-level
1480         changes to the version of FreeType. Note that Chromium itself
1481         still uses the system FreeType and is unaffected by this change.
1482
1483         This setting can still be turned off (at compile/gyp-time) by
1484         manually setting use_custom_freetype=0.
1485
1486         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1487
1488 2013-02-22  Anders Carlsson  <andersca@apple.com>
1489
1490         Move pluginLoadPolicy to the page loader client
1491         https://bugs.webkit.org/show_bug.cgi?id=110635
1492
1493         Reviewed by Sam Weinig.
1494
1495         * MiniBrowser/mac/WK2BrowserWindowController.m:
1496         (-[WK2BrowserWindowController awakeFromNib]):
1497         * WebKitTestRunner/TestController.cpp:
1498         (WTR::TestController::createOtherPage):
1499         (WTR::TestController::createWebViewWithOptions):
1500
1501 2013-02-22  Kenneth Russell  <kbr@google.com>
1502
1503         Unreviewed. Changed gman's primary address for auto-complete in Bugzilla.
1504
1505         * Scripts/webkitpy/common/config/committers.py:
1506
1507 2013-02-22  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1508
1509         [WTR] Do not dump information about empty subframes.
1510         https://bugs.webkit.org/show_bug.cgi?id=110585
1511
1512         Reviewed by Simon Fraser.
1513
1514         Follow DumpRenderTree more closely by skipping empty frames
1515         (frames which have no document). We are not really interested in
1516         showing anything about them.
1517
1518         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1519         (WTR::dumpDescendantFramesText): Do not print subframe names when they
1520         have no associated Document.
1521
1522 2013-02-21  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1523
1524         [EFL][DRT] Do not dump empty frames.
1525         https://bugs.webkit.org/show_bug.cgi?id=110474
1526
1527         Reviewed by Kenneth Rohde Christiansen.
1528
1529         Follow the original Mac implementation more closely by skipping
1530         empty frames (frames which have no document). We are not really
1531         interested in showing anything about them.
1532
1533         * DumpRenderTree/efl/DumpRenderTree.cpp:
1534         (dumpFramesAsText):
1535
1536 2013-02-21  Dirk Pranke  <dpranke@chromium.org>
1537
1538         [chromium] support the lucid version of freetype on precise in DRT
1539         https://bugs.webkit.org/show_bug.cgi?id=107338
1540
1541         Reviewed by Tony Chang.
1542
1543         Modify the DRT build so that we can optionally link against
1544         a fixed version of Freetype2. This allows us to share pixel test
1545         results across multiple versions of Ubuntu without having to
1546         worry about differences in font rendering.
1547
1548         At the moment this feature is off by default. Eventually it will
1549         be on by default on linux.
1550
1551         Note that this only affects DRT; the regular Chromium binary
1552         (and, for now, content_shell) will still use the system version
1553         of Freetype.
1554
1555         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1556
1557 2013-02-21  Rouslan Solomakhin  <rouslan@chromium.org>
1558
1559         [Chromium] Remove the word "cheher" from the list of misspelled words
1560         https://bugs.webkit.org/show_bug.cgi?id=110447
1561
1562         Reviewed by Tony Chang.
1563
1564         Other platforms do not mark "cheher" as a misspelled word in layout tests.
1565         This change is to bring Chromium platform in line with the rest of the
1566         platforms.
1567
1568         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
1569         (WebTestRunner::MockSpellCheck::hasInCache): Changed "cheher" to "wellcome".
1570         (WebTestRunner::MockSpellCheck::fillSuggestionList): Removed "cheher" misspelling and "checker" suggestion.
1571         (WebTestRunner::MockSpellCheck::initializeIfNeeded): Removed "cheher" misspelling.
1572
1573 2013-02-21  Jochen Eisinger  <jochen@chromium.org>
1574
1575         [chromium] document WebTestDelegate and WebTestRunner interfaces
1576         https://bugs.webkit.org/show_bug.cgi?id=110472
1577
1578         Reviewed by Adam Barth.
1579
1580         Also remove the default implementation of the remaining WebTestDelegate
1581         methods now that all embedders provide this interface.
1582
1583         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1584         (WebTestDelegate):
1585         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1586         (WebTestRunner):
1587
1588 2013-02-19  Mark Hahnenberg  <mhahnenberg@apple.com>
1589
1590         Objective-C API: Need a way to use the Objective-C JavaScript API with WebKit
1591         https://bugs.webkit.org/show_bug.cgi?id=106059
1592
1593         Reviewed by Geoffrey Garen.
1594
1595         Added new tests for the WebKit API portion of the JSC Objective-C API.
1596
1597         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1598         * TestWebKitAPI/Tests/mac/JSContextBackForwardCache1.html: Added.
1599         * TestWebKitAPI/Tests/mac/JSContextBackForwardCache2.html: Added.
1600         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm: Added.
1601         (-[MyConsole log:]):
1602         (-[MyConsole printHelloWorld]):
1603         (-[MyConsole add:to:]):
1604         (-[DidCreateJavaScriptContextFrameLoadDelegate webView:didFinishLoadForFrame:]):
1605         (-[DidCreateJavaScriptContextFrameLoadDelegate webView:didCreateJavaScriptContext:forFrame:]):
1606         (TestWebKitAPI):
1607         (TestWebKitAPI::TEST):
1608
1609 2013-02-21  Stephen Chenney  <schenney@chromium.org>
1610
1611         Unreviewed, add myself as a reviewer
1612
1613         * Scripts/webkitpy/common/config/committers.py:
1614
1615 2013-02-21  Jer Noble  <jer.noble@apple.com>
1616
1617         Unreviewed; add myself to the Media watchlist and update my committers.py setting to Reviewer.
1618
1619         * Scripts/webkitpy/common/config/committers.py:
1620         * Scripts/webkitpy/common/config/watchlist:
1621
1622 2013-02-21  Martin Robinson  <mrobinson@igalia.com>
1623
1624         gtk/DumpRenderTree.cpp is missing <locale.h> include
1625         https://bugs.webkit.org/show_bug.cgi?id=109386
1626
1627         * DumpRenderTree/gtk/DumpRenderTree.cpp: Fix the WebKitGTK+ Mac build
1628         by include locale.h when we use setlocale.
1629
1630 2013-02-21  Martin Robinson  <mrobinson@igalia.com>
1631
1632         [GTK] Move feature overriding to the configure phase
1633         https://bugs.webkit.org/show_bug.cgi?id=110293
1634
1635         Reviewed by Gustavo Noronha Silva.
1636
1637         * Scripts/webkitdirs.pm:
1638         (runAutogenForAutotoolsProjectIfNecessary): Rename the feature file to
1639         WebKitFeatureOverrides.txt to better match the other filenames used in
1640         the new feature processing.
1641         * gtk/generate-feature-defines-files: Added. A script which takes as an argument
1642         the default features, overrides them with the contents of WebKitFeatureOverrrides.txt
1643         and writes WebKitFeatures.txt and WebKitFeatures.h.
1644         * gtk/override-feature-defines: Removed.
1645
1646 2013-02-21  Oswald Buddenhagen  <oswald.buddenhagen@digia.com>
1647
1648         [Qt] Remove obsolete DEPENDPATH assignment
1649
1650         Reviewed by Simon Hausmann
1651
1652         qmake now adds CONFIG+=depend_includepath by default, making manual
1653         DEPENDPATH setup unnecessary.
1654
1655         * qmake/mkspecs/features/default_post.prf:
1656
1657 2013-02-20  Vivek Galatage  <vivekg@webkit.org>
1658
1659         Unreviewed. Changing primary email id.
1660
1661         * Scripts/webkitpy/common/config/committers.py:
1662
1663 2013-02-14  James Robinson  <jamesr@chromium.org>
1664
1665         [chromium] Request WebLayerTreeView for DumpRenderTree via explicit testing path
1666         https://bugs.webkit.org/show_bug.cgi?id=109634
1667
1668         Reviewed by Adrienne Walker.
1669
1670         * DumpRenderTree/chromium/WebViewHost.cpp:
1671         (WebViewHost::createOutputSurface):
1672         (WebViewHost::initializeLayerTreeView):
1673
1674 2013-02-20  Martin Robinson  <mrobinson@igalia.com>
1675
1676         [GTK] Re-enable 3D CSS transforms when using build-webkit
1677         https://bugs.webkit.org/show_bug.cgi?id=110402
1678
1679         Reviewed by Xan Lopez.
1680
1681         * Scripts/webkitperl/FeatureList.pm: Enable 3D rendering by default
1682         when building WebKitGTK+.
1683
1684 2013-02-20  Roger Fong  <roger_fong@apple.com>
1685
1686         Get VS2010 Solution B&I ready.
1687         <rdar://problem/1322988>
1688
1689         Rubberstamped by Timothy Horton.
1690
1691         Add Production configurations.
1692
1693         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1694         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
1695         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props: Added.
1696         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props:
1697         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props: Added.
1698         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props:
1699         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
1700         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
1701         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props: Added.
1702         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props:
1703         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props: Added.
1704         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props:
1705         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
1706         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props: Added.
1707         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props:
1708         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1709         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props: Added.
1710         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props:
1711         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
1712         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1713         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props: Added.
1714         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props:
1715         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props: Added.
1716         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props:
1717         * win/record-memory/record-memory.vcxproj:
1718         * win/record-memory/record-memoryProduction.props: Added.
1719         * win/record-memory/record-memoryRelease.props:
1720
1721 2013-02-20  Dirk Schulze  <krit@webkit.org>
1722
1723         Enable CANVAS_PATH flag
1724         https://bugs.webkit.org/show_bug.cgi?id=108508
1725
1726         Reviewed by Simon Fraser.
1727
1728         Enable CANVAS_PATH flag on trunk.
1729
1730         * Scripts/webkitperl/FeatureList.pm:
1731
1732 2013-02-20  Tony Chang  <tony@chromium.org>
1733
1734         Parse author names with commas in ChangeLogs
1735         https://bugs.webkit.org/show_bug.cgi?id=110356
1736
1737         Reviewed by Dirk Pranke.
1738
1739         Paweł's name has a comma in it, which was confusing the ChangeLog parser.
1740
1741         * Scripts/webkitpy/common/checkout/changelog.py:
1742         (ChangeLogEntry): Move name splitting regexp into a constant.
1743         (ChangeLogEntry._parse_reviewer_text): Use _split_reviewer_names.
1744         (ChangeLogEntry._split_reviewer_names): Rename to be more specific.
1745         (ChangeLogEntry._split_author_names_with_emails): Rename to be more specific and require emails.
1746         (ChangeLogEntry._parse_author_text): Use _split_author_names_with_emails.
1747         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1748         (test_parse_authors): Test case with Paweł's name.
1749
1750 2013-02-15  Dirk Schulze  <krit@webkit.org>
1751
1752         [Chromium] Add runtime flag for CanvasPath
1753         https://bugs.webkit.org/show_bug.cgi?id=109997
1754
1755         Reviewed by Adam Barth.
1756
1757         Added runtime flag for Canvas Path. Enabled it by default for TestShell. Otherwise
1758         the constructor for Path on DOMWindow would never be activatable, since the script
1759         is running after creating the DOMWindow object.
1760
1761         * DumpRenderTree/chromium/TestShell.cpp:
1762         (TestShell::TestShell):
1763
1764 2013-02-20  Jochen Eisinger  <jochen@chromium.org>
1765
1766         [chromium] use a WebTestProxyBase pointer to identify the window we need the history for
1767         https://bugs.webkit.org/show_bug.cgi?id=110346
1768
1769         Reviewed by Adam Barth.
1770
1771         Using an index is very brittle, as the TestRunner API does not define
1772         any ordering of windows.
1773
1774         Also, make TestRunner::shouldDumpBackForwardList() so content shell can
1775         trigger the capturing in the browser process before generating the
1776         text dump.
1777
1778         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1779         (WebTestRunner):
1780         (WebTestRunner::WebTestDelegate::captureHistoryForWindow):
1781         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1782         (WebTestRunner):
1783         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1784         (TestRunner):
1785         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1786         (WebTestRunner::WebTestProxyBase::captureTree):
1787         * DumpRenderTree/chromium/WebViewHost.cpp:
1788         (WebViewHost::captureHistoryForWindow):
1789         * DumpRenderTree/chromium/WebViewHost.h:
1790         (WebViewHost):
1791
1792 2013-02-19  Rouslan Solomakhin  <rouslan@chromium.org>
1793
1794         [Chromium] Serve spellcheck suggestions for editing/spelling/spelling-changed-text.html from cache
1795         https://bugs.webkit.org/show_bug.cgi?id=109220
1796
1797         Reviewed by Tony Chang.
1798
1799         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
1800         (WebTestRunner::MockSpellCheck::hasInCache): Added a method to detect whether spellcheck results can be served from cache.
1801         (WebTestRunner):
1802         (WebTestRunner::MockSpellCheck::fillSuggestionList): Modified to suggest "checker" for the word "cheher".
1803         (WebTestRunner::MockSpellCheck::initializeIfNeeded): Modified to mark "cheher" as misspelling.
1804         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:
1805         (MockSpellCheck):
1806         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp:
1807         (WebTestRunner::SpellCheckClient::requestCheckingOfText): Modified to serve spellcheck suggestions from cache when possible.
1808
1809 2013-02-20  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1810
1811         [Gtk] HTML5 Media controls require a design refresh
1812         https://bugs.webkit.org/show_bug.cgi?id=83869
1813
1814         Reviewed by Philippe Normand.
1815
1816         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1817         (initializeGtkFontSettings): Added gnome as default icon theme for
1818         the DRT.
1819         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1820         (WTR::initializeGtkSettings): Added gnome as default icon theme for
1821         the WTR.
1822         * gtk/jhbuild.modules: Added gnome-icon-theme-symbolic as external
1823         dependency.
1824
1825 2013-02-20  Jochen Eisinger  <jochen@chromium.org>
1826
1827         [chromium] move most of the remaining mocks to TestRunner library
1828         https://bugs.webkit.org/show_bug.cgi?id=110217
1829
1830         Reviewed by Nico Weber.
1831
1832         While most of the functionality provided by these mocks is also
1833         available in the content module, there is no straight forward way to
1834         inject the mock results required for layout tests.
1835
1836         * DumpRenderTree/DumpRenderTree.gypi:
1837         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1838         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1839         (WebKit):
1840         (WebTestRunner):
1841         (WebTestRunner::WebTestProxy::geolocationClient):
1842         (WebTestRunner::WebTestProxy::speechInputController):
1843         (WebTestRunner::WebTestProxy::speechRecognizer):
1844         (WebTestRunner::WebTestProxy::deviceOrientationClient):
1845         (WebTestRunner::WebTestProxy::requestPointerLock):
1846         (WebTestRunner::WebTestProxy::requestPointerUnlock):
1847         (WebTestRunner::WebTestProxy::isPointerLocked):
1848         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechInputController.cpp.
1849         (WebTestRunner::MockWebSpeechInputController::MockWebSpeechInputController):
1850         (WebTestRunner):
1851         (WebTestRunner::MockWebSpeechInputController::~MockWebSpeechInputController):
1852         (WebTestRunner::MockWebSpeechInputController::setDelegate):
1853         (WebTestRunner::MockWebSpeechInputController::addMockRecognitionResult):
1854         (WebTestRunner::MockWebSpeechInputController::setDumpRect):
1855         (WebTestRunner::MockWebSpeechInputController::clearResults):
1856         (WebTestRunner::MockWebSpeechInputController::startRecognition):
1857         (WebTestRunner::MockWebSpeechInputController::cancelRecognition):
1858         (WebTestRunner::MockWebSpeechInputController::stopRecording):
1859         (WebTestRunner::MockWebSpeechInputController::speechTaskFired):
1860         (WebTestRunner::MockWebSpeechInputController::SpeechTask::SpeechTask):
1861         (WebTestRunner::MockWebSpeechInputController::SpeechTask::stop):
1862         (WebTestRunner::MockWebSpeechInputController::SpeechTask::runIfValid):
1863         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechInputController.h.
1864         (WebKit):
1865         (WebTestRunner):
1866         (MockWebSpeechInputController):
1867         (WebTestRunner::MockWebSpeechInputController::taskList):
1868         (SpeechTask):
1869         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp.
1870         (WebTestRunner::MockWebSpeechRecognizer::MockWebSpeechRecognizer):
1871         (WebTestRunner):
1872         (WebTestRunner::MockWebSpeechRecognizer::~MockWebSpeechRecognizer):
1873         (WebTestRunner::MockWebSpeechRecognizer::setDelegate):
1874         (WebTestRunner::MockWebSpeechRecognizer::start):
1875         (WebTestRunner::MockWebSpeechRecognizer::stop):
1876         (WebTestRunner::MockWebSpeechRecognizer::abort):
1877         (WebTestRunner::MockWebSpeechRecognizer::addMockResult):
1878         (WebTestRunner::MockWebSpeechRecognizer::setError):
1879         (WebTestRunner::MockWebSpeechRecognizer::startTaskQueue):
1880         (WebTestRunner::MockWebSpeechRecognizer::clearTaskQueue):
1881         (WebTestRunner::MockWebSpeechRecognizer::StepTask::runIfValid):
1882         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechRecognizer.h.
1883         (WebKit):
1884         (WebTestRunner):
1885         (MockWebSpeechRecognizer):
1886         (WebTestRunner::MockWebSpeechRecognizer::wasAborted):
1887         (WebTestRunner::MockWebSpeechRecognizer::client):
1888         (WebTestRunner::MockWebSpeechRecognizer::handle):
1889         (WebTestRunner::MockWebSpeechRecognizer::taskList):
1890         (Task):
1891         (WebTestRunner::MockWebSpeechRecognizer::Task::Task):
1892         (WebTestRunner::MockWebSpeechRecognizer::Task::~Task):
1893         (StepTask):
1894         (WebTestRunner::MockWebSpeechRecognizer::StepTask::StepTask):
1895         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1896         (WebTestRunner::TestInterfaces::TestInterfaces):
1897         (WebTestRunner::TestInterfaces::windowOpened):
1898         (WebTestRunner):
1899         (WebTestRunner::TestInterfaces::windowClosed):
1900         (WebTestRunner::TestInterfaces::windowList):
1901         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
1902         (TestInterfaces):
1903         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1904         (WebTestRunner::TestRunner::TestRunner):
1905         (WebTestRunner::TestRunner::reset):
1906         (WebTestRunner::TestRunner::requestPointerLock):
1907         (WebTestRunner):
1908         (WebTestRunner::TestRunner::requestPointerUnlock):
1909         (WebTestRunner::TestRunner::isPointerLocked):
1910         (WebTestRunner::TestRunner::didAcquirePointerLockInternal):
1911         (WebTestRunner::TestRunner::didNotAcquirePointerLockInternal):
1912         (WebTestRunner::TestRunner::didLosePointerLockInternal):
1913         (WebTestRunner::TestRunner::windowCount):
1914         (WebTestRunner::TestRunner::setMockDeviceOrientation):
1915         (WebTestRunner::TestRunner::numberOfPendingGeolocationPermissionRequests):
1916         (WebTestRunner::TestRunner::setGeolocationPermission):
1917         (WebTestRunner::TestRunner::setMockGeolocationPosition):
1918         (WebTestRunner::TestRunner::setMockGeolocationPositionUnavailableError):
1919         (WebTestRunner::TestRunner::addMockSpeechInputResult):
1920         (WebTestRunner::TestRunner::setMockSpeechInputDumpRect):
1921         (WebTestRunner::TestRunner::addMockSpeechRecognitionResult):
1922         (WebTestRunner::TestRunner::setMockSpeechRecognitionError):
1923         (WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted):
1924         (WebTestRunner::TestRunner::didAcquirePointerLock):
1925         (WebTestRunner::TestRunner::didNotAcquirePointerLock):
1926         (WebTestRunner::TestRunner::didLosePointerLock):
1927         (WebTestRunner::TestRunner::setPointerLockWillRespondAsynchronously):
1928         (WebTestRunner::TestRunner::setPointerLockWillFailSynchronously):
1929         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1930         (WebTestRunner):
1931         (TestRunner):
1932         (HostMethodTask):
1933         (WebTestRunner::TestRunner::HostMethodTask::HostMethodTask):
1934         (WebTestRunner::TestRunner::HostMethodTask::runIfValid):
1935         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1936         (WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
1937         (WebTestRunner::WebTestProxyBase::setInterfaces):
1938         (WebTestRunner::WebTestProxyBase::setDelegate):
1939         (WebTestRunner::WebTestProxyBase::reset):
1940         (WebTestRunner::WebTestProxyBase::captureTree):
1941         (WebTestRunner::WebTestProxyBase::geolocationClientMock):
1942         (WebTestRunner):
1943         (WebTestRunner::WebTestProxyBase::deviceOrientationClientMock):
1944         (WebTestRunner::WebTestProxyBase::speechInputControllerMock):
1945         (WebTestRunner::WebTestProxyBase::speechRecognizerMock):
1946         (WebTestRunner::WebTestProxyBase::geolocationClient):
1947         (WebTestRunner::WebTestProxyBase::speechInputController):
1948         (WebTestRunner::WebTestProxyBase::speechRecognizer):
1949         (WebTestRunner::WebTestProxyBase::deviceOrientationClient):
1950         (WebTestRunner::WebTestProxyBase::requestPointerLock):
1951         (WebTestRunner::WebTestProxyBase::requestPointerUnlock):
1952         (WebTestRunner::WebTestProxyBase::isPointerLocked):
1953         * DumpRenderTree/chromium/WebViewHost.cpp:
1954         (WebViewHost::reset):
1955         * DumpRenderTree/chromium/WebViewHost.h:
1956         (WebKit):
1957         (WebViewHost):
1958
1959 2013-02-20  Andras Becsi  <andras.becsi@digia.com>
1960
1961         [Qt] Make debug builds possible on 32bit Linux
1962         https://bugs.webkit.org/show_bug.cgi?id=110231
1963
1964         Reviewed by Tor Arne Vestbø.
1965
1966         Use the stabs format for debug builds to make the object files
1967         a bit smaller so that they can be linked on a 32bit system.
1968
1969         * qmake/mkspecs/features/unix/default_post.prf:
1970
1971 2013-02-20  Takashi Toyoshima  <toyoshim@chromium.org>
1972
1973         Unreviewed. Add myself to watch lists.
1974
1975         * Scripts/webkitpy/common/config/committers.py:
1976         * Scripts/webkitpy/common/config/watchlist:
1977
1978 2013-02-19  Joshua Bell  <jsbell@chromium.org>
1979
1980         Remove warning from run-bindings-tests
1981         https://bugs.webkit.org/show_bug.cgi?id=110285
1982
1983         Reviewed by Kentaro Hara.
1984
1985         Since wkrev.com/139331 run-bindings-tests has been harmlessly emitting
1986         "Unknown option: idlattributesfile". That option was removed from
1987         bindings/scripts/preprocess-idls.pl but was still being passed by
1988         the test script. Remove it.
1989
1990         * Scripts/webkitpy/bindings/main.py:
1991         (BindingsTests.generate_supplemental_dependency): Remove unused arg.
1992
1993 2013-02-19  Elliott Sprehn  <esprehn@chromium.org>
1994
1995         Unreviewed. Add myself to watch lists.
1996
1997         * Scripts/webkitpy/common/config/committers.py:
1998         * Scripts/webkitpy/common/config/watchlist:
1999
2000 2013-02-19  Hans Muller  <hmuller@adobe.com>
2001
2002         Unreviewed, corrected primary email.
2003
2004         * Scripts/webkitpy/common/config/committers.py:
2005
2006 2013-02-19  Hans Muller  <hmuller@adobe.com>
2007
2008         Unreviewed. Adding myself as a committer.
2009
2010         * Scripts/webkitpy/common/config/committers.py:
2011
2012 2013-02-19  Pravin D  <pravind@webkit.org>
2013
2014         Unreviewed, changing primary email.
2015
2016         * Scripts/webkitpy/common/config/committers.py:
2017
2018 2013-02-19  Alan Cutter  <alancutter@chromium.org>
2019
2020         REGRESSION: Sheriffbot is failing to process rollout requests
2021         https://bugs.webkit.org/show_bug.cgi?id=106945
2022
2023         Reviewed by Adam Barth.
2024
2025         Modified Sheriffbot build script to track the svn repo from git and add bot user details to the git repo config file.
2026         This resolves problems when Sheriffbot attempts to perform a rollout request.
2027
2028         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
2029         * EWSTools/configure-git-svn.sh: Copied from Tools/EWSTools/create-webkit-git.
2030         * EWSTools/configure-git-user.sh: Renamed from Tools/EWSTools/create-webkit-git.
2031
2032 2013-02-19  Claudio Saavedra  <csaavedra@igalia.com>
2033
2034         Unreviewed build fix.
2035
2036         * efl/jhbuild.modules:
2037         * gtk/jhbuild.modules:
2038
2039         Bump harfbuzz module to 0.9.7. See related bug 110145.
2040
2041 2013-02-19  Simon Hausmann  <simon.hausmann@digia.com>
2042
2043         [Qt] Skip the build with a warning if certain tools cannot be found in the PATH
2044         https://bugs.webkit.org/show_bug.cgi?id=110215
2045
2046         Reviewed by Tor Arne Vestbø.
2047
2048         Check that gperf, python, ruby, perl, bison and flex are in the PATH before
2049         continuing the build. Otherwise skip with an error message explaining which
2050         programs are missing from the build.
2051
2052         * qmake/mkspecs/features/configure.prf:
2053         * qmake/mkspecs/features/functions.prf:
2054
2055 2013-02-19  Sheriff Bot  <webkit.review.bot@gmail.com>
2056
2057         Unreviewed, rolling out r143319.
2058         http://trac.webkit.org/changeset/143319
2059         https://bugs.webkit.org/show_bug.cgi?id=110214
2060
2061         Causes build issues on win32 (Requested by carewolf on
2062         #webkit).
2063
2064         * qmake/mkspecs/features/features.pri:
2065
2066 2013-02-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2067
2068         [Qt] Enable MathML
2069         https://bugs.webkit.org/show_bug.cgi?id=110205
2070
2071         Reviewed by Simon Hausmann.
2072
2073         * qmake/mkspecs/features/features.pri:
2074
2075 2013-02-17  Andrei Bucur  <abucur@adobe.com>
2076
2077         Unreviewed. Adding myself as a committer.
2078
2079         * Scripts/webkitpy/common/config/committers.py:
2080
2081 2013-02-19  Hajime Morrita  <morrita@google.com>
2082
2083         Unreviewed, updated spelling of my name.
2084
2085         * Scripts/webkitpy/common/config/committers.py:
2086
2087 2013-02-18  Ilya Tikhonovsky  <loislo@chromium.org>
2088
2089         Unreviewed. Adjust expectations.
2090
2091         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:
2092         (TestWebKitAPI::TEST):
2093
2094 2013-02-18  Zan Dobersek  <zdobersek@igalia.com>
2095
2096         Unreviewed GTK gardening.
2097
2098         * Scripts/run-gtk-tests:
2099         (TestRunner): Skipped the ReloadPageAfterCrash unit test as it is flakily timing out.
2100
2101 2013-02-18  Adenilson Cavalcanti  <cavalcantii@gmail.com>
2102
2103         [Qt][WK2] Remove duped test name and append new test in project file
2104         https://bugs.webkit.org/show_bug.cgi?id=110117
2105
2106         A new WK2 API test has landed recently (ResizeWindowAfterCrash), this patch will
2107         add this test into the runnable test suite and remove a duped test in project file.
2108
2109         Reviewed by Jocelyn Turcotte.
2110
2111         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro:
2112
2113 2013-02-18  Jochen Eisinger  <jochen@chromium.org>
2114
2115         [chromium] remove log spew from dumpAllBackForwardLists
2116         https://bugs.webkit.org/show_bug.cgi?id=110108
2117
2118         Reviewed by Nico Weber.
2119
2120         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2121
2122 2013-02-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2123
2124         [EFL][WK2] Disable failing API tests
2125         https://bugs.webkit.org/show_bug.cgi?id=110081
2126
2127         Reviewed by Kenneth Rohde Christiansen.
2128
2129         Disable DOMWindowExtensionBasic WK2 test on EFL port as it times out.
2130
2131         * TestWebKitAPI/PlatformEfl.cmake:
2132
2133 2013-02-18  Simon Hausmann  <simon.hausmann@digia.com>
2134
2135         [Qt] Disable the build if certain configure checks fail
2136         https://bugs.webkit.org/show_bug.cgi?id=110094
2137
2138         Reviewed by Tor Arne Vestbø.
2139
2140         Allow for the build to be skipped (clear out SUBDIRS) if certain
2141         configure conditions aren't met.
2142
2143         * qmake/mkspecs/features/configure.prf:
2144
2145 2013-02-15  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2146
2147         [Qt][WK2] Support WK2 API tests
2148         https://bugs.webkit.org/show_bug.cgi?id=109843
2149
2150         Reviewed by Jocelyn Turcotte.
2151
2152         * TestWebKitAPI/DerivedSources.pri: Added.
2153         * TestWebKitAPI/InjectedBundle.pri: Added.
2154         * TestWebKitAPI/PlatformWebView.h:
2155         * TestWebKitAPI/TestWebKitAPI.pri:
2156         * TestWebKitAPI/TestWebKitAPI.pro:
2157         * TestWebKitAPI/Tests/JavaScriptCore/JavaScriptCore.pro: Added.
2158         * TestWebKitAPI/Tests/WTF/WTF.pro:
2159         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro: Added.
2160         * TestWebKitAPI/qt/PlatformUtilitiesQt.cpp:
2161         (TestWebKitAPI::Util::sleep):
2162         (TestWebKitAPI::Util::createInjectedBundlePath):
2163         (TestWebKitAPI::Util::createURLForResource):
2164         (TestWebKitAPI::Util::isKeyDown):
2165         (Util):
2166         * TestWebKitAPI/qt/PlatformWebViewQt.cpp: Added.
2167         (TestWebKitAPI):
2168         (WrapperWindow):
2169         (TestWebKitAPI::WrapperWindow::WrapperWindow):
2170         (TestWebKitAPI::WrapperWindow::handleStatusChanged):
2171         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2172         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2173         (TestWebKitAPI::PlatformWebView::resizeTo):
2174         (TestWebKitAPI::PlatformWebView::page):
2175         (TestWebKitAPI::PlatformWebView::focus):
2176         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
2177         (TestWebKitAPI::PlatformWebView::simulateAltKeyPress):
2178         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
2179         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2180         * TestWebKitAPI/qt/main.cpp:
2181         (addQtWebProcessToPath):
2182         (main):
2183
2184 2013-02-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2185
2186         [EFL][WK2] Refactor Ewk_Favicon code and stop relying on internal C++ API
2187         https://bugs.webkit.org/show_bug.cgi?id=108598
2188
2189         Reviewed by Kenneth Rohde Christiansen.
2190
2191         Update EFL's MiniBrowser to make use of new Ewk_Favicon API.
2192
2193         * MiniBrowser/efl/main.c:
2194         (update_view_favicon):
2195         (on_view_favicon_changed):
2196         (window_create):
2197
2198 2013-02-18  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
2199
2200         Unreviewed. Add myself as a committer.
2201
2202         * Scripts/webkitpy/common/config/committers.py:
2203
2204 2013-02-13  Ilya Tikhonovsky  <loislo@chromium.org>
2205
2206         Web Inspector: Native Memory Instrumentation: reportLeaf method doesn't report the leaf node properly.
2207         https://bugs.webkit.org/show_bug.cgi?id=109554
2208
2209         In some cases leaves have no pointer so with the old schema we can't generate nodeId for them because we
2210         can't insert 0 into hashmap. It happens when we call addPrivateBuffer method.
2211
2212         Drive by fix: I introduced a client interface for the HeapGraphSerializer.
2213         It helps me to do the tests for the serializer.
2214
2215         Reviewed by Yury Semikhatsky.
2216
2217         It is covered by newly added tests in TestWebKitAPI.
2218
2219         * TestWebKitAPI/TestWebKitAPI.gypi:
2220         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Added.
2221         (TestWebKitAPI):
2222         (HeapGraphReceiver):
2223         (TestWebKitAPI::HeapGraphReceiver::HeapGraphReceiver):
2224         (TestWebKitAPI::HeapGraphReceiver::printGraph):
2225         (TestWebKitAPI::HeapGraphReceiver::dumpNodes):
2226         (TestWebKitAPI::HeapGraphReceiver::dumpEdges):
2227         (TestWebKitAPI::HeapGraphReceiver::dumpBaseToRealNodeId):
2228         (TestWebKitAPI::HeapGraphReceiver::dumpStrings):
2229         (TestWebKitAPI::HeapGraphReceiver::serializer):
2230         (TestWebKitAPI::HeapGraphReceiver::chunkPart):
2231         (TestWebKitAPI::HeapGraphReceiver::dumpPart):
2232         (TestWebKitAPI::HeapGraphReceiver::stringValue):
2233         (TestWebKitAPI::HeapGraphReceiver::intValue):
2234         (TestWebKitAPI::HeapGraphReceiver::nodeToString):
2235         (TestWebKitAPI::HeapGraphReceiver::edgeToString):
2236         (TestWebKitAPI::HeapGraphReceiver::printNode):
2237         (Helper):
2238         (TestWebKitAPI::Helper::Helper):
2239         (TestWebKitAPI::Helper::addNode):
2240         (TestWebKitAPI::Helper::addEdge):
2241         (TestWebKitAPI::Helper::done):
2242         (Object):
2243         (TestWebKitAPI::Helper::Object::Object):
2244         (TestWebKitAPI::TEST):
2245         (Owner):
2246         (TestWebKitAPI::Owner::Owner):
2247         (TestWebKitAPI::Owner::reportMemoryUsage):
2248
2249 2013-02-18  Ryosuke Niwa  <rniwa@webkit.org>
2250
2251         WKR build fix. Always use ascii since irclib/ircbot doesn't support unicode.
2252
2253         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2254         (NewCommitBot.next_work_item):
2255
2256 2013-02-17  Kangil Han  <kangil.han@samsung.com>
2257
2258         Unreviewed. Add myself as a committer.
2259
2260         * Scripts/webkitpy/common/config/committers.py:
2261
2262 2013-02-17  Alan Cutter  <alancutter@chromium.org>
2263
2264         GCE EWS bots are all offline
2265         https://bugs.webkit.org/show_bug.cgi?id=110069
2266
2267         Reviewed by Eric Seidel.
2268
2269         Updated GCE EWS build scripts to use the gcel-10-04-v20130104 image instead of the obsoleted ubuntu-10-04-v20120621.
2270         This changed the ephemeral disk path to /dev/sdb and required /etc/hosts to be chmodded to 644.
2271
2272         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
2273         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
2274         * EWSTools/GoogleComputeEngine/build-cr-linux-debug-ews.sh:
2275         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
2276         * EWSTools/build-vm.sh:
2277         * EWSTools/start-queue.sh:
2278
2279 2013-02-18  Eugene Klyuchnikov  <eustas@chromium.org>
2280
2281         Unreviewed, add myself to commiters.py.
2282
2283         * Scripts/webkitpy/common/config/committers.py:
2284
2285 2013-02-17  Dongwoo Joshua Im  <dw.im@samsung.com>
2286
2287         Unreviewed. Add myself as a committer.
2288
2289         * Scripts/webkitpy/common/config/committers.py:
2290
2291 2013-02-17  Roger Fong  <roger_fong@apple.com>
2292
2293         Unreviewed. Fix typo in script.
2294
2295         * EWSTools/start-queue-win.sh:
2296
2297 2013-02-15  Roger Fong  <roger_fong@apple.com>
2298
2299         Pass in bot name as parameter to start-queue-win script.
2300         https://bugs.webkit.org/show_bug.cgi?id=109998.
2301
2302         Reviewed by Darin Adler.
2303
2304         * EWSTools/start-queue-win.sh:
2305
2306 2013-02-18  Byungwoo Lee  <bw80.lee@samsung.com>
2307
2308         Unreviewed. Add myself as a committer.
2309
2310         * Scripts/webkitpy/common/config/committers.py:
2311
2312 2013-02-17  Ryosuke Niwa  <rniwa@webkit.org>
2313
2314         Rename new-commit-bot to WKR to disambiguate it from commit-queue.
2315
2316         Rubber-stamped by Andreas Kling.
2317
2318         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2319         (NewCommitBot.begin_work_queue):
2320
2321 2013-02-16  Glenn Adams  <glenn@skynav.com>
2322
2323         Unreviewed. Add myself as a committer.
2324
2325         * Scripts/webkitpy/common/config/committers.py:
2326
2327 2013-02-16  Ryosuke Niwa  <rniwa@webkit.org>
2328
2329         new-commit-bot should report the full name of committer and reviewer instead of just nicks
2330         https://bugs.webkit.org/show_bug.cgi?id=110040
2331
2332         Reviewed by Darin Adler.
2333
2334         Have it report names like "Ryosuke Niwa (rniwa)" instead of just "rniwa".
2335
2336         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2337         (NewCommitBot):
2338         (NewCommitBot._summarize_commit_log):
2339         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
2340
2341 2013-02-16  Ryosuke Niwa  <rniwa@webkit.org>
2342
2343         We need a CIA replacement
2344         https://bugs.webkit.org/show_bug.cgi?id=110008
2345
2346         Reviewed by Andreas Kling.
2347
2348         Added new-commit-bot.
2349
2350         * Scripts/webkitpy/tool/bot/queueengine.py:
2351         (QueueEngine.__init__):
2352         (QueueEngine): Made the sleep tiem configurable.
2353         (QueueEngine._sleep_message):
2354         (QueueEngine._sleep):
2355         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2356         (QueueEngineTest.test_sleep_message):
2357         * Scripts/webkitpy/tool/commands/__init__.py:
2358         * Scripts/webkitpy/tool/commands/newcommitbot.py: Added.
2359         (PingPong): Added. Implements the ping pong protocol.
2360         (NewCommitBot):
2361         (NewCommitBot.begin_work_queue):
2362         (NewCommitBot.work_item_log_path):
2363         (NewCommitBot.next_work_item): Update SVN revision and report any new commits made since
2364         the last time we checked the head SVN revision.
2365         (NewCommitBot.process_work_item):
2366         (NewCommitBot._update_checkout): svn up.
2367         (NewCommitBot._new_svn_revisions): Returns a range of new revisions.
2368         (NewCommitBot._summarize_commit_log): Summarize a commit log to be posted on IRC.
2369         (NewCommitBot.handle_unexpected_error):
2370         (NewCommitBot.handle_script_error):
2371         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Added.
2372         (NewCommitBotTest.test_summarize_commit_log_basic): Tests for summarizing non-rollout commits.
2373         (NewCommitBotTest.test_summarize_commit_log_rollout): Tests for summarizing rollouts.
2374         * Scripts/webkitpy/tool/commands/queues.py:
2375         (AbstractQueue.execute):
2376         * Scripts/webkitpy/tool/commands/queuestest.py:
2377         (MockQueueEngine.__init__):
2378         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2379         (SheriffBotTest.test_command_aliases):
2380         * Scripts/webkitpy/tool/main.py:
2381         (WebKitPatch):
2382
2383 2013-02-16  Jochen Eisinger  <jochen@chromium.org>
2384
2385         [chromium] initialize all variables of TestRunner classes
2386         https://bugs.webkit.org/show_bug.cgi?id=110013
2387
2388         Reviewed by Adam Barth.
2389
2390         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2391         (WebTestRunner::TestInterfaces::TestInterfaces):
2392         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2393         (WebTestRunner::TestRunner::TestRunner):
2394
2395 2013-02-16  Jochen Eisinger  <jochen@chromium.org>
2396
2397         [chromium] destroy the TestPlugin when the destroy() method is invoked.
2398         https://bugs.webkit.org/show_bug.cgi?id=110012
2399
2400         Reviewed by Adam Barth.
2401
2402         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
2403         (WebTestRunner::TestPlugin::destroy):
2404
2405 2013-02-15  Adenilson Cavalcanti  <cavalcantii@gmail.com>
2406
2407         [WK2] Write a test to simulate crashed WebProcess followed by Window resize
2408         https://bugs.webkit.org/show_bug.cgi?id=109842
2409
2410         Reviewed by Benjamin Poulain.
2411
2412         This new test will kill WebProcess, followed by next resizing the Window. It helps to
2413         identify if the port is testing for WebPageProxy data members state (e.g. DrawingArea, Frames)
2414         before making calls into them.
2415
2416         * TestWebKitAPI/GNUmakefile.am:
2417         * TestWebKitAPI/PlatformEfl.cmake:
2418         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2419         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp: Added.
2420         (TestWebKitAPI):
2421         (TestWebKitAPI::didFinishLoad):
2422         (TestWebKitAPI::didCrash):
2423         (TestWebKitAPI::TEST):
2424
2425 2013-02-15  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2426
2427         Add CString operators for comparison with const char*
2428         https://bugs.webkit.org/show_bug.cgi?id=109947
2429
2430         Reviewed by Darin Adler.
2431
2432         Add tests for WTF::CString's comparison operators.
2433
2434         * TestWebKitAPI/Tests/WTF/CString.cpp:
2435         (TEST):
2436
2437 2013-02-15  Zan Dobersek  <zdobersek@igalia.com>
2438
2439         webkit-patch suggest-reviewers should limit itself to 5 reviewers
2440         https://bugs.webkit.org/show_bug.cgi?id=107528
2441
2442         Reviewed by Eric Seidel.
2443
2444         * Scripts/webkitpy/common/checkout/checkout.py:
2445         (Checkout.suggested_reviewers): Iterate through the sorted commit info list,
2446         scraping reviewers from the commit information and in the end producing a list
2447         of reviewers that's sorted from the most to least recent activity of any reviewer
2448         that has reviewed or authored patches for the changed files.
2449         * Scripts/webkitpy/tool/commands/queries.py:
2450         (SuggestReviewers): Use the SuggestReviewers step instead of reimplementing much of
2451         the same logic.
2452         (SuggestReviewers._prepare_state): Force the reviewer suggestion because the option
2453         defaults to False.
2454         * Scripts/webkitpy/tool/steps/suggestreviewers.py:
2455         (SuggestReviewers.run): Only list the first five suggested reviewers, now printed out
2456         on a single line.  Only ask for CC-ing the suggested reviewers to the bug if the
2457         bug ID is located in the command's state.
2458
2459 2013-02-15  Pablo Flouret  <pablof@motorola.com>
2460
2461         Unreviewed. Add myself as a committer.
2462
2463         * Scripts/webkitpy/common/config/committers.py:
2464
2465 2013-02-15  Roger Fong  <roger_fong@apple.com>
2466
2467         Get Win EWS startup script checked into tree so we can make changes to all the EWS bots more easily.
2468
2469         * EWSTools/start-queue-win.sh: Added.
2470
2471 2013-02-15  Andreas Kling  <akling@apple.com>
2472
2473         Unbreak webkit-patch -- can't have both Committer and Contributor entry with same e-mail address.
2474
2475         * Scripts/webkitpy/common/config/committers.py:
2476
2477 2013-02-15  Joanmarie Diggs  <jdiggs@igalia.com>
2478
2479         Unreviewed. Add myself as a committer.
2480
2481         * Scripts/webkitpy/common/config/committers.py:
2482
2483 2013-02-15  Ryosuke Niwa  <rniwa@webkit.org>
2484
2485         NRWT: ML Debug Test bot is timing out after cleaning up ports
2486         https://bugs.webkit.org/show_bug.cgi?id=109912
2487
2488         Reviewed by Simon Fraser.
2489
2490         Added more debug messgaes to diagnose the issue.
2491
2492         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2493         (Manager.run):
2494
2495 2013-02-15  Claudio Saavedra  <csaavedra@igalia.com>
2496
2497         Unreviewed. Add myself as a committer.
2498
2499         * Scripts/webkitpy/common/config/committers.py:
2500
2501 2013-02-15  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2502
2503         Unreviewed. Update Yi Shen, Antonio Gomes and Laszlo Gombos'
2504         emails on their behalf.
2505
2506         * Scripts/webkitpy/common/config/committers.py:
2507
2508 2013-02-15  Andrey Lushnikov  <lushnikov@chromium.org>
2509
2510         Web Inspector: implement smart braces functionality
2511         https://bugs.webkit.org/show_bug.cgi?id=109200
2512
2513         Reviewed by Pavel Feldman.
2514
2515         Fix eventSender.keyDown implementation to correctly process opening
2516         round brace symbol.
2517
2518         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
2519         (WebTestRunner):
2520         (WebTestRunner::EventSender::keyDown):
2521
2522 2013-02-15  Jochen Eisinger  <jochen@chromium.org>
2523
2524         Speculative build fix for chromium-win.
2525
2526         Unreviewed build fix.
2527
2528         Add declarations of the copy constructor and assignment operator to
2529         WebTestProxyBase, so VS doesn't try to generate them.
2530
2531         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2532
2533 2013-02-15  Simon Hausmann  <simon.hausmann@digia.com>
2534
2535         [Qt] Port GCController to JSC C API
2536         https://bugs.webkit.org/show_bug.cgi?id=109690
2537
2538         Reviewed by Benjamin Poulain.
2539
2540         Rename TestRunner to TestRunnerQt to avoid conflict when
2541         including TestRunner.h in the future.
2542
2543         Replaced QObject based GCController implementation with JSC C API
2544         based one.
2545
2546         * DumpRenderTree/qt/DumpRenderTree.pro:
2547         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2548         (WebCore::DumpRenderTree::DumpRenderTree):
2549         (WebCore::DumpRenderTree::open):
2550         (WebCore::DumpRenderTree::initJSObjects):
2551         (WebCore::methodNameStringForFailedTest):
2552         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2553         (WebCore::DumpRenderTree::testRunner):
2554         (DumpRenderTree):
2555         * DumpRenderTree/qt/GCControllerQt.cpp:
2556         (GCController::getJSObjectCount):
2557         * DumpRenderTree/qt/GCControllerQt.h: Removed.
2558         * DumpRenderTree/qt/TestRunnerQt.cpp:
2559         (TestRunnerQt::TestRunnerQt):
2560         (TestRunnerQt::reset):
2561         (TestRunnerQt::dumpNotifications):
2562         (TestRunnerQt::processWork):
2563         (TestRunnerQt::maybeDump):
2564         (TestRunnerQt::dumpAsText):
2565         (TestRunnerQt::waitUntilDone):
2566         (TestRunnerQt::setViewModeMediaFeature):
2567         (TestRunnerQt::webHistoryItemCount):
2568         (TestRunnerQt::keepWebHistory):
2569         (TestRunnerQt::notifyDone):
2570         (TestRunnerQt::windowCount):
2571         (TestRunnerQt::grantWebNotificationPermission):
2572         (TestRunnerQt::ignoreLegacyWebNotificationPermissionRequests):
2573         (TestRunnerQt::denyWebNotificationPermission):
2574         (TestRunnerQt::removeAllWebNotificationPermissions):
2575         (TestRunnerQt::simulateWebNotificationClick):
2576         (TestRunnerQt::simulateLegacyWebNotificationClick):
2577         (TestRunnerQt::display):
2578         (TestRunnerQt::displayInvalidatedRegion):
2579         (TestRunnerQt::clearBackForwardList):
2580         (TestRunnerQt::pathToLocalResource):
2581         (TestRunnerQt::dumpEditingCallbacks):
2582         (TestRunnerQt::dumpFrameLoadCallbacks):
2583         (TestRunnerQt::dumpProgressFinishedCallback):
2584         (TestRunnerQt::dumpUserGestureInFrameLoadCallbacks):
2585         (TestRunnerQt::dumpResourceLoadCallbacks):
2586         (TestRunnerQt::dumpResourceResponseMIMETypes):
2587         (TestRunnerQt::dumpWillCacheResponse):
2588         (TestRunnerQt::dumpHistoryCallbacks):
2589         (TestRunnerQt::setWillSendRequestReturnsNullOnRedirect):
2590         (TestRunnerQt::setWillSendRequestReturnsNull):
2591         (TestRunnerQt::setWillSendRequestClearHeader):
2592         (TestRunnerQt::setDeferMainResourceDataLoad):
2593         (TestRunnerQt::queueBackNavigation):
2594         (TestRunnerQt::queueForwardNavigation):
2595         (TestRunnerQt::queueLoad):
2596         (TestRunnerQt::queueLoadHTMLString):
2597         (TestRunnerQt::queueReload):
2598         (TestRunnerQt::queueLoadingScript):
2599         (TestRunnerQt::queueNonLoadingScript):
2600         (TestRunnerQt::provisionalLoad):
2601         (TestRunnerQt::timerEvent):
2602         (TestRunnerQt::encodeHostName):
2603         (TestRunnerQt::decodeHostName):
2604         (TestRunnerQt::closeWebInspector):
2605         (TestRunnerQt::setDeveloperExtrasEnabled):
2606         (TestRunnerQt::setAsynchronousSpellCheckingEnabled):
2607         (TestRunnerQt::showWebInspector):
2608         (TestRunnerQt::evaluateInWebInspector):
2609         (TestRunnerQt::goBack):
2610         (TestRunnerQt::setDefersLoading):
2611         (TestRunnerQt::setAllowUniversalAccessFromFileURLs):
2612         (TestRunnerQt::setAllowFileAccessFromFileURLs):
2613         (TestRunnerQt::setAppCacheMaximumSize):
2614         (TestRunnerQt::setAutofilled):
2615         (TestRunnerQt::setValueForUser):
2616         (TestRunnerQt::setFixedContentsSize):
2617         (TestRunnerQt::setPrivateBrowsingEnabled):
2618         (TestRunnerQt::setSpatialNavigationEnabled):
2619         (TestRunnerQt::setPopupBlockingEnabled):
2620         (TestRunnerQt::setPluginsEnabled):
2621         (TestRunnerQt::setPOSIXLocale):
2622         (TestRunnerQt::setWindowIsKey):
2623         (TestRunnerQt::setMainFrameIsFirstResponder):
2624         (TestRunnerQt::setJavaScriptCanAccessClipboard):
2625         (TestRunnerQt::setXSSAuditorEnabled):
2626         (TestRunnerQt::dispatchPendingLoadRequests):
2627         (TestRunnerQt::clearAllApplicationCaches):
2628         (TestRunnerQt::clearApplicationCacheForOrigin):
2629         (TestRunnerQt::localStorageDiskUsageForOrigin):
2630         (TestRunnerQt::setApplicationCacheOriginQuota):
2631         (TestRunnerQt::applicationCacheDiskUsageForOrigin):
2632         (TestRunnerQt::originsWithApplicationCache):
2633         (TestRunnerQt::setCacheModel):
2634         (TestRunnerQt::setDatabaseQuota):
2635         (TestRunnerQt::clearAllDatabases):
2636         (TestRunnerQt::addOriginAccessWhitelistEntry):
2637         (TestRunnerQt::removeOriginAccessWhitelistEntry):
2638         (TestRunnerQt::setCustomPolicyDelegate):
2639         (TestRunnerQt::waitForPolicyDelegate):
2640         (TestRunnerQt::overridePreference):
2641         (TestRunnerQt::setUserStyleSheetLocation):
2642         (TestRunnerQt::setCaretBrowsingEnabled):
2643         (TestRunnerQt::setAuthorAndUserStylesEnabled):
2644         (TestRunnerQt::setUserStyleSheetEnabled):
2645         (TestRunnerQt::setDomainRelaxationForbiddenForURLScheme):
2646         (TestRunnerQt::callShouldCloseOnWebView):
2647         (TestRunnerQt::setScrollbarPolicy):
2648         (TestRunnerQt::setSmartInsertDeleteEnabled):
2649         (TestRunnerQt::setSelectTrailingWhitespaceEnabled):
2650         (TestRunnerQt::execCommand):
2651         (TestRunnerQt::isCommandEnabled):
2652         (TestRunnerQt::findString):
2653         (TestRunnerQt::markerTextForListItem):
2654         (TestRunnerQt::computedStyleIncludingVisitedInfo):
2655         (TestRunnerQt::elementDoesAutoCompleteForElementWithId):
2656         (TestRunnerQt::authenticateSession):
2657         (TestRunnerQt::setIconDatabaseEnabled):
2658         (TestRunnerQt::setMockDeviceOrientation):
2659         (TestRunnerQt::setGeolocationPermission):
2660         (TestRunnerQt::numberOfPendingGeolocationPermissionRequests):
2661         (TestRunnerQt::setGeolocationPermissionCommon):
2662         (TestRunnerQt::setMockGeolocationPositionUnavailableError):
2663         (TestRunnerQt::setMockGeolocationPosition):
2664         (TestRunnerQt::addMockSpeechInputResult):
2665         (TestRunnerQt::setMockSpeechInputDumpRect):
2666         (TestRunnerQt::startSpeechInput):
2667         (TestRunnerQt::evaluateScriptInIsolatedWorldAndReturnValue):
2668         (TestRunnerQt::evaluateScriptInIsolatedWorld):
2669         (TestRunnerQt::addUserStyleSheet):
2670         (TestRunnerQt::removeAllVisitedLinks):
2671         (TestRunnerQt::addURLToRedirect):
2672         (TestRunnerQt::originsWithLocalStorage):
2673         (TestRunnerQt::deleteAllLocalStorage):
2674         (TestRunnerQt::deleteLocalStorageForOrigin):
2675         (TestRunnerQt::observeStorageTrackerNotifications):
2676         (TestRunnerQt::syncLocalStorage):
2677         (TestRunnerQt::resetPageVisibility):
2678         (TestRunnerQt::setPageVisibility):
2679         (TestRunnerQt::setAutomaticLinkDetectionEnabled):
2680         (TestRunnerQt::setTextDirection):
2681         (TestRunnerQt::setAlwaysAcceptCookies):
2682         (TestRunnerQt::setAlwaysBlockCookies):
2683         (TestRunnerQt::setAudioData):
2684         * DumpRenderTree/qt/TestRunnerQt.h:
2685         (TestRunnerQt):
2686
2687 2013-02-14  Karen Grunberg  <kareng@chromium.org>
2688
2689         adding myself as a committer
2690
2691         * Scripts/webkitpy/common/config/committers.py:
2692
2693 2013-02-14  Glenn Adams  <glenn@skynav.com>
2694
2695         new-run-webkit-tests needs a shared TestExpectations between all WebKit ports
2696         https://bugs.webkit.org/show_bug.cgi?id=37565
2697
2698         Introduce generic TestExpectations file that applies as a fallback for all ports, the location of which
2699         is LayoutTests/TestExpectations.
2700
2701         Reviewed by Dirk Pranke.
2702
2703         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
2704         (FakePort.path_to_generic_test_expectations_file):
2705         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2706         (TestExpectations.__init__):
2707         * Scripts/webkitpy/layout_tests/port/base.py:
2708         (Port.path_to_generic_test_expectations_file):
2709         (Port):
2710         (Port._port_specific_expectations_files):
2711         (Port.expectations_files):
2712         * Scripts/webkitpy/layout_tests/port/chromium.py:
2713         (ChromiumPort._port_specific_expectations_files):
2714         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2715         (ChromiumAndroidPort._port_specific_expectations_files):
2716         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
2717         (ChromiumPortTestCase.test_expectations_files):
2718         * Scripts/webkitpy/layout_tests/port/efl.py:
2719         (EflPort._port_specific_expectations_files):
2720         * Scripts/webkitpy/layout_tests/port/gtk.py:
2721         (GtkPort._port_specific_expectations_files):
2722         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2723         (GtkPortTest.test_expectations_files):
2724         * Scripts/webkitpy/layout_tests/port/mac.py:
2725         (MacPort._port_specific_expectations_files):
2726         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2727         (PortTestCase.test_expectations_ordering):
2728         (test_expectations_files):
2729         * Scripts/webkitpy/layout_tests/port/qt.py:
2730         (QtPort._port_specific_expectations_files):
2731         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2732         (QtPortTest.test_expectations_files):
2733         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2734         (WinPortTest.test_expectations_files):
2735         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2736         (PrintExpectationsTest.test_paths):
2737         * Scripts/webkitpy/tool/commands/rebaseline.py:
2738         (RebaselineTest._update_expectations_file):
2739
2740 2013-02-14  Jochen Eisinger  <jochen@chromium.org>
2741
2742         [chromium] move pixel generation logic to TestRunner library
2743         https://bugs.webkit.org/show_bug.cgi?id=109686
2744
2745         Reviewed by Stephen White.
2746
2747         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2748         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2749         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2750         (WebTestRunner):
2751         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2752         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2753         (WebTestRunner):
2754         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2755         (WebTestRunner::TestInterfaces::~TestInterfaces):
2756         (WebTestRunner::TestInterfaces::setWebView):
2757         (WebTestRunner::TestInterfaces::proxy):
2758         (WebTestRunner):
2759         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2760         (WebTestRunner):
2761         (TestInterfaces):
2762         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2763         (WebTestRunner::TestRunner::setWebView):
2764         (WebTestRunner):
2765         (WebTestRunner::TestRunner::setBackingScaleFactor):
2766         (WebTestRunner::TestRunner::display):
2767         (WebTestRunner::TestRunner::displayInvalidatedRegion):
2768         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2769         (WebTestRunner):
2770         (TestRunner):
2771         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2772         (WebTestRunner::WebTestInterfaces::setWebView):
2773         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2774         (WebTestRunner::WebTestProxyBase::reset):
2775         (WebTestRunner::WebTestProxyBase::capturePixels):
2776         (WebTestRunner):
2777         (WebTestRunner::WebTestProxyBase::paintRect):
2778         (WebTestRunner::WebTestProxyBase::paintInvalidatedRegion):
2779         (WebTestRunner::WebTestProxyBase::paintPagesWithBoundaries):
2780         (WebTestRunner::WebTestProxyBase::canvas):
2781         (WebTestRunner::WebTestProxyBase::displayRepaintMask):
2782         (WebTestRunner::WebTestProxyBase::display):
2783         (WebTestRunner::WebTestProxyBase::displayInvalidatedRegion):
2784         (WebTestRunner::WebTestProxyBase::discardBackingStore):
2785         (WebTestRunner::WebTestProxyBase::setWindowRect):
2786         (WebTestRunner::WebTestProxyBase::userMediaClient):
2787         * DumpRenderTree/chromium/TestShell.cpp:
2788         (TestShell::createMainWindow):
2789         (TestShell::~TestShell):
2790         (TestShell::showDevTools):
2791         (TestShell::closeDevTools):
2792         (TestShell::dump):
2793         * DumpRenderTree/chromium/WebViewHost.cpp:
2794         (WebViewHost::setWindowRect):
2795         (WebViewHost::setDeviceScaleFactor):
2796         (WebViewHost::reset):
2797         * DumpRenderTree/chromium/WebViewHost.h:
2798         (WebViewHost):
2799
2800 2013-02-14  Tony Chang  <tony@chromium.org>
2801
2802         Unreviewed, set svn:eol-style native for .sln, .vcproj, and .vsprops files.
2803         https://bugs.webkit.org/show_bug.cgi?id=96934
2804
2805         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
2806         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
2807         * DumpRenderTree/win/DumpRenderTreeLauncherCommon.vsprops: Added property svn:eol-style.
2808         * DumpRenderTree/win/DumpRenderTreeLauncherDebug.vsprops: Added property svn:eol-style.
2809         * DumpRenderTree/win/DumpRenderTreeLauncherDebugAll.vsprops: Added property svn:eol-style.
2810         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops: Added property svn:eol-style.
2811         * DumpRenderTree/win/DumpRenderTreeLauncherProduction.vsprops: Added property svn:eol-style.
2812         * DumpRenderTree/win/DumpRenderTreeLauncherRelease.vsprops: Added property svn:eol-style.
2813         * DumpRenderTree/win/DumpRenderTreeLauncherReleaseCairoCFLite.vsprops: Added property svn:eol-style.
2814         * DumpRenderTree/win/ImageDiffLauncherCommon.vsprops: Added property svn:eol-style.
2815         * DumpRenderTree/win/ImageDiffLauncherDebug.vsprops: Added property svn:eol-style.
2816         * DumpRenderTree/win/ImageDiffLauncherDebugAll.vsprops: Added property svn:eol-style.
2817         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops: Added property svn:eol-style.
2818         * DumpRenderTree/win/ImageDiffLauncherProduction.vsprops: Added property svn:eol-style.
2819         * DumpRenderTree/win/ImageDiffLauncherRelease.vsprops: Added property svn:eol-style.
2820         * DumpRenderTree/win/ImageDiffLauncherReleaseCairoCFLite.vsprops: Added property svn:eol-style.
2821         * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Added property svn:eol-style.
2822         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
2823         * MiniBrowser/Configurations/MiniBrowserLauncherCommon.vsprops: Added property svn:eol-style.
2824         * MiniBrowser/Configurations/MiniBrowserLauncherDebug.vsprops: Added property svn:eol-style.
2825         * MiniBrowser/Configurations/MiniBrowserLauncherDebugAll.vsprops: Added property svn:eol-style.
2826         * MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops: Added property svn:eol-style.
2827         * MiniBrowser/Configurations/MiniBrowserLauncherProduction.vsprops: Added property svn:eol-style.
2828         * MiniBrowser/Configurations/MiniBrowserLauncherRelease.vsprops: Added property svn:eol-style.
2829         * MiniBrowser/Configurations/MiniBrowserLauncherReleaseCairoCFLite.vsprops: Added property svn:eol-style.
2830         * TestWebKitAPI/Configurations/TestWebKitAPICFNetwork.vsprops: Added property svn:eol-style.
2831         * TestWebKitAPI/Configurations/TestWebKitAPIDebug.vsprops: Added property svn:eol-style.
2832         * TestWebKitAPI/Configurations/TestWebKitAPIDebugAll.vsprops: Added property svn:eol-style.
2833         * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops: Added property svn:eol-style.
2834         * TestWebKitAPI/Configurations/TestWebKitAPIInjectedBundleCommon.vsprops: Added property svn:eol-style.
2835         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops: Added property svn:eol-style.
2836         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops: Added property svn:eol-style.
2837         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Added property svn:eol-style.
2838         * WebKitTestRunner/WebKitTestRunner.sln: Modified property svn:eol-style.
2839         * WebKitTestRunner/win/WebKitTestRunnerLauncherCommon.vsprops: Added property svn:eol-style.
2840         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebug.vsprops: Added property svn:eol-style.
2841         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugAll.vsprops: Added property svn:eol-style.
2842         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops: Added property svn:eol-style.
2843         * WebKitTestRunner/win/WebKitTestRunnerLauncherProduction.vsprops: Added property svn:eol-style.
2844         * WebKitTestRunner/win/WebKitTestRunnerLauncherRelease.vsprops: Added property svn:eol-style.
2845         * WebKitTestRunner/win/WebKitTestRunnerLauncherReleaseCairoCFLite.vsprops: Added property svn:eol-style.
2846         * WinLauncher/WinLauncherLauncherCommon.vsprops: Added property svn:eol-style.
2847         * WinLauncher/WinLauncherLauncherDebug.vsprops: Added property svn:eol-style.
2848         * WinLauncher/WinLauncherLauncherDebugAll.vsprops: Added property svn:eol-style.
2849         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops: Added property svn:eol-style.
2850         * WinLauncher/WinLauncherLauncherProduction.vsprops: Added property svn:eol-style.
2851         * WinLauncher/WinLauncherLauncherRelease.vsprops: Added property svn:eol-style.
2852         * WinLauncher/WinLauncherLauncherReleaseCairoCFLite.vsprops: Added property svn:eol-style.
2853
2854 2013-02-14  Tony Chang  <tony@chromium.org>
2855
2856         Unreviewed, set svn:eol-style CRLF for .sln files.
2857
2858         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
2859         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
2860         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
2861         * WebKitTestRunner/WebKitTestRunner.sln: Modified property svn:eol-style.
2862
2863 2013-02-14  Zan Dobersek  <zdobersek@igalia.com>
2864
2865         [GTK] Errors when building WebKit2 with Clang
2866         https://bugs.webkit.org/show_bug.cgi?id=109603
2867
2868         Reviewed by Alexey Proskuryakov.
2869
2870         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2871         (WTR::PlatformWebView::resizeTo): Cast the width and height parameters to the integer
2872         type when constructing the GtkAllocation.
2873
2874         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
2875         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
2876         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
2877         * WebKitTestRunner/WebKitTestRunner.sln: Modified property svn:eol-style.
2878
2879 2013-02-14  Roger Fong  <roger_fong@apple.com>
2880
2881         Add eol-style=native to solution files. Add a new solution file.
2882
2883         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree.sln: Added property svn:eol-style.
2884         * TestWebKitAPI/TestWebKitAPI.vcxproj: Added property svn:eol-style. Modified property svn:ignore.
2885         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.sln: Added.
2886
2887 2013-02-14  Mario Sanchez Prada  <mario.prada@samsung.com>
2888
2889         [GTK] Missing call to g_object_ref while retrieving accessible table cells
2890         https://bugs.webkit.org/show_bug.cgi?id=106903
2891
2892         Reviewed by Martin Robinson.
2893
2894         Both DRT and WKTR need to call g_object_unref() now that an extra
2895         reference is added in the implementation of atk_table_ref_at().
2896
2897         * DumpRenderTree/atk/AccessibilityUIElementGtk.cpp:
2898         (AccessibilityUIElement::cellForColumnAndRow): Call g_object_unref
2899         before returning the new instance of AccessibilityUIElement.
2900         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2901         (WTR::AccessibilityUIElement::cellForColumnAndRow): Ditto.
2902
2903 2013-02-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2904
2905         Unreviewed, rolling out r142841.
2906         http://trac.webkit.org/changeset/142841
2907         https://bugs.webkit.org/show_bug.cgi?id=109791
2908
2909         Caused webkit_unit_tests to crash on chromium bots. (Requested
2910         by atwilson_ on #webkit).
2911
2912         * DumpRenderTree/chromium/WebViewHost.cpp:
2913         (WebViewHost::createOutputSurface):
2914         (WebViewHost::initializeLayerTreeView):
2915
2916 2013-02-13  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2917
2918         [EFL][jhbuild] Silence GSettings-related warning.
2919         https://bugs.webkit.org/show_bug.cgi?id=109749
2920
2921         Reviewed by Martin Robinson.
2922
2923         Apply the same change done to the GTK+ port in r109127; this
2924         silences the warnings printed by glib about the memory GSettings
2925         backend being used.
2926
2927         Not only does this make the bots (as well as manual runs of, say,
2928         WebKitTestRunner) much more silent, but it also removes an stderr
2929         line (which run-perf-tests considers as a failure).
2930
2931         * Scripts/webkitpy/layout_tests/port/efl.py:
2932         (EflPort.setup_environ_for_server): Explicitly set the
2933         GSETTINGS_BACKEND environment variable to "memory".
2934
2935 2013-02-14  Jochen Eisinger  <jochen@chromium.org>
2936
2937         [chromium] move mock notification presenter to TestRunner library
2938         https://bugs.webkit.org/show_bug.cgi?id=109706
2939
2940         Reviewed by Adam Barth.
2941
2942         * DumpRenderTree/DumpRenderTree.gypi:
2943         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2944         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2945         (WebKit):
2946         (WebTestRunner::WebTestProxy::notificationPresenter):
2947         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Renamed from Tools/DumpRenderTree/chromium/NotificationPresenter.cpp.
2948         (WebTestRunner::NotificationPresenter::NotificationPresenter):
2949         (WebTestRunner):
2950         (WebTestRunner::NotificationPresenter::~NotificationPresenter):
2951         (WebTestRunner::NotificationPresenter::grantPermission):
2952         (WebTestRunner::NotificationPresenter::simulateClick):
2953         (WebTestRunner::NotificationPresenter::show):
2954         (WebTestRunner::NotificationPresenter::cancel):
2955         (WebTestRunner::NotificationPresenter::objectDestroyed):
2956         (WebTestRunner::NotificationPresenter::checkPermission):
2957         (WebTestRunner::NotificationPresenter::requestPermission):
2958         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Renamed from Tools/DumpRenderTree/chromium/NotificationPresenter.h.
2959         (WebTestRunner):
2960         (NotificationPresenter):
2961         (WebTestRunner::NotificationPresenter::setDelegate):
2962         (WebTestRunner::NotificationPresenter::reset):
2963         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2964         (WebTestRunner::TestRunner::TestRunner):
2965         (WebTestRunner::TestRunner::setDelegate):
2966         (WebTestRunner::TestRunner::reset):
2967         (WebTestRunner::TestRunner::notificationPresenter):
2968         (WebTestRunner):
2969         (WebTestRunner::TestRunner::grantWebNotificationPermission):
2970         (WebTestRunner::TestRunner::simulateLegacyWebNotificationClick):
2971         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2972         (WebKit):
2973         (WebTestRunner):
2974         (TestRunner):
2975         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2976         (WebTestRunner::WebTestProxyBase::notificationPresenter):
2977         (WebTestRunner):
2978         * DumpRenderTree/chromium/TestShell.cpp:
2979         (TestShell::initialize):
2980         (TestShell::resetTestController):
2981         * DumpRenderTree/chromium/TestShell.h:
2982         (WebKit):
2983         (TestShell):
2984         * DumpRenderTree/chromium/WebViewHost.cpp:
2985         * DumpRenderTree/chromium/WebViewHost.h:
2986
2987 2013-02-13  Roger Fong  <roger_fong@apple.com>
2988
2989         Unreviewed. Add separate DumpRenderTree VS2010 solution file.
2990
2991         * DumpRenderTree/DumpRenderTree.vcxproj: Added property svn:ignore.
2992         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree.sln: Added.
2993
2994 2013-02-12  James Robinson  <jamesr@chromium.org>
2995
2996         [chromium] Request WebLayerTreeView for DumpRenderTree via explicit testing path
2997         https://bugs.webkit.org/show_bug.cgi?id=109634
2998
2999         Reviewed by Adrienne Walker.
3000
3001         * DumpRenderTree/chromium/WebViewHost.cpp:
3002         (WebViewHost::createOutputSurface):
3003         (WebViewHost::initializeLayerTreeView):
3004
3005 2013-02-13  David Farler  <dfarler@apple.com>
3006
3007         TestWebKitAPI fails to build for iphonesimulator: 'CFNetwork/CFNetworkDefs.h' file not found
3008         https://bugs.webkit.org/show_bug.cgi?id=109766
3009
3010         Reviewed by David Kilzer.
3011
3012         * TestWebKitAPI/Configurations/Base.xcconfig:
3013         - Don't search Mac OS X header search paths when building on iOS
3014
3015 2013-02-13  Zan Dobersek  <zdobersek@igalia.com>
3016
3017         The 'global isinf/isnan' compiler quirk required when using clang with libstdc++
3018         https://bugs.webkit.org/show_bug.cgi?id=109325
3019
3020         Reviewed by Anders Carlsson.
3021
3022         Prefix calls to the isinf and isnan methods with std::, declaring we want to use the
3023         two methods as they're provided by the C++ standard library being used.
3024
3025         * DumpRenderTree/TestRunner.cpp:
3026         (setAppCacheMaximumSizeCallback):
3027         (setApplicationCacheOriginQuotaCallback):
3028         (setDatabaseQuotaCallback):
3029
3030 2013-02-13  Alan Cutter  <alancutter@chromium.org>
3031
3032         cr-linux debug should use clang and maybe be a components build
3033         https://bugs.webkit.org/show_bug.cgi?id=108512
3034
3035         Reviewed by Adam Barth.
3036
3037         Modified GCE cr-linux-debug-ews bot build scripts to configure clang over gcc for build performance.
3038         Build bots will update clang with each bot cycle.
3039         Updated GCE image paths to suit gcutil 1.6.1.
3040
3041         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
3042         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
3043         * EWSTools/GoogleComputeEngine/build-cr-linux-debug-ews.sh:
3044         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
3045         * EWSTools/configure-clang-linux.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-chromium-ews.sh.
3046         * EWSTools/start-queue.sh:
3047
3048 2013-02-13  Sheriff Bot  <webkit.review.bot@gmail.com>
3049
3050         Unreviewed, rolling out r142747.
3051         http://trac.webkit.org/changeset/142747
3052         https://bugs.webkit.org/show_bug.cgi?id=109746
3053
3054         broke component build (Requested by alecf_gardening on
3055         #webkit).
3056
3057         * TestWebKitAPI/TestWebKitAPI.gypi:
3058         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Removed.
3059
3060 2013-02-13  Jochen Eisinger  <jochen@chromium.org>
3061
3062         [chromium] fix TestRunner build with enable_webrtc=0
3063         https://bugs.webkit.org/show_bug.cgi?id=109700
3064
3065         Reviewed by Tony Chang.
3066
3067         We can't use ENABLE() macros in the TestRunner library, however,
3068         ENABLE_WEBRTC is defined by build/common.gypi, so we can use it.
3069
3070         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp:
3071         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp:
3072         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp:
3073         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp:
3074         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
3075         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3076         (WebTestRunner):
3077         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3078         (WebTestRunner::WebTestProxyBase::userMediaClient):
3079         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp:
3080
3081 2013-02-12  Roger Fong  <roger_fong@apple.com>
3082
3083         TestWebKitAPI and record-memory projects and property sheets for VS2010.
3084         https://bugs.webkit.org/show_bug.cgi?id=107034
3085
3086         Reviewed by Brent Fulgham.
3087
3088         * TestWebKitAPI/TestWebKitAPI.vcxproj: Added.
3089         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Added.
3090         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Added.
3091         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPostBuild.cmd: Copied from Tools/TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd.
3092         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPreBuild.cmd: Copied from Tools/TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd.
3093         * win/record-memory: Added.
3094         * win/record-memory/main.cpp: Copied from Tools/record-memory-win/main.cpp.
3095         * win/record-memory/record-memory.vcxproj: Added.
3096         * win/record-memory/record-memory.vcxproj.filters: Added.
3097         * win/record-memory/record-memoryCommon.props: Added.
3098         * win/record-memory/record-memoryDebug.props: Added.
3099         * win/record-memory/record-memoryRelease.props: Added.
3100
3101 2013-02-13  Tommy Widenflycht  <tommyw@google.com>
3102
3103         MediaStream API: Use the source id when creating new tracks
3104         https://bugs.webkit.org/show_bug.cgi?id=109688
3105
3106         Reviewed by Adam Barth.
3107
3108         Switching mock to new API.
3109
3110         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp:
3111         (WebTestRunner::WebUserMediaClientMock::requestUserMedia):
3112
3113 2013-02-13  Brent Fulgham  <bfulgham@webkit.org>
3114
3115         [Windows] Unreviewed VS2010 fix to add $(ConfigurationBuildDir)/private
3116         to include paths, to match VS2005 build behavior.
3117
3118         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherCommon.props:
3119         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherCommon.props:
3120         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
3121         * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props:
3122         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props:
3123
3124 2013-02-13  Sheriff Bot  <webkit.review.bot@gmail.com>
3125
3126         Unreviewed, rolling out r142736.
3127         http://trac.webkit.org/changeset/142736
3128         https://bugs.webkit.org/show_bug.cgi?id=109716
3129
3130         Broke ABI, nightly builds crash on launch (Requested by ap on
3131         #webkit).
3132
3133         * MiniBrowser/mac/WK2BrowserWindowController.m:
3134         (-[WK2BrowserWindowController awakeFromNib]):
3135         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3136         (WTR::InjectedBundlePage::InjectedBundlePage):
3137         * WebKitTestRunner/TestController.cpp:
3138         (WTR::TestController::createWebViewWithOptions):
3139
3140 2013-02-13  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3141
3142         [WK2][EFL][WTR] Regression(r141836): WTR crashes on exit
3143         https://bugs.webkit.org/show_bug.cgi?id=109456
3144
3145         Reviewed by Anders Carlsson.
3146
3147         WebView instance must not live longer than EwkView, as EwkView owns
3148         objects that page proxy refers to, doing otherwise leads to a crash.
3149
3150         Test controller has own ptr containing WebView. Invoking of ewk_shutdown()
3151         leads to evas objects deletion. So, the problem was that test controller was
3152         deleted after ewk_shutdown() had been called in main() function causing
3153         crashes on WTR exit.
3154
3155         The patch introduces a scope for test controller so that it is deleted first.
3156
3157         * WebKitTestRunner/efl/main.cpp:
3158         (main):
3159
3160 2013-02-13  Ilya Tikhonovsky  <loislo@chromium.org>
3161
3162         Web Inspector: Native Memory Instrumentation: reportLeaf method doesn't report the leaf node properly.
3163         https://bugs.webkit.org/show_bug.cgi?id=109554
3164
3165         In some cases leaves have no pointer so with the old schema we can't generate nodeId for them because we
3166         can't insert 0 into hashmap. It happens when we call addPrivateBuffer method.
3167
3168         Drive by fix: I introduced a client interface for the HeapGraphSerializer.
3169         It helps me to do the tests for the serializer.
3170
3171         Reviewed by Yury Semikhatsky.
3172
3173         It is covered by newly added tests in TestWebKitAPI.
3174
3175         * TestWebKitAPI/TestWebKitAPI.gypi:
3176         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Added.
3177         (TestWebKitAPI):
3178         (HeapGraphReceiver):
3179         (TestWebKitAPI::HeapGraphReceiver::HeapGraphReceiver):
3180         (TestWebKitAPI::HeapGraphReceiver::printGraph):
3181         (TestWebKitAPI::HeapGraphReceiver::dumpNodes):
3182         (TestWebKitAPI::HeapGraphReceiver::dumpEdges):
3183         (TestWebKitAPI::HeapGraphReceiver::dumpBaseToRealNodeId):
3184         (TestWebKitAPI::HeapGraphReceiver::dumpStrings):
3185         (TestWebKitAPI::HeapGraphReceiver::serializer):
3186         (TestWebKitAPI::HeapGraphReceiver::chunkPart):
3187         (TestWebKitAPI::HeapGraphReceiver::dumpPart):
3188         (TestWebKitAPI::HeapGraphReceiver::stringValue):
3189         (TestWebKitAPI::HeapGraphReceiver::intValue):
3190         (TestWebKitAPI::HeapGraphReceiver::nodeToString):
3191         (TestWebKitAPI::HeapGraphReceiver::edgeToString):
3192         (TestWebKitAPI::HeapGraphReceiver::printNode):
3193         (Helper):
3194         (TestWebKitAPI::Helper::Helper):
3195         (TestWebKitAPI::Helper::addNode):
3196         (TestWebKitAPI::Helper::addEdge):
3197         (TestWebKitAPI::Helper::done):
3198         (Object):
3199         (TestWebKitAPI::Helper::Object::Object):
3200         (TestWebKitAPI::TEST):
3201         (Owner):
3202         (TestWebKitAPI::Owner::Owner):
3203         (TestWebKitAPI::Owner::reportMemoryUsage):
3204
3205 2013-02-13  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3206
3207         [WK2] Remove web intents callbacks
3208         https://bugs.webkit.org/show_bug.cgi?id=109654
3209
3210         Reviewed by Benjamin Poulain.
3211
3212         Web intents was removed by r142549.
3213
3214         * MiniBrowser/mac/WK2BrowserWindowController.m:
3215         (-[WK2BrowserWindowController awakeFromNib]):
3216         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3217         (WTR::InjectedBundlePage::InjectedBundlePage):
3218         * WebKitTestRunner/TestController.cpp:
3219         (WTR::TestController::createWebViewWithOptions):
3220
3221 2013-02-12  Adenilson Cavalcanti  <cavalcantii@gmail.com>
3222
3223         [WK2] Page reloading will crash UIProcess after WebProcess was killed
3224         https://bugs.webkit.org/show_bug.cgi?id=109305
3225
3226         Reviewed by Benjamin Poulain.
3227
3228         Adding a new test to simulate the case of WebProcess crash followed by a trying
3229         to load a new page.
3230
3231         * TestWebKitAPI/GNUmakefile.am:
3232         * TestWebKitAPI/PlatformEfl.cmake:
3233         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3234         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp: Added.
3235         (TestWebKitAPI):
3236         (TestWebKitAPI::didFinishLoad):
3237         (TestWebKitAPI::TEST):
3238
3239 2013-02-11  Brent Fulgham  <bfulgham@webkit.org>
3240
3241         Update WebKitDirs.pm for new Windows paths
3242         https://bugs.webkit.org/show_bug.cgi?id=107714
3243
3244         Reviewed by Daniel Bates.
3245
3246         * Scripts/webkitdirs.pm: For each existing Windows environment
3247         variable, also include creation of the 'new' variables. The
3248         'old' variables will be removed in a future update.
3249         (windowsSourceSourceDir): New helper routine to return the
3250         actual 'Source' folder of the WebKit source tree.
3251
3252 2013-02-12  Alec Flett  <alecflett@chromium.org>
3253
3254         Fix signedness in WebTestProxy
3255         https://bugs.webkit.org/show_bug.cgi?id=109623
3256
3257         Reviewed by Adam Barth.
3258
3259         Fix signedness problem, using size_t instead of int.
3260
3261         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3262
3263 2013-02-12  Raymond Toy  <rtoy@google.com>
3264
3265         Add alias
3266         https://bugs.webkit.org/show_bug.cgi?id=109621
3267
3268         No review needed.
3269
3270         * Scripts/webkitpy/common/config/committers.py:
3271
3272 2013-02-12  Jochen Eisinger  <jochen@chromium.org>
3273
3274         [chromium] move text dump generation to TestRunner library
3275         https://bugs.webkit.org/show_bug.cgi?id=109575
3276
3277         Reviewed by Adam Barth.
3278
3279         * DumpRenderTree/DumpRenderTree.gypi:
3280         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3281         (WebKit):
3282         (WebTestRunner::WebTestDelegate::captureHistoryForWindow):
3283         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3284         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3285         (WebTestRunner):
3286         * DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestCommon.h.
3287         (WebTestRunner::normalizeLayoutTestURL):
3288         (WebTestRunner):
3289         * DumpRenderTree/chromium/TestRunner/src/TestCommon.h:
3290         (WebTestRunner):
3291         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3292         (WebTestRunner::TestRunner::checkResponseMimeType):
3293         (WebTestRunner):
3294         (WebTestRunner::TestRunner::shouldDumpAsText):
3295         (WebTestRunner::TestRunner::shouldGeneratePixelResults):
3296         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3297         (TestRunner):
3298         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp:
3299         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3300         (WebTestRunner::WebTestProxyBase::captureTree):
3301         (WebTestRunner):
3302         * DumpRenderTree/chromium/TestShell.cpp:
3303         (TestShell::dump):
3304         (TestShell::captureHistoryForWindow):
3305         * DumpRenderTree/chromium/TestShell.h:
3306         (TestShell):
3307         * DumpRenderTree/chromium/WebViewHost.cpp:
3308         (WebViewHost::captureHistoryForWindow):
3309         * DumpRenderTree/chromium/WebViewHost.h:
3310
3311 2013-02-12  Jessie Berlin  <jberlin@apple.com>
3312
3313         Rollout r142618, it broke all the Mac builds.
3314
3315         * TestWebKitAPI/TestWebKitAPI.gypi:
3316         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3317         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Removed.
3318         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3319
3320 2013-02-12  Yury Semikhatsky  <yurys@chromium.org>
3321
3322         Unreviewed. Fix Chromium compilation after r142618.
3323
3324         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:
3325         (TestWebKitAPI::HeapGraphReceiver::printNode):
3326
3327 2013-02-12  Martin Robinson  <mrobinson@igalia.com>
3328
3329         [GTK] Add an optional moduleset with hard to get packages (including libsecret)
3330         https://bugs.webkit.org/show_bug.cgi?id=109195
3331
3332         Reviewed by Philippe Normand.
3333
3334         Add an optional moduleset that includes libsecret. This moduleset will
3335         be used to install some annoyingly hard to obtain dependencies on older
3336         distributions.
3337
3338         * gtk/jhbuild-optional.modules: Added.
3339         * gtk/jhbuild.modules: Add a reference to the new moduleset file.
3340
3341 2013-02-12  Ilya Tikhonovsky  <loislo@chromium.org>
3342
3343         Web Inspector: Native Memory Instrumentation: reportLeaf method doesn't report the leaf node properly.
3344         https://bugs.webkit.org/show_bug.cgi?id=109554
3345
3346         In some cases leaves have no pointer. As example when we report a leaf via addPrivateBuffer.
3347         This patch has new set of tests for HeapGraphSerializer.
3348
3349         Reviewed by Yury Semikhatsky.
3350
3351         * TestWebKitAPI/TestWebKitAPI.gypi:
3352         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3353         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Added.
3354         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3355
3356 2013-02-12  Zan Dobersek  <zdobersek@igalia.com>
3357
3358         Unreviewed followup to r142606, the EFL port also enables the CSS image-set
3359         feature so the new configuration option's default value should reflect that.
3360
3361         * Scripts/webkitperl/FeatureList.pm:
3362
3363 2013-02-12  Zan Dobersek  <zdobersek@igalia.com>
3364
3365         [GTK] Enable CSS Variables feature in development builds
3366         https://bugs.webkit.org/show_bug.cgi?id=109474
3367
3368         Reviewed by Martin Robinson.
3369
3370         * Scripts/webkitperl/FeatureList.pm: Enable the feature on development
3371         builds of the GTK port.
3372
3373 2013-02-12  Zan Dobersek  <zdobersek@igalia.com>
3374
3375         [GTK] Enable CSS image-set support in development builds
3376         https://bugs.webkit.org/show_bug.cgi?id=109475
3377
3378         Reviewed by Martin Robinson.
3379
3380         * Scripts/webkitperl/FeatureList.pm: Add the configuration option for the feature.
3381         Note that the Mac port also enables the feature but does so in Platform.h as the feature
3382         is also enabled for the iOS port which can't at the moment be detected via webkitperl.
3383
3384 2013-02-12  Zan Dobersek  <zdobersek@igalia.com>
3385
3386         [GTK] Enable DOM4 events constructors in development builds
3387         https://bugs.webkit.org/show_bug.cgi?id=109471
3388
3389         Reviewed by Martin Robinson.
3390
3391         * Scripts/webkitperl/FeatureList.pm: Enable the feature for the GTK port as well.
3392
3393 2013-02-12  Zan Dobersek  <zdobersek@igalia.com>
3394
3395         Remove unnecessary variables from FeatureList.pm
3396         https://bugs.webkit.org/show_bug.cgi?id=109558
3397
3398         Reviewed by Daniel Bates.
3399
3400         A small cleanup, removing unused variables for which the related configuration
3401         options were already removed.
3402
3403         * Scripts/webkitperl/FeatureList.pm:
3404
3405 2013-02-12  Zan Dobersek  <zdobersek@igalia.com>
3406
3407         Remove ENABLE_XHR_RESPONSE_BLOB handling from various build systems
3408         https://bugs.webkit.org/show_bug.cgi?id=109481
3409
3410         Reviewed by Daniel Bates.
3411
3412         The ENABLE_XHR_RESPONSE_BLOB feature define was removed from the code
3413         back in r120574. There are still occurrences of it in various build systems
3414         which should all be removed as they are useless.
3415
3416         * Scripts/webkitperl/FeatureList.pm:
3417
3418 2013-02-12  Jochen Eisinger  <jochen@chromium.org>
3419
3420         [chromium] move webrtc mocks to testrunner library
3421         https://bugs.webkit.org/show_bug.cgi?id=109041
3422
3423         Reviewed by Adam Barth.
3424
3425         * DumpRenderTree/DumpRenderTree.gypi:
3426         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3427         (WebKitSupportTestEnvironment):
3428         (WebKitSupportTestEnvironment::mockPlatform):
3429         (main):
3430         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
3431         (MockWebKitPlatformSupport::setInterfaces):
3432         (MockWebKitPlatformSupport::createMediaStreamCenter):
3433         (MockWebKitPlatformSupport::createRTCPeerConnectionHandler):
3434         * DumpRenderTree/chromium/MockWebKitPlatformSupport.h:
3435         (WebTestRunner):
3436         (MockWebKitPlatformSupport):
3437         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3438         (WebKit):
3439         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3440         (WebKit):
3441         (WebTestRunner):
3442         (WebTestRunner::WebTestProxy::showContextMenu):
3443         (WebTestRunner::WebTestProxy::userMediaClient):
3444         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Renamed from Tools/DumpRenderTree/chromium/MockConstraints.cpp.
3445         (WebTestRunner::MockConstraints::verifyConstraints):
3446         (WebTestRunner):
3447         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Renamed from Tools/DumpRenderTree/chromium/MockConstraints.h.
3448         (WebKit):
3449         (WebTestRunner):
3450         (MockConstraints):
3451         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp.
3452         (WebTestRunner):
3453         (WebTestRunner::MockWebMediaStreamCenter::MockWebMediaStreamCenter):
3454         (WebTestRunner::MockWebMediaStreamCenter::queryMediaStreamSources):
3455         (WebTestRunner::MockWebMediaStreamCenter::didEnableMediaStreamTrack):
3456         (WebTestRunner::MockWebMediaStreamCenter::didDisableMediaStreamTrack):
3457         (WebTestRunner::MockWebMediaStreamCenter::didAddMediaStreamTrack):
3458         (WebTestRunner::MockWebMediaStreamCenter::didRemoveMediaStreamTrack):
3459         (WebTestRunner::MockWebMediaStreamCenter::didStopLocalMediaStream):
3460         (MockWebAudioDestinationConsumer):
3461         (WebTestRunner::MockWebAudioDestinationConsumer::~MockWebAudioDestinationConsumer):
3462         (WebTestRunner::MockWebMediaStreamCenter::didCreateMediaStream):
3463         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Renamed from Tools/DumpRenderTree/chromium/MockWebMediaStreamCenter.h.
3464         (WebKit):
3465         (WebTestRunner):
3466         (MockWebMediaStreamCenter):
3467         (WebTestRunner::MockWebMediaStreamCenter::MockWebMediaStreamCenter):
3468         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebRTCDTMFSenderHandler.cpp.
3469         (WebTestRunner):
3470         (DTMFSenderToneTask):
3471         (WebTestRunner::DTMFSenderToneTask::DTMFSenderToneTask):
3472         (WebTestRunner::MockWebRTCDTMFSenderHandler::MockWebRTCDTMFSenderHandler):
3473         (WebTestRunner::MockWebRTCDTMFSenderHandler::setClient):
3474         (WebTestRunner::MockWebRTCDTMFSenderHandler::currentToneBuffer):
3475         (WebTestRunner::MockWebRTCDTMFSenderHandler::canInsertDTMF):
3476         (WebTestRunner::MockWebRTCDTMFSenderHandler::insertDTMF):
3477         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Renamed from Tools/DumpRenderTree/chromium/MockWebRTCDTMFSenderHandler.h.
3478         (WebTestRunner):
3479         (MockWebRTCDTMFSenderHandler):
3480         (WebTestRunner::MockWebRTCDTMFSenderHandler::taskList):
3481         (WebTestRunner::MockWebRTCDTMFSenderHandler::clearToneBuffer):
3482         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebRTCDataChannelHandler.cpp.
3483         (WebTestRunner):
3484         (DataChannelReadyStateTask):
3485         (WebTestRunner::DataChannelReadyStateTask::DataChannelReadyStateTask):
3486         (WebTestRunner::MockWebRTCDataChannelHandler::MockWebRTCDataChannelHandler):
3487         (WebTestRunner::MockWebRTCDataChannelHandler::setClient):
3488         (WebTestRunner::MockWebRTCDataChannelHandler::bufferedAmount):
3489         (WebTestRunner::MockWebRTCDataChannelHandler::sendStringData):
3490         (WebTestRunner::MockWebRTCDataChannelHandler::sendRawData):
3491         (WebTestRunner::MockWebRTCDataChannelHandler::close):
3492         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Renamed from Tools/DumpRenderTree/chromium/MockWebRTCDataChannelHandler.h.
3493         (WebTestRunner):
3494         (MockWebRTCDataChannelHandler):
3495         (WebTestRunner::MockWebRTCDataChannelHandler::taskList):
3496         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp.
3497         (WebTestRunner):
3498         (RTCSessionDescriptionRequestSuccededTask):
3499         (WebTestRunner::RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
3500         (RTCSessionDescriptionRequestFailedTask):
3501         (WebTestRunner::RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
3502         (RTCStatsRequestSucceededTask):
3503         (WebTestRunner::RTCStatsRequestSucceededTask::RTCStatsRequestSucceededTask):
3504         (RTCVoidRequestTask):
3505         (WebTestRunner::RTCVoidRequestTask::RTCVoidRequestTask):
3506         (RTCPeerConnectionStateTask):
3507         (WebTestRunner::RTCPeerConnectionStateTask::RTCPeerConnectionStateTask):
3508         (RemoteDataChannelTask):
3509         (WebTestRunner::RemoteDataChannelTask::RemoteDataChannelTask):
3510         (WebTestRunner::MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
3511         (WebTestRunner::MockWebRTCPeerConnectionHandler::initialize):
3512         (WebTestRunner::MockWebRTCPeerConnectionHandler::createOffer):
3513         (WebTestRunner::MockWebRTCPeerConnectionHandler::createAnswer):
3514         (WebTestRunner::MockWebRTCPeerConnectionHandler::setLocalDescription):
3515         (WebTestRunner::MockWebRTCPeerConnectionHandler::setRemoteDescription):
3516         (WebTestRunner::MockWebRTCPeerConnectionHandler::localDescription):
3517         (WebTestRunner::MockWebRTCPeerConnectionHandler::remoteDescription):
3518         (WebTestRunner::MockWebRTCPeerConnectionHandler::updateICE):
3519         (WebTestRunner::MockWebRTCPeerConnectionHandler::addICECandidate):
3520         (WebTestRunner::MockWebRTCPeerConnectionHandler::addStream):
3521         (WebTestRunner::MockWebRTCPeerConnectionHandler::removeStream):
3522         (WebTestRunner::MockWebRTCPeerConnectionHandler::getStats):
3523         (WebTestRunner::MockWebRTCPeerConnectionHandler::createDataChannel):
3524         (WebTestRunner::MockWebRTCPeerConnectionHandler::createDTMFSender):
3525         (WebTestRunner::MockWebRTCPeerConnectionHandler::stop):
3526         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Renamed from Tools/DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h.
3527         (WebKit):
3528         (WebTestRunner):
3529         (MockWebRTCPeerConnectionHandler):
3530         (WebTestRunner::MockWebRTCPeerConnectionHandler::taskList):
3531         (WebTestRunner::MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
3532         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3533         (WebTestRunner::TestInterfaces::TestInterfaces):
3534         (WebTestRunner::TestInterfaces::setDelegate):
3535         (WebTestRunner::TestInterfaces::delegate):
3536         (WebTestRunner):
3537         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3538         (TestInterfaces):
3539         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3540         (WebTestRunner::WebTestInterfaces::createMediaStreamCenter):
3541         (WebTestRunner):
3542         (WebTestRunner::WebTestInterfaces::createWebRTCPeerConnectionHandler):
3543         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3544         (WebTestRunner::WebTestProxyBase::userMediaClient):
3545         (WebTestRunner):
3546         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Renamed from Tools/DumpRenderTree/chromium/WebUserMediaClientMock.cpp.
3547         (WebTestRunner):
3548         (UserMediaRequestTask):
3549         (WebTestRunner::UserMediaRequestTask::UserMediaRequestTask):
3550         (MockExtraData):
3551         (WebTestRunner::WebUserMediaClientMock::WebUserMediaClientMock):
3552         (WebTestRunner::WebUserMediaClientMock::requestUserMedia):
3553         (WebTestRunner::WebUserMediaClientMock::cancelUserMediaRequest):
3554         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/WebUserMediaClientMock.h.
3555         (WebTestRunner):
3556         (WebUserMediaClientMock):
3557         (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
3558         (WebTestRunner::WebUserMediaClientMock::taskList):
3559         * DumpRenderTree/chromium/TestShell.cpp:
3560         (TestShell::initialize):
3561         * DumpRenderTree/chromium/TestShell.h:
3562         (TestShell):
3563         * DumpRenderTree/chromium/WebViewHost.cpp:
3564         * DumpRenderTree/chromium/WebViewHost.h:
3565         (WebViewHost):
3566
3567 2013-02-11  Timothy Loh  <timloh@chromium.com>
3568
3569         webkit-patch upload regenerates the WebCore ChangeLog every time it's called
3570         https://bugs.webkit.org/show_bug.cgi?id=108983
3571
3572         Reviewed by Ryosuke Niwa.
3573
3574         This patch puts the behaviour from Bug 74358 behind the flag (default=OFF)
3575         `--update-changelogs', and removes the flag `--no-prepare-changelogs'.
3576         The flag name change from prepare to update is since we still want to
3577         prepare changelogs in the default case when none currently exist.
3578
3579         * Scripts/webkitpy/tool/commands/commandtest.py:
3580         (CommandsTest.assert_execute_outputs):
3581         * Scripts/webkitpy/tool/steps/options.py:
3582         (Options):
3583         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3584         (PrepareChangeLog.options):
3585         (PrepareChangeLog.run):
3586
3587 2013-02-11  Jochen Eisinger  <jochen@chromium.org>
3588
3589         [chromium] move printPage() implementation to testRunner library
3590         https://bugs.webkit.org/show_bug.cgi?id=109436
3591
3592         Reviewed by Adam Barth.
3593
3594         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3595         (WebTestRunner::WebTestProxy::showContextMenu):
3596         (WebTestRunner::WebTestProxy::printPage):
3597         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3598         (WebTestRunner):
3599         (WebTestRunner::WebTestProxyBase::printPage):
3600         * DumpRenderTree/chromium/WebViewHost.cpp:
3601         * DumpRenderTree/chromium/WebViewHost.h:
3602
3603 2013-02-11  James Robinson  <jamesr@chromium.org>
3604
3605         [Chromium] Get rid of WebAnimationController
3606         https://bugs.webkit.org/show_bug.cgi?id=109235
3607
3608         Reviewed by Benjamin Poulain.
3609
3610         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3611         (WebTestRunner::TestRunner::TestRunner):
3612         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3613         (TestRunner):
3614
3615 2013-02-11  Ryosuke Niwa  <rniwa@webkit.org>
3616
3617         Disable delete button controller on non-Mac ports and delete EditorClient::shouldShowDeleteInterface
3618         https://bugs.webkit.org/show_bug.cgi?id=109534
3619
3620         Reviewed by Anders Carlsson.
3621
3622         * DumpRenderTree/gtk/EditingCallbacks.cpp:
3623         (shouldShowDeleteInterfaceForElement):
3624
3625 2013-02-11  Nico Weber  <thakis@chromium.org>
3626
3627         Remove web intents code
3628         https://bugs.webkit.org/show_bug.cgi?id=109501
3629
3630         Reviewed by Eric Seidel.
3631
3632         See thread "Removing ENABLE(WEB_INTENTS) code" on webkit-dev.
3633
3634         * DumpRenderTree/TestRunner.cpp:
3635         (TestRunner::staticFunctions):
3636         * DumpRenderTree/TestRunner.h: