d1bfb386b8a25f99f6851c374ae55ed2050fe45e
[WebKit-https.git] / Tools / ChangeLog
1 2011-06-22  Nate Chapin  <japhet@chromium.org>
2
3         Reviewed by Adam Barth.
4
5         Add libsoup to libWebCoreInternals build.
6         https://bugs.webkit.org/show_bug.cgi?id=62066
7
8         * GNUmakefile.am:
9
10 2011-06-22  Dirk Pranke  <dpranke@chromium.org>
11
12         Reviewed by Tony Chang.
13
14         nrwt: handle missing httpd cleanly
15         https://bugs.webkit.org/show_bug.cgi?id=62027
16
17         We had reverted the change in r89414, so this adds it back in
18         (modifying check_sys_deps() in port/base.py to check for an
19         installed web server).
20
21         This change then fixes the change in r89414 to stub out the
22         check_sys_deps() in the test port so that the unit tests run correctly.
23
24         * Scripts/webkitpy/layout_tests/port/base.py:
25         * Scripts/webkitpy/layout_tests/port/test.py:
26
27 2011-06-22  David Levin  <levin@chromium.org>
28
29         Reviewed by Adam Barth.
30
31         check-webkit-style should check for invalid uses of RefPtr/OwnPtr as parameters.
32         https://bugs.webkit.org/show_bug.cgi?id=63188
33
34         * Scripts/webkitpy/style/checkers/cpp.py: Added the check.
35         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
36
37 2011-06-22  Tony Chang  <tony@chromium.org>
38
39         Reviewed by Ojan Vafai.
40
41         Add a buildbot for testing ENABLE(CSS3_FLEXBOX)
42         https://bugs.webkit.org/show_bug.cgi?id=62891
43
44         * BuildSlaveSupport/build.webkit.org-config/config.json:
45
46 2011-06-22  Dirk Pranke  <dpranke@chromium.org>
47
48         Reviewed by Ojan Vafai.
49
50         nrwt: don't look for http lock when running the test port
51         https://bugs.webkit.org/show_bug.cgi?id=63158
52
53         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
54         * Scripts/webkitpy/layout_tests/port/test.py:
55
56 2011-06-22  Balazs Kelemen  <kbalazs@webkit.org>
57
58         Reviewed by Andreas Kling.
59
60         [Qt][WK2] Set up plugin tests
61         https://bugs.webkit.org/show_bug.cgi?id=63066
62
63         * WebKitTestRunner/qt/TestControllerQt.cpp:
64         (WTR::TestController::initializeTestPluginDirectory):
65         Use the QTWEBKIT_PLUGIN_PATH environment variable as the path
66         of the test plugin like DRT does.
67
68 2011-06-22  Eric Seidel  <eric@webkit.org>
69
70         Reviewed by Ojan Vafai.
71
72         Make sheriff-bot rollout messages a little nicer
73         https://bugs.webkit.org/show_bug.cgi?id=63107
74
75         It annoyed me this afternoon that I had to convert sheriff-bots "r12345" revisions
76         into urls myself.  So I have now fixed its "preparing" message to include a url.
77
78         I also figured that I should make the messages mention all of the responsible parties
79         so that rollouts are never surprises.  If you're in the channel and were involved
80         in a patch, you will see if someone is using sheriff-bot to rollout a patch.
81
82         As part of doing this I also changed (and tested) _parse_args to fail-fast
83         when given invalid args.
84
85         * Scripts/webkitpy/tool/bot/irc_command.py:
86         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
87         * Scripts/webkitpy/tool/bot/sheriff.py:
88         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
89
90 2011-06-22  Dirk Pranke  <dpranke@chromium.org>
91
92         Reviewed by Tony Chang.
93
94         run-webkit-websocketserver fails to stop websocket server
95         https://bugs.webkit.org/show_bug.cgi?id=63123
96
97         There's a ten-character change in new-run-webkit-websocketserver
98         that fixes the actual bug, and then we update the code in
99         new-run-webkit-httpd to do the actual stop call, and add more tests
100         (refactoring the existing test code so that it is shared).
101
102         * Scripts/new-run-webkit-httpd:
103         * Scripts/new-run-webkit-websocketserver:
104         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py:
105
106 2011-06-22  Adam Roben  <aroben@apple.com>
107
108         Add links to existing bugs related to failing tests on TestFailures page
109
110         I changed the layout of the page a little to make it easier to read with all the new
111         information. Passing/failing revisions have been moved down below the list of tests to be
112         closer to the existing bugs and the new bug link. And each set of tests and its relevant
113         information is in a light gray box.
114
115         Fixes <http://webkit.org/b/61665> TestFailures page should link to existing bugs when
116         possible
117
118         Reviewed by Darin Adler.
119
120         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js: Added.
121         (Bugzilla): This new class represents a single Bugzilla instance.
122         (Bugzilla.prototype.quickSearch): Searches Bugzilla using its Quick Search functionality,
123         passing the resulting bug titles and URLs to the callback when complete. If called multiple
124         times with the same query before the query returns, caches the callbacks so that only one
125         query is sent over the wire. When the query completes, all pending callbacks are called.
126
127         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
128         (#failure-history): Reduce the margin/padding on the top-level list a bit.
129         (#failure-history > li): Put each set of tests in a gray box, and indent most information
130         inside the box.
131         (.test-list): Unindent the list of failing tests so it is visually at the top level.
132         (.new-and-existing-bugs): Reduce the space at the bottom of this area so that the bottom of
133         each box isn't a big empty space.
134         (.existing-bugs-list): Use a smaller text size for existing bugs, since their titles can be
135         quite long.
136
137         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
138         (addQueryParametersToURL): New function extracted from
139         ViewController.prototype._domForNewAndExistingBugs.
140
141         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
142         (ViewController): Take and store an optional Bugzilla instance.
143         (ViewController.prototype._displayBuilder): Give the top-level list an id for styling
144         purposes and move the list of failing tests above all other information. Only show bug
145         information once we've determined the most-recent passing revision for a set of tests. It's
146         not that useful to file a new bug before this information has been determined, and searching
147         for existing bugs before we've figured out which tests started failing at the same time
148         would end up giving you information about a bunch of unrelated tests.
149         (ViewController.prototype._domForNewAndExistingBugs): Renamed from _domForNewBugLink. Now
150         returns a DocumentFragment instead of an HTMLParagraphElement. If we don't have a Bugzilla
151         instance, just returns an empty DocumentFragment. Starts a search for bugs related to the
152         failing tests, and adds links to the bugs when the search completes.
153
154         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pass a
155         Bugzilla instance for bugs.webkit.org to the ViewController.
156
157 2011-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
158
159         Reviewed by Martin Robinson.
160
161         [GTK] Apply current view settings to newly created views in GtkLauncher
162         https://bugs.webkit.org/show_bug.cgi?id=63142
163
164         * GtkLauncher/main.c:
165         (createWebViewCb):
166
167 2011-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
168
169         Reviewed by Martin Robinson.
170
171         [GTK] Use GOption to parse main arguments in GtkLauncher
172         https://bugs.webkit.org/show_bug.cgi?id=63060
173
174         Instead of getting the settings from the view, create a new
175         settings object not associated with any view so that we can parse
176         the command line arguments before creating the view. It will also
177         allows to use the same settings for more than one view if we
178         eventually support passing more than one uri from the command
179         line.
180
181         * GtkLauncher/main.c:
182         (parseOptionEntryCallback): Make this function static. Also use
183         g_ascii_strtoll/g_ascii_strtod to parse int/float values instead
184         of atoi/atof to provide better error messages. And always fill the
185         error struct when the function fails.
186         (getOptionEntriesFromWebKitWebSettings): Use an array of
187         GOptionEntry structs instead of a GArray, since that is what
188         g_option_group_add_entries() expects and the array size doesn't
189         change.
190         (addWebSettingsGroupToContext): Helper function to add the
191         websettings group to the option context.
192         (main): Create the option context to parse command line arguments.
193
194 2011-06-22  Martin Robinson  <mrobinson@igalia.com>
195
196         Reviewed by Adam Roben.
197
198         [GTK] Implement pixel dump support for WebKitTestRunner
199         https://bugs.webkit.org/show_bug.cgi?id=58242
200
201         * DumpRenderTree/gtk/GNUmakefile.ImageDiff.am: Added.
202         * GNUmakefile.am: Separate out the ImageDiff bits of the GNUmakefile.
203         * Scripts/old-run-webkit-tests: Update to add support for the GTK+ port.
204         * WebKitTestRunner/GNUmakefile.am: Added Cairo specific files to the build.
205         * WebKitTestRunner/TestInvocation.cpp: Moved this code to the platform-independent
206         file so that we can share it across platforms.
207         (WTR::TestInvocation::compareActualHashToExpectedAndDumpResults):
208         * WebKitTestRunner/TestInvocation.h: Updated method list.
209         * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Added Cairo implementation.
210         * WebKitTestRunner/cg/TestInvocationCG.cpp:
211         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Updated to use new helper.
212
213 2011-06-22  Sheriff Bot  <webkit.review.bot@gmail.com>
214
215         Unreviewed, rolling out r89414.
216         http://trac.webkit.org/changeset/89414
217         https://bugs.webkit.org/show_bug.cgi?id=63130
218
219         It broke webkitpy tests (Requested by Ossy on #webkit).
220
221         * Scripts/webkitpy/layout_tests/port/base.py:
222
223 2011-06-22  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
224
225         Reviewed by Dirk Pranke.
226
227         [NRWT] Print error message when there is no httpd present on the system
228         https://bugs.webkit.org/show_bug.cgi?id=62027
229
230         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
231
232 2011-06-21  Dirk Pranke  <dpranke@chromium.org>
233
234         Unreviewed, build fix.
235         Fix crashes in new-run-webkit-tests resulting from the
236         change to the http_server logic in r89400. Python 2.5
237         on Mac 10.5 has some weird error paths.
238
239         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
240         * Scripts/webkitpy/common/system/executive.py:
241
242 2011-06-21  MORITA Hajime  <morrita@google.com>
243
244         Unreviewed, rolling out r89401 and r89403.
245         http://trac.webkit.org/changeset/89401
246         http://trac.webkit.org/changeset/89403
247         https://bugs.webkit.org/show_bug.cgi?id=62970
248
249         Breaks mac build and mistakenly enables the spellcheck API
250
251         * Scripts/build-webkit:
252         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
253
254 2011-06-21  Kent Tamura  <tkent@chromium.org>
255
256         [Mac] Sort Xcode project files.
257
258         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
259
260 2011-06-20  MORITA Hajime  <morrita@google.com>
261
262         Reviewed by Kent Tamura.
263
264         Spellcheck API should be build-able.
265         https://bugs.webkit.org/show_bug.cgi?id=62970
266
267         * Scripts/build-webkit:
268
269 2011-06-21  Dirk Pranke  <dpranke@chromium.org>
270
271         Reviewed by Tony Chang.
272
273         nrwt: attempt #3 at fixing server startup/shutdown
274         https://bugs.webkit.org/show_bug.cgi?id=62829
275
276         Attempt yet again to make starting and stopping servers
277         reliable. It turns out that apache has races between when the
278         ctl process exists and when it writes/removes the pid file.
279         This change accounts for the races.
280
281         * Scripts/new-run-webkit-httpd:
282         * Scripts/webkitpy/common/system/executive.py:
283         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
284         * Scripts/webkitpy/layout_tests/port/base.py:
285         * Scripts/webkitpy/layout_tests/port/http_server.py:
286         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
287         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Added.
288         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
289         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
290
291 2011-06-21  Dmitry Lomov  <dslomov@google.com>
292
293         Reviewed by Adam Roben.
294
295         https://bugs.webkit.org/show_bug.cgi?id=63080
296         Unit-tests step on test-only bot is broken.
297         Removing the step until run-api-tests is fixed.
298
299         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
300
301 2011-06-20  Dmitry Lomov  <dslomov@google.com>
302
303         Reviewed by David Levin.
304
305         https://bugs.webkit.org/show_bug.cgi?id=63017
306         "Unit tests" step on bots should provide more information in case of failure.
307
308         * BuildSlaveSupport/build.webkit.org-config/master.cfg: added --verbose flag to UnitTests step.
309
310 2011-06-20  Dirk Pranke  <dpranke@chromium.org>
311
312         Reviewed by Ojan Vafai.
313
314         new-run-webkit-tests: order shards by name, not number of tests
315         https://bugs.webkit.org/show_bug.cgi?id=62753
316
317         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
318
319 2011-06-20  Dirk Pranke  <dpranke@chromium.org>
320
321         Reviewed by Ojan Vafai.
322
323         we should only log the test names to the tests_run.txt files during layout_tests
324         https://bugs.webkit.org/show_bug.cgi?id=62751
325
326         * Scripts/old-run-webkit-tests:
327         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
328
329 2011-06-20  Eric Seidel  <eric@webkit.org>
330
331         Reviewed by Adam Barth.
332
333         commit-queue/ews-bots should run run-bindings-tests for every patch
334         https://bugs.webkit.org/show_bug.cgi?id=63010
335
336         * Scripts/webkitpy/common/config/ports.py:
337         * Scripts/webkitpy/tool/commands/download_unittest.py:
338         * Scripts/webkitpy/tool/steps/runtests.py:
339         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
340         * Scripts/webkitpy/tool/steps/steps_unittest.py:
341
342 2011-06-20  Chang Shu  <cshu@webkit.org>
343
344         Reviewed by Adam Barth.
345
346         fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code tests fail when showModalDialog isn't supported
347         https://bugs.webkit.org/show_bug.cgi?id=53676
348
349         * WebKitTestRunner/TestController.cpp:
350         (WTR::TestController::initialize):
351
352 2011-06-20  Eric Seidel  <eric@webkit.org>
353
354         Reviewed by Adam Barth.
355
356         buildbots should run run-bindings-tests
357         https://bugs.webkit.org/show_bug.cgi?id=63001
358
359         run-bindings-tests takes 2.4 seconds on my machine, so
360         I expect this will not be noticeable on the bots.
361
362         I also removed tiger-specific checks since Tiger is no
363         longer a supported platform for webkit.
364
365         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
366
367 2011-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
368
369         Unreviewed. Fix WebKit2 GTK build after r89249.
370
371         * GtkLauncher/main.c:
372         (main):
373
374 2011-06-20  Pavel Feldman  <pfeldman@chromium.org>
375
376         Reviewed by Yury Semikhatsky.
377
378         Web Inspector: remove LayoutTestController::setTimelineProfilingEnabled.
379         https://bugs.webkit.org/show_bug.cgi?id=62994
380
381         * DumpRenderTree/LayoutTestController.cpp:
382         (closeWebInspectorCallback):
383         (LayoutTestController::staticFunctions):
384         * DumpRenderTree/LayoutTestController.h:
385         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
386         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
387         * DumpRenderTree/chromium/LayoutTestController.cpp:
388         (LayoutTestController::LayoutTestController):
389         * DumpRenderTree/chromium/LayoutTestController.h:
390         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
391         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
392         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
393         * DumpRenderTree/qt/LayoutTestControllerQt.h:
394         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
395         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
396         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
397         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
398         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
399
400 2011-06-20  Lukasz Slachciak  <l.slachciak@samsung.com>
401
402         Reviewed by Martin Robinson.
403
404         [GTK] General mechanism for adjusting WebKitWebSettings in GtkLauncher.
405         https://bugs.webkit.org/show_bug.cgi?id=55308
406
407         * GtkLauncher/main.c: Added general mechanism for adjusting WebKitWebSettings.
408         (parseOptionEntryCallback): Callback for parsing option entry.
409         (getOptionEntriesFromWebKitWebSettings): Basing on the WebKitWebSettings properties prepare
410         list of option entries.
411         (transformStringToBoolean): Transform function for boolean convertion used by parseOptionEntryCallback.
412         (transformStringToInt): Transform function for int convertion used by parseOptionEntryCallback.
413         (transformStringToFloat): Transform function for float convertion used by parseOptionEntryCallback.
414         (parseAdditionalOptions): Help function parsing additional commandline options.
415         (main): Added call to parseAdditionalOptions.
416
417 2011-06-20  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
418
419         Reviewed by Andreas Kling.
420
421         [Qt] [WK2] Compile error in ActivateFontsQt.cpp on Mac
422         https://bugs.webkit.org/show_bug.cgi?id=62869
423
424         Add QFont include to fix "incomlete type QFont" error.
425
426         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
427
428 2011-06-19  Adam Bergkvist  <adam.bergkvist@ericsson.com>
429
430         Reviewed by Martin Robinson.
431
432         [GTK] Enable Media Stream feature and make it default on
433         https://bugs.webkit.org/show_bug.cgi?id=60394
434
435         * Scripts/build-webkit:
436
437 2011-06-19  Sheriff Bot  <webkit.review.bot@gmail.com>
438
439         Unreviewed, rolling out r89198.
440         http://trac.webkit.org/changeset/89198
441         https://bugs.webkit.org/show_bug.cgi?id=62953
442
443         Chromium breakage on "Linux Tests" (Requested by senorblanco
444         on #webkit).
445
446         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
447         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
448         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
449
450 2011-06-18  Daniel Bates  <dbates@webkit.org>
451
452         Reviewed by Eric Seidel.
453
454         Git.push_local_commits_to_server() should use passed username and
455         password when we don't have cached credentials
456         https://bugs.webkit.org/show_bug.cgi?id=62941
457
458         Fixes a issue where Git.push_local_commits_to_server() would always look
459         for cached credentials regardless of whether a username and password
460         were passed as arguments. Instead, if given both a username and password
461         then we shouldn't look for cached credentials (since we were explicitly given
462         credentials).
463
464         * Scripts/webkitpy/common/checkout/scm/git.py:
465         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Added unit tests.
466
467 2011-06-18  Daniel Bates  <dbates@rim.com>
468
469         Rubber-stamped by Eric Seidel.
470
471         Remove run-javascriptcore-tests --skip-build option; Instead add --build/no-build options
472         https://bugs.webkit.org/show_bug.cgi?id=62767
473
474         Part 3 of 3
475
476         Remove the command-line option --skip-build now that the master BuildBot has been restarted
477         following <http://trac.webkit.org/changeset/89138>.
478
479         Instead, specify --no-build to get analogous functionality.
480
481         * Scripts/run-javascriptcore-tests:
482
483 2011-06-18  Dirk Pranke  <dpranke@chromium.org>
484
485         Reviewed by Tony Chang.
486
487         new-run-webkit-tests: fix test sorting
488         https://bugs.webkit.org/show_bug.cgi?id=58691
489
490         This changes the sorting to use a "natural" sort order such that
491         foo2.html sorts before foo13.html, and sorts the tests so
492         that all the tests in a directory are run before any test in a
493         subdirectory.
494
495         This change also adds a split() method to the filesystem since
496         that is needed to cluster files into a directory otherwise.
497
498         * Scripts/webkitpy/common/system/filesystem.py:
499         * Scripts/webkitpy/common/system/filesystem_mock.py:
500         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
501         * Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:
502
503 2011-06-18  Evan Martin  <evan@chromium.org>
504
505         Reviewed by Darin Adler.
506
507         Compiler warning in double->int conversion in TestNetscapePlugIn
508         https://bugs.webkit.org/show_bug.cgi?id=51554
509
510         This code is providing a JS API for removing a property by numeric ID.
511         We get it from JS as a double, and must convert it to an int before using it.
512
513         Test: LayoutTests/plugins/npruntime/remove-property.html
514
515         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:
516         (NPRuntimeRemoveProperty::TestObject::invoke):
517
518 2011-06-18  Patrick Gansterer  <paroga@webkit.org>
519
520         Reviewed by Eric Seidel.
521
522         Don't exit webkit-patch when running on Win32 python
523         https://bugs.webkit.org/show_bug.cgi?id=55811
524
525         Most of the basic actions work in the meantime,
526         so let people play with in on Win32 now.
527
528         * Scripts/webkit-patch:
529
530 2011-06-18  Alice Boxhall  <aboxhall@chromium.org>
531
532         Reviewed by Ojan Vafai.
533
534         Convert json_results_generator.py to output version 4 JSON.
535         https://bugs.webkit.org/show_bug.cgi?id=60869
536
537         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
538         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
539         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
540
541 2011-06-18  Berend-Jan Wever  <skylined@chromium.org>
542
543         Reviewed by Eric Seidel.
544
545         Some names with spaces are incorrectly reported as not containing spaces
546         while running prepare-ChangeLog
547         https://bugs.webkit.org/show_bug.cgi?id=55572
548
549         * Scripts/VCSUtils.pm: Updated CHANGE_LOG_NAME check for spaces to allow
550           non-alphanumeric characters in names.
551
552 2011-06-18  Michael Saboff  <msaboff@apple.com>
553
554         Reviewed by Eric Seidel.
555
556         Enhancement: New Script to Format malloc_history output as tree
557         https://bugs.webkit.org/show_bug.cgi?id=56378
558
559         New script to process malloc_history output to tree format.
560
561         * Scripts/malloc-tree: Added.
562
563 2011-06-17  Dmitry Lomov  <dslomov@google.com>
564
565         Reviewed by Daniel Bates.
566
567         https://bugs.webkit.org/show_bug.cgi?id=62918 
568         Pass configuration to UnitTests step in master.cfg
569
570         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
571
572 2011-06-17  Leandro Pereira  <leandro@profusion.mobi>
573
574         Reviewed by Eric Seidel.
575
576         [EFL] Add Evas-based ImageDiff implementation.
577         https://bugs.webkit.org/show_bug.cgi?id=61942
578
579         Build system changes will be performed as soon as the complete
580         DumpRenderTree implementation is upstreamed.
581
582         * DumpRenderTree/efl/ImageDiff.cpp: Added.
583         (pixelFromImageData):
584         (differenceImageFromDifferenceBuffer):
585         (computeDistanceBetweenPixelComponents):
586         (calculatePixelDifference):
587         (calculateDifference):
588         (getTemporaryFile):
589         (printImage):
590         (printImageDifferences):
591         (resizeEcoreEvasIfNeeded):
592         (readImageFromStdin):
593         (parseCommandLineOptions):
594         (shutdownEfl):
595         (abortWithErrorMessage):
596         (initEfl):
597         (main):
598
599 2011-06-17  Tony Chang  <tony@chromium.org>
600
601         Reviewed by Dirk Pranke.
602
603         [chromium] force rebaseline-chromium-webkit-tests to use the chromium port
604         https://bugs.webkit.org/show_bug.cgi?id=62907
605
606         This fixes a bug where the ImageDiff on the user's machine doesn't
607         match the logic used on the Chromium buildbots.  This has the downside
608         of requiring that the Chromium ImageDiff is built, but it turns out
609         that even with --tolerance 0, the CG ImageDiff will allow small pixel
610         differences through.
611
612         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
613
614 2011-06-17  Brent Fulgham  <bfulgham@webkit.org>
615
616         [WinCairo] Unreviewed build correction.
617
618         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops:
619         Update WinCairo property sheet to link against the Cairo DLL,
620         now that we are using a more recent Cairo build. 
621
622 2011-06-17  Brent Fulgham  <bfulgham@webkit.org>
623
624         Reviewed by Brian Weinstein.
625
626         Create a simple example of using the COM-based C++ listeners.
627         A new onclick event is attached (via C++) to the WebKit logo
628         in the default test pattern displayed on startup.  Clicking on
629         the logo causes a message box to be displayed.
630         https://bugs.webkit.org/show_bug.cgi?id=61885
631
632         * WinLauncher/DOMDefaultImpl.h: Added.  Stub implementation of
633           the WebScriptObject and DOMEventListener.
634         * WinLauncher/WinLauncher.cpp:
635         (SimpleEventListener::SimpleEventListener): Example implementation
636           of a simple DOM event listener.
637         (SimpleEventListener::handleEvent): 
638         (WinLauncherWebHost::didFinishLoadForFrame): Added implementation
639          to bind a C++ method to the 'onclick' event for the WebKit logo.
640         (_tWinMain):
641         * WinLauncher/WinLauncher.h:
642         * WinLauncher/WinLauncher.vcproj: Add new DOMDefaultImpl.h file.
643
644 2011-06-17  Chang Shu  <cshu@webkit.org>
645
646         Reviewed by Andreas Kling.
647
648         [Qt] [WK2] Support undo/redo in MiniBrowser
649         https://bugs.webkit.org/show_bug.cgi?id=62809
650
651         * MiniBrowser/qt/BrowserWindow.cpp:
652         (BrowserWindow::BrowserWindow):
653
654 2011-06-17  Daniel Bates  <dbates@rim.com>
655
656         Rubber-stamped by Eric Seidel.
657
658         Remove run-javascriptcore-tests --skip-build option; Instead add --build/no-build options
659         https://bugs.webkit.org/show_bug.cgi?id=62767
660
661         Part 2 of 3
662
663         Update the BuildBot master.cfg to use the new --no-build run-javascriptcore-tests
664         command line option instead of --skip-build.
665
666         We'll remove --skip-build from run-javascriptcore-test in a follow up patch once the
667         master buildbot picks up the change.
668
669         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
670
671 2011-06-17  Daniel Bates  <dbates@rim.com>
672
673         Rubber-stamped by Eric Seidel.
674
675         Remove run-javascriptcore-tests --skip-build option; Instead add --build/no-build options
676         https://bugs.webkit.org/show_bug.cgi?id=62767
677
678         Part 1 of 3
679
680         Towards renaming the option --skip-build to --no-build. Add --build/--no-build options to
681         run-javascriptcore-tests. Also, add a remark about these options to the usage message
682         printed by run-javascriptcore-tests.
683
684         We'll remove --skip-build in a follow up patch once the master buildbot picks up the changes.
685
686         * Scripts/run-javascriptcore-tests: Additionally, remove unnecessary initialization
687           of $showHelp.
688
689 2011-06-17  Joone Hur  <joone.hur@collabora.co.uk>
690
691         Reviewed by Martin Robinson.
692
693         [GTK] Replace GdkRectangle by cairo_rectangle_int_t
694         https://bugs.webkit.org/show_bug.cgi?id=60687
695
696         Replace GdkRectangle by cairo_rectangle_int_t.
697
698         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Replace GdkRectangle by cairo_rectangle_int_t.
699         (createBitmapContextFromWebView):
700         * DumpRenderTree/gtk/TextInputController.cpp: Ditto.
701         (firstRectForCharacterRangeCallback):
702
703 2011-06-16  Dmitry Lomov  <dslomov@google.com>
704
705         Reviewed by David Levin.
706
707         https://bugs.webkit.org/show_bug.cgi?id=62603
708         Run run-api-tests on bots in debug mode.
709         Release mode is disabled due to https://bugs.webkit.org/show_bug.cgi?id=61812.
710
711         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
712
713 2011-06-16  Leandro Pereira  <leandro@profusion.mobi>
714
715         Reviewed by Eric Seidel.
716
717         [EFL] DumpRenderTree: Add GCController, PixelDumpSupport and
718         WorkQueueItem.
719         They will be plugged into the build system once the EFL's DRT is
720         fully upstreamed.
721         https://bugs.webkit.org/show_bug.cgi?id=61958
722
723         * DumpRenderTree/efl: Added.
724         * DumpRenderTree/efl/GCControllerEfl.cpp: Added.
725         (GCController::collect):
726         (GCController::collectOnAlternateThread):
727         (GCController::getJSObjectCount):
728         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp: Added.
729         (createBitmapContextFromWebView):
730         * DumpRenderTree/efl/WorkQueueItemEfl.cpp: Added.
731         (LoadItem::invoke):
732         (LoadHTMLStringItem::invoke):
733         (ReloadItem::invoke):
734         (ScriptItem::invoke):
735         (BackForwardItem::invoke):
736         * DumpRenderTree/efl/WorkQueueItemEfl.h: Added.
737         (WorkQueueItem::~WorkQueueItem):
738         (LoadItem::LoadItem):
739         (LoadHTMLStringItem::LoadHTMLStringItem):
740         (ScriptItem::ScriptItem):
741         (LoadingScriptItem::LoadingScriptItem):
742         (LoadingScriptItem::invoke):
743         (NonLoadingScriptItem::NonLoadingScriptItem):
744         (NonLoadingScriptItem::invoke):
745         (BackForwardItem::BackForwardItem):
746         (BackItem::BackItem):
747         (ForwardItem::ForwardItem):
748
749 2011-06-16  Kevin Ollivier  <kevino@theolliviers.com>
750
751         [wx] Unreviewed build fix, make sure the waf build checks the webKitBranchBuild
752         preference like the perl scripts do.
753
754         * waf/build/build_utils.py:
755         * waf/build/settings.py:
756
757 2011-06-16  Tommy Widenflycht  <tommyw@google.com>
758
759         Reviewed by Tony Gentilcore.
760
761         MediaStream API: Runtime enabled features
762         https://bugs.webkit.org/show_bug.cgi?id=62798
763
764         Add the WebRuntimeFeatures API for Media Streams and enable the feature by default in DumpRenderTree.
765
766         * DumpRenderTree/chromium/TestShell.cpp:
767         (TestShell::TestShell):
768
769 2011-06-16  Torsten Kurbad  <gentoo@tk-webart.de>
770
771         Reviewed by Eric Seidel.
772
773         Add support for sys.platform == 'linux3' by relaxing
774         conditional statements and/or extending lookup dicts.
775         This way, Linux kernels >=3.0-rc1 get supported in the
776         build process.
777         https://bugs.webkit.org/show_bug.cgi?id=62730
778
779         * Scripts/webkitpy/common/system/executive.py:
780         * Scripts/webkitpy/common/system/file_lock.py:
781         * Scripts/webkitpy/common/system/path_unittest.py:
782         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
783         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
784         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
785         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
786         * Scripts/webkitpy/layout_tests/port/factory.py:
787         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
788         * Scripts/webkitpy/layout_tests/port/qt.py:
789         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
790
791 2011-06-16  Sheriff Bot  <webkit.review.bot@gmail.com>
792
793         Unreviewed, rolling out r88796.
794         http://trac.webkit.org/changeset/88796
795         https://bugs.webkit.org/show_bug.cgi?id=62790
796
797         It made fast/dom/nodesFromRect-basic.html time out on Qt,
798         64-bit, debug mode (Requested by Ossy on #webkit).
799
800         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
801         (LayoutTestController::nodesFromRect):
802         * DumpRenderTree/qt/LayoutTestControllerQt.h:
803         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
804         (PlainTextController::plainText):
805         * DumpRenderTree/qt/PlainTextControllerQt.h:
806
807 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
808
809         Unreviewed, build fix.
810
811         Revert the patches in r88995 and r88999; the http servers don't
812         seem to be shutting down reliably.
813
814         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
815         * Scripts/webkitpy/layout_tests/port/base.py:
816         * Scripts/webkitpy/layout_tests/port/http_server.py:
817         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
818         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
819         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
820         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
821
822 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
823
824         Unreviewed, build fix.
825
826         Add some debugging messages to triage problems introduced in
827         r88995.
828
829         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
830
831 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
832
833         Reviewed by Tony Chang.
834
835         nrwt: should clean up stale server processes from a previous run
836         https://bugs.webkit.org/show_bug.cgi?id=62615
837
838         This change fixes cases where NRWT might start a server and then
839         exit, leaving the server still running. Now NRWT should detect
840         this case and clean up on the next run, without shutting down
841         any processes it didn't start.
842
843         This change also fixes a bug in executive.kill_process on UNIX
844         where zombies weren't being handled properly.
845
846         * Scripts/webkitpy/common/system/executive.py:
847         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
848         * Scripts/webkitpy/layout_tests/port/base.py:
849         * Scripts/webkitpy/layout_tests/port/http_server.py:
850         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
851         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
852         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
853
854 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
855
856         Reviewed by Tony Chang.
857
858         nrwt: fix http, websocket server startup, shutdown
859         https://bugs.webkit.org/show_bug.cgi?id=62180
860
861         This change refactors all of the server-related code to
862         have consistent semantics. It pushes the start()/stop()
863         logic into the base class and adds four much smaller routines
864         for specialization:
865         _prepare_config() - for optionally writing config files etc.
866             to disk prior to starting the server
867         _remove_stale_log_files()
868         _spawn_process() - the actual launch of the subprocess
869         _cleanup_after_stop() - and custom cleanup code
870
871         Prior to this change the three server implementations were
872         fairly inconsistent, leading to lots of weirdness on the bots
873         with servers being left around, etc.
874
875         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
876         * Scripts/webkitpy/layout_tests/port/http_server.py:
877         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
878         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
879
880 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
881
882         Reviewed by Tony Chang.
883
884         webkitpy: clean up code prior to functional changes for server startup/shutdown
885         https://bugs.webkit.org/show_bug.cgi?id=62256
886
887         This patch does a bunch of minor cleanup of the code, but there
888         should be no functional changes except that all of the modules
889         will now use the same exception type. Other changes include
890         removing unused code paths and functions, pushing 'name' and
891         'pid_file' into the base class of the server objects, and using
892         the Filesystem object instead of the codecs, tempfile, and
893         shutils modules.
894
895         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
896         * Scripts/webkitpy/layout_tests/port/http_server.py:
897         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
898         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
899
900 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
901
902         Reviewed by Tony Chang.
903
904         webkitpy: add integration tests for new-run-webkit-httpd, stop calling shut_down_http_server
905         https://bugs.webkit.org/show_bug.cgi?id=62251
906
907         shut_down_http_server() was a total hack that was only used by
908         new-run-webkit-httpd, so I've moved the code there and switched
909         to using executive.kill_process() for the common case. The
910         method itself will be removed in the patch on bug 59993.
911
912         * Scripts/new-run-webkit-httpd:
913         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
914         * Scripts/webkitpy/layout_tests/port/http_server.py:
915         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Added.
916         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
917
918 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
919
920         Unreviewed, build fix.
921
922         Fix test-webkitpy failure introduced in r88986.
923
924         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
925
926 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
927
928         Reviewed by Eric Seidel.
929
930         NRWT: doesn't support webarchives, has stale skipping logic.
931         https://bugs.webkit.org/show_bug.cgi?id=58293
932
933         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
934         * Scripts/webkitpy/layout_tests/port/base.py:
935         * Scripts/webkitpy/layout_tests/port/webkit.py:
936
937 2011-06-15  Jeremy Orlow  <jorlow@webkit.org>
938
939         Change my email to @webkit.org
940
941         * Scripts/webkitpy/common/config/committers.py:
942
943 2011-06-15  Nikolas Zimmermann  <nzimmermann@rim.com>
944
945         Reviewed by David Hyatt.
946
947         CSS 2.1: Support replaced elements with relative intrinsic sizes
948         https://bugs.webkit.org/show_bug.cgi?id=15849
949
950         CSS 2.1 failure: html4/replaced-intrinsic-ratio-001
951         https://bugs.webkit.org/show_bug.cgi?id=53099
952
953         Recognize *.htm tests in the old & new DRT implementation, needed for the vanilla css2.1 html4 tests.
954
955         * Scripts/old-run-webkit-tests:
956         * Scripts/webkitpy/layout_tests/port/test_files.py:
957
958 2011-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
959
960         Reviewed by Martin Robinson.
961
962         [GTK] Add a statusbar to MiniBrowser
963         https://bugs.webkit.org/show_bug.cgi?id=62634
964
965         It shows the url of the current hovered link.
966
967         * MiniBrowser/gtk/BrowserWindow.c:
968         (browserWindowConstructed): Create the GtkSatusbar.
969         (mouseDidMoveOverElement): Update statusbar text.
970         (browserWindowUIClientInit): Add implementation for
971         mouseDidMoveOverElement().
972         * MiniBrowser/gtk/GNUmakefile.am: Add new files to compilation.
973         * MiniBrowser/gtk/WebBundle/WebBundleMain.c: Added.
974         (mouseDidMoveOverElement): Pass the url of the current hovered
975         link to the UI process.
976         (didCreatePage): Set the UI client adding an implementation for
977         mouseDidMoveOverElement().
978         (WKBundleInitialize):
979         * MiniBrowser/gtk/main.c:
980         (createWKContextWithInjectedBundle): Create a global context with
981         the injected bundle.
982         (loadURI): Use the global context.
983         (main):
984
985 2011-06-14  Lucas Forschler  <lforschler@apple.com>
986
987         Reviewed by Stephanie Lewis.
988
989         https://bugs.webkit.org/show_bug.cgi?id=62495
990         Bug 62495 - combine windows and mac kill-old-processes script
991         Add a platform agnostic script.  Remove the recently added mac flavor.
992         Note: Leaving the windows one alone, since it is currently used by the WebKit bots.
993         
994         * BuildSlaveSupport/kill-old-processes: Added.
995         * BuildSlaveSupport/mac: Removed.
996         * BuildSlaveSupport/mac/kill-old-processes: Removed.
997
998 2011-06-14  Dirk Pranke  <dpranke@chromium.org>
999
1000         Reviewed by Tony Chang.
1001
1002         nrwt: handle worker exceptions cleanly
1003         https://bugs.webkit.org/show_bug.cgi?id=62614
1004
1005         This change modifiers new-run-webkit-tests to handle exceptions
1006         raised by worker threads better, by:
1007         - capturing the worker's stack and logging it in the manager
1008         - propagating the worker's exception in the caller correctly
1009         - attempting to cancel the workers and clean up even when
1010           we get an unexpected exception
1011
1012         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
1013         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
1014         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1015         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1016
1017 2011-06-14  Qi Zhang  <qi.2.zhang@nokia.com>
1018
1019         Reviewed by Laszlo Gombos.
1020
1021         [Qt] fast/dom/HTMLScriptElement/nested-execution.html failed
1022         https://bugs.webkit.org/show_bug.cgi?id=62227
1023
1024         QtWebkit does not yet support different CacheModels. This change will 
1025         expose setCacheModel() with a stub implementation, which is enough to pass the LayoutTest.
1026
1027         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1028         (LayoutTestController::setCacheModel):
1029         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1030
1031 2011-06-14  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1032
1033         Reviewed by Andreas Kling.
1034
1035         [Qt] tst_QWebFrame::overloadedSlots() fails
1036         https://bugs.webkit.org/show_bug.cgi?id=37319
1037
1038         Since we don't implictly convert 'document' object to QWebElement
1039         in metacalls anymore, change the controller to expect QVariantMap instead.
1040
1041         The method plainText() was updated to use QVariantMap as well to let the bridge
1042         do the conversion directly for us.
1043
1044         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1045         (LayoutTestController::nodesFromRect):
1046         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1047         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
1048         (PlainTextController::plainText):
1049         * DumpRenderTree/qt/PlainTextControllerQt.h:
1050
1051 2011-06-14  Andras Becsi  <abecsi@webkit.org>
1052
1053         Reviewed by Csaba Osztrogonác.
1054
1055         Remove dead code in DumpRenderTree/TestNetscapePlugIn/main.cpp
1056         https://bugs.webkit.org/show_bug.cgi?id=62630
1057
1058         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1059         (NPP_New): remove dead variable 'forceCarbon'
1060
1061 2011-06-13  Hayato Ito  <hayato@chromium.org>
1062
1063         Reviewed by Ojan Vafai.
1064
1065         [NRWT] Fix a WebKitDriver so that it returns an actual hash value if DRT returns that.
1066         https://bugs.webkit.org/show_bug.cgi?id=59188
1067
1068         A current WebKitDriver doesn't try to return an actual hash value if DRT does not return an image.
1069         WebKitDriver should always return an actual hash value if DRT returns that.
1070
1071         No tests since I'll add sample reftests to make sure mismatch reftests work later,
1072         which should be in a separate patch.
1073
1074         * Scripts/webkitpy/layout_tests/port/webkit.py:
1075
1076 2011-06-13  Kent Tamura  <tkent@chromium.org>
1077
1078         [Chromium-win] Fix two wrong assertions exposed by r88757.
1079
1080         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
1081         (WebThemeEngineDRTWin::paintTrackbar):
1082
1083 2011-06-13  Alexey Proskuryakov  <ap@apple.com>
1084
1085         Added an updated e-mail address for Matt Lilek, to make Bugzilla autocomplete
1086         and commit queue happy.
1087
1088         * Scripts/webkitpy/common/config/committers.py:
1089
1090 2011-06-13  Chris Rogers  <crogers@google.com>
1091
1092         Unreviewed build fix.
1093
1094         Build fix to chromium DRT until we can rebaseline some tests
1095         https://bugs.webkit.org/show_bug.cgi?id=62608
1096
1097         * DumpRenderTree/chromium/TestShell.cpp:
1098         (TestShell::TestShell):
1099
1100 2011-06-13  Chris Rogers  <crogers@google.com>
1101
1102         Reviewed by Dirk Pranke.
1103
1104         Add Web Audio support to chromium DRT
1105         https://bugs.webkit.org/show_bug.cgi?id=62306
1106
1107         * DumpRenderTree/chromium/LayoutTestController.cpp:
1108         (LayoutTestController::LayoutTestController):
1109         (LayoutTestController::reset):
1110         (LayoutTestController::setEncodedAudioData):
1111         * DumpRenderTree/chromium/LayoutTestController.h:
1112         (LayoutTestController::encodedAudioData):
1113         (LayoutTestController::shouldDumpAsAudio):
1114         (LayoutTestController::setShouldDumpAsAudio):
1115         * DumpRenderTree/chromium/TestEventPrinter.cpp:
1116         (DRTPrinter::handleAudioHeader):
1117         (TestShellPrinter::handleAudioHeader):
1118         * DumpRenderTree/chromium/TestEventPrinter.h:
1119         * DumpRenderTree/chromium/TestShell.cpp:
1120         (TestShell::TestShell):
1121         (TestShell::dump):
1122
1123 2011-06-13  Jaehun Lim  <ljaehun.lim@samsung.com>
1124
1125         Reviewed by Eric Seidel.
1126
1127         [EFL] Add load error handler to EWebLauncher
1128         https://bugs.webkit.org/show_bug.cgi?id=62347
1129
1130         Add a handler function of "load,error" to EWebLauncher.
1131         EWebLauncher now displays a simple error page on load errors.
1132
1133         * EWebLauncher/main.c:
1134         (on_load_error):
1135         (browserCreate):
1136
1137 2011-06-13  Martin Robinson  <mrobinson@igalia.com>
1138
1139         Reviewed by Eric Seidel.
1140
1141         [GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
1142         https://bugs.webkit.org/show_bug.cgi?id=62385
1143
1144         Remove duplicate TestNetscapePlugIn implementation. Having two copies
1145         of this code makes keeping it in sync much more difficult. The files are
1146         almost identical and this change ports the X11 changes to main.cpp.
1147
1148         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1149         (NPP_New): Do not set the plugin as windowless always. Doing this breaks
1150         some results on Qt and this seems to be unnecessary for the moment.
1151         (keyEventToChar): Added this helper which converts a X11 keycode into a char.
1152         (handleEventX11): Use the handler to properly convert the keycode. Do not print
1153         adjustCursorEvent output. The tests currently do not trigger this for Cocoa and thus
1154         it should not be in the results.
1155         (NPP_GetValue): Properly handle NPPVpluginNeedsXEmbed and make it clearer why the
1156         XP_UNIX block is first by guarding against using a null instance.
1157         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update source list add
1158         the XP_UNIX define for Linux.
1159         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Removed.
1160         * GNUmakefile.am: Update source list.
1161
1162 2011-06-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1163
1164         Unreviewed, rolling out r88671.
1165         http://trac.webkit.org/changeset/88671
1166         https://bugs.webkit.org/show_bug.cgi?id=62591
1167
1168         "didn't work" (Requested by dpranke on #webkit).
1169
1170         * Scripts/new-run-webkit-httpd:
1171         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1172         * Scripts/webkitpy/layout_tests/port/http_server.py:
1173         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1174         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
1175         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1176         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1177
1178 2011-06-13  Nate Chapin  <japhet@chromium.org>
1179
1180         Reviewed by Darin Fisher.
1181
1182         New test method on TestNetscapePlugin for https://bugs.webkit.org/show_bug.cgi?id=61482.
1183
1184         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1185
1186 2011-06-13  Dirk Pranke  <dpranke@chromium.org>
1187
1188         Reviewed by Tony Chang.
1189
1190         webkitpy: add integration tests for new-run-webkit-httpd, stop calling shut_down_http_server
1191         https://bugs.webkit.org/show_bug.cgi?id=62251
1192
1193         shut_down_http_server() was a total hack that was only used by
1194         new-run-webkit-httpd, so I've moved the code there and switched
1195         to using executive.kill_process() for the common case. The
1196         method itself will be removed in the patch on bug 59993.
1197
1198         * Scripts/new-run-webkit-httpd:
1199         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1200         * Scripts/webkitpy/layout_tests/port/http_server.py:
1201         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Added.
1202         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1203
1204 2011-06-13  Tony Chang  <tony@chromium.org>
1205
1206         Reviewed by Dimitri Glazkov.
1207
1208         rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
1209         https://bugs.webkit.org/show_bug.cgi?id=62578
1210
1211         * Scripts/build-webkit:
1212
1213 2011-06-13  Tony Chang  <tony@chromium.org>
1214
1215         Reviewed by Adam Barth.
1216
1217         rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
1218         https://bugs.webkit.org/show_bug.cgi?id=62545
1219
1220         * Scripts/build-webkit:
1221
1222 2011-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
1223
1224         Reviewed by Martin Robinson.
1225
1226         [GTK] Export an API similar to WebKit1
1227         https://bugs.webkit.org/show_bug.cgi?id=57820
1228
1229         Build GtkLauncher2 for WebKit2. It's actually the same GtkLauncher
1230         code, but linking to libwebkit2gtk.
1231
1232         * GNUmakefile.am:
1233         * GtkLauncher/main.c:
1234         (createBrowser):
1235         (main):
1236
1237 2011-06-12  MORITA Hajime  <morrita@google.com>
1238
1239         Unreviewed, rolling out r88625.
1240         http://trac.webkit.org/changeset/88625
1241         https://bugs.webkit.org/show_bug.cgi?id=61073
1242
1243         Breaks SL Webkit2 Tests
1244
1245         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
1246         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
1247         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
1248         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1249         (WTR::InjectedBundlePage::didClearWindowForFrame):
1250         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1251
1252 2011-06-12  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1253
1254         Reviewed by Antonio Gomes.
1255
1256         [Qt] LayoutTestController needs setTextDirection implementation
1257         https://bugs.webkit.org/show_bug.cgi?id=62442
1258
1259         Implements LayoutController.setTextDirection.
1260
1261         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1262         (LayoutTestController::setTextDirection):
1263         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1264
1265 2011-06-12  Dominic Cooney  <dominicc@chromium.org>
1266
1267         Reviewed by Hajime Morita.
1268
1269         Add window.internals to WebKit2's WebKitTestRunner.
1270         https://bugs.webkit.org/show_bug.cgi?id=61073
1271
1272         Test: fast/harness/internals-object.html
1273
1274         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
1275         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
1276         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
1277         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1278         (WTR::InjectedBundlePage::didClearWindowForFrame): initialize window.internals
1279         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1280
1281 2011-06-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1282
1283         Unreviewed, rolling out r88616.
1284         http://trac.webkit.org/changeset/88616
1285         https://bugs.webkit.org/show_bug.cgi?id=62517
1286
1287         It broke editing/text-iterator/findString.html (Requested by
1288         tonikitoo on #webkit).
1289
1290         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1291         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1292
1293 2011-06-12  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1294
1295         Reviewed by Antonio Gomes.
1296
1297         [Qt] LayoutTestController needs setTextDirection implementation
1298         https://bugs.webkit.org/show_bug.cgi?id=62442
1299
1300         Implements LayoutController.setTextDirection.
1301
1302         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1303         (LayoutTestController::setTextDirection):
1304         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1305
1306 2011-06-10  Ryosuke Niwa  <rniwa@webkit.org>
1307
1308         Reviewed by Ojan Vafai.
1309
1310         new-run-webkit-tests: 'images' links on results.html don't work
1311         https://bugs.webkit.org/show_bug.cgi?id=62194
1312
1313         Use relative path when generating images-diffs.html
1314
1315         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1316         Added _output_testname.
1317
1318 2011-06-10  Lucas Forschler  <lforschler@apple.com>
1319
1320         Reviewed by Stephanie Lewis.
1321
1322         Script to kill old processes on Mac.
1323         This matches the windows version.
1324         https://bugs.webkit.org/show_bug.cgi?id=62479  
1325         
1326         * BuildSlaveSupport/mac: Added.
1327         * BuildSlaveSupport/mac/kill-old-processes: Added.
1328
1329 2011-06-10  Adam Barth  <abarth@webkit.org>
1330
1331         Reviewed by James Robinson.
1332
1333         When sheriffbot reports failures on IRC instead of saying "(and more..)" it should say the number of tests that are failing
1334         https://bugs.webkit.org/show_bug.cgi?id=62489
1335
1336         * Scripts/webkitpy/tool/bot/sheriff.py:
1337         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1338
1339 2011-06-10  Tony Chang  <tony@chromium.org>
1340
1341         Reviewed by Ojan Vafai.
1342
1343         add a compile guard ENABLE(FLEXBOX)
1344         https://bugs.webkit.org/show_bug.cgi?id=62049
1345
1346         * Scripts/build-webkit:
1347
1348 2011-06-10  Mark Rowe  <mrowe@apple.com>
1349
1350         Reviewed by Dimitri Glazkov.
1351
1352         <rdar://problem/9562114> Fix DumpRenderTree build for production configuration.
1353
1354         Ensure that DumpRenderTree can find libWebCoreTestSupport.dylib and the associated
1355         header file.
1356
1357         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1358         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1359
1360 2011-06-09  Csaba Osztrogonác  <ossy@webkit.org>
1361
1362         Unreviewed rolling out r88471, because it broke plugin tests on Qt.
1363
1364         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1365         (handleEventX11):
1366         (NPP_GetValue):
1367         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1368         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Added.
1369         (webkit_test_plugin_new_instance):
1370         (webkit_test_plugin_destroy_instance):
1371         (webkit_test_plugin_set_window):
1372         (executeScript):
1373         (webkit_test_plugin_new_stream):
1374         (webkit_test_plugin_destroy_stream):
1375         (webkit_test_plugin_stream_as_file):
1376         (webkit_test_plugin_write_ready):
1377         (webkit_test_plugin_write):
1378         (webkit_test_plugin_print):
1379         (keyEventToChar):
1380         (webkit_test_plugin_handle_event):
1381         (webkit_test_plugin_url_notify):
1382         (webkit_test_plugin_get_value):
1383         (webkit_test_plugin_set_value):
1384         (NP_GetMIMEDescription):
1385         (NP_Initialize):
1386         (NP_Shutdown):
1387         (NP_GetValue):
1388         * GNUmakefile.am:
1389
1390 2011-06-09  Martin Robinson  <mrobinson@igalia.com>
1391
1392         Reviewed by Eric Seidel.
1393
1394         [GTK] Implement the next bit of the TextInputController (hasMarkedText and markedRange)
1395         https://bugs.webkit.org/show_bug.cgi?id=55603
1396
1397         Add callbacks to support hasMarkedText and markedRange and also clean up existing 
1398         TextInputController support.
1399
1400         * DumpRenderTree/gtk/TextInputController.cpp:
1401         (setMarkedTextCallback): Accept parameters in terms of start and length, instead
1402         of start and end. This matches the other ports. Do not use GLib style early returns.
1403         (hasMarkedTextCallback): Added.
1404         (markedRangeCallback): Added.
1405         (insertTextCallback): Cleanup as described above.
1406         (unmarkTextCallback): Cleanup as described above.
1407         (firstRectForCharacterRangeCallback): Cleanup as described above.
1408         (selectedRangeCallback): Cleanup as described above.
1409
1410 2011-06-09  Dirk Pranke  <dpranke@chromium.org>
1411
1412         Reviewed by Tony Chang.
1413
1414         nrwt: support webaudio in chromium driver
1415         https://bugs.webkit.org/show_bug.cgi?id=62226
1416
1417         * Scripts/webkitpy/layout_tests/port/chromium.py:
1418
1419 2011-06-09  Dan Bernstein  <mitz@apple.com>
1420
1421         Reviewed by Anders Carlsson.
1422
1423         Added a test for Vector::reverse()
1424         https://bugs.webkit.org/show_bug.cgi?id=62393
1425
1426         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1427         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp: Added.
1428         (TestWebKitAPI::TEST):
1429         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1430
1431 2011-06-09  Martin Robinson  <mrobinson@igalia.com>
1432
1433         Reviewed by Andreas Kling.
1434
1435         [GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
1436         https://bugs.webkit.org/show_bug.cgi?id=62385
1437
1438         Remove duplicate TestNetscapePlugIn implementation. Having two copies
1439         of this code makes keeping it in sync much more difficult. The files are
1440         almost identical and this change ports the X11 changes to main.cpp.
1441
1442         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1443         (keyEventToChar): Added this helper which converts a X11 keycode into a char.
1444         (handleEventX11): Use the handler to properly convert the keycode. Do not print
1445         adjustCursorEvent output. The tests currently do not trigger this for Cocoa and thus
1446         it should not be in the results.
1447         (NPP_GetValue): Properly handle NPPVpluginNeedsXEmbed.
1448         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update source list.
1449         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Removed.
1450         * GNUmakefile.am: Update source list.
1451
1452 2011-06-09  Noel Gordon  <noel.gordon@gmail.com>
1453
1454         Reviewed by Tony Chang.
1455
1456         Test plugin should support event logging on the windows port.
1457         https://bugs.webkit.org/show_bug.cgi?id=61721
1458
1459         The WebKit win port interprets a 0 return from plugin NPP_HandleEvent()
1460         calls to mean the plugin handled the event.
1461
1462         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1463         (handleEventWin): Return 0 for each event on windows.
1464
1465 2011-06-09  Chang Shu  <cshu@webkit.org>
1466
1467         Reviewed by Andreas Kling.
1468
1469         [Qt] [WK2] Many editing tests failed on missing shouldBeginEditingInDOMRange:range printout
1470         https://bugs.webkit.org/show_bug.cgi?id=62381
1471
1472         Activate QGraphicsScene and setFocus on QGraphicsItem to make sure the view has the focus.
1473         QWKPagePrivate::isViewFocused() will check it later.
1474
1475         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1476         (WTR::PlatformWebView::PlatformWebView):
1477
1478 2011-06-09  Robert Hogan  <robert@webkit.org>
1479
1480         Reviewed by Andreas Kling.
1481
1482         Teach Qt about window.internals
1483         https://bugs.webkit.org/show_bug.cgi?id=61074
1484
1485         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1486         (WebCore::DumpRenderTree::initJSObjects):
1487
1488 2011-06-09  Eric Seidel  <eric@webkit.org>
1489
1490         Reviewed by Adam Barth.
1491
1492         Disable running layout tests on Mac EWS bots (and fix cr-linux bots to run them again)
1493         https://bugs.webkit.org/show_bug.cgi?id=62362
1494
1495         The mac bots are failing inspector tests.  We don't know why yet.
1496         So for now, turning run-webkit-tests off for the mac-ews.
1497
1498         Also noticed that due to the wrong variable name the cr-linux
1499         bots weren't running tests!
1500
1501         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1502
1503 2011-06-09  Zoltan Herczeg  <zherczeg@inf.u-szeged.hu>
1504
1505         Reviewed by Csaba Osztrogonac.
1506
1507         [Qt][WK2] Canvas tests make css2.1 ones failing
1508         https://bugs.webkit.org/show_bug.cgi?id=53427
1509
1510         Adding a workaround for this issue by mimicing the behaviour of DumpRenderTree.
1511         Since the Qt port should eventually go to QRawFont, this issue will be resolved
1512         in the future. Both clearMemoryCaches() and removeAllApplicationFonts() are
1513         needed for the workaround.
1514
1515         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
1516         (WTR::LayoutTestController::platformInitialize):
1517
1518 2011-06-09  Mario Sanchez Prada  <msanchez@igalia.com>
1519
1520         Reviewed by Chris Fleizach.
1521
1522         [GTK] Provide a way in DRT to check the platform name
1523         https://bugs.webkit.org/show_bug.cgi?id=56855
1524
1525         Patch for adding 'platformName' static property to DRT's
1526         LayoutController and provide platform specific implementations.
1527
1528         In principle, this feature will be only of interest for writing
1529         accessibility tests, so that's why it's only implemented in the
1530         Mac, Gtk and Win platforms.
1531
1532         * DumpRenderTree/LayoutTestController.h: New method platformName().
1533         * DumpRenderTree/LayoutTestController.cpp:
1534         (getPlatformNameCallback): New callback for 'platformName'.
1535         (LayoutTestController::staticValues): New static property.
1536
1537         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1538         (LayoutTestController::platformName): Implemented.
1539
1540         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1541         (LayoutTestController::platformName): Implemented.
1542
1543         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1544         (LayoutTestController::platformName): Implemented.
1545
1546 2011-06-08  Mike Lawther  <mikelawther@chromium.org>
1547
1548         Reviewed by James Robinson.
1549
1550         Add mikelawther to committers.py
1551         https://bugs.webkit.org/show_bug.cgi?id=62354
1552
1553         * Scripts/webkitpy/common/config/committers.py:
1554
1555 2011-06-08  Kent Tamura  <tkent@chromium.org>
1556
1557         [Chromium] Fix a typo.
1558
1559         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
1560         (WebThemeControlDRTWin::draw):
1561
1562 2011-06-08  Kent Tamura  <tkent@chromium.org>
1563
1564         Reviewed by Hajime Morita.
1565
1566         [Chromium] Support vertical sliders in Windows DRT
1567         https://bugs.webkit.org/show_bug.cgi?id=62352
1568
1569         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
1570         (WebThemeControlDRTWin::draw):
1571           Paint VerticalSliderThumbType and VerticalSliderTrackType.
1572         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
1573           Add VerticalSliderTrackType and VerticalSliderThumbType.
1574         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
1575         (WebThemeEngineDRTWin::paintTrackbar):
1576           Convert Windows identifiers to the internal identifiers for vertical sliders.
1577
1578 2011-06-08  Ojan Vafai  <ojan@chromium.org>
1579
1580         Reviewed by Tony Chang.
1581
1582         add a short-flag for --experimental-fully-parallel
1583         https://bugs.webkit.org/show_bug.cgi?id=62321
1584
1585         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1586
1587 2011-06-08  Ryosuke Niwa  <rniwa@webkit.org>
1588
1589         Reviewed by Tony Chang.
1590
1591         new-run-webkit-tests: don't turn the tree red when there are new passes
1592         https://bugs.webkit.org/show_bug.cgi?id=62311
1593
1594         Look for "new passes" instead of "passed unexpectedly" in evaluateCommand
1595         to match commandComplete.
1596
1597         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1598
1599 2011-06-08  Tom Hudson  <tomhudson@google.com>
1600
1601         Reviewed by Mihai Parparita.
1602
1603         Allow sorting in RebaselineServer based on 'metric' field in unexpected_results.json
1604         https://bugs.webkit.org/show_bug.cgi?id=60964
1605
1606         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1607         Add 'Sort tests by metric' link.
1608         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1609         (disableSorting): Activate 'Sort tests by metric' link.
1610         (enableSorting): Deactivate 'Sort tests by metric' link.
1611         (selectDirectory): Call enableSorting()/disableSorting() depending
1612         on currently selected failure type, and sort tests if requested.
1613         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1614         New .disabled-control class for deactivated links.
1615
1616 2011-06-08  Tom Sepez  <tsepez@chromium.org>
1617
1618         Reviewed by Adam Barth.
1619
1620         Add web permissions callbacks for mixed content blocking.
1621         https://bugs.webkit.org/show_bug.cgi?id=61946
1622
1623         * DumpRenderTree/chromium/LayoutTestController.cpp:
1624         (LayoutTestController::setAllowDisplayOfInsecureContent):
1625         (LayoutTestController::setAllowRunningOfInsecureContent):
1626         (LayoutTestController::overridePreference):
1627         * DumpRenderTree/chromium/WebPermissions.cpp:
1628         (WebPermissions::allowDisplayingInsecureContent):
1629         (WebPermissions::allowRunningInsecureContent):
1630         (WebPermissions::setDisplayingInsecureContentAllowed):
1631         (WebPermissions::setRunningInsecureContentAllowed):
1632         (WebPermissions::reset):
1633         * DumpRenderTree/chromium/WebPermissions.h:
1634
1635 2011-06-08  Dirk Pranke  <dpranke@chromium.org>
1636
1637         Reviewed by Tony Chang.
1638
1639         webkitpy: fix typo causing us to skip the port unit tests in chromium_linux
1640         https://bugs.webkit.org/show_bug.cgi?id=62259
1641
1642         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1643
1644 2011-06-08  Ryosuke Niwa  <rniwa@webkit.org>
1645
1646         Reviewed by Tony Chang.
1647
1648         new-run-webkit-tests: master.cfg errors when nrwt successfully runs test
1649         https://bugs.webkit.org/show_bug.cgi?id=62303
1650
1651         Access self.incorrectLayoutLines instead of incorrectLayoutLines in evaluateCommand.
1652
1653         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1654
1655 2011-06-08  Greg Simon  <gregsimon@chromium.org>
1656
1657         Reviewed by Dimitri Glazkov.
1658
1659         Control Indexeddb backends from LayoutTestController
1660         https://bugs.webkit.org/show_bug.cgi?id=61000
1661
1662         * DumpRenderTree/chromium/LayoutTestController.cpp:
1663         (LayoutTestController::LayoutTestController):
1664         (LayoutTestController::setOverrideIndexedDBBackingStore):
1665         (LayoutTestController::clearAllDatabases):
1666         * DumpRenderTree/chromium/LayoutTestController.h:
1667
1668 2011-06-08  Andreas Kling  <kling@webkit.org>
1669
1670         Add Pierre Rossi to contributors list for EZ-CC.
1671
1672         * Scripts/webkitpy/common/config/committers.py:
1673
1674 2011-06-08  Ilya Sherman  <isherman@chromium.org>
1675
1676         Reviewed by Andreas Kling.
1677
1678         Add Ilya Sherman to list of committers
1679         https://bugs.webkit.org/show_bug.cgi?id=62270
1680
1681         * Scripts/webkitpy/common/config/committers.py:
1682
1683 2011-06-07  Ryosuke Niwa  <rniwa@webkit.org>
1684
1685         Reviewed by Tony Chang.
1686
1687         new-run-webkit-tests: Bot master should print useful information on waterfall/console for nrwt
1688         https://bugs.webkit.org/show_bug.cgi?id=62178
1689
1690         Added commandComplete and evaluateCommand for NewRunWebKitTests class
1691         to parse new-run-webkit-tests' results.
1692
1693         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1694
1695 2011-06-07  Dirk Pranke  <dpranke@chromium.org>
1696
1697         Reviewed by Eric Seidel.
1698
1699         webkitpy: add a popen() call to executive
1700         https://bugs.webkit.org/show_bug.cgi?id=62179
1701
1702         This change adds a popen() wrapper call to the Executive object.
1703         This will allow other webkitpy scripts that currently call
1704         subprocess directly to use Executive, instead.
1705
1706         No additional tests are necessary (the existing tests cover the code).
1707
1708         * Scripts/webkitpy/common/system/executive.py:
1709
1710 2011-06-07  Sam Weinig  <sam@webkit.org>
1711
1712         Reviewed by Anders Carlsson.
1713
1714         Remove repeated IPC traffic from SetRenderTreeSize message
1715         https://bugs.webkit.org/show_bug.cgi?id=62244
1716
1717         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1718         (WTR::InjectedBundlePage::InjectedBundlePage):
1719         Add stub for didLayoutForFrame.
1720
1721 2011-06-07  Dirk Pranke  <dpranke@chromium.org>
1722
1723         Reviewed by Tony Chang.
1724
1725         rebaseline-chromium-webkit-tests: fix baselining order for linux, linux_x86_64
1726         https://bugs.webkit.org/show_bug.cgi?id=62241
1727
1728         * Scripts/webkitpy/layout_tests/port/chromium.py:
1729
1730 2011-06-07  Adam Barth  <abarth@webkit.org>
1731
1732         Rubber-stamped by Eric Seidel.
1733
1734         Enable tests on the mac-ews
1735
1736         When we bring the mac-ews back up, we're going to try running tests!
1737
1738         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1739
1740 2011-06-07  Dmitry Lomov  <dslomov@google.com>
1741
1742         Reviewed by David Levin.
1743
1744         https://bugs.webkit.org/show_bug.cgi?id=62215
1745         Allow comparisons with 0 in LIKELY and UNLIKELY macros.
1746
1747         * Scripts/webkitpy/style/checkers/cpp.py:
1748         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1749
1750 2011-06-07  Nico Weber  <thakis@chromium.org>
1751
1752         Reviewed by Dimitri Glazkov.
1753
1754         [chromium] -Wdelete-non-virtual-dtor pass for DumpRenderTree
1755         https://bugs.webkit.org/show_bug.cgi?id=62210
1756
1757         The change to TestEventPrinter fixes a latent bug, because
1758         objects are deleted through the TestEventPrinter type, but none
1759         of the subclasses have destructors or non-POD members.
1760
1761         The changes to NotificationPresenter and WebViewHost do _not_ to fix a
1762         real bug, they just make clang's -Wdelete-non-virtual-dtor happy. As
1763         discussed at http://codereview.chromium.org/7094005/, we prefer making
1764         leaf class destructors virtual over making the leaf classes final.
1765
1766         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1767         (NotificationPresenter::~NotificationPresenter):
1768         * DumpRenderTree/chromium/NotificationPresenter.h:
1769         * DumpRenderTree/chromium/TestEventPrinter.cpp:
1770         (TestEventPrinter::~TestEventPrinter):
1771         * DumpRenderTree/chromium/TestEventPrinter.h:
1772         * DumpRenderTree/chromium/WebViewHost.h:
1773
1774 2011-06-06  Ryosuke Niwa  <rniwa@webkit.org>
1775
1776         Reviewed by Dirk Pranke.
1777
1778         [chromium] Chromium bots on build.webkit.org don't upload results.html
1779         https://bugs.webkit.org/show_bug.cgi?id=61961
1780
1781         Don't fix the path on chromium port erroneously.
1782
1783         * BuildSlaveSupport/test-result-archive:
1784
1785 2011-06-06  Martin Robinson  <mrobinson@igalia.com>
1786
1787         Fix the GTK+ build by ensuring that the autogenerated sources
1788         necessary for libWebCoreInternals are recorded in a predeclared
1789         variable before assigning to BUILT_SOURCES.
1790
1791         * GNUmakefile.am: Predeclare libwebcoreinternals_built_sources.
1792
1793 2011-06-06  Yong Li  <yoli@rim.com>
1794
1795         Reviewed by Eric Seidel.
1796
1797         https://bugs.webkit.org/show_bug.cgi?id=62097
1798         Fix the problem that integral bitfield check incorrectly barked at ?: expressions.
1799
1800         * Scripts/webkitpy/style/checkers/cpp.py:
1801         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1802
1803 2011-06-06  Xan Lopez  <xlopez@igalia.com>
1804
1805         Reviewed by Martin Robinson.
1806
1807         [GTK] Enable feature/symbol detection in NWRT/GTK
1808         https://bugs.webkit.org/show_bug.cgi?id=62136
1809
1810         Disable feature detection through DRT, since we don't support it,
1811         and set the libwebcore patch correctly so that symbol detection
1812         through 'nm' works.
1813
1814         * Scripts/webkitpy/layout_tests/port/gtk.py:
1815
1816 2011-06-06  Shishir Agrawal  <shishir@chromium.org>
1817
1818         Reviewed by Tony Gentilcore.
1819
1820         Add a "prerender" state for page visibility.
1821         https://bugs.webkit.org/show_bug.cgi?id=62062
1822
1823         * DumpRenderTree/chromium/LayoutTestController.cpp:
1824         (LayoutTestController::setPageVisibility):
1825
1826 2011-06-06  Csaba Osztrogonác  <ossy@webkit.org>
1827
1828         [Qt] Implement download feature for QtTestBrowser
1829         https://bugs.webkit.org/show_bug.cgi?id=61865
1830
1831         Buildfix for --minimal and CONFIG+=qt_minimal build after r88161.
1832
1833         * QtTestBrowser/launcherwindow.cpp:
1834         (LauncherWindow::LauncherWindow):
1835         * QtTestBrowser/launcherwindow.h:
1836
1837 2011-06-06  Barát Tibor  <Barat.Tibor@stud.u-szeged.hu>
1838
1839         Reviewed by Csaba Osztrogonác.
1840
1841         [Qt] Implement download feature for QtTestBrowser
1842         https://bugs.webkit.org/show_bug.cgi?id=61865
1843
1844         * QtTestBrowser/launcherwindow.cpp:
1845         (LauncherWindow::LauncherWindow):
1846         (LauncherWindow::downloadRequest):
1847         (LauncherWindow::fileDownloadFinished):
1848         * QtTestBrowser/launcherwindow.h:
1849
1850 2011-06-04  Dominic Cooney  <dominicc@chromium.org>
1851
1852         Reviewed by Dimitri Glazkov.
1853
1854         Make DumpRenderTree initialize window.internals.
1855         https://bugs.webkit.org/show_bug.cgi?id=61076
1856
1857         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: link WebCoreTestSupport.
1858         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1859         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
1860
1861 2011-06-06  Alexandru Chiculita  <achicu@adobe.com>
1862
1863         Reviewed by Kent Tamura.
1864
1865         Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
1866         https://bugs.webkit.org/show_bug.cgi?id=61628
1867
1868         * Scripts/build-webkit:
1869
1870 2011-06-06  Mihnea Ovidenie  <mihnea@adobe.com>
1871
1872         Reviewed by Kent Tamura.
1873
1874         Add ENABLE(CSS_REGIONS) guard for CSS Regions support
1875         https://bugs.webkit.org/show_bug.cgi?id=61631
1876
1877         * Scripts/build-webkit:
1878
1879 2011-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1880
1881         Unreviewed. Fix the GTK+ build.
1882
1883         * GNUmakefile.am: Use javascriptcore_cflags when building libWebCoreInternals.
1884
1885 2011-06-05  Alexey Proskuryakov  <ap@apple.com>
1886
1887         Add an e-mail address for Cameron McCormack that matches Bugzilla (so that auto-completion
1888         works properly).
1889
1890         * Scripts/webkitpy/common/config/committers.py:
1891
1892 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
1893
1894         [wx] Unreviewed build fix. Update git branch build dir handling to match what other
1895         WebKit scripts expect, so other scripts work properly with wx.
1896
1897         * waf/build/build_utils.py:
1898         * waf/build/settings.py:
1899
1900 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
1901
1902         [wx] Unreviewed build fix. Restore the PPC build and allow users to specify architectures
1903         to build on Mac.
1904
1905         * waf/build/settings.py:
1906         * wx/install-unix-extras:
1907
1908 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
1909
1910         [wx] Unreviewed build fixes for recent trunk changes.
1911
1912         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1913         (LayoutTestController::setTextDirection):
1914         * waf/build/settings.py:
1915
1916 2011-06-04  Martin Robinson  <mrobinson@igalia.com>
1917
1918         Fix the GTK+ build.
1919
1920         * GNUmakefile.am: Add some missing newline escape.
1921
1922 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
1923
1924         Try to fix the GTK+ bulid.
1925
1926         * GNUmakefile.am: Add JSDOMWrapper.cpp to the libWebCoreInternals
1927         source list.
1928
1929 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
1930
1931         Reviewed by Adam Barth.
1932
1933         nrwt: should skip chromium test expectation overrides on upstream bots
1934         https://bugs.webkit.org/show_bug.cgi?id=61888
1935
1936         * Scripts/webkitpy/layout_tests/port/chromium.py:
1937         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1938
1939 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
1940
1941         Reviewed by Ojan Vafai.
1942
1943         new-run-webkit-tests: minor logging, code cleanup
1944         https://bugs.webkit.org/show_bug.cgi?id=62055
1945
1946         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
1947         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
1948
1949 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
1950
1951         Try to fix the build failure on the GTK+ 32-bit Release bot.
1952
1953         * GNUmakefile.am: Add JSInternal.{cpp,h} to the BUILT_SOURCES list.
1954
1955 2011-05-31  Martin Robinson  <mrobinson@igalia.com>
1956
1957         Reviewed by Ryosuke Niwa.
1958
1959         [GTK] Support smart replace for the pasteboard
1960         https://bugs.webkit.org/show_bug.cgi?id=61734
1961
1962         Call into the DumpRenderTreeSupportGtk hooks to toggle smart replace.
1963         This is required to produce consistent test results.
1964
1965         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1966         (resetDefaultsToConsistentValues): Set the smart replace setting to on by default.
1967         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1968         (LayoutTestController::setSmartInsertDeleteEnabled): Added an implementation of this
1969         methods which calls into DumpRenderTreeSupportGtk.
1970
1971 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
1972
1973         Reviewed by Dimitri Glazkov.
1974
1975         Teach Gtk build about window.internals
1976         https://bugs.webkit.org/show_bug.cgi?id=61071
1977
1978         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1979         (webViewWindowObjectCleared): Inject the new internals object when the
1980         window object clears.
1981         * GNUmakefile.am: Add new source files and includes necessary for window.internals.
1982         Also do a little bit of cleanup.
1983
1984 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
1985
1986         Reviewed by Tony Chang.
1987
1988         Worker may not be stopped after LT.
1989         https://bugs.webkit.org/show_bug.cgi?id=61847
1990
1991         Re-submit a variant of the first fix for this bug. It's possible
1992         that actually calling cleanup() in the worker threads was taking
1993         too long and we triggered the assertions in the manager thread.
1994
1995         I've bumped up the timeout in the manager and added better
1996         diagnostics. I also cleaned up the cleanup() code a bit because
1997         there was some unnecessary if-checks.
1998
1999         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2000         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
2001
2002 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
2003
2004         Reviewed by Tony Chang.
2005
2006         nrwt: fix duplicate logging regression
2007         https://bugs.webkit.org/show_bug.cgi?id=61981
2008
2009         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2010
2011 2011-06-03  Robert Kroeger  <rjkroege@chromium.org>
2012
2013         Reviewed by Adam Barth.
2014
2015         Modified addTouchPoint to correctly re-use touchPoint id values starting
2016         from the lowest not-un-use touchPoint id as is done by the embedder
2017         APIs. (Fixes BUGCR36415)
2018
2019         https://bugs.webkit.org/show_bug.cgi?id=62016
2020
2021         * DumpRenderTree/chromium/EventSender.cpp:
2022         (EventSender::addTouchPoint):
2023
2024 2011-06-03  Cary Clark  <caryclark@google.com>
2025
2026         Reviewed by Eric Seidel.
2027
2028         Draw DRT scroll bar thumb with CG when WebKit renders with Skia
2029         https://bugs.webkit.org/show_bug.cgi?id=61534
2030
2031         Skia on Mac uses Skia to render WebKit, and CG
2032         to render UI elements. The CG elements need a
2033         transcribed graphics context that preserves the
2034         canvas matrix, and the canvas clip.
2035
2036         The SkiaBitLocker utility class sets up a CGContext
2037         from the SkCanvas, locks the bitmap's bits, and
2038         releases the lock when the class goes out of scope.
2039
2040         The SkiaBitLocker implementation is described by
2041         this patch:
2042         http://codereview.chromium.org/7031006/
2043
2044         When WebKit uses Skia for rendering, the WebCanvas
2045         is an SkCanvas. Create an equivalent CGContext to
2046         draw the scrollbar thumb.
2047
2048         As the Chrome Mac port does not yet use Skia, this
2049         patch has no effect and requires no tests.
2050
2051         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2052         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2053
2054 2011-06-03  Andras Becsi  <abecsi@webkit.org>
2055
2056         Unreviewed build fix.
2057
2058         Fix typo.
2059
2060         * Scripts/old-run-webkit-tests:
2061
2062 2011-06-03  Andras Becsi  <abecsi@webkit.org>
2063
2064         Reviewed by Csaba Osztrogonác.
2065
2066         Print error message when there is no httpd present on the system
2067         https://bugs.webkit.org/show_bug.cgi?id=61939
2068
2069         * Scripts/old-run-webkit-tests: Propose to run with --no-httpd.
2070         * Scripts/webkitperl/httpd.pm:
2071
2072 2011-06-03  Mikhail Naganov  <mnaganov@chromium.org>
2073
2074         Reviewed by Yury Semikhatsky.
2075
2076         Web Inspector: [Chromium] cpu-profiler-profiling layout test is flaky on Linux Debug.
2077         https://bugs.webkit.org/show_bug.cgi?id=61533
2078
2079         Skip cpu-profiler-profiling in debug, implement a fast headless alternative.
2080
2081         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2082         (DRTDevToolsAgent::setJavaScriptProfilingEnabled):
2083         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2084         * DumpRenderTree/chromium/LayoutTestController.cpp:
2085         (LayoutTestController::LayoutTestController):
2086         (LayoutTestController::setJavaScriptProfilingEnabled):
2087         * DumpRenderTree/chromium/LayoutTestController.h:
2088         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2089         (LayoutTestController::setJavaScriptProfilingEnabled):
2090         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2091         (WTR::LayoutTestController::setJavaScriptProfilingEnabled):
2092         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2093
2094 2011-06-02  Dirk Pranke  <dpranke@chromium.org>
2095
2096         Reviewed by Tony Chang.
2097
2098         NRWT needs a way to log to a file without including backspaces without needing --verbose
2099         https://bugs.webkit.org/show_bug.cgi?id=60328
2100
2101         This change modifies NRWT so that if it can tell if it is
2102         writing to a terminal, it will overwrite any messages printed
2103         in the 'one-line-progress' and 'updates' print options, and if
2104         not (or if --verbose was specified) the messages will be printed
2105         without backspaces.
2106
2107         If the overwriting updates are disabled, one-line-progress will
2108         only print every 10 seconds instead of on every update. This
2109         ensures that we still get updates once in a while while the
2110         tests are running, even if we're not in --verbose mode. Note
2111         that one-line-progress will now still be printed in --verbose,
2112         since it's useful as long as you're not flooded with the
2113         updates.
2114
2115         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2116         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2117         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2118
2119 2011-06-02  Martin Robinson  <mrobinson@igalia.com>
2120
2121         Reviewed by Gustavo Noronha Silva.
2122
2123         [GTK] autogen.sh is run twice for each buld on the bots
2124         https://bugs.webkit.org/show_bug.cgi?id=61951
2125
2126         * Scripts/webkitdirs.pm: Only check the previous autotools arguments
2127         for the WebKit project. This prevents build-jsc runs from forcing subsequent
2128         build-webkit runs to re-rerun autogen.sh.
2129
2130 2011-06-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2131
2132         Unreviewed, rolling out r87946.
2133         http://trac.webkit.org/changeset/87946
2134         https://bugs.webkit.org/show_bug.cgi?id=61965
2135
2136         Cause NRWT to break (Requested by abarth|gardener on #webkit).
2137
2138         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
2139
2140 2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
2141
2142         Reviewed by Darin Adler.
2143
2144         Add build logistics and plumbing for window.internals object.
2145         https://bugs.webkit.org/show_bug.cgi?id=60313
2146
2147         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
2148         * DumpRenderTree/chromium/TestShell.cpp:
2149         (TestShell::bindJSObjectsToWindow): Added injection code.
2150         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2151         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
2152
2153 2011-06-02  Hao Zheng  <zhenghao@chromium.org>
2154
2155         Reviewed by Dirk Pranke.
2156
2157         Call cleanup() explicitly at the end of worker.run().
2158         https://bugs.webkit.org/show_bug.cgi?id=61847
2159
2160         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
2161
2162 2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
2163
2164         Unreviewed, rolling out r87926.
2165         http://trac.webkit.org/changeset/87926
2166         https://bugs.webkit.org/show_bug.cgi?id=60313
2167
2168         Fails to find WebCoreTestSupport.dylib on bots.
2169
2170         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2171         * DumpRenderTree/chromium/TestShell.cpp:
2172         (TestShell::bindJSObjectsToWindow):
2173         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2174         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
2175
2176 2011-05-21  Dimitri Glazkov  <dglazkov@chromium.org>
2177
2178         Reviewed by Darin Adler.
2179
2180         Add build logistics and plumbing for window.internals object.
2181         https://bugs.webkit.org/show_bug.cgi?id=60313
2182
2183         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
2184         * DumpRenderTree/chromium/TestShell.cpp:
2185         (TestShell::bindJSObjectsToWindow): Added injection code.
2186         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2187         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
2188
2189 2011-06-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2190
2191         Reviewed by Eric Seidel.
2192
2193         Adjust efl coding style to more efl directories
2194         https://bugs.webkit.org/show_bug.cgi?id=61903
2195
2196         * Scripts/webkitpy/style/checker.py: Adjust efl coding style to efl directories.
2197
2198 2011-06-01  Dirk Pranke  <dpranke@chromium.org>
2199
2200         Reviewed by Tony Chang.
2201
2202         old-run-webkit-tests: add support for audio files
2203         https://bugs.webkit.org/show_bug.cgi?id=57992
2204
2205         * Scripts/old-run-webkit-tests:
2206
2207 2011-06-01  Jochen Eisinger  <jochen@chromium.org>
2208
2209         Reviewed by Adam Barth.
2210
2211         Implement layoutTestController.setImagesAllowed for controlling the respective behavior of the WebPermissionClient
2212         https://bugs.webkit.org/show_bug.cgi?id=34314
2213
2214         * DumpRenderTree/DumpRenderTree.gypi:
2215         * DumpRenderTree/chromium/LayoutTestController.cpp:
2216         (LayoutTestController::LayoutTestController):
2217         (LayoutTestController::setImagesAllowed):
2218         (LayoutTestController::setStorageAllowed):
2219         * DumpRenderTree/chromium/LayoutTestController.h:
2220         * DumpRenderTree/chromium/WebPermissions.cpp: Copied from Tools/DumpRenderTree/chromium/WebPermissions.h.
2221         (WebPermissions::WebPermissions):
2222         (WebPermissions::~WebPermissions):
2223         (WebPermissions::allowImages):
2224         (WebPermissions::allowStorage):
2225         (WebPermissions::setImagesAllowed):
2226         (WebPermissions::setStorageAllowed):
2227         (WebPermissions::reset):
2228         * DumpRenderTree/chromium/WebPermissions.h:
2229
2230 2011-06-01  Noel Gordon  <noel.gordon@gmail.com>
2231
2232         Reviewed by Tony Chang.
2233
2234         Test plugin should support event logging on the windows port.
2235         https://bugs.webkit.org/show_bug.cgi?id=61721
2236
2237         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2238         (handleEventWin): Well, handle them.
2239
2240 2011-06-01  Daniel Cheng  <dcheng@chromium.org>
2241
2242         Reviewed by Tony Chang.
2243
2244         [chromium] Use correct file name for dragging out images.
2245         https://bugs.webkit.org/show_bug.cgi?id=24887
2246
2247         * DumpRenderTree/chromium/EventSender.cpp:
2248         (EventSender::EventSender):
2249         (EventSender::dumpFilenameBeingDragged):
2250         * DumpRenderTree/chromium/EventSender.h:
2251
2252 2011-06-01  Dirk Pranke  <dpranke@chromium.org>
2253
2254         Reviewed by Tony Chang.
2255
2256         nrwt: make webaudio work w/o content-length header
2257         https://bugs.webkit.org/show_bug.cgi?id=61819
2258
2259         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2260         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
2261         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2262         * Scripts/webkitpy/layout_tests/port/webkit.py:
2263
2264 2011-06-01  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
2265
2266         Reviewed by Andreas Kling.
2267
2268         [Qt][WK2] Add QGLWidget viewport support to MiniBrowser
2269         https://bugs.webkit.org/show_bug.cgi?id=61802
2270
2271         Add command line parameter and menu item to MiniBrowser application 
2272         enabling use of QGLWidget for browser viewport.
2273
2274         * MiniBrowser/qt/BrowserWindow.cpp:
2275         (BrowserWindow::BrowserWindow):
2276         (BrowserWindow::toggleGLViewport):
2277         * MiniBrowser/qt/BrowserWindow.h:
2278         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2279         (MiniBrowserApplication::handleUserOptions):
2280         * MiniBrowser/qt/MiniBrowserApplication.h:
2281         (WindowOptions::WindowOptions):
2282
2283 2011-06-01  Martin Robinson  <mrobinson@igalia.com>
2284
2285         Reviewed by Xan Lopez.
2286
2287         Print out autogen arguments when they differ from the last set, to help
2288         with debugging build issues.
2289
2290         * Scripts/webkitdirs.pm: Print out previous and current build arguments
2291         when they differ.
2292
2293 2011-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2294
2295         Reviewed by Martin Robinson.
2296
2297         [GTK] run-launcher should run MiniBrowser in WebKit2
2298         https://bugs.webkit.org/show_bug.cgi?id=61858
2299
2300         * Scripts/run-launcher: Check whether -2 command line option has
2301         been passed and run MiniBrowser instead of GtkLauncher.
2302
2303 2011-05-31  Hao Zheng  <zhenghao@chromium.org>
2304
2305         Reviewed by Dirk Pranke.
2306
2307         Fix exception in verbose printing mode.
2308         https://bugs.webkit.org/show_bug.cgi?id=61723
2309
2310         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2311
2312 2011-05-31  Yong Li  <yoli@rim.com>
2313
2314         Reviewed by Eric Seidel.
2315
2316         https://bugs.webkit.org/show_bug.cgi?id=54807
2317         We have been assuming plain bitfields (like "int a : 31") are always signed integers.
2318         However some compilers can treat them as unsigned. For example, RVCT 4.0 states plain
2319         bitfields (declared without either signed or unsigned qualifiers) are treats as unsigned.
2320         http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0348c/Babjddhe.html
2321         Although we can use "--signed-bitfields" flag to make RVCT 4.0 behave as most other compilers,
2322         always using "signed"/"unsigned" qualifier to declare integral type bitfields is still a good
2323         rule we should have in order to make our code independent from compilers and compiler flags.
2324
2325         * Scripts/webkitpy/style/checkers/cpp.py:
2326
2327 2011-05-31  Hironori Bono  <hbono@chromium.org>
2328
2329         Reviewed by Eric Seidel.
2330
2331         Add a JavaScript function layoutTestController.setTextDirection().
2332         https://bugs.webkit.org/show_bug.cgi?id=50952
2333
2334         This change adds a new JavaScript function setTextDirection() to the
2335         LayoutTestController class of Safari and Chrome to write layout tests
2336         that changes the text direction of an editable element.
2337
2338         * DumpRenderTree/LayoutTestController.cpp:
2339         (setTextDirectionCallback):
2340         (LayoutTestController::staticFunctions):
2341         * DumpRenderTree/LayoutTestController.h:
2342         * DumpRenderTree/chromium/LayoutTestController.cpp:
2343         (LayoutTestController::LayoutTestController):
2344         (LayoutTestController::setTextDirection):
2345         * DumpRenderTree/chromium/LayoutTestController.h:
2346         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2347         (LayoutTestController::setTextDirection):
2348         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2349         (LayoutTestController::setTextDirection):
2350         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2351         (LayoutTestController::setTextDirection):
2352
2353 2011-05-31  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
2354
2355         Reviewed by Simon Hausmann.
2356
2357         [Qt] User-agent list of Qt test browsers is very outdated
2358         https://bugs.webkit.org/show_bug.cgi?id=61531
2359
2360         The user can edit the user-agent manually, so there's no need to have
2361         a super complete and up to date list, but it's nice to have it
2362         minimally updated.
2363
2364         * MiniBrowser/qt/useragentlist.txt:
2365         * QtTestBrowser/useragentlist.txt:
2366
2367 2011-03-30  Martin Robinson  <mrobinson@igalia.com>
2368
2369         Reviewed by Adam Roben.
2370
2371         [GTK] [WebKit2] Implement a basic WebKitTestRunner
2372         https://bugs.webkit.org/show_bug.cgi?id=57068
2373
2374         Add an implementation of WebKitTestRunner for GTK+.
2375
2376         * Scripts/build-webkittestrunner: Added knowledge of GTK+ TestRunner.
2377         * Scripts/old-run-webkit-tests: Ditto.
2378         * Scripts/run-launcher: Ditto.
2379         * Scripts/webkitdirs.pm: Ditto.
2380         * WebKitTestRunner/GNUmakefile.am: Added.
2381         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2382         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp: Added.
2383         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
2384         * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
2385         * WebKitTestRunner/PlatformWebView.h:
2386         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Added.
2387         * WebKitTestRunner/gtk/TestControllerGtk.cpp: Added.
2388         * WebKitTestRunner/gtk/TestInvocationGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
2389         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2390         * WebKitTestRunner/gtk/main.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
2391         (main): Added.
2392
2393 2011-05-31  Dirk Pranke  <dpranke@chromium.org>
2394
2395         Reviewed by Tony Chang.
2396
2397         new-run-webkit-tests: doesn't wait for children if it gets a ctrl-c
2398         https://bugs.webkit.org/show_bug.cgi?id=60241
2399
2400         * Scripts/new-run-webkit-tests:
2401
2402 2011-05-31  Eric Seidel  <eric@webkit.org>
2403
2404         Reviewed by David Kilzer.
2405
2406         webkitpy should create zips with zip -9
2407         https://bugs.webkit.org/show_bug.cgi?id=61789
2408
2409         Dave Kilzer suggested we add this to make zips uploaded to bugzilla smaller.
2410
2411         * Scripts/webkitpy/common/system/workspace.py:
2412         * Scripts/webkitpy/common/system/workspace_unittest.py:
2413
2414 2011-05-31  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
2415
2416         Reviewed by Csaba Osztrogonác.
2417
2418         [Qt] Implement find feature for QtTestBrowser
2419         https://bugs.webkit.org/show_bug.cgi?id=61425
2420
2421         Buildfix for --minimal and CONFIG+=qt_minimal build.
2422
2423         * QtTestBrowser/launcherwindow.cpp:
2424         (LauncherWindow::LauncherWindow):
2425         (LauncherWindow::createChrome):
2426         * QtTestBrowser/launcherwindow.h:
2427
2428 2011-05-31  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
2429
2430         Reviewed by Csaba Osztrogonác.
2431
2432         [Qt] Implement find feature for QtTestBrowser
2433         https://bugs.webkit.org/show_bug.cgi?id=61425
2434
2435         * QtTestBrowser/launcherwindow.cpp:
2436         (LauncherWindow::LauncherWindow):
2437         (LauncherWindow::createChrome):
2438         (LauncherWindow::showFindBar):
2439         (LauncherWindow::find):
2440         * QtTestBrowser/launcherwindow.h:
2441
2442 2011-05-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2443
2444         Reviewed by Martin Robinson.
2445
2446         [GTK] Implement JavaScript dialogs in MiniBrowser
2447         https://bugs.webkit.org/show_bug.cgi?id=61725
2448
2449         * MiniBrowser/gtk/BrowserWindow.c:
2450         (WKStringGetCString): Helper function to get a UTF-8 c string from
2451         a WKStringRef.
2452         (WKURLGetCString): Helper function to get a UTF-8 c string from a
2453         WKURLRef.
2454         (browserWindowUpdateURL): Update to use WKURLGetCString.
2455         (didReceiveTitleForFrame): Update to use WKStringGetCString.
2456         (createMessageDialog): Create a GtkMessageDialog.
2457         (runJavaScriptAlert):
2458         (runJavaScriptConfirm):
2459         (runJavaScriptPrompt):
2460         (browserWindowUIClientInit):
2461
2462 2011-05-29  Yuta Kitamura  <yutak@chromium.org>
2463
2464         Reviewed by Kent Tamura.
2465
2466         WebSocket closing handshake
2467         https://bugs.webkit.org/show_bug.cgi?id=35721
2468
2469         * Scripts/webkitpy/thirdparty/__init__.py:
2470         Pull in pywebsocket 0.6b1. We need to update pywebsocket
2471         to get the right behavior of closing handshake.
2472
2473 2011-05-29  Daniel Bates  <dbates@rim.com>
2474
2475         Reviewed by David Kilzer.
2476
2477         REGRESSION (r86515): svn-apply ignores diffs that omit line count in chunk range
2478         https://bugs.webkit.org/show_bug.cgi?id=61162
2479
2480         Fixes an issue where svn-apply may ignore a diff that contains a chunk range line
2481         that omits a line count. In particular, the chunk range regular expression does
2482         not match a chunk range line that omits a line count. GNU diff(1) will omit the
2483         line count in the chunk range if the line count is exactly 1. For example, appending
2484         a new line to the end of an existing file F that contains exactly one line of text will
2485         be represented in a diff with a chunk range line that omits the line count for F.
2486
2487         * Scripts/VCSUtils.pm:
2488           (parseChunkRange): Added.
2489         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl: Added.
2490         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
2491           - Added unit test "Git: Append new line to the end of an existing file".
2492
2493 2011-05-28  Adam Barth  <abarth@webkit.org>
2494
2495         Reviewed by Eric Seidel.
2496
2497         EWS builds patches that fail to build twice, which seems useless and slows down the bots
2498         https://bugs.webkit.org/show_bug.cgi?id=55585
2499
2500         This patch switches all the early warning system bots over to the new
2501         PatchAnalysisTask-based infrastructure.  This patch makes these bots
2502         more efficient (in the case where patches fail to build) and paves the
2503         way for running tests on these bots!
2504
2505         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2506         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
2507         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2508         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2509         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2510         * Scripts/webkitpy/tool/commands/queues.py:
2511
2512 2011-05-28  Kenichi Ishibashi  <bashi@chromium.org>
2513
2514         Reviewed by Kent Tamura.
2515
2516         Add bashi as a committer.
2517
2518         https://bugs.webkit.org/show_bug.cgi?id=61685
2519
2520         * Scripts/webkitpy/common/config/committers.py:
2521
2522 2011-05-27  Adam Barth  <abarth@webkit.org>
2523
2524         Reviewed by Eric Seidel.
2525
2526         When checking whether the tree is red, the EWS posts a link to the wrong log
2527         https://bugs.webkit.org/show_bug.cgi?id=61072
2528
2529         We need to cache the original script error because that contains the
2530         failure log we want to upload.  If we don't cache that script error,
2531         self._script_error will get overwritten when we sanity check the clean
2532         tree (and it also has test failures).
2533
2534         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2535             - This testing approach is slightly goofy.  We'd like to use
2536               assertRaisesRegexp, but that's not available until Python 2.7.
2537         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2538
2539 2011-05-27  Jochen Eisinger  <jochen@chromium.org>
2540
2541         Reviewed by Adam Barth.
2542
2543         Add layoutTestController.setStorageAllowed() to control whether access
2544         to the localStorage API is enabled via the WebPermissionClient
2545         https://bugs.webkit.org/show_bug.cgi?id=61581
2546
2547         * DumpRenderTree/chromium/LayoutTestController.cpp:
2548         (LayoutTestController::LayoutTestController):
2549         (LayoutTestController::setStorageAllowed):
2550         * DumpRenderTree/chromium/LayoutTestController.h:
2551         * DumpRenderTree/chromium/TestShell.cpp:
2552         (TestShell::TestShell):
2553         (TestShell::createNewWindow):
2554         * DumpRenderTree/chromium/TestShell.h:
2555         * DumpRenderTree/chromium/WebPermissions.h: Added.
2556         (WebPermissions::WebPermissions):
2557         (WebPermissions::allowStorage):
2558         (WebPermissions::setStorageAllowed):
2559         (WebPermissions::reset):
2560
2561 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
2562
2563         Reviewed by Eric Seidel.
2564
2565         NRWT: clean up metered_stream code in preparation for 'nooverwriting' patch
2566         https://bugs.webkit.org/show_bug.cgi?id=60326
2567
2568         This patch removes a lot of the complexity from the
2569         metered_stream implementation that was unnecessary since there
2570         was only one caller and the logic could be coordinated better.
2571
2572         There should be no functional changes in this patch, just code
2573         getting deleted and cleaned up.
2574
2575         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
2576         * Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py:
2577         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2578         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2579
2580 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
2581
2582         Reviewed by Eric Seidel.
2583
2584         NRWT: minor cleanup in printing module
2585         https://bugs.webkit.org/show_bug.cgi?id=60329
2586
2587         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2588
2589 2011-05-27  Steve Lacey  <sjl@chromium.org>
2590
2591         Reviewed by David Levin.
2592
2593         Add sjl@chromium.org as a committer.
2594
2595         https://bugs.webkit.org/show_bug.cgi?id=61672
2596
2597         * Scripts/webkitpy/common/config/committers.py:
2598
2599 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
2600
2601         Reviewed by Adam Barth.
2602
2603         NRWT: remove --print detailed-progress
2604         https://bugs.webkit.org/show_bug.cgi?id=60324
2605
2606         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
2607         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2608         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2609         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2610
2611 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
2612
2613         Reviewed by Ojan Vafai.
2614
2615         NRWT: debug messages from the workers are being logged twice
2616         https://bugs.webkit.org/show_bug.cgi?id=60428
2617
2618         It looks like when the workers are run in separate processes
2619         we end up getting two copies of every log message they print.
2620         This has to do with the multiprocessing module on UNIX cloning
2621         the log configuration in a way I wasn't expecting, and so two
2622         log handlers end up getting registered.
2623
2624         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
2625         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2626         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2627         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2628
2629 2011-05-27  Adam Roben  <aroben@apple.com>
2630
2631         Always decode tester names from location.hash
2632
2633         When navigating directly to a tester-specific URL (e.g.,
2634         <http://build.webkit.org/TestFailures/#/Windows%207%20Release%20(Tests)>), you could end up
2635         with a URL-encoded tester name in the page, and then the encoded name could make its way
2636         into Bugzilla bugs. Bad!
2637
2638         Reviewed by David Kilzer.
2639
2640         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
2641         (ViewController.prototype.parseHash): Pass the tester name we got from location.hash through
2642         decodeURIComponent before trying to use it.
2643
2644 2011-05-27  Adam Roben  <aroben@apple.com>
2645
2646         Remove testing code that snuck into r87528
2647
2648         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
2649         (ViewController.prototype._domForNewBugLink): Remove a line I was using for some testing.
2650
2651 2011-05-27  Adam Roben  <aroben@apple.com>
2652
2653         Add links to TestFailures to easily file bugs about failing tests
2654
2655         Fixes <http://webkit.org/b/61636> <rdar://problem/9514886> TestFailures page should have
2656         links to file bugs for failing tests
2657
2658         Reviewed by David Kilzer.
2659
2660         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
2661         (Builder.prototype.resultsPageURL): New helper function to return the URL to results.html
2662         for a particular build.
2663         (Builder.prototype._getFailingTests): Use resultsPageURL.
2664
2665         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
2666         (ViewController.prototype._displayBuilder): Add links to file bugs about each set of
2667         failures.
2668         (ViewController.prototype._domForBuildName): Use resultsPageURL.
2669         (ViewController.prototype._domForNewBugLink): Added. Creates an element that represents the
2670         new bug link. The bug has a title, description, and URL already filled in for you!
2671
2672 2011-05-27  Sheriff Bot  <webkit.review.bot@gmail.com>
2673
2674         Unreviewed, rolling out r87464.
2675         http://trac.webkit.org/changeset/87464
2676         https://bugs.webkit.org/show_bug.cgi?id=61643
2677
2678         client-close/server-close tests are flaky on Chromium Mac and
2679         Windows (Requested by aklein on #webkit).
2680
2681         * Scripts/webkitpy/thirdparty/__init__.py:
2682
2683 2011-05-27  Alexey Proskuryakov  <ap@apple.com>
2684
2685         Added Douglas Davidson to contributors list for easier CC'ing.
2686
2687         * Scripts/webkitpy/common/config/committers.py:
2688
2689 2011-05-26  Mihai Parparita  <mihaip@chromium.org>
2690
2691         Reviewed by Adam Barth.
2692
2693         Fix worldID and destinationDomain argument names
2694         https://bugs.webkit.org/show_bug.cgi?id=61571
2695
2696         As part of working on r87423, I noticed a couple of inconsistencies in
2697         argument names:
2698         - We would use worldId in .h files but worldID in .cpp files.
2699           Standardize on the latter
2700         - SecurityOrigin::addOriginAccessWhitelistEntry would take a
2701           destinationDomains argument, even though the actual parameter was for
2702           a single domain (renamed to be singular).
2703
2704         * DumpRenderTree/LayoutTestController.h:
2705         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2706         (LayoutTestController::evaluateScriptInIsolatedWorld):
2707
2708 2011-05-26  Yuta Kitamura  <yutak@chromium.org>
2709
2710         Reviewed by Kent Tamura.
2711
2712         WebSocket closing handshake
2713         https://bugs.webkit.org/show_bug.cgi?id=35721
2714
2715         * Scripts/webkitpy/thirdparty/__init__.py:
2716         Pull in pywebsocket 0.6b1. We need to update pywebsocket
2717         to get the right behavior of closing handshake.
2718
2719 2011-05-26  Qi Zhang  <qi.2.zhang@nokia.com>
2720
2721         Reviewed by Andreas Kling.
2722
2723         WebKitTestRunner needs layoutTestController.setAuthorAndUserStylesEnabled
2724         https://bugs.webkit.org/show_bug.cgi?id=42676
2725
2726         Implemented layoutTestController.setAuthorAndUserStylesEnabled for WebKitTestRunner.
2727
2728         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2729         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2730         (WTR::InjectedBundle::beginTesting):
2731         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2732         (WTR::LayoutTestController::setAuthorAndUserStylesEnabled):
2733         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2734
2735 2011-05-26  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
2736
2737         Reviewed by Andreas Kling.
2738
2739         [Qt] QtTestBrowser "Switch User Agent" dialog is broken
2740         https://bugs.webkit.org/show_bug.cgi?id=61527
2741
2742         The setMaximumHeight() call is unecessary and breaks the dialog at
2743         least on my setup.
2744
2745         * QtTestBrowser/launcherwindow.cpp:
2746         (LauncherWindow::showUserAgentDialog):
2747
2748 2011-05-02  Robert Hogan  <robert@webkit.org>
2749
2750         Reviewed by Adam Roben.
2751
2752         [Qt] Allow popup windows from plugins when initiated by a user gesture
2753
2754         https://bugs.webkit.org/show_bug.cgi?id=41292
2755
2756         Support parameters introduced in plugin-initiate-popup-window.html
2757
2758         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2759         (webkit_test_plugin_new_instance):
2760         (webkit_test_plugin_handle_event):
2761
2762 2011-05-26  Mihai Parparita  <mihaip@chromium.org>
2763
2764         Reviewed by Adam Barth.
2765
2766         Support cross-origin XMLHttpRequest in isolated worlds
2767         https://bugs.webkit.org/show_bug.cgi?id=59843
2768
2769         Expose setIsolatedWorldSecurityOrigin in LayoutTestController.
2770
2771         * DumpRenderTree/chromium/LayoutTestController.cpp:
2772         (LayoutTestController::LayoutTestController):
2773         (LayoutTestController::setIsolatedWorldSecurityOrigin):
2774         * DumpRenderTree/chromium/LayoutTestController.h:
2775
2776 2011-05-25  Brian Weinstein  <bweinstein@apple.com>
2777
2778         Reviewed by Adam Roben.
2779
2780         WebKit2: Status bar, toolbar, and menu bar checks should be in the injected bundle
2781         https://bugs.webkit.org/show_bug.cgi?id=61474
2782         <rdar://problem/9468337>
2783
2784         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2785         (WTR::InjectedBundlePage::InjectedBundlePage): Add empty entries in the WKBundlePageUIClient.
2786
2787 2011-05-26  Andreas Kling  <kling@webkit.org>
2788
2789         Unreviewed, correct address to webkit-committers mailing list.
2790
2791         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2792
2793 2011-05-25  Adam Roben  <aroben@apple.com>
2794
2795         Don't assume that builds finish in the order they were started
2796
2797         Fixes <http://webkit.org/b/61464> TestFailures page shows failures from a not-most-recent
2798         build when one slave is taking a long time to finish a build
2799
2800         Reviewed by Antti Koivisto.
2801
2802         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
2803         (Builder.prototype.getMostRecentCompletedBuildNumber): Don't assume that all builds that are
2804         newer than the oldest in-progress build are also themselves in progress. Just check whether
2805         each build is actually in progress (as signified by its presence in the currentBuilds set).
2806
2807 2011-05-25  Adam Roben  <aroben@apple.com>
2808
2809         Correctly detect cases where only a single test failed/crashed/timed out
2810
2811         Fixes <http://webkit.org/b/61463> TestFailures page doesn't show testers with only a single
2812         failing test
2813
2814         Reviewed by Darin Adler.
2815
2816         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
2817         (Builder.prototype.getNumberOfFailingTests): Don't require "test cases" to be plural. It
2818         will be singular when only a single test fails/crashes/times out.
2819
2820         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
2821         (ViewController.prototype._displayTesters): Only pluralize "test" when more than one test
2822         failed/crashed/timed out.
2823
2824 2011-05-26  Tom Hudson  <tomhudson@google.com>
2825
2826         Reviewed by Tony Chang.
2827
2828         Add flags to Chromium ImageDiff to write image comparison metrics on
2829         stdout.
2830         https://bugs.webkit.org/show_bug.cgi?id=60569
2831
2832         * DumpRenderTree/chromium/ImageDiff.cpp:
2833         (Image::createFromStdin): Fix spelling.
2834         (maxOf3): New function to do 3-way maximum.
2835         (getRedComponent): Extract red component from ABGR packed encoding.
2836         (getGreenComponent): Extract green component from ABGR packed encoding.
2837         (getBlueComponent): Extract blue component from ABGR packed encoding.
2838         (weightedPercentageDifferent): Determine % of pixels different in two
2839         images multiplied by intensity difference of each pixel.
2840         (printHelp): Document new arguments.
2841         (compareImages): Parameterize.
2842         (untestedCompareImages): Parameterize.
2843         (diffImages): Parameterize; write results on stdout if requested.
2844         (main): Parse new arguments.
2845
2846 2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>
2847
2848         Reviewed by Simon Hausmann.
2849
2850         WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
2851         https://bugs.webkit.org/show_bug.cgi?id=42697
2852
2853         Implemented layoutTestController.setPrivateBrowsingEnabled for WebKitTestRunner.
2854
2855         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2856         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2857         (WTR::InjectedBundle::beginTesting):
2858         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2859         (WTR::LayoutTestController::setPrivateBrowsingEnabled):
2860         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2861
2862 2011-05-25  Jon Honeycutt  <jhoneycutt@apple.com>
2863
2864         REGRESSION (WebKit2): Crash in Flash on USA Today photo gallery
2865         https://bugs.webkit.org/show_bug.cgi?id=61428
2866         <rdar://problem/9457006>
2867
2868         Reviewed by Adam Roben.
2869
2870         The crash occurs when Flash posts a message to a window that it
2871         creates, and in processing the message, it calls NPN_Evaluate to
2872         evaluate JavaScript that removes the plug-in from the page. Flash then
2873         crashes when we return to Flash code.
2874
2875         This test emulates that behavior.
2876
2877         * DumpRenderTree/TestNetscapePlugIn/win/CallJSThatDestroysPlugin.cpp: Added.
2878         (CallJSThatDestroysPlugin::CallJSThatDestroysPlugin):
2879         Initialize member vars.
2880         (CallJSThatDestroysPlugin::~CallJSThatDestroysPlugin):
2881         Remove our custom property from the message window, and destroy it.
2882         (CallJSThatDestroysPlugin::NPP_Destroy):
2883         Set m_isDestroyed, log that the plug-in was destroyed, and notify the
2884         layout test controller that we're done.
2885         (wndProc):
2886         Get the PluginTest object, and call its runTest() function.
2887         (CallJSThatDestroysPlugin::NPP_New):
2888         Setup the test: register a class for the message-only window, create
2889         it, and post a message to it to run the test.
2890         (CallJSThatDestroysPlugin::runTest):
2891         Execute JS that removes the plug-in from the page, and if we're not
2892         destroyed, log a success message.
2893
2894         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2895         Add new test to project.
2896
2897 2011-05-25  Tony Chang  <tony@chromium.org>
2898
2899         Reviewed by Adam Barth.
2900
2901         webkitpy's NetworkTransaction shouldn't use mechanize
2902         https://bugs.webkit.org/show_bug.cgi?id=61450
2903
2904         mechanize.HTTPError is just an alias for urllib2.HTTPError, so
2905         use urllib2 directly.  Re-add NetworkTransaction to
2906         test_results_uploader.py (reverting r87124).
2907
2908         * Scripts/webkitpy/common/net/networktransaction.py:
2909         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
2910
2911 2011-05-25  Kevin Ollivier  <kevino@theolliviers.com>
2912
2913         [Chromium] Unreviewed build fix. Do not define WTF/JS_EXPORT_PRIVATE to JS_EXPORTDATA
2914         until the port begins using those export macros.
2915
2916         * DumpRenderTree/chromium/config.h:
2917
2918 2011-05-25  Sheriff Bot  <webkit.review.bot@gmail.com>
2919
2920         Unreviewed, rolling out r87257.
2921         http://trac.webkit.org/changeset/87257
2922         https://bugs.webkit.org/show_bug.cgi?id=61457
2923
2924         This broke layout tests, see bug 61431. (Requested by
2925         hwennborg on #webkit).
2926
2927         * DumpRenderTree/chromium/LayoutTestController.cpp:
2928         (LayoutTestController::LayoutTestController):
2929         (LayoutTestController::clearAllDatabases):
2930         * DumpRenderTree/chromium/LayoutTestController.h:
2931
2932 2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>
2933
2934         Reviewed by Andreas Kling.
2935
2936         [Qt] fast/css/disabled-author-styles.html failed
2937         https://bugs.webkit.org/show_bug.cgi?id=61438
2938
2939         Implemented API setAuthorAndUserStylesEnabled in LayoutTestControllerQt.
2940
2941         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2942         (WebCore::WebPage::resetSettings):
2943         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2944         (LayoutTestController::setAuthorAndUserStylesEnabled):
2945         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2946
2947 2011-05-25  Adam Roben  <aroben@apple.com>
2948
2949         Identify, rather than skip, builds where run-webkit-tests exited early due to too many failures
2950
2951         Fixes <http://webkit.org/b/61441> TestFailures page should show when run-webkit-tests
2952         started exiting early due to too many crashes, timeouts, or failures
2953
2954         Reviewed by David Kilzer.
2955
2956         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
2957         (Builder.prototype.getNumberOfFailingTests): Rather than returning -1 ("unknown") when
2958         run-webkit-tests exits early due to too many failures, pass that information in another
2959         argument to the callback.
2960         (Builder.prototype.startFetchingBuildHistory): Updated the documentation comment to reflect
2961         the new structure of the object passed to the callback.
2962         (Builder.prototype._getFailingTests): Updated to expect a tooManyFailures boolean from
2963         getNumberOfFailingTests and to pass that along to our own callbacks.
2964         (Builder.prototype._incorporateBuildHistory): Updated to expect a tooManyFailures boolean
2965         from _getFailingTests and to store that value in the history object.
2966
2967         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
2968         (.info): Added.
2969
2970         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
2971         (ViewController.prototype._displayBuilder): Updated for change in structure to the history
2972         object and to add a note when run-webkit-tests exited early due to too many failures.
2973         (ViewController.prototype._displayTesters): Renamed testersAndFailureCounts to
2974         latestBuildInfos since each entry now contains more than just the tester and failure count.
2975         Now displays a message for testers where the latest build exited early due to too many
2976         failures. Updated to expect a tooManyFailures boolean from getNumberOfFailingTests and to
2977         store that value in latestBuildInfos.
2978
2979 2011-05-24  Keishi Hattori  <keishi@webkit.org>
2980
2981         Reviewed by Kent Tamura.
2982
2983         Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
2984         https://bugs.webkit.org/show_bug.cgi?id=61273
2985
2986         * Scripts/build-webkit: Added INPUT_COLOR feature flag.
2987
2988 2011-05-24  Greg Simon  <gregsimon@chromium.org>
2989
2990         Reviewed by Dimitri Glazkov.
2991
2992         Control Indexeddb backends from LayoutTestController
2993         https://bugs.webkit.org/show_bug.cgi?id=61000
2994
2995         * DumpRenderTree/chromium/LayoutTestController.cpp:
2996         (LayoutTestController::LayoutTestController):
2997         (LayoutTestController::setOverrideIndexedDBBackingStore):
2998         (LayoutTestController::clearAllDatabases):
2999         * DumpRenderTree/chromium/LayoutTestController.h:
3000
3001 2011-05-24  Robert Hogan  <robert@webkit.org>
3002
3003         Reviewed by Ryosuke Niwa.
3004
3005         [Qt] Fix fast/events/selectstart-by-single-click-with-shift.html
3006         https://bugs.webkit.org/show_bug.cgi?id=61393
3007
3008         * DumpRenderTree/qt/EventSenderQt.h:
3009         * DumpRenderTree/qt/EventSenderQt.cpp:
3010         (getModifiers): static function for interpreting modifiers
3011         (EventSender::mouseDown): Respect keyboard modifiers
3012         (EventSender::keyDown): use new static function
3013         (EventSender::sendOrQueueEvent): whitespace fix
3014
3015 2011-05-24  Jay Civelli  <jcivelli@chromium.org>
3016
3017         Reviewed by Adam Barth.
3018
3019         Adding MHTML reading support.
3020         https://bugs.webkit.org/show_bug.cgi?id=7168
3021
3022         * Scripts/build-webkit:
3023         * Scripts/old-run-webkit-tests:
3024         * Scripts/webkitperl/features.pm:
3025         * Scripts/webkitpy/layout_tests/port/test_files.py:
3026         * Scripts/webkitpy/layout_tests/port/webkit.py:
3027
3028 2011-05-24  Stephen White  <senorblanco@chromium.org>
3029
3030         Reviewed by Kenneth Russell.
3031
3032         Remove most style checks on Source/ThirdParty/glu, since it doesn't
3033         follow WebKit style.
3034         https://bugs.webkit.org/show_bug.cgi?id=61365
3035
3036         * Scripts/webkitpy/style/checker.py:
3037
3038 2011-05-24  Adam Roben  <aroben@apple.com>
3039
3040         Don't allow forcing builds through the build.webkit.org web interface
3041
3042         Someone has been forcing bogus builds.
3043
3044         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3045
3046 2011-05-24  Qi Zhang  <qi.2.zhang@nokia.com>
3047
3048         Reviewed by Adam Roben.
3049
3050         WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
3051         https://bugs.webkit.org/show_bug.cgi?id=42669
3052
3053         Fixes the regression issue caused by patch 94265. The patch didn't intialize the setting before the 
3054         layouttest starting, it will make the test cases after editing/execCommand/clipboard-access.html failed.
3055         Because that case changed the setting.
3056
3057         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3058         (WTR::InjectedBundle::beginTesting):
3059
3060 2011-05-24  Csaba Osztrogonác  <ossy@webkit.org>
3061
3062         Reviewed by Kenneth Rohde Christiansen.
3063
3064         [ORWT]Make --skipped=only option work with parameters with LayoutTests/ prefix
3065         https://bugs.webkit.org/show_bug.cgi?id=61052
3066
3067         * Scripts/old-run-webkit-tests:
3068
3069 2011-05-24  Adam Roben  <aroben@apple.com>
3070
3071         Make TestFailures show how many tests are failing on each tester, and omit testers with no failures
3072
3073         Fixes <http://webkit.org/b/61063> <rdar://problem/9460533> TestFailures page shows testers
3074         that don't have any failing tests, which isn't useful
3075
3076         Reviewed by David Kilzer.
3077
3078         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js:
3079         (Buildbot.prototype.getTesters): Renamed from getTesterNames. Now returns Builder objects
3080         instead of name strings.
3081         (Buildbot.prototype._buildersForNames): Added. Helper function to convert an array of
3082         builder names into an array of builders.
3083
3084         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
3085         (Builder.prototype.getMostRecentCompletedBuildNumber): Added. Returns the build number of
3086         the most recently completed build, or -1 if there is no such build.
3087         (Builder.prototype.getNumberOfFailingTests): Added. Returns the number of tests that failed
3088         in the given build, or -1 if the number could not be determined. Some of this code came from
3089         _getFailingTests.
3090         (Builder.prototype._getBuildJSON): Added. Code came from _getFailingTests.
3091         (Builder.prototype._getFailingTests): Changed to use new _getBuildJSON and
3092         getNumberOfFailingTests functions.
3093
3094         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
3095         (ViewController.prototype._displayTesters): Get the current number of test failures for each
3096         tester and show it in the list. Omit testers that have no failures at all. We keep the
3097         testers and failure counts in an array and sort it before displaying the current data, as
3098         the order in which data will be fetched is unpredictable.
3099
3100 2011-05-23  Tony Chang  <tony@chromium.org>
3101
3102         Reviewed by Ojan Vafai.
3103
3104         [nrwt] don't use NetworkTranslation when uploading results
3105         https://bugs.webkit.org/show_bug.cgi?id=61315
3106
3107         This avoids autoinstalling mechanize.  It didn't matter anyway
3108         because test_results_uploader.py wasn't using mechanize to make the
3109         request so NetworkTransaction::run wasn't doing anything extra
3110         (it only matters if it catches mechanize.HTTPError).
3111
3112         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
3113
3114 2011-05-23  Tony Chang  <tony@chromium.org>
3115
3116         Reviewed by Dirk Pranke.
3117
3118         [chromium] fix the rebaseline tool to work with Linux GPU failures
3119         https://bugs.webkit.org/show_bug.cgi?id=61312
3120
3121         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3122
3123 2011-05-23  Darin Adler  <darin@apple.com>
3124
3125         Ignore generated .pyc files in a directory full of python code.
3126
3127         * Scripts/webkitpy/common/checkout/scm: Added property svn:ignore.
3128
3129 2011-05-23  Adam Barth  <abarth@webkit.org>
3130
3131         Reviewed by Eric Seidel.
3132
3133         sheriffbot should give more details about the failures in IRC
3134         https://bugs.webkit.org/show_bug.cgi?id=61233
3135
3136         With this patch, sheriffbot will annonce the set of failing tests,
3137         which might help folks triage the problem.
3138
3139         * Scripts/webkitpy/tool/commands/sheriffbot.py:
3140         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
3141
3142 2011-05-23  Sheriff Bot  <webkit.review.bot@gmail.com>
3143
3144         Unreviewed, rolling out r87078.
3145         http://trac.webkit.org/changeset/87078
3146         https://bugs.webkit.org/show_bug.cgi?id=61294
3147
3148         Patch contains errors and seems likely to break a bunch of
3149         bots (Requested by abarth on #webkit).
3150
3151         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3152         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3153         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3154
3155 2011-05-23  Alice Boxhall  <aboxhall@chromium.org>
3156
3157         Reviewed by Ojan Vafai.
3158
3159         Convert json_results_generator.py to output version 4 JSON.
3160         https://bugs.webkit.org/show_bug.cgi?id=60869
3161
3162         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3163         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3164         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3165
3166 2011-05-23  Patrick Gansterer  <paroga@webkit.org>
3167
3168         Reviewed by Adam Barth.
3169
3170         Move generation of shell_command from port to executive
3171         https://bugs.webkit.org/show_bug.cgi?id=61251
3172
3173         After move it's possible to use the code in other places too.
3174
3175         * Scripts/webkitpy/common/config/ports.py:
3176         * Scripts/webkitpy/common/system/executive.py:
3177
3178 2011-05-23  Qi Zhang  <qi.2.zhang@nokia.com>
3179
3180         Reviewed by Darin Adler.
3181
3182         WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
3183         https://bugs.webkit.org/show_bug.cgi?id=42669
3184
3185         Implement setJavaScriptCanAccessClipboard in WebKitTestRunner.
3186
3187         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3188         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3189         (WTR::LayoutTestController::setJavaScriptCanAccessClipboard):
3190         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3191
3192 2011-05-22  Robert Hogan  <robert@webkit.org>
3193
3194         Reviewed by Kenneth Rohde Christiansen.
3195
3196         Fix policyDelegate in Qt DRT
3197         https://bugs.webkit.org/show_bug.cgi?id=61247
3198
3199         Use the 'policy delegate' implemented in FrameLoaderClient
3200         for layout tests. The partial implementation in DumpRenderTreeQt
3201         is redundant, so remove it.
3202
3203         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3204         (WebCore::WebPage::acceptNavigationRequest):
3205         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3206         (LayoutTestController::waitForPolicyDelegate):
3207
3208 2011-05-22  Patrick Gansterer  <paroga@webkit.org>
3209
3210         Reviewed by Darin Adler.
3211
3212         Use double quotes for filename arguments
3213         https://bugs.webkit.org/show_bug.cgi?id=61250
3214
3215         Windows does not support single quotes on the command line,
3216         so replace them with double quotes.
3217
3218         * Scripts/prepare-ChangeLog:
3219
3220 2011-05-20  Simon Fraser  <simon.fraser@apple.com>
3221
3222         Reviewed by Sam Weinig.
3223
3224         WebKitTestRunner needs layoutTestController.pauseTransitionAtTimeOnElementWithId
3225         https://bugs.webkit.org/show_bug.cgi?id=42550
3226         
3227         Implement pauseTransitionAtTimeOnElementWithId in WebKitTestRunner.
3228
3229         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3230         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3231         Copy the code for pausing animations, FIXME comments and all.
3232         (WTR::LayoutTestController::pauseTransitionAtTimeOnElementWithId):
3233         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3234
3235 2011-05-20  Alok Priyadarshi  <alokp@chromium.org>
3236
3237         Reviewed by Stephen White.
3238
3239         Adding myself to the committers list.
3240
3241         * Scripts/webkitpy/common/config/committers.py:
3242
3243 2011-05-19  Adam Roben  <aroben@apple.com>
3244
3245         Test that the WebKit2 UI process doesn't crash when starting a download
3246
3247         Test for <http://webkit.org/b/61142> <rdar://problem/9471680> REGRESSION (r86812): Crash
3248         (preceded by assertion) in fastMalloc when downloading a file
3249
3250         Reviewed by Darin Adler.
3251
3252         * TestWebKitAPI/Tests/WebKit2/18-characters.html: Added.
3253
3254         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp: Added.
3255         (TestWebKitAPI::decidePolicyForNavigationAction): Start a download.
3256         (TestWebKitAPI::decideDestinationWithSuggestedFilename): Record that the download was
3257         started, cancel the download, and return a bogus string.
3258
3259         (TestWebKitAPI::setContextDownloadClient):
3260         (TestWebKitAPI::setPagePolicyClient):
3261         Simple helper functions.
3262
3263         (TestWebKitAPI::TEST): Load 18-characters.html, which should trigger a download thanks to
3264         our policy client, and run until we know that the download was started. If we haven't
3265         crashed, we win!
3266
3267         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3268         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3269         * TestWebKitAPI/win/copy-resources.cmd:
3270         Added new files.
3271
3272 2011-05-20  Kent Tamura  <tkent@chromium.org>
3273
3274         Reviewed by Ryosuke Niwa.
3275
3276         Fix style errors in DumpRenderTree/chromium/.
3277         https://bugs.webkit.org/show_bug.cgi?id=61172
3278
3279         * DumpRenderTree/chromium/CppBoundClass.cpp:
3280         (CppBoundClass::getAsCppVariant):
3281         (CppBoundClass::bindToJavascript):
3282         * DumpRenderTree/chromium/CppBoundClass.h:
3283         (CppBoundClass::GetterCallback::~GetterCallback):
3284         (CppBoundClass::CppBoundClass):
3285         (CppBoundClass::Callback::~Callback):
3286         (CppBoundClass::MemberCallback::MemberCallback):
3287         (CppBoundClass::MemberCallback::~MemberCallback):
3288         (CppBoundClass::MemberGetterCallback::MemberGetterCallback):
3289         (CppBoundClass::MemberGetterCallback::~MemberGetterCallback):
3290         * DumpRenderTree/chromium/CppVariant.h:
3291         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3292         (DRTDevToolsAgent::~DRTDevToolsAgent):
3293         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
3294         (DRTDevToolsClient::sendFrontendLoaded):
3295         * DumpRenderTree/chromium/DRTDevToolsClient.h:
3296         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3297         (main):
3298         * DumpRenderTree/chromium/EventSender.cpp:
3299         (SavedEvent::SavedEvent):
3300         (EventSender::EventSender):
3301         (EventSender::keyDown):
3302         * DumpRenderTree/chromium/EventSender.h:
3303         * DumpRenderTree/chromium/ImageDiff.cpp:
3304         (Image::Image):
3305         * DumpRenderTree/chromium/LayoutTestController.cpp:
3306         (LayoutTestController::LayoutTestController):
3307         (LayoutTestController::WorkQueue::reset):
3308         (WorkItemBackForward::WorkItemBackForward):
3309         (WorkItemLoadingScript::WorkItemLoadingScript):
3310         (WorkItemNonLoadingScript::WorkItemNonLoadingScript):
3311         (WorkItemLoad::WorkItemLoad):
3312         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
3313         (LayoutTestController::pathToLocalResource):
3314         * DumpRenderTree/chromium/LayoutTestController.h:
3315         (LayoutTestController::WorkItem::~WorkItem):
3316         (LayoutTestController::WorkQueue::WorkQueue):
3317         * DumpRenderTree/chromium/MockSpellCheck.cpp:
3318         (MockSpellCheck::MockSpellCheck):
3319         (MockSpellCheck::~MockSpellCheck):
3320         * DumpRenderTree/chromium/MockSpellCheck.h:
3321         * DumpRenderTree/chromium/NotificationPresenter.h:
3322         (NotificationPresenter::NotificationPresenter):
3323         * DumpRenderTree/chromium/Task.cpp:
3324         (WebTask::WebTask):
3325         * DumpRenderTree/chromium/Task.h:
3326         (TaskList::TaskList):
3327         * DumpRenderTree/chromium/TestEventPrinter.cpp:
3328         (DRTPrinter::DRTPrinter):
3329         (TestShellPrinter::TestShellPrinter):
3330         * DumpRenderTree/chromium/TestNavigationController.cpp:
3331         (TestNavigationEntry::TestNavigationEntry):
3332         (TestNavigationEntry::~TestNavigationEntry):
3333         (TestNavigationController::TestNavigationController):
3334         (TestNavigationController::reload):
3335         (TestNavigationController::loadEntry):
3336         (TestNavigationController::didNavigateToEntry):
3337         * DumpRenderTree/chromium/TestNavigationController.h:
3338         (TestShellExtraData::TestShellExtraData):
3339         * DumpRenderTree/chromium/TestShell.cpp:
3340         (dumpHistoryItem):
3341         * DumpRenderTree/chromium/TestShell.h:
3342         (TestParams::TestParams):
3343         * DumpRenderTree/chromium/TestShellWin.cpp:
3344         (TestShell::waitTestFinished):
3345         * DumpRenderTree/chromium/TestWebWorker.h:
3346         (TestWebWorker::startWorkerContext):
3347         (TestWebWorker::terminateWorkerContext):
3348         (TestWebWorker::postMessageToWorkerContext):
3349         (TestWebWorker::clientDestroyed):
3350         (TestWebWorker::postMessageToWorkerObject):
3351         (TestWebWorker::postExceptionToWorkerObject):
3352         (TestWebWorker::postConsoleMessageToWorkerObject):
3353         (TestWebWorker::confirmMessageFromWorkerObject):
3354         (TestWebWorker::reportPendingActivity):
3355         (TestWebWorker::workerContextClosed):
3356         (TestWebWorker::~TestWebWorker):
3357         * DumpRenderTree/chromium/TextInputController.cpp:
3358         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
3359         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
3360         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
3361         (WebThemeEngineDRTWin::paintButton):
3362         (WebThemeEngineDRTWin::paintMenuList):
3363         (WebThemeEngineDRTWin::paintTrackbar):
3364         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
3365         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
3366         * DumpRenderTree/chromium/WebViewHost.cpp:
3367         (WebViewHost::navigate):
3368         (WebViewHost::updateSessionHistory):
3369         (WebViewHost::paintInvalidatedRegion):
3370         * DumpRenderTree/chromium/WebViewHost.h:
3371
3372 2011-05-19  Dmitry Lomov  <dslomov@google.com>
3373
3374         Reviewed by Adam Roben.
3375
3376         Detect hangs in run-api-tests
3377         https://bugs.webkit.org/show_bug.cgi?id=48043
3378
3379         * Scripts/run-api-tests: Added test timeouts
3380
3381 2011-05-19  Dmitry Lomov  <dslomov@google.com>
3382
3383         Reviewed by Adam Roben.
3384
3385         run-api-tests should run one test per process
3386         https://bugs.webkit.org/show_bug.cgi?id=61088
3387
3388         * Scripts/run-api-tests: Resurrecting the previous revison of this file, with fixes to system call under Windows, 
3389         return code, and parsing GTest output format.
3390
3391 2011-05-15  Robert Hogan  <robert@webkit.org>
3392
3393         Reviewed by Antonio Gomes.
3394
3395         [Qt][GTK] plugins/get-url-with-javascript-url.html fails
3396         https://bugs.webkit.org/show_bug.cgi?id=60834
3397         Fix unix test plugin for plugins/get-url-with-javascript-url.html
3398
3399         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3400         (webkit_test_plugin_new_stream):
3401         (webkit_test_plugin_write_ready):
3402         (webkit_test_plugin_write):
3403
3404 2011-05-19  Sheriff Bot  <webkit.review.bot@gmail.com>
3405
3406         Unreviewed, rolling out r86869, r86873, r86875, and r86877.
3407         http://trac.webkit.org/changeset/86869
3408         http://trac.webkit.org/changeset/86873
3409         http://trac.webkit.org/changeset/86875
3410         http://trac.webkit.org/changeset/86877
3411         https://bugs.webkit.org/show_bug.cgi?id=61139
3412
3413         broke builds and debug DRT (Requested by rniwa on #webkit).
3414
3415         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3416         * DumpRenderTree/chromium/TestShell.cpp:
3417         (TestShell::bindJSObjectsToWindow):
3418         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3419         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
3420
3421 2011-05-18  Dimitri Glazkov  <dglazkov@chromium.org>
3422
3423         Reviewed by Darin Adler.
3424
3425         Add build logistics and plumbing for window.internals object.
3426         https://bugs.webkit.org/show_bug.cgi?id=60313
3427
3428         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
3429         * DumpRenderTree/chromium/TestShell.cpp:
3430         (TestShell::bindJSObjectsToWindow): Added injection code.
3431         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3432         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
3433
3434 2011-05-19  Zsolt Fehér  <h490267@stud.u-szeged.hu>
3435
3436         Reviewed by Csaba Osztrogonác.
3437
3438         [Qt] Implement eventSender.scalePageBy
3439         https://bugs.webkit.org/show_bug.cgi?id=60015
3440
3441         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3442         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3443         * DumpRenderTree/qt/EventSenderQt.cpp:
3444         (EventSender::scalePageBy):
3445         * DumpRenderTree/qt/EventSenderQt.h:
3446
3447 2011-05-19  Kenichi Ishibashi  <bashi@chromium.org>
3448
3449         Reviewed by Kent Tamura.
3450
3451         [Chromium] IME candidate window appears wrong position in an iframe
3452         https://bugs.webkit.org/show_bug.cgi?id=61023
3453
3454         Call the focused frame's firstRectForCharacterRange() instead of the
3455         main frame so that DRT behaves as the same as Chromium.
3456
3457         * DumpRenderTree/chromium/TextInputController.cpp:
3458         (TextInputController::firstRectForCharacterRange):
3459
3460 2011-05-18  Adam Roben  <aroben@apple.com>
3461
3462         Add a new page to build.webkit.org to help find when tests started failing
3463
3464         The page is accessible at <http://build.webkit.org/TestFailures/>. It is pretty minimalist
3465         right now, but already shows some useful information. It's somewhat similar to webkit-patch
3466         failure-reason and sheriffbot, and perhaps can be combined with them eventually. It's a
3467         little more convenient than either of them, though, because it's all done in the browser
3468         (and thus it's easy to go directly to the relevant test results).
3469
3470         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Added.
3471         (Buildbot): This class represents a Buildbot server.
3472         (Buildbot.prototype.buildURL): Returns the URL for the summary page for a particular build.
3473         (Buildbot.prototype.builderNamed): Returns a Builder with the given name.
3474         (Buildbot.prototype.getTesterNames): Fetches the names of all testers and passes them to the
3475         callback.
3476         (Buildbot.prototype.parseBuildName): Breaks up a build name into its constituent parts. Must
3477         be implemented by a derived class that understands this server's build naming scheme.
3478         (Buildbot.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
3479         particular build.
3480
3481         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Added.
3482         (Builder): This class represents one builder on the buildbot.
3483         (Builder.prototype.buildURL): Returns the URL for the summary page for a particular build.
3484         (Builder.prototype.failureDiagnosisTextAndURL): Returns data that provides a little more
3485         information about a particular test failure.
3486         (Builder.prototype.startFetchingBuildHistory): Periodically calls the callback with
3487         information about when tests started failing.
3488         (Builder.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
3489         particular build.
3490         (Builder.prototype._getBuildNames): Fetches the names of all builds and passes them to the
3491         callback.
3492         (Builder.prototype._getFailingTests): Fetches the results.html page for the given build and
3493         extracts all the failing tests listed in it, passing them to the callback.
3494         (Builder.prototype._incorporateBuildHistory): Gets the failing tests for the specified
3495         build, merges them into the build history, and calls the callback telling it whether the
3496         next build should be fetched to provide more information.
3497
3498         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
3499         Added. Just some simple styles.
3500
3501         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Added.
3502         (createDefinitionList): Takes an array of pairs and turns them into a DL element.
3503         (getResource): Wrapper around XMLHttpRequest.
3504         (Array.prototype.findFirst): Finds the first element matching the given predicate and
3505         returns it.
3506         (Array.prototype.last): Returns the last element of the array.
3507
3508         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Added.
3509         (ViewController): This class contains the main logic for displaying the page.
3510         (ViewController.loaded): Just calls through to parseHash.
3511         (ViewController.parseHash): Either starts analyzing failures on a particular builder, or
3512         shows the list of all testers so one can be chosen. This function is called when the page
3513         loads and whenever we get a hashchange event.
3514         (ViewController._displayBuilder): Asks the builder to fetch build history, and displays it
3515         as it is fetched. The display ends up grouping tests by when they started failing.
3516         (ViewController._displayTesters): Gets the list of testers and displays it.
3517
3518         (ViewController._domForBuildName):
3519         (ViewController._domForFailedTest):
3520         Helper functions to create descriptions and links for a particular build or failed test.
3521
3522         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Added.
3523         (WebKitBuildbot): Calls up to the base class constructor with the correct base URL.
3524         (WebKitBuildbot.prototype.parseBuildName): Parses a build.webkit.org-style build name.
3525
3526         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Added. Just
3527         loads all the files and sets up a ViewController, which does the rest.
3528
3529         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Added a link to the new
3530         page.
3531
3532 2011-05-18  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
3533
3534         Reviewed by Csaba Osztrogonác.
3535
3536         [Qt] Implement layoutTestController.setValueForUser()
3537         https://bugs.webkit.org/show_bug.cgi?id=60956
3538
3539         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3540         (LayoutTestController::setValueForUser):
3541         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3542
3543 2011-05-16  Robert Hogan  <robert@webkit.org>
3544
3545         Reviewed by Kenneth Rohde Christiansen.
3546
3547         plugins/invalidate_rect.html fails on linux ports
3548
3549         - Make the unix test netscape plugin recognize the onPaintEvent
3550           and windowedPlugin parameters.
3551
3552         https://bugs.webkit.org/show_bug.cgi?id=54051
3553
3554         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3555         (handleEventX11):
3556         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3557         (LayoutTestController::displayInvalidatedRegion):
3558         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3559         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3560         (webkit_test_plugin_new_instance):
3561         (webkit_test_plugin_handle_event):
3562
3563 2011-05-17  Tony Chang  <tony@chromium.org>
3564
3565         Reviewed by Ojan Vafai.
3566
3567         [chromium] move Lucid 64 bit results into LayoutTests/platform/chromium-linux
3568         https://bugs.webkit.org/show_bug.cgi?id=60895
3569
3570         Update the tools to handle the move.  Lucid 32 results now go in
3571         chromium-linux-x86 and the default platform on Linux is now x86_64.
3572
3573         * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Default to x86_64
3574         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3575         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Default to Lucid
3576         * Scripts/webkitpy/layout_tests/port/base.py: ditto
3577         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Update directory fallback and default to Lucid 64
3578         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3579         * Scripts/webkitpy/layout_tests/port/test.py: Update tests to default to x86_64
3580         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Update bot names.
3581         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: Whitespace cleanup.
3582
3583 2011-05-17  Adam Roben  <aroben@apple.com>
3584
3585         Make run-api-tests work on Windows when there are spaces in the path
3586
3587         Fixes <http://webkit.org/b/60954> REGRESSION (r86511): run-api-tests fails if there are
3588         spaces in the path to TestWebKitAPI.exe
3589
3590         Reviewed by David Levin.
3591
3592         * Scripts/run-api-tests:
3593         (runTestTool): Use the "direct object" form of system() to avoid having the path to
3594         TestWebKitAPI.exe be split by the shell.
3595
3596 2011-05-16  Ian Henderson  <ianh@apple.com>
3597
3598         Reviewed by Joseph Pecoraro.
3599
3600         Page::goToItem doesn't work while loading is deferred
3601         https://bugs.webkit.org/show_bug.cgi?id=60412
3602
3603         Add setDefersLoading and goBack methods to LayoutTestController.  We
3604         need to use goBack() instead of history.back() because the latter goes
3605         through NavigationScheduler, hence doesn't exhibit the bug.
3606
3607         * DumpRenderTree/LayoutTestController.cpp:
3608         (goBackCallback):
3609         (setDefersLoadingCallback):
3610         (LayoutTestController::staticFunctions):
3611         * DumpRenderTree/LayoutTestController.h:
3612         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3613         (LayoutTestController::goBack):
3614         (LayoutTestController::setDefersLoading):
3615         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3616         (LayoutTestController::goBack):
3617         (LayoutTestController::setDefersLoading):
3618         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3619         (LayoutTestController::goBack):
3620         (LayoutTestController::setDefersLoading):
3621         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3622         (LayoutTestController::goBack):
3623         (LayoutTestController::setDefersLoading):
3624
3625 2011-05-16  Sam Weinig  <sam@webkit.org>
3626
3627         Reviewed by Anders Carlsson.
3628
3629         TestWebKitAPI should build with clang if it can
3630         https://bugs.webkit.org/show_bug.cgi?id=60918
3631
3632         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
3633         Update CompilerVersion.xcconfig to match others.
3634
3635         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3636         Add CompilerVersion.xcconfig to the project.
3637
3638         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
3639         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
3640         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3641         (TestWebKitAPI::didSameDocumentNavigationForFrame):
3642         Add some casts to quiet warnings from clang.
3643
3644 2011-05-16  Dirk Pranke  <dpranke@chromium.org>
3645
3646         Reviewed by David Levin.
3647
3648         add dpranke as a reviewer
3649         https://bugs.webkit.org/show_bug.cgi?id=60919
3650
3651         * Scripts/webkitpy/common/config/committers.py:
3652
3653 2011-05-16  Robert Hogan  <robert@webkit.org>
3654
3655         Reviewed by Anders Carlsson.
3656
3657         [Gtk] plugins/get-url-notify-with-url-that-fails-to-load.html crashes on buildbot
3658
3659         https://bugs.webkit.org/show_bug.cgi?id=60838
3660
3661         The unix test plugin needs to call the test's NPP_URLNotify
3662         rather than the browsers.
3663
3664         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3665         (webkit_test_plugin_url_notify):
3666
3667 2011-05-16  Brent Fulgham  <bfulgham@webkit.org>
3668
3669         Rubber-stamped by Adam Roben.
3670
3671         Adding myself as a reviewer.
3672         * Scripts/webkitpy/common/config/committers.py:
3673
3674 2011-05-16  Sam Weinig  <sam@webkit.org>
3675
3676         Fix typo pointed out by Dave Levin.
3677
3678         * TestWebKitAPI/PlatformUtilities.h:
3679         (TestWebKitAPI::Util::assertWKStringEqual):
3680         Strig -> String.
3681
3682 2011-05-16  Sam Weinig  <sam@webkit.org>
3683
3684         Reviewed by David Levin.
3685
3686         Convert api tester over to using gtest expectations directly
3687         https://bugs.webkit.org/show_bug.cgi?id=60862
3688
3689         * TestWebKitAPI/PlatformUtilities.cpp:
3690         (TestWebKitAPI::Util::toSTD):
3691         * TestWebKitAPI/PlatformUtilities.h:
3692         (TestWebKitAPI::Util::assertWKStrigEqual):
3693         Add convenience macro to compare WK2 strings. Add some overloads of toSTD to make
3694         the implementation of the macro simpler.
3695
3696         * TestWebKitAPI/Test.h:
3697         Remove TEST_ASSERT forwarder.
3698
3699         [Test changes elided]
3700
3701 2011-05-16  David Kilzer  <ddkilzer@apple.com>
3702
3703         <http://webkit.org/b/60913> C++ exceptions should not be enabled when building with llvm-gcc-4.2
3704         <rdar://problem/9446430>
3705
3706         Reviewed by Mark Rowe.
3707
3708         * MiniBrowser/Configurations/Base.xcconfig: Fixed typo.
3709         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
3710         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
3711
3712 2011-05-16  Jon Lee  <jonlee@apple.com>
3713
3714         Reviewed by Simon Fraser.
3715
3716         Can't horizontally scroll iframes and overflow because wheel events are always accepted
3717         https://bugs.webkit.org/show_bug.cgi?id=60779
3718
3719         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3720         (WTR::InjectedBundlePage::InjectedBundlePage): Set new default method to nil.
3721
3722 2011-05-16  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
3723
3724         Reviewed by Csaba Osztrogonác.
3725
3726         [Qt] Tools.pro misses include(common.pri)
3727         https://bugs.webkit.org/show_bug.cgi?id=60883
3728
3729         It includes features.pri, which depends on common.pri (the build is
3730         not broken today with the default options, but this is the right
3731         thing to do).
3732
3733         * Tools.pro:
3734
3735 2011-05-15  Dominic Cooney  <dominicc@chromium.org>
3736
3737         Unreviewed: adding myself to committers.py.
3738
3739         * Scripts/webkitpy/common/config/committers.py:
3740
3741 2011-05-15  Daniel Bates  <dbates@webkit.org>
3742
3743         Reviewed by Chris Jerdonek.
3744
3745         svn-apply can't handle Git diff that only changes executable bit
3746         https://bugs.webkit.org/show_bug.cgi?id=60848
3747
3748         Fixes an issue where svn-{apply, unapply} fail to handle a Git diff for a file
3749         that only has an executable bit change.
3750
3751         * Scripts/VCSUtils.pm:
3752           - Modified regex $chunkRangeRegEx to match chunk range with ending text, say: @@ -2,6 +2,18 @@ foo().
3753         (parseDiff): Modified to count the number of text chunks in the diff. This should also help towards
3754         fixing <https://bugs.webkit.org/show_bug.cgi?id=29684>.
3755         * Scripts/svn-apply:
3756         (patch): Only use standard patch tool if the patch is non-empty and for a text file (i.e. not a binary patch).
3757         * Scripts/svn-unapply:
3758         (patch): Ditto.
3759         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
3760           - Updated expected results for test cases to account for numTextChunks.
3761           - Fixed malformed chunk range in test cases: "Git: simple", and "Git: Git diff followed by SVN diff".
3762           - Added test case "Git: file that only has an executable bit change".
3763         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
3764           - Updated expected results for test cases to account for numTextChunks.
3765
3766 2011-05-15  Sam Weinig  <sam@webkit.org>
3767
3768         Fix windows build.
3769
3770         * TestWebKitAPI/win/main.cpp:
3771         (main):
3772
3773 2011-05-15  Sam Weinig  <sam@webkit.org>
3774
3775         Reviewed by David Levin.
3776
3777         Make API tester more gtest friendly
3778         https://bugs.webkit.org/show_bug.cgi?id=60859
3779
3780         * Scripts/run-api-tests:
3781         Numerous changes:
3782         - Remove logic to run tests one at a time.
3783         - Remove logic to build up a list of tests, instead just pass --gtest_list_tests to 
3784           the test runner and allow gtest to print it for us.
3785         - Forward stdout from the test tool to stdout, even in non-verbose runs.
3786         - Run test tool from the current working directory instead of the root webkit
3787           directory.
3788
3789         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3790         Move plist to be with other bundle sources.
3791
3792         * TestWebKitAPI/TestsController.cpp:
3793         (TestWebKitAPI::TestsController::TestsController):
3794         (TestWebKitAPI::TestsController::run):
3795         * TestWebKitAPI/TestsController.h:
3796         * TestWebKitAPI/mac/main.mm:
3797         Simplify TestController down to a single run function. We should consider removing the class
3798         entirely at some point.
3799
3800 2011-05-15  Sheriff Bot  <webkit.review.bot@gmail.com>
3801
3802         Unreviewed, rolling out r86504.
3803         http://trac.webkit.org/changeset/86504
3804         https://bugs.webkit.org/show_bug.cgi?id=60853
3805
3806         "Broke Qt EventSender in editing/selection tests" (Requested
3807         by mwenge on #webkit).
3808
3809         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3810         (WebCore::WebPage::WebPage):
3811         (WebCore::DumpRenderTree::DumpRenderTree):
3812         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3813         (WebCore::DumpRenderTree::initJSObjects):
3814         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3815         (WebCore::DumpRenderTree::eventSender):
3816         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3817         (webkit_test_plugin_new_instance):
3818         (webkit_test_plugin_set_window):
3819         (webkit_test_plugin_handle_event):
3820
3821 2011-05-12  Robert Hogan  <robert@webkit.org>
3822
3823         Reviewed by Benjamin Poulain.
3824
3825         [Qt] fix http/tests/plugins/plugin-document-has-focus.html
3826
3827         The support for this test added to the unix test plugin here
3828         may allow other platforms to pass it (nearly everyone
3829         skips it). On Qt it required a bit of trickiness with
3830         the page's EventSender object to get it working fully though,
3831         so only unskipping Qt here.
3832
3833         https://bugs.webkit.org/show_bug.cgi?id=60722
3834
3835         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3836         (WebCore::WebPage::WebPage):
3837         (WebCore::WebPage::eventSender):
3838         (WebCore::DumpRenderTree::DumpRenderTree):
3839         (WebCore::DumpRenderTree::initJSObjects):
3840         (WebCore::DumpRenderTree::createWindow):
3841         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3842         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3843         (webkit_test_plugin_new_instance):
3844         (webkit_test_plugin_set_window):
3845         (webkit_test_plugin_handle_event):
3846
3847 2011-05-14  Arno Renevier  <arno@renevier.net>
3848
3849         Reviewed by Martin Robinson.
3850
3851         make run-gtk-tests executable
3852         https://bugs.webkit.org/show_bug.cgi?id=59278
3853
3854         * Scripts/run-gtk-tests:
3855
3856 2011-05-14  Anders Carlsson  <andersca@apple.com>
3857
3858         Reviewed by Kevin Decker.
3859
3860         NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
3861         https://bugs.webkit.org/show_bug.cgi?id=60823
3862         <rdar://problem/9430386>
3863
3864         Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.
3865
3866         * DumpRenderTree/DumpRenderTree.gypi:
3867         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3868         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added.
3869         (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad):
3870         (GetURLNotifyWithURLThatFailsToLoad::NPP_New):
3871         (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
3872         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3873         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3874         * GNUmakefile.am:
3875
3876 2011-05-14  Sheriff Bot  <webkit.review.bot@gmail.com>
3877
3878         Unreviewed, rolling out r86476.
3879         http://trac.webkit.org/changeset/86476
3880         https://bugs.webkit.org/show_bug.cgi?id=60832
3881
3882         It made plugins/get-url-notify-with-url-that-fails-to-
3883         load.html crash on GTK (Requested by Ossy on #webkit).
3884
3885         * DumpRenderTree/DumpRenderTree.gypi:
3886         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3887         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Removed.
3888         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3889         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3890         * GNUmakefile.am:
3891
3892 2011-05-13  Anders Carlsson  <andersca@apple.com>
3893
3894         Reviewed by Sam Weinig.
3895
3896         NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
3897         https://bugs.webkit.org/show_bug.cgi?id=60823
3898         <rdar://problem/9430386>
3899
3900         Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.
3901
3902         * DumpRenderTree/DumpRenderTree.gypi:
3903         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3904         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added.
3905         (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad):
3906         (GetURLNotifyWithURLThatFailsToLoad::NPP_New):
3907         (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
3908         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3909         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3910         * GNUmakefile.am:
3911
3912 2011-05-13  Anders Carlsson  <andersca@apple.com>
3913
3914         Build fix.
3915
3916         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp:
3917
3918 2011-05-13  Anders Carlsson  <andersca@apple.com>
3919
3920         Reviewed by Sam Weinig.
3921
3922         NPN_GetURL with a javascript: URL doesn't send back the result in the stream
3923         https://bugs.webkit.org/show_bug.cgi?id=60810
3924
3925         Add a test that calls NPN_GetURL on a javascript: URL and checks that it gets back the expected result.
3926
3927         * DumpRenderTree/DumpRenderTree.gypi:
3928         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3929         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3930         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3931         * GNUmakefile.am:
3932         Add files.
3933
3934         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3935         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3936         Add new NPN and NPP wrappers and sort them according to the order they appear in npfunctions.h
3937
3938         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp: Added.
3939         (GetURLWithJavaScriptURL::GetURLWithJavaScriptURL):
3940         (GetURLWithJavaScriptURL::NPP_New):
3941         (GetURLWithJavaScriptURL::NPP_NewStream):
3942         (GetURLWithJavaScriptURL::NPP_DestroyStream):
3943         (GetURLWithJavaScriptURL::NPP_WriteReady):
3944         (GetURLWithJavaScriptURL::NPP_Write):
3945         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3946         (NPP_NewStream):
3947         (NPP_WriteReady):
3948         (NPP_Write):
3949         (NPP_URLNotify):
3950         call the PluginTest NPP wrappers.
3951
3952 2011-05-13  Sheriff Bot  <webkit.review.bot@gmail.com>
3953
3954         Unreviewed, rolling out r86447.
3955         http://trac.webkit.org/changeset/86447
3956         https://bugs.webkit.org/show_bug.cgi?id=60809
3957
3958         "Broke some uses of EventSender object on Qt" (Requested by
3959         mwenge on #webkit).
3960
3961         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3962         (WebCore::WebPage::WebPage):
3963         (WebCore::DumpRenderTree::DumpRenderTree):
3964         (WebCore::DumpRenderTree::initJSObjects):
3965         (WebCore::DumpRenderTree::createWindow):
3966         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3967         (WebCore::DumpRenderTree::eventSender):
3968         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3969         (webkit_test_plugin_new_instance):
3970         (webkit_test_plugin_set_window):
3971         (webkit_test_plugin_handle_event):
3972
3973 2011-05-13  Robert Hogan  <robert@webkit.org>
3974
3975         Reviewed by Benjamin Poulain.
3976
3977         [Qt] fix http/tests/plugins/plugin-document-has-focus.html
3978
3979         The support for this test added to the unix test plugin here
3980         may allow other platforms to pass it (nearly everyone
3981         skips it). On Qt it required a bit of trickiness with
3982         the page's EventSender object to get it working fully though,
3983         so only unskipping Qt here.
3984
3985         https://bugs.webkit.org/show_bug.cgi?id=60722
3986
3987         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3988         (WebCore::WebPage::WebPage):
3989         (WebCore::WebPage::eventSender):
3990         (WebCore::DumpRenderTree::DumpRenderTree):
3991         (WebCore::DumpRenderTree::initJSObjects):
3992         (WebCore::DumpRenderTree::createWindow):
3993         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3994         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3995         (webkit_test_plugin_new_instance):
3996         (webkit_test_plugin_set_window):
3997         (webkit_test_plugin_handle_event):
3998
3999 2011-05-13  Adam Roben  <aroben@apple.com>
4000
4001         Exclude the Leopard NRWT bot from the core builder set
4002
4003         Fixes <http://webkit.org/b/60392> Leopard Intel Release (NRWT) shouldn't be a core builder
4004
4005         Reviewed by Darin Adler.
4006
4007         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
4008         (BuildBot.__init__): Tighten up the Leopard regexp to only allow the non-NRWT Leopard bots
4009         in the core builder set.
4010
4011         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
4012         (BuildBotTest.test_builder_name_regexps): Updated to match the current set of builders and
4013         regexps.
4014
4015 2011-05-13  Adam Roben  <aroben@apple.com>
4016
4017         Group all the NRWT bots together
4018
4019         This also gets the new NRWT bots out of the middle of Apple's bots. Since these new NRWT
4020         bots are experimental, it seems best not to clutter up the non-experimental bots with
4021         experimental ones.
4022
4023         Fixes <http://webkit.org/b/60769> New "(NRWT)" bots are right in the middle of Apple's bots
4024         on build.webkit.org
4025
4026         Reviewed by Dan Bernstein.
4027
4028         * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the "(NRWT)" bots next to the
4029         Chromium testers, which also use new-run-webkit-tests.
4030
4031 2011-05-13  Adam Roben  <aroben@apple.com>
4032
4033         Add a plugin test that dumps the plugin window's rect
4034
4035         Part of the test for <http://webkit.org/b/60194> <rdar://problem/9383760> REGRESSION
4036         (r79167): Windowed plugins in Google Reader don't move when the article list is scrolled
4037
4038         Reviewed by Dan Bernstein.
4039
4040         * DumpRenderTree/TestNetscapePlugIn/Tests/win/DumpWindowRect.cpp: Added.
4041         (DumpWindowRect::DumpWindowRect): Just call up to the base class.
4042         (DumpWindowRect::performWindowGeometryTest): Find our window rect relative to the test
4043         harness window and log it.
4044
4045         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added DumpWindowRect.
4046
4047 2011-05-13  Adam Roben  <aroben@apple.com>
4048
4049         Move code required for most tests of plugin window geometry into a base class
4050
4051         WebKit2's asynchronous plugin window positioning makes testing window geometry tricky. By
4052         having all the trickiness in a shared base class, writing new window geometry tests will be
4053         much easier.
4054
4055         Fixes <http://webkit.org/b/60776> It's hard to write tests that check plugin window geometry
4056
4057         Reviewed by Anders Carlsson.
4058
4059         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp:
4060         (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Changed to inherit from the new
4061         WindowGeometryTest base class. Most of the code from this class was moved to the new base
4062         class.
4063         (WindowRegionIsSetToClipRect::performWindowGeometryTest): Renamed from checkWindowRegion.
4064         This is called by the base class when it is safe to check the window's geometry. Note that
4065         the m_didCheckWindowRegion logic was removed completely; it has never been needed and was
4066         just vestigial code from an earlier version of this test.
4067
4068         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added new
4069         WindowGeometryTest class.
4070
4071         * DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.cpp: Added. Code came from
4072         WindowRegionIsSetToClipRect.
4073         (WindowGeometryTest::finishTest): This is the only change from WindowRegionIsSetToClipRect.
4074         We now call the new virtual performWindowGeometryTest function instead of checkWindowRegion.
4075         Subclasses can implement that function to perform their own tests.
4076
4077         * DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.h: Added.
4078
4079 2011-05-13  Zoltan Herczeg  <zherczeg@webkit.org>
4080
4081         Reviewed by Csaba Osztrogonác.
4082
4083         Missing 2nd #EOF if WebProcess is killed.
4084         https://bugs.webkit.org/show_bug.cgi?id=60761
4085
4086         If the WebProcess is killed, only one #EOF is yielded
4087         by WebKitTestRunner. However, run-webkit-test wait for
4088         a second #EOF, which signals the finishing of pixel dump.
4089         Since this never happens, run-webkit-test waits forever.
4090
4091         * WebKitTestRunner/TestInvocation.cpp:
4092         (WTR::TestInvocation::dump):
4093         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
4094         * WebKitTestRunner/TestInvocation.h:
4095
4096 2011-05-13  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
4097
4098         Reviewed by Csaba Osztrogonác.
4099
4100         [NRWT] chromium-linux tests shouldn't run on other platforms
4101         https://bugs.webkit.org/show_bug.cgi?id=60162
4102
4103         Remove _tests_for_other_platforms defs because r82753
4104         implemented it properly in the baseclass in webkit.py.
4105
4106         * Scripts/webkitpy/layout_tests/port/gtk.py:
4107         * Scripts/webkitpy/layout_tests/port/qt.py:
4108         * Scripts/webkitpy/layout_tests/port/win.py:
4109
4110 2011-05-12  Ryuan Choi  <ryuan.choi@samsung.com>
4111
4112         Reviewed by Antonio Gomes.
4113
4114         [EFL] Remove unused option of EWeblauncher
4115         https://bugs.webkit.org/show_bug.cgi?id=60747
4116
4117         Remove sudo-workaround option.
4118         This option is not used and make other option wrong.
4119
4120         * EWebLauncher/main.c:
4121
4122 2011-05-12  Lucas Forschler  <lforschler@apple.com>
4123
4124         Reviewed by Stephanie Lewis.
4125
4126         Fix config.json to address missing WK2 builder/tester config.
4127         Fix naming of machines (xserve not macpro)
4128
4129         * BuildSlaveSupport/build.webkit.org-config/config.json:
4130
4131 2011-05-12  Lucas Forschler  <lforschler@apple.com>
4132
4133         Reviewed by Stephanie Lewis.
4134
4135         Add SnowLeopard Debug builder and Test bot.
4136         apple-xserve-8 = SL Debug Tester.
4137         apple-xserve-9 = SL Debug Builder.
4138         
4139         * BuildSlaveSupport/build.webkit.org-config/config.json:
4140
4141 2011-05-12  Adam Barth  <abarth@webkit.org>
4142
4143         This patch disables sheriffbot's bug postings.  He's just been way too
4144         spammy recently due to test flakiness.
4145
4146         * Scripts/webkitpy/tool/commands/sheriffbot.py:
4147         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
4148
4149 2011-05-11  Brian Weinstein  <bweinstein@apple.com>
4150
4151         Reviewed by Anders Carlsson.
4152
4153         After relaunching an unresponsive web process, web page stops responding to mouse movement
4154         https://bugs.webkit.org/show_bug.cgi?id=60669
4155         <rdar://problem/9409934>
4156         
4157         This test follows the steps needed to reproduce this bug:
4158         1) Hang the web process
4159         2) While the web process is hung, move the mouse (so WebPageProxy thinks it is processing a mouse move event)
4160         3) Kill and restart the WebProcess
4161         4) Move the mouse
4162         
4163         We are testing that we receive mouse move events after the WebProcess has restarted.
4164
4165         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp: Added.
4166         (TestWebKitAPI::didFinishLoadForFrame): Set a flag that we finished loading.
4167         (TestWebKitAPI::processDidBecomeUnresponsive): Kill the web process once we become unresponsive.
4168         (TestWebKitAPI::processDidCrash): Reload the page when the process crashes, which restarts the web process.
4169         (TestWebKitAPI::setPageLoaderClient):
4170         (TestWebKitAPI::TEST):
4171         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp: Added.
4172         (TestWebKitAPI::MouseMoveAfterCrashTest::MouseMoveAfterCrashTest):
4173         (TestWebKitAPI::MouseMoveAfterCrashTest::didReceiveMessage):
4174         * TestWebKitAPI/Tests/WebKit2/mouse-move-listener.html: Added.
4175
4176         * TestWebKitAPI/PlatformWebView.h:
4177         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
4178         (TestWebKitAPI::PlatformWebView::simulateMouseMove): Sends the messages that simulate a mouse move.
4179         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
4180         (TestWebKitAPI::PlatformWebView::simulateMouseMove): Ditto.
4181
4182         Add new files.
4183         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4184         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
4185         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
4186         * TestWebKitAPI/win/copy-resources.cmd:
4187
4188 2011-05-12  Tomasz Morawski  <t.morawski@samsung.com>
4189
4190         Reviewed by Antonio Gomes.
4191
4192         [EFL] Added initialization/shutdown for ecore_file library
4193         https://bugs.webkit.org/show_bug.cgi?id=60457
4194
4195         Added initialization and shuthown for ecore_file library and replaced
4196         realpath function to ecore_file_realpath.
4197
4198         * EWebLauncher/main.c:
4199         (quit):
4200         (findThemePath):
4201         (main):
4202
4203 2011-05-12  Young Han Lee  <joybro@company100.net>
4204
4205         Reviewed by Kenneth Rohde Christiansen.
4206
4207         [Qt] Implement layoutTestController.layerTreeAsText()
4208         https://bugs.webkit.org/show_bug.cgi?id=60367
4209
4210         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4211         (LayoutTestController::layerTreeAsText):
4212         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4213
4214 2011-05-11  Eric Seidel  <eric@webkit.org>
4215
4216         Reviewed by David Levin.
4217
4218         Teach validate-committer-lists how to validate committers bugzilla_email()
4219         https://bugs.webkit.org/show_bug.cgi?id=60651
4220
4221         It turns out we currently have 9 committers with invalid values for their
4222         bugzilla_email field (meaning we don't know what email is their bugzilla account).
4223         "Alexander Kellett" <lypanov@mac.com>
4224         "Andre Boule" <aboule@apple.com>
4225         "Cameron McCormack" <cam@webkit.org>
4226         "Chris Petersen" <cpetersen@apple.com>
4227         "Eli Fidler" <eli@staikos.net>
4228         "Matt Lilek" <webkit@mattlilek.com>
4229         "Pierre d'Herbemont" <pdherbemont@free.fr>
4230         "Scott Violet" <sky@chromium.org>
4231         "Adam Treat" <treat@kde.org>
4232
4233         Most of those haven't committed in a very long time, so it's not suprising
4234         that we haven't noticed that their bugzilla emails are bogus.
4235
4236         * Scripts/validate-committer-lists:
4237         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4238         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
4239
4240 2011-05-11  Dmitry Lomov  <dslomov@google.com>
4241
4242         Reviewed by David Levin.
4243
4244         https://bugs.webkit.org/show_bug.cgi?id=59561
4245         Switch TestWebKitAPI to GTest
4246
4247         Fixes Makefiles and WinCairo build as well
4248
4249         * Makefile:
4250         * Scripts/build-api-tests:
4251         * Scripts/run-api-tests:
4252         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
4253         * TestWebKitAPI/Test.h:
4254         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4255         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
4256         (TestWebKitAPI::TEST):
4257         * TestWebKitAPI/TestsController.cpp:
4258         (TestWebKitAPI::TestsController::TestsController):
4259         (TestWebKitAPI::TestsController::dumpTestNames):
4260         (TestWebKitAPI::TestsController::runTestNamed):
4261         (TestWebKitAPI::TestsController::runAllTests):
4262         * TestWebKitAPI/TestsController.h:
4263         * TestWebKitAPI/mac/main.mm:
4264         (main):
4265
4266 2011-05-11  Eric Seidel  <eric@webkit.org>
4267
4268         Reviewed by Alexey Proskuryakov.
4269
4270         Add Luke Macpherson to committers.py as a Contributor
4271         https://bugs.webkit.org/show_bug.cgi?id=60639
4272
4273         * Scripts/webkitpy/common/config/committers.py:
4274
4275 2011-05-11  Noam Rosenthal  <noam.rosenthal@nokia.com>
4276
4277         Reviewed by Kenneth Rohde Christiansen.
4278
4279         [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
4280         https://bugs.webkit.org/show_bug.cgi?id=60439
4281
4282         Patch 4/12: Update the build script to enable 3D rendering by default for Qt.
4283
4284         * Scripts/build-webkit:
4285
4286 2011-05-11  Brian Weinstein  <bweinstein@apple.com>
4287
4288         Reviewed by Adam Roben.
4289
4290         REGRESSION (r86161): WKPreferences API test failing on Windows
4291         https://bugs.webkit.org/show_bug.cgi?id=60658
4292
4293         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
4294         (TestWebKitAPI::TEST):
4295
4296 2011-05-11  Alice Boxhall  <aboxhall@chromium.org>
4297
4298         Reviewed by Ojan Vafai.
4299
4300         Modify jsonresults_unittest.py to use a dict format for its test data, and modify jsonresults.py to flatten hierarchical directory structures in input JSON.
4301         https://bugs.webkit.org/show_bug.cgi?id=60521
4302
4303         First steps towards making the results JSON all hierarchical.
4304
4305         * TestResultServer/model/jsonresults.py:
4306         * TestResultServer/model/jsonresults_unittest.py:
4307
4308 2011-05-11  Kevin Ollivier  <kevino@theolliviers.com>
4309
4310         [wx] Build fix, adding new LayoutTestController method stubs.
4311
4312         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4313         (LayoutTestController::localStorageDiskUsageForOrigin):
4314         (LayoutTestController::applicationCacheDiskUsageForOrigin):
4315
4316 2011-05-11  Jessie Berlin  <jberlin@apple.com>
4317
4318         Reviewed by Darin Adler.
4319
4320         [WebKit2] exceededDatabaseQuota function on WKPageUIClient needs to provide information
4321         about the usage for both the origin overall and the database in question.
4322         https://bugs.webkit.org/show_bug.cgi?id=60573
4323
4324         * WebKitTestRunner/TestController.cpp:
4325         (WTR::exceededDatabaseQuota):
4326
4327 2011-05-10  Stephen White  <senorblanco@chromium.org>
4328
4329         Reviewed by David Levin.
4330
4331         Adding myself as a reviewer.
4332         https://bugs.webkit.org/show_bug.cgi?id=60587
4333
4334         * Scripts/webkitpy/common/config/committers.py:
4335
4336 2011-05-11  Eric Seidel  <eric@webkit.org>
4337
4338         Reviewed by Csaba Osztrogonác.
4339
4340         queues.webkit.org should show 1000+ instead of 1000 when we hit the query limit
4341         https://bugs.webkit.org/show_bug.cgi?id=60614
4342
4343         AppEngine has a result limit of 1000.  We hit that when trying
4344         to find out how many patches the style-queue (and other queues)
4345         have passed in the last 30 days. &nb