Create a MAC EWS startup shell script.
[WebKit-https.git] / Tools / ChangeLog
1 2013-01-22  Lucas Forschler  <lforschler@apple.com>
2
3         Create a MAC EWS startup shell script.
4
5         Reviewed by Ryosuke Niwa.
6
7         * EWSTools/start-queue-mac.sh: Added.
8
9 2013-01-22  Joseph Pecoraro  <pecoraro@apple.com>
10
11         [Mac] Enable Page Visibility (PAGE_VISIBILITY_API)
12         https://bugs.webkit.org/show_bug.cgi?id=107230
13
14         Reviewed by David Kilzer.
15
16         * DumpRenderTree/mac/TestRunnerMac.mm:
17         (TestRunner::resetPageVisibility):
18         Fix a typo in the original implementation. resetPageVisibility should
19         pass initialState YES so an event is not dispatched, which causes
20         issues in multiple tests. This now matches other ports.
21
22 2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
23
24         [GTK] Enable CSS Image Orientation feature
25         https://bugs.webkit.org/show_bug.cgi?id=99040
26
27         Reviewed by Martin Robinson.
28
29         Enable the CSS Image Orientation feature in the development
30         builds of the GTK port. The feature is still disabled in the release
31         builds.
32
33         * Scripts/webkitperl/FeatureList.pm:
34
35 2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
36
37         [GTK] Enable the <template> element support in development builds
38         https://bugs.webkit.org/show_bug.cgi?id=106575
39
40         Reviewed by Martin Robinson.
41
42         Enable the <template> element support in the development builds of the GTK port.
43
44         * Scripts/webkitperl/FeatureList.pm:
45
46 2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
47
48         Prettify the output of the override-feature-defines script
49         https://bugs.webkit.org/show_bug.cgi?id=106542
50
51         Reviewed by Martin Robinson.
52
53         The output now clearly lists the feature defines being overridden
54         along with the default and overriding values for each feature define.
55
56         * gtk/override-feature-defines:
57         (adjust_feature_defines_makefile):
58         (adjust_feature_defines_makefile.override_feature_define):
59
60 2013-01-22  Zan Dobersek  <zdobersek@igalia.com>
61
62         Remove uses of deprecated unittest.TestCase aliases
63         https://bugs.webkit.org/show_bug.cgi?id=102252
64
65         Reviewed by Adam Barth.
66
67         Replace the deprecated assertEquals method of the TestCase interface
68         used in some webkitpy unittests with the assertEqual method.
69
70         * Scripts/webkitpy/common/system/profiler_unittest.py:
71         (ProfilerFactoryTest._assert_default_profiler_name):
72         (ProfilerFactoryTest.test_default_profiler_output):
73         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
74         (GtkPortTest.test_expectations_files):
75         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
76         (TestHttpServer.test_win32_start_and_stop):
77
78 2013-01-22  Jer Noble  <jer.noble@apple.com>
79
80         REGRESSION(r140344): Repeated crashes in WKTR PlatformWebView::viewSupportsOptions().
81         https://bugs.webkit.org/show_bug.cgi?id=107562
82
83         Rubber-stamped by Alexy Proskuryakov.
84
85         The input to WKBooleanGetValue() is not NULL-safe, so NULL check its inputs before calling.
86
87         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
88         (WTR::PlatformWebView::PlatformWebView):
89         (WTR::PlatformWebView::viewSupportsOptions):
90
91 2013-01-22  Alexey Proskuryakov  <ap@apple.com>
92
93         One is not allowed to use commit-queue to make oneself a committer.
94
95         * Scripts/webkitpy/common/config/committers.py: Removing eustas@chromium.org.
96
97 2013-01-22  Eugene Klyuchnikov  <eustas@chromium.org>
98
99         Add myself to commiters.py
100         https://bugs.webkit.org/show_bug.cgi?id=107546
101
102         Reviewed by Kentaro Hara.
103
104         * Scripts/webkitpy/common/config/committers.py:
105
106 2013-01-22  Manuel Rego Casasnovas  <rego@igalia.com>
107
108         [GTK] Implement TestRunner::setTextDirection
109         https://bugs.webkit.org/show_bug.cgi?id=107131
110
111         Reviewed by Philippe Normand.
112
113         * DumpRenderTree/gtk/DumpRenderTree.cpp:
114         (resetDefaultsToConsistentValues): Reset direction to default value.
115         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
116         (TestRunner::setTextDirection): Implement method using
117         gtk_widget_set_direction.
118
119 2013-01-22  Jochen Eisinger  <jochen@chromium.org>
120
121         [chromium] move spell checking mocks to TestRunner library
122         https://bugs.webkit.org/show_bug.cgi?id=107455
123
124         Reviewed by Kent Tamura.
125
126         The content module doesn't provide its own WebSpellCheckClient.
127
128         * DumpRenderTree/DumpRenderTree.gypi:
129         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
130         (WebTestRunner::WebTestDelegate::fillSpellingSuggestionList):
131         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
132         (WebKit):
133         (WebTestRunner):
134         (WebTestProxyBase):
135         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
136         (WebTestRunner):
137         (WebTestRunner::makeMenuItemStringsFor):
138         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Renamed from Tools/DumpRenderTree/chromium/MockGrammarCheck.cpp.
139         (MockGrammarCheck::checkGrammarOfString):
140         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Renamed from Tools/DumpRenderTree/chromium/MockGrammarCheck.h.
141         (WebKit):
142         (MockGrammarCheck):
143         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Renamed from Tools/DumpRenderTree/chromium/MockSpellCheck.cpp.
144         (MockSpellCheck::MockSpellCheck):
145         (MockSpellCheck::~MockSpellCheck):
146         (isNotASCIIAlpha):
147         (MockSpellCheck::spellCheckWord):
148         (MockSpellCheck::fillSuggestionList):
149         (MockSpellCheck::initializeIfNeeded):
150         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Renamed from Tools/DumpRenderTree/chromium/MockSpellCheck.h.
151         (MockSpellCheck):
152         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Added.
153         (WebTestRunner::SpellCheckClient::SpellCheckClient):
154         (WebTestRunner):
155         (WebTestRunner::SpellCheckClient::~SpellCheckClient):
156         (WebTestRunner::SpellCheckClient::setDelegate):
157         (WebTestRunner::SpellCheckClient::spellCheck):
158         (WebTestRunner::SpellCheckClient::checkTextOfParagraph):
159         (WebTestRunner::SpellCheckClient::requestCheckingOfText):
160         (WebTestRunner::SpellCheckClient::finishLastTextCheck):
161         (WebTestRunner::SpellCheckClient::autoCorrectWord):
162         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h.
163         (WebTestRunner):
164         (SpellCheckClient):
165         (WebTestRunner::SpellCheckClient::taskList):
166         (WebTestRunner::SpellCheckClient::mockSpellCheck):
167         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
168         (TestDelegate):
169         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
170         (WebTestInterfaces::Internal):
171         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
172         (WebTestRunner::WebTestProxyBase::WebTestProxyBase):
173         (WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
174         (WebTestRunner::WebTestProxyBase::setDelegate):
175         (WebTestRunner::WebTestProxyBase::spellCheckClient):
176         (WebTestRunner):
177         * DumpRenderTree/chromium/WebViewHost.cpp:
178         (WebViewHost::WebViewHost):
179         (WebViewHost::setWebWidget):
180         * DumpRenderTree/chromium/WebViewHost.h:
181         (WebViewHost):
182
183 2013-01-22  Krzysztof Czech  <k.czech@samsung.com>
184
185         [EFL] Adds Accessibility support to wk1
186         https://bugs.webkit.org/show_bug.cgi?id=107440
187
188         Reviewed by Gyuyoung Kim.
189
190         * DumpRenderTree/efl/CMakeLists.txt: Adds ATK headers and libraries.
191
192 2013-01-21  Joseph Pecoraro  <pecoraro@apple.com>
193
194         [Mac] WK1 MiniBrowser should clear delegates before releasing webview
195         https://bugs.webkit.org/show_bug.cgi?id=107506
196
197         Reviewed by Dan Bernstein.
198
199         * MiniBrowser/mac/WK1BrowserWindowController.m:
200         (-[WK1BrowserWindowController dealloc]):
201
202 2013-01-21  Dirk Schulze  <dschulze@adobe.com>
203
204         Add build flag for Canvas's Path object (disabled by default)
205         https://bugs.webkit.org/show_bug.cgi?id=107473
206
207         Reviewed by Dean Jackson.
208
209         Add CANVAS_PATH build flag to build systems.
210
211         * Scripts/webkitperl/FeatureList.pm:
212
213 2013-01-21  Jinwoo Song  <jinwoo7.song@samsung.com>
214
215         [EFL][WK2] Add APIs to set/get view source mode
216         https://bugs.webkit.org/show_bug.cgi?id=106633
217
218         Reviewed by Gyuyoung Kim.
219
220         Added a shotcut 'F8' in Minibrowser to display a source code
221         of the web page in a new window.
222
223        * MiniBrowser/efl/main.c:
224         (on_key_down):
225         (on_window_create):
226         (window_create):
227         (elm_main):
228
229 2013-01-21  Nico Weber  <thakis@chromium.org>
230
231         [chromium] Don't archive generated source files.
232         https://bugs.webkit.org/show_bug.cgi?id=106736
233
234         Reviewed by Eric Seidel.
235
236         They shouldn't be needed to run tests. They don't need a lot of space,
237         but add many lines to the "extracting" stdout. This attempts to reduce
238         that noise a bit.
239
240         * BuildSlaveSupport/built-product-archive:
241         (archiveBuiltProduct):
242
243 2013-01-21  Benjamin Poulain  <benjamin@webkit.org>
244
245         Mac DumpRenderTree's installSignalHandlers() is unreachable code
246         https://bugs.webkit.org/show_bug.cgi?id=107383
247
248         Reviewed by Sam Weinig.
249
250         The CrashHandler of DumpRenderTree were originally used for restoring
251         the color profile of the main display even if DRT crashes.
252
253         That feature was later limited to pixel tests only in r29999.
254
255         In r104351, the DRT was changed to use device color space. Making the crash
256         handlers useless, but they were left in the code since the error reporting
257         code was still reachable.
258
259         Later, r124581 refactored the code and dumpPixelsForCurrentTest
260         is being used before being assigned its value.
261         This did cause any regression because the code had become useless with the previous change.
262
263         * DumpRenderTree/mac/DumpRenderTree.mm:
264         Remove crashHandler() and installSignalHandlers() as they have become useless and
265         have been unreachable code for 6 months.
266         (dumpRenderTree):
267         Remove the code that was unreachable due to dumpPixelsForCurrentTest being always false
268         at those points.
269
270 2013-01-21  Nico Weber  <thakis@chromium.org>
271
272         Make ninja the default build system for build-webkit --chromium on mac
273         https://bugs.webkit.org/show_bug.cgi?id=106737
274
275         Reviewed by Eric Seidel.
276
277         * Scripts/update-webkit-chromium:
278
279 2013-01-21  Christophe Dumez  <christophe.dumez@intel.com>
280
281         Regression(r140262): Causes a lot of flakiness
282         https://bugs.webkit.org/show_bug.cgi?id=107454
283
284         Reviewed by Alexey Proskuryakov.
285
286         r140262 introduced a lot of flakiness due to fixed layout mode
287         not getting disabled on the view after being enabled for
288         specific test cases. This patch makes sure fixed layout mode
289         properly gets reset in WebKitTestRunner to avoid flakiness.
290
291         * WebKitTestRunner/TestInvocation.cpp:
292         (WTR::updateLayoutType):
293
294 2013-01-21  Gustavo Noronha Silva  <gns@gnome.org>
295
296         REGRESSION (r140285): GTK uses WKPageResourceLoadClient which was removed
297         https://bugs.webkit.org/show_bug.cgi?id=107421
298
299         Unreviewed build fix.
300
301         * Scripts/run-gtk-tests:
302         (TestRunner): skip Resource tests.
303
304 2013-01-21  Christophe Dumez  <christophe.dumez@intel.com>
305
306         [EFL][WKTR] platformRunUntil() should keep the main loop running
307         https://bugs.webkit.org/show_bug.cgi?id=107442
308
309         Reviewed by Noam Rosenthal.
310
311         EFL's implementation of platformRunUntil() should keep the main loop
312         running and avoid calling sleep() between calls to
313         ecore_main_loop_iterate(). This call to sleep seems to be a source
314         of deadlocks (see Bug 106884).
315
316         * WebKitTestRunner/efl/TestControllerEfl.cpp:
317         (WTR::TestController::platformRunUntil):
318
319 2013-01-21  Vivek Galatage  <vivek.vg@samsung.com>
320
321         QtTestBrowser should provide way to clear selected elements
322         https://bugs.webkit.org/show_bug.cgi?id=107437
323
324         Reviewed by Simon Hausmann.
325
326         Provide a way to "Clear selection" in the "Develop" menu to clear the previous search highlight.
327         Invoke the clearSelection prior to highlighting new elements.
328
329         * QtTestBrowser/launcherwindow.cpp:
330         (ElementHighlight):
331         (LauncherWindow::createChrome):
332         (LauncherWindow::selectElements):
333         (LauncherWindow::clearSelection):
334         * QtTestBrowser/launcherwindow.h:
335         (LauncherWindow):
336
337 2013-01-21  Jochen Eisinger  <jochen@chromium.org>
338
339         [chromium] move methods interacting with willSendRequest to TestRunner
340         https://bugs.webkit.org/show_bug.cgi?id=107270
341
342         Reviewed by Kent Tamura.
343
344         * DumpRenderTree/chromium/DRTTestRunner.cpp:
345         (DRTTestRunner::DRTTestRunner):
346         (DRTTestRunner::waitForPolicyDelegate):
347         * DumpRenderTree/chromium/DRTTestRunner.h:
348         (DRTTestRunner):
349         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
350         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
351         (WebTestRunner::WebTestRunner::httpHeadersToClear):
352         (WebTestRunner::WebTestRunner::shouldBlockRedirects):
353         (WebTestRunner::WebTestRunner::willSendRequestShouldReturnNull):
354         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
355         (WebTestRunner::TestRunner::TestRunner):
356         (WebTestRunner::TestRunner::reset):
357         (WebTestRunner::TestRunner::httpHeadersToClear):
358         (WebTestRunner):
359         (WebTestRunner::TestRunner::shouldBlockRedirects):
360         (WebTestRunner::TestRunner::willSendRequestShouldReturnNull):
361         (WebTestRunner::TestRunner::setWillSendRequestClearHeader):
362         (WebTestRunner::TestRunner::setWillSendRequestReturnsNullOnRedirect):
363         (WebTestRunner::TestRunner::setWillSendRequestReturnsNull):
364         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
365         (TestRunner):
366         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
367         (WebTestRunner::WebTestProxyBase::willSendRequest):
368         * DumpRenderTree/chromium/WebViewHost.cpp:
369         (WebViewHost::willSendRequest):
370         (WebViewHost::reset):
371         * DumpRenderTree/chromium/WebViewHost.h:
372         (WebViewHost):
373
374 2013-01-21  Zan Dobersek  <zdobersek@igalia.com>
375
376         [GTK] Stop building WebKit2 on GTK EWSs
377         https://bugs.webkit.org/show_bug.cgi?id=107435
378
379         Reviewed by Philippe Normand.
380
381         The WebKit2 build of the GTK is at the moment not efficiently maintainable,
382         so stop building it on GTK EWSs.
383
384         * Scripts/webkitpy/common/config/ports.py:
385         (GtkPort.build_webkit_command):
386         * Scripts/webkitpy/common/config/ports_unittest.py:
387         (DeprecatedPortTest.test_gtk_port):
388
389 2013-01-21  Tommy Widenflycht  <tommyw@google.com>
390
391         MediaStream API: Update the RTCPeerConnection states to match the latest specification
392         https://bugs.webkit.org/show_bug.cgi?id=107120
393
394         Reviewed by Adam Barth.
395
396         Updating mock to use the new states.
397
398         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
399         (RTCPeerConnectionStateTask::RTCPeerConnectionStateTask):
400         (MockWebRTCPeerConnectionHandler::initialize):
401         (MockWebRTCPeerConnectionHandler::updateICE):
402
403 2013-01-20  Tim 'mithro' Ansell  <mithro@mithis.com>
404
405         Extend diff_parser to support the --full-index output.
406         https://bugs.webkit.org/show_bug.cgi?id=107408
407
408         Reviewed by Maciej Stachowiak.
409
410         * Scripts/webkitpy/common/checkout/diff_parser.py:
411         (git_diff_to_svn_diff):
412         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
413         (DiffParserTest):
414         (DiffParserTest.test_git_diff_to_svn_diff):
415         (git_diff_to_svn_diff):
416
417 2013-01-20  Yoshifumi Inoue  <yosin@chromium.org>
418
419         Dragging over an element with scrollbars should scroll the element when dragging near edges
420         https://bugs.webkit.org/show_bug.cgi?id=39725
421
422         Reviewed by Hajime Morita.
423
424         This patch introduces canceling drag-and-drop by escape key for testing
425         behavior after cancellation drag-and-drop.
426
427         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
428         (WebTestRunner):
429         (WebTestRunner::EventSender::doMouseUp):
430         (WebTestRunner::EventSender::finishDragAndDrop):
431         (WebTestRunner::EventSender::keyDown):
432         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
433         (EventSender):
434         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Added VKEY_ESCAPE.
435
436 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
437
438         [chromium] move frame generation related methods to TestRunner
439         https://bugs.webkit.org/show_bug.cgi?id=107268
440
441         Reviewed by Adam Barth.
442
443         * DumpRenderTree/chromium/DRTTestRunner.cpp:
444         (DRTTestRunner::DRTTestRunner):
445         (DRTTestRunner::setWillSendRequestReturnsNull):
446         * DumpRenderTree/chromium/DRTTestRunner.h:
447         (DRTTestRunner):
448         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
449         (WebTestRunner::WebTestDelegate::display):
450         (WebTestRunner::WebTestDelegate::displayInvalidatedRegion):
451         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
452         (WebTestRunner::TestRunner::TestRunner):
453         (WebTestRunner::TestRunner::display):
454         (WebTestRunner):
455         (WebTestRunner::TestRunner::displayInvalidatedRegion):
456         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
457         (TestRunner):
458         * DumpRenderTree/chromium/WebViewHost.cpp:
459         (WebViewHost::display):
460         (WebViewHost::displayInvalidatedRegion):
461         * DumpRenderTree/chromium/WebViewHost.h:
462
463 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
464
465         [chromium] move speech related methods to TestRunner library
466         https://bugs.webkit.org/show_bug.cgi?id=107266
467
468         Reviewed by Adam Barth.
469
470         * DumpRenderTree/chromium/DRTTestRunner.cpp:
471         (DRTTestRunner::DRTTestRunner):
472         (DRTTestRunner::displayInvalidatedRegion):
473         * DumpRenderTree/chromium/DRTTestRunner.h:
474         (DRTTestRunner):
475         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
476         (WebTestDelegate):
477         (WebTestRunner::WebTestDelegate::addMockSpeechInputResult):
478         (WebTestRunner::WebTestDelegate::setMockSpeechInputDumpRect):
479         (WebTestRunner::WebTestDelegate::addMockSpeechRecognitionResult):
480         (WebTestRunner::WebTestDelegate::setMockSpeechRecognitionError):
481         (WebTestRunner::WebTestDelegate::wasMockSpeechRecognitionAborted):
482         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
483         (WebTestRunner::TestRunner::TestRunner):
484         (WebTestRunner):
485         (WebTestRunner::TestRunner::addMockSpeechInputResult):
486         (WebTestRunner::TestRunner::setMockSpeechInputDumpRect):
487         (WebTestRunner::TestRunner::addMockSpeechRecognitionResult):
488         (WebTestRunner::TestRunner::setMockSpeechRecognitionError):
489         (WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted):
490         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
491         (TestRunner):
492         * DumpRenderTree/chromium/WebViewHost.cpp:
493         (WebViewHost::addMockSpeechInputResult):
494         (WebViewHost::setMockSpeechInputDumpRect):
495         (WebViewHost::addMockSpeechRecognitionResult):
496         (WebViewHost::setMockSpeechRecognitionError):
497         (WebViewHost::wasMockSpeechRecognitionAborted):
498         * DumpRenderTree/chromium/WebViewHost.h:
499
500 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
501
502         [chromium] move notification related methods to TestRunner
503         https://bugs.webkit.org/show_bug.cgi?id=107269
504
505         Reviewed by Adam Barth.
506
507         * DumpRenderTree/chromium/DRTTestRunner.cpp:
508         (DRTTestRunner::DRTTestRunner):
509         * DumpRenderTree/chromium/DRTTestRunner.h:
510         (DRTTestRunner):
511         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
512         (WebTestDelegate):
513         (WebTestRunner::WebTestDelegate::grantWebNotificationPermission):
514         (WebTestRunner::WebTestDelegate::simulateLegacyWebNotificationClick):
515         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
516         (WebTestRunner::TestRunner::TestRunner):
517         (WebTestRunner):
518         (WebTestRunner::TestRunner::grantWebNotificationPermission):
519         (WebTestRunner::TestRunner::simulateLegacyWebNotificationClick):
520         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
521         (TestRunner):
522         * DumpRenderTree/chromium/WebViewHost.cpp:
523         (WebViewHost::grantWebNotificationPermission):
524         (WebViewHost::simulateLegacyWebNotificationClick):
525         * DumpRenderTree/chromium/WebViewHost.h:
526
527 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
528
529         [chromium] move geolocation related methods to TestRunner
530         https://bugs.webkit.org/show_bug.cgi?id=107267
531
532         Reviewed by Adam Barth.
533
534         * DumpRenderTree/chromium/DRTTestRunner.cpp:
535         (DRTTestRunner::DRTTestRunner):
536         * DumpRenderTree/chromium/DRTTestRunner.h:
537         (DRTTestRunner):
538         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
539         (WebTestRunner::WebTestDelegate::numberOfPendingGeolocationPermissionRequests):
540         (WebTestRunner::WebTestDelegate::setGeolocationPermission):
541         (WebTestRunner::WebTestDelegate::setMockGeolocationPosition):
542         (WebTestRunner::WebTestDelegate::setMockGeolocationPositionUnavailableError):
543         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
544         (WebTestRunner::TestRunner::TestRunner):
545         (WebTestRunner::TestRunner::numberOfPendingGeolocationPermissionRequests):
546         (WebTestRunner):
547         (WebTestRunner::TestRunner::setGeolocationPermission):
548         (WebTestRunner::TestRunner::setMockGeolocationPosition):
549         (WebTestRunner::TestRunner::setMockGeolocationPositionUnavailableError):
550         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
551         (TestRunner):
552         * DumpRenderTree/chromium/WebViewHost.cpp:
553         (WebViewHost::numberOfPendingGeolocationPermissionRequests):
554         (WebViewHost::setGeolocationPermission):
555         (WebViewHost::setMockGeolocationPosition):
556         (WebViewHost::setMockGeolocationPositionUnavailableError):
557         * DumpRenderTree/chromium/WebViewHost.h:
558
559 2013-01-19  Zan Dobersek  <zdobersek@igalia.com>
560
561         Unreviewed build fix for Qt WK2 after r140258.
562         Use the size_t type instead of unsigned for the variable
563         which holds the position of the first null character in the
564         console message.
565
566         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
567         (WTR::InjectedBundlePage::willAddMessageToConsole):
568
569 2013-01-19  Sheriff Bot  <webkit.review.bot@gmail.com>
570
571         Unreviewed, rolling out r140260.
572         http://trac.webkit.org/changeset/140260
573         https://bugs.webkit.org/show_bug.cgi?id=107387
574
575         breaks fast/text/hyphens.html, fast/text/hyphenate-* (but
576         nothing else) (Requested by thakis__ on #webkit).
577
578         * Scripts/update-webkit-chromium:
579
580 2013-01-19  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
581
582         Delegated scrolling: Assertion on attempt to show a CSS sticky element
583         https://bugs.webkit.org/show_bug.cgi?id=106890
584
585         Reviewed by Kenneth Rohde Christiansen.
586
587         Enabled fixed layout mode in WTR for 'fast/css/sticky' tests.
588
589         * WebKitTestRunner/TestInvocation.cpp:
590         (WTR::shouldUseFixedLayout):
591         (WTR):
592         (WTR::updateLayoutType):
593
594 2013-01-19  Nico Weber  <thakis@chromium.org>
595
596         Make ninja the default build system for build-webkit --chromium on mac
597         https://bugs.webkit.org/show_bug.cgi?id=106737
598
599         Reviewed by Eric Seidel.
600
601         * Scripts/update-webkit-chromium:
602
603 2013-01-19  Zan Dobersek  <zdobersek@igalia.com>
604
605         [WK2] svg/dom/fuzz-path-parser.html is failing
606         https://bugs.webkit.org/show_bug.cgi?id=107133
607
608         Reviewed by Alexey Proskuryakov.
609
610         Console messages can contain null characters before the end of string.
611         Appending such message to the StringBuilder as a WTFString appends the
612         complete string, including the null character. This later cuts off everything
613         after the null character when the string is being printed out to the test
614         output.
615
616         To avoid this, truncate the string up to the first null character. This
617         preserves the newline character appended immediately after this and
618         stops giving incorrect output.
619
620         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
621         (WTR::InjectedBundlePage::willAddMessageToConsole):
622
623 2013-01-19  Eric Seidel  <eric@webkit.org>
624
625         Update error regexps so that Parser/html-parser-srcdoc.html can "pass"
626         https://bugs.webkit.org/show_bug.cgi?id=107367
627
628         Reviewed by Ryosuke Niwa.
629
630         Using srcdoc instead of document.write changes the error output
631         ever so slightly.  Clearly we were already trying to ignore these
632         messages, just not succeeding.  This change makes this new test "pass" correctly.
633
634         * Scripts/webkitpy/performance_tests/perftest.py:
635         (PerfTest):
636
637 2013-01-18  Dan Winship  <danw@gnome.org>
638
639         REGRESSION (r139071): run-webkit-httpd complains at launch
640         https://bugs.webkit.org/show_bug.cgi?id=107310
641
642         Reviewed by Alexey Proskuryakov.
643
644         * Scripts/webkitperl/httpd.pm:
645         (getApacheVersion): use preferred perl syntax
646
647 2013-01-18  Julie Parent  <jparent@chromium.org>
648
649         Add back 'group' as a default cross dashboard parameter, but with null as its value.
650         https://bugs.webkit.org/show_bug.cgi?id=107336
651
652         We need to have 'group' listed as a parameter, else we never parse it,
653         as we only parse parameters with defaults.
654         
655         Reviewed by Ojan Vafai.
656
657         * TestResultServer/static-dashboards/dashboard_base.js:
658
659 2013-01-18  Emil A Eklund  <eae@chromium.org>
660
661         Update LayoutUnit rounding unit test
662         https://bugs.webkit.org/show_bug.cgi?id=107322
663
664         Reviewed by Levi Weintraub.
665         
666         Update the LayoutUnitRounding test to use fromFloatRound for
667         values that cannot accurately be represented as a LayoutUnit
668         (the default behavior is to floor the value to the nearest
669         LayoutUnit).
670
671         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
672         (TestWebKitAPI::TEST):
673
674 2013-01-18  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
675
676         VCSUtils.pm: Stop calling git repo-config.
677         https://bugs.webkit.org/show_bug.cgi?id=107294
678
679         Reviewed by Dirk Pranke.
680
681         The `repo-config' git command has been deprecated since early
682         2008, and recent versions have started warning it is deprecated.
683
684         Basically revert r27870 and use the `config' command all the time.
685
686         * Scripts/VCSUtils.pm:
687         (gitConfig):
688
689 2013-01-18  Levi Weintraub  <leviw@chromium.org>
690
691         LayoutUnit should round half consistently, not away from zero
692         https://bugs.webkit.org/show_bug.cgi?id=107208
693
694         Reviewed by Eric Seidel.
695
696         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp: Updating to reflect and
697         cover this change in rounding behavior.
698
699 2013-01-18  Tim Horton  <timothy_horton@apple.com>
700
701         [mac] DumpRenderTree/WebKitTestRunner should not participate in Exposé/Mission Control
702         https://bugs.webkit.org/show_bug.cgi?id=107234
703
704         Reviewed by Simon Fraser.
705
706         * DumpRenderTree/mac/DumpRenderTree.mm:
707         (createWebViewAndOffscreenWindow): Disable participation in Exposé via NSWindowCollectionBehaviorStationary.
708         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
709         (WTR::PlatformWebView::PlatformWebView): Ditto.
710
711 2013-01-18  Tim Horton  <timothy_horton@apple.com>
712
713         [mac] DumpRenderTree/WebKitTestRunner should disable NSBeep
714         https://bugs.webkit.org/show_bug.cgi?id=107251
715
716         Reviewed by Simon Fraser.
717
718         Disable NSBeep in DumpRenderTree and WebKitTestRunner using NSSound SPI.
719
720         * DumpRenderTree/mac/DumpRenderTree.mm:
721         (dumpRenderTree):
722         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
723         (WTR::InjectedBundle::platformInitialize):
724
725 2013-01-18  Martin Robinson  <mrobinson@igalia.com>
726
727         [GTK] Enable indexed database for development builds
728         https://bugs.webkit.org/show_bug.cgi?id=107299
729
730         Reviewed by Gustavo Noronha Silva.
731
732         * Scripts/webkitperl/FeatureList.pm: Enable indexed database by default
733         for GTK+ development builds.
734
735 2013-01-18  Dominic Mazzoni  <dmazzoni@google.com>
736
737         AX: Improve table-guessing heuristics
738         https://bugs.webkit.org/show_bug.cgi?id=107042
739
740         Reviewed by Chris Fleizach.
741
742         Implement parentElementCallback on Chromium to make testing easier.
743
744         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
745         (WebTestRunner::AccessibilityUIElement::parentElementCallback):
746
747 2013-01-18  Martin Robinson  <mrobinson@igalia.com>
748
749         [GTK] Add property for IndexedDB database path to WebKitGTK+
750         https://bugs.webkit.org/show_bug.cgi?id=106136
751
752         Reviewed by Gustavo Noronha Silva.
753
754         During testing, set the web database directory to DUMPRENDERTREE_TEMP
755         before falling back to the old default. This is necessary because
756         indexed database tests require that each DRT shard is using a different
757         IDB database location.
758
759         * DumpRenderTree/gtk/DumpRenderTree.cpp:
760         (temporaryDatabaseDirectory): Added this helper for getting the
761         database directory.
762         (setDefaultsToConsistentStateValuesForTesting): Use the new helper.
763
764 2013-01-18  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
765
766         [EFL][WK2] Enable API test InjectedBundleFrameHitTest on EFL
767         https://bugs.webkit.org/show_bug.cgi?id=107264
768
769         Reviewed by Laszlo Gombos.
770
771         Enable API test InjectedBundleFrameHitTest for hit-testing,
772         since it is now passing on both Debug and Release builds.
773
774         * TestWebKitAPI/CMakeLists.txt:
775         * TestWebKitAPI/PlatformEfl.cmake:
776
777 2013-01-18  Manuel Rego Casasnovas  <rego@igalia.com>
778
779         [GTK] Implement TestRunner::addUserScript
780         https://bugs.webkit.org/show_bug.cgi?id=107275
781
782         Reviewed by Philippe Normand.
783
784         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
785         (TestRunner::addUserScript): Implement method using
786         DumpRenderTreeSupportGtk::addUserScript.
787
788 2013-01-18  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
789
790         Unreviewed, add my secondary email address to the list.
791
792         * Scripts/webkitpy/common/config/committers.py:
793
794 2013-01-18  Dan Carney  <dcarney@google.com>
795
796         [chromium] move pointerlock functions to TestRunner library
797         https://bugs.webkit.org/show_bug.cgi?id=107241
798
799         Reviewed by Jochen Eisinger.
800
801         * DumpRenderTree/chromium/DRTTestRunner.cpp:
802         (DRTTestRunner::DRTTestRunner):
803         * DumpRenderTree/chromium/DRTTestRunner.h:
804         (DRTTestRunner):
805         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
806         (WebTestRunner::WebTestDelegate::didAcquirePointerLock):
807         (WebTestRunner::WebTestDelegate::didNotAcquirePointerLock):
808         (WebTestRunner::WebTestDelegate::didLosePointerLock):
809         (WebTestRunner::WebTestDelegate::setPointerLockWillRespondAsynchronously):
810         (WebTestRunner::WebTestDelegate::setPointerLockWillFailSynchronously):
811         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
812         (WebTestRunner::TestRunner::TestRunner):
813         (WebTestRunner):
814         (WebTestRunner::TestRunner::didAcquirePointerLock):
815         (WebTestRunner::TestRunner::didNotAcquirePointerLock):
816         (WebTestRunner::TestRunner::didLosePointerLock):
817         (WebTestRunner::TestRunner::setPointerLockWillRespondAsynchronously):
818         (WebTestRunner::TestRunner::setPointerLockWillFailSynchronously):
819         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
820         (TestRunner):
821         * DumpRenderTree/chromium/WebViewHost.h:
822         (WebViewHost):
823
824 2013-01-14  Dominik Röttsches  <dominik.rottsches@intel.com>
825
826         [EFL] Update freetype in jhbuild to 2.4.11 and activate subpixel layout
827         https://bugs.webkit.org/show_bug.cgi?id=106774
828
829         Reviewed by Martin Robinson.
830
831         In order to fix a long standing linespacing/font ascent & descent issue
832         we found that FreeType commit b0962ac34e660 solves that problem.
833         Let's update FreeType accordingly, but bump it to 2.4.11 due to the
834         maintainer recommending several security updates after that said commit.
835
836         Also, in order to avoid extra rebaselining, let's activate subpixel
837         layout at the same time.
838
839         * efl/jhbuild.modules: New freetype 2.4.11
840
841 2013-01-17  Xiaobo Wang  <xbwang@torchmobile.com.cn>
842
843         [BlackBerry] DRT - Accept http/file URL when running drt-launcher from command line
844         https://bugs.webkit.org/show_bug.cgi?id=107107
845         PR 282192
846
847         Reviewed by Rob Buis.
848
849         The DRT application will convert relative/absolute file path to
850         file://<real-file-path> format, so we only check for http/file prefix.
851
852         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
853         (BlackBerry::WebKit::isFullUrl):
854         (WebKit):
855         (BlackBerry::WebKit::DumpRenderTree::runCurrentTest):
856
857 2013-01-17  Frank Farzan  <frankf@chromium.org>
858
859         Flakiness dashboard: Add ChromiumFYI master
860         https://bugs.webkit.org/show_bug.cgi?id=107180
861
862         Reviewed by Ojan Vafai.
863
864         This is needed to enable Chrome Android bots
865         to upload results for instrumentation tests.
866
867         * TestResultServer/generate_builders_json.py:
868         (main):
869         * TestResultServer/static-dashboards/builders.jsonp:
870
871 2013-01-17  Frank Farzan  <frankf@chromium.org>
872
873         Add Chrome on Android instrumentation test types to flakiness dashboard
874         https://bugs.webkit.org/show_bug.cgi?id=106964
875
876         Reviewed by Ojan Vafai.
877
878         Specifically, add these test types:
879         
880          androidwebview_instrumentation_tests
881          chromiumtestshell_instrumentation_tests
882          contentshell_instrumentation_tests
883         
884         Also, add ChromiumFYI to the list of masters.
885
886         * TestResultServer/static-dashboards/builders.js:
887         (loadBuildersList):
888         * TestResultServer/static-dashboards/dashboard_base.js:
889         (currentBuilderGroupCategory):
890
891 2013-01-17  Tim 'mithro' Ansell  <mithro@mithis.com>
892
893         Fixing webkitpy's SCM unit tests.
894         https://bugs.webkit.org/show_bug.cgi?id=106429
895
896         Reviewed by Eric Seidel.
897
898         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
899         (SCMDetectorTest.test_detect_scm_system):
900         * Scripts/webkitpy/common/checkout/scm/git.py:
901         (Git.in_working_directory):
902         (Git.read_git_config):
903         (Git._assert_can_squash):
904         (Git.remote_branch_ref):
905         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
906         (GitSVNTest.test_commit_with_message_multiple_local_commits_always_squash):
907         (GitTestWithMock):
908         (GitTestWithMock.make_scm):
909         (GitTestWithMock.test_create_patch):
910         * Scripts/webkitpy/common/system/outputcapture.py:
911         (OutputCapture.assert_outputs):
912         (OutputCaptureTestCaseBase):
913         * Scripts/webkitpy/test/printer.py:
914         (Printer.configure):
915
916 2013-01-17  Julie Parent  <jparent@chromium.org>
917
918         Flakiness dashboard assumes there must be ToT tests
919         https://bugs.webkit.org/show_bug.cgi?id=107155
920
921         Remove group as a default parameter, since we can't actually know
922         the name of a group initially.  Instead, introduces 
923         currentBuilderGroupName which returns the current builder group
924         if it has been explicitly set, or picks the first one available
925         as a default. Allows us to remove some extra code tracking this
926         stuff as well.
927         
928         Reviewed by Ojan Vafai.
929
930         * TestResultServer/static-dashboards/dashboard_base.js:
931         (parseCrossDashboardParameters):
932         (currentBuilderGroupName):
933         (currentBuilderGroup):
934         * TestResultServer/static-dashboards/flakiness_dashboard.js:
935         (platformAndBuildType):
936         * TestResultServer/static-dashboards/loader.js:
937         (.):
938
939 2013-01-16  Ryosuke Niwa  <rniwa@webkit.org>
940
941         Remove NodeListsNodeData when it's no longer needed
942         https://bugs.webkit.org/show_bug.cgi?id=107074
943
944         Reviewed by Darin Adler.
945
946         Generalize the warning a little so that it's also ignored on PerformanceTests/DOM/TraverseChildNodes.html
947
948         * Scripts/webkitpy/performance_tests/perftest.py:
949         (PerfTest):
950
951 2013-01-17  Simon Fraser  <simon.fraser@apple.com>
952
953         Ref test images are upside-down in WebKit2
954         https://bugs.webkit.org/show_bug.cgi?id=105457
955
956         Reviewed by Sam "Speedy" Weinig.
957         
958         The bitmap context created in TestInvocation::dumpPixelsAndCompareWithExpected()
959         from the window snapshot contained a flipped copy of the image, causing all ref
960         and pixel images to be upside-down.
961
962         * WebKitTestRunner/cg/TestInvocationCG.cpp:
963         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
964
965 2013-01-17  Timothy Loh  <timloh@google.com>
966
967         Replaced specifiers variable with is_debug in builders.py
968         https://bugs.webkit.org/show_bug.cgi?id=107057
969
970         Reviewed by Dirk Pranke.
971
972         Replaced specifiers variable with is_debug in builders.py to simplify
973         Bug 106259. The other specifiers are not used elsewhere in the code.
974         Fixed builder_name_for_port_name to return a debug builder if we don't
975         have a release builder.
976
977         * Scripts/webkitpy/layout_tests/port/builders.py:
978         (all_port_names):
979         (builder_name_for_port_name):
980         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
981         (TestRebaselineExpectations.test_rebaseline_expectations):
982
983 2013-01-17  Martin Robinson  <mrobinson@igalia.com>
984
985         [GTK] Build with LevelDB when IndexedDB is enabled
986         https://bugs.webkit.org/show_bug.cgi?id=103220
987
988         Reviewed by Gustavo Noronha Silva.
989
990         * Scripts/webkitpy/style/checker.py: Do not style check the leveldb source code
991         as it does not conform to WebKit style.
992
993 2013-01-17  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
994
995         [EFL][WK2] Fix misuse of ASSERT on ecore_evas_init()
996         https://bugs.webkit.org/show_bug.cgi?id=107119
997
998         Reviewed by Laszlo Gombos.
999
1000         Do not use ASSERT on ecore_evas_init(), since the expression inside
1001         the macro compiles out of release builds.
1002
1003         * TestWebKitAPI/PlatformEfl.cmake: Enable API test UserMessage.
1004         * TestWebKitAPI/efl/PlatformWebView.cpp:
1005         (TestWebKitAPI::initEcoreEvas): Remove ASSERT on ecore_evas_init().
1006
1007 2013-01-17  Eugene Klyuchnikov  <eustas@chromium.org>
1008
1009         Web Inspector: Profiler: split "getProfile" to "getCPUProfile" and "loadHeapSnapshot"
1010         https://bugs.webkit.org/show_bug.cgi?id=104545
1011
1012         Reviewed by Yury Semikhatsky.
1013
1014         Adopt signature changes.
1015
1016         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
1017         (ProfilerAgent.getCPUProfile): Renamed.
1018         (ProfilerAgent.getHeapSnapshot): Added.
1019
1020 2013-01-17  Zan Dobersek  <zdobersek@igalia.com>
1021
1022         [GTK][EFL] NWRT should check that Xvfb is installed
1023         https://bugs.webkit.org/show_bug.cgi?id=71767
1024
1025         Reviewed by Dirk Pranke.
1026
1027         EFL and GTK ports now check that Xvfb is installed before running
1028         layout tests. The command line used to check whether Xvfb is present
1029         is a simple `which Xvfb` that should return 0 as the exit code upon
1030         success.
1031
1032         * Scripts/webkitpy/layout_tests/port/efl.py:
1033         (EflPort.show_results_html_file):
1034         (EflPort):
1035         (EflPort.check_sys_deps):
1036         * Scripts/webkitpy/layout_tests/port/gtk.py:
1037         (GtkPort.check_sys_deps):
1038         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
1039         (XvfbDriver):
1040         (XvfbDriver.check_xvfb):
1041
1042 2013-01-16  Alan Cutter  <alancutter@chromium.org>
1043
1044         sheriffbot can't tell me who "kov" is
1045         https://bugs.webkit.org/show_bug.cgi?id=106184
1046
1047         Reviewed by Eric Seidel.
1048
1049         Added glob style searching to the CommitterList contributors_by_search_string function so exact matches are favoured.
1050
1051         * Scripts/webkitpy/common/config/committers.py:
1052         (Account.matches_glob):
1053         (CommitterList.contributors_by_search_string):
1054         * Scripts/webkitpy/common/config/committers_unittest.py:
1055         (CommittersTest.test_committer_lookup):
1056         * Scripts/webkitpy/tool/bot/irc_command.py:
1057         (Whois):
1058
1059 2013-01-16  David Kilzer  <ddkilzer@apple.com>
1060
1061         Use xcrun to find path to make for Mac port
1062         <http://webkit.org/b/107091>
1063
1064         Reviewed by Dan Bernstein.
1065
1066         * Scripts/webkitpy/layout_tests/port/mac.py:
1067         (MacPort._build_java_test_support): Call self.make_command().
1068         (MacPort.make_command): Add.  Call xcrun_find().
1069         (MacPort.nm_command): Use self.xcrun_find().
1070         (MacPort.xcrun_find): Add.  Extract from nm_command().
1071
1072 2013-01-16  Sam Weinig  <sam@webkit.org>
1073
1074         Make debug-safari --target-web-process work again
1075         https://bugs.webkit.org/show_bug.cgi?id=107088
1076
1077         Reviewed by Anders Carlsson.
1078
1079         * Scripts/webkitdirs.pm:
1080         (execMacWebKitAppForDebugging):
1081         The shim is now called SecItemShim.
1082
1083 2013-01-16  Alan Cutter  <alancutter@chromium.org>
1084
1085         GCE build scripts don't take working directory into account when calling findzone.sh
1086         https://bugs.webkit.org/show_bug.cgi?id=106962
1087
1088         Reviewed by Adam Barth.
1089
1090         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
1091         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
1092         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
1093
1094 2013-01-16  Alan Cutter  <alancutter@chromium.org>
1095
1096         start-queue.sh does not pass remaining parameters correctly
1097         https://bugs.webkit.org/show_bug.cgi?id=107054
1098
1099         Reviewed by Adam Barth.
1100
1101         start-queue.sh now passes all remaining params to the webkit-patch command.
1102         Previously only one additional queue parameter could be sent.
1103
1104         * EWSTools/start-queue.sh:
1105
1106 2013-01-16  Xueqing Huang  <huangxueqing@baidu.com>
1107
1108         check-webkit-style script cannot running in Chinese windows.
1109         https://bugs.webkit.org/show_bug.cgi?id=87548
1110
1111         Reviewed by Darin Adler.
1112
1113         * Scripts/webkitpy/common/system/platforminfo.py:
1114         (PlatformInfo._win_version_tuple_from_cmd):
1115
1116 2013-01-16  Dirk Pranke  <dpranke@chromium.org>
1117
1118         Delete an extraneous print statement.
1119         https://bugs.webkit.org/show_bug.cgi?id=106562
1120
1121         Delete the extraneous print statement introduced in r139841.
1122
1123         * Scripts/webkitpy/layout_tests/views/printing.py:
1124         (Printer.print_found):
1125
1126 2013-01-16  Zan Dobersek  <zdobersek@igalia.com>
1127
1128         Please reinstate --pixel
1129         https://bugs.webkit.org/show_bug.cgi?id=101995
1130
1131         Reviewed by Dirk Pranke.
1132
1133         Add the '--pixel' and '--no-pixel' options for NRWT as aliases for
1134         the '--pixel-tests' (or '-p') and '--no-pixel-tests' options respectively.
1135         Some developers are still used to these options that were available in the ORWT.
1136
1137         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1138         (parse_args):
1139
1140 2013-01-16  Eric Seidel  <eric@webkit.org>
1141
1142         Remove --shark* support from sunspider/run-sunspider now that Shark is dead
1143         https://bugs.webkit.org/show_bug.cgi?id=99512
1144
1145         Reviewed by Darin Adler.
1146
1147         * Scripts/run-sunspider:
1148
1149 2013-01-16  Eric Seidel  <eric@webkit.org>
1150
1151         Remove webkitpy Visual Studio files, as core developers are not interested in maintaining them
1152         https://bugs.webkit.org/show_bug.cgi?id=106036
1153
1154         Reviewed by Darin Adler.
1155
1156         * Scripts/webkitpy/webkitpy.pyproj: Removed.
1157         * Scripts/webkitpy/webkitpy.sln: Removed.
1158
1159 2013-01-16  Chris Hopman  <cjhopman@chromium.org>
1160
1161         [Chromium] Remove hardcoded chromium_*.jar in gyp files
1162         https://bugs.webkit.org/show_bug.cgi?id=104049
1163
1164         Reviewed by Eric Seidel.
1165
1166         Targets with dependencies (direct/indirect) on a java target receive
1167         the chromium_*.jar paths in the variable input_jars_paths. Targets
1168         should use that rather than hardcoding where they think the jar will
1169         be. These can be passed directly to ant as INPUT_JARS_PATHS rather
1170         than as --jars to generate_native_test.py.
1171
1172         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1173         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
1174
1175 2013-01-16  Dan Carney  <dcarney@google.com>
1176
1177         [chromium] move setMockDeviceOrientation to TestRunner library
1178         https://bugs.webkit.org/show_bug.cgi?id=106895
1179
1180         Reviewed by Jochen Eisinger.
1181
1182         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1183         (DRTTestRunner::DRTTestRunner):
1184         * DumpRenderTree/chromium/DRTTestRunner.h:
1185         (DRTTestRunner):
1186         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1187         (WebKit):
1188         (WebTestRunner::WebTestDelegate::setDeviceOrientation):
1189         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1190         (WebTestRunner::TestRunner::TestRunner):
1191         (WebTestRunner::TestRunner::setMockDeviceOrientation):
1192         (WebTestRunner):
1193         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1194         (TestRunner):
1195         * DumpRenderTree/chromium/WebViewHost.cpp:
1196         (WebViewHost::setDeviceOrientation):
1197         * DumpRenderTree/chromium/WebViewHost.h:
1198         (WebViewHost):
1199
1200 2013-01-16  Jochen Eisinger  <jochen@chromium.org>
1201
1202         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
1203         https://bugs.webkit.org/show_bug.cgi?id=106904
1204
1205         Reviewed by Adam Barth.
1206
1207         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1208         (DRTTestRunner::DRTTestRunner):
1209         (DRTTestRunner::notifyDone):
1210         (DRTTestRunner::reset):
1211         * DumpRenderTree/chromium/DRTTestRunner.h:
1212         (DRTTestRunner):
1213         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1214         (WebTestRunner::WebTestDelegate::setDeviceScaleFactor):
1215         (WebTestRunner::WebTestDelegate::setFocus):
1216         (WebTestRunner::WebTestDelegate::setAcceptAllCookies):
1217         (WebTestRunner::WebTestDelegate::pathToLocalResource):
1218         (WebTestRunner::WebTestDelegate::setLocale):
1219         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1220         (WebTestRunner::TestRunner::TestRunner):
1221         (WebTestRunner::TestRunner::reset):
1222         (WebTestRunner::TestRunner::setAlwaysAcceptCookies):
1223         (WebTestRunner):
1224         (WebTestRunner::TestRunner::setWindowIsKey):
1225         (WebTestRunner::TestRunner::pathToLocalResource):
1226         (WebTestRunner::TestRunner::setBackingScaleFactor):
1227         (WebTestRunner::TestRunner::setPOSIXLocale):
1228         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1229         (WebTestRunner::TestRunner::taskList):
1230         (TestRunner):
1231         * DumpRenderTree/chromium/WebViewHost.cpp:
1232         (WebViewHost::setDeviceScaleFactor):
1233         (WebViewHost::setFocus):
1234         (WebViewHost::setAcceptAllCookies):
1235         (WebViewHost::pathToLocalResource):
1236         (WebViewHost::setLocale):
1237         * DumpRenderTree/chromium/WebViewHost.h:
1238         (WebViewHost):
1239
1240 2013-01-16  Sergio Villar Senin  <svillar@igalia.com>
1241
1242         [GTK] build-webkit fails if the jhbuild wrapper is not used
1243         https://bugs.webkit.org/show_bug.cgi?id=106769
1244
1245         Reviewed by Martin Robinson.
1246
1247         Return an empty array instead of "" in
1248         jhbuildWrapperPrefixIfNeeded() because otherwise that empty string
1249         will not be recognized as a valid command when the returned array
1250         is directly passed to perl's system() call.
1251
1252         * Scripts/webkitdirs.pm:
1253         (jhbuildWrapperPrefixIfNeeded):
1254
1255 2013-01-16  Jochen Eisinger  <jochen@chromium.org>
1256
1257         [chromium] add title text direction attribute to TestRunner
1258         https://bugs.webkit.org/show_bug.cgi?id=106907
1259
1260         Reviewed by Adam Barth.
1261
1262         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1263         (DRTTestRunner::DRTTestRunner):
1264         (DRTTestRunner::reset):
1265         * DumpRenderTree/chromium/DRTTestRunner.h:
1266         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1267         (WebTestRunner::WebTestRunner::setTitleTextDirection):
1268         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1269         (WebTestRunner::TestRunner::TestRunner):
1270         (WebTestRunner::TestRunner::reset):
1271         (WebTestRunner::TestRunner::setTitleTextDirection):
1272         (WebTestRunner):
1273         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1274         (TestRunner):
1275         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1276         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
1277         * DumpRenderTree/chromium/WebViewHost.cpp:
1278         (WebViewHost::didReceiveTitle):
1279
1280 2013-01-16  Jussi Kukkonen  <jussi.kukkonen@intel.com>
1281
1282         NRWT still confused about test count with --repeat-each and --iterations
1283         https://bugs.webkit.org/show_bug.cgi?id=106562
1284
1285         Reviewed by Dirk Pranke.
1286
1287         Fix the printed unique test count and skipped count. This
1288         seems to have broken in r127688 ("NRWT lies about the number
1289         of tests that it's skipping when used with --repeat-each").
1290
1291         Also add a test for print_found()
1292
1293         * Scripts/webkitpy/layout_tests/views/printing.py:
1294         (Printer.print_found):
1295         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1296         (Testprinter.test_details):
1297         (Testprinter):
1298         (Testprinter.test_found):
1299
1300 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
1301
1302         Unreviewed follow-up to r139769.
1303
1304         Note that omitting the WebKit1 code from the build now
1305         works for GTK as well.
1306
1307         * Scripts/build-webkit:
1308
1309 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
1310
1311         test-webkitpy: truncate output to the terminal width when necessary
1312         https://bugs.webkit.org/show_bug.cgi?id=106973
1313
1314         Reviewed by Ojan Vafai.
1315
1316         this implements the same logic for test-webkitpy that we have
1317         for run-webkit-tests (and ninja).
1318
1319         No tests written as this is exercised by running test-webkitpy itself.
1320
1321         * Scripts/webkitpy/test/printer.py:
1322         (Printer.configure):
1323         (Printer._test_line):
1324
1325 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
1326
1327         remove extraneous output in test-webkitpy
1328         https://bugs.webkit.org/show_bug.cgi?id=106971
1329
1330         Reviewed by Ojan Vafai.
1331
1332         We weren't ignoring or capturing the echoed output from
1333         these two tests, and getting noise in the logs as a result.
1334
1335         * Scripts/webkitpy/common/system/executive_unittest.py:
1336         (ExecutiveTest.test_auto_stringify_args):
1337         (ExecutiveTest.test_popen_args):
1338
1339 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
1340
1341         webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer.test_win32_start_and_stop is flaky
1342         https://bugs.webkit.org/show_bug.cgi?id=106974
1343
1344         Reviewed by Ryosuke Niwa.
1345
1346         I forgot to stub out the call to check to ensure that the ports were
1347         available, so this test could fail if something was listening on 8000 or
1348         8443 on the machine.
1349
1350         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1351         (TestHttpServer.test_win32_start_and_stop):
1352
1353 2013-01-15  Levi Weintraub  <leviw@chromium.org>
1354
1355         Unreviewed, rolling out r139792.
1356         http://trac.webkit.org/changeset/139792
1357         https://bugs.webkit.org/show_bug.cgi?id=106970
1358
1359         Broke the windows build.
1360
1361         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1362         (DRTTestRunner::DRTTestRunner):
1363         (DRTTestRunner::notifyDone):
1364         (DRTTestRunner::reset):
1365         (DRTTestRunner::setAlwaysAcceptCookies):
1366         (DRTTestRunner::setWindowIsKey):
1367         (DRTTestRunner::pathToLocalResource):
1368         (DRTTestRunner::setPOSIXLocale):
1369         (InvokeCallbackTask):
1370         (InvokeCallbackTask::InvokeCallbackTask):
1371         (InvokeCallbackTask::runIfValid):
1372         (DRTTestRunner::setBackingScaleFactor):
1373         * DumpRenderTree/chromium/DRTTestRunner.h:
1374         (DRTTestRunner):
1375         (DRTTestRunner::taskList):
1376         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1377         (WebTestRunner::WebTestDelegate::setDatabaseQuota):
1378         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1379         (WebTestRunner::TestRunner::TestRunner):
1380         (WebTestRunner::TestRunner::reset):
1381         (WebTestRunner::TestRunner::setDatabaseQuota):
1382         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1383         (TestRunner):
1384         * DumpRenderTree/chromium/WebViewHost.cpp:
1385         (WebViewHost::setPendingExtraData):
1386         (WebViewHost::setDeviceScaleFactor):
1387         * DumpRenderTree/chromium/WebViewHost.h:
1388         (WebViewHost):
1389
1390 2013-01-15  Ryosuke Niwa  <rniwa@webkit.org>
1391
1392         Build fix after r139357. The port name of MacWK2EWS should be 'mac-wk2'.
1393
1394         * Scripts/webkitpy/common/config/ports.py:
1395         (MacWK2Port):
1396
1397 2013-01-15  Alan Cutter  <alancutter@chromium.org>
1398
1399         Extend sheriffbot's "help" command to be able to get help on individual commands
1400         https://bugs.webkit.org/show_bug.cgi?id=106629
1401
1402         Reviewed by Eric Seidel.
1403
1404         Added a help command to sheriffbot.
1405         Fixed some style issues and ordered the commands alphabetically.
1406
1407         * Scripts/webkitpy/tool/bot/irc_command.py:
1408         (IRCCommand):
1409         (IRCCommand.execute):
1410         (IRCCommand.usage):
1411         (IRCCommand.help):
1412         (CreateBug):
1413         (CreateBug.execute):
1414         (Help):
1415         (Help.execute):
1416         (Help._post_command_help):
1417         (Hi):
1418         (Hi.execute):
1419         (Restart):
1420         (RollChromiumDEPS):
1421         (RollChromiumDEPS._parse_args):
1422         (RollChromiumDEPS._expand_irc_nickname):
1423         (RollChromiumDEPS.execute):
1424         (Rollout):
1425         (Rollout._extract_revisions):
1426         (Rollout.execute):
1427         (Sheriffs):
1428         (Sheriffs.execute):
1429         (Whois):
1430         (Whois.execute):
1431         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1432         (IRCBotTest.test_help):
1433
1434 2013-01-15  Enrica Casucci  <enrica@apple.com>
1435
1436         Add a new set of WebKit2 APIs for text search and
1437         search results management.
1438         https://bugs.webkit.org/show_bug.cgi?id=106834.
1439         <rdar://problem/12597159>
1440
1441         Added new test for the new WebKit2 API for
1442         text search.
1443         
1444         Reviewed by Simon Fraser.
1445
1446         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1447         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm: Added.
1448
1449 2013-01-15  Levi Weintraub  <leviw@chromium.org>
1450
1451         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
1452         https://bugs.webkit.org/show_bug.cgi?id=106904
1453
1454         Reverting 139794. It broke the build. It appears that a header file,
1455         WebTextDirection.h, was left out.
1456
1457         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1458         (DRTTestRunner::DRTTestRunner):
1459         (DRTTestRunner::reset):
1460         * DumpRenderTree/chromium/DRTTestRunner.h:
1461         (DRTTestRunner::setTitleTextDirection):
1462         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1463         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
1464         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1465         (WebTestRunner::TestRunner::TestRunner):
1466         (WebTestRunner::TestRunner::reset):
1467         (WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
1468         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1469         (TestRunner):
1470         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1471         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
1472         * DumpRenderTree/chromium/WebViewHost.cpp:
1473         (WebViewHost::didReceiveTitle):
1474
1475 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
1476
1477         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
1478         https://bugs.webkit.org/show_bug.cgi?id=106904
1479
1480         Reviewed by Adam Barth.
1481
1482         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1483         (DRTTestRunner::DRTTestRunner):
1484         (DRTTestRunner::notifyDone):
1485         (DRTTestRunner::reset):
1486         * DumpRenderTree/chromium/DRTTestRunner.h:
1487         (DRTTestRunner):
1488         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1489         (WebTestRunner::WebTestDelegate::setDeviceScaleFactor):
1490         (WebTestRunner::WebTestDelegate::setFocus):
1491         (WebTestRunner::WebTestDelegate::setAcceptAllCookies):
1492         (WebTestRunner::WebTestDelegate::pathToLocalResource):
1493         (WebTestRunner::WebTestDelegate::setLocale):
1494         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1495         (WebTestRunner::TestRunner::TestRunner):
1496         (WebTestRunner::TestRunner::reset):
1497         (WebTestRunner::TestRunner::setAlwaysAcceptCookies):
1498         (WebTestRunner):
1499         (WebTestRunner::TestRunner::setWindowIsKey):
1500         (WebTestRunner::TestRunner::pathToLocalResource):
1501         (WebTestRunner::TestRunner::setBackingScaleFactor):
1502         (WebTestRunner::TestRunner::setPOSIXLocale):
1503         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1504         (WebTestRunner::TestRunner::taskList):
1505         (TestRunner):
1506         * DumpRenderTree/chromium/WebViewHost.cpp:
1507         (WebViewHost::setDeviceScaleFactor):
1508         (WebViewHost::setFocus):
1509         (WebViewHost::setAcceptAllCookies):
1510         (WebViewHost::pathToLocalResource):
1511         (WebViewHost::setLocale):
1512         * DumpRenderTree/chromium/WebViewHost.h:
1513         (WebViewHost):
1514
1515 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
1516
1517         Tests with WontFix expectation are (indirectly) skipped
1518         https://bugs.webkit.org/show_bug.cgi?id=105860
1519
1520         Reviewed by Dirk Pranke.
1521
1522         Only skip the WontFix expectation if there are no other layout test
1523         expectations (like Failure, ImageOnlyFailure) listed for the test.
1524         This makes it possible to run an expected failure for which there
1525         is no reason or interest to fix. There are some ports that would like
1526         to exercise this behavior as well as specific test cases that should use
1527         such expectations.
1528
1529         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1530         (TestExpectationParser._tokenize_line): Only add the SKIP modifier for a
1531         WONTFIX test if there are no expectations listed. The warning is adjusted
1532         to reflect the new behavior.
1533         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Add
1534         and adjust test cases for these changes.
1535         (ExpectationSyntaxTests.test_wontfix):
1536         (SemanticTests.test_skip_and_wontfix):
1537
1538 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
1539
1540         [chromium] add title text direction attribute to TestRunner
1541         https://bugs.webkit.org/show_bug.cgi?id=106907
1542
1543         Reviewed by Adam Barth.
1544
1545         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1546         (DRTTestRunner::DRTTestRunner):
1547         (DRTTestRunner::reset):
1548         * DumpRenderTree/chromium/DRTTestRunner.h:
1549         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1550         (WebTestRunner::WebTestRunner::setTitleTextDirection):
1551         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1552         (WebTestRunner::TestRunner::TestRunner):
1553         (WebTestRunner::TestRunner::reset):
1554         (WebTestRunner::TestRunner::setTitleTextDirection):
1555         (WebTestRunner):
1556         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1557         (TestRunner):
1558         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1559         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
1560         * DumpRenderTree/chromium/WebViewHost.cpp:
1561         (WebViewHost::didReceiveTitle):
1562
1563 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
1564
1565         nrwt: change the default # of locked shards on chromium_win to 1
1566         https://bugs.webkit.org/show_bug.cgi?id=106938
1567
1568         Reviewed by Eric Seidel.
1569
1570         It looks like LigHTTPd might be buggy or unstable if we are
1571         running multiple http tests in parallel; see
1572         http://code.google.com/p/chromium/issues/detail?id=169530 for more
1573         context as well. This change will stop running http tests in parallel
1574         and we can see if this fixes things.
1575
1576         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1577         (ChromiumWinPort.default_max_locked_shards):
1578         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1579         (ChromiumWinTest.test_path_to_image_diff):
1580         (ChromiumWinTest):
1581         (ChromiumWinTest.test_default_max_locked_shards):
1582
1583 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
1584
1585         [chromium] move WebDatabase related methods to TestRunner library
1586         https://bugs.webkit.org/show_bug.cgi?id=106905
1587
1588         Reviewed by Adam Barth.
1589
1590         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1591         (DRTTestRunner::DRTTestRunner):
1592         (DRTTestRunner::reset):
1593         * DumpRenderTree/chromium/DRTTestRunner.h:
1594         (DRTTestRunner):
1595         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1596         (WebTestRunner::WebTestDelegate::clearAllDatabases):
1597         (WebTestRunner::WebTestDelegate::setDatabaseQuota):
1598         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1599         (WebTestRunner::TestRunner::TestRunner):
1600         (WebTestRunner::TestRunner::reset):
1601         (WebTestRunner::TestRunner::clearAllDatabases):
1602         (WebTestRunner):
1603         (WebTestRunner::TestRunner::setDatabaseQuota):
1604         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1605         (TestRunner):
1606         * DumpRenderTree/chromium/WebViewHost.cpp:
1607         (WebViewHost::clearAllDatabases):
1608         (WebViewHost::setDatabaseQuota):
1609         * DumpRenderTree/chromium/WebViewHost.h:
1610         (WebViewHost):
1611
1612 2013-01-15  Tim 'mithro' Ansell  <mithro@mithis.com>
1613
1614         Renaming CleanWorkingDirectory step to DiscardLocalChanges to make
1615         functionality match the name.
1616         https://bugs.webkit.org/show_bug.cgi?id=106870
1617
1618         Reviewed by Adam Barth.
1619
1620         * Scripts/webkitpy/tool/commands/download.py:
1621         (Clean):
1622         (Update):
1623         (Build):
1624         (BuildAndTest):
1625         (CheckStyle):
1626         (BuildAttachment):
1627         (BuildAndTestAttachment):
1628         (AbstractPatchApplyingCommand):
1629         (ApplyWatchList):
1630         (AbstractPatchLandingCommand):
1631         (CreateRollout):
1632         * Scripts/webkitpy/tool/steps/__init__.py:
1633         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
1634         (CleanWorkingDirectory.options):
1635         (CleanWorkingDirectory.run):
1636         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
1637         * Scripts/webkitpy/tool/steps/discardlocalchanges.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
1638         * Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py.
1639
1640 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
1641
1642         [Autotools] Add support for WebKit2-only builds
1643         https://bugs.webkit.org/show_bug.cgi?id=106889
1644
1645         Reviewed by Gustavo Noronha Silva.
1646
1647         * GNUmakefile.am: Only build the GtkLauncher and DumpRenderTree if building WebKit1.
1648         * Scripts/build-webkit: Pass along the information on whether to build WebKit1 when
1649         building the GTK port through build-webkit.
1650         * Scripts/webkitdirs.pm:
1651         (buildAutotoolsProject): Add the --disable-webkit1 configuration flag to the build
1652         arguments when not building WebKit1.
1653         (buildGtkProject): Pass along the information on whether to build WebKit1 when building
1654         through the Autotools build system.
1655
1656 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
1657
1658         [GTK] Enable Performance Timeline, Resource Timing, Navigation Timing features
1659         https://bugs.webkit.org/show_bug.cgi?id=106197
1660
1661         Reviewed by Martin Robinson.
1662
1663         * Scripts/webkitperl/FeatureList.pm: Add the configuration options for all three
1664         features. Enable them on GTK, meaning they will be enabled in development builds
1665         (i.e. when building with build-webkit).
1666
1667 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
1668
1669         [GTK] Enable CSS Image Resolution feature
1670         https://bugs.webkit.org/show_bug.cgi?id=99038
1671
1672         Reviewed by Gustavo Noronha Silva.
1673
1674         Enable the CSS Image Resolution feature for the development
1675         builds of the GTK port.
1676
1677         * Scripts/webkitperl/FeatureList.pm:
1678
1679 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
1680
1681         [GTK] Stop passing the unstable features flag to configure script when using build-webkit
1682         https://bugs.webkit.org/show_bug.cgi?id=106579
1683
1684         Reviewed by Gustavo Noronha Silva.
1685
1686         The --enable-unstable-features flag is not required to be passed anymore
1687         to the configure script as it was removed in r138252.
1688
1689         * Scripts/webkitdirs.pm:
1690         (buildAutotoolsProject):
1691
1692 2013-01-15  Tony Chang  <tony@chromium.org>
1693
1694         [chromium] Unreviewed, fix a bug where we don't properly shutdown lighttpd.
1695
1696         * Scripts/webkitpy/layout_tests/servers/http_server.py:
1697         (Lighttpd._check_and_kill): Pass /pid so taskkill.exe doesn't error out on us.
1698         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1699         (TestHttpServer.test_win32_start_and_stop):
1700
1701 2013-01-15  Joshua Bell  <jsbell@chromium.org>
1702
1703         Unreviewed. Adding Michael Pruett as contributor.
1704
1705         * Scripts/webkitpy/common/config/committers.py:
1706
1707 2013-01-15  Victor Carbune  <victor@rosedu.org>
1708
1709         Unreviewed. Update my email addresses.
1710
1711         * Scripts/webkitpy/common/config/committers.py:
1712
1713 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
1714
1715         [GTK] Waiting on the gdb process will lead to deadlock
1716         https://bugs.webkit.org/show_bug.cgi?id=106906
1717
1718         Reviewed by Philippe Normand.
1719
1720         Use communicate() rather than wait() on the Popen object that's running the gdb
1721         command. This avoids the deadlock that occurs on the GTK builders.
1722
1723         * Scripts/webkitpy/layout_tests/port/gtk.py:
1724         (GtkPort._get_gdb_output):
1725
1726 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
1727
1728         [GTK] Limit the number of frames printed out when backtracing with gdb
1729         https://bugs.webkit.org/show_bug.cgi?id=106901
1730
1731         Reviewed by Philippe Normand.
1732
1733         Printing an unlimited number of frames when dumping the gdb backtracing
1734         output can cause timeouts in the builders. This patch limits the number
1735         of frames that are printed out to 1024.
1736
1737         * Scripts/webkitpy/layout_tests/port/gtk.py:
1738         (GtkPort._get_gdb_output):
1739
1740 2013-01-15  Andras Becsi  <andras.becsi@digia.com>
1741
1742         [Qt] Fix ImageDiff's image format conversion
1743         https://bugs.webkit.org/show_bug.cgi?id=106880
1744
1745         Reviewed by Csaba Osztrogonác.
1746
1747         Besides actually doing the conversion this also silences the suspicious warning:
1748         "ignoring return value of function declared with warn_unused_result attribute".
1749
1750         * ImageDiff/qt/ImageDiff.cpp:
1751         (main): QImage::convertToFormat, contrary to the assumed behaviour, returns a
1752         copy of the image in the given format and does not alter the image itself.
1753
1754 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
1755
1756         [chromium] move remaining methods that just set a boolean flag to TestRunner library
1757         https://bugs.webkit.org/show_bug.cgi?id=106823
1758
1759         Reviewed by Darin Fisher.
1760
1761         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1762         (DRTTestRunner::DRTTestRunner):
1763         (DRTTestRunner::reset):
1764         * DumpRenderTree/chromium/DRTTestRunner.h:
1765         (DRTTestRunner):
1766         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1767         (WebTestRunner::WebTestRunner::shouldDumpBackForwardList):
1768         (WebTestRunner::WebTestRunner::deferMainResourceDataLoad):
1769         (WebTestRunner::WebTestRunner::shouldDumpSelectionRect):
1770         (WebTestRunner::WebTestRunner::testRepaint):
1771         (WebTestRunner::WebTestRunner::sweepHorizontally):
1772         (WebTestRunner::WebTestRunner::isPrinting):
1773         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
1774         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1775         (WebTestRunner::TestRunner::TestRunner):
1776         (WebTestRunner::TestRunner::reset):
1777         (WebTestRunner::TestRunner::shouldDumpBackForwardList):
1778         (WebTestRunner):
1779         (WebTestRunner::TestRunner::deferMainResourceDataLoad):
1780         (WebTestRunner::TestRunner::shouldDumpSelectionRect):
1781         (WebTestRunner::TestRunner::testRepaint):
1782         (WebTestRunner::TestRunner::sweepHorizontally):
1783         (WebTestRunner::TestRunner::isPrinting):
1784         (WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
1785         (WebTestRunner::TestRunner::dumpBackForwardList):
1786         (WebTestRunner::TestRunner::setDeferMainResourceDataLoad):
1787         (WebTestRunner::TestRunner::dumpSelectionRect):
1788         (WebTestRunner::TestRunner::repaintSweepHorizontally):
1789         (WebTestRunner::TestRunner::setPrinting):
1790         (WebTestRunner::TestRunner::setShouldStayOnPageAfterHandlingBeforeUnload):
1791         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1792         (TestRunner):
1793
1794 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
1795
1796         nrwt: stub out show_results_html for mock ports
1797         https://bugs.webkit.org/show_bug.cgi?id=106848
1798
1799         Reviewed by Ojan Vafai.
1800
1801         We were accidentally using the underlying ports'
1802         show_results_html_file() implementation, which would, unsurprisingly,
1803         fail in many cases (e.g., running mock-efl on the mac).
1804
1805         No test added since we don't generally add tests for the mock
1806         implementation.
1807
1808         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1809         (MockDRTPort.show_results_html_file):
1810
1811 2013-01-14  Tim 'mithro' Ansell  <mithro@mithis.com>
1812
1813         Changing clean_working_directory/clean_local_commits and related
1814         functions to have consistent naming.
1815
1816         https://bugs.webkit.org/show_bug.cgi?id=104198
1817
1818         Reviewed by Adam Barth.
1819
1820         * Scripts/webkitpy/common/checkout/scm/git.py:
1821         * Scripts/webkitpy/common/checkout/scm/scm.py:
1822         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1823         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1824         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
1825         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
1826
1827 2013-01-14  Alan Cutter  <alancutter@chromium.org>
1828
1829         Fix EWS GCE build scripts to detect which zone is available
1830         https://bugs.webkit.org/show_bug.cgi?id=106524
1831
1832         Reviewed by Adam Barth.
1833
1834         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
1835         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
1836         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
1837         * EWSTools/GoogleComputeEngine/findzone.sh: Added.
1838
1839 2013-01-14  Tim 'mithro' Ansell  <mithro@mithis.com>
1840
1841         Adding an error string to AmbiguousCommitError.
1842         https://bugs.webkit.org/show_bug.cgi?id=106846
1843
1844         Reviewed by Adam Barth.
1845
1846         * Scripts/webkitpy/common/checkout/scm/git.py:
1847         (AmbiguousCommitError.__init__):
1848
1849 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
1850
1851         kill whole lighttpd process tree for chromium win
1852         https://bugs.webkit.org/show_bug.cgi?id=106838
1853
1854         Reviewed by Tony Chang.
1855
1856         Land a speculative fix for lighttpd.exe hanging on some chromium bots;
1857         I think a test is causing a httpd server child process to wedge and
1858         killing the parent httpd server process isn't sufficient to ensure
1859         that the children are also killed.
1860
1861         * Scripts/webkitpy/layout_tests/servers/http_server.py:
1862         (Lighttpd._check_and_kill):
1863         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1864         (TestHttpServer.test_start_cmd):
1865         (TestHttpServer):
1866         (TestHttpServer.test_win32_start_and_stop):
1867         (TestHttpServer.test_win32_start_and_stop.wait_for_action):
1868         (TestHttpServer.test_win32_start_and_stop.mock_returns):
1869         (TestHttpServer.test_win32_start_and_stop.mock_returns.return_value_thunk):
1870
1871 2013-01-14  Nico Weber  <thakis@chromium.org>
1872
1873         [chromium] Enable `update-webkit --chromium --ninja` on windows
1874         https://bugs.webkit.org/show_bug.cgi?id=106836
1875
1876         Reviewed by Eric Seidel.
1877
1878         After running this, build-webkit --chromium will use ninja to build.
1879         Apparently there are some minor issues with that still, so it's
1880         not quite ready for use yet.
1881
1882         * Scripts/webkitdirs.pm:
1883         (determineIsChromiumNinja):
1884         (buildChromium):
1885
1886 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
1887
1888         nrwt: use the same search path for baselines and TestExpectations on apple mac
1889         https://bugs.webkit.org/show_bug.cgi?id=105599
1890
1891         Reviewed by Ryosuke Niwa.
1892
1893         Bug 105583 revealed some confusion due to the fact that the Apple
1894         Mac port used a different list of directories to search for baselines
1895         and TestExpectations files (actually, pretty much every port does).
1896
1897         It seems like a good idea to use the same list for both by default, but
1898         making this happen will affect every port in slightly different ways, so
1899         we'll try this on the Apple Mac port first.
1900
1901         Note that the effective changes for this are that:
1902         1) The apple mac port will look in platform/wk2 for baselines where
1903         it didn't before (it will look after looking in mac-wk2 but before
1904         the non-wk2 dirs)
1905         2) The apple mac-snowleopard port will use the expectations in
1906         mac-lion as well as the expectations in mac-snowleopard, although
1907         I'm not even sure if mac-snowleopard is still supported ...
1908
1909         * Scripts/webkitpy/layout_tests/port/mac.py:
1910         (MacPort.default_baseline_search_path):
1911         (MacPort.expectations_files):
1912         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1913         (test_baseline_search_path):
1914
1915 2013-01-14  Dominic Mazzoni  <dmazzoni@google.com>
1916
1917         AX: Need to implement ColorWellRole
1918         https://bugs.webkit.org/show_bug.cgi?id=106756
1919
1920         Reviewed by Chris Fleizach.
1921
1922         Returns a string representation of the value of a color
1923         when the role is Color Well, to make it easy to write layout
1924         tests for color controls.
1925
1926         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
1927
1928 2013-01-14  Dominic Mazzoni  <dmazzoni@google.com>
1929
1930         Chromium: Error in AccessibilityUIElement::intValueGetterCallback
1931         https://bugs.webkit.org/show_bug.cgi?id=106682
1932
1933         Reviewed by Chris Fleizach.
1934
1935         Modify Chromium's DRT implementation of intValue to return a
1936         different value depending on the role.
1937
1938         There are actually platform-specific differences in what should
1939         be returned in the "value" of an object, so Chromium normally keeps
1940         these separate (i.e. valueForRange, headingLevel, hierarchicalLevel, etc.)
1941         but this is a fine simplification to make cross-platform tests easier.
1942
1943         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
1944         (WebTestRunner::AccessibilityUIElement::intValueGetterCallback):
1945
1946 2013-01-14  Jochen Eisinger  <jochen@chromium.org>
1947
1948         [chromium] move remaining methods to dump WebViewClient callbacks to TestRunner library
1949         https://bugs.webkit.org/show_bug.cgi?id=106785
1950
1951         Reviewed by Adam Barth.
1952
1953         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1954         (DRTTestRunner::DRTTestRunner):
1955         (DRTTestRunner::reset):
1956         * DumpRenderTree/chromium/DRTTestRunner.h:
1957         (DRTTestRunner):
1958         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1959         (WebTestProxyBase):
1960         (WebTestRunner::WebTestProxy::setStatusText):
1961         (WebTestRunner::WebTestProxy::didStopLoading):
1962         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1963         (WebTestRunner::WebTestRunner::shouldDumpStatusCallbacks):
1964         (WebTestRunner::WebTestRunner::shouldDumpProgressFinishedCallback):
1965         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1966         (WebTestRunner::TestRunner::TestRunner):
1967         (WebTestRunner::TestRunner::reset):
1968         (WebTestRunner::TestRunner::shouldDumpStatusCallbacks):
1969         (WebTestRunner):
1970         (WebTestRunner::TestRunner::shouldDumpProgressFinishedCallback):
1971         (WebTestRunner::TestRunner::dumpWindowStatusChanges):
1972         (WebTestRunner::TestRunner::dumpProgressFinishedCallback):
1973         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1974         (TestRunner):
1975         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1976         (WebTestRunner::WebTestProxyBase::setStatusText):
1977         (WebTestRunner):
1978         (WebTestRunner::WebTestProxyBase::didStopLoading):
1979         * DumpRenderTree/chromium/WebViewHost.cpp:
1980         (WebViewHost::didStopLoading):
1981         * DumpRenderTree/chromium/WebViewHost.h:
1982         (WebViewHost):
1983
1984 2013-01-14  Andrey Lushnikov  <lushnikov@chromium.org>
1985
1986         Web Inspector: devtools front-end doesn't have focus in TestShell
1987         https://bugs.webkit.org/show_bug.cgi?id=106778
1988
1989         Reviewed by Pavel Feldman.
1990
1991         Focus devTools window after loadURL method.
1992
1993         * DumpRenderTree/chromium/TestShell.cpp:
1994         (TestShell::runFileTest):
1995
1996 2013-01-14  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1997
1998         [EFL][jhbuild] Build the GStreamer-related dependencies with the "configure" script
1999         https://bugs.webkit.org/show_bug.cgi?id=106573
2000
2001         Reviewed by Philippe Normand.
2002
2003         Similarly to what's been described in bug 106569, we're building
2004         from release tarballs, so there's no reason to regenerate the
2005         autoconf-related stuff with autogen.sh, especially since we might
2006         run into trouble with automake 1.13 and deprecated macros.
2007
2008         * efl/jhbuild.modules:
2009
2010 2013-01-14  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
2011
2012         [Qt] The Qt's configuration isn't honoured regarding the use of the system libpng and libjpeg
2013         https://bugs.webkit.org/show_bug.cgi?id=104909
2014
2015         Reviewed by Simon Hausmann.
2016
2017         To be able to build redistribuable binary packages, Qt's configure switches
2018         -qt-libpng and -qt-libjpeg are used to avoid having the binaries trying to
2019         dynamically link to optional system libraries.
2020         QtWebKit is doing its own configure checks for those libraries, thus adding a
2021         runtime dependency that might not be fulfilled if the packager's machine had
2022         those libraries while the user's machine won't.
2023
2024         Since in most cases where WebKit will want to use those system libraries, Qt will
2025         also be using them, remove these configure tests from WebKit.
2026
2027         * qmake/config.tests/libjpeg/libjpeg.cpp: Removed.
2028         * qmake/config.tests/libjpeg/libjpeg.pro: Removed.
2029         * qmake/config.tests/libpng/libpng.cpp: Removed.
2030         * qmake/config.tests/libpng/libpng.pro: Removed.
2031         * qmake/mkspecs/features/features.prf:
2032
2033 2013-01-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2034
2035         [EFL][jhbuild] Bump the EFL dependencies in jhbuild to 1.7.5.
2036         https://bugs.webkit.org/show_bug.cgi?id=106574
2037
2038         Reviewed by Laszlo Gombos.
2039
2040         Rely on a more recent stable release, which includes support for
2041         Lua 5.2 in Edje and other assorted minor fixes.
2042
2043         While here, also use the "configure" script to build the libraries
2044         instead of relying on autogen.sh, which is not really needed with
2045         a release tarball and may have problems with automake 1.13.
2046
2047         * efl/jhbuild.modules:
2048
2049 2013-01-14  Andrey Lushnikov  <lushnikov@chromium.org>
2050
2051         Web Inspector: fix DRT to deliver simulated events to devtools front-end
2052         https://bugs.webkit.org/show_bug.cgi?id=106650
2053
2054         Reviewed by Pavel Feldman.
2055
2056         Add separated m_devToolsTestInterfaces object to testShell which is
2057         bind to devTools webview.
2058
2059         * DumpRenderTree/chromium/TestShell.cpp:
2060         (TestShell::initialize):
2061         (TestShell::createMainWindow):
2062         (TestShell::~TestShell):
2063         (TestShell::showDevTools):
2064         (TestShell::resetTestController):
2065         (TestShell::bindJSObjectsToWindow):
2066         (TestShell::createNewWindow):
2067         * DumpRenderTree/chromium/TestShell.h:
2068         (TestShell):
2069
2070 2013-01-14  Alan Cutter  <alancutter@chromium.org>
2071
2072         Sheriffbot command aliases need test cases
2073         https://bugs.webkit.org/show_bug.cgi?id=106754
2074
2075         Reviewed by Eric Seidel.
2076
2077         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2078         (SheriffBotTest.test_command_aliases):
2079
2080 2013-01-13  Alan Cutter  <alancutter@chromium.org>
2081
2082         Allow users to misspell the "sheriffs" command in sheriffbot
2083         https://bugs.webkit.org/show_bug.cgi?id=106628
2084
2085         Reviewed by Steve Block.
2086
2087         * Scripts/webkitpy/tool/bot/irc_command.py:
2088
2089 2013-01-13  Alan Cutter  <alancutter@chromium.org>
2090
2091         Make "gardeners" an alias for "sheriffs" in sherrifbot
2092         https://bugs.webkit.org/show_bug.cgi?id=106627
2093
2094         Reviewed by Eric Seidel.
2095
2096         * Scripts/webkitpy/tool/bot/irc_command.py:
2097
2098 2013-01-13  Dirk Pranke  <dpranke@chromium.org>
2099
2100         [chromium] webkitpy-test: executive.py stringify_args error on the release test bot
2101         https://bugs.webkit.org/show_bug.cgi?id=105380
2102
2103         Reviewed by Eric Seidel.
2104
2105         Fix a regression introduced in r137692 where we were double-encoding
2106         the arguments to popen(); this was only an issue on windows, where
2107         we would try to encode something to mbcs, then try to encode it
2108         to unicode as if the input as ascii.
2109
2110         * Scripts/webkitpy/common/system/executive.py:
2111         (Executive.run_command):
2112
2113 2013-01-13  Alan Cutter  <alancutter@chromium.org>
2114
2115         State who told sheriffbot to roll the Chromium deps and to what revision
2116         https://bugs.webkit.org/show_bug.cgi?id=106626
2117
2118         Reviewed by Eric Seidel.
2119
2120         Added optional argument to post-chromium-deps-roll so Sheriffbot can specify ChangeLog message.
2121
2122         * Scripts/webkitpy/tool/bot/irc_command.py:
2123         (RollChromiumDEPS._expand_irc_nickname):
2124         (RollChromiumDEPS.execute):
2125         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2126         (IRCCommandTest.test_roll_chromium_deps):
2127         * Scripts/webkitpy/tool/bot/sheriff.py:
2128         (Sheriff.post_chromium_deps_roll):
2129         * Scripts/webkitpy/tool/commands/roll.py:
2130         (RollChromiumDEPS._prepare_state):
2131         (PostChromiumDEPSRoll):
2132         (PostChromiumDEPSRoll._prepare_state):
2133         * Scripts/webkitpy/tool/commands/roll_unittest.py:
2134         (PostRollCommandsTest.test_prepare_state):
2135         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
2136         (PrepareChangeLogForDEPSRoll.run):
2137
2138 2013-01-13  Alan Cutter  <alancutter@chromium.org>
2139
2140         Add Alan Cutter as contributor
2141         https://bugs.webkit.org/show_bug.cgi?id=106747
2142
2143         Reviewed by Eric Seidel.
2144
2145         * Scripts/webkitpy/common/config/committers.py:
2146
2147 2013-01-13  Jonathan Liu  <net147@gmail.com>
2148
2149         Fix CONFIG missing link_pkgconfig on Windows
2150         https://bugs.webkit.org/show_bug.cgi?id=106647
2151
2152         Some libraries (e.g. libxslt, libxml2 and sqlite3) fail to link
2153         properly on Windows because they are added to PKGCONFIG but
2154         CONFIG does not contain link_pkgconfig.
2155
2156         This is because link_pkgconfig is added in unix/default_pre.prf
2157         which is only used for UNIX platforms. To fix this, move it to
2158         the general default_pre.prf.
2159
2160         Reviewed by Simon Hausmann.
2161
2162         * qmake/mkspecs/features/default_pre.prf:
2163         * qmake/mkspecs/features/unix/default_pre.prf:
2164
2165 2013-01-12  Nico Weber  <thakis@chromium.org>
2166
2167         nrwt/chromium: Don't prefer chromium over webkit build directories
2168         https://bugs.webkit.org/show_bug.cgi?id=105597
2169
2170         Reviewed by Dirk Pranke.
2171
2172         Rely on the new timestamp logic instead. Requested by dpranke in
2173         https://bugs.webkit.org/show_bug.cgi?id=105498
2174
2175         * Scripts/webkitpy/layout_tests/port/chromium.py:
2176         (ChromiumPort._static_build_path):
2177         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2178         (ChromiumLinuxPortTest.test_build_path):
2179         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2180         (ChromiumMacPortTest.test_build_path):
2181         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2182         (ChromiumWinTest.test_build_path):
2183
2184 2013-01-12  Nico Weber  <thakis@chromium.org>
2185
2186         Use ninja by default on Linux for build-webkit --chromium, bot edition
2187         https://bugs.webkit.org/show_bug.cgi?id=104434
2188
2189         Reviewed by Eric Seidel.
2190
2191         r139557 changed update-webkit to pick ninja by default on linux, but
2192         the bots run update-webkit-chromium directly so they didn't see this.
2193         Move the default for ninja into update-webkit-chromium so that it's
2194         picked up by the bots, and let update-webkit forward non-default
2195         options to there.
2196
2197         This way, the default is in one place only and both developers (who
2198         usually use update-webkit which then shells out to
2199         updat-webkit-chromium) and bots (which use update-webkit-chromium
2200         directly) see the same behavior.
2201
2202         * Scripts/update-webkit:
2203         * Scripts/update-webkit-chromium:
2204
2205 2013-01-12  Nico Weber  <thakis@chromium.org>
2206
2207         Make ninja the default build system on Linux for build-webkit --chromium
2208         https://bugs.webkit.org/show_bug.cgi?id=104434
2209
2210         Reviewed by Eric Seidel.
2211
2212         * Scripts/update-webkit:
2213
2214 2013-01-12  Alan Cutter  <alancutter@chromium.org>
2215
2216         Migrate the remaining bots in EC2 to Google Compute Engine
2217         https://bugs.webkit.org/show_bug.cgi?id=106005
2218
2219         Reviewed by Eric Seidel.
2220
2221         Updated bot scripts for launching feeder-queue, style-queue and sheriffbot on GCE.
2222
2223         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh: Copied from Tools/EWSTools/build-repo.sh.
2224         * EWSTools/boot.sh:
2225         * EWSTools/build-repo.sh:
2226         * EWSTools/start-queue.sh:
2227
2228 2013-01-12  Jochen Eisinger  <jochen@chromium.org>
2229
2230         [chromium] move inspector related methods to TestRunner library
2231         https://bugs.webkit.org/show_bug.cgi?id=106654
2232
2233         Reviewed by Adam Barth.
2234
2235         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2236         (DRTTestRunner::DRTTestRunner):
2237         * DumpRenderTree/chromium/DRTTestRunner.h:
2238         (DRTTestRunner):
2239         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2240         (WebTestRunner::WebTestDelegate::showDevTools):
2241         (WebTestRunner::WebTestDelegate::closeDevTools):
2242         (WebTestRunner::WebTestDelegate::evaluateInWebInspector):
2243         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2244         (WebTestRunner::TestRunner::TestRunner):
2245         (WebTestRunner::TestRunner::showWebInspector):
2246         (WebTestRunner):
2247         (WebTestRunner::TestRunner::closeWebInspector):
2248         (WebTestRunner::TestRunner::evaluateInWebInspector):
2249         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2250         (TestRunner):
2251         * DumpRenderTree/chromium/WebViewHost.cpp:
2252         (WebViewHost::showDevTools):
2253         (WebViewHost::closeDevTools):
2254         (WebViewHost::evaluateInWebInspector):
2255         * DumpRenderTree/chromium/WebViewHost.h:
2256         (WebViewHost):
2257
2258 2013-01-11  Julie Parent  <jparent@chromium.org>
2259
2260         Builder should not be a valid parameter for stats dashboard
2261         https://bugs.webkit.org/show_bug.cgi?id=106698
2262
2263         Reviewed by Dirk Pranke.
2264         
2265         Since builder is a dashboard specific parameter, dashboard_base
2266         should not be handling it in handleValidHashParameterWrapper, rather,
2267         each specific dashboard should in its handleValidHashParameter function.
2268     
2269         Note that the FIXME in dashboard_base about this was actually wrong -
2270         we don't want to move it to g_crossDashboardState, because it isn't
2271         actually cross dashboard state.
2272         
2273         In fact, flakiness and treemap have the code in 
2274         handleValidHashParameter, but it is currently dead code because 
2275         dashboard_base gets to it first.
2276         
2277         Added the proper handling to timeline_explorer, since builder is
2278         valid there.
2279
2280         * TestResultServer/static-dashboards/dashboard_base.js:
2281         * TestResultServer/static-dashboards/timeline_explorer.html:
2282
2283 2013-01-11  Ryosuke Niwa  <rniwa@webkit.org>
2284
2285         REGRESSION: buildbot mangles error messages with timestamps run-webkit-tests outputs
2286         https://bugs.webkit.org/show_bug.cgi?id=106688
2287
2288         Reviewed by Eric Seidel.
2289
2290         Update the regular expression used to strip the garbage at the beginning.
2291
2292         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2293         (RunWebKitTests.nrwt_log_message_regexp):
2294
2295 2013-01-11  Pratik Solanki  <psolanki@apple.com>
2296
2297         TestRunner leaks when running tests
2298         https://bugs.webkit.org/show_bug.cgi?id=106683
2299
2300         Reviewed by Simon Fraser.
2301
2302         Remove extra ref() that we missed out on deleting when refactoring window.layoutTestController
2303         to window.testRunner in r124705. This caused the TestRunner object to be leaked when running
2304         tests.
2305
2306         * DumpRenderTree/TestRunner.cpp:
2307         (TestRunner::makeWindowObject):
2308
2309 2013-01-11  Julie Parent  <jparent@chromium.org>
2310
2311         Dashboard Cleanup: Add isLoadingComplete to the loader.Loader object.
2312         https://bugs.webkit.org/show_bug.cgi?id=106247
2313
2314         Old code nulled out the loader instance when it completed loading and
2315         then later used the fact that it was null to determine if it had loaded
2316         or not.  This is not only unintuitive, but it also prevents using the
2317         loader object later on.
2318         
2319         Added new method, used it, added unit test for it.
2320         
2321         Reviewed by Dirk Pranke.
2322
2323         * TestResultServer/static-dashboards/dashboard_base.js:
2324         (resourceLoadingComplete):
2325         (handleLocationChange):
2326         * TestResultServer/static-dashboards/loader.js:
2327         (.):
2328         * TestResultServer/static-dashboards/loader_unittests.js:
2329
2330 2013-01-11  Ryosuke Niwa  <rniwa@webkit.org>
2331
2332         Try CRLF to LF change in r139407 again.
2333
2334         * BuildSlaveSupport/delete-stale-build-files:
2335         (main):
2336         (webkitBuildDirectory):
2337         * BuildSlaveSupport/kill-old-processes:
2338         (main):
2339
2340 2013-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2341
2342         [GTK] Disable the unit tests timeout when running from make check
2343         https://bugs.webkit.org/show_bug.cgi?id=106670
2344
2345         Reviewed by Philippe Normand.
2346
2347         * GNUmakefile.am: Pass --timeout=-1 to run-gtk-test.
2348
2349 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2350
2351         Yet another unreviewed fix after r139431.
2352
2353         * Scripts/run-launcher: Pass the arguments to `jhbuild-wrapper' in
2354         the correct order.
2355
2356 2013-01-11  Dan Carney  <dcarney@google.com>
2357
2358         [chromium] move some whitespace and resize related methods to TestRunner library
2359         https://bugs.webkit.org/show_bug.cgi?id=106655
2360
2361         Reviewed by Jochen Eisinger.
2362
2363         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2364         (DRTTestRunner::DRTTestRunner):
2365         * DumpRenderTree/chromium/DRTTestRunner.h:
2366         (DRTTestRunner):
2367         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2368         (WebKit):
2369         (WebTestRunner::WebTestDelegate::setClientWindowRect):
2370         (WebTestRunner::WebTestDelegate::setSelectTrailingWhitespaceEnabled):
2371         (WebTestRunner::WebTestDelegate::setSmartInsertDeleteEnabled):
2372         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2373         (WebTestRunner::TestRunner::TestRunner):
2374         (WebTestRunner::TestRunner::setSmartInsertDeleteEnabled):
2375         (WebTestRunner):
2376         (WebTestRunner::TestRunner::setSelectTrailingWhitespaceEnabled):
2377         (WebTestRunner::TestRunner::enableAutoResizeMode):
2378         (WebTestRunner::TestRunner::disableAutoResizeMode):
2379         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2380         (TestRunner):
2381         * DumpRenderTree/chromium/WebViewHost.cpp:
2382         (WebViewHost::setClientWindowRect):
2383         * DumpRenderTree/chromium/WebViewHost.h:
2384         (WebViewHost):
2385
2386 2013-01-11  Mario Sanchez Prada  <mario.prada@samsung.com>
2387
2388         Unreviewed. Update my e-mail addresses.
2389
2390         * Scripts/webkitpy/common/config/committers.py:
2391
2392 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2393
2394         Another unreviewed fix after r139431.
2395
2396         In a way, this is also a generic bug fix, since previously isEfl()
2397         would fail when called from run-efl-tests and we thus did not use
2398         jhbuild to run our tests. This now resulted in us calling
2399         "jhbuild-wrapper run" without specifying a platform.
2400
2401         * Scripts/run-efl-tests: Pass "--efl" to ARGV manually for isEfl()
2402         to work.
2403
2404 2013-01-11  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2405
2406         [Qt][WK1] Web Audio support
2407         https://bugs.webkit.org/show_bug.cgi?id=106651
2408
2409         Reviewed by Jocelyn Turcotte.
2410
2411         Implements support for dumping audio data in DumpRenderTree.
2412
2413         Adds WebAudio to toggleable features in QtTestBrowser.
2414
2415         Enables LEGACY_WEB_AUDIO. This feature is required for 2/3 of the web audio regression tests. It is enabled by default
2416         because it has no effect when WEB_AUDIO is not enabled. This combination matches the settings in FeatureList.pm.
2417
2418         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2419         (WebCore::DumpRenderTree::dump):
2420         * DumpRenderTree/qt/TestRunnerQt.cpp:
2421         (TestRunner::reset):
2422         (TestRunner::overridePreference):
2423         (TestRunner::setAudioData):
2424         * DumpRenderTree/qt/TestRunnerQt.h:
2425         (TestRunner::shouldDumpAsAudio):
2426         (TestRunner::audioData):
2427         (TestRunner):
2428         * QtTestBrowser/launcherwindow.cpp:
2429         (LauncherWindow::applyPrefs):
2430         (LauncherWindow::createChrome):
2431         (LauncherWindow::toggleWebAudio):
2432         * QtTestBrowser/launcherwindow.h:
2433         (WindowOptions::WindowOptions):
2434         (WindowOptions):
2435         (LauncherWindow):
2436         * qmake/mkspecs/features/features.prf:
2437         * qmake/mkspecs/features/features.pri:
2438
2439 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2440
2441         Unreviewed jhbuild-related fix after r139431.
2442
2443         * Scripts/webkitpy/layout_tests/port/efl.py:
2444         (EflPort.__init__): Pass a string to set_option_default(), since
2445         shlex.split() will be called on it later.
2446
2447 2013-01-11  Csaba Osztrogonác  <ossy@webkit.org>
2448
2449         Unreviewed typo fixes after r139431.
2450
2451         * Scripts/run-javascriptcore-tests:
2452
2453 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2454
2455         [jhbuild] Remove the "run-with-jhbuild" scripts.
2456         https://bugs.webkit.org/show_bug.cgi?id=106572
2457
2458         Reviewed by Martin Robinson.
2459
2460         Both ports which use jhbuild were mostly duplicating the
2461         `run-with-jhbuild' script in their own directories for no clear reason.
2462
2463         The script itself was just a thin wrapper around the `jhbuild-wrapper',
2464         so just start using that directly and get rid of a useless middle man.
2465
2466         Adjust scripts which called run-with-jhbuild to call jhbuild-wrapper
2467         instead.
2468
2469         * Scripts/run-javascriptcore-tests:
2470         * Scripts/run-launcher:
2471         * Scripts/webkitdirs.pm:
2472         (runAutogenForAutotoolsProjectIfNecessary):
2473         (buildAutotoolsProject):
2474         (jhbuildWrapperPrefixIfNeeded):
2475         (generateBuildSystemFromCMakeProject):
2476         (buildCMakeGeneratedProject):
2477         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
2478         (run):
2479         * Scripts/webkitpy/layout_tests/port/efl.py:
2480         (EflPort.__init__):
2481         (EflPort._image_diff_command):
2482         * efl/run-with-jhbuild: Removed.
2483         * gtk/run-with-jhbuild: Removed.
2484
2485 2013-01-11  Alan Cutter  <alancutter@chromium.org>
2486
2487         Allow arbitrary queue launch parameters in EWSTools/start-queue.sh
2488         https://bugs.webkit.org/show_bug.cgi?id=106636
2489
2490         Reviewed by Adam Barth.
2491
2492         This parameter will allow the bot boot script to use start-queue.sh and provide an IRC password for sheriffbot.
2493
2494         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
2495         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
2496         * EWSTools/screen-config:
2497         * EWSTools/start-queue.sh:
2498
2499 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
2500
2501         kill-old-processes and delete-stale-build-files use CRLF linebreaks
2502         https://bugs.webkit.org/show_bug.cgi?id=106622
2503
2504         Reviewed by Simon Fraser.
2505
2506         Use LF instead of CRLF in kill-old-processes and delete-stale-build-files.
2507         Also escape clang\+\+ correctly in kill-old-processes.
2508
2509         * BuildSlaveSupport/delete-stale-build-files:
2510         * BuildSlaveSupport/kill-old-processes:
2511
2512 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
2513
2514         Build fix after r139357. It was missing a comma.
2515
2516         * QueueStatusServer/model/queues.py:
2517         (Queue):
2518
2519 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
2520
2521         Fixing AuthenticationError when running test-webkitpy as a non-committer.
2522         https://bugs.webkit.org/show_bug.cgi?id=106420
2523
2524         Reviewed by Eric Seidel.
2525
2526         * Scripts/webkitpy/common/checkout/scm/git.py:
2527         (Git.push_local_commits_to_server):
2528         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2529         * Scripts/webkitpy/common/checkout/scm/svn.py:
2530         (SVNRepository):
2531         (SVNRepository.has_authorization_for_realm):
2532
2533 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
2534
2535         [EFL][jhbuild] Use tarballs for gstreamer instead of git
2536         https://bugs.webkit.org/show_bug.cgi?id=106552
2537
2538         Reviewed by Laszlo Gombos.
2539
2540         Use tarballs for gstreamer instead of git in EFL's jhbuild
2541         to work around intermittent network issues on our build
2542         bots. Tarballs are fully cached and require no network
2543         operation if their checksum matches.
2544
2545         * efl/jhbuild.modules:
2546
2547 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
2548
2549         Add Mac WK2 EWS bots
2550         https://bugs.webkit.org/show_bug.cgi?id=106590
2551
2552         Reviewed by Adam Barth.
2553
2554         Added MacWK2EWS, and made myself a watcher for MacEWS and MacWK2EWS.
2555         Also add a deprecated MacWK2Port class.
2556
2557         * QueueStatusServer/model/queues.py:
2558         (Queue):
2559         * Scripts/webkitpy/common/config/ports.py:
2560         (DeprecatedPort.port):
2561         (MacWK2Port):
2562         (MacWK2Port.run_webkit_tests_command):
2563         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2564         (MacEWS):
2565         (MacWK2EWS):
2566         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2567         (_test_ewses):
2568
2569 2013-01-10  Dan Carney  <dcarney@google.com>
2570
2571         [chromium] move webpermissionclient related methods to TestRunner library
2572         https://bugs.webkit.org/show_bug.cgi?id=106548
2573
2574         Reviewed by Jochen Eisinger.
2575
2576         * DumpRenderTree/DumpRenderTree.gypi:
2577         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2578         (DRTTestRunner::DRTTestRunner):
2579         (DRTTestRunner::reset):
2580         * DumpRenderTree/chromium/DRTTestRunner.h:
2581         (DRTTestRunner):
2582         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2583         (WebTestRunner::WebTestDelegate::normalizeLayoutTestURL):
2584         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2585         (WebKit):
2586         (WebTestRunner::WebTestRunner::webPermissions):
2587         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2588         (WebTestRunner::TestRunner::TestRunner):
2589         (WebTestRunner::TestRunner::setDelegate):
2590         (WebTestRunner):
2591         (WebTestRunner::TestRunner::reset):
2592         (WebTestRunner::TestRunner::webPermissions):
2593         (WebTestRunner::TestRunner::dumpPermissionClientCallbacks):
2594         (WebTestRunner::TestRunner::setImagesAllowed):
2595         (WebTestRunner::TestRunner::setScriptsAllowed):
2596         (WebTestRunner::TestRunner::setStorageAllowed):
2597         (WebTestRunner::TestRunner::setPluginsAllowed):
2598         (WebTestRunner::TestRunner::setAllowDisplayOfInsecureContent):
2599         (WebTestRunner::TestRunner::setAllowRunningOfInsecureContent):
2600         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2601         (WebTestRunner):
2602         (TestRunner):
2603         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.cpp.
2604         (WebTestRunner):
2605         (WebTestRunner::WebPermissions::WebPermissions):
2606         (WebTestRunner::WebPermissions::~WebPermissions):
2607         (WebTestRunner::WebPermissions::allowImage):
2608         (WebTestRunner::WebPermissions::allowScriptFromSource):
2609         (WebTestRunner::WebPermissions::allowStorage):
2610         (WebTestRunner::WebPermissions::allowPlugins):
2611         (WebTestRunner::WebPermissions::allowDisplayingInsecureContent):
2612         (WebTestRunner::WebPermissions::allowRunningInsecureContent):
2613         (WebTestRunner::WebPermissions::setImagesAllowed):
2614         (WebTestRunner::WebPermissions::setScriptsAllowed):
2615         (WebTestRunner::WebPermissions::setStorageAllowed):
2616         (WebTestRunner::WebPermissions::setPluginsAllowed):
2617         (WebTestRunner::WebPermissions::setDisplayingInsecureContentAllowed):
2618         (WebTestRunner::WebPermissions::setRunningInsecureContentAllowed):
2619         (WebTestRunner::WebPermissions::setDelegate):
2620         (WebTestRunner::WebPermissions::setDumpCallbacks):
2621         (WebTestRunner::WebPermissions::reset):
2622         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.h.
2623         (WebTestRunner):
2624         (WebPermissions):
2625         * DumpRenderTree/chromium/TestShell.cpp:
2626         (TestShell::initialize):
2627         (TestShell::resetTestController):
2628         (TestShell::createNewWindow):
2629         * DumpRenderTree/chromium/TestShell.h:
2630         (TestShell):
2631         * DumpRenderTree/chromium/WebViewHost.cpp:
2632         (WebViewHost::normalizeLayoutTestURL):
2633         * DumpRenderTree/chromium/WebViewHost.h:
2634         (WebViewHost):
2635
2636 2013-01-10  Alan Cutter  <alancutter@chromium.org>
2637
2638         Split EWS tool cold-boot.sh into modular components
2639         https://bugs.webkit.org/show_bug.cgi?id=106527
2640
2641         Reviewed by Adam Barth.
2642
2643         Split cold-boot.sh script up into build-vm.sh, build-repo.sh and build-boot-cmd.sh.
2644         Updated GCE bot build scripts to match.
2645         Unable to test scripts directly as they depend on being in the repository to work!
2646
2647         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
2648         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
2649         * EWSTools/build-boot-cmd.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-chromium-ews.sh.
2650         * EWSTools/build-repo.sh: Copied from Tools/EWSTools/cold-boot.sh.
2651         * EWSTools/build-vm.sh: Renamed from Tools/EWSTools/cold-boot.sh.
2652
2653 2013-01-10  Julie Parent  <jparent@chromium.org>
2654
2655         Dashboard Cleanup: Do not generate the page if we are about to reload.
2656         https://bugs.webkit.org/show_bug.cgi?id=106584
2657
2658         Reviewed by Dirk Pranke.
2659
2660         Move the logic to determine if we should generate the page into
2661         parseParameters() since that is where we have the knowledge to
2662         determine it, and return that value to handleLocationChange, 
2663         rather than passing the changed parameters back to handleLocationChange
2664         and having it make the decision.
2665         
2666         This is logically equivalent, save one case: when we are about to do
2667         a reload, we know that there is no reason to generate the page.  Old
2668         code was causing an extra page generation in this case.
2669         
2670         * TestResultServer/static-dashboards/dashboard_base.js:
2671         (parseParameters):
2672         (handleLocationChange):
2673
2674 2013-01-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2675
2676         [jhbuild] Use the "configure" script to build glib
2677         https://bugs.webkit.org/show_bug.cgi?id=106569
2678
2679         Reviewed by Martin Robinson.
2680
2681         So far both EFL and GTK have been using autogen.sh to build glib.
2682         While that does work most of the time, it's not really needed since
2683         we are downloading and building stable releases from tarballs.
2684         Additionally, autogen.sh fails to work with automake 1.13 due to the
2685         usage of some macros that have been removed (this has already been
2686         fixed in glib master).
2687
2688         * efl/jhbuild.modules:
2689         * gtk/jhbuild.modules:
2690
2691 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
2692
2693         Changing tests to be consistent and use self.scm rather then recreating the scm object.
2694         (Missed a couple)
2695         https://bugs.webkit.org/show_bug.cgi?id=106536
2696
2697         Reviewed by Eric Seidel.
2698
2699         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2700
2701 2013-01-10  Tony Chang  <tony@chromium.org>
2702
2703         Speed up supplemental dependency computation
2704         https://bugs.webkit.org/show_bug.cgi?id=106503
2705
2706         Reviewed by Adam Barth.
2707
2708         Pass the IDL attributes file for generating the bindings in WebKitTestRunner.
2709
2710         * WebKitTestRunner/CMakeLists.txt:
2711
2712 2013-01-10  Zan Dobersek  <zandobersek@gmail.com>
2713
2714         Remove the ENABLE_ANIMATION_API feature define occurences
2715         https://bugs.webkit.org/show_bug.cgi?id=106544
2716
2717         Reviewed by Simon Fraser.
2718
2719         The Animation API code was removed in r137243. The ENABLE_ANIMATION_API
2720         feature define handling still lingers in various build systems and configurations
2721         but is of no use, so it should be removed.
2722
2723         * Scripts/webkitperl/FeatureList.pm:
2724         * qmake/mkspecs/features/features.pri:
2725
2726 2013-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
2727
2728         [GTK] Add support for loading web process extensions
2729         https://bugs.webkit.org/show_bug.cgi?id=105631
2730
2731         Reviewed by Gustavo Noronha Silva.
2732
2733         * MiniBrowser/gtk/GNUmakefile.am:
2734         * MiniBrowser/gtk/main.c:
2735         (main): Set WEBKIT_INJECTED_BUNDLE env var to use the injected
2736         bundle lib from build dir.
2737         * Scripts/webkitpy/style/checker.py: Add exceptions for GTK+ API
2738         located in WebProcess/InjectedBundle/API/gtk.
2739         * gtk/generate-gtkdoc:
2740         (get_webkit2_options): Scan also files in
2741         WebProcess/InjectedBundle/API/gtk to generate API docs.
2742         (get_webkit2_options.injected_bundle_src_path): Helper function to
2743         build paths in WebProcess/InjectedBundle/API/gtk.
2744
2745 2013-01-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2746
2747         [EFL][WK2] Writing immediately to created windows (open) fails
2748         https://bugs.webkit.org/show_bug.cgi?id=105276
2749
2750         Reviewed by Kenneth Rohde Christiansen.
2751
2752         Do not reset 'about:blank' url for the new pages in mini browser.
2753
2754         * MiniBrowser/efl/main.c:
2755         (window_create):
2756
2757 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
2758
2759         Changing tests to be consistent and use self.scm rather then recreating the scm object.
2760         https://bugs.webkit.org/show_bug.cgi?id=106536
2761
2762         Reviewed by Eric Seidel.
2763
2764         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2765
2766 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
2767
2768         Converting to unittest2 so we can use assertItemsEqual, making tests
2769         not dependent on order of items.
2770         https://bugs.webkit.org/show_bug.cgi?id=106532
2771
2772         Before:
2773         Ran 1733 tests in 38.385s
2774         FAILED (failures=1, errors=22)
2775
2776         After:
2777         Ran 1733 tests in 32.298s
2778         FAILED (failures=0, errors=22)
2779
2780         Reviewed by Eric Seidel.
2781
2782         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2783         * Scripts/webkitpy/thirdparty/__init__.py:
2784         (AutoinstallImportHook._install_unittest2):
2785
2786 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
2787
2788         [EFL] Add gstreamer 1.0.5 to jhbuild
2789         https://bugs.webkit.org/show_bug.cgi?id=106178
2790
2791         Reviewed by Laszlo Gombos.
2792
2793         Add gstreamer 1.0.5 to EFL's jhbuild configuration.
2794
2795         * efl/jhbuild.modules:
2796
2797 2013-01-09  Alan Cutter  <alancutter@chromium.org>
2798
2799         Updated parameters in GCE build scripts so they now work.
2800         https://bugs.webkit.org/show_bug.cgi?id=106523
2801
2802         Reviewed by Adam Barth.
2803
2804         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
2805         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
2806         * EWSTools/cold-boot.sh:
2807
2808 2013-01-09  Mark Pilgrim  <pilgrim@chromium.org>
2809
2810         [Chromium] Remove some stray references to WebKitPlatformSupport.h in DumpRenderTree
2811         https://bugs.webkit.org/show_bug.cgi?id=106520
2812
2813         Reviewed by James Robinson.
2814
2815         Part of a larger refactoring series. See tracking bug 82948.
2816
2817         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2818         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2819
2820 2013-01-09  Julie Parent  <jparent@chromium.org>
2821
2822         Dashboard cleanup: Remove code for currentState and window.location.hash getting out of state
2823         https://bugs.webkit.org/show_bug.cgi?id=106514
2824
2825         This is old code, as these can no longer get out of sync.
2826         permmaLinkURLHash is generated from currentState, which is set only
2827         from the location.  The commment about how these can get out of sync
2828         refers to a function that no longer exists.
2829         
2830         Reviewed by Dirk Pranke.
2831
2832         * TestResultServer/static-dashboards/dashboard_base.js:
2833         (handleLocationChange):
2834
2835 2013-01-09  Julie Parent  <jparent@chromium.org>
2836
2837         Dashboard Cleanup: Reload the page as soon as we know we need to.
2838         https://bugs.webkit.org/show_bug.cgi?id=106515
2839
2840         No need to continue parsing all of the data once we know that
2841         we need to do a reload.
2842         
2843         Reviewed by Dirk Pranke.
2844
2845         * TestResultServer/static-dashboards/dashboard_base.js:
2846         (parseParameters):
2847
2848 2013-01-09  Eric Seidel  <eric@webkit.org>
2849
2850         run-perf-tests --chromium-android --profile should show symbols for the kernel
2851         https://bugs.webkit.org/show_bug.cgi?id=106498
2852
2853         Reviewed by Adam Barth.
2854
2855         Turns out this was easy, once I finally read the output from "perf report".
2856         It appears there may be a bug in "perf record" on android, as it complains
2857         about not being able to read from /proc/kallsyms even when
2858         /proc/sys/kernel/kptr_restrict is 0.  For now I've not bothered
2859         to keep /proc/sys/kernel/kptr_restrict as 0 during the actual record
2860         but rather just flip it to 0 long enough to grab the /proc/kallsyms
2861         and then flip it back to whatever the device had.
2862
2863         /proc/sys/kernel/kptr_restrict controls what /proc/kallsyms returns
2864         on Linux.  /proc/kallsyms contains a mapping of kernel addresses
2865         to symbol names.  Its world-readable, but will return all 0s if you
2866         don't have permission to see the kernel symbols.  kptr_restrict
2867         supports values 0, 1, 2.  Where 0 means "everyone can see the real symbols"
2868         1 is only a specific group, and 2 is "no one, not even root".
2869         By default kptr_restrict is 2 on Android it seems.
2870         More kptr_restrict docs: http://lwn.net/Articles/420403/
2871
2872         I also took this opportunity to clean up how the perf record command
2873         was built for use/display in AndroidPerf.profile_after_exit and
2874         change to always using long-form names for the arguments (to hopefully help readability).
2875
2876         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2877         (AndroidPerf.__init__):
2878         (profile_after_exit):
2879         (ChromiumAndroidDriver.__init__):
2880         (ChromiumAndroidDriver._update_kallsyms_cache):
2881         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
2882
2883 2013-01-09  Julie Parent  <jparent@chromium.org>
2884
2885         Dashboard cleanup: remove dead code.
2886         https://bugs.webkit.org/show_bug.cgi?id=106509
2887
2888         Reviewed by Dirk Pranke.
2889
2890         * TestResultServer/static-dashboards/dashboard_base.js:
2891         (parseParameters):
2892
2893 2013-01-09  Joanmarie Diggs  <jdiggs@igalia.com>
2894
2895         [GTK] accessibility/aria-labelledby-overrides-label.html requires a proper baseline
2896         https://bugs.webkit.org/show_bug.cgi?id=105638
2897
2898         Reviewed by Martin Robinson.
2899
2900         The test was failing for two reasons:
2901         - AccessibilityRenderObject::correspondingLabelForControlElement() was
2902           not ignoring the ARIA labelled-by property
2903         - AccessibilityController::accessibleElementById() was not implemented
2904
2905         Because getting an element by ID cannot be done in the UIProcess, the
2906         decision was made to expose the element's ID as an accessible attribute
2907         of the object.
2908
2909         In addition, fixing the bug in AccessibilityRenderObject made it possible
2910         to eliminate the Gtk platform-specific expectations for another test.
2911
2912         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2913         (childElementById): Added. Walks the tree looking for the AtkObject
2914         Attribute which exposes the HTML element's ID.
2915         (AccessibilityController::accessibleElementById): Implemented.
2916         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2917         (AccessibilityUIElement::title): Modified to print out "AXTitle: " even
2918         when there is no title, as is done with the Mac port.
2919         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2920         (WTR):
2921         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2922         (WTR::childElementById): Added. Walks the tree looking for the AtkObject
2923         Attribute which exposes the HTML element's ID.
2924         (WTR):
2925         (WTR::AccessibilityController::accessibleElementById): Implemented.
2926         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2927         (WTR::AccessibilityUIElement::title): Modified to print out "AXTitle: "
2928         even when there is no title, as is done with the Mac port.
2929
2930 2013-01-09  Gregg Tavares  <gman@google.com>
2931
2932         Add Gregg Tavares as a committer
2933         https://bugs.webkit.org/show_bug.cgi?id=106492
2934
2935         Unreviewed.
2936
2937         * Scripts/webkitpy/common/config/committers.py:
2938
2939 2013-01-09  Roger Fong  <roger_fong@apple.com>
2940
2941         Enable seamless iFrames for Windows DRT.
2942         https://bugs.webkit.org/show_bug.cgi?id=106468.
2943
2944         Rubberstamped by Timothy Horton.
2945
2946         * DumpRenderTree/win/DumpRenderTree.cpp:
2947         (resetDefaultsToConsistentValues):
2948
2949 2013-01-09  Christophe Dumez  <christophe.dumez@intel.com>
2950
2951         [WK2] Implement eventSender.scheduleAsynchronousKeyDown
2952         https://bugs.webkit.org/show_bug.cgi?id=93979
2953
2954         Reviewed by Benjamin Poulain.
2955
2956         Implement eventSender.scheduleAsynchronousKeyDown() in
2957         WebKitTestRunner.
2958
2959         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2960         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2961         (WTR::createKeyDownMessageBody):
2962         (WTR::EventSendingController::keyDown):
2963         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
2964         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2965         (EventSendingController):
2966         * WebKitTestRunner/TestController.cpp:
2967         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle):
2968         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2969         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2970         * WebKitTestRunner/TestController.h:
2971         (TestController):
2972
2973 2013-01-09  Jochen Eisinger  <jochen@chromium.org>
2974
2975         [chromium] move resource load callback dumping to TestRunner library
2976         https://bugs.webkit.org/show_bug.cgi?id=106449
2977
2978         Reviewed by Adam Barth.
2979
2980         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2981         (DRTTestRunner::DRTTestRunner):
2982         (DRTTestRunner::reset):
2983         * DumpRenderTree/chromium/DRTTestRunner.h:
2984         (DRTTestRunner):
2985         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2986         (WebKit):
2987         (WebTestRunner::WebTestDelegate::makeURLErrorDescription):
2988         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2989         (WebKit):
2990         (WebTestProxyBase):
2991         (WebTestRunner::WebTestProxy::assignIdentifierToRequest):
2992         (WebTestRunner::WebTestProxy::willRequestResource):
2993         (WebTestRunner::WebTestProxy::willSendRequest):
2994         (WebTestRunner::WebTestProxy::didReceiveResponse):
2995         (WebTestRunner::WebTestProxy::didFinishResourceLoad):
2996         (WebTestRunner::WebTestProxy::didFailResourceLoad):
2997         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2998         (WebTestRunner::WebTestRunner::shouldDumpResourceLoadCallbacks):
2999         (WebTestRunner::WebTestRunner::shouldDumpResourceRequestCallbacks):
3000         (WebTestRunner::WebTestRunner::shouldDumpResourceResponseMIMETypes):
3001         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3002         (WebTestRunner::TestRunner::TestRunner):
3003         (WebTestRunner::TestRunner::reset):
3004         (WebTestRunner::TestRunner::shouldDumpResourceLoadCallbacks):
3005         (WebTestRunner::TestRunner::shouldDumpResourceRequestCallbacks):
3006         (WebTestRunner::TestRunner::shouldDumpResourceResponseMIMETypes):
3007         (WebTestRunner):
3008         (WebTestRunner::TestRunner::dumpResourceLoadCallbacks):
3009         (WebTestRunner::TestRunner::dumpResourceRequestCallbacks):
3010         (WebTestRunner::TestRunner::dumpResourceResponseMIMETypes):
3011         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3012         (TestRunner):
3013         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3014         (WebTestRunner::WebTestProxyBase::reset):
3015         (WebTestRunner):
3016         (WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
3017         (WebTestRunner::WebTestProxyBase::willRequestResource):
3018         (WebTestRunner::WebTestProxyBase::willSendRequest):
3019         (WebTestRunner::WebTestProxyBase::didReceiveResponse):
3020         (WebTestRunner::WebTestProxyBase::didFinishResourceLoad):
3021         (WebTestRunner::WebTestProxyBase::didFailResourceLoad):
3022         * DumpRenderTree/chromium/WebViewHost.cpp:
3023         (WebViewHost::willSendRequest):
3024         (WebViewHost::makeURLErrorDescription):
3025         (WebViewHost::reset):
3026         * DumpRenderTree/chromium/WebViewHost.h:
3027         (WebViewHost):
3028
3029 2013-01-09  Dan Carney  <dcarney@google.com>
3030
3031         [chromium] move dumpcreateview methods to testrunner library
3032         https://bugs.webkit.org/show_bug.cgi?id=106434
3033
3034         Reviewed by Adam Barth.
3035
3036         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3037         (DRTTestRunner::DRTTestRunner):
3038         (DRTTestRunner::reset):
3039         * DumpRenderTree/chromium/DRTTestRunner.h:
3040         (DRTTestRunner):
3041         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3042         (WebTestRunner::WebTestRunner::shouldDumpCreateView):
3043         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3044         (WebTestRunner::TestRunner::TestRunner):
3045         (WebTestRunner::TestRunner::reset):
3046         (WebTestRunner::TestRunner::shouldDumpCreateView):
3047         (WebTestRunner):
3048         (WebTestRunner::TestRunner::dumpCreateView):
3049         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3050         (TestRunner):
3051
3052 2013-01-09  Csaba Osztrogonác  <ossy@webkit.org>
3053
3054         webkitpy cleanup: Merge additional_comment_text into comment_text
3055         https://bugs.webkit.org/show_bug.cgi?id=106421
3056
3057         Reviewed by Adam Barth.
3058
3059         * Scripts/webkitpy/common/config/committervalidator.py:
3060         (CommitterValidator.reject_patch_from_commit_queue):
3061         (CommitterValidator.reject_patch_from_review_queue):
3062         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3063         (Bugzilla.set_flag_on_attachment):
3064         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
3065         (MockBugzilla.set_flag_on_attachment):
3066         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3067         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3068         (AbstractEarlyWarningSystem._post_reject_message_on_bug):
3069         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3070
3071 2013-01-09  Mario Sanchez Prada  <mario.prada@samsung.com>
3072
3073         [GTK] Raise version of gdk-pixbuf in jhbuild up to 2.26.5
3074         https://bugs.webkit.org/show_bug.cgi?id=106464
3075
3076         Reviewed by Martin Robinson.
3077
3078         Current version in jhbuild.modules (2.26.0) is giving trouble to
3079         when trying to build WebKitGTK from scratch, due to a segmentation
3080         fault error in gdk-pixbuf-query-loader during the 'make'
3081         phase. Raising the version to 2.26.5 fixes this issue.
3082
3083         * gtk/jhbuild.modules: Version raised, checksums updated.
3084
3085 2013-01-09  János Badics  <jbadics@inf.u-szeged.hu>
3086
3087         [Qt][NRWT] Pass --timeout to DRT/WTR if a test is marked as SLOW.
3088         https://bugs.webkit.org/show_bug.cgi?id=90968.
3089
3090         Reviewed by Csaba Osztrogonác.
3091
3092         Added functionality in DRT and WTR to use any timeout value while running
3093         slow tests (eventually, any test). Now NRWT --time-out-ms determines the
3094         timeout value for the test. Added a flag in NRWT (supports_per_test_timeout)
3095         to indicate whether the current port supports setting timeout value
3096         per test (it's False by default; I enabled it only on Qt).
3097         Also corrected a typo in driver.py
3098
3099         * DumpRenderTree/DumpRenderTree.h:
3100         (TestCommand::TestCommand):
3101         (TestCommand):
3102         * DumpRenderTree/DumpRenderTreeCommon.cpp:
3103         (parseInputLine):
3104         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3105         (WebCore::DumpRenderTree::processLine):
3106         * Scripts/webkitpy/layout_tests/port/base.py:
3107         (Port.supports_per_test_timeout):
3108         * Scripts/webkitpy/layout_tests/port/driver.py:
3109         (Driver.run_test):
3110         (Driver._command_from_driver_input):
3111         * Scripts/webkitpy/layout_tests/port/qt.py:
3112         (QtPort.supports_per_test_timeout):
3113         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3114         (WTR::InjectedBundle::InjectedBundle):
3115         (WTR::InjectedBundle::didReceiveMessage):
3116         (WTR::InjectedBundle::beginTesting):
3117         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3118         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3119         (WTR::TestRunner::setCustomTimeout):
3120         (WTR):
3121         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3122         (TestRunner):
3123         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
3124         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
3125         * WebKitTestRunner/TestController.cpp:
3126         (WTR::TestController::TestController):
3127         (WTR::TestController::getCustomTimeout):
3128         (WTR):
3129         (WTR::TestCommand::TestCommand):
3130         (TestCommand):
3131         (WTR::parseInputLine):
3132         (WTR::TestController::runTest):
3133         (WTR::TestController::runUntil):
3134         * WebKitTestRunner/TestController.h:
3135         (TestController):
3136         * WebKitTestRunner/TestInvocation.cpp:
3137         (WTR::TestInvocation::TestInvocation):
3138         (WTR::TestInvocation::setCustomTimeout):
3139         (WTR):
3140         (WTR::TestInvocation::invoke):
3141         * WebKitTestRunner/TestInvocation.h:
3142         (TestInvocation):
3143
3144 2013-01-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3145
3146         Regression(r138681): Add HAVE(ACCESSIBILITY) guard to atk files
3147         https://bugs.webkit.org/show_bug.cgi?id=106290
3148
3149         Reviewed by Martin Robinson.
3150
3151         Some atk files don't use HAVE(ACCESSIBILITY). It might make build errors when
3152         the macro isn't enabled.
3153
3154         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3155
3156 2013-01-08  Martin Robinson  <mrobinson@igalia.com>
3157
3158         WebKitTestRunner needs support for setHandlesAuthenticationChallenges
3159         https://bugs.webkit.org/show_bug.cgi?id=103653
3160
3161         Reviewed by Anders Carlsson.
3162
3163         Implement setHandlesAuthenticationChallenges in the UIProcess by sending credentials
3164         and the enabled boolean to the UIProcess and then implementing the didReceiveAuthenticationChallengeInFrame
3165         client callback.
3166
3167         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Exposed the new TestRunner
3168         methods to the JavaScript API.
3169         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3170         (WTR::TestRunner::setHandlesAuthenticationChallenges): Added this callback for the JavaScript API.
3171         (WTR::TestRunner::setAuthenticationUsername): Ditto.
3172         (WTR::TestRunner::setAuthenticationPassword): Ditto.
3173         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3174         (TestRunner): Added new declarations for the above.
3175         * WebKitTestRunner/TestController.cpp:
3176         (WTR::TestController::createWebViewWithOptions): Hook up the new didReceiveSynchronousMessageFromInjectedBundle
3177         callback.
3178         (WTR::TestController::resetStateToConsistentValues): Reset the credentials and enabled boolean between tests.
3179         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Handle the callback by using
3180         the authentication information passed from the InjectedBundle.
3181         * WebKitTestRunner/TestController.h:
3182         (WTR::TestController::setHandlesAuthenticationChallenges): Added setter to allow TestInvocation
3183         to communicate with the TestController.
3184         (WTR::TestController::setAuthenticationUsername): Ditto.
3185         (WTR::TestController::setAuthenticationPassword): Ditto.
3186         (TestController):
3187         * WebKitTestRunner/TestInvocation.cpp:
3188         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Handle the messages sending authentication
3189         information from the InjectedBundle.
3190         (WTR::TestInvocation::outputText): Added this method so that the TestController can output
3191         text to the TestInvocation text output.
3192         * WebKitTestRunner/TestInvocation.h:
3193         (TestInvocation): Added declaration for new method.
3194
3195 2013-01-08  Benjamin Poulain  <benjamin@webkit.org>
3196
3197         Add myself as a watcher for Web Geolocation
3198
3199         Unreviewed.
3200
3201         * Scripts/webkitpy/common/config/watchlist:
3202
3203 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
3204
3205         [webkitpy] Call setup_test_run method of the parent Port interface when method is called on subclasses
3206         https://bugs.webkit.org/show_bug.cgi?id=106364
3207
3208         Reviewed by Eric Seidel.
3209
3210         When the setup_test_run method is called on the subclasses of the base Port
3211         interface, the parent method should also be called via super(), despite the
3212         parent method not doing anything at the moment.
3213
3214         The according calls to super() are required in the ChromiumPort, EflPort
3215         and GtkPort implementations.
3216
3217         * Scripts/webkitpy/layout_tests/port/chromium.py:
3218         (ChromiumPort.setup_test_run):
3219         * Scripts/webkitpy/layout_tests/port/efl.py:
3220         (EflPort.setup_test_run):
3221         * Scripts/webkitpy/layout_tests/port/gtk.py:
3222         (GtkPort.setup_test_run):
3223
3224 2013-01-08  Julie Parent  <jparent@chromium.org>
3225
3226         Dashboard cleanup: Remove globals g_buildersThatFailedToLoad and g_staleBuilders
3227         https://bugs.webkit.org/show_bug.cgi?id=106356
3228
3229         g_buildersThatFailedToLoad and g_staleBuilders were globals defined in
3230         dashboard_base, assigned by Loader, and used only by dashboard_base to
3231         create error messages.  Moved the variables to be privates on the Loader
3232         object, moved error message creation to _getLoadingErrorMessages on the
3233         Loader object, and now pass the errors back to dashboard base via the
3234         resourceLoadingComplete callback.
3235         
3236         Also removed the now unused clearError function, it was only being used
3237         by unit tests to clean up global state.
3238         
3239         Reviewed by Dirk Pranke.
3240
3241         * TestResultServer/static-dashboards/dashboard_base.js:
3242         (resourceLoadingComplete):
3243         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3244         * TestResultServer/static-dashboards/loader.js:
3245         (.):
3246         * TestResultServer/static-dashboards/loader_unittests.js:
3247
3248 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
3249
3250         [EFL][GTK] Make the PulseAudioSanitizer an object on the EflPort, GtkPort
3251         https://bugs.webkit.org/show_bug.cgi?id=106354
3252
3253         Reviewed by Eric Seidel.
3254
3255         Put the PulseAudioSanitizer object on the EflPort and GtkPort interfaces
3256         instead of those two inheriting from it. Also add a mock object of the
3257         sanitizer that's used in unit tests.
3258
3259         * Scripts/webkitpy/layout_tests/port/efl.py:
3260         (EflPort):
3261         (EflPort.__init__):
3262         (EflPort.setup_test_run):
3263         (EflPort.clean_up_test_run):
3264         * Scripts/webkitpy/layout_tests/port/efl_unittest.py: Also correct the
3265         importing order.
3266         (EflPortTest.make_port): Put a mock PulseAudioSanitizer on the instance.
3267         * Scripts/webkitpy/layout_tests/port/gtk.py:
3268         (GtkPort):
3269         (GtkPort.__init__):
3270         (GtkPort.setup_test_run):
3271         (GtkPort.clean_up_test_run):
3272         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py: Also correct the
3273         importing order.
3274         (GtkPortTest.make_port): Put a mock PulseAudioSanitizer on the instance.
3275         * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer.py:
3276         (PulseAudioSanitizer.unload_pulseaudio_module): Stylize the method as public.
3277         (PulseAudioSanitizer.restore_pulseaudio_module): Ditto.
3278         * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer_mock.py: Added.
3279         (PulseAudioSanitizerMock): A simple mock interface for PulseAudioSanitizer.
3280         (PulseAudioSanitizerMock.unload_pulseaudio_module):
3281         (PulseAudioSanitizerMock.restore_pulseaudio_module):
3282
3283 2013-01-08  Jochen Eisinger  <jochen@chromium.org>
3284
3285         [chromium] move dumpFrameLoadCallbacks and friends to the TestRunner library
3286         https://bugs.webkit.org/show_bug.cgi?id=106324
3287
3288         Reviewed by Adam Barth.
3289
3290         Since the frame load callbacks are part of the WebFrameClient, the
3291         WebTestProxy is now intercepting both WebViewClient and WebFrameClient
3292         methods.
3293
3294         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3295         (DRTTestRunner::DRTTestRunner):
3296         (DRTTestRunner::reset):
3297         * DumpRenderTree/chromium/DRTTestRunner.h:
3298         (DRTTestRunner):
3299         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3300         (WebTestInterfaces):
3301         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3302         (WebKit):
3303         (WebTestProxyBase):
3304         (WebTestRunner):
3305         (WebTestRunner::WebTestProxy::WebTestProxy):
3306         (WebTestProxy):
3307         (WebTestRunner::WebTestProxy::didInvalidateRect):
3308         (WebTestRunner::WebTestProxy::didScrollRect):
3309         (WebTestRunner::WebTestProxy::scheduleComposite):
3310         (WebTestRunner::WebTestProxy::scheduleAnimation):
3311         (WebTestRunner::WebTestProxy::setWindowRect):
3312         (WebTestRunner::WebTestProxy::show):
3313         (WebTestRunner::WebTestProxy::didAutoResize):
3314         (WebTestRunner::WebTestProxy::postAccessibilityNotification):
3315         (WebTestRunner::WebTestProxy::startDragging):
3316         (WebTestRunner::WebTestProxy::shouldBeginEditing):
3317         (WebTestRunner::WebTestProxy::shouldEndEditing):
3318         (WebTestRunner::WebTestProxy::shouldInsertNode):
3319         (WebTestRunner::WebTestProxy::shouldInsertText):
3320         (WebTestRunner::WebTestProxy::shouldChangeSelectedRange):
3321         (WebTestRunner::WebTestProxy::shouldDeleteRange):
3322         (WebTestRunner::WebTestProxy::shouldApplyStyle):
3323         (WebTestRunner::WebTestProxy::didBeginEditing):
3324         (WebTestRunner::WebTestProxy::didChangeSelection):
3325         (WebTestRunner::WebTestProxy::didChangeContents):
3326         (WebTestRunner::WebTestProxy::didEndEditing):
3327         (WebTestRunner::WebTestProxy::registerIntentService):
3328         (WebTestRunner::WebTestProxy::dispatchIntent):
3329         (WebTestRunner::WebTestProxy::willPerformClientRedirect):
3330         (WebTestRunner::WebTestProxy::didCancelClientRedirect):
3331         (WebTestRunner::WebTestProxy::didStartProvisionalLoad):
3332         (WebTestRunner::WebTestProxy::didReceiveServerRedirectForProvisionalLoad):
3333         (WebTestRunner::WebTestProxy::didFailProvisionalLoad):
3334         (WebTestRunner::WebTestProxy::didCommitProvisionalLoad):
3335         (WebTestRunner::WebTestProxy::didReceiveTitle):
3336         (WebTestRunner::WebTestProxy::didFinishDocumentLoad):
3337         (WebTestRunner::WebTestProxy::didHandleOnloadEvents):
3338         (WebTestRunner::WebTestProxy::didFailLoad):
3339         (WebTestRunner::WebTestProxy::didFinishLoad):
3340         (WebTestRunner::WebTestProxy::didChangeLocationWithinPage):
3341         (WebTestRunner::WebTestProxy::didDisplayInsecureContent):
3342         (WebTestRunner::WebTestProxy::didRunInsecureContent):
3343         (WebTestRunner::WebTestProxy::didDetectXSS):
3344         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3345         (WebTestRunner::WebTestRunner::setTestIsRunning):
3346         (WebTestRunner::WebTestRunner::shouldDumpFrameLoadCallbacks):
3347         (WebTestRunner::WebTestRunner::setShouldDumpFrameLoadCallbacks):
3348         (WebTestRunner::WebTestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
3349         (WebTestRunner::WebTestRunner::stopProvisionalFrameLoads):
3350         (WebTestRunner::WebTestRunner::shouldDumpTitleChanges):
3351         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3352         (WebTestRunner::TestRunner::TestRunner):
3353         (WebTestRunner::TestRunner::reset):
3354         (WebTestRunner::TestRunner::setTestIsRunning):
3355         (WebTestRunner):
3356         (WebTestRunner::TestRunner::shouldDumpFrameLoadCallbacks):
3357         (WebTestRunner::TestRunner::setShouldDumpFrameLoadCallbacks):
3358         (WebTestRunner::TestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
3359         (WebTestRunner::TestRunner::stopProvisionalFrameLoads):
3360         (WebTestRunner::TestRunner::shouldDumpTitleChanges):
3361         (WebTestRunner::TestRunner::dumpFrameLoadCallbacks):
3362         (WebTestRunner::TestRunner::dumpUserGestureInFrameLoadCallbacks):
3363         (WebTestRunner::TestRunner::setStopProvisionalFrameLoads):
3364         (WebTestRunner::TestRunner::dumpTitleChanges):
3365         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3366         (TestRunner):
3367         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3368         (WebTestInterfaces::Internal):
3369         (WebTestRunner::WebTestInterfaces::Internal::webView):
3370         (WebTestRunner::WebTestInterfaces::Internal::Internal):
3371         (WebTestRunner::WebTestInterfaces::Internal::setWebView):
3372         (WebTestRunner):
3373         (WebTestRunner::WebTestInterfaces::Internal::setTestIsRunning):
3374         (WebTestRunner::WebTestInterfaces::setWebView):
3375         (WebTestRunner::WebTestInterfaces::setTestIsRunning):
3376         (WebTestRunner::WebTestInterfaces::webView):
3377         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3378         (WebTestRunner::WebTestProxyBase::willPerformClientRedirect):
3379         (WebTestRunner):
3380         (WebTestRunner::WebTestProxyBase::didCancelClientRedirect):
3381         (WebTestRunner::WebTestProxyBase::didStartProvisionalLoad):
3382         (WebTestRunner::WebTestProxyBase::didReceiveServerRedirectForProvisionalLoad):
3383         (WebTestRunner::WebTestProxyBase::didFailProvisionalLoad):
3384         (WebTestRunner::WebTestProxyBase::didCommitProvisionalLoad):
3385         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
3386         (WebTestRunner::WebTestProxyBase::didFinishDocumentLoad):
3387         (WebTestRunner::WebTestProxyBase::didHandleOnloadEvents):
3388         (WebTestRunner::WebTestProxyBase::didFailLoad):
3389         (WebTestRunner::WebTestProxyBase::didFinishLoad):
3390         (WebTestRunner::WebTestProxyBase::didChangeLocationWithinPage):
3391         (WebTestRunner::WebTestProxyBase::didDisplayInsecureContent):
3392         (WebTestRunner::WebTestProxyBase::didRunInsecureContent):
3393         (WebTestRunner::WebTestProxyBase::didDetectXSS):
3394         * DumpRenderTree/chromium/TestShell.cpp:
3395         (TestShell::runFileTest):
3396         (TestShell::testFinished):
3397         * DumpRenderTree/chromium/TestShell.h:
3398         (TestShell):
3399         * DumpRenderTree/chromium/WebViewHost.cpp:
3400         (WebViewHost::didStartProvisionalLoad):
3401         (WebViewHost::didReceiveServerRedirectForProvisionalLoad):
3402         (WebViewHost::didFailProvisionalLoad):
3403         (WebViewHost::didCommitProvisionalLoad):
3404         (WebViewHost::didReceiveTitle):
3405         (WebViewHost::didFailLoad):
3406         (WebViewHost::didFinishLoad):
3407         * DumpRenderTree/chromium/WebViewHost.h:
3408         (WebViewHost):
3409
3410 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
3411
3412         [GTK] Lower the default timeout value for WebKitTestRunner
3413         https://bugs.webkit.org/show_bug.cgi?id=106353
3414
3415         Reviewed by Dirk Pranke.
3416
3417         The default timeout value for WebKitTestRunner should be lowered.
3418         The current value (80 seconds) is irrational and just leads to producing
3419         text failures for layout tests that genuinely time out. This just leads
3420         to more deviation from the GTK WK1 port in terms of test expectations.
3421
3422         The value used is the same as when running the DumpRenderTree, that's
3423         6 seconds in release builds and 12 seconds in debug builds.
3424
3425         * Scripts/webkitpy/layout_tests/port/gtk.py:
3426         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3427         (GtkPortTest.test_default_timeout_ms):
3428
3429 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
3430
3431         test-webkitpy shows failure output on my linux box
3432         https://bugs.webkit.org/show_bug.cgi?id=101261
3433
3434         Reviewed by Eric Seidel.
3435
3436         Mock out the PulseAudioSanitizer methods when creating testing instances
3437         of EflPort and GtkPort interfaces in unit tests. This stops throwing up
3438         PulseAudio output when the sanitizer was trying to unload modules which
3439         were already unloaded by another unit test that was being run in parallel.
3440
3441         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
3442         (EflPortTest):
3443         (EflPortTest.make_port):
3444         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3445         (GtkPortTest):
3446         (GtkPortTest.make_port):
3447
3448 2013-01-08  Julie Parent  <jparent@chromium.org>
3449
3450         Dashboard Cleanup: Remove g_hasDoneInitialPageGeneration
3451         https://bugs.webkit.org/show_bug.cgi?id=106254
3452
3453         Remove the global variable g_hasDoneInitialPageGeneration.  It was used
3454         only to figure out if we should call addBuilderLoadErrors during
3455         handleLocationChange, which was called when the loader completed and on
3456         any hash change, but we only ever wanted to call addBuilderLoadErrors
3457         on the initial loader load.  Moved the call of addBuilderLoadErrors to
3458         resourceLoadingComplete rather than handleLocationChange, so now we
3459         only call it when we want to, and the check can go away completely.
3460
3461         Reviewed by Dirk Pranke.
3462
3463         * TestResultServer/static-dashboards/dashboard_base.js:
3464         (addBuilderLoadErrors):
3465         (resourceLoadingComplete):
3466         (handleLocationChange):
3467         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3468
3469 2013-01-08  Dominic Mazzoni  <dmazzoni@google.com>
3470
3471         Add aboxhall@chromium.org to accessibility watchlist.
3472
3473         Unreviewed.
3474
3475         * Scripts/webkitpy/common/config/watchlist:
3476
3477 2013-01-08  Dan Winship  <danw@gnome.org>
3478
3479         Add Apache 2.4 support for Fedora 18
3480         https://bugs.webkit.org/show_bug.cgi?id=104478
3481
3482         Reviewed by Martin Robinson.
3483
3484         Apache 2.4's httpd.conf is slightly incompatible with 2.2's, so we
3485         need a separate config.
3486
3487         * Scripts/webkitpy/layout_tests/port/base.py:
3488         (Port._apache_version):
3489         (Port._apache_config_file_name_for_platform):
3490         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3491         * Scripts/run-webkit-httpd:
3492         * Scripts/webkitperl/httpd.pm:
3493         (getApacheVersion):
3494         (getDefaultConfigForTestDirectory):
3495         (getHTTPDConfigPathForTestDirectory):
3496
3497 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
3498
3499         Make the override-feature-defines script compatible with Python v3
3500         https://bugs.webkit.org/show_bug.cgi?id=105742
3501
3502         Reviewed by Martin Robinson.
3503
3504         Instead of printing output through a statement, use the print function and format
3505         the output using the str.format method. This makes the script runnable with Python v3.
3506
3507         * gtk/override-feature-defines:
3508         (adjust_feature_defines_makefile):
3509
3510 2013-01-08  Heikki Paajanen  <heikki.paajanen@palm.com>
3511
3512         [Qt] Fix libxml2 config test
3513         https://bugs.webkit.org/show_bug.cgi?id=106317
3514
3515         Reviewed by Simon Hausmann.
3516
3517         Don't assume standard include/libxml2, libxml-2.0.pc should know
3518         where it's headers are.
3519
3520         * qmake/config.tests/libxml2/libxml2.cpp: Fix include
3521
3522 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
3523
3524         [GTK] Make Tools/gtk/generate-gtkdoc compatible with Python 3
3525         https://bugs.webkit.org/show_bug.cgi?id=106195
3526
3527         Reviewed by Philippe Normand.
3528
3529         Perform changes in the generate-gtkdoc script and common and gtkdoc modules
3530         to make the Python code compatible with Python 3. This includes modifying
3531         print statements, exception handling, dictionary iteration and
3532         byte-sequence-to-string conversion.
3533
3534         * gtk/common.py:
3535         (get_build_path):
3536         (pkg_config_file_variable):
3537         (gtk_version_of_pkg_config_file):
3538         * gtk/generate-gtkdoc:
3539         (print_missing_api):
3540         * gtk/gtkdoc.py:
3541         (GTKDoc.__init__):
3542         (GTKDoc._run_command):
3543
3544 2013-01-02  Steve Block  <steveblock@chromium.org>
3545
3546         Add chromium.org email address for Steve Block.
3547
3548         Unreviewed.
3549
3550         * Scripts/webkitpy/common/config/committers.py:
3551
3552 2013-01-07  Filip Pizlo  <fpizlo@apple.com>
3553
3554         Rationalize closure call heuristics and profiling
3555         https://bugs.webkit.org/show_bug.cgi?id=106270
3556
3557         Reviewed by Oliver Hunt.
3558         
3559         Add ability to use display-profiler-output via a pipe, and add the ability to dump
3560         all generated code ('display *' or 'd *').
3561
3562         * Scripts/display-profiler-output:
3563
3564 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
3565
3566         Sorted more xcodeproj files.
3567
3568         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3569         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3570         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
3571
3572 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
3573
3574         Sorted xcodeproj files.
3575
3576         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3577         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3578
3579 2013-01-07  Dan Bernstein  <mitz@apple.com>
3580
3581         [mac] WebKit1 clients can’t tell when a frame has been removed from the hierarchy
3582         https://bugs.webkit.org/show_bug.cgi?id=106261
3583
3584         Reviewed by Simon Fraser.
3585
3586         Added a test for -[WebFrameLoadDelegate webView:didRemoveFrameFromHierarchy:].
3587
3588         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3589         * TestWebKitAPI/Tests/mac/WebViewDidRemoveFrameFromHierarchy.mm: Added.
3590         (-[DidRemoveFrameFromHierarchyFrameLoadDelegate webView:didFinishLoadForFrame:]):
3591         (-[DidRemoveFrameFromHierarchyFrameLoadDelegate webView:didRemoveFrameFromHierarchy:]):
3592         (TestWebKitAPI):
3593         (TestWebKitAPI::TEST):
3594
3595 2013-01-07  Ojan Vafai  <ojan@chromium.org>
3596
3597         Add the Apple MountainLion bots to garden-o-matic.
3598         Eventually, we really should move away from hardcoding
3599         the list of bots.
3600
3601         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3602
3603 2013-01-07  Jochen Eisinger  <jochen@chromium.org>
3604
3605         [chromium] move web audio related methods to testrunner library
3606         https://bugs.webkit.org/show_bug.cgi?id=106211
3607
3608         Reviewed by Adam Barth.
3609
3610         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3611         (DRTTestRunner::DRTTestRunner):
3612         (DRTTestRunner::reset):
3613         * DumpRenderTree/chromium/DRTTestRunner.h:
3614         (DRTTestRunner):
3615         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3616         (WebKit):
3617         (WebTestRunner::WebTestRunner::shouldDumpAsAudio):
3618         (WebTestRunner::WebTestRunner::audioData):
3619         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3620         (WebTestRunner::TestRunner::TestRunner):
3621         (WebTestRunner::TestRunner::reset):
3622         (WebTestRunner::TestRunner::shouldDumpAsAudio):
3623         (WebTestRunner):
3624         (WebTestRunner::TestRunner::audioData):
3625         (WebTestRunner::TestRunner::setAudioData):
3626         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3627         (TestRunner):
3628         * DumpRenderTree/chromium/TestShell.cpp:
3629         (TestShell::dump):
3630
3631 2013-01-07  Mike West  <mkwst@chromium.org>
3632
3633         Make the IFRAME_SEAMLESS flag runtime-enabled.
3634         https://bugs.webkit.org/show_bug.cgi?id=106213
3635
3636         Reviewed by Ojan Vafai.
3637
3638         * DumpRenderTree/chromium/TestShell.cpp:
3639         (TestShell::TestShell):
3640         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3641         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3642         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3643         (resetDefaultsToConsistentValues):
3644         * DumpRenderTree/mac/DumpRenderTree.mm:
3645         (resetDefaultsToConsistentValues):
3646         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3647         (WebCore::WebPage::resetSettings):
3648         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3649         (WTR::InjectedBundle::beginTesting):
3650             Ensure that seamless IFrames are enabled for layout tests in each of
3651             the ports that support seamless IFrames.
3652
3653 2013-01-07  Jochen Eisinger  <jochen@chromium.org>
3654
3655         [chromium] move dumpAsText and friends to the TestRunner library
3656         https://bugs.webkit.org/show_bug.cgi?id=106222
3657
3658         Reviewed by Adam Barth.
3659
3660         This moves dumpAsText, dumpChildFramesAsText, and dumpChildFrameScrollPositions to the TestRunner library.
3661
3662         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3663         (DRTTestRunner::DRTTestRunner):
3664     &