[GTK] Ensure generated events have given modifiers GDK understands
[WebKit-https.git] / Tools / ChangeLog
1 2014-02-04  Carlos Garnacho  <carlosg@gnome.org>
2
3         [GTK] Ensure generated events have given modifiers GDK understands
4         https://bugs.webkit.org/show_bug.cgi?id=128171
5
6         Reviewed by Carlos Garcia Campos.
7
8         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
9         (WTR::webkitModifiersToGDKModifiers): Move around
10         (WTR::EventSenderProxy::createMouseButtonEvent):
11         (WTR::EventSenderProxy::keyDown): Use webkitModifiersToGDKModifiers to
12         translate WKEventModifiers.
13
14 2014-02-04  Gabor Rapcsanyi  <rgabor@webkit.org>
15
16         Fine tuning the ARM EFL bots
17         https://bugs.webkit.org/show_bug.cgi?id=128168
18
19         Reviewed by Csaba Osztrogonác.
20
21         * BuildSlaveSupport/build.webkit.org-config/config.json: Add custom SVN mirror.
22         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
23         (WaitForSVNServer): Make it not to halt before the first repository checkout.
24         (WaitForSVNServer.evaluateCommand):
25         (Factory.__init__): Disable kill-old-processes step on EFL ARM bots, because these
26         bots run on the same machine and they kill the processes of each other.
27
28 2014-02-03  Ryosuke Niwa  <rniwa@webkit.org>
29
30         kill-old-processes doesn't kill plugin processes
31         https://bugs.webkit.org/show_bug.cgi?id=128138
32
33         Reviewed by Andreas Kling.
34
35         Add plugin process names to the list of processes to kill.
36
37         * BuildSlaveSupport/kill-old-processes:
38         (main):
39
40 2014-02-03  Dean Jackson  <dino@apple.com>
41
42         Feature flag for shape-inside
43         https://bugs.webkit.org/show_bug.cgi?id=128001
44
45         Reviewed by Simon Fraser.
46
47         Add CSS_SHAPE_INSIDE flag, and -css-shape-inside build
48         flag.
49
50         * Scripts/webkitperl/FeatureList.pm:
51
52 2014-02-03  Zoltan Horvath  <zoltan@webkit.org>
53
54         Unreviewed. Reorder my e-mail addresses in contributors.json,
55         so bugzilla will auto complete my actual bugzilla username.
56
57         * Scripts/webkitpy/common/config/contributors.json:
58
59 2014-02-03  Daniel Bates  <dabates@apple.com>
60
61         WebKit Bot Watcher's Dashboard: Defer subsequent resource loads from access-restricted build bot when
62         iteration fails to load with HTTP 401 status code
63         https://bugs.webkit.org/show_bug.cgi?id=128077
64
65         Reviewed by Alexey Proskuryakov.
66
67         Similar to the fix for <https://bugs.webkit.org/show_bug.cgi?id=127849>, we should only prompt for
68         the HTTP credentials of a build bot so long as an earlier authentication request wasn't cancelled
69         (i.e. failed with an HTTP 401 Unauthorized status code). Currently an authentication dialog will be
70         presented for an iteration each time the update queue timer fires until a person successfully
71         authenticates. Instead we should update the authentication status of the build bot on receiving an
72         HTTP 401 response code such that we defer subsequent requests to load any resource from the access-
73         restricted build bot when the queue update timer fires.
74
75         A person must explicitly click the "unauthorized" status line shown for the queue associated with the
76         iteration in the dashboard and authenticate successfully for the iteration to be loaded once an
77         authentication request for an iteration is cancelled.
78
79         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
80         (BuildbotIteration.prototype.update): Early return if the associated Buildbot was given invalid credentials.
81         Also notify the associated Buildbot and update the queue view when a load failed with an HTTP 401 status code.
82         (BuildbotIteration.prototype.loadLayoutTestResults): Ditto.
83         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
84         (BuildbotQueueView): Modified to call BuildbotQueueView.prototype._unauthorizedAccess instead of
85         QueueView.prototype._updateSoon when event BuildbotQueue.Event.UnauthorizedAccess is received.
86         (BuildbotQueueView.prototype._unauthorizedAccess): Added.
87
88 2014-02-03  Daniel Bates  <dabates@apple.com>
89
90         WebKit Bot Watcher's Dashboard: Teach JSON.load() to interpret third argument as either an
91         option dictionary or a failure callback
92         https://bugs.webkit.org/show_bug.cgi?id=128080
93
94         Reviewed by Alexey Proskuryakov.
95
96         Currently JSON.load() takes a failure callback function as its third argument and
97         an option dictionary as its fourth argument. So, a caller that wants to ignore errors
98         and pass an option dictionary must pass null or a reference to an empty function for
99         the value of third argument. Instead, we should make the third argument polymorphic for
100         convenience. Then a caller can either pass a failure callback function or an option dictionary.
101
102         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
103
104 2014-02-03  Krzysztof Czech  <k.czech@samsung.com>
105
106         [ATK] Expose aria-controls through ATK_RELATION_CONTROLLER_FOR
107         https://bugs.webkit.org/show_bug.cgi?id=127908
108
109         Reviewed by Chris Fleizach.
110
111         Updated AccessibilityUIElement both in WKTR and DRT so that aria-controls support could be tested properly.
112         Added empty stubs to not break mac builds.
113
114         * DumpRenderTree/AccessibilityUIElement.cpp:
115         (ariaControlsElementAtIndexCallback):
116         (AccessibilityUIElement::getJSClass):
117         * DumpRenderTree/AccessibilityUIElement.h:
118         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
119         (accessibilityElementAtIndex):
120         (AccessibilityUIElement::disclosedRowAtIndex):
121         (AccessibilityUIElement::ariaOwnsElementAtIndex):
122         (AccessibilityUIElement::ariaFlowToElementAtIndex):
123         (AccessibilityUIElement::ariaControlsElementAtIndex):
124         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
125         (AccessibilityUIElement::ariaControlsElementAtIndex):
126         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
127         (AccessibilityUIElement::ariaControlsElementAtIndex):
128         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
129         (AccessibilityUIElement::ariaControlsElementAtIndex):
130         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
131         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
132         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
133         (WTR::accessibilityElementAtIndex):
134         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
135         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
136         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
137         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
138         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
139         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
140         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
141         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
142
143 2014-02-02  Daniel Bates  <dabates@apple.com>
144
145         WebKit Bot Watcher's Dashboard: Access restricted queue should only prompt for HTTP credentials once per page load
146         https://bugs.webkit.org/show_bug.cgi?id=127849
147
148         I inadvertently used the equality operator instead of the identity operator when comparing the
149         value of the error HTTP status code with the numeric literal 401.
150
151         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
152         (BuildbotQueue.prototype.update):
153
154 2014-02-02  Daniel Bates  <dabates@apple.com>
155
156         Attempt to fix production dashboard after <http://trac.webkit.org/changeset/163222>
157
158         Actually pass option dictionary to JSON.load(); JSON.load() takes four arguments with the
159         last-most argument being the option dictionary.
160
161         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
162         (BuildbotIteration.prototype.update):
163
164 2014-02-01  Filip Pizlo  <fpizlo@apple.com>
165
166         JSC profiler's stub info profiling support should work again
167         https://bugs.webkit.org/show_bug.cgi?id=128057
168
169         Reviewed by Mark Lam.
170
171         * Scripts/display-profiler-output: Just make sure that there's always a space between the origin stack dump and the top bytecode index.
172
173 2014-02-01  Filip Pizlo  <fpizlo@apple.com>
174
175         JSC profiler should show reasons for jettison
176         https://bugs.webkit.org/show_bug.cgi?id=128047
177
178         Reviewed by Geoffrey Garen.
179         
180         Gave the tool a "log" command, that tells you all of the interesting things
181         that happened to a piece of bytecode, from the standpoint of optimization.
182         It's a great summary view for seeing how our tier-up machinery works.
183         
184         This uses a lot of information that was already available, plus the newly
185         added jettisonReason field.
186
187         * Scripts/display-profiler-output:
188
189 2014-01-31  Ryosuke Niwa  <rniwa@webkit.org>
190
191         Remove inline member functions of FrameSelection that access m_selection
192         https://bugs.webkit.org/show_bug.cgi?id=127986
193
194         Reviewed by Enrica Casucci.
195
196         * TestWebKitAPI/Configurations/Base.xcconfig:
197
198 2014-01-31  Anders Carlsson  <andersca@apple.com>
199
200         Another attempt at fixing the build.
201
202         * TestWebKitAPI/Configurations/Base.xcconfig:
203
204 2014-01-31  Oliver Hunt  <oliver@apple.com>
205
206         Rollout r163195 and related patches
207
208         * DumpRenderTree/CMakeLists.txt:
209         * WebKitTestRunner/CMakeLists.txt:
210         * WinCELauncher/CMakeLists.txt:
211
212 2014-01-31  Daniel Bates  <dabates@apple.com>
213
214         Attempt to fix Production Dashboard after <http://trac.webkit.org/changeset/163213>
215         (https://bugs.webkit.org/show_bug.cgi?id=127849)
216
217         Reviewed by David Farler.
218
219         Pass credentials when querying build bot iteration. 
220
221         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
222         (BuildbotIteration.prototype.update):
223         (BuildbotIteration.prototype.loadLayoutTestResults):
224
225 2014-01-31  Anders Carlsson  <andersca@apple.com>
226
227         Fix iOS build.
228
229         * TestWebKitAPI/Configurations/Base.xcconfig:
230
231 2014-01-31  Simon Fraser  <simon.fraser@apple.com>
232
233         WebKitTestRunner project doesn't show Mac as a valid destination architecture.
234         
235         Make sure that SUPPORTED_PLATFORMS is defined in Base.xcconfig.
236         
237         Also add BaseTarget.xcconfig to the project.
238
239         * WebKitTestRunner/Configurations/Base.xcconfig:
240         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
241
242 2014-01-31  Daniel Bates  <dabates@apple.com>
243
244         WebKit Bot Watcher's Dashboard: Access restricted queue should only prompt for HTTP credentials once per page load
245         https://bugs.webkit.org/show_bug.cgi?id=127849
246
247         Reviewed by Alexey Proskuryakov.
248
249         Currently whenever the dashboard updates the status of a queue whose Buildbot requires authentication
250         it will cause a browser to prompt for credentials once per update until valid credentials are provided.
251         Instead we should keep track of Buildbots that respond with an HTTP 401 Unauthorized status code to avoid
252         subsequently querying them and hence cause a browser to prompt for credentials. Together with an optional
253         hint provided when instantiating a Buildbot object as to whether it requires authentication, we can make
254         the dashboard prompt for HTTP credentials exactly once per page load for each queue whose associated
255         Buildbot requires authentication.
256
257         Queues whose Buildbot wasn't authenticated will show in the dashboard as "unauthorized". Clicking on
258         this status message will cause the browser to prompt for credentials.
259
260         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
261         (Buildbot): Initialize instance variable authenticationStatus to Buildbot.AuthenticationStatus.Unauthenticated.
262         (Buildbot.prototype.get needsAuthentication): Added.
263         (Buildbot.prototype.get authenticationStatus): Added.
264         (Buildbot.prototype.get isAuthenticated): Added.
265         (Buildbot.prototype.set isAuthenticated): Added.
266         (Buildbot.prototype.updateQueues): Added.
267         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
268         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Modified to call
269         BuildbotQueueView.prototype._appendUnauthorizedLineView() to update the view and show status of the queue as
270         "unauthorized" if the Buildbot associated with the queue is either unauthenticated or was given invalid credentials.
271         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
272         (BuildbotQueue.prototype.update): Return immediately if the associated Buildbot requires authentication.
273         Additionally, if the JSON load fails with an HTTP 401 Unauthorized access error (say, credentials were
274         invalidated) then update the authentication status of the Buildbot to avoid subsequently prompting a
275         person for credentials the next time the queue update timer fires.
276         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
277         (BuildbotQueueView): Register as a listener for event BuildbotQueue.Event.UnauthorizedAccess on each queue
278         so that the view can be updated to show status "unauthorized".
279         (BuildbotQueueView.prototype._appendUnauthorizedLineView): Added.
280         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
281         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
282         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js: Added new status, StatusLineView.Status.Unauthorized.
283         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
284         (.status-line.unauthorized .bubble): Added.
285         (.status-line.unauthorized .bubble.pictogram): Added.
286         (.status-line.unauthorized .message): Added.
287
288 2014-01-31  Filip Pizlo  <fpizlo@apple.com>
289
290         Unreviewed, really make --copy-libraries a no-able option.
291         
292         * Scripts/build-jsc:
293
294 2014-01-31  Filip Pizlo  <fpizlo@apple.com>
295
296         Unreviewed, really add the --copy-libraries option.
297
298         * Scripts/build-jsc:
299
300 2014-01-31  Filip Pizlo  <fpizlo@apple.com>
301
302         Unreviewed, fix the script for older Rubies.
303
304         * Scripts/export-llvm-build:
305
306 2014-01-31  Filip Pizlo  <fpizlo@apple.com>
307
308         Having a custom LLVM checkout should always override all other ways of getting LLVM
309         https://bugs.webkit.org/show_bug.cgi?id=128015
310
311         Reviewed by Oliver Hunt.
312
313         * Scripts/copy-webkitlibraries-to-product-directory:
314
315 2014-01-31  Daniel Bates  <dabates@apple.com>
316
317         WebKit Bot Watcher's Dashboard: Teach JSON.load() to take optional failure callback function
318         https://bugs.webkit.org/show_bug.cgi?id=127924
319
320         Reviewed by Alexey Proskuryakov.
321
322         Towards providing better error handling when a JSON load fails with a non-200 HTTP status
323         code, we should teach JSON.load() to take an optional failure callback function and invoke
324         it when either a load error or a JSON parsing error occurs.
325
326         As a side benefit of having a failure callback function a caller can separate the error handling
327         logic for a JSON load or parse error from the logic of handling a successful parsing of JSON content.
328
329         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
330         (BuildbotIteration.prototype.loadLayoutTestResults): Move JSON parser error logic into failure
331         callback function.
332         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
333         (JSON.load): Modified to take optional failure callback function called failureCallback.
334
335 2014-01-29  Oliver Hunt  <oliver@apple.com>
336
337         Make it possible to implement JS builtins in JS
338         https://bugs.webkit.org/show_bug.cgi?id=127887
339
340         Reviewed by Michael Saboff.
341
342         CMake updates
343
344         * DumpRenderTree/CMakeLists.txt:
345         * WebKitTestRunner/CMakeLists.txt:
346         * WinCELauncher/CMakeLists.txt:
347
348 2014-01-31  Filip Pizlo  <fpizlo@apple.com>
349
350         Allow more flexibility for copy-webkitlibraries-to-product-directory
351         https://bugs.webkit.org/show_bug.cgi?id=128010
352
353         Reviewed by Oliver Hunt.
354         
355         It's now the case that copy-webkitlibraries-to-product-directory does nothing by
356         default, but you can tell it to either copy WebKitSystemInterface (--wksi) or LLVM
357         (--llvm). You can also tell it where to get LLVM from.
358
359         * Scripts/build-jsc:
360         * Scripts/build-webkit:
361         * Scripts/copy-webkitlibraries-to-product-directory:
362
363 2014-01-31  David Farler  <dfarler@apple.com>
364
365         DumpRenderTree iOS fails to link: missing rowHeaders and columnHeaders in AccessibilityUIElement
366         https://bugs.webkit.org/show_bug.cgi?id=128004
367
368         Reviewed by Chris Fleizach.
369
370         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
371         (AccessibilityUIElement::columnHeaders): Stub added.
372         (AccessibilityUIElement::rowHeaders): Stub added.
373
374 2014-01-31  Zoltan Horvath  <zoltan@webkit.org>
375
376         Unreviewed. Update my contributors.json entry.
377
378         * Scripts/webkitpy/common/config/contributors.json:
379
380 2014-01-31  Anders Carlsson  <andersca@apple.com>
381
382         REGRESSION: WebKit2.PageLoadBasic API test is failing
383         https://bugs.webkit.org/show_bug.cgi?id=127892
384
385         Reviewed by Dan Bernstein.
386
387         Re-enable test.
388
389         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
390
391 2014-01-31  Csaba Osztrogonác  <ossy@webkit.org>
392
393         [jhbuild] Disable escape sequences in EWS output
394         https://bugs.webkit.org/show_bug.cgi?id=127922
395
396         Reviewed by Alexey Proskuryakov.
397
398         * Scripts/webkitpy/common/system/environment.py:
399         (Environment.disable_gcc_smartquotes):
400         (Environment):
401         (Environment.disable_jhbuild_VT100_output):
402         * Scripts/webkitpy/tool/commands/download_unittest.py:
403         * Scripts/webkitpy/tool/steps/build.py:
404         (Build.build):
405
406 2014-01-30  Martin Robinson  <mrobinson@igalia.com>
407
408         [GTK] [CMake] Add support for building against GTK+ 2
409         https://bugs.webkit.org/show_bug.cgi?id=127959
410
411         Reviewed by Anders Carlsson.
412
413         * DumpRenderTree/PlatformGTK.cmake: Use the new API version variable and don't use GTK3 directly.
414         * GtkLauncher/CMakeLists.txt: Ditto.
415         * ImageDiff/PlatformGTK.cmake: Ditto.
416         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Ditto.
417
418 2014-01-30  Anders Carlsson  <andersca@apple.com>
419
420         Add webView:didFinishLoadingNavigation: delegate method
421         https://bugs.webkit.org/show_bug.cgi?id=127976
422
423         Reviewed by Dan Bernstein.
424
425         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
426         (-[NavigationDelegate webView:didCommitNavigation:]):
427         (-[NavigationDelegate webView:didFinishLoadingNavigation:]):
428
429 2014-01-30  Anders Carlsson  <andersca@apple.com>
430
431         Add a webView:didCommitNavigation: delegate method
432         https://bugs.webkit.org/show_bug.cgi?id=127972
433
434         Reviewed by Dan Bernstein.
435
436         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
437         (-[NavigationDelegate webView:didStartProvisionalNavigation:]):
438         (-[NavigationDelegate webView:didCommitNavigation:]):
439
440 2014-01-30  Anders Carlsson  <andersca@apple.com>
441
442         Add a webView:didFailProvisionalNavigation:withError: delegate method
443         https://bugs.webkit.org/show_bug.cgi?id=127968
444
445         Reviewed by Dan Bernstein.
446
447         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
448         (-[DidFailProvisionalNavigationDelegate webView:didStartProvisionalNavigation:]):
449         (-[DidFailProvisionalNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
450         (TEST):
451
452 2014-01-30  Ryosuke Niwa  <rniwa@webkit.org>
453
454         The test server build fixes.
455
456         * TestResultServer/model/jsonresults.py:
457         (JsonResults.merge):
458         * TestResultServer/static-dashboards/flakiness_dashboard.js:
459
460 2014-01-30  Ryosuke Niwa  <rniwa@webkit.org>
461
462         NRWT shouldn't say "Finished writing JSON files" if it failed to to so
463         https://bugs.webkit.org/show_bug.cgi?id=127966
464
465         Reviewed by Alexey Proskuryakov.
466
467         Don't say "Finished writing JSON files" if we had failed to generate the JSON file.
468         Also explicitly say this is for test results server as we're generating two JSON files.
469
470         * Scripts/webkitpy/layout_tests/controllers/manager.py:
471         (Manager._upload_json_files):
472         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
473         (JSONLayoutResultsGenerator.__init__): Don't generate JSON file implicitly inside the constructor.
474         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
475         (JSONResultsGenerator.generate_json_output): Return a boolean indicating whether the generation
476         had succeeded or not.
477
478 2014-01-30  Filip Pizlo  <fpizlo@apple.com>
479
480         copy-webkitlibraries-to-product-directory should accept command-line arguments for extra work required for optional features rather than relying on environment variables
481         https://bugs.webkit.org/show_bug.cgi?id=120221
482
483         Reviewed by Mark Hahnenberg.
484
485         * Scripts/build-jsc:
486         * Scripts/build-webkit:
487         * Scripts/copy-webkitlibraries-to-product-directory:
488
489 2014-01-30  Anders Carlsson  <andersca@apple.com>
490
491         Add a webView:didStartProvisionalNavigation: delegate method
492         https://bugs.webkit.org/show_bug.cgi?id=127965
493
494         Reviewed by Dan Bernstein.
495
496         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
497         (-[NavigationDelegate webView:didStartProvisionalNavigation:]):
498         (TEST):
499
500 2014-01-30  Chris Fleizach  <cfleizach@apple.com>
501
502         WebKitTestRunner fails to link - missing rowHeaders and columnHeaders
503         https://bugs.webkit.org/show_bug.cgi?id=127917
504
505         Reviewed by Andy Estes.
506
507         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
508         (WTR::AccessibilityUIElement::rowHeaders):
509         (WTR::AccessibilityUIElement::columnHeaders):
510
511 2014-01-30  Martin Robinson  <mrobinson@igalia.com>
512
513         [GTK] [CMake] Add a "make dist" target
514         https://bugs.webkit.org/show_bug.cgi?id=116378
515
516         Reviewed by Gustavo Noronha Silva.
517
518         Added a script that reads a manifest file an produces a tarball. Also add
519         the manifest.
520
521         * gtk/make-dist.py: Added.
522         * gtk/manifest.txt: Added.
523
524 2014-01-30  David Farler  <dfarler@apple.com>
525
526         Move OTHER_LDFLAGS erasure to DumpRenderTreeLibrary.xcconfig.
527         https://bugs.webkit.org/show_bug.cgi?id=127935
528
529         Reviewed by Andy Estes.
530
531         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
532         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig:
533         Move OTHER_LDFLAGS erasure to the static library's xcconfig.
534
535 2014-01-30  David Farler  <dfarler@apple.com>
536
537         DumpRenderTree fails to build with ASAN: -fsanitize=address passed to static DRT target
538         https://bugs.webkit.org/show_bug.cgi?id=127935
539
540         Reviewed by Andy Estes.
541
542         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
543         Clear OTHER_LDFLAGS at the project level for the static library target.
544         No other linker flags were inherited from DebugRelease.
545
546 2014-01-30  David Farler  <dfarler@apple.com>
547
548         package-root shouldn't prefix simulator roots with the SDK path
549         http://bugs.webkit.org/show_bug.cgi?id=127923
550
551         Reviewed by Dan Bernstein.
552
553         * Scripts/package-root: Don't add an install path prefix.
554
555 2014-01-30  Gabor Rapcsanyi  <rgabor@webkit.org>
556
557         Add ARM EFL Linux builder bots to Apple buildmaster
558         https://bugs.webkit.org/show_bug.cgi?id=127472
559
560         Reviewed by Csaba Osztrogonác.
561
562         There is no ARM buildslaves after removing the Qt builders.
563
564         * BuildSlaveSupport/build.webkit.org-config/config.json:
565
566 2014-01-30  Andy Estes  <aestes@apple.com>
567
568         REGRESSION (r163037): WebKit2.PageLoadBasic API test failing on Mountain Lion
569         https://bugs.webkit.org/show_bug.cgi?id=127934
570
571         Disable the failing test on Mountain Lion.
572
573         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
574         (TestWebKitAPI::TEST):
575
576 2014-01-30  Anders Carlsson  <andersca@apple.com>
577
578         Add WKNavigationDelegate class
579         https://bugs.webkit.org/show_bug.cgi?id=127927
580
581         Reviewed by Dan Bernstein.
582
583         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
584         (TEST):
585
586 2014-01-30  David Farler  <dfarler@apple.com>
587
588         Enable iOS Tools builds by default
589         https://bugs.webkit.org/show_bug.cgi?id=127919
590
591         Reviewed by Andy Estes.
592
593         * Makefile:
594         Build all the tools except MiniBrowser on iOS
595         * Scripts/build-webkit:
596         Ditto.
597         Build WebKitTestRunnerApp target on iOS.
598
599 2014-01-30  David Farler  <dfarler@apple.com>
600
601         Make TestWebKitAPI build and run for iOS
602         https://bugs.webkit.org/show_bug.cgi?id=127925
603
604         Reviewed by Andy Estes.
605
606         * TestWebKitAPI/Configurations/Base.xcconfig:
607         - Don't warn on 64-32 bit conversion on x86_64 and arm64
608         - Don't build mac/*
609         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
610         - Link WebKit2 on all platforms
611
612 2014-01-30  David Farler  <dfarler@apple.com>
613
614         package-root should copy ./usr from the build products directory
615         https://bugs.webkit.org/show_bug.cgi?id=127878
616
617         Reviewed by Daniel Bates.
618
619         * Scripts/package-root:
620         Copy ./usr in addition to the frameworks.
621
622 2014-01-30  Andrei Bucur  <abucur@adobe.com>
623
624         Remove the ACCELERATED_COMPOSITING flag
625         https://bugs.webkit.org/show_bug.cgi?id=127833
626
627         Reviewed by Antti Koivisto.
628
629         Remove the USE(ACCELERATED_COMPOSITING) conditionals from the code base and make AC
630         mandatory.
631
632         * DumpRenderTree/efl/DumpRenderTree.cpp:
633         (initEcoreEvas):
634         * EWebLauncher/main.c:
635         (windowCreate):
636         * MiniBrowser/efl/main.c:
637         (elm_main):
638         * TestWebKitAPI/efl/PlatformWebView.cpp:
639         (TestWebKitAPI::initEcoreEvas):
640         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
641         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
642         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
643         (WTR::initEcoreEvas):
644
645 2014-01-29  Csaba Osztrogonác  <ossy@webkit.org>
646
647         Remove ENABLE(JAVASCRIPT_DEBUGGER) leftovers
648         https://bugs.webkit.org/show_bug.cgi?id=127845
649
650         Reviewed by Joseph Pecoraro.
651
652         * Scripts/webkitperl/FeatureList.pm:
653
654 2014-01-29  Anders Carlsson  <andersca@apple.com>
655
656         -[WKWebView loadRequest:] should return a WKNavigation
657         https://bugs.webkit.org/show_bug.cgi?id=127873
658
659         Reviewed by Dan Bernstein.
660
661         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
662         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm: Added.
663         (TEST):
664
665 2014-01-29  Tim Horton  <timothy_horton@apple.com>
666
667         WebKit2 View Gestures (Swipe): Update rubberBandsAt{Left,Right} when WebKit swipe is enabled
668         https://bugs.webkit.org/show_bug.cgi?id=127855
669         <rdar://problem/15933878>
670
671         Reviewed by Anders Carlsson.
672
673         * MiniBrowser/mac/WK2BrowserWindowController.m:
674         (-[WK2BrowserWindowController awakeFromNib]):
675         Enable swipe in MiniBrowser for testing purposes.
676
677 2014-01-29  Daniel Bates  <dabates@apple.com>
678
679         Fix JSONP requests made by the WebKit Bot Watcher's Dashboard following <http://trac.webkit.org/changeset/163034>
680         (https://bugs.webkit.org/show_bug.cgi?id=127784)
681
682         Use dot-notation instead of array index notation to access the dictionary value for key jsonpCallbackName
683         in the specified options dictionary.
684
685         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
686         (JSON.load):
687
688 2014-01-29  Daniel Bates  <dabates@apple.com>
689
690         WebKit Bot Watcher's Dashboard: Add support for using HTTP authentication with Buildbot
691         https://bugs.webkit.org/show_bug.cgi?id=127784
692
693         Reviewed by Alexey Proskuryakov.
694
695         Implement support for querying a Buildbot that requires HTTP authentication to access it.
696
697         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
698         (Buildbot): Add optional argument, options, to pass a dictionary of Buildbot options.
699         For now, we only support a single option, needsAuthentication, to indicate whether the
700         Buildbots requires HTTP authentication (defaults to false - HTTP authentication is
701         not required).
702         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
703         (BuildbotIteration.prototype.loadLayoutTestResults): Modified to pass JSONP callback name
704         to JSON.load() using the option dictionary.
705         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
706         (BuildbotQueue.prototype.update): Modified to pass withCredentials to JSON.load().
707         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
708         (JSON.load): Removed optional argument jsonpCallbackName and added optional argument options,
709         which is a dictionary. The argument jsonpCallbackName is now specified as an entry in the
710         options dictionary. Added boolean options withCredentials to toggle querying with HTTP
711         authentication credentials.
712
713 2014-01-29  Alexey Proskuryakov  <ap@apple.com>
714
715         build.webkit.org/dashboard links to an old failing build rather than the most recent
716         https://bugs.webkit.org/show_bug.cgi?id=127765
717         <rdar://problem/15795228>
718
719         Reviewed by Timothy Hatcher.
720
721         This patch changes builder view to not show how many failures there were in a row,
722         because it is not very relevant, and complicates the UI. Instead, we just show the
723         latest failing build and the latest successful one.
724
725         The patch also removes commit history popovers from revisions that can not be correlated
726         with any change. These popovers are only helpful in the first line, when there is
727         another line for comparison below. In this case, it's useful to see what changed
728         between the revisions, but even then, only if it was an actual failure, not a buildbot
729         exception.
730
731         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
732         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
733         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
734         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
735         (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
736         (BuildbotQueueView.prototype._revisionPopoverContentForIteration):
737         (BuildbotQueueView.prototype.revisionContentForIteration):
738         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
739         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
740
741 2014-01-29  Csaba Osztrogonác  <ossy@webkit.org>
742
743         Remove ENABLE(JAVASCRIPT_DEBUGGER) guards
744         https://bugs.webkit.org/show_bug.cgi?id=127840
745
746         Reviewed by Mark Lam.
747
748         * Scripts/webkitperl/FeatureList.pm:
749
750 2014-01-29  Krzysztof Czech  <k.czech@samsung.com>
751
752         [ATK] Expose aria-describedby with ATK_RELATION_DESCRIBED_BY
753         https://bugs.webkit.org/show_bug.cgi?id=121684
754
755         Reviewed by Mario Sanchez Prada.
756
757         Implementing helpText by using relation ATK_RELATION_DESCRIBED_BY.
758
759         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
760         (AccessibilityUIElement::helpText):
761         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
762         (WTR::AccessibilityUIElement::helpText):
763
764 2014-01-27  Chris Fleizach  <cfleizach@apple.com>
765
766         AX: Support @scope in HTML tables
767         https://bugs.webkit.org/show_bug.cgi?id=127688
768
769         Reviewed by Mario Sanchez Prada.
770
771         Add support for rowHeaders and columnHeaders.
772
773         * DumpRenderTree/AccessibilityUIElement.cpp:
774         (convertElementsToObjectArray):
775         (columnHeadersCallback):
776         (rowHeadersCallback):
777         (uiElementArrayAttributeValueCallback):
778         (AccessibilityUIElement::columnHeaders):
779         (AccessibilityUIElement::rowHeaders):
780         (AccessibilityUIElement::getJSClass):
781         * DumpRenderTree/AccessibilityUIElement.h:
782         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
783         (AccessibilityUIElement::rowHeaders):
784         (AccessibilityUIElement::columnHeaders):
785         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
786         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
787         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
788         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
789         (WTR::AccessibilityUIElement::rowHeaders):
790         (WTR::AccessibilityUIElement::columnHeaders):
791         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
792         (WTR::convertElementsToObjectArray):
793         (WTR::AccessibilityUIElement::rowHeaders):
794         (WTR::AccessibilityUIElement::columnHeaders):
795         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
796
797 2014-01-28  Daniel Bates  <dabates@apple.com>
798
799         Teach Buildbot dashboard to parse alternative revision format
800         https://bugs.webkit.org/show_bug.cgi?id=127561
801
802         Reviewed by Alexey Proskuryakov.
803
804         Add support for extracting the OpenSource and Internal revision numbers when Buildbot
805         returns a dictionary for the value of property got_revision.
806
807         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
808         (isMultiCodebaseGotRevisionProperty): Added.
809         (parseRevisionProperty): Added; parses Buildbot revision property, which can either be a
810         string or a dictionary.
811         (BuildbotIteration.prototype.update.): Modified to call parseRevisionProperty() to determine
812         the OpenSource and Internal revision numbers.
813
814 2014-01-28  Adrian Perez de Castro  <aperez@igalia.com>
815
816         [GTK] Add API to allow setting the process model in WebKitWebContext
817         https://bugs.webkit.org/show_bug.cgi?id=125463
818
819         Reviewed by Carlos Garcia Campos.
820
821         Implements accessors in WebKitWebContext for the process model.
822         The default behavior is unchanged, and a single web process is
823         used. Using WEBKIT_PROCESS_MODEL_ONE_SECONDARY_PROCESS_PER_WEB_VIEW
824         as the process model will make use one web process for each
825         WebKitWebView. This also enables the network process. Setting
826         the process model must be done as early as possible, before the
827         very first web process is spawned.
828
829         * MiniBrowser/gtk/main.c:
830         (main):
831         Enable multiple process mode if the MINIBROWSER_MULTIPROCESS
832         environment variable is defined and not empty.
833         * TestWebKitAPI/GNUmakefile.am:
834         Add new TestMultiprocess test case.
835         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
836         Add new TestMultiprocess test case.
837         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp: Added.
838         (loadChanged):
839         (testMultipleSecondaryProcesses):
840         (initializeWebExtensions):
841         (beforeAll):
842         (afterAll):
843         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
844         (methodCallCallback):
845         Implement the GetProcessIdentifier D-Bus method.
846         (makeBusName):
847         Choose a different bus name when the web extension is used
848         from TestMultiprocess.
849         (webkit_web_extension_initialize_with_user_data):
850         Use makeBusName() to choose the bus name.
851
852 2014-01-28  Carlos Garcia Campos  <cgarcia@igalia.com>
853
854         [SOUP] Remove soupURIToKURL
855         https://bugs.webkit.org/show_bug.cgi?id=127104
856
857         Reviewed by Martin Robinson.
858
859         * TestWebKitAPI/GNUmakefile.am: Add soup cppflags to WebCore unit
860         tests, because URL.h now includes GUniquePtrSoup.h.
861         * TestWebKitAPI/CMakeLists.txt: Ditto.
862         * WebKitTestRunner/PlatformEfl.cmake: Add soup cppflags to WTR,
863         because URL.h now includes GUniquePtrSoup.h.
864
865 2014-01-27  Carlos Garcia Campos  <cgarcia@igalia.com>
866
867         [GTK] Make webkit_uri_scheme_request_get_web_view() work with CustomProtocols
868         https://bugs.webkit.org/show_bug.cgi?id=127614
869
870         Reviewed by Gustavo Noronha Silva.
871
872         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: Bring
873         back the custom URI scheme WebView check.
874
875 2014-01-27  Tim Horton  <timothy_horton@apple.com>
876
877         Revert yet one more tiny part of r162629 that didn't get reverted in r162883
878
879         * WebKitTestRunner/TestController.cpp:
880         (WTR::TestController::pluginLoadPolicy):
881         * WebKitTestRunner/TestController.h:
882
883 2014-01-27  Tim Horton  <timothy_horton@apple.com>
884
885         Revert one more tiny part of r162629 that didn't get reverted in r162883.
886
887         ... which was also causing test failures!
888
889         * WebKitTestRunner/TestController.cpp:
890         (WTR::TestController::createWebViewWithOptions):
891
892 2014-01-27  David Farler  <dfarler@apple.com>
893
894         iOS DumpRenderTree.app dies loading fonts
895         https://bugs.webkit.org/show_bug.cgi?id=127730
896
897         Reviewed by Daniel Bates.
898
899         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
900         - Add Ahem to the __DATA section
901         * DumpRenderTree/mac/DumpRenderTree.mm:
902         (activateFontsIOS):
903         - Load "WeightWatcher100" instead.
904
905 2014-01-27  Alexey Proskuryakov  <ap@apple.com>
906
907         [Mac] Extra logging output from run-safari --no-saved-state
908         https://bugs.webkit.org/show_bug.cgi?id=127732
909
910         Reviewed by Daniel Bates.
911
912         * Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp): Use an option that
913         disables saved state without logging.
914
915 2014-01-27  Tim Horton  <timothy_horton@apple.com>
916
917         Revert the parts of r162629 that add a new pluginLoadPolicy and the context menu item.
918
919         We're leaving the parts that make us use PDFPlugin instead of showing the blocked
920         plugin indicator intact, though.
921
922         * WebKitTestRunner/TestController.cpp:
923         (WTR::TestController::createWebViewWithOptions):
924
925 2014-01-27  Andy Estes  <aestes@apple.com>
926
927         Scrub WebKit API headers of WTF macros
928         https://bugs.webkit.org/show_bug.cgi?id=127706
929
930         Reviewed by David Kilzer.
931
932         * Scripts/check-for-inappropriate-macros-in-external-headers: Modified
933         the regex to require a '(' after the macro name in order to be
934         considered a match. This prevents things like 'ENABLE_SOME_FEATURE'
935         from being flagged as an ENABLE() macro.
936
937 2014-01-27  Commit Queue  <commit-queue@webkit.org>
938
939         Unreviewed, rolling out r162846.
940         http://trac.webkit.org/changeset/162846
941         https://bugs.webkit.org/show_bug.cgi?id=127695
942
943         "Broke the WebKit Bot Watcher's Dashboard; will fix offline"
944         (Requested by dydz on #webkit).
945
946         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
947         (BuildbotIteration.prototype.update.):
948
949 2014-01-27  Daniel Bates  <dabates@apple.com>
950
951         Add support for displaying results from multiple Buildbots on WebKit Bot Watcher's Dashboard
952         https://bugs.webkit.org/show_bug.cgi?id=127564
953
954         Reviewed by Alexey Proskuryakov.
955
956         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
957         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
958
959 2014-01-27  Daniel Bates  <dabates@apple.com>
960
961         Teach Buildbot dashboard to parse alternative revision format
962         https://bugs.webkit.org/show_bug.cgi?id=127561
963
964         Reviewed by Alexey Proskuryakov.
965
966         Add support for extracting the OpenSource and Internal revision numbers when Buildbot
967         returns a dictionary for the value of property got_revision.
968
969         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
970         (parseRevisionProperty): Added; parses Buildbot revision property, which can either be a
971         string or a dictionary.
972         (BuildbotIteration.prototype.update.): Modified to call parseRevisionProperty() to determine
973         the OpenSource and Internal revision numbers.
974
975 2014-01-27  Carlos Garcia Campos  <cgarcia@igalia.com>
976
977         [GTK] Implement custom URI schemes with CustomProtocols
978         https://bugs.webkit.org/show_bug.cgi?id=127091
979
980         Reviewed by Gustavo Noronha Silva.
981
982         Temporarily disable the WebKitWebView check until we figure out
983         how to implement it with CustomProtocols.
984
985         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
986
987 2014-01-26  Alexey Proskuryakov  <ap@apple.com>
988
989         REGRESSION(r127412): http/tests/misc/link-rel-icon-beforeload.html is broken.
990
991         * DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::setIconDatabaseEnabled):
992         Fixed an incorrect ifdef.
993
994 2014-01-26  Brendan Long  <b.long@cablelabs.com>
995
996         [GTK] DumpRenderTree prints out suggesting to set WEBKIT_TOP_LEVEL when fonts are missing but doesn't use it.
997         https://bugs.webkit.org/show_bug.cgi?id=110602
998
999         Reviewed by Philippe Normand.
1000
1001         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1002         (getTopLevelPath): Use WEBKIT_TOP_LEVEL environment variable if it exists.
1003         (initializeFonts): Fix printing of expected font path (fontPath is guaranteed to be null here).
1004
1005 2014-01-24  Andy Estes  <aestes@apple.com>
1006
1007         [iOS] Upstream changes in Tools/DumpRenderTree
1008         https://bugs.webkit.org/show_bug.cgi?id=127412
1009
1010         Reviewed by Simon Fraser.
1011
1012         Upstream all iOS changes. Added a new target called DumpRenderTree.app,
1013         which builds the DumpRenderTree static library into an app bundle as
1014         expected by the iOS Simulator.
1015
1016         * DumpRenderTree/AccessibilityTextMarker.h:
1017         * DumpRenderTree/AccessibilityUIElement.h:
1018         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1019         * DumpRenderTree/DumpRenderTreeFileDraggingSource.h:
1020         * DumpRenderTree/DumpRenderTreePrefix.h:
1021         * DumpRenderTree/PixelDumpSupport.cpp:
1022         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1023         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
1024         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
1025         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1026         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1027         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
1028         * DumpRenderTree/TestNetscapePlugIn/TestObject.h:
1029         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp:
1030         * DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSAfterRemovingPluginElement.cpp:
1031         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
1032         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp:
1033         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:
1034         * DumpRenderTree/TestNetscapePlugIn/Tests/NullNPPGetValuePointer.cpp:
1035         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
1036         * DumpRenderTree/TestNetscapePlugIn/Tests/PluginScriptableNPObjectInvokeDefault.cpp:
1037         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1038         * DumpRenderTree/TestRunner.cpp:
1039         * DumpRenderTree/TestRunner.h:
1040         * DumpRenderTree/cg/ImageDiffCG.cpp:
1041         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1042         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
1043         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1044         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h: Added.
1045         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm: Added.
1046         * DumpRenderTree/ios/Info.plist: Added.
1047         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport.c: Added.
1048         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Added.
1049         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Added.
1050         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Changes: Added.
1051         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/IPhoneSimulatorNotification.xs: Added.
1052         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/MANIFEST: Added.
1053         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL: Added.
1054         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/README: Added.
1055         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm: Added.
1056         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/ppport.h: Added.
1057         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/t/IPhoneSimulatorNotification.t: Added.
1058         * DumpRenderTree/ios/PerlSupport/Makefile: Added.
1059         * DumpRenderTree/ios/PixelDumpSupportIOS.mm: Added.
1060         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
1061         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
1062         * DumpRenderTree/mac/AppleScriptController.m:
1063         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1064         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1065         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1066         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Added.
1067         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig:
1068         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
1069         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig: Added.
1070         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
1071         * DumpRenderTree/mac/DumpRenderTree.mm:
1072         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
1073         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1074         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1075         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
1076         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
1077         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1078         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1079         * DumpRenderTree/mac/EditingDelegate.h:
1080         * DumpRenderTree/mac/EventSendingController.h:
1081         * DumpRenderTree/mac/EventSendingController.mm:
1082         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1083         * DumpRenderTree/mac/HistoryDelegate.h:
1084         * DumpRenderTree/mac/LayoutTestHelper.m:
1085         * DumpRenderTree/mac/MockGeolocationProvider.mm:
1086         * DumpRenderTree/mac/NavigationController.h:
1087         * DumpRenderTree/mac/ObjCPlugin.h:
1088         * DumpRenderTree/mac/ObjCPlugin.m:
1089         * DumpRenderTree/mac/ObjCPluginFunction.h:
1090         * DumpRenderTree/mac/PolicyDelegate.h:
1091         * DumpRenderTree/mac/ResourceLoadDelegate.h:
1092         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1093         * DumpRenderTree/mac/TestRunnerMac.mm:
1094         * DumpRenderTree/mac/TextInputController.h:
1095         * DumpRenderTree/mac/TextInputController.m:
1096         * DumpRenderTree/mac/UIDelegate.h:
1097         * DumpRenderTree/mac/UIDelegate.mm:
1098
1099 2014-01-25  Darin Adler  <darin@apple.com>
1100
1101         Call deprecatedCharacters instead of characters at more call sites
1102         https://bugs.webkit.org/show_bug.cgi?id=127631
1103
1104         Reviewed by Sam Weinig.
1105
1106         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1107         (TestWebKitAPI::expectBuilderContent):
1108         (TestWebKitAPI::expectEmpty):
1109         (TestWebKitAPI::TEST):
1110         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1111         (TestWebKitAPI::TEST):
1112         Use the new name.
1113
1114 2014-01-25  Anders Carlsson  <andersca@apple.com>
1115
1116         Modernize HashTable threading code
1117         https://bugs.webkit.org/show_bug.cgi?id=127621
1118
1119         Reviewed by Darin Adler.
1120
1121         Explicitly include headers that used to be brought in by HashTable.h
1122
1123         * DumpRenderTree/JavaScriptThreading.cpp:
1124
1125 2014-01-24  Eric Carlson  <eric.carlson@apple.com>
1126
1127         Unreviewed. Add Philip Jägenstedt to watch and contributor lists.
1128
1129         * Scripts/webkitpy/common/config/contributors.json:
1130         * Scripts/webkitpy/common/config/watchlist:
1131
1132 2014-01-23  David Farler  <dfarler@apple.com>
1133
1134         Make WebKitTestRunner work with iOS
1135         https://bugs.webkit.org/show_bug.cgi?id=127448
1136
1137         Reviewed by Simon Fraser.
1138
1139         Combined patch from Simon below with some additional xcconfig cleanups,
1140         rebasing and stubbing out a couple of new functions that popped up
1141         since then.
1142
1143         2013-12-03  Simon Fraser  <simon.fraser@apple.com>
1144
1145                 <rdar://problem/15515469> Get WebKitTestRunner working on iOS
1146
1147                 Get WebKitTestRunner limping on iOS. Main parts:
1148                 - Stub out lots of accessibility-related functions.
1149                 - Stub out EventSender
1150                 - Create target to make a bundled app that runs in the simulator,
1151                   and copy the injected bundle library into it.
1152                 - Make a UIWindow and WKView to load tests in
1153
1154                 It runs, load tests, and dumps results to output. More work will be
1155                 required once we can execute it via the webkitpy scripts.
1156
1157         * WebKitTestRunner/Configurations/Base.xcconfig:
1158         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1159         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
1160         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1161         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm: Added.
1162         (WTR::AccessibilityController::addNotificationListener):
1163         (WTR::AccessibilityController::removeNotificationListener):
1164         (WTR::AccessibilityController::platformName):
1165         (WTR::AccessibilityController::logAccessibilityEvents):
1166         (WTR::AccessibilityController::resetToConsistentState):
1167         (WTR::findAccessibleObjectById):
1168         (WTR::AccessibilityController::accessibleElementById):
1169         * WebKitTestRunner/InjectedBundle/ios/AccessibilityNotificationHandler.h: Added.
1170         * WebKitTestRunner/InjectedBundle/ios/AccessibilityTextMarkerIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
1171         (WTR::AccessibilityTextMarker::isEqual):
1172         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm: Added.
1173         (WTR::AccessibilityUIElement::AccessibilityUIElement):
1174         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
1175         (WTR::AccessibilityUIElement::isEqual):
1176         (WTR::AccessibilityUIElement::getLinkedUIElements):
1177         (WTR::AccessibilityUIElement::getDocumentLinks):
1178         (WTR::AccessibilityUIElement::getChildren):
1179         (WTR::AccessibilityUIElement::getChildrenWithRange):
1180         (WTR::AccessibilityUIElement::childrenCount):
1181         (WTR::AccessibilityUIElement::elementAtPoint):
1182         (WTR::AccessibilityUIElement::indexOfChild):
1183         (WTR::AccessibilityUIElement::childAtIndex):
1184         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
1185         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
1186         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
1187         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
1188         (WTR::AccessibilityUIElement::rowAtIndex):
1189         (WTR::AccessibilityUIElement::selectedChildAtIndex):
1190         (WTR::AccessibilityUIElement::selectedChildrenCount):
1191         (WTR::AccessibilityUIElement::selectedRowAtIndex):
1192         (WTR::AccessibilityUIElement::titleUIElement):
1193         (WTR::AccessibilityUIElement::parentElement):
1194         (WTR::AccessibilityUIElement::disclosedByRow):
1195         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
1196         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
1197         (WTR::AccessibilityUIElement::attributesOfChildren):
1198         (WTR::AccessibilityUIElement::allAttributes):
1199         (WTR::AccessibilityUIElement::stringAttributeValue):
1200         (WTR::AccessibilityUIElement::numberAttributeValue):
1201         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
1202         (WTR::AccessibilityUIElement::uiElementAttributeValue):
1203         (WTR::AccessibilityUIElement::boolAttributeValue):
1204         (WTR::AccessibilityUIElement::isAttributeSettable):
1205         (WTR::AccessibilityUIElement::isAttributeSupported):
1206         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
1207         (WTR::AccessibilityUIElement::role):
1208         (WTR::AccessibilityUIElement::subrole):
1209         (WTR::AccessibilityUIElement::roleDescription):
1210         (WTR::AccessibilityUIElement::title):
1211         (WTR::AccessibilityUIElement::description):
1212         (WTR::AccessibilityUIElement::orientation):
1213         (WTR::AccessibilityUIElement::stringValue):
1214         (WTR::AccessibilityUIElement::language):
1215         (WTR::AccessibilityUIElement::helpText):
1216         (WTR::AccessibilityUIElement::x):
1217         (WTR::AccessibilityUIElement::y):
1218         (WTR::AccessibilityUIElement::width):
1219         (WTR::AccessibilityUIElement::height):
1220         (WTR::AccessibilityUIElement::clickPointX):
1221         (WTR::AccessibilityUIElement::clickPointY):
1222         (WTR::AccessibilityUIElement::intValue):
1223         (WTR::AccessibilityUIElement::minValue):
1224         (WTR::AccessibilityUIElement::maxValue):
1225         (WTR::AccessibilityUIElement::valueDescription):
1226         (WTR::AccessibilityUIElement::insertionPointLineNumber):
1227         (WTR::AccessibilityUIElement::isPressActionSupported):
1228         (WTR::AccessibilityUIElement::isIncrementActionSupported):
1229         (WTR::AccessibilityUIElement::isDecrementActionSupported):
1230         (WTR::AccessibilityUIElement::isEnabled):
1231         (WTR::AccessibilityUIElement::isRequired):
1232         (WTR::AccessibilityUIElement::isFocused):
1233         (WTR::AccessibilityUIElement::isSelected):
1234         (WTR::AccessibilityUIElement::isSelectedOptionActive):
1235         (WTR::AccessibilityUIElement::isIndeterminate):
1236         (WTR::AccessibilityUIElement::isExpanded):
1237         (WTR::AccessibilityUIElement::isChecked):
1238         (WTR::AccessibilityUIElement::hierarchicalLevel):
1239         (WTR::AccessibilityUIElement::classList):
1240         (WTR::AccessibilityUIElement::speak):
1241         (WTR::AccessibilityUIElement::ariaIsGrabbed):
1242         (WTR::AccessibilityUIElement::ariaDropEffects):
1243         (WTR::AccessibilityUIElement::lineForIndex):
1244         (WTR::AccessibilityUIElement::rangeForLine):
1245         (WTR::AccessibilityUIElement::rangeForPosition):
1246         (WTR::AccessibilityUIElement::boundsForRange):
1247         (WTR::AccessibilityUIElement::stringForRange):
1248         (WTR::AccessibilityUIElement::attributedStringForRange):
1249         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
1250         (WTR::uiElementCountForSearchPredicate):
1251         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
1252         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1253         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
1254         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
1255         (WTR::AccessibilityUIElement::attributesOfColumns):
1256         (WTR::AccessibilityUIElement::attributesOfRows):
1257         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
1258         (WTR::AccessibilityUIElement::attributesOfHeader):
1259         (WTR::AccessibilityUIElement::rowCount):
1260         (WTR::AccessibilityUIElement::columnCount):
1261         (WTR::AccessibilityUIElement::indexInTable):
1262         (WTR::AccessibilityUIElement::rowIndexRange):
1263         (WTR::AccessibilityUIElement::columnIndexRange):
1264         (WTR::AccessibilityUIElement::cellForColumnAndRow):
1265         (WTR::AccessibilityUIElement::horizontalScrollbar):
1266         (WTR::AccessibilityUIElement::verticalScrollbar):
1267         (WTR::AccessibilityUIElement::scrollToMakeVisible):
1268         (WTR::AccessibilityUIElement::selectedTextRange):
1269         (WTR::AccessibilityUIElement::setSelectedTextRange):
1270         (WTR::AccessibilityUIElement::increment):
1271         (WTR::AccessibilityUIElement::decrement):
1272         (WTR::AccessibilityUIElement::showMenu):
1273         (WTR::AccessibilityUIElement::press):
1274         (WTR::AccessibilityUIElement::setSelectedChild):
1275         (WTR::AccessibilityUIElement::accessibilityValue):
1276         (WTR::AccessibilityUIElement::documentEncoding):
1277         (WTR::AccessibilityUIElement::documentURI):
1278         (WTR::AccessibilityUIElement::url):
1279         (WTR::AccessibilityUIElement::addNotificationListener):
1280         (WTR::AccessibilityUIElement::removeNotificationListener):
1281         (WTR::AccessibilityUIElement::isFocusable):
1282         (WTR::AccessibilityUIElement::isSelectable):
1283         (WTR::AccessibilityUIElement::isMultiSelectable):
1284         (WTR::AccessibilityUIElement::isVisible):
1285         (WTR::AccessibilityUIElement::isOffScreen):
1286         (WTR::AccessibilityUIElement::isCollapsed):
1287         (WTR::AccessibilityUIElement::isIgnored):
1288         (WTR::AccessibilityUIElement::hasPopup):
1289         (WTR::AccessibilityUIElement::takeFocus):
1290         (WTR::AccessibilityUIElement::takeSelection):
1291         (WTR::AccessibilityUIElement::addSelection):
1292         (WTR::AccessibilityUIElement::removeSelection):
1293         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
1294         (WTR::AccessibilityUIElement::textMarkerRangeLength):
1295         (WTR::AccessibilityUIElement::previousTextMarker):
1296         (WTR::AccessibilityUIElement::nextTextMarker):
1297         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
1298         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
1299         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
1300         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
1301         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
1302         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
1303         (WTR::AccessibilityUIElement::textMarkerForPoint):
1304         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
1305         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
1306         (WTR::AccessibilityUIElement::indexForTextMarker):
1307         (WTR::AccessibilityUIElement::isTextMarkerValid):
1308         (WTR::AccessibilityUIElement::textMarkerForIndex):
1309         (WTR::AccessibilityUIElement::startTextMarker):
1310         (WTR::AccessibilityUIElement::endTextMarker):
1311         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
1312         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
1313         (WTR::AccessibilityUIElement::pathDescription):
1314         (WTR::AccessibilityUIElement::supportedActions):
1315         * WebKitTestRunner/InjectedBundle/ios/ActivateFontsIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
1316         (WTR::activateFonts):
1317         * WebKitTestRunner/InjectedBundle/ios/EventSenderProxyIOS.mm: Added.
1318         (WTR::EventSenderProxy::EventSenderProxy):
1319         (WTR::EventSenderProxy::~EventSenderProxy):
1320         (WTR::EventSenderProxy::updateClickCountForButton):
1321         (WTR::EventSenderProxy::mouseDown):
1322         (WTR::EventSenderProxy::mouseUp):
1323         (WTR::EventSenderProxy::mouseMoveTo):
1324         (WTR::EventSenderProxy::leapForward):
1325         (WTR::EventSenderProxy::keyDown):
1326         (WTR::EventSenderProxy::mouseScrollBy):
1327         (WTR::EventSenderProxy::continuousMouseScrollBy):
1328         (WTR::EventSenderProxy::addTouchPoint):
1329         (WTR::EventSenderProxy::updateTouchPoint):
1330         (WTR::EventSenderProxy::setTouchModifier):
1331         (WTR::EventSenderProxy::setTouchPointRadius):
1332         (WTR::EventSenderProxy::touchStart):
1333         (WTR::EventSenderProxy::touchMove):
1334         (WTR::EventSenderProxy::touchEnd):
1335         (WTR::EventSenderProxy::touchCancel):
1336         (WTR::EventSenderProxy::clearTouchPoints):
1337         (WTR::EventSenderProxy::releaseTouchPoint):
1338         (WTR::EventSenderProxy::cancelTouchPoint):
1339         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
1340         (WTR::InjectedBundle::platformInitialize):
1341         * WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
1342         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
1343         * WebKitTestRunner/Makefile:
1344         * WebKitTestRunner/TestController.cpp:
1345         (WTR::TestController::initialize):
1346         * WebKitTestRunner/TestController.h:
1347         * WebKitTestRunner/TestInvocation.cpp:
1348         (WTR::TestInvocation::invoke):
1349         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1350         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1351         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Added.
1352         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Added.
1353         (-[AppDelegate application:didFinishLaunchingWithOptions:]):
1354         (-[AppDelegate applicationWillResignActive:]):
1355         (-[AppDelegate applicationDidEnterBackground:]):
1356         (-[AppDelegate applicationWillEnterForeground:]):
1357         (-[AppDelegate applicationDidBecomeActive:]):
1358         (-[AppDelegate applicationWillTerminate:]):
1359         * WebKitTestRunner/WebKitTestRunnerApp/Images.xcassets/AppIcon.appiconset/Contents.json: Added.
1360         * WebKitTestRunner/WebKitTestRunnerApp/Images.xcassets/LaunchImage.launchimage/Contents.json: Added.
1361         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist: Added.
1362         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Prefix.pch: Added.
1363         * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Added.
1364         * WebKitTestRunner/WebKitTestRunnerApp/main.m: Added.
1365         (main):
1366         * WebKitTestRunner/WebKitTestRunnerAppTests-Info.plist: Added.
1367         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests-Info.plist: Added.
1368         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests.m: Added.
1369         (-[WebKitTestRunnerAppTests setUp]):
1370         (-[WebKitTestRunnerAppTests tearDown]):
1371         (-[WebKitTestRunnerAppTests testExample]):
1372         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj/InfoPlist.strings: Added.
1373         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1374         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1375         * WebKitTestRunner/iOS.xcconfig: Added.
1376         * WebKitTestRunner/ios/PlatformWebViewIOS.mm: Added.
1377         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useTiledDrawing:]):
1378         (-[TestRunnerWKView _shouldUseTiledDrawingArea]):
1379         (-[WebKitTestRunnerWindow isKeyWindow]):
1380         (-[WebKitTestRunnerWindow setFrameOrigin:]):
1381         (-[WebKitTestRunnerWindow setFrame:]):
1382         (-[WebKitTestRunnerWindow frameRespectingFakeOrigin]):
1383         (-[WebKitTestRunnerWindow backingScaleFactor]):
1384         (WTR::PlatformWebView::PlatformWebView):
1385         (WTR::PlatformWebView::resizeTo):
1386         (WTR::PlatformWebView::~PlatformWebView):
1387         (WTR::PlatformWebView::page):
1388         (WTR::PlatformWebView::focus):
1389         (WTR::PlatformWebView::windowFrame):
1390         (WTR::PlatformWebView::setWindowFrame):
1391         (WTR::PlatformWebView::didInitializeClients):
1392         (WTR::PlatformWebView::addChromeInputField):
1393         (WTR::PlatformWebView::removeChromeInputField):
1394         (WTR::PlatformWebView::makeWebViewFirstResponder):
1395         (WTR::PlatformWebView::windowSnapshotImage):
1396         (WTR::PlatformWebView::viewSupportsOptions):
1397         * WebKitTestRunner/ios/TestControllerIOS.mm: Added.
1398         (WTR::TestController::notifyDone):
1399         (WTR::TestController::platformInitialize):
1400         (WTR::TestController::platformDestroy):
1401         (WTR::TestController::initializeInjectedBundlePath):
1402         (WTR::TestController::initializeTestPluginDirectory):
1403         (WTR::TestController::platformRunUntil):
1404         (WTR::TestController::platformInitializeContext):
1405         (WTR::TestController::runModal):
1406         (WTR::TestController::platformLibraryPathForTesting):
1407         * WebKitTestRunner/ios/WebArchiveDumpSupportIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
1408         (createCFURLResponseFromResponseData):
1409         (supportedNonImageMIMETypes):
1410         * WebKitTestRunner/ios/mainIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
1411         (-[WebKitTestRunnerApp _runTestController]):
1412         (-[WebKitTestRunnerApp applicationDidFinishLaunching:]):
1413         (main):
1414
1415 2014-01-24  Enrique Ocaña González  <eocanha@igalia.com>
1416
1417         [GTK] Put cache files in XDG_CACHE_HOME
1418         https://bugs.webkit.org/show_bug.cgi?id=123458
1419
1420         Reviewed by Martin Robinson.
1421
1422         * GtkLauncher/main.c:
1423         (createBrowser):
1424
1425 2014-01-23  Max Vujovic  <mvujovic@adobe.com>
1426
1427         Remove CSS Custom Filters code and tests
1428         https://bugs.webkit.org/show_bug.cgi?id=127382
1429
1430         Reviewed by Simon Fraser.
1431
1432         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1433         (resetDefaultsToConsistentValues):
1434         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1435         (TestRunner::overridePreference):
1436
1437 2014-01-23  Tim Horton  <timothy_horton@apple.com>
1438
1439         PDFPlugin: Use PDFPlugin even if there's an external plugin installed, if it's blocked
1440         https://bugs.webkit.org/show_bug.cgi?id=127415
1441         <rdar://problem/12482452>
1442
1443         Reviewed by Sam Weinig.
1444
1445         Adopt the new page loader client plugin load callback.
1446
1447         * WebKitTestRunner/TestController.cpp:
1448         (WTR::TestController::createWebViewWithOptions):
1449         (WTR::TestController::pluginLoadPolicy):
1450         * WebKitTestRunner/TestController.h:
1451
1452 2014-01-23  peavo@outlook.com  <peavo@outlook.com>
1453
1454         [Curl] There is no way to specify cache folder.
1455         https://bugs.webkit.org/show_bug.cgi?id=125028
1456
1457         Reviewed by Brent Fulgham.
1458
1459         Enable disc cache in WinLauncher by setting cache folder location.
1460
1461         * WinLauncher/WinLauncher.cpp:
1462         (getAppDataFolder): Added function to get app data folder.
1463         (setCacheFolder): Added function to set cache folder.
1464         (createCrashReport): Use new getAppDataFolder function.
1465         (wWinMain): Use function setCacheFolder to set cache folder location.
1466
1467 2014-01-23  Daniel Bates  <dabates@apple.com>
1468
1469         build-webkit --sdk=iphonesimulator doesn't think it's building iOS
1470         https://bugs.webkit.org/show_bug.cgi?id=127379
1471
1472         Reviewed by Simon Fraser.
1473
1474         Teach build-webkit to recognize --sdk=X.
1475
1476         Currently, build-webkit recognizes --sdk X to specify X as the Xcode SDK to use, which is also
1477         considered when determining the WebKit port to build. But build-webkit advertises --sdk=X in its
1478         help message. We should teach build-webkit to recognize both --sdk X and --sdk=X to make its handling
1479         of --sdk more consistent with the handling of other build-webkit options that take a value (e.g. --prefix).
1480
1481         * Scripts/webkitdirs.pm:
1482         (checkForArgumentAndRemoveFromArrayRefGettingValue): Added.
1483         (checkForArgumentAndRemoveFromARGVGettingValue): Modified to call checkForArgumentAndRemoveFromArrayRefGettingValue().
1484         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl: Added.
1485
1486 2014-01-23  Commit Queue  <commit-queue@webkit.org>
1487
1488         Unreviewed, rolling out r162612.
1489         http://trac.webkit.org/changeset/162612
1490         https://bugs.webkit.org/show_bug.cgi?id=127488
1491
1492         broke the build (Requested by mhahnenberg on #webkit).
1493
1494         * Scripts/build-jsc:
1495         * jsc-cli/jsc-cli.xcodeproj/project.pbxproj: Removed.
1496         * jsc-cli/jsc-cli/CLIInstance.h: Removed.
1497         * jsc-cli/jsc-cli/CLIInstance.m: Removed.
1498         * jsc-cli/jsc-cli/JSModule.h: Removed.
1499         * jsc-cli/jsc-cli/JSModule.m: Removed.
1500         * jsc-cli/jsc-cli/JSRunLoopThread.h: Removed.
1501         * jsc-cli/jsc-cli/JSRunLoopThread.m: Removed.
1502         * jsc-cli/jsc-cli/ReadEvalPrintLoop.h: Removed.
1503         * jsc-cli/jsc-cli/ReadEvalPrintLoop.m: Removed.
1504         * jsc-cli/jsc-cli/RunLoopThread.h: Removed.
1505         * jsc-cli/jsc-cli/RunLoopThread.m: Removed.
1506         * jsc-cli/jsc-cli/ScriptInputSource.h: Removed.
1507         * jsc-cli/jsc-cli/ScriptInputSource.m: Removed.
1508         * jsc-cli/jsc-cli/main.m: Removed.
1509
1510 2014-01-23  Mark Hahnenberg  <mhahnenberg@apple.com>
1511
1512         Basic framework for a modern jsc CLI
1513         https://bugs.webkit.org/show_bug.cgi?id=127435
1514
1515         Reviewed by Geoffrey Garen.
1516
1517         The most basic components of a modern jsc command line interface consist of the following:
1518
1519         - A simple REPL to enter commands and receive results
1520         - The ability to define a module (which consists of various internal methods as well as a 
1521           set of externally visible methods)
1522         - The ability to load other modules at runtime
1523         - The ability to interact with the underlying platform to perform various "privileged" 
1524           functions (e.g. opening files, printing to the stdout, etc.)
1525         
1526         The basic architecture will look something like the following:
1527         - If the tool is run in REPL mode (i.e. no command line arguments), it will start the REPL 
1528           on the main thread and start a secondary thread with a run loop to handle various inputs 
1529           from the REPL thread.
1530         - If the tool is given a script to run, it will evaluate that script (and any scripts that 
1531           it might transitively load) within the run loop on the secondary thread while the main 
1532           thread blocks until it has completed.
1533
1534         * Scripts/build-jsc:
1535         * jsc-cli: Added.
1536         * jsc-cli/jsc-cli: Added.
1537         * jsc-cli/jsc-cli.xcodeproj: Added.
1538         * jsc-cli/jsc-cli.xcodeproj/project.pbxproj: Added.
1539         * jsc-cli/jsc-cli/CLIInstance.h: Added.
1540         * jsc-cli/jsc-cli/CLIInstance.m: Added.
1541         (-[CLIInstance init]):
1542         (-[CLIInstance loadFile:]):
1543         (-[CLIInstance run]):
1544         * jsc-cli/jsc-cli/JSModule.h: Added.
1545         * jsc-cli/jsc-cli/JSModule.m: Added.
1546         (coreModules):
1547         (isCoreModule):
1548         (classForModule):
1549         (coreModuleFullPath):
1550         (resolveModuleAsFile):
1551         (resolveModuleAsDirectory):
1552         (nodeModulePaths):
1553         (resolveAsNodeModule):
1554         (+[JSModule resolve:atPath:]):
1555         (globalModuleCache):
1556         (isCached):
1557         (cachedModule):
1558         (cacheModule):
1559         (+[JSModule require:atPath:]):
1560         (+[JSModule require:atPath:inContext:]):
1561         (-[JSModule platformObjectInContext:]):
1562         (-[JSModule initWithId:filename:context:]):
1563         (-[JSModule dealloc]):
1564         (-[JSModule didStartLoading]):
1565         (-[JSModule didFinishLoading]):
1566         (-[JSModule require:]):
1567         (-[JSModule exports]):
1568         * jsc-cli/jsc-cli/JSRunLoopThread.h: Added.
1569         * jsc-cli/jsc-cli/JSRunLoopThread.m: Added.
1570         (jsThreadMain):
1571         (+[JSRunLoopThread threadMain]):
1572         (-[JSRunLoopThread initWithFiles:andContext:]):
1573         (-[JSRunLoopThread startRunLoop]):
1574         (-[JSRunLoopThread start]):
1575         (-[JSRunLoopThread join]):
1576         (-[JSRunLoopThread didReceiveInput:]):
1577         (-[JSRunLoopThread performCallback:withError:]):
1578         (-[JSRunLoopThread performCallback:withArguments:]):
1579         (-[JSRunLoopThread didFinishRunLoopInitialization]):
1580         * jsc-cli/jsc-cli/ReadEvalPrintLoop.h: Added.
1581         * jsc-cli/jsc-cli/ReadEvalPrintLoop.m: Added.
1582         (-[ReadEvalPrintLoop initWithJSThread:]):
1583         (prompt):
1584         (escapeStringForOutput):
1585         (-[ReadEvalPrintLoop processNextInput]):
1586         (-[ReadEvalPrintLoop run]):
1587         * jsc-cli/jsc-cli/RunLoopThread.h: Added.
1588         * jsc-cli/jsc-cli/RunLoopThread.m: Added.
1589         (+[RunLoopThread threadMain]):
1590         (-[RunLoopThread init]):
1591         (-[RunLoopThread dealloc]):
1592         (-[RunLoopThread didFinishRunLoopInitialization]):
1593         (-[RunLoopThread start]):
1594         (-[RunLoopThread join]):
1595         * jsc-cli/jsc-cli/ScriptInputSource.h: Added.
1596         * jsc-cli/jsc-cli/ScriptInputSource.m: Added.
1597         (scriptInputSourceScheduleRoutine):
1598         (scriptInputSourcePerformRoutine):
1599         (scriptInputSourceCancelRoutine):
1600         (-[ScriptInputSource initWithContext:]):
1601         (-[ScriptInputSource dealloc]):
1602         (-[ScriptInputSource addToCurrentRunLoop]):
1603         (-[ScriptInputSource removeFromRemoteRunLoop]):
1604         (-[ScriptInputSource didReceiveScript:]):
1605         (-[ScriptInputSource didReceiveSignal]):
1606         (-[ScriptInputSource runScriptRemotely:]):
1607         (-[ScriptInputSource finishAsyncCallback:withResult:]):
1608         * jsc-cli/jsc-cli/main.m: Added.
1609         (main):
1610
1611 2014-01-23  László Langó  <llango.u-szeged@partner.samsung.com>
1612
1613         Remove a FIXME comment that is already fixed.
1614         https://bugs.webkit.org/show_bug.cgi?id=127468
1615
1616         Reviewed by Csaba Osztrogonác.
1617
1618         * Scripts/webkitpy/style/filereader.py:
1619         (TextFileReader.__init__):
1620
1621 2014-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1622
1623         [GLIB] Use GUniquePtr instead of GOwnPtr
1624         https://bugs.webkit.org/show_bug.cgi?id=127431
1625
1626         Reviewed by Martin Robinson.
1627
1628         GUniquePtr is a template alias of std::unique_ptr with a custom
1629         deleter that replaces GOwnPtr. GOwnPtr is still used for the cases
1630         where the output pointer is needed, but it will also be replaced soon.
1631
1632         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
1633         (printAccessibilityEvent):
1634         (axObjectEventListener):
1635         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1636         (indexRangeInTable):
1637         (AccessibilityUIElement::role):
1638         (AccessibilityUIElement::title):
1639         (AccessibilityUIElement::description):
1640         (AccessibilityUIElement::stringValue):
1641         (AccessibilityUIElement::language):
1642         (AccessibilityUIElement::lineForIndex):
1643         (AccessibilityUIElement::selectedTextRange):
1644         (AccessibilityUIElement::url):
1645         * DumpRenderTree/efl/AccessibilityControllerEfl.cpp:
1646         (AccessibilityController::accessibleElementById):
1647         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1648         (AccessibilityController::accessibleElementById):
1649         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1650         (getOutputDir):
1651         (getFontsPath):
1652         (initializeFonts):
1653         (dumpFramesAsText):
1654         (compareHistoryItems):
1655         (dumpHistoryItem):
1656         (soupURIToStringPreservingPassword):
1657         (resetDefaultsToConsistentValues):
1658         (temporaryDatabaseDirectory):
1659         (webViewTitleChanged):
1660         (webFrameLoadStatusNotified):
1661         (pathFromSoupURI):
1662         (convertWebResourceToURLPath):
1663         (urlSuitableForTestResult):
1664         (descriptionSuitableForTestResult):
1665         (willSendRequestCallback):
1666         (frameLoadEventCallback):
1667         * DumpRenderTree/gtk/EditingCallbacks.cpp:
1668         (dumpNodePath):
1669         (dumpRange):
1670         (shouldApplyStyle):
1671         * DumpRenderTree/gtk/EventSender.cpp:
1672         (contextClickCallback):
1673         (beginDragWithFilesCallback):
1674         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1675         (TestRunner::pathToLocalResource):
1676         (TestRunner::queueLoad):
1677         (TestRunner::removeOriginAccessWhitelistEntry):
1678         (TestRunner::setMockGeolocationPositionUnavailableError):
1679         (TestRunner::setIconDatabaseEnabled):
1680         (TestRunner::findString):
1681         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
1682         (TestRunner::overridePreference):
1683         (TestRunner::addUserScript):
1684         (TestRunner::addUserStyleSheet):
1685         (TestRunner::setTextDirection):
1686         * DumpRenderTree/gtk/TextInputController.cpp:
1687         (setMarkedTextCallback):
1688         (insertTextCallback):
1689         (doCommandCallback):
1690         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
1691         (LoadHTMLStringItem::invoke):
1692         * TestWebKitAPI/PlatformGTK.cmake:
1693         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
1694         (WebKitDOMNodeTest::testTagNames):
1695         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
1696         (testBackForwardListLimitAndCache):
1697         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
1698         (testContextMenuSmartSeparators):
1699         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
1700         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1701         (testDownloadLocalFile):
1702         (testDownloadLocalFileError):
1703         (addContentDispositionHTTPHeaderToResponse):
1704         (serverCallback):
1705         (testDownloadRemoteFileError):
1706         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
1707         (startTestServer):
1708         (testInspectorServerPageList):
1709         (openRemoteDebuggingSession):
1710         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
1711         (testPrintOperationPrint):
1712         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1713         (addCacheHTTPHeadersToResponse):
1714         (serverCallback):
1715         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1716         (httpsServerCallback):
1717         (httpServerCallback):
1718         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1719         (testWebViewJavaScriptDialogs):
1720         (testWebViewWindowProperties):
1721         (testWebViewFileChooserRequest):
1722         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
1723         (testWebExtensionWindowObjectCleared):
1724         (testWebExtensionIsolatedWorld):
1725         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp:
1726         (startTestServer):
1727         (checkAtspiAccessible):
1728         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
1729         (serverCallback):
1730         (testClearDatabase):
1731         (testGetFaviconURI):
1732         (webkitFaviconDatabaseFinalizedCallback):
1733         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1734         (testWebContextGetPlugins):
1735         (testWebContextURIScheme):
1736         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1737         (testWebViewRunJavaScript):
1738         (testWebViewMode):
1739         (testWebViewPageVisibility):
1740         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp:
1741         (isStyleSheetInjectedForURLAtPath):
1742         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
1743         (testWebViewEditorCutCopyPasteNonEditable):
1744         (testWebViewEditorCutCopyPasteEditable):
1745         (testWebViewEditorSelectAllNonEditable):
1746         (testWebViewEditorSelectAllEditable):
1747         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1748         (sendRequestCallback):
1749         (methodCallCallback):
1750         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
1751         (TestWebKitAPI::Util::createInjectedBundlePath):
1752         (TestWebKitAPI::Util::createURLForResource):
1753         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
1754         (TestWebKitAPI::doKeyStroke):
1755         (TestWebKitAPI::doMouseButtonEvent):
1756         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
1757         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
1758         (loadFailedCallback):
1759         (LoadTrackingTest::loadURI):
1760         (LoadTrackingTest::loadHtml):
1761         (LoadTrackingTest::loadPlainText):
1762         (LoadTrackingTest::loadRequest):
1763         (LoadTrackingTest::reload):
1764         (LoadTrackingTest::goBack):
1765         (LoadTrackingTest::goForward):
1766         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
1767         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:
1768         (registerGResource):
1769         (removeNonEmptyDirectory):
1770         (main):
1771         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1772         (Test::getWebKit1TestResoucesDir):
1773         (Test::getResourcesDir):
1774         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp:
1775         (WebKitTestBus::run):
1776         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
1777         (WebKitTestServer::WebKitTestServer):
1778         (WebKitTestServer::getURIForPath):
1779         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp:
1780         (WebProcessTestRunner::runTest):
1781         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1782         (resourceGetDataCallback):
1783         (WebViewTest::mainResourceData):
1784         (WebViewTest::mouseMoveTo):
1785         (WebViewTest::keyStroke):
1786         (WebViewTest::doMouseButtonEvent):
1787         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
1788         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1789         (WTR::AccessibilityController::accessibleElementById):
1790         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1791         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1792         (WTR::AccessibilityUIElement::role):
1793         (WTR::AccessibilityUIElement::title):
1794         (WTR::AccessibilityUIElement::description):
1795         (WTR::AccessibilityUIElement::stringValue):
1796         (WTR::AccessibilityUIElement::language):
1797         (WTR::AccessibilityUIElement::lineForIndex):
1798         (WTR::AccessibilityUIElement::selectedTextRange):
1799         (WTR::AccessibilityUIElement::url):
1800         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1801         (WTR::getOutputDir):
1802         (WTR::getFontsPath):
1803         (WTR::initializeFontConfigSetting):
1804         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1805         (WTR::topLevelPath):
1806         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1807         (WTR::TestRunner::pathToLocalResource):
1808         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1809         (WTR::TestController::initializeInjectedBundlePath):
1810         (WTR::TestController::initializeTestPluginDirectory):
1811
1812 2014-01-05  Martin Robinson  <mrobinson@igalia.com>
1813
1814         [GTK] [CMake] run-webkit-tests should support the CMake build
1815         https://bugs.webkit.org/show_bug.cgi?id=126503
1816
1817         Reviewed by Daniel Bates.
1818
1819         Update run-launcher and gtk.py to work properly when dealing with the CMake port.
1820         run-webkit-tests does not need the --gtkcmake flag, but run-launcher does.
1821
1822         * Scripts/run-launcher: Work properly with the gtkcmake flag.
1823         * Scripts/webkitpy/port/gtk.py:
1824         (GtkPort._is_cmake_build): Added this helper which looks for the CMakeCache
1825         file to detect a CMake build.
1826         (GtkPort._built_executables_path): Added this helper to locate the built executable path.
1827         (GtkPort._built_libraries_path): Added this helper to locate the built library path.
1828         (GtkPort._port_flag_for_scripts): Use --gtkcmake when appropriate.
1829         (GtkPort.setup_environ_for_server): The way CMake builds libraries differs from GTK+.
1830         (GtkPort._path_to_driver): Use the new helper.
1831         (GtkPort._path_to_image_diff): Use the new helper.
1832         (GtkPort._path_to_webcore_library): Use the new helper.
1833         (GtkPort.build_webkit_command): Use --gtkcmake when appropriate.
1834
1835 2014-01-22  Ryuan Choi  <ryuan.choi@samsung.com>
1836
1837         [EFL] Remove unnecessary smart method since ewk_view_tiled removed
1838         https://bugs.webkit.org/show_bug.cgi?id=127417
1839
1840         Reviewed by Gyuyoung Kim.
1841
1842         * EWebLauncher/main.c:
1843         (on_key_down): Removed shortcut to test pre render.
1844
1845 2014-01-22  Myles C. Maxfield  <mmaxfield@apple.com>
1846
1847         Remove CSS3_TEXT_DECORATION define
1848         https://bugs.webkit.org/show_bug.cgi?id=127333
1849
1850         This is required for unprefixing the text-decoration-* CSS properties.
1851
1852         Reviewed by Simon Fraser.
1853
1854         * Configurations/FeatureDefines.xcconfig:
1855
1856 2014-01-22  Andy Estes  <aestes@apple.com>
1857
1858         [iOS] Prepare for upstreaming DumpRenderTree changes
1859         https://bugs.webkit.org/show_bug.cgi?id=127412
1860
1861         Reviewed by Simon Fraser.
1862
1863         Unlike on Mac where DumpRenderTree is a command-line tool, on iOS it is
1864         an application bundle. Instead of upstreaming a separate target for the
1865         app that duplicates the 'Compile Sources' phase of the tool, separate
1866         out the compilation into a static library target that both the
1867         command-line tool and the app can link against. Also, perform some
1868         unrelated cleanup.
1869
1870         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Updated the
1871         project file format from 2.4- to 3.2-compatible. Removed the
1872         'Copy Headers' build phase and removed all files from the
1873         'Compile Sources' build phase of DumpRenderTree. Added some files that
1874         were missing from the project. Created a 'DumpRenderTree (Library)'
1875         target for building the static library and made the 'DumpRenderTree'
1876         target depend on it. Added a 'Compile Sources' build phase to this
1877         target that builds the same files the DumpRenderTree target used to.
1878         Created DumpRenderTreeMain.mm as the only source file of the
1879         DumpRenderTree target, since targets won't link a binary without at
1880         least one source file. Made DumpRenderTree (Library) use
1881         DumpRenderTreeLibrary.xcconfig and made LayoutTestHelper use
1882         BaseTarget.xcconfig (so that it doesn't try to link libDumpRenderTree.a).
1883         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Moved
1884         definitions of GCC_ENABLE_OBJC_EXCEPTIONS and GCC_PREFIX_HEADER from
1885         DumpRenderTree.xcconfig to here so that LayoutTestHelper can use them.
1886         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Passed
1887         -force_load $(BUILT_PRODUCTS_DIR)libDumpRenderTree.a to OTHER_LDFLAGS.
1888         This is needed to correctly link a static library containing an Objective-C
1889         category (see <https://developer.apple.com/library/mac/qa/qa1490/_index.html>).
1890         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Added.
1891         * DumpRenderTree/mac/DumpRenderTree.mm:
1892         (DumpRenderTreeMain): Renamed from main.
1893         * DumpRenderTree/mac/DumpRenderTreeMac.h: Added declaration of DumpRenderTreeMain.
1894         * DumpRenderTree/mac/DumpRenderTreeMain.mm: Added.
1895         (main): Called DumpRenderTreeMain from main.
1896
1897 2014-01-15  Martin Robinson  <mrobinson@igalia.com>
1898
1899         [GTK][CMake] build-webkit should try harder to avoid re-running cmake
1900         https://bugs.webkit.org/show_bug.cgi?id=127073
1901
1902         Reviewed by Daniel Bates.
1903
1904         * Scripts/build-webkit: Unify all the ports that call buildCMakeProjectOrExit with
1905         the new isCMakeBuild conditional. This allows us to share more code between ports.
1906         Pass the build arguments to the removeCMakeCache function.
1907         * Scripts/webkitdirs.pm:
1908         (runAutogenForAutotoolsProjectIfNecessary): Renamed mustReRunAutogen to cachedArgumentFileOutOfDate
1909         because it's now shared with the CMake build.
1910         (cachedArgumentFileOutOfDate): Renamed.
1911         (cmakeCachePath): Added this helper which gets the CMakeCache.txt path.
1912         (shouldRemoveCMakeCache): Tries to preserve current behavior for all ports, 
1913         except GTK+ which examines the OptionsGTK.cmake and OptionsCommon.cmake file
1914         as well as checking if build-webkit has been run with different arguments.
1915         (removeCMakeCache): Call shouldRemoveCMakeCache now.
1916         (generateBuildSystemFromCMakeProject): Exit early if CMakeCache.txt exists for GTK+.
1917         (isCMakeBuild): Added.
1918
1919 2014-01-22  Thiago de Barros Lacerda  <thiago.lacerda@openbossa.org>
1920
1921         [EFL][GTK] Get EFL and GTK compiling with ACCESSIBILITY disabled
1922         https://bugs.webkit.org/show_bug.cgi?id=127119
1923
1924         Reviewed by Mario Sanchez Prada.
1925
1926         Guarding ACCESSIBILITY code in DumpRenderTree and WebKitTestRunner with HAVE(ACCESSIBILITY).
1927
1928         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1929         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1930         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1931         (resetDefaultsToConsistentValues):
1932         (webViewWindowObjectCleared):
1933         (main):
1934         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1935         (WTR::AccessibilityController::platformName):
1936         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1937         (WTR::AccessibilityUIElement::isIndeterminate):
1938
1939 2014-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1940
1941
1942         [GTK] Add GUniquePtr
1943         https://bugs.webkit.org/show_bug.cgi?id=127170
1944
1945         Reviewed by Gustavo Noronha Silva.
1946
1947         Add unit tests for GUniquePtr.
1948
1949         * TestWebKitAPI/GNUmakefile.am: Add new file to compilation.
1950         * TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp: Added.
1951         (log):
1952         (takeLogStr):
1953         (TestWebKitAPI::TEST):
1954
1955 2014-01-22  Jinwoo Song  <jinwoo7.song@samsung.com>
1956
1957         Remove Nix files from Tools
1958         https://bugs.webkit.org/show_bug.cgi?id=127418
1959
1960         Reviewed by Csaba Osztrogonác.
1961
1962         * Scripts/build-webkit:
1963         * Scripts/update-webkit-libs-jhbuild:
1964         * Scripts/webkitdirs.pm:
1965         (determineArchitecture):
1966         (argumentsForConfiguration):
1967         (jscProductDir):
1968         (builtDylibPathForName):
1969         (isAppleWebKit):
1970         (launcherPath):
1971         (launcherName):
1972         (checkRequiredSystemConfig):
1973         (copyInspectorFrontendFiles):
1974         (jhbuildWrapperPrefixIfNeeded):
1975         (buildCMakeProjectOrExit):
1976         (cmakeBasedPortName):
1977         * Scripts/webkitpy/common/config/ports.py:
1978         (DeprecatedPort.port):
1979         (EflWK2Port.build_webkit_command):
1980         * Scripts/webkitpy/port/factory.py:
1981         (platform_options):
1982         (PortFactory):
1983         * Scripts/webkitpy/port/nix.py: Removed.
1984         * Scripts/webkitpy/port/nix_unittest.py: Removed.
1985
1986 2014-01-21  Benjamin Poulain  <benjamin@webkit.org>
1987
1988         Add Ian and Ricky to the contributor list
1989
1990         * Scripts/webkitpy/common/config/contributors.json:
1991         I am too old to remember all those email addresses :)
1992
1993 2014-01-21  David Farler  <dfarler@apple.com>
1994
1995         Upstream package-root for iOS
1996
1997         Reviewed by Daniel bates.
1998
1999         * Scripts/package-root: Added.
2000         (usage):
2001         * Scripts/webkitdirs.pm:
2002         (XcodeSDKPath): Added function.
2003
2004 2014-01-21  Daniel Bates  <dabates@apple.com>
2005
2006         [iOS] Tools/Makefile shouldn't build modules DumpRenderTree, gtest, or TestWebKitAPI
2007         https://bugs.webkit.org/show_bug.cgi?id=127368
2008
2009         Reviewed by Tim Horton.
2010
2011         Similar to the build-webkit change in <https://bugs.webkit.org/show_bug.cgi?id=127364>,
2012         we don't want to build DumpRenderTree, gtest, or TestWebKitAPI when running make in
2013         Tools.
2014
2015         * Makefile:
2016
2017 2014-01-21  Daniel Bates  <dabates@apple.com>
2018
2019         [iOS] Don't build DumpRenderTree, gtest, or TestWebKitAPI
2020         https://bugs.webkit.org/show_bug.cgi?id=127364
2021
2022         Reviewed by Simon Fraser.
2023
2024         For now, don't build DumpRenderTree and TestWebKitAPI for iOS as these
2025         projects fail to build because we need to upstream the relevant iOS changes.
2026         Also, don't build gtest, which is a dependency of TestWebKitAPI since we
2027         aren't building TestWebKitAPI.
2028
2029         * Scripts/build-webkit:
2030
2031 2014-01-21  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2032
2033         Unreviewed, remove myself from some watchlist entries.
2034
2035         * Scripts/webkitpy/common/config/watchlist:
2036
2037 2014-01-21  Zalan Bujtas  <zalan@apple.com>
2038
2039         Use 64 as the default value for the subpixel denominator.
2040
2041         Reviewed by Simon Fraser.
2042
2043         * lldb/lldb_webkit.py:
2044         (WebCoreLayoutUnitProvider.to_string):
2045
2046 2014-01-21  ChangSeok Oh  <changseok.oh@collabora.com>
2047
2048         [GTK] Fix a c++11 compliance issue for fontconfig
2049         https://bugs.webkit.org/show_bug.cgi?id=127283
2050
2051         Reviewed by Martin Robinson.
2052
2053         fontconfig-2.8.0 is not compliant with C++11. So I propose to apply a
2054         hotfix until bumping fontconfig up.
2055
2056         * gtk/jhbuild.modules:
2057         * gtk/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
2058
2059 2014-01-21  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2060
2061         run-jsc-stress-tests should accept --child-processes option and WEBKIT_TEST_CHILD_PROCESSES env.var
2062         like run_webkit_test does
2063         https://bugs.webkit.org/show_bug.cgi?id=127349
2064
2065         Reviewed by Csaba Osztrogonác.
2066
2067         * Scripts/run-jsc-stress-tests:
2068
2069 2014-01-21  Adrian Perez de Castro  <aperez@igalia.com>
2070
2071         [GTK] Allow passing extra data to web extensions
2072         https://bugs.webkit.org/show_bug.cgi?id=125990
2073
2074         Reviewed by Carlos Garcia Campos.
2075
2076         Allow passing additional information to the injected bundle. On top
2077         of the string containing the path to the web extensions directory,
2078         a GVariant can be set with additional data using
2079         webkit_web_context_set_web_extensions_initialization_user_data().
2080         Also, a new initialize-web-extensions signal is emitted before
2081         launching a new WebProcess to allow setting different user data
2082         for each process. The GVariant is serialized as a string, passed
2083         to the injected bundle, and the injected bundle deserializes back
2084         the data, which is passed to web extensions which define the
2085         webkit_web_extension_initialize_with_user_data() function (for
2086         backwards compatibility, webkit_web_extension_initialize() is
2087         used as a fallback.)
2088
2089         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
2090         (initializeWebExtensions): Handles the initialize-web-extensions
2091         signal, and sets the web extensions directory and the initialization
2092         user data.
2093         (testWebExtensionInitializationUserData): New test case for checking
2094         the user data passed on initialization to web extensions.
2095         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2096         (methodCallCallback): Added implementation for the
2097         GetInitializationUserData D-Bus method, used by
2098         testWebExtensionInitializationUserData().
2099         (webkit_web_extension_initialize_with_user_data): Define the
2100         initialization function with the additional user data parameter.
2101
2102 2014-01-21  Siddharth Mathur  <s.mathur@ieee.org>
2103
2104         Change my email address in contributors.json.
2105
2106         Unreviewed.
2107
2108         * Scripts/webkitpy/common/config/contributors.json:
2109
2110 2014-01-21  Krzysztof Czech  <k.czech@samsung.com>
2111
2112         [ATK] Expose aria-flowto through ATK_RELATION_FLOWS_TO
2113         https://bugs.webkit.org/show_bug.cgi?id=127291
2114
2115         Reviewed by Mario Sanchez Prada.
2116
2117         Implemented AccessibilityUIElement::ariaFlowToElementAtIndex method.
2118
2119         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2120         (AccessibilityUIElement::ariaFlowToElementAtIndex):
2121         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2122         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
2123
2124 2014-01-20  Zalan Bujtas  <zalan@apple.com>
2125
2126         Force float division when calculating CSS px value.
2127
2128         Reviewed by Simon Fraser.
2129
2130         Note that in Python 3, this is the default behavior.
2131
2132         * lldb/lldb_webkit.py:
2133         (WebCoreLayoutUnitProvider.to_string):
2134
2135 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
2136
2137         build.webkit.org/dashboard should display information about patches in EWS
2138         https://bugs.webkit.org/show_bug.cgi?id=127006
2139
2140         Reviewed by Ryosuke Niwa.
2141
2142         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
2143         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Bugzilla.js: Added.
2144         (Bugzilla.prototype.detailsURLForAttachment):
2145         Added a class for Bugzilla. So far, the only thing it can do is build patch URLs,
2146         which is needed when one wants to do something with a patch EWS is stuck on.
2147
2148         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
2149         Create a Bugzilla instance.
2150
2151         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
2152         (EWS.prototype.jsonQueueLengthURL):
2153         (EWS.prototype.jsonQueueStatusURL):
2154         Build JSON ULRs here, not in EWSQueue, as this is how other classes are structured.
2155
2156         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
2157         (EWSQueue.prototype.get statusPageURL): Changed to use a URL provided by EWS instead
2158         of second guessing.
2159         (EWSQueue.prototype.get chartsPageURL): Added.
2160         (EWSQueue.prototype.get loadedDetailedStatus): Tells whether we currently have
2161         additional data already loaded (it's reset with every update).
2162         (EWSQueue.prototype.get patches): Get patch queue.
2163         (EWSQueue.prototype.get bots): Get bots.
2164         (EWSQueue.prototype.update): Changed to use a specialized cheaper URL.
2165         (EWSQueue.prototype.loadDetailedStatus): Load and transform detailed status JSON.
2166
2167         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
2168         (EWSQueueView.prototype.update.appendQueue): Add a popover is there are any patches
2169         in the queue.
2170         (EWSQueueView.prototype.addLinkToRow): A helper to build the popover.
2171         (EWSQueueView.prototype.addTextToRow): Ditto.
2172         (EWSQueueView.prototype._addQueueHeadingToPopover): Ditto.
2173         (EWSQueueView.prototype._addBotsHeadingToPopover): Ditto.
2174         (EWSQueueView.prototype._addDividerToPopover): Ditto.
2175         (EWSQueueView.prototype._timeIntervalString): A helper to format a timestamp into a
2176         relative string.
2177         (EWSQueueView.prototype._popoverContentForEWSQueue): Build the popover.
2178         (EWSQueueView.prototype._presentPopoverForEWSQueue): Start loading data, and present
2179         it when done.
2180
2181         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
2182         Added rules for EWS popover. Removed a duplicate rule for build-logs-popover.
2183         Changed a few difficult to read padding styles to padding-left.
2184
2185 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
2186
2187         Fix webkitpy tests.
2188
2189         * Scripts/webkitpy/common/net/web_mock.py: (MockBrowser.set_handle_robots):
2190         Added a mock implementation, as we now call this function.
2191
2192 2014-01-20  Darin Adler  <darin@apple.com>
2193
2194         Update style checker and tests to deal with override instead of OVERRIDE
2195         https://bugs.webkit.org/show_bug.cgi?id=127175
2196
2197         Reviewed by Anders Carlsson.
2198
2199         * Scripts/webkitpy/style/checkers/cpp.py:
2200         (check_braces): Use override instead of OVERRIDE.
2201         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2202         (CppStyleTest.test_brace_at_begin_of_line): Ditto.
2203
2204 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
2205
2206         EWS should provide better information to Dashboard via JSON
2207         https://bugs.webkit.org/show_bug.cgi?id=127265
2208
2209         Reviewed by Ryosuke Niwa.
2210
2211         * QueueStatusServer/app.yaml: Updated version.
2212
2213         * QueueStatusServer/main.py:
2214         * QueueStatusServer/handlers/queuelengthjson.py:
2215         Added a way to cheaply get only the queue length, which is all the dashboard
2216         needs unless a popover is opened.
2217
2218         * QueueStatusServer/handlers/queuestatusjson.py: Updated to return more information
2219         that we will need. Changed some field names to be more meaningful. Fixed bot listing
2220         to understand that a bot can be reprurposed and used in a different queue.
2221
2222 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
2223
2224         Make uploading results to EWS work despite robots.txt
2225         https://bugs.webkit.org/show_bug.cgi?id=127296
2226
2227         Reviewed by Ryosuke Niwa.
2228
2229         * Scripts/webkitpy/common/net/statusserver.py: (StatusServer.__init__): Disable
2230         checking robots.txt.
2231
2232         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: (Bugzilla._get_browser):
2233         Removed a comment saying that we would want to stop doing this. Not checking
2234         robots.txt is more efficient than checking it.
2235
2236 2014-01-19  Ryuan Choi  <ryuan.choi@samsung.com>
2237
2238         [EFL][WK1] Remove and refactor the APIs which use single and base keyword
2239         https://bugs.webkit.org/show_bug.cgi?id=127214
2240
2241         Reviewed by Gyuyoung Kim.
2242
2243         Followed the changes of API.
2244
2245         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2246         (drtViewAdd):
2247         * EWebLauncher/main.c:
2248         (windowCreate):
2249
2250 2014-01-19  Eunmi Lee  <eunmi15.lee@samsung.com>
2251
2252         [EFL][WK2] Add touch events option to MiniBrowser.
2253         https://bugs.webkit.org/show_bug.cgi?id=127262
2254
2255         Reviewed by Gyuyoung Kim.
2256
2257         As a default, touch events are disabled and mouse events are enabled.
2258         If touch events option sets to true, touch events are enabled and mouse
2259         events are disabled.
2260
2261         * MiniBrowser/efl/main.c:
2262         (window_create):
2263         (elm_main):
2264
2265 2014-01-19  Zalan Bujtas  <zalan@apple.com>
2266
2267         Pretty print LayoutUnit, LayoutPoint, and LayoutSize in lldb and gdb.
2268         https://bugs.webkit.org/show_bug.cgi?id=126080
2269
2270         Reviewed by Sam Weinig.
2271
2272         This changes the output of printing LayoutUnits to be in px but it also
2273         preserves the original LayoutUnit value.
2274
2275         This will lead to lldb output like: (and it works even when subpixel is disabled)
2276
2277         (const WebCore::LayoutRect) $0 = {
2278             m_location = { x = 2.25px (144), y = 1px (64)}
2279             m_size = { width = 13.75px (880), height = 20px (1280) }
2280
2281
2282         And gdb output like:
2283
2284         m_frameRect = {
2285             m_location = LayoutPoint(0px (0), 0px(0)),
2286             m_size = LayoutSize(8px (512), 5px (320))
2287         }
2288
2289         This patch is based on patch by bjonesbe@adobe.com and for Blink by cbiesinger@chromium.org.
2290
2291         * gdb/webkit.py:
2292         (WebCoreLayoutUnitPrinter):
2293         (WebCoreLayoutUnitPrinter.__init__):
2294         (WebCoreLayoutUnitPrinter.to_string):
2295         (WebCoreLayoutSizePrinter):
2296         (WebCoreLayoutSizePrinter.__init__):
2297         (WebCoreLayoutSizePrinter.to_string):
2298         (WebCoreLayoutPointPrinter):
2299         (WebCoreLayoutPointPrinter.__init__):
2300         (WebCoreLayoutPointPrinter.to_string):
2301         (add_pretty_printers):
2302         * lldb/lldb_webkit.py:
2303         (__lldb_init_module):
2304         (WebCoreLayoutUnit_SummaryProvider):
2305         (WebCoreLayoutSize_SummaryProvider):
2306         (WebCoreLayoutPoint_SummaryProvider):
2307         (WebCoreLayoutUnitProvider):
2308         (WebCoreLayoutUnitProvider.__init__):
2309         (WebCoreLayoutUnitProvider.to_string):
2310         (WebCoreLayoutSizeProvider):
2311         (WebCoreLayoutSizeProvider.__init__):
2312         (WebCoreLayoutSizeProvider.get_width):
2313         (WebCoreLayoutSizeProvider.get_height):
2314         (WebCoreLayoutPointProvider):
2315         (WebCoreLayoutPointProvider.__init__):
2316         (WebCoreLayoutPointProvider.get_x):
2317         (WebCoreLayoutPointProvider.get_y):
2318
2319 2014-01-18  Alexey Proskuryakov  <ap@apple.com>
2320
2321         Add robots.txt to http://webkit-queues.appspot.com
2322         https://bugs.webkit.org/show_bug.cgi?id=127240
2323
2324         * QueueStatusServer/app.yaml: Added required "upload" attribute for robots.txt.
2325
2326 2014-01-18  Alexey Proskuryakov  <ap@apple.com>
2327
2328         Add robots.txt to http://webkit-queues.appspot.com
2329         https://bugs.webkit.org/show_bug.cgi?id=127240
2330
2331         Reviewed by Ryosuke Niwa.
2332
2333         * QueueStatusServer/app.yaml: Added robots.txt as a static file. Updated version.
2334
2335         * QueueStatusServer/robots.txt: Added.
2336
2337 2014-01-18  Alberto Garcia  <berto@igalia.com>
2338
2339         Tools/Scripts/test-webkitperl fails: 'tempdir' can't be called as a method
2340         https://bugs.webkit.org/show_bug.cgi?id=127217
2341
2342         Reviewed by Daniel Bates.
2343
2344         The syntax File::Temp->tempdir() was explicitly made invalid
2345         following <https://github.com/Perl-Toolchain-Gang/File-Temp/commit/c8920b2161ab6900a09e02b9410e0e4c3d74f565>
2346         which was included in File::Temp v2.30, shipped with Perl v5.18.0.
2347
2348         Use File::Temp::tempdir() instead.
2349
2350         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
2351
2352 2014-01-18  Alexey Proskuryakov  <ap@apple.com>
2353
2354         build.webkit.org/dashboard should have image diff links in test results popovers
2355         https://bugs.webkit.org/show_bug.cgi?id=127188
2356
2357         Reviewed by Timothy Hatcher.
2358
2359         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2360         (Buildbot.prototype.layoutTestImagesURLForIteration):
2361         (Buildbot.prototype.layoutTestImageDiffURLForIteration):
2362         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2363         (BuildbotIteration.prototype.loadLayoutTestResults):
2364         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2365         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions.addFailureInfoLink):
2366         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions.addFailureInfoText):
2367         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
2368
2369 2014-01-18  Anders Carlsson  <andersca@apple.com>
2370
2371         Remove ENABLE_THREADED_HTML_PARSER defines everywhere
2372         https://bugs.webkit.org/show_bug.cgi?id=127225
2373
2374         Reviewed by Andreas Kling.
2375
2376         This concludes the removal of over 8.8 million lines of threaded parser code.
2377
2378         * Scripts/webkitperl/FeatureList.pm:
2379
2380 2014-01-17  Alexey Proskuryakov  <ap@apple.com>
2381
2382         build.webkit.org/dashboard should have diff links in test results popovers
2383         https://bugs.webkit.org/show_bug.cgi?id=126986
2384
2385         Reviewed by Tim Horton.
2386
2387         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2388         (Buildbot.prototype.layoutTestCrashLogURLForIteration):
2389         (Buildbot.prototype.layoutTestStderrURLForIteration):
2390         (Buildbot.prototype.layoutTestDiffURLForIteration):
2391         (Buildbot.prototype.layoutTestPrettyDiffURLForIteration):
2392         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2393         (BuildbotIteration.prototype.loadLayoutTestResults):
2394         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2395         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
2396
2397 2014-01-17  Matthew Hanson  <matthew_hanson@apple.com>
2398
2399         Add the bare minimum support for branches to the bot-watchers dashboard
2400         https://bugs.webkit.org/show_bug.cgi?id=127124
2401
2402         This patch simply introduces the notion of branches into the bot-watchers dashboard.
2403         Subsequent patches will build functionality on top of this simple bit of infrastructure.
2404
2405         Reviewed by Timothy Hatcher.
2406
2407         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2408         (BuildbotQueue): store the branch property in the BuildbotQueue constructor
2409         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2410         Initialize the Dashboard.Branch object
2411
2412 2014-01-17  Chris Fleizach  <cfleizach@apple.com>
2413
2414         platform/mac/accessibility/aria-multiline.html sometimes asserts in AccessibilityController::removeNotificationListener
2415         https://bugs.webkit.org/show_bug.cgi?id=127141
2416
2417         Reviewed by Alexey Proskuryakov.
2418
2419         Make sure to reset the notification handler each time.
2420
2421         * DumpRenderTree/AccessibilityController.cpp:
2422         (AccessibilityController::resetToConsistentState):
2423         * DumpRenderTree/AccessibilityController.h:
2424         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
2425         (AccessibilityController::platformResetToConsistentState):
2426         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
2427         (AccessibilityController::platformResetToConsistentState):
2428         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2429         (AccessibilityController::~AccessibilityController):
2430         (AccessibilityController::platformResetToConsistentState):
2431         (AccessibilityController::removeNotificationListener):
2432         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2433         (AccessibilityController::platformResetToConsistentState):
2434
2435 2014-01-17  Alberto Garcia  <berto@igalia.com>
2436
2437         [GTK] Test /webkit/download/not-found fails in GTK Linux 64-bit Release bot
2438         https://bugs.webkit.org/show_bug.cgi?id=82329
2439
2440         Reviewed by Carlos Garcia Campos.
2441
2442         Unskip, this is working fine now.
2443
2444         * Scripts/run-gtk-tests:
2445         (TestRunner):
2446
2447 2014-01-17  Alberto Garcia  <berto@igalia.com>
2448
2449         [GTK] Test /webkit/webview/icon-uri times out in GTK Linux 64-bit Release bot
2450         https://bugs.webkit.org/show_bug.cgi?id=82328
2451
2452         Reviewed by Carlos Garcia Campos.
2453
2454         This was caused by the icon database being corrupted in the
2455         Release bot. After removing it the test works fine so it can be
2456         run again.
2457
2458         * Scripts/run-gtk-tests:
2459         (TestRunner):
2460
2461 2014-01-16  Alexey Proskuryakov  <ap@apple.com>
2462
2463         Test results popovers at http://build.webkit.org/dashboard should link to stderr
2464         https://bugs.webkit.org/show_bug.cgi?id=126929
2465
2466         Reviewed by Timothy Hatcher.
2467
2468         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2469         (Buildbot.prototype.layoutTestCrashLogURLForIteration): Renamed for consistency.
2470         (Buildbot.prototype.layoutTestStderrURLForIteration): Added.
2471
2472         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2473         (BuildbotIteration.prototype.loadLayoutTestResults): Store has_stderr attribute.
2474
2475         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2476         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
2477         Add a link to stderr output if present.
2478
2479         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
2480         (.test-results-popover .additional-link): Style with light grey (will use the same style
2481         for diff links).
2482
2483 2014-01-16  Ryosuke Niwa  <rniwa@webkit.org>
2484
2485         Automate DoYouEvenBench
2486         https://bugs.webkit.org/show_bug.cgi?id=124497
2487
2488         Reviewed by Geoffrey Garen.
2489
2490         * Scripts/webkitpy/performance_tests/perftest.py:
2491         (PerfTestMetric.__init__): Added the aggregator name as an argument.
2492         (PerfTestMetric.aggregator): Added.
2493         (PerfTest._metrics_regex): Made the subtest name match non-greedy so that the metric names will be
2494         won't be eagerly parsed as a part of the subtest name. e.g. "Time" and "Total" in "a:Time:Total"
2495         should be parsed as the metric and the aggregator respectively.
2496         (PerfTest._run_with_driver): Pass in the aggregator name.
2497         (PerfTest._ensure_metrics): Ditto. Also split the subtest name by / as required by DoYouEvenBench
2498         which generates subtests of subtests within a single test file.
2499
2500         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2501         (test_parse_output_with_subtests_and_total): Added.
2502
2503         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2504         (_generate_results_dict): Add the aggregator name to the JSON when one is available.
2505
2506         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2507         (TestWithSubtestsData): Added a sub test with an aggregator and a sub-sub test.
2508
2509 2014-01-16  Chris Fleizach  <cfleizach@apple.com>
2510
2511         platform/mac/accessibility/aria-multiline.html sometimes asserts in AccessibilityController::removeNotificationListener
2512         https://bugs.webkit.org/show_bug.cgi?id=127141
2513
2514         Reviewed by Alexey Proskuryakov.
2515
2516         Don't assert that the notification handler needs to be cleaned up. Deallocing the controller should be enough to clean up as it is.
2517
2518         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2519         (AccessibilityController::~AccessibilityController):
2520
2521 2014-01-16  Ryosuke Niwa  <rniwa@webkit.org>
2522
2523         EWS shouldn't comment on Bugzilla for failing builds or style errors
2524         https://bugs.webkit.org/show_bug.cgi?id=127079
2525
2526         Reviewed by Anders Carlsson.
2527
2528         Since patch authors and reviewers could retrieve this information from bubbles,
2529         we shouldn't spam the Bugzilla with useless comments.
2530
2531         We still post style errors but not python paths we used since it's a pure noise.
2532
2533         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2534         (AbstractEarlyWarningSystem._post_reject_message_on_bug):
2535         * Scripts/webkitpy/tool/commands/queues.py:
2536         (StyleQueue.review_patch):
2537
2538 2014-01-15  Roger Fong  <roger_fong@apple.com>
2539
2540         Add support for handling WebGL load policies.
2541         https://bugs.webkit.org/show_bug.cgi?id=126935
2542         <rdar://problem/15790448>.
2543
2544         Reviewed by Timothy Horton.
2545
2546         * WebKitTestRunner/TestController.cpp: Update WKPageLoaderClient to V4.
2547         (WTR::TestController::createWebViewWithOptions):
2548
2549 2014-01-16  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2550
2551         Remove workaround for compilers not supporting explicit override control
2552         https://bugs.webkit.org/show_bug.cgi?id=127111
2553
2554         Reviewed by Anders Carlsson.
2555
2556         Now all compilers support explicit override control, this workaround can be removed.
2557
2558         * DumpRenderTree/gtk/fonts/fonts.conf:
2559         * Scripts/do-webcore-rename:
2560         Removed this rename operation from the list of contemplated future renames.
2561         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
2562         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
2563         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
2564         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
2565         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2566
2567 2014-01-16  Oliver Hunt  <oliver@apple.com>
2568
2569         Stop run-jsc from consuming stderr output
2570         https://bugs.webkit.org/show_bug.cgi?id=127115
2571
2572         Reviewed by Mark Lam.
2573
2574         Simple patch to make run-jsc easier to deal with
2575
2576         * Scripts/run-jsc:
2577
2578 2014-01-16  Eva Balazsfalvi  <balazsfalvi.eva@stud.u-szeged.hu>
2579
2580         Tools/gtk/generate-feature-defines-files doesn't work with older versions of python
2581         https://bugs.webkit.org/show_bug.cgi?id=126323
2582
2583         Reviewed by Csaba Osztrogonác.
2584
2585         * gtk/generate-feature-defines-files:
2586
2587 2014-01-16  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
2588
2589         [EFL][WK2] Implement TestController::setHidden
2590         https://bugs.webkit.org/show_bug.cgi?id=127036
2591
2592         Reviewed by Gyuyoung Kim.
2593
2594         WebKitTestRunner needs TestController::setHidden implementation to
2595         properly handle page visibility API layout tests after r161105.
2596
2597         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2598         (WTR::TestController::setHidden):
2599
2600 2014-01-16  Zan Dobersek  <zdobersek@igalia.com>
2601
2602         [GTK][MiniBrowser] The progress entry reset callback can be fired after the BrowserWindow is destroyed
2603         https://bugs.webkit.org/show_bug.cgi?id=127083
2604
2605         Reviewed by Carlos Garcia Campos.
2606
2607         When the load progress reaches 1.0 (i.e. 100%), a timeout callback is set up in webViewLoadProgressChanged.
2608         The progress entry is then reset back to 0 in that callback and the timeout source is removed.
2609
2610         The callback can be fired after the relevant BrowserWindow and its progress entry are destroyed, causing
2611         assertion failures in gtk_entry_set_progress_fraction due to an invalid GtkEntry object. To avoid that,
2612         To avoid that, the ID of the timeout source is stored on the BrowserWindow and is destroyed when the
2613         BrowserWindow object is being finalized, preventing the callback from firing.
2614
2615         * MiniBrowser/gtk/BrowserWindow.c:
2616         (resetEntryProgress):
2617         (webViewLoadProgressChanged):
2618         (browserWindowFinalize):
2619
2620 2014-01-15  Alexey Proskuryakov  <ap@apple.com>
2621
2622         DumpRenderTree doesn't disable web preferences autosave
2623         https://bugs.webkit.org/show_bug.cgi?id=127062
2624
2625         Reviewed by Dan Bernstein.
2626
2627         * DumpRenderTree/mac/DumpRenderTree.mm: (prepareConsistentTestingEnvironment):
2628         Do it.
2629
2630 2014-01-15  Dean Jackson  <dino@apple.com>
2631
2632         Improve filter-build-webkit, especially for iOS builds
2633         https://bugs.webkit.org/show_bug.cgi?id=81046
2634
2635         Reviewed by Joseph Pecoraro.
2636
2637         Lots of updates to the filtering rules, mostly from the
2638         iOS build output. Other highlights include:
2639         - ignoring escape sequences for color ouput
2640         - detecting escaped spaces in file name regexps
2641
2642         * Scripts/filter-build-webkit:
2643         (shouldIgnoreLine):
2644
2645 2014-01-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2646
2647         [GTK] Web process sometimes crashes when printing in synchronous mode
2648         https://bugs.webkit.org/show_bug.cgi?id=126979
2649
2650         Reviewed by Gustavo Noronha Silva.
2651
2652         * Scripts/run-gtk-tests:
2653         (TestRunner): Unskip
2654         /webkit2/WebKitPrintOperation/close-after-print.
2655
2656 2014-01-15  ChangSeok Oh  <changseok.oh@collabora.com>
2657
2658         [EFL] Change test font installed path to webkitgtk-font-tests
2659         https://bugs.webkit.org/show_bug.cgi?id=126723
2660
2661         Reviewed by Gyuyoung Kim.
2662
2663         I'd like to change the test fonts installed directory from 'webkitgtk-test-fonts-0.0.3'
2664         to 'webkitgtk-test-fonts'. webkitgtk-test-fonts-0.0.3 doesn't match the path
2665         hard-coded in FontManagement.cpp#105
2666
2667         * DumpRenderTree/PlatformEfl.cmake:
2668         * WebKitTestRunner/PlatformEfl.cmake:
2669         * efl/jhbuild.modules:
2670
2671 2014-01-14  Ryosuke Niwa  <rniwa@webkit.org>
2672
2673         Make DoYouEvenBench runnable by run-perf-tests
2674         https://bugs.webkit.org/show_bug.cgi?id=127030
2675
2676         Reviewed by Andreas Kling.
2677
2678         Ignore console messages spit out by DoYouEvenBench and support aggregator names such as
2679         ":Total" to appear at the end of a test name. We don't do anything with it for now.
2680
2681         * Scripts/webkitpy/performance_tests/perftest.py:
2682         (PerfTest._metrics_regex): Handle aggregator names such as ":Total". We'll pass it down
2683         to the JSON in a follow up patch for the perf dashboard.
2684         (PerfTest._lines_to_ignore_in_parser_result): Added lines to ignore for DoYouEvenBench.
2685
2686 2014-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
2687
2688         [GTK] UI process crashes when the web process crashes while printing
2689         https://bugs.webkit.org/show_bug.cgi?id=126977
2690
2691         Reviewed by Gustavo Noronha Silva.
2692
2693         Add new test case to check that closing the window right after
2694         printing works. It's skipped for now, because this patch only
2695         fixes the UI process crash, but not the web process one.
2696
2697         * Scripts/run-gtk-tests:
2698         (TestRunner): Skip
2699         /webkit2/WebKitPrintOperation/close-after-print.
2700         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
2701         (testPrintOperationPrintPrinter):
2702         (findPrintToFilePrinter):
2703         (testPrintOperationPrint):
2704         (testPrintOperationErrors):
2705         (testPrintOperationCloseAfterPrint):
2706         (beforeAll):
2707
2708 2014-01-14  Brent Fulgham  <bfulgham@apple.com>
2709
2710         [WIN] Set MSBuild environment variable to avoid long-lived processes locking log files
2711         https://bugs.webkit.org/show_bug.cgi?id=127002
2712
2713         Reviewed by David Kilzer.
2714
2715         * Scripts/webkitdirs.pm:
2716         (setupAppleWinEnv): Export MSBUILDDISABLENODEREUSE=1 to the environment.
2717
2718 2014-01-14  Commit Queue  <commit-queue@webkit.org>
2719
2720         Unreviewed, rolling out r162000.
2721         http://trac.webkit.org/changeset/162000
2722         https://bugs.webkit.org/show_bug.cgi?id=127009
2723
2724         API versioning is wrong (Requested by rfong on #webkit).
2725
2726         * MiniBrowser/mac/WK2BrowserWindowController.m:
2727         (-[WK2BrowserWindowController awakeFromNib]):
2728         * WebKitTestRunner/TestController.cpp:
2729         (WTR::TestController::createOtherPage):
2730         (WTR::TestController::createWebViewWithOptions):
2731
2732 2014-01-13  Roger Fong  <roger_fong@apple.com>
2733
2734         Add support for handling WebGL load policies.
2735         https://bugs.webkit.org/show_bug.cgi?id=126935
2736         <rdar://problem/15790448>.
2737
2738         Reviewed by Brent Fulgham.
2739
2740         * MiniBrowser/mac/WK2BrowserWindowController.m:
2741         (-[WK2BrowserWindowController awakeFromNib]):
2742         * WebKitTestRunner/TestController.cpp:
2743         (WTR::TestController::createWebViewWithOptions):
2744
2745 2014-01-14  Zan Dobersek  <zdobersek@igalia.com>
2746
2747         [GTK] Skip FontConfig initialization in WebKitTestRunner if requested
2748         https://bugs.webkit.org/show_bug.cgi?id=120110
2749
2750         Reviewed by Martin Robinson.
2751
2752         Skip the FontConfig settings initialization in WebKitTestRunner if the
2753         WEBKIT_SKIP_WEBKITTESTRUNNER_FONTCONFIG_INITIALIZATION environment variable is set.
2754         This is useful when profiling the WebKitTestRunner execution, where at the startup
2755         this step takes considerable amount of time and disturbs the profiling output.
2756
2757         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2758         (WTR::initializeFontConfigSetting):
2759
2760 2014-01-14  Brian J. Burg  <burg@cs.washington.edu>
2761
2762         Add ENABLE(WEB_REPLAY) feature flag to the build system
2763         https://bugs.webkit.org/show_bug.cgi?id=126949
2764
2765         Reviewed by Joseph Pecoraro.
2766
2767         * Scripts/webkitperl/FeatureList.pm:
2768
2769 2014-01-14  László Langó  <llango.u-szeged@partner.samsung.com>
2770
2771         REGRESSION (r160085): check-webkit-style: utf8' codec can't decode byte 0x89 in position 0: invalid start byte.
2772         https://bugs.webkit.org/show_bug.cgi?id=126702
2773
2774         Reviewed by Alexey Proskuryakov.
2775
2776         Resolve regression and remove a FIXME comment that is already fixed.
2777
2778         * Scripts/webkitpy/common/system/filesystem.py:
2779         (FileSystem.open_text_file_for_reading):
2780         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2781         (RealFileSystemTest.test_read_and_write_file):
2782         * Scripts/webkitpy/style/filereader.py:
2783         (TextFileReader._read_lines):
2784         * Scripts/webkitpy/style/filereader_unittest.py:
2785         (TextFileReaderTest.test_count_delete_only_file):
2786         (TextFileReaderTest):
2787         (TextFileReaderTest.test_process_malformed_file):
2788
2789 2014-01-02  Brian Holt  <brian.holt@samsung.com>
2790
2791         [GTK] Parse Valgrind xml leak files
2792         https://bugs.webkit.org/show_bug.cgi?id=119446
2793
2794         Reviewed by Alejandro G. Castro.
2795
2796         Parse the xml files generated by Valgrind to yield useful
2797         information about the memory leaks.
2798
2799         * Scripts/webkitpy/port/gtk.py:
2800         (GtkPort.__init__):
2801         (GtkPort.setup_test_run): Clear the previous output files before new
2802         run.
2803         (GtkPort.print_leaks_summary):
2804
2805         * Scripts/webkitpy/port/leakdetector_valgrind.py: Added.
2806         Parse the xml files generated by Valgrind and summarise leaks
2807         into an easily understandable list.
2808         (get_text_of):
2809         (get_CDATA_of):
2810         (gather_frames):
2811         (ValgrindError):
2812         (ValgrindError.__init__):
2813         (ValgrindError.__str__):
2814         (ValgrindError.unique_string):
2815         (ValgrindError.error_hash):
2816         (ValgrindError.__hash__):
2817         (ValgrindError.__eq__):
2818         (LeakDetectorValgrind):
2819         (LeakDetectorValgrind.__init__):
2820         (LeakDetectorValgrind._parse_leaks_output):
2821         (LeakDetectorValgrind.leaks_files_in_results_directory):
2822         (LeakDetectorValgrind.clean_leaks_files_from_results_directory):
2823         (LeakDetectorValgrind.parse_and_print_leaks_detail):
2824
2825         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Added.
2826         (make_mock_valgrind_output):
2827         (make_mock_incomplete_valgrind_output):
2828         (make_mock_valgrind_results):
2829         (make_mock_valgrind_results_incomplete):
2830         (make_mock_valgrind_results_empty):
2831         (make_mock_valgrind_results_misformatted):
2832         (mock_run_cppfilt_command):
2833         (LeakDetectorValgrindTest):
2834         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
2835         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
2836         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
2837         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
2838         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
2839         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
2840         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
2841         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
2842
2843 2014-01-13  Lucas Forschler  <lforschler@apple.com>
2844
2845         Update the LLINT CLoop Bot build infrastructure
2846         https://bugs.webkit.org/show_bug.cgi?id=126604
2847         
2848         Unreviewed.
2849         
2850         * BuildSlaveSupport/build.webkit.org-config/config.json:
2851         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2852         (CompileLLINTCLoop):
2853         (RunLLINTCLoopTests):
2854         (BuildAndTestLLINTCLoopFactory):
2855         (BuildAndTestLLINTCLoopFactory.__init__):
2856
2857 2014-01-13  Jinwoo Song  <jinwoo7.song@samsung.com>
2858
2859         [EFL][WK2] Disable failing API tests
2860         https://bugs.webkit.org/show_bug.cgi?id=126960
2861
2862         Reviewed by Gyuyoung Kim.
2863
2864         Disable WKViewUserViewportToContents test until bug 126261 is resolved.
2865
2866         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
2867         (TestWebKitAPI::TEST):
2868
2869 2014-01-13  Daniel Batyai  <dbatyai.u-szeged@partner.samsung.com>
2870
2871         Remove wdiff
2872         https://bugs.webkit.org/show_bug.cgi?id=124766
2873
2874         Reviewed by Ryosuke Niwa.
2875
2876         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
2877         (ResultsJSONParserTest):
2878         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2879         (TestResultWriter):
2880         (TestResultWriter.create_text_diff_and_write_result):
2881         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2882         (summarize_results):
2883         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2884         (RunTest.test_output_diffs):
2885         * Scripts/webkitpy/port/base.py:
2886         (Port.__init__):
2887         (Port.driver_stop_timeout):
2888         (Port.check_image_diff):
2889         (Port.repository_paths):
2890         (Port._path_to_lighttpd_php):
2891         * Scripts/webkitpy/port/base_unittest.py:
2892         (PortTest.test_default_child_processes):
2893         (PortTest.test_pretty_patch_script_error):
2894         * Scripts/webkitpy/port/port_testcase.py:
2895         (PortTestCase.test_diff_image_crashed):
2896         * Scripts/webkitpy/port/test.py:
2897         (TestPort.operating_system):
2898
2899 2014-01-13  Martin Robinson  <mrobinson@igalia.com>
2900
2901         Build fix for the GTK+ CMake port
2902
2903         * TestWebKitAPI/PlatformGTK.cmake: The WKConnection test is no longer with us.
2904
2905 2014-01-13  Adrian Perez de Castro  <aperez@igalia.com>
2906
2907         [GTK] Add cast in call to g_object_add_weak_pointer in MiniBrowser
2908         https://bugs.webkit.org/show_bug.cgi?id=126881
2909
2910         Reviewed by Carlos Garcia Campos.
2911
2912         * MiniBrowser/gtk/BrowserWindow.c:
2913         (browser_window_new):
2914         Explicitly cast GtkWindow** to gpointer* in call to
2915         g_object_add_weak_pointer to avoid compiler warnings.
2916
2917 2014-01-13  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2918
2919         Remove parsing of old-run-webkit-tests output from master.cfg
2920         https://bugs.webkit.org/show_bug.cgi?id=126690
2921
2922         Reviewed by Csaba Osztrogonác.
2923
2924         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2925         Removed parsing of ORWT output, as it is not used anymore.
2926         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2927         Updated unit tests accordingly.
2928
2929 2014-01-13  Commit Queue  <commit-queue@webkit.org>
2930
2931         Unreviewed, rolling out r161808.
2932         http://trac.webkit.org/changeset/161808
2933         https://bugs.webkit.org/show_bug.cgi?id=126874
2934
2935         This patch make several files to be always regenerated on
2936         every make (Requested by KaL on #webkit).
2937
2938         * WebKitTestRunner/GNUmakefile.am:
2939
2940 2014-01-13  Adrian Perez de Castro  <aperez@igalia.com>
2941
2942         [GTK] Make MiniBrowser windows non-transient by default
2943         https://bugs.webkit.org/show_bug.cgi?id=126840
2944
2945         Reviewed by Carlos Garcia Campos.
2946
2947         Instead of making new browser windows transient as soon as they are
2948         created, save the pointer to the parent window and set the transient
2949         state later on when handling the "run-as-modal" signal. This makes
2950         it easier to use the MiniBrowser to do tests involving multiple
2951         windows, and will be useful as well when multi-web-process mode is
2952         enabled for the GTK port.
2953
2954         * MiniBrowser/gtk/BrowserWindow.c:
2955         (webViewRunAsModal): Set the parent window using
2956         gtk_window_set_transient_for() using the saved parent
2957         window.
2958         (browser_window_new): Save the parent window using
2959         g_object_set_data() instead of making the new window
2960         transient immediately.
2961
2962 2014-01-12  Sergio Correia  <sergio.correia@openbossa.org>
2963
2964         [EFL][WK2] Make API tests work again
2965         https://bugs.webkit.org/show_bug.cgi?id=126769
2966
2967         Reviewed by Gyuyoung Kim.
2968
2969         The EFL and WK2 test binaries are currently being generated at *TestWebKitAPI/
2970         [E]WebKit2, respectively, and this causes problems because the logic to find
2971         where WebProcess is to look in the same directory of the running process and
2972         then proceed to use LIBEXECDIR (typically /usr/loca/bin).
2973
2974         This patch introduces a WEBKIT_EXEC_PATH environment variable, inspired in the
2975         Gtk port, which allows us to look for WebProcess initially in this directory,
2976         if it's defined.
2977
2978         * TestWebKitAPI/efl/main.cpp:
2979         (main): Define WEBKIT_EXEC_PATH to be used by WebKit2 API tests.
2980
2981 2014-01-12  Daniel Bates  <dabates@apple.com>
2982
2983         [iOS] Fix the build
2984
2985         For now, ensure we build WebKit System Interface before we build WebKit.
2986         We'll remove this constraint and the constraint to build WebKit Additions
2987         in a subsequent commit.
2988
2989         * Scripts/build-webkit:
2990
2991 2014-01-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2992
2993         Unreviewed. Fix make distcheck.
2994
2995         * gtk/GNUmakefile.am: Add generate-inspector-gresource-manifest.py
2996         to EXTRA_DIST.
2997
2998 2014-01-12  Tobias Mueller  <tobiasmue@gnome.org>
2999
3000         --disable-dependency-tracking causes build failure due to missing directories
3001         https://bugs.webkit.org/show_bug.cgi?id=94488
3002
3003         Reviewed by Gustavo Noronha Silva.
3004
3005         Autotools build fix: Ensure output directory existing
3006         before generating DerivedSources. This allows for
3007         --disable-dependency-tracking to be run.
3008
3009
3010         * WebKitTestRunner/GNUmakefile.am: Added a new target of the directory in which files are meant to be stored.
3011
3012 2014-01-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3013
3014         [GTK] Fix return value of WebKitDownload::created-destination
3015         https://bugs.webkit.org/show_bug.cgi?id=126741
3016
3017         Reviewed by Martin Robinson.
3018
3019         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp: Fix return
3020         value of several callbacks.
3021
3022 2014-01-11  Sam Weinig  <sam@webkit.org>
3023
3024         Add support for null StringViews
3025         https://bugs.webkit.org/show_bug.cgi?id=126827
3026
3027         Reviewed by Anders Carlsson.
3028
3029         Add new test for StringView.
3030
3031         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3032         * TestWebKitAPI/Tests/WTF/StringView.cpp: Added.
3033         (TestWebKitAPI::TEST):
3034
3035 2014-01-10  Benjamin Poulain  <bpoulain@apple.com>
3036
3037         Remove the BlackBerry port from trunk
3038         https://bugs.webkit.org/show_bug.cgi?id=126715
3039
3040         Reviewed by Anders Carlsson.
3041
3042         * DumpRenderTree/DumpRenderTree.h:
3043         * DumpRenderTree/PixelDumpSupport.cpp:
3044
3045 2014-01-10  Daniel Bates  <dabates@apple.com>
3046
3047         [iOS] Fix project build order
3048
3049         Ensure we build WebKitAdditions before WebCore (if applicable). Also, we don't
3050         build WebInspectorUI, Tools/MiniBrowser, or Tools/WebKitTestRunner on iOS at the
3051         time of writing.
3052
3053         * Scripts/build-webkit:
3054
3055 2014-01-10  Mario Sanchez Prada  <mario.prada@samsung.com>
3056
3057         Move platformName property from testRunner to accessibilityController
3058         https://bugs.webkit.org/show_bug.cgi?id=126689
3059
3060         Reviewed by Chris Fleizach.
3061
3062         Move the platformName property from the testRunner into
3063         accessibilityController, since this is a concept that has only be
3064         used by accessibility tests since it got added, and also because
3065         the real intention was not to distinguish among "ports" (mac, win,
3066         gtk, efl) but between platforms (atk, mac, win).
3067
3068         This change will be very useful to merge GTK's roles-exposed.html
3069         and Mac's role-subrole-roledescription.html into one single test,
3070         since we will be specifying in the test itself which elements are
3071         supported in which accessibility "platform". In this context,
3072         being able to check accessibilityController.platformName directly
3073         against a list of supported accessibility platforms (e.g. "atk,mac")
3074         will certainly maintain the code cleaner and simpler.
3075
3076         * DumpRenderTree/TestRunner.h:
3077         (TestRunner::platformName): Removed.
3078         * DumpRenderTree/TestRunner.cpp:
3079         (getPlatformNameCallback): Removed.
3080         (TestRunner::staticValues): Removed platformName
3081         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3082         (TestRunner::platformName): Removed.
3083         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3084         (TestRunner::platformName): Removed.
3085         * DumpRenderTree/mac/TestRunnerMac.mm:
3086         (TestRunner::platformName): Removed.
3087         * DumpRenderTree/win/TestRunnerWin.cpp:
3088         (TestRunner::platformName): Removed.
3089
3090         * DumpRenderTree/AccessibilityController.h:
3091         (AccessibilityController::platformName): Added.
3092         * DumpRenderTree/AccessibilityController.cpp:
3093         (getPlatformNameCallback): Added.
3094         (AccessibilityController::getJSClass): Added platformName.
3095         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
3096         (AccessibilityController::platformName): Added, returning "atk".
3097         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3098         (AccessibilityController::platformName): Ditto, returning "mac".
3099         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
3100         (AccessibilityController::platformName): Ditto, returning "ios".
3101         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3102         (AccessibilityController::platformName): Ditto, returning "win".
3103
3104         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3105         (platformName): Removed.
3106         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3107         (TestRunner::platformName): Removed.
3108         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
3109         (TestRunner::platformName): Removed.
3110         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
3111         (TestRunner::platformName): Removed.
3112         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
3113         (TestRunner::platformName): Removed.
3114         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
3115         (TestRunner::platformName): Removed.
3116
3117         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
3118         (WTR:AccessibilityController::platformName): Added.
3119         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
3120         (platformName): Added.
3121         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
3122         (WTR::AccessibilityController::platformName): Added, returning "atk".
3123         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
3124         (WTR::AccessibilityController::platformName): Added, returning "mac".
3125
3126 2014-01-10  Benjamin Poulain  <bpoulain@apple.com>
3127
3128         Remove the BlackBerry port from trunk
3129         https://bugs.webkit.org/show_bug.cgi?id=126715
3130
3131         Reviewed by Anders Carlsson.
3132
3133         * Scripts/webkitpy/common/config/watchlist:
3134
3135 2014-01-09  Benjamin Poulain  <bpoulain@apple.com>
3136
3137         Remove the BlackBerry files outside WebCore
3138         https://bugs.webkit.org/show_bug.cgi?id=126715
3139
3140         Reviewed by Anders Carlsson.
3141
3142         * DumpRenderTree/blackberry: Removed.
3143
3144 2014-01-10  Simon Fraser  <simon.fraser@apple.com>
3145
3146         Remove knowledge of Blackberry from build scripts
3147         https://bugs.webkit.org/show_bug.cgi?id=126766
3148
3149         Reviewed by Anders Carlsson.
3150         
3151         Remove isBlackBerry() and references to it, and rmeove
3152         blackberry-related stuff from the watchlist.
3153
3154         * Scripts/build-webkit:
3155         * Scripts/webkit-build-directory:
3156         * Scripts/webkitdirs.pm:
3157         (determineBaseProductDir):
3158         (argumentsForConfiguration):
3159         (builtDylibPathForName):
3160         (isAppleWebKit):
3161         (buildCMakeProjectOrExit):
3162         (cmakeBasedPortArguments):
3163         (cmakeBasedPortName):
3164         * Scripts/webkitperl/FeatureList.pm:
3165         * Scripts/webkitpy/common/config/watchlist:
3166
3167 2014-01-10  Daniel Bates  <dabates@apple.com>
3168
3169         [iOS] Fix up simulator build and enable default features
3170
3171         Rubber-stamped by Joseph Pecoraro.
3172
3173         * Scripts/webkitdirs.pm:
3174         (determineArchitecture):
3175         (determinePassedArchitecture):
3176         * Scripts/webkitperl/FeatureList.pm: Also expose command line option to toggle ENABLE_PLUGIN_PROXY_FOR_VIDEO (enabled
3177         by default only in iOS).
3178
3179 2014-01-10  Daniel Bates  <dabates@apple.com>
3180
3181         [iOS] Upstream WebCore and Tools miscellaneous changes
3182         https://bugs.webkit.org/show_bug.cgi?id=126698
3183
3184         Reviewed by David Kilzer.
3185
3186         * Scripts/check-for-inappropriate-objc-class-names:
3187         * Scripts/check-for-webkit-framework-include-consistency:
3188
3189 2014-01-09  Dan Bernstein  <mitz@apple.com>
3190
3191         [Cocoa] Promote WKBackForwardList{,Item}.h to public
3192         https://bugs.webkit.org/show_bug.cgi?id=126707
3193
3194         Reviewed by Sam Weinig.
3195
3196         * Scripts/check-for-webkit-framework-include-consistency: Account for stale private headers
3197         left behind in the build products directory after a private header is made public.
3198
3199 2014-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
3200
3201         [SOUP] Partial file left on disk after a download fails or is cancelled in WebKit2
3202         https://bugs.webkit.org/show_bug.cgi?id=126686
3203
3204         Reviewed by Martin Robinson.
3205
3206         Test that partial files are not left on disk after a download has
3207         been cancelled after the destination has been decided. To make
3208         sure the download is cancelled after the destination has been
3209         decided and before the operation finishes, we cancel the download
3210         in the destination decided callback, and we use an infinite
3211         resource that writes chunks to the response body and never
3212         completes the body.
3213
3214         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
3215         (addContentDispositionHTTPHeaderToResponse): Helper function to
3216         add the Content-Disposition to the response headers.
3217         (writeNextChunkIdle): Write next chunk to response body.
3218         (writeNextChunk): Write next chunk in an idle to avoid flooding
3219         the network with the inifnite resource.
3220         (serverCallback): Add an inifinite resource.
3221         (testDownloadRemoteFileError): Check that partial file is not
3222         present after the download has been cancelled.
3223
3224 2014-01-09  Roland Takacs  <rtakacs@inf.u-szeged.hu>
3225
3226         Move myself to the committers list.
3227
3228         Unreviewed.
3229
3230         * Scripts/webkitpy/common/config/contributors.json:
3231
3232 2014-01-08  Seokju Kwon  <seokju@webkit.org>
3233
3234         [GTK] Unreviewed build fix after r161522.
3235
3236         * TestWebKitAPI/GNUmakefile.am: Remove WKConnection.cpp and WKConnection_Bundle.cpp.
3237
3238 2014-01-08  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
3239
3240         Missleading style error when mixing system and non-system header include lines.
3241         https://bugs.webkit.org/show_bug.cgi?id=126564
3242
3243         Reviewed by Ryosuke Niwa.
3244
3245         * Scripts/webkitpy/style/checkers/cpp.py:
3246         (check_include_line):
3247         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3248         (OrderOfIncludesTest.test_check_alphabetical_include_order):
3249         (OrderOfIncludesTest.test_public_primary_header):
3250
3251 2014-01-08  Seokju Kwon  <seokju@webkit.org>
3252
3253         [EFL] Unreviewed build fix after r161522.
3254
3255         * TestWebKitAPI/CMakeLists.txt:
3256         * TestWebKitAPI/PlatformEfl.cmake:
3257
3258 2014-01-08  Anders Carlsson  <andersca@apple.com>
3259
3260         Remove WKConnectionRef tests
3261         https://bugs.webkit.org/show_bug.cgi?id=126666
3262
3263         Reviewed by Dan Bernstein.
3264
3265         The WKConnectionRef is poorly designed but thankfully not used anywhere. 
3266         Remove the API tests as a first step towards killing the entire thing.
3267
3268         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3269         * TestWebKitAPI/Tests/WebKit2/WKConnection.cpp: Removed.
3270         * TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp: Removed.
3271
3272 2014-01-08  Commit Queue  <commit-queue@webkit.org>
3273
3274         Unreviewed, rolling out r161512.
3275         http://trac.webkit.org/changeset/161512
3276         https://bugs.webkit.org/show_bug.cgi?id=126655
3277
3278         Broke webkitpy tests (Requested by ap on #webkit).
3279
3280         * Scripts/webkitpy/port/gtk.py:
3281         (GtkPort.__init__):
3282         (GtkPort.setup_test_run):
3283         (GtkPort._port_specific_expectations_files):
3284         * Scripts/webkitpy/port/leakdetector_valgrind.py: Removed.
3285         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Removed.
3286
3287 2014-01-08  Commit Queue  <commit-queue@webkit.org>
3288
3289         Unreviewed, rolling out r161517.
3290         http://trac.webkit.org/changeset/161517
3291         https://bugs.webkit.org/show_bug.cgi?id=126659
3292
3293         The fix didn't completely remove the problem and is now
3294         standing in the way of the rollout of the offending patch
3295         (Requested by zdobersek on #webkit).
3296
3297         * Scripts/webkitpy/port/gtk.py:
3298         (GtkPort.__init__):
3299
3300 2014-01-08  Zan Dobersek  <zdobersek@igalia.com>
3301
3302         Unreviewed. Attempting to fix webkitpy tests after r161512.
3303
3304         * Scripts/webkitpy/port/gtk.py:
3305         (GtkPort.__init__): Construct LeakDetectorValgrin only if leak detection is enabled.
3306
3307 2014-01-08  Brian Holt  <brian.holt@samsung.com>
3308
3309         [GTK] Parse Valgrind xml leak files
3310         https://bugs.webkit.org/show_bug.cgi?id=119446
3311
3312         Reviewed by Alejandro G. Castro.
3313
3314         Parse the xml files generated by Valgrind to yield useful
3315         information about the memory leaks.
3316
3317         * Scripts/webkitpy/port/gtk.py:
3318         (GtkPort.__init__):
3319         (GtkPort.setup_test_run): Clear the previous output files before new
3320         run.
3321         (GtkPort.print_leaks_summary):
3322
3323         * Scripts/webkitpy/port/leakdetector_valgrind.py: Added.
3324         Parse the xml files generated by Valgrind and summarise leaks
3325         into an easily understandable list.
3326         (get_text_of):
3327         (get_CDATA_of):
3328         (gather_frames):
3329         (ValgrindError):
3330         (ValgrindError.__init__):
3331         (ValgrindError.__str__):
3332         (ValgrindError.unique_string):
3333         (ValgrindError.error_hash):
3334         (ValgrindError.__hash__):
3335         (ValgrindError.__eq__):
3336         (LeakDetectorValgrind):
3337         (LeakDetectorValgrind.__init__):
3338         (LeakDetectorValgrind._parse_leaks_output):
3339         (LeakDetectorValgrind.leaks_files_in_results_directory):
3340         (LeakDetectorValgrind.clean_leaks_files_from_results_directory):
3341         (LeakDetectorValgrind.parse_and_print_leaks_detail):
3342
3343         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Added.
3344         (make_mock_valgrind_output):
3345         (make_mock_incomplete_valgrind_output):
3346         (make_mock_valgrind_results):
3347         (make_mock_valgrind_results_incomplete):
3348         (make_mock_valgrind_results_empty):
3349         (make_mock_valgrind_results_misformatted):
3350         (LeakDetectorValgrindTest):
3351         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
3352         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
3353         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
3354         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
3355         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
3356         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
3357         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
3358         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
3359
3360 2014-01-08  Commit Queue  <commit-queue@webkit.org>
3361
3362         Unreviewed, rolling out r161427.
3363         http://trac.webkit.org/changeset/161427
3364         https://bugs.webkit.org/show_bug.cgi?id=126645
3365
3366         Emits a stye error on any newly added files (Requested by ap
3367         on #webkit).
3368
3369         * Scripts/webkitpy/style/checkers/cpp.py:
3370         (check_style):
3371         (CppChecker):
3372         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3373         (WebKitStyleTest.test_other):
3374
3375 2014-01-08  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
3376
3377         Remove run-webkit-tests wrapper script as all platform are using NRWT now.
3378         https://bugs.webkit.org/show_bug.cgi?id=126580
3379
3380         Reviewed by Csaba Osztrogonác.
3381
3382         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3383         (RunWebKitTests): Passing --debug-rwt-logging here instead of the
3384         run-webkit-tests script.
3385         * Scripts/new-run-webkit-tests: Renamed to run-webkit-tests.
3386         * Scripts/run-webkit-tests: Removed, as it was just a temporary hack.
3387
3388 2014-01-08  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
3389
3390         Update the list of non-committer u-szeged contributors
3391         https://bugs.webkit.org/show_bug.cgi?id=126640
3392
3393         Reviewed by Csaba Osztrogonác.
3394
3395         * Scripts/webkitpy/common/config/contributors.json:
3396
3397 2014-01-08  Alberto Garcia  <berto@igalia.com>
3398
3399         Fix some compilation warnings
3400         https://bugs.webkit.org/show_bug.cgi?id=126635
3401
3402         Reviewed by Csaba Osztrogonác.
3403
3404         * GtkLauncher/main.c:
3405         (createWindow): This function is not supposed to receive any
3406         parameter, yet we are passing one.
3407
3408 2014-01-08  Brian Holt  <brian.holt@samsung.com>
3409
3410         [GTK][WK2] unskip passing unit tests
3411         https://bugs.webkit.org/show_bug.cgi?id=126637
3412
3413         Reviewed by Carlos Garcia Campos.
3414
3415         Unskip TestResources and TestAuthentication unit tests since they
3416         are passing both under Xvfb and X.
3417
3418         * Scripts/run-gtk-tests:
3419         (TestRunner):
3420
3421 2014-01-08  Alberto Garcia  <berto@igalia.com>
3422
3423         REGRESSION(r160304): [GTK] Disable libtool fast install
3424         https://bugs.webkit.org/show_bug.cgi?id=126381
3425
3426         Reviewed by Gustavo Noronha Silva.
3427
3428         Disable the libtool fast-install mode in developer/test builds.
3429
3430         In this mode binaries are generated ready to be used directly from
3431         the build tree. Otherwise they would need to be relinked when they
3432         are executed, which can take a lot of resources, particularly in
3433         debug builds.
3434
3435         * Scripts/webkitdirs.pm:
3436         (runAutogenForAutotoolsProjectIfNecessary):
3437
3438 2014-01-08  Zan Dobersek  <zdobersek@igalia.com>
3439
3440         Unreviewed GTK gardening.
3441
3442         * Scripts/run-gtk-tests:
3443         (TestRunner): Skipping the snapshot test case from the TestWebKitWebView test suite.
3444         The test is failing due to issues with Xvfb, with the problem being handled in bug #120404.
3445
3446 2014-01-07  Lucas Forschler  <lforschler@apple.com>
3447
3448         Add buildbot infrasctructure for building and testing JSC cloop
3449         https://bugs.webkit.org/show_bug.cgi?id=126604
3450
3451         Reviewed by Geoffrey Garen.
3452
3453         * BuildSlaveSupport/build.webkit.org-config/config.json:
3454         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3455         (CompileCLOOP):
3456         (RunCLOOPTests):
3457         (RunCLOOPTests.countFailures):
3458         (BuildAndTestCLOOP):
3459
3460 2014-01-07  Brian Burg  <bburg@apple.com>
3461
3462         Unreviewed. Add myself as a committer.
3463
3464         * Scripts/webkitpy/common/config/contributors.json:
3465
3466 2014-01-07  Alexey Proskuryakov  <ap@apple.com>
3467
3468         Popovers at build.webkit.org/dashboard could have titles
3469         https://bugs.webkit.org/show_bug.cgi?id=126495
3470
3471         Reviewed by Timothy Hatcher.
3472
3473         Added titles to all popovers except for pending revisions one, which I would like
3474         to improve more (probably add an ETA).
3475
3476         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
3477         (BuildbotBuilderQueueView.prototype._presentPopoverFailureLogs): Moved code for 
3478         adding a title to base class.
3479
3480         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3481         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Moved code for inserting
3482         a divider to a separate function.
3483         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Added a title.
3484         (BuildbotQueueView.prototype._presentNoChangePopover): Updated the text to match
3485         title from above function.
3486         (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Renamed "contentElement"
3487         variable to "content" to match all other code.
3488         (BuildbotQueueView.prototype._addIterationHeadingToPopover): Added.
3489         (BuildbotQueueView.prototype._addDividerToPopover): Added.
3490
3491         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3492         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions): Add a title.
3493         (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions): Ditto.
3494         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): Ditto.
3495
3496         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
3497
3498 2014-01-07  Alexey Proskuryakov  <ap@apple.com>
3499
3500         There should be a delay when quickly switching to a different popover at build.webkit.org/dashboard
3501         https://bugs.webkit.org/show_bug.cgi?id=126472
3502
3503         Reviewed by Timothy Hatcher.
3504
3505         Added a delay when quickly switching to a different popover, making it easier to
3506         move mouse pointer from active element to its popover without accidentally opening
3507         a different popover.
3508
3509         Used this code to add a delay before creating a popover. This doesn't change UI
3510         behavior, as there was alerady a delay before it became visible, but it avoids
3511         flooding buildbot server with http requests when quickly moving the mouse over
3512         dashboard page.
3513
3514         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js:
3515         Fixed a case where popover could get stuck. If content was updated while fade-out
3516         transition was already in place, the transition was removed for no good reason.
3517
3518         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
3519         (PopoverTracker._onblur): While at it, also taught popovers to disappear on window blur.
3520
3521         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:
3522         (.popover.step-in): Now that PopoverTracker has a 200ms delay of its own, reduced
3523         popover delay from 1s to 800ms.
3524
3525 2014-01-07  Alexey Proskuryakov  <ap@apple.com>
3526
3527         Improve display of failed builds at build.webkit.org/dashboard
3528         https://bugs.webkit.org/show_bug.cgi?id=126542
3529         <rdar://problem/15753550>
3530
3531         Reviewed by Timothy Hatcher.
3532
3533         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
3534         Instead of hardcoding step name, look for the first step that failed.
3535         While at it, added a popover with more links. There are multiple, and it's good
3536         to have a choice of which one to look at in each situation.
3537
3538         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3539         (BuildbotIteration.prototype.get successful): Being successful is not the opposite
3540         of having failed. Many iterations are interrupted for whatever reason internal to
3541         Buildbot, and these are suppoed to be orange, not red.
3542         (BuildbotIteration.prototype.get productive): Changed to exclude inerrupted iterations,
3543         not only WillRetry ones.
3544         (BuildbotIteration.prototype.get failed): Changed to only include iterations that
3545         actually failed, more likely indicating a problem with code base.
3546         (BuildbotIteration.prototype.get firstFailedStepName):
3547         (BuildbotIteration.prototype.failureLogURL): Expose informaiton about failure.
3548         (BuildbotIteration.prototype.get failureLogs): Ditto.
3549         (BuildbotIteration.prototype.update): Store complete results for the failed step.
3550         Not every failure stops the iteration, so we could have multiple failed steps,
3551         but let's see if seeing just the first one will be enough.
3552
3553         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3554         (BuildbotQueue.prototype.get firstRecentUnsuccessfulIteration): Updated to work in
3555         terms of successful iterations.
3556         (BuildbotQueue.prototype.get mostRecentSuccessfulIteration): Ditto.
3557
3558         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3559         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Updated to work in
3560         terms of successful iterations.
3561
3562         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3563         Removed code to create a path to build output, we now take it from results JSON.
3564
3565         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
3566         Added styles for the new popover.
3567
3568 2014-01-07  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
3569
3570         defined constants should use all uppercase names with words separated by underscores.
3571         https://bugs.webkit.org/show_bug.cgi?id=126055
3572
3573         Reviewed by Alexey Proskuryakov.
3574
3575         * Scripts/webkitpy/style/checkers/cpp.py:
3576         (check_style):
3577         (CppChecker):
3578         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3579         (WebKitStyleTest.test_define_constants):
3580
3581 2014-01-07  Brian Holt  <brian.holt@samsung.com>
3582
3583         Unreviewed. Add myself as a committer.
3584
3585         * Scripts/webkitpy/common/config/contributors.json:
3586
3587 2014-01-07  Csaba Osztrogonác  <ossy@webkit.org>
3588
3589         Remove the WinCE buildbot from build.webkit.org
3590         https://bugs.webkit.org/show_bug.cgi?id=126517
3591
3592         Reviewed by Alexey Proskuryakov.
3593
3594         * BuildSlaveSupport/build.webkit.org-config/config.json:
3595         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3596         (appendCustomBuildFlags):
3597
3598 2014-01-07  Krzysztof Czech  <k.czech@samsung.com>
3599
3600         [EFL] Change ATK version to 2.11.4
3601         https://bugs.webkit.org/show_bug.cgi?id=126573
3602
3603         Reviewed by Gyuyoung Kim.
3604
3605         ATK 2.11.4 introduces some new roles, that are already being used by WebKit.
3606
3607         * efl/jhbuild.modules: