2011-01-10 Tony Chang <tony@chromium.org>
[WebKit-https.git] / Tools / ChangeLog
1 2011-01-10  Tony Chang  <tony@chromium.org>
2
3         Unreviewed, rolling out r75398.
4         http://trac.webkit.org/changeset/75398
5         https://bugs.webkit.org/show_bug.cgi?id=52008
6
7         Some layout tests are crashing on Chromium Win.
8
9         * DumpRenderTree/chromium/WebViewHost.cpp:
10         (WebViewHost::updatePaintRect):
11         * DumpRenderTree/chromium/WebViewHost.h:
12
13 2011-01-10  Adam Roben  <aroben@apple.com>
14
15         Roll out r75392
16
17         It isn't needed now that r75289 has been rolled out.
18
19         * Scripts/run-javascriptcore-tests:
20
21 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
22
23         Reviewed by Anders Carlsson.
24
25         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
26         https://bugs.webkit.org/show_bug.cgi?id=52160
27
28         * WebKitTestRunner/mac/TestControllerMac.mm:
29         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
30         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
31         anyway.
32
33 2011-01-10  Tony Chang  <tony@chromium.org>
34
35         Reviewed by Mihai Parparita.
36
37         [chromium] fix for animated gif layout tests
38         https://bugs.webkit.org/show_bug.cgi?id=52008
39
40         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
41             to trigger gif animations.
42         (WebViewHostPaintTask::WebViewHostPaintTask):
43         (WebViewHostPaintTask::runIfValid):
44         (WebViewHost::updatePaintRect):
45         * DumpRenderTree/chromium/WebViewHost.h:
46         (WebViewHost::taskList):
47
48 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
49
50         Reviewed by Xan Lopez.
51
52         [GTK] Fix gtk2 compilation for master
53         https://bugs.webkit.org/show_bug.cgi?id=51885
54
55         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
56         (createBitmapContextFromWebView): Replaced the old
57         gdk_drawable_get_size with gdk_pixmap_get_size.
58
59 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
60
61         Reviewed by Laszlo Gombos.
62
63         [WINCE] Reenable NPAPI after r75203
64         https://bugs.webkit.org/show_bug.cgi?id=52109
65
66         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
67         it with !isEfl(), because EFL port does not support NPAPI (yet).
68
69         * Scripts/build-webkit:
70
71 2011-01-10  Adam Roben  <aroben@apple.com>
72
73         Skip some asserting JS tests
74
75         See <http://webkit.org/b/52156>.
76
77         * Scripts/run-javascriptcore-tests:
78
79 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
80
81         Reviewed by Xan Lopez.
82
83         [GTK] build-webkit disable Blob support via arguments passed to automake
84         https://bugs.webkit.org/show_bug.cgi?id=52097
85
86         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
87         build-webkit.
88
89 2011-01-10  Adam Roben  <aroben@apple.com>
90
91         Use the same name and description for TestNetscapePlugin on Windows and
92         Mac
93
94         Fixes <http://webkit.org/b/52151>
95         fast/frames/iframe-reparenting-plugins.html fails on Windows
96
97         Reviewed by Steve Falkenburg.
98
99         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
100         the name and description from Mac's Info.plist.
101
102 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
103
104         Reviewed by Laszlo Gombos.
105
106         [Qt][WK2] Guard gcc-specific syntax
107
108         Non-gcc based compliers choke on the "-include"
109         syntax for preinclude, place guard around it.
110
111         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
112         * WebKitTestRunner/qt/WebKitTestRunner.pro:
113
114 2011-01-10  Andreas Kling  <kling@webkit.org>
115
116         Reviewed by Simon Hausmann.
117
118         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
119         https://bugs.webkit.org/show_bug.cgi?id=52111
120
121         When getting a createNewPage() callback from QWKPage, create the
122         new page with the same QWKContext as the page that is passed to
123         the callback.
124
125         * MiniBrowser/qt/BrowserView.h:
126         * MiniBrowser/qt/BrowserWindow.cpp:
127         (newPageFunction):
128         (BrowserWindow::BrowserWindow):
129         * MiniBrowser/qt/BrowserWindow.h:
130
131 2011-01-10  Andreas Kling  <kling@webkit.org>
132
133         Reviewed by Kenneth Rohde Christiansen.
134
135         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
136
137         BrowserView set its own useless createNewPage() callback on QWKPage.
138         This was immediately overridden by BrowserWindow anyway, so remove
139         the BrowserView one.
140
141         * MiniBrowser/qt/BrowserView.cpp:
142         (BrowserView::BrowserView):
143
144 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
145
146         Reviewed by Jeremy Orlow.
147
148         [Chromium] Remove non-client-based Geolocation code
149         https://bugs.webkit.org/show_bug.cgi?id=50921
150
151         * DumpRenderTree/chromium/LayoutTestController.cpp:
152         (LayoutTestController::setGeolocationPermission):
153         (LayoutTestController::setMockGeolocationPosition):
154         (LayoutTestController::setMockGeolocationError):
155         * DumpRenderTree/chromium/WebViewHost.cpp:
156         (WebViewHost::geolocationClientMock):
157         (WebViewHost::reset):
158         * DumpRenderTree/chromium/WebViewHost.h:
159
160 2011-01-10  Eric Seidel  <eric@webkit.org>
161
162         Reviewed by Adam Barth.
163
164         Commit bot tried to land r? cq+ patch
165         https://bugs.webkit.org/show_bug.cgi?id=36638
166
167         It should now be possible to post a patch with r? and cq+ and the
168         commit-queue will correctly wait for the r+ before attempting to land the patch.
169         (This was a feature requested by several users.)
170
171         One caveat: We don't actually reject r-, cq+ patches from the queue
172         (we just ignore them), but I think that's OK for now.
173
174         I also noticed that setting r- once a commit-queue node had grabbed
175         a patch would not properly cancel the landing.  That's fixed and
176         tested in this patch.
177
178         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
179         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
180         * Scripts/webkitpy/tool/bot/feeders.py:
181         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
182
183 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
184
185         Reviewed by Kenneth Rohde Christiansen.
186
187         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
188         https://bugs.webkit.org/show_bug.cgi?id=51934
189
190         When accessing the network from the destructor of QWebPage, the network access manager
191         was already deleted because the object WebPage was already destructed.
192
193         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
194         The object is now destructed in the destructor of QObject.
195
196         * QtTestBrowser/webpage.cpp:
197         (WebPage::WebPage):
198         (WebPage::setQnamThreaded):
199         * QtTestBrowser/webpage.h:
200         (QtNAMThread::QtNAMThread):
201
202 2011-01-08  Eric Seidel  <eric@webkit.org>
203
204         Reviewed by Ojan Vafai.
205
206         test_failures.py should not mention TestShell (long live DumpRenderTree!)
207         https://bugs.webkit.org/show_bug.cgi?id=52067
208
209         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
210         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
211
212         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
213
214 2011-01-08  Eric Seidel  <eric@webkit.org>
215
216         Reviewed by Mihai Parparita.
217
218         commit-queue hangs when the ChangeLog diff is bad
219         https://bugs.webkit.org/show_bug.cgi?id=52072
220
221         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
222         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
223
224 2011-01-08  Adam Barth  <abarth@webkit.org>
225
226         Teach svn-apply how to re-write WebCore to Source/WebCore.
227
228         * Scripts/VCSUtils.pm:
229
230 2011-01-07  Adam Barth  <abarth@webkit.org>
231
232         Rubber-stamped by Eric Seidel.
233
234         Move WebCore to Source
235         https://bugs.webkit.org/show_bug.cgi?id=52050
236
237         Update the tools to understand WebCore's new location.
238
239         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
240         * DumpRenderTree/wscript:
241         * GNUmakefile.am:
242         * Scripts/build-webkit:
243         * Scripts/do-file-rename:
244         * Scripts/do-webcore-rename:
245         * Scripts/generate-qt-inspector-resource:
246         * Scripts/prepare-ChangeLog:
247         * Scripts/run-bindings-tests:
248         * Scripts/update-iexploder-cssproperties:
249         * Scripts/update-sources-list.py:
250         * Scripts/update-webkit-localizable-strings:
251         * Scripts/webkitdirs.pm:
252         * Scripts/webkitpy/common/config/build.py:
253         * Scripts/webkitpy/common/config/build_unittest.py:
254         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
255         * Scripts/webkitpy/style/checker.py:
256         * Scripts/webkitpy/style/checker_unittest.py:
257         * WebKitTestRunner/DerivedSources.pro:
258         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
259         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
260         * wx/browser/wscript:
261         * wx/build/settings.py:
262
263 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
264
265         Reviewed by Sam Weinig.
266
267         Make WebKitTestRunner rest between loads more robust to avoid test crashes
268         https://bugs.webkit.org/show_bug.cgi?id=52086
269
270         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
271         (WTR::InjectedBundle::didReceiveMessage):
272         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
273         (WTR::LayoutTestController::notifyDone):
274         * WebKitTestRunner/TestController.cpp:
275         (WTR::TestController::resetStateToConsistentValues):
276         (WTR::TestController::run):
277
278 2011-01-07  James Robinson  <jamesr@chromium.org>
279
280         Revert "Implement mozilla's animationTime property"
281         https://bugs.webkit.org/show_bug.cgi?id=51952
282
283         This approach isn't quite right.
284
285         * DumpRenderTree/chromium/WebViewHost.cpp:
286         (WebViewHost::paintInvalidatedRegion):
287
288 2011-01-07  Adam Roben  <aroben@apple.com>
289
290         Build master fix
291
292         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
293         (RunWebKitTests.start): Don't try to concatenate a list and a string.
294
295 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
296
297         Reviewed by Csaba Osztrogonác.
298
299         run-qtwebkit-tests should be able to kill a testsuite.
300
301         Add new option in the script that can setup a timeout for a test.
302         If the test execution takes more then specified time then the test
303         would be terminated.
304
305         [Qt] run-qtwebkit-tests needs timeout
306         https://bugs.webkit.org/show_bug.cgi?id=51894
307
308         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
309         * Scripts/run-qtwebkit-tests:
310
311 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
312
313         Unreviewed fix after r75233.
314
315         Based on idea from Eric Seidel.
316
317         Add remote zip file handling to webkitpy.
318         https://bugs.webkit.org/show_bug.cgi?id=50901
319
320         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
321
322 2011-01-07  Shane Stephens  <shanestephens@google.com>
323
324         Reviewed by Eric Seidel.
325
326         svn-apply: should support git binary delta diffs
327         https://bugs.webkit.org/show_bug.cgi?id=38864
328
329         * Scripts/VCSUtils.pm:
330         * Scripts/svn-apply:
331
332 2011-01-06  Julie Parent  <jparent@chromium.org>
333
334         Reviewed by Eric Seidel.
335
336         Test Result Server not removing old results.
337         https://bugs.webkit.org/show_bug.cgi?id=52012
338
339         * TestResultServer/model/jsonresults.py:
340         Fix off-by-one: Truncate if >= num_runs, not just >.
341         * TestResultServer/model/jsonresults_unittest.py:
342         Add unit test to test that merging in a new result with the same value
343         as the last result causes previous result to fall off.
344
345 2011-01-06  James Kozianski  <koz@chromium.org>
346
347         Reviewed by Mihai Parparita.
348
349         Add classes to provide a consistent interface to a set of files.
350         https://bugs.webkit.org/show_bug.cgi?id=50901
351
352         These classes allow us to write code that is agnostic to whether a
353         particular set of files resides in a local directory or in a zip file
354         on a remote machine.
355
356         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
357         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
358         * Scripts/webkitpy/common/system/fileset.py: Added.
359         * Scripts/webkitpy/common/system/filesystem.py:
360         * Scripts/webkitpy/common/system/filesystem_mock.py:
361         * Scripts/webkitpy/common/system/zipfileset.py: Added.
362         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
363
364 2011-01-06  Eric Seidel  <eric@webkit.org>
365
366         Reviewed by Adam Barth.
367
368         NetworkTransaction should log the url it is retrying
369         https://bugs.webkit.org/show_bug.cgi?id=52043
370
371         * Scripts/webkitpy/common/net/networktransaction.py:
372         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
373
374 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
375
376         Windows build fix.
377         Import os before using it.
378
379         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
380
381 2011-01-06  Eric Seidel  <eric@webkit.org>
382
383         Reviewed by Adam Barth.
384
385         StyleQueue fails to report errors when patches have many files
386         https://bugs.webkit.org/show_bug.cgi?id=52042
387
388         This is one of at least two errors preventing style error reporting at the moment.
389         When we moved to passing the list of files to check explicitly,
390         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
391         We could change the type of the QueueStatus.message type, or we could
392         just teach statusserver.py how to clamp values (and warn when it does).
393         I chose the latter path.
394
395         * Scripts/webkitpy/common/net/statusserver.py:
396
397 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
398
399         Reviewed by Stephanie Lewis.
400         
401         Fix syntax error in script.
402
403         Windows bots need to archive/unarchive builds to/from configuration-specific directories
404         https://bugs.webkit.org/show_bug.cgi?id=51996
405
406         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
407
408 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
409
410         Unreviewed, fixing WinCE build after r75196.
411
412         WinCE port does not (yet) support NPAPI.
413
414         * Scripts/build-webkit:
415
416 2011-01-06  Xan Lopez  <xlopez@igalia.com>
417
418         Reviewed by Darin Adler.
419
420         File::Spec->rel2abs in sunspider-compare-results mangles parameters
421         https://bugs.webkit.org/show_bug.cgi?id=52015
422
423         * Scripts/sunspider-compare-results: call rel2abs on our arguments
424         after the platform has been detected, otherwise the script will
425         mangle things like '--gtk' into '/a/path/--gtk', breaking the
426         detection.
427
428 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
429
430         Reviewed by Eric Seidel.
431
432         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
433         https://bugs.webkit.org/show_bug.cgi?id=51346
434
435         * Scripts/build-webkit:
436
437 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
438
439         Reviewed by Adam Roben.
440
441         Windows bots need to archive/unarchive builds to/from configuration-specific directories
442         https://bugs.webkit.org/show_bug.cgi?id=51996
443         
444         After the configuration directory change, we were archiving the incorrect directory for
445         build product, so we were running tests on the wrong binaries.
446         
447         This change archives the correct directory, and also unarchives it into a configuration-
448         specific directory.
449
450         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
451         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
452
453 2011-01-06  Eric Seidel  <eric@webkit.org>
454
455         Reviewed by Mihai Parparita.
456
457         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
458         https://bugs.webkit.org/show_bug.cgi?id=52002
459
460         See an example of this here:
461         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
462
463         It's due to the fact that we pass around TestFailure() instance
464         objects and yet expect them to all compare to be the same.
465
466         This is bad.  We should either have shared instances of these values
467         or we should just pass around the class names.  There are already hacks
468         in place to make TestFailure objects pass equality tests, I just added
469         a __hash__ implementation so they can be used in sets as expected.
470
471         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
472         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
473
474 2011-01-06  Evan Martin  <evan@chromium.org>
475
476         Reviewed by Tony Chang.
477
478         [gdb] handle inaccessible memory and UChar*
479         https://bugs.webkit.org/show_bug.cgi?id=52003
480
481         To pretty-print a UChar*, we just grope around in the memory
482         looking for a terminating NUL.  We need to handle the exception
483         that can occur when we poke into an invalid location.
484
485         Additionally, the logic for choosing which pretty-printer would
486         early return before hitting the point where we'd use the UChar*
487         printer.  (Did this ever work?  How did it regress?)
488
489         * gdb/webkit.py:
490
491 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
492
493         Reviewed by Ada Chan.
494
495         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
496         https://bugs.webkit.org/show_bug.cgi?id=51969
497         
498         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
499
500         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
501         (WTR::InjectedBundlePage::InjectedBundlePage):
502         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
503         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
504
505 2011-01-06  James Robinson  <jamesr@chromium.org>
506
507         Reviewed by Simon Fraser.
508
509         Implement mozilla's animationTime property
510         https://bugs.webkit.org/show_bug.cgi?id=51952
511
512         Chromium DRT support for webkitAnimationTime.
513
514         * DumpRenderTree/chromium/WebViewHost.cpp:
515         (WebViewHost::paintInvalidatedRegion):
516
517 2011-01-06  Julie Parent  <jparent@chromium.org>
518
519         Reviewed by Tony Chang.
520
521         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
522         https://bugs.webkit.org/show_bug.cgi?id=51217
523
524         * TestResultServer/model/jsonresults.py:
525         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
526         Adds missing documentation.
527         * TestResultServer/model/jsonresults_unittest.py:
528         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
529         Update test_merge to take a number of builds to truncate at.
530
531 2011-01-06  Adam Barth  <abarth@webkit.org>
532
533         Reviewed by Eric Seidel.
534
535         The EWS should log outside of the working directory
536         https://bugs.webkit.org/show_bug.cgi?id=51986
537
538         This patch prepare us for using git clean -x -d -f in the EWS wrapper
539         script, which will actually clean the working copy back to a pristine
540         state instead of leaving untracked directories and ignored files.
541
542         * Scripts/webkitpy/tool/commands/queues.py:
543         * Scripts/webkitpy/tool/commands/queues_unittest.py:
544
545 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
546
547         Windows build fix.
548         Back out attempted change to built-product-archive.
549
550         * BuildSlaveSupport/built-product-archive:
551
552 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
553
554         Windows build fix.
555         Include configuration name when unpacking a build archive.
556
557         Needed, since we split Windows build results into configuration-specific directories
558         under WebKitOutputDir.
559
560         * BuildSlaveSupport/built-product-archive:
561
562 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
563
564         Reviewed by Darin Adler.
565
566         Debug and Release builds on Windows clobber each other
567         https://bugs.webkit.org/show_bug.cgi?id=49185
568
569         Changes the structure of WebKitBuild build products directory so we
570         completely separate each build configuration into independent directories.
571         
572         Although we previously had per-configuration directories for obj, this change adds
573         per-configuration directories for bin, lib, obj, and include. Each configuration's
574         build products are stored within a directory inside of WebKitBuild.
575         
576         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
577         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
578
579         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
580         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
581         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
582         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
583         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
584         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
585         * DumpRenderTree/win/ImageDiffCommon.vsprops:
586         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
587         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
588         * FindSafari/FindSafari.vcproj:
589         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
590         * MiniBrowser/MiniBrowserPostBuild.cmd:
591         * MiniBrowser/MiniBrowserPreBuild.cmd:
592         * Scripts/webkitdirs.pm:
593         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
594         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
595         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
596         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
597         * TestWebKitAPI/win/copy-resources.cmd:
598         * WebKitAPITest/WebKitAPITestCommon.vsprops:
599         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
600         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
601         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
602         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
603         * WebKitTestRunner/win/InjectedBundle.vcproj:
604         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
605         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
606         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
607         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
608         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
609         * WinLauncher/WinLauncherCommon.vsprops:
610         * WinLauncher/WinLauncherPostBuild.cmd:
611         * WinLauncher/WinLauncherPreBuild.cmd:
612
613 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
614
615         Reviewed by Ariya Hidayat.
616
617         [Qt] TestNetscapePlugin doesn't link on OS X
618         https://bugs.webkit.org/show_bug.cgi?id=51948
619
620         Only add a dependency on libX11 on X11 systems
621
622         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
623
624 2011-01-05  Jeff Miller  <jeffm@apple.com>
625
626         Reviewed by Adam Roben.
627
628         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
629         https://bugs.webkit.org/show_bug.cgi?id=51970
630
631         * Scripts/webkitpy/style/checker.py:
632         Add -readability/naming for WebKit2 C API directories.
633
634 2011-01-05  Eric Seidel  <eric@webkit.org>
635
636         Unreviewed, just fixing one more log error from my previous python patch.
637
638         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
639         https://bugs.webkit.org/show_bug.cgi?id=51802
640
641         webkit-patch failure-reason was logging about parsing errors
642         due to my misunderstanding of how BeautifulSoup.findAll worked.
643
644         Fixed, and added a unit test.
645
646         * Scripts/webkitpy/common/net/layouttestresults.py:
647         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
648
649 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
650
651         Reviewed by Kenneth Rohde Christiansen.
652
653         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
654         https://bugs.webkit.org/show_bug.cgi?id=51951
655
656         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
657         to create new window from WebKit.
658
659         * MiniBrowser/qt/BrowserWindow.cpp:
660         (newPageFunction):
661         (BrowserWindow::BrowserWindow):
662         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
663         (BrowserWindow::newWindow):
664         (BrowserWindow::updateUserAgentList):
665         (BrowserWindow::showUserAgentDialog):
666         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
667         define the type of the backing store used for new windows.
668         * MiniBrowser/qt/main.cpp:
669         (main):
670
671 2011-01-05  Eric Seidel  <eric@webkit.org>
672
673         Reviewed by Ojan Vafai.
674
675         commit-queue should report failure type when reporting flaky tests
676         https://bugs.webkit.org/show_bug.cgi?id=51900
677
678         This patch was a ridiculous amount of plumbing.  In the end I like
679         the NRWT-style TestResult class even less.  But now we're passing
680         a list of TestResult objects from the queue to the FlakyTestReporter.
681         Thus the FlakyTestReporter can more easily report what type of failure
682         occurred.
683
684         In the process, I found that I was not alone in finding TestResult
685         cumbersome to use.  A bunch of code was trying to create a TestResult
686         object with default values.  However since the constructor didn't make
687         this easy, some places were getting it wrong (including the TestResult unit test)!
688         I've fixed the TestResult constructor to have default values for non-essential
689         arguments.
690
691         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
692         * Scripts/webkitpy/common/net/layouttestresults.py:
693         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
694         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
695         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
696         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
697         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
698         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
699         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
700         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
701         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
702         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
703         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
704         * Scripts/webkitpy/tool/commands/queues.py:
705         * Scripts/webkitpy/tool/commands/queues_unittest.py:
706
707 2011-01-05  Eric Seidel  <eric@webkit.org>
708
709         Unreviewed.
710
711         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
712         https://bugs.webkit.org/show_bug.cgi?id=51802
713
714         Add another unit test to cover a previously missing import.
715
716         * Scripts/webkitpy/common/net/layouttestresults.py:
717         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
718
719 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
720
721         Reviewed by David Levin.
722
723         Add mihaip@chromium.org as a reviewer
724         https://bugs.webkit.org/show_bug.cgi?id=51966
725         
726         Add myself as a reviewer.
727
728         * Scripts/webkitpy/common/config/committers.py:
729
730 2011-01-05  James Simonsen  <simonjam@chromium.org>
731
732         Unreviewed. Adding myself to the list of committers.
733
734         * Scripts/webkitpy/common/config/committers.py:
735
736 2011-01-05  Eric Seidel  <eric@webkit.org>
737
738         Unreviewed.
739
740         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
741         https://bugs.webkit.org/show_bug.cgi?id=51802
742
743         Fix two exceptions seen on the bots after my original commit.
744
745         * Scripts/webkitpy/common/net/layouttestresults.py:
746         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
747
748 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
749
750         Reviewed by Andreas Kling.
751
752         [Qt]Add local storage settings to QtTestBrowser command line arguments 
753         https://bugs.webkit.org/show_bug.cgi?id=51750
754
755         * QtTestBrowser/main.cpp:
756         (LauncherApplication::handleUserOptions):
757          Local storage settings can be enable form command line arguments for
758          QtTestBrowser.
759
760 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
761
762         Reviewed by Martin Robinson.
763
764         GTK: AX: DRT needs to use correct root object method.
765         https://bugs.webkit.org/show_bug.cgi?id=51911
766
767         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
768         (AccessibilityController::rootElement):
769
770 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
771
772         Rubber-stamped by Csaba Osztrogonác.
773
774         Based on idea from Péter Gál.
775
776         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
777
778 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
779
780         Reviewed by Adam Barth.
781
782         sheriff-bot should be able to do multi-revision rollouts
783         https://bugs.webkit.org/show_bug.cgi?id=51176
784
785         * Scripts/webkitpy/tool/bot/irc_command.py:
786         * Scripts/webkitpy/tool/bot/sheriff.py:
787         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
788
789 2011-01-05  Eric Seidel  <eric@webkit.org>
790
791         Reviewed by Adam Barth.
792
793         queues.webkit.org should have per-bot status pages
794         https://bugs.webkit.org/show_bug.cgi?id=51906
795
796         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
797         statuses from a single queue.  Now that we have many bots servicing
798         some queues (commit-queue, win-ews, etc.) its easy to have the messages
799         you care about scroll off the end of the 15-message limit on the main page.
800
801         Eventually we should probably rename /queue-status to /queue or /queues,
802         but that's fodder for another patch.
803
804         * QueueStatusServer/handlers/queuestatus.py:
805         * QueueStatusServer/index.yaml:
806         * QueueStatusServer/main.py:
807         * QueueStatusServer/templates/includes/singlequeuestatus.html:
808          - This probably should use a custom filter instead of hard-coding
809            the URL scheme here, but I couldn't figure out how to easily
810            create such a filter.  Most filters work with "strings" so we can't
811            pass the status object.  We could add a method to the status
812            object and call that, but that seemed a bit strange too.
813         * QueueStatusServer/templates/queuestatus.html:
814
815 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
816
817         Unreviewed. Adding myself to the list of committers.
818
819         * Scripts/webkitpy/common/config/committers.py:
820
821 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
822
823         Reviewed by David Levin.
824
825         check-webkit-style treated some macros with parentheses after #elif as function calls
826         https://bugs.webkit.org/show_bug.cgi?id=51695
827
828         Ingore function call space checking in any preprocessor directives
829         (things starting with #). Change search() to match() because 
830         preprocessor directives are supposed to be in the beginning of lines.
831
832         * Scripts/webkitpy/style/checkers/cpp.py:
833         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
834
835 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
836
837         Reviewed by Tony Chang.
838
839         Change the --multi-load test option to --stress-opt
840         https://bugs.webkit.org/show_bug.cgi?id=50751
841
842         * DumpRenderTree/chromium/DumpRenderTree.cpp:
843         (runTest):
844         (main):
845         * DumpRenderTree/chromium/TestShell.cpp:
846         (TestShell::TestShell):
847         * DumpRenderTree/chromium/TestShell.h:
848         (TestShell::stressOpt):
849         (TestShell::setStressOpt):
850         (TestShell::stressDeopt):
851         (TestShell::setStressDeopt):
852         (TestShell::javaScriptFlags):
853         (TestShell::setJavaScriptFlags):
854         * Scripts/webkitpy/layout_tests/port/chromium.py:
855         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
856
857 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
858
859         Reviewed by Sam Weinig.
860
861         WK2: Support Accessibility
862         https://bugs.webkit.org/show_bug.cgi?id=51859
863
864         Use rootObject() method to get top of accessibility tree.
865
866         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
867         (AccessibilityController::focusedElement):
868         (AccessibilityController::rootElement):
869
870 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
871
872         Reviewed by Darin Adler.
873
874         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
875         https://bugs.webkit.org/show_bug.cgi?id=51846
876
877         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
878         back to GRefPtr.
879
880 2011-01-04  Zhe Su  <suzhe@chromium.org>
881
882         Reviewed by Kenneth Russell.
883
884         Fix insertText, setMarkedText and unmarkText methods of
885         TextInputController to call corresponding methods of WebKit::WebView
886         rather than WebKit::WebFrame. This change matches the behavior of
887         chromium browser.
888         insertText corresponds to WebView::confirmComposition(text)
889         setMarkedText corresponds to WebView::setComposition(...)
890         unmarkText corresponds to WebView::confirmComposition()
891         https://bugs.webkit.org/show_bug.cgi?id=51693
892
893         * DumpRenderTree/chromium/TextInputController.cpp:
894         (TextInputController::insertText):
895         (TextInputController::setMarkedText):
896         (TextInputController::unmarkText):
897
898 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
899
900         Reviewed by Laszlo Gombos.
901
902         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
903
904         On Symbian productDir points to the source directory. Removing all the
905         empty files from the productDir directory corrupts the svn repository.
906
907         * Scripts/build-webkit:
908
909 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
910
911         Reviewed by Adam Barth.
912
913         [Qt] Add SelectAll option to the context menu for the editor
914         https://bugs.webkit.org/show_bug.cgi?id=50049
915
916         Set shortcut for the SelectAll action.
917
918         * QtTestBrowser/mainwindow.cpp:
919         (MainWindow::buildUI):
920
921 2011-01-03  David Levin  <levin@chromium.org>
922
923         Reviewed by Eric Seidel.
924
925         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
926         https://bugs.webkit.org/show_bug.cgi?id=51842
927
928         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
929         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
930
931 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
932
933         Reviewed by David Kilzer.
934
935         [WINCE] Adds a build slave.
936         https://bugs.webkit.org/show_bug.cgi?id=50523
937
938         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
939         entry for a release build of the WinCE port.
940         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
941         flag to build the WinCE port.
942
943 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
944
945         Reviewed by David Kilzer.
946
947         Add WinCE support to build-webkit
948         https://bugs.webkit.org/show_bug.cgi?id=51642
949
950         * Scripts/build-webkit:
951         * Scripts/webkitdirs.pm:
952
953 2011-01-03  Eric Seidel  <eric@webkit.org>
954
955         Reviewed by Adam Barth.
956
957         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
958         https://bugs.webkit.org/show_bug.cgi?id=51802
959
960         I'm not the biggest fan of the test_failures or test_results classes,
961         but it's better to have one shared set of classes, than separate ones
962         for new vs. old run-webkit-test result handling.
963
964         This moves the ORWT results class "LayoutTestResults" over to using
965         TestResult and TestFailure classes, making it easy for us to
966         make all our sheriff-bot and other webkitpy code NRWT ready.
967
968         This also makes it a trivial patch to generate results.json information
969         from ORWT results.html files (for flaky test analysis, etc.) as well
970         as making it a one-liner to report test failure types when the
971         commit-queue sees flaky tests.
972
973         This patch tried not to add new functionality, but only to replace
974         the guts of LayoutTestResults, while adding unit tests and hoping
975         not to break anything.
976
977         I also moved callers which assumed User.prompt* were static/class methods
978         to using them as instance methods (since we'll eventually want to make them such).
979
980         In the process of re-writing things, I broke the rebaseline command, so I wrote
981         a unit test to catch my breakage were I do do so again in the future.
982
983         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
984         * Scripts/webkitpy/common/net/layouttestresults.py:
985         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
986         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
987         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
988         * Scripts/webkitpy/tool/commands/queries.py:
989         * Scripts/webkitpy/tool/commands/rebaseline.py:
990         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
991         * Scripts/webkitpy/tool/mocktool.py:
992
993 2011-01-03  Adam Barth  <abarth@webkit.org>
994
995         Reviewed by Simon Fraser.
996
997         webkit-patch shouldn't waste time cleaning a working directory that's already clean
998         https://bugs.webkit.org/show_bug.cgi?id=51840
999
1000         * Scripts/webkitpy/common/checkout/scm.py:
1001
1002 2011-01-03  Adam Barth  <abarth@webkit.org>
1003
1004         Reviewed by Simon Fraser.
1005
1006         webkit-patch should only hide update output if --quiet
1007         https://bugs.webkit.org/show_bug.cgi?id=51838
1008
1009         As requested by smfr.
1010
1011         * Scripts/webkitpy/tool/steps/update.py:
1012
1013 2011-01-03  Adam Barth  <abarth@webkit.org>
1014
1015         Reviewed by David Levin.
1016
1017         commit-queue shouldn't reject patches twice if two bots process the same patch
1018         https://bugs.webkit.org/show_bug.cgi?id=51805
1019
1020         Before raising an error, we first check whether the patch is still in
1021         the commit-queue.  This check is still racy, of course, but the time
1022         window is much smaller.
1023
1024         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1025
1026 2011-01-03  Sam Weinig  <sam@webkit.org>
1027
1028         Reviewed by Anders Carlsson.
1029
1030         Make run-api-tests less chatty.
1031         https://bugs.webkit.org/show_bug.cgi?id=51831
1032
1033         - Make script quiet by default and add --verbose option (replacing --quiet).
1034         - When not verbose, pipe stdout and stderr to devnull.
1035
1036         * Scripts/run-api-tests:
1037
1038 2011-01-03  Pratik Solanki  <psolanki@apple.com>
1039
1040         Unreviewed. Adding myself to committers.py.
1041
1042         * Scripts/webkitpy/common/config/committers.py:
1043
1044 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
1045
1046         Reviewed by Xan Lopez.
1047
1048         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
1049         https://bugs.webkit.org/show_bug.cgi?id=51806
1050
1051         Originally, the $libraryName is 'JavaScriptCore'. When building release 
1052         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
1053         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
1054         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
1055         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
1056         so make it 'WebKitBuild/Release/.libs'
1057
1058         * Scripts/webkitdirs.pm: 
1059
1060 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
1061
1062         Reviewed by Adam Barth.
1063
1064         Make EFL a core builder
1065         https://bugs.webkit.org/show_bug.cgi?id=51804
1066
1067         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1068         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1069
1070 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1071
1072         [Qt] Unreviewed fix after r74855 and r74875.
1073
1074         * BuildSlaveSupport/built-product-archive:
1075          - Create directories explicitly.
1076          - Pass shell=True to subprocess.call().
1077
1078 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1079
1080         [Qt] Unreviewed fix after r74855.
1081
1082         Move JavaScriptCore to Source
1083         https://bugs.webkit.org/show_bug.cgi?id=51604
1084
1085         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
1086
1087 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1088
1089         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
1090
1091         Move JavaScriptCore to Source
1092         https://bugs.webkit.org/show_bug.cgi?id=51604
1093
1094         * Scripts/webkitdirs.pm:
1095
1096 2011-01-02  Robert Hogan  <robert@webkit.org>
1097
1098         Unreviewed, build fix.
1099
1100         [Qt] Fix DRT build after 74855
1101
1102         * DumpRenderTree/qt/DumpRenderTree.pro:
1103
1104 2011-01-01  Adam Barth  <abarth@webkit.org>
1105
1106         Remove the assumption from the Qt and Gtk builds that every project is
1107         in the root directory.
1108
1109         * Scripts/build-webkit:
1110
1111 2011-01-01  Adam Barth  <abarth@webkit.org>
1112
1113         Reviewed by Eric Seidel.
1114
1115         Teach svn-apply how to apply patches even though JavaScriptCore has moved
1116         https://bugs.webkit.org/show_bug.cgi?id=51796
1117
1118         After this change, svn-apply will magically apply patches to
1119         JavaScriptCore/foo to Source/JavaScriptCore/foo.
1120
1121         * Scripts/VCSUtils.pm:
1122
1123 2011-01-01  Adam Barth  <abarth@webkit.org>
1124
1125         Reviewed by Eric Seidel.
1126
1127         Move JavaScriptCore to Source
1128         https://bugs.webkit.org/show_bug.cgi?id=51604
1129
1130         Update references to JavaScriptCore to point to the new location.
1131
1132         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1133         * DumpRenderTree/qt/DumpRenderTree.pro:
1134         * DumpRenderTree/qt/ImageDiff.pro:
1135         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1136         * DumpRenderTree/wscript:
1137         * Scripts/build-jsc:
1138         * Scripts/build-webkit:
1139         * Scripts/do-file-rename:
1140         * Scripts/do-webcore-rename:
1141         * Scripts/run-javascriptcore-tests:
1142         * Scripts/update-javascriptcore-test-results:
1143         * Scripts/webkitdirs.pm:
1144         * Scripts/webkitpy/common/config/build_unittest.py:
1145         * Scripts/webkitpy/style/checker.py:
1146         * Scripts/webkitpy/style/checker_unittest.py:
1147         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1148         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1149         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1150         * wx/build/settings.py:
1151
1152 2011-01-01  Adam Barth  <abarth@webkit.org>
1153
1154         Reviewed by Eric Seidel.
1155
1156         Move Sources to Source
1157         https://bugs.webkit.org/show_bug.cgi?id=51794
1158
1159         Update scripts to point to the new location.
1160
1161         * Scripts/build-webkit:
1162         * Scripts/do-file-rename:
1163         * Scripts/do-webcore-rename:
1164         * Scripts/webkitpy/common/config/build.py:
1165         * Scripts/webkitpy/common/config/build_unittest.py:
1166
1167 2010-12-31  Kent Tamura  <tkent@chromium.org>
1168
1169         Reviewed by Eric Seidel.
1170
1171         [DRT/Chromium] Enable mock spell checker on non-OSX
1172         https://bugs.webkit.org/show_bug.cgi?id=51401
1173
1174         * DumpRenderTree/chromium/WebViewHost.cpp:
1175         (WebViewHost::spellCheck):
1176
1177 2010-12-31  Adam Barth  <abarth@webkit.org>
1178
1179         Reviewed by Ariya Hidayat.
1180
1181         Remove Tools/Scripts/wkstyle
1182         https://bugs.webkit.org/show_bug.cgi?id=51774
1183
1184         This script appears to not have been touched in a while and seems to
1185         have been replaced by check-webkit-style.
1186
1187         * Scripts/wkstyle: Removed.
1188
1189 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
1190
1191         Unreviewed. Coding style fix.
1192
1193         * DumpRenderTree/chromium/TestShell.h:
1194
1195 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
1196
1197         Reviewed by Pavel Feldman.
1198
1199         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
1200
1201         It was a problem with Chromium DRT. DevToolsAgent object instance was
1202         attached not only to the inspected page but to the DevTools window too.
1203         As result all the inspector files were interpreted as a content of inspected page
1204         and were transfered to the DevTools scripts panel for debugging etc.
1205
1206         https://bugs.webkit.org/show_bug.cgi?id=51735
1207
1208         * DumpRenderTree/chromium/TestShell.cpp:
1209         (TestShell::TestShell):
1210         (TestShell::bindJSObjectsToWindow):
1211         (TestShell::createNewWindow):
1212         * DumpRenderTree/chromium/TestShell.h:
1213
1214 2010-12-31  Adam Barth  <abarth@webkit.org>
1215
1216         Rubber-stamped by Eric Seidel.
1217
1218         Move PageLoadTests to PerformanceTests/PageLoad
1219         https://bugs.webkit.org/show_bug.cgi?id=51771
1220
1221         Update references to PageLoadTests to point to the new location.
1222
1223         * Scripts/run-pageloadtest:
1224         * Scripts/webkitpy/common/config/build.py:
1225
1226 2010-12-31  Adam Barth  <abarth@webkit.org>
1227
1228         Rubber-stamped by Eric Seidel.
1229
1230         Move SunSpider into PerformanceTests
1231         https://bugs.webkit.org/show_bug.cgi?id=51769
1232
1233         Update these scripts to point to the new location.
1234
1235         * Scripts/run-sunspider:
1236         * Scripts/sunspider-compare-results:
1237
1238 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
1239
1240         Reviewed by Kent Tamura.
1241
1242         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
1243         https://bugs.webkit.org/show_bug.cgi?id=51728
1244         
1245         Add implementation of the Mac WebThemeEngine that uses an NSScroller
1246         to render top-level scrollbars. This makes them match the Mac port's
1247         use of an NSScrollView, which means that we'll be able to share more
1248         pixel baselines.
1249         
1250         The new rendering code will not be activated until the 
1251         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
1252         ScrollbarThemeChromiumMac.
1253
1254         * DumpRenderTree/DumpRenderTree.gypi:
1255         * DumpRenderTree/chromium/TestShellMac.mm:
1256         (platformInit):
1257         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
1258         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
1259         (+[FakeActiveWindow alwaysActiveWindow]):
1260         (+[FakeActiveWindow alwaysInactiveWindow]):
1261         (-[FakeActiveWindow initWithActiveControls:]):
1262         (-[FakeActiveWindow _hasActiveControls]):
1263         (WebThemeEngineDRTMac::paintScrollbarThumb):
1264         (stateToHIEnableState):
1265         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
1266         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
1267
1268 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
1269
1270         Reviewed by David Kilzer.
1271
1272         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
1273         used
1274         https://bugs.webkit.org/show_bug.cgi?id=51672
1275
1276         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
1277         with USE_SYSTEM_MALLOC=1
1278         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
1279         with USE_SYSTEM_MALLOC=1
1280
1281 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1282
1283         Reviewed by David Kilzer.
1284
1285         [Qt] [Symbian] Fix build-webkit script for Symbian
1286         https://bugs.webkit.org/show_bug.cgi?id=51509
1287
1288         Set the OUTPUT_DIR for Symbian to be the same as the source
1289         directory.
1290
1291         * Scripts/webkitdirs.pm:
1292
1293 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
1294
1295         Reviewed by Darin Adler.
1296
1297         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
1298         https://bugs.webkit.org/show_bug.cgi?id=51758
1299
1300         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
1301
1302         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
1303         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
1304
1305 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
1306
1307         Unreviewed WinCE buildfix.
1308
1309         * WinCELauncher/main.cpp: Add missing include.
1310
1311 2010-12-29  Daniel Bates  <dbates@rim.com>
1312
1313         Reviewed by Darin Adler.
1314
1315         svn-apply updates date of wrong change log entry for a change log diff that
1316         contains two consecutive entries with the same author and date
1317         https://bugs.webkit.org/show_bug.cgi?id=46061
1318
1319         Fixes an issue where the date of the wrong change log entry may be modified.
1320         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
1321         in a ChangeLog file to the top of the file.
1322
1323         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
1324         diff when it detects that the diff inserts a change log entry earlier in a
1325         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
1326         change. With the advent of the commit-queue this functionality of bailing out
1327         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
1328         Instead, we should always move the change log entry to the top of the ChangeLog file.
1329
1330         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
1331         the date line of the correct change log entry in a ChangeLog diff.
1332
1333         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
1334
1335         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
1336           Updated the following unit tests now that we move entries inserted earlier to the top:
1337           - "fixChangeLogPatch: New entry inserted in middle."
1338             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
1339
1340           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
1341             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
1342
1343         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
1344
1345 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
1346
1347         Reviewed by Eric Seidel.
1348
1349         [Qt] Fixed compatibility with gold linker on X11 platforms
1350         https://bugs.webkit.org/show_bug.cgi?id=51700
1351
1352         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1353         Linked TestNetscapePlugin with libX11 on Unix platforms
1354
1355 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
1356
1357         Reviewed by Darin Adler.
1358
1359         Circular dependency in webkitpy.common.checkout.changelog module
1360         https://bugs.webkit.org/show_bug.cgi?id=50475
1361
1362         Remove automatic import of api.Checkout module when any checkout/
1363         submodule is imported (e.g.: when checkout.scm.Git is imported).
1364
1365         * Scripts/webkitpy/common/checkout/__init__.py:
1366
1367 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
1368
1369         Reviewed by Ojan Vafai.
1370
1371         prepare-ChangeLog should support the -g option for specifying the git-commit
1372         https://bugs.webkit.org/show_bug.cgi?id=51708
1373
1374         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
1375         webkit-patch, though the exact meaning of the two options remain different.
1376
1377         * Scripts/prepare-ChangeLog: Add -g.
1378
1379 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
1380
1381         Reviewed by Simon Hausmann.
1382
1383         [Qt] Fix compilation with Qt in namespace
1384         https://bugs.webkit.org/show_bug.cgi?id=51701
1385
1386         * QtTestBrowser/webview.h:
1387
1388 2010-12-28  Daniel Bates  <dbates@rim.com>
1389
1390         Reviewed by Sam Weinig.
1391
1392         Substitute // MARK: for compiler-specific #pragma mark
1393         https://bugs.webkit.org/show_bug.cgi?id=51657
1394
1395         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
1396         substituting  "// MARK:" for "#pragma mark", which provides
1397         analogous code-bookmarking functionality under Xcode.
1398
1399         Also, for consistency, we should substitute "// MARK:" for compiler-
1400         specific "#pragma mark" in the source files for the Mac port.
1401
1402         * DumpRenderTree/AccessibilityTextMarker.cpp:
1403         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
1404         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
1405         * DumpRenderTree/mac/ObjCController.m:
1406         * MiniBrowser/mac/AppDelegate.m:
1407         * MiniBrowser/mac/BrowserWindowController.m:
1408
1409 2010-12-28  Xan Lopez  <xlopez@igalia.com>
1410
1411         Reviewed by Eric Seidel.
1412
1413         Add --no-build option to run-sunspider
1414         https://bugs.webkit.org/show_bug.cgi?id=51658
1415
1416         * Scripts/run-sunspider: add --no-build flag to skip building
1417         phase.
1418
1419 2010-12-27  Daniel Bates  <dbates@rim.com>
1420
1421         Rubber-stamped by Martin Robinson.
1422
1423         Append the directory Tools/DumpRenderTree to the list of directories that
1424         do-webcore-rename should search so that it can rename DRT files and
1425         source code.
1426
1427         * Scripts/do-webcore-rename:
1428
1429 2010-12-27  Eric Seidel  <eric@webkit.org>
1430
1431         Reviewed by Adam Barth.
1432
1433         build-webkit should detect missing Java SDK and explain how to install it
1434         https://bugs.webkit.org/show_bug.cgi?id=51651
1435
1436         * Scripts/build-webkit:
1437
1438 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
1439
1440         Reviewed by Daniel Bates.
1441
1442         [GTK] Add support for build-jsc
1443         https://bugs.webkit.org/show_bug.cgi?id=51625
1444
1445         Add GTK+ support to build-jsc now that building the jsc executable as
1446         a standalone target is easy.
1447
1448         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
1449         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
1450         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
1451         and pass it along to buildAutotoolsProject.
1452
1453 2010-12-27  David Levin  <levin@chromium.org>
1454
1455         Reviewed by Eric Seidel.
1456
1457         check-webkit-style check for meaningless variable names in function declarations.
1458         https://bugs.webkit.org/show_bug.cgi?id=51523
1459
1460         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
1461         from the new check and whitespace/parens because the syntax is unusual and
1462         produced a fair number of positives for these checks.
1463         * Scripts/webkitpy/style/checkers/cpp.py:
1464         (_convert_to_lower_with_underscores): Used as a canonical form for type names
1465         and parameter names when determining if the parameter name is useless.
1466         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
1467         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
1468         format.
1469         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
1470         text or an acronym of it.
1471         (check_function_definition): Checks function definitions for meaningless variable names.
1472         (process_line): Added call to check_function_definition.
1473         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1474         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
1475         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
1476         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
1477         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
1478         because when only checking a snippet, there are a lot of bogus functions.
1479         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
1480         that I put there previously and just noticed.
1481         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
1482         check_function_definition and process_line.
1483
1484 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1485
1486         Reviewed by Martin Robinson.
1487
1488         [GTK] Disable flash plugin in GtkLauncher when using gtk3
1489         https://bugs.webkit.org/show_bug.cgi?id=51591
1490
1491         Flash plugin uses gtk2 that is incompatible with gtk3 making
1492         webkit crash when it's built with gtk3.
1493
1494         * GtkLauncher/main.c:
1495         (main):
1496
1497 2010-12-25  Adam Barth  <abarth@webkit.org>
1498
1499         Reviewed by Eric Seidel.
1500
1501         Move ANGLE to Sources/ThirdParty
1502         https://bugs.webkit.org/show_bug.cgi?id=51605
1503
1504         * Scripts/build-webkit:
1505           - Point to the new ANGLE location.
1506
1507 2010-12-26  David Levin  <levin@chromium.org>
1508
1509         Reviewed by Eric Seidel.
1510
1511         check-webkit-style should be able to parse function declaration parameters.
1512         https://bugs.webkit.org/show_bug.cgi?id=51451
1513
1514         * Scripts/webkitpy/style/checkers/cpp.py:
1515         (Position.__init__): Holds simple position information (row, column).
1516         (Parameter.__init__): Holds information about a parameter.
1517         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
1518         (SingleLineView.convert_column_to_row): Returns the original row given a column.
1519         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
1520         (find_parameter_name_index): Finds where the parameter name is.
1521         (parameter_list): Generates the list of parameters for a function.
1522         (_FunctionState.begin): Added information to allow determining the parameters
1523         on demand.
1524         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
1525         (detect_functions): Improve function detection for operator functions and
1526         determine where the parameters end and pass that to _FunctionState.begin.
1527         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1528         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
1529         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
1530         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
1531         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
1532         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
1533         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
1534         (FunctionDetectionTest.perform_function_detection): Added support for verifying
1535         the parameters found.
1536         (FunctionDetectionTest.test_function_declaration_detection): Added more function
1537         detection test to verify that we catch the operator functions.
1538         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
1539         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
1540         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
1541         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
1542         test_function_length_check_definition_severity1_for_test.
1543
1544 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
1545
1546         Unreviewed WinCE buildfix after r74334.
1547
1548         * CMakeListsWinCE.txt:
1549
1550 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
1551
1552         Unreviewed, rolling out r74632.
1553         http://trac.webkit.org/changeset/74632
1554         https://bugs.webkit.org/show_bug.cgi?id=51600
1555
1556         makes test-webkitpy hang forever on GTK (Requested by philn-tp
1557         on #webkit).
1558
1559         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1560         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
1561
1562 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
1563
1564         Reviewed by Kenneth Rohde Christiansen.
1565
1566         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
1567         https://bugs.webkit.org/show_bug.cgi?id=43528
1568
1569         Remove on_resize because ewk_view_fixed_layout_size_set should not be
1570         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
1571         FrameView, rendering was ignored when _ewk_view_smart_calculate was
1572         called.
1573
1574         * EWebLauncher/main.c:
1575         (browserCreate):
1576
1577 2010-12-24  Eric Seidel  <eric@webkit.org>
1578
1579         Reviewed by Adam Barth.
1580
1581         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
1582         https://bugs.webkit.org/show_bug.cgi?id=28291
1583
1584         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
1585         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
1586         to strings with find in the diff.
1587         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
1588
1589         * Scripts/webkitpy/common/checkout/api.py:
1590         * Scripts/webkitpy/common/checkout/diff_parser.py:
1591         * Scripts/webkitpy/tool/steps/abstractstep.py:
1592         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
1593         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
1594         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
1595         * Scripts/webkitpy/tool/steps/validatereviewer.py:
1596
1597 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
1598
1599         Reviewed by Kenneth Russell.
1600
1601         Modify new-run-webkit-tests to shut up and exit when all the threads
1602         are wedged so that test runs complete faster and we don't end up
1603         w/ enormous log files.
1604
1605         https://bugs.webkit.org/show_bug.cgi?id=51572
1606
1607         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1608         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
1609
1610 2010-12-24  Eric Seidel  <eric@webkit.org>
1611
1612         Reviewed by David Levin.
1613
1614         commit-queue should better explain how it will re-open bugs and follow duplicate chains
1615         https://bugs.webkit.org/show_bug.cgi?id=51549
1616
1617         I've had multiple people ask me about the commit-queue's behavior
1618         regarding reporting flaky tests.  I figured it would be best to just
1619         have the queue explain itself in the bugs it files.
1620
1621         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1622         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1623
1624 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
1625
1626         Reviewed by Eric Seidel.
1627
1628         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
1629         https://bugs.webkit.org/show_bug.cgi?id=51467
1630
1631         * Scripts/webkitpy/style/checker.py:
1632         * Scripts/webkitpy/style/checker_unittest.py:
1633
1634 2010-12-23  Adam Barth  <abarth@webkit.org>
1635
1636         Rubber-stamped by Eric Seidel.
1637
1638         Move JavaScriptGlue into Sources
1639         https://bugs.webkit.org/show_bug.cgi?id=51583
1640
1641         These tools refer to JavaScriptGlue and need to be updated to its new
1642         location.
1643
1644         * Scripts/build-webkit:
1645         * Scripts/do-file-rename:
1646         * Scripts/do-webcore-rename:
1647         * Scripts/webkitpy/common/config/build.py:
1648         * Scripts/webkitpy/common/config/build_unittest.py:
1649
1650 2010-12-23  Lucas Forschler  <lforschler@apple.com>
1651
1652         Reviewed by Eric Seidel.
1653
1654         Bug 51539 - update iexploder scripts to point to new location
1655
1656         * Scripts/run-iexploder-tests:
1657         * Scripts/update-iexploder-cssproperties:
1658
1659 2010-12-23  Evan Martin  <evan@chromium.org>
1660
1661         Reviewed by Ryosuke Niwa.
1662
1663         [chromium] LayoutTestController warning in float->int conversion
1664         https://bugs.webkit.org/show_bug.cgi?id=51553
1665
1666         Rather than reading an int, converting to a float, then getting a compiler
1667         warning on passing the float to something that expects an int, instead
1668         just pass around ints.
1669
1670         No tests, fixes a compiler warning.
1671
1672         * DumpRenderTree/chromium/LayoutTestController.cpp:
1673         (parsePageSizeParameters):
1674         (LayoutTestController::pageNumberForElementById):
1675         (LayoutTestController::numberOfPages):
1676
1677 2010-12-23  Lucas Forschler  <lforschler@apple.com>
1678
1679         Reviewed by Darin Adler.
1680
1681         Bug 51537 - iexploder needs cleanup
1682         
1683         * iExploder/htdocs: Removed.
1684         * iExploder/htdocs/config.rb: Removed.
1685         * iExploder/htdocs/cssproperties.in: Removed.
1686         * iExploder/htdocs/cssvalues.in: Removed.
1687         * iExploder/htdocs/htmlattrs.in: Removed.
1688         * iExploder/htdocs/htmltags.in: Removed.
1689         * iExploder/htdocs/htmlvalues.in: Removed.
1690         * iExploder/htdocs/iexploder.cgi: Removed.
1691         * iExploder/htdocs/iexploder.rb: Removed.
1692         * iExploder/htdocs/index.html: Removed.
1693         * iExploder/htdocs/webserver.rb: Removed.
1694         * iExploder/iexploder-1.7.2/output: Removed.
1695         * iExploder/tools: Removed.
1696         * iExploder/tools/lasthit.rb: Removed.
1697         * iExploder/tools/osx_last_crash.rb: Removed.
1698         * iExploder/tools/showtest.rb: Removed.
1699
1700 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
1701
1702         Reviewed by Kenneth Rohde Christiansen.
1703
1704         [EFL] Make 'single' the default backing store in EWebLauncher
1705         https://bugs.webkit.org/show_bug.cgi?id=51534
1706
1707         'single' is the simplest backing store and the one intended to be the
1708         default in the test browser. By mistake the tiled backing store was
1709         left as default in r72617.
1710
1711         * EWebLauncher/main.c:
1712         (browserCreate): ditto.
1713
1714 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
1715
1716         Reviewed by Kenneth Rohde Christiansen.
1717
1718         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
1719         https://bugs.webkit.org/show_bug.cgi?id=51533
1720
1721         There's no point in concatenating env("HOME") with "blah", so remove
1722         option from EWebLauncher.
1723
1724         * EWebLauncher/main.c:
1725         (main): ditto.
1726
1727 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
1728
1729         Reviewed by Eric Seidel.
1730
1731         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
1732
1733         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
1734         I just discovered that we have two additional GC runs per each WebViewHost.
1735         Test_shell had no such calls.
1736         These gc runs eat 15% of cpu time.
1737
1738         https://bugs.webkit.org/show_bug.cgi?id=51479
1739
1740         * DumpRenderTree/chromium/WebViewHost.cpp:
1741         (WebViewHost::~WebViewHost):
1742
1743 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
1744
1745         Reviewed by Ojan Vafai.
1746
1747         This change splits out the TestRunner class into its own file.
1748         When we fork the code for message passing, we will create a new
1749         TestRunner, and this change will allow that to be more modular.
1750
1751         While we're at it, split out TestInput and ResultSummary into
1752         their own files, to reduce the size of run_webkit_tests to
1753         something more managable.
1754
1755         https://bugs.webkit.org/show_bug.cgi?id=51092
1756
1757         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1758         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
1759         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1760         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
1761         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
1762         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1763         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1764
1765  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
1766
1767         Reviewed by Ojan Vafai.
1768
1769         nrwt multiprocessing - start over, prepare to fork the code
1770  
1771         This code cleans up the signatures and implementation of the
1772         TestRunner class so we can easily fork it to run either the
1773         stable implementation or the new, unstable message-passing
1774         implementation. The two variants will have different
1775         implementations of the run_tests() method. We will switch
1776         between the two based on the setting for the '--worker-model'
1777         switch. We rename the two currently valid values to 'old-inline'
1778         and 'old-threads'.
1779
1780         https://bugs.webkit.org/show_bug.cgi?id=51081
1781
1782         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1783         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1784
1785 2010-12-22  Victor Wang  <victorw@chromium.org>
1786
1787         Reviewed by Darin Fisher.
1788
1789         [Chromium] Update chromium archive test result url in rebaseline script.
1790
1791         https://bugs.webkit.org/show_bug.cgi?id=51503
1792
1793         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1794
1795 2010-12-22  Lucas Forschler  <lforschler@apple.com>
1796
1797         Reviewed by Alice Liu.
1798
1799         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
1800         Verified on Chrome, Safari, and IE.
1801         With this change, we will record memory from a parent browser window and all child processes.
1802
1803         * record-memory-win/main.cpp:
1804         (ProcessArgs):
1805         (PrintUsage):
1806         (getMemoryInfo):
1807         (printProcessInfo):
1808         (evalProcesses):
1809         (UseImage):
1810         (QueryContinuously):
1811         (ElapsedTime):
1812
1813 2010-12-22  Lucas Forschler  <lforschler@apple.com>
1814
1815         Unreviewed rollout r74489, because it was missing changelog.
1816
1817         * record-memory-win/main.cpp:
1818         
1819 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
1820
1821         Adding myself as a reviewer.
1822
1823         * Scripts/webkitpy/common/config/committers.py:
1824
1825 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
1826
1827         Unreviewed.  Adding myself to committers.py.
1828
1829         * Scripts/webkitpy/common/config/committers.py:
1830
1831 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
1832
1833         Reviewed by Kenneth Rohde Christiansen.
1834
1835         TestNetscapePlugIn should use #if defined
1836         https://bugs.webkit.org/show_bug.cgi?id=51471
1837
1838         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1839         (NP_Initialize):
1840         (NPP_New):
1841
1842 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
1843
1844         Reviewed by Yury Semikhatsky.
1845
1846         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
1847
1848         DevTools window should be closed explicitly because it has custom deinitialization code.
1849
1850         https://bugs.webkit.org/show_bug.cgi?id=50722
1851
1852         * DumpRenderTree/chromium/TestShell.cpp:
1853         (TestShell::closeRemainingWindows):
1854
1855 2010-12-22  David Levin  <levin@chromium.org>
1856
1857         Reviewed by Shinichiro Hamaji.
1858
1859         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
1860         https://bugs.webkit.org/show_bug.cgi?id=51452
1861
1862         * Scripts/webkitpy/style/checkers/cpp.py:
1863         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
1864         Using the file extension if possible but falling back to the file contents if we have a header file.
1865         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
1866         (_FileState.is_c_or_objective_c):
1867         (check_using_std): Changed to using _FileState to determine the file type.
1868         (check_max_min_macros): Ditto.
1869         (check_for_null): Ditto.
1870         (check_style): Changed the parameters to various calls since they now need _FileState
1871         to determine the file type.
1872         (check_language): Added the file_state parameter so it could be passed
1873         to check_identifier_name_in_declaration.
1874         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
1875         this is an Objective C file.
1876         (_process_lines): Added information for the _FileState constructor (and moved the
1877         call to a place that had the information).
1878         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1879         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
1880         its functionality.
1881         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
1882
1883 2010-12-21  Andy Estes  <aestes@apple.com>
1884
1885         Reviewed by Mark Rowe.
1886
1887         Do not build non-Intel architectures for WebKit2-related projects.
1888         https://bugs.webkit.org/show_bug.cgi?id=51440
1889
1890         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
1891         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
1892         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
1893
1894 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
1895
1896         Reviewed by Darin Fisher.
1897
1898         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
1899         https://bugs.webkit.org/show_bug.cgi?id=51406 
1900         
1901         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
1902         to WebThemeEngineDRTWin and update references everywhere.
1903
1904         * DumpRenderTree/DumpRenderTree.gypi:
1905         * DumpRenderTree/chromium/TestShellWin.cpp:
1906         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
1907         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
1908         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
1909         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
1910
1911 2010-12-21  Anders Carlsson  <andersca@apple.com>
1912
1913         Reviewed by John Sullivan.
1914
1915         Clicking missing plug-in text does not show a sheet
1916         https://bugs.webkit.org/show_bug.cgi?id=51403
1917
1918         Update for changes to the WebPageUIClient.
1919
1920         * MiniBrowser/mac/BrowserWindowController.m:
1921         (-[BrowserWindowController awakeFromNib]):
1922         * WebKitTestRunner/TestController.cpp:
1923         (WTR::createOtherPage):
1924         (WTR::TestController::initialize):
1925
1926 2010-12-21  Eric Seidel  <eric@webkit.org>
1927
1928         Reviewed by Adam Barth.
1929
1930         commit-queue will report constant failures as flaky if other tests flake
1931         https://bugs.webkit.org/show_bug.cgi?id=51272
1932
1933         This patch just removes functionality and adds testing.
1934         Previously we attempted to report flaky tests when we had
1935         two different tests fail in a row.  However, since we stop
1936         running the tests at the first failure, our code was wrong in
1937         trying to determine flakiness from the incomplete runs.
1938
1939         Originally I posted an alternate patch:
1940         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
1941         which fixed our flaky logic in this case, however it was decided
1942         that that patch would be too difficult to maintain, so now
1943         I'm just removing the broken logic.
1944
1945         This will dramatically cut-down on our flaky-test false positives
1946         at the (small) cost of the queues being unable to report
1947         any flakiness if the tree is very flaky.  (With at least one test
1948         flaking on every run, we'll never report failures anymore.)  I think
1949         this is a tradeoff worth making.
1950
1951         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1952         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1953
1954 2010-12-20  Eric Seidel  <eric@webkit.org>
1955
1956         Reviewed by Adam Barth.
1957
1958         commit-queue wrongly rejects patches when it can't update itself
1959         https://bugs.webkit.org/show_bug.cgi?id=46636
1960
1961         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1962         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1963         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1964
1965 2010-12-20  Adam Barth  <abarth@webkit.org>
1966
1967         Move web sites to Websites directory
1968         https://bugs.webkit.org/show_bug.cgi?id=51323
1969
1970         Update references to BugsSite to point to the new location.
1971
1972         This patch was never officially reviewed (because it was too large to
1973         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
1974         Rowe gave me the green light.
1975
1976         * Scripts/old-run-webkit-tests:
1977         * Scripts/webkitpy/common/config/build.py:
1978         * Scripts/webkitpy/common/config/build_unittest.py:
1979         * Scripts/webkitpy/common/prettypatch.py:
1980         * Scripts/webkitpy/layout_tests/port/base.py:
1981         * Scripts/webkitpy/style/main.py:
1982
1983 2010-12-20  Adrienne Walker  <enne@google.com>
1984
1985         Unreviewed. Adding myself to the list of committers.
1986
1987         * webkitpy/common/config/committers.py:
1988
1989 2010-12-20  Mark Rowe  <mrowe@apple.com>
1990
1991         Reviewed by Dan Bernstein.
1992
1993         <rdar://problem/8757601> Don't install header files in to the Resources directory.
1994
1995         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
1996         Resources directory.
1997
1998 2010-12-20  Eric Seidel  <eric@webkit.org>
1999
2000         Reviewed by Adam Barth.
2001
2002         commit-queue should include bot id when attaching failure diffs
2003         https://bugs.webkit.org/show_bug.cgi?id=51280
2004
2005         This is a tiny change to include the bot id in the name of the attachment.
2006         Most of this diff is just changing the unit test expectations
2007         now that I hid the comment printing when the comment is None.
2008
2009         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2010         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2011         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2012         * Scripts/webkitpy/tool/mocktool.py:
2013
2014 2010-12-20  Jeff Miller  <jeffm@apple.com>
2015
2016         Reviewed by Dan Bernstein.
2017
2018         Tools/vcbin/midl.exe needs to be rebuilt
2019         https://bugs.webkit.org/show_bug.cgi?id=51347
2020
2021         * vcbin/midl.exe: Rebuilt.
2022
2023 2010-12-20  David Levin  <levin@chromium.org>
2024
2025         Reviewed by Ariya Hidayat.
2026
2027         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
2028         https://bugs.webkit.org/show_bug.cgi?id=51343
2029
2030         Follow up from the WebKitTools -> Tools rename.
2031
2032         * Scripts/webkit-tools-completion.sh:
2033
2034 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
2035
2036         Reviewed by James Robinson.
2037
2038         new-run-webkit-tests ignores trailing EOL differences in text tests
2039         https://bugs.webkit.org/show_bug.cgi?id=36983
2040
2041         Changed the handling of new-line characters within new-run-webkit-tests
2042         to match old-run-webkit-tests.  Differences in leading and trailing empty
2043         lines in text expectation files are no longer ignored.
2044
2045         * Scripts/webkitpy/layout_tests/port/base.py:
2046         * Scripts/webkitpy/layout_tests/port/test.py:
2047         Added unit tests.  Removed old duplicate unit test entries.
2048         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2049
2050 2010-12-20  David Levin  <levin@chromium.org>
2051
2052         Reviewed by Shinichiro Hamaji.
2053
2054         check-webkit-style should detect function declarations (and trivial functions).
2055         https://bugs.webkit.org/show_bug.cgi?id=51303
2056
2057         * Scripts/webkitpy/style/checkers/cpp.py:
2058         (_FunctionState.begin): Add is_declaration and changed the line count
2059         start to begin at -1 (which will keep the results consistent, since
2060         the starting line number passed in is one less in this change).
2061         (detect_functions): changed function detection to now catch trivial
2062         functions and declarations.
2063         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
2064         of the function as this may look at return values (when processing
2065         a declaration).
2066         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2067         (FunctionDetectionTest.perform_function_detection): Basic mechanics
2068         of testing the function detection.
2069         (FunctionDetectionTest.test_basic_function_detection): Test a simple
2070         function.
2071         (FunctionDetectionTest.test_function_declaration_detection): Test a
2072         declaration.
2073         (FunctionDetectionTest.test_non_functions): A test case for a case
2074         that caused the code to fail due to the { being in quotes.
2075         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
2076         cases to help catch false alarms for return values.
2077         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
2078         we don't get false alarms for member variables either.
2079
2080 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
2081
2082         Reviewed by Antonio Gomes.
2083
2084         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
2085         https://bugs.webkit.org/show_bug.cgi?id=51319
2086
2087         * CMakeListsEfl.txt:
2088
2089 2010-12-18  Adam Barth  <abarth@webkit.org>
2090
2091         Reviewed by Sam Weinig.
2092
2093         Move WebKitExamplePlugins to Examples
2094         https://bugs.webkit.org/show_bug.cgi?id=51291
2095
2096         * Scripts/webkitpy/common/config/build.py:
2097
2098 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
2099
2100         Unreviewed Qt buildfix after r74301.
2101
2102         Rename WebKitTools to Tools
2103         https://bugs.webkit.org/show_bug.cgi?id=49861
2104
2105         * MiniBrowser/DerivedSources.pro:
2106         * MiniBrowser/qt/MiniBrowser.pro:
2107
2108 2010-12-17  Dan Bernstein  <mitz@apple.com>
2109
2110         Reviewed by Simon Fraser.
2111
2112         Rename WebKitTools to Tools
2113         https://bugs.webkit.org/show_bug.cgi?id=49861
2114
2115         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2116         * CodeCoverage/README:
2117         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2118         (WebCore::DumpRenderTree::initializeFonts):
2119         * EWSTools/start-commit-queue.sh:
2120         * EWSTools/start-queue.sh:
2121         * GNUmakefile.am:
2122         * MIDLWrapper/MIDLWrapper.cpp:
2123         (wmain):
2124         * MiniBrowser/qt/MiniBrowser.pro:
2125         * Scripts/build-api-tests:
2126         * Scripts/build-dumprendertree:
2127         * Scripts/build-webkit:
2128         * Scripts/build-webkittestrunner:
2129         * Scripts/generate-coverage-data:
2130         * Scripts/old-run-webkit-tests:
2131         * Scripts/run-api-tests:
2132         * Scripts/run-iexploder-tests:
2133         * Scripts/run-javascriptcore-tests:
2134         * Scripts/run-mangleme-tests:
2135         * Scripts/run-sunspider:
2136         * Scripts/run-webkit-websocketserver:
2137         * Scripts/sunspider-compare-results:
2138         * Scripts/test-webkitperl:
2139         * Scripts/test-webkitpy:
2140         * Scripts/update-iexploder-cssproperties:
2141         * Scripts/update-webkit:
2142         * Scripts/update-webkit-localizable-strings:
2143         * Scripts/webkitdirs.pm:
2144         * Scripts/webkitpy/common/checkout/scm.py:
2145         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2146         * Scripts/webkitpy/common/config/committervalidator.py:
2147         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
2148         * Scripts/webkitpy/common/config/ports.py:
2149         * Scripts/webkitpy/common/config/ports_unittest.py:
2150         * Scripts/webkitpy/common/system/logutils_unittest.py:
2151         * Scripts/webkitpy/common/system/ospath_unittest.py:
2152         * Scripts/webkitpy/layout_tests/port/chromium.py:
2153         * Scripts/webkitpy/layout_tests/port/config.py:
2154         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2155         * Scripts/webkitpy/layout_tests/port/http_server.py:
2156         * Scripts/webkitpy/layout_tests/port/test.py:
2157         * Scripts/webkitpy/style/checker.py:
2158         * Scripts/webkitpy/style/checker_unittest.py:
2159         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2160         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2161         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2162         * WebKitTestRunner/DerivedSources.pro:
2163         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2164         (WTR::activateFonts):
2165         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2166         * wx/build/build_utils.py:
2167
2168 2010-12-16  Antonio Gomes  <agomes@rim.com>
2169
2170         Reviewed by Martin Robinson.
2171
2172         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
2173         https://bugs.webkit.org/show_bug.cgi?id=51163
2174
2175         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
2176         GTK+'s DRT should also reset to UNIX after each test execution.
2177
2178         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2179         (resetDefaultsToConsistentValues):
2180
2181 2010-12-17  David Levin  <levin@chromium.org>
2182
2183         Reviewed by Eric Seidel.
2184
2185         check-webkit-style should understand WTF #include guards
2186         https://bugs.webkit.org/show_bug.cgi?id=44911
2187
2188         * Scripts/webkitpy/style/checkers/cpp.py:
2189         (get_header_guard_cpp_variable): modify to suggest the WTF style
2190         of header guard when appropriate.
2191         (check_for_header_guard): handle multiple return values from
2192         get_header_guard_cpp_variable
2193         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2194         (CppStyleTest.test_build_header_guard): Added tests for the WTF
2195         header style.
2196
2197 2010-12-16  David Levin  <levin@chromium.org>
2198
2199         Reviewed by Eric Seidel.
2200
2201         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
2202         https://bugs.webkit.org/show_bug.cgi?id=51210
2203
2204         The error only shows up when using python 2.6 or later.
2205
2206         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
2207         the decprecated field error,message with something equivalent.
2208
2209 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
2210
2211         Reviewed by Eric Seidel.
2212
2213         Add --exit-after-n-failures/crashes to NRWT
2214         https://bugs.webkit.org/show_bug.cgi?id=51160
2215         
2216         Abort test run (in a similar way to how control-C is handled) when
2217         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
2218         that number of unexpected failures/crashes/timeouts.
2219
2220         * Scripts/webkitpy/layout_tests/port/test.py:
2221         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2222         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2223
2224 2010-12-16  David Levin  <levin@chromium.org>
2225
2226         Reviewed by Shinichiro Hamaji.
2227
2228         check-webkit-style unit tests has some duplicate boilerplate code.
2229         https://bugs.webkit.org/show_bug.cgi?id=49519
2230
2231         * Scripts/webkitpy/style/checkers/cpp.py:
2232         (update_include_state): Replaced the "io" parameter with the global
2233         configuration _unit_test_config. This allowed not calling into
2234         functions at a low level and also not plumbing through the injection
2235         information through many levels of code.
2236         (check_for_include_what_you_use): Ditto.
2237         (process_file_data): Added the ability to set up the unit test config
2238         to allow for injection.
2239         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2240         (ErrorCollector.__init__): Added support for having a filter for errors.
2241         (ErrorCollector.__call__): Ditto.
2242         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
2243         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
2244         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
2245         functions in the cpp.py with generic processing and a filter that
2246         indicates what errors should be kept.
2247         (CppStyleTestBase.perform_multi_line_lint): Ditto.
2248         (CppStyleTestBase.perform_language_rules_check): Ditto.
2249         (CppStyleTestBase.perform_function_lengths_check): Ditto.
2250         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
2251         (CppStyleTestBase.perform_include_what_you_use): Ditto.
2252         (CppStyleTest.test_multi_line_comments): Added another
2253         error message which applies to the test case.
2254         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
2255         to not have config.h, since it is processed as a header file.
2256         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
2257         style and indentation in checked code.
2258         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
2259         Fixed line number.
2260         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
2261         Ditto.
2262
2263 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
2264
2265         Unreviewed, rolling out r74136.
2266         http://trac.webkit.org/changeset/74136
2267         https://bugs.webkit.org/show_bug.cgi?id=51135
2268
2269         r74136 breaks chromium canary bots because some tests are not
2270         rebaselined correctly to resolve EOL differences (Requested by
2271         jianli on #webkit).
2272
2273         * Scripts/webkitpy/layout_tests/port/base.py:
2274         * Scripts/webkitpy/layout_tests/port/test.py:
2275         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2276
2277 2010-12-15  Adam Roben  <aroben@apple.com>
2278
2279         Teach check-webkit-style to check .vcproj and .vsprops files for XML
2280         syntax errors
2281
2282         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
2283         XML syntax errors in .vcproj/.vsprops files
2284
2285         Reviewed by Dave Levin.
2286
2287         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
2288         that should be treated as XML and that should be allowed to contain
2289         carriage returns. (These lists happen to be identical currently.)
2290         (FileType): Added a new XML type.
2291         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
2292         Just does a simple file extension check.
2293         (CheckerDispatcher._file_type): Added a case for XML files.
2294         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
2295         files (surprise!).
2296         (StyleProcessor.process): Ask the dispatcher whether we should pass the
2297         lines through the carriage checker.
2298
2299         * Scripts/webkitpy/style/checker_unittest.py:
2300         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
2301         Added. Checks a few file names to see if carriage returns are allowed
2302         or not.
2303         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
2304         other assert_checker_* functions.
2305         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
2306         test_*_paths functions.
2307         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
2308         test_*_paths functions.
2309         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
2310         file from this test case, as vcproj files now have a type.
2311         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
2312         Added. Similar to the other should_* functions.
2313         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
2314         Added. Checks that carriage returns aren't checked for or stripped for
2315         allowed files.
2316
2317         * Scripts/webkitpy/style/checkers/xml.py: Added.
2318         (XMLChecker.__init__): Simple init method.
2319         (XMLChecker.check): Pass each line through the expat parser, and record
2320         a style error for any errors thrown by the parser.
2321
2322         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
2323         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
2324         produce a style error.
2325         (XMLCheckerTest.assert_error): Checks that the given XML produces an
2326         error of the given category on the given line.
2327         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
2328         checking that the XMLChecker constructor works properly.
2329         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
2330         cause a style error (see, e.g., r73887).
2331         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
2332         cause a style error (see, e.g., r73773).
2333         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
2334         properly.
2335         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
2336         tags cause a style error (see, e.g., r72795).
2337         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
2338         style error.
2339
2340 2010-12-15  Lucas Forschler  <lforschler@apple.com>
2341
2342         Reviewed by Stephanie Lewis.
2343
2344         https://bugs.webkit.org/show_bug.cgi?id=51117
2345         Add a new leopard test bot
2346         really really commit to trunk this time.
2347
2348         * BuildSlaveSupport/build.webkit.org-config/config.json:
2349
2350 2010-12-15  Sam Weinig  <sam@webkit.org>
2351
2352         Reviewed by Anders Carlsson.
2353
2354         WebKit2: Can't add files to an <input type=file>
2355         https://bugs.webkit.org/show_bug.cgi?id=51087
2356
2357         * MiniBrowser/mac/BrowserWindowController.m:
2358         (runOpenPanel):
2359         (-[BrowserWindowController awakeFromNib]):
2360         Add simple implementation of runOpenPanel callback.
2361
2362         * MiniBrowser/win/BrowserView.cpp:
2363         (BrowserView::create):
2364         * WebKitTestRunner/TestController.cpp:
2365         (WTR::createOtherPage):
2366         (WTR::TestController::initialize):
2367         Stub out runOpenPanel callback. 
2368
2369 2010-12-14  Eric Seidel  <eric@webkit.org>
2370
2371         Reviewed by Adam Barth.
2372
2373         commit-queue should upload failure diffs when tests flake
2374         https://bugs.webkit.org/show_bug.cgi?id=51051
2375
2376         To make this testable I needed to pipe FileSystem down onto tool.
2377         We've wanted it there for a long time anyway.
2378
2379         This patch is kinda a big hack.  But we don't have a nice
2380         way to read results.html files.  I think this will need further
2381         revision before this code actually feels clean.
2382
2383         As part of testing this change, I had to make MockBugzilla.create_bug
2384         actually return an id (like it should) which required updating
2385         a few other unit test results (for the better).
2386
2387         The results_matching_keys change in layouttestresults/rebasline
2388         was an alternate path which I decided not to use in the end, but
2389         I left the change as it seemed an improvement.
2390
2391         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2392         * Scripts/webkitpy/common/net/layouttestresults.py:
2393         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2394         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2395         * Scripts/webkitpy/tool/commands/queues.py:
2396         * Scripts/webkitpy/tool/commands/rebaseline.py:
2397         * Scripts/webkitpy/tool/main.py:
2398         * Scripts/webkitpy/tool/mocktool.py:
2399
2400 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
2401
2402         Reviewed by James Robinson.
2403
2404         new-run-webkit-tests ignores trailing EOL differences in text tests
2405         https://bugs.webkit.org/show_bug.cgi?id=36983
2406
2407         Changed the handling of new-line characters within new-run-webkit-tests
2408         to match old-run-webkit-tests.  Differences in leading and trailing empty
2409         lines in text expectation files are no longer ignored.
2410
2411         * Scripts/webkitpy/layout_tests/port/base.py:
2412         * Scripts/webkitpy/layout_tests/port/test.py:
2413         Added unit tests.  Removed old duplicate unit test entries.
2414         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2415
2416 2010-12-15  Ojan Vafai  <ojan@chromium.org>
2417
2418         Reviewed by Adam Barth.
2419
2420         make status-bubble white-space:nowrap so we can measure it's width without wrapping
2421         https://bugs.webkit.org/show_bug.cgi?id=51149
2422
2423         * QueueStatusServer/templates/statusbubble.html:
2424
2425 2010-12-15  Ojan Vafai  <ojan@chromium.org>
2426
2427         Reviewed by Adam Barth.
2428
2429         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
2430         https://bugs.webkit.org/show_bug.cgi?id=51125
2431
2432         * QueueStatusServer/templates/statusbubble.html:
2433
2434 2010-12-15  Darin Adler  <darin@apple.com>
2435
2436         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
2437
2438 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
2439
2440         Unreviewed, rolling out r74117.
2441         http://trac.webkit.org/changeset/74117
2442         https://bugs.webkit.org/show_bug.cgi?id=51113
2443
2444         This broke the GTK1 build. (Requested by mrobinson on
2445         #webkit).
2446
2447         * Scripts/webkitdirs.pm:
2448
2449 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
2450
2451         Reviewed by Martin Robinson.
2452
2453         Change generate-forwarding-headers.pl for GTK port usage 
2454         (https://bugs.webkit.org/show_bug.cgi?id=37369)
2455
2456         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
2457
2458 2010-12-14  Kent Tamura  <tkent@chromium.org>
2459
2460         Reviewed by Jian Li.
2461
2462         [DRT/Chromium] Remove another unnecessary error message
2463         https://bugs.webkit.org/show_bug.cgi?id=51083
2464
2465         * DumpRenderTree/chromium/WebViewHost.cpp:
2466         (WebViewHost::didInvalidateRect):
2467
2468 2010-12-14  Lucas Forschler  <lforschler@apple.com>
2469
2470         Reviewed by Stephanie Lewis.
2471
2472         Add a new Leopard Debug Test WK2 Bot
2473
2474         * BuildSlaveSupport/build.webkit.org-config/config.json:
2475
2476 2010-12-14  Ojan Vafai  <ojan@chromium.org>
2477
2478         Fix python unittests after http://trac.webkit.org/changeset/74070.
2479
2480         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2481
2482 2010-12-14  Kent Tamura  <tkent@chromium.org>
2483
2484         Reviewed by Jian Li.
2485
2486         [DRT/Chromium] Remove a unnecessary error message
2487         https://bugs.webkit.org/show_bug.cgi?id=51069
2488
2489         * DumpRenderTree/chromium/WebViewHost.cpp:
2490         (WebViewHost::paintInvalidatedRegion):
2491
2492 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
2493
2494         Reviewed by Ojan Vafai.
2495
2496         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
2497         https://bugs.webkit.org/show_bug.cgi?id=48926
2498
2499         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2500         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
2501
2502 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2503
2504         Reviewed by Eric Seidel.
2505
2506         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
2507         https://bugs.webkit.org/show_bug.cgi?id=50231
2508
2509         Guard CONFIG+=link_pkgconfig with !symbian.
2510
2511         * DumpRenderTree/qt/DumpRenderTree.pro:
2512         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2513         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2514
2515 2010-12-14  Philippe Normand  <pnormand@igalia.com>
2516
2517         Reviewed by Ojan Vafai.
2518
2519         [new-run-webkit-tests] expectations parsing is slow
2520         https://bugs.webkit.org/show_bug.cgi?id=50635
2521
2522         Avoid expensive iteration of all the tests when checking if a test
2523         file is to be skipped or not.
2524
2525         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2526         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2527         * Scripts/webkitpy/layout_tests/port/test.py:
2528
2529 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
2530
2531         Reviewed by Xan Lopez.
2532
2533         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
2534         https://bugs.webkit.org/show_bug.cgi?id=27048
2535
2536         Add support in DRT for checking whether an accessibility UI
2537         element is focusable and/or focused. Implemented for GTK.
2538
2539         * DumpRenderTree/AccessibilityUIElement.cpp:
2540         (getIsFocusedCallback): New.
2541         (getIsFocusableCallback): New.
2542         (AccessibilityUIElement::getJSClass): Add the new available
2543         callbacks for isFocused and isFocusable.
2544         * DumpRenderTree/AccessibilityUIElement.h:
2545         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2546         (AccessibilityUIElement::isFocused): New, implemented by checking
2547         whether the related AtkState value is in the object's state set.
2548         (AccessibilityUIElement::isFocusable): Ditto.
2549         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2550         (AccessibilityUIElement::isFocused): New, dummy implementation.
2551         (AccessibilityUIElement::isFocusable): Ditto.
2552         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2553         (AccessibilityUIElement::isFocused): Ditto.
2554         (AccessibilityUIElement::isFocusable): Ditto.
2555
2556 2010-12-14  Eric Seidel  <eric@webkit.org>
2557
2558         Reviewed by Ojan Vafai.
2559
2560         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
2561         https://bugs.webkit.org/show_bug.cgi?id=50715
2562
2563         This patch makes webkit-patch print the following:
2564
2565         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
2566         Install a 64-bit git for better performance, see:
2567         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
2568
2569         I wrote this mostly because I have approximately 8 machines that I use
2570         and making sure each one is using a good Git install seemed folly.
2571         webkit-patch makes a lot of git calls, so using a fast git can shave
2572         several seconds in every invocation.  See the webkit-dev thread for more info.
2573
2574         This message will print twice during 'webkit-patch upload',
2575         once from webkit-patch and once from check-webkit-style.
2576
2577         Unfortunately there is no good way to test this due to how machine-dependent
2578         the code is.  I considered writing a test for the log message, but it seemed not worth it.
2579
2580         * Scripts/webkitpy/common/checkout/scm.py:
2581
2582 2010-12-13  Eric Seidel  <eric@webkit.org>
2583
2584         Reviewed by Adam Barth.
2585
2586         FlakyTestReporter doesn't understand bots running from multiple email addresses
2587         https://bugs.webkit.org/show_bug.cgi?id=50960
2588
2589         This explains at least one of the dupes of:
2590         https://bugs.webkit.org/show_bug.cgi?id=50863
2591         that we saw filed by the commit-queue this morning.
2592         I think the other one was explained by my previous fix to result counting code.
2593
2594         Since this is really hard to test with a unit test, instead I
2595         create a new (possibly useful in the future) command
2596         which given a layout test path will return you
2597         the one bug which our tools would assume it the flaky test bug.
2598         If some other script wants to use bug-for-test we'll
2599         need to extend it with some options like --create-if-missing or similar.
2600
2601         * Scripts/webkitpy/common/net/bugzilla/bug.py:
2602         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2603         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2604         * Scripts/webkitpy/tool/commands/__init__.py:
2605         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
2606
2607 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
2608
2609         Reviewed by James Robinson.
2610
2611         Add option to build-webkit to not build WebKit2
2612         https://bugs.webkit.org/show_bug.cgi?id=50988
2613         
2614         Add support for a --no-webkit2 option to build-webkit. It seems to save
2615         ~1 minute from clean builds and ~10 seconds from no-op builds.
2616
2617         * Scripts/build-webkit:
2618
2619 2010-12-13  Lucas Forschler  <lforschler@apple.com>
2620
2621         Reviewed by Dave Kilzer.
2622
2623         Update iexploder from 1.3.2 to 1.7.2
2624         Move 1.3.2 into its own subdir
2625         Add 1.7.2 into its own subdir
2626         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
2627
2628         * Scripts/run-iexploder-tests:
2629         * Scripts/update-iexploder-cssproperties:
2630         * iExploder/CHANGELOG.txt: Removed.
2631         * iExploder/LICENSE.txt: Removed.
2632         * iExploder/README.txt: Removed.
2633         * iExploder/htdocs: Removed.
2634         * iExploder/iexploder-1.3.2: Added.
2635         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
2636         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
2637         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
2638         * iExploder/iexploder-1.3.2/htdocs: Added.
2639         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
2640         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
2641         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
2642         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
2643         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
2644         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
2645         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
2646         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
2647         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
2648         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
2649         * iExploder/iexploder-1.3.2/tools: Added.
2650         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
2651         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
2652         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
2653         * iExploder/iexploder-1.7.2: Added.
2654         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
2655         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
2656         * iExploder/iexploder-1.7.2/README.txt: Added.
2657         * iExploder/iexploder-1.7.2/output: Added.
2658         * iExploder/iexploder-1.7.2/src: Added.
2659         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
2660         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
2661         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
2662         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
2663         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
2664         * iExploder/iexploder-1.7.2/src/css-properties: Added.
2665         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
2666         * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
2667         * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
2668         * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
2669         * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
2670         * iExploder/iexploder-1.7.2/src/css-pseudo: Added.
2671         * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
2672         * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
2673         * iExploder/iexploder-1.7.2/src/css-values: Added.
2674         * iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
2675         * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
2676         * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
2677         * iExploder/iexploder-1.7.2/src/css-values/other: Added.
2678         * iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
2679         * iExploder/iexploder-1.7.2/src/headers: Added.
2680         * iExploder/iexploder-1.7.2/src/headers/dillo: Added.
2681         * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
2682         * iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
2683         * iExploder/iexploder-1.7.2/src/headers/webkit: Added.
2684         * iExploder/iexploder-1.7.2/src/html-attrs: Added.
2685         * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
2686         * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
2687         * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
2688         * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
2689         * iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
2690         * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
2691         * iExploder/iexploder-1.7.2/src/html-tags: Added.
2692         * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
2693         * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
2694         * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
2695         * iExploder/iexploder-1.7.2/src/html-tags/other: Added.
2696         * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
2697         * iExploder/iexploder-1.7.2/src/html-values: Added.
2698         * iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
2699         * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
2700         * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
2701         * iExploder/iexploder-1.7.2/src/html-values/other: Added.
2702         * iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
2703         * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
2704         * iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
2705         * iExploder/iexploder-1.7.2/src/index.html: Added.
2706         * iExploder/iexploder-1.7.2/src/media: Added.
2707         * iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
2708         * iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
2709         * iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
2710         * iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
2711         * iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
2712         * iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
2713         * iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
2714         * iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
2715         * iExploder/iexploder-1.7.2/src/media/bug.png: Added.
2716         * iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
2717         * iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
2718         * iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
2719         * iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
2720         * iExploder/iexploder-1.7.2/src/mime-types: Added.
2721         * iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
2722         * iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
2723         * iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
2724         * iExploder/iexploder-1.7.2/src/protocols: Added.
2725         * iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
2726         * iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
2727         * iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
2728         * iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
2729         * iExploder/iexploder-1.7.2/src/scanner.rb: Added.
2730         * iExploder/iexploder-1.7.2/src/version.rb: Added.
2731         * iExploder/iexploder-1.7.2/src/webserver.rb: Added.
2732         * iExploder/iexploder-1.7.2/testcases: Added.
2733         * iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
2734         * iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
2735         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added.
2736         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added.
2737         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added.
2738         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added.
2739         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added.
2740         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added.
2741         * iExploder/iexploder-1.7.2/tools: Added.
2742         * iExploder/iexploder-1.7.2/tools/lasthit.rb: Added.
2743         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added.
2744         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added.
2745         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added.
2746         * iExploder/tools: Removed.
2747
2748 2010-12-13  Sam Weinig  <sam@webkit.org>
2749
2750         Reviewed by Anders Carlsson.
2751
2752         Remove associated page concept from WKView constructor
2753         https://bugs.webkit.org/show_bug.cgi?id=50983
2754
2755         Step 1: Remove associate page constructors from WKView and make
2756         all views use the shared namespace for the context.
2757
2758         * TestWebKitAPI/PlatformWebView.h:
2759         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2760         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2761         * WebKitTestRunner/PlatformWebView.h:
2762         * WebKitTestRunner/TestController.cpp:
2763         (WTR::createOtherPage):
2764         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2765         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2766         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2767
2768 2010-12-13  Sam Weinig  <sam@webkit.org>
2769
2770         Reviewed by Anders Carlsson.
2771
2772         Change the WebKit2 public API so there is no explicit WKPageNamespace object
2773         https://bugs.webkit.org/show_bug.cgi?id=50898
2774
2775         * MiniBrowser/mac/AppDelegate.h:
2776         * MiniBrowser/mac/AppDelegate.m:
2777         * MiniBrowser/mac/BrowserWindowController.h:
2778         * MiniBrowser/mac/BrowserWindowController.m:
2779         * MiniBrowser/win/BrowserView.cpp:
2780         Convert MiniBrowser to not use PageNamespaces.
2781
2782         * TestWebKitAPI/PlatformWebView.h:
2783         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
2784         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
2785         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
2786         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
2787         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
2788         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
2789         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
2790         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2791         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2792         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
2793         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
2794         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
2795         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
2796         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2797         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2798         Convert TestWebKitAPI to not use PageNamespaces.
2799
2800         * WebKitTestRunner/PlatformWebView.h:
2801         * WebKitTestRunner/TestController.cpp:
2802         * WebKitTestRunner/TestController.h:
2803         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2804         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2805         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2806         Convert WebKitTestRunner to not use PageNamespaces.
2807
2808 2010-12-13  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2809
2810         Reviewed by Eric Seidel.
2811
2812         webkit-patch rollout should be able to do multi-revision rollouts
2813         https://bugs.webkit.org/show_bug.cgi?id=33336
2814
2815         Make it possible to pass more than one revision to webkit-patch.
2816
2817         * Scripts/webkitpy/common/checkout/api.py:
2818         * Scripts/webkitpy/common/checkout/changelog.py:
2819         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2820         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
2821         * Scripts/webkitpy/tool/commands/download.py:
2822         * Scripts/webkitpy/tool/commands/download_unittest.py:
2823         * Scripts/webkitpy/tool/mocktool.py:
2824         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
2825         * Scripts/webkitpy/tool/steps/revertrevision.py:
2826
2827 2010-12-13  Eric Seidel  <eric@webkit.org>
2828
2829         Unreviewed.
2830
2831         Teach webkit-patch how to search bugzilla
2832         https://bugs.webkit.org/show_bug.cgi?id=50500
2833
2834         webkit-patch bug-search fails when there is only one result.
2835         Turns out we needed a bit more logic in our result count parsing code.
2836
2837         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2838         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2839
2840 2010-12-13  Antti Koivisto  <antti@apple.com>
2841
2842         Reviewed by Alexey Proskuryakov.
2843
2844         Add setSerializeHTTPLoads function to allow testing resource load order on OS X.
2845         https://bugs.webkit.org/show_bug.cgi?id=50758
2846
2847         * DumpRenderTree/LayoutTestController.cpp:
2848         (setSerializeHTTPLoadsCallback):
2849         (LayoutTestController::staticFunctions):
2850         * DumpRenderTree/LayoutTestController.h:
2851         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2852         (LayoutTestController::setSerializeHTTPLoads):
2853         * DumpRenderTree/mac/DumpRenderTree.mm:
2854         (resetDefaultsToConsistentValues):
2855         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2856         (LayoutTestController::setSerializeHTTPLoads):
2857         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2858         (LayoutTestController::setSerializeHTTPLoads):
2859
2860 2010-12-13  Dimitri Glazkov  <dglazkov@chromium.org>
2861
2862         Reviewed by Ojan Vafai.
2863
2864         Remove "use-drt" option from test step command line, since the option was removed in r73748.
2865         https://bugs.webkit.org/show_bug.cgi?id=50936
2866
2867         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed the option.
2868
2869 2010-12-13  Patrick Gansterer  <paroga@webkit.org>
2870
2871         Reviewed by Csaba Osztrogonác.
2872
2873         Add revlink to BuildBot status
2874         https://bugs.webkit.org/show_bug.cgi?id=50914
2875
2876         This adds a hyperlink to trac changeset on the revision numbers. 
2877
2878         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2879
2880 2010-12-13  Andras Becsi  <abecsi@webkit.org>
2881
2882         Reviewed by Csaba Osztrogonác.
2883
2884         [Qt][WK2] Fix build if WebKitTools are not available
2885         https://bugs.webkit.org/show_bug.cgi?id=50242
2886
2887         * MiniBrowser/qt/MiniBrowser.pro: Correct the comment.
2888         * Scripts/webkitdirs.pm: Added WebKitTools/MiniBrowser to $subdirs.
2889         * MiniBrowser/DerivedSources.pro: Added.
2890
2891 2010-12-13  Eric Seidel  <eric@webkit.org>
2892
2893         Reviewed by Adam Barth.
2894
2895         EWS Queues should remove orpahned pyc files before starting
2896         https://bugs.webkit.org/show_bug.cgi?id=50904
2897
2898         A previous check added a platform.py which caused
2899         EWS bots on some platforms to hit an import exception.
2900         The platform.py file was removed in a subsequent commit, but
2901         the EWS bots in question stayed stuck.  This change will
2902         fix those bots once restarted (and prevent this in the future).
2903
2904         I also went ahead and unified start-queue and start-commit-queue
2905         since they were nearly identical.  I also added bot_id support
2906         to both force all EWSes to have bot ids as well as get rid of the one
2907         remaining reason why I had my own copies of these scripts.
2908         Hopefully this will be enough to get all the other bot admins
2909         (ahem, Adam, ahem) to move to using these checked in copies as well.
2910
2911         * EWSTools/start-commit-queue.sh: Removed.
2912         * EWSTools/start-queue.sh:
2913
2914 2010-10-28  MORITA Hajime  <morrita@google.com>
2915
2916         Reviewed by Ojan Vafai.
2917
2918         spellcheck does not check pasted text
2919         https://bugs.webkit.org/show_bug.cgi?id=40092
2920
2921         Added LayoutTestController::setAsynchronousSpellCheckingEnabled()
2922         to control the setting.
2923
2924         * DumpRenderTree/LayoutTestController.cpp:
2925         (setAsynchronousSpellCheckingEnabledCallback):
2926         (LayoutTestController::staticFunctions):
2927         * DumpRenderTree/LayoutTestController.h:
2928         * DumpRenderTree/chromium/LayoutTestController.h:
2929         * DumpRenderTree/chromium/LayoutTestController.cpp:
2930         (LayoutTestController::LayoutTestController):
2931         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
2932         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2933         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
2934         * DumpRenderTree/mac/DumpRenderTree.mm:
2935         (resetDefaultsToConsistentValues):
2936         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2937         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
2938         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2939         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2940         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
2941         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2942         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
2943         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2944         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
2945
2946 2010-12-12  Sam Weinig  <sam@webkit.org>
2947
2948         Reviewed by Anders Carlsson.
2949
2950         Fix failing API test. It turns out that a pop-state event
2951         is sent before every fragment navigation, so we have to test
2952         for it in addition in PageLoadDidChangeLocationWithinPageForFrame.
2953
2954         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2955         (TestWebKitAPI::didSameDocumentNavigationForFrame):
2956
2957 2010-12-12  Alejandro G. Castro  <alex@igalia.com>
2958
2959         Reviewed by Eric Seidel.
2960
2961         [GTK] Add new-run-webkit-tests support to gtk
2962         https://bugs.webkit.org/show_bug.cgi?id=50681
2963
2964         Adding the basic support to run the new-run-webkit-tests.
2965
2966         * Scripts/webkitpy/layout_tests/port/gtk.py:
2967
2968 2010-10-11  Diego Gonzalez  <diegohcg@webkit.org>
2969
2970         Reviewed by Kenneth Rohde Christiansen.
2971
2972         [Qt] Mock DeviceOrientation client for DRT
2973         https://bugs.webkit.org/show_bug.cgi?id=47490
2974
2975         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2976         (WebCore::DumpRenderTree::DumpRenderTree):
2977         (WebCore::DumpRenderTree::~DumpRenderTree):
2978         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2979         (LayoutTestController::setMockDeviceOrientation):
2980
2981 2010-12-11  Philippe Normand  <pnormand@igalia.com>
2982
2983         Reviewed by Gustavo Noronha Silva.
2984
2985         [GTK] launcher: disable the Mozilla-style fullscreen API
2986         https://bugs.webkit.org/show_bug.cgi?id=50874
2987
2988         Disabling the fullscreen API until its implementation for GTK is
2989         mature enough. The webview setting for it is already FALSE by
2990         default.
2991
2992         * GtkLauncher/main.c:
2993         (createWindow):
2994
2995 2010-12-10  Eric Seidel  <eric@webkit.org>
2996
2997         Reviewed by Adam Barth.
2998
2999         commit-queue flaky test messages show cryptic version information for mac os x
3000         https://bugs.webkit.org/show_bug.cgi?id=50864
3001
3002         Turns out platform.platform() returns kernel version information
3003         which isn't helpful, and just plain confusing on Mac
3004         (OS X 10.6.5 uses Darwin Kernel 10.5.0).
3005
3006         So I've updated PlatformInfo.display_name() to special case
3007         mac.  I also found a bad use of sys.platform in the process
3008         and fixed that.  (sys.platform always returns 'darwin' on mac).
3009
3010         * Scripts/webkitpy/common/system/platforminfo.py:
3011         * Scripts/webkitpy/common/system/user.py:
3012         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3013         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3014         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3015
3016 2010-12-10  Eric Seidel  <eric@webkit.org>
3017
3018         Unreviewed.
3019
3020         Exception seen while reporting flaky test with commit-queue.
3021         Just a missing include.
3022
3023         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3024         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3025
3026 2010-12-10  Kinuko Yasuda  <kinuko@chromium.org>
3027
3028         Reviewed by Eric Seidel.
3029
3030         [Chromium] Remove old JSONResultsGenerator script that existed for backward-compatibility
3031         https://bugs.webkit.org/show_bug.cgi?id=50796
3032
3033         Also updating the test code to use JSONResultsGeneratorBase and
3034         to improve test coverage for incremental cases.
3035
3036         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3037         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3038
3039 2010-12-10  Joseph Pecoraro  <joepeck@webkit.org>
3040
3041         Reviewed by Darin Adler.
3042
3043         prepare-ChangeLog --help doesn't mention --bug shorthand -b
3044         https://bugs.webkit.org/show_bug.cgi?id=50835
3045
3046         * Scripts/prepare-ChangeLog: be more explicit about -b and match file style.
3047
3048 2010-12-10  Eric Seidel  <eric@webkit.org>
3049
3050         Reviewed by Adam Barth.
3051
3052         Bugs created by the commit-queue should all block on a master bug
3053         https://bugs.webkit.org/show_bug.cgi?id=50857
3054
3055         This makes all bugs created by the commit-queue block on:
3056         https://bugs.webkit.org/show_bug.cgi?id=50856
3057
3058         In the process of testing this, I found that the existing
3059         create_bug code was wrong.  I also found that existing
3060         unit tests for create-rollout used invalid values
3061         for options.blocks.  I fixed both issues and tested.
3062
3063         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3064         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3065         * Scripts/webkitpy/tool/commands/commandtest.py:
3066         * Scripts/webkitpy/tool/commands/download_unittest.py:
3067         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3068         * Scripts/webkitpy/tool/mocktool.py:
3069         * Scripts/webkitpy/tool/steps/options.py:
3070
3071 2010-12-10  Eric Seidel  <eric@webkit.org>
3072
3073         Reviewed by Adam Barth.
3074
3075         Teach webkitpy how to follow duplicate chains when posting comments on flake bugs
3076         https://bugs.webkit.org/show_bug.cgi?id=50853
3077
3078         I also discovered when doing this that the code was posting
3079         the comment on the wrong bug, but that's fixed here too.
3080
3081         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3082         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3083         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3084         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3085         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3086         * Scripts/webkitpy/tool/mocktool.py:
3087
3088 2010-12-10  Anders Carlsson  <andersca@apple.com>
3089
3090         Reviewed by John Sullivan.
3091
3092         Make WKContextGetStatistics gather global statistics
3093         https://bugs.webkit.org/show_bug.cgi?id=50850
3094
3095         Remove the code that gets the statistics and fills in the per context
3096         statistics information for now.
3097
3098         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
3099         (-[BrowserStatisticsWindowController refreshStatistics:]):
3100
3101 2010-12-10  Eric Seidel  <eric@webkit.org>
3102
3103         Unreviewed.
3104
3105         commit-queue should report port/platform information when commenting on flaky test bugs
3106         https://bugs.webkit.org/show_bug.cgi?id=50839
3107
3108         Renamed platform.py to platforminfo.py.  This broke import platform in executive.py
3109         which was only used by new run webkit tests (and clearly not unit tested).
3110
3111         * Scripts/webkitpy/common/system/platforminfo.py: Renamed from WebKitTools/Scripts/webkitpy/common/system/platform.py.
3112         * Scripts/webkitpy/tool/main.py:
3113         * Scripts/webkitpy/tool/mocktool.py:
3114
3115 2010-12-10  Eric Seidel  <eric@webkit.org>
3116
3117         Reviewed by Tony Chang.
3118
3119         commit-queue should report port/platform information when commenting on flaky test bugs
3120         https://bugs.webkit.org/show_bug.cgi?id=50839
3121
3122         This was a suggestion from Tony Chang this morning.
3123         I added a platform.py class so I could easily mock the platform call,
3124         but that may not be the final solution for this mocking.
3125         We'll try it and see.
3126
3127         * Scripts/webkitpy/common/system/platform.py: Added.
3128         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3129         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3130         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3131         * Scripts/webkitpy/tool/main.py:
3132         * Scripts/webkitpy/tool/mocktool.py:
3133
3134 2010-12-10  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>
3135
3136         Reviewed by Joseph Pecoraro.
3137
3138         Bug 43455 - [Qt]: Implement Application Cache Quotas
3139         https://bugs.webkit.org/show_bug.cgi?id=43455
3140
3141         Introduce functions to allow new appcache layout test origin-quota.html
3142         to work correctly under Qt.
3143
3144         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3145         (WebCore::DumpRenderTree::DumpRenderTree):
3146         (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
3147         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3148
3149         Introduce functions to allow new appcache layout test origin-quota.html
3150         to be successful under qt. Changes required because LayoutTestControllerQt
3151         does not inherit from LayoutController.
3152
3153         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3154         (LayoutTestController::reset):
3155         (LayoutTestController::clearAllApplicationCaches):
3156         (LayoutTestController::setApplicationCacheOriginQuota):
3157         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3158         (LayoutTestController::shouldDumpApplicationCacheDelegateCallbacks):
3159         (LayoutTestController::dumpApplicationCacheDelegateCallbacks):
3160
3161 2010-12-10  Eric Seidel  <eric@webkit.org>
3162
3163         Reviewed by Adam Barth.
3164
3165         Move buildbot.py into its own module so we can split it out into one-file-per-class
3166         https://bugs.webkit.org/show_bug.cgi?id=50806
3167
3168         We're adding more buildbot logic these days, so it makes sense
3169         to give buildbot its own module.
3170
3171         * Scripts/webkitpy/common/net/buildbot/__init__.py: Added.
3172         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot.py.
3173         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot_unittest.py.
3174         * Scripts/webkitpy/common/net/failuremap.py:
3175         * Scripts/webkitpy/common/net/regressionwindow.py:
3176         * Scripts/webkitpy/tool/commands/rebaseline.py:
3177
3178 2010-12-10  Tony Chang  <tony@chromium.org>
3179
3180         Reviewed by Eric Seidel.
3181
3182         Use FileSystem::remove when cleaning up http lock files
3183         https://bugs.webkit.org/show_bug.cgi?id=50830
3184
3185         * Scripts/webkitpy/layout_tests/port/http_lock.py:
3186
3187 2010-12-10  Joone Hur  <joone@kldp.org>
3188
3189         Reviewed by Martin Robinson.
3190
3191         [GTK] DRT needs layoutTestController.setCacheModel
3192         https://bugs.webkit.org/show_bug.cgi?id=50705
3193         
3194         webkit_set_cache_mode() is called to set the cache model.
3195         
3196         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3197         (LayoutTestController::setCacheModel): Set the cache model. 
3198
3199 2010-12-10  Tony Chang  <tony@chromium.org>
3200
3201         Reviewed by Ojan Vafai.
3202
3203         [chromium] remove --use-drt and add --use-test-shell
3204         https://bugs.webkit.org/show_bug.cgi?id=50701
3205
3206         * Scripts/webkitpy/common/config/ports.py:
3207         * Scripts/webkitpy/common/config/ports_unittest.py:
3208         * Scripts/webkitpy/layout_tests/port/chromium.py:
3209         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3210         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3211         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3212         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3213         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3214         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3215         * Scripts/webkitpy/layout_tests/port/webkit.py:
3216         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3217         * Scripts/webkitpy/style/checkers/test_expectations.py:
3218         * Scripts/webkitpy/tool/commands/queries.py:
3219
3220 2010-12-10  John Knottenbelt  <jknotten@chromium.org>
3221
3222         Reviewed by Steve Block.
3223
3224         [Chromium] Implement mocks for client-based geolocation
3225         https://bugs.webkit.org/show_bug.cgi?id=46895
3226
3227         * DumpRenderTree/chromium/LayoutTestController.cpp:
3228         (LayoutTestController::setGeolocationPermission):
3229         (LayoutTestController::setMockGeolocationPosition):
3230         (LayoutTestController::setMockGeolocationError):
3231         * DumpRenderTree/chromium/LayoutTestController.h:
3232         * DumpRenderTree/chromium/WebViewHost.cpp:
3233         (WebViewHost::geolocationClient):
3234         (WebViewHost::geolocationClientMock):
3235         (WebViewHost::reset):
3236         * DumpRenderTree/chromium/WebViewHost.h:
3237
3238 2010-12-10  Alejandro G. Castro  <alex@igalia.com>
3239
3240         Reviewed by Martin Robinson.
3241
3242         [GTK] Add hasSpellingMarker support to the DRT
3243         https://bugs.webkit.org/show_bug.cgi?id=50739
3244
3245         Implemented the hasSpellingMarker to support spelling tests.
3246
3247         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3248         (LayoutTestController::hasSpellingMarker):
3249
3250 2010-12-10  Eric Seidel  <eric@webkit.org>
3251
3252         Reviewed by Ojan Vafai.
3253
3254         webkit-patch: not possible to use build-and-test with local commits
3255         https://bugs.webkit.org/show_bug.cgi?id=33378
3256
3257         Make --no-clean not even check if we have local commits.
3258         It's unclear to me why the code was originally written this way.
3259         I was unable to dig up a reason from svn history.
3260
3261         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
3262         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
3263
3264 2010-12-10  Mario Sanchez Prada  <msanchez@igalia.com>
3265
3266         Reviewed by Martin Robinson.
3267
3268         [GTK] AX: implement isEnabled in DRT
3269         https://bugs.webkit.org/show_bug.cgi?id=50814
3270
3271         Implement AccessibilityUIElement::isEnabled() for GTK.
3272
3273         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3274         (checkElementState): New function to refactor common code.
3275         (AccessibilityUIElement::isEnabled): Implement this by checking
3276         the current state of the AtkObject.
3277         (AccessibilityUIElement::isSelected): Use the new
3278         checkElementState function.
3279
3280 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3281
3282         Reviewed by Kenneth Rohde Christiansen.
3283
3284         [Qt][WK2] Add the QWKContext API class to wrap the WebContext.
3285         https://bugs.webkit.org/show_bug.cgi?id=50750
3286
3287         * MiniBrowser/qt/BrowserView.cpp:
3288         (BrowserView::BrowserView):
3289         * MiniBrowser/qt/BrowserView.h:
3290         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3291         (WTR::WebView::WebView):
3292
3293 2010-12-10  Joone Hur  <joone@kldp.org>
3294
3295         Reviewed by Xan Lopez.
3296
3297         [GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet
3298         https://bugs.webkit.org/show_bug.cgi?id=50808
3299
3300         Unskipping the following test cases:
3301         userscripts/mixed-case-stylesheet.html
3302         userscripts/simple-stylesheet.html
3303         userscripts/user-style-all-frames.html
3304
3305         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3306         (LayoutTestController::addUserStyleSheet):
3307
3308 2010-12-10  Joone Hur  <joone@kldp.org>
3309
3310         Reviewed by Eric Seidel.
3311
3312         [GTK] Add DRT support for pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet
3313         https://bugs.webkit.org/show_bug.cgi?id=50783
3314
3315         This patch allows to unskip the following test cases:
3316         printing/page-rule-selection.html
3317         printing/page-format-data.html
3318
3319         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3320         (LayoutTestController::pageProperty): Added.
3321         (LayoutTestController::isPageBoxVisible): Ditto.
3322         (LayoutTestController::pageSizeAndMarginsInPixels): Ditto.
3323         (LayoutTestController::addUserStyleSheet): Ditto.
3324
3325 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3326
3327         Reviewed by Kenneth Rohde Christiansen.
3328
3329         [Qt] Make QtTestBrowser spawn QNAM in a secondary thread.
3330
3331         A menu allows to switch QNAM back to the same thread.
3332
3333         * QtTestBrowser/launcherwindow.cpp:
3334         (LauncherWindow::initializeView):
3335         (LauncherWindow::createChrome):
3336         (LauncherWindow::toggleThreadedQnam):
3337         * QtTestBrowser/launcherwindow.h:
3338         (WindowOptions::WindowOptions):
3339         * QtTestBrowser/webpage.cpp:
3340         (WebPage::WebPage):
3341         (WebPage::setQnamThreaded):
3342         * QtTestBrowser/webpage.h:
3343         (QnamThread::QnamThread):
3344         (QnamThread::~QnamThread):
3345         (QnamThread::networkAccessManager):
3346         (QnamThread::run):
3347
3348 2010-12-10  Martin Robinson  <mrobinson@igalia.com>
3349
3350         Reviewed by Xan Lopez.
3351
3352         [Gtk] style="font-family: courier" makes text disappear
3353         https://bugs.webkit.org/show_bug.cgi?id=47452
3354
3355         Add a test that verifies that fonts without valid charmaps are
3356         never selected.
3357
3358         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3359         (initializeFonts): Initialize DRT with our font (derived from Ahem)
3360         that has no valid charmap.
3361         * DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon: Added.
3362         * DumpRenderTree/gtk/fonts/fonts.conf: Updated settings to override users'
3363         settings which may disable selection of bitmap fonts.
3364
3365 2010-12-10  Eric Seidel  <eric@webkit.org>
3366
3367         Unreviewed.
3368
3369         The commit-queue should file bugs about flaky tests it encounters
3370         https://bugs.webkit.org/show_bug.cgi?id=50803
3371
3372         create_bug_for_flaky_test was insufficiently tested, thus buggy.
3373         Now it's tested.
3374
3375         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3376         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3377
3378 2010-12-10  Eric Seidel  <eric@webkit.org>
3379
3380         Unreviewed.  Somehow this last-minute edit didn't quite get committed.
3381
3382         The commit-queue should file bugs about flaky tests it encounters
3383         https://bugs.webkit.org/show_bug.cgi?id=50803
3384
3385         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3386
3387 2010-12-09  Eric Seidel  <eric@webkit.org>
3388
3389         Reviewed by Adam Barth.
3390
3391         The commit-queue should file bugs about flaky tests it encounters
3392         https://bugs.webkit.org/show_bug.cgi?id=50803
3393
3394         This change got a bit big.  I also added a new config.urls file
3395         because I needed to share the view_source_url code with committervalidator.py.
3396
3397         This adds a new class FlakyTestReporter which holds all the logic about
3398         reporting flaky tests to bugzilla.
3399
3400         Right now this code knows how to look up bugs for flaky tests.
3401         If it can't find a bug filed from the commit-queue, it will open a new
3402         one, ccing the relevant people and adding information about the failure.
3403
3404         It is not yet smart enough to chase down duplicate chains, or to include
3405         the actual failure diff.  But those can be added in later iterations.
3406
3407         * Scripts/webkitpy/common/checkout/api.py:
3408         * Scripts/webkitpy/common/checkout/changelog.py:
3409         * Scripts/webkitpy/common/checkout/commitinfo.py:
3410         * Scripts/webkitpy/common/config/committervalidator.py:
3411         * Scripts/webkitpy/common/config/urls.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
3412         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3413         * Scripts/webkitpy/tool/bot/flakytestreporter.py: Added.
3414         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
3415         * Scripts/webkitpy/tool/bot/irc_command.py:
3416         * Scripts/webkitpy/tool/bot/sheriff.py:
3417         * Scripts/webkitpy/tool/commands/download.py:
3418         * Scripts/webkitpy/tool/commands/queues.py:
3419         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3420         * Scripts/webkitpy/tool/comments.py:
3421         * Scripts/webkitpy/tool/mocktool.py:
3422         * Scripts/webkitpy/tool/steps/commit.py:
3423
3424 2010-12-09  Eric Seidel  <eric@webkit.org>
3425
3426         Reviewed by Adam Barth.
3427
3428         Teach webkit-patch how to search bugzilla
3429         https://bugs.webkit.org/show_bug.cgi?id=50500
3430
3431         This is a step towards teaching webkitpy how to file
3432         new bugs for flaky tests and update them when new flakes occur.
3433
3434         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3435         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3436         * Scripts/webkitpy/tool/commands/__init__.py:
3437         * Scripts/webkitpy/tool/commands/bugsearch.py: Added.
3438
3439 2010-12-09  Adam Barth  <abarth@webkit.org>
3440
3441         Reviewed by Ojan Vafai.
3442
3443         commit-queue errors out due to local commits
3444         https://bugs.webkit.org/show_bug.cgi?id=50766
3445
3446         We seem to be tripping over having local commits in the working copy a
3447         lot recently.  I don't quite fully understand what the issue is, but
3448         this patch attempts to solve the problem by adding an explicit clean
3449         step before processing a patch.  Previously, we did the cleaning as
3450         part of the apply-attachment step, so this might not actually fix the
3451         problem.
3452
3453         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3454         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3455         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3456
3457 2010-12-09  Dirk Pranke  <dpranke@chromium.org>
3458
3459         Reviewed by Ojan Vafai.
3460
3461         Make new-run-webkit-tests --lint-test-files log slightly better
3462         messages and return -1 if lint fails. Remove the
3463         'suppress_errors' keyword param to the TestExpectationsFile
3464         class, and clean up logging and exception raising for error
3465         handling. Also add more unit tests and clean up the unit test code a bit.
3466
3467         https://bugs.webkit.org/show_bug.cgi?id=50205
3468
3469         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3470         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3471         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py
3472         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py
3473         * Scripts/webkitpy/layout_tests/port/chromium.py:
3474         * Scripts/webkitpy/style/checkers/test_expectations.py:
3475         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3476
3477 2010-12-09  Tony Chang  <tony@chromium.org>
3478
3479         Unreviewed, fix for windows code.  We were catching the wrong
3480         exception in Windows.
3481
3482         * Scripts/webkitpy/common/system/filesystem.py:
3483
3484 2010-12-09  Antonio Gomes  <agomes@rim.com>
3485
3486         Reviewed by Martin Robinson.
3487
3488         [Gtk] Populate DumpRenderTreeSupportGtk (part IV)
3489         https://bugs.webkit.org/show_bug.cgi?id=48429
3490
3491         Adjust call sites of webkit_thread_count to use the DumpRenderTreeSupportGtk version now.
3492
3493         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3494         (LayoutTestController::workerThreadCount):
3495
3496 2010-12-06  Philippe Normand  <pnormand@igalia.com>
3497
3498         Reviewed by Martin Robinson.
3499
3500         [GTK] Support the Mozilla-style Fullscreen Javascript API
3501         https://bugs.webkit.org/show_bug.cgi?id=50572
3502
3503         Enable the Javascript Fullscreen support in the GtkLauncher. Also
3504         make DRT update the Chrome when the WebView settings have been
3505         reset to consistent values.
3506
3507         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3508         (resetDefaultsToConsistentValues):
3509         * GtkLauncher/main.c:
3510         (create_window):
3511         * Scripts/build-webkit:
3512
3513 2010-12-09  Koan-Sin Tan  <koansin.tan@gmail.com>
3514
3515         Reviewed by Tor Arne Vestbø
3516
3517         [Qt] run-launcher doesn't start the browser on Mac OS X 10.6
3518         https://bugs.webkit.org/show_bug.cgi?id=50742
3519
3520         check not only QtWebKit.framework/QtWebKit but also libQtWebKit.dylib
3521
3522         * Scripts/webkitdirs.pm:
3523
3524 2010-12-09  Joone Hur  <joone@kldp.org>
3525
3526          Reviewed by Martin Robinson.
3527
3528          [GTK] Support for viewport meta tag
3529          https://bugs.webkit.org/show_bug.cgi?id=45443
3530
3531          Add support for testing the viewport properties for WebKitGtk.
3532
3533          * DumpRenderTree/LayoutTestController.cpp:
3534          (dumpConfigurationForViewportCallback): Added this JS callback to set the size of the visible viewport.
3535          (LayoutTestController::staticFunctions):
3536          * DumpRenderTree/LayoutTestController.h:
3537          * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3538          (LayoutTestController::dumpConfigurationForViewport): Added this function to test the viewport properties.
3539          * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3540          (LayoutTestController::dumpConfigurationForViewport): Ditto.
3541          * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3542          (LayoutTestController::dumpConfigurationForViewport): Ditto.
3543          * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3544          (LayoutTestController::dumpConfigurationForViewport): Ditto.
3545          * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3546          (LayoutTestController::dumpConfigurationForViewport): Ditto.
3547
3548 2010-12-08  William Siegrist <wsiegrist@apple.com>
3549
3550         Reviewed by Eric Seidel.
3551
3552         Migrate buildbot.py from xmlrpc to json.
3553         https://bugs.webkit.org/show_bug.cgi?id=50647
3554
3555         * Scripts/webkitpy/common/net/buildbot.py:
3556
3557 2010-12-08  Tony Chang  <tony@chromium.org>
3558
3559         Reviewed by Eric Seidel.
3560
3561         make starting the websocket server more reliable on windows
3562         https://bugs.webkit.org/show_bug.cgi?id=50712
3563
3564         * Scripts/webkitpy/common/system/filesystem.py:
3565         (remove): Substitute method for os.remove to retry on error on Windows
3566         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3567         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Use FileSystem.remove
3568
3569 2010-12-08  Jessie Berlin  <jberlin@apple.com>
3570
3571         Reviewed by Adam Roben.
3572
3573         WebKit2: Implement WebChromeClient::exceededDatabaseQuota
3574         https://bugs.webkit.org/show_bug.cgi?id=50656
3575
3576         * MiniBrowser/mac/BrowserWindowController.m:
3577         (-[BrowserWindowController awakeFromNib]):
3578         Indicate that exceededDatabaseQuota is not implemented.
3579         * MiniBrowser/win/BrowserView.cpp:
3580         (BrowserView::create):
3581         Ditto.
3582         * WebKitTestRunner/TestController.cpp:
3583         (WTR::createOtherPage):
3584         Ditto.
3585         (WTR::TestController::initialize):
3586         Ditto.
3587
3588 2010-12-08  Antonio Gomes  <agomes@rim.com>
3589
3590         Reviewed by Martin Robinson.
3591
3592         [Gtk] Populate DumpRenderTreeSupportGtk (part III)
3593         https://bugs.webkit.org/show_bug.cgi?id=48429
3594
3595         Moved the following methods from webkitprivate.h to DumpRenderTreeSupportGtk.cpp|h:
3596         * webkit_gc_collect_javascript_objects;
3597         * webkit_gc_collect_javascript_objects_on_alternate_thread;
3598         * webkit_gc_count_javascript_objects;
3599         * webkit_web_frame_layout.
3600
3601         These were all only used by GTK+ DRT.
3602
3603         * DumpRenderTree/gtk/EventSender.cpp:
3604         (dispatchEvent):
3605         * DumpRenderTree/gtk/GCControllerGtk.cpp:
3606         (GCController::collect):
3607         (GCController::collectOnAlternateThread):
3608         (GCController::getJSObjectCount):
3609
3610 2010-12-07  Tony Chang  <tony@chromium.org>
3611
3612         Reviewed by Ojan Vafai.
3613
3614         [chromium] force NRWT to use DRT
3615         https://bugs.webkit.org/show_bug.cgi?id=50359
3616
3617         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3618
3619 2010-12-06  Sam Weinig  <sam@webkit.org>
3620
3621         Reviewed by Anders Carlsson.
3622
3623         Generalize didChangeLocationWithinPageForFrame for all same document navigations
3624         https://bugs.webkit.org/show_bug.cgi?id=50584
3625
3626         * MiniBrowser/mac/BrowserWindowController.m:
3627         (didSameDocumentNavigationForFrame):
3628         (-[BrowserWindowController awakeFromNib]):
3629         (-[BrowserWindowController didSameDocumentNavigationForFrame:]):
3630         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3631         (TestWebKitAPI::didSameDocumentNavigationForFrame):
3632         (TestWebKitAPI::TEST):
3633         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3634         (WTR::InjectedBundlePage::InjectedBundlePage):
3635         (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame):
3636         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3637         * WebKitTestRunner/TestController.cpp:
3638         (WTR::TestController::initialize):
3639
3640 2010-12-06  Kinuko Yasuda  <kinuko@chromium.org>
3641
3642         Reviewed by Ojan Vafai.
3643
3644         Make TestResultsServer return 404 for non-existing results files.
3645         https://bugs.webkit.org/show_bug.cgi?id=50581
3646
3647         * TestResultServer/handlers/testfilehandler.py:
3648
3649 2010-12-06  Tony Chang  <tony@chromium.org>