cffbfaf1b67c151524a2fb8d2e0f1222d8e5855b
[WebKit-https.git] / Tools / ChangeLog
1 2013-12-10  Ryuan Choi  <ryuan.choi@samsung.com>
2
3         Unreviewed EFL build fix attempt
4
5         * TestWebKitAPI/CMakeLists.txt: Added ${WEBKIT2_DIR}/Platform/CoreIPC to include lists.
6         * WebKitTestRunner/CMakeLists.txt: Ditto.
7
8 2013-12-10  Anders Carlsson  <andersca@apple.com>
9
10         Add a HashMap constructor that takes an initializer list
11         https://bugs.webkit.org/show_bug.cgi?id=125551
12
13         Reviewed by Dan Bernstein.
14
15         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
16         (TestWebKitAPI::TEST):
17
18 2013-12-10  Laszlo Vidacs  <lac@inf.u-szeged.hu>
19
20         Use std::array when computing MD5 checksum
21         https://bugs.webkit.org/show_bug.cgi?id=125509
22
23         Reviewed by Anders Carlsson.
24
25         Use MD5::Digest type and MD5::hashSize when computing MD5 checksum.
26
27         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
28         (computeMD5HashStringForBitmapContext):
29         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
30         (computeMD5HashStringForBitmapContext):
31         * TestWebKitAPI/Tests/WTF/MD5.cpp:
32         (TestWebKitAPI::expectMD5):
33         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
34         (WTR::computeMD5HashStringForCairoSurface):
35         * WebKitTestRunner/cg/TestInvocationCG.cpp:
36         (WTR::computeMD5HashStringForContext):
37
38 2013-12-10  Mario Sanchez Prada  <mario.prada@samsung.com>
39
40         [ATK] Expose splitter elements with ATK_ROLE_SEPARATOR
41         https://bugs.webkit.org/show_bug.cgi?id=125522
42
43         Reviewed by Chris Fleizach.
44
45         Update strings representing ATK_ROLE_SEPARATOR for layout tests.
46
47         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
48         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
49
50 2013-12-10  Laszlo Vidacs  <lac@inf.u-szeged.hu>
51
52         Add --makeargs option to build-jsc
53         https://bugs.webkit.org/show_bug.cgi?id=125344
54
55         Reviewed by Filip Pizlo.
56
57         * Scripts/build-jsc: Handle and pass makefile arguments in jsc build.
58
59 2013-12-10  Joanmarie Diggs  <jdiggs@igalia.com>
60
61         AX: [ATK] Convert the get_text atktest.c unit tests to layout tests
62         https://bugs.webkit.org/show_bug.cgi?id=125497
63
64         Reviewed by Mario Sanchez Prada.
65
66         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
67         (AccessibilityUIElement::stringForRange): Implemented.
68         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
69         (WTR::AccessibilityUIElement::stringForRange): Implemented.
70
71 2013-12-10  Martin Robinson  <mrobinson@igalia.com>
72
73         Various fixes for the CMake GTK+ build
74
75         Reviewed by Gustavo Noronha.
76
77         * MiniBrowser/gtk/CMakeLists.txt: Update source list and correct the name of BrowserMarshal.h.
78         * TestWebKitAPI/PlatformGTK.cmake: Add GTK+ libraries to the test program. They're required.
79
80 2013-12-10  László Langó  <lango@inf.u-szeged.hu>
81
82         --cloop option does not work in Tools/Scripts/build-jsc.
83         https://bugs.webkit.org/show_bug.cgi?id=125214
84
85         Reviewed by Csaba Osztrogonác.
86
87         * Scripts/build-jsc:
88
89 2013-12-10  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
90
91         Merge mark_for_landing and mark_for_commit_queue into one argument
92         https://bugs.webkit.org/show_bug.cgi?id=125448
93
94         Reviewed by Ryosuke Niwa.
95
96         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
97         (CommitQueueFlag):
98         (Bugzilla._commit_queue_flag):
99         (Bugzilla._fill_attachment_form):
100         (Bugzilla.add_patch_to_bug):
101         (Bugzilla.create_bug):
102         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
103         (test_commit_queue_flag.assert_commit_queue_flag):
104         (test_commit_queue_flag):
105
106 2013-12-09  Tim Horton  <timothy_horton@apple.com>
107
108         Remove dead extract_reference_link.py (and the reftests module)
109         https://bugs.webkit.org/show_bug.cgi?id=125116
110
111         Reviewed by Ryosuke Niwa.
112
113         This code doesn't seem to have ever been used.
114
115         * Scripts/webkitpy/layout_tests/reftests/__init__.py: Removed.
116         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link.py: Removed.
117         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py: Removed.
118
119 2013-12-09  Mario Sanchez Prada  <mario.prada@samsung.com>
120
121         [ATK] Translate ATK_ROLE_SECTION into "AXSection" in DRT/WKTR
122         https://bugs.webkit.org/show_bug.cgi?id=125456
123
124         Reviewed by Chris Fleizach.
125
126         Return 'AXSection' for section roles instead of 'AXDiv'.
127
128         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
129         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
130
131 2013-12-09  Brian J. Burg  <burg@cs.washington.edu>
132
133         check-webkit-style should check for extra newlines at EOF
134         https://bugs.webkit.org/show_bug.cgi?id=125424
135
136         Reviewed by Darin Adler.
137
138         Report a style violation if extraneous newlines are added
139         to the end of a C++ file. There should only be one newline at EOF.
140
141         * Scripts/webkitpy/style/checkers/cpp.py:
142         (check_for_missing_new_line_at_eof): Renamed from check_for_new_line_at_eof.
143         (check_for_extra_new_line_at_eof): Added.
144         (_process_lines): Added new check and renamed existing EOF check.
145         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
146         (CppStyleTest.test_extra_newlines_at_eof): Added.
147         (CppStyleTest.test_extra_newlines_at_eof.do_test): Added.
148
149 2013-12-09  Laszlo Vidacs  <lac@inf.u-szeged.hu>
150
151         check-webkit-style: ternary operator in macro call identified as initialization list
152         https://bugs.webkit.org/show_bug.cgi?id=125443
153
154         Reviewed by Ryosuke Niwa.
155
156         Do not match initialization list when questionmark is placed before :
157
158         * Scripts/webkitpy/style/checkers/cpp.py:
159         (check_member_initialization_list):
160
161 2013-12-09  Joanmarie Diggs  <jdiggs@igalia.com>
162
163         AX: [ATK] Convert the get_{string,text}_at_offset atktest.c unit tests to layout tests
164         https://bugs.webkit.org/show_bug.cgi?id=125451
165
166         Reviewed by Mario Sanchez Prada.
167
168         Create the needed callbacks for DRT and WKTR.
169
170         * DumpRenderTree/AccessibilityUIElement.cpp:
171         (characterAtOffsetCallback): added
172         (wordAtOffsetCallback): added
173         (lineAtOffsetCallback): added
174         (sentenceAtOffsetCallback): added
175         (AccessibilityUIElement::getJSClass):
176         * DumpRenderTree/AccessibilityUIElement.h:
177         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
178         (stringAtOffset): added
179         (AccessibilityUIElement::characterAtOffset): added
180         (AccessibilityUIElement::wordAtOffset): added
181         (AccessibilityUIElement::lineAtOffset): added
182         (AccessibilityUIElement::sentenceAtOffset): added
183         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
184         (WTR::AccessibilityUIElement::characterAtOffset): added
185         (WTR::AccessibilityUIElement::wordAtOffset): added
186         (WTR::AccessibilityUIElement::lineAtOffset): added
187         (WTR::AccessibilityUIElement::sentenceAtOffset): added
188         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
189         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
190         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
191         (WTR::stringAtOffset): added
192         (WTR::AccessibilityUIElement::characterAtOffset): added
193         (WTR::AccessibilityUIElement::wordAtOffset): added
194         (WTR::AccessibilityUIElement::lineAtOffset): added
195         (WTR::AccessibilityUIElement::sentenceAtOffset): added
196
197 2013-12-08  Sam Weinig  <sam@webkit.org>
198
199         32-bit MiniBrowser doesn't build
200         https://bugs.webkit.org/show_bug.cgi?id=125420
201
202         Reviewed by Dan Bernstein.
203
204         * MiniBrowser/mac/AppDelegate.h:
205         * MiniBrowser/mac/AppDelegate.m:
206         (-[BrowserAppDelegate init]):
207         (-[BrowserAppDelegate applicationWillTerminate:]):
208
209 2013-12-08  Brian Holt  <brian.holt@samsung.com>
210
211         [WK2] Add ENABLE_NETWORK_PROCESS flag
212         https://bugs.webkit.org/show_bug.cgi?id=125421
213
214         Add support to build with the Network Process enabled.
215
216         Reviewed by Martin Robinson.
217
218         * Scripts/webkitperl/FeatureList.pm:
219
220 2013-12-07  Filip Pizlo  <fpizlo@apple.com>
221
222         Fold typedArray.length if typedArray is constant
223         https://bugs.webkit.org/show_bug.cgi?id=125252
224
225         Reviewed by Sam Weinig.
226         
227         Add Source/JavaScriptCore/tests/stress to the set of JS tests. This is where you
228         should put tests that run just like JSRegress but don't run as part of LayoutTests.
229         Currently I'm using it for tests that require some surgical support from jsc.cpp.
230
231         * Scripts/run-javascriptcore-tests:
232
233 2013-12-08  Zan Dobersek  <zdobersek@igalia.com>
234
235         [gdb] Update printers for WTF::CString, JSC::JSString
236         https://bugs.webkit.org/show_bug.cgi?id=124600
237
238         Reviewed by Gustavo Noronha Silva.
239
240         Update the two printers after they fell behind the changes in implementation.
241
242         * gdb/webkit.py:
243         (WTFCStringPrinter.to_string):
244         (JSCJSStringPrinter.to_string):
245
246 2013-12-08  Zan Dobersek  <zdobersek@igalia.com>
247
248         [webkitpy] Add a WestonDriver unit test
249         https://bugs.webkit.org/show_bug.cgi?id=125408
250
251         Reviewed by Gustavo Noronha Silva.
252
253         Add a webkitpy unit test for the Weston driver.
254
255         * Scripts/webkitpy/port/westondriver_unittest.py: Added.
256         (WestonDriverTest):
257         (WestonDriverTest.make_driver): Sets up a new WestonDriver instance for testing purposes.
258         (WestonDriverTest.test_start): Check that the Weston compositor is launched properly and that
259         the server environment contains proper WAYLAND and GDK_BACKEND entries.
260         (WestonDriverTest.test_stop): Check that the Weston compositor is terminated properly and that
261         the driver cleans up the temporary directory.
262         (WestonDriverTest.test_stop.FakeWestonProcess): A helper class that logs the expected termination.
263         (WestonDriverTest.test_stop.FakeWestonProcess.terminate):
264
265 2013-12-08  Brendan Long  <b.long@cablelabs.com>
266
267         [Gtk] install-dependencies doesn't install libgtk-3-dev
268         https://bugs.webkit.org/show_bug.cgi?id=125320
269
270         Reviewed by Gustavo Noronha Silva.
271
272         * gtk/install-dependencies: Add libgtk-3-dev, libsoup2.4 and subversion
273
274 2013-12-07  Sam Weinig  <sam@webkit.org>
275
276         [Cocoa] Convert a few more parts of MiniBrowser over to the Objective-C API
277         https://bugs.webkit.org/show_bug.cgi?id=125401
278
279         Reviewed by Dan Bernstein.
280
281         * MiniBrowser/mac/WK2BrowserWindowController.m:
282         (-[WK2BrowserWindowController fetch:]):
283         (-[WK2BrowserWindowController reload:]):
284         (-[WK2BrowserWindowController goBack:]):
285         (-[WK2BrowserWindowController goForward:]):
286         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
287         (-[WK2BrowserWindowController currentZoomFactor]):
288         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
289         (-[WK2BrowserWindowController zoomIn:]):
290         (-[WK2BrowserWindowController zoomOut:]):
291         (-[WK2BrowserWindowController canResetZoom]):
292         (-[WK2BrowserWindowController resetZoom:]):
293         (-[WK2BrowserWindowController toggleZoomMode:]):
294         (-[WK2BrowserWindowController updateTextFieldFromURL:]):
295
296 2013-12-07  Sam Weinig  <sam@webkit.org>
297
298         Convert MiniBrowser to use WKProcessGroup and WKBrowsingContextGroup
299         https://bugs.webkit.org/show_bug.cgi?id=125400
300
301         Reviewed by Dan Bernstein.
302
303         * MiniBrowser/mac/AppDelegate.h:
304         * MiniBrowser/mac/AppDelegate.m:
305         * MiniBrowser/mac/WK2BrowserWindowController.h:
306         * MiniBrowser/mac/WK2BrowserWindowController.m:
307         (-[WK2BrowserWindowController initWithProcessGroup:browsingContextGroup:]):
308         (-[WK2BrowserWindowController dealloc]):
309         (createNewPage):
310         (-[WK2BrowserWindowController awakeFromNib]):
311         (-[WK2BrowserWindowController browsingContextController:didNavigateWithNavigationData:]):
312         (-[WK2BrowserWindowController browsingContextController:didPerformClientRedirectFromURL:toURL:]):
313         (-[WK2BrowserWindowController browsingContextController:didPerformServerRedirectFromURL:toURL:]):
314         (-[WK2BrowserWindowController browsingContextController:didUpdateHistoryTitle:forURL:]):
315         Replace global WKContextRef and WKPageGroupRef with WKProcessGroup and WKBrowsingContextGroup. Also
316         replace context based WKContextHistoryClient with WKBrowsingContextController based WKBrowsingContextHistoryDelegate
317
318 2013-12-07  Gustavo Noronha Silva  <gns@gnome.org>
319
320         [GTK] Run each gtest subtest separately instead of in one go
321         https://bugs.webkit.org/show_bug.cgi?id=125386
322
323         Reviewed by Martin Robinson.
324
325         This is what other ports are doing (except they build each test as a separate binary)
326         and will help with the timeouts we sometimes hit because it applies to the full test
327         run.
328
329         * Scripts/run-gtk-tests:
330         (TestRunner._get_tests_from_google_test_suite): get a list of available sub-tests.
331         (TestRunner._run_google_test): run a single subtest from a gtest binary.
332         (TestRunner._run_google_test_suite): call the binary once per subtest.
333
334 2013-12-07  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
335
336         Move PrettyPatch related code to prettypatch.py
337         https://bugs.webkit.org/show_bug.cgi?id=124937
338
339         Reviewed by Ryosuke Niwa.
340
341         This code seems to have a better place here than in Port, since PrettyPatch already knows
342         pretty_patch_path, and this also unifies the usage of PrettyPatch
343
344         * Scripts/webkitpy/common/prettypatch.py:
345         (PrettyPatch.__init__):
346         (PrettyPatch.pretty_diff):
347         (PrettyPatch):
348         (PrettyPatch.pretty_patch_available):
349         (PrettyPatch.check_pretty_patch):
350         (PrettyPatch.pretty_patch_text):
351         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
352         (TestResultWriter.create_text_diff_and_write_result):
353         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
354         (summarize_results):
355         * Scripts/webkitpy/port/base.py:
356         (Port.__init__):
357         (Port.wdiff_available):
358         (Port.check_image_diff):
359         (Port.wdiff_text):
360         * Scripts/webkitpy/port/base_unittest.py:
361         (PortTest.test_pretty_patch_os_error):
362         (PortTest.test_pretty_patch_script_error):
363
364 2013-12-06  Dan Bernstein  <mitz@apple.com>
365
366         [Mac] MiniBrowser Debug builds are compiled with -Os
367         https://bugs.webkit.org/show_bug.cgi?id=125376
368
369         Reviewed by Tim Horton.
370
371         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Set GCC_OPTIMIZATION_LEVEL to 0 for
372         the Debug configuration at the project level.
373
374 2013-12-06  Jer Noble  <jer.noble@apple.com>
375
376         [MSE] Add a runtime-setting for the MediaSource constructor.
377         https://bugs.webkit.org/show_bug.cgi?id=125336
378
379         Reviewed by Eric Carlson.
380
381         Enable MediaSource in DRT and WKTR.
382
383         * DumpRenderTree/mac/DumpRenderTree.mm:
384         (resetWebPreferencesToConsistentValues):
385         * WebKitTestRunner/TestController.cpp:
386         (WTR::TestController::resetPreferencesToConsistentValues):
387
388 2013-12-06  Jer Noble  <jer.noble@apple.com>
389
390         Strip out extraneous logging from AppleGVA in media tests.
391         https://bugs.webkit.org/show_bug.cgi?id=125357
392
393         Reviewed by Simon Fraser.
394
395         Add a mechanism for stripping out abritrary regular expressions from test input and output.
396
397         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
398         (SingleTestRunner._run_compare_test): Strip out logging
399         * Scripts/webkitpy/port/base.py:
400         (Port.logging_patterns_to_strip): Return an empty list by default.
401         * Scripts/webkitpy/port/driver.py:
402         (DriverOutput.strip_patterns): Apply the port specific patterns to the text.
403         * Scripts/webkitpy/port/mac.py:
404         (MacPort.logging_patterns_to_strip): Return a complete list.
405
406 2013-12-06  Dean Jackson  <dino@apple.com>
407
408         Updating ANGLE should point to instructions
409         https://bugs.webkit.org/show_bug.cgi?id=125361
410
411         Reviewed by Eric Carlson.
412
413         Point to https://trac.webkit.org/wiki/UpdatingANGLE when
414         someone wants to patch ANGLE.
415
416         * Scripts/webkitpy/common/config/watchlist:
417
418 2013-12-06  Dan Bernstein  <mitz@apple.com>
419
420         [Mac] Transition MiniBrowser to the Cocoa API: load delegate
421         https://bugs.webkit.org/show_bug.cgi?id=125334
422
423         Reviewed by Darin Adler.
424
425         * MiniBrowser/mac/WK2BrowserWindowController.m:
426         (-[WK2BrowserWindowController dealloc]): Nil out the load delegate and stop observing the
427         title property.
428         (-[WK2BrowserWindowController isPaginated]): Changed to use Cocoa SPI.
429         (-[WK2BrowserWindowController togglePaginationMode:]): Ditto.
430         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]): Update the
431         window title with the title property changes.
432         (-[WK2BrowserWindowController awakeFromNib]): Start observing the title property. Changed to
433         set the load delegate instead of the load client.
434         (-[WK2BrowserWindowController updateTextFieldFromURL:]): Changed to use Cocoa types.
435         (-[WK2BrowserWindowController updateProvisionalURL]): Removed frame parameter.
436         (-[WK2BrowserWindowController updateCommittedURL]): Ditto.
437         (-[WK2BrowserWindowController browsingContextControllerDidStartProvisionalLoad:]):
438         Implemented this load delegate method.
439         (-[WK2BrowserWindowController browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]):
440         Ditto.
441         (-[WK2BrowserWindowController browsingContextController:didFailProvisionalLoadWithError:]): Ditto.
442         (-[WK2BrowserWindowController browsingContextControllerDidCommitLoad:]): Ditto.
443         (-[WK2BrowserWindowController browsingContextControllerDidFinishLoad:]): Ditto.
444         (-[WK2BrowserWindowController browsingContextController:didFailLoadWithError:]): Ditto.
445         (-[WK2BrowserWindowController browsingContextControllerDidChangeBackForwardList:addedItem:removedItems:]):
446         Ditto.
447         (-[WK2BrowserWindowController browsingContextController:canAuthenticateAgainstProtectionSpace:]):
448         Ditto.
449         (-[WK2BrowserWindowController browsingContextController:didReceiveAuthenticationChallenge:]): Ditto.
450
451 2013-12-06  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
452
453         Remove function from style/checkers/cpp.py.
454         https://bugs.webkit.org/show_bug.cgi?id=125341
455
456         Reviewed by Darin Adler.
457
458         Corrects a FIXME: by removing a function from cpp.py.
459
460         * Scripts/webkitpy/style/checkers/cpp.py:
461         (CppChecker.__init__):
462         (CppChecker.check):
463         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
464         (CppStyleTestBase.process_file_data):
465
466 2013-12-06  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
467
468         check-webkit-style: false positive warning for indentation of #ifdef code.
469         https://bugs.webkit.org/show_bug.cgi?id=125254
470
471         Reviewed by Darin Adler.
472
473         * Scripts/webkitpy/style/checkers/cpp.py:
474         (check_member_initialization_list):
475         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
476         (WebKitStyleTest.test_member_initialization_list):
477
478 2013-12-06  Chris Fleizach  <cfleizach@apple.com>
479
480         Fix spelling error in style checker: beggining
481         https://bugs.webkit.org/show_bug.cgi?id=125347
482
483         Reviewed by Anders Carlsson.
484
485         * Scripts/webkitpy/style/checkers/cpp.py:
486         (check_member_initialization_list):
487         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
488         (WebKitStyleTest.test_member_initialization_list):
489
490 2013-12-06  Lukasz Gajowy  <l.gajowy@samsung.com>
491
492         [ATK] Missing aria roles mappings
493         https://bugs.webkit.org/show_bug.cgi?id=117729
494
495         Reviewed by Mario Sanchez Prada.
496
497         Added new mappings to AccessibilityUIElementAtk.cpp.
498
499         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
500         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
501
502 2013-12-06  Csaba Osztrogonác  <ossy@webkit.org>
503
504         Typo fix after r160218.
505
506         * Scripts/webkitpy/test/main.py:
507         (main):
508
509 2013-12-06  Csaba Osztrogonác  <ossy@webkit.org>
510
511         Unreviewed fix after r160206.
512
513         * Scripts/webkitpy/test/main.py:
514         (main): sys.platform can be win32 or cygwin too on Windows.
515
516 2013-12-05  Csaba Osztrogonác  <ossy@webkit.org>
517
518         Disable WebKit2 webkitpy unittests on Windows
519         https://bugs.webkit.org/show_bug.cgi?id=125318
520
521         Reviewed by Ryosuke Niwa.
522
523         * Scripts/webkitpy/test/main.py:
524         (main):
525
526 2013-12-05  Anders Carlsson  <andersca@apple.com>
527
528         Tweak WeakObjCPtr
529         https://bugs.webkit.org/show_bug.cgi?id=125311
530
531         Reviewed by Darin Adler.
532
533         Split up tests into more logical groups. Add new tests for new functionality.
534
535         * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm:
536
537 2013-12-05  Carlos Garcia Campos  <cgarcia@igalia.com>
538
539         [GTK] Fix gtk-doc warnings when generating DOM bindings API docs
540         https://bugs.webkit.org/show_bug.cgi?id=125302
541
542         Reviewed by Philippe Normand.
543
544         * gtk/generate-webkitdom-doc-files:
545         (WebKitDOMDocGeneratorSections.write_footer): Add a new section
546         containing a private subsection for WEBKIT_API, WEBKIT_DEPRECATED
547         and WEBKIT_DEPRECATED_FOR macros.
548
549 2013-12-05  Laszlo Vidacs  <lac@inf.u-szeged.hu>
550
551         Fix cross compilation on x86
552         https://bugs.webkit.org/show_bug.cgi?id=125295
553
554         Reviewed by Zoltan Herczeg.
555
556         Certain compiler flags should not be added when cross compilation is enabled.
557
558         * Scripts/webkitdirs.pm:
559         (runAutogenForAutotoolsProjectIfNecessary):
560         (generateBuildSystemFromCMakeProject):
561
562 2013-12-05  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
563
564         Remove duplicated/dead code from cpp style checker unit tests.
565         https://bugs.webkit.org/show_bug.cgi?id=125226
566
567         Reviewed by Ryosuke Niwa.
568
569         Remove the first definition of OrderOfIncludesTest class as it is
570         overwritten by the second. Remove a duplicated assert statement
571         from the second class.
572
573         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
574         (OrderOfIncludesTest.setUp):
575         (OrderOfIncludesTest.test_try_drop_common_suffixes):
576           The last assert was duplicated.
577
578 2013-12-05  László Langó  <lango@inf.u-szeged.hu>
579
580         Remove Scripts/generate-qt-inspector-resource.
581         https://bugs.webkit.org/show_bug.cgi?id=125288
582
583         Reviewed by Andreas Kling.
584
585         * Scripts/generate-qt-inspector-resource: Removed. There is no QT anymore.
586         We don't need this file.
587
588 2013-12-05  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
589
590         Remove certain methods from TestExpectations and use TestExpectationsModel instead of them
591         https://bugs.webkit.org/show_bug.cgi?id=125218
592
593         Reviewed by Ryosuke Niwa.
594
595         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
596         (LayoutTestFinder.skip_tests):
597         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
598         (LayoutTestRunner.run_tests):
599         (LayoutTestRunner._update_summary_with_result):
600         * Scripts/webkitpy/layout_tests/controllers/manager.py:
601         (Manager._test_is_slow):
602         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
603         (JSONLayoutResultsGenerator._insert_failure_summaries):
604         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
605         (TestExpectations.get_rebaselining_failures):
606         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
607         (assert_exp):
608         (MiscTests.test_multiple_results):
609         (MiscTests.test_category_expectations):
610         (MiscTests.test_get_modifiers):
611         (MiscTests.test_get_expectations_string):
612         (MiscTests.test_expectation_to_string):
613         (MiscTests.test_get_test_set):
614         (MiscTests.test_more_specific_override_resets_skip):
615         (SkippedTests.check):
616         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
617         (TestRunResults.__init__):
618         (summarize_results):
619         * Scripts/webkitpy/tool/commands/rebaseline.py:
620         (RebaselineExpectations._tests_to_rebaseline):
621
622 2013-12-04  Ryosuke Niwa  <rniwa@webkit.org>
623
624         Enable HTMLTemplateElement by default
625         https://bugs.webkit.org/show_bug.cgi?id=123851
626
627         Reviewed by Antti Koivisto.
628
629         * Scripts/webkitperl/FeatureList.pm:
630
631 2013-12-04  Jozsef Berta  <jberta@inf.u-szeged.hu>
632
633         [EFL] Bumping GStreamer version to 1.2.1
634         https://bugs.webkit.org/show_bug.cgi?id=125155
635
636         Reviewed by Gyuyoung Kim.
637
638         * efl/jhbuild.modules: Set the GStreamer version to 1.2.1
639
640
641 2013-12-04  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
642
643         Update jhbuild revision.
644         https://bugs.webkit.org/show_bug.cgi?id=124966
645         
646         Reviewed by Gyuyoung Kim.
647
648         Used version of Jhbuild failed to create directories and caused
649         update-webkitefl-libs to fail. Latest Jhbuild version has it fixed.
650
651         * jhbuild/jhbuild-wrapper:
652
653 2013-12-04  Anders Carlsson  <andersca@apple.com>
654
655         Add a WeakObjCPtr class
656         https://bugs.webkit.org/show_bug.cgi?id=125267
657
658         Reviewed by Geoffrey Garen.
659
660         Add API tests for WeakObjCPtr.
661
662         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
663         * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm: Added.
664         (TEST):
665
666 2013-12-04  Anders Carlsson  <andersca@apple.com>
667
668         Make the estimatedProgress property observable using KVO
669         https://bugs.webkit.org/show_bug.cgi?id=125259
670
671         Reviewed by Dan Bernstein.
672
673         Bind the progress indicator value to the "estimatedProgress" property.
674
675         * MiniBrowser/mac/WK2BrowserWindowController.m:
676         (-[WK2BrowserWindowController dealloc]):
677         (-[WK2BrowserWindowController awakeFromNib]):
678
679 2013-12-04  Anders Carlsson  <andersca@apple.com>
680
681         Add a loading property to WKBrowsingContextController
682         https://bugs.webkit.org/show_bug.cgi?id=125256
683
684         Reviewed by Dan Bernstein.
685
686         Bind the progress indicator visibility to the "loading" property.
687
688         * MiniBrowser/mac/WK2BrowserWindowController.m:
689         (-[WK2BrowserWindowController dealloc]):
690         (-[WK2BrowserWindowController awakeFromNib]):
691         (-[WK2BrowserWindowController didStartProgress]):
692         (-[WK2BrowserWindowController didFinishProgress]):
693
694 2013-12-04  Nick Diego Yamane  <nick.yamane@openbossa.org>
695
696         [EFL][WK2] Buildfix after r160104
697         https://bugs.webkit.org/show_bug.cgi?id=125231
698
699         Reviewed by Anders Carlsson.
700
701         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
702         (TestWebKitAPI::TEST): reinterpret_cast<WKFooClientBase*>(&client) -> &client.base
703         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
704         (TestWebKitAPI::setViewClient): Ditto.
705
706 2013-12-04  Myles C. Maxfield  <mmaxfield@apple.com>
707
708         check-webkit-style detected some ternary statements as initialization lists
709         https://bugs.webkit.org/show_bug.cgi?id=125246
710
711         Reviewed by Dean Jackson.
712
713         The regular expression that check-webkit-tests uses to detect initialization
714         lists was too broad, resulting in false positives. This patch makes the
715         regex more specific
716
717         * Scripts/webkitpy/style/checkers/cpp.py:
718         (check_member_initialization_list):
719         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
720         (WebKitStyleTest.test_member_initialization_list):
721
722 2013-12-04  Mark Hahnenberg  <mhahnenberg@apple.com>
723
724         run-jsc-stress-tests can only run locally
725         https://bugs.webkit.org/show_bug.cgi?id=124551
726
727         Reviewed by Filip Pizlo.
728
729         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Fixed a couple issues. One was if the script was
730         killed before the lock directory was removed, future executions wouldn't make any progress. Also 
731         added a couple more signals to handle gracefully at shutdown. 
732         * Scripts/run-javascriptcore-tests: Pass through the --remote argument to run-jsc-stress-tests.
733         * Scripts/run-jsc-stress-tests: Added support for the --remote flag. It accepts a hostname, user, and port.
734         The script then generates the test bundle, tars it up, and copies it to the remote host via ssh where
735         it then untars the bundle and executes the shell-based test runner. Also refactored some of the logic
736         toward the end of the script to make it easier to tell which of the various modes do what.
737
738 2013-12-04  Csaba Osztrogonác  <ossy@webkit.org>
739
740         [EFL][WK2] Buildfix after r160104
741         https://bugs.webkit.org/show_bug.cgi?id=125233
742
743         Reviewed by Anders Carlsson.
744
745         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
746         (TestWebKitAPI::TEST):
747         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
748         (TestWebKitAPI::setPageLoaderClient):
749
750 2013-12-03  Anders Carlsson  <andersca@apple.com>
751
752         Deprecate all unversioned client structs in favor of having explicit versioned structs
753         https://bugs.webkit.org/show_bug.cgi?id=125203
754
755         Reviewed by Dan Bernstein.
756
757         Update for WebKit2 API changes.
758
759         * MiniBrowser/mac/AppDelegate.m:
760         (-[BrowserAppDelegate init]):
761         * MiniBrowser/mac/WK2BrowserWindowController.m:
762         (-[WK2BrowserWindowController awakeFromNib]):
763         * TestWebKitAPI/InjectedBundleController.cpp:
764         (TestWebKitAPI::InjectedBundleController::initialize):
765         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
766         (TestWebKitAPI::TEST):
767         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
768         (TestWebKitAPI::setInjectedBundleClient):
769         * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp:
770         (TestWebKitAPI::TEST):
771         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
772         (TestWebKitAPI::TEST):
773         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
774         (TestWebKitAPI::TEST):
775         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
776         (TestWebKitAPI::DOMWindowExtensionBasic::didCreatePage):
777         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
778         (TestWebKitAPI::TEST):
779         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
780         (TestWebKitAPI::DOMWindowExtensionNoCache::didCreatePage):
781         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp:
782         (TestWebKitAPI::setInjectedBundleClient):
783         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
784         (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
785         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
786         (TestWebKitAPI::TEST):
787         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
788         (TestWebKitAPI::TEST):
789         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
790         (TestWebKitAPI::setContextDownloadClient):
791         (TestWebKitAPI::setPagePolicyClient):
792         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
793         (TestWebKitAPI::TEST):
794         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
795         (TestWebKitAPI::TEST):
796         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
797         (TestWebKitAPI::TEST):
798         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
799         (TestWebKitAPI::TEST):
800         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
801         (TestWebKitAPI::TEST):
802         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
803         (TestWebKitAPI::TEST):
804         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
805         (TestWebKitAPI::setupGeolocationProvider):
806         (TestWebKitAPI::setupView):
807         (TestWebKitAPI::TEST):
808         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
809         (TestWebKitAPI::TEST):
810         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
811         (TestWebKitAPI::setPageLoaderClient):
812         (TestWebKitAPI::setInjectedBundleClient):
813         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
814         (TestWebKitAPI::HitTestResultNodeHandleTest::didCreatePage):
815         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
816         (TestWebKitAPI::TEST):
817         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
818         (TestWebKitAPI::setInjectedBundleClient):
819         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
820         (TestWebKitAPI::InjectedBundleFrameHitTestTest::didCreatePage):
821         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
822         (TestWebKitAPI::TEST):
823         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
824         (TestWebKitAPI::TEST):
825         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
826         (TestWebKitAPI::TEST):
827         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
828         (TestWebKitAPI::TEST):
829         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
830         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::didCreatePage):
831         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
832         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
833         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
834         (TestWebKitAPI::setPageLoaderClient):
835         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
836         (TestWebKitAPI::setPageLoaderClient):
837         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
838         (TestWebKitAPI::setPageLoaderClient):
839         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
840         (TestWebKitAPI::setPageLoaderClient):
841         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
842         (TestWebKitAPI::setPageLoaderClient):
843         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
844         (TestWebKitAPI::TEST):
845         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
846         (TestWebKitAPI::TEST):
847         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
848         (TestWebKitAPI::setInjectedBundleClient):
849         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
850         (TestWebKitAPI::ParentFrameTest::didCreatePage):
851         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
852         (TestWebKitAPI::setInjectedBundleClient):
853         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
854         (TestWebKitAPI::PasteboardNotificationsTest::didCreatePage):
855         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
856         (TestWebKitAPI::TEST):
857         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
858         (TestWebKitAPI::TEST):
859         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
860         (TestWebKitAPI::TEST):
861         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
862         (TestWebKitAPI::TEST):
863         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
864         (TestWebKitAPI::setInjectedBundleClient):
865         (TestWebKitAPI::setPageLoaderClient):
866         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
867         (TestWebKitAPI::setPageLoaderClient):
868         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
869         (TestWebKitAPI::TEST):
870         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
871         (TestWebKitAPI::setPageLoaderClient):
872         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
873         (TestWebKitAPI::ShouldGoToBackForwardListItemTest::didCreatePage):
874         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
875         (TestWebKitAPI::TEST):
876         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp:
877         (TestWebKitAPI::TEST):
878         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp:
879         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setInjectedBundleClient):
880         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
881         * TestWebKitAPI/Tests/WebKit2/WKConnection.cpp:
882         (TestWebKitAPI::TEST):
883         * TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp:
884         (TestWebKitAPI::WKConnectionTest::initialize):
885         * TestWebKitAPI/Tests/WebKit2/WKPageGetScaleFactorNotZero.cpp:
886         (TestWebKitAPI::setPageLoaderClient):
887         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
888         (TestWebKitAPI::setInjectedBundleClient):
889         (TestWebKitAPI::TEST):
890         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
891         (TestWebKitAPI::WebKit2WillLoadTest::setInjectedBundleClient):
892         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
893         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent.cpp:
894         (TestWebKitAPI::setInjectedBundleClient):
895         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
896         (TestWebKitAPI::WillSendSubmitEventTest::didCreatePage):
897         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
898         (TestWebKitAPI::TEST):
899         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
900         (TestWebKitAPI::setInjectedBundleClient):
901         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
902         (TestWebKitAPI::TEST):
903         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
904         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
905         (TestWebKitAPI::DenyWillSendRequestTest::didCreatePage):
906         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
907         (TestWebKitAPI::didCreateConnection):
908         (TestWebKitAPI::TEST):
909         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
910         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
911         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm:
912         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
913         (TestWebKitAPI::setPageLoaderClient):
914         * WebKitTestRunner/GeolocationProviderMock.cpp:
915         (WTR::GeolocationProviderMock::GeolocationProviderMock):
916         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
917         (WTR::InjectedBundle::initialize):
918         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
919         (WTR::InjectedBundlePage::InjectedBundlePage):
920         * WebKitTestRunner/TestController.cpp:
921         (WTR::TestController::createOtherPage):
922         (WTR::TestController::initialize):
923         (WTR::TestController::createWebViewWithOptions):
924
925 2013-12-04  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
926
927         Style checker for .messages.in files (WTF:: prefix)
928         https://bugs.webkit.org/show_bug.cgi?id=125142
929
930         Reviewed by Anders Carlsson.
931
932         A new style checker for .messages.in files, that checks for the use of WTF::
933         prefix in these files. (Also checks for tabs as these files were previously
934         handled as text files.)
935
936         * Scripts/webkitpy/style/checker.py:
937         (CheckerDispatcher._create_checker):
938           New checker is returned for .messages.in files.
939         * Scripts/webkitpy/style/checkers/messagesin.py: Added.
940           The new style checker class.
941         (MessagesInChecker):
942         (MessagesInChecker.__init__):
943         (MessagesInChecker.check):
944         (MessagesInChecker.check_WTF_prefix):
945         * Scripts/webkitpy/style/checkers/messagesin_unittest.py: Added.
946           Unit test for the new style  checker class.
947         (MessagesInCheckerStyleTestCase):
948         (test_checker):
949         (test_checker.error_handler_for_test):
950         (MessagesInCheckerTestCase):
951         (MessagesInCheckerTestCase.test_init):
952         (MessagesInCheckerTestCase.test_init.error_handler_for_test):
953
954 2013-12-04  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
955
956         Style checker requires alphabetical ordering in cmake lists even it contains variable.
957         https://bugs.webkit.org/show_bug.cgi?id=124918
958
959         Reviewed by Csaba Osztrogonác.
960
961         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
962         (CMakeCheckerTest.test_check):
963         * Scripts/webkitpy/style/checkers/cmake.py:
964         (CMakeChecker._check_list_order):
965         This will ignore lines with variable substitution.
966
967 2013-12-04  László Langó  <lango@inf.u-szeged.hu>
968
969         check-webkit-style is wrong about expected format parameter pack rvalue reference arguments
970         https://bugs.webkit.org/show_bug.cgi?id=124731
971
972         Reviewed by Zoltan Herczeg.
973
974         * Scripts/webkitpy/style/checkers/cpp.py:
975         (check_spacing):
976         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
977         (Cpp11StyleTest.test_rvaule_reference_in_parameter_pack):
978
979 2013-12-04  László Langó  <lango@inf.u-szeged.hu>
980
981         Remove codecs and os dependencies from filereader.py in webkitpy/style.
982         https://bugs.webkit.org/show_bug.cgi?id=124719
983
984         Although TextFileReader requires a FileSystem it circumvents it in two places!
985         We should use the FileSystem only and remove codecs and os imports.
986
987         Reviewed by Zoltan Herczeg.
988
989         * Scripts/webkitpy/common/system/filesystem.py:
990         (FileSystem.open_stdin): Moved from TextFileReader
991         * Scripts/webkitpy/style/filereader.py:
992         (TextFileReader._read_lines): use FileSystem instead of calling codecs.open directly
993         (TextFileReader._process_directory): use FileSystem instead of calling os.walk directly
994
995 2013-12-04  László Langó  <lango@inf.u-szeged.hu>
996
997         check-webkit-style should check member initialization indentation.
998         https://bugs.webkit.org/show_bug.cgi?id=124820
999
1000         Reviewed by Zoltan Herczeg.
1001
1002         check-webkit-style should check member initialization indentation
1003         belongs to webkit coding style:
1004         http://www.webkit.org/coding/coding-style.html#punctuation-member-init
1005
1006         * Scripts/webkitpy/style/checkers/cpp.py:
1007         (check_member_initialization_list): Add new method to check member
1008         initialization list.
1009         (check_style): Add the call of the new method.
1010         (check_language): Move self initialization checking into the new method.
1011         (CppChecker): Add a new category for initialization list.
1012         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1013         (CppStyleTest.test_runtime_selfinit):
1014         (CppStyleTest.test_deprecated_cast):
1015         (WebKitStyleTest.test_member_initialization_list): Add new testcases for
1016         the new feature.
1017
1018 2013-12-04  Tamas Gergely  <gertom@inf.u-szeged.hu>
1019
1020         style-bot should reject Committer additions to committers.py
1021         https://bugs.webkit.org/show_bug.cgi?id=107574
1022
1023         Reviewed by Zoltan Herczeg.
1024
1025         The style check when executed in non-interactive mode (probably by a
1026         bot) will raise an additional error if the contributors.json file is
1027         modified. Non-interactive mode information is propagated to the
1028         Dispatcher, which creates a special JSON checker for the
1029         contributors.json file.
1030
1031         * Scripts/webkitpy/style/checker.py:
1032         (check_webkit_style_configuration):
1033         (CheckerDispatcher._create_checker):
1034         (CheckerDispatcher.dispatch):
1035         (StyleProcessorConfiguration.__init__):
1036         (StyleProcessor.process):
1037         * Scripts/webkitpy/style/checker_unittest.py:
1038         (CheckerDispatcherSkipTest._assert_should_skip_without_warning):
1039         (CheckerDispatcherDispatchTest.dispatch):
1040         (StyleProcessorConfigurationTest._style_checker_configuration):
1041         (StyleProcessor_EndToEndTest.test_init):
1042         (StyleProcessor_EndToEndTest.test_process):
1043         (StyleProcessor_CodeCoverageTest.MockDispatcher.dispatch):
1044         (StyleProcessor_CodeCoverageTest.setUp):
1045         * Scripts/webkitpy/style/checkers/jsonchecker.py:
1046         (JSONChecker.line_number_from_json_exception):
1047         (JSONContributorsChecker):
1048         (JSONContributorsChecker.check):
1049         * Scripts/webkitpy/style/error_handlers_unittest.py:
1050         (DefaultStyleErrorHandlerTest._style_checker_configuration):
1051         * Scripts/webkitpy/style/optparser.py:
1052         (CommandOptionValues.__init__):
1053         (ArgumentParser._create_option_parser):
1054         (ArgumentParser.parse):
1055         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1056         (test_post):
1057         (test_upload):
1058         * Scripts/webkitpy/tool/steps/checkstyle.py:
1059         (CheckStyle.run):
1060
1061 2013-12-04  Nick Diego Yamane  <nick.yamane@openbossa.org>
1062
1063         [EFL][WK2] Fix build after API::Client changes
1064         https://bugs.webkit.org/show_bug.cgi?id=125206
1065
1066         Reviewed by Csaba Osztrogonác.
1067
1068         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
1069         (TestWebKitAPI::TEST):
1070         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
1071         (TestWebKitAPI::setViewClient):
1072
1073 2013-12-03  Dan Bernstein  <mitz@apple.com>
1074
1075         Fixed a test timing out after r160040.
1076
1077         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
1078         (-[SimpleLoadFailDelegate browsingContextController:didFailProvisionalLoadWithError:]):
1079         Updated for the delegate method rename.
1080
1081 2013-12-03  Filip Pizlo  <fpizlo@apple.com>
1082
1083         REGRESSION: repro scripts disappear when you rerun tests
1084         https://bugs.webkit.org/show_bug.cgi?id=125184
1085
1086         Reviewed by Mark Hahnenberg.
1087         
1088         This bug made it difficult to quickly see if a test that recently failed is still
1089         failing while also running a new batch of tests.
1090
1091         Repro scripts are supposed to stay around until you delete them explicitly. This
1092         patch accomplishes that.
1093
1094         * Scripts/run-jsc-stress-tests:
1095
1096 2013-12-03  peavo@outlook.com  <peavo@outlook.com>
1097
1098         [Win] run-jsc-stress-tests has a great number of failures (2026/7606) on Windows
1099         https://bugs.webkit.org/show_bug.cgi?id=125111
1100
1101         Reviewed by Filip Pizlo.
1102
1103         Almost all errors seem to be caused by differences in line ending when diffing test output with expected output.
1104
1105         * Scripts/run-javascriptcore-tests: Enable api test and stress test for WinCairo.
1106         * Scripts/run-jsc-stress-tests: Ignore carriage return when diffing test output with expected output.
1107
1108 2013-12-03  Ryosuke Niwa  <rniwa@webkit.org>
1109
1110         Add a script to automatically configure a git clone
1111         https://bugs.webkit.org/show_bug.cgi?id=110073
1112
1113         Revert the change to use https for now since git.webkit.org is setup with http.
1114
1115         * Scripts/webkitpy/tool/commands/setupgitclone.py:
1116         (SetupGitClone.execute):
1117
1118 2013-12-03  Ryosuke Niwa  <rniwa@webkit.org>
1119
1120         Add a script to automatically configure a git clone
1121         https://bugs.webkit.org/show_bug.cgi?id=110073
1122
1123         Reviewed by Benjamin Poulain.
1124
1125         Added "webkit-patch setup-git-clone" to setup a brand new Git clone.
1126
1127         This command runs various commands listed on http://trac.webkit.org/wiki/UsingGitWithWebKit
1128
1129         * Scripts/webkitpy/tool/commands/__init__.py:
1130         * Scripts/webkitpy/tool/commands/setupgitclone.py: Added.
1131         (SetupGitClone):
1132         (SetupGitClone.execute):
1133
1134 2013-12-03  Anders Carlsson  <andersca@apple.com>
1135
1136         Deprecate WKNotificationProvider
1137         https://bugs.webkit.org/show_bug.cgi?id=125178
1138
1139         Reviewed by Sam Weinig.
1140
1141         Update for WebKit2 changes.
1142
1143         * WebKitTestRunner/TestController.cpp:
1144         (WTR::TestController::initialize):
1145         * WebKitTestRunner/WebNotificationProvider.cpp:
1146         (WTR::WebNotificationProvider::provider):
1147         * WebKitTestRunner/WebNotificationProvider.h:
1148
1149 2013-12-03  Brent Fulgham  <bfulgham@apple.com>
1150
1151         [Win] Support 64-bit Application Support Libraries Location 
1152         https://bugs.webkit.org/show_bug.cgi?id=125179
1153
1154         Reviewed by Tim Horton.
1155
1156         Enable the user to specify a location for 64-bit support libraries (such as libxml2, ICU, etc.)
1157         on Windows until an official distribution is available that properly creates registry settings
1158         to specify these locations.
1159
1160         * Scripts/webkitdirs.pm:
1161         (setupAppleWinEnv): Notify user to set WEBKIT_64_SUPPORT environment variable if needed.
1162         (setupCygwinEnv): Report WEWBKIT_64_SUPPORT path when running 64-bit builds.
1163         (appleApplicationSupportPath): Add WEBKIT_64_SUPPORT location to runtime environment when
1164         running 64-bit builds.
1165
1166 2013-12-03  Mark Hahnenberg  <mhahnenberg@apple.com>
1167
1168         run-jsc-stress-tests only supports host environments that have make installed
1169         https://bugs.webkit.org/show_bug.cgi?id=124550
1170
1171         Reviewed by Darin Adler.
1172
1173         This might not be the case for all hosts, so this patch implements an alternate "backend" 
1174         for run-jsc-stress-tests to use normal shell commands rather than Makefiles. To remain at 
1175         least somewhat competitive with the make-based test runner, the shell backend uses subshells
1176         run in the background to allow tests to run in parallel. Since the concurrency primitives 
1177         in shell scripting are rather coarse, the overhead of this parallelism is higher than that 
1178         of the make-based runner.
1179
1180         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Added. This is the runner that is copied into
1181         the bundle and controls all of the parallel aspects of the shell-based test runner.
1182         * Scripts/run-jsc-stress-tests:
1183
1184 2013-12-03  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
1185
1186         Remove function from TextChecker
1187         https://bugs.webkit.org/show_bug.cgi?id=125148
1188
1189         Reviewed by Darin Adler.
1190
1191         The process_file_data is used only from the unit tests, so it is simply moved there.
1192
1193         * Scripts/webkitpy/style/checkers/text.py:
1194         (TextChecker.check):
1195         * Scripts/webkitpy/style/checkers/text_unittest.py:
1196         (TextStyleTestCase.process_file_data):
1197         (TextStyleTestCase.assertNoError):
1198         (TextStyleTestCase.assertError):
1199
1200 2013-12-03  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
1201
1202         Remove get_test() and reference test names directly instead.
1203         https://bugs.webkit.org/show_bug.cgi?id=124962
1204
1205         Reviewed by Csaba Osztrogonác.
1206
1207         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1208         (Base.__init__):
1209         (Base.get_basic_tests):
1210         (assert_exp):
1211         (MiscTests.test_multiple_results):
1212         (MiscTests.test_category_expectations):
1213         (MiscTests.test_get_modifiers):
1214         (MiscTests.test_get_expectations_string):
1215         (MiscTests.test_get_test_set):
1216         (MiscTests.test_parse_warning):
1217         (MiscTests.test_pixel_tests_flag.match):
1218
1219 2013-12-03  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
1220
1221         Style Checker false pass.
1222         https://bugs.webkit.org/show_bug.cgi?id=112456
1223
1224         Reviewed by Csaba Osztrogonác.
1225
1226         * Scripts/webkitpy/style/checkers/changelog.py:
1227         (ChangeLogChecker.check_entry):
1228         simple regex fix to check "No new tests (...)."
1229         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
1230         (ChangeLogCheckerTest.test_no_new_tests):
1231
1232 2013-12-02  Filip Pizlo  <fpizlo@apple.com>
1233
1234         run-jsc-stress-tests should allow for tests that have a directory containing .js files nested within a directory containing the data
1235         https://bugs.webkit.org/show_bug.cgi?id=125130
1236
1237         Reviewed by Geoffrey Garen.
1238
1239         * Scripts/run-jsc-stress-tests:
1240
1241 2013-12-02  Samuel White  <samuel_white@apple.com>
1242
1243         AX: Add AXUIElementCountForSearchPredicate parameterized attribute.
1244         https://bugs.webkit.org/show_bug.cgi?id=124561
1245
1246         Reviewed by Chris Fleizach.
1247
1248         Added function to verify that NSAccessibilityUIElementCountForSearchPredicateParameterizedAttribute works as it should.
1249
1250         * DumpRenderTree/AccessibilityUIElement.cpp:
1251         (uiElementCountForSearchPredicateCallback):
1252         (uiElementForSearchPredicateCallback):
1253         (AccessibilityUIElement::getJSClass):
1254         * DumpRenderTree/AccessibilityUIElement.h:
1255         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1256         (AccessibilityUIElement::uiElementCountForSearchPredicate):
1257         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1258         (AccessibilityUIElement::uiElementCountForSearchPredicate):
1259         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1260         (searchPredicateParameterizedAttributeForSearchCriteria):
1261         (AccessibilityUIElement::uiElementCountForSearchPredicate):
1262         (AccessibilityUIElement::uiElementForSearchPredicate):
1263         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1264         (AccessibilityUIElement::uiElementCountForSearchPredicate):
1265         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1266         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
1267         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1268         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1269         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1270         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
1271         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1272         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
1273         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
1274         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1275
1276 2013-12-02  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
1277
1278         Instead of a large 'if' block, each failure class should write it's own result in test_result_writer.py
1279         https://bugs.webkit.org/show_bug.cgi?id=124714
1280
1281         Reviewed by Ryosuke Niwa.
1282
1283         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1284         (write_test_result):
1285         * Scripts/webkitpy/layout_tests/models/test_failures.py:
1286         (TestFailure.write_failure):
1287         (FailureText):
1288         (FailureText.write_failure):
1289         (FailureAudio):
1290         (FailureAudio.write_failure):
1291         (FailureCrash.write_failure):
1292         (FailureMissingResult):
1293         (FailureTextMismatch):
1294         (FailureMissingImageHash.write_failure):
1295         (FailureMissingImage.write_failure):
1296         (FailureImageHashMismatch.write_failure):
1297         (FailureReftestMismatch.write_failure):
1298         (FailureReftestMismatchDidNotOccur.write_failure):
1299         (FailureMissingAudio):
1300         (FailureAudioMismatch):
1301
1302 2013-12-02  László Langó  <lango@inf.u-szeged.hu>
1303
1304         Remove the stderr_write attribute from StyleProcessorConfiguration
1305         https://bugs.webkit.org/show_bug.cgi?id=124703
1306
1307         Reviewed by Ryosuke Niwa.
1308
1309         Remove the stderr_write attribute from this class in checker and
1310         replace its use with calls to a logging module logger. We Should 
1311         use logging module instead of writing to stderr directly.
1312
1313         * Scripts/webkitpy/style/checker.py: Change stderr_write attribute to logging module logger.
1314         (check_webkit_style_configuration):
1315         (CheckerDispatcher.dispatch): Remove FIXME comment.
1316         (StyleProcessorConfiguration):
1317         (StyleProcessorConfiguration.__init__):
1318         (StyleProcessorConfiguration.write_style_error):
1319         * Scripts/webkitpy/style/checker_unittest.py: Update test to the modification.
1320         There is an "ERROR" prefix in log messiges from now.
1321         (StyleProcessorConfigurationTest):
1322         (StyleProcessorConfigurationTest._style_checker_configuration):
1323         (StyleProcessorConfigurationTest.test_init):
1324         (StyleProcessorConfigurationTest.test_write_style_error_emacs):
1325         (StyleProcessorConfigurationTest.test_write_style_error_vs7):
1326         (StyleProcessor_EndToEndTest.with):
1327         (StyleProcessor_EndToEndTest.test_init):
1328         (StyleProcessor_EndToEndTest.test_process):
1329         (StyleProcessor_CodeCoverageTest.setUp):
1330         * Scripts/webkitpy/style/error_handlers.py: Remove stderr_write usage and replace with logging module logger.
1331         (DefaultStyleErrorHandler.__call__):
1332         * Scripts/webkitpy/style/error_handlers_unittest.py: Update test to the modification.
1333         There is an "ERROR" prefix in log messiges from now.
1334         (DefaultStyleErrorHandlerTest):
1335         (DefaultStyleErrorHandlerTest.setUp):
1336         (DefaultStyleErrorHandlerTest._mock_increment_error_count):
1337         (DefaultStyleErrorHandlerTest._style_checker_configuration):
1338         (DefaultStyleErrorHandlerTest._check_initialized):
1339         (DefaultStyleErrorHandlerTest.test_non_reportable_error):
1340         (DefaultStyleErrorHandlerTest.test_max_reports_per_category):
1341         (DefaultStyleErrorHandlerTest.test_line_numbers):
1342
1343 2013-12-02  Brian J. Burg  <burg@cs.washington.edu>
1344
1345         Add JavaScript style checker and teach checker.py about .js files
1346         https://bugs.webkit.org/show_bug.cgi?id=125049
1347
1348         Reviewed by Joseph Pecoraro.
1349
1350         Add a JavaScript file type, extension, and checker (JSChecker).
1351         Use TextChecker for JavaScript tests, libraries, website resources,
1352         etc. and use JSChecker for files within WebInspectorUI/UserInterface.
1353
1354         Amended tests for TextChecker to reflect the rule above.
1355
1356         * Scripts/webkitpy/style/checker.py:
1357         (_all_categories): Add categories defined by JSChecker.
1358         (FileType): Add file type for JS and re-number the enum.
1359         (CheckerDispatcher._file_type): Detect .js files as JavaScript.
1360         (CheckerDispatcher._create_checker):
1361         Create a JSChecker or TextChecker depending on the file's path.
1362
1363         * Scripts/webkitpy/style/checker_unittest.py:
1364         (CheckerDispatcherDispatchTest.assert_checker_js): Added.
1365         (CheckerDispatcherDispatchTest.test_js_paths): Added.
1366         (CheckerDispatcherDispatchTest.test_text_paths): Add new test paths
1367         that end in .js but should be checked with TextChecker.
1368         * Scripts/webkitpy/style/checkers/js.py: Added.
1369         (JSChecker):
1370         (JSChecker.__init__):
1371         (JSChecker.check):
1372         * Scripts/webkitpy/style/checkers/js_unittest.py: Added.
1373         (JSTestCase):
1374         (JSTestCase.assertNoError):
1375         (JSTestCase.assertNoError.error_for_test):
1376         (JSTestCase.assertError):
1377         (JSTestCase.assertError.error_for_test):
1378         (JSTestCase.test_no_error):
1379         (JSTestCase.test_error):
1380
1381 2013-12-02  Mark Hahnenberg  <mhahnenberg@apple.com>
1382
1383         run-jsc-stress-tests always copies the VM
1384         https://bugs.webkit.org/show_bug.cgi?id=125092
1385
1386         Reviewed by Filip Pizlo.
1387
1388         This can be slow, especially with full debug builds. It should just symlink the VM into the 
1389         bundle by default and do a full copy only when asked.
1390
1391         * Scripts/run-jsc-stress-tests:
1392
1393 2013-12-02  Brent Fulgham  <bfulgham@apple.com>
1394
1395         [Win] Port run-jsc-stress-tests
1396         https://bugs.webkit.org/show_bug.cgi?id=124801
1397
1398         Reviewed by Filip Pizlo.
1399
1400         * Scripts/run-jsc-stress-tests: Gracefully handle lack of sysctl
1401         command on Windows so that stress tests can run.
1402
1403 2013-12-02  Mark Hahnenberg  <mhahnenberg@apple.com>
1404
1405         Build fix after r159955
1406
1407         * Scripts/run-jsc-stress-tests:
1408
1409 2013-12-02  Mark Hahnenberg  <mhahnenberg@apple.com>
1410
1411         run-jsc-stress-tests should be able to package its tests and move them places
1412         https://bugs.webkit.org/show_bug.cgi?id=124549
1413
1414         Reviewed by Filip Pizlo.
1415
1416         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. Was just a ruby reimplementation
1417         of grep -i -q
1418         * Scripts/run-javascriptcore-tests: Pass through the --tarball flag.
1419         * Scripts/run-jsc-stress-tests: Changed to create a bundle of tests inside the results directory.
1420         We now also copy whatever VM was specified, along with its associated framework, into this directory.
1421         All of the generated scripts now are completely relative within the results directory. This allows
1422         run-jsc-stress-tests to execute a bundle from anywhere. Also added a --tarball flag which creates a
1423         tarball of the generated results directory. Also refactored several portions of the script into
1424         separate functions to make it easier to run them conditionally depending on which mode we're running in. 
1425
1426 2013-12-02  Andrzej Badowski  <a.badowski@samsung.com>
1427
1428         [ATK] Support active state for listbox elements.
1429         https://bugs.webkit.org/show_bug.cgi?id=125009
1430
1431         Reviewed by Chris Fleizach.
1432
1433         Supplement WebKitTestRunner and DumpRenderTree to support isSelectedOptionActive.
1434
1435         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1436         (AccessibilityUIElement::isSelectedOptionActive):
1437         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1438         (WTR::AccessibilityUIElement::isSelectedOptionActive):
1439         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1440         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1441         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1442         (WTR::AccessibilityUIElement::isSelectedOptionActive):
1443         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1444         (WTR::AccessibilityUIElement::isSelectedOptionActive):
1445
1446 2013-12-02  Zan Dobersek  <zdobersek@igalia.com>
1447
1448         Unreviewed GTK gardening.
1449
1450         * Scripts/run-gtk-tests:
1451         (TestRunner): Skip two unit tests that are causing the subsequent test to crash.
1452
1453 2013-12-01  Dan Bernstein  <mitz@apple.com>
1454
1455         [Mac] Transition MiniBrowser to the Cocoa API: policy delegate   
1456         https://bugs.webkit.org/show_bug.cgi?id=125046
1457
1458         Reviewed by Sam Weinig.
1459
1460         * MiniBrowser/mac/AppDelegate.m:
1461         (-[BrowserAppDelegate newWindow:]): Added WK_API_ENABLED guards.
1462         (-[BrowserAppDelegate openDocument:]): Ditto.
1463         * MiniBrowser/mac/WK2BrowserWindowController.h: Ditto. Also moved ivar declarations from the
1464         interface to the implementation.
1465         * MiniBrowser/mac/WK2BrowserWindowController.m:
1466         (-[WK2BrowserWindowController awakeFromNib]): Changed to set the policy delegate instead of
1467         the policy client.
1468         (-[WK2BrowserWindowController browsingContextController:decidePolicyForNavigationAction:decisionHandler:]):
1469         Moved policy client implementation into this delegate method.
1470         (-[WK2BrowserWindowController browsingContextController:decidePolicyForNewWindowAction:decisionHandler:]):
1471         Ditto.
1472         (-[WK2BrowserWindowController browsingContextController:decidePolicyForResponseAction:decisionHandler:]):
1473         Ditto.
1474
1475 2013-12-01  Dan Bernstein  <mitz@apple.com>
1476
1477         [Mac] Remove the MiniBrowser injected bundle
1478         https://bugs.webkit.org/show_bug.cgi?id=125041
1479
1480         Reviewed by Anders Carlsson.
1481
1482         It had no ops!
1483
1484         * MiniBrowser/Configurations/WebBundle.xcconfig: Removed.
1485         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1486         * MiniBrowser/mac/AppDelegate.m:
1487         (-[BrowserAppDelegate init]):
1488         * MiniBrowser/mac/WebBundle/Info.plist: Removed.
1489         * MiniBrowser/mac/WebBundle/WebBundleMain.m: Removed.
1490
1491 2013-11-29  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
1492
1493         check-webkit-style should check for extraneous newline between config.h and primary header.
1494         https://bugs.webkit.org/show_bug.cgi?id=124821
1495
1496         Reviewed by Csaba Osztrogonác.
1497
1498         * Scripts/webkitpy/style/checkers/cpp.py:
1499         (check_include_line):
1500         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1501         (OrderOfIncludesTest.test_check_line_break_after_own_header):
1502         (OrderOfIncludesTest):
1503         (OrderOfIncludesTest.test_check_line_break_before_own_header):
1504
1505 2013-11-29  Jozsef Berta  <jberta@inf.u-szeged.hu>
1506
1507         test-webkit-scripts should show the failing tests and use an appropriate exit code
1508         https://bugs.webkit.org/show_bug.cgi?id=124840
1509
1510         Reviewed by Ryosuke Niwa.
1511
1512         A fixme in test-webkit-scripts asked that the script should display success or failiure
1513         and exit with a 0 or 1 value accordingly after all of the tests have completed.
1514
1515         * Scripts/test-webkit-scripts:
1516         (ScriptsTester.run_test_script):
1517         The outcome of the currently run script is returned to the main as a boolean value. A boolean is returned,
1518         because at this point we don't need to pass on more information other than success or failiure.
1519         (ScriptsTester.main):
1520         The return values are now stored for each script and when all tests have completed successfully,
1521         the script indicates success and returns 0. Otherwise it will display the name(s) of the failing script(s) and return 1.
1522
1523 2013-11-29  Krzysztof Czech  <k.czech@samsung.com>
1524
1525         [ATK] Added support for isAttributeSettable in AccessibilityUIElementAtk
1526         https://bugs.webkit.org/show_bug.cgi?id=124923
1527
1528         Reviewed by Mario Sanchez Prada.
1529
1530         Added missing implementation of isAttributeSettable. Using
1531         ATK_STATE_EDITABLE for checking whether attribute is settable.
1532
1533         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1534         (AccessibilityUIElement::isAttributeSettable):
1535         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1536         (WTR::AccessibilityUIElement::isAttributeSettable):
1537
1538 2013-11-28  Commit Queue  <commit-queue@webkit.org>
1539
1540         Unreviewed, rolling out r159839.
1541         http://trac.webkit.org/changeset/159839
1542         https://bugs.webkit.org/show_bug.cgi?id=124974
1543
1544         run-webkit-tests doesn't generate pretty diff (Requested by
1545         Ossy on #webkit).
1546
1547         * Scripts/webkitpy/common/prettypatch.py:
1548         (PrettyPatch.__init__):
1549         (PrettyPatch.pretty_diff):
1550         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1551         (TestResultWriter.create_text_diff_and_write_result):
1552         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1553         (summarize_results):
1554         * Scripts/webkitpy/port/base.py:
1555         (Port.__init__):
1556         (Port.pretty_patch_available):
1557         (Port.check_pretty_patch):
1558         (Port.variable):
1559         (Port.variable.pretty_patch_text):
1560         * Scripts/webkitpy/port/base_unittest.py:
1561         (PortTest.test_pretty_patch_os_error):
1562         (PortTest.test_pretty_patch_script_error):
1563
1564 2013-11-28  Antti Koivisto  <antti@apple.com>
1565
1566         Remove feature: CSS variables
1567         https://bugs.webkit.org/show_bug.cgi?id=114119
1568
1569         Reviewed by Andreas Kling.
1570
1571         * Scripts/webkitperl/FeatureList.pm:
1572
1573 2013-11-28  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
1574
1575         Move PrettyPatch related code to prettypatch.py
1576         https://bugs.webkit.org/show_bug.cgi?id=124937
1577
1578         Reviewed by Ryosuke Niwa.
1579
1580         This code seems to have a better place here than in Port, since PrettyPatch already knows
1581         pretty_patch_path, and this also unifies the usage of PrettyPatch
1582
1583         * Scripts/webkitpy/common/prettypatch.py:
1584         (PrettyPatch.__init__):
1585         (PrettyPatch.pretty_diff):
1586         (PrettyPatch):
1587         (PrettyPatch.pretty_patch_available):
1588         (PrettyPatch.check_pretty_patch):
1589         (PrettyPatch.pretty_patch_text):
1590         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1591         (TestResultWriter.create_text_diff_and_write_result):
1592         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1593         (summarize_results):
1594         * Scripts/webkitpy/port/base.py:
1595         (Port.__init__):
1596         (Port.wdiff_available):
1597         (Port.check_image_diff):
1598         (Port.wdiff_text):
1599         * Scripts/webkitpy/port/base_unittest.py:
1600         (PortTest.test_pretty_patch_os_error):
1601         (PortTest.test_pretty_patch_script_error):
1602
1603 2013-11-28  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
1604
1605         Checkout should own the scm object in Host
1606         https://bugs.webkit.org/show_bug.cgi?id=124943
1607
1608         Reviewed by Ryosuke Niwa.
1609
1610         * Scripts/webkitpy/common/host.py:
1611         (Host.__init__):
1612         (Host.initialize_scm):
1613         (Host.scm):
1614
1615 2013-11-26  Filip Pizlo  <fpizlo@apple.com>
1616
1617         Do bytecode validation as part of testing
1618         https://bugs.webkit.org/show_bug.cgi?id=124913
1619
1620         Reviewed by Oliver Hunt.
1621
1622         * Scripts/run-jsc-stress-tests:
1623
1624 2013-11-27  Andres Gomez  <agomez@igalia.com>
1625
1626         [GTK] Tools/Scripts/update-webkitgtk-libs fails due to missing fontutils dependencies for building the "xserver" module
1627         https://bugs.webkit.org/show_bug.cgi?id=124940
1628
1629         Reviewed by Martin Robinson.
1630
1631         xserver-font-utils is needed for building gtk port dependencies
1632         with jhbuild.
1633
1634         * gtk/install-dependencies: Added xserver-font-utils to jhbuild
1635         dependecies.
1636
1637 2013-11-27  Andres Gomez  <agomez@igalia.com>
1638
1639         [GTK] Tools/Scripts/update-webkitgtk-libs unsorted and fails because of missing "git"
1640         https://bugs.webkit.org/show_bug.cgi?id=124938
1641
1642         Reviewed by Philippe Normand.
1643
1644         Added needed git dependency for building the gtk port with
1645         jhbuild. Also, the dependencies needed for building the gtk port
1646         are now sorted alphabetically.
1647
1648         * gtk/install-dependencies: Added git as jhbuild dependency and
1649         sorted dependencies alphabetically.
1650
1651 2013-11-27  Jozsef Berta  <jberta@inf.u-szeged.hu>
1652
1653         run_webkit_tests.py: error: no such option: --wincairo
1654         https://bugs.webkit.org/show_bug.cgi?id=124927
1655
1656         Reviewed by Ryosuke Niwa.
1657
1658         * BuildSlaveSupport/build.webkit.org-config/config.json: The run_webkit_tests.py doesn't supports
1659         the layout testing on wincairo, so it is turned off.
1660
1661 2013-11-26  Marcelo Lira  <marcelo.lira@openbossa.org>
1662
1663         Nix upstreaming - Adding build files and supporting scripts
1664         https://bugs.webkit.org/show_bug.cgi?id=118367
1665
1666         Reviewed by Ryosuke Niwa.
1667
1668         * Scripts/build-webkit:
1669         * Scripts/run-nix-tests: Added.
1670         * Scripts/run-webkit-tests:
1671         * Scripts/update-webkit-libs-jhbuild:
1672         * Scripts/update-webkitnix-libs: Added.
1673         * Scripts/webkitdirs.pm:
1674         (determineArchitecture):
1675         (argumentsForConfiguration):
1676         (jscProductDir):
1677         (builtDylibPathForName):
1678         (determineIsNix):
1679         (isNix):
1680         (isAppleWebKit):
1681         (launcherPath):
1682         (launcherName):
1683         (checkRequiredSystemConfig):
1684         (copyInspectorFrontendFiles):
1685         (jhbuildWrapperPrefixIfNeeded):
1686         (buildCMakeProjectOrExit):
1687         (cmakeBasedPortName):
1688         * Scripts/webkitpy/common/config/ports.py:
1689         (DeprecatedPort.port):
1690         (EflWK2Port.build_webkit_command):
1691         (NixPort):
1692         (NixPort.build_webkit_command):
1693         * Scripts/webkitpy/port/factory.py:
1694         (platform_options):
1695         (PortFactory):
1696         * Scripts/webkitpy/port/nix.py: Added.
1697         (NixPort):
1698         (NixPort._wk2_port_name):
1699         (NixPort.determine_full_port_name):
1700         (NixPort.__init__):
1701         (NixPort._port_flag_for_scripts):
1702         (NixPort.setup_test_run):
1703         (NixPort.setup_environ_for_server):
1704         (NixPort.default_timeout_ms):
1705         (NixPort.clean_up_test_run):
1706         (NixPort._generate_all_test_configurations):
1707         (NixPort._path_to_driver):
1708         (NixPort._path_to_image_diff):
1709         (NixPort._image_diff_command):
1710         (NixPort._search_paths):
1711         (NixPort.show_results_html_file):
1712         (NixPort._port_specific_expectations_files):
1713         (NixPort.default_baseline_search_path):
1714         * Scripts/webkitpy/port/nix_unittest.py: Added.
1715         (NixPortTest):
1716         (NixPortTest._assert_search_path):
1717         (NixPortTest._assert_expectations_files):
1718         (NixPortTest.test_baseline_search_path):
1719         (NixPortTest.test_expectations_files):
1720         (NixPortTest.test_default_timeout_ms):
1721         * jhbuild/jhbuild-wrapper:
1722         (determine_platform):
1723         * nix/common.py: Added.
1724         (script_path):
1725         (top_level_path):
1726         * nix/jhbuild.modules: Added.
1727         * nix/jhbuildrc: Added.
1728
1729 2013-11-26  Ryosuke Niwa  <rniwa@webkit.org>
1730
1731         Record subtest values in Dromaeo tests
1732         https://bugs.webkit.org/show_bug.cgi?id=124498
1733
1734         Reviewed by Andreas Kling.
1735
1736         Supported parsing subtest results.
1737
1738         * Scripts/webkitpy/performance_tests/perftest.py: Replaced _metrics with an ordered list of subtests, each of
1739         which contains a dictionary with its name and an ordered list of subtest's metrics.
1740         (PerfTest.__init__): Initialize _metrics as a list.
1741         (PerfTest.run): Go through each subtest and its metrics to create a list of TestMetrics.
1742         (PerfTest._run_with_driver):
1743         (PerfTest._ensure_metrics): Look for a subtest then a metric in _metrics.
1744
1745         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1746         (TestPerfTest._assert_results_are_correct): Updated the assertions per changes to _metrics.
1747         (TestPerfTest.test_parse_output): Ditto.
1748         (TestPerfTest.test_parse_output_with_subtests): Added the metric and the unit on each subtest result as well as
1749         assertions to ensure subtest results are parsed properly.
1750         (TestReplayPerfTest.test_run_with_driver_accumulates_results): Updated the assertions per changes to _metrics.
1751         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results): Dittp.
1752
1753         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1754         (_generate_results_dict): When the metric for a subtest is processed before that of the main test, the url is
1755         incorrectly suffixed with '/'. Fix this later by re-computing the url with TestPerfMetric.test_file_name when
1756         adding new results.
1757
1758         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1759         (TestWithSubtestsData): Added.
1760         (TestDriver.run_test):
1761         (MainTest.test_run_test_with_subtests): Added.
1762
1763 2013-11-26  Ryosuke Niwa  <rniwa@webkit.org>
1764
1765         Enable HTML template element on Windows ports
1766         https://bugs.webkit.org/show_bug.cgi?id=124758
1767
1768         Reviewed by Andreas Kling.
1769
1770         * Scripts/webkitperl/FeatureList.pm:
1771
1772 2013-11-26  Ryosuke Niwa  <rniwa@webkit.org>
1773
1774         Remove replay performance tests as it's not actively maintained
1775         https://bugs.webkit.org/show_bug.cgi?id=124764
1776
1777         Reviewed by Andreas Kling.
1778
1779         Removed the feature.
1780
1781         * Scripts/webkitpy/performance_tests/perftest.py:
1782         (SingleProcessPerfTest.__init__):
1783         (PerfTestFactory):
1784         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1785         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1786         (PerfTestsRunner._parse_args):
1787         (PerfTestsRunner._collect_tests):
1788         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1789         (MainTest.test_collect_tests_with_ignored_skipped_list):
1790         (MainTest.test_default_args):
1791         * Scripts/webkitpy/thirdparty/__init__.py:
1792         (AutoinstallImportHook.find_module):
1793         (AutoinstallImportHook._install_unittest2):
1794         * Scripts/webkitpy/thirdparty/__init___unittest.py:
1795         (ThirdpartyTest.test_imports):
1796
1797 2013-11-26  Filip Pizlo  <fpizlo@apple.com>
1798
1799         Enable aggressive DFG validation in testing
1800         https://bugs.webkit.org/show_bug.cgi?id=124911
1801
1802         Rubber stamped by Ryosuke Niwa.
1803         
1804         This enables validation testing in non-concurrent-JIT runs.
1805
1806         * Scripts/run-jsc-stress-tests:
1807
1808 2013-11-26  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
1809
1810         Moved methods which belong to Checkout into checkout.py
1811         https://bugs.webkit.org/show_bug.cgi?id=124889
1812
1813         Reviewed by Ryosuke Niwa.
1814
1815         * Scripts/webkitpy/common/checkout/checkout.py:
1816         (Checkout.scripts_directory):
1817         (Checkout):
1818         (Checkout.script_path):
1819         (Checkout.commit_message_for_this_commit):
1820         (Checkout.apply_patch):
1821         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1822         (test_commit_message_for_this_commit):
1823         (CheckoutTest.test_apply_patch):
1824         * Scripts/webkitpy/common/checkout/scm/scm.py:
1825         (SCM.absolute_path):
1826         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1827         (SCMTest._setup_webkittools_scripts_symlink):
1828         * Scripts/webkitpy/common/checkout/scm/svn.py:
1829         (SVN.create_patch):
1830
1831 2013-11-25  Ryuan Choi  <ryuan.choi@samsung.com>
1832
1833         [EFL] Use Config mode of find_package for EFL 1.8
1834         https://bugs.webkit.org/show_bug.cgi?id=124555
1835
1836         Reviewed by Gyuyoung Kim.
1837
1838         * MiniBrowser/efl/CMakeLists.txt:
1839         Added optional config mode and made version requirement optional.
1840
1841 2013-11-25  Andres Gomez  <agomez@igalia.com>
1842
1843         [GTK] Search functionality in MiniBrowser provides feedback on search fail
1844         https://bugs.webkit.org/show_bug.cgi?id=122681
1845
1846         Reviewed by Mario Sanchez Prada.
1847
1848         When using the search functionality in MiniBrowser, if the search
1849         fails, the entry background color gets red to report the user
1850         about the failing condition. When the entry is cleaned or the
1851         search is again succesful the background turns back to its
1852         original color.
1853
1854         * MiniBrowser/gtk/BrowserSearchBar.c:
1855         (setFailedStyleForEntry): Added.
1856         (doSearch): Sets the entry's background to its original style if
1857         there is no text to search.
1858         (findControllerFailedToFindTextCallback): Added.
1859         (findControllerFoundTextCallback): Added.
1860         (browser_search_bar_init): Creates and adds a new CSS provider to
1861         the text entry so we can change its style based on the success
1862         condition of the search.
1863         (browserSearchBarFinalize): Frees the new CSS provider.
1864         (browser_search_bar_new): Connects the two new handlers to the
1865         "failed-to-find-text" and "found-text" signals emitted by the
1866         WebKitFindController.
1867
1868 2013-11-25  Dan Bernstein  <mitz@apple.com>
1869
1870         [Cocoa] Put most of the Cocoa API behind WK_API_ENABLED guards
1871         https://bugs.webkit.org/show_bug.cgi?id=124850
1872
1873         Reviewed by Brady Eidson.
1874
1875         Added #if WK_API_ENABLED guards around tests that use the Objective-C API.
1876
1877         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1878         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
1879         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1880         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
1881         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
1882         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
1883         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
1884
1885 2013-11-25  Commit Queue  <commit-queue@webkit.org>
1886
1887         Unreviewed, rolling out r159752 and r159754.
1888         http://trac.webkit.org/changeset/159752
1889         http://trac.webkit.org/changeset/159754
1890         https://bugs.webkit.org/show_bug.cgi?id=124847
1891
1892         Broke linux test bots. (Requested by mhahnenberg on #webkit).
1893
1894         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
1895         * Scripts/run-javascriptcore-tests:
1896         * Scripts/run-jsc-stress-tests:
1897
1898 2013-11-25  Mark Hahnenberg  <mhahnenberg@apple.com>
1899
1900         Followup fix after r159752
1901
1902         * Scripts/run-jsc-stress-tests: We need to handle Release builds too.
1903
1904 2013-11-25  Mark Hahnenberg  <mhahnenberg@apple.com>
1905
1906         run-jsc-stress-tests should be able to package its tests and move them places
1907         https://bugs.webkit.org/show_bug.cgi?id=124549
1908
1909         Reviewed by Filip Pizlo.
1910
1911         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. Was just a ruby reimplementation 
1912         of grep -i -q
1913         * Scripts/run-javascriptcore-tests: Pass through the --tarball flag.
1914         * Scripts/run-jsc-stress-tests: Changed to create a bundle of tests inside the results directory. 
1915         We now also copy whatever VM was specified, along with its associated framework, into this directory. 
1916         All of the generated scripts now are completely relative within the results directory. This allows 
1917         run-jsc-stress-tests to execute a bundle from anywhere. Also added a --tarball flag which creates a 
1918         tarball of the generated results directory. Also refactored several portions of the script into 
1919         separate functions to make it easier to run them conditionally depending on which mode we're running in.
1920
1921 2013-11-25  László Langó  <lango@inf.u-szeged.hu>
1922
1923         EWS creates 0 byte sized log files
1924         https://bugs.webkit.org/show_bug.cgi?id=107606
1925
1926         Reviewed by Ryosuke Niwa.
1927
1928         There was a modification in r138264, that tried to make less log,
1929         because some of the messeges were duplicated. After this the EWS
1930         created the log file (with the same name as the bugID) but doesn't
1931         write anything into it, even if there were errors during the build.
1932         From now only creates the log file only if there is some error.
1933
1934         * Scripts/webkitpy/tool/bot/queueengine.py:
1935         (QueueEngine.run): If the build and tests pass, there is no ScriptError raised,
1936         there is nothing to log. Open the log file only if a ScriptError was raised to
1937         avoid to make empty log files for bugs.
1938         (QueueEngine._open_work_log): Does not need to tee STDOUT to log file anymore,
1939         because of changes in r138264. Teeing is used for locally testing purposes and
1940         this feature is not used anymore.
1941         (QueueEngine._ensure_work_log_closed): Close the logfile. We don't use output
1942         teeing anymore. It is a necessary change because of QueueEngine._open_work_log
1943         change.
1944         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1945         (LoggingDelegate): The order of the callbacks was changed by this patch.
1946         (QueueEngineTest.test_trivial): Won't create log file if the queue was terminated,
1947         so we have to update this test.
1948         (QueueEngineTest.test_unexpected_error): The order of the callbacks was changed by
1949         this patch.
1950         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1951         (AbstractEarlyWarningSystem.review_patch): Raise again the captured ScriptError
1952         to be able to handle it in QueueEngine.run. Without this change, the existing
1953         exception handler never run (the process_work_item method never raise ScriptError)
1954         We can get the error message only from the ScriptError at this point.
1955
1956 2013-11-22  Dean Jackson  <dino@apple.com>
1957
1958         Speculative Mountain Lion build fix.
1959
1960         * MiniBrowser/mac/AppDelegate.m:
1961         (-[BrowserAppDelegate openDocument:]):
1962
1963 2013-11-22  Anders Carlsson  <andersca@apple.com>
1964
1965         Fix Mountain Lion bug.
1966
1967         * MiniBrowser/mac/AppDelegate.m:
1968         (-[BrowserAppDelegate openDocument:]):
1969
1970 2013-11-22  Anders Carlsson  <andersca@apple.com>
1971
1972         MiniBrowser should use the blocks-based NSOpenPanel API
1973         https://bugs.webkit.org/show_bug.cgi?id=124786
1974
1975         Reviewed by Simon Fraser.
1976
1977         * MiniBrowser/mac/AppDelegate.m:
1978         (-[BrowserAppDelegate frontmostBrowserWindowController]):
1979         Account for windows that don't have a BrowserWindowController.
1980
1981         (-[BrowserAppDelegate openDocument:]):
1982
1983 2013-11-22  Commit Queue  <commit-queue@webkit.org>
1984
1985         Unreviewed, rolling out r159690.
1986         http://trac.webkit.org/changeset/159690
1987         https://bugs.webkit.org/show_bug.cgi?id=124782
1988
1989         Broke webkitpy tests (Requested by ap on #webkit).
1990
1991         * Scripts/webkitpy/tool/bot/queueengine.py:
1992         (QueueEngine.run):
1993         (QueueEngine._open_work_log):
1994         (QueueEngine._ensure_work_log_closed):
1995         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1996         (AbstractEarlyWarningSystem.review_patch):
1997
1998 2013-11-22  László Langó  <lango@inf.u-szeged.hu>
1999
2000         EWS creates 0 byte sized log files
2001         https://bugs.webkit.org/show_bug.cgi?id=107606
2002
2003         Reviewed by Ryosuke Niwa.
2004
2005         There was a modification in r138264, that tried to make less log, 
2006         because some of the messeges were duplicated. After this the EWS 
2007         created the log file (with the same name as the bugID) but doesn't 
2008         write anything into it, even if there were errors during the build. 
2009         From now only creates the log file only if there is some error.
2010
2011         * Scripts/webkitpy/tool/bot/queueengine.py:
2012         (QueueEngine.run): If the build and tests pass, there is no ScriptError raised,
2013         there is nothing to log. Open the log file only if a ScriptError was raised to
2014         avoid to make empty log files for bugs.
2015         (QueueEngine._open_work_log): Does not need to tee STDOUT to log file anymore,
2016         because of changes in r138264. Teeing is used for locally testing purposes and
2017         this feature is not used anymore.
2018         (QueueEngine._ensure_work_log_closed): Close the logfile. We don't use output 
2019         teeing anymore. It is a necessary change because of QueueEngine._open_work_log
2020         change.
2021         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2022         (AbstractEarlyWarningSystem.review_patch): Raise again the captured ScriptError
2023         to be able to handle it in QueueEngine.run. Without this change, the existing
2024         exception handler never run (the process_work_item method never raise ScriptError)
2025         We can get the error message only from the ScriptError at this point.
2026
2027 2013-11-21  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2028
2029         Remove ENABLE_WORKERS
2030         https://bugs.webkit.org/show_bug.cgi?id=105784
2031
2032         Reviewed by Darin Adler.
2033
2034         * Scripts/webkitperl/FeatureList.pm:
2035
2036 2013-11-21  Darin Adler  <darin@apple.com>
2037
2038         Try to fix buildbot Dashboard for people who have not hidden anything.
2039
2040         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2041         Add a null check for hidden platforms.
2042
2043 2013-11-21  Peter Szanka  <h868064@stud.u-szeged.hu>
2044
2045         Remove chrome/chromium related things from webkitpy.
2046         https://bugs.webkit.org/show_bug.cgi?id=124493
2047
2048         Reviewed by Darin Adler.
2049
2050         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2051         (PortTest.assert_mock_port_works):
2052         * Scripts/webkitpy/port/base.py:
2053         (Port.to.setup_environ_for_server):
2054         * Scripts/webkitpy/port/mac_unittest.py:
2055         (test_tests_for_other_platforms):
2056         * Scripts/webkitpy/port/mock_drt.py:
2057         (MockTestShell.output_for_test):
2058         * Scripts/webkitpy/tool/bot/irc_command.py:
2059         (Restart.execute):
2060         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
2061         (IRCBotTest.test_help):
2062
2063 2013-11-21  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
2064
2065         In filereader.py, process_file() should throw instead of exiting directly when the file doesn't exist
2066         https://bugs.webkit.org/show_bug.cgi?id=124717
2067
2068         Reviewed by Ryosuke Niwa.
2069
2070         * Scripts/webkitpy/style/filereader.py:
2071         (TextFileReader.process_file):
2072         * Scripts/webkitpy/style/filereader_unittest.py:
2073         (TextFileReaderTest.test_process_file__does_not_exist):
2074
2075 2013-11-21  Mark Rowe  <mrowe@apple.com>
2076
2077         <https://webkit.org/b/124702> Stop overriding VALID_ARCHS.
2078
2079         All modern versions of Xcode set it appropriately for our needs.
2080
2081         Reviewed by Alexey Proskuryakov.
2082
2083         * MiniBrowser/Configurations/Base.xcconfig:
2084         * WebKitTestRunner/Configurations/Base.xcconfig:
2085
2086 2013-11-21  Nick Diego Yamane  <nick.yamane@openbossa.org>
2087
2088         webkitdirs::checkForArgumentAndRemoveFromArrayRef() removed wrong element
2089         https://bugs.webkit.org/show_bug.cgi?id=124676
2090
2091         Reviewed by Daniel Bates.
2092
2093         checkForArgumentAndRemoveFromArrayRef functions was removing wrong
2094         elements when there were more then one occurrence of that argument.
2095         E.g: Checking for 'a' in {a, b, a, c}, the resulting array would be
2096         {b, a}, when it should be {b, c}.
2097
2098         * Scripts/webkitdirs.pm:
2099         (checkForArgumentAndRemoveFromArrayRef): bugfix mentioned above.
2100         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
2101         Added; Unit tests for webkitdirs::checkForArgumentAndRemoveFromArrayRef function.
2102
2103 2013-11-21  Ryosuke Niwa  <rniwa@webkit.org>
2104
2105         Update build-webkit after r159550.
2106
2107         * Scripts/webkitperl/FeatureList.pm:
2108
2109 2013-11-21  Lucas Forschler  <lforschler@apple.com>
2110
2111         Bring a new bot online, replacing the previous ones.
2112         
2113         Unreviewed.
2114
2115         * BuildSlaveSupport/build.webkit.org-config/config.json:
2116
2117 2013-11-21  Dean Jackson  <dino@apple.com>
2118
2119         Don't fetch hidden platforms on build.webkit.org/dashboard
2120         https://bugs.webkit.org/show_bug.cgi?id=124750
2121
2122         Reviewed by Tim Horton.
2123
2124         If a platform is hidden, don't fetch its data. If it
2125         becomes unhidden, try to fetch immediately (unless
2126         you've recently fetched).
2127
2128         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2129         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2130
2131 2013-11-21  Commit Queue  <commit-queue@webkit.org>
2132
2133         Unreviewed, rolling out r159633.
2134         http://trac.webkit.org/changeset/159633
2135         https://bugs.webkit.org/show_bug.cgi?id=124726
2136
2137         it broke 10 webkitpy tests (Requested by dino_ on #webkit).
2138
2139         * Scripts/webkitpy/style/checker.py:
2140         (check_webkit_style_configuration):
2141         (CheckerDispatcher.dispatch):
2142         (StyleProcessorConfiguration):
2143         (StyleProcessorConfiguration.__init__):
2144         (StyleProcessorConfiguration.write_style_error):
2145
2146 2013-11-21  László Langó  <lango@inf.u-szeged.hu>
2147
2148         Remove the stderr_write attribute from StyleProcessorConfiguration.
2149         https://bugs.webkit.org/show_bug.cgi?id=124703
2150
2151         Reviewed by Brent Fulgham.
2152
2153         * Scripts/webkitpy/style/checker.py:
2154         (check_webkit_style_configuration):
2155         (CheckerDispatcher.dispatch):
2156         (StyleProcessorConfiguration):
2157         (StyleProcessorConfiguration.__init__):
2158         (StyleProcessorConfiguration.write_style_error):
2159
2160 2013-11-21  Ryosuke Niwa  <rniwa@webkit.org>
2161
2162         PerfTestRunner._generate_results_dict shouldn't depend on test objects
2163         https://bugs.webkit.org/show_bug.cgi?id=124623
2164
2165         Removed the dependency on test objects from results JSON generation.
2166         This allows single test.run to return metrics for multiple tests
2167
2168         Reviewed by Antti Koivisto.
2169
2170         * Scripts/webkitpy/performance_tests/perftest.py:
2171         (PerfTestMetric.__init__): Takes the test path and test name.
2172         (PerfTestMetric.path): Added.
2173         (PerfTestMetric.test_file_name): Added.
2174         (PerfTest.run): Accumulate PerfTestMetric objects instead of raw values.
2175         (PerfTest._ensure_metrics): Instantiate PerfTestMetric with the test path and test name.
2176         The path is going to have the names of subtests at the end once we support them.
2177
2178         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2179         (TestPerfTestMetric.test_init_set_missing_unit): Specify the test path and test name.
2180         (TestPerfTestMetric.test_init_set_time_metric): Ditto.
2181         (TestPerfTestMetric.test_has_values): Ditto.
2182         (TestPerfTestMetric.test_append): Ditto.
2183
2184         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2185         (_generate_results_dict): Only use metrics.
2186         (_run_tests_set): Accumulate metrics as supposed to (test, metrics) pairs.
2187
2188 2013-11-21  Manuel Rego Casasnovas  <rego@igalia.com>
2189
2190         REGRESSION(r159599): webkitdirs.pm spits out warnings at lines 851 and 852
2191         https://bugs.webkit.org/show_bug.cgi?id=124697
2192
2193         Reviewed by Ryosuke Niwa.
2194
2195         * Scripts/webkitdirs.pm:
2196         (checkForArgumentAndRemoveFromARGVGettingValue): Fix check of array size
2197         before trying to access to the first element.
2198
2199 2013-11-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2200
2201         [GTK] Mark all deprecated symbols in GObject DOM bindings
2202         https://bugs.webkit.org/show_bug.cgi?id=124406
2203
2204         Reviewed by Gustavo Noronha Silva.
2205
2206         * Scripts/webkitpy/style/checker.py: Add special case for
2207         WebKitDOMDeprecated.
2208         * gtk/generate-gtkdoc:
2209         (get_webkit2_options): Use the prefix of the methods as namespace,
2210         since this is what gtkdoc expects to sort the index.
2211         (get_webkit1_options): Ditto.
2212         (get_webkitdom_options): Ditto.
2213         * gtk/generate-webkitdom-doc-files:
2214         (WebKitDOMDocGenerator): Add a global list of deleted objects.
2215         (WebKitDOMDocGenerator.write_deleted_classes): New method to write
2216         the documentation for classes that are deprecated because they
2217         have been removed.
2218         (WebKitDOMDocGeneratorDocs.write_deleted_classes): Add sections
2219         for deleted classes too.
2220         (WebKitDOMDocGeneratorSections.__init__): Build a list of
2221         deprecated symbols using the given symbols file.
2222         (WebKitDOMDocGeneratorSections._deleted_class): Returns the
2223         deleted class corresponding to the given function.
2224         (WebKitDOMDocGeneratorSections._deprecated_symbols): Builds a
2225         dictionary of deprecated symbols for every class.
2226         (WebKitDOMDocGeneratorSections.write_section): Add also the
2227         deprecated symbols in every section.
2228         (WebKitDOMDocGeneratorSections.write_deleted_classes): Add
2229         sections for deleted classes too.
2230
2231 2013-11-20  László Langó  <lango@inf.u-szeged.hu>
2232
2233         check-webkit-style should support C++11 rvalue references.
2234         https://bugs.webkit.org/show_bug.cgi?id=123406
2235
2236         Reviewed by Brent Fulgham.
2237
2238         * Scripts/webkitpy/style/checkers/cpp.py:
2239         (check_style):
2240         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2241         (Cpp11StyleTest):
2242         (Cpp11StyleTest.test_rvaule_reference_at_end_of_line):
2243
2244 2013-11-20  Dean Jackson  <dino@apple.com>
2245
2246         Allow settings to be shown/hidden on build.webkit.org/dashboard
2247         https://bugs.webkit.org/show_bug.cgi?id=124694
2248
2249         Reviewed by Tim Horton.
2250
2251         In preparation for more options/buttons, allow the page to
2252         show or hide all the interactive things using a little gear icon
2253         in the top left corner.
2254
2255         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2256         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
2257         (Settings.prototype.toggleSettingsDisplay):
2258         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2259         (div.cellButton.hide):
2260         (div.cellButton.unhide):
2261         (.settings-visible div.cellButton.hide, .settings-visible div.cellButton.unhide):
2262         (.settings):
2263         (.settings:hover):
2264         (.settings-visible .settings):
2265
2266 2013-11-20  Dean Jackson  <dino@apple.com>
2267
2268         No need to base64 SVG on build.webkit.org/dashboard
2269         https://bugs.webkit.org/show_bug.cgi?id=124687
2270
2271         Reviewed by Tim Horton.
2272
2273         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
2274         (.status-line.good .bubble.pictogram):
2275
2276 2013-11-20  Dean Jackson  <dino@apple.com>
2277
2278         Make links look more like links on build.webkit.org/dashboard
2279         https://bugs.webkit.org/show_bug.cgi?id=124686
2280
2281         Reviewed by Tim Horton.
2282
2283         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css:
2284         (.queue-view .queueLabel:hover):
2285         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
2286         (.status-line.linked .label:hover):
2287
2288 2013-11-20  Nick Diego Yamane  <nick.yamane@openbossa.org>
2289
2290         Modify webkitdirs to reuse checkForArgumentAndRemoveFromARGV
2291         https://bugs.webkit.org/show_bug.cgi?id=124581
2292
2293         Reviewed by Daniel Bates.
2294
2295         Some subroutines are replicating code from checkForArgument**
2296         functions instead of reusing them as is being done by all other functions.
2297
2298         * Scripts/webkitdirs.pm:
2299         (determineXcodeSDK): Added.
2300         (determinePassedConfiguration): Added.
2301         (determinePassedArchitecture): Added.
2302         (checkForArgumentAndRemoveFromARGV): Added.
2303         (checkForArgumentAndRemoveFromARGVGettingValue): Added.
2304
2305 2013-11-20  Jozsef Berta  <jberta@inf.u-szeged.hu>
2306
2307         Delete baseline optimizer
2308         https://bugs.webkit.org/show_bug.cgi?id=122333
2309
2310         Reviewed by Ryosuke Niwa.
2311
2312         * Scripts/webkitpy/common/checkout/baselineoptimizer.py: Removed.
2313         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py: Removed.
2314         * Scripts/webkitpy/tool/commands/rebaseline.py:
2315         (RebaselineTest.execute):
2316         (AbstractParallelRebaselineCommand._files_to_add):
2317         (AbstractParallelRebaselineCommand._rebaseline):
2318         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2319         (TestRebaselineJson.test_rebaseline_all):
2320         (TestRebaselineJson.test_rebaseline_debug):
2321         (TestRebaselineExpectations.disabled_test_overrides_are_included_correctly):
2322
2323 2013-11-20  Anders Carlsson  <andersca@apple.com>
2324
2325         Enable PageLoadTest assertions again
2326         https://bugs.webkit.org/show_bug.cgi?id=124681
2327
2328         Reviewed by Tim Horton.
2329
2330         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2331         Actually install all-content-in-one-iframe.html, noticed while debugging this assertion.
2332
2333 2013-11-20  Mark Rowe  <mrowe@apple.com>
2334
2335         Remove some obsolete logic from WebKit.app.
2336
2337         Reviewed by Alexey Proskuryakov.
2338
2339         * WebKitLauncher/WebKitNightlyEnabler.m:
2340         (poseAsWebKitApp): Remove a pre-10.6 codepath.
2341         (enableWebKitNightlyBehaviour): Remove a 10.4-specific codepath.
2342
2343 2013-11-20  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
2344
2345         Moved stray urls from svn.py and statusserver.py into common.config.urls
2346         https://bugs.webkit.org/show_bug.cgi?id=124650
2347
2348         Reviewed by Ryosuke Niwa.
2349
2350         * Scripts/webkitpy/common/checkout/scm/svn.py:
2351         (SVNRepository):
2352         * Scripts/webkitpy/common/config/urls.py:
2353         * Scripts/webkitpy/common/net/statusserver.py:
2354         (StatusServer.__init__):
2355         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2356         (_generate_results_dict):
2357
2358 2013-11-20  Commit Queue  <commit-queue@webkit.org>
2359
2360         Unreviewed, rolling out r159496.
2361         http://trac.webkit.org/changeset/159496
2362         https://bugs.webkit.org/show_bug.cgi?id=124641
2363
2364         It caused warning and build break with cmake lower than 2.8.8
2365         (Requested by ryuan on #webkit).
2366
2367         * MiniBrowser/efl/CMakeLists.txt:
2368
2369 2013-11-20  Gabor Rapcsanyi  <rgabor@webkit.org>
2370
2371         [EFL] libseccomp-2.0.0 doesn't support ARM architecture
2372         https://bugs.webkit.org/show_bug.cgi?id=124412
2373
2374         Reviewed by Gyuyoung Kim.
2375
2376         Update libseccomp to a newer 2.1.0 version.
2377
2378         * efl/jhbuild.modules:
2379
2380 2013-11-19  Mark Rowe  <mrowe@apple.com>
2381
2382         <rdar://problem/15487072> Modernize WebKit.app's OS X version checking logic.
2383
2384         Gestalt is deprecated on recent OS X versions so we should switch off it.
2385
2386         Reviewed by Sam Weinig.
2387
2388         * WebKitLauncher/main.m:
2389         (currentMacOSXVersion): Retrieve the version string from SystemVersion.plist.
2390         (currentMacOSXMajorVersion): Split the version string at the periods, retrieve the first
2391         two components, then join them back up.
2392         (main): Switch to using currentMacOSXMajorVersion to make it clearer which part of
2393         the version we care about.
2394
2395 2013-11-19  Commit Queue  <commit-queue@webkit.org>
2396
2397         Unreviewed, rolling out r159538.
2398         http://trac.webkit.org/changeset/159538
2399         https://bugs.webkit.org/show_bug.cgi?id=124627
2400
2401         it broke run-jsc-stress-tests (Requested by mhahnenberg on
2402         #webkit).
2403
2404         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
2405         * Scripts/run-javascriptcore-tests:
2406         * Scripts/run-jsc-stress-tests:
2407
2408 2013-11-19  Mark Hahnenberg  <mhahnenberg@apple.com>
2409
2410         run-jsc-stress-tests should be able to package its tests and move them places
2411         https://bugs.webkit.org/show_bug.cgi?id=124549
2412
2413         Reviewed by Geoff Garen and Filip Pizlo.
2414
2415         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. This script was just a ruby reimplementation 
2416         of grep -i -q 
2417         * Scripts/run-javascriptcore-tests: Pass through the --make-bundle flag.
2418         * Scripts/run-jsc-stress-tests: Added the new concept of a "bundle", which is a collection of all tests and any
2419         other files that those tests require to run in any environment along with a fixed root directory into which these
2420         files and their expected directory structure are cloned. The default Bundle class is basically 
2421         a no-op so that it functions like run-jsc-stress-tests prior to this patch. MovableBundle is a Bundle that knows 
2422         how to translate local paths to bundle paths and does all the work of moving each test file into the right place 
2423         inside the .tests directory. After all the test files have been created in jsc-stress-results MovableBundle 
2424         creates a tarball of the entire directory for easy relocation. The --make-bundle flag causes run-jsc-stress-tests 
2425         to use MovableBundle instead of just Bundle. 
2426
2427 2013-11-19  Dan Bernstein  <mitz@apple.com>
2428
2429         <rdar://problem/15139479> Reenable the JSC Objective-C API tests on Mountain Lion once the bots are running Xcode 5
2430
2431         Rubber-stamped by Mark Rowe.
2432
2433         Reverted r156840.
2434
2435         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:
2436
2437 2013-11-19  Ryosuke Niwa  <rniwa@webkit.org>
2438
2439         Yet another build fix. Just allow any character.
2440         There are just too many special characters to be listed here.
2441
2442         * Scripts/webkitpy/performance_tests/perftest.py:
2443         (PerfTest._lines_to_ignore_in_parser_result):
2444         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2445         (TestPerfTest.test_parse_output_with_subtests)
2446
2447 2013-11-19  Ryosuke Niwa  <rniwa@webkit.org>
2448
2449         Another build fix. Allow ':' in subtest names.
2450
2451         * Scripts/webkitpy/performance_tests/perftest.py:
2452         (PerfTest._lines_to_ignore_in_parser_result):
2453         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2454         (TestPerfTest.test_parse_output_with_subtests)
2455
2456 2013-11-19  Ryuan Choi  <ryuan.choi@samsung.com>
2457
2458         [EFL] Use Config mode of find_package for EFL 1.8
2459         https://bugs.webkit.org/show_bug.cgi?id=124555
2460
2461         Reviewed by Gyuyoung Kim.
2462
2463         * MiniBrowser/efl/CMakeLists.txt: Introduced a config mode to find elementary.
2464
2465 2013-11-19  Ryosuke Niwa  <rniwa@webkit.org>
2466
2467         Build fix. Subtest names need to be more permissive.
2468
2469         * Scripts/webkitpy/performance_tests/perftest.py:
2470         (PerfTest._lines_to_ignore_in_parser_result):
2471         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2472         (TestPerfTest.test_parse_output_with_subtests)
2473
2474 2013-11-18  Mark Rowe  <mrowe@apple.com>
2475
2476         Use hw.activecpu for determining how many processes to spawn.
2477
2478         It's documented as the preferred way to determine the number of threads
2479         or processes to create in a SMP aware application.
2480
2481         Rubber-stamped by Tim Horton.
2482
2483         * Scripts/copy-webkitlibraries-to-product-directory:
2484         * Scripts/run-jsc-stress-tests:
2485         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2486
2487 2013-11-18  Tim Horton  <timothy_horton@apple.com>
2488
2489         build.webkit.org/dashboard builder headers should link to the builder page
2490         https://bugs.webkit.org/show_bug.cgi?id=124553
2491
2492         Reviewed by Timothy Hatcher.
2493
2494         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2495         (BuildbotQueue.prototype.get overviewURL):
2496         Add overviewURL(), which returns the URL to the builder overview page, with the last 50 builds shown.
2497
2498         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
2499         (BuildbotBuilderQueueView.prototype.update.appendBuildArchitecture):
2500         (BuildbotBuilderQueueView.prototype.update):
2501         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2502         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2503         (BuildbotTesterQueueView.prototype.update.appendBuild):
2504         (BuildbotTesterQueueView.prototype.update):
2505         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css:
2506         (.queue-view .queueLabel):
2507         (.queue-view .queueLabel:not(:first-child)):
2508         Make the header a link instead of a label, and wire it up to overviewURL.
2509
2510 2013-11-18  Samuel White  <samuel_white@apple.com>
2511
2512         AX: Add ability to fetch only visible table rows.
2513         https://bugs.webkit.org/show_bug.cgi?id=124430
2514
2515         Reviewed by Chris Fleizach.
2516
2517         Adding method to fetch array of AccessibilityUIElements to help with test brevity and test breakage. Specifically, we
2518         have a good deal of churn any time we add or update an element attribute. This happens because the number of tests
2519         that rely on a simple element description text dump to verify a single attribute is non trivial. So any time you
2520         change add an attribute, you have to update all the tests that are now implicitly verifying this new attribute. But
2521         as the test guidelines state, our tests should be more focused and specific about what they test.
2522
2523         * DumpRenderTree/AccessibilityUIElement.cpp:
2524         (uiElementArrayAttributeValueCallback):
2525         (AccessibilityUIElement::uiElementArrayAttributeValue):
2526         (AccessibilityUIElement::getJSClass):
2527         * DumpRenderTree/AccessibilityUIElement.h:
2528         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2529         (AccessibilityUIElement::uiElementArrayAttributeValue):
2530         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2531         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
2532         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2533         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2534         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2535         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
2536         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2537         (WTR::AccessibilityUIElement::getUIElementsWithAttribute):
2538         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
2539
2540 2013-11-18  Ryosuke Niwa  <rniwa@webkit.org>
2541
2542         Simplify and reformat the output of performance tests inside test runners
2543         https://bugs.webkit.org/show_bug.cgi?id=124496
2544
2545         Reviewed by Antti Koivisto.
2546
2547         As a preparation to support subtests for Dromaeo and DoYouEvenBench, simplify the output
2548         performance tests generate. Instead of spitting out noise in PerfTestRunner (runner.js)
2549         and ignoring it in PerfTest._filter_output (perftest.py), simply avoid generating it in
2550         the first place.
2551
2552         Also modernize the output to adopt "metric" concept better and make it forward compatible
2553         with subtests.
2554
2555         With this patch, performance tests written using runner.js only produces empty lines or
2556         lines of the following format inside test runners (DumpRenderTree and WebKitTestRunner):
2557         <subtest name> -> [<value 1>, <value 2>, ...]
2558         :<metric name> -> [<value 1>, <value 2>, ...]
2559
2560         This greatly simplifies the parsing logic inside PerfTest._run_with_driver.
2561
2562         * Scripts/webkitpy/performance_tests/perftest.py:
2563         (PerfTest): Removed a bunch of regular expressions that are no longer used.
2564         (PerfTest._run_with_driver): Just parse the values and description and treat everything
2565         else as errors.
2566
2567         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2568         (TestPerfTest.test_parse_output): Removed the junk.
2569         (TestPerfTest._assert_failed_on_line): Extracted from test_parse_output_with_failing_line,
2570         which was removed in favor of the tests below.
2571         (TestPerfTest.test_parse_output_with_running_five_times): Added.
2572         (TestPerfTest.test_parse_output_with_detailed_info): Added.
2573         (TestPerfTest.test_parse_output_with_statistics): Added.
2574         (TestPerfTest.test_parse_output_with_description): Removed the junk.
2575         (TestPerfTest.test_parse_output_with_subtests): Ditto.
2576         (TestSingleProcessPerfTest.test_use_only_one_process): Ditto.
2577
2578         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2579         (EventTargetWrapperTestData): Ditto.
2580         (SomeParserTestData): Ditto.
2581         (MemoryTestData): Ditto.
2582
2583 2013-11-18  Tim Horton  <timothy_horton@apple.com>
2584
2585         Occasionally, hundreds of tests fail with small text diffs on Mavericks
2586         https://bugs.webkit.org/show_bug.cgi?id=124312
2587
2588         Reviewed by Simon Fraser.
2589
2590         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2591         (Manager._set_up_run):
2592         * Scripts/webkitpy/port/base.py:
2593         (Port.to.reset_preferences):
2594         * Scripts/webkitpy/port/mac.py:
2595         (MacPort.reset_preferences):
2596         Delete DumpRenderTree and WebKitTestRunner defaults domains before running tests,
2597         returning some of the functionality of 158652 after 159364 removed it.
2598
2599 2013-11-18  Tim Horton  <timothy_horton@apple.com>
2600
2601         Checkmarks are shifted down on iPhone at build.webkit.org/dashboard
2602         https://bugs.webkit.org/show_bug.cgi?id=122909
2603
2604         Reviewed by Alexey Proskuryakov.
2605
2606         Put the checkmark SVG in the CSS file as a data URI so it loads immediately.
2607
2608         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
2609         (.status-line .bubble):
2610         (.status-line.good .bubble.pictogram):
2611
2612 2013-11-18  Ryosuke Niwa  <rniwa@webkit.org>
2613
2614         Remove _lines_to_ignore_in_stderr, which was only used in Chromium port
2615         https://bugs.webkit.org/show_bug.cgi?id=124499
2616
2617         Reviewed by Csaba Osztrogonác.
2618
2619         Removed the code. I didn't like this hack back when it was added, and I don't like it today.
2620
2621         * Scripts/webkitpy/performance_tests/perftest.py:
2622         (PerfTest._should_ignore_line):
2623         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2624         (TestPerfTest): Removed the unit test.
2625
2626 2013-11-17  Filip Pizlo  <fpizlo@apple.com>
2627
2628         Unreviewed, fix this script for older Rubies where Pathname doesn't coerce to String
2629         quite as easily.
2630         
2631         With help from Andy Trick.
2632
2633         * Scripts/export-llvm-build:
2634
2635 2013-11-15  Filip Pizlo  <fpizlo@apple.com>
2636
2637         FTL should have an explicit notion of bytecode liveness
2638         https://bugs.webkit.org/show_bug.cgi?id=124181
2639
2640         Reviewed by Mark Hahnenberg.
2641
2642         * Scripts/run-jsc-stress-tests:
2643
2644 2013-11-16  Dan Bernstein  <mitz@apple.com>
2645
2646         No way for policy client to determine if a the response’s MIME type can be shown
2647         https://bugs.webkit.org/show_bug.cgi?id=124445
2648
2649         Reviewed by Sam Weinig.
2650
2651         * MiniBrowser/mac/WK2BrowserWindowController.m:
2652         (decidePolicyForResponse): Added canShowMIMEType parameter.
2653         (-[WK2BrowserWindowController awakeFromNib]): Updated for changes in the policy client.
2654
2655         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2656         (TestWebKitAPI::decidePolicyForResponse): Added canShowMIMEType parameter.
2657
2658         * WebKitTestRunner/TestController.cpp:
2659         (WTR::TestController::createWebViewWithOptions): Updated for changes in the policy client.
2660         (WTR::TestController::decidePolicyForResponse): Added canShowMIMEType parameter.
2661         * WebKitTestRunner/TestController.h:
2662
2663 2013-11-16  Tim Horton  <timothy_horton@apple.com>
2664
2665         Checkmarks are shifted down on iPhone at build.webkit.org/dashboard
2666         https://bugs.webkit.org/show_bug.cgi?id=122909
2667
2668         Reviewed by Timothy Hatcher.
2669
2670         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/checkmark.svg: Added.
2671         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
2672         (StatusLineView.prototype.set repeatCount):
2673         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
2674         (.status-line.good .bubble.pictogram):
2675         Use an SVG image instead of an obscure font for the checkboxes so they
2676         render identically on all platforms.
2677
2678 2013-11-15  Tim Horton  <timothy_horton@apple.com>
2679
2680         Occasionally, hundreds of tests fail with small text diffs on Mavericks
2681         https://bugs.webkit.org/show_bug.cgi?id=124312
2682
2683         Reviewed by Alexey Proskuryakov.
2684
2685         Try reverting the part of r158652 that deleted all of the persistent
2686         defaults, in the thought that there might be some sort of race between
2687         processes causing some settings to be left in the wrong state.
2688
2689         * DumpRenderTree/mac/DumpRenderTree.mm:
2690         (setDefaultsToConsistentValuesForTesting):
2691         * WebKitTestRunner/mac/main.mm:
2692         (setDefaultsToConsistentValuesForTesting):
2693
2694 2013-11-15  Dan Bernstein  <mitz@apple.com>
2695
2696         Give the policy client the originating frame of a navigation action
2697         https://bugs.webkit.org/show_bug.cgi?id=124431
2698
2699         Reviewed by Anders Carlsson.
2700
2701         * MiniBrowser/mac/WK2BrowserWindowController.m:
2702         (decidePolicyForNavigationAction): Added originatingFrame parameter.
2703         (-[WK2BrowserWindowController awakeFromNib]): Updated for the new version of the policy
2704         client.
2705
2706         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
2707         (TestWebKitAPI::decidePolicyForNavigationAction): Added originatingFrame parameter.
2708         (TestWebKitAPI::setPagePolicyClient): Updated for the new version of the policy client.
2709
2710         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2711         (TestWebKitAPI::decidePolicyForNavigationAction): Added originatingFrame parameter.
2712         (TestWebKitAPI::TEST): Updated for the new version of the policy client.
2713
2714         * WebKitTestRunner/TestController.cpp:
2715         (WTR::TestController::createWebViewWithOptions): Updated for the new version of the policy
2716         client.
2717         (WTR::TestController::decidePolicyForNavigationAction): Added originatingFrame parameter.
2718         * WebKitTestRunner/TestController.h:
2719
2720 2013-11-15  Tim Horton  <timothy_horton@apple.com>
2721
2722         build.webkit.org/dashboard should provide a way to focus on a subset of bots
2723         https://bugs.webkit.org/show_bug.cgi?id=122676
2724
2725         Reviewed by Timothy Hatcher.
2726
2727         Add a small 'hide' button next to every platform logo, and a 'show all'
2728         button which only appears when at least one platform is hidden. Hidden
2729         platforms persist using localStorage.
2730
2731         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
2732         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2733         (updateHiddenPlatforms):
2734         (documentReady.unhideButton):
2735         (documentReady.hideButton):
2736         (documentReady):
2737         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js: Added.
2738         (Settings.prototype.setObject):
2739         (Settings.prototype.getObject):
2740         (Settings.prototype.addSettingListener):
2741         (Settings.prototype.fireSettingListener):
2742         (Settings.prototype.toggleHiddenPlatform):
2743         (Settings.prototype.clearHiddenPlatforms):
2744         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2745         (div.cellButton):
2746         (div.cellButton.hide):
2747         (.hidden):
2748         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
2749
2750 2013-11-15  Jer Noble  <jer.noble@apple.com>
2751
2752         MediaTime addition and subtraction operators have errors when the rhs is infinite.
2753         https://bugs.webkit.org/show_bug.cgi?id=124413
2754
2755         Reviewed by Eric Carlson.
2756
2757         Add a test for operator+ and operator- where an infinite value appears
2758         on the right-hand side:
2759         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
2760         (TestWebKitAPI::TEST):
2761
2762         Add a LLDB summary provider for MediaTime which displays the rational
2763         time as well as the value in seconds:
2764         * lldb/lldb_webkit.py:
2765         (__lldb_init_module):
2766         (WTFMediaTime_SummaryProvider):
2767         (WTFHashTableProvider.has_children):
2768         (WTFMediaTimeProvider):
2769         (WTFMediaTimeProvider.__init__):
2770         (WTFMediaTimeProvider.timeValue):
2771         (WTFMediaTimeProvider.timeScale):
2772         (WTFMediaTimeProvider.isInvalid):
2773         (WTFMediaTimeProvider.isPositiveInfinity):
2774         (WTFMediaTimeProvider.isNegativeInfinity):
2775         (WTFMediaTimeProvider.isIndefinite):
2776
2777 2013-11-15  Tim Horton  <timothy_horton@apple.com>
2778
2779         Make it possible to select revision numbers on build.webkit.org/dashboard
2780         https://bugs.webkit.org/show_bug.cgi?id=124400
2781
2782         Reviewed by Timothy Hatcher.
2783
2784         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2785         (BuildbotQueueView.prototype.revisionLinksForIteration):
2786         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2787         (.selectable):
2788         Add a child span to the trac link, which has '-webkit-user-select: all' on it.
2789         This way, a Dashboard user can highlight revision numbers for easy copying,
2790         and doesn't even have to be precise about the selection.
2791
2792 2013-11-15  Tim Horton  <timothy_horton@apple.com>
2793
2794         Adjust and add retina versions of EFL and GTK build.webkit.org/dashboard icons
2795         https://bugs.webkit.org/show_bug.cgi?id=124399
2796
2797         Reviewed by Gustavo Noronha Silva.
2798
2799         Add new EFL and GTK icons (derived from Wikipedia's SVGs) to make new 1x and 2x icons,
2800         with the icons adjusted to have solid backgrounds, to not be squished, and to not
2801         intersect the ring, similar to the Mac icons.
2802
2803         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png:
2804         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL@2x.png: Added.
2805         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK.png:
2806         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK@2x.png: Added.
2807         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2808         (documentReady.hideButton):
2809         (documentReady):
2810         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2811         (table.queue-grid tr.platform.linux-gtk img.logo):
2812         (table.queue-grid tr.platform.linux-efl img.logo):
2813
2814 2013-11-15  Stephane Jadaud  <sjadaud@sii.fr>
2815
2816         [GStreamer] Add support for Media Source API
2817         https://bugs.webkit.org/show_bug.cgi?id=99065
2818
2819         Reviewed by Philippe Normand.
2820
2821         * Scripts/webkitperl/FeatureList.pm:
2822
2823 2013-11-15  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2824
2825         [GTK] Bumping GStreamer version to 1.2.1 for the dependencies
2826         https://bugs.webkit.org/show_bug.cgi?id=124360
2827
2828         Reviewed by Philippe Normand.
2829
2830         * gtk/jhbuild.modules: Bumped GStreamer version up to 1.2.1
2831
2832 2013-11-14  Brent Fulgham  <bfulgham@apple.com>
2833
2834         [Win] Improve support for command line builds of 64-bit JSC
2835         https://bugs.webkit.org/show_bug.cgi?id=124380
2836
2837         Reviewed by David Kilzer.
2838
2839         * Scripts/webkitdirs.pm:
2840         (argumentsForConfiguration): Recognize all flavors of Debug and Release (i.e., 'Debug',
2841         'Debug|Win32', 'Debug|x64') when passing arguments to child processes.
2842         (determinePassedConfiguration): Don't suffix configuration with "|Win32" or "|x64". That's
2843         what the "$configurationForVisualStudio" value is for.
2844
2845 2013-11-14  Oliver Hunt  <oliver@apple.com>
2846
2847         Make CLoop easier to build, and make it work
2848         https://bugs.webkit.org/show_bug.cgi?id=124359
2849
2850         Reviewed by Geoffrey Garen.
2851
2852         Add --cloop support to forcibly enable to CLoop build
2853
2854         * Scripts/build-jsc:
2855         * Scripts/build-webkit:
2856
2857 2013-11-14  Lucas Forschler  <lforschler@apple.com>
2858
2859         Add webkit slave.
2860
2861         Unreviewed.
2862
2863         * BuildSlaveSupport/build.webkit.org-config/config.json:
2864
2865 2013-11-14  Tim Horton  <timothy_horton@apple.com>
2866
2867         build.webkit.org/dashboard can’t open different results in two new tabs
2868         https://bugs.webkit.org/show_bug.cgi?id=124383
2869
2870         Reviewed by Alexey Proskuryakov.
2871
2872         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2873         (BuildbotQueueView.prototype.revisionLinksForIteration):
2874         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
2875         (StatusLineView.prototype._clicked):
2876         Use _blank (which is effectively open-in-new-tab, in Safari) instead of _new (which isn't a
2877         real pseudo-target and instead acts as a named target and will end up causing all link clicks
2878         to open in the same secondary tab).
2879
2880 2013-11-14  Anders Carlsson  <andersca@apple.com>
2881
2882         Remove duplicate entry.
2883
2884         * Scripts/webkitpy/common/config/contributors.json:
2885
2886 2013-11-14  Krzysztof Czech  <k.czech@samsung.com>
2887
2888         [ATK] Change WKTR/DRT AX methods to use nullptr 
2889         https://bugs.webkit.org/show_bug.cgi?id=124352
2890
2891         Reviewed by Anders Carlsson.
2892
2893         Change WKTR/DRT accessibility related methods to use nullptr.
2894
2895         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
2896         (AccessibilityController::AccessibilityController):
2897         (AccessibilityController::elementAtPoint):
2898         (AccessibilityController::removeNotificationListener):
2899         (AccessibilityController::childElementById):
2900         * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.cpp:
2901         (AccessibilityNotificationHandler::AccessibilityNotificationHandler):
2902         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2903         (AccessibilityUIElement::elementAtPoint):
2904         (AccessibilityUIElement::linkedUIElementAtIndex):
2905         (AccessibilityUIElement::getChildAtIndex):
2906         (AccessibilityUIElement::titleUIElement):
2907         (AccessibilityUIElement::parentElement):
2908         (AccessibilityUIElement::subrole):
2909         (AccessibilityUIElement::roleDescription):
2910         (AccessibilityUIElement::orientation):
2911         (AccessibilityUIElement::ariaDropEffects):
2912         (AccessibilityUIElement::uiElementForSearchPredicate):
2913         (AccessibilityUIElement::cellForColumnAndRow):
2914         (AccessibilityUIElement::disclosedRowAtIndex):
2915         (AccessibilityUIElement::ariaOwnsElementAtIndex):
2916         (AccessibilityUIElement::ariaFlowToElementAtIndex):
2917         (AccessibilityUIElement::selectedRowAtIndex):
2918         (AccessibilityUIElement::rowAtIndex):
2919         (AccessibilityUIElement::disclosedByRow):
2920         (AccessibilityUIElement::removeNotificationListener):
2921         (AccessibilityUIElement::classList):
2922         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2923         (WTR::AccessibilityController::logAccessibilityEvents):
2924         (WTR::AccessibilityController::resetToConsistentState):
2925         (WTR::childElementById):
2926         (WTR::AccessibilityController::accessibleElementById):
2927         (WTR::AccessibilityController::removeNotificationListener):
2928         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2929         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
2930         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
2931         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2932         (WTR::AccessibilityUIElement::elementAtPoint):
2933         (WTR::AccessibilityUIElement::childAtIndex):
2934         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
2935         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
2936         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
2937         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
2938         (WTR::AccessibilityUIElement::rowAtIndex):
2939         (WTR::AccessibilityUIElement::selectedChildAtIndex):
2940         (WTR::AccessibilityUIElement::selectedRowAtIndex):
2941         (WTR::AccessibilityUIElement::titleUIElement):
2942         (WTR::AccessibilityUIElement::parentElement):
2943         (WTR::AccessibilityUIElement::disclosedByRow):
2944         (WTR::AccessibilityUIElement::uiElementAttributeValue):
2945         (WTR::AccessibilityUIElement::orientation):
2946         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2947         (WTR::AccessibilityUIElement::cellForColumnAndRow):
2948         (WTR::AccessibilityUIElement::horizontalScrollbar):
2949         (WTR::AccessibilityUIElement::verticalScrollbar):
2950         (WTR::AccessibilityUIElement::removeNotificationListener):
2951         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
2952         (WTR::AccessibilityUIElement::previousTextMarker):
2953         (WTR::AccessibilityUIElement::nextTextMarker):
2954         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
2955         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
2956         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
2957         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
2958         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
2959         (WTR::AccessibilityUIElement::textMarkerForPoint):
2960         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
2961         (WTR::AccessibilityUIElement::textMarkerForIndex):
2962         (WTR::AccessibilityUIElement::supportedActions):
2963         (WTR::AccessibilityUIElement::pathDescription):
2964         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
2965         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
2966         (WTR::AccessibilityUIElement::classList):
2967
2968 2013-11-14  Éva Balázsfalvi  <balazsfalvi.eva@stud.u-szeged.hu>
2969
2970         run-perf-tests should warn loudly if you're using a Debug build.
2971         https://bugs.webkit.org/show_bug.cgi?id=105236
2972
2973         Reviewed by Csaba Osztrogonác.
2974
2975         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2976         (PerfTestsRunner.run):
2977
2978 2013-11-14  Éva Balázsfalvi  <balazsfalvi.eva@stud.u-szeged.hu>
2979
2980         Fix Tools/Scripts/webkitpy/port/factory.py --help to display which configuration is default
2981         https://bugs.webkit.org/show_bug.cgi?id=124143
2982
2983         Reviewed by Csaba Osztrogonác.
2984
2985         * Scripts/webkitpy/port/factory.py:
2986         (configuration_options):
2987
2988 2013-11-13  Anders Carlsson  <andersca@apple.com>
2989
2990         Add a Vector constructor that takes an std::initializer_list
2991         https://bugs.webkit.org/show_bug.cgi?id=124287
2992
2993         Reviewed by Antti Koivisto.
2994
2995         * TestWebKitAPI/Tests/WTF/Vector.cpp:
2996         (TestWebKitAPI::TEST):
2997
2998 2013-11-13  Mario Sanchez Prada  <mario.prada@samsung.com>
2999
3000         Unreviewed GTK gardening. Updated rebaseline unit tests to include WK2 bot.
3001
3002         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3003         (TestRebaselineTest.test_baseline_directory): Updated.
3004
3005 2013-11-13  Krzysztof Czech  <k.czech@samsung.com>
3006
3007         [ATK] Support compilation of EFL/GTK without accessibility
3008         https://bugs.webkit.org/show_bug.cgi?id=122448
3009
3010         Reviewed by Chris Fleizach.
3011
3012         Added missing HAVE(ACCESSIBILITY) guards and stubs to ATK's related files,
3013         so that in case of turning off the HAVE_ACCESSIBILITY macro EFL/GTK would compile properly.
3014
3015         * DumpRenderTree/AccessibilityController.h:
3016         * DumpRenderTree/AccessibilityUIElement.h:
3017         * DumpRenderTree/atk/AccessibilityCallbacks.h:
3018         * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.cpp:
3019         * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.h:
3020         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3021         (WTR::AccessibilityController::rootElement):
3022         (WTR::AccessibilityController::focusedElement):
3023         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3024         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
3025         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3026         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h:
3027         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3028         * WebKitTestRunner/PlatformEfl.cmake:
3029
3030 2013-11-12  Ryuan Choi  <ryuan.choi@samsung.com>
3031
3032         [EFL] Added libxss-dev to install-dependencies
3033         https://bugs.webkit.org/show_bug.cgi?id=124254
3034
3035         Reviewed by Gyuyoung Kim.
3036
3037         libxss-dev is required to build EFL packages.
3038         see building part in http://www.enlightenment.org/p.php?p=contribute
3039
3040         * efl/install-dependencies: Added libxss-dev to parameter of apt-get command.
3041
3042 2013-11-12  Tim Horton  <timothy_horton@apple.com>
3043
3044         After http://trac.webkit.org/changeset/159109, update
3045         rebaseline_unittest to use the new GTK bot names.
3046
3047         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3048         (TestRebaselineTest.test_baseline_directory):
3049
3050 2013-11-12  Denis Nomiyama  <d.nomiyama@samsung.com>
3051
3052         [GTK] Update GTK builders in Tools/Scripts/webkitpy/port/builders.py
3053         https://bugs.webkit.org/show_bug.cgi?id=124144
3054
3055         Reviewed by Gustavo Noronha Silva.
3056
3057         Updated the list of GTK builders in Tools/Scripts/webkitpy/port/builders.py
3058         according to http://build.webkit.org/builders.
3059
3060         * Scripts/webkitpy/port/builders.py:
3061
3062 2013-11-11  Samuel White  <samuel_white@apple.com>
3063
3064         AX: support helpText() in DumpRenderTree
3065         https://bugs.webkit.org/show_bug.cgi?id=40194
3066
3067         Reviewed by Chris Fleizach.
3068
3069         Implemented stubbed helpText methods so we can move aria-help.html back to LayoutTests/accessibility.
3070
3071         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3072         (AccessibilityUIElement::helpText):
3073
3074 2013-11-11  Anders Carlsson  <andersca@apple.com>
3075
3076         Remove block based APIs from the WebKit2 C API
3077         https://bugs.webkit.org/show_bug.cgi?id=124157
3078
3079         Reviewed by Sam Weinig.
3080
3081         Update for WK2 changes.
3082
3083         * MiniBrowser/mac/WK2BrowserWindowController.m:
3084         (dumpSource):
3085         (-[WK2BrowserWindowController dumpSourceToConsole:]):
3086
3087 2013-11-11  Tamas Gergely  <gertom@inf.u-szeged.hu>
3088
3089         The feeder queue will not feed patches older than one week.
3090         https://bugs.webkit.org/show_bug.cgi?id=107152
3091
3092         Reviewed by Csaba Osztrogonác.
3093
3094         The feeder queue will not feed patches older than one week.
3095         Unit test added to this scenario.
3096
3097         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3098         (BugzillaQueries._parse_attachment_ids_request_query):
3099           Handle date parameter.
3100         (BugzillaQueries):
3101         (BugzillaQueries._fetch_attachment_ids_request_query):
3102           Propagate date.
3103         (BugzillaQueries.fetch_attachment_ids_from_review_queue):
3104           Propagate date.
3105         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
3106         (MockBugzillaQueries.fetch_attachment_ids_from_review_queue):
3107           Handle date.
3108         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3109         (test_request_page_parsing):
3110           Unit test added.
3111         * Scripts/webkitpy/tool/bot/feeders.py:
3112         (EWSFeeder.feed):
3113           Query patch ids with date parameter (now - 1 week).
3114
3115 2013-11-11  Tamas Gergely  <gertom@inf.u-szeged.hu>
3116
3117         Do not shut down ImageDiff server after every diff during the tests.
3118         https://bugs.webkit.org/show_bug.cgi?id=124140
3119
3120         Reviewed by Csaba Osztrogonác.
3121
3122         There was a FIXME: There is no need to shut down the ImageDiff
3123         server after every diff. Shutdown is removed from that point.
3124
3125         * Scripts/webkitpy/port/image_diff.py:
3126         (ImageDiffer._read):
3127
3128 2013-11-08  Matthew Hanson  <matthew_hanson@apple.com>
3129
3130         Unreviewed. Added myself as a contributor.
3131
3132         * Scripts/webkitpy/common/config/contributors.json:
3133
3134 2013-11-08  Krzysztof Czech  <k.czech@samsung.com>
3135
3136         [GTK] accessibility/aria-link-supports-press.html is failing
3137         https://bugs.webkit.org/show_bug.cgi?id=98355
3138
3139         Reviewed by Mario Sanchez Prada.
3140
3141         Checking "jump" action for link elements. Action "jump" occurs when a link 
3142         element is pressed/clicked.
3143
3144         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3145         (AccessibilityUIElement::isPressActionSupported):
3146         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3147         (WTR::AccessibilityUIElement::isPressActionSupported):
3148
3149 2013-11-08  Przemyslaw Szymanski  <p.szymanski3@samsung.com>
3150
3151         [JHBUILD] Jhbuild Makefile build bug workaround
3152         https://bugs.webkit.org/show_bug.cgi?id=123971
3153
3154         Reviewed by Ryosuke Niwa.
3155
3156         After Jhbuild repository is cloned (for instance when you use
3157         Tools/Scripts/update-webkitefl-libs) it is built from sources.
3158         If you have GREP_OPTIONS grep env variable set (for instance
3159         GREP_OPTIONS=-n) then it is jhbuild build error. Makefile.plain
3160         uses shell grep. For specific GREP_OPTIONS grep output will be
3161         different than expected one by Jhbuild and there is an error
3162         with Jhbuild build. Jhbuild will not be built and then WebKit
3163         source also will not be built. This patch is a workaround to this
3164         issue. It disables GREP_OPTIONS for Jhbuild build time.
3165
3166         * jhbuild/jhbuild-wrapper:
3167         (install_jhbuild):
3168
3169 2013-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3170
3171         [GTK] Ignore deprecated macros when generating gtk-doc
3172         https://bugs.webkit.org/show_bug.cgi?id=123988
3173
3174         Reviewed by Philippe Normand.
3175
3176         * gtk/generate-gtkdoc:
3177         (get_common_options): Ignore also WEBKIT_DEPRECATED and
3178         WEBKIT_DEPRECATED_FOR decorators.
3179
3180 2013-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3181
3182         [GTK] Pass the library namespace to gtkdoc-mkdb
3183         https://bugs.webkit.org/show_bug.cgi?id=123900
3184
3185         Reviewed by Martin Robinson.
3186
3187         This fixes the generation of the index of symbols in the API
3188         documentation.
3189
3190         * gtk/generate-gtkdoc:
3191         (get_webkit2_options): Define namespace as WebKit.
3192         (get_webkit1_options): Ditto.
3193         (get_webkitdom_options): Define namespace as WebKitDOM.
3194         * gtk/gtkdoc.py:
3195         (GTKDoc.__init__): Add namespace option.
3196         (GTKDoc._run_gtkdoc_mkdb): Pass namespace to mkdb if present.
3197
3198 2013-11-07  Chris Fleizach  <cfleizach@apple.com>
3199
3200         Modify email order list for James Craig so his primary email is first.
3201
3202         * Scripts/webkitpy/common/config/contributors.json:
3203
3204 2013-11-07  Nick Diego Yamane  <nick.yamane@openbossa.org>
3205
3206         [Gtk] Disable LTO when building cairo
3207         https://bugs.webkit.org/show_bug.cgi?id=123954
3208
3209         Reviewed by Martin Robinson.
3210
3211         Cairo always uses LTO, when it detects compiler support.
3212         LTO is buggy in many/all versions of GCC and shouldn't be enabled by
3213         default. This patch disables LTO when building cairo library.
3214         - See: https://bugs.freedesktop.org/show_bug.cgi?id=60852
3215
3216         With gcc 4.7.3, for example, the build fails with the following message:
3217         'lto1: fatal error: LTO_tags out of range: Range is 0 to 361, value is 15872'
3218
3219         * gtk/jhbuild.modules:
3220
3221 2013-11-07  Samuel White  <samuel_white@apple.com>
3222
3223         AX: DRT AccessibilityUIElement::isFocused methods should be finished.
3224         https://bugs.webkit.org/show_bug.cgi?id=123774
3225
3226         Reviewed by Chris Fleizach.
3227
3228         Implemented AccessibilityUIElement::isFocused methods and removed FIXMEs.
3229
3230         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3231         (AccessibilityUIElement::isFocused):
3232         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3233         (WTR::AccessibilityUIElement::isFocused):
3234
3235 2013-11-07  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
3236
3237         Removed retrieveQMakespecVar function
3238         https://bugs.webkit.org/show_bug.cgi?id=123996
3239
3240         Reviewed by Csaba Osztrogonác.
3241
3242         * Scripts/webkitdirs.pm:
3243
3244 2013-11-07  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
3245
3246         Removed QMake related filters
3247         https://bugs.webkit.org/show_bug.cgi?id=123992
3248
3249         Reviewed by Csaba Osztrogonác.
3250
3251         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3252         (TestRebaseline.test_rebaseline):
3253         (TestRebaselineExpectations.test_rebaseline_expectations):
3254
3255 2013-11-07  Nick Diego Yamane  <nick.yamane@openbossa.org>
3256
3257         [Efl] Disable LTO when building cairo
3258         https://bugs.webkit.org/show_bug.cgi?id=123947
3259
3260         Reviewed by Gyuyoung Kim.
3261
3262         Cairo always uses LTO, when it detects compiler support.
3263         LTO is buggy in many/all versions of GCC and shouldn't be enabled by
3264         default. This patch disables LTO when building cairo library.
3265         - See: https://bugs.freedesktop.org/show_bug.cgi?id=60852
3266
3267         With gcc 4.7.3, for example, the build fails with the following message:
3268         'lto1: fatal error: LTO_tags out of range: Range is 0 to 361, value is 15872'
3269
3270         * efl/jhbuild.modules:
3271
3272 2013-11-07  Mario Sanchez Prada  <mario.prada@samsung.com>
3273
3274         AX: [ATK] Video and audio elements are not properly exposed
3275         https://bugs.webkit.org/show_bug.cgi?id=123894
3276
3277         Reviewed by Chris Fleizach.
3278
3279         Update DRT and WKTR to handle the ATK_ROLE_EMBEDDED role.
3280
3281         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp: Updated.
3282         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: Updated.
3283
3284 2013-11-07  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
3285
3286         Change git_commit_from_svn_revision() to work in a pure git checkout
3287         https://bugs.webkit.org/show_bug.cgi?id=111668
3288
3289         Reviewed by Ryosuke Niwa.
3290
3291         * Scripts/webkitpy/common/checkout/scm/git.py:
3292         (Git.git_commit_from_svn_revision):
3293
3294 2013-11-06  Jer Noble  <jer.noble@apple.com>
3295
3296         Unreviewed webkitpy unit test fix; update baselines after r158765
3297
3298         * Scripts/webkitpy/port/win_unittest.py:
3299         (WinPortTest.test_baseline_search_path):
3300
3301 2013-11-06  Jer Noble  <jer.noble@apple.com>
3302
3303         [Win] run-webkit-tests on the win platform should fall back to mac-mountainlion, not mac-lion.
3304         https://bugs.webkit.org/show_bug.cgi?id=123905
3305
3306         Reviewed by Brent Fulgham.
3307
3308         Now that the mac-lion results have been removed, the win port should fall back to
3309         the mac-mountainlion results.
3310
3311         * Scripts/webkitpy/port/win.py:
3312         (WinPort.default_baseline_search_path):
3313
3314 2013-11-06  Anders Carlsson  <andersca@apple.com>
3315
3316         Fix a Mountain Lion test failure.
3317
3318         NSURLRequest doesn't conform to NSSecureCoding on Mountain Lion, so don't try to test encoding it.
3319
3320         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
3321         (TestWebKitAPI::TEST):
3322
3323 2013-11-06  Krzysztof Czech  <k.czech@samsung.com>
3324
3325         [ATK] Implement tables-related attributesOf*() functions for AccessibilityUIElement
3326         https://bugs.webkit.org/show_bug.cgi?id=118969
3327
3328         Reviewed by Mario Sanchez Prada.
3329
3330         Added missing implementation of attributesOfColumnHeaders, attributesOfRowHeaders, attributesOfVisibleCells.
3331
3332         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3333         (AccessibilityUIElement::attributesOfChildren):
3334         (AccessibilityUIElement::attributesOfColumnHeaders):
3335         (AccessibilityUIElement::attributesOfRowHeaders):
3336         (AccessibilityUIElement::attributesOfVisibleCells):
3337         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3338         (WTR::AccessibilityUIElement::attributesOfChildren):
3339         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
3340         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
3341         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
3342
3343 2013-11-05  Benjamin Poulain  <benjamin@webkit.org>
3344
3345         [WK2] Add a WebKit2 API for Geolocation's highAccuracy
3346         https://bugs.webkit.org/show_bug.cgi?id=123786
3347
3348         Reviewed by Darin Adler.
3349
3350         Add basic testing for the Geolocation API (start, stop and change accuracy).
3351
3352         * TestWebKitAPI/GNUmakefile.am:
3353         * TestWebKitAPI/PlatformEfl.cmake:
3354         * TestWebKitAPI/PlatformGTK.cmake:
3355         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3356         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp: Added.
3357         (TestWebKitAPI::operator<<):
3358         (TestWebKitAPI::GeolocationStateTracker::~GeolocationStateTracker):
3359         (TestWebKitAPI::GeolocationStateTracker::eventsChanged):
3360         (TestWebKitAPI::GeolocationStateTracker::startUpdatingCallback):
3361         (TestWebKitAPI::GeolocationStateTracker::stopUpdatingCallback):
3362         (TestWebKitAPI::GeolocationStateTracker::setEnableHighAccuracyCallback):
3363         (TestWebKitAPI::decidePolicyForGeolocationPermissionRequestCallBack):
3364         (TestWebKitAPI::setupGeolocationProvider):
3365         (TestWebKitAPI::setupView):
3366         (TestWebKitAPI::GeolocationBasicStateTracker::GeolocationBasicStateTracker):
3367         (TestWebKitAPI::GeolocationBasicStateTracker::eventsChanged):
3368         (TestWebKitAPI::GeolocationBasicWithHighAccuracyStateTracker::GeolocationBasicWithHighAccuracyStateTracker):
3369         (TestWebKitAPI::GeolocationBasicWithHighAccuracyStateTracker::eventsChanged):
3370         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker):
3371         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
3372         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker):
3373         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
3374         (TestWebKitAPI::didFinishLoadForFrame):
3375         * TestWebKitAPI/Tests/WebKit2/geolocationGetCurrentPosition.html: Added.
3376         * TestWebKitAPI/Tests/WebKit2/geolocationGetCurrentPositionWithHighAccuracy.html: Added.
3377         * TestWebKitAPI/Tests/WebKit2/geolocationWatchPosition.html: Added.
3378         * TestWebKitAPI/Tests/WebKit2/geolocationWatchPositionWithHighAccuracy.html: Added.
3379         * WebKitTestRunner/GeolocationProviderMock.cpp:
3380         (WTR::GeolocationProviderMock::GeolocationProviderMock):
3381
3382 2013-11-05  Anders Carlsson  <andersca@apple.com>
3383
3384         Implement more NSCoder methods
3385         https://bugs.webkit.org/show_bug.cgi?id=123815
3386
3387         Reviewed by Dan Bernstein.
3388
3389         Add a method that takes an NSArray, an NSDictionary and an NSURLRequest.
3390
3391         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
3392         (TestWebKitAPI::TEST):
3393         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm:
3394         (-[BundleObject testMethodWithArray:dictionary:request:]):
3395         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Shared.h:
3396
3397 2013-11-05  Filip Pizlo  <fpizlo@apple.com>
3398
3399         Update ReducedFTL
3400         https://bugs.webkit.org/show_bug.cgi?id=123805
3401
3402         Reviewed by Sam Weinig.
3403         
3404         - Make ReducedFTL build with debug info.
3405         
3406         - Give ReducedFTL a --loop mode that runs everything in a loop. Great for finding
3407           memory leaks and attaching a profiler.
3408         
3409         - Reorder the passes so that they match the FTL.
3410         
3411         - Make it possible to change the backend opt level and enable the fast isel.
3412
3413         * ReducedFTL/ReducedFTL.c:
3414         (usage):
3415         (roundUpSize):
3416         (mmAllocateCodeSection):
3417         (main):
3418         * ReducedFTL/build.sh:
3419
3420 2013-11-05  Chris Fleizach  <cfleizach@apple.com>
3421
3422         AX: switch DRT AX methods to use nullptr
3423         https://bugs.webkit.org/show_bug.cgi?id=123773
3424
3425         Reviewed by Andreas Kling.
3426
3427         Switch AX related code in DRT and WKTR to use nullptr.
3428
3429         * DumpRenderTree/AccessibilityUIElement.cpp:
3430         (AccessibilityUIElement::startTextMarker):
3431         (AccessibilityUIElement::endTextMarker):
3432         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3433         (findAccessibleObjectById):
3434         (AccessibilityController::accessibleElementById):
3435         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3436         (AccessibilityUIElement::getChildAtIndex):
3437         (AccessibilityUIElement::linkedUIElementAtIndex):
3438         (AccessibilityUIElement::ariaOwnsElementAtIndex):
3439         (AccessibilityUIElement::ariaFlowToElementAtIndex):
3440         (AccessibilityUIElement::disclosedRowAtIndex):
3441         (AccessibilityUIElement::selectedChildAtIndex):
3442         (AccessibilityUIElement::selectedRowAtIndex):
3443         (AccessibilityUIElement::rowAtIndex):
3444         (AccessibilityUIElement::titleUIElement):
3445         (AccessibilityUIElement::parentElement):
3446         (AccessibilityUIElement::disclosedByRow):
3447         (AccessibilityUIElement::stringAttributeValue):
3448         (AccessibilityUIElement::uiElementAttributeValue):
3449         (AccessibilityUIElement::role):
3450         (AccessibilityUIElement::subrole):
3451         (AccessibilityUIElement::roleDescription):
3452         (AccessibilityUIElement::title):
3453         (AccessibilityUIElement::description):
3454         (AccessibilityUIElement::orientation):
3455         (AccessibilityUIElement::stringValue):
3456         (AccessibilityUIElement::language):
3457         (AccessibilityUIElement::helpText):
3458         (AccessibilityUIElement::valueDescription):
3459         (AccessibilityUIElement::speak):
3460         (AccessibilityUIElement::classList):
3461         (AccessibilityUIElement::ariaDropEffects):
3462         (AccessibilityUIElement::rangeForLine):
3463         (AccessibilityUIElement::rangeForPosition):
3464         (AccessibilityUIElement::boundsForRange):
3465         (AccessibilityUIElement::stringForRange):
3466         (AccessibilityUIElement::attributedStringForRange):
3467         (AccessibilityUIElement::uiElementForSearchPredicate):
3468         (AccessibilityUIElement::attributesOfColumnHeaders):
3469         (AccessibilityUIElement::attributesOfRowHeaders):
3470         (AccessibilityUIElement::attributesOfColumns):
3471         (AccessibilityUIElement::attributesOfRows):
3472         (AccessibilityUIElement::attributesOfVisibleCells):
3473         (AccessibilityUIElement::attributesOfHeader):
3474         (AccessibilityUIElement::rowIndexRange):
3475         (AccessibilityUIElement::columnIndexRange):
3476         (AccessibilityUIElement::cellForColumnAndRow):
3477         (AccessibilityUIElement::horizontalScrollbar):
3478         (AccessibilityUIElement::verticalScrollbar):
3479         (AccessibilityUIElement::pathDescription):
3480         (AccessibilityUIElement::selectedTextRange):
3481         (AccessibilityUIElement::url):
3482         (AccessibilityUIElement::textMarkerRangeForElement):
3483         (AccessibilityUIElement::textMarkerForIndex):
3484         (AccessibilityUIElement::previousTextMarker):
3485         (AccessibilityUIElement::nextTextMarker):
3486         (AccessibilityUIElement::stringForTextMarkerRange):
3487         (AccessibilityUIElement::textMarkerRangeForMarkers):
3488         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
3489         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
3490         (AccessibilityUIElement::endTextMarkerForBounds):
3491         (AccessibilityUIElement::startTextMarkerForBounds):
3492         (AccessibilityUIElement::textMarkerForPoint):
3493         (AccessibilityUIElement::accessibilityElementForTextMarker):
3494         (AccessibilityUIElement::startTextMarker):
3495         (AccessibilityUIElement::endTextMarker):
3496         (AccessibilityUIElement::supportedActions):
3497         (AccessibilityUIElement::mathPostscriptsDescription):
3498         (AccessibilityUIElement::mathPrescriptsDescription):
3499         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3500         (WTR::AccessibilityController::accessibleElementById):
3501         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3502         (WTR::AccessibilityUIElement::startTextMarker):
3503         (WTR::AccessibilityUIElement::endTextMarker):
3504         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
3505         (WTR::findAccessibleObjectById):
3506         (WTR::AccessibilityController::accessibleElementById):
3507         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3508         (WTR::AccessibilityUIElement::childAtIndex):
3509         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
3510         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
3511         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
3512         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
3513         (WTR::AccessibilityUIElement::rowAtIndex):
3514         (WTR::AccessibilityUIElement::selectedChildAtIndex):
3515         (WTR::AccessibilityUIElement::selectedRowAtIndex):
3516         (WTR::AccessibilityUIElement::titleUIElement):
3517         (WTR::AccessibilityUIElement::parentElement):
3518         (WTR::AccessibilityUIElement::disclosedByRow):
3519         (WTR::AccessibilityUIElement::stringAttributeValue):
3520         (WTR::AccessibilityUIElement::uiElementAttributeValue):
3521         (WTR::AccessibilityUIElement::role):
3522         (WTR::AccessibilityUIElement::subrole):
3523         (WTR::AccessibilityUIElement::roleDescription):
3524         (WTR::AccessibilityUIElement::title):
3525         (WTR::AccessibilityUIElement::description):
3526         (WTR::AccessibilityUIElement::orientation):
3527         (WTR::AccessibilityUIElement::stringValue):
3528         (WTR::AccessibilityUIElement::language):
3529         (WTR::AccessibilityUIElement::helpText):
3530         (WTR::AccessibilityUIElement::valueDescription):
3531         (WTR::AccessibilityUIElement::classList):
3532         (WTR::AccessibilityUIElement::speak):
3533         (WTR::AccessibilityUIElement::ariaDropEffects):
3534         (WTR::AccessibilityUIElement::rangeForLine):
3535         (WTR::AccessibilityUIElement::rangeForPosition):
3536         (WTR::AccessibilityUIElement::boundsForRange):
3537         (WTR::AccessibilityUIElement::stringForRange):
3538         (WTR::AccessibilityUIElement::attributedStringForRange):
3539         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
3540         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
3541         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
3542         (WTR::AccessibilityUIElement::attributesOfColumns):
3543         (WTR::AccessibilityUIElement::attributesOfRows):
3544         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
3545         (WTR::AccessibilityUIElement::attributesOfHeader):
3546         (WTR::AccessibilityUIElement::rowIndexRange):
3547         (WTR::AccessibilityUIElement::columnIndexRange):
3548         (WTR::AccessibilityUIElement::cellForColumnAndRow):
3549         (WTR::AccessibilityUIElement::horizontalScrollbar):
3550         (WTR::AccessibilityUIElement::verticalScrollbar):
3551         (WTR::AccessibilityUIElement::selectedTextRange):
3552         (WTR::AccessibilityUIElement::url):
3553         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
3554         (WTR::AccessibilityUIElement::previousTextMarker):
3555         (WTR::AccessibilityUIElement::nextTextMarker):
3556         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
3557         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
3558         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
3559         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
3560         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
3561         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
3562         (WTR::AccessibilityUIElement::textMarkerForPoint):
3563         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
3564         (WTR::AccessibilityUIElement::textMarkerForIndex):
3565         (WTR::AccessibilityUIElement::startTextMarker):
3566         (WTR::AccessibilityUIElement::endTextMarker):
3567         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
3568         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
3569         (WTR::AccessibilityUIElement::pathDescription):
3570         (WTR::AccessibilityUIElement::supportedActions):
3571
3572 2013-11-05  László Langó  <laszlo.lango@frontendart.com>
3573
3574         Remove leftover Qt related things from the flakiness_dashboard
3575         https://bugs.webkit.org/show_bug.cgi?id=123800
3576
3577         Reviewed by Anders Carlsson.
3578
3579         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3580         (test):
3581
3582 2013-11-05  Robert Plociennik  <r.plociennik@samsung.com>
3583
3584         [EFL] accessibility/svg-group-element-with-title.html is failing
3585         https://bugs.webkit.org/show_bug.cgi?id=114151
3586
3587         Reviewed by Mario Sanchez Prada.
3588
3589         atk_component_ref_accessible_at_point(), utilized in
3590         AccessibilityUIElement::elementAtPoint(), is expected to 'get a reference to the
3591         accessible child, if one exists, at the coordinate point specified' and not
3592         explicitly return self in case of lack of child elements. This contradicts with
3593         expected behavior of elementAtPoint(). Therefore, elementAtPoint() is
3594         changed to return self regardless of coordinates specified, provided no child
3595         element could be retrieved, effectively mimicing the behaviour of equivalent
3596         Mac implementation in accessibilityHitTest().
3597
3598         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3599         (AccessibilityUIElement::elementAtPoint): Fixed.
3600         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3601         (WTR::AccessibilityUIElement::elementAtPoint): Fixed.
3602
3603 2013-11-05  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3604
3605         [CSS] Enable css-image-orientation on EFL and GTK ports.
3606         https://bugs.webkit.org/show_bug.cgi?id=123698
3607
3608         Reviewed by Beth Dakin.
3609
3610         r157909 added wrong early return for css-image-orientation. It causes about 20 regressions in layout test
3611         when enabling css-image-orientaiton. This fixes those wrong implementation as well as enables it on EFL
3612         and GTK ports by default.
3613
3614         * Scripts/webkitperl/FeatureList.pm:
3615
3616 2013-11-04  Alexey Proskuryakov  <ap@apple.com>
3617
3618         DumpRenderTree should reset its preferences file on launch
3619         https://bugs.webkit.org/show_bug.cgi?id=29751
3620
3621         Reviewed by Dan Bernstein.
3622
3623         Using NSArgumentDomain was not a good idea. While it works with NSUserDefaults
3624         and CFPreferencesCopyAppValue family of functions, it doesn't work with
3625         CFPreferencesCopyValue(..., kCFPreferencesCurrentApplication, ...).
3626
3627         So, now we'll just set defaults in the current application.
3628
3629         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
3630         - Delete the defaults.
3631         - Removed CFPreferencesSetAppValue calls, as -setValuesForKeysWithDictionary: does the same.
3632         - The comment about [NSUserDefaults standardUserDefaults] indirectly initializing NSApplication was incorrect.
3633
3634         * WebKitTestRunner/mac/main.mm: (setDefaultsToConsistentValuesForTesting):
3635         Switched to -setValuesForKeysWithDictionary for consistency.
3636
3637 2013-11-04  Filip Pizlo  <fpizlo@apple.com>
3638
3639         Running FTL tests shouldn't reduce coverage on DFG tests
3640         https://bugs.webkit.org/show_bug.cgi?id=123780
3641
3642         Reviewed by Geoffrey Garen.
3643
3644         * Scripts/run-jsc-stress-tests:
3645
3646 2013-11-04  Anders Carlsson  <andersca@apple.com>
3647
3648         More WKRemoteObjectRegistry work
3649         https://bugs.webkit.org/show_bug.cgi?id=123754
3650
3651         Reviewed by Dan Bernstein.
3652
3653         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
3654         (TestWebKitAPI::TEST):
3655         Use the correct bundle test name. Call Util::run.
3656
3657         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm:
3658         (-[BundleObject sayHello]):
3659         (-[BundleObject testMethodWithString:double:integer:]):
3660         Add BundleObject implementation. Register the bundle object with
3661         the remote object registry. Call _handleMessageWithName:body: on the incoming message.
3662
3663 2013-11-04  Krzysztof Czech  <k.czech@samsung.com>
3664
3665         [EFL] Change ATK version to 2.10.0
3666         https://bugs.webkit.org/show_bug.cgi?id=123727
3667
3668         Reviewed by Mario Sanchez Prada.
3669
3670         Provided new API to retrieve text at a given offset.
3671
3672         * efl/jhbuild.modules:
3673
3674 2013-11-04  Robert Plociennik  <r.plociennik@samsung.com>
3675
3676         [EFL] accessibility/textarea-line-for-index.html is failing
3677         https://bugs.webkit.org/show_bug.cgi?id=112015
3678
3679         Reviewed by Mario Sanchez Prada.
3680
3681         Provided implementation for AccessibilityUIElement::lineForIndex().
3682
3683         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3684         (AccessibilityUIElement::lineForIndex): Implemented.
3685         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3686         (WTR::AccessibilityUIElement::lineForIndex): Implemented.
3687
3688 2013-11-04  Krzysztof Czech  <k.czech@samsung.com>
3689
3690         [EFL] accessibility/button-press-action.html
3691         https://bugs.webkit.org/show_bug.cgi?id=111993
3692
3693         Reviewed by Mario Sanchez Prada.
3694
3695         Provided an implementation for AccessibilityUIElement::isPressActionSupported.
3696
3697         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3698         (AccessibilityUIElement::isPressActionSupported):
3699         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3700         (WTR::AccessibilityUIElement::isPressActionSupported):
3701
3702 2013-11-03  Patrick Gansterer  <paroga@webkit.org>
3703
3704         Add test for ListHashSet::removeLast()
3705         https://bugs.webkit.org/show_bug.cgi?id=121810
3706
3707         Reviewed by Anders Carlsson.
3708
3709         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
3710         (TestWebKitAPI::TEST):
3711
3712 2013-11-02  Filip Pizlo  <fpizlo@apple.com>
3713
3714         LLVM assertion failures should funnel into WTF's crash handling
3715         https://bugs.webkit.org/show_bug.cgi?id=123682
3716
3717         Reviewed by Geoffrey Garen.
3718         
3719         Need to disable LLVM's crash overrides so that we can do our own crash overrides.
3720
3721         * Scripts/configure-llvm:
3722
3723 2013-11-01  Andy Estes  <aestes@apple.com>
3724
3725         Teach check-for-webkit-framework-include-consistency to ignore stale iOS Private headers that might exist in build directories due to r158443
3726         https://bugs.webkit.org/show_bug.cgi?id=123636
3727
3728         Reviewed by Andreas Kling.
3729
3730         * Scripts/check-for-webkit-framework-include-consistency:
3731
3732 2013-11-01  Anders Carlsson  <andersca@apple.com>
3733
3734         Begin work on encoding argument types
3735         https://bugs.webkit.org/show_bug.cgi?id=123631
3736
3737         Reviewed by Dan Bernstein.
3738
3739         Add another test method.
3740
3741         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
3742         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Shared.h:
3743
3744 2013-11-01  Afonso R. Costa Jr.  <afonso.costa@samsung.com>
3745
3746         Expose setApplicationCacheOriginQuota via window.internals
3747         https://bugs.webkit.org/show_bug.cgi?id=87838
3748
3749         Reviewed by Joseph Pecoraro.
3750
3751         * DumpRenderTree/TestRunner.cpp: Move setApplicationCacheOriginQuota
3752         to window.internals
3753         (TestRunner::staticFunctions):
3754         * DumpRenderTree/TestRunner.h: Ditto.
3755         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setApplicationCacheOriginQuota.
3756         * DumpRenderTree/efl/TestRunnerEfl.cpp: Ditto.
3757         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Ditto.
3758         * DumpRenderTree/mac/TestRunnerMac.mm: Ditto.
3759         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
3760         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Ditto.
3761         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Ditto.
3762         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
3763
3764 2013-10-31  Mark Lam  <mark.lam@apple.com>
3765
3766         REGRESSION: Crashes in -[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:].
3767         https://bugs.webkit.org/show_bug.cgi?id=123383.
3768
3769         Reviewed by Geoffrey Garen.
3770
3771         Removed an inappropriate assertion in DumpRenderTree/mac/UIDelegate.mm and
3772         added 2 attributes (databaseDefaultQuota and databaseMaxQuota) to allow
3773         tests to set appropriate quota settings to exercise quota expansion tests
3774         when needed.
3775
3776         * DumpRenderTree/TestRunner.cpp:
3777         (TestRunner::TestRunner):
3778         (getDatabaseDefaultQuotaCallback):
3779         (getDatabaseMaxQuotaCallback):
3780         (setDatabaseDefaultQuotaCallback):
3781         (setDatabaseMaxQuotaCallback):
3782         (TestRunner::staticValues):
3783         * DumpRenderTree/TestRunner.h:
3784         (TestRunner::databaseDefaultQuota):
3785         (TestRunner::setDatabaseDefaultQuota):
3786         (TestRunner::databaseMaxQuota):
3787         (TestRunner::setDatabaseMaxQuota):
3788         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3789         (BlackBerry::WebKit::DumpRenderTree::exceededDatabaseQuota):
3790         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
3791         (onExceededDatabaseQuota):
3792         * DumpRenderTree/mac/UIDelegate.mm:
3793         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]):
3794         * DumpRenderTree/win/UIDelegate.cpp:
3795         (UIDelegate::exceededDatabaseQuota):
3796         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3797         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3798         (WTR::InjectedBundlePage::didExceedDatabaseQuota):
3799         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3800         (WTR::TestRunner::TestRunner):
3801         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3802         (WTR::TestRunner::databaseDefaultQuota):
3803         (WTR::TestRunner::setDatabaseDefaultQuota):
3804         (WTR::TestRunner::databaseMaxQuota):
3805         (WTR::TestRunner::setDatabaseMaxQuota):
3806         * WebKitTestRunner/TestController.cpp:
3807         (WTR::TestController::createOtherPage):
3808         (WTR::TestController::createWebViewWithOptions):
3809
3810 2013-10-31  Anders Carlsson  <andersca@apple.com>
3811
3812         Add a WKRemoteObject class
3813         https://bugs.webkit.org/show_bug.cgi?id=123586
3814
3815         Reviewed by Dan Bernstein.
3816
3817         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
3818         (TestWebKitAPI::TEST):
3819         Add a conformsToProtocol: test.
3820
3821 2013-10-30  Ryosuke Niwa  <rniwa@webkit.org>
3822
3823         build.webkit.org should have a clean build button
3824         https://bugs.webkit.org/show_bug.cgi?id=123559
3825
3826         Reviewed by Darin Adler.
3827
3828         Add a new "clean" forced scheduler. When a build was created by this scheduler, CleanBuildIfScheduled
3829         step executes clean-build script that removes the WebKitBuild directory.
3830
3831         Also added make-passwords-json.py which creates a fake passwords.json from config.json for testing purposes.
3832
3833         * BuildSlaveSupport/build.webkit.org-config/make-passwords-json.py: Added.
3834         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3835         (CleanBuildIfScheduled): Added.
3836         (CleanBuildIfScheduled.start): Added. Don't do a clean build if if this build wasn't schecueld by
3837         the clean build scheduler.
3838         (DeleteStaleBuildFiles): Added.
3839         (DeleteStaleBuildFiles.start): Added. Don't delete stale build files if this build was scheduled by
3840         the clean build scheduler since everything in the WebKitBuild directory had already been removed.
3841         (Factory.__init__): Always add CleanBuildIfScheduled.  The step itself checks whether to run
3842         clean-build script or hide itself.
3843         (loadBuilderConfig): Added the new clean build scheduler. Also make ForceScheduler future proof; in newer
3844         versions of buildbot, builderNames needs to be a list of regular strings.
3845         * BuildSlaveSupport/clean-build: Added.
3846
3847 2013-10-31  Filip Pizlo  <fpizlo@apple.com>
3848
3849         Remove CachedTranscendentalFunction because caching math functions is an ugly idea
3850         https://bugs.webkit.org/show_bug.cgi?id=123574
3851
3852         Reviewed by Mark Hahnenberg.
3853
3854         Make it easier to see that a test doesn't have an -expected file.
3855
3856         * Scripts/run-jsc-stress-tests:
3857
3858 2013-10-31  Tamas Gergely  <gertom@inf.u-szeged.hu>
3859
3860         Run tests as if they are expected to pass when --force is given.
3861         https://bugs.webkit.org/show_bug.cgi?id=112890
3862
3863         Reviewed by Ryosuke Niwa.
3864
3865         The --force switch of new-run-webkit-tests is now forces all tests to
3866         be run with 'PASS' as expected result.
3867
3868         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3869         (Manager.run):
3870         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3871         (TestExpectations.__init__):
3872         (TestExpectations._add_expectations):
3873         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3874         (parse_args):
3875         (_set_up_derived_options):
3876
3877 2013-10-31  Geoffrey Garen  <ggaren@apple.com>
3878
3879         Added Mark Lam as a reviewer.
3880
3881         Unreviewed.
3882
3883         * Scripts/webkitpy/common/config/contributors.json:
3884
3885 2013-10-30  Alexey Proskuryakov  <ap@apple.com>
3886
3887         Teach the style checker about ENUM_CLASS
3888         https://bugs.webkit.org/show_bug.cgi?id=123528
3889
3890         Reviewed by Andy Estes.
3891
3892         * Scripts/webkitpy/style/checkers/cpp.py:
3893         (_EnumState.process_clean_line): Make content of an ENUM_CLASS declaration
3894         equivalent to enum content for checking.
3895         (check_braces): Allow semicolon at the end.
3896
3897         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3898         (NoNonVirtualDestructorsTest.test_enum_casing):
3899         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon):
3900         (WebKitStyleTest.test_braces):
3901         Test it.
3902
3903 2013-10-30  Ryosuke Niwa  <rniwa@webkit.org>
3904
3905         kill-old-processes should kill Web Socket script
3906         https://bugs.webkit.org/show_bug.cgi?id=123546
3907
3908         Reviewed by Benjamin Poulain.
3909
3910         * BuildSlaveSupport/kill-old-processes:
3911         (main):
3912
3913 2013-10-30  Alexey Proskuryakov  <ap@apple.com>
3914
3915         Set svn:ignore for .pyc files created for test-webkitpy.
3916
3917         * Scripts/webkitpy/layout_tests/reftests: Added property svn:ignore.
3918         * Scripts/webkitpy/performance_tests: Added property svn:ignore.
3919         * Scripts/webkitpy/to_be_moved: Added property svn:ignore.
3920         * Scripts/webkitpy/w3c: Added property svn:ignore.
3921
3922 2013-10-30  Alexey Proskuryakov  <ap@apple.com>
3923
3924         85 inspector tests asserting in DrawingAreaProxyImpl::updateAcceleratedCompositingMode()
3925         when there is a stale WebKitTestRunner preference
3926         https://bugs.webkit.org/show_bug.cgi?id=115115
3927
3928         Reviewed by Darin Adler.
3929
3930         Delete stale preferences on launch.
3931
3932         * WebKitTestRunner/TestController.h:
3933         * WebKitTestRunner/TestController.cpp:
3934         (WTR::TestController::initialize): Now that we don't have preferences stored from
3935         the previous run, we need th reinstate them before creating a WKView. Not all preferences
3936         can be applied to an existing view retroactively.
3937         (WTR::TestController::resetPreferencesToConsistentValues): Split out of resetStateToConsistentValues,
3938         because there is no injected bundle yet when calling this function from initialize().
3939
3940         * WebKitTestRunner/mac/main.mm: (setDefaultsToConsistentValuesForTesting): Delete
3941         the preferences.
3942
3943         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize):
3944         Added some FIXMEs.
3945
3946 2013-10-30  Anders Carlsson  <andersca@apple.com>
3947
3948         Try to fix the 32-bit build.
3949         
3950         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
3951         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm:
3952
3953 2013-10-30  Anders Carlsson  <andersca@apple.com>
3954
3955         Begin fleshing out an API test for WKRemoteObjectRegistry
3956         https://bugs.webkit.org/show_bug.cgi?id=123531
3957
3958         Reviewed by Andreas Kling.
3959
3960         Add a very simple test that doesn't really test anything for now.
3961
3962         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3963         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm: Added.
3964         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm: Added.
3965         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Shared.h: Added.
3966
3967 2013-10-30  Filip Pizlo  <fpizlo@apple.com>
3968
3969         Remove unnecessary touch
3970
3971         Rubber stamped by Mark Hahnenberg.
3972
3973         * Scripts/run-jsc-stress-tests:
3974
3975 2013-10-30  Samuel White  <samuel_white@apple.com>
3976
3977         AX: Add samuel_white@apple.com to accessibility watchlist cc rules
3978         https://bugs.webkit.org/show_bug.cgi?id=123515
3979
3980         Reviewed by Chris Fleizach.
3981
3982         Adding myself and jcraig@apple.com (per his request) to the accessibility watchlist. Also
3983         updating contributors.json with permission from bweinstein@apple.com to make this possible.
3984
3985         * Scripts/webkitpy/common/config/contributors.json:
3986         * Scripts/webkitpy/common/config/watchlist:
3987
3988 2013-10-30  Patrick Gansterer  <paroga@webkit.org>
3989
3990         [WIN] Add executable entry points to DRT and WinLauncher
3991         https://bugs.webkit.org/show_bug.cgi?id=121837
3992
3993         Reviewed by Brent Fulgham.
3994
3995         This allows to compile and run the executables without DLLLauncher.
3996
3997         * DumpRenderTree/win/DumpRenderTree.cpp:
3998         (main):
3999         (dllLauncherEntryPoint):
4000         * WinLauncher/WinLauncher.cpp:
4001         (wWinMain):
4002         (dllLauncherEntryPoint):
4003
4004 2013-10-30  Filip Pizlo  <fpizlo@apple.com>
4005
4006         run-jsc-stress-tests should handle ".." in paths and "slow!" in cmd's
4007         https://bugs.webkit.org/show_bug.cgi?id=123521
4008
4009         Reviewed by Mark Hahnenberg.
4010
4011         * Scripts/run-jsc-stress-tests:
4012
4013 2013-10-30  Alexey Proskuryakov  <ap@apple.com>
4014
4015         Mavericks: 128 tests are failing due to pixel differences
4016         https://bugs.webkit.org/show_bug.cgi?id=123488
4017
4018         Reviewed by Simon Fraser.
4019
4020         Apple font preferences cannot be fully reset after they've been read, so we
4021         need to set them using CFPreferences before initializing NSApplication.
4022
4023         In theory, this should be an issue on WebKit2 as well, but somehow it doesn't
4024         appear to be. I guess we can figure out the reasons for this difference when/if
4025         any observable problems start to occur.
4026
4027         * DumpRenderTree/mac/DumpRenderTree.mm:
4028         (setDefaultsToConsistentValuesForTesting): Only set defaults here, move other work
4029         to prepareConsistentTestingEnvironment().
4030         (main): Call setDefaultsToConsistentValuesForTesting before [NSApplication sharedApplication]
4031         (which is unnecessary anyway since NSUserDefaults will implicitly call it, but seems
4032         useful to keep in case we change out approach to defaults again).
4033
4034 2013-10-29  Andy Estes  <aestes@apple.com>
4035
4036         Teach the style checker how to handle Objective-C categories and NS_ENUM
4037         https://bugs.webkit.org/show_bug.cgi?id=123482
4038
4039         Reviewed by Dan Bernstein.
4040
4041         * Scripts/webkitpy/style/checkers/cpp.py:
4042         (check_spacing_for_function_call): Allow a space before '(' in a line
4043         starting with @interface or @implementation, since this is defining an
4044         Objective-C category rather than a function.
4045         (check_braces): The opening brace of an NS_ENUM should not be on its
4046         own line.
4047         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added unit tests.
4048
4049 2013-10-30  Robert Plociennik  <r.plociennik@samsung.com>
4050
4051         [EFL] accessibility/textarea-selected-text-range.html is failing
4052         https://bugs.webkit.org/show_bug.cgi?id=112016
4053
4054         Reviewed by Mario Sanchez Prada.
4055
4056         Provided implementation for AccessibilityUIElement::selectedTextRange() and
4057         AccessibilityUIElement::setSelectedTextRange().
4058
4059         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
4060         (AccessibilityUIElement::selectedTextRange): Implemented.
4061         (AccessibilityUIElement::setSelectedTextRange): Implemented
4062         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4063         (WTR::AccessibilityUIElement::selectedTextRange): Implemented.
4064         (WTR::AccessibilityUIElement::setSelectedTextRange): Implemented.
4065
4066 2013-10-30  Robert Plociennik  <r.plociennik@samsung.com>
4067
4068         [GTK] accessibility/svg-remote-element.html is failing
4069         https://bugs.webkit.org/show_bug.cgi?id=101185
4070
4071         Reviewed by Chris Fleizach.
4072
4073         Implemented missing methods by mimicing existing functionality in
4074         AccessibilityObject::clickPoint() using available ATK API.
4075
4076         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
4077         (AccessibilityUIElement::clickPointX): Implemented.
4078         (AccessibilityUIElement::clickPointY): Implemented.
4079         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4080         (WTR::AccessibilityUIElement::clickPointX): Implemented.
4081         (WTR::AccessibilityUIElement::clickPointY): Implemented.
4082
4083 2013-10-30  Tamas Gergely  <gertom@inf.u-szeged.hu>
4084
4085         Removed Windows platform configurations from WebKitTestRunner.
4086         https://bugs.webkit.org/show_bug.cgi?id=123152
4087
4088         Reviewed by Csaba Osztrogonác.
4089
4090         Removed Windows specific parts from the source files, Windows specific
4091         subdirectory (win) and Visual Studio property files from the WebKitTestRunner,
4092         as the platform is no longer supported by this tool.
4093
4094         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Removed.
4095         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Removed.
4096         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops: Removed.
4097         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Removed.
4098         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Removed.
4099         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Removed.
4100         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Removed.
4101         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
4102         (WTR::AccessibilityController::rootElement):
4103         (WTR::AccessibilityController::focusedElement):
4104         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
4105         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
4106         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
4107         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4108         * WebKitTestRunner/PlatformWebView.h:
4109         * WebKitTestRunner/TestController.cpp:
4110         (WTR::TestController::initialize):
4111         * WebKitTestRunner/TestInvocation.cpp:
4112         (WTR::createWKURL):
4113         * WebKitTestRunner/cg/TestInvocationCG.cpp:
4114         * WebKitTestRunner/config.h:
4115         * WebKitTestRunner/win/InjectedBundle.vcproj: Removed.
4116         * WebKitTestRunner/win/InjectedBundleDebug.vsprops: Removed.
4117         * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops: Removed.
4118         * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops: Removed.
4119         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Removed.
4120         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Removed.
4121         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd: Removed.
4122         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd: Removed.
4123         * WebKitTestRunner/win/InjectedBundleProduction.vsprops: Removed.
4124         * WebKitTestRunner/win/InjectedBundleRelease.vsprops: Removed.
4125         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops: Removed.
4126         * WebKitTestRunner/win/PlatformWebViewWin.cpp: Removed.
4127         * WebKitTestRunner/win/TestControllerWin.cpp: Removed.
4128         * WebKitTestRunner/win/TestInvocationWin.cpp: Removed.
4129         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Removed.
4130         * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops: Removed.
4131         * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops: Removed.
4132         * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops: Removed.
4133         * WebKitTestRunner/win/WebKitTestRunnerLauncher.vcproj: Removed.
4134         * WebKitTestRunner/win/WebKitTestRunnerLauncherCommon.vsprops: Removed.
4135         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebug.vsprops: Removed.
4136         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugAll.vsprops: Removed.
4137         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops: Removed.
4138         * WebKitTestRunner/win/WebKitTestRunnerLauncherProduction.vsprops: Removed.
4139         * WebKitTestRunner/win/WebKitTestRunnerLauncherRelease.vsprops: Removed.
4140         * WebKitTestRunner/win/WebKitTestRunnerLauncherReleaseCairoCFLite.vsprops: Removed.
4141         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd: Removed.
4142         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd: Removed.
4143         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops: Removed.
4144         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops: Removed.
4145         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops: Removed.
4146         * WebKitTestRunner/win/build-generated-files.sh: Removed.
4147         * WebKitTestRunner/win/main.cpp: Removed.
4148
4149 2013-10-29  Alexey Proskuryakov  <ap@apple.com>
4150
4151         Result of focus-option-control-on-page.html depends on system preferences
4152         https://bugs.webkit.org/show_bug.cgi?id=123304
4153
4154         Reviewed by Simon Fraser.
4155
4156         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
4157         Override a preference that WebKit reads to decide what Tab does, so that current
4158         user default doesn't affect tests.
4159
4160         * WebKitTestRunner/mac/main.mm: (setDefaultsToConsistentValuesForTesting):
4161         Ditto.
4162
4163 2013-10-29  Filip Pizlo  <fpizlo@apple.com>
4164
4165         It should be possible to specify extra tests to run-javascriptcore-tests
4166         https://bugs.webkit.org/show_bug.cgi?id=123495
4167
4168         Reviewed by Oliver Hunt.
4169         
4170         This adds two ways to specify additional tests: the option --extra-tests=<blah>, and
4171         the environment variable EXTRA_JSC_TESTS.
4172         
4173         Those two values (the command-line option and the environment variable) are passed
4174         as extra arguments to run-jsc-stress-tests.
4175         
4176         To make this extra super useful, run-jsc-stress-tests now allows yaml configuration
4177         files to be recursive: if a "- collection:" line is found, the string is handled
4178         just as if it was a command-line argument. This allows you to use --extra-tests=file
4179         where file contains a bunch of "- collection:" lines, and this is equivalent to each
4180         of those lines being a command-line argument.
4181
4182         * Scripts/run-javascriptcore-tests:
4183         * Scripts/run-jsc-stress-tests:
4184
4185 2013-10-29  Ryosuke Niwa  <rniwa@webkit.org>
4186
4187         Add Mavericks builders to the old flakiness dashboard.
4188
4189         * TestResultServer/static-dashboards/builders.jsonp:
4190         * TestResultServer/static-dashboards/flakiness_dashboard.js:
4191
4192 2013-10-29  Seokju Kwon  <seokju@webkit.org>
4193
4194         Fix memory leak in Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp
4195         https://bugs.webkit.org/show_bug.cgi?id=123478
4196
4197         Reviewed by Anders Carlsson.
4198
4199         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
4200         (NPP_Destroy): Add a missing free() for 'obj->evaluateScriptOnMouseDownOrKeyDown'.
4201
4202 2013-10-29  Lucas Forschler  <lforschler@apple.com>
4203
4204         Move the SEO bots from testers to archivers.
4205         
4206         Unreviewed.
4207         
4208         * BuildSlaveSupport/build.webkit.org-config/config.json:
4209
4210 2013-10-29  Hugo Parente Lima  <hugo.lima@openbossa.org>
4211
4212         Adding Nix files in Source/Platform to trunk
4213         https://bugs.webkit.org/show_bug.cgi?id=118331
4214
4215         Reviewed by Benjamin Poulain.
4216
4217         Add a special rule for Nix API files located at Source/Platform/nix.
4218
4219         * Scripts/webkitpy/style/checker.py:
4220
4221  2013-10-29  Nadav Rotem  <nrotem@apple.com>
4222  
4223          Add myself as a comitter.
4224          https://bugs.webkit.org/show_bug.cgi?id=123455
4225  
4226          Reviewed by Anders Carlsson.
4227  
4228          * Scripts/webkitpy/common/config/contributors.json:
4229  
4230 2013-10-29  Lucas Forschler  <lforschler@apple.com>
4231
4232         Teach the WebKit2 testers to abort early by setting the shouldAbortEarly property to True.
4233         https://bugs.webkit.org/show_bug.cgi?id=123450
4234
4235         Reviewed by Alexey Proskuryakov.
4236
4237         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4238         (RunWebKit2Tests.start):
4239
4240 2013-10-29  Alexey Proskuryakov  <ap@apple.com>
4241
4242         [Mac] Rationalize user defaults override code
4243         https://bugs.webkit.org/show_bug.cgi?id=123436
4244
4245         Reviewed by Dan Bernstein.
4246
4247         * DumpRenderTree/mac/DumpRenderTree.mm:
4248         (resetWebPreferencesToConsistentValues): Renamed from resetDefaultsToConsistentValues,
4249         because this function only resets WebPreferences now.
4250         (setDefaultsToConsistentValuesForTesting): Moved code for setting the defaults
4251         here, because tests never change them, and they only need to be set once, not
4252         before each test. Removed long obsolete workaround for HIToolbox preferences.
4253         Don't call resetWebPreferencesToConsistentValues, because it will be called before
4254         the first test anyway.
4255         (main): Don't set AppleMagnifiedMode here, moved that to setDefaultsToConsistentValuesForTesting.
4256         (resetWebViewToConsistentStateBeforeTesting): Moved TestRunner::setSerializeHTTPLoads
4257         and setlocale calls out of resetWebPreferencesToConsistentValues().
4258         Added AppleAquaAntiAliasingChanged notification that we had in WK2, because it's
4259         also needed in WK1.
4260
4261         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
4262         (WTR::InjectedBundle::platformInitialize): Use literal syntax for defaults
4263         dictionary.
4264
4265         * WebKitTestRunner/mac/main.mm:
4266         (setDefaultsToConsistentValuesForTesting): Factored out of main(), and changed to
4267         use NSArgumentDomain for everything.
4268
4269 2013-10-29  Philippe Normand  <pnormand@igalia.com>
4270
4271         [GTK] enable media-stream in build-webkit
4272         https://bugs.webkit.org/show_bug.cgi?id=123144
4273
4274         Reviewed by Martin Robinson.
4275
4276         * Scripts/webkitperl/FeatureList.pm: Enable media-stream build
4277         for the GTK+ port.
4278
4279 2013-10-29  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
4280
4281         EFL 32 bit buildbot doesn't work on dashboard
4282         https://bugs.webkit.org/show_bug.cgi?id=123435
4283
4284         Reviewed by Csaba Osztrogonác.
4285