cfb454404c2da3ef1f192475ae51d8c252001755
[WebKit-https.git] / Tools / ChangeLog
1 2012-11-06  Oliver Hunt  <oliver@apple.com>
2
3         Don't warn about RefPtr* parameters
4         https://bugs.webkit.org/show_bug.cgi?id=101403
5
6         Reviewed by Gavin Barraclough.
7
8         RefPtr<>* is a valid parameter type.
9
10         * Scripts/webkitpy/style/checkers/cpp.py:
11         (check_function_definition_and_pass_ptr):
12         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
13         (PassPtrTest.test_ref_ptr_parameter_value):
14
15 2012-11-06  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
16
17         [WTR] Reset EventSender before running each test.
18         https://bugs.webkit.org/show_bug.cgi?id=101353
19
20         Reviewed by Simon Fraser.
21
22         Contrary to what was done to at least some ports in DumpRenderTree,
23         EventSender did not currently reset its values in WTR. This caused
24         flakiness if a test such as editing/selection/fake-doubleclick.html was
25         run twice in a row, since the click count was not reset across each
26         run.
27
28         * WebKitTestRunner/TestController.cpp:
29         (WTR::TestController::TestController): Do not create m_eventSenderProxy
30         in the constructor anymore, it is created in
31         resetStateToConsistentValues now.
32         (WTR::TestController::resetStateToConsistentValues): Recreate
33         m_eventSenderProxy every time this method is run.
34         * WebKitTestRunner/TestController.h: Make m_eventSenderProxy an OwnPtr
35         and guard it with a platform #ifdef.
36         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
37         (WTR::EventSenderProxy::~EventSenderProxy): Add an empty
38         implementation.
39         * WebKitTestRunner/mac/EventSenderProxy.mm:
40         (WTR::EventSenderProxy::~EventSenderProxy): Ditto.
41         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
42         (WTR::EventSenderProxy::~EventSenderProxy): Ditto.
43
44 2012-11-06  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
45
46         [EFL][WK2] Refactor Ewk_Auth_Request, Ewk_Url_Scheme_Request and Ewk_Download_Job to be Ewk_Objects
47         https://bugs.webkit.org/show_bug.cgi?id=101383
48
49         Reviewed by Kenneth Rohde Christiansen.
50
51         Ewk_Auth_Request, Ewk_Url_Scheme_Request and Ewk_Download_Job are Ewk_Objects now.
52
53         * MiniBrowser/efl/main.c:
54         (auth_popup_close):
55         (on_authentication_request):
56
57 2012-11-06  Tommy Widenflycht  <tommyw@google.com>
58
59         [chromium] MediaStream API: Remove the valgrind issue with MockWebRTCPeerConnectionHandler
60         https://bugs.webkit.org/show_bug.cgi?id=101336
61
62         Reviewed by Andreas Kling.
63
64         This patch changes the delete to delete [] to match the new[].
65
66         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
67
68 2012-11-06  Mihai Balan  <mibalan@adobe.com>
69
70         Add Adobe's bug tracker to committers.py
71         https://bugs.webkit.org/show_bug.cgi?id=101338
72
73         Reviewed by Kentaro Hara.
74
75         Adding Adobe's bug tracker mailing list to committers.py
76         to enable its inclusion in the autocomplete list.
77
78         * Scripts/webkitpy/common/config/committers.py:
79
80 2012-11-06  Sami Kyostila  <skyostil@chromium.org>
81
82         [chromium] Enable fixed position compositing on Android DRT
83         https://bugs.webkit.org/show_bug.cgi?id=100263
84
85         Reviewed by James Robinson.
86
87         Chrome on Android forces composited mode for every page and creates
88         stacking contexts and graphics layers for fixed positioned elements.
89         Change the DumpRenderTree settings to match this.
90
91         * DumpRenderTree/chromium/DumpRenderTree.cpp:
92         (main):
93         * DumpRenderTree/chromium/TestShell.cpp:
94         (TestShell::TestShell):
95         (TestShell::resetWebSettings):
96         * DumpRenderTree/chromium/TestShell.h:
97         (TestShell::setAcceleratedCompositingForFixedPositionEnabled):
98         (TestShell):
99         * DumpRenderTree/chromium/WebPreferences.cpp:
100         (WebPreferences::reset):
101         (WebPreferences::applyTo):
102         * DumpRenderTree/chromium/WebPreferences.h:
103         (WebPreferences):
104         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
105         (ChromiumAndroidPort.additional_drt_flag):
106
107 2012-11-06  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
108
109         [EFL][WTR] EventSender: Get rid of the WTRMouseButton enum.
110         https://bugs.webkit.org/show_bug.cgi?id=101340
111
112         Reviewed by Kenneth Rohde Christiansen.
113
114         Get rid of an enum which was basically a duplicate of the
115         WKEventMouseButton one in the shared API.
116
117         The only difference is that it also had a case for a 4th mouse
118         button that we treat in a special way in evasMouseButton() now.
119
120         * WebKitTestRunner/EventSenderProxy.h:
121         (EventSenderProxy):
122         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
123         (WTR::evasMouseButton):
124         (WTR::EventSenderProxy::EventSenderProxy):
125         (WTR::EventSenderProxy::mouseUp):
126         (WTR::EventSenderProxy::mouseMoveTo):
127         (WTR::EventSenderProxy::mouseScrollBy):
128         (WTR::EventSenderProxy::leapForward):
129
130 2012-11-06  Jussi Kukkonen  <jussi.kukkonen@intel.com>
131
132         [EFL][WK2] Minibrowser forgets http variables when url includes ampersand
133         https://bugs.webkit.org/show_bug.cgi?id=101061
134
135         Reviewed by Kenneth Rohde Christiansen.
136
137         Elementary entry only returns 'markup' text, meaning ampersands
138         in a url will become "&amp;". Use elm_entry_markup_to_utf8() and
139         elm_entry_utf8_to_markup() when interacting with the entry.
140
141         * MiniBrowser/efl/main.c:
142         (on_url_changed):
143         (on_url_bar_activated):
144
145 2012-11-06  Balazs Kelemen  <kbalazs@webkit.org>
146
147         DumpRenderTree should have --pixel-tests option again
148         https://bugs.webkit.org/show_bug.cgi?id=98648
149
150         Reviewed by Dirk Pranke.
151
152         Add back the --pixel-tests command line option to DumpRenderTree.
153         It was removed r124581 because tools don't use it after that patch.
154         However, it turned out that it is useful for debugging and working
155         with pixel tests.
156
157         * DumpRenderTree/efl/DumpRenderTree.cpp:
158         (parseCommandLineOptions):
159         (runTest):
160         * DumpRenderTree/gtk/DumpRenderTree.cpp:
161         (initializeGlobalsFromCommandLineOptions):
162         (runTest):
163         * DumpRenderTree/mac/DumpRenderTree.mm:
164         (initializeGlobalsFromCommandLineOptions):
165         (runTest):
166         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
167         (isOption):
168         (printUsage):
169         (main):
170         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
171         (WebCore::DumpRenderTree::processLine):
172         * DumpRenderTree/qt/DumpRenderTreeQt.h:
173         (WebCore::DumpRenderTree::setShouldDumpPixelsForAllTests):
174         (DumpRenderTree):
175         * DumpRenderTree/win/DumpRenderTree.cpp:
176         (runTest):
177         (dllLauncherEntryPoint):
178         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
179         (runTest):
180         (MyApp::OnInit):
181         * WebKitTestRunner/TestController.cpp:
182         (WTR::TestController::TestController):
183         (WTR::TestController::initialize):
184         (WTR::TestController::runTest):
185         * WebKitTestRunner/TestController.h:
186         (TestController):
187
188 2012-11-05  Dirk Pranke  <dpranke@chromium.org>
189
190         webkit-patch rebaseline*: fix typo for --results-directory
191         https://bugs.webkit.org/show_bug.cgi?id=101295
192
193         Reviewed by Ojan Vafai.
194
195         Had --results_directory instead of --results-directory in both the
196         code and the unit test.
197
198         * Scripts/webkitpy/tool/commands/rebaseline.py:
199         (AbstractParallelRebaselineCommand._rebaseline_commands):
200         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
201         (TestRebaselineJson.test_results_directory):
202
203 2012-11-05  Dirk Pranke  <dpranke@chromium.org>
204
205         webkit-patch rebaseline*: fix handling of local file urls
206         https://bugs.webkit.org/show_bug.cgi?id=101296
207
208         Reviewed by Ojan Vafai.
209
210         When using --results-directory, we need to make sure we're converting
211         paths to file:/// urls for urllib to work correctly. Also, this
212         patch reworks the unit tests to get better coverage (of the execute()
213         command) and reduce copy/pasting of mock options.
214
215         * Scripts/webkitpy/tool/commands/rebaseline.py:
216         (RebaselineTest._rebaseline_test_and_update_expectations):
217         (RebaselineTest.execute):
218         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
219         (TestRebaselineTest.setUp):
220         (test_rebaseline_updates_expectations_file):
221         (test_rebaseline_does_not_include_overrides):
222         (test_rebaseline_test_with_results_directory):
223         (test_rebaseline_test_internal_with_move_overwritten_baselines_to):
224
225 2012-11-05  Kenneth Russell  <kbr@google.com>
226
227         Added secondary email address and IRC nick.
228         https://bugs.webkit.org/show_bug.cgi?id=101290
229
230         Unreviewed change to committers.py.
231
232         * Scripts/webkitpy/common/config/committers.py:
233
234 2012-11-05  Glenn Adams  <glenn@skynav.com>
235
236         Add IRC alias for Glenn Adams
237         https://bugs.webkit.org/show_bug.cgi?id=101262
238
239         Reviewed by Eric Seidel.
240
241         Add IRC alias for Glenn Adams.
242
243         * Scripts/webkitpy/common/config/committers.py:
244
245 2012-11-05  Dima Gorbik  <dgorbik@apple.com>
246
247         Back out controversial changes from Bug 98665.
248         https://bugs.webkit.org/show_bug.cgi?id=101244
249
250         Reviewed by David Kilzer.
251
252         Backing out changes from Bug 98665 until further discussions take place on rules for including Platform.h in Assertions.h.
253
254         * DumpRenderTree/mac/MockGeolocationProvider.mm:
255
256 2012-11-05  Dirk Pranke  <dpranke@chromium.org>
257
258         webkitpy: lint, clean up rebaseline.py
259         https://bugs.webkit.org/show_bug.cgi?id=101240
260
261         Reviewed by Ojan Vafai.
262
263         Miscellaneous cleanup of lint errors and warnings.
264
265         * Scripts/webkitpy/tool/commands/rebaseline.py:
266         (AbstractRebaseliningCommand):
267         (RebaselineTest._test_root):
268         (OptimizeBaselines._optimize_baseline):
269         (OptimizeBaselines.execute):
270         (AnalyzeBaselines.__init__):
271         (AbstractParallelRebaselineCommand):
272         (AbstractParallelRebaselineCommand._builders_to_fetch_from):
273         (AbstractParallelRebaselineCommand._files_to_add):
274         (AbstractParallelRebaselineCommand._rebaseline):
275         (RebaselineExpectations.__init__):
276         (Rebaseline.execute):
277         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
278         (_BaseTestCase.setUp):
279         (TestAnalyzeBaselines.setUp):
280
281 2012-11-05  Dirk Pranke  <dpranke@chromium.org>
282
283         webkit-patch optimize-baselines should take a --platform arg
284         https://bugs.webkit.org/show_bug.cgi?id=97623
285
286         Reviewed by Ojan Vafai.
287
288         So that we can optionally limit/control which platforms' results
289         are affected.
290
291         This patch adds --platform to analyze-baselines as well.
292
293         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
294         (_baseline_search_hypergraph):
295         (BaselineOptimizer.__init__):
296         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
297         (TestBaselineOptimizer.__init__):
298         (BaselineOptimizerTest.test_move_baselines):
299         * Scripts/webkitpy/tool/commands/rebaseline.py:
300         (OptimizeBaselines.__init__):
301         (OptimizeBaselines.execute):
302         (AnalyzeBaselines.__init__):
303         (AnalyzeBaselines.execute):
304         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
305         (TestAnalyzeBaselines.test_default):
306         (TestAnalyzeBaselines.test_missing_baselines):
307
308 2012-11-05  Dirk Pranke  <dpranke@chromium.org>
309
310         webkit-patch rebaseline-expectations should take a --platform arg
311         https://bugs.webkit.org/show_bug.cgi?id=97621
312
313         Reviewed by Ojan Vafai.
314
315         So that we can limit which platforms we attempt to rebaseline;
316         this can reduce the noise the command produces if some ports
317         have errors or warnings in their TestExpectations files and/or
318         help produce more predictable results.
319
320         In testing this patch, I realized that the rebaseline-in-parallel
321         commands (rebaseline-json, rebaseline-expectations, etc.) can
322         cause multiple rebaseline-test-internal commands to attempt to
323         modify the TestExpectations files concurrently, and that we needed
324         to lock the files to prevent corruption; it would be nice if
325         we can split the updating-the-expectations-files out separately
326         from updating the filesystem (much like we do with the scm updates)
327         to avoid this concurrency.
328
329         * Scripts/webkitpy/common/system/file_lock_mock.py: Added.
330         (MockFileLock):
331         (MockFileLock.__init__):
332         (MockFileLock.acquire_lock):
333         (MockFileLock.release_lock):
334         * Scripts/webkitpy/common/system/systemhost.py:
335         (SystemHost.copy_current_environment):
336         (SystemHost):
337         (SystemHost.make_file_lock):
338         * Scripts/webkitpy/common/system/systemhost_mock.py:
339         (MockSystemHost.copy_current_environment):
340         (MockSystemHost):
341         (MockSystemHost.make_file_lock):
342         * Scripts/webkitpy/tool/commands/rebaseline.py:
343         (RebaselineTest._update_expectations_file):
344         (RebaselineExpectations.__init__):
345         (RebaselineExpectations._add_tests_to_rebaseline_for_port):
346         (RebaselineExpectations.execute):
347
348 2012-11-05  Dirk Pranke  <dpranke@chromium.org>
349
350         webkitpy: clean up options for specifying multiple platforms at once
351         https://bugs.webkit.org/show_bug.cgi?id=101140
352
353         Reviewed by Ojan Vafai.
354
355         This patch reworks how we display the help strings for --platform
356         options and how we filter out platforms matching a glob. This will
357         be useful as I add patches to ensure that all the webkit-patch
358         commands are using --platform consistently to filter ports.
359
360         There should be no functional changes resulting from this patch.
361
362         * Scripts/webkitpy/layout_tests/port/factory.py:
363         (platform_options):
364         (PortFactory.all_port_names):
365         (PortFactory.get_from_builder_name):
366         * Scripts/webkitpy/tool/commands/queries.py:
367         (PrintExpectations.__init__):
368         (PrintBaselines.__init__):
369         * Scripts/webkitpy/tool/commands/rebaseline.py:
370         (AbstractRebaseliningCommand):
371         (RebaselineJson.__init__):
372         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
373         (TestRebaselineExpectations.setUp):
374         (TestRebaselineExpectations.test_rebaseline_expectations):
375
376 2012-11-05  Peter Beverloo  <peter@chromium.org>
377
378         The layout test runner shouldn't wait for data if stdout/stderr have been closed
379         https://bugs.webkit.org/show_bug.cgi?id=101233
380
381         Reviewed by Dirk Pranke.
382
383         Trying to read the file descriptor for the stdout or stderr pipes when DumpRenderTree
384         has crashed during a Chromium Android layout test-run, which uses FIFOs for
385         communication, causes the File.fileno() method to raise a ValueError. Return early
386         if either of the pipes has already been closed.
387
388         * Scripts/webkitpy/layout_tests/port/server_process.py:
389         (ServerProcess._wait_for_data_and_update_buffers_using_select):
390
391 2012-11-05  Dirk Pranke  <dpranke@chromium.org>
392
393         webkit-patch rebaseline is broken
394         https://bugs.webkit.org/show_bug.cgi?id=101235
395
396         Reviewed by Ojan Vafai.
397
398         It didn't get updated to handle the change in parsing --suffixes
399         properly, and the unit test didn't get updated either, masking the
400         problem.
401
402         * Scripts/webkitpy/tool/commands/rebaseline.py:
403         (Rebaseline._tests_to_update):
404         (Rebaseline.execute):
405         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
406         (TestRebaseline.test_rebaseline):
407
408 2012-11-05  Dirk Pranke  <dpranke@chromium.org>
409
410         lint-webkitpy doesn't autoinstall pylint properly.
411         https://bugs.webkit.org/show_bug.cgi?id=101106
412
413         Reviewed by Ojan Vafai.
414
415         Re-land r133381 with fix; ironically, lint-webkitpy would've
416         complained about the problem. Also modify pylintrc and clean up
417         any other lint errors in the modified files.
418
419         * Scripts/webkitpy/common/system/autoinstall.py:
420         (AutoInstaller._set_up_target_dir):
421         (AutoInstaller):
422         (AutoInstaller._make_package):
423         (AutoInstaller._create_scratch_directory):
424         (AutoInstaller._install):
425         (AutoInstaller.install):
426         * Scripts/webkitpy/pylintrc:
427         * Scripts/webkitpy/thirdparty/__init__.py:
428         (AutoinstallImportHook._ensure_autoinstalled_dir_is_in_sys_path):
429         (AutoinstallImportHook):
430         (AutoinstallImportHook.find_module):
431         (AutoinstallImportHook._install_pylint):
432         (AutoinstallImportHook._install_coverage):
433         (AutoinstallImportHook._install_eliza):
434         (AutoinstallImportHook._install_webpagereplay):
435         (AutoinstallImportHook._install):
436         * Scripts/webkitpy/thirdparty/__init___unittest.py:
437         (ThirdpartyTest.test_import_hook.MockImportHook.__init__):
438         (ThirdpartyTest.test_import_hook):
439         (ThirdpartyTest.test_imports):
440
441 2012-11-05  KyungTae Kim  <ktf.kim@samsung.com>
442
443         [EFL] Fix build warning in EWebLauncher/main.c
444         https://bugs.webkit.org/show_bug.cgi?id=101197
445
446         Reviewed by Kentaro Hara.
447
448         Because the strp of _Ecore_Getopt_Value is char** (Ecore_Getopt.h),
449         The parameter of ECORE_GETOPT_VALUE_STR should be char*
450
451         * EWebLauncher/main.c:
452         (_User_Arguments):
453
454 2012-11-05  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
455
456         [EFL][WK2] Add --window-size command line option to EFL MiniBrowser
457         https://bugs.webkit.org/show_bug.cgi?id=100942
458
459         Reviewed by Kenneth Rohde Christiansen.
460
461         Added window-size (-s) command line option to EFL MiniBrowser.
462
463         * MiniBrowser/efl/main.c:
464         (window_create):
465         (parse_window_size):
466         (elm_main):
467
468 2012-11-05  Christophe Dumez  <christophe.dumez@intel.com>
469
470         [EFL][WK2] The icon database path should be set by the client
471         https://bugs.webkit.org/show_bug.cgi?id=101182
472
473         Reviewed by Kenneth Rohde Christiansen.
474
475         Enable favicon database functionality in MiniBrowser since
476         it is used and it is no longer enabled by default.
477
478         * MiniBrowser/efl/main.c:
479         (elm_main):
480
481 2012-11-03  Balazs Kelemen  <kbalazs@webkit.org>
482
483         [Qt][WK2] setPlatformStrategies always asserts after r132744
484         https://bugs.webkit.org/show_bug.cgi?id=100838
485
486         Reviewed by Simon Hausmann.
487
488         Reland with build fixes.
489
490         Turned test runners to use the new QtTestSupport.
491
492         * DumpRenderTree/qt/DumpRenderTree.pro:
493         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
494         (main):
495         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
496         (WebCore::DumpRenderTree::open):
497         * DumpRenderTree/qt/QtInitializeTestFonts.h: Removed.
498         * MiniBrowser/qt/MiniBrowser.pro:
499         * QtTestBrowser/QtTestBrowser.pro:
500         * QtTestBrowser/qttestbrowser.cpp:
501         (LauncherApplication::handleUserOptions):
502         * WebKitTestRunner/InjectedBundle/Target.pri:
503         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
504         (WTR::activateFonts):
505         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Removed.
506         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Removed.
507         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
508         (WTR::TestRunner::platformInitialize):  Removed the comment from here
509         because it was just lying, apparently two times. First, it is not incorrect
510         to reinitialize our font set and clear font caches, it is what the tests
511         expect. Second, the use of QRawFont has nothing to do with the font cache.
512         * WebKitTestRunner/Target.pri:
513         * WebKitTestRunner/qt/main.cpp:
514         (main):
515
516 2012-11-04  Sheriff Bot  <webkit.review.bot@gmail.com>
517
518         Unreviewed, rolling out r133381.
519         http://trac.webkit.org/changeset/133381
520         https://bugs.webkit.org/show_bug.cgi?id=101161
521
522         It made webkit-patch useless (Requested by Ossy_weekend on
523         #webkit).
524
525         * Scripts/webkitpy/common/system/autoinstall.py:
526         (AutoInstaller._create_scratch_directory):
527         (AutoInstaller._install):
528         (AutoInstaller.install):
529         * Scripts/webkitpy/thirdparty/__init__.py:
530         (AutoinstallImportHook.__init__):
531         (AutoinstallImportHook._install_pylint):
532         (AutoinstallImportHook._install_coverage):
533         (AutoinstallImportHook._install_eliza):
534         (AutoinstallImportHook._install):
535         * Scripts/webkitpy/thirdparty/__init___unittest.py:
536         (ThirdpartyTest.test_import_hook.MockImportHook.__init__):
537         (ThirdpartyTest.test_import_hook):
538
539 2012-11-03  Sheriff Bot  <webkit.review.bot@gmail.com>
540
541         Unreviewed, rolling out r133403, r133404, and r133409.
542         http://trac.webkit.org/changeset/133403
543         http://trac.webkit.org/changeset/133404
544         http://trac.webkit.org/changeset/133409
545         https://bugs.webkit.org/show_bug.cgi?id=101158
546
547         "Broke tests" (Requested by kbalazs on #webkit).
548
549         * DumpRenderTree/qt/DumpRenderTree.pro:
550         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
551         (main):
552         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
553         (WebCore::DumpRenderTree::open):
554         * DumpRenderTree/qt/QtInitializeTestFonts.cpp: Renamed from Source/WebCore/platform/qt/QtTestSupport.cpp.
555         (WebKit):
556         (WebKit::initializeTestFonts):
557         * DumpRenderTree/qt/QtInitializeTestFonts.h: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
558         (WebKit):
559         * MiniBrowser/qt/MiniBrowser.pro:
560         * MiniBrowser/qt/MiniBrowserApplication.cpp:
561         (MiniBrowserApplication::handleUserOptions):
562         * QtTestBrowser/QtTestBrowser.pro:
563         * QtTestBrowser/qttestbrowser.cpp:
564         (LauncherApplication::handleUserOptions):
565         * WebKitTestRunner/InjectedBundle/Target.pri:
566         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
567         (WTR::activateFonts):
568         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
569         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
570         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
571         (WTR::TestRunner::platformInitialize):
572         * WebKitTestRunner/Target.pri:
573         * WebKitTestRunner/qt/main.cpp:
574         (main):
575
576 2012-11-03  Balazs Kelemen  <kbalazs@webkit.org>
577
578         [Qt][WK2] setPlatformStrategies always asserts after r132744
579         https://bugs.webkit.org/show_bug.cgi?id=100838
580
581         2nd unreviewed buildfix.
582
583         * MiniBrowser/qt/MiniBrowserApplication.cpp:
584
585 2012-11-03  Balazs Kelemen  <kbalazs@webkit.org>
586
587         [Qt][WK2] setPlatformStrategies always asserts after r132744
588         https://bugs.webkit.org/show_bug.cgi?id=100838
589
590         Unreviewed buildfix.
591
592         * WebKitTestRunner/Target.pri:
593
594 2012-11-03  Balazs Kelemen  <kbalazs@webkit.org>
595
596         [Qt][WK2] setPlatformStrategies always asserts after r132744
597         https://bugs.webkit.org/show_bug.cgi?id=100838
598
599         Reviewed by Simon Hausmann.
600
601         Reland with build fix.
602
603         Turned test runners to use the new QtTestSupport.
604
605         * DumpRenderTree/qt/DumpRenderTree.pro:
606         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
607         (main):
608         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
609         (WebCore::DumpRenderTree::open):
610         * DumpRenderTree/qt/QtInitializeTestFonts.h: Removed.
611         * MiniBrowser/qt/MiniBrowser.pro:
612         * QtTestBrowser/QtTestBrowser.pro:
613         * QtTestBrowser/qttestbrowser.cpp:
614         (LauncherApplication::handleUserOptions):
615         * WebKitTestRunner/InjectedBundle/Target.pri:
616         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
617         (WTR::activateFonts):
618         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Removed.
619         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Removed.
620         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
621         (WTR::TestRunner::platformInitialize):  Removed the comment from here
622         because it was just lying, apparently two times. First, it is not incorrect
623         to reinitialize our font set and clear font caches, it is what the tests
624         expect. Second, the use of QRawFont has nothing to do with the font cache.
625         * WebKitTestRunner/Target.pri:
626         * WebKitTestRunner/qt/main.cpp:
627         (main):
628
629 2012-11-03  Sheriff Bot  <webkit.review.bot@gmail.com>
630
631         Unreviewed, rolling out r133397.
632         http://trac.webkit.org/changeset/133397
633         https://bugs.webkit.org/show_bug.cgi?id=101155
634
635         "Broke Qt. No way to force the damn bots to do a clean build.
636         I'm giving up." (Requested by kbalazs on #webkit).
637
638         * DumpRenderTree/qt/DumpRenderTree.pro:
639         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
640         (main):
641         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
642         (WebCore::DumpRenderTree::open):
643         * DumpRenderTree/qt/QtInitializeTestFonts.cpp: Renamed from Source/WebCore/platform/qt/QtTestSupport.cpp.
644         (WebKit):
645         (WebKit::initializeTestFonts):
646         * DumpRenderTree/qt/QtInitializeTestFonts.h: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
647         (WebKit):
648         * QtTestBrowser/QtTestBrowser.pro:
649         * QtTestBrowser/qttestbrowser.cpp:
650         (LauncherApplication::handleUserOptions):
651         * WebKitTestRunner/InjectedBundle/Target.pri:
652         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
653         (WTR::activateFonts):
654         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
655         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
656         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
657         (WTR::TestRunner::platformInitialize):
658         * WebKitTestRunner/Target.pri:
659         * WebKitTestRunner/qt/main.cpp:
660         (main):
661
662 2012-11-03  Balazs Kelemen  <kbalazs@webkit.org>
663
664         [Qt][WK2] setPlatformStrategies always asserts after r132744
665         https://bugs.webkit.org/show_bug.cgi?id=100838
666
667         Reviewed by Simon Hausmann.
668
669         Turned test runners to use the new QtTestSupport.
670
671         * DumpRenderTree/qt/DumpRenderTree.pro:
672         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
673         (main):
674         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
675         (WebCore::DumpRenderTree::open):
676         * QtTestBrowser/QtTestBrowser.pro:
677         * QtTestBrowser/qttestbrowser.cpp:
678         (LauncherApplication::handleUserOptions):
679         * WebKitTestRunner/InjectedBundle/Target.pri:
680         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
681         (WTR::activateFonts):
682         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Removed.
683         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Removed.
684         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
685         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
686         (WTR::TestRunner::platformInitialize): Removed the comment from here
687         because it was just lying, apparently two times. First, it is not incorrect
688         to reinitialize our font set and clear font caches, it is what the tests
689         expect. Second, the use of QRawFont has nothing to do with the font cache.
690         * WebKitTestRunner/Target.pri:
691         * WebKitTestRunner/qt/main.cpp:
692         (main):
693
694 2012-11-02  Dirk Pranke  <dpranke@chromium.org>
695
696         webkit-patch rebaseline is broken
697         https://bugs.webkit.org/show_bug.cgi?id=101081
698
699         Reviewed by Ojan Vafai.
700
701         I broke this in r133061 and the unit tests weren't covering this
702         code path. Fixed the issue and the tests. --results-directory
703         doesn't make sense for either 'webkit-patch rebaseline' or
704         'webkit-patch rebaseline-expectations', so we don't want to expose
705         that as a command line option, but they all call a common
706         _rebaseline() routine that references options.results_directory,
707         so we need to set a default value.
708
709         * Scripts/webkitpy/tool/commands/rebaseline.py:
710         (RebaselineExpectations.execute):
711         (Rebaseline.execute):
712         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
713         (TestRebaseline):
714         (TestRebaseline.test_rebaseline):
715
716 2012-11-02  Dirk Pranke  <dpranke@chromium.org>
717
718         lint-webkitpy doesn't autoinstall pylint properly
719         https://bugs.webkit.org/show_bug.cgi?id=101106
720
721         Reviewed by Ojan Vafai.
722
723         Turns out the autoinstalling code for pylint didn't install
724         pylint's dependencies, and the autoinstaller code didn't work
725         using nested directories (e.g., "logilab/astng"). Fix those issues,
726         clean up the autoinstaller code, and add tests to make sure everything
727         imports successfully.
728
729         * Scripts/webkitpy/common/system/autoinstall.py:
730         (AutoInstaller._create_scratch_directory):
731         (AutoInstaller._install):
732         (AutoInstaller.install):
733         * Scripts/webkitpy/thirdparty/__init__.py:
734         (AutoinstallImportHook._ensure_autoinstalled_dir_is_in_sys_path):
735         (AutoinstallImportHook._install_pylint):
736         (AutoinstallImportHook._install_coverage):
737         (AutoinstallImportHook._install_eliza):
738         (AutoinstallImportHook._install):
739         * Scripts/webkitpy/thirdparty/__init___unittest.py:
740         (ThirdpartyTest.test_import_hook.MockImportHook.__init__):
741         (ThirdpartyTest.test_import_hook):
742         (ThirdpartyTest.test_imports):
743
744 2012-11-02  Dirk Pranke  <dpranke@chromium.org>
745
746         nrwt prints an awkward result message for missing results
747         https://bugs.webkit.org/show_bug.cgi?id=100915
748
749         Reviewed by Ojan Vafai.
750
751         Completely rework how we print out the description of
752         each tests's result - we now will print either "passed" or "failed",
753         followed by " unexpectedly" if we weren't expecting the result,
754         followed by a short description of each type of failure that happened
755         (in parentheses). Also reworked the description of each type of
756         failure slightly to be clearer.
757
758         Also rework the tests to make sure we have coverage of all of the
759         messages. Examples of the new output are posted as an attachment to
760         the bug.
761
762         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
763         (TestExpectations):
764         * Scripts/webkitpy/layout_tests/models/test_failures.py:
765         (FailureTimeout.message):
766         (FailureMissingResult.message):
767         (FailureTextMismatch.message):
768         (FailureMissingImageHash.message):
769         (FailureMissingImage.message):
770         (FailureImageHashMismatch.message):
771         (FailureImageHashIncorrect.message):
772         (FailureReftestMismatch.message):
773         (FailureReftestMismatchDidNotOccur.message):
774         (FailureReftestNoImagesGenerated.message):
775         (FailureMissingAudio.message):
776         (FailureAudioMismatch.message):
777         (FailureEarlyExit.message):
778         * Scripts/webkitpy/layout_tests/port/test.py:
779         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
780         (MainTest.test_run_singly_actually_runs_tests):
781         (MainTest.test_missing_and_unexpected_results):
782         * Scripts/webkitpy/layout_tests/views/printing.py:
783         (Printer._print_result_summary_entry):
784         (Printer.print_finished_test):
785         (Printer._result_message):
786         (Printer._print_unexpected_results):
787         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
788         * Scripts/webkitpy/tool/commands/queues_unittest.py:
789
790 2012-11-02  Dirk Pranke  <dpranke@chromium.org>
791
792         webkitpy: clean up logging in common.system.autoinstall
793         https://bugs.webkit.org/show_bug.cgi?id=101090
794
795         Reviewed by Ojan Vafai.
796
797         This module logged way too much, much of which was logging that
798         was either really redundant or useful only during initial development.
799         This patch deletes a lot of code and tweaks the remaining log messages
800         to be more useful now.
801
802         Also, clean up a bunch of lint errors and warnings.
803
804         * Scripts/webkitpy/common/system/autoinstall.py:
805         (AutoInstaller.__init__):
806         (AutoInstaller._write_file):
807         (AutoInstaller._set_up_target_dir):
808         (AutoInstaller._create_scratch_directory):
809         (AutoInstaller._url_downloaded_path):
810         (AutoInstaller._is_downloaded):
811         (AutoInstaller._record_url_downloaded):
812         (AutoInstaller._extract_targz):
813         (AutoInstaller._extract_all):
814         (AutoInstaller._unzip):
815         (AutoInstaller._download_to_stream):
816         (AutoInstaller._download):
817         (AutoInstaller._install):
818         (AutoInstaller.install):
819
820 2012-11-02  Dirk Pranke  <dpranke@chromium.org>
821
822         webkit-patch analyze-baselines output is weak
823         https://bugs.webkit.org/show_bug.cgi?id=100998
824
825         Reviewed by Ojan Vafai.
826
827         Currently analyze-baselines prints a list of baselines that have
828         the same checksum per line, but the format is hard to read;
829         this patch cleans up the output to print by directory instead
830         and use the same format I recently added for debugging optimize-baselines,
831         then refactors the code so that we share and adds tests for
832         analyze-baselines (which was untested).
833
834         Also, I got rid of a couple of unnecessarily-hardcoded port names,
835         and modified the baseline optimizer to log the current world when
836         optimize fails.
837
838         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
839         (BaselineOptimizer.read_results_by_directory):
840         (BaselineOptimizer.write_by_directory):
841         (BaselineOptimizer.optimize):
842         * Scripts/webkitpy/tool/commands/rebaseline.py:
843         (OptimizeBaselines.execute):
844         (AnalyzeBaselines.__init__):
845         (AnalyzeBaselines._write):
846         (AnalyzeBaselines._analyze_baseline):
847         (AnalyzeBaselines.execute):
848         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
849         (_FakeOptimizer):
850         (_FakeOptimizer.read_results_by_directory):
851         (TestAnalyzeBaselines):
852         (TestAnalyzeBaselines.setUp):
853         (TestAnalyzeBaselines.test_default):
854         (TestAnalyzeBaselines.test_missing_baselines):
855
856 2012-11-02  Adam Barth  <abarth@webkit.org>
857
858         ENABLE(UNDO_MANAGER) is disabled everywhere and is not under active development
859         https://bugs.webkit.org/show_bug.cgi?id=100711
860
861         Reviewed by Eric Seidel.
862
863         * Scripts/webkitperl/FeatureList.pm:
864         * qmake/mkspecs/features/features.pri:
865
866 2012-11-02  Sheriff Bot  <webkit.review.bot@gmail.com>
867
868         Unreviewed, rolling out r133303.
869         http://trac.webkit.org/changeset/133303
870         https://bugs.webkit.org/show_bug.cgi?id=101068
871
872         "Broke qt wk2 build (seems like bots fails to rerun qmake if
873         needed)" (Requested by kbalazs on #webkit).
874
875         * DumpRenderTree/qt/DumpRenderTree.pro:
876         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
877         (main):
878         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
879         (WebCore::DumpRenderTree::open):
880         * DumpRenderTree/qt/QtInitializeTestFonts.cpp: Renamed from Source/WebCore/platform/qt/QtTestSupport.cpp.
881         (WebKit):
882         (WebKit::initializeTestFonts):
883         * DumpRenderTree/qt/QtInitializeTestFonts.h: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
884         (WebKit):
885         * QtTestBrowser/QtTestBrowser.pro:
886         * QtTestBrowser/qttestbrowser.cpp:
887         (LauncherApplication::handleUserOptions):
888         * WebKitTestRunner/InjectedBundle/Target.pri:
889         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
890         (WTR::activateFonts):
891         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
892         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
893         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
894         (WTR::TestRunner::platformInitialize):
895         * WebKitTestRunner/Target.pri:
896         * WebKitTestRunner/qt/main.cpp:
897         (main):
898
899 2012-11-02  Balazs Kelemen  <kbalazs@webkit.org>
900
901         [Qt][WK2] setPlatformStrategies always asserts after r132744
902         https://bugs.webkit.org/show_bug.cgi?id=100838
903
904         Reviewed by Simon Hausmann.
905
906         Turned test runners to use the new QtTestSupport.
907
908         * DumpRenderTree/qt/DumpRenderTree.pro:
909         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
910         (main):
911         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
912         (WebCore::DumpRenderTree::open):
913         * QtTestBrowser/QtTestBrowser.pro:
914         * QtTestBrowser/qttestbrowser.cpp:
915         (LauncherApplication::handleUserOptions):
916         * WebKitTestRunner/InjectedBundle/Target.pri:
917         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
918         (WTR::activateFonts):
919         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Removed.
920         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Removed.
921         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
922         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
923         (WTR::TestRunner::platformInitialize): Removed the comment from here
924         because it was just lying, apparently two times. First, it is not incorrect
925         to reinitialize our font set and clear font caches, it is what the tests
926         expect. Second, the use of QRawFont has nothing to do with the font cache.
927         * WebKitTestRunner/Target.pri:
928         * WebKitTestRunner/qt/main.cpp:
929         (main):
930
931 2012-11-02  Peter Beverloo  <peter@chromium.org>
932
933         Output Android's device status before running tests on the bots
934         https://bugs.webkit.org/show_bug.cgi?id=100944
935
936         Reviewed by Dirk Pranke.
937
938         This adds a new step to the build master which will be run prior to the
939         actual tests-suites on the Chromium Android tester, and soon the Chromium
940         Android Perf bot. For each attached device, it outputs the build
941         information, battery level, battery temperature and username.
942
943         The Android tester currently is very flaky, and this will help tremendously
944         in being able to figure out what's wrong with the bot.
945
946         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
947         (OutputAndroidDeviceStatus):
948         (TestFactory.__init__):
949         * BuildSlaveSupport/chromium/output-android-device-status: Added.
950         (GetAttachedDevices):
951         (AndroidDeviceStatus):
952         (AndroidDeviceStatus.__init__):
953         (AndroidDeviceStatus._run_adb_command):
954         (AndroidDeviceStatus.device_type):
955         (AndroidDeviceStatus.device_build):
956         (AndroidDeviceStatus.device_fingerprint):
957         (AndroidDeviceStatus.battery_level):
958         (AndroidDeviceStatus.battery_temperature):
959         (AndroidDeviceStatus.username):
960         (main):
961
962 2012-11-02  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
963
964         [Qt] WTR: Make sure that eventSender.mouseDown sends a press event for the second press
965         https://bugs.webkit.org/show_bug.cgi?id=101033
966
967         Reviewed by Simon Hausmann.
968
969         eventSender.mouseDown doesn't work properly since r133153 where
970         MouseButtonDblClick events aren't interpreted as Press events anymore.
971         The problem is that mouseDown sends a DblClick event instead of a Press,
972         while the correct way is to send both events.
973
974         Since QQuickWebView isn't doing anything with DblClick events anymore,
975         simply send Press events all the time and let WebCore figure out
976         where the double clicks are.
977
978         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
979         (WTR::EventSenderProxy::updateClickCountForButton):
980         (WTR::EventSenderProxy::mouseDown):
981
982 2012-11-02  Christophe Dumez  <christophe.dumez@intel.com>
983
984         [EFL][WK2] Add HTTP authentication support to MiniBrowser
985         https://bugs.webkit.org/show_bug.cgi?id=100953
986
987         Reviewed by Kenneth Rohde Christiansen.
988
989         Add HTTP authentication support to MiniBrowser. An authentication
990         dialog now pops up to ask the user for credentials whenever
991         a Web site requires authentication.
992
993         * MiniBrowser/efl/main.c:
994         (auth_popup_close):
995         (on_auth_cancel):
996         (on_auth_ok):
997         (on_authentication_request):
998         (window_create):
999
1000 2012-11-01  Yury Semikhatsky  <yurys@chromium.org>
1001
1002         Memory instrumentation: do not call checkCountedObject with wrong pointers
1003         https://bugs.webkit.org/show_bug.cgi?id=100958
1004
1005         Reviewed by Alexander Pavlov.
1006
1007         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp: test that if there
1008         if there is class A derived from classes B and C and we have pointer B* to an
1009         object of class A then MemoryInstrumentationClient::checkoutCountedObject won't
1010         be called for B* but only for A*
1011
1012         Also MemoryInstrumentation implementation used in the test was refactored to
1013         allow passing client as a parameter. The client implementation was extracted into
1014         a top-level class MemoryInstrumentationTestClient.
1015
1016 2012-11-01  Christophe Dumez  <christophe.dumez@intel.com>
1017
1018         [EFL][WK2] Make File Chooser dialog modal in MiniBrowser
1019         https://bugs.webkit.org/show_bug.cgi?id=100962
1020
1021         Reviewed by Gyuyoung Kim.
1022
1023         Make File Chooser dialog modal in MiniBrowser and make
1024         sure it is closed and freed when its parent window is
1025         closed.
1026
1027         * MiniBrowser/efl/main.c:
1028         (close_file_picker):
1029         (on_filepicker_parent_deletion):
1030         (on_file_chooser_request):
1031
1032 2012-11-01  Seonae Kim  <sunaeluv.kim@samsung.com>
1033
1034         [EFL][DRT] Support Geolocation
1035         https://bugs.webkit.org/show_bug.cgi?id=97427
1036
1037         Reviewed by Gyuyoung Kim. 
1038
1039         Implement methods to use GeolocationClientMock in DumpRenderTree.
1040         This client attaches to the page whenever a view is created.
1041
1042         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1043         (DumpRenderTreeChrome::createView):
1044         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1045         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1046         (TestRunner::setMockGeolocationPosition):
1047         (TestRunner::setMockGeolocationPositionUnavailableError):
1048         (TestRunner::setGeolocationPermission):
1049         (TestRunner::numberOfPendingGeolocationPermissionRequests):
1050
1051 2012-11-01  Ryosuke Niwa  <rniwa@webkit.org>
1052
1053         Remove tests no longer needed after r133229.
1054
1055         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1056         (TestPerfTestFactory.test_inspector_test):
1057         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1058         (test_collect_tests_with_skipped_list):
1059
1060 2012-11-01  Nico Weber  <thakis@chromium.org>
1061
1062         [chromium] Try to find ninja if it's not in the path already
1063         https://bugs.webkit.org/show_bug.cgi?id=100988
1064
1065         Reviewed by Ryosuke Niwa.
1066
1067         Similar to the gclient detection logic in update-webkit-chromium
1068
1069         * Scripts/webkitdirs.pm:
1070         (buildChromiumNinja):
1071
1072 2012-11-01  Eric Seidel  <eric@webkit.org>
1073
1074         Add Glenn Adams to the Contributor list
1075         https://bugs.webkit.org/show_bug.cgi?id=100982
1076
1077         Reviewed by Adam Barth.
1078
1079         I CC him enough on bugs it would help me to have him listed here.
1080
1081         * Scripts/webkitpy/common/config/committers.py:
1082
1083 2012-11-01  Jer Noble  <jer.noble@apple.com>
1084
1085         Add Python-LLDB support for WTF::Vector types.
1086         https://bugs.webkit.org/show_bug.cgi?id=100980
1087
1088         Reviewed by Anders Carlsson.
1089
1090         Add a synthetic child provider for WTF::Vector types.
1091
1092         * lldb/lldb_webkit.py:
1093         (__lldb_init_module): Add both the summary and synthetic providers for WTF::Vector
1094         (WTFVector_SummaryProvider): Wrapper around WTFVectorProvider
1095         (WTFVectorProvider):
1096         (WTFVectorProvider.__init__):
1097         (WTFVectorProvider.num_children): Return m_size+2 children to account for synthesized children.
1098         (WTFVectorProvider.get_child_index): Synthesize child indexes for each entry in the Vector.
1099         (WTFVectorProvider.get_child_at_index): Synthesize children for each entry in the Vector.
1100         (WTFVectorProvider.update): Retrieve state from the underlying Vector.
1101         (WTFVectorProvider.has_children): Vectors always have children.
1102
1103 2012-11-01  Zoltan Horvath  <zoltan@webkit.org>
1104
1105         Remove PageLoad directory entry from PerformanceTests pattern_map
1106         https://bugs.webkit.org/show_bug.cgi?id=100989
1107
1108         Reviewed by Ryosuke Niwa.
1109
1110         Since we removed PageLoad directory from PerformanceTests we don't need this entry in pattern_map.
1111
1112         * Scripts/webkitpy/performance_tests/perftest.py:
1113         (PerfTestFactory):
1114
1115 2012-11-01  Jer Noble  <jer.noble@apple.com>
1116
1117         Add LLDB-Python scripts to support WebKit data types.
1118         https://bugs.webkit.org/show_bug.cgi?id=100898
1119
1120         Reviewed by Anders Carlsson.
1121
1122         Add Summary providers for common WebKit string types.
1123
1124         * lldb/lldb_webkit.py: Added.
1125         (__lldb_init_module): Register these providers with the debugger.
1126         (WTFString_SummaryProvider): Wrapper around WTFStringProvider.
1127         (WTFStringImpl_SummaryProvider): Wrapper around WTFStringImplProvider.
1128         (WTFAtomicString_SummaryProvider): Ditto.
1129         (guess_string_length): Walk through the string looking for a null-byte(s).
1130         (ustring_to_string): Walk through the string, extracting two-byte values, and concatenate them.
1131         (lstring_to_string): Walk through the string, extracting byte values, and concatenate them.
1132         (WTFStringImplProvider): 
1133         (WTFStringImplProvider.__init__):
1134         (WTFStringImplProvider.get_length): Extract the m_length variable.
1135         (WTFStringImplProvider.get_data8): Extract the m_data8 variable.
1136         (WTFStringImplProvider.get_data16): Extract the m_data16 variable.
1137         (WTFStringImplProvider.to_string): Pass the appropriate data variable to {u,l}string_to_string.
1138         (WTFStringImplProvider.is_8bit): Check the m_hashAndFlags variable.
1139         (WTFStringProvider):
1140         (WTFStringProvider.__init__):
1141         (WTFStringProvider.stringimpl): Extract the m_impl variable.
1142         (WTFStringProvider.get_length): Pass through to WTFStringImplProvider.
1143         (WTFStringProvider.to_string): Ditto.
1144
1145 2012-11-01  Peter Beverloo  <peter@chromium.org>
1146
1147         [Chromium-Android] Apache doesn't properly clean up ipc semaphores after a layout test run
1148         https://bugs.webkit.org/show_bug.cgi?id=100950
1149
1150         Reviewed by Dirk Pranke.
1151
1152         When a test run would fail to complete due to an exception in one of
1153         the workers, the HTTP server wouldn't get a chance to gracefully shut
1154         down. This caused too much IPC semaphores to be left on the server,
1155         causing Apache to fail to start in subsequent runs.
1156
1157         By unifying the Android-specific code with other ports, we no longer
1158         fail to call the ChromiumPort/Base setup_test_run() and clean_up_test_run()
1159         methods either. Furthermore, the number_of_servers argument for starting
1160         the HTTP server is now available as well.
1161
1162         Because not all tests require an HTTP server, it's not guaranteed that
1163         it will be started. Android depends on this, so add a new method to Port
1164         and override it for Android: requires_http_server().
1165
1166         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1167         (LayoutTestRunner.run_tests):
1168         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1169         (Manager._run_tests):
1170         * Scripts/webkitpy/layout_tests/port/base.py:
1171         (Port.to.requires_http_server):
1172         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1173         (PortTest.test_dont_require_http_server):
1174         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1175         (ChromiumAndroidPort.requires_http_server):
1176         (ChromiumAndroidPort.start_http_server):
1177         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1178         (ChromiumAndroidPortTest.test_must_require_http_server):
1179
1180 2012-11-01  Adam Roben  <aroben@webkit.org>
1181
1182         Crash beneath WKRelease after failed load in MiniBrowser
1183         https://bugs.webkit.org/show_bug.cgi?id=100954
1184
1185         Reviewed by Sam Weinig.
1186
1187         There were just some simple retain/release bugs.
1188
1189         * MiniBrowser/mac/WK2BrowserWindowController.m:
1190         (-[WK2BrowserWindowController updateTextFieldFromURL:]):
1191         (-[WK2BrowserWindowController updateProvisionalURLForFrame:]):
1192         Don't try to release null URLs.
1193
1194         (-[WK2BrowserWindowController updateCommittedURLForFrame:]): Don't
1195         release a URL for which we don't have ownership.
1196
1197 2012-10-31  Rob Buis  <rbuis@rim.com>
1198
1199         [BlackBerry] Fix editing/text-iterator/findString-expected.html fail
1200         https://bugs.webkit.org/show_bug.cgi?id=100902
1201
1202         Reviewed by Yong Li.
1203
1204         PR 210039
1205
1206         Fix the test my using the Page::findString method instead of our own in-page searcher.
1207         This also syncs some of the changes we did regarding String usage.
1208
1209         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1210         (BlackBerry::WebKit::DumpRenderTree::dumpFramesAsText):
1211         (BlackBerry::WebKit::dumpHistoryItem):
1212         (BlackBerry::WebKit::dumpBackForwardListForWebView):
1213         (BlackBerry::WebKit::DumpRenderTree::dump):
1214         (BlackBerry::WebKit::DumpRenderTree::didFinishDocumentLoadForFrame):
1215         (BlackBerry::WebKit::DumpRenderTree::didReceiveTitleForFrame):
1216         (BlackBerry::WebKit::DumpRenderTree::runJavaScriptAlert):
1217         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
1218         (DumpRenderTree):
1219         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1220         (TestRunner::setMockGeolocationError):
1221         (TestRunner::layerTreeAsText):
1222         (TestRunner::findString):
1223         (TestRunner::setStorageDatabaseIdleInterval):
1224
1225 2012-11-01  Christophe Dumez  <christophe.dumez@intel.com>
1226
1227         [EFL][WK2] Add File Chooser dialog support to MiniBrowser
1228         https://bugs.webkit.org/show_bug.cgi?id=100822
1229
1230         Reviewed by Kenneth Rohde Christiansen.
1231
1232         Add very basic file picker dialog to MiniBrowser so that
1233         the user can select a file from the file system when
1234         clicking an input element of type "file".
1235
1236         * MiniBrowser/efl/main.c:
1237         (close_file_picker):
1238         (on_filepicker_deletion):
1239         (on_fileselector_done):
1240         (on_file_chooser_request):
1241         (window_create):
1242
1243 2012-11-01  Yael Aharon  <yael.aharon@intel.com>
1244
1245         Unreviewed. Change my email address.
1246
1247         * Scripts/webkitpy/common/config/committers.py:
1248
1249 2012-11-01  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
1250
1251         [Qt] Double clicks/taps aren't passed down to the page
1252         https://bugs.webkit.org/show_bug.cgi?id=100949
1253
1254         Reviewed by Kenneth Rohde Christiansen.
1255
1256         Touch mocking shouldn't transform double click events as well,
1257         this adds an extra touch update between clicks which prevents
1258         double-tap detection from triggering on web pages.
1259
1260         Tested on the mobile version of Google maps.
1261
1262         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1263         (MiniBrowserApplication::notify):
1264
1265 2012-10-31  Dirk Pranke  <dpranke@chromium.org>
1266
1267         NRWT: lint warnings don't show up by default
1268         https://bugs.webkit.org/show_bug.cgi?id=100914
1269
1270         Reviewed by Ryosuke Niwa.
1271
1272         NRWT wasn't printing any warnings if you had errors in your
1273         TestExpectations files; this means you would only notice this
1274         with --lint-test-files, which is probably bad. I'm not sure
1275         when this requested, but perhaps when we changed the
1276         warnings to not be fatal if you weren't linting the files.
1277
1278         Now they're still not fatal, but at least we print them.
1279
1280         Also fix one warning message where we were printing the test name twice.
1281
1282         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1283         (TestExpectationsModel._already_seen_better_match):
1284         (TestExpectations._report_warnings):
1285         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1286         (MiscTests.test_parse_warnings_are_logged_if_not_in_lint_mode(self): Added.
1287
1288 2012-10-31  Terry Anderson  <tdanderson@chromium.org>
1289
1290         Missing stderr output when using run-webkit-tests
1291         https://bugs.webkit.org/show_bug.cgi?id=100709
1292
1293         Reviewed by Dirk Pranke.
1294
1295         Appends #EOF to the end of the stderr output only at the end of a test,
1296         not possibly part-way through. This will allow all of the stderr output 
1297         to appear on the results page after running run-webkit-tests.
1298
1299         * DumpRenderTree/chromium/TestEventPrinter.cpp:
1300         (TestEventPrinter::handleTextFooter):
1301         (TestEventPrinter::handleTestFooter):
1302
1303 2012-10-30  Mark Lam  <mark.lam@apple.com>
1304
1305         A JSC printf (support for %J+s and %b).
1306         https://bugs.webkit.org/show_bug.cgi?id=100566.
1307
1308         Reviewed by Michael Saboff.
1309
1310         Added regression tests for VMInspector::fprintf() sprintf() and snprintf().
1311
1312         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1313         * TestWebKitAPI/Tests/JavaScriptCore: Added.
1314         * TestWebKitAPI/Tests/JavaScriptCore/VMInspector.cpp: Added.
1315
1316 2012-10-31  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1317
1318         Added viewport at-rule to the CSS parser and tokenizer
1319         https://bugs.webkit.org/show_bug.cgi?id=95961
1320
1321         Reviewed by Kenneth Rohde Christiansen.
1322
1323         Enable CSS Device Adaptation by default on EFL.
1324
1325         * Scripts/webkitperl/FeatureList.pm:
1326
1327 2012-10-31  Terry Anderson  <tdanderson@chromium.org>
1328
1329         [touchadjustment] touch-links-two-finger-tap test pass incorrectly
1330         https://bugs.webkit.org/show_bug.cgi?id=100619
1331
1332         Reviewed by Antonio Gomes.
1333
1334         Store the touch area when sending a GestureTwoFingerTap event.
1335
1336         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
1337         (WebTestRunner):
1338         (WebTestRunner::EventSender::gestureEvent):
1339
1340 2012-10-31  Dirk Pranke  <dpranke@chromium.org>
1341
1342         nrwt is not killing stuck DRTs on chromium win
1343         https://bugs.webkit.org/show_bug.cgi?id=100886
1344
1345         Unreviewed, build fix.
1346
1347         In the original implementation of NRWT for Chromium, we used
1348         to assume that DRT would always manage to exit on its own and
1349         so NRWT wouldn't attempt to kill DRT if it was stuck (this was the
1350         "hung worker" problem, and meant that if DRT hung, NRWT would hang).
1351
1352         Eventually, we merged the chromium code with the other ports and
1353         now will always try to shut down DRTs if a test times out, but as
1354         part of that merge we left in a code path where we wouldn't
1355         shut the driver down on windows. This was resulting in stray
1356         DRTs being left around, and NRWT sometimes not exiting cleanly as
1357         a result.
1358
1359         No unit tests added because this was a windows-only code path (hence
1360         hard to test) and that is now gone.
1361
1362         * Scripts/webkitpy/layout_tests/port/server_process.py:
1363         (ServerProcess.stop):
1364
1365 2012-10-31  Ami Fischman  <fischman@chromium.org>
1366
1367         [chromium] DRT and WTR should clear the cache between tests
1368         https://bugs.webkit.org/show_bug.cgi?id=93195
1369
1370         Reviewed by Tony Chang.
1371
1372         This change makes chromium DRT match the GTK+, Qt, and EFL ports.
1373
1374         * DumpRenderTree/chromium/TestShell.cpp:
1375         (TestShell::resetTestController): added a WebCache::clear() call to achieve the goal of the bug.
1376
1377 2012-10-31  Dirk Pranke  <dpranke@chromium.org>
1378
1379         Fix typos introduced in r133061.
1380         Unreviewed, build fix.
1381
1382         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1383         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
1384         (ReflectionHandler._serve_file):
1385
1386 2012-10-31  Dirk Pranke  <dpranke@chromium.org>
1387
1388         garden-o-matic should work for local results
1389         https://bugs.webkit.org/show_bug.cgi?id=100805
1390
1391         Reviewed by Adam Barth.
1392
1393         This is the next step in making garden-o-matic replace
1394         'webkit-patch rebaseline-server' and be able to deal with local
1395         results. garden-o-matic now accepts a '--results-directory' option
1396         that will point to a layout-test-results directory. At the moment
1397         this will only work if you are also filtering to a single bot/
1398         platform at a time (we can't handle multiple bots' worth of local
1399         results, but that is a logical next step).
1400
1401         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1402         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1403         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1404         * Scripts/webkitpy/tool/commands/gardenomatic.py:
1405         (GardenOMatic.__init__):
1406         (GardenOMatic.execute):
1407         * Scripts/webkitpy/tool/commands/rebaseline.py:
1408         (AbstractRebaseliningCommand):
1409         (RebaselineTest.__init__):
1410         (RebaselineTest._rebaseline_test):
1411         (RebaselineTest._rebaseline_test_and_update_expectations):
1412         (RebaselineTest.execute):
1413         (AbstractParallelRebaselineCommand._rebaseline_commands):
1414         (AbstractParallelRebaselineCommand._rebaseline):
1415         (RebaselineJson.__init__):
1416         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1417         (_BaseTestCase):
1418         (test_rebaseline_updates_expectations_file):
1419         (test_rebaseline_does_not_include_overrides):
1420         (test_rebaseline_test):
1421         (test_rebaseline_test_and_print_scm_changes):
1422         (test_rebaseline_and_copy_test):
1423         (test_rebaseline_and_copy_test_no_existing_result):
1424         (test_rebaseline_and_copy_test_with_lion_result):
1425         (test_rebaseline_and_copy_no_overwrite_test):
1426         (test_rebaseline_test_internal_with_move_overwritten_baselines_to):
1427         (TestRebaselineJson.test_rebaseline_all):
1428         (TestRebaselineJson.test_rebaseline_debug):
1429         (TestRebaselineJson.test_move_overwritten):
1430         (TestRebaselineJson.test_no_optimize):
1431         (TestRebaselineExpectations.test_rebaseline_expectations):
1432         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1433         (GardeningHTTPRequestHandler.rebaselineall):
1434         (GardeningHTTPRequestHandler):
1435         (GardeningHTTPRequestHandler.localresult):
1436         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
1437         (ReflectionHandler.do_POST):
1438         (ReflectionHandler):
1439         (ReflectionHandler.do_HEAD):
1440
1441 2012-10-31  Dirk Pranke  <dpranke@chromium.org>
1442
1443         garden-o-matic should support gardening a single port and specifying how to deal with overwritten baselines
1444         https://bugs.webkit.org/show_bug.cgi?id=100563
1445
1446         Reviewed by Ojan Vafai.
1447
1448         This patch starts the process of making garden-o-matic more useful for
1449         bringing up a single new port in two ways. The goal is to fully
1450         obsolete webkit-patch rebaseline-server.
1451         
1452         First, it adds support for the --platform arguments to garden-o-matic
1453         (so that the UI will default to the right cluster of bots), and if the platform arg
1454         specifies a single bot, filters the results down to just that bot.
1455
1456         Second, it adds support for --move-overwritten-baselines and changes
1457         the implementation of the move_overwritten_baselines setting in builders.py
1458         so that it is only used if this flag is provided.
1459
1460         Future patches will make it possible to use local copies of the build
1461         results (rather than going to the bots) and other optimizations to make
1462         it faster to review lots of changes on a single bot.
1463
1464         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1465         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1466         (.):
1467         * Scripts/webkitpy/layout_tests/port/builders.py:
1468         * Scripts/webkitpy/tool/commands/gardenomatic.py:
1469         (GardenOMatic):
1470         (GardenOMatic.execute):
1471         * Scripts/webkitpy/tool/commands/rebaseline.py:
1472         (AbstractRebaseliningCommand):
1473         (AbstractRebaseliningCommand.__init__):
1474         (RebaselineTest):
1475         (OptimizeBaselines):
1476         (AnalyzeBaselines):
1477         (AbstractParallelRebaselineCommand):
1478         (AbstractParallelRebaselineCommand._rebaseline_commands):
1479         (AbstractParallelRebaselineCommand._rebaseline):
1480         (Rebaseline.__init__):
1481         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1482         (GardeningHTTPServer.url):
1483         (GardeningHTTPRequestHandler.rebaselineall):
1484
1485 2012-10-31  Dirk Pranke  <dpranke@chromium.org>
1486
1487         test-webkitpy: fix running modules and classes on the command line
1488         https://bugs.webkit.org/show_bug.cgi?id=100787
1489
1490         Reviewed by Eric Seidel.
1491
1492         Handling modules and classes are arguments on the command line
1493         was broken due to the way we were parsing test names looking for
1494         parallel and serial tests.
1495
1496         * Scripts/webkitpy/test/main.py:
1497         (Tester._test_names):
1498         (_Loader):
1499         * Scripts/webkitpy/test/main_unittest.py:
1500         (TestStubs.integration_test_empty):
1501         (TestStubs):
1502         (TestStubs.serial_test_empty):
1503         (TestStubs.serial_integration_test_empty):
1504         (TesterTest._find_test_names):
1505         (TesterTest):
1506         (TesterTest.test_individual_names_are_not_run_twice):
1507         (TesterTest.test_integration_tests_are_not_found_by_default):
1508         (TesterTest.test_integration_tests_are_found):
1509
1510 2012-10-31  Dirk Pranke  <dpranke@chromium.org>
1511
1512         webkitpy: refactor common command line arguments for --platform, rebaseline commands
1513         https://bugs.webkit.org/show_bug.cgi?id=100800
1514
1515         Reviewed by Ojan Vafai.
1516
1517         This change shuffles around how we share command-line options
1518         between NRWT and the various webkit-patch rebaselining commands.
1519
1520         There are no functional changes in this patch but it should make
1521         things clearer and will be useful in a couple of upcoming patches.
1522
1523         * Scripts/webkitpy/layout_tests/port/__init__.py:
1524         * Scripts/webkitpy/layout_tests/port/factory.py:
1525         (platform_options):
1526         (configuration_options):
1527         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1528         (parse_args):
1529         * Scripts/webkitpy/tool/commands/queries.py:
1530         (PrintExpectations.__init__):
1531         (PrintBaselines.__init__):
1532         * Scripts/webkitpy/tool/commands/rebaseline.py:
1533         (AbstractRebaseliningCommand):
1534         (AbstractRebaseliningCommand.__init__):
1535         (RebaselineTest.__init__):
1536         (OptimizeBaselines.__init__):
1537         (AnalyzeBaselines.__init__):
1538         (AbstractParallelRebaselineCommand):
1539         (RebaselineJson.__init__):
1540         (RebaselineExpectations.__init__):
1541         (Rebaseline.__init__):
1542
1543 2012-10-31  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1544
1545         [NRWT] Xvfb driver is leaking application cache files
1546         https://bugs.webkit.org/show_bug.cgi?id=100864
1547
1548         Reviewed by Kenneth Rohde Christiansen.
1549
1550         Application Cache looks for XDG_CACHE_HOME which is now
1551         prepended with DUMPRENDERTREE_TEMP and cleaned up when
1552         the test worker finishes his job.
1553
1554         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
1555         (XvfbDriver._start):
1556
1557 2012-10-31  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1558
1559         [EFL] DRT doesn't clean up after itself
1560         https://bugs.webkit.org/show_bug.cgi?id=100346
1561
1562         Reviewed by Kenneth Rohde Christiansen.
1563
1564         The test driver exports an environment variable DUMPRENDERTREE_TEMP
1565         which is used by both DRT and WTR as the folder for storing icons,
1566         databases, application cache, etc, overriding the default XDG_* path.
1567
1568         We don't need to create these folders because in fact, they are never
1569         used and also never cleaned. Things created inside DUMPRENDERTREE_TEMP
1570         are automatically removed after the test run.
1571
1572         * Scripts/webkitpy/layout_tests/port/efl.py:
1573         (EflPort.setup_environ_for_server):
1574
1575 2012-10-31  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1576
1577         [WTR] WebKitTestRunner is not cleaning up the icon database
1578         https://bugs.webkit.org/show_bug.cgi?id=100678
1579
1580         Reviewed by Kenneth Rohde Christiansen.
1581
1582         The icon database was not being set to the temporary folder created for
1583         the test runner by the test driver, which is removed automatically
1584         after the run.
1585
1586         * WebKitTestRunner/TestController.cpp:
1587         (WTR::TestController::initialize):
1588
1589 2012-10-31  Mike West  <mkwst@chromium.org>
1590
1591         Script run from an isolated world should bypass a page's CSP.
1592         https://bugs.webkit.org/show_bug.cgi?id=97398
1593
1594         Reviewed by Adam Barth.
1595
1596         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1597         (DRTTestRunner::DRTTestRunner):
1598         (DRTTestRunner::setIsolatedWorldContentSecurityPolicy):
1599         * DumpRenderTree/chromium/DRTTestRunner.h:
1600         (DRTTestRunner):
1601             Adding a mechanism to set the Content Security Policy for an
1602             isolated world to Chromium's testRunner.
1603
1604 2012-10-31  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
1605
1606         [EFL][DRT] EventSender requires contextClick implementation
1607         https://bugs.webkit.org/show_bug.cgi?id=86091
1608
1609         Reviewed by Gyuyoung Kim.
1610
1611         Add contextClick for DumpRenderTreeEventSender basing on WebKit GTK
1612         implementation.
1613
1614         * DumpRenderTree/efl/EventSender.cpp:
1615         (getMenuItemTitleCallback):
1616         (setMenuItemTitleCallback):
1617         (menuItemClickCallback):
1618         (contextClickCallback):
1619
1620 2012-10-30  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1621
1622         [WTR] Memory leaks in TestWebKitAPI::didReceiveMessageFromInjectedBundle()
1623         https://bugs.webkit.org/show_bug.cgi?id=100770
1624
1625         Reviewed by Sam Weinig.
1626
1627         Adopt strings returned by WKStringCreateWithUTF8CString() in
1628         didReceiveMessageFromInjectedBundle() to avoid memory leaks.
1629
1630         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent.cpp:
1631         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1632
1633 2012-10-30  Kangil Han  <kangil.han@samsung.com>
1634
1635         Fix broken python unit test
1636         https://bugs.webkit.org/show_bug.cgi?id=100810
1637
1638         Reviewed by Dirk Pranke.
1639
1640         BUG 100755 has broken python unit test, e.g. assertion fail, since it modified baseline path.
1641         Therefore, this patch fixes it.
1642
1643         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1644         (TestRebaselineTest.test_baseline_directory):
1645
1646 2012-10-30  Dirk Pranke  <dpranke@chromium.org>
1647
1648         webkit-patch rebaseline*: add more helpful logging
1649         https://bugs.webkit.org/show_bug.cgi?id=100562
1650
1651         Reviewed by Ojan Vafai.
1652
1653         This change rewires the garden-o-matic and rebaseline* commands
1654         in webkit-patch so that --verbose propagates through all the
1655         subcommand invocations properly, and cleans up the logging so
1656         that you can actually tell what is happening. For now, we
1657         leave all of the logging at the logging.DEBUG level, which
1658         means that it gets mixed in will all the other debug logging noise
1659         and is harder to read, but we'll fix that in subsequent patches.
1660
1661         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
1662         (BaselineOptimizer._platform):
1663         (BaselineOptimizer._move_baselines):
1664         (BaselineOptimizer.optimize):
1665         * Scripts/webkitpy/tool/commands/gardenomatic.py:
1666         (GardenOMatic.execute):
1667         * Scripts/webkitpy/tool/commands/rebaseline.py:
1668         (RebaselineTest._copy_existing_baseline):
1669         (RebaselineTest._rebaseline_test):
1670         (OptimizeBaselines._optimize_baseline):
1671         (OptimizeBaselines.execute):
1672         (AbstractParallelRebaselineCommand._run_webkit_patch):
1673         (AbstractParallelRebaselineCommand._rebaseline_commands):
1674         (AbstractParallelRebaselineCommand._files_to_add):
1675         (AbstractParallelRebaselineCommand._optimize_baselines):
1676         (AbstractParallelRebaselineCommand._rebaseline):
1677         (RebaselineExpectations._add_tests_to_rebaseline_for_port):
1678         (Rebaseline.execute):
1679         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1680         (GardeningHTTPServer.__init__):
1681         (GardeningHTTPRequestHandler):
1682         (GardeningHTTPRequestHandler._run_webkit_patch):
1683         (GardeningHTTPRequestHandler.rebaselineall):
1684
1685 2012-10-30  Dirk Pranke  <dpranke@chromium.org>
1686
1687         clean up tests for webkit-patch rebaseline* commands
1688         https://bugs.webkit.org/show_bug.cgi?id=100793
1689
1690         Reviewed by Ojan Vafai.
1691
1692         The tests in rebaseline_unittest.py had a lot of code cloning,
1693         and many of the tests tested whether things passed or failed by
1694         looking at what was logged instead of what was actually done;
1695         as a result the tests were kinda hard to understand and harder to
1696         maintain.
1697
1698         This patch adds hooks to MockWeb() and MockExecutive() so we can
1699         directly see which URLs were fetched and calls invoked, and
1700         then reworks all of the unit tests to be easier to follow and
1701         maintain and not sensitive to the logging. Also there were a
1702         couple of tests that were redundant.
1703
1704         There are no functional changes in this patch, and I verified that
1705         the coverage remains the same.
1706
1707         * Scripts/webkitpy/common/net/web_mock.py:
1708         (MockWeb.__init__):
1709         (MockWeb.get_binary):
1710         * Scripts/webkitpy/common/system/executive_mock.py:
1711         (MockExecutive.__init__):
1712         (MockExecutive.run_command):
1713         (MockExecutive.kill_all):
1714         (MockExecutive):
1715         (MockExecutive.kill_process):
1716         (MockExecutive.popen):
1717         (MockExecutive.run_in_parallel):
1718         (MockExecutive2):
1719         (MockExecutive2.__init__):
1720         (MockExecutive2.run_command):
1721         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1722         (_BaseTestCase):
1723         (_BaseTestCase.setUp):
1724         (_BaseTestCase._expand):
1725         (_BaseTestCase._read):
1726         (_BaseTestCase._write):
1727         (_BaseTestCase._zero_out_test_expectations):
1728         (TestRebaselineTest):
1729         (TestRebaselineTest.test_baseline_directory):
1730         (TestRebaselineTest.test_rebaseline_updates_expectations_file_noop):
1731         (test_rebaseline_updates_expectations_file):
1732         (test_rebaseline_does_not_include_overrides):
1733         (test_rebaseline_test):
1734         (test_rebaseline_test_and_print_scm_changes):
1735         (test_rebaseline_and_copy_test):
1736         (test_rebaseline_and_copy_test_no_existing_result):
1737         (test_rebaseline_and_copy_test_with_lion_result):
1738         (test_rebaseline_and_copy_no_overwrite_test):
1739         (test_rebaseline_test_internal_with_move_overwritten_baselines_to):
1740         (TestRebaselineJson):
1741         (TestRebaselineJson.setUp):
1742         (TestRebaselineJson.tearDown):
1743         (TestRebaselineJson.test_rebaseline_all):
1744         (TestRebaselineJson.test_rebaseline_debug):
1745         (TestRebaseline):
1746         (TestRebaseline.test_tests_to_update):
1747         (TestRebaseline.test_rebaseline):
1748         (TestRebaseline.test_rebaseline.rebaseline_stub):
1749         (TestRebaselineExpectations):
1750         (TestRebaselineExpectations.setUp):
1751         (TestRebaselineExpectations.test_rebaseline_expectations):
1752         (TestRebaselineExpectations.test_rebaseline_expectations_noop):
1753         (TestRebaselineExpectations.disabled_test_overrides_are_included_correctly):
1754
1755 2012-10-30  Dirk Pranke  <dpranke@chromium.org>
1756
1757         test-webkitpy: fix import of coverage so that it works in a clean install
1758         https://bugs.webkit.org/show_bug.cgi?id=100780
1759
1760         Reviewed by Tony Chang.
1761
1762         The coverage module is written so that the parent directory needs
1763         to be in PYTHONPATH; work around that ...
1764
1765         * Scripts/webkitpy/test/main_unittest.py:
1766         (TestStubs.test_empty):
1767         (TesterTest.test_individual_names_are_not_run_twice):
1768         (TesterTest):
1769         (TesterTest.integration_test_coverage_works):
1770         * Scripts/webkitpy/thirdparty/__init__.py:
1771         (AutoinstallImportHook._install_coverage):
1772
1773 2012-10-30  Anders Carlsson  <andersca@apple.com>
1774
1775         Another build fix.
1776
1777         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
1778         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1779
1780 2012-10-30  Anders Carlsson  <andersca@apple.com>
1781
1782         Build fix.
1783
1784         * WebKitTestRunner/mac/EventSenderProxy.mm:
1785         (WTR::EventSenderProxy::mouseScrollBy):
1786
1787 2012-10-30  Rick Byers  <rbyers@chromium.org>
1788
1789         [touchadjustment] touch-links-longpress tests passes incorrectly
1790         https://bugs.webkit.org/show_bug.cgi?id=96810
1791
1792         Reviewed by Antonio Gomes.
1793
1794         Add support for suppling width/height information for longpress
1795         gesture (as for other gestures like tapDown) for the purposes
1796         of touch adjustment.
1797
1798         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
1799         (WebTestRunner):
1800         (WebTestRunner::EventSender::gestureEvent):
1801
1802 2012-10-29  Anders Carlsson  <andersca@apple.com>
1803
1804         Build WebKit as C++11 on Mac
1805         https://bugs.webkit.org/show_bug.cgi?id=100720
1806
1807         Reviewed by Daniel Bates.
1808
1809         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1810         * MiniBrowser/Configurations/Base.xcconfig:
1811         * TestWebKitAPI/Configurations/Base.xcconfig:
1812         * WebKitTestRunner/Configurations/Base.xcconfig:
1813         Add CLANG_CXX_LANGUAGE_STANDARD=gnu++0x.
1814
1815 2012-10-30  Christophe Dumez  <christophe.dumez@intel.com>
1816
1817         [EFL][JHBUILD] Update EFL libraries to v1.7.1 stable release
1818         https://bugs.webkit.org/show_bug.cgi?id=100759
1819
1820         Reviewed by Kenneth Rohde Christiansen.
1821
1822         Update Bump EFL libraries to the new stable release (v1.7.1)
1823         in JHBuild to pull the latest bug fixes.
1824
1825         * efl/jhbuild.modules:
1826
1827 2012-10-29  Anders Carlsson  <andersca@apple.com>
1828
1829         String::createCFString should return a RetainPtr
1830         https://bugs.webkit.org/show_bug.cgi?id=100419
1831
1832         Reviewed by Andreas Kling.
1833
1834         Update callers of String::createCFString.
1835
1836         * WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
1837         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
1838
1839 2012-10-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1840
1841         [WK2][WTR] WebKitTestRunner needs testRunner.queueLoadHTMLString
1842         https://bugs.webkit.org/show_bug.cgi?id=100747
1843
1844         Reviewed by Kenneth Rohde Christiansen.
1845
1846         Added testRunner.queueLoadHTMLString implementation.
1847
1848         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1849         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1850         (WTR::InjectedBundle::queueLoadHTMLString):
1851         (WTR):
1852         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1853         (InjectedBundle):
1854         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1855         (WTR::TestRunner::queueLoadHTMLString):
1856         (WTR):
1857         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1858         (TestRunner):
1859         * WebKitTestRunner/TestInvocation.cpp:
1860         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1861         * WebKitTestRunner/WorkQueueManager.cpp:
1862         (WTR::WorkQueueManager::queueLoadHTMLString):
1863         (WTR):
1864         * WebKitTestRunner/WorkQueueManager.h:
1865         (WorkQueueManager):
1866
1867 2012-10-30  Kangil Han  <kangil.han@samsung.com>
1868
1869         [EFL] Baseline search path should consider both WK1 and WK2 on layout test.
1870         https://bugs.webkit.org/show_bug.cgi?id=100755
1871
1872         Reviewed by Gyuyoung Kim.
1873
1874         Current implementation doesn't consider WK1 case in baseline search path.
1875         Therefore, this patch fixes it.
1876
1877         * Scripts/webkitpy/layout_tests/port/efl.py:
1878         (EflPort.default_baseline_search_path):
1879
1880 2012-10-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1881
1882         [QT][DRT] Remove unneeded testRunner.setMediaType() implementation
1883         https://bugs.webkit.org/show_bug.cgi?id=100740
1884
1885         Reviewed by Kenneth Rohde Christiansen.
1886
1887         Removed unneeded testRunner.setMediaType() implementation, as tests use
1888         cross-platform window.internals.settings.setMediaTypeOverride instead.
1889
1890         * DumpRenderTree/qt/TestRunnerQt.cpp:
1891         * DumpRenderTree/qt/TestRunnerQt.h:
1892         (TestRunner):
1893
1894 2012-10-30  Kangil Han  <kangil.han@samsung.com>
1895
1896         [EFL][DRT] Bitmap should show whole view area.
1897         https://bugs.webkit.org/show_bug.cgi?id=100642
1898
1899         Reviewed by Gyuyoung Kim.
1900
1901         css sticky position test cases haven't been passed even though implementation has been landed by BUG 95182.
1902         This is because current create bitmap implementation refers to geometry position that considers scroll movement even though
1903         paint does it. Therefore, this patch always reflects current view size and remove duplicated graphic operation to dump correct bitmap image.
1904
1905         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
1906         (createBitmapContextFromWebView):
1907
1908 2012-10-30  Jinwoo Song  <jinwoo7.song@samsung.com>
1909
1910         [EFL] Refactor tooltip callback signal in WebKit1
1911         https://bugs.webkit.org/show_bug.cgi?id=100571
1912
1913         Reviewed by Gyuyoung Kim.
1914
1915         Separate tooltip callback signal into 'tooltip,text,set'
1916         and 'tooltip,text,unset' to be consistent with WebKit2.
1917
1918         * EWebLauncher/main.c:
1919         (on_tooltip_text_set):
1920         (on_tooltip_text_unset):
1921         (browserCreate):
1922
1923 2012-10-29  Csaba Osztrogonác  <ossy@webkit.org>
1924
1925         Unreviewed, rolling out r132819.
1926         http://trac.webkit.org/changeset/132819
1927         https://bugs.webkit.org/show_bug.cgi?id=100388
1928
1929         It made layout testing 40% slower and storage tests assert
1930
1931         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1932         (WebCore::DumpRenderTree::DumpRenderTree):
1933         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1934         (WebCore::DumpRenderTree::dump):
1935         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1936         (DumpRenderTree):
1937         * DumpRenderTree/qt/TestRunnerQt.cpp:
1938         (TestRunner::reset):
1939         * DumpRenderTree/qt/TestRunnerQt.h:
1940         (TestRunner):
1941
1942 2012-10-29  Jochen Eisinger  <jochen@chromium.org>
1943
1944         [chromium] TestRunner needs to compile ChromiumCurrentTime and ChromiumThreading in components build
1945         https://bugs.webkit.org/show_bug.cgi?id=100658
1946
1947         Reviewed by Tony Chang.
1948
1949         Before, this was compiled into DumpRenderTree. I also dropped the
1950         include_dirs and dependencies block as TestRunner already has them.
1951
1952         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1953
1954 2012-10-29  Takashi Sakamoto  <tasak@google.com>
1955
1956         Unreviewed. Adding myself as a committer.
1957
1958         * Scripts/webkitpy/common/config/committers.py:
1959
1960 2012-10-28  Mark Rowe  <mrowe@apple.com>
1961
1962         Simplify Xcode configuration settings that used to vary between OS versions.
1963
1964         Reviewed by Dan Bernstein.
1965
1966         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1967         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1968         * MiniBrowser/Configurations/Base.xcconfig:
1969         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1970         * TestWebKitAPI/Configurations/Base.xcconfig:
1971         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1972         * WebKitTestRunner/Configurations/Base.xcconfig:
1973         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1974
1975 2012-10-28  Mark Rowe  <mrowe@apple.com>
1976
1977         Remove references to unsupported OS and Xcode versions.
1978
1979         Reviewed by Anders Carlsson.
1980
1981         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1982         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1983         * DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig: Removed.
1984         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1985         * MiniBrowser/Configurations/Base.xcconfig:
1986         * MiniBrowser/Configurations/CompilerVersion.xcconfig: Removed.
1987         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1988         * TestWebKitAPI/Configurations/Base.xcconfig:
1989         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig: Removed.
1990         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1991         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1992         * WebKitTestRunner/Configurations/Base.xcconfig:
1993         * WebKitTestRunner/Configurations/CompilerVersion.xcconfig: Removed.
1994         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1995         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1996
1997 2012-10-26  Dirk Pranke  <dpranke@chromium.org>
1998
1999         webkitpy: change non-verbose log format for webkit-patch
2000         https://bugs.webkit.org/show_bug.cgi?id=100561
2001
2002         Reviewed by Ojan Vafai.
2003
2004         Logging the module name and the log level is annoying and nearly useless.
2005         For starters, this change removes that unless you are doing verbose/
2006         debug logging. In the future we should split out the concepts of
2007         verbose and debug logging (like we did in test-webkitpy and
2008         run-webkit-tests) so that you could get this in debug logging.
2009
2010         * Scripts/webkitpy/common/system/logutils.py:
2011         (_default_handlers):
2012         (configure_logging):
2013         * Scripts/webkitpy/common/system/logutils_unittest.py:
2014         (ConfigureLoggingTest.test_info_message):
2015         (ConfigureLoggingTest):
2016         (ConfigureLoggingTest.test_debug_message):
2017         (ConfigureLoggingTest.test_two_messages):
2018         (ConfigureLoggingVerboseTest):
2019         (ConfigureLoggingVerboseTest._logging_level):
2020         (ConfigureLoggingVerboseTest.test_info_message):
2021         (ConfigureLoggingVerboseTest.test_debug_message):
2022         (ConfigureLoggingCustomLevelTest.test_logged_message):
2023
2024 2012-10-29  Christophe Dumez  <christophe.dumez@intel.com>
2025
2026         [CMAKE] Add TestNetscapePlugIn/Tests/NPRuntimeCallsWithNullNPP.cpp to CMakeLists.txt
2027         https://bugs.webkit.org/show_bug.cgi?id=100681
2028
2029         Reviewed by Anders Carlsson.
2030
2031         Add TestNetscapePlugIn/Tests/NPRuntimeCallsWithNullNPP.cpp to CMake since
2032         it is needed by plugins/npruntime/npruntime-calls-with-null-npp.html
2033         layout test.
2034
2035         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2036
2037 2012-10-29  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2038
2039         [Qt] Flaky security tests
2040         https://bugs.webkit.org/show_bug.cgi?id=100388
2041
2042         Reviewed by Jocelyn Turcotte.
2043
2044         Disable text dumping and load a blank URL to ensure the documentLoader is cleared 
2045         before we start dumping text for the new page. Otherwise messages from the old page
2046         may end up in the text output of the new test.
2047
2048         This matches what WebKitTestRunner does, and reuses the Qt code for waiting for flag.
2049
2050         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2051         (WebCore::DumpRenderTree::DumpRenderTree):
2052         (WebCore::runUntil):
2053         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2054         (WebCore::DumpRenderTree::finishedResetting):
2055         (WebCore::DumpRenderTree::dump):
2056         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2057         (DumpRenderTree):
2058         * DumpRenderTree/qt/TestRunnerQt.cpp:
2059         (TestRunner::resetDumping):
2060         (TestRunner::reset):
2061         * DumpRenderTree/qt/TestRunnerQt.h:
2062         (TestRunner):
2063
2064 2012-10-29  Christophe Dumez  <christophe.dumez@intel.com>
2065
2066         [WK2][WKTR] Enable Shadow DOM at runtime if compiled with SHADOW_DOM support
2067         https://bugs.webkit.org/show_bug.cgi?id=100668
2068
2069         Reviewed by Kenneth Rohde Christiansen.
2070
2071         Enable Shadow DOM functionality at run time in WebKitTestRunner
2072         if compiled with SHADOW_DOM flag set. This is needed to run
2073         the Shadow DOM layout tests.
2074
2075         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2076         (WTR::InjectedBundle::beginTesting):
2077
2078 2012-10-29  Yael Aharon  <yael.aharon@intel.com>
2079
2080         [EFL][AC] Fix bugs preventing us from running layout tests with AC turned on
2081         https://bugs.webkit.org/show_bug.cgi?id=100598
2082
2083         Reviewed by Kenneth Rohde Christiansen.
2084
2085         Make sure to use opengl_x11 engine when AC is turned on and X11 is in use.
2086         We cannot create a gl context otherwise.
2087
2088         * MiniBrowser/efl/main.c:
2089         (elm_main):
2090         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2091         (WTR::initEcoreEvas):
2092         * DumpRenderTree/efl/DumpRenderTree.cpp:
2093         (initEcoreEvas):
2094         * EWebLauncher/efl/main.c:
2095         (windowCreate):
2096
2097 2012-10-29  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2098
2099         [EFL][WK2] REGRESSION(r132342): fast/events/frame-tab-focus.html fails
2100         https://bugs.webkit.org/show_bug.cgi?id=100646
2101
2102         Reviewed by Kenneth Rohde Christiansen.
2103
2104         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2105         (WTR::PlatformWebView::focus): Improve the check we perform to
2106         decide whether the focus should be taken out of the view before
2107         focusing it again so that we do not unnecessarily unfocus it and
2108         cause blur/focus events to be triggered. Instead of just verifying
2109         if the Evas_Object representing the view has focus, use the WK C
2110         API to check that the currently focused frame is not the main
2111         frame.
2112
2113 2012-10-29  Sheriff Bot  <webkit.review.bot@gmail.com>
2114
2115         Unreviewed, rolling out r132782.
2116         http://trac.webkit.org/changeset/132782
2117         https://bugs.webkit.org/show_bug.cgi?id=100653
2118
2119         It made 400+ tests fail and 180 tests flakey on Qt (Requested
2120         by Ossy on #webkit).
2121
2122         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2123         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2124
2125 2012-10-29  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2126
2127         [Qt] Flaky security tests
2128         https://bugs.webkit.org/show_bug.cgi?id=100388
2129
2130         Reviewed by Jocelyn Turcotte.
2131
2132         Disable text output and load a blank URL to ensure the documentLoader is cleared
2133         before we start dumping text for the new page. Otherwise messages from the old page
2134         may end up in the text output of the new test.
2135
2136         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2137         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2138
2139 2012-10-29  Jochen Eisinger  <jochen@chromium.org>
2140
2141         [chromium] remove remaining usages of webkit_support from the TestRunner library
2142         https://bugs.webkit.org/show_bug.cgi?id=100344
2143
2144         Reviewed by Adam Barth.
2145
2146         The most important part is to not rely on calling out to gdk/X11 to
2147         translate keycodes to hardware keycodes, as this is not possible inside
2148         the sandbox.
2149
2150         * DumpRenderTree/DumpRenderTree.gypi:
2151         * DumpRenderTree/chromium/DRTTestRunner.h:
2152         (WebKit):
2153         (webkit_support):
2154         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2155         (WebTestDelegate):
2156         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h:
2157         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
2158         (WebTestRunner):
2159         (WebTestRunner::EventSender::doDragDrop):
2160         (WebTestRunner::EventSender::updateClickCountForButton):
2161         (WebTestRunner::EventSender::mouseDown):
2162         (WebTestRunner::EventSender::mouseUp):
2163         (WebTestRunner::EventSender::mouseMoveTo):
2164         (WebTestRunner::EventSender::keyDown):
2165         (WebTestRunner::EventSender::replaySavedEvents):
2166         (WebTestRunner::EventSender::contextClick):
2167         (WebTestRunner::EventSender::beginDragWithFiles):
2168         (WebTestRunner::EventSender::sendCurrentTouchEvent):
2169         (WebTestRunner::EventSender::handleMouseWheel):
2170         (WebTestRunner::EventSender::gestureEvent):
2171         (WebTestRunner::EventSender::gestureFlingCancel):
2172         (WebTestRunner::EventSender::gestureFlingStart):
2173         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Added.
2174         (WebTestRunner):
2175         (WebTestRunner::NativeKeyCodeForWindowsKeyCode):
2176         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h.
2177         (WebTestRunner):
2178         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
2179         (TestDelegate):
2180         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2181         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2182         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2183         (WebTestInterfaces::Internal):
2184         (WebTestRunner::WebTestInterfaces::Internal::getCurrentTimeInMillisecond):
2185         (WebTestRunner):
2186         (WebTestRunner::WebTestInterfaces::Internal::getAbsoluteWebStringFromUTF8Path):
2187         * DumpRenderTree/chromium/WebViewHost.cpp:
2188         (WebViewHost::getCurrentTimeInMillisecond):
2189         (WebViewHost::getAbsoluteWebStringFromUTF8Path):
2190         * DumpRenderTree/chromium/WebViewHost.h:
2191         (WebViewHost):
2192
2193 2012-10-29  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
2194
2195         Unreviewed. Add jonathan.dong@torchmobile.com.cn as a committer.
2196         https://bugs.webkit.org/show_bug.cgi?id=100629
2197
2198         * Scripts/webkitpy/common/config/committers.py:
2199
2200 2012-10-27  Dan Bernstein  <mitz@apple.com>
2201
2202         REAL_PLATFORM_NAME build setting is no longer needed
2203         https://bugs.webkit.org/show_bug.cgi?id=100587
2204
2205         Reviewed by Mark Rowe.
2206
2207         Removed the definition of REAL_PLATFORM_NAME and replaced references to it with references
2208         to PLATFORM_NAME.
2209
2210         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2211         * DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig:
2212         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2213         * MiniBrowser/Configurations/Base.xcconfig:
2214         * MiniBrowser/Configurations/CompilerVersion.xcconfig:
2215         * TestWebKitAPI/Configurations/Base.xcconfig:
2216         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
2217         * WebKitTestRunner/Configurations/Base.xcconfig:
2218         * WebKitTestRunner/Configurations/CompilerVersion.xcconfig:
2219         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2220
2221 2012-10-26  Anders Carlsson  <andersca@apple.com>
2222
2223         Crash when making NPRuntime calls with a null NPP pointer
2224         https://bugs.webkit.org/show_bug.cgi?id=100569
2225
2226         Reviewed by Darin Adler.
2227
2228         Add new NPRuntimeCallsWithNullNPP plug-in test.
2229
2230         * DumpRenderTree/DumpRenderTree.gypi:
2231         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2232         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2233         (PluginTest::NPN_ReleaseVariantValue):
2234         (PluginTest::netscapeFuncs):
2235         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2236         (PluginTest):
2237         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeCallsWithNullNPP.cpp: Added.
2238         (NPRuntimeCallsWithNullNPP):
2239         (NPRuntimeCallsWithNullNPP::NPRuntimeCallsWithNullNPP):
2240         (NPRuntimeCallsWithNullNPP::NPP_New):
2241         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2242         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2243         * GNUmakefile.am:
2244
2245 2012-10-26  Dominic Mazzoni  <dmazzoni@google.com>
2246
2247         AX: Notification should be sent when accessibilityIsIgnored changes
2248         https://bugs.webkit.org/show_bug.cgi?id=99547
2249
2250         Reviewed by Chris Fleizach.
2251
2252         Add additional accessibility notifications.
2253
2254         * DumpRenderTree/chromium/WebViewHost.cpp:
2255         (WebViewHost::postAccessibilityNotification):
2256
2257 2012-10-25  Roger Fong  <roger_fong@apple.com>
2258
2259         Get rid of (<X%) failing output for old-run-webkit-tests.
2260         https://bugs.webkit.org/show_bug.cgi?id=100447
2261
2262         Reviewed by Jessie Berlin.
2263
2264         Not a particularly useful piece of information. It's pretty much never above 1%.
2265         new-run-webkit-tests does not output this either.
2266
2267         * Scripts/old-run-webkit-tests:
2268         (printResults):
2269
2270 2012-10-26  Xianzhu Wang  <wangxianzhu@chromium.org>
2271
2272         Build bot gives incorrect link to EWS build failure
2273         https://bugs.webkit.org/show_bug.cgi?id=100436
2274
2275         Reviewed by Adam Barth.
2276
2277         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2278         (MockCommitQueue.__init__):
2279         (MockCommitQueue.command_failed): Return incremental failure_status_id
2280         (CommitQueueTaskTest.test_red_tree_patch_rejection): Check failure_status_id
2281         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2282         (PatchAnalysisTask._test_patch): Use the failure_status_id of test with patch when test without patch fails and test with patch has unexpected failures.
2283
2284 2012-10-26  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2285
2286         webkitpy: Pass the `Listen' Apache directive from webkitpy, not the httpd.conf files.
2287         https://bugs.webkit.org/show_bug.cgi?id=98602
2288
2289         Reviewed by Dirk Pranke.
2290
2291         Unify all the different `Listen' directives present in the several
2292         httpd.conf files we have in LayoutTests/http/conf. For one, we
2293         were already passing `Listen 127.0.0.1:8000' via webkitpy before,
2294         and opening the other ports from the conf files.
2295
2296         The configuration files differed mostly in the way they handled
2297         IPV6 ports. Some of them did not listen to IPV6 ports because the
2298         systems which used them sometimes did not have IPV6 support. The
2299         `http_server_supports_ipv6' method has been added to Port to
2300         address that. cygwin, on its turn, still seems to use Apache 1.3,
2301         which does not support IPV6 at all; the newly-added method has a
2302         special case for that. Plus, perform a socket.getaddrinfo() call
2303         the same way Apache itself does so we are sure we only enable IPV6
2304         when setting that up in the httpd server is not going to fail.
2305
2306         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2307         (MockPlatformInfo.is_cygwin):
2308         * Scripts/webkitpy/layout_tests/port/base.py:
2309         (Port.baseline_version_dir):
2310         (Port.to.start_websocket_server):
2311         (Port.to):
2312         (Port.to.http_server_supports_ipv6):
2313         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2314         (PortTest.test_http_server_supports_ipv6):
2315         (PortTest.test_build_path):
2316         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2317         (LayoutTestApacheHttpd):
2318         (LayoutTestApacheHttpd.__init__):
2319
2320 2012-10-26  David Barton  <dbarton@mathscribe.com>
2321
2322         Unreviewed. Update my IRC nickname to a registered one.
2323
2324         * Scripts/webkitpy/common/config/committers.py:
2325
2326 2012-10-26  Simon Hausmann  <simon.hausmann@digia.com>
2327
2328         [Qt] Fix the LLInt build on Windows
2329         https://bugs.webkit.org/show_bug.cgi?id=97648
2330
2331         Reviewed by Tor Arne Vestbø.
2332
2333         Added BIN_EXTENSION variable - similar to automake - that expands to .exe as suffix for
2334         executable programs on Windows. Empty otherwise. Also added support for force_build_all
2335         to allow overriding us disabling build_all for TEMPLATE = app.
2336
2337         * qmake/mkspecs/features/default_pre.prf:
2338
2339 2012-10-26  Xiaobo Wang  <xbwang@torchmobile.com.cn>
2340
2341         [BlackBerry] Support pixel tests for BlackBerry DRT
2342         https://bugs.webkit.org/show_bug.cgi?id=100210
2343
2344         Reviewed by Rob Buis.
2345
2346         (The following 2 files are missed in previous patch(r132582), adding them
2347         again.)
2348
2349         * DumpRenderTree/blackberry/build: Added.
2350         * DumpRenderTree/blackberry/src.pro: Added.
2351         Adds 2 files for building ImageDiff, by Christopher Wells.
2352
2353 2012-10-26  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2354
2355         Add feature flags for CSS Device Adaptation
2356         https://bugs.webkit.org/show_bug.cgi?id=95960
2357
2358         Reviewed by Kenneth Rohde Christiansen.
2359
2360         * Scripts/webkitperl/FeatureList.pm:
2361
2362 2012-10-26  Sheriff Bot  <webkit.review.bot@gmail.com>
2363
2364         Unreviewed, rolling out r132552.
2365         http://trac.webkit.org/changeset/132552
2366         https://bugs.webkit.org/show_bug.cgi?id=100486
2367
2368         Makes typeahead tests crash in debug. (Requested by pfeldman
2369         on #webkit).
2370
2371         * DumpRenderTree/DumpRenderTree.gypi:
2372         * DumpRenderTree/chromium/DRTTestRunner.h:
2373         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2374         (WebTestDelegate):
2375         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h:
2376         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
2377         (WebTestRunner):
2378         (WebTestRunner::EventSender::doDragDrop):
2379         (WebTestRunner::EventSender::updateClickCountForButton):
2380         (WebTestRunner::EventSender::mouseDown):
2381         (WebTestRunner::EventSender::mouseUp):
2382         (WebTestRunner::EventSender::mouseMoveTo):
2383         (WebTestRunner::EventSender::keyDown):
2384         (WebTestRunner::EventSender::replaySavedEvents):
2385         (WebTestRunner::EventSender::contextClick):
2386         (WebTestRunner::EventSender::beginDragWithFiles):
2387         (WebTestRunner::EventSender::sendCurrentTouchEvent):
2388         (WebTestRunner::EventSender::handleMouseWheel):
2389         (WebTestRunner::EventSender::gestureEvent):
2390         (WebTestRunner::EventSender::gestureFlingCancel):
2391         (WebTestRunner::EventSender::gestureFlingStart):
2392         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
2393         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
2394         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
2395         (TestDelegate):
2396         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2397         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2398         (WebKit):
2399         (webkit_support):
2400         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2401         (WebTestInterfaces::Internal):
2402         * DumpRenderTree/chromium/WebViewHost.cpp:
2403         * DumpRenderTree/chromium/WebViewHost.h:
2404         (WebViewHost):
2405
2406 2012-10-26  Xiaobo Wang  <xbwang@torchmobile.com.cn>
2407
2408         [BlackBerry] Support pixel tests for BlackBerry DRT
2409         https://bugs.webkit.org/show_bug.cgi?id=100210
2410
2411         Reviewed by Rob Buis.
2412
2413         The implementation is based on the patch from Christopher Wells.
2414
2415         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2416         (BlackBerry::WebKit::DumpRenderTree::DumpRenderTree):
2417         (BlackBerry::WebKit::DumpRenderTree::runTest):
2418         (BlackBerry::WebKit::DumpRenderTree::runCurrentTest):
2419         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
2420         (BlackBerry::WebKit::DumpRenderTree::runTests):
2421         (BlackBerry::WebKit::DumpRenderTree::dump):
2422         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
2423         (DumpRenderTree):
2424
2425         * DumpRenderTree/blackberry/PNGImageEncoder.cpp:
2426         (BGRAtoRGBA):
2427         (encodeBitmapToPNG):
2428         * DumpRenderTree/blackberry/PNGImageEncoder.h:
2429         The changes to PNGImageEncoder files are from master_40, patched by Tyler
2430         Abbott and Rob Buis.
2431
2432         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
2433         (createBitmapContextFromWebView):
2434         (computeMD5HashStringForBitmapContext):
2435         (printPNG):
2436         (dumpBitmap):
2437         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.h:
2438         (BitmapContext::createByAdoptingData):
2439         (BitmapContext::~BitmapContext):
2440         (BitmapContext):
2441         (BitmapContext::BitmapContext):
2442
2443         * DumpRenderTree/blackberry/build: Added.
2444         * DumpRenderTree/blackberry/src.pro: Added.
2445         Adds 2 files for building ImageDiff, by Christopher Wells.
2446
2447 2012-10-25  Min Qin  <qinmin@chromium.org>
2448
2449         Fix a layout test crash if a TestWebkitPlugin is put inside an iframe
2450         https://bugs.webkit.org/show_bug.cgi?id=100406
2451
2452         Reviewed by Adam Barth.
2453
2454         Resize the context with an empty rect will cause a gl_error in gles2_cmd_decoder.cc.
2455         Don't paint the plugin if m_rect is empty.
2456
2457         * DumpRenderTree/chromium/TestWebPlugin.cpp:
2458         (TestWebPlugin::updateGeometry):
2459
2460 2012-10-25  Jinwoo Song  <jinwoo7.song@samsung.com>
2461
2462         [EFL][WK2] Display tooltip in MiniBrowser
2463         https://bugs.webkit.org/show_bug.cgi?id=99322
2464
2465         Reviewed by Kenneth Rohde Christiansen.
2466
2467         Display tooltip in MiniBrowser using elm_object_tooltip_text_set().
2468
2469         * MiniBrowser/efl/main.c:
2470         (on_tooltip_text_set):
2471         (on_tooltip_text_unset):
2472         (window_create):
2473
2474 2012-10-25  Jochen Eisinger  <jochen@chromium.org>
2475
2476         [chromium] remove remaining usages of webkit_support from the TestRunner library
2477         https://bugs.webkit.org/show_bug.cgi?id=100344
2478
2479         Reviewed by Adam Barth.
2480
2481         The most important part is to not rely on calling out to gdk/X11 to
2482         translate keycodes to hardware keycodes, as this is not possible inside
2483         the sandbox.
2484
2485         * DumpRenderTree/DumpRenderTree.gypi:
2486         * DumpRenderTree/chromium/DRTTestRunner.h:
2487         (WebKit):
2488         (webkit_support):
2489         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2490         (WebTestDelegate):
2491         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h:
2492         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
2493         (WebTestRunner):
2494         (WebTestRunner::EventSender::doDragDrop):
2495         (WebTestRunner::EventSender::updateClickCountForButton):
2496         (WebTestRunner::EventSender::mouseDown):
2497         (WebTestRunner::EventSender::mouseUp):
2498         (WebTestRunner::EventSender::mouseMoveTo):
2499         (WebTestRunner::EventSender::keyDown):
2500         (WebTestRunner::EventSender::replaySavedEvents):
2501         (WebTestRunner::EventSender::contextClick):
2502         (WebTestRunner::EventSender::beginDragWithFiles):
2503         (WebTestRunner::EventSender::sendCurrentTouchEvent):
2504         (WebTestRunner::EventSender::handleMouseWheel):
2505         (WebTestRunner::EventSender::gestureEvent):
2506         (WebTestRunner::EventSender::gestureFlingCancel):
2507         (WebTestRunner::EventSender::gestureFlingStart):
2508         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Added.
2509         (WebTestRunner):
2510         (WebTestRunner::NativeKeyCodeForWindowsKeyCode):
2511         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h.
2512         (WebTestRunner):
2513         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
2514         (TestDelegate):
2515         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2516         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2517         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2518         (WebTestInterfaces::Internal):
2519         (WebTestRunner::WebTestInterfaces::Internal::getCurrentTimeInMillisecond):
2520         (WebTestRunner):
2521         (WebTestRunner::WebTestInterfaces::Internal::getAbsoluteWebStringFromUTF8Path):
2522         * DumpRenderTree/chromium/WebViewHost.cpp:
2523         (WebViewHost::getCurrentTimeInMillisecond):
2524         (WebViewHost::getAbsoluteWebStringFromUTF8Path):
2525         * DumpRenderTree/chromium/WebViewHost.h:
2526         (WebViewHost):
2527
2528 2012-10-25  Sheriff Bot  <webkit.review.bot@gmail.com>
2529
2530         Unreviewed, rolling out r132514.
2531         http://trac.webkit.org/changeset/132514
2532         https://bugs.webkit.org/show_bug.cgi?id=100440
2533
2534         "Broke chromium content_browsertests AccessibilityAriaMenu
2535         AccessibilityInputRange AccessibilityListMarkers" (Requested
2536         by scheib on #webkit).
2537
2538         * DumpRenderTree/chromium/WebViewHost.cpp:
2539         (WebViewHost::postAccessibilityNotification):
2540
2541 2012-10-25  Dirk Pranke  <dpranke@chromium.org>
2542
2543         rwt --lint-test-files doesn't handle the cascade properly
2544         https://bugs.webkit.org/show_bug.cgi?id=100315
2545
2546         Reviewed by Ojan Vafai.
2547
2548         We were only linting the first file in each port's list of
2549         expectations.
2550
2551         This change pushes more of the logic for linting files into
2552         the TestExpectations classes themselves, but it's still a bit of
2553         a hack. A better solution will require splitting out the actual
2554         parsing of the files from the TestExpectations constructor.
2555
2556         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2557         (TestExpectations):
2558         (TestExpectations.__init__):
2559         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2560         (parse_exp):
2561         (SkippedTests.check):
2562         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2563         (lint):
2564         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2565         (LintTest.test_all_configurations.FakePort.__init__):
2566         (LintTest.test_all_configurations):
2567         (LintTest.test_lint_test_files__errors):
2568         * Scripts/webkitpy/style/checkers/test_expectations.py:
2569         (TestExpectationsChecker.check_test_expectations):
2570
2571 2012-10-25  Zan Dobersek  <zandobersek@gmail.com>
2572
2573         Unreviewed GTK gardening.
2574
2575         Skipping the atspi-basic-hierarchy test case in the TestWebKitAccessibility
2576         WebKit2 API test since the test is currently failing.
2577
2578         * Scripts/run-gtk-tests:
2579         (TestRunner):
2580
2581 2012-10-25  Dominic Mazzoni  <dmazzoni@google.com>
2582
2583         AX: Notification should be sent when accessibilityIsIgnored changes
2584         https://bugs.webkit.org/show_bug.cgi?id=99547
2585
2586         Reviewed by Chris Fleizach.
2587
2588         Add additional accessibility notifications.
2589
2590         * DumpRenderTree/chromium/WebViewHost.cpp:
2591         (WebViewHost::postAccessibilityNotification):
2592
2593 2012-10-25  Dominik Röttsches  <dominik.rottsches@intel.com>
2594
2595         Conditionalize XHR timeout support
2596         https://bugs.webkit.org/show_bug.cgi?id=100356
2597
2598         Reviewed by Adam Barth.
2599
2600         Adding XHR_TIMEOUT feature in perl and qmake files.
2601
2602         * Scripts/webkitperl/FeatureList.pm:
2603         * qmake/mkspecs/features/features.pri:
2604
2605 2012-10-25  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2606
2607         Unreviewed. Update my contact info.
2608
2609         * Scripts/webkitpy/common/config/committers.py:
2610
2611 2012-10-25  Terry Anderson  <tdanderson@chromium.org>
2612
2613         Unreviewed. Adding myself as a committer.
2614
2615         * Scripts/webkitpy/common/config/committers.py:
2616
2617 2012-10-25  Zeno Albisser  <zeno@webkit.org>
2618
2619         [Qt] Adjust library name in webkitdirs.pm after r131300.
2620         https://bugs.webkit.org/show_bug.cgi?id=100376
2621
2622         The library was renamed from QtWebKit to QtWebKitWidgets.
2623         run-launcher was still looking for QtWebKit.
2624
2625         Reviewed by Simon Hausmann.
2626
2627         * Scripts/webkitdirs.pm:
2628         (builtDylibPathForName):
2629
2630 2012-10-22  Mikhail Naganov  <mnaganov@chromium.org>
2631
2632         [Chromium] Add supportMultipleWindows setting, needed for Android
2633         https://bugs.webkit.org/show_bug.cgi?id=99716
2634
2635         Reviewed by Adam Barth.
2636
2637         Add supportMultipleWindows settings for reusing the same view when
2638         opening popups. This is required for emulating the behavior of
2639         Android WebView. Adding into WebCore, as other ports might want to
2640         use this setting in the future.
2641
2642         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2643         (DRTTestRunner::overridePreference):
2644         * DumpRenderTree/chromium/WebPreferences.cpp:
2645         (WebPreferences::reset):
2646         (WebPreferences::applyTo):
2647         * DumpRenderTree/chromium/WebPreferences.h:
2648         (WebPreferences):
2649
2650 2012-10-25  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2651
2652         [EFL][WK2] JavaScript popups are not focused when opened
2653         https://bugs.webkit.org/show_bug.cgi?id=100354
2654
2655         Reviewed by Kenneth Rohde Christiansen.
2656
2657         Move focus to the JavaScript popups when opened so that the key events
2658         are forwarded to the popups instead of web view.
2659
2660         * MiniBrowser/efl/main.c:
2661         (on_javascript_alert):
2662         (on_javascript_confirm):
2663         (on_javascript_prompt):
2664
2665 2012-10-25  Eugene Klyuchnikov  <eustas.bug@gmail.com>
2666
2667         Web Inspector: Fix "check-inspector-strings" script and fix localized strings.
2668         https://bugs.webkit.org/show_bug.cgi?id=100090
2669
2670         Reviewed by Vsevolod Vlasov.
2671
2672         Script "check-inspector-strings" seems to be broken.
2673         Fixed it, refined search algorithm.
2674
2675         * Scripts/check-inspector-strings: Fixed and refined.
2676
2677 2012-10-24  Dirk Pranke  <dpranke@chromium.org>
2678
2679         nrwt: fix a couple of minor crashing issues under cygwin
2680         https://bugs.webkit.org/show_bug.cgi?id=100309
2681
2682         Reviewed by Ojan Vafai.
2683
2684         Cygwin was crashing on a null object reference and then
2685         an oserror in kill().
2686
2687         * Scripts/webkitpy/common/system/executive.py:
2688         (Executive.kill_process):
2689         * Scripts/webkitpy/layout_tests/port/server_process.py:
2690         (ServerProcess.stop):
2691
2692 2012-10-24  Dirk Pranke  <dpranke@chromium.org>
2693
2694         nrwt: truncate meter lines properly on windows
2695         https://bugs.webkit.org/show_bug.cgi?id=100062
2696
2697         Reviewed by Tony Chang.
2698
2699         This change adds the code to figure out the terminal width
2700         on windows (it was already there for Unixen) and moves it
2701         to a platform-specific object.
2702
2703         * Scripts/webkitpy/common/system/platforminfo.py:
2704         (PlatformInfo.terminal_width):
2705         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2706         (MockPlatformInfo.total_bytes_memory):
2707         (MockPlatformInfo):
2708         (MockPlatformInfo.terminal_width):
2709         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
2710         (MeteredStream.__init__):
2711         (MeteredStream.number_of_columns):
2712         (MeteredStream.flush):
2713         * Scripts/webkitpy/layout_tests/views/printing.py:
2714         (Printer.__init__):
2715         (Printer._test_status_line):
2716
2717 2012-10-24  Dirk Pranke  <dpranke@chromium.org>
2718
2719         tweak debug logging in webkit-patch optimize-baselines
2720         https://bugs.webkit.org/show_bug.cgi?id=100294
2721
2722         Reviewed by Ojan Vafai.
2723
2724         This changes the logging to print out the baselines found
2725         (and their checksums) even when we don't do anything.
2726
2727         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
2728         (BaselineOptimizer.optimize):
2729
2730 2012-10-24  Sailesh Agrawal  <sail@chromium.org>
2731
2732         Incorrect keycodes for numpad /, -, +, .
2733         https://bugs.webkit.org/show_bug.cgi?id=99188
2734
2735         Reviewed by Tony Chang.
2736
2737         Add key mappings for all numpad keys.
2738
2739         * DumpRenderTree/mac/EventSendingController.mm:
2740         (KeyMappingEntry):
2741         (-[EventSendingController keyDown:withModifiers:withLocation:]): Added all numpad keys.
2742
2743 2012-10-24  Dirk Pranke  <dpranke@chromium.org>
2744
2745         webkitpy: clean up references to Skipped files
2746         https://bugs.webkit.org/show_bug.cgi?id=100045
2747
2748         Reviewed by Ojan Vafai.
2749
2750         Since they are no longer used or needed ...
2751
2752         * Scripts/webkitpy/layout_tests/port/apple.py:
2753         (ApplePort._generate_all_test_configurations):
2754         * Scripts/webkitpy/layout_tests/port/base.py:
2755         (Port.skipped_layout_tests):
2756         (Port.expectations_files):
2757         (Port._wk2_port_name):
2758         * Scripts/webkitpy/layout_tests/port/gtk.py:
2759         (GtkPort):
2760         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2761         (MacTest.test_default_timeout_ms):
2762         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2763         (test_expectations_files):
2764         (test_expectations_files.platform_dirs):
2765         * Scripts/webkitpy/layout_tests/port/qt.py:
2766         (QtPort.__init__):
2767
2768 2012-10-24  Jochen Eisinger  <jochen@chromium.org>
2769
2770         [chromium] Use include paths relative to Source/ in the TestRunner's public API
2771         https://bugs.webkit.org/show_bug.cgi?id=100079
2772
2773         Reviewed by Adam Barth.
2774
2775         For a inside-chromium build, we usually don't add the WebKit API paths
2776         as include paths, so including files by name only does not work.
2777
2778         Eventually we might want to move to a model where all includes are
2779         relative to Source/, so we're using that here already now.
2780
2781         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2782         * DumpRenderTree/chromium/TestRunner/public/WebEventSender.h:
2783         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2784
2785 2012-10-24  Ojan Vafai  <ojan@chromium.org>
2786
2787         Show an error when there are no completed builds in the past 20 runs
2788         https://bugs.webkit.org/show_bug.cgi?id=100266
2789
2790         Reviewed by Dimitri Glazkov.
2791
2792         Right now we get a cryptic JS error in the console when loading the gtk port. This at least gives an error in
2793         the notification stream. We should probably tweak this UI to make it so we can make
2794         errors in the notification stream stick out (e.g. make the text red).
2795
2796         We should also consider making the number of runs to load dynamic (e.g. if 20 runs don't work,
2797         try 40).
2798
2799         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
2800         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
2801         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
2802
2803 2012-10-24  Ian Vollick  <vollick@chromium.org>
2804
2805         [chromium] Explicitly disable accelerated animations in DRT
2806         https://bugs.webkit.org/show_bug.cgi?id=100241
2807
2808         Reviewed by Adrienne Walker.
2809
2810         Disable accelerated animations by default in DRT.        
2811
2812         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2813         (main):
2814         * DumpRenderTree/chromium/TestShell.cpp:
2815         (TestShell::setAcceleratedAnimationEnabled):
2816         * DumpRenderTree/chromium/TestShell.h:
2817         (TestShell):
2818
2819 2012-10-24  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
2820
2821         [Qt] Move the QQuickWebViewExperimental pointer to QQuickWebViewPrivate
2822         https://bugs.webkit.org/show_bug.cgi?id=100253
2823
2824         Reviewed by Kenneth Rohde Christiansen.
2825
2826         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2827         (WTR::WrapperWindow::handleStatusChanged):
2828         Use QQuickWebView::experimental rather than creating a new instance.
2829
2830 2012-10-24  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2831
2832         [EFL] run-webkit-tests writes garbage on stderr when running on Xvfb
2833         https://bugs.webkit.org/show_bug.cgi?id=100243
2834
2835         Reviewed by Kenneth Rohde Christiansen.
2836
2837         These errors generate noise on the reports and in some cases, like when
2838         running perf tests, makes the test fail. By using Xext, we can add a
2839         dummy handler to ignore these errors.
2840
2841         We could have added this handler on the top level EWK API, but that
2842         would be intrusive and could override handlers defined by the user.
2843
2844         * WebKitTestRunner/PlatformEfl.cmake:
2845         * WebKitTestRunner/efl/main.cpp:
2846         (dummyExtensionErrorHandler):
2847         (main):
2848
2849 2012-10-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2850
2851         Unreviewed. Fix the GTK+ build.
2852
2853         * TestWebKitAPI/GNUmakefile.am: Add GTK_FLAGS to
2854         libTestWebKitAPIMain and webcore cflags to TestGtk.
2855
2856 2012-10-24  Zeno Albisser  <zeno@webkit.org>
2857
2858         Implement GraphicsSurface for Windows.
2859         https://bugs.webkit.org/show_bug.cgi?id=98147
2860
2861         Reviewed by Kenneth Rohde Christiansen.
2862
2863         * qmake/mkspecs/features/features.prf:
2864                 Activate GraphicsSurface on windows in case opengles2 (ANGLE)
2865                 is available in QT_CONFIG.
2866
2867 2012-10-24  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2868
2869         [EFL][WK2] fast/repaint/delete-into-nested-block.html and fast/repaint/4776765.html are flaky
2870         https://bugs.webkit.org/show_bug.cgi?id=100010
2871
2872         Reviewed by Kenneth Rohde Christiansen.
2873
2874         Force the main view to receive focus even if Evas already
2875         considers it to be focused.
2876
2877         It might happen that a different frame is focused by a page and
2878         the focus change notification does not reach Evas. When another
2879         test is run, the main frame is then not considered to be focused
2880         by WebCore, and things such as focus rings are not drawn as
2881         expected.
2882
2883         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2884         (WTR::PlatformWebView::focus):
2885
2886 2012-10-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2887
2888         Unreviewed, rolling out r132333.
2889         http://trac.webkit.org/changeset/132333
2890         https://bugs.webkit.org/show_bug.cgi?id=100234
2891
2892         Crashes many tests on the EFL-WK2 bot. (Requested by rakuco on
2893         #webkit).
2894
2895         * WebKitTestRunner/TestController.cpp:
2896         (WTR::TestController::resetStateToConsistentValues):
2897         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2898         (WTR::TestController::platformInitializeContext):
2899
2900 2012-10-24  Dongwoo Joshua Im  <dw.im@samsung.com>
2901
2902         [GTK] Fix build break - undefined reference to 'gtk_init'
2903         https://bugs.webkit.org/show_bug.cgi?id=100221
2904
2905         Unreviewed build fix.
2906
2907         GTK_LIBS is needed for TestWTF.
2908
2909         * TestWebKitAPI/GNUmakefile.am:
2910
2911 2012-10-24  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
2912
2913         WebKitTestRunner needs to turn on 'setContinuousSpellCheckingEnabled'
2914         https://bugs.webkit.org/show_bug.cgi?id=93611
2915
2916         Reviewed by Hajime Morita.
2917
2918         WebKitTestRunner enables spelling feature to pass the layout tests from editing/spelling.
2919
2920         * WebKitTestRunner/TestController.cpp:
2921         (WTR::TestController::resetStateToConsistentValues):
2922         Enables spelling by WebKit2 C API.
2923
2924         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2925         (WTR::TestController::platformInitializeContext):
2926         Attaches WKTextChecker's client and sets default language for WebKit2-EFL port.
2927
2928 2012-10-24  Mario Sanchez Prada  <mario@webkit.org>
2929
2930         [WK2] [GTK] TestWebKitAccessibility is not being run
2931         https://bugs.webkit.org/show_bug.cgi?id=100102
2932
2933         Reviewed by Carlos Garcia Campos.
2934
2935         Removed wrong early return in _start_accessibility_daemons().
2936
2937         * Scripts/run-gtk-tests:
2938         (TestRunner._lookup_atspi2_binary): Removed wrong line.
2939
2940 2012-10-24  Noel Gordon  <noel.gordon@gmail.com>
2941
2942         [chromium] Plumb DRT WebkitShouldRespectImageOrientation through to page settings 
2943         https://bugs.webkit.org/show_bug.cgi?id=100197
2944
2945         Reviewed by Kent Tamura.
2946
2947         fast/images/exif-orientation.html and fast/images/exif-orientation-css.html require a DRT
2948         WebkitShouldRespectImageOrientation preference.  Add the chromium implementation for this
2949         preference and plumb it through to page settings.
2950
2951         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2952         (DRTTestRunner::overridePreference): Update the tests WebkitShouldRespectImageOrientation
2953         setting in DRT prefs.
2954         * DumpRenderTree/chromium/WebPreferences.cpp:
2955         (WebPreferences::reset): Disable the preference before and after each test.
2956         (WebPreferences::applyTo): Apply the preference to the page settings of each test.
2957         * DumpRenderTree/chromium/WebPreferences.h:
2958         (WebPreferences):
2959
2960 2012-10-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2961
2962         [GTK] TestWebKitAPI/TestWebKit2 and TestWebKitAPI/TestGtk link to the installed libs
2963         https://bugs.webkit.org/show_bug.cgi?id=100134
2964
2965         Reviewed by Martin Robinson.
2966
2967         Do not share the LDADD variable among TestWTF, TestWebKit2 and
2968         TestGtk.
2969
2970         * TestWebKitAPI/GNUmakefile.am:
2971
2972 2012-10-23  Kihong Kwon  <kihong.kwon@samsung.com>
2973
2974         Unreviewed. Adding myself as committer.
2975
2976         * Scripts/webkitpy/common/config/committers.py:
2977
2978 2012-10-23  Dan Bernstein  <mitz@apple.com>
2979
2980         Tools changes for <rdar://problem/2966974> [mac] Kerning and ligatures are not enabled by default
2981         https://bugs.webkit.org/show_bug.cgi?id=100188
2982
2983         Reviewed by Sam Weinig.
2984
2985         Disable kerning and ligatures by default when running the tests.
2986
2987         * DumpRenderTree/mac/DumpRenderTree.mm:
2988         (resetDefaultsToConsistentValues): Set a value of NO for the
2989         WebKitKerningAndLigaturesEnabledByDefault user default.
2990         * WebKitTestRunner/mac/main.mm:
2991         (main): Register a value of NO for the WebKitKerningAndLigaturesEnabledByDefault user
2992         default.
2993
2994 2012-10-23  Simon Fraser  <simon.fraser@apple.com>
2995
2996         Allow tests to run with a tile cache, and optionally dump the tile cache via layerTreeAsText()
2997         https://bugs.webkit.org/show_bug.cgi?id=100159
2998
2999         Reviewed by Tim Horton.
3000
3001         Make WebKitTestRunner use a WKView with a tile cache for tests run in a directory
3002         whose path includes "tiled-drawing". It does this by passing around a WKDictionary 
3003         of options, and if the current PlatformWebView doesn't support those options, it will
3004         create a new one.
3005
3006         * WebKitTestRunner/PlatformWebView.h:
3007         (PlatformWebView): Add a WKDictionaryRef options dictionary argument.
3008         (WTR::PlatformWebView::viewSupportsOptions): Returns true if the view
3009         supports the options in the WKDictionaryRef.
3010         * WebKitTestRunner/TestController.cpp:
3011         (WTR::TestController::initialize): Call createWebViewWithOptions() with
3012         no options in the normal case.
3013         (WTR::TestController::createWebViewWithOptions): Moved code into this fuction
3014         so we can call it in two places.
3015         (WTR::TestController::ensureViewSupportsOptions): If the current view
3016         doesn't support the given options, throw it away and makea  new one that does.
3017         * WebKitTestRunner/TestController.h:
3018         * WebKitTestRunner/TestInvocation.cpp:
3019         (WTR::shouldUseTiledDrawing): Return true if the directory contains "tiled-drawing".
3020         (WTR::updateTiledDrawingForCurrentTest): Tell the TestController to check whether
3021         the view supports the given options. No-op for non-Mac platforms.
3022         (WTR::TestInvocation::invoke): Call updateTiledDrawingForCurrentTest().
3023         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3024         (WTR::PlatformWebView::PlatformWebView): New constructor parameter.
3025         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3026         (WTR::PlatformWebView::PlatformWebView):  New constructor parameter.
3027         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3028         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:useTiledDrawing:]):
3029         (-[TestRunnerWKView _shouldUseTiledDrawingArea]): Subclass the WKView so we can return
3030         a custom value from this method.
3031         (WTR::PlatformWebView::PlatformWebView):
3032         (WTR::PlatformWebView::viewSupportsOptions):
3033         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3034         (WTR::PlatformWebView::PlatformWebView): New constructor parameter.
3035         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3036         (WTR::PlatformWebView::PlatformWebView): New constructor parameter.
3037
3038 2012-10-23  Sheriff Bot  <webkit.review.bot@gmail.com>
3039
3040         Unreviewed, rolling out r132276.
3041         http://trac.webkit.org/changeset/132276
3042         https://bugs.webkit.org/show_bug.cgi?id=100189
3043
3044         It broke the Qt-WK2 build intentionally (Requested by
3045         Ossy_night on #webkit).
3046
3047         * WebKitTestRunner/PlatformWebView.h:
3048         (PlatformWebView):
3049         * WebKitTestRunner/TestController.cpp:
3050         (WTR::TestController::initialize):
3051         * WebKitTestRunner/TestController.h:
3052         (TestController):
3053         * WebKitTestRunner/TestInvocation.cpp:
3054         (WTR):
3055         (WTR::TestInvocation::invoke):
3056         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3057         (WTR::PlatformWebView::PlatformWebView):
3058         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3059         (WTR::PlatformWebView::PlatformWebView):
3060         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3061         (WTR::PlatformWebView::PlatformWebView):
3062         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3063         (WTR::PlatformWebView::PlatformWebView):
3064         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3065         (WTR::PlatformWebView::PlatformWebView):
3066
3067 2012-10-23  Martin Robinson  <mrobinson@igalia.com>
3068
3069         [GTK][Soup] Implement the default authentication dialog via WebCoreSupport
3070         https://bugs.webkit.org/show_bug.cgi?id=99351
3071
3072         Reviewed by Carlos Garcia Campos.
3073
3074         We no longer need to turn off the soup authentication dialog soup feature,
3075         because it's not installed.
3076
3077         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3078         (setDefaultsToConsistentStateValuesForTesting): Don't turn off the feature any longer.
3079
3080 2012-10-23  Simon Fraser  <simon.fraser@apple.com>
3081
3082         Allow tests to run with a tile cache, and optionally dump the tile cache via layerTreeAsText()
3083         https://bugs.webkit.org/show_bug.cgi?id=100159
3084
3085         Reviewed by Tim Horton.
3086
3087         Make WebKitTestRunner use a WKView with a tile cache for tests run in a directory
3088         whose path includes "tiled-drawing". It does this by passing around a WKDictionary 
3089         of options, and if the current PlatformWebView doesn't support those options, it will
3090         create a new one.
3091
3092         * WebKitTestRunner/PlatformWebView.h:
3093         (PlatformWebView): Add a WKDictionaryRef options dictionary argument.
3094         (WTR::PlatformWebView::viewSupportsOptions): Returns true if the view
3095         supports the options in the WKDictionaryRef.
3096         * WebKitTestRunner/TestController.cpp:
3097         (WTR::TestController::initialize): Call createWebViewWithOptions() with
3098         no options in the normal case.
3099         (WTR::TestController::createWebViewWithOptions): Moved code into this fuction
3100         so we can call it in two places.
3101         (WTR::TestController::ensureViewSupportsOptions): If the current view
3102         doesn't support the given options, throw it away and makea  new one that does.
3103         * WebKitTestRunner/TestController.h:
3104         * WebKitTestRunner/TestInvocation.cpp:
3105         (WTR::shouldUseTiledDrawing): Return true if the directory contains "tiled-drawing".
3106         (WTR::updateTiledDrawingForCurrentTest): Tell the TestController to check whether
3107         the view supports the given options. No-op for non-Mac platforms.
3108         (WTR::TestInvocation::invoke): Call updateTiledDrawingForCurrentTest().
3109         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3110         (WTR::PlatformWebView::PlatformWebView): New constructor parameter.
3111         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3112         (WTR::PlatformWebView::PlatformWebView):  New constructor parameter.
3113         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3114         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:useTiledDrawing:]):
3115         (-[TestRunnerWKView _shouldUseTiledDrawingArea]): Subclass the WKView so we can return
3116         a custom value from this method.
3117         (WTR::PlatformWebView::PlatformWebView):
3118         (WTR::PlatformWebView::viewSupportsOptions):
3119         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3120         (WTR::PlatformWebView::PlatformWebView): New constructor parameter.
3121         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3122         (WTR::PlatformWebView::PlatformWebView): New constructor parameter.
3123
3124 2012-10-23  David Barton  <dbarton@mathscribe.com>
3125
3126         [MathML] Symbol font uses greek letters for roman ones on linux and Windows
3127         https://bugs.webkit.org/show_bug.cgi?id=99921
3128
3129         Reviewed by Eric Seidel.
3130
3131         Enable the STIXSizeOneSym font for testing.
3132
3133         * DumpRenderTree/mac/DumpRenderTree.mm:
3134         (allowedFontFamilySet):
3135         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3136         (WTR::allowedFontFamilySet):
3137
3138 2012-10-23  Tony Chang  <tony@chromium.org>
3139
3140         [chromium] Chromium window build system does not rebuild correctly when enabling/disabling a feature
3141         https://bugs.webkit.org/show_bug.cgi?id=38926
3142
3143         Reviewed by Eric Seidel.
3144
3145         Remove hack for clobbering build when features.gypi changes. Now that
3146         Chromium requires VS2010 or newer, this bug has gone away.
3147
3148         * Scripts/update-webkit:
3149
3150 2012-10-23  Jochen Eisinger  <jochen@chromium.org>
3151
3152         [chromium] remove the const qualifier from WebTestDelegate::printMessage
3153         https://bugs.webkit.org/show_bug.cgi?id=100082
3154
3155         Reviewed by Adam Barth.
3156
3157         There's no reason the method should be const, and indeed for
3158         content_shell we want to send an IPC which is a non-const operation.
3159
3160         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3161         (WebTestDelegate):
3162         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
3163         (TestDelegate):
3164         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3165         (WebTestInterfaces::Internal):
3166         (WebTestRunner::WebTestInterfaces::Internal::printMessage):
3167         * DumpRenderTree/chromium/WebViewHost.cpp:
3168         (WebViewHost::printMessage):
3169         * DumpRenderTree/chromium/WebViewHost.h:
3170         (WebViewHost):
3171
3172 2012-10-23  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3173
3174         Add support for resolution media query
3175         https://bugs.webkit.org/show_bug.cgi?id=99077
3176
3177         Reviewed by Antti Koivisto.
3178
3179         Add support for the RESOLUTION_MEDIA_QUERY feature flag.
3180
3181         * Scripts/webkitperl/FeatureList.pm:
3182         * qmake/mkspecs/features/features.pri:
3183
3184 2012-10-23  Bruno de Oliveira Abinader  <bruno.abinader@basyskom.com>
3185
3186         Adding myself to commiters.py
3187         https://bugs.webkit.org/show_bug.cgi?id=100122
3188
3189         Unreviewed update to commiters.py.
3190
3191         * Scripts/webkitpy/common/config/committers.py:
3192
3193 2012-10-23  Timothy Hatcher  <timothy@apple.com>
3194
3195         Unreviewed watchlist change to monitor Inspector IDLs.
3196
3197         * Scripts/webkitpy/common/config/watchlist:
3198
3199 2012-10-23  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3200
3201         [WK2] [WTR] WebKitTestRunner needs testRunner.queueForwardNavigation
3202         https://bugs.webkit.org/show_bug.cgi?id=99700
3203
3204         Reviewed by Kenneth Rohde Christiansen.
3205
3206         Implemented testRunner.queueForwardNavigation, made little refactoring in Work Queue
3207         to obviate code duplication.
3208
3209         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3210         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3211         (WTR::InjectedBundle::queueBackNavigation):
3212         (WTR):
3213         (WTR::InjectedBundle::queueForwardNavigation):
3214         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3215         (InjectedBundle):
3216         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3217         (WTR::TestRunner::queueForwardNavigation):
3218         (WTR):
3219         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3220         (TestRunner):
3221         * WebKitTestRunner/TestInvocation.cpp:
3222         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3223         * WebKitTestRunner/WorkQueueManager.cpp:
3224         (NavigationItem):
3225         (WTR::NavigationItem::NavigationItem):
3226         (WTR::NavigationItem::invoke):
3227         (WTR):
3228         (WTR::WorkQueueManager::queueBackNavigation):
3229         (WTR::WorkQueueManager::queueForwardNavigation):
3230         * WebKitTestRunner/WorkQueueManager.h:
3231         (WorkQueueManager):
3232
3233 2012-10-23  Simon Hausmann  <simon.hausmann@digia.com>
3234
3235         Unreviewed trivial Qt build fix: Fix build without USE_3D_GRAPHICS
3236
3237         Disable USE_GRAPHICS_SURFACE if we don't have USE_3D_GRAPHICS because
3238         GraphicsSurface.h needs GraphicsContext3D.
3239
3240         * qmake/mkspecs/features/features.prf:
3241
3242 2012-10-23  Simon Pena  <spena@igalia.com>
3243
3244         Unreviewed. Adding myself as committer.
3245
3246         * Scripts/webkitpy/common/config/committers.py:
3247
3248 2012-10-22  Jochen Eisinger  <jochen@chromium.org>
3249
3250         [chromium] Move the call to RegisterIsolatedFileSystem to the WebTestDelegate interface
3251         https://bugs.webkit.org/show_bug.cgi?id=100048
3252
3253         Reviewed by Adam Barth.
3254
3255         The call needs to be done outside of the sandbox.
3256
3257         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3258         (WebTestDelegate):
3259         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
3260         (WebTestRunner):
3261         (WebTestRunner::EventSender::beginDragWithFiles):
3262         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
3263         (TestDelegate):
3264         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3265         (WebTestInterfaces::Internal):
3266         (WebTestRunner::WebTestInterfaces::Internal::registerIsolatedFileSystem):
3267         (WebTestRunner):
3268         * DumpRenderTree/chromium/WebViewHost.cpp:
3269         (WebViewHost::registerIsolatedFileSystem):
3270         * DumpRenderTree/chromium/WebViewHost.h:
3271         (WebViewHost):
3272
3273 2012-10-22  Dirk Pranke  <dpranke@chromium.org>
3274
3275         webkitpy: remove unneeded debug messages from find_files()
3276         https://bugs.webkit.org/show_bug.cgi?id=100041
3277
3278         Reviewed by Adam Barth.
3279
3280         This routine gets called all the time when loading the virtual
3281         suites, and the debug messages were spamming me.
3282
3283         * Scripts/webkitpy/common/find_files.py:
3284         (_normalized_find):
3285
3286 2012-10-22  Tony Chang  <tony@chromium.org>
3287
3288         [chromium] Add Mac 10.7 Debug bot since it's on the waterfall
3289         https://bugs.webkit.org/show_bug.cgi?id=100028
3290
3291         Reviewed by Eric Seidel.
3292
3293         garden-o-matic can't baseline without this entry.
3294
3295         * Scripts/webkitpy/layout_tests/port/builders.py:
3296
3297 2012-10-22  Jochen Eisinger  <jochen@chromium.org>
3298
3299         [chromium] introduce WebTask to the TestRunner library
3300         https://bugs.webkit.org/show_bug.cgi?id=99964
3301
3302         Reviewed by Adam Barth.
3303
3304         I'm also removing the dependency on webkit_support, and instead go
3305         through the WebTestDelegate interface.
3306
3307         * DumpRenderTree/DumpRenderTree.gypi:
3308         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
3309         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3310         (DRTDevToolsAgent::taskList):
3311         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
3312         * DumpRenderTree/chromium/DRTDevToolsClient.h:
3313         (DRTDevToolsClient::taskList):
3314         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3315         (InvokeCallbackTask::InvokeCallbackTask):
3316         * DumpRenderTree/chromium/DRTTestRunner.h:
3317         (DRTTestRunner::taskList):
3318         (DRTTestRunner::WorkQueue::taskList):
3319         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3320         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
3321         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
3322         (RTCStatsRequestSucceededTask::RTCStatsRequestSucceededTask):
3323         (RTCVoidRequestTask::RTCVoidRequestTask):
3324         (StringDataTask::StringDataTask):
3325         (CharPtrDataTask::CharPtrDataTask):
3326         (DataChannelReadyStateTask::DataChannelReadyStateTask):
3327         (RTCPeerConnectionReadyStateTask::RTCPeerConnectionReadyStateTask):
3328         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3329         (MockWebRTCPeerConnectionHandler):
3330         (MockWebRTCPeerConnectionHandler::taskList):
3331         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
3332         (MockWebSpeechInputController::SpeechTask::SpeechTask):
3333         * DumpRenderTree/chromium/MockWebSpeechInputController.h:
3334         (MockWebSpeechInputController::taskList):
3335         (MockWebSpeechInputController):
3336         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
3337         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
3338         (MockWebSpeechRecognizer::taskList):
3339         (MockWebSpeechRecognizer):
3340         (MockWebSpeechRecognizer::StepTask::StepTask):
3341         * DumpRenderTree/chromium/Task.cpp: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/Task.cpp.
3342         (WebTestRunner):
3343         (WebTestRunner::invokeTask):
3344         (TaskWrapper):
3345         (WebTestRunner::TaskWrapper::TaskWrapper):
3346         (WebTestRunner::TaskWrapper::~TaskWrapper):
3347         (WebTestRunner::TaskWrapper::Run):
3348         (postTask):
3349         (postDelayedTask):
3350         * DumpRenderTree/chromium/Task.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h.
3351         (WebTestRunner):
3352         * DumpRenderTree/chromium/TestRunner/public/WebTask.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/Task.h.
3353         (WebTestRunner):
3354         (WebTask):
3355         (WebTaskList):
3356         (WebMethodTask):
3357         (WebTestRunner::WebMethodTask::WebMethodTask):
3358         (WebTestRunner::WebMethodTask::~WebMethodTask):
3359         (WebTestRunner::WebMethodTask::run):
3360         (WebTestRunner::WebMethodTask::cancel):
3361         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3362         (WebTestRunner):
3363         (WebTestDelegate):
3364         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
3365         (WebTestRunner):
3366         (WebTestRunner::EventSender::scheduleAsynchronousClick):
3367         (WebTestRunner::KeyDownTask::KeyDownTask):
3368         (WebTestRunner::EventSender::scheduleAsynchronousKeyDown):
3369         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
3370         (WebTestRunner::EventSender::taskList):
3371         (EventSender):
3372         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
3373         (WebTestRunner):
3374         (TestDelegate):
3375         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3376         * DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/Task.cpp.
3377         (WebTestRunner):
3378         (WebTestRunner::WebTask::WebTask):
3379         (WebTestRunner::WebTask::~WebTask):
3380         (WebTestRunner::WebTaskList::WebTaskList):
3381         (WebTestRunner::WebTaskList::~WebTaskList):
3382         (WebTestRunner::WebTaskList::registerTask):
3383         (WebTestRunner::WebTaskList::unregisterTask):
3384         (WebTestRunner::WebTaskList::revokeAll):
3385         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3386         (WebTestInterfaces::Internal):
3387         (WebTestRunner::WebTestInterfaces::Internal::postTask):
3388         (WebTestRunner):
3389         (WebTestRunner::WebTestInterfaces::Internal::postDelayedTask):
3390         * DumpRenderTree/chromium/TestShell.cpp:
3391         (TestShell::initialize):
3392         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
3393         (UserMediaRequestTask::UserMediaRequestTask):
3394         * DumpRenderTree/chromium/WebUserMediaClientMock.h:
3395         (WebUserMediaClientMock::taskList):
3396         (WebUserMediaClientMock):
3397         * DumpRenderTree/chromium/WebViewHost.cpp:
3398         (WebViewHost::postTask):
3399         (WebViewHost::postDelayedTask):
3400         * DumpRenderTree/chromium/WebViewHost.h:
3401         (WebViewHost):
3402         (WebViewHost::taskList):
3403         (WebViewHost::HostMethodTask::HostMethodTask):
3404
3405 2012-10-22  Ojan Vafai  <ojan@chromium.org>
3406
3407         Update flakiness dashboard to match the state of the builders.
3408         * TestResultServer/static-dashboards/builders.js:
3409         (isChromiumDepsGTestRunner):
3410         Broaden the filter since Chromium naming scheme is not consistent.
3411         (loadBuildersList):
3412         The main Chromium master now only runs builders, no tests.
3413         * TestResultServer/static-dashboards/dashboard_base.js:
3414         Remove test suites that no longer run on any of these masters.
3415
3416 2012-10-22  Jochen Eisinger  <jochen@chromium.org>
3417
3418         [chromium] add a method for printing message to the WebTestDelegate
3419         https://bugs.webkit.org/show_bug.cgi?id=99960
3420
3421         Reviewed by Adam Barth.
3422
3423         When using the TestRunner library from the content_shell, we can't print
3424         message directly but need to send them to the browser process.
3425
3426         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3427         (WebTestDelegate):
3428         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp:
3429         (WebTestRunner::AccessibilityController::fallbackCallback):
3430         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h:
3431         (WebTestRunner::AccessibilityController::setDelegate):
3432         (AccessibilityController):
3433         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
3434         (WebTestRunner):
3435         (WebTestRunner::EventSender::dumpFilenameBeingDragged):
3436         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp:
3437         (GamepadController::connect):
3438         (GamepadController::disconnect):
3439         (GamepadController::setId):
3440         (GamepadController::setButtonCount):
3441         (GamepadController::setButtonData):
3442         (GamepadController::setAxisCount):
3443         (GamepadController::setAxisData):
3444         (GamepadController::fallbackCallback):
3445         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
3446         (TestDelegate):
3447         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3448         (TestInterfaces::~TestInterfaces):
3449         (TestInterfaces::setDelegate):
3450         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3451         (WebTestInterfaces::Internal):
3452         (WebTestRunner::WebTestInterfaces::Internal::printMessage):
3453         (WebTestRunner):
3454         * DumpRenderTree/chromium/WebViewHost.cpp:
3455         (WebViewHost::didBeginEditing):
3456         (WebViewHost::lastContextMenuData):
3457         (WebViewHost::clearContextMenuData):
3458         (WebViewHost::setEditCommand):
3459         (WebViewHost::clearEditCommand):
3460         (WebViewHost::fillSpellingSuggestionList):
3461         (WebViewHost::setGamepadData):
3462         (WebViewHost::printMessage):
3463         * DumpRenderTree/chromium/WebViewHost.h:
3464         (WebViewHost):
3465
3466 2012-10-22  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3467
3468         I now only watch Selectors instead of all of CSS.
3469
3470         Unreviewed update of watchlist.
3471
3472         * Scripts/webkitpy/common/config/watchlist:
3473
3474 2012-10-22  Yury Semikhatsky  <yurys@chromium.org>
3475
3476         Make sure base and derived class pointers are different in MemoryInstrumentationTest.instrumentedWithMultipleAncestors
3477         https://bugs.webkit.org/show_bug.cgi?id=99987
3478
3479         Reviewed by Alexander Pavlov.
3480
3481         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp: changed first parent
3482         class in the list so that it has virtual table as well as the second one. This
3483         way we may be sure that pointer to the second ancestor class will differ from
3484         the pointer to the derived class.
3485
3486 2012-10-22  Yury Semikhatsky  <yurys@chromium.org>
3487
3488         Unreviewed. Fix compilation after r132059.
3489
3490         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
3491
3492 2012-10-22  Dominik Röttsches  <dominik.rottsches@intel.com>
3493
3494         Adding Cairo and Harfbuzz watchlist entries
3495
3496         Unreviewed watchlist update.
3497
3498         Added myself to these new ones and SVG.
3499
3500         * Scripts/webkitpy/common/config/watchlist:
3501
3502 2012-10-22  Yury Semikhatsky  <yurys@chromium.org>
3503
3504         Web Inspector: do not double count memory of objects with multiple ancestors
3505         https://bugs.webkit.org/show_bug.cgi?id=99958
3506
3507         Reviewed by Alexander Pavlov.
3508
3509         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp: Test that there
3510         is no double counting in case of multiple inheritance.
3511
3512 2012-10-22  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3513
3514         [Qt] Basic gesture event handling
3515         https://bugs.webkit.org/show_bug.cgi?id=66173
3516
3517         Reviewed by Simon Hausmann.
3518
3519         Add support for eventSender.gestureLongPress.
3520
3521         * DumpRenderTree/qt/EventSenderQt.cpp:
3522         (EventSender::EventSender):
3523         (EventSender::gestureLongPress):
3524         * DumpRenderTree/qt/EventSenderQt.h:
3525         (EventSender):
3526
3527 2012-10-22  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3528
3529         [WTR] Properly initialize TestRunner::m_dumpSelectionRect.
3530         https://bugs.webkit.org/show_bug.cgi?id=99970
3531
3532         Reviewed by Kenneth Rohde Christiansen.
3533
3534         Follow-up to r131476: actually initialize m_dumpSelectionRect to
3535         some value to avoid some flakyness in the tests.
3536
3537         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3538         (WTR::TestRunner::TestRunner):
3539
3540 2012-10-22  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
3541
3542         [Qt] Don't build any of the tools in production_build
3543
3544         Reviewed by Simon Hausmann.
3545
3546         * Tools.pro:
3547         * qmake/mkspecs/features/configure.prf:
3548
3549 2012-10-22  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
3550
3551         [Qt] Move OBJECTS_DIR and friends to default_pre.prf
3552
3553         The introduction of load(qt_build_config) in .qmake.conf meant
3554         that we started loading qtmodule.pri, which in turn set both
3555         MOC_DIR, RCC_DIR, and OBJECTS_DIR.
3556
3557         We were setting OBJECTS_DIR in default_post under a isEmpty() guard
3558         so that project files could override the objects dir. Instead of
3559         using the isEmpty() check we move it to defaul_pre, which will
3560         override the qtmodule.pri settings, but still allow project files
3561         to override it.
3562
3563         Reviewed by Ossy.
3564
3565         * qmake/mkspecs/features/default_post.prf:
3566         * qmake/mkspecs/features/default_pre.prf:
3567
3568 2012-10-22  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3569
3570         WebKitTestRunner needs testRunner.queueLoadingScript and testRunner.queueNonLoadingScript
3571         https://bugs.webkit.org/show_bug.cgi?id=42675
3572
3573         Reviewed by Kenneth Rohde Christiansen.
3574
3575         Added implementation of testRunner.queueLoadingScript and testRunner.queueNonLoadingScript.
3576
3577         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3578         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3579         (WTR::InjectedBundle::queueLoadingScript):
3580         (WTR):
3581         (WTR::InjectedBundle::queueNonLoadingScript):
3582         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3583         (InjectedBundle):
3584         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3585         (WTR::TestRunner::queueLoadingScript):
3586         (WTR):
3587         (WTR::TestRunner::queueNonLoadingScript):
3588         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3589         (TestRunner):
3590         * WebKitTestRunner/TestInvocation.cpp:
3591         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3592         * WebKitTestRunner/WorkQueueManager.cpp:
3593         (WTR):
3594         (WTR::runJavaScriptFunction):
3595         (ScriptItem):
3596         (WTR::ScriptItem::ScriptItem):
3597         (WTR::ScriptItem::invoke):
3598         (WTR::WorkQueueManager::queueBackNavigation):
3599         (WTR::WorkQueueManager::queueLoadingScript):
3600         (WTR::WorkQueueManager::queueNonLoadingScript):
3601         * WebKitTestRunner/WorkQueueManager.h:
3602         (WorkQueueManager):
3603
3604 2012-10-22  Zan Dobersek  <zandobersek@gmail.com>
3605
3606         Unreviewed, a follow-up to r132034 where I forgot to address
3607         Ojan's review comment about the race condition in handleLocationChange.
3608
3609         * TestResultServer/static-dashboards/dashboard_base.js:
3610         (handleLocationChange):
3611
3612 2012-10-22  Zan Dobersek  <zandobersek@gmail.com>
3613
3614         [TestResultServer] Move the resource loading into a dedicated class
3615         https://bugs.webkit.org/show_bug.cgi?id=99246
3616
3617         Reviewed by Ojan Vafai.
3618
3619         A new 'loader' namespace is created, containing the request method (previously located in dashboard_base.js)
3620         and the new Loader object, which handles the loading of all the necessary data the dashboard might require.
3621
3622         * TestResultServer/static-dashboards/aggregate_results.html: Include the loader.js source file.
3623         * TestResultServer/static-dashboards/builders.js:
3624         (requestBuilderList): Use the request method located in the loader namespace instead of the removed doXHR method.
3625         (onBuilderListLoad): Now parses the response text of the passed-in XHR. When all the builder lists are loaded the
3626         resource loader object is notified appropriately.
3627         (onErrorLoadingBuilderList): The partial function that calls this function also adds an XHR parameter.
3628         * TestResultServer/static-dashboards/dashboard_base.js: Much of the resource loading-related code is moved to loader.js.
3629         The Loader object is now used to load all the required resources.
3630         (parseParameters): Don't push the 'builder' parameter into the current state if the unit tests are being run.
3631         (resourceLoadingComplete): This method gets called when all the resources are loaded and the dashboard should
3632         proceed with generating the page.
3633         (handleLocationChange):
3634         * TestResultServer/static-dashboards/flakiness_dashboard.html: Include the loader.js source file.
3635         * TestResultServer/static-dashboards/flakiness_dashboard.js: The request method has been relocated to the loader namespace.
3636         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: The affected test cases are modified appropriately.
3637         (test):
3638         * TestResultServer/static-dashboards/loader.js: Added.
3639         (.): A new namespace is introduced, publicly exporting the request method that performs an XHR operation and a Loader object
3640         which oversees resource loading. The loading is done in steps, first loading the builders list, after that the results files
3641         the current dashboard needs, and lastly the TestExpectations files if they are required by the dashboard. When done the loader
3642         calls the resourceLoadingComplete method located in dashboard_base.js. This signals the dashboard all resources are available
3643         and it can proceed with generating the dashboard page.
3644         * TestResultServer/static-dashboards/loader_unittests.js: Added. Contains unit tests for the Loader object, covering the
3645         incremental loading and the loading of results files and TestExpectations files. The builders list loading is currently not
3646         tested as the unit tests page overrides related methods that possibly affect other tests' behavior.
3647         * TestResultServer/static-dashboards/run-unittests.html: Now includes the loader.js and loader_unittests.js source file.
3648         Refactors the code a bit due to changes in how onBuilderListLoad behaves.
3649         * TestResultServer/static-dashboards/timeline_explorer.html: Now includes the loader.js source file.
3650         * TestResultServer/static-dashboards/treemap.html: Ditto. Also refactors the code to take into account
3651         that all the test files are now loaded before generating the dashboard page.
3652
3653 2012-10-21  Jochen Eisinger  <jochen@chromium.org>
3654
3655         [chromium] introduce a public API for the TestRunner library
3656         https://bugs.webkit.org/show_bug.cgi?id=99904
3657
3658         Reviewed by Adam Barth.
3659
3660         The API decouples the public API from the underlying implementation, so
3661         embedders can depend on it. I'm also changing DRT to consume the
3662         TestRunner API through the public API, except for DRTTestRunner and all
3663         places that require Task.h. These two will be migrated in later changes.
3664
3665         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3666         * DumpRenderTree/DumpRenderTree.gypi:
3667         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3668         * DumpRenderTree/chromium/DRTDevToolsClient.h:
3669         * DumpRenderTree/chromium/MockSpellCheck.cpp:
3670         (MockSpellCheck::fillSuggestionList):
3671         * DumpRenderTree/chromium/MockSpellCheck.h:
3672         (MockSpellCheck):
3673         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3674         * DumpRenderTree/chromium/MockWebSpeechInputController.h:
3675         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
3676         * DumpRenderTree/chromium/TestRunner/public/WebAccessibilityController.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h.
3677         (WebKit):
3678         (WebTestRunner):
3679         (WebAccessibilityController):
3680         * DumpRenderTree/chromium/TestRunner/public/WebEventSender.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h.
3681         (WebKit):
3682         (WebTestRunner):
3683         (WebEventSender):
3684         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h.
3685         (WebKit):
3686         (WebTestRunner):
3687         (WebTestDelegate):
3688         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h.
3689         (WebKit):
3690         (WebTestRunner):
3691         (WebTestInterfaces):
3692         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp:
3693         (WebTestRunner):
3694         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h:
3695         (WebTestRunner):
3696         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
3697         (WebTestRunner):
3698         (WebTestRunner::makeMenuItemStringsFor):
3699         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
3700         (WebTestRunner):
3701         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
3702         (TestDelegate):
3703         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3704         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3705         (TestInterfaces):
3706         * DumpRenderTree/chromium/TestRunner/src/WebAccessibilityController.cpp: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h.
3707         (WebTestRunner):
3708         (WebTestRunner::WebAccessibilityController::WebAccessibilityController):
3709         (WebTestRunner::WebAccessibilityController::setFocusedElement):
3710         (WebTestRunner::WebAccessibilityController::notificationReceived):
3711         (WebTestRunner::WebAccessibilityController::shouldLogAccessibilityEvents):
3712         * DumpRenderTree/chromium/TestRunner/src/WebEventSender.cpp: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h.
3713         (WebTestRunner):
3714         (WebTestRunner::WebEventSender::WebEventSender):
3715         (WebTestRunner::WebEventSender::doDragDrop):
3716         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Added.
3717         (WebTestRunner):
3718         (WebTestInterfaces::Internal):
3719         (WebTestRunner::WebTestInterfaces::Internal::testInterfaces):
3720         (WebTestRunner::WebTestInterfaces::Internal::accessibilityController):
3721         (WebTestRunner::WebTestInterfaces::Internal::eventSender):
3722         (WebTestRunner::WebTestInterfaces::Internal::Internal):
3723         (WebTestRunner::WebTestInterfaces::Internal::~Internal):
3724         (WebTestRunner::WebTestInterfaces::Internal::setDelegate):
3725         (WebTestRunner::WebTestInterfaces::Internal::clearContextMenuData):
3726         (WebTestRunner::WebTestInterfaces::Internal::clearEditCommand):
3727         (WebTestRunner::WebTestInterfaces::Internal::fillSpellingSuggestionList):
3728         (WebTestRunner::WebTestInterfaces::Internal::setEditCommand):
3729         (WebTestRunner::WebTestInterfaces::Internal::lastContextMenuData):
3730         (WebTestRunner::WebTestInterfaces::Internal::setGamepadData):
3731         (WebTestRunner::WebTestInterfaces::WebTestInterfaces):
3732         (WebTestRunner::WebTestInterfaces::~WebTestInterfaces):
3733         (WebTestRunner::WebTestInterfaces::setWebView):
3734         (WebTestRunner::WebTestInterfaces::setDelegate):
3735         (WebTestRunner::WebTestInterfaces::bindTo):
3736         (WebTestRunner::WebTestInterfaces::resetAll):
3737         (WebTestRunner::WebTestInterfaces::accessibilityController):
3738         (WebTestRunner::WebTestInterfaces::eventSender):
3739         * DumpRenderTree/chromium/TestShell.cpp:
3740         (TestShell::initialize):
3741         * DumpRenderTree/chromium/TestShell.h:
3742         (TestShell::eventSender):
3743         (TestShell::accessibilityController):
3744         (TestShell):
3745         * DumpRenderTree/chromium/WebUserMediaClientMock.h:
3746         * DumpRenderTree/chromium/WebViewHost.cpp:
3747         (WebViewHost::finishLastTextCheck):
3748         (WebViewHost::fillSpellingSuggestionList):
3749         * DumpRenderTree/chromium/WebViewHost.h:
3750         (WebViewHost):
3751
3752 2012-10-21  Viatcheslav Ostapenko  <v.ostapenko@samsung.com>
3753
3754         Unreviewed. Updating my emails.
3755
3756         * Scripts/webkitpy/common/config/committers.py:
3757
3758 2012-10-20  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3759
3760         [EFL][DRT] Implement tracking and painting repaint rectangles.
3761         https://bugs.webkit.org/show_bug.cgi?id=99838
3762
3763         Reviewed by Gyuyoung Kim.
3764
3765         Implement displayWebView() and start tracking/painting the repaint
3766         rectangles for the repaint tests that rely on it.
3767
3768         * DumpRenderTree/efl/DumpRenderTree.cpp:
3769         (displayWebView):
3770         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3771         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3772         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
3773         (createBitmapContextFromWebView):
3774
3775 2012-10-19  Dan Bernstein  <mitz@apple.com>
3776
3777         Add bundle API for hit-testing
3778         https://bugs.webkit.org/show_bug.cgi?id=99907
3779
3780         Reviewed by Sam Weinig.
3781
3782         Added an API test for WKBundleFrameCreateHitTest().
3783
3784         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added InjectedBundleFrameHitTest.cpp,
3785         InjectedBundleFrameHitTest_bundle.cpp, and link-with-title.html.
3786
3787         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp: Added.
3788         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Checks that the message contains the
3789         title of the link in link-with-title.html.
3790         (TestWebKitAPI::setInjectedBundleClient):
3791         (TestWebKitAPI::TEST):
3792         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp: Added.
3793         (TestWebKitAPI::InjectedBundleFrameHitTestTest::InjectedBundleFrameHitTestTest):
3794         (TestWebKitAPI::didFinishLoadForFrameCallback): Hit tests at (50, 50) and sends the link title
3795         from the result back to the UI process.
3796         (TestWebKitAPI::InjectedBundleFrameHitTestTest::didCreatePage):
3797         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
3798         * TestWebKitAPI/Tests/WebKit2/link-with-title.html: Added.
3799
3800 2012-10-19  Sheriff Bot  <webkit.review.bot@gmail.com>
3801
3802         Unreviewed, rolling out r131944.
3803         http://trac.webkit.org/changeset/131944
3804         https://bugs.webkit.org/show_bug.cgi?id=99891
3805
3806         On second thoughts, not such a great idea (Requested by jamesr
3807         on #webkit).
3808
3809         * DumpRenderTree/chromium/TestShell.cpp:
3810         (TestShell::createNewWindow):
3811
3812 2012-10-19  Alexandre Elias  <aelias@chromium.org>
3813
3814         [chromium] API to pass impl thread via WebLayerTreeView
3815         https://bugs.webkit.org/show_bug.cgi?id=99863
3816
3817         Reviewed by James Robinson.
3818
3819         This adds an API to pass the compositor impl thread via WebView and
3820         WebLayerTreeView. This is currently a no-op change, but in the future
3821         this codepath will supercede WebCompositor. The goal is to avoid statics
3822         in compositor initialization.
3823
3824         * DumpRenderTree/chromium/TestShell.cpp:
3825         (TestShell::createNewWindow):
3826
3827 2012-10-19  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3828
3829         [Cairo][WTR] Implement the painting of repaint rectangles.
3830         https://bugs.webkit.org/show_bug.cgi?id=99839
3831
3832         Reviewed by Martin Robinson.
3833
3834         Implement the required code to paint the gray overlay with
3835         transparent regions for the repaint rectangles, as other ports
3836         already do and as is already done in most WK1 ports.
3837
3838         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
3839         (WTR::paintRepaintRectOverlay):
3840         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3841
3842 2012-09-08  Alpha Lam  <hclam@chromium.org>
3843
3844         [chromium] Implement deferred image decoding
3845         https://bugs.webkit.org/show_bug.cgi?id=94240
3846
3847         Reviewed by Stephen White.
3848
3849         Add --enable-deferred-image-decoding to DRT.
3850
3851         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3852         (main):
3853         * DumpRenderTree/chromium/TestShell.cpp:
3854         (TestShell::TestShell):
3855         (TestShell::resetWebSettings):
3856         * DumpRenderTree/chromium/TestShell.h:
3857         (TestShell::setDeferredImageDecodingEnabled):
3858         (TestShell):
3859         * DumpRenderTree/chromium/WebPreferences.cpp:
3860         (WebPreferences::reset):
3861         (WebPreferences::applyTo):
3862         * DumpRenderTree/chromium/WebPreferences.h:
3863         (WebPreferences):
3864         * Scripts/webkitpy/layout_tests/port/chromium.py:
3865         (ChromiumPort.virtual_test_suites):
3866
3867 2012-10-19  Dongwoo Joshua Im  <dw.im@samsung.com>
3868
3869         Rename ENABLE_CSS3_TEXT_DECORATION to ENABLE_CSS3_TEXT
3870         https://bugs.webkit.org/show_bug.cgi?id=99804
3871
3872         Reviewed by Julien Chaffraix.
3873
3874         CSS3 text related properties will be implemented under this flag,
3875         including text decoration, text-align-last, and text-justify.
3876
3877         * Scripts/webkitperl/FeatureList.pm:
3878         * qmake/mkspecs/features/features.pri:
3879
3880 2012-10-19  Balazs Kelemen  <kbalazs@webkit.org>
3881
3882         [Qt][WTR] renderToOffscreenBuffer should not be set if the real render loop is active
3883         https://bugs.webkit.org/show_bug.cgi?id=99831
3884
3885         Reviewed by Jocelyn Turcotte.
3886
3887         Do not set renderToOffscreenBuffer if we have called setRenderWithoutShowing.
3888         We do not need it in this case and these things are actually conflicting.
3889
3890         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3891         (WTR::WrapperWindow::handleStatusChanged):
3892         (WTR::PlatformWebView::PlatformWebView):
3893         (WTR::PlatformWebView::windowShapshotEnabled): Added a comment
3894         describing why this workaround is needed.
3895
3896 2012-10-19  Zan Dobersek  <zandobersek@gmail.com>
3897
3898         [WK2][GTK] Fullscreen tests timing out in bots
3899         https://bugs.webkit.org/show_bug.cgi?id=93973
3900
3901         Reviewed by Philippe Normand.
3902
3903         Add webcore_cppflags to the CPPFLAGS for WebKitTestRunner and the
3904         injected bundle library. webcore_cppflags contains all the feature
3905         defines' macros so the ENABE(*) compilation guards should now work
3906         properly (i.e. enable the code behind them when the feature is enabled).
3907
3908         * WebKitTestRunner/GNUmakefile.am:
3909
3910 2012-10-19  Simon Hausmann  <simon.hausmann@digia.com>
3911
3912         Unreviewed, rolling out r131734.
3913         http://trac.webkit.org/changeset/131734
3914
3915         Broke ANGLE build where we end up with @echo foo && @echo -n
3916
3917         * qmake/mkspecs/features/default_post.prf:
3918
3919 2012-10-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3920
3921         REGRESSION (r130640 - r130644): TestCookieManager API test is failing
3922         https://bugs.webkit.org/show_bug.cgi?id=98738
3923
3924         Reviewed by Philippe Normand.
3925
3926         * Scripts/run-gtk-tests:
3927         (TestRunner): Unskip /webkit2/WebKitCookieManager/accept-policy.
3928
3929 2012-10-19  Tommy Widenflycht  <tommyw@google.com>
3930
3931         MediaStream API: Update the RuntimeEnabledFeatures flags
3932         https://bugs.webkit.org/show_bug.cgi?id=99714
3933
3934         Reviewed by Adam Barth.
3935
3936         Enabling the DeprecatedPeerConnection so that all tests still run.
3937
3938         * DumpRenderTree/chromium/TestShell.cpp:
3939         (TestShell::TestShell):
3940
3941 2012-10-18  Dominic Mazzoni  <dmazzoni@google.com>
3942
3943         AX: labelForElement is slow when there are a lot of DOM elements
3944         https://bugs.webkit.org/show_bug.cgi?id=97825
3945
3946         Reviewed by Ryosuke Niwa.
3947
3948         Implement titleUIElement in the chromium port of DRT, and
3949         fix getAccessibleElementById so that it ensures the backing store
3950         is up-to-date.
3951
3952         * DumpRenderTree/chromium/TestRunner/AccessibilityControllerChromium.cpp:
3953         (AccessibilityController::getAccessibleElementById):
3954         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
3955         (AccessibilityUIElement::titleUIElementCallback):
3956
3957 2012-10-17  Ilya Tikhonovsky  <loislo@chromium.org>
3958
3959         Web Inspector: NMI provide data for mixing with tcmalloc heap dumps.
3960         https://bugs.webkit.org/show_bug.cgi?id=99457
3961
3962         Reviewed by Yury Semikhatsky.
3963
3964         countObjectSize now requires pointer to object as the first argument.
3965
3966         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
3967
3968 2012-10-18  Dirk Pranke  <dpranke@chromium.org>
3969
3970         make move_overwritten_baselines_to work again while rebaselining
3971         https://bugs.webkit.org/show_bug.cgi?id=99793
3972
3973         Reviewed by Ojan Vafai.
3974
3975         We used to have code that would help when rebaselining results
3976         for new ports (e.g., when moving from Lion to Mountain Lion) but
3977         it appears that code bitrotted during all the refactoring since
3978         the last time we needed this. This patch makes things work
3979         again, adds more tests that will hopefully make clearer what
3980         is supposed to work, and renames various parameters to be
3981         consistent.
3982
3983         * Scripts/webkitpy/layout_tests/port/builders.py:
3984         (move_overwritten_baselines_to):
3985         (builder_path_for_port_name):
3986         * Scripts/webkitpy/tool/commands/rebaseline.py:
3987         (RebaselineTest.__init__):
3988         (RebaselineTest._copy_existing_baseline):
3989         (RebaselineTest._rebaseline_test):
3990         (RebaselineTest.execute):
3991         (AbstractParallelRebaselineCommand._rebaseline_commands):
3992         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3993         (test_rebaseline_json_with_move_overwritten_baselines_to):
3994         (test_rebaseline_test_internal_with_move_overwritten_baselines_to):
3995         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3996         (GardeningServerTest.test_rebaselineall):
3997
3998 2012-10-18  Roger Fong  <roger_fong@apple.com>
3999
4000         Unreviewed. Skip really old flaky failing jscore date test. 
4001         There's a bug tracking it here: https://bugs.webkit.org/show_bug.cgi?id=53712.
4002
4003         * Scripts/run-javascriptcore-tests:
4004
4005 2012-10-18  Byungwoo Lee  <bw80.lee@samsung.com>
4006
4007         Fix build warning.
4008         https://bugs.webkit.org/show_bug.cgi?id=99788
4009
4010         Reviewed by Kentaro Hara.
4011
4012         Use return value of mktemp() for removing -Wunused-result.
4013
4014         * MiniBrowser/efl/main.c:
4015         (on_download_request):
4016
4017 2012-10-18  Benjamin Poulain  <bpoulain@apple.com>
4018
4019         [WK2] WebKit2 does not build without PLUGIN_PROCESS on Mac
4020         https://bugs.webkit.org/show_bug.cgi?id=99771
4021
4022         Reviewed by Anders Carlsson.
4023
4024         * DumpRenderTree/mac/MockWebNotificationProvider.mm: The file was not including config.h,
4025         effectively breaking feature flags.
4026
4027 2012-10-18  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
4028
4029         [EFL][DRT] Make textareas resizable by default.
4030         https://bugs.webkit.org/show_bug.cgi?id=99719
4031
4032         Reviewed by Gyuyoung Kim.
4033
4034         Enable painting the textarea resizer at the corner by default,
4035         just as it already is the case for WK2. This eases the work needed
4036         to get the pixel tests in shape and run by the bots, as both the
4037         WK1 and WK2 ports will have more similar results.
4038
4039         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
4040         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
4041
4042 2012-10-18  Jochen Eisinger  <jochen@chromium.org>
4043
4044         [chromium] Add a webkit_test_support target that WebTestingSupport
4045         https://bugs.webkit.org/show_bug.cgi?id=99772
4046
4047         Reviewed by Adam Barth.
4048
4049         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4050
4051 2012-10-18  Jochen Eisinger  <jochen@chromium.org>
4052
4053         [chromium] move TestRunner files into a src/ sub directory
4054         https://bugs.webkit.org/show_bug.cgi?id=99776
4055
4056         Reviewed by Adam Barth.
4057
4058         This is in preparation of adding a public API to the TestRunner library.
4059
4060         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4061         * DumpRenderTree/DumpRenderTree.gypi:
4062         * DumpRenderTree/chromium/DRTTestRunner.h:
4063         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/AccessibilityControllerChromium.cpp.
4064         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/AccessibilityControllerChromium.h.
4065         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp.
4066         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h.
4067         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp.
4068         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/CppBoundClass.h.
4069         * DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/CppVariant.cpp.
4070         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/CppVariant.h.
4071         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/EventSender.cpp.
4072         * DumpRenderTree/chromium/TestRunner/src/EventSender.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/EventSender.h.
4073         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/GamepadController.cpp.
4074         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/GamepadController.h.
4075         * DumpRenderTree/chromium/TestRunner/src/Task.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/Task.cpp.
4076         * DumpRenderTree/chromium/TestRunner/src/Task.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/Task.h.
4077         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/TestDelegate.h.
4078         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp.
4079         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/TestInterfaces.h.
4080         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/TestRunner.cpp.
4081         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/TestRunner.h.
4082         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/TextInputController.cpp.
4083         * DumpRenderTree/chromium/TestRunner/src/TextInputController.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/TextInputController.h.
4084
4085 2012-10-18  Dirk Pranke  <dpranke@chromium.org>
4086
4087         [chromium] garden-o-matic should ignore the 10.8 Tests bot
4088         https://bugs.webkit.org/show_bug.cgi?id=99765
4089
4090         Reviewed by Adam Barth.
4091
4092         It's really more of an FYI bot at this point and can be safely
4093         ignored like the Content Shell bots.
4094
4095         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
4096         (.):
4097
4098 2012-10-18  Jochen Eisinger  <jochen@chromium.org>
4099
4100         [chromium] Simplify TestInterfaces, as this class won't be directly exposed in the TestRunner library's interface
4101         https://bugs.webkit.org/show_bug.cgi?id=99766
4102
4103         Reviewed by Adam Barth.
4104
4105         This reverts http://trac.webkit.org/changeset/123240
4106
4107         * DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:
4108         (TestInterfaces::TestInterfaces):
4109         (TestInterfaces::~TestInterfaces):
4110         (TestInterfaces::setWebView):
4111         (TestInterfaces::setDelegate):
4112         (TestInterfaces::bindTo):
4113         (TestInterfaces::resetAll):
4114         (TestInterfaces::accessibilityController):
4115         (TestInterfaces::eventSender):
4116         * DumpRenderTree/chromium/TestRunner/TestInterfaces.h:
4117         (TestInterfaces):
4118
4119 2012-10-18  Sheriff Bot  <webkit.review.bot@gmail.com>
4120
4121         Unreviewed, rolling out r131810.
4122         http://trac.webkit.org/changeset/131810
4123         https://bugs.webkit.org/show_bug.cgi?id=99762
4124
4125         Broke linux debug webkit_unit_tests (Requested by
4126         danakj|gardening on #webkit).
4127
4128         * DumpRenderTree/chromium/DumpRenderTree.cpp:
4129         (main):
4130         * DumpRenderTree/chromium/TestShell.cpp:
4131         (TestShell::TestShell):
4132         (TestShell::resetWebSettings):
4133         * DumpRenderTree/chromium/TestShell.h:
4134         (TestShell):
4135         * DumpRenderTree/chromium/WebPreferences.cpp:
4136         (WebPreferences::reset):
4137         (WebPreferences::applyTo):
4138         * DumpRenderTree/chromium/WebPreferences.h:
4139         (WebPreferences):
4140         * Scripts/webkitpy/layout_tests/port/chromium.py:
4141         (ChromiumPort.virtual_test_suites):
4142
4143 2012-10-18  Alpha Lam  <hclam@chromium.org>
4144
4145         [chromium] Implement deferred image decoding
4146         https://bugs.webkit.org/show_bug.cgi?id=94240
4147
4148         Reviewed by Stephen White.
4149
4150         Add --enable-deferred-image-decoding to DRT.
4151
4152         * DumpRenderTree/chromium/DumpRenderTree.cpp:
4153         (main):
4154         * DumpRenderTree/chromium/TestShell.cpp:
4155         (TestShell::TestShell):
4156         (TestShell::resetWebSettings):
4157         * DumpRenderTree/chromium/TestShell.h:
4158         (TestShell::setDeferredImageDecodingEnabled):
4159         (TestShell):
4160         * DumpRenderTree/chromium/WebPreferences.cpp:
4161         (WebPreferences::reset):
4162         (WebPreferences::applyTo):
4163         * DumpRenderTree/chromium/WebPreferences.h:
4164         (WebPreferences):
4165         * Scripts/webkitpy/layout_tests/port/chromium.py:
4166         (ChromiumPort.virtual_test_suites):
4167
4168 2012-10-18  Dirk Pranke  <dpranke@chromium.org>
4169
4170         webkitpy: fix chromium bot configs in builders.py
4171         https://bugs.webkit.org/show_bug.cgi?id=99638
4172
4173         Reviewed by Ojan Vafai.
4174
4175         Updating after the great bot-renaming and deleting a test case
4176         that is no longer needed.
4177
4178         * Scripts/webkitpy/layout_tests/port/builders.py:
4179         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
4180         (BuildCoverageExtrapolatorTest.test_extrapolate):
4181
4182 2012-10-18  Dirk Pranke  <dpranke@chromium.org>
4183
4184         [chromium] Add 10.8 bot into fallback path, make work with garden-o-matic
4185         https://bugs.webkit.org/show_bug.cgi?id=99748
4186
4187         Reviewed by Ryosuke Niwa.
4188
4189         Subject pretty much says it all ...
4190
4191         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
4192         * Scripts/webkitpy/layout_tests/port/builders.py:
4193         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
4194         (ChromiumMacPort):
4195         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
4196         (ChromiumMacPortTest.test_versions):
4197         (ChromiumMacPortTest.test_baseline_path):
4198         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
4199         (TestRebaseline.test_baseline_directory):
4200         (test_rebaseline_and_copy_test_with_lion_result):
4201         (test_rebaseline_expectations):
4202
4203 2012-10-18  Timothy Hatcher  <timothy@apple.com>
4204
4205         Teach prepare-ChangeLog how to handle non-function properties in JavaScript prototypes.
4206
4207         https://bugs.webkit.org/show_bug.cgi?id=99747
4208
4209         Reviewed by Joseph Pecoraro.
4210
4211         * Scripts/prepare-ChangeLog:
4212         (get_function_line_ranges_for_javascript): Clear currentIdentifiers when comma is encountered
4213         so it does not tack those identifiers onto the next changed function.
4214
4215 2012-10-18  James Simonsen  <simonjam@chromium.org>
4216
4217         Add a script for exporting http/tests/w3c/webperf/submission to W3C
4218         https://bugs.webkit.org/show_bug.cgi?id=99675
4219
4220         Reviewed by Tony Gentilcore.
4221
4222         This does the inverse of Scripts/import-w3c-performance-wg-tests.
4223
4224         * Scripts/export-w3c-performance-wg-tests: Added.
4225
4226 2012-10-18  Pablo Flouret  <pablof@motorola.com>
4227
4228         Implement css3-conditional's @supports rule
4229         https://bugs.webkit.org/show_bug.cgi?id=86146
4230
4231         Reviewed by Antti Koivisto.
4232
4233         * Scripts/webkitperl/FeatureList.pm:
4234         * qmake/mkspecs/features/features.pri:
4235             Add an ENABLE_CSS3_CONDITIONAL_RULES flag.
4236
4237 2012-10-18  Xiaobo Wang  <xbwang@torchmobile.com.cn>
4238
4239         [BlackBerry] Dump DRT output to stdout if test is passed as command line argument
4240         https://bugs.webkit.org/show_bug.cgi?id=99150
4241
4242         Reviewed by Rob Buis.
4243
4244         Fixed some code style errors as well.
4245
4246         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
4247         (BlackBerry::WebKit::DumpRenderTree::runTest):
4248         (BlackBerry::WebKit::DumpRenderTree::runRemainingTests):
4249         (BlackBerry::WebKit::DumpRenderTree::runTests):
4250         (BlackBerry::WebKit::DumpRenderTree::isHTTPTest):
4251         (BlackBerry::WebKit::DumpRenderTree::dump):
4252         (BlackBerry::WebKit::DumpRenderTree::addMessageToConsole):
4253         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
4254         (DumpRenderTree):
4255
4256 2012-10-18  Simon Hausmann  <simon.hausmann@digia.com>
4257
4258         [Qt] Improved support for silent builds
4259
4260         Reviewed by Tor Arne Vestbø.
4261
4262         Silence our extra compilers when CONFIG+=silent is set.
4263
4264         * qmake/mkspecs/features/default_post.prf:
4265
4266 2012-10-18  Simon Hausmann  <simon.hausmann@digia.com>
4267
4268         [Qt] Reduce memory pressure at link time with less compromise on speed of linking
4269
4270         Reviewed by Csaba Osztrogonác.
4271
4272         Revert r131718 that made us pass -fno-keep-memory to the linker for any
4273         i386 builds. The downside of passing that option is that it slows down
4274         the process of linking and as Ossy determined, release builds do _not_
4275         take as much memory (2.x GB) for linking but much less (~350MB).
4276
4277         However there is one condition where even release builds do take up too
4278         much memory, and that is when Qt is configured with
4279         -separate-debug-info, because it adds a -g next to -O2. The recent
4280         introduction of loading qt_build_config enabled us to read qmodule.pri,
4281         which adds the -g if Qt is configured with -separate-debug-info. So
4282         instead of playing with -fno-keep-memory (which is a last resort
4283         measure for debug builds) we should tweak our existing mechanism of
4284         dealing with the debug info:
4285
4286         production_build.prf tries to ensure that we use -g only in static
4287         libraries that contain API facing code, so that we get nice backtraces
4288     &nb