[BlackBerry] Enable VIDEO_TRACK
[WebKit-https.git] / Tools / ChangeLog
1 2012-09-17  Rob Buis  <rbuis@rim.com>
2
3         [BlackBerry] Enable VIDEO_TRACK
4         https://bugs.webkit.org/show_bug.cgi?id=96949
5
6         Reviewed by Antonio Gomes.
7
8         * Scripts/webkitperl/FeatureList.pm:
9
10 2012-09-17  Rick Byers  <rbyers@chromium.org>
11
12         Add handling of new GestureTapCancel in DRT
13
14         https://bugs.webkit.org/show_bug.cgi?id=96183
15
16         Reviewed by Antonio Gomes.
17
18         * DumpRenderTree/chromium/TestWebPlugin.cpp:
19         (TestWebPlugin::handleInputEvent):
20         * DumpRenderTree/chromium/EventSender.cpp:
21         (EventSender::gestureTapCancel):
22
23 2012-09-17  Philip Rogers  <pdr@google.com>
24
25         Teach style checker about preprocessor directive indentation rules
26         https://bugs.webkit.org/show_bug.cgi?id=96874
27
28         Reviewed by Adam Barth.
29
30         Preprocessor directives (#ifdef, #include, #define, etc.) should not be indented.
31         This is not explicit in our style guide but is generally followed in our code.
32         Searching for violations in our codebase shows these are rarely indented:
33             #include - indented in 6 files
34             #ifdef - indented in 0 files
35             #ifndef - indented in 1 file
36             #define - indented in 11 files
37             #if - indented in 7 files
38
39         * Scripts/webkitpy/style/checkers/cpp.py:
40         (check_directive_indentation):
41
42             This is the simple test where we look for spaces followed by a #.
43
44         (check_style):
45         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
46
47             A few tests needed to be modified because they had unintentionally indented
48             preprocessor directives.
49
50         (CppStyleTest.test_build_class.Foo):
51         (CppStyleTest.test_build_class):
52         (CppStyleTest.test_build_class.DERIVE_FROM_GOO):
53         (WebKitStyleTest.test_line_breaking):
54         (WebKitStyleTest.test_directive_indentation):
55
56 2012-09-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
57
58         [Qt] Auto-generate the module pri file for QtWebKit
59
60         Reviewed by Simon Hausmann.
61
62         * qmake/qt_webkit.pri: Removed.
63
64 2012-09-14  Dirk Pranke  <dpranke@chromium.org>
65
66         nrwt: --additional-platform-dir is broken on chromium ports
67         https://bugs.webkit.org/show_bug.cgi?id=96840
68
69         Reviewed by Ojan Vafai.
70
71         Looks like I broke this when cleaning things up as part of
72         adding ML support. Fixing and adding a test.
73
74         * Scripts/webkitpy/layout_tests/port/chromium.py:
75         (ChromiumPort.default_baseline_search_path):
76         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
77         (ChromiumAndroidPort.default_baseline_search_path):
78         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
79         (ChromiumLinuxPort.default_baseline_search_path):
80         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
81         (ChromiumMacPort.__init__):
82         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
83         (ChromiumWinPort.setup_environ_for_server):
84         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
85         (test_check_build):
86         (test_additional_platform_directory):
87
88 2012-09-13  Stephanie Lewis  <slewis@apple.com>
89
90         mac-future ignores previous platform TestExpectations.
91         https://bugs.webkit.org/show_bug.cgi?id=96718.
92
93         Reviewed by Dirk Pranke.
94
95         TestExpectations match an expectation's configuraton against a list of configurations that are 
96         valid for that port.  That list does not contain mac-future so none of the expectations can be
97         applied.
98
99         * Scripts/webkitpy/layout_tests/port/apple.py:
100         (ApplePort._generate_all_test_configurations):
101
102 2012-09-14  Adam Barth  <abarth@webkit.org>
103
104         Remove webkitPostMessage
105         https://bugs.webkit.org/show_bug.cgi?id=96577
106
107         Reviewed by Ojan Vafai.
108
109         Add ENABLE_LEGACY_VENDOR_PREFIXES flag.
110
111         * Scripts/webkitperl/FeatureList.pm:
112         * qmake/mkspecs/features/features.pri:
113
114 2012-09-14  Alexey Proskuryakov  <ap@apple.com>
115
116         [WK2] webarchive/loading/javascript-url-iframe-crash.html fails
117         https://bugs.webkit.org/show_bug.cgi?id=96817
118
119         Reviewed by Kenneth Rohde Christiansen.
120
121         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
122         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): This callback
123         got overlooked when adding logging elsewhere.
124
125 2012-09-14  Peter Beverloo  <peter@chromium.org>
126
127         [Chromium] Build fix for DumpRenderTree following r128628
128         https://bugs.webkit.org/show_bug.cgi?id=96808
129
130         Reviewed by Tony Chang.
131
132         When building DumpRenderTree from the Chromium project, a compile error
133         shows up because including the header ForwardIOStreamsAndroid.h cannot
134         be located. TestWebKitAPI does this correctly.
135
136         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
137
138 2012-09-14  Dana Jansens  <danakj@chromium.org>
139
140         Change cc-bugs@google.com watchlist to cc-bugs@chromium.org
141         https://bugs.webkit.org/show_bug.cgi?id=96805
142
143         Reviewed by Dirk Pranke.
144
145         * Scripts/webkitpy/common/config/committers.py:
146         * Scripts/webkitpy/common/config/watchlist:
147
148 2012-09-14  Peter Beverloo  <peter@chromium.org>
149
150         [Chromium] Support the --{in,out,err}-fifo arguments on TestWebKitAPI and webkit_unit_tests
151         https://bugs.webkit.org/show_bug.cgi?id=96687
152
153         Reviewed by Tony Chang.
154
155         Android's DumpRenderTree currently supports these arguments, implemented
156         as part of TestShellAndroid:
157         http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/chromium/TestShellAndroid.cpp?rev=128496
158
159         They're used by the layout test runner to get the STDOUT and STDERR while
160         a layout test run is in process, which is a safer alternative to parsing
161         all the logcat output manually. The implementation can be seen here:
162         http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py?rev=128496#L590
163
164         This patch generalizes parsing of and applying the effects of these arguments
165         so that they can be used for TestWebKitAPI and webkit_unit_tests as well.
166         After this patch, this will make it possible to pull out the output-reading
167         code from Android's layout test port and generalize it so it can be re-used
168         in the new test-runner for the other two test suites.
169
170         This has no effect when compiling and running these tests as part of Chromium
171         code, which has a much more advanced test-runner that does parse complete log
172         output, but also directly depends on code licensed under Apache 2.
173
174         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
175         * DumpRenderTree/chromium/TestShellAndroid.cpp:
176         (platformInit):
177         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
178
179 2012-09-14  Zoltan Horvath  <zoltan@webkit.org>
180
181         check-webkit-style should not warn in case of NONCOPYABLE and FAST_ALLOCATED macros
182         https://bugs.webkit.org/show_bug.cgi?id=96656
183
184         Reviewed by Adam Barth.
185
186         We should allow to use WTF_MAKE_NONCOPYABLE(ClassName) and WTF_MAKE_FAST_ALLOCATED
187         macros in 1 line.
188
189         * Scripts/webkitpy/style/checkers/cpp.py:
190         (check_style.definitions):
191         (check_style): Add rule.
192         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
193         (WebKitStyleTest.test_line_breaking): Add unittest.
194
195 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
196
197         WebKitTestRunner needs layoutTestController.dumpDatabaseCallbacks
198         https://bugs.webkit.org/show_bug.cgi?id=57570
199
200         Reviewed by Kenneth Rohde Christiansen.
201
202         Implement testRunner.dumpDatabaseCallbacks in WebKitTestRunner
203         and dump the information expected by the test cases.
204
205         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
206         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
207         (WTR::InjectedBundle::beginTesting): Explicitly set the default
208         database quota.
209         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
210         (WTR::securityOriginToStr): New convenience function to convert
211         a security origin to the string expected in test results.
212         (WTR):
213         (WTR::InjectedBundlePage::InjectedBundlePage):
214         (WTR::InjectedBundlePage::didExceedDatabaseQuota):
215         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota): Minor
216         refactoring to share code with didExceedDatabaseQuota.
217         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
218         (InjectedBundlePage):
219         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
220         (WTR::TestRunner::TestRunner):
221         * WebKitTestRunner/InjectedBundle/TestRunner.h:
222         (WTR::TestRunner::dumpDatabaseCallbacks):
223         (WTR::TestRunner::shouldDumpDatabaseCallbacks):
224         (TestRunner):
225
226 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
227
228         [Qt] Set force_static_libs_as_shared early enough to be caught by configure
229
230         Rubber-stamped by Simon Hausmann.
231
232         * qmake/mkspecs/features/default_post.prf:
233
234 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
235
236         [Qt] Remove old cruft from the qmake build system
237
238         Rubber-stamped by Simon Hausmann.
239
240         * DumpRenderTree/qt/DumpRenderTree.pro:
241         * qmake/mkspecs/features/default_post.prf:
242
243 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
244
245         [Qt] Enable force_static_libs_as_shared for development
246
247         Not enabled for buildbots or production-builds (part of Qt5)
248
249         Reviewed by Simon Hausmann.
250
251         * qmake/mkspecs/features/default_post.prf:
252
253 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
254
255         [Qt] Make force_static_libs_as_shared work on Mac OS
256
257         We had to move a few LIBS += around that were in the wrong place,
258         and not caught when everything was just linked into the final
259         QtWebKit library.
260
261         Reviewed by Simon Hausmann.
262
263         * qmake/mkspecs/features/default_post.prf:
264         * qmake/mkspecs/features/force_static_libs_as_shared.prf:
265
266 2012-09-14  Simon Hausmann  <simon.hausmann@nokia.com>
267
268         [Qt] Fix build of WTR on Windows
269
270         Reviewed by Tor Arne Vestbø.
271
272         WTR/qt/main.cpp includes TestController.h, which lives in just WTR/
273         With qmake's unix makefile generator as well as with the MingW generator,
274         the directory where the pro file lives (WTR/) is automatically added to
275         the include search path, but not so with MSVC. Instead of relying on qmake's
276         implicit feature here, add WTR/ explicitly to the include search path.
277
278         * WebKitTestRunner/Target.pri:
279
280 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
281
282         WebKitTestRunner needs layoutTestController.setStopProvisionalFrameLoads
283         https://bugs.webkit.org/show_bug.cgi?id=42691
284
285         Reviewed by Kenneth Rohde Christiansen.
286
287         Add implementation for testrunner.setStopProvisionalFrameLoads()
288         in WebKitTestRunner.
289
290         Original patch by Alexey Proskuryakov.
291
292         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
293         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
294         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
295         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
296         (WTR::TestRunner::TestRunner):
297         * WebKitTestRunner/InjectedBundle/TestRunner.h:
298         (TestRunner):
299         (WTR::TestRunner::setStopProvisionalFrameLoads):
300         (WTR::TestRunner::shouldStopProvisionalFrameLoads):
301
302 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
303
304         [Qt] Fix handling of debug/release/debug_and_release/build_all
305
306         We now pick up the defaults from Qt, in default_pre (CONFIG already
307         contains the appropriate values for debug and release). We then let
308         the command line arguments to qmake, or the project files themselves,
309         override the configuration, and finally we sanitize the configuration
310         in default_post.
311
312         Reviewed by Simon Hausmann.
313
314         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
315         * Scripts/webkitdirs.pm:
316         (buildQMakeProjects):
317         * qmake/mkspecs/features/default_post.prf:
318         * qmake/mkspecs/features/default_pre.prf:
319         * qmake/mkspecs/features/mac/default_pre.prf:
320
321 2012-09-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
322
323         WebKitTestRunner needs layoutTestController.setTabKeyCyclesThroughElements
324         https://bugs.webkit.org/show_bug.cgi?id=42687
325
326         Reviewed by Kenneth Rohde Christiansen.
327
328         Implement testRunner.setTabKeyCyclesThroughElements for
329         WebKitTestRunner.
330
331         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
332         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
333         (WTR::InjectedBundle::beginTesting):
334         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
335         (WTR::TestRunner::setTabKeyCyclesThroughElements):
336         (WTR):
337         * WebKitTestRunner/InjectedBundle/TestRunner.h:
338         (TestRunner):
339
340 2012-09-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
341
342         EventSendingController::keyDown does not support non-array modifier arguments
343         https://bugs.webkit.org/show_bug.cgi?id=96727
344
345         Reviewed by Kenneth Rohde Christiansen.
346
347         Add support for handling a string as modifier argument to
348         EventSendingController::keyDown.
349
350         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
351         (WTR::parseModifierArray):
352
353 2012-09-14  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
354
355         WebKitTestRunner needs layoutTestController.setCustomPolicyDelegate
356         https://bugs.webkit.org/show_bug.cgi?id=42546
357
358         Reviewed by Kenneth Rohde Christiansen.
359
360         Exported TestRunner::setCustomPolicyDelegate() method.
361         Allowed Policy Delegate dumping even if we're not in 'waitUntilDone' mode.
362
363         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
364         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
365         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
366
367 2012-09-14  Zan Dobersek  <zandobersek@gmail.com>
368
369         [GTK] Clear application cache between tests in DumpRenderTree
370         https://bugs.webkit.org/show_bug.cgi?id=96543
371
372         Reviewed by Philippe Normand.
373
374         Call the new DumpRenderTreeSupportGtk method to clear application cache
375         after each test in DumpRenderTree.
376
377         Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
378         as well. It's now being set in XvfbDriver._start so that each driver is assigned
379         a cache directory that's constructed out of the driver's name and its worker
380         number. These directories are located in the layout tests results directory.
381         At least on the builders this ensures a driver-specific empty cache directory
382         with each test run.
383
384         * DumpRenderTree/gtk/DumpRenderTree.cpp:
385         (runTest):
386         * Scripts/webkitpy/layout_tests/port/gtk.py:
387         (GtkPort.setup_environ_for_server):
388         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
389         (XvfbDriver._start):
390
391 2012-09-14  Simon Hausmann  <simon.hausmann@nokia.com>
392
393         [Qt] Fix linking on Windows
394
395         Reviewed by Tor Arne Vestbø.
396
397         When compiling code _after_ QtWebKit.dll, we need to make sure that the QWEBKIT_EXPORT
398         macro turns into an import macro, which means QT_MAKEDLL should only be set _up until_
399         the QtWebKit.dll creation in the build process and be off afterwards. This is done in
400         win32/default_post.prf using a !contains(QT, webkit): DEFINES += QT_MAKEDLL.
401
402         r128450 sanitized the values of QT and PKGCONFIG to only contain the dependencies we
403         want for QtWebKit.dll, but unfortunately that code was applied to any binary built also
404         after the module. Therefore QT did never contain webkit anymore and we always passed
405         QT_MAKEDLL to DEFINES, resulting in QWEBKIT_EXPORT to _not_ turn into an import macro.
406
407         This patch introduces a creating_module configuration that is used to
408         scope the qt/pkgconfig sanitization.
409
410         * qmake/mkspecs/features/default_post.prf:
411
412 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
413
414         [WK2][WKTR] TestRunner is not dumping some frame load callbacks information
415         https://bugs.webkit.org/show_bug.cgi?id=96740
416
417         Reviewed by Kenneth Rohde Christiansen.
418
419         Dump information expected by the test cases about the following
420         frame load callbacks:
421         "didDisplayInsecureContentForFrame"
422         "didRunInsecureContentForFrame"
423         "didDetectXSSForFrame"
424
425         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
426         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Print a URL
427         as expected by test results by calling pathSuitableForTestResult() instead
428         of printing raw URL.
429         (WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
430         (WTR::InjectedBundlePage::didRunInsecureContentForFrame):
431         (WTR::InjectedBundlePage::didDetectXSSForFrame):
432
433 2012-09-14  Peter Beverloo  <peter@chromium.org>
434
435         The runtime/unsigned category should be valid in the cpp style-checker.
436         https://bugs.webkit.org/show_bug.cgi?id=96748
437
438         Reviewed by Csaba Osztrogonác.
439
440         This is causing the webkitpy tests to fail because it's not listed in the
441         category array. Furthermore, change an "int" to "long" because it's
442         throwing a double error in one of the earlier asserts.
443
444         * Scripts/webkitpy/style/checkers/cpp.py:
445         (CppChecker):
446         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
447         (WebKitStyleTest.test_names):
448
449 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
450
451         Evas_Object* is a ref'ed structure, so tread it as such
452         https://bugs.webkit.org/show_bug.cgi?id=96659
453
454         Reviewed by Adam Barth.
455
456         Replace OwnPtr<Evas_Object> with RefPtr.
457
458         * DumpRenderTree/efl/ImageDiff.cpp:
459         (calculateDifference):
460         (printImageDifferences):
461         (readImageFromStdin):
462         (main):
463
464 2012-09-14  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
465
466         Unreviewed, rolling out r128507.
467         http://trac.webkit.org/changeset/128507
468         https://bugs.webkit.org/show_bug.cgi?id=96659
469
470         Revert. r128507 makes too many crashes in EFL layout test bots.
471
472         * DumpRenderTree/efl/ImageDiff.cpp:
473         (calculateDifference):
474         (printImageDifferences):
475         (readImageFromStdin):
476         (main):
477
478 2012-09-13  Kevin Funk  <kevin.funk@kdab.com>
479
480         Make compile with both OS(WINCE) and PLATFORM(QT) support
481         https://bugs.webkit.org/show_bug.cgi?id=95536
482
483         Reviewed by Simon Hausmann.
484
485         Fix wince support in qmake files
486
487         * Tools.pro:
488         * qmake/mkspecs/features/configure.prf:
489         * qmake/mkspecs/features/default_post.prf:
490         * qmake/mkspecs/features/features.prf:
491         * qmake/mkspecs/features/functions.prf:
492
493 2012-09-13  KwangYong Choi  <ky0.choi@samsung.com>
494
495         [WK2] Add color picker API support for WebKit2
496         https://bugs.webkit.org/show_bug.cgi?id=95058
497
498         Reviewed by Gyuyoung Kim.
499
500         Initialization code for color picker callbacks in UI client.
501
502         * MiniBrowser/mac/BrowserWindowController.m:
503         (-[BrowserWindowController awakeFromNib]):
504         * MiniBrowser/win/BrowserView.cpp:
505         (BrowserView::create):
506         * WebKitTestRunner/TestController.cpp:
507         (WTR::TestController::createOtherPage):
508         (WTR::TestController::initialize):
509
510 2012-09-13  Yuta Kitamura  <yutak@chromium.org>
511
512         Upgrade yutak to reviewer
513         https://bugs.webkit.org/show_bug.cgi?id=96721
514
515         Reviewed by Kent Tamura.
516
517         * Scripts/webkitpy/common/config/committers.py:
518
519 2012-09-13  Adenilson Cavalcanti  <cavalcantii@gmail.com>
520
521         Make the style checker report usage of "unsigned int"
522         https://bugs.webkit.org/show_bug.cgi?id=96693
523
524         Reviewed by Dirk Pranke.
525
526         Add a rule to check for uses of unsigned int, as the updated coding style recomends.
527
528         * Scripts/webkitpy/style/checkers/cpp.py:
529         (check_language):
530
531 2012-09-13  Philip Rogers  <pdr@google.com>
532
533         Add gender-neutral form of webkit-patch land-cowboy
534         https://bugs.webkit.org/show_bug.cgi?id=96709
535
536         Reviewed by Adam Barth.
537
538         Add webkit-patch land-cowhand, the confident and courageous form of webkit-patch for everyone.
539
540         * Scripts/webkitpy/tool/commands/download.py:
541         (LandCowhand):
542
543 2012-09-13  Seokju Kwon  <seokju.kwon@samsung.com>
544
545         [EFL] Remove some parameters in browserCreate()
546         https://bugs.webkit.org/show_bug.cgi?id=96499
547
548         Reviewed by Kenneth Rohde Christiansen.
549
550         There are too many parameters in browserCreate(). Lots of it seems like settings from command line argument.
551         And I have moved some parameters into User_Arguments.
552
553         * EWebLauncher/main.c:
554         (_User_Arguments):
555         (_ELauncher):
556         (on_key_down):
557         (browserCreate):
558         (findThemePath):
559         (parseUserArguments):
560         (main):
561
562 2012-09-13  Mark Lam  <mark.lam@apple.com>
563
564         Unreviewed. Adding myself to the committers list.
565
566         * Scripts/webkitpy/common/config/committers.py:
567
568 2012-09-13  Ryosuke Niwa  <rniwa@webkit.org>
569
570         run-perf-tests output cryptic error when the config file is missing.
571         https://bugs.webkit.org/show_bug.cgi?id=96453
572
573         Reviewed by Tony Chang.
574
575         Add a special error message when a configuration file is missing.
576
577         Also update the help message of --source-json-path to signify the fact it specifies
578         the configuration file on performance tests bots.
579
580         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
581         (PerfTestsRunner._parse_args):
582         (PerfTestsRunner._generate_and_show_results):
583         (PerfTestsRunner._merge_slave_config_json):
584         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
585         (_test_run_with_json_output): Make upload to fail by default and assert the result
586         in the function so that we can return logs instead.
587         (_test_run_with_json_output.mock_upload_json):
588         (test_run_with_json_output):
589         (test_run_with_description):
590         (test_run_respects_no_results):
591         (test_run_with_slave_config_json):
592         (test_run_with_bad_slave_config_json):
593         (test_run_with_multiple_repositories):
594
595 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
596
597         Evas_Object* is a ref'ed structure, so tread it as such
598         https://bugs.webkit.org/show_bug.cgi?id=96659
599
600         Reviewed by Adam Barth.
601
602         Replace OwnPtr<Evas_Object> with RefPtr.
603
604         * DumpRenderTree/efl/ImageDiff.cpp:
605         (calculateDifference):
606         (printImageDifferences):
607         (readImageFromStdin):
608         (main):
609
610 2012-09-13  Csaba Osztrogonác  <ossy@webkit.org>
611
612         One more unreviewed trivial fix after r128399.
613
614         * BuildSlaveSupport/build.webkit.org-config/config.json: Fix URLs of the SVN mirror server.
615
616 2012-09-13  Csaba Osztrogonác  <ossy@webkit.org>
617
618         Unreviewed trivial fix after r128399.
619
620         * BuildSlaveSupport/wait-for-SVN-server.py: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py.
621         (getLatestSVNRevision):
622         (waitForSVNRevision):
623
624 2012-09-13  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
625
626         [WK2][WTR] WebKitTestRunner needs testRunner.callShouldCloseOnWebView
627         https://bugs.webkit.org/show_bug.cgi?id=96366
628
629         Reviewed by Anders Carlsson.
630
631         Implement testRunner.callShouldCloseOnWebView for WebKitTestRunner
632         by calling shouldClose() on the FrameLoader.
633
634         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
635         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
636         (WTR::TestRunner::callShouldCloseOnWebView):
637         (WTR):
638         * WebKitTestRunner/InjectedBundle/TestRunner.h:
639         (TestRunner):
640
641 2012-09-13  Sheriff Bot  <webkit.review.bot@gmail.com>
642
643         Unreviewed, rolling out r128453.
644         http://trac.webkit.org/changeset/128453
645         https://bugs.webkit.org/show_bug.cgi?id=96681
646
647         Having tests use the same appcache directory leads to timeouts
648         (Requested by zdobersek on #webkit).
649
650         * DumpRenderTree/gtk/DumpRenderTree.cpp:
651         (runTest):
652         * Scripts/webkitpy/layout_tests/port/gtk.py:
653         (GtkPort.setup_environ_for_server):
654
655 2012-09-13  James Robinson  <jamesr@chromium.org>
656
657         [chromium] Temporarily remove Android Builder (dbg) from garden-o-matic view
658         https://bugs.webkit.org/show_bug.cgi?id=96678
659
660         Reviewed by Dirk Pranke.
661
662         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
663         (.):
664
665 2012-09-13  Rob Buis  <rbuis@rim.com>
666
667         Unreviewed changes to watchlist.
668
669         - Add myself to BlackBerry bugs
670
671         * Scripts/webkitpy/common/config/watchlist:
672
673 2012-09-13  Stephen Chenney  <schenney@chromium.org>
674
675         Add an SVG entry to the watchlist
676
677         Unreviewed config change.
678
679         * Scripts/webkitpy/common/config/watchlist:
680         - Created a new SVG watchlist label covering WebCore/svg and WebCore/rendering/svg
681         - Added myself and pdr as watchers
682
683 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
684
685         [Qt] Make WebKit2 work on Windows with Qt 5
686         https://bugs.webkit.org/show_bug.cgi?id=76776
687
688         Reviewed by Tor Arne Vestbø.
689
690         WebKit2 should compile with Qt on Windows now, so enable it. This patch in fact corrects
691         the check to disable WebKit when we don't have USE_3D_GRAPHICS available, because we need
692         that for the GL TextureMapper (it's only built when that feature is set).
693
694         * qmake/mkspecs/features/configure.prf:
695
696 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
697
698         [Qt] Ensure that QT is finalized before loading qt_module.prf
699
700         As qt_module.prf does dependency tracking based on the content of the
701         QT variable. The intermediate WebKit modules modify the variable in
702         their .pri files, so we have to ensure we've loaded all the modules
703         before loading qt_module.
704
705         Reviewed by Tor Arne Vestbø.
706         Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-09-13
707
708         * qmake/mkspecs/features/default_post.prf:
709         * qmake/mkspecs/features/webkit_modules.prf: Added.
710
711 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
712
713         [Qt] Fix build of Qt WTR/MiniBrowser with MSVC and nmake
714         https://bugs.webkit.org/show_bug.cgi?id=96633
715
716         Reviewed by Csaba Osztrogonác.
717
718         WTR and MiniBrowser both have DRT in their include path (for the shared font stuff). Batch
719         builds with MSVC and nmake result in nmake picking up main.cpp from the wrong directory.
720         It's the usual problem and the usual solution is to rename one of the conflicting files.
721         This patch chooses to rename DRT instead of WTR and MBR.
722
723         Fixed include order at the same time to match style guide.
724
725         * DumpRenderTree/qt/DumpRenderTree.pro:
726         * DumpRenderTree/qt/DumpRenderTreeMain.cpp: Renamed from Tools/DumpRenderTree/qt/main.cpp.
727         (messageHandler):
728         (isOption):
729         (takeOptionValue):
730         (printUsage):
731         (main):
732
733 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
734
735         The Script run-launcher should support -2 in combination with --efl
736         https://bugs.webkit.org/show_bug.cgi?id=96639
737
738         Reviewed by Simon Hausmann.
739
740         Support running the MiniBrowser then supplied -2 as argument.
741
742         * Scripts/run-launcher:
743
744 2012-09-13  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
745
746         Unreviewed, add my Intel email address to the list.
747
748         * Scripts/webkitpy/common/config/committers.py:
749
750 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
751
752         [Qt] Don't overwrite LIBS_PRIVATE when sanitizing LIBS
753
754         Reviewed by Ossy.
755
756         * qmake/mkspecs/features/default_post.prf:
757
758 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
759
760         [EFL][DRT] Implement LayoutTestController::layerTreeAsText
761         https://bugs.webkit.org/show_bug.cgi?id=82294
762
763         Reviewed by Gyuyoung Kim.
764
765         Implement layerTreeAsText using the DumpRenderTreeSupportEfl method.
766
767         * DumpRenderTree/efl/TestRunnerEfl.cpp:
768         (TestRunner::layerTreeAsText):
769
770 2012-09-13  Zan Dobersek  <zandobersek@gmail.com>
771
772         [GTK] Clear application cache between tests in DumpRenderTree
773         https://bugs.webkit.org/show_bug.cgi?id=96543
774
775         Reviewed by Philippe Normand.
776
777         Call the new DumpRenderTreeSupportGtk method to clear application cache
778         after each test.
779
780         Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
781         as well. Currently it points to a subdirectory in the layout tests results
782         directory. At least on the builders this ensures an empty cache directory
783         with each test run.
784
785         * DumpRenderTree/gtk/DumpRenderTree.cpp:
786         (runTest):
787         * Scripts/webkitpy/layout_tests/port/gtk.py:
788         (GtkPort.setup_environ_for_server):
789
790 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
791
792         [Qt] Make sure LIBS, PKGCONFIG, and QT, do not affect QtWebKit's prl file
793
794         Unless it's actually a dependency of the public QtWebKit API.
795
796         We could replace every occurance of LIBS, PKGCONFIG, and QT, in the pri
797         files with their _PRIVATE equivivalent, but that's likely to break when
798         someone adds a new QT/LIBS/PKGCONFIG += foo line somewhere. Instead we
799         clean up the variables in default_post.
800
801         This means that the CONFIG -= explicitlib in linkAgainstLibrary() is no
802         longer needed, as it was a workaround for the intermediate libraries ending
803         up in the prl file. And, since CONFIG -= staticlib was there to support
804         the explicitlib option, we can remove that too (as well as the exception
805         for gprof, since it would be empty). If gprof needs tweaks to always link
806         statically they should go in gprof.prf.
807
808         Reviewed by Simon Hausmann.
809
810         * qmake/mkspecs/features/default_post.prf:
811         * qmake/mkspecs/features/functions.prf:
812
813 2012-09-13  Mario Sanchez Prada  <msanchez@igalia.com>
814
815         [GTK] "Infinite" loop in AccessibilityUIElementGtk.cpp
816         https://bugs.webkit.org/show_bug.cgi?id=96632
817
818         Reviewed by Carlos Garcia Campos.
819
820         Fix this by using atk_object_get_n_accessible_children instead of
821         calling getChildren() from childCount.
822
823         * WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp:
824         (WTR::AccessibilityUIElement::childrenCount): Avoid the infinite
825         loop by using atk_object_get_n_accessible_children().
826
827 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
828
829         [Qt][Win] Enable USE(3D_GRAPHICS)
830         https://bugs.webkit.org/show_bug.cgi?id=90879
831
832         Reviewed by Kenneth Rohde Christiansen.
833
834         Enable it on Windows as well as on QNX (bug fixed).
835
836         * qmake/mkspecs/features/features.prf:
837
838 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
839
840         [Qt] The ANGLE build on Windows breaks with GnuWin32's flex because it is too old
841         https://bugs.webkit.org/show_bug.cgi?id=96359
842
843         Reviewed by Tor Arne Vestbø.
844
845         GnuWin32's flex is 2.5.4 and that is too old for ANGLE's preprocessor
846         lexer. The only viable alternative I could find on Windows that provides
847         binaries is the winflexbison distribution (http://sourceforge.net/projects/winflexbison/),
848         so let's use that one instead.
849
850         * Scripts/webkitdirs.pm:
851         (checkRequiredSystemConfig):
852         * qmake/mkspecs/features/default_pre.prf:
853
854 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
855
856         [Qt] Add configuration for production builds
857         https://bugs.webkit.org/show_bug.cgi?id=96607
858
859         Reviewed by Kenneth Rohde Christiansen.
860
861         Add configuration tweaks for production builds, to ease memory pressure with the GNU toolchain
862         and enable all-in-one-files optimizations.
863
864         * qmake/mkspecs/features/production_build.prf: Added.
865
866 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
867
868         [Qt] GStreamer detection does not work when cross-compiling
869         https://bugs.webkit.org/show_bug.cgi?id=96608
870
871         Reviewed by Kenneth Rohde Christiansen.
872
873         When cross-compiling it is not safe to just use system(pkg-config),
874         because there is a high probability that it will find packages in the
875         host system instead of in the target one. Instead use qmake's new
876         packagesExist() function that takes care of this delicate aspect of
877         cross compilation by setting PKG_CONFIG_SYSROOT_DIR and
878         PKG_CONFIG_LIBDIR accordingly.
879
880         * qmake/mkspecs/features/features.prf:
881
882 2012-09-13  Christophe Dumez  <christophe.dumez@intel.com>
883
884         [WK2][WTR] More efficient string handling in InjectedBundlePage
885         https://bugs.webkit.org/show_bug.cgi?id=96609
886
887         Reviewed by Kenneth Rohde Christiansen.
888
889         Update StringBuilder usage in InjectedBundlePage to follow
890         the latest recommandations for efficient string handling:
891         http://trac.webkit.org/wiki/EfficientStrings
892
893         This involves using appendLiteral() or appendNumber()
894         instead of append() whenever possible.
895
896         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
897         (WTR::dumpPath):
898         (WTR::rangeToStr):
899         (WTR::styleDecToStr):
900         (WTR::frameToStr):
901         (WTR::dumpResourceURL):
902         (WTR):
903         (WTR::dumpFrameDescriptionSuitableForTestResult):
904         (WTR::dumpRequestDescriptionSuitableForTestResult):
905         (WTR::dumpResponseDescriptionSuitableForTestResult):
906         (WTR::dumpErrorDescriptionSuitableForTestResult):
907         (WTR::InjectedBundlePage::didReceiveIntentForFrame):
908         (WTR::InjectedBundlePage::registerIntentServiceForFrame):
909         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
910         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
911         (WTR::InjectedBundlePage::didCommitLoadForFrame):
912         (WTR::InjectedBundlePage::didFinishProgress):
913         (WTR::dumpFrameScrollPosition):
914         (WTR::dumpFrameText):
915         (WTR::dumpDescendantFramesText):
916         (WTR::InjectedBundlePage::didFinishLoadForFrame):
917         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
918         (WTR::InjectedBundlePage::didCancelClientRedirectForFrame):
919         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
920         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
921         (WTR::InjectedBundlePage::didHandleOnloadEventsForFrame):
922         (WTR::InjectedBundlePage::willSendRequestForFrame):
923         (WTR::InjectedBundlePage::didReceiveResponseForResource):
924         (WTR::InjectedBundlePage::didFinishLoadForResource):
925         (WTR::InjectedBundlePage::didFailLoadForResource):
926         (WTR::InjectedBundlePage::shouldCacheResponse):
927         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
928         (WTR::InjectedBundlePage::willAddMessageToConsole):
929         (WTR::InjectedBundlePage::willSetStatusbarText):
930         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
931         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
932         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
933         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
934         (WTR::InjectedBundlePage::shouldBeginEditing):
935         (WTR::InjectedBundlePage::shouldEndEditing):
936         (WTR::InjectedBundlePage::shouldInsertNode):
937         (WTR::InjectedBundlePage::shouldInsertText):
938         (WTR::InjectedBundlePage::shouldDeleteRange):
939         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
940         (WTR::InjectedBundlePage::shouldApplyStyle):
941         (WTR::InjectedBundlePage::didBeginEditing):
942         (WTR::InjectedBundlePage::didEndEditing):
943         (WTR::InjectedBundlePage::didChange):
944         (WTR::InjectedBundlePage::didChangeSelection):
945         (WTR::InjectedBundlePage::supportsFullScreen):
946         (WTR::InjectedBundlePage::enterFullScreenForElement):
947         (WTR::InjectedBundlePage::exitFullScreenForElement):
948         (WTR::InjectedBundlePage::beganEnterFullScreen):
949         (WTR::InjectedBundlePage::beganExitFullScreen):
950         (WTR::InjectedBundlePage::closeFullScreen):
951         (WTR::dumpBackForwardListItem):
952         (WTR::InjectedBundlePage::dumpBackForwardList):
953
954 2012-09-13  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
955
956         [Qt][WK2] Memory leaks in Qt's TestRunner
957         https://bugs.webkit.org/show_bug.cgi?id=96603
958
959         Reviewed by Csaba Osztrogonác.
960
961         Fix memory leaks in Qt's TestRunner code by adopting WKString
962         created with WKStringCreateWithUTF8CString().
963
964         * WebKitTestRunner/qt/TestControllerQt.cpp:
965         (WTR::TestController::initializeInjectedBundlePath):
966         (WTR::TestController::initializeTestPluginDirectory):
967
968 2012-09-13  Zan Dobersek  <zandobersek@gmail.com>
969
970         [GTK][NRWT] Lower timeout value to 6 seconds (12 for debug configuration)
971         https://bugs.webkit.org/show_bug.cgi?id=96506
972
973         Reviewed by Dirk Pranke.
974
975         Lower the timeout value to 6 seconds for release configuration and 12 seconds
976         for debug configuration. These are the same values the Chromium port uses.
977
978         Currently the value is lowered only for the DumpRenderTree, WebKitTestRunner (and
979         the layout tests under WebKit2 generally) requires more attention and gardening
980         than what the current effort produces.
981
982         The unit test is updated as well to test these changes.
983
984         * Scripts/webkitpy/layout_tests/port/gtk.py:
985         (GtkPort.default_timeout_ms):
986         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
987         (GtkPortTest.test_default_timeout_ms):
988         (GtkPortTest.assertLinesEqual):
989
990 2012-09-12  Csaba Osztrogonác  <ossy@webkit.org>
991
992         Add SVN mirror handling feature to build.webkit.org
993         https://bugs.webkit.org/show_bug.cgi?id=85887
994
995         Reviewed by Dirk Pranke.
996
997         * BuildSlaveSupport/build.webkit.org-config/config.json: Add SVN mirrors for Qt buildslaves hosted in Szeged.
998         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
999         (ConfigureBuild.__init__): Add SVNMirror property to be able to watch which slaves use which mirror on build.webkit.org.
1000         (ConfigureBuild.start):
1001         (CheckOutSource.__init__): Set baseURL to the SVNMirror or the default http://svn.webkit.org/repository/webkit/
1002         (WaitForSVNServer): Add new buildstep for waiting the SVNMirror to be in sync with http://svn.webkit.org/repository/webkit/
1003         (Factory.__init__):
1004         (BuildFactory.__init__):
1005         (TestFactory.__init__):
1006         (BuildAndTestFactory.__init__):
1007         (BuildAndPerfTestFactory.__init__):
1008         (BuildAndPerfTestWebKit2Factory.__init__):
1009         (DownloadAndPerfTestFactory.__init__):
1010         (DownloadAndPerfTestWebKit2Factory.__init__):
1011         (loadBuilderConfig): Use kwargs instead of args to be able to add the optional SVNMirror factory argument.
1012         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1013         (SVNMirrorTest):
1014         (SVNMirrorTest.setUp): Load config.json once at startup.
1015         (SVNMirrorTest.get_SVNMirrorFromConfig): Get the SVNMirror from config.json for a given buildslave.
1016         (SVNMirrorTest.test_CheckOutSource): Compare CheckOutSource.baseURL with SVNMirror in config.json for all builders
1017         * BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py: Added.
1018         (getLatestSVNRevision): Get the latest SVN revison from the given server.
1019         (waitForSVNRevision): Wait until the given SVN revision is committed to the given server. It doesn't wait if the
1020                               SVN revision is empty (force build triggered without revision) or the server is unavailable.
1021
1022 2012-09-12  Kangil Han  <kangil.han@samsung.com>
1023
1024         [WK2][WTR] Set waitUntilDone watchdog timer value equal to WK1.
1025         https://bugs.webkit.org/show_bug.cgi?id=81606
1026
1027         Reviewed by Tim Horton.
1028
1029         6 seconds is harsh for some jquery test cases.
1030         Therefore, adjust the value to match DumpRenderTree.
1031
1032         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1033         (WTR):
1034
1035 2012-09-12  KyungTae Kim  <ktf.kim@samsung.com>
1036
1037         [EFL] Support download attribute feature
1038         https://bugs.webkit.org/show_bug.cgi?id=96462
1039
1040         Reviewed by Gyuyoung Kim.
1041
1042         Enable DOWNLOAD_ATTRIBUTE feature for EFL port,
1043         and add "download,request" callback to the DumpRenderTree for EFL.
1044
1045         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1046         (DumpRenderTreeChrome::createView):
1047         (DumpRenderTreeChrome::onDownloadRequest):
1048         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1049         (DumpRenderTreeChrome):
1050         * Scripts/webkitperl/FeatureList.pm:
1051
1052 2012-09-12  Stephanie Lewis  <slewis@apple.com>
1053
1054         Reduce parallism on the wk2 testers.
1055         https://bugs.webkit.org/show_bug.cgi?id=95906
1056
1057         Reviewed by Dirk Pranke.
1058
1059         The wk2 testers on Mountain Lion are getting stuck and timing out.  The problem appears to be due to
1060         resource contention.  Reducing the number of processes alleviates the issue.  
1061
1062         Starting by reducing 25%.
1063
1064         * Scripts/webkitpy/layout_tests/port/mac.py:
1065         (MacPort.default_child_processes):
1066
1067 2012-09-12  Brady Eidson  <beidson@apple.com>
1068
1069         Assert in NetscapePlugin::destroy() with async plugin init
1070         <rdar://problem/12277595> and https://bugs.webkit.org/show_bug.cgi?id=96576
1071
1072         Reviewed by Anders Carlsson.
1073
1074         Expose NPN_Invoke to plug-in tests:
1075         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1076         (PluginTest::NPN_Invoke):
1077         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1078         (PluginTest):
1079
1080         Add a test that uses NPN_Invoke on the window object from inside NPP_New to remove the plug-in element:
1081         * DumpRenderTree/TestNetscapePlugIn/Tests/InvokeDestroysPluginWithinNPP_New.cpp: Added.
1082         (InvokeDestroysPluginWithinNPP_New):
1083         (InvokeDestroysPluginWithinNPP_New::InvokeDestroysPluginWithinNPP_New):
1084         (InvokeDestroysPluginWithinNPP_New::NPP_New):
1085         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1086
1087 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
1088
1089         refactor TestExpectations tokenization slightly in preparation for the new syntax
1090         https://bugs.webkit.org/show_bug.cgi?id=96564
1091
1092         Reviewed by Ojan Vafai.
1093
1094         This change changes how we will tokenize/lex the
1095         TestExpectations files, in preparation for supporting both the
1096         old syntax and the new one. This change by itself should be a
1097         no-op.
1098
1099         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1100         (TestExpectationParser._tokenize_line):
1101         (TestExpectationParser):
1102         (TestExpectationParser._tokenize_line_using_old_format):
1103         (TestExpectationParser._tokenize_line_using_new_format):
1104
1105 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
1106
1107         remove unused testexpectations editing code from webkitpy, garden-o-matic
1108         https://bugs.webkit.org/show_bug.cgi?id=96562
1109
1110         Reviewed by Adam Barth.
1111
1112         This code was prototyped but never fully realized. Removing
1113         until it reanimates :).
1114
1115         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1116         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
1117         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py: Removed.
1118         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py: Removed.
1119         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1120         (BuildCoverageExtrapolator.extrapolate_test_configurations):
1121         (GardeningHTTPRequestHandler._run_webkit_patch):
1122         (GardeningHTTPRequestHandler.ping):
1123         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1124         (BuildCoverageExtrapolatorTest.test_extrapolate):
1125         (GardeningServerTest.test_rebaseline_new_port):
1126
1127 2012-09-12  Lucas Forschler  <lforschler@apple.com>
1128
1129         Remove unused bot, apple-xserve-1.
1130         https://bugs.webkit.org/show_bug.cgi?id=96570
1131         
1132         Reviewed by Stephanie Lewis.
1133
1134         * BuildSlaveSupport/build.webkit.org-config/config.json:
1135
1136 2012-09-12  Xan Lopez  <xlopez@igalia.com>
1137
1138         [GTK] We attempt to rebase documentation even if it's not present
1139         https://bugs.webkit.org/show_bug.cgi?id=96553
1140
1141         Reviewed by Martin Robinson.
1142
1143         Do not make the documentation rebase step fatal. This allows make
1144         install to succeed when there's no documentation generated.
1145
1146         * gtk/generate-gtkdoc:
1147
1148 2012-09-12  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1149
1150         Respect WEBKITOUTPUTDIR when running EFL tests
1151         https://bugs.webkit.org/show_bug.cgi?id=96528
1152
1153         Reviewed by Dirk Pranke.
1154
1155         Expose user set WEBKITOUTPUTDIR to the web process.
1156
1157         * Scripts/webkitpy/layout_tests/port/driver.py:
1158         (Driver._start): Add WEBKITOUTPUTDIR to the environment
1159         of the web process and its potential jhbuild wrapper.
1160
1161 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
1162
1163         webkitdirs: fix uname version handling for cygwin
1164         https://bugs.webkit.org/show_bug.cgi?id=96436
1165
1166         Reviewed by Jon Honeycutt.
1167
1168         Newer versions of cygwin embed an additional version string
1169         inside parentheses, so you get "1.7.16(0.249/5/3)" instead of "1.7.16".
1170         Update the code to handle that.
1171
1172         * Scripts/webkitdirs.pm:
1173         (setupAppleWinEnv):
1174
1175 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
1176
1177         Regression(r128338): Broke Windows build
1178         https://bugs.webkit.org/show_bug.cgi?id=96537
1179
1180         Unreviewed build fix.
1181
1182         Fix Apple-Win build by allocating array dynamically
1183         since its size is not constant.
1184
1185         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1186         (WTR::stringArrayToJS):
1187
1188 2012-09-12  Alex Sakhartchouk  <alexst@chromium.org>
1189
1190         [chromium] Add a virtual test suite for fast/hidpi
1191         https://bugs.webkit.org/show_bug.cgi?id=90192
1192
1193         Reviewed by Dirk Pranke.
1194
1195         Add a virtual test suite to make sure the pixel tests in fast/hidpi give the same result
1196         on the hardware accelerated path as the software path.
1197
1198         * DumpRenderTree/chromium/WebPreferences.cpp:
1199         (WebPreferences::applyTo):
1200         * Scripts/webkitpy/layout_tests/port/chromium.py:
1201         (ChromiumPort.virtual_test_suites):
1202
1203 2012-09-12  Adam Klein  <adamk@chromium.org>
1204
1205         [chromium] Add content_browsertests to the flakiness dashboard
1206         https://bugs.webkit.org/show_bug.cgi?id=96535
1207
1208         Reviewed by Ojan Vafai.
1209
1210         * TestResultServer/static-dashboards/dashboard_base.js:
1211
1212 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
1213
1214         [WK2][WKTR] TestRunner needs to implement originsWithApplicationCache
1215         https://bugs.webkit.org/show_bug.cgi?id=96496
1216
1217         Reviewed by Kenneth Rohde Christiansen.
1218
1219         Add implementation for originsWithApplicationCache to
1220         WebKitTestRunner.
1221
1222         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1223         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1224         (WTR::stringArrayToJS):
1225         (WTR):
1226         (WTR::TestRunner::originsWithApplicationCache):
1227         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1228         (TestRunner):
1229
1230 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1231
1232         Fix Qt/Windows build with Python3
1233         https://bugs.webkit.org/show_bug.cgi?id=96473
1234
1235         Reviewed by Csaba Osztrogonác.
1236
1237         In Python 3 print is a real function, so we must use parentheses around
1238         the function parameters. This is backwards compatible with Python 2.
1239
1240         * Scripts/generate-win32-export-forwards:
1241
1242 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1243
1244         Unreviewed trivial build fix for Qt/Windows after bug #96358.
1245
1246         As pointed out by Kevin, we should inject the "set PATH=..." statement
1247         to add the GnuWin32 directory only if that directory actually exists.
1248
1249         * qmake/mkspecs/features/default_post.prf:
1250
1251 2012-09-12  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1252
1253         [EFL] [WK2] Memory leaks in TestControllerEfl
1254         https://bugs.webkit.org/show_bug.cgi?id=96525
1255
1256         Reviewed by Kenneth Rohde Christiansen.
1257
1258         Fix memory leaks in EFL's TestRunner code by adopting an allocation
1259         of WKString created with WKStringCreateWithUTF8CString().
1260
1261         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1262         (WTR::TestController::initializeInjectedBundlePath):
1263         (WTR::TestController::initializeTestPluginDirectory):
1264
1265 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
1266
1267         [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
1268         https://bugs.webkit.org/show_bug.cgi?id=96374
1269
1270         Reviewed by Kenneth Rohde Christiansen.
1271
1272         Implement support for dumpApplicationCacheDelegateCallbacks
1273         and disallowIncreaseForApplicationCacheQuota in
1274         WebKitTestRunner and properly dump the information
1275         expected by the tests.
1276
1277         If the application cache quota is reached for a given
1278         security origin, WebKitTestRunner will reset the quota
1279         to its default value, unless intructed not to via
1280         disallowIncreaseForApplicationCacheQuota().
1281
1282         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1283         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1284         (WTR::InjectedBundlePage::InjectedBundlePage):
1285         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
1286         (WTR):
1287         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1288         (InjectedBundlePage):
1289         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1290         (WTR::TestRunner::TestRunner):
1291         (WTR::TestRunner::disallowIncreaseForApplicationCacheQuota):
1292         (WTR):
1293         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1294         (WTR::TestRunner::dumpApplicationCacheDelegateCallbacks):
1295         (TestRunner):
1296         (WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota):
1297         (WTR::TestRunner::shouldDumpApplicationCacheDelegateCallbacks):
1298
1299 2012-09-12  Jochen Eisinger  <jochen@chromium.org>
1300
1301         [chromium] remove deprecated and unused sets import from chromium_android driver
1302         https://bugs.webkit.org/show_bug.cgi?id=96485
1303
1304         Reviewed by Dirk Pranke.
1305
1306         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1307
1308 2012-09-12  Zan Dobersek  <zandobersek@gmail.com>
1309
1310         Flakiness dashboard doesn't recognize new Chromium Android test builder
1311         https://bugs.webkit.org/show_bug.cgi?id=96523
1312
1313         Reviewed by Ojan Vafai.
1314
1315         Properly return 'ANDROID' as the Chromium platform for Android builders.
1316
1317         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1318         (chromiumPlatform):
1319         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1320         (test):
1321
1322 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1323
1324         [Qt] Build on Windows requires bison/flex in PATH
1325         https://bugs.webkit.org/show_bug.cgi?id=96358
1326
1327         Reviewed by Tor Arne Vestbø.
1328
1329         The build requires flex, bison, etc. and they need to be in the PATH when building. On Mac OS X
1330         and Linux that is rarely a problem given how easily available the tools are. On Windows however
1331         a separate installation of various GNU tools is required as the operating system doesn't come with
1332         them. To make the development more convenient, Qt 5 provides a copy of the most essential tools in
1333         the gnuwin32 directory of the qt5.git top-level repository.
1334
1335         This patch tries to detect the presence of those tools and prepends them to the PATH if found.
1336
1337         This is required in preparation for the elimination of qt5/qtwebkit.pri, which currently expands
1338         PATH before calling build-webkit. It it also required for the upcoming introduction of win_flex
1339         as dependency over flex, which can be done with less hassle when qt5's gnuwin32 directory has been
1340         updated with the new tool.
1341
1342         * Scripts/webkitdirs.pm:
1343         (checkRequiredSystemConfig):
1344         * qmake/mkspecs/features/default_post.prf:
1345
1346 2012-09-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1347
1348         [Qt] Update build-jsc after r128174
1349
1350         Reviewed by Ossy.
1351
1352         * Scripts/build-jsc:
1353
1354 2012-09-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1355
1356         [Qt] Teach addStrictSubdirOrderBetween to handle more than two targets
1357
1358         By hard-coding the names of the targets we defined we ended up just
1359         redefining the previous target when using addStrictSubdirOrderBetween
1360         more than once in a single project file.
1361
1362         We now embed the two base targets into the target names.
1363
1364         Reviewed by Simon Hausmann.
1365
1366         * qmake/mkspecs/features/functions.prf:
1367
1368 2012-09-12  Philippe Liard  <pliard@google.com>
1369
1370         Depend on {base,net} GYP targets rather than {base,net}_java.
1371         https://bugs.webkit.org/show_bug.cgi?id=95690
1372
1373         Reviewed by Adam Barth.
1374
1375         {base,net}_java became 'private' targets on the Chromium side that
1376         clients should not depend on (see
1377         https://chromiumcodereview.appspot.com/10913083/).
1378         This removes a bunch of trailing white spaces additionally in
1379         TestWebkitAPI.gyp (which includes non-trailing white space changes).
1380
1381         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1382         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
1383
1384 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1385
1386         [Qt] Fix the build with ENABLE_NETSCAPE_PLUGIN_API=0
1387         https://bugs.webkit.org/show_bug.cgi?id=96494
1388
1389         Reviewed by Tor Arne Vestbø.
1390
1391         WK2's ENABLE_PLUGIN_PROCESS uses the NPAPI functions unconditionally, so disable the
1392         plugin process feature if we don't have NPAPI.
1393
1394         * qmake/mkspecs/features/features.prf:
1395
1396 2012-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1397
1398         Unreviewed, rolling out r128280.
1399         http://trac.webkit.org/changeset/128280
1400         https://bugs.webkit.org/show_bug.cgi?id=96498
1401
1402         it broke compilation on windows debug bot (Requested by loislo
1403         on #webkit).
1404
1405         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1406         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1407         (WTR::InjectedBundlePage::InjectedBundlePage):
1408         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1409         (InjectedBundlePage):
1410         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1411         (WTR::TestRunner::TestRunner):
1412         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1413         (TestRunner):
1414
1415 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1416
1417         [Qt] Make it possible to build with "make release" and "make debug" on Windows
1418         https://bugs.webkit.org/show_bug.cgi?id=96488
1419
1420         Reviewed by Tor Arne Vestbø.
1421
1422         A "make debug" is passed through recursively and currently it aborts at Makefile.DerivedSources
1423         because there are no such targets. We want the generated sources to be independent from release
1424         or debug build configurations, so it is sufficient to provide fake debug and release targets that
1425         redirect to the same general-purpose target (first) of creating the derived sources.
1426
1427         * qmake/mkspecs/features/default_post.prf:
1428
1429 2012-09-12  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1430
1431         [EFL] Make DumpRenderTree smarter at finding the fonts
1432         http://webkit.org/b/96281
1433
1434         Reviewed by Gyuyoung Kim.
1435
1436         Respect WEBKITOUTPUTDIR and expand the font dir from it.
1437         Use CString consistently.
1438
1439         * DumpRenderTree/efl/FontManagement.cpp:
1440         (buildPath):
1441         (getCoreFontFiles):
1442         (addFontDirectory):
1443         (addFontFiles):
1444         (getCustomBuildDir):
1445         (getPlatformFontsPath):
1446         (addFontsToEnvironment):
1447
1448 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
1449
1450         [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
1451         https://bugs.webkit.org/show_bug.cgi?id=96374
1452
1453         Reviewed by Kenneth Rohde Christiansen.
1454
1455         Implement support for dumpApplicationCacheDelegateCallbacks
1456         and disallowIncreaseForApplicationCacheQuota in
1457         WebKitTestRunner and properly dump the information
1458         expected by the tests.
1459
1460         If the application cache quota is reached for a given
1461         security origin, WebKitTestRunner will reset the quota
1462         to its default value, unless intructed not to via
1463         disallowIncreaseForApplicationCacheQuota().
1464
1465         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1466         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1467         (WTR::InjectedBundlePage::InjectedBundlePage):
1468         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
1469         (WTR):
1470         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1471         (InjectedBundlePage):
1472         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1473         (WTR::TestRunner::TestRunner):
1474         (WTR::TestRunner::disallowIncreaseForApplicationCacheQuota):
1475         (WTR):
1476         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1477         (WTR::TestRunner::dumpApplicationCacheDelegateCallbacks):
1478         (TestRunner):
1479         (WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota):
1480         (WTR::TestRunner::shouldDumpApplicationCacheDelegateCallbacks):
1481
1482 2012-09-12  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1483
1484         [WK2] [WTR] WebKitTestRunner needs TestRunner.workerThreadCount
1485         https://bugs.webkit.org/show_bug.cgi?id=96388
1486
1487         Reviewed by Kenneth Rohde Christiansen.
1488
1489         Exported TestRunner.workerThreadCount as readonly attribute.
1490
1491         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1492         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Added workerThreadCount() method implementation.
1493         (WTR::TestRunner::workerThreadCount): Returns count of worker threads.
1494         (WTR):
1495         * WebKitTestRunner/InjectedBundle/TestRunner.h: Added workerThreadCount() method. 
1496         (TestRunner):
1497
1498 2012-09-12  Jochen Eisinger  <jochen@chromium.org>
1499
1500         [chromium] Consume a user gesture when creating a new view.
1501         https://bugs.webkit.org/show_bug.cgi?id=96373
1502
1503         Reviewed by Adam Barth.
1504
1505         * DumpRenderTree/chromium/WebViewHost.cpp:
1506         (WebViewHost::createView):
1507
1508 2012-09-12  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1509
1510         [WK2][WTR] Some of TestRunner special options are not reset before testing
1511         https://bugs.webkit.org/show_bug.cgi?id=96384
1512
1513         Reviewed by Kenneth Rohde Christiansen.
1514
1515         Now values of the following special options are reset:
1516         void setAcceptsEditing(in boolean value);
1517         void setCloseRemainingWindowsWhenComplete(in boolean value);
1518         void setXSSAuditorEnabled(in boolean value);
1519         void setAllowFileAccessFromFileURLs(in boolean value);
1520         void setPluginsEnabled(in boolean value);
1521         void setPopupBlockingEnabled(in boolean value);
1522
1523         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1524         (WTR::InjectedBundle::beginTesting):
1525
1526 2012-09-11  Ryuan Choi  <ryuan.choi@samsung.com>
1527
1528         [CMAKE] Supply feature defines to CodeGeneratorTestRunner.
1529         https://bugs.webkit.org/show_bug.cgi?id=96273
1530
1531         Reviewed by Gyuyoung Kim.
1532
1533         Passed FEATURE_DEFINES_WITH_SPACE_SEPARATOR to CodeGeneratorTestRunner
1534         in order to distinguish compile time options such as ENABLE(TOUCH_EVENTS).
1535
1536         * WebKitTestRunner/CMakeLists.txt:
1537
1538 2012-09-11  Dirk Pranke  <dpranke@chromium.org>
1539
1540         [chromium] rename webkit_resources
1541         https://bugs.webkit.org/show_bug.cgi?id=95874
1542
1543         Reviewed by James Robinson.
1544
1545         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1546
1547 2012-09-11  Jochen Eisinger  <jochen@chromium.org>
1548
1549         [chromium] don't include content shell builders in the garden-o-matic view
1550         https://bugs.webkit.org/show_bug.cgi?id=96418
1551
1552         Reviewed by James Robinson.
1553
1554         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1555
1556 2012-09-11  Adam Klein  <adamk@chromium.org>
1557
1558         Garden-o-matic should ignore a wider variety of warnings in buildbot json
1559         https://bugs.webkit.org/show_bug.cgi?id=96411
1560
1561         Reviewed by Adam Barth.
1562
1563         Previously only the exact string "warning" was treated as a warning
1564         result. This patch treats any string with "warning" as a substring
1565         as a warning (e.g., "warnings", as seen on the cr-win buildbots).
1566
1567         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
1568         (.):
1569         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
1570
1571 2012-09-11  Marcelo Lira  <marcelo.lira@openbossa.org>
1572
1573         Restore original value of mock scrollbars enabled in InternalSettings
1574         https://bugs.webkit.org/show_bug.cgi?id=87680
1575
1576         Reviewed by Adam Barth.
1577
1578         Added backup support for mock scrollbars state in
1579         InternalSettings::Backup, and removed support for these
1580         from Qt's DumpRenderTree.
1581
1582         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1583         (WebCore::WebPage::resetSettings):
1584         * DumpRenderTree/qt/TestRunnerQt.cpp:
1585         (TestRunner::setFrameFlatteningEnabled):
1586         * DumpRenderTree/qt/TestRunnerQt.h:
1587         (TestRunner):
1588
1589 2012-09-11  Dan Bernstein  <mitz@apple.com>
1590
1591         Fixed a bug where kill-old-processes failed to kill clang++.
1592
1593         Rubber-stamped by Alexey Proskuryakov.
1594
1595         * BuildSlaveSupport/kill-old-processes: Escape the + signs in "clang++"
1596         where it is passed as a regular expression to killall.
1597
1598 2012-09-11  Philippe Liard  <pliard@google.com>
1599
1600         Make sure that md5sum is not setup on non-Chromium Android platforms.
1601         https://bugs.webkit.org/show_bug.cgi?id=96393
1602
1603         Reviewed by Adam Barth.
1604
1605         Previously md5sum was setup in ChromiumAndroidDriver's constructor
1606         which is also invoked on non-Chromium Android platforms. The following patch
1607         moves this logic to _startup_test() which is guaranteed to be invoked
1608         only on Android.
1609
1610         This also updates the prompt unit test in chromium_android_unittest.py.
1611
1612         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1613         (ChromiumAndroidDriver.__init__):
1614         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
1615         (ChromiumAndroidDriver._setup_test):
1616
1617 2012-09-11  Raphael Kubo da Costa  <rakuco@webkit.org>
1618
1619         [EFL] Rewrite the EFL-related Find modules
1620         https://bugs.webkit.org/show_bug.cgi?id=95237
1621
1622         Reviewed by Kenneth Rohde Christiansen.
1623
1624         * DumpRenderTree/efl/CMakeLists.txt: Stop setting the LINK_FLAGS
1625         property and include all the Enlightenment Foundation Libraries
1626         required by the target.
1627         * EWebLauncher/CMakeLists.txt: Ditto.
1628         * MiniBrowser/efl/CMakeLists.txt: Ditto.
1629         * TestWebKitAPI/PlatformEfl.cmake: Add missing include directories
1630         now that they are not added implicitly.
1631         * WebKitTestRunner/CMakeLists.txt: Stop setting the LINK_FLAGS
1632         property.
1633         * WebKitTestRunner/PlatformEfl.cmake: Stop setting the LINK_FLAGS
1634         property and include all the Enlightenment Foundation Libraries
1635         required by the target.
1636
1637 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
1638
1639         [WK2][WKTR] TestRunner needs to implement setApplicationCacheOriginQuota
1640         https://bugs.webkit.org/show_bug.cgi?id=96379
1641
1642         Reviewed by Kenneth Rohde Christiansen.
1643
1644         Add implementation for setApplicationCacheOriginQuota
1645         to WebKitTestRunner.
1646
1647         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1648         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1649         (WTR::TestRunner::setApplicationCacheOriginQuota):
1650         (WTR):
1651         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1652         (TestRunner):
1653
1654 2012-09-11  Luciano Wolf  <luciano.wolf@openbossa.org>
1655
1656         [Qt] [WK2] editing/inserting/typing-tab-designmode tests are failing
1657         https://bugs.webkit.org/show_bug.cgi?id=91988
1658
1659         Reviewed by Kenneth Rohde Christiansen.
1660
1661         Regular key events generated by Qt for the tab key fill both
1662         keyCode and keyText, so we should do the same for our fake events.
1663
1664         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
1665         (WTR::EventSenderProxy::keyDown):
1666
1667 2012-09-11  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1668
1669         [WK2][WTR] WebKitTestRunner needs testRunner.setSpatialNavigationEnabled
1670         https://bugs.webkit.org/show_bug.cgi?id=96269
1671
1672         Reviewed by Kenneth Rohde Christiansen.
1673
1674         Exported missing testRunner.setSpatialNavigationEnabled() method.
1675
1676         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1677         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1678         (WTR::InjectedBundle::beginTesting):
1679         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1680         (WTR::TestRunner::setSpatialNavigationEnabled):
1681         (WTR):
1682         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1683         (TestRunner):
1684
1685 2012-09-11  Philippe Liard  <pliard@chromium.org>
1686
1687         Support LayoutTests on non-rooted devices for Chromium Android.
1688         https://bugs.webkit.org/show_bug.cgi?id=95346
1689
1690         Reviewed by Dirk Pranke.
1691
1692         We were requiring root permissions to sync resource files with the
1693         device by comparing host and device files' timestamp after we
1694         synchronized the device and host clocks.
1695         We now rely on md5sum provided by Chromium to handle data files
1696         synchronization.
1697
1698         * Scripts/webkitpy/layout_tests/port/chromium.py:
1699         (ChromiumPort._check_driver_build_up_to_date):
1700         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1701         (ChromiumAndroidDriver.__init__):
1702         (ChromiumAndroidDriver._setup_test):
1703         (ChromiumAndroidDriver._push_executable):
1704         (ChromiumAndroidDriver._push_test_resources):
1705         (ChromiumAndroidDriver._read_prompt):
1706
1707 2012-09-11  Simon Hausmann  <simon.hausmann@nokia.com>
1708
1709         [Qt] Fix output paths on Windows
1710
1711         Reviewed by Tor Arne Vestbø.
1712
1713         BUILD_ROOT_RELATIVE_TO_OUT_PWD was calculated incorrectly Windows, resulting in an incorrect
1714         DESTDIR transformation at the end of default_post.prf. The calculation should be baased no qmake
1715         paths, which can use drive letters but always use forward slashes. So the use of QMAKE_DIR_SEP is
1716         incorrect here and instead for the calculation we should use forward slashes.
1717
1718         * qmake/mkspecs/features/default_pre.prf:
1719
1720 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1721
1722         [Qt] Fix passing of defines from the build system
1723
1724         We explicitly have to pass -DENABLE_FOO=0 for every single feature
1725         that's not explicitly enabled in WEBKIT_CONFIG, since Platform.h
1726         will add it's own defaults if the features are not defined.
1727
1728         At some point we might want to run a configure-test to inspect what
1729         Platform.h will do, so we can sync up the build system's view of
1730         the feature-defines with the compile-time situation.
1731
1732         Reviewed by Simon Hausmann.
1733
1734         * qmake/mkspecs/features/functions.prf:
1735
1736 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1737
1738         [Qt] Fix --qt option to build-webkit
1739
1740         Reviewed by Ossy.
1741
1742         * Scripts/webkitdirs.pm:
1743         (buildQMakeProjects):
1744
1745 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1746
1747         [Qt] Add a configure step to the Qt build system
1748
1749         This allows building the Qt port using just 'qmake WebKit.pro'. Using
1750         the build-webkit script is still supported, and will add slightly more
1751         logic to the build, such as detecting the need for clean or incremental
1752         builds.
1753
1754         Internally, the build system now uses a new variable, WEBKIT_CONFIG, for
1755         all things related to configuring the build, such as use/have/enable flags,
1756         and these are translated to defines in default_post. Project files should
1757         no longer check contains(DEFINES,...) to detect features, but use the new
1758         enable?(), use?(), and have?() functions. The no_webkit1 and no_webkit2
1759         options have been translated into WEBKIT_CONFIG options as well, and can
1760         be checked using build?().
1761
1762         Reviewed by Simon Hausmann.
1763
1764         * DumpRenderTree/qt/DumpRenderTree.pro:
1765         * MiniBrowser/qt/MiniBrowser.pro:
1766         * QtTestBrowser/QtTestBrowser.pro:
1767         * Scripts/build-webkit:
1768         * Scripts/webkitdirs.pm:
1769         (qtFeatureDefaults):
1770         (buildQMakeProjects):
1771         * Tools.pro:
1772         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
1773         * WebKitTestRunner/InjectedBundle/Target.pri:
1774         * WebKitTestRunner/Target.pri:
1775         * qmake/.qmake.cache: Added.
1776         * qmake/configure.pri: Removed.
1777         * qmake/configure.pro: Removed.
1778         * qmake/dump-features: Added.
1779         * qmake/mkspecs/features/configure.prf: Added.
1780         * qmake/mkspecs/features/default_post.prf:
1781         * qmake/mkspecs/features/default_pre.prf:
1782         * qmake/mkspecs/features/features.prf:
1783         * qmake/mkspecs/features/features.pri:
1784         * qmake/mkspecs/features/functions.prf:
1785         * qmake/mkspecs/features/gprof.prf:
1786         * qmake/mkspecs/features/mac/default_pre.prf:
1787         * qmake/mkspecs/features/win32/default_pre.prf:
1788
1789 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
1790
1791         [WK2][WKTR] TestRunner needs to implement clearApplicationCacheForOrigin
1792         https://bugs.webkit.org/show_bug.cgi?id=96372
1793
1794         Reviewed by Kenneth Rohde Christiansen.
1795
1796         Implement clearApplicationCacheForOrigin() in WebKitTestRunner.
1797
1798         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1799         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1800         (WTR::TestRunner::clearApplicationCacheForOrigin):
1801         (WTR):
1802         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1803         (TestRunner):
1804
1805 2012-09-11  Peter Beverloo  <peter@chromium.org>
1806
1807         Don't ignore .pak files when making an archive for Android
1808         https://bugs.webkit.org/show_bug.cgi?id=96375
1809
1810         Reviewed by Jochen Eisinger.
1811
1812         The .pak files do need to be pushed to the device, which is currently
1813         preventing the layout test runner from correctly pushing all files.
1814
1815         * BuildSlaveSupport/built-product-archive:
1816         (archiveBuiltProduct):
1817
1818 2012-09-11  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1819
1820         [WK2][WTR] WebKitTestRunner needs layoutTestController.setMinimumTimerInterval
1821         https://bugs.webkit.org/show_bug.cgi?id=96256
1822
1823         Reviewed by Kenneth Rohde Christiansen.
1824
1825         Exported TestRunner::setMinimumTimerInterval() method.
1826
1827         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1828         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1829         (WTR::InjectedBundle::beginTesting):
1830         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1831         (WTR::TestRunner::setMinimumTimerInterval):
1832         (WTR):
1833         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1834         (TestRunner):
1835
1836 2012-09-11  Tommy Widenflycht  <tommyw@google.com>
1837
1838         MediaStream API: add RTCPeerConnection::onnegotiationneeded
1839         https://bugs.webkit.org/show_bug.cgi?id=96097
1840
1841         Reviewed by Adam Barth.
1842
1843         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1844         (MockWebRTCPeerConnectionHandler::addStream):
1845         (MockWebRTCPeerConnectionHandler::removeStream):
1846
1847 2012-09-11  Peter Beverloo  <peter@chromium.org>
1848
1849         Recognize the "--chromium-android" argument in run-webkit-tests
1850         https://bugs.webkit.org/show_bug.cgi?id=96369
1851
1852         Reviewed by Jochen Eisinger.
1853
1854         Chromium for the Android platform cannot determine the platform based on
1855         the host itself, so we'll use the --chromium-android argument as the build
1856         master passes to run-webkit-tests. Make sure the layout test runner
1857         can pick the right port when doing so.
1858
1859         * Scripts/run-webkit-tests:
1860         * Scripts/webkitpy/layout_tests/port/factory.py:
1861         (port_options):
1862
1863 2012-09-11  Simon Hausmann  <simon.hausmann@nokia.com>
1864
1865         [QT] Fix build with newer qmake from Qt 5
1866
1867         Rubber-stamped by Tor Arne Vestbø.
1868
1869         Support for "qmake -query QMAKE_MKSPECS" was removed from qmake. Replace
1870         it with the use of QT_HOST_DATA/mkspecs.
1871         Based on patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com>.
1872
1873         * Scripts/webkitdirs.pm:
1874         (builtDylibPathForName):
1875         (qtMakeCommand):
1876
1877 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1878
1879         [Qt] Remove Qt 4 syncqt, no longer needed
1880
1881         Reviewed by Simon Hausmann.
1882
1883         * qmake/syncqt-4.8: Removed.
1884
1885 2012-09-11  Andras Becsi  <andras.becsi@nokia.com>
1886
1887         [Qt][WK2] Fix the build with recent Qt5
1888         https://bugs.webkit.org/show_bug.cgi?id=96283
1889
1890         Reviewed by Simon Hausmann.
1891
1892         We should not use deprecated Qt API because doing that results
1893         in build failure since all the deprecated API was disabled
1894         in qtbase (https://codereview.qt-project.org/#change,24890).
1895
1896         * DumpRenderTree/qt/main.cpp:
1897         (main):
1898         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1899         (MiniBrowserApplication::notify):
1900         * MiniBrowser/qt/raw/View.cpp:
1901         (View::exposeEvent):
1902         (main):
1903
1904 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
1905
1906         WTR needs an implementation of applicationCacheDiskUsageForOrigin
1907         https://bugs.webkit.org/show_bug.cgi?id=87188
1908
1909         Reviewed by Kenneth Rohde Christiansen.
1910
1911         Add implementation for applicationCacheDiskUsageForOrigin()
1912         in WebKitTestRunner.
1913
1914         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1915         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1916         (WTR::TestRunner::applicationCacheDiskUsageForOrigin):
1917         (WTR):
1918         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1919         (TestRunner):
1920
1921 2012-09-10  Joanmarie Diggs  <jdiggs@igalia.com>
1922
1923         Properly expose <legend> elements to ATs
1924         https://bugs.webkit.org/show_bug.cgi?id=84137
1925
1926         Reviewed by Chris Fleizach.
1927
1928         Created a new WebCore Accessibility Role, LegendRole. Used it to map to
1929         the expected platform role, ATK_ROLE_LABEL. Also established the needed
1930         AtkRelation pair, label-for/labelled-by between the legend and fieldset.
1931
1932         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
1933         (roleToString): added "Legend" string for WebAccessibilityRoleLegend
1934
1935 2012-09-10  Jer Noble  <jer.noble@apple.com>
1936
1937         Unreviewed; rolling out r128081.
1938         http://trac.webkit.org/changeset/128081
1939         https://bugs.webkit.org/show_bug.cgi?id=96134
1940
1941         New test http/tests/media/video-donottrack.html fails to run on Apple test bots.
1942
1943         * DumpRenderTree/TestRunner.cpp:
1944         (TestRunner::TestRunner):
1945         (TestRunner::staticFunctions):
1946         * DumpRenderTree/TestRunner.h:
1947         (TestRunner):
1948         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1949         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1950         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1951         (WTR::InjectedBundlePage::InjectedBundlePage):
1952         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1953         (InjectedBundlePage):
1954         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1955         (WTR::TestRunner::TestRunner):
1956         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1957         (TestRunner):
1958
1959 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
1960
1961         TestExpectationsChecker._determine_port_from_expectations_path() does not support cascaded TestExpectations
1962         https://bugs.webkit.org/show_bug.cgi?id=96205
1963
1964         Reviewed by Tony Chang.
1965
1966         _determine_port_from_expectations_path() was calling port.path_to_test_expectations_file()
1967         internally, which means that it would support only 1 TestExpectations file per port. This
1968         is an issue for ports such as EFL that support cascased TestExpectations (efl-wk2 -> efl
1969         and efl-wk1 -> efl).
1970
1971         This patch makes _determine_port_from_expectations_path() call port.expectations_files()
1972         instead so that all the ports TestExpectations are recognized. The ports are also
1973         constructed twice, with "webkit_test_runner" option set to True and False so that we
1974         retrieve the TestExpectations paths for both WebKit1 and WebKit2.
1975
1976         * Scripts/webkitpy/style/checkers/test_expectations.py:
1977         (TestExpectationsChecker._determine_port_from_expectations_path):
1978         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Add corresponding unit test.
1979         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
1980
1981 2012-09-10  Ryuan Choi  <ryuan.choi@samsung.com>
1982
1983         [WTR] Generated source files should include config.h
1984         https://bugs.webkit.org/show_bug.cgi?id=96254
1985
1986         Reviewed by Benjamin Poulain.
1987
1988         Current coding style has encouraged to include config.h at the first position,
1989         But derived sources, generated by CodeGeneratorTestRunner.pm, don't follow
1990         this rule.
1991         Therefore, this patch added it.
1992
1993         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1994         (_generateImplementationFile):
1995
1996 2012-09-10  Rick Byers  <rbyers@chromium.org>
1997
1998         Add handling of new GestureTapCancel in DRT
1999         
2000         https://bugs.webkit.org/show_bug.cgi?id=96183
2001
2002         Reviewed by Adam Barth.
2003
2004         * DumpRenderTree/chromium/TestWebPlugin.cpp:
2005         (TestWebPlugin::handleInputEvent):
2006
2007 2012-09-10  Brady Eidson  <beidson@apple.com>
2008
2009         Javascript in foreground tabs should not wait synchronously for plug-ins to load
2010         <rdar://problem/12067415> and https://bugs.webkit.org/show_bug.cgi?id=96167
2011
2012         Reviewed by Geoff Garen.
2013
2014         Enhance the "Slow NPP_New" plug-in to also be able to return properties to javascript.
2015
2016         * DumpRenderTree/TestNetscapePlugIn/Tests/SlowNPPNew.cpp:
2017         (PluginObject):
2018         (SlowNPPNew::PluginObject::PluginObject):
2019         (SlowNPPNew::PluginObject::~PluginObject):
2020         (SlowNPPNew::PluginObject::hasProperty):
2021         (SlowNPPNew::PluginObject::getProperty):
2022         (SlowNPPNew::NPP_GetValue):
2023         (SlowNPPNew):
2024
2025 2012-09-10  Tim Horton  <timothy_horton@apple.com>
2026
2027         WKTR often reports an unresponsive WebProcess on Mac bots
2028         https://bugs.webkit.org/show_bug.cgi?id=95906
2029
2030         Reviewed by Dan Bernstein.
2031
2032         Attempt to work around resource contention issues by increasing the NRWT
2033         timeout when running against WKTR, as well as WKTR's own WebProcess timeout.
2034
2035         * Scripts/webkitpy/layout_tests/port/base.py:
2036         (Port.default_timeout_ms): Default timeout when using WKTR -> 80 seconds.
2037         * WebKitTestRunner/TestController.cpp:
2038         (WTR): LongTimeout (used when waiting for WebProcess to finish) -> 60 seconds.
2039
2040 2012-09-07  Jer Noble  <jer.noble@apple.com>
2041
2042         <audio> and <video> should send Do Not Track when appropriate
2043         https://bugs.webkit.org/show_bug.cgi?id=96134
2044
2045         Reviewed by Eric Carlson.
2046
2047         Add a testRunner JS API for calling setShouldSendDoNotTrackHTTPHeader to DRT and 
2048         WTR. Add FrameLoaderClient client methods for retrieving that value.
2049
2050         * DumpRenderTree/TestRunner.cpp:
2051         (setShouldSendDoNotTrackHTTPHeaderCallback): Pass through to the TestRunner.
2052         (TestRunner::staticFunctions): Add the setShouldSendDoNotTrackHTTPHeader function.
2053         * DumpRenderTree/TestRunner.h:
2054         (TestRunner::setShouldSendDoNotTrackHTTPHeader): Simple setter.
2055         (TestRunner::shouldSendDoNotTrackHTTPHeader): Simple getter.
2056         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2057         (-[FrameLoadDelegate webViewShouldSendDoNotTrackHTTPHeader:]): 
2058             Pass the question on to the TestRunner.
2059         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2060         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2061         (WTR::InjectedBundlePage::InjectedBundlePage):
2062             Add the setShouldSendDoNotTrackHTTPHeader client function.
2063         (WTR::InjectedBundlePage::shouldSendDoNotTrackHTTPHeader):
2064             Pass the question on to the TestRunner.
2065         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2066         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2067         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2068         (WTR::TestRunner::shouldSendDoNotTrackHTTPHeader): Simple getter.
2069         (WTR::TestRunner::setShouldSendDoNotTrackHTTPHeader): Simple Setter.
2070
2071 2012-09-10  Ojan Vafai  <ojan@chromium.org>
2072
2073         Make EFL bots work on the flakiness dashboard
2074         https://bugs.webkit.org/show_bug.cgi?id=96164
2075
2076         Reviewed by Tony Chang.
2077
2078         Also, update outdated unittests that had started failing.
2079
2080         * TestResultServer/static-dashboards/builders.js:
2081         (isWebkitTestRunner):
2082         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2083         (nonChromiumPlatform):
2084         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2085         (test):
2086
2087 2012-09-10  Tommy Widenflycht  <tommyw@google.com>
2088
2089         [chromium] MediaStream API: Remove the Descriptor postfix
2090         https://bugs.webkit.org/show_bug.cgi?id=96268
2091
2092         Reviewed by Adam Barth.
2093
2094         After consideration I realized that there is no need whatsoever in using the Descriptor prefix
2095         in the WekKit embedder API. Removed from WebRTCSessionDescription and WebRTCICECandidate to start with.
2096
2097         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2098         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
2099         (MockWebRTCPeerConnectionHandler::createOffer):
2100         (MockWebRTCPeerConnectionHandler::createAnswer):
2101         (MockWebRTCPeerConnectionHandler::setLocalDescription):
2102         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
2103         (MockWebRTCPeerConnectionHandler::localDescription):
2104         (MockWebRTCPeerConnectionHandler::remoteDescription):
2105         (MockWebRTCPeerConnectionHandler::addICECandidate):
2106         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2107         (MockWebRTCPeerConnectionHandler):
2108
2109 2012-09-10  Arnaud Renevier  <a.renevier@sisa.samsung.com>
2110
2111         [Gtk] failure to build jhbuild dependencies with cups 1.6
2112         https://bugs.webkit.org/show_bug.cgi?id=95991
2113
2114         Reviewed by Gustavo Noronha Silva.
2115
2116         Bump gtk+ and gnome-themes-standard dependencies to 3.4.2 to allow
2117         building with cups >= 1.6 [GNOME #670373].
2118
2119         * gtk/jhbuild.modules:
2120
2121 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
2122
2123         [EFL][DRT] Encoding issue in printed console messages
2124         https://bugs.webkit.org/show_bug.cgi?id=96263
2125
2126         Reviewed by Kenneth Rohde Christiansen.
2127
2128         Correctly handle CONSOLE messages that contain non-ascii
2129         characters in EFL's DRT. We need to use String::fromUTF8()
2130         to construct a WTF::String from a raw string.
2131
2132         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2133         (onConsoleMessage):
2134
2135 2012-09-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2136
2137         [WK2][WTR] User style sheet location should be reset before each test
2138         https://bugs.webkit.org/show_bug.cgi?id=96262
2139
2140         Reviewed by Kenneth Rohde Christiansen.
2141
2142         User style sheet location is reset before each test now.
2143
2144         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2145         (WTR::InjectedBundle::beginTesting):
2146
2147 2012-09-10  Simon Hausmann  <simon.hausmann@nokia.com>
2148
2149         Fix build of WTR with Qt on Windows
2150         https://bugs.webkit.org/show_bug.cgi?id=96249
2151
2152         Reviewed by Kenneth Rohde Christiansen.
2153
2154         Windows loves to define min and max as macros, which beautifully
2155         clashes in many places where min and max are used as variable or method
2156         names. It can be convinced not to do this when min and max are already
2157         define as macros (expanding to themselves). We have this kind of
2158         workaround in config.h files all over WebKit and as it turns out when
2159         building WTR with Qt on Windows we do end up with such a clash. Therefore
2160         we need the same workaround.
2161
2162         * WebKitTestRunner/config.h:
2163
2164 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
2165
2166         [WK2] New fast/forms/number/number-interactive-validation-required.html fails
2167         https://bugs.webkit.org/show_bug.cgi?id=95936
2168
2169         Reviewed by Kenneth Rohde Christiansen.
2170
2171         Enable interactive form validation setting in WebKitTestRunner as
2172         we are currently doing in DumpRenderTree. This is needed for some
2173         tests to pass.
2174
2175         * WebKitTestRunner/TestController.cpp:
2176         (WTR::TestController::resetStateToConsistentValues):
2177
2178 2012-09-09  Zan Dobersek  <zandobersek@gmail.com>
2179
2180         Clean up the code in XvfbDriver
2181         https://bugs.webkit.org/show_bug.cgi?id=96202
2182
2183         Reviewed by Philippe Normand.
2184
2185         Changes:
2186         - Remove unneeded imports,
2187         - assign the _lock_file member variable when the display number is determined,
2188         - no need for parentheses around a single string format argument,
2189         - use FileSystem.exists method when checking if lock file is present as it
2190         makes the intention much more clearer.
2191
2192         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
2193         (XvfbDriver._start):
2194         (XvfbDriver.stop):
2195
2196 2012-09-09  Patrick Gansterer  <paroga@webkit.org>
2197
2198         Make the String initialization on the function side of String::number()
2199         https://bugs.webkit.org/show_bug.cgi?id=95940
2200
2201         Reviewed by Benjamin Poulain.
2202
2203         * TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp:
2204         (testBoundaries):
2205         (testNumbers):
2206
2207 2012-09-09  Pierre Rossi  <pierre.rossi@gmail.com>
2208
2209         [WK2] expose element rect for color input type
2210         https://bugs.webkit.org/show_bug.cgi?id=91664
2211
2212         Reviewed by Simon Hausmann.
2213
2214         Update the QML logic in MiniBrowser to take advantage of this.
2215         The picker size is now hardcoded and we try to place it below the
2216         input element if possible.
2217
2218         * MiniBrowser/qt/qml/ColorChooser.qml:
2219
2220 2012-09-08  Christophe Dumez  <christophe.dumez@intel.com>
2221
2222         [WK2] New fast/events/tab-focus-link-in-canvas fails from r126908
2223         https://bugs.webkit.org/show_bug.cgi?id=95329
2224
2225         Reviewed by Kenneth Rohde Christiansen.
2226
2227         Explicitely disable TabToLinks setting in WebKitTestRunner.
2228         Tests override the "WebKitTabToLinksPreferenceKey" preference
2229         to enable it.
2230
2231         * WebKitTestRunner/TestController.cpp:
2232         (WTR::TestController::resetStateToConsistentValues):
2233
2234 2012-09-08  Kenichi Ishibashi  <bashi@chromium.org>
2235
2236         webkit.py gdb pretty printer can't print CString
2237         https://bugs.webkit.org/show_bug.cgi?id=96068
2238
2239         Reviewed by Tony Chang.
2240
2241         Update WTFCStringPrinter to follow r126191.
2242
2243         * gdb/webkit.py:
2244         (WTFCStringPrinter.to_string):
2245
2246 2012-09-07  Benjamin Poulain  <bpoulain@apple.com>
2247
2248         Rename the ustring() accessor to string()
2249         https://bugs.webkit.org/show_bug.cgi?id=95919
2250
2251         Reviewed by Geoffrey Garen.
2252
2253         Update EFL's DRT.
2254
2255         Fix some string conversion that have been made useless
2256         with recent changes.
2257
2258         * DumpRenderTree/efl/EventSender.cpp:
2259         (keyPadNameFromJSValue):
2260         (keyNameFromJSValue):
2261         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2262         (TestRunner::queueLoad):
2263         (TestRunner::addOriginAccessWhitelistEntry):
2264         (TestRunner::removeOriginAccessWhitelistEntry):
2265         (TestRunner::setUserStyleSheetLocation):
2266         (TestRunner::setValueForUser):
2267         (TestRunner::elementDoesAutoCompleteForElementWithId):
2268         (TestRunner::execCommand):
2269         (TestRunner::findString):
2270         (TestRunner::isCommandEnabled):
2271         (TestRunner::clearApplicationCacheForOrigin):
2272         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
2273         (TestRunner::pauseAnimationAtTimeOnElementWithId):
2274         (TestRunner::pauseTransitionAtTimeOnElementWithId):
2275         (toInt):
2276         (TestRunner::overridePreference):
2277         (TestRunner::addUserScript):
2278         (TestRunner::addUserStyleSheet):
2279         (TestRunner::evaluateInWebInspector):
2280         (TestRunner::evaluateScriptInIsolatedWorld):
2281         (TestRunner::setTextDirection):
2282         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
2283         (LoadItem::invoke):
2284         (LoadHTMLStringItem::invoke):
2285         (ScriptItem::invoke):
2286
2287 2012-09-06  Jeffrey Pfau  <jpfau@apple.com>
2288
2289         Extend third-party storage blocking API to optionally allow blocking all storage
2290         https://bugs.webkit.org/show_bug.cgi?id=95915
2291
2292         Reviewed by Brady Eidson.
2293
2294         Modified API test to use new revised API.
2295
2296         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2297         (TestWebKitAPI::TEST):
2298
2299 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
2300
2301         AX: WebCore accessibility roles should be cross-platform
2302         https://bugs.webkit.org/show_bug.cgi?id=94870
2303
2304         Reviewed by Chris Fleizach.
2305
2306         Add debug strings to Chromium for new accessibility roles.
2307
2308         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2309         (roleToString):
2310
2311 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
2312
2313         AX: Chromium needs access to canvasHasFallbackContent
2314         https://bugs.webkit.org/show_bug.cgi?id=96124
2315
2316         Reviewed by Chris Fleizach.
2317
2318         Distinguish between canvas roles with and without fallback
2319         content on Chromium.
2320
2321         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2322         (getRole):
2323
2324 2012-09-07  Ojan Vafai  <ojan@chromium.org>
2325
2326         Handle non-existant TestExpectations files gracefully
2327         https://bugs.webkit.org/show_bug.cgi?id=96149
2328
2329         Reviewed by Eric Seidel.
2330
2331         Even when we get rid of Skipped files, we shouldn't have each port
2332         require a TestExpectations file for each platform if it doesn't
2333         need one.
2334
2335         * Scripts/webkitpy/layout_tests/port/base.py:
2336         (Port.expectations_dict):
2337         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2338         (PortTest.test_nonexistant_expectations):
2339
2340 2012-09-07  Tony Chang  <tony@chromium.org>
2341
2342         Regression: check-webkit-style no longer checks TestExpectations for syntax errors
2343         https://bugs.webkit.org/show_bug.cgi?id=96136
2344
2345         Reviewed by Ojan Vafai.
2346
2347         When we renamed the file to TestExpectations, it was no longer considered a text file so
2348         it was no longer being checked. Since then, test_expectations_overrides() has been removed
2349         from the port object, so I've removed that from the check. I'm not sure what it was
2350         supposed to do.
2351
2352         * Scripts/webkitpy/style/checker.py:
2353         (CheckerDispatcher._file_type): Mark TestExpectations as a text file.
2354         * Scripts/webkitpy/style/checkers/test_expectations.py:
2355         (TestExpectationsChecker.check_test_expectations): Remove overrides param.
2356         (TestExpectationsChecker.check): Remove overrides param.
2357         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2358         (TestExpectationsTestCase.assert_lines_lint): Remove overrides param.
2359
2360 2012-09-07  Christophe Dumez  <christophe.dumez@intel.com>
2361
2362         [EFL] Use same default minimum logical font size in DRT and WTR
2363         https://bugs.webkit.org/show_bug.cgi?id=96116
2364
2365         Reviewed by Martin Robinson.
2366
2367         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2368         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Set minimum
2369         logical font size to 9 to match the value used in WTR.
2370         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2371         (WTR::InjectedBundle::beginTesting): Explicitly set the minimum
2372         logical font size to 9 (default value in WK2)
2373
2374 2012-09-07  Tommy Widenflycht  <tommyw@google.com>
2375
2376         MediaStream API: add RTCPeerConnection::createAnswer
2377         https://bugs.webkit.org/show_bug.cgi?id=96092
2378
2379         Reviewed by Adam Barth.
2380
2381         Expanding and enhancing MockWebRTCPeerConnectionHandler.
2382
2383         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2384         (MockWebRTCPeerConnectionHandler::createOffer):
2385         (MockWebRTCPeerConnectionHandler::createAnswer):
2386         (MockWebRTCPeerConnectionHandler::setLocalDescription):
2387         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
2388         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2389         (MockWebRTCPeerConnectionHandler):
2390
2391 2012-09-07  Dean Jackson  <dino@apple.com>
2392
2393         Unreviewed changes to watchlist.
2394
2395         - Add new WebGL and Filters definitions
2396         - Add myself to OpenGL bugs
2397
2398         * Scripts/webkitpy/common/config/watchlist:
2399
2400 2012-09-07  Peter Beverloo  <peter@chromium.org>
2401
2402         Actually trigger the Android Tester
2403         https://bugs.webkit.org/show_bug.cgi?id=96118
2404
2405         Reviewed by Adam Barth.
2406
2407         * BuildSlaveSupport/build.webkit.org-config/config.json:
2408
2409 2012-09-07  Dominic Mazzoni <dmazzoni@google.com>
2410
2411         New time input needs accessibility
2412         https://bugs.webkit.org/show_bug.cgi?id=96032
2413
2414         Reviewed by Chris Fleizach.
2415
2416         Add support for valueDescription for testing.
2417
2418         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2419         (getValueDescription):
2420         (AccessibilityUIElement::AccessibilityUIElement):
2421         (AccessibilityUIElement::valueDescriptionGetterCallback):
2422         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h:
2423         (AccessibilityUIElement):
2424
2425 2012-09-07  Peter Beverloo  <peter@chromium.org>
2426
2427         Add the google-android-tests build slave to the master's config
2428         https://bugs.webkit.org/show_bug.cgi?id=96113
2429
2430         Reviewed by Csaba Osztrogonác.
2431
2432         * BuildSlaveSupport/build.webkit.org-config/config.json:
2433
2434 2012-09-07  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2435
2436         [WK2] [EFL] Set theme for WebKit2 API test runner
2437         https://bugs.webkit.org/show_bug.cgi?id=96100
2438
2439         Reviewed by Kenneth Rohde Christiansen.
2440
2441         Set the theme generated by the build for the WebKit2 API test runner.
2442
2443         * TestWebKitAPI/PlatformEfl.cmake:
2444         * TestWebKitAPI/efl/PlatformWebView.cpp:
2445         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2446
2447 2012-09-07  Csaba Osztrogonác  <ossy@webkit.org>
2448
2449         Unreviewed. Add Gábor Ballabás as contributor.
2450
2451         * Scripts/webkitpy/common/config/committers.py:
2452
2453 2012-09-07  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
2454
2455         [Qt] Fix ROOT_BUILD_DIR on Windows MSVC build.
2456         https://bugs.webkit.org/show_bug.cgi?id=96078
2457
2458         Reviewed by Tor Arne Vestbø.
2459
2460         Correct JSC, DumpRenderTree, ImageDiff, QtTestBrowser binaries location by adding $$toSystemPath to ROOT_BUILD_DIR generation.
2461
2462         * qmake/mkspecs/features/default_pre.prf:
2463
2464 2012-09-07  Christophe Dumez  <christophe.dumez@intel.com>
2465
2466         [EFL] Add TestExpectations file for efl-wk1
2467         https://bugs.webkit.org/show_bug.cgi?id=96019
2468
2469         Reviewed by Gyuyoung Kim.
2470
2471         Update TestExpectations cascading for EFL port
2472         so that we use efl-wk1 -> efl search paths
2473         for WebKit1 EFL.
2474
2475         * Scripts/webkitpy/layout_tests/port/efl.py:
2476         (EflPort._search_paths):
2477
2478 2012-09-07  Zan Dobersek  <zandobersek@gmail.com>
2479
2480         [NRWT] XvfbDriver should stop the Xvfb more aggressively
2481         https://bugs.webkit.org/show_bug.cgi?id=95097
2482
2483         Reviewed by Dirk Pranke.
2484
2485         The Xvfb process is now killed when the XvfbDriver is stopping. Simply
2486         terminating the process does not always work as expected, leading to timeouts
2487         in run-webkit-tests on the buildbot. The lock file Xvfb creates is also removed
2488         as it's not removed by the killed Xvfb process.
2489
2490         Also included is a thorough unittest for XvfbDriver. Proper starting of the driver
2491         is tested in different circumstances - whether pixel tests are enabled or not,
2492         with an arbitrary worker number or with an Xorg process already running on the system.
2493         The stopping of the driver is tested by checking that the Xvfb process is truly killed
2494         and then set to None.
2495
2496         * BuildSlaveSupport/kill-old-processes:
2497         Kill any stale Xvfb processes at the start of the build cycle so no Xvfb
2498         is left running, potentially clogging up a display at a certain position.
2499         * Scripts/webkitpy/common/system/executive_mock.py:
2500         (MockExecutive.__init__):
2501         The _running_pids is now a dictionary with process names as keys and pids
2502         as values.
2503         (MockExecutive.check_running_pid):
2504         Check whether the passed-in pid is in the _running_pids dictionary's values.
2505         (MockExecutive):
2506         (MockExecutive.running_pids):
2507         This method returns the list of all the process pids of which the name passes
2508         through the process_name_filter.
2509         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
2510         Use the Executive object of the port's host to check for running pids and open
2511         new subprocesses or kill them throughout the class.
2512         (XvfbDriver._start):
2513         Use the _server_process_constructor to make testing the XvfbDriver possible. Also,
2514         start the server process after it's created.
2515         (XvfbDriver.stop):
2516         Now kills the Xvfb process instead of terminating it and waiting for it to close.
2517         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py: Added.
2518         (XvfbDriverTest):
2519         (XvfbDriverTest.make_driver):
2520         (XvfbDriverTest.assertDriverStartSuccessful):
2521         (XvfbDriverTest.test_start_no_pixel_tests):
2522         (XvfbDriverTest.test_start_pixel_tests):
2523         (XvfbDriverTest.test_start_arbitrary_worker_number):
2524         (XvfbDriverTest.test_start_existing_xorg_process):
2525         (XvfbDriverTest.test_stop):
2526         (XvfbDriverTest.test_stop.FakeXvfbProcess):
2527
2528 2012-09-06  Peter Beverloo  <peter@chromium.org>
2529
2530         Introduce the Chromium Android Release (Tests) bot
2531         https://bugs.webkit.org/show_bug.cgi?id=95980
2532
2533         Reviewed by Adam Barth.
2534
2535         This adds the Chromium Android Release (Tests) bot to the WebKit waterfall,
2536         which will be running layout tests on actual Android devices. Right now,
2537         four Galaxy Nexus phones are attached.
2538
2539         * BuildSlaveSupport/build.webkit.org-config/config.json:
2540
2541 2012-09-06  James Robinson  <jamesr@chromium.org>
2542
2543         [chromium] Use WebCompositorSupport functions instead of WebCompositor statics
2544         https://bugs.webkit.org/show_bug.cgi?id=96007
2545
2546         Reviewed by Adrienne Walker.
2547
2548         Fixes initialization / settings code to use WebCompositorSupport.
2549
2550         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2551         (main):
2552         * DumpRenderTree/chromium/TestShell.cpp:
2553         (TestShell::initialize):
2554         (TestShell::setPerTilePaintingEnabled):
2555
2556 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
2557
2558         [EFL][WK2] Provide implementation for PlatformWebView::windowFrame()
2559         https://bugs.webkit.org/show_bug.cgi?id=95995
2560
2561         Reviewed by Kenneth Rohde Christiansen.
2562
2563         Provide proper implementation for PlatformWebView::windowFrame()
2564         in EFL's WebKitTestRunner.
2565
2566         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2567         (WTR::PlatformWebView::windowFrame):
2568
2569 2012-09-06  Fady Samuel  <fsamuel@chromium.org>
2570
2571         Fix WTF.Lrint on 32-bit platforms
2572         https://bugs.webkit.org/show_bug.cgi?id=96003
2573
2574         Reviewed by Benjamin Poulain.
2575
2576         Fixed failing WTF.Lrint test on 32-bit platforms.
2577
2578         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2579         (TestWebKitAPI::TEST):
2580
2581 2012-09-06  Tommy Widenflycht  <tommyw@google.com>
2582
2583         MediaStream API: Add the local and remote description functionality to RTCPeerConnection
2584         https://bugs.webkit.org/show_bug.cgi?id=95839
2585
2586         Reviewed by Adam Barth.
2587
2588         In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
2589         up the task definitions a bit. There was no need to have them in the header file.
2590
2591         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2592         (RTCSessionDescriptionRequestSuccededTask):
2593         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
2594         (RTCSessionDescriptionRequestFailedTask):
2595         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
2596         (RTCVoidRequestTask):
2597         (RTCVoidRequestTask::RTCVoidRequestTask):
2598         (MockWebRTCPeerConnectionHandler::createOffer):
2599         (MockWebRTCPeerConnectionHandler::setLocalDescription):
2600         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
2601         (MockWebRTCPeerConnectionHandler::localDescription):
2602         (MockWebRTCPeerConnectionHandler::remoteDescription):
2603         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2604         (MockWebRTCPeerConnectionHandler):
2605
2606 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
2607
2608         [Qt] Fix build on Mac OS X 10.6
2609         https://bugs.webkit.org/show_bug.cgi?id=95200
2610
2611         Reviewed by Tor Arne Vestbø.
2612
2613         The build on Mac OS X 10.6 is broken when using QuickTime. Enable it only for
2614         10.7 and newer.
2615
2616         * qmake/mkspecs/features/features.prf:
2617
2618 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
2619
2620         [WKTR] addSelectionKey should be mapped to "Control" modifiers on other OSes than Mac
2621         https://bugs.webkit.org/show_bug.cgi?id=95973
2622
2623         Reviewed by Kenneth Rohde Christiansen.
2624
2625         Correctly map "addSelectionKey" to "Control" modifier
2626         in WKTR's EventSender on other OSes than Mac OS X,
2627         instead of mapping it to the "Meta" modifier.
2628
2629         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2630         (WTR::parseModifier):
2631
2632 2012-09-06  Balazs Kelemen  <kbalazs@webkit.org>
2633
2634         [nrwt] Harden against empty stdout/stderr after stopping a crashed/timed out driver
2635         https://bugs.webkit.org/show_bug.cgi?id=95710
2636
2637         Reviewed by Dirk Pranke.
2638
2639         The stdout / stderr output can be None so make sure
2640         we won't raise an exception in this case.
2641
2642         * Scripts/webkitpy/layout_tests/port/driver.py:
2643         (Driver.run_test):
2644
2645 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
2646
2647         [EFL] Sanitize URLs in EWebLauncher / Minibrowser
2648         https://bugs.webkit.org/show_bug.cgi?id=95849
2649
2650         Reviewed by Kenneth Rohde Christiansen.
2651
2652         Sanitize URLs passed by the user as program
2653         argument or typed in the URL bar in order to
2654         be more tolerant.
2655
2656         * EWebLauncher/CMakeLists.txt:
2657         * EWebLauncher/main.c:
2658         (main):
2659         * EWebLauncher/url_bar.c:
2660         (_url_bar_url_get_with_protocol):
2661         (on_urlbar_key_down):
2662         * EWebLauncher/url_utils.c: Added.
2663         (has_scheme):
2664         (url_from_user_input): Add utility function to construct a
2665         URL from user input.
2666         * EWebLauncher/url_utils.h: Added.
2667         * MiniBrowser/efl/CMakeLists.txt:
2668         * MiniBrowser/efl/main.c:
2669         (main):
2670
2671 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
2672
2673         [Qt] Various small Windows / MSVC build fixes
2674         https://bugs.webkit.org/show_bug.cgi?id=95934
2675
2676         Reviewed by Kenneth Rohde Christiansen.
2677
2678         setFocus takes a boolean as argument: Don't try to implicitly convert
2679         an enum to a boolean, MSVC doesn't like that. The intent here is to
2680         enable focus, so just pass true.
2681
2682         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2683         (WTR::PlatformWebView::focus):
2684
2685 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
2686
2687         [Qt] Fix build with ANGLE on platforms that provide EGL/GLESv2
2688         https://bugs.webkit.org/show_bug.cgi?id=95965
2689
2690         Reviewed by Tor Arne Vestbø.
2691
2692         Add ANGLE as a static library module to the Qt WebKit build system.
2693
2694         * qmake/mkspecs/features/default_post.prf:
2695         * qmake/mkspecs/modules/angle.prf: Added.
2696
2697 2012-09-06  Andras Becsi  <andras.becsi@nokia.com>
2698
2699         [WK2] Make [Qt]ViewportHandler cross platform
2700         https://bugs.webkit.org/show_bug.cgi?id=91257
2701
2702         Reviewed by Kenneth Rohde Christiansen.
2703
2704         Remove initial scale from viewport info item since it is
2705         set to -1 after applied thus it does not hold any valuable
2706         information.
2707
2708         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
2709
2710 2012-09-05  Tony Chang  <tony@chromium.org>
2711
2712         [chromium] Remove dependency on webkit_user_agent
2713         https://bugs.webkit.org/show_bug.cgi?id=95886
2714
2715         Reviewed by Adam Barth.
2716
2717         The code isn't used by DumpRenderTree.
2718
2719         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2720
2721 2012-09-05  Rick Byers  <rbyers@chromium.org>
2722
2723         Update chromium DumpRenderTree for new WebGestureEvent fields
2724         https://bugs.webkit.org/show_bug.cgi?id=95573
2725
2726         Reviewed by James Robinson.
2727
2728         Update EventSender to write gesture details into the appropriate
2729         type-specific WebGestureEvent fields.
2730         * DumpRenderTree/chromium/TestRunner/EventSender.cpp:
2731         (EventSender::gestureEvent):
2732         (EventSender::gestureFlingStart):
2733
2734 2012-09-05  Dirk Pranke  <dpranke@chromium.org>
2735
2736         NRWT lies about the number of tests that it's skipping when used with --repeat-each
2737         https://bugs.webkit.org/show_bug.cgi?id=95789
2738
2739         Reviewed by Ojan Vafai.
2740
2741         Fix miscalculation in log message.
2742
2743         * Scripts/webkitpy/layout_tests/views/printing.py:
2744         (Printer.print_found):
2745
2746 2012-09-05  Kenichi Ishibashi  <bashi@chromium.org>
2747
2748         Unreviewed, rolling out r127612, r127660, and r127664.
2749         http://trac.webkit.org/changeset/127612
2750         http://trac.webkit.org/changeset/127660
2751         http://trac.webkit.org/changeset/127664
2752         https://bugs.webkit.org/show_bug.cgi?id=95920
2753
2754         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2755         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
2756         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
2757         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
2758         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
2759         (MockWebRTCPeerConnectionHandler::createOffer):
2760         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2761         (MockWebRTCPeerConnectionHandler):
2762         (SuccessCallbackTask):
2763         (FailureCallbackTask):
2764
2765 2012-09-05  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
2766
2767         Ignore-metrics includes scroll offsets.
2768         https://bugs.webkit.org/show_bug.cgi?id=95845
2769
2770         Reviewed by Dirk Pranke.
2771
2772         Strip scroll-offsets the same way scroll-height and scroll-width is stripped.
2773
2774         * Scripts/old-run-webkit-tests:
2775         (stripMetrics):
2776         * Scripts/webkitpy/layout_tests/port/driver.py:
2777         (DriverOutput):
2778
2779 2012-09-05  Zan Dobersek  <zandobersek@gmail.com>
2780
2781         Unreviewed test fix.
2782
2783         Including a plugin source file into the build that was added in r127595.
2784
2785         * GNUmakefile.am:
2786
2787 2012-09-05  Tommy Widenflycht  <tommyw@google.com>
2788
2789         MediaStream API: Add the local and remote description functionality to RTCPeerConnection
2790         https://bugs.webkit.org/show_bug.cgi?id=95839
2791
2792         Reviewed by Adam Barth.
2793
2794         In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
2795         up the task definitions a bit. There was no need to have them in the header file.
2796
2797         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2798         (RTCSessionDescriptionRequestSuccededTask):
2799         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
2800         (RTCSessionDescriptionRequestFailedTask):
2801         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
2802         (RTCVoidRequestTask):
2803         (RTCVoidRequestTask::RTCVoidRequestTask):
2804         (MockWebRTCPeerConnectionHandler::createOffer):
2805         (MockWebRTCPeerConnectionHandler::setLocalDescription):
2806         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
2807         (MockWebRTCPeerConnectionHandler::localDescription):
2808         (MockWebRTCPeerConnectionHandler::remoteDescription):
2809         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2810         (MockWebRTCPeerConnectionHandler):
2811
2812 2012-09-05  Kangil Han  <kangil.han@samsung.com>
2813
2814         [EFL] Remove '+=' usage in String
2815         https://bugs.webkit.org/show_bug.cgi?id=95808
2816
2817         Reviewed by Benjamin Poulain.
2818
2819         Replaced use of String operator '+=' with StringBuilder.append*() in order to adopt efficient String concatenation.
2820
2821         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2822         (descriptionSuitableForTestResult):
2823
2824 2012-09-05  Christophe Dumez  <christophe.dumez@intel.com>
2825
2826         [EFL][WK2] Provide implementation for TestRunner::pathToLocalResource()
2827         https://bugs.webkit.org/show_bug.cgi?id=95842
2828
2829         Reviewed by Kenneth Rohde Christiansen.
2830
2831         Provide proper implementation for TestRunner::pathToLocalResource()
2832         in EFL WKTR, identical to the one for DumpRenderTree.
2833
2834         Map /tmp to ${DUMPRENDERTREE_TEMP} environment variable and
2835         /tmp/LayoutTests to ${LOCAL_RESOURCE_ROOT} so that local resources
2836         are found my WebKitTestRunner.
2837
2838         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
2839         (WTR::TestRunner::pathToLocalResource):
2840
2841 2012-09-05  Brady Eidson  <beidson@apple.com>
2842
2843         Frequent crashes in PluginView::scriptObject under runtimeObjectCustomGetOwnPropertySlot
2844         <rdar://problem/12142226> and https://bugs.webkit.org/show_bug.cgi?id=95026
2845
2846         Reviewed by Andy Estes.
2847
2848         Add a plug-in that always fails to initialize:
2849         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPNewFails.cpp: Added.
2850         (NPPNewFails):
2851         (NPPNewFails::NPPNewFails):
2852         (NPPNewFails::NPP_New):
2853
2854         Add it to all the project files:
2855         * DumpRenderTree/DumpRenderTree.gypi:
2856         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2857         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2858         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2859         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2860
2861 2012-09-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2862
2863         [Qt] Fix makefile race condition between derived sources and target
2864
2865         r121966 removed too much of the old qmake logic, including the rule
2866         that ensured that qmake_all would not trigger dual runs of qmake --
2867         one of the derived sources -qmake-all rule, and one for making the
2868         derived sources.
2869
2870         We now follow a similar pattern as before, by introducing a custom
2871         target that explicitly depends on the derived sources' qmake-all before
2872         doing a manual run of make. That ensures a single qmake run for the derived
2873         sources.
2874
2875         https://bugs.webkit.org/show_bug.cgi?id=93847
2876
2877         Reviewed by Csaba Osztrogonác.
2878
2879         * qmake/mkspecs/features/functions.prf:
2880
2881 2012-09-05  Christophe Dumez  <christophe.dumez@intel.com>
2882
2883         WKTR doesn't implement dumpWillCacheResponse()
2884         https://bugs.webkit.org/show_bug.cgi?id=94607
2885
2886         Reviewed by Kenneth Rohde Christiansen.
2887
2888         Define shouldCacheResponse() callback in resource
2889         load client and provide implementation for
2890         dumpWillCacheResponse() in WebKitTestRunner.
2891
2892         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2893         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2894         (WTR::InjectedBundlePage::InjectedBundlePage):
2895         (WTR::InjectedBundlePage::shouldCacheResponse):
2896         (WTR):
2897         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2898         (InjectedBundlePage):
2899         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2900         (WTR::TestRunner::TestRunner):
2901         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2902         (WTR::TestRunner::dumpWillCacheResponse):
2903         (WTR::TestRunner::shouldDumpWillCacheResponse):
2904         (TestRunner):
2905
2906 2012-09-05  Kaustubh Atrawalkar  <kaustubh@motorola.com>
2907
2908         [DRT] LTC:: Move printing related APIs from LayoutTestController to Internals
2909         https://bugs.webkit.org/show_bug.cgi?id=92735
2910
2911         Reviewed by Hajime Morita.
2912
2913         Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
2914
2915         * DumpRenderTree/TestRunner.cpp:
2916         (TestRunner::staticFunctions):
2917         * DumpRenderTree/TestRunner.h:
2918         (TestRunner):
2919         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2920         (TestRunner::addUserStyleSheet):
2921         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2922         (DRTTestRunner::DRTTestRunner):
2923         (DRTTestRunner::hasCustomPageSizeStyle):
2924         * DumpRenderTree/chromium/DRTTestRunner.h:
2925         (DRTTestRunner):
2926         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2927         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2928         * DumpRenderTree/mac/TestRunnerMac.mm:
2929         * DumpRenderTree/qt/TestRunnerQt.cpp:
2930         (TestRunner::evaluateScriptInIsolatedWorld):
2931         * DumpRenderTree/qt/TestRunnerQt.h:
2932         (TestRunner):
2933         * DumpRenderTree/win/TestRunnerWin.cpp:
2934         * DumpRenderTree/wx/TestRunnerWx.cpp:
2935         (TestRunner::abortModal):
2936         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2937         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2938         (WTR):
2939         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2940         (TestRunner):
2941
2942 2012-09-05  Simon Hausmann  <simon.hausmann@nokia.com>
2943
2944         [Qt] Automate the use of AllInOne files in the Qt build
2945         https://bugs.webkit.org/show_bug.cgi?id=95837
2946
2947         Reviewed by Tor Arne Vestbø.
2948
2949         New feature file that implements the all-in-one file automation by
2950         adding the requested all-in-one files to SOURCES and removing the files
2951         it includes from SOURCES.
2952
2953         * qmake/mkspecs/features/use_all_in_one_files.prf: Added.
2954
2955 2012-09-04  Tim Horton  <timothy_horton@apple.com>
2956
2957         Have NRWT log more output when crash logs are missing
2958         https://bugs.webkit.org/show_bug.cgi?id=95814
2959
2960         Reviewed by Dan Bernstein.
2961
2962         Log the stderr and stdout of the test, in order to provide slightly more
2963         context when the WebProcess times out while running tests.
2964
2965         * Scripts/webkitpy/layout_tests/port/driver.py:
2966         (Driver.run_test):
2967
2968 2012-09-04  Xianzhu Wang  <wangxianzhu@chromium.org>
2969
2970         [Chromium-Android] Include device serial number in ChromiumAndroidDriver log messages
2971         https://bugs.webkit.org/show_bug.cgi?id=95770
2972
2973         Reviewed by Adam Barth.
2974
2975         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2976         (ChromiumAndroidDriver.__init__):
2977         (ChromiumAndroidDriver._log_error): Added to replace original _log.error().
2978         (ChromiumAndroidDriver._log_debug): Added to replace original _log.debug().
2979         (ChromiumAndroidDriver._abort): Added to replace original raise AssertionError().
2980         (ChromiumAndroidDriver._push_executable):
2981         (ChromiumAndroidDriver._push_fonts):
2982         (ChromiumAndroidDriver._push_test_resources):
2983         (ChromiumAndroidDriver._run_adb_command):
2984         (ChromiumAndroidDriver._get_last_stacktrace):
2985         (ChromiumAndroidDriver._get_crash_log):
2986         (ChromiumAndroidDriver._start):
2987         (ChromiumAndroidDriver._start_once):
2988         (ChromiumAndroidDriver._start_once.deadlock_detector):
2989         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
2990         (ChromiumAndroidDriverTest.test_get_crash_log):
2991
2992 2012-09-04  Satish Sampath  <satish@chromium.org>
2993
2994         Run git commands within the checkout directory
2995         https://bugs.webkit.org/show_bug.cgi?id=95742
2996
2997         Reviewed by Eric Seidel.
2998
2999         git commands run from scm/git.py are sometimes run with cwd set to the
3000         checkout_root and other times with whatever directory was the default cwd.
3001         Instead all these should run with the checkout root set as the cwd
3002         (except where we explicitly need a different path)
3003
3004         * Scripts/webkitpy/common/checkout/scm/git.py:
3005         (Git._run_git):
3006         (Git.find_checkout_root):
3007         (Git.discard_local_commits):
3008         (Git.local_commits):
3009         (Git.working_directory_is_clean):
3010         (Git.clean_working_directory):
3011         (Git.add_list):
3012         (Git.delete_list):
3013         (Git.exists):
3014         (Git._current_branch):
3015         (Git._changes_files_for_commit):
3016         (Git.revisions_changing_file):
3017         (Git.svn_revision):
3018         (Git._run_git_svn_find_rev):
3019         (Git.contents_at_revision):
3020         (Git.diff_for_file):
3021         (Git.show_head):
3022         (Git.committer_email_for_revision):
3023         (Git.apply_reverse_diff):
3024         (Git.revert_files):
3025         (Git.commit_with_message):
3026         (Git._commit_on_branch):
3027         (Git.svn_commit_log):
3028         (Git.last_svn_commit_log):
3029         (Git.svn_blame):
3030         (Git._branch_ref_exists):
3031         (Git.delete_branch):
3032         (Git.remote_merge_base):
3033         (Git.commit_locally_with_message):
3034         (Git.push_local_commits_to_server):
3035         (Git.commit_ids_from_commitish_arguments):
3036         (Git.commit_message_for_local_commit):
3037         (Git.files_changed_summary_for_commit):
3038
3039 2012-09-04  Tommy Widenflycht  <tommyw@google.com>
3040
3041         MediaStream API: Add the async createOffer functionality to RTCPeerConnection
3042         https://bugs.webkit.org/show_bug.cgi?id=95734
3043
3044         Reviewed by Adam Barth.
3045
3046         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3047         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
3048         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
3049         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
3050         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
3051         (MockWebRTCPeerConnectionHandler::createOffer):
3052         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3053         (MockWebRTCPeerConnectionHandler):
3054         (MockWebRTCPeerConnectionHandler::taskList):
3055         (SuccessCallbackTask):
3056         (FailureCallbackTask):
3057
3058 2012-09-04  Xianzhu Wang  <wangxianzhu@chromium.org>
3059
3060         [Chromium-Android] Output time and thread info in crash log
3061         https://bugs.webkit.org/show_bug.cgi?id=95768
3062
3063         Reviewed by Adam Barth.
3064
3065         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3066         (ChromiumAndroidDriver._get_logcat): Add '-v threadtime' to adb logcat command line to get time and thread info.
3067
3068 2012-09-04  Tommy Widenflycht  <tommyw@google.com>
3069
3070         MediaStream API: Change the MediaStreamTrackList track added/removed signaling
3071         https://bugs.webkit.org/show_bug.cgi?id=95721
3072
3073         Reviewed by Adam Barth.
3074
3075         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
3076         (MockWebMediaStreamCenter::didAddMediaStreamTrack):
3077         (MockWebMediaStreamCenter::didRemoveMediaStreamTrack):
3078         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
3079         (MockWebMediaStreamCenter):
3080
3081 2012-09-04  Tony Chang  <tony@chromium.org>
3082
3083         Elide test names when running new-run-webkit-tests
3084         https://bugs.webkit.org/show_bug.cgi?id=95626
3085
3086         Reviewed by Dirk Pranke.
3087
3088         When the test name exceeds the number of terminal columns, it leaves
3089         text on the screen. Avoid this by eliding the test name when running
3090         tests. This is similar to what ninja does when compiling.
3091
3092         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
3093         (MeteredStream):
3094         (MeteredStream.number_of_columns): Helper method to get number of
3095         terminal columns. Won't work on Win32 python, but meh.
3096         * Scripts/webkitpy/layout_tests/views/printing.py:
3097         (Printer._test_status_line): New method for eliding the text. Doesn't use \u2026
3098         because stderr appears to be ascii only.
3099         (Printer.print_started_test): Route through _test_status_line.
3100         (Printer.print_finished_test): Route through _test_status_line.
3101         (Printer._print_test_trace): Route through _test_status_line.
3102         (Printer._print_baseline): Route through _test_status_line.
3103         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3104         (test_test_status_line): Test for _test_status_line.
3105
3106 2012-09-04  Martin Robinson  <mrobinson@igalia.com>
3107
3108         [GTK] Print API missing documentation when generating gtkdoc
3109         https://bugs.webkit.org/show_bug.cgi?id=95703
3110
3111         Reviewed by Carlos Garcia Campos.
3112
3113         Print out API missing documentation when generating gtkdoc. This makes it
3114         easier to fix documentation errors.
3115
3116         * gtk/generate-gtkdoc:
3117         (print_missing_api): Added.
3118         (generate_doc): Inline the rebase step, since it now reports an error
3119         when you try to rebase without generating documentation first.
3120         * gtk/gtkdoc.py:
3121         (GTKDoc.rebase_installed_docs): Raise an error when rebasing without
3122         generating documentation first to enable a small cleanup at the caller.
3123         (GTKDoc.api_missing_documentation): Added.
3124
3125 2012-09-04  Vincent Scheib  <scheib@chromium.org>
3126
3127         [Chromium] Allow asyncronous response of pointer lock requests in layout tests.
3128         https://bugs.webkit.org/show_bug.cgi?id=95628
3129
3130         Reviewed by James Robinson.
3131
3132         Future tests need the ability to respond asynchronously that
3133         pointer lock requests have been accepted or rejected. This patch
3134         adds the following:
3135             testRunner.setPointerLockWillRespondAsynchronously();
3136             testRunner.didAcquirePointerLock();
3137             testRunner.didNotAcquirePointerLock();
3138
3139         Tested in existing test:
3140             pointerlockchange-pointerlockerror-events.html
3141
3142         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3143         (DRTTestRunner::DRTTestRunner):
3144         (DRTTestRunner::didAcquirePointerLock):
3145         (DRTTestRunner::didNotAcquirePointerLock):
3146         (DRTTestRunner::setPointerLockWillRespondAsynchronously):
3147         * DumpRenderTree/chromium/DRTTestRunner.h:
3148         (DRTTestRunner):
3149         * DumpRenderTree/chromium/WebViewHost.cpp:
3150         (WebViewHost::requestPointerLock):
3151         (WebViewHost::didAcquirePointerLock):
3152         (WebViewHost::didNotAcquirePointerLock):
3153         * DumpRenderTree/chromium/WebViewHost.h:
3154         (WebViewHost):
3155         (WebViewHost::setPointerLockWillRespondAsynchronously):
3156
3157 2012-09-04  Ojan Vafai  <ojan@chromium.org>
3158
3159         Move content shell bots to their own builder group
3160         https://bugs.webkit.org/show_bug.cgi?id=95765
3161
3162         Reviewed by Adam Barth.
3163
3164         In their current state of instability, they add too much noise. Once they get more stable,
3165         we can add them back to the regular group or just have them replace the other bots.
3166
3167         Also, fix the filter for Apple Windows bots since some of them are now "Apple Win ...".
3168
3169         * TestResultServer/static-dashboards/builders.js:
3170         (isWebkitTestRunner):
3171         (isChromiumContentShellTestRunner):
3172         (isChromiumWebkitTipOfTreeTestRunner):
3173         (loadBuildersList):
3174
3175 2012-09-03  Ryuan Choi  <ryuan.choi@samsung.com>
3176
3177         [EFL] Change the focus when the web view is clicked in MiniBrowser and EWebLauncher
3178         https://bugs.webkit.org/show_bug.cgi?id=95689
3179
3180         Reviewed by Kenneth Rohde Christiansen.
3181
3182         In Minibrowser & EWebLauncher, the web view loses the focus when url bar is clicked.
3183         So, there are bugs that key events are always generated in url bar although
3184         the user clicked the web view.
3185
3186         This patch recovers the focus of the web view when left button is pressed and
3187         adds for MiniBrowser to toggle the focus when middle button is pressed
3188         like EWebLauncher already did.
3189
3190         * EWebLauncher/main.c:
3191         (on_mouse_down):
3192         * MiniBrowser/efl/main.c:
3193         (on_mouse_down):
3194         (browserCreate):
3195
3196 2012-09-03  Tao Bai  <michaelbai@chromium.org>
3197
3198         Added ANDROID_GDBSERVER definition for Ant
3199         https://bugs.webkit.org/show_bug.cgi?id=95265
3200
3201         Reviewed by Adam Barth.
3202
3203         ANDROID_GDBSERVER will replace ANDROID_TOOLCHAIN, because the ANDROID_TOOLCHAIN
3204         is only used for finding the gdbserver.
3205
3206         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3207         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3208
3209 2012-09-03  Tommy Widenflycht  <tommyw@google.com>
3210
3211         MediaStream API: Add Ice-related functionality to RTCPeerConnection
3212         https://bugs.webkit.org/show_bug.cgi?id=95565
3213
3214         Reviewed by Adam Barth.
3215
3216         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3217         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
3218         (MockWebRTCPeerConnectionHandler::updateICE):
3219         (MockWebRTCPeerConnectionHandler::addICECandidate):
3220         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3221         (MockWebRTCPeerConnectionHandler):
3222
3223 2012-09-03  Christophe Dumez  <christophe.dumez@intel.com>
3224
3225         [EFL] Fix resizing issues related to URL bar in Minibrowser / EWebLauncher
3226         https://bugs.webkit.org/show_bug.cgi?id=95670
3227
3228         Reviewed by Kenneth Rohde Christiansen.
3229
3230         Fix layout issues related to the URL bar in Minibrowser
3231         and EWebLauncher when the window is resized.
3232
3233         The URL bar was not resized accordingly and the Web
3234         page was moved behing the URL bar, hiding part of it.
3235
3236         * EWebLauncher/main.c:
3237         (on_ecore_evas_resize):
3238         (closeWindow):
3239         * EWebLauncher/url_bar.c:
3240         (url_bar_width_set):
3241         (url_bar_add):
3242         * EWebLauncher/url_bar.h:
3243         * MiniBrowser/efl/main.c:
3244         (on_ecore_evas_resize):
3245         (main):
3246
3247 2012-09-01  Xianzhu Wang  <wangxianzhu@chromium.org>
3248
3249         [Chromium-Android] Remove hard-coded skipped directories in chromium_android.py
3250         https://bugs.webkit.org/show_bug.cgi?id=95605
3251
3252         Reviewed by Dirk Pranke.
3253
3254         Now skipping rules are put in LayoutTests/platform/chromium-android/TestExpectations.
3255
3256         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3257         (ChromiumAndroidPort.check_sys_deps):
3258         (ChromiumAndroidPort.expectations_files):
3259         (ChromiumAndroidPort.clean_up_test_run):
3260
3261 2012-09-01  Joanmarie Diggs  <jdiggs@igalia.com>
3262
3263         [Gtk] Incorrect/unexpected characters in the text of certain accessibles
3264         https://bugs.webkit.org/show_bug.cgi?id=95180
3265
3266         Reviewed by Chris Fleizach.
3267
3268         The bug that was fixed stood in the way of fully implementing stringValue().
3269         Testing that the bug is fixed requires stringValue() to be fully implemented
3270         and object replacement characters to be printable.
3271
3272         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3273         (replaceCharactersForResults): New method which turns object replacement
3274         characters into "<obj>" so that the characters can be properly shown in
3275         Layout Test results. Also turns "\n" into "<\\n>" so that printing the
3276         accessible text of a single object in the accessible tree doesn't mess up
3277         the readibility of the results.
3278         (AccessibilityUIElement::stringValue): Remove the code that immediately
3279         returned upon encountering an object of ATK_ROLE_PANEL and call the new
3280         replaceCharactersForResults() prior to returning the accessible string
3281         value.
3282
3283 2012-09-01  Tommy Widenflycht  <tommyw@google.com>
3284
3285         MediaStream API: Add MediaStream management to RTCPeerConnection
3286         https://bugs.webkit.org/show_bug.cgi?id=95543
3287
3288         Reviewed by Adam Barth.
3289
3290         Extending MockWebRTCPeerConnectionHandler to handle addStream/removeStream.
3291
3292         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3293         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
3294         (MockWebRTCPeerConnectionHandler::addStream):
3295         (MockWebRTCPeerConnectionHandler::removeStream):
3296         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3297         (MockWebRTCPeerConnectionHandler):
3298
3299 2012-08-31  Tony Chang  <tony@chromium.org>
3300
3301         Remove ENABLE_CSS3_FLEXBOX compile time flag
3302         https://bugs.webkit.org/show_bug.cgi?id=95382
3303
3304         Reviewed by Ojan Vafai.
3305
3306         Everyone is already enabling this by default and the spec has stablized.
3307
3308         * Scripts/webkitperl/FeatureList.pm:
3309         * qmake/mkspecs/features/features.pri:
3310
3311 2012-08-31  Pratik Solanki  <psolanki@apple.com>
3312
3313         objc_msgSend and IMP should be cast appropriately before using
3314         https://bugs.webkit.org/show_bug.cgi?id=95242
3315
3316         Reviewed by Benjamin Poulain.
3317
3318         Fix for older compilers. Pass id as the return type to the template
3319         instead of relying on default type.
3320
3321         * DumpRenderTree/mac/DumpRenderTree.mm:
3322         (drt_NSFontManager_availableFontFamilies):
3323         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3324         (WTR::wtr_NSFontManager_availableFontFamilies):
3325
3326 2012-08-31  Zan Dobersek  <zandobersek@gmail.com>
3327
3328         nrwt: use scm instead of calling svn directly to get the revision in json results generator
3329         https://bugs.webkit.org/show_bug.cgi?id=89616
3330
3331         Reviewed by Eric Seidel.
3332
3333         Add the new 'executive' optional function argument to the SCM.in_working_directory
3334         class method. This way we get to reuse an Executive instance which is necessary in testing
3335         when we're operating with a mock version of the object.
3336
3337         In JSONResultsGeneratorBase, it's now possible to get the current SVN revision by using
3338         the SCMDetector with the generator's FileSystem and Executive instances.
3339
3340         * Scripts/webkitpy/common/checkout/scm/detection.py:
3341         (SCMDetector.detect_scm_system):
3342         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
3343         (SCMDetectorTest.test_detect_scm_system): Update the unit test to capture the mock
3344         Executive output and test it against expected output.
3345         * Scripts/webkitpy/common/checkout/scm/git.py:
3346         (Git.in_working_directory):
3347         * Scripts/webkitpy/common/checkout/scm/scm.py:
3348         (SCM.in_working_directory):
3349         * Scripts/webkitpy/common/checkout/scm/svn.py:
3350         (SVN.in_working_directory):
3351         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3352         (JSONResultsGeneratorBase.__init__):
3353         (JSONResultsGeneratorBase._get_svn_revision):
3354
3355 2012-08-31  Jon Lee  <jonlee@apple.com>
3356
3357         [Tests] Add basic tests to http/tests/notifications
3358         https://bugs.webkit.org/show_bug.cgi?id=95493
3359         <rdar://problem/12209303>
3360
3361         Reviewed by Alexey Proskuryakov.
3362
3363         Add permission request support for WTR.
3364
3365         * WebKitTestRunner/TestController.cpp:
3366         (WTR::TestController::initialize):
3367         (WTR::TestController::decidePolicyForNotificationPermissionRequest): Always allow.
3368         * WebKitTestRunner/TestController.h:
3369         (TestController):
3370
3371 2012-08-31  Jon Lee  <jonlee@apple.com>
3372
3373         [DRT] Make simulating a web click on a notification a queued task
3374         https://bugs.webkit.org/show_bug.cgi?id=95546
3375         <rdar://problem/12214170>
3376
3377         Reviewed by Alexey Proskuryakov.
3378
3379         Making the web click happen asynchronously better mimics user interaction with the platform.
3380
3381         * DumpRenderTree/TestRunner.h: Add a flag that determines whether we have a pending notification click.
3382         (TestRunner::hasPendingWebNotificationClick): Exposed so that dump() can check that the flag is
3383         not set.
3384         * DumpRenderTree/mac/DumpRenderTree.mm:
3385         (dump): Assert that the flag is not set.
3386         * DumpRenderTree/mac/TestRunnerMac.mm:
3387         (TestRunner::simulateWebNotificationClick): Set the flag, then add a task to click the
3388         notification. In the case where the block gets executed after the flag has been unset, we avoid
3389         performing the click.
3390
3391 2012-08-31  Balazs Kelemen  <kbalazs@webkit.org>
3392
3393         [Qt] ImageDiff output is not in the expected form if image dimensions differ
3394         https://bugs.webkit.org/show_bug.cgi?id=95575
3395
3396         Reviewed by Csaba Osztrogonác.
3397
3398         Output 100% difference in the case of differing image dimensions so
3399         the test harness knows that we won't produce any output further.
3400         This matches the behavior of other ports.
3401
3402         * DumpRenderTree/qt/ImageDiff.cpp:
3403         (main):
3404
3405 2012-08-31  Sheriff Bot  <webkit.review.bot@gmail.com>
3406
3407         Unreviewed, rolling out r127261.
3408         http://trac.webkit.org/changeset/127261
3409         https://bugs.webkit.org/show_bug.cgi?id=95572
3410
3411         This patch depends on other build fixes (see blockers of bug
3412         95466) which should land first (Requested by milian on
3413         #webkit).
3414
3415         * qmake/mkspecs/features/features.prf:
3416
3417 2012-08-31  Milian Wolff  <milian.wolff@kdab.com>
3418
3419         [Qt] Support WebKit2/QML on QNX
3420         https://bugs.webkit.org/show_bug.cgi?id=95466
3421
3422         Reviewed by Noam Rosenthal.
3423
3424         Enable USE(3D_GRAPHICS) on QNX again, paired with the other bug fixes
3425         this should finally work now.
3426
3427         * qmake/mkspecs/features/features.prf:
3428
3429 2012-08-30  Xianzhu Wang  <wangxianzhu@chromium.org>
3430
3431         [Chromium-Android] Skip compositing/webgl and platform/chromium/virtual/threaded/compositing/webgl tests
3432         https://bugs.webkit.org/show_bug.cgi?id=95400
3433
3434         Reviewed by Dirk Pranke.
3435
3436         WebGL is not enabled and should be skipped on Android (http://crbug.com/135877).
3437
3438         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3439         (ChromiumAndroidPort.skipped_layout_tests):
3440
3441 2012-08-30  Gustavo Noronha Silva  <gns@gnome.org>
3442
3443         [GTK] Tries to run empty string when calling generate-gtkdoc when not using jhbuild
3444         https://bugs.webkit.org/show_bug.cgi?id=95499
3445
3446         Unreviewed. One more fix to avoid trying to run the empty string.
3447
3448         * Scripts/webkitdirs.pm:
3449         (buildAutotoolsProject):
3450
3451 2012-08-30  Sheriff Bot  <webkit.review.bot@gmail.com>
3452
3453         Unreviewed, rolling out r127171.
3454         http://trac.webkit.org/changeset/127171
3455         https://bugs.webkit.org/show_bug.cgi?id=95505
3456
3457         testRunner does not need dumpWebNotificationCallbacks().
3458         (Requested by jonlee on #webkit).
3459
3460         * DumpRenderTree/TestRunner.cpp:
3461         (TestRunner::TestRunner):
3462         (TestRunner::staticFunctions):
3463         * DumpRenderTree/TestRunner.h:
3464         (TestRunner):
3465         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
3466         (-[MockWebNotificationProvider webView:didShowNotification:]):
3467         (-[MockWebNotificationProvider webView:didClickNotification:]):
3468         (-[MockWebNotificationProvider webView:didCloseNotifications:]):
3469         * DumpRenderTree/mac/UIDelegate.mm:
3470         (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]):
3471
3472 2012-08-30  Pratik Solanki  <psolanki@apple.com>
3473
3474         objc_msgSend and IMP should be cast appropriately before using
3475         https://bugs.webkit.org/show_bug.cgi?id=95242
3476
3477         Reviewed by Benjamin Poulain.
3478
3479         Use wtfObjcMsgSend and wtfCallIMP templates which do appropriate casts
3480         to a function pointer with right types when calling objc_msgSend and an
3481         IMP method directly.
3482
3483         * DumpRenderTree/mac/DumpRenderTree.mm:
3484         (drt_NSFontManager_availableFontFamilies):
3485         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3486         (WTR::wtr_NSFontManager_availableFontFamilies):
3487
3488 2012-08-30  Benjamin Poulain  <bpoulain@apple.com>
3489
3490         Replace JSC::UString by WTF::String
3491         https://bugs.webkit.org/show_bug.cgi?id=95271
3492
3493         Reviewed by Geoffrey Garen.
3494
3495         Get rid of UString.
3496
3497         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
3498         * gdb/webkit.py:
3499         (WTFStringPrinter.to_string):
3500         (JSCIdentifierPrinter.to_string):
3501         (JSCJSStringPrinter.to_string):
3502         (add_pretty_printers):
3503
3504 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
3505
3506         nrwt should have TestExpectations everywhere we have Skipped files for apple ports
3507         https://bugs.webkit.org/show_bug.cgi?id=95495
3508
3509         Reviewed by Ojan Vafai.
3510
3511         This is a follow-on to bug 95370 that adds in support for
3512         platform/wk2/TestExpectations and
3513         platform/{mac,win}-$version/TestExpectations.
3514
3515         * Scripts/webkitpy/layout_tests/port/apple.py:
3516         (ApplePort.expectations_files):
3517         * Scripts/webkitpy/layout_tests/port/base.py:
3518         (Port._skipped_file_search_paths):
3519         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3520         (MacTest.test_expectations_files):
3521         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3522         (MockDRTPortTest.make_port):
3523         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3524         (WinPortTest.test_expectations_files):
3525
3526 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
3527
3528         executive.run_in_parallel() hangs if given nothing to do
3529         https://bugs.webkit.org/show_bug.cgi?id=95387
3530
3531         Reviewed by Ojan Vafai.
3532
3533         Check to make sure that Executive.run_in_parallel() requires
3534         a non-empty list of commands to execute; passing an empty list
3535         seems surely like a programming error.
3536
3537         * Scripts/webkitpy/common/system/executive.py:
3538         (Executive.run_in_parallel):
3539         * Scripts/webkitpy/common/system/executive_unittest.py:
3540         (ExecutiveTest.test_run_in_parallel_assert_nonempty):
3541
3542 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
3543
3544         decide what (and how) we should set the tolerance for ref test pixel compares and test for that
3545         https://bugs.webkit.org/show_bug.cgi?id=94746
3546
3547         Reviewed by Ojan Vafai.
3548
3549         Add an assertion to diff_image() to check that we are passing
3550         tolerance=0 explicitly when diffing ref test results.
3551
3552         * Scripts/webkitpy/layout_tests/port/test.py:
3553         (TestPort.diff_image):
3554
3555 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
3556
3557         NRWT should look in mac-wk2 for a TestExpecations file
3558         https://bugs.webkit.org/show_bug.cgi?id=95370
3559
3560         Reviewed by Ojan Vafai.
3561
3562         Adds support for mac-wk2 and win-wk2 to expectations_files()
3563         for the apple mac and apple win ports.
3564         
3565         * Scripts/webkitpy/layout_tests/port/apple.py:
3566         (ApplePort.expectations_files):
3567         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3568         (MacTest.test_expectations_files):
3569         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3570         (WinTest.test_expectations_files):
3571         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3572         (PortTestCase.test_expectations_files):
3573
3574 2012-08-30  Jon Lee  <jonlee@apple.com>
3575
3576         [Mac] Add testRunner.dumpWebNotificationCallbacks() to DRT
3577         https://bugs.webkit.org/show_bug.cgi?id=95232
3578         <rdar://problem/12190776>
3579
3580         Reviewed by Alexey Proskuryakov.
3581
3582         Add additional output when running test, if testRunner.dumpWebNotificationCallbacks() is called.
3583
3584         * DumpRenderTree/TestRunner.cpp:
3585         (TestRunner::TestRunner):
3586         (dumpWebNotificationCallbacksCallback):
3587         (TestRunner::staticFunctions):
3588         * DumpRenderTree/TestRunner.h:
3589         (TestRunner):
3590         (TestRunner::dumpWebNotificationCallbacks):
3591         (TestRunner::setDumpWebNotificationCallbacks):
3592         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
3593         (-[WebNotification _drt_descriptionSuitableForTestResult]):
3594         (-[MockWebNotificationProvider webView:didShowNotification:]):
3595         (-[MockWebNotificationProvider webView:didClickNotification:]):
3596         (-[MockWebNotificationProvider webView:didCloseNotifications:]):
3597         * DumpRenderTree/mac/UIDelegate.mm:
3598         (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]):
3599
3600 2012-08-30  Tommy Widenflycht  <tommyw@google.com>
3601
3602         MediaStream API: Introduce MediaConstraints
3603         https://bugs.webkit.org/show_bug.cgi?id=95198
3604
3605         Reviewed by Adam Barth.
3606
3607         Extending the MockWebRTCPeerConnectionHandler with MediaConstraints functionality.
3608
3609         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3610         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
3611         (isSupportedConstraint):
3612         (isValidConstraint):
3613         (MockWebRTCPeerConnectionHandler::initialize):
3614         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3615         (MockWebRTCPeerConnectionHandler):
3616
3617 2012-08-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3618
3619         [WK2][WTR] Add didReceiveServerRedirectForProvisionalLoadForFrame dumping
3620         https://bugs.webkit.org/show_bug.cgi?id=95454
3621
3622         Reviewed by Kenneth Rohde Christiansen.
3623
3624         Added didReceiveServerRedirectForProvisionalLoadForFrame dumping to WTR.
3625
3626         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3627         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
3628
3629 2012-08-30  Leo Yang  <leoyang@rim.com>
3630
3631         Update my email address.
3632
3633         Not reviewed.
3634
3635         * Scripts/webkitpy/common/config/committers.py:
3636
3637 2012-08-30  Jochen Eisinger  <jochen@chromium.org>
3638
3639         [NRWT] Add support for recognizing arbitrary process names in crash lines
3640         https://bugs.webkit.org/show_bug.cgi?id=95435
3641
3642         Reviewed by Adam Barth.
3643
3644         When running layout tests in the chromium port using the content shell,
3645         we want to be able to report sub-process crashes as well.
3646
3647         * Scripts/webkitpy/layout_tests/port/driver.py:
3648         (Driver._check_for_driver_crash):
3649         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
3650         (DriverTest.test_check_for_driver_crash):
3651
3652 2012-08-29  Zan Dobersek  <zandobersek@gmail.com>
3653
3654         Random test-webkitpy failures on the buildbot
3655         https://bugs.webkit.org/show_bug.cgi?id=95096
3656
3657         Reviewed by Dirk Pranke.
3658
3659         Suppress occasional errors when running test-webkitpy on GTK builders
3660         by running these tests serially. The 64-bit Release builder is especially
3661         prone to these as it can run up to 24 tests in parallel.
3662
3663         Despite the tests not being run in parallel, the testing only lasts a handful
3664         of seconds more, so this is a worthy trade-off to avoid unnecessary
3665         false-alarm redness on the GTK builders.
3666
3667         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3668         (RunPythonTests.start):
3669
3670 2012-08-29  Benjamin Poulain  <bpoulain@apple.com>
3671
3672         REGRESSION(r126780): Crash using StringImpl::is8Bit before checking if there is an impl
3673         https://bugs.webkit.org/show_bug.cgi?id=95380
3674
3675         Reviewed by Michael Saboff.
3676
3677         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3678         Add very basic tests for String::ascii(). This covers the case of null strings that caused
3679         the crash.
3680