[GTK] Rely on the general implementation for detecting the Apache server path.
[WebKit-https.git] / Tools / ChangeLog
1 2012-10-01  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2
3         [GTK] Rely on the general implementation for detecting the Apache server path.
4         https://bugs.webkit.org/show_bug.cgi?id=98033
5
6         Reviewed by Martin Robinson.
7
8         The implemenentation of _path_to_apache() in base.py already
9         checks for the same paths gtk.py tries; the only difference is
10         that all of the are tried regardless of the current distro.
11
12         Doing so is more portable, and lets us remove some distro-checking
13         from the code.
14
15         * Scripts/webkitpy/layout_tests/port/gtk.py:
16         (GtkPort._path_to_apache): Remove.
17
18 2012-10-01  Csaba Osztrogonác  <ossy@webkit.org>
19
20         Unreviewed, update the URL of the Szeged SVN mirror.
21
22         * BuildSlaveSupport/build.webkit.org-config/config.json:
23
24 2012-10-01  Yuta Kitamura  <yutak@chromium.org>
25
26         Unreviewed. Create WebSocket watch list, and add myself to that list.
27
28         * Scripts/webkitpy/common/config/watchlist:
29
30 2012-09-30  Taiju Tsuiki  <tzik@chromium.org>
31
32         Unreviewed. Adding myself as a committer.
33
34         * Scripts/webkitpy/common/config/committers.py:
35
36 2012-09-30  Sadrul Habib Chowdhury  <sadrul@chromium.org>
37
38         [chromium] Add a test to verify that a plugin does not receive touch-events unless it explicitly requests for them
39         https://bugs.webkit.org/show_bug.cgi?id=97975
40
41         Reviewed by Adam Barth.
42
43         TestWebPlugin can now be configured to accept touch events or not. Use this
44         configurability to verify that a plugin does not receive touch events unless
45         it explicitly requests for them.
46
47         * DumpRenderTree/chromium/TestWebPlugin.cpp:
48         (TestWebPlugin::TestWebPlugin):
49         (TestWebPlugin::initialize):
50         (TestWebPlugin::parseBoolean):
51         * DumpRenderTree/chromium/TestWebPlugin.h:
52         (TestWebPlugin):
53
54 2012-09-28  Mariusz Grzegorczyk  <mariusz.g@samsung.com>
55
56         [WK2][GTK][EFL] Share WebKit2-GTK plugin process implementation with EFL port
57         https://bugs.webkit.org/show_bug.cgi?id=91844
58
59         Reviewed by Simon Hausmann.
60
61         Turn on Netscape Plugin API option by default.
62
63         * Scripts/webkitperl/FeatureList.pm:
64
65 2012-09-28  Dirk Pranke  <dpranke@chromium.org>
66
67         webkit-patch rebaseline-expectations is broken
68         https://bugs.webkit.org/show_bug.cgi?id=97619
69
70         Reviewed by Ojan Vafai.
71
72         The new expectations format is causing two problems for
73         webkit-patch rebaseline expectations
74
75         1) the transformation into and out of the old syntax (which is
76         still used internally) is somewhat lossy, e.g., we're not
77         preserving the case of Bug(x) identifiers. Also, we can't
78         tell if the input was [ WontFix ] or [ Skip WontFix Pass ]
79         2) the new syntax is more lenient, allowing for multiple ways to
80         specify the same result, e.g., "[ Skip ]" may or may not be
81         missing.
82
83         As a result, we end up rewriting a whole bunch of lines for
84         purely syntactic differences.
85
86         Both of these things are bugs that need to be fixed, but
87         we should also not just rewrite lines that shouldn't be
88         modified.
89
90         This patch fixes the last issue (no rewriting).
91
92         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
93         (TestExpectationLine._format_line):
94         (TestExpectations.remove_rebaselined_tests):
95         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
96         (RebaseliningTest.test_remove):
97
98 2012-09-28  Dirk Pranke  <dpranke@chromium.org>
99
100         virtual directories should just rename the beginning of the test path
101         https://bugs.webkit.org/show_bug.cgi?id=97925
102
103         Reviewed by Ojan Vafai.
104
105         We were replacing all occurrences of the base prefix of a
106         virtual test suite with the virtual name, instead of just the
107         first. So, where we had softwarecompositing running the
108         compositing tests, any compositing test that actually had
109         "compositing" in the test base name would get that expanded
110         incorrectly.
111
112         * Scripts/webkitpy/layout_tests/port/base.py:
113         (Port.populated_virtual_test_suites):
114         (Port.lookup_virtual_test_base):
115         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
116         (PortTest.test_tests):
117         * Scripts/webkitpy/layout_tests/port/test.py:
118
119 2012-09-28  Ojan Vafai  <ojan@chromium.org>
120
121         Garden-o-matic sometimes things buildbot warnings are failures
122         https://bugs.webkit.org/show_bug.cgi?id=97926
123
124         Reviewed by Tony Chang.
125
126         It turns out the JSON clearly tells us if it's a failure.
127         We want to skip all warnings even if they don't have "warning" in the text.
128         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
129         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
130
131 2012-09-28  Harald Tveit Alvestrand  <harald@alvestrand.no>
132
133         Implement the GetStats interface on PeerConnection
134         https://bugs.webkit.org/show_bug.cgi?id=95193
135
136         Reviewed by Adam Barth.
137
138         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
139         (RTCStatsRequestSucceededTask):
140         (RTCStatsRequestSucceededTask::RTCStatsRequestSucceededTask):
141         (MockWebRTCPeerConnectionHandler::getStats):
142         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
143         (MockWebRTCPeerConnectionHandler):
144
145 2012-09-28  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
146
147         [NRWT] XvfbDriver should choose the next free display
148         https://bugs.webkit.org/show_bug.cgi?id=88414
149
150         Reviewed by Dirk Pranke.
151
152         This change how the XvfbDriver choose the next display. Before
153         this the choosing are based on the worker number but it caused
154         errors when several nrwt run on the same time. This add process
155         based free diplay search.
156
157         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
158         (XvfbDriver.__init__):
159         (XvfbDriver._next_free_display):
160         (XvfbDriver._start):
161         (XvfbDriver.stop):
162         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
163         (XvfbDriverTest.make_driver):
164         (XvfbDriverTest.test_start_no_pixel_tests):
165         (XvfbDriverTest.test_start_pixel_tests):
166         (XvfbDriverTest.test_start_arbitrary_worker_number):
167         (XvfbDriverTest.test_next_free_display):
168         (XvfbDriverTest):
169         (XvfbDriverTest.test_start_next_worker):
170
171 2012-09-28  Huang Dongsung  <luxtella@company100.net>
172
173         [GTK] Enable CSS Shaders layout LayoutTests on GTK+
174         https://bugs.webkit.org/show_bug.cgi?id=97821
175
176         Reviewed by Martin Robinson.
177
178         This feature is disabled via Settings by default, but for testing,
179         we enable it using layoutTestController.overridePreferences. Add the
180         necessary plumbing for DRT.
181
182         WTR already works because support was added for Apple Mac earlier.
183
184         * DumpRenderTree/gtk/DumpRenderTree.cpp:
185         (resetDefaultsToConsistentValues): Feature is off by default.
186         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
187         (TestRunner::overridePreference): Add handling of WebKitCSSCustomFilterEnabled.
188
189 2012-09-28  Csaba Osztrogonác  <ossy@webkit.org>
190
191         [Qt] Make NRWT use wk2/TestExpectations file
192         https://bugs.webkit.org/show_bug.cgi?id=97894
193
194         Reviewed by Simon Hausmann.
195
196         * Scripts/webkitpy/layout_tests/port/qt.py: Remove unnecessary _skipped_file_search_paths function.
197         (QtPort.expectations_files): Add wk2 if --webkit-test-runner option added.
198         * Scripts/webkitpy/layout_tests/port/qt_unittest.py: Remove unnecessary test__skipped_file_search_paths function.
199         (QtPortTest._assert_search_path): Removed.
200         (QtPortTest.test_expectations_files): Add wk2 if --webkit-test-runner option added, and code cleanup.
201
202 2012-09-28  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
203
204         [EFL][DRT] EFL's layoutTestController.keepWebHistory should enable visited links tracking
205         https://bugs.webkit.org/show_bug.cgi?id=97901
206
207         Reviewed by Kenneth Rohde Christiansen.
208
209         EFL's DRT testRunner.keepWebHistory should enable visited links tracking in order
210         to be consistent with WTR implementation and also several tests rely on that (fast/history).
211
212         * DumpRenderTree/efl/TestRunnerEfl.cpp:
213         (TestRunner::keepWebHistory):
214
215 2012-09-28  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
216
217         [EFL][DRT] EFL DRT should disable visited links tracking by default
218         https://bugs.webkit.org/show_bug.cgi?id=97881
219
220         Reviewed by Kenneth Rohde Christiansen.
221
222         Visited links tracking is disabled by default for each test.
223
224         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
225         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
226
227 2012-09-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
228
229         Unreviewed, rolling out r129863.
230         http://trac.webkit.org/changeset/129863
231         https://bugs.webkit.org/show_bug.cgi?id=97173
232
233         Broken debug WK2 layout test
234
235         * MiniBrowser/efl/main.c:
236         (quit):
237         (main):
238         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
239         (WTR::initEcoreEvas):
240         (WTR::PlatformWebView::~PlatformWebView):
241         * WebKitTestRunner/efl/main.cpp:
242         (main):
243
244 2012-09-28  Kai Koehne  <kai.koehne@digia.com>
245
246         [Qt] Use qInstallMessageHandler()
247         https://bugs.webkit.org/show_bug.cgi?id=96648
248
249         Reviewed by Jocelyn Turcotte.
250
251         qInstallMsgHandler() got deprecated in Qt 5.
252
253         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
254         (messageHandler):
255         (main):
256         * WebKitTestRunner/qt/main.cpp:
257         (messageHandler):
258         (main):
259
260 2012-09-28  Eunmi Lee  <eunmi15.lee@samsung.com>
261
262         [EFL][WK2] Refactoring initialization and shutdown codes of EFL libraries.
263         https://bugs.webkit.org/show_bug.cgi?id=97173
264
265         Reviewed by Gyuyoung Kim.
266
267         The initialization and shutdown are done inside the webkit, so we don't
268         have to call them out of the webkit.
269
270         * MiniBrowser/efl/main.c:
271         (quit):
272         (main):
273         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
274         (WTR::initEcoreEvas):
275         (WTR::PlatformWebView::~PlatformWebView):
276         * WebKitTestRunner/efl/main.cpp:
277         (main):
278
279 2012-09-27  Alexandre Elias  <aelias@chromium.org>
280
281         [chromium] DumpRenderTree support for software compositing
282         https://bugs.webkit.org/show_bug.cgi?id=96853
283
284         Reviewed by James Robinson.
285
286         This adds software compositor support to DumpRenderTree.  The only
287         thing needed is a minimal OutputSurfaceSoftware that holds a
288         viewport-sized bitmap. Then, I added virtual test suite
289         platform/chromium/virtual/softwarecompositing -- a mirror of the
290         compositing/ directory with --enable-software-compositing, and
291         expectations for not yet supported tests.
292
293         * DumpRenderTree/DumpRenderTree.gypi:
294         * DumpRenderTree/chromium/DumpRenderTree.cpp:
295         (main):
296         * DumpRenderTree/chromium/TestShell.cpp:
297         (TestShell::TestShell):
298         * DumpRenderTree/chromium/TestShell.h:
299         (TestShell::softwareCompositingEnabled):
300         (TestShell::setSoftwareCompositingEnabled):
301         (TestShell):
302         * DumpRenderTree/chromium/WebViewHost.cpp:
303         (WebViewHost::createOutputSurface):
304         * DumpRenderTree/chromium/WebViewHostOutputSurface.cpp:
305         (WebKit::WebViewHostOutputSurface::create3d):
306         (WebKit):
307         (WebKit::WebViewHostOutputSurface::createSoftware):
308         (WebKit::WebViewHostOutputSurface::WebViewHostOutputSurface):
309         (WebKit::WebViewHostOutputSurface::bindToClient):
310         (WebKit::WebViewHostOutputSurface::surfaceSoftware):
311         * DumpRenderTree/chromium/WebViewHostOutputSurface.h:
312         (WebKit):
313         (WebViewHostOutputSurface):
314         * DumpRenderTree/chromium/WebViewHostSoftwareOutputDevice.cpp: Copied from Tools/DumpRenderTree/chromium/WebViewHostOutputSurface.cpp.
315         (WebKit):
316         (WebKit::WebViewHostSoftwareOutputDevice::lockForWrite):
317         (WebKit::WebViewHostSoftwareOutputDevice::unlockForWrite):
318         (WebKit::WebViewHostSoftwareOutputDevice::lockForRead):
319         (WebKit::WebViewHostSoftwareOutputDevice::unlockForRead):
320         (WebKit::WebViewHostSoftwareOutputDevice::viewportChanged):
321         * DumpRenderTree/chromium/WebViewHostSoftwareOutputDevice.h: Copied from Tools/DumpRenderTree/chromium/WebViewHostOutputSurface.cpp.
322         (WebKit):
323         (WebViewHostSoftwareOutputDevice):
324         * Scripts/webkitpy/layout_tests/port/chromium.py:
325         (ChromiumPort.virtual_test_suites):
326
327 2012-09-27  Nasko Oskov  <nasko@chromium.org>
328
329         Move DumpRenderTree to use newer version of the name method of
330         WebFrame and the willCheckAndDispatchMessageEvent method of WebFrameClient
331         https://bugs.webkit.org/show_bug.cgi?id=95254
332
333         Reviewed by Adam Barth.
334
335         The WebFrame name() method is removed and replaced by better named
336         uniqueName() method, so DRT needs to be updated to use this new version.
337         Also the willCheckAndDispatchMessageEvent in WebFrameClient gained
338         one more parameter, which had to be added in DRT.
339
340         * DumpRenderTree/chromium/TestShell.cpp:
341         (dumpFramesAsText):
342         (dumpFramesAsPrintedText):
343         (dumpFrameScrollPosition):
344         * DumpRenderTree/chromium/WebViewHost.cpp:
345         (WebViewHost::unableToImplementPolicyWithError):
346         (WebViewHost::willCheckAndDispatchMessageEvent):
347         (WebViewHost::printFrameDescription):
348         * DumpRenderTree/chromium/WebViewHost.h:
349         (WebViewHost):
350
351 2012-09-27  Julie Parent  <jparent@chromium.org>
352
353         Add webkit_unit_tests to the flakiness dashboard
354         https://bugs.webkit.org/show_bug.cgi?id=97814
355
356         Reviewed by Dirk Pranke.
357
358         webkit_unit_tests run on the same bots as test_shell_tests.
359
360         * TestResultServer/static-dashboards/builders.js:
361         (loadBuildersList):
362         * TestResultServer/static-dashboards/dashboard_base.js:
363         (currentBuilderGroupCategory):
364
365 2012-09-27  Florin Malita  <fmalita@chromium.org>
366
367         [Perftest] PerfTestRunner exception when using nested git checkouts
368         https://bugs.webkit.org/show_bug.cgi?id=97796
369
370         Reviewed by Ryosuke Niwa.
371
372         In order to support separate Chromium vs. WebKit git trees, PerfTestsRunner needs to
373         instantiate per-repository SCM objects when collecting revision information.
374
375         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
376         (PerfTestsRunner._generate_results_dict):
377
378 2012-09-27  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
379
380         [Mac][DRT] Add support to allow non-array modifier arguments in keyDown()
381         https://bugs.webkit.org/show_bug.cgi?id=97805
382
383         Reviewed by Alexey Proskuryakov.
384
385         Add support for handling a string as modifier argument to keyDown().
386         This support has already been added to other ports, so implementing
387         this on Mac too, to be consistent with the other ports.
388
389         * DumpRenderTree/mac/EventSendingController.mm:
390         (modifierFlags):
391         (buildModifierFlags):
392
393 2012-09-27  Dirk Pranke  <dpranke@chromium.org>
394
395         efl wk2 bots weren't looking at platform/wk2/TestExpectations
396         https://bugs.webkit.org/show_bug.cgi?id=97815
397
398         Unreviewed, build fix.
399
400         Should clean up this logic later so that we're just using the
401         implementation in base ...
402
403         * Scripts/webkitpy/layout_tests/port/efl.py:
404         (EflPort._search_paths):
405         (EflPort.expectations_files):
406
407 2012-09-27  Dirk Pranke  <dpranke@chromium.org>
408
409         webkitpy: make warning about missing BUG identifiers per-port configurable
410         https://bugs.webkit.org/show_bug.cgi?id=97751
411
412         Reviewed by Ojan Vafai.
413
414         Prior to this change linting TestExpectations files (checking their style)
415         would raise warnings if lines were missing a BUG modifier, even
416         though such a modifier is actually optional in the syntax. As we
417         migrate the entries over from the Skipped files, these warnings
418         will generate a lot of noise, and it's not yet clear that we
419         actually want to require the modifiers on all ports.
420
421         So, this change makes this per-port configurable so that they
422         will generate warnings in the Chromium TestExpectations and not
423         anywhere else.
424
425         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
426         (TestExpectationParser._parse_modifiers):
427         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
428         (MiscTests.test_parse_warning):
429         (SemanticTests.test_missing_bugid):
430         * Scripts/webkitpy/layout_tests/port/base.py:
431         (Port.warn_if_bug_missing_in_test_expectations):
432         * Scripts/webkitpy/layout_tests/port/chromium.py:
433         (ChromiumPort.warn_if_bug_missing_in_test_expectations):
434
435 2012-09-27  Xianzhu Wang  <wangxianzhu@chromium.org>
436
437         [Chromium-Android] Push more fonts for layout tests to match chromium-linux
438         https://bugs.webkit.org/show_bug.cgi?id=97746
439
440         Reviewed by Dirk Pranke.
441
442         * DumpRenderTree/chromium/android_fallback_fonts.xml: Added the new fonts into fallback list. Removed the Android system fallback font DroidSansFallback.ttf.
443         * Scripts/webkitpy/layout_tests/port/builders.py: Add chromium-android to pass style check.
444         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
445         (ChromiumAndroidPort.check_build): Added check for md5sum and forwarder utilities to give better error message when they are missing.
446         (ChromiumAndroidPort.check_sys_deps): Allow host font files to come from one of multiple directories.
447         (ChromiumAndroidPort._path_to_md5sum):
448         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
449         (ChromiumAndroidDriver._push_fonts):
450         (ChromiumAndroidDriver._push_test_resources):
451
452 2012-09-27  Tommy Widenflycht  <tommyw@google.com>
453
454         MediaStream API: Enhance MediaConstraints to make it easier to get the constraint data
455         https://bugs.webkit.org/show_bug.cgi?id=97559
456
457         Reviewed by Adam Barth.
458
459         Refactoring for the new WebMediaConstraints api.
460
461         * DumpRenderTree/chromium/MockConstraints.cpp:
462         (MockConstraints::verify):
463
464 2012-09-27  Tommy Widenflycht  <tommyw@google.com>
465
466         MediaStream API: Rename MockConstraints::verify to verifyConstraints
467         https://bugs.webkit.org/show_bug.cgi?id=97779
468
469         Reviewed by Csaba Osztrogonác.
470
471         The Mac OS X sdk has a macro called verify :/
472
473         * DumpRenderTree/chromium/MockConstraints.cpp:
474         (MockConstraints::verifyConstraints):
475         * DumpRenderTree/chromium/MockConstraints.h:
476         (MockConstraints):
477         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
478         (MockWebRTCPeerConnectionHandler::initialize):
479         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
480         (WebUserMediaClientMock::requestUserMedia):
481
482 2012-09-27  Tommy Widenflycht  <tommyw@google.com>
483
484         MediaStream API: Update getUserMedia to match the latest specification
485         https://bugs.webkit.org/show_bug.cgi?id=97540
486
487         Reviewed by Adam Barth.
488
489         http://dev.w3.org/2011/webrtc/editor/getusermedia.html#navigatorusermedia
490         Navigator.getUserMedia is changed so that the audio and video members can either
491         be a bool or a constraints object.
492
493         * public/WebUserMediaRequest.h:
494         (WebKit):
495         (WebUserMediaRequest):
496         * src/WebUserMediaRequest.cpp:
497         (WebKit::WebUserMediaRequest::audioConstraints):
498         (WebKit):
499         (WebKit::WebUserMediaRequest::videoConstraints):
500
501 2012-09-26  Laszlo Gombos  <l.gombos@samsung.com>
502
503         Unreviewed. Update my e-mail address.
504
505         * Scripts/webkitpy/common/config/committers.py:
506
507 2012-09-26  Dirk Pranke  <dpranke@chromium.org>
508
509         modify old-run-webkit-tests to support TestExpectations files a little
510         https://bugs.webkit.org/show_bug.cgi?id=97276
511
512         Reviewed by Daniel Bates.
513
514         This patch adds minimal support to old-run-webkit-tests so that
515         it can read a TestExpectations file and skip the tests listed
516         there. It will skip *all* tests, regardless of the expectation
517         (even if the test is listed as [ Pass ]), and it will only look
518         at the TestExpectations file if there isn't a Skipped file next
519         to it.
520         
521         This will allow us to switch to using just using
522         TestExpectations files without making old-run-webkit-tests
523         totally useless.
524
525         * Scripts/old-run-webkit-tests:
526         (readSkippedFiles):
527         (processSkippedFileEntry): Added.
528         (startsWith): Added.
529
530 2012-09-26  Dirk Pranke  <dpranke@chromium.org>
531
532         The style bot spams about skia_test_expectations.txt
533         https://bugs.webkit.org/show_bug.cgi?id=97699
534
535         Reviewed by Adam Barth.
536
537         Remove the warning about a missing skia_test_expectations.txt
538         file for now. There are some situations where it would be
539         helpful to get this warning as it might indicate that the user
540         is going to get results different than what they're expecting,
541         but at the moment it looks difficult if not impossible to get
542         those warnings and not also get warnings that we don't care
543         about, so the noise is outweighing the value of the signal.
544
545         This at least will stop the false negatives we're getting on the
546         style bots. If it turns out people do need the warning we can
547         add it back in in some other more conditional way.
548
549         * Scripts/webkitpy/layout_tests/port/chromium.py:
550         (ChromiumPort.expectations_files):
551         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
552         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
553         (test_rebaseline_updates_expectations_file):
554         (test_rebaseline_does_not_include_overrides):
555         (test_rebaseline_expectations):
556         (_assert_command):
557
558 2012-09-26  David Michael Barr  <davidbarr@chromium.org>
559
560         Unreviewed. Upgrade myself from contributor to committer.
561
562         * Scripts/webkitpy/common/config/committers.py:
563
564 2012-09-26  Ryosuke Niwa  <rniwa@webkit.org>
565
566         Remove deprecated code from perftestrunner.py
567         https://bugs.webkit.org/show_bug.cgi?id=97724
568
569         Reviewed by Adam Barth.
570
571         Remove the code deprecated in r129580 now that we have landed r129597,
572         which updated master.cfg to use new options, and restarted the buildbot master.
573
574         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
575         (PerfTestsRunner._parse_args):
576         (PerfTestsRunner._generate_and_show_results):
577         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
578         (test_run_with_slave_config_json):
579         (test_parse_args):
580
581 2012-09-26  Beth Dakin  <bdakin@apple.com>
582
583         https://bugs.webkit.org/show_bug.cgi?id=97629
584         http/tests/security/cross-frame-access-put.html failing on Mac WK2 bots after 
585         being unskipped
586
587         Reviewed by Tim Horton.
588
589         The test was failing because we were failing to use the fake window origin. We 
590         should really always use the fake origin. This patch eliminates 
591         _shouldUseFakeOrigin in favor of always using it.
592         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
593         (-[WebKitTestRunnerWindow setFrameOrigin:]):
594         (-[WebKitTestRunnerWindow setFrame:display:animate:]):
595         (-[WebKitTestRunnerWindow setFrame:display:]):
596         (-[WebKitTestRunnerWindow frameRespectingFakeOrigin]):
597
598 2012-09-26  Tony Chang  <tony@chromium.org>
599
600         C++ style checker should warn when the indentation is wrong
601         https://bugs.webkit.org/show_bug.cgi?id=97602
602
603         Reviewed by Ojan Vafai.
604
605         Rewrite the indentation checker to ensure that indentation is always a factor of 4
606         and that we only indent 4 spaces from the previous line.
607
608         I deleted some of the old indentation checking code since it was filtered out
609         and didn't match the webkit style.
610
611         * Scripts/webkitpy/style/checker.py:
612         * Scripts/webkitpy/style/checkers/cpp.py:
613         (check_indentation_amount): New function that checks indentation. Intentionally runs after
614         other indentation checks.
615         (check_style): Delete the old indentation code since we were already filtering out the whitespace/labels warnings.
616         (CppChecker): Remove the whitespace/labels filter.
617         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
618         (CppStyleTest.test_multi_line_comments): Force 4 space indent.
619         (CppStyleTest.test_explicit_single_argument_constructors):
620         (CppStyleTest.test_explicit_single_argument_constructors.Foo):
621         (CppStyleTest.test_explicit_single_argument_constructors.Qualifier):
622         (CppStyleTest.test_slash_star_comment_on_single_line):
623         (CppStyleTest.test_braces):
624         (CppStyleTest.test_spacing_before_last_semicolon):
625         (CppStyleTest.test_static_or_global_stlstrings):
626         (CppStyleTest.test_indent): Added macro test case.
627         (CppStyleTest.test_build_class):
628         (NoNonVirtualDestructorsTest.test_no_error):
629         (NoNonVirtualDestructorsTest.test_no_error.Foo):
630         (NoNonVirtualDestructorsTest.test_no_error.Qualified):
631         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed):
632         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed.Foo):
633         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed):
634         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed.Foo):
635         (NoNonVirtualDestructorsTest.test_no_warn_when_derived):
636         (NoNonVirtualDestructorsTest.test_no_warn_when_derived.Foo):
637         (NoNonVirtualDestructorsTest.test_internal_braces):
638         (NoNonVirtualDestructorsTest.test_internal_braces.Foo):
639         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor):
640         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo):
641         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo.Goo):
642         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor):
643         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo):
644         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo.Goo):
645         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor):
646         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor.Qualified):
647         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error):
648         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error.Foo):
649         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
650         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error.Foo):
651         (WebKitStyleTest.test_indentation):
652         (WebKitStyleTest.test_braces): Add test for call params spanning lines.
653
654 2012-09-26  Adam Barth  <abarth@webkit.org>
655
656         Rollout messages should be clickable in bugzilla
657         https://bugs.webkit.org/show_bug.cgi?id=97711
658
659         Reviewed by Simon Fraser.
660
661         If we say Bug NNNN instead of just NNNN, bugzilla will autolink to the
662         actual bug.
663
664         * Scripts/webkitpy/tool/commands/download_unittest.py:
665         * Scripts/webkitpy/tool/steps/createbug.py:
666         (CreateBug.run):
667
668 2012-09-26  Marcelo Lira  <marcelo.lira@openbossa.org>
669
670         run-perf-tests must expand environment variables in user provided paths
671         https://bugs.webkit.org/show_bug.cgi?id=97686
672
673         Reviewed by Ryosuke Niwa.
674
675         The run-perf-tests command line options that receive paths from the
676         user now expand any possible environment variables, because Python's
677         file handling methods do not handle those.
678
679         Examples:
680         run-perf-tests --platform=qt --release --output-json-path=~/perf-results
681         run-perf-tests --platform=qt --release --output-json-path=$HOME/perf-results
682
683         Also removed unused imports.
684
685         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
686         (PerfTestsRunner._parse_args._expand_path): expand environment variables in a path passed via command line
687         (PerfTestsRunner._parse_args):
688
689 2012-09-26  Sheriff Bot  <webkit.review.bot@gmail.com>
690
691         Unreviewed, rolling out r129654.
692         http://trac.webkit.org/changeset/129654
693         https://bugs.webkit.org/show_bug.cgi?id=97702
694
695         breaks chromium windows build (Requested by schenney on
696         #webkit).
697
698         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
699         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
700         (MockWebRTCPeerConnectionHandler):
701
702 2012-09-26  Michael Saboff  <msaboff@apple.com>
703
704         Unreviewed build change.
705
706         Reverting inadvertent change to project file.
707
708         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
709
710 2012-09-26  Harald Tveit Alvestrand  <harald@alvestrand.no>
711
712         Implement the GetStats interface on PeerConnection
713         https://bugs.webkit.org/show_bug.cgi?id=95193
714
715         Reviewed by Adam Barth.
716
717         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
718         (RTCStatsRequestSucceededTask):
719         (RTCStatsRequestSucceededTask::RTCStatsRequestSucceededTask):
720         (MockWebRTCPeerConnectionHandler::getStats):
721         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
722         (MockWebRTCPeerConnectionHandler):
723
724 2012-09-26  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
725
726         [WK2][WTR] Policy client: dumping from decidePolicyForResponse callback
727         https://bugs.webkit.org/show_bug.cgi?id=97034
728
729         Reviewed by Kenneth Rohde Christiansen.
730
731         Provided dumping from WTR Policy client 'decidePolicyForResponse' callback.
732
733         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
734         (WTR::InjectedBundlePage::decidePolicyForResponse):
735
736 2012-09-26  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
737
738         [Qt][WTR] Build fix for MSVC. 
739         https://bugs.webkit.org/show_bug.cgi?id=97667
740
741         Reviewed by Csaba Osztrogonác.
742
743         WTR misses InjectedBundle headers. Adding $$PWD to Target.pri is required for MSVC. Clean build is necessary on Windows.
744
745         * WebKitTestRunner/InjectedBundle/Target.pri:
746
747 2012-09-26  Xiaobo Wang  <xbwang@torchmobile.com.cn>
748
749         [BlackBerry] [DRT] eventSender.keyDown() doesn't support Ctrl key modifier
750         https://bugs.webkit.org/show_bug.cgi?id=97665
751
752         Reviewed by Rob Buis.
753
754         This patch fixes test fast/forms/input-text-option-delete.html.
755
756         * DumpRenderTree/blackberry/EventSender.cpp:
757         (keyDownCallback):
758
759 2012-09-26  Dinu Jacob  <dinu.s.jacob@intel.com>
760
761         Unreviewed. Adding myself as a committer.
762
763         * Scripts/webkitpy/common/config/committers.py:
764
765 2012-09-26  Carlos Garcia Campos  <cgarcia@igalia.com>
766
767         [GTK] Remove color codes characters from run-gtk-tests output when not writing to a TTY
768         https://bugs.webkit.org/show_bug.cgi?id=97660
769
770         Reviewed by Philippe Normand.
771
772         Remove also the '\r' characters returned by TTY output to try to fix
773         the double line endings of the script output in the bots.
774
775         * Scripts/run-gtk-tests:
776         (TestRunner.__init__): Compile a regexp for color codes if stdout
777         it not a TTY.
778         (TestRunner._run_test_command.parse_line): Remove color codes and
779         '\r' characters from the line returned by the pseudo-terminal if
780         stdout is not a TTY.
781         * gtk/common.py:
782         (parse_output_lines): Fix the last chunk check to make sure we
783         always send entire lines to the callback, otherwise color codes
784         regexp might fail if the line is not complete.
785
786 2012-09-25  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
787
788         [DRT][WTR] Support overriding the 'WebKitDisplayImagesKey' preference
789         https://bugs.webkit.org/show_bug.cgi?id=96883
790
791         Reviewed by Kenneth Rohde Christiansen.
792
793         * DumpRenderTree/efl/TestRunnerEfl.cpp:
794         (TestRunner::overridePreference): Support the
795         'WebKitDisplayImagesKey' preference.
796
797 2012-09-26  Zan Dobersek  <zandobersek@gmail.com>
798
799         [GTK] Enable some of the unstable CSS features
800         https://bugs.webkit.org/show_bug.cgi?id=97572
801
802         Reviewed by Martin Robinson.
803
804         Enable the <style scoped> support via DumpRenderTreeSupportGtk method
805         whenever resetting defualts to consistent values.
806
807         * DumpRenderTree/gtk/DumpRenderTree.cpp:
808         (resetDefaultsToConsistentValues):
809
810 2012-09-26  Zan Dobersek  <zandobersek@gmail.com>
811
812         REGRESSION (r126189): No more mismatch-did-not-occur failures in reftests
813         https://bugs.webkit.org/show_bug.cgi?id=97112
814
815         Reviewed by Dirk Pranke.
816
817         Don't use the reftest's image hash when gathering output of its reference.
818         This indirectly forces the driver to return the reference's image output
819         as well. This specifically solves the problem when the reftest and its
820         mismatch reference are equal but the unexpected match failure is not
821         reported due to missing image output of the reference file.
822
823         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
824         (SingleTestRunner._run_reftest):
825         * Scripts/webkitpy/layout_tests/port/test.py:
826         (TestPort.diff_image):
827         (TestDriver.run_test):
828
829 2012-09-25  Ryosuke Niwa  <rniwa@webkit.org>
830
831         Update master.cfg to invoke run-perf-tests with --no-show-results and --reset-results
832         https://bugs.webkit.org/show_bug.cgi?id=97613
833
834         Reviewed by Dirk Pranke.
835
836         Use options added in r129580.
837
838         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
839         (RunAndUploadPerfTests):
840
841 2012-09-25  Peter Rybin  <peter.rybin@gmail.com>
842
843         Web Inspector: Fix logging in pure protocol test harness
844         https://bugs.webkit.org/show_bug.cgi?id=97579
845
846         Reviewed by Yury Semikhatsky.
847
848         JavaScript alert implementation in DumpRenderTree gets immediate flush to make sure that
849         the message survives crash or kill by timeout.
850
851         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
852         (BlackBerry::WebKit::DumpRenderTree::runJavaScriptAlert):
853         * DumpRenderTree/chromium/WebViewHost.cpp:
854         (WebViewHost::runModalAlertDialog):
855         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
856         (onJavaScriptAlert):
857         * DumpRenderTree/gtk/DumpRenderTree.cpp:
858         (webViewScriptAlert):
859         * DumpRenderTree/mac/UIDelegate.mm:
860         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
861         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
862         (WebCore::WebPage::javaScriptAlert):
863         * DumpRenderTree/win/UIDelegate.cpp:
864         (UIDelegate::runJavaScriptAlertPanelWithMessage):
865
866 2012-09-25  Dan Bernstein  <mitz@apple.com>
867
868         Tools part of <rdar://problem/11455228> [mac] Stop using screen fonts
869         https://bugs.webkit.org/show_bug.cgi?id=97620
870
871         Reviewed by John Sullivan.
872
873         * DumpRenderTree/mac/DumpRenderTree.mm:
874         (resetDefaultsToConsistentValues): Enable screen font substitution when
875         running the tests.
876         * WebKitTestRunner/TestController.cpp:
877         (WTR::TestController::resetStateToConsistentValues): Ditto.
878
879 2012-09-25  Ryosuke Niwa  <rniwa@webkit.org>
880
881         Build fix. "values" doesn't necessarily contain multiple values but it needs to be always parsed as an array.
882
883         * Scripts/webkitpy/performance_tests/perftest.py:
884         (PerfTest.parse_output):
885
886 2012-09-25  Ryosuke Niwa  <rniwa@webkit.org>
887
888         run-perf-tests: cleanup options and results generation code
889         https://bugs.webkit.org/show_bug.cgi?id=97611
890
891         Reviewed by Dirk Pranke.
892
893         Previously, --test-results-server triggered old JSOn format where the outermost structure was a dictionary
894         instead of an array, and also implicitly triggered --no-show-results, caused the old outputs not to merge,
895         and prevented the generation of results page. Also, it was not obvious that --source-json-path is an option
896         used only on buildbot slaves.
897
898         This patch will:
899         - Remove the old format since perf-o-matic supports new format now.
900         - Add --reset-results option so that we can explicitly clear existing outputs.
901         - Add --slave-config-json-path option to replace --source-json-path option.
902
903         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
904         (PerfTestsRunner._parse_args): Added --reset-results and --slave-config-json-path options.
905         (PerfTestsRunner._generate_and_show_results): Refactored. Also removed the code to strip "values" from
906         results since perf-o-matic can parse and store these values now.
907         (PerfTestsRunner._merge_outputs_if_needed): Renamed from _merge_outputs_if_needed.
908         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
909         (test_run_with_json_output): Test a harmless behavioral change to generate resuls page even when
910         --test-results-server is present.
911         (test_run_with_description):
912         (test_run_generates_json_by_default):
913         (test_run_merges_output_by_default): Added.
914         (test_run_respects_reset_results): Added.
915         (test_run_with_slave_config_json):
916         (test_run_with_bad_slave_config_json): Use --slave-config-json-path instead of --source-json-path to make
917         sure this optioon works as well.
918         (test_run_with_multiple_repositories):
919         (test_run_with_upload_json):
920
921 2012-09-25  Simon Fraser  <simon.fraser@apple.com>
922
923         Fix SnowLeopard build by adding #ifdefs.
924         
925         Fix crashes on some tests where the CFURLRef appears to be null.
926
927         * WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
928         (WTR::testPathFromURL):
929         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
930
931 2012-09-25  Simon Fraser  <simon.fraser@apple.com>
932
933         Speculative build fix for Production builds.
934
935         * DumpRenderTree/mac/Configurations/Base.xcconfig:
936         * WebKitTestRunner/Configurations/Base.xcconfig:
937
938 2012-09-25  Simon Fraser  <simon.fraser@apple.com>
939
940         Fix the build after r129566.
941
942         * DumpRenderTree/mac/FrameLoadDelegate.mm:
943
944 2012-09-25  Dominic Mazzoni  <dmazzoni@google.com>
945
946         AX: AccessibilityUIElementChromium.cpp won't build on Windows without wtf/StringExtras.h
947         https://bugs.webkit.org/show_bug.cgi?id=97614
948
949         Unreviewed, fixing windows breakage.
950
951         Added wtf/StringExtras.h to the includes to fix the Chromium/Windows build.
952
953         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
954
955 2012-09-24  Simon Fraser  <simon.fraser@apple.com>
956
957         <rdar://problem/12351906> Have DumpRenderTree and WebKitTestRunner crash logs show which test crashed
958
959         Reviewed by Mark Rowe.
960
961         Use a new WebKitSytemInterface function to add data to crash logs about which 
962         test was running when the crash happened.
963
964         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Make sure WEBKIT_SYSTEM_INTERFACE_LIBRARY is defined.
965         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: link with the WebKitSystemInterface library.
966         * DumpRenderTree/mac/FrameLoadDelegate.mm:
967         (testPathFromURL): Given a (probably) file URL, return the part after "/LayoutTests/"
968         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): Tell Crash Reporter which test was running,
969         if we're the main frame and the test is active.
970         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Make sure WEBKIT_SYSTEM_INTERFACE_LIBRARY is defined.
971         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: link the injected bundle with the WebKitSystemInterface library.
972         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
973         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): Call platformDidStartProvisionalLoadForFrame().
974         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Stub for non-Mac platforms.
975         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
976         Add a platformDidStartProvisionalLoadForFrame() for platform-specific work.
977         * WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm: Added.
978         (WTR::testPathFromURL): Given a (probably) file URL, return the part after "/LayoutTests/"
979         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Tell Crash Reporter which test was running,
980         if we're the main frame.
981         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Add InjectedBundlePageMac.mm.
982
983 2012-09-25  Julie Parent  <jparent@chromium.org>
984
985         Make test_shell_tests show up in flakiness dashboard.
986         https://bugs.webkit.org/show_bug.cgi?id=97585
987
988         Reviewed by Dirk Pranke.
989
990         test_shell_tests run only on chromium.org, and on the same bots as
991         the layout tests, so do not use the generic fallbacks.
992
993         * TestResultServer/static-dashboards/builders.js:
994         (loadBuildersList):
995         * TestResultServer/static-dashboards/dashboard_base.js:
996         (currentBuilderGroupCategory):
997
998 2012-09-25  Lucas Forschler  <lforschler@apple.com>
999
1000         Python tests fail on Windows bots when running with more than one child process.  Temporarily use only one child process until the problem can be fixed.
1001         https://bugs.webkit.org/show_bug.cgi?id=97465
1002         
1003         Reviewed by Tim Horton.
1004
1005         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1006         (RunPythonTests.start):
1007
1008 2012-09-25  Mike West  <mkwst@chromium.org>
1009
1010         Unreviewed. Adding myself as a committer.
1011
1012         Yay. :)
1013
1014         * Scripts/webkitpy/common/config/committers.py:
1015
1016 2012-09-25  Beth Dakin  <bdakin@apple.com>
1017
1018         https://bugs.webkit.org/show_bug.cgi?id=95397
1019         Need to merge didFirstVisuallyNonEmptyLayout and 
1020         didNewFirstVisuallyNonEmptyLayout
1021         -and corresponding-
1022         <rdar://problem/10791680>
1023
1024         Reviewed by Sam Weinig.
1025
1026         Account for the new member of the PageLoadClient.
1027         * MiniBrowser/mac/BrowserWindowController.m:
1028         (-[BrowserWindowController awakeFromNib]):
1029         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1030         (WTR::InjectedBundlePage::InjectedBundlePage):
1031         * WebKitTestRunner/TestController.cpp:
1032         (WTR::TestController::initialize):
1033
1034         The NewFirstVisuallyNonEmptyLayoutForImages has existed for a while, 
1035         but it did not have the right target membership.
1036         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1037
1038         Use new didLayout API instead of old 
1039         didNewFirstVisuallyNonEmptyLayout API.
1040         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
1041         (TestWebKitAPI):
1042         (TestWebKitAPI::didLayout):
1043         (TestWebKitAPI::setPageLoaderClient):
1044         (TestWebKitAPI::TEST):
1045         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
1046         (TestWebKitAPI):
1047         (TestWebKitAPI::didLayout):
1048         (TestWebKitAPI::setPageLoaderClient):
1049         (TestWebKitAPI::TEST):
1050         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
1051         (TestWebKitAPI):
1052         (TestWebKitAPI::didLayout):
1053         (TestWebKitAPI::setPageLoaderClient):
1054         (TestWebKitAPI::TEST):
1055         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
1056         (TestWebKitAPI):
1057         (TestWebKitAPI::didLayout):
1058         (TestWebKitAPI::setPageLoaderClient):
1059         (TestWebKitAPI::TEST):
1060
1061 2012-09-25  Benjamin Poulain  <bpoulain@apple.com>
1062
1063         Add missing support for Geolocation tests on WebKit2
1064         https://bugs.webkit.org/show_bug.cgi?id=97518
1065
1066         Reviewed by Sam Weinig.
1067
1068         There are two main features added to the tooling to make the test run:
1069         -Add support for error reporting for position errors through setMockGeolocationPositionUnavailableError.
1070         -Support the 3 states permission: undefined-allowed-denied.
1071
1072         * WebKitTestRunner/GeolocationProviderMock.cpp:
1073         (WTR::GeolocationProviderMock::GeolocationProviderMock):
1074         (WTR::GeolocationProviderMock::setPosition):
1075         (WTR::GeolocationProviderMock::setPositionUnavailableError):
1076         (WTR::GeolocationProviderMock::startUpdating):
1077         (WTR::GeolocationProviderMock::sendPositionIfNeeded):
1078         (WTR::GeolocationProviderMock::sendErrorIfNeeded):
1079         * WebKitTestRunner/GeolocationProviderMock.h:
1080         (GeolocationProviderMock):
1081         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1082         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1083         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
1084         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1085         (InjectedBundle):
1086         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1087         (WTR::TestRunner::setMockGeolocationPositionUnavailableError):
1088         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1089         (TestRunner):
1090         * WebKitTestRunner/TestController.cpp:
1091         (WTR::TestController::TestController):
1092         (WTR::decidePolicyForGeolocationPermissionRequest):
1093         (WTR::TestController::resetStateToConsistentValues):
1094         (WTR::TestController::setGeolocationPermission):
1095         (WTR::TestController::setMockGeolocationPosition):
1096         (WTR::TestController::setMockGeolocationPositionUnavailableError):
1097         (WTR::TestController::handleGeolocationPermissionRequest):
1098         (WTR::TestController::decidePolicyForGeolocationPermissionRequestIfPossible):
1099         * WebKitTestRunner/TestController.h:
1100         (TestController):
1101         * WebKitTestRunner/TestInvocation.cpp:
1102         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1103
1104 2012-09-25  Sheriff Bot  <webkit.review.bot@gmail.com>
1105
1106         Unreviewed, rolling out r129517.
1107         http://trac.webkit.org/changeset/129517
1108         https://bugs.webkit.org/show_bug.cgi?id=97582
1109
1110         Link errors in chromium (Requested by alecf on #webkit).
1111
1112         * DumpRenderTree/DumpRenderTree.gypi:
1113         * DumpRenderTree/chromium/MockConstraints.cpp: Removed.
1114         * DumpRenderTree/chromium/MockConstraints.h: Removed.
1115         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1116         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
1117         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
1118         (RTCVoidRequestTask::RTCVoidRequestTask):
1119         (isSupportedConstraint):
1120         (isValidConstraint):
1121         (MockWebRTCPeerConnectionHandler::initialize):
1122         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
1123         (WebKit::WebUserMediaClientMock::requestUserMedia):
1124         * DumpRenderTree/chromium/WebUserMediaClientMock.h:
1125         (WebKit):
1126         (WebUserMediaClientMock):
1127         * DumpRenderTree/chromium/WebViewHost.h:
1128         (WebKit):
1129         (WebViewHost):
1130
1131 2012-09-25  Dominic Mazzoni  <dmazzoni@google.com>
1132
1133         AX: Chromium doesn't pass accessibility text range and line number tests
1134         https://bugs.webkit.org/show_bug.cgi?id=97246
1135
1136         Reviewed by Chris Fleizach.
1137
1138         Provide a chromium implementation of some AccessibilityUIElement
1139         methods needed by accessibility tests.
1140
1141         Enables four existing tests to pass on Chromium:
1142         Tests: accessibility/textarea-insertion-point-line-number.html
1143                accessibility/textarea-line-for-index.html
1144                accessibility/textarea-selected-text-range.html
1145                accessibility/textbox-role-reports-selection.html
1146
1147         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
1148         (AccessibilityUIElement::insertionPointLineNumberGetterCallback):
1149         (AccessibilityUIElement::selectedTextRangeGetterCallback):
1150         (AccessibilityUIElement::lineForIndexCallback):
1151         (AccessibilityUIElement::setSelectedTextRangeCallback):
1152
1153 2012-09-25  Peter Beverloo  <peter@chromium.org>
1154
1155         [Chromium] Android's build archives have grown from 38M to 102M in 11 days
1156         https://bugs.webkit.org/show_bug.cgi?id=97336
1157
1158         Reviewed by Adam Barth.
1159
1160         Each WebKit target results in four APKs in the out/{Debug,Release}/ directory,
1161         while we really only need one. Ignoring the unsigned APKs removes six from
1162         the archive will make sure that we only archive a single APK per target,
1163         bringing its size back to rougly 40 megabytes.
1164
1165         * BuildSlaveSupport/built-product-archive:
1166         (archiveBuiltProduct):
1167
1168 2012-09-25  Tommy Widenflycht  <tommyw@google.com>
1169
1170         MediaStream API: Update getUserMedia to match the latest specification
1171         https://bugs.webkit.org/show_bug.cgi?id=97540
1172
1173         Reviewed by Adam Barth.
1174
1175         Adding mock support for the enhanced getUserMedia call.
1176
1177         * DumpRenderTree/DumpRenderTree.gypi:
1178         * DumpRenderTree/chromium/MockConstraints.cpp: Copied from Source/WebCore/platform/chromium/support/WebMediaConstraints.cpp.
1179         (MockConstraints):
1180         (MockConstraints::isSupported):
1181         (MockConstraints::isValid):
1182         (MockConstraints::verify):
1183         * DumpRenderTree/chromium/MockConstraints.h: Copied from Tools/DumpRenderTree/chromium/WebUserMediaClientMock.h.
1184         (WebKit):
1185         (MockConstraints):
1186         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1187         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
1188         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
1189         (RTCVoidRequestTask::RTCVoidRequestTask):
1190         (MockWebRTCPeerConnectionHandler::initialize):
1191         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
1192         (UserMediaRequestTask):
1193         (UserMediaRequestTask::UserMediaRequestTask):
1194         (WebUserMediaClientMock::requestUserMedia):
1195         * DumpRenderTree/chromium/WebUserMediaClientMock.h:
1196         (WebUserMediaClientMock):
1197         (WebUserMediaClientMock::taskList):
1198         * DumpRenderTree/chromium/WebViewHost.h:
1199         (WebKit):
1200         (WebViewHost):
1201
1202 2012-09-25  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1203
1204         [EFL] Do not dump inspector output in DRT
1205         https://bugs.webkit.org/show_bug.cgi?id=97018
1206
1207         Reviewed by Kenneth Rohde Christiansen.
1208
1209         Some inspector-related layout tests expect console output from the
1210         inspector view to be suppressed. Do that by setting a property in
1211         the inspector view that makes the onConsoleMessage callback return
1212         early and not output anything.
1213
1214         Using evas_object_data_{get,set} is not very beautiful, but it is
1215         still better than properly subclassing Ewk_View and having to
1216         implement something similar to drt_view_console_message_enable_set().
1217
1218         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1219         (DumpRenderTreeChrome::createWebInspectorView):
1220         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1221         (onConsoleMessage):
1222
1223 2012-09-25  Christophe Dumez  <christophe.dumez@intel.com>
1224
1225         [WK2][WKTR] TestRunner needs support for setWillSendRequestReturnsNullOnRedirect
1226         https://bugs.webkit.org/show_bug.cgi?id=97542
1227
1228         Reviewed by Kenneth Rohde Christiansen.
1229
1230         Implement support for setWillSendRequestReturnsNullOnRedirect
1231         in WebKitTestRunner.
1232
1233         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1234         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1235         (WTR::InjectedBundlePage::willSendRequestForFrame):
1236         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1237         (WTR::TestRunner::TestRunner):
1238         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1239         (WTR::TestRunner::willSendRequestReturnsNullOnRedirect):
1240         (WTR::TestRunner::setWillSendRequestReturnsNullOnRedirect):
1241         (TestRunner):
1242
1243 2012-09-25  Xiaobo Wang  <xbwang@torchmobile.com.cn>
1244
1245         [BlackBerry] [DRT] fast/forms/textarea-live-pseudo-selectors.html failed
1246         https://bugs.webkit.org/show_bug.cgi?id=97189
1247
1248         Reviewed by Rob Buis.
1249
1250         Translate ASCII key code to BlackBerry key code for BACKSPACE and DELETE key.
1251
1252         * DumpRenderTree/blackberry/EventSender.cpp:
1253         (keyDownCallback):
1254
1255 2012-09-25  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1256
1257         [WK2][WTR] WTR bundle client loads binary data as text
1258         https://bugs.webkit.org/show_bug.cgi?id=97532
1259
1260         Reviewed by Kenneth Rohde Christiansen.
1261
1262         WTR::InjectedBundlePage::decidePolicyForResponse now checks response MIME type
1263         and returns WKBundlePagePolicyActionPassThrough if it cannot be shown.
1264
1265         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1266         (WTR::InjectedBundlePage::decidePolicyForResponse):
1267
1268 2012-09-25  Zan Dobersek  <zandobersek@gmail.com>
1269
1270         Unreviewed, another test case adjustment after r129459. Python 2.7 doesn't
1271         seem to be a requirement yet so the assertDictEqual method is not yet available
1272         on all builders. Assert that the empty dictionary length equals 0 instead.
1273
1274         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1275         (ResultSummaryTest.test_interpret_test_failures):
1276
1277 2012-09-24  Simon Hausmann  <simon.hausmann@digia.com>
1278
1279         [Qt] Fix build with latest Qt 5
1280         https://bugs.webkit.org/show_bug.cgi?id=97479
1281
1282         Reviewed by Tor Arne Vestbø.
1283
1284         The variables for syncqt handling are now set in api.pri, but let's add a comment here that we can
1285         remove them from default_pre.prf once we're past Qt 5 beta2.
1286
1287         * qmake/mkspecs/features/default_pre.prf:
1288
1289 2012-09-25  Zan Dobersek  <zandobersek@gmail.com>
1290
1291         Unreviewed, adjusting the test cases after r129459. The JSON data
1292         for reftests now contains the 'reftest_type' key and no more 'is_reftest'
1293         or 'is_mismatch_reftest' keys.
1294
1295         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1296         (EndToEndTest.test_reftest_with_two_notrefs):
1297
1298 2012-09-24  Zan Dobersek  <zandobersek@gmail.com>
1299
1300         Unexpected reftest passes are only reported when pixel testing is enabled in results.html as well
1301         https://bugs.webkit.org/show_bug.cgi?id=97426
1302
1303         Reviewed by Ojan Vafai.
1304
1305         The 'is_reftest' member of the TestResult class has been replaced by the reftest_type
1306         member which is a set containing either '!=', '==', both or none if the test represented
1307         by the object is not a reftest.
1308
1309         When summarizing results, the test dictionary is updated to contain the 'reftest_type' key
1310         if the test is a reftest. The value of this key is a list of all the reftest types of this test.
1311
1312         The test failure interpretation method has been refactored, it now reports only
1313         missing results of various formats and image diff percent in case of image or
1314         reftest mismatch.
1315
1316         Unit tests have been modified accordingly.
1317
1318         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1319         (LayoutTestRunner._update_summary_with_result):
1320         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1321         (LayoutTestRunnerTests.test_update_summary_with_result):
1322         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1323         (interpret_test_failures):
1324         (summarize_results):
1325         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1326         (ResultSummaryTest.test_interpret_test_failures):
1327         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1328         (SingleTestRunner.run):
1329         (SingleTestRunner._run_reftest):
1330         * Scripts/webkitpy/layout_tests/models/test_results.py:
1331         (TestResult.__init__):
1332         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1333         (EndToEndTest.test_reftest_with_two_notrefs):
1334
1335 2012-09-24  Sam Weinig  <sam@webkit.org>
1336
1337         Use NSUserDefaults rather than an environment variable to control whether to use an XPC Service for the WebProcess
1338         https://bugs.webkit.org/show_bug.cgi?id=97514
1339
1340         Reviewed by Anders Carlsson.
1341
1342         * Scripts/webkitdirs.pm:
1343         (argumentsForRunAndDebugMacWebKitApp):
1344         Push "-WebKit2UseXPCServiceForWebProcess YES" as arguments when --use-web-process-xpc-service
1345         is provided to set the user default. Move adding of @ARGV to after custom additions as calling
1346         shouldUseXPCServiceForWebProcess() can change @ARGV.
1347
1348         (runMacWebKitApp):
1349         (execMacWebKitAppForDebugging):
1350         Stop setting the WEBKIT_USE_XPC_SERVICE_FOR_WEB_PROCESS environment variable.
1351
1352 2012-09-24  Laszlo Gombos  <l.gombos@samsung.com>
1353
1354         [GTK][EFL] Make sure cairo is built with fontconfig support
1355         https://bugs.webkit.org/show_bug.cgi?id=97513
1356
1357         Reviewed by Martin Robinson.
1358
1359         The GTK and EFL port of WebKit requires a version of cairo that is built with fontconfig support. 
1360
1361         * efl/jhbuild.modules:
1362         * gtk/jhbuild.modules:
1363
1364 2012-09-24  Benjamin Poulain  <bpoulain@apple.com>
1365
1366         Fix Geolocation error reporting in the test support
1367         https://bugs.webkit.org/show_bug.cgi?id=97386
1368
1369         Reviewed by Sam Weinig.
1370         The TestRunner was exposing internal implementation details of
1371         the Geolocation object through setMockGeolocationError().
1372
1373         In practice, only the error code PositionUnavailable is supported
1374         or even implemented.
1375
1376         Exposing setMockGeolocationError() does not make sense for WebKit2 as
1377         passing generic errors from the UIProcess is a bad idea. This is the
1378         opportunity to clean TestRunner and prepare and interface suitable for WebKit2.
1379
1380         * DumpRenderTree/TestRunner.cpp:
1381         (setMockGeolocationPositionUnavailableErrorCallback):
1382         (TestRunner::staticFunctions):
1383         * DumpRenderTree/TestRunner.h:
1384         (TestRunner):
1385         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1386         (TestRunner::setMockGeolocationPositionUnavailableError):
1387         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1388         (DRTTestRunner::DRTTestRunner):
1389         (DRTTestRunner::setMockGeolocationPositionUnavailableError):
1390         * DumpRenderTree/chromium/DRTTestRunner.h:
1391         (DRTTestRunner):
1392         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1393         (TestRunner::setMockGeolocationPositionUnavailableError):
1394         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1395         (TestRunner::setMockGeolocationPositionUnavailableError):
1396         * DumpRenderTree/mac/MockGeolocationProvider.h:
1397         * DumpRenderTree/mac/MockGeolocationProvider.mm:
1398         (-[MockGeolocationProvider dealloc]):
1399         (-[MockGeolocationProvider resetError]):
1400         (-[MockGeolocationProvider setPosition:]):
1401         (-[MockGeolocationProvider setPositionUnavailableErrorWithMessage:]):
1402         (-[MockGeolocationProvider lastPosition]):
1403         (-[MockGeolocationProvider timerFired]):
1404         * DumpRenderTree/mac/TestRunnerMac.mm:
1405         (TestRunner::setMockGeolocationPositionUnavailableError):
1406         * DumpRenderTree/qt/TestRunnerQt.cpp:
1407         (TestRunner::setMockGeolocationPositionUnavailableError):
1408         * DumpRenderTree/qt/TestRunnerQt.h:
1409         (TestRunner):
1410         * DumpRenderTree/win/TestRunnerWin.cpp:
1411         (TestRunner::setMockGeolocationPositionUnavailableError):
1412         * DumpRenderTree/wx/TestRunnerWx.cpp:
1413         (TestRunner::setMockGeolocationPositionUnavailableError):
1414
1415 2012-09-24  Nikhil Bansal  <n.bansal@samsung.com>
1416
1417         [EFL][WK2] TestRunner needs touch events support.
1418         https://bugs.webkit.org/show_bug.cgi?id=96465
1419
1420         Reviewed by Kenneth Rohde Christiansen.
1421
1422         Simulate touch events in WebkitTestRunner for touch related
1423         layout tests. This patch uses ewk_view_feed_touch_event() to
1424         generate touch events.
1425
1426         * WebKitTestRunner/EventSenderProxy.h:
1427         (EventSenderProxy):
1428         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
1429         (WTR):
1430         (WTR::setEvasModifiers):
1431         (WTR::EventSenderProxy::EventSenderProxy):
1432         (WTR::EventSenderProxy::~EventSenderProxy):
1433         (WTR::EventSenderProxy::sendTouchEvent):
1434         (WTR::EventSenderProxy::addTouchPoint):
1435         (WTR::EventSenderProxy::updateTouchPoint):
1436         (WTR::EventSenderProxy::setTouchModifier):
1437         (WTR::EventSenderProxy::touchStart):
1438         (WTR::EventSenderProxy::touchMove):
1439         (WTR::EventSenderProxy::touchEnd):
1440         (WTR::EventSenderProxy::touchCancel):
1441         (WTR::EventSenderProxy::clearTouchPoints):
1442         (WTR::EventSenderProxy::releaseTouchPoint):
1443         (WTR::EventSenderProxy::cancelTouchPoint):
1444
1445 2012-09-24  Christophe Dumez  <christophe.dumez@intel.com>
1446
1447         [WK2] TestRunner does not support overridePreference with value "0"
1448         https://bugs.webkit.org/show_bug.cgi?id=97457
1449
1450         Reviewed by Alexey Proskuryakov.
1451
1452         testRunner.overridePreference() was marked as taking a boolean
1453         in argument in testRunner.idl even though the test cases are
1454         passing strings to it. The current code works if the test
1455         case wants to enable a setting and therefore passes "1" string.
1456         However, if the test wants to disable a setting and passes "0"
1457         string, the current code also evaluates this to true causing
1458         certain test cases to fail.
1459
1460         The argument to testRunner.overridePreference() is now of string
1461         type and a function has been added to convert the string passed
1462         by the test to a boolean value.
1463
1464         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1465         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1466         (WTR::toBool):
1467         (WTR):
1468         (WTR::TestRunner::overridePreference):
1469         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1470         (TestRunner):
1471
1472 2012-09-24  Sheriff Bot  <webkit.review.bot@gmail.com>
1473
1474         Unreviewed, rolling out r129343.
1475         http://trac.webkit.org/changeset/129343
1476         https://bugs.webkit.org/show_bug.cgi?id=97479
1477
1478         It broke the build (Requested by Ossy_NIGHT on #webkit).
1479
1480         * qmake/mkspecs/features/default_pre.prf:
1481
1482 2012-09-24  Zan Dobersek  <zandobersek@gmail.com>
1483
1484         [Gtk] Unskip the Shadow DOM layout tests
1485         https://bugs.webkit.org/show_bug.cgi?id=90776
1486
1487         Reviewed by Ryosuke Niwa.
1488
1489         Enable Shadow DOM through DumpRenderTreeSupport when resetting defaults in between tests.
1490
1491         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1492         (resetDefaultsToConsistentValues):
1493
1494 2012-09-24  Zan Dobersek  <zandobersek@gmail.com>
1495
1496         REGRESSION (r129211-r129218): http/tests/loading/redirect-with-no-location-crash.html failing on GTK Linux 64-bit Release WK2 (Tests)
1497         https://bugs.webkit.org/show_bug.cgi?id=97404
1498
1499         Reviewed by Philippe Normand.
1500
1501         Print out the 'didReceiveTitle' information when dumping frame load callbacks.
1502
1503         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1504         (webViewTitleChanged):
1505
1506 2012-09-24  Simon Hausmann  <simon.hausmann@digia.com>
1507
1508         [Qt] Fix build with latest Qt 5
1509
1510         Reviewed by Tor Arne Vestbø.
1511
1512         The variables for syncqt handling are now set in api.pri, but let's add a comment here that we can
1513         remove them from default_pre.prf once we're past Qt 5 beta2.
1514
1515         * qmake/mkspecs/features/default_pre.prf:
1516
1517 2012-09-22  Dominic Mazzoni  <dmazzoni@google.com>
1518
1519         AX: Layout tests would be easier to write if AccessibilityController could find an element by id
1520         https://bugs.webkit.org/show_bug.cgi?id=97301
1521
1522         Reviewed by Chris Fleizach.
1523
1524         Adds a new accessibleElementById method to AccessibilityController, to make it
1525         easier to write cross-platform layout tests.
1526
1527         Implemented for Chromium and for Mac (DRT and WKTR).
1528
1529         * DumpRenderTree/AccessibilityController.cpp:
1530         (getAccessibleElementByIdCallback):
1531         (AccessibilityController::getJSClass):
1532         * DumpRenderTree/AccessibilityController.h:
1533         (AccessibilityController):
1534         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1535         * DumpRenderTree/chromium/TestRunner/AccessibilityControllerChromium.cpp:
1536         (AccessibilityController::AccessibilityController):
1537         (AccessibilityController::findAccessibleElementByIdRecursive):
1538         (AccessibilityController::getAccessibleElementById):
1539         (AccessibilityController::accessibleElementByIdGetterCallback):
1540         * DumpRenderTree/chromium/TestRunner/AccessibilityControllerChromium.h:
1541         (AccessibilityController):
1542         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1543         (AccessibilityController::accessibleElementById):
1544         * DumpRenderTree/mac/AccessibilityCommonMac.h: added
1545         * DumpRenderTree/mac/AccessibilityCommonMac.mm: added
1546         (+[NSString stringWithJSStringRef:]):
1547         (-[NSString createJSStringRef]):
1548         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1549         (findAccessibleObjectById):
1550         (AccessibilityController::accessibleElementById):
1551         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1552         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1553         (AccessibilityController::accessibleElementById):
1554         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1555         (WTR::AccessibilityController::accessibleElementById):
1556         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
1557         (AccessibilityController):
1558         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
1559         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h: added
1560         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm: added
1561         (+[NSString stringWithJSStringRef:]):
1562         (-[NSString createJSStringRef]):
1563         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
1564         (WTR::findAccessibleObjectById):
1565         (WTR):
1566         (WTR::AccessibilityController::accessibleElementById):
1567         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1568         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1569
1570 2012-09-22  Zan Dobersek  <zandobersek@gmail.com>
1571
1572         Unexpected reftest passes are only reported when pixel testing is enabled
1573         https://bugs.webkit.org/show_bug.cgi?id=97242
1574
1575         Reviewed by Dirk Pranke.
1576
1577         LayoutTestRunner should know whether the finished test it's handling is
1578         a reftest. This is necessary when updating result summary for reftests
1579         when pixel testing is not enabled - in these circumstances an unexpectedly
1580         passing reftest was not reported as such due to pixel testing then being
1581         determined by searching for reftest failures in failures list, which were
1582         not found in an empty failure list of a passing test. Now the TestResult
1583         objects have a member variable indicating the test is a reftest whenever
1584         that's the case.
1585
1586         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1587         (LayoutTestRunner._update_summary_with_result):
1588         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1589         (LayoutTestRunnerTests.test_update_summary_with_result):
1590         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1591         (SingleTestRunner.run):
1592         (SingleTestRunner._run_reftest):
1593         * Scripts/webkitpy/layout_tests/models/test_results.py:
1594         (TestResult.__init__):
1595
1596 2012-09-21  Sam Weinig  <sam@webkit.org>
1597
1598         WebProcess XPC services need have their environment set without disrupting all other XPC services
1599         https://bugs.webkit.org/show_bug.cgi?id=95161
1600
1601         Reviewed by Anders Carlsson.
1602
1603         Remove setting the __XPC_* environment variables.
1604
1605         * Scripts/webkitdirs.pm:
1606         (setUpGuardMallocIfNeeded):
1607         (runMacWebKitApp):
1608         (execMacWebKitAppForDebugging):
1609
1610 2012-09-21  Dirk Pranke  <dpranke@chromium.org>
1611
1612         Fix typo in additional-platform-directory patch just landed
1613         https://bugs.webkit.org/show_bug.cgi?id=97380
1614         
1615         Unreviewed, build fix.
1616
1617         * Scripts/webkitpy/layout_tests/port/base.py:
1618         (Port.relative_test_filename):
1619         (Port.relative_perf_test_filename):
1620
1621 2012-09-21  Dirk Pranke  <dpranke@chromium.org>
1622
1623         nrwt: don't require additional-platform-directory to be an abspath or live under LayoutTests
1624         https://bugs.webkit.org/show_bug.cgi?id=97380
1625
1626         Reviewed by Ojan Vafai.
1627
1628         There doesn't seem to be a good reason for this restriction and
1629         it's useful to be able to point to directories outside the
1630         checkout for results (e.g., for local failures due to a 10.7.4
1631         install ;).
1632
1633         * Scripts/webkitpy/layout_tests/port/base.py:
1634         (Port.relative_test_filename):
1635         (Port.relative_perf_test_filename):
1636         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1637         (ChromiumAndroidDriver._command_from_driver_input):
1638         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1639         (_set_up_derived_options):
1640         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1641         (MainTest.test_additional_platform_directory):
1642
1643 2012-09-21  Dirk Pranke  <dpranke@chromium.org>
1644
1645         webkitpy: drop support for old TestExpectations syntax
1646         https://bugs.webkit.org/show_bug.cgi?id=97364
1647
1648         Reviewed by Ryosuke Niwa.
1649
1650         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1651         (TestExpectationParser._collect_matching_tests):
1652         (TestExpectationParser):
1653         (TestExpectationParser._tokenize_line):
1654         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1655         (SkippedTests.test_skipped_entry_dont_exist):
1656         (ExpectationSyntaxTests.assert_tokenize_exp):
1657         (ExpectationSyntaxTests.test_bare_name):
1658         (ExpectationSyntaxTests.test_bare_name_and_bugs):
1659         (ExpectationSyntaxTests.test_comments):
1660         (ExpectationSyntaxTests.test_config_modifiers):
1661         (ExpectationSyntaxTests.test_unknown_config):
1662         (ExpectationSyntaxTests.test_unknown_expectation):
1663         (ExpectationSyntaxTests.test_skip):
1664         (ExpectationSyntaxTests.test_slow):
1665         (ExpectationSyntaxTests.test_wontfix):
1666         (ExpectationSyntaxTests.test_blank_line):
1667         (ExpectationSyntaxTests.test_warnings):
1668         (RebaseliningTest.test_no_get_rebaselining_failures):
1669
1670 2012-09-21  Simon Fraser  <simon.fraser@apple.com>
1671
1672         Improve WTR unresponsiveness output a little
1673         https://bugs.webkit.org/show_bug.cgi?id=97370
1674
1675         Reviewed by Timothy Horton.
1676
1677         Distinguish between conditions that already set the errorMessage,
1678         and unresponsiveness due to slow about:blank loads when WTR
1679         reports unresponsiveness.
1680
1681         * WebKitTestRunner/TestInvocation.cpp:
1682         (WTR::TestInvocation::invoke):
1683
1684 2012-09-21  Chris Rogers  <crogers@google.com>
1685
1686         Add Web Audio support for deprecated/legacy APIs
1687         https://bugs.webkit.org/show_bug.cgi?id=97050
1688
1689         Reviewed by Eric Carlson.
1690
1691         * Scripts/webkitperl/FeatureList.pm:
1692
1693 2012-09-21  Dirk Pranke  <dpranke@chromium.org>
1694
1695         webkitpy: update remaining tests to use the new expectation syntax
1696         https://bugs.webkit.org/show_bug.cgi?id=97362
1697
1698         Reviewed by Ojan Vafai.
1699
1700         This patch updates all the unit tests that were still using the
1701         old TestExpectations syntax to use the new syntax *except* for
1702         the tests that were specifically testing that we parsed the old
1703         syntax correctly.
1704
1705         Also, a block of tests for the new syntax were duplicated, so
1706         I've deleted the duplicate.
1707
1708         Note that the old syntax is still supported so this change should
1709         produce no visible changes.
1710
1711         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1712         (MiscTests.test_multiple_results):
1713         (MiscTests.test_category_expectations):
1714         (MiscTests.test_error_on_different_platform):
1715         (MiscTests.test_error_on_different_build_type):
1716         (MiscTests.test_overrides):
1717         (MiscTests.test_overrides__directory):
1718         (MiscTests.test_overrides__duplicate):
1719         (MiscTests.test_more_specific_override_resets_skip):
1720         (SkippedTests.check):
1721         (SkippedTests.test_duplicate_skipped_test_fails_lint):
1722         (SkippedTests.test_skipped_file_overrides_expectations):
1723         (SkippedTests.test_skipped_dir_overrides_expectations):
1724         (SkippedTests.test_skipped_file_overrides_overrides):
1725         (SkippedTests.test_skipped_dir_overrides_overrides):
1726         (ExpectationSyntaxTests.disabled_test_missing_expectation):
1727         (ExpectationSyntaxTests.disabled_test_missing_colon):
1728         (ExpectationSyntaxTests.disabled_test_too_many_colons):
1729         (ExpectationSyntaxTests.disabled_test_too_many_equals_signs):
1730         (ExpectationSyntaxTests):
1731         (ExpectationSyntaxTests.test_unrecognized_expectation):
1732         (ExpectationSyntaxTests.test_macro):
1733         (SemanticTests.test_bug_format):
1734         (SemanticTests.test_bad_bugid):
1735         (SemanticTests.test_missing_bugid):
1736         (SemanticTests.test_slow_and_timeout):
1737         (SemanticTests.test_rebaseline):
1738         (test_missing_file):
1739         (test_ambiguous):
1740         (test_more_modifiers):
1741         (test_order_in_file):
1742         (test_macro_overrides):
1743         (OldExpectationParserTests):
1744         (OldExpectationParserTests._tokenize):
1745         (OldExpectationParserTests.test_tokenize_extra_colon):
1746         (OldExpectationParserTests.test_tokenize_missing_equal):
1747         (OldExpectationParserTests.test_tokenize_extra_equal):
1748         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1749         (MainTest.test_skip_failing_tests):
1750         (MainTest.test_additional_expectations):
1751         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1752         (TestExpectationsTestCase.test_valid_expectations):
1753         (TestExpectationsTestCase.test_invalid_expectations):
1754         (TestExpectationsTestCase.test_tab):
1755
1756 2012-09-21  Benjamin Poulain  <bpoulain@apple.com>
1757
1758         [WK2] Add basic testing support for Geolocation
1759         https://bugs.webkit.org/show_bug.cgi?id=97278
1760
1761         Reviewed by Kenneth Rohde Christiansen.
1762
1763         Update the Geolocation testing to use the proper API in the UIProcess.
1764
1765         * WebKitTestRunner/CMakeLists.txt:
1766         * WebKitTestRunner/GNUmakefile.am:
1767
1768         * WebKitTestRunner/GeolocationProviderMock.cpp: Added.
1769         (WTR::startUpdatingCallback):
1770         (WTR::stopUpdatingCallback):
1771         (WTR::GeolocationProviderMock::GeolocationProvierMock):
1772         (WTR::GeolocationProviderMock::setMockGeolocationPosition):
1773         (WTR::GeolocationProviderMock::startUpdating):
1774         (WTR::GeolocationProviderMock::stopUpdating):
1775         (GeolocationProviderMock):
1776         The GeolocationProvider store the location update and deliver them as needed.
1777
1778         WebCore GeolocationController do not support asynchronous update on start/stop. This is not
1779         a problem in this case because all the messages between the WebProcess and the UIProcess are
1780         asynchronous. Because of this, unlike GeolocationClientMock, we do not use a timer for event
1781         delivery.
1782
1783         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1784         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1785         (WTR::InjectedBundle::setGeolocationPermission):
1786         (WTR::InjectedBundle::setMockGeolocationPosition):
1787         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1788         (InjectedBundle):
1789         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1790         (WTR::TestRunner::setGeolocationPermission):
1791         (WTR::TestRunner::setMockGeolocationPosition):
1792         From the InjectedBundle, we now pass the information to the UIProcess so that
1793         GeolocationProvider and the TestController can respond appropriately.
1794
1795         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1796         (TestRunner):
1797         * WebKitTestRunner/Target.pri:
1798         * WebKitTestRunner/TestController.cpp:
1799         (WTR::TestController::TestController):
1800         (WTR::decidePolicyForGeolocationPermissionRequest):
1801         (WTR::TestController::createOtherPage):
1802         (WTR::TestController::initialize):
1803         (WTR::TestController::setMockGeolocationPosition):
1804         * WebKitTestRunner/TestController.h:
1805         (TestController):
1806         (WTR::TestController::setGeolocationPermission):
1807         (WTR::TestController::isGeolocationPermissionAllowed):
1808         * WebKitTestRunner/TestInvocation.cpp:
1809         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1810         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1811         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1812
1813 2012-09-21  Joanmarie Diggs  <jdiggs@igalia.com>
1814
1815         REGRESSION (r127882): accessibility/spinbutton-value.html failing on GTK
1816         https://bugs.webkit.org/show_bug.cgi?id=96196
1817
1818         Reviewed by Martin Robinson.
1819
1820         The "regression" is that a new test was added but the support was missing
1821         in the Gtk port for spin buttons.
1822
1823         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1824         (AccessibilityUIElement::valueDescription): Updated the FIXME comment to
1825         indicate that this cannot be implemented until it is implemented in ATK.
1826         URL of the newly-filed ATK bug included for reference.
1827
1828 2012-09-21  Dirk Pranke  <dpranke@chromium.org>
1829
1830         Fix test_skip_and_wontfix failure
1831         https://bugs.webkit.org/show_bug.cgi?id=97225
1832
1833         Unreviewed, build fix.
1834
1835         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1836         (SemanticTests.test_skip_and_wontfix):
1837
1838 2012-09-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1839
1840         [GTK] Implement ViewState methods in PageClientImpl in WebKit2
1841         https://bugs.webkit.org/show_bug.cgi?id=97202
1842
1843         Reviewed by Martin Robinson.
1844
1845         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1846         (WTR::PlatformWebView::focus): Focus the view.
1847
1848 2012-09-21  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1849
1850         [WTR] Memory leaks in InjectedBundleController::initialize()
1851         https://bugs.webkit.org/show_bug.cgi?id=97329
1852
1853         Reviewed by Alexey Proskuryakov.
1854
1855         Fix leaks in InjectedBundleController::initialize() by adopting
1856         strings created with WKStringCreateWithUTF8CString().
1857
1858         * TestWebKitAPI/InjectedBundleController.cpp:
1859         (TestWebKitAPI::InjectedBundleController::initialize):
1860
1861 2012-09-21  Marcelo Lira  <marcelo.lira@openbossa.org>
1862
1863         [Qt][WK2] Removed duplicated code from EventSenderProxy::keyDown
1864         https://bugs.webkit.org/show_bug.cgi?id=97235
1865
1866         Reviewed by Luiz Agostini.
1867
1868         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
1869         (WTR::EventSenderProxy::keyDown):
1870
1871 2012-09-21  Gergely Kis  <gergely@homejinni.com>
1872
1873         Add MIPS build slave to build.webkit.org
1874         https://bugs.webkit.org/show_bug.cgi?id=96713
1875
1876         Reviewed by Csaba Osztrogonác.
1877
1878         Added a build slave for MIPS, and enabled a builder for 
1879         Qt Linux MIPS32R2 little-endian release build.
1880
1881         * BuildSlaveSupport/build.webkit.org-config/config.json:
1882
1883 2012-09-21  Peter Beverloo  <peter@chromium.org>
1884
1885         [Chromium] Switch back to a fixed fifo path for Android
1886         https://bugs.webkit.org/show_bug.cgi?id=97230
1887
1888         Reviewed by Tony Chang.
1889
1890         Because not all external storage cards will be formated using a file
1891         system that supports named pipes, Chromium has been changed to creating
1892         the pipes in a temporary folder on the internal storage. Adapt this in
1893         WebKit so we can continue to run layout tests.
1894
1895         This also includes an *unreviewed* fix for a breakage in the webkitpy
1896         tests I made in r129221. Two lines and related to this code, so I decided
1897         to include it in this change.
1898
1899         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1900         (ChromiumAndroidDriver.__init__):
1901         (ChromiumAndroidDriver._setup_test):
1902         (ChromiumAndroidDriver._update_version):
1903
1904 2012-09-20  Peter Beverloo  <peter@chromium.org>
1905
1906         Leverage Chromium's code to set up FIFOs for Chromium Android layout tests
1907         https://bugs.webkit.org/show_bug.cgi?id=97227
1908
1909         Reviewed by Tony Chang.
1910
1911         We switched Chromium to using FIFOs in order to achieve better consistency,
1912         which was done by Marcus in r157541. Remove all custom WebKit code in
1913         favor of Chromium's implementation.
1914
1915         Remove more FIFO code in the test runner itself, including the code in
1916         DumpRenderTree that invoked it. We can now switch to Chromium's brand
1917         new FIFO-creating code, which is being set-up for all test targets build
1918         for Android, including DumpRenderTree, TestWebKitAPI and webkit_unit_tests.
1919
1920         This also changes the ChromiumAndroidDriver._remove_all_pipes method to
1921         delete the files individually. "rm" would fail if one of the earlier files
1922         does not exist, and the "-f" argument doesn't seem to be reliable.
1923
1924         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1925         * DumpRenderTree/chromium/TestShellAndroid.cpp:
1926         (platformInit):
1927         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1928         (ChromiumAndroidDriver.__init__):
1929         (ChromiumAndroidDriver._setup_test):
1930         (ChromiumAndroidDriver._get_external_storage):
1931         (ChromiumAndroidDriver._drt_cmd_line):
1932         (ChromiumAndroidDriver._remove_all_pipes):
1933         (ChromiumAndroidDriver.stop):
1934         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
1935
1936 2012-09-21  Christophe Dumez  <christophe.dumez@intel.com>
1937
1938         [WK2][WKTR] EventSender needs to implement scheduleAsynchronousClick
1939         https://bugs.webkit.org/show_bug.cgi?id=97326
1940
1941         Reviewed by Kenneth Rohde Christiansen.
1942
1943         Implement scheduleAsynchronousClick() in WebKitTestRunner's
1944         EventSender by sending a "MouseDown" and a "MouseUp" message
1945         asynchronously to the WebProcess.
1946
1947         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1948         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1949         (WTR::createMouseMessageBody):
1950         (WTR):
1951         (WTR::EventSendingController::mouseDown):
1952         (WTR::EventSendingController::mouseUp):
1953         (WTR::EventSendingController::scheduleAsynchronousClick):
1954         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1955         (EventSendingController):
1956         * WebKitTestRunner/TestController.cpp:
1957         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1958
1959 2012-09-21  Simon Hausmann  <simon.hausmann@digia.com>
1960
1961         [Qt] Error out early if we don't have ICU available
1962
1963         Reviewed by Tor Arne Vestbø.
1964
1965         * qmake/mkspecs/features/configure.prf:
1966
1967 2012-09-21  Simon Hausmann  <simon.hausmann@digia.com>
1968
1969         [Qt] Bail out when trying to build WebKit with Qt != 5
1970
1971         Reviewed by Tor Arne Vestbø.
1972
1973         Moved check for Qt version out of default_pre into top-level WebKit.pro,
1974         because we never reach default_pre.prf due to the lack of .qmake.conf support
1975         in older versions of Qt/QMake.
1976
1977         * qmake/mkspecs/features/default_pre.prf:
1978
1979 2012-09-21  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1980
1981         WebKitTestRunner needs to print frame load delegate information
1982         https://bugs.webkit.org/show_bug.cgi?id=42705
1983
1984         Reviewed by Kenneth Rohde Christiansen.
1985
1986         Added missing dumping from WTR::InjectedBundlePage::didFailLoadWithErrorForFrame.
1987
1988         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1989         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1990
1991 2012-09-21  Christophe Dumez  <christophe.dumez@intel.com>
1992
1993         [EFL] EventSender should mimic CTRL+o emacs shortcut
1994         https://bugs.webkit.org/show_bug.cgi?id=97224
1995
1996         Reviewed by Kenneth Rohde Christiansen.
1997
1998         Add support for mimicking CTRL+o emacs shortcut in EFL's
1999         EventSender in DumpRenderTree and WebKitTestRunner.
2000
2001         * DumpRenderTree/efl/EventSender.cpp:
2002         (sendKeyDown):
2003         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
2004         (WTR::EventSenderProxy::keyDown):
2005
2006 2012-09-21  Simon Hausmann  <simon.hausmann@digia.com>
2007
2008         [Qt] Re-fix clean builds
2009
2010         Reviewed by Tor Arne Vestbø.
2011
2012         Re-introduce the sanitization for LIBS when creating a module to use
2013         LIBS_PRIVATE and otherwise do _not_ use LIBS_PRIVATE. We decided to
2014         continue to use QT, LIBS and PKGCONFIG instead of their _PRIVATE variants
2015         throughout the code base, so just using LIBS_PRIVATE in linkAgainstLibrary()
2016         causes build issues when depending system libraries end up in LIBS before
2017         LIBS_PRIVATE.
2018
2019         * qmake/mkspecs/features/default_post.prf:
2020         * qmake/mkspecs/features/functions.prf:
2021
2022 2012-09-20  Simon Fraser  <simon.fraser@apple.com>
2023
2024         Comment out a failing webkitpy unit test until Dirk can fix it.
2025
2026         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2027         (SemanticTests.test_skip_and_wontfix):
2028
2029 2012-09-20  Dirk Pranke  <dpranke@chromium.org>
2030
2031         make Skip, WontFix be the only expectations on a line
2032         https://bugs.webkit.org/show_bug.cgi?id=97225
2033
2034         Reviewed by Ojan Vafai.
2035
2036         It is now incorrect in the new syntax to have a line like:
2037
2038             foo.html [ WontFix Crash ]
2039
2040         This will generate a lint warning and be treated as an invalid
2041         line. Fixing this caused a whole bunch of unit tests to need updating
2042         to no longer be marked as WontFix :). Also, this patch adjusts
2043         the warnings so that missing Bug() identifiers will cause lint
2044         warnings but will *not* cause the line to be treated as invalid.
2045         Fixing these issues also revealed that test_hung_thread was no
2046         longer testing the right logic, so I adjusted the timeouts in
2047         test.py to make that test work again.
2048
2049         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2050         (Worker._run_test_in_another_thread):
2051         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2052         (ResultSummaryTest.test_summarized_results_wontfix):
2053         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2054         (TestExpectationParser._parse_modifiers):
2055         (TestExpectationParser._tokenize_line_using_new_format):
2056         (TestExpectationLine.is_invalid):
2057         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2058         (BasicTests.test_basic):
2059         (test_get_test_set):
2060         (test_parse_warning):
2061         (test_pixel_tests_flag):
2062         (SemanticTests.test_missing_bugid):
2063         (SemanticTests):
2064         (SemanticTests.test_skip_and_wontfix):
2065         * Scripts/webkitpy/layout_tests/port/test.py:
2066         (TestDriver.run_test):
2067         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2068         (MainTest.test_hung_thread):
2069         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2070         (PrintExpectationsTest.test_basic):
2071         (PrintExpectationsTest.test_multiple):
2072         (PrintExpectationsTest.test_full):
2073         (PrintExpectationsTest.test_exclude):
2074         (PrintExpectationsTest.test_csv):
2075
2076 2012-09-20  Lucas Forschler  <lforschler@apple.com>
2077
2078         Unreviewed.  Start running tests on the mac-ews.
2079         
2080         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2081         (MacEWS):
2082
2083 2012-09-20  Tony Chang  <tony@chromium.org>
2084
2085         [chromium] Enable more clang warnings
2086         https://bugs.webkit.org/show_bug.cgi?id=97257
2087
2088         Reviewed by James Robinson.
2089
2090         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Add -Wunused-parameter. Don't add -Wglobal-constructors because
2091         there are lots of violations in these files.
2092
2093 2012-09-19  Ryosuke Niwa  <rniwa@webkit.org>
2094
2095         run-perf-tests should record individual value instead of statistics
2096         https://bugs.webkit.org/show_bug.cgi?id=97155
2097
2098         Reviewed by Hajime Morita.
2099
2100         Parse the list of individual value reported by tests and include them as "values".
2101         We strip "values" from the output JSON when uploading it to the perf-o-matic
2102         since it doesn't know how to parse "values" or ignore it.
2103
2104         * Scripts/webkitpy/performance_tests/perftest.py:
2105         (PerfTest):
2106         (PerfTest.parse_output): Parse and report "values".
2107         (PageLoadingPerfTest.run): Report indivisual page loading time in "values".
2108         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2109         (MainTest.test_parse_output):
2110         (MainTest.test_parse_output_with_failing_line):
2111         (TestPageLoadingPerfTest.test_run):
2112         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2113         (PerfTestsRunner._generate_and_show_results): Strip "values" from each result
2114         until we update perf-o-matic.
2115         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2116         (test_run_memory_test):
2117         (test_run_with_json_output):
2118         (test_run_with_description):
2119         (test_run_with_slave_config_json):
2120         (test_run_with_multiple_repositories):
2121
2122 2012-09-20  Simon Hausmann  <simon.hausmann@digia.com>
2123
2124         [Qt] Fix production builds
2125
2126         Unreviewed trivial fix: Follow up r129119 and avoid clobbering LIBS through the use of LIBS_PRIVATE.
2127
2128         Otherwise the libQtWebKit.prl file for example contains -lWebKit1 -lWebCore, etc.
2129
2130         * qmake/mkspecs/features/functions.prf:
2131
2132 2012-09-20  Dirk Pranke  <dpranke@chromium.org>
2133
2134         REGRESSION: layout test results doesn't show diffs
2135         https://bugs.webkit.org/show_bug.cgi?id=97182
2136
2137         Reviewed by Ojan Vafai.
2138
2139         Go back to storing TEXT, AUDIO, and IMAGE+TEXT in results.json
2140         so that results.html (and hopefully garden-o-matic) can
2141         determine which things actually failed. However, we keep mapping
2142         these results to Failure so that we still only have a single
2143         expectation type for them.
2144
2145         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2146         (JSONLayoutResultsGenerator):
2147         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2148         (TestExpectationParser):
2149         (TestExpectations):
2150         (TestExpectations.result_was_expected):
2151         * Scripts/webkitpy/layout_tests/models/test_failures.py:
2152         (determine_result_type):
2153         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2154         (MainTest.test_missing_and_unexpected_results):
2155         (MainTest.test_retrying_and_flaky_tests):
2156
2157 2012-09-20  Tommy Widenflycht  <tommyw@google.com>
2158
2159         MediaStream API: Extend UserMediaRequest with a ownerDocument method
2160         https://bugs.webkit.org/show_bug.cgi?id=97095
2161
2162         Reviewed by Adam Barth.
2163
2164         Extending WebUserMediaClientMock to check that the owning document is valid,
2165         and that the document has a frame.
2166
2167         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
2168         (WebKit::WebUserMediaClientMock::requestUserMedia):
2169
2170 2012-09-20  Stephen Chenney  <schenney@chromium.org>
2171
2172         [Chromium] DRT does not support --dump-all-pixels flag
2173         https://bugs.webkit.org/show_bug.cgi?id=95098
2174
2175         Reviewed by Dirk Pranke.
2176
2177         Add support for the --pixel-tests and shorthand -p option in Chromium DumpRenderTree. Use
2178         of this flag causes pixel results to be created for all tests, regardless of
2179         individual test options. If an individual test provides a pixel hash it will be used,
2180         otherwise the hash will be empty. This replaces a previously defined but unused option
2181         --dump-all-pixels, and is useful primarily when debugging DRT instances.
2182
2183         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2184         (runTest): Add a parameter and code to force pixel results for the test.
2185         (main): Add parameter handling for --pixels-test and -p, and remove --dump-all-pixels.
2186
2187 2012-09-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2188
2189         [GTK] run-api-tests should not buffer test stdout
2190         https://bugs.webkit.org/show_bug.cgi?id=88474
2191
2192         Reviewed by Philippe Normand.
2193
2194         * Scripts/run-gtk-tests:
2195         (TestRunner._run_test_command): Use os.forkpty() instead of
2196         subprocess.Popen() so that gtest sends the output with colors to
2197         stdout. Use common.parse_output_lines() to parse the output and
2198         write it to stdout while it's read.
2199         (TestRunner._run_test_command.parse_line): Parse the line to get
2200         the test pid and write the line to stdout.
2201         (TestRunner._run_test_command.waitpid): Helper function to call
2202         waitpid handling EINTR.
2203         (TestRunner._run_test_command.return_code_from_exit_status):
2204         Helper function to convert exit status of test commands to a
2205         return code.
2206         * gtk/common.py:
2207         (parse_output_lines): Helper function that uses select to read
2208         the given file descriptor and call the given callback for every
2209         line read.
2210
2211 2012-09-20  Simon Hausmann  <simon.hausmann@digia.com>
2212
2213         [Qt] Fix initial build
2214
2215         Reviewed by Tor Arne Vestbø.
2216
2217         When building QtWebKit the first time there is no qt_webkit.pri module pri file, and therefore
2218         $$QT.webkit.name isn't set and so creating_module isn't set. That has all sorts of implications
2219         causing incorrect linking for Makefile.api, etc.
2220
2221         Fix the determination by simply checking if MODULE is set, which only happens in api.pri.
2222
2223         * qmake/mkspecs/features/webkit_modules.prf:
2224
2225 2012-09-20  Sheriff Bot  <webkit.review.bot@gmail.com>
2226
2227         Unreviewed, rolling out r129091.
2228         http://trac.webkit.org/changeset/129091
2229         https://bugs.webkit.org/show_bug.cgi?id=97205
2230
2231         It broke perf tests everywhere (Requested by Ossy on #webkit).
2232
2233         * Scripts/webkitpy/performance_tests/perftest.py:
2234         (PerfTest):
2235         (PerfTest.parse_output):
2236         (PageLoadingPerfTest.run):
2237         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2238         (MainTest.test_parse_output):
2239         (MainTest.test_parse_output_with_failing_line):
2240         (TestPageLoadingPerfTest.test_run):
2241         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2242         (PerfTestsRunner._generate_and_show_results):
2243         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2244         (test_run_memory_test):
2245         (test_run_with_json_output):
2246         (test_run_with_description):
2247         (test_run_with_slave_config_json):
2248         (test_run_with_multiple_repositories):
2249
2250 2012-09-20  Simon Hausmann  <simon.hausmann@digia.com>
2251
2252         [Qt] QtWebKit module header includes private dependencies
2253
2254         Reviewed by Tor Arne Vestbø.
2255
2256         * qmake/mkspecs/features/default_post.prf: Don't try to sanitize LIBS, because we can make sure
2257         that LIBS_PRIVATE is set from the beginning. Moved the creating_module and PKGCONFIG/QT(_PRIVATE)
2258         sanitization into webkit_modules.prf. creating_module determination requires TARGET to be set, so
2259         we can't do it in default_pre.
2260         * qmake/mkspecs/features/webkit_modules.prf:
2261
2262 2012-09-20  Simon Hausmann  <simon.hausmann@digia.com>
2263
2264         [Qt] Fix build with MingW
2265
2266         Reviewed by Tor Arne Vestbø.
2267
2268         Don't try to compile WebCore, etc. with debug symbols for production
2269         builds, it's just too big.
2270
2271         * qmake/mkspecs/features/production_build.prf:
2272
2273 2012-09-20  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
2274
2275         [EFL][DRT]DumpRenderTree needs to reset focus state when test starts.
2276         https://bugs.webkit.org/show_bug.cgi?id=97087
2277
2278         Reviewed by Gyuyoung Kim.
2279
2280         Add focusing a main frame on settings reset.
2281         After editing/undo/undo-iframe-location-change was executed a frame
2282         was left in unfocused state. This caused flakiness in two tests results.
2283
2284         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2285         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2286
2287 2012-09-20  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2288
2289         [Qt] Add eventSender.gestureTap
2290         https://bugs.webkit.org/show_bug.cgi?id=66173
2291
2292         Reviewed by Kenneth Rohde Christiansen.
2293
2294         Implement support for sending raw QGesture events.
2295
2296         * DumpRenderTree/qt/EventSenderQt.cpp:
2297         (EventSender::EventSender):
2298         (EventSender::gestureTap):
2299         * DumpRenderTree/qt/EventSenderQt.h:
2300         (EventSender):
2301
2302 2012-09-19  Sheriff Bot  <webkit.review.bot@gmail.com>
2303
2304         Unreviewed, rolling out r129007.
2305         http://trac.webkit.org/changeset/129007
2306         https://bugs.webkit.org/show_bug.cgi?id=97172
2307
2308         It broke the build on the Qt bots (Requested by Ossy on
2309         #webkit).
2310
2311         * qmake/config.tests/gccdepends/empty.cpp:
2312         * qmake/config.tests/gccdepends/gccdepends.pro:
2313         * qmake/mkspecs/features/default_pre.prf:
2314
2315 2012-09-19  Ryosuke Niwa  <rniwa@webkit.org>
2316
2317         run-perf-tests should record indivisual value instead of statistics
2318         https://bugs.webkit.org/show_bug.cgi?id=97155
2319
2320         Reviewed by Hajime Morita.
2321
2322         Parse the list of indivisual value reported by tests and include them as "values".
2323         We strip "values" from the output JSON when uploading it to the perf-o-matic
2324         since it doesn't know how to parse "values" or ignore it.
2325
2326         * Scripts/webkitpy/performance_tests/perftest.py:
2327         (PerfTest):
2328         (PerfTest.parse_output): Parse and report "values".
2329         (PageLoadingPerfTest.run): Report indivisual page loading time in "values".
2330         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2331         (MainTest.test_parse_output):
2332         (MainTest.test_parse_output_with_failing_line):
2333         (TestPageLoadingPerfTest.test_run):
2334         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2335         (PerfTestsRunner._generate_and_show_results): Strip "values" from each result
2336         until we update perf-o-matic.
2337         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2338         (test_run_memory_test):
2339         (test_run_with_json_output):
2340         (test_run_with_description):
2341         (test_run_with_slave_config_json):
2342         (test_run_with_multiple_repositories):
2343
2344 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
2345
2346         Fix regex groups for bug matching in flakiness dashboard.
2347         https://bugs.webkit.org/show_bug.cgi?id=97152
2348
2349         Unreviewed, build fix.
2350
2351         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2352         (htmlForBugs):
2353
2354 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
2355
2356         nrwt: print unexpected results using new TestExpectations syntax
2357         https://bugs.webkit.org/show_bug.cgi?id=97159
2358
2359         Unreviewed, build fix.
2360
2361         Change new-run-webkit-tests to print out failures using the new
2362         syntax when there are unexpected results, e.g.:
2363
2364         52 tests ran as expected, 19 didn't:
2365
2366
2367         Regressions: Unexpected failures : (2)
2368           failures/flaky/text.html [ Failure ]
2369           failures/unexpected/text-image-checksum.html [ Failure ]
2370
2371         and so forth
2372
2373         * Scripts/webkitpy/layout_tests/views/printing.py:
2374         (Printer._print_unexpected_results):
2375
2376 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
2377
2378         update flakiness dashboard after cutover to new test expectations syntax
2379         https://bugs.webkit.org/show_bug.cgi?id=97152
2380
2381         Unreviewed, build fix.
2382
2383         Handle (??) the new Bug notations as well. Hopefully we don't
2384         still need the old ones.
2385
2386         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2387         (filterBugs):
2388         (htmlForBugs):
2389         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2390
2391 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
2392
2393         update flakiness dashboard after cutover to new test expectations syntax
2394         https://bugs.webkit.org/show_bug.cgi?id=97152
2395
2396         Reviewed by Ryosuke Niwa.
2397
2398         This change clones the TestExpectation parsing state machine
2399         from python into javascript.
2400
2401         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2402         (parsedExpectations.lines.forEach):
2403         (parsedExpectations):
2404         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2405
2406 2012-09-19  Dana Jansens  <danakj@chromium.org>
2407
2408         Add backer@chromium.org as contributor
2409         https://bugs.webkit.org/show_bug.cgi?id=97150
2410
2411         * Scripts/webkitpy/common/config/committers.py:
2412
2413 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
2414
2415         fix MISSING after TestExpectations conversion
2416         https://bugs.webkit.org/show_bug.cgi?id=97148
2417
2418         Unreviewed, expectations change / build fix.
2419
2420         * Scripts/convert-test-expectations:
2421         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2422         (TestExpectationParser):
2423
2424 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
2425
2426         nrwt: convert chromium TestExpectations to the new syntax
2427         https://bugs.webkit.org/show_bug.cgi?id=97139
2428
2429         Reviewed by Ryosuke Niwa.
2430     
2431         Add in a file temporarily that does the conversion of
2432         test expectations formats
2433
2434         * Tools/Scripts/convert-test-expectations: Added.
2435
2436 2012-09-19  Ryosuke Niwa  <rniwa@webkit.org>
2437
2438         REGRESSION: run-perf-tests no longer reports the total test time
2439         https://bugs.webkit.org/show_bug.cgi?id=97138
2440
2441         Reviewed by Tony Chang.
2442
2443         Report the finished time as a info-level log as opposed to a debug level log.
2444
2445         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2446         (PerfTestsRunner._run_single_test):
2447         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2448         (MainTest.normalizeFinishedTime): Added. It replaces all finished times by 0.1 seconds.
2449         (test_run_test_pause_before_testing):
2450         (test_run_test_set_for_parser_tests):
2451         (test_run_memory_test):
2452         (_test_run_with_json_output):
2453
2454 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
2455
2456         Support new TestExpectations format alongside old one
2457         https://bugs.webkit.org/show_bug.cgi?id=96588
2458
2459         Reviewed by Ojan Vafai.
2460
2461         This patch adds support for actually reading in lines formatted
2462         in the new style, and when we re-serialize/write out the file,
2463         all lines will be written in the new style. Note that reading in
2464         the old style is still supported, and no updates are being made
2465         to the actual TestExpectations files as part of this change.
2466
2467         This change updates most but not all of the unit tests to use
2468         the new syntax. I will update the rest when (or before where
2469         possible) I drop support for the old format.
2470
2471         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2472         (TestExpectationParser):
2473         (TestExpectationParser._tokenize_line):
2474         (TestExpectationParser._tokenize_line_using_new_format):
2475         (TestExpectationLine.to_string):
2476         (TestExpectationLine._format_line):
2477         (TestExpectations):
2478         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2479         (test_parse_warning):
2480         (SkippedTests.test_skipped_entry_dont_exist):
2481         (NewExpectationSyntaxTests.test_warnings):
2482         (RemoveConfigurationsTest.test_remove):
2483         (test_remove_line):
2484         (RebaseliningTest.test_remove):
2485         (RebaseliningTest.test_no_get_rebaselining_failures):
2486         (TestExpectationParserTests.test_tokenize_blank):
2487         (TestExpectationParserTests.test_tokenize_extra_colon):
2488         (TestExpectationParserTests.test_tokenize_missing_equal):
2489         (TestExpectationParserTests.test_tokenize_extra_equal):
2490         (TestExpectationSerializationTests.test_unparsed_to_string):
2491         (TestExpectationSerializationTests.test_unparsed_list_to_string):
2492         (TestExpectationSerializationTests.test_parsed_to_string):
2493         (TestExpectationSerializationTests.test_format_line):
2494         (TestExpectationSerializationTests.test_string_roundtrip):
2495         (TestExpectationSerializationTests.test_list_roundtrip):
2496         (TestExpectationSerializationTests.test_reconstitute_only_these):
2497         (TestExpectationSerializationTests.test_string_whitespace_stripping):
2498         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2499         (LintTest.test_lint_test_files__errors):
2500         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2501         (PrintExpectationsTest.test_basic):
2502         (PrintExpectationsTest.test_multiple):
2503         (PrintExpectationsTest.test_full):
2504         (PrintExpectationsTest.test_exclude):
2505         * Scripts/webkitpy/tool/commands/rebaseline.py:
2506         (RebaselineExpectations.execute):
2507         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2508         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
2509         (test_rebaseline_updates_expectations_file):
2510         (test_rebaseline_does_not_include_overrides):
2511         (test_rebaseline_expectations_noop):
2512         (test_overrides_are_included_correctly):
2513
2514 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
2515
2516         implement first part of support for the new TestExpectations syntax
2517         https://bugs.webkit.org/show_bug.cgi?id=96569
2518
2519         Reviewed by Ryosuke Niwa.
2520
2521         This patch implements support for parsing a line of the new
2522         format for the TestExpectations file and converting it back into
2523         the old format for compatibility. This routine is not yet used
2524         by anything.
2525
2526         The new format is documented at:
2527           http://trac.webkit.org/wiki/TestExpectations
2528
2529         but, in short:
2530
2531           [bugs] [ "[" modifiers "]" ] test_name [ "[" expectations "]" ]
2532
2533         - Comments are indicated with "#" instead of "//"
2534         - If no expectations are specified we default to Skip for
2535           compatibility with the Skipped files (these two changes make
2536           Skipped files a subset of TestExpectations files)
2537
2538         - All of the tokens are now CamelCase instead of ALLCAPS.
2539         - FAIL -> Failure
2540         - IMAGE -> ImageOnlyFailure
2541         - WONTFIX -> WontFix
2542         - modifiers refer to just the platforms and configurations
2543           (release/debug) that the line applies to.
2544         - WontFix, Rebaseline, Slow, and Skip move to the right-hand side as
2545           expectations
2546         - expectations will typically be written out in lexicographic order
2547         - We use webkit.org/b/12345, crbug.com/12345, and Bug(dpranke)
2548           instead of BUGWK12345, BUGCR12345, and BUGDPRANKE.
2549
2550         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2551         (TestExpectationParser):
2552         (TestExpectationParser._tokenize_line_using_new_format):
2553         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2554         (NewExpectationSyntaxTests):
2555         (NewExpectationSyntaxTests.assert_exp):
2556         (NewExpectationSyntaxTests.test_bare_name):
2557         (NewExpectationSyntaxTests.test_bare_name_and_bugs):
2558         (NewExpectationSyntaxTests.test_comments):
2559         (NewExpectationSyntaxTests.test_config_modifiers):
2560         (NewExpectationSyntaxTests.test_unknown_config):
2561         (NewExpectationSyntaxTests.test_unknown_expectation):
2562         (NewExpectationSyntaxTests.test_skip):
2563         (NewExpectationSyntaxTests.test_slow):
2564         (NewExpectationSyntaxTests.test_wontfix):
2565         (NewExpectationSyntaxTests.test_blank_line):
2566         (NewExpectationSyntaxTests.test_warnings):
2567
2568 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
2569
2570         nrwt: replace TEXT, AUDIO, and IMAGE+TEXT with FAIL
2571         https://bugs.webkit.org/show_bug.cgi?id=96845
2572
2573         Reviewed by Ojan Vafai.
2574
2575         In preparation for the new TestExpectations syntax, we replace
2576         all TEXT, IMAGE+TEXT, and AUDIO failures with FAIL. This will
2577         make switching to the new syntax lossless (i.e., we lose
2578         information now, not then).
2579
2580         Note that we can still parse in results.json files that have the
2581         old data for backwards compatibility.
2582         
2583
2584         * Scripts/webkitpy/common/net/resultsjsonparser.py:
2585         (JSONTestResult._failure_types_from_actual_result):
2586         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
2587         (ResultsJSONParserTest):
2588         (test_basic):
2589         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2590         (ResultSummaryTest.test_summarized_results_wontfix):
2591         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2592         (JSONLayoutResultsGenerator):
2593         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2594         (TestExpectations):
2595         (TestExpectations.remove_pixel_failures):
2596         (TestExpectations.has_pixel_failures):
2597         (TestExpectations.suffixes_for_expectations):
2598         (TestExpectations.get_rebaselining_failures):
2599         (TestExpectations.remove_configuration_from_test):
2600         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2601         (assert_bad_expectations):
2602         (BasicTests):
2603         (BasicTests.test_basic):
2604         (MiscTests):
2605         (MiscTests.test_multiple_results):
2606         (MiscTests.test_result_was_expected):
2607         (MiscTests.test_remove_pixel_failures):
2608         (MiscTests.test_suffixes_for_expectations):
2609         (test_get_expectations_string):
2610         (test_parse_warning):
2611         (test_error_on_different_platform):
2612         (test_error_on_different_build_type):
2613         (test_overrides):
2614         (test_overrides__directory):
2615         (test_overrides__duplicate):
2616         (test_pixel_tests_flag):
2617         (test_more_specific_override_resets_skip):
2618         (SkippedTests.test_skipped_file_overrides_expectations):
2619         (SkippedTests.test_skipped_dir_overrides_expectations):
2620         (SkippedTests.test_skipped_file_overrides_overrides):
2621         (SkippedTests.test_skipped_dir_overrides_overrides):
2622         (ExpectationSyntaxTests.test_missing_colon):
2623         (ExpectationSyntaxTests.test_too_many_equals_signs):
2624         (SemanticTests.test_bug_format):
2625         (SemanticTests.test_bad_bugid):
2626         (SemanticTests.test_missing_bugid):
2627         (SemanticTests.test_rebaseline):
2628         (test_missing_file):
2629         (test_more_modifiers):
2630         (test_order_in_file):
2631         (test_macro_overrides):
2632         (RemoveConfigurationsTest.test_remove):
2633         (test_remove_line):
2634         (RebaseliningTest.test_remove):
2635         (TestExpectationSerializationTests.test_serialize_parsed_expectations):
2636         * Scripts/webkitpy/layout_tests/models/test_failures.py:
2637         (determine_result_type):
2638         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2639         (test_test_expectations):
2640         * Scripts/webkitpy/layout_tests/port/test.py:
2641         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2642         (MainTest.test_missing_and_unexpected_results):
2643         (MainTest.test_retrying_and_flaky_tests):
2644         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2645         (TestExpectationsTestCase.test_valid_expectations):
2646         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2647         (PrintExpectationsTest.test_basic):
2648         (PrintExpectationsTest.test_multiple):
2649         (PrintExpectationsTest.test_full):
2650         (PrintExpectationsTest.test_exclude):
2651         (PrintExpectationsTest.test_csv):
2652         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2653         (test_rebaseline_does_not_include_overrides):
2654         (test_overrides_are_included_correctly):
2655
2656 2012-09-19  Dominic Mazzoni  <dmazzoni@google.com>
2657
2658         AX: A few control types are returning the wrong answer for isReadOnly
2659         https://bugs.webkit.org/show_bug.cgi?id=96735
2660
2661         Reviewed by Chris Fleizach.
2662
2663         Exposing isReadOnly in an AccessibilityObject to DumpRenderTree.
2664
2665         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2666         (AccessibilityUIElement::AccessibilityUIElement):
2667         (AccessibilityUIElement::isReadOnlyGetterCallback):
2668         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h:
2669         (AccessibilityUIElement):
2670
2671 2012-09-19  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2672
2673         [WTR] Memory leaks in TestRunner::deliverWebIntent()
2674         https://bugs.webkit.org/show_bug.cgi?id=97111
2675
2676         Reviewed by Kenneth Rohde Christiansen.
2677
2678         Fix memory leaks in deliverWebIntent() by adopting strings
2679         created with WKStringCreateWithUTF8CString().
2680
2681         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2682         (WTR::TestRunner::deliverWebIntent):
2683
2684 2012-09-19  Simon Hausmann  <simon.hausmann@digia.com>
2685
2686         [Qt] Fix incremental builds with all-in-one-files and gccdepends
2687
2688         Reviewed by Tor Arne Vestbø.
2689
2690         Pass -MP to gcc when we use the gcc depends feature, to ensure that implicit rules
2691         are not only created for header files but also for .cpp files. AllInOne.cpp files
2692         include other .cpp files, and when those are removed we need those dummy rules to
2693         avoid a "No rule to make Foo.cpp required by AllInOne.o" error.
2694
2695         * qmake/config.tests/gccdepends/empty.cpp:
2696         (main):
2697         * qmake/config.tests/gccdepends/gccdepends.pro:
2698         * qmake/mkspecs/features/default_pre.prf:
2699
2700 2012-09-19  Rick Byers  <rbyers@chromium.org>
2701
2702         Do touch adjustment on GestureTapDown
2703         https://bugs.webkit.org/show_bug.cgi?id=96677
2704
2705         Reviewed by Antonio Gomes.
2706
2707         Allow radius to be set for GestureTapDown events.
2708         * DumpRenderTree/chromium/TestRunner/EventSender.cpp:
2709         (EventSender::gestureEvent):
2710
2711 2012-09-19  Christophe Dumez  <christophe.dumez@intel.com>
2712
2713         [EFL] EFL's DRT does not support overriding 'WebKitCSSRegionsEnabled' preference
2714         https://bugs.webkit.org/show_bug.cgi?id=97100
2715
2716         Reviewed by Gyuyoung Kim.
2717
2718         EFL's DRT now supports overriding the 'WebKitCSSRegionsEnabled'
2719         preference, in order to match WebKitTestRunner functionality.
2720
2721         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2722         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2723         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2724         (TestRunner::overridePreference):
2725
2726 2012-09-18  Kangil Han  <kangil.han@samsung.com>
2727
2728         [WK2][WTR] CodeGeneratorTestRunner could keep original copyright.
2729         https://bugs.webkit.org/show_bug.cgi?id=96181
2730
2731         Reviewed by Daniel Bates.
2732
2733         This patch enabled derived files, in DerivedSources/InjectedBundle, to keep original copyright.
2734
2735         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2736         (new):
2737         (_parseLicenseBlock):
2738         (_parseLicenseBlockFromFile):
2739         (_defaultLicenseBlock):
2740         (_licenseBlock):
2741         (_generateHeaderFile):
2742         (_generateImplementationFile):
2743
2744 2012-09-18  Byungwoo Lee  <bw80.lee@samsung.com>
2745
2746         Title string should be changed when document.title is set to ''.
2747         https://bugs.webkit.org/show_bug.cgi?id=96793
2748
2749         Reviewed by Kenneth Rohde Christiansen.
2750
2751         Change dump format of dumpTitleChanges more understandable.
2752         Uses single quotation marks for the title string.
2753
2754         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2755         (BlackBerry::WebKit::DumpRenderTree::didReceiveTitleForFrame):
2756         * DumpRenderTree/chromium/WebViewHost.cpp:
2757         (WebViewHost::didReceiveTitle):
2758         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2759         (DumpRenderTreeChrome::onFrameTitleChanged):
2760         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2761         (webViewTitleChanged):
2762         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2763         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
2764         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2765         (WebCore::DumpRenderTree::titleChanged):
2766         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2767         (FrameLoadDelegate::didReceiveTitle):
2768         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
2769         (LayoutWebViewEventHandler::OnReceivedTitleEvent):
2770         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2771         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
2772
2773 2012-09-18  Szilard Ledan  <szledan@inf.u-szeged.hu>
2774
2775         EWS shouldn't sleep if there are new patches in its queue
2776         https://bugs.webkit.org/show_bug.cgi?id=83038
2777
2778         Reviewed by Eric Seidel.
2779
2780         EWS tries to process a security patch. Of course it can't, because the EWS isn't
2781         the member of the security group. But the problem is that after it can't process
2782         the attachment, it says that queue is empty (but it isn't!) and it sleeps 2 minutes
2783         and push the security patch to the end of the queue.
2784         Now it stays in the loop until it finds a patch or the queue gets empty.
2785
2786         * Scripts/webkitpy/tool/commands/queues.py:
2787         (AbstractPatchQueue._next_patch):
2788         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2789         (AbstractPatchQueueTest.test_next_patch):
2790
2791 2012-09-18  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2792
2793         [WK2][WTR] InjectedBundle::booleanForKey() should handle literals effectively
2794         https://bugs.webkit.org/show_bug.cgi?id=97014
2795
2796         Reviewed by Kenneth Rohde Christiansen.
2797
2798         According to http://trac.webkit.org/wiki/EfficientStrings WTF::StringBuilder::appendLiteral() shall
2799         be used for literals rather than WTF::StringBuilder::append().
2800
2801         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2802         (WTR::InjectedBundle::booleanForKey):
2803
2804 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
2805
2806         Update my e-mail address.
2807
2808         * Scripts/webkitpy/common/config/committers.py:
2809
2810 2012-09-18  Andras Becsi  <andras.becsi@digia.com>
2811
2812         Update my e-mail address.
2813
2814         Unreviewed.
2815
2816         * Scripts/webkitpy/common/config/committers.py:
2817
2818 2012-09-18  Andras Becsi  <andras.becsi@digia.com>
2819
2820         [Qt] qt_webkit.pri should not be listed in Tools.pro
2821
2822         Reviewed and rubber-stamped by Simon Hausmann and Tor Arne Vestbø.
2823
2824         Since r128751 the module pri file is auto-generated
2825         but it was still listed in OTHER_FILES.
2826
2827         * Tools.pro: Remove unneeded line.
2828
2829 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
2830
2831         [Qt] Fix build with some versions of the gold linker
2832
2833         Reviewed by Tor Arne Vestbø.
2834
2835         Don't unconditionally pass --no-keep-memory to the linker, some versions might not support it.
2836         Instead run a compile/link test first to see if it works.
2837
2838         * qmake/config.tests/gnuld/gnuld.pro: Added.
2839         * qmake/config.tests/gnuld/main.cpp: Added.
2840         (main):
2841         * qmake/mkspecs/features/unix/default_post.prf:
2842
2843 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
2844
2845         [Qt] Remove forced use of gold.
2846
2847         Reviewed by Tor Arne Vestbø.
2848
2849         The choice of what linker to use with WebKit should be taken by Qt's build system and ideally the same for all
2850         modules of Qt. Then in turn it is usually up to the administrator of the machine. Recent Debian based systems
2851         often offer the automatic use of gold through a symlink and a dpkg-diversion when installing the gold package.
2852
2853         * qmake/mkspecs/features/unix/default_post.prf:
2854
2855 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
2856
2857         [Qt] Prospective Qt/Windows cross-compiling fix
2858
2859         Reviewed by Tor Arne Vestbø.
2860
2861         The win32 scope is not set when cross-compiling from Linux to Windows.
2862
2863         * qmake/mkspecs/features/functions.prf:
2864
2865 2012-09-18  Seokju Kwon  <seokju.kwon@samsung.com>
2866
2867         [EFL] Remove background view on EWebLauncher and MiniBrowser
2868         https://bugs.webkit.org/show_bug.cgi?id=96905
2869
2870         Reviewed by Gyuyoung Kim.
2871
2872         The size of webview was changed after adding url bar.
2873         And the background view is not necessary anymore, since it was used for debugging back in the day.
2874
2875         * EWebLauncher/main.c:
2876         (_ELauncher):
2877         (on_ecore_evas_resize):
2878         (browserCreate):
2879         * MiniBrowser/efl/main.c:
2880         (_MiniBrowser):
2881         (on_ecore_evas_resize):
2882         (browserCreate):
2883
2884 2012-09-18  Sergio Villar Senin  <svillar@igalia.com>
2885
2886         [GTK] run-webkit-tests unable to find TestExpectations for WK2
2887         https://bugs.webkit.org/show_bug.cgi?id=96998
2888
2889         Reviewed by Philippe Normand.
2890
2891         We should look for TestExpectations files in all the locations where
2892         we currently look for Skipped files. This will allow
2893         run-webkit-tests to look for TestExpectations files in
2894         platform/gtk-wk2 and platform/wk2 if the "-2" flag is used.
2895
2896         * Scripts/webkitpy/layout_tests/port/gtk.py:
2897         (GtkPort.expectations_files):
2898
2899 2012-09-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2900
2901         [Qt] Fix build without the QtQuick module
2902
2903         Reviewed by Simon Hausmann.
2904
2905         * qmake/mkspecs/features/features.prf:
2906
2907 2012-09-18  Stephanie Lewis  <slewis@apple.com>
2908
2909         Build fix after http://trac.webkit.org/projects/webkit/changeset/128852.
2910
2911         Unreviewed.
2912
2913         * DumpRenderTree/mac/DumpRenderTree.mm:
2914         (poseAsClass):
2915
2916 2012-09-18  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
2917
2918         Unreviewed update of email addresses for Berlin QtWebKit office.
2919
2920         * Scripts/webkitpy/common/config/committers.py:
2921
2922 2012-09-17  Zan Dobersek  <zandobersek@gmail.com>
2923
2924         [GTK] fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html failing after r128645
2925         https://bugs.webkit.org/show_bug.cgi?id=96899
2926
2927         Reviewed by Martin Robinson.
2928
2929         When overriding the 'WebKitDisplayImageKey' preference, use the
2930         'auto-load-images' property of WebKitWebSettings as the property which
2931         should be updated with the corresponding preference value.
2932
2933         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2934         (resetDefaultsToConsistentValues):
2935         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2936         (TestRunner::overridePreference):
2937
2938 2012-09-17  Pratik Solanki  <psolanki@apple.com>
2939
2940         DumpRenderTree and WebKitTestRunner should compile with -Wundef on Mac
2941         https://bugs.webkit.org/show_bug.cgi?id=96973
2942
2943         Reviewed by Dan Bernstein.
2944
2945         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2946         * WebKitTestRunner/Configurations/Base.xcconfig:
2947         * WebKitTestRunner/PlatformWebView.h: Use #ifdef __OBJC__ and not #if.
2948
2949 2012-09-17  Dirk Pranke  <dpranke@chromium.org>
2950
2951         nrwt: remove "unexpected EOF" warnings
2952         https://bugs.webkit.org/show_bug.cgi?id=96970
2953
2954         Reviewed by Ojan Vafai.
2955
2956         After debugging this a bit, it looks like there aren't any cases
2957         that I can reproduce where a read() of zero indicates something
2958         actually wrong; either it is a prelude to a crash, or a false
2959         negative. So, I'm removing these warnings and adding a comment.
2960
2961         * Scripts/webkitpy/layout_tests/port/server_process.py:
2962         (ServerProcess._wait_for_data_and_update_buffers_using_select):
2963
2964 2012-09-17  Dirk Pranke  <dpranke@chromium.org>
2965
2966         [chromium] ASAN bot is crashing at the end of the run
2967         https://bugs.webkit.org/show_bug.cgi?id=96967
2968
2969         Reviewed by Abhishek Arya.
2970
2971         The ASAN bot is crashing attempting to decode some output into
2972         UTF-8; there's no reason to do this, so let's not do this and
2973         see if something else is going on as well.
2974
2975         * Scripts/webkitpy/layout_tests/port/chromium.py:
2976         (ChromiumPort._get_crash_log):
2977
2978 2012-09-17  Dirk Pranke  <dpranke@chromium.org>
2979
2980         nrwt: --results-directory isn't getting printed properly
2981         https://bugs.webkit.org/show_bug.cgi?id=96965
2982
2983         Reviewed by Ojan Vafai.
2984
2985         options.results_directory isn't actually initialized with the
2986         default values until after we call print_config(), so this
2987         changes things to print the value directly.
2988
2989         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2990         (run):
2991         * Scripts/webkitpy/layout_tests/views/printing.py:
2992         (Printer.print_config):
2993         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2994         (Testprinter.test_print_config):
2995
2996 2012-09-17  Rob Buis  <rbuis@rim.com>
2997
2998         [BlackBerry] Enable VIDEO_TRACK
2999         https://bugs.webkit.org/show_bug.cgi?id=96949
3000
3001         Reviewed by Antonio Gomes.
3002
3003         * Scripts/webkitperl/FeatureList.pm:
3004
3005 2012-09-17  Rick Byers  <rbyers@chromium.org>
3006
3007         Add handling of new GestureTapCancel in DRT
3008
3009         https://bugs.webkit.org/show_bug.cgi?id=96183
3010
3011         Reviewed by Antonio Gomes.
3012
3013         * DumpRenderTree/chromium/TestWebPlugin.cpp:
3014         (TestWebPlugin::handleInputEvent):
3015         * DumpRenderTree/chromium/EventSender.cpp:
3016         (EventSender::gestureTapCancel):
3017
3018 2012-09-17  Philip Rogers  <pdr@google.com>
3019
3020         Teach style checker about preprocessor directive indentation rules
3021         https://bugs.webkit.org/show_bug.cgi?id=96874
3022
3023         Reviewed by Adam Barth.
3024
3025         Preprocessor directives (#ifdef, #include, #define, etc.) should not be indented.
3026         This is not explicit in our style guide but is generally followed in our code.
3027         Searching for violations in our codebase shows these are rarely indented:
3028             #include - indented in 6 files
3029             #ifdef - indented in 0 files
3030             #ifndef - indented in 1 file
3031             #define - indented in 11 files
3032             #if - indented in 7 files
3033
3034         * Scripts/webkitpy/style/checkers/cpp.py:
3035         (check_directive_indentation):
3036
3037             This is the simple test where we look for spaces followed by a #.
3038
3039         (check_style):
3040         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3041
3042             A few tests needed to be modified because they had unintentionally indented
3043             preprocessor directives.
3044
3045         (CppStyleTest.test_build_class.Foo):
3046         (CppStyleTest.test_build_class):
3047         (CppStyleTest.test_build_class.DERIVE_FROM_GOO):
3048         (WebKitStyleTest.test_line_breaking):
3049         (WebKitStyleTest.test_directive_indentation):
3050
3051 2012-09-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3052
3053         [Qt] Auto-generate the module pri file for QtWebKit
3054
3055         Reviewed by Simon Hausmann.
3056
3057         * qmake/qt_webkit.pri: Removed.
3058
3059 2012-09-14  Dirk Pranke  <dpranke@chromium.org>
3060
3061         nrwt: --additional-platform-dir is broken on chromium ports
3062         https://bugs.webkit.org/show_bug.cgi?id=96840
3063
3064         Reviewed by Ojan Vafai.
3065
3066         Looks like I broke this when cleaning things up as part of
3067         adding ML support. Fixing and adding a test.
3068
3069         * Scripts/webkitpy/layout_tests/port/chromium.py:
3070         (ChromiumPort.default_baseline_search_path):
3071         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3072         (ChromiumAndroidPort.default_baseline_search_path):
3073         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3074         (ChromiumLinuxPort.default_baseline_search_path):
3075         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3076         (ChromiumMacPort.__init__):
3077         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3078         (ChromiumWinPort.setup_environ_for_server):
3079         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3080         (test_check_build):
3081         (test_additional_platform_directory):
3082
3083 2012-09-13  Stephanie Lewis  <slewis@apple.com>
3084
3085         mac-future ignores previous platform TestExpectations.
3086         https://bugs.webkit.org/show_bug.cgi?id=96718.
3087
3088         Reviewed by Dirk Pranke.
3089
3090         TestExpectations match an expectation's configuraton against a list of configurations that are 
3091         valid for that port.  That list does not contain mac-future so none of the expectations can be
3092         applied.
3093
3094         * Scripts/webkitpy/layout_tests/port/apple.py:
3095         (ApplePort._generate_all_test_configurations):
3096
3097 2012-09-14  Adam Barth  <abarth@webkit.org>
3098
3099         Remove webkitPostMessage
3100         https://bugs.webkit.org/show_bug.cgi?id=96577
3101
3102         Reviewed by Ojan Vafai.
3103
3104         Add ENABLE_LEGACY_VENDOR_PREFIXES flag.
3105
3106         * Scripts/webkitperl/FeatureList.pm:
3107         * qmake/mkspecs/features/features.pri:
3108
3109 2012-09-14  Alexey Proskuryakov  <ap@apple.com>
3110
3111         [WK2] webarchive/loading/javascript-url-iframe-crash.html fails
3112         https://bugs.webkit.org/show_bug.cgi?id=96817
3113
3114         Reviewed by Kenneth Rohde Christiansen.
3115
3116         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3117         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): This callback
3118         got overlooked when adding logging elsewhere.
3119
3120 2012-09-14  Peter Beverloo  <peter@chromium.org>
3121
3122         [Chromium] Build fix for DumpRenderTree following r128628
3123         https://bugs.webkit.org/show_bug.cgi?id=96808
3124
3125         Reviewed by Tony Chang.
3126
3127         When building DumpRenderTree from the Chromium project, a compile error
3128         shows up because including the header ForwardIOStreamsAndroid.h cannot
3129         be located. TestWebKitAPI does this correctly.
3130
3131         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3132
3133 2012-09-14  Dana Jansens  <danakj@chromium.org>
3134
3135         Change cc-bugs@google.com watchlist to cc-bugs@chromium.org
3136         https://bugs.webkit.org/show_bug.cgi?id=96805
3137
3138         Reviewed by Dirk Pranke.
3139
3140         * Scripts/webkitpy/common/config/committers.py:
3141         * Scripts/webkitpy/common/config/watchlist:
3142
3143 2012-09-14  Peter Beverloo  <peter@chromium.org>
3144
3145         [Chromium] Support the --{in,out,err}-fifo arguments on TestWebKitAPI and webkit_unit_tests
3146         https://bugs.webkit.org/show_bug.cgi?id=96687
3147
3148         Reviewed by Tony Chang.
3149
3150         Android's DumpRenderTree currently supports these arguments, implemented
3151         as part of TestShellAndroid:
3152         http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/chromium/TestShellAndroid.cpp?rev=128496
3153
3154         They're used by the layout test runner to get the STDOUT and STDERR while
3155         a layout test run is in process, which is a safer alternative to parsing
3156         all the logcat output manually. The implementation can be seen here:
3157         http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py?rev=128496#L590
3158
3159         This patch generalizes parsing of and applying the effects of these arguments
3160         so that they can be used for TestWebKitAPI and webkit_unit_tests as well.
3161         After this patch, this will make it possible to pull out the output-reading
3162         code from Android's layout test port and generalize it so it can be re-used
3163         in the new test-runner for the other two test suites.
3164
3165         This has no effect when compiling and running these tests as part of Chromium
3166         code, which has a much more advanced test-runner that does parse complete log
3167         output, but also directly depends on code licensed under Apache 2.
3168
3169         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3170         * DumpRenderTree/chromium/TestShellAndroid.cpp:
3171         (platformInit):
3172         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3173
3174 2012-09-14  Zoltan Horvath  <zoltan@webkit.org>
3175
3176         check-webkit-style should not warn in case of NONCOPYABLE and FAST_ALLOCATED macros
3177         https://bugs.webkit.org/show_bug.cgi?id=96656
3178
3179         Reviewed by Adam Barth.
3180
3181         We should allow to use WTF_MAKE_NONCOPYABLE(ClassName) and WTF_MAKE_FAST_ALLOCATED
3182         macros in 1 line.
3183
3184         * Scripts/webkitpy/style/checkers/cpp.py:
3185         (check_style.definitions):
3186         (check_style): Add rule.
3187         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3188         (WebKitStyleTest.test_line_breaking): Add unittest.
3189
3190 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
3191
3192         WebKitTestRunner needs layoutTestController.dumpDatabaseCallbacks
3193         https://bugs.webkit.org/show_bug.cgi?id=57570
3194
3195         Reviewed by Kenneth Rohde Christiansen.
3196
3197         Implement testRunner.dumpDatabaseCallbacks in WebKitTestRunner
3198         and dump the information expected by the test cases.
3199
3200         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3201         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3202         (WTR::InjectedBundle::beginTesting): Explicitly set the default
3203         database quota.
3204         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3205         (WTR::securityOriginToStr): New convenience function to convert
3206         a security origin to the string expected in test results.
3207         (WTR):
3208         (WTR::InjectedBundlePage::InjectedBundlePage):
3209         (WTR::InjectedBundlePage::didExceedDatabaseQuota):
3210         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota): Minor
3211         refactoring to share code with didExceedDatabaseQuota.
3212         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3213         (InjectedBundlePage):
3214         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3215         (WTR::TestRunner::TestRunner):
3216         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3217         (WTR::TestRunner::dumpDatabaseCallbacks):
3218         (WTR::TestRunner::shouldDumpDatabaseCallbacks):
3219         (TestRunner):
3220
3221 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3222
3223         [Qt] Set force_static_libs_as_shared early enough to be caught by configure
3224
3225         Rubber-stamped by Simon Hausmann.
3226
3227         * qmake/mkspecs/features/default_post.prf:
3228
3229 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3230
3231         [Qt] Remove old cruft from the qmake build system
3232
3233         Rubber-stamped by Simon Hausmann.
3234
3235         * DumpRenderTree/qt/DumpRenderTree.pro:
3236         * qmake/mkspecs/features/default_post.prf:
3237
3238 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3239
3240         [Qt] Enable force_static_libs_as_shared for development
3241
3242         Not enabled for buildbots or production-builds (part of Qt5)
3243
3244         Reviewed by Simon Hausmann.
3245
3246         * qmake/mkspecs/features/default_post.prf:
3247
3248 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3249
3250         [Qt] Make force_static_libs_as_shared work on Mac OS
3251
3252         We had to move a few LIBS += around that were in the wrong place,
3253         and not caught when everything was just linked into the final
3254         QtWebKit library.
3255
3256         Reviewed by Simon Hausmann.
3257
3258         * qmake/mkspecs/features/default_post.prf:
3259         * qmake/mkspecs/features/force_static_libs_as_shared.prf:
3260
3261 2012-09-14  Simon Hausmann  <simon.hausmann@nokia.com>
3262
3263         [Qt] Fix build of WTR on Windows
3264
3265         Reviewed by Tor Arne Vestbø.
3266
3267         WTR/qt/main.cpp includes TestController.h, which lives in just WTR/
3268         With qmake's unix makefile generator as well as with the MingW generator,
3269         the directory where the pro file lives (WTR/) is automatically added to
3270         the include search path, but not so with MSVC. Instead of relying on qmake's
3271         implicit feature here, add WTR/ explicitly to the include search path.
3272
3273         * WebKitTestRunner/Target.pri:
3274
3275 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
3276
3277         WebKitTestRunner needs layoutTestController.setStopProvisionalFrameLoads
3278         https://bugs.webkit.org/show_bug.cgi?id=42691
3279
3280         Reviewed by Kenneth Rohde Christiansen.
3281
3282         Add implementation for testrunner.setStopProvisionalFrameLoads()
3283         in WebKitTestRunner.
3284
3285         Original patch by Alexey Proskuryakov.
3286
3287         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3288         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3289         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
3290         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3291         (WTR::TestRunner::TestRunner):
3292         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3293         (TestRunner):
3294         (WTR::TestRunner::setStopProvisionalFrameLoads):
3295         (WTR::TestRunner::shouldStopProvisionalFrameLoads):
3296
3297 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3298
3299         [Qt] Fix handling of debug/release/debug_and_release/build_all
3300
3301         We now pick up the defaults from Qt, in default_pre (CONFIG already
3302         contains the appropriate values for debug and release). We then let
3303         the command line arguments to qmake, or the project files themselves,
3304         override the configuration, and finally we sanitize the configuration
3305         in default_post.
3306
3307         Reviewed by Simon Hausmann.
3308
3309         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3310         * Scripts/webkitdirs.pm:
3311         (buildQMakeProjects):
3312         * qmake/mkspecs/features/default_post.prf:
3313         * qmake/mkspecs/features/default_pre.prf:
3314         * qmake/mkspecs/features/mac/default_pre.prf:
3315
3316 2012-09-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3317
3318         WebKitTestRunner needs layoutTestController.setTabKeyCyclesThroughElements
3319         https://bugs.webkit.org/show_bug.cgi?id=42687
3320
3321         Reviewed by Kenneth Rohde Christiansen.
3322
3323         Implement testRunner.setTabKeyCyclesThroughElements for
3324         WebKitTestRunner.
3325
3326         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3327         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3328         (WTR::InjectedBundle::beginTesting):
3329         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3330         (WTR::TestRunner::setTabKeyCyclesThroughElements):
3331         (WTR):
3332         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3333         (TestRunner):
3334
3335 2012-09-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3336
3337         EventSendingController::keyDown does not support non-array modifier arguments
3338         https://bugs.webkit.org/show_bug.cgi?id=96727
3339
3340         Reviewed by Kenneth Rohde Christiansen.
3341
3342         Add support for handling a string as modifier argument to
3343         EventSendingController::keyDown.
3344
3345         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3346         (WTR::parseModifierArray):
3347
3348 2012-09-14  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3349
3350         WebKitTestRunner needs layoutTestController.setCustomPolicyDelegate
3351         https://bugs.webkit.org/show_bug.cgi?id=42546
3352
3353         Reviewed by Kenneth Rohde Christiansen.
3354
3355         Exported TestRunner::setCustomPolicyDelegate() method.
3356         Allowed Policy Delegate dumping even if we're not in 'waitUntilDone' mode.
3357
3358         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3359         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3360         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
3361
3362 2012-09-14  Zan Dobersek  <zandobersek@gmail.com>
3363
3364         [GTK] Clear application cache between tests in DumpRenderTree
3365         https://bugs.webkit.org/show_bug.cgi?id=96543
3366
3367         Reviewed by Philippe Normand.
3368
3369         Call the new DumpRenderTreeSupportGtk method to clear application cache
3370         after each test in DumpRenderTree.
3371
3372         Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
3373         as well. It's now being set in XvfbDriver._start so that each driver is assigned
3374         a cache directory that's constructed out of the driver's name and its worker
3375         number. These directories are located in the layout tests results directory.
3376         At least on the builders this ensures a driver-specific empty cache directory
3377         with each test run.
3378
3379         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3380         (runTest):
3381         * Scripts/webkitpy/layout_tests/port/gtk.py:
3382         (GtkPort.setup_environ_for_server):
3383         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
3384         (XvfbDriver._start):
3385
3386 2012-09-14  Simon Hausmann  <simon.hausmann@nokia.com>
3387
3388         [Qt] Fix linking on Windows
3389
3390         Reviewed by Tor Arne Vestbø.
3391
3392         When compiling code _after_ QtWebKit.dll, we need to make sure that the QWEBKIT_EXPORT
3393         macro turns into an import macro, which means QT_MAKEDLL should only be set _up until_
3394         the QtWebKit.dll creation in the build process and be off afterwards. This is done in
3395         win32/default_post.prf using a !contains(QT, webkit): DEFINES += QT_MAKEDLL.
3396
3397         r128450 sanitized the values of QT and PKGCONFIG to only contain the dependencies we
3398         want for QtWebKit.dll, but unfortunately that code was applied to any binary built also
3399         after the module. Therefore QT did never contain webkit anymore and we always passed
3400         QT_MAKEDLL to DEFINES, resulting in QWEBKIT_EXPORT to _not_ turn into an import macro.
3401
3402         This patch introduces a creating_module configuration that is used to
3403         scope the qt/pkgconfig sanitization.
3404
3405         * qmake/mkspecs/features/default_post.prf:
3406
3407 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
3408
3409         [WK2][WKTR] TestRunner is not dumping some frame load callbacks information
3410         https://bugs.webkit.org/show_bug.cgi?id=96740
3411
3412         Reviewed by Kenneth Rohde Christiansen.
3413
3414         Dump information expected by the test cases about the following
3415         frame load callbacks:
3416         "didDisplayInsecureContentForFrame"
3417         "didRunInsecureContentForFrame"
3418         "didDetectXSSForFrame"
3419
3420         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3421         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Print a URL
3422         as expected by test results by calling pathSuitableForTestResult() instead
3423         of printing raw URL.
3424         (WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
3425         (WTR::InjectedBundlePage::didRunInsecureContentForFrame):
3426         (WTR::InjectedBundlePage::didDetectXSSForFrame):
3427
3428 2012-09-14  Peter Beverloo  <peter@chromium.org>
3429
3430         The runtime/unsigned category should be valid in the cpp style-checker.
3431         https://bugs.webkit.org/show_bug.cgi?id=96748
3432
3433         Reviewed by Csaba Osztrogonác.
3434
3435         This is causing the webkitpy tests to fail because it's not listed in the
3436         category array. Furthermore, change an "int" to "long" because it's
3437         throwing a double error in one of the earlier asserts.
3438
3439         * Scripts/webkitpy/style/checkers/cpp.py:
3440         (CppChecker):
3441         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3442         (WebKitStyleTest.test_names):
3443
3444 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3445
3446         Evas_Object* is a ref'ed structure, so tread it as such
3447         https://bugs.webkit.org/show_bug.cgi?id=96659
3448
3449         Reviewed by Adam Barth.
3450
3451         Replace OwnPtr<Evas_Object> with RefPtr.
3452
3453         * DumpRenderTree/efl/ImageDiff.cpp:
3454         (calculateDifference):
3455         (printImageDifferences):
3456         (readImageFromStdin):
3457         (main):
3458
3459 2012-09-14  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3460
3461         Unreviewed, rolling out r128507.
3462         http://trac.webkit.org/changeset/128507
3463         https://bugs.webkit.org/show_bug.cgi?id=96659
3464
3465         Revert. r128507 makes too many crashes in EFL layout test bots.
3466
3467         * DumpRenderTree/efl/ImageDiff.cpp:
3468         (calculateDifference):
3469         (printImageDifferences):
3470         (readImageFromStdin):
3471         (main):
3472
3473 2012-09-13  Kevin Funk  <kevin.funk@kdab.com>
3474
3475         Make compile with both OS(WINCE) and PLATFORM(QT) support
3476         https://bugs.webkit.org/show_bug.cgi?id=95536
3477
3478         Reviewed by Simon Hausmann.
3479
3480         Fix wince support in qmake files
3481
3482         * Tools.pro:
3483         * qmake/mkspecs/features/configure.prf:
3484         * qmake/mkspecs/features/default_post.prf:
3485         * qmake/mkspecs/features/features.prf:
3486         * qmake/mkspecs/features/functions.prf:
3487
3488 2012-09-13  KwangYong Choi  <ky0.choi@samsung.com>
3489
3490         [WK2] Add color picker API support for WebKit2
3491         https://bugs.webkit.org/show_bug.cgi?id=95058
3492
3493         Reviewed by Gyuyoung Kim.
3494
3495         Initialization code for color picker callbacks in UI client.
3496
3497         * MiniBrowser/mac/BrowserWindowController.m:
3498         (-[BrowserWindowController awakeFromNib]):
3499         * MiniBrowser/win/BrowserView.cpp:
3500         (BrowserView::create):
3501         * WebKitTestRunner/TestController.cpp:
3502         (WTR::TestController::createOtherPage):
3503         (WTR::TestController::initialize):
3504
3505 2012-09-13  Yuta Kitamura  <yutak@chromium.org>
3506
3507         Upgrade yutak to reviewer
3508         https://bugs.webkit.org/show_bug.cgi?id=96721
3509
3510         Reviewed by Kent Tamura.
3511
3512         * Scripts/webkitpy/common/config/committers.py:
3513
3514 2012-09-13  Adenilson Cavalcanti  <cavalcantii@gmail.com>
3515
3516         Make the style checker report usage of "unsigned int"
3517         https://bugs.webkit.org/show_bug.cgi?id=96693
3518
3519         Reviewed by Dirk Pranke.
3520
3521         Add a rule to check for uses of unsigned int, as the updated coding style recomends.
3522
3523         * Scripts/webkitpy/style/checkers/cpp.py:
3524         (check_language):
3525
3526 2012-09-13  Philip Rogers  <pdr@google.com>
3527
3528         Add gender-neutral form of webkit-patch land-cowboy
3529         https://bugs.webkit.org/show_bug.cgi?id=96709
3530
3531         Reviewed by Adam Barth.
3532
3533         Add webkit-patch land-cowhand, the confident and courageous form of webkit-patch for everyone.
3534
3535         * Scripts/webkitpy/tool/commands/download.py:
3536         (LandCowhand):
3537
3538 2012-09-13  Seokju Kwon  <seokju.kwon@samsung.com>
3539
3540         [EFL] Remove some parameters in browserCreate()
3541         https://bugs.webkit.org/show_bug.cgi?id=96499
3542
3543         Reviewed by Kenneth Rohde Christiansen.
3544
3545         There are too many parameters in browserCreate(). Lots of it seems like settings from command line argument.
3546         And I have moved some parameters into User_Arguments.
3547
3548         * EWebLauncher/main.c:
3549         (_User_Arguments):
3550         (_ELauncher):
3551         (on_key_down):
3552         (browserCreate):
3553         (findThemePath):
3554         (parseUserArguments):
3555         (main):
3556
3557 2012-09-13  Mark Lam  <mark.lam@apple.com>
3558
3559         Unreviewed. Adding myself to the committers list.
3560
3561         * Scripts/webkitpy/common/config/committers.py:
3562
3563 2012-09-13  Ryosuke Niwa  <rniwa@webkit.org>
3564
3565         run-perf-tests output cryptic error when the config file is missing.
3566         https://bugs.webkit.org/show_bug.cgi?id=96453
3567
3568         Reviewed by Tony Chang.
3569
3570         Add a special error message when a configuration file is missing.
3571
3572         Also update the help message of --source-json-path to signify the fact it specifies
3573         the configuration file on performance tests bots.
3574
3575         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3576         (PerfTestsRunner._parse_args):
3577         (PerfTestsRunner._generate_and_show_results):
3578         (PerfTestsRunner._merge_slave_config_json):
3579         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3580         (_test_run_with_json_output): Make upload to fail by default and assert the result
3581         in the function so that we can return logs instead.
3582         (_test_run_with_json_output.mock_upload_json):
3583         (test_run_with_json_output):
3584         (test_run_with_description):
3585         (test_run_respects_no_results):
3586         (test_run_with_slave_config_json):
3587         (test_run_with_bad_slave_config_json):
3588         (test_run_with_multiple_repositories):
3589
3590 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3591
3592         Evas_Object* is a ref'ed structure, so tread it as such
3593         https://bugs.webkit.org/show_bug.cgi?id=96659
3594
3595         Reviewed by Adam Barth.
3596
3597         Replace OwnPtr<Evas_Object> with RefPtr.
3598
3599         * DumpRenderTree/efl/ImageDiff.cpp:
3600         (calculateDifference):
3601         (printImageDifferences):
3602         (readImageFromStdin):
3603         (main):
3604
3605 2012-09-13  Csaba Osztrogonác  <ossy@webkit.org>
3606
3607         One more unreviewed trivial fix after r128399.
3608
3609         * BuildSlaveSupport/build.webkit.org-config/config.json: Fix URLs of the SVN mirror server.
3610
3611 2012-09-13  Csaba Osztrogonác  <ossy@webkit.org>
3612
3613         Unreviewed trivial fix after r128399.
3614
3615         * BuildSlaveSupport/wait-for-SVN-server.py: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py.
3616         (getLatestSVNRevision):
3617         (waitForSVNRevision):
3618
3619 2012-09-13  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3620
3621         [WK2][WTR] WebKitTestRunner needs testRunner.callShouldCloseOnWebView
3622         https://bugs.webkit.org/show_bug.cgi?id=96366
3623
3624         Reviewed by Anders Carlsson.
3625
3626         Implement testRunner.callShouldCloseOnWebView for WebKitTestRunner
3627         by calling shouldClose() on the FrameLoader.
3628
3629         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3630         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3631         (WTR::TestRunner::callShouldCloseOnWebView):
3632         (WTR):
3633         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3634         (TestRunner):
3635
3636 2012-09-13  Sheriff Bot  <webkit.review.bot@gmail.com>
3637
3638         Unreviewed, rolling out r128453.
3639         http://trac.webkit.org/changeset/128453
3640         https://bugs.webkit.org/show_bug.cgi?id=96681
3641
3642         Having tests use the same appcache directory leads to timeouts
3643         (Requested by zdobersek on #webkit).
3644