cd23f74c505250391ce9a85f8064caec232b588c
[WebKit-https.git] / Tools / ChangeLog
1 2020-03-13  Sergio Villar Senin  <svillar@igalia.com>
2
3         [WebXR] IDLs, stubs and build configuration for WPE
4         https://bugs.webkit.org/show_bug.cgi?id=208702
5
6         Reviewed by Dean Jackson.
7
8         * Scripts/webkitperl/FeatureList.pm: Added WebXR.
9         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Added ENABLE_WEBXR, off by default.
10
11 2020-03-16  Per Arne Vollan  <pvollan@apple.com>
12
13         [Cocoa] Limit set of classes that can be decoded when a preference has changed
14         https://bugs.webkit.org/show_bug.cgi?id=208012
15
16         Reviewed by Brent Fulgham.
17
18         * TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm:
19         (TEST):
20
21 2020-03-16  youenn fablet  <youenn@apple.com>
22
23         Unique origins should not be Potentially Trustworthy
24         https://bugs.webkit.org/show_bug.cgi?id=209049
25
26         Reviewed by Darin Adler.
27
28         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
29         (TestWebKitAPI::TEST_F):
30
31 2020-03-15  Fujii Hironori  <Hironori.Fujii@sony.com>
32
33         KeyedDecoderGeneric fails to allocate Vector while decoding broken data
34         https://bugs.webkit.org/show_bug.cgi?id=207324
35
36         Reviewed by Darin Adler.
37
38         * TestWebKitAPI/Tests/WebCore/KeyedCoding.cpp:
39         (TestWebKitAPI::generateRandomData): Added.
40         (TestWebKitAPI::KeyedCoding.DecodeRandomData): Added a new test decoding random data.
41
42 2020-03-15  Yusuke Suzuki  <ysuzuki@apple.com>
43
44         Should not use variable-length-array (VLA)
45         https://bugs.webkit.org/show_bug.cgi?id=209043
46
47         Reviewed by Mark Lam.
48
49         * ContentExtensionTester/Configurations/Base.xcconfig:
50         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
51
52 2020-03-13  Alex Christensen  <achristensen@webkit.org>
53
54         WKWebView._negotiatedLegacyTLS should be correct after back/forward navigations
55         https://bugs.webkit.org/show_bug.cgi?id=209011
56         <rdar://problem/59370588>
57
58         Reviewed by Youenn Fablet.
59
60         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
61         (TestWebKitAPI::TEST):
62
63 2020-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
64
65         [watchOS] Don’t display empty text suggestions in Quickboard when editing input fields
66         https://bugs.webkit.org/show_bug.cgi?id=209089
67
68         Reviewed by Tim Horton.
69
70         Add an API test for watchOS. Also rename a few occurrences of "Autofill" to "AutoFill", to reflect the official
71         marketing name for the feature.
72
73         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
74         (runUntilReceivesAutoplayEvent):
75
76         Additionally fix the watchOS engineering build for arm64_32, which was failing due to comparisons between 64-bit
77         and 32-bit integers. This is because this function took a `WKAutoplayEvent` (a 32-bit integer), but compared
78         against the `_WKAutoplayEvent` type (an NSInteger that is 64 bits on this architecture). There didn't seem to
79         be any compelling reason to compare against different types here (especially since we only set
80         `receivedAutoplayEvent` under the Objective-C delegate method that provides a `_WKAutoplayEvent`), so I changed
81         these all to be `_WKAutoplayEvent`.
82
83         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
84         (-[AutoFillTestView _autofillInputView]):
85         (-[AutoFillTestView textInputHasAutoFillContext]):
86         (TestWebKitAPI::TEST):
87         (-[AutofillTestView initWithFrame:]): Deleted.
88         (-[AutofillTestView _autofillInputView]): Deleted.
89         (-[AutofillTestView textInputHasAutofillContext]): Deleted.
90         * TestWebKitAPI/ios/UIKitSPI.h:
91
92 2020-03-13  Chris Dumez  <cdumez@apple.com>
93
94         Unreviewed, reverting r256232.
95
96         Caused ResizeObserver tests to become flaky
97
98         Reverted changeset:
99
100         "[DRT] InternalSettingsGenerated::resetToConsistentState() may
101         override TestOptions"
102         https://bugs.webkit.org/show_bug.cgi?id=207481
103         https://trac.webkit.org/changeset/256232
104
105 2020-03-13  Kate Cheney  <katherine_cheney@apple.com>
106
107         [ iOS and Mac wk2 ] http/tests/in-app-browser-privacy/ tests failing
108         https://bugs.webkit.org/show_bug.cgi?id=209016
109         <rdar://problem/60329530> 
110
111         Reviewed by Chris Dumez.
112
113         Re-initialize the app-bound domains when the correct
114         TestOptions parameter is set.
115
116         * WebKitTestRunner/TestController.cpp:
117         (WTR::TestController::createWebViewWithOptions):
118         (WTR::TestController::reinitializeAppBoundDomains):
119         * WebKitTestRunner/TestController.h:
120
121 2020-03-13  Kate Cheney  <katherine_cheney@apple.com>
122
123         Report all third party loads on a per-page basis
124         https://bugs.webkit.org/show_bug.cgi?id=209032
125         <rdar://problem/60397323>
126
127         Reviewed by Chris Dumez.
128
129         Mostly naming updates to reflect the change in use for this SPI call.
130         It now returns all loaded third party domains, not just prevalent ones.
131
132         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
133         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
134         (WTR::InjectedBundle::didReceiveMessageToPage):
135         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
136         (WTR::TestRunner::getLoadedThirdPartyDomains):
137         (WTR::TestRunner::callDidReceiveLoadedThirdPartyDomainsCallback):
138         (WTR::TestRunner::getPrevalentDomains): Deleted.
139         (WTR::TestRunner::callDidReceivePrevalentDomainsCallback): Deleted.
140         * WebKitTestRunner/InjectedBundle/TestRunner.h:
141         * WebKitTestRunner/TestController.cpp:
142         (WTR::TestController::resetStateToConsistentValues):
143         (WTR::TestController::getLoadedThirdPartyDomains):
144         (WTR::TestController::clearLoadedThirdPartyDomains):
145         (WTR::TestController::getPrevalentDomains): Deleted.
146         (WTR::TestController::clearPrevalentDomains): Deleted.
147         * WebKitTestRunner/TestController.h:
148         * WebKitTestRunner/TestInvocation.cpp:
149         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
150         (WTR::TestInvocation::didReceiveLoadedThirdPartyDomains):
151         (WTR::TestInvocation::didReceivePrevalentDomains): Deleted.
152         * WebKitTestRunner/TestInvocation.h:
153         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
154         (WTR::TestController::getLoadedThirdPartyDomains):
155         (WTR::TestController::clearLoadedThirdPartyDomains):
156         (WTR::TestController::getPrevalentDomains): Deleted.
157         (WTR::TestController::clearPrevalentDomains): Deleted.
158
159 2020-03-13  Aakash Jain  <aakash_jain@apple.com>
160
161         [ews] run FindModifiedChangeLogs early in the build
162         https://bugs.webkit.org/show_bug.cgi?id=209060
163
164         Reviewed by Jonathan Bedard.
165
166         * BuildSlaveSupport/ews-build/factories.py:
167         * BuildSlaveSupport/ews-build/factories_unittest.py: Updated unit-test.
168
169 2020-03-13  Diego Pino Garcia  <dpino@igalia.com>
170
171         [GTK] Add EWS testers to run GTK layout tests
172         https://bugs.webkit.org/show_bug.cgi?id=207648
173
174         Reviewed by Carlos Alberto Lopez Perez and Aakash Jain.
175
176         Queue 'GTK-Webkit2-EWS' was renamed to 'GTK-Build-EWS'.
177         A new queue, named 'GTK-WK2-Tests-EWS', was added for WK2
178         tests (layout tests).
179
180         * BuildSlaveSupport/ews-build/config.json: Added new queue for
181         WK2 tests.
182         * BuildSlaveSupport/ews-build/factories.py:
183         (GTKTestsFactory):
184         * BuildSlaveSupport/ews-build/factories_unittest.py:
185         (TestCommitQueueFactory.test_commit_queue_factory):
186         (TestGTKFactory): Added unit-test.
187         (TestGTKFactory.test_gtk_factory):
188         * BuildSlaveSupport/ews-build/loadConfig.py:
189         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
190         (TagsForBuilderTest.test_getTagsForBuilder):
191
192 2020-03-13  Aakash Jain  <aakash_jain@apple.com>
193
194         Add API endpoint in EWS django app to provide patch status in json format
195         https://bugs.webkit.org/show_bug.cgi?id=208940
196
197         Reviewed by Jonathan Bedard.
198
199         * BuildSlaveSupport/ews-app/ews/urls.py: Added url for new api endpoint.
200         * BuildSlaveSupport/ews-app/ews/views/status.py: Added.
201
202 2020-03-13  Kate Cheney  <katherine_cheney@apple.com>
203
204         WebKit2UseRemoteLayerTreeDrawingArea should be reset to NO between layout tests
205         https://bugs.webkit.org/show_bug.cgi?id=209055
206         <rdar://problem/60272692>
207
208         Reviewed by Simon Fraser.
209
210         Now that WebKitTestRunner has a bundleID, its' user default values
211         persist between tests. This patch resets WebKit2UseRemoteLayerTreeDrawingArea
212         to NO before running tests. It will be set to YES in PlatformWebView
213         if specified by the test.
214
215         * WebKitTestRunner/mac/main.mm:
216         (setDefaultsToConsistentValuesForTesting):
217
218 2020-03-13  Konstantin Tokarev  <annulen@yandex.ru>
219
220         [CMake] Eleminate mismatches between Find* module names and variables they set
221         https://bugs.webkit.org/show_bug.cgi?id=208948
222
223         Reviewed by Michael Catanzaro.
224
225         * wpe/backends/CMakeLists.txt:
226
227 2020-03-13  Aakash Jain  <aakash_jain@apple.com>
228
229         [ews-app] reduce logging
230         https://bugs.webkit.org/show_bug.cgi?id=209062
231
232         Reviewed by Jonathan Bedard.
233
234         * BuildSlaveSupport/ews-app/ews/common/bugzilla.py:
235         (BugzillaBeautifulSoup.authenticate):
236         (BugzillaBeautifulSoup._load_query):
237
238 2020-03-13  Ryosuke Niwa  <rniwa@webkit.org>
239
240         Crash in TextIterator::node via TextManipulationController::replace
241         https://bugs.webkit.org/show_bug.cgi?id=209048
242
243         Reviewed by Wenson Hsieh.
244
245         Added a regression test.
246
247         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
248         (TextManipulation.CompleteTextManipulationShouldReplaceContentsAroundParagraphWithJustImage):
249
250 2020-03-13  Saam Barati  <sbarati@apple.com>
251
252         Pull in JS tests from "Internal" when there are "Internal" tests in an adjacent directory
253         https://bugs.webkit.org/show_bug.cgi?id=209038
254
255         Reviewed by Keith Miller.
256
257         This allows us to automatically pull in some tests that are in non open sourced Apple
258         checkouts.
259
260         * Scripts/run-javascriptcore-tests:
261         (runJSCStressTests):
262
263 2020-03-12  Ryosuke Niwa  <rniwa@webkit.org>
264
265         Crash in TextManipulationController::replace
266         https://bugs.webkit.org/show_bug.cgi?id=209021
267
268         Reviewed by Wenson Hsieh.
269
270         Added a regression test.
271
272         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
273         (TextManipulation.CompleteTextManipulationShouldReplaceContentFollowedAfterImageInCSSTable):
274
275 2020-03-12  Per Arne Vollan  <pvollan@apple.com>
276
277         [macOS] _AXSApplicationAccessibilityEnabled should not be called
278         https://bugs.webkit.org/show_bug.cgi?id=208953
279
280         Reviewed by Brent Fulgham.
281
282         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
283
284 2020-03-12  Kate Cheney  <katherine_cheney@apple.com>
285
286         Resource load statistics data summary should return all third party data
287         https://bugs.webkit.org/show_bug.cgi?id=209000
288         <rdar://problem/60348306>
289
290         Reviewed by John Wilander.
291
292         Marked only 2 of 3 domains prevalent in data summary tests to ensure
293         the call returns all third parties, not just prevalent ones.
294         Added a more aggressive check for the size of the array at the
295         beginning of the test to ensure the array is still returning 3 values. 
296         Also removed the ASSERT statements as they seem to cause timeouts (not
297         clear crashes) when they are not true, which is hard to debug.
298         If these values are nil, the test will fail in the EXPECT_WK_STREQ
299         checks, we don't need ASSERT statements.
300
301         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
302         (TEST):
303
304 2020-03-12  Jonathan Bedard  <jbedard@apple.com>
305
306         resultsdpy: Add script to run local instance
307         https://bugs.webkit.org/show_bug.cgi?id=208746
308
309         Rubber-stamped by Aakash Jain.
310
311         * resultsdbpy/resultsdbpy/example: Added.
312         * resultsdbpy/resultsdbpy/example/__init__.py: Added.
313         * resultsdbpy/resultsdbpy/example/environment.py: Added.
314         (Environment): Organize environment variables used by results database.
315         (ModelFromEnvironment): Construct the database model from the environment.
316         (main): Create and drop tables, if required.
317         * resultsdbpy/resultsdbpy/example/main.py: Added.
318         (health): Web-server health check.
319         (handle_errors):
320         (main): Run results database web-server.
321         * resultsdbpy/resultsdbpy/example/worker.py: Added.
322         (main): Asynchronously process uploaded results.
323         * resultsdbpy/resultsdbpy/run: Added.
324
325 2020-03-12  Wenson Hsieh  <wenson_hsieh@apple.com>
326
327         run-webkit-tests --use-gpu-process should enable GPU Process for canvas
328         https://bugs.webkit.org/show_bug.cgi?id=209004
329
330         Reviewed by Tim Horton.
331
332         Add "RenderCanvasInGPUProcessEnabled" to the list of internal features that should be enabled when
333         `use_gpu_process` is specified.
334
335         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
336         (parse_args):
337
338 2020-03-12  Matt Lewis  <jlewis3@apple.com>
339
340         Make flatpack import for run-webkit-tests only happen on linux systems
341         https://bugs.webkit.org/show_bug.cgi?id=208954
342
343         Reviewed by Philippe Normand.
344
345         * Scripts/run-webkit-tests: Added an if statement to find the system platform
346         to determine if we need the flatpackutils import. 
347
348 2020-03-12  Alex Christensen  <achristensen@webkit.org>
349
350         WKWebView.hasOnlySecureContent should be correct after back/forward navigations
351         https://bugs.webkit.org/show_bug.cgi?id=207609
352
353         Reviewed by Ryosuke Niwa.
354
355         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
356         (TestWebKitAPI::TEST):
357
358 2020-03-12  Daniel Bates  <dabates@apple.com>
359
360         FocusController::setFocusedElement() should tell client of refocused element
361         https://bugs.webkit.org/show_bug.cgi?id=208880
362
363         Reviewed by Wenson Hsieh.
364
365         Adds a test to ensure that calling -selectPositionAtPoint on an already focused element tries
366         to start an input session. Currently, it does not even try.
367
368         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
369         (TEST):
370
371 2020-03-12  Michael Catanzaro  <mcatanzaro@gnome.org>
372
373         [GTK] Use #!/usr/bin/python3 shebang to run generate-gtkdoc
374         https://bugs.webkit.org/show_bug.cgi?id=208970
375
376         Reviewed by Daniel Bates.
377
378         Fedora and Ubuntu are both patching generate-gtkdoc to use #!/usr/bin/python3 rather than
379         #!/usr/bin/env python.
380
381         #!/usr/bin/env and /usr/bin/python are both banned in Fedora packages. I guess Ubuntu
382         probably has similar rules.
383
384         Note this is the only script that attempts to use /usr/bin/python in tarball builds.
385         Everything else that does so is probably only used by webkit-build.
386
387         https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_multiple_python_runtimes
388
389         * gtkdoc/generate-gtkdoc:
390
391 2020-03-11  Jiewen Tan  <jiewen_tan@apple.com>
392
393         [WebAuthn] Formalize the Keychain schema
394         https://bugs.webkit.org/show_bug.cgi?id=183533
395         <rdar://problem/43347926>
396
397         Reviewed by Brent Fulgham.
398
399         Modifies the test infra to use Credential ID as the unique identifier for a credential instead of
400         the original combination of RP ID and user handle.
401
402         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
403         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
404         (WTR::TestRunner::cleanUpKeychain):
405         (WTR::TestRunner::keyExistsInKeychain):
406         * WebKitTestRunner/InjectedBundle/TestRunner.h:
407         * WebKitTestRunner/TestController.h:
408         * WebKitTestRunner/TestInvocation.cpp:
409         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
410         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
411         (WTR::TestController::cleanUpKeychain):
412         (WTR::TestController::keyExistsInKeychain):
413
414 2020-03-11  Keith Miller  <keith_miller@apple.com>
415
416         Test262-runner should always consider crashes as new failures
417         https://bugs.webkit.org/show_bug.cgi?id=208943
418
419         Reviewed by Yusuke Suzuki.
420
421         Right now the runner will consider crashes with no output as passes, which is obviously bad.
422         Since we should never crash on a conformance test we should consider a crash as a new failure
423         100% of the time.
424
425         * Scripts/test262/Runner.pm:
426         (processFile):
427         (runTest):
428         (processResult):
429
430 2020-03-11  Chris Dumez  <cdumez@apple.com>
431
432         Assertion hit under WebPageProxy::suspendCurrentPageIfPossible() when bypassing certificate warning page
433         https://bugs.webkit.org/show_bug.cgi?id=208927
434         <rdar://problem/55448331>
435
436         Reviewed by Alex Christensen.
437
438         Add API test coverage.
439
440         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
441
442 2020-03-11  Diego Pino Garcia  <dpino@igalia.com>
443
444         [GTK] Switch EWS api-gtk bot from buildAndTest to testOnly
445         https://bugs.webkit.org/show_bug.cgi?id=208860
446
447         Reviewed by Carlos Alberto Lopez Perez.
448
449         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
450         (StatusBubble): Added 'api-gtk'.
451         * BuildSlaveSupport/ews-build/config.json:
452         * BuildSlaveSupport/ews-build/factories.py:
453         (BuildFactory.__init__): Call InstallGTKDependencies() if platform is
454         GTK.
455         (TestFactory.__init__): Call InstallGTKDependencies() if platform is
456         GTK.
457         (GTKBuildFactory):
458         (GTKBuildFactory.__init__): Deleted.
459         (GTKBuildAndTestFactory): Deleted.
460         (GTKBuildAndTestFactory.__init__): Deleted.
461         (GTKAPIBuildAndTestFactory): Deleted.
462         * BuildSlaveSupport/ews-build/loadConfig.py:
463
464 2020-03-11  Aakash Jain  <aakash_jain@apple.com>
465
466         [ews] Add unit test to prevent multiple schedulers for a builder.
467         https://bugs.webkit.org/show_bug.cgi?id=208917
468
469         Reviewed by Carlos Alberto Lopez Perez.
470
471         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
472         (ConfigDotJSONTest.test_multiple_scheduers_for_builder): Added unit test.
473         (TagsForBuilderTest): Fixed a typo.
474
475 2020-03-11 Philippe Normand  <pnormand@igalia.com>
476
477         [GTK] Failing API tests under the Flatpak SDK environment
478         https://bugs.webkit.org/show_bug.cgi?id=208871
479
480         Reviewed by Michael Catanzaro.
481
482         The load-failed signal callback should return a boolean result,
483         otherwise we enter in unknown territory depending on how the
484         toolchain compiles this, possibly triggering bad behavior (with
485         GCC 9.2 from the Flatpak SDK) or not caring at all (with current
486         GCC toolchain on buildbots).
487
488         Patch suggested by Michael Catanzaro.
489
490         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
491         (loadFailedCallback):
492
493 2020-03-10  Don Olmstead  <don.olmstead@sony.com>
494
495         Sync FeatureList.pm with CMake definitions
496         https://bugs.webkit.org/show_bug.cgi?id=208866
497
498         Reviewed by Michael Catanzaro.
499
500         * Scripts/webkitperl/FeatureList.pm:
501
502 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
503
504         [ews] Add unit tests for commit queue factory
505         https://bugs.webkit.org/show_bug.cgi?id=208862
506
507         Reviewed by Jonathan Bedard.
508
509         * BuildSlaveSupport/ews-build/factories_unittest.py:
510         (TestCommitQueueFactory):
511         (TestCommitQueueFactory.test_commit_queue_factory): Added unit-test for commit-queue factory.
512
513 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
514
515         [ews-app] Status bubble should only display important messages in pop-over - part 3
516         https://bugs.webkit.org/show_bug.cgi?id=208865
517
518         Reviewed by Jonathan Bedard.
519
520         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
521         (StatusBubble): Added more strings to STEPS_TO_HIDE.
522
523 2020-03-10  Lauro Moura  <lmoura@igalia.com>
524
525         [WPE] MiniBrowser: Close child WebViews when exiting
526         https://bugs.webkit.org/show_bug.cgi?id=208689
527
528         Reviewed by Carlos Garcia Campos.
529
530         Store created views so we can release them before exiting.
531
532         * MiniBrowser/wpe/main.cpp:
533         (webViewClose):
534         (createWebView):
535         (main):
536
537 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
538
539         Add ValidateCommiterAndReviewer and ValidateChangeLogAndReviewer build steps in commit-queue
540         https://bugs.webkit.org/show_bug.cgi?id=208861
541
542         Reviewed by Jonathan Bedard.
543
544         * BuildSlaveSupport/ews-build/factories.py:
545         (Factory.__init__): Remove verifycqplus parameter.
546         (CommitQueueFactory): Inherit from factory.BuildFactory base class instead of custom Factory class.
547         (CommitQueueFactory.__init__): Add required build steps, especially ValidateCommiterAndReviewer, 
548         UpdateWorkingDirectory and ValidateChangeLogAndReviewer.
549
550 2020-03-10  Philippe Normand  <pnormand@igalia.com>
551
552         [GTK] API favicon test flaky timeouts
553         https://bugs.webkit.org/show_bug.cgi?id=208189
554
555         Reviewed by Carlos Garcia Campos.
556
557         Sometimes the favicon changes already during the load. Keeping
558         track of it in the WebView favicon property notification handler
559         gets us rid of the race.
560
561         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
562         (testFaviconDatabaseGetFavicon):
563
564 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
565
566         Generate commit-queue status bubble from new EWS
567         https://bugs.webkit.org/show_bug.cgi?id=208811
568
569         Reviewed by Jonathan Bedard.
570
571         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
572         (StatusBubble._build_bubbles_for_patch):
573
574 2020-03-09  Don Olmstead  <don.olmstead@sony.com>
575
576         Remove obsolete feature flags
577         https://bugs.webkit.org/show_bug.cgi?id=208830
578
579         Reviewed by Alex Christensen.
580
581         Remove ENABLE_CUSTOM_SCHEME_HANDLER and ENABLE_MAC_VIDEO_TOOLBOX since they
582         are no longer used.
583
584         Also remove ENABLE_POINTER_EVENTS since the FeaturesDefines.xcconfig was not modified
585         when the compilation flag was removed in r258148.
586
587         Remove ENABLE_ACCELERATED_OVERFLOW_SCROLLING, ENABLE_CSS_IMAGE_ORIENTATION,
588         ENABLE_CUSTOM_SCHEME_HANDLER, and ENABLE_FETCH_API from FeatureList.pm.
589
590         * Scripts/webkitperl/FeatureList.pm:
591         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
592
593 2020-03-09  Kate Cheney  <katherine_cheney@apple.com>
594
595         WebKitTestRunner bundleID should not be cleared before every test
596         https://bugs.webkit.org/show_bug.cgi?id=208823
597         <rdar://problem/60204539>
598
599         Reviewed by Per Arne Vollan.
600
601         This is causing test failures for layout tests which rely on the Info.plist 
602         bundle identifier (not the one set via the override method).
603
604         * WebKitTestRunner/TestController.cpp:
605         (WTR::TestController::createWebViewWithOptions):
606         (WTR::TestController::ensureViewSupportsOptionsForTest):
607         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
608
609 2020-03-09  Per Arne Vollan  <pvollan@apple.com>
610
611         [macOS] Notification observer is not removed
612         https://bugs.webkit.org/show_bug.cgi?id=208834
613
614         Reviewed by Tim Horton.
615
616         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
617         * TestWebKitAPI/Tests/WebKit/EnableAccessibility.mm: Added.
618         (TEST):
619
620 2020-03-06  Brian Burg  <bburg@apple.com>
621
622         upload.py gets confused by git-svn checkouts, unable to upload test results from my desk build
623         https://bugs.webkit.org/show_bug.cgi?id=208729
624         <rdar://problem/60105447>
625
626         Reviewed by Jonathan Bedard.
627
628         Improve upload.py to look for the svn branch and revision for the 'webkit'
629         project and prefer those to the git equivalents (eg, prefer trunk/rNNNNN to master/<hash>).
630
631         * Scripts/webkitpy/common/checkout/scm/git.py:
632         (Git):
633         (Git.git_svn_id_regexp):
634         (Git._field_from_git_svn_id):
635         (Git.svn_revision):
636         (Git.svn_branch):
637         (Git.svn_url):
638         (Git.native_branch):
639         Refactor svn revision, branch, url to use the same regexp and helper code.
640
641         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
642         (StubRepository.svn_branch):
643         Expose a stub since this is used unconditionally by Port.commits_for_upload.
644
645         * Scripts/webkitpy/common/checkout/scm/svn.py:
646         (SVN.svn_branch):
647         (SVN.native_revision):
648         (SVN):
649         (SVN.native_branch):
650         Refactor so the actual implementation is contained in svn_revision / svn_branch.
651         The native_* methods call out to the SVN equivalents since this is an SVN repository.
652
653         * Scripts/webkitpy/port/base.py:
654         (Port.commits_for_upload):
655         Add special git-svn handling for the WebKit repository so that SVN branch and revision
656         is preferred over the git equivalents.
657
658 2020-03-09  Antoine Quint  <graouts@apple.com>
659
660         TestWebKitAPI fails to build on watchOS
661         https://bugs.webkit.org/show_bug.cgi?id=208820
662
663         Reviewed by Tim Horton.
664
665         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
666
667 2020-03-09  Jonathan Bedard  <jbedard@apple.com>
668
669         resultsdbpy: Add tool to manage resultsdbpy container
670         https://bugs.webkit.org/show_bug.cgi?id=208743
671
672         Rubber-stamped by Aakash Jain.
673
674         Add tool to start, stop and restart the resultsdbpy Docker container.
675
676         * resultsdbpy/resultsdbpy/container: Added.
677
678 2020-03-09  Carlos Garcia Campos  <cgarcia@igalia.com>
679
680         [GTK][WPE] Surrounding text for input methods should not be limited to the current paragraph
681         https://bugs.webkit.org/show_bug.cgi?id=208706
682
683         Reviewed by Žan Doberšek.
684
685         Add test case to check surrounding text in multiline context.
686
687         * TestWebKitAPI/Tests/WebKitGLib/TestInputMethodContext.cpp:
688         (testWebKitInputMethodContextSurrounding):
689
690 2020-03-08  Per Arne Vollan  <pvollan@apple.com>
691
692         [iOS] Mapping to UTI from tag and tag class should be performed in the UI process
693         https://bugs.webkit.org/show_bug.cgi?id=208783
694
695         Reviewed by Brent Fulgham.
696
697         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
698
699 2020-03-07  Ross Kirsling  <ross.kirsling@sony.com>
700
701         Replace the use of term "rollout" to "revert" in various tools
702         https://bugs.webkit.org/show_bug.cgi?id=208775
703
704         Reviewed by Ryosuke Niwa.
705
706         See this webkit-dev thread for the originating discussion:
707         https://lists.webkit.org/pipermail/webkit-dev/2020-March/031132.html
708
709         'rollout' is a confusing term to anyone unacquainted with WebKit;
710         consensus seems to be that 'revert' would be the best replacement (as opposed to 'rollback').
711
712         Given the long legacy of this term within WebKit, it's important to deprecate and not remove 'rollout' commands.
713         As such, this patch aims to make 'revert' the preferred term everywhere without making 'rollout' fail.
714
715         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js:
716         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
717         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
718         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
719         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/trac_unittests.js:
720         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
721         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
722         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
723         * BuildSlaveSupport/ews-build/steps.py:
724         * BuildSlaveSupport/ews-build/steps_unittest.py:
725         * Scripts/webkit-tools-completion.sh:
726         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
727         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
728         * Scripts/webkitpy/common/checkout/scm/svn.py:
729         * Scripts/webkitpy/common/net/bugzilla/attachment.py:
730         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
731         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
732         * Scripts/webkitpy/tool/bot/feeders.py:
733         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
734         * Scripts/webkitpy/tool/bot/irc_command.py:
735         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
736         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
737         * Scripts/webkitpy/tool/bot/sheriff.py:
738         * Scripts/webkitpy/tool/commands/download.py:
739         * Scripts/webkitpy/tool/commands/download_unittest.py:
740         * Scripts/webkitpy/tool/commands/newcommitbot.py:
741         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
742         * Scripts/webkitpy/tool/commands/queues_unittest.py:
743         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
744         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
745         * Scripts/webkitpy/tool/steps/__init__.py:
746         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
747         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
748         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
749         * Scripts/webkitpy/tool/steps/reopenbugafterrevert.py: Renamed from Tools/Scripts/webkitpy/tool/steps/reopenbugafterrollout.py.
750
751 2020-03-07  David Quesada  <david_quesada@apple.com>
752
753         Crash in -[_WKRemoteObjectRegistry _invokeMethod:] block when calling a reply block after the web view has deallocated
754         https://bugs.webkit.org/show_bug.cgi?id=208781
755         rdar://problem/60061016
756
757         Reviewed by Alex Christensen.
758
759         Add a test that recreates the conditions of this crash:
760         - Send a message from the injected bundle to the UI process that contains a reply block.
761         - Hold a reference to the reply block.
762         - Let the web view deallocate.
763         - Call the block, and expect not to crash.
764
765         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
766         (localObjectInterface):
767         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
768         (-[LocalObject doSomethingWithCompletionHandler:]):
769         (TEST):
770         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
771         (-[RemoteObjectRegistryPlugIn callUIProcessMethodWithReplyBlock]):
772
773 2020-03-07  Ryosuke Niwa  <rniwa@webkit.org>
774
775         TextManipulationController should work with ARIA labels
776         https://bugs.webkit.org/show_bug.cgi?id=208759
777
778         Reviewed by Wenson Hsieh.
779
780         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
781         (TextManipulation.StartTextManipulationFindAttributeContent): Added.
782         (TextManipulation.CompleteTextManipulationShouldPreserveOrderOfBlockImage): Updated
783         the expected number of tokens for the first item as the very first image is correctly
784         detected per the code change. 
785         (TextManipulation.CompleteTextManipulationShouldReplaceAttributeContent): Added.
786
787 2020-03-07  Alex Christensen  <achristensen@webkit.org>
788
789         Regression r258042: Failing API test TestWebKitAPI.URLSchemeHandler.Frames
790         https://bugs.webkit.org/show_bug.cgi?id=208767
791
792         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
793         The frameID of the main frame before loading is only 0 on Mac right now.
794         The test is still good because it validates that execution works in the main frame before loading.
795
796 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
797
798         [ews] commit queue is not skipping layout tests for rollout patches
799         https://bugs.webkit.org/show_bug.cgi?id=208716
800
801         Unreviewed minor fix.
802
803         * BuildSlaveSupport/ews-build/steps.py:
804         (RunWebKitTests.doStepIf):
805         (RunWebKit1Tests.doStepIf): Moved to base class RunWebKitTests.
806         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
807
808 2020-03-05  Sam Weinig  <weinig@apple.com>
809
810         Move JavaScriptCore related feature defines from FeatureDefines.xcconfig to PlatformEnableCocoa.h
811         https://bugs.webkit.org/show_bug.cgi?id=207436
812         <rdar://problem/59296762>
813
814         Reviewed by Darin Adler.
815
816         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
817         Remove JSC related defines.
818
819 2020-03-07  Chris Fleizach  <cfleizach@apple.com>
820
821         AX: Provide a way to run tests in isolated tree mode
822         https://bugs.webkit.org/show_bug.cgi?id=208629
823         <rdar://problem/60075583>
824
825         Reviewed by Ryosuke Niwa.
826
827         Provide the ability to run tests for accessibility in the isolated tree mode.
828         This sends a flag over to the injected bundle which calls the right HIServices override so that
829         the system thinks it is in isolated mode.
830
831         * Scripts/compare-webkit-configurations:
832         (flag_for_comparison):
833         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
834         (parse_args):
835         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
836         (parse_args):
837         * Scripts/webkitpy/port/driver.py:
838         (Driver.cmd_line):
839         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
840         (WTR::AccessibilityController::AccessibilityController):
841         (WTR::AccessibilityController::setAccessibilityIsolatedTreeMode):
842         (WTR::AccessibilityController::updateIsolatedTreeMode):
843         (WTR::AccessibilityController::executeOnAXThreadIfPossible):
844         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
845         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
846         (WTR::InjectedBundle::didReceiveMessageToPage):
847         (WTR::InjectedBundle::beginTesting):
848         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
849         * WebKitTestRunner/Options.cpp:
850         (WTR::handleOptionAccessibilityIsolatedTreeMode):
851         (WTR::OptionsHandler::OptionsHandler):
852         * WebKitTestRunner/Options.h:
853         * WebKitTestRunner/TestController.cpp:
854         (WTR::TestController::initialize):
855         (WTR::TestController::resetPreferencesToConsistentValues):
856         (WTR::TestController::resetStateToConsistentValues):
857         * WebKitTestRunner/TestController.h:
858         (WTR::TestController::accessibilityIsolatedTreeMode const):
859
860 2020-03-06  Per Arne Vollan  <pvollan@apple.com>
861
862         [Cocoa] Re-enable CFPrefs direct mode
863         https://bugs.webkit.org/show_bug.cgi?id=208690
864
865         Reviewed by Brent Fulgham.
866
867         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
868         * TestWebKitAPI/Tests/WebKit/GrantAccessToPreferencesService.mm: Added.
869         (TEST):
870         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
871         (TestWebKitAPI::TEST):
872
873 2020-03-06  Kate Cheney  <katherine_cheney@apple.com>
874
875         UIProcess needs mechanism to specify AppBound domains
876         https://bugs.webkit.org/show_bug.cgi?id=208528
877         <rdar://problem/59980340>
878
879         Reviewed by Brent Fulgham.
880
881         Added test app-bound domains to the plist and tested that the domains
882         are properly stored in the website data store after a navigation.
883
884         * TestWebKitAPI/Info.plist:
885         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
886         (TEST):
887
888 2020-03-06  Alex Christensen  <achristensen@webkit.org>
889
890         Add SPI to disable cross origin access control checks
891         https://bugs.webkit.org/show_bug.cgi?id=208748
892
893         Reviewed by Tim Hatcher.
894
895         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
896         Add a test that verifies this SPI allows Access-Control-Allow-Origin: * with credentials.
897
898 2020-03-06  Basuke Suzuki  <basuke.suzuki@sony.com>
899
900         [webkitpy] Fix executive on Windows to run wpt server correctly
901         https://bugs.webkit.org/show_bug.cgi?id=208693
902
903         Reviewed by Jonathan Bedard.
904
905         Bug fix for Windows environment a) fixing a typo. b) fixing path
906         c) fix how to kill subprocesses.
907
908         * Scripts/webkitpy/common/system/executive.py:
909         (Executive._windows_kill_command):
910         (Executive.interrupt):
911         (Executive.kill_all):
912         * Scripts/webkitpy/port/base.py:
913         (Port.web_platform_test_server_doc_root):
914
915 2020-03-06  Alex Christensen  <achristensen@webkit.org>
916
917         Evaluating JavaScript in main frame before loading should succeed
918         https://bugs.webkit.org/show_bug.cgi?id=208733
919
920         Reviewed by Tim Horton.
921
922         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
923
924 2020-03-06  Ryosuke Niwa  <rniwa@webkit.org>
925
926         TextManipulationController should preserve images
927         https://bugs.webkit.org/show_bug.cgi?id=208692
928
929         Reviewed by Wenson Hsieh.
930
931         Added tests for preserving images and their ordering.
932
933         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
934         (TextManipulation.CompleteTextManipulationShouldPreserveImagesAsExcludedTokens):
935         (TextManipulation.CompleteTextManipulationShouldPreserveSVGAsExcludedTokens):
936         (TextManipulation.CompleteTextManipulationShouldPreserveOrderOfBlockImage):
937
938 2020-03-06  David Quesada  <david_quesada@apple.com>
939
940         Add _WKResourceLoadInfo.resourceType SPI
941         https://bugs.webkit.org/show_bug.cgi?id=208723
942
943         Reviewed by Alex Christensen.
944
945         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
946         (TEST):
947
948 2020-03-06  Jonathan Bedard  <jbedard@apple.com>
949
950         Stop reporting to webkit-test-results.webkit.org
951         https://bugs.webkit.org/show_bug.cgi?id=207218
952
953         Reviewed by Alexey Proskuryakov.
954
955         * BuildSlaveSupport/build.webkit.org-config/steps.py:
956         (RunWebKitTests):
957
958 2020-03-06  Sihui Liu  <sihui_liu@apple.com>
959
960         UIProcess crash after using _prepareForMoveToWindow, then deallocating the WKWebView before moving to the window
961         https://bugs.webkit.org/show_bug.cgi?id=208365
962         <rdar://problem/59877296>
963
964         Reviewed by Geoffrey Garen.
965
966         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
967         (TEST):
968
969 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
970
971         EWS should be able to fetch patch status for security bugs while processing them
972         https://bugs.webkit.org/show_bug.cgi?id=206511
973
974         Reviewed by Alexey Proskuryakov.
975
976         * BuildSlaveSupport/ews-build/steps.py:
977         (BugzillaMixin.fetch_data_from_url_with_authentication): Method to fetch data from bugzilla using api key.
978         (BugzillaMixin.get_patch_json): 
979         (BugzillaMixin.get_bug_json):
980         (BugzillaMixin._is_bug_closed):
981         (ApplyPatch.hideStepIf): Use 'sensitive' build property instead of 'validated'.
982         (TransferToS3.hideStepIf): Ditto.
983
984 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
985
986         [ews] commit-queue should show the trac url for the commit on the build page
987         https://bugs.webkit.org/show_bug.cgi?id=208715
988
989         Reviewed by Jonathan Bedard.
990
991         * BuildSlaveSupport/ews-build/steps.py:
992         (PushCommitToWebKitRepo.evaluateCommand):
993
994 2020-03-06  Alex Christensen  <achristensen@webkit.org>
995
996         Fix ResourceLoadDelegate.LoadInfo API test after r257816
997         https://bugs.webkit.org/show_bug.cgi?id=208550
998
999         * TestWebKitAPI/cocoa/HTTPServer.mm:
1000         (TestWebKitAPI::HTTPServer::respondToRequests):
1001         Sometimes we need a separate read to read the HTTP body after a request header, sometimes it comes in the same read.
1002         If it comes in the same read, send the response immediately.  Otherwise read the HTTP body then send the response.
1003
1004 2020-03-06  Lauro Moura <lmoura@igalia.com>
1005
1006         [WPE][WebDriver] MiniBrowser should react to close session commands
1007         https://bugs.webkit.org/show_bug.cgi?id=207529
1008
1009         Reviewed by Carlos Garcia Campos.
1010
1011         Do not call g_object_unref on the first created view if it has already
1012         been disposed in the "close" signal handler.
1013
1014         Based on original patch by Yury Semikhatsky.
1015
1016         * MiniBrowser/wpe/main.cpp:
1017         (main):
1018
1019 2020-03-06  Michael Catanzaro  <mcatanzaro@gnome.org>
1020
1021         [WPE][GTK] Use Firefox user agent quirk more aggressively on Google Docs
1022         https://bugs.webkit.org/show_bug.cgi?id=208647
1023
1024         Reviewed by Carlos Garcia Campos.
1025
1026         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1027         (TestWebKitAPI::TEST):
1028
1029 2020-03-05  Alex Christensen  <achristensen@webkit.org>
1030
1031         Add WKNavigationDelegatePrivate SPI to inform application of subframe navigations
1032         https://bugs.webkit.org/show_bug.cgi?id=208670
1033
1034         Reviewed by Brady Eidson.
1035
1036         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
1037         (-[FrameNavigationDelegate waitForNavigations:]):
1038         (-[FrameNavigationDelegate requests]):
1039         (-[FrameNavigationDelegate frames]):
1040         (-[FrameNavigationDelegate callbacks]):
1041         (-[FrameNavigationDelegate _webView:didStartProvisionalLoadWithRequest:inFrame:]):
1042         (-[FrameNavigationDelegate _webView:didFailProvisionalLoadWithRequest:inFrame:withError:]):
1043         (-[FrameNavigationDelegate _webView:didCommitLoadWithRequest:inFrame:]):
1044         (-[FrameNavigationDelegate _webView:didFailLoadWithRequest:inFrame:withError:]):
1045         (-[FrameNavigationDelegate _webView:didFinishLoadWithRequest:inFrame:]):
1046         (TEST):
1047
1048 2020-03-05  Alex Christensen  <achristensen@webkit.org>
1049
1050         Add WKFrameInfo._parentFrameHandle SPI
1051         https://bugs.webkit.org/show_bug.cgi?id=208674
1052
1053         Reviewed by Brady Eidson.
1054
1055         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1056
1057 2020-03-05  Jiewen Tan  <jiewen_tan@apple.com>
1058
1059         [WebAuthn] Implement SPI -[_WKWebAuthenticationPanelDelegate panel:selectAssertionResponse:source:completionHandler:]
1060         https://bugs.webkit.org/show_bug.cgi?id=208626
1061         <rdar://problem/60074148>
1062
1063         Reviewed by Brent Fulgham.
1064
1065         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1066         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
1067         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:source:completionHandler:]):
1068         (TestWebKitAPI::TEST):
1069         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:completionHandler:]): Deleted.
1070         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-multiple-accounts.html:
1071         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Added.
1072
1073 2020-03-05  Antoine Quint  <graouts@apple.com>
1074
1075         Page-specific UserStyleSheets should wait until the initial empty document has been removed to be injected
1076         https://bugs.webkit.org/show_bug.cgi?id=208644
1077         <rdar://problem/60042429>
1078
1079         Reviewed by Brady Eidson.
1080
1081         Add new tests for -[_WKUserStyleSheet initWithSource:forWKWebView:forMainFrameOnly:userContentWorld:]) that check:
1082         
1083         1. that a _WKUserStyleSheet can be added immediately after a WKWebView's creation and will be injected once the initial
1084            empty document has been removed in favor of the document for the requested URL,
1085         2. that removing a _WKUserStyleSheet immediately after it was added but before the initial empty document was removed
1086            correctly does not injected the style sheet.
1087
1088         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
1089
1090 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
1091
1092         [ews] Add build step to push commit to WebKit repository
1093         https://bugs.webkit.org/show_bug.cgi?id=208589
1094
1095         Reviewed by Jonathan Bedard.
1096
1097         * BuildSlaveSupport/ews-build/steps.py:
1098         (PushCommitToWebKitRepo): Build step to push the local commit to WebKit repository.
1099         (PushCommitToWebKitRepo.start): Initialize log observer.
1100         (PushCommitToWebKitRepo.evaluateCommand): Check command return status and comment on bug accordingly.
1101         (PushCommitToWebKitRepo.comment_text_for_bug): Generate comment text for commenting on bug.
1102         (PushCommitToWebKitRepo.svn_revision_from_commit_text): Extract the svn revision from commit text.
1103         (PushCommitToWebKitRepo.getResultSummary): Set custom failure message.
1104         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1105         * BuildSlaveSupport/ews-build/factories.py:
1106
1107 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
1108
1109         [ews] Add unit tests for ValidateCommiterAndReviewer build step
1110         https://bugs.webkit.org/show_bug.cgi?id=208262
1111
1112         Reviewed by Jonathan Bedard.
1113
1114         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests for ValidateCommiterAndReviewer.
1115
1116 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
1117
1118         commit-queue should run WK2 tests instead of WK1 tests
1119         https://bugs.webkit.org/show_bug.cgi?id=208544
1120
1121         Reviewed by Jonathan Bedard.
1122
1123         * BuildSlaveSupport/ews-build/factories.py:
1124
1125 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
1126
1127         [ews] ValidateCommiterAndReviewer should validate emails in case insensitive manner
1128         https://bugs.webkit.org/show_bug.cgi?id=208645
1129
1130         Reviewed by Alexey Proskuryakov.
1131
1132         * BuildSlaveSupport/ews-build/steps.py:
1133         (ValidateCommiterAndReviewer.load_contributors):
1134         (ValidateCommiterAndReviewer.start):
1135
1136 2020-03-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1137
1138         style-checker: Add UAF to the list of security words to warn about.
1139         https://bugs.webkit.org/show_bug.cgi?id=208643
1140
1141         Reviewed by Jonathan Bedard.
1142
1143         UAF is a common acronym used for use after free.
1144
1145         * Scripts/webkitpy/style/checkers/changelog.py:
1146         (ChangeLogChecker.check_for_unwanted_security_phrases):
1147
1148 2020-03-04  Basuke Suzuki  <basuke.suzuki@sony.com>
1149
1150         [MSVC] Add .natvis support of WebKit types
1151         https://bugs.webkit.org/show_bug.cgi?id=193119
1152
1153         Reviewed by Don Olmstead.
1154
1155         To help the WebKit developer while debugging, this file defines how
1156         WebKit types are displayed in debugger of Visual Studio.
1157         Very limited set of WebKit types, but it changes the world.
1158
1159         * VisualStudio/WebKit.natvis: Added.
1160
1161 2020-03-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1162
1163         Add system trace points around display list replay
1164         https://bugs.webkit.org/show_bug.cgi?id=208616
1165
1166         Reviewed by Simon Fraser.
1167
1168         Add a new "Display list replay" trace point.
1169
1170         * Tracing/SystemTracePoints.plist:
1171
1172 2020-03-04  Alex Christensen  <achristensen@webkit.org>
1173
1174         Call globalObjectIsAvailableForFrame before evaluating JavaScript in newly created worlds
1175         https://bugs.webkit.org/show_bug.cgi?id=208615
1176         <rdar://problem/59406743>
1177
1178         Reviewed by Alex Christensen.
1179
1180         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1181         * TestWebKitAPI/Tests/WebKitCocoa/ContentWorldPlugIn.mm: Added.
1182         (-[ContentWorldPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1183         (-[ContentWorldPlugIn webProcessPlugInBrowserContextController:globalObjectIsAvailableForFrame:inScriptWorld:]):
1184         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
1185         (TEST):
1186         Also make a test written in bug 206310 actually run code.
1187
1188 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
1189
1190         [build.webkit.org] Remove leaks queue
1191         https://bugs.webkit.org/show_bug.cgi?id=208580
1192
1193         Reviewed by Jonathan Bedard.
1194
1195         * BuildSlaveSupport/build.webkit.org-config/config.json:
1196         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1197         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1198
1199 2020-03-04  Alex Christensen  <achristensen@webkit.org>
1200
1201         Add SPI to evaluate JavaScript in an iframe
1202         https://bugs.webkit.org/show_bug.cgi?id=208605
1203
1204         Reviewed by Brady Eidson.
1205
1206         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1207
1208 2020-03-03  Jiewen Tan  <jiewen_tan@apple.com>
1209
1210         [WebAuthn] Implement -[_WKWebAuthenticationPanelDelegate panel:decidePolicyForLocalAuthenticatorWithCompletionHandler:] SPI
1211         https://bugs.webkit.org/show_bug.cgi?id=208533
1212         <rdar://problem/60010184>
1213
1214         Reviewed by Alex Christensen.
1215
1216         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1217         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
1218         (-[TestWebAuthenticationPanelDelegate panel:decidePolicyForLocalAuthenticatorWithCompletionHandler:]):
1219         (TestWebKitAPI::TEST):
1220         (-[TestWebAuthenticationPanelDelegate panel:verifyUserWithAccessControl:completionHandler:]): Deleted.
1221         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Removed.
1222
1223 2020-03-04  Alex Christensen  <achristensen@webkit.org>
1224
1225         callAsyncJavaScript with an invalid parameter and no completionHandler should not crash
1226         https://bugs.webkit.org/show_bug.cgi?id=208593
1227
1228         Reviewed by Brady Eidson.
1229
1230         * TestWebKitAPI/Tests/WebKitCocoa/AsyncFunction.mm:
1231         (TestWebKitAPI::TEST):
1232
1233 2020-03-04  Alex Christensen  <achristensen@webkit.org>
1234
1235         WKWebView's frames accessor should return a traversable type
1236         https://bugs.webkit.org/show_bug.cgi?id=208591
1237
1238         Reviewed by Brady Eidson.
1239
1240         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1241
1242 2020-03-04  Antoine Quint  <graouts@apple.com>
1243
1244         Add an SPI to allow UserStyleSheet injection to target a specific WKWebView
1245         https://bugs.webkit.org/show_bug.cgi?id=208575
1246         <rdar://problem/59773690>
1247
1248         Reviewed by Brady Eidson.
1249
1250         Add new tests for the new SPI which check:
1251         
1252         1. that specifying forWKWebView: when initializing a _WKUserStyleSheet will inject the provided CSS source in the
1253            specified WKWebView alone,
1254         2. that the same test works with two WKWebViews with a shared WKWebKitConfiguration,
1255         3. that a WKWebView-specific _WKUserStyleSheet can be removed,
1256         4. that a WKWebView-specific _WKUserStyleSheet can be added twice and removed once and be removed as expected,
1257         5. and that a WKWebView-specific _WKUserStyleSheet is automatically removed when navigating to a new page,
1258         6. and that the same test also works with PSON enabled.
1259
1260         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
1261
1262 2020-03-04  Ryan Haddad  <ryanhaddad@apple.com>
1263
1264         [macOS] test-lldb-webkit failing on debug bots
1265         https://bugs.webkit.org/show_bug.cgi?id=208545
1266
1267         Reviewed by Jonathan Bedard.
1268
1269         The lldb-webkit-test step must pass in the build configuration as an
1270         argument to the test-lldb-webkit script so that it uses the lldbWebKitTester
1271         binary that is downloaded with the rest of the build products. Without this
1272         argument, the bots expect to find the binary in the 'WebKitBuild/Release' directory
1273         regardless of their actual build configuration.
1274
1275         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1276         (RunLLDBWebKitTests): Pass in the build configuration to the test-lldb-webkit script.
1277         * Scripts/test-lldb-webkit:
1278         (LldbTester.parse_args): Capitalize the constants for Debug / Release since that is what webkitpy expects.
1279
1280 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
1281
1282         [ews] Add build step to create local git commit for commit-queue (follow-up fix)
1283         https://bugs.webkit.org/show_bug.cgi?id=208539
1284
1285         Unreviewed follow-up fix.
1286
1287         * BuildSlaveSupport/ews-build/steps.py:
1288
1289 2020-03-04  Daniel Bates  <dabates@apple.com>
1290
1291         Should use -bounds instead of -frame in RequestTextInputContext.mm tests
1292         https://bugs.webkit.org/show_bug.cgi?id=208565
1293
1294         Reviewed by Wenson Hsieh.
1295
1296         Pass the bounds of the web view to -synchronouslyRequestTextInputContextsInRect: instead
1297         of its frame as a means to find all the editable elements in the visible content area
1298         of the web view.
1299
1300         Coincidentally this makes no difference to the test results right now because the web view
1301         happens to be located at the origin (0, 0) in the window. However if in the future the
1302         web view would be located at some other point then the tests may fail because the rectangle
1303         passed to -synchronouslyRequestTextInputContextsInRect: would no longer represent the
1304         rectangle for the visible content area.
1305
1306         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1307         (TEST):
1308
1309 2020-03-04  Daniel Bates  <dabates@apple.com>
1310
1311         Organize tests in RequestTextInputContext.mm tests under test name RequestTextInputContext
1312         https://bugs.webkit.org/show_bug.cgi?id=208564
1313
1314         Reviewed by Alex Christensen.
1315
1316         Group the tests in RequestTextInputContext.mm under the test case name RequestTextInputContext
1317         to make it easy to run just these tests.
1318
1319         Currently, the tests are organized under the test case name WebKit. This means you need to
1320         pass run-api-tests the name of each sub-test as there is no easy way to run them all without
1321         also running all the TestWebKitAPI.WebKit sub-tests. Instead organize them under RequestTextInputContext
1322         so that a person can run just these test using:
1323         
1324                 run-api-tests --debug TestWebKitAPI.RequestTextInputContext
1325
1326         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1327         (TEST):
1328
1329 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
1330
1331         [ews] Add build step to create local git commit for commit-queue
1332         https://bugs.webkit.org/show_bug.cgi?id=208539
1333
1334         Reviewed by Jonathan Bedard.
1335
1336         * BuildSlaveSupport/ews-build/steps.py:
1337         (CreateLocalGITCommit): Build step to create local git commit.
1338         (CreateLocalGITCommit.start):
1339         (CreateLocalGITCommit.getResultSummary): Set custom failure message.
1340         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests and restructured imports.
1341         * BuildSlaveSupport/ews-build/factories.py:
1342
1343 2020-03-04  Simon Fraser  <simon.fraser@apple.com>
1344
1345         (r256513) [ Mac ] fast/scrolling/programmatic-scroll-to-zero-zero.html is a flaky failure
1346         https://bugs.webkit.org/show_bug.cgi?id=207948
1347
1348         Reviewed by Zalan Bujtas.
1349
1350         EventSendingController needs to trigger layout so that the WebHTMLView is not 0x0,
1351         so that it receives the wheel events.
1352
1353         * DumpRenderTree/mac/EventSendingController.mm:
1354         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
1355         * DumpRenderTree/win/EventSender.cpp:
1356         (mouseScrollBy):
1357
1358 2020-03-04  Andres Gonzalez  <andresg_22@apple.com>
1359
1360         REGRESSION (r257739): two fast/events/autoscroll test have started to fail
1361         https://bugs.webkit.org/show_bug.cgi?id=208520
1362         <rdar://problem/60000214>
1363
1364         Reviewed by Chris Fleizach.
1365
1366         Calling InjectedBundle::singleton().page()->page() in the constructor
1367         of the AccessibilityController is having this side effect on iOS.
1368         So #if to MAC where it's actually being used.
1369
1370         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1371         (WTR::AccessibilityController::AccessibilityController):
1372
1373 2020-03-03  Alex Christensen  <achristensen@webkit.org>
1374
1375         Add SPI _WKResourceLoadInfo.loadedFromCache
1376         https://bugs.webkit.org/show_bug.cgi?id=208554
1377
1378         Reviewed by Wenson Hsieh.
1379
1380         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
1381         (TEST):
1382
1383 2020-03-03  Ryosuke Niwa  <rniwa@webkit.org>
1384
1385         Batch observations and completions of text manipulations
1386         https://bugs.webkit.org/show_bug.cgi?id=208406
1387
1388         Reviewed by Wenson Hsieh.
1389
1390         Updated the existing tests to use new APIs, and added new tests for batching finding & replacing
1391         multiple paragraphs at once.
1392
1393         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1394         (-[TextManipulationDelegate _webView:didFindTextManipulationItems:]):
1395         (-[TextManipulationDelegate items]):
1396         (-[LegacyTextManipulationDelegate init]):
1397         (-[LegacyTextManipulationDelegate _webView:didFindTextManipulationItem:]):
1398         (TextManipulation.StartTextManipulationSupportsLegacyDelegateCallback): Added.
1399         (TextManipulation.LegacyCompleteTextManipulationReplaceSimpleSingleParagraph): Added.
1400         (TextManipulation.CompleteTextManipulationReplaceMultipleSimpleParagraphsAtOnce): Added.
1401         (TextManipulation.CompleteTextManipulationShouldBatchItemCallback): Added.
1402         (TextManipulation.CompleteTextManipulationFailWhenItemIdentifierIsDuplicated): Added.
1403         (TextManipulation.CompleteTextManipulationCanHandleSubsetOfItemsToFail): Added.
1404
1405 2020-03-03  Per Arne Vollan  <pvollan@apple.com>
1406
1407         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
1408         https://bugs.webkit.org/show_bug.cgi?id=208415
1409
1410         Reviewed by Brent Fulgham.
1411
1412         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1413         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
1414         (TEST):
1415
1416 2020-03-03  Alex Christensen  <achristensen@webkit.org>
1417
1418         Add response to _WKResourceLoadDelegate didCompleteWithError callback
1419         https://bugs.webkit.org/show_bug.cgi?id=208553
1420
1421         Reviewed by Simon Fraser.
1422
1423         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
1424         (-[TestResourceLoadDelegate webView:resourceLoad:didCompleteWithError:response:]):
1425         (TEST):
1426         (-[TestResourceLoadDelegate webView:resourceLoad:didCompleteWithError:]): Deleted.
1427
1428 2020-03-03  Brady Eidson  <beidson@apple.com>
1429
1430         API Test [Mojave+ WK2 Debug ] TestWebKitAPI.WKAttachmentTestsMac.InsertDroppedFilePromisesAsAttachments is a flaky crash.
1431         https://bugs.webkit.org/show_bug.cgi?id=198795
1432
1433         Reviewed by Chris Dumez.
1434
1435         This test appears to no longer be flaky.
1436         
1437         Let's re-enable it.
1438         
1439         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1440         (TestWebKitAPI::TEST):
1441
1442 2020-03-03  Alex Christensen  <achristensen@webkit.org>
1443
1444         Requests sent to _WKResourceLoadDelegate should include HTTPBody
1445         https://bugs.webkit.org/show_bug.cgi?id=208550
1446
1447         Reviewed by Tim Hatcher.
1448
1449         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
1450         (TEST):
1451         * TestWebKitAPI/cocoa/HTTPServer.mm:
1452         (TestWebKitAPI::HTTPServer::respondToRequests):
1453         HTTPServer now looks for Content-Length in its request.
1454         If it finds this header, that means that the HTTP body is going to be received in another read, then the response should be sent after receiving that.
1455
1456 2020-03-03  Alex Christensen  <achristensen@webkit.org>
1457
1458         Expose originalURL and originalHTTPMethod on _WKResourceLoadInfo
1459         https://bugs.webkit.org/show_bug.cgi?id=208522
1460
1461         Reviewed by Brian Weinstein.
1462
1463         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
1464         (TEST):
1465
1466 2020-03-03  Aakash Jain  <aakash_jain@apple.com>
1467
1468         commit-queue should update working directory and reapply patch just before commiting
1469         https://bugs.webkit.org/show_bug.cgi?id=208521
1470
1471         Reviewed by Jonathan Bedard.
1472
1473         * BuildSlaveSupport/ews-build/factories.py:
1474
1475 2020-03-03  Matt Lewis  <jlewis3@apple.com>
1476
1477         Add Unittest to commits_for_upload() and fix multiple unittests for several test suites.
1478         https://bugs.webkit.org/show_bug.cgi?id=208485
1479
1480         Reviewed by Jonathan Bedard.
1481
1482         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
1483         (StubRepository.__init__): Fixing the constructor to call upon the parent class as we were not doing this before. It also means
1484         that we don't have to recreate the variables that are already created.
1485         * Scripts/webkitpy/common/checkout/scm/stub_repository_unittest.py: High level changed the imports to better reflect what we are using
1486         from each module, rather than making extra imports that we don't need.
1487         (StubRepositoryTest.mock_host_for_stub_repository): Since we are calling both an executive and a filesystem mock for most of the
1488         tests. it makes more sense to create a mock host with the files needed, than it does to instantiate each of these as separate objects
1489         and not part of the host.
1490         (StubRepositoryTest.test_in_working_directory): Changed the filesystem call to the host call.
1491         (StubRepositoryTest.test_native_revision): Changed the filesystem call to the host call.
1492         (StubRepositoryTest.test_native_branch): Changed the filesystem call to the host call.
1493         (StubRepositoryTest.test_svn_revision): Changed the filesystem call to the host call.
1494         (StubRepositoryTest.test_find_checkout_root): Changed the filesystem call to the host call.
1495         (StubRepositoryTest.test_find_checkout_root_failure): Changed the filesystem call to the host call.
1496         (StubRepositoryTest.test_find_parent_path_matching_callback_condition_with_file_system): Changed the filesystem call to the host call.
1497         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py: 
1498         (SummarizedResultsTest.test_svn_revision_exists): Changed the name to original test to better reflect that it was just looking to see
1499         if we were geting any value at all
1500         (SummarizedResultsTest.test_svn_revision): Added a test to make sure that the revision we are getting is what we expect to get and make
1501         sure we aren't gabking the wrong key:value pair
1502         * Scripts/webkitpy/port/base_unittest.py: Changed from MockSystemHost to MockHost as we want the extras that
1503         come with the MockHosts and MockHost inherits from MockSystemHost.
1504         (PortTest.make_port): Changed the port to call MockHost that will creat the required stub_repository files.
1505         (test_commits_for_upload): Added amissing test for commits_for_upload as this has been an issue when trying to make changes
1506         to the various upload steps.
1507
1508 2020-03-03  Aakash Jain  <aakash_jain@apple.com>
1509
1510         [ews] Add build step to find list of modified changelogs
1511         https://bugs.webkit.org/show_bug.cgi?id=208514
1512
1513         Reviewed by Jonathan Bedard.
1514
1515         * BuildSlaveSupport/ews-build/factories.py:
1516         * BuildSlaveSupport/ews-build/steps.py:
1517         (FindModifiedChangeLogs): Build step to find modified ChangeLogs.
1518         (FindModifiedChangeLogs.start): Initialize log observer.
1519         (FindModifiedChangeLogs.getResultSummary): Set custom failure message.
1520         (FindModifiedChangeLogs.evaluateCommand):
1521         (FindModifiedChangeLogs.is_path_to_changelog): Check if the file is a ChangeLog.
1522         (FindModifiedChangeLogs._status_regexp): Regex to match files from git output.
1523         (FindModifiedChangeLogs.extract_changelogs): Method to get list of ChangeLogs from git output.
1524         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1525
1526 2020-03-03  Ryan Haddad  <ryanhaddad@apple.com>
1527
1528         [iOS EWS] TestWebKitAPI.WKWebsiteDataStore.RemoveAndFetchData is failing
1529         https://bugs.webkit.org/show_bug.cgi?id=208451
1530
1531         Unreviewed test gardening.
1532
1533         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm: Disable the test for iOS since it is slowing down EWS.
1534
1535 2020-03-03  Jiten Mehta  <jmehta@apple.com>
1536
1537         Adopt HTTP Alternative Services Storage
1538         https://bugs.webkit.org/show_bug.cgi?id=208387
1539
1540         Reviewed by Alex Christensen.
1541
1542         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1543         (checkUntilEntryFound):
1544         (TEST):
1545
1546 2020-03-03  Kate Cheney  <katherine_cheney@apple.com>
1547
1548         Check for navigation to app-bound domain during script evaluation
1549         https://bugs.webkit.org/show_bug.cgi?id=208319
1550         <rdar://problem/57569321>
1551
1552         Reviewed by Brent Fulgham.
1553
1554         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1555         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm: Added.
1556         (-[TestInAppBrowserScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1557         (TEST):
1558         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-agent-script.html: Added.
1559         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-script.html: Added.
1560
1561 2020-03-03  Commit Queue  <commit-queue@webkit.org>
1562
1563         Unreviewed, rolling out r257754.
1564         https://bugs.webkit.org/show_bug.cgi?id=208513
1565
1566         Introduced API test failure (Requested by perarne on #webkit).
1567
1568         Reverted changeset:
1569
1570         "[Cocoa] Mapping from MIME type to UTI type should be done in
1571         the UI process"
1572         https://bugs.webkit.org/show_bug.cgi?id=208415
1573         https://trac.webkit.org/changeset/257754
1574
1575 2020-03-03  Diego Pino Garcia  <dpino@igalia.com>
1576
1577         REGRESSION(r257726): [GTK] LayoutTests crashing after r257726
1578         https://bugs.webkit.org/show_bug.cgi?id=208506
1579
1580         Reviewed by Carlos Garcia Campos.
1581
1582         * WebKitTestRunner/TestController.cpp:
1583         (WTR::TestController::platformAdjustContext): Remove unnecessary code.
1584
1585 2020-03-02  Ben Nham  <nham@apple.com>
1586
1587         Add performance probes for HTML parsing
1588         https://bugs.webkit.org/show_bug.cgi?id=208271
1589
1590         Reviewed by Daniel Bates.
1591
1592         This adds probes that show which lines of HTML are have been parsed.
1593
1594         * Tracing/SystemTracePoints.plist:
1595
1596 2020-03-02  Per Arne Vollan  <pvollan@apple.com>
1597
1598         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
1599         https://bugs.webkit.org/show_bug.cgi?id=208415
1600
1601         Reviewed by Brent Fulgham.
1602
1603         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1604         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
1605         (TEST):
1606
1607 2020-03-02  Jacob Uphoff  <jacob_uphoff@apple.com>
1608
1609         Unreviewed, rolling out r257725.
1610
1611         This commit caused 10 API tests to fail
1612
1613         Reverted changeset:
1614
1615         "[Cocoa] Mapping from MIME type to UTI type should be done in
1616         the UI process"
1617         https://bugs.webkit.org/show_bug.cgi?id=208415
1618         https://trac.webkit.org/changeset/257725
1619
1620 2020-03-02  Saam Barati  <sbarati@apple.com>
1621
1622         Don't skip tests unnecessarily on arm64
1623         https://bugs.webkit.org/show_bug.cgi?id=208470
1624         <rdar://problem/59968869>
1625
1626         Reviewed by Tadeu Zagallo.
1627
1628         * Scripts/run-jsc-stress-tests:
1629
1630 2020-03-02  Andres Gonzalez  <andresg_22@apple.com>
1631
1632         Fix for LayoutTests/accessibility/mac/search-text/search-text.html in IsolatedTree mode.
1633         https://bugs.webkit.org/show_bug.cgi?id=208434
1634
1635         Reviewed by Chris Fleizach.
1636
1637         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1638         (WTR::AccessibilityController::AccessibilityController): Initializes m_useAXThread.
1639         (WTR::AccessibilityController::rootElement): No need to set m_useAXThread here since it is initialize in the constructor.
1640         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
1641         (WTR::AccessibilityController::accessibleElementById): Same as above.
1642
1643 2020-03-02  John Wilander  <wilander@apple.com>
1644
1645         ResourceLoadStatistics: Enable cookie blocking and the Storage Access API in ephemeral sessions
1646         https://bugs.webkit.org/show_bug.cgi?id=208399
1647         <rdar://problem/24731650>
1648
1649         Reviewed by Brent Fulgham.
1650
1651         The majority of the changes in WTR::TestController is (partially) fixing a bug
1652         where the TestRunner would statically use the default website datastore instead
1653         of the website data store configure for the page. This worked for persistent
1654         storage testing but not for ephemeral sessions which is what this patch is all
1655         about. The previous TestController::websiteDataStore() is now called
1656         TestController::defaultWebsiteDataStore() and the new
1657         TestController::websiteDataStore() returns the configured website data store.
1658         Most of the use of the default website data store should probably change but
1659         that's not really for this patch to deal with. I did however move all of
1660         resource load statistics' use to the new TestController::websiteDataStore().
1661
1662         A new TestRunner function was added: isStatisticsEphemeral()
1663         It allows test cases to query the ephemeral status of resource load statistics.
1664
1665         One problem that is mitigated in this patch but not fully fixed is that for
1666         Cocoa platforms, the TestRunner sets up two ephemeral sessions, once in
1667         TestController::generatePageConfiguration() via C API 
1668         WKPageConfigurationSetWebsiteDataStore(), and then again in 
1669         TestControllerCocoa's initializeWebViewConfiguration() via Cocoa API
1670         [copiedConfiguration setWebsiteDataStore:ephemeralWebsiteDataStore].
1671         I tried removing the latter since one session for all platforms should be
1672         Enough but got broken behavior as a result. So now both are still there
1673         and both enable resource load statistics.
1674
1675         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1676         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1677         (WTR::TestRunner::isStatisticsEphemeral):
1678         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1679         * WebKitTestRunner/TestController.cpp:
1680         (WTR::TestController::defaultWebsiteDataStore):
1681         (WTR::TestController::websiteDataStore):
1682         (WTR::TestController::generatePageConfiguration):
1683         (WTR::TestController::resetPreferencesToConsistentValues):
1684         (WTR::TestController::resetStateToConsistentValues):
1685         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1686         (WTR::TestController::decidePolicyForNavigationAction):
1687         (WTR::TestController::platformAdjustContext):
1688         (WTR::TestController::clearServiceWorkerRegistrations):
1689         (WTR::TestController::clearDOMCache):
1690         (WTR::TestController::clearDOMCaches):
1691         (WTR::TestController::clearIndexedDatabases):
1692         (WTR::TestController::clearLocalStorage):
1693         (WTR::TestController::hasDOMCache):
1694         (WTR::TestController::domCacheSize):
1695         (WTR::TestController::setStatisticsEnabled):
1696         (WTR::TestController::isStatisticsEphemeral):
1697         (WTR::TestController::setStatisticsDebugMode):
1698         (WTR::TestController::setStatisticsPrevalentResourceForDebugMode):
1699         (WTR::TestController::setStatisticsLastSeen):
1700         (WTR::TestController::setStatisticsMergeStatistic):
1701         (WTR::TestController::setStatisticsPrevalentResource):
1702         (WTR::TestController::setStatisticsVeryPrevalentResource):
1703         (WTR::TestController::dumpResourceLoadStatistics):
1704         (WTR::TestController::isStatisticsPrevalentResource):
1705         (WTR::TestController::isStatisticsVeryPrevalentResource):
1706         (WTR::TestController::isStatisticsRegisteredAsSubresourceUnder):
1707         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
1708         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
1709         (WTR::TestController::setStatisticsHasHadUserInteraction):
1710         (WTR::TestController::isStatisticsHasHadUserInteraction):
1711         (WTR::TestController::isStatisticsOnlyInDatabaseOnce):
1712         (WTR::TestController::setStatisticsGrandfathered):
1713         (WTR::TestController::isStatisticsGrandfathered):
1714         (WTR::TestController::setUseITPDatabase):
1715         (WTR::TestController::setStatisticsSubframeUnderTopFrameOrigin):
1716         (WTR::TestController::setStatisticsSubresourceUnderTopFrameOrigin):
1717         (WTR::TestController::setStatisticsSubresourceUniqueRedirectTo):
1718         (WTR::TestController::setStatisticsSubresourceUniqueRedirectFrom):
1719         (WTR::TestController::setStatisticsTopFrameUniqueRedirectTo):
1720         (WTR::TestController::setStatisticsTopFrameUniqueRedirectFrom):
1721         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1722         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1723         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1724         (WTR::TestController::statisticsUpdateCookieBlocking):
1725         (WTR::TestController::statisticsSubmitTelemetry):
1726         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
1727         (WTR::TestController::setStatisticsIsRunningTest):
1728         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
1729         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
1730         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
1731         (WTR::TestController::setStatisticsGrandfatheringTime):
1732         (WTR::TestController::setStatisticsMaxStatisticsEntries):
1733         (WTR::TestController::setStatisticsPruneEntriesDownTo):
1734         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
1735         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1736         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
1737         (WTR::TestController::statisticsDeleteCookiesForHost):
1738         (WTR::TestController::isStatisticsHasLocalStorage):
1739         (WTR::TestController::setStatisticsCacheMaxAgeCap):
1740         (WTR::TestController::hasStatisticsIsolatedSession):
1741         (WTR::TestController::setStatisticsShouldDowngradeReferrer):
1742         (WTR::TestController::setStatisticsShouldBlockThirdPartyCookies):
1743         (WTR::TestController::setStatisticsFirstPartyWebsiteDataRemovalMode):
1744         (WTR::TestController::statisticsResetToConsistentState):
1745         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
1746         * WebKitTestRunner/TestController.h:
1747         * WebKitTestRunner/TestInvocation.cpp:
1748         (WTR::TestInvocation::invoke):
1749         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1750         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1751         (WTR::initializeWebViewConfiguration):
1752         (WTR::TestController::platformCreateWebView):
1753
1754 2020-03-02  Per Arne Vollan  <pvollan@apple.com>
1755
1756         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
1757         https://bugs.webkit.org/show_bug.cgi?id=208415
1758
1759         Reviewed by Brent Fulgham.
1760
1761         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1762         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
1763         (TEST):
1764
1765 2020-03-02  Daniel Bates  <dabates@apple.com>
1766
1767         Page::editableElementsInRect() should find nested editable elements and return found elements in paint order
1768         https://bugs.webkit.org/show_bug.cgi?id=208352
1769         <rdar://problem/59867815>
1770
1771         Reviewed by Wenson Hsieh.
1772
1773         Update test results to reflect the new behavior. To do this I also need to fix up the test code
1774         to actually scroll the web content. This also means we now execute the same code on both Mac and
1775         iOS to do the scrolling: window.scrollTo(0, 5000). Also fixed up sub-test "Inputs scrolled outside
1776         the requested rect; should not be included." to use a 10000px height <div> so that you can scroll
1777         to a y position of 5000. Otherwise, it's impossible to do because the page height is < 5000px.
1778
1779         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1780         (TEST):
1781
1782 2020-03-02  Jacob Uphoff  <jacob_uphoff@apple.com>
1783
1784         Unreviewed, rolling out r257687.
1785
1786         This commit caused debug tests to crash for macOS & iOS
1787
1788         Reverted changeset:
1789
1790         "[Cocoa] Mapping from MIME type to UTI type should be done in
1791         the UI process"
1792         https://bugs.webkit.org/show_bug.cgi?id=208415
1793         https://trac.webkit.org/changeset/257687
1794
1795 2020-03-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1796
1797         Unreviewed, rolling out r257618.
1798
1799         This allegedly causes Safari to crash when closing a window
1800         (see rdar://problem/59922725).
1801
1802         Reverted changeset:
1803
1804         "UIProcess crash after using _prepareForMoveToWindow, then
1805         deallocating the WKWebView before moving to the window"
1806         https://bugs.webkit.org/show_bug.cgi?id=208365
1807         https://trac.webkit.org/changeset/257618
1808
1809 2020-02-29  Yusuke Suzuki  <ysuzuki@apple.com>
1810
1811         Remove std::lock_guard
1812         https://bugs.webkit.org/show_bug.cgi?id=206451
1813
1814         Reviewed by Anders Carlsson.
1815
1816         Add std::lock_guard lint rule to prevent from using it.
1817
1818         * Scripts/webkitpy/style/checkers/cpp.py:
1819         (check_lock_guard):
1820         (check_style):
1821         (CppChecker):
1822         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1823         (WebKitStyleTest.test_lock_guard):
1824         * TestWebKitAPI/Tests/WTF/Condition.cpp:
1825         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1826         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
1827         (assertHasObjects):
1828         (assertHasOnlyObjects):
1829         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1830         (WTR::AXThread::dispatch):
1831         (WTR::AXThread::dispatchFunctionsFromAXThread):
1832         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
1833         (WTR::AXThread::initializeRunLoop):
1834
1835 2020-02-29  Per Arne Vollan  <pvollan@apple.com>
1836
1837         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
1838         https://bugs.webkit.org/show_bug.cgi?id=208415
1839
1840         Reviewed by Brent Fulgham.
1841
1842         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1843         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
1844         (TEST):
1845
1846 2020-02-28  Fujii Hironori  <Hironori.Fujii@sony.com>
1847
1848         Unreviewed, rolling out r257565.
1849
1850         It broke WinCairo MiniBrowser
1851
1852         Reverted changeset:
1853
1854         "[CMake] Use WEBKIT_EXECUTABLE in MiniBrowser"
1855         https://bugs.webkit.org/show_bug.cgi?id=206894
1856         https://trac.webkit.org/changeset/257565
1857
1858 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
1859
1860         EWS fails to retry build in case of kill-old-processes exception
1861         https://bugs.webkit.org/show_bug.cgi?id=208003
1862
1863         Reviewed by Jonathan Bedard.
1864
1865         * BuildSlaveSupport/ews-build/steps.py:
1866         (KillOldProcesses.evaluateCommand):
1867         (KillOldProcesses.getResultSummary):
1868
1869 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
1870
1871         [ews] commit-queue should update the ChangeLog with Reviewer name
1872         https://bugs.webkit.org/show_bug.cgi?id=206535
1873
1874         Reviewed by Jonathan Bedard.
1875
1876         * BuildSlaveSupport/ews-build/steps.py:
1877         (ApplyPatch.start): Update the patch with the patch reviewer name if available.
1878
1879 2020-02-28  Jonathan Bedard  <jbedard@apple.com>
1880
1881         run-javascriptcore-tests: Make upload format valid
1882         https://bugs.webkit.org/show_bug.cgi?id=208341
1883
1884         Rubber-stamped by Aakash Jain.
1885
1886         * Scripts/run-javascriptcore-tests:
1887         (uploadResults): Remove. FIXME.
1888         * Scripts/webkitdirs.pm:
1889         (splitVersionString): Handle case where the subminor version number has a - in it.
1890         * Scripts/webkitperl/webkitdirs_unittest/splitVersion.pl: Add unit tests.
1891
1892 2020-02-28  youenn fablet  <youenn@apple.com>
1893
1894         [MacOS/iOS] Enable audio/video capture in GPUProcess by default
1895         https://bugs.webkit.org/show_bug.cgi?id=208130
1896
1897         Reviewed by Eric Carlson.
1898
1899         * WebKitTestRunner/TestOptions.h:
1900         Use GPU process to capture by default.
1901         We will remove this option once done verifying that every test works smoothly.
1902
1903 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
1904
1905         [ews] commit queue should skip building and testing for rollout patches
1906         https://bugs.webkit.org/show_bug.cgi?id=208329
1907
1908         Reviewed by Jonathan Bedard.
1909
1910         * BuildSlaveSupport/ews-build/steps.py:
1911         (BugzillaMixin._is_patch_obsolete): Set rollout property appropriately.
1912         (CompileWebKit.doStepIf): Skip tests for rollout patches on commit-queue.
1913         (RunWebKit1Tests.doStepIf): Ditto.
1914         * BuildSlaveSupport/ews-build/steps_unittest.py:
1915         (TestCompileWebKit.test_skip_for_rollout_patches_on_commit_queue): Added unit-test.
1916         (TestRunWebKit1Tests.test_skip_for_rollout_patches_on_commit_queue): Ditto.
1917
1918 2020-02-28  Daniel Bates  <dabates@apple.com>
1919
1920         Update my watch list preferences and contributor's entry.
1921
1922         * Scripts/webkitpy/common/config/contributors.json:
1923         * Scripts/webkitpy/common/config/watchlist:
1924
1925 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
1926
1927         Fix WebCore export macros for declspec
1928         https://bugs.webkit.org/show_bug.cgi?id=208363
1929
1930         Reviewed by Konstantin Tokarev.
1931
1932         Remove setting of WEBCORE_EXPORT and WEBCORE_TESTSUPPORT_EXPORT from the header
1933         files. Removed precompiled headers that were empty.
1934
1935         * DumpRenderTree/DumpRenderTreePrefix.h:
1936         * DumpRenderTree/win/DefaultPolicyDelegate.cpp: Added a missing config.h.
1937         * MiniBrowser/win/stdafx.h:
1938         * TestWebKitAPI/win/TestWebKitAPIPrefix.cpp: Removed.
1939         * TestWebKitAPI/win/TestWebKitAPIPrefix.h: Removed.
1940         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.cpp: Removed.
1941         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h: Removed.
1942         * WebKitTestRunner/PlatformFTW.cmake:
1943         * WebKitTestRunner/PlatformWin.cmake:
1944         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1945
1946 2020-02-27  Tim Horton  <timothy_horton@apple.com>
1947
1948         UIProcess crash after using _prepareForMoveToWindow, then deallocating the WKWebView before moving to the window
1949         https://bugs.webkit.org/show_bug.cgi?id=208365
1950
1951         Reviewed by Alex Christensen.
1952
1953         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
1954         (TEST):
1955         Add a test! It was a 100% repro crash before this change.
1956
1957 2020-02-27  Kate Cheney  <katherine_cheney@apple.com>
1958
1959         TestWebKitAPI and WebKitTestRunner should have bundle identifiers
1960         https://bugs.webkit.org/show_bug.cgi?id=208260
1961         <rdar://problem/59820107>
1962
1963         Reviewed by Tim Horton.
1964
1965         Followed instructions for adding an Info.plist for Single-File Tools
1966         found on https://developer.apple.com/library/archive/documentation/Security/Conceptual/CodeSigningGuide/Procedures/Procedures.html
1967
1968         The default WebsiteDataStore file path will change with this test to
1969         reflect the new bundleID so we must change expectations for any api
1970         tests which rely on knowing the path.
1971
1972         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1973         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1974         * TestWebKitAPI/Tests/WebKitCocoa/IDBDeleteRecovery.mm:
1975         (TEST):
1976         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
1977         (TEST):
1978         * TestWebKitAPI/Tests/WebKitCocoa/IDBObjectStoreInfoUpgradeToV2.mm:
1979         (TEST):
1980         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.mm:
1981         (TEST):
1982         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
1983         (TEST):
1984         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
1985         (TEST):
1986         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageClear.mm:
1987         (TEST):
1988         (defaultWebsiteCacheDirectory):
1989         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageNullEntries.mm:
1990         (TEST):
1991         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1992         (TEST):
1993         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1994         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
1995         (TEST):
1996         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1997         (TEST):
1998         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1999         (runWebsiteDataStoreCustomPaths):
2000         (TEST):
2001         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
2002         (TestWebKitAPI::resetTestState):
2003         Now that we set a bundleID, we have to reset the cache model between
2004         tests, otherwise it gets stored between tests.
2005
2006         (TestWebKitAPI::TEST):
2007         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2008         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2009
2010 2020-02-27  Ryosuke Niwa  <rniwa@webkit.org>
2011
2012         TextManipulationController should not generate a new item for content in manipulated paragraphs
2013         https://bugs.webkit.org/show_bug.cgi?id=208286
2014
2015         Reviewed by Wenson Hsieh.
2016
2017         Added a regression test.
2018
2019         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2020         (TextManipulation.InsertingContentIntoAlreadyManipulatedContentDoesNotCreateTextManipulationItem):
2021
2022 2020-02-27  Jonathan Bedard  <jbedard@apple.com>
2023
2024         run-javascriptcore-tests: Make upload format valid
2025         https://bugs.webkit.org/show_bug.cgi?id=208341
2026
2027         Reviewed by Aakash Jain.
2028
2029         * Scripts/run-javascriptcore-tests:
2030         (uploadResults): Print json blob for upload after failure for debugging.
2031
2032 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
2033
2034         [CMake] Add WebKit::PAL target
2035         https://bugs.webkit.org/show_bug.cgi?id=198493
2036
2037         Reviewed by Michael Catanzaro.
2038
2039         Add workaround for Windows where PAL_FRAMEWORK_HEADERS_DIR is not propagating.
2040
2041         * DumpRenderTree/PlatformWin.cmake:
2042
2043 2020-02-27  Alex Christensen  <achristensen@webkit.org>
2044
2045         Add SPI to query WKFrameInfos in a WKWebView
2046         https://bugs.webkit.org/show_bug.cgi?id=208212
2047
2048         Reviewed by Brady Eidson.
2049
2050         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2051         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp: Removed.
2052         * WebKitTestRunner/TestController.cpp:
2053         (WTR::TestController::saltForOrigin):
2054
2055 2020-02-27  Jacob Uphoff  <jacob_uphoff@apple.com>
2056
2057         Unreviewed, rolling out r257530.
2058
2059         This commit seems to have broke the build internally for
2060         watchOS
2061
2062         Reverted changeset:
2063
2064         "Add SPI to query WKFrameInfos in a WKWebView"
2065         https://bugs.webkit.org/show_bug.cgi?id=208212
2066         https://trac.webkit.org/changeset/257530
2067
2068 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
2069
2070         [CMake] Use WEBKIT_EXECUTABLE in MiniBrowser
2071         https://bugs.webkit.org/show_bug.cgi?id=206894
2072
2073         Reviewed by Adrian Perez de Castro.
2074
2075         Modify CMake ports to use WEBKIT_EXECUTABLE when creating their respective
2076         MiniBrowsers.
2077
2078         * MiniBrowser/gtk/CMakeLists.txt:
2079         * MiniBrowser/win/CMakeLists.txt:
2080         * MiniBrowser/wpe/CMakeLists.txt:
2081
2082 2020-02-26  Alex Christensen  <achristensen@webkit.org>
2083
2084         Remove unused WebsiteDataStore::setSourceApplicationBundleIdentifier
2085         https://bugs.webkit.org/show_bug.cgi?id=206456
2086
2087         Reviewed by Brady Eidson.
2088
2089         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2090         (TEST):
2091
2092 2020-02-26  Alex Christensen  <achristensen@webkit.org>
2093
2094         _WKUserContentWorld should be a wrapper around WKContentWorld
2095         https://bugs.webkit.org/show_bug.cgi?id=208274
2096
2097         Reviewed by Brady Eidson.
2098
2099         * TestWebKitAPI/Tests/WebKitCocoa/UserContentWorld.mm:
2100         (TEST):
2101         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
2102         (TEST):
2103
2104 2020-02-26  Ryan Haddad  <ryanhaddad@apple.com>
2105
2106         Unreviewed, rolling out r257522.
2107
2108         Caused 16 API test failures on the bots
2109
2110         Reverted changeset:
2111
2112         "TestWebKitAPI and WebKitTestRunner should have bundle
2113         identifiers"
2114         https://bugs.webkit.org/show_bug.cgi?id=208260
2115         https://trac.webkit.org/changeset/257522
2116
2117 2020-02-26  Alex Christensen  <achristensen@webkit.org>
2118
2119         Add SPI to query WKFrameInfos in a WKWebView
2120         https://bugs.webkit.org/show_bug.cgi?id=208212
2121
2122         Reviewed by Brady Eidson.
2123
2124         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2125         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp: Removed.
2126         * WebKitTestRunner/TestController.cpp:
2127         (WTR::TestController::saltForOrigin):
2128
2129 2020-02-26  Kate Cheney  <katherine_cheney@apple.com>
2130
2131         TestWebKitAPI and WebKitTestRunner should have bundle identifiers
2132         https://bugs.webkit.org/show_bug.cgi?id=208260
2133         <rdar://problem/59820107>
2134
2135         Reviewed by Tim Horton.
2136
2137         Followed instructions for adding an Info.plist for Single-File Tools
2138         found on https://developer.apple.com/library/archive/documentation/Security/Conceptual/CodeSigningGuide/Procedures/Procedures.html
2139
2140         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2141         * TestWebKitAPI/Info.plist: Added.
2142         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2143         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2144         * WebKitTestRunner/Info.plist: Added.
2145         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2146
2147 2020-02-26  Kate Cheney  <katherine_cheney@apple.com>
2148
2149         Tests should each use a unique ResourceLoadStatistics file path for its database store
2150         https://bugs.webkit.org/show_bug.cgi?id=208206
2151         <rdar://problem/59690272>
2152
2153         Reviewed by Brady Eidson.
2154
2155         Initialize a default website data store before checking for the ITP
2156         store to ensure the directory exists after the file has been deleted.
2157
2158         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2159         (TEST):
2160
2161 2020-02-26  Christopher Reid  <chris.reid@sony.com>
2162
2163         [Win] Implement NetworkCache::Data by using FileSystem::MappedFileData
2164         https://bugs.webkit.org/show_bug.cgi?id=197684
2165         <rdar://problem/59467397>
2166
2167         Reviewed by Yusuke Suzuki.
2168
2169         Add test for FileSystem::createFile
2170
2171         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
2172
2173 2020-02-26  Aakash Jain  <aakash_jain@apple.com>
2174
2175         [ews] commit-queue should verify patch committer and reviewer
2176         https://bugs.webkit.org/show_bug.cgi?id=206532
2177
2178         Reviewed by Jonathan Bedard.
2179
2180         * BuildSlaveSupport/ews-build/steps.py:
2181         (ValidateCommiterAndReviewer): Build step to validate patch commiter and reviewer.
2182         (ValidateCommiterAndReviewer._addToLog):
2183         (ValidateCommiterAndReviewer.getResultSummary):
2184         (ValidateCommiterAndReviewer.fail_build):
2185         (ValidateCommiterAndReviewer.load_contributors): Load contributors information.
2186         (ValidateCommiterAndReviewer.is_reviewer):
2187         (ValidateCommiterAndReviewer.is_committer):
2188         (ValidateCommiterAndReviewer.full_name_from_email):
2189         (ValidateCommiterAndReviewer.start):
2190
2191 2020-02-26  Daniel Bates  <dabates@apple.com>
2192
2193         [iOS] Send focus update immediately on becoming or resigning first responder
2194         https://bugs.webkit.org/show_bug.cgi?id=208082
2195         <rdar://problem/59688413>
2196
2197         Rubber-stamped by Jer Noble.
2198
2199         Add a test to ensure that selecting a position at a point after the web view
2200         becomes first responder is allowed. Such an operation is only allowed if the
2201         web view is focused.
2202
2203         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
2204         (-[TestWKWebView selectPositionAtPoint:]):
2205         (TEST):
2206         * TestWebKitAPI/ios/UIKitSPI.h: Forward declare SPI.
2207
2208 2020-02-26  Chris Dumez  <cdumez@apple.com>
2209
2210         Unreviewed, disable new DragAndDropTests.DragAndDropOnEmptyView API test on iOS.
2211
2212         The test was added for macOS and times out on iOS.
2213
2214         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
2215         (TEST):
2216
2217 2020-02-26  Youenn Fablet  <youenn@apple.com>
2218
2219         Use WebPageProxy preferences for capture instead of WebProcessPool configuration parameters
2220         https://bugs.webkit.org/show_bug.cgi?id=208238
2221
2222         Reviewed by Eric Carlson.
2223
2224         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2225         (TEST):
2226         Remove use of deleted parameter.
2227
2228 2020-02-25  Devin Rousso  <drousso@apple.com>
2229
2230         Web Inspector: safari app extension isolated worlds and injected files use the extension's identifier instead of its name
2231         https://bugs.webkit.org/show_bug.cgi?id=206911
2232         <rdar://problem/58026635>
2233
2234         Reviewed by Brian Burg.
2235
2236         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2237         (TestWebKitAPI::TEST):
2238         Add test for `WTF::HashSet::reserveInitialCapacity`.
2239
2240         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2241         (TestWebKitAPI::TEST):
2242         Actually check the value of `WTF::HashMap::capacity`.
2243
2244         * TestWebKitAPI/Tests/WebKitCocoa/_WKInspectorDelegate.mm: Added.
2245         (-[InspectorDelegate _webView:didAttachInspector:])
2246         (-[InspectorDelegate _webView:browserDomainEnabledForInspector:])
2247         (-[InspectorDelegate _webView:browserDomainDisabledForInspector:])
2248         (TestWebKitAPI::TEST):
2249         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2250         (-[InspectorDelegate _webView:didAttachInspector:]): Deleted.
2251         (TestWebKitAPI::TEST): Deleted.
2252
2253 2020-02-25  Matt Lewis  <jlewis3@apple.com>
2254
2255         Add checkout_root to stubrepository.py
2256         https://bugs.webkit.org/show_bug.cgi?id=208213
2257
2258         Reviewed by Jonathan Bedard.
2259
2260         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
2261         (StubRepository.__init__):
2262
2263         We are creating our own class variable for checkout_root rather than calling the parent SCM variable
2264         because when initially we left out the parent constructor due to trying to override the fact that we don't actually have a SCM.
2265
2266 2020-02-25  Daniel Bates  <dabates@apple.com>
2267
2268         TestWebKitAPI.PasteMixedContent.CopyAndPasteWithCustomPasteboardDataOnly should wait until copy operation completes
2269         https://bugs.webkit.org/show_bug.cgi?id=208214
2270
2271         Reviewed by Wenson Hsieh.
2272
2273         Wait until the copy operation completes before loading the second web view and testing paste
2274         to ensure that something was actually copied to the clipboard.
2275
2276         * TestWebKitAPI/TestWebKitAPI.xcodeproj/xcshareddata/xcschemes/TestWebKitAPI.xcscheme:
2277         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
2278         (TestWebKitAPI::TEST): Substitute -_synchronouslyExecuteEditCommand for -_executeEditCommand
2279         so that we wait until the command completes.
2280
2281 2020-02-25  Chris Dumez  <cdumez@apple.com>
2282
2283         REGRESSION (r256882): Can't drag an HTML file into a new (empty) Safari tab
2284         https://bugs.webkit.org/show_bug.cgi?id=208199
2285         <rdar://problem/59746887>
2286
2287         Reviewed by Alex Christensen.
2288
2289         Add API test coverage.
2290
2291         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
2292         (TEST):
2293
2294 2020-02-25  Sihui Liu  <sihui_liu@apple.com>
2295
2296         spinRunLoop should take a non-zero integer as parameter
2297         https://bugs.webkit.org/show_bug.cgi?id=208148
2298         <rdar://problem/59766682>
2299
2300         Unreviewed iOS build fix.
2301
2302         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
2303         (TestWebKitAPI::Util::spinRunLoop):
2304
2305 2020-02-25  Sihui Liu  <sihui_liu@apple.com>
2306
2307         spinRunLoop should take a non-zero integer as parameter
2308         https://bugs.webkit.org/show_bug.cgi?id=208148
2309
2310         Reviewed by Darin Adler.
2311
2312         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2313         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2314         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
2315         (TestWebKitAPI::Util::spinRunLoop):
2316
2317 2020-02-24  Yusuke Suzuki  <ysuzuki@apple.com>
2318
2319         [WTF] Add tests for CompactRefPtrTuple
2320         https://bugs.webkit.org/show_bug.cgi?id=208172
2321
2322         Reviewed by Darin Adler.
2323
2324         We copy tests from RefPtr for CompactRefPtrTuple to ensure that it is working correctly.
2325         Many of tests are not necessary since currently CompactRefPtrTuple is non-copyable / non-movable.
2326
2327         * TestWebKitAPI/CMakeLists.txt:
2328         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2329         * TestWebKitAPI/Tests/WTF/CompactRefPtrTuple.cpp: Added.
2330         (TestWebKitAPI::TEST):
2331
2332 2020-02-24  Aakash Jain  <aakash_jain@apple.com>
2333
2334         [ews] commit-queue should check that patch have appropriate review flag
2335         https://bugs.webkit.org/show_bug.cgi?id=208138
2336
2337         Reviewed by Jonathan Bedard.
2338
2339         * BuildSlaveSupport/ews-build/steps.py:
2340         (BugzillaMixin._is_patch_obsolete): Drive-by fix to set build properties for patch author, commiter and reviewer.
2341         (BugzillaMixin._is_patch_cq_plus):
2342         (BugzillaMixin._does_patch_have_acceptable_review_flag): Method to check if patch have r? or r- flag.
2343         (ValidatePatch.start):
2344
2345 2020-02-24  Jiewen Tan  <jiewen_tan@apple.com>
2346
2347         [WebAuthn] Implement SPI for the platform authenticator
2348         https://bugs.webkit.org/show_bug.cgi?id=208087
2349         <rdar://problem/59369305>
2350
2351         Reviewed by Brent Fulgham.
2352
2353         Besides adding API tests, this patch also teaches TestWebKitAPI to use restricted entitlements.
2354
2355         * TestWebKitAPI/Configurations/TestWebKitAPI-macOS.entitlements:
2356         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2357         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2358         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
2359         (-[TestWebAuthenticationPanelDelegate panel:updateWebAuthenticationPanel:]):
2360         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:completionHandler:]):
2361         (-[TestWebAuthenticationPanelDelegate panel:verifyUserWithAccessControl:completionHandler:]):
2362         (TestWebKitAPI::TEST):
2363         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion.html.
2364         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-duplicate-credential.html: Added.
2365         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-error.html: Added.
2366         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la.html: Added.
2367
2368 2020-02-24  Yusuke Suzuki  <ysuzuki@apple.com>
2369
2370         Unreviewed, updating LLDB test for CompactPointerTuple.
2371         https://bugs.webkit.org/show_bug.cgi?id=207827
2372
2373         * lldb/lldb_webkit.py:
2374         (WTFCompactPointerTupleProvider):
2375         (WTFCompactPointerTupleProvider.update):
2376
2377 2020-02-24  Ellie Epskamp-Hunt  <eepskamphunt@apple.com>
2378
2379         Provide alternate way to name Web Content process
2380         https://bugs.webkit.org/show_bug.cgi?id=205224
2381         rdar://57038084
2382
2383         Reviewed by Alex Christensen.
2384
2385         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2386         * TestWebKitAPI/Tests/WebKitCocoa/DisplayName.mm: Added.
2387         (TestWebKitAPI::TEST):
2388
2389 2020-02-24  Jonathan Bedard  <jbedard@apple.com>
2390
2391         results.webkit.org: Link to result archives
2392         https://bugs.webkit.org/show_bug.cgi?id=207646
2393         <rdar://problem/59395807>
2394
2395         Rubber-stamped by Aakash Jain.
2396
2397         * resultsdbpy/resultsdbpy/view/static/js/archiveRouter.js: Added.
2398         (_ArchiveRouter): Retrieve json from archive-router endpoint.
2399         (_ArchiveRouter.prototype._determineArgumentFromAncestry): Given an argument, default and ancestry values,
2400         return the most specific value.
2401         (_ArchiveRouter.prototype.hasArchive): Check if a suite and mode have an archive link.
2402         (_ArchiveRouter.prototype.pathFor): Construct the path for archive access.
2403         (_ArchiveRouter.prototype.labelFor): Return a label for an archive link.
2404         * resultsdbpy/resultsdbpy/view/static/js/investigate.js:
2405         (parametersForInstance): Extract from lambda function.
2406         (testRunLink): Use parametersForInstance instead of a lambda function.
2407         (archiveLink): Return an archive link for data. 
2408         (contentForData): Add archive link to view.
2409         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
2410         (TimelineFromEndpoint): Accept both suite and test.
2411         (TimelineFromEndpoint.prototype.render.onDotEnterFactory): Add archive link to pop-over.
2412         * resultsdbpy/resultsdbpy/view/templates/search.html: Pass suite and test to TimelineEndpoint.
2413         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Pass suite to TimelineEndpoint.
2414         * resultsdbpy/resultsdbpy/view/view_routes.py:
2415         (ViewRoutes.__init__): Add archive_route dictionary.
2416
2417 2020-02-24  Alex Christensen  <achristensen@webkit.org>
2418
2419         WKWebViewConfiguration._corsDisablingPatterns should also disable CORS for non-DocumentThreadableLoader loading
2420         https://bugs.webkit.org/show_bug.cgi?id=208035
2421         <rdar://problem/58011337>
2422
2423         Reviewed by Tim Hatcher.
2424
2425         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
2426
2427 2020-02-22  Darin Adler  <darin@apple.com>
2428
2429         Fix some include mistakes and make some coding style tweaks to WebKit and WebKitTestRunner
2430         https://bugs.webkit.org/show_bug.cgi?id=208099
2431
2432         Reviewed by Antti Koivisto.
2433
2434         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
2435         Sorted includes the traditional way. Added an include of AccessibilityCommonMac.h
2436         so we can use the -[NSString createJSStringRef] method.
2437         (-[NSString createJSStringRef]): Deleted. This is a duplicate of the method
2438         defined in AccessibilityCommonMac.mm, and was causing a linker warning.
2439
2440 2020-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2441
2442         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html is failing in iOS 13.4 beta
2443         https://bugs.webkit.org/show_bug.cgi?id=208096
2444         <rdar://problem/59632008>
2445
2446         Reviewed by Alexey Proskuryakov.
2447
2448         In the iOS 13.4 beta, the fix for <rdar://problem/56422337> changed -[UIDatePicker setCalendar:], such that
2449         if the new calendar locale matches that of the current calendar's locale (and several other properties of the
2450         new NSCalendar are also unchanged), then the UIDatePicker's calendar will also avoid changing.
2451
2452         In our layout tests, the mechanism we use to simulate the user changing their preferred calendar is no longer
2453         compatible with the above change since the swizzled NSCalendar instance does not have a locale set, so it will
2454         default to the same locale as the one used in the original NSCalendar. This means the call to -setCalendar: ends
2455         up being a no-op, so the test fails to override the simulated Japanese calendar type with a Gregorian calendar
2456         in the credit card expiry field.
2457
2458         To fix this, additionally specify a calendar locale identifier when generating the mock NSCalendar.
2459
2460         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2461         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2462         (WTR::UIScriptController::setDefaultCalendarType):
2463         * WebKitTestRunner/TestController.h:
2464
2465         Change m_overriddenCalendarIdentifier to m_overriddenCalendarAndLocaleIdentifiers, a pair of calendar
2466         identifier and calendar locale identifier.
2467
2468         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2469         (WTR::swizzledCalendar):
2470         (WTR::TestController::overriddenCalendarIdentifier const):
2471         (WTR::TestController::overriddenCalendarLocaleIdentifier const):
2472
2473         Clean these up by returning the `NSString *` instead of making another `RetainPtr`.
2474
2475         (WTR::TestController::setDefaultCalendarType):
2476
2477         Plumb the new calendar's locale identifier through this method.
2478
2479         (WTR::TestController::cocoaResetStateToConsistentValues):
2480         (WTR::TestController::getOverriddenCalendarIdentifier const): Deleted.
2481         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
2482         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:
2483         (WTR::UIScriptControllerCocoa::setDefaultCalendarType):
2484
2485 2020-02-21  Kate Cheney  <katherine_cheney@apple.com>
2486
2487         App-bound domains should have separate Network Sessions
2488         https://bugs.webkit.org/show_bug.cgi?id=208026
2489         <rdar://problem/59434006>
2490
2491         Reviewed by Brent Fulgham.
2492
2493         This patch is mostly test infrastructure involving 3 functions.
2494         One sets in-app browser privacy as enabled in the network process
2495         manually for the test. One ensures that setting the WebView category
2496         works properly, and the last one checks for an app-bound session for
2497         an app-bound navigation.
2498
2499         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2500         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2501         (WTR::InjectedBundle::didReceiveMessageToPage):
2502         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2503         (WTR::TestRunner::getWebViewCategory):
2504         (WTR::TestRunner::callDidReceiveWebViewCategoryCallback):
2505         (WTR::TestRunner::hasAppBoundSession):
2506         (WTR::TestRunner::setInAppBrowserPrivacyEnabled):
2507         (WTR::TestRunner::callDidSetInAppBrowserPrivacyEnabledCallback):
2508         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2509         * WebKitTestRunner/TestController.cpp:
2510         (WTR::TestController::ensureViewSupportsOptionsForTest):
2511         Clearing the bundleID should happen right before setting a new one, 
2512         otherwise it clears the ID after it is set and returns a null ID.
2513
2514         (WTR::TestController::resetStateToConsistentValues):
2515         (WTR::TestController::getWebViewCategory):
2516         (WTR::InAppBrowserPrivacyCallbackContext::InAppBrowserPrivacyCallbackContext):
2517         (WTR::inAppBrowserPrivacyBooleanResultCallback):
2518         (WTR::inAppBrowserPrivacyVoidResultCallback):
2519         (WTR::TestController::hasAppBoundSession):
2520         (WTR::TestController::setInAppBrowserPrivacyEnabled):
2521         * WebKitTestRunner/TestController.h:
2522         * WebKitTestRunner/TestInvocation.cpp:
2523         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2524         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2525         (WTR::TestInvocation::didSetInAppBrowserPrivacyEnabled):
2526         (WTR::TestInvocation::didReceivePrevalentDomains):
2527         (WTR::TestInvocation::didReceiveWebViewCategory):
2528         * WebKitTestRunner/TestInvocation.h:
2529         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2530         (WTR::TestController::getWebViewCategory):
2531
2532 2020-02-21  Jonathan Bedard  <jbedard@apple.com>
2533
2534         Build DumpRenderTree and WebKitTestRunner for macCatalyst
2535         https://bugs.webkit.org/show_bug.cgi?id=208068
2536         <rdar://problem/59676596>
2537
2538         Reviewed by Tim Horton.
2539
2540         * DumpRenderTree/ios/TextInputControllerIOS.m: Import WebKitLegacy explicitly.
2541         * DumpRenderTree/mac/Configurations/Base.xcconfig: Use cocoatouch instead of SDK.
2542         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Ditto.
2543         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Ditto.
2544         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Ditto.
2545         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Ditto.
2546         * DumpRenderTree/mac/EditingDelegate.mm: Import WebKitLegacy explicitly.
2547         * DumpRenderTree/mac/EventSendingController.h: Ditto.
2548         * DumpRenderTree/mac/ObjCPlugin.m: Ditto.
2549         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Ditto.
2550         * Makefile: Add DumpRenderTree and WebKitTestRunner.
2551         * WebKitTestRunner/Configurations/Base.xcconfig: Use cocoatouch instead of SDK.
2552         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Ditto.
2553         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Ditto.
2554
2555 2020-02-21  Aakash Jain  <aakash_jain@apple.com>
2556
2557         [ews] Add build step to Validate ChangeLog for commit-queue
2558         https://bugs.webkit.org/show_bug.cgi?id=208064
2559
2560         Reviewed by Jonathan Bedard.
2561
2562         * BuildSlaveSupport/ews-build/steps.py:
2563         (ValidateChangeLogAndReviewer): Build step to validate ChangeLog.
2564         (ValidateChangeLogAndReviewer.start):
2565         (ValidateChangeLogAndReviewer.evaluateCommand): If the validation fails, comment on bug and mark patch as cq-.
2566         (SetCommitQueueMinusFlagOnPatch.start): End the build (after marking the patch cq-) if build_finish_summary property is set.
2567
2568 2020-02-21  Aakash Jain  <aakash_jain@apple.com>
2569
2570         [ews] Add build step to set cq- flag on bugzilla patch
2571         https://bugs.webkit.org/show_bug.cgi?id=208021
2572
2573         Reviewed by Jonathan Bedard.
2574
2575         * BuildSlaveSupport/ews-build/steps.py:
2576         (BugzillaMixin.set_cq_minus_flag_on_patch):
2577         (SetCommitQueueMinusFlagOnPatch):
2578         (SetCommitQueueMinusFlagOnPatch.start):
2579         (SetCommitQueueMinusFlagOnPatch.getResultSummary):
2580
2581 2020-02-20  Matt Lewis  <jlewis3@apple.com>
2582
2583         Stub repositories fail to upload some results due to missing head svn revision
2584         https://bugs.webkit.org/show_bug.cgi?id=207684
2585
2586         Reviewed by Jonathan Bedard.
2587
2588         * Scripts/webkitpy/common/host_mock.py: Added in call for creating stub repo checkout information for upload tests.
2589         (MockHost.__init__):
2590         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2591         (summarize_results): Changed call to head_svn_revision to port.commits_for_upload() to bring
2592         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2593         (SummarizedResultsTest.setUp): Added in new required parameter for testing.
2594         * Scripts/webkitpy/port/base.py:
2595         (Port.commits_for_upload): Removed the forced movement up the systems tree that prevented us 
2596         from using mock SCMs and more
2597         * Scripts/webkitpy/port/test.py: Added function to make the checkout_information.json for upload testing.
2598
2599 2020-02-21  Diego Pino Garcia  <dpino@igalia.com>
2600
2601         [JSCOnly] Add --verbose flag when running JavaScriptCore tests
2602         https://bugs.webkit.org/show_bug.cgi?id=208051
2603
2604         Reviewed by Carlos Alberto Lopez Perez.
2605
2606         Verbose flag prints out each test name executed. Without this flag
2607         stdout prints out one or two periods.
2608
2609         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2610         (RunJavaScriptCoreTests.start):
2611
2612 2020-02-21  Michael Catanzaro  <mcatanzaro@gnome.org>
2613
2614         [WPE][GTK] googleapis.com is a public suffix, defeating isGoogle() check in UserAgentQuirks.cpp
2615         https://bugs.webkit.org/show_bug.cgi?id=207984
2616
2617         Reviewed by Daniel Bates.
2618
2619         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2620         (TestWebKitAPI::TEST):
2621
2622 2020-02-20  Michael Catanzaro  <mcatanzaro@gnome.org>
2623
2624         [GTK] Improve user agent quirk for Google Docs and Google Drive
2625         https://bugs.webkit.org/show_bug.cgi?id=206506
2626
2627         Reviewed by Carlos Garcia Campos.
2628
2629         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2630         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
2631         (TestWebKitAPI::TEST):
2632
2633 2020-02-20  Fujii Hironori  <Hironori.Fujii@sony.com>
2634
2635         check-webkit-style: Check if *_EXPORT and *_EXPORT_PRIVATE macros are used under corresponding directories
2636         https://bugs.webkit.org/show_bug.cgi?id=207380
2637
2638         Reviewed by Jonathan Bedard.
2639
2640         Added a new rule 'build/export_macro'.
2641
2642         Removed a obsolete rule 'readability/webkit_export' which was used
2643         only by Chromium port (r148185).
2644
2645         * Scripts/webkitpy/style/checkers/cpp.py:
2646         (_FunctionState.export_macro):
2647         (check_function_definition):
2648         (_unix_path): Added.
2649         (is_generated_file): Use _unix_path.
2650         (check_has_config_header): Ditto.
2651         (CppChecker):
2652         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2653         (WebKitStyleTest.test_export_macro_check):
2654         (WebKitStyleTest.test_webkit_export_check): Deleted.
2655
2656 2020-02-20  Fujii Hironori  <Hironori.Fujii@sony.com>
2657
2658         [Win][MiniBrowser] Add prettier toolbar button icons
2659         https://bugs.webkit.org/show_bug.cgi?id=207999
2660
2661         Reviewed by Ross Kirsling.
2662
2663         Use a custom toolbar button icons instead of system stock icons.
2664
2665         Fixed a bug toolbar button dropdown arrows always looked being
2666         hovered. TBSTYLE_FLAT should be given.
2667
2668         Removed the window border line of Progress Indicator.
2669
2670         * MiniBrowser/win/MainWindow.cpp:
2671         (MainWindow::createToolbar):
2672         * MiniBrowser/win/MiniBrowserLib.rc:
2673         * MiniBrowser/win/MiniBrowserLibResource.h:
2674         * MiniBrowser/win/toolbar.bmp: Added.
2675
2676 2020-02-20  Aakash Jain  <aakash_jain@apple.com>
2677
2678         Update run-webkit-tests help description for skip-failing-tests
2679         https://bugs.webkit.org/show_bug.cgi?id=208031
2680
2681         Reviewed by Alexey Proskuryakov.
2682
2683         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2684
2685 2020-02-20  Chris Dumez  <cdumez@apple.com>
2686
2687         REGRESSION (r255677): Reloading tab with beforeunload prompt closes tab when asking to stay on page
2688         https://bugs.webkit.org/show_bug.cgi?id=208015
2689         <rdar://problem/59591630>
2690
2691         Reviewed by Geoffrey Garen.
2692
2693         Add API test coverage.
2694
2695         * TestWebKitAPI/Tests/WebKitCocoa/ModalAlerts.mm:
2696         (TEST):
2697
2698 2020-02-20  Tim Horton  <timothy_horton@apple.com>
2699
2700         WKWebView with non-zero origin has the wrong top content inset with NSWindowStyleMaskFullSizeContentView
2701         https://bugs.webkit.org/show_bug.cgi?id=207998
2702         <rdar://problem/40942425>
2703
2704         Reviewed by Sam Weinig.
2705
2706         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2707         * TestWebKitAPI/Tests/WebKitCocoa/TopContentInset.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm.
2708         (-[FullscreenChangeMessageHandler userContentController:didReceiveScriptMessage:]):
2709         (TestWebKitAPI::TEST):
2710         Add some tests for top content insets.
2711
2712 2020-02-20  Jonathan Bedard  <jbedard@apple.com>
2713
2714         results.webkit.org: Correctly report JSC tests for windows (Follow-up fix)
2715         https://bugs.webkit.org/show_bug.cgi?id=207910
2716
2717         Unreviewed infrastructure fix.
2718
2719         * Scripts/run-javascriptcore-tests:
2720         (configurationForUpload): Use the major version instead of the sub-minor version
2721         for version name.
2722
2723 2020-02-20  Don Olmstead  <don.olmstead@sony.com>
2724
2725         [CMake] Add WPE::libwpe target
2726         https://bugs.webkit.org/show_bug.cgi?id=207970
2727
2728         Reviewed by Adrian Perez de Castro.
2729
2730         Use the WPE::libwpe target.
2731
2732         * MiniBrowser/wpe/CMakeLists.txt:
2733         * TestWebKitAPI/PlatformWPE.cmake:
2734         * TestWebKitAPI/glib/PlatformWPE.cmake:
2735         * wpe/backends/CMakeLists.txt:
2736
2737 2020-02-19  Fujii Hironori  <Hironori.Fujii@sony.com>
2738
2739         [Win][MiniBrowser] Add 'Go Home' menu item and toolbar button
2740         https://bugs.webkit.org/show_bug.cgi?id=207749
2741
2742         Reviewed by Ross Kirsling.
2743
2744         Added "Set Default URL to Current URL" menu item like Mac MiniBrowser.
2745
2746         * MiniBrowser/win/MainWindow.cpp:
2747         (MainWindow::createToolbar):
2748         (MainWindow::WndProc):
2749         (MainWindow::setDefaultURLToCurrentURL):
2750         (MainWindow::goHome): Added.
2751         (MainWindow::onURLBarEnter):
2752         * MiniBrowser/win/MainWindow.h:
2753         * MiniBrowser/win/MiniBrowserLib.rc:
2754         * MiniBrowser/win/MiniBrowserLibResource.h:
2755         * MiniBrowser/win/MiniBrowserReplace.h:
2756         * MiniBrowser/win/WinMain.cpp:
2757         (wWinMain):
2758
2759 2020-02-19  Peng Liu  <peng.liu6@apple.com>
2760
2761         Fix check-webkit-style errors related to AVFoundationSPI.h
2762         https://bugs.webkit.org/show_bug.cgi?id=207834
2763
2764         Reviewed by Daniel Bates.
2765
2766         Revert the change in r256770 regarding the headers ordering.
2767         Headers in the same category should be in sorted order (case sensitive, as done by the command-line sort tool or the Xcode sort selection command).
2768
2769         * Scripts/webkitpy/style/checkers/cpp.py:
2770         (check_include_line):
2771
2772 2020-02-19  Jonathan Bedard  <jbedard@apple.com>
2773
2774         results.webkit.org: Correctly report JSC tests for windows
2775         https://bugs.webkit.org/show_bug.cgi?id=207910
2776
2777         Rubber-stamped by Aakash Jain.
2778
2779         * Scripts/run-javascriptcore-tests:
2780         (configurationForUpload): Give Windows a version name.
2781         * Scripts/webkitdirs.pm:
2782         (determineWinVersion): Correctly parse Windows 10 version numbers, conform to
2783         Version dictionary.
2784
2785 2020-02-19  Chris Dumez  <cdumez@apple.com>
2786
2787         Unreviewed, fix assertions in storage access API layout tests after r256882.
2788
2789         Drop dead testRunner code to toggle storage access API feature.
2790
2791         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2792         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2793         (WTR::TestRunner::setStorageAccessAPIEnabled): Deleted.
2794         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2795         * WebKitTestRunner/TestInvocation.cpp:
2796         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2797
2798 2020-02-18  Zan Dobersek  <zdobersek@igalia.com>
2799
2800         [WPE] Support 2D axis, smooth-motion events
2801         https://bugs.webkit.org/show_bug.cgi?id=207881
2802
2803         Reviewed by Carlos Garcia Campos.
2804
2805         * wpe/jhbuild.modules: Bump to a newer libwpe commit.
2806
2807 2020-02-18  Ryan Haddad  <ryanhaddad@apple.com>
2808
2809         Unreviewed, rolling out r256851.
2810
2811         Broke internal bots
2812
2813         Reverted changeset:
2814
2815         "Stub repositories fail to upload some results due to missing
2816         head svn revision"
2817         https://bugs.webkit.org/show_bug.cgi?id=207684
2818         https://trac.webkit.org/changeset/256851
2819
2820 2020-02-18  Fujii Hironori  <Hironori.Fujii@sony.com>
2821
2822         [Win][MiniBrowser] Support back/forward mouse buttons by handing APPCOMMAND_BROWSER_BACKWARD and APPCOMMAND_BROWSER_FORWARD
2823         https://bugs.webkit.org/show_bug.cgi?id=207883
2824
2825         Reviewed by Ross Kirsling.
2826
2827         Unlike other mouse buttons, 4th and 5th mouse buttons are
2828         processed differently. Clicking them dispatches WM_XBUTTONDOWN and
2829         WM_XBUTTONUP events to the window under the mouse cursor.
2830         Unhandled WM_XBUTTONUP events are automatically converted to
2831         WM_APPCOMMAND. And, unhandle WM_APPCOMMAND are propagated to the
2832         parent window.
2833         <https://docs.microsoft.com/en-us/windows/win32/inputdev/wm-appcommand>
2834
2835         Unlike other WM_* commands, WM_APPCOMMAND should return 1 if it is
2836         handled.
2837
2838         * MiniBrowser/win/BrowserWindow.h:
2839         * MiniBrowser/win/MainWindow.cpp:
2840         (MainWindow::WndProc):
2841         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2842         (WebKitBrowserWindow::navigateForwardOrBackward):
2843         * MiniBrowser/win/WebKitBrowserWindow.h:
2844         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
2845         (WebKitLegacyBrowserWindow::navigateForwardOrBackward):
2846         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
2847
2848 2020-02-18  Alex Christensen  <achristensen@webkit.org>
2849
2850         Expand WKRemoteObjectCoder supported POD types to encode NSURLResponse types
2851         https://bugs.webkit.org/show_bug.cgi?id=207912
2852         <rdar://problem/59556922>
2853
2854         Reviewed by Brian Weinstein.
2855
2856         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
2857         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
2858         (TEST):
2859         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
2860         (-[RemoteObjectRegistryPlugIn sendRequest:response:challenge:error:completionHandler:]):
2861
2862 2020-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2863
2864         [macOS] Web process may crash under ServicesOverlayController::buildPotentialHighlightsIfNeeded
2865         https://bugs.webkit.org/show_bug.cgi?id=207899
2866         <rdar://problem/55658207>
2867
2868         Reviewed by Tim Horton and Simon Fraser.
2869
2870         Make it possible to run tests on macOS with services controls enabled, via a new TestOptions flag.
2871
2872         * WebKitTestRunner/TestController.cpp:
2873         (WTR::updateTestOptionsFromTestHeader):
2874         * WebKitTestRunner/TestOptions.h:
2875         (WTR::TestOptions::hasSameInitializationOptions const):
2876         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2877         (WTR::TestController::platformCreateWebView):
2878
2879 2020-02-18  Matt Lewis  <jlewis3@apple.com>
2880
2881         Stub repositories fail to upload some results due to missing head svn revision
2882         https://bugs.webkit.org/show_bug.cgi?id=207684
2883
2884         Reviewed by Jonathan Bedard.
2885
2886         * Scripts/webkitpy/api_tests/run_api_tests.py:
2887         (main): Added initializing the scm to the host object.
2888         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2889         (summarize_results): Changed call to head_svn_revision to port.commits_for_upload() to bring
2890         it in line with modern code.
2891         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2892         (main): Added inializing the scm to the host object.
2893         * Scripts/webkitpy/port/base.py:
2894         (Port.commits_for_upload): Removed the forced movement up the systems tree that prevented us
2895         from using mock SCMs and more
2896         * Scripts/webkitpy/test/main.py:
2897         (main):  Removed the forced movement up the systems tree, initialized the SCM on the host object,
2898         and converted the webkit_root variable to the SCM checkout root.
2899         (Tester._run_tests):
2900
2901 2020-02-18  Per Arne Vollan  <pvollan@apple.com>
2902
2903         Move [UIDevice currentDevice] calls to UI process
2904         https://bugs.webkit.org/show_bug.cgi?id=204320
2905
2906         Reviewed by Darin Adler.
2907
2908         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2909         * TestWebKitAPI/Tests/WebKit/LocalizedDeviceModel.mm: Added.
2910         (TEST):
2911
2912 2020-02-18  Simon Fraser  <simon.fraser@apple.com>
2913
2914         Move from "layer flush" terminology to "rendering update"
2915         https://bugs.webkit.org/show_bug.cgi?id=207870
2916
2917         Reviewed by Tim Horton.
2918
2919         Rename various functions and member variables to move away from the legacy "layer flush"
2920         terminology and instead use "rendering update", matching Page::updateRendering(). The fact
2921         that we have layers is an implementation detail.
2922         
2923         Change LayerFlushThrottlingState to be an OptionSet<>.
2924
2925         * Tracing/SystemTracePoints.plist:
2926
2927 2020-02-17  Zhifei Fang  <zhifei_fang@apple.com>
2928
2929         [Webkit.css] Adding popover style element
2930         This help to prevent us reinventing the wheel ever again
2931         https://bugs.webkit.org/show_bug.cgi?id=207787
2932
2933         Reviewed by Dean Jackson.
2934
2935         * resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml:
2936         * resultsdbpy/resultsdbpy/view/static/library/css/index.html:
2937         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
2938         (.popover):
2939         (.popover>.content):
2940         (.popover.display):
2941         (.popover .arrow):
2942         (.popover .arrow.point-top):
2943         (.popover .arrow.point-bottom):
2944         (.popover .arrow.point-left):
2945         (.popover .arrow.point-right):
2946         (@media (prefers-color-scheme: dark) .popover>.content):
2947         (@media (prefers-color-scheme: dark) .popover.display):
2948         (@media (prefers-color-scheme: dark) .popover .arrow):
2949         (.popover>.content>.section): Deleted.
2950         (.popover:focus>.content, .popover:hover>.content): Deleted.
2951         (.popover.right>.content): Deleted.
2952         (.popover.right :focus>.content, .popover.right:hover>.content): Deleted.
2953         (.popover.left>.content): Deleted.
2954         (.popover.left :focus>.content, .popover.left:hover>.content): Deleted.
2955         (.popover.bottom>.content): Deleted.
2956         (.popover.bottom :focus>.content, .popover.bottom:hover>.content): Deleted.
2957
2958 2020-02-17  Brent Fulgham  <bfulgham@apple.com>
2959
2960         Update WebKit Tools to issue mach extensions as needed
2961         https://bugs.webkit.org/show_bug.cgi?id=207850
2962         <rdar://problem/59521019>
2963
2964         Reviewed by Per Arne Vollan.
2965
2966         Revise the codesign settings for our testing tools to allow the process to vend mach extensions
2967         to its child processes (WebContent, GPU, Network, etc.) as needed.
2968
2969         * MiniBrowser/MiniBrowser.entitlements:
2970         * TestWebKitAPI/Configurations/TestWebKitAPI-macOS.entitlements: Added.
2971         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2972         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2973         * WebKitTestRunner/Configurations/WebKitTestRunner.entitlements:
2974
2975 2020-02-17  Peng Liu  <peng.liu6@apple.com>
2976
2977         Fix check-webkit-style errors related to AVFoundationSPI.h
2978         https://bugs.webkit.org/show_bug.cgi?id=207834
2979
2980         Reviewed by Eric Carlson.
2981
2982         We need to use case-insensitive comparison to check whether the headers are alphabetically sorted in each header section.
2983         Soft-link headers can be included as either "file.h" or <file.h>.
2984
2985         * Scripts/webkitpy/style/checkers/cpp.py:
2986         (_classify_include):
2987         (check_include_line):
2988
2989 2020-02-17  Keith Rollin  <krollin@apple.com>
2990
2991         Unreviewed build fix after r256715.
2992
2993         Fix tvOS and watchOS builds.
2994
2995         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
2996
2997 2020-02-17  Per Arne Vollan  <pvollan@apple.com>
2998
2999         Use CF prefs direct mode in the WebContent process
3000         https://bugs.webkit.org/show_bug.cgi?id=203420
3001
3002         Reviewed by Brent Fulgham.
3003
3004         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3005         * TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm: Added.
3006         (TEST):
3007
3008 2020-02-17  Aakash Jain  <aakash_jain@apple.com>
3009
3010         EWS should be able to file Bugzilla bugs
3011         https://bugs.webkit.org/show_bug.cgi?id=207845
3012
3013         Reviewed by Alexey Proskuryakov.
3014
3015         * BuildSlaveSupport/ews-build/steps.py:
3016         (BugzillaMixin.create_bug): Method to file bugzilla bug using bugzilla REST API.
3017
3018 2020-02-17  Aakash Jain  <aakash_jain@apple.com>
3019
3020         EWS should be able to comment on Bugzilla
3021         https://bugs.webkit.org/show_bug.cgi?id=201927
3022
3023         Reviewed by Jonathan Bedard.
3024
3025         * BuildSlaveSupport/ews-build/steps.py:
3026         (BugzillaMixin.comment_on_bug): Method to comment on bugzilla bug.
3027         (BugzillaMixin.remove_flags_on_patch): Drive-by fix to correctly identify failure based on status code.
3028         (BugzillaMixin.close_bug): Ditto.
3029         (CommentOnBug): Build step to comment on bugzilla bug.
3030
3031 2020-02-17  Antti Koivisto  <antti@apple.com>
3032
3033         [macOS] Add trace points for layer flush runloop observer
3034         https://bugs.webkit.org/show_bug.cgi?id=207837
3035
3036         Reviewed by Sam Weinig.
3037
3038         * Tracing/SystemTracePoints.plist:
3039
3040 2020-02-17  Don Olmstead  <don.olmstead@sony.com>
3041
3042         [CMake] Use builtin targets
3043         https://bugs.webkit.org/show_bug.cgi?id=205166
3044
3045         Reviewed by Darin Adler.
3046
3047         * TestWebKitAPI/PlatformWin.cmake:
3048
3049 2020-02-17  Aakash Jain  <aakash_jain@apple.com>
3050
3051         [ews] add SetBuildSummary step for Windows EWS
3052         https://bugs.webkit.org/show_bug.cgi?id=207556
3053
3054         Reviewed by Jonathan Bedard.
3055
3056         * BuildSlaveSupport/ews-build/factories.py:
3057         (WindowsFactory.__init__):
3058         (GTKBuildAndTestFactory.__init__):
3059         * BuildSlaveSupport/ews-build/factories_unittest.py:
3060         (TestBuildAndTestsFactory.test_windows_factory): Added unit-test.
3061
3062 2020-02-17  Alberto Garcia  <berto@igalia.com>
3063
3064         [WPE] Change the QML plugin install path
3065         https://bugs.webkit.org/show_bug.cgi?id=207761
3066
3067         Reviewed by Philippe Normand.
3068
3069         * Scripts/run-qt-wpe-minibrowser:
3070         * glib/api_test_runner.py:
3071         (TestRunner._run_test_qt):
3072
3073 2020-02-16  Fujii Hironori  <Hironori.Fujii@sony.com>
3074
3075         Remove remaining WTF_EXPORT and WTF_IMPORT by replacing them with WTF_EXPORT_DECLARATION and WTF_IMPORT_DECLARATION
3076         https://bugs.webkit.org/show_bug.cgi?id=207746
3077
3078         Reviewed by Don Olmstead.
3079
3080         * MiniBrowser/win/stdafx.h:
3081
3082 2020-02-16  Brady Eidson  <beidson@apple.com>
3083
3084         Expose "allowsContentJavaScript" on WKWebpagePreferences
3085         <rdar://problem/51534967> and https://bugs.webkit.org/show_bug.cgi?id=207427
3086
3087         Reviewed by Darin Adler.
3088
3089         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
3090         (TEST):
3091         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3092         (-[WebsitePoliciesNavigationDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
3093         (TEST):
3094         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:preferences:userInfo:decisionHandler:]): Deleted.
3095         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3096         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3097         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
3098         (-[TestNavigationDelegate waitForDidFinishNavigationWithPreferences:]):
3099         (-[WKWebView _test_waitForDidFinishNavigationWithPreferences:]):
3100         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
3101         * TestWebKitAPI/cocoa/TestWKWebView.h:
3102         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3103         (-[WKWebView synchronouslyLoadHTMLString:preferences:]):
3104
3105 2020-02-14  Yusuke Suzuki  <ysuzuki@apple.com>
3106
3107         NetworkLoadMetrics should be shared by multiple ResourceResponse instances
3108         https://bugs.webkit.org/show_bug.cgi?id=207747
3109
3110         Reviewed by Keith Miller.
3111
3112         * TestWebKitAPI/Tests/WebCore/ParsedContentRange.cpp:
3113         (TestWebKitAPI::TEST):
3114
3115 2020-02-14  Alex Christensen  <achristensen@webkit.org>
3116
3117         Allow UIDNAInfo.errors from uidna_nameToUnicode that would not cause URL parsing failures
3118         https://bugs.webkit.org/show_bug.cgi?id=207360
3119         <rdar://problem/57825317>
3120
3121         Reviewed by Ryosuke Niwa.
3122
3123         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
3124         (TestWebKitAPI::TEST):
3125
3126 2020-02-14  Don Olmstead  <don.olmstead@sony.com>
3127
3128         [CMake] Add Fontconfig::Fontconfig target
3129         https://bugs.webkit.org/show_bug.cgi?id=207730
3130
3131         Reviewed by Adrian Perez de Castro.
3132
3133         Use the Fontconfig::Fontconfig target.
3134
3135         * WebKitTestRunner/PlatformGTK.cmake:
3136
3137 2020-02-13  Kate Cheney  <katherine_cheney@apple.com>
3138
3139          Expose prevalent domains on a per-page basis
3140          https://bugs.webkit.org/show_bug.cgi?id=207523
3141          <rdar://problem/59270758>
3142
3143         Reviewed by Chris Dumez.
3144
3145         Added WebKitTestRunner functions so this functionality can be tested.
3146         clearPrevalentDomains should be called between tests to reset the
3147         state.
3148
3149         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3150         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3151         (WTR::InjectedBundle::didReceiveMessageToPage):
3152         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3153         (WTR::TestRunner::getPrevalentDomains):
3154         (WTR::TestRunner::callDidReceivePrevalentDomainsCallback):
3155         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3156         * WebKitTestRunner/TestController.cpp:
3157         (WTR::TestController::resetStateToConsistentValues):
3158         (WTR::TestController::getPrevalentDomains):
3159         (WTR::TestController::clearPrevalentDomains):
3160         * WebKitTestRunner/TestController.h:
3161         * WebKitTestRunner/TestInvocation.cpp:
3162         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3163         (WTR::TestInvocation::didReceivePrevalentDomains):
3164         * WebKitTestRunner/TestInvocation.h:
3165         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3166         (WTR::TestController::getPrevalentDomains):
3167         (WTR::TestController::clearPrevalentDomains):
3168
3169 2020-02-13  Fujii Hironori  <Hironori.Fujii@sony.com>
3170
3171         [Win][MiniBrowser] Reimplement the toolbar by using toolbar common control
3172         https://bugs.webkit.org/show_bug.cgi?id=207682
3173
3174         Reviewed by Ross Kirsling.
3175
3176         The toolbar placed button common controls as the toolbar buttons.
3177         However, because these buttons are focusable, shortcut keys don't
3178         work after clicking them.
3179
3180         Added Home button, Add to Bookmarks button, dropdown buttons of
3181         back and forward buttons, but they aren't implemented yet. Just
3182         placeholders at the moment.
3183
3184         * MiniBrowser/win/MainWindow.cpp:
3185         (MainWindow::createToolbar): Added.
3186         (MainWindow::resizeToolbar): Added.
3187         (MainWindow::rescaleToolbar): Added.
3188         (MainWindow::init):
3189         (MainWindow::resizeSubViews):
3190         (MainWindow::updateDeviceScaleFactor):
3191         * MiniBrowser/win/MainWindow.h: Added m_toolbarItemsWidth.
3192
3193 2020-02-13  Ryosuke Niwa  <rniwa@webkit.org>
3194
3195         Dark Mode: In Notes, list item becomes invisible in dark mode after outdenting
3196         https://bugs.webkit.org/show_bug.cgi?id=207676
3197
3198         Reviewed by Wenson Hsieh and Timothy Hatcher.
3199
3200         Added regression tests for pasting content with -apple-system-label and outdenting content.
3201
3202         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
3203         (PasteHTML.TransformColorsOfDarkContentButNotSemanticColor):
3204         (PasteHTML.DoesNotTransformColorsOfLightContentDuringOutdent):
3205
3206 2020-02-13  Alex Christensen  <achristensen@webkit.org>
3207
3208         _WKResourceLoadInfo should conform to NSSecureCoding
3209         https://bugs.webkit.org/show_bug.cgi?id=207667
3210
3211         Reviewed by Brady Eidson.
3212
3213         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
3214         (TEST):
3215
3216 2020-02-13  Stephan Szabo  <stephan.szabo@sony.com>
3217
3218         [PlayStation] Add Buildbots for Debug/Release builds
3219         https://bugs.webkit.org/show_bug.cgi?id=199454
3220
3221         Reviewed by Aakash Jain.
3222
3223         * BuildSlaveSupport/build.webkit.org-config/config.json:
3224         Add PlayStation slaves, builders
3225         * BuildSlaveSupport/build.webkit.org-config/factories.py:
3226         Use higher timeout for playstation as with win bot
3227         * BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
3228         Set PlayStation category for playstation platform
3229         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3230         Use same path as gtk, wincairo, etc for appendCustomBuildFlags
3231         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3232         Add PlayStation expectations
3233
3234 2020-02-13  Per Arne Vollan  <pvollan@apple.com>
3235
3236         [iOS] Check if PIP is supported in the UI process
3237         https://bugs.webkit.org/show_bug.cgi?id=207406
3238
3239         Reviewed by Brent Fulgham.
3240
3241         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3242         * TestWebKitAPI/Tests/WebKit/PictureInPictureSupport.mm: Added.
3243         (TEST):
3244
3245 2020-02-13  Jonathan Bedard  <jbedard@apple.com>
3246
3247         TestWebKitAPI: Conditionalize fullscreen tests on fullscreen API
3248         https://bugs.webkit.org/show_bug.cgi?id=207397
3249         <rdar://problem/59268128>
3250
3251         Reviewed by Jer Noble.
3252
3253         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
3254         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm:
3255
3256 2020-02-13  Jonathan Bedard  <jbedard@apple.com>
3257
3258         TestWebKitAPI: Re-baseline DocumentEditingContext for Catalyst
3259         https://bugs.webkit.org/show_bug.cgi?id=207696
3260
3261         Reviewed by Tim Horton.
3262
3263         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3264
3265 2020-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3266
3267         [iOS] -updateSelectionWithExtentPoint:completionHandler: should work without requiring floating cursor
3268         https://bugs.webkit.org/show_bug.cgi?id=207680
3269         <rdar://problem/59340940>
3270
3271         Reviewed by Tim Horton.
3272
3273         Add a new API test to verify that calling -updateSelectionWithExtentPoint:completionHandler: with a point behind
3274         the current selection works.
3275
3276         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
3277         (-[TestWKWebView updateSelectionWithExtentPoint:]):
3278         * TestWebKitAPI/ios/UIKitSPI.h:
3279
3280 2020-02-13  Said Abou-Hallawa  <said@apple.com>
3281
3282         Unreviewed, rolling out r255158, 255405 and r255486
3283
3284         Caused test flakiness and PLT regression.
3285
3286         * DumpRenderTree/mac/DumpRenderTree.mm:
3287         (resetWebPreferencesToConsistentValues):
3288         * DumpRenderTree/win/DumpRenderTree.cpp:
3289         (enableExperimentalFeatures):
3290         * WebKitTestRunner/TestController.cpp:
3291         (WTR::TestController::resetPreferencesToConsistentValues):
3292
3293 2020-02-12  Jonathan Bedard  <jbedard@apple.com>
3294
3295         run-javascriptcore-tests: Allow insecure requests on upload
3296         https://bugs.webkit.org/show_bug.cgi?id=207662
3297
3298         Rubber-stamped by Aakash Jain.
3299
3300         * Scripts/run-javascriptcore-tests:
3301         (uploadResults): Allow insecure curl request when posting results.
3302
3303 2020-02-12  Truitt Savell  <tsavell@apple.com>
3304
3305         Unreviewed, rolling out r256463.
3306
3307         Caused major flakiness on Mac wk2
3308
3309         Reverted changeset:
3310
3311         "REGRESSION (r255158): http/tests/frame-throttling/raf-
3312         throttle-in-cross-origin-subframe.html is a flaky failure"
3313         https://bugs.webkit.org/show_bug.cgi?id=206839
3314         https://trac.webkit.org/changeset/256463
3315
3316 2020-02-12  Jonathan Bedard  <jbedard@apple.com>
3317
3318         results.webkit.org: Remove debug JS logging
3319         https://bugs.webkit.org/show_bug.cgi?id=207663
3320
3321         Reviewed by Aakash Jain.
3322
3323         * resultsdbpy/resultsdbpy/view/static/js/investigate.js:
3324         (elapsed):
3325         * resultsdbpy/resultsdbpy/view/static/js/tooltip.js:
3326         (_ToolTip.prototype.toString):
3327         * resultsdbpy/resultsdbpy/view/static/library/js/Ref.js:
3328         (prototype.addWithDelay):
3329         * resultsdbpy/resultsdbpy/view/templates/archive_list.html:
3330
3331 2020-02-12  Simon Fraser  <simon.fraser@apple.com>
3332
3333         Remove CSS_DEVICE_ADAPTATION
3334         https://bugs.webkit.org/show_bug.cgi?id=203479
3335
3336         Reviewed by Tim Horton.
3337         
3338         CSS Working Group resolved to remove @viewport <https://github.com/w3c/csswg-drafts/issues/4766>,
3339         so remove the code.
3340
3341         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3342
3343 2020-02-12  Said Abou-Hallawa  <said@apple.com>
3344
3345         REGRESSION (r255158): http/tests/frame-throttling/raf-throttle-in-cross-origin-subframe.html is a flaky failure
3346         https://bugs.webkit.org/show_bug.cgi?id=206839
3347
3348         Reviewed by Simon Fraser.
3349
3350         Remove the WKPreference key 'RenderingUpdateThrottlingEnabled'.
3351
3352         * DumpRenderTree/mac/DumpRenderTree.mm:
3353         (resetWebPreferencesToConsistentValues):
3354         * DumpRenderTree/win/DumpRenderTree.cpp:
3355         (enableExperimentalFeatures):
3356         * WebKitTestRunner/TestController.cpp:
3357         (WTR::TestController::resetPreferencesToConsistentValues):
3358
3359 2020-02-12  Jonathan Bedard  <jbedard@apple.com>
3360
3361         results.webkit.org: Cache archive content
3362         https://bugs.webkit.org/show_bug.cgi?id=207589
3363
3364         Reviewed by Aakash Jain.
3365
3366         * resultsdbpy/resultsdbpy/flask_support/util.py:
3367         (cache_for): Add decorator function which sets the cache values on the returned response.
3368         * resultsdbpy/resultsdbpy/view/archive_view.py:
3369         (ArchiveView): Cache archive content client-side for 12 hours.
3370         * resultsdbpy/resultsdbpy/view/archive_view_unittest.py:
3371         (ArchiveViewUnittest.test_file): Verify that archived content is cached.
3372
3373 2020-02-12  Youenn Fablet  <youenn@apple.com>
3374
3375         WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
3376         https://bugs.webkit.org/show_bug.cgi?id=207537
3377
3378         Reviewed by Chris Dumez.
3379
3380         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3381
3382 2020-02-11  Rob Buis  <rbuis@igalia.com>
3383
3384         Bug 207424: Crash in WebCore::ParsedContentType::parseContentType when parsing invalid MIME type
3385         <https://webkit.org/b/207424>
3386         <rdar://problem/59250384>
3387
3388         Reviewed by Rob Buis.
3389
3390         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3391         (TestWebKitAPI::TEST): Add more tests.
3392
3393 2020-02-11  Commit Queue  <commit-queue@webkit.org>
3394
3395         Unreviewed, rolling out r256314.
3396         https://bugs.webkit.org/show_bug.cgi?id=207594
3397
3398         It is breaking an API test (Requested by youenn on #webkit).
3399
3400         Reverted changeset:
3401
3402         "WebSWServerConnection::registerServiceWorkerClient is not
3403         sending IPC message to UIProcess when it should"
3404         https://bugs.webkit.org/show_bug.cgi?id=207537
3405         https://trac.webkit.org/changeset/256314
3406
3407 2020-02-11  Jonathan Bedard  <jbedard@apple.com>
3408
3409         results.webkit.org: Configuration documentation should include architecture
3410         https://bugs.webkit.org/show_bug.cgi?id=207584
3411
3412         Reviewed by Aakash Jain.
3413
3414         * resultsdbpy/resultsdbpy/view/templates/documentation.html: Add architecture documentation.
3415
3416 2020-02-11  Youenn Fablet  <youenn@apple.com>
3417
3418         Regression: RTCRtpSender.getCapabilities("video") returns null on iOS 13.4 (17E5223h)
3419         https://bugs.webkit.org/show_bug.cgi?id=207325
3420         <rdar://problem/59224810>
3421
3422         Reviewed by Eric Carlson.
3423
3424         * TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:
3425         (TestWebKitAPI::TEST):
3426         Add a test validating that RTCRtpSender.getCapabilities does not return null.
3427         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
3428
3429 2020-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3430
3431         KeyboardInputTests.SupportsImagePaste fails on recent versions of UIKit
3432         https://bugs.webkit.org/show_bug.cgi?id=207557
3433
3434         Reviewed by Jonathan Bedard.
3435
3436         The exception occurs because UIKit attempts to create a QoS interval upon setting the initially selected row in
3437         a UITableView when we focus a date picker. This fails because TestWebKitAPI isn't actually an app, so the call
3438         to `work_interval_create` with `WORK_INTERVAL_TYPE_CA_CLIENT` as the option flag fails. For the time being, work
3439         around this by focusing an empty select element instead (for which we won't attempt to create and select any
3440         table view cells).
3441
3442         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3443
3444 2020-02-11  Alex Christensen  <achristensen@webkit.org>
3445
3446         Add WKHTTPCookieStore._getCookiesForURL SPI
3447         https://bugs.webkit.org/show_bug.cgi?id=207527
3448
3449         Reviewed by Brady Eidson.
3450
3451         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
3452         (TEST):
3453
3454 2020-02-11  Youenn Fablet  <youenn@apple.com>
3455
3456         WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
3457         https://bugs.webkit.org/show_bug.cgi?id=207537
3458
3459         Reviewed by Chris Dumez.
3460
3461         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3462
3463 2020-02-11  Lauro Moura  <lmoura@igalia.com>
3464
3465         [WPE][WebDriver] MiniBrowser should react to close session commands
3466         https://bugs.webkit.org/show_bug.cgi?id=207529
3467
3468         Reviewed by Carlos Garcia Campos.
3469
3470         WebDriver delete session command asks to close the WebView associated to the
3471         current automation session. We must react to it to avoid lots of
3472         timeouts and errors.
3473
3474         * MiniBrowser/wpe/main.cpp:
3475         (main): Listen to "close" signal on the main WebView.
3476
3477 2020-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3478
3479         [iOS] Non-internal API test runners frequently crash due to Objective-C exceptions
3480         https://bugs.webkit.org/show_bug.cgi?id=207525
3481         <rdar://problem/59110543>
3482
3483         Reviewed by Tim Horton.
3484
3485         After the fix for <rdar://problem/56301207>, some scroll view content offset changes will attempt to call into
3486         CoreAnalytics API to try and report data about scrolling velocities. In the iOS 13.3 simulator, this involves
3487         creating a dictionary, of which one of the keys is the bundle identifier of the application. The value is
3488         unconditionally inserted into the dictionary. Since TestWebKitAPI does not run in the context of a
3489         UIApplication, the bundle identifier (that is, `NSBundle.mainBundle.bundleIdentifier`) ends up being nil,
3490         causing us to crash upon trying to create the dictionary.
3491
3492         While it would make things easier, we can't just swizzle -bundleIdentifier for the entirely of every test, since
3493         some tests expect the bundle identifier to be nil (or call into system frameworks that expect the bundle
3494         identifier to be nil). These tests fail or time out when -bundleIdentifier is unconditionally swizzled
3495         throughout the test run. To work around this bug for the time being, simply pretend that we have a bundle
3496         identifier when running API tests on iOS, by swizzling `-[NSBundle bundleIdentifier]` to return a string at the
3497         beginning of each API test.
3498
3499         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3500         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3501         (overrideBundleIdentifier):
3502
3503         Move this to the top of the file, so it can be shared.
3504
3505         (+[WKWebView initialize]):
3506
3507         At the start of each test, force UIKit to cache a fake value for `_UIMainBundleIdentifier()` by invoking an
3508         internal class method that calls into the internal helper function, with no other side effects.
3509
3510         * TestWebKitAPI/ios/UIKitSPI.h:
3511
3512 2020-02-10  Jonathan Bedard  <jbedard@apple.com>
3513
3514         TestWebKitAPI: Support ClipboardTests.ReadMultipleItems on Catalyst
3515         https://bugs.webkit.org/show_bug.cgi?id=207501
3516         <rdar://problem/59323414>
3517
3518         Reviewed by Alex Christensen.
3519
3520         * TestWebKitAPI/Tests/WebKitCocoa/ClipboardTests.mm:
3521         (writeMultipleObjectsToPlatformPasteboard): All iOS family ports should have
3522         The same behavior.
3523
3524 2020-02-10  Alan Sien Wei Hshieh  <hshieh@apple.com>
3525
3526         Add a variant of -[WKWebViewPrivate _getContentsAsStringWithCompletionHandler:] that includes contents from subframes
3527         https://bugs.webkit.org/show_bug.cgi?id=207352
3528         <rdar://problem/59115798>
3529
3530         Reviewed by Alex Christensen.
3531
3532         Add a test to exercise the new SPI.
3533
3534         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm: Add a test for getting text from all frames with
3535         a webpage that contains text in subframes.
3536
3537
3538 2020-02-10  Per Arne Vollan  <pvollan@apple.com>
3539
3540         [iOS] Crash when granting access to asset services
3541         https://bugs.webkit.org/show_bug.cgi?id=207520
3542
3543         Reviewed by Brent Fulgham.
3544
3545         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3546         * TestWebKitAPI/Tests/WebKit/GrantAccessToMobileAssets.mm: Added.
3547         (TEST):
3548
3549 2020-02-10  Chris Dumez  <cdumez@apple.com>
3550
3551         [DRT] InternalSettingsGenerated::resetToConsistentState() may override TestOptions
3552         https://bugs.webkit.org/show_bug.cgi?id=207481
3553
3554         Reviewed by Alexey Proskuryakov.
3555
3556         InternalSettingsGenerated::resetToConsistentState() may override TestOptions such as enableBackForwardCache.
3557         This is causing issues such as the back/forward cache sometimes getting enabled on tests where
3558         TestOptions::enableBackForwardCache() is false, because a previous test has enabled the back/forward cache.
3559
3560         * DumpRenderTree/mac/DumpRenderTree.mm:
3561         (resetWebViewToConsistentStateBeforeTesting):
3562         Make sure we reset preferences after we call WebCoreTestSupport::resetInternalsObject(), since
3563         resetInternalsObject() updates settings and TestOptions / DRT preferences should have priority
3564         over internal settings.
3565
3566 2020-02-10  Per Arne Vollan  <pvollan@apple.com>
3567
3568         [watchOS] Notification listener is never unregistered
3569         https://bugs.webkit.org/show_bug.cgi?id=207459
3570
3571         Reviewed by Maciej Stachowiak.
3572
3573         Add a test which tests that posting a backlight level change notification will not cause a crash.
3574
3575         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3576         * TestWebKitAPI/Tests/WebKit/BacklightLevelNotification.mm: Added.
3577         (TEST):
3578
3579 2020-02-10  James Howard  <jameshoward@mac.com>
3580
3581         Standard gamepad mapping for GameControllerGamepads
3582         https://bugs.webkit.org/show_bug.cgi?id=206033
3583
3584         Reviewed by Dean Jackson.
3585
3586         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3587         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3588         (WTR::TestRunner::setMockGamepadDetails):
3589         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3590         * WebKitTestRunner/TestInvocation.cpp:
3591         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3592
3593 2020-02-10  Aakash Jain  <aakash_jain@apple.com>
3594
3595         [ews] Display flaky layout test names in build summary
3596         https://bugs.webkit.org/show_bug.cgi?id=207504
3597
3598         Reviewed by Jonathan Bedard.
3599
3600         * BuildSlaveSupport/ews-build/steps.py:
3601         (ReRunWebKitTests.evaluateCommand): Drive-by fix to correct the pluralization.
3602         (AnalyzeLayoutTestsResults.report_pre_existing_failures): Append the flaky failure information.
3603         (AnalyzeLayoutTestsResults.start):
3604
3605 2020-02-10  Aakash Jain  <aakash_jain@apple.com>
3606
3607         [ews] Use SetBuildSummary instead of buildFinished in Layout tests
3608         https://bugs.webkit.org/show_bug.cgi?id=207492
3609
3610         Reviewed by Jonathan Bedard.
3611
3612         * BuildSlaveSupport/ews-build/steps.py:
3613         (RunWebKitTests.evaluateCommand):
3614         (ReRunWebKitTests.evaluateCommand):
3615         (AnalyzeLayoutTestsResults.report_pre_existing_failures):
3616         * BuildSlaveSupport/ews-build/factories.py:
3617         (TestFactory.__init__):
3618
3619 2020-02-10  Truitt Savell  <tsavell@apple.com>
3620
3621         Unreviewed, rolling out r256091.
3622
3623         Broke internal builds
3624
3625         Reverted changeset:
3626
3627         "Move trivial definitions from FeatureDefines.xcconfig to
3628         PlatformEnableCocoa.h"
3629         https://bugs.webkit.org/show_bug.cgi?id=207155
3630         https://trac.webkit.org/changeset/256091
3631
3632 2020-02-10  Truitt Savell  <tsavell@apple.com>
3633
3634         Unreviewed, rolling out r256103.
3635
3636         This patch is blocking the rollout of r256091
3637
3638         Reverted changeset:
3639
3640         "Move JavaScriptCore related feature defines from
3641         FeatureDefines.xcconfig to PlatformEnableCocoa.h"
3642         https://bugs.webkit.org/show_bug.cgi?id=207436
3643         https://trac.webkit.org/changeset/256103
3644
3645 2020-02-10  Jonathan Bedard  <jbedard@apple.com>
3646
3647         results.webkit.org: Abstract archive storage solutions
3648         https://bugs.webkit.org/show_bug.cgi?id=207277
3649
3650         Rubber-stamped by Aakash Jain.
3651
3652         * resultsdbpy/resultsdbpy/model/archive_context.py:
3653         (ArchiveContext):
3654         (ArchiveContext.ArchiveMetaDataByCommit.unpack):
3655         (ArchiveContext.__init__): Add archiver member.
3656         (ArchiveContext.__enter__): archiver is a context manager.
3657         (ArchiveContext.__exit__): Ditto.
3658         (ArchiveContext.register): The archiver member owns saving an archive.
3659         (ArchiveContext.find_archive): The archiver member owns retrieving an archive.
3660         (ArchiveContext.ArchiveChunks): Move to CassandraArchiver.
3661         * resultsdbpy/resultsdbpy/model/archiver.py: Added.
3662         (Archiver): Base class for all Archiving systems.
3663         (Archiver.archive_digest): Given a file-like archive, calculate it's digest.
3664         (Archiver.archive_size): Given a file-like archive, calculate it's size.
3665         (Archiver.save):
3666         (Archiver.retrieve):
3667         * resultsdbpy/resultsdbpy/model/cassandra_archiver.py: Added.
3668         (CassandraArchiver):
3669         (CassandraArchiver.ArchiveChunks): Moved from ArchiveContext.
3670         (CassandraArchiver.__init__):
3671         (CassandraArchiver.__enter__):
3672         (CassandraArchiver.__exit__):
3673         (CassandraArchiver.save): Split the provided archive into chunks for saving, moved
3674         from ArchiveContext.
3675         (CassandraArchiver.retrieve): Retrieve an archive with the provided hash, moved
3676         from ArchiveContext.
3677
3678 2020-02-09  Lauro Moura  <lmoura@igalia.com>
3679
3680         [GTK][WPE] Expose allowTopNavigationToDataURL
3681         https://bugs.webkit.org/show_bug.cgi?id=207384
3682
3683         Reviewed by Adrian Perez de Castro.
3684
3685         Updates with new "allow-top-navigation-to-data-urls" property.
3686
3687         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3688         (testWebViewAllowModalDialogs): This test requires this property to be
3689         set.
3690         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3691         (testWebKitSettings): Added tests for getter/setter.
3692
3693 2020-02-08  Sam Weinig  <weinig@apple.com>
3694
3695         Move JavaScriptCore related feature defines from FeatureDefines.xcconfig to PlatformEnableCocoa.h
3696         https://bugs.webkit.org/show_bug.cgi?id=207436
3697
3698         Reviewed by Tim Horton.
3699
3700         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3701         Remove ENABLE_FAST_JIT_PERMISSIONS and ENABLE_FTL_JIT.
3702
3703 2020-02-08  Yusuke Suzuki  <ysuzuki@apple.com>
3704
3705         [WTF] Try using 75% load factor for HashTable
3706         https://bugs.webkit.org/show_bug.cgi?id=207183
3707
3708         Reviewed by Mark Lam.
3709
3710         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3711         (TestWebKitAPI::testInitialCapacity):
3712
3713 2020-02-08  Sam Weinig  <weinig@apple.com>
3714
3715         Move trivial definitions from FeatureDefines.xcconfig to PlatformEnableCocoa.h
3716         https://bugs.webkit.org/show_bug.cgi?id=207155
3717
3718         Reviewed by Tim Horton.
3719
3720         Move all trivial definitions (just ENABLE_FOO = ENABLE_FOO; or ENABLE_BAR = ;)
3721         from the FeatureDefines.xcconfigs to PlatformEnableCocoa.h, ensuring each one
3722         also has a default value in PlatformEnable.h
3723
3724         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3725
3726 2020-02-07  Wenson Hsieh  <wenson_hsieh@apple.com>
3727
3728         Several iOS API tests that call -makeKeyWindow assert after r255907
3729         https://bugs.webkit.org/show_bug.cgi?id=207411
3730
3731         Reviewed by Tim Horton.
3732
3733         r255907 asserted in -makeKeyWindow that the shared UIApplication exists. While this was guaranteed for all call
3734         sites of -makeKeyWindow from API tests, -makeKeyWindow may also be invoked from within UIKit code; in this case,
3735         nothing guarantees that the application has been initialized, and we end up hitting this assertion. To fix this,
3736         replace the assertion with logic to bootstrap the shared UIApplication (if it didn't already exist).
3737
3738         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3739         (TestWebKitAPI::TEST):
3740         (TestWebKitAPI::overrideBundleIdentifier): Deleted.
3741         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3742         (overrideBundleIdentifier):
3743         (setOverriddenApplicationKeyWindow):
3744
3745 2020-02-07  Jonathan Bedard  <jbedard@apple.com>
3746
3747         TestWebKitAPI: Disable legacy ActionSheet tests on Catalyst
3748         https://bugs.webkit.org/show_bug.cgi?id=207405
3749
3750         Reviewed by Wenson Hsieh.
3751
3752         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
3753
3754 2020-02-07  Alex Christensen  <achristensen@apple.com>
3755
3756         Remember if we used legacy TLS in the back/forward cache like we remember if we have only secure content
3757         https://bugs.webkit.org/show_bug.cgi?id=207409
3758         rdar://problem/59275641
3759
3760         Reviewed by Chris Dumez.
3761
3762         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
3763         (TestWebKitAPI::TEST):
3764
3765 2020-02-07  Ryan Haddad  <ryanhaddad@apple.com>
3766
3767         Unreviewed, rolling out r256051.
3768
3769         Broke internal builds.
3770
3771         Reverted changeset:
3772
3773         "Move trivial definitions from FeatureDefines.xcconfig to
3774         PlatformEnableCocoa.h"
3775         https://bugs.webkit.org/show_bug.cgi?id=207155
3776         https://trac.webkit.org/changeset/256051
3777
3778 2020-02-07  Jonathan Bedard  <jbedard@apple.com>
3779
3780         iPad testers failing to launch processes
3781         https://bugs.webkit.org/show_bug.cgi?id=207401
3782         <rdar://problem/58184777>
3783
3784         Unreviewed infrastructure fix.
3785
3786         This is a speculative fix because I've had problems reproducing this error.
3787         The only time I managed to reproduce the problem was immediately after killing the 
3788         SimulatorTrampoline and CoreSimulator.xpc processes.
3789
3790         * BuildSlaveSupport/kill-old-processes:
3791         (main): Only kill Simulator.app, not all associated simulator processes.
3792
3793 2020-02-07  Jiewen Tan  <jiewen_tan@apple.com>
3794
3795         [WebAuthn] Report CTAP Client Pin Error to clients
3796         https://bugs.webkit.org/show_bug.cgi?id=205837
3797         <rdar://problem/58356872>
3798
3799         Reviewed by Brent Fulgham.
3800
3801         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3802         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
3803         (-[TestWebAuthenticationPanelDelegate panel:updateWebAuthenticationPanel:]):
3804         (TestWebKitAPI::TEST):
3805         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-pin-auth-blocked-error.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-error.html.
3806         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-pin-invalid-error-retry.html: Added.
3807         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-auth-blocked-error.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-error.html.
3808         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-pin-auth-blocked-error.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-error.html.
3809         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-pin-auth-invalid-error-retry.html: Added.
3810         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-pin-blocked-error.html: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-error.html.
3811         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-pin-invalid-error-retry.html: Added.
3812         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-invalid-error-retry.html: Added.
3813
3814 2020-02-07  Jonathan Bedard  <jbedard@apple.com>
3815
3816         run-safari Doesn't work with the latest Xcode version and iOS
3817         https://bugs.webkit.org/show_bug.cgi?id=207394
3818
3819         Reviewed by Ryosuke Niwa.
3820
3821         * Scripts/webkitdirs.pm:
3822         (iosSimulatorRuntime): Determine the runtime from valid runtimes.
3823         (findOrCreateSimulatorForIOSDevice): iPhone 5 is unsupported, remove code.
3824
3825 2020-02-07  Daniel Bates  <dabates@apple.com>
3826
3827         Legacy WebKit: Have linkedOnOrAfter() respect the NSDefault WebKitLinkedOnOrAfterEverything and opt DumpRenderTree in
3828         https://bugs.webkit.org/show_bug.cgi?id=207366
3829
3830         Reviewed by Brent Fulgham.
3831
3832         Enable default WebKitLinkedOnOrAfterEverything in DumpRenderTree just as we do in WebKitTestRunner.
3833         This lets me put test results for Mac and iOS Legacy WebKit in the same cross-platform directory
3834         as the actual test instead of under a platform-specific directory even when the tests' behavior
3835         depends on the link-time version of WebKit.
3836
3837         Note that testing of pre-linked behavior can still be accomplished by test writers by exposing settings
3838         and toggling them in a test.
3839
3840         * DumpRenderTree/mac/DumpRenderTree.mm:
3841         (setDefaultsToConsistentValuesForTesting):
3842
3843 2020-02-03  Sam Weinig  <weinig@apple.com>
3844
3845         Move trivial definitions from FeatureDefines.xcconfig to PlatformEnableCocoa.h
3846         https://bugs.webkit.org/show_bug.cgi?id=207155
3847
3848         Reviewed by Tim Horton.
3849
3850         Move all trivial definitions (just ENABLE_FOO = ENABLE_FOO; or ENABLE_BAR = ;)
3851         from the FeatureDefines.xcconfigs to PlatformEnableCocoa.h, ensuring each one
3852         also has a default value in PlatformEnable.h
3853
3854         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3855
3856 2020-02-07  Kate Cheney  <katherine_cheney@apple.com>
3857
3858         Update WebView category name to be more accurate
3859         https://bugs.webkit.org/show_bug.cgi?id=207334
3860         <rdar://problem/59224855>
3861
3862         Reviewed by Brent Fulgham.
3863
3864         * TestWebKitAPI/Tests/WebKitCocoa/Configuration.mm:
3865         (TEST):
3866
3867 2020-02-07  Aakash Jain  <aakash_jain@apple.com>
3868
3869         [ews] add commit-queue build step to close the bug
3870         https://bugs.webkit.org/show_bug.cgi?id=207387
3871
3872         Reviewed by Jonathan Bedard.
3873
3874         * BuildSlaveSupport/ews-build/steps.py:
3875         (BugzillaMixin.close_bug): Method to close the bugzilla bug.
3876         (CloseBug): Build step to close bugzilla bug.
3877
3878 2020-02-05  Aakash Jain  <aakash_jain@apple.com>
3879
3880         [ews] add commit-queue build step to clear flags on patch
3881         https://bugs.webkit.org/show_bug.cgi?id=206536
3882
3883         Reviewed by Jonathan Bedard.
3884
3885         * BuildSlaveSupport/ews-build/steps.py:
3886         (BugzillaMixin): Class for common bugzilla related methods.
3887         (BugzillaMixin.get_bugzilla_api_key): Method to read bugzilla api key from file.
3888         (BugzillaMixin.remove_flags_on_patch): Method to remove flags on patch.
3889         (ValidatePatch):
3890         (RemoveFlagsOnPatch): Class to remove flags on patch.
3891         (RemoveFlagsOnPatch.start):
3892         (ValidatePatch._addToLog): Moved.
3893         (ValidatePatch.fetch_data_from_url): Moved.
3894         (ValidatePatch.get_patch_json): Moved.
3895         (ValidatePatch.get_bug_json): Moved.
3896         (ValidatePatch.get_bug_id_from_patch): Moved.
3897         (ValidatePatch._is_patch_obsolete): Moved.
3898         (ValidatePatch._is_patch_review_denied): Moved.
3899         (ValidatePatch._is_patch_cq_plus): Moved.
3900         (ValidatePatch._is_bug_closed): Moved.
3901
3902 2020-02-07  Jonathan Bedard  <jbedard@apple.com>
3903
3904         EWS should run resultsdbpy tests
3905         https://bugs.webkit.org/show_bug.cgi?id=201928
3906
3907         Reviewed by Aakash Jain.
3908
3909         * BuildSlaveSupport/ews-build/factories.py:
3910         (ServicesFactory.__init__): Add RunResultsdbpyTests.
3911         * BuildSlaveSupport/ews-build/factories_unittest.py:
3912         (TestTestsFactory.test_services_factory): Add RunResultsdbpyTests.
3913         * BuildSlaveSupport/ews-build/steps.py:
3914         (CheckPatchRelevance): resultsdbpy changes should trigger service tests.
3915         (RunResultsdbpyTests): Add step which runs resultsdbpy tests.
3916         * BuildSlaveSupport/ews-build/steps_unittest.py:
3917         (TestRunResultsdbpyTests):
3918         (TestRunResultsdbpyTests.setUp):
3919         (TestRunResultsdbpyTests.tearDown):
3920         (TestRunResultsdbpyTests.test_success):
3921         (TestRunResultsdbpyTests.test_failure):
3922
3923 2020-02-07  Jacob Uphoff  <jacob_uphoff@apple.com>
3924
3925         Adding myself to contributors.json
3926         
3927         Unreviewed
3928
3929         * Scripts/webkitpy/common/config/contributors.json:
3930
3931 2020-02-07  Jason Lawrence  <lawrence.j@apple.com>
3932
3933         Adding myself to contributors.json
3934         
3935         Unreviewed
3936
3937         * Scripts/webkitpy/common/config/contributors.json:
3938
3939 2020-02-07  Patrick Griffis  <pgriffis@igalia.com>
3940
3941         [GTK][WPE] Add same-site cookie support
3942         https://bugs.webkit.org/show_bug.cgi?id=204137
3943
3944         Reviewed by Carlos Garcia Campos.
3945
3946         Update libsoup to 2.69.90 in JHBuild.
3947
3948         * gtk/jhbuild.modules:
3949         * wpe/jhbuild.modules:
3950
3951 2020-02-07  Yusuke Suzuki  <ysuzuki@apple.com>
3952
3953         Unreviewed, revert 75% load-factor because of JetStream2/string-unpack-code-SP regression
3954         https://bugs.webkit.org/show_bug.cgi?id=207183
3955
3956         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3957         (TestWebKitAPI::testInitialCapacity):
3958
3959 2020-02-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3960
3961         WebPage::rangeForGranularityAtPoint always returns null in the case of CharacterGranularity
3962         https://bugs.webkit.org/show_bug.cgi?id=207350
3963         <rdar://problem/59239914>
3964
3965         Reviewed by Tim Horton.
3966
3967         Add a test to exercise the corner case in the SPI.
3968
3969         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3970         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm: Added.
3971
3972 2020-02-06  Jiewen Tan  <jiewen_tan@apple.com>
3973
3974         Adopt new SOAuthorizationOption constants
3975         https://bugs.webkit.org/show_bug.cgi?id=207186
3976         <rdar://problem/48909336>
3977
3978         Reviewed by Brent Fulgham.
3979
3980         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
3981         (checkAuthorizationOptions):
3982
3983 2020-02-06  Brady Eidson  <beidson@apple.com>
3984
3985         Cleanup and promote WKContentWorld and its clients in WKWebView.
3986         https://bugs.webkit.org/show_bug.cgi?id=207351
3987
3988         Reviewed by Alex Christensen.
3989
3990         * TestWebKitAPI/Tests/WebKitCocoa/AsyncFunction.mm:
3991         (TestWebKitAPI::TEST):
3992         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
3993         (TEST):
3994         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3995         (-[WKWebView objectByCallingAsyncFunction:withArguments:error:]):
3996
3997 2020-02-06  Fujii Hironori  <Hironori.Fujii@sony.com>
3998
3999         [Win][MiniBrowser] Accelerator keys don't work unless the main window is focused
4000         https://bugs.webkit.org/show_bug.cgi?id=207250
4001
4002         Reviewed by Alex Christensen.
4003
4004         MiniBrowser has shortcut keys, Ctrl-W to close window, Ctrl-R to
4005         reload. However, they don't work unless the main window is
4006         focused.
4007
4008         Ctrl-W should be processed differently. Ctrl-W should be handled
4009         without dispatching to WebKit, others should be handled only when
4010         WebKit didn't consume. So, this change split the accelerator table
4011         into two, one is for Ctrl-W, another is for other shortcut keys.
4012
4013         For Ctrl-W, key events are processed before dispatching to
4014         WebView. It is converted to IDM_CLOSE_WINDOW of WM_COMMAND, and
4015         dispatched to WebView. WebKit2 WebView bubbles up unhandled
4016         WM_COMMAND to the parent window. Then, IDM_CLOSE_WINDOW is handled
4017         in the main window's WndProc. However, it doesn't work for WebKit1
4018         because this change doesn't add the bubbling up code to WebKit1
4019         WebView.
4020
4021         For other shortcut keys, for example Ctrl-R, key events are
4022         dispatched to WebView without accelerator key translations. Then,
4023         WebKitBrowserWindow::didNotHandleKeyEvent is called back if they
4024         aren't consumed. didNotHandleKeyEvent posts the messasge to the
4025         main window. The message loop processed key events dispatched to
4026         the main window with another accelerator table. However, it
4027         doesn't work for WebKit1, because WebKit1 doesn't have a API
4028         equivalent to didNotHandleKeyEvent.
4029
4030         After switching the active window by pressing Alt-Tab and
4031         reactivating the main window, the main window got the focus. This
4032         was the reason shortcut keys worked only after reactivating the
4033         main window. But, this is not the desired behavior after this
4034         change because other shortcut keys don't work if the main window
4035         is focused. So. set the focus to the brower window when
4036         WM_ACTIVATE of the main window.
4037
4038         Shortcut keys Ctrl++ (zoom in) and Ctrl+- (zoom out) were
4039         effective only for keyboard numpad. Add VK_OEM_MINUS and
4040         VK_OEM_PLUS for them.
4041
4042         Add a shortcut key Ctrl-0 to reset page zoom scale to actual.
4043
4044         * MiniBrowser/win/MainWindow.cpp:
4045         (MainWindow::isInstance):
4046         (MainWindow::WndProc):
4047         * MiniBrowser/win/MainWindow.h:
4048         * MiniBrowser/win/MiniBrowserLib.rc: Add a new accelerator table
4049         IDR_ACCELERATORS_PRE for Ctrl-W.
4050         * MiniBrowser/win/MiniBrowserLibResource.h:
4051         * MiniBrowser/win/WebKitBrowserWindow.cpp:
4052         (WebKitBrowserWindow::didNotHandleKeyEvent):
4053         * MiniBrowser/win/WinMain.cpp:
4054         (wWinMain):
4055
4056 2020-02-06  Jonathan Bedard  <jbedard@apple.com>
4057
4058         results.webkitorg: Dead CI links
4059         https://bugs.webkit.org/show_bug.cgi?id=207340
4060
4061         Reviewed by Alexey Proskuryakov.
4062
4063         * resultsdbpy/resultsdbpy/view/static/js/configuration.js:
4064         (Configuration.prototype.toParams): Version name and version number often duplicate the
4065         same information, exception version number is often more specific than is useful.
4066
4067 2020-02-06  Brent Fulgham  <bfulgham@apple.com>
4068
4069         Prevent navigating top level frames to Data URLs
4070         https://bugs.webkit.org/show_bug.cgi?id=206962
4071         <rdar://problem/56770676>
4072
4073         Reviewed by Youenn Fablet.
4074
4075         Revise test running code to allow data URL navigations by default, since they are so frequently
4076         used in testing. However, provide a flag to turn this off in tests so we can confirm proper
4077         function.
4078
4079         * DumpRenderTree/TestOptions.cpp:
4080         (TestOptions::TestOptions):
4081         * DumpRenderTree/TestOptions.h:
4082         * DumpRenderTree/mac/DumpRenderTree.mm:
4083         (setWebPreferencesForTestOptions):
4084         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4085         (DownloadAttributeDoesNotStartDownloads): Revise configuration to allow script navigation of the main frame to a Data URL.
4086         (StartDownloadWithDownloadAttribute): Ditto.
4087         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
4088         (WebViewWillPerformClientRedirect): Ditto.
4089         (WebViewDidCancelClientRedirect): Ditto.
4090         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4091         (NavigateToDataURLThenBack): Ditto.
4092         (ContentExtensionBlocksMainLoadThenReloadWithoutExtensions): Ditto.
4093         * WebKitTestRunner/TestController.cpp:
4094         (WTR::TestController::resetPreferencesToConsistentValues):
4095         (WTR::updateTestOptionsFromTestHeader):
4096         * WebKitTestRunner/TestOptions.h:
4097         (WTR::TestOptions::hasSameInitializationOptions const):
4098         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4099         (WTR::initializeWebViewConfiguration):
4100         (WTR::TestController::platformCreateWebView):
4101
4102 2020-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
4103
4104         [iOS] Provide a way to suppress software keyboards on WKWebView's WKContentView
4105         https://bugs.webkit.org/show_bug.cgi?id=207272
4106         <rdar://problem/59190828>
4107
4108         Reviewed by Tim Horton.
4109
4110         Add an API test to verify (through UIKeyboardImpl) that the software keyboard should be suppressed when setting
4111         -_setSuppressSoftwareKeyboard: on the web view. This involves making `-makeKeyWindow` "work" in the API testing
4112         environment on iOS, by swizzling out both `-[NSBundle bundleIdentifier]` and `-[UIApplication keyWindow]`.
4113
4114         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
4115         (TestWebKitAPI::overrideBundleIdentifier):
4116         * TestWebKitAPI/cocoa/TestWKWebView.mm:
4117         (setOverriddenApplicationKeyWindow):
4118         (applicationKeyWindowOverride):
4119         (-[TestWKWebViewHostWindow makeKeyWindow]):
4120         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
4121         * TestWebKitAPI/ios/UIKitSPI.h:
4122
4123         Also move the `UIResponder (UIKitSPI)` category from the internal section to the SPI section; this is redundant
4124         when using the internal SDK to build, since these methods are already declared in UIResponder_Private.h.
4125
4126 2020-02-05  Don Olmstead  <don.olmstead@sony.com>
4127
4128         [PlayStation] Build a shared JavaScriptCore
4129         https://bugs.webkit.org/show_bug.cgi?id=198446
4130
4131         Reviewed by Fujii Hironori.
4132
4133         Add TARGET_OBJECTS for bmalloc and WTF so TestWTF links.
4134
4135         * TestWebKitAPI/PlatformPlayStation.cmake:
4136
4137 2020-02-05  Stephan Szabo  <stephan.szabo@sony.com>
4138
4139         [WinCairo] Set up fonts for layout tests for test bot image
4140         https://bugs.webkit.org/show_bug.cgi?id=207223
4141
4142         Reviewed by Fujii Hironori.
4143
4144         * WebKitTestRunner/InjectedBundle/win/ActivateFontsWin.cpp:
4145           Implement activateFonts to load fonts for test
4146
4147 2020-02-05  Don Olmstead  <don.olmstead@sony.com>
4148
4149         [PlayStation] Miscellaneous build fixes February 2020 edition
4150         https://bugs.webkit.org/show_bug.cgi?id=207312
4151
4152         Unreviewed build fix.
4153
4154         * TestWebKitAPI/PlatformWebView.h: Remove #elif guard and just use #else
4155
4156 2020-02-05  Yusuke Suzuki  <ysuzuki@apple.com>
4157
4158         [WTF] Try using 75% load factor for HashTable
4159         https://bugs.webkit.org/show_bug.cgi?id=207183
4160
4161         Reviewed by Mark Lam.
4162
4163         Fix load-factor assumption in existing tests.
4164
4165         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
4166         (TestWebKitAPI::testInitialCapacity):
4167
4168 2020-02-05  Jonathan Bedard  <jbedard@apple.com>
4169
4170         resulsdbpy: Fix unit tests
4171         https://bugs.webkit.org/show_bug.cgi?id=207304
4172
4173         Reviewed by Aakash Jain.
4174
4175         * resultsdbpy/resultsdbpy/model/configuration_context_unittest.py:
4176         (ConfigurationContextTest.test_partition_by_configuration): Add branch to testing table.
4177         (ConfigurationContextTest.test_partition_by_partial_configuration): Ditto.
4178         * resultsdbpy/resultsdbpy/model/failure_context_unittest.py:
4179         (FailureContextTest.test_failures): Sort test failures by uuid for a predictable order in testing.
4180         (FailureContextTest.test_unexpected_failures): Ditto.
4181         * resultsdbpy/resultsdbpy/model/mock_model_factory.py:
4182         (MockModelFactory.iterate_all_commits): Do not batch requests since this function has no way
4183         of knowing how expensive the callback may be.
4184
4185 2020-02-05  Chris Dumez  <cdumez@apple.com>
4186
4187         Unreviewed, another build fix after r255846
4188
4189         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
4190
4191 2020-02-05  Ryan Haddad  <ryanhaddad@apple.com>
4192
4193         Unreviewed infrastructure fix.
4194
4195         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4196         (WebKitBuildbot): Delete entries for queues that have been removed from buildbot.
4197
4198 2020-02-05  Chris Dumez  <cdumez@apple.com>
4199
4200         Unreviewed build fix after r255846.
4201
4202         * TestWebKitAPI/cocoa/HTTPServer.h:
4203
4204 2020-02-05  Jiewen Tan  <jiewen_tan@apple.com>
4205
4206         Defer ending AppSSO sheets til NSWindowDidDeminiaturize or NSApplicationDidUnhide
4207         https://bugs.webkit.org/show_bug.cgi?id=207173
4208         <rdar://problem/55669065>
4209
4210         Reviewed by Brent Fulgham.
4211
4212         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
4213         (TestWebKitAPI::TEST):
4214         * TestWebKitAPI/cocoa/TestWKWebView.mm:
4215         (-[TestWKWebView _setUpTestWindow:]):
4216         Make the TestWKWebViewHostWindow miniaturizable to enable the test.
4217
4218 2020-02-05  Jonathan Bedard  <jbedard@apple.com>
4219
4220         results.webkit.org: Apply ttl to archive shards
4221         https://bugs.webkit.org/show_bug.cgi?id=207295
4222
4223         Rubber-stamped by Aakash Jain.
4224
4225         * resultsdbpy/resultsdbpy/model/archive_context.py:
4226         (ArchiveContext.ArchiveMetaDataByCommit): Use new table.
4227         (ArchiveContext.ArchiveChunks): Use new table.
4228         (ArchiveContext.register): Add ttl to archive shards.
4229
4230 2020-02-05  Alex Christensen  <achristensen@webkit.org>
4231
4232         Make WKWebView._negotiatedLegacyTLS accurate when loading main resouorce from network or cache
4233         https://bugs.webkit.org/show_bug.cgi?id=207207
4234
4235         Reviewed by Chris Dumez.
4236
4237         HTTPServer now supports HTTPS. Tell your friends!
4238
4239         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
4240         (testCertificate):
4241         (testIdentity):
4242         (credentialWithIdentity):
4243         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
4244         (TestWebKitAPI::webViewWithNavigationDelegate):
4245         (TestWebKitAPI::TEST):
4246         * TestWebKitAPI/cocoa/HTTPServer.h:
4247         * TestWebKitAPI/cocoa/HTTPServer.mm:
4248         (TestWebKitAPI::HTTPServer::HTTPServer):
4249         (TestWebKitAPI::HTTPServer::request const):
4250
4251 2020-02-05  Brady Eidson  <beidson@apple.com>
4252
4253         _WKDownload should expose the originating FrameInfo.
4254         <rdar://problem/58022576> and https://bugs.webkit.org/show_bug.cgi?id=207185
4255
4256         Reviewed by Geoff Garen.
4257
4258         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4259         (-[DownloadTestSchemeDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
4260         (-[DownloadSecurityOriginDelegate _downloadDidStart:]):
4261         (loaded):
4262         * TestWebKitAPI/cocoa/HTTPServer.mm:
4263
4264 2020-02-05  Xabier Rodriguez Calvar  <calvaris@igalia.com>
4265
4266         [GTK] Fix dependencies build
4267         https://bugs.webkit.org/show_bug.cgi?id=207273
4268
4269         Reviewed by Carlos Garcia Campos.
4270
4271         * gtk/jhbuild.modules: Bumped wpebackend-fdo version to 1.4.1 and
4272         added mesa as one of its deps. Added the xserver patch as well.
4273         * gtk/patches/xserver-gl-version.patch: Added.
4274
4275 2020-02-05  Chris Dumez  <cdumez@apple.com>
4276
4277         REGRESSION(r255595): page not closed after beforeunload handler returns true
4278         https://bugs.webkit.org/show_bug.cgi?id=207189
4279         <rdar://problem/59149593>
4280
4281         Reviewed by Youenn Fablet.
4282
4283         Add API test coverage for fix landed in r255677.
4284
4285         * TestWebKitAPI/Tests/WebKitCocoa/ModalAlerts.mm:
4286         (-[SlowBeforeUnloadPromptUIDelegate _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
4287         (TEST):
4288
4289 2020-02-05  Jonathan Bedard  <jbedard@apple.com>
4290
4291         results.webkit.org should disable auto-capitalize over the search field
4292         https://bugs.webkit.org/show_bug.cgi?id=207240
4293         <rdar://problem/59053042>
4294
4295         Rubber-stamped by Aakash Jain.
4296
4297         * resultsdbpy/resultsdbpy/view/static/js/search.js:
4298
4299 2020-02-01  Darin Adler  <darin@apple.com>
4300
4301         Replace RGBA32 typedef with a class to improve type safety
4302         https://bugs.webkit.org/show_bug.cgi?id=206862
4303
4304         Reviewed by Sam Weinig.
4305
4306         * TestWebKitAPI/Tests/WebKitCocoa/PDFSnapshot.mm:
4307         (TestWebKitAPI::TEST): Use the Color constructor instead of Color::createUnchecked.
4308
4309 2020-02-04  Darin Adler  <darin@apple.com>
4310
4311         Remove NSKeyedArchiverSPI.h now that WebKit only uses API
4312         https://bugs.webkit.org/show_bug.cgi?id=207203
4313
4314         Reviewed by Anders Carlsson.
4315
4316         * TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm: Removed
4317         include of NSKeyedArchiverSPI.h and call methods of NSKeyedArchiver directly.
4318         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm: Ditto.
4319         * TestWebKitAPI/Tests/ios/WKWebViewOpaque.mm: Ditto.
4320         * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm: Ditto.
4321
4322 2020-02-04  Jonathan Bedard  <jbedard@apple.com>
4323
4324         results.webkit.org: Support Internal in run-javascriptcore-tests
4325         https://bugs.webkit.org/show_bug.cgi?id=204095
4326
4327         Rubber-stamped by Aakash Jain.