cd1a0f1cb08cc04fb9877e5541060feb3efb690b
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2
3         [ews-build] Do not trigger queues which are not in production yet
4         https://bugs.webkit.org/show_bug.cgi?id=196581
5
6         Reviewed by Dewei Zhu.
7
8         * BuildSlaveSupport/ews-build/config.json:
9
10 2019-04-03  Chris Dumez  <cdumez@apple.com>
11
12         Unreviewed, fix typo in the name of API test added in r243848.
13
14         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
15         (TestWebKitAPI::TEST):
16
17 2019-04-03  Chris Dumez  <cdumez@apple.com>
18
19         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
20         https://bugs.webkit.org/show_bug.cgi?id=196588
21         <rdar://problem/49365787>
22
23         Reviewed by Ryosuke Niwa.
24
25         Add API test coverage.
26
27         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
28         (TestWebKitAPI::nullJavaScriptCallback):
29         (TestWebKitAPI::didCrashCheckFrames):
30         (TestWebKitAPI::TEST):
31
32 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
33
34         run-webkit-tests: Upload test results (new results database)
35         https://bugs.webkit.org/show_bug.cgi?id=196577
36         <rdar://problem/34841155>
37
38         Reviewed by Lucas Forschler.
39
40         * Scripts/webkitpy/layout_tests/controllers/manager.py:
41         (Manager.run): Upload results after each device shard, since the configuration will be
42         different for each device.
43         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
44         uploaded to a results database.
45         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
46         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
47
48 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
49
50         -apple-trailing-word is needed for browser detection
51         https://bugs.webkit.org/show_bug.cgi?id=196575
52
53         Unreviewed.
54
55         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
56
57 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
58
59         [CMake][WTF] Mirror XCode header directories
60         https://bugs.webkit.org/show_bug.cgi?id=191662
61
62         Reviewed by Konstantin Tokarev.
63
64         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
65         builds.
66
67         * CMakeLists.txt:
68         * DumpRenderTree/CMakeLists.txt:
69         * DumpRenderTree/PlatformWin.cmake:
70         * MiniBrowser/win/CMakeLists.txt:
71         * TestWebKitAPI/CMakeLists.txt:
72         * TestWebKitAPI/PlatformWin.cmake:
73         * WebKitTestRunner/PlatformGTK.cmake:
74         * WebKitTestRunner/PlatformWin.cmake:
75
76 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
77
78         [ews-app] Status bubble should not display certain infrastructure status messages
79         https://bugs.webkit.org/show_bug.cgi?id=196550
80
81         Reviewed by Lucas Forschler.
82
83         Do not display the steps which are un-needed for end-user. This information is still avaiable
84         if the user click on the bubble and look at the Buildbot build.
85         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
86         (StatusBubble._steps_messages):
87         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
88
89 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
90
91         [ews-build] Use https for sending data to ews-app
92         https://bugs.webkit.org/show_bug.cgi?id=196492
93
94         Reviewed by Lucas Forschler.
95
96         * BuildSlaveSupport/ews-build/events.py:
97
98 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
99
100         Remove support for -apple-trailing-word
101         https://bugs.webkit.org/show_bug.cgi?id=196525
102
103         Reviewed by Zalan Bujtas.
104
105         This CSS property is nonstandard and not used.
106
107         * Scripts/webkitperl/FeatureList.pm:
108         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
109
110 2019-04-03  Youenn Fablet  <youenn@apple.com>
111
112         Add a test for DOMCache on multiple browsing in case of private browsing
113         https://bugs.webkit.org/show_bug.cgi?id=196524
114
115         Reviewed by Alex Christensen.
116
117         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
118         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
119
120 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
121
122         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
123         https://bugs.webkit.org/show_bug.cgi?id=196540
124
125         Reviewed by Aakash Jain.
126
127         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
128
129 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
130
131         Add plumbing for a compatibility mode preference in WebKit
132         https://bugs.webkit.org/show_bug.cgi?id=196005
133
134         Reviewed by Tim Horton.
135
136         Add new API tests.
137
138         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
139         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
140
141 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
142
143         [WPE][GTK] Update libsrtp dependency package for Debian
144         https://bugs.webkit.org/show_bug.cgi?id=196528
145
146         Reviewed by Frédéric Wang.
147
148         * gtk/install-dependencies:
149         * wpe/install-dependencies:
150
151 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
152
153         [WK2] Add support for Window's beforeprint / afterprint events
154         https://bugs.webkit.org/show_bug.cgi?id=196478
155         <rdar://problem/49535124>
156
157         Unreviewed build fix for MSVC.
158
159         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
160
161         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
162
163         * WebKitTestRunner/TestController.cpp:
164         (WTR::printFrame): Use int and float literals.
165
166 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
167
168         [ews-build] Reassign bots to queues
169
170         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
171
172 2019-04-02  Chris Dumez  <cdumez@apple.com>
173
174         [WK2] Add support for Window's beforeprint / afterprint events
175         https://bugs.webkit.org/show_bug.cgi?id=196478
176
177         Reviewed by Alex Christensen.
178
179         Add minimal implementation for printFrame in WebKitTestRunner.
180
181         * WebKitTestRunner/TestController.cpp:
182         (WTR::printFrame):
183         (WTR::TestController::createOtherPage):
184         (WTR::TestController::createWebViewWithOptions):
185
186 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
187
188         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
189         https://bugs.webkit.org/show_bug.cgi?id=196491
190
191         Reviewed by Lucas Forschler.
192
193         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
194
195 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
196
197         [ews-build] Configure buildbot try credentials in environment variables
198         https://bugs.webkit.org/show_bug.cgi?id=196501
199
200         Reviewed by Lucas Forschler.
201
202         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
203         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
204         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
205
206 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
207
208         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
209         https://bugs.webkit.org/show_bug.cgi?id=196496
210         <rdar://problem/49521634>
211
212         Reviewed by Chris Dumez.
213
214         Add new API tests (see WebKit ChangeLog for more detail).
215
216         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
217         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
218         (TEST):
219
220 2019-04-02  David Kilzer  <ddkilzer@apple.com>
221
222         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
223         <https://webkit.org/b/196499>
224
225         Reviewed by Alexey Proskuryakov.
226
227         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
228         ENABLE_ADDRESS_SANITIZER.
229
230 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
231
232         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
233         https://bugs.webkit.org/show_bug.cgi?id=182757
234
235         Reviewed by Don Olmstead.
236
237         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
238         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
239
240 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
241
242         run-api-tests: Upload test results
243         https://bugs.webkit.org/show_bug.cgi?id=196323
244         <rdar://problem/49356714>
245
246         Reviewed by Lucas Forschler.
247
248         * Scripts/webkitpy/api_tests/manager.py:
249         (Manager):
250         (Manager.run): Upload results to a results database.
251         * Scripts/webkitpy/api_tests/run_api_tests.py:
252         (parse_args): Add upload arguments.
253         * Scripts/webkitpy/port/base.py:
254         (Port):
255         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
256         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
257         with commits from any other associated repositories.
258         * Scripts/webkitpy/port/device.py:
259         (Device):
260         (Device.build_version): Access build_versoin of underlying platform device.
261         * Scripts/webkitpy/port/ios_simulator_unittest.py:
262         (IOSSimulatorTest):
263         (IOSSimulatorTest.test_configuration_for_upload):
264         * Scripts/webkitpy/port/device_port.py:
265         (DevicePort):
266         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
267         the same as the machine uploading results.
268         * Scripts/webkitpy/port/mac.py:
269         (MacPort):
270         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
271         * Scripts/webkitpy/port/mac_unittest.py:
272         (MacTest):
273         (MacTest.test_configuration_for_upload):
274         * Scripts/webkitpy/xcode/simulated_device.py:
275         (SimulatedDeviceManager._create_device_with_runtime):
276         (SimulatedDevice.__init__): Create simulated device with a build_version.
277         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
278         (test_existing_simulator):
279
280 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
281
282         Remove extra newline characters (Follow-up fix to r243707)
283
284         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
285
286 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
287
288         [ews-app] Use API_KEY to accept results data
289         https://bugs.webkit.org/show_bug.cgi?id=196461
290
291         Reviewed by Dewei Zhu.
292
293         * BuildSlaveSupport/ews-app/ews/views/results.py:
294         (Results.post): Validate EWS_API_KEY before accepting any data.
295         * BuildSlaveSupport/ews-build/events.py:
296         (Events.sendData): Send EWS_API_KEY if available along with event data.
297
298 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
299
300         Unable to copy and paste a PDF from Notes into Mail compose body
301         https://bugs.webkit.org/show_bug.cgi?id=196442
302         <rdar://problem/48573098>
303
304         Reviewed by Tim Horton.
305
306         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
307         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
308         to be specified on the item providers.
309
310         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
311         (TestWebKitAPI::mapItemForTesting):
312         (TestWebKitAPI::contactItemForTesting):
313
314 2019-04-01  Tim Horton  <timothy_horton@apple.com>
315
316         Make UIWKDocumentContext rects per-character instead of per-word
317         https://bugs.webkit.org/show_bug.cgi?id=196459
318
319         Reviewed by Wenson Hsieh.
320
321         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
322         (TEST):
323         Adjust test results due to switching to per-character rects.
324
325 2019-04-01  Chris Dumez  <cdumez@apple.com>
326
327         UIProcess crash when a prewarmed process is terminated
328         https://bugs.webkit.org/show_bug.cgi?id=196451
329         <rdar://problem/49245471>
330
331         Reviewed by Geoffrey Garen.
332
333         Add API test coverage.
334
335         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
336         (TEST):
337
338 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
339
340         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
341         https://bugs.webkit.org/show_bug.cgi?id=196449
342
343         Reviewed by Lucas Forschler.
344
345         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
346         (StatusBubble.get_os_details): Method to get OS and Xcode details.
347         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
348         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
349
350 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
351
352         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
353         https://bugs.webkit.org/show_bug.cgi?id=196444
354
355         Reviewed by Lucas Forschler.
356
357         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
358
359 2019-04-01  Alex Christensen  <achristensen@webkit.org>
360
361         Add SPI to canonicalize NSURLs with WTF::URL
362         https://bugs.webkit.org/show_bug.cgi?id=196415
363         <rdar://problem/44980271>
364
365         Reviewed by Darin Adler.
366
367         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
368         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
369         (TestWebKitAPI::TEST):
370
371 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
372
373         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
374         https://bugs.webkit.org/show_bug.cgi?id=196441
375
376         Reviewed by Carlos Garcia Campos.
377
378         Don't cache the wpe_view_backend object that might not exist yet at the
379         time of EventSenderProxy constructor invocation, but instead retrieve
380         that object whenever it's required for event dispatching. This should
381         avoid crashes in this constructor now that it's invoked before any
382         PlatformWindow has been set up (as changed in r243496).
383
384         * WebKitTestRunner/EventSenderProxy.h:
385         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
386         (WTR::viewBackend):
387         (WTR::EventSenderProxy::EventSenderProxy):
388         (WTR::EventSenderProxy::mouseDown):
389         (WTR::EventSenderProxy::mouseUp):
390         (WTR::EventSenderProxy::mouseMoveTo):
391         (WTR::EventSenderProxy::mouseScrollBy):
392         (WTR::EventSenderProxy::keyDown):
393         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
394
395 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
396
397         [Win][WebKit] MiniBrowser should support high DPI display
398         https://bugs.webkit.org/show_bug.cgi?id=196391
399
400         Reviewed by Alex Christensen.
401
402         * MiniBrowser/win/WebKitBrowserWindow.cpp:
403         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
404         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
405         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
406
407 2019-03-31  Sam Weinig  <weinig@apple.com>
408
409         Remove more i386 specific configurations
410         https://bugs.webkit.org/show_bug.cgi?id=196430
411
412         Reviewed by Alexey Proskuryakov.
413
414         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
415         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
416
417 2019-03-31  Andy Estes  <aestes@apple.com>
418
419         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
420         https://bugs.webkit.org/show_bug.cgi?id=196433
421         <rdar://problem/49293305>
422
423         Reviewed by Tim Horton.
424
425         Enhanced API test coverage to include all navigation response policy decisions in both
426         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
427
428         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
429         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
430         (TestWebKitAPI::TEST):
431         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
432         (readFile):
433         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
434         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
435         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
436         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
437         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
438         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
439         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
440         (-[QuickLookDelegate _downloadDidStart:]):
441         (-[QuickLookDelegate _download:didReceiveResponse:]):
442         (-[QuickLookDelegate _download:didReceiveData:]):
443         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
444         (-[QuickLookDelegate _downloadDidFinish:]):
445         (-[QuickLookDelegate _download:didFailWithError:]):
446         (-[QuickLookDelegate _downloadDidCancel:]):
447         (-[QuickLookDelegate verifyDownload]):
448         (runTest):
449         (runTestDecideBeforeLoading):
450         (runTestDecideAfterLoading):
451         (TEST):
452         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
453         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
454         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
455         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
456         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
457         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
458         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
459         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
460         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
461         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
462         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
463         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
464         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
465         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
466
467 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
468
469         [CMake] add testdfg as target with build-jsc
470         https://bugs.webkit.org/show_bug.cgi?id=196393
471
472         Reviewed by Saam Barati.
473
474         Added testdfg as one of the targets to build when
475         using CMake.
476
477         * Scripts/build-jsc:
478
479 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
480
481         Delete WebMetal implementation in favor of WebGPU
482         https://bugs.webkit.org/show_bug.cgi?id=195418
483
484         Reviewed by Dean Jackson.
485
486         * DumpRenderTree/mac/DumpRenderTree.mm:
487         (enableExperimentalFeatures):
488         (resetWebPreferencesToConsistentValues):
489         * Scripts/webkitperl/FeatureList.pm:
490         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
491         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
492         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
493         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
494         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
495         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
496         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
497         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
498         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
499         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
500         (WTR::InjectedBundle::beginTesting):
501         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
502         (WTR::TestRunner::setWebMetalEnabled): Deleted.
503         * WebKitTestRunner/InjectedBundle/TestRunner.h:
504
505 2019-03-29  Chris Dumez  <cdumez@apple.com>
506
507         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
508         https://bugs.webkit.org/show_bug.cgi?id=196405
509         <rdar://problem/49428130>
510
511         Reviewed by Wenson Hsieh.
512
513         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
514         the popover presentation methods to be no-ops. Use this in the new test added in
515         r243523 so that we do not swizzle those methods for all tests. This is needed because
516         those WatchOS tests rely on the popover getting presented and interactive.
517
518         * WebKitTestRunner/TestController.cpp:
519         (WTR::updateTestOptionsFromTestHeader):
520         * WebKitTestRunner/TestController.h:
521         * WebKitTestRunner/TestOptions.h:
522         (WTR::TestOptions::hasSameInitializationOptions const):
523         * WebKitTestRunner/ios/TestControllerIOS.mm:
524         (WTR::TestController::platformInitialize):
525         (WTR::TestController::platformResetStateToConsistentValues):
526
527 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
528
529         [Curl] Add Server Trust Evaluation Support.
530         https://bugs.webkit.org/show_bug.cgi?id=191646
531
532         Reviewed by Fujii Hironori.
533
534         Implemented MiniBrowser UI for asking if user trusts the server.
535
536         * MiniBrowser/win/Common.cpp:
537         (askServerTrustEvaluation):
538         (replaceString):
539         * MiniBrowser/win/Common.h:
540         * MiniBrowser/win/MiniBrowserLib.rc:
541         * MiniBrowser/win/MiniBrowserLibResource.h:
542         * MiniBrowser/win/WebKitBrowserWindow.cpp:
543         (createPEMString):
544         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
545         (WebKitBrowserWindow::canTrustServerCertificate):
546         * MiniBrowser/win/WebKitBrowserWindow.h:
547
548 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
549
550         Implement ResizeObserver.
551         https://bugs.webkit.org/show_bug.cgi?id=157743
552
553         Reviewed by Simon Fraser.
554
555         Support resizeObserverEnabled webPreferences.
556
557         * DumpRenderTree/TestOptions.cpp:
558         (TestOptions::TestOptions):
559         * DumpRenderTree/TestOptions.h:
560         * DumpRenderTree/mac/DumpRenderTree.mm:
561         (setWebPreferencesForTestOptions):
562         * DumpRenderTree/win/DumpRenderTree.cpp:
563         (enableExperimentalFeatures):
564         * Scripts/webkitperl/FeatureList.pm:
565         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
566
567 2019-03-28  John Wilander  <wilander@apple.com>
568
569         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
570         https://bugs.webkit.org/show_bug.cgi?id=196281
571         <rdar://problem/48938748>
572
573         Reviewed by Alex Christensen.
574
575         This patch adds the function isStatisticsHasLocalStorage() to the
576         TestRunner. With it, the page can query the WebsiteDataStore in the
577         UI process to make sure that it sees LocalStorage.
578
579         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
580         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
581         (WTR::TestRunner::isStatisticsHasLocalStorage):
582         * WebKitTestRunner/InjectedBundle/TestRunner.h:
583         * WebKitTestRunner/TestController.cpp:
584         (WTR::TestController::isStatisticsHasLocalStorage):
585         * WebKitTestRunner/TestController.h:
586         * WebKitTestRunner/TestInvocation.cpp:
587         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
588
589 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
590
591         API::Data::createWithoutCopying should do a null check before calling CFRelease
592         https://bugs.webkit.org/show_bug.cgi?id=196276
593         <rdar://problem/48059859>
594
595         Reviewed by Alex Christensen.
596
597         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
598
599         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
600         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
601         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
602         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
603         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
604         (TestWebKitAPI::TEST):
605
606 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
607
608         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
609         https://bugs.webkit.org/show_bug.cgi?id=186276
610
611         Reviewed by Carlos Garcia Campos.
612
613         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
614         (webViewLoadChanged):
615         (testWebResourceGetDataError):
616         (testWebResourceGetDataEmpty):
617         (beforeAll):
618         (webViewloadChanged): Deleted.
619
620 2019-03-27  Andy Estes  <aestes@apple.com>
621
622         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
623         https://bugs.webkit.org/show_bug.cgi?id=196317
624
625         Reviewed by Dan Bernstein.
626
627         package-root copies built products into a staging directory using ditto(1), which does not
628         follow symbolic links as it traverses a directory. Now that the files in
629         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
630         itself, these become broken links when ditto'd into the staging directory.
631
632         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
633
634         * Scripts/package-root:
635
636 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
637
638         [ews-app] Update display text of Submit for ews analysis
639         https://bugs.webkit.org/show_bug.cgi?id=196309
640
641         Reviewed by Dewei Zhu.
642
643         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
644
645 2019-03-27  David Kilzer  <ddkilzer@apple.com>
646
647         run-webkit-tests should check for leaks in WebKit processes
648         <https://webkit.org/b/193772>
649         <rdar://problem/46526680>
650
651         Reviewed by Ryosuke Niwa.
652
653         This works by doing the following:
654         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
655           The list of child processes are returned one per line:
656           process.name: pid
657         - Run the "#LIST CHILD PROCESSES" command just before the
658           "#CHECK FOR WORLD LEAKS" command, and store the list of child
659           processes on the ServerProcess object.
660         - When the `--leaks` switch is handled, run check_for_leaks() on
661           each child process after the main test harness.
662
663         * DumpRenderTree/mac/DumpRenderTree.mm:
664         (handleControlCommand):
665         - Use strncmp() instead of strcmp().
666         - Add support for handling "#LIST CHILD PROCESSES" command.
667
668         * Scripts/webkitpy/port/base.py:
669         (Port.check_for_leaks):
670         * Scripts/webkitpy/port/darwin.py:
671         (DarwinPort.check_for_leaks):
672         - Rename redundant 'process_pid' argument to 'process_id'.
673
674         * Scripts/webkitpy/port/driver.py:
675         (Driver.do_post_tests_work):
676         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
677           longer the only command this sends to WebKitTestRunner.
678         - If the `--leaks` switch is present, send the
679           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
680           result using Port.set_webkit_processes().
681         (Driver._parse_child_processes_output):
682         - Add helper method to parse list of child process names and
683           process IDs returned from WebKitTestRunner.
684
685         * Scripts/webkitpy/port/ios_device.py:
686         (IOSDevicePort.check_for_leaks):
687         - Rename redundant 'process_pid' argument to 'process_id'.
688
689         * Scripts/webkitpy/port/leakdetector.py:
690         (LeakDetector._parse_leaks_output):
691         - Return early if there is no leaks_output.
692         (LeakDetector.check_for_leaks):
693         - Rename redundant 'process_pid' argument to 'process_id'.
694
695         * Scripts/webkitpy/port/server_process.py:
696         (ServerProcess.__init__):
697         (ServerProcess.child_processes):
698         (ServerProcess.set_child_processes):
699         - Add instance variable to Port to store list of child process
700           names and process IDs returned from WebKitTestRunner.
701         (ServerProcess._start):
702         - Clear self._child_processes.
703         (ServerProcess.stop):
704         - If self._child_processes is set, call
705           self._port.check_for_leaks() for each child process.
706
707         * Scripts/webkitpy/port/server_process_unittest.py:
708         (TrivialMockPort.check_for_leaks):
709         - Rename redundant 'process_pid' argument to 'process_id'.
710
711         * Scripts/webkitpy/port/simulator_process.py:
712         (SimulatorProcess.stop):
713         - If self._child_processes is set, call
714           self._port.check_for_leaks() for each child process.
715
716         * Scripts/webkitpy/port/watch_device.py:
717         (WatchDevicePort.check_for_leaks):
718         - Rename redundant 'process_pid' argument to 'process_id'.
719
720         * WebKitTestRunner/TestController.cpp:
721         (WTR::TestController::dumpResponse):
722         - Extract method from findAndDumpWorldLeaks() so that it may be
723           reused by findAndDumpWebKitProcessIdentifiers().
724         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
725         - Add method to output process name and process ID of both the
726           WebContent and Networking processes.
727         (WTR::TestController::findAndDumpWorldLeaks):
728         - Fix missing newline in output when there were no abandoned
729           documents.
730         - Call dumpResponse() for extracted code.
731         (WTR::TestController::handleControlCommand):
732         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
733         - Use strncmp() instead of strcmp().
734         - Call findAndDumpWebKitProcessIdentifiers() when
735           "#LIST CHILD PROCESSES" command is sent.
736         * WebKitTestRunner/TestController.h:
737         (WTR::TestController::dumpResponse):
738         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
739         - Declare methods.
740
741 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
742
743         Unreviewed. Add GLib API test cases after r243434.
744
745         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
746         (testWebViewActiveURI):
747         (serverCallback):
748         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
749         (sendRequestCallback):
750
751 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
752
753         Geolocation request not complete when watch request was started in a different web process
754         https://bugs.webkit.org/show_bug.cgi?id=195996
755
756         Reviewed by Alex Christensen.
757
758         Add a test case.
759
760         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
761         (TestWebKitAPI::runJavaScriptAlert):
762         (TestWebKitAPI::TEST):
763
764 2019-03-26  Keith Rollin  <krollin@apple.com>
765
766         Update the way generate-xcfilelists returns strings from functions
767         https://bugs.webkit.org/show_bug.cgi?id=195975
768         <rdar://problem/49040807>
769
770         Reviewed by Dean Jackson.
771
772         There are places where generate-xcfilelists executes assignments with
773         statements like:
774
775             FOO=$(some_function)
776
777         where "some_function" return a string by echoing it. E.g.
778
779             some_function()
780             {
781                 echo "Hello, World"
782             }
783
784         This is a common idiom, but it has a problem if "some_function" needs
785         to call "exit" in an attempt to halt the entire script right then and
786         there. Since "some_function" is called inside of $(), it's being
787         executed in a sub-shell. Calling exit in that sub-shell simply exits
788         that shell; it doesn't not exit the outer shell in which the main part
789         of the script is still running. As such, the main script keeps
790         executing when the intent was for the script to halt.
791
792         The solution to this is to use a different idiom for returning
793         strings. The one we now is to pass in the name of the variable to
794         receive the string result:
795
796             some_function()
797             {
798                 variable_name=$1
799                 eval $variable_name ="Hello, World"
800             }
801
802         The call site now looks like
803
804             some_function FOO
805
806         Because there's no invocation of a sub-shell, some_function can now
807         call "exit" if it wants to, and the entire script will exit at that
808         point.
809
810         * Scripts/generate-xcfilelists:
811
812 2019-03-26  Chris Dumez  <cdumez@apple.com>
813
814         Add basic layout test coverage for File Picker on iOS
815         https://bugs.webkit.org/show_bug.cgi?id=196265
816
817         Reviewed by Wenson Hsieh.
818
819         Add layout test infrastructure to test the file picker on iOS.
820
821         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
822         (WTR::UIScriptController::dismissFilePicker):
823         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
824         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
825         (WTR::UIScriptController::dismissFilePicker):
826         * TestRunnerShared/UIScriptContext/UIScriptController.h:
827         * WebKitTestRunner/TestController.cpp:
828         (WTR::TestController::createWebViewWithOptions):
829         (WTR::updateTestOptionsFromTestHeader):
830         * WebKitTestRunner/TestOptions.h:
831         (WTR::TestOptions::hasSameInitializationOptions const):
832         * WebKitTestRunner/ios/TestControllerIOS.mm:
833         (overridePresentViewController):
834         (WTR::TestController::platformInitialize):
835         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
836         (WTR::UIScriptController::dismissFilePicker):
837
838 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
839
840         Implement async paste method on UIWKInteractionViewProtocol
841         https://bugs.webkit.org/show_bug.cgi?id=196267
842         <rdar://problem/49236346>
843
844         Reviewed by Tim Horton.
845
846         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
847         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
848         are now a part of all iOS 12 internal SDKs.
849
850         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
851
852         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
853         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
854
855         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
856         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
857         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
858         * TestWebKitAPI/ios/UIKitSPI.h:
859
860 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
861
862         [ews-build] Use PostgreSQL for ews.webkit.org database
863         https://bugs.webkit.org/show_bug.cgi?id=196270
864
865         Reviewed by Lucas Forschler.
866
867         * BuildSlaveSupport/ews-app/ews-app/settings.py:
868
869 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
870
871         [ews] Reset simctl states on reboot
872         https://bugs.webkit.org/show_bug.cgi?id=196260
873
874         Rubber-stamped by Aakash Jain.
875
876         * EWSTools/start-queue-mac.sh:
877
878 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
879
880         [ews-build] Use PostgreSQL for ews-build database
881         https://bugs.webkit.org/show_bug.cgi?id=196229
882
883         Reviewed by Lucas Forschler.
884
885         * BuildSlaveSupport/ews-build/master.cfg:
886
887 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
888
889         [ews-build] Get master_hostname dynamically in master.cfg
890         https://bugs.webkit.org/show_bug.cgi?id=196255
891
892         Reviewed by Lucas Forschler.
893
894         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
895         send events data in test mode.
896
897 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
898
899         [ews-app] Set db_constraint to False for Foreign Keys
900         https://bugs.webkit.org/show_bug.cgi?id=196252
901
902         Reviewed by Lucas Forschler.
903
904         * BuildSlaveSupport/ews-app/ews/models/build.py:
905         * BuildSlaveSupport/ews-app/ews/models/step.py:
906
907 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
908
909         [ews-build] is_test_mode_enabled should default to True
910         https://bugs.webkit.org/show_bug.cgi?id=196248
911
912         Reviewed by Lucas Forschler.
913
914         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
915
916 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
917
918         [ews-app] Add webkitperl to ENABLED_QUEUES
919         https://bugs.webkit.org/show_bug.cgi?id=196253
920
921         Reviewed by Lucas Forschler.
922
923         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
924
925 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
926
927         Address NSWindow sometimes using WebKitTestRunnerEvent too early
928         https://bugs.webkit.org/show_bug.cgi?id=196211
929         rdar://problem/49110552
930
931         Reviewed by Tim Horton.
932
933         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
934         Make sure that EventSenderProxy always exists when running tests. We used to create
935         it when resetting before the first test, which is a bit too late.
936
937         * WebKitTestRunner/TestController.h:
938         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
939         (WTR::TestController::platformCreateWebView):
940         (WTR::TestController::platformCreateOtherPage):
941         (WTR::TestController::finishCreatingPlatformWebView):
942         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
943         (WTR::PlatformWebView::PlatformWebView):
944         Moved some code that made NSWindow use NSEvent during web view creation. We may
945         need to move more if some other case us found, but this is enough for now.
946
947 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
948
949         Unreviewed. Fix typo in GLib geolocation API after r243285.
950
951         gelocation -> geolocation.
952
953         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
954         (testGeolocationManagerWatchPosition):
955
956 2019-03-25  Alex Christensen  <achristensen@webkit.org>
957
958         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
959         https://bugs.webkit.org/show_bug.cgi?id=196213
960
961         Reviewed by Geoff Garen.
962
963         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
964         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
965         (credentialWithIdentityAndKeychainPath):
966         (-[ChallengeDelegate webView:didFinishNavigation:]):
967         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
968         (TestWebKitAPI::TEST):
969
970 2019-03-25  Alex Christensen  <achristensen@webkit.org>
971
972         Expected shouldn't assume its contained types are copyable
973         https://bugs.webkit.org/show_bug.cgi?id=195986
974
975         Reviewed by JF Bastien.
976
977         * TestWebKitAPI/Tests/WTF/Expected.cpp:
978         (TestWebKitAPI::NonCopyable::operator== const):
979         (TestWebKitAPI::NonCopyable::operator!= const):
980         (TestWebKitAPI::TEST):
981
982 2019-03-25  Tim Horton  <timothy_horton@apple.com>
983
984         Remove some now-unnecessary dynamic class lookup
985         https://bugs.webkit.org/show_bug.cgi?id=196237
986
987         Reviewed by Simon Fraser.
988
989         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
990         (makeRequest):
991         (TEST):
992
993 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
994
995         Unreviewed, rolling out r243450.
996
997         AppleWin and WinCairo port builds get broken.
998
999         Reverted changeset:
1000
1001         "Add test for fix of #196095"
1002         https://bugs.webkit.org/show_bug.cgi?id=196097
1003         https://trac.webkit.org/changeset/243450
1004
1005 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1006
1007         Unreviewed, rolling out r243465.
1008         https://bugs.webkit.org/show_bug.cgi?id=196226
1009
1010         the test doesn't build (Requested by thorton on #webkit).
1011
1012         Reverted changeset:
1013
1014         "Do not terminate the NetworkProcess if a third party
1015         application sends a NSCredential with a SecIdentityRef"
1016         https://bugs.webkit.org/show_bug.cgi?id=196213
1017         https://trac.webkit.org/changeset/243465
1018
1019 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1020
1021         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1022         https://bugs.webkit.org/show_bug.cgi?id=196213
1023
1024         Reviewed by Geoff Garen.
1025
1026         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1027         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1028         (credentialWithIdentityAndKeychainPath):
1029         (-[ChallengeDelegate webView:didFinishNavigation:]):
1030         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1031         (TestWebKitAPI::TEST):
1032
1033 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1034
1035         [ews-build] Gracefully handle missing patch_id in events
1036         https://bugs.webkit.org/show_bug.cgi?id=196216
1037
1038         Reviewed by Lucas Forschler.
1039
1040         * BuildSlaveSupport/ews-build/events.py:
1041
1042 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1043
1044         [ews-build] use lz4 compression for improving buildbot performance
1045         https://bugs.webkit.org/show_bug.cgi?id=196155
1046
1047         Reviewed by Lucas Forschler.
1048
1049         * BuildSlaveSupport/ews-build/master.cfg:
1050
1051 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1052
1053         Pull some API testing helper methods out of TestWKWebView
1054         https://bugs.webkit.org/show_bug.cgi?id=196212
1055
1056         Reviewed by Tim Horton.
1057
1058         Refactor some more API testing utility methods, so that they can be used in
1059         tests that do not use TestWKWebView.
1060
1061         * TestWebKitAPI/cocoa/TestWKWebView.h:
1062         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1063         (-[WKWebView loadTestPageNamed:]):
1064         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1065         (-[WKWebView synchronouslyLoadHTMLString:]):
1066         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1067         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1068         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1069         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1070         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1071
1072 2019-03-25  Jer Noble  <jer.noble@apple.com>
1073
1074         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1075         https://bugs.webkit.org/show_bug.cgi?id=196097
1076
1077         Reviewed by Eric Carlson.
1078
1079         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1080
1081         * DumpRenderTree/mac/DumpRenderTree.mm:
1082         (resetWebPreferencesToConsistentValues):
1083         * WebKitTestRunner/TestController.cpp:
1084         (WTR::TestController::resetPreferencesToConsistentValues):
1085
1086 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1087
1088         Pull IPadUserInterfaceSwizzler out into a separate header file
1089         https://bugs.webkit.org/show_bug.cgi?id=196193
1090
1091         Reviewed by Anders Carlsson.
1092
1093         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1094         be used in other API tests.
1095
1096         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1097         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1098         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1099         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1100         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1101         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1102         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1103
1104 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1105
1106         Remove NavigatorContentUtils in WebCore/Modules
1107         https://bugs.webkit.org/show_bug.cgi?id=196070
1108
1109         Reviewed by Alex Christensen.
1110
1111         NavigatorContentUtils was to support the custom scheme spec [1].
1112         However, in WebKit side, no port has supported the feature in
1113         WebKit layer after EFL port was removed. So there has been the
1114         only IDL implementation of the NavigatorContentUtils in WebCore.
1115         So we don't need to keep the implementation in WebCore anymore.
1116
1117         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1118
1119         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1120
1121 2019-03-24  Andy Estes  <aestes@apple.com>
1122
1123         [watchOS] Remove unused Proximity Networking code
1124         https://bugs.webkit.org/show_bug.cgi?id=196188
1125
1126         Reviewed by Tim Horton.
1127
1128         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1129         (TEST):
1130
1131 2019-03-23  Keith Miller  <keith_miller@apple.com>
1132
1133         Refactor clz/ctz and fix getLSBSet.
1134         https://bugs.webkit.org/show_bug.cgi?id=196162
1135
1136         Reviewed by Saam Barati.
1137
1138         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1139
1140         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1141         (TestWebKitAPI::TEST):
1142
1143 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1144
1145         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1146         https://bugs.webkit.org/show_bug.cgi?id=196143
1147
1148         Reviewed by Michael Catanzaro.
1149
1150         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1151         directories.
1152
1153         * Scripts/webkitpy/style/checkers/cpp.py:
1154         (check_identifier_name_in_declaration):
1155         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1156         (WebKitStyleTest.test_names):
1157
1158 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1159
1160         [Flatpak] Manifest expanding fails for qt WPE extension
1161         https://bugs.webkit.org/show_bug.cgi?id=196148
1162
1163         Reviewed by Alex Christensen.
1164
1165         * flatpak/flatpakutils.py:
1166         (expand_submodules_recurse): The last recurse manifest expand
1167         iteration might lead to a single module so take it into account
1168         and don't try to recurse further.
1169
1170 2019-03-22  Chris Dumez  <cdumez@apple.com>
1171
1172         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1173         https://bugs.webkit.org/show_bug.cgi?id=195348
1174         <rdar://problem/48622090>
1175
1176         Reviewed by Alex Christensen.
1177
1178         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1179         to NO when test.options().shouldIgnoreMetaViewport is false.
1180
1181         * WebKitTestRunner/ios/TestControllerIOS.mm:
1182         (WTR::TestController::platformConfigureViewForTest):
1183
1184 2019-03-22  Chris Dumez  <cdumez@apple.com>
1185
1186         Prewarmed processes should be usable with any website data store
1187         https://bugs.webkit.org/show_bug.cgi?id=196104
1188
1189         Reviewed by Alex Christensen.
1190
1191         Add API test coverage.
1192
1193         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1194         (runInitialWarmedProcessUsedTest):
1195         (TEST):
1196
1197 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1198
1199         Back out local changes to Alex's Subversion working directory
1200
1201         They were accidentally committed.
1202
1203         * Scripts/webkitpy/common/system/abstractexecutive.py:
1204         (AbstractExecutive.wait_newest):
1205         * Scripts/webkitpy/common/system/executive.py:
1206         (Executive.running_pids):
1207         * Scripts/webkitpy/common/system/executive_mock.py:
1208         (MockExecutive.running_pids):
1209         * Scripts/webkitpy/common/system/executive_unittest.py:
1210         (ExecutiveTest.serial_test_running_pids):
1211         * Scripts/webkitpy/port/darwin.py:
1212         (DarwinPort.check_for_leaks):
1213         * Scripts/webkitpy/port/leakdetector.py:
1214         (LeakDetector.check_for_leaks):
1215         - This was the hack attached to Bug 193772.
1216
1217         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1218         (+[WebKitTestRunnerEvent mouseLocation]):
1219         - This works around a crash on an internal build.
1220
1221 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1222
1223         Fix the build after r243354
1224         https://bugs.webkit.org/show_bug.cgi?id=196138
1225         <rdar://problem/49145951>
1226
1227         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1228         (TEST):
1229         * TestWebKitAPI/ios/UIKitSPI.h:
1230
1231 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1232
1233         Adopt UIWKDocumentContext
1234         https://bugs.webkit.org/show_bug.cgi?id=196040
1235         <rdar://problem/48642440>
1236
1237         Reviewed by Ryosuke Niwa.
1238
1239         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1240         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1241         (makeRequest):
1242         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1243         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1244         (applyStyle):
1245         (TEST):
1246         Add tests for UIWKDocumentContext.
1247
1248         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1249         (TEST):
1250         (recursiveFindWKContentView): Deleted.
1251         * TestWebKitAPI/cocoa/TestWKWebView.h:
1252         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1253         (recursiveFindWKContentView):
1254         (-[TestWKWebView wkContentView]):
1255         * TestWebKitAPI/ios/UIKitSPI.h:
1256         Share the WKContentView finding code between tests.
1257
1258 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1259
1260         [iOS WK2] Turn on async overflow scrolling by default
1261         https://bugs.webkit.org/show_bug.cgi?id=196011
1262         rdar://problem/48453859
1263
1264         Reviewed by Antti Koivisto.
1265         
1266         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1267         since so many basic layout tests have different results when compositing is triggered for
1268         overflow.
1269         
1270         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1271
1272         * WebKitTestRunner/TestController.cpp:
1273         (WTR::TestController::resetPreferencesToConsistentValues):
1274
1275 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1276
1277         [ews-build] Retry API test in case of failures
1278         https://bugs.webkit.org/show_bug.cgi?id=196004
1279
1280         Reviewed by Lucas Forschler.
1281
1282         * BuildSlaveSupport/ews-build/steps.py:
1283         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1284         (CompileWebKitToT.doStepIf): Ditto.
1285         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1286         (ReRunAPITests): Re-run API tests.
1287         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1288         (RunAPITestsWithoutPatch): Run API tests without patch.
1289         (RunAPITestsWithoutPatch.doStepIf):
1290         (RunAPITestsWithoutPatch.hideStepIf):
1291         (RunAPITestsWithoutPatch.evaluateCommand):
1292         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1293         (AnalyzeAPITestsResults.start):
1294         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1295         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1296         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1297         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1298
1299 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1300
1301         [ews-build] Update queues configurations
1302         https://bugs.webkit.org/show_bug.cgi?id=196074
1303
1304         Reviewed by Dewei Zhu.
1305
1306         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1307         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1308
1309 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1310
1311         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1312         https://bugs.webkit.org/show_bug.cgi?id=195680
1313         <rdar://problem/48903534>
1314
1315         Unreviewed infrastructure fix.
1316
1317         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1318         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1319
1320 2019-03-21  Andy Estes  <aestes@apple.com>
1321
1322         [iOS] Apple Pay should be available in documents with no user agent scripts
1323         https://bugs.webkit.org/show_bug.cgi?id=196061
1324         <rdar://problem/48649391>
1325
1326         Reviewed by Brady Eidson.
1327
1328         Added API tests and related infrastructure.
1329
1330         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1331         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1332         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1333         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1334         (TestWebKitAPI::TEST):
1335         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1336         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1337         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1338         * TestWebKitAPI/cocoa/TestProtocol.mm:
1339         (-[TestProtocol startLoading]):
1340         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1341         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1342         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1343         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1344
1345 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1346
1347         REGRESSSION (r243297): webkitpy tests broken
1348         https://bugs.webkit.org/show_bug.cgi?id=196108
1349
1350         Reviewed by Aakash Jain.
1351
1352         r243297 updated contributors.json, which broke a few unit tests.
1353
1354         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1355         (IRCCommandTest.test_whois):
1356         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1357
1358 2019-03-21  Chris Dumez  <cdumez@apple.com>
1359
1360         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1361         https://bugs.webkit.org/show_bug.cgi?id=196041
1362         <rdar://problem/49083230>
1363
1364         Reviewed by Alex Christensen.
1365
1366         Add API test coverage.
1367
1368         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1369         (TEST):
1370
1371 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1372
1373         Add SPI to inform applications of WKContentRuleList actions
1374         https://bugs.webkit.org/show_bug.cgi?id=195965
1375         <rdar://problem/42664365>
1376
1377         Reviewed by Geoff Garen.
1378
1379         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1380         (TestWebKitAPI::allActionsForResourceLoad):
1381         (TestWebKitAPI::testRequest):
1382         (TestWebKitAPI::TEST_F):
1383         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1384         (Notification::description):
1385         (Notification::operator== const):
1386         (toVector):
1387         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1388         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1389         (makeContentRuleList):
1390         (TEST):
1391         (makeWarnContentRuleList): Deleted.
1392
1393 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1394
1395         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1396         https://bugs.webkit.org/show_bug.cgi?id=196088
1397
1398         Reviewed by Brian Burg.
1399
1400         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1401         Support checks when only one platform is specified. Also deprecate macosx() and
1402         force the use of macos() instead.
1403
1404         * Scripts/webkitpy/style/checkers/cpp.py:
1405         (check_min_versions_of_wk_api_available):
1406         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1407         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1408
1409 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1410
1411         Update status inactive committers' status to 'contributor'.
1412
1413         * Scripts/webkitpy/common/config/contributors.json:
1414
1415 2019-03-21  Xan Lopez  <xan@igalia.com>
1416
1417         [JSC][x86] Drop support for x87 floating point
1418         https://bugs.webkit.org/show_bug.cgi?id=194853
1419
1420         Reviewed by Don Olmstead.
1421
1422         Force SSE2 on x86/32bit builds.
1423
1424         * Scripts/webkitdirs.pm:
1425         (generateBuildSystemFromCMakeProject):
1426
1427 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1428
1429         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1430         https://bugs.webkit.org/show_bug.cgi?id=196073
1431
1432         Reviewed by Michael Catanzaro.
1433
1434         Add test cases to check functions and constructors with no arguments but receiving user data.
1435
1436         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1437         (checkUserData):
1438         (testJSCFunction):
1439         (fooCreateWithUserData):
1440         (testJSCClass):
1441
1442 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1443
1444         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1445
1446         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1447
1448         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1449
1450 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1451
1452         [GTK][WPE] Add API to provide geolocation information
1453         https://bugs.webkit.org/show_bug.cgi?id=195940
1454
1455         Reviewed by Michael Catanzaro.
1456
1457         Add a new test to check the new API.
1458
1459         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1460         (testGeolocationManagerCurrentPosition):
1461         (testGeolocationManagerWatchPosition):
1462         (beforeAll):
1463         (afterAll):
1464         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1465         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1466         (beforeAll): Ditto.
1467         * TestWebKitAPI/glib/CMakeLists.txt:
1468
1469 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1470
1471         [GLib] Returning G_TYPE_OBJECT from a method does not work
1472         https://bugs.webkit.org/show_bug.cgi?id=195574
1473
1474         Reviewed by Michael Catanzaro.
1475
1476         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1477
1478         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1479         (getGFile):
1480         (getParent):
1481         (createGString):
1482         (getGString):
1483         (getGStringCopyWillRaise):
1484         (getGStringCopy):
1485         (getGStringStr):
1486         (getGStringLen):
1487         (freeGString):
1488         (testJSCClass):
1489
1490 2019-03-20  Saam Barati  <sbarati@apple.com>
1491
1492         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1493         https://bugs.webkit.org/show_bug.cgi?id=195721
1494
1495         Reviewed by Filip Pizlo.
1496
1497         * Scripts/run-javascriptcore-tests:
1498
1499 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1500
1501         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
1502         https://bugs.webkit.org/show_bug.cgi?id=196049
1503
1504         Reviewed by Tim Horton.
1505
1506         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
1507         overflow scrolling in general, so rename it.
1508
1509         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1510
1511 2019-03-20  Daniel Bates  <dabates@apple.com>
1512
1513         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
1514         https://bugs.webkit.org/show_bug.cgi?id=196031
1515         <rdar://problem/49078172>
1516
1517         Reviewed by Tim Horton.
1518
1519         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
1520         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
1521         same code path used when the Done button is pressed to dismiss the <select> picker.
1522
1523         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1524         (TestWebKitAPI::TEST):
1525
1526 2019-03-20  Chris Dumez  <cdumez@apple.com>
1527
1528         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
1529         https://bugs.webkit.org/show_bug.cgi?id=196029
1530         <rdar://problem/48954651>
1531
1532         Reviewed by Tim Horton.
1533
1534         Add API test coverage.
1535
1536         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1537
1538 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
1539
1540         [ews-build] Improve failure summary string for ApplyPatch step
1541         https://bugs.webkit.org/show_bug.cgi?id=195995
1542
1543         Reviewed by Alexey Proskuryakov.
1544
1545         * BuildSlaveSupport/ews-build/steps.py:
1546         (ApplyPatch.getResultSummary): Override getResultSummary.
1547
1548 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
1549
1550         AX: Implement support for new meter ARIA role
1551         https://bugs.webkit.org/show_bug.cgi?id=195966
1552
1553         Reviewed by Chris Fleizach.
1554
1555         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
1556         to AXLevelIndicator.
1557
1558         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1559
1560 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
1561
1562         [WebAuthN] Implement FIDO AppID extension
1563         https://bugs.webkit.org/show_bug.cgi?id=143491
1564         <rdar://problem/48298273>
1565
1566         Reviewed by Brent Fulgham.
1567
1568         Add a test that covers the new flag of convertToU2fSignCommand.
1569
1570         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
1571         (TestWebKitAPI::TEST):
1572         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1573         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
1574         (TestWebKitAPI::TEST):
1575
1576 2019-03-19  Keith Rollin  <krollin@apple.com>
1577
1578         Add support for more platforms to generate-xcfilelists
1579         https://bugs.webkit.org/show_bug.cgi?id=195977
1580
1581         Reviewed by Alexey Proskuryakov.
1582
1583         generate-xcfilelists incorrectly complains when involved with building
1584         WebKit for iphonesimulator:
1585
1586             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
1587             …
1588             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
1589
1590         Address this by teaching generate-xcfilelists about more platforms.
1591
1592         * Scripts/generate-xcfilelists:
1593
1594 2019-03-19  John Wilander  <wilander@apple.com>
1595
1596         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
1597         https://bugs.webkit.org/show_bug.cgi?id=195923
1598         <rdar://problem/49001272>
1599
1600         Reviewed by Alex Christensen.
1601
1602         This patch does the following to the TestRunner:
1603         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
1604         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
1605         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
1606
1607         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1608         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1609         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1610         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1611         * WebKitTestRunner/TestController.cpp:
1612         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1613         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1614         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1615         * WebKitTestRunner/TestController.h:
1616         * WebKitTestRunner/TestInvocation.cpp:
1617         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1618
1619 2019-03-19  Christopher Reid  <chris.reid@sony.com>
1620
1621         [CMake] Support more clang and gcc sanitizers
1622         https://bugs.webkit.org/show_bug.cgi?id=195956
1623
1624         Reviewed by Michael Catanzaro.
1625
1626         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
1627
1628 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1629
1630         [ews-build] Improve summary for PrintConfiguration step
1631         https://bugs.webkit.org/show_bug.cgi?id=195945
1632
1633         Reviewed by Lucas Forschler.
1634
1635         * BuildSlaveSupport/ews-build/steps.py:
1636         (PrintConfiguration.getResultSummary): Override getResultSummary.
1637
1638 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1639
1640         [ews-build] Improve summary for CheckOutSource step
1641         https://bugs.webkit.org/show_bug.cgi?id=195963
1642
1643         Reviewed by Lucas Forschler.
1644
1645         * BuildSlaveSupport/ews-build/steps.py:
1646         (CheckOutSource.getResultSummary):
1647
1648 2019-03-19  Daniel Bates  <dabates@apple.com>
1649
1650         [iOS] Focus not preserved when switching between tabs
1651         https://bugs.webkit.org/show_bug.cgi?id=195820
1652         <rdar://problem/43614450>
1653
1654         Reviewed by Brent Fulgham.
1655
1656         Add tests to ensure that we restore focus when resigning and becoming first responder.
1657
1658         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1659         (TestWebKitAPI::TEST):
1660
1661 2019-03-19  Alex Christensen  <achristensen@webkit.org>
1662
1663         Make WTFLogChannelState and WTFLogLevel enum classes
1664         https://bugs.webkit.org/show_bug.cgi?id=195904
1665
1666         Reviewed by Eric Carlson.
1667
1668         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1669         (TestWebKitAPI::TEST_F):
1670
1671 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1672
1673         [GStreamer][EME] Backported mssdemux protection data crash fix
1674         https://bugs.webkit.org/show_bug.cgi?id=195918
1675
1676         Reviewed by Philippe Normand.
1677
1678         * gstreamer/jhbuild.modules:
1679         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
1680
1681 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1682
1683         Unreviewed, rolling out r243132.
1684
1685         Broke GTK build
1686
1687         Reverted changeset:
1688
1689         "Make WTFLogChannelState and WTFLogLevel enum classes"
1690         https://bugs.webkit.org/show_bug.cgi?id=195904
1691         https://trac.webkit.org/changeset/243132
1692
1693 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
1694
1695         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
1696
1697         * Scripts/webkitdirs.pm:
1698         (builtDylibPathForName): Adjust the shared library name that's changed
1699         with the API version bump in r243073.
1700
1701 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1702
1703         Make WTFLogChannelState and WTFLogLevel enum classes
1704         https://bugs.webkit.org/show_bug.cgi?id=195904
1705
1706         Reviewed by Eric Carlson.
1707
1708         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1709         (TestWebKitAPI::TEST_F):
1710
1711 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1712
1713         Disable flaky test added in r2431100
1714         https://webkit.org/b/195785
1715
1716         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1717         (TestWebKitAPI::TEST):
1718         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
1719
1720 2019-03-18  Timothy Hatcher  <timothy@apple.com>
1721
1722         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
1723         https://bugs.webkit.org/show_bug.cgi?id=195916
1724
1725         Reviewed by Tim Horton.
1726
1727         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1728         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
1729
1730 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
1731
1732         Add a secondary e-mail address for Fujii Hironori to make tools happier.
1733
1734         * Scripts/webkitpy/common/config/contributors.json:
1735
1736 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1737
1738         Implement DownloadMonitor to prevent long-running slow downloads from background apps
1739         https://bugs.webkit.org/show_bug.cgi?id=195785
1740
1741         Reviewed by Geoffrey Garen.
1742
1743         * TestWebKitAPI/TCPServer.cpp: Added.
1744         (TestWebKitAPI::TCPServer::TCPServer):
1745         (TestWebKitAPI::TCPServer::~TCPServer):
1746         (TestWebKitAPI::TCPServer::socketBindListen):
1747         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
1748         * TestWebKitAPI/TCPServer.h: Added.
1749         (TestWebKitAPI::TCPServer::port const):
1750         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1751         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1752         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
1753         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
1754         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1755         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
1756         (TestWebKitAPI::respondSlowly):
1757         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
1758         (TestWebKitAPI::downloadAtRate):
1759         (TestWebKitAPI::TEST):
1760
1761 2019-03-18  Saam Barati  <sbarati@apple.com>
1762
1763         Add a plan file for JetStream 2
1764         https://bugs.webkit.org/show_bug.cgi?id=190734
1765
1766         Reviewed by Mark Lam.
1767
1768         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
1769
1770 2019-03-18  Chris Dumez  <cdumez@apple.com>
1771
1772         Delay WebProcess launch until a load is triggered in a Web view
1773         https://bugs.webkit.org/show_bug.cgi?id=195758
1774         <rdar://problem/48126013>
1775
1776         Reviewed by Geoff Garen.
1777
1778         Add API test coverage. Also update some existing API tests to not expect
1779         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
1780
1781         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
1782         (TestWebKitAPI::TEST):
1783         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
1784         (TestWebKitAPI::TEST):
1785         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1786         (TEST):
1787         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1788         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1789         (TEST):
1790         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1791         (TEST):
1792         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
1793
1794 2019-03-18  Xan Lopez  <xan@igalia.com>
1795
1796         [CMake] Prevent potential warning when determining $architecture
1797         https://bugs.webkit.org/show_bug.cgi?id=195891
1798
1799         Reviewed by Michael Catanzaro.
1800
1801         It's possible for generateBuildSystemForCMakeProject to be called
1802         before determineArchitecture() is ever called. This will make the
1803         first eq check with $architecture to be bogus (and print a
1804         warning). Change that to an eq check with architecture(), which
1805         implicitly calls determineArchitecture() if needed, and change all
1806         the other similar cases in the method in the same way to prevent
1807         future bugs like this one.
1808
1809         * Scripts/webkitdirs.pm:
1810         (generateBuildSystemFromCMakeProject):
1811
1812 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1813
1814         [WPE] Tarballs generated with “make dist” cannot build documentation
1815         https://bugs.webkit.org/show_bug.cgi?id=195885
1816
1817         Reviewed by Carlos Garcia Campos.
1818
1819         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
1820
1821 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1822
1823         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
1824         https://bugs.webkit.org/show_bug.cgi?id=195883
1825
1826         Reviewed by Carlos Garcia Campos.
1827
1828         * gtkdoc/gtkdoc.py:
1829         (GTKDoc._run_command): When commands fail to run, include the full command line for
1830         the program invocation and the output it has generated on the standard error stream.
1831
1832 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1833
1834         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
1835         https://bugs.webkit.org/show_bug.cgi?id=195786
1836
1837         Reviewed by Philippe Normand.
1838
1839         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
1840         * wpe/jhbuild.modules: Ditto.
1841
1842 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
1843
1844         [ews-build] Don't run clean builds on EWS builders
1845         https://bugs.webkit.org/show_bug.cgi?id=195851
1846
1847         Reviewed by Geoffrey Garen.
1848
1849         * BuildSlaveSupport/ews-build/factories.py:
1850
1851 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
1852
1853         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
1854         https://bugs.webkit.org/show_bug.cgi?id=195849
1855
1856         Reviewed by Chris Dumez.
1857
1858         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
1859
1860         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1861         (runWebsiteDataStoreCustomPaths):
1862
1863 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
1864
1865         webkitpy: Upload test results
1866         https://bugs.webkit.org/show_bug.cgi?id=195755
1867         <rdar://problem/48896182>
1868
1869         Reviewed by Aakash Jain.
1870
1871         Establish a new format for uploading results that is not tied to layout tests, apply
1872         that format to webkitpy tests.
1873
1874         * Scripts/webkitpy/common/checkout/scm/git.py:
1875         (Git.native_branch): Return what branch the current checkout is on.
1876         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1877         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1878         * Scripts/webkitpy/common/checkout/scm/svn.py:
1879         (SVN.native_branch): Ditto.
1880         * Scripts/webkitpy/common/system/platforminfo.py:
1881         (PlatformInfo.build_version): Return a build version for Mac.
1882         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1883         (MockPlatformInfo.__init__):
1884         (MockPlatformInfo.build_version):
1885         * Scripts/webkitpy/results: Added.
1886         * Scripts/webkitpy/results/__init__.py: Added.
1887         * Scripts/webkitpy/results/options.py: Added.
1888         (upload_options): OptParse list for upload options.
1889         * Scripts/webkitpy/results/upload.py: Added.
1890         (Upload): Class which enforces the upload format expected by the results server.
1891         (Upload.Expectations):
1892         (Upload.create_configuration):
1893         (Upload.create_commit):
1894         (Upload.create_details):
1895         (Upload.create_run_stats):
1896         (Upload.create_test_result):
1897         (Upload.__init__):
1898         (Upload.Encoder): Encode Upload object as json.
1899         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
1900         * Scripts/webkitpy/results/upload_unittest.py: Added.
1901         * Scripts/webkitpy/test/main.py:
1902         (Tester._parse_args): Add upload arguments.
1903         (Tester._run_tests): Allow results to be uploaded.
1904         * Scripts/webkitpy/test/runner.py:
1905         (Runner.__init__): Record which tests were run, rather than just counting them.
1906         (Runner.handle):
1907         * Scripts/webkitpy/test/runner_unittest.py:
1908         (RunnerTest.test_run):
1909         * Scripts/webkitpy/thirdparty/__init__.py:
1910         (AutoinstallImportHook.find_module): Add requests auto-install.
1911         (AutoinstallImportHook._install_requests):
1912         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1913         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
1914
1915 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1916
1917         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
1918         https://bugs.webkit.org/show_bug.cgi?id=195810
1919
1920         Reviewed by Tim Horton.
1921
1922         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
1923         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
1924         ending certain layout tests.
1925
1926         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1927         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1928         (-[TestRunnerWKWebView dealloc]):
1929         (-[TestRunnerWKWebView resetInteractionCallbacks]):
1930
1931         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
1932         helper method when destroying the web view, and when resetting state between tests.
1933
1934         * WebKitTestRunner/ios/TestControllerIOS.mm:
1935         (WTR::TestController::platformResetStateToConsistentValues):
1936
1937         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
1938
1939 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
1940
1941         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
1942         https://bugs.webkit.org/show_bug.cgi?id=190350
1943         <rdar://problem/45089503>
1944
1945         Reviewed by Geoffrey Garen.
1946
1947         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1948         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
1949         (TEST):
1950         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
1951         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
1952         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
1953         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
1954         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
1955         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
1956         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
1957         (runTest):
1958         (createDirectories):
1959         (TEST):
1960         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
1961         (TEST):
1962         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
1963         (TEST):
1964
1965 2019-03-15  Timothy Hatcher  <timothy@apple.com>
1966
1967         Add support to WebPage for getting the contents as an attributed string.
1968         https://bugs.webkit.org/show_bug.cgi?id=195636
1969         rdar://problem/45055697
1970
1971         Reviewed by Tim Horton.
1972
1973         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1974         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
1975
1976 2019-03-15  Chris Dumez  <cdumez@apple.com>
1977
1978         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
1979         https://bugs.webkit.org/show_bug.cgi?id=195747
1980
1981         Reviewed by Geoff Garen.
1982
1983         Add API test coverage.
1984
1985         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1986
1987 2019-03-15  Shawn Roberts  <sroberts@apple.com>
1988
1989         Unreviewed, rolling out r242952.
1990
1991         Causing API failures on iOS Simulator
1992
1993         Reverted changeset:
1994
1995         "[PSON] Make sure the WebProcessCache is leverage when
1996         relaunching a process after termination"
1997         https://bugs.webkit.org/show_bug.cgi?id=195747
1998         https://trac.webkit.org/changeset/242952
1999
2000 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2001
2002         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2003         https://bugs.webkit.org/show_bug.cgi?id=195740
2004
2005         Reviewed by Ross Kirsling.
2006
2007         window.open doesn't work for WebKitBrowserWindow because it is not
2008         implemented yet.
2009
2010         1. Implemented createNewPage callback of WKPageUIClient.
2011         2. Changed MainWindow to take a BrowserWindow factory function
2012           instead of BrowserWindowType to be flexible to create
2013           BrowserWindow with extra settings.
2014         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2015           because it is not relevant with MainWindow anymore.
2016
2017         * MiniBrowser/win/Common.cpp:
2018         (parseCommandLine):
2019         * MiniBrowser/win/Common.h:
2020         (CommandLineOptions::CommandLineOptions):
2021         * MiniBrowser/win/MainWindow.cpp:
2022         (MainWindow::MainWindow):
2023         (MainWindow::create):
2024         (MainWindow::init):
2025         (MainWindow::WndProc):
2026         * MiniBrowser/win/MainWindow.h:
2027         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2028         (PrintWebUIDelegate::createWebViewWithRequest):
2029         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2030         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2031         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2032         (WebKitBrowserWindow::updateProxySettings):
2033         (WebKitBrowserWindow::createNewPage):
2034         * MiniBrowser/win/WebKitBrowserWindow.h:
2035         * MiniBrowser/win/WinMain.cpp:
2036         (wWinMain):
2037
2038 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2039
2040         Make it possible to test scrolling tree layer manipulation more easily
2041         https://bugs.webkit.org/show_bug.cgi?id=195780
2042
2043         Reviewed by Tim Horton.
2044         
2045         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2046         cuts off communication of scrolling tree scrolls back to the web process
2047         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2048         allows tests to trigger scrolls which run the scrolling tree layer positioning
2049         logic, but never get another commit from the web process that might mask
2050         scrolling tree bugs.
2051         
2052         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2053         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2054         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2055
2056         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2057         (WTR::UIScriptController::scrollUpdatesDisabled const):
2058         (WTR::UIScriptController::setScrollUpdatesDisabled):
2059         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2060         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2061         (WTR::UIScriptController::scrollUpdatesDisabled const):
2062         (WTR::UIScriptController::setScrollUpdatesDisabled):
2063         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2064         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2065         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2066         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2067         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2068         * WebKitTestRunner/ios/TestControllerIOS.mm:
2069         (WTR::TestController::platformResetStateToConsistentValues):
2070         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2071         (WTR::UIScriptController::scrollUpdatesDisabled const):
2072         (WTR::UIScriptController::setScrollUpdatesDisabled):
2073
2074 2019-03-14  Youenn Fablet  <youenn@apple.com>
2075
2076         Move IDB storage in private browsing mode to NetworkProcess
2077         https://bugs.webkit.org/show_bug.cgi?id=195602
2078
2079         Reviewed by Brady Eidson.
2080
2081         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2082         (TEST):
2083
2084 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2085
2086         [ews-build] Make descriptionDone messages more readable
2087         https://bugs.webkit.org/show_bug.cgi?id=195760
2088
2089         Reviewed by Lucas Forschler.
2090
2091         * BuildSlaveSupport/ews-build/steps.py:
2092         * BuildSlaveSupport/ews-build/steps_unittest.py:
2093
2094 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2095
2096         [ews-build] Generate status-bubble hover-over messages
2097         https://bugs.webkit.org/show_bug.cgi?id=195680
2098
2099         Reviewed by Lucas Forschler.
2100
2101         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2102         (StatusBubble):
2103         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2104         on hover-over.
2105         (StatusBubble._iso_time):
2106         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2107         hover-over message.
2108         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2109
2110 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2111
2112         [ews-app] Gracefully handle the case when state_string is None
2113         https://bugs.webkit.org/show_bug.cgi?id=195753
2114
2115         Reviewed by Lucas Forschler.
2116
2117         * BuildSlaveSupport/ews-app/ews/models/build.py:
2118         * BuildSlaveSupport/ews-app/ews/models/step.py:
2119
2120 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2121
2122         [ews-app] Status bubble display pending for currently running build step
2123         https://bugs.webkit.org/show_bug.cgi?id=195744
2124
2125         Reviewed by Lucas Forschler.
2126
2127         * BuildSlaveSupport/ews-build/events.py:
2128         (Events.stepStarted): If state_string is pending, replace it with step name.
2129
2130 2019-03-14  Chris Dumez  <cdumez@apple.com>
2131
2132         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2133         https://bugs.webkit.org/show_bug.cgi?id=195750
2134
2135         Reviewed by Geoffrey Garen.
2136
2137         Add API test coverage.
2138
2139         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2140         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2141         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2142         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2143
2144 2019-03-14  Chris Dumez  <cdumez@apple.com>
2145
2146         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2147         https://bugs.webkit.org/show_bug.cgi?id=195747
2148
2149         Reviewed by Geoff Garen.
2150
2151         Add API test coverage.
2152
2153         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2154
2155 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2156
2157         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2158         https://bugs.webkit.org/show_bug.cgi?id=195725
2159         <rdar://problem/48545062>
2160
2161         Reviewed by Tim Horton.
2162
2163         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2164         handler is nil.
2165
2166         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2167         (TestWebKitAPI::TEST):
2168
2169 2019-03-13  Sam Weinig  <sam@webkit.org>
2170
2171         Add utility function to allow easy reverse range-based iteration of a container
2172         https://bugs.webkit.org/show_bug.cgi?id=195542
2173
2174         Reviewed by Antti Koivisto.
2175
2176         * TestWebKitAPI/CMakeLists.txt:
2177         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2178         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2179         (TestWebKitAPI::TEST):
2180         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2181
2182 2019-03-13  Chris Dumez  <cdumez@apple.com>
2183
2184         Use a ServiceWorker process per registrable domain
2185         https://bugs.webkit.org/show_bug.cgi?id=195649
2186
2187         Reviewed by Youenn Fablet.
2188
2189         Update API test coverage.
2190
2191         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2192
2193 2019-03-13  Chris Dumez  <cdumez@apple.com>
2194
2195         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2196         https://bugs.webkit.org/show_bug.cgi?id=195684
2197         <rdar://problem/48294714>
2198
2199         Reviewed by Antti Koivisto.
2200
2201         Add API test coverage.
2202
2203         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2204
2205 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2206
2207         [ews-app] Remove unused patch view
2208         https://bugs.webkit.org/show_bug.cgi?id=195669
2209
2210         Reviewed by Lucas Forschler.
2211
2212         * BuildSlaveSupport/ews-app/ews/urls.py:
2213         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2214
2215 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2216
2217         [ews-app] Use Buildbot result code variables
2218         https://bugs.webkit.org/show_bug.cgi?id=195668
2219
2220         Reviewed by Alexey Proskuryakov.
2221
2222         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2223         (Buildbot): Added Buildbot result code variables.
2224         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2225         (StatusBubble._build_bubble): Used Buildbot result code variables.
2226
2227 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2228
2229         [Flatpak] Expand submodule recursively
2230         https://bugs.webkit.org/show_bug.cgi?id=195672
2231
2232         Building WPE with flatpak was impossible without that as it was raising an exception.
2233         Also update wpebackend-fdo to match what is built in jhbuild
2234
2235         Reviewed by Philippe Normand.
2236
2237         * flatpak/flatpakutils.py:
2238         (expand_submodules_recurse):
2239         (expand_manifest):
2240         * flatpak/org.webkit.WPEModules.yaml:
2241
2242 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2243
2244         [ews-app] status bubble should be hidden for certain builds
2245         https://bugs.webkit.org/show_bug.cgi?id=194597
2246
2247         Reviewed by Dewei Zhu.
2248
2249         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2250         (StatusBubble._build_bubble):
2251         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2252         because the patch didn't have relevant changes.
2253         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2254         in production yet.
2255
2256 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2257
2258         [Win] Fix a slew of simple clang-cl warnings.
2259         https://bugs.webkit.org/show_bug.cgi?id=195652
2260
2261         Reviewed by Don Olmstead.
2262
2263         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2264         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2265
2266 2019-03-12  Justin Fan  <justin_fan@apple.com>
2267
2268         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2269         https://bugs.webkit.org/show_bug.cgi?id=195518
2270         <rdar://problem/46322356>
2271
2272         Reviewed by Myles C. Maxfield.
2273
2274         * DumpRenderTree/DerivedSources-input.xcfilelist:
2275         * DumpRenderTree/DerivedSources-output.xcfilelist:
2276
2277 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2278
2279         Unreviewed, rolling out r242825.
2280         https://bugs.webkit.org/show_bug.cgi?id=195648
2281
2282         "Broke webkitpy tests with my change to
2283         lldb_dump_class_layout.py" (Requested by rmorisset on
2284         #webkit).
2285
2286         Reverted changeset:
2287
2288         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2289         classes with suspicious padding"
2290         https://bugs.webkit.org/show_bug.cgi?id=195573
2291         https://trac.webkit.org/changeset/242825
2292
2293 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2294
2295         [ews-build] Show status bubbles while the patch is waiting in queue
2296         https://bugs.webkit.org/show_bug.cgi?id=195618
2297
2298         Reviewed by Lucas Forschler.
2299
2300         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2301         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2302         enabled in initial deployment.
2303         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2304         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2305         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2306         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2307         (StatusBubble._build_bubbles_for_patch):
2308
2309 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2310
2311         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2312         https://bugs.webkit.org/show_bug.cgi?id=195573
2313
2314         Reviewed by Simon Fraser.
2315
2316         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2317
2318         * Scripts/dump-class-layout:
2319         (main):
2320         * lldb/lldb_dump_class_layout.py:
2321         (ClassLayout.__init__):
2322         (ClassLayout._compute_padding_recursive):
2323         (LLDBDebuggerInstance.dump_layout_for_classname):
2324         (LLDBDebuggerInstance):
2325         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2326         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2327
2328 2019-03-12  Chris Dumez  <cdumez@apple.com>
2329
2330         Device Orientation access permission should be denied unless explicitly granted by the client
2331         https://bugs.webkit.org/show_bug.cgi?id=195625
2332
2333         Reviewed by Youenn Fablet.
2334
2335         add API test coverage.
2336
2337         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2338         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2339         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2340         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2341         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2342         (runDeviceOrientationTest):
2343         (TEST):
2344         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2345         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2346
2347 2019-03-12  Jer Noble  <jer.noble@apple.com>
2348
2349         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2350         https://bugs.webkit.org/show_bug.cgi?id=195137
2351         <rdar://problem/48810307>
2352
2353         Reviewed by Eric Carlson.
2354
2355         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2356         (TestWebKitAPI::TEST):
2357
2358 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2359
2360         [ews-build] Change urls from uat to production
2361         https://bugs.webkit.org/show_bug.cgi?id=195566
2362
2363         Reviewed by Lucas Forschler.
2364
2365         * BuildSlaveSupport/ews-app/ews/config.py:
2366         * BuildSlaveSupport/ews-build/events.py:
2367         * BuildSlaveSupport/ews-build/steps.py:
2368
2369 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2370
2371         [ews-build] change max_builds for local-worker to 1
2372         https://bugs.webkit.org/show_bug.cgi?id=195568
2373
2374         Reviewed by Lucas Forschler.
2375
2376         * BuildSlaveSupport/ews-build/loadConfig.py:
2377
2378 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2379
2380         Fix the build
2381
2382         * TestRunnerShared/spi/PencilKitTestSPI.h:
2383         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2384
2385 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2386
2387         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2388         https://bugs.webkit.org/show_bug.cgi?id=194131
2389
2390         Reviewed by Michael Catanzaro.
2391
2392         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2393         (uriChanged):
2394         (testUnfinishedSubresourceLoad):
2395         (serverCallback):
2396         (beforeAll):
2397
2398 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2399
2400         WTF::Expected should use std::addressof instead of operator&
2401         https://bugs.webkit.org/show_bug.cgi?id=195604
2402
2403         Reviewed by Myles Maxfield.
2404
2405         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2406         (TestWebKitAPI::Unique::Unique):
2407         (TestWebKitAPI::Unique::operator&):
2408         (TestWebKitAPI::TEST):
2409
2410 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2411
2412         Add Optional to Forward.h.
2413         https://bugs.webkit.org/show_bug.cgi?id=195586
2414
2415         Reviewed by Darin Adler.
2416
2417         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2418         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2419         Remove unnecessary includes from headers.
2420
2421 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2422
2423         Add testing API to hit-test and scroll overflow scrollers
2424         https://bugs.webkit.org/show_bug.cgi?id=195278
2425
2426         Reviewed by Antti Koivisto.
2427         
2428         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2429         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2430         
2431         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2432
2433         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2434         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2435         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2436         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2437         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2438         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2439         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2440         (WTR::enclosingScrollViewIncludingSelf):
2441         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2442
2443 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2444
2445         API test WebKit.RequestTextInputContext fails on iOS
2446         https://bugs.webkit.org/show_bug.cgi?id=195585
2447
2448         Reviewed by Wenson Hsieh and Simon Fraser.
2449
2450         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2451         (applyStyle):
2452         (TEST):
2453         Add a viewport, so that the coordinates match up on iOS.
2454         Scroll by moving the UIScrollView's contentOffset.
2455
2456 2019-03-11  Chris Dumez  <cdumez@apple.com>
2457
2458         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2459         https://bugs.webkit.org/show_bug.cgi?id=195506
2460         <rdar://problem/48733477>
2461
2462         Reviewed by Alex Christensen.
2463
2464         Add API test coverage.
2465
2466         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2467
2468 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2469
2470         Adding myself to contributors.json
2471
2472         Unreviewed, addming myself to contributors.json .
2473
2474         * Scripts/webkitpy/common/config/contributors.json:
2475
2476 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2477
2478         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2479         https://bugs.webkit.org/show_bug.cgi?id=195511
2480         <rdar://problem/44873269>
2481
2482         Reviewed by Darin Adler.
2483
2484         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2485         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2486         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2487         (TEST_F):
2488
2489 2019-03-11  Chris Dumez  <cdumez@apple.com>
2490
2491         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2492         https://bugs.webkit.org/show_bug.cgi?id=195561
2493
2494         Reviewed by Youenn Fablet.
2495
2496         Make sure the JS in the test requests for permission to receive device orientation events.
2497
2498         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2499
2500 2019-03-11  Youenn Fablet  <youenn@apple.com>
2501
2502         Allow storage quota increase by default in WTR
2503         https://bugs.webkit.org/show_bug.cgi?id=195541
2504
2505         Reviewed by Geoffrey Garen.
2506
2507         Allow storage quota increase by default in WTR.
2508         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
2509         Use this for tests that explicitly need cache increase.
2510
2511         Instead of increasing quota by 2, make sure the next request is
2512         granted by adding all given parameters.
2513
2514         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2515         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2516         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2517         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
2518         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2519         * WebKitTestRunner/TestController.cpp:
2520         (WTR::TestController::setAllowStorageQuotaIncrease):
2521         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2522         * WebKitTestRunner/TestController.h:
2523         * WebKitTestRunner/TestInvocation.cpp:
2524         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2525         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2526         (WTR::TestController::cocoaResetStateToConsistentValues):
2527         (WTR::TestController::setAllowStorageQuotaIncrease):
2528         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2529         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2530         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2531
2532 2019-03-11  Xan Lopez  <xan@igalia.com>
2533
2534         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
2535         https://bugs.webkit.org/show_bug.cgi?id=194147
2536
2537         Reviewed by Michael Saboff.
2538
2539         To make --32-bit work correctly on Linux/64bit we need to:
2540
2541         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
2542         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
2543         unfortunately CMake only allows us to do this during
2544         crosscompilation, which is overkill here.
2545         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
2546         pkg-config detection module uses the x86 .pc files instead of the
2547         x86_64 ones.
2548         - Set the -m32 flags for the compiler.
2549
2550         * Scripts/webkitdirs.pm:
2551         (generateBuildSystemFromCMakeProject):
2552
2553 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
2554
2555         Add MotionMark-1.1 plan file for run-benchmark script.
2556         https://bugs.webkit.org/show_bug.cgi?id=195481
2557
2558         Rubber-stamped by Darin Adler.
2559
2560         Run-benchmark script should support MontionMark-1.1.
2561
2562         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
2563
2564 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2565
2566         [ews-app] Add support for submit-to-ews url
2567         https://bugs.webkit.org/show_bug.cgi?id=195477
2568
2569         Reviewed by Lucas Forschler.
2570
2571         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2572         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2573         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
2574         * BuildSlaveSupport/ews-app/ews/urls.py:
2575         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
2576
2577 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
2578
2579         Unreviewed, rolling out r242688, r242643, r242624.
2580
2581         Caused multiple layout test failures and crashes on iOS and macOS.
2582
2583         Reverted changeset:
2584
2585         "requestAnimationFrame should execute before the next frame"
2586         https://bugs.webkit.org/show_bug.cgi?id=177484
2587         https://trac.webkit.org/changeset/242624/webkit
2588
2589         * Tracing/SystemTracePoints.plist:
2590
2591 2019-03-11  John Wilander  <wilander@apple.com>
2592
2593         Resource Load Statistics: Make it possible exclude localhost from classification
2594         https://bugs.webkit.org/show_bug.cgi?id=195474
2595         <rdar://problem/47520577>
2596
2597         Reviewed by Brent Fulgham.
2598
2599         This patch allows for localhost to be excluded from classification and
2600         treatment as a prevalent resource.
2601
2602         The WebKit Tools change adds a new function called
2603         testRunner.setStatisticsIsRunningTest() which can be used to control this
2604         behavior.
2605
2606         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2607         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2608         (WTR::TestRunner::setStatisticsIsRunningTest):
2609         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2610         * WebKitTestRunner/TestController.cpp:
2611         (WTR::TestController::setStatisticsIsRunningTest):
2612         * WebKitTestRunner/TestController.h:
2613         * WebKitTestRunner/TestInvocation.cpp:
2614         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2615
2616 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2617
2618         [ews-build] Disable waterfall and console view for ews-build.webkit.org
2619         https://bugs.webkit.org/show_bug.cgi?id=195560
2620
2621         Reviewed by Lucas Forschler.
2622
2623         * BuildSlaveSupport/ews-build/master.cfg:
2624
2625 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2626
2627         Unreviewed, rolling out r242698.
2628
2629         API test crashes on bots.
2630
2631         Reverted changeset:
2632
2633         "Add a WKContentRuleList variant that uses copied memory
2634         instead of mmap'd shared memory for class A containerized
2635         apps"
2636         https://bugs.webkit.org/show_bug.cgi?id=195511
2637         https://trac.webkit.org/changeset/242698
2638
2639 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2640
2641         [WPE] Enable web process sandbox
2642         https://bugs.webkit.org/show_bug.cgi?id=195169
2643
2644         Reviewed by Daniel Bates.
2645
2646         * wpe/install-dependencies:
2647         * wpe/jhbuild.modules:
2648
2649 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2650
2651         [ews-app] Use port 17000 for worker communication
2652         https://bugs.webkit.org/show_bug.cgi?id=195558
2653
2654         Reviewed by Lucas Forschler.
2655
2656         * BuildSlaveSupport/ews-build/master.cfg:
2657
2658 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2659
2660         [ews-build] unit-tests fail when passwords.json is missing
2661         https://bugs.webkit.org/show_bug.cgi?id=195557
2662
2663         Reviewed by Lucas Forschler.
2664
2665         * BuildSlaveSupport/ews-build/loadConfig.py:
2666         (loadBuilderConfig):
2667         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2668         (ConfigDotJSONTest.test_configuration):
2669         * BuildSlaveSupport/ews-build/master.cfg:
2670
2671 2019-03-11  Truitt Savell  <tsavell@apple.com>
2672
2673         Unreviewed, rolling out r242702.
2674
2675         Broke High Sierra builders.
2676
2677         Reverted changeset:
2678
2679         "Add utility function to allow easy reverse range-based
2680         iteration of a container"
2681         https://bugs.webkit.org/show_bug.cgi?id=195542
2682         https://trac.webkit.org/changeset/242702
2683
2684 2019-03-11  Sam Weinig  <sam@webkit.org>
2685
2686         Add utility function to allow easy reverse range-based iteration of a container
2687         https://bugs.webkit.org/show_bug.cgi?id=195542
2688
2689         Reviewed by Antti Koivisto.
2690
2691         * TestWebKitAPI/CMakeLists.txt:
2692         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2693         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2694         (TestWebKitAPI::TEST):
2695         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2696
2697 2019-03-10  Alex Christensen  <achristensen@webkit.org>
2698
2699         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2700         https://bugs.webkit.org/show_bug.cgi?id=195511
2701         <rdar://problem/44873269>
2702
2703         Reviewed by Darin Adler.
2704
2705         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2706         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2707         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2708         (TEST_F):
2709
2710 2019-03-10  Tim Horton  <timothy_horton@apple.com>
2711
2712         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
2713         https://bugs.webkit.org/show_bug.cgi?id=195499
2714
2715         Reviewed by Darin Adler.
2716
2717         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2718         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
2719         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
2720         (-[WKWebView synchronouslyFocusTextInputContext:]):
2721         (applyStyle):
2722         (applyIframe):
2723         (TEST):
2724         Add some tests for this SPI.
2725
2726 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
2727
2728         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
2729         https://bugs.webkit.org/show_bug.cgi?id=181151
2730
2731         Reviewed by Don Olmstead.
2732
2733         * TestWebKitAPI/CMakeLists.txt:
2734         * TestWebKitAPI/PlatformWin.cmake:
2735         Enable TestWTF RunLoop tests in all platforms.
2736
2737         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
2738         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
2739         (TestWebKitAPI::DerivedOneShotTimer::fired):
2740         (TestWebKitAPI::TEST):
2741         Only a few platforms support nested RunLoop.
2742
2743         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
2744         (TestWebKitAPI::DerivedRepeatingTimer::fired):
2745
2746 2019-03-10  David Quesada  <david_quesada@apple.com>
2747
2748         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
2749         https://bugs.webkit.org/show_bug.cgi?id=152480
2750
2751         Reviewed by Chris Dumez.
2752
2753         Add a unit test based on Daniel Bates's test case that starts a download, ensures
2754         there are no additional references to the process pool besides the one held by
2755         the download, waits for the download to finish (in the sense that the
2756         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
2757         measure, also check that the process pool has been deallocated at the end of the
2758         test. The test wouldn't be meaningful if the process pool were still alive.
2759
2760         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2761         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
2762         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
2763             The download will be canceled because the delegate does not implement the
2764             method to decide the download's destination, so this is where we know the
2765             DownloadProxyMap is done with the DownloadProxy.
2766         (TEST):
2767
2768 2019-03-08  Chris Dumez  <cdumez@apple.com>
2769
2770         Add support for Device Orientation / Motion permission API
2771         https://bugs.webkit.org/show_bug.cgi?id=195329
2772         <rdar://problem/47645367>
2773
2774         Reviewed by Geoffrey Garen.
2775
2776         Add test infrastructure to help test the Device Orientation / Motion permission API.
2777
2778         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2779         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2780         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
2781         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2782         * WebKitTestRunner/TestController.cpp:
2783         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
2784         (WTR::TestController::createWebViewWithOptions):
2785         (WTR::TestController::resetStateToConsistentValues):
2786         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
2787         * WebKitTestRunner/TestController.h:
2788         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
2789         * WebKitTestRunner/TestInvocation.cpp:
2790         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2791
2792 2019-03-08  Saam barati  <sbarati@apple.com>
2793
2794         Add a compare-results script to compare benchmark results
2795         https://bugs.webkit.org/show_bug.cgi?id=195486
2796         <rdar://problem/48723397>
2797
2798         Reviewed by Geoffrey Garen.
2799
2800         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
2801         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
2802         to extend it to learn about our other benchmarks.
2803
2804         * Scripts/compare-results: Added.
2805         (readJSONFile):
2806         (detectJetStream2):
2807         (JetStream2Results):
2808         (detectSpeedometer2):
2809         (Speedometer2Results):
2810         (detectPLT5):
2811         (PLT5Results):
2812         (detectBenchmark):
2813         (biggerIsBetter):
2814         (ttest):
2815         (getOptions):
2816         (main):
2817
2818 2019-03-08  Stephanie Lewis  <slewis@apple.com>
2819
2820         Ensure old tab state is cleared between iterations of run-benchmark
2821         https://bugs.webkit.org/show_bug.cgi?id=195393
2822         <rdar://problem/46885583>
2823
2824         Reviewed by Dewei Zhu.
2825
2826         a) ensure the default to restore state is not set
2827         b) terminate Safari correctly
2828         c) Set the system default to ignore Persistent State in Safari
2829
2830         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2831         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
2832         (OSXBrowserDriver.prepare_env): 
2833         (OSXBrowserDriver.restore_env):
2834         (OSXBrowserDriver.close_browsers):
2835         (OSXBrowserDriver._terminate_processes):
2836         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
2837         (OSXChromeDriver):
2838         (OSXChromeCanaryDriver):
2839         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
2840         (OSXFirefoxDriver):
2841         (OSXFirefoxNightlyDriver):
2842         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
2843         (OSXSafariDriver):
2844         (OSXSafariDriver.prepare_env):
2845
2846 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
2847
2848         [GTK] Several InputMethodFilter tests are failing
2849         https://bugs.webkit.org/show_bug.cgi?id=195408
2850
2851         Reviewed by Carlos Garcia Campos.
2852
2853         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
2854         Regressed in r241751.
2855         Hexadecimal values of keycodes are expressed now in upper letters.
2856         Composited characters should be cast to UTF8 strings.
2857
2858         (TestWebKitAPI::TEST):
2859
2860 2019-03-07  Tomas Popela  <tpopela@redhat.com>
2861
2862         [GTK] Make Tools/gtkdoc python3 compatible
2863         https://bugs.webkit.org/show_bug.cgi?id=195359
2864
2865         Reviewed by Carlos Garcia Campos.
2866
2867         * gtkdoc/generate-gtkdoc:
2868         ConfigParser was reworked in Python 3.2 so we have adapt the code to
2869         work with Python 2 and 3.
2870         (get_gtkdoc_module_paths):
2871         The iteritems() was removed in Python 3, so let's use items() that's
2872         available in Python 2 and 3.
2873         (get_generator_for_config):
2874         * gtkdoc/gtkdoc.py:
2875         (GTKDoc._run_command):
2876         The sys.stdout.write() is expecting str in Python 3 and not bytes
2877         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
2878         for passing the bytes there.
2879
2880 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
2881
2882         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
2883         https://bugs.webkit.org/show_bug.cgi?id=195346
2884         <rdar://problem/48667048>
2885
2886         Unreviewed build fix for clang-cl.
2887
2888         * DumpRenderTree/win/DumpRenderTree.cpp:
2889         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
2890
2891 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
2892
2893         requestAnimationFrame should execute before the next frame
2894         https://bugs.webkit.org/show_bug.cgi?id=177484
2895
2896         Reviewed by Simon Fraser.
2897
2898         Add trace points for the page RenderingUpdate.
2899
2900         * Tracing/SystemTracePoints.plist:
2901
2902 2019-03-07  Zalan Bujtas  <zalan@apple.com>
2903
2904         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
2905         https://bugs.webkit.org/show_bug.cgi?id=195353
2906         <rdar://problem/48626394>
2907
2908         Reviewed by Simon Fraser.
2909
2910         * WebKitTestRunner/ios/TestControllerIOS.mm:
2911         (WTR::TestController::platformResetPreferencesToConsistentValues):
2912
2913 2019-03-07  John Wilander  <wilander@apple.com>
2914
2915         Resource Load Statistics: Make it possible to purge only script-accessible cookies
2916         https://bugs.webkit.org/show_bug.cgi?id=195383
2917         <rdar://problem/48570136>
2918
2919         Reviewed by Brent Fulgham.
2920
2921         This patch adds test infrastructure to purge only script-accessible cookies,
2922         including a new testRunner function called statisticsDeleteCookiesForHost().git a
2923
2924         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2925         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2926         (WTR::TestRunner::statisticsDeleteCookiesForHost):
2927         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2928         * WebKitTestRunner/TestController.cpp:
2929         (WTR::TestController::statisticsDeleteCookiesForHost):
2930         * WebKitTestRunner/TestController.h:
2931         * WebKitTestRunner/TestInvocation.cpp:
2932         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2933
2934 2019-03-07  Commit Queue  <commit-queue@webkit.org>
2935
2936         Unreviewed, rolling out r242354.
2937         https://bugs.webkit.org/show_bug.cgi?id=195402
2938
2939         breaks layout tests in all configurations (Requested by
2940         zdobersek on #webkit).
2941
2942         Reverted changeset:
2943
2944         "[WPE] Enable web process sandbox"
2945         https://bugs.webkit.org/show_bug.cgi?id=195169
2946         https://trac.webkit.org/changeset/242354
2947
2948 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
2949
2950         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
2951         https://bugs.webkit.org/show_bug.cgi?id=195346
2952
2953         Reviewed by Fujii Hironori.
2954
2955         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2956         (TestWebKitAPI::TEST):
2957         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
2958
2959         * DumpRenderTree/win/DumpRenderTree.cpp:
2960         (findFontFallback):
2961         (addFontFallbackIfPresent):
2962         (removeFontFallbackIfPresent):
2963         (main):
2964         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2965         (TestWebKitAPI::Util::moduleDirectory):
2966         (TestWebKitAPI::Util::createInjectedBundlePath):
2967         Use wchar helpers as needed.
2968
2969 2019-03-06  Rob Buis  <rbuis@igalia.com>
2970
2971         Consider supporting the `referrerpolicy` attribute.
2972         https://bugs.webkit.org/show_bug.cgi?id=179053
2973
2974         Reviewed by Darin Adler.
2975
2976         Add a runtime flag for referrerpolicy attribute.
2977
2978         * DumpRenderTree/mac/DumpRenderTree.mm:
2979         (enableExperimentalFeatures):
2980
2981 2019-03-05  Daniel Bates  <dabates@apple.com>
2982
2983         Update expected API test result following r242379
2984         (https://bugs.webkit.org/show_bug.cgi?id=195125)
2985
2986         Update expected x-coordinate of selection rect now that the left padding of
2987         a textarea is sized in ems (so dependent on the font size) just like the left
2988         padding of a text field.
2989
2990         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2991         (TestWebKitAPI::TEST):
2992
2993 2019-03-05  David Quesada  <david_quesada@apple.com>
2994
2995         [WK2] It should be possible to follow links with 'download' attributes
2996         https://bugs.webkit.org/show_bug.cgi?id=195145
2997         rdar://problem/48462642
2998
2999         Reviewed by Alex Christensen.
3000
3001         Add a unit test to verify that activating links with 'download' attributes now
3002         navigates to the linked resource, rather than starts downloading it. Add another
3003         to verify that it is still possible to explicitly download the link via the
3004         'Download' navigation action policy.
3005
3006         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3007         (-[DownloadAttributeTestDelegate init]):
3008         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3009         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3010         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3011         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3012         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3013         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3014         (TEST):
3015         * WebKitTestRunner/TestController.cpp:
3016         (WTR::TestController::decidePolicyForNavigationAction):
3017         * WebKitTestRunner/TestController.h:
3018
3019 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3020
3021         [Curl] Implement Cookie Accept Policy.
3022         https://bugs.webkit.org/show_bug.cgi?id=191645
3023
3024         Reviewed by Fujii Hironori.
3025
3026         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3027         (TestWebKitAPI::Curl::TEST_F):
3028
3029 2019-03-05  Youenn Fablet  <youenn@apple.com>
3030
3031         Rename requestCacheStorageSpace to requestStorageSpace
3032         https://bugs.webkit.org/show_bug.cgi?id=195282
3033
3034         Reviewed by Chris Dumez.
3035
3036         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3037         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3038         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3039
3040 2019-03-05  Brady Eidson  <beidson@apple.com>
3041
3042         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3043         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3044
3045         Reviewed by Tim Horton.
3046
3047         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3048         different directory into that same WKWebView should work.
3049
3050         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3051         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3052
3053 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3054
3055         Add WeakHashSet
3056         https://bugs.webkit.org/show_bug.cgi?id=195152
3057
3058         Reviewed by Antti Koivisto.
3059
3060         Added tests for WeakHashSet.
3061
3062         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3063         (TestWebKitAPI::Base::Base): Moved.
3064         (TestWebKitAPI::Derived::foo): Moved.
3065         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3066         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3067         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3068         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3069
3070 2019-03-04  Chris Dumez  <cdumez@apple.com>
3071
3072         Do not share WebProcesses between private and regular sessions
3073         https://bugs.webkit.org/show_bug.cgi?id=195189
3074         <rdar://problem/48421064>
3075
3076         Reviewed by Alex Christensen.
3077
3078         Add API test coverage.
3079
3080         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3081         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3082
3083 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3084
3085         [WPE] Enable web process sandbox
3086         https://bugs.webkit.org/show_bug.cgi?id=195169
3087
3088         Reviewed by Daniel Bates.
3089
3090         * wpe/install-dependencies:
3091         * wpe/jhbuild.modules:
3092
3093 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3094
3095         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3096         https://bugs.webkit.org/show_bug.cgi?id=195206
3097
3098         Reviewed by Žan Doberšek.
3099
3100         Add a new test case.
3101
3102         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3103         (testJSCClass):
3104
3105 2019-03-04  Charlie Turner  <cturner@igalia.com>
3106
3107         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3108         https://bugs.webkit.org/show_bug.cgi?id=194898
3109
3110         Reviewed by Žan Doberšek.
3111
3112         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3113         a GCC extension that permits arithmetic on void* pointer. Inline
3114         the macro until this issue is fixed upstream.
3115
3116 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3117
3118         Rid the world of WK_API_ENABLED
3119         https://bugs.webkit.org/show_bug.cgi?id=195263
3120
3121         Reviewed by Dan Bernstein.
3122
3123         List of changed files elided because it's useless.
3124
3125 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3126
3127         Unreviewed follow-up to r242292.
3128
3129         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3130
3131         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3132         (TestWebKitAPI::testStrip): Renamed from strip.
3133         (TestWebKitAPI::TEST):
3134
3135 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3136
3137         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3138
3139         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3140         and bug #194272 for details.
3141
3142         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3143
3144 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3145
3146         Remove some more unused 32-bit code
3147         https://bugs.webkit.org/show_bug.cgi?id=195255
3148
3149         Reviewed by Darin Adler.
3150
3151         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3152         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3153         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3154         (NPP_New):
3155         (NPP_HandleEvent):
3156         (handleEventCarbon): Deleted.
3157
3158 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3159
3160         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3161
3162         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3163         (TestWebKitAPI::TEST):
3164
3165 2019-03-01  Darin Adler  <darin@apple.com>
3166
3167         Finish removing String::format
3168         https://bugs.webkit.org/show_bug.cgi?id=194893
3169
3170         Reviewed by Daniel Bates.
3171 '
3172         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3173
3174 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3175
3176         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3177         https://bugs.webkit.org/show_bug.cgi?id=195229
3178         <rdar://problem/48520362>
3179
3180         Reviewed by Chris Dumez.
3181
3182         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3183         (TEST):
3184
3185 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3186
3187         Add a system trace scope for event region building
3188         https://bugs.webkit.org/show_bug.cgi?id=195226
3189
3190         Reviewed by Jon Lee.
3191
3192         This trace scope measures the time spend converting element rects into Region objects,
3193         which can be large on some pages.
3194
3195         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3196
3197         * Tracing/SystemTracePoints.plist:
3198
3199 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3200
3201         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3202         https://bugs.webkit.org/show_bug.cgi?id=194612
3203
3204         Reviewed by Alex Christensen.
3205
3206         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3207         Just test the new string-processing function and don't touch the actual environment.
3208         (Test cases are all as before, but based on operator== instead of strcmp.)
3209
3210 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3211
3212         [ews-app] Update primary keys for handling multiple Buildbot instances
3213         https://bugs.webkit.org/show_bug.cgi?id=195120
3214
3215         Reviewed by Stephanie Lewis.
3216
3217         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3218         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3219         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3220
3221         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3222         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3223         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3224         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3225         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3226         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3227
3228 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3229
3230         [WinCairo] Enable service worker
3231         https://bugs.webkit.org/show_bug.cgi?id=188318
3232
3233         Reviewed by Youenn Fablet.
3234
3235         * DumpRenderTree/DumpRenderTreePrefix.h:
3236         * TestWebKitAPI/PlatformWin.cmake:
3237         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3238         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3239         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3240
3241 2019-03-01  Justin Fan  <justin_fan@apple.com>
3242
3243         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3244         https://bugs.webkit.org/show_bug.cgi?id=195191
3245
3246         Rubber-stamped by Dean Jackson.
3247
3248         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3249
3250         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3251
3252 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3253
3254         Unreviewed, fix lldb webkitpy tests
3255         https://bugs.webkit.org/show_bug.cgi?id=194375
3256
3257         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3258
3259         * lldb/lldb_webkit.py:
3260         (WTFStringImplProvider.is_8bit):
3261
3262 2019-02-28  David Quesada  <david_quesada@apple.com>
3263
3264         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3265         https://bugs.webkit.org/show_bug.cgi?id=195121
3266         rdar://problem/48450302
3267
3268         Reviewed by Alex Christensen.
3269
3270         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3271         configurations where the 'download' attribute is absent, blank, or populated
3272         with a filename, and where the anchor element is same-origin or cross-origin
3273         (meaning the 'download' attribute shouldn't be honored).
3274
3275         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3276         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3277         (-[NavigationActionTestDelegate init]):
3278         (-[NavigationActionTestDelegate navigationAction]):
3279         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3280         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3281         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3282         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3283         (TEST):
3284
3285 2019-02-28  Antoine Quint  <graouts@apple.com>
3286
3287         Enable the Pointer Events runtime flag by default
3288         https://bugs.webkit.org/show_bug.cgi?id=195156
3289
3290         Reviewed by Dean Jackson.
3291
3292         * DumpRenderTree/mac/DumpRenderTree.mm:
3293         (enableExperimentalFeatures):
3294
3295 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3296
3297         Several PasteImage API tests are flaky
3298         https://bugs.webkit.org/show_bug.cgi?id=195160
3299
3300         Reviewed by Tim Horton.
3301
3302         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3303         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3304         listening for a "load" event after image load is already complete.
3305
3306         To address this, make these tests first register a "load" event handler, then run script to insert an image
3307         element into the document, and finally wait until the load event is observed before checking image size.
3308
3309         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3310
3311 2019-02-28  Chris Dumez  <cdumez@apple.com>
3312
3313         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3314         https://bugs.webkit.org/show_bug.cgi?id=195107
3315
3316         Reviewed by Alex Christensen.
3317
3318         Give some time for the zoom level to get restored.
3319
3320         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3321
3322 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3323
3324         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3325         https://bugs.webkit.org/show_bug.cgi?id=194958
3326
3327         Reviewed by Geoffrey Garen.
3328
3329         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3330         (TEST):
3331
3332 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3333
3334         [ews-app] Update method to save build to handle builder_display_name
3335         https://bugs.webkit.org/show_bug.cgi?id=195047
3336
3337         Reviewed by Dewei Zhu.
3338
3339         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3340         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3341
3342 2019-02-28  Justin Fan  <justin_fan@apple.com>
3343
3344         [Web GPU] Enable Web GPU only on 64-bit
3345         https://bugs.webkit.org/show_bug.cgi?id=195139
3346
3347         Because Metal is only supported on 64 bit apps.
3348
3349         Unreviewed build fix.
3350
3351         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3352
3353 2019-02-27  Youenn Fablet  <youenn@apple.com>
3354
3355         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3356         https://bugs.webkit.org/show_bug.cgi?id=194959
3357
3358         Reviewed by Chris Dumez.
3359
3360         Spin loop until getting the condition to remove flakiness.
3361
3362         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3363
3364 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3365
3366         [ews-build] Buildbot should include builder_display_name in the build events
3367         https://bugs.webkit.org/show_bug.cgi?id=195045
3368
3369         Reviewed by Dewei Zhu.
3370
3371         * BuildSlaveSupport/ews-build/events.py:
3372         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3373         buildername to builder_name to be consistent in naming style.
3374         (Events.buildFinished): Ditto.
3375
3376 2019-02-27  Chris Dumez  <cdumez@apple.com>
3377
3378         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3379         https://bugs.webkit.org/show_bug.cgi?id=194480
3380
3381         Reviewed by Brady Eidson.
3382
3383         Update existing API test to make it more likely to reproduce the issue.
3384
3385         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3386
3387 2019-02-27  Brady Eidson  <beidson@apple.com>
3388
3389         Universal links from Google search results pages don't open the app.
3390         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3391
3392         Reviewed by Geoffrey Garen.
3393
3394         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3395         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3396         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3397         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3398
3399 2019-02-27  Chris Dumez  <cdumez@apple.com>
3400
3401         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3402         https://bugs.webkit.org/show_bug.cgi?id=195102
3403
3404         Reviewed by Geoffrey Garen.
3405
3406         If the number of processes is not yet what we expect, wait a bit and check again to give
3407         processes some time to exit.
3408
3409         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3410
3411 2019-02-27  Chris Dumez  <cdumez@apple.com>
3412
3413         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3414         https://bugs.webkit.org/show_bug.cgi?id=194545
3415
3416         Reviewed by Brady Eidson.
3417
3418         Make sure the test navigates forward and then back only once. Previously, navigating
3419         back would trigger a navigation again in a timer.
3420
3421         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3422
3423 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3424
3425         High Sierra Debug JSC test queue should use faster hardware
3426         https://bugs.webkit.org/show_bug.cgi?id=194603
3427
3428         Rubber-stamped by Alexey Proskuryakov.
3429
3430         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3431
3432         * BuildSlaveSupport/build.webkit.org-config/config.json:
3433         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3434         (BubbleQueueServer):
3435         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3436         (WebKitBuildbot):
3437         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3438         * QueueStatusServer/config/queues.py:
3439         * Scripts/webkitpy/common/config/ews.json:
3440         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3441         (test_ews_name):
3442
3443 2019-02-27  John Wilander  <wilander@apple.com>
3444
3445         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3446         https://bugs.webkit.org/show_bug.cgi?id=195071
3447         <rdar://problem/48417690>
3448
3449         Reviewed by Alex Christensen and Brent Fulgham.
3450
3451         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3452         (TestWebKitAPI::createURL):
3453             Convenience function.
3454         (TestWebKitAPI::TEST):
3455             WebCore::AdClickAttribution now takes a URL when creating Source and
3456             Destination.
3457         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3458         (TestWebKitAPI::TEST):
3459             WebCore::AdClickAttribution now takes a URL when creating Source and
3460             Destination.
3461
3462 2019-02-27  Antoine Quint  <graouts@apple.com>
3463
3464         Support Pointer Events on macOS
3465         https://bugs.webkit.org/show_bug.cgi?id=195008
3466         <rdar://problem/47454419>
3467
3468         Reviewed by Dean Jackson.
3469
3470         * DumpRenderTree/mac/DumpRenderTree.mm:
3471         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3472         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3473
3474 2019-02-26  Mark Lam  <mark.lam@apple.com>
3475
3476         Remove remaining poisoning code.
3477         https://bugs.webkit.org/show_bug.cgi?id=194138
3478
3479         Reviewed by Saam Barati.
3480
3481         * TestWebKitAPI/CMakeLists.txt:
3482         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3483         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
3484         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
3485         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
3486         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
3487         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
3488         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
3489
3490 2019-02-26  Alex Christensen  <achristensen@webkit.org>
3491
3492         Move ephemeral local storage from WebProcess to UIProcess
3493         https://bugs.webkit.org/show_bug.cgi?id=195074
3494         <rdar://problem/47937975>
3495
3496         Reviewed by Geoff Garen.
3497
3498         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3499
3500 2019-02-20  Jer Noble  <jer.noble@apple.com>
3501
3502         [Cocoa] Media elements will restart network buffering just before suspending
3503         https://bugs.webkit.org/show_bug.cgi?id=193691
3504
3505         Reviewed by Eric Carlson.
3506
3507         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3508         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3509         (TEST):
3510
3511 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
3512
3513         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
3514         https://bugs.webkit.org/show_bug.cgi?id=191652
3515
3516         Reviewed by Alex Christensen.
3517
3518         Fix WinCairo MiniBrowser behavior of authentication dialog.
3519
3520         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3521         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3522
3523 2019-02-26  Youenn Fablet  <youenn@apple.com>
3524
3525         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
3526         https://bugs.webkit.org/show_bug.cgi?id=195028
3527         <rdar://problem/48243733>
3528
3529         Reviewed by Eric Carlson.
3530
3531         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3532
3533 2019-02-26  Philippe Normand  <pnormand@igalia.com>
3534
3535         [WPE] Add API for webview background color configuration
3536         https://bugs.webkit.org/show_bug.cgi?id=192305
3537
3538         Reviewed by Michael Catanzaro.
3539
3540         * MiniBrowser/wpe/main.cpp:
3541         (main): Add a new option to configure the webview background
3542         color. Example: --bg-color=transparent.
3543         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3544         (testWebViewBackgroundColor): Enable background color API tests for WPE.
3545         (beforeAll): Ditto.
3546
3547 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
3548
3549         scalableNativeWebpageParameters() is not preserved on new page navigation.
3550         https://bugs.webkit.org/show_bug.cgi?id=194892
3551         <rdar://problem/47538280>
3552
3553         Reviewed by Wenson Hsieh.
3554         
3555         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
3556
3557         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3558         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3559         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3560         (WTR::UIScriptController::allowsViewportShrinkToFit):
3561         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3562         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3563         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3564         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3565         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3566         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3567
3568 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3569
3570         [ews-app] Add model for handling multiple Buildbot instances
3571         https://bugs.webkit.org/show_bug.cgi?id=194863
3572
3573         Reviewed by Stephanie Lewis.
3574
3575         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
3576
3577 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3578
3579         [ews-app] Remove BuilderMapping table
3580         https://bugs.webkit.org/show_bug.cgi?id=194961
3581
3582         Reviewed by Stephanie Lewis.
3583
3584         Store builder name directly in build table, instead of having a separate
3585         table for it.
3586
3587         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
3588         * BuildSlaveSupport/ews-app/ews/models/build.py:
3589         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
3590         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3591
3592 2019-02-25  John Wilander  <wilander@apple.com>
3593
3594         Introduce and adopt new class RegistrableDomain for eTLD+1
3595         https://bugs.webkit.org/show_bug.cgi?id=194791
3596         <rdar://problem/48179240>
3597
3598         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
3599
3600         This patch adds an API test and replaces two instances of
3601         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
3602
3603         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3604         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3605         (TestWebKitAPI::TEST):
3606             Changed two strings to make sure the registrable domains are still considered
3607             invalid and pass the test.
3608         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
3609         (TestWebKitAPI::TEST):
3610         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3611         (WTR::InjectedBundle::didReceiveMessageToPage):
3612
3613 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
3614
3615         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
3616         https://bugs.webkit.org/show_bug.cgi?id=195001
3617
3618         Reviewed by Carlos Garcia Campos.
3619
3620         API version 1.0 always includes the functionality previously guarded with
3621         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
3622         unconditionally.
3623
3624         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3625         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
3626         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
3627         (WebViewTest::showInWindow): Ditto.
3628         (WebViewTest::hideView): Ditto.
3629         * wpe/backends/HeadlessViewBackend.cpp:
3630         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
3631         * wpe/backends/ViewBackend.cpp:
3632         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
3633         * wpe/backends/WindowViewBackend.cpp:
3634         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
3635         WPE_BACKEND_CHECK_VERSION().
3636         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
3637
3638 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
3639
3640         [Flatpak] Add support for flatpak > 1.1.2
3641         https://bugs.webkit.org/show_bug.cgi?id=194088
3642
3643         Flatpak 1.2 is now out so we need to support that
3644         version now.
3645
3646         Reviewed by Michael Catanzaro.
3647
3648         * flatpak/flatpakutils.py:
3649         (check_flatpak):
3650         (FlatpakPackages.__init__):
3651         (FlatpakPackages.__detect_packages):
3652         (FlatpakPackages.__detect_packages.in):
3653         (FlatpakRepos.update):
3654
3655 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
3656
3657         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
3658         https://bugs.webkit.org/show_bug.cgi?id=194998
3659
3660         Reviewed by Carlos Garcia Campos.
3661
3662         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
3663         to a Git checkout and using the latest commit containing various fixes
3664         and improvements.
3665
3666 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3667
3668         [WPE][GTK] Remove user agent quirk for washingtonpost.com
3669         https://bugs.webkit.org/show_bug.cgi?id=194981
3670
3671         Reviewed by Žan Doberšek.
3672
3673         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3674         (TestWebKitAPI::TEST):
3675
3676 2019-02-23  Keith Miller  <keith_miller@apple.com>
3677
3678         Add new mac target numbers
3679         https://bugs.webkit.org/show_bug.cgi?id=194955
3680
3681         Reviewed by Tim Horton.
3682
3683         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3684         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3685         * MiniBrowser/Configurations/Base.xcconfig:
3686         * TestWebKitAPI/Configurations/Base.xcconfig:
3687         * WebKitTestRunner/Configurations/Base.xcconfig:
3688
3689 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
3690
3691         [WinCairo] Enable wk1/wk2 suffix for platform search path.
3692         https://bugs.webkit.org/show_bug.cgi?id=194846
3693
3694         Reviewed by Don Olmstead.
3695
3696         Added _search_paths() and _port_specific_expectations_files() for
3697         WinCairoPort.
3698
3699         * Scripts/webkitpy/port/win.py:
3700         (WinCairoPort.default_baseline_search_path):
3701         (WinCairoPort):
3702         (WinCairoPort._port_specific_expectations_files):
3703         (WinCairoPort._search_paths):
3704
3705 2019-02-22  Tim Horton  <timothy_horton@apple.com>
3706
3707         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
3708         https://bugs.webkit.org/show_bug.cgi?id=194963
3709
3710         Reviewed by Dean Jackson.
3711
3712         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3713         Do a `contains` check instead of `equals`, because in debug builds we
3714         put the GraphicsLayer pointer in a prefix.
3715
3716 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3717
3718         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
3719         https://bugs.webkit.org/show_bug.cgi?id=194873
3720         <rdar://problem/46701974>
3721
3722         Reviewed by Tim Horton.
3723
3724         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
3725
3726         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3727         (WTR::UIScriptController::menuRect const):
3728         (WTR::UIScriptController::isShowingMenu const):
3729         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3730         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3731         (WTR::UIScriptController::menuRect const):
3732
3733         Add a function to query the bounds of the callout menu in content coordinates.
3734
3735         (WTR::UIScriptController::isShowingMenu const):
3736
3737         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
3738
3739         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3740         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3741         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3742         (WTR::UIScriptController::rectForMenuAction const):
3743         (WTR::UIScriptController::menuRect const):
3744         (WTR::UIScriptController::isShowingMenu const):
3745         (WTR::findViewInHierarchyOfType): Deleted.
3746
3747 2019-02-22  Chris Dumez  <cdumez@apple.com>
3748
3749         Regression(PSON) Unable to preview password-protected documents on iCloud.com
3750         https://bugs.webkit.org/show_bug.cgi?id=194954
3751         <rdar://problem/48127957>
3752
3753         Reviewed by Alex Christensen.
3754
3755         Add API test coverage.
3756
3757         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3758         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
3759         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3760         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3761
3762 2019-02-22  Chris Dumez  <cdumez@apple.com>
3763
3764         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
3765         https://bugs.webkit.org/show_bug.cgi?id=194924
3766         <rdar://problem/48216125>
3767
3768         Reviewed by Geoffrey Garen.
3769
3770         Add API test coverage.
3771
3772         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3773
3774 2019-02-22  Chris Dumez  <cdumez@apple.com>
3775
3776         Unreviewed, disable API test added in r241928 on iOS.
3777
3778         The cache is not enabled on devices with less than 3GB of RAM.
3779
3780         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3781
3782 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
3783
3784         Hardcode Visual Viewports on everywhere except iOS WK1
3785         https://bugs.webkit.org/show_bug.cgi?id=194928
3786
3787         Reviewed by Zalan Bujtas.
3788
3789         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
3790         change the default value of the Setting to 'true', and hardcode WebView on iOS to
3791         set it to false. The setting has shipped for several years and there's no need to turn
3792         it off now.
3793
3794         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
3795         Visual Viewports are not enabled.
3796         
3797         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
3798         that only runs in WK2
3799
3800         * MiniBrowser/mac/SettingsController.h:
3801         * MiniBrowser/mac/SettingsController.m:
3802         (-[SettingsController init]):
3803         (-[SettingsController _populateMenu]):
3804         (-[SettingsController validateMenuItem:]):
3805         (-[SettingsController visualViewportEnabled]): Deleted.
3806         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
3807         * MiniBrowser/mac/WK1BrowserWindowController.m:
3808         (-[WK1BrowserWindowController didChangeSettings]):
3809         * MiniBrowser/mac/WK2BrowserWindowController.m:
3810         (-[WK2BrowserWindowController didChangeSettings]):
3811
3812 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
3813
3814         Discard cached processes when clearing website data store
3815         https://bugs.webkit.org/show_bug.cgi?id=194894
3816
3817         Reviewed by Chris Dumez.
3818
3819         Added a test case.
3820
3821         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3822         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
3823
3824 2019-02-21  Alex Christensen  <achristensen@webkit.org>
3825
3826         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
3827         https://bugs.webkit.org/show_bug.cgi?id=194914
3828         <rdar://problem/47586889>
3829
3830         Reviewed by Geoffrey Garen.
3831
3832         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3833         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
3834         (TEST):
3835         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
3836
3837 2019-02-21  David Kilzer  <ddkilzer@apple.com>
3838
3839         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
3840         <https://webkit.org/b/194761>
3841
3842         Reviewed by Myles Maxfield.
3843
3844         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3845         (WTR::activateSystemCoreWebFonts): Log `error` to console if
3846         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
3847         to use ARC-compliant cast.
3848         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
3849         ARC-compliant cast.
3850         (WTR::installFakeHelvetica): Log `error` to console if
3851         CTFontManagerRegisterFontsForURL() fails, but only on supported
3852         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
3853         Call CFRelease() on `error` to fix the leak.  Update to use
3854         ARC-compliant cast.
3855         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
3856         cast.
3857
3858 2019-02-21  Chris Dumez  <cdumez@apple.com>
3859
3860         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
3861         https://bugs.webkit.org/show_bug.cgi?id=194481
3862
3863         Reviewed by Alex Christensen.
3864
3865         Give the processes a chance to shutdown and wait until we reached the expected number
3866         of processes.
3867
3868         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3869
3870 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3871
3872         Fix the macOS build
3873
3874         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3875
3876 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3877
3878         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
3879
3880         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3881         I am a backwards.
3882
3883 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3884
3885         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
3886
3887         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3888         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
3889         We could force on UI-side compositing, but I feel like the test might be more
3890         valuable exercising the normal path on each platform (though the original
3891         bug was also UI-side specific). Though we can't validate that the overlay
3892         layer was installed successfully, there are layout tests that do that.
3893
3894 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3895
3896         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
3897         https://bugs.webkit.org/show_bug.cgi?id=194845
3898         <rdar://problem/47944579>
3899
3900         Reviewed by Antti Koivisto.
3901
3902         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3903         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3904
3905 2019-02-21  Zalan Bujtas  <zalan@apple.com>
3906
3907         [LFC][Floats] Add support for placing formatting roots in-between floats.
3908         https://bugs.webkit.org/show_bug.cgi?id=194902
3909
3910         Reviewed by Antti Koivisto.
3911
3912         * LayoutReloaded/misc/LFC-passing-tests.txt:
3913
3914 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
3915
3916         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
3917         https://bugs.webkit.org/show_bug.cgi?id=194901
3918
3919         Unreviewed build fix.
3920
3921         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
3922         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
3923         WPEBackend-fdo-0.1 as library name.
3924
3925 2019-02-21  Rob Buis  <rbuis@igalia.com>
3926
3927         Update MIME type parser
3928         https://bugs.webkit.org/show_bug.cgi?id=180526
3929
3930         Reviewed by Darin Adler.
3931
3932         Add tests involving leading and trailing whitespace, non-token
3933         characters and quoted strings.
3934
3935         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3936         (TestWebKitAPI::TEST):
3937
3938 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
3939
3940         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
3941         https://bugs.webkit.org/show_bug.cgi?id=194884
3942
3943         Reviewed by Michael Catanzaro.
3944
3945         * PlatformWin.cmake:
3946
3947 2019-02-20  Chris Dumez  <cdumez@apple.com>
3948
3949         Add API test for <rdar://problem/47471222>
3950         https://bugs.webkit.org/show_bug.cgi?id=194847
3951
3952         Reviewed by Alex Christensen.
3953
3954         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3955
3956 2019-02-20  Chris Dumez  <cdumez@apple.com>
3957
3958         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
3959         https://bugs.webkit.org/show_bug.cgi?id=194872
3960         <rdar://problem/47924500>
3961
3962         Reviewed by Alex Christensen.
3963
3964         Add API test coverage.
3965
3966         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3967
3968 2019-02-20  Jer Noble  <jer.noble@apple.com>
3969
3970         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
3971         https://bugs.webkit.org/show_bug.cgi?id=191332
3972
3973         Reviewed by Dean Jackson.
3974
3975         * Scripts/git-is-in-range: Added.
3976
3977 2019-02-20  Andy Estes  <aestes@apple.com>
3978
3979         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
3980         https://bugs.webkit.org/show_bug.cgi?id=194869
3981
3982         Rubber-stamped by Jer Noble.
3983
3984         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3985         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
3986         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3987         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
3988         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3989         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3990
3991 2019-02-20  Chris Dumez  <cdumez@apple.com>
3992
3993         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
3994         https://bugs.webkit.org/show_bug.cgi?id=194857
3995         <rdar://problem/47759323>
3996
3997         Reviewed by Alex Christensen.
3998
3999         Add API test coverage.
4000
4001         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4002
4003 2019-02-20  Chris Dumez  <cdumez@apple.com>
4004
4005         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
4006         https://bugs.webkit.org/show_bug.cgi?id=194829
4007         <rdar://problem/47889906>
4008
4009         Reviewed by Alexey Proskuryakov.
4010
4011         Every time the TestOptions were changing we were creating both a new Web view and
4012         a new WKContext, which would start a new Network process. In most cases, we only
4013         need to contruct a new Web view and we do can keep reusing the same WKContext.
4014         This patch implements this optimization and thus avoids spinning a lot of new
4015         Network processes while running the layout tests.
4016
4017         * WebKitTestRunner/TestController.cpp:
4018         (WTR::TestController::generateContextConfiguration const):
4019         (WTR::TestController::generatePageConfiguration):
4020         (WTR::TestController::createWebViewWithOptions):
4021         (WTR::TestController::resetPreferencesToConsistentValues):
4022         (WTR::updateTestOptionsFromTestHeader):
4023         * WebKitTestRunner/TestController.h:
4024         * WebKitTestRunner/TestOptions.h:
4025         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
4026         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
4027         (WTR::TestOptions::hasSameInitializationOptions const):
4028         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
4029         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4030         (WTR::TestController::platformAddTestOptions const):
4031
4032 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
4033
4034         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
4035         https://bugs.webkit.org/show_bug.cgi?id=167941
4036
4037         Reviewed by Carlos Garcia Campos.
4038
4039         * MiniBrowser/gtk/main.c:
4040         (filterSavedCallback): Added.
4041         (main): Support loading a JSON rule set file for content filtering.
4042         * MiniBrowser/wpe/main.cpp:
4043         (filterSavedCallback): Added.
4044         (main): Support loading a JSON rule set file for content filtering.
4045         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
4046         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
4047         (WTF::derefGPtr): Ditto.
4048         (testEmptyStore):
4049         (testSaveInvalidFilter):
4050         (testSaveLoadFilter):
4051         (testSavedFilterIdentifierMatch):
4052         (testRemoveFilter):
4053         (testSaveMultipleFilters):
4054         (testSaveFilterFromFile):
4055         (testFilterPersistence):
4056         (beforeAll):
4057         (afterAll):
4058         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
4059         (removeOldInjectedContentAndResetLists): Also reset content filters.
4060         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
4061         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
4062         the element affected by the style sheet.
4063         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
4064         and returns it to be used by tests.
4065         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
4066         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
4067         (serverCallback): Add support for serving a CSS style sheet for testing.
4068         (beforeAll): Add call to testUserContentManagerContentFilter().
4069         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
4070
4071 2019-02-19  Keith Rollin  <krollin@apple.com>
4072
4073         Add timing information to build output
4074         https://bugs.webkit.org/show_bug.cgi?id=194839
4075         <rdar://problem/48219609>
4076
4077         Reviewed by Alexey Proskuryakov.
4078
4079         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
4080         emit each project's build time to its output. E.g.,
4081
4082             ** BUILD SUCCEEDED ** [0.132 sec]
4083
4084         * Scripts/webkitdirs.pm:
4085         (XcodeOptions):
4086
4087 2019-02-19  Truitt Savell  <tsavell@apple.com>
4088
4089         Unreviewed, rolling out r241784.
4090
4091         Broke all OpenSource builds.
4092
4093         Reverted changeset:
4094
4095         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
4096         instances view"
4097         https://bugs.webkit.org/show_bug.cgi?id=172848
4098         https://trac.webkit.org/changeset/241784
4099
4100 2019-02-19  Zalan Bujtas  <zalan@apple.com>
4101
4102         [LFC][Floats] Remove redundant intersecting logic
4103         https://bugs.webkit.org/show_bug.cgi?id=194804
4104
4105         Reviewed by Antti Koivisto.
4106
4107         * LayoutReloaded/misc/LFC-passing-tests.txt:
4108
4109 2019-02-19  Dean Jackson  <dino@apple.com>
4110
4111         Clean-up output from generate-xcfilelists so it can be filtered
4112         https://bugs.webkit.org/show_bug.cgi?id=194795
4113
4114         Reviewed by Joseph Pecoraro (and Keith Rollin).
4115
4116         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
4117         make a slight tweak to filter-build-webkit so such lines are marked
4118         as plain.
4119
4120         * Scripts/filter-build-webkit:
4121         * Scripts/generate-xcfilelists:
4122
4123 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
4124
4125         pytest is not correctly auto-installed
4126         https://bugs.webkit.org/show_bug.cgi?id=194707
4127
4128         Reviewed by Carlos Garcia Campos.
4129
4130         * Scripts/webkitpy/thirdparty/__init__.py:
4131         (AutoinstallImportHook._install_pytest):
4132
4133 2019-02-18  Chris Dumez  <cdumez@apple.com>
4134
4135         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
4136         https://bugs.webkit.org/show_bug.cgi?id=194797
4137         <rdar://problem/48055151>
4138
4139         Reviewed by Geoffrey Garen.
4140
4141         Add API test coverage.
4142
4143         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4144
4145 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
4146
4147         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
4148         https://bugs.webkit.org/show_bug.cgi?id=194670
4149         <rdar://problem/39066529>
4150
4151         Reviewed by Tim Horton.
4152
4153         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
4154         pasted in an editable area as attachment elements.
4155
4156         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
4157         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
4158         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
4159         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4160         (TestWebKitAPI::TEST):
4161         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4162         (WTR::InjectedBundlePage::InjectedBundlePage):
4163
4164 2019-02-18  Alex Christensen  <achristensen@webkit.org>
4165
4166         Fix API test after r241728
4167        ​https://bugs.webkit.org/show_bug.cgi?id=194723
4168
4169         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4170         (TEST):
4171         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
4172
4173 2019-02-18  Daniel Bates  <dabates@apple.com>
4174
4175         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
4176         https://bugs.webkit.org/show_bug.cgi?id=192824
4177         <rdar://problem/47100332>
4178
4179         Reviewed by Wenson Hsieh.
4180
4181         Fix a bug where the wrong usage code was used for F13 thru F24.
4182
4183         * WebKitTestRunner/ios/HIDEventGenerator.mm:
4184         (keyCodeForDOMFunctionKey):
4185
4186 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
4187
4188         Bytecode cache should a have a boot-specific validation
4189         https://bugs.webkit.org/show_bug.cgi?id=194769
4190         <rdar://problem/48149509>
4191
4192         Reviewed by Keith Miller.
4193
4194         Add test for WTF::bootSessionUUIDString()
4195
4196         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4197         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
4198         (TEST):
4199
4200 2019-02-18  Alex Christensen  <achristensen@webkit.org>
4201
4202         Disable safe browsing in WKWebView and remove its WKPreferences API
4203         https://bugs.webkit.org/show_bug.cgi?id=194723
4204         <rdar://problem/48122993>
4205
4206         Reviewed by Geoffrey Garen.
4207
4208         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4209         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4210         (TEST):
4211         (safeBrowsingView):
4212         Make tests use SPI instead of API.
4213
4214 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
4215
4216         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
4217         https://bugs.webkit.org/show_bug.cgi?id=194586
4218
4219         Reviewed by Ross Kirsling.
4220
4221         * DumpRenderTree/win/DumpRenderTree.cpp:
4222         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
4223         * Scripts/webkitpy/port/driver.py:
4224         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
4225
4226 2019-02-17  David Kilzer  <ddkilzer@apple.com>
4227
4228         Unreviewed, rolling out r241620.
4229
4230         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
4231         (Requested by ddkilzer on #webkit.)
4232
4233         Reverted changeset:
4234
4235         "[WTF] Add environment variable helpers"
4236         https://bugs.webkit.org/show_bug.cgi?id=192405
4237         https://trac.webkit.org/changeset/241620
4238
4239 2019-02-16  Zalan Bujtas  <zalan@apple.com>
4240
4241         [LFC] RenderImage's default intrinsic size is 0.
4242         https://bugs.webkit.org/show_bug.cgi?id=194745
4243
4244         Reviewed by Antti Koivisto.
4245
4246         * LayoutReloaded/misc/LFC-passing-tests.txt:
4247
4248 2019-02-16  Zalan Bujtas  <zalan@apple.com>
4249
4250         [LFC][BFC] Add support for block replaced intrinsic width.
4251         https://bugs.webkit.org/show_bug.cgi?id=194705
4252
4253         Reviewed by Simon Fraser.
4254
4255         * LayoutReloaded/misc/LFC-passing-tests.txt:
4256
4257 2019-02-16  Zalan Bujtas  <zalan@apple.com>
4258
4259         [LFC] Apply min/max width constraints to preferred width computation
4260         https://bugs.webkit.org/show_bug.cgi?id=194739
4261
4262         Reviewed by Simon Fraser.
4263
4264         * LayoutReloaded/misc/LFC-passing-tests.txt:
4265
4266 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
4267
4268         [WTF] Add environment variable helpers
4269         https://bugs.webkit.org/show_bug.cgi?id=192405
4270
4271         Reviewed by Michael Catanzaro.
4272
4273         * DumpRenderTree/mac/DumpRenderTree.mm:
4274         (libraryPathForDumpRenderTree):
4275         * DumpRenderTree/win/DumpRenderTree.cpp:
4276         (libraryPathForDumpRenderTree):
4277         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
4278         (setUpIOSLayoutTestCommunication):
4279         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
4280         (beforeAll):
4281         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
4282         (main):
4283         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
4284         (WebKitTestBus::run):
4285         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
4286         (WTR::getOutputDir):
4287         (WTR::initializeFontConfigSetting):
4288         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
4289         (WTR::InjectedBundle::platformInitialize):
4290         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
4291         (WTR::topLevelPath):
4292         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
4293         (WTR::topLevelPath):
4294         (WTR::getOutputDir):
4295         (WTR::activateFonts):
4296         * WebKitTestRunner/TestController.cpp:
4297         (WTR::TestController::libraryPathForTesting):
4298         (WTR::TestController::generateContextConfiguration const):
4299         (WTR::TestController::generatePageConfiguration):
4300         (WTR::TestController::decideDestinationWithSuggestedFilename):
4301         (WTR::TestController::platformAdjustContext):
4302         * WebKitTestRunner/TestController.h:
4303         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4304         (WTR::TestController::cocoaPlatformInitialize):
4305         (WTR::TestController::platformAdjustContext):
4306         * WebKitTestRunner/gtk/main.cpp:
4307         (main):
4308         * WebKitTestRunner/mac/TestControllerMac.mm:
4309         (WTR::TestController::configureContentExtensionForTest):
4310         * WebKitTestRunner/wpe/main.cpp:
4311         (main):
4312         Utilize WTF::Environment where possible.
4313
4314 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
4315
4316         [iOS] WKWebView callout bar is missing Change Writing Direction item
4317         https://bugs.webkit.org/show_bug.cgi?id=190015
4318         <rdar://problem/44810366>
4319
4320         Reviewed by Tim Horton.
4321
4322         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
4323         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
4324
4325         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
4326         (TestWebKitAPI::TEST):
4327
4328 2019-02-15  Chris Dumez  <cdumez@apple.com>
4329
4330         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
4331         https://bugs.webkit.org/show_bug.cgi?id=194717
4332         <rdar://problem/47884404>
4333
4334         Reviewed by Brady Eidson.
4335
4336         Add API test coverage.
4337
4338         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4339
4340 2019-02-15  Youenn Fablet  <youenn@apple.com>
4341
4342         Make navigator.mediaDevices SecureContext
4343         https://bugs.webkit.org/show_bug.cgi?id=194666
4344
4345         Reviewed by Eric Carlson.
4346
4347         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
4348         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
4349         (TEST_F):
4350
4351 2019-02-15  Brian Burg  <bburg@apple.com>
4352
4353         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
4354         https://bugs.webkit.org/show_bug.cgi?id=194411
4355         <rdar://problem/47787614>
4356
4357         Reviewed by Joseph Pecoraro.
4358
4359         Remove unnecessary soft linking macro usage.
4360
4361         * DumpRenderTree/mac/TestRunnerMac.mm:
4362         (TestRunner::inspectorTestStubURL):
4363         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
4364         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
4365         (WTR::TestRunner::inspectorTestStubURL):
4366
4367 2019-02-15  Commit Queue  <commit-queue@webkit.org>
4368
4369         Unreviewed, rolling out r241559 and r241566.
4370         https://bugs.webkit.org/show_bug.cgi?id=194710
4371
4372         Causes layout test crashes under GuardMalloc (Requested by
4373         ryanhaddad on #webkit).
4374
4375         Reverted changesets:
4376
4377         "[WTF] Add environment variable helpers"
4378         https://bugs.webkit.org/show_bug.cgi?id=192405
4379         https://trac.webkit.org/changeset/241559
4380
4381         "Unreviewed build fix for WinCairo Debug after r241559."
4382         https://trac.webkit.org/changeset/241566
4383
4384 2019-02-15  Zalan Bujtas  <zalan@apple.com>
4385
4386         [LFC] Out-of-flo