ccddbe165824c8bf3acd95306d74fbf453bd673c
[WebKit-https.git] / Tools / ChangeLog
1 2015-07-06  Alex Christensen  <achristensen@webkit.org>
2
3         [Content Extensions] Remove memory page reporting
4         https://bugs.webkit.org/show_bug.cgi?id=146659
5
6         Reviewed by Benjamin Poulain.
7
8         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
9         (TestWebKitAPI::TEST_F):
10
11 2015-07-06  Benjamin Poulain  <benjamin@webkit.org>
12
13         [Content Extensions] Make the DFA transitions ranges instead of characters
14         https://bugs.webkit.org/show_bug.cgi?id=146575
15
16         Reviewed by Alex Christensen.
17
18         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
19         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
20         Since the minimizer is perfect, we get the minimal solution now,
21         which is really cool!
22
23 2015-07-06  Brady Eidson  <beidson@apple.com>
24
25         ShouldOpenExternalURLsPolicy should default to "Allow" for WK2 API loads.
26         <rdar://problem/21640050> and https://bugs.webkit.org/show_bug.cgi?id=146563
27
28         Reviewed by Geoff Garen.
29
30         * WebKitTestRunner/TestInvocation.cpp:
31         (WTR::TestInvocation::invoke): For testing purposes, all pages should start with the 
32           ShouldOpenExternalURLsPolicy set to "ShouldNotAllow"
33
34 2015-07-06  Daniel Bates  <dabates@apple.com>
35
36         Unreviewed, rolling out r170639.
37
38         Broke using webkit-patch apply-attachment to apply an
39         attachment from a security bug. The patch incorrectly assumed
40         that Bugzilla returns a non-HTTP 200 status code in its HTTP
41         response when authentication is required.
42
43         Reverted changeset:
44
45         "webkit-patch apply-from-bug / apply-attachment should not ask
46         for credentials if none are required"
47         https://bugs.webkit.org/show_bug.cgi?id=40095
48         http://trac.webkit.org/changeset/170639
49
50 2015-07-04  Chris Dumez  <cdumez@apple.com>
51
52         Drop RefPtr::clear() method
53         https://bugs.webkit.org/show_bug.cgi?id=146556
54
55         Reviewed by Brady Eidson.
56
57         Drop RefPtr::clear() method in favor of "= nullptr;" pattern.
58
59 2015-07-03  Dan Bernstein  <mitz@apple.com>
60
61         Fixed the iOS build.
62
63         * DumpRenderTree/mac/EventSendingController.mm:
64         (+[EventSendingController isSelectorExcludedFromWebScript:]):
65         (+[EventSendingController webScriptNameForSelector:]):
66
67 2015-07-03  Dan Bernstein  <mitz@apple.com>
68
69         [Xcode] Update some build settings as recommended by Xcode 7
70         https://bugs.webkit.org/show_bug.cgi?id=146597
71
72         Reviewed by Sam Weinig.
73
74         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Updated LastUpgradeCheck.
75
76         * DumpRenderTree/mac/Configurations/Base.xcconfig: Enabled GCC_NO_COMMON_BLOCKS,
77         ENABLE_STRICT_OBJC_MSGSEND, CLANG_WARN_BOOL_CONVERSION, CLANG_WARN_CONSTANT_CONVERSION,
78         CLANG_WARN_EMPTY_BODY, CLANG_WARN_ENUM_CONVERSION, CLANG_WARN_INT_CONVERSION,
79         CLANG_WARN_UNREACHABLE_CODE, GCC_WARN_ABOUT_RETURN_TYPE,
80         GCC_WARN_UNINITIALIZED_AUTOS, and GCC_WARN_UNDECLARED_SELECTOR.
81
82         * DumpRenderTree/mac/EventSendingController.mm:
83         (+[EventSendingController webScriptNameForSelector:]): Removed check for setDragMode:,
84         which was removed in r19101.
85
86         * DumpRenderTree/mac/TextInputController.m:
87         (-[TextInputController interpretKeyEvents:withSender:]): Suppressed -Wundeclared-selector
88         around used of a selector not that is not declared anywhere.
89
90         * MiniBrowser/Configurations/Base.xcconfig: Enabled GCC_NO_COMMON_BLOCKS.
91
92         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Updated LastUpgradeCheck.
93
94         * TestWebKitAPI/Configurations/Base.xcconfig: Enabled GCC_NO_COMMON_BLOCKS,
95         ENABLE_STRICT_OBJC_MSGSEND, CLANG_WARN_BOOL_CONVERSION, CLANG_WARN_CONSTANT_CONVERSION,
96         CLANG_WARN_EMPTY_BODY, CLANG_WARN_ENUM_CONVERSION, CLANG_WARN_INT_CONVERSION,
97         CLANG_WARN_UNREACHABLE_CODE, GCC_WARN_ABOUT_RETURN_TYPE,
98         GCC_WARN_UNINITIALIZED_AUTOS, and GCC_WARN_UNDECLARED_SELECTOR.
99
100         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Updated LastUpgradeCheck.
101
102 2015-07-02  Daniel Bates  <dabates@apple.com>
103
104         [iOS] Add WebKitSystemInterface for iOS 8.4
105         https://bugs.webkit.org/show_bug.cgi?id=146548
106
107         Rubber-stamped by Zalan Bujtas.
108
109         * Scripts/copy-webkitlibraries-to-product-directory:
110
111 2015-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
112
113         [GTK] WebSQL doesn't work because openDatabase always fails with DOM Exception 18
114         https://bugs.webkit.org/show_bug.cgi?id=146234
115
116         Reviewed by Sergio Villar Senin.
117
118         Enable the WebSQL directory test that was disabled because of this bug.
119
120         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
121         (testWebContextConfiguration):
122
123 2015-07-01  Matthew Daiter  <mdaiter@apple.com>
124
125         Enabled MEDIA_STREAM flag
126         https://bugs.webkit.org/show_bug.cgi?id=145947
127         <rdar://problem/21365829>
128         
129         Reviewed by Eric Carlson.
130
131         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
132
133 2015-06-30  Martin Robinson  <mrobinson@igalia.com>
134
135         [GTK] REGRESSION(r183936): Test /webkit2/WebKitWebContext/spell-checker fails since r183936
136         https://bugs.webkit.org/show_bug.cgi?id=144828
137
138         Reviewed by Carlos Garcia Campos.
139
140         * WebKitTestRunner/gtk/main.cpp:
141         (main): Use the new WKTextChecker API to set the spell checking languages
142         when the process is starting up.
143
144 2015-06-30  Andy VanWagoner  <thetalecrafter@gmail.com>
145
146         Implement ECMAScript Internationalization API
147         https://bugs.webkit.org/show_bug.cgi?id=90906
148
149         Reviewed by Benjamin Poulain.
150
151         * Scripts/webkitperl/FeatureList.pm: add ENABLE_INTL flag
152
153 2015-06-30  Jonathan Davis  <jond@apple.com>
154
155         Unreviewed. Added myself as a committer.
156
157         * Scripts/webkitpy/common/config/contributors.json:
158
159 2015-06-30  Brent Fulgham  <bfulgham@apple.com>
160
161         Unreviewed build fix.
162
163         * Scripts/update-webkit-dependency: Try to build even if we cannot connect
164         to developer.apple.com to get update libraries.
165
166 2015-06-29  Jake Nielsen  <jacob_nielsen@apple.com>
167
168         Add timeout in run-webkit-tests for launching the simulator
169         https://bugs.webkit.org/show_bug.cgi?id=146371
170
171         Reviewed by Darin Adler.
172
173         Adds a default 5-minute timeout using the timeout class in webkitpy.benchmark_runner.utils
174         for the otherwise infinitely patient wait_until_device_is_in_state method.
175
176         * Scripts/webkitpy/xcode/simulator.py:
177         (Simulator.DeviceState):
178         (Simulator):
179         (Simulator.wait_until_device_is_in_state):
180         (Simulator.device_state):
181
182 2015-06-29  Benjamin Poulain  <benjamin@webkit.org>
183
184         Make the NFA transitions range-based
185         https://bugs.webkit.org/show_bug.cgi?id=146338
186
187         Reviewed by Alex Christensen.
188
189         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
190         Test some new interesting cases.
191
192 2015-06-28  Dan Bernstein  <mitz@apple.com>
193
194         [Xcode] Use the same environment for command-line and IDE builds
195         https://bugs.webkit.org/show_bug.cgi?id=146401
196
197         Reviewed by Anders Carlsson.
198
199         * Scripts/webkitdirs.pm:
200         (XcodeOptions): Set the UseSanitizedBuildSystemEnvironment user default to YES, which makes
201         xcodebuild use the same environment Xcode uses.
202
203 2015-06-28  Dan Bernstein  <mitz@apple.com>
204
205         REGRESSION (r185915): Source-incompatible change in WKPageUIClient
206         https://bugs.webkit.org/show_bug.cgi?id=146396
207
208         Reviewed by Anders Carlsson.
209
210         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
211         (TestWebKitAPI::runJavaScriptAlert): Removed _deprecatedForUseWithV0 suffix from the name.
212         (TestWebKitAPI::TEST): Updated for renames.
213         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
214         (runJavaScriptAlert): Removed suffix.
215         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView): Updated.
216         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
217         (runJavaScriptAlert): Removed suffix.
218         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView): Updated.
219
220 2015-06-27  Carlos Garcia Campos  <cgarcia@igalia.com>
221
222         [GTK][SOUP] Implement WebCore::PublicSuffix for soup and enable PUBLIC_SUFFIX_LIST for GTK+
223         https://bugs.webkit.org/show_bug.cgi?id=146318
224
225         Reviewed by Sergio Villar Senin.
226
227         Copy mac PublicSuffix test to the common directory and add it to
228         the GTK+ build.
229
230         * TestWebKitAPI/PlatformGTK.cmake:
231         * TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp: Added.
232         (TestWebKitAPI::TEST_F):
233
234 2015-06-26  Per Arne Vollan  <peavo@outlook.com>
235
236         WinLauncher fails to download files.
237         https://bugs.webkit.org/show_bug.cgi?id=146242
238
239         Reviewed by Alex Christensen.
240
241         Added WinLauncher download delegate.
242
243         * WinLauncher/Common.cpp:
244         * WinLauncher/WebDownloadDelegate.cpp: Added.
245         (WebDownloadDelegate::WebDownloadDelegate):
246         (WebDownloadDelegate::~WebDownloadDelegate):
247         (WebDownloadDelegate::QueryInterface):
248         (WebDownloadDelegate::AddRef):
249         (WebDownloadDelegate::Release):
250         (WebDownloadDelegate::decideDestinationWithSuggestedFilename):
251         (WebDownloadDelegate::didCancelAuthenticationChallenge):
252         (WebDownloadDelegate::didCreateDestination):
253         (WebDownloadDelegate::didFailWithError):
254         (WebDownloadDelegate::didReceiveAuthenticationChallenge):
255         (WebDownloadDelegate::didReceiveDataOfLength):
256         (WebDownloadDelegate::didReceiveResponse):
257         (WebDownloadDelegate::shouldDecodeSourceDataOfMIMEType):
258         (WebDownloadDelegate::willResumeWithResponse):
259         (WebDownloadDelegate::willSendRequest):
260         (WebDownloadDelegate::didBegin):
261         (WebDownloadDelegate::didFinish):
262         * WinLauncher/WebDownloadDelegate.h: Added.
263         * WinLauncher/WinLauncher.cpp:
264         (WinLauncher::setAccessibilityDelegate):
265         (WinLauncher::setResourceLoadDelegate):
266         (WinLauncher::setDownloadDelegate):
267         (WinLauncher::mainFrame):
268         * WinLauncher/WinLauncher.h:
269         (WinLauncher::standardPreferences):
270         (WinLauncher::privatePreferences):
271         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
272         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
273         * WinLauncher/WinMain.cpp:
274         (wWinMain):
275
276 2015-06-26  Csaba Osztrogonác  <ossy@webkit.org>
277
278         [EFL] Bump libseccomp version to 2.2.1
279         https://bugs.webkit.org/show_bug.cgi?id=146341
280
281         Reviewed by Gyuyoung Kim.
282
283         * efl/jhbuild.modules:
284         * efl/jhbuildrc: Enabled libseccomp build on AArch64.
285         * efl/patches/libseccomp-pick-up-CC.patch: Removed, we don't need it anymore.
286
287 2015-06-25  Alex Christensen  <achristensen@webkit.org>
288
289         [Content Extensions] Add a way to match a domain but not subdomains
290         https://bugs.webkit.org/show_bug.cgi?id=146241
291         rdar://problem/21557754
292
293         Reviewed by Darin Adler.
294
295         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
296         (TestWebKitAPI::TEST_F):
297         Update subdomain test because of changed behavior and add test for new '*' functionality.
298
299 2015-06-25  Jaehun Lim  <ljaehun.lim@samsung.com>
300
301         Cleanup ENABLE_CSS3_CONDITIONAL_RULES codes.
302         https://bugs.webkit.org/show_bug.cgi?id=146308
303
304         Reviewed by Csaba Osztrogonác.
305
306         ENABLE_CSS3_CONDITIONAL_RULES guard was removed from r174536.
307
308         * Scripts/webkitperl/FeatureList.pm:
309
310 2015-06-25  Carlos Garcia Campos  <cgarcia@igalia.com>
311
312         [GTK] Add initial WebKitWebsiteDataManager API for process configuration options
313         https://bugs.webkit.org/show_bug.cgi?id=146149
314
315         Reviewed by Sergio Villar Senin.
316
317         Update unit tests to use WebKitWebsiteDataManager.
318
319         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
320         (testWebContextConfiguration):
321         (serverCallback):
322         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
323         (Test::Test): Use WebKitWebsiteDataManager and set all possible
324         values to ensure unit tests don't write outside the temporary directory.
325         (Test::~Test): Explicitly reset the web context to ensure its
326         objects are released before the leaks check.
327         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
328         (WebViewTest::wait): Fix the GSource used, since we are receiving
329         a double in seconds, but using g_timeout_add_seconds() that
330         expects an unsigned in seconds. Use GMainLoopSource to correctly
331         handle the value and simplify the code.
332
333 2015-06-24  Jason Marcell  <jmarcell@apple.com>
334
335         Work towards: Add status of Safari projects on iOS Dashboard on build-safari
336         https://bugs.webkit.org/show_bug.cgi?id=146126
337         <rdar://problem/18226291>
338
339         Reviewed by Alexey Proskuryakov.
340
341         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
342         (documentReady): Using combined queues to display iOS projects
343
344 2015-06-24  Doug Russell  <d_russell@apple.com>
345
346         Bug 146177 - AX: AXObjectCache should try to use an unignored accessibilityObject 
347         when posting a selection notification when on the border between two accessibilityObjects
348         https://bugs.webkit.org/show_bug.cgi?id=146177
349
350         Reviewed by Darin Adler.
351
352         Add support for mapping WebCore Accessibility types into JSValueRef types
353         so they can be used in tests.
354
355         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
356         (webAccessibilityObjectWrapperClass):
357         (-[AccessibilityNotificationHandler startObserving]):
358         (makeValueRefForValue):
359         (makeArrayRefForArray):
360         (makeObjectRefForDictionary):
361         (-[AccessibilityNotificationHandler _notificationReceived:]):
362         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
363         (webAccessibilityObjectWrapperClass):
364         (-[AccessibilityNotificationHandler startObserving]):
365         (makeValueRefForValue):
366         (makeArrayRefForArray):
367         (makeObjectRefForDictionary):
368         (-[AccessibilityNotificationHandler _notificationReceived:]):
369
370 2015-06-24  Zalan Bujtas  <zalan@apple.com>
371
372         Subpixel rendering: roundToDevicePixel() snaps to wrong value.
373         https://bugs.webkit.org/show_bug.cgi?id=146273
374         rdar://problem/18509840
375
376         Reviewed by Simon Fraser.
377
378         Due to the floating point approximate representation, we can't always produce
379         the correct snap value. This patch addresses the issue by removing redundant kFixedPointDenominator multiplication
380         and by changing the rounding in roundToDevicePixel() from float to double.
381
382         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
383         (TestWebKitAPI::TEST):
384
385 2015-06-24  Brady Eidson  <beidson@apple.com>
386
387         Update JavaScript dialog delegates to include a WKSecurityOriginRef argument.
388         <rdar://problem/21269187> and https://bugs.webkit.org/show_bug.cgi?id=146249
389
390         Reviewed by Alex Christensen.
391
392         - Update WKTR to the new client structure.
393         - Update existing TestWebKitAPI tests to either use the new client structure or
394           assign the old function signature to the updated variable name.
395         - Include a new test.
396
397         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
398
399         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp:
400         (TestWebKitAPI::runJavaScriptAlert):
401
402         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
403         (TestWebKitAPI::TEST):
404
405         * TestWebKitAPI/Tests/WebKit2/ModalAlertsSPI.cpp:
406         (TestWebKitAPI::analyzeDialogArguments):
407         (TestWebKitAPI::runJavaScriptAlert):
408         (TestWebKitAPI::runJavaScriptConfirm):
409         (TestWebKitAPI::runJavaScriptPrompt):
410         (TestWebKitAPI::createNewPage):
411         (TestWebKitAPI::TEST):
412
413         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
414         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
415
416         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
417         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
418
419         * WebKitTestRunner/TestController.cpp:
420         (WTR::TestController::createOtherPage):
421         (WTR::TestController::createWebViewWithOptions):
422
423 2015-06-23  Dewei Zhu  <dewei_zhu@apple.com>
424
425         Refactoring benchmark runner script to follow pep8 code style.
426         https://bugs.webkit.org/show_bug.cgi?id=146264
427
428         Reviewed by Ryosuke Niwa.
429
430         Refactor benchmark runner script to follow pep8 code style.
431
432         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
433         (GenericBenchmarkBuilder.prepare):
434         (GenericBenchmarkBuilder._run_create_script):
435         (GenericBenchmarkBuilder._copy_benchmark_to_temp_dir):
436         (GenericBenchmarkBuilder._fetch_remote_archive):
437         (GenericBenchmarkBuilder):
438         (GenericBenchmarkBuilder._checkout_with_subversion):
439         (GenericBenchmarkBuilder._apply_patch):
440         (GenericBenchmarkBuilder.clean):
441         (GenericBenchmarkBuilder._runCreateScript): Deleted.
442         (GenericBenchmarkBuilder._copyBenchmarkToTempDir): Deleted.
443         (GenericBenchmarkBuilder._fetchRemoteArchive): Deleted.
444         (GenericBenchmarkBuilder._checkoutWithSubverion): Deleted.
445         (GenericBenchmarkBuilder._applyPatch): Deleted.
446         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
447         (BenchmarkRunner.__init__):
448         (BenchmarkRunner._find_plan_file):
449         (BenchmarkRunner.execute):
450         (BenchmarkRunner._cleanup):
451         (BenchmarkRunner._dump):
452         (BenchmarkRunner._wrap):
453         (BenchmarkRunner._merge):
454         (BenchmarkRunner._show_results):
455         (BenchmarkRunner._findPlanFile): Deleted.
456         (BenchmarkRunner.cleanup): Deleted.
457         (BenchmarkRunner.dump): Deleted.
458         (BenchmarkRunner.wrap): Deleted.
459         (BenchmarkRunner.merge): Deleted.
460         (BenchmarkRunner.show_results): Deleted.
461         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
462         (BrowserDriver.prepare_env):
463         (BrowserDriver.launch_url):
464         (BrowserDriver.close_browsers):
465         (BrowserDriver.prepareEnv): Deleted.
466         (BrowserDriver.launchUrl): Deleted.
467         (BrowserDriver.closeBrowser): Deleted.
468         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
469         (OSXBrowserDriver):
470         (OSXBrowserDriver.prepare_env):
471         (OSXBrowserDriver.close_browsers):
472         (OSXBrowserDriver._launch_process):
473         (OSXBrowserDriver._terminiate_processes):
474         (OSXBrowserDriver._launch_process_with_caffinate):
475         (OSXBrowserDriver._screen_size):
476         (OSXBrowserDriver.prepareEnv): Deleted.
477         (OSXBrowserDriver.closeBrowsers): Deleted.
478         (OSXBrowserDriver.launchProcess): Deleted.
479         (OSXBrowserDriver.terminateProcesses): Deleted.
480         (OSXBrowserDriver.launchProcessWithCaffinate): Deleted.
481         (OSXBrowserDriver.screenSize): Deleted.
482         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
483         (OSXChromeDriver):
484         (OSXChromeDriver.launch_url):
485         (OSXChromeCanaryDriver):
486         (OSXChromeCanaryDriver.launch_url):
487         (OSXChromeDriver.launchUrl): Deleted.
488         (OSXChromeCanaryDriver.launchUrl): Deleted.
489         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
490         (OSXFirefoxDriver):
491         (OSXFirefoxDriver.launch_url):
492         (OSXFirefoxNightlyDriver):
493         (OSXFirefoxNightlyDriver.launch_url):
494         (OSXFirefoxDriver.launchUrl): Deleted.
495         (OSXFirefoxNightlyDriver.launchUrl): Deleted.
496         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
497         (OSXSafariDriver):
498         (OSXSafariDriver.prepare_env):
499         (OSXSafariDriver.launch_url):
500         (OSXSafariDriver.close_browsers):
501         (OSXSafariDriver._maximize_window):
502         (OSXSafariDriver.prepareEnv): Deleted.
503         (OSXSafariDriver.launchUrl): Deleted.
504         (OSXSafariDriver.closeBrowsers): Deleted.
505         (OSXSafariDriver.maximizeWindow): Deleted.
506         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
507         (HTTPServerDriver.fetch_result):
508         (HTTPServerDriver.kill_server):
509         (HTTPServerDriver.get_return_code):
510         (HTTPServerDriver.set_device_id):
511         (HTTPServerDriver.fetchResult): Deleted.
512         (HTTPServerDriver.killServer): Deleted.
513         (HTTPServerDriver.getReturnCode): Deleted.
514         (HTTPServerDriver.setDeviceID): Deleted.
515         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
516         (SimpleHTTPServerDriver.serve):
517         (SimpleHTTPServerDriver.base_url):
518         (SimpleHTTPServerDriver.fetch_result):
519         (SimpleHTTPServerDriver.kill_server):
520         (SimpleHTTPServerDriver.get_return_code):
521         (SimpleHTTPServerDriver): Deleted.
522         (SimpleHTTPServerDriver.baseUrl): Deleted.
523         (SimpleHTTPServerDriver.fetchResult): Deleted.
524         (SimpleHTTPServerDriver.killServer): Deleted.
525         (SimpleHTTPServerDriver.getReturnCode): Deleted.
526         * Scripts/webkitpy/benchmark_runner/utils.py:
527         (get_path_from_project_root):
528         (force_remove):
529         (getPathFromProjectRoot): Deleted.
530         (forceRemove): Deleted.
531
532 2015-06-23  Anders Carlsson  <andersca@apple.com>
533
534         Add operator! and copy/move constructors to WeakObjCPtr
535         https://bugs.webkit.org/show_bug.cgi?id=146255
536
537         Reviewed by Andreas Kling.
538
539         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm:
540         (TEST):
541
542 2015-06-23  Simon Fraser  <simon.fraser@apple.com>
543
544         Expose some more rendering progress events, and have MiniBrowser log for each of them
545         https://bugs.webkit.org/show_bug.cgi?id=146227
546
547         Reviewed by Darin Adler.
548
549         Register for layout milestones/rendering progress events in the WK1 and WK2
550         browser window controllers, and, if logging is turned on, log when they are
551         reached.
552
553         * MiniBrowser/mac/WK1BrowserWindowController.m:
554         (-[WK1BrowserWindowController awakeFromNib]):
555         (-[WK1BrowserWindowController webView:didLayout:]):
556         * MiniBrowser/mac/WK2BrowserWindowController.m:
557         (-[WK2BrowserWindowController awakeFromNib]):
558         (-[WK2BrowserWindowController _webView:renderingProgressDidChange:]):
559
560 2015-06-23  Brady Eidson  <beidson@apple.com>
561
562         WKFrameInfo should have an accessor for the Frame's current security origin.
563         https://bugs.webkit.org/show_bug.cgi?id=146162
564
565         Reviewed by Dan Bernstein.
566
567         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
568         * TestWebKitAPI/Tests/WebKit2/modal-alerts-in-new-about-blank-window.html: Added.
569         * TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm: Added.
570         (sawDialog):
571         (-[ModalAlertsUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
572         (-[ModalAlertsUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
573         (-[ModalAlertsUIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
574         (-[ModalAlertsUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
575         (TEST):
576
577 2015-06-23  Tanay C  <tanay.c@samsung.com>
578
579         Remove build warnings in Tools/DumpRenderTree/TestNetscapePlugIn
580         https://bugs.webkit.org/show_bug.cgi?id=146007
581
582         Reviewed by Darin Adler.
583
584         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
585         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: Add attribute to functions.
586         (pluginLogWithWindowObject):
587         (pluginLogWithArguments):
588         (pluginLog):
589         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: Add attribute to functions.
590         (PluginTest::executeScript):
591         (PluginTest::log):
592
593 2015-06-23  Csaba Osztrogonác  <ossy@webkit.org>
594
595         [EFL] Add libhyphen-dev as dependency after r185862
596         https://bugs.webkit.org/show_bug.cgi?id=146230
597
598         Reviewed by Gyuyoung Kim.
599
600         * efl/install-dependencies:
601
602 2015-06-22  Ryuan Choi  <ryuan.choi@navercorp.com>
603
604         [EFL] Hyphenation is not supported
605         https://bugs.webkit.org/show_bug.cgi?id=89830
606
607         Reviewed by Gyuyoung Kim.
608
609         * efl/jhbuild.modules: Added webkitgtk-test-dicts for layout test.
610
611 2015-06-22  Dewei Zhu  <dewei_zhu@apple.com>
612
613         Get rid of factory json files in benchmark_runner
614         https://bugs.webkit.org/show_bug.cgi?id=146175
615
616         Reviewed by Ryosuke Niwa.
617
618         Get rid of factory json files in benchmark_runner and refactoring the code.
619
620         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py:
621         (benchmark_builder_loader):
622         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py:
623         (BenchmarkBuilderFactory):
624         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Removed.
625         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
626         (GenericBenchmarkBuilder):
627         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
628         (BenchmarkRunner.__init__):
629         (BenchmarkRunner.execute):
630         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py:
631         (browser_driver_loader):
632         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
633         (BrowserDriver):
634         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
635         (BrowserDriverFactory):
636         (BrowserDriverFactory.available_platforms):
637         (BrowserDriverFactory.available_browsers):
638         (BrowserDriverFactory.add_browser_driver):
639         (BrowserDriverFactory.create):
640         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json: Removed.
641         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
642         (OSXBrowserDriver):
643         (OSXBrowserDriver.prepareEnv):
644         (OSXBrowserDriver.terminateProcesses):
645         (OSXBrowserDriver.screenSize):
646         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
647         (OSXChromeDriver):
648         (OSXChromeCanaryDriver):
649         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
650         (OSXFirefoxDriver):
651         (OSXFirefoxNightlyDriver):
652         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
653         (OSXSafariDriver):
654         * Scripts/webkitpy/benchmark_runner/generic_factory.py:
655         (GenericFactory.create):
656         (GenericFactory.add):
657         (GenericFactory.iterateGetItem): Deleted.
658         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py:
659         (http_server_driver_loader):
660         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
661         (HTTPServerDriver):
662         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver_factory.py:
663         (HTTPServerDriverFactory):
664         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_drivers.json: Removed.
665         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
666         (SimpleHTTPServerDriver):
667         * Scripts/webkitpy/benchmark_runner/utils.py:
668         (is_subclass):
669         (load_subclasses):
670         (ModuleNotFoundError): Deleted.
671         (loadModule): Deleted.
672         (loadJSONFromFile): Deleted.
673
674 2015-06-22  Simon Fraser  <simon.fraser@apple.com>
675
676         Make it possible to enable incremental rendering suppression in MiniBrowser
677         https://bugs.webkit.org/show_bug.cgi?id=146223
678         
679         Reviewed by Tim Horton.
680
681         Add a menu item to enable incremental rendering suppression to MiniBrowser.
682         
683         For WK1, this just toggles a pref, and takes effect immediately.
684         
685         For WK2, this is a WKConfiguration property, so only affects new web views.
686         
687         Also remove a toolbar item connection to toggleUseMinimumViewSize: that caused
688         logging on launch.
689
690         * MiniBrowser/mac/AppDelegate.m:
691         (defaultConfiguration):
692         * MiniBrowser/mac/BrowserWindow.xib:
693         * MiniBrowser/mac/SettingsController.h:
694         * MiniBrowser/mac/SettingsController.m:
695         (-[SettingsController _populateMenu]):
696         (-[SettingsController validateMenuItem:]):
697         (-[SettingsController toggleIncrementalRenderingSuppressed:]):
698         (-[SettingsController incrementalRenderingSuppressed]):
699         * MiniBrowser/mac/WK1BrowserWindowController.m:
700         (-[WK1BrowserWindowController didChangeSettings]):
701
702 2015-06-19  Filip Pizlo  <fpizlo@apple.com>
703
704         Run CDjs as part of JSC stress testing
705         https://bugs.webkit.org/show_bug.cgi?id=146174
706
707         Reviewed by Geoffrey Garen.
708
709         * Scripts/run-javascriptcore-tests:
710         (runJSCStressTests): Make this aware of the cdjs-tests.yaml.
711         * Scripts/run-jsc-stress-tests:
712         - Teach this about tests that indicate error by returning an error code while also having lots of output even when they succeed.
713         - Add the ability to have "tests" be a list of tests rather than just one test. This could also be a list of directories that have tests.
714         - Fix a bug with bundle copying: whether the $collection should have the basename appended depends on whether we copy into bundleDir.dirname, not on whether absoluteCollection is a directory.
715
716 2015-06-21  Alexey Proskuryakov  <ap@apple.com>
717
718         REGRESSION (r172975): navigator.language unable to tell region for Traditional Chinese users
719         https://bugs.webkit.org/show_bug.cgi?id=146121
720         rdar://problem/21395180
721
722         Reviewed by Darin Adler.
723
724         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
725         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm: Added.
726         (-[NavigatorLanguageDelegate webView:didFinishLoadForFrame:]):
727         (TestWebKitAPI::overrideAppleLanguages):
728         (TestWebKitAPI::languageForSystemLanguage):
729         (TestWebKitAPI::TEST):
730
731 2015-06-21  Michael Catanzaro  <mcatanzaro@igalia.com>
732
733         [CMake] Ignore warnings from system headers when compiling Tools
734         https://bugs.webkit.org/show_bug.cgi?id=146185
735
736         Reviewed by Martin Robinson.
737
738         Use the SYSTEM argument to the include_directories() command to silence compiler warnings
739         from system headers that we don't control.
740
741         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
742         * ImageDiff/CMakeLists.txt: Also, remove an EFL include directory from here...
743         * ImageDiff/PlatformEfl.cmake: ...and put it here where it belongs.
744         * ImageDiff/PlatformGTK.cmake:
745         * MiniBrowser/efl/CMakeLists.txt:
746         * MiniBrowser/gtk/CMakeLists.txt:
747         * TestWebKitAPI/PlatformEfl.cmake:
748         * TestWebKitAPI/PlatformGTK.cmake:
749         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
750         * WebKitTestRunner/CMakeLists.txt:
751         * WebKitTestRunner/PlatformEfl.cmake:
752         * WebKitTestRunner/PlatformGTK.cmake:
753
754 2015-06-20  Michael Catanzaro  <mcatanzaro@igalia.com>
755
756         [GTK] Define GDK_VERSION_MIN_REQUIRED when compiling MiniBrowser
757         https://bugs.webkit.org/show_bug.cgi?id=146186
758
759         Reviewed by Martin Robinson.
760
761         Define GDK_VERSION_MIN_REQUIRED when compiling MiniBrowser to silence several dozen
762         deprecation warnings. (MiniBrowser is unique in that it does not include wtf/Platform.h.)
763
764         * MiniBrowser/gtk/CMakeLists.txt:
765
766 2015-06-19  Ryosuke Niwa  <rniwa@webkit.org>
767
768         Build fix after r146125.
769
770         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
771         (OSXSafariDriver):
772         (OSXSafariDriver.prepareEnv):
773
774 2015-06-19  Brady Eidson  <beidson@apple.com>
775
776         Rename WKSecurityOrigin.h/cpp to WKSecurityOriginRef.h/cpp.
777         https://bugs.webkit.org/show_bug.cgi?id=146152
778
779         Reviewed by Dan Bernstein.
780
781         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
782         * WebKitTestRunner/WebNotificationProvider.cpp:
783
784 2015-06-19  Mark Lam  <mark.lam@apple.com>
785
786         CheckedArithmetic's operator bool() and operator==() is broken.
787         https://bugs.webkit.org/show_bug.cgi?id=146129
788
789         Reviewed by Geoffrey Garen and Oliver Hunt.
790
791         Added API tests for operator ==, !=, <, <=, >, and >=, and tested for both normal
792         and overflow scenarios in usage of the Checked arithmetic class.
793
794         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
795         (TestWebKitAPI::OverflowCrashLogger::overflowed):
796         (TestWebKitAPI::OverflowCrashLogger::clearOverflow):
797         (TestWebKitAPI::OverflowCrashLogger::crash):
798         (TestWebKitAPI::OverflowCrashLogger::reset):
799         (TestWebKitAPI::OverflowCrashLogger::hasOverflowed):
800         (TestWebKitAPI::OverflowCrashLogger::overflowCount):
801         (TestWebKitAPI::OverflowCrashLogger::didCrash):
802         - crash logger for verifying that a crash occurs when expected. 
803
804         (TestWebKitAPI::resetOverflow):
805         - convenience function for resetting a test value to an initial overflowed state
806           before a crash.  We will use this value in the overflow testing.
807
808         (TestWebKitAPI::CheckedArithmeticTester::run):
809         - Added new tests for all the comparison operators.
810
811 2015-06-19  Per Arne Vollan  <peavo@outlook.com>
812
813         Fix the Windows build after r185721
814         https://bugs.webkit.org/show_bug.cgi?id=146146
815
816         Reviewed by Csaba Osztrogonác.
817
818         Speculative buildfix.
819
820         * DumpRenderTree/win/UIDelegate.h:
821         (UIDelegate::unused4): Added.
822         (UIDelegate::webViewShouldInterruptJavaScript): Deleted.
823
824 2015-06-19  Diego Pino Garcia  <dpino@igalia.com>
825
826         Unreviewed. Add myself as a committer.
827
828         * Scripts/webkitpy/common/config/contributors.json:
829
830 2015-06-19  Csaba Osztrogonác  <ossy@webkit.org>
831
832         Remove unnecessary svn:executable flags
833         https://bugs.webkit.org/show_bug.cgi?id=146107
834
835         Reviewed by Alexey Proskuryakov.
836
837         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-green.png: Removed property svn:executable.
838         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-red.png: Removed property svn:executable.
839         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/daterangepicker.css: Removed property svn:executable.
840         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/jquery.daterangepicker.js: Removed property svn:executable.
841         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/moment.min.js: Removed property svn:executable.
842         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Removed property svn:executable.
843         * CygwinDownloader/cygwin-downloader.zip: Removed property svn:executable.
844         * DumpRenderTree/ForwardingHeaders/runtime/JSExportMacros.h: Removed property svn:executable.
845         * DumpRenderTree/win/TextInputController.cpp: Removed property svn:executable.
846         * DumpRenderTree/win/TextInputController.h: Removed property svn:executable.
847         * DumpRenderTree/win/TextInputControllerWin.cpp: Removed property svn:executable.
848         * Scripts/webkitpy/port/base_unittest.py: Removed property svn:executable.
849         * Scripts/webkitpy/port/driver.py: Removed property svn:executable.
850         * Scripts/webkitpy/w3c/test_parser.py: Removed property svn:executable.
851
852 2015-06-19  Csaba Osztrogonác  <ossy@webkit.org>
853
854         Disable tests on the WinCairo buildbot
855         https://bugs.webkit.org/show_bug.cgi?id=146106
856
857         Reviewed by Alexey Proskuryakov.
858
859         * BuildSlaveSupport/build.webkit.org-config/config.json:
860         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
861
862 2015-06-19  Hunseop Jeong  <hs85.jeong@samsung.com>
863
864         [EFL] Fix the minibrowser after r185725
865         https://bugs.webkit.org/show_bug.cgi?id=146135
866
867         Reviewed by Gyuyoung Kim.
868
869         Removed the HAVE_ECORE_X guard in MiniBrowser because it is an unnecessary guard
870         for the elm_config_accel_preference_set() to set the config of acceleration preference.
871
872         * MiniBrowser/efl/main.c:
873         (elm_main): Deleted the HAVE_ECORE_X guard.
874
875 2015-06-18  Dewei Zhu  <dewei_zhu@apple.com>
876
877         Extend capability of run-benchmark script to support mobile device
878         https://bugs.webkit.org/show_bug.cgi?id=146125
879
880         Reviewed by Ryosuke Niwa.
881
882         Extend capability of run-benchmark to support mobile device, and move majority of run-benchmark script code to
883         benchmark_runner directory, and make run-benchmark a wrapping script. Also correct a typo.
884
885         * Scripts/run-benchmark:
886         (main): Deleted.
887         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
888         (BenchmarkRunner.__init__):
889         (BenchmarkRunner.execute):
890         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
891         (BrowserDriver.prepareEnv):
892         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
893         (OSXBrowserDriver.prepareEnv):
894         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
895         (OSXSafariDriver.prepareEnv):
896         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
897         (HTTPServerDriver.getReturnCode):
898         (HTTPServerDriver):
899         (HTTPServerDriver.setDeviceID):
900         * Scripts/webkitpy/benchmark_runner/run_benchmark.py: Copied from Tools/Scripts/run-benchmark.
901         (parse_args):
902         (start):
903         (main):
904         * Scripts/webkitpy/benchmark_runner/utils.py:
905         (getPathFromProjectRoot):
906
907 2015-06-18  Jon Lee  <jonlee@apple.com>
908
909         Unreviewed. Add Matt Daiter as a contributor.
910
911         * Scripts/webkitpy/common/config/contributors.json:
912
913 2015-06-18  Mark Lam  <mark.lam@apple.com>
914
915         Refactor CheckedArithmeticOperations.cpp to use templates instead of macros.
916         https://bugs.webkit.org/show_bug.cgi?id=146103
917
918         Not reviewed.
919
920         Follow up to fix some typos not caught before original patch was landed.
921
922         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
923         (TestWebKitAPI::CheckedArithmeticTester::run):
924         (TestWebKitAPI::AllowMixedSignednessTest::run):
925         (TestWebKitAPI::IgnoreMixedSignednessTest::run):
926
927 2015-06-18  Daniel Bates  <dabates@apple.com>
928
929         Make webkitdirs::runGitUpdate() work when invoked in more than one Git checkout
930         https://bugs.webkit.org/show_bug.cgi?id=146082
931
932         Reviewed by Darin Adler.
933
934         The function webkitdirs::runGitUpdate may not update the Git checkout in the current
935         working directory after being invoked in a different Git checkout. In particular,
936         calling runGitUpdate() inside a Git SVN checkout and subsequently calling it inside
937         a pure Git checkout g will fail to update g.
938
939         Currently webkitdirs::runGitUpdate() calls VCSUtils::isGitSVN() to determine whether
940         the current working directory is a Git SVN checkout. And isGitSVN() caches its result
941         to speed up subsequent queries. This prevents runGitUpdate() from being used to update
942         an arbitrary Git checkout (since isGitSVN() may return a cached result for a directory
943         different than the current working directory). Instead runGitUpdate() should check
944         whether the current working directory is a Git SVN checkout on each invocation.
945
946         * Scripts/VCSUtils.pm: Export function isGitSVNDirectory so that it can be used from webkitdirs::runGitUpdate().
947         (isGitSVNDirectory): Extracted logic to determine whether a directory is a Git
948         SVN directory from isGitSVN().
949         (isGitSVN): Implemented in terms of isGitSVNDirectory().
950         * Scripts/webkitdirs.pm:
951         (runGitUpdate): Modified to use isGitSVNDirectory().
952
953 2015-06-18  Mark Lam  <mark.lam@apple.com>
954
955         Refactor CheckedArithmeticOperations.cpp to use templates instead of macros.
956         https://bugs.webkit.org/show_bug.cgi?id=146103
957
958         Reviewed by Anders Carlsson.
959
960         Presently, the tests in CheckedArithmeticOperations.cpp are all implemented as
961         part of a large macro.  This makes them harder to:
962
963         1. write: no editor help with indentations, have to add trailing '\'s,
964            inconvenient to add line breaks and comments.
965
966         2. read: no chroma coding / syntax highlighting.
967
968         3. debug: compile time errors are reported as being on the single line where
969            the macro is used.
970
971         Refactoring the tests to use C++ templates solves all these issues.
972
973         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
974         (TestWebKitAPI::CheckedArithmeticTester::run):
975         (TestWebKitAPI::AllowMixedSignednessTest::run):
976         (TestWebKitAPI::IgnoreMixedSignednessTest::run):
977         (TestWebKitAPI::CoerceLiteralToUnsigned::coerce):
978         (TestWebKitAPI::CoerceLiteralNop::coerce):
979
980 2015-06-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
981
982         [EFL][WK2] Use Web Browser cache model in MiniBrowser
983         https://bugs.webkit.org/show_bug.cgi?id=112273
984
985         Reviewed by Laszlo Gombos.
986
987         Set cache model to EWK_CACHE_MODEL_PRIMARY_WEBBROWSER in EFL's MiniBrowser
988         instead of leaving the default value (EWK_CACHE_MODEL_DOCUMENT_VIEWER).
989         This way we have a decent cache capacity and the page cache actually works.
990
991         * MiniBrowser/efl/main.c:
992         (elm_main):
993
994 2015-06-18  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
995
996         Remove redundant Chromium bug keyword
997         https://bugs.webkit.org/show_bug.cgi?id=146097
998
999         Reviewed by Csaba Osztrogonác.
1000
1001         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1002         (TestExpectationParser._parse_modifiers): Remove BUGCR for TestExpectations.
1003         (TestExpectationLine._format_line): Deleted.
1004
1005 2015-06-17  Daniel Bates  <dabates@apple.com>
1006
1007         Client may receive began editing callback for already focused text field
1008         https://bugs.webkit.org/show_bug.cgi?id=146074
1009         <rdar://problem/21293562>
1010
1011         Reviewed by Darin Adler.
1012
1013         Add a unit test to ensure that a client receives exactly one began editing
1014         callback when a text field is newly focused. In particular, dispatching
1015         a DOM focus event at an already focused text field does not dispatch a
1016         began editing callback to the client.
1017
1018         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
1019         (TestWebKitAPI::TEST_F):
1020
1021 2015-06-17  Hyungwook Lee  <hyungwook.lee@navercorp.com>
1022
1023         [Win]Implement layoutTestController.dispatchPendingLoadRequests. 
1024         https://bugs.webkit.org/show_bug.cgi?id=26481
1025
1026         Reviewed by Darin Adler.
1027
1028         Implement WebView::dispatchPendingLoadRequests() private API for test runner.
1029
1030         * DumpRenderTree/win/TestRunnerWin.cpp:
1031         (TestRunner::dispatchPendingLoadRequests):
1032         (TestRunner::overridePreference):
1033
1034 2015-06-17  Alex Christensen  <achristensen@webkit.org>
1035
1036         [Content Extensions] Fail to parse invalid arrays
1037         https://bugs.webkit.org/show_bug.cgi?id=146079
1038         rdar://problem/21422649
1039
1040         Reviewed by Benjamin Poulain.
1041
1042         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1043         (TestWebKitAPI::TEST_F):
1044         Correct and add parsing tests with invalid arrays.
1045
1046 2015-06-17  Matt Rajca  <mrajca@apple.com>
1047
1048         Unreviewed. Added myself as a committer.
1049
1050         * Scripts/webkitpy/common/config/contributors.json:
1051
1052 2015-06-17  Daniel Bates  <dabates@apple.com>
1053
1054         Export VCSUtils::gitTreeDirectory()
1055         <rdar://problem/21248901>
1056
1057         Rubber-stamped by Alexey Proskuryakov.
1058
1059         * Scripts/VCSUtils.pm:
1060
1061 2015-06-17  Tim Horton  <timothy_horton@apple.com>
1062
1063         Safari tabs still have shrunken content after coming out of fullscreen
1064         https://bugs.webkit.org/show_bug.cgi?id=146037
1065         <rdar://problem/21105960>
1066
1067         Reviewed by Simon Fraser and Darin Adler.
1068
1069         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1070         * TestWebKitAPI/Tests/WebKit2Cocoa/ShrinkToFit.mm: Added.
1071         (-[ShrinkToFitNavigationDelegate webView:didFinishNavigation:]):
1072         (TEST):
1073         Add a test that ensures that disabling scale-to-fit mode correctly updates
1074         the page's layout.
1075
1076 2015-06-17  Dan Bernstein  <mitz@apple.com>
1077
1078         [Cocoa] Expose UIDelegate::UIClient::close via WKUIDelegate
1079         https://bugs.webkit.org/show_bug.cgi?id=145957
1080
1081         Reviewed by Darin Adler.
1082
1083         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
1084         (-[OpenAndCloseWindowUIDelegate webViewDidClose:]): Renamed from -_webViewClose:.
1085
1086 2015-06-15  Chris Fleizach  <cfleizach@apple.com>
1087
1088         AX:  iOS accessibility tests are not running because we need WKTR support
1089         https://bugs.webkit.org/show_bug.cgi?id=145991
1090
1091         Reviewed by Daniel Bates.
1092
1093         Add support for WKTR iOS accessibility.
1094         Utilize the notification handling mechanisms that Mac already uses.
1095         Rename iphone* DRT methods to either use existing methods that are similar, or rename to more generic names.
1096
1097         * DumpRenderTree/AccessibilityUIElement.cpp:
1098         (stringForSelectionCallback):
1099         (getIdentifierCallback):
1100         (getTraitsCallback):
1101         (getElementTextPositionCallback):
1102         (getElementTextLengthCallback):
1103         (AccessibilityUIElement::getJSClass):
1104         (getIPhoneLabelCallback): Deleted.
1105         (getIPhoneHintCallback): Deleted.
1106         (getIPhoneValueCallback): Deleted.
1107         (getIPhoneIdentifierCallback): Deleted.
1108         (getIPhoneTraitsCallback): Deleted.
1109         (getIPhoneIsElementCallback): Deleted.
1110         (getIPhoneElementTextPositionCallback): Deleted.
1111         (getIPhoneElementTextLengthCallback): Deleted.
1112         * DumpRenderTree/AccessibilityUIElement.h:
1113         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1114         (AccessibilityUIElement::identifier):
1115         (AccessibilityUIElement::traits):
1116         (AccessibilityUIElement::elementTextPosition):
1117         (AccessibilityUIElement::elementTextLength):
1118         (AccessibilityUIElement::description):
1119         (AccessibilityUIElement::orientation):
1120         (AccessibilityUIElement::stringValue):
1121         (AccessibilityUIElement::language):
1122         (AccessibilityUIElement::helpText):
1123         (AccessibilityUIElement::intValue):
1124         (AccessibilityUIElement::isSelected):
1125         (AccessibilityUIElement::isExpanded):
1126         (AccessibilityUIElement::documentURI):
1127         (AccessibilityUIElement::addNotificationListener):
1128         (AccessibilityUIElement::removeNotificationListener):
1129         (AccessibilityUIElement::isFocusable):
1130         (AccessibilityUIElement::isIgnored):
1131         (AccessibilityUIElement::hasPopup):
1132         (AccessibilityUIElement::iphoneLabel): Deleted.
1133         (AccessibilityUIElement::iphoneHint): Deleted.
1134         (AccessibilityUIElement::iphoneValue): Deleted.
1135         (AccessibilityUIElement::iphoneIdentifier): Deleted.
1136         (AccessibilityUIElement::iphoneTraits): Deleted.
1137         (AccessibilityUIElement::iphoneIsElement): Deleted.
1138         (AccessibilityUIElement::iphoneElementTextPosition): Deleted.
1139         (AccessibilityUIElement::iphoneElementTextLength): Deleted.
1140         (_accessibilityNotificationCallback): Deleted.
1141         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1142         (WTR::AccessibilityUIElement::isValid):
1143         (WTR::AccessibilityUIElement::identifier):
1144         (WTR::AccessibilityUIElement::traits):
1145         (WTR::AccessibilityUIElement::elementTextPosition):
1146         (WTR::AccessibilityUIElement::elementTextLength):
1147         (WTR::AccessibilityUIElement::stringForSelection):
1148         (WTR::AccessibilityUIElement::elementsForRange):
1149         (WTR::AccessibilityUIElement::increaseTextSelection):
1150         (WTR::AccessibilityUIElement::decreaseTextSelection):
1151         (WTR::AccessibilityUIElement::linkedElement):
1152         (WTR::AccessibilityUIElement::headerElementAtIndex):
1153         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
1154         (WTR::AccessibilityUIElement::characterAtOffset):
1155         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1156         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1157         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
1158         (WTR::findAccessibleObjectById):
1159         (WTR::AccessibilityController::accessibleElementById):
1160         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1161         (+[NSString stringWithJSStringRef:]):
1162         (-[NSString createJSStringRef]):
1163         (WTR::convertNSArrayToVector):
1164         (WTR::concatenateAttributeAndValue):
1165         (WTR::AccessibilityUIElement::AccessibilityUIElement):
1166         (WTR::AccessibilityUIElement::isEqual):
1167         (WTR::AccessibilityUIElement::headerElementAtIndex):
1168         (WTR::AccessibilityUIElement::linkedElement):
1169         (WTR::AccessibilityUIElement::getLinkedUIElements):
1170         (WTR::AccessibilityUIElement::elementAtPoint):
1171         (WTR::convertElementsToObjectArray):
1172         (WTR::AccessibilityUIElement::elementsForRange):
1173         (WTR::AccessibilityUIElement::indexOfChild):
1174         (WTR::AccessibilityUIElement::stringAttributeValue):
1175         (WTR::AccessibilityUIElement::description):
1176         (WTR::AccessibilityUIElement::orientation):
1177         (WTR::AccessibilityUIElement::stringValue):
1178         (WTR::AccessibilityUIElement::language):
1179         (WTR::AccessibilityUIElement::helpText):
1180         (WTR::AccessibilityUIElement::x):
1181         (WTR::AccessibilityUIElement::clickPointX):
1182         (WTR::AccessibilityUIElement::clickPointY):
1183         (WTR::AccessibilityUIElement::intValue):
1184         (WTR::AccessibilityUIElement::minValue):
1185         (WTR::AccessibilityUIElement::maxValue):
1186         (WTR::AccessibilityUIElement::valueDescription):
1187         (WTR::AccessibilityUIElement::isSelected):
1188         (WTR::AccessibilityUIElement::isSelectedOptionActive):
1189         (WTR::AccessibilityUIElement::stringForRange):
1190         (WTR::AccessibilityUIElement::attributedStringForRange):
1191         (WTR::AccessibilityUIElement::attributesOfHeader):
1192         (WTR::AccessibilityUIElement::traits):
1193         (WTR::AccessibilityUIElement::identifier):
1194         (WTR::AccessibilityUIElement::rowCount):
1195         (WTR::AccessibilityUIElement::rowIndexRange):
1196         (WTR::AccessibilityUIElement::columnIndexRange):
1197         (WTR::AccessibilityUIElement::cellForColumnAndRow):
1198         (WTR::AccessibilityUIElement::horizontalScrollbar):
1199         (WTR::AccessibilityUIElement::documentURI):
1200         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
1201         (WTR::AccessibilityUIElement::increaseTextSelection):
1202         (WTR::AccessibilityUIElement::decreaseTextSelection):
1203         (WTR::AccessibilityUIElement::stringForSelection):
1204         (WTR::AccessibilityUIElement::elementTextPosition):
1205         (WTR::AccessibilityUIElement::elementTextLength):
1206         (WTR::AccessibilityUIElement::url):
1207         (WTR::AccessibilityUIElement::addNotificationListener):
1208         (WTR::AccessibilityUIElement::removeNotificationListener):
1209         (WTR::AccessibilityUIElement::isFocusable):
1210         (WTR::AccessibilityUIElement::isIgnored):
1211         (WTR::AccessibilityUIElement::hasPopup):
1212         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
1213         (WTR::_CGPathEnumerationIteration):
1214         (WTR::AccessibilityUIElement::pathDescription):
1215         (WTR::AccessibilityUIElement::supportedActions):
1216
1217 2015-06-16  Mark Lam  <mark.lam@apple.com>
1218
1219         Use NakedPtr<Exception>& to return exception results.
1220         https://bugs.webkit.org/show_bug.cgi?id=145870
1221
1222         Reviewed by Anders Carlsson and Filip Pizlo.
1223
1224         * TestWebKitAPI/CMakeLists.txt:
1225         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1226         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1227         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1228         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp: Added.
1229         (TestWebKitAPI::TEST):
1230         (TestWebKitAPI::nakedPtrFoo):
1231
1232 2015-06-16  Tobias Reiss  <tobi+webkit@basecode.de>
1233
1234         Unreviewed. Adding myself as a committer.
1235
1236         * Scripts/webkitpy/common/config/contributors.json:
1237
1238 2015-06-15  Alexey Proskuryakov  <ap@apple.com>
1239
1240         Add test expectations for El Capitan
1241         https://bugs.webkit.org/show_bug.cgi?id=146005
1242
1243         Rubber-stamped by Dan Bernstein.
1244
1245         Add appropriate tools code.
1246
1247         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan.png: Added.
1248         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan@2x.png: Added.
1249         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1250         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1251         Added dashboard support.
1252
1253         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1254         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1255         Trigger the right build queues on check-in.
1256
1257         * Scripts/webkitpy/common/system/platforminfo.py:
1258         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
1259         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1260         * Scripts/webkitpy/port/mac.py:
1261         * Scripts/webkitpy/port/mac_unittest.py:
1262         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1263         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1264         Added cases for El Capitan, and updated tests for new baseline search paths.
1265
1266 2015-06-15  Alex Christensen  <achristensen@webkit.org>
1267
1268         [Content Extensions] Make max NFA size and max rule count user defaults.
1269         https://bugs.webkit.org/show_bug.cgi?id=145663
1270
1271         Reviewed by Benjamin Poulain.
1272
1273         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1274         (TestWebKitAPI::TEST_F):
1275
1276 2015-06-12  Alexey Proskuryakov  <ap@apple.com>
1277
1278         -[WKWebView evaluateJavaScript] provides a misleading error when the return cannot be serialized
1279         https://bugs.webkit.org/show_bug.cgi?id=145900
1280
1281         Reviewed by Sam Weinig.
1282
1283         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
1284         (TEST): Added tests.
1285
1286 2015-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1287
1288         [SOUP] Custom URI schemes don't work for requests containing a fragment identifier
1289         https://bugs.webkit.org/show_bug.cgi?id=145969
1290
1291         Reviewed by Sergio Villar Senin.
1292
1293         Add a test case to the custom URI schemes unit test.
1294
1295         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1296         (testWebContextURIScheme):
1297
1298 2015-06-15  Csaba Osztrogonác  <ossy@webkit.org>
1299
1300         [GTK] Fix deprecated-register warning in the generated WebKitMarshal.cpp
1301         https://bugs.webkit.org/show_bug.cgi?id=145922
1302
1303         Reviewed by Carlos Garcia Campos.
1304
1305         * gtk/jhbuild.modules:
1306         * gtk/patches/glib-warning-fix.patch: Added.
1307
1308 2015-06-12  Alexey Proskuryakov  <ap@apple.com>
1309
1310         Update springLoadingHighlight type
1311         https://bugs.webkit.org/show_bug.cgi?id=145939
1312         rdar://problem/20880213
1313
1314         Reviewed by Darin Adler.
1315
1316         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
1317         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1318         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
1319         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
1320
1321 2015-06-12  Dewei Zhu  <dewei_zhu@apple.com>
1322
1323         Move cursor to (10, 0) instead of (0, 0) and polish the mouse move code
1324         https://bugs.webkit.org/show_bug.cgi?id=145945
1325
1326         Reviewed by Stephanie Lewis.
1327
1328         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1329         (OSXBrowserDriver.prepareEnv):
1330         (OSXBrowserDriver.moveCursor): Deleted.
1331         (OSXBrowserDriver): Deleted.
1332         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1333         (OSXSafariDriver.prepareEnv):
1334
1335 2015-06-12  Brent Fulgham  <bfulgham@apple.com>
1336
1337         Revise update-webkit-dependency to use LWP::UserAgent instead of LWP::Simple for better handling of https
1338         https://bugs.webkit.org/show_bug.cgi?id=145938
1339
1340         Reviewed by Alexey Proskuryakov.
1341
1342         * Scripts/update-webkit-dependency: Switch from LWP::Simple to
1343         LWP::UserAgent to get access to more robust HTTPS support.
1344
1345 2015-06-12  Csaba Osztrogonác  <ossy@webkit.org>
1346
1347         [GTK] Fix return type warning in WebViewTest.cpp
1348         https://bugs.webkit.org/show_bug.cgi?id=145914
1349
1350         Reviewed by Darin Adler.
1351
1352         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1353         (WebViewTest::isEditable):
1354
1355 2015-06-12  Zan Dobersek  <zdobersek@igalia.com>
1356
1357         [GLib] Move files under Source/WTF/wtf/gobject to Source/WTF/wtf/glib
1358         https://bugs.webkit.org/show_bug.cgi?id=145799
1359
1360         Reviewed by Carlos Garcia Campos.
1361
1362         Update header inclusions for headers that have been moved
1363         to Source/WTF/wtf/glib/.
1364
1365         Also move the unit tests under TestWebKitAPI/Tests/WTF/gobject/
1366         to TestWebKitAPI/Tests/WTF/glib/ and update the build rules.
1367
1368         * TestWebKitAPI/PlatformGTK.cmake:
1369         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp.
1370         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
1371         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
1372         (TestWebKitAPI::GMainLoopSourceTest::runLoop):
1373         (TestWebKitAPI::GMainLoopSourceTest::delayedFinish):
1374         (TestWebKitAPI::GMainLoopSourceTest::finish):
1375         (TestWebKitAPI::GMainLoopSourceTest::source):
1376         (TestWebKitAPI::basicRescheduling):
1377         (TestWebKitAPI::TEST):
1378         (TestWebKitAPI::reentrantRescheduling):
1379         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch):
1380         (TestWebKitAPI::basicDestroyCallbacks):
1381         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch):
1382         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch):
1383         * TestWebKitAPI/Tests/WTF/glib/GUniquePtr.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp.
1384         (log):
1385         (takeLogStr):
1386         (TestWebKitAPI::TEST):
1387         (TestWebKitAPI::returnOutChar):
1388         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
1389         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
1390         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest): Deleted.
1391         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest): Deleted.
1392         (TestWebKitAPI::GMainLoopSourceTest::runLoop): Deleted.
1393         (TestWebKitAPI::GMainLoopSourceTest::delayedFinish): Deleted.
1394         (TestWebKitAPI::GMainLoopSourceTest::finish): Deleted.
1395         (TestWebKitAPI::GMainLoopSourceTest::source): Deleted.
1396         (TestWebKitAPI::basicRescheduling): Deleted.
1397         (TestWebKitAPI::TEST): Deleted.
1398         (TestWebKitAPI::reentrantRescheduling): Deleted.
1399         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch): Deleted.
1400         (TestWebKitAPI::basicDestroyCallbacks): Deleted.
1401         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch): Deleted.
1402         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch): Deleted.
1403         * TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp:
1404         (log): Deleted.
1405         (takeLogStr): Deleted.
1406         (TestWebKitAPI::TEST): Deleted.
1407         (TestWebKitAPI::returnOutChar): Deleted.
1408         * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp:
1409         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
1410         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
1411         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
1412         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
1413         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
1414         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1415         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp:
1416         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
1417         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
1418         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1419         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1420         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
1421         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp:
1422         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
1423         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp:
1424         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp:
1425         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1426         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
1427         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1428         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1429         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
1430         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1431         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
1432         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
1433         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
1434         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
1435         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1436         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp:
1437         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.h:
1438         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
1439         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h:
1440         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1441         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1442         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1443         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1444         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h:
1445         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1446         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1447         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1448         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1449         * WebKitTestRunner/PlatformGTK.cmake:
1450         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1451         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1452
1453 2015-06-12  Csaba Osztrogonác  <ossy@webkit.org>
1454
1455         [EFL] Fix deprecated declarations warnings related to WK2 versioned structs
1456         https://bugs.webkit.org/show_bug.cgi?id=145913
1457
1458         Reviewed by Gyuyoung Kim.
1459
1460         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1461         (TestWebKitAPI::setupGeolocationProvider):
1462         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
1463         (TestWebKitAPI::setPageLoaderClient):
1464         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp:
1465         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
1466         * WebKitTestRunner/GeolocationProviderMock.cpp:
1467         (WTR::GeolocationProviderMock::GeolocationProviderMock):
1468         * WebKitTestRunner/WebNotificationProvider.cpp:
1469         (WTR::WebNotificationProvider::provider):
1470
1471 2015-06-12  Csaba Osztrogonác  <ossy@webkit.org>
1472
1473         Fix the libusrsctp build with clang
1474         https://bugs.webkit.org/show_bug.cgi?id=145128
1475
1476         Reviewed by Gyuyoung Kim.
1477
1478         * efl/jhbuild.modules:
1479         * gtk/jhbuild.modules:
1480
1481 2015-06-11  Mark Lam  <mark.lam@apple.com>
1482
1483         WebCore::reportException() needs to be able to accept a raw thrown value in addition to Exception objects.
1484         https://bugs.webkit.org/show_bug.cgi?id=145872
1485
1486         Reviewed by Michael Saboff.
1487
1488         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:
1489         (-[DidCreateJavaScriptContextFrameLoadDelegate webView:didCreateJavaScriptContext:forFrame:]):
1490         - Exercises the JSC ObjC API to call a function which throws an exception.  That
1491           exception will be returned as a JSValue instead of an Exception object.  We
1492           will use this JSValue to test WebCore::reportException() to confirm that it is
1493           able to handle an exception value which is not an Exception object.
1494
1495 2015-06-11  Dewei Zhu  <dewei_zhu@apple.com>
1496
1497         Move cursor to corner and fix safari window size before running benchmark
1498         https://bugs.webkit.org/show_bug.cgi?id=145858
1499
1500         Reviewed by Ryosuke Niwa
1501
1502         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1503         (OSXBrowserDriver.prepareEnv):
1504         (OSXBrowserDriver):
1505         (OSXBrowserDriver.moveCursor):
1506         (OSXBrowserDriver.getScreenSize):
1507         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1508         (OSXChromeDriver.launchUrl):
1509         (OSXChromeCanaryDriver.launchUrl):
1510         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1511         (OSXFirefoxDriver.launchUrl):
1512         (OSXFirefoxNightlyDriver.launchUrl):
1513         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1514         (OSXSafariDriver.prepareEnv):
1515         (OSXSafariDriver):
1516         (OSXSafariDriver.maximizeWindow):
1517
1518 2015-06-11  Daniel Bates  <dabates@apple.com>
1519
1520         [iOS] Cannot run run-webkit-tests with public SDK; LayoutTestRelay fails to build
1521         https://bugs.webkit.org/show_bug.cgi?id=145319
1522
1523         Reviewed by David Kilzer.
1524
1525         Add SPI wrapper header for CoreSimulator and update the source files to reference
1526         it instead of directly referencing the CoreSimulator header.
1527
1528         * LayoutTestRelay/LayoutTestRelay.xcodeproj/project.pbxproj:
1529         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h: Added.
1530         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1531         * LayoutTestRelay/LayoutTestRelay/main.m:
1532
1533 2015-06-10  KwangHyuk Kim  <hyuki.kim@samsung.com>
1534
1535         [EFL] dimmed area for popup does not cover the fullscreen mode.
1536         https://bugs.webkit.org/show_bug.cgi?id=145133
1537
1538         Reviewed by Gyuyoung Kim.
1539
1540         By calling elm_win_resize_object_add(), popup was added as a resize object of elm_win.
1541         as a result, popup can cover the fullscreen area when it enters a fullscreen mode.
1542
1543         * MiniBrowser/efl/main.c:
1544         (on_fullscreen_accept):
1545         (on_fullscreen_deny):
1546         (on_fullscreen_enter):
1547
1548 2015-06-10  Commit Queue  <commit-queue@webkit.org>
1549
1550         Unreviewed, rolling out r185442.
1551         https://bugs.webkit.org/show_bug.cgi?id=145871
1552
1553         seems to have broken WTF.StringOperators test (Requested by
1554         alexchristensen on #webkit).
1555
1556         Reverted changeset:
1557
1558         "[Content Extensions] Limit number of rules."
1559         https://bugs.webkit.org/show_bug.cgi?id=145663
1560         http://trac.webkit.org/changeset/185442
1561
1562 2015-06-10  Alex Christensen  <achristensen@webkit.org>
1563
1564         [Content Extensions] Make max NFA size and max rule count user defaults.
1565         https://bugs.webkit.org/show_bug.cgi?id=145663
1566         rdar://problem/21242407
1567
1568         Reviewed by Benjamin Poulain.
1569
1570         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1571         (TestWebKitAPI::TEST_F):
1572
1573 2015-06-10  Hyungwook Lee  <hyungwook.lee@navercorp.com>
1574
1575         [EFL] Execute Javascript method in mini browser address bar.
1576         https://bugs.webkit.org/show_bug.cgi?id=145725
1577
1578         Reviewed by Gyuyoung Kim.
1579
1580         Support 'javascript:' scheme in WebKit EFL Mini Browser.
1581
1582         * MiniBrowser/efl/main.c:
1583         (url_from_user_input):
1584         (url_load_from_user_input):
1585         (on_url_bar_activated):
1586         (elm_main):
1587
1588 2015-06-09  Hyungwook Lee  <hyungwook.lee@navercorp.com>
1589
1590         Implement dumpProgressFinishedCallback() for Win layoutTestController.
1591         https://bugs.webkit.org/show_bug.cgi?id=66773
1592
1593         Reviewed by Darin Adler.
1594
1595         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1596         * DumpRenderTree/win/FrameLoadDelegate.h:
1597
1598 2015-06-09  Ryosuke Niwa  <rniwa@webkit.org>
1599
1600         run-benchmark should either checkout JetStream 1.0.1 or support running the latest version
1601         https://bugs.webkit.org/show_bug.cgi?id=145764
1602
1603         Reviewed by Darin Adler.
1604
1605         Added the support for checkout a subversion directory in run-benchmark and used in the plans for
1606         JetStream and SunSpider.
1607
1608         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
1609         (GenericBenchmarkBuilder):
1610         (GenericBenchmarkBuilder.prepare): Instead of taking each argument from benchmark plan, just accept
1611         the whole JSON as the input.
1612         (GenericBenchmarkBuilder._checkoutWithSubverion): Added.
1613         (GenericBenchmarkBuilder._applyPatch): Check the existence of benchmark_patch in prepare() instead.
1614         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1615         (BenchmarkRunner.execute): Removed the check for having either 'local_copy' or 'remote_archive' in
1616         a benchmark plan now that it's checkedi in GenericBenchmarkBuilder.prepare.
1617         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
1618         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
1619
1620 2015-06-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1621
1622         Remove ewstool scripts used by chromium port
1623         https://bugs.webkit.org/show_bug.cgi?id=145789
1624
1625         Reviewed by Csaba Osztrogonác.
1626
1627         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh: Removed.
1628         * EWSTools/GoogleComputeEngine/build-commit-queue.sh: Removed.
1629         * EWSTools/GoogleComputeEngine/build-cr-linux-debug-ews.sh: Removed.
1630         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh: Removed.
1631         * EWSTools/GoogleComputeEngine/findzone.sh: Removed.
1632
1633 2015-06-09  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
1634
1635         Unreviewed, updated my list of email addresses.
1636
1637         * Scripts/webkitpy/common/config/contributors.json:
1638
1639 2015-06-09  Csaba Osztrogonác  <ossy@webkit.org>
1640
1641         [cmake] Fix the style issues in cmake project files
1642         https://bugs.webkit.org/show_bug.cgi?id=145755
1643
1644         Reviewed by Darin Adler.
1645
1646         * TestWebKitAPI/CMakeLists.txt:
1647         * TestWebKitAPI/PlatformEfl.cmake:
1648
1649 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
1650
1651         Fix a typo in r185345.
1652
1653         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1654         (OSXSafariDriver.closeBrowsers):
1655
1656 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
1657
1658         Yet another unreviewed build fix :(
1659
1660         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1661         (OSXSafariDriver):
1662         (OSXSafariDriver.launchUrl):
1663         (OSXSafariDriver.closeBrowsers):
1664
1665 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
1666
1667         Unreviewed build fix. Initialize result in the case things blow up below.
1668
1669         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1670         (BenchmarkRunner.execute):
1671
1672 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
1673
1674         Partially revert and fix after r185243.
1675
1676         * Scripts/benchmark_runner/benchmark_runner.py:
1677         * Scripts/run-benchmark:
1678
1679 2015-06-08  Daniel Bates  <dabates@apple.com>
1680
1681         Many LayoutTests/http tests time out in DumpRenderTree
1682         https://bugs.webkit.org/show_bug.cgi?id=145770
1683         <rdar://problem/19593910>
1684
1685         Reviewed by Alexey Proskuryakov.
1686
1687         * DumpRenderTree/ios/Info.plist: Add ATS key.
1688         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1689         (-[LTRelayController _environmentVariables]): Copy environment variables LOCAL_RESOURCE_ROOT
1690         and DUMPRENDERTREE_TEMP to the simulator environment to avoid assertion failures in tests
1691         that make use of testRunner.pathToLocalResource().
1692
1693 2015-06-08  Csaba Osztrogonác  <ossy@webkit.org>
1694
1695         [GTK] Fix parentheses warning in TestWebKitWebView.cpp
1696         https://bugs.webkit.org/show_bug.cgi?id=145759
1697
1698         Reviewed by Carlos Garcia Campos.
1699
1700         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1701         (testWebViewSave):
1702
1703 2015-06-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1704
1705         [GTK] Add editor mode to MiniBrowser
1706         https://bugs.webkit.org/show_bug.cgi?id=145595
1707
1708         Reviewed by Sergio Villar Senin.
1709
1710         It loads an empty editable web view with an edit toolbar. It makes
1711         easier to test the editor, editing commands and input methods.
1712
1713         * MiniBrowser/gtk/BrowserWindow.c:
1714         (editingCommandCallback):
1715         (browserWindowSetupEditorToolbar):
1716         (browserWindowConstructed):
1717         * MiniBrowser/gtk/main.c:
1718         (createBrowserWindow):
1719
1720 2015-06-05  Zalan Bujtas  <zalan@apple.com>
1721
1722         From r185273 on WTF::RefCounter exposes the actual refcount instead of a boolean value.
1723
1724         Reviewed by Dan Bernstein.
1725
1726         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
1727         (TestWebKitAPI::TEST):
1728
1729 2015-06-05  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1730
1731         [EFL] API test has been broken since r184357
1732         https://bugs.webkit.org/show_bug.cgi?id=145635
1733
1734         Reviewed by Darin Adler.
1735
1736         r184357 suppress cmake build warning using TARGET_FILE property. However
1737         many EFL API test cases have been broken after applying it.
1738
1739         * TestWebKitAPI/CMakeLists.txt:
1740
1741 2015-06-05  Anders Carlsson  <andersca@apple.com>
1742
1743         Make the network cache directory part of WKContextConfigurationRef
1744         https://bugs.webkit.org/show_bug.cgi?id=145711
1745
1746         Reviewed by Antti Koivisto.
1747
1748         * WebKitTestRunner/TestController.cpp:
1749         (WTR::TestController::initialize):
1750
1751 2015-06-05  Anders Carlsson  <andersca@apple.com>
1752
1753         Make the application cache directory part of WKContextConfigurationRef
1754         https://bugs.webkit.org/show_bug.cgi?id=145704
1755
1756         Reviewed by Geoffrey Garen.
1757
1758         * WebKitTestRunner/TestController.cpp:
1759         (WTR::TestController::initialize):
1760
1761 2015-06-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1762
1763         check-webkit-style should recommend using nullptr instead of recommending using 0 for the null pointer in C++ code.
1764         https://bugs.webkit.org/show_bug.cgi?id=145680
1765
1766         Reviewed by Brent Fulgham.
1767
1768         * Scripts/webkitpy/style/checkers/cpp.py:
1769         (check_for_null):
1770         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1771         (WebKitStyleTest.test_null_false_zero):
1772
1773 2015-06-05  Stephanie Lewis  <slewis@apple.com>
1774
1775         Make the web server more robust to timing issues..
1776
1777         Reviewed by Ryosuke Niwa.
1778
1779         Cleaned up exception handling.
1780         Test server is actually serving pages before returning.
1781         Clean up some style issues.
1782
1783         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
1784         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
1785         (SimpleHTTPServerDriver.__init__):
1786         (SimpleHTTPServerDriver.serve): check output, wait for pages to serve
1787         (SimpleHTTPServerDriver.baseUrl): 
1788         (SimpleHTTPServerDriver.fetchResult):
1789         (SimpleHTTPServerDriver.killServer):
1790         (SimpleHTTPServerDriver.getReturnCode):
1791
1792 2015-06-05  Stephanie Lewis  <slewis@apple.com>
1793
1794
1795         Add errors to run-benchmark exception handling.
1796
1797         Reviewed by Ryosuke Niwa.
1798
1799         * Scripts/run-benchmark:
1800         (main):
1801         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
1802         (GenericBenchmarkBuilder.prepare):
1803         (GenericBenchmarkBuilder._runCreateScript):
1804         (GenericBenchmarkBuilder._applyPatch):
1805         (GenericBenchmarkBuilder.clean):
1806         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1807         (BenchmarkRunner.__init__):
1808         (BenchmarkRunner.execute):
1809         (BenchmarkRunner):
1810         (BenchmarkRunner.cleanup):
1811         * Scripts/webkitpy/benchmark_runner/generic_factory.py:
1812         (GenericFactory.iterateGetItem):
1813         (GenericFactory.create):
1814         * Scripts/webkitpy/benchmark_runner/utils.py:
1815         (loadModule):
1816         (loadJSONFromFile):
1817         (forceRemove):
1818
1819 2015-06-05  Stephanie Lewis  <slewis@apple.com>
1820
1821         Streamline run-benchmark browser
1822
1823         Reviewed by Ryosuke Niwa.
1824
1825         Add Caffeinate so computer won't sleep while running.
1826         Remove calls to collect output since we were just dumping to stdout anyway.
1827         Add xpc dyld_path.
1828         Default to system safari.
1829
1830         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1831         (OSXBrowserDriver.launchProcess):
1832         (OSXBrowserDriver.terminateProcesses):
1833         (OSXBrowserDriver):
1834         (OSXBrowserDriver.launchCaffeinateForProcess):
1835         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1836         (OSXSafariDriver.launchUrl):
1837         (OSXSafariDriver.closeBrowsers):
1838
1839 2015-06-04  Benjamin Poulain  <bpoulain@apple.com>
1840
1841         Combine tiny DFAs into slightly larger ones
1842         https://bugs.webkit.org/show_bug.cgi?id=145572
1843
1844         Reviewed by Alex Christensen.
1845
1846         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1847         * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp: Added.
1848         (TestWebKitAPI::DFACombinerTest::SetUp):
1849         (TestWebKitAPI::combine):
1850         (TestWebKitAPI::TEST_F):
1851         * TestWebKitAPI/Tests/WebCore/DFAHelpers.h: Copied from Source/WebCore/contentextensions/DFA.h.
1852         (TestWebKitAPI::countLiveNodes):
1853         (TestWebKitAPI::createNFAs):
1854         (TestWebKitAPI::buildDFAFromPatterns):
1855         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
1856         (TestWebKitAPI::countLiveNodes): Deleted.
1857         (TestWebKitAPI::createNFAs): Deleted.
1858         (TestWebKitAPI::buildDFAFromPatterns): Deleted.
1859
1860 2015-06-04  Alexey Proskuryakov  <ap@apple.com>
1861
1862         WebKitTestRunner leaks strings in generateWhitelist()
1863         https://bugs.webkit.org/show_bug.cgi?id=145665
1864
1865         Reviewed by Myles C. Maxfield.
1866
1867         * WebKitTestRunner/mac/TestControllerMac.mm:
1868         (WTR::generateWhitelist):
1869
1870 2015-06-03  Yusuke Suzuki  <utatane.tea@gmail.com>
1871
1872         Fix options in build-jsc for CMake builds
1873         https://bugs.webkit.org/show_bug.cgi?id=145636
1874
1875         Reviewed by Gyuyoung Kim.
1876
1877         CMake only accepts -DXXX=YYY style options.
1878         And ensured that ENABLE_JIT=OFF when specifying `--cloop`.
1879
1880         * Scripts/build-jsc:
1881
1882 2015-06-03  Matthew Daiter  <mdaiter@apple.com>
1883
1884         Added a patch so that the colors displayed on the page could be toggled
1885         in case people need accessibility colors displayed in their browser.
1886         https://bugs.webkit.org/show_bug.cgi?id=145570
1887         <rdar://problem/20994468>
1888
1889         Added in CSS colors and toggle buttons for checkmarks in the page, so that
1890         the page could be rendered in a specific way for accessibility needs if needed.
1891
1892         Reviewed by Alexey Proskuryakov.
1893
1894         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1895         (updateHiddenPlatforms):
1896         (applyAccessibilityColorSetting): Initial loading of accessibility colors if necessary
1897         (toggleAccessibilityColors): Toggle colors on and off
1898         (documentReady): Needed to make changes to the initialization
1899         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1900         (a:hover):
1901         (div.cellButton, div.accessibilityButton): Added in similar properties for cellButton and accessibilityButton
1902         (div.cellButton.hide, div.accessibilityButton.hide):
1903         (div.cellButton.unhide, div.accessibilityButton.unhide):
1904         (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide):
1905         (.popover-tracking:hover):
1906         (.accessibilityButton):
1907         (div.cellButton): Deleted.
1908         (div.cellButton.hide): Deleted.
1909         (div.cellButton.unhide): Deleted.
1910         (.settings-visible div.cellButton.hide, .settings-visible div.cellButton.unhide): Deleted.
1911         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
1912         (.status-line.neutral .bubble):
1913         (.status-line.unauthorized .bubble):
1914         (.status-line.danger .bubble.pictogram):
1915         (.status-line.bad .bubble.pictogram):
1916         (.status-line.no-bubble .message):
1917         (.status-line.bad .bubble):
1918         (.status-line.good .bubble):
1919         (.status-line.good .message):
1920         (.status-line.bad .message):
1921         (body.accessibility-colors .status-line.good .bubble):
1922         (body.accessibility-colors .status-line.bad .bubble):
1923         (body.accessibility-colors .status-line.good .message):
1924         (body.accessibility-colors .status-line.bad .message):
1925         (.status-line.danger .message):
1926         (.status-line.unauthorized .message):
1927
1928 2015-06-03  Ryosuke Niwa  <rniwa@webkit.org>
1929
1930         Unreviewed build fix for Dromaeo.
1931
1932         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
1933         (BenchmarkResults._aggregate_results_for_test):
1934
1935 2015-06-03  Anders Carlsson  <andersca@apple.com>
1936
1937         Fix build.
1938
1939         * DumpRenderTree/mac/TestRunnerMac.mm:
1940
1941 2015-06-03  Daniel Bates  <dabates@apple.com>
1942
1943         WebKit2.TextFieldDidBeginAndEndEditing is flaky on Mac
1944         https://bugs.webkit.org/show_bug.cgi?id=145616
1945
1946         Skip the test on Mac for now to avoid having the bots turn red due to the flakiness
1947         of the test. Further investigation is needed.
1948
1949         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
1950         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp:
1951
1952 2015-06-03  Brady Eidson  <beidson@apple.com>
1953
1954         REGRESSION (r183498): Certain types of frame loads in iframes with <base target="_blank"> can open urls in new window/tabs
1955         https://bugs.webkit.org/show_bug.cgi?id=145580
1956
1957         Reviewed by Mark Lam.
1958
1959         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1960         (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame): Implement the dump for "didChangeLocationWithinPageForFrame"
1961
1962 2015-06-03  Alexey Proskuryakov  <ap@apple.com>
1963
1964         Attempt to fix CSSPropertyParserTest.GridTrackLimits API test after http://trac.webkit.org/r185147
1965
1966         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
1967         (TestWebKitAPI::TEST): Update the syntax.
1968
1969 2015-06-02  Mark Lam  <mark.lam@apple.com>
1970
1971         build-jsc's --cloop option is broken.
1972         https://bugs.webkit.org/show_bug.cgi?id=145516
1973
1974         Reviewed by Darin Adler.
1975
1976         * Scripts/build-jsc:
1977         - Make sure to disable the JIT when --cloop is specified.
1978           Did analogous fix for --ftljit.
1979
1980 2015-06-02  Daniel Bates  <dabates@apple.com>
1981
1982         Update ATS keys used in MiniBrowser and WebKitTestRunnerApp
1983
1984         Rubber-stamped by Alexey Proskuryakov.
1985
1986         * MiniBrowser/mac/Info.plist:
1987         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
1988
1989 2015-06-01  Commit Queue  <commit-queue@webkit.org>
1990
1991         Unreviewed, rolling out r185066.
1992         https://bugs.webkit.org/show_bug.cgi?id=145543
1993
1994         it breaks the FTL JIT builds with a local checkout of llvm
1995         (Requested by pizlo on #webkit).
1996
1997         Reverted changeset:
1998
1999         "build-jsc's --cloop option is broken."
2000         https://bugs.webkit.org/show_bug.cgi?id=145516
2001         http://trac.webkit.org/changeset/185066
2002
2003 2015-06-01  Daniel Bates  <dabates@apple.com>
2004
2005         Notify client that we began editing when text field is focused
2006         https://bugs.webkit.org/show_bug.cgi?id=145439
2007         <rdar://problem/21142108>
2008
2009         Reviewed by Anders Carlsson.
2010
2011         Add API test to ensure that we dispatch textFieldDid{Begin, End}Editing callbacks when
2012         a text field is focused and defocused.
2013
2014         * TestWebKitAPI/CMakeLists.txt:
2015         * TestWebKitAPI/PlatformEfl.cmake:
2016         * TestWebKitAPI/PlatformGTK.cmake:
2017         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2018         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp: Added.
2019         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::didReceiveMessageFromInjectedBundle):
2020         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::didFinishLoadForFrame):
2021         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::setInjectedBundleClient):
2022         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::setPageLoaderClient):
2023         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::nullJavaScriptCallback):
2024         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::executeJavaScriptAndCheckDidReceiveMessage):
2025         (TestWebKitAPI::TEST_F):
2026         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp: Added.
2027         (TestWebKitAPI::textFieldDidBeginEditing):
2028         (TestWebKitAPI::textFieldDidEndEditing):
2029         (TestWebKitAPI::TextFieldDidBeginAndEndEditingEventsTest::TextFieldDidBeginAndEndEditingEventsTest):
2030         (TestWebKitAPI::TextFieldDidBeginAndEndEditingEventsTest::didCreatePage):
2031         * TestWebKitAPI/Tests/WebKit2/input-focus-blur.html: Added.
2032
2033 2015-06-01  Alex Christensen  <achristensen@webkit.org>
2034
2035         [Content Extensions] resource-type and load-type should be independent.
2036         https://bugs.webkit.org/show_bug.cgi?id=145528
2037         rdar://problem/21190765
2038
2039         Reviewed by Benjamin Poulain.
2040
2041         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2042         (TestWebKitAPI::TEST_F):
2043
2044 2015-06-01  Daniel Bates  <dabates@apple.com>
2045
2046         Add ATS keys to WebKitTestRunnerApp
2047         https://bugs.webkit.org/show_bug.cgi?id=145519
2048
2049         Reviewed by Alexey Proskuryakov.
2050
2051         Add ATS keys for WebKitTestRunnerApp as we did for MiniBrowser in bug #145141.
2052
2053         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
2054
2055 2015-06-01  Brady Eidson  <beidson@apple.com>
2056
2057         Add WKTR support for "should open external URLs".
2058         https://bugs.webkit.org/show_bug.cgi?id=145505
2059
2060         Reviewed by Darin Adler.
2061
2062         - Add a new option to "queueLoad" to allow javascript to queue a load that has the
2063           "should open external URLs" bit set.
2064         
2065         - Add a new "dumpPolicyDelegateCallbacks" call to dump the NavigationAction in
2066           the policy delegate, including whether or not the bit was set.
2067         
2068         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2069         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2070         (WTR::TestRunner::queueLoad):
2071         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2072         (WTR::TestRunner::dumpPolicyDelegateCallbacks):
2073         (WTR::TestRunner::shouldDumpPolicyCallbacks):
2074         
2075         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2076         (WTR::InjectedBundle::queueLoad):
2077         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2078
2079         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2080         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
2081
2082         * WebKitTestRunner/TestInvocation.cpp:
2083         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2084
2085         * WebKitTestRunner/WorkQueueManager.cpp:
2086         (WTR::WorkQueueManager::queueLoad):
2087         * WebKitTestRunner/WorkQueueManager.h:
2088
2089 2015-06-01  Mark Lam  <mark.lam@apple.com>
2090
2091         build-jsc's --cloop option is broken.
2092         https://bugs.webkit.org/show_bug.cgi?id=145516
2093
2094         Reviewed by Darin Adler.
2095
2096         * Scripts/build-jsc:
2097         - Make sure to disable the JIT when --cloop is specified.
2098           Did analogous fix for --ftljit.
2099
2100 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
2101
2102         [CMake] check-webkit-style provides bogus explanation for alphabetical sorting error
2103         https://bugs.webkit.org/show_bug.cgi?id=144959
2104
2105         Reviewed by Darin Adler.
2106
2107         * Scripts/webkitpy/style/checkers/cmake.py:
2108         (CMakeChecker.check): Use enumerate instead of xrange.
2109         (CMakeChecker._check_list_order): Use enumerate instead of incrementing line_number manually.
2110         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
2111         (CMakeCheckerTest.test_check): Update the expected results.
2112
2113 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
2114
2115         Fix the webkitpy scm unittests after r174051
2116         https://bugs.webkit.org/show_bug.cgi?id=145511
2117
2118         Reviewed by Darin Adler.
2119
2120         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2121         (GitTestWithMock.make_scm):
2122
2123 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
2124
2125         EWS provides misleading information for not applyable patches
2126         https://bugs.webkit.org/show_bug.cgi?id=145307
2127
2128         Reviewed by Alexey Proskuryakov.
2129
2130         * Scripts/svn-apply: Die if there is no applyable diff in the patch.
2131
2132 2015-06-01  Alexey Proskuryakov  <ap@apple.com>
2133
2134         Further tweak results of WebKit1.StringTruncator after r184965.
2135
2136         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
2137
2138 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
2139
2140         [cmake] Suppress unused parameter warnings in WebKit2 and TestNetscapePlugIn
2141         https://bugs.webkit.org/show_bug.cgi?id=145264
2142
2143         Reviewed by Carlos Garcia Campos.
2144
2145         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Set extra compiler flags and suppress only unused parameter warnings.
2146
2147 2015-05-30  Ryosuke Niwa  <rniwa@webkit.org>
2148
2149         Unreviewed build fix after r185014. Some tests only have subtests and not metrics.
2150
2151         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
2152         (BenchmarkResults._lint_subtest_results):
2153         * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py:
2154         (test_aggregate_nested_results):
2155         (test_lint_results):
2156         * WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h:
2157
2158 2015-05-29  Ryosuke Niwa  <rniwa@webkit.org>
2159
2160         run-benchmark should print out the results
2161         https://bugs.webkit.org/show_bug.cgi?id=145398
2162
2163         Reviewed by Antti Koivisto.
2164
2165         Added BenchmarkResults to compute and format the aggregated values. It also does the syntax/semantic check
2166         of the output to catch early errors.
2167
2168         * Scripts/webkitpy/benchmark_runner/benchmark_results.py: Added.
2169         (BenchmarkResults): Added.
2170         (BenchmarkResults.__init__): Added.
2171         (BenchmarkResults.format): Added.
2172         (BenchmarkResults._format_tests): Added. Used by BenchmarkResults.format.
2173         (BenchmarkResults._format_values): Formats a list of values measured for a given metric on a given test.
2174         Uses the sample standard deviation to compute the significant figures for the value.
2175         (BenchmarkResults._unit_from_metric): Added.
2176         (BenchmarkResults._aggregate_results): Added.
2177         (BenchmarkResults._aggregate_results_for_test): Added.
2178         (BenchmarkResults._flatten_list): Added.
2179         (BenchmarkResults._subtest_values_by_config_iteration): Added. Organizes values measured for subtests
2180         by the iteration number so that i-th array contains values for all subtests at i-th iteration.
2181         (BenchmarkResults._aggregate_values): Added.
2182         (BenchmarkResults._lint_results): Added.
2183         (BenchmarkResults._lint_subtest_results): Added.
2184         (BenchmarkResults._lint_aggregator_list): Added.
2185         (BenchmarkResults._lint_configuration): Added.
2186         (BenchmarkResults._lint_values): Added.
2187         (BenchmarkResults._is_numeric): Added.
2188         * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py: Added.
2189         (BenchmarkResultsTest):
2190         (BenchmarkResultsTest.test_init):
2191         (BenchmarkResultsTest.test_format):
2192         (test_format_values_with_large_error):
2193         (test_format_values_with_small_error):
2194         (test_format_values_with_time):
2195         (test_format_values_with_no_error):
2196         (test_format_values_with_small_difference):
2197         (test_aggregate_results):
2198         (test_aggregate_results_with_gropus):
2199         (test_aggregate_nested_results):
2200         (test_lint_results):
2201         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2202         (BenchmarkRunner.execute): Added a call to show_results
2203         (BenchmarkRunner.wrap): Only dump the merged JSON when debugging.
2204         (BenchmarkRunner.show_results): Added.
2205
2206 2015-05-15  Ryosuke Niwa  <rniwa@webkit.org>
2207
2208         run_benchmark should have an option to specify the number of runs
2209         https://bugs.webkit.org/show_bug.cgi?id=145091
2210
2211         Reviewed by Antti Koivisto.
2212
2213         Added --count option.
2214
2215         * Scripts/run-benchmark:
2216         (main):
2217         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2218         (BenchmarkRunner.__init__):
2219
2220 2015-05-28  Alexey Proskuryakov  <ap@apple.com>
2221
2222         Update results of WebKit1.StringTruncator after r184965. I missed one letter.
2223
2224         * TestWebKitAPI/Tests/mac/StringTruncator.mm: (TestWebKitAPI::TEST):
2225
2226 2015-05-28  Alexey Proskuryakov  <ap@apple.com>
2227
2228         Update results of WebKit1.StringTruncator after r184965.
2229
2230         * TestWebKitAPI/Tests/mac/StringTruncator.mm: (TestWebKitAPI::TEST):
2231
2232 2015-05-28  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2233
2234         Unreviewed, updated my list of email addresses.
2235
2236         * Scripts/webkitpy/common/config/contributors.json:
2237
2238 2015-05-27  Dean Jackson  <dino@apple.com>
2239
2240         img.currentSrc problem in strict mode with old picturefill
2241         https://bugs.webkit.org/show_bug.cgi?id=144095
2242         <rdar://problem/21087013>
2243
2244         Reviewed by Simon Fraser.
2245
2246         Add a PICTURE_SIZES flag.
2247
2248         * Scripts/webkitperl/FeatureList.pm:
2249
2250 2015-05-26  Dana Burkart  <dburkart@apple.com>
2251
2252         Fixes compatibility issues with recent dashboard cleanup.
2253         https://bugs.webkit.org/show_bug.cgi?id=144814
2254
2255         Reviewed by Alexey Proskuryakov.
2256
2257         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
2258         (BuildbotStaticAnalyzerQueueView):
2259         (BuildbotStaticAnalyzerQueueView.prototype.update):
2260         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2261         (documentReady):
2262
2263 2015-05-26  Alexey Proskuryakov  <ap@apple.com>
2264
2265         Botwatcher's dashboard doesn't show JSC test regressions on Apple bots
2266         https://bugs.webkit.org/show_bug.cgi?id=143091
2267         rdar://problem/19330328
2268
2269         Reviewed by Darin Adler and Timothy Hatcher.
2270
2271         We have many of these, which are hard to fit on the dashboard. Added a view that
2272         collapses to a single green bubble when everything is good, and expands when there
2273         are failures (or manually).
2274
2275         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added BuildbotCombinedQueueView.js
2276
2277         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2278         (Buildbot.prototype.set isAuthenticated):
2279         (Buildbot.prototype._normalizeQueueInfo):
2280         (Buildbot.prototype._normalizeQueuesInfo):
2281         (Buildbot.prototype.updateQueues):
2282         Moved queue info normalization here from BuildbitQueue. The latter is a model class
2283         that shouldn't have to know about presentation, and this lets us leep the knowledge
2284         about combined queues out if it. Later, we can refactor existing code, and move out
2285         all knowledge about headings and such.
2286
2287         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
2288         Added the new view. It's not quite universal, and doesn't have as helpful popovers
2289         as other views, but we can extend it when/if we use it for more than JSC.
2290
2291         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2292         (BuildbotQueue): Now that info is normalized before creating a queue, don't do that here.
2293
2294         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2295         (documentReady): Added support for combined queues. These are currently always ending up
2296         in Other column, but it's easy to customize in the future if we need to.
2297
2298         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2299         (WebKitBuildbot): Added JSC queus.
2300
2301         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
2302         (.combined-queue-popover):
2303         (.combined-queue-popover .revision):
2304         Added styles for the combined view.
2305
2306 2015-05-26  Dan Bernstein  <mitz@apple.com>
2307
2308         Changed a file to use Unix line endings.
2309
2310         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
2311
2312 2015-05-26  Dan Bernstein  <mitz@apple.com>
2313
2314         <rdar://problem/21104551> Update build settings
2315
2316         Reviewed by Anders Carlsson.
2317
2318         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
2319         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2320         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2321         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2322         * WebEditingTester/Configurations/DebugRelease.xcconfig:
2323         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2324         * asan/asan.xcconfig:
2325
2326 2015-05-26  Anders Carlsson  <andersca@apple.com>
2327
2328         Fix build.
2329
2330         * WebKitTestRunner/mac/EventSenderProxy.mm:
2331         (WTR::EventSenderProxy::mouseForceDown):
2332         (WTR::EventSenderProxy::mouseForceUp):
2333         (WTR::EventSenderProxy::mouseForceChanged):
2334
2335 2015-05-26  Alexey Proskuryakov  <ap@apple.com>
2336
2337         build.webkit.org/dashboard: Don't list test steps in BuildbotIteration twice
2338         https://bugs.webkit.org/show_bug.cgi?id=145342
2339
2340         Reviewed by Darin Adler.
2341
2342         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2343         (BuildbotIteration.prototype._parseData):
2344
2345 2015-05-26  Milan Crha  <mcrha@redhat.com>
2346
2347         [GTK] Expand wildcards inside generate-inspector-gresource-manifest.py
2348         https://bugs.webkit.org/show_bug.cgi?id=138134
2349
2350         Reviewed by Žan Doberšek.
2351
2352         * gtk/generate-inspector-gresource-manifest.py:
2353         (get_filenames): Command line with expanded resources exceeds 32KB, which
2354         is a limit on Windows. It's better to expand wildcards inside the python script.
2355
2356 2015-05-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2357
2358         [GTK] Add construct property to WebKitWebContext to set the IndexedDB database directory
2359         https://bugs.webkit.org/show_bug.cgi?id=140882
2360
2361         Reviewed by Gustavo Noronha Silva.
2362
2363         Make sure unit tests write IndexedDB databases to the temporary
2364         directory, and add a test case to check that the directory is
2365         correctly created at the expected path.
2366
2367         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2368         (testWebContextConfiguration):
2369         (serverCallback):
2370         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2371         (Test::Test):
2372
2373 2015-05-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2374
2375         [GTK] Enable IndexedDB
2376         https://bugs.webkit.org/show_bug.cgi?id=98932
2377
2378         Reviewed by Žan Doberšek.
2379
2380         * Scripts/webkitperl/FeatureList.pm: Enable IndexedDB for the GTK port.
2381
2382 2015-05-24  Sam Weinig  <sam@webkit.org>
2383
2384         Crash when using a removed ScriptMessageHandler
2385         <rdar://problem/20888499>
2386         https://bugs.webkit.org/show_bug.cgi?id=145359
2387
2388         Reviewed by Dan Bernstein.
2389
2390         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
2391         Add tests for removing script message handlers.
2392
2393 2015-05-23  Dan Bernstein  <mitz@apple.com>
2394
2395         Remove unused definitions of WEBKIT_VERSION_MIN_REQUIRED
2396         https://bugs.webkit.org/show_bug.cgi?id=145345
2397
2398         Reviewed by Sam Weinig.
2399
2400         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2401         * LayoutTestRelay/Configurations/Base.xcconfig:
2402         * TestWebKitAPI/Configurations/Base.xcconfig:
2403         * WebKitTestRunner/Configurations/Base.xcconfig:
2404
2405 2015-05-23  Yusuke Suzuki  <utatane.tea@gmail.com>
2406
2407         Introduce UniquedStringImpl and SymbolImpl to separate symbolic strings from AtomicStringImpl
2408         https://bugs.webkit.org/show_bug.cgi?id=144848
2409
2410         Reviewed by Darin Adler.
2411
2412         Use UniquedStringImpl, SymbolImpl and AtomicStringImpl.
2413
2414         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2415
2416 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
2417
2418         Fix one more merge error in static analyzer support.
2419
2420         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
2421         (BuildbotStaticAnalyzerQueueView):
2422
2423 2015-05-22  Dana Burkart  <dburkart@apple.com>
2424
2425         Fix internal dashboard breakage from recent commit.
2426         https://bugs.webkit.org/show_bug.cgi?id=144814
2427
2428         Unreviewed build fix.
2429
2430         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
2431         (BuildbotStaticAnalyzerQueueView.prototype.update.appendStaticAnalyzerQueueStatus):
2432         (BuildbotStaticAnalyzerQueueView.prototype.update):
2433
2434 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
2435
2436         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
2437         https://bugs.webkit.org/show_bug.cgi?id=130463
2438         rdar://problem/20461342
2439
2440         Reviewed by Tim Horton.
2441
2442         This was more of a timing related flakiness than an actual OS version specific bug,
2443         we weren't getting window visibility notifications.
2444         
2445         I will look into adding this function call to DumpRenderTree separately, layout tests
2446         might actually rely on the broken behavior.
2447
2448         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2449         (TestWebKitAPI::TEST_F):
2450         * TestWebKitAPI/mac/mainMac.mm:
2451         (main):
2452
2453 2015-05-22  Dana Burkart  <dburkart@apple.com>
2454
2455         Add missing file from r184804 (mis-applied diff).
2456         https://bugs.webkit.org/show_bug.cgi?id=144814
2457
2458         Reviewed by Alexey Proskuryakov.
2459
2460         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js: Added.
2461         (BuildbotStaticAnalyzerQueueView):
2462         (BuildbotStaticAnalyzerQueueView.prototype.update.appendStaticAnalyzerQueueStatus):
2463         (BuildbotStaticAnalyzerQueueView.prototype.update):
2464
2465 2015-05-22  Dana Burkart  <dburkart@apple.com>
2466
2467         Add support to the botwatchers dashboard for a static analyzer bot.
2468         https://bugs.webkit.org/show_bug.cgi?id=144814
2469
2470         Reviewed by Alexey Proskuryakov.
2471
2472         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2473         scan-build should be considered a productive step.
2474
2475         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2476         (BuildbotQueue):
2477         Adds support for the staticAnalyzer property
2478
2479         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
2480         (BuildbotTestResults.prototype._parseResults):
2481         Get bug count from the scan-build step output
2482
2483         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2484         (documentReady):
2485         Rename the performance column 'Other', and merge the current 'Other' column with it.
2486
2487         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2488         (WebKitBuildbot):
2489         Now that performance bots are part of the 'Other' column, give them better headings.
2490
2491 2015-05-22  Tim Horton  <timothy_horton@apple.com>
2492
2493         Turn on autosaving of toolbar configuration in MiniBrowser
2494
2495         Rubber-stamped by Dan Bernstein.
2496
2497         * MiniBrowser/mac/BrowserWindow.xib:
2498
2499 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
2500
2501         build.webkit.org/dashboard: Simplify BuildbotQueueView creation code
2502         https://bugs.webkit.org/show_bug.cgi?id=145297
2503
2504         Reviewed by Tim Horton.
2505
2506         This is a refactoring to simplify code, and to make it more logical.
2507
2508         It is up to the view to decide how to present the queues, and whether to split
2509         them into debug and release, or in some different way.
2510
2511         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
2512         (BuildbotBuilderQueueView.filterQueues):
2513         (BuildbotBuilderQueueView):
2514         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
2515         (BuildbotLeaksQueueView):
2516         (BuildbotLeaksQueueView.prototype.update):
2517         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
2518         (BuildbotPerformanceQueueView):
2519         (BuildbotPerformanceQueueView.prototype.update):
2520         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2521         (BuildbotQueueView):
2522         (BuildbotQueueView.prototype._updateQueues):
2523         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2524         (BuildbotTesterQueueView):
2525         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2526         (documentReady):
2527
2528 2015-05-22  Tim Horton  <timothy_horton@apple.com>
2529
2530         Remove action menu support
2531         https://bugs.webkit.org/show_bug.cgi?id=145305
2532         <rdar://problem/21070771>
2533
2534         Reviewed by Anders Carlsson.
2535
2536         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2537         * TestWebKitAPI/Tests/WebKit2/action-menu-target.pdf: Removed.
2538         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Removed.
2539         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: Removed.
2540         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm: Removed.
2541         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundleSPI.h: Removed.
2542         Remove the tests.
2543
2544 2015-05-22  Dan Bernstein  <mitz@apple.com>
2545
2546         Removed the Use Shrink To Fit button from the toolbar’s default set.
2547
2548         Rubber-stamped by Tim Horton.
2549
2550         * MiniBrowser/mac/BrowserWindow.xib:
2551
2552 2015-05-21  Joanmarie Diggs  <jdiggs@igalia.com>
2553
2554         AX: [GTK] Implement computedRoleString in AccessibilityUIElement
2555         https://bugs.webkit.org/show_bug.cgi?id=128420
2556
2557         Reviewed by Chris Fleizach.
2558
2559         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2560         (WTR::AccessibilityUIElement::computedRoleString): Implemented.
2561
2562 2015-05-21  Csaba Osztrogonác  <ossy@webkit.org>
2563
2564         [EFL] Bump libsoup version to 2.50.0
2565         https://bugs.webkit.org/show_bug.cgi?id=145127
2566
2567         Reviewed by Gyuyoung Kim.
2568
2569         * efl/jhbuild.modules:
2570         * efl/patches/soup-clang-warning-fix1.patch: Removed.
2571         * efl/patches/soup-clang-warning-fix2.patch: Removed.
2572
2573 2015-05-20  Zan Dobersek  <zdobersek@igalia.com>
2574
2575         [GTK] Move MainThreadGtk, RunLoopGtk, WorkQueueGtk under Source/WTF/wtf/glib/
2576         https://bugs.webkit.org/show_bug.cgi?id=145117
2577
2578         Reviewed by Csaba Osztrogonác.
2579
2580         Rename the WorkQueueGtk.cpp file to WorkQueueGLib.cpp, and move it under
2581         Tools/TestWebKitAPI/Tests/WTF/glib/.
2582
2583         * TestWebKitAPI/PlatformGTK.cmake:
2584         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp.
2585         (TestWebKitAPI::TEST):
2586
2587 2015-05-20  KwangHyuk Kim  <hyuki.kim@samsung.com>
2588
2589         [EFL] fix efreet error
2590         https://bugs.webkit.org/show_bug.cgi?id=143670
2591
2592         Reviewed by Gyuyoung Kim.
2593
2594         Fix efreet error by using external variable efreet_cache_update.
2595         As 0 value of efreet_cache_update prevents monitoring of icon and desktop cache,
2596         efreet error for efreet_cache does not occur.
2597
2598         * MiniBrowser/efl/main.c:
2599         (elm_main):
2600
2601 2015-05-20  Michael Saboff  <msaboff@apple.com>
2602
2603         Add option to run_jsc_stress_tests to disable JIT testing
2604         https://bugs.webkit.org/show_bug.cgi?id=145233
2605
2606         Reviewed by Mark Lam.
2607
2608         Added --no-jit option.
2609
2610         * Scripts/run-jsc-stress-tests:
2611
2612 2015-05-20  Alex Christensen  <achristensen@webkit.org>
2613
2614         Use correct String for StringView in WTF API tests
2615         https://bugs.webkit.org/show_bug.cgi?id=145226
2616         rdar://problem/20361786
2617
2618         Reviewed by Benjamin Poulain.
2619
2620         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2621         (TestWebKitAPI::TEST):
2622         Use patternHolder for pattern.
2623
2624 2015-05-20  Alex Christensen  <achristensen@webkit.org>
2625
2626         [Content Extensions] Relax restrictions on triggers that match everything.
2627         https://bugs.webkit.org/show_bug.cgi?id=145069
2628
2629         Reviewed by Benjamin Poulain.
2630
2631         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2632         (TestWebKitAPI::TEST_F):
2633         Update and add tests for new possibilities with .*
2634
2635 2015-05-20  Rohit Kumar  <kumar.rohit@samsung.com>
2636
2637         [EFL][Minibrowser] Hide URL bar on fullscreen mode for HTML elements and browser window in WebKit EFL Minibrowser
2638         https://bugs.webkit.org/show_bug.cgi?id=144992
2639
2640         Reviewed by Gyuyoung Kim.
2641
2642         * MiniBrowser/efl/main.c:
2643         (toggle_window_fullscreen): Method to toggle between fullscreen and normal mode.
2644         (on_key_down):
2645         (on_fullscreen_enter):
2646         (on_fullscreen_exit):
2647         (window_create):
2648
2649 2015-05-19  Yusuke Suzuki  <utatane.tea@gmail.com>
2650
2651         Move AtomicStringImpl table related operations from AtomicString to AtomicStringImpl
2652         https://bugs.webkit.org/show_bug.cgi?id=145109
2653
2654         Reviewed by Darin Adler.
2655
2656         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2657         (TestWebKitAPI::TEST):
2658
2659 2015-05-19  Anders Carlsson  <andersca@apple.com>
2660
2661         Add alternate menu items for performing operations on the default data store
2662         https://bugs.webkit.org/show_bug.cgi?id=145184
2663
2664         Reviewed by Sam Weinig.
2665
2666         This makes it possible to test WKWebsiteDataStore code paths when there are no live web views
2667         associated with a data store.
2668
2669         * MiniBrowser/mac/AppDelegate.m:
2670         (-[BrowserAppDelegate fetchDefaultStoreWebsiteData:]):
2671         (-[BrowserAppDelegate fetchAndClearDefaultStoreWebsiteData:]):
2672         (-[BrowserAppDelegate clearDefaultStoreWebsiteData:]):
2673         * MiniBrowser/mac/MainMenu.xib:
2674
2675 2015-05-19  Csaba Osztrogonác  <ossy@webkit.org>
2676
2677         Fix tautological-compare warning in AtomicString.cpp
2678         https://bugs.webkit.org/show_bug.cgi?id=145120
2679
2680         Reviewed by Alexey Proskuryakov.
2681
2682         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
2683         (TestWebKitAPI::TEST): Removed always true assert.
2684
2685 2015-05-18  Csaba Osztrogonác  <ossy@webkit.org>
2686
2687         [EFL] Fix unsequenced warning in MiniBrowser's main.c
2688         https://bugs.webkit.org/show_bug.cgi?id=145123
2689
2690         Reviewed by Gyuyoung Kim.
2691
2692         * MiniBrowser/efl/main.c:
2693         (on_key_down):
2694
2695 2015-05-18  Daniel Bates  <dabates@apple.com>
2696
2697         prepare-ChangeLog reports function above deleted function as deleted; uninitialized value warning
2698         when staged non-empty file for commit
2699         https://bugs.webkit.org/show_bug.cgi?id=145082
2700
2701         Reviewed by Darin Adler.
2702
2703         Fixes two issues when running prepare-ChangeLog:
2704             1. The function above a deleted function is reported as changed.
2705             2. With a Git checkout of WebKit, a Perl uninitialized value warning is emitted when
2706             a new non-empty file is staged for commit (e.g. extractLineRangeBeforeAndAfterChange.pl,
2707             included in this patch).
2708
2709         Simplify code by using unified diff parsing logic for both SVN and Git support. Currently
2710         prepare-ChangeLog has logic to parse normal diff- and unified diff- chunk range lines as
2711         generated by `svn diff` and `git diff`, respectively. The logic for parsing these formats
2712         has correctness issues. We should make use of the VCSUtil::parseChunkRange() to parse
2713         chunk range lines of a unified diff as opposed to having specialized logic in prepare-ChangeLog.
2714         VCSUtil::parseChunkRange() has existing test coverage.
2715
2716         * Scripts/prepare-ChangeLog:
2717         (generateFunctionLists): Only add a line range to %line_ranges_before_changed, %line_ranges_after_changed
2718         when the beginning line number, ending line number >= 1. Modified for-loop condition to iterate over
2719         all the files represented by %line_ranges_before_changed and %line_ranges_after_changed so that we
2720         examine files that only have deletions. Currently this works as a side effect of the behavior of
2721         extractLineRangeAfterChange(), which always returns a well-formed (though nonsensical) line range for
2722         a change that represents a deletion (e.g. extractLineRangeAfterChange("@@ -166,6 +165,0 @@") => [165, 165]).
2723         (diffCommand): Generate a unified diff instead of a normal diff when using a SVN checkout of WebKit.
2724         (extractLineRangeAfterChange): Remove logic to parse a normal diff chunk range line and write
2725         the logic to parse a unified diff chunk range line in terms of VCSUtil::parseChunkRange().
2726         We return (-1, -1) when the change represents a deletion.
2727         (extractLineRangeBeforeChange): Remove logic to parse a normal diff chunk range line and write
2728         the logic to parse a unified diff chunk range line in terms of VCSUtil::parseChunkRange().
2729         We return (-1, -1) when the change represents an addition.
2730         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl: Added;
2731         unit tests.
2732
2733 2015-05-18  Anders Carlsson  <andersca@apple.com>
2734
2735         Add ATS keys to MiniBrowser
2736         https://bugs.webkit.org/show_bug.cgi?id=145141
2737
2738         Reviewed by Sam Weinig.
2739
2740         * MiniBrowser/mac/Info.plist:
2741
2742 2015-05-17  David Kilzer  <ddkilzer@apple.com>
2743
2744         bisect-builds: Add 'retry' option when prompting whether the bug reproduced
2745         <http://webkit.org/b/145100>
2746
2747         Reviewed by Darin Adler.
2748
2749         * Scripts/bisect-builds:
2750         - Add PROMPT_ANSWER_* constants for yes/no/retry/broken prompt.
2751         - Switch to using PROMPT_RESPONSE_* constants when testing the
2752           value of $didReproduceBug.
2753         - Add do { } while loops to implement 'retry' mode.
2754         (promptForTest):
2755         - Switch to returning PROMPT_RESPONSE_* constants.
2756         - Add support for 'retry' response.
2757
2758 2015-05-16  Tanay C  <tanay.c@samsung.com>
2759
2760         [EFL][WK2] Minibrowser : Add search icon to search bar
2761         https://bugs.webkit.org/show_bug.cgi?id=139773
2762
2763         Reviewed by Gyuyoung Kim.
2764
2765         * MiniBrowser/efl/main.c: 
2766         (search_icon_show): Added.
2767         (search_box_show): Modified.
2768
2769 2015-05-15  Ryosuke Niwa  <rniwa@webkit.org>
2770
2771         run_benchmark should have an option to specify the number of runs
2772         https://bugs.webkit.org/show_bug.cgi?id=145091
2773
2774         Reviewed by Stephanie Lewis.
2775
2776         Added --count option.
2777
2778         * Scripts/run-benchmark:
2779         (main):
2780         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2781         (BenchmarkRunner.__init__):
2782
2783 2015-05-15  Timothy Horton  <timothy_horton@apple.com>
2784
2785         Temporarily disable failing API test.
2786
2787         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
2788         (TestWebKitAPI::TEST):
2789
2790 2015-05-15  Ravi Phaneendra Kasibhatla  <r.kasibhatla@samsung.com>
2791
2792         User interruption while running of run-webkit-tests should also generate results.html
2793         https://bugs.webkit.org/show_bug.cgi?id=122154
2794
2795         Reviewed by Csaba Osztrogonác.
2796
2797         Generation of results.html on execution of run-webkit-tests happens only
2798         on completion of entire layout tests run. It should be created even when
2799         the execution has been interrupted - either by user (by pressing Ctrl+C)
2800         or because of other interruptions (like exit-after-n-failures option).
2801
2802         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2803         (LayoutTestRunner.run_tests):
2804         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2805         (Manager.run):
2806         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2807         (TestRunResults.__init__):
2808         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2809         (main):
2810         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2811         (RunTest.test_keyboard_interrupt):
2812         (MainTest.test_exception_handling):
2813
2814 2015-05-15  Csaba Osztrogonác  <ossy@webkit.org>
2815
2816         [buildbot] Fix the URL of the performance bots
2817         https://bugs.webkit.org/show_bug.cgi?id=145043
2818
2819         Reviewed by Ryosuke Niwa.
2820
2821         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2822
2823 2015-05-14  Timothy Horton  <timothy_horton@apple.com>
2824
2825         Add a layout mode that scales down the view to try to fit the document
2826         https://bugs.webkit.org/show_bug.cgi?id=145022
2827         <rdar://problem/19790341>
2828
2829         Reviewed by Dean Jackson.
2830
2831         * MiniBrowser/mac/BrowserWindow.xib:
2832         * MiniBrowser/mac/BrowserWindowController.h:
2833         * MiniBrowser/mac/WK2BrowserWindowController.m:
2834         (-[WK2BrowserWindowController toggleShrinkToFit:]):
2835         (-[WK2BrowserWindowController toggleUseMinimumViewSize:]): Deleted.
2836         Switch to _WKLayoutModeDynamicSizeComputedFromMinimumDocumentSize.
2837
2838 2015-05-14  Michael Catanzaro  <mcatanzaro@igalia.com>
2839
2840         [CMake] Don't read the LOCATION property of targets
2841         https://bugs.webkit.org/show_bug.cgi?id=145018
2842
2843         Reviewed by Martin Robinson.
2844
2845         Use the TARGET_FILE_DIR generator expression to determine the location of the test injected
2846         bundle, rather than assuming that the LOCATION property of TestWebKitAPIInjectedBundle will
2847         be the same at configure-time as it is at generate-time.
2848
2849         * TestWebKitAPI/CMakeLists.txt:
2850
2851 2015-05-14  Myles C. Maxfield  <mmaxfield@apple.com>
2852
2853         Add String literal overloads to equalIgnoringASCIICase()
2854         https://bugs.webkit.org/show_bug.cgi?id=145008
2855
2856         Reviewed by Benjamin Poulain.
2857
2858         Test changes to WTF.
2859
2860         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2861         (WTF.StringImplEqualIgnoringASCIICaseBasic): Test const char*.
2862         (WTF.StringImplEqualIgnoringASCIICaseWithLatin1Characters): Ditto.
2863         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2864         (WTF.StringViewEqualIgnoringASCIICaseBasic): Ditto.
2865         (WTF.StringViewEqualIgnoringASCIICaseWithLatin1Characters): Ditto.
2866
2867 2015-05-14  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2868
2869         SharedBuffer::createWithContentsOfFile should use map file routines
2870         https://bugs.webkit.org/show_bug.cgi?id=144192
2871
2872         Reviewed by Darin Adler.
2873
2874         Adding SharedBuffer and FileSystem Unit tests to Mac and GTK, not yet for EFL.
2875
2876         * TestWebKitAPI/PlatformGTK.cmake:
2877         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2878         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Added.
2879         (TestWebKitAPI::FileSystemTest::tempFilePath):
2880         (TestWebKitAPI::FileSystemTest::tempEmptyFilePath):
2881         (TestWebKitAPI::TEST_F):
2882         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Added.
2883         (TestWebKitAPI::SharedBufferTest::tempFilePath):
2884         (TestWebKitAPI::SharedBufferTest::tempEmptyFilePath):
2885         (TestWebKitAPI::TEST_F):
2886
2887 2015-05-13  Alex Christensen  <achristensen@webkit.org>
2888
2889         [Content Extensions] Test interactions between multiple extensions and multiple domains.
2890         https://bugs.webkit.org/show_bug.cgi?id=144967
2891
2892         Reviewed by Benjamin Poulain.
2893
2894         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2895         Xcode wanted to fix an alphabetization issue.
2896         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2897         (TestWebKitAPI::TEST_F):
2898         Test interactions that worked but were not explicitly tested before.
2899
2900 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
2901
2902         Unreviewed build fix.
2903
2904         Added the missing metric name and wrapped values in an array as done in SunSpider.patch.
2905
2906         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch:
2907
2908 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
2909
2910         Fix the previous commit, which made both bubbles green.
2911
2912         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
2913         (.status-line.good .bubble):
2914         (.status-line.bad .bubble):
2915         (.status-line.good .message):
2916
2917 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
2918
2919         People with Deuteranopia can't tell red and green apart on bot watcher's dashboard
2920         https://bugs.webkit.org/show_bug.cgi?id=144929
2921
2922         Reviewed by Eric Carlson.
2923
2924         Tweaked colors as I see fit.
2925
2926         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
2927         (.status-line.good .bubble):
2928         (.status-line.bad .bubble):
2929
2930 2015-05-11  Alexey Proskuryakov  <ap@apple.com>
2931
2932         [Mac] Share cookie storage between UI process and secondary processes
2933         https://bugs.webkit.org/show_bug.cgi?id=144820
2934         rdar://problem/20572830
2935
2936         Reviewed by Darin Adler.
2937
2938         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
2939         Don't set cookie storage directory, as it's a no-op, we use an ephemeral session
2940         for testing.
2941
2942 2015-05-12  Jake Nielsen  <jacob_nielsen@apple.com>
2943
2944         Fix internal build configuration issues
2945         https://bugs.webkit.org/show_bug.cgi?id=144762
2946
2947         Reviewed by David Kilzer.
2948
2949         Modifies DumpRenderTree's xcconfig files to use SDK selectors.
2950
2951         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2952         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2953         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2954         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
2955         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig:
2956         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
2957         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
2958         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
2959
2960 2015-05-12  David Kilzer  <ddkilzer@apple.com>
2961
2962         Switch to launching iOS Simulator using bundle ID
2963         <rdar://problem/20916096>
2964
2965         This is required to fix the layout tests on internal bots.
2966
2967         * Scripts/webkitdirs.pm:
2968         (relaunchIOSSimulator): Switch to use bundle ID to launch iOS
2969         Simulator.  Add FIXME.
2970         (quitIOSSimulator): Add FIXME.
2971         * Scripts/webkitpy/port/ios.py:
2972         (IOSSimulatorPort.setup_test_run): Switch to use bundle ID to
2973         launch iOS Simulator.  Add FIXME.
2974         (IOSSimulatorPort.check_sys_deps): Add FIXME.
2975
2976 2015-05-12  Per Arne Vollan  <peavo@outlook.com>
2977
2978         Fix run-javascriptcore-tests step on the WinCairo bot
2979         https://bugs.webkit.org/show_bug.cgi?id=144866
2980
2981         Reviewed by Csaba Osztrogonác.
2982
2983         Catch exception when failing to create soft link, so we can fall back to copy.
2984
2985         * Scripts/run-jsc-stress-tests:
2986
2987 2015-05-12  Joanmarie Diggs  <jdiggs@igalia.com>
2988
2989         [GTK][WK2] rowAtIndex is not implemented in DRT/WKTR
2990         https://bugs.webkit.org/show_bug.cgi?id=116971
2991
2992         Reviewed by Chris Fleizach.
2993
2994         Implement rowAtIndex for ATK.
2995
2996         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2997         (WTR::AccessibilityUIElement::rowAtIndex):
2998
2999 2015-05-11  Dan Bernstein  <mitz@apple.com>
3000
3001         Test for <rdar://problem/20878075> Trying to navigate to an invalid URL loads about:blank, but -[WKWebView URL] returns the invalid URL
3002
3003         Reviewed by Alexey Proskuryakov.
3004
3005         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3006         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm: Fixed copyright header.
3007         * TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLChange.mm: Added.
3008         (-[ProvisionalURLChangeController webView:didFinishNavigation:]):
3009
3010 2015-05-11  Jake Nielsen  <jacob_nielsen@apple.com>
3011
3012         Fix internal build configuration issues
3013         https://bugs.webkit.org/show_bug.cgi?id=144762
3014
3015         Reviewed by Darin Adler.
3016
3017         Modifies TestWebKitAPI and WebKitTestRunner's xcconfig files to use SDK selectors.
3018
3019         * TestWebKitAPI/Configurations/Base.xcconfig:
3020         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3021         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
3022         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3023         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3024         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
3025         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
3026
3027 2015-05-11  Brent Fulgham  <bfulgham@apple.com>
3028
3029         [Win] Move Windows build target to Windows 7 (or newer)
3030         https://bugs.webkit.org/show_bug.cgi?id=144890
3031         <rdar://problem/20707307>
3032
3033         Reviewed by Anders Carlsson.
3034
3035         Update linked SDK and minimal Windows level to be compatible with
3036         Windows 7 or newer.
3037
3038         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
3039         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
3040         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
3041         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
3042         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
3043         * DumpRenderTree/config.h:
3044         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3045         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
3046         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
3047         * WinLauncher/stdafx.h:
3048
3049 2015-05-11  Commit Queue  <commit-queue@webkit.org>
3050
3051         Unreviewed, rolling out r184119.
3052         https://bugs.webkit.org/show_bug.cgi?id=144888
3053
3054         broke JSC tests on Apple Windows bots (Requested by kling on
3055         #webkit).
3056
3057         Reverted changeset:
3058
3059         "Fix run-javascriptcore-tests step on the WinCairo bot"
3060         https://bugs.webkit.org/show_bug.cgi?id=144866
3061         http://trac.webkit.org/changeset/184119
3062
3063 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
3064
3065         run-benchmark should support Dromaeo
3066         https://bugs.webkit.org/show_bug.cgi?id=144849
3067
3068         Reviewed by Chris Dumez.
3069
3070         Added the benchmark plans for Dromaeo DOM tests. We only run these tests once since
3071         they can take as much as 15 minutes to run each.
3072
3073         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch: Added.
3074         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Added.
3075         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Added.
3076         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Added.
3077
3078 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
3079
3080         Build fix. jetstream has a local copy, not remote archive.
3081
3082         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
3083
3084 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
3085
3086         run-benchmark should support SunSpider, Kraken and Octane
3087         https://bugs.webkit.org/show_bug.cgi?id=144840
3088
3089         Reviewed by Darin Adler.
3090
3091         Added the support for SunSpider, Kraken, and Octane. Because of the licensing issues, we can't commit the
3092         Kraken source code into the WebKit repository as done for other benchmarks. Instead, we'll dynamically
3093         download it from the remote server using newly added RemoteZipBenchmarkBuilder. We do the same for Octane
3094         for simplicity. Use newly added --local-copy option to specify the location of a local copy if there is any.
3095
3096         Renamed "original_benchmark in the plan file to "local_copy" and added a new optional "remote_archive" to
3097         specify the URL to a remote ZIP file. This optional field is used by Kraken and Octane benchmark plans.
3098
3099         In addition, generalized the ability to run a "create script" in JetStreamBenchmarkBuilder since it's also
3100         needed for SunSpider and Kraken. This feature has now been folded into GenericBenchmarkBuilder.
3101
3102         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Added
3103         RemoteZipBenchmarkBuilder for Kraken and removed JetStreamBenchmarkBuilder since GenericBenchmarkBuilder
3104         now has the ability to run an arbitrary "create script".
3105
3106         * Scripts/run-benchmark:
3107         (main): Added an optional argument, --local-copy, to override the location of the benchmark's local copy.
3108         This also overrides the remote archive URL specified in the plan.
3109
3110         * Scripts/webkitpy/benchmark_runner/README.md: Updated the description.
3111
3112         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Deleted the entry for
3113         JetStreamBenchmarkBuilder.
3114
3115         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: 
3116         (GenericBenchmarkBuilder.prepare): Call _fetchRemoteArchive if local_copy is not specified in the plan or
3117         by --local-copy option but remote_archive is specified. Also call self.clean() here instead of relying on
3118         _runCreateScript and _applyPatch to clean after themselves.
3119         (GenericBenchmarkBuilder._runCreateScript): Moved from JetStreamBenchmarkBuilder._runCreateScript since
3120         JetStream, SunSpider, Kraken all use this feature.
3121         (GenericBenchmarkBuilder._copyBenchmarkToTempDir): Use self.name as the destination location instead of
3122         the leaf directory name since the latter is not available when a remote ZIP file is used.
3123         (GenericBenchmarkBuilder._fetchRemoteArchive): Added.
3124         (GenericBenchmarkBuilder._applyPatch): Apply the patch inside destination directory to avoid hard coding
3125         the benchmark name in the patches.
3126
3127         * Scripts/webkitpy/benchmark_runner/benchmark_builder/jetstream_benchmark_builder.py: Removed.
3128
3129         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3130         (BenchmarkRunner.__init__): Set self.planName. Also override 'local_copy' when --local-copy option is used.
3131         (BenchmarkRunner.execute): Exit early if neither local_copy nor remote_archive is specified. Prefix the URL
3132         the browser opens by planName as the plan file no longer contains that.
3133
3134         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Changed the path to be relative against
3135         the top directory of JetStream instead of its parent.
3136         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch: Added.
3137         * Scripts/webkitpy/benchmark_runner/data/patches/Octane.patch: Added.
3138         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Changed the path to be relative against
3139         the top directory of JetStream instead of its parent.
3140         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch: Added.
3141         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Uses GenericBenchmarkBuilder and specifies
3142         the script to run. The entry point was changed to the relative path from the top directory of JetStream as
3143         done in JetStream.patch.
3144         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Added.
3145         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Added.
3146         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: The entry point was changed to the relative
3147         path from the top directory of JetStream as done in JetStream.patch.
3148         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan: Added.
3149
3150 2015-05-11  Csaba Osztrogonác  <ossy@webkit.org>
3151
3152         Fix run-javascriptcore-tests step on the WinCairo bot
3153         https://bugs.webkit.org/show_bug.cgi?id=144866
3154
3155         Reviewed by Darin Adler.
3156
3157         * Scripts/run-jsc-stress-tests:
3158
3159 2015-05-11  Alex Christensen  <achristensen@webkit.org>
3160
3161         [Content Extensions] Support domain-specific rules and exceptions.
3162         https://bugs.webkit.org/show_bug.cgi?id=144833
3163
3164         Reviewed by Darin Adler.
3165
3166         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3167         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
3168         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
3169         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
3170         Moved CompiledContentExtensionData from ContentExtensionCompiler.h because it is only used for testing.
3171         (TestWebKitAPI::mainDocumentRequest):
3172         (TestWebKitAPI::subResourceRequest):
3173         (TestWebKitAPI::TEST_F):
3174         (TestWebKitAPI::checkCompilerError):
3175         Added tests for parsing and functionality of if-domain and unless-domain.
3176
3177 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
3178
3179         run-benchmark should support Chrome Canary and Firefox Nightly
3180         https://bugs.webkit.org/show_bug.cgi?id=144850
3181
3182         Reviewed by Darin Adler.
3183
3184         Added the support for Chrome Canary, Firefox (release), and Firefox Nightly.
3185
3186         This patch also extracts OSXBrowserDriver to launch and terminate processes on OS X.
3187
3188         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json:
3189         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py: Added.
3190         (OSXBrowserDriver):
3191         (OSXBrowserDriver.prepareEnv): Extracted from ChromeBrowserDriver.prepareEnv.
3192         (OSXBrowserDriver.closeBrowsers): Ditto.
3193         (OSXBrowserDriver.launchProcess): Ditto.
3194         (OSXBrowserDriver.terminateProcesses): Ditto.
3195         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
3196         (OSXChromeDriver): Removed the unused self.chromePreferences.
3197         (OSXChromeDriver.prepareEnv): Moved to OSXBrowserDriver.
3198         (OSXChromeDriver.closeBrowsers): Ditto.
3199         (OSXChromeDriver.launchUrl):
3200         (OSXChromeCanaryDriver): Added.
3201         (OSXChromeCanaryDriver.launchUrl):
3202         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: Added.
3203         (OSXFirefoxDriver): Added.
3204         (OSXFirefoxDriver.launchUrl):
3205         (OSXFirefoxNightlyDriver): Added.
3206         (OSXFirefoxNightlyDriver.launchUrl):
3207         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
3208         (OSXSafariDriver):
3209         (OSXSafariDriver.closeBrowsers):
3210
3211 2015-05-11  Tim Horton  <timothy_horton@apple.com>
3212
3213         Page overlay action context override should indicate the source of the request
3214         https://bugs.webkit.org/show_bug.cgi?id=144832
3215         <rdar://problem/20562594>
3216
3217         Reviewed by Darin Adler.
3218
3219         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm:
3220         (TestWebKitAPI::ActionMenuTest::actionContextForResultAtPoint):
3221
3222 2015-05-10  Martin Robinson  <mrobinson@igalia.com>
3223
3224         [GTK] fast/events/page-visibility-transition-test.html is timing out
3225         https://bugs.webkit.org/show_bug.cgi?id=114789
3226
3227         Reviewed by Darin Adler.
3228
3229         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3230         (WTR::TestController::setHidden): Map and unmap the WebView when the harness
3231         requests visibility changes.
3232
3233 2015-05-10  Csaba Osztrogonác  <ossy@webkit.org>
3234
3235         [EFL] Fix install-dependencies on Ubuntu 14.10/15.04
3236         https://bugs.webkit.org/show_bug.cgi?id=144798
3237
3238         Reviewed by Darin Adler.
3239
3240         * efl/install-dependencies:
3241
3242 2015-05-09  Ryosuke Niwa  <rniwa@webkit.org>
3243
3244         Make arguments of run-benchmark more user friendly
3245         https://bugs.webkit.org/show_bug.cgi?id=144835
3246
3247         Reviewed by Darin Adler.
3248
3249         Made --build-directory optional since I don't expect a typical WebKit developer to have a local build
3250         of Chrome and Firefox. Also made --plan accept just a filename so that we can just say "speedometer"
3251         instead of "Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan". Finally, removed
3252         default values from --platform and --browser as they are required arguments.
3253
3254         * Scripts/run-benchmark:
3255         (main): Made --build-directory optional, and removed default values from --platform and --browser.
3256         Also added help text for --build-directory and --plan. In addition, the list of platforms and browsers
3257         are not dynamically obtained via BrowserDriverFactory.
3258         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3259         (BenchmarkRunner.__init__): Raise when we can't find the plan file or the plan file is not a valid JSON
3260         file instead of suppressing the error here and blowing up later mysteriously since we won't be able to
3261         run any benchmark in that case.
3262         (BenchmarkRunner._findPlanFile): Added. Look for the plan in webkitpy/benchmark_runner/data/plans if
3263         the specified file isn't a valid relative or an absolute path.
3264         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
3265         (BrowserDriverFactory.available_platforms): Added. Used in main to provide the list of valid platforms
3266         and browsers.
3267         (BrowserDriverFactory.available_browsers): Ditto.
3268         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
3269         (OSXChromeDriver.launchUrl): browserBuildPath is never optional since BenchmarkRunner.execute always
3270         calls launchUrl with this argument so removed the default value. Also added a fallback path for when
3271         browserBuildPath was None.
3272         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
3273         (OSXSafariDriver.launchUrl): Ditto. We also fallback when the build directory doesn't contain Safari
3274         so that we can use locally built WebKit to launch Safari.
3275
3276 2015-05-09  Yoav Weiss  <yoav@yoav.ws>
3277
3278         Remove the PICTURE_SIZES build flag
3279         https://bugs.webkit.org/show_bug.cgi?id=144679
3280
3281         Reviewed by Benjamin Poulain.
3282
3283         Removed the PICTURE_SIZES build time flag.
3284
3285         * Scripts/webkitperl/FeatureList.pm:
3286
3287 2015-05-09  David Kilzer  <ddkilzer@apple.com>
3288
3289         Layout tests broke due to unexpected simctl output
3290
3291         * Scripts/webkitpy/xcode/simulator.py:
3292         (Simulator._parse_devices): Handle new Device Pairs header.
3293         * Scripts/webkitpy/xcode/simulator_unittest.py:
3294         (test_device_pairs): Add unit test for Device Pairs header.
3295
3296 2015-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
3297
3298         Remove convenience constructors for TextRun
3299         https://bugs.webkit.org/show_bug.cgi?id=144752
3300
3301         Reviewed by Anders Carlsson.
3302
3303         Test the StringView which takes a StringImpl*.
3304
3305         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3306         (StringView8Bit): Testing is8Bit() on StringView
3307
3308 2015-05-07  Sam Weinig  <sam@webkit.org>
3309
3310         [Content Extensions] Add simple tester that takes an extension and compiles it
3311         https://bugs.webkit.org/show_bug.cgi?id=144781
3312
3313         Reviewed by Dan Bates.
3314
3315         * ContentExtensionTester: Added.
3316         * ContentExtensionTester/Configurations: Added.
3317         * ContentExtensionTester/Configurations/Base.xcconfig: Copied from Source/bmalloc/Configurations/Base.xcconfig.
3318         * ContentExtensionTester/Configurations/ContentExtensionTester.xcconfig: Copied from Source/bmalloc/Configurations/bmalloc.xcconfig.
3319         * ContentExtensionTester/Configurations/DebugRelease.xcconfig: Copied from Source/bmalloc/Configurations/DebugRelease.xcconfig.
3320         * ContentExtensionTester/ContentExtensionTester.xcodeproj: Added.
3321         * ContentExtensionTester/ContentExtensionTester.xcodeproj/project.pbxproj: Added.
3322         * ContentExtensionTester/Makefile: Copied from Tools/TestWebKitAPI/Makefile.
3323         * ContentExtensionTester/main.m: Added.
3324         * Scripts/run-content-extension-tester: Copied from Tools/Scripts/run-webkit-tests.
3325
3326 2015-05-08  Alexey Proskuryakov  <ap@apple.com>
3327
3328         Build fix.
3329
3330         Reviewed by Dan Bernstein.
3331
3332         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
3333         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3334         (-[DumpRenderTreeDraggingInfo springLoadingHighlight]):
3335         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
3336         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
3337         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
3338         (-[WebKitTestRunnerDraggingInfo springLoadingHighlight]):
3339         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
3340
3341 2015-05-08  Martin Robinson  <mrobinson@igalia.com>
3342
3343         [GTK] Some tests fail because they do not assume the popup menu captures click events
3344         https://bugs.webkit.org/show_bug.cgi?id=40601
3345
3346         Reviewed by Carlos Garcia Campos.
3347
3348         Popdown all attached menus when moving between tests and between each new
3349         event sent to the WebView. This prevents context and popup menus from eating
3350         events.
3351
3352         * WebKitTestRunner/PlatformWebView.h: Added a helper method to do menu popdown.
3353         * WebKitTestRunner/TestController.cpp: Add a specialization of these methods for GTK+.
3354         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3355         (WTR::dispatchEvent): Popdown all menus between dispatching events.
3356         (WTR::EventSenderProxy::replaySavedEvents): Pass the view when dispatching events.
3357         (WTR::EventSenderProxy::sendOrQueueEvent): Pass the view when dispatching events.
3358         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3359         (WTR::PlatformWebView::hideAllPopupMenus): Added this helper.
3360         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3361         (WTR::TestController::platformConfigureViewForTest): Added this stub, which is no
3362         longer in the platform-independent file.
3363         (WTR::TestController::platformResetPreferencesToConsistentValues): Popdown menus.
3364
3365 015-05-08  Michael Catanzaro  <mcatanzaro@igalia.com>, Martin Robinson <mrobinson@igalia.com>
3366
3367         [GTK] Checks for DEVELOPMENT_BUILD are all wrong
3368         https://bugs.webkit.org/show_bug.cgi?id=144746
3369
3370         Reviewed by Carlos Garcia Campos.
3371
3372         Use ENABLE_DEVELOPER_MODE rather than DEVELOPMENT_BUILD.
3373
3374         * MiniBrowser/gtk/main.c:
3375         (main):
3376
3377 2015-05-08  Commit Queue  <commit-queue@webkit.org>
3378
3379         Unreviewed, rolling out r183996.
3380         https://bugs.webkit.org/show_bug.cgi?id=144806
3381
3382         ASan detected use-after free (Requested by ap on #webkit).
3383
3384         Reverted changeset:
3385
3386         "Remove convenience constructors for TextRun"
3387         https://bugs.webkit.org/show_bug.cgi?id=144752
3388         http://trac.webkit.org/changeset/183996
3389
3390 2015-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
3391
3392         Remove convenience constructors for TextRun
3393         https://bugs.webkit.org/show_bug.cgi?id=144752
3394
3395         Reviewed by Anders Carlsson.
3396
3397         Test the StringView which takes a StringImpl*.
3398
3399         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3400         (StringView8Bit): Testing is8Bit() on StringView
3401
3402 2015-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3403
3404         [GTK] WTR doesn't correctly handle the Escape key
3405         https://bugs.webkit.org/show_bug.cgi?id=144788
3406
3407         Reviewed by Martin Robinson.
3408
3409         Correctly handle 0x001B character code in GTK+ event sender to be
3410         recognized as Escape key, because gdk_unicode_to_keyval() doesn't
3411         handle it. This fixes layout tests using keyDown(String.fromCharCode(0x001B), null);
3412         to dismiss popup menus.
3413
3414         Fixes editing/selection/5354455-1.html.
3415
3416         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3417         (WTR::getGDKKeySymForKeyRef):
3418
3419 2015-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3420
3421         [GTK] Expose allowFileAccessFromFileURLs setting to WebKit2 GTK+ API
3422         https://bugs.webkit.org/show_bug.cgi?id=144748
3423
3424         Reviewed by Sergio Villar Senin.
3425
3426         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
3427         (testWebKitSettings): Check the new setting is correctly
3428         initialized and updated.
3429         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3430         (testWebContextSecurityFileXHR): Check XHR to local files is
3431         allowed from file URLs after changing the setting.
3432         (beforeAll): Add new test.
3433
3434 2015-05-08  Commit Queue  <commit-queue@webkit.org>
3435
3436         Unreviewed, rolling out r183945.
3437         https://bugs.webkit.org/show_bug.cgi?id=144789
3438
3439         "It broke all the GTK+ tests" (Requested by KaL on #webkit).
3440
3441         Reverted changeset:
3442
3443         "[GTK] Checks for DEVELOPMENT_BUILD are all wrong"
3444         https://bugs.webkit.org/show_bug.cgi?id=144746
3445         http://trac.webkit.org/changeset/183945
3446
3447 2015-05-07  Anders Carlsson  <andersca@apple.com>
3448
3449         Build fixes.
3450
3451         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
3452         (TestWebKitAPI::TEST):
3453         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
3454         (TestWebKitAPI::TEST):
3455         Add casts.
3456
3457 2015-05-07  Filip Pizlo  <fpizlo@apple.com>
3458
3459         GC has trouble with pathologically large array allocations
3460         https://bugs.webkit.org/show_bug.cgi?id=144609
3461
3462         Reviewed by Geoffrey Garen.
3463         
3464         Add a --filter option that restricts the set of tests we run. I needed it to fix this bug
3465         and it's a frequently requested feature.
3466         
3467         Also add the ability to run a test pretending that your system has a particular RAM size.
3468         This is useful for GC tests, and the new GC test that I added uses this.
3469
3470         * Scripts/run-javascriptcore-tests:
3471         (runJSCStressTests):
3472         * Scripts/run-jsc-stress-tests:
3473
3474 2015-05-07  Csaba Osztrogonác  <ossy@webkit.org>
3475
3476         [EFL] Bump EFL version to 1.14.0
3477         https://bugs.webkit.org/show_bug.cgi?id=144743
3478
3479         Reviewed by Darin Adler.
3480
3481         Bump EFL and elementary version to 1.14.0 and removed
3482         md5sum, because it isn't used at all if hash is present.
3483
3484         * efl/jhbuild.modules:
3485
3486 2015-05-07  Saam Barati  <saambarati1@gmail.com>
3487
3488         exceptionFuzz tests should explicitly initialize the exceptionFuzz boolean in JavaScript code through a function in jsc.cpp
3489         https://bugs.webkit.org/show_bug.cgi?id=144753
3490
3491         Reviewed by Mark Lam.
3492
3493         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
3494
3495 2015-05-07  Beth Dakin  <bdakin@apple.com>
3496
3497         New force-related DOM events should fire in WK1 views
3498         https://bugs.webkit.org/show_bug.cgi?id=144663
3499         -and corresponding-
3500         rdar://problem/20281886
3501
3502         Reviewed by Sam Weinig.
3503
3504         PlatformEventFactory::createPlatformMouseEvent() takes the last pressure event 
3505         now. Just send nil. 
3506         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
3507         (TestWebKitAPI::buildAndPerformTest):
3508
3509 2015-05-07  Michael Catanzaro  <mcatanzaro@igalia.com>
3510
3511         [GTK] Checks for DEVELOPMENT_BUILD are all wrong
3512         https://bugs.webkit.org/show_bug.cgi?id=144746
3513
3514         Reviewed by Martin Robinson.
3515
3516         Use DEVELOPER_MODE rather than DEVELOPMENT_BUILD.
3517
3518         * MiniBrowser/gtk/main.c:
3519         (main):
3520
3521 2015-05-05  Myles C. Maxfield  <mmaxfield@apple.com>
3522
3523         Revert "Introducing the Platform Abstraction Layer (PAL)"
3524         https://bugs.webkit.org/show_bug.cgi?id=144751
3525
3526         Unreviewed.
3527
3528         PAL should be a new target inside WebCore, rather than a top-level folder.
3529
3530         * Scripts/build-webkit: Add it to build-webkit.
3531
3532 2015-05-07  Ada Chan  <adachan@apple.com>
3533
3534         Add a test for WKPageCopySessionState() with filtering.
3535         https://bugs.webkit.org/show_bug.cgi?id=144666
3536
3537         Reviewed by Darin Adler.
3538
3539         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3540         * TestWebKitAPI/Tests/WebKit2/WKPageCopySessionStateWithFiltering.cpp: Added.
3541         (TestWebKitAPI::didFinishLoadForFrame):
3542         (TestWebKitAPI::setPageLoaderClient):
3543         (TestWebKitAPI::filterFirstItemCallback):
3544         (TestWebKitAPI::filterAllItemsCallback):
3545         (TestWebKitAPI::createSessionStates):
3546         (TestWebKitAPI::TEST):
3547
3548 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
3549
3550         iOS build fix attempt
3551
3552         Link WebKitTestRunnerApp to WebKit, now that we don't have WebKit2.
3553
3554         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3555
3556 2015-05-06  Matt Baker  <mattbaker@apple.com>
3557
3558         Unreviewed, updated my list of email addresses.
3559
3560         * Scripts/webkitpy/common/config/contributors.json:
3561
3562 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
3563
3564         Do not link tools to WebKit2.framework
3565         https://bugs.webkit.org/show_bug.cgi?id=144699
3566
3567         Unreviewed build fix.
3568
3569         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3570         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
3571         These linked to WebKit2 in two ways, eliminating the other one.
3572
3573 2015-05-05  Myles C. Maxfield  <mmaxfield@apple.com>
3574
3575         Introducing the Platform Abstraction Layer (PAL)
3576         https://bugs.webkit.org/show_bug.cgi?id=143358
3577
3578         Reviewed by Simon Fraser.
3579
3580         * Scripts/build-webkit: Add it to build-webkit.
3581
3582 2015-05-06  Alex Christensen  <achristensen@webkit.org>
3583
3584         Fix api tests after r183877.
3585
3586         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3587         (TestWebKitAPI::TEST_F):
3588         Generate all DFAs before compiling them.
3589
3590 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
3591
3592         Do not link tools to WebKit2.framework
3593         https://bugs.webkit.org/show_bug.cgi?id=144699
3594
3595         Reviewed by Tim Horton.
3596
3597         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3598         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3599         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3600
3601 2015-05-06  Alex Christensen  <achristensen@webkit.org>
3602
3603         [Content Extensions] Test splitting NFAs by max NFA size.
3604         https://bugs.webkit.org/show_bug.cgi?id=144659
3605
3606         Reviewed by Darin Adler.
3607
3608         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3609         (TestWebKitAPI::createNFAs):
3610         (TestWebKitAPI::TEST_F):
3611         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
3612         (TestWebKitAPI::createNFAs):
3613
3614 2015-05-05  daegyu lee  <daegyu.lee@navercorp.com>
3615
3616         Remove the remaining vestiges of SVG feature define
3617         https://bugs.webkit.org/show_bug.cgi?id=144655
3618
3619         Reviewed by Alexey Proskuryakov.
3620
3621         * Scripts/webkitperl/FeatureList.pm:
3622
3623 2015-05-05  Timothy Horton  <timothy_horton@apple.com>
3624
3625         Add a layout mode for computing fixed layout size from a minimum size
3626         https://bugs.webkit.org/show_bug.cgi?id=144610
3627         <rdar://problem/19790341>
3628
3629         Reviewed by Simon Fraser.
3630
3631         * MiniBrowser/mac/BrowserWindow.xib:
3632         * MiniBrowser/mac/BrowserWindowController.h:
3633         * MiniBrowser/mac/WK1BrowserWindowController.m:
3634         (-[WK1BrowserWindowController toggleUseMinimumViewSize:]):
3635         * MiniBrowser/mac/WK2BrowserWindowController.m:
3636         (-[WK2BrowserWindowController toggleUseMinimumViewSize:]):
3637         Add a optional toolbar item to toggle a minimum view size of 1024x0.
3638
3639 2015-05-05  Alex Christensen  <achristensen@webkit.org>
3640
3641         [Content Extensions] Release input NSString when finished copying it.
3642         https://bugs.webkit.org/show_bug.cgi?id=144642
3643
3644         Reviewed by Brian Weinstein.
3645
3646         * WebKitTestRunner/mac/TestControllerMac.mm:
3647         (WTR::TestController::platformConfigureViewForTest):
3648         Use alloc and initWithContentsOfURL to prevent over-releasing an autoreleased object.
3649
3650 2015-05-05  Brent Fulgham  <bfulgham@apple.com>
3651
3652         Unreviewed test fix after r183798.
3653
3654         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3655         (convertToDRTLabel): Mimic behavior of Mac accessibility output
3656         so we can share results.
3657
3658 2015-05-05  Alex Christensen  <achristensen@webkit.org>
3659
3660         [Content Extensions] Use less memory to store the json input.