ccad61f083cf9e3a0d9afb447e9cc370383b9508
[WebKit-https.git] / Tools / ChangeLog
1 2012-11-05  Peter Beverloo  <peter@chromium.org>
2
3         The layout test runner shouldn't wait for data if stdout/stderr have been closed
4         https://bugs.webkit.org/show_bug.cgi?id=101233
5
6         Reviewed by Dirk Pranke.
7
8         Trying to read the file descriptor for the stdout or stderr pipes when DumpRenderTree
9         has crashed during a Chromium Android layout test-run, which uses FIFOs for
10         communication, causes the File.fileno() method to raise a ValueError. Return early
11         if either of the pipes has already been closed.
12
13         * Scripts/webkitpy/layout_tests/port/server_process.py:
14         (ServerProcess._wait_for_data_and_update_buffers_using_select):
15
16 2012-11-05  Dirk Pranke  <dpranke@chromium.org>
17
18         webkit-patch rebaseline is broken
19         https://bugs.webkit.org/show_bug.cgi?id=101235
20
21         Reviewed by Ojan Vafai.
22
23         It didn't get updated to handle the change in parsing --suffixes
24         properly, and the unit test didn't get updated either, masking the
25         problem.
26
27         * Scripts/webkitpy/tool/commands/rebaseline.py:
28         (Rebaseline._tests_to_update):
29         (Rebaseline.execute):
30         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
31         (TestRebaseline.test_rebaseline):
32
33 2012-11-05  Dirk Pranke  <dpranke@chromium.org>
34
35         lint-webkitpy doesn't autoinstall pylint properly.
36         https://bugs.webkit.org/show_bug.cgi?id=101106
37
38         Reviewed by Ojan Vafai.
39
40         Re-land r133381 with fix; ironically, lint-webkitpy would've
41         complained about the problem. Also modify pylintrc and clean up
42         any other lint errors in the modified files.
43
44         * Scripts/webkitpy/common/system/autoinstall.py:
45         (AutoInstaller._set_up_target_dir):
46         (AutoInstaller):
47         (AutoInstaller._make_package):
48         (AutoInstaller._create_scratch_directory):
49         (AutoInstaller._install):
50         (AutoInstaller.install):
51         * Scripts/webkitpy/pylintrc:
52         * Scripts/webkitpy/thirdparty/__init__.py:
53         (AutoinstallImportHook._ensure_autoinstalled_dir_is_in_sys_path):
54         (AutoinstallImportHook):
55         (AutoinstallImportHook.find_module):
56         (AutoinstallImportHook._install_pylint):
57         (AutoinstallImportHook._install_coverage):
58         (AutoinstallImportHook._install_eliza):
59         (AutoinstallImportHook._install_webpagereplay):
60         (AutoinstallImportHook._install):
61         * Scripts/webkitpy/thirdparty/__init___unittest.py:
62         (ThirdpartyTest.test_import_hook.MockImportHook.__init__):
63         (ThirdpartyTest.test_import_hook):
64         (ThirdpartyTest.test_imports):
65
66 2012-11-05  KyungTae Kim  <ktf.kim@samsung.com>
67
68         [EFL] Fix build warning in EWebLauncher/main.c
69         https://bugs.webkit.org/show_bug.cgi?id=101197
70
71         Reviewed by Kentaro Hara.
72
73         Because the strp of _Ecore_Getopt_Value is char** (Ecore_Getopt.h),
74         The parameter of ECORE_GETOPT_VALUE_STR should be char*
75
76         * EWebLauncher/main.c:
77         (_User_Arguments):
78
79 2012-11-05  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
80
81         [EFL][WK2] Add --window-size command line option to EFL MiniBrowser
82         https://bugs.webkit.org/show_bug.cgi?id=100942
83
84         Reviewed by Kenneth Rohde Christiansen.
85
86         Added window-size (-s) command line option to EFL MiniBrowser.
87
88         * MiniBrowser/efl/main.c:
89         (window_create):
90         (parse_window_size):
91         (elm_main):
92
93 2012-11-05  Christophe Dumez  <christophe.dumez@intel.com>
94
95         [EFL][WK2] The icon database path should be set by the client
96         https://bugs.webkit.org/show_bug.cgi?id=101182
97
98         Reviewed by Kenneth Rohde Christiansen.
99
100         Enable favicon database functionality in MiniBrowser since
101         it is used and it is no longer enabled by default.
102
103         * MiniBrowser/efl/main.c:
104         (elm_main):
105
106 2012-11-03  Balazs Kelemen  <kbalazs@webkit.org>
107
108         [Qt][WK2] setPlatformStrategies always asserts after r132744
109         https://bugs.webkit.org/show_bug.cgi?id=100838
110
111         Reviewed by Simon Hausmann.
112
113         Reland with build fixes.
114
115         Turned test runners to use the new QtTestSupport.
116
117         * DumpRenderTree/qt/DumpRenderTree.pro:
118         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
119         (main):
120         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
121         (WebCore::DumpRenderTree::open):
122         * DumpRenderTree/qt/QtInitializeTestFonts.h: Removed.
123         * MiniBrowser/qt/MiniBrowser.pro:
124         * QtTestBrowser/QtTestBrowser.pro:
125         * QtTestBrowser/qttestbrowser.cpp:
126         (LauncherApplication::handleUserOptions):
127         * WebKitTestRunner/InjectedBundle/Target.pri:
128         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
129         (WTR::activateFonts):
130         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Removed.
131         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Removed.
132         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
133         (WTR::TestRunner::platformInitialize):  Removed the comment from here
134         because it was just lying, apparently two times. First, it is not incorrect
135         to reinitialize our font set and clear font caches, it is what the tests
136         expect. Second, the use of QRawFont has nothing to do with the font cache.
137         * WebKitTestRunner/Target.pri:
138         * WebKitTestRunner/qt/main.cpp:
139         (main):
140
141 2012-11-04  Sheriff Bot  <webkit.review.bot@gmail.com>
142
143         Unreviewed, rolling out r133381.
144         http://trac.webkit.org/changeset/133381
145         https://bugs.webkit.org/show_bug.cgi?id=101161
146
147         It made webkit-patch useless (Requested by Ossy_weekend on
148         #webkit).
149
150         * Scripts/webkitpy/common/system/autoinstall.py:
151         (AutoInstaller._create_scratch_directory):
152         (AutoInstaller._install):
153         (AutoInstaller.install):
154         * Scripts/webkitpy/thirdparty/__init__.py:
155         (AutoinstallImportHook.__init__):
156         (AutoinstallImportHook._install_pylint):
157         (AutoinstallImportHook._install_coverage):
158         (AutoinstallImportHook._install_eliza):
159         (AutoinstallImportHook._install):
160         * Scripts/webkitpy/thirdparty/__init___unittest.py:
161         (ThirdpartyTest.test_import_hook.MockImportHook.__init__):
162         (ThirdpartyTest.test_import_hook):
163
164 2012-11-03  Sheriff Bot  <webkit.review.bot@gmail.com>
165
166         Unreviewed, rolling out r133403, r133404, and r133409.
167         http://trac.webkit.org/changeset/133403
168         http://trac.webkit.org/changeset/133404
169         http://trac.webkit.org/changeset/133409
170         https://bugs.webkit.org/show_bug.cgi?id=101158
171
172         "Broke tests" (Requested by kbalazs on #webkit).
173
174         * DumpRenderTree/qt/DumpRenderTree.pro:
175         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
176         (main):
177         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
178         (WebCore::DumpRenderTree::open):
179         * DumpRenderTree/qt/QtInitializeTestFonts.cpp: Renamed from Source/WebCore/platform/qt/QtTestSupport.cpp.
180         (WebKit):
181         (WebKit::initializeTestFonts):
182         * DumpRenderTree/qt/QtInitializeTestFonts.h: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
183         (WebKit):
184         * MiniBrowser/qt/MiniBrowser.pro:
185         * MiniBrowser/qt/MiniBrowserApplication.cpp:
186         (MiniBrowserApplication::handleUserOptions):
187         * QtTestBrowser/QtTestBrowser.pro:
188         * QtTestBrowser/qttestbrowser.cpp:
189         (LauncherApplication::handleUserOptions):
190         * WebKitTestRunner/InjectedBundle/Target.pri:
191         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
192         (WTR::activateFonts):
193         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
194         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
195         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
196         (WTR::TestRunner::platformInitialize):
197         * WebKitTestRunner/Target.pri:
198         * WebKitTestRunner/qt/main.cpp:
199         (main):
200
201 2012-11-03  Balazs Kelemen  <kbalazs@webkit.org>
202
203         [Qt][WK2] setPlatformStrategies always asserts after r132744
204         https://bugs.webkit.org/show_bug.cgi?id=100838
205
206         2nd unreviewed buildfix.
207
208         * MiniBrowser/qt/MiniBrowserApplication.cpp:
209
210 2012-11-03  Balazs Kelemen  <kbalazs@webkit.org>
211
212         [Qt][WK2] setPlatformStrategies always asserts after r132744
213         https://bugs.webkit.org/show_bug.cgi?id=100838
214
215         Unreviewed buildfix.
216
217         * WebKitTestRunner/Target.pri:
218
219 2012-11-03  Balazs Kelemen  <kbalazs@webkit.org>
220
221         [Qt][WK2] setPlatformStrategies always asserts after r132744
222         https://bugs.webkit.org/show_bug.cgi?id=100838
223
224         Reviewed by Simon Hausmann.
225
226         Reland with build fix.
227
228         Turned test runners to use the new QtTestSupport.
229
230         * DumpRenderTree/qt/DumpRenderTree.pro:
231         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
232         (main):
233         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
234         (WebCore::DumpRenderTree::open):
235         * DumpRenderTree/qt/QtInitializeTestFonts.h: Removed.
236         * MiniBrowser/qt/MiniBrowser.pro:
237         * QtTestBrowser/QtTestBrowser.pro:
238         * QtTestBrowser/qttestbrowser.cpp:
239         (LauncherApplication::handleUserOptions):
240         * WebKitTestRunner/InjectedBundle/Target.pri:
241         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
242         (WTR::activateFonts):
243         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Removed.
244         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Removed.
245         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
246         (WTR::TestRunner::platformInitialize):  Removed the comment from here
247         because it was just lying, apparently two times. First, it is not incorrect
248         to reinitialize our font set and clear font caches, it is what the tests
249         expect. Second, the use of QRawFont has nothing to do with the font cache.
250         * WebKitTestRunner/Target.pri:
251         * WebKitTestRunner/qt/main.cpp:
252         (main):
253
254 2012-11-03  Sheriff Bot  <webkit.review.bot@gmail.com>
255
256         Unreviewed, rolling out r133397.
257         http://trac.webkit.org/changeset/133397
258         https://bugs.webkit.org/show_bug.cgi?id=101155
259
260         "Broke Qt. No way to force the damn bots to do a clean build.
261         I'm giving up." (Requested by kbalazs on #webkit).
262
263         * DumpRenderTree/qt/DumpRenderTree.pro:
264         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
265         (main):
266         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
267         (WebCore::DumpRenderTree::open):
268         * DumpRenderTree/qt/QtInitializeTestFonts.cpp: Renamed from Source/WebCore/platform/qt/QtTestSupport.cpp.
269         (WebKit):
270         (WebKit::initializeTestFonts):
271         * DumpRenderTree/qt/QtInitializeTestFonts.h: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
272         (WebKit):
273         * QtTestBrowser/QtTestBrowser.pro:
274         * QtTestBrowser/qttestbrowser.cpp:
275         (LauncherApplication::handleUserOptions):
276         * WebKitTestRunner/InjectedBundle/Target.pri:
277         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
278         (WTR::activateFonts):
279         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
280         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
281         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
282         (WTR::TestRunner::platformInitialize):
283         * WebKitTestRunner/Target.pri:
284         * WebKitTestRunner/qt/main.cpp:
285         (main):
286
287 2012-11-03  Balazs Kelemen  <kbalazs@webkit.org>
288
289         [Qt][WK2] setPlatformStrategies always asserts after r132744
290         https://bugs.webkit.org/show_bug.cgi?id=100838
291
292         Reviewed by Simon Hausmann.
293
294         Turned test runners to use the new QtTestSupport.
295
296         * DumpRenderTree/qt/DumpRenderTree.pro:
297         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
298         (main):
299         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
300         (WebCore::DumpRenderTree::open):
301         * QtTestBrowser/QtTestBrowser.pro:
302         * QtTestBrowser/qttestbrowser.cpp:
303         (LauncherApplication::handleUserOptions):
304         * WebKitTestRunner/InjectedBundle/Target.pri:
305         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
306         (WTR::activateFonts):
307         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Removed.
308         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Removed.
309         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
310         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
311         (WTR::TestRunner::platformInitialize): Removed the comment from here
312         because it was just lying, apparently two times. First, it is not incorrect
313         to reinitialize our font set and clear font caches, it is what the tests
314         expect. Second, the use of QRawFont has nothing to do with the font cache.
315         * WebKitTestRunner/Target.pri:
316         * WebKitTestRunner/qt/main.cpp:
317         (main):
318
319 2012-11-02  Dirk Pranke  <dpranke@chromium.org>
320
321         webkit-patch rebaseline is broken
322         https://bugs.webkit.org/show_bug.cgi?id=101081
323
324         Reviewed by Ojan Vafai.
325
326         I broke this in r133061 and the unit tests weren't covering this
327         code path. Fixed the issue and the tests. --results-directory
328         doesn't make sense for either 'webkit-patch rebaseline' or
329         'webkit-patch rebaseline-expectations', so we don't want to expose
330         that as a command line option, but they all call a common
331         _rebaseline() routine that references options.results_directory,
332         so we need to set a default value.
333
334         * Scripts/webkitpy/tool/commands/rebaseline.py:
335         (RebaselineExpectations.execute):
336         (Rebaseline.execute):
337         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
338         (TestRebaseline):
339         (TestRebaseline.test_rebaseline):
340
341 2012-11-02  Dirk Pranke  <dpranke@chromium.org>
342
343         lint-webkitpy doesn't autoinstall pylint properly
344         https://bugs.webkit.org/show_bug.cgi?id=101106
345
346         Reviewed by Ojan Vafai.
347
348         Turns out the autoinstalling code for pylint didn't install
349         pylint's dependencies, and the autoinstaller code didn't work
350         using nested directories (e.g., "logilab/astng"). Fix those issues,
351         clean up the autoinstaller code, and add tests to make sure everything
352         imports successfully.
353
354         * Scripts/webkitpy/common/system/autoinstall.py:
355         (AutoInstaller._create_scratch_directory):
356         (AutoInstaller._install):
357         (AutoInstaller.install):
358         * Scripts/webkitpy/thirdparty/__init__.py:
359         (AutoinstallImportHook._ensure_autoinstalled_dir_is_in_sys_path):
360         (AutoinstallImportHook._install_pylint):
361         (AutoinstallImportHook._install_coverage):
362         (AutoinstallImportHook._install_eliza):
363         (AutoinstallImportHook._install):
364         * Scripts/webkitpy/thirdparty/__init___unittest.py:
365         (ThirdpartyTest.test_import_hook.MockImportHook.__init__):
366         (ThirdpartyTest.test_import_hook):
367         (ThirdpartyTest.test_imports):
368
369 2012-11-02  Dirk Pranke  <dpranke@chromium.org>
370
371         nrwt prints an awkward result message for missing results
372         https://bugs.webkit.org/show_bug.cgi?id=100915
373
374         Reviewed by Ojan Vafai.
375
376         Completely rework how we print out the description of
377         each tests's result - we now will print either "passed" or "failed",
378         followed by " unexpectedly" if we weren't expecting the result,
379         followed by a short description of each type of failure that happened
380         (in parentheses). Also reworked the description of each type of
381         failure slightly to be clearer.
382
383         Also rework the tests to make sure we have coverage of all of the
384         messages. Examples of the new output are posted as an attachment to
385         the bug.
386
387         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
388         (TestExpectations):
389         * Scripts/webkitpy/layout_tests/models/test_failures.py:
390         (FailureTimeout.message):
391         (FailureMissingResult.message):
392         (FailureTextMismatch.message):
393         (FailureMissingImageHash.message):
394         (FailureMissingImage.message):
395         (FailureImageHashMismatch.message):
396         (FailureImageHashIncorrect.message):
397         (FailureReftestMismatch.message):
398         (FailureReftestMismatchDidNotOccur.message):
399         (FailureReftestNoImagesGenerated.message):
400         (FailureMissingAudio.message):
401         (FailureAudioMismatch.message):
402         (FailureEarlyExit.message):
403         * Scripts/webkitpy/layout_tests/port/test.py:
404         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
405         (MainTest.test_run_singly_actually_runs_tests):
406         (MainTest.test_missing_and_unexpected_results):
407         * Scripts/webkitpy/layout_tests/views/printing.py:
408         (Printer._print_result_summary_entry):
409         (Printer.print_finished_test):
410         (Printer._result_message):
411         (Printer._print_unexpected_results):
412         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
413         * Scripts/webkitpy/tool/commands/queues_unittest.py:
414
415 2012-11-02  Dirk Pranke  <dpranke@chromium.org>
416
417         webkitpy: clean up logging in common.system.autoinstall
418         https://bugs.webkit.org/show_bug.cgi?id=101090
419
420         Reviewed by Ojan Vafai.
421
422         This module logged way too much, much of which was logging that
423         was either really redundant or useful only during initial development.
424         This patch deletes a lot of code and tweaks the remaining log messages
425         to be more useful now.
426
427         Also, clean up a bunch of lint errors and warnings.
428
429         * Scripts/webkitpy/common/system/autoinstall.py:
430         (AutoInstaller.__init__):
431         (AutoInstaller._write_file):
432         (AutoInstaller._set_up_target_dir):
433         (AutoInstaller._create_scratch_directory):
434         (AutoInstaller._url_downloaded_path):
435         (AutoInstaller._is_downloaded):
436         (AutoInstaller._record_url_downloaded):
437         (AutoInstaller._extract_targz):
438         (AutoInstaller._extract_all):
439         (AutoInstaller._unzip):
440         (AutoInstaller._download_to_stream):
441         (AutoInstaller._download):
442         (AutoInstaller._install):
443         (AutoInstaller.install):
444
445 2012-11-02  Dirk Pranke  <dpranke@chromium.org>
446
447         webkit-patch analyze-baselines output is weak
448         https://bugs.webkit.org/show_bug.cgi?id=100998
449
450         Reviewed by Ojan Vafai.
451
452         Currently analyze-baselines prints a list of baselines that have
453         the same checksum per line, but the format is hard to read;
454         this patch cleans up the output to print by directory instead
455         and use the same format I recently added for debugging optimize-baselines,
456         then refactors the code so that we share and adds tests for
457         analyze-baselines (which was untested).
458
459         Also, I got rid of a couple of unnecessarily-hardcoded port names,
460         and modified the baseline optimizer to log the current world when
461         optimize fails.
462
463         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
464         (BaselineOptimizer.read_results_by_directory):
465         (BaselineOptimizer.write_by_directory):
466         (BaselineOptimizer.optimize):
467         * Scripts/webkitpy/tool/commands/rebaseline.py:
468         (OptimizeBaselines.execute):
469         (AnalyzeBaselines.__init__):
470         (AnalyzeBaselines._write):
471         (AnalyzeBaselines._analyze_baseline):
472         (AnalyzeBaselines.execute):
473         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
474         (_FakeOptimizer):
475         (_FakeOptimizer.read_results_by_directory):
476         (TestAnalyzeBaselines):
477         (TestAnalyzeBaselines.setUp):
478         (TestAnalyzeBaselines.test_default):
479         (TestAnalyzeBaselines.test_missing_baselines):
480
481 2012-11-02  Adam Barth  <abarth@webkit.org>
482
483         ENABLE(UNDO_MANAGER) is disabled everywhere and is not under active development
484         https://bugs.webkit.org/show_bug.cgi?id=100711
485
486         Reviewed by Eric Seidel.
487
488         * Scripts/webkitperl/FeatureList.pm:
489         * qmake/mkspecs/features/features.pri:
490
491 2012-11-02  Sheriff Bot  <webkit.review.bot@gmail.com>
492
493         Unreviewed, rolling out r133303.
494         http://trac.webkit.org/changeset/133303
495         https://bugs.webkit.org/show_bug.cgi?id=101068
496
497         "Broke qt wk2 build (seems like bots fails to rerun qmake if
498         needed)" (Requested by kbalazs on #webkit).
499
500         * DumpRenderTree/qt/DumpRenderTree.pro:
501         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
502         (main):
503         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
504         (WebCore::DumpRenderTree::open):
505         * DumpRenderTree/qt/QtInitializeTestFonts.cpp: Renamed from Source/WebCore/platform/qt/QtTestSupport.cpp.
506         (WebKit):
507         (WebKit::initializeTestFonts):
508         * DumpRenderTree/qt/QtInitializeTestFonts.h: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
509         (WebKit):
510         * QtTestBrowser/QtTestBrowser.pro:
511         * QtTestBrowser/qttestbrowser.cpp:
512         (LauncherApplication::handleUserOptions):
513         * WebKitTestRunner/InjectedBundle/Target.pri:
514         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
515         (WTR::activateFonts):
516         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
517         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
518         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
519         (WTR::TestRunner::platformInitialize):
520         * WebKitTestRunner/Target.pri:
521         * WebKitTestRunner/qt/main.cpp:
522         (main):
523
524 2012-11-02  Balazs Kelemen  <kbalazs@webkit.org>
525
526         [Qt][WK2] setPlatformStrategies always asserts after r132744
527         https://bugs.webkit.org/show_bug.cgi?id=100838
528
529         Reviewed by Simon Hausmann.
530
531         Turned test runners to use the new QtTestSupport.
532
533         * DumpRenderTree/qt/DumpRenderTree.pro:
534         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
535         (main):
536         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
537         (WebCore::DumpRenderTree::open):
538         * QtTestBrowser/QtTestBrowser.pro:
539         * QtTestBrowser/qttestbrowser.cpp:
540         (LauncherApplication::handleUserOptions):
541         * WebKitTestRunner/InjectedBundle/Target.pri:
542         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
543         (WTR::activateFonts):
544         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Removed.
545         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Removed.
546         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
547         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
548         (WTR::TestRunner::platformInitialize): Removed the comment from here
549         because it was just lying, apparently two times. First, it is not incorrect
550         to reinitialize our font set and clear font caches, it is what the tests
551         expect. Second, the use of QRawFont has nothing to do with the font cache.
552         * WebKitTestRunner/Target.pri:
553         * WebKitTestRunner/qt/main.cpp:
554         (main):
555
556 2012-11-02  Peter Beverloo  <peter@chromium.org>
557
558         Output Android's device status before running tests on the bots
559         https://bugs.webkit.org/show_bug.cgi?id=100944
560
561         Reviewed by Dirk Pranke.
562
563         This adds a new step to the build master which will be run prior to the
564         actual tests-suites on the Chromium Android tester, and soon the Chromium
565         Android Perf bot. For each attached device, it outputs the build
566         information, battery level, battery temperature and username.
567
568         The Android tester currently is very flaky, and this will help tremendously
569         in being able to figure out what's wrong with the bot.
570
571         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
572         (OutputAndroidDeviceStatus):
573         (TestFactory.__init__):
574         * BuildSlaveSupport/chromium/output-android-device-status: Added.
575         (GetAttachedDevices):
576         (AndroidDeviceStatus):
577         (AndroidDeviceStatus.__init__):
578         (AndroidDeviceStatus._run_adb_command):
579         (AndroidDeviceStatus.device_type):
580         (AndroidDeviceStatus.device_build):
581         (AndroidDeviceStatus.device_fingerprint):
582         (AndroidDeviceStatus.battery_level):
583         (AndroidDeviceStatus.battery_temperature):
584         (AndroidDeviceStatus.username):
585         (main):
586
587 2012-11-02  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
588
589         [Qt] WTR: Make sure that eventSender.mouseDown sends a press event for the second press
590         https://bugs.webkit.org/show_bug.cgi?id=101033
591
592         Reviewed by Simon Hausmann.
593
594         eventSender.mouseDown doesn't work properly since r133153 where
595         MouseButtonDblClick events aren't interpreted as Press events anymore.
596         The problem is that mouseDown sends a DblClick event instead of a Press,
597         while the correct way is to send both events.
598
599         Since QQuickWebView isn't doing anything with DblClick events anymore,
600         simply send Press events all the time and let WebCore figure out
601         where the double clicks are.
602
603         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
604         (WTR::EventSenderProxy::updateClickCountForButton):
605         (WTR::EventSenderProxy::mouseDown):
606
607 2012-11-02  Christophe Dumez  <christophe.dumez@intel.com>
608
609         [EFL][WK2] Add HTTP authentication support to MiniBrowser
610         https://bugs.webkit.org/show_bug.cgi?id=100953
611
612         Reviewed by Kenneth Rohde Christiansen.
613
614         Add HTTP authentication support to MiniBrowser. An authentication
615         dialog now pops up to ask the user for credentials whenever
616         a Web site requires authentication.
617
618         * MiniBrowser/efl/main.c:
619         (auth_popup_close):
620         (on_auth_cancel):
621         (on_auth_ok):
622         (on_authentication_request):
623         (window_create):
624
625 2012-11-01  Yury Semikhatsky  <yurys@chromium.org>
626
627         Memory instrumentation: do not call checkCountedObject with wrong pointers
628         https://bugs.webkit.org/show_bug.cgi?id=100958
629
630         Reviewed by Alexander Pavlov.
631
632         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp: test that if there
633         if there is class A derived from classes B and C and we have pointer B* to an
634         object of class A then MemoryInstrumentationClient::checkoutCountedObject won't
635         be called for B* but only for A*
636
637         Also MemoryInstrumentation implementation used in the test was refactored to
638         allow passing client as a parameter. The client implementation was extracted into
639         a top-level class MemoryInstrumentationTestClient.
640
641 2012-11-01  Christophe Dumez  <christophe.dumez@intel.com>
642
643         [EFL][WK2] Make File Chooser dialog modal in MiniBrowser
644         https://bugs.webkit.org/show_bug.cgi?id=100962
645
646         Reviewed by Gyuyoung Kim.
647
648         Make File Chooser dialog modal in MiniBrowser and make
649         sure it is closed and freed when its parent window is
650         closed.
651
652         * MiniBrowser/efl/main.c:
653         (close_file_picker):
654         (on_filepicker_parent_deletion):
655         (on_file_chooser_request):
656
657 2012-11-01  Seonae Kim  <sunaeluv.kim@samsung.com>
658
659         [EFL][DRT] Support Geolocation
660         https://bugs.webkit.org/show_bug.cgi?id=97427
661
662         Reviewed by Gyuyoung Kim. 
663
664         Implement methods to use GeolocationClientMock in DumpRenderTree.
665         This client attaches to the page whenever a view is created.
666
667         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
668         (DumpRenderTreeChrome::createView):
669         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
670         * DumpRenderTree/efl/TestRunnerEfl.cpp:
671         (TestRunner::setMockGeolocationPosition):
672         (TestRunner::setMockGeolocationPositionUnavailableError):
673         (TestRunner::setGeolocationPermission):
674         (TestRunner::numberOfPendingGeolocationPermissionRequests):
675
676 2012-11-01  Ryosuke Niwa  <rniwa@webkit.org>
677
678         Remove tests no longer needed after r133229.
679
680         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
681         (TestPerfTestFactory.test_inspector_test):
682         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
683         (test_collect_tests_with_skipped_list):
684
685 2012-11-01  Nico Weber  <thakis@chromium.org>
686
687         [chromium] Try to find ninja if it's not in the path already
688         https://bugs.webkit.org/show_bug.cgi?id=100988
689
690         Reviewed by Ryosuke Niwa.
691
692         Similar to the gclient detection logic in update-webkit-chromium
693
694         * Scripts/webkitdirs.pm:
695         (buildChromiumNinja):
696
697 2012-11-01  Eric Seidel  <eric@webkit.org>
698
699         Add Glenn Adams to the Contributor list
700         https://bugs.webkit.org/show_bug.cgi?id=100982
701
702         Reviewed by Adam Barth.
703
704         I CC him enough on bugs it would help me to have him listed here.
705
706         * Scripts/webkitpy/common/config/committers.py:
707
708 2012-11-01  Jer Noble  <jer.noble@apple.com>
709
710         Add Python-LLDB support for WTF::Vector types.
711         https://bugs.webkit.org/show_bug.cgi?id=100980
712
713         Reviewed by Anders Carlsson.
714
715         Add a synthetic child provider for WTF::Vector types.
716
717         * lldb/lldb_webkit.py:
718         (__lldb_init_module): Add both the summary and synthetic providers for WTF::Vector
719         (WTFVector_SummaryProvider): Wrapper around WTFVectorProvider
720         (WTFVectorProvider):
721         (WTFVectorProvider.__init__):
722         (WTFVectorProvider.num_children): Return m_size+2 children to account for synthesized children.
723         (WTFVectorProvider.get_child_index): Synthesize child indexes for each entry in the Vector.
724         (WTFVectorProvider.get_child_at_index): Synthesize children for each entry in the Vector.
725         (WTFVectorProvider.update): Retrieve state from the underlying Vector.
726         (WTFVectorProvider.has_children): Vectors always have children.
727
728 2012-11-01  Zoltan Horvath  <zoltan@webkit.org>
729
730         Remove PageLoad directory entry from PerformanceTests pattern_map
731         https://bugs.webkit.org/show_bug.cgi?id=100989
732
733         Reviewed by Ryosuke Niwa.
734
735         Since we removed PageLoad directory from PerformanceTests we don't need this entry in pattern_map.
736
737         * Scripts/webkitpy/performance_tests/perftest.py:
738         (PerfTestFactory):
739
740 2012-11-01  Jer Noble  <jer.noble@apple.com>
741
742         Add LLDB-Python scripts to support WebKit data types.
743         https://bugs.webkit.org/show_bug.cgi?id=100898
744
745         Reviewed by Anders Carlsson.
746
747         Add Summary providers for common WebKit string types.
748
749         * lldb/lldb_webkit.py: Added.
750         (__lldb_init_module): Register these providers with the debugger.
751         (WTFString_SummaryProvider): Wrapper around WTFStringProvider.
752         (WTFStringImpl_SummaryProvider): Wrapper around WTFStringImplProvider.
753         (WTFAtomicString_SummaryProvider): Ditto.
754         (guess_string_length): Walk through the string looking for a null-byte(s).
755         (ustring_to_string): Walk through the string, extracting two-byte values, and concatenate them.
756         (lstring_to_string): Walk through the string, extracting byte values, and concatenate them.
757         (WTFStringImplProvider): 
758         (WTFStringImplProvider.__init__):
759         (WTFStringImplProvider.get_length): Extract the m_length variable.
760         (WTFStringImplProvider.get_data8): Extract the m_data8 variable.
761         (WTFStringImplProvider.get_data16): Extract the m_data16 variable.
762         (WTFStringImplProvider.to_string): Pass the appropriate data variable to {u,l}string_to_string.
763         (WTFStringImplProvider.is_8bit): Check the m_hashAndFlags variable.
764         (WTFStringProvider):
765         (WTFStringProvider.__init__):
766         (WTFStringProvider.stringimpl): Extract the m_impl variable.
767         (WTFStringProvider.get_length): Pass through to WTFStringImplProvider.
768         (WTFStringProvider.to_string): Ditto.
769
770 2012-11-01  Peter Beverloo  <peter@chromium.org>
771
772         [Chromium-Android] Apache doesn't properly clean up ipc semaphores after a layout test run
773         https://bugs.webkit.org/show_bug.cgi?id=100950
774
775         Reviewed by Dirk Pranke.
776
777         When a test run would fail to complete due to an exception in one of
778         the workers, the HTTP server wouldn't get a chance to gracefully shut
779         down. This caused too much IPC semaphores to be left on the server,
780         causing Apache to fail to start in subsequent runs.
781
782         By unifying the Android-specific code with other ports, we no longer
783         fail to call the ChromiumPort/Base setup_test_run() and clean_up_test_run()
784         methods either. Furthermore, the number_of_servers argument for starting
785         the HTTP server is now available as well.
786
787         Because not all tests require an HTTP server, it's not guaranteed that
788         it will be started. Android depends on this, so add a new method to Port
789         and override it for Android: requires_http_server().
790
791         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
792         (LayoutTestRunner.run_tests):
793         * Scripts/webkitpy/layout_tests/controllers/manager.py:
794         (Manager._run_tests):
795         * Scripts/webkitpy/layout_tests/port/base.py:
796         (Port.to.requires_http_server):
797         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
798         (PortTest.test_dont_require_http_server):
799         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
800         (ChromiumAndroidPort.requires_http_server):
801         (ChromiumAndroidPort.start_http_server):
802         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
803         (ChromiumAndroidPortTest.test_must_require_http_server):
804
805 2012-11-01  Adam Roben  <aroben@webkit.org>
806
807         Crash beneath WKRelease after failed load in MiniBrowser
808         https://bugs.webkit.org/show_bug.cgi?id=100954
809
810         Reviewed by Sam Weinig.
811
812         There were just some simple retain/release bugs.
813
814         * MiniBrowser/mac/WK2BrowserWindowController.m:
815         (-[WK2BrowserWindowController updateTextFieldFromURL:]):
816         (-[WK2BrowserWindowController updateProvisionalURLForFrame:]):
817         Don't try to release null URLs.
818
819         (-[WK2BrowserWindowController updateCommittedURLForFrame:]): Don't
820         release a URL for which we don't have ownership.
821
822 2012-10-31  Rob Buis  <rbuis@rim.com>
823
824         [BlackBerry] Fix editing/text-iterator/findString-expected.html fail
825         https://bugs.webkit.org/show_bug.cgi?id=100902
826
827         Reviewed by Yong Li.
828
829         PR 210039
830
831         Fix the test my using the Page::findString method instead of our own in-page searcher.
832         This also syncs some of the changes we did regarding String usage.
833
834         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
835         (BlackBerry::WebKit::DumpRenderTree::dumpFramesAsText):
836         (BlackBerry::WebKit::dumpHistoryItem):
837         (BlackBerry::WebKit::dumpBackForwardListForWebView):
838         (BlackBerry::WebKit::DumpRenderTree::dump):
839         (BlackBerry::WebKit::DumpRenderTree::didFinishDocumentLoadForFrame):
840         (BlackBerry::WebKit::DumpRenderTree::didReceiveTitleForFrame):
841         (BlackBerry::WebKit::DumpRenderTree::runJavaScriptAlert):
842         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
843         (DumpRenderTree):
844         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
845         (TestRunner::setMockGeolocationError):
846         (TestRunner::layerTreeAsText):
847         (TestRunner::findString):
848         (TestRunner::setStorageDatabaseIdleInterval):
849
850 2012-11-01  Christophe Dumez  <christophe.dumez@intel.com>
851
852         [EFL][WK2] Add File Chooser dialog support to MiniBrowser
853         https://bugs.webkit.org/show_bug.cgi?id=100822
854
855         Reviewed by Kenneth Rohde Christiansen.
856
857         Add very basic file picker dialog to MiniBrowser so that
858         the user can select a file from the file system when
859         clicking an input element of type "file".
860
861         * MiniBrowser/efl/main.c:
862         (close_file_picker):
863         (on_filepicker_deletion):
864         (on_fileselector_done):
865         (on_file_chooser_request):
866         (window_create):
867
868 2012-11-01  Yael Aharon  <yael.aharon@intel.com>
869
870         Unreviewed. Change my email address.
871
872         * Scripts/webkitpy/common/config/committers.py:
873
874 2012-11-01  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
875
876         [Qt] Double clicks/taps aren't passed down to the page
877         https://bugs.webkit.org/show_bug.cgi?id=100949
878
879         Reviewed by Kenneth Rohde Christiansen.
880
881         Touch mocking shouldn't transform double click events as well,
882         this adds an extra touch update between clicks which prevents
883         double-tap detection from triggering on web pages.
884
885         Tested on the mobile version of Google maps.
886
887         * MiniBrowser/qt/MiniBrowserApplication.cpp:
888         (MiniBrowserApplication::notify):
889
890 2012-10-31  Dirk Pranke  <dpranke@chromium.org>
891
892         NRWT: lint warnings don't show up by default
893         https://bugs.webkit.org/show_bug.cgi?id=100914
894
895         Reviewed by Ryosuke Niwa.
896
897         NRWT wasn't printing any warnings if you had errors in your
898         TestExpectations files; this means you would only notice this
899         with --lint-test-files, which is probably bad. I'm not sure
900         when this requested, but perhaps when we changed the
901         warnings to not be fatal if you weren't linting the files.
902
903         Now they're still not fatal, but at least we print them.
904
905         Also fix one warning message where we were printing the test name twice.
906
907         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
908         (TestExpectationsModel._already_seen_better_match):
909         (TestExpectations._report_warnings):
910         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
911         (MiscTests.test_parse_warnings_are_logged_if_not_in_lint_mode(self): Added.
912
913 2012-10-31  Terry Anderson  <tdanderson@chromium.org>
914
915         Missing stderr output when using run-webkit-tests
916         https://bugs.webkit.org/show_bug.cgi?id=100709
917
918         Reviewed by Dirk Pranke.
919
920         Appends #EOF to the end of the stderr output only at the end of a test,
921         not possibly part-way through. This will allow all of the stderr output 
922         to appear on the results page after running run-webkit-tests.
923
924         * DumpRenderTree/chromium/TestEventPrinter.cpp:
925         (TestEventPrinter::handleTextFooter):
926         (TestEventPrinter::handleTestFooter):
927
928 2012-10-30  Mark Lam  <mark.lam@apple.com>
929
930         A JSC printf (support for %J+s and %b).
931         https://bugs.webkit.org/show_bug.cgi?id=100566.
932
933         Reviewed by Michael Saboff.
934
935         Added regression tests for VMInspector::fprintf() sprintf() and snprintf().
936
937         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
938         * TestWebKitAPI/Tests/JavaScriptCore: Added.
939         * TestWebKitAPI/Tests/JavaScriptCore/VMInspector.cpp: Added.
940
941 2012-10-31  Thiago Marcos P. Santos  <thiago.santos@intel.com>
942
943         Added viewport at-rule to the CSS parser and tokenizer
944         https://bugs.webkit.org/show_bug.cgi?id=95961
945
946         Reviewed by Kenneth Rohde Christiansen.
947
948         Enable CSS Device Adaptation by default on EFL.
949
950         * Scripts/webkitperl/FeatureList.pm:
951
952 2012-10-31  Terry Anderson  <tdanderson@chromium.org>
953
954         [touchadjustment] touch-links-two-finger-tap test pass incorrectly
955         https://bugs.webkit.org/show_bug.cgi?id=100619
956
957         Reviewed by Antonio Gomes.
958
959         Store the touch area when sending a GestureTwoFingerTap event.
960
961         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
962         (WebTestRunner):
963         (WebTestRunner::EventSender::gestureEvent):
964
965 2012-10-31  Dirk Pranke  <dpranke@chromium.org>
966
967         nrwt is not killing stuck DRTs on chromium win
968         https://bugs.webkit.org/show_bug.cgi?id=100886
969
970         Unreviewed, build fix.
971
972         In the original implementation of NRWT for Chromium, we used
973         to assume that DRT would always manage to exit on its own and
974         so NRWT wouldn't attempt to kill DRT if it was stuck (this was the
975         "hung worker" problem, and meant that if DRT hung, NRWT would hang).
976
977         Eventually, we merged the chromium code with the other ports and
978         now will always try to shut down DRTs if a test times out, but as
979         part of that merge we left in a code path where we wouldn't
980         shut the driver down on windows. This was resulting in stray
981         DRTs being left around, and NRWT sometimes not exiting cleanly as
982         a result.
983
984         No unit tests added because this was a windows-only code path (hence
985         hard to test) and that is now gone.
986
987         * Scripts/webkitpy/layout_tests/port/server_process.py:
988         (ServerProcess.stop):
989
990 2012-10-31  Ami Fischman  <fischman@chromium.org>
991
992         [chromium] DRT and WTR should clear the cache between tests
993         https://bugs.webkit.org/show_bug.cgi?id=93195
994
995         Reviewed by Tony Chang.
996
997         This change makes chromium DRT match the GTK+, Qt, and EFL ports.
998
999         * DumpRenderTree/chromium/TestShell.cpp:
1000         (TestShell::resetTestController): added a WebCache::clear() call to achieve the goal of the bug.
1001
1002 2012-10-31  Dirk Pranke  <dpranke@chromium.org>
1003
1004         Fix typos introduced in r133061.
1005         Unreviewed, build fix.
1006
1007         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1008         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
1009         (ReflectionHandler._serve_file):
1010
1011 2012-10-31  Dirk Pranke  <dpranke@chromium.org>
1012
1013         garden-o-matic should work for local results
1014         https://bugs.webkit.org/show_bug.cgi?id=100805
1015
1016         Reviewed by Adam Barth.
1017
1018         This is the next step in making garden-o-matic replace
1019         'webkit-patch rebaseline-server' and be able to deal with local
1020         results. garden-o-matic now accepts a '--results-directory' option
1021         that will point to a layout-test-results directory. At the moment
1022         this will only work if you are also filtering to a single bot/
1023         platform at a time (we can't handle multiple bots' worth of local
1024         results, but that is a logical next step).
1025
1026         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1027         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1028         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1029         * Scripts/webkitpy/tool/commands/gardenomatic.py:
1030         (GardenOMatic.__init__):
1031         (GardenOMatic.execute):
1032         * Scripts/webkitpy/tool/commands/rebaseline.py:
1033         (AbstractRebaseliningCommand):
1034         (RebaselineTest.__init__):
1035         (RebaselineTest._rebaseline_test):
1036         (RebaselineTest._rebaseline_test_and_update_expectations):
1037         (RebaselineTest.execute):
1038         (AbstractParallelRebaselineCommand._rebaseline_commands):
1039         (AbstractParallelRebaselineCommand._rebaseline):
1040         (RebaselineJson.__init__):
1041         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1042         (_BaseTestCase):
1043         (test_rebaseline_updates_expectations_file):
1044         (test_rebaseline_does_not_include_overrides):
1045         (test_rebaseline_test):
1046         (test_rebaseline_test_and_print_scm_changes):
1047         (test_rebaseline_and_copy_test):
1048         (test_rebaseline_and_copy_test_no_existing_result):
1049         (test_rebaseline_and_copy_test_with_lion_result):
1050         (test_rebaseline_and_copy_no_overwrite_test):
1051         (test_rebaseline_test_internal_with_move_overwritten_baselines_to):
1052         (TestRebaselineJson.test_rebaseline_all):
1053         (TestRebaselineJson.test_rebaseline_debug):
1054         (TestRebaselineJson.test_move_overwritten):
1055         (TestRebaselineJson.test_no_optimize):
1056         (TestRebaselineExpectations.test_rebaseline_expectations):
1057         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1058         (GardeningHTTPRequestHandler.rebaselineall):
1059         (GardeningHTTPRequestHandler):
1060         (GardeningHTTPRequestHandler.localresult):
1061         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
1062         (ReflectionHandler.do_POST):
1063         (ReflectionHandler):
1064         (ReflectionHandler.do_HEAD):
1065
1066 2012-10-31  Dirk Pranke  <dpranke@chromium.org>
1067
1068         garden-o-matic should support gardening a single port and specifying how to deal with overwritten baselines
1069         https://bugs.webkit.org/show_bug.cgi?id=100563
1070
1071         Reviewed by Ojan Vafai.
1072
1073         This patch starts the process of making garden-o-matic more useful for
1074         bringing up a single new port in two ways. The goal is to fully
1075         obsolete webkit-patch rebaseline-server.
1076         
1077         First, it adds support for the --platform arguments to garden-o-matic
1078         (so that the UI will default to the right cluster of bots), and if the platform arg
1079         specifies a single bot, filters the results down to just that bot.
1080
1081         Second, it adds support for --move-overwritten-baselines and changes
1082         the implementation of the move_overwritten_baselines setting in builders.py
1083         so that it is only used if this flag is provided.
1084
1085         Future patches will make it possible to use local copies of the build
1086         results (rather than going to the bots) and other optimizations to make
1087         it faster to review lots of changes on a single bot.
1088
1089         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1090         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1091         (.):
1092         * Scripts/webkitpy/layout_tests/port/builders.py:
1093         * Scripts/webkitpy/tool/commands/gardenomatic.py:
1094         (GardenOMatic):
1095         (GardenOMatic.execute):
1096         * Scripts/webkitpy/tool/commands/rebaseline.py:
1097         (AbstractRebaseliningCommand):
1098         (AbstractRebaseliningCommand.__init__):
1099         (RebaselineTest):
1100         (OptimizeBaselines):
1101         (AnalyzeBaselines):
1102         (AbstractParallelRebaselineCommand):
1103         (AbstractParallelRebaselineCommand._rebaseline_commands):
1104         (AbstractParallelRebaselineCommand._rebaseline):
1105         (Rebaseline.__init__):
1106         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1107         (GardeningHTTPServer.url):
1108         (GardeningHTTPRequestHandler.rebaselineall):
1109
1110 2012-10-31  Dirk Pranke  <dpranke@chromium.org>
1111
1112         test-webkitpy: fix running modules and classes on the command line
1113         https://bugs.webkit.org/show_bug.cgi?id=100787
1114
1115         Reviewed by Eric Seidel.
1116
1117         Handling modules and classes are arguments on the command line
1118         was broken due to the way we were parsing test names looking for
1119         parallel and serial tests.
1120
1121         * Scripts/webkitpy/test/main.py:
1122         (Tester._test_names):
1123         (_Loader):
1124         * Scripts/webkitpy/test/main_unittest.py:
1125         (TestStubs.integration_test_empty):
1126         (TestStubs):
1127         (TestStubs.serial_test_empty):
1128         (TestStubs.serial_integration_test_empty):
1129         (TesterTest._find_test_names):
1130         (TesterTest):
1131         (TesterTest.test_individual_names_are_not_run_twice):
1132         (TesterTest.test_integration_tests_are_not_found_by_default):
1133         (TesterTest.test_integration_tests_are_found):
1134
1135 2012-10-31  Dirk Pranke  <dpranke@chromium.org>
1136
1137         webkitpy: refactor common command line arguments for --platform, rebaseline commands
1138         https://bugs.webkit.org/show_bug.cgi?id=100800
1139
1140         Reviewed by Ojan Vafai.
1141
1142         This change shuffles around how we share command-line options
1143         between NRWT and the various webkit-patch rebaselining commands.
1144
1145         There are no functional changes in this patch but it should make
1146         things clearer and will be useful in a couple of upcoming patches.
1147
1148         * Scripts/webkitpy/layout_tests/port/__init__.py:
1149         * Scripts/webkitpy/layout_tests/port/factory.py:
1150         (platform_options):
1151         (configuration_options):
1152         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1153         (parse_args):
1154         * Scripts/webkitpy/tool/commands/queries.py:
1155         (PrintExpectations.__init__):
1156         (PrintBaselines.__init__):
1157         * Scripts/webkitpy/tool/commands/rebaseline.py:
1158         (AbstractRebaseliningCommand):
1159         (AbstractRebaseliningCommand.__init__):
1160         (RebaselineTest.__init__):
1161         (OptimizeBaselines.__init__):
1162         (AnalyzeBaselines.__init__):
1163         (AbstractParallelRebaselineCommand):
1164         (RebaselineJson.__init__):
1165         (RebaselineExpectations.__init__):
1166         (Rebaseline.__init__):
1167
1168 2012-10-31  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1169
1170         [NRWT] Xvfb driver is leaking application cache files
1171         https://bugs.webkit.org/show_bug.cgi?id=100864
1172
1173         Reviewed by Kenneth Rohde Christiansen.
1174
1175         Application Cache looks for XDG_CACHE_HOME which is now
1176         prepended with DUMPRENDERTREE_TEMP and cleaned up when
1177         the test worker finishes his job.
1178
1179         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
1180         (XvfbDriver._start):
1181
1182 2012-10-31  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1183
1184         [EFL] DRT doesn't clean up after itself
1185         https://bugs.webkit.org/show_bug.cgi?id=100346
1186
1187         Reviewed by Kenneth Rohde Christiansen.
1188
1189         The test driver exports an environment variable DUMPRENDERTREE_TEMP
1190         which is used by both DRT and WTR as the folder for storing icons,
1191         databases, application cache, etc, overriding the default XDG_* path.
1192
1193         We don't need to create these folders because in fact, they are never
1194         used and also never cleaned. Things created inside DUMPRENDERTREE_TEMP
1195         are automatically removed after the test run.
1196
1197         * Scripts/webkitpy/layout_tests/port/efl.py:
1198         (EflPort.setup_environ_for_server):
1199
1200 2012-10-31  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1201
1202         [WTR] WebKitTestRunner is not cleaning up the icon database
1203         https://bugs.webkit.org/show_bug.cgi?id=100678
1204
1205         Reviewed by Kenneth Rohde Christiansen.
1206
1207         The icon database was not being set to the temporary folder created for
1208         the test runner by the test driver, which is removed automatically
1209         after the run.
1210
1211         * WebKitTestRunner/TestController.cpp:
1212         (WTR::TestController::initialize):
1213
1214 2012-10-31  Mike West  <mkwst@chromium.org>
1215
1216         Script run from an isolated world should bypass a page's CSP.
1217         https://bugs.webkit.org/show_bug.cgi?id=97398
1218
1219         Reviewed by Adam Barth.
1220
1221         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1222         (DRTTestRunner::DRTTestRunner):
1223         (DRTTestRunner::setIsolatedWorldContentSecurityPolicy):
1224         * DumpRenderTree/chromium/DRTTestRunner.h:
1225         (DRTTestRunner):
1226             Adding a mechanism to set the Content Security Policy for an
1227             isolated world to Chromium's testRunner.
1228
1229 2012-10-31  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
1230
1231         [EFL][DRT] EventSender requires contextClick implementation
1232         https://bugs.webkit.org/show_bug.cgi?id=86091
1233
1234         Reviewed by Gyuyoung Kim.
1235
1236         Add contextClick for DumpRenderTreeEventSender basing on WebKit GTK
1237         implementation.
1238
1239         * DumpRenderTree/efl/EventSender.cpp:
1240         (getMenuItemTitleCallback):
1241         (setMenuItemTitleCallback):
1242         (menuItemClickCallback):
1243         (contextClickCallback):
1244
1245 2012-10-30  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1246
1247         [WTR] Memory leaks in TestWebKitAPI::didReceiveMessageFromInjectedBundle()
1248         https://bugs.webkit.org/show_bug.cgi?id=100770
1249
1250         Reviewed by Sam Weinig.
1251
1252         Adopt strings returned by WKStringCreateWithUTF8CString() in
1253         didReceiveMessageFromInjectedBundle() to avoid memory leaks.
1254
1255         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent.cpp:
1256         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1257
1258 2012-10-30  Kangil Han  <kangil.han@samsung.com>
1259
1260         Fix broken python unit test
1261         https://bugs.webkit.org/show_bug.cgi?id=100810
1262
1263         Reviewed by Dirk Pranke.
1264
1265         BUG 100755 has broken python unit test, e.g. assertion fail, since it modified baseline path.
1266         Therefore, this patch fixes it.
1267
1268         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1269         (TestRebaselineTest.test_baseline_directory):
1270
1271 2012-10-30  Dirk Pranke  <dpranke@chromium.org>
1272
1273         webkit-patch rebaseline*: add more helpful logging
1274         https://bugs.webkit.org/show_bug.cgi?id=100562
1275
1276         Reviewed by Ojan Vafai.
1277
1278         This change rewires the garden-o-matic and rebaseline* commands
1279         in webkit-patch so that --verbose propagates through all the
1280         subcommand invocations properly, and cleans up the logging so
1281         that you can actually tell what is happening. For now, we
1282         leave all of the logging at the logging.DEBUG level, which
1283         means that it gets mixed in will all the other debug logging noise
1284         and is harder to read, but we'll fix that in subsequent patches.
1285
1286         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
1287         (BaselineOptimizer._platform):
1288         (BaselineOptimizer._move_baselines):
1289         (BaselineOptimizer.optimize):
1290         * Scripts/webkitpy/tool/commands/gardenomatic.py:
1291         (GardenOMatic.execute):
1292         * Scripts/webkitpy/tool/commands/rebaseline.py:
1293         (RebaselineTest._copy_existing_baseline):
1294         (RebaselineTest._rebaseline_test):
1295         (OptimizeBaselines._optimize_baseline):
1296         (OptimizeBaselines.execute):
1297         (AbstractParallelRebaselineCommand._run_webkit_patch):
1298         (AbstractParallelRebaselineCommand._rebaseline_commands):
1299         (AbstractParallelRebaselineCommand._files_to_add):
1300         (AbstractParallelRebaselineCommand._optimize_baselines):
1301         (AbstractParallelRebaselineCommand._rebaseline):
1302         (RebaselineExpectations._add_tests_to_rebaseline_for_port):
1303         (Rebaseline.execute):
1304         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1305         (GardeningHTTPServer.__init__):
1306         (GardeningHTTPRequestHandler):
1307         (GardeningHTTPRequestHandler._run_webkit_patch):
1308         (GardeningHTTPRequestHandler.rebaselineall):
1309
1310 2012-10-30  Dirk Pranke  <dpranke@chromium.org>
1311
1312         clean up tests for webkit-patch rebaseline* commands
1313         https://bugs.webkit.org/show_bug.cgi?id=100793
1314
1315         Reviewed by Ojan Vafai.
1316
1317         The tests in rebaseline_unittest.py had a lot of code cloning,
1318         and many of the tests tested whether things passed or failed by
1319         looking at what was logged instead of what was actually done;
1320         as a result the tests were kinda hard to understand and harder to
1321         maintain.
1322
1323         This patch adds hooks to MockWeb() and MockExecutive() so we can
1324         directly see which URLs were fetched and calls invoked, and
1325         then reworks all of the unit tests to be easier to follow and
1326         maintain and not sensitive to the logging. Also there were a
1327         couple of tests that were redundant.
1328
1329         There are no functional changes in this patch, and I verified that
1330         the coverage remains the same.
1331
1332         * Scripts/webkitpy/common/net/web_mock.py:
1333         (MockWeb.__init__):
1334         (MockWeb.get_binary):
1335         * Scripts/webkitpy/common/system/executive_mock.py:
1336         (MockExecutive.__init__):
1337         (MockExecutive.run_command):
1338         (MockExecutive.kill_all):
1339         (MockExecutive):
1340         (MockExecutive.kill_process):
1341         (MockExecutive.popen):
1342         (MockExecutive.run_in_parallel):
1343         (MockExecutive2):
1344         (MockExecutive2.__init__):
1345         (MockExecutive2.run_command):
1346         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1347         (_BaseTestCase):
1348         (_BaseTestCase.setUp):
1349         (_BaseTestCase._expand):
1350         (_BaseTestCase._read):
1351         (_BaseTestCase._write):
1352         (_BaseTestCase._zero_out_test_expectations):
1353         (TestRebaselineTest):
1354         (TestRebaselineTest.test_baseline_directory):
1355         (TestRebaselineTest.test_rebaseline_updates_expectations_file_noop):
1356         (test_rebaseline_updates_expectations_file):
1357         (test_rebaseline_does_not_include_overrides):
1358         (test_rebaseline_test):
1359         (test_rebaseline_test_and_print_scm_changes):
1360         (test_rebaseline_and_copy_test):
1361         (test_rebaseline_and_copy_test_no_existing_result):
1362         (test_rebaseline_and_copy_test_with_lion_result):
1363         (test_rebaseline_and_copy_no_overwrite_test):
1364         (test_rebaseline_test_internal_with_move_overwritten_baselines_to):
1365         (TestRebaselineJson):
1366         (TestRebaselineJson.setUp):
1367         (TestRebaselineJson.tearDown):
1368         (TestRebaselineJson.test_rebaseline_all):
1369         (TestRebaselineJson.test_rebaseline_debug):
1370         (TestRebaseline):
1371         (TestRebaseline.test_tests_to_update):
1372         (TestRebaseline.test_rebaseline):
1373         (TestRebaseline.test_rebaseline.rebaseline_stub):
1374         (TestRebaselineExpectations):
1375         (TestRebaselineExpectations.setUp):
1376         (TestRebaselineExpectations.test_rebaseline_expectations):
1377         (TestRebaselineExpectations.test_rebaseline_expectations_noop):
1378         (TestRebaselineExpectations.disabled_test_overrides_are_included_correctly):
1379
1380 2012-10-30  Dirk Pranke  <dpranke@chromium.org>
1381
1382         test-webkitpy: fix import of coverage so that it works in a clean install
1383         https://bugs.webkit.org/show_bug.cgi?id=100780
1384
1385         Reviewed by Tony Chang.
1386
1387         The coverage module is written so that the parent directory needs
1388         to be in PYTHONPATH; work around that ...
1389
1390         * Scripts/webkitpy/test/main_unittest.py:
1391         (TestStubs.test_empty):
1392         (TesterTest.test_individual_names_are_not_run_twice):
1393         (TesterTest):
1394         (TesterTest.integration_test_coverage_works):
1395         * Scripts/webkitpy/thirdparty/__init__.py:
1396         (AutoinstallImportHook._install_coverage):
1397
1398 2012-10-30  Anders Carlsson  <andersca@apple.com>
1399
1400         Another build fix.
1401
1402         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
1403         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1404
1405 2012-10-30  Anders Carlsson  <andersca@apple.com>
1406
1407         Build fix.
1408
1409         * WebKitTestRunner/mac/EventSenderProxy.mm:
1410         (WTR::EventSenderProxy::mouseScrollBy):
1411
1412 2012-10-30  Rick Byers  <rbyers@chromium.org>
1413
1414         [touchadjustment] touch-links-longpress tests passes incorrectly
1415         https://bugs.webkit.org/show_bug.cgi?id=96810
1416
1417         Reviewed by Antonio Gomes.
1418
1419         Add support for suppling width/height information for longpress
1420         gesture (as for other gestures like tapDown) for the purposes
1421         of touch adjustment.
1422
1423         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
1424         (WebTestRunner):
1425         (WebTestRunner::EventSender::gestureEvent):
1426
1427 2012-10-29  Anders Carlsson  <andersca@apple.com>
1428
1429         Build WebKit as C++11 on Mac
1430         https://bugs.webkit.org/show_bug.cgi?id=100720
1431
1432         Reviewed by Daniel Bates.
1433
1434         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1435         * MiniBrowser/Configurations/Base.xcconfig:
1436         * TestWebKitAPI/Configurations/Base.xcconfig:
1437         * WebKitTestRunner/Configurations/Base.xcconfig:
1438         Add CLANG_CXX_LANGUAGE_STANDARD=gnu++0x.
1439
1440 2012-10-30  Christophe Dumez  <christophe.dumez@intel.com>
1441
1442         [EFL][JHBUILD] Update EFL libraries to v1.7.1 stable release
1443         https://bugs.webkit.org/show_bug.cgi?id=100759
1444
1445         Reviewed by Kenneth Rohde Christiansen.
1446
1447         Update Bump EFL libraries to the new stable release (v1.7.1)
1448         in JHBuild to pull the latest bug fixes.
1449
1450         * efl/jhbuild.modules:
1451
1452 2012-10-29  Anders Carlsson  <andersca@apple.com>
1453
1454         String::createCFString should return a RetainPtr
1455         https://bugs.webkit.org/show_bug.cgi?id=100419
1456
1457         Reviewed by Andreas Kling.
1458
1459         Update callers of String::createCFString.
1460
1461         * WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
1462         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
1463
1464 2012-10-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1465
1466         [WK2][WTR] WebKitTestRunner needs testRunner.queueLoadHTMLString
1467         https://bugs.webkit.org/show_bug.cgi?id=100747
1468
1469         Reviewed by Kenneth Rohde Christiansen.
1470
1471         Added testRunner.queueLoadHTMLString implementation.
1472
1473         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1474         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1475         (WTR::InjectedBundle::queueLoadHTMLString):
1476         (WTR):
1477         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1478         (InjectedBundle):
1479         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1480         (WTR::TestRunner::queueLoadHTMLString):
1481         (WTR):
1482         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1483         (TestRunner):
1484         * WebKitTestRunner/TestInvocation.cpp:
1485         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1486         * WebKitTestRunner/WorkQueueManager.cpp:
1487         (WTR::WorkQueueManager::queueLoadHTMLString):
1488         (WTR):
1489         * WebKitTestRunner/WorkQueueManager.h:
1490         (WorkQueueManager):
1491
1492 2012-10-30  Kangil Han  <kangil.han@samsung.com>
1493
1494         [EFL] Baseline search path should consider both WK1 and WK2 on layout test.
1495         https://bugs.webkit.org/show_bug.cgi?id=100755
1496
1497         Reviewed by Gyuyoung Kim.
1498
1499         Current implementation doesn't consider WK1 case in baseline search path.
1500         Therefore, this patch fixes it.
1501
1502         * Scripts/webkitpy/layout_tests/port/efl.py:
1503         (EflPort.default_baseline_search_path):
1504
1505 2012-10-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1506
1507         [QT][DRT] Remove unneeded testRunner.setMediaType() implementation
1508         https://bugs.webkit.org/show_bug.cgi?id=100740
1509
1510         Reviewed by Kenneth Rohde Christiansen.
1511
1512         Removed unneeded testRunner.setMediaType() implementation, as tests use
1513         cross-platform window.internals.settings.setMediaTypeOverride instead.
1514
1515         * DumpRenderTree/qt/TestRunnerQt.cpp:
1516         * DumpRenderTree/qt/TestRunnerQt.h:
1517         (TestRunner):
1518
1519 2012-10-30  Kangil Han  <kangil.han@samsung.com>
1520
1521         [EFL][DRT] Bitmap should show whole view area.
1522         https://bugs.webkit.org/show_bug.cgi?id=100642
1523
1524         Reviewed by Gyuyoung Kim.
1525
1526         css sticky position test cases haven't been passed even though implementation has been landed by BUG 95182.
1527         This is because current create bitmap implementation refers to geometry position that considers scroll movement even though
1528         paint does it. Therefore, this patch always reflects current view size and remove duplicated graphic operation to dump correct bitmap image.
1529
1530         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
1531         (createBitmapContextFromWebView):
1532
1533 2012-10-30  Jinwoo Song  <jinwoo7.song@samsung.com>
1534
1535         [EFL] Refactor tooltip callback signal in WebKit1
1536         https://bugs.webkit.org/show_bug.cgi?id=100571
1537
1538         Reviewed by Gyuyoung Kim.
1539
1540         Separate tooltip callback signal into 'tooltip,text,set'
1541         and 'tooltip,text,unset' to be consistent with WebKit2.
1542
1543         * EWebLauncher/main.c:
1544         (on_tooltip_text_set):
1545         (on_tooltip_text_unset):
1546         (browserCreate):
1547
1548 2012-10-29  Csaba Osztrogonác  <ossy@webkit.org>
1549
1550         Unreviewed, rolling out r132819.
1551         http://trac.webkit.org/changeset/132819
1552         https://bugs.webkit.org/show_bug.cgi?id=100388
1553
1554         It made layout testing 40% slower and storage tests assert
1555
1556         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1557         (WebCore::DumpRenderTree::DumpRenderTree):
1558         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1559         (WebCore::DumpRenderTree::dump):
1560         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1561         (DumpRenderTree):
1562         * DumpRenderTree/qt/TestRunnerQt.cpp:
1563         (TestRunner::reset):
1564         * DumpRenderTree/qt/TestRunnerQt.h:
1565         (TestRunner):
1566
1567 2012-10-29  Jochen Eisinger  <jochen@chromium.org>
1568
1569         [chromium] TestRunner needs to compile ChromiumCurrentTime and ChromiumThreading in components build
1570         https://bugs.webkit.org/show_bug.cgi?id=100658
1571
1572         Reviewed by Tony Chang.
1573
1574         Before, this was compiled into DumpRenderTree. I also dropped the
1575         include_dirs and dependencies block as TestRunner already has them.
1576
1577         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1578
1579 2012-10-29  Takashi Sakamoto  <tasak@google.com>
1580
1581         Unreviewed. Adding myself as a committer.
1582
1583         * Scripts/webkitpy/common/config/committers.py:
1584
1585 2012-10-28  Mark Rowe  <mrowe@apple.com>
1586
1587         Simplify Xcode configuration settings that used to vary between OS versions.
1588
1589         Reviewed by Dan Bernstein.
1590
1591         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1592         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1593         * MiniBrowser/Configurations/Base.xcconfig:
1594         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1595         * TestWebKitAPI/Configurations/Base.xcconfig:
1596         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1597         * WebKitTestRunner/Configurations/Base.xcconfig:
1598         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1599
1600 2012-10-28  Mark Rowe  <mrowe@apple.com>
1601
1602         Remove references to unsupported OS and Xcode versions.
1603
1604         Reviewed by Anders Carlsson.
1605
1606         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1607         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1608         * DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig: Removed.
1609         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1610         * MiniBrowser/Configurations/Base.xcconfig:
1611         * MiniBrowser/Configurations/CompilerVersion.xcconfig: Removed.
1612         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1613         * TestWebKitAPI/Configurations/Base.xcconfig:
1614         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig: Removed.
1615         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1616         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1617         * WebKitTestRunner/Configurations/Base.xcconfig:
1618         * WebKitTestRunner/Configurations/CompilerVersion.xcconfig: Removed.
1619         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1620         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1621
1622 2012-10-26  Dirk Pranke  <dpranke@chromium.org>
1623
1624         webkitpy: change non-verbose log format for webkit-patch
1625         https://bugs.webkit.org/show_bug.cgi?id=100561
1626
1627         Reviewed by Ojan Vafai.
1628
1629         Logging the module name and the log level is annoying and nearly useless.
1630         For starters, this change removes that unless you are doing verbose/
1631         debug logging. In the future we should split out the concepts of
1632         verbose and debug logging (like we did in test-webkitpy and
1633         run-webkit-tests) so that you could get this in debug logging.
1634
1635         * Scripts/webkitpy/common/system/logutils.py:
1636         (_default_handlers):
1637         (configure_logging):
1638         * Scripts/webkitpy/common/system/logutils_unittest.py:
1639         (ConfigureLoggingTest.test_info_message):
1640         (ConfigureLoggingTest):
1641         (ConfigureLoggingTest.test_debug_message):
1642         (ConfigureLoggingTest.test_two_messages):
1643         (ConfigureLoggingVerboseTest):
1644         (ConfigureLoggingVerboseTest._logging_level):
1645         (ConfigureLoggingVerboseTest.test_info_message):
1646         (ConfigureLoggingVerboseTest.test_debug_message):
1647         (ConfigureLoggingCustomLevelTest.test_logged_message):
1648
1649 2012-10-29  Christophe Dumez  <christophe.dumez@intel.com>
1650
1651         [CMAKE] Add TestNetscapePlugIn/Tests/NPRuntimeCallsWithNullNPP.cpp to CMakeLists.txt
1652         https://bugs.webkit.org/show_bug.cgi?id=100681
1653
1654         Reviewed by Anders Carlsson.
1655
1656         Add TestNetscapePlugIn/Tests/NPRuntimeCallsWithNullNPP.cpp to CMake since
1657         it is needed by plugins/npruntime/npruntime-calls-with-null-npp.html
1658         layout test.
1659
1660         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1661
1662 2012-10-29  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1663
1664         [Qt] Flaky security tests
1665         https://bugs.webkit.org/show_bug.cgi?id=100388
1666
1667         Reviewed by Jocelyn Turcotte.
1668
1669         Disable text dumping and load a blank URL to ensure the documentLoader is cleared 
1670         before we start dumping text for the new page. Otherwise messages from the old page
1671         may end up in the text output of the new test.
1672
1673         This matches what WebKitTestRunner does, and reuses the Qt code for waiting for flag.
1674
1675         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1676         (WebCore::DumpRenderTree::DumpRenderTree):
1677         (WebCore::runUntil):
1678         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1679         (WebCore::DumpRenderTree::finishedResetting):
1680         (WebCore::DumpRenderTree::dump):
1681         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1682         (DumpRenderTree):
1683         * DumpRenderTree/qt/TestRunnerQt.cpp:
1684         (TestRunner::resetDumping):
1685         (TestRunner::reset):
1686         * DumpRenderTree/qt/TestRunnerQt.h:
1687         (TestRunner):
1688
1689 2012-10-29  Christophe Dumez  <christophe.dumez@intel.com>
1690
1691         [WK2][WKTR] Enable Shadow DOM at runtime if compiled with SHADOW_DOM support
1692         https://bugs.webkit.org/show_bug.cgi?id=100668
1693
1694         Reviewed by Kenneth Rohde Christiansen.
1695
1696         Enable Shadow DOM functionality at run time in WebKitTestRunner
1697         if compiled with SHADOW_DOM flag set. This is needed to run
1698         the Shadow DOM layout tests.
1699
1700         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1701         (WTR::InjectedBundle::beginTesting):
1702
1703 2012-10-29  Yael Aharon  <yael.aharon@intel.com>
1704
1705         [EFL][AC] Fix bugs preventing us from running layout tests with AC turned on
1706         https://bugs.webkit.org/show_bug.cgi?id=100598
1707
1708         Reviewed by Kenneth Rohde Christiansen.
1709
1710         Make sure to use opengl_x11 engine when AC is turned on and X11 is in use.
1711         We cannot create a gl context otherwise.
1712
1713         * MiniBrowser/efl/main.c:
1714         (elm_main):
1715         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1716         (WTR::initEcoreEvas):
1717         * DumpRenderTree/efl/DumpRenderTree.cpp:
1718         (initEcoreEvas):
1719         * EWebLauncher/efl/main.c:
1720         (windowCreate):
1721
1722 2012-10-29  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1723
1724         [EFL][WK2] REGRESSION(r132342): fast/events/frame-tab-focus.html fails
1725         https://bugs.webkit.org/show_bug.cgi?id=100646
1726
1727         Reviewed by Kenneth Rohde Christiansen.
1728
1729         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1730         (WTR::PlatformWebView::focus): Improve the check we perform to
1731         decide whether the focus should be taken out of the view before
1732         focusing it again so that we do not unnecessarily unfocus it and
1733         cause blur/focus events to be triggered. Instead of just verifying
1734         if the Evas_Object representing the view has focus, use the WK C
1735         API to check that the currently focused frame is not the main
1736         frame.
1737
1738 2012-10-29  Sheriff Bot  <webkit.review.bot@gmail.com>
1739
1740         Unreviewed, rolling out r132782.
1741         http://trac.webkit.org/changeset/132782
1742         https://bugs.webkit.org/show_bug.cgi?id=100653
1743
1744         It made 400+ tests fail and 180 tests flakey on Qt (Requested
1745         by Ossy on #webkit).
1746
1747         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1748         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1749
1750 2012-10-29  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1751
1752         [Qt] Flaky security tests
1753         https://bugs.webkit.org/show_bug.cgi?id=100388
1754
1755         Reviewed by Jocelyn Turcotte.
1756
1757         Disable text output and load a blank URL to ensure the documentLoader is cleared
1758         before we start dumping text for the new page. Otherwise messages from the old page
1759         may end up in the text output of the new test.
1760
1761         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1762         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1763
1764 2012-10-29  Jochen Eisinger  <jochen@chromium.org>
1765
1766         [chromium] remove remaining usages of webkit_support from the TestRunner library
1767         https://bugs.webkit.org/show_bug.cgi?id=100344
1768
1769         Reviewed by Adam Barth.
1770
1771         The most important part is to not rely on calling out to gdk/X11 to
1772         translate keycodes to hardware keycodes, as this is not possible inside
1773         the sandbox.
1774
1775         * DumpRenderTree/DumpRenderTree.gypi:
1776         * DumpRenderTree/chromium/DRTTestRunner.h:
1777         (WebKit):
1778         (webkit_support):
1779         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1780         (WebTestDelegate):
1781         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h:
1782         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
1783         (WebTestRunner):
1784         (WebTestRunner::EventSender::doDragDrop):
1785         (WebTestRunner::EventSender::updateClickCountForButton):
1786         (WebTestRunner::EventSender::mouseDown):
1787         (WebTestRunner::EventSender::mouseUp):
1788         (WebTestRunner::EventSender::mouseMoveTo):
1789         (WebTestRunner::EventSender::keyDown):
1790         (WebTestRunner::EventSender::replaySavedEvents):
1791         (WebTestRunner::EventSender::contextClick):
1792         (WebTestRunner::EventSender::beginDragWithFiles):
1793         (WebTestRunner::EventSender::sendCurrentTouchEvent):
1794         (WebTestRunner::EventSender::handleMouseWheel):
1795         (WebTestRunner::EventSender::gestureEvent):
1796         (WebTestRunner::EventSender::gestureFlingCancel):
1797         (WebTestRunner::EventSender::gestureFlingStart):
1798         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Added.
1799         (WebTestRunner):
1800         (WebTestRunner::NativeKeyCodeForWindowsKeyCode):
1801         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h.
1802         (WebTestRunner):
1803         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
1804         (TestDelegate):
1805         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1806         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1807         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1808         (WebTestInterfaces::Internal):
1809         (WebTestRunner::WebTestInterfaces::Internal::getCurrentTimeInMillisecond):
1810         (WebTestRunner):
1811         (WebTestRunner::WebTestInterfaces::Internal::getAbsoluteWebStringFromUTF8Path):
1812         * DumpRenderTree/chromium/WebViewHost.cpp:
1813         (WebViewHost::getCurrentTimeInMillisecond):
1814         (WebViewHost::getAbsoluteWebStringFromUTF8Path):
1815         * DumpRenderTree/chromium/WebViewHost.h:
1816         (WebViewHost):
1817
1818 2012-10-29  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
1819
1820         Unreviewed. Add jonathan.dong@torchmobile.com.cn as a committer.
1821         https://bugs.webkit.org/show_bug.cgi?id=100629
1822
1823         * Scripts/webkitpy/common/config/committers.py:
1824
1825 2012-10-27  Dan Bernstein  <mitz@apple.com>
1826
1827         REAL_PLATFORM_NAME build setting is no longer needed
1828         https://bugs.webkit.org/show_bug.cgi?id=100587
1829
1830         Reviewed by Mark Rowe.
1831
1832         Removed the definition of REAL_PLATFORM_NAME and replaced references to it with references
1833         to PLATFORM_NAME.
1834
1835         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1836         * DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig:
1837         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1838         * MiniBrowser/Configurations/Base.xcconfig:
1839         * MiniBrowser/Configurations/CompilerVersion.xcconfig:
1840         * TestWebKitAPI/Configurations/Base.xcconfig:
1841         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
1842         * WebKitTestRunner/Configurations/Base.xcconfig:
1843         * WebKitTestRunner/Configurations/CompilerVersion.xcconfig:
1844         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1845
1846 2012-10-26  Anders Carlsson  <andersca@apple.com>
1847
1848         Crash when making NPRuntime calls with a null NPP pointer
1849         https://bugs.webkit.org/show_bug.cgi?id=100569
1850
1851         Reviewed by Darin Adler.
1852
1853         Add new NPRuntimeCallsWithNullNPP plug-in test.
1854
1855         * DumpRenderTree/DumpRenderTree.gypi:
1856         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1857         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1858         (PluginTest::NPN_ReleaseVariantValue):
1859         (PluginTest::netscapeFuncs):
1860         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1861         (PluginTest):
1862         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeCallsWithNullNPP.cpp: Added.
1863         (NPRuntimeCallsWithNullNPP):
1864         (NPRuntimeCallsWithNullNPP::NPRuntimeCallsWithNullNPP):
1865         (NPRuntimeCallsWithNullNPP::NPP_New):
1866         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1867         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1868         * GNUmakefile.am:
1869
1870 2012-10-26  Dominic Mazzoni  <dmazzoni@google.com>
1871
1872         AX: Notification should be sent when accessibilityIsIgnored changes
1873         https://bugs.webkit.org/show_bug.cgi?id=99547
1874
1875         Reviewed by Chris Fleizach.
1876
1877         Add additional accessibility notifications.
1878
1879         * DumpRenderTree/chromium/WebViewHost.cpp:
1880         (WebViewHost::postAccessibilityNotification):
1881
1882 2012-10-25  Roger Fong  <roger_fong@apple.com>
1883
1884         Get rid of (<X%) failing output for old-run-webkit-tests.
1885         https://bugs.webkit.org/show_bug.cgi?id=100447
1886
1887         Reviewed by Jessie Berlin.
1888
1889         Not a particularly useful piece of information. It's pretty much never above 1%.
1890         new-run-webkit-tests does not output this either.
1891
1892         * Scripts/old-run-webkit-tests:
1893         (printResults):
1894
1895 2012-10-26  Xianzhu Wang  <wangxianzhu@chromium.org>
1896
1897         Build bot gives incorrect link to EWS build failure
1898         https://bugs.webkit.org/show_bug.cgi?id=100436
1899
1900         Reviewed by Adam Barth.
1901
1902         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1903         (MockCommitQueue.__init__):
1904         (MockCommitQueue.command_failed): Return incremental failure_status_id
1905         (CommitQueueTaskTest.test_red_tree_patch_rejection): Check failure_status_id
1906         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1907         (PatchAnalysisTask._test_patch): Use the failure_status_id of test with patch when test without patch fails and test with patch has unexpected failures.
1908
1909 2012-10-26  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1910
1911         webkitpy: Pass the `Listen' Apache directive from webkitpy, not the httpd.conf files.
1912         https://bugs.webkit.org/show_bug.cgi?id=98602
1913
1914         Reviewed by Dirk Pranke.
1915
1916         Unify all the different `Listen' directives present in the several
1917         httpd.conf files we have in LayoutTests/http/conf. For one, we
1918         were already passing `Listen 127.0.0.1:8000' via webkitpy before,
1919         and opening the other ports from the conf files.
1920
1921         The configuration files differed mostly in the way they handled
1922         IPV6 ports. Some of them did not listen to IPV6 ports because the
1923         systems which used them sometimes did not have IPV6 support. The
1924         `http_server_supports_ipv6' method has been added to Port to
1925         address that. cygwin, on its turn, still seems to use Apache 1.3,
1926         which does not support IPV6 at all; the newly-added method has a
1927         special case for that. Plus, perform a socket.getaddrinfo() call
1928         the same way Apache itself does so we are sure we only enable IPV6
1929         when setting that up in the httpd server is not going to fail.
1930
1931         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1932         (MockPlatformInfo.is_cygwin):
1933         * Scripts/webkitpy/layout_tests/port/base.py:
1934         (Port.baseline_version_dir):
1935         (Port.to.start_websocket_server):
1936         (Port.to):
1937         (Port.to.http_server_supports_ipv6):
1938         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1939         (PortTest.test_http_server_supports_ipv6):
1940         (PortTest.test_build_path):
1941         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1942         (LayoutTestApacheHttpd):
1943         (LayoutTestApacheHttpd.__init__):
1944
1945 2012-10-26  David Barton  <dbarton@mathscribe.com>
1946
1947         Unreviewed. Update my IRC nickname to a registered one.
1948
1949         * Scripts/webkitpy/common/config/committers.py:
1950
1951 2012-10-26  Simon Hausmann  <simon.hausmann@digia.com>
1952
1953         [Qt] Fix the LLInt build on Windows
1954         https://bugs.webkit.org/show_bug.cgi?id=97648
1955
1956         Reviewed by Tor Arne Vestbø.
1957
1958         Added BIN_EXTENSION variable - similar to automake - that expands to .exe as suffix for
1959         executable programs on Windows. Empty otherwise. Also added support for force_build_all
1960         to allow overriding us disabling build_all for TEMPLATE = app.
1961
1962         * qmake/mkspecs/features/default_pre.prf:
1963
1964 2012-10-26  Xiaobo Wang  <xbwang@torchmobile.com.cn>
1965
1966         [BlackBerry] Support pixel tests for BlackBerry DRT
1967         https://bugs.webkit.org/show_bug.cgi?id=100210
1968
1969         Reviewed by Rob Buis.
1970
1971         (The following 2 files are missed in previous patch(r132582), adding them
1972         again.)
1973
1974         * DumpRenderTree/blackberry/build: Added.
1975         * DumpRenderTree/blackberry/src.pro: Added.
1976         Adds 2 files for building ImageDiff, by Christopher Wells.
1977
1978 2012-10-26  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1979
1980         Add feature flags for CSS Device Adaptation
1981         https://bugs.webkit.org/show_bug.cgi?id=95960
1982
1983         Reviewed by Kenneth Rohde Christiansen.
1984
1985         * Scripts/webkitperl/FeatureList.pm:
1986
1987 2012-10-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1988
1989         Unreviewed, rolling out r132552.
1990         http://trac.webkit.org/changeset/132552
1991         https://bugs.webkit.org/show_bug.cgi?id=100486
1992
1993         Makes typeahead tests crash in debug. (Requested by pfeldman
1994         on #webkit).
1995
1996         * DumpRenderTree/DumpRenderTree.gypi:
1997         * DumpRenderTree/chromium/DRTTestRunner.h:
1998         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1999         (WebTestDelegate):
2000         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h:
2001         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
2002         (WebTestRunner):
2003         (WebTestRunner::EventSender::doDragDrop):
2004         (WebTestRunner::EventSender::updateClickCountForButton):
2005         (WebTestRunner::EventSender::mouseDown):
2006         (WebTestRunner::EventSender::mouseUp):
2007         (WebTestRunner::EventSender::mouseMoveTo):
2008         (WebTestRunner::EventSender::keyDown):
2009         (WebTestRunner::EventSender::replaySavedEvents):
2010         (WebTestRunner::EventSender::contextClick):
2011         (WebTestRunner::EventSender::beginDragWithFiles):
2012         (WebTestRunner::EventSender::sendCurrentTouchEvent):
2013         (WebTestRunner::EventSender::handleMouseWheel):
2014         (WebTestRunner::EventSender::gestureEvent):
2015         (WebTestRunner::EventSender::gestureFlingCancel):
2016         (WebTestRunner::EventSender::gestureFlingStart):
2017         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
2018         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
2019         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
2020         (TestDelegate):
2021         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2022         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2023         (WebKit):
2024         (webkit_support):
2025         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2026         (WebTestInterfaces::Internal):
2027         * DumpRenderTree/chromium/WebViewHost.cpp:
2028         * DumpRenderTree/chromium/WebViewHost.h:
2029         (WebViewHost):
2030
2031 2012-10-26  Xiaobo Wang  <xbwang@torchmobile.com.cn>
2032
2033         [BlackBerry] Support pixel tests for BlackBerry DRT
2034         https://bugs.webkit.org/show_bug.cgi?id=100210
2035
2036         Reviewed by Rob Buis.
2037
2038         The implementation is based on the patch from Christopher Wells.
2039
2040         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2041         (BlackBerry::WebKit::DumpRenderTree::DumpRenderTree):
2042         (BlackBerry::WebKit::DumpRenderTree::runTest):
2043         (BlackBerry::WebKit::DumpRenderTree::runCurrentTest):
2044         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
2045         (BlackBerry::WebKit::DumpRenderTree::runTests):
2046         (BlackBerry::WebKit::DumpRenderTree::dump):
2047         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
2048         (DumpRenderTree):
2049
2050         * DumpRenderTree/blackberry/PNGImageEncoder.cpp:
2051         (BGRAtoRGBA):
2052         (encodeBitmapToPNG):
2053         * DumpRenderTree/blackberry/PNGImageEncoder.h:
2054         The changes to PNGImageEncoder files are from master_40, patched by Tyler
2055         Abbott and Rob Buis.
2056
2057         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
2058         (createBitmapContextFromWebView):
2059         (computeMD5HashStringForBitmapContext):
2060         (printPNG):
2061         (dumpBitmap):
2062         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.h:
2063         (BitmapContext::createByAdoptingData):
2064         (BitmapContext::~BitmapContext):
2065         (BitmapContext):
2066         (BitmapContext::BitmapContext):
2067
2068         * DumpRenderTree/blackberry/build: Added.
2069         * DumpRenderTree/blackberry/src.pro: Added.
2070         Adds 2 files for building ImageDiff, by Christopher Wells.
2071
2072 2012-10-25  Min Qin  <qinmin@chromium.org>
2073
2074         Fix a layout test crash if a TestWebkitPlugin is put inside an iframe
2075         https://bugs.webkit.org/show_bug.cgi?id=100406
2076
2077         Reviewed by Adam Barth.
2078
2079         Resize the context with an empty rect will cause a gl_error in gles2_cmd_decoder.cc.
2080         Don't paint the plugin if m_rect is empty.
2081
2082         * DumpRenderTree/chromium/TestWebPlugin.cpp:
2083         (TestWebPlugin::updateGeometry):
2084
2085 2012-10-25  Jinwoo Song  <jinwoo7.song@samsung.com>
2086
2087         [EFL][WK2] Display tooltip in MiniBrowser
2088         https://bugs.webkit.org/show_bug.cgi?id=99322
2089
2090         Reviewed by Kenneth Rohde Christiansen.
2091
2092         Display tooltip in MiniBrowser using elm_object_tooltip_text_set().
2093
2094         * MiniBrowser/efl/main.c:
2095         (on_tooltip_text_set):
2096         (on_tooltip_text_unset):
2097         (window_create):
2098
2099 2012-10-25  Jochen Eisinger  <jochen@chromium.org>
2100
2101         [chromium] remove remaining usages of webkit_support from the TestRunner library
2102         https://bugs.webkit.org/show_bug.cgi?id=100344
2103
2104         Reviewed by Adam Barth.
2105
2106         The most important part is to not rely on calling out to gdk/X11 to
2107         translate keycodes to hardware keycodes, as this is not possible inside
2108         the sandbox.
2109
2110         * DumpRenderTree/DumpRenderTree.gypi:
2111         * DumpRenderTree/chromium/DRTTestRunner.h:
2112         (WebKit):
2113         (webkit_support):
2114         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2115         (WebTestDelegate):
2116         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h:
2117         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
2118         (WebTestRunner):
2119         (WebTestRunner::EventSender::doDragDrop):
2120         (WebTestRunner::EventSender::updateClickCountForButton):
2121         (WebTestRunner::EventSender::mouseDown):
2122         (WebTestRunner::EventSender::mouseUp):
2123         (WebTestRunner::EventSender::mouseMoveTo):
2124         (WebTestRunner::EventSender::keyDown):
2125         (WebTestRunner::EventSender::replaySavedEvents):
2126         (WebTestRunner::EventSender::contextClick):
2127         (WebTestRunner::EventSender::beginDragWithFiles):
2128         (WebTestRunner::EventSender::sendCurrentTouchEvent):
2129         (WebTestRunner::EventSender::handleMouseWheel):
2130         (WebTestRunner::EventSender::gestureEvent):
2131         (WebTestRunner::EventSender::gestureFlingCancel):
2132         (WebTestRunner::EventSender::gestureFlingStart):
2133         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Added.
2134         (WebTestRunner):
2135         (WebTestRunner::NativeKeyCodeForWindowsKeyCode):
2136         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h.
2137         (WebTestRunner):
2138         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
2139         (TestDelegate):
2140         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2141         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2142         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2143         (WebTestInterfaces::Internal):
2144         (WebTestRunner::WebTestInterfaces::Internal::getCurrentTimeInMillisecond):
2145         (WebTestRunner):
2146         (WebTestRunner::WebTestInterfaces::Internal::getAbsoluteWebStringFromUTF8Path):
2147         * DumpRenderTree/chromium/WebViewHost.cpp:
2148         (WebViewHost::getCurrentTimeInMillisecond):
2149         (WebViewHost::getAbsoluteWebStringFromUTF8Path):
2150         * DumpRenderTree/chromium/WebViewHost.h:
2151         (WebViewHost):
2152
2153 2012-10-25  Sheriff Bot  <webkit.review.bot@gmail.com>
2154
2155         Unreviewed, rolling out r132514.
2156         http://trac.webkit.org/changeset/132514
2157         https://bugs.webkit.org/show_bug.cgi?id=100440
2158
2159         "Broke chromium content_browsertests AccessibilityAriaMenu
2160         AccessibilityInputRange AccessibilityListMarkers" (Requested
2161         by scheib on #webkit).
2162
2163         * DumpRenderTree/chromium/WebViewHost.cpp:
2164         (WebViewHost::postAccessibilityNotification):
2165
2166 2012-10-25  Dirk Pranke  <dpranke@chromium.org>
2167
2168         rwt --lint-test-files doesn't handle the cascade properly
2169         https://bugs.webkit.org/show_bug.cgi?id=100315
2170
2171         Reviewed by Ojan Vafai.
2172
2173         We were only linting the first file in each port's list of
2174         expectations.
2175
2176         This change pushes more of the logic for linting files into
2177         the TestExpectations classes themselves, but it's still a bit of
2178         a hack. A better solution will require splitting out the actual
2179         parsing of the files from the TestExpectations constructor.
2180
2181         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2182         (TestExpectations):
2183         (TestExpectations.__init__):
2184         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2185         (parse_exp):
2186         (SkippedTests.check):
2187         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2188         (lint):
2189         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2190         (LintTest.test_all_configurations.FakePort.__init__):
2191         (LintTest.test_all_configurations):
2192         (LintTest.test_lint_test_files__errors):
2193         * Scripts/webkitpy/style/checkers/test_expectations.py:
2194         (TestExpectationsChecker.check_test_expectations):
2195
2196 2012-10-25  Zan Dobersek  <zandobersek@gmail.com>
2197
2198         Unreviewed GTK gardening.
2199
2200         Skipping the atspi-basic-hierarchy test case in the TestWebKitAccessibility
2201         WebKit2 API test since the test is currently failing.
2202
2203         * Scripts/run-gtk-tests:
2204         (TestRunner):
2205
2206 2012-10-25  Dominic Mazzoni  <dmazzoni@google.com>
2207
2208         AX: Notification should be sent when accessibilityIsIgnored changes
2209         https://bugs.webkit.org/show_bug.cgi?id=99547
2210
2211         Reviewed by Chris Fleizach.
2212
2213         Add additional accessibility notifications.
2214
2215         * DumpRenderTree/chromium/WebViewHost.cpp:
2216         (WebViewHost::postAccessibilityNotification):
2217
2218 2012-10-25  Dominik Röttsches  <dominik.rottsches@intel.com>
2219
2220         Conditionalize XHR timeout support
2221         https://bugs.webkit.org/show_bug.cgi?id=100356
2222
2223         Reviewed by Adam Barth.
2224
2225         Adding XHR_TIMEOUT feature in perl and qmake files.
2226
2227         * Scripts/webkitperl/FeatureList.pm:
2228         * qmake/mkspecs/features/features.pri:
2229
2230 2012-10-25  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2231
2232         Unreviewed. Update my contact info.
2233
2234         * Scripts/webkitpy/common/config/committers.py:
2235
2236 2012-10-25  Terry Anderson  <tdanderson@chromium.org>
2237
2238         Unreviewed. Adding myself as a committer.
2239
2240         * Scripts/webkitpy/common/config/committers.py:
2241
2242 2012-10-25  Zeno Albisser  <zeno@webkit.org>
2243
2244         [Qt] Adjust library name in webkitdirs.pm after r131300.
2245         https://bugs.webkit.org/show_bug.cgi?id=100376
2246
2247         The library was renamed from QtWebKit to QtWebKitWidgets.
2248         run-launcher was still looking for QtWebKit.
2249
2250         Reviewed by Simon Hausmann.
2251
2252         * Scripts/webkitdirs.pm:
2253         (builtDylibPathForName):
2254
2255 2012-10-22  Mikhail Naganov  <mnaganov@chromium.org>
2256
2257         [Chromium] Add supportMultipleWindows setting, needed for Android
2258         https://bugs.webkit.org/show_bug.cgi?id=99716
2259
2260         Reviewed by Adam Barth.
2261
2262         Add supportMultipleWindows settings for reusing the same view when
2263         opening popups. This is required for emulating the behavior of
2264         Android WebView. Adding into WebCore, as other ports might want to
2265         use this setting in the future.
2266
2267         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2268         (DRTTestRunner::overridePreference):
2269         * DumpRenderTree/chromium/WebPreferences.cpp:
2270         (WebPreferences::reset):
2271         (WebPreferences::applyTo):
2272         * DumpRenderTree/chromium/WebPreferences.h:
2273         (WebPreferences):
2274
2275 2012-10-25  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2276
2277         [EFL][WK2] JavaScript popups are not focused when opened
2278         https://bugs.webkit.org/show_bug.cgi?id=100354
2279
2280         Reviewed by Kenneth Rohde Christiansen.
2281
2282         Move focus to the JavaScript popups when opened so that the key events
2283         are forwarded to the popups instead of web view.
2284
2285         * MiniBrowser/efl/main.c:
2286         (on_javascript_alert):
2287         (on_javascript_confirm):
2288         (on_javascript_prompt):
2289
2290 2012-10-25  Eugene Klyuchnikov  <eustas.bug@gmail.com>
2291
2292         Web Inspector: Fix "check-inspector-strings" script and fix localized strings.
2293         https://bugs.webkit.org/show_bug.cgi?id=100090
2294
2295         Reviewed by Vsevolod Vlasov.
2296
2297         Script "check-inspector-strings" seems to be broken.
2298         Fixed it, refined search algorithm.
2299
2300         * Scripts/check-inspector-strings: Fixed and refined.
2301
2302 2012-10-24  Dirk Pranke  <dpranke@chromium.org>
2303
2304         nrwt: fix a couple of minor crashing issues under cygwin
2305         https://bugs.webkit.org/show_bug.cgi?id=100309
2306
2307         Reviewed by Ojan Vafai.
2308
2309         Cygwin was crashing on a null object reference and then
2310         an oserror in kill().
2311
2312         * Scripts/webkitpy/common/system/executive.py:
2313         (Executive.kill_process):
2314         * Scripts/webkitpy/layout_tests/port/server_process.py:
2315         (ServerProcess.stop):
2316
2317 2012-10-24  Dirk Pranke  <dpranke@chromium.org>
2318
2319         nrwt: truncate meter lines properly on windows
2320         https://bugs.webkit.org/show_bug.cgi?id=100062
2321
2322         Reviewed by Tony Chang.
2323
2324         This change adds the code to figure out the terminal width
2325         on windows (it was already there for Unixen) and moves it
2326         to a platform-specific object.
2327
2328         * Scripts/webkitpy/common/system/platforminfo.py:
2329         (PlatformInfo.terminal_width):
2330         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2331         (MockPlatformInfo.total_bytes_memory):
2332         (MockPlatformInfo):
2333         (MockPlatformInfo.terminal_width):
2334         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
2335         (MeteredStream.__init__):
2336         (MeteredStream.number_of_columns):
2337         (MeteredStream.flush):
2338         * Scripts/webkitpy/layout_tests/views/printing.py:
2339         (Printer.__init__):
2340         (Printer._test_status_line):
2341
2342 2012-10-24  Dirk Pranke  <dpranke@chromium.org>
2343
2344         tweak debug logging in webkit-patch optimize-baselines
2345         https://bugs.webkit.org/show_bug.cgi?id=100294
2346
2347         Reviewed by Ojan Vafai.
2348
2349         This changes the logging to print out the baselines found
2350         (and their checksums) even when we don't do anything.
2351
2352         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
2353         (BaselineOptimizer.optimize):
2354
2355 2012-10-24  Sailesh Agrawal  <sail@chromium.org>
2356
2357         Incorrect keycodes for numpad /, -, +, .
2358         https://bugs.webkit.org/show_bug.cgi?id=99188
2359
2360         Reviewed by Tony Chang.
2361
2362         Add key mappings for all numpad keys.
2363
2364         * DumpRenderTree/mac/EventSendingController.mm:
2365         (KeyMappingEntry):
2366         (-[EventSendingController keyDown:withModifiers:withLocation:]): Added all numpad keys.
2367
2368 2012-10-24  Dirk Pranke  <dpranke@chromium.org>
2369
2370         webkitpy: clean up references to Skipped files
2371         https://bugs.webkit.org/show_bug.cgi?id=100045
2372
2373         Reviewed by Ojan Vafai.
2374
2375         Since they are no longer used or needed ...
2376
2377         * Scripts/webkitpy/layout_tests/port/apple.py:
2378         (ApplePort._generate_all_test_configurations):
2379         * Scripts/webkitpy/layout_tests/port/base.py:
2380         (Port.skipped_layout_tests):
2381         (Port.expectations_files):
2382         (Port._wk2_port_name):
2383         * Scripts/webkitpy/layout_tests/port/gtk.py:
2384         (GtkPort):
2385         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2386         (MacTest.test_default_timeout_ms):
2387         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2388         (test_expectations_files):
2389         (test_expectations_files.platform_dirs):
2390         * Scripts/webkitpy/layout_tests/port/qt.py:
2391         (QtPort.__init__):
2392
2393 2012-10-24  Jochen Eisinger  <jochen@chromium.org>
2394
2395         [chromium] Use include paths relative to Source/ in the TestRunner's public API
2396         https://bugs.webkit.org/show_bug.cgi?id=100079
2397
2398         Reviewed by Adam Barth.
2399
2400         For a inside-chromium build, we usually don't add the WebKit API paths
2401         as include paths, so including files by name only does not work.
2402
2403         Eventually we might want to move to a model where all includes are
2404         relative to Source/, so we're using that here already now.
2405
2406         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2407         * DumpRenderTree/chromium/TestRunner/public/WebEventSender.h:
2408         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2409
2410 2012-10-24  Ojan Vafai  <ojan@chromium.org>
2411
2412         Show an error when there are no completed builds in the past 20 runs
2413         https://bugs.webkit.org/show_bug.cgi?id=100266
2414
2415         Reviewed by Dimitri Glazkov.
2416
2417         Right now we get a cryptic JS error in the console when loading the gtk port. This at least gives an error in
2418         the notification stream. We should probably tweak this UI to make it so we can make
2419         errors in the notification stream stick out (e.g. make the text red).
2420
2421         We should also consider making the number of runs to load dynamic (e.g. if 20 runs don't work,
2422         try 40).
2423
2424         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
2425         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
2426         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
2427
2428 2012-10-24  Ian Vollick  <vollick@chromium.org>
2429
2430         [chromium] Explicitly disable accelerated animations in DRT
2431         https://bugs.webkit.org/show_bug.cgi?id=100241
2432
2433         Reviewed by Adrienne Walker.
2434
2435         Disable accelerated animations by default in DRT.        
2436
2437         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2438         (main):
2439         * DumpRenderTree/chromium/TestShell.cpp:
2440         (TestShell::setAcceleratedAnimationEnabled):
2441         * DumpRenderTree/chromium/TestShell.h:
2442         (TestShell):
2443
2444 2012-10-24  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
2445
2446         [Qt] Move the QQuickWebViewExperimental pointer to QQuickWebViewPrivate
2447         https://bugs.webkit.org/show_bug.cgi?id=100253
2448
2449         Reviewed by Kenneth Rohde Christiansen.
2450
2451         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2452         (WTR::WrapperWindow::handleStatusChanged):
2453         Use QQuickWebView::experimental rather than creating a new instance.
2454
2455 2012-10-24  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2456
2457         [EFL] run-webkit-tests writes garbage on stderr when running on Xvfb
2458         https://bugs.webkit.org/show_bug.cgi?id=100243
2459
2460         Reviewed by Kenneth Rohde Christiansen.
2461
2462         These errors generate noise on the reports and in some cases, like when
2463         running perf tests, makes the test fail. By using Xext, we can add a
2464         dummy handler to ignore these errors.
2465
2466         We could have added this handler on the top level EWK API, but that
2467         would be intrusive and could override handlers defined by the user.
2468
2469         * WebKitTestRunner/PlatformEfl.cmake:
2470         * WebKitTestRunner/efl/main.cpp:
2471         (dummyExtensionErrorHandler):
2472         (main):
2473
2474 2012-10-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2475
2476         Unreviewed. Fix the GTK+ build.
2477
2478         * TestWebKitAPI/GNUmakefile.am: Add GTK_FLAGS to
2479         libTestWebKitAPIMain and webcore cflags to TestGtk.
2480
2481 2012-10-24  Zeno Albisser  <zeno@webkit.org>
2482
2483         Implement GraphicsSurface for Windows.
2484         https://bugs.webkit.org/show_bug.cgi?id=98147
2485
2486         Reviewed by Kenneth Rohde Christiansen.
2487
2488         * qmake/mkspecs/features/features.prf:
2489                 Activate GraphicsSurface on windows in case opengles2 (ANGLE)
2490                 is available in QT_CONFIG.
2491
2492 2012-10-24  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2493
2494         [EFL][WK2] fast/repaint/delete-into-nested-block.html and fast/repaint/4776765.html are flaky
2495         https://bugs.webkit.org/show_bug.cgi?id=100010
2496
2497         Reviewed by Kenneth Rohde Christiansen.
2498
2499         Force the main view to receive focus even if Evas already
2500         considers it to be focused.
2501
2502         It might happen that a different frame is focused by a page and
2503         the focus change notification does not reach Evas. When another
2504         test is run, the main frame is then not considered to be focused
2505         by WebCore, and things such as focus rings are not drawn as
2506         expected.
2507
2508         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2509         (WTR::PlatformWebView::focus):
2510
2511 2012-10-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2512
2513         Unreviewed, rolling out r132333.
2514         http://trac.webkit.org/changeset/132333
2515         https://bugs.webkit.org/show_bug.cgi?id=100234
2516
2517         Crashes many tests on the EFL-WK2 bot. (Requested by rakuco on
2518         #webkit).
2519
2520         * WebKitTestRunner/TestController.cpp:
2521         (WTR::TestController::resetStateToConsistentValues):
2522         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2523         (WTR::TestController::platformInitializeContext):
2524
2525 2012-10-24  Dongwoo Joshua Im  <dw.im@samsung.com>
2526
2527         [GTK] Fix build break - undefined reference to 'gtk_init'
2528         https://bugs.webkit.org/show_bug.cgi?id=100221
2529
2530         Unreviewed build fix.
2531
2532         GTK_LIBS is needed for TestWTF.
2533
2534         * TestWebKitAPI/GNUmakefile.am:
2535
2536 2012-10-24  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
2537
2538         WebKitTestRunner needs to turn on 'setContinuousSpellCheckingEnabled'
2539         https://bugs.webkit.org/show_bug.cgi?id=93611
2540
2541         Reviewed by Hajime Morita.
2542
2543         WebKitTestRunner enables spelling feature to pass the layout tests from editing/spelling.
2544
2545         * WebKitTestRunner/TestController.cpp:
2546         (WTR::TestController::resetStateToConsistentValues):
2547         Enables spelling by WebKit2 C API.
2548
2549         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2550         (WTR::TestController::platformInitializeContext):
2551         Attaches WKTextChecker's client and sets default language for WebKit2-EFL port.
2552
2553 2012-10-24  Mario Sanchez Prada  <mario@webkit.org>
2554
2555         [WK2] [GTK] TestWebKitAccessibility is not being run
2556         https://bugs.webkit.org/show_bug.cgi?id=100102
2557
2558         Reviewed by Carlos Garcia Campos.
2559
2560         Removed wrong early return in _start_accessibility_daemons().
2561
2562         * Scripts/run-gtk-tests:
2563         (TestRunner._lookup_atspi2_binary): Removed wrong line.
2564
2565 2012-10-24  Noel Gordon  <noel.gordon@gmail.com>
2566
2567         [chromium] Plumb DRT WebkitShouldRespectImageOrientation through to page settings 
2568         https://bugs.webkit.org/show_bug.cgi?id=100197
2569
2570         Reviewed by Kent Tamura.
2571
2572         fast/images/exif-orientation.html and fast/images/exif-orientation-css.html require a DRT
2573         WebkitShouldRespectImageOrientation preference.  Add the chromium implementation for this
2574         preference and plumb it through to page settings.
2575
2576         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2577         (DRTTestRunner::overridePreference): Update the tests WebkitShouldRespectImageOrientation
2578         setting in DRT prefs.
2579         * DumpRenderTree/chromium/WebPreferences.cpp:
2580         (WebPreferences::reset): Disable the preference before and after each test.
2581         (WebPreferences::applyTo): Apply the preference to the page settings of each test.
2582         * DumpRenderTree/chromium/WebPreferences.h:
2583         (WebPreferences):
2584
2585 2012-10-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2586
2587         [GTK] TestWebKitAPI/TestWebKit2 and TestWebKitAPI/TestGtk link to the installed libs
2588         https://bugs.webkit.org/show_bug.cgi?id=100134
2589
2590         Reviewed by Martin Robinson.
2591
2592         Do not share the LDADD variable among TestWTF, TestWebKit2 and
2593         TestGtk.
2594
2595         * TestWebKitAPI/GNUmakefile.am:
2596
2597 2012-10-23  Kihong Kwon  <kihong.kwon@samsung.com>
2598
2599         Unreviewed. Adding myself as committer.
2600
2601         * Scripts/webkitpy/common/config/committers.py:
2602
2603 2012-10-23  Dan Bernstein  <mitz@apple.com>
2604
2605         Tools changes for <rdar://problem/2966974> [mac] Kerning and ligatures are not enabled by default
2606         https://bugs.webkit.org/show_bug.cgi?id=100188
2607
2608         Reviewed by Sam Weinig.
2609
2610         Disable kerning and ligatures by default when running the tests.
2611
2612         * DumpRenderTree/mac/DumpRenderTree.mm:
2613         (resetDefaultsToConsistentValues): Set a value of NO for the
2614         WebKitKerningAndLigaturesEnabledByDefault user default.
2615         * WebKitTestRunner/mac/main.mm:
2616         (main): Register a value of NO for the WebKitKerningAndLigaturesEnabledByDefault user
2617         default.
2618
2619 2012-10-23  Simon Fraser  <simon.fraser@apple.com>
2620
2621         Allow tests to run with a tile cache, and optionally dump the tile cache via layerTreeAsText()
2622         https://bugs.webkit.org/show_bug.cgi?id=100159
2623
2624         Reviewed by Tim Horton.
2625
2626         Make WebKitTestRunner use a WKView with a tile cache for tests run in a directory
2627         whose path includes "tiled-drawing". It does this by passing around a WKDictionary 
2628         of options, and if the current PlatformWebView doesn't support those options, it will
2629         create a new one.
2630
2631         * WebKitTestRunner/PlatformWebView.h:
2632         (PlatformWebView): Add a WKDictionaryRef options dictionary argument.
2633         (WTR::PlatformWebView::viewSupportsOptions): Returns true if the view
2634         supports the options in the WKDictionaryRef.
2635         * WebKitTestRunner/TestController.cpp:
2636         (WTR::TestController::initialize): Call createWebViewWithOptions() with
2637         no options in the normal case.
2638         (WTR::TestController::createWebViewWithOptions): Moved code into this fuction
2639         so we can call it in two places.
2640         (WTR::TestController::ensureViewSupportsOptions): If the current view
2641         doesn't support the given options, throw it away and makea  new one that does.
2642         * WebKitTestRunner/TestController.h:
2643         * WebKitTestRunner/TestInvocation.cpp:
2644         (WTR::shouldUseTiledDrawing): Return true if the directory contains "tiled-drawing".
2645         (WTR::updateTiledDrawingForCurrentTest): Tell the TestController to check whether
2646         the view supports the given options. No-op for non-Mac platforms.
2647         (WTR::TestInvocation::invoke): Call updateTiledDrawingForCurrentTest().
2648         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2649         (WTR::PlatformWebView::PlatformWebView): New constructor parameter.
2650         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2651         (WTR::PlatformWebView::PlatformWebView):  New constructor parameter.
2652         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2653         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:useTiledDrawing:]):
2654         (-[TestRunnerWKView _shouldUseTiledDrawingArea]): Subclass the WKView so we can return
2655         a custom value from this method.
2656         (WTR::PlatformWebView::PlatformWebView):
2657         (WTR::PlatformWebView::viewSupportsOptions):
2658         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2659         (WTR::PlatformWebView::PlatformWebView): New constructor parameter.
2660         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2661         (WTR::PlatformWebView::PlatformWebView): New constructor parameter.
2662
2663 2012-10-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2664
2665         Unreviewed, rolling out r132276.
2666         http://trac.webkit.org/changeset/132276
2667         https://bugs.webkit.org/show_bug.cgi?id=100189
2668
2669         It broke the Qt-WK2 build intentionally (Requested by
2670         Ossy_night on #webkit).
2671
2672         * WebKitTestRunner/PlatformWebView.h:
2673         (PlatformWebView):
2674         * WebKitTestRunner/TestController.cpp:
2675         (WTR::TestController::initialize):
2676         * WebKitTestRunner/TestController.h:
2677         (TestController):
2678         * WebKitTestRunner/TestInvocation.cpp:
2679         (WTR):
2680         (WTR::TestInvocation::invoke):
2681         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2682         (WTR::PlatformWebView::PlatformWebView):
2683         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2684         (WTR::PlatformWebView::PlatformWebView):
2685         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2686         (WTR::PlatformWebView::PlatformWebView):
2687         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2688         (WTR::PlatformWebView::PlatformWebView):
2689         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2690         (WTR::PlatformWebView::PlatformWebView):
2691
2692 2012-10-23  Martin Robinson  <mrobinson@igalia.com>
2693
2694         [GTK][Soup] Implement the default authentication dialog via WebCoreSupport
2695         https://bugs.webkit.org/show_bug.cgi?id=99351
2696
2697         Reviewed by Carlos Garcia Campos.
2698
2699         We no longer need to turn off the soup authentication dialog soup feature,
2700         because it's not installed.
2701
2702         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2703         (setDefaultsToConsistentStateValuesForTesting): Don't turn off the feature any longer.
2704
2705 2012-10-23  Simon Fraser  <simon.fraser@apple.com>
2706
2707         Allow tests to run with a tile cache, and optionally dump the tile cache via layerTreeAsText()
2708         https://bugs.webkit.org/show_bug.cgi?id=100159
2709
2710         Reviewed by Tim Horton.
2711
2712         Make WebKitTestRunner use a WKView with a tile cache for tests run in a directory
2713         whose path includes "tiled-drawing". It does this by passing around a WKDictionary 
2714         of options, and if the current PlatformWebView doesn't support those options, it will
2715         create a new one.
2716
2717         * WebKitTestRunner/PlatformWebView.h:
2718         (PlatformWebView): Add a WKDictionaryRef options dictionary argument.
2719         (WTR::PlatformWebView::viewSupportsOptions): Returns true if the view
2720         supports the options in the WKDictionaryRef.
2721         * WebKitTestRunner/TestController.cpp:
2722         (WTR::TestController::initialize): Call createWebViewWithOptions() with
2723         no options in the normal case.
2724         (WTR::TestController::createWebViewWithOptions): Moved code into this fuction
2725         so we can call it in two places.
2726         (WTR::TestController::ensureViewSupportsOptions): If the current view
2727         doesn't support the given options, throw it away and makea  new one that does.
2728         * WebKitTestRunner/TestController.h:
2729         * WebKitTestRunner/TestInvocation.cpp:
2730         (WTR::shouldUseTiledDrawing): Return true if the directory contains "tiled-drawing".
2731         (WTR::updateTiledDrawingForCurrentTest): Tell the TestController to check whether
2732         the view supports the given options. No-op for non-Mac platforms.
2733         (WTR::TestInvocation::invoke): Call updateTiledDrawingForCurrentTest().
2734         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2735         (WTR::PlatformWebView::PlatformWebView): New constructor parameter.
2736         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2737         (WTR::PlatformWebView::PlatformWebView):  New constructor parameter.
2738         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2739         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:useTiledDrawing:]):
2740         (-[TestRunnerWKView _shouldUseTiledDrawingArea]): Subclass the WKView so we can return
2741         a custom value from this method.
2742         (WTR::PlatformWebView::PlatformWebView):
2743         (WTR::PlatformWebView::viewSupportsOptions):
2744         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2745         (WTR::PlatformWebView::PlatformWebView): New constructor parameter.
2746         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2747         (WTR::PlatformWebView::PlatformWebView): New constructor parameter.
2748
2749 2012-10-23  David Barton  <dbarton@mathscribe.com>
2750
2751         [MathML] Symbol font uses greek letters for roman ones on linux and Windows
2752         https://bugs.webkit.org/show_bug.cgi?id=99921
2753
2754         Reviewed by Eric Seidel.
2755
2756         Enable the STIXSizeOneSym font for testing.
2757
2758         * DumpRenderTree/mac/DumpRenderTree.mm:
2759         (allowedFontFamilySet):
2760         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
2761         (WTR::allowedFontFamilySet):
2762
2763 2012-10-23  Tony Chang  <tony@chromium.org>
2764
2765         [chromium] Chromium window build system does not rebuild correctly when enabling/disabling a feature
2766         https://bugs.webkit.org/show_bug.cgi?id=38926
2767
2768         Reviewed by Eric Seidel.
2769
2770         Remove hack for clobbering build when features.gypi changes. Now that
2771         Chromium requires VS2010 or newer, this bug has gone away.
2772
2773         * Scripts/update-webkit:
2774
2775 2012-10-23  Jochen Eisinger  <jochen@chromium.org>
2776
2777         [chromium] remove the const qualifier from WebTestDelegate::printMessage
2778         https://bugs.webkit.org/show_bug.cgi?id=100082
2779
2780         Reviewed by Adam Barth.
2781
2782         There's no reason the method should be const, and indeed for
2783         content_shell we want to send an IPC which is a non-const operation.
2784
2785         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2786         (WebTestDelegate):
2787         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
2788         (TestDelegate):
2789         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2790         (WebTestInterfaces::Internal):
2791         (WebTestRunner::WebTestInterfaces::Internal::printMessage):
2792         * DumpRenderTree/chromium/WebViewHost.cpp:
2793         (WebViewHost::printMessage):
2794         * DumpRenderTree/chromium/WebViewHost.h:
2795         (WebViewHost):
2796
2797 2012-10-23  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2798
2799         Add support for resolution media query
2800         https://bugs.webkit.org/show_bug.cgi?id=99077
2801
2802         Reviewed by Antti Koivisto.
2803
2804         Add support for the RESOLUTION_MEDIA_QUERY feature flag.
2805
2806         * Scripts/webkitperl/FeatureList.pm:
2807         * qmake/mkspecs/features/features.pri:
2808
2809 2012-10-23  Bruno de Oliveira Abinader  <bruno.abinader@basyskom.com>
2810
2811         Adding myself to commiters.py
2812         https://bugs.webkit.org/show_bug.cgi?id=100122
2813
2814         Unreviewed update to commiters.py.
2815
2816         * Scripts/webkitpy/common/config/committers.py:
2817
2818 2012-10-23  Timothy Hatcher  <timothy@apple.com>
2819
2820         Unreviewed watchlist change to monitor Inspector IDLs.
2821
2822         * Scripts/webkitpy/common/config/watchlist:
2823
2824 2012-10-23  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2825
2826         [WK2] [WTR] WebKitTestRunner needs testRunner.queueForwardNavigation
2827         https://bugs.webkit.org/show_bug.cgi?id=99700
2828
2829         Reviewed by Kenneth Rohde Christiansen.
2830
2831         Implemented testRunner.queueForwardNavigation, made little refactoring in Work Queue
2832         to obviate code duplication.
2833
2834         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2835         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2836         (WTR::InjectedBundle::queueBackNavigation):
2837         (WTR):
2838         (WTR::InjectedBundle::queueForwardNavigation):
2839         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2840         (InjectedBundle):
2841         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2842         (WTR::TestRunner::queueForwardNavigation):
2843         (WTR):
2844         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2845         (TestRunner):
2846         * WebKitTestRunner/TestInvocation.cpp:
2847         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2848         * WebKitTestRunner/WorkQueueManager.cpp:
2849         (NavigationItem):
2850         (WTR::NavigationItem::NavigationItem):
2851         (WTR::NavigationItem::invoke):
2852         (WTR):
2853         (WTR::WorkQueueManager::queueBackNavigation):
2854         (WTR::WorkQueueManager::queueForwardNavigation):
2855         * WebKitTestRunner/WorkQueueManager.h:
2856         (WorkQueueManager):
2857
2858 2012-10-23  Simon Hausmann  <simon.hausmann@digia.com>
2859
2860         Unreviewed trivial Qt build fix: Fix build without USE_3D_GRAPHICS
2861
2862         Disable USE_GRAPHICS_SURFACE if we don't have USE_3D_GRAPHICS because
2863         GraphicsSurface.h needs GraphicsContext3D.
2864
2865         * qmake/mkspecs/features/features.prf:
2866
2867 2012-10-23  Simon Pena  <spena@igalia.com>
2868
2869         Unreviewed. Adding myself as committer.
2870
2871         * Scripts/webkitpy/common/config/committers.py:
2872
2873 2012-10-22  Jochen Eisinger  <jochen@chromium.org>
2874
2875         [chromium] Move the call to RegisterIsolatedFileSystem to the WebTestDelegate interface
2876         https://bugs.webkit.org/show_bug.cgi?id=100048
2877
2878         Reviewed by Adam Barth.
2879
2880         The call needs to be done outside of the sandbox.
2881
2882         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2883         (WebTestDelegate):
2884         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
2885         (WebTestRunner):
2886         (WebTestRunner::EventSender::beginDragWithFiles):
2887         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
2888         (TestDelegate):
2889         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2890         (WebTestInterfaces::Internal):
2891         (WebTestRunner::WebTestInterfaces::Internal::registerIsolatedFileSystem):
2892         (WebTestRunner):
2893         * DumpRenderTree/chromium/WebViewHost.cpp:
2894         (WebViewHost::registerIsolatedFileSystem):
2895         * DumpRenderTree/chromium/WebViewHost.h:
2896         (WebViewHost):
2897
2898 2012-10-22  Dirk Pranke  <dpranke@chromium.org>
2899
2900         webkitpy: remove unneeded debug messages from find_files()
2901         https://bugs.webkit.org/show_bug.cgi?id=100041
2902
2903         Reviewed by Adam Barth.
2904
2905         This routine gets called all the time when loading the virtual
2906         suites, and the debug messages were spamming me.
2907
2908         * Scripts/webkitpy/common/find_files.py:
2909         (_normalized_find):
2910
2911 2012-10-22  Tony Chang  <tony@chromium.org>
2912
2913         [chromium] Add Mac 10.7 Debug bot since it's on the waterfall
2914         https://bugs.webkit.org/show_bug.cgi?id=100028
2915
2916         Reviewed by Eric Seidel.
2917
2918         garden-o-matic can't baseline without this entry.
2919
2920         * Scripts/webkitpy/layout_tests/port/builders.py:
2921
2922 2012-10-22  Jochen Eisinger  <jochen@chromium.org>
2923
2924         [chromium] introduce WebTask to the TestRunner library
2925         https://bugs.webkit.org/show_bug.cgi?id=99964
2926
2927         Reviewed by Adam Barth.
2928
2929         I'm also removing the dependency on webkit_support, and instead go
2930         through the WebTestDelegate interface.
2931
2932         * DumpRenderTree/DumpRenderTree.gypi:
2933         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2934         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2935         (DRTDevToolsAgent::taskList):
2936         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
2937         * DumpRenderTree/chromium/DRTDevToolsClient.h:
2938         (DRTDevToolsClient::taskList):
2939         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2940         (InvokeCallbackTask::InvokeCallbackTask):
2941         * DumpRenderTree/chromium/DRTTestRunner.h:
2942         (DRTTestRunner::taskList):
2943         (DRTTestRunner::WorkQueue::taskList):
2944         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2945         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
2946         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
2947         (RTCStatsRequestSucceededTask::RTCStatsRequestSucceededTask):
2948         (RTCVoidRequestTask::RTCVoidRequestTask):
2949         (StringDataTask::StringDataTask):
2950         (CharPtrDataTask::CharPtrDataTask):
2951         (DataChannelReadyStateTask::DataChannelReadyStateTask):
2952         (RTCPeerConnectionReadyStateTask::RTCPeerConnectionReadyStateTask):
2953         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2954         (MockWebRTCPeerConnectionHandler):
2955         (MockWebRTCPeerConnectionHandler::taskList):
2956         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
2957         (MockWebSpeechInputController::SpeechTask::SpeechTask):
2958         * DumpRenderTree/chromium/MockWebSpeechInputController.h:
2959         (MockWebSpeechInputController::taskList):
2960         (MockWebSpeechInputController):
2961         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
2962         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
2963         (MockWebSpeechRecognizer::taskList):
2964         (MockWebSpeechRecognizer):
2965         (MockWebSpeechRecognizer::StepTask::StepTask):
2966         * DumpRenderTree/chromium/Task.cpp: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/Task.cpp.
2967         (WebTestRunner):
2968         (WebTestRunner::invokeTask):
2969         (TaskWrapper):
2970         (WebTestRunner::TaskWrapper::TaskWrapper):
2971         (WebTestRunner::TaskWrapper::~TaskWrapper):
2972         (WebTestRunner::TaskWrapper::Run):
2973         (postTask):
2974         (postDelayedTask):
2975         * DumpRenderTree/chromium/Task.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h.
2976         (WebTestRunner):
2977         * DumpRenderTree/chromium/TestRunner/public/WebTask.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/Task.h.
2978         (WebTestRunner):
2979         (WebTask):
2980         (WebTaskList):
2981         (WebMethodTask):
2982         (WebTestRunner::WebMethodTask::WebMethodTask):
2983         (WebTestRunner::WebMethodTask::~WebMethodTask):
2984         (WebTestRunner::WebMethodTask::run):
2985         (WebTestRunner::WebMethodTask::cancel):
2986         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2987         (WebTestRunner):
2988         (WebTestDelegate):
2989         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
2990         (WebTestRunner):
2991         (WebTestRunner::EventSender::scheduleAsynchronousClick):
2992         (WebTestRunner::KeyDownTask::KeyDownTask):
2993         (WebTestRunner::EventSender::scheduleAsynchronousKeyDown):
2994         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
2995         (WebTestRunner::EventSender::taskList):
2996         (EventSender):
2997         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
2998         (WebTestRunner):
2999         (TestDelegate):
3000         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3001         * DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/Task.cpp.
3002         (WebTestRunner):
3003         (WebTestRunner::WebTask::WebTask):
3004         (WebTestRunner::WebTask::~WebTask):
3005         (WebTestRunner::WebTaskList::WebTaskList):
3006         (WebTestRunner::WebTaskList::~WebTaskList):
3007         (WebTestRunner::WebTaskList::registerTask):
3008         (WebTestRunner::WebTaskList::unregisterTask):
3009         (WebTestRunner::WebTaskList::revokeAll):
3010         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3011         (WebTestInterfaces::Internal):
3012         (WebTestRunner::WebTestInterfaces::Internal::postTask):
3013         (WebTestRunner):
3014         (WebTestRunner::WebTestInterfaces::Internal::postDelayedTask):
3015         * DumpRenderTree/chromium/TestShell.cpp:
3016         (TestShell::initialize):
3017         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
3018         (UserMediaRequestTask::UserMediaRequestTask):
3019         * DumpRenderTree/chromium/WebUserMediaClientMock.h:
3020         (WebUserMediaClientMock::taskList):
3021         (WebUserMediaClientMock):
3022         * DumpRenderTree/chromium/WebViewHost.cpp:
3023         (WebViewHost::postTask):
3024         (WebViewHost::postDelayedTask):
3025         * DumpRenderTree/chromium/WebViewHost.h:
3026         (WebViewHost):
3027         (WebViewHost::taskList):
3028         (WebViewHost::HostMethodTask::HostMethodTask):
3029
3030 2012-10-22  Ojan Vafai  <ojan@chromium.org>
3031
3032         Update flakiness dashboard to match the state of the builders.
3033         * TestResultServer/static-dashboards/builders.js:
3034         (isChromiumDepsGTestRunner):
3035         Broaden the filter since Chromium naming scheme is not consistent.
3036         (loadBuildersList):
3037         The main Chromium master now only runs builders, no tests.
3038         * TestResultServer/static-dashboards/dashboard_base.js:
3039         Remove test suites that no longer run on any of these masters.
3040
3041 2012-10-22  Jochen Eisinger  <jochen@chromium.org>
3042
3043         [chromium] add a method for printing message to the WebTestDelegate
3044         https://bugs.webkit.org/show_bug.cgi?id=99960
3045
3046         Reviewed by Adam Barth.
3047
3048         When using the TestRunner library from the content_shell, we can't print
3049         message directly but need to send them to the browser process.
3050
3051         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3052         (WebTestDelegate):
3053         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp:
3054         (WebTestRunner::AccessibilityController::fallbackCallback):
3055         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h:
3056         (WebTestRunner::AccessibilityController::setDelegate):
3057         (AccessibilityController):
3058         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
3059         (WebTestRunner):
3060         (WebTestRunner::EventSender::dumpFilenameBeingDragged):
3061         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp:
3062         (GamepadController::connect):
3063         (GamepadController::disconnect):
3064         (GamepadController::setId):
3065         (GamepadController::setButtonCount):
3066         (GamepadController::setButtonData):
3067         (GamepadController::setAxisCount):
3068         (GamepadController::setAxisData):
3069         (GamepadController::fallbackCallback):
3070         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
3071         (TestDelegate):
3072         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3073         (TestInterfaces::~TestInterfaces):
3074         (TestInterfaces::setDelegate):
3075         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3076         (WebTestInterfaces::Internal):
3077         (WebTestRunner::WebTestInterfaces::Internal::printMessage):
3078         (WebTestRunner):
3079         * DumpRenderTree/chromium/WebViewHost.cpp:
3080         (WebViewHost::didBeginEditing):
3081         (WebViewHost::lastContextMenuData):
3082         (WebViewHost::clearContextMenuData):
3083         (WebViewHost::setEditCommand):
3084         (WebViewHost::clearEditCommand):
3085         (WebViewHost::fillSpellingSuggestionList):
3086         (WebViewHost::setGamepadData):
3087         (WebViewHost::printMessage):
3088         * DumpRenderTree/chromium/WebViewHost.h:
3089         (WebViewHost):
3090
3091 2012-10-22  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3092
3093         I now only watch Selectors instead of all of CSS.
3094
3095         Unreviewed update of watchlist.
3096
3097         * Scripts/webkitpy/common/config/watchlist:
3098
3099 2012-10-22  Yury Semikhatsky  <yurys@chromium.org>
3100
3101         Make sure base and derived class pointers are different in MemoryInstrumentationTest.instrumentedWithMultipleAncestors
3102         https://bugs.webkit.org/show_bug.cgi?id=99987
3103
3104         Reviewed by Alexander Pavlov.
3105
3106         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp: changed first parent
3107         class in the list so that it has virtual table as well as the second one. This
3108         way we may be sure that pointer to the second ancestor class will differ from
3109         the pointer to the derived class.
3110
3111 2012-10-22  Yury Semikhatsky  <yurys@chromium.org>
3112
3113         Unreviewed. Fix compilation after r132059.
3114
3115         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
3116
3117 2012-10-22  Dominik Röttsches  <dominik.rottsches@intel.com>
3118
3119         Adding Cairo and Harfbuzz watchlist entries
3120
3121         Unreviewed watchlist update.
3122
3123         Added myself to these new ones and SVG.
3124
3125         * Scripts/webkitpy/common/config/watchlist:
3126
3127 2012-10-22  Yury Semikhatsky  <yurys@chromium.org>
3128
3129         Web Inspector: do not double count memory of objects with multiple ancestors
3130         https://bugs.webkit.org/show_bug.cgi?id=99958
3131
3132         Reviewed by Alexander Pavlov.
3133
3134         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp: Test that there
3135         is no double counting in case of multiple inheritance.
3136
3137 2012-10-22  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3138
3139         [Qt] Basic gesture event handling
3140         https://bugs.webkit.org/show_bug.cgi?id=66173
3141
3142         Reviewed by Simon Hausmann.
3143
3144         Add support for eventSender.gestureLongPress.
3145
3146         * DumpRenderTree/qt/EventSenderQt.cpp:
3147         (EventSender::EventSender):
3148         (EventSender::gestureLongPress):
3149         * DumpRenderTree/qt/EventSenderQt.h:
3150         (EventSender):
3151
3152 2012-10-22  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3153
3154         [WTR] Properly initialize TestRunner::m_dumpSelectionRect.
3155         https://bugs.webkit.org/show_bug.cgi?id=99970
3156
3157         Reviewed by Kenneth Rohde Christiansen.
3158
3159         Follow-up to r131476: actually initialize m_dumpSelectionRect to
3160         some value to avoid some flakyness in the tests.
3161
3162         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3163         (WTR::TestRunner::TestRunner):
3164
3165 2012-10-22  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
3166
3167         [Qt] Don't build any of the tools in production_build
3168
3169         Reviewed by Simon Hausmann.
3170
3171         * Tools.pro:
3172         * qmake/mkspecs/features/configure.prf:
3173
3174 2012-10-22  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
3175
3176         [Qt] Move OBJECTS_DIR and friends to default_pre.prf
3177
3178         The introduction of load(qt_build_config) in .qmake.conf meant
3179         that we started loading qtmodule.pri, which in turn set both
3180         MOC_DIR, RCC_DIR, and OBJECTS_DIR.
3181
3182         We were setting OBJECTS_DIR in default_post under a isEmpty() guard
3183         so that project files could override the objects dir. Instead of
3184         using the isEmpty() check we move it to defaul_pre, which will
3185         override the qtmodule.pri settings, but still allow project files
3186         to override it.
3187
3188         Reviewed by Ossy.
3189
3190         * qmake/mkspecs/features/default_post.prf:
3191         * qmake/mkspecs/features/default_pre.prf:
3192
3193 2012-10-22  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3194
3195         WebKitTestRunner needs testRunner.queueLoadingScript and testRunner.queueNonLoadingScript
3196         https://bugs.webkit.org/show_bug.cgi?id=42675
3197
3198         Reviewed by Kenneth Rohde Christiansen.
3199
3200         Added implementation of testRunner.queueLoadingScript and testRunner.queueNonLoadingScript.
3201
3202         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3203         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3204         (WTR::InjectedBundle::queueLoadingScript):
3205         (WTR):
3206         (WTR::InjectedBundle::queueNonLoadingScript):
3207         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3208         (InjectedBundle):
3209         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3210         (WTR::TestRunner::queueLoadingScript):
3211         (WTR):
3212         (WTR::TestRunner::queueNonLoadingScript):
3213         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3214         (TestRunner):
3215         * WebKitTestRunner/TestInvocation.cpp:
3216         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3217         * WebKitTestRunner/WorkQueueManager.cpp:
3218         (WTR):
3219         (WTR::runJavaScriptFunction):
3220         (ScriptItem):
3221         (WTR::ScriptItem::ScriptItem):
3222         (WTR::ScriptItem::invoke):
3223         (WTR::WorkQueueManager::queueBackNavigation):
3224         (WTR::WorkQueueManager::queueLoadingScript):
3225         (WTR::WorkQueueManager::queueNonLoadingScript):
3226         * WebKitTestRunner/WorkQueueManager.h:
3227         (WorkQueueManager):
3228
3229 2012-10-22  Zan Dobersek  <zandobersek@gmail.com>
3230
3231         Unreviewed, a follow-up to r132034 where I forgot to address
3232         Ojan's review comment about the race condition in handleLocationChange.
3233
3234         * TestResultServer/static-dashboards/dashboard_base.js:
3235         (handleLocationChange):
3236
3237 2012-10-22  Zan Dobersek  <zandobersek@gmail.com>
3238
3239         [TestResultServer] Move the resource loading into a dedicated class
3240         https://bugs.webkit.org/show_bug.cgi?id=99246
3241
3242         Reviewed by Ojan Vafai.
3243
3244         A new 'loader' namespace is created, containing the request method (previously located in dashboard_base.js)
3245         and the new Loader object, which handles the loading of all the necessary data the dashboard might require.
3246
3247         * TestResultServer/static-dashboards/aggregate_results.html: Include the loader.js source file.
3248         * TestResultServer/static-dashboards/builders.js:
3249         (requestBuilderList): Use the request method located in the loader namespace instead of the removed doXHR method.
3250         (onBuilderListLoad): Now parses the response text of the passed-in XHR. When all the builder lists are loaded the
3251         resource loader object is notified appropriately.
3252         (onErrorLoadingBuilderList): The partial function that calls this function also adds an XHR parameter.
3253         * TestResultServer/static-dashboards/dashboard_base.js: Much of the resource loading-related code is moved to loader.js.
3254         The Loader object is now used to load all the required resources.
3255         (parseParameters): Don't push the 'builder' parameter into the current state if the unit tests are being run.
3256         (resourceLoadingComplete): This method gets called when all the resources are loaded and the dashboard should
3257         proceed with generating the page.
3258         (handleLocationChange):
3259         * TestResultServer/static-dashboards/flakiness_dashboard.html: Include the loader.js source file.
3260         * TestResultServer/static-dashboards/flakiness_dashboard.js: The request method has been relocated to the loader namespace.
3261         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: The affected test cases are modified appropriately.
3262         (test):
3263         * TestResultServer/static-dashboards/loader.js: Added.
3264         (.): A new namespace is introduced, publicly exporting the request method that performs an XHR operation and a Loader object
3265         which oversees resource loading. The loading is done in steps, first loading the builders list, after that the results files
3266         the current dashboard needs, and lastly the TestExpectations files if they are required by the dashboard. When done the loader
3267         calls the resourceLoadingComplete method located in dashboard_base.js. This signals the dashboard all resources are available
3268         and it can proceed with generating the dashboard page.
3269         * TestResultServer/static-dashboards/loader_unittests.js: Added. Contains unit tests for the Loader object, covering the
3270         incremental loading and the loading of results files and TestExpectations files. The builders list loading is currently not
3271         tested as the unit tests page overrides related methods that possibly affect other tests' behavior.
3272         * TestResultServer/static-dashboards/run-unittests.html: Now includes the loader.js and loader_unittests.js source file.
3273         Refactors the code a bit due to changes in how onBuilderListLoad behaves.
3274         * TestResultServer/static-dashboards/timeline_explorer.html: Now includes the loader.js source file.
3275         * TestResultServer/static-dashboards/treemap.html: Ditto. Also refactors the code to take into account
3276         that all the test files are now loaded before generating the dashboard page.
3277
3278 2012-10-21  Jochen Eisinger  <jochen@chromium.org>
3279
3280         [chromium] introduce a public API for the TestRunner library
3281         https://bugs.webkit.org/show_bug.cgi?id=99904
3282
3283         Reviewed by Adam Barth.
3284
3285         The API decouples the public API from the underlying implementation, so
3286         embedders can depend on it. I'm also changing DRT to consume the
3287         TestRunner API through the public API, except for DRTTestRunner and all
3288         places that require Task.h. These two will be migrated in later changes.
3289
3290         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3291         * DumpRenderTree/DumpRenderTree.gypi:
3292         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3293         * DumpRenderTree/chromium/DRTDevToolsClient.h:
3294         * DumpRenderTree/chromium/MockSpellCheck.cpp:
3295         (MockSpellCheck::fillSuggestionList):
3296         * DumpRenderTree/chromium/MockSpellCheck.h:
3297         (MockSpellCheck):
3298         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3299         * DumpRenderTree/chromium/MockWebSpeechInputController.h:
3300         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
3301         * DumpRenderTree/chromium/TestRunner/public/WebAccessibilityController.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h.
3302         (WebKit):
3303         (WebTestRunner):
3304         (WebAccessibilityController):
3305         * DumpRenderTree/chromium/TestRunner/public/WebEventSender.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h.
3306         (WebKit):
3307         (WebTestRunner):
3308         (WebEventSender):
3309         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h.
3310         (WebKit):
3311         (WebTestRunner):
3312         (WebTestDelegate):
3313         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h.
3314         (WebKit):
3315         (WebTestRunner):
3316         (WebTestInterfaces):
3317         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp:
3318         (WebTestRunner):
3319         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h:
3320         (WebTestRunner):
3321         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
3322         (WebTestRunner):
3323         (WebTestRunner::makeMenuItemStringsFor):
3324         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
3325         (WebTestRunner):
3326         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
3327         (TestDelegate):
3328         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3329         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3330         (TestInterfaces):
3331         * DumpRenderTree/chromium/TestRunner/src/WebAccessibilityController.cpp: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h.
3332         (WebTestRunner):
3333         (WebTestRunner::WebAccessibilityController::WebAccessibilityController):
3334         (WebTestRunner::WebAccessibilityController::setFocusedElement):
3335         (WebTestRunner::WebAccessibilityController::notificationReceived):
3336         (WebTestRunner::WebAccessibilityController::shouldLogAccessibilityEvents):
3337         * DumpRenderTree/chromium/TestRunner/src/WebEventSender.cpp: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h.
3338         (WebTestRunner):
3339         (WebTestRunner::WebEventSender::WebEventSender):
3340         (WebTestRunner::WebEventSender::doDragDrop):
3341         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Added.
3342         (WebTestRunner):
3343         (WebTestInterfaces::Internal):
3344         (WebTestRunner::WebTestInterfaces::Internal::testInterfaces):
3345         (WebTestRunner::WebTestInterfaces::Internal::accessibilityController):
3346         (WebTestRunner::WebTestInterfaces::Internal::eventSender):
3347         (WebTestRunner::WebTestInterfaces::Internal::Internal):
3348         (WebTestRunner::WebTestInterfaces::Internal::~Internal):
3349         (WebTestRunner::WebTestInterfaces::Internal::setDelegate):
3350         (WebTestRunner::WebTestInterfaces::Internal::clearContextMenuData):
3351         (WebTestRunner::WebTestInterfaces::Internal::clearEditCommand):
3352         (WebTestRunner::WebTestInterfaces::Internal::fillSpellingSuggestionList):
3353         (WebTestRunner::WebTestInterfaces::Internal::setEditCommand):
3354         (WebTestRunner::WebTestInterfaces::Internal::lastContextMenuData):
3355         (WebTestRunner::WebTestInterfaces::Internal::setGamepadData):
3356         (WebTestRunner::WebTestInterfaces::WebTestInterfaces):
3357         (WebTestRunner::WebTestInterfaces::~WebTestInterfaces):
3358         (WebTestRunner::WebTestInterfaces::setWebView):
3359         (WebTestRunner::WebTestInterfaces::setDelegate):
3360         (WebTestRunner::WebTestInterfaces::bindTo):
3361         (WebTestRunner::WebTestInterfaces::resetAll):
3362         (WebTestRunner::WebTestInterfaces::accessibilityController):
3363         (WebTestRunner::WebTestInterfaces::eventSender):
3364         * DumpRenderTree/chromium/TestShell.cpp:
3365         (TestShell::initialize):
3366         * DumpRenderTree/chromium/TestShell.h:
3367         (TestShell::eventSender):
3368         (TestShell::accessibilityController):
3369         (TestShell):
3370         * DumpRenderTree/chromium/WebUserMediaClientMock.h:
3371         * DumpRenderTree/chromium/WebViewHost.cpp:
3372         (WebViewHost::finishLastTextCheck):
3373         (WebViewHost::fillSpellingSuggestionList):
3374         * DumpRenderTree/chromium/WebViewHost.h:
3375         (WebViewHost):
3376
3377 2012-10-21  Viatcheslav Ostapenko  <v.ostapenko@samsung.com>
3378
3379         Unreviewed. Updating my emails.
3380
3381         * Scripts/webkitpy/common/config/committers.py:
3382
3383 2012-10-20  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3384
3385         [EFL][DRT] Implement tracking and painting repaint rectangles.
3386         https://bugs.webkit.org/show_bug.cgi?id=99838
3387
3388         Reviewed by Gyuyoung Kim.
3389
3390         Implement displayWebView() and start tracking/painting the repaint
3391         rectangles for the repaint tests that rely on it.
3392
3393         * DumpRenderTree/efl/DumpRenderTree.cpp:
3394         (displayWebView):
3395         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3396         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3397         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
3398         (createBitmapContextFromWebView):
3399
3400 2012-10-19  Dan Bernstein  <mitz@apple.com>
3401
3402         Add bundle API for hit-testing
3403         https://bugs.webkit.org/show_bug.cgi?id=99907
3404
3405         Reviewed by Sam Weinig.
3406
3407         Added an API test for WKBundleFrameCreateHitTest().
3408
3409         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added InjectedBundleFrameHitTest.cpp,
3410         InjectedBundleFrameHitTest_bundle.cpp, and link-with-title.html.
3411
3412         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp: Added.
3413         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Checks that the message contains the
3414         title of the link in link-with-title.html.
3415         (TestWebKitAPI::setInjectedBundleClient):
3416         (TestWebKitAPI::TEST):
3417         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp: Added.
3418         (TestWebKitAPI::InjectedBundleFrameHitTestTest::InjectedBundleFrameHitTestTest):
3419         (TestWebKitAPI::didFinishLoadForFrameCallback): Hit tests at (50, 50) and sends the link title
3420         from the result back to the UI process.
3421         (TestWebKitAPI::InjectedBundleFrameHitTestTest::didCreatePage):
3422         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
3423         * TestWebKitAPI/Tests/WebKit2/link-with-title.html: Added.
3424
3425 2012-10-19  Sheriff Bot  <webkit.review.bot@gmail.com>
3426
3427         Unreviewed, rolling out r131944.
3428         http://trac.webkit.org/changeset/131944
3429         https://bugs.webkit.org/show_bug.cgi?id=99891
3430
3431         On second thoughts, not such a great idea (Requested by jamesr
3432         on #webkit).
3433
3434         * DumpRenderTree/chromium/TestShell.cpp:
3435         (TestShell::createNewWindow):
3436
3437 2012-10-19  Alexandre Elias  <aelias@chromium.org>
3438
3439         [chromium] API to pass impl thread via WebLayerTreeView
3440         https://bugs.webkit.org/show_bug.cgi?id=99863
3441
3442         Reviewed by James Robinson.
3443
3444         This adds an API to pass the compositor impl thread via WebView and
3445         WebLayerTreeView. This is currently a no-op change, but in the future
3446         this codepath will supercede WebCompositor. The goal is to avoid statics
3447         in compositor initialization.
3448
3449         * DumpRenderTree/chromium/TestShell.cpp:
3450         (TestShell::createNewWindow):
3451
3452 2012-10-19  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3453
3454         [Cairo][WTR] Implement the painting of repaint rectangles.
3455         https://bugs.webkit.org/show_bug.cgi?id=99839
3456
3457         Reviewed by Martin Robinson.
3458
3459         Implement the required code to paint the gray overlay with
3460         transparent regions for the repaint rectangles, as other ports
3461         already do and as is already done in most WK1 ports.
3462
3463         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
3464         (WTR::paintRepaintRectOverlay):
3465         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3466
3467 2012-09-08  Alpha Lam  <hclam@chromium.org>
3468
3469         [chromium] Implement deferred image decoding
3470         https://bugs.webkit.org/show_bug.cgi?id=94240
3471
3472         Reviewed by Stephen White.
3473
3474         Add --enable-deferred-image-decoding to DRT.
3475
3476         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3477         (main):
3478         * DumpRenderTree/chromium/TestShell.cpp:
3479         (TestShell::TestShell):
3480         (TestShell::resetWebSettings):
3481         * DumpRenderTree/chromium/TestShell.h:
3482         (TestShell::setDeferredImageDecodingEnabled):
3483         (TestShell):
3484         * DumpRenderTree/chromium/WebPreferences.cpp:
3485         (WebPreferences::reset):
3486         (WebPreferences::applyTo):
3487         * DumpRenderTree/chromium/WebPreferences.h:
3488         (WebPreferences):
3489         * Scripts/webkitpy/layout_tests/port/chromium.py:
3490         (ChromiumPort.virtual_test_suites):
3491
3492 2012-10-19  Dongwoo Joshua Im  <dw.im@samsung.com>
3493
3494         Rename ENABLE_CSS3_TEXT_DECORATION to ENABLE_CSS3_TEXT
3495         https://bugs.webkit.org/show_bug.cgi?id=99804
3496
3497         Reviewed by Julien Chaffraix.
3498
3499         CSS3 text related properties will be implemented under this flag,
3500         including text decoration, text-align-last, and text-justify.
3501
3502         * Scripts/webkitperl/FeatureList.pm:
3503         * qmake/mkspecs/features/features.pri:
3504
3505 2012-10-19  Balazs Kelemen  <kbalazs@webkit.org>
3506
3507         [Qt][WTR] renderToOffscreenBuffer should not be set if the real render loop is active
3508         https://bugs.webkit.org/show_bug.cgi?id=99831
3509
3510         Reviewed by Jocelyn Turcotte.
3511
3512         Do not set renderToOffscreenBuffer if we have called setRenderWithoutShowing.
3513         We do not need it in this case and these things are actually conflicting.
3514
3515         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3516         (WTR::WrapperWindow::handleStatusChanged):
3517         (WTR::PlatformWebView::PlatformWebView):
3518         (WTR::PlatformWebView::windowShapshotEnabled): Added a comment
3519         describing why this workaround is needed.
3520
3521 2012-10-19  Zan Dobersek  <zandobersek@gmail.com>
3522
3523         [WK2][GTK] Fullscreen tests timing out in bots
3524         https://bugs.webkit.org/show_bug.cgi?id=93973
3525
3526         Reviewed by Philippe Normand.
3527
3528         Add webcore_cppflags to the CPPFLAGS for WebKitTestRunner and the
3529         injected bundle library. webcore_cppflags contains all the feature
3530         defines' macros so the ENABE(*) compilation guards should now work
3531         properly (i.e. enable the code behind them when the feature is enabled).
3532
3533         * WebKitTestRunner/GNUmakefile.am:
3534
3535 2012-10-19  Simon Hausmann  <simon.hausmann@digia.com>
3536
3537         Unreviewed, rolling out r131734.
3538         http://trac.webkit.org/changeset/131734
3539
3540         Broke ANGLE build where we end up with @echo foo && @echo -n
3541
3542         * qmake/mkspecs/features/default_post.prf:
3543
3544 2012-10-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3545
3546         REGRESSION (r130640 - r130644): TestCookieManager API test is failing
3547         https://bugs.webkit.org/show_bug.cgi?id=98738
3548
3549         Reviewed by Philippe Normand.
3550
3551         * Scripts/run-gtk-tests:
3552         (TestRunner): Unskip /webkit2/WebKitCookieManager/accept-policy.
3553
3554 2012-10-19  Tommy Widenflycht  <tommyw@google.com>
3555
3556         MediaStream API: Update the RuntimeEnabledFeatures flags
3557         https://bugs.webkit.org/show_bug.cgi?id=99714
3558
3559         Reviewed by Adam Barth.
3560
3561         Enabling the DeprecatedPeerConnection so that all tests still run.
3562
3563         * DumpRenderTree/chromium/TestShell.cpp:
3564         (TestShell::TestShell):
3565
3566 2012-10-18  Dominic Mazzoni  <dmazzoni@google.com>
3567
3568         AX: labelForElement is slow when there are a lot of DOM elements
3569         https://bugs.webkit.org/show_bug.cgi?id=97825
3570
3571         Reviewed by Ryosuke Niwa.
3572
3573         Implement titleUIElement in the chromium port of DRT, and
3574         fix getAccessibleElementById so that it ensures the backing store
3575         is up-to-date.
3576
3577         * DumpRenderTree/chromium/TestRunner/AccessibilityControllerChromium.cpp:
3578         (AccessibilityController::getAccessibleElementById):
3579         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
3580         (AccessibilityUIElement::titleUIElementCallback):
3581
3582 2012-10-17  Ilya Tikhonovsky  <loislo@chromium.org>
3583
3584         Web Inspector: NMI provide data for mixing with tcmalloc heap dumps.
3585         https://bugs.webkit.org/show_bug.cgi?id=99457
3586
3587         Reviewed by Yury Semikhatsky.
3588
3589         countObjectSize now requires pointer to object as the first argument.
3590
3591         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
3592
3593 2012-10-18  Dirk Pranke  <dpranke@chromium.org>
3594
3595         make move_overwritten_baselines_to work again while rebaselining
3596         https://bugs.webkit.org/show_bug.cgi?id=99793
3597
3598         Reviewed by Ojan Vafai.
3599
3600         We used to have code that would help when rebaselining results
3601         for new ports (e.g., when moving from Lion to Mountain Lion) but
3602         it appears that code bitrotted during all the refactoring since
3603         the last time we needed this. This patch makes things work
3604         again, adds more tests that will hopefully make clearer what
3605         is supposed to work, and renames various parameters to be
3606         consistent.
3607
3608         * Scripts/webkitpy/layout_tests/port/builders.py:
3609         (move_overwritten_baselines_to):
3610         (builder_path_for_port_name):
3611         * Scripts/webkitpy/tool/commands/rebaseline.py:
3612         (RebaselineTest.__init__):
3613         (RebaselineTest._copy_existing_baseline):
3614         (RebaselineTest._rebaseline_test):
3615         (RebaselineTest.execute):
3616         (AbstractParallelRebaselineCommand._rebaseline_commands):
3617         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3618         (test_rebaseline_json_with_move_overwritten_baselines_to):
3619         (test_rebaseline_test_internal_with_move_overwritten_baselines_to):
3620         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3621         (GardeningServerTest.test_rebaselineall):
3622
3623 2012-10-18  Roger Fong  <roger_fong@apple.com>
3624
3625         Unreviewed. Skip really old flaky failing jscore date test. 
3626         There's a bug tracking it here: https://bugs.webkit.org/show_bug.cgi?id=53712.
3627
3628         * Scripts/run-javascriptcore-tests:
3629
3630 2012-10-18  Byungwoo Lee  <bw80.lee@samsung.com>
3631
3632         Fix build warning.
3633         https://bugs.webkit.org/show_bug.cgi?id=99788
3634
3635         Reviewed by Kentaro Hara.
3636
3637         Use return value of mktemp() for removing -Wunused-result.
3638
3639         * MiniBrowser/efl/main.c:
3640         (on_download_request):
3641
3642 2012-10-18  Benjamin Poulain  <bpoulain@apple.com>
3643
3644         [WK2] WebKit2 does not build without PLUGIN_PROCESS on Mac
3645         https://bugs.webkit.org/show_bug.cgi?id=99771
3646
3647         Reviewed by Anders Carlsson.
3648
3649         * DumpRenderTree/mac/MockWebNotificationProvider.mm: The file was not including config.h,
3650         effectively breaking feature flags.
3651
3652 2012-10-18  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3653
3654         [EFL][DRT] Make textareas resizable by default.
3655         https://bugs.webkit.org/show_bug.cgi?id=99719
3656
3657         Reviewed by Gyuyoung Kim.
3658
3659         Enable painting the textarea resizer at the corner by default,
3660         just as it already is the case for WK2. This eases the work needed
3661         to get the pixel tests in shape and run by the bots, as both the
3662         WK1 and WK2 ports will have more similar results.
3663
3664         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3665         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3666
3667 2012-10-18  Jochen Eisinger  <jochen@chromium.org>
3668
3669         [chromium] Add a webkit_test_support target that WebTestingSupport
3670         https://bugs.webkit.org/show_bug.cgi?id=99772
3671
3672         Reviewed by Adam Barth.
3673
3674         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3675
3676 2012-10-18  Jochen Eisinger  <jochen@chromium.org>
3677
3678         [chromium] move TestRunner files into a src/ sub directory
3679         https://bugs.webkit.org/show_bug.cgi?id=99776
3680
3681         Reviewed by Adam Barth.
3682
3683         This is in preparation of adding a public API to the TestRunner library.
3684
3685         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3686         * DumpRenderTree/DumpRenderTree.gypi:
3687         * DumpRenderTree/chromium/DRTTestRunner.h:
3688         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/AccessibilityControllerChromium.cpp.
3689         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/AccessibilityControllerChromium.h.
3690         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp.
3691         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h.
3692         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp.
3693         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/CppBoundClass.h.
3694         * DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/CppVariant.cpp.
3695         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/CppVariant.h.
3696         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/EventSender.cpp.
3697         * DumpRenderTree/chromium/TestRunner/src/EventSender.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/EventSender.h.
3698         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/GamepadController.cpp.
3699         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/GamepadController.h.
3700         * DumpRenderTree/chromium/TestRunner/src/Task.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/Task.cpp.
3701         * DumpRenderTree/chromium/TestRunner/src/Task.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/Task.h.
3702         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/TestDelegate.h.
3703         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp.
3704         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/TestInterfaces.h.
3705         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/TestRunner.cpp.
3706         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/TestRunner.h.
3707         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/TextInputController.cpp.
3708         * DumpRenderTree/chromium/TestRunner/src/TextInputController.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/TextInputController.h.
3709
3710 2012-10-18  Dirk Pranke  <dpranke@chromium.org>
3711
3712         [chromium] garden-o-matic should ignore the 10.8 Tests bot
3713         https://bugs.webkit.org/show_bug.cgi?id=99765
3714
3715         Reviewed by Adam Barth.
3716
3717         It's really more of an FYI bot at this point and can be safely
3718         ignored like the Content Shell bots.
3719
3720         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3721         (.):
3722
3723 2012-10-18  Jochen Eisinger  <jochen@chromium.org>
3724
3725         [chromium] Simplify TestInterfaces, as this class won't be directly exposed in the TestRunner library's interface
3726         https://bugs.webkit.org/show_bug.cgi?id=99766
3727
3728         Reviewed by Adam Barth.
3729
3730         This reverts http://trac.webkit.org/changeset/123240
3731
3732         * DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:
3733         (TestInterfaces::TestInterfaces):
3734         (TestInterfaces::~TestInterfaces):
3735         (TestInterfaces::setWebView):
3736         (TestInterfaces::setDelegate):
3737         (TestInterfaces::bindTo):
3738         (TestInterfaces::resetAll):
3739         (TestInterfaces::accessibilityController):
3740         (TestInterfaces::eventSender):
3741         * DumpRenderTree/chromium/TestRunner/TestInterfaces.h:
3742         (TestInterfaces):
3743
3744 2012-10-18  Sheriff Bot  <webkit.review.bot@gmail.com>
3745
3746         Unreviewed, rolling out r131810.
3747         http://trac.webkit.org/changeset/131810
3748         https://bugs.webkit.org/show_bug.cgi?id=99762
3749
3750         Broke linux debug webkit_unit_tests (Requested by
3751         danakj|gardening on #webkit).
3752
3753         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3754         (main):
3755         * DumpRenderTree/chromium/TestShell.cpp:
3756         (TestShell::TestShell):
3757         (TestShell::resetWebSettings):
3758         * DumpRenderTree/chromium/TestShell.h:
3759         (TestShell):
3760         * DumpRenderTree/chromium/WebPreferences.cpp:
3761         (WebPreferences::reset):
3762         (WebPreferences::applyTo):
3763         * DumpRenderTree/chromium/WebPreferences.h:
3764         (WebPreferences):
3765         * Scripts/webkitpy/layout_tests/port/chromium.py:
3766         (ChromiumPort.virtual_test_suites):
3767
3768 2012-10-18  Alpha Lam  <hclam@chromium.org>
3769
3770         [chromium] Implement deferred image decoding
3771         https://bugs.webkit.org/show_bug.cgi?id=94240
3772
3773         Reviewed by Stephen White.
3774
3775         Add --enable-deferred-image-decoding to DRT.
3776
3777         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3778         (main):
3779         * DumpRenderTree/chromium/TestShell.cpp:
3780         (TestShell::TestShell):
3781         (TestShell::resetWebSettings):
3782         * DumpRenderTree/chromium/TestShell.h:
3783         (TestShell::setDeferredImageDecodingEnabled):
3784         (TestShell):
3785         * DumpRenderTree/chromium/WebPreferences.cpp:
3786         (WebPreferences::reset):
3787         (WebPreferences::applyTo):
3788         * DumpRenderTree/chromium/WebPreferences.h:
3789         (WebPreferences):
3790         * Scripts/webkitpy/layout_tests/port/chromium.py:
3791         (ChromiumPort.virtual_test_suites):
3792
3793 2012-10-18  Dirk Pranke  <dpranke@chromium.org>
3794
3795         webkitpy: fix chromium bot configs in builders.py
3796         https://bugs.webkit.org/show_bug.cgi?id=99638
3797
3798         Reviewed by Ojan Vafai.
3799
3800         Updating after the great bot-renaming and deleting a test case
3801         that is no longer needed.
3802
3803         * Scripts/webkitpy/layout_tests/port/builders.py:
3804         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3805         (BuildCoverageExtrapolatorTest.test_extrapolate):
3806
3807 2012-10-18  Dirk Pranke  <dpranke@chromium.org>
3808
3809         [chromium] Add 10.8 bot into fallback path, make work with garden-o-matic
3810         https://bugs.webkit.org/show_bug.cgi?id=99748
3811
3812         Reviewed by Ryosuke Niwa.
3813
3814         Subject pretty much says it all ...
3815
3816         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3817         * Scripts/webkitpy/layout_tests/port/builders.py:
3818         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3819         (ChromiumMacPort):
3820         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3821         (ChromiumMacPortTest.test_versions):
3822         (ChromiumMacPortTest.test_baseline_path):
3823         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3824         (TestRebaseline.test_baseline_directory):
3825         (test_rebaseline_and_copy_test_with_lion_result):
3826         (test_rebaseline_expectations):
3827
3828 2012-10-18  Timothy Hatcher  <timothy@apple.com>
3829
3830         Teach prepare-ChangeLog how to handle non-function properties in JavaScript prototypes.
3831
3832         https://bugs.webkit.org/show_bug.cgi?id=99747
3833
3834         Reviewed by Joseph Pecoraro.
3835
3836         * Scripts/prepare-ChangeLog:
3837         (get_function_line_ranges_for_javascript): Clear currentIdentifiers when comma is encountered
3838         so it does not tack those identifiers onto the next changed function.
3839
3840 2012-10-18  James Simonsen  <simonjam@chromium.org>
3841
3842         Add a script for exporting http/tests/w3c/webperf/submission to W3C
3843         https://bugs.webkit.org/show_bug.cgi?id=99675
3844
3845         Reviewed by Tony Gentilcore.
3846
3847         This does the inverse of Scripts/import-w3c-performance-wg-tests.
3848
3849         * Scripts/export-w3c-performance-wg-tests: Added.
3850
3851 2012-10-18  Pablo Flouret  <pablof@motorola.com>
3852
3853         Implement css3-conditional's @supports rule
3854         https://bugs.webkit.org/show_bug.cgi?id=86146
3855
3856         Reviewed by Antti Koivisto.
3857
3858         * Scripts/webkitperl/FeatureList.pm:
3859         * qmake/mkspecs/features/features.pri:
3860             Add an ENABLE_CSS3_CONDITIONAL_RULES flag.
3861
3862 2012-10-18  Xiaobo Wang  <xbwang@torchmobile.com.cn>
3863
3864         [BlackBerry] Dump DRT output to stdout if test is passed as command line argument
3865         https://bugs.webkit.org/show_bug.cgi?id=99150
3866
3867         Reviewed by Rob Buis.
3868
3869         Fixed some code style errors as well.
3870
3871         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3872         (BlackBerry::WebKit::DumpRenderTree::runTest):
3873         (BlackBerry::WebKit::DumpRenderTree::runRemainingTests):
3874         (BlackBerry::WebKit::DumpRenderTree::runTests):
3875         (BlackBerry::WebKit::DumpRenderTree::isHTTPTest):
3876         (BlackBerry::WebKit::DumpRenderTree::dump):
3877         (BlackBerry::WebKit::DumpRenderTree::addMessageToConsole):
3878         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
3879         (DumpRenderTree):
3880
3881 2012-10-18  Simon Hausmann  <simon.hausmann@digia.com>
3882
3883         [Qt] Improved support for silent builds
3884
3885         Reviewed by Tor Arne Vestbø.
3886
3887         Silence our extra compilers when CONFIG+=silent is set.
3888
3889         * qmake/mkspecs/features/default_post.prf:
3890
3891 2012-10-18  Simon Hausmann  <simon.hausmann@digia.com>
3892
3893         [Qt] Reduce memory pressure at link time with less compromise on speed of linking
3894
3895         Reviewed by Csaba Osztrogonác.
3896
3897         Revert r131718 that made us pass -fno-keep-memory to the linker for any
3898         i386 builds. The downside of passing that option is that it slows down
3899         the process of linking and as Ossy determined, release builds do _not_
3900         take as much memory (2.x GB) for linking but much less (~350MB).
3901
3902         However there is one condition where even release builds do take up too
3903         much memory, and that is when Qt is configured with
3904         -separate-debug-info, because it adds a -g next to -O2. The recent
3905         introduction of loading qt_build_config enabled us to read qmodule.pri,
3906         which adds the -g if Qt is configured with -separate-debug-info. So
3907         instead of playing with -fno-keep-memory (which is a last resort
3908         measure for debug builds) we should tweak our existing mechanism of
3909         dealing with the debug info:
3910
3911         production_build.prf tries to ensure that we use -g only in static
3912         libraries that contain API facing code, so that we get nice backtraces
3913         at least into the API layer. For other static libraries such as WebCore
3914         we skip -g via CONFIG += no_debug_info. One of the conditions for
3915         enabling this tweak is CONFIG(debug, debug|release). This patch adds
3916         contains(QT_CONFIG,separate_debug_info) to the conditions.
3917
3918         The patch also extend the CONFIG += no_debug_info part with the removal
3919         of no_separate_debug_info. There is no point in running an extra
3920         build step to strip out debug info into a separate file if at the same
3921         time we tell the compiler to not generate any debug info altogether.
3922
3923         * qmake/mkspecs/features/production_build.prf:
3924         * qmake/mkspecs/features/unix/default_post.prf:
3925
3926 2012-10-18  Balazs Kelemen  <kbalazs@webkit.org>
3927
3928         [Qt] OpenGL rendering is not possible on bots using Xvfb
3929         https://bugs.webkit.org/show_bug.cgi?id=99463
3930
3931         Reviewed by Jocelyn Turcotte.
3932
3933         Added a workaround to be able to disallow UI side OpenGL rendering
3934         if the environment is not suitable because it can be extremely slow
3935         with a software backend.
3936
3937         * Scripts/webkitpy/layout_tests/port/qt.py:
3938         (QtPort.setup_environ_for_server): Let the environment variable
3939         QT_WEBKIT_DISABLE_UIPROCESS_DUMPPIXELS reach the driver. This variable
3940         should be defined on bots that don't have a suitable OpenGL environment.
3941         * WebKitTestRunner/PlatformWebView.h:
3942         (PlatformWebView):
3943         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3944         (WTR::WrapperWindow::handleStatusChanged): Don't try to create an OpenGL
3945         surface and set the setRenderWithoutShowing flag on the window if the
3946         variable is set.
3947         (WTR::PlatformWebView::windowSnapshotImage):
3948         (WTR::PlatformWebView::windowShapshotEnabled):
3949         (WTR):
3950         * WebKitTestRunner/qt/TestInvocationQt.cpp:
3951         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Use the old method
3952         of evaluating pixel results if the snapshot is not supported, that is to check
3953         the image we got from the web process. This is necessary for the bots to be able
3954         to run ref tests.
3955
3956 2012-10-15  Balazs Kelemen  <kbalazs@webkit.org>
3957
3958         [Qt] Implement pixel snapshot generation in WTR
3959         https://bugs.webkit.org/show_bug.cgi?id=95992
3960
3961         Reviewed by Jocelyn Turcotte.
3962
3963         Switch the Qt implementation of the PlatformWebView to use
3964         QQuickWindow::grabWindow to generate the pixel results. This way
3965         we will go through the scenegraph and test the actual rendering backend.
3966         We use QQuickWindowPrivate::setRenderWithoutShowing to avoid the need of
3967         showing the window.
3968
3969         * WebKitTestRunner/Target.pri: Had to added a bunch
3970         of modules to be able to use QQuickWindowPrivate.
3971         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3972         (WTR::WrapperWindow::handleStatusChanged):
3973         (WTR::PlatformWebView::windowSnapshotImage):
3974
3975 2012-10-15  Balazs Kelemen  <kbalazs@webkit.org>
3976
3977         [Qt][WTR] Do a forced repaint before generating pixel results
3978         https://bugs.webkit.org/show_bug.cgi?id=98654
3979
3980         Reviewed by Jocelyn Turcotte.
3981
3982         Do a forced repaint before grabbing the pixel snapshot. This extra
3983         synchronisation is necessary with the CoordinatedGraphics rendering
3984         backend because it has a fully asynchronous nature. This patch make
3985         us using the window snapshot for pixel results which is necessary to
3986         capture animations and other dynamic content. The actual grabbing of
3987         the window has not been implemented in this patch. It will come in
3988         a follow-up.
3989
3990         * WebKitTestRunner/TestInvocation.cpp:
3991         (WTR::TestInvocation::invoke):
3992         (WTR::TestInvocation::dump): Store results in member variables.
3993         Don't close output channels yet.
3994         (WTR::TestInvocation::dumpResults): Added. This is where we dump
3995         the results if no error happened.
3996         (WTR):
3997         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3998         * WebKitTestRunner/TestInvocation.h:
3999         (TestInvocation):
4000         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
4001         (WTR::PlatformWebView::windowSnapshotImage):
4002         * WebKitTestRunner/qt/TestInvocationQt.cpp:
4003         (WTR::TestInvocation::forceRepaintDoneCallback):
4004         (WTR):
4005         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
4006
4007 2012-10-18  Simon Hausmann  <simon.hausmann@digia.com>
4008
4009         [Qt] Clean up variables controlling Qt module creation/handling
4010
4011         Reviewed by Tor Arne Vestbø.
4012
4013         We now depend on a Qt 5 version that is new enough to allow us to
4014         clean this up. Qt's default_pre.prf uses MODULE_QMAKE_OUTDIR, but
4015         the other MODULE_BASE_* variables are onl used in qmodule.prf.
4016
4017         * qmake/mkspecs/features/default_pre.prf:
4018
4019 2012-10-18  Simon Hausmann  <simon.hausmann@digia.com>
4020
4021         [Qt] Reduce memory pressure during link time
4022
4023         Reviewed by Tor Arne Vestbø.
4024
4025         If possible always pass -fkeep-memory to the linker on i386. The
4026         library has grown so big that we need this not only for i386 debug
4027         builds but at least also for release.
4028
4029         * qmake/mkspecs/features/unix/default_post.prf:
4030
4031 2012-10-17  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
4032
4033         [Qt] Modularize documentation for QtWebKit
4034
4035         Running 'make docs' would fail unless 'make qmake_all' was ran first,
4036         but qmake_all involved generating all the derived sources, which seems
4037         overly complex just for building documentation.
4038
4039         We solve this by preventing all subdirs except QtWebKit from having a
4040         docs target. This would normally work fine on its own, but since we
4041         use CONFIG += ordered, there's now a missing doc target for the
4042         immediate dependency of the QtWebKit subdir. We solve this by adding
4043         a dummy-target ourselves.
4044
4045         Finally, we clean up the qdocconf file to match the rest of the Qt
4046         documentation modularization efforts.
4047
4048         Reviewed by Simon Hausmann.
4049
4050         * qmake/mkspecs/features/default_post.prf:
4051
4052 2012-10-17  Zoltan Horvath  <zoltan@webkit.org>
4053
4054         Remove the JSHeap memory measurement of the PageLoad performacetests since it creates bogus JSGlobalDatas
4055         https://bugs.webkit.org/show_bug.cgi?id=99609 
4056
4057         Reviewed by Ryosuke Niwa.
4058
4059         Remove the implementation since it creates bogus JSGlobalDatas in the layout tests.
4060
4061         * DumpRenderTree/mac/DumpRenderTree.mm:
4062         (dump):
4063
4064 2012-10-17  Dirk Pranke  <dpranke@chromium.org>
4065
4066         [chromium] stop falling back to platform/mac for LayoutTest results
4067         https://bugs.webkit.org/show_bug.cgi?id=99666
4068
4069         Reviewed by James Robinson.
4070
4071         Previously the Chromium ports would fall back to results in
4072         platform/mac if a result was not found in platform/chromium-*.
4073         This allowed us to share a lot of results w/ the Apple Mac port,
4074         but often surprised people (especially at Apple ;) when changing
4075         something in that directory would break a Chromium build.
4076
4077         The tests that are deleted in baselineoptimizer were for cases
4078         that are no longer relevant or possible in the current fallback
4079         graph.
4080
4081         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
4082         (BaselineOptimizerTest.test_move_baselines):
4083         (BaselineOptimizerTest.test_chromium_covers_mac_win_linux):
4084         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
4085         (ChromiumAndroidPort):
4086         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
4087         (ChromiumLinuxPort):
4088         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
4089         (ChromiumMacPort):
4090         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
4091         (ChromiumWinPort):
4092         * TestResultServer/static-dashboards/flakiness_dashboard.js:
4093
4094 2012-10-17  Shashi Shekhar  <shashishekhar@google.com>
4095
4096         Remove redundant sdk_build parameter.
4097         https://bugs.webkit.org/show_bug.cgi?id=99648
4098
4099         Reviewed by Adam Barth.
4100
4101         sdk_build parameter is no longer needed.
4102
4103         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4104         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
4105
4106 2012-10-17  Joanmarie Diggs  <jdiggs@igalia.com>
4107
4108         [GTK] AccessibilityUIElement::role() should be consistent across platforms wherever possible
4109         https://bugs.webkit.org/show_bug.cgi?id=99640
4110
4111         Reviewed by Chris Fleizach.
4112
4113         Convert AtkRole instances to the Mac/Safari-style AXRole string.
4114
4115         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
4116         (roleToString): New method to convert AtkRole instances to the Mac/Safari-style AXRole string
4117         (AccessibilityUIElement::role): Output the Mac/Safair-style AXRole string rather than the AtkRole's name
4118
4119 2012-10-17  Anders Carlsson  <andersca@apple.com>
4120
4121         Clean up Vector.h
4122         https://bugs.webkit.org/show_bug.cgi?id=99622
4123
4124         Reviewed by Benjamin Poulain.
4125
4126         Remove ReversedProxy test.
4127
4128         * TestWebKitAPI/Tests/WTF/Vector.cpp:
4129
4130 2012-10-17  Scott Graham  <scottmg@chromium.org>
4131
4132         Integer overflows/underflows in all Gamepad controller api calls.
4133         https://bugs.webkit.org/show_bug.cgi?id=97262
4134
4135         Reviewed by Abhishek Arya.
4136
4137         Range check controller inputs. This code is not exposed to the web,
4138         but makes fuzzers try less hard to break uninteresting code.
4139
4140         * DumpRenderTree/chromium/TestRunner/GamepadController.cpp:
4141         (GamepadController::setButtonCount):
4142         (GamepadController::setButtonData):
4143         (GamepadController::setAxisCount):
4144         (GamepadController::setAxisData):
4145
4146 2012-10-17  Joseph Pecoraro  <pecoraro@apple.com>
4147
4148         Unreviewed watchlist email change.
4149
4150         * Scripts/webkitpy/common/config/watchlist:
4151
4152 2012-10-17  Dan Carney  <dcarney@google.com>
4153
4154         Bind isolatedWorldSecurityOrigin to world
4155         https://bugs.webkit.org/show_bug.cgi?id=99582
4156
4157         Reviewed by Adam Barth.
4158
4159         Added ability to unset isolatedWorldSecurityOrigin.
4160
4161         * DumpRenderTree/chromium/DRTTestRunner.cpp:
4162         (DRTTestRunner::setIsolatedWorldSecurityOrigin):
4163
4164 2012-10-17  Joseph Pecoraro  <pecoraro@apple.com>
4165
4166         Unreviewed watchlist addition.
4167
4168         * Scripts/webkitpy/common/config/watchlist:
4169
4170 2012-10-17  Sadrul Habib Chowdhury  <sadrul@chromium.org>
4171
4172         plugins: Allow a plugin to dictate whether it can receive drag events or not.
4173         https://bugs.webkit.org/show_bug.cgi?id=99355
4174
4175         Reviewed by Tony Chang.
4176
4177         Update the TestWebPlugin to implement the new |canProcessDrag| interface.
4178
4179         * DumpRenderTree/chromium/TestWebPlugin.h:
4180         (TestWebPlugin::canProcessDrag):
4181
4182 2012-10-17  Dominic Mazzoni  <dmazzoni@google.com>
4183
4184         Unreviewed. Create an accessibility watchlist.
4185
4186         * Scripts/webkitpy/common/config/committers.py:
4187         * Scripts/webkitpy/common/config/watchlist:
4188
4189 2012-10-17  Jochen Eisinger  <jochen@chromium.org>
4190
4191         [gyp] fix bundle resources for DumpRenderTree on mac
4192         https://bugs.webkit.org/show_bug.cgi?id=99558
4193
4194         Reviewed by Adam Barth.
4195
4196         mac_bundle_resources doesn't propagate to targets that depend on it,
4197         so I'm wrapping it in an all_dependent_settings block.
4198
4199         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4200
4201 2012-10-17  Harald Alvestrand  <hta@google.com>
4202
4203         Add myself to the MediaStream watchlist
4204         https://bugs.webkit.org/show_bug.cgi?id=99589
4205
4206         Reviewed by Adam Barth.
4207
4208         * Scripts/webkitpy/common/config/watchlist:
4209
4210 2012-10-17  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
4211
4212         [WK2][WTR] InjectedBundlePage::decidePolicyForNavigationAction() should print only filename part of local URLs
4213         https://bugs.webkit.org/show_bug.cgi?id=99581
4214
4215         Reviewed by Kenneth Rohde Christiansen.
4216
4217         Now InjectedBundlePage::decidePolicyForNavigationAction() prints only filename part of local URLs (URLs where scheme
4218         equals to 'file').
4219
4220         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4221         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
4222
4223 2012-10-17  Harald Alvestrand  <hta@google.com>
4224
4225         Implement the Selector argument to RTCPeerConnection.getStats
4226         https://bugs.webkit.org/show_bug.cgi?id=99460
4227
4228         Reviewed by Adam Barth.
4229
4230         The MockWebRTCPeerConnectionHandler will return one object only
4231         when it gets a selector, and an even number when there is no selector.
4232         This allows to verify that the argument is passed, but not its value.
4233
4234         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
4235         (MockWebRTCPeerConnectionHandler::getStats):
4236
4237 2012-10-17  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
4238
4239         WebKitTestRunner needs layoutTestController.queueReload
4240         https://bugs.webkit.org/show_bug.cgi?id=42672
4241
4242         Reviewed by Kenneth Rohde Christiansen.
4243
4244         Added implementation of testRunner.queueReload().
4245
4246         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4247         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4248         (WTR::InjectedBundle::queueReload):
4249         (WTR):
4250         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
4251         (InjectedBundle):
4252         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4253         (WTR::TestRunner::queueReload):
4254         (WTR):
4255         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4256         (TestRunner):
4257         * WebKitTestRunner/TestInvocation.cpp:
4258         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
4259         * WebKitTestRunner/WorkQueueManager.cpp:
4260         (WTR::WorkQueueManager::queueReload):
4261         (WTR):
4262         * WebKitTestRunner/WorkQueueManager.h:
4263         (WorkQueueManager):
4264
4265 2012-10-17  Mark Rowe  <mrowe@apple.com>
4266
4267         Fix the build with a newer version of clang.
4268
4269         Reviewed by Dan Bernstein.
4270
4271         Update to accommodate the renamed methods in WebCoreStatistics.
4272
4273         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
4274         (createPagedBitmapContext):
4275
4276 2012-10-17  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
4277
4278         WebKitTestRunner needs testRunner.queueLoad
4279         https://bugs.webkit.org/show_bug.cgi?id=42674
4280
4281         Reviewed by Kenneth Rohde Christiansen.
4282
4283         Added testRunner.queueLoad() and testRunner.queueBackNavigation() implementation to WTR including
4284         Work Queue implementation. Work Queue is managed by WorkQueueManager which belongs to UI process
4285         (as the needed functionality, like loading initiation, has to be invoked from UI process) and