1 2015-05-11 Ryosuke Niwa <rniwa@webkit.org>
3 Build fix. jetstream has a local copy, not remote archive.
5 * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
7 2015-05-11 Ryosuke Niwa <rniwa@webkit.org>
9 run-benchmark should support SunSpider, Kraken and Octane
10 https://bugs.webkit.org/show_bug.cgi?id=144840
12 Reviewed by Darin Adler.
14 Added the support for SunSpider, Kraken, and Octane. Because of the licensing issues, we can't commit the
15 Kraken source code into the WebKit repository as done for other benchmarks. Instead, we'll dynamically
16 download it from the remote server using newly added RemoteZipBenchmarkBuilder. We do the same for Octane
17 for simplicity. Use newly added --local-copy option to specify the location of a local copy if there is any.
19 Renamed "original_benchmark in the plan file to "local_copy" and added a new optional "remote_archive" to
20 specify the URL to a remote ZIP file. This optional field is used by Kraken and Octane benchmark plans.
22 In addition, generalized the ability to run a "create script" in JetStreamBenchmarkBuilder since it's also
23 needed for SunSpider and Kraken. This feature has now been folded into GenericBenchmarkBuilder.
25 * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Added
26 RemoteZipBenchmarkBuilder for Kraken and removed JetStreamBenchmarkBuilder since GenericBenchmarkBuilder
27 now has the ability to run an arbitrary "create script".
29 * Scripts/run-benchmark:
30 (main): Added an optional argument, --local-copy, to override the location of the benchmark's local copy.
31 This also overrides the remote archive URL specified in the plan.
33 * Scripts/webkitpy/benchmark_runner/README.md: Updated the description.
35 * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Deleted the entry for
36 JetStreamBenchmarkBuilder.
38 * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
39 (GenericBenchmarkBuilder.prepare): Call _fetchRemoteArchive if local_copy is not specified in the plan or
40 by --local-copy option but remote_archive is specified. Also call self.clean() here instead of relying on
41 _runCreateScript and _applyPatch to clean after themselves.
42 (GenericBenchmarkBuilder._runCreateScript): Moved from JetStreamBenchmarkBuilder._runCreateScript since
43 JetStream, SunSpider, Kraken all use this feature.
44 (GenericBenchmarkBuilder._copyBenchmarkToTempDir): Use self.name as the destination location instead of
45 the leaf directory name since the latter is not available when a remote ZIP file is used.
46 (GenericBenchmarkBuilder._fetchRemoteArchive): Added.
47 (GenericBenchmarkBuilder._applyPatch): Apply the patch inside destination directory to avoid hard coding
48 the benchmark name in the patches.
50 * Scripts/webkitpy/benchmark_runner/benchmark_builder/jetstream_benchmark_builder.py: Removed.
52 * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
53 (BenchmarkRunner.__init__): Set self.planName. Also override 'local_copy' when --local-copy option is used.
54 (BenchmarkRunner.execute): Exit early if neither local_copy nor remote_archive is specified. Prefix the URL
55 the browser opens by planName as the plan file no longer contains that.
57 * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Changed the path to be relative against
58 the top directory of JetStream instead of its parent.
59 * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch: Added.
60 * Scripts/webkitpy/benchmark_runner/data/patches/Octane.patch: Added.
61 * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Changed the path to be relative against
62 the top directory of JetStream instead of its parent.
63 * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch: Added.
64 * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Uses GenericBenchmarkBuilder and specifies
65 the script to run. The entry point was changed to the relative path from the top directory of JetStream as
66 done in JetStream.patch.
67 * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Added.
68 * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Added.
69 * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: The entry point was changed to the relative
70 path from the top directory of JetStream as done in JetStream.patch.
71 * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan: Added.
73 2015-05-11 Csaba Osztrogonác <ossy@webkit.org>
75 Fix run-javascriptcore-tests step on the WinCairo bot
76 https://bugs.webkit.org/show_bug.cgi?id=144866
78 Reviewed by Darin Adler.
80 * Scripts/run-jsc-stress-tests:
82 2015-05-11 Alex Christensen <achristensen@webkit.org>
84 [Content Extensions] Support domain-specific rules and exceptions.
85 https://bugs.webkit.org/show_bug.cgi?id=144833
87 Reviewed by Darin Adler.
89 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
90 (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
91 (TestWebKitAPI::InMemoryCompiledContentExtension::create):
92 (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
93 Moved CompiledContentExtensionData from ContentExtensionCompiler.h because it is only used for testing.
94 (TestWebKitAPI::mainDocumentRequest):
95 (TestWebKitAPI::subResourceRequest):
96 (TestWebKitAPI::TEST_F):
97 (TestWebKitAPI::checkCompilerError):
98 Added tests for parsing and functionality of if-domain and unless-domain.
100 2015-05-11 Ryosuke Niwa <rniwa@webkit.org>
102 run-benchmark should support Chrome Canary and Firefox Nightly
103 https://bugs.webkit.org/show_bug.cgi?id=144850
105 Reviewed by Darin Adler.
107 Added the support for Chrome Canary, Firefox (release), and Firefox Nightly.
109 This patch also extracts OSXBrowserDriver to launch and terminate processes on OS X.
111 * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json:
112 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py: Added.
114 (OSXBrowserDriver.prepareEnv): Extracted from ChromeBrowserDriver.prepareEnv.
115 (OSXBrowserDriver.closeBrowsers): Ditto.
116 (OSXBrowserDriver.launchProcess): Ditto.
117 (OSXBrowserDriver.terminateProcesses): Ditto.
118 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
119 (OSXChromeDriver): Removed the unused self.chromePreferences.
120 (OSXChromeDriver.prepareEnv): Moved to OSXBrowserDriver.
121 (OSXChromeDriver.closeBrowsers): Ditto.
122 (OSXChromeDriver.launchUrl):
123 (OSXChromeCanaryDriver): Added.
124 (OSXChromeCanaryDriver.launchUrl):
125 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: Added.
126 (OSXFirefoxDriver): Added.
127 (OSXFirefoxDriver.launchUrl):
128 (OSXFirefoxNightlyDriver): Added.
129 (OSXFirefoxNightlyDriver.launchUrl):
130 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
132 (OSXSafariDriver.closeBrowsers):
134 2015-05-11 Tim Horton <timothy_horton@apple.com>
136 Page overlay action context override should indicate the source of the request
137 https://bugs.webkit.org/show_bug.cgi?id=144832
138 <rdar://problem/20562594>
140 Reviewed by Darin Adler.
142 * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm:
143 (TestWebKitAPI::ActionMenuTest::actionContextForResultAtPoint):
145 2015-05-10 Martin Robinson <mrobinson@igalia.com>
147 [GTK] fast/events/page-visibility-transition-test.html is timing out
148 https://bugs.webkit.org/show_bug.cgi?id=114789
150 Reviewed by Darin Adler.
152 * WebKitTestRunner/gtk/TestControllerGtk.cpp:
153 (WTR::TestController::setHidden): Map and unmap the WebView when the harness
154 requests visibility changes.
156 2015-05-10 Csaba Osztrogonác <ossy@webkit.org>
158 [EFL] Fix install-dependencies on Ubuntu 14.10/15.04
159 https://bugs.webkit.org/show_bug.cgi?id=144798
161 Reviewed by Darin Adler.
163 * efl/install-dependencies:
165 2015-05-09 Ryosuke Niwa <rniwa@webkit.org>
167 Make arguments of run-benchmark more user friendly
168 https://bugs.webkit.org/show_bug.cgi?id=144835
170 Reviewed by Darin Adler.
172 Made --build-directory optional since I don't expect a typical WebKit developer to have a local build
173 of Chrome and Firefox. Also made --plan accept just a filename so that we can just say "speedometer"
174 instead of "Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan". Finally, removed
175 default values from --platform and --browser as they are required arguments.
177 * Scripts/run-benchmark:
178 (main): Made --build-directory optional, and removed default values from --platform and --browser.
179 Also added help text for --build-directory and --plan. In addition, the list of platforms and browsers
180 are not dynamically obtained via BrowserDriverFactory.
181 * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
182 (BenchmarkRunner.__init__): Raise when we can't find the plan file or the plan file is not a valid JSON
183 file instead of suppressing the error here and blowing up later mysteriously since we won't be able to
184 run any benchmark in that case.
185 (BenchmarkRunner._findPlanFile): Added. Look for the plan in webkitpy/benchmark_runner/data/plans if
186 the specified file isn't a valid relative or an absolute path.
187 * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
188 (BrowserDriverFactory.available_platforms): Added. Used in main to provide the list of valid platforms
190 (BrowserDriverFactory.available_browsers): Ditto.
191 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
192 (OSXChromeDriver.launchUrl): browserBuildPath is never optional since BenchmarkRunner.execute always
193 calls launchUrl with this argument so removed the default value. Also added a fallback path for when
194 browserBuildPath was None.
195 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
196 (OSXSafariDriver.launchUrl): Ditto. We also fallback when the build directory doesn't contain Safari
197 so that we can use locally built WebKit to launch Safari.
199 2015-05-09 Yoav Weiss <yoav@yoav.ws>
201 Remove the PICTURE_SIZES build flag
202 https://bugs.webkit.org/show_bug.cgi?id=144679
204 Reviewed by Benjamin Poulain.
206 Removed the PICTURE_SIZES build time flag.
208 * Scripts/webkitperl/FeatureList.pm:
210 2015-05-09 David Kilzer <ddkilzer@apple.com>
212 Layout tests broke due to unexpected simctl output
214 * Scripts/webkitpy/xcode/simulator.py:
215 (Simulator._parse_devices): Handle new Device Pairs header.
216 * Scripts/webkitpy/xcode/simulator_unittest.py:
217 (test_device_pairs): Add unit test for Device Pairs header.
219 2015-05-08 Myles C. Maxfield <mmaxfield@apple.com>
221 Remove convenience constructors for TextRun
222 https://bugs.webkit.org/show_bug.cgi?id=144752
224 Reviewed by Anders Carlsson.
226 Test the StringView which takes a StringImpl*.
228 * TestWebKitAPI/Tests/WTF/StringView.cpp:
229 (StringView8Bit): Testing is8Bit() on StringView
231 2015-05-07 Sam Weinig <sam@webkit.org>
233 [Content Extensions] Add simple tester that takes an extension and compiles it
234 https://bugs.webkit.org/show_bug.cgi?id=144781
236 Reviewed by Dan Bates.
238 * ContentExtensionTester: Added.
239 * ContentExtensionTester/Configurations: Added.
240 * ContentExtensionTester/Configurations/Base.xcconfig: Copied from Source/bmalloc/Configurations/Base.xcconfig.
241 * ContentExtensionTester/Configurations/ContentExtensionTester.xcconfig: Copied from Source/bmalloc/Configurations/bmalloc.xcconfig.
242 * ContentExtensionTester/Configurations/DebugRelease.xcconfig: Copied from Source/bmalloc/Configurations/DebugRelease.xcconfig.
243 * ContentExtensionTester/ContentExtensionTester.xcodeproj: Added.
244 * ContentExtensionTester/ContentExtensionTester.xcodeproj/project.pbxproj: Added.
245 * ContentExtensionTester/Makefile: Copied from Tools/TestWebKitAPI/Makefile.
246 * ContentExtensionTester/main.m: Added.
247 * Scripts/run-content-extension-tester: Copied from Tools/Scripts/run-webkit-tests.
249 2015-05-08 Alexey Proskuryakov <ap@apple.com>
253 Reviewed by Dan Bernstein.
255 * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
256 * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
257 (-[DumpRenderTreeDraggingInfo springLoadingHighlight]):
258 (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
259 * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
260 * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
261 (-[WebKitTestRunnerDraggingInfo springLoadingHighlight]):
262 (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
264 2015-05-08 Martin Robinson <mrobinson@igalia.com>
266 [GTK] Some tests fail because they do not assume the popup menu captures click events
267 https://bugs.webkit.org/show_bug.cgi?id=40601
269 Reviewed by Carlos Garcia Campos.
271 Popdown all attached menus when moving between tests and between each new
272 event sent to the WebView. This prevents context and popup menus from eating
275 * WebKitTestRunner/PlatformWebView.h: Added a helper method to do menu popdown.
276 * WebKitTestRunner/TestController.cpp: Add a specialization of these methods for GTK+.
277 * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
278 (WTR::dispatchEvent): Popdown all menus between dispatching events.
279 (WTR::EventSenderProxy::replaySavedEvents): Pass the view when dispatching events.
280 (WTR::EventSenderProxy::sendOrQueueEvent): Pass the view when dispatching events.
281 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
282 (WTR::PlatformWebView::hideAllPopupMenus): Added this helper.
283 * WebKitTestRunner/gtk/TestControllerGtk.cpp:
284 (WTR::TestController::platformConfigureViewForTest): Added this stub, which is no
285 longer in the platform-independent file.
286 (WTR::TestController::platformResetPreferencesToConsistentValues): Popdown menus.
288 015-05-08 Michael Catanzaro <mcatanzaro@igalia.com>, Martin Robinson <mrobinson@igalia.com>
290 [GTK] Checks for DEVELOPMENT_BUILD are all wrong
291 https://bugs.webkit.org/show_bug.cgi?id=144746
293 Reviewed by Carlos Garcia Campos.
295 Use ENABLE_DEVELOPER_MODE rather than DEVELOPMENT_BUILD.
297 * MiniBrowser/gtk/main.c:
300 2015-05-08 Commit Queue <commit-queue@webkit.org>
302 Unreviewed, rolling out r183996.
303 https://bugs.webkit.org/show_bug.cgi?id=144806
305 ASan detected use-after free (Requested by ap on #webkit).
309 "Remove convenience constructors for TextRun"
310 https://bugs.webkit.org/show_bug.cgi?id=144752
311 http://trac.webkit.org/changeset/183996
313 2015-05-08 Myles C. Maxfield <mmaxfield@apple.com>
315 Remove convenience constructors for TextRun
316 https://bugs.webkit.org/show_bug.cgi?id=144752
318 Reviewed by Anders Carlsson.
320 Test the StringView which takes a StringImpl*.
322 * TestWebKitAPI/Tests/WTF/StringView.cpp:
323 (StringView8Bit): Testing is8Bit() on StringView
325 2015-05-08 Carlos Garcia Campos <cgarcia@igalia.com>
327 [GTK] WTR doesn't correctly handle the Escape key
328 https://bugs.webkit.org/show_bug.cgi?id=144788
330 Reviewed by Martin Robinson.
332 Correctly handle 0x001B character code in GTK+ event sender to be
333 recognized as Escape key, because gdk_unicode_to_keyval() doesn't
334 handle it. This fixes layout tests using keyDown(String.fromCharCode(0x001B), null);
335 to dismiss popup menus.
337 Fixes editing/selection/5354455-1.html.
339 * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
340 (WTR::getGDKKeySymForKeyRef):
342 2015-05-08 Carlos Garcia Campos <cgarcia@igalia.com>
344 [GTK] Expose allowFileAccessFromFileURLs setting to WebKit2 GTK+ API
345 https://bugs.webkit.org/show_bug.cgi?id=144748
347 Reviewed by Sergio Villar Senin.
349 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
350 (testWebKitSettings): Check the new setting is correctly
351 initialized and updated.
352 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
353 (testWebContextSecurityFileXHR): Check XHR to local files is
354 allowed from file URLs after changing the setting.
355 (beforeAll): Add new test.
357 2015-05-08 Commit Queue <commit-queue@webkit.org>
359 Unreviewed, rolling out r183945.
360 https://bugs.webkit.org/show_bug.cgi?id=144789
362 "It broke all the GTK+ tests" (Requested by KaL on #webkit).
366 "[GTK] Checks for DEVELOPMENT_BUILD are all wrong"
367 https://bugs.webkit.org/show_bug.cgi?id=144746
368 http://trac.webkit.org/changeset/183945
370 2015-05-07 Anders Carlsson <andersca@apple.com>
374 * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
375 (TestWebKitAPI::TEST):
376 * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
377 (TestWebKitAPI::TEST):
380 2015-05-07 Filip Pizlo <fpizlo@apple.com>
382 GC has trouble with pathologically large array allocations
383 https://bugs.webkit.org/show_bug.cgi?id=144609
385 Reviewed by Geoffrey Garen.
387 Add a --filter option that restricts the set of tests we run. I needed it to fix this bug
388 and it's a frequently requested feature.
390 Also add the ability to run a test pretending that your system has a particular RAM size.
391 This is useful for GC tests, and the new GC test that I added uses this.
393 * Scripts/run-javascriptcore-tests:
395 * Scripts/run-jsc-stress-tests:
397 2015-05-07 Csaba Osztrogonác <ossy@webkit.org>
399 [EFL] Bump EFL version to 1.14.0
400 https://bugs.webkit.org/show_bug.cgi?id=144743
402 Reviewed by Darin Adler.
404 Bump EFL and elementary version to 1.14.0 and removed
405 md5sum, because it isn't used at all if hash is present.
407 * efl/jhbuild.modules:
409 2015-05-07 Saam Barati <saambarati1@gmail.com>
411 exceptionFuzz tests should explicitly initialize the exceptionFuzz boolean in JavaScript code through a function in jsc.cpp
412 https://bugs.webkit.org/show_bug.cgi?id=144753
414 Reviewed by Mark Lam.
416 * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
418 2015-05-07 Beth Dakin <bdakin@apple.com>
420 New force-related DOM events should fire in WK1 views
421 https://bugs.webkit.org/show_bug.cgi?id=144663
423 rdar://problem/20281886
425 Reviewed by Sam Weinig.
427 PlatformEventFactory::createPlatformMouseEvent() takes the last pressure event
429 * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
430 (TestWebKitAPI::buildAndPerformTest):
432 2015-05-07 Michael Catanzaro <mcatanzaro@igalia.com>
434 [GTK] Checks for DEVELOPMENT_BUILD are all wrong
435 https://bugs.webkit.org/show_bug.cgi?id=144746
437 Reviewed by Martin Robinson.
439 Use DEVELOPER_MODE rather than DEVELOPMENT_BUILD.
441 * MiniBrowser/gtk/main.c:
444 2015-05-05 Myles C. Maxfield <mmaxfield@apple.com>
446 Revert "Introducing the Platform Abstraction Layer (PAL)"
447 https://bugs.webkit.org/show_bug.cgi?id=144751
451 PAL should be a new target inside WebCore, rather than a top-level folder.
453 * Scripts/build-webkit: Add it to build-webkit.
455 2015-05-07 Ada Chan <adachan@apple.com>
457 Add a test for WKPageCopySessionState() with filtering.
458 https://bugs.webkit.org/show_bug.cgi?id=144666
460 Reviewed by Darin Adler.
462 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
463 * TestWebKitAPI/Tests/WebKit2/WKPageCopySessionStateWithFiltering.cpp: Added.
464 (TestWebKitAPI::didFinishLoadForFrame):
465 (TestWebKitAPI::setPageLoaderClient):
466 (TestWebKitAPI::filterFirstItemCallback):
467 (TestWebKitAPI::filterAllItemsCallback):
468 (TestWebKitAPI::createSessionStates):
469 (TestWebKitAPI::TEST):
471 2015-05-06 Alexey Proskuryakov <ap@apple.com>
473 iOS build fix attempt
475 Link WebKitTestRunnerApp to WebKit, now that we don't have WebKit2.
477 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
479 2015-05-06 Matt Baker <mattbaker@apple.com>
481 Unreviewed, updated my list of email addresses.
483 * Scripts/webkitpy/common/config/contributors.json:
485 2015-05-06 Alexey Proskuryakov <ap@apple.com>
487 Do not link tools to WebKit2.framework
488 https://bugs.webkit.org/show_bug.cgi?id=144699
490 Unreviewed build fix.
492 * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
493 * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
494 These linked to WebKit2 in two ways, eliminating the other one.
496 2015-05-05 Myles C. Maxfield <mmaxfield@apple.com>
498 Introducing the Platform Abstraction Layer (PAL)
499 https://bugs.webkit.org/show_bug.cgi?id=143358
501 Reviewed by Simon Fraser.
503 * Scripts/build-webkit: Add it to build-webkit.
505 2015-05-06 Alex Christensen <achristensen@webkit.org>
507 Fix api tests after r183877.
509 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
510 (TestWebKitAPI::TEST_F):
511 Generate all DFAs before compiling them.
513 2015-05-06 Alexey Proskuryakov <ap@apple.com>
515 Do not link tools to WebKit2.framework
516 https://bugs.webkit.org/show_bug.cgi?id=144699
518 Reviewed by Tim Horton.
520 * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
521 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
522 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
524 2015-05-06 Alex Christensen <achristensen@webkit.org>
526 [Content Extensions] Test splitting NFAs by max NFA size.
527 https://bugs.webkit.org/show_bug.cgi?id=144659
529 Reviewed by Darin Adler.
531 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
532 (TestWebKitAPI::createNFAs):
533 (TestWebKitAPI::TEST_F):
534 * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
535 (TestWebKitAPI::createNFAs):
537 2015-05-05 daegyu lee <daegyu.lee@navercorp.com>
539 Remove the remaining vestiges of SVG feature define
540 https://bugs.webkit.org/show_bug.cgi?id=144655
542 Reviewed by Alexey Proskuryakov.
544 * Scripts/webkitperl/FeatureList.pm:
546 2015-05-05 Timothy Horton <timothy_horton@apple.com>
548 Add a layout mode for computing fixed layout size from a minimum size
549 https://bugs.webkit.org/show_bug.cgi?id=144610
550 <rdar://problem/19790341>
552 Reviewed by Simon Fraser.
554 * MiniBrowser/mac/BrowserWindow.xib:
555 * MiniBrowser/mac/BrowserWindowController.h:
556 * MiniBrowser/mac/WK1BrowserWindowController.m:
557 (-[WK1BrowserWindowController toggleUseMinimumViewSize:]):
558 * MiniBrowser/mac/WK2BrowserWindowController.m:
559 (-[WK2BrowserWindowController toggleUseMinimumViewSize:]):
560 Add a optional toolbar item to toggle a minimum view size of 1024x0.
562 2015-05-05 Alex Christensen <achristensen@webkit.org>
564 [Content Extensions] Release input NSString when finished copying it.
565 https://bugs.webkit.org/show_bug.cgi?id=144642
567 Reviewed by Brian Weinstein.
569 * WebKitTestRunner/mac/TestControllerMac.mm:
570 (WTR::TestController::platformConfigureViewForTest):
571 Use alloc and initWithContentsOfURL to prevent over-releasing an autoreleased object.
573 2015-05-05 Brent Fulgham <bfulgham@apple.com>
575 Unreviewed test fix after r183798.
577 * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
578 (convertToDRTLabel): Mimic behavior of Mac accessibility output
579 so we can share results.
581 2015-05-05 Alex Christensen <achristensen@webkit.org>
583 [Content Extensions] Use less memory to store the json input.
584 https://bugs.webkit.org/show_bug.cgi?id=144604
586 Reviewed by Benjamin Poulain.
588 * MiniBrowser/mac/ExtensionManagerWindowController.m:
589 (-[ExtensionManagerWindowController add:]):
590 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
591 (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
592 * WebKitTestRunner/mac/TestControllerMac.mm:
593 (WTR::TestController::platformConfigureViewForTest):
595 2015-05-05 Yusuke Suzuki <utatane.tea@gmail.com>
597 Unreviewed. Make myself a WebKit reviewer.
599 * Scripts/webkitpy/common/config/contributors.json:
601 2015-05-05 Joanmarie Diggs <jdiggs@igalia.com>
603 [GTK] r183783 breaks build
604 https://bugs.webkit.org/show_bug.cgi?id=144632
606 Reviewed by Martin Robinson.
608 Return false rather than nullptr for unimplemented AccessibilityUIElement::setSelectedVisibleTextRange
610 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
611 (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
613 2015-05-05 Alex Christensen <achristensen@webkit.org>
615 [Content Extensions] Combine NFAs properly and free memory as we compile.
616 https://bugs.webkit.org/show_bug.cgi?id=144485
618 Reviewed by Benjamin Poulain.
620 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
621 (TestWebKitAPI::TEST_F):
622 Added tests for correctly splitting up NFAs with unquantified terms after quantified terms.
623 Added tests for deep NFAs.
625 2015-05-04 Alex Christensen <achristensen@webkit.org>
627 [Content Extensions] Use less memory when writing byte code to file
628 https://bugs.webkit.org/show_bug.cgi?id=144602
630 Reviewed by Darin Adler.
632 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
634 2015-05-05 Carlos Garcia Campos <cgarcia@igalia.com>
636 [GTK] Async operations running in the WorkQueue thread should schedule their sources to the WorkQueue main lopp
637 https://bugs.webkit.org/show_bug.cgi?id=144541
639 Reviewed by Žan Doberšek.
641 Add a test case to WorkQueue unit test, to check that sources of
642 asynchronous IO operations running in the WorkQueue thread are
643 dispatched by the WorkQueue main loop.
645 * TestWebKitAPI/PlatformGTK.cmake:
646 * TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp: Added.
647 (TestWebKitAPI::TEST):
649 2015-05-04 Brent Fulgham <bfulgham@apple.com>
651 Correct '--show-webview' option for Tiled Drawing tests
652 https://bugs.webkit.org/show_bug.cgi?id=144621
654 Reviewed by Simon Fraser.
656 The scrolling thread/tiled drawing tests recreate the standard test runner web view. My earlier patch did not make
657 sure that the state of the '--show-webview' option was propagated to this additional view creation routine.
659 * WebKitTestRunner/mac/TestControllerMac.mm:
660 (WTR::TestController::platformConfigureViewForTest): Include the value of the 'shouldShowWebView' state in the
661 WKMutableDictionary passed to the 'ensureViewSupportsOptions' method.
663 2015-05-04 Filip Pizlo <fpizlo@apple.com>
665 Large array shouldn't be slow
666 https://bugs.webkit.org/show_bug.cgi?id=144617
668 Reviewed by Geoffrey Garen.
670 Add the hash-map benchmark to LongSpider. LongSpider was already not a perfect match of
671 SunSpider. It's not an official benchmark. It contains benchmarks that are relatively
672 long-running. So, hash-map sort of belongs here.
674 * Scripts/run-jsc-benchmarks:
676 2015-05-04 Doug Russell <d_russell@apple.com>
678 AX: setting focus via accessibility object needs to set isSynchronizing in resulting selection intent
679 https://bugs.webkit.org/show_bug.cgi?id=144489
681 Reviewed by Chris Fleizach.
683 Resolves infinite looping when navigating rapidly between controls with the search API and then focusing
684 on the returned control.
685 Remove isSynchronizing flag from AXTextStateChangeIntent and put it on AXObjectCache.
686 Move AXTextStateChangeIntent logic in AccessibilityRenderObject into a helper method.
687 Call new AXTextStateChangeIntent helper from AccessibilityRenderObject::setFocus().
688 Add support for setSelectedVisibleTextRange() in accessibility tests.
690 * DumpRenderTree/AccessibilityUIElement.cpp:
691 (setSelectedVisibleTextRangeCallback):
692 (AccessibilityUIElement::setSelectedVisibleTextRange):
693 (AccessibilityUIElement::getJSClass):
694 (AccessibilityUIElement::textMarkerForIndex): Deleted.
695 * DumpRenderTree/AccessibilityUIElement.h:
696 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
697 (AccessibilityUIElement::setSelectedVisibleTextRange):
698 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
699 (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
700 (WTR::AccessibilityUIElement::setSelectedTextRange): Deleted.
701 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
702 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
703 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
704 (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
705 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
706 (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
707 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
708 (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
710 2015-05-04 Brent Fulgham <bfulgham@apple.com>
712 [Win] Implement the "--show-webview" option for Windows
713 https://bugs.webkit.org/show_bug.cgi?id=144589
715 Reviewed by Alex Christensen.
717 Add another runtime flag (--show-webview) that causes DumpRenderTree
718 to draw its view on-screen, rather than the standard offscreen mode.
720 * DumpRenderTree/win/DumpRenderTree.cpp:
721 (createWebViewAndOffscreenWindow): Honor the 'showWebView' flag.
722 (initializeGlobalsFromCommandLineOptions): Recognize the new
723 command-line argument, and set the global 'showWebView' state if
726 2015-05-04 Csaba Osztrogonác <ossy@webkit.org>
728 Remove dead code from TestInvocationCairo.cpp
729 https://bugs.webkit.org/show_bug.cgi?id=144564
731 Reviewed by Gyuyoung Kim.
733 Only EFL and GTK port use TestInvocationCairo.cpp, there isn't other platform.
735 * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
736 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
738 2015-05-04 Joonghun Park <jh718.park@samsung.com>
740 [GTK] Add libnotify in gtk install-dependencies
741 https://bugs.webkit.org/show_bug.cgi?id=144379
743 Reviewed by Csaba Osztrogonác.
745 * gtk/install-dependencies:
747 2015-05-01 Mario Sanchez Prada <mario@endlessm.com>
749 check-webkit-style fails due to system pylint
750 https://bugs.webkit.org/show_bug.cgi?id=144360
752 Reviewed by Darin Adler.
754 Make sure that the directory containing third party autoinstalled modules
755 is at the beginning of the search path, to avoid conflicts with other
756 versions of the same modules installed in the system (e.g. pylint).
758 * Scripts/webkitpy/thirdparty/__init__.py: Prepend the autoinstalled
759 modules directory to sys.path, instead of appending it.
761 2015-05-01 Mario Sanchez Prada <mario@endlessm.com>
763 Unreviewed, updated my list of email addresses.
765 * Scripts/webkitpy/common/config/contributors.json: Updated.
767 2015-05-01 Martin Robinson <mrobinson@igalia.com>
769 USE(...) macro should expect unprefixed variables
770 https://bugs.webkit.org/show_bug.cgi?id=144454
772 Reviewed by Daniel Bates.
774 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Replace all occurrences WTF_USE with USE.
775 * DumpRenderTree/config.h: Ditto.
776 * TestWebKitAPI/config.h: Ditto.
778 2015-05-01 Basile Clement <basile_clement@apple.com>
780 Unreviewed. Add myself as a commiter in contributors.json.
782 * Scripts/webkitpy/common/config/contributors.json:
784 2015-05-01 Dewei Zhu <dewei_zhu@apple.com>
786 Update speedometer patch to provide better UI, fix merge result bug and add "Score" metric to speedometer benchmark.
787 https://bugs.webkit.org/show_bug.cgi?id=144487
789 Reviewed by Ryosuke Niwa.
791 * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
792 (BenchmarkRunner.merge): Fix bug.
793 * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Update appearance and add "Score" metric.
795 2015-05-01 Brady Eidson <beidson@apple.com>
797 Add API to disable meta refreshes.
798 <rdar://problem/20333198> and https://bugs.webkit.org/show_bug.cgi?id=144269
800 Reviewed by Alexey Proskuryakov.
802 * DumpRenderTree/mac/DumpRenderTree.mm:
803 (resetWebPreferencesToConsistentValues): Reset the meta refresh pref between tests.
805 2015-05-01 Brent Fulgham <bfulgham@apple.com>
807 Provide a runtime flag to run-webkit-tests that shows the test view
808 https://bugs.webkit.org/show_bug.cgi?id=144079.
810 Unreviewed correction to r183651.
812 * WebKitTestRunner/TestController.cpp:
813 (WTR::TestController::initialize): Make sure the state of the '--show-webview'
814 flag is included in the options dictionary passed to the PlatformWebView.
816 2015-05-01 Antti Koivisto <antti@apple.com>
818 Remove network process load serialization code
819 https://bugs.webkit.org/show_bug.cgi?id=144448
821 Reviewed by Alexey Proskuryakov.
823 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
824 (WTR::InjectedBundle::beginTesting):
825 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
826 (WTR::TestRunner::setSerializeHTTPLoads):
827 (WTR::TestRunner::dispatchPendingLoadRequests):
829 2015-05-01 Xabier Rodriguez Calvar <calvaris@igalia.com>
831 [GTK] Add libhyphen-dev to the build dependencies
832 https://bugs.webkit.org/show_bug.cgi?id=144452
834 Reviewed by Martin Robinson.
836 * gtk/install-dependencies: Added hyphen as Fedora and Arch
839 2015-04-30 Brent Fulgham <bfulgham@apple.com>
841 Provide a runtime flag to run-webkit-tests that shows the test view
842 https://bugs.webkit.org/show_bug.cgi?id=144079.
844 Reviewed by Dean Jackson.
846 Add a new flag (--show-webview) that causes DumpRenderTree and WebKitTestRunner to display
847 their WebViews on-screen. This can be used when running tests via the "--additional-drt-flag"
850 --additional-drt-flag="--show-webview"
852 * DumpRenderTree/mac/DumpRenderTree.mm:
853 (createWebViewAndOffscreenWindow): Use an on-screen window rect if the user passed the
854 '--show-webview' flag.
855 (initializeGlobalsFromCommandLineOptions): Recognize the "--show-webview" option.
856 * WebKitTestRunner/Options.cpp:
857 (WTR::Options::Options):
858 (WTR::handleOptionShowWebView):
859 (WTR::OptionsHandler::OptionsHandler): Recognize the new "--show-webview" option.
860 * WebKitTestRunner/Options.h:
861 * WebKitTestRunner/TestController.cpp:
862 (WTR::TestController::TestController):
863 (WTR::TestController::initialize): Use value of 'shouldShowWebView' from the Options bundle.
864 * WebKitTestRunner/TestController.h:
865 (WTR::TestController::shouldShowWebView):
866 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
867 (WTR::PlatformWebView::PlatformWebView): Retrieve the value of the 'ShouldShowWebView' key from the
868 options dictionary. If it is true, display the web view while running the test.
870 2015-04-30 Alexey Proskuryakov <ap@apple.com>
872 r183355 didn't trigger Mac tests
873 https://bugs.webkit.org/show_bug.cgi?id=144464
875 Reviewed by Simon Fraser.
877 Update badly neglected filters and unit tests.
879 * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
880 (_should_file_trigger_build):
881 * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
883 (ShouldBuildTest.test_should_build):
885 2015-04-30 Xabier Rodriguez Calvar <calvaris@igalia.com>
887 [GTK] Add libhyphen-dev to the build dependencies
888 https://bugs.webkit.org/show_bug.cgi?id=144452
890 Reviewed by Martin Robinson.
892 * gtk/install-dependencies: Added libhyphen-dev to the WebKitGTK+
895 2015-04-30 Martin Robinson <mrobinson@igalia.com>
897 [GTK] Testing dictionaries are not installed automatically
898 https://bugs.webkit.org/show_bug.cgi?id=144460
900 Reviewed by Carlos Garcia Campos.
902 * gtk/jhbuild.modules: Add the testing dictionaries to the main moduleset.
904 2015-04-30 Dewei Zhu <dewei_zhu@apple.com>
906 Fix return code issue, check return code of safari process and dump results to log
907 https://bugs.webkit.org/show_bug.cgi?id=144436
909 Reviewed by Ryosuke Niwa.
911 * Scripts/run-benchmark:
912 * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
913 (BenchmarkRunner.dump): Correct typo.
914 (BenchmarkRunner.wrap): Add results to console.
915 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Check return code to detect Safari crashes.
916 (OSXSafariDriver.prepareEnv):
917 (OSXSafariDriver.launchUrl):
918 (OSXSafariDriver.closeBrowsers):
920 2015-04-29 Joseph Pecoraro <pecoraro@apple.com>
922 Should no longer need to worry about very old versions of Xcode
923 https://bugs.webkit.org/show_bug.cgi?id=144437
925 Reviewed by Dan Bernstein.
927 * Scripts/check-for-exit-time-destructors:
928 * Scripts/check-for-global-initializers:
929 * Scripts/check-for-weak-vtables-and-externals:
931 2015-04-29 Joseph Pecoraro <pecoraro@apple.com>
933 REGRESSION(183583): [Mac] make without SDKROOT has issues
934 https://bugs.webkit.org/show_bug.cgi?id=144431
936 Reviewed by Dan Bernstein.
939 * WebKitTestRunner/Makefile:
940 Assume an empty SDKROOT means an macosx variant, so only
941 enable settings if the SDKROOT is not empty and does not
944 2015-04-29 Brent Fulgham <bfulgham@apple.com>
946 Expand test infrastructure to support scrolling tests
947 https://bugs.webkit.org/show_bug.cgi?id=143684
948 <rdar://problem/20375516>
950 Reviewed by Simon Fraser.
952 * DumpRenderTree/mac/DumpRenderTree.mm:
953 (resetWebViewToConsistentStateBeforeTesting): Make sure the WheelEventTestTrigger state is
954 reset before the next test run.
955 * WebKitTestRunner/TestController.cpp:
956 (WTR::TestController::resetStateToConsistentValues): Ditto."
958 2015-04-29 Alex Christensen <achristensen@webkit.org>
960 Run javascriptcore tests on Windows without cygwin
961 https://bugs.webkit.org/show_bug.cgi?id=144419
963 Reviewed by Brent Fulgham.
965 * Scripts/run-javascriptcore-tests:
967 Just call ruby, not /usr/bin/env ruby.
969 2015-04-29 Yusuke Suzuki <utatane.tea@gmail.com>
971 [GTK] Add --enable-shared option to LLVM to build mesa
972 https://bugs.webkit.org/show_bug.cgi?id=144393
974 Reviewed by Martin Robinson.
976 The updated mesa requires the shared LLVM libraries.
977 To build mesa with LLVM in FTL build, this patch added `--enable-shared` option
978 to LLVM configure script. It will provide shared libraries in addition to static libraries.
980 * gtk/jhbuild-optional.modules:
982 2015-04-29 Martin Robinson <mrobinson@igalia.com>
984 [GTK] Add support for automatic hyphenation
985 https://bugs.webkit.org/show_bug.cgi?id=44478
987 Reviewed by Carlos Garcia Campos.
989 * gtk/jhbuild.modules: Add a module for testing dictionaries, so that
990 all systems will use the same dictionaries for testing purposes.
992 2015-04-29 Jake Nielsen <jacob_nielsen@apple.com>
994 Failure when building WebKit for appletvsimulator.
995 https://bugs.webkit.org/show_bug.cgi?id=144356
997 Reviewed by Alexey Proskuryakov.
999 Changes Makefile logic to check for "not OS X" rather than "is iOS" to
1000 make TVOS and WatchOS behave correctly.
1003 * WebKitTestRunner/Makefile:
1005 2015-04-29 Alexey Proskuryakov <ap@apple.com>
1007 Use-after-free when invalidating WKPageForceRepaint callback
1008 https://bugs.webkit.org/show_bug.cgi?id=144401
1009 rdar://problem/20741111
1011 Reviewed by Tim Horton.
1013 * WebKitTestRunner/TestController.h: (WTR::TestController::isCurrentInvocation): Added.
1015 * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::forceRepaintDoneCallback):
1016 Don't do anything on error, because the context may be a stale pointer now.
1018 2015-04-29 David Kilzer <ddkilzer@apple.com>
1020 check-webkit-style: Don't complain about returning value from Objective-C method call in header
1021 <http://webkit.org/b/144395>
1023 Reviewed by Andy Estes.
1025 * Scripts/webkitpy/style/checkers/cpp.py:
1026 (check_spacing): Update regex so 'return' is ignored if it
1027 precedes the whitespace and bracket. Change category name to
1028 'whitespace/brackets'. Add period to error message.
1029 (CppChecker): Add 'whitespace/brackets' as a category.
1030 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1031 (ErrorCollector.__call__): Replace 'STYLE_CATEGORIES' with
1032 'CppChecker.categories' since that's where the list lives now.
1033 (CppStyleTest.test_spacing_before_brackets): Add tests for
1034 'whitespace/brackets' issues and non-issues.
1036 2015-04-29 Alex Christensen <achristensen@webkit.org>
1040 * Scripts/webkitdirs.pm:
1041 (determinePassedConfiguration):
1042 WinCairo bot doesn't use cygwin, but it needs Release_WinCairo for its configuration.
1044 2015-04-29 Myles C. Maxfield <mmaxfield@apple.com>
1046 [OS X] Use CTFontCreateForCSS instead of doing font search ourselves
1047 https://bugs.webkit.org/show_bug.cgi?id=132159
1049 Reviewed by Darin Adler.
1051 Make DumpRenderTree and WebKitTestRunner use the new font whitelist instead of
1052 swizzling NSFontManager methods. This is predicated on ENABLE(PLATFORM_FONT_LOOKUP).
1054 * DumpRenderTree/mac/DumpRenderTree.mm:
1057 (createWebViewAndOffscreenWindow):
1058 * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1059 (WTR::activateFonts):
1060 * WebKitTestRunner/mac/TestControllerMac.mm:
1061 (WTR::allowedFontFamilySet):
1062 (WTR::systemHiddenFontFamilySet):
1063 (WTR::generateWhitelist):
1064 (WTR::TestController::platformInitializeContext):
1066 2015-04-29 Alexey Proskuryakov <ap@apple.com>
1068 fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
1069 https://bugs.webkit.org/show_bug.cgi?id=144155
1071 Reviewed by Andreas Kling.
1073 * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):
1074 Make sure that test window is "visible" before each test. While there is no concrete
1075 evidence that this is the problem indeed, the behavior is consistent with what would
1076 happen for an invisible window. Also, WKTR obviously needs to do this to protect
1077 against potential buggy tests that hide the window and don't show it.
1079 2015-04-29 Carlos Garcia Campos <cgarcia@igalia.com>
1081 Unreviewed. Fix /webkit2/WebKitWebInspectorServer/test-open-debugging-session.
1083 Latest changes in the inspector UI made this test fail. We were
1084 relying that the sidebar was always visible and the first 'li'
1085 element of the inspector was the one containing the title. This is
1086 no longer true, so better use document title that is not likely
1089 * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
1090 (openRemoteDebuggingSession):
1092 2015-04-29 Andres Gomez <agomez@igalia.com>
1094 Unreviewed. Re-sorted my contributor's mails to help bugzilla on showing the proper one.
1096 * Scripts/webkitpy/common/config/contributors.json:
1098 2015-04-29 Andres Gomez <agomez@igalia.com>
1100 Unreviewed. Created a new watchlist for changes in WebInspectorUI images and added myself to it.
1102 * Scripts/webkitpy/common/config/watchlist:
1104 2015-04-29 Hunseop Jeong <hs85.jeong@samsung.com>
1106 [EFL] Allow to run the tests on the native X display
1107 https://bugs.webkit.org/show_bug.cgi?id=144247
1109 Reviewed by Gyuyoung Kim.
1111 Added the USE_NATIVE_XDISPLAY option for the WTR.
1112 We can select the Xorg driver if environment variable is set up before running the tests.
1114 * Scripts/webkitpy/port/efl.py:
1115 (EflPort._driver_class):
1117 2015-04-29 Joonghun Park <jh718.park@samsung.com>
1119 [GTK] Add libnotify-dev in gtk install-dependencies
1120 https://bugs.webkit.org/show_bug.cgi?id=144379
1122 Reviewed by Žan Doberšek.
1124 * gtk/install-dependencies:
1126 2015-04-28 Ryuan Choi <ryuan.choi@navercorp.com>
1128 [CoordinatedGraphics] Merge TILED_BACKING_STORE guard with COORDINATED_GRAPHICS
1129 https://bugs.webkit.org/show_bug.cgi?id=143001
1131 Reviewed by Gyuyoung Kim.
1133 * WebKitTestRunner/TestController.cpp:
1134 (WTR::shouldUseFixedLayout):
1136 2015-04-28 Dewei Zhu <dewei_zhu@apple.com>
1138 Increase stablility of run-benchmark script
1139 https://bugs.webkit.org/show_bug.cgi?id=144361
1141 Reviewed by Ryosuke Niwa.
1143 * Scripts/run-benchmark:
1145 * Scripts/webkitpy/benchmark_runner/README.md: Update readme due to changes.
1146 * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
1147 (GenericBenchmarkBuilder.clean):
1148 * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Improve error handling and remove an unnecessary loop.
1149 (BenchmarkRunner.__init__):
1150 (BenchmarkRunner.execute):
1151 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1152 (OSXSafariDriver.prepareEnv): Remove saved sessions of Safari.
1153 * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Upload 'results' rather than 'time'.
1154 * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Update formate.
1155 * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Update formate.
1156 * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
1157 (ServerControl.render_POST): Flush the buffer to make sure we can pass the result to stdout.
1158 * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
1159 (HTTPServerDriver.fetchResult):
1161 (HTTPServerDriver.killServer): Add kill server interface.
1162 (HTTPServerDriver.getReturnCode): Add get return code interface.
1163 * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Adjust to support new interfaces.
1164 (SimpleHTTPServerDriver.serve):
1165 (SimpleHTTPServerDriver.fetchResult):
1166 (SimpleHTTPServerDriver):
1167 (SimpleHTTPServerDriver.killServer):
1168 (SimpleHTTPServerDriver.getReturnCode):
1169 * Scripts/webkitpy/benchmark_runner/utils.py:
1170 (forceRemove): Provide python version of 'rm -rf'.
1172 2015-04-28 Sam Weinig <sam@webkit.org>
1174 [Content Extensions] Process NFAs individually to avoid having all NFAs live at the same time
1175 https://bugs.webkit.org/show_bug.cgi?id=144363
1177 Reviewed by Alex Christensen.
1179 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1180 (TestWebKitAPI::createNFAs):
1181 (TestWebKitAPI::TEST_F):
1182 * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
1183 (TestWebKitAPI::countLiveNodes):
1184 (TestWebKitAPI::createNFAs):
1185 (TestWebKitAPI::buildDFAFromPatterns):
1186 Update tests to use a hand rolled createNFAs function on top of CombinedURLFilters::processNFAs.
1188 2015-04-28 Michael Catanzaro <mcatanzaro@igalia.com>
1190 Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
1191 https://bugs.webkit.org/show_bug.cgi?id=144304
1193 Reviewed by Geoffrey Garen.
1195 * Scripts/build-jsc: Use ENABLE_JIT instead of ENABLE_LLINT_C_LOOP on Mac. Always explicitly
1196 set the value of ENABLE_JIT and ENABLE_FTL_JIT to avoid assumptions about the default value.
1197 * Scripts/webkitperl/FeatureList.pm: Add --jit option to build-webkit.
1199 2015-04-28 Commit Queue <commit-queue@webkit.org>
1201 Unreviewed, rolling out r183514.
1202 https://bugs.webkit.org/show_bug.cgi?id=144359
1204 It broke cloop test bots (Requested by mcatanzaro on #webkit).
1208 "Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT"
1209 https://bugs.webkit.org/show_bug.cgi?id=144304
1210 http://trac.webkit.org/changeset/183514
1212 2015-04-28 Michael Catanzaro <mcatanzaro@igalia.com>
1214 Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
1215 https://bugs.webkit.org/show_bug.cgi?id=144304
1217 Reviewed by Geoffrey Garen.
1219 * Scripts/build-jsc: Use ENABLE_JIT instead of ENABLE_LLINT_C_LOOP on Mac. Perform sanity-
1220 checking to ensure --cloop and --ftl-jit cannot be combined. Always explicitly set the value
1221 of ENABLE_JIT and ENABLE_FTL_JIT to avoid assumptions about the default value.
1222 * Scripts/webkitperl/FeatureList.pm: Add --jit option to build-webkit.
1224 2015-04-28 Gyuyoung Kim <gyuyoung.kim@webkit.org>
1226 [CMake] Remove unnecessary include paths in TestWebKitAPI cmake files
1227 https://bugs.webkit.org/show_bug.cgi?id=144319
1229 Reviewed by Csaba Osztrogonác.
1231 * TestWebKitAPI/CMakeLists.txt:
1232 * TestWebKitAPI/PlatformEfl.cmake:
1234 2015-04-28 Joseph Pecoraro <pecoraro@apple.com>
1236 Fix common typo "targetting" => "targeting"
1237 https://bugs.webkit.org/show_bug.cgi?id=144349
1239 Reviewed by Daniel Bates.
1241 * Scripts/webkitdirs.pm:
1242 (execMacWebKitAppForDebugging):
1244 2015-04-28 Joanmarie Diggs <jdiggs@igalia.com>
1246 [GTK][jhbuild] Mesa build failure with llvm 3.6
1247 https://bugs.webkit.org/show_bug.cgi?id=144250
1249 Reviewed by Žan Doberšek.
1251 Bump the version of Mesa to 10.5.4
1253 * gtk/jhbuild.modules:
1255 2015-04-28 Alexey Proskuryakov <ap@apple.com>
1257 Disable App Nap in WebKitTestRunner UI process
1258 https://bugs.webkit.org/show_bug.cgi?id=144308
1260 Reviewed by Daniel Bates.
1262 * WebKitTestRunner/mac/main.mm:
1263 (disableAppNapInUIProcess):
1266 2015-04-28 Marcos Chavarría Teijeiro <chavarria1991@gmail.com>
1268 [GTK] Update JHBuild Mesa download directory
1269 https://bugs.webkit.org/show_bug.cgi?id=144318
1271 Update the download directory of Mesa module since the previous one
1272 doesn't exist any more.
1274 Reviewed by Žan Doberšek.
1276 * gtk/jhbuild.modules:
1278 2015-04-28 Commit Queue <commit-queue@webkit.org>
1280 Unreviewed, rolling out r183477.
1281 https://bugs.webkit.org/show_bug.cgi?id=144334
1283 Roll back the Mesa dependency bump in fear of uncaught
1284 regressions while the testing bots are no-op. (Requested by
1285 zdobersek on #webkit).
1289 "[GTK][jhbuild] Mesa build failure with llvm 3.6"
1290 https://bugs.webkit.org/show_bug.cgi?id=144250
1291 http://trac.webkit.org/changeset/183477
1293 2015-04-28 Joanmarie Diggs <jdiggs@igalia.com>
1295 [GTK][jhbuild] Mesa build failure with llvm 3.6
1296 https://bugs.webkit.org/show_bug.cgi?id=144250
1298 Reviewed by Žan Doberšek.
1300 Bump the version of Mesa to 10.5.4
1302 * gtk/jhbuild.modules:
1304 2015-04-27 Dewei Zhu <dewei_zhu@apple.com>
1306 Add '__init__.py' and fix known bug in benchmark runner.
1307 https://bugs.webkit.org/show_bug.cgi?id=144296
1309 Reviewed by Ryosuke Niwa
1311 * Scripts/webkitpy/benchmark_runner/__init__.py: Make python to recognize this module.
1312 * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Make python to recognize this module.
1313 * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1314 (BenchmarkRunner.__init__):
1315 (BenchmarkRunner.execute): Fix logic bug that '--output-file' option doesn't work, and empty output file bug.
1316 * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Make python to recognize this module.
1317 * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Make python to recognize this module.
1319 2015-04-27 Alexey Proskuryakov <ap@apple.com>
1323 * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
1324 (-[AccessibilityNotificationHandler _notificationReceived:]):
1325 Use -objectForKey:, not array subscript.
1327 2015-04-27 Alexey Proskuryakov <ap@apple.com>
1329 Catch unexpected exits in DumpRenderTree
1330 https://bugs.webkit.org/show_bug.cgi?id=144288
1332 Reviewed by Tim Horton.
1334 * DumpRenderTree/mac/DumpRenderTree.mm:
1336 (DumpRenderTreeMain):
1338 2015-04-27 Alexey Proskuryakov <ap@apple.com>
1342 * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
1343 (-[AccessibilityNotificationHandler _notificationReceived:]):
1344 Use -objectForKey:, not array subscript.
1346 2015-04-27 Alexey Proskuryakov <ap@apple.com>
1348 fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
1349 https://bugs.webkit.org/show_bug.cgi?id=144155
1351 Reviewed by Tim Horton.
1353 * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues):
1354 Disable App Nap. I don't have positive evidence that it's the culprit, but it could be,
1355 and we clearly don't want App Nap while testing.
1357 2015-04-22 Martin Robinson <mrobinson@igalia.com>
1359 [CMake] Autogenerate cmakeconfig.h.cmake
1360 https://bugs.webkit.org/show_bug.cgi?id=143997
1362 Reviewed by Csaba Osztrogonác.
1364 * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Add XP_UNIX to the command-line
1365 definitions since TestNetscapePlugIn does not use cmakeconfig.h.
1367 2015-04-27 Brent Fulgham <bfulgham@apple.com>
1369 REGRESSION(r182879): Images and video can no longer be downloaded
1370 https://bugs.webkit.org/show_bug.cgi?id=144267
1371 <rdar://problem/20702844>
1373 Reviewed by Simon Fraser.
1375 Revise tests to check for proper download menu state.
1376 1. Downloading a loal image should be disabled.
1377 2. Downloading a local media file should be disabled.
1378 3. Downloading non-downloadable media should be disabled.
1380 * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1381 (TestWebKitAPI::TEST):
1383 2015-04-27 Csaba Osztrogonác <ossy@webkit.org>
1385 Merge run-launcher into run-minibrowser
1386 https://bugs.webkit.org/show_bug.cgi?id=141928
1388 Reviewed by Darin Adler.
1390 * Scripts/run-iexploder-tests:
1391 (runSafariWithIExploder):
1392 * Scripts/run-launcher: Removed.
1393 * Scripts/run-minibrowser:
1394 * Scripts/webkitdirs.pm:
1396 * Scripts/webkitpy/port/efl.py:
1397 (EflPort.show_results_html_file):
1398 * Scripts/webkitpy/port/efl_unittest.py:
1399 (EflPortTest.test_show_results_html_file):
1400 * Scripts/webkitpy/port/gtk.py:
1401 (GtkPort.print_leaks_summary):
1402 (GtkPort.show_results_html_file):
1404 * Scripts/webkitpy/port/gtk_unittest.py:
1405 (GtkPortTest.test_show_results_html_file):
1407 2015-04-27 Csaba Osztrogonác <ossy@webkit.org>
1409 [buildbot] Fix the output of perf-test buildstep on timeout
1410 https://bugs.webkit.org/show_bug.cgi?id=144097
1412 Reviewed by Ryosuke Niwa.
1414 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1415 (RunAndUploadPerfTests.getText2):
1416 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1417 (RunAndUploadPerfTestsTest.test_buildbot_timeout):
1418 (RunAndUploadPerfTestsTest.test_build_bad_preparation): Deleted.
1420 2015-04-27 Csaba Osztrogonác <ossy@webkit.org>
1422 [EFL] TestWebKitAPI's forwarding header generator should depend on WebKit2's generator
1423 https://bugs.webkit.org/show_bug.cgi?id=143874
1425 Reviewed by Gyuyoung Kim.
1427 * TestWebKitAPI/PlatformEfl.cmake: Add the new dependency.
1429 2015-04-24 Philippe Normand <pnormand@igalia.com>
1431 [JHBuild] Move to upstream OpenWebRTC
1432 https://bugs.webkit.org/show_bug.cgi?id=144145
1434 Reviewed by Carlos Garcia Campos.
1436 * efl/jhbuild.modules: Switch to upstream OpenWebRTC repository
1437 and add a new simple patch to gst-plugins-base, required for
1439 * efl/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Added.
1440 * gtk/jhbuild.modules: Ditto.
1441 * gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Added.
1443 2015-04-26 Yusuke Suzuki <utatane.tea@gmail.com>
1445 [ES6] Implement ES6 template literals
1446 https://bugs.webkit.org/show_bug.cgi?id=142691
1448 Reviewed by Darin Adler.
1450 Add ENABLE_ES6_TEMPLATE_LITERAL_SYNTAX compile time flag.
1452 * Scripts/webkitperl/FeatureList.pm:
1454 2015-04-26 Gyuyoung Kim <gyuyoung.kim@webkit.org>
1456 [CMake][EFL] Remove unnecessary include, library path in WebKitTestRunner/PlatformEfl.cmake
1457 https://bugs.webkit.org/show_bug.cgi?id=144217
1459 Reviewed by Darin Adler.
1461 * WebKitTestRunner/PlatformEfl.cmake:
1463 2015-04-26 Doug Russell <d_russell@apple.com>
1465 AX: richer text change notifications (142719)
1466 https://bugs.webkit.org/show_bug.cgi?id=142719
1468 Reviewed by Darin Adler.
1470 Richer accessibility value change notifications. Introduce AXTextEditType,
1471 postTextStateChangeNotification and postTextReplacementNotification to give assistive
1472 tech apps more reliable context for responding to changes in web content. Also implement
1473 a mechanism to post value changes in password form fields in coalesced ticks to thwart
1474 analyzing the cadence of changes.
1476 Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent,
1477 and an overload of postTextReplacementNotification to give assistive tech apps more
1478 reliable context for responding to changes in web content selection. Also block posting
1479 selection changes on password fields.
1481 * DumpRenderTree/mac/AccessibilityNotificationHandler.h:
1482 * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
1483 (-[AccessibilityNotificationHandler stopObserving]):
1484 (-[AccessibilityNotificationHandler _notificationReceived:]):
1485 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1486 (AccessibilityUIElement::removeNotificationListener):
1487 * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
1488 (-[AccessibilityNotificationHandler _notificationReceived:]):
1489 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1490 (WTR::AccessibilityUIElement::removeNotificationListener):
1492 2015-04-25 Sungmann Cho <sungmann.cho@navercorp.com>
1494 Add myself to contributors.json
1495 https://bugs.webkit.org/show_bug.cgi?id=144204
1497 Reviewed by Darin Adler.
1499 * Scripts/webkitpy/common/config/contributors.json:
1501 2015-04-25 Martin Robinson <mrobinson@igalia.com>
1503 Rename ENABLE_3D_RENDERING to ENABLE_3D_TRANSFORMS
1504 https://bugs.webkit.org/show_bug.cgi?id=144182
1506 Reviewed by Simon Fraser.
1508 * DumpRenderTree/win/DumpRenderTree.cpp: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
1510 2015-04-25 Dewei Zhu <dewei_zhu@apple.com>
1512 https://bugs.webkit.org/show_bug.cgi?id=144038
1514 Reviewed by Ryosuke Niwa
1516 Add a script to run Speedometer and JetStream on a browser.
1518 * Scripts/run-benchmark: Wrapper script to run benchmark.
1520 * Scripts/webkitpy/benchmark_runner/README.md: Introduction of this script.
1521 * Scripts/webkitpy/benchmark_runner/__init__.py: Added.
1522 * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Added.
1523 * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py: Added.
1524 (BenchmarkBuilderFactory):
1525 * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Added.
1526 * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: Added.
1527 (GenericBenchmarkBuilder):
1528 (GenericBenchmarkBuilder.prepare):
1529 (GenericBenchmarkBuilder._copyBenchmarkToTempDir):
1530 (GenericBenchmarkBuilder._applyPatch):
1531 (GenericBenchmarkBuilder.clean):
1532 * Scripts/webkitpy/benchmark_runner/benchmark_builder/jetstream_benchmark_builder.py: Added.
1533 (JetStreamBenchmarkBuilder):
1534 (JetStreamBenchmarkBuilder.prepare):
1535 (JetStreamBenchmarkBuilder._runCreateScript):
1536 * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Main module that masters all the processes of benchmark running.
1538 (BenchmarkRunner.__init__):
1539 (BenchmarkRunner.execute):
1540 (BenchmarkRunner.dump):
1541 (BenchmarkRunner.wrap):
1542 (BenchmarkRunner.merge):
1543 * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Added.
1544 * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py: Added.
1546 (BrowserDriver.prepareEnv):
1547 (BrowserDriver.launchUrl):
1548 (BrowserDriver.closeBrowser):
1549 * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py: Added.
1550 (BrowserDriverFactory):
1551 * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json: Added.
1552 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: Added.
1554 (OSXChromeDriver.prepareEnv):
1555 (OSXChromeDriver.launchUrl):
1556 (OSXChromeDriver.closeBrowsers):
1557 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Added.
1559 (OSXSafariDriver.prepareEnv):
1560 (OSXSafariDriver.launchUrl):
1561 (OSXSafariDriver.closeBrowsers):
1562 * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Patch that makes JetStream compatible with this script.
1563 * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Patch that makes Speedometer compatible with this scritp.
1564 * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Added.
1565 * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Added.
1566 * Scripts/webkitpy/benchmark_runner/generic_factory.py: Factory for generic purpose.
1568 (GenericFactory.iterateGetItem):
1569 (GenericFactory.create):
1570 * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Added.
1571 * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: Added.
1573 (ServerControl.render_GET):
1574 (ServerControl.render_POST):
1575 * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py: Added.
1577 (HTTPServerDriver.serve):
1578 (HTTPServerDriver.fetchResult):
1579 * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver_factory.py: Added.
1580 (HTTPServerDriverFactory):
1581 * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_drivers.json: Added.
1582 * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Added.
1583 (SimpleHTTPServerDriver):
1584 (SimpleHTTPServerDriver.depends):
1585 (SimpleHTTPServerDriver.__init__):
1586 (SimpleHTTPServerDriver.serve):
1587 (SimpleHTTPServerDriver.baseUrl):
1588 (SimpleHTTPServerDriver.fetchResult):
1589 * Scripts/webkitpy/benchmark_runner/utils.py: Utility module.
1590 (ModuleNotFoundError):
1592 (getPathFromProjectRoot):
1597 (timeout.handle_timeout):
1598 (timeout.__enter__):
1601 2015-04-24 Commit Queue <commit-queue@webkit.org>
1603 Unreviewed, rolling out r183303.
1604 https://bugs.webkit.org/show_bug.cgi?id=144181
1606 Change was incorrect, broke builds (Requested by smfr on
1612 http://trac.webkit.org/changeset/183303
1614 2015-04-24 Simon Fraser <simon.fraser@apple.com>
1618 * MiniBrowser/mac/WK2BrowserWindowController.m:
1619 (-[WK2BrowserWindowController initWithConfiguration:]):
1621 2015-04-24 Brent Fulgham <bfulgham@apple.com>
1623 Disable ActionMenusPDFTest due to timeout on test bot
1625 * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1626 (TestWebKitAPI::TEST):
1628 2015-04-24 Commit Queue <commit-queue@webkit.org>
1630 Unreviewed, rolling out r183266.
1631 https://bugs.webkit.org/show_bug.cgi?id=144164
1633 Broke 32-bit build and a test. (Requested by ap on #webkit).
1637 "AX: richer text change notifications (142719)"
1638 https://bugs.webkit.org/show_bug.cgi?id=142719
1639 http://trac.webkit.org/changeset/183266
1641 2015-04-24 Brent Fulgham <bfulgham@apple.com>
1643 REGRESSION: WebKit2.ActionMenusTest API test fails
1644 https://bugs.webkit.org/show_bug.cgi?id=144149
1645 <rdar://problem/20677770>
1647 Reviewed by Tim Horton.
1649 * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Revise to use the same test PDF
1650 as the 'ActionMenusPDFTest'.
1651 * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1652 (TestWebKitAPI::TEST): Unskip the PDF portion of ActionMenusTest, and revise its expected output
1653 to match the hit test on the 'action-menu-target.pdf' test file.
1655 2015-04-24 Daniel Bates <dabates@apple.com>
1657 Cleanup: Use @memoized for property IOSSimulator.testing_device
1658 https://bugs.webkit.org/show_bug.cgi?id=141715
1660 Reviewed by Darin Adler.
1662 Simplify the caching of the result of IOSSimulator.testing_device
1663 and make the code more readable by making use of the @memoized declarator
1664 instead of explicitly managing a private instance variable,
1665 IOSSimulator._testing_device, for the cached result.
1667 * Scripts/webkitpy/port/ios.py:
1668 (IOSPort.determine_full_port_name):
1669 (IOSSimulatorPort.__init__): Delete instance variable IOSSimulatorPort._testing_device.
1671 (IOSSimulatorPort.testing_device): No need to cache the created device object in
1672 IOSSimulatorPort._testing_device since we are marking this function @memoized.
1673 (IOSSimulatorPort.reset_preferences): Code style fix; inline self.testing_device.path instead
1674 of caching in local variable since we only make use of this value exactly once in this function.
1675 (IOSPort.__init__): Deleted; The instance variable IOSPort._testing_device has never
1676 been used since being added in r178622. So, we can remove this constructor since
1677 it's the trivial constructor once we remove the instance variable IOSPort._testing_device.
1679 2015-04-24 Anders Carlsson <andersca@apple.com>
1681 Rename -[WKWebsiteDataStore isNonPersistent] to -[WKWebsiteDataStore isPersistent]
1682 https://bugs.webkit.org/show_bug.cgi?id=144158
1684 Reviewed by Beth Dakin.
1686 * MiniBrowser/mac/WK2BrowserWindowController.m:
1687 (-[WK2BrowserWindowController initWithConfiguration:]):
1689 2015-04-24 Doug Russell <d_russell@apple.com>
1691 AX: richer text change notifications (142719)
1692 https://bugs.webkit.org/show_bug.cgi?id=142719
1694 Reviewed by Darin Adler.
1696 Richer accessibility value change notifications. Introduce AXTextEditType, postTextStateChangeNotification and postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content. Also implement a mechanism to post value changes in password form fields in coalesced ticks to thwart analyzing the cadence of changes.
1698 Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent, and an overload of postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content selection. Also block posting selection changes on password fields.
1700 * DumpRenderTree/mac/AccessibilityNotificationHandler.h:
1701 * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
1702 (-[AccessibilityNotificationHandler stopObserving]):
1703 (-[AccessibilityNotificationHandler _notificationReceived:]):
1704 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1705 (AccessibilityUIElement::removeNotificationListener):
1706 * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
1707 (-[AccessibilityNotificationHandler _notificationReceived:]):
1708 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1709 (WTR::AccessibilityUIElement::removeNotificationListener):
1711 2015-04-24 Darin Adler <darin@apple.com>
1713 Convert OwnPtr and PassOwnPtr uses to std::unique_ptr
1714 https://bugs.webkit.org/show_bug.cgi?id=128007
1716 Reviewed by Anders Carlsson.
1718 * DumpRenderTree/win/HistoryDelegate.h: Removed unneeded include.
1719 * DumpRenderTree/win/UIDelegate.h: Ditto.
1721 * TestWebKitAPI/Tests/WTF/HashMap.cpp: Removed OwnPtr-specific test cases.
1722 * TestWebKitAPI/Tests/WTF/HashSet.cpp: Ditto.
1724 * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Removed unneeded include.
1726 * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Use unique_ptr.
1727 (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp): Use make_unique.
1728 * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Ditto.
1729 (TestWebKitAPI::WebKit2WillLoadTest::SetUp): Ditto.
1730 * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
1731 (WebKitDOMDOMWindowTest::create): Ditto.
1732 * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1733 (documentLoadedCallback): Use a queue of DelayedSignal objects instead
1734 of smart pointers to DelayedSIgnal objects.
1735 (uriChangedCallback): Ditto.
1737 2015-04-24 Brent Fulgham <bfulgham@apple.com>
1739 [Mac] Unreviewed test fix.
1740 https://bugs.webkit.org/show_bug.cgi?id=144149
1742 * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1743 (TestWebKitAPI::TEST): Temporarily skip the PDF <embed>
1746 2015-04-23 Darin Adler <darin@apple.com>
1748 Another round of removing use of OwnPtr, PassOwnPtr, and deleteOwnedPtr
1749 https://bugs.webkit.org/show_bug.cgi?id=144090
1751 Reviewed by Anders Carlsson.
1753 * DumpRenderTree/mac/DumpRenderTree.mm: Removed unneeded include.
1755 2015-04-23 Michael Saboff <msaboff@apple.com>
1757 lldb macro btjs sometimes can't get a frame description
1758 https://bugs.webkit.org/show_bug.cgi?id=144130
1760 Reviewed by Filip Pizlo.
1762 We look to execute ExecState::describeFrame(). It appears that in some contexts the
1763 debugger can't find ExecState. In those cases, CallFrame works as it is a typedef of
1764 ExecState. Therefore we can fallback to using CallFrame::describeFrame().
1766 * lldb/lldb_webkit.py:
1769 2015-04-23 Alex Christensen <achristensen@webkit.org>
1771 Use less memory when compiling content extensions.
1772 https://bugs.webkit.org/show_bug.cgi?id=144051
1774 Reviewed by Darin Adler and Benjamin Poulain.
1776 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1777 (TestWebKitAPI::TEST_F):
1778 * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
1779 (TestWebKitAPI::countLiveNodes):
1781 2015-04-22 Michael Catanzaro <mcatanzaro@igalia.com>
1783 [CMake] Clean up JSC JIT options
1784 https://bugs.webkit.org/show_bug.cgi?id=143998
1786 Reviewed by Filip Pizlo.
1788 * Scripts/build-jsc: Do not use -ENABLE_LLINT_C_LOOP on CMake ports.
1789 * Scripts/webkitperl/FeatureList.pm: Remove ENABLE_LLINT_C_LOOP.
1791 2015-04-21 Brent Fulgham <bfulgham@apple.com>
1793 [Mac] Extend action menus to support PDF
1794 https://bugs.webkit.org/show_bug.cgi?id=143895
1795 <rdar://problem/19003333>
1797 Reviewed by Tim Horton.
1799 Reactivate the action menu tests, and add a new PDF-based test to make sure that selection
1800 of PDF content works.
1802 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new 'test.pdf' resource to bundle.
1803 * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Update with a new PDF pane.
1804 * TestWebKitAPI/Tests/WebKit2/test.pdf: Added.
1805 * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1806 (-[ActionMenusTestWKView _actionMenuItemsForHitTestResult:withType:defaultActionMenuItems:userData:]):
1807 Update to support PDF tests.
1808 (TestWebKitAPI::windowPointForTarget): Add new target for PDF test.
1809 (TestWebKitAPI::waitForPDFToLoad): New helper function to avoid starting test before the PDF is available.
1811 2015-04-22 Carlos Garcia Campos <cgarcia@igalia.com>
1813 Unreviewed. Do not run GTK+ user media unit tests when ENABLE_MEDIA_STREAM is disabled.
1815 * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1817 (testWebViewAudioOnlyUserMediaPermissionRequests):
1819 2015-04-22 Michael Catanzaro <mcatanzaro@igalia.com>
1821 Add myself to watchlist
1822 https://bugs.webkit.org/show_bug.cgi?id=144041
1824 Reviewed by Alex Christensen.
1826 Add myself watching CMake, GtkWebKit2PublicAPI, SoupNetwork, and WebKitGTKTranslations.
1828 * Scripts/webkitpy/common/config/watchlist:
1830 2015-04-22 Carlos Garcia Campos <cgarcia@igalia.com>
1832 [GTK] MiniBrowser should use NetworkProcess by default
1833 https://bugs.webkit.org/show_bug.cgi?id=143948
1835 Reviewed by Sergio Villar Senin.
1837 Use WEBKIT_PROCESS_MODEL_MULTIPLE_SECONDARY_PROCESSES by default
1838 unless MINIBROWSER_SINGLEPROCESS environment variable is present.
1840 * MiniBrowser/gtk/main.c:
1843 2015-04-21 Matthew Hanson <matthew_hanson@apple.com>
1845 Use grep instead of any in prepare-ChangeLog, to avoid Windows compatibility issues.
1847 Unreviewed build fix.
1849 * Scripts/prepare-ChangeLog:
1850 (get_function_line_ranges_for_cpp):
1851 Use grep instead of any to determine if a string is an element of an array.
1853 2015-04-21 Anders Carlsson <andersca@apple.com>
1855 Fix block signatures
1856 https://bugs.webkit.org/show_bug.cgi?id=144002
1858 Reviewed by Andreas Kling.
1860 * MiniBrowser/mac/WK2BrowserWindowController.m:
1861 (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1863 2015-04-21 Philippe Normand <pnormand@igalia.com>
1865 [GTK] jhbuild should not use a branch for openwebrtc
1866 https://bugs.webkit.org/show_bug.cgi?id=143981
1868 Reviewed by Carlos Garcia Campos.
1870 * gtk/jhbuild.modules:
1872 2015-04-20 Matthew Hanson <matthew_hanson@apple.com>
1874 Fix compilation error for prepare-ChangeLog running with Perl version < v5.18.2.
1876 Unreviewed build fix.
1878 The any function was added to List::Utils between Perl v5.16.2 and Perl v5.18.2.
1879 However, it has been exposed by List::MoreUtils since its inception. This patch uses
1880 the any function exposed by List::MoreUtils for greater compatibility.
1882 * Scripts/prepare-ChangeLog:
1883 Use any from List::MoreUtils instead of List::Utils, as List::MoreUtils exposes
1884 the any function in all of versions of Perl used by our infrastructure.
1886 2015-04-20 Alex Christensen <achristensen@webkit.org>
1888 Remove unnecessary logs when resetting tests.
1890 * WebKitTestRunner/mac/TestControllerMac.mm:
1891 (WTR::TestController::platformResetPreferencesToConsistentValues):
1892 In r183020 I added some logs when compiling or removing content extensions fails.
1893 We often try to remove a content extension that does not exist, and that is not a problem.
1895 2015-04-17 Matthew Hanson <matthew_hanson@apple.com>
1897 prepare-ChangeLog should ignore the preceeding function when processing the removal of a function.
1898 https://bugs.webkit.org/show_bug.cgi?id=143897
1900 Reviewed by David Kilzer.
1902 This is a speculative fix that addresses two issues:
1904 1. An off-by-one error which allowed ending lines to be less than starting lines when a hunk was a pure delete.
1905 We were determining ending lines from combined diffs using the logic: End = Start + Offset - 1.
1907 So for a hunk like "@@ -723,10 +721,0 @@ bool foobar", we were generating the following starting/ending line pairs:
1911 Before is correct, but After should be (721, 721), since it represents the beginning and ending lines for the hunk.
1912 Whether there are zero lines or one line in the hunk, the starting and ending line are the same.
1914 This error was causing bad behavior on purely additive and purely subtractive hunks, but since we only refer
1915 to After when generating ChangeLog output, the extractLineRangeBeforeChange had no visible effect on program output.
1917 The fix is to set End to the max of Start + Offset - 1 and Start, rather than always using the former.
1919 2. Creating git diffs from HEAD and not origin/master by default.
1921 Hard-coding origin/master into the originalFile command has the disadvantage of causing the diff to fail entirely
1922 when origin/master does not exist, and to do the wrong thing when determining deleted functions/methods.
1924 * Scripts/prepare-ChangeLog:
1926 Use HEAD instead of origin/master in default Git case.
1928 (generateFunctionLists):
1929 Ensure that the end line is not less than the start line.
1931 (extractLineRangeAfterChange):
1932 Set the end line to the start line if the end line is less than the start line.
1934 (extractLineRangeBeforeChange):
1937 2015-04-17 Matthew Hanson <matthew_hanson@apple.com>
1939 Suppress warning in prepare-ChangeLog.
1940 https://bugs.webkit.org/show_bug.cgi?id=143882
1942 Reviewed by David Kilzer.
1944 Prune noisy prepare-ChangeLog output by using the List::Util::any function
1945 instead of the deprecated smartmatch operator.
1947 * Scripts/prepare-ChangeLog:
1948 Import the List::Util::any function.
1950 (get_function_line_ranges_for_cpp):
1951 Use the any function instead of smartmatch.
1953 2015-04-20 Anders Carlsson <andersca@apple.com>
1955 Modify the WKWebsiteDataStore API to take a NSSet of types instead of a bitmask
1956 https://bugs.webkit.org/show_bug.cgi?id=143966
1958 Reviewed by Dan Bernstein.
1960 * MiniBrowser/mac/WK2BrowserWindowController.m:
1962 (-[WK2BrowserWindowController fetchWebsiteData:]):
1963 (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
1964 (-[WK2BrowserWindowController clearWebsiteData:]):
1966 2015-04-20 Alex Christensen <achristensen@webkit.org>
1968 Fix content extension test flakiness.
1969 https://bugs.webkit.org/show_bug.cgi?id=143950
1971 Reviewed by Brady Eidson.
1973 * WebKitTestRunner/mac/TestControllerMac.mm:
1974 (WTR::TestController::platformResetPreferencesToConsistentValues):
1975 Remove the TestContentExtensions if it exists.
1976 (WTR::TestController::platformConfigureViewForTest):
1977 Log errors in case there are any.
1979 2015-04-20 Alex Christensen <achristensen@webkit.org>
1981 Properly report errors from _WKUserContentExtensionStore.
1982 https://bugs.webkit.org/show_bug.cgi?id=143808
1984 Reviewed by Darin Adler.
1986 * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
1989 2015-04-20 Carlos Garcia Campos <cgarcia@igalia.com>
1991 Add a rule for NetworkCache to watchlist file
1992 https://bugs.webkit.org/show_bug.cgi?id=143945
1994 Reviewed by Sergio Villar Senin.
1996 And add myself to the list of watchers.
1998 * Scripts/webkitpy/common/config/watchlist:
2000 2015-04-19 Darin Adler <darin@apple.com>
2002 Update RefPtr documentation and deprecation
2003 https://bugs.webkit.org/show_bug.cgi?id=143936
2005 Reviewed by Andreas Kling.
2007 * Scripts/do-webcore-rename: Put in some DeprecatedPassRefPtr renames.
2009 2015-04-19 Yusuke Suzuki <utatane.tea@gmail.com>
2011 Introduce bytecode intrinsics
2012 https://bugs.webkit.org/show_bug.cgi?id=143926
2014 Reviewed by Filip Pizlo.
2016 Change cpplint to accept emit_intrinsic_XXX.
2018 * Scripts/webkitpy/style/checkers/cpp.py:
2019 (check_identifier_name_in_declaration):
2021 2015-04-18 Simon Fraser <simon.fraser@apple.com>
2023 Fix lldb_webkit.py to show StringImpls correctly
2024 https://bugs.webkit.org/show_bug.cgi?id=143920
2026 Reviewed by Andreas Kling.
2028 Update WTFStringImplProvider's is_8bit to use the correct bitmask.
2030 * lldb/lldb_webkit.py:
2031 (WTFStringImplProvider.is_8bit):
2033 2015-04-17 Daniel Bates <dabates@apple.com>
2035 Not able to build WebKit against iOS Simulator 8.3 SDK
2036 https://bugs.webkit.org/show_bug.cgi?id=143883
2038 Reviewed by David Kilzer.
2040 Copy libraries libWebKitSystemInterfaceIOS{Device, Simulator}8.3.a to the built product directory
2041 so that Xcode uses them.
2043 * Scripts/copy-webkitlibraries-to-product-directory:
2045 2015-04-17 Beth Dakin <bdakin@apple.com>
2047 Force mouse events should go through normal mouse event handling code paths
2048 https://bugs.webkit.org/show_bug.cgi?id=143749
2050 rdar://problem/20472895
2052 Reviewed by Dean Jackson.
2054 Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner.
2055 Since there is not a way to create an NSEventTypePressure from scratch, we
2056 subclass NSEvent and override all of the critical methods.
2058 * WebKitTestRunner/EventSenderProxy.h:
2059 * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2060 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2061 (WTR::EventSendingController::mouseForceDown):
2062 (WTR::EventSendingController::mouseForceUp):
2063 (WTR::EventSendingController::mouseForceChanged):
2064 * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2065 * WebKitTestRunner/TestController.cpp:
2066 (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2067 * WebKitTestRunner/mac/EventSenderProxy.mm:
2068 (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
2069 (-[EventSenderPressureEvent timestamp]):
2070 (-[EventSenderPressureEvent type]):
2071 (-[EventSenderPressureEvent locationInWindow]):
2072 (-[EventSenderPressureEvent location]):
2073 (-[EventSenderPressureEvent stage]):
2074 (-[EventSenderPressureEvent pressure]):
2075 (-[EventSenderPressureEvent phase]):
2076 (-[EventSenderPressureEvent eventNumber]):
2077 (WTR::EventSenderProxy::mouseForceDown):
2078 (WTR::EventSenderProxy::mouseForceUp):
2079 (WTR::EventSenderProxy::mouseForceChanged):
2081 2015-04-17 Alexey Proskuryakov <ap@apple.com>
2083 build.webkit.org/dashboard still shows obsolete results for out of order builds sometimes
2084 https://bugs.webkit.org/show_bug.cgi?id=143885
2086 Reviewed by Tim Horton.
2088 Fixed a case where we have two builds with the same revision(s). An in order build
2089 is one for which the revision is strictly higher.
2091 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2092 (BuildbotQueue.prototype._checkForInOrderResult):
2093 (BuildbotQueue.prototype.compareIterationsByRevisions):
2095 2015-04-17 Commit Queue <commit-queue@webkit.org>
2097 Unreviewed, rolling out r182912 and r182920.
2098 https://bugs.webkit.org/show_bug.cgi?id=143881
2100 Build breakage in some configurations (Requested by ap on
2103 Reverted changesets:
2105 "Force mouse events should go through normal mouse event
2106 handling code paths"
2107 https://bugs.webkit.org/show_bug.cgi?id=143749
2108 http://trac.webkit.org/changeset/182912
2110 http://trac.webkit.org/changeset/182920
2112 2015-04-17 Csaba Osztrogonác <ossy@webkit.org>
2114 [GTK] One more unreviewed fix after r182882.
2116 * TestWebKitAPI/PlatformGTK.cmake: Added back the WebKit2's forwarding header generator dependency.
2118 2015-04-17 Csaba Osztrogonác <ossy@webkit.org>
2120 [GTK] Unreviewed speculative clean build fix after r182882.
2122 TestWebKitAPI's forwarding header generator depended on WeKit2's
2123 which generated SOUP related forwarding headers too.
2125 This dependency isn't necessary and was removed by r182882 to make
2126 forwarding header generators parallelizable. But in this case
2127 TestWebKitAPI's and WebKitTestRunner's forwarding header generator
2128 should generate SOUP related forwarding headers too similar to EFL.
2130 * TestWebKitAPI/PlatformGTK.cmake:
2131 * WebKitTestRunner/PlatformGTK.cmake:
2133 2015-04-17 Carlos Garcia Campos <cgarcia@igalia.com>
2135 [SOUP] Redirect to non HTTP destination is broken
2136 https://bugs.webkit.org/show_bug.cgi?id=143866
2138 Reviewed by Sergio Villar Senin.
2140 Add a unit test to check that redirect to a data URI works.
2142 * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
2143 (testRedirectToDataURI):
2147 2015-04-16 Jake Nielsen <jacob_nielsen@apple.com>
2149 Changes method of quitting iOS Simulator to be more correct.
2150 https://bugs.webkit.org/show_bug.cgi?id=143847
2151 <rdar://problem/20530344>
2153 Reviewed by Darin Adler.
2155 Fixes by addressing the app by ID rather than by name.
2157 * Scripts/webkitdirs.pm:
2159 * Scripts/webkitpy/port/ios.py:
2160 (IOSSimulatorPort.check_sys_deps):
2162 2015-04-16 Anders Carlsson <andersca@apple.com>
2164 Deprecate _WKWebsiteDataStore in favor of WKWebsiteDataStore
2165 https://bugs.webkit.org/show_bug.cgi?id=143844
2167 Reviewed by Dan Bernstein.
2169 * MiniBrowser/mac/AppDelegate.m:
2170 (-[BrowserAppDelegate newPrivateWindow:]):
2171 * MiniBrowser/mac/WK2BrowserWindowController.m:
2172 (-[WK2BrowserWindowController initWithConfiguration:]):
2173 (-[WK2BrowserWindowController fetchWebsiteData:]):
2174 (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
2175 (-[WK2BrowserWindowController clearWebsiteData:]):
2177 2015-04-16 Alex Christensen <achristensen@webkit.org>
2181 * WebKitTestRunner/mac/TestControllerMac.mm:
2182 (WTR::TestController::platformResetPreferencesToConsistentValues):
2183 (WTR::TestController::platformConfigureViewForTest):
2184 Added WK_API_ENABLED.
2186 2015-04-16 Alex Christensen <achristensen@webkit.org>
2188 Removed unused WKUserContentFilterRef.
2189 https://bugs.webkit.org/show_bug.cgi?id=143852
2191 Reviewed by Sam Weinig.
2193 * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
2194 * WebKitTestRunner/mac/TestControllerMac.mm:
2195 (WTR::TestController::platformResetPreferencesToConsistentValues):
2196 (WTR::TestController::platformConfigureViewForTest):
2198 2015-04-16 Jake Nielsen <jacob_nielsen@apple.com>
2200 Unreviewed. Adding myself as a commiter in contributers.json.
2202 * Scripts/webkitpy/common/config/contributors.json:
2204 2015-04-16 Alexey Proskuryakov <ap@apple.com>
2206 It is very hard to attach a debugger to WebProcess to debug tests
2207 https://bugs.webkit.org/show_bug.cgi?id=143837
2209 Reviewed by Chris Dumez.
2211 --no-timeout used to only affect waitUntilDone timeout, but not IPC timeout in
2212 WebKitTestRunner, and not pipe reading timeout in run-webkit-tests.
2214 Now it disables all timeouts in tools, as is best for debugging tests.
2216 * Scripts/webkitpy/port/driver.py: (Driver.run_test): Respect --no-timeout, so
2217 that the script doesn't terminate DRT/WKTR when there is no output for a long time.
2219 * WebKitTestRunner/Options.cpp: Removed --no-timeout-at-all, as --no-timeout
2220 now has the same functionality.
2222 2015-04-16 Beth Dakin <bdakin@apple.com>
2224 Force mouse events should go through normal mouse event handling code paths
2225 https://bugs.webkit.org/show_bug.cgi?id=143749
2227 rdar://problem/20472895
2229 Reviewed by Dean Jackson.
2231 Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner.
2232 Since there is not a way to create an NSEventTypePressure from scratch, we
2233 subclass NSEvent and override all of the critical methods.
2235 * WebKitTestRunner/EventSenderProxy.h:
2236 * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2237 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2238 (WTR::EventSendingController::mouseForceDown):
2239 (WTR::EventSendingController::mouseForceUp):
2240 (WTR::EventSendingController::mouseForceChanged):
2241 * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2242 * WebKitTestRunner/TestController.cpp:
2243 (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2244 * WebKitTestRunner/mac/EventSenderProxy.mm:
2245 (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
2246 (-[EventSenderPressureEvent timestamp]):
2247 (-[EventSenderPressureEvent type]):
2248 (-[EventSenderPressureEvent locationInWindow]):
2249 (-[EventSenderPressureEvent location]):
2250 (-[EventSenderPressureEvent stage]):
2251 (-[EventSenderPressureEvent pressure]):
2252 (-[EventSenderPressureEvent phase]):
2253 (-[EventSenderPressureEvent eventNumber]):
2254 (WTR::EventSenderProxy::mouseForceDown):
2255 (WTR::EventSenderProxy::mouseForceUp):
2256 (WTR::EventSenderProxy::mouseForceChanged):
2258 2015-04-16 Csaba Osztrogonác <ossy@webkit.org>
2260 [EFL] Bump LLVM to version 3.6.0 on X86_64
2261 https://bugs.webkit.org/show_bug.cgi?id=143604
2263 Reviewed by Gyuyoung Kim.
2265 * efl/jhbuild.modules:
2266 * efl/patches/llvm-elf-add-stackmaps-arm64.patch: Added the necessary part of llvm-elf-add-stackmaps.patch.
2267 * efl/patches/llvm-elf-add-stackmaps.patch: Removed, it is included in LLVM 3.6.0 release.
2268 * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Removed, it is included in LLVM 3.6.0 release.
2269 * efl/patches/llvm-version-arm64.patch: Added. Set PACKAGE_VERSION to "3.5.0ftl" to be able to ensure we use patched LLVM on AArch64.
2271 2015-04-16 Csaba Osztrogonác <ossy@webkit.org>
2273 [EFL] Remove an unnecessary workaround from jhbuildrc
2274 https://bugs.webkit.org/show_bug.cgi?id=143823
2276 Reviewed by Gyuyoung Kim.
2280 2015-04-16 Csaba Osztrogonác <ossy@webkit.org>
2282 [GTK] Run forwarding headers generator unconditionally
2283 https://bugs.webkit.org/show_bug.cgi?id=143819
2285 Reviewed by Carlos Garcia Campos.
2287 * TestWebKitAPI/PlatformGTK.cmake:
2288 * WebKitTestRunner/PlatformGTK.cmake:
2290 2015-04-15 Gyuyoung Kim <gyuyoung.kim@webkit.org>
2292 [EFL] Add gnutls to jhbuild.module
2293 https://bugs.webkit.org/show_bug.cgi?id=143777
2295 Reviewed by Csaba Osztrogonác.
2297 EFL port has required at least 3.0.0 version of gnutls since r176712.
2298 However some old linux distributions don't support 3.0.0 version. Besides
2299 other projects sometimes need to use lower version of gnutls.
2301 This patch supports to download gnutls through jhbuild, and use it.
2303 * efl/install-dependencies: Add nettle-dev dependency and remove libgnutls28-dev.
2304 * efl/jhbuild.modules: Download 3.3 version because 3.3 version is stable version.
2306 2015-04-15 Mark Lam <mark.lam@apple.com>
2308 Remove obsolete VMInspector debugging tool.
2309 https://bugs.webkit.org/show_bug.cgi?id=143798
2311 Reviewed by Michael Saboff.
2313 * TestWebKitAPI/CMakeLists.txt:
2314 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2315 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
2316 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2317 * TestWebKitAPI/Tests/JavaScriptCore/VMInspector.cpp: Removed.
2319 2015-04-15 Jer Noble <jer.noble@apple.com>
2321 Unreviewed gardening; Make the previous commit apply only _post_ Yosemite.
2323 * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2325 2015-04-15 Jer Noble <jer.noble@apple.com>
2327 Unreviewed gardening; disable FullscreenZoomInitialFrame.WebKit2 API test post-Yosemite.
2329 * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2330 (TestWebKitAPI::TEST_F):
2332 2015-04-15 Chris Dumez <cdumez@apple.com>
2334 [Win] DRT does not seem to reset the 'UsesPageCache' setting between tests
2335 https://bugs.webkit.org/show_bug.cgi?id=143779
2337 Reviewed by Brent Fulgham.
2339 Reset the 'UsesPageCache' setting to FALSE between tests on Windows,
2340 similarly to what is done on Mac / WK1. Without this, PageCache could
2341 stay enabled after page cache tests and cause weird behaviors.
2343 * DumpRenderTree/win/DumpRenderTree.cpp:
2344 (resetWebPreferencesToConsistentValues):
2346 2015-04-14 Simon Fraser <simon.fraser@apple.com>
2348 Re-enable custom dilation for antialiased fonts
2349 https://bugs.webkit.org/show_bug.cgi?id=143738
2351 Reviewed by Tim Horton.
2353 Enabling custom dilation for antialised fonts broke layout tests, so re-land it,
2354 but disable in WebKitTestRunner and DumpRenderTree. The latter requires adding
2355 a private WebKit pref. This pref defaults to YES, enabling the feature by default
2356 in WK1 as we do for WK2.
2358 * DumpRenderTree/mac/DumpRenderTree.mm:
2359 (resetWebPreferencesToConsistentValues):
2360 * WebKitTestRunner/TestController.cpp:
2361 (WTR::TestController::resetPreferencesToConsistentValues):
2363 2015-04-14 Brent Fulgham <bfulgham@apple.com>
2365 Correct layering violation in DumpRenderTree Build
2366 https://bugs.webkit.org/show_bug.cgi?id=143732
2368 Reviewed by Simon Fraser.
2370 Correct a layering violation in DumpRenderTree by calling functions on the
2371 WebCoreTestSupport library, rather than attempting to work with WebCore
2374 * DumpRenderTree/mac/EventSendingController.mm:
2375 (-[EventSendingController monitorWheelEvents]): Call methods on WebCoreTestSupport, rather
2376 than WebCore itself.,
2377 (-[EventSendingController callAfterScrollingCompletes:]): Ditto.
2379 2015-04-14 Benjamin Poulain <benjamin@webkit.org>
2381 Add a conservative DFA minimizer for the content extension matcher
2382 https://bugs.webkit.org/show_bug.cgi?id=143501
2384 Reviewed by Alex Christensen.
2386 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2387 * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
2389 2015-04-14 Daniel Bates <dabates@apple.com>
2391 Skip failing test Tests/WebKit2Cocoa/FixedLayoutSize.mm on iOS
2392 https://bugs.webkit.org/show_bug.cgi?id=143693
2393 <rdar://problem/20530316>
2395 Reviewed by Tim Horton.
2397 Skip the test Tests/WebKit2Cocoa/FixedLayoutSize.mm as we do not plan
2398 to use the fixed layout code on iOS at this time.
2400 * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Add !PLATFORM(IOS)-guard.
2402 2015-04-14 Dominik Röttsches <dominik.rottsches@intel.com>
2404 Remove myself from watchlist, remove empty Cairo and HarfBuzz watchlists
2405 https://bugs.webkit.org/show_bug.cgi?id=143705
2407 Unreviewed change to watchlist file.
2409 * Scripts/webkitpy/common/config/watchlist:
2411 2015-04-14 KwangHyuk Kim <hyuki.kim@samsung.com>
2413 [EFL] favicon wasn't updated for google.com sometimes.
2414 https://bugs.webkit.org/show_bug.cgi?id=141940
2416 Reviewed by Gyuyoung Kim.
2418 As elm_entry_utf8_to_markup can include additional characters, parameter for the
2419 on_icon_changed_cb was just set by using url string retrieved by ewk_view_url_get().
2421 * MiniBrowser/efl/main.c:
2424 2015-04-13 Tim Horton <timothy_horton@apple.com>
2426 Add a persistent, fixed scale factor to make it easy to scale down WK(Web)Views
2427 https://bugs.webkit.org/show_bug.cgi?id=143560
2428 <rdar://problem/16302047>
2430 Reviewed by Darin Adler.
2432 * MiniBrowser/mac/BrowserWindowController.h:
2433 * MiniBrowser/mac/MainMenu.xib:
2434 * MiniBrowser/mac/WK1BrowserWindowController.m:
2435 (-[WK1BrowserWindowController setScale:]):
2436 * MiniBrowser/mac/WK2BrowserWindowController.m:
2437 (viewScaleForMenuItemTag):
2438 (-[WK2BrowserWindowController setScale:]):
2439 (-[WK2BrowserWindowController validateMenuItem:]):
2440 Add a submenu with four view scale options: 100%, 75%, 50%, and 25%.
2441 When in use, we resize the window so that the view fits correctly, and
2442 use automaticallyComputesFixedlayoutSizeFromViewScale so that the page's
2443 layout size will not change when scaling down (but will update appropriately
2444 when the view is resized).
2446 2015-04-13 Alexey Proskuryakov <ap@apple.com>
2448 build.webkit.org/dashboard shows obsolete results when builds are substantially out of order
2449 https://bugs.webkit.org/show_bug.cgi?id=138630
2451 Reviewed by Tim Horton.
2453 Make sure that we always load at least one in order productive iteration.
2455 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2456 (BuildbotQueue): Added _hasLoadedIterationForInOrderResult to track whether the queue
2457 is done loading at least one iteration that wasn't an out of order build.
2458 (BuildbotQueue.prototype.loadMoreHistoricalIterations): Listen for iteration load
2459 when that's needed to check for out of order builds.
2460 (BuildbotQueue.prototype.update): Ditto.
2461 (BuildbotQueue.prototype._checkForInOrderResult): Check if the queue has an in order
2462 result, and if it does not, load more iterations.
2463 (BuildbotQueue.prototype.loadAll): We have everything loaded, so we certainly have
2464 an in order iteration loaded too.
2465 (BuildbotQueue.prototype.compareIterations): Extracted from sortIterations(), and
2466 corrected to always sort loaded iterations before unloaded ones.
2468 2015-04-10 Brent Fulgham <bfulgham@apple.com>
2470 Expand test infrastructure to support scrolling tests
2471 https://bugs.webkit.org/show_bug.cgi?id=143286
2472 <rdar://problem/20375516>
2474 Reviewed by Simon Fraser.
2476 Extend the WK1 and WK2 test programs to support two new EventSender commands:
2477 (1) monitorWheelEvents: Tells DRT and WKTR to track the wheel event and animation state, so that we can
2478 block executing tests until WebKit has completed any rubberband, scroll, or scroll-snap animations.
2479 (2) callAfterScrollingCompletes: Provide a callback method to be executed when WebKit determines that
2480 relevant rubberband, scroll, and scroll-snap animations are finished.
2482 * DumpRenderTree/mac/EventSendingController.mm:
2483 (+[EventSendingController isSelectorExcludedFromWebScript:]): Update to recognize 'callAfterScrollingCompletes:'
2484 and 'monitorWheelEvents'.
2485 (+[EventSendingController webScriptNameForSelector:]): Ditto.
2486 (-[EventSendingController mouseScrollByX:andY:continuously:]): Add some stderr logging to help when
2487 debugging test failures.
2488 (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Ditto.
2489 (-[EventSendingController callAfterScrollingCompletes:]): Added. Protects the JSObject representing the callback
2490 function, then passes it to WebCore to be called once the test deferrals have been cleared.
2491 (-[EventSendingController monitorWheelEvents:]): Added. Activates the wheel event tracking used by the
2492 'callAfterScrollingCompletes' method.
2493 * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added signatures for 'callAfterScrollingCompletes'
2494 and 'monitorWheelEvents'.
2495 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2496 (WTR::EventSendingController::callAfterScrollingCompletes): Added. Protects the JSObject representing the
2497 callback function, then passes it to WebCore to be called once the test deferrals have been cleared
2498 (WTR::EventSendingController::monitorWheelEvents): Added. Activates the wheel event tracking used by the
2499 'callAfterScrollingComplates' method.
2500 * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2502 2015-04-13 Alexey Proskuryakov <ap@apple.com>
2504 build.webkit.org/dashboard: Crash-only queues should show failure when testing fails to start
2505 https://bugs.webkit.org/show_bug.cgi?id=143656
2507 Reviewed by Darin Adler.
2509 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2510 (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2512 2015-04-13 Sergio Villar Senin <svillar@igalia.com>
2514 REGRESSION(r181134): [GTK] Test /webkit2/WebKitWebView/insecure-content is failing after r181134
2515 https://bugs.webkit.org/show_bug.cgi?id=142387
2517 Reviewed by Carlos Garcia Campos.
2519 Running mixed content is blocked by default since r181134. Updated
2520 the test case to reflect the new default settings.
2522 * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2523 (testInsecureContent):
2525 2015-04-13 Gyuyoung Kim <gyuyoung.kim@webkit.org>
2527 Fix wrong value variable in ENABLE_NAVIGATOR_HWCONCURRENCY
2528 https://bugs.webkit.org/show_bug.cgi?id=143667
2530 Reviewed by Csaba Osztrogonác.
2532 ENABLE_NAVIGATOR_HWCONCURRENCY has used $registerProtocolHandlerSupport value variable
2533 since r169017. Added $hardwareConcurrencySupport for it.
2535 Additionally networkInfoSupport is removed because this feature was removed due to spec out.
2537 * Scripts/webkitperl/FeatureList.pm:
2539 2015-04-13 Csaba Osztrogonác <ossy@webkit.org>
2541 [cmake] Add ENABLE(ATTACHMENT_ELEMENT) to the build system
2542 https://bugs.webkit.org/show_bug.cgi?id=143664
2544 Reviewed by Gyuyoung Kim.
2546 * Scripts/webkitperl/FeatureList.pm:
2548 2015-04-12 Gyuyoung Kim <gyuyoung.kim@webkit.org>
2550 [EFL] Enable Media Source
2551 https://bugs.webkit.org/show_bug.cgi?id=143635
2553 Reviewed by Csaba Osztrogonác.
2555 * Scripts/webkitperl/FeatureList.pm: Enable media source on efl port.
2557 2015-04-12 Alexey Proskuryakov <ap@apple.com>
2559 build.webkit.org/dashboard: Crash-only queues should show failure when failure limit is exceeded
2560 https://bugs.webkit.org/show_bug.cgi?id=143646
2562 Reviewed by David Kilzer.
2564 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2565 (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2567 2015-04-11 Alexey Proskuryakov <ap@apple.com>
2569 Use en_US spell checker for tests on Mac instead of Multilingual
2570 https://bugs.webkit.org/show_bug.cgi?id=143641
2572 Reviewed by Dan Bernstein.
2574 * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
2575 While at it, override NSUserDictionaryReplacementItems, so that user replacements
2576 cannot affect tests.
2578 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize):
2579 Made this more like WebKit1 version.
2581 2015-04-10 Tim Horton <timothy_horton@apple.com>
2583 Replace setFixedLayoutSizeEnabled: with an enum of layout modes
2584 https://bugs.webkit.org/show_bug.cgi?id=143576
2586 Reviewed by Simon Fraser.
2588 * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm:
2592 2015-04-09 Gyuyoung Kim <gyuyoung.kim@webkit.org>
2594 Update my email address and expertise.
2595 https://bugs.webkit.org/show_bug.cgi?id=143586
2597 Unreviewed, just update my info.
2599 * Scripts/webkitpy/common/config/contributors.json:
2601 2015-04-09 Joseph Pecoraro <pecoraro@apple.com>
2603 Flakiness Dashboard not loading insecure content if loaded with https URL
2604 https://bugs.webkit.org/show_bug.cgi?id=143570
2606 Reviewed by Alexey Proskuryakov.
2608 * TestResultServer/app.yaml:
2609 * TestResultServer/static-dashboards/loader.js:
2610 Switch to https scheme.
2612 2015-04-09 Csaba Osztrogonác <ossy@webkit.org>
2614 [EFL][GTK] WebKit2's generate-forwarding-headers.pl runs too many times
2615 https://bugs.webkit.org/show_bug.cgi?id=142907
2617 Reviewed by Carlos Garcia Campos.
2619 * TestWebKitAPI/PlatformEfl.cmake:
2620 * TestWebKitAPI/PlatformGTK.cmake:
2621 * WebKitTestRunner/PlatformEfl.cmake:
2622 * WebKitTestRunner/PlatformGTK.cmake:
2624 2015-04-08 Brent Fulgham <bfulgham@apple.com>
2626 [Mac] Unreviewed test fix after r182584
2627 https://bugs.webkit.org/show_bug.cgi?id=143452
2629 Put both of these tests back to their original state now that the underlying
2632 * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
2633 (TestWebKitAPI::TEST):
2634 * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
2635 (TestWebKitAPI::TEST):
2637 2015-04-08 Filip Pizlo <fpizlo@apple.com>
2639 run-jsc-benchmarks geomean of preferred means shouldn't print the VMs header twice
2640 https://bugs.webkit.org/show_bug.cgi?id=143553
2642 Reviewed by Ryosuke Niwa.
2644 Remove the spurious printVMs left over from an earlier change.
2646 * Scripts/run-jsc-benchmarks:
2648 2015-04-08 Brent Fulgham <bfulgham@apple.com>
2650 [Mac] Unreviewed test fix after r182581
2652 The behavior of control-left-click is controlled by a system preference.
2653 Our test bots have this turned off.
2655 * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
2656 (TestWebKitAPI::TEST):
2657 * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
2658 (TestWebKitAPI::TEST):
2660 2015-04-08 Brent Fulgham <bfulgham@apple.com>
2662 [Mac] WebKit is not honoring OS preferences for secondary click behaviors
2663 https://bugs.webkit.org/show_bug.cgi?id=143452
2664 <rdar://problem/20437483>
2666 Reviewed by Tim Horton.
2668 Add a new API test to confirm that Cocoa mouse button press events are properly
2669 tagged with the desired menu behavior (i.e., 'None', 'Context', or 'Action'.)
2671 The WK2 test dispatches mouse down events to a PlatformWebView, and checks with
2672 some registered event handlers that the expected button press and context menu
2673 events are received.
2675 The WK1 unit test creates an NSEvent with the desired button press state, and then
2676 uses WebCore::PlatformEventFactory::createPlatformMouseEvent to create a WebCore event.
2677 We check the resulting PlatformMouseEvent for proper state.
2679 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test files.
2680 * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp: Added.
2681 (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
2682 * TestWebKitAPI/Tests/WebKit2/mouse-button-listener.html: Added.
2683 * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm: Added.
2684 (TestWebKitAPI::canCallMenuTypeForEvent): Helper function.
2685 (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
2686 * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2687 (TestWebKitAPI::PlatformWebView::simulateButtonClick): Added method to support firing
2689 * TestWebKitAPI/mac/PlatformWebViewMac.h:
2691 2015-04-08 Michael Catanzaro <mcatanzaro@igalia.com>
2693 [GTK] Add pango to jhbuild-optional.modules
2694 https://bugs.webkit.org/show_bug.cgi?id=143537
2696 Reviewed by Martin Robinson.
2698 * gtk/jhbuild-optional.modules: Add pango.
2700 2015-04-08 Carlos Alberto Lopez Perez <clopez@igalia.com>
2702 [XvfbDriver] Regular expression used to match running X servers fails on Fedora 22.
2703 https://bugs.webkit.org/show_bug.cgi?id=143530
2705 Reviewed by Žan Doberšek.
2707 Assume that the default value for display (:0) is reserved and start checking on :1
2708 Adjust webkitpy test and include two new test cases for this bug (display number not specified)
2709 and for X server named Xorg.bin (previous bug 1376599)
2711 * Scripts/webkitpy/port/xvfbdriver.py:
2712 (XvfbDriver._next_free_display)
2713 * Scripts/webkitpy/port/xvfbdriver_unittest.py:
2714 (XvfbDriverTest.test_start_no_pixel_tests):
2715 (XvfbDriverTest.test_start_pixel_tests):
2716 (XvfbDriverTest.test_start_arbitrary_worker_number):
2717 (XvfbDriverTest.test_next_free_display):
2718 (XvfbDriverTest.test_start_next_worker):
2719 2015-04-08 Alex Christensen <achristensen@webkit.org>
2721 Block popups from content extensions.
2722 https://bugs.webkit.org/show_bug.cgi?id=143497
2724 Reviewed by Brady Eidson.
2726 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2727 (TestWebKitAPI::TEST_F):
2730 2015-04-08 Alex Christensen <achristensen@webkit.org> and Patrick Gansterer <paroga@webkit.org>
2732 Add CMake build system for WinCairo port.
2733 https://bugs.webkit.org/show_bug.cgi?id=115944
2735 Reviewed by Chris Dumez.
2738 * WinLauncher/CMakeLists.txt: Added.
2740 2015-04-08 Carlos Garcia Campos <cgarcia@igalia.com>
2742 [GTK] Crash in DOMObjectCache when a wrapped object owned by the cache is unreffed by the user
2743 https://bugs.webkit.org/show_bug.cgi?id=143521
2745 Reviewed by Martin Robinson.
2747 Add a way to detect unexpected web process crashes to WebViewTest,
2748 and a test case to testDOMCache to trigger the crash.
2750 * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
2751 (WebKitDOMNodeTest::testDOMCache):
2752 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
2753 (testWebKitWebViewProcessCrashed):
2754 * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2755 (WebViewTest::WebViewTest):
2756 (WebViewTest::webProcessCrashed):
2757 * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2759 2015-04-07 Alexey Proskuryakov <ap@apple.com>
2761 PageVisibilityStateWithWindowChanges should only be enabled on Yosemite
2762 rdar://problem/20461342
2764 * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2766 2015-04-07 Commit Queue <commit-queue@webkit.org>
2768 Unreviewed, rolling out r182511.
2769 https://bugs.webkit.org/show_bug.cgi?id=143507
2771 caused debug test failures (Requested by alexchristensen on
2776 "Block popups from content extensions."
2777 https://bugs.webkit.org/show_bug.cgi?id=143497
2778 http://trac.webkit.org/changeset/182511
2780 2015-04-07 Alex Christensen <achristensen@webkit.org>
2782 Block popups from content extensions.
2783 https://bugs.webkit.org/show_bug.cgi?id=143497
2785 Reviewed by Brady Eidson.
2787 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2788 (TestWebKitAPI::TEST_F):
2791 2015-04-07 Benjamin Poulain <benjamin@webkit.org>
2793 Get the features.json files ready for open contributions
2794 https://bugs.webkit.org/show_bug.cgi?id=143436
2796 Reviewed by Darin Adler.
2798 * Scripts/webkitpy/style/checkers/jsonchecker.py:
2799 (JSONFeaturesChecker.check):
2800 Extend the syntax checking a bit, but leave everything non-mandatory
2801 very loose until we figure what fields are important.
2803 2015-04-07 Tim Horton <timothy_horton@apple.com>
2805 Expose and test fixedLayoutSize via modern WebKit SPI
2806 https://bugs.webkit.org/show_bug.cgi?id=143500
2808 Reviewed by Simon Fraser.
2810 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2811 * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Added.
2812 (-[FixedLayoutSizeNavigationDelegate webView:didFinishNavigation:]):
2814 Add a test that verifies that fixedLayoutSize works at all, that
2815 it persists through a navigation, and that turning it back off reverts to
2816 laying out at the size of the view.
2818 2015-04-07 Michael Catanzaro <mcatanzaro@igalia.com>
2820 Unreviewed. Add myself as a committer.
2822 * Scripts/webkitpy/common/config/contributors.json:
2824 2015-04-07 Brent Fulgham <bfulgham@apple.com>
2826 [Win] Bots complain about missing /etc/catalog
2827 https://bugs.webkit.org/show_bug.cgi?id=143484
2829 Reviewed by Chris Dumez.
2831 The libxml2 build on Mac, iOS, and Windows does not provide the set
2832 of default catalog files. We do not actually need these for our
2833 purposes, but we get warnings and some bot flakiness because they
2836 We can avoid both problems the same way the Mac and iOS ports do,
2837 by setting the XML_CATALOG_FILES environment variable to 'empty string',
2838 which avoid the warnings and bot problems.
2840 * Scripts/webkitpy/port/win.py:
2841 (WinPort.setup_environ_for_server): Added.
2843 2015-04-06 Sam Weinig <sam@webkit.org>
2845 Use content extensions in MiniBrowser.
2846 https://bugs.webkit.org/show_bug.cgi?id=143446
2848 Reviewed by Alex Christensen.
2850 * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2851 * MiniBrowser/mac/AppDelegate.h:
2852 * MiniBrowser/mac/AppDelegate.m:
2853 (-[BrowserAppDelegate init]):
2854 (-[BrowserAppDelegate showExtensionsManager:]):
2855 (-[BrowserAppDelegate userContentContoller]):
2856 * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
2857 * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
2858 (-[ExtensionManagerWindowController init]):
2859 (-[ExtensionManagerWindowController windowDidLoad]):
2860 (-[ExtensionManagerWindowController add:]):
2861 (-[ExtensionManagerWindowController remove:]):
2862 * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
2863 * MiniBrowser/mac/MainMenu.xib:
2865 2015-04-07 Youenn Fablet <youenn.fablet@crf.canon.fr>
2867 web-platform-tests server should retrieve the modules file relatively to its docroot path
2868 https://bugs.webkit.org/show_bug.cgi?id=142742
2870 Reviewed by Darin Adler.
2872 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2873 (WebPlatformTestServer._install_modules): Compute the modules description file path according wpt server doc root path.
2875 2015-04-06 Commit Queue <commit-queue@webkit.org>
2877 Unreviewed, rolling out r182445.
2878 https://bugs.webkit.org/show_bug.cgi?id=143459
2880 broke 32 bit build (Requested by alexchristensen on #webkit).
2884 "Use content extensions in MiniBrowser."
2885 https://bugs.webkit.org/show_bug.cgi?id=143446
2886 http://trac.webkit.org/changeset/182445
2888 2015-04-06 Sam Weinig <sam@webkit.org>
2890 Use content extensions in MiniBrowser.
2891 https://bugs.webkit.org/show_bug.cgi?id=143446
2893 Reviewed by Alex Christensen.
2895 * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2896 * MiniBrowser/mac/AppDelegate.h:
2897 * MiniBrowser/mac/AppDelegate.m:
2898 (-[BrowserAppDelegate init]):
2899 (-[BrowserAppDelegate showExtensionsManager:]):
2900 (-[BrowserAppDelegate userContentContoller]):
2901 * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
2902 * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
2903 (-[ExtensionManagerWindowController init]):
2904 (-[ExtensionManagerWindowController windowDidLoad]):
2905 (-[ExtensionManagerWindowController add:]):
2906 (-[ExtensionManagerWindowController remove:]):
2907 * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
2908 * MiniBrowser/mac/MainMenu.xib:
2910 2015-04-06 Michael Catanzaro <mcatanzaro@gnome.org>
2912 [GTK] install-dependencies should prefer dnf to yum
2913 https://bugs.webkit.org/show_bug.cgi?id=143441
2915 Reviewed by Martin Robinson.
2917 Test for the existance of dnf before yum, and only try to use yum if dnf does not exist.
2919 * gtk/install-dependencies:
2921 2015-04-06 Andy Estes <aestes@apple.com>
2923 [iOS] 'make clean' fails in Tools/WebKitTestRunner
2924 https://bugs.webkit.org/show_bug.cgi?id=143455
2926 Reviewed by Dan Bernstein.
2928 This Makefile adds '-target WebKitTestRunnerApp' to OTHER_OPTIONS during iOS builds, but the top-level
2929 Makefile.shared adds '-alltargets' for clean builds, and xcodebuild does not allow both -target and -alltargets.
2931 * WebKitTestRunner/Makefile: Don't add '-target WebKitTestRunerApp' to OTHER_OPTIONS on clean builds.
2933 2015-04-06 Alexey Proskuryakov <ap@apple.com>
2935 WebKit1.SetAndUpdateCacheModelPreferencesChangeMix fails on some machines
2936 https://bugs.webkit.org/show_bug.cgi?id=143450
2938 Reviewed by Anders Carlsson.
2940 * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: (TestWebKitAPI::TEST):
2941 Make sure that the view is actually closed, regardless of anything else that happens beneath.
2942 Also, removed unnecessary get() calls.
2944 2015-04-03 Alexey Proskuryakov <ap@apple.com>
2946 Reduce the dependency on Flash in regression tests
2947 https://bugs.webkit.org/show_bug.cgi?id=143391
2949 Reviewed by Anders Carlsson.
2951 * WebKitTestRunner/TestController.cpp: (WTR::TestController::decidePolicyForPluginLoad):
2952 Only allow QuickTime and the test plug-in.
2954 2015-04-06 Youenn Fablet <youenn.fablet@crf.canon.fr>
2956 W3C test importer should generate the modules installed dynamically to run wpt tests
2957 https://bugs.webkit.org/show_bug.cgi?id=142738
2959 Reviewed by Ryosuke Niwa.
2961 The test importer can now generate the submodules description file based on information extracted from the corresponding git repository.
2962 The implementation is done within TestDownloader and it is activated for the WPT repository.
2963 LayoutTests/imported/w3c/resources/WPTModules is renamed as LayoutTests/imported/w3c/resources/web-platform-tests-modules.json for that reason.
2965 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2966 (WebPlatformTestServer._install_modules): Updated to cope with path as array.
2967 * Scripts/webkitpy/w3c/test_downloader.py:
2968 (TestDownloader._git_submodules_status): Added so that it can be overriden for unit tests.
2970 (TestDownloader._git_submodules_description): Computes submodule description.
2971 (TestDownloader.generate_git_submodules_description): Write submodule description in a file.
2972 * Scripts/webkitpy/w3c/test_importer.py:
2973 (TestImporter.do_import): Added the possibility to post process the tests.
2975 (TestImporter.generate_git_submodules_description_for_all_repositories): Enable generating module description file.
2976 (TestImporter.should_convert_test_harness_links): Updated according new options format.
2977 * Scripts/webkitpy/w3c/test_importer_unittest.py:
2978 (TestImporterTest.import_downloaded_tests): Making use of TestDownloaderMock.
2979 (TestImporterTest.import_downloaded_tests.TestDownloaderMock): Added to override submodule status gathering.
2980 (TestImporterTest.import_downloaded_tests.TestDownloaderMock.__init__):
2981 (TestImporterTest.import_downloaded_tests.TestDownloaderMock._git_submodules_status):
2982 (TestImporterTest.test_submodules_generation): Added to check that modules description files works.
2984 2015-04-05 Antti Koivisto <antti@apple.com>
2986 Bloom filter should support longer hashes
2987 https://bugs.webkit.org/show_bug.cgi?id=143419
2989 Reviewed by Dan Bernstein.
2991 * TestWebKitAPI/Tests/WTF/BloomFilter.cpp:
2992 (TestWebKitAPI::generateRandomDigests):
2993 (TestWebKitAPI::TEST):
2995 2015-04-03 Csaba Osztrogonác <ossy@webkit.org>
2997 run-jsc-stress-tests --remote should add libllvmForJSC.so to the bundle on Linux
2998 https://bugs.webkit.org/show_bug.cgi?id=143372
3000 Reviewed by Darin Adler.
3002 * Scripts/run-jsc-stress-tests:
3004 2015-04-03 Antti Koivisto <antti@apple.com>
3006 Add non-counting bloom filter class
3007 https://bugs.webkit.org/show_bug.cgi?id=143366
3009 Reviewed by Sam Weinig.
3011 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3012 * TestWebKitAPI/Tests/WTF/BloomFilter.cpp: Added.
3013 (TestWebKitAPI::generateRandomHashes):
3014 (TestWebKitAPI::TEST):
3016 2015-04-03 Csaba Osztrogonác <ossy@webkit.org>
3018 FTL JIT tests should fail if LLVM library isn't available
3019 https://bugs.webkit.org/show_bug.cgi?id=143374
3021 Reviewed by Mark Lam.
3023 * Scripts/run-jsc-stress-tests:
3025 2015-04-03 Csaba Osztrogonác <ossy@webkit.org>
3027 [EFL] Speedup jhbuild with disable running autogen.sh
3028 https://bugs.webkit.org/show_bug.cgi?id=143369
3030 Reviewed by Gyuyoung Kim.
3032 * efl/jhbuild.modules:
3034 2015-04-01 Alexey Proskuryakov <ap@apple.com>
3036 filter-webkit-build should filter out "created by an unsupported XCDependencyGraph build" lines
3037 https://bugs.webkit.org/show_bug.cgi?id=143282
3039 Reviewed by Daniel Bates.
3041 * Scripts/filter-build-webkit: (shouldIgnoreLine): Do it.
3043 2015-04-01 Alexey Proskuryakov <ap@apple.com>
3045 When LayoutTestHelper fails to start, we continue to run the tests, ending up with mysterious failures
3046 https://bugs.webkit.org/show_bug.cgi?id=143240
3047 rdar://problem/19990425
3049 Reviewed by Tim Horton.
3051 * DumpRenderTree/mac/LayoutTestHelper.m:
3052 (colorProfileURLForDisplay):
3053 (saveDisplayColorProfiles):
3054 Gracefully handle it when the current profile cannot be retrieved, fixing at
3055 least one case when LayoutTestHelper couldn't start.
3057 * Scripts/webkitpy/layout_tests/controllers/manager.py:
3058 (Manager._set_up_run):
3059 (Manager._force_pixel_tests_if_needed):
3060 * Scripts/webkitpy/port/base.py: (Port.to.start_helper):
3061 * Scripts/webkitpy/port/mac.py: (MacPort.start_helper):
3062 Return and check an error from start_helper().
3064 2015-04-01 Brent Fulgham <bfulgham@apple.com>
3066 [Win] Run test-webkitpy as part of EWS (just like we do on other platforms)
3067 https://bugs.webkit.org/show_bug.cgi?id=143321
3069 Reviewed by Alexey Proskuryakov.
3071 * EWSTools/start-queue-win.sh: Add commands to run 'test-webkitpy' during processing loop.
3073 2015-04-01 Enrica Casucci <enrica@apple.com>
3075 Injected bundle messages should be at the page level.
3076 https://bugs.webkit.org/show_bug.cgi?id=143283
3078 Reviewed by Alexey Proskuryakov.
3080 Updating WebKitTestRunner to use the new page level messaging.
3081 The author of this patch is Tim Horton, I just finished it.
3083 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3084 (WTR::EventSendingController::mouseDown):
3085 (WTR::EventSendingController::mouseUp):
3086 (WTR::EventSendingController::mouseMoveTo):
3087 (WTR::EventSendingController::leapForward):
3088 (WTR::EventSendingController::scheduleAsynchronousClick):
3089 (WTR::EventSendingController::keyDown):
3090 (WTR::EventSendingController::scheduleAsynchronousKeyDown):
3091 (WTR::EventSendingController::mouseScrollBy):
3092 (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
3093 (WTR::EventSendingController::continuousMouseScrollBy):
3094 (WTR::EventSendingController::addTouchPoint):
3095 (WTR::EventSendingController::updateTouchPoint):
3096 (WTR::EventSendingController::setTouchModifier):
3097 (WTR::EventSendingController::setTouchPointRadius):
3098 (WTR::EventSendingController::touchStart):
3099 (WTR::EventSendingController::touchMove):
3100 (WTR::EventSendingController::touchEnd):
3101 (WTR::EventSendingController::touchCancel):
3102 (WTR::EventSendingController::clearTouchPoints):
3103 (WTR::EventSendingController::releaseTouchPoint):
3104 (WTR::EventSendingController::cancelTouchPoint):
3105 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3106 (WTR::InjectedBundle::didReceiveMessage):
3107 (WTR::InjectedBundle::didReceiveMessageToPage):
3108 (WTR::InjectedBundle::done):
3109 (WTR::InjectedBundle::outputText):
3110 (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
3111 (WTR::InjectedBundle::postAddChromeInputField):
3112 (WTR::InjectedBundle::postRemoveChromeInputField):
3113 (WTR::InjectedBundle::postFocusWebView):
3114 (WTR::InjectedBundle::postSetBackingScaleFactor):
3115 (WTR::InjectedBundle::postSetWindowIsKey):
3116 (WTR::InjectedBundle::postSimulateWebNotificationClick):
3117 (WTR::InjectedBundle::postSetAddsVisitedLinks):
3118 (WTR::InjectedBundle::setGeolocationPermission):
3119 (WTR::InjectedBundle::setMockGeolocationPosition):
3120 (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
3121 (WTR::InjectedBundle::setUserMediaPermission):
3122 (WTR::InjectedBundle::setCustomPolicyDelegate):
3123 (WTR::InjectedBundle::setHidden):
3124 (WTR::InjectedBundle::setCacheModel):
3125 (WTR::InjectedBundle::shouldProcessWorkQueue):
3126 (WTR::InjectedBundle::processWorkQueue):
3127 (WTR::InjectedBundle::queueBackNavigation):
3128 (WTR::InjectedBundle::queueForwardNavigation):
3129 (WTR::InjectedBundle::queueLoad):
3130 (WTR::InjectedBundle::queueLoadHTMLString):
3131 (WTR::InjectedBundle::queueReload):
3132 (WTR::InjectedBundle::queueLoadingScript):
3133 (WTR::InjectedBundle::queueNonLoadingScript):
3134 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3135 (WTR::TestRunner::setHandlesAuthenticationChallenges):
3136 (WTR::TestRunner::setAuthenticationUsername):
3137 (WTR::TestRunner::setAuthenticationPassword):
3138 (WTR::TestRunner::secureEventInputIsEnabled):
3139 (WTR::TestRunner::setBlockAllPlugins):
3140 * WebKitTestRunner/TestController.cpp:
3141 (WTR::TestController::createWebViewWithOptions):
3142 (WTR::TestController::resetStateToConsistentValues):
3143 (WTR::TestController::didReceivePageMessageFromInjectedBundle):
3144 (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundle):
3145 * WebKitTestRunner/TestController.h:
3146 * WebKitTestRunner/TestInvocation.cpp:
3147 (WTR::TestInvocation::invoke):
3148 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3150 2015-04-01 Commit Queue <commit-queue@webkit.org>
3152 Unreviewed, rolling out r182174 and r182177.
3153 https://bugs.webkit.org/show_bug.cgi?id=143314
3155 Try to correct EWS failures (Requested by bfulgham on
3158 Reverted changesets:
3160 "Python SCM should be able to retrieve untracked files"
3161 https://bugs.webkit.org/show_bug.cgi?id=143135
3162 http://trac.webkit.org/changeset/182174
3164 "[buildbot] clean-build script should remove untracked files
3165 and revert local changes too"
3166 https://bugs.webkit.org/show_bug.cgi?id=142400
3167 http://trac.webkit.org/changeset/182177
3169 2015-04-01 Alex Christensen <achristensen@webkit.org>
3171 [Content Extensions] Properly handle regexes that match everything.
3172 https://bugs.webkit.org/show_bug.cgi?id=143281
3174 Reviewed by Benjamin Poulain.
3176 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3177 (TestWebKitAPI::testRequest):
3178 (TestWebKitAPI::makeBackend):
3179 (TestWebKitAPI::TEST_F):
3180 Removed duplicate code and added test.
3182 2015-03-31 Benjamin Poulain <bpoulain@apple.com>
3184 Content Extensions: split the state machines to minimize prefix states
3185 https://bugs.webkit.org/show_bug.cgi?id=143253
3187 Reviewed by Alex Christensen.
3189 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3190 (TestWebKitAPI::TEST_F):
3191 (TestWebKitAPI::testPatternStatus):
3193 2015-03-31 Yusuke Suzuki <utatane.tea@gmail.com>
3195 Clean up Identifier factories to clarify the meaning of StringImpl*
3196 https://bugs.webkit.org/show_bug.cgi?id=143146
3198 Reviewed by Filip Pizlo.
3200 Simple API tests for StringImpl are added.
3202 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3203 (TestWebKitAPI::TEST):
3205 2015-03-31 Csaba Osztrogonác <ossy@webkit.org>
3207 [EFL] Add AArch64 builder and tester bot to build.webkit.org
3208 https://bugs.webkit.org/show_bug.cgi?id=143092
3210 Reviewed by Gyuyoung Kim.
3212 * BuildSlaveSupport/build.webkit.org-config/config.json:
3213 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3215 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3217 2015-03-31 Youenn Fablet <youenn.fablet@crf.canon.fr>
3219 [buildbot] clean-build script should remove untracked files and revert local changes too
3220 https://bugs.webkit.org/show_bug.cgi?id=142400
3222 Reviewed by Ryosuke Niwa.
3224 This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
3225 A helper routine SCM.discard_untracked_files is added for that purpose.
3227 * BuildSlaveSupport/clean-build:
3228 (main): Making call to Scripts/clean-webkit
3229 * Scripts/clean-webkit: Added.
3230 (main): Revert changes and delete untracked files.
3231 * Scripts/webkitpy/common/checkout/scm/scm.py:
3232 (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
3233 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3234 (SCMTest._shared_test_discard_untracked_files):
3235 (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
3237 2015-03-31 Youenn Fablet <youenn.fablet@crf.canon.fr>
3239 Python SCM should be able to retrieve untracked files
3240 https://bugs.webkit.org/show_bug.cgi?id=143135
3242 Reviewed by Ryosuke Niwa.
3244 This patch introduces SCM.untracked_files to retrieve a list of untracked files.
3245 Ignored files may be included or not in this list according boolean passed to the function.
3247 * Scripts/webkitpy/common/checkout/scm/git.py:
3248 (Git.untracked_files):
3249 * Scripts/webkitpy/common/checkout/scm/scm.py:
3250 (SCM.untracked_files):
3251 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3252 (SCMTest._shared_test_untracked_files):
3253 (test_untracked_files):
3254 (GitSVNTest.test_untracked_files):
3255 * Scripts/webkitpy/common/checkout/scm/svn.py:
3256 (SVN.untracked_files):
3258 2015-03-30 Alex Christensen <achristensen@webkit.org>
3260 [Content Extensions] Correctly handle regular expressions matching everything
3261 https://bugs.webkit.org/show_bug.cgi?id=143235
3263 Reviewed by Benjamin Poulain.
3265 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3266 (TestWebKitAPI::checkCompilerError):
3267 (TestWebKitAPI::TEST_F):
3268 Test ContentExtensionErrors.
3270 2015-03-30 Alexey Proskuryakov <ap@apple.com>
3272 DumpRenderTree should set NSWindowDisplayWithRunLoopObserver
3273 https://bugs.webkit.org/show_bug.cgi?id=143241
3274 rdar://problem/20351297
3276 Reviewed by Mark Lam.
3278 * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
3280 2015-03-30 Gyuyoung Kim <gyuyoung.kim@samsung.com>
3282 [CMake][EFL] Remove redundant library link and include path
3283 https://bugs.webkit.org/show_bug.cgi?id=143221
3285 Reviewed by Csaba Osztrogonác.
3287 * ImageDiff/PlatformEfl.cmake: Remove unnecessary library link and include path.
3289 2015-03-30 Sam Weinig <sam@webkit.org>
3291 [Content Extensions] Flesh out the UserContentExtensionStore
3292 https://bugs.webkit.org/show_bug.cgi?id=143123
3294 Reviewed by Benjamin Poulain.
3296 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3297 * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm: Added.
3298 Add tests for _WKUserContentExtensionStore.
3300 2015-03-30 Marcos Chavarría Teijeiro <chavarria1991@gmail.com>
3302 Update install-dependencies Fedora packages after r181624
3303 https://bugs.webkit.org/show_bug.cgi?id=143215
3305 Add json-glib, libv4l, openssl and pulseaudio development packages to
3306 the Fedora list providing we need them to build WebKit dependencies
3307 for this distribution.
3309 Reviewed by Philippe Normand.
3311 * gtk/install-dependencies:
3313 2015-03-30 Commit Queue <commit-queue@webkit.org>
3315 Unreviewed, rolling out r182119.
3316 https://bugs.webkit.org/show_bug.cgi?id=143196
3318 problem with syntax (Requested by youenn on #webkit).
3322 "[buildbot] clean-build script should remove untracked files
3323 and revert local changes too"
3324 https://bugs.webkit.org/show_bug.cgi?id=142400
3325 http://trac.webkit.org/changeset/182119
3327 2015-03-30 Benjamin Poulain <benjamin@webkit.org>
3329 Start the features.json files
3330 https://bugs.webkit.org/show_bug.cgi?id=143207
3332 Reviewed by Darin Adler.
3334 I kept the style checking light. We'll have to figure
3335 what is the best format for each field.
3337 * Scripts/webkitpy/style/checker.py:
3338 (CheckerDispatcher._create_checker):
3339 * Scripts/webkitpy/style/checkers/jsonchecker.py:
3340 (JSONContributorsChecker.check):
3341 (JSONFeaturesChecker):
3342 (JSONFeaturesChecker.check):
3344 2015-03-29 Youenn Fablet <youenn.fablet@crf.canon.fr>
3346 [buildbot] clean-build script should remove untracked files and revert local changes too
3347 https://bugs.webkit.org/show_bug.cgi?id=142400
3349 Reviewed by Ryosuke Niwa.
3351 This patch cleans the WebKit folder by deleting SCM untracked files and reverting changes for tracked files.
3353 * BuildSlaveSupport/clean-build:
3354 (main): Adding call to Tools/Scripts/clean-webkit.
3355 * Scripts/clean-webkit: Added.
3356 (main): Removes untracked and changed files.
3357 * Scripts/webkitpy/common/checkout/scm/git.py:
3358 (Git.untracked_files): Retrieves GIT untracked files.
3359 * Scripts/webkitpy/common/checkout/scm/scm.py:
3360 (SCM.untracked_files): Retrieves SVN untracked files.
3362 (SCM.discard_untracked_files): Deletes untracked files/folders.
3363 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3364 (SCMTest._shared_test_untracked_files): Unit testing for untracked files.
3365 (test_untracked_files):
3366 (GitSVNTest.test_untracked_files):
3367 * Scripts/webkitpy/common/checkout/scm/svn.py:
3368 (SVN.untracked_files):
3370 2015-03-27 Gyuyoung Kim <gyuyoung.kim@samsung.com>
3372 [CMake] Remove unnecessary INCLUDE_IF_EXISTS macro
3373 https://bugs.webkit.org/show_bug.cgi?id=143138
3375 Reviewed by Csaba Osztrogonác.
3377 INCLUDE_IF_EXISTS isn't used except for 2 places. However those uses can
3378 be replaced with WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS.
3380 * ImageDiff/CMakeLists.txt:
3381 Use WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS() instead of INCLUDE_IF_EXISTS.
3382 * WebKitTestRunner/CMakeLists.txt: ditto.
3384 2015-03-27 Myles C. Maxfield <mmaxfield@apple.com>
3386 Support building WTF on Windows without Cygwin
3387 https://bugs.webkit.org/show_bug.cgi?id=143084
3389 Reviewed by Brent Fulgham.
3391 Windows without Cygwin doesn't have curl, unzip, or grep. Luckily, Perl does all of these things.
3392 This patch also migrates to using File::Spec->catfile() for directory separators.
3394 * Scripts/update-webkit-dependency:
3396 * Scripts/update-webkit-support-libs:
3398 (downloadExpectedVersionNumber):
3400 (toUnixPath): Deleted.
3401 * Scripts/webkitdirs.pm:
3402 (determineSourceDir):
3403 (windowsSourceSourceDir):
3404 (windowsLibrariesDir):
3406 (checkInstalledTools):
3407 (buildVisualStudioProject):
3409 2015-03-27 Alex Christensen <achristensen@webkit.org>
3412 https://bugs.webkit.org/show_bug.cgi?id=143086
3414 Reviewed by Brent Fulgham.
3416 * Scripts/webkitdirs.pm:
3417 (buildVisualStudioProject):
3418 (runSvnUpdateAndResolveChangeLogs):
3419 Use ActivePerl-friendly perl.
3421 2015-03-27 Csaba Osztrogonác <ossy@webkit.org>
3423 URTBF after r182059 to fix the EFL build.
3425 * TestWebKitAPI/CMakeLists.txt:
3427 2015-03-26 Alexey Proskuryakov <ap@apple.com>
3429 Layout test results URL loads in WK1 but not WK2 minibrowser
3430 https://bugs.webkit.org/show_bug.cgi?id=143117
3432 Reviewed by Tim Horton.
3434 * MiniBrowser/mac/WK2BrowserWindowController.m:
3435 (-[WK2BrowserWindowController fetch:]): Fix this, international domain names, and
3437 (-[WK2BrowserWindowController updateTextFieldFromURL:]): Ditto.
3439 2015-03-26 Jer Noble <jer.noble@apple.com>
3441 Add --allowed-host support to run-webkit-tests
3442 https://bugs.webkit.org/show_bug.cgi?id=142938
3444 Reviewed by Brent Fulgham.
3446 Accept --allowed-host arguments from run-webkit-tests and pass them through to
3447 DumpRenderTree and WebKitTestRunner.
3449 Drive-by fix: Depending on the value of the --layout-test-dir parameter, layout test results
3450 are placed in the wrong location. The argument is compared with each tests's path, and if a
3451 relative path or a path with '..' was used, results are placed alongside the test. Take the
3452 absolute path of the --layout-test-dir argument, collapsing path components like '..'.
3454 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3456 * Scripts/webkitpy/port/base.py:
3458 (Port.allowed_hosts):
3459 * Scripts/webkitpy/port/driver.py:
3462 2015-03-26 Jer Noble <jer.noble@apple.com>
3464 [Mac] Add an --allowed-host argument to DRT and WKTR to allow tests to connect to non-localhost servers
3465 https://bugs.webkit.org/show_bug.cgi?id=142931
3467 Reviewed by Brent Fulgham.
3469 Currently, both DRT and WKTR will refuse to allow network connections to non-localhost servers
3470 over HTTP/HTTPS. For certain testing scenarios, however, it would be useful if both DRT and
3471 WKTR could be allowed to make HTTP/HTTPS connections to certain, specific servers defined at
3474 To allow this, add an optional argument to DRT and WKTR, --allowed-host, which will add the specified
3475 hostname to a whitelist; requests to these hosts will allowed to proceed normally.
3477 Drive-by fix: in InjectedBundlePage::willSendRequestForFrame, we get the top loading frame from the
3478 injected bundle. But after the main resource load completes, the bundle nulls out it's pointer to the
3479 top loading frame, which causes a subsequent crash when further resources are requested. Instead, get
3480 the top loading frame from the page, as we do elsewhere in this class.
3482 * DumpRenderTree/TestRunner.h:
3483 (TestRunner::allowedHosts):
3484 (TestRunner::setAllowedHosts):
3485 * DumpRenderTree/mac/DumpRenderTree.mm:
3486 (initializeGlobalsFromCommandLineOptions):
3488 * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3490 (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3491 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3492 (WTR::InjectedBundle::didReceiveMessage):
3493 (WTR::InjectedBundle::isAllowedHost):
3494 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3495 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3496 (WTR::isAllowedHost):
3497 (WTR::InjectedBundlePage::willSendRequestForFrame):
3498 * WebKitTestRunner/InjectedBundle/TestRunner.h:
3499 * WebKitTestRunner/Options.cpp:
3500 (WTR::handleOptionAllowedHost):
3501 (WTR::OptionsHandler::OptionsHandler):
3502 * WebKitTestRunner/Options.h:
3503 * WebKitTestRunner/TestController.cpp:
3504 (WTR::TestController::initialize):
3505 (WTR::TestController::resetStateToConsistentValues):
3506 * WebKitTestRunner/TestController.h:
3508 2015-03-26 Brady Eidson <beidson@apple.com>
3510 Apply ContentExtension actions after redirects.
3511 <rdar://problem/20062613> and https://bugs.webkit.org/show_bug.cgi?id=143055
3513 Reviewed by Alex Christensen.
3515 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3516 (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Dump the fact that the load error is kWKErrorCodeCannotShowURL
3517 which is specifically interesting to a new test.
3519 2015-03-26 Csaba Osztrogonác <ossy@webkit.org>
3521 [EFL] Disable building libseccomp on AArch64
3522 https://bugs.webkit.org/show_bug.cgi?id=143094
3524 Reviewed by Gyuyoung Kim.
3528 2015-03-26 Csaba Osztrogonác <ossy@webkit.org>
3530 [jhbuild] git should use only 1 thread for cloning jhbuild
3531 https://bugs.webkit.org/show_bug.cgi?id=143095
3533 Reviewed by Gyuyoung Kim.
3535 * jhbuild/jhbuild-wrapper:
3538 2015-03-25 Joseph Pecoraro <pecoraro@apple.com>
3540 Update prepare-ChangeLog to work with ES6 Class syntax
3541 https://bugs.webkit.org/show_bug.cgi?id=143069
3543 Reviewed by Timothy Hatcher.
3545 * Scripts/prepare-ChangeLog:
3546 (get_function_line_ranges_for_javascript):
3547 Better handle ES6 Class syntax.
3549 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
3550 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
3553 (DerivedClass.staticMethod):
3554 (DerivedClass.prototype.method.nestedFunctionInsideMethod):
3555 (DerivedClass.prototype.method):
3556 (DerivedClass.prototype.get getter):
3557 (namespace.MyClass):
3558 (namespace.MyClass.staticMethod):
3559 (namespace.MyClass.prototype.method.nestedFunctionInsideMethod):
3560 (namespace.MyClass.prototype.method):
3561 (namespace.MyClass.prototype.get getter):
3564 2015-03-25 Filip Pizlo <fpizlo@apple.com>
3566 Use JITCompilationCanFail in more places, and make the fail path of JITCompilationMustSucceed a crash instead of attempting GC
3567 https://bugs.webkit.org/show_bug.cgi?id=142993
3569 Reviewed by Mark Lam.
3571 Bunch of support for testing executable allocation failure.
3573 * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz: Added.
3575 * Scripts/run-javascriptcore-tests:
3576 (runJSCStressTests):
3577 * Scripts/run-jsc-stress-tests:
3579 2015-03-25 Myles C. Maxfield <mmaxfield@apple.com>
3581 Fix Windows build from r181977.
3585 * Scripts/update-webkit-dependency:
3587 2015-03-25 Sam Weinig <sam@webkit.org>
3589 Address additional review feedback from https://bugs.webkit.org/show_bug.cgi?id=143059.
3591 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3592 (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
3594 2015-03-25 Myles C. Maxfield <mmaxfield@apple.com>
3596 Migrate update-webkit for Windows to not require Cygwin
3597 https://bugs.webkit.org/show_bug.cgi?id=143040
3599 Reviewed by Brent Fulgham.
3601 * Scripts/update-webkit-dependency:
3603 (toUnixPath): Deleted.
3604 * Scripts/webkitdirs.pm:
3606 (checkInstalledTools):
3609 2015-03-25 Sam Weinig <sam@webkit.org>
3611 [Content Extensions] Convert content extension compiling to return error codes and write its output using a client
3612 https://bugs.webkit.org/show_bug.cgi?id=143059
3614 Reviewed by Alex Christensen.
3616 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3617 (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
3618 Update for new interface of compileRuleList().
3620 2015-03-25 Alex Christensen <achristensen@webkit.org>
3622 [Content Extensions] Add multi-DFA compiling and interpreting.
3623 https://bugs.webkit.org/show_bug.cgi?id=143010
3625 Reviewed by Benjamin Poulain.
3627 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3628 (TestWebKitAPI::testRequest):
3629 (TestWebKitAPI::TEST_F):
3630 Add some tests for ignore-previous-rules and large rulesets.
3632 2015-03-25 Alexey Proskuryakov <ap@apple.com>
3634 Mavericks WK1 still runs JSC tests
3635 https://bugs.webkit.org/show_bug.cgi?id=143035
3637 Reviewed by Csaba Osztrogonác.
3639 * BuildSlaveSupport/build.webkit.org-config/config.json: Bring Mavericks WK1 in line
3642 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated the tests
3645 2015-03-25 Commit Queue <commit-queue@webkit.org>
3647 Unreviewed, rolling out r181932.
3648 https://bugs.webkit.org/show_bug.cgi?id=143041
3650 The test fails most of the time on bots (Requested by ap on
3655 "[Content Extensions] Add multi-DFA compiling and
3657 https://bugs.webkit.org/show_bug.cgi?id=143010
3658 http://trac.webkit.org/changeset/181932
3660 2015-03-24 Alex Christensen <achristensen@webkit.org>
3662 [Content Extensions] Add multi-DFA compiling and interpreting.
3663 https://bugs.webkit.org/show_bug.cgi?id=143010
3665 Reviewed by Benjamin Poulain.