[ews-build] Get master_hostname dynamically in master.cfg
[WebKit-https.git] / Tools / ChangeLog
1 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2
3         [ews-build] Get master_hostname dynamically in master.cfg
4         https://bugs.webkit.org/show_bug.cgi?id=196255
5
6         Reviewed by Lucas Forschler.
7
8         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
9         send events data in test mode.
10
11 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
12
13         [ews-app] Set db_constraint to False for Foreign Keys
14         https://bugs.webkit.org/show_bug.cgi?id=196252
15
16         Reviewed by Lucas Forschler.
17
18         * BuildSlaveSupport/ews-app/ews/models/build.py:
19         * BuildSlaveSupport/ews-app/ews/models/step.py:
20
21 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
22
23         [ews-build] is_test_mode_enabled should default to True
24         https://bugs.webkit.org/show_bug.cgi?id=196248
25
26         Reviewed by Lucas Forschler.
27
28         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
29
30 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
31
32         [ews-app] Add webkitperl to ENABLED_QUEUES
33         https://bugs.webkit.org/show_bug.cgi?id=196253
34
35         Reviewed by Lucas Forschler.
36
37         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
38
39 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
40
41         Address NSWindow sometimes using WebKitTestRunnerEvent too early
42         https://bugs.webkit.org/show_bug.cgi?id=196211
43         rdar://problem/49110552
44
45         Reviewed by Tim Horton.
46
47         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
48         Make sure that EventSenderProxy always exists when running tests. We used to create
49         it when resetting before the first test, which is a bit too late.
50
51         * WebKitTestRunner/TestController.h:
52         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
53         (WTR::TestController::platformCreateWebView):
54         (WTR::TestController::platformCreateOtherPage):
55         (WTR::TestController::finishCreatingPlatformWebView):
56         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
57         (WTR::PlatformWebView::PlatformWebView):
58         Moved some code that made NSWindow use NSEvent during web view creation. We may
59         need to move more if some other case us found, but this is enough for now.
60
61 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
62
63         Unreviewed. Fix typo in GLib geolocation API after r243285.
64
65         gelocation -> geolocation.
66
67         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
68         (testGeolocationManagerWatchPosition):
69
70 2019-03-25  Alex Christensen  <achristensen@webkit.org>
71
72         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
73         https://bugs.webkit.org/show_bug.cgi?id=196213
74
75         Reviewed by Geoff Garen.
76
77         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
78         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
79         (credentialWithIdentityAndKeychainPath):
80         (-[ChallengeDelegate webView:didFinishNavigation:]):
81         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
82         (TestWebKitAPI::TEST):
83
84 2019-03-25  Alex Christensen  <achristensen@webkit.org>
85
86         Expected shouldn't assume its contained types are copyable
87         https://bugs.webkit.org/show_bug.cgi?id=195986
88
89         Reviewed by JF Bastien.
90
91         * TestWebKitAPI/Tests/WTF/Expected.cpp:
92         (TestWebKitAPI::NonCopyable::operator== const):
93         (TestWebKitAPI::NonCopyable::operator!= const):
94         (TestWebKitAPI::TEST):
95
96 2019-03-25  Tim Horton  <timothy_horton@apple.com>
97
98         Remove some now-unnecessary dynamic class lookup
99         https://bugs.webkit.org/show_bug.cgi?id=196237
100
101         Reviewed by Simon Fraser.
102
103         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
104         (makeRequest):
105         (TEST):
106
107 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
108
109         Unreviewed, rolling out r243450.
110
111         AppleWin and WinCairo port builds get broken.
112
113         Reverted changeset:
114
115         "Add test for fix of #196095"
116         https://bugs.webkit.org/show_bug.cgi?id=196097
117         https://trac.webkit.org/changeset/243450
118
119 2019-03-25  Commit Queue  <commit-queue@webkit.org>
120
121         Unreviewed, rolling out r243465.
122         https://bugs.webkit.org/show_bug.cgi?id=196226
123
124         the test doesn't build (Requested by thorton on #webkit).
125
126         Reverted changeset:
127
128         "Do not terminate the NetworkProcess if a third party
129         application sends a NSCredential with a SecIdentityRef"
130         https://bugs.webkit.org/show_bug.cgi?id=196213
131         https://trac.webkit.org/changeset/243465
132
133 2019-03-25  Alex Christensen  <achristensen@webkit.org>
134
135         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
136         https://bugs.webkit.org/show_bug.cgi?id=196213
137
138         Reviewed by Geoff Garen.
139
140         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
141         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
142         (credentialWithIdentityAndKeychainPath):
143         (-[ChallengeDelegate webView:didFinishNavigation:]):
144         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
145         (TestWebKitAPI::TEST):
146
147 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
148
149         [ews-build] Gracefully handle missing patch_id in events
150         https://bugs.webkit.org/show_bug.cgi?id=196216
151
152         Reviewed by Lucas Forschler.
153
154         * BuildSlaveSupport/ews-build/events.py:
155
156 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
157
158         [ews-build] use lz4 compression for improving buildbot performance
159         https://bugs.webkit.org/show_bug.cgi?id=196155
160
161         Reviewed by Lucas Forschler.
162
163         * BuildSlaveSupport/ews-build/master.cfg:
164
165 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
166
167         Pull some API testing helper methods out of TestWKWebView
168         https://bugs.webkit.org/show_bug.cgi?id=196212
169
170         Reviewed by Tim Horton.
171
172         Refactor some more API testing utility methods, so that they can be used in
173         tests that do not use TestWKWebView.
174
175         * TestWebKitAPI/cocoa/TestWKWebView.h:
176         * TestWebKitAPI/cocoa/TestWKWebView.mm:
177         (-[WKWebView loadTestPageNamed:]):
178         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
179         (-[WKWebView synchronouslyLoadHTMLString:]):
180         (-[WKWebView synchronouslyLoadTestPageNamed:]):
181         (-[TestWKWebView loadTestPageNamed:]): Deleted.
182         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
183         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
184         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
185
186 2019-03-25  Jer Noble  <jer.noble@apple.com>
187
188         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
189         https://bugs.webkit.org/show_bug.cgi?id=196097
190
191         Reviewed by Eric Carlson.
192
193         Drive-by bug fix: allow tests to play audio without a user gesture by default.
194
195         * DumpRenderTree/mac/DumpRenderTree.mm:
196         (resetWebPreferencesToConsistentValues):
197         * WebKitTestRunner/TestController.cpp:
198         (WTR::TestController::resetPreferencesToConsistentValues):
199
200 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
201
202         Pull IPadUserInterfaceSwizzler out into a separate header file
203         https://bugs.webkit.org/show_bug.cgi?id=196193
204
205         Reviewed by Anders Carlsson.
206
207         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
208         be used in other API tests.
209
210         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
211         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
212         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
213         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
214         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
215         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
216         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
217
218 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
219
220         Remove NavigatorContentUtils in WebCore/Modules
221         https://bugs.webkit.org/show_bug.cgi?id=196070
222
223         Reviewed by Alex Christensen.
224
225         NavigatorContentUtils was to support the custom scheme spec [1].
226         However, in WebKit side, no port has supported the feature in
227         WebKit layer after EFL port was removed. So there has been the
228         only IDL implementation of the NavigatorContentUtils in WebCore.
229         So we don't need to keep the implementation in WebCore anymore.
230
231         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
232
233         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
234
235 2019-03-24  Andy Estes  <aestes@apple.com>
236
237         [watchOS] Remove unused Proximity Networking code
238         https://bugs.webkit.org/show_bug.cgi?id=196188
239
240         Reviewed by Tim Horton.
241
242         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
243         (TEST):
244
245 2019-03-23  Keith Miller  <keith_miller@apple.com>
246
247         Refactor clz/ctz and fix getLSBSet.
248         https://bugs.webkit.org/show_bug.cgi?id=196162
249
250         Reviewed by Saam Barati.
251
252         Add tests for clz, ctz, getLSBSet, and getMSBSet.
253
254         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
255         (TestWebKitAPI::TEST):
256
257 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
258
259         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
260         https://bugs.webkit.org/show_bug.cgi?id=196143
261
262         Reviewed by Michael Catanzaro.
263
264         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
265         directories.
266
267         * Scripts/webkitpy/style/checkers/cpp.py:
268         (check_identifier_name_in_declaration):
269         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
270         (WebKitStyleTest.test_names):
271
272 2019-03-22  Philippe Normand  <pnormand@igalia.com>
273
274         [Flatpak] Manifest expanding fails for qt WPE extension
275         https://bugs.webkit.org/show_bug.cgi?id=196148
276
277         Reviewed by Alex Christensen.
278
279         * flatpak/flatpakutils.py:
280         (expand_submodules_recurse): The last recurse manifest expand
281         iteration might lead to a single module so take it into account
282         and don't try to recurse further.
283
284 2019-03-22  Chris Dumez  <cdumez@apple.com>
285
286         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
287         https://bugs.webkit.org/show_bug.cgi?id=195348
288         <rdar://problem/48622090>
289
290         Reviewed by Alex Christensen.
291
292         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
293         to NO when test.options().shouldIgnoreMetaViewport is false.
294
295         * WebKitTestRunner/ios/TestControllerIOS.mm:
296         (WTR::TestController::platformConfigureViewForTest):
297
298 2019-03-22  Chris Dumez  <cdumez@apple.com>
299
300         Prewarmed processes should be usable with any website data store
301         https://bugs.webkit.org/show_bug.cgi?id=196104
302
303         Reviewed by Alex Christensen.
304
305         Add API test coverage.
306
307         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
308         (runInitialWarmedProcessUsedTest):
309         (TEST):
310
311 2019-03-22  David Kilzer  <ddkilzer@apple.com>
312
313         Back out local changes to Alex's Subversion working directory
314
315         They were accidentally committed.
316
317         * Scripts/webkitpy/common/system/abstractexecutive.py:
318         (AbstractExecutive.wait_newest):
319         * Scripts/webkitpy/common/system/executive.py:
320         (Executive.running_pids):
321         * Scripts/webkitpy/common/system/executive_mock.py:
322         (MockExecutive.running_pids):
323         * Scripts/webkitpy/common/system/executive_unittest.py:
324         (ExecutiveTest.serial_test_running_pids):
325         * Scripts/webkitpy/port/darwin.py:
326         (DarwinPort.check_for_leaks):
327         * Scripts/webkitpy/port/leakdetector.py:
328         (LeakDetector.check_for_leaks):
329         - This was the hack attached to Bug 193772.
330
331         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
332         (+[WebKitTestRunnerEvent mouseLocation]):
333         - This works around a crash on an internal build.
334
335 2019-03-22  Tim Horton  <timothy_horton@apple.com>
336
337         Fix the build after r243354
338         https://bugs.webkit.org/show_bug.cgi?id=196138
339         <rdar://problem/49145951>
340
341         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
342         (TEST):
343         * TestWebKitAPI/ios/UIKitSPI.h:
344
345 2019-03-21  Tim Horton  <timothy_horton@apple.com>
346
347         Adopt UIWKDocumentContext
348         https://bugs.webkit.org/show_bug.cgi?id=196040
349         <rdar://problem/48642440>
350
351         Reviewed by Ryosuke Niwa.
352
353         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
354         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
355         (makeRequest):
356         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
357         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
358         (applyStyle):
359         (TEST):
360         Add tests for UIWKDocumentContext.
361
362         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
363         (TEST):
364         (recursiveFindWKContentView): Deleted.
365         * TestWebKitAPI/cocoa/TestWKWebView.h:
366         * TestWebKitAPI/cocoa/TestWKWebView.mm:
367         (recursiveFindWKContentView):
368         (-[TestWKWebView wkContentView]):
369         * TestWebKitAPI/ios/UIKitSPI.h:
370         Share the WKContentView finding code between tests.
371
372 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
373
374         [iOS WK2] Turn on async overflow scrolling by default
375         https://bugs.webkit.org/show_bug.cgi?id=196011
376         rdar://problem/48453859
377
378         Reviewed by Antti Koivisto.
379         
380         Explicitly turn off the async overflow scrolling internal feature for tests by default,
381         since so many basic layout tests have different results when compositing is triggered for
382         overflow.
383         
384         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
385
386         * WebKitTestRunner/TestController.cpp:
387         (WTR::TestController::resetPreferencesToConsistentValues):
388
389 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
390
391         [ews-build] Retry API test in case of failures
392         https://bugs.webkit.org/show_bug.cgi?id=196004
393
394         Reviewed by Lucas Forschler.
395
396         * BuildSlaveSupport/ews-build/steps.py:
397         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
398         (CompileWebKitToT.doStepIf): Ditto.
399         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
400         (ReRunAPITests): Re-run API tests.
401         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
402         (RunAPITestsWithoutPatch): Run API tests without patch.
403         (RunAPITestsWithoutPatch.doStepIf):
404         (RunAPITestsWithoutPatch.hideStepIf):
405         (RunAPITestsWithoutPatch.evaluateCommand):
406         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
407         (AnalyzeAPITestsResults.start):
408         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
409         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
410         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
411         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
412
413 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
414
415         [ews-build] Update queues configurations
416         https://bugs.webkit.org/show_bug.cgi?id=196074
417
418         Reviewed by Dewei Zhu.
419
420         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
421         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
422
423 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
424
425         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
426         https://bugs.webkit.org/show_bug.cgi?id=195680
427         <rdar://problem/48903534>
428
429         Unreviewed infrastructure fix.
430
431         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
432         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
433
434 2019-03-21  Andy Estes  <aestes@apple.com>
435
436         [iOS] Apple Pay should be available in documents with no user agent scripts
437         https://bugs.webkit.org/show_bug.cgi?id=196061
438         <rdar://problem/48649391>
439
440         Reviewed by Brady Eidson.
441
442         Added API tests and related infrastructure.
443
444         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
445         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
446         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
447         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
448         (TestWebKitAPI::TEST):
449         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
450         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
451         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
452         * TestWebKitAPI/cocoa/TestProtocol.mm:
453         (-[TestProtocol startLoading]):
454         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
455         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
456         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
457         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
458
459 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
460
461         REGRESSSION (r243297): webkitpy tests broken
462         https://bugs.webkit.org/show_bug.cgi?id=196108
463
464         Reviewed by Aakash Jain.
465
466         r243297 updated contributors.json, which broke a few unit tests.
467
468         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
469         (IRCCommandTest.test_whois):
470         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
471
472 2019-03-21  Chris Dumez  <cdumez@apple.com>
473
474         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
475         https://bugs.webkit.org/show_bug.cgi?id=196041
476         <rdar://problem/49083230>
477
478         Reviewed by Alex Christensen.
479
480         Add API test coverage.
481
482         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
483         (TEST):
484
485 2019-03-21  Alex Christensen  <achristensen@webkit.org>
486
487         Add SPI to inform applications of WKContentRuleList actions
488         https://bugs.webkit.org/show_bug.cgi?id=195965
489         <rdar://problem/42664365>
490
491         Reviewed by Geoff Garen.
492
493         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
494         (TestWebKitAPI::allActionsForResourceLoad):
495         (TestWebKitAPI::testRequest):
496         (TestWebKitAPI::TEST_F):
497         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
498         (Notification::description):
499         (Notification::operator== const):
500         (toVector):
501         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
502         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
503         (makeContentRuleList):
504         (TEST):
505         (makeWarnContentRuleList): Deleted.
506
507 2019-03-21  Timothy Hatcher  <timothy@apple.com>
508
509         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
510         https://bugs.webkit.org/show_bug.cgi?id=196088
511
512         Reviewed by Brian Burg.
513
514         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
515         Support checks when only one platform is specified. Also deprecate macosx() and
516         force the use of macos() instead.
517
518         * Scripts/webkitpy/style/checkers/cpp.py:
519         (check_min_versions_of_wk_api_available):
520         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
521         (WebKitStyleTest.test_min_versions_of_wk_api_available):
522
523 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
524
525         Update status inactive committers' status to 'contributor'.
526
527         * Scripts/webkitpy/common/config/contributors.json:
528
529 2019-03-21  Xan Lopez  <xan@igalia.com>
530
531         [JSC][x86] Drop support for x87 floating point
532         https://bugs.webkit.org/show_bug.cgi?id=194853
533
534         Reviewed by Don Olmstead.
535
536         Force SSE2 on x86/32bit builds.
537
538         * Scripts/webkitdirs.pm:
539         (generateBuildSystemFromCMakeProject):
540
541 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
542
543         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
544         https://bugs.webkit.org/show_bug.cgi?id=196073
545
546         Reviewed by Michael Catanzaro.
547
548         Add test cases to check functions and constructors with no arguments but receiving user data.
549
550         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
551         (checkUserData):
552         (testJSCFunction):
553         (fooCreateWithUserData):
554         (testJSCClass):
555
556 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
557
558         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
559
560         Add g_assert_cmpfloat_with_epsilon macro if not defined.
561
562         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
563
564 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
565
566         [GTK][WPE] Add API to provide geolocation information
567         https://bugs.webkit.org/show_bug.cgi?id=195940
568
569         Reviewed by Michael Catanzaro.
570
571         Add a new test to check the new API.
572
573         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
574         (testGeolocationManagerCurrentPosition):
575         (testGeolocationManagerWatchPosition):
576         (beforeAll):
577         (afterAll):
578         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
579         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
580         (beforeAll): Ditto.
581         * TestWebKitAPI/glib/CMakeLists.txt:
582
583 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
584
585         [GLib] Returning G_TYPE_OBJECT from a method does not work
586         https://bugs.webkit.org/show_bug.cgi?id=195574
587
588         Reviewed by Michael Catanzaro.
589
590         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
591
592         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
593         (getGFile):
594         (getParent):
595         (createGString):
596         (getGString):
597         (getGStringCopyWillRaise):
598         (getGStringCopy):
599         (getGStringStr):
600         (getGStringLen):
601         (freeGString):
602         (testJSCClass):
603
604 2019-03-20  Saam Barati  <sbarati@apple.com>
605
606         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
607         https://bugs.webkit.org/show_bug.cgi?id=195721
608
609         Reviewed by Filip Pizlo.
610
611         * Scripts/run-javascriptcore-tests:
612
613 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
614
615         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
616         https://bugs.webkit.org/show_bug.cgi?id=196049
617
618         Reviewed by Tim Horton.
619
620         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
621         overflow scrolling in general, so rename it.
622
623         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
624
625 2019-03-20  Daniel Bates  <dabates@apple.com>
626
627         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
628         https://bugs.webkit.org/show_bug.cgi?id=196031
629         <rdar://problem/49078172>
630
631         Reviewed by Tim Horton.
632
633         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
634         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
635         same code path used when the Done button is pressed to dismiss the <select> picker.
636
637         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
638         (TestWebKitAPI::TEST):
639
640 2019-03-20  Chris Dumez  <cdumez@apple.com>
641
642         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
643         https://bugs.webkit.org/show_bug.cgi?id=196029
644         <rdar://problem/48954651>
645
646         Reviewed by Tim Horton.
647
648         Add API test coverage.
649
650         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
651
652 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
653
654         [ews-build] Improve failure summary string for ApplyPatch step
655         https://bugs.webkit.org/show_bug.cgi?id=195995
656
657         Reviewed by Alexey Proskuryakov.
658
659         * BuildSlaveSupport/ews-build/steps.py:
660         (ApplyPatch.getResultSummary): Override getResultSummary.
661
662 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
663
664         AX: Implement support for new meter ARIA role
665         https://bugs.webkit.org/show_bug.cgi?id=195966
666
667         Reviewed by Chris Fleizach.
668
669         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
670         to AXLevelIndicator.
671
672         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
673
674 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
675
676         [WebAuthN] Implement FIDO AppID extension
677         https://bugs.webkit.org/show_bug.cgi?id=143491
678         <rdar://problem/48298273>
679
680         Reviewed by Brent Fulgham.
681
682         Add a test that covers the new flag of convertToU2fSignCommand.
683
684         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
685         (TestWebKitAPI::TEST):
686         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
687         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
688         (TestWebKitAPI::TEST):
689
690 2019-03-19  Keith Rollin  <krollin@apple.com>
691
692         Add support for more platforms to generate-xcfilelists
693         https://bugs.webkit.org/show_bug.cgi?id=195977
694
695         Reviewed by Alexey Proskuryakov.
696
697         generate-xcfilelists incorrectly complains when involved with building
698         WebKit for iphonesimulator:
699
700             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
701             …
702             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
703
704         Address this by teaching generate-xcfilelists about more platforms.
705
706         * Scripts/generate-xcfilelists:
707
708 2019-03-19  John Wilander  <wilander@apple.com>
709
710         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
711         https://bugs.webkit.org/show_bug.cgi?id=195923
712         <rdar://problem/49001272>
713
714         Reviewed by Alex Christensen.
715
716         This patch does the following to the TestRunner:
717         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
718         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
719         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
720
721         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
722         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
723         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
724         * WebKitTestRunner/InjectedBundle/TestRunner.h:
725         * WebKitTestRunner/TestController.cpp:
726         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
727         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
728         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
729         * WebKitTestRunner/TestController.h:
730         * WebKitTestRunner/TestInvocation.cpp:
731         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
732
733 2019-03-19  Christopher Reid  <chris.reid@sony.com>
734
735         [CMake] Support more clang and gcc sanitizers
736         https://bugs.webkit.org/show_bug.cgi?id=195956
737
738         Reviewed by Michael Catanzaro.
739
740         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
741
742 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
743
744         [ews-build] Improve summary for PrintConfiguration step
745         https://bugs.webkit.org/show_bug.cgi?id=195945
746
747         Reviewed by Lucas Forschler.
748
749         * BuildSlaveSupport/ews-build/steps.py:
750         (PrintConfiguration.getResultSummary): Override getResultSummary.
751
752 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
753
754         [ews-build] Improve summary for CheckOutSource step
755         https://bugs.webkit.org/show_bug.cgi?id=195963
756
757         Reviewed by Lucas Forschler.
758
759         * BuildSlaveSupport/ews-build/steps.py:
760         (CheckOutSource.getResultSummary):
761
762 2019-03-19  Daniel Bates  <dabates@apple.com>
763
764         [iOS] Focus not preserved when switching between tabs
765         https://bugs.webkit.org/show_bug.cgi?id=195820
766         <rdar://problem/43614450>
767
768         Reviewed by Brent Fulgham.
769
770         Add tests to ensure that we restore focus when resigning and becoming first responder.
771
772         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
773         (TestWebKitAPI::TEST):
774
775 2019-03-19  Alex Christensen  <achristensen@webkit.org>
776
777         Make WTFLogChannelState and WTFLogLevel enum classes
778         https://bugs.webkit.org/show_bug.cgi?id=195904
779
780         Reviewed by Eric Carlson.
781
782         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
783         (TestWebKitAPI::TEST_F):
784
785 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
786
787         [GStreamer][EME] Backported mssdemux protection data crash fix
788         https://bugs.webkit.org/show_bug.cgi?id=195918
789
790         Reviewed by Philippe Normand.
791
792         * gstreamer/jhbuild.modules:
793         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
794
795 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
796
797         Unreviewed, rolling out r243132.
798
799         Broke GTK build
800
801         Reverted changeset:
802
803         "Make WTFLogChannelState and WTFLogLevel enum classes"
804         https://bugs.webkit.org/show_bug.cgi?id=195904
805         https://trac.webkit.org/changeset/243132
806
807 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
808
809         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
810
811         * Scripts/webkitdirs.pm:
812         (builtDylibPathForName): Adjust the shared library name that's changed
813         with the API version bump in r243073.
814
815 2019-03-18  Alex Christensen  <achristensen@webkit.org>
816
817         Make WTFLogChannelState and WTFLogLevel enum classes
818         https://bugs.webkit.org/show_bug.cgi?id=195904
819
820         Reviewed by Eric Carlson.
821
822         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
823         (TestWebKitAPI::TEST_F):
824
825 2019-03-18  Alex Christensen  <achristensen@webkit.org>
826
827         Disable flaky test added in r2431100
828         https://webkit.org/b/195785
829
830         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
831         (TestWebKitAPI::TEST):
832         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
833
834 2019-03-18  Timothy Hatcher  <timothy@apple.com>
835
836         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
837         https://bugs.webkit.org/show_bug.cgi?id=195916
838
839         Reviewed by Tim Horton.
840
841         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
842         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
843
844 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
845
846         Add a secondary e-mail address for Fujii Hironori to make tools happier.
847
848         * Scripts/webkitpy/common/config/contributors.json:
849
850 2019-03-18  Alex Christensen  <achristensen@webkit.org>
851
852         Implement DownloadMonitor to prevent long-running slow downloads from background apps
853         https://bugs.webkit.org/show_bug.cgi?id=195785
854
855         Reviewed by Geoffrey Garen.
856
857         * TestWebKitAPI/TCPServer.cpp: Added.
858         (TestWebKitAPI::TCPServer::TCPServer):
859         (TestWebKitAPI::TCPServer::~TCPServer):
860         (TestWebKitAPI::TCPServer::socketBindListen):
861         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
862         * TestWebKitAPI/TCPServer.h: Added.
863         (TestWebKitAPI::TCPServer::port const):
864         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
865         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
866         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
867         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
868         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
869         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
870         (TestWebKitAPI::respondSlowly):
871         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
872         (TestWebKitAPI::downloadAtRate):
873         (TestWebKitAPI::TEST):
874
875 2019-03-18  Saam Barati  <sbarati@apple.com>
876
877         Add a plan file for JetStream 2
878         https://bugs.webkit.org/show_bug.cgi?id=190734
879
880         Reviewed by Mark Lam.
881
882         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
883
884 2019-03-18  Chris Dumez  <cdumez@apple.com>
885
886         Delay WebProcess launch until a load is triggered in a Web view
887         https://bugs.webkit.org/show_bug.cgi?id=195758
888         <rdar://problem/48126013>
889
890         Reviewed by Geoff Garen.
891
892         Add API test coverage. Also update some existing API tests to not expect
893         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
894
895         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
896         (TestWebKitAPI::TEST):
897         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
898         (TestWebKitAPI::TEST):
899         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
900         (TEST):
901         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
902         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
903         (TEST):
904         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
905         (TEST):
906         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
907
908 2019-03-18  Xan Lopez  <xan@igalia.com>
909
910         [CMake] Prevent potential warning when determining $architecture
911         https://bugs.webkit.org/show_bug.cgi?id=195891
912
913         Reviewed by Michael Catanzaro.
914
915         It's possible for generateBuildSystemForCMakeProject to be called
916         before determineArchitecture() is ever called. This will make the
917         first eq check with $architecture to be bogus (and print a
918         warning). Change that to an eq check with architecture(), which
919         implicitly calls determineArchitecture() if needed, and change all
920         the other similar cases in the method in the same way to prevent
921         future bugs like this one.
922
923         * Scripts/webkitdirs.pm:
924         (generateBuildSystemFromCMakeProject):
925
926 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
927
928         [WPE] Tarballs generated with “make dist” cannot build documentation
929         https://bugs.webkit.org/show_bug.cgi?id=195885
930
931         Reviewed by Carlos Garcia Campos.
932
933         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
934
935 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
936
937         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
938         https://bugs.webkit.org/show_bug.cgi?id=195883
939
940         Reviewed by Carlos Garcia Campos.
941
942         * gtkdoc/gtkdoc.py:
943         (GTKDoc._run_command): When commands fail to run, include the full command line for
944         the program invocation and the output it has generated on the standard error stream.
945
946 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
947
948         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
949         https://bugs.webkit.org/show_bug.cgi?id=195786
950
951         Reviewed by Philippe Normand.
952
953         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
954         * wpe/jhbuild.modules: Ditto.
955
956 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
957
958         [ews-build] Don't run clean builds on EWS builders
959         https://bugs.webkit.org/show_bug.cgi?id=195851
960
961         Reviewed by Geoffrey Garen.
962
963         * BuildSlaveSupport/ews-build/factories.py:
964
965 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
966
967         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
968         https://bugs.webkit.org/show_bug.cgi?id=195849
969
970         Reviewed by Chris Dumez.
971
972         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
973
974         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
975         (runWebsiteDataStoreCustomPaths):
976
977 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
978
979         webkitpy: Upload test results
980         https://bugs.webkit.org/show_bug.cgi?id=195755
981         <rdar://problem/48896182>
982
983         Reviewed by Aakash Jain.
984
985         Establish a new format for uploading results that is not tied to layout tests, apply
986         that format to webkitpy tests.
987
988         * Scripts/webkitpy/common/checkout/scm/git.py:
989         (Git.native_branch): Return what branch the current checkout is on.
990         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
991         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
992         * Scripts/webkitpy/common/checkout/scm/svn.py:
993         (SVN.native_branch): Ditto.
994         * Scripts/webkitpy/common/system/platforminfo.py:
995         (PlatformInfo.build_version): Return a build version for Mac.
996         * Scripts/webkitpy/common/system/platforminfo_mock.py:
997         (MockPlatformInfo.__init__):
998         (MockPlatformInfo.build_version):
999         * Scripts/webkitpy/results: Added.
1000         * Scripts/webkitpy/results/__init__.py: Added.
1001         * Scripts/webkitpy/results/options.py: Added.
1002         (upload_options): OptParse list for upload options.
1003         * Scripts/webkitpy/results/upload.py: Added.
1004         (Upload): Class which enforces the upload format expected by the results server.
1005         (Upload.Expectations):
1006         (Upload.create_configuration):
1007         (Upload.create_commit):
1008         (Upload.create_details):
1009         (Upload.create_run_stats):
1010         (Upload.create_test_result):
1011         (Upload.__init__):
1012         (Upload.Encoder): Encode Upload object as json.
1013         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
1014         * Scripts/webkitpy/results/upload_unittest.py: Added.
1015         * Scripts/webkitpy/test/main.py:
1016         (Tester._parse_args): Add upload arguments.
1017         (Tester._run_tests): Allow results to be uploaded.
1018         * Scripts/webkitpy/test/runner.py:
1019         (Runner.__init__): Record which tests were run, rather than just counting them.
1020         (Runner.handle):
1021         * Scripts/webkitpy/test/runner_unittest.py:
1022         (RunnerTest.test_run):
1023         * Scripts/webkitpy/thirdparty/__init__.py:
1024         (AutoinstallImportHook.find_module): Add requests auto-install.
1025         (AutoinstallImportHook._install_requests):
1026         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1027         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
1028
1029 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1030
1031         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
1032         https://bugs.webkit.org/show_bug.cgi?id=195810
1033
1034         Reviewed by Tim Horton.
1035
1036         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
1037         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
1038         ending certain layout tests.
1039
1040         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1041         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1042         (-[TestRunnerWKWebView dealloc]):
1043         (-[TestRunnerWKWebView resetInteractionCallbacks]):
1044
1045         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
1046         helper method when destroying the web view, and when resetting state between tests.
1047
1048         * WebKitTestRunner/ios/TestControllerIOS.mm:
1049         (WTR::TestController::platformResetStateToConsistentValues):
1050
1051         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
1052
1053 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
1054
1055         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
1056         https://bugs.webkit.org/show_bug.cgi?id=190350
1057         <rdar://problem/45089503>
1058
1059         Reviewed by Geoffrey Garen.
1060
1061         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1062         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
1063         (TEST):
1064         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
1065         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
1066         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
1067         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
1068         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
1069         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
1070         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
1071         (runTest):
1072         (createDirectories):
1073         (TEST):
1074         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
1075         (TEST):
1076         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
1077         (TEST):
1078
1079 2019-03-15  Timothy Hatcher  <timothy@apple.com>
1080
1081         Add support to WebPage for getting the contents as an attributed string.
1082         https://bugs.webkit.org/show_bug.cgi?id=195636
1083         rdar://problem/45055697
1084
1085         Reviewed by Tim Horton.
1086
1087         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1088         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
1089
1090 2019-03-15  Chris Dumez  <cdumez@apple.com>
1091
1092         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
1093         https://bugs.webkit.org/show_bug.cgi?id=195747
1094
1095         Reviewed by Geoff Garen.
1096
1097         Add API test coverage.
1098
1099         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1100
1101 2019-03-15  Shawn Roberts  <sroberts@apple.com>
1102
1103         Unreviewed, rolling out r242952.
1104
1105         Causing API failures on iOS Simulator
1106
1107         Reverted changeset:
1108
1109         "[PSON] Make sure the WebProcessCache is leverage when
1110         relaunching a process after termination"
1111         https://bugs.webkit.org/show_bug.cgi?id=195747
1112         https://trac.webkit.org/changeset/242952
1113
1114 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
1115
1116         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
1117         https://bugs.webkit.org/show_bug.cgi?id=195740
1118
1119         Reviewed by Ross Kirsling.
1120
1121         window.open doesn't work for WebKitBrowserWindow because it is not
1122         implemented yet.
1123
1124         1. Implemented createNewPage callback of WKPageUIClient.
1125         2. Changed MainWindow to take a BrowserWindow factory function
1126           instead of BrowserWindowType to be flexible to create
1127           BrowserWindow with extra settings.
1128         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
1129           because it is not relevant with MainWindow anymore.
1130
1131         * MiniBrowser/win/Common.cpp:
1132         (parseCommandLine):
1133         * MiniBrowser/win/Common.h:
1134         (CommandLineOptions::CommandLineOptions):
1135         * MiniBrowser/win/MainWindow.cpp:
1136         (MainWindow::MainWindow):
1137         (MainWindow::create):
1138         (MainWindow::init):
1139         (MainWindow::WndProc):
1140         * MiniBrowser/win/MainWindow.h:
1141         * MiniBrowser/win/PrintWebUIDelegate.cpp:
1142         (PrintWebUIDelegate::createWebViewWithRequest):
1143         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1144         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
1145         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
1146         (WebKitBrowserWindow::updateProxySettings):
1147         (WebKitBrowserWindow::createNewPage):
1148         * MiniBrowser/win/WebKitBrowserWindow.h:
1149         * MiniBrowser/win/WinMain.cpp:
1150         (wWinMain):
1151
1152 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
1153
1154         Make it possible to test scrolling tree layer manipulation more easily
1155         https://bugs.webkit.org/show_bug.cgi?id=195780
1156
1157         Reviewed by Tim Horton.
1158         
1159         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
1160         cuts off communication of scrolling tree scrolls back to the web process
1161         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
1162         allows tests to trigger scrolls which run the scrolling tree layer positioning
1163         logic, but never get another commit from the web process that might mask
1164         scrolling tree bugs.
1165         
1166         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
1167         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
1168         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
1169
1170         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1171         (WTR::UIScriptController::scrollUpdatesDisabled const):
1172         (WTR::UIScriptController::setScrollUpdatesDisabled):
1173         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1174         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1175         (WTR::UIScriptController::scrollUpdatesDisabled const):
1176         (WTR::UIScriptController::setScrollUpdatesDisabled):
1177         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1178         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1179         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1180         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
1181         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
1182         * WebKitTestRunner/ios/TestControllerIOS.mm:
1183         (WTR::TestController::platformResetStateToConsistentValues):
1184         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1185         (WTR::UIScriptController::scrollUpdatesDisabled const):
1186         (WTR::UIScriptController::setScrollUpdatesDisabled):
1187
1188 2019-03-14  Youenn Fablet  <youenn@apple.com>
1189
1190         Move IDB storage in private browsing mode to NetworkProcess
1191         https://bugs.webkit.org/show_bug.cgi?id=195602
1192
1193         Reviewed by Brady Eidson.
1194
1195         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
1196         (TEST):
1197
1198 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1199
1200         [ews-build] Make descriptionDone messages more readable
1201         https://bugs.webkit.org/show_bug.cgi?id=195760
1202
1203         Reviewed by Lucas Forschler.
1204
1205         * BuildSlaveSupport/ews-build/steps.py:
1206         * BuildSlaveSupport/ews-build/steps_unittest.py:
1207
1208 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1209
1210         [ews-build] Generate status-bubble hover-over messages
1211         https://bugs.webkit.org/show_bug.cgi?id=195680
1212
1213         Reviewed by Lucas Forschler.
1214
1215         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1216         (StatusBubble):
1217         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
1218         on hover-over.
1219         (StatusBubble._iso_time):
1220         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
1221         hover-over message.
1222         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
1223
1224 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1225
1226         [ews-app] Gracefully handle the case when state_string is None
1227         https://bugs.webkit.org/show_bug.cgi?id=195753
1228
1229         Reviewed by Lucas Forschler.
1230
1231         * BuildSlaveSupport/ews-app/ews/models/build.py:
1232         * BuildSlaveSupport/ews-app/ews/models/step.py:
1233
1234 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1235
1236         [ews-app] Status bubble display pending for currently running build step
1237         https://bugs.webkit.org/show_bug.cgi?id=195744
1238
1239         Reviewed by Lucas Forschler.
1240
1241         * BuildSlaveSupport/ews-build/events.py:
1242         (Events.stepStarted): If state_string is pending, replace it with step name.
1243
1244 2019-03-14  Chris Dumez  <cdumez@apple.com>
1245
1246         Add WebsitePolicy for the client to specify the device orientation & motion access policy
1247         https://bugs.webkit.org/show_bug.cgi?id=195750
1248
1249         Reviewed by Geoffrey Garen.
1250
1251         Add API test coverage.
1252
1253         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1254         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
1255         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1256         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1257
1258 2019-03-14  Chris Dumez  <cdumez@apple.com>
1259
1260         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
1261         https://bugs.webkit.org/show_bug.cgi?id=195747
1262
1263         Reviewed by Geoff Garen.
1264
1265         Add API test coverage.
1266
1267         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1268
1269 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
1270
1271         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
1272         https://bugs.webkit.org/show_bug.cgi?id=195725
1273         <rdar://problem/48545062>
1274
1275         Reviewed by Tim Horton.
1276
1277         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
1278         handler is nil.
1279
1280         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1281         (TestWebKitAPI::TEST):
1282
1283 2019-03-13  Sam Weinig  <sam@webkit.org>
1284
1285         Add utility function to allow easy reverse range-based iteration of a container
1286         https://bugs.webkit.org/show_bug.cgi?id=195542
1287
1288         Reviewed by Antti Koivisto.
1289
1290         * TestWebKitAPI/CMakeLists.txt:
1291         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1292         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
1293         (TestWebKitAPI::TEST):
1294         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
1295
1296 2019-03-13  Chris Dumez  <cdumez@apple.com>
1297
1298         Use a ServiceWorker process per registrable domain
1299         https://bugs.webkit.org/show_bug.cgi?id=195649
1300
1301         Reviewed by Youenn Fablet.
1302
1303         Update API test coverage.
1304
1305         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1306
1307 2019-03-13  Chris Dumez  <cdumez@apple.com>
1308
1309         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
1310         https://bugs.webkit.org/show_bug.cgi?id=195684
1311         <rdar://problem/48294714>
1312
1313         Reviewed by Antti Koivisto.
1314
1315         Add API test coverage.
1316
1317         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1318
1319 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
1320
1321         [ews-app] Remove unused patch view
1322         https://bugs.webkit.org/show_bug.cgi?id=195669
1323
1324         Reviewed by Lucas Forschler.
1325
1326         * BuildSlaveSupport/ews-app/ews/urls.py:
1327         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
1328
1329 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
1330
1331         [ews-app] Use Buildbot result code variables
1332         https://bugs.webkit.org/show_bug.cgi?id=195668
1333
1334         Reviewed by Alexey Proskuryakov.
1335
1336         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1337         (Buildbot): Added Buildbot result code variables.
1338         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1339         (StatusBubble._build_bubble): Used Buildbot result code variables.
1340
1341 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
1342
1343         [Flatpak] Expand submodule recursively
1344         https://bugs.webkit.org/show_bug.cgi?id=195672
1345
1346         Building WPE with flatpak was impossible without that as it was raising an exception.
1347         Also update wpebackend-fdo to match what is built in jhbuild
1348
1349         Reviewed by Philippe Normand.
1350
1351         * flatpak/flatpakutils.py:
1352         (expand_submodules_recurse):
1353         (expand_manifest):
1354         * flatpak/org.webkit.WPEModules.yaml:
1355
1356 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
1357
1358         [ews-app] status bubble should be hidden for certain builds
1359         https://bugs.webkit.org/show_bug.cgi?id=194597
1360
1361         Reviewed by Dewei Zhu.
1362
1363         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1364         (StatusBubble._build_bubble):
1365         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
1366         because the patch didn't have relevant changes.
1367         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
1368         in production yet.
1369
1370 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
1371
1372         [Win] Fix a slew of simple clang-cl warnings.
1373         https://bugs.webkit.org/show_bug.cgi?id=195652
1374
1375         Reviewed by Don Olmstead.
1376
1377         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1378         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
1379
1380 2019-03-12  Justin Fan  <justin_fan@apple.com>
1381
1382         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
1383         https://bugs.webkit.org/show_bug.cgi?id=195518
1384         <rdar://problem/46322356>
1385
1386         Reviewed by Myles C. Maxfield.
1387
1388         * DumpRenderTree/DerivedSources-input.xcfilelist:
1389         * DumpRenderTree/DerivedSources-output.xcfilelist:
1390
1391 2019-03-12  Commit Queue  <commit-queue@webkit.org>
1392
1393         Unreviewed, rolling out r242825.
1394         https://bugs.webkit.org/show_bug.cgi?id=195648
1395
1396         "Broke webkitpy tests with my change to
1397         lldb_dump_class_layout.py" (Requested by rmorisset on
1398         #webkit).
1399
1400         Reverted changeset:
1401
1402         "Alter Tools/Scripts/dump-class-layout to be able to dump all
1403         classes with suspicious padding"
1404         https://bugs.webkit.org/show_bug.cgi?id=195573
1405         https://trac.webkit.org/changeset/242825
1406
1407 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
1408
1409         [ews-build] Show status bubbles while the patch is waiting in queue
1410         https://bugs.webkit.org/show_bug.cgi?id=195618
1411
1412         Reviewed by Lucas Forschler.
1413
1414         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1415         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
1416         enabled in initial deployment.
1417         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
1418         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
1419         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
1420         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
1421         (StatusBubble._build_bubbles_for_patch):
1422
1423 2019-03-12  Robin Morisset  <rmorisset@apple.com>
1424
1425         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
1426         https://bugs.webkit.org/show_bug.cgi?id=195573
1427
1428         Reviewed by Simon Fraser.
1429
1430         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
1431
1432         * Scripts/dump-class-layout:
1433         (main):
1434         * lldb/lldb_dump_class_layout.py:
1435         (ClassLayout.__init__):
1436         (ClassLayout._compute_padding_recursive):
1437         (LLDBDebuggerInstance.dump_layout_for_classname):
1438         (LLDBDebuggerInstance):
1439         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
1440         (LLDBDebuggerInstance.layout_for_classname): Deleted.
1441
1442 2019-03-12  Chris Dumez  <cdumez@apple.com>
1443
1444         Device Orientation access permission should be denied unless explicitly granted by the client
1445         https://bugs.webkit.org/show_bug.cgi?id=195625
1446
1447         Reviewed by Youenn Fablet.
1448
1449         add API test coverage.
1450
1451         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1452         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
1453         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
1454         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
1455         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1456         (runDeviceOrientationTest):
1457         (TEST):
1458         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1459         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1460
1461 2019-03-12  Jer Noble  <jer.noble@apple.com>
1462
1463         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
1464         https://bugs.webkit.org/show_bug.cgi?id=195137
1465         <rdar://problem/48810307>
1466
1467         Reviewed by Eric Carlson.
1468
1469         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
1470         (TestWebKitAPI::TEST):
1471
1472 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
1473
1474         [ews-build] Change urls from uat to production
1475         https://bugs.webkit.org/show_bug.cgi?id=195566
1476
1477         Reviewed by Lucas Forschler.
1478
1479         * BuildSlaveSupport/ews-app/ews/config.py:
1480         * BuildSlaveSupport/ews-build/events.py:
1481         * BuildSlaveSupport/ews-build/steps.py:
1482
1483 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
1484
1485         [ews-build] change max_builds for local-worker to 1
1486         https://bugs.webkit.org/show_bug.cgi?id=195568
1487
1488         Reviewed by Lucas Forschler.
1489
1490         * BuildSlaveSupport/ews-build/loadConfig.py:
1491
1492 2019-03-12  Tim Horton  <timothy_horton@apple.com>
1493
1494         Fix the build
1495
1496         * TestRunnerShared/spi/PencilKitTestSPI.h:
1497         * TestWebKitAPI/ios/PencilKitTestSPI.h:
1498
1499 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
1500
1501         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
1502         https://bugs.webkit.org/show_bug.cgi?id=194131
1503
1504         Reviewed by Michael Catanzaro.
1505
1506         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1507         (uriChanged):
1508         (testUnfinishedSubresourceLoad):
1509         (serverCallback):
1510         (beforeAll):
1511
1512 2019-03-11  Alex Christensen  <achristensen@webkit.org>
1513
1514         WTF::Expected should use std::addressof instead of operator&
1515         https://bugs.webkit.org/show_bug.cgi?id=195604
1516
1517         Reviewed by Myles Maxfield.
1518
1519         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1520         (TestWebKitAPI::Unique::Unique):
1521         (TestWebKitAPI::Unique::operator&):
1522         (TestWebKitAPI::TEST):
1523
1524 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
1525
1526         Add Optional to Forward.h.
1527         https://bugs.webkit.org/show_bug.cgi?id=195586
1528
1529         Reviewed by Darin Adler.
1530
1531         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
1532         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
1533         Remove unnecessary includes from headers.
1534
1535 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
1536
1537         Add testing API to hit-test and scroll overflow scrollers
1538         https://bugs.webkit.org/show_bug.cgi?id=195278
1539
1540         Reviewed by Antti Koivisto.
1541         
1542         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
1543         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
1544         
1545         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
1546
1547         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1548         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
1549         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1550         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1551         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
1552         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1553         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1554         (WTR::enclosingScrollViewIncludingSelf):
1555         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
1556
1557 2019-03-11  Tim Horton  <timothy_horton@apple.com>
1558
1559         API test WebKit.RequestTextInputContext fails on iOS
1560         https://bugs.webkit.org/show_bug.cgi?id=195585
1561
1562         Reviewed by Wenson Hsieh and Simon Fraser.
1563
1564         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1565         (applyStyle):
1566         (TEST):
1567         Add a viewport, so that the coordinates match up on iOS.
1568         Scroll by moving the UIScrollView's contentOffset.
1569
1570 2019-03-11  Chris Dumez  <cdumez@apple.com>
1571
1572         Assert in WebPageProxy::suspendCurrentPageIfPossible()
1573         https://bugs.webkit.org/show_bug.cgi?id=195506
1574         <rdar://problem/48733477>
1575
1576         Reviewed by Alex Christensen.
1577
1578         Add API test coverage.
1579
1580         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1581
1582 2019-03-11  Shawn Roberts  <sroberts@apple.com>
1583
1584         Adding myself to contributors.json
1585
1586         Unreviewed, addming myself to contributors.json .
1587
1588         * Scripts/webkitpy/common/config/contributors.json:
1589
1590 2019-03-11  Alex Christensen  <achristensen@webkit.org>
1591
1592         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
1593         https://bugs.webkit.org/show_bug.cgi?id=195511
1594         <rdar://problem/44873269>
1595
1596         Reviewed by Darin Adler.
1597
1598         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
1599         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
1600         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
1601         (TEST_F):
1602
1603 2019-03-11  Chris Dumez  <cdumez@apple.com>
1604
1605         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
1606         https://bugs.webkit.org/show_bug.cgi?id=195561
1607
1608         Reviewed by Youenn Fablet.
1609
1610         Make sure the JS in the test requests for permission to receive device orientation events.
1611
1612         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1613
1614 2019-03-11  Youenn Fablet  <youenn@apple.com>
1615
1616         Allow storage quota increase by default in WTR
1617         https://bugs.webkit.org/show_bug.cgi?id=195541
1618
1619         Reviewed by Geoffrey Garen.
1620
1621         Allow storage quota increase by default in WTR.
1622         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
1623         Use this for tests that explicitly need cache increase.
1624
1625         Instead of increasing quota by 2, make sure the next request is
1626         granted by adding all given parameters.
1627
1628         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1629         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1630         (WTR::TestRunner::setAllowStorageQuotaIncrease):
1631         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
1632         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1633         * WebKitTestRunner/TestController.cpp:
1634         (WTR::TestController::setAllowStorageQuotaIncrease):
1635         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
1636         * WebKitTestRunner/TestController.h:
1637         * WebKitTestRunner/TestInvocation.cpp:
1638         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1639         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1640         (WTR::TestController::cocoaResetStateToConsistentValues):
1641         (WTR::TestController::setAllowStorageQuotaIncrease):
1642         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
1643         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
1644         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
1645
1646 2019-03-11  Xan Lopez  <xan@igalia.com>
1647
1648         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
1649         https://bugs.webkit.org/show_bug.cgi?id=194147
1650
1651         Reviewed by Michael Saboff.
1652
1653         To make --32-bit work correctly on Linux/64bit we need to:
1654
1655         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
1656         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
1657         unfortunately CMake only allows us to do this during
1658         crosscompilation, which is overkill here.
1659         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
1660         pkg-config detection module uses the x86 .pc files instead of the
1661         x86_64 ones.
1662         - Set the -m32 flags for the compiler.
1663
1664         * Scripts/webkitdirs.pm:
1665         (generateBuildSystemFromCMakeProject):
1666
1667 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
1668
1669         Add MotionMark-1.1 plan file for run-benchmark script.
1670         https://bugs.webkit.org/show_bug.cgi?id=195481
1671
1672         Rubber-stamped by Darin Adler.
1673
1674         Run-benchmark script should support MontionMark-1.1.
1675
1676         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
1677
1678 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
1679
1680         [ews-app] Add support for submit-to-ews url
1681         https://bugs.webkit.org/show_bug.cgi?id=195477
1682
1683         Reviewed by Lucas Forschler.
1684
1685         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1686         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1687         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
1688         * BuildSlaveSupport/ews-app/ews/urls.py:
1689         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
1690
1691 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
1692
1693         Unreviewed, rolling out r242688, r242643, r242624.
1694
1695         Caused multiple layout test failures and crashes on iOS and macOS.
1696
1697         Reverted changeset:
1698
1699         "requestAnimationFrame should execute before the next frame"
1700         https://bugs.webkit.org/show_bug.cgi?id=177484
1701         https://trac.webkit.org/changeset/242624/webkit
1702
1703         * Tracing/SystemTracePoints.plist:
1704
1705 2019-03-11  John Wilander  <wilander@apple.com>
1706
1707         Resource Load Statistics: Make it possible exclude localhost from classification
1708         https://bugs.webkit.org/show_bug.cgi?id=195474
1709         <rdar://problem/47520577>
1710
1711         Reviewed by Brent Fulgham.
1712
1713         This patch allows for localhost to be excluded from classification and
1714         treatment as a prevalent resource.
1715
1716         The WebKit Tools change adds a new function called
1717         testRunner.setStatisticsIsRunningTest() which can be used to control this
1718         behavior.
1719
1720         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1721         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1722         (WTR::TestRunner::setStatisticsIsRunningTest):
1723         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1724         * WebKitTestRunner/TestController.cpp:
1725         (WTR::TestController::setStatisticsIsRunningTest):
1726         * WebKitTestRunner/TestController.h:
1727         * WebKitTestRunner/TestInvocation.cpp:
1728         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1729
1730 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
1731
1732         [ews-build] Disable waterfall and console view for ews-build.webkit.org
1733         https://bugs.webkit.org/show_bug.cgi?id=195560
1734
1735         Reviewed by Lucas Forschler.
1736
1737         * BuildSlaveSupport/ews-build/master.cfg:
1738
1739 2019-03-11  Alex Christensen  <achristensen@webkit.org>
1740
1741         Unreviewed, rolling out r242698.
1742
1743         API test crashes on bots.
1744
1745         Reverted changeset:
1746
1747         "Add a WKContentRuleList variant that uses copied memory
1748         instead of mmap'd shared memory for class A containerized
1749         apps"
1750         https://bugs.webkit.org/show_bug.cgi?id=195511
1751         https://trac.webkit.org/changeset/242698
1752
1753 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
1754
1755         [WPE] Enable web process sandbox
1756         https://bugs.webkit.org/show_bug.cgi?id=195169
1757
1758         Reviewed by Daniel Bates.
1759
1760         * wpe/install-dependencies:
1761         * wpe/jhbuild.modules:
1762
1763 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
1764
1765         [ews-app] Use port 17000 for worker communication
1766         https://bugs.webkit.org/show_bug.cgi?id=195558
1767
1768         Reviewed by Lucas Forschler.
1769
1770         * BuildSlaveSupport/ews-build/master.cfg:
1771
1772 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
1773
1774         [ews-build] unit-tests fail when passwords.json is missing
1775         https://bugs.webkit.org/show_bug.cgi?id=195557
1776
1777         Reviewed by Lucas Forschler.
1778
1779         * BuildSlaveSupport/ews-build/loadConfig.py:
1780         (loadBuilderConfig):
1781         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1782         (ConfigDotJSONTest.test_configuration):
1783         * BuildSlaveSupport/ews-build/master.cfg:
1784
1785 2019-03-11  Truitt Savell  <tsavell@apple.com>
1786
1787         Unreviewed, rolling out r242702.
1788
1789         Broke High Sierra builders.
1790
1791         Reverted changeset:
1792
1793         "Add utility function to allow easy reverse range-based
1794         iteration of a container"
1795         https://bugs.webkit.org/show_bug.cgi?id=195542
1796         https://trac.webkit.org/changeset/242702
1797
1798 2019-03-11  Sam Weinig  <sam@webkit.org>
1799
1800         Add utility function to allow easy reverse range-based iteration of a container
1801         https://bugs.webkit.org/show_bug.cgi?id=195542
1802
1803         Reviewed by Antti Koivisto.
1804
1805         * TestWebKitAPI/CMakeLists.txt:
1806         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1807         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
1808         (TestWebKitAPI::TEST):
1809         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
1810
1811 2019-03-10  Alex Christensen  <achristensen@webkit.org>
1812
1813         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
1814         https://bugs.webkit.org/show_bug.cgi?id=195511
1815         <rdar://problem/44873269>
1816
1817         Reviewed by Darin Adler.
1818
1819         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
1820         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
1821         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
1822         (TEST_F):
1823
1824 2019-03-10  Tim Horton  <timothy_horton@apple.com>
1825
1826         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
1827         https://bugs.webkit.org/show_bug.cgi?id=195499
1828
1829         Reviewed by Darin Adler.
1830
1831         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1832         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
1833         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
1834         (-[WKWebView synchronouslyFocusTextInputContext:]):
1835         (applyStyle):
1836         (applyIframe):
1837         (TEST):
1838         Add some tests for this SPI.
1839
1840 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
1841
1842         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
1843         https://bugs.webkit.org/show_bug.cgi?id=181151
1844
1845         Reviewed by Don Olmstead.
1846
1847         * TestWebKitAPI/CMakeLists.txt:
1848         * TestWebKitAPI/PlatformWin.cmake:
1849         Enable TestWTF RunLoop tests in all platforms.
1850
1851         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
1852         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
1853         (TestWebKitAPI::DerivedOneShotTimer::fired):
1854         (TestWebKitAPI::TEST):
1855         Only a few platforms support nested RunLoop.
1856
1857         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
1858         (TestWebKitAPI::DerivedRepeatingTimer::fired):
1859
1860 2019-03-10  David Quesada  <david_quesada@apple.com>
1861
1862         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
1863         https://bugs.webkit.org/show_bug.cgi?id=152480
1864
1865         Reviewed by Chris Dumez.
1866
1867         Add a unit test based on Daniel Bates's test case that starts a download, ensures
1868         there are no additional references to the process pool besides the one held by
1869         the download, waits for the download to finish (in the sense that the
1870         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
1871         measure, also check that the process pool has been deallocated at the end of the
1872         test. The test wouldn't be meaningful if the process pool were still alive.
1873
1874         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1875         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
1876         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
1877             The download will be canceled because the delegate does not implement the
1878             method to decide the download's destination, so this is where we know the
1879             DownloadProxyMap is done with the DownloadProxy.
1880         (TEST):
1881
1882 2019-03-08  Chris Dumez  <cdumez@apple.com>
1883
1884         Add support for Device Orientation / Motion permission API
1885         https://bugs.webkit.org/show_bug.cgi?id=195329
1886         <rdar://problem/47645367>
1887
1888         Reviewed by Geoffrey Garen.
1889
1890         Add test infrastructure to help test the Device Orientation / Motion permission API.
1891
1892         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1893         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1894         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
1895         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1896         * WebKitTestRunner/TestController.cpp:
1897         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
1898         (WTR::TestController::createWebViewWithOptions):
1899         (WTR::TestController::resetStateToConsistentValues):
1900         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
1901         * WebKitTestRunner/TestController.h:
1902         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
1903         * WebKitTestRunner/TestInvocation.cpp:
1904         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1905
1906 2019-03-08  Saam barati  <sbarati@apple.com>
1907
1908         Add a compare-results script to compare benchmark results
1909         https://bugs.webkit.org/show_bug.cgi?id=195486
1910         <rdar://problem/48723397>
1911
1912         Reviewed by Geoffrey Garen.
1913
1914         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
1915         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
1916         to extend it to learn about our other benchmarks.
1917
1918         * Scripts/compare-results: Added.
1919         (readJSONFile):
1920         (detectJetStream2):
1921         (JetStream2Results):
1922         (detectSpeedometer2):
1923         (Speedometer2Results):
1924         (detectPLT5):
1925         (PLT5Results):
1926         (detectBenchmark):
1927         (biggerIsBetter):
1928         (ttest):
1929         (getOptions):
1930         (main):
1931
1932 2019-03-08  Stephanie Lewis  <slewis@apple.com>
1933
1934         Ensure old tab state is cleared between iterations of run-benchmark
1935         https://bugs.webkit.org/show_bug.cgi?id=195393
1936         <rdar://problem/46885583>
1937
1938         Reviewed by Dewei Zhu.
1939
1940         a) ensure the default to restore state is not set
1941         b) terminate Safari correctly
1942         c) Set the system default to ignore Persistent State in Safari
1943
1944         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1945         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
1946         (OSXBrowserDriver.prepare_env): 
1947         (OSXBrowserDriver.restore_env):
1948         (OSXBrowserDriver.close_browsers):
1949         (OSXBrowserDriver._terminate_processes):
1950         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
1951         (OSXChromeDriver):
1952         (OSXChromeCanaryDriver):
1953         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
1954         (OSXFirefoxDriver):
1955         (OSXFirefoxNightlyDriver):
1956         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
1957         (OSXSafariDriver):
1958         (OSXSafariDriver.prepare_env):
1959
1960 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
1961
1962         [GTK] Several InputMethodFilter tests are failing
1963         https://bugs.webkit.org/show_bug.cgi?id=195408
1964
1965         Reviewed by Carlos Garcia Campos.
1966
1967         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
1968         Regressed in r241751.
1969         Hexadecimal values of keycodes are expressed now in upper letters.
1970         Composited characters should be cast to UTF8 strings.
1971
1972         (TestWebKitAPI::TEST):
1973
1974 2019-03-07  Tomas Popela  <tpopela@redhat.com>
1975
1976         [GTK] Make Tools/gtkdoc python3 compatible
1977         https://bugs.webkit.org/show_bug.cgi?id=195359
1978
1979         Reviewed by Carlos Garcia Campos.
1980
1981         * gtkdoc/generate-gtkdoc:
1982         ConfigParser was reworked in Python 3.2 so we have adapt the code to
1983         work with Python 2 and 3.
1984         (get_gtkdoc_module_paths):
1985         The iteritems() was removed in Python 3, so let's use items() that's
1986         available in Python 2 and 3.
1987         (get_generator_for_config):
1988         * gtkdoc/gtkdoc.py:
1989         (GTKDoc._run_command):
1990         The sys.stdout.write() is expecting str in Python 3 and not bytes
1991         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
1992         for passing the bytes there.
1993
1994 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
1995
1996         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
1997         https://bugs.webkit.org/show_bug.cgi?id=195346
1998         <rdar://problem/48667048>
1999
2000         Unreviewed build fix for clang-cl.
2001
2002         * DumpRenderTree/win/DumpRenderTree.cpp:
2003         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
2004
2005 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
2006
2007         requestAnimationFrame should execute before the next frame
2008         https://bugs.webkit.org/show_bug.cgi?id=177484
2009
2010         Reviewed by Simon Fraser.
2011
2012         Add trace points for the page RenderingUpdate.
2013
2014         * Tracing/SystemTracePoints.plist:
2015
2016 2019-03-07  Zalan Bujtas  <zalan@apple.com>
2017
2018         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
2019         https://bugs.webkit.org/show_bug.cgi?id=195353
2020         <rdar://problem/48626394>
2021
2022         Reviewed by Simon Fraser.
2023
2024         * WebKitTestRunner/ios/TestControllerIOS.mm:
2025         (WTR::TestController::platformResetPreferencesToConsistentValues):
2026
2027 2019-03-07  John Wilander  <wilander@apple.com>
2028
2029         Resource Load Statistics: Make it possible to purge only script-accessible cookies
2030         https://bugs.webkit.org/show_bug.cgi?id=195383
2031         <rdar://problem/48570136>
2032
2033         Reviewed by Brent Fulgham.
2034
2035         This patch adds test infrastructure to purge only script-accessible cookies,
2036         including a new testRunner function called statisticsDeleteCookiesForHost().git a
2037
2038         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2039         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2040         (WTR::TestRunner::statisticsDeleteCookiesForHost):
2041         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2042         * WebKitTestRunner/TestController.cpp:
2043         (WTR::TestController::statisticsDeleteCookiesForHost):
2044         * WebKitTestRunner/TestController.h:
2045         * WebKitTestRunner/TestInvocation.cpp:
2046         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2047
2048 2019-03-07  Commit Queue  <commit-queue@webkit.org>
2049
2050         Unreviewed, rolling out r242354.
2051         https://bugs.webkit.org/show_bug.cgi?id=195402
2052
2053         breaks layout tests in all configurations (Requested by
2054         zdobersek on #webkit).
2055
2056         Reverted changeset:
2057
2058         "[WPE] Enable web process sandbox"
2059         https://bugs.webkit.org/show_bug.cgi?id=195169
2060         https://trac.webkit.org/changeset/242354
2061
2062 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
2063
2064         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
2065         https://bugs.webkit.org/show_bug.cgi?id=195346
2066
2067         Reviewed by Fujii Hironori.
2068
2069         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2070         (TestWebKitAPI::TEST):
2071         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
2072
2073         * DumpRenderTree/win/DumpRenderTree.cpp:
2074         (findFontFallback):
2075         (addFontFallbackIfPresent):
2076         (removeFontFallbackIfPresent):
2077         (main):
2078         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2079         (TestWebKitAPI::Util::moduleDirectory):
2080         (TestWebKitAPI::Util::createInjectedBundlePath):
2081         Use wchar helpers as needed.
2082
2083 2019-03-06  Rob Buis  <rbuis@igalia.com>
2084
2085         Consider supporting the `referrerpolicy` attribute.
2086         https://bugs.webkit.org/show_bug.cgi?id=179053
2087
2088         Reviewed by Darin Adler.
2089
2090         Add a runtime flag for referrerpolicy attribute.
2091
2092         * DumpRenderTree/mac/DumpRenderTree.mm:
2093         (enableExperimentalFeatures):
2094
2095 2019-03-05  Daniel Bates  <dabates@apple.com>
2096
2097         Update expected API test result following r242379
2098         (https://bugs.webkit.org/show_bug.cgi?id=195125)
2099
2100         Update expected x-coordinate of selection rect now that the left padding of
2101         a textarea is sized in ems (so dependent on the font size) just like the left
2102         padding of a text field.
2103
2104         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2105         (TestWebKitAPI::TEST):
2106
2107 2019-03-05  David Quesada  <david_quesada@apple.com>
2108
2109         [WK2] It should be possible to follow links with 'download' attributes
2110         https://bugs.webkit.org/show_bug.cgi?id=195145
2111         rdar://problem/48462642
2112
2113         Reviewed by Alex Christensen.
2114
2115         Add a unit test to verify that activating links with 'download' attributes now
2116         navigates to the linked resource, rather than starts downloading it. Add another
2117         to verify that it is still possible to explicitly download the link via the
2118         'Download' navigation action policy.
2119
2120         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2121         (-[DownloadAttributeTestDelegate init]):
2122         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
2123         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
2124         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
2125         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
2126         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2127         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
2128         (TEST):
2129         * WebKitTestRunner/TestController.cpp:
2130         (WTR::TestController::decidePolicyForNavigationAction):
2131         * WebKitTestRunner/TestController.h:
2132
2133 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
2134
2135         [Curl] Implement Cookie Accept Policy.
2136         https://bugs.webkit.org/show_bug.cgi?id=191645
2137
2138         Reviewed by Fujii Hironori.
2139
2140         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
2141         (TestWebKitAPI::Curl::TEST_F):
2142
2143 2019-03-05  Youenn Fablet  <youenn@apple.com>
2144
2145         Rename requestCacheStorageSpace to requestStorageSpace
2146         https://bugs.webkit.org/show_bug.cgi?id=195282
2147
2148         Reviewed by Chris Dumez.
2149
2150         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2151         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2152         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
2153
2154 2019-03-05  Brady Eidson  <beidson@apple.com>
2155
2156         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
2157         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
2158
2159         Reviewed by Tim Horton.
2160
2161         Loading a file: URL into a WKWebView and then loading another file: url from a completely
2162         different directory into that same WKWebView should work.
2163
2164         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2165         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
2166
2167 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
2168
2169         Add WeakHashSet
2170         https://bugs.webkit.org/show_bug.cgi?id=195152
2171
2172         Reviewed by Antti Koivisto.
2173
2174         Added tests for WeakHashSet.
2175
2176         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2177         (TestWebKitAPI::Base::Base): Moved.
2178         (TestWebKitAPI::Derived::foo): Moved.
2179         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
2180         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
2181         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
2182         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
2183
2184 2019-03-04  Chris Dumez  <cdumez@apple.com>
2185
2186         Do not share WebProcesses between private and regular sessions
2187         https://bugs.webkit.org/show_bug.cgi?id=195189
2188         <rdar://problem/48421064>
2189
2190         Reviewed by Alex Christensen.
2191
2192         Add API test coverage.
2193
2194         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2195         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2196
2197 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2198
2199         [WPE] Enable web process sandbox
2200         https://bugs.webkit.org/show_bug.cgi?id=195169
2201
2202         Reviewed by Daniel Bates.
2203
2204         * wpe/install-dependencies:
2205         * wpe/jhbuild.modules:
2206
2207 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2208
2209         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
2210         https://bugs.webkit.org/show_bug.cgi?id=195206
2211
2212         Reviewed by Žan Doberšek.
2213
2214         Add a new test case.
2215
2216         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2217         (testJSCClass):
2218
2219 2019-03-04  Charlie Turner  <cturner@igalia.com>
2220
2221         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
2222         https://bugs.webkit.org/show_bug.cgi?id=194898
2223
2224         Reviewed by Žan Doberšek.
2225
2226         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
2227         a GCC extension that permits arithmetic on void* pointer. Inline
2228         the macro until this issue is fixed upstream.
2229
2230 2019-03-03  Tim Horton  <timothy_horton@apple.com>
2231
2232         Rid the world of WK_API_ENABLED
2233         https://bugs.webkit.org/show_bug.cgi?id=195263
2234
2235         Reviewed by Dan Bernstein.
2236
2237         List of changed files elided because it's useless.
2238
2239 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
2240
2241         Unreviewed follow-up to r242292.
2242
2243         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
2244
2245         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2246         (TestWebKitAPI::testStrip): Renamed from strip.
2247         (TestWebKitAPI::TEST):
2248
2249 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2250
2251         Unreviewed, remove accidentally-committed URLHelpers.cpp test
2252
2253         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
2254         and bug #194272 for details.
2255
2256         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
2257
2258 2019-03-03  Tim Horton  <timothy_horton@apple.com>
2259
2260         Remove some more unused 32-bit code
2261         https://bugs.webkit.org/show_bug.cgi?id=195255
2262
2263         Reviewed by Darin Adler.
2264
2265         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2266         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
2267         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2268         (NPP_New):
2269         (NPP_HandleEvent):
2270         (handleEventCarbon): Deleted.
2271
2272 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
2273
2274         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
2275
2276         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2277         (TestWebKitAPI::TEST):
2278
2279 2019-03-01  Darin Adler  <darin@apple.com>
2280
2281         Finish removing String::format
2282         https://bugs.webkit.org/show_bug.cgi?id=194893
2283
2284         Reviewed by Daniel Bates.
2285 '
2286         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
2287
2288 2019-03-01  Alex Christensen  <achristensen@webkit.org>
2289
2290         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
2291         https://bugs.webkit.org/show_bug.cgi?id=195229
2292         <rdar://problem/48520362>
2293
2294         Reviewed by Chris Dumez.
2295
2296         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2297         (TEST):
2298
2299 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
2300
2301         Add a system trace scope for event region building
2302         https://bugs.webkit.org/show_bug.cgi?id=195226
2303
2304         Reviewed by Jon Lee.
2305
2306         This trace scope measures the time spend converting element rects into Region objects,
2307         which can be large on some pages.
2308
2309         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
2310
2311         * Tracing/SystemTracePoints.plist:
2312
2313 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
2314
2315         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
2316         https://bugs.webkit.org/show_bug.cgi?id=194612
2317
2318         Reviewed by Alex Christensen.
2319
2320         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2321         Just test the new string-processing function and don't touch the actual environment.
2322         (Test cases are all as before, but based on operator== instead of strcmp.)
2323
2324 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
2325
2326         [ews-app] Update primary keys for handling multiple Buildbot instances
2327         https://bugs.webkit.org/show_bug.cgi?id=195120
2328
2329         Reviewed by Stephanie Lewis.
2330
2331         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
2332         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
2333         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
2334
2335         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
2336         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
2337         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
2338         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
2339         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
2340         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
2341
2342 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
2343
2344         [WinCairo] Enable service worker
2345         https://bugs.webkit.org/show_bug.cgi?id=188318
2346
2347         Reviewed by Youenn Fablet.
2348
2349         * DumpRenderTree/DumpRenderTreePrefix.h:
2350         * TestWebKitAPI/PlatformWin.cmake:
2351         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
2352         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
2353         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
2354
2355 2019-03-01  Justin Fan  <justin_fan@apple.com>
2356
2357         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
2358         https://bugs.webkit.org/show_bug.cgi?id=195191
2359
2360         Rubber-stamped by Dean Jackson.
2361
2362         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
2363
2364         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2365
2366 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
2367
2368         Unreviewed, fix lldb webkitpy tests
2369         https://bugs.webkit.org/show_bug.cgi?id=194375
2370
2371         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
2372
2373         * lldb/lldb_webkit.py:
2374         (WTFStringImplProvider.is_8bit):
2375
2376 2019-02-28  David Quesada  <david_quesada@apple.com>
2377
2378         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
2379         https://bugs.webkit.org/show_bug.cgi?id=195121
2380         rdar://problem/48450302
2381
2382         Reviewed by Alex Christensen.
2383
2384         Add API tests for -WKNavigationAction._shouldPerformDownload in various
2385         configurations where the 'download' attribute is absent, blank, or populated
2386         with a filename, and where the anchor element is same-origin or cross-origin
2387         (meaning the 'download' attribute shouldn't be honored).
2388
2389         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2390         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
2391         (-[NavigationActionTestDelegate init]):
2392         (-[NavigationActionTestDelegate navigationAction]):
2393         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
2394         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
2395         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2396         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
2397         (TEST):
2398
2399 2019-02-28  Antoine Quint  <graouts@apple.com>
2400
2401         Enable the Pointer Events runtime flag by default
2402         https://bugs.webkit.org/show_bug.cgi?id=195156
2403
2404         Reviewed by Dean Jackson.
2405
2406         * DumpRenderTree/mac/DumpRenderTree.mm:
2407         (enableExperimentalFeatures):
2408
2409 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
2410
2411         Several PasteImage API tests are flaky
2412         https://bugs.webkit.org/show_bug.cgi?id=195160
2413
2414         Reviewed by Tim Horton.
2415
2416         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
2417         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
2418         listening for a "load" event after image load is already complete.
2419
2420         To address this, make these tests first register a "load" event handler, then run script to insert an image
2421         element into the document, and finally wait until the load event is observed before checking image size.
2422
2423         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
2424
2425 2019-02-28  Chris Dumez  <cdumez@apple.com>
2426
2427         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
2428         https://bugs.webkit.org/show_bug.cgi?id=195107
2429
2430         Reviewed by Alex Christensen.
2431
2432         Give some time for the zoom level to get restored.
2433
2434         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2435
2436 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
2437
2438         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
2439         https://bugs.webkit.org/show_bug.cgi?id=194958
2440
2441         Reviewed by Geoffrey Garen.
2442
2443         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
2444         (TEST):
2445
2446 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
2447
2448         [ews-app] Update method to save build to handle builder_display_name
2449         https://bugs.webkit.org/show_bug.cgi?id=195047
2450
2451         Reviewed by Dewei Zhu.
2452
2453         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
2454         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
2455
2456 2019-02-28  Justin Fan  <justin_fan@apple.com>
2457
2458         [Web GPU] Enable Web GPU only on 64-bit
2459         https://bugs.webkit.org/show_bug.cgi?id=195139
2460
2461         Because Metal is only supported on 64 bit apps.
2462
2463         Unreviewed build fix.
2464
2465         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2466
2467 2019-02-27  Youenn Fablet  <youenn@apple.com>
2468
2469         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
2470         https://bugs.webkit.org/show_bug.cgi?id=194959
2471
2472         Reviewed by Chris Dumez.
2473
2474         Spin loop until getting the condition to remove flakiness.
2475
2476         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2477
2478 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
2479
2480         [ews-build] Buildbot should include builder_display_name in the build events
2481         https://bugs.webkit.org/show_bug.cgi?id=195045
2482
2483         Reviewed by Dewei Zhu.
2484
2485         * BuildSlaveSupport/ews-build/events.py:
2486         (Events.buildStarted): Included builder_display_name in event data. Also renamed
2487         buildername to builder_name to be consistent in naming style.
2488         (Events.buildFinished): Ditto.
2489
2490 2019-02-27  Chris Dumez  <cdumez@apple.com>
2491
2492         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
2493         https://bugs.webkit.org/show_bug.cgi?id=194480
2494
2495         Reviewed by Brady Eidson.
2496
2497         Update existing API test to make it more likely to reproduce the issue.
2498
2499         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2500
2501 2019-02-27  Brady Eidson  <beidson@apple.com>
2502
2503         Universal links from Google search results pages don't open the app.
2504         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
2505
2506         Reviewed by Geoffrey Garen.
2507
2508         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
2509         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
2510         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2511         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2512
2513 2019-02-27  Chris Dumez  <cdumez@apple.com>
2514
2515         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
2516         https://bugs.webkit.org/show_bug.cgi?id=195102
2517
2518         Reviewed by Geoffrey Garen.
2519
2520         If the number of processes is not yet what we expect, wait a bit and check again to give
2521         processes some time to exit.
2522
2523         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2524
2525 2019-02-27  Chris Dumez  <cdumez@apple.com>
2526
2527         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
2528         https://bugs.webkit.org/show_bug.cgi?id=194545
2529
2530         Reviewed by Brady Eidson.
2531
2532         Make sure the test navigates forward and then back only once. Previously, navigating
2533         back would trigger a navigation again in a timer.
2534
2535         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2536
2537 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
2538
2539         High Sierra Debug JSC test queue should use faster hardware
2540         https://bugs.webkit.org/show_bug.cgi?id=194603
2541
2542         Rubber-stamped by Alexey Proskuryakov.
2543
2544         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
2545
2546         * BuildSlaveSupport/build.webkit.org-config/config.json:
2547         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2548         (BubbleQueueServer):
2549         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2550         (WebKitBuildbot):
2551         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2552         * QueueStatusServer/config/queues.py:
2553         * Scripts/webkitpy/common/config/ews.json:
2554         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2555         (test_ews_name):
2556
2557 2019-02-27  John Wilander  <wilander@apple.com>
2558
2559         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
2560         https://bugs.webkit.org/show_bug.cgi?id=195071
2561         <rdar://problem/48417690>
2562
2563         Reviewed by Alex Christensen and Brent Fulgham.
2564
2565         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2566         (TestWebKitAPI::createURL):
2567             Convenience function.
2568         (TestWebKitAPI::TEST):
2569             WebCore::AdClickAttribution now takes a URL when creating Source and
2570             Destination.
2571         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
2572         (TestWebKitAPI::TEST):
2573             WebCore::AdClickAttribution now takes a URL when creating Source and
2574             Destination.
2575
2576 2019-02-27  Antoine Quint  <graouts@apple.com>
2577
2578         Support Pointer Events on macOS
2579         https://bugs.webkit.org/show_bug.cgi?id=195008
2580         <rdar://problem/47454419>
2581
2582         Reviewed by Dean Jackson.
2583
2584         * DumpRenderTree/mac/DumpRenderTree.mm:
2585         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
2586         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2587
2588 2019-02-26  Mark Lam  <mark.lam@apple.com>
2589
2590         Remove remaining poisoning code.
2591         https://bugs.webkit.org/show_bug.cgi?id=194138
2592
2593         Reviewed by Saam Barati.
2594
2595         * TestWebKitAPI/CMakeLists.txt:
2596         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2597         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
2598         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
2599         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
2600         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
2601         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
2602         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
2603
2604 2019-02-26  Alex Christensen  <achristensen@webkit.org>
2605
2606         Move ephemeral local storage from WebProcess to UIProcess
2607         https://bugs.webkit.org/show_bug.cgi?id=195074
2608         <rdar://problem/47937975>
2609
2610         Reviewed by Geoff Garen.
2611
2612         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2613
2614 2019-02-20  Jer Noble  <jer.noble@apple.com>
2615
2616         [Cocoa] Media elements will restart network buffering just before suspending
2617         https://bugs.webkit.org/show_bug.cgi?id=193691
2618
2619         Reviewed by Eric Carlson.
2620
2621         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2622         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
2623         (TEST):
2624
2625 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
2626
2627         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
2628         https://bugs.webkit.org/show_bug.cgi?id=191652
2629
2630         Reviewed by Alex Christensen.
2631
2632         Fix WinCairo MiniBrowser behavior of authentication dialog.
2633
2634         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2635         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
2636
2637 2019-02-26  Youenn Fablet  <youenn@apple.com>
2638
2639         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
2640         https://bugs.webkit.org/show_bug.cgi?id=195028
2641         <rdar://problem/48243733>
2642
2643         Reviewed by Eric Carlson.
2644
2645         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2646
2647 2019-02-26  Philippe Normand  <pnormand@igalia.com>
2648
2649         [WPE] Add API for webview background color configuration
2650         https://bugs.webkit.org/show_bug.cgi?id=192305
2651
2652         Reviewed by Michael Catanzaro.
2653
2654         * MiniBrowser/wpe/main.cpp:
2655         (main): Add a new option to configure the webview background
2656         color. Example: --bg-color=transparent.
2657         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2658         (testWebViewBackgroundColor): Enable background color API tests for WPE.
2659         (beforeAll): Ditto.
2660
2661 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
2662
2663         scalableNativeWebpageParameters() is not preserved on new page navigation.
2664         https://bugs.webkit.org/show_bug.cgi?id=194892
2665         <rdar://problem/47538280>
2666
2667         Reviewed by Wenson Hsieh.
2668         
2669         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
2670
2671         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2672         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
2673         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2674         (WTR::UIScriptController::allowsViewportShrinkToFit):
2675         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2676         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2677         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
2678         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2679         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2680         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
2681
2682 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
2683
2684         [ews-app] Add model for handling multiple Buildbot instances
2685         https://bugs.webkit.org/show_bug.cgi?id=194863
2686
2687         Reviewed by Stephanie Lewis.
2688
2689         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
2690
2691 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
2692
2693         [ews-app] Remove BuilderMapping table
2694         https://bugs.webkit.org/show_bug.cgi?id=194961
2695
2696         Reviewed by Stephanie Lewis.
2697
2698         Store builder name directly in build table, instead of having a separate
2699         table for it.
2700
2701         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
2702         * BuildSlaveSupport/ews-app/ews/models/build.py:
2703         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
2704         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2705
2706 2019-02-25  John Wilander  <wilander@apple.com>
2707
2708         Introduce and adopt new class RegistrableDomain for eTLD+1
2709         https://bugs.webkit.org/show_bug.cgi?id=194791
2710         <rdar://problem/48179240>
2711
2712         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
2713
2714         This patch adds an API test and replaces two instances of
2715         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
2716
2717         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2718         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2719         (TestWebKitAPI::TEST):
2720             Changed two strings to make sure the registrable domains are still considered
2721             invalid and pass the test.
2722         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
2723         (TestWebKitAPI::TEST):
2724         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2725         (WTR::InjectedBundle::didReceiveMessageToPage):
2726
2727 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
2728
2729         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
2730         https://bugs.webkit.org/show_bug.cgi?id=195001
2731
2732         Reviewed by Carlos Garcia Campos.
2733
2734         API version 1.0 always includes the functionality previously guarded with
2735         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
2736         unconditionally.
2737
2738         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2739         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
2740         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
2741         (WebViewTest::showInWindow): Ditto.
2742         (WebViewTest::hideView): Ditto.
2743         * wpe/backends/HeadlessViewBackend.cpp:
2744         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
2745         * wpe/backends/ViewBackend.cpp:
2746         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
2747         * wpe/backends/WindowViewBackend.cpp:
2748         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
2749         WPE_BACKEND_CHECK_VERSION().
2750         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
2751
2752 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
2753
2754         [Flatpak] Add support for flatpak > 1.1.2
2755         https://bugs.webkit.org/show_bug.cgi?id=194088
2756
2757         Flatpak 1.2 is now out so we need to support that
2758         version now.
2759
2760         Reviewed by Michael Catanzaro.
2761
2762         * flatpak/flatpakutils.py:
2763         (check_flatpak):
2764         (FlatpakPackages.__init__):
2765         (FlatpakPackages.__detect_packages):
2766         (FlatpakPackages.__detect_packages.in):
2767         (FlatpakRepos.update):
2768
2769 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
2770
2771         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
2772         https://bugs.webkit.org/show_bug.cgi?id=194998
2773
2774         Reviewed by Carlos Garcia Campos.
2775
2776         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
2777         to a Git checkout and using the latest commit containing various fixes
2778         and improvements.
2779
2780 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2781
2782         [WPE][GTK] Remove user agent quirk for washingtonpost.com
2783         https://bugs.webkit.org/show_bug.cgi?id=194981
2784
2785         Reviewed by Žan Doberšek.
2786
2787         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2788         (TestWebKitAPI::TEST):
2789
2790 2019-02-23  Keith Miller  <keith_miller@apple.com>
2791
2792         Add new mac target numbers
2793         https://bugs.webkit.org/show_bug.cgi?id=194955
2794
2795         Reviewed by Tim Horton.
2796
2797         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2798         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2799         * MiniBrowser/Configurations/Base.xcconfig:
2800         * TestWebKitAPI/Configurations/Base.xcconfig:
2801         * WebKitTestRunner/Configurations/Base.xcconfig:
2802
2803 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
2804
2805         [WinCairo] Enable wk1/wk2 suffix for platform search path.
2806         https://bugs.webkit.org/show_bug.cgi?id=194846
2807
2808         Reviewed by Don Olmstead.
2809
2810         Added _search_paths() and _port_specific_expectations_files() for
2811         WinCairoPort.
2812
2813         * Scripts/webkitpy/port/win.py:
2814         (WinCairoPort.default_baseline_search_path):
2815         (WinCairoPort):
2816         (WinCairoPort._port_specific_expectations_files):
2817         (WinCairoPort._search_paths):
2818
2819 2019-02-22  Tim Horton  <timothy_horton@apple.com>
2820
2821         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
2822         https://bugs.webkit.org/show_bug.cgi?id=194963
2823
2824         Reviewed by Dean Jackson.
2825
2826         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2827         Do a `contains` check instead of `equals`, because in debug builds we
2828         put the GraphicsLayer pointer in a prefix.
2829
2830 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2831
2832         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
2833         https://bugs.webkit.org/show_bug.cgi?id=194873
2834         <rdar://problem/46701974>
2835
2836         Reviewed by Tim Horton.
2837
2838         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
2839
2840         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2841         (WTR::UIScriptController::menuRect const):
2842         (WTR::UIScriptController::isShowingMenu const):
2843         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2844         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2845         (WTR::UIScriptController::menuRect const):
2846
2847         Add a function to query the bounds of the callout menu in content coordinates.
2848
2849         (WTR::UIScriptController::isShowingMenu const):
2850
2851         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
2852
2853         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2854         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2855         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2856         (WTR::UIScriptController::rectForMenuAction const):
2857         (WTR::UIScriptController::menuRect const):
2858         (WTR::UIScriptController::isShowingMenu const):
2859         (WTR::findViewInHierarchyOfType): Deleted.
2860
2861 2019-02-22  Chris Dumez  <cdumez@apple.com>
2862
2863         Regression(PSON) Unable to preview password-protected documents on iCloud.com
2864         https://bugs.webkit.org/show_bug.cgi?id=194954
2865         <rdar://problem/48127957>
2866
2867         Reviewed by Alex Christensen.
2868
2869         Add API test coverage.
2870
2871         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2872         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
2873         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2874         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2875
2876 2019-02-22  Chris Dumez  <cdumez@apple.com>
2877
2878         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
2879         https://bugs.webkit.org/show_bug.cgi?id=194924
2880         <rdar://problem/48216125>
2881
2882         Reviewed by Geoffrey Garen.
2883
2884         Add API test coverage.
2885
2886         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2887
2888 2019-02-22  Chris Dumez  <cdumez@apple.com>
2889
2890         Unreviewed, disable API test added in r241928 on iOS.
2891
2892         The cache is not enabled on devices with less than 3GB of RAM.
2893
2894         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2895
2896 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
2897
2898         Hardcode Visual Viewports on everywhere except iOS WK1
2899         https://bugs.webkit.org/show_bug.cgi?id=194928
2900
2901         Reviewed by Zalan Bujtas.
2902
2903         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
2904         change the default value of the Setting to 'true', and hardcode WebView on iOS to
2905         set it to false. The setting has shipped for several years and there's no need to turn
2906         it off now.
2907
2908         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
2909         Visual Viewports are not enabled.
2910         
2911         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
2912         that only runs in WK2
2913
2914         * MiniBrowser/mac/SettingsController.h:
2915         * MiniBrowser/mac/SettingsController.m:
2916         (-[SettingsController init]):
2917         (-[SettingsController _populateMenu]):
2918         (-[SettingsController validateMenuItem:]):
2919         (-[SettingsController visualViewportEnabled]): Deleted.
2920         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
2921         * MiniBrowser/mac/WK1BrowserWindowController.m:
2922         (-[WK1BrowserWindowController didChangeSettings]):
2923         * MiniBrowser/mac/WK2BrowserWindowController.m:
2924         (-[WK2BrowserWindowController didChangeSettings]):
2925
2926 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
2927
2928         Discard cached processes when clearing website data store
2929         https://bugs.webkit.org/show_bug.cgi?id=194894
2930
2931         Reviewed by Chris Dumez.
2932
2933         Added a test case.
2934
2935         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2936         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
2937
2938 2019-02-21  Alex Christensen  <achristensen@webkit.org>
2939
2940         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
2941         https://bugs.webkit.org/show_bug.cgi?id=194914
2942         <rdar://problem/47586889>
2943
2944         Reviewed by Geoffrey Garen.
2945
2946         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2947         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
2948         (TEST):
2949         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
2950
2951 2019-02-21  David Kilzer  <ddkilzer@apple.com>
2952
2953         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
2954         <https://webkit.org/b/194761>
2955
2956         Reviewed by Myles Maxfield.
2957
2958         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2959         (WTR::activateSystemCoreWebFonts): Log `error` to console if
2960         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
2961         to use ARC-compliant cast.
2962         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
2963         ARC-compliant cast.
2964         (WTR::installFakeHelvetica): Log `error` to console if
2965         CTFontManagerRegisterFontsForURL() fails, but only on supported
2966         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
2967         Call CFRelease() on `error` to fix the leak.  Update to use
2968         ARC-compliant cast.
2969         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
2970         cast.
2971
2972 2019-02-21  Chris Dumez  <cdumez@apple.com>
2973
2974         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
2975         https://bugs.webkit.org/show_bug.cgi?id=194481
2976
2977         Reviewed by Alex Christensen.
2978
2979         Give the processes a chance to shutdown and wait until we reached the expected number
2980         of processes.
2981
2982         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2983
2984 2019-02-21  Tim Horton  <timothy_horton@apple.com>
2985
2986         Fix the macOS build
2987
2988         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2989
2990 2019-02-21  Tim Horton  <timothy_horton@apple.com>
2991
2992         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
2993
2994         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2995         I am a backwards.
2996
2997 2019-02-21  Tim Horton  <timothy_horton@apple.com>
2998
2999         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
3000
3001         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3002         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
3003         We could force on UI-side compositing, but I feel like the test might be more
3004         valuable exercising the normal path on each platform (though the original
3005         bug was also UI-side specific). Though we can't validate that the overlay
3006         layer was installed successfully, there are layout tests that do that.
3007
3008 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3009
3010         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
3011         https://bugs.webkit.org/show_bug.cgi?id=194845
3012         <rdar://problem/47944579>
3013
3014         Reviewed by Antti Koivisto.
3015
3016         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3017         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3018
3019 2019-02-21  Zalan Bujtas  <zalan@apple.com>
3020
3021         [LFC][Floats] Add support for placing formatting roots in-between floats.
3022         https://bugs.webkit.org/show_bug.cgi?id=194902
3023
3024         Reviewed by Antti Koivisto.
3025
3026         * LayoutReloaded/misc/LFC-passing-tests.txt:
3027
3028 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
3029
3030         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
3031         https://bugs.webkit.org/show_bug.cgi?id=194901
3032
3033         Unreviewed build fix.
3034
3035         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
3036         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
3037         WPEBackend-fdo-0.1 as library name.
3038
3039 2019-02-21  Rob Buis  <rbuis@igalia.com>
3040
3041         Update MIME type parser
3042         https://bugs.webkit.org/show_bug.cgi?id=180526
3043
3044         Reviewed by Darin Adler.
3045
3046         Add tests involving leading and trailing whitespace, non-token
3047         characters and quoted strings.
3048
3049         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3050         (TestWebKitAPI::TEST):
3051
3052 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
3053
3054         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
3055         https://bugs.webkit.org/show_bug.cgi?id=194884
3056
3057         Reviewed by Michael Catanzaro.
3058
3059         * PlatformWin.cmake:
3060
3061 2019-02-20  Chris Dumez  <cdumez@apple.com>
3062
3063         Add API test for <rdar://problem/47471222>
3064         https://bugs.webkit.org/show_bug.cgi?id=194847
3065
3066         Reviewed by Alex Christensen.
3067
3068         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3069
3070 2019-02-20  Chris Dumez  <cdumez@apple.com>
3071
3072         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
3073         https://bugs.webkit.org/show_bug.cgi?id=194872
3074         <rdar://problem/47924500>
3075
3076         Reviewed by Alex Christensen.
3077
3078         Add API test coverage.
3079
3080         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3081
3082 2019-02-20  Jer Noble  <jer.noble@apple.com>
3083
3084         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
3085         https://bugs.webkit.org/show_bug.cgi?id=191332
3086
3087         Reviewed by Dean Jackson.
3088
3089         * Scripts/git-is-in-range: Added.
3090
3091 2019-02-20  Andy Estes  <aestes@apple.com>
3092
3093         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
3094         https://bugs.webkit.org/show_bug.cgi?id=194869
3095
3096         Rubber-stamped by Jer Noble.
3097
3098         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3099         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
3100         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3101         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
3102         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3103         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3104
3105 2019-02-20  Chris Dumez  <cdumez@apple.com>
3106
3107         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
3108         https://bugs.webkit.org/show_bug.cgi?id=194857
3109         <rdar://problem/47759323>
3110
3111         Reviewed by Alex Christensen.
3112
3113         Add API test coverage.
3114
3115         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3116
3117 2019-02-20  Chris Dumez  <cdumez@apple.com>
3118
3119         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
3120         https://bugs.webkit.org/show_bug.cgi?id=194829
3121         <rdar://problem/47889906>
3122
3123         Reviewed by Alexey Proskuryakov.
3124
3125         Every time the TestOptions were changing we were creating both a new Web view and
3126         a new WKContext, which would start a new Network process. In most cases, we only
3127         need to contruct a new Web view and we do can keep reusing the same WKContext.
3128         This patch implements this optimization and thus avoids spinning a lot of new
3129         Network processes while running the layout tests.
3130
3131         * WebKitTestRunner/TestController.cpp:
3132         (WTR::TestController::generateContextConfiguration const):
3133         (WTR::TestController::generatePageConfiguration):
3134         (WTR::TestController::createWebViewWithOptions):
3135         (WTR::TestController::resetPreferencesToConsistentValues):
3136         (WTR::updateTestOptionsFromTestHeader):
3137         * WebKitTestRunner/TestController.h:
3138         * WebKitTestRunner/TestOptions.h:
3139         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
3140         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
3141         (WTR::TestOptions::hasSameInitializationOptions const):
3142         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
3143         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3144         (WTR::TestController::platformAddTestOptions const):
3145
3146 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
3147
3148         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
3149         https://bugs.webkit.org/show_bug.cgi?id=167941
3150
3151         Reviewed by Carlos Garcia Campos.
3152
3153         * MiniBrowser/gtk/main.c:
3154         (filterSavedCallback): Added.
3155         (main): Support loading a JSON rule set file for content filtering.
3156         * MiniBrowser/wpe/main.cpp:
3157         (filterSavedCallback): Added.
3158         (main): Support loading a JSON rule set file for content filtering.
3159         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
3160         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
3161         (WTF::derefGPtr): Ditto.
3162         (testEmptyStore):
3163         (testSaveInvalidFilter):
3164         (testSaveLoadFilter):
3165         (testSavedFilterIdentifierMatch):
3166         (testRemoveFilter):
3167         (testSaveMultipleFilters):
3168         (testSaveFilterFromFile):
3169         (testFilterPersistence):
3170         (beforeAll):
3171         (afterAll):
3172         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
3173         (removeOldInjectedContentAndResetLists): Also reset content filters.
3174         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
3175         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
3176         the element affected by the style sheet.
3177         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
3178         and returns it to be used by tests.
3179         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
3180         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
3181         (serverCallback): Add support for serving a CSS style sheet for testing.
3182         (beforeAll): Add call to testUserContentManagerContentFilter().
3183         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
3184
3185 2019-02-19  Keith Rollin  <krollin@apple.com>
3186
3187         Add timing information to build output
3188         https://bugs.webkit.org/show_bug.cgi?id=194839
3189         <rdar://problem/48219609>
3190
3191         Reviewed by Alexey Proskuryakov.
3192
3193         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
3194         emit each project's build time to its output. E.g.,
3195
3196             ** BUILD SUCCEEDED ** [0.132 sec]
3197
3198         * Scripts/webkitdirs.pm:
3199         (XcodeOptions):
3200
3201 2019-02-19  Truitt Savell  <tsavell@apple.com>
3202
3203         Unreviewed, rolling out r241784.
3204
3205         Broke all OpenSource builds.
3206
3207         Reverted changeset:
3208
3209         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
3210         instances view"
3211         https://bugs.webkit.org/show_bug.cgi?id=172848
3212         https://trac.webkit.org/changeset/241784
3213
3214 2019-02-19  Zalan Bujtas  <zalan@apple.com>
3215
3216         [LFC][Floats] Remove redundant intersecting logic
3217         https://bugs.webkit.org/show_bug.cgi?id=194804
3218
3219         Reviewed by Antti Koivisto.
3220
3221         * LayoutReloaded/misc/LFC-passing-tests.txt:
3222
3223 2019-02-19  Dean Jackson  <dino@apple.com>
3224
3225         Clean-up output from generate-xcfilelists so it can be filtered
3226         https://bugs.webkit.org/show_bug.cgi?id=194795
3227
3228         Reviewed by Joseph Pecoraro (and Keith Rollin).
3229
3230         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
3231         make a slight tweak to filter-build-webkit so such lines are marked
3232         as plain.
3233
3234         * Scripts/filter-build-webkit:
3235         * Scripts/generate-xcfilelists:
3236
3237 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
3238
3239         pytest is not correctly auto-installed
3240         https://bugs.webkit.org/show_bug.cgi?id=194707
3241
3242         Reviewed by Carlos Garcia Campos.
3243
3244         * Scripts/webkitpy/thirdparty/__init__.py:
3245         (AutoinstallImportHook._install_pytest):
3246
3247 2019-02-18  Chris Dumez  <cdumez@apple.com>
3248
3249         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
3250         https://bugs.webkit.org/show_bug.cgi?id=194797
3251         <rdar://problem/48055151>
3252
3253         Reviewed by Geoffrey Garen.
3254
3255         Add API test coverage.
3256
3257         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3258
3259 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3260
3261         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
3262         https://bugs.webkit.org/show_bug.cgi?id=194670
3263         <rdar://problem/39066529>
3264
3265         Reviewed by Tim Horton.
3266
3267         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
3268         pasted in an editable area as attachment elements.
3269
3270         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
3271         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3272         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
3273         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3274         (TestWebKitAPI::TEST):
3275         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3276         (WTR::InjectedBundlePage::InjectedBundlePage):
3277
3278 2019-02-18  Alex Christensen  <achristensen@webkit.org>
3279
3280         Fix API test after r241728
3281        ​https://bugs.webkit.org/show_bug.cgi?id=194723
3282
3283         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3284         (TEST):
3285         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
3286
3287 2019-02-18  Daniel Bates  <dabates@apple.com>
3288
3289         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
3290         https://bugs.webkit.org/show_bug.cgi?id=192824
3291         <rdar://problem/47100332>
3292
3293         Reviewed by Wenson Hsieh.
3294
3295         Fix a bug where the wrong usage code was used for F13 thru F24.
3296
3297         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3298         (keyCodeForDOMFunctionKey):
3299
3300 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
3301
3302         Bytecode cache should a have a boot-specific validation
3303         https://bugs.webkit.org/show_bug.cgi?id=194769
3304         <rdar://problem/48149509>
3305
3306         Reviewed by Keith Miller.
3307
3308         Add test for WTF::bootSessionUUIDString()
3309
3310         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3311         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
3312         (TEST):
3313
3314 2019-02-18  Alex Christensen  <achristensen@webkit.org>
3315
3316         Disable safe browsing in WKWebView and remove its WKPreferences API
3317         https://bugs.webkit.org/show_bug.cgi?id=194723
3318         <rdar://problem/48122993>
3319
3320         Reviewed by Geoffrey Garen.
3321
3322         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3323         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3324         (TEST):
3325         (safeBrowsingView):
3326         Make tests use SPI instead of API.
3327
3328 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
3329
3330         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
3331         https://bugs.webkit.org/show_bug.cgi?id=194586
3332
3333         Reviewed by Ross Kirsling.
3334
3335         * DumpRenderTree/win/DumpRenderTree.cpp:
3336         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
3337         * Scripts/webkitpy/port/driver.py:
3338         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
3339
3340 2019-02-17  David Kilzer  <ddkilzer@apple.com>
3341
3342         Unreviewed, rolling out r241620.
3343
3344         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
3345         (Requested by ddkilzer on #webkit.)
3346
3347         Reverted changeset:
3348
3349         "[WTF] Add environment variable helpers"
3350         https://bugs.webkit.org/show_bug.cgi?id=192405
3351         https://trac.webkit.org/changeset/241620
3352
3353 2019-02-16  Zalan Bujtas  <zalan@apple.com>
3354
3355         [LFC] RenderImage's default intrinsic size is 0.
3356         https://bugs.webkit.org/show_bug.cgi?id=194745
3357
3358         Reviewed by Antti Koivisto.
3359
3360         * LayoutReloaded/misc/LFC-passing-tests.txt:
3361
3362 2019-02-16  Zalan Bujtas  <zalan@apple.com>
3363
3364         [LFC][BFC] Add support for block replaced intrinsic width.
3365         https://bugs.webkit.org/show_bug.cgi?id=194705
3366
3367         Reviewed by Simon Fraser.
3368
3369         * LayoutReloaded/misc/LFC-passing-tests.txt:
3370
3371 2019-02-16  Zalan Bujtas  <zalan@apple.com>
3372
3373         [LFC] Apply min/max width constraints to preferred width computation
3374         https://bugs.webkit.org/show_bug.cgi?id=194739
3375
3376         Reviewed by Simon Fraser.
3377
3378         * LayoutReloaded/misc/LFC-passing-tests.txt:
3379
3380 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
3381
3382         [WTF] Add environment variable helpers
3383         https://bugs.webkit.org/show_bug.cgi?id=192405
3384
3385         Reviewed by Michael Catanzaro.
3386
3387         * DumpRenderTree/mac/DumpRenderTree.mm:
3388         (libraryPathForDumpRenderTree):
3389         * DumpRenderTree/win/DumpRenderTree.cpp:
3390         (libraryPathForDumpRenderTree):
3391         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
3392         (setUpIOSLayoutTestCommunication):
3393         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
3394         (beforeAll):
3395         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
3396         (main):
3397         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
3398         (WebKitTestBus::run):
3399         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3400         (WTR::getOutputDir):
3401         (WTR::initializeFontConfigSetting):
3402         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
3403         (WTR::InjectedBundle::platformInitialize):
3404         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
3405         (WTR::topLevelPath):
3406         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
3407         (WTR::topLevelPath):
3408         (WTR::getOutputDir):
3409         (WTR::activateFonts):
3410         * WebKitTestRunner/TestController.cpp:
3411         (WTR::TestController::libraryPathForTesting):
3412         (WTR::TestController::generateContextConfiguration const):
3413         (WTR::TestController::generatePageConfiguration):
3414         (WTR::TestController::decideDestinationWithSuggestedFilename):
3415         (WTR::TestController::platformAdjustContext):
3416         * WebKitTestRunner/TestController.h:
3417         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3418         (WTR::TestController::cocoaPlatformInitialize):
3419         (WTR::TestController::platformAdjustContext):
3420         * WebKitTestRunner/gtk/main.cpp:
3421         (main):
3422         * WebKitTestRunner/mac/TestControllerMac.mm:
3423         (WTR::TestController::configureContentExtensionForTest):
3424         * WebKitTestRunner/wpe/main.cpp:
3425         (main):
3426         Utilize WTF::Environment where possible.
3427
3428 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3429
3430         [iOS] WKWebView callout bar is missing Change Writing Direction item
3431         https://bugs.webkit.org/show_bug.cgi?id=190015
3432         <rdar://problem/44810366>
3433
3434         Reviewed by Tim Horton.
3435
3436         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
3437         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
3438
3439         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
3440         (TestWebKitAPI::TEST):
3441
3442 2019-02-15  Chris Dumez  <cdumez@apple.com>
3443
3444         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
3445         https://bugs.webkit.org/show_bug.cgi?id=194717
3446         <rdar://problem/47884404>
3447
3448         Reviewed by Brady Eidson.
3449
3450         Add API test coverage.
3451
3452         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3453
3454 2019-02-15  Youenn Fablet  <youenn@apple.com>
3455
3456         Make navigator.mediaDevices SecureContext
3457         https://bugs.webkit.org/show_bug.cgi?id=194666
3458
3459         Reviewed by Eric Carlson.
3460
3461         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
3462         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
3463         (TEST_F):
3464
3465 2019-02-15  Brian Burg  <bburg@apple.com>
3466
3467         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
3468         https://bugs.webkit.org/show_bug.cgi?id=194411
3469         <rdar://problem/47787614>
3470
3471         Reviewed by Joseph Pecoraro.
3472
3473         Remove unnecessary soft linking macro usage.
3474
3475         * DumpRenderTree/mac/TestRunnerMac.mm:
3476         (TestRunner::inspectorTestStubURL):
3477         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
3478         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
3479         (WTR::TestRunner::inspectorTestStubURL):
3480
3481 2019-02-15  Commit Queue  <commit-queue@webkit.org>
3482
3483         Unreviewed, rolling out r241559 and r241566.
3484         https://bugs.webkit.org/show_bug.cgi?id=194710
3485
3486         Causes layout test crashes under GuardMalloc (Requested by
3487         ryanhaddad on #webkit).
3488
3489         Reverted changesets:
3490
3491         "[WTF] Add environment variable helpers"
3492         https://bugs.webkit.org/show_bug.cgi?id=192405
3493         https://trac.webkit.org/changeset/241559
3494
3495         "Unreviewed build fix for WinCairo Debug after r241559."
3496         https://trac.webkit.org/changeset/241566
3497
3498 2019-02-15  Zalan Bujtas  <zalan@apple.com>
3499
3500         [LFC] Out-of-flow box is never a float box
3501         https://bugs.webkit.org/show_bug.cgi?id=194704
3502
3503         Reviewed by Antti Koivisto.
3504
3505         * LayoutReloaded/misc/LFC-passing-tests.txt:
3506
3507 2019-02-10  Darin Adler  <darin@apple.com>
3508
3509         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
3510         https://bugs.webkit.org/show_bug.cgi?id=194487
3511
3512         Reviewed by Daniel Bates.
3513
3514         * DumpRenderTree/win/DumpRenderTree.cpp:
3515         (applicationId): Use makeString instead of String::format.
3516         (main): Ditto.
3517         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3518         (TestWebKitAPI::Util::createURLForResource): Ditto.
3519         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3520         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
3521
3522         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3523         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
3524         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
3525         (WTR::createStringWithAttributes): Use appendLiteral.
3526         (WTR::AccessibilityUIElement::helpText const): Ditto.
3527         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
3528         directly instead of using String::format.
3529         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
3530         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
3531
3532 2019-02-15  Truitt Savell  <tsavell@apple.com>
3533
3534         Unreviewed, rolling out r241564.
3535
3536         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
3537
3538         Reverted changeset:
3539
3540         "[Mac] WebInspectorUI.framework does not need to be soft-
3541         linked anymore"
3542         https://bugs.webkit.org/show_bug.cgi?id=194411
3543         https://trac.webkit.org/changeset/241564
3544
3545 2019-02-15  Saam barati  <sbarati@apple.com>
3546
3547         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
3548         https://bugs.webkit.org/show_bug.cgi?id=194036
3549
3550         Reviewed by Yusuke Suzuki.
3551
3552         * Scripts/run-jsc-stress-tests:
3553
3554 2019-02-14  Tim Horton  <timothy_horton@apple.com>
3555
3556         Fix the build.
3557
3558         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3559         (WTR::UIScriptController::drawSquareInEditableImage):
3560         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3561         (TestWebKitAPI::drawSquareInEditableImage):
3562
3563 2019-02-14  Tim Horton  <timothy_horton@apple.com>
3564
3565         Fix the build.
3566
3567         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3568         (WTR::UIScriptController::drawSquareInEditableImage):
3569         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3570         (TestWebKitAPI::drawSquareInEditableImage):
3571
3572 2019-02-14  Brian Burg  <bburg@apple.com>
3573
3574         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
3575         https://bugs.webkit.org/show_bug.cgi?id=194411
3576         <rdar://problem/47787614>
3577
3578         Reviewed by Joseph Pecoraro.
3579
3580         Remove unnecessary soft linking macro usage.
3581
3582         * DumpRenderTree/mac/TestRunnerMac.mm:
3583         (TestRunner::inspectorTestStubURL):
3584         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
3585         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
3586         (WTR::TestRunner::inspectorTestStubURL):
3587
3588 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
3589
3590         [ews-app] status bubble should fetch builder name info from BuilderMapping table
3591         https://bugs.webkit.org/show_bug.cgi?id=194599
3592
3593         Reviewed by Lucas Forschler.
3594
3595         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3596         (StatusBubble._build_bubble):
3597
3598 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
3599
3600         [ews-app] Set Foreign Key in Django build model
3601         https://bugs.webkit.org/show_bug.cgi?id=194667
3602
3603         Reviewed by Lucas Forschler.
3604
3605         * BuildSlaveSupport/ews-app/ews/models/build.py:
3606         (Build):
3607
3608 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
3609
3610         [WTF] Add environment variable helpers
3611         https://bugs.webkit.org/show_bug.cgi?id=192405
3612
3613         Reviewed by Michael Catanzaro.
3614
3615         * DumpRenderTree/mac/DumpRenderTree.mm:
3616         (libraryPathForDumpRenderTree):
3617         * DumpRenderTree/win/DumpRenderTree.cpp:
3618         (libraryPathForDumpRenderTree):
3619         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
3620         (setUpIOSLayoutTestCommunication):
3621         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3622         (TestWebKitAPI::strip):
3623         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
3624         (beforeAll):
3625         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
3626         (main):
3627         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
3628         (WebKitTestBus::run):
3629         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3630         (WTR::getOutputDir):
3631         (WTR::initializeFontConfigSetting):
3632         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
3633         (WTR::InjectedBundle::platformInitialize):
3634         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
3635         (WTR::topLevelPath):
3636         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
3637         (WTR::topLevelPath):
3638         (WTR::getOutputDir):
3639         (WTR::activateFonts):
3640         * WebKitTestRunner/TestController.cpp:
3641         (WTR::TestController::libraryPathForTesting):
3642         (WTR::TestController::generateContextConfiguration const):
3643         (WTR::TestController::generatePageConfiguration):
3644         (WTR::TestController::decideDestinationWithSuggestedFilename):
3645         (WTR::TestController::platformAdjustContext):
3646         * WebKitTestRunner/TestController.h:
3647         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3648         (WTR::TestController::cocoaPlatformInitialize):
3649         (WTR::TestController::platformAdjustContext):
3650         * WebKitTestRunner/gtk/main.cpp:
3651         (main):
3652         * WebKitTestRunner/mac/TestControllerMac.mm:
3653         (WTR::TestController::configureContentExtensionForTest):
3654         * WebKitTestRunner/wpe/main.cpp:
3655         (main):
3656         Utilize WTF::Environment where possible.
3657
3658 2019-02-14  Chris Dumez  <cdumez@apple.com>
3659
3660         [PSON] Introduce a WebContent Process cache
3661         https://bugs.webkit.org/show_bug.cgi?id=194594
3662         <rdar://problem/46793397>
3663
3664         Reviewed by Geoff Garen.
3665
3666         Update API tests to turn on the WebContent Process cache.
3667
3668         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3669
3670 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
3671
3672         Unreviewed, build fix after r241480
3673
3674         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3675         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
3676         (-[DragAndDropSimulator initWithWebView:]):
3677
3678 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
3679
3680         AX: ARIA Reflection was disabled in error
3681         https://bugs.webkit.org/show_bug.cgi?id=194647
3682         <rdar://problem/48068336>
3683
3684         Reviewed by Ryosuke Niwa.
3685
3686         Remove test override now that this feature should be enabled by default.
3687
3688         * WebKitTestRunner/TestController.cpp:
3689         (WTR::TestController::resetPreferencesToConsistentValues):
3690
3691 2019-02-14  Commit Queue  <commit-queue@webkit.org>
3692
3693         Unreviewed, rolling out r241486.
3694         https://bugs.webkit.org/show_bug.cgi?id=194655
3695
3696         causing API failures in builds (Requested by ShawnRoberts on
3697         #webkit).
3698
3699         Reverted changeset:
3700
3701         "[Cocoa] Media elements will restart network buffering just
3702         before suspending"
3703         https://bugs.webkit.org/show_bug.cgi?id=193691
3704         https://trac.webkit.org/changeset/241486
3705
3706 2019-02-14  Zalan Bujtas  <zalan@apple.com>
3707
3708         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
3709         https://bugs.webkit.org/show_bug.cgi?id=194622
3710
3711         Reviewed by Antti Koivisto.
3712
3713         * LayoutReloaded/misc/LFC-passing-tests.txt:
3714