cc36242d274e42dc3d9149854272480155f7866a
[WebKit-https.git] / Tools / ChangeLog
1 2018-11-13  Ryosuke Niwa  <rniwa@webkit.org>
2
3         WebKit.GeolocationTransitionToLowAccuracy API crashes when enabling PSON
4         https://bugs.webkit.org/show_bug.cgi?id=191616
5
6         Reviewed by Chris Dumez.
7
8         The crash was caused by WKView in autorelease pool invoking stopUpdatingCallback after
9         GeolocationTransitionToLowAccuracyStateTracker in the stack had been destroyed,
10         resulting in the use-after-free.
11
12         Made the tests more robust by clearing geolocation provider before exiting each test
13         since we can't really prevent WKView from entering an autorelease pool.
14
15         Also made WebKit.GeolocationTransitionToLowAccuracy wait for the success callback
16         instead of simply the end of the navigation so that the test would continue to work
17         even if a web content process was created for the second web view (lowAccuracyWebView)
18
19         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
20         (TestWebKitAPI::setupGeolocationProvider): Moved "*" to match the WebKit coding style guideline.
21         (TestWebKitAPI::clearGeolocationProvider): Added.
22         (TestWebKitAPI::runJavaScriptAlert): Added.
23         (TestWebKitAPI::didFinishNavigation): Deleted.
24         * TestWebKitAPI/Tests/WebKit/geolocationWatchPosition.html:
25
26 2018-11-13  Chris Dumez  <cdumez@apple.com>
27
28         WKProcessPool.InitialWarmedProcessUsed API is failing with PSON enabled
29         https://bugs.webkit.org/show_bug.cgi?id=191618
30
31         Reviewed by Ryosuke Niwa.
32
33         Update API test to explicitly disable automatic process prewarning since it is testing
34         manual prewarming.
35
36         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
37         (TEST):
38
39 2018-11-13  Chris Dumez  <cdumez@apple.com>
40
41         Several Service Worker API tests are failing when enabling PSON
42         https://bugs.webkit.org/show_bug.cgi?id=191619
43
44         Reviewed by Youenn Fablet.
45
46         Update tests to use _webProcessCountIgnoringPrewarmed instead of _webProcessCount so that they are
47         not impacted by process prewarming.
48
49         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
50
51 2018-11-13  Wenson Hsieh  <wenson_hsieh@apple.com>
52
53         [iOS] Do not show selection UI for editable elements with opacity near zero
54         https://bugs.webkit.org/show_bug.cgi?id=191442
55         <rdar://problem/45958625>
56
57         Reviewed by Simon Fraser.
58
59         Add a couple of new testing helpers to UIScriptController.
60
61         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
62         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
63         (WTR::UIScriptController::textSelectionRangeRects const):
64         (WTR::UIScriptController::selectionCaretViewRect const):
65         (WTR::UIScriptController::selectionRangeViewRects const):
66         * TestRunnerShared/UIScriptContext/UIScriptController.h:
67         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
68         (WTR::UIScriptController::textSelectionRangeRects const):
69
70         Rename `selectionRangeViewRects` to `textSelectionRangeRects`. This allows us to draw a distinction between
71         `textSelectionRangeRects`/`textSelectionCaretRect`, which retrieve information about selection rects known
72         to the text interaction assistant, and `selectionCaretViewRect`/`selectionRangeViewRects`, which retrieve the
73         actual frames of the selection views used to draw overlaid selection UI. This difference is important in the
74         new layout tests added in this patch, which only suppress caret rendering (i.e. selection views remain hidden).
75
76         Also, drive-by fix a leaked `NSMutableArray`.
77
78         (WTR::UIScriptController::selectionStartGrabberViewRect const):
79         (WTR::UIScriptController::selectionEndGrabberViewRect const):
80         (WTR::UIScriptController::selectionCaretViewRect const):
81         (WTR::UIScriptController::selectionRangeViewRects const):
82
83         Testing helpers to grab the frames of caret and selection views, in WKContentView's coordinate space. These
84         rects are also clamped to WKContentView bounds.
85
86 2018-11-13  Daniel Bates  <dabates@apple.com>
87
88         Consolidate WebKit UIKitSPI.h and UIKitTestSPI.h
89         https://bugs.webkit.org/show_bug.cgi?id=173341
90         <rdar://problem/32752890>
91
92         Reviewed by Simon Fraser.
93
94         There is little value to making a distinction between forward declarations
95         of UIKit SPI needed in the WebKit layer and just for testing. Moreover,
96         the contents of these two headers can conflict with each other following
97         r218275 as DumpRenderTree includes both headers. Instead we should remove
98         UIKitTestSPI.h and have WebKitTestRunner include the WebKit variant, UIKitSPI.h.
99
100         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
101         * DumpRenderTree/mac/DumpRenderTree.mm:
102         * TestRunnerShared/spi/UIKitTestSPI.h: Removed.
103         * WebKitTestRunner/Configurations/Base.xcconfig:
104         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
105         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
106         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
107         * WebKitTestRunner/ios/HIDEventGenerator.h:
108         * WebKitTestRunner/ios/HIDEventGenerator.mm:
109         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
110         * WebKitTestRunner/ios/TestControllerIOS.mm:
111         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
112         * WebKitTestRunner/ios/mainIOS.mm:
113
114 2018-11-13  Takashi Komori  <Takashi.Komori@sony.com>
115
116         Remove WebKitTestRunnerLib's build warnings.
117         https://bugs.webkit.org/show_bug.cgi?id=191580
118
119         Reviewed by Fujii Hironori.
120
121         Include cmakeconfig.h in precompiled header.
122
123         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
124
125 2018-11-12  Darshan Kadu  <darsh7807@gmail.com>
126
127         Implement Cache API support for WPE/GTK
128         https://bugs.webkit.org/show_bug.cgi?id=178316
129
130         Reviewed by Michael Catanzaro.
131
132         Called WKWebsiteDataStoreSetCacheStoragePerOriginQuota function to set the cache limit to 400 * 1200
133         on all the platforms in TestController.cpp. Also, removed the setCacheStoragePerOriginQuota call from TestControllerCocoa.mm
134
135         * WebKitTestRunner/TestController.cpp:
136         (WTR::TestController::generatePageConfiguration):
137         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
138         (WTR::initializeWebViewConfiguration):
139
140 2018-11-12  Christopher Reid  <chris.reid@sony.com>
141
142         [Curl] Reject entire cookie if the domain fails a tailmatch.
143         https://bugs.webkit.org/show_bug.cgi?id=191406
144
145         Reviewed by Youenn Fablet.
146
147         Added unittests for Curl cookie implementation.
148
149         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
150         (TestWebKitAPI::Curl::CurlCookies::RejectTailmatchFailureDomain):
151
152 2018-11-12  Alex Christensen  <achristensen@webkit.org>
153
154         [iOS] Implement safe browsing in WebKit
155         https://bugs.webkit.org/show_bug.cgi?id=191441
156
157         Reviewed by Tim Horton.
158
159         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
160         (checkTitleAndClick):
161         (TEST):
162
163 2018-11-12  Basuke Suzuki  <basuke.suzuki@sony.com>
164
165         [Curl] Add API Test for Curl cookie backend.
166         https://bugs.webkit.org/show_bug.cgi?id=191493
167
168         Reviewed by Youenn Fablet.
169
170         Add unit test to TestWebCore.
171
172         * TestWebKitAPI/PlatformWin.cmake:
173         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp: Added.
174
175 2018-11-12  Tim Horton  <timothy_horton@apple.com>
176
177         Make it possible to edit images inline
178         https://bugs.webkit.org/show_bug.cgi?id=191352
179         <rdar://problem/30107985>
180
181         Reviewed by Dean Jackson.
182
183         * WebKitTestRunner/TestController.cpp:
184         (WTR::updateTestOptionsFromTestHeader):
185         * WebKitTestRunner/TestOptions.h:
186         (WTR::TestOptions::hasSameInitializationOptions const):
187         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
188         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
189         (WTR::TestController::platformCreateWebView):
190         Add a test option to enable editable images.
191
192         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
193         (WTR::UIScriptController::drawSquareInEditableImage):
194         (WTR::UIScriptController::numberOfStrokesInEditableImage):
195         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
196         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
197         (WTR::UIScriptController::drawSquareInEditableImage):
198         (WTR::UIScriptController::numberOfStrokesInEditableImage):
199         * TestRunnerShared/UIScriptContext/UIScriptController.h:
200         * TestRunnerShared/spi/PencilKitTestSPI.h: Added.
201         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
202         (WTR::findEditableImageCanvas):
203         (WTR::UIScriptController::drawSquareInEditableImage):
204         (WTR::UIScriptController::numberOfStrokesInEditableImage):
205         Add the ability to draw on a PKCanvasView that is a subview of the WKWebView,
206         and also to retrieve the number of strokes currently on the PKCanvasView.
207         Currently this just takes the first canvas; we might need to make it
208         take an identifier or something in the future if we need tests with multiple
209         canvases. The indirect testing mechanism is required because PKCanvasView
210         can currently not actually paint its strokes in the Simulator.
211
212 2018-11-12  Ryan Haddad  <ryanhaddad@apple.com>
213
214         [MediaStream] Screen capture should be an experimental feature on OSX only
215         https://bugs.webkit.org/show_bug.cgi?id=191552
216
217         Unreviewed test gardening.
218
219         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm: Only run these tests on macOS.
220
221 2018-11-12  Don Olmstead  <don.olmstead@sony.com>
222
223         Shipped PNGs include bad profiles: iCCP: known incorrect sRGB profile
224         https://bugs.webkit.org/show_bug.cgi?id=189230
225         <rdar://problem/44050379>
226
227         Reviewed by Joseph Pecoraro.
228
229         Runs all png images through zopflipng. This results in a smaller file
230         size and takes care of this issue as a byproduct.
231
232         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-green.png:
233         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-red.png:
234         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan.png:
235         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan@2x.png:
236         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK.png:
237         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK@2x.png:
238         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra.png:
239         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra@2x.png:
240         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10.png:
241         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10@2x.png:
242         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10Simulator.png:
243         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10Simulator@2x.png:
244         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11.png:
245         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11@2x.png:
246         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator.png:
247         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator@2x.png:
248         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12.png:
249         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12@2x.png:
250         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12Simulator.png:
251         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12Simulator@2x.png:
252         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9.png:
253         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9@2x.png:
254         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator.png:
255         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator@2x.png:
256         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice.png:
257         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice@2x.png:
258         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSSimulator.png:
259         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSSimulator@2x.png:
260         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks.png:
261         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks@2x.png:
262         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mojave.png:
263         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mojave@2x.png:
264         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png:
265         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png:
266         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing.png:
267         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing@2x.png:
268         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
269         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
270         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png:
271         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE@2x.png:
272         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows10.png:
273         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows10@2x.png:
274         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7.png:
275         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7@2x.png:
276         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8.png:
277         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8@2x.png:
278         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP.png:
279         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP@2x.png:
280         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite.png:
281         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite@2x.png:
282
283 2018-11-12  Tim Horton  <timothy_horton@apple.com>
284
285         Modernize WebKit Tools Xcode projects for localization's sake
286         https://bugs.webkit.org/show_bug.cgi?id=191495
287
288         Reviewed by Alexey Proskuryakov.
289
290         * ContentExtensionTester/ContentExtensionTester.xcodeproj/project.pbxproj:
291         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
292         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj:
293         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj:
294         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
295         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
296         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
297         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
298         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
299         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
300         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
301         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj:
302         These are less important because they're not localized, but since
303         I made the style checker complain, it now complains any time anyone
304         touches any of these projects... so upgrade them.
305
306 2018-11-12  Jonathan Bedard  <jbedard@apple.com>
307
308         webkitpy: Check for specific process instead of using data migrator
309         https://bugs.webkit.org/show_bug.cgi?id=191551
310         <rdar://problem/45993156>
311
312         Rubber-stamped by Aakash Jain.
313
314         It's possible for the data migrator process to be stuck, but for a simulator to be
315         usable. Use device-specific processes to detect when a device is usable.
316
317         * Scripts/webkitpy/xcode/simulated_device.py:
318         (SimulatedDeviceManager._wait_until_device_is_usable):
319         (SimulatedDeviceManager):
320         (SimulatedDeviceManager.initialize_devices): Explicitly wait until a device is usable
321         since this implies that a device is booted.
322         (SimulatedDeviceManager.swap): Ditto.
323         (SimulatedDevice.is_usable): Check that a device is booted and that a device-specific
324         process indicating the device is usable can be found.
325         (SimulatedDeviceManager.wait_until_data_migration_is_done): Deleted.
326         * Scripts/webkitpy/xcode/simulated_device_unittest.py: Update simctl_json so that
327         it triggers the logic in is_usable()
328
329 2018-11-12  Takashi Komori  <Takashi.Komori@sony.com>
330
331         Resurrect WebKitTestRunner for Windows port
332         https://bugs.webkit.org/show_bug.cgi?id=189257
333
334         Reviewed by Fujii Hironori.
335
336         Implement WebKitTestRunner for WinCairo.
337
338         * PlatformWin.cmake:
339         * Scripts/build-webkittestrunner:
340         * WebKitTestRunner/CMakeLists.txt:
341         * WebKitTestRunner/EventSenderProxy.h:
342         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
343         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
344         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
345         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
346         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
347         (WTR::rangeToStr):
348         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
349         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
350         (WTR::TestRunner::TestRunner):
351         * WebKitTestRunner/InjectedBundle/TestRunner.h:
352         * WebKitTestRunner/InjectedBundle/win/AccessibilityControllerWin.cpp: Added.
353         (WTR::AccessibilityController::resetToConsistentState):
354         (WTR::AccessibilityController::accessibleElementById):
355         (WTR::AccessibilityController::platformName):
356         (WTR::AccessibilityController::rootElement):
357         (WTR::AccessibilityController::focusedElement):
358         (WTR::AccessibilityController::addNotificationListener):
359         (WTR::AccessibilityController::removeNotificationListener):
360         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp: Added.
361         (WTR::AccessibilityUIElement::AccessibilityUIElement):
362         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
363         (WTR::AccessibilityUIElement::isEqual):
364         (WTR::AccessibilityUIElement::getChildren):
365         (WTR::AccessibilityUIElement::getChildrenWithRange):
366         (WTR::AccessibilityUIElement::childrenCount):
367         (WTR::AccessibilityUIElement::elementAtPoint):
368         (WTR::AccessibilityUIElement::indexOfChild):
369         (WTR::AccessibilityUIElement::childAtIndex):
370         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
371         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
372         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
373         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
374         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
375         (WTR::AccessibilityUIElement::rowAtIndex):
376         (WTR::AccessibilityUIElement::selectedChildAtIndex const):
377         (WTR::AccessibilityUIElement::selectedChildrenCount const):
378         (WTR::AccessibilityUIElement::selectedRowAtIndex):
379         (WTR::AccessibilityUIElement::titleUIElement):
380         (WTR::AccessibilityUIElement::parentElement):
381         (WTR::AccessibilityUIElement::disclosedByRow):
382         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
383         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
384         (WTR::AccessibilityUIElement::attributesOfChildren):
385         (WTR::AccessibilityUIElement::allAttributes):
386         (WTR::AccessibilityUIElement::stringAttributeValue):
387         (WTR::AccessibilityUIElement::numberAttributeValue):
388         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
389         (WTR::AccessibilityUIElement::rowHeaders const):
390         (WTR::AccessibilityUIElement::columnHeaders const):
391         (WTR::AccessibilityUIElement::uiElementAttributeValue const):
392         (WTR::AccessibilityUIElement::boolAttributeValue):
393         (WTR::AccessibilityUIElement::isAttributeSettable):
394         (WTR::AccessibilityUIElement::isAttributeSupported):
395         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
396         (WTR::AccessibilityUIElement::role):
397         (WTR::AccessibilityUIElement::subrole):
398         (WTR::AccessibilityUIElement::roleDescription):
399         (WTR::AccessibilityUIElement::computedRoleString):
400         (WTR::AccessibilityUIElement::title):
401         (WTR::AccessibilityUIElement::description):
402         (WTR::AccessibilityUIElement::orientation const):
403         (WTR::AccessibilityUIElement::stringValue):
404         (WTR::AccessibilityUIElement::language):
405         (WTR::AccessibilityUIElement::helpText const):
406         (WTR::AccessibilityUIElement::x):
407         (WTR::AccessibilityUIElement::y):
408         (WTR::AccessibilityUIElement::width):
409         (WTR::AccessibilityUIElement::height):
410         (WTR::AccessibilityUIElement::clickPointX):
411         (WTR::AccessibilityUIElement::clickPointY):
412         (WTR::AccessibilityUIElement::intValue const):
413         (WTR::AccessibilityUIElement::minValue):
414         (WTR::AccessibilityUIElement::maxValue):
415         (WTR::AccessibilityUIElement::valueDescription):
416         (WTR::AccessibilityUIElement::insertionPointLineNumber):
417         (WTR::AccessibilityUIElement::isPressActionSupported):
418         (WTR::AccessibilityUIElement::isIncrementActionSupported):
419         (WTR::AccessibilityUIElement::isDecrementActionSupported):
420         (WTR::AccessibilityUIElement::isEnabled):
421         (WTR::AccessibilityUIElement::isRequired const):
422         (WTR::AccessibilityUIElement::isFocused const):
423         (WTR::AccessibilityUIElement::isSelected const):
424         (WTR::AccessibilityUIElement::isSelectedOptionActive const):
425         (WTR::AccessibilityUIElement::isExpanded const):
426         (WTR::AccessibilityUIElement::isChecked const):
427         (WTR::AccessibilityUIElement::isIndeterminate const):
428         (WTR::AccessibilityUIElement::hierarchicalLevel const):
429         (WTR::AccessibilityUIElement::speakAs):
430         (WTR::AccessibilityUIElement::ariaIsGrabbed const):
431         (WTR::AccessibilityUIElement::ariaDropEffects const):
432         (WTR::AccessibilityUIElement::lineForIndex):
433         (WTR::AccessibilityUIElement::rangeForLine):
434         (WTR::AccessibilityUIElement::rangeForPosition):
435         (WTR::AccessibilityUIElement::boundsForRange):
436         (WTR::AccessibilityUIElement::stringForRange):
437         (WTR::AccessibilityUIElement::attributedStringForRange):
438         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
439         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
440         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
441         (WTR::AccessibilityUIElement::selectTextWithCriteria):
442         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
443         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
444         (WTR::AccessibilityUIElement::attributesOfColumns):
445         (WTR::AccessibilityUIElement::attributesOfRows):
446         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
447         (WTR::AccessibilityUIElement::attributesOfHeader):
448         (WTR::AccessibilityUIElement::rowCount):
449         (WTR::AccessibilityUIElement::columnCount):
450         (WTR::AccessibilityUIElement::indexInTable):
451         (WTR::AccessibilityUIElement::rowIndexRange):
452         (WTR::AccessibilityUIElement::columnIndexRange):
453         (WTR::AccessibilityUIElement::cellForColumnAndRow):
454         (WTR::AccessibilityUIElement::horizontalScrollbar const):
455         (WTR::AccessibilityUIElement::verticalScrollbar const):
456         (WTR::AccessibilityUIElement::selectedTextRange):
457         (WTR::AccessibilityUIElement::setSelectedTextRange):
458         (WTR::AccessibilityUIElement::increment):
459         (WTR::AccessibilityUIElement::decrement):
460         (WTR::AccessibilityUIElement::showMenu):
461         (WTR::AccessibilityUIElement::press):
462         (WTR::AccessibilityUIElement::setSelectedChild const):
463         (WTR::AccessibilityUIElement::setSelectedChildAtIndex const):
464         (WTR::AccessibilityUIElement::removeSelectionAtIndex const):
465         (WTR::AccessibilityUIElement::clearSelectedChildren const):
466         (WTR::AccessibilityUIElement::accessibilityValue const):
467         (WTR::AccessibilityUIElement::documentEncoding):
468         (WTR::AccessibilityUIElement::documentURI):
469         (WTR::AccessibilityUIElement::url):
470         (WTR::AccessibilityUIElement::addNotificationListener):
471         (WTR::AccessibilityUIElement::removeNotificationListener):
472         (WTR::AccessibilityUIElement::isFocusable const):
473         (WTR::AccessibilityUIElement::isSelectable const):
474         (WTR::AccessibilityUIElement::isMultiSelectable const):
475         (WTR::AccessibilityUIElement::isVisible const):
476         (WTR::AccessibilityUIElement::isOffScreen const):
477         (WTR::AccessibilityUIElement::isCollapsed const):
478         (WTR::AccessibilityUIElement::isIgnored const):
479         (WTR::AccessibilityUIElement::isSingleLine const):
480         (WTR::AccessibilityUIElement::isMultiLine const):
481         (WTR::AccessibilityUIElement::hasPopup const):
482         (WTR::AccessibilityUIElement::takeFocus):
483         (WTR::AccessibilityUIElement::takeSelection):
484         (WTR::AccessibilityUIElement::addSelection):
485         (WTR::AccessibilityUIElement::removeSelection):
486         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
487         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
488         (WTR::AccessibilityUIElement::textMarkerRangeLength):
489         (WTR::AccessibilityUIElement::previousTextMarker):
490         (WTR::AccessibilityUIElement::nextTextMarker):
491         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
492         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
493         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
494         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
495         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
496         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
497         (WTR::AccessibilityUIElement::textMarkerForPoint):
498         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
499         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRange):
500         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions):
501         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
502         (WTR::AccessibilityUIElement::indexForTextMarker):
503         (WTR::AccessibilityUIElement::isTextMarkerValid):
504         (WTR::AccessibilityUIElement::textMarkerForIndex):
505         (WTR::AccessibilityUIElement::startTextMarker):
506         (WTR::AccessibilityUIElement::endTextMarker):
507         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
508         (WTR::AccessibilityUIElement::scrollToMakeVisible):
509         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
510         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
511         (WTR::AccessibilityUIElement::supportedActions const):
512         (WTR::AccessibilityUIElement::pathDescription const):
513         (WTR::AccessibilityUIElement::mathPostscriptsDescription const):
514         (WTR::AccessibilityUIElement::mathPrescriptsDescription const):
515         (WTR::AccessibilityUIElement::classList const):
516         (WTR::AccessibilityUIElement::characterAtOffset):
517         (WTR::AccessibilityUIElement::wordAtOffset):
518         (WTR::AccessibilityUIElement::lineAtOffset):
519         (WTR::AccessibilityUIElement::sentenceAtOffset):
520         * WebKitTestRunner/InjectedBundle/win/ActivateFontsWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
521         (WTR::activateFonts):
522         (WTR::installFakeHelvetica):
523         (WTR::uninstallFakeHelvetica):
524         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
525         (WTR::InjectedBundle::platformInitialize):
526         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.cpp: Added.
527         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
528         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
529         (WTR::TestRunner::pathToLocalResource):
530         (WTR::TestRunner::inspectorTestStubURL):
531         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
532         (WTR::TestRunner::platformInitialize):
533         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
534         (WTR::TestRunner::installFakeHelvetica):
535         * WebKitTestRunner/PlatformWebView.h:
536         * WebKitTestRunner/PlatformWin.cmake: Added.
537         * WebKitTestRunner/TestController.cpp:
538         (WTR::TestController::resetStateToConsistentValues):
539         (WTR::createTestURL):
540         * WebKitTestRunner/TestInvocation.cpp:
541         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
542         * WebKitTestRunner/win/EventSenderProxyWin.cpp: Added.
543         (WTR::EventSenderProxy::EventSenderProxy):
544         (WTR::EventSenderProxy::~EventSenderProxy):
545         (WTR::EventSenderProxy::mouseDown):
546         (WTR::EventSenderProxy::mouseUp):
547         (WTR::EventSenderProxy::mouseMoveTo):
548         (WTR::EventSenderProxy::mouseScrollBy):
549         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
550         (WTR::EventSenderProxy::continuousMouseScrollBy):
551         (WTR::EventSenderProxy::leapForward):
552         (WTR::EventSenderProxy::keyDown):
553         * WebKitTestRunner/win/PlatformWebViewWin.cpp: Added.
554         (WTR::registerWindowClass):
555         (WTR::PlatformWebView::PlatformWebView):
556         (WTR::PlatformWebView::~PlatformWebView):
557         (WTR::PlatformWebView::resizeTo):
558         (WTR::PlatformWebView::page):
559         (WTR::PlatformWebView::focus):
560         (WTR::PlatformWebView::windowFrame):
561         (WTR::PlatformWebView::setWindowFrame):
562         (WTR::PlatformWebView::didInitializeClients):
563         (WTR::PlatformWebView::addChromeInputField):
564         (WTR::PlatformWebView::removeChromeInputField):
565         (WTR::PlatformWebView::addToWindow):
566         (WTR::PlatformWebView::removeFromWindow):
567         (WTR::PlatformWebView::setWindowIsKey):
568         (WTR::PlatformWebView::makeWebViewFirstResponder):
569         (WTR::generateCairoSurfaceFromBitmap):
570         (WTR::PlatformWebView::windowSnapshotImage):
571         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
572         (WTR::PlatformWebView::setNavigationGesturesEnabled):
573         (WTR::PlatformWebView::forceWindowFramesChanged):
574         (WTR::PlatformWebView::drawsBackground const):
575         (WTR::PlatformWebView::setDrawsBackground):
576         * WebKitTestRunner/win/TestControllerWin.cpp: Added.
577         (WTR::exceptionFilter):
578         (WTR::runRunLoopUntil):
579         (WTR::TestController::notifyDone):
580         (WTR::TestController::setHidden):
581         (WTR::TestController::platformInitialize):
582         (WTR::TestController::platformPreferences):
583         (WTR::TestController::platformDestroy):
584         (WTR::toWK):
585         (WTR::TestController::platformInitializeContext):
586         (WTR::TestController::platformRunUntil):
587         (WTR::TestController::platformDidCommitLoadForFrame):
588         (WTR::TestController::initializeInjectedBundlePath):
589         (WTR::TestController::initializeTestPluginDirectory):
590         (WTR::TestController::runModal):
591         (WTR::TestController::platformContext):
592         (WTR::TestController::platformLibraryPathForTesting):
593         (WTR::TestController::platformConfigureViewForTest):
594         (WTR::TestController::platformResetPreferencesToConsistentValues):
595         (WTR::TestController::updatePlatformSpecificTestOptionsForTest const):
596         * WebKitTestRunner/win/WebKitTestRunnerPrefix.cpp: Added.
597         * WebKitTestRunner/win/main.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
598         (dllLauncherEntryPoint):
599
600 2018-11-12  Alicia Boya García  <aboya@igalia.com>
601
602         [MSE][GStreamer] Introduce AbortableTaskQueue
603         https://bugs.webkit.org/show_bug.cgi?id=190902
604
605         Reviewed by Xabier Rodriguez-Calvar.
606
607         Tests for AbortableTaskQueue are included.
608
609         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
610         * TestWebKitAPI/PlatformGTK.cmake:
611         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp: Added.
612         (TestWebKitAPI::TEST):
613         (TestWebKitAPI::FancyResponse::FancyResponse):
614         (TestWebKitAPI::FancyResponse::operator=):
615         (TestWebKitAPI::DeterministicScheduler::DeterministicScheduler):
616         (TestWebKitAPI::DeterministicScheduler::ThreadContext::ThreadContext):
617         (TestWebKitAPI::DeterministicScheduler::ThreadContext::waitMyTurn):
618         (TestWebKitAPI::DeterministicScheduler::ThreadContext::yieldToThread):
619
620 2018-11-11  Fujii Hironori  <Hironori.Fujii@sony.com>
621
622         run-bindings-tests is timing out in some WinCairo bots
623         https://bugs.webkit.org/show_bug.cgi?id=191348
624
625         Reviewed by Alex Christensen.
626
627         BuildBot kills run-bindings-tests if it outputs nothing for 20
628         minutes. run-bindings-tests runs very slowly in WinCairo Docker,
629         and it takes more than 30 minutes to finish. And, Windows Python
630         buffers the progress output.
631
632         * Scripts/webkitpy/bindings/main.py:
633         (BindingsTests.detect_changes): Call sys.stdout.flush() after the
634         test case result is output.
635
636 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
637
638         Implement a new edit command to change the enclosing list type
639         https://bugs.webkit.org/show_bug.cgi?id=191487
640         <rdar://problem/45955922>
641
642         Reviewed by Ryosuke Niwa.
643
644         Add a new API test to verify that `-[WKWebView _changeListType:]` is hooked up to the corresponding editing
645         command in WebCore. See the new layout test for a test that exercises more nuanced corner cases.
646
647         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
648         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
649         (-[TestWKWebView setPosition:offset:]):
650         (-[TestWKWebView setBase:baseOffset:extent:extentOffset:]):
651         (TestWebKitAPI::webViewForEditActionTestingWithPageNamed):
652         (TestWebKitAPI::TEST):
653         * TestWebKitAPI/Tests/WebKitCocoa/editable-nested-lists.html: Added.
654
655 2018-11-11  Dan Bernstein  <mitz@apple.com>
656
657         ProcessPoolConfiguration::copy() doesn’t copy m_customWebContentServiceBundleIdentifier
658         https://bugs.webkit.org/show_bug.cgi?id=191514
659
660         Reviewed by Geoffrey Garen.
661
662         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
663         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm: Added.
664         (TEST):
665
666 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
667
668         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
669         https://bugs.webkit.org/show_bug.cgi?id=191492
670
671         Reviewed by Alex Christensen.
672
673         Update file name.
674
675         * DumpRenderTree/mac/DumpRenderTree.mm:
676         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
677         * WebKitTestRunner/mac/TestControllerMac.mm:
678
679 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
680
681         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
682         https://bugs.webkit.org/show_bug.cgi?id=191492
683
684         Reviewed by Alex Christensen.
685
686         * DumpRenderTree/mac/DumpRenderTree.mm:
687         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
688         * WebKitTestRunner/mac/TestControllerMac.mm:
689
690 2018-11-10  Ryan Haddad  <ryanhaddad@apple.com>
691
692         Unreviewed, rolling out r238065.
693
694         Breaks internal builds.
695
696         Reverted changeset:
697
698         "Make it possible to edit images inline"
699         https://bugs.webkit.org/show_bug.cgi?id=191352
700         https://trac.webkit.org/changeset/238065
701
702 2018-11-10  Michael Catanzaro  <mcatanzaro@igalia.com>
703
704         [WPE][GTK] API test /webkit/WebKitSettings/webkit-settings is failing
705         https://bugs.webkit.org/show_bug.cgi?id=191221
706
707         Unreviewed, fix a typo from the previous patch. After disabling the setting, we should test
708         that it is disabled, but we're testing that it is enabled, because I failed to update this
709         line.
710
711         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
712         (testWebKitSettings):
713
714 2018-11-10  Tim Horton  <timothy_horton@apple.com>
715
716         Make it possible to edit images inline
717         https://bugs.webkit.org/show_bug.cgi?id=191352
718         <rdar://problem/30107985>
719
720         Reviewed by Dean Jackson.
721
722         * WebKitTestRunner/TestController.cpp:
723         (WTR::updateTestOptionsFromTestHeader):
724         * WebKitTestRunner/TestOptions.h:
725         (WTR::TestOptions::hasSameInitializationOptions const):
726         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
727         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
728         (WTR::TestController::platformCreateWebView):
729         Add a test option to enable editable images.
730
731         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
732         (WTR::UIScriptController::drawSquareInEditableImage):
733         (WTR::UIScriptController::numberOfStrokesInEditableImage):
734         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
735         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
736         (WTR::UIScriptController::drawSquareInEditableImage):
737         (WTR::UIScriptController::numberOfStrokesInEditableImage):
738         * TestRunnerShared/UIScriptContext/UIScriptController.h:
739         * TestRunnerShared/spi/PencilKitTestSPI.h: Added.
740         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
741         (WTR::findEditableImageCanvas):
742         (WTR::UIScriptController::drawSquareInEditableImage):
743         (WTR::UIScriptController::numberOfStrokesInEditableImage):
744         Add the ability to draw on a PKCanvasView that is a subview of the WKWebView,
745         and also to retrieve the number of strokes currently on the PKCanvasView.
746         Currently this just takes the first canvas; we might need to make it
747         take an identifier or something in the future if we need tests with multiple
748         canvases. The indirect testing mechanism is required because PKCanvasView
749         can currently not actually paint its strokes in the Simulator.
750
751 2018-11-09  Chris Dumez  <cdumez@apple.com>
752
753         Suspended page persists even after back/forward list item is gone
754         https://bugs.webkit.org/show_bug.cgi?id=191488
755         <rdar://problem/45953006>
756
757         Reviewed by Geoffrey Garen.
758
759         Add API test coverage.
760
761         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
762
763 2018-11-09  Wenson Hsieh  <wenson_hsieh@apple.com>
764
765         [Cocoa] Implement SPI on WKWebView to increase and decrease list levels
766         https://bugs.webkit.org/show_bug.cgi?id=191471
767         <rdar://problem/45952472>
768
769         Reviewed by Tim Horton.
770
771         Add an API test to ensure that list levels can be incremented and decremented via WKWebView SPI.
772
773         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
774         (TestWebKitAPI::webViewForEditActionTesting):
775         (TestWebKitAPI::TEST):
776
777 2018-11-09  Basuke Suzuki  <basuke.suzuki@sony.com>
778
779         [Curl][WebKit] Implement Proxy configuration API.
780         https://bugs.webkit.org/show_bug.cgi?id=189053
781
782         Reviewed by Youenn Fablet.
783
784         Added Proxy Settings dialog to call newly added API.
785
786         * MiniBrowser/win/BrowserWindow.h:
787         * MiniBrowser/win/Common.cpp:
788         (askProxySettings):
789         (askCredential):
790         (authDialogProc): Deleted.
791         * MiniBrowser/win/Common.h:
792         * MiniBrowser/win/DialogHelper.h: Added.
793         (Dialog::run):
794         (Dialog::doalogProc):
795         (Dialog::handle):
796         (Dialog::setup):
797         (Dialog::update):
798         (Dialog::validate):
799         (Dialog::updateOkButton):
800         (Dialog::command):
801         (Dialog::ok):
802         (Dialog::cancel):
803         (Dialog::close):
804         (Dialog::hDlg):
805         (Dialog::item):
806         (Dialog::setEnabled):
807         (Dialog::setText):
808         (Dialog::getText):
809         (Dialog::getTextLength):
810         (Dialog::RadioGroup::RadioGroup):
811         (Dialog::RadioGroup::set):
812         (Dialog::RadioGroup::get):
813         (Dialog::radioGroup):
814         * MiniBrowser/win/MainWindow.cpp:
815         (MainWindow::WndProc):
816         * MiniBrowser/win/MiniBrowserLib.rc:
817         * MiniBrowser/win/MiniBrowserLibResource.h:
818         * MiniBrowser/win/WebKitBrowserWindow.cpp:
819         (createWKURL):
820         (WebKitBrowserWindow::WebKitBrowserWindow):
821         (WebKitBrowserWindow::updateProxySettings):
822         (WebKitBrowserWindow::loadURL):
823         (WebKitBrowserWindow::loadHTMLString):
824         (WebKitBrowserWindow::openProxySettings):
825         * MiniBrowser/win/WebKitBrowserWindow.h:
826         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
827         (WebKitLegacyBrowserWindow::openProxySettings):
828         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
829
830 2018-11-09  Wenson Hsieh  <wenson_hsieh@apple.com>
831
832         [Cocoa] Introduce WKWebView SPI to insert nested ordered and unordered lists
833         https://bugs.webkit.org/show_bug.cgi?id=191410
834         <rdar://problem/45898610>
835
836         Reviewed by Dean Jackson.
837
838         Move WKWebViewEditActions from iOS to WebKitCocoa, and enable the relevant WKWebViewEditActions tests on macOS.
839         Additionally, add new API tests to verify that `-_pasteAsQuotation:` and `-_insertNested(Un)OrderedList:` are
840         hooked up to their respective editing commands.
841
842         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
843         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm: Renamed from Tools/TestWebKitAPI/Tests/ios/WKWebViewEditActions.mm.
844         (-[TestWKWebView querySelectorExists:]):
845         (-[TestWKWebView insertString:]):
846
847         Add a helper method to insert a piece of text. This abstracts platform differences between iOS and macOS, by
848         invoking the WKWebView directly on macOS and calling on the content view on iOS.
849
850         (TestWebKitAPI::webViewForEditActionTesting):
851         (TestWebKitAPI::TEST):
852
853 2018-11-09  Philippe Normand  <pnormand@igalia.com>
854
855         [Flatpak] Refactoring and drive-by fixes
856         https://bugs.webkit.org/show_bug.cgi?id=191421
857
858         Reviewed by Michael Catanzaro.
859
860         * Scripts/webkitdirs.pm:
861         (inFlatpakSandbox): Flatpak now has a /.flatpak-info file when in
862         the sandbox, so rely on this.
863         * flatpak/flatpakutils.py:
864         (expand_manifest): Pass explicit keywords to load_manifest() and
865         remove unused local variable.
866         (WebkitFlatpak.clean_args): Move hard-coded sdk/runtime infos to the manifest file.
867         (WebkitFlatpak.run_in_sandbox): Add support for extra environment variables.
868         (WebkitFlatpak.setup_dev_env): Stop build at final app. Refactor
869         build_type handling a bit.
870         * flatpak/org.webkit.CommonModules.yaml: Added.
871         * flatpak/org.webkit.WPE.yaml: wpebackend upstream was renamed to libwpe.
872         * flatpak/org.webkit.WebKit.yaml: Move common dependencies
873         declaration to CommonModules, so it can be reused later when we
874         add support for building extra libraries depending on WPE.
875
876 2018-11-08  Said Abou-Hallawa  <sabouhallawa@apple.com>
877
878 onal supported image formats
879         https://bugs.webkit.org/show_bug.cgi?id=190454
880
881         Reviewed by Simon Fraser.
882
883         Test opening a TGA image in WebView which is not allowed by default. The
884         TGA format will be allowed through WKWebViewConfiguration.
885
886         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
887         * TestWebKitAPI/Tests/WebKitCocoa/100x100-red.tga: Added.
888         * TestWebKitAPI/Tests/WebKitCocoa/400x400-green.png: Added.
889         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalSupportedImageTypes.mm: Added.
890         (runTest):
891         (TEST):
892
893 2018-11-08  Jiewen Tan  <jiewen_tan@apple.com>
894
895         Unreviewed, a proper build fix for r237983
896
897         Don't include header PublicKeyCredential.h in CtapResponseTest.cpp.
898
899         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
900         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/CtapRequestTest.cpp.
901         (TestWebKitAPI::TEST):
902         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/CtapResponseTest.cpp.
903         (TestWebKitAPI::getTestCorruptedSignResponse):
904         (TestWebKitAPI::getTestCredentialRawIdBytes):
905         (TestWebKitAPI::convertToVector):
906         (TestWebKitAPI::TEST):
907
908 2018-11-08  Keith Rollin  <krollin@apple.com>
909
910         Create .xcfilelist files
911         https://bugs.webkit.org/show_bug.cgi?id=191324
912         <rdar://problem/45852819>
913
914         Reviewed by Alex Christensen.
915
916         As part of preparing for enabling XCBuild, create and use .xcfilelist
917         files. These files are using during Run Script build phases in an
918         Xcode project. If a Run Script build phase produces new files that are
919         used later as inputs to subsequent build phases, XCBuild needs to know
920         about these files. These files can be either specified in an "output
921         files" section of the Run Script phase editor, or in .xcfilelist files
922         that are associated with the Run Script build phase.
923
924         This patch takes the second approach. It consists of three sets of changes:
925
926         - Modify the DerivedSources.make files to have a
927           'print_all_generated_files" target that produces a list of the files
928           they create.
929
930         - Create a shell script that produces .xcfilelist files from the
931           output of the previous step, as well as for the files created in the
932           Generate Unified Sources build steps.
933
934         - Add the new .xcfilelist files to the associated projects.
935
936         Note that, with these changes, the Xcode workspace and projects can no
937         longer be fully loaded into Xcode 9. Xcode will attempt to load the
938         projects that have .xcfilelist files associated with them, but will
939         fail and display a placeholder for those projects instead. It's
940         expected that all developers are using Xcode 10 by now and that not
941         being able to load into Xcode 9 is not a practical issue. Keep in mind
942         that this is strictly an IDE issue, and that the projects can still be
943         built with `xcodebuild`.
944
945         Also note that the shell script that creates the .xcfilelist files can
946         also be used to verify that the set of files that's currently checked
947         in is up-to-date. This checking can be used as part of a check-in hook
948         or part of check-webkit-style to sooner catch cases where the
949         .xcfilelist files need to be regenerated.
950
951         * DumpRenderTree/DerivedSources.make:
952         * DumpRenderTree/DerivedSources.xcfilelist: Added.
953         * Scripts/generate-xcfilelists: Added.
954         * WebKitTestRunner/DerivedSources.make:
955         * WebKitTestRunner/DerivedSources.xcfilelist: Added.
956
957 2018-11-08  Jiewen Tan  <jiewen_tan@apple.com>
958
959         Unreviewed, a quick build fix for r237983
960
961         Temporarily make CtapRequestTest.cpp/CtapResponseTest.cpp to mac only to avoid iOS build failures.
962
963         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
964         * TestWebKitAPI/Tests/WebCore/mac/CtapRequestTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp.
965         (TestWebKitAPI::TEST):
966         * TestWebKitAPI/Tests/WebCore/mac/CtapResponseTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp.
967         (TestWebKitAPI::getTestCorruptedSignResponse):
968         (TestWebKitAPI::getTestCredentialRawIdBytes):
969         (TestWebKitAPI::convertToVector):
970         (TestWebKitAPI::TEST):
971
972 2018-11-05  Ryan Haddad  <ryanhaddad@apple.com>
973
974         Fix steps_unittest.py failures related to recent Win10/Win7 changes
975         https://bugs.webkit.org/show_bug.cgi?id=191290
976
977         Reviewed by Alexey Proskuryakov.
978
979         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update expected results.
980
981 2018-11-08  Dean Jackson  <dino@apple.com>
982
983         Add a String literal that returns a String
984         https://bugs.webkit.org/show_bug.cgi?id=191425
985         <rdar://problem/45914556>
986
987         Reviewed by Sam Weinig.
988
989         Test _str.
990
991         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
992         (TestWebKitAPI::TEST):
993
994 2018-11-08  Jonathan Bedard  <jbedard@apple.com>
995
996         webkitpy: Generalize trailing SDK specifier (Part 2)
997         https://bugs.webkit.org/show_bug.cgi?id=191275
998         <rdar://problem/45703660>
999
1000         Rubber-stamped by Aakash Jain.
1001
1002         Re-landing this change, configuration issues have been resolved.
1003
1004         * Scripts/webkitpy/port/ios_device.py:
1005         (IOSDevicePort): Use normalized SDK.
1006         * Scripts/webkitpy/port/ios_simulator.py:
1007         (IOSSimulatorPort): Use normalized SDK.
1008         (IOSSimulatorPort._build_driver_flags): Use platform SDK in build driver flags.
1009
1010 2018-11-08  Jiewen Tan  <jiewen_tan@apple.com>
1011
1012         [WebAuthN] Import CTAP device request/response converters from Chromium
1013         https://bugs.webkit.org/show_bug.cgi?id=190784
1014         <rdar://problem/45460333>
1015
1016         Reviewed by Brent Fulgham.
1017
1018         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1019         * TestWebKitAPI/Tests/WebCore/CBORValueTest.cpp:
1020         (TestWebKitAPI::TEST):
1021         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp: Added.
1022         (TestWebKitAPI::TEST):
1023         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp: Added.
1024         (TestWebKitAPI::getTestCorruptedSignResponse):
1025         (TestWebKitAPI::getTestCredentialRawIdBytes):
1026         (TestWebKitAPI::convertToVector):
1027         (TestWebKitAPI::TEST):
1028         * TestWebKitAPI/Tests/WebCore/FidoTestData.h: Added.
1029
1030 2018-11-07  Caio Lima  <ticaiolima@gmail.com>
1031
1032         [BigInt] Add support to BigInt into ValueAdd
1033         https://bugs.webkit.org/show_bug.cgi?id=186177
1034
1035         Reviewed by Keith Miller.
1036
1037         * Scripts/run-jsc-benchmarks:
1038
1039 2018-11-07  Sihui Liu  <sihui_liu@apple.com>
1040
1041         RELEASE_ASSERT(!m_hardClosedForUserDelete) fails in WebCore::IDBServer::UniqueIDBDatabase::invokeOperationAndTransactionTimer
1042         https://bugs.webkit.org/show_bug.cgi?id=191326
1043         <rdar://problem/45769269>
1044
1045         Reviewed by Geoffrey Garen.
1046
1047         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1048         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.html: Added.
1049         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm: Added.
1050         (-[IndexedDBUserDeleteMessageHandler userContentController:didReceiveScriptMessage:]):
1051         (TEST):
1052
1053 2018-11-07  Daniel Bates  <dabates@apple.com>
1054
1055         Override +[UIKeyboard isInHardwareKeyboardMode] in WebKitTestRunner and DumpRenderTree
1056         https://bugs.webkit.org/show_bug.cgi?id=190141
1057
1058         Reviewed by Darin Adler.
1059
1060         Override +[UIKeyboard isInHardwareKeyboardMode] to always return NO so as to make test
1061         runs deterministic regardless of whether a hardware keyboard is attached.
1062
1063         * DumpRenderTree/mac/DumpRenderTree.mm:
1064         (overrideIsInHardwareKeyboardMode): Added.
1065         (prepareConsistentTestingEnvironment):
1066         * TestRunnerShared/spi/UIKitTestSPI.h: Forward declare SPI.
1067         * WebKitTestRunner/ios/TestControllerIOS.mm:
1068         (overrideIsInHardwareKeyboardMode): Added.
1069         (WTR::TestController::platformInitialize):
1070
1071 2018-11-07  Jonathan Bedard  <jbedard@apple.com>
1072
1073         Unreviewed, rolling out r237913.
1074
1075         Breaks running tests on Mac without iOS SDK installed
1076
1077         Reverted changeset:
1078
1079         "webkitpy: Generalize trailing SDK specifier (Part 2)"
1080         https://bugs.webkit.org/show_bug.cgi?id=191275
1081         https://trac.webkit.org/changeset/237913
1082
1083 2018-11-07  Zamiul Haque  <zhaque@apple.com>
1084
1085         Force a gregorian calendar to show for credit card expiration date inputs
1086         (autocomplete='cc-exp'*) regardless of default system settings.
1087         https://bugs.webkit.org/show_bug.cgi?id=191096
1088         rdar://problem/42640256
1089
1090         Reviewed by Tim Horton.
1091
1092         Implemented simulateForeignDefaultCalendar and calendarType to be used
1093         for changing the default calendar returned by the system (ie. [NSCalendar
1094         currentCalendar]) and getting the calendar type identifier of a presented date
1095         picker.
1096
1097         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1098         (WTR::UIScriptController::isShowingDataListSuggestions const):
1099         (WTR::UIScriptController::calendarType const):
1100         (WTR::UIScriptController::setDefaultCalendarType):
1101         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1102         (WTR::UIScriptController::calendarType const):
1103         (WTR::UIScriptController::setDefaultCalendarType):
1104         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1105         (WTR::UIScriptController::selectionEndGrabberViewRect const):
1106         (WTR::UIScriptController::calendarType const): Deleted.
1107         * WebKitTestRunner/TestController.cpp:
1108         * WebKitTestRunner/TestController.h:
1109         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1110         (WTR::UIScriptController::calendarType const):
1111         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1112         (WTR::swizzledCalendar):
1113         (WTR::TestController::getOverriddenCalendarIdentifier const):
1114         (WTR::TestController::setDefaultCalendarType):
1115         (WTR::TestController::cocoaResetStateToConsistentValues):
1116         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1117         (WTR::UIScriptController::selectionEndGrabberViewRect const):
1118         (WTR::UIScriptController::calendarType const): Deleted.
1119
1120 2018-11-06  Jonathan Bedard  <jbedard@apple.com>
1121
1122         webkitpy: Boot a single worker for custom devices
1123         https://bugs.webkit.org/show_bug.cgi?id=191312
1124         <rdar://problem/45848717>
1125
1126         Rubber-stamped by Aakash Jain.
1127
1128         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1129         (Manager.run): Custom devices only run a hand-full of tests. Booting multiple
1130         simulators is expensive and unneeded for these tests.
1131         * Scripts/webkitpy/port/ios.py:
1132         (IOSPort. child_processes): No reason to memoize this call, and it prevents
1133         overriding the number of child processes when booting custom devices.
1134
1135 2018-11-06  Jonathan Bedard  <jbedard@apple.com>
1136
1137         webkitpy: Generalize trailing SDK specifier (Part 2)
1138         https://bugs.webkit.org/show_bug.cgi?id=191275
1139         <rdar://problem/45703660>
1140
1141         Reviewed by Aakash Jain.
1142
1143         * Scripts/webkitpy/port/ios_device.py:
1144         (IOSDevicePort): Use normalized SDK.
1145         * Scripts/webkitpy/port/ios_simulator.py:
1146         (IOSSimulatorPort): Use normalized SDK.
1147         (IOSSimulatorPort._build_driver_flags): Use platform SDK in build driver flags.
1148
1149 2018-11-06  Justin Fan  <justin_fan@apple.com>
1150
1151         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
1152         https://bugs.webkit.org/show_bug.cgi?id=191291
1153
1154         Reviewed by Myles Maxfield.
1155
1156         Properly disable WEBGPU on all non-Metal platforms for now.
1157
1158         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1159
1160 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
1161
1162         [ews-app] Add URL configuration for OpenSource EWS Django app
1163         https://bugs.webkit.org/show_bug.cgi?id=191132
1164
1165         Rubber-stamped by Lucas Forschler.
1166
1167         * BuildSlaveSupport/ews-app/ews-app/urls.py: Added entry for ews.urls.
1168         * BuildSlaveSupport/ews-app/ews/urls.py: Added.
1169
1170 2018-11-06  Youenn Fablet  <youenn@apple.com>
1171
1172         Make mDNS ICE Candidate an experimental flag again
1173         https://bugs.webkit.org/show_bug.cgi?id=191262
1174
1175         Reviewed by Dean Jackson.
1176
1177         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1178         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1179         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
1180         (WTR::TestRunner::setMDNSICECandidatesEnabled): Deleted.
1181         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1182
1183 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
1184
1185         [ews-app] Add views for OpenSource EWS Django app
1186         https://bugs.webkit.org/show_bug.cgi?id=191131
1187
1188         Rubber-stamped by Lucas Forschler.
1189
1190         * BuildSlaveSupport/ews-app/ews/views/index.py: Added.
1191         * BuildSlaveSupport/ews-app/ews/views/patch.py:
1192         * BuildSlaveSupport/ews-app/ews/views/results.py: Added.
1193         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added.
1194
1195 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
1196
1197         [ews-app] Add models for OpenSource EWS Django app
1198         https://bugs.webkit.org/show_bug.cgi?id=191123
1199
1200         Reviewed by Lucas Forschler.
1201
1202         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
1203         * BuildSlaveSupport/ews-app/ews/models/buildermappings.py: Added.
1204         * BuildSlaveSupport/ews-app/ews/models/builds.py: Added.
1205         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1206         * BuildSlaveSupport/ews-app/ews/models/steps.py: Added.
1207
1208 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
1209
1210         [ews-app] Fix Invalid HTTP_HOST header
1211         https://bugs.webkit.org/show_bug.cgi?id=191325
1212
1213         Reviewed by Lucas Forschler.
1214
1215         Changing ALLOWED_HOSTS to * as the landing page should be publicly accessible.
1216
1217         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1218
1219 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
1220
1221         [ews-app] Rename EWS_app to ews-app - part 2
1222         https://bugs.webkit.org/show_bug.cgi?id=191317
1223
1224         Reviewed by Lucas Forschler.
1225
1226         * BuildSlaveSupport/ews-app/EWS_app: Removed.
1227         * BuildSlaveSupport/ews-app/ews-app: Moved from BuildSlaveSupport/ews-app/EWS_app.
1228         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1229         * BuildSlaveSupport/ews-app/ews-app/urls.py:
1230         * BuildSlaveSupport/ews-app/ews-app/wsgi.py:
1231         * BuildSlaveSupport/ews-app/manage.py:
1232
1233 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
1234
1235         [ews-app] Rename EWS_app to ews-app - part 1
1236         https://bugs.webkit.org/show_bug.cgi?id=191317
1237
1238         Reviewed by Lucas Forschler.
1239
1240         * BuildSlaveSupport/EWS_app: Removed.
1241         * BuildSlaveSupport/ews-app: Moved from BuildSlaveSupport/EWS_app.
1242
1243 2018-11-06  Myles C. Maxfield  <mmaxfield@apple.com>
1244
1245         Spelling dots are drawn in the wrong place
1246         https://bugs.webkit.org/show_bug.cgi?id=190764
1247
1248         Reviewed by Dean Jackson.
1249
1250         Previously, it was impossible for WebKitTestRunner to draw spelling dots. This patch adds support for a header
1251         at the top of test files, of the form <!-- webkit-test-runner [ spellCheckingDots=true ] --> which will cause
1252         dots to be drawn.
1253
1254         * WebKitTestRunner/TestController.cpp:
1255         (WTR::TestController::resetStateToConsistentValues):
1256         (WTR::updateTestOptionsFromTestHeader):
1257         (WTR::TestController::platformResetStateToConsistentValues):
1258         * WebKitTestRunner/TestController.h:
1259         * WebKitTestRunner/TestOptions.h:
1260         (WTR::TestOptions::hasSameInitializationOptions const):
1261         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1262         (WTR::TestController::cocoaResetStateToConsistentValues):
1263         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1264         * WebKitTestRunner/ios/TestControllerIOS.mm:
1265         (WTR::TestController::platformResetStateToConsistentValues):
1266         * WebKitTestRunner/mac/TestControllerMac.mm:
1267         (WTR::TestController::platformResetStateToConsistentValues):
1268
1269 2018-11-06  Don Olmstead  <don.olmstead@sony.com>
1270
1271         Feature flags not present for Visual Studio when using build-webkit
1272         https://bugs.webkit.org/show_bug.cgi?id=191288
1273
1274         Reviewed by Fujii Hironori.
1275
1276         Passes feature flags to Visual studio builds within build-webkit.
1277         Removes cmakeBasedPortArguments as it is no longer in use.
1278
1279         * Scripts/build-jsc:
1280         * Scripts/build-webkit:
1281         * Scripts/webkitdirs.pm:
1282         (cmakeBasedPortArguments): Deleted.
1283
1284 2018-11-06  Per Arne Vollan  <pvollan@apple.com>
1285
1286         REGRESSION (r230523): Caps lock indicator not shown in password field
1287         https://bugs.webkit.org/show_bug.cgi?id=190056
1288
1289         Reviewed by Ryosuke Niwa.
1290
1291         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1292         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1293         (WTR::TestRunner::toggleCapsLock):
1294         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1295         * WebKitTestRunner/TestController.h:
1296         * WebKitTestRunner/TestInvocation.cpp:
1297         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1298         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1299         (WTR::TestController::toggleCapsLock):
1300
1301 2018-11-06  Sihui Liu  <sihui_liu@apple.com>
1302
1303         IndexedDB: WAL file keeps growing
1304         https://bugs.webkit.org/show_bug.cgi?id=191294
1305         <rdar://problem/41333493>
1306
1307         Reviewed by Chris Dumez.
1308
1309         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1310         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize-1.html: Added.
1311         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize-2.html: Added.
1312         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm: Added.
1313         (-[IndexedDBFileSizeMessageHandler userContentController:didReceiveScriptMessage:]):
1314         (TEST):
1315
1316 2018-11-06  Alex Christensen  <achristensen@webkit.org>
1317
1318         Fix tests after r237863
1319         https://bugs.webkit.org/show_bug.cgi?id=191315
1320
1321         Reviewed by Chris Dumez.
1322
1323         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1324         With the timing change of r237863, the WKWebView progressed further than before when loading main.html so it completed before main2.html.
1325         This test was meant to test that main2.html does eventually load, and it doesn't matter if main.html loads before it.  I updated the test
1326         to verify that main2.html eventually loads, making this test less timing dependent.
1327
1328 2018-11-06  Ryan Haddad  <ryanhaddad@apple.com>
1329
1330         Unreviewed, rolling out r237834.
1331
1332         Tests for this change crash on iOS Simulator
1333
1334         Reverted changeset:
1335
1336         "Spelling dots are drawn in the wrong place"
1337         https://bugs.webkit.org/show_bug.cgi?id=190764
1338         https://trac.webkit.org/changeset/237834
1339
1340 2018-11-05  Alex Christensen  <achristensen@webkit.org>
1341
1342         [Mac] Implement safe browsing in WebKit
1343         https://bugs.webkit.org/show_bug.cgi?id=188871
1344
1345         Reviewed by Tim Horton.
1346
1347         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1348         (-[SafeBrowsingNavigationDelegate webView:didCommitNavigation:]):
1349         (+[TestServiceLookupResult resultWithProvider:phishing:malware:unwantedSoftware:]):
1350         (-[TestLookupContext lookUpURL:completionHandler:]):
1351         (simpleURL):
1352         (safeBrowsingView):
1353         (TEST):
1354         (-[SafeBrowsingNavigationDelegate webView:didFinishNavigation:]): Deleted.
1355         (+[TestServiceLookupResult resultWithProvider:phishing:malware:unwantedSoftware:knownToBeUnsafe:]): Deleted.
1356         (-[TestServiceLookupResult isKnownToBeUnsafe]): Deleted.
1357         * TestWebKitAPI/Utilities.h:
1358
1359 2018-11-05  Jonathan Bedard  <jbedard@apple.com>
1360
1361         webkitpy: Generalize trailing SDK specifier (Part 1)
1362         https://bugs.webkit.org/show_bug.cgi?id=191275
1363         <rdar://problem/45703660>
1364
1365         Reviewed by Lucas Forschler.
1366
1367         * Scripts/webkitpy/common/system/platforminfo.py:
1368         (PlatformInfo.available_sdks): List all installed SDKs with version numbers stripped out.
1369         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
1370         (TestPlatformInfo):
1371         (TestPlatformInfo.test_available_sdks):
1372
1373 2018-11-05  Myles C. Maxfield  <mmaxfield@apple.com>
1374
1375         Spelling dots are drawn in the wrong place
1376         https://bugs.webkit.org/show_bug.cgi?id=190764
1377
1378         Reviewed by Dean Jackson.
1379
1380         Previously, it was impossible for WebKitTestRunner to draw spelling dots. This patch adds support for a header
1381         at the top of test files, of the form <!-- webkit-test-runner [ spellCheckingDots=true ] --> which will cause
1382         dots to be drawn.
1383
1384         * WebKitTestRunner/TestController.cpp:
1385         (WTR::TestController::resetStateToConsistentValues):
1386         (WTR::updateTestOptionsFromTestHeader):
1387         (WTR::TestController::platformResetStateToConsistentValues):
1388         * WebKitTestRunner/TestController.h:
1389         * WebKitTestRunner/TestOptions.h:
1390         (WTR::TestOptions::hasSameInitializationOptions const):
1391         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1392         (WTR::TestController::cocoaResetStateToConsistentValues):
1393         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1394         * WebKitTestRunner/ios/TestControllerIOS.mm:
1395         (WTR::TestController::platformResetStateToConsistentValues):
1396         * WebKitTestRunner/mac/TestControllerMac.mm:
1397         (WTR::TestController::platformResetStateToConsistentValues):
1398
1399 2018-11-05  Chris Dumez  <cdumez@apple.com>
1400
1401         Use same limit for page cache and suspended pages
1402         https://bugs.webkit.org/show_bug.cgi?id=191266
1403
1404         Reviewed by Geoffrey Garen.
1405
1406         Update API tests accordingly.
1407
1408         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1409
1410 2018-11-05  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1411
1412         [style] Exclude style check for auto generated files.
1413         https://bugs.webkit.org/show_bug.cgi?id=191118
1414
1415         Reviewed by Eric Carlson.
1416
1417         Some files checked in to the repository are generated by other tools. In this patch,
1418         "MiniBrowserLibResource.h" is the file generated and managed by resource editor of
1419         VisualStudio.
1420
1421         There's no need to check these files because it's not practical to fix the style errors
1422         or it's hard to maintain those fixes.
1423
1424         * Scripts/webkitpy/style/checkers/cpp.py:
1425         (is_generated_file):
1426         (CppChecker.check):
1427
1428 2018-11-05  Thibault Saunier  <tsaunier@igalia.com>
1429
1430         [Flatpak] Build libx264 as it is the h264 encoder we support in WebRTC
1431         https://bugs.webkit.org/show_bug.cgi?id=190680
1432
1433         Reviewed by Philippe Normand.
1434
1435         * flatpak/org.webkit.WebKit.yaml:
1436
1437 2018-11-05  Daniel Bates  <dabates@apple.com>
1438
1439         [lldb-webkit] Fix formatting nits in Document and Frame summary strings
1440         https://bugs.webkit.org/show_bug.cgi?id=191094
1441
1442         Reviewed by Andy Estes.
1443
1444         Format boolean as 1/0 when printing Frame summary to be consistent with the formatting of
1445         booleans in other summary strings, substitute "inMainFrame" for "isMainFrame" in the printed
1446         Document summary and add closing brace '}' to both Frame and Document summary strings to make
1447         them look pretty.
1448
1449         * lldb/lldb_webkit.py:
1450         (WebCoreFrame_SummaryProvider):
1451         (WebCoreDocument_SummaryProvider):
1452
1453 2018-11-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1454
1455         [iOS] Allow WKWebView clients to customize bar button item groups in the accessory view when editing
1456         https://bugs.webkit.org/show_bug.cgi?id=191240
1457         <rdar://problem/44872806>
1458
1459         Reviewed by Tim Horton.
1460
1461         Add new API tests to verify that setting leading and trailing bar button groups on WKWebView sets the first
1462         responder's (i.e. WKContentView's) leading and trailing bar button groups, and that this can also be achieved by
1463         overriding `-[WKWebView inputAssistantItem]`.
1464
1465         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1466         (-[InputAssistantItemTestingWebView fakeLeadingBarButtonItemAction]):
1467         (-[InputAssistantItemTestingWebView fakeTrailingBarButtonItemAction]):
1468         (+[InputAssistantItemTestingWebView barButtonIcon]):
1469         (+[InputAssistantItemTestingWebView leadingItemsForWebView:]):
1470         (+[InputAssistantItemTestingWebView trailingItemsForWebView:]):
1471         (-[InputAssistantItemTestingWebView inputAssistantItem]):
1472         (TestWebKitAPI::TEST):
1473
1474 2018-11-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1475
1476         [iOS] Changing view scale sometimes does not zoom the page to the new initial scale when the page is zoomed in when ignoring meta viewport
1477         https://bugs.webkit.org/show_bug.cgi?id=191226
1478         <rdar://problem/45781765>
1479
1480         Reviewed by Tim Horton.
1481
1482         Add a missing check for `shouldIgnoreMetaViewport` when comparing TestOptions, to ensure that "ignore meta
1483         viewport" state doesn't unexpectedly persist after running a layout test that ignores meta viewport.
1484
1485         * WebKitTestRunner/TestOptions.h:
1486         (WTR::TestOptions::hasSameInitializationOptions const):
1487
1488 2018-11-05  Commit Queue  <commit-queue@webkit.org>
1489
1490         Unreviewed, rolling out r237784 and r237788.
1491         https://bugs.webkit.org/show_bug.cgi?id=191270
1492
1493         Caused mediastream layout test failures (Requested by
1494         ryanhaddad on #webkit).
1495
1496         Reverted changesets:
1497
1498         "[MediaStream] User should not be prompted again after denying
1499         getDisplayMedia request"
1500         https://bugs.webkit.org/show_bug.cgi?id=191227
1501         https://trac.webkit.org/changeset/237784
1502
1503         "[MediaStream] User should not be prompted again after denying
1504         getDisplayMedia request"
1505         https://bugs.webkit.org/show_bug.cgi?id=191227
1506         https://trac.webkit.org/changeset/237788
1507
1508 2018-11-05  Lucas Forschler  <lforschler@apple.com>
1509
1510         https://bugs.webkit.org/show_bug.cgi?id=191268
1511         Remove unused bots.
1512
1513         rubber-stamped by Alexey Proskuryakov.
1514
1515         * BuildSlaveSupport/build.webkit.org-config/config.json:
1516         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1517         (WebKitBuildbot):
1518
1519 2018-11-05  Michael Catanzaro  <mcatanzaro@igalia.com>
1520
1521         [WPE][GTK] API test runner fails to respect default build type
1522         https://bugs.webkit.org/show_bug.cgi?id=190247
1523
1524         Reviewed by Carlos Garcia Campos.
1525
1526         Problem is it's looking for a release build, even though I've run set-webkit-configuration
1527         --debug. It should look for a debug build unless I explicitly pass --release.
1528
1529         * glib/api_test_runner.py:
1530         (TestRunner.__init__):
1531
1532 2018-11-05  Thibault Saunier  <tsaunier@igalia.com>
1533
1534         [GStreamer][WebRTC] Add webrtcencoder bin to cleanup and refactor the way we set encoders
1535         https://bugs.webkit.org/show_bug.cgi?id=190674
1536
1537         Reviewed by Philippe Normand.
1538
1539         webrtcencoder is a simple GstBin with a set of well known GStreamer encoders which
1540         it can use to implement encoding for different formats exposing a trimmed down unified API.
1541
1542         It also adds proper handling of H264 profiles.
1543
1544         The added files follow GStreamer coding style as we aim at upstreaming the element
1545         in the future.
1546
1547         Reviewed by Philippe Normand.
1548
1549         * Scripts/webkitpy/style/checker.py:
1550
1551 2018-11-05  Michael Catanzaro  <mcatanzaro@igalia.com>
1552
1553         [WPE][GTK] API test /webkit/WebKitSettings/webkit-settings is failing
1554         https://bugs.webkit.org/show_bug.cgi?id=191221
1555
1556         Reviewed by Carlos Garcia Campos.
1557
1558         This test ensures that MSE is disabled by default, but we now enable it by default, so
1559         reverse the semantics of the test.
1560
1561         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1562         (testWebKitSettings):
1563
1564 2018-11-05  Michael Catanzaro  <mcatanzaro@igalia.com>
1565
1566         REGRESSION(r237031): [GTK] Test /webkit/WebKitWebView/settings is failing
1567         https://bugs.webkit.org/show_bug.cgi?id=191225
1568
1569         Reviewed by Alejandro G. Castro.
1570
1571         Fix a memory leak causing this test to fail.
1572
1573         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
1574         (WebViewTest::initializeWebView):
1575
1576 2018-11-04  Zan Dobersek  <zdobersek@igalia.com>
1577
1578         [webkitpy] Support WPE in the run-web-platform-tests script
1579         https://bugs.webkit.org/show_bug.cgi?id=191183
1580
1581         Reviewed by Alex Christensen.
1582
1583         * Scripts/webkitpy/w3c/wpt_runner.py:
1584         (parse_args): Support `--wpe` as an argument that specifies WPE as the
1585         target port. Additionally, the `--display-server` flag now accepts
1586         `headless` as a valid value, enabling the WPE WebDriver to run in
1587         headless mode.
1588
1589 2018-11-04  Fujii Hironori  <Hironori.Fujii@sony.com>
1590
1591         [Win] Use C++14, not C++17
1592         https://bugs.webkit.org/show_bug.cgi?id=191101
1593
1594         Reviewed by Alex Christensen.
1595
1596         std::basic_string::data() returns a read-only const buffer in
1597         C++14.
1598
1599         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1600         (createString): Use std::vector instead of std::wstring.
1601         (createUTF8String): Use std::vector instead of std::string.
1602
1603 2018-11-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1604
1605         [Cocoa] Fold common UIScriptController functionality on macOS and iOS into UIScriptControllerCocoa.mm
1606         https://bugs.webkit.org/show_bug.cgi?id=191231
1607
1608         Reviewed by Simon Fraser.
1609
1610         Moves some UIScriptController method implementations specific to iOS and macOS into UIScriptControllerCocoa, so
1611         it can be shared between iOS-family and macOS platforms. See below for more details.
1612
1613         No change in behavior.
1614
1615         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1616         (WTR::UIScriptController::overridePreference):
1617
1618         Add a method stub for DumpRenderTree.
1619
1620         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1621         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1622         (WTR::UIScriptController::doAsyncTask):
1623         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
1624
1625         Unify these method implementations.
1626
1627         (WTR::UIScriptController::removeViewFromWindow):
1628         (WTR::UIScriptController::addViewToWindow):
1629
1630         Move the macOS implementation to UIScriptControllerCocoa. On iOS, this method currently only adds the web view
1631         to the window, and does not attempt to invoke the given completion block; additionally, invoking the completion
1632         block after a presentation update (as done on macOS) causes pageoverlay/overlay-remove-reinsert-view.html to
1633         begin failing consistently. This patch does not attempt to change behavior, but adds a FIXME describing this.
1634
1635         (WTR::UIScriptController::overridePreference):
1636         (WTR::UIScriptController::findString):
1637         (WTR::UIScriptController::contentsOfUserInterfaceItem const):
1638
1639         Move these from UIScriptControllerMac to UIScriptControllerCocoa, so that it is now implemented on iOS as well.
1640
1641         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1642         (WTR::UIScriptController::doAsyncTask): Deleted.
1643         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution): Deleted.
1644         (WTR::UIScriptController::contentsOfUserInterfaceItem const): Deleted.
1645         (WTR::UIScriptController::findString): Deleted.
1646         (WTR::UIScriptController::removeViewFromWindow): Deleted.
1647         (WTR::UIScriptController::addViewToWindow): Deleted.
1648         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1649         (WTR::UIScriptController::doAsyncTask): Deleted.
1650         (WTR::UIScriptController::contentsOfUserInterfaceItem const): Deleted.
1651         (WTR::UIScriptController::overridePreference): Deleted.
1652         (WTR::UIScriptController::findString): Deleted.
1653         (WTR::UIScriptController::removeViewFromWindow): Deleted.
1654         (WTR::UIScriptController::addViewToWindow): Deleted.
1655         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution): Deleted.
1656
1657 2018-11-04  Eric Carlson  <eric.carlson@apple.com>
1658
1659         [MediaStream] User should not be prompted again after denying getDisplayMedia request
1660         https://bugs.webkit.org/show_bug.cgi?id=191227
1661         <rdar://problem/45784512>
1662
1663         Reviewed by Youenn Fablet.
1664
1665         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
1666         (-[GetDisplayMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1667         (TestWebKitAPI::GetDisplayMediaTest::promptForCapture):
1668         (TestWebKitAPI::TEST_F):
1669
1670 2018-11-04  Zalan Bujtas  <zalan@apple.com>
1671
1672         [LFC][BFC] Add support for percentage height in quirks mode.
1673         https://bugs.webkit.org/show_bug.cgi?id=191232
1674
1675         Reviewed by Antti Koivisto.
1676
1677         * LayoutReloaded/misc/LFC-passing-tests.txt:
1678
1679 2018-11-04  Zalan Bujtas  <zalan@apple.com>
1680
1681         [LFC][BCF] Add support for block level non-replaced inflow height percentage
1682         https://bugs.webkit.org/show_bug.cgi?id=191229
1683
1684         Reviewed by Antti Koivisto.
1685
1686         * LayoutReloaded/misc/LFC-passing-tests.txt:
1687
1688 2018-11-02  Zalan Bujtas  <zalan@apple.com>
1689
1690         [LFC][BFC] Resolve percentage height values.
1691         https://bugs.webkit.org/show_bug.cgi?id=191224
1692
1693         Reviewed by Antti Koivisto.
1694
1695         * LayoutReloaded/misc/LFC-passing-tests.txt:
1696
1697 2018-11-03  Alex Christensen  <achristensen@webkit.org>
1698
1699         Mac production builds should sign the network process xpc service with entitlements
1700         https://bugs.webkit.org/show_bug.cgi?id=191209
1701         <rdar://problem/45377609>
1702
1703         Reviewed by Geoff Garen.
1704
1705         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1706         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm: Added.
1707         (TEST):
1708
1709 2018-11-02  Alex Christensen  <achristensen@webkit.org>
1710
1711         Unreviewed, rolling out r237761.
1712
1713         Makes most API tests timeout and WK2 tests crash
1714
1715         Reverted changeset:
1716
1717         "Mac production builds should sign the network process xpc
1718         service with entitlements"
1719         https://bugs.webkit.org/show_bug.cgi?id=191209
1720         https://trac.webkit.org/changeset/237761
1721
1722 2018-11-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1723
1724         Unreviewed API test gardening
1725
1726         * TestWebKitAPI/glib/TestExpectations.json:
1727
1728 2018-11-02  Justin Michaud  <justin_michaud@apple.com>
1729
1730         Add new global object and preliminary Worklets support for CSS painting api
1731         https://bugs.webkit.org/show_bug.cgi?id=190979
1732
1733         Reviewed by Chris Dumez.
1734
1735         * Scripts/webkitpy/bindings/main.py:
1736         (BindingsTests.generate_supplemental_dependency):
1737         (BindingsTests.main):
1738
1739 2018-11-02  Alex Christensen  <achristensen@webkit.org>
1740
1741         Mac production builds should sign the network process xpc service with entitlements
1742         https://bugs.webkit.org/show_bug.cgi?id=191209
1743         <rdar://problem/45377609>
1744
1745         Reviewed by Geoff Garen.
1746
1747         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1748         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm: Added.
1749         (TEST):
1750
1751 2018-11-02  Lucas Forschler  <lforschler@apple.com>
1752
1753         Add Windows 10 archive bots
1754         https://bugs.webkit.org/show_bug.cgi?id=190964
1755         
1756         This Change updates the Apple Windows Buildbot configuration.
1757         - Add Windows 10 specific builders and testers for release and debug.
1758         - Refactor Windows -> Windows 7.
1759         - Remove Windows 7 Debug.
1760
1761         Reviewed by Aakash Jain.
1762
1763         * BuildSlaveSupport/build.webkit.org-config/config.json:
1764
1765 2018-11-02  Philippe Normand  <pnormand@igalia.com>
1766
1767         [GTK][WPE] Enable GST_DEBUG_NO_COLOR environment variable pass-through
1768
1769         Rubber-stamped by Michael Catanzaro.
1770
1771         This variable is useful to get rid of shell color escapes in tests stderr files.
1772
1773         * Scripts/webkitpy/port/gtk.py:
1774         (GtkPort.setup_environ_for_server):
1775         * Scripts/webkitpy/port/wpe.py:
1776         (WPEPort.setup_environ_for_server):
1777
1778 2018-11-02  Aakash Jain  <aakash_jain@apple.com>
1779
1780         Add Basic Django web app for OpenSource EWS
1781         https://bugs.webkit.org/show_bug.cgi?id=191091
1782
1783         Reviewed by Lucas Forschler.
1784
1785         * BuildSlaveSupport/EWS_app/manage.py: Added, auto-generated by Django.
1786         * BuildSlaveSupport/EWS_app/EWS_app/__init__.py: Added, auto-generated by Django.
1787         * BuildSlaveSupport/EWS_app/EWS_app/settings.py: Added, auto-generated by Django.
1788         * BuildSlaveSupport/EWS_app/EWS_app/urls.py: Added, auto-generated by Django.
1789         * BuildSlaveSupport/EWS_app/EWS_app/wsgi.py: Added, auto-generated by Django.
1790         * BuildSlaveSupport/EWS_app/ews/__init__.py: Added.
1791         * BuildSlaveSupport/EWS_app/ews/admin.py: Added, auto-generated by Django.
1792         * BuildSlaveSupport/EWS_app/ews/apps.py: Added, auto-generated by Django.
1793         * BuildSlaveSupport/EWS_app/ews/migrations/__init__.py: Added.
1794         * BuildSlaveSupport/EWS_app/ews/tests.py: Added, auto-generated by Django.
1795         * BuildSlaveSupport/EWS_app/ews/models/__init__.py: Added.
1796         * BuildSlaveSupport/EWS_app/ews/models/patch.py: Added.
1797         * BuildSlaveSupport/EWS_app/ews/views/__init__.py: Added.
1798         * BuildSlaveSupport/EWS_app/ews/views/patch.py: Added.
1799
1800 2018-11-02  Daniel Bates  <dabates@apple.com>
1801
1802         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
1803         https://bugs.webkit.org/show_bug.cgi?id=190487
1804
1805         Reviewed by Tim Horton.
1806
1807         Update the code for renamed enumerations. For WebKitTestRunner, removed comment that does not
1808         match my observations when using the simulator to simulate iOS 12 and add support for testing
1809         right-hand side modifiers.
1810
1811         * DumpRenderTree/mac/EventSendingController.mm:
1812         (modifierFlags):
1813         (-[EventSendingController keyDown:withModifiers:withLocation:]):
1814         (-[EventSendingController setTouchModifier:value:]):
1815         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1816         (hidUsageCodeForCharacter):
1817
1818 2018-11-02  Chris Dumez  <cdumez@apple.com>
1819
1820         [PSON] Reuse SuspendedPages' process when possible, for performance
1821         https://bugs.webkit.org/show_bug.cgi?id=191166
1822
1823         Reviewed by Geoffrey Garen.
1824
1825         Add API test coverage.
1826
1827         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1828
1829 2018-11-02  Zalan Bujtas  <zalan@apple.com>
1830
1831         [LFC][IFC] Add support for intrinsic width calculation
1832         https://bugs.webkit.org/show_bug.cgi?id=191144
1833
1834         Reviewed by Antti Koivisto.
1835
1836         * LayoutReloaded/misc/LFC-passing-tests.txt:
1837
1838 2018-11-01  Philippe Normand  <pnormand@igalia.com>
1839
1840         [Apache] Self-signed SSL certificate RSA key is considered too weak
1841         https://bugs.webkit.org/show_bug.cgi?id=191156
1842
1843         Reviewed by Michael Catanzaro.
1844
1845         * Scripts/webkitpy/common/system/pemfile.py:
1846
1847 2018-11-02  Zan Dobersek  <zdobersek@igalia.com>
1848
1849         Unreviewed follow-up to r237678.
1850
1851         * wpe/jhbuild.modules: The patch element apparently has to be a child
1852         of the branch in order for Jhbuild to properly detect and apply the
1853         patch file.
1854
1855 2018-11-01  Ross Kirsling  <ross.kirsling@sony.com>
1856
1857         build-jsc --wincairo should update WinCairo libraries
1858         https://bugs.webkit.org/show_bug.cgi?id=191170
1859
1860         Reviewed by Fujii Hironori.
1861
1862         * Scripts/build-jsc:
1863
1864 2018-11-01  John Wilander  <wilander@apple.com>
1865
1866         In WebCore::ResourceLoadObserver, use document.sessionID().isEphemeral() when possible and check for page existence when not
1867         https://bugs.webkit.org/show_bug.cgi?id=191119
1868         <rdar://problem/44176965>
1869
1870         Reviewed by Chris Dumez.
1871
1872         This is an API test for a WebKitLegacy WebView that is first closed and then
1873         JavaScript is handed a keyboard event.
1874
1875         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1876         * TestWebKitAPI/Tests/WebKitLegacy/mac/ClosingWebView.mm: Added.
1877         (-[ClosingWebViewThenSendingItAKeyDownEventLoadDelegate webView:didFinishLoadForFrame:]):
1878         (-[KeyboardEventListener handleEvent:]):
1879         (TestWebKitAPI::TEST):
1880
1881 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
1882
1883         Add a storage limit for IndexedDB
1884         https://bugs.webkit.org/show_bug.cgi?id=190598
1885         <rdar://problem/44654715>
1886
1887         Reviewed by Chris Dumez.
1888
1889         Add API for testing.
1890
1891         * DumpRenderTree/TestRunner.cpp:
1892         (setIDBPerOriginQuotaCallback):
1893         (TestRunner::staticFunctions):
1894         * DumpRenderTree/TestRunner.h:
1895         * DumpRenderTree/mac/TestRunnerMac.mm:
1896         (TestRunner::setIDBPerOriginQuota):
1897         * DumpRenderTree/win/TestRunnerWin.cpp:
1898         (TestRunner::setIDBPerOriginQuota):
1899         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1900         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1901         (WTR::TestRunner::setIDBPerOriginQuota):
1902         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1903         * WebKitTestRunner/TestController.cpp:
1904         (WTR::TestController::setIDBPerOriginQuota):
1905         * WebKitTestRunner/TestController.h:
1906         * WebKitTestRunner/TestInvocation.cpp:
1907         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1908
1909 2018-11-01  Chris Dumez  <cdumez@apple.com>
1910
1911         [PSON] WebPageProxy::receivedNavigationPolicyDecision() should not schedule the new load asynchronously when process-swapping
1912         https://bugs.webkit.org/show_bug.cgi?id=191076
1913
1914         Reviewed by Geoffrey Garen.
1915
1916         Add API test coverage.
1917
1918         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1919         (-[PSONNavigationDelegate init]):
1920         (-[PSONNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1921
1922 2018-11-01  Adrian Perez de Castro  <aperez@igalia.com>
1923
1924         Fix build with VIDEO and WEB_AUDIO disabled
1925         https://bugs.webkit.org/show_bug.cgi?id=191147
1926         <rdar://problem/45726710>
1927
1928         Unreviewed build fix.
1929
1930         This adds the missing compilation guards in the WPE MiniBrowser.
1931
1932         * MiniBrowser/wpe/main.cpp:
1933         (main): Condition GST includes and calls.
1934
1935 2018-10-31  Zalan Bujtas  <zalan@apple.com>
1936
1937         [LFC][IFC] Add support for inline-block elements.
1938         https://bugs.webkit.org/show_bug.cgi?id=191143
1939
1940         Reviewed by Antti Koivisto.
1941
1942         * LayoutReloaded/misc/LFC-passing-tests.txt:
1943
1944 2018-11-01  Claudio Saavedra  <csaavedra@igalia.com>
1945
1946         [WPE] Add missing libsoup patch to jhbuild
1947         https://bugs.webkit.org/show_bug.cgi?id=191149
1948
1949         Reviewed by Žan Doberšek.
1950
1951         * wpe/jhbuild.modules:
1952         * wpe/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Added.
1953
1954 2018-11-01  Claudio Saavedra  <csaavedra@igalia.com>
1955
1956         Fix build with VIDEO and WEB_AUDIO disabled
1957         https://bugs.webkit.org/show_bug.cgi?id=191147
1958
1959         Reviewed by Philippe Normand.
1960
1961         * MiniBrowser/gtk/main.c:
1962         (main): Condition GST includes and calls
1963
1964 2018-10-31  Justin Michaud  <justin_michaud@apple.com>
1965
1966         Add Justin Michaud to the list of WebKit Committers
1967         https://bugs.webkit.org/show_bug.cgi?id=191142
1968
1969         * Scripts/webkitpy/common/config/contributors.json:
1970
1971 2018-10-31  Guillaume Emont  <guijemont@igalia.com>
1972
1973         Don't run JIT tests on 32-bit platforms
1974         https://bugs.webkit.org/show_bug.cgi?id=191074
1975
1976         Reviewed by Michael Catanzaro.
1977
1978         * Scripts/run-jsc-stress-tests:
1979
1980 2018-10-30  Wenson Hsieh  <wenson_hsieh@apple.com>
1981
1982         [Cocoa] Attachment dropped from one web view to another is missing its file wrapper
1983         https://bugs.webkit.org/show_bug.cgi?id=190530
1984         <rdar://problem/45232149>
1985
1986         Reviewed by Tim Horton.
1987
1988         Add a test to verify that copying different types of attachments and pasting in a new web view inserts
1989         attachments in the second web view that are backed by _WKAttachment objects, whose NSFileWrappers hold data that
1990         is equivalent to the original file wrappers used to insert attachments in the first web view.
1991
1992         Existing API tests verify that when copying and pasting within a single web view, the pasted attachment element
1993         is still backed by the same NSFileWrapper instance.
1994
1995         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1996         (TestWebKitAPI::TEST):
1997
1998 2018-10-30  Fujii Hironori  <Hironori.Fujii@sony.com>
1999
2000         [Win] Remove obsolete code for Visual Studio Express in webkitdirs.pm
2001         https://bugs.webkit.org/show_bug.cgi?id=190949
2002
2003         Reviewed by Alex Christensen.
2004
2005         Visual Studio 2017 Community is the alternative.
2006
2007         * Scripts/webkitdirs.pm: Remove $willUseVCExpressWhenBuilding variable.
2008         (setupCygwinEnv): Remove obsolete code for Visual Studio Express.
2009         (buildVisualStudioProject): Ditto.
2010         (dieIfWindowsPlatformSDKNotInstalled): Deleted.
2011         (usingVisualStudioExpress): Deleted.
2012
2013 2018-10-30  Fujii Hironori  <Hironori.Fujii@sony.com>
2014
2015         [Win][Direct2D] Support building DumpRenderTree for Direct2D
2016         https://bugs.webkit.org/show_bug.cgi?id=191093
2017         <rdar://problem/45685706>
2018
2019         Unreviewed build fix.
2020
2021         error C2065: 'renderTarget': undeclared identifier
2022
2023         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
2024         (createBitmapContextFromWebView): Restored the previous implementation.
2025
2026 2018-10-30  Don Olmstead  <don.olmstead@sony.com>
2027
2028         [PlayStation] Enable JavaScriptCore
2029         https://bugs.webkit.org/show_bug.cgi?id=191072
2030
2031         Reviewed by Brent Fulgham.
2032
2033         Add platform scripts for building the PlayStation port.
2034         perl Tools/Scripts/build-webkit --playstation
2035
2036         * Scripts/build-webkit:
2037         * Scripts/build-webkittestrunner:
2038         * Scripts/webkitdirs.pm:
2039         (argumentsForConfiguration):
2040         (determineConfigurationProductDir):
2041         (isPlayStation): Added.
2042         (getMSBuildPlatformArgument): Added.
2043         (buildVisualStudioProject):
2044         (wrapperPrefixIfNeeded):
2045         (generateBuildSystemFromCMakeProject):
2046         * TestWebKitAPI/PlatformPlayStation.cmake: Added.
2047
2048 2018-10-30  Brent Fulgham  <bfulgham@apple.com>
2049
2050         [Win][Direct2D] Support building DumpRenderTree for Direct2D
2051         https://bugs.webkit.org/show_bug.cgi?id=191093
2052         <rdar://problem/45685706>
2053
2054         Reviewed by Alex Christensen.
2055
2056         * DumpRenderTree/PixelDumpSupport.cpp: Update for Direct2D use.
2057         * DumpRenderTree/PlatformWin.cmake: Add support for Direct2D build.
2058         * DumpRenderTree/win/PixelDumpSupportDirect2D.cpp: Added.
2059         (pixelDumpSystemFactory): Added.
2060         (printPNG): Create stub.
2061         (computeMD5HashStringForBitmapContext): Ditto.
2062         (dumpBitmap): Ditto.
2063         * DumpRenderTree/win/PixelDumpSupportDirect2D.h: Added.
2064         (BitmapContext::createByAdoptingBitmapAndContext):
2065         (BitmapContext::~BitmapContext):
2066         (BitmapContext::platformContext const):
2067         (BitmapContext::BitmapContext):
2068         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
2069         (createBitmapContextFromWebView): Update to support Direct2D.
2070         * MiniBrowser/win/MiniBrowserReplace.h: Drive-by fix: The old WebKit
2071         logo is no longer available at this location. Switch to the new logo.
2072
2073 2018-10-30  Jonathan Bedard  <jbedard@apple.com>
2074
2075         webkitpy: Support alternate simctl list outputs
2076         https://bugs.webkit.org/show_bug.cgi?id=191090
2077         <rdar://problem/45684255>
2078
2079         Rubber-stamped by Aakash Jain.
2080
2081         * Scripts/webkitpy/xcode/simulated_device.py:
2082         (SimulatedDeviceManager._create_runtimes): Support alternative availability format.
2083         (SimulatedDeviceManager._create_device_with_runtime): Ditto.
2084         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
2085         (test_available_devices): Add iOS 12 with alternative availability format.
2086
2087 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2088
2089         Clean up some obsolete MAX_ALLOWED macros
2090         https://bugs.webkit.org/show_bug.cgi?id=190916
2091
2092         Reviewed by Tim Horton.
2093
2094         * TestWebKitAPI/Tests/WTF/darwin/WeakLinking.cpp:
2095         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2096         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2097
2098 2018-10-30  Claudio Saavedra  <csaavedra@igalia.com>
2099
2100         [GTK][WPE] Fixes to the PublicSuffix implementation
2101         https://bugs.webkit.org/show_bug.cgi?id=191031
2102
2103         Reviewed by Michael Catanzaro.
2104
2105         * TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:
2106         (TestWebKitAPI::TEST_F): Remove a test for a domain
2107         that is not registrable and shouldn't be tested there.
2108
2109 2018-10-29  Tim Horton  <timothy_horton@apple.com>
2110
2111         Modernize WebKit nibs and lprojs for localization's sake
2112         https://bugs.webkit.org/show_bug.cgi?id=190911
2113         <rdar://problem/45349466>
2114
2115         Reviewed by Dan Bernstein.
2116
2117         * Scripts/check-inspector-strings:
2118         * Scripts/update-webkit-localizable-strings:
2119         * gtk/manifest.txt.in:
2120         * wpe/manifest.txt.in:
2121         English->en
2122
2123 2018-10-29  Daniel Bates  <dabates@apple.com>
2124
2125         [lldb-webkit] Last aliased enumerator in OptionSet is printed; should print first enumerator
2126         https://bugs.webkit.org/show_bug.cgi?id=191036
2127
2128         Reviewed by Andy Estes.
2129
2130         Prefer the first enumerator (in parse order) when pretty-printing an OptionSet that is parameterized
2131         by an enum that contains two or more enumerators with the same value. For example, suppose
2132         you have the following enum:
2133
2134         enum Flag {
2135             A = 1 << 0,
2136             AAlias = A,
2137         };
2138
2139         Then pretty-printing OptionSet<Flag>(Flag::A) should print A instead of AAlias. A side effect of
2140         this change is that OptionSet<Flag>(Flag::AAlias) will also print A as its only member as we cannot
2141         differentiate between A and Alias. This should be acceptable in practice as aliased enumerators
2142         tend to be used in bounds checks as opposed to code that adds to a set.
2143
2144         * lldb/lldbWebKitTester/main.cpp:
2145         (testSummaryProviders):
2146         * lldb/lldb_webkit.py:
2147         (WTFOptionSetProvider.update):
2148         * lldb/lldb_webkit_unittest.py:
2149         (TestSummaryProviders.serial_test_WTFOptionSetProvider_simple):
2150         (TestSummaryProviders):
2151         (TestSummaryProviders.serial_test_WTFOptionSetProvider_aliased_flag):
2152
2153 2018-10-29  Daniel Bates  <dabates@apple.com>
2154
2155         [llbd-webkit] Add summaries for Document, Frame, and SecurityOrigin
2156         https://bugs.webkit.org/show_bug.cgi?id=191033
2157
2158         Reviewed by Andy Estes.
2159
2160         For Documents we display its origin, URL, whether it's in the main frame, and its page cache state.
2161         We display the same details in the summary for a Frame because its Document tends to be the most
2162         interesting aspect of it. For SecurityOrigin we display its origin, domain (affects cookie access),
2163         and whether the origin has universal access.
2164
2165         * lldb/lldb_webkit.py:
2166         (__lldb_init_module):
2167         Register new summary providers.
2168
2169         (WebCoreSecurityOrigin_SummaryProvider):
2170         (WebCoreFrame_SummaryProvider):
2171         (WebCoreDocument_SummaryProvider):
2172         Add new summary providers.
2173
2174         (StdOptionalWrapper):
2175         (StdOptionalWrapper.__init__):
2176         (StdOptionalWrapper.has_value):
2177         (StdOptionalWrapper.value):
2178         Convenience data type that provides access to the fields of a std::optional<>.
2179         
2180         (WebCoreSecurityOriginProvider):
2181         (WebCoreSecurityOriginProvider.__init__):
2182         (WebCoreSecurityOriginProvider.is_unique):
2183         (WebCoreSecurityOriginProvider.scheme):
2184         (WebCoreSecurityOriginProvider.host):
2185         (WebCoreSecurityOriginProvider.port):
2186         (WebCoreSecurityOriginProvider.domain):
2187         (WebCoreSecurityOriginProvider.has_universal_access):
2188         (WebCoreSecurityOriginProvider.to_string):
2189         (WebCoreFrameProvider):
2190         (WebCoreFrameProvider.__init__):
2191         (WebCoreFrameProvider.is_main_frame):
2192         (WebCoreFrameProvider.document):
2193         (WebCoreDocumentProvider):
2194         (WebCoreDocumentProvider.__init__):
2195         (WebCoreDocumentProvider.url):
2196         (WebCoreDocumentProvider.origin):
2197         (WebCoreDocumentProvider.page_cache_state):
2198         (WebCoreDocumentProvider.frame):
2199
2200 2018-10-29  Chris Dumez  <cdumez@apple.com>
2201
2202         [PSON] When Safari restores session state after launching, going back and forward does not swap processes
2203         https://bugs.webkit.org/show_bug.cgi?id=190975
2204         <rdar://problem/45059256>
2205
2206         Reviewed by Antti Koivisto.
2207
2208         Add API test coverage.
2209
2210         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2211
2212 2018-10-29  Zalan Bujtas  <zalan@apple.com>
2213
2214         [LFC][IFC] Compute estimated margin top for inline formatting root's ancestors
2215         https://bugs.webkit.org/show_bug.cgi?id=191018
2216
2217         Reviewed by Antti Koivisto.
2218
2219         * LayoutReloaded/misc/LFC-passing-tests.txt:
2220
2221 2018-10-29  Zalan Bujtas  <zalan@apple.com>
2222
2223         [LFC] Add support for inflow non replaced content height when the box is an inline formatting root.
2224         https://bugs.webkit.org/show_bug.cgi?id=191011
2225
2226         Reviewed by Antti Koivisto.
2227
2228         * LayoutReloaded/misc/LFC-passing-tests.txt:
2229
2230 2018-10-29  Zalan Bujtas  <zalan@apple.com>
2231
2232         Missing from r237549
2233
2234         Reviewed by Antti Koivisto.
2235
2236         * LayoutReloaded/misc/LFC-passing-tests.txt:
2237
2238 2018-10-29  Zalan Bujtas  <zalan@apple.com>
2239
2240         [LFC][IFC] Add support for simple intruding floats.
2241         https://bugs.webkit.org/show_bug.cgi?id=190998
2242
2243         Reviewed by Antti Koivisto.
2244
2245         * LayoutReloaded/misc/LFC-passing-tests.txt:
2246
2247 2018-10-29  Zalan Bujtas  <zalan@apple.com>
2248
2249         [LFC][IFC] Inline layout produces separate runs when float is present.
2250         https://bugs.webkit.org/show_bug.cgi?id=190980
2251
2252         Reviewed by Antti Koivisto.
2253
2254         * LayoutReloaded/misc/LFC-passing-tests.txt:
2255
2256 2018-10-29  Tadeu Zagallo  <tzagallo@apple.com>
2257
2258         New bytecode format for JSC
2259         https://bugs.webkit.org/show_bug.cgi?id=187373
2260         <rdar://problem/44186758>
2261
2262         Reviewed by Filip Pizlo.
2263
2264         Do not force ENABLE_JIT=true when $forceCLoop is false.
2265
2266         * Scripts/build-jsc:
2267
2268 2018-10-29  Claudio Saavedra  <csaavedra@igalia.com>
2269
2270         [GTK] Try to fix the xserver-xorg build in the Ubuntu LTS bot
2271
2272         Unreviewed build fix
2273
2274         The build fails because of some array-bound check related
2275         to strcmp() macro optimizations. Disabling selective Werrors
2276         when building xserver-xorg might get past this.
2277
2278         * gtk/jhbuild.modules: Add --disable-selective-werror to xserver-xorg
2279         configuration.
2280
2281 2018-10-29  Claudio Saavedra  <csaavedra@igalia.com>
2282
2283         [GTK] Update API test expectations after r237383
2284         https://bugs.webkit.org/show_bug.cgi?id=186913
2285
2286         Unreviewed gardening.
2287
2288         * TestWebKitAPI/glib/TestExpectations.json: Remove
2289         passing TestSSL tests.
2290
2291 2018-10-28  Zan Dobersek  <zdobersek@igalia.com>
2292
2293         [WPE] Add the WebKitVersion.h header
2294         https://bugs.webkit.org/show_bug.cgi?id=191015
2295
2296         Reviewed by Michael Catanzaro.
2297
2298         * MiniBrowser/wpe/main.cpp:
2299         (automationStartedCallback): Remove the FIXME and finally enable the
2300         webkit_application_info_set_version() call.
2301         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp: Remove
2302         this FIXME as well and remove the custom WEBKIT_*_VERSION macros.
2303
2304 2018-10-28  Fujii Hironori  <Hironori.Fujii@sony.com>
2305
2306         [Win] Remove obsolete code for vcxproj builds in build-api-tests and build-jsc
2307         https://bugs.webkit.org/show_bug.cgi?id=190948
2308
2309         Reviewed by Brent Fulgham.
2310
2311         vcxproj files have been removed in Bug 154388.
2312
2313         * Scripts/build-api-tests: Removed obsolete code to build vcproj.
2314         * Scripts/build-jsc:
2315         (buildMyProject): Ditto. Removed a condition of buiding bmalloc
2316         which is not used because Windows ports are using CMake.
2317
2318 2018-10-28  Geoffrey Garen  <ggaren@apple.com>
2319
2320         HashMap should support selecting a random entry
2321         https://bugs.webkit.org/show_bug.cgi?id=190814
2322
2323         Reviewed by Ryosuke Niwa.
2324
2325         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Renamed IsRandom to
2326         IsEvenlyDistributed to reflect the fact that we're only testing the
2327         distribution. Added a test case that covers more table densities and
2328         the remove() operation.
2329
2330 2018-10-27  Charlie Turner  <cturner@igalia.com>
2331
2332         [GTK] Add bubblewrap feature option
2333         https://bugs.webkit.org/show_bug.cgi?id=190981
2334
2335         Reviewed by Xabier Rodriguez-Calvar.
2336
2337         Without this, it was not possible to disable the bubblewrap sandbox
2338         from the webkit build scripts.
2339
2340         * Scripts/webkitperl/FeatureList.pm:
2341
2342 2018-10-26  Commit Queue  <commit-queue@webkit.org>
2343
2344         Unreviewed, rolling out r237479 and r237484.
2345         https://bugs.webkit.org/show_bug.cgi?id=190978
2346
2347         broke JSC on iOS (Requested by tadeuzagallo on #webkit).
2348
2349         Reverted changesets:
2350
2351         "New bytecode format for JSC"
2352         https://bugs.webkit.org/show_bug.cgi?id=187373
2353         https://trac.webkit.org/changeset/237479
2354
2355         "Gardening: Build fix after r237479."
2356         https://bugs.webkit.org/show_bug.cgi?id=187373
2357         https://trac.webkit.org/changeset/237484
2358
2359 2018-10-26  Tadeu Zagallo  <tzagallo@apple.com>
2360
2361         New bytecode format for JSC
2362         https://bugs.webkit.org/show_bug.cgi?id=187373
2363         <rdar://problem/44186758>
2364
2365         Reviewed by Filip Pizlo.
2366
2367         Do not force ENABLE_JIT=true when $forceCLoop is false.
2368
2369         * Scripts/build-jsc:
2370
2371 2018-10-26  Geoffrey Garen  <ggaren@apple.com>
2372
2373         HashMap should support selecting a random entry
2374         https://bugs.webkit.org/show_bug.cgi?id=190814
2375
2376         Reviewed by Antti Koivisto.
2377
2378         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Updated the Random_IsRandom to
2379         more thoroughly test for randomness.
2380
2381 2018-10-26  Antti Koivisto  <antti@apple.com>
2382
2383         hashSet.remove(hashSet.random()) doesn't build
2384         https://bugs.webkit.org/show_bug.cgi?id=190953
2385
2386         Reviewed by Chris Dumez.
2387
2388         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2389         (TestWebKitAPI::TEST):
2390
2391 2018-10-26  Zalan Bujtas  <zalan@apple.com>
2392
2393         [LFC][IFC] Layout floats as part of the inline content
2394         https://bugs.webkit.org/show_bug.cgi?id=190942
2395
2396         Reviewed by Antti Koivisto.
2397
2398         * LayoutReloaded/misc/LFC-passing-tests.txt:
2399
2400 2018-10-26  Alicia Boya García  <aboya@igalia.com>
2401
2402         [MSE][WTF][Media] Invalid MediaTime should be falsy
2403         https://bugs.webkit.org/show_bug.cgi?id=190893
2404
2405         Reviewed by Jer Noble.
2406
2407         This patch adds additional API tests for the conversions from
2408         MediaTime to boolean.
2409
2410         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
2411         (TestWebKitAPI::TEST):
2412
2413 2018-10-25  Chris Dumez  <cdumez@apple.com>
2414
2415         [PSON] Navigating cross-site with locked history but unlocked back/forward list fails to create a new BackForwardListItem
2416         https://bugs.webkit.org/show_bug.cgi?id=190915
2417         <rdar://problem/45059069>
2418
2419         Reviewed by Geoffrey Garen.
2420
2421         Add API test coverage.
2422
2423         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2424
2425 2018-10-25  Joseph Pecoraro  <pecoraro@apple.com>
2426
2427         Web Inspector: Add a watchlist message rule to warn about feature checking new inspector protocol changes
2428         https://bugs.webkit.org/show_bug.cgi?id=190896
2429
2430         Reviewed by Matt Baker.
2431
2432         * Scripts/webkitpy/common/config/watchlist:
2433
2434 2018-10-25  Geoffrey Garen  <ggaren@apple.com>
2435
2436         HashMap should support selecting a random entry
2437         https://bugs.webkit.org/show_bug.cgi?id=190814
2438
2439         Reviewed by Antti Koivisto.
2440
2441         Unit testing is fun and easy!
2442
2443         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2444         (TestWebKitAPI::ZeroHash::hash):
2445         (TestWebKitAPI::TEST):
2446
2447 2018-10-24  Tim Horton  <timothy_horton@apple.com>
2448
2449         REGRESSION (r237331): DismissingActionSheetShouldNotDismissPresentingViewController times out
2450         https://bugs.webkit.org/show_bug.cgi?id=190897
2451
2452         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2453         (TestWebKitAPI::TEST):
2454         Disable the test for now.
2455
2456 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
2457
2458         Clean up some obsolete macOS version guards
2459         https://bugs.webkit.org/show_bug.cgi?id=190887
2460
2461         Reviewed by Dan Bernstein.
2462
2463         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2464         (__simulated_forceClickAssociatedEventsMask):
2465         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:clickCount:]):
2466         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2467         (WTR::initializeWebViewConfiguration):
2468         * WebKitTestRunner/mac/EventSenderProxy.mm:
2469         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
2470
2471 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
2472
2473         Turn on Conic Gradients
2474         https://bugs.webkit.org/show_bug.cgi?id=190810
2475
2476         Reviewed by Tim Horton.
2477
2478         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2479
2480 2018-10-24  Pablo Saavedra  <psaavedra@igalia.com>
2481
2482         [WPE] Fix CMake rules in for TestWebKitAPIBase library building in developer mode
2483         https://bugs.webkit.org/show_bug.cgi?id=190328
2484
2485         Reviewed by Michael Catanzaro.
2486
2487         * TestWebKitAPI/CMakeLists.txt:
2488         * TestWebKitAPI/PlatformWPE.cmake:
2489
2490 2018-10-24  Chris Dumez  <cdumez@apple.com>
2491
2492         [PSON] When navigating back and forth, 'about:blank' shows up in the back/forward list
2493         https://bugs.webkit.org/show_bug.cgi?id=190846
2494         <rdar://problem/45058938>
2495
2496         Reviewed by Antti Koivisto.
2497
2498         Add API test coverage.
2499
2500         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2501
2502 2018-10-24  Claudio Saavedra  <csaavedra@igalia.com>
2503
2504         [GTK] TestSSL failing because of missing libsoup patch
2505         https://bugs.webkit.org/show_bug.cgi?id=190869
2506
2507         Reviewed by Michael Catanzaro.
2508
2509         * gtk/jhbuild.modules: Add the patch below to fix the API test TestSSL
2510         * gtk/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Added.
2511
2512 2018-10-23  Justin Fan  <justin_fan@apple.com>
2513
2514         [WebGPU] Rename old GPU* implementation files to GPULegacy* for WebMetal
2515         https://bugs.webkit.org/show_bug.cgi?id=190817
2516
2517         Reviewed by Dean Jackson.
2518
2519         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2520         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUBuffer.mm.
2521         (TestWebKitAPI::TEST_F):
2522         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Copied from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm.
2523         (TestWebKitAPI::TEST_F):
2524         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUDevice.mm.
2525         (TestWebKitAPI::TEST_F):
2526         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm.
2527         (TestWebKitAPI::TEST_F):
2528         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm.
2529         (TestWebKitAPI::TEST_F):
2530         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUTest.h.
2531
2532 2018-10-23  Chris Dumez  <cdumez@apple.com>
2533
2534         [PSON] Add support for cross-site client-side redirects
2535         https://bugs.webkit.org/show_bug.cgi?id=190806
2536         <rdar://problem/45047344>
2537
2538         Reviewed by Geoffrey Garen.
2539
2540         Add API test coverage.
2541
2542         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2543         (-[PSONNavigationDelegate _webView:willPerformClientRedirectToURL:delay:]):
2544         (-[PSONNavigationDelegate _webView:didPerformClientRedirectFromURL:toURL:]):
2545
2546 2018-10-23  Claudio Saavedra  <csaavedra@igalia.com>
2547
2548         [WPE][GTK] Pass full certificate chain in CertificateInfo coder
2549         https://bugs.webkit.org/show_bug.cgi?id=190789
2550
2551         Reviewed by Michael Catanzaro.
2552
2553         When the network process serializes certificate data to other
2554         processes through the argument coders, the certificate chain, if
2555         present, is lost. In practice this means that applications using
2556         the public API to process certificate info have no details on the
2557         certificate chain, other than the very basics included in the
2558         certificate. Serialize the entire chain if available in the
2559         certificate.
2560
2561         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
2562         (testSSL): Test that the self-signed certificate has no bogus
2563         issuer certificate.
2564
2565 2018-10-22  Tim Horton  <timothy_horton@apple.com>
2566
2567         REGRESSION (r237331): InteractionDeadlockAfterCrash API test fails
2568         https://bugs.webkit.org/show_bug.cgi?id=190801
2569         <rdar://problem/43674361>
2570
2571         * TestWebKitAPI/Tests/WebKitCocoa/InteractionDeadlockAfterCrash.mm:
2572         (TEST):
2573         Use a parented WKWebView for this test, otherwise none of the assertions
2574         about gesture recognizers work anymore.
2575
2576 2018-10-22  Ryan Haddad  <ryanhaddad@apple.com>
2577
2578         REGRESSION (r234081): TestWebKitAPI.VideoControlsManager.VideoControlsManagerAudioElementFollowingUserInteraction is a flaky timeout
2579         https://bugs.webkit.org/show_bug.cgi?id=187972
2580
2581         Unreviewed test gardening.
2582
2583         * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
2584         (TestWebKitAPI::TEST): Disable the flaky test.
2585
2586 2018-10-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2587
2588         [iOS] [Datalist] fast/forms/datalist/datalist-show-hide.html fails
2589         https://bugs.webkit.org/show_bug.cgi?id=190777
2590
2591         Reviewed by Tim Horton.
2592
2593         Implement isShowingDataListSuggestions on iOS. See below for more details.
2594
2595         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2596         (WTR::UIScriptController::isShowingDataListSuggestions const):
2597
2598         Add a stub implementation for DumpRenderTree.
2599
2600         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2601         (WTR::UIScriptController::isShowingDataListSuggestions const):
2602
2603         Move this stub implementation to !PLATFORM(COCOA).
2604
2605         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2606         (WTR::forEachViewInHierarchy):
2607
2608         Add a helper function to apply a given function to a UIView and each of its subviews, recursively.
2609
2610         (WTR::UIScriptController::isShowingDataListSuggestions const):
2611
2612         For iOS, return whether the UIRemoteKeyboardWindow contains a subview of type WKDataListSuggestionsPickerView.
2613
2614 2018-10-19  Dan Bernstein  <mitz@apple.com>
2615
2616         [macOS] MiniBrowser has an unused injected bundle
2617         https://bugs.webkit.org/show_bug.cgi?id=190770
2618
2619         Reviewed by Tim Horton.
2620
2621         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Removed.
2622         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Removed the MiniBrowserBundle target,
2623           the Copy Bundle build phase in the MiniBrowser target, and references to removed files.
2624         * MiniBrowser/MiniBrowserWebProcessPlugIn.h: Removed.
2625         * MiniBrowser/MiniBrowserWebProcessPlugIn.m: Removed.
2626         * MiniBrowser/mac/Bundle: Removed.
2627
2628 2018-10-19  Wenson Hsieh  <wenson_hsieh@apple.com>
2629
2630         [iOS] [Datalist] Can't pick datalist suggestions in a stock WKWebView
2631         https://bugs.webkit.org/show_bug.cgi?id=190621
2632         <rdar://problem/45310649>
2633
2634         Reviewed by Tim Horton.
2635
2636         Add a UIScriptController hook to resign first responder on WKWebView. See LayoutTests/ChangeLog for more detail.
2637
2638         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2639         (WTR::UIScriptController::resignFirstResponder):
2640         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2641         (WTR::UIScriptController::resignFirstResponder):
2642         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2643         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2644         (WTR::UIScriptController::resignFirstResponder):
2645         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2646         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2647         (WTR::UIScriptController::resignFirstResponder):
2648         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2649         (WTR::PlatformWebView::makeWebViewFirstResponder):
2650
2651         Implement this method stub on iOS, to ensure that TestController::resetStateToConsistentValues restores first
2652         responder on the WKWebView when running iOS layout tests.
2653
2654         * WebKitTestRunner/ios/TestControllerIOS.mm:
2655         (WTR::TestController::platformResetStateToConsistentValues):
2656
2657         After resigning first responder to dismiss any on-screen keyboard, ensure that we restore first responder.
2658
2659 2018-10-19  Dean Jackson  <dino@apple.com>
2660
2661         ASSERTION FAILED: !frame().animation().hasAnimations() in WebCore::FrameView::didDestroyRenderTree()
2662         https://bugs.webkit.org/show_bug.cgi?id=186946
2663         <rdar://problem/41724248>
2664
2665         Reviewed by Antoine Quint.
2666
2667         If the incoming test has different enableWebAnimationsCSSIntegration options,
2668         then we need to create a new WebView.
2669
2670         * DumpRenderTree/TestOptions.cpp:
2671         (TestOptions::webViewIsCompatibleWithOptions const):
2672
2673 2018-10-19  Charlie Turner  <cturner@igalia.com>
2674
2675         [EME] Fix crash during tracing in  gst_qtdemux_request_protection_context
2676         https://bugs.webkit.org/show_bug.cgi?id=190738
2677
2678         Reviewed by Xabier Rodriguez-Calvar.
2679
2680         Add a GStreamer patch to avoid crashing when the run-time logging
2681         level is TRACE. There was a missing null check which caused many
2682         tests to crash.
2683
2684         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Added.
2685
2686 2018-10-18  Alicia Boya García  <aboya@igalia.com>
2687
2688         [Media] Use nanoseconds as MaximumTimeScale
2689         https://bugs.webkit.org/show_bug.cgi?id=190631
2690
2691         Rebased MediaTime tests covering timescales over the maximum.
2692
2693         Reviewed by Jer Noble.
2694
2695         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
2696         (TestWebKitAPI::TEST):
2697
2698 2018-10-18  Dean Johnson  <dean_johnson@apple.com>
2699
2700         clean-webkit pulls in many unnecessary dependencies in webkitpy
2701         https://bugs.webkit.org/show_bug.cgi?id=190732
2702
2703         Reviewed by Alexey Proskuryakov.
2704
2705         * Scripts/webkitpy/common/host.py:
2706         (Host.__init__): Split out 'bugs', 'bugzilla', and 'web' to only be created when used.
2707         (Host):
2708         (Host.bugs):
2709         (Host.bugzilla):
2710         (Host.web):
2711
2712 2018-10-18  Chris Dumez  <cdumez@apple.com>
2713
2714         [PSON] SuspendedPages do not report meaningful domains in Activity Monitor
2715         https://bugs.webkit.org/show_bug.cgi?id=190721
2716         <rdar://problem/45059699>
2717
2718         Reviewed by Alex Christensen.
2719
2720         Add API test coverage.
2721
2722         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2723
2724 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
2725
2726         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
2727         https://bugs.webkit.org/show_bug.cgi?id=190729
2728
2729         Reviewed by Tim Horton.
2730
2731         * DumpRenderTree/AccessibilityController.h:
2732         * DumpRenderTree/AccessibilityTextMarker.h:
2733         * DumpRenderTree/AccessibilityUIElement.cpp:
2734         (AccessibilityUIElement::getJSClass):
2735         * DumpRenderTree/AccessibilityUIElement.h:
2736         * DumpRenderTree/DumpRenderTreeFileDraggingSource.h:
2737         * DumpRenderTree/TestRunner.cpp:
2738         (getSecureEventInputIsEnabledCallback):
2739         (TestRunner::staticFunctions):
2740         (TestRunner::callUIScriptCallback):
2741         * DumpRenderTree/TestRunner.h:
2742         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2743         * DumpRenderTree/ios/AccessibilityTextMarkerIOS.mm:
2744         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2745         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm:
2746         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:
2747         * DumpRenderTree/ios/TextInputControllerIOS.m:
2748         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2749         * DumpRenderTree/mac/AppleScriptController.m:
2750         * DumpRenderTree/mac/DumpRenderTree.mm:
2751         (createWebViewAndOffscreenWindow):
2752         (destroyWebViewAndOffscreenWindow):
2753         (resetWebPreferencesToConsistentValues):
2754         (setDefaultsToConsistentValuesForTesting):
2755         (allocateGlobalControllers):
2756         (releaseGlobalControllers):
2757         (addTestPluginsToPluginSearchPath):
2758         (prepareConsistentTestingEnvironment):
2759         (dumpRenderTree):
2760         (DumpRenderTreeMain):
2761         (dumpFrameAsPDF):
2762         (dumpBackForwardListForAllWindows):
2763         (updateDisplay):
2764         (dump):
2765         (resetWebViewToConsistentStateBeforeTesting):
2766         (runTest):
2767         (displayWebView):
2768         (displayAndTrackRepaintsWebView):
2769         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
2770         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2771         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2772         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
2773         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2774         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2775         (-[DumpRenderTreeWindow close]):
2776         (-[DumpRenderTreeWindow webView]):
2777         (-[DumpRenderTreeWindow webViewStartedAcceleratedCompositing:]):
2778         * DumpRenderTree/mac/EventSendingController.h:
2779         * DumpRenderTree/mac/EventSendingController.mm:
2780         (+[EventSendingController isSelectorExcludedFromWebScript:]):
2781         (+[EventSendingController webScriptNameForSelector:]):
2782         (-[EventSendingController dealloc]):
2783         (-[EventSendingController currentEventTime]):
2784         (-[EventSendingController clearKillRing]):
2785         (modifierFlags):
2786         (-[EventSendingController mouseDown:withModifiers:]):
2787         (-[EventSendingController scalePageBy:atX:andY:]):
2788         (-[EventSendingController mouseUp:withModifiers:]):
2789         (-[EventSendingController mouseMoveToX:Y:]):
2790         (-[EventSendingController mouseScrollByX:andY:continuously:]):
2791         (-[EventSendingController keyDown:withModifiers:withLocation:]):
2792         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2793         (-[FrameLoadDelegate init]):
2794         (-[FrameLoadDelegate dealloc]):
2795         (-[FrameLoadDelegate processWork:]):
2796         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2797         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
2798         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
2799         * DumpRenderTree/mac/LayoutTestHelper.m:
2800         * DumpRenderTree/mac/MockGeolocationProvider.mm:
2801         (-[MockGeolocationProvider timerFired]):
2802         * DumpRenderTree/mac/TestRunnerMac.mm:
2803         (TestRunner::setMainFrameIsFirstResponder):
2804         (TestRunner::setAutomaticLinkDetectionEnabled):
2805         (TestRunner::setUseDashboardCompatibilityMode):
2806         (TestRunner::isCommandEnabled):
2807         (TestRunner::inspectorTestStubURL):
2808         (TestRunner::apiTestNewWindowDataLoadBaseURL):
2809         (TestRunner::abortModal):
2810         (TestRunner::setTextDirection):
2811         (TestRunner::addChromeInputField):
2812         (TestRunner::removeChromeInputField):
2813         (TestRunner::focusWebView):
2814         (TestRunner::setBackingScaleFactor):
2815         (TestRunner::imageCountInGeneralPasteboard const):
2816         * DumpRenderTree/mac/UIDelegate.h:
2817         * DumpRenderTree/mac/UIDelegate.mm:
2818         (-[UIDelegate modalWindowWillClose:]):
2819         (-[UIDelegate webViewRunModal:]):
2820         (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]):
2821         (-[UIDelegate dealloc]):
2822         * Scripts/check-for-inappropriate-objc-class-names:
2823         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2824         * TestRunnerShared/spi/UIKitTestSPI.h:
2825         * TestWebKitAPI/Tests/WTF/darwin/WeakLinking.cpp:
2826         * TestWebKitAPI/Tests/WebCore/MarkedText.cpp:
2827         (WebCore::operator<<):
2828         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
2829         (TestWebKitAPI::TEST):
2830         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
2831         (TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
2832         * TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp:
2833         * TestWebKitAPI/Tests/WebKit/NoHistoryItemScrollToFragment.mm:
2834         (TestWebKitAPI::TEST):
2835         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
2836         (TestWebKitAPI::TEST):
2837         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLs.mm:
2838         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
2839         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegate.mm:
2840         (TEST):
2841         * TestWebKitAPI/Tests/WebKitCocoa/BundleRangeHandle.mm:
2842         (TEST):
2843         * TestWebKitAPI/Tests/WebKitCocoa/BundleRangeHandlePlugIn.mm:
2844         (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
2845         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm:
2846         (TEST):
2847         * TestWebKitAPI/Tests/WebKitCocoa/CopyHTML.mm:
2848         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
2849         (createWebViewWithCustomPasteboardDataEnabled):
2850         * TestWebKitAPI/Tests/WebKitCocoa/Copying.mm:
2851         (TEST):
2852         * TestWebKitAPI/Tests/WebKitCocoa/DataDetection.mm:
2853         * TestWebKitAPI/Tests/WebKitCocoa/DoAfterNextPresentationUpdateAfterCrash.mm:
2854         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
2855         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
2856         * TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
2857         * TestWebKitAPI/Tests/WebKitCocoa/FixedLayoutSize.mm:
2858         * TestWebKitAPI/Tests/WebKitCocoa/FontAttributes.mm:
2859         * TestWebKitAPI/Tests/WebKitCocoa/Geolocation.mm:
2860         * TestWebKitAPI/Tests/WebKitCocoa/InteractionDeadlockAfterCrash.mm:
2861         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageClear.mm:
2862         (defaultWebsiteCacheDirectory):
2863         (defaultApplicationCacheDirectory):
2864         (TEST):
2865         * TestWebKitAPI/Tests/WebKitCocoa/NSFileManagerExtras.mm:
2866         * TestWebKitAPI/Tests/WebKitCocoa/NowPlaying.mm:
2867         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
2868         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
2869         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
2870         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
2871         (TestWebKitAPI::TEST):
2872         * TestWebKitAPI/Tests/WebKitCocoa/PasteRTFD.mm:
2873         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
2874         * TestWebKitAPI/Tests/WebKitCocoa/RenderedImageWithOptions.mm:
2875         (runTestWithWidth):
2876         * TestWebKitAPI/Tests/WebKitCocoa/RenderedImageWithOptionsPlugIn.mm:
2877         (-[RenderedImageWithOptionsPlugIn renderImageWithWidth:completionHandler:]):
2878         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2879         * TestWebKitAPI/Tests/WebKitCocoa/ShrinkToFit.mm:
2880         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
2881         * TestWebKitAPI/Tests/WebKitCocoa/VisibleContentRect.mm:
2882         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2883         (platformCopyRichTextWithMultipleAttachments):
2884         (platformCopyRichTextWithImage):
2885         (platformCopyPNG):
2886         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
2887         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
2888         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2889         * TestWebKitAPI/Tests/WebKitCocoa/WKPDFViewStablePresentationUpdateCallback.mm:
2890         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
2891         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-leaks.mm:
2892         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
2893         (TEST):
2894         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2895         (TEST):
2896         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2897         (TEST):
2898         * TestWebKitAPI/Tests/WebKitCocoa/_WKInputDelegate.mm:
2899         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
2900         * TestWebKitAPI/Tests/WebKitLegacy/ios/SnapshotViaRenderInContext.mm:
2901         * TestWebKitAPI/Tests/WebKitLegacy/mac/AccessingPastedImage.mm:
2902         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
2903         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2904         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2905         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2906         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2907         * TestWebKitAPI/Tests/ios/RenderingProgressTests.mm:
2908         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
2909         * TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm:
2910         * TestWebKitAPI/Tests/ios/SynchronousTimeoutTests.mm:
2911         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
2912         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
2913         * TestWebKitAPI/Tests/ios/TextAutosizingBoost.mm:
2914         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2915         * TestWebKitAPI/Tests/ios/WKScrollViewDelegate.mm:
2916         * TestWebKitAPI/Tests/ios/WKScrollViewTests.mm:
2917         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2918         * TestWebKitAPI/Tests/ios/WKWebViewEditActions.mm:
2919         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2920         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2921         (-[WKWebView _test_waitForDidFinishNavigation]):
2922         * TestWebKitAPI/cocoa/TestWKWebView.h:
2923         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2924         * TestWebKitAPI/config.h:
2925         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2926         * TestWebKitAPI/ios/TestWKWebViewController.h:
2927         * TestWebKitAPI/ios/TestWKWebViewController.mm:
2928         * TestWebKitAPI/ios/UIKitSPI.h:
2929         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2930         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2931         (WTR::InjectedBundle::beginTesting):
2932         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2933         (WTR::TestRunner::inspectorTestStubURL):
2934         * WebKitTestRunner/TestController.cpp:
2935         (WTR::TestController::webProcessName):
2936         (WTR::TestController::networkProcessName):
2937         * WebKitTestRunner/TestInvocation.cpp:
2938         (WTR::TestInvocation::invoke):
2939         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2940         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2941         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2942         (WTR::initializeWebViewConfiguration):
2943         (WTR::TestController::platformCreateWebView):
2944         (WTR::TestController::imageCountInGeneralPasteboard const):
2945         (WTR::TestController::addTestKeyToKeychain):
2946         (WTR::TestController::cleanUpKeychain):
2947         (WTR::TestController::keyExistsInKeychain):
2948         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2949         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2950         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2951
2952 2018-10-18  Chris Dumez  <cdumez@apple.com>
2953
2954         [PSON] Cap number of SuspendedPageProxy objects and allow a WebPageProxy to have more than one
2955         https://bugs.webkit.org/show_bug.cgi?id=190688
2956         <rdar://problem/45354095>
2957
2958         Reviewed by Antti Koivisto.
2959
2960         Extended API test coverage to confirm that:
2961         - We do not accumulate more than 3 suspended processes.
2962         - We can navigate back 3 times and use the page cache for each of these loads.
2963
2964         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2965
2966 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2967
2968         Enable the datalist element by default on iOS and macOS
2969         https://bugs.webkit.org/show_bug.cgi?id=190594
2970         <rdar://problem/45281159>
2971
2972         Reviewed by Ryosuke Niwa and Tim Horton.
2973
2974         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2975
2976 2018-10-17  Chris Fleizach  <cfleizach@apple.com>
2977
2978         AX: Certain tags should identify their context to iOS API
2979         https://bugs.webkit.org/show_bug.cgi?id=190622
2980         <rdar://problem/45308194>
2981
2982         Reviewed by Zalan Bujtas.
2983
2984         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2985         (AccessibilityUIElement::stringAttributeValue):
2986         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2987         (WTR::AccessibilityUIElement::stringAttributeValue):
2988
2989 2018-10-16  Sihui Liu  <sihui_liu@apple.com>
2990
2991         Add a switch for Web SQL
2992         https://bugs.webkit.org/show_bug.cgi?id=190271
2993
2994         Reviewed by Ryosuke Niwa.
2995
2996         * WebKitTestRunner/TestController.cpp:
2997         (WTR::TestController::resetPreferencesToConsistentValues):
2998
2999 2018-10-16  Alex Christensen  <achristensen@webkit.org>
3000
3001         Remove InjectedBundleBackForwardList
3002         https://bugs.webkit.org/show_bug.cgi?id=190640
3003
3004         Reviewed by Chris Dumez.
3005
3006         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3007         (WTR::InjectedBundle::dumpBackForwardListsForAllPages):
3008         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3009         (WTR::InjectedBundlePage::prepare):
3010         (WTR::InjectedBundlePage::dumpHistory):
3011         (WTR::hasPrefix): Deleted.
3012         (WTR::compareByTargetName): Deleted.
3013         (WTR::dumpBackForwardListItem): Deleted.
3014         (WTR::InjectedBundlePage::dumpBackForwardList): Deleted.
3015         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3016         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3017         (WTR::TestRunner::clearBackForwardList):
3018
3019 2018-10-16  Dominik Infuehr  <dinfuehr@igalia.com>
3020
3021         Unreviewed, added myself to contributors.json.
3022
3023         * Scripts/webkitpy/common/config/contributors.json:
3024
3025 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
3026
3027         Implement feature flag and bindings for CSS Painting API
3028         https://bugs.webkit.org/show_bug.cgi?id=190237
3029
3030         Reviewed by Ryosuke Niwa.
3031
3032         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3033
3034 2018-10-16  Philippe Normand  <pnormand@igalia.com>
3035
3036         Unreviewed, GTK Ubuntu LTS Jhbuild prospective build fix
3037
3038         * gstreamer/jhbuild.modules:
3039
3040 2018-10-16  Philippe Normand  <pnormand@igalia.com>
3041
3042         [GTK][JHBuild] Disable libmount support in glib
3043
3044         Rubber-stamped by Alejandro G. Castro.
3045
3046         This feature doesn't seem required for our setup.
3047
3048         * gtk/jhbuild.modules:
3049
3050 2018-10-15  Justin Fan  <justin_fan@apple.com>
3051
3052         Add WebGPU 2018 feature flag and experimental feature flag
3053         https://bugs.webkit.org/show_bug.cgi?id=190509
3054
3055         Reviewed by Dean Jackson.
3056
3057         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
3058         for the 2018 WebGPU prototype.
3059
3060         * DumpRenderTree/TestOptions.cpp:
3061         (TestOptions::TestOptions):
3062         * DumpRenderTree/TestOptions.h:
3063         * DumpRenderTree/mac/DumpRenderTree.mm:
3064         (setWebPreferencesForTestOptions):
3065         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3066
3067 2018-10-15  Ryan Haddad  <ryanhaddad@apple.com>
3068
3069         Update bot configuration for Sierra archive queues
3070         https://bugs.webkit.org/show_bug.cgi?id=190605
3071
3072         Reviewed by Aakash Jain.
3073
3074         * BuildSlaveSupport/build.webkit.org-config/config.json:
3075
3076 2018-10-15  Timothy Hatcher  <timothy@apple.com>
3077
3078         Add support for prefers-color-scheme media query
3079         https://bugs.webkit.org/show_bug.cgi?id=190499
3080         rdar://problem/45212025
3081
3082         Reviewed by Dean Jackson.
3083
3084         * Scripts/webkitperl/FeatureList.pm: Added ENABLE_DARK_MODE_CSS as dark-mode-css.
3085         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
3086
3087 2018-10-15  Patrick Griffis  <pgriffis@igalia.com>
3088
3089         [JHBuild] Add xdg-dbus-proxy module
3090         https://bugs.webkit.org/show_bug.cgi?id=190589
3091
3092         Reviewed by Michael Catanzaro.
3093
3094         * gtk/jhbuild.modules:
3095
3096 2018-10-15  Patrick Griffis  <pgriffis@igalia.com>
3097
3098         [GTK] Add new sandboxing dependencies to install-dependencies
3099         https://bugs.webkit.org/show_bug.cgi?id=190588
3100
3101         Reviewed by Michael Catanzaro.
3102
3103         * gtk/install-dependencies:
3104
3105 2018-10-15  Chris Dumez  <cdumez@apple.com>
3106
3107         Experiment: target=_blank on anchors should imply rel=noopener
3108         https://bugs.webkit.org/show_bug.cgi?id=190481
3109
3110         Reviewed by Alex Christensen.
3111
3112         Add API test coverage to make sure we can now swap process when target=_blank
3113         is specified on an anchor but rel=noopener is not.
3114
3115         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3116
3117 2018-10-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3118
3119         [iOS] Can't select text after dismissing the keyboard when changing focus
3120         https://bugs.webkit.org/show_bug.cgi?id=190563
3121         <rdar://problem/44613559>
3122
3123         Reviewed by Tim Horton.
3124
3125         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3126         (WTR::UIScriptController::isShowingKeyboard const):
3127
3128         Add a new UIScriptController method that returns whether the keyboard is shown. See `ui-helper.js` for more
3129         details.
3130
3131         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3132         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3133         (WTR::UIScriptController::isShowingKeyboard const):
3134         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3135         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3136         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3137
3138         Also rename the `isShowingKeyboard` Objective-C property to the more canonical `showingKeyboard`, with
3139         `isShowingKeyboard` as the getter method.
3140
3141         (-[TestRunnerWKWebView _invokeShowKeyboardCallbackIfNecessary]):
3142         (-[TestRunnerWKWebView _invokeHideKeyboardCallbackIfNecessary]):
3143         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3144         (WTR::UIScriptController::isShowingKeyboard const):
3145
3146 2018-10-15  Ryan Haddad  <ryanhaddad@apple.com>
3147
3148         Unreviewed, fix JSC tests after WebGPUShadingLanguageRI directory was removed in r237115.
3149
3150         * Scripts/run-javascriptcore-tests:
3151         (runJSCStressTests): Remove wsl-tests.yaml.
3152
3153 2018-10-15  Christopher Reid  <chris.reid@sony.com>
3154
3155         [Curl][WinCairo] Add Public Suffix support to WinCairo
3156         https://bugs.webkit.org/show_bug.cgi?id=183060
3157
3158         Reviewed by Alex Christensen.
3159
3160         Share mac's PublicSuffix tests with all ports.
3161
3162         * TestWebKitAPI/PlatformWin.cmake:
3163         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3164         * TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:
3165         * TestWebKitAPI/Tests/mac/PublicSuffix.mm: Removed.
3166
3167 2018-10-15  Myles C. Maxfield  <mmaxfield@apple.com>
3168
3169         [WHLSL] Migrated WebGPUShadingLanguageRI to the W3C
3170         https://bugs.webkit.org/show_bug.cgi?id=190555
3171
3172         Unreviewed.
3173
3174         Migrated to https://github.com/gpuweb/WHLSL/tree/master/Source
3175
3176         * WebGPUShadingLanguageRI/AddressSpace.js: Removed.
3177         * WebGPUShadingLanguageRI/All.js: Removed.
3178         * WebGPUShadingLanguageRI/AllocateAtEntryPoints.js: Removed.
3179         * WebGPUShadingLanguageRI/AnonymousVariable.js: Removed.
3180         * WebGPUShadingLanguageRI/ArrayRefType.js: Removed.
3181         * WebGPUShadingLanguageRI/ArrayType.js: Removed.
3182         * WebGPUShadingLanguageRI/Assignment.js: Removed.
3183         * WebGPUShadingLanguageRI/AutoWrapper.js: Removed.
3184         * WebGPUShadingLanguageRI/Block.js: Removed.
3185         * WebGPUShadingLanguageRI/BoolLiteral.js: Removed.
3186         * WebGPUShadingLanguageRI/Break.js: Removed.
3187         * WebGPUShadingLanguageRI/BuiltInSemantic.js: Removed.
3188         * WebGPUShadingLanguageRI/BuiltinMatrixGetter.js: Removed.
3189         * WebGPUShadingLanguageRI/BuiltinMatrixSetter.js: Removed.
3190         * WebGPUShadingLanguageRI/BuiltinVectorGetter.js: Removed.
3191         * WebGPUShadingLanguageRI/BuiltinVectorSetter.js: Removed.
3192         * WebGPUShadingLanguageRI/CallExpression.js: Removed.
3193         * WebGPUShadingLanguageRI/CallFunction.js: Removed.
3194         * WebGPUShadingLanguageRI/Casts.js: Removed.
3195         * WebGPUShadingLanguageRI/Check.js: Removed.
3196         * WebGPUShadingLanguageRI/CheckLiteralTypes.js: Removed.
3197         * WebGPUShadingLanguageRI/CheckLoops.js: Removed.
3198         * WebGPUShadingLanguageRI/CheckNativeFuncStages.js: Removed.
3199         * WebGPUShadingLanguageRI/CheckRecursion.js: Removed.
3200         * WebGPUShadingLanguageRI/CheckRecursiveTypes.js: Removed.
3201         * WebGPUShadingLanguageRI/CheckReturns.js: Removed.
3202         * WebGPUShadingLanguageRI/CheckTypesWithArguments.js: Removed.
3203         * WebGPUShadingLanguageRI/CheckUnreachableCode.js: Removed.
3204         * WebGPUShadingLanguageRI/CheckWrapped.js: Removed.
3205         * WebGPUShadingLanguageRI/Checker.js: Removed.
3206         * WebGPUShadingLanguageRI/CloneProgram.js: Removed.
3207         * WebGPUShadingLanguageRI/CommaExpression.js: Removed.
3208         * WebGPUShadingLanguageRI/ConstexprFolder.js: Removed.
3209         * WebGPUShadingLanguageRI/Continue.js: Removed.
3210         * WebGPUShadingLanguageRI/ConvertPtrToArrayRefExpression.js: Removed.
3211         * WebGPUShadingLanguageRI/CreateLiteral.js: Removed.
3212         * WebGPUShadingLanguageRI/CreateLiteralType.js: Removed.
3213         * WebGPUShadingLanguageRI/DereferenceExpression.js: Removed.
3214         * WebGPUShadingLanguageRI/DoWhileLoop.js: Removed.
3215         * WebGPUShadingLanguageRI/DotExpression.js: Removed.
3216         * WebGPUShadingLanguageRI/EArrayRef.js: Removed.
3217         * WebGPUShadingLanguageRI/EBuffer.js: Removed.
3218         * WebGPUShadingLanguageRI/EBufferBuilder.js: Removed.
3219         * WebGPUShadingLanguageRI/EPtr.js: Removed.
3220         * WebGPUShadingLanguageRI/EnumLiteral.js: Removed.
3221         * WebGPUShadingLanguageRI/EnumMember.js: Removed.
3222         * WebGPUShadingLanguageRI/EnumType.js: Removed.
3223         * WebGPUShadingLanguageRI/EvaluationCommon.js: Removed.
3224         * WebGPUShadingLanguageRI/Evaluator.js: Removed.
3225         * WebGPUShadingLanguageRI/Expression.js: Removed.
3226         * WebGPUShadingLanguageRI/ExpressionFinder.js: Removed.
3227         * WebGPUShadingLanguageRI/ExternalOrigin.js: Removed.
3228         * WebGPUShadingLanguageRI/Field.js: Removed.
3229         * WebGPUShadingLanguageRI/FindHighZombies.js: Removed.
3230         * WebGPUShadingLanguageRI/FlattenedStructOffsetGatherer.js: Removed.
3231         * WebGPUShadingLanguageRI/FloatLiteral.js: Removed.
3232         * WebGPUShadingLanguageRI/FloatLiteralType.js: Removed.
3233         * WebGPUShadingLanguageRI/FoldConstexprs.js: Removed.
3234         * WebGPUShadingLanguageRI/ForLoop.js: Removed.
3235         * WebGPUShadingLanguageRI/Func.js: Removed.
3236         * WebGPUShadingLanguageRI/FuncAttribute.js: Removed.
3237         * WebGPUShadingLanguageRI/FuncDef.js: Removed.
3238         * WebGPUShadingLanguageRI/FuncNumThreadsAttribute.js: Removed.
3239         * WebGPUShadingLanguageRI/FuncParameter.js: Removed.
3240         * WebGPUShadingLanguageRI/FunctionLikeBlock.js: Removed.
3241         * WebGPUShadingLanguageRI/HighZombieFinder.js: Removed.
3242         * WebGPUShadingLanguageRI/IdentityExpression.js: Removed.
3243         * WebGPUShadingLanguageRI/IfStatement.js: Removed.
3244         * WebGPUShadingLanguageRI/IndexExpression.js: Removed.
3245         * WebGPUShadingLanguageRI/InferTypesForCall.js: Removed.
3246         * WebGPUShadingLanguageRI/Inline.js: Removed.
3247         * WebGPUShadingLanguageRI/Inliner.js: Removed.
3248         * WebGPUShadingLanguageRI/IntLiteral.js: Removed.
3249         * WebGPUShadingLanguageRI/IntLiteralType.js: Removed.
3250         * WebGPUShadingLanguageRI/Intrinsics.js: Removed.
3251         * WebGPUShadingLanguageRI/LayoutBuffers.js: Removed.
3252         * WebGPUShadingLanguageRI/Lexer.js: Removed.
3253         * WebGPUShadingLanguageRI/LexerToken.js: Removed.
3254         * WebGPUShadingLanguageRI/LiteralTypeChecker.js: Removed.
3255         * WebGPUShadingLanguageRI/LogicalExpression.js: Removed.
3256         * WebGPUShadingLanguageRI/LogicalNot.js: Removed.
3257         * WebGPUShadingLanguageRI/LoopChecker.js: Removed.
3258         * WebGPUShadingLanguageRI/MakeArrayRefExpression.js: Removed.
3259         * WebGPUShadingLanguageRI/MakePtrExpression.js: Removed.
3260         * WebGPUShadingLanguageRI/MatrixType.js: Removed.
3261         * WebGPUShadingLanguageRI/Metal/MSLBackend.js: Removed.
3262         * WebGPUShadingLanguageRI/Metal/MSLCodegenAll.js: Removed.
3263         * WebGPUShadingLanguageRI/Metal/MSLCompileResult.js: Removed.
3264         * WebGPUShadingLanguageRI/Metal/MSLConstexprEmitter.js: Removed.
3265         * WebGPUShadingLanguageRI/Metal/MSLFunctionDeclaration.js: Removed.
3266         * WebGPUShadingLanguageRI/Metal/MSLFunctionDefinition.js: Removed.
3267         * WebGPUShadingLanguageRI/Metal/MSLFunctionForwardDeclaration.js: Removed.
3268         * WebGPUShadingLanguageRI/Metal/MSLInsertTrapParameter.js: Removed.
3269         * WebGPUShadingLanguageRI/Metal/MSLNameMangler.js: Removed.
3270         * WebGPUShadingLanguageRI/Metal/MSLNativeFunctionCall.js: Removed.
3271         * WebGPUShadingLanguageRI/Metal/MSLStatementEmitter.js: Removed.
3272         * WebGPUShadingLanguageRI/Metal/MSLTypeAttributes.js: Removed.
3273         * WebGPUShadingLanguageRI/Metal/MSLTypeAttributesMap.js: Removed.
3274         * WebGPUShadingLanguageRI/Metal/MSLTypeUnifier.js: Removed.
3275         * WebGPUShadingLanguageRI/Metal/TypeOf.js: Removed.
3276         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/.gitignore: Removed.
3277         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.h: Removed.
3278         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.m: Removed.
3279         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Assets.xcassets/AppIcon.appiconset/Contents.json: Removed.
3280         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Assets.xcassets/Contents.json: Removed.
3281         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Base.lproj/Main.storyboard: Removed.
3282         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.h: Removed.
3283         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.m: Removed.
3284         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.h: Removed.
3285         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m: Removed.
3286         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.h: Removed.
3287         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.m: Removed.
3288         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Default.whlsl: Removed.
3289         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Julia.whlsl: Removed.
3290         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Mandelbrot.whlsl: Removed.
3291         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Info.plist: Removed.
3292         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.h: Removed.
3293         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m: Removed.
3294         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.h: Removed.
3295         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.m: Removed.
3296         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.h: Removed.
3297         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.m: Removed.
3298         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.h: Removed.
3299         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.m: Removed.
3300         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.h: Removed.
3301         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m: Removed.
3302         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.h: Removed.
3303         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m: Removed.
3304         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.h: Removed.
3305         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m: Removed.
3306         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.h: Removed.
3307         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m: Removed.
3308         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/WHLSL.entitlements: Removed.
3309         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/_SharedMetal.txt: Removed.
3310         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/main.m: Removed.
3311         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj: Removed.
3312         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/Info.plist: Removed.
3313         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/WHLSL_ToyTests.m: Removed.
3314         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.html: Removed.
3315         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.js: Removed.
3316         * WebGPUShadingLanguageRI/NameContext.js: Removed.
3317         * WebGPUShadingLanguageRI/NameFinder.js: Removed.
3318         * WebGPUShadingLanguageRI/NameResolver.js: Removed.
3319         * WebGPUShadingLanguageRI/NativeFunc.js: Removed.
3320         * WebGPUShadingLanguageRI/NativeType.js: Removed.
3321         * WebGPUShadingLanguageRI/Node.js: Removed.
3322         * WebGPUShadingLanguageRI/NormalUsePropertyResolver.js: Removed.
3323         * WebGPUShadingLanguageRI/NullLiteral.js: Removed.
3324         * WebGPUShadingLanguageRI/NullType.js: Removed.
3325         * WebGPUShadingLanguageRI/OperatorAnderIndexer.js: Removed.
3326         * WebGPUShadingLanguageRI/OperatorArrayRefLength.js: Removed.
3327         * WebGPUShadingLanguageRI/OriginKind.js: Removed.
3328         * WebGPUShadingLanguageRI/OverloadResolutionFailure.js: Removed.
3329         * WebGPUShadingLanguageRI/Parse.js: Removed.
3330         * WebGPUShadingLanguageRI/Prepare.js: Removed.
3331         * WebGPUShadingLanguageRI/Program.js: Removed.
3332         * WebGPUShadingLanguageRI/ProgramWithUnnecessaryThingsRemoved.js: Removed.
3333         * WebGPUShadingLanguageRI/PropertyAccessExpression.js: Removed.
3334         * WebGPUShadingLanguageRI/PropertyResolver.js: Removed.
3335         * WebGPUShadingLanguageRI/PtrType.js: Removed.
3336         * WebGPUShadingLanguageRI/ReadModifyWriteExpression.js: Removed.
3337         * WebGPUShadingLanguageRI/RecursionChecker.js: Removed.
3338         * WebGPUShadingLanguageRI/RecursiveTypeChecker.js: Removed.
3339         * WebGPUShadingLanguageRI/ReferenceType.js: Removed.
3340         * WebGPUShadingLanguageRI/ResolveNames.js: Removed.
3341         * WebGPUShadingLanguageRI/ResolveOverloadImpl.js: Removed.
3342         * WebGPUShadingLanguageRI/ResolveProperties.js: Removed.
3343         * WebGPUShadingLanguageRI/ResolveTypeDefs.js: Removed.
3344         * WebGPUShadingLanguageRI/ResourceSemantic.js: Removed.
3345         * WebGPUShadingLanguageRI/Return.js: Removed.
3346         * WebGPUShadingLanguageRI/ReturnChecker.js: Removed.
3347         * WebGPUShadingLanguageRI/ReturnException.js: Removed.
3348         * WebGPUShadingLanguageRI/Rewriter.js: Removed.
3349         * WebGPUShadingLanguageRI/SPIR-V.js: Removed.
3350         * WebGPUShadingLanguageRI/SPIRV.html: Removed.
3351         * WebGPUShadingLanguageRI/SPIRVCodegen.js: Removed.
3352         * WebGPUShadingLanguageRI/SPIRVTypeAnalyzer.js: Removed.
3353         * WebGPUShadingLanguageRI/SPIRVVariableAnalyzer.js: Removed.
3354         * WebGPUShadingLanguageRI/Sampler.js: Removed.
3355         * WebGPUShadingLanguageRI/Semantic.js: Removed.
3356         * WebGPUShadingLanguageRI/SpecializationConstantSemantic.js: Removed.
3357         * WebGPUShadingLanguageRI/StageInOutSemantic.js: Removed.
3358         * WebGPUShadingLanguageRI/StandardLibrary.js: Removed.
3359         * WebGPUShadingLanguageRI/StatementCloner.js: Removed.
3360         * WebGPUShadingLanguageRI/StructLayoutBuilder.js: Removed.
3361         * WebGPUShadingLanguageRI/StructType.js: Removed.
3362         * WebGPUShadingLanguageRI/SwitchCase.js: Removed.
3363         * WebGPUShadingLanguageRI/SwitchStatement.js: Removed.
3364         * WebGPUShadingLanguageRI/SynthesizeArrayOperatorLength.js: Removed.
3365         * WebGPUShadingLanguageRI/SynthesizeCopyConstructorOperator.js: Removed.
3366         * WebGPUShadingLanguageRI/SynthesizeDefaultConstructorOperator.js: Removed.
3367         * WebGPUShadingLanguageRI/SynthesizeEnumFunctions.js: Removed.
3368         * WebGPUShadingLanguageRI/SynthesizeStructAccessors.js: Removed.
3369         * WebGPUShadingLanguageRI/TernaryExpression.js: Removed.
3370         * WebGPUShadingLanguageRI/Test.html: Removed.
3371         * WebGPUShadingLanguageRI/Test.js: Removed.
3372         * WebGPUShadingLanguageRI/Texture.js: Removed.
3373         * WebGPUShadingLanguageRI/TextureOperations.js: Removed.
3374         * WebGPUShadingLanguageRI/TrapStatement.js: Removed.
3375         * WebGPUShadingLanguageRI/Type.js: Removed.
3376         * WebGPUShadingLanguageRI/TypeDef.js: Removed.
3377         * WebGPUShadingLanguageRI/TypeDefResolver.js: Removed.
3378         * WebGPUShadingLanguageRI/TypeOverloadResolutionFailure.js: Removed.
3379         * WebGPUShadingLanguageRI/TypeRef.js: Removed.
3380         * WebGPUShadingLanguageRI/TypedValue.js: Removed.
3381         * WebGPUShadingLanguageRI/UintLiteral.js: Removed.
3382         * WebGPUShadingLanguageRI/UintLiteralType.js: Removed.
3383         * WebGPUShadingLanguageRI/UnificationContext.js: Removed.
3384         * WebGPUShadingLanguageRI/UnreachableCodeChecker.js: Removed.
3385         * WebGPUShadingLanguageRI/Value.js: Removed.
3386         * WebGPUShadingLanguageRI/VariableDecl.js: Removed.
3387         * WebGPUShadingLanguageRI/VariableRef.js: Removed.
3388         * WebGPUShadingLanguageRI/VectorType.js: Removed.
3389         * WebGPUShadingLanguageRI/VisitingSet.js: Removed.
3390         * WebGPUShadingLanguageRI/Visitor.js: Removed.
3391         * WebGPUShadingLanguageRI/WLexicalError.js: Removed.
3392         * WebGPUShadingLanguageRI/WSyntaxError.js: Removed.
3393         * WebGPUShadingLanguageRI/WTrapError.js: Removed.
3394         * WebGPUShadingLanguageRI/WTypeError.js: Removed.
3395         * WebGPUShadingLanguageRI/WhileLoop.js: Removed.
3396         * WebGPUShadingLanguageRI/WrapChecker.js: Removed.
3397         * WebGPUShadingLanguageRI/index.html: Removed.
3398         * WebGPUShadingLanguageRI/spirv.core.grammar.json: Removed.
3399         * WebGPUShadingLanguageRI/wsl-tests.yaml: Removed.
3400
3401 2018-10-15  Philippe Normand  <pnormand@igalia.com>
3402
3403         [GTK] Disable MSE build support on Debian and Ubuntu LTS bots
3404         https://bugs.webkit.org/show_bug.cgi?id=190581
3405
3406         Reviewed by Michael Catanzaro.
3407
3408         These bots don't use JHBuild and their host GStreamer version is
3409         too old for the GStreamer MSE backend. Version 1.14 is needed at least.
3410
3411         * BuildSlaveSupport/build.webkit.org-config/config.json:
3412
3413 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3414
3415         Use pragma once in WTF
3416         https://bugs.webkit.org/show_bug.cgi?id=190527
3417
3418         Reviewed by Chris Dumez.
3419
3420         Put WorkQueue in namespace DRT so it does not conflict with WTF::WorkQueue.
3421
3422         * DumpRenderTree/TestRunner.cpp:
3423         (TestRunner::queueLoadHTMLString):
3424         (TestRunner::queueLoadAlternateHTMLString):
3425         (TestRunner::queueBackNavigation):
3426         (TestRunner::queueForwardNavigation):
3427         (TestRunner::queueLoadingScript):
3428         (TestRunner::queueNonLoadingScript):
3429         (TestRunner::queueReload):
3430         * DumpRenderTree/WorkQueue.cpp:
3431         (WorkQueue::singleton): Deleted.
3432         (WorkQueue::WorkQueue): Deleted.
3433         (WorkQueue::queue): Deleted.
3434         (WorkQueue::dequeue): Deleted.
3435         (WorkQueue::count): Deleted.
3436         (WorkQueue::clear): Deleted.
3437         (WorkQueue::processWork): Deleted.
3438         * DumpRenderTree/WorkQueue.h:
3439         (WorkQueue::setFrozen): Deleted.
3440         * DumpRenderTree/WorkQueueItem.h:
3441         * DumpRenderTree/mac/DumpRenderTree.mm:
3442         (runTest):
3443         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3444         (-[FrameLoadDelegate processWork:]):
3445         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
3446         * DumpRenderTree/mac/TestRunnerMac.mm:
3447         (TestRunner::notifyDone):
3448         (TestRunner::forceImmediateCompletion):
3449         (TestRunner::queueLoad):
3450         * DumpRenderTree/win/DumpRenderTree.cpp:
3451         (runTest):
3452         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3453         (FrameLoadDelegate::processWork):
3454         (FrameLoadDelegate::locationChangeDone):
3455         * DumpRenderTree/win/TestRunnerWin.cpp:
3456         (TestRunner::notifyDone):
3457         (TestRunner::forceImmediateCompletion):
3458         (TestRunner::queueLoad):
3459
3460 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
3461
3462         [JSC] Remove Option::useAsyncIterator
3463         https://bugs.webkit.org/show_bug.cgi?id=190567
3464
3465         Reviewed by Saam Barati.
3466
3467         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3468
3469 2018-10-15  Claudio Saavedra  <csaavedra@igalia.com>
3470
3471         [WPE] Silence a unused-parameter warning
3472
3473         Unreviewed.
3474         * MiniBrowser/wpe/main.cpp:
3475         (decidePermissionRequest):
3476
3477 2018-10-12  Guillaume Emont  <guijemont@igalia.com>
3478
3479         [Tools][webkitpy] fix handling of JSCTESTS_OPTIONS
3480         https://bugs.webkit.org/show_bug.cgi?id=190537
3481
3482         Reviewed by Alexey Proskuryakov.
3483
3484         In DeprecatedPort.run_javascriptcore_tests_command() JSCTESTS_OPTIONS
3485         needs to be split before adding it to the command since it is treated
3486         as a list of args.
3487
3488         * Scripts/webkitpy/common/config/ports.py:
3489         (DeprecatedPort.run_javascriptcore_tests_command):
3490
3491 2018-10-12  Wenson Hsieh  <wenson_hsieh@apple.com>
3492
3493         [iOS] Allow SPI clients to lay out at arbitrarily scaled sizes and scale to fit the view
3494         https://bugs.webkit.org/show_bug.cgi?id=190504
3495         <rdar://problem/45117760>
3496
3497         Reviewed by Tim Horton.
3498
3499         Teach UIScriptController to set WKWebView's view scale via a new `setViewScale` method, supported in WebKit2 on
3500         macOS and iOS.
3501
3502         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3503         (WTR::UIScriptController::setViewScale):
3504         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3505         (WTR::UIScriptController::setViewScale):
3506         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3507         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3508         (WTR::UIScriptController::setViewScale):
3509         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3510         * WebKitTestRunner/UIScriptControllerCocoa.mm: Added.
3511
3512         Add a new file for UIScriptController methods on Cocoa platforms.
3513
3514         (WTR::UIScriptController::setViewScale):
3515         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3516         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3517         (WTR::TestController::cocoaResetStateToConsistentValues):
3518
3519         Ensure that _viewScale is reset to 1 after running a layout test.
3520
3521 2018-10-12  Aakash Jain  <aakash_jain@apple.com>
3522
3523         [ews-build] Rename iOS-11-Simulator-Tests-EWS to iOS-11-Simulator-WK2-Tests-EWS
3524         https://bugs.webkit.org/show_bug.cgi?id=190536
3525
3526         Reviewed by Alexey Proskuryakov.
3527
3528         * BuildSlaveSupport/ews-build/config.json: Renamed iOS-11-Simulator-Tests-EWS to iOS-11-Simulator-WK2-Tests-EWS.
3529
3530 2018-10-11  Youenn Fablet  <youenn@apple.com>
3531
3532         IOS 12 - Service worker cache not shared when added to homescreen
3533         https://bugs.webkit.org/show_bug.cgi?id=190269
3534         <rdar://problem/45009961>
3535
3536         Reviewed by Alex Christensen.
3537
3538         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3539         Add test to ensure that CacheStorage use the default website data store parameters.
3540
3541 2018-10-11  Tim Horton  <timothy_horton@apple.com>
3542
3543         Clicking on bookmarklet crashes at NavigationState::willRecordNavigationSnapshot
3544         https://bugs.webkit.org/show_bug.cgi?id=190476
3545         <rdar://problem/32757191>
3546
3547         Reviewed by Megan Gardner.
3548
3549         * TestWebKitAPI/Tests/WebKitCocoa/SnapshotStore.mm:
3550         (TEST):
3551         Add a test that we don't crash.
3552
3553 2018-10-11  Tim Horton  <timothy_horton@apple.com>
3554
3555         REGRESSION (r237037): Cannot use webkit-patch upload, always fails with unknown 'cc_radar'
3556
3557         * Scripts/webkitpy/tool/steps/options.py:
3558         (Options):
3559         Fix the name of the variable that the --cc-radar option writes into.
3560
3561 2018-10-10  Dean Jackson  <dino@apple.com>
3562
3563         Add --cc-radar option to webkit-patch bug creation
3564         https://bugs.webkit.org/show_bug.cgi?id=190451
3565         <rdar://problem/45176671>
3566
3567         Reviewed by Antoine Quint.
3568
3569         Add a new command line option to automatically
3570         CC radar to new or updated bugs.
3571
3572         * Scripts/webkitpy/tool/commands/commandtest.py:
3573         (CommandsTest.assert_execute_outputs):
3574         * Scripts/webkitpy/tool/commands/upload.py:
3575         (CreateBug.__init__):
3576         (CreateBug.execute):
3577         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3578         (test_prepare_with_cc):
3579         (test_prepare_with_radar):
3580         (test_prepare_with_cc_and_radar):
3581         * Scripts/webkitpy/tool/steps/createbug.py:
3582         (CreateBug.options):
3583         (CreateBug.run):
3584         * Scripts/webkitpy/tool/steps/options.py:
3585         (Options):
3586
3587 2018-10-11  Claudio Saavedra  <csaavedra@igalia.com>
3588
3589         [GStreamer] Do not build gstgtk plugins
3590         https://bugs.webkit.org/show_bug.cgi?id=190463
3591
3592         Reviewed by Xabier Rodriguez-Calvar.
3593
3594         These plugins pull a GTK+ dependency that, at least in WPE,
3595         is unnecessary. The GTK+ port doesn't need it either, as far
3596         as I can tell.
3597
3598         * gstreamer/jhbuild.modules: Disable gstgtk plugins
3599
3600 2018-10-11  Alejandro G. Castro  <alex@igalia.com>
3601
3602         [GTK][WPE] Add mediaDevices.enumerateDevices support
3603         https://bugs.webkit.org/show_bug.cgi?id=185761
3604
3605         Reviewed by Youenn Fablet.
3606
3607         Added new API test for the mediaDevices.enumerateDevices:
3608         usermedia-enumeratedevices-permission-check. And a new API test
3609         for the WebsiteDataStore: testWebsiteDataDeviceIdHashSalt.
3610
3611         * MiniBrowser/gtk/main.c:
3612         (gotWebsiteDataCallback): Added a new section to the about:data
3613         webpage to include the information about the hash salt.
3614         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3615         (testWebViewUserMediaEnumerateDevicesPermissionCheck): Added the
3616         new test checking the enumerateDevices API when permission is
3617         denied and when permission is allowed for the origin.
3618         (beforeAll): Defined the new test.
3619         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
3620         (serverCallback): Register a new URI for the enumerateDevices.
3621         (testWebsiteDataConfiguration): Remove the hash salts from the
3622         directories.
3623         (testWebsiteDataDeviceIdHashSalt): New test cheking the
3624         enumerateDevices API.
3625         (beforeAll): Added the new test testWebsiteDataDeviceIdHashSalt to
3626         the init structure.
3627         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
3628         (WebViewTest::initializeWebView): Make sure the media-stream is
3629         activated in the webView.
3630
3631 2018-10-10  Fujii Hironori  <Hironori.Fujii@sony.com>
3632
3633         Add WinCairo to the flakiness dashboard
3634         https://bugs.webkit.org/show_bug.cgi?id=188345
3635
3636         Reviewed by Lucas Forschler.
3637
3638         * TestResultServer/static-dashboards/builders.jsonp: Regenerated by generate_builders_json.py.
3639         * TestResultServer/static-dashboards/flakiness_dashboard.js: Added a new platform 'WINCAIRO'.
3640
3641 2018-10-10  Dean Jackson  <dino@apple.com>
3642
3643         [WHSL -> MSL] Annotate semantics correctly in generated MSL
3644         https://bugs.webkit.org/show_bug.cgi?id=190452
3645         <rdar://problem/45178272>
3646
3647         Reviewed by Myles Maxfield.
3648
3649         Correctly label the appropriate semantics as [[position]]
3650         and [[color(N)]].
3651
3652         * WebGPUShadingLanguageRI/Metal/MSLBackend.js: Identify position
3653         and color attributes. Also use the semantic's index rather than
3654         a counter.
3655         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.html: Use a <pre> for
3656         output, and only include the actual shader code.
3657
3658 2018-10-10  Ross Kirsling  <ross.kirsling@sony.com>
3659
3660         build-webkit --inspector-frontend shouldn't have a nonzero exit code
3661         https://bugs.webkit.org/show_bug.cgi?id=190430
3662
3663         Reviewed by Brian Burg.
3664
3665         * Scripts/webkitdirs.pm:
3666         (argumentsForConfiguration):
3667         --inspector-frontend should only be popped off of argv by determineIsInspectorFrontend;
3668         it shouldn't be re-inserted as a CLI option by argumentsForConfiguration.
3669
3670 2018-10-10  Tim Horton  <timothy_horton@apple.com>
3671
3672         Share more WKShareSheet code between macOS and iOS, and fix a few bugs
3673         https://bugs.webkit.org/show_bug.cgi?id=190420
3674
3675         Reviewed by Simon Fraser.
3676
3677         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3678         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
3679         (WTR::UIScriptController::invokeShareSheetWithResolution): Deleted.
3680         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3681         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
3682         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3683         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3684         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
3685         (WTR::UIScriptController::invokeShareSheetWithResolution): Deleted.
3686         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3687         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3688         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
3689         (WTR::UIScriptController::invokeShareSheetWithResolution): Deleted.
3690         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3691         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
3692         Change the testing mechanism for the share sheet such that we up-front
3693         set that it should immediately return with a particular state, instead
3694         of programmatically dismissing the sheet.
3695
3696         Otherwise, running the tests on macOS doesn't work, because we pop
3697         a context menu, which spins the runloop and prevents dismissal from
3698         going through.
3699
3700 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
3701
3702         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
3703         https://bugs.webkit.org/show_bug.cgi?id=190429
3704
3705         Reviewed by Saam Barati.
3706
3707         * TestWebKitAPI/Tests/WebCore/mac/GPUBuffer.mm:
3708         (TestWebKitAPI::TEST_F):
3709
3710 2018-10-10  Chris Dumez  <cdumez@apple.com>
3711
3712         Regression(PSON): Assertion hit under WebPageProxy::didNavigateWithNavigationData()
3713         https://bugs.webkit.org/show_bug.cgi?id=190418
3714         <rdar://problem/45059769>
3715
3716         Reviewed by Geoffrey Garen.
3717
3718         Add API test coverage.
3719
3720         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3721
3722 2018-10-10  Guillaume Emont  <guijemont@igalia.com>
3723
3724         [JSCOnly Add an armv7 JSCOnly EWS that runs tests
3725         https://bugs.webkit.org/show_bug.cgi?id=190191
3726
3727         Reviewed by Michael Catanzaro.
3728
3729         * QueueStatusServer/config/queues.py:
3730         * Scripts/webkitpy/common/config/ews.json:
3731         * Scripts/webkitpy/common/config/ports.py:
3732         (DeprecatedPort.run_javascriptcore_tests_command):
3733         Add the possibility to pass arguments to run-javascriptcore-tests with
3734         the JSCTESTS_OPTIONS environment variable
3735         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3736         (test_ews_name):
3737
3738
3739 2018-10-09  Guillaume Emont  <guijemont@igalia.com>
3740
3741         Allow run-javascriptcore-tests to distribute tests between devices
3742         https://bugs.webkit.org/show_bug.cgi?id=190190
3743
3744         Reviewed by Michael Catanzaro.
3745
3746         * Scripts/run-jsc-stress-tests:
3747         * Scripts/webkitruby/jsc-stress-test-writer-default.rb:
3748         * Scripts/webkitruby/jsc-stress-test-writer-ruby.rb:
3749
3750 2018-10-09  Dean Jackson  <dino@apple.com>
3751
3752         Update WHLSL to Metal tester with semantics
3753         https://bugs.webkit.org/show_bug.cgi?id=190416
3754         <rdar://problem/45145139>
3755
3756         Reviewed by Myles Maxfield.
3757
3758         A few small changes to the WHLSL to Metal tools:
3759         - Make it compile by adding some missing JS files :)
3760         - Add semantics to the default shader
3761         - Add FIXMEs to the other shaders
3762         - Create an in-browser test for the WHLSLToMetal codepath
3763         - Fix typos in the semantics checker
3764
3765         * WebGPUShadingLanguageRI/Checker.js:
3766         (Checker.prototype._checkSemantics.checkSemanticTypes):
3767         (Checker.prototype._checkSemantics.checkSemanticForShaderType):
3768         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:
3769         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Default.whlsl:
3770         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Julia.whlsl:
3771         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Mandelbrot.whlsl:
3772         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj:
3773         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.html: Added.
3774
3775 2018-10-09  Jer Noble  <jer.noble@apple.com>
3776
3777         Crash when closing WKWebView during enter fullscreen animation
3778         https://bugs.webkit.org/show_bug.cgi?id=190412
3779
3780         Reviewed by Brian Burg.
3781
3782         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3783         * TestWebKitAPI/Tests/WebKitCocoa/CloseWebViewDuringEnterFullscreen.mm: Added.
3784         (-[CloseWebViewDuringEnterFullscreenUIDelegate _webViewWillEnterFullscreen:]):
3785         (-[CloseWebViewDuringEnterFullscreenUIDelegate _webViewWillExitFullscreen:]):
3786         (TestWebKitAPI::TEST):
3787
3788 2018-10-09  Chris Dumez  <cdumez@apple.com>
3789
3790         Anchor target should be ignored on activation when the download attribute is set
3791         https://bugs.webkit.org/show_bug.cgi?id=190408
3792
3793         Reviewed by Geoffrey Garen.
3794
3795         Update WebKitTestRunner to block popups by default and add support for testRunner.setCanOpenWindows()
3796         for tests that need popups. This aligns WebKitTestRunner with DumpRenderTree and allows testing
3797         popup blocking.
3798
3799         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3800         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3801         (WTR::TestRunner::setCanOpenWindows):
3802         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3803         * WebKitTestRunner/TestController.cpp:
3804         (WTR::TestController::createOtherPage):
3805         * WebKitTestRunner/TestController.h:
3806         * WebKitTestRunner/TestInvocation.cpp:
3807         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3808         * WebKitTestRunner/TestInvocation.h:
3809
3810 2018-10-09  Jer Noble  <jer.noble@apple.com>
3811
3812         WebDriver: thrown ObjC exception under -[WKFullScreenWindowController windowDidFailToEnterFullScreen:] when session is terminated
3813         https://bugs.webkit.org/show_bug.cgi?id=190098
3814         <rdar://problem/42822671>
3815
3816         Reviewed by Brian Burg.
3817
3818         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3819         * TestWebKitAPI/Tests/WebKitCocoa/CloseWebViewAfterEnterFullscreen.mm: Added.
3820         (-[CloseWebViewAfterEnterFullscreenUIDelegate _webViewDidEnterFullscreen:]):
3821         (-[CloseWebViewAfterEnterFullscreenUIDelegate _webViewDidExitFullscreen:]):
3822         (TestWebKitAPI::TEST):
3823
3824 2018-10-09  Jiewen Tan  <jiewen_tan@apple.com>
3825
3826         [WebAuthN] Import CTAP HID message and packet structure from Chromium
3827         https://bugs.webkit.org/show_bug.cgi?id=189289
3828         <rdar://problem/44120310>
3829
3830         Reviewed by Brent Fulgham.
3831
3832         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3833         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp: Added.
3834         (TestWebKitAPI::TEST):
3835
3836 2018-10-09  Chris Dumez  <cdumez@apple.com>
3837
3838         PSON: Doing a cross-site navigation via the URL bar does not swap process on iOS
3839         https://bugs.webkit.org/show_bug.cgi?id=190378
3840         <rdar://problem/45059466>
3841
3842         Reviewed by Geoffrey Garen.
3843
3844         Add API test coverage.
3845
3846         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3847
3848 2018-10-09  Jer Noble  <jer.noble@apple.com>
3849
3850         ISOTrackEncryptionBox returns incorrect defaultKeyID
3851         https://bugs.webkit.org/show_bug.cgi?id=190368
3852
3853         Reviewed by Eric Carlson.
3854
3855         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3856         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp: Added.
3857         (TestWebKitAPI::TEST):
3858
3859 2018-10-09  Philippe Normand  <pnormand@igalia.com>
3860
3861         [JHBuild] Update to GStreamer 1.14.4
3862         https://bugs.webkit.org/show_bug.cgi?id=190395
3863
3864         Reviewed by Xabier Rodriguez-Calvar.
3865
3866         * gstreamer/jhbuild.modules: Remove patches merged in 1.14.4 and bump version of GStreamer modules.
3867         * gstreamer/patches/gst-plugins-good-0007-matroskademux-Allow-Matroska-headers-to-be-read-more.patch: Removed.
3868         * gstreamer/patches/gst-plugins-good-0008-matroskademux-Refactor-track-parsing-out-from-adding.patch: Removed.
3869         * gstreamer/patches/gst-plugins-good-0009-matroskademux-Parse-successive-Tracks-elements.patch: Removed.
3870         * gstreamer/patches/gst-plugins-good-0010-matroskademux-Emit-no-more-pads-after-parsing-Tracks.patch: Removed.
3871
3872 2018-10-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3873
3874         [macOS] API test DragAndDropTests.DropColor is failing on macOS 10.12
3875         https://bugs.webkit.org/show_bug.cgi?id=190386
3876
3877         Reviewed by Ryosuke Niwa.
3878
3879         Unlike macOS 10.13 and 10.14, -[NSColor redColor] is not equivalent to a fully red color in sRGB on macOS 10.12.
3880         Fix the test by dragging and dropping an NSColor that is equivalent to rgb(255, 0, 0) on all relevant versions
3881         of macOS.
3882
3883         * TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm:
3884         (TEST):
3885
3886 2018-10-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3887
3888         [Cocoa] [WK2] Add support for text alignment and text lists in font attributes
3889         https://bugs.webkit.org/show_bug.cgi?id=190342
3890         <rdar://problem/44767118>
3891
3892         Reviewed by Tim Horton.
3893
3894         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3895         * TestWebKitAPI/Tests/WebKitCocoa/FontAttributes.mm:
3896
3897         Add a new API test to check that the font attributes dictionary contains the correct NSParagraphStyles when
3898         moving the selection around text inside nested list elements.
3899
3900         (TestWebKitAPI::checkParagraphStyles):
3901
3902         Add a new helper to check an NSParagraphStyle against expected results.
3903
3904         (TestWebKitAPI::webViewForTestingFontAttributes):
3905
3906         Allow each test to pass in the name of the test page to load.
3907
3908         (TestWebKitAPI::TEST):
3909         * TestWebKitAPI/Tests/WebKitCocoa/nested-lists.html: Added.
3910
3911         Add a new test page that contains text enclosed in multiple levels of unordered and ordered lists.
3912
3913         * TestWebKitAPI/Tests/WebKitCocoa/rich-text-attributes.html:
3914
3915         Remove `text-align: left` from one of these elements, to test for NSTextAlignmentNatural.
3916
3917 2018-10-08  Justin Fan  <justin_fan@apple.com>
3918
3919         WebGPU: Rename old WebGPU prototype to WebMetal
3920         https://bugs.webkit.org/show_bug.cgi?id=190325
3921         <rdar://problem/44990443>
3922
3923         Reviewed by Dean Jackson.
3924
3925         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
3926
3927         * DumpRenderTree/mac/DumpRenderTree.mm:
3928         (enableExperimentalFeatures):
3929         (resetWebPreferencesToConsistentValues):
3930         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3931         * TestWebKitAPI/Tests/WebCore/mac/GPUBuffer.mm:
3932         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm:
3933         * TestWebKitAPI/Tests/WebCore/mac/GPUDevice.mm:
3934         * TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm:
3935         * TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm:
3936         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3937         (WTR::InjectedBundle::beginTesting):
3938         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3939         (WTR::TestRunner::setWebMetalEnabled):
3940         (WTR::TestRunner::setWebGPUEnabled): Deleted.
3941         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3942
3943 2018-10-08  Commit Queue  <commit-queue@webkit.org>
3944
3945         Unreviewed, rolling out r236941.
3946         https://bugs.webkit.org/show_bug.cgi?id=190374
3947
3948         Causing API test failures in new test (Requested by jernoble
3949         on #webkit).
3950
3951         Reverted changeset:
3952
3953         "ISOTrackEncryptionBox returns incorrect defaultKeyID"
3954         https://bugs.webkit.org/show_bug.cgi?id=190368
3955         https://trac.webkit.org/changeset/236941
3956
3957 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
3958
3959         Make <input type=color> a runtime enabled (on-by-default) feature
3960         https://bugs.webkit.org/show_bug.cgi?id=189162
3961
3962         Reviewed by Wenson Hsieh and Tim Horton.
3963
3964         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3965
3966 2018-10-08  Jer Noble  <jer.noble@apple.com>
3967
3968         ISOTrackEncryptionBox returns incorrect defaultKeyID
3969         https://bugs.webkit.org/show_bug.cgi?id=190368
3970
3971         Reviewed by Eric Carlson.
3972
3973         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3974         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp: Added.
3975         (TestWebKitAPI::TEST):
3976
3977 2018-10-08  Alex Christensen  <achristensen@webkit.org>
3978
3979         Remove WKBundleFileHandleRef
3980         https://bugs.webkit.org/show_bug.cgi?id=190360
3981
3982         Reviewed by Tim Horton.
3983
3984         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3985         * TestWebKitAPI/Tests/WebKit/WKBundleFileHandle.cpp: Removed.
3986         * TestWebKitAPI/Tests/WebKit/WKBundleFileHandle_Bundle.cpp: Removed.
3987
3988 2018-10-08  Dan Bernstein  <mitz@apple.com>
3989
3990         Tools part of [Xcode] Update some build settings as recommended by Xcode 10
3991         https://bugs.webkit.org/show_bug.cgi?id=190250
3992
3993         Reviewed by Anders Carlsson.
3994
3995         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
3996
3997         * DumpRenderTree/mac/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
3998           CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
3999           CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
4000
4001         * DumpRenderTree/mac/DumpRenderTreeMac.h: Addressed the strict prototype warning.
4002
4003         * DumpRenderTree/mac/EditingDelegate.mm: Suppressed the deprecated implementations warning
4004           around deprecated methods or categories on deprecated classes.
4005         * DumpRenderTree/mac/FrameLoadDelegate.mm: Ditto.
4006         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
4007         * DumpRenderTree/mac/TestRunnerMac.mm: Ditto.
4008         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
4009
4010         * MiniBrowser/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
4011           CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
4012           CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
4013
4014         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
4015
4016         * MiniBrowser/mac/AppDelegate.h: Addressed the strict prototypes warning.
4017         * MiniBrowser/mac/WK2BrowserWindowController.m: Removed an unused #import to avoid having to
4018           address the fact that many of the WebKit C SPI headers trigger the strict prototypes warning.
4019
4020         * MobileMiniBrowser/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
4021           CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_SUSPICIOUS_MOVE (by fixing a typo),
4022           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF.
4023
4024         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj: Let Xcode update
4025           LastUpgradeCheck and remove the .xcconfig files from the Copy Bundle Resources build phase.
4026
4027         * TestWebKitAPI/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
4028           CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
4029           CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
4030           Made the WebKit headers be treated as system headers to avoid dealing with the fact that
4031           many C SPI headers trigger the strict prototypes warning.
4032
4033         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
4034
4035         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4036         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
4037         (-[BlobDownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
4038         (-[UIDownloadAsFileTestDelegate _webView:contextMenu:forElement:]):
4039         (-[RedirectedDownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
4040         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4041         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
4042         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
4043         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
4044         (-[AudioSessionCategoryUIWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
4045         * TestWebKitAPI/Tests/WebKitLegacy/ios/SnapshotViaRenderInContext.mm:
4046         (-[RenderInContextWebViewDelegate webViewDidFinishLoad:]):
4047         (-[RenderInContextWebViewDelegate webView:didFailLoadWithError:]):
4048         * TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm:
4049         (-[SetTimeoutFunctionWebViewDelegate webViewDidFinishLoad:]):
4050         (-[SetTimeoutFunctionWebViewDelegate webView:didFailLoadWithError:]):
4051         (-[SetTimeoutFunctionWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
4052         * TestWebKitAPI/Tests/mac/LegacyDragAndDropTests.mm:
4053         (-[DragInfo namesOfPromisedFilesDroppedAtDestination:]):
4054         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
4055         (-[DragAndDropTestWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
4056         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m:
4057         (-[SyntheticBackingScaleFactorWindow IGNORE_WARNINGS_END]):
4058         (-[SyntheticBackingScaleFactorWindow userSpaceScaleFactor]): Deleted.
4059         * TestWebKitAPI/mac/TestDraggingInfo.mm:
4060         (-[TestDraggingInfo namesOfPromisedFilesDroppedAtDestination:]):
4061
4062         In all of the above, suppressed the deprecated implementations warning where needed.
4063
4064         * WebKitTestRunner/Configurations/Base.xcconfig: Enabled ENABLE_STRICT_OBJC_MSGSEND,
4065           CLANG_WARN_BOOL_CONVERSION, CLANG_WARN_COMMA, CLANG_WARN_CONSTANT_CONVERSION,
4066           CLANG_WARN_EMPTY_BODY, CLANG_WARN_ENUM_CONVERSION, CLANG_WARN_INT_CONVERSION,
4067           CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_UNREACHABLE_CODE, CLANG_WARN__DUPLICATE_METHOD_MATCH,
4068           GCC_WARN_UNDECLARED_SELECTOR, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
4069           CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
4070           and GCC_NO_COMMON_BLOCKS.
4071
4072         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
4073
4074         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
4075         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed
4076           the deprecated implementations warning.
4077
4078         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
4079         (WTR::UIScriptController::replaceTextAtRange): Addressed an int-conversion warning.
4080
4081 2018-10-07  Yacine Bandou  <yacine.bandou@softathome.com>
4082
4083         [GStreamer][EME][webm] Add the WebM encrypted content support in matroskademux
4084         https://bugs.webkit.org/show_bug.cgi?id=189238
4085
4086         Reviewed by Xabier Rodriguez-Calvar.
4087
4088         Modifications on GStreamer, tracked in GStreamer bugzilla:
4089         https://bugzilla.gnome.org/show_bug.cgi?id=797231
4090         https://bugzilla.gnome.org/show_bug.cgi?id=765275
4091
4092         * gstreamer/jhbuild.modules: Add new patches.
4093         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Added.
4094         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Added.
4095         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Added.
4096         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Added.
4097
4098 2018-10-06  Dan Bernstein  <mitz@apple.com>
4099
4100         [Xcode] Never build yasm with ASAN
4101         https://bugs.webkit.org/show_bug.cgi?id=190327
4102
4103         Reviewed by Youenn Fablet.
4104
4105         * asan/asan.xcconfig: Allow targets to opt out of building with ASAN by setting
4106           the WK_ASAN_DISALLOWED build setting to YES (or, actually, anything other than NO or unset).
4107
4108 2018-10-05  Chris Dumez  <cdumez@apple.com>
4109
4110         Regression(r236862): Crash under DOMWindowExtension::willDetachGlobalObjectFromFrame()
4111         https://bugs.webkit.org/show_bug.cgi?id=190320
4112         <rdar://problem/45044814>
4113
4114         Reviewed by Geoffrey Garen.
4115
4116         Add API test coverage.
4117
4118         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
4119         (TestWebKitAPI::TEST):
4120         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
4121         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyGlobalObjectForDOMWindowExtension):
4122
4123 2018-10-03  Jer Noble  <jer.noble@apple.com>
4124
4125         Add support for reporting "display composited video frames" through the VideoPlaybackQuality object.
4126         https://bugs.webkit.org/show_bug.cgi?id=190266
4127
4128         Reviewed by Eric Carlson.
4129
4130         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4131         * TestWebKitAPI/Tests/WebKitCocoa/VideoQualityDisplayCompositing.mm: Added.
4132         (TestWebKitAPI::TEST):
4133
4134 2018-10-05  Ryan Haddad  <ryanhaddad@apple.com>
4135
4136         Unreviewed, rolling out r236866.
4137
4138         Breaks internal builds.
4139
4140         Reverted changeset:
4141
4142         "Add support for reporting "display composited video frames"
4143         through the VideoPlaybackQuality object."
4144         https://bugs.webkit.org/show_bug.cgi?id=190266
4145         https://trac.webkit.org/changeset/236866
4146
4147 2018-10-05  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
4148
4149         [WPE][JSC] Use Unified Sources for Platform-specific sources
4150         https://bugs.webkit.org/show_bug.cgi?id=190300
4151
4152         Reviewed by Yusuke Suzuki.
4153
4154         Currently the GTK port already used Unified Sources with the same source files.
4155         As WPE has conditional code using gmodule, we need to add GLIB_GMODULE_LIBRARIES
4156         to the list of libraries to link with.
4157
4158         * TestWebKitAPI/PlatformWPE.cmake:
4159
4160 2018-10-05  Zach Li  <zachli@apple.com>
4161
4162         Expose whether WKWebProcessPlugInNodeHandle is a select element to clients
4163         https://bugs.webkit.org/show_bug.cgi?id=190302
4164         <rdar://problem/45031469>
4165
4166         Reviewed by Tim Horton.
4167
4168         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4169         * TestWebKitAPI/Tests/WebKitCocoa/InjectedBundleNodeHandleIsSelectElement.mm: Added.
4170         (-[InjectedBundleNodeHandleIsSelectElement verifySelectElementForHTMLElementTag:document:jsContext:expectedResult:failedElementTags:]):
4171         (-[InjectedBundleNodeHandleIsSelectElement webProcessPlugIn:didCreateBrowserContextController:]):
4172         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
4173         (-[InjectedBundleNodeHandleIsSelectElementDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
4174         (TEST):
4175
4176 2018-10-04  Wenson Hsieh  <wenson_hsieh@apple.com>
4177
4178         [iOS] [WK2] Expose some more editing SPI on WKWebView
4179         https://bugs.webkit.org/show_bug.cgi?id=190232
4180         <rdar://problem/44963368>
4181
4182         Reviewed by Tim Horton.
4183
4184         Adds new API tests to exercise the new SPIs.
4185
4186         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4187         * TestWebKitAPI/Tests/ios/WKWebViewEditActions.mm: Added.
4188         (-[TestWKWebView querySelectorExists:]):
4189         (TestWebKitAPI::webViewForEditActionTesting):
4190         (TestWebKitAPI::TEST):
4191         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
4192         (-[TestWKWebView collapseToStart]): Deleted.
4193         (-[TestWKWebView collapseToEnd]): Deleted.
4194         (-[TestWKWebView stylePropertyAtSelectionStart:]): Deleted.
4195         (-[TestWKWebView stylePropertyAtSelectionEnd:]): Deleted.
4196         * TestWebKitAPI/cocoa/TestWKWebView.h:
4197         * TestWebKitAPI/cocoa/TestWKWebView.mm:
4198         (-[TestWKWebView stylePropertyAtSelectionStart:]):
4199         (-[TestWKWebView stylePropertyAtSelectionEnd:]):
4200         (-[TestWKWebView collapseToStart]):
4201         (-[TestWKWebView collapseToEnd]):
4202
4203         Pull some common testing helpers out of NSFontManager and into TestWKWebView.
4204
4205 2018-10-04  Jer Noble  <jer.noble@apple.com>
4206
4207         Add support for reporting "display composited video frames" through the VideoPlaybackQuality object.
4208         https://bugs.webkit.org/show_bug.cgi?id=190266
4209
4210         Reviewed by Eric Carlson.
4211
4212         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4213         * TestWebKitAPI/Tests/WebKitCocoa/VideoQualityDisplayCompositing.mm: Added.
4214         (TestWebKitAPI::TEST):
4215
4216 2018-10-04  Wenson Hsieh  <wenson_hsieh@apple.com>
4217
4218         [Cocoa] Add SPI to expose typing attributes at the current selection on WKWebView
4219         https://bugs.webkit.org/show_bug.cgi?id=190119
4220         <rdar://problem/44767062>
4221
4222         Reviewed by Tim Horton.
4223
4224         Add a new API test that loads a document containing various rich text styles. This test moves the selection
4225         around the document and checks the last set of font attributes received via the new UI delegate hook.
4226
4227         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4228         * TestWebKitAPI/Tests/WebKitCocoa/FontAttributes.mm: Added.
4229         (-[FontAttributesListener _webView:didChangeFontAttributes:]):
4230         (-[FontAttributesListener lastFontAttributes]):
4231         (-[TestWKWebView selectElementWithIdentifier:]):
4232         (-[TestWKWebView fontAttributesAfterNextPresentationUpdate]):
4233         (ColorExpectation::ColorExpectation):
4234         (ShadowExpectation::ShadowExpectation):
4235         (checkColor):
4236         (checkShadow):
4237         (checkFont):
4238         (webViewForTestingFontAttributes):
4239         * TestWebKitAPI/Tests/WebKitCocoa/rich-text-attributes.html: Added.
4240
4241 2018-10-04  Alan Coon  <alancoon@apple.com>
4242
4243         Unreviewed, add self as contributor.
4244
4245         * Scripts/webkitpy/common/config/contributors.json:
4246
4247 2018-10-04  Wenson Hsieh  <wenson_hsieh@apple.com>
4248
4249         [macOS] Fix some font attribute conversion bugs in preparation for "Font > Styles…" support in WebKit2
4250         https://bugs.webkit.org/show_bug.cgi?id=190289
4251         <rdar://problem/45020806>
4252
4253         Reviewed by Ryosuke Niwa.
4254
4255         Add new API tests to exercise two corner cases when using NSFontOptions ("Font > Styles…") to change font
4256         attributes at the current selection.
4257
4258         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4259         * TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h:
4260         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
4261         (webViewForFontManagerTesting):
4262         (TestWebKitAPI::TEST):
4263         * TestWebKitAPI/mac/TestFontOptions.h: Copied from Source/WebCore/editing/cocoa/FontAttributesCocoa.mm.
4264         * TestWebKitAPI/mac/TestFontOptions.mm: Added.
4265