[chromium] Implement CCThread in terms of WebThread
[WebKit-https.git] / Tools / ChangeLog
1 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
2
3         Change garden-o-matic frontend builder array to be a configuration map.
4         https://bugs.webkit.org/show_bug.cgi?id=66816
5
6         Reviewed by Adam Barth.
7
8         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js: Made kBuilders a map, with value being a configuration object.
9         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Adjusted callsites to expect a map.
10         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Ditto.
11         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Ditto.
12         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Ditto.
13
14 2011-08-23  Cary Clark  <caryclark@google.com>
15
16         Turn WebCanvas into CGContext before drawing scrollbar (DRT using Skia on Mac)
17         https://bugs.webkit.org/show_bug.cgi?id=66803
18
19         This fixes the WebKit Canaries, in particular avoids a crash on tests
20         like css1/basic/comments.html.
21
22         Reviewed by James Robinson.
23
24         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
25         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
26         The NSGraphicsContext call graphicsContextWithGraphicsPort takes a void*
27         parameter, so it took a WebCanvas* (mapped to SkCanvas* in Skia-land)
28         and treated it as if it were a CGContextRef.
29
30 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
31
32         Fix mergeChangeLogs test on native windows
33         https://bugs.webkit.org/show_bug.cgi?id=66797
34
35         Reviewed by Adam Roben.
36
37         Windows has no /tmp/ directory and the "TMPDIR" environment variable isn't set in the default setup.
38         Add the "TEMP" environment variable as additional source for the temporary directory used in writeTempFile.
39
40         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
41         (writeTempFile):
42
43 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
44
45         garden-o-matic relative time is wrong and updates too frequently.
46         https://bugs.webkit.org/show_bug.cgi?id=66802
47
48         Reviewed by Adam Barth.
49
50         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Changed to account for rounding correctly.
51         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: Updated tests.
52         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Upped the interval to 1 minute.
53
54 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
55
56         Add missing quotes around filenames in mergeChangeLogs
57         https://bugs.webkit.org/show_bug.cgi?id=66794
58
59         Reviewed by Adam Roben.
60
61         * Scripts/VCSUtils.pm:
62         (mergeChangeLogs):
63
64 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
65
66         webkit-perl tests fail on win32 Perl due to lack of list form of pipe open implementation
67         https://bugs.webkit.org/show_bug.cgi?id=49080
68
69         Reviewed by Adam Roben.
70
71         Use the string form of pipe open instead (like we do at all other places).
72
73         * Scripts/VCSUtils.pm:
74         (mergeChangeLogs):
75
76 2011-08-23  Adam Barth  <abarth@webkit.org>
77
78         garden-o-matic summary should be able to examine failures
79         https://bugs.webkit.org/show_bug.cgi?id=66748
80
81         Reviewed by Dimitri Glazkov.
82
83         This patch refactors a bunch of code from summary.js to independent
84         controllers in controllers.js.  This patch also contains the first
85         iteration of binding the "examine" event to a the behavior showing the
86         details view for the tests.  There's more work to do here to make this
87         work properly (and elegantly), but this patch is a start.
88
89         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
90         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
91         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
92         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers/rebaseline.js:
93         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
94         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
95         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
96         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
97         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
98
99 2011-08-23  Adam Barth  <abarth@webkit.org>
100
101         webkitpy/common/config/build.py shouldn't mention non-existant Android directory
102         https://bugs.webkit.org/show_bug.cgi?id=66737
103
104         Reviewed by Steve Block.
105
106         This directory doesn't exist anymore now that the Android port shares
107         more code with Chromium.
108
109         * Scripts/webkitpy/common/config/build.py:
110
111 2011-08-22  Eric Seidel  <eric@webkit.org>
112
113         Hack start-queue.sh in an attempt to resurrect the cr-jail-1 cr-mac-ews bot.
114         I won't have ssh access to the bot again for a couple days, so
115         attempting to fix by changing this script.  If this doesn't
116         work we'll just live with the it hung for now.
117
118         Unreviewed.
119
120         * EWSTools/start-queue.sh:
121
122 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
123
124         webkit-patch rebaseline-expectations command should not rearrange the entire test_expectations.txt file.
125         https://bugs.webkit.org/show_bug.cgi?id=66727
126
127         Reviewed by Adam Barth.
128
129         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Made it possible to run TestExpectationSerializer without a TestConfigurationConverter,
130             in which case the serializer treats all expectations as unparsed.
131         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added unit tests.
132
133 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
134
135         Update unit test expectations after r93530.
136
137         * Scripts/webkitpy/layout_tests/port/factory_unittest.py: Updated.
138         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
139
140 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
141
142         [Chromium] Expand CPU/GPU/Skia/CG into a matrix in graphics_type.
143         https://bugs.webkit.org/show_bug.cgi?id=66705
144
145         Reviewed by Adam Barth.
146
147         * Scripts/webkitpy/layout_tests/port/chromium.py: Added plumbing for CG graphics types.
148         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Adjusted unit test.
149
150 2011-08-22  James Robinson  <jamesr@chromium.org>
151
152         [chromium] Update builder names for chromium gpu bots due to CG switchover
153         https://bugs.webkit.org/show_bug.cgi?id=66693
154
155         Reviewed by Dirk Pranke.
156
157         Update the port and builder names for the chromium mac gpu bots to
158         account for the CG transition.
159
160         * Scripts/webkitpy/layout_tests/port/builders.py:
161
162 2011-08-22  Dirk Pranke  <dpranke@chromium.org>
163
164         fix the GPU bot names on the layout test dashboard
165         https://bugs.webkit.org/show_bug.cgi?id=66697
166
167         Reviewed by Dimitri Glazkov.
168
169         * TestResultServer/static-dashboards/builders.js:
170
171 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
172
173         garden-o-matic's relative time display should be updated regularly.
174         https://bugs.webkit.org/show_bug.cgi?id=66682
175
176         Reviewed by Adam Barth.
177
178         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Moved Time to ui.Time, added code for regular updates.
179         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed to use ui.Time.
180         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Added tests.
181
182 2011-08-22  Xianzhu Wang  <wangxianzhu@chromium.org>
183
184         Pass --makeargs of build-webkit to chromium linux builder
185         https://bugs.webkit.org/show_bug.cgi?id=66361
186
187         Reviewed by Tony Chang.
188
189         * Scripts/build-webkit:
190         * Scripts/webkitdirs.pm:
191         (buildChromiumMakefile):
192         (buildChromium):
193
194 2011-08-22  Peter Beverloo  <peter@chromium.org>
195
196         Add myself to the contributor list.
197         https://bugs.webkit.org/show_bug.cgi?id=66674
198
199         Reviewed by Tony Gentilcore.
200
201         * Scripts/webkitpy/common/config/committers.py:
202
203 2011-08-22  Balazs Kelemen  <kbalazs@webkit.org>
204
205         [Qt] ImageDiff does not consider --tolerance
206         https://bugs.webkit.org/show_bug.cgi?id=66299
207
208         Reviewed by Csaba Osztrogonác.
209
210         * DumpRenderTree/qt/ImageDiff.cpp:
211         (main):
212
213 2011-08-22  Csaba Osztrogonác  <ossy@webkit.org>
214
215         Update contributor list.
216
217         Reviewed by Zoltan Herczeg.
218
219         * Scripts/webkitpy/common/config/committers.py:
220
221 2011-08-22  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
222
223         [ORWT] Fix --reset-results --add-platform-exceptions combo
224         https://bugs.webkit.org/show_bug.cgi?id=65464
225
226         Reviewed by Csaba Osztrogonác.
227
228         * Scripts/old-run-webkit-tests:
229
230 2011-08-20  Adam Barth  <abarth@webkit.org>
231
232         garden-o-matic summary.html should have UI for examining failures
233         https://bugs.webkit.org/show_bug.cgi?id=66625
234
235         Reviewed by Dimitri Glazkov.
236
237         This patch introduces the notion of UI actions and converts our
238         existing manual <button> manipulation with this new abstraction.  The
239         patch also adds an Examine button to failure notifications.  In a
240         future patch, I'll add a controller that wires this button up to
241         something useful.
242
243         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
244         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
245         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js: Added.
246         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js: Added.
247         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
248         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
249         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
250         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
251
252 2011-08-20  Adam Barth  <abarth@webkit.org>
253
254         garden-o-matic summary page should indiciate compile failures
255         https://bugs.webkit.org/show_bug.cgi?id=66624
256
257         Reviewed by Dimitri Glazkov.
258
259         This patch creates a notification-based UI for build failures.  The new
260         UI displays the same information that used to be displayed in the
261         infobar.  There's lots of room for improvement in surfacing more
262         information, but this is a start.
263
264         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
265         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
266         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
267
268 2011-08-19  James Robinson  <jamesr@chromium.org>
269
270         [chromium] Default to experimental-fully-parallel mode for chromium gpu port
271         https://bugs.webkit.org/show_bug.cgi?id=66606
272
273         Reviewed by Dirk Pranke.
274
275         The chromium GPU configuration does not (currently) contain any tests
276         incompatible with --experimental-fully-parallel, and this flag is a
277         significan speedup because of the directory canvas/philip/tests which
278         contains 802 tests in the same directory. Setting this option by
279         default on this configuration is a 2x speed in release, 44s to 22s,
280         and a 3x speedup in debug, 223s to 77s, on linux on a 16 core machine.
281
282         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
283         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
284         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
285
286 2011-08-19  Sheriff Bot  <webkit.review.bot@gmail.com>
287
288         Unreviewed, rolling out r93426.
289         http://trac.webkit.org/changeset/93426
290         https://bugs.webkit.org/show_bug.cgi?id=66607
291
292         Broke the Mac build by not building gtest.framework anymore
293         (Requested by andersca on #webkit).
294
295         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
296
297 2011-08-19  James Robinson  <jamesr@chromium.org>
298
299         [chromium] Chromium GPU layout tests should use the normal process number selection, not force 1 worker
300         https://bugs.webkit.org/show_bug.cgi?id=66603
301
302         Reviewed by Dirk Pranke.
303
304         The various ChromiumGpu ports should use the same child worker
305         selection logic as other ports so they can run with full
306         parallelization on multicore systems.
307
308         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
309         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
310
311 2011-08-19  Alok Priyadarshi  <alokp@chromium.org>
312
313         [chromium] Remove dependency of WebThemeControlDRTWin on skia::PlatformCanvas
314         https://bugs.webkit.org/show_bug.cgi?id=66570
315
316         Reviewed by Mihai Parparita.
317
318         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
319         (WebThemeControlDRTWin::draw):
320         (WebThemeControlDRTWin::drawTextField):
321         (WebThemeControlDRTWin::drawProgressBar):
322         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
323
324 2011-08-18  Dmitry Lomov  <dslomov@google.com>
325
326         TestWebKitAPI breaks on Windows due to fast malloc incompatibility.
327         https://bugs.webkit.org/show_bug.cgi?id=66521
328
329         This patch ensures that gtest uses new and delete operators that are defined in JavaScriptCore.
330
331         Reviewed by David Levin.
332
333         * TestWebKitAPI/Tests/WTF/StringOperators.cpp: Removed redefinition of JS_EXPORTDATA.
334
335 2011-08-19  Adam Roben  <aroben@apple.com>
336
337         Add project file changes I left out in r93417
338
339         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
340
341 2011-08-19  Adam Roben  <aroben@apple.com>
342
343         Add a helper class for swizzling ObjC instance methods to TestWebKitAPI
344
345         Fixes <http://webkit.org/b/66565> TestWebKitAPI needs a way to override instance methods of
346         NSScreen
347
348         Reviewed by Anders Carlsson.
349
350         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
351
352         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Added.
353         (-[SimpleObject setValue:]): Original implementation.
354
355         (TestWebKitAPI::setValue2):
356         (TestWebKitAPI::setValue3):
357         Swizzled implementations.
358
359         (TestWebKitAPI::TEST): Test that we can swizzle and re-swizzle and un-swizzle an ObjC
360         instance method.
361
362         * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Added.
363         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Added.
364         (TestWebKitAPI::InstanceMethodSwizzler::InstanceMethodSwizzler): Swizzle the method.
365         (TestWebKitAPI::InstanceMethodSwizzler::~InstanceMethodSwizzler): Unswizzle the method.
366
367 2011-08-19  Tom Zakrajsek  <tomz@codeaurora.org>
368
369         Fix _path_to_apache() error reporting
370         https://bugs.webkit.org/show_bug.cgi?id=66486
371
372         Reviewed by Ryosuke Niwa.
373
374         * Scripts/webkitpy/layout_tests/port/webkit.py:
375
376 2011-08-19  Adam Roben  <aroben@apple.com>
377
378         Windows build fix after r93404
379
380         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp: Added missing #include.
381
382 2011-08-19  Tony Gentilcore  <tonyg@chromium.org>
383
384         Add leandrogracia to the committers list
385         https://bugs.webkit.org/show_bug.cgi?id=66552
386
387         Also fix line endings in file.
388
389         No reviewed required.
390
391         * Scripts/webkitpy/common/config/committers.py:
392
393 2011-08-19  Amruth Raj  <amruthraj@motorola.com>
394
395         Fix compilation issue in WebKitTestRunner
396         https://bugs.webkit.org/show_bug.cgi?id=66554
397
398         Reviewed by Martin Robinson.
399
400         * WebKitTestRunner/PixelDumpSupport.cpp:
401
402 2011-08-19  Adam Roben  <aroben@apple.com>
403
404         Pull some of DynamicDeviceScaleFactor's code up into a shareable base class
405
406         This will make it easier to write other WebKit-agnostic tests
407
408         Fixes <http://webkit.org/b/66558> Would like to be able to reuse DynamicDeviceScaleFactor's
409         code in other WebKit-agnostic tests
410
411         Reviewed by Anders Carlsson.
412
413         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
414
415         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm: Fixed copyright. Moved a bunch of
416         code to WebKitAgnosticTest.h/mm. Changed to inherit from WebKitAgnosticTest.
417         (TestWebKitAPI::DynamicDeviceScaleFactor::url): Simple getter.
418         (TestWebKitAPI::DynamicDeviceScaleFactor::didLoadURL): Calls through to runTest.
419         (TestWebKitAPI::DynamicDeviceScaleFactor::runTest): Removed loading code which
420         WebKitAgnosticTest handles for us.
421         (TestWebKitAPI::TEST_F): Removed view-creation code which WebKitAgnosticTest handles for us.
422
423         * TestWebKitAPI/mac/WebKitAgnosticTest.h: Added. Code came from DynamicDeviceScaleFactor.
424         (TestWebKitAPI::WebKitAgnosticTest::loadAndWaitUntilDone): Code came from
425         DynamicDeviceScaleFactor::runTest.
426
427         * TestWebKitAPI/mac/WebKitAgnosticTest.mm: Copied from Tools/TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm.
428         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test): Code came from
429         DynamicDeviceScaleFactor.WebKit.
430         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test): Code came from
431         DynamicDeviceScaleFactor.WebKit2.
432
433 2011-08-19  Adam Roben  <aroben@apple.com>
434
435         Clean up #includes in TestWebKitAPI
436
437         Fixes <http://webkit.org/b/66556> TestWebKitAPI's prefix header isn't very helpful
438
439         Reviewed by Anders Carlsson.
440
441         * TestWebKitAPI/TestWebKitAPIPrefix.h: Added wtf/Platform.h. Added gtest/gtest.h for C++
442         files and WebKit/WebKit.h for ObjC files.
443
444         * TestWebKitAPI/InjectedBundleController.cpp:
445         * TestWebKitAPI/JavaScriptTest.h:
446         * TestWebKitAPI/PlatformUtilities.h:
447         * TestWebKitAPI/PlatformWebView.h:
448         * TestWebKitAPI/Test.h:
449         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
450         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
451         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp:
452         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
453         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
454         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
455         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
456         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
457         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
458         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
459         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
460         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
461         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
462         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
463         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
464         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
465         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
466         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
467         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
468         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
469         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
470         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
471         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
472         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
473         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
474         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
475         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
476         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
477         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
478         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
479         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
480         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
481         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
482         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
483         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
484         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
485         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
486         * TestWebKitAPI/TestsController.cpp:
487         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
488         Removed now-unnecessary #includes. Moved #includes of Test.h in with the rest of the
489         #includes since it is no longer a special header.
490
491 2011-08-18  Dirk Pranke  <dpranke@chromium.org>
492
493         new-run-webkit-tests hung while acquiring http lock on snow leopard bots
494         https://bugs.webkit.org/show_bug.cgi?id=64886
495
496         Temporarily disable the http locking to work around the issue.
497         I'm not actually sure if this is going to work or improve things
498         much.
499
500         Reviewed by Ryosuke Niwa.
501
502         * Scripts/webkitpy/layout_tests/port/mac.py:
503
504 2011-08-18  Tony Chang  <tony@chromium.org>
505
506         add embedded png checksums to WebKitTestRunner
507         https://bugs.webkit.org/show_bug.cgi?id=66494
508
509         Looks like WebKitTestRunner has never supported embedded checksums.  This copies
510         some code from DRT and adds it to the WebKitTestRunner.
511
512         Reviewed by Darin Adler.
513
514         * WebKitTestRunner/CyclicRedundancyCheck.cpp: Copied from Tools/DumpRenderTree
515         * WebKitTestRunner/CyclicRedundancyCheck.h: Copied from Tools/DumpRenderTree
516         * WebKitTestRunner/GNUmakefile.am: Add new files
517         * WebKitTestRunner/PixelDumpSupport.cpp: Copied from Tools/DumpRenderTree
518         * WebKitTestRunner/PixelDumpSupport.h: Copied from Tools/DumpRenderTree
519         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Add new files
520         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
521         (WTR::dumpBitmap): Refactor to use PixelDumpSupport.
522         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
523         * WebKitTestRunner/cg/TestInvocationCG.cpp:
524         (WTR::dumpBitmap): Refactor to use PixelDumpSupport.
525         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
526         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Add new files
527
528 2011-08-18  Shawn Singh  <shawnsingh@chromium.org>
529
530         https://bugs.webkit.org/show_bug.cgi?id=47240
531
532         Fixed a cygwin path problem in the chromium port of diff_image;
533         Also made the return values of the diff_image function more consistent.
534
535         Reviewed by Dirk Pranke.
536
537         * Scripts/webkitpy/layout_tests/port/chromium.py:
538
539 2011-08-17  Alejandro G. Castro  <alex@igalia.com>
540
541         [GTK] Fix compilation problems with deprecations in gtk+
542         https://bugs.webkit.org/show_bug.cgi?id=66073
543
544         Reviewed by Martin Robinson.
545
546         * DumpRenderTree/gtk/DumpRenderTree.cpp:
547         (main): G_CONST_RETURN was deprecated
548         * GtkLauncher/main.c:
549         (createWindow): Added gtk_box_new conditional compilation for
550         gtk+-3.
551         * MiniBrowser/gtk/BrowserWindow.c:
552         (browser_window_init): Replaced gtk_vbox_new with gtk_box_new, we
553         are just supporting gtk+-3 for WebKit2.
554
555 2011-08-18  Anders Carlsson  <andersca@apple.com>
556
557         Fix libc++ C++0x build
558         https://bugs.webkit.org/show_bug.cgi?id=66479
559
560         Reviewed by Adam Roben.
561
562         Add missing includes.
563
564         * DumpRenderTree/LayoutTestController.cpp:
565         * DumpRenderTree/mac/CheckedMalloc.cpp:
566
567 2011-08-18  Adam Roben  <aroben@apple.com>
568
569         Test that WebKit updates style when a WebView is moved between differently-scaled windows
570
571         Test for <http://webkit.org/b/66412> <rdar://problem/9971958> WebKit doesn't react when a
572         WebView is moved between windows with different backing scale factors
573
574         Reviewed by Anders Carlsson.
575
576         * TestWebKitAPI/JavaScriptTest.cpp:
577         (TestWebKitAPI::runJSTest): Moved a little bit of code from here...
578         (TestWebKitAPI::compareJSResult): ...to here. Also made the error message more similar to
579         gtest's built-in error messages.
580
581         * TestWebKitAPI/JavaScriptTest.h: Added overloads of runJSTest that take a WebView * and
582         WKView * for convenience on Mac. Added compareJSResult helper function for implementing
583         those overloads.
584
585         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
586
587         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm: Added.
588         (-[FrameLoadDelegate initWithDidFinishLoadBoolean:]): Simple initializer.
589         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Record that the load finished.
590         (TestWebKitAPI::didFinishLoadForFrame): Record that the load finished.
591         (TestWebKitAPI::setPageLoaderClient): Set up the client.
592         (TestWebKitAPI::DynamicDeviceScaleFactor::DynamicDeviceScaleFactor): Simple constructor.
593         (TestWebKitAPI::DynamicDeviceScaleFactor::createWindow): Creates a
594         SyntheticBackingScaleFactorWindow and returns it.
595         (TestWebKitAPI::DynamicDeviceScaleFactor::runTest): Loads devicePixelRatio.html and checks
596         that WebKit uses the correct scale factor when the WebView is not in a window, is put in a
597         window, is moved to a differently-scaled window, and is taken out of the window.
598         (TestWebKitAPI::DynamicDeviceScaleFactor::loadURL): Helper function with overloads for
599         WebKit1 and WebKit2.
600         (TestWebKitAPI::TEST_F): Runs the test, with overloads for WebKit1 and WebKit2.
601
602         * TestWebKitAPI/Tests/mac/devicePixelRatio.html: Added.
603
604         * TestWebKitAPI/mac/JavaScriptTestMac.mm: Added.
605         (TestWebKitAPI::runJSTest): Fairly simple overloads for WebView * and WKView *.
606
607         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.h: Added.
608         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m: Added.
609         (-[SyntheticBackingScaleFactorWindow initWithContentRect:styleMask:backing:defer:]): Simple
610         initializer.
611         (-[SyntheticBackingScaleFactorWindow setBackingScaleFactor:]): Simple setter.
612
613         (-[SyntheticBackingScaleFactorWindow backingScaleFactor]):
614         (-[SyntheticBackingScaleFactorWindow userSpaceScaleFactor]):
615         Overrides of NSWindow methods that WebKit uses to determine the device scale factor.
616
617 2011-08-18  Dmitry Lomov  <dslomov@google.com>
618
619         https://bugs.webkit.org/show_bug.cgi?id=66425
620         check-webkit-style should detect incorrectly formatted file change descriptions.
621         Description, if present, should be separated from colon with a space.
622
623         Reviewed by David Levin.
624
625         * Scripts/webkitpy/style/checkers/changelog.py: Fix.
626         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Unit tests.
627
628 2011-08-18  Adam Barth  <abarth@webkit.org>
629
630         webkit-patch pretty-diff should be shown in main help
631         https://bugs.webkit.org/show_bug.cgi?id=66404
632
633         Reviewed by Dimitri Glazkov.
634
635         As requested by dglazkov.
636
637         * Scripts/webkitpy/tool/commands/prettydiff.py:
638
639 2011-08-17  Dmitry Lomov  <dslomov@google.com>
640
641         https://bugs.webkit.org/show_bug.cgi?id=66400
642         Fix TestWebKitAPI build on Mac OS.
643
644         Reviewed by David Levin.
645
646         * TestWebKitAPI/Configurations/Base.xcconfig: Added ICU headers to the HEADER_SEARCH_PATH.
647
648 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
649
650         garden-o-matic spring cleaning: move scripts, styles, and images in the respective directories.
651         https://bugs.webkit.org/show_bug.cgi?id=66427
652
653         Reviewed by Adam Barth.
654
655         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js: Removed.
656         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Removed.
657         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot_unittests.js: Removed.
658         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Removed.
659         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js: Removed.
660         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js: Removed.
661         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js: Removed.
662         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js: Removed.
663         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js: Removed.
664         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js: Removed.
665         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js: Removed.
666         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js: Removed.
667         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js: Removed.
668         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js: Removed.
669         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js: Removed.
670         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js: Removed.
671         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ORWTResultsParser.js: Removed.
672         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js: Removed.
673         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css: Removed.
674         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js: Removed.
675         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js: Removed.
676         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Removed.
677         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Removed.
678         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js: Removed.
679         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Removed.
680         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js: Removed.
681         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Removed.
682         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Removed.
683         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Removed.
684         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js: Removed.
685         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js: Removed.
686         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Removed.
687         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js: Removed.
688         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js: Removed.
689         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js: Removed.
690         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers: Removed.
691         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js: Removed.
692         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers/rebaseline.js: Removed.
693         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png: Removed.
694         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png: Removed.
695         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
696         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images: Added.
697         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-green.png: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png.
698         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-red.png: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png.
699         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
700         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css: Removed.
701         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js: Removed.
702         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Removed.
703         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Removed.
704         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js: Removed.
705         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js: Removed.
706         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html:
707         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js: Removed.
708         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js: Removed.
709         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
710         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js.
711         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js.
712         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot_unittests.js.
713         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Builder.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js.
714         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Builder_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js.
715         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FailingTestsBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js.
716         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FailingTestsBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js.
717         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyLayoutTestDetector.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js.
718         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyLayoutTestDetector_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js.
719         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyTestBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js.
720         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyTestBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js.
721         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestHistoryAnalyzer.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js.
722         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestResultsLoader.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js.
723         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NRWTResultsParser.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js.
724         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js.
725         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js.
726         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ORWTResultsParser.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ORWTResultsParser.js.
727         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/PersistentCache.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js.
728         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/TestRelatedBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js.
729         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/TestRelatedBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js.
730         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js.
731         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js.
732         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js.
733         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js.
734         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBugzilla.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js.
735         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBuildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js.
736         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js.
737         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js.
738         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/bugzilla_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js.
739         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js.
740         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js.
741         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js.
742         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js.
743         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js.
744         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.
745         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js.
746         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js.
747         ():
748         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js.
749         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js.
750         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js.
751         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js.
752         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js.
753         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js.
754         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/trac_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js.
755         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js.
756         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js.
757         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js.
758         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js.
759         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/unexpected-passes.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js.
760         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/TestFailures.css: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css.
761         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/main.css: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css.
762         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
763         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Removed.
764         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js: Removed.
765         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js: Removed.
766         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js: Removed.
767         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js: Removed.
768         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html:
769         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js: Removed.
770
771 2011-08-17  Jochen Eisinger  <jochen@chromium.org>
772
773         Make SVNTest.test_svn_apply use the same timezone logic as VCSUtils.pm
774         https://bugs.webkit.org/show_bug.cgi?id=65877
775
776         Reviewed by Eric Seidel.
777
778         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
779
780 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
781
782         Remove base.keys and replace it with Object.keys.
783         https://bugs.webkit.org/show_bug.cgi?id=66422
784
785         Reviewed by Adam Barth.
786
787         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Removed base.keys.
788         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Removed unit tests for it.
789         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Replaced with Object.keys
790
791 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
792
793         garden-o-matic Summary view should have items in descending chronological order.
794         https://bugs.webkit.org/show_bug.cgi?id=66403
795
796         Reviewed by Adam Barth.
797
798         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Renamed "push" to "add" for clarity, cleaned up some stuff.
799         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Rewrote add to insert DOM elements in order.
800         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added unit tests.
801
802 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
803
804         Fix a few errors in garden-o-matic frontend unit tests.
805         https://bugs.webkit.org/show_bug.cgi?id=66421
806
807         Reviewed by Adam Barth.
808
809         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Changed my excellent test to view time as variable continuum.
810         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Tweaked the test to accommodate new builder names.
811         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Hurriedly covered up my prior sins.
812
813 2011-08-17  Adam Barth  <abarth@webkit.org>
814
815         Update Tools to account for (CG) being added to Chromium builder names
816         https://bugs.webkit.org/show_bug.cgi?id=66410
817
818         Reviewed by Adam Barth.
819
820         Some of these names will change back once we turn on Skia bots.
821
822         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js:
823         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
824         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
825         * Scripts/webkitpy/layout_tests/port/builders.py:
826         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
827         * TestResultServer/static-dashboards/builders.js:
828         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
829
830 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
831
832         Wire up relative time to garden-o-matic summary view.
833         https://bugs.webkit.org/show_bug.cgi?id=66343
834
835         Reviewed by Adam Barth.
836
837         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Add time to the commitData object. 
838         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Adjusted unit tests.
839         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Wired up relative date.
840         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated unit tests.
841         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Adjusted unit tests.
842
843 2011-08-17  Adam Roben  <aroben@apple.com>
844
845         Make run-api-tests run tests in alphabetical order
846
847         Fixes <http://webkit.org/b/66401> run-api-tests runs tests in a semi-random order
848
849         Reviewed by David Kilzer.
850
851         * Scripts/run-api-tests:
852         (runAllTests):
853         (runAllTestsInSuite):
854         Sort the lists of tests and suites before iterating over them.
855
856 2011-08-17  Adam Barth  <abarth@webkit.org>
857
858         garden-o-matic should be able to rebaseline expected failures
859         https://bugs.webkit.org/show_bug.cgi?id=66204
860
861         Reviewed by Dimitri Glazkov.
862
863         This patch introduces a new view for displaying expect, actual, and
864         differences between results.  The new view also has a fledgling
865         controller that handles some basic operations.  The new view is
866         exercised by rebaseline.html, which lets you rebaselines expected
867         failures, but the new view is not fully integrated into
868         garden-o-matic.html
869
870         More patches will be required to make this stuff fully working, but
871         this patch was already somewhat spiraling out of control.  Hopefully
872         this patch will serve as a good starting point for further development.
873
874         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers: Added.
875         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js: Added.
876         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers/rebaseline.js: Added.
877         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
878         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
879         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
880         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html: Added.
881         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
882         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
883         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
884         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js:
885         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js: Added.
886
887 2011-08-16  Chang Shu  <cshu@webkit.org>
888
889         Support reset in WebCore::Internals
890         https://bugs.webkit.org/show_bug.cgi?id=66307
891
892         Reviewed by Dimitri Glazkov.
893
894         Added call to resetInternalsObject in DRT.
895
896         * DumpRenderTree/chromium/TestShell.cpp:
897         (TestShell::resetTestController):
898         * DumpRenderTree/mac/DumpRenderTree.mm:
899         (resetWebViewToConsistentStateBeforeTesting):
900         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
901         (WebCore::WebPage::resetSettings):
902
903 2011-08-17  Alexis Menard  <alexis.menard@openbossa.org>
904
905         Add a new build slave for the Qt port on Mac OS SnowLeopard.
906         https://bugs.webkit.org/show_bug.cgi?id=66392
907
908         Modify the config file to include the new build slave.
909
910         Reviewed by Adam Roben.
911
912         * BuildSlaveSupport/build.webkit.org-config/config.json:
913
914 2011-08-17  Sam White  <samuel.white@rochester.edu>
915
916         AccessibilityObject levels are inconsistent
917         https://bugs.webkit.org/show_bug.cgi?id=66180
918         
919         Added the ability to get numeric attribute values using numberAttributeValue. This
920         function complements the existing stringAttributeValue and boolAttributeValue functions.
921         The addition of numberAttributeValue was necessary because the stringAttributeValue
922         function does a type check and will only return strings. This limitation made it
923         impossible to get values for attributes that returned an NSNumber.
924
925         Reviewed by Chris Fleizach.
926
927         * DumpRenderTree/AccessibilityUIElement.cpp:
928         (numberAttributeValueCallback):
929         (AccessibilityUIElement::getJSClass):
930         * DumpRenderTree/AccessibilityUIElement.h:
931         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
932         (AccessibilityUIElement::numberAttributeValue):
933         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
934         (AccessibilityUIElement::numberAttributeValue):
935         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
936         (AccessibilityUIElement::numberAttributeValue):
937
938 2011-08-17  Adam Roben  <aroben@apple.com>
939
940         Tell Trac logs always to display all specified revisions in a single page
941
942         Trac imposes a default limit of 100 revisions per log page. We need to tell it to allow more
943         revisions than that.
944
945         Fixes <http://webkit.org/b/66373> Links to Trac from TestFailures page don't always show all
946         relevant revisions
947
948         Reviewed by Daniel Bates.
949
950         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
951         (trac.logURL): Add a limit parameter to the log URL that allows all revisions to be seen in
952         a single page.
953
954         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
955         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js:
956         Updated tests for the above.
957
958 2011-08-17  Adam Roben  <aroben@apple.com>
959
960         Fix TestFailures's link to file a bug about TestFailures itself
961
962         Fixes <http://webkit.org/b/66387> REGRESSION (r92135): TestFailures page's link to file a
963         bug about itself is broken
964
965         Reviewed by Dan Bates.
966
967         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
968         (ViewController.prototype._domForAuxiliaryUIElements): Added a path separator to separate
969         the host from the path.
970
971 2011-08-17  Adam Roben  <aroben@apple.com>
972
973         Teach TestFailures to ignore unbelievably short test runs
974
975         Fixes <http://webkit.org/b/66385> TestFailures page thinks all tests passed in
976         http://build.webkit.org/builders/Windows%207%20Release%20(Tests)/builds/14956
977
978         Reviewed by Dan Bates.
979
980         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
981         (Builder.prototype.getNumberOfFailingTests): If it looks like all tests passed, but
982         run-webkit-tests took less than 10 seconds to run, assume that some weird error occurred
983         that caused it not to run any tests at all (as happened for a while due to
984         <http://webkit.org/b/64988>). Bumped the cache version to evict old, buggy cached data.
985
986         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
987         Test for the above.
988
989         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
990         (LayoutTestResultsLoader.prototype.start): Bumped the cache version to evict old, buggy cached data.
991
992 2011-08-16  Adam Barth  <abarth@webkit.org>
993
994         Add a CG qualifier similar to the GPU qualifier
995         https://bugs.webkit.org/show_bug.cgi?id=66359
996
997         Reviewed by Eric Seidel.
998
999         Once we have a Skia configuration on Chromium Mac, we'll use this CG
1000         qualifier to note that expectations apply only to the CG configuration.
1001
1002         * Scripts/webkitpy/layout_tests/port/chromium.py:
1003         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1004
1005 2011-08-16  Eric Seidel  <eric@webkit.org>
1006
1007         REGRESSION(92717): WinPort needs to parse version information from port_name
1008         https://bugs.webkit.org/show_bug.cgi?id=66325
1009
1010         Unreviewed.  Fixing an exception/typo seen on the bots (and testing to make sure it works).
1011
1012         * Scripts/webkitpy/layout_tests/port/mac.py:
1013         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1014
1015 2011-08-16  Adam Barth  <abarth@webkit.org>
1016
1017         Change webkit-patch analyze-baselines to print in a more unix-friendly way
1018         https://bugs.webkit.org/show_bug.cgi?id=66349
1019
1020         Reviewed by James Robinson.
1021
1022         As requested by jamesr.
1023
1024         * Scripts/webkitpy/tool/commands/rebaseline.py:
1025
1026 2011-08-16  Eric Seidel  <eric@webkit.org>
1027
1028         REGRESSION(92717): WinPort needs to parse version information from port_name
1029         https://bugs.webkit.org/show_bug.cgi?id=66325
1030
1031         Reviewed by Adam Barth.
1032
1033         WinPort didn't have any port_name parsing logic.
1034         Seemed it was best to just share the logic from MacPort.
1035         Sharing the logic from MacPort seemed easiest with a shared superclass.
1036         Once I created ApplePort (the superclass) there was a bunch of logic to share.
1037         I found LeakDetector was just in the way when switching back and forth
1038         between win.py and mac.py so I moved it into its own file.
1039
1040         The only logic change here is that WinPort should now be
1041         able to parse port_name values like MacPort (and other ports)
1042         can.  The fact that ports do this in their constructors is
1043         wrong and a source of many bugs.  But at least now WinPort
1044         matches the status-quo.
1045
1046         * Scripts/webkitpy/layout_tests/port/apple.py: Added.
1047         * Scripts/webkitpy/layout_tests/port/leakdetector.py: Added.
1048         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py: Added.
1049         * Scripts/webkitpy/layout_tests/port/mac.py:
1050         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1051         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1052         * Scripts/webkitpy/layout_tests/port/win.py:
1053         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1054
1055 2011-08-16  Adam Barth  <abarth@webkit.org>
1056
1057         Add webkit-patch analyze-baselines, as requested by jamesr.
1058
1059         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
1060         * Scripts/webkitpy/tool/commands/rebaseline.py:
1061
1062 2011-08-16  Adam Barth  <abarth@webkit.org>
1063
1064         Fold bulk-optimize-baselines into optimize-baselines
1065         https://bugs.webkit.org/show_bug.cgi?id=66345
1066
1067         Reviewed by James Robinson.
1068
1069         bulk-optimize-baselines is now a superset of optimize-baselines, so
1070         they can be combined.
1071
1072         * Scripts/webkitpy/tool/commands/rebaseline.py:
1073
1074 2011-08-16  Adam Barth  <abarth@webkit.org>
1075
1076         Move chromium-mac to chromium-cg-mac to prepare for Skia switchover
1077         https://bugs.webkit.org/show_bug.cgi?id=66334
1078
1079         Reviewed by Tony Chang.
1080
1081         This patch moves us closer to switching the Chromium port from
1082         CoreGraphics to Skia.  This patch teaches our tools that the current
1083         Chromium Mac configuration is actually chromium-cg-mac, which makes
1084         room for a future chromium-mac configuration that uses Skia.
1085
1086         Shortly after this patch lands, I'll do a server-side move of the
1087         chromium-mac and chromium-mac-leopard directories to chromium-cg-mac
1088         and chromium-cg-mac-leopard.
1089
1090         * BuildSlaveSupport/build.webkit.org-config/config.json:
1091         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
1092         * Scripts/webkitpy/common/config/build.py:
1093         * Scripts/webkitpy/common/config/build_unittest.py:
1094         * Scripts/webkitpy/layout_tests/port/base.py:
1095         * Scripts/webkitpy/layout_tests/port/builders.py:
1096         * Scripts/webkitpy/layout_tests/port/chromium.py:
1097         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1098         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1099         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1100         * Scripts/webkitpy/layout_tests/port/factory.py:
1101         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1102         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1103         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1104         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1105         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
1106         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1107         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1108
1109 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
1110
1111         garden-o-matic frontend needs a friendly relative time description method.
1112         https://bugs.webkit.org/show_bug.cgi?id=66324
1113
1114         Reviewed by Adam Barth.
1115
1116         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added base.relativizeTime method.
1117         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added unit tests.
1118         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Wired up Time widget to use it.
1119
1120 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
1121
1122         Summary view should not add multiple entries for the same test failure.
1123         https://bugs.webkit.org/show_bug.cgi?id=66318
1124
1125         Reviewed by Adam Barth.
1126
1127         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Added a simplistic updating button.
1128         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added ways to check for
1129             equality of ui.notifications.FailingTest, and whether ui.notifications.TestFailures already contains a given failure analysis.
1130         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added tests.
1131
1132 2011-08-16  Adam Roben  <aroben@apple.com>
1133
1134         Teach TestFailures that tests that have failed or passed many times in a row are not flaky
1135
1136         The basic strategy here is that once a test has failed or passed many times in a row we
1137         never again consider it as a possibly flaky test. It's a simple strategy but seems to result
1138         in many fewer false positives than our current behavior.
1139
1140         Fixes <http://webkit.org/b/66327> TestFailures page considers far too many tests to be
1141         flaky, including tests that failed for a while but then were fixed
1142
1143         Reviewed by Dan Bates.
1144
1145         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:
1146         (FlakyLayoutTestDetector): Initialize new _buildCount property, which is used to track the
1147         number of non-too-many-failure builds we've seen.
1148         (FlakyLayoutTestDetector.prototype.incorporateTestResults): Don't track tests which haven't
1149         failed in the _maximumFailOrPassCount most recent builds. For other not-yet-considered-flaky
1150         tests, keep track of how many times they have passed or failed in a row. If they pass or
1151         fail more than _maximumFailOrPassCount times, consider them to be non-flaky. (Once a test is
1152         considered flaky it doesn't matter how many times it passes or fails.)
1153
1154         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js:
1155         Added tests for the above.
1156
1157 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
1158
1159         garden-o-matic needs a summary view with actions for each problem.
1160         https://bugs.webkit.org/show_bug.cgi?id=66144
1161
1162         Reviewed by Adam Barth.
1163
1164         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: Added notifications tests.
1165         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Added.
1166         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added.
1167         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added.
1168         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css: Added.
1169         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Added.
1170
1171 2011-08-16  Dean Jackson  <dino@apple.com>
1172
1173         Adding Ted "hober" O'Connor as a non-committing contributor.
1174
1175         * Scripts/webkitpy/common/config/committers.py:
1176
1177 2011-08-16  Adam Roben  <aroben@apple.com>
1178
1179         Teach TestFailures how to interpret unfinished test runs
1180
1181         Fixes <http://webkit.org/b/66309> TestFailures thinks all tests passed in
1182         http://build.webkit.org/builders/Lion%20Intel%20Debug%20(Tests)/builds/136
1183
1184         Reviewed by David Kilzer.
1185
1186         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1187         (Builder.prototype.getNumberOfFailingTests): Look for "isFinished" in the layout-test step
1188         rather than "isStarted" so that we don't count builds for which the test run never finished.
1189         Bumped the cache version to evict old, buggy cached data.
1190
1191         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
1192         Added a test for the above, and made a somewhat synthetic test more realistic by including
1193         more of the actual JSON data from build.webkit.org.
1194
1195         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
1196         (LayoutTestResultsLoader.prototype.start): Bumped the cache version to evict old, buggy
1197         cached data.
1198
1199 2011-08-16  Adam Roben  <aroben@apple.com>
1200
1201         Make Apple's Windows port fall back to Lion results instead of SnowLeopard
1202
1203         Apple's Windows port now uses Lion-era versions of CoreFoundation, ICU, etc., so in theory
1204         should match Lion's behavior.
1205
1206         Fixes <http://webkit.org/b/66302> Apple's Windows port matches Lion for some test results,
1207         but doesn't use Lion results
1208
1209         Reviewed by David Kilzer.
1210
1211         * Scripts/old-run-webkit-tests:
1212         (expectedDirectoryForTest):
1213         * Scripts/webkitpy/layout_tests/port/win.py:
1214         (WinPort.baseline_search_path):
1215         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1216         (WinPortTest.test_baseline_search_path):
1217         Replaced mac-snowleopard with mac-lion.
1218
1219         * Scripts/webkitpy/common/config/build.py:
1220         (_should_file_trigger_build): Added an entry for the LayoutTests/platform/mac-lion
1221         directory, which all Apple Mac platforms and Apple Win platforms could potentially use
1222         results from. Removed Apple Win from being affected by mac-snowleopard changes, since it
1223         will no longer look there for results.
1224
1225         * Scripts/webkitpy/common/config/build_unittest.py:
1226         (ShouldBuildTest.test_should_build): Tests for the above changes.
1227
1228 2011-08-16  Dean Jackson  <dino@apple.com>
1229
1230         Move me from contributor to reviewer.
1231
1232         * Scripts/webkitpy/common/config/committers.py:
1233
1234 2011-08-15  Dimitri Glazkov  <dglazkov@chromium.org>
1235
1236         garden-o-matic frontend needs model.commitDataForRevisionRange function.
1237         https://bugs.webkit.org/show_bug.cgi?id=66252
1238
1239         Reviewed by Adam Barth.
1240
1241         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Added commitDataForRevisionRange method.
1242         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Added tests.
1243
1244 2011-08-15  Dimitri Glazkov  <dglazkov@chromium.org>
1245
1246         garden-o-matic frontend needs a generic way to track updates.
1247         https://bugs.webkit.org/show_bug.cgi?id=66245
1248
1249         Reviewed by Adam Barth.
1250
1251         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added UpdateTracker.
1252         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added tests.
1253
1254 2011-08-15  Adam Roben  <aroben@apple.com>
1255
1256         Teach TestWebKitAPI/gtest how to print JavaScript failures nicely
1257
1258         Failures now give output of the form: foo should be bar but is baz
1259
1260         Fixes <http://webkit.org/b/66240> It's hard to tell what the actual result of a failed JS
1261         test is in TestWebKitAPI's output
1262
1263         Reviewed by David Levin.
1264
1265         * TestWebKitAPI/JavaScriptTest.cpp:
1266         (TestWebKitAPI::JavaScriptCallbackContext::JavaScriptCallbackContext): Removed now-unused
1267         members.
1268         (TestWebKitAPI::javaScriptCallback): Changed to just store the result string in the context
1269         object, rather than doing any testing of it here.
1270         (TestWebKitAPI::runJSTest): Made this function a gtest predicate-formatter. This allows us
1271         to use a pretty error message when the test fails.
1272
1273         * TestWebKitAPI/JavaScriptTest.h: Changed runJSTest to a predicate-formatter, and added nice
1274         gtest-style macros that wrap it.
1275
1276         * TestWebKitAPI/Test.h: Removed now-unused TEST_ASSERT_RETURN.
1277
1278         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
1279         (TestWebKitAPI::TEST): Changed to use the new macros.
1280
1281         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
1282         (TestWebKitAPI::createSessionStateContainingFormData): Ditto. Note that this function no
1283         longer returns 0 when the JS test fails. That shouldn't have any effect on whether or not
1284         the test passes, though. Returning early seems to have been an unnecessary optimization.
1285
1286         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1287         (TestWebKitAPI::TEST): Changed to use the new macros.
1288
1289 2011-08-15  Eric Seidel  <eric@webkit.org>
1290
1291         Move the Leaks bot back to ORWT until I can fix LeaksViewer regressions filed by Adam Roben in bug 66227 and 66228.
1292
1293         Unreviewed.
1294
1295         * Scripts/run-webkit-tests:
1296         (usingLeaks):
1297         (useNewRunWebKitTests):
1298
1299 2011-08-14  Adam Barth  <abarth@webkit.org>
1300
1301         Switch results detail view over to new-style object-oriented UI widgets
1302         https://bugs.webkit.org/show_bug.cgi?id=66200
1303
1304         Reviewed by Dimitri Glazkov.
1305
1306         This patch replaces my goofy template-based UI for the results
1307         comparison screen with new object-oriented UI widgets.
1308
1309         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1310         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
1311         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
1312         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
1313         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
1314         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js: Added.
1315         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
1316
1317 2011-08-13  Dimitri Glazkov  <dglazkov@chromium.org>
1318
1319         garden-o-matic's analyzeUnexpectedFailures needs a completion callback.
1320         https://bugs.webkit.org/show_bug.cgi?id=66166
1321
1322         Also changed base.RequestTracker to:
1323         a) fire callback immediately if requestsInFlight is 0;
1324         b) not barf if callback is not supplied.
1325
1326         Reviewed by Adam Barth.
1327
1328         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js: Started using completion callback.
1329         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Added completion callback.
1330         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Changed RequestTracker.
1331         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittest.js: Added unit tests.
1332
1333 2011-08-12  Mark Rowe  <mrowe@apple.com>
1334
1335         Be more forward-looking in the choice of compiler.
1336
1337         Rubber-stamped by Jon Honeycutt.
1338
1339         * DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig:
1340         * MiniBrowser/Configurations/CompilerVersion.xcconfig:
1341         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
1342         * WebKitTestRunner/Configurations/CompilerVersion.xcconfig:
1343
1344 2011-08-12  Sadrul Habib Chowdhury  <sadrul@chromium.org>
1345
1346         DRT: Add support for gesture events.
1347         https://bugs.webkit.org/show_bug.cgi?id=66105
1348
1349         Reviewed by Darin Fisher.
1350
1351         * DumpRenderTree/chromium/EventSender.cpp:
1352         (EventSender::EventSender):
1353         (EventSender::gestureScrollBegin):
1354         (EventSender::gestureScrollEnd):
1355         (EventSender::gestureTap):
1356         (EventSender::gestureEvent):
1357         * DumpRenderTree/chromium/EventSender.h:
1358
1359 2011-08-12  Andy Estes  <aestes@apple.com>
1360
1361         allowRoundingHacksCallback uses the wrong argument for 'thisObject'.
1362         https://bugs.webkit.org/show_bug.cgi?id=66158
1363
1364         Reviewed by Dan Bernstein.
1365
1366         * DumpRenderTree/LayoutTestController.cpp:
1367         (allowRoundingHacksCallback): The third argument is the 'this'
1368         JSObjectRef, not the second.
1369
1370 2011-08-12  Andy Estes  <aestes@apple.com>
1371
1372         Cancel in onbeforeunload dialog sometime causes a button to stop working.
1373         https://bugs.webkit.org/show_bug.cgi?id=26211
1374
1375         Reviewed by Alexey Proskuryakov.
1376
1377         Implement a new LayoutTestController method that a test can call to set
1378         the return value of DumpRenderTree's beforeunload UI delegate.
1379
1380         * DumpRenderTree/LayoutTestController.cpp:
1381         (LayoutTestController::LayoutTestController): Initialize
1382         m_shouldStayOnPageAfterHandlingBeforeUnload.
1383         (setShouldStayOnPageAfterHandlingBeforeUnloadCallback): Call
1384         LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload().
1385         (LayoutTestController::staticFunctions): Register
1386         'setShouldStayOnPageAfterHandlingBeforeUnload' as a static function.
1387         * DumpRenderTree/LayoutTestController.h: 
1388         (LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload):
1389         (LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
1390         * DumpRenderTree/chromium/LayoutTestController.cpp:
1391         (LayoutTestController::LayoutTestController): Initialize
1392         m_shouldStayOnPageAfterHandlingBeforeUnload and bind
1393         'setShouldStayOnPageAfterHandlingBeforeUnload' to its c++ setter.
1394         (LayoutTestController::reset): Reset
1395         m_shouldStayOnPageAfterHandlingBeforeUnload to false.
1396         (LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
1397         Set m_shouldStayOnPageAfterHandlingBeforeUnload to the value passed in
1398         from JavaScript.
1399         * DumpRenderTree/chromium/LayoutTestController.h:
1400         (LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload):
1401         * DumpRenderTree/chromium/WebViewHost.cpp:
1402         (WebViewHost::runModalBeforeUnloadDialog): Add the correct logging and
1403         return the inverse of
1404         LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload().
1405         * DumpRenderTree/mac/UIDelegate.mm:
1406         (-[UIDelegate webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:]): Ditto.
1407         * DumpRenderTree/win/UIDelegate.cpp:
1408         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
1409         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1410         Define setShouldStayOnPageAfterHandlingBeforeUnload().
1411         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1412         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue): Post a message
1413         to the Test Controller telling it what value it should return in its
1414         onbeforeunload UI delegate.
1415         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1416         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1417         (WTR::LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
1418         Call InjectedBundle::postNewBeforeUnloadReturnValue().
1419         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1420         * WebKitTestRunner/TestController.cpp:
1421         (WTR::TestController::TestController): Initialize
1422         m_beforeUnloadReturnValue to true.
1423         (WTR::runBeforeUnloadConfirmPanel): Add the correct logging and return
1424         the value of TestController::beforeUnloadReturnValue().
1425         (WTR::TestController::resetStateToConsistentValues): Reset
1426         m_beforeUnloadReturnValue to true.
1427         * WebKitTestRunner/TestController.h:
1428         (WTR::TestController::beforeUnloadReturnValue):
1429         (WTR::TestController::setBeforeUnloadReturnValue):
1430         * WebKitTestRunner/TestInvocation.cpp:
1431         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Handle the
1432         message posted from the injected bundle by retrieving the message body
1433         as a WKBoolean and calling TestController::setBeforeUnloadReturnValue().
1434
1435 2011-08-12  Sam Weinig  <sam@webkit.org>
1436
1437         Move compiler specific macros to their own header
1438         https://bugs.webkit.org/show_bug.cgi?id=66119
1439
1440         Reviewed by Anders Carlsson.
1441
1442         * DumpRenderTree/ForwardingHeaders/wtf/Compiler.h: Added.
1443
1444 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
1445
1446         Add a way to extend DOM objects in garden-o-matic.
1447         https://bugs.webkit.org/show_bug.cgi?id=66096
1448
1449         Reviewed by Adam Barth.
1450
1451         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added base.extends.
1452         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added tests.
1453
1454 2011-08-11  MORITA Hajime  <morrita@google.com>
1455
1456         [Chromium][DRT] editing/spelling/spelling-backspace-between-lines.html fails
1457         https://bugs.webkit.org/show_bug.cgi?id=45438
1458
1459         Reviewed by Kent Tamura.
1460
1461         MockSpellCheck was assuming the input of spellCheckWord() is a word.
1462         But it can be a series of word. This change made spellCheckWord()
1463         understand simple word boundary which appears in tests.
1464         
1465         * DumpRenderTree/chromium/MockSpellCheck.cpp:
1466         (MockSpellCheck::spellCheckWord):
1467
1468 2011-08-11  Mark Rowe  <mrowe@apple.com>
1469
1470         Rework some Makefile logic to remove a double-negative.
1471
1472         Reviewed by Jon Honeycutt.
1473
1474         * DumpRenderTree/mac/PerlSupport/Makefile:
1475
1476 2011-08-11  Anders Carlsson  <andersca@apple.com>
1477
1478         Add a FIXME.
1479
1480         * TestWebKitAPI/TestsController.cpp:
1481         (TestWebKitAPI::TestsController::TestsController):
1482
1483 2011-08-11  Anders Carlsson  <andersca@apple.com>
1484
1485         Initialize threading before running any tests
1486         https://bugs.webkit.org/show_bug.cgi?id=66112
1487
1488         Reviewed by Adam Barth.
1489
1490         * TestWebKitAPI/TestsController.cpp:
1491         (TestWebKitAPI::TestsController::TestsController):
1492
1493 2011-08-11  Adam Barth  <abarth@webkit.org>
1494
1495         Add unexpected-passes.html to TestFailures for marking tests as passing
1496         https://bugs.webkit.org/show_bug.cgi?id=66102
1497
1498         Reviewed by Dimitri Glazkov.
1499
1500         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1501         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
1502             - Move some code into the library so it can be shared.
1503         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
1504         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
1505         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
1506             - Add round-trip unit tests.
1507         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html: Added.
1508         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js: Added.
1509             - I'm not entirely sure this feature should remain a separate HTML
1510               file, but it seemed better than cluttering up the main HTML file
1511               with too much extra stuff.
1512         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1513         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1514             - The gardening server couldn't handle adding PASS expectations.  Now it can.
1515
1516 2011-08-11  Eric Seidel  <eric@webkit.org>
1517
1518         NRWT has wrong fallback order for Mac now that Lion exists
1519         https://bugs.webkit.org/show_bug.cgi?id=66093
1520
1521         Reviewed by Adam Barth.
1522
1523         ORWT used a different system for fallback orders than NRWT did.
1524         I moved win.py to match ORWT fallback orders in bug 64486.
1525         This bug moves mac.py to match ORWT fallback order
1526         and adds 'lion' as a supported OS version.
1527
1528         Because ChromiumMac shares OS version detection code with AppleMac
1529         this also added support for 'lion' to chromium mac.  Hopefully that's a good thing.
1530
1531         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1532         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1533         * Scripts/webkitpy/layout_tests/port/mac.py:
1534         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1535         * Scripts/webkitpy/layout_tests/port/win.py:
1536
1537 2011-08-11  Adam Barth  <abarth@webkit.org>
1538
1539         Update test results now that we use absolute URLs.
1540
1541         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js:
1542
1543 2011-08-11  Adam Barth  <abarth@webkit.org>
1544
1545         garden-o-matic should be able to determine when tests unexpectedly pass
1546         https://bugs.webkit.org/show_bug.cgi?id=66092
1547
1548         Reviewed by Dimitri Glazkov.
1549
1550         This patch just contains the library methods for extracting this
1551         information.  I'll add some UI in a subsequent patch.
1552
1553         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
1554         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
1555
1556 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
1557
1558         New expectation entries should be placed next to existing ones.
1559         https://bugs.webkit.org/show_bug.cgi?id=66066
1560
1561         Reviewed by Adam Barth.
1562
1563         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Added the notion of insertion point,
1564             which is computed as the last found reference to the same test.
1565         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added and adjusted unit tests.
1566
1567 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
1568
1569         Unreviewed, rolling out r92847.
1570         http://trac.webkit.org/changeset/92847
1571         https://bugs.webkit.org/show_bug.cgi?id=65986
1572
1573         Broke check-webkit-style
1574
1575         * Scripts/webkitpy/style/checker.py:
1576         * Scripts/webkitpy/style/checker_unittest.py:
1577
1578 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
1579
1580         Unreviewed, rolling out r92847.
1581         http://trac.webkit.org/changeset/92847
1582         https://bugs.webkit.org/show_bug.cgi?id=65986
1583
1584         Broke check-webkit-style
1585
1586         * Scripts/webkitpy/style/checker.py:
1587         * Scripts/webkitpy/style/checker_unittest.py:
1588
1589 2011-08-11  Pierre Rossi  <pierre.rossi@gmail.com>
1590
1591         [Qt] autotests shouldn't require config.h in the style check
1592         https://bugs.webkit.org/show_bug.cgi?id=65986
1593
1594         Remove the include rules from the style-check for Qt tests.
1595         Since for the most part it's just a matter of using the
1596         API provided by QtWebKit, enforcing the WebCore set of rules
1597         only seems to make sense in the case of MIMESniffing.
1598
1599         Reviewed by Benjamin Poulain.
1600
1601         * Scripts/webkitpy/style/checker.py:
1602         * Scripts/webkitpy/style/checker_unittest.py:
1603
1604 2011-08-11  Zsolt Fehér  <h490267@stud.u-szeged.hu>
1605
1606         [WK2] Implement waitForPolicyDelegate
1607         https://bugs.webkit.org/show_bug.cgi?id=42330
1608
1609         Reviewed by Csaba Osztrogonác.
1610
1611         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1612         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1613         (WTR::navigationTypeToString):
1614         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1615         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1616         (WTR::LayoutTestController::LayoutTestController):
1617         (WTR::LayoutTestController::setCustomPolicyDelegate):
1618         (WTR::LayoutTestController::waitForPolicyDelegate):
1619         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1620         (WTR::LayoutTestController::isPolicyDelegateEnabled):
1621         (WTR::LayoutTestController::isPolicyDelegatePermissive):
1622
1623 2011-08-11  Adam Barth  <abarth@webkit.org>
1624
1625         rebaseline-expectations should use the release bots, not the debug
1626         bots.  The debug bots don't all run all the tests.  Also, delay
1627         updating test_expectations a long as possible to avoid clearing out
1628         lines that we'll need for other ports.
1629
1630         * Scripts/webkitpy/layout_tests/port/builders.py:
1631         * Scripts/webkitpy/tool/commands/rebaseline.py:
1632         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1633
1634 2011-08-10  Ryosuke Niwa  <rniwa@webkit.org>
1635
1636         r92792 inadvertently removed PlatformSpecificScheduler for all Snow Leopard bots.
1637         Revert it partially so that the remaining Snow Leopard bots can fulfill their duty.
1638
1639         * BuildSlaveSupport/build.webkit.org-config/config.json:
1640
1641 2011-08-10  Eric Seidel  <eric@webkit.org>
1642
1643         new-run-webkit-test's WinPort has no fallback logic
1644         https://bugs.webkit.org/show_bug.cgi?id=64486
1645
1646         Unreviewed.
1647
1648         Turns out that we've long had a subtle bug whereby if you didn't
1649         already have DumpRenderTree built, we might end up running unsupported tests
1650         because the DumpRenderTree --print-supported-features check would silently fail.
1651
1652         When I moved the call from using popen to using Executive.run_command, this silent
1653         failure became noisy.  (Breaking some bots.)
1654
1655         This re-orders our steps so that we always build DRT before collecting expectations,
1656         as well as adds a warning message when DumpRenderTree can't be found.
1657
1658         * Scripts/webkitpy/layout_tests/port/webkit.py:
1659         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1660
1661 2011-08-10  Eric Seidel  <eric@webkit.org>
1662
1663         new-run-webkit-test's WinPort has no fallback logic
1664         https://bugs.webkit.org/show_bug.cgi?id=64486
1665
1666         Unreviewed.  Fix test-webkitpy under Python 2.5.
1667
1668         * Scripts/webkitpy/layout_tests/port/win.py:
1669
1670 2011-08-10  Benjamin Poulain  <benjamin@webkit.org>
1671
1672         [Qt][WK2] MiniBrowser is firing twice the QDesktopWebView::mousePressEvent method
1673         https://bugs.webkit.org/show_bug.cgi?id=65875
1674
1675         Reviewed by Kenneth Rohde Christiansen.
1676
1677         For some reason, QWidget send fake mouse event on some platform, under certains conditions.
1678
1679         This causes mouse events to be sent twice in some cases. We work around the problem
1680         by defining the first touch point to be a primary touch point (case which hit some
1681         weird condition in QWidget, skipping the generation of fake mouse events).
1682
1683         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1684         (MiniBrowserApplication::notify):
1685
1686 2011-08-10  David Hyatt  <hyatt@apple.com>
1687
1688         https://bugs.webkit.org/show_bug.cgi?id=66004
1689
1690         Remove the regions and exclusions bots and also the flags in build-webkit, since I'm just turning
1691         the code on by default.
1692
1693         Reviewed by Adam Roben.
1694
1695         * BuildSlaveSupport/build.webkit.org-config/config.json:
1696         * Scripts/build-webkit:
1697
1698 2011-08-10  Oliver Hunt  <oliver@apple.com>
1699
1700         JSEvaluteScript does not return the correct object when given JSONP data
1701         https://bugs.webkit.org/show_bug.cgi?id=66003
1702
1703         Reviewed by Gavin Barraclough.
1704
1705         Add a test case.
1706
1707         * DumpRenderTree/mac/DumpRenderTree.mm:
1708         (testStringByEvaluatingJavaScriptFromString):
1709
1710 2011-08-10  Eric Seidel  <eric@webkit.org>
1711
1712         WIN: NRWT runs compositing tests on configurations that don't support compositing
1713         https://bugs.webkit.org/show_bug.cgi?id=64472
1714
1715         Reviewed by Adam Barth.
1716
1717         I think the code was just wrong.  It was never splitting the string
1718         into list pieces before.
1719         I've now tested the supported_features code and theoretically it
1720         should now work with Windows DRT.
1721
1722         I also made the list-lookup functions always return lists, to make
1723         it possible to clean up the list-transform code in the future
1724         (I opted not to do that cleanup in this patch, but at least now
1725         both types of feature lookup functions match return types.)
1726
1727         * Scripts/webkitpy/layout_tests/port/webkit.py:
1728         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1729
1730 2011-08-10  Eric Seidel  <eric@webkit.org>
1731
1732         Clean up ChromiumDriver a little
1733         https://bugs.webkit.org/show_bug.cgi?id=65995
1734
1735         Unreviewed.
1736
1737         Fix NRWT for chromium.  Silly python.
1738
1739         * Scripts/webkitpy/layout_tests/port/chromium.py:
1740
1741 2011-08-10  Eric Seidel  <eric@webkit.org>
1742
1743         Clean up ChromiumDriver a little
1744         https://bugs.webkit.org/show_bug.cgi?id=65995
1745
1746         Reviewed by Adam Barth.
1747
1748         - We no longer support threading, so remove threading specific code.
1749         - Add FIXMEs about using ServerProcess instead.
1750         - Condense option-mapping if-cascade into a for loop.
1751         - Unindent long if blocks by using early return.
1752         - Unwrap lines which are needlessly wrapped.
1753
1754         There should be no functional changes here, just code cleanup/dead-code removal.
1755
1756         * Scripts/webkitpy/layout_tests/port/chromium.py:
1757
1758 2011-08-10  Dimitri Glazkov  <dglazkov@chromium.org>
1759
1760         Unmuddle construction options for TestConfiguration.
1761         https://bugs.webkit.org/show_bug.cgi?id=65988
1762
1763         The TestConfiguration instance is now constructed only using actual values.
1764         Port-based construction is split into a "from_port" class method.
1765
1766         Reviewed by Eric Seidel.
1767
1768         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added TestConfiguration.from_port
1769         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Adjusted code to accommodate the change.
1770         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Ditto.
1771         * Scripts/webkitpy/layout_tests/port/base.py: Ditto.
1772         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Ditto.
1773
1774 2011-08-10  Eric Seidel  <eric@webkit.org>
1775
1776         Leaks bot shows python logging prefixes as part of summary display
1777         https://bugs.webkit.org/show_bug.cgi?id=65931
1778
1779         Reviewed by Adam Barth.
1780
1781         The big part of this change is adding a unittesting system for
1782         master.cfg, so mere-mortals can make changes to build.webkit.org
1783         with greatly-reduced risk of breaking the world.
1784
1785         Turns out that in typing up my trival logging fix I made 2 typos,
1786         so hopefully the hour spent getting master.cfg to load was worth it. :)
1787
1788         I also tried to make mastercfg_unittest run as part of test-webkitpy
1789         but right now test-webkitpy requires that unittest files be located in
1790         a module-name-compatible directory.  'build.webkit.org-config' is not
1791         a valid module name.
1792
1793         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1794          - Fixed _parseNewRunWebKitTestsOutput to strip NRWT's python formatter prefix
1795            by using a new _strip_python_logging_prefix function.
1796          - Also fixed this function to file to work with a more modern
1797            simplejson version (which returns unicode objects instead of str objects)
1798            and filed a related bug with buildbot.net due to their handling of unicode builder names.
1799         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Added.
1800          - BuildBotConfigLoader is a huge pile of code just to get master.cfg to load.
1801          - The actual tiny unittest of the new _parseNewRunWebKitTestsOutput logic.
1802         * Scripts/webkitpy/thirdparty/__init__.py:
1803          - Add autoinstallation of buildbot (and jinja2) for use by mastercfg_unittest.py
1804
1805 2011-08-09  Dimitri Glazkov  <dglazkov@chromium.org>
1806
1807         garden-o-matic should extrapolate failures given a set of known results
1808         https://bugs.webkit.org/show_bug.cgi?id=65882
1809
1810         Reviewed by Adam Barth.
1811
1812         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Spuriously covered my old sins.
1813         * Scripts/webkitpy/layout_tests/port/builders.py: Augmented builders dictionary to contain build coverage specifiers,
1814             adjusted all call sites.
1815         * Scripts/webkitpy/tool/servers/gardeningserver.py: Added BuildCoverageExtrapolator, a thing that
1816             makes wider net for specific failures.
1817         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added unit tests.
1818
1819 2011-08-10  Adam Barth  <abarth@webkit.org>
1820
1821         The URL we were computing for retrieving baselines was missing a slash
1822         character because our mocks had an extra slash character.  I've
1823         corrected both the code and the mock.
1824
1825         * Scripts/webkitpy/tool/commands/rebaseline.py:
1826         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1827         * Scripts/webkitpy/tool/mocktool.py:
1828
1829 2011-08-09  Adam Barth  <abarth@webkit.org>
1830
1831         Move the quote mark to the right place.
1832
1833         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
1834
1835 2011-08-09  Adam Barth  <abarth@webkit.org>
1836
1837         garden-o-matic should use huerstics to narrow regression range
1838         https://bugs.webkit.org/show_bug.cgi?id=65948
1839
1840         Reviewed by Dimitri Glazkov.
1841
1842         When analyzing a regression range, if one of the commit messages
1843         mentions the test in question, we now hueristically assume that
1844         revision caused the failure.  (I'm shamelessly stealing this idea from
1845         TestFailures.)
1846
1847         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
1848
1849 2011-07-13  Eric Seidel  <eric@webkit.org>
1850
1851         new-run-webkit-test's WinPort has no fallback logic
1852         https://bugs.webkit.org/show_bug.cgi?id=64486
1853
1854         Reviewed by Adam Roben.
1855
1856         I've tried to write a patch for bug 64439 twice now, and both times
1857         I've ended up re-writing half the port system.  So I'm breaking
1858         things up into smaller pieces, this being the first.
1859
1860         WinPort still does not have any port_name parsing, so when instantiated
1861         with the name "win-xp" (i.e. by the rebaseline server) it will just behave as the 'win' port.
1862         I'll fix this in a second pass when I standardize port_name parsing for all webkit ports.
1863
1864         Otherwise this should "just work" for windows.  I've not been able to test the
1865         version detection on my mac, but the unit tests show the code behaving as designed.
1866
1867         * Scripts/webkitpy/layout_tests/port/win.py:
1868         * Scripts/webkitpy/layout_tests/port/win_unittest.py: Added.
1869
1870 2011-08-09  Adam Barth  <abarth@webkit.org>
1871
1872         Teach build.webkit.org's garden-o-matic how to talk to the local server
1873         https://bugs.webkit.org/show_bug.cgi?id=65940
1874
1875         Reviewed by Dimitri Glazkov.
1876
1877         After this patch, the version of garden-o-matic on build.webkit.org is
1878         fully functional.  It can interact with the local server via CORS.
1879
1880         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
1881         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
1882         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
1883         * Scripts/webkitpy/tool/commands/gardenomatic.py:
1884         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1885
1886 2011-08-09  Adam Barth  <abarth@webkit.org>
1887
1888         Enable CORS for garden-o-matic
1889         https://bugs.webkit.org/show_bug.cgi?id=65936
1890
1891         Reviewed by Dimitri Glazkov.
1892
1893         This patch will allow the hosted instance of garden-o-matic to
1894         communicate with the local server.
1895
1896         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1897         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
1898
1899 2011-08-09  Adam Barth  <abarth@webkit.org>
1900
1901         Upgrade jquery in TestFailures
1902         https://bugs.webkit.org/show_bug.cgi?id=65935
1903
1904         Reviewed by Dimitri Glazkov.
1905
1906         Upgrade to a newer version of jQuery with better support for CORS and CSP.
1907
1908         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1909         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
1910         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
1911
1912 2011-08-09  Sheriff Bot  <webkit.review.bot@gmail.com>
1913
1914         Unreviewed, rolling out r92683.
1915         http://trac.webkit.org/changeset/92683
1916         https://bugs.webkit.org/show_bug.cgi?id=65921
1917
1918          "Breaks Qt --minimal build. Revert pending update of the Qt
1919         minimal configuration" (Requested by simathur on #webkit).
1920
1921         * QtTestBrowser/cookiejar.cpp:
1922         (TestBrowserCookieJar::TestBrowserCookieJar):
1923         * QtTestBrowser/launcherwindow.cpp:
1924         (LauncherWindow::createChrome):
1925         (LauncherWindow::setDiskCache):
1926         * QtTestBrowser/main.cpp:
1927         (LauncherApplication::handleUserOptions):
1928         * QtTestBrowser/webpage.cpp:
1929         (WebPage::openUrlInDefaultBrowser):
1930
1931 2011-08-09  Siddharth Mathur  <siddharth.mathur@nokia.com>
1932
1933         [Qt] Simplify code by removing QT_NO_DESKTOPSERVICES and QT_NO_NETWORKDISKCACHE
1934         https://bugs.webkit.org/show_bug.cgi?id=65880
1935
1936         Reviewed by Andreas Kling.
1937
1938         QDesktopServices and QNetworkDiskCache have been around for a while now. Kill flags which 
1939         check for their feature flags. Assume that any reasonable Qt build provides them. 
1940         * QtTestBrowser/cookiejar.cpp:
1941         (TestBrowserCookieJar::TestBrowserCookieJar):
1942         * QtTestBrowser/launcherwindow.cpp:
1943         (LauncherWindow::createChrome):
1944         (LauncherWindow::setDiskCache):
1945         * QtTestBrowser/main.cpp:
1946         (LauncherApplication::handleUserOptions):
1947         * QtTestBrowser/webpage.cpp:
1948         (WebPage::openUrlInDefaultBrowser):
1949
1950 2011-08-09  Adam Barth  <abarth@webkit.org>
1951
1952         BaselineOptimizer created the wrong baseline for fast/js/regexp-overflow.html
1953         https://bugs.webkit.org/show_bug.cgi?id=65891
1954
1955         Reviewed by Eric Seidel.
1956
1957         The problem was that platform/chromium contained a bogus expectation
1958         file that needed to be removed, but by the time we got around to
1959         removing it, we'd already moved the correct baseline into its place.
1960         After this patch, we copy the gold results into memory before
1961         reshuffling things on disk (and we delete bad things before adding good
1962         things).
1963
1964         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
1965         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
1966
1967 2011-08-08  Adam Barth  <abarth@webkit.org>
1968
1969         Chromium Windows bots can't figure out what SVN revision they're running
1970         https://bugs.webkit.org/show_bug.cgi?id=65893
1971
1972         Reviewed by Eric Seidel.
1973
1974         The comment in _engage_awesome_windows_hacks explains why we're making
1975         this change.  It's ugly and rediculous, but this approach seems better
1976         than using shell=True when calling popen.
1977
1978         * Scripts/webkitpy/common/checkout/scm/svn.py:
1979         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1980
1981 2011-08-08  Adam Barth  <abarth@webkit.org>
1982
1983         Remove deduplicate-tests
1984         https://bugs.webkit.org/show_bug.cgi?id=65886
1985
1986         Reviewed by Tony Chang.
1987
1988         This script is redundant with "webkit-patch bulk-optimize-baselines",
1989         which can find many more duplicates than deduplicate-tests because
1990         bulk-optimize-baselines can move results around whereas
1991         deduplicate-tests can only remove results.
1992
1993         * Scripts/deduplicate-tests: Removed.
1994         * Scripts/webkitpy/to_be_moved/deduplicate_tests.py: Removed.
1995         * Scripts/webkitpy/to_be_moved/deduplicate_tests_unittest.py: Removed.
1996
1997 2011-08-08  Adam Barth  <abarth@webkit.org>
1998
1999         scm.delete should delete empty parent directories as well
2000         https://bugs.webkit.org/show_bug.cgi?id=65878
2001
2002         Reviewed by Eric Seidel.
2003
2004         This behavior makes SVN match GIT (which has no concept of empty
2005         directories).  This bug comes up a lot when optimizing baselines, which
2006         often create empty directories when we're able to optimize everything
2007         out of a given folder.
2008
2009         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2010         * Scripts/webkitpy/common/checkout/scm/svn.py:
2011
2012 2011-08-08  Lucas Forschler  <lforschler@apple.com>
2013
2014         Add triggers for Lion WK2 test bots.
2015
2016         Reviewed by Stephanie Lewis.
2017
2018         * BuildSlaveSupport/build.webkit.org-config/config.json:
2019
2020 2011-08-08  Adam Barth  <abarth@webkit.org>
2021
2022         bulk-optimize-baselines should take directories on the command line
2023         https://bugs.webkit.org/show_bug.cgi?id=65879
2024
2025         Reviewed by Dimitri Glazkov.
2026
2027         Passing lists of tests via stdin is a pain.  It's easier if the command
2028         takes a list of tests on the command line, like run-webkit-tests.
2029
2030         * Scripts/webkitpy/tool/commands/rebaseline.py:
2031
2032 2011-08-08  Adam Barth  <abarth@webkit.org>
2033
2034         Deprecate rebaseline-chromium-webkit-tests
2035         https://bugs.webkit.org/show_bug.cgi?id=65873
2036
2037         Reviewed by Dimitri Glazkov.
2038
2039         This script never worked correctly and now is redundant with more
2040         modern infrastructure for rebaselining tests.  This patch deprecates
2041         the script in order to flush out any issues with the new tools.  Once
2042         folks are happy with the new tools, we'll delete this script.
2043
2044         * Scripts/rebaseline-chromium-webkit-tests:
2045
2046 2011-08-08  Dimitri Glazkov  <dglazkov@chromium.org>
2047
2048         garden-o-matic should only touch expectations that need updating.
2049         https://bugs.webkit.org/show_bug.cgi?id=65876
2050
2051         Reviewed by Adam Barth.
2052
2053         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Added reconstitute_only_these to TestExpectationSerializer.list_to_string,
2054             so that a caller could influence which lines to serialize from values.
2055         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added tests.
2056         * Scripts/webkitpy/tool/servers/gardeningserver.py: Started using reconstitute_only_these.
2057         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added tests.
2058
2059 2011-08-08  Dimitri Glazkov  <dglazkov@chromium.org>
2060
2061         TestExpectationsEditor should return a list of updated expectations.
2062         https://bugs.webkit.org/show_bug.cgi?id=65872
2063
2064         Reviewed by Adam Barth.
2065
2066         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Added a list to store lines that are being updated.
2067         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Changed tests to account for updated lines.
2068
2069 2011-08-08  Jochen Eisinger  <jochen@chromium.org>
2070
2071         Fix SCM webkitpy unit test failures
2072         https://bugs.webkit.org/show_bug.cgi?id=65823
2073
2074         Reviewed by Eric Seidel.
2075
2076         * Scripts/webkitpy/common/checkout/scm/git.py:
2077         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2078
2079 2011-08-08  Eric Seidel  <eric@webkit.org>
2080
2081         Move the --leaks bot back over to NRWT now that I'm back
2082         from vacation and able to debug it.
2083
2084         Unreviewed.
2085
2086         * Scripts/run-webkit-tests:
2087         (usingWebKit2):
2088         (useNewRunWebKitTests):
2089
2090 2011-08-05  Dimitri Glazkov  <dglazkov@chromium.org>
2091
2092         Wire up updating expectations in garden-o-matic.
2093         https://bugs.webkit.org/show_bug.cgi?id=65794
2094
2095         Reviewed by Adam Barth.
2096
2097         * Scripts/webkitpy/layout_tests/port/factory.py: Moved _port_for_builder from rebaseline.py to here, rename to get_from_builder_name.
2098         * Scripts/webkitpy/tool/commands/rebaseline.py: Adapted callsites to new location.
2099         * Scripts/webkitpy/tool/servers/gardeningserver.py: Added GardeningExpectationsUpdater, which knows how to update expectations.
2100         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added loads of tests.
2101
2102 2011-08-08  Jochen Eisinger  <jochen@chromium.org>
2103
2104         webkit-patch doesn't get along with renamed files
2105         https://bugs.webkit.org/show_bug.cgi?id=48075
2106
2107         Possibly a bit heavy handed - I removed all instances of -C and
2108         changed every instance of -M with '--no-renames' in git.py. This
2109         forces git to not try to tell us about renames at all, which is
2110         ultimately the behaviour we want. The old file is shown deleted,
2111         then the new file is shown added, followed by any changes that
2112         occurred. Also gets rid of the problem where deleting one file
2113         and adding another file which has similar content would
2114         unexpectedly show up as a rename, and fall out of a diff.
2115
2116         Based on a patch by Wyatt Carss.
2117
2118         Reviewed by Eric Seidel.
2119
2120         * Scripts/webkitpy/common/checkout/scm/git.py:
2121
2122 2011-08-07  Sam White  <samuel.white@rochester.edu>
2123
2124         Add the ability to search the AccessibilityObject cache
2125         https://bugs.webkit.org/show_bug.cgi?id=64994
2126         
2127         Added testing support for AccessibilityObject cache searching. Currently,
2128         only the mac platform is full supported and has had API exposed. Other
2129         platforms have only have this new functionality stubbed. Full implementation
2130         is a job suited only for an accessibility expert of each respective platform.
2131
2132         Reviewed by Chris Fleizach.
2133
2134         * DumpRenderTree/AccessibilityUIElement.cpp:
2135         (uiElementForSearchPredicateCallback):
2136         (AccessibilityUIElement::getJSClass):
2137         * DumpRenderTree/AccessibilityUIElement.h:
2138         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2139         (AccessibilityUIElement::uiElementForSearchPredicate):
2140         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2141         (AccessibilityUIElement::uiElementForSearchPredicate):
2142         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2143         (AccessibilityUIElement::uiElementForSearchPredicate):
2144
2145 2011-08-06  Adam Barth  <abarth@webkit.org>
2146
2147         Remove dead code in webkitpy
2148         https://bugs.webkit.org/show_bug.cgi?id=65818
2149
2150         Reviewed by Dimitri Glazkov.
2151
2152         This code was added to support the rebaseline2 command six months ago,
2153         but the rebaseline2 command was never finished and no one else has used
2154         this code since it was landed.  This patch removes the dead code.  If
2155         we revive rebaseline2, then we can revert this patch and recover the
2156         code.  Until then, this code is just dead weight.
2157
2158         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2159         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2160         * Scripts/webkitpy/common/net/testoutput.py: Removed.
2161         * Scripts/webkitpy/common/net/testoutput_unittest.py: Removed.
2162         * Scripts/webkitpy/common/net/testoutputset.py: Removed.
2163         * Scripts/webkitpy/common/net/testoutputset_unittest.py: Removed.
2164         * Scripts/webkitpy/common/system/directoryfileset.py: Removed.
2165         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Removed.
2166         * Scripts/webkitpy/layout_tests/port/base.py:
2167         * Scripts/webkitpy/layout_tests/port/chromium.py:
2168         * Scripts/webkitpy/layout_tests/port/webkit.py:
2169
2170 2011-08-06  Adam Barth  <abarth@webkit.org>
2171
2172         webkit-patch optimize-baselines can't handle promotions to base results directory
2173         https://bugs.webkit.org/show_bug.cgi?id=65819
2174
2175         Reviewed by Dimitri Glazkov.
2176
2177         This bug came up when testing the optimizer on some editing baselines.
2178
2179         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
2180         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
2181
2182 2011-08-06  Adam Barth  <abarth@webkit.org>
2183
2184         Add a small command to optimize baselines in bulk.
2185
2186         * Scripts/webkitpy/tool/commands/rebaseline.py:
2187
2188 2011-08-05  Dimitri Glazkov  <dglazkov@chromium.org>
2189
2190         Fix unit test breakage by plumbing convert_404_to_None in MockWeb.
2191
2192         * Scripts/webkitpy/tool/mocktool.py: Added missing parameter to MockWeb.get_binary
2193
2194 2011-08-05  Dimitri Glazkov  <dglazkov@chromium.org>
2195
2196         Garden-o-matic updateexpectations needs a unit test.
2197         https://bugs.webkit.org/show_bug.cgi?id=65780
2198
2199         Reviewed by Adam Barth.
2200
2201         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added unit test.
2202
2203 2011-08-05  Anders Carlsson  <andersca@apple.com>
2204
2205         Future proof an Objective-C test
2206         https://bugs.webkit.org/show_bug.cgi?id=65788
2207
2208         Reviewed by Dan Bernstein.
2209
2210         Add isObjectInstanceOf to ObjCController.
2211
2212         * DumpRenderTree/mac/ObjCController.m:
2213         (+[ObjCController isSelectorExcludedFromWebScript:]):
2214         (+[ObjCController webScriptNameForSelector:]):
2215         (-[ObjCController isObject:instanceOf:]):
2216
2217 2011-08-05  Adam Barth  <abarth@webkit.org>
2218
2219         trac.js needs unittests
2220         https://bugs.webkit.org/show_bug.cgi?id=65673
2221
2222         Reviewed by Dimitri Glazkov.
2223
2224         This tests also have somewhat large fixtures.  I've trimmed the example
2225         XML down a bunch while still hitting interesting cases in the parsing.
2226
2227         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
2228         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Added.
2229
2230 2011-08-05  Adam Barth  <abarth@webkit.org>
2231
2232         Rebuild rebaseline-chromium-webkit-tests on top of modern infrastructure
2233         https://bugs.webkit.org/show_bug.cgi?id=65759
2234
2235         Reviewed by Dimitri Glazkov.
2236
2237         rebaseline-chromium-webkit-tests doesn't really fit into webkitpy's
2238         architecture, is poorly tested, and has a bunch of quirks.  This patch
2239         rebuilds the core functionality of rebaseline-chromium-webkit-tests on
2240         top of more modern infrastructure.  In the process, we get more code
2241         re-use and better testing.
2242
2243         Once we're satisfied with this new implementation, we can delete the
2244         old implementation.
2245
2246         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
2247         * Scripts/webkitpy/common/net/web.py:
2248         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2249         * Scripts/webkitpy/layout_tests/port/builders.py:
2250         * Scripts/webkitpy/layout_tests/port/chromium.py:
2251         * Scripts/webkitpy/layout_tests/port/factory.py:
2252         * Scripts/webkitpy/layout_tests/port/webkit.py:
2253         * Scripts/webkitpy/tool/commands/rebaseline.py:
2254         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2255
2256 2011-08-05  Anders Carlsson  <andersca@apple.com>
2257
2258         Remove PluginHalter
2259         https://bugs.webkit.org/show_bug.cgi?id=65729
2260
2261         Reviewed by Darin Adler.
2262
2263         Remove call to set the allowed plug-in run time.
2264
2265         * DumpRenderTree/mac/DumpRenderTree.mm:
2266         (resetDefaultsToConsistentValues):
2267
2268 2011-08-05  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
2269
2270         Unreviewed build fix for Qt-Minimal buildbot
2271
2272         Use ~/.QtTestBrowser for the cookiejar when QDesktopServices
2273         is disabled.
2274
2275         Rubber-stamped by Holger Freyther.
2276
2277         * QtTestBrowser/cookiejar.cpp:
2278         (TestBrowserCookieJar::TestBrowserCookieJar):
2279
2280 2011-08-05  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
2281
2282         [Qt] QtTestBrowser: Add support for saving cookies on disk
2283         https://bugs.webkit.org/show_bug.cgi?id=65328
2284
2285         Simple cookiejar that saves cookies on disk.
2286
2287         Added menu options to clear cookies (Edit->Clear cookies) and
2288         disable disk cookies (Settings->[ ]Save Cookies on Disk).
2289
2290         Option -no-disk-cookies is also available.
2291
2292         Reviewed by Andreas Kling.
2293
2294         * QtTestBrowser/QtTestBrowser.pro:
2295         * QtTestBrowser/cookiejar.cpp: Added.
2296         * QtTestBrowser/cookiejar.h: Added.
2297         * QtTestBrowser/launcherwindow.cpp:
2298         * QtTestBrowser/launcherwindow.h:
2299         * QtTestBrowser/main.cpp:
2300
2301 2011-08-04  Adam Barth  <abarth@webkit.org>
2302
2303         model.js needs some unit testing
2304         https://bugs.webkit.org/show_bug.cgi?id=65730
2305
2306         Reviewed by Dimitri Glazkov.
2307
2308         These tests do not cover all the functions exported by the model
2309         module.  We'll need to add the remaining ones in the future.
2310
2311         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Added.
2312         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
2313
2314 2011-08-04  Adam Barth  <abarth@webkit.org>
2315
2316         Another speculative fix for the "svn revision on Windows" problem.
2317
2318         * Scripts/webkitpy/common/checkout/scm/git.py:
2319
2320 2011-08-04  Mark Rowe  <mrowe@apple.com>
2321
2322         Future-proof Xcode configuration settings.
2323
2324         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2325         * DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig:
2326         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2327         * MiniBrowser/Configurations/Base.xcconfig:
2328         * MiniBrowser/Configurations/CompilerVersion.xcconfig:
2329         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2330         * TestWebKitAPI/Configurations/Base.xcconfig:
2331         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
2332         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2333         * WebKitTestRunner/Configurations/Base.xcconfig:
2334         * WebKitTestRunner/Configurations/CompilerVersion.xcconfig:
2335         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2336
2337 2011-08-04  Adam Barth  <abarth@webkit.org>
2338
2339         Fancier debug logging.
2340
2341         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2342
2343 2011-08-04  David Levin  <levin@chromium.org>
2344
2345         [chromium] Fix assertion failure in ThreadIdentifierData::identifier in TestShell.
2346         https://bugs.webkit.org/show_bug.cgi?id=65685
2347
2348         Reviewed by Dmitry Titov.
2349
2350         * DumpRenderTree/chromium/WebViewHost.cpp:
2351         (WebViewHost::WebViewHost): Intialize WTF threading before
2352         anything in WTF is used. Usually this is done by WebViewImpl::WebViewImpl
2353         but in some cases code may use WTF without creating WebViewImpl and
2354         WTF code functionality may call WTF::currentThread, which requires
2355         this initialization now.
2356
2357 2011-08-04  Adam Barth  <abarth@webkit.org>
2358
2359         An educated guess at causing the Windows bots on build.webkit.org to
2360         find the SVN revision number.
2361
2362         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2363         * Scripts/webkitpy/layout_tests/port/base.py:
2364
2365 2011-08-04  Adam Barth  <abarth@webkit.org>
2366
2367         More logging to help debug the "no SVN rev on Chromium Windows bots"
2368         bug.  My current theory is that we're trying to detect the SCM system
2369         in the wrong directory.
2370
2371         * Scripts/webkitpy/layout_tests/port/base.py:
2372
2373 2011-08-04  Dimitri Glazkov  <dglazkov@chromium.org>
2374
2375         Speed up webkit-patch optimize-expectations significantly by not collecting test files.
2376         https://bugs.webkit.org/show_bug.cgi?id=65697
2377
2378         I neglected to realize that collecting test names is not necessary for this operation.
2379
2380         Reviewed by Adam Barth.
2381
2382         * Scripts/webkitpy/tool/commands/expectations.py: Changed to pass an empty list of test files.
2383
2384 2011-08-04  Adam Barth  <abarth@webkit.org>
2385
2386         checkout_unittest.js should have better coverage of checkout.js
2387         https://bugs.webkit.org/show_bug.cgi?id=65671
2388
2389         Reviewed by Dimitri Glazkov.
2390
2391         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
2392             - Remove unused functions.
2393         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js:
2394             - Test remaining public functions in the checkout module.
2395
2396 2011-08-04  Dmitry Lomov  <dslomov@google.com>
2397
2398         https://bugs.webkit.org/show_bug.cgi?id=65706
2399         Run run-unit-tests on release mode test bots.
2400         Reenabling after 61812 is fixed.
2401
2402         Reviewed by Adam Roben.
2403
2404         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2405
2406 2011-08-04  Adam Barth  <abarth@webkit.org>
2407
2408         builders.js needs unit tests
2409         https://bugs.webkit.org/show_bug.cgi?id=65670
2410
2411         Reviewed by Dimitri Glazkov.
2412
2413         This test requires somewhat large test fixtures, but using real
2414         examples seemed better than trimming them down too much.
2415
2416         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js:
2417         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Added.
2418         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
2419             - Note: trac_unittests.js doesn't exist (yet!).
2420
2421 2011-08-04  Alexis Menard  <alexis.menard@openbossa.org>
2422
2423         [Qt] Make navigation actions properly usable in QML.
2424         https://bugs.webkit.org/show_bug.cgi?id=65624
2425
2426         Fix compilation after the introduction of QWebNavigationController.
2427
2428         Reviewed by Benjamin Poulain.
2429
2430         * MiniBrowser/qt/BrowserView.cpp:
2431         (BrowserView::navigationAction):
2432
2433 2011-08-04  Adam Barth  <abarth@webkit.org>
2434
2435         Another subtle bug due to lack of testing in main.js.  :(
2436
2437         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
2438
2439 2011-08-04  Adam Barth  <abarth@webkit.org>
2440
2441         Fix types.  Sadly, main.js has no test coverage.  (I need to think
2442         about how to test this part of the code.)
2443
2444         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
2445
2446 2011-08-04  Adam Barth  <abarth@webkit.org>
2447
2448         bugzilla.js is missing unit tests
2449         https://bugs.webkit.org/show_bug.cgi?id=65656
2450
2451         Reviewed by Adam Roben.
2452
2453         Testing makes perfect.
2454
2455         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js: Added.
2456         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js:
2457         (NetworkSimulator.prototype.runTest.get if):
2458         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
2459
2460 2011-08-04  Adam Barth  <abarth@webkit.org>
2461
2462         Add missing license blocks to garden-o-matic
2463         https://bugs.webkit.org/show_bug.cgi?id=65654
2464
2465         Reviewed by Dimitri Glazkov.
2466
2467         This patch is entirely boilerplate.
2468
2469         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
2470         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
2471         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js:
2472         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js:
2473         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
2474         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js:
2475         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
2476         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2477         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
2478         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
2479         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
2480         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js:
2481         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js:
2482         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
2483         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
2484         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
2485         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
2486         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
2487
2488 2011-08-04  Adam Barth  <abarth@webkit.org>
2489
2490         garden-o-matic needs a way to mock out the network
2491         https://bugs.webkit.org/show_bug.cgi?id=65653
2492
2493         Reviewed by Dimitri Glazkov.
2494
2495         This patch introduces the net module, which is a useful mock point for
2496         abstracting away the network.  Future patches will use this
2497         infrastructure to test some currently untested code.
2498
2499         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js:
2500         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
2501         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
2502         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js:
2503         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
2504         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2505         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
2506         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js: Added.
2507         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js: Added.
2508         (NetworkSimulator):
2509         (NetworkSimulator.prototype.scheduleCallback):
2510         (NetworkSimulator.prototype.runTest):
2511         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
2512         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
2513         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
2514         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2515
2516 2011-08-03  Adam Barth  <abarth@webkit.org>
2517
2518         Use failureInfo more pervasively in garden-o-matic
2519         https://bugs.webkit.org/show_bug.cgi?id=65650
2520
2521         Reviewed by Dimitri Glazkov.
2522
2523         These three variable appears in concert together many places.  This
2524         patch unifies the remaining uses into being failureInfo objects, which
2525         saves some marshalling.
2526
2527         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
2528         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
2529         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
2530         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
2531         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
2532
2533 2011-08-03  Adam Barth  <abarth@webkit.org>
2534
2535         garden-o-matic should be able to update expecations from the details pane
2536         https://bugs.webkit.org/show_bug.cgi?id=65648
2537
2538         Reviewed by Dimitri Glazkov.
2539
2540         The new button queues up the updates, which get executed all at once.
2541
2542         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2543         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
2544         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
2545
2546 2011-08-03  Adam Barth  <abarth@webkit.org>
2547
2548         Add UI to garden-o-matic for updating expectations
2549         https://bugs.webkit.org/show_bug.cgi?id=65644
2550
2551         Reviewed by Dimitri Glazkov.
2552
2553         The patch plumbs the UI back to the gardening server, but the gardening
2554         server endpoint is just a stub at this point.
2555
2556         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
2557         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2558         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
2559         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
2560         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2561         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
2562
2563 2011-08-03  Adam Barth  <abarth@webkit.org>
2564
2565         garden-o-matic details view should queue rebaselines for later execution
2566         https://bugs.webkit.org/show_bug.cgi?id=65636
2567
2568         Reviewed by Dimitri Glazkov.
2569
2570         This patch doesn't contain any confirmation UI, but we'll probably want
2571         that at some point.
2572
2573         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
2574         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2575         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
2576         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
2577
2578 2011-08-03  Kentaro Hara  <haraken@google.com>
2579
2580         Implement EventSender.scalePageBy()
2581         https://bugs.webkit.org/show_bug.cgi?id=58013
2582
2583         Reviewed by Darin Fisher.
2584
2585         Implemented EventSender.scalePageBy(f, x, y), which scales a page by a factor of f
2586         and then sets a scroll position to (x, y). Enabled the tests that had been waiting
2587         for the implementation of EventSender.scalePageBy(f, x, y).
2588
2589         Tests: compositing/scaling/tiled-layer-recursion.html
2590                fast/repaint/scale-page-shrink.html
2591                fast/dom/Element/scale-page-client-rects.html
2592                fast/dom/Range/scale-page-client-rects.html
2593                fast/events/scroll-in-scaled-page-with-overflow-hidden.html
2594                fast/dom/Element/scale-page-bounding-client-rect.html
2595                fast/dom/Range/scale-page-bounding-client-rect.html
2596
2597         * DumpRenderTree/chromium/EventSender.cpp:
2598         (EventSender::EventSender): Added bindings for scalePageBy().
2599         (EventSender::scalePageBy): A wrapper method for scalePage() in WebView.
2600         * DumpRenderTree/chromium/EventSender.h:
2601         * DumpRenderTree/chromium/TestShell.cpp:
2602         (TestShell::resetTestController): Resets the scale factor to 1.
2603
2604 2011-08-03  David Levin  <levin@chromium.org>
2605
2606         Rename WEBKIT_API to WEBKIT_EXPORT in check-webkit-style.
2607         https://bugs.webkit.org/show_bug.cgi?id=65652
2608
2609         Reviewed by Adam Barth.
2610
2611         * Scripts/webkitpy/style/checkers/cpp.py:
2612         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2613
2614 2011-08-03  Filip Pizlo  <fpizlo@apple.com>
2615
2616         Adding Filip Pizlo to committer list.
2617
2618         Unreviewed.
2619
2620         * Scripts/webkitpy/common/config/committers.py:
2621
2622 2011-08-03  Dimitri Glazkov  <dglazkov@chromium.org>
2623
2624         Add "optimize-expectations" command to webkit-patch.
2625         https://bugs.webkit.org/show_bug.cgi?id=65633
2626
2627         For now, only operates on Chromium test_expectations.txt and does not report errors/warnings.
2628
2629         Reviewed by Adam Barth.
2630
2631         * Scripts/webkitpy/tool/commands/__init__.py: Added command.
2632         * Scripts/webkitpy/tool/commands/expectations.py: Added.
2633
2634 2011-08-03  Dimitri Glazkov  <dglazkov@chromium.org>
2635
2636         Allow multiple bug identifiers in test expectations.
2637         https://bugs.webkit.org/show_bug.cgi?id=65642
2638
2639         Reviewed by Adam Barth.
2640
2641         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Tweaked to allow multiple bug ids.
2642         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added tests.
2643
2644 2011-08-03  Dimitri Glazkov  <dglazkov@chromium.org>
2645
2646         Teach BuilderToPort to distinguish between Release and Debug builders.
2647         https://bugs.webkit.org/show_bug.cgi?id=65628
2648
2649         Reviewed by Adam Barth.
2650
2651         * Scripts/webkitpy/tool/commands/rebaseline.py: Added a smart options object and passed it to port factory.
2652         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Added tests.
2653
2654 2011-08-03  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2655
2656         [Qt] Fix running qmltests for WK2 in the bot
2657         https://bugs.webkit.org/show_bug.cgi?id=65621
2658
2659         Reviewed by Csaba Osztrogonác.
2660
2661         The path for QML_IMPORT_PATH was assuming we were running the WK1 tests,
2662         but now there's the case for WK2 UIProcess tests as well.
2663
2664         * Scripts/run-qtwebkit-tests: add both possible paths to the QML_IMPORT_PATH.
2665
2666 2011-08-02  Dimitri Glazkov  <dglazkov@chromium.org>
2667
2668         Add a way to edit test expectations.
2669         https://bugs.webkit.org/show_bug.cgi?id=64922
2670
2671         Implements a TestExpectationsEditor, which provides a standard way to
2672         update and remove test expectations.
2673
2674         Reviewed by Adam Barth.
2675
2676         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed TestExpectationSerializer to skip lines that match no test configurations,
2677             added TestExpectationLine.is_flaky, added BugManager, a simple interface to be fleshed out later, and a TestExpectationsEditor, the big
2678             enchilada.
2679         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Loads of tests to capture desired behavior.
2680
2681 2011-08-03  Andreas Kling  <kling@webkit.org>
2682
2683         [Qt] MiniBrowser: Unbreak load progress indication.
2684         https://bugs.webkit.org/show_bug.cgi?id=65614
2685
2686         Reviewed by Kenneth Rohde Christiansen.
2687
2688         loadProgress() was renamed to loadProgressChanged().
2689
2690         * MiniBrowser/qt/BrowserWindow.cpp:
2691         (BrowserWindow::BrowserWindow):
2692         (BrowserWindow::onLoadProgressChanged):
2693         * MiniBrowser/qt/BrowserWindow.h:
2694
2695 2011-08-03  Martin Robinson  <mrobinson@igalia.com>
2696
2697         Build fix for WebKit2GTK+.
2698
2699         * WebKitTestRunner/GNUmakefile.am: Include libInternals as one of
2700         of the library dependencies of the injected bundle.
2701
2702 2011-08-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2703
2704         [GTK] Install web and plugin processes in libexecdir instead of bindir
2705         https://bugs.webkit.org/show_bug.cgi?id=65600
2706
2707         Reviewed by Martin Robinson.
2708
2709         Set WEBKIT_EXEC_PATH environment variable to use web and plugin
2710         process from current directory instead of the intalled ones.
2711
2712         * MiniBrowser/gtk/GNUmakefile.am:
2713         * MiniBrowser/gtk/main.c:
2714         (main):
2715         * WebKitTestRunner/GNUmakefile.am:
2716         * WebKitTestRunner/gtk/main.cpp:
2717         (main):
2718
2719 2011-08-02  Anders Carlsson  <andersca@apple.com>
2720
2721         Add mac-lion platform to old-run-webkit-tests
2722         https://bugs.webkit.org/show_bug.cgi?id=65577
2723
2724         * Scripts/old-run-webkit-tests:
2725         * Scripts/webkitdirs.pm:
2726         (isLion):
2727
2728 2011-08-02  Alexandru Chiculita  <achicu@adobe.com>
2729
2730         Buildbot: The Properties object has no "hasProperty" method in buildbot 8.3
2731         https://bugs.webkit.org/show_bug.cgi?id=65554
2732
2733         Using "has_key" instead of "hasProperty" in order to support buildbot 8.3.
2734
2735         Reviewed by Adam Roben.
2736
2737         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2738
2739 2011-08-02  Jochen Eisinger  <jochen@chromium.org>
2740
2741         Implement WebPermissionClient::allowPlugins for layout tests
2742         https://bugs.webkit.org/show_bug.cgi?id=33991
2743
2744         Reviewed by Adam Barth.
2745
2746         * DumpRenderTree/chromium/LayoutTestController.cpp:
2747         (LayoutTestController::LayoutTestController):
2748         (LayoutTestController::setPluginsAllowed):
2749         * DumpRenderTree/chromium/LayoutTestController.h:
2750         * DumpRenderTree/chromium/WebPermissions.cpp:
2751         (WebPermissions::allowPlugins):
2752         (WebPermissions::setPluginsAllowed):
2753         (WebPermissions::reset):
2754         * DumpRenderTree/chromium/WebPermissions.h:
2755
2756 2011-08-02  Adam Barth  <abarth@webkit.org>
2757
2758         TestFailures unit tests leak a global variable
2759         https://bugs.webkit.org/show_bug.cgi?id=65500
2760
2761         Reviewed by Adam Roben.
2762
2763         qunit detects the leak if you check the "noglobals" box on run-unittests.html.
2764
2765         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
2766
2767 2011-08-02  Alexandru Chiculita  <achicu@adobe.com>
2768
2769         CSS Regions build bot should archive and upload output files
2770         https://bugs.webkit.org/show_bug.cgi?id=65200
2771
2772         Until now the buildbots would only upload the result archive if the 'trigger' parameters was specified. The
2773         upload was needed, because the testbots needed to download and use the archive. For CSS Regions we don't have
2774         a testbot yet, but we want to save the archive on the server for manual testing. Added new parameter
2775         in config.json, called "upload" that when set to "true" will force the upload to the buildmaster server.
2776
2777         The "features" argument is now taken into account when determining the name of the archive on the server. That
2778         was needed in order to avoid the CSS Regions Mac buildbot overwrite the SnowLeopard Mac build.
2779
2780         Reviewed by Adam Roben.
2781
2782         * BuildSlaveSupport/build.webkit.org-config/config.json:
2783         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2784
2785 2011-08-02  Patrick Gansterer  <paroga@webkit.org>
2786
2787         Fix _win32_check_running_pid on 64bit windows python
2788         https://bugs.webkit.org/show_bug.cgi?id=64950
2789
2790         Reviewed by Adam Roben.
2791
2792         Use the correct types for the PROCESSENTRY32 struct.
2793         th32DefaultHeapID is declared as ULONG_PTR and not as DWORD.
2794         Using 32bit for pointers instead of 64bit results in an ERROR_BAD_LENGTH
2795         failure, when calling the Process32First function.
2796         This is covered by the executive unittest.
2797
2798         * Scripts/webkitpy/common/system/executive.py:
2799
2800 2011-08-01  Adam Barth  <abarth@webkit.org>
2801
2802         garden-o-matic should call optimize-baselines when rebaselining tests
2803         https://bugs.webkit.org/show_bug.cgi?id=65499
2804
2805         Reviewed by Dimitri Glazkov.
2806
2807         I took the opportunity to modernize this code to use some of our more
2808         powerful primitives from base.
2809
2810         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
2811         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js:
2812         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
2813         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2814         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2815
2816 2011-08-01  Stephanie Lewis  <slewis@apple.com>
2817
2818         Finish reconfiguration started by Lucas Forschler
2819         Reconfigured slaves:
2820         Removed Leopard Intel Release (Build)
2821         Removed Leopard Intel Release (Tests)
2822         Remove apple-pixel-1
2823         Added Lion slaves from disabled Leopard slaves
2824
2825         Added builders:
2826         Lion Intel Release (Build)
2827         Lion Intel Debug (Build)
2828         Lion Intel Release (Tests)
2829         Lion Intel Release WK2 (Tests)
2830         Lion Intel Debug (Tests)
2831         Lion Intel Debug WK2 (Tests)
2832
2833         Added triggers:
2834         lion-intel-debug-tests
2835         lion-intel-debug-test-wk2
2836         lion-intel-release-tests
2837         lion-intel-release-tests-wk2
2838         
2839         Removed trigger:
2840         leopard-intel-release-tests
2841
2842         Added PlatformSpecificScheduler:
2843         mac-lion
2844
2845         Added "mac-lion" to build.py and build_unitttest.py
2846
2847         Reviewed by Mark Rowe.
2848
2849         * BuildSlaveSupport/build.webkit.org-config/config.json:
2850         * Scripts/webkitpy/common/config/build.py:
2851         * Scripts/webkitpy/common/config/build_unittest.py:
2852
2853  
2854 2011-08-01  Adam Barth  <abarth@webkit.org>
2855
2856         webkit-patch needs to be able to "optimize" the storage of baselines on disk
2857         https://bugs.webkit.org/show_bug.cgi?id=65418
2858
2859         Reviewed by Dimitri Glazkov.
2860
2861         If we're not careful when rebaselining tests, we can end up with lots
2862         of duplicate expected results files in the tree.  This patch adds a
2863         webkit-patch command that optimizes the storage of expected results on
2864         disk.
2865
2866         This command is similar to deduplicate-tests, except that it can move
2867         test results around rather than just remove duplicate results.
2868
2869         Unfortunately, this problem is very tricky because the baseline search
2870         structure is a hypergraph.  This patch include a huerstic optimizer
2871         that appears to work on a bunch of examples I've tried.  We'll likely
2872         need to refine it as gain experience.
2873
2874         * Scripts/webkitpy/common/system/filesystem.py:
2875         * Scripts/webkitpy/tool/commands/rebaseline.py:
2876
2877 2011-08-01  Dimitri Glazkov  <dglazkov@chromium.org>
2878
2879         Teach TestExpectationSerializer about parsed expectations.
2880         https://bugs.webkit.org/show_bug.cgi?id=65444
2881
2882         This is a bit largish in size, but the essentials are:
2883         * TestExpectationSerializer, given a parsed TestExpectationLine, can now spit out a pretty string.
2884         * We now store original content of the expectation line on TestExpectationLine.
2885         * Lots of tests.
2886
2887         Reviewed by Adam Barth.
2888
2889         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Fixed an issue where we didn't
2890             populate macros correctly, also fixed an issue where we incorrectly returned an empty list
2891             for all configurations.
2892         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added tests for those.
2893         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Removed vestiges of code long gone,
2894             refactored TestExpectationsSerializer to recognize and correctly serialize parsed TestExpectationLine instances,
2895             changed to store and use TestExpectationLine.original_string.
2896         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added tests.
2897
2898 2011-08-01  Adam Barth  <abarth@webkit.org>
2899
2900         Remove unused functionality from gardeningserver
2901         https://bugs.webkit.org/show_bug.cgi?id=65479
2902
2903         Reviewed by Dimitri Glazkov.
2904
2905         We now handle these operations directly from the front-end.  That means
2906         they work even without the gardening server running!
2907
2908         Also, add some missing files to the list of static files.
2909
2910         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2911         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2912
2913 2011-08-01  Dimitri Glazkov  <dglazkov@chromium.org>
2914
2915         Introduce SpecifierSorter, a thing that knows how specifiers should be ordered.
2916         https://bugs.webkit.org/show_bug.cgi?id=65413
2917
2918         Reviewed by Adam Barth.
2919
2920         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added SpecifierSorter and converted
2921             existing code to use it.
2922         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added unit tests and cleaned up a bit.
2923
2924 2011-08-01  Adam Barth  <abarth@webkit.org>
2925
2926         Refactor bugzilla.js for use by garden-o-matic
2927         https://bugs.webkit.org/show_bug.cgi?id=65450
2928
2929         Reviewed by Dimitri Glazkov.
2930
2931         This patch refactors bugzilla.js to use the AsynchronousCache and
2932         updates the style to use a module instead of an object.  This patch
2933         then fixes all the existing code that uses this class to use the new
2934         API style.
2935
2936         This main benefit of this patch is we remove the tricky manual caching
2937         and this code is now available to use in garden-o-matic (since the
2938         dependency on Utilities.js is now gone).
2939
2940         I ran all the unit tests and poked around in TestFailures a bit to see
2941         that everything seemed to be working properly.
2942
2943         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js:
2944         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js:
2945         (FailingTestsBugForm):
2946         (FailingTestsBugForm.prototype._createBugTitle):
2947         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
2948         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js:
2949         (FlakyTestBugForm):
2950         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js:
2951         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js:
2952         (NewBugForm):
2953         (NewBugForm.prototype.domElement):
2954         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js:
2955         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js:
2956         (TestRelatedBugForm):
2957         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js:
2958         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
2959         (ViewController.prototype._displayBuilder.start):
2960         (ViewController.prototype._displayBuilder):
2961         (ViewController.prototype._domForAuxiliaryUIElements):
2962         (ViewController.prototype._domForNewAndExistingBugs.bugzilla.quickSearch):
2963         (ViewController.prototype._domForPossiblyFlakyTests.flakyList.appendChildren):
2964         (ViewController.prototype._domForPossiblyFlakyTests):
2965         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
2966         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2967         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
2968
2969 2011-08-01  Adam Barth  <abarth@webkit.org>
2970
2971         garden-o-matic shouldn't require local server to determine if compile failed
2972         https://bugs.webkit.org/show_bug.cgi?id=65446
2973
2974         Reviewed by Dimitri Glazkov.
2975
2976         This patch adds some basic bindings for the buildbot JSON API.  I
2977         wanted to use Buildbot.js an Builder.js from the original TestFailures,
2978         but they make a number of WebKit-specific assumptions.  We'll
2979         eventually need to reconcile these pieces of code.
2980
2981         I should really add tests for this code, but that will require me to
2982         build a better mock network.  I'll be happy to do that in a follow-up
2983         patch.
2984
2985         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js: Added.
2986             - It's very unclear to me whether didFail is correct.  Supposedly
2987               the first entry here is the exit code of the step, which is 0 on
2988               success.  I suspect we'll need to improve this function over time.
2989         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2990         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
2991         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
2992
2993 2011-08-01  Adam Barth  <abarth@webkit.org>
2994
2995         garden-o-matic should show all failures, even ones that it can't find a regression range for
2996         https://bugs.webkit.org/show_bug.cgi?id=65447
2997
2998         Reviewed by Dimitri Glazkov.
2999
3000         Previously, we just wouldn't display test failures that we couldn't
3001         identify a regression range for (or whose regression range had fallen
3002         off the page).  This patch just displays them at the end of the list,
3003         which is slightly (but not much) better.
3004
3005         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
3006
3007 2011-08-01  Jeff Miller  <jeffm@apple.com>
3008
3009         Windows build fix after r92096.
3010
3011         * TestWebKitAPI/win/InjectedBundleControllerWin.cpp: Use #include, not #import, and don't include Foundation.h.
3012         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Add InjectedBundleControllerWin.cpp.
3013
3014 2011-07-31  Anders Carlsson  <andersca@apple.com>
3015
3016         DownloadDecideDestinationCrash WebKit2 API tests crashes
3017         https://bugs.webkit.org/show_bug.cgi?id=65442
3018
3019         Reviewed by Sam Weinig.
3020
3021         Copy the 18-characters.html file to the destination directory so we won't
3022         crash trying to make an URL for it.
3023
3024         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3025
3026 2011-07-31  Anders Carlsson  <andersca@apple.com>
3027
3028         Fix SpacebarScrolling WebKit2 API test
3029         https://bugs.webkit.org/show_bug.cgi?id=65431
3030
3031         Reviewed by Sam Weinig.
3032
3033         Add a way to do platform-specific bundle initialization, and use it to disable smooth
3034         scrolling. Also make it possible for a test to load the injected bundle without actually running
3035         a test from it.
3036
3037         * TestWebKitAPI/InjectedBundleController.cpp:
3038         (TestWebKitAPI::InjectedBundleController::initialize):
3039         * TestWebKitAPI/InjectedBundleController.h:
3040         * TestWebKitAPI/PlatformUtilities.cpp:
3041         (TestWebKitAPI::Util::createContextWithInjectedBundle):
3042         * TestWebKitAPI/PlatformUtilities.h:
3043         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3044         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
3045         (TestWebKitAPI::TEST):
3046         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm: Added.
3047         (TestWebKitAPI::InjectedBundleController::platformInitialize):
3048         * TestWebKitAPI/win/InjectedBundleControllerWin.cpp: Added.
3049         (TestWebKitAPI::InjectedBundleController::platformInitialize):
3050         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3051
3052 2011-07-31  Dimitri Glazkov  <dglazkov@chromium.org>
3053
3054         Use set comparison to find duplicate or overlapping specifiers in test expectations.
3055         https://bugs.webkit.org/show_bug.cgi?id=65430
3056
3057         Reviewed by Adam Barth.
3058
3059         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed to use set comparisons, because length
3060             of a set is wrong.
3061         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Added some unit tests to actually catch
3062             regressions.
3063
3064 2011-07-31  Xan Lopez  <xlopez@igalia.com>
3065
3066         Group dependencies CFLAGS together.
3067
3068         * GNUmakefile.am: ditto.
3069
3070 2011-07-31  Daniel Bates  <dbates@webkit.org>
3071
3072         Attempt to fix the GTK build after <http://trac.webkit.org/changeset/92059>
3073         (https://bugs.webkit.org/show_bug.cgi?id=65419).
3074
3075         * GNUmakefile.am: Add $(CAIRO_CFLAGS) to libWebCoreInternals_la_CPPFLAGS.
3076
3077 2011-07-30  Patrick Gansterer  <paroga@webkit.org>
3078
3079         Fix ports_unittest.py on native windows
3080         https://bugs.webkit.org/show_bug.cgi?id=64959
3081
3082         Reviewed by Adam Barth.
3083
3084         Replace WebKitPort.script_path with WebKitPort.script_shell_command.
3085         The latter includes the interpreter executable required on native windows.
3086
3087         * Scripts/webkitpy/common/config/ports_unittest.py:
3088
3089 2011-07-30  Adam Barth  <abarth@webkit.org>
3090
3091         Properly escape regular expressions.  (Maybe these shouldn't be regular
3092         expressions?)
3093
3094         * Scripts/webkitpy/tool/commands/rebaseline.py:
3095
3096 2011-07-30  Adam Barth  <abarth@webkit.org>
3097
3098         Add support for Win7 to garden-o-matic.
3099
3100         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
3101         * Scripts/webkitpy/tool/commands/rebaseline.py:
3102
3103 2011-07-30  Adam Barth  <abarth@webkit.org>
3104
3105         garden-o-matic regression ranges expand after fast bots start passing
3106         https://bugs.webkit.org/show_bug.cgi?id=65406
3107
3108         Reviewed by Dimitri Glazkov.
3109
3110         Once the gardener has fixed a problem, the fast bots pick up the fix,
3111         which means we end up using the slow bots to compute the regression
3112         range.  Unfortunately, the slow bots give us large regression ranges,
3113         leading to this strange effect where the regression range quality
3114         degrades as fixes roll in.
3115
3116         This patch causes us to remember the previous regression ranges we've
3117         seen and to use that information in the future, as long as it's
3118         consistent with the new information we receive.
3119
3120         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
3121
3122 2011-07-30  Adam Barth  <abarth@webkit.org>
3123
3124         garden-o-matic should have a Refresh button to update its display
3125         https://bugs.webkit.org/show_bug.cgi?id=65403
3126
3127         Reviewed by Dimitri Glazkov.
3128
3129         The refresh button should be faster and less disruptive than the browser's reload button.
3130
3131         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3132         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
3133
3134 2011-07-30  Adam Barth  <abarth@webkit.org>
3135
3136         garden-o-matic should look for the "patch by" line in revisions ostensibly authored by the commit-queue
3137         https://bugs.webkit.org/show_bug.cgi?id=65231
3138
3139         Reviewed by Dimitri Glazkov.
3140
3141         The human readable name is easier to understand, especially when the patch is landed by the commit-queue.
3142
3143         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
3144
3145 2011-07-30  Adam Barth  <abarth@webkit.org>
3146
3147         garden-o-matic should strikeout revisions that have been rolled out
3148         https://bugs.webkit.org/show_bug.cgi?id=65227
3149
3150         Reviewed by Dimitri Glazkov.
3151
3152         This helps gardeners keep track of which problems have been solved.
3153
3154         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
3155         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
3156         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
3157         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
3158
3159 2011-07-30  Adam Barth  <abarth@webkit.org>
3160
3161         Add missing files to the server.
3162
3163         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3164
3165 2011-07-29  Adam Barth  <abarth@webkit.org>
3166
3167         Actually import the logging module!
3168
3169         * Scripts/webkitpy/common/checkout/scm/git.py:
3170
3171 2011-07-29  Adam Barth  <abarth@webkit.org>
3172
3173         More debug logging.  Maybe we're running the git version of this
3174         function somehow?  (That would explain why it doesn't work!)
3175
3176         * Scripts/webkitpy/common/checkout/scm/git.py:
3177
3178 2011-07-29  Adam Barth  <abarth@webkit.org>
3179
3180         Add some temporary debug logging messages to try to understand why the
3181         windows bots can't figure out their current SVN revision.
3182
3183         * Scripts/webkitpy/common/checkout/scm/svn.py:
3184
3185 2011-07-29  Adam Barth  <abarth@webkit.org>
3186
3187         Chromium try servers should use downstream test_expectations
3188         https://bugs.webkit.org/show_bug.cgi?id=65390
3189
3190         Reviewed by Dirk Pranke.
3191
3192         Otherwise the try servers will report bogus failures.
3193
3194         * Scripts/webkitpy/layout_tests/port/chromium.py:
3195
3196 2011-07-29  Dimitri Glazkov  <dglazkov@chromium.org>
3197
3198         Fix an error in macro collapsing, refactor code to be pretty.
3199         https://bugs.webkit.org/show_bug.cgi?id=65387
3200
3201         My set math was wrong.
3202
3203         Reviewed by Adam Barth.
3204
3205         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Moved collapsing into a classmethod, fixed the math to be correct.
3206         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added unit tests.
3207
3208 2011-07-27  Ryuan Choi  <ryuan.choi@samsung.com>
3209
3210         Style bot complains about EFL-specific forward declaration naming.
3211         https://bugs.webkit.org/show_bug.cgi?id=64680
3212
3213         Exclude EFL-specific forward declarations from indentifiers with underscores checks.
3214
3215         Reviewed by Adam Barth.
3216
3217         * Scripts/webkitpy/style/checkers/cpp.py:
3218         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3219
3220 2011-07-27  Adam Roben  <aroben@apple.com>
3221
3222         Use wacky !svn/bc URLs consistently in Leaks Viewer
3223
3224         This ensures that any resources loaded via relative URLs will still get pulled from the same
3225         revision of Subversion.
3226
3227         Fixes <http://webkit.org/b/65267> Focus/exclude button glyphs don't load on Leaks Viewer
3228
3229         Reviewed by David Kilzer.
3230
3231         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Use the
3232         !svn/bc-style URL for inspector.css, too, just like we do for all other resources we pull
3233         from Subversion.
3234
3235 2011-07-27  Raphael Kubo da Costa  <kubo@profusion.mobi>
3236
3237         [EFL] Drop WorkQueueItemEfl.h in favour of the general WorkQueueItem.h
3238         https://bugs.webkit.org/show_bug.cgi?id=65269
3239
3240         Reviewed by Kent Tamura.
3241
3242         WorkQueueItemEfl.h was being included by efl's
3243         LayoutTestControllerEfl.cpp, however the top-level
3244         LayoutTestController still included WorkQueueItem.h, causing a lot of
3245         type mismatches when running the WorkQueueItem code.
3246
3247         We can stick to the original WorkQueueItem header by making a few
3248         changes to EFL's LayoutTestController.
3249
3250         This should make tests such as
3251         fast/loader/non-deferred-substitute-load.html stop crashing.
3252
3253         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3254         (LayoutTestController::queueLoad):
3255         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
3256         (LoadItem::invoke):
3257         (LoadHTMLStringItem::invoke):
3258         (ScriptItem::invoke):
3259         * DumpRenderTree/efl/WorkQueueItemEfl.h: Removed.
3260
3261 2011-07-27  Dimitri Glazkov  <dglazkov@chromium.org>
3262
3263         Re-add unit tests I accidentally zapped in r91878.
3264
3265         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Re-added unit tests.
3266
3267 2011-07-27  Dimitri Glazkov  <dglazkov@chromium.org>
3268
3269         Replace SpecificityCalculator with TestConfiguration-driven logic.
3270         https://bugs.webkit.org/show_bug.cgi?id=65206
3271
3272         Use our newly-acquired ability to expand modifiers into a set of
3273         matching TestConfiguration instances to calculate specificity and
3274         determine whether expectation applies to a given test configuration.
3275
3276         Also, store bug modifier on TestExpectationsLine.
3277
3278         Reviewed by Adam Barth.
3279
3280         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Replaced the logic of calculating specificity with
3281             test configuration matching, removed a bunch of code.
3282         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Removed a bunch of tests that aren't useful anymore.
3283
3284
3285 2011-07-27  Dimitri Glazkov  <dglazkov@chromium.org>
3286
3287         Allow ports to specify their own test expectation specifier macros.
3288         https://bugs.webkit.org/show_bug.cgi?id=65291
3289
3290         Reviewed by Adam Barth.
3291
3292         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed SpecificityCalculator to use port macros.
3293         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Ditto.
3294         * Scripts/webkitpy/layout_tests/port/base.py: Added configuration_specifier_macros to retrieve the macros.
3295         * Scripts/webkitpy/layout_tests/port/chromium.py: Overrode it to return Chromium's macros.
3296         * Scripts/webkitpy/layout_tests/port/test.py: Added test macros.
3297
3298 2011-07-27  Dimitri Glazkov  <dglazkov@chromium.org>
3299
3300         Allow TestConfigurationConverter report conversion errors.
3301         https://bugs.webkit.org/show_bug.cgi?id=65287
3302
3303         Also, fix a few miscellaneous testing issues.
3304
3305         Reviewed by Adam Barth.
3306
3307         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added a way to report unknown modifier errors.
3308         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added a test for reporting errors.
3309         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Fixed an error where an invalid TestConfiguration instance
3310             was created. 'default' is not a valid build type.
3311         * Scripts/webkitpy/layout_tests/port/test.py: Ditto. '' is not a valid version.
3312
3313 2011-07-27  Dimitri Glazkov  <dglazkov@chromium.org>
3314
3315         Teach all ports about their test configurations.
3316         https://bugs.webkit.org/show_bug.cgi?id=65278
3317
3318         Each Port object should return a valid set of all TestConfiguration instances,
3319         available for this port.
3320
3321         Reviewed by Philippe Normand.
3322
3323         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Removed TestConfiguration.all_test_configurations,
3324             since it is different for each port.
3325         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Removed related test.
3326         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed SpecificityCalculator to take a list of
3327             all test configurations as a param.
3328         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Adjusted arguments accordingly.
3329         * Scripts/webkitpy/layout_tests/port/base.py: Forced all ports to override generation of all test configurations.
3330         * Scripts/webkitpy/layout_tests/port/chromium.py: Implemented _generate_all_test_configurations for the port.
3331         * Scripts/webkitpy/layout_tests/port/gtk.py: Ditto.
3332         * Scripts/webkitpy/layout_tests/port/mac.py: Ditto.
3333         * Scripts/webkitpy/layout_tests/port/qt.py: Ditto.
3334         * Scripts/webkitpy/layout_tests/port/win.py:
3335         * Scripts/webkitpy/layout_tests/port/port_testcase.py: Added an extra test to ensure we're generating a good set.
3336         * Scripts/webkitpy/layout_tests/port/test.py: Implemented a fixed-in-time all_test_configurations for testing.
3337         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added a mock all_test_configurations implementation.
3338         * Scripts/webkitpy/layout_tests/port/win_unittest.py: Added a unit test for the port.
3339
3340 2011-07-27  Benjamin Poulain  <benjamin@webkit.org>
3341
3342         [WK2][Qt] Move from QGraphicsView to Qt Scene Graph
3343         https://bugs.webkit.org/show_bug.cgi?id=62969
3344
3345         Reviewed by Andreas Kling.
3346
3347         Co-authored with Simon Hausmann  <simon.hausmann@nokia.com>
3348
3349         With the scene graph, the interface to have a window on screen is
3350         QSGCanvas. QGraphicsView is not used, and openGL is an enforced
3351         dependency.
3352
3353         Both the BrowserView and the WebKitTest runner are changed from
3354         QGraphicsView to QSGCanvas.
3355
3356         * MiniBrowser/qt/BrowserView.cpp:
3357         (BrowserView::BrowserView):
3358         (BrowserView::resizeEvent):
3359         (BrowserView::view):
3360         * MiniBrowser/qt/BrowserView.h:
3361         * MiniBrowser/qt/BrowserWindow.cpp:
3362         (BrowserWindow::BrowserWindow):
3363         (BrowserWindow::urlChanged):
3364         (BrowserWindow::~BrowserWindow):
3365         * MiniBrowser/qt/BrowserWindow.h:
3366         * MiniBrowser/qt/MiniBrowser.pro:
3367         * MiniBrowser/qt/main.cpp:
3368         (main):
3369         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3370         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3371         (WTR::WebView::WebView):
3372         (WTR::PlatformWebView::PlatformWebView):
3373         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3374
3375 2011-07-27  Sheriff Bot  <webkit.review.bot@gmail.com>
3376
3377         Unreviewed, rolling out r91792.
3378         http://trac.webkit.org/changeset/91792
3379         https://bugs.webkit.org/show_bug.cgi?id=65242
3380
3381         It broke NRWT on Qt and GTK (Requested by Ossy_night on
3382         #webkit).
3383
3384         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
3385         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
3386         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3387         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3388         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3389         * Scripts/webkitpy/layout_tests/port/test.py:
3390
3391 2011-07-26  Adam Barth  <abarth@webkit.org>
3392
3393         Switch to an older idiom that works on Python 2.5.
3394
3395         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
3396
3397 2011-07-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3398
3399         Add an exception to coding style check for EFL port.
3400         https://bugs.webkit.org/show_bug.cgi?id=65162
3401
3402         Add an exception of whitespace/declaration for EFL port. Because,
3403         '*' operator is next to variable in EFL coding style.
3404
3405         Reviewed by Kent Tamura.
3406
3407         * Scripts/webkitpy/style/checker.py:
3408
3409 2011-07-26  Keith Kyzivat  <keith.kyzivat@nokia.com>
3410
3411         [Qt] Add option to turn on disk caching in QtTestBrowser
3412         https://bugs.webkit.org/show_bug.cgi?id=65007
3413
3414         Reviewed by Noam Rosenthal.
3415
3416         Add menu item and command line option to turn on disk caching in
3417         QtTestBrowser. Simple QNetworkDiskCache added to the page's
3418         QNetworkAccssManager.
3419
3420         * QtTestBrowser/launcherwindow.cpp:
3421         (LauncherWindow::initializeView):
3422         (LauncherWindow::createChrome):
3423         (LauncherWindow::setDiskCache):
3424         * QtTestBrowser/launcherwindow.h:
3425         (WindowOptions::WindowOptions):
3426         * QtTestBrowser/main.cpp:
3427         (LauncherApplication::handleUserOptions):
3428
3429 2011-07-26  Sadrul Habib Chowdhury  <sadrul@chromium.org>
3430
3431         Add support for download='filename' attribute in anchors.
3432         https://bugs.webkit.org/show_bug.cgi?id=64580
3433
3434         Reviewed by Adam Barth.
3435
3436         * DumpRenderTree/chromium/WebViewHost.cpp:
3437         (WebViewHost::loadURLExternally):
3438         * DumpRenderTree/chromium/WebViewHost.h:
3439
3440 2011-07-26  Dan Bernstein  <mitz@apple.com>
3441
3442         Rubber-stamped by Anders Carlsson.
3443
3444         Update DumpRenderTree and API tests for the pictograph font family preference.
3445
3446         * DumpRenderTree/mac/DumpRenderTree.mm:
3447         (resetDefaultsToConsistentValues):
3448         * DumpRenderTree/win/DumpRenderTree.cpp:
3449         (resetDefaultsToConsistentValues):
3450         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3451         (TestWebKitAPI::TEST):
3452         * WebKitTestRunner/TestController.cpp:
3453         (WTR::TestController::resetStateToConsistentValues):
3454
3455 2011-07-26  Dimitri Glazkov  <dglazkov@chromium.org>
3456
3457         Replace SpecificityCalculator with TestConfiguration-driven logic.
3458         https://bugs.webkit.org/show_bug.cgi?id=65206
3459
3460         Use our newly-acquired ability to expand modifiers into a set of
3461         matching TestConfiguration instances to calculate specificity and
3462         determine whether expectation applies to a given test configuration.
3463
3464         Also, store bug modifier on TestExpectationsLine.
3465
3466         Reviewed by Adam Barth.
3467
3468         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added a way to report unknown modifier errors.
3469         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added a test for reporting errors.
3470         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Replaced the logic of calculating specificity with
3471             test configuration matching, removed a bunch of code.
3472         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Removed a bunch of tests that aren't useful anymore.
3473         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Fixed an error where an invalid TestConfiguration instance
3474             was created. 'default' is not a valid build type.
3475         * Scripts/webkitpy/layout_tests/port/test.py: Ditto. '' is not a valid version.
3476
3477 2011-07-26  Adam Barth  <abarth@webkit.org>
3478
3479         Increase the information density in garden-o-matic
3480         https://bugs.webkit.org/show_bug.cgi?id=65141
3481
3482         Reviewed by Dimitri Glazkov.
3483
3484         This patch changes lets us show each revision on a single line,
3485         allowing use to show an entire day's worth of commits at once.
3486
3487         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
3488         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
3489         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
3490
3491 2011-07-26  Dimitri Glazkov  <dglazkov@chromium.org>
3492
3493         TestConfigurationConverter should not barf on invalid specifiers.
3494         https://bugs.webkit.org/show_bug.cgi?id=65194
3495
3496         Reviewed by Adam Barth.
3497
3498         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Refactored TestConfigurationConverter.to_config_set a bit,
3499             made it return empty set whenever an invalid specifier is encountered.
3500         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added corresponding tests.
3501
3502 2011-07-26  Dimitri Glazkov  <dglazkov@chromium.org>
3503
3504         Introduce a way to convert between specifier lists and TestConfiguration sets.
3505         https://bugs.webkit.org/show_bug.cgi?id=65094
3506
3507         Add TestConfigurationConverter, a facility to convert:
3508         1) a set of specifiers into a set of TestConfiguration instances;
3509         2) a set of TestConfiguration instances into a list of sets of specifiers.
3510
3511         Reviewed by Adam Barth.
3512
3513         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added TestConfigurationConverter.
3514         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added tests for it.
3515
3516 2011-07-26  Alexandru Chiculita  <achicu@adobe.com>
3517
3518         CSS Regions build bot should build with "--css-regions" and "--css-exclusion" flags
3519         https://bugs.webkit.org/show_bug.cgi?id=65171
3520
3521         Added "features" parameter in config.json for "builder" objects. The parameter is optional and must be an array. All the items
3522         of the array will be passed to the build-webkit script. The items will automatically be prefixed with "--".
3523
3524         Reviewed by Adam Roben.
3525
3526         * BuildSlaveSupport/build.webkit.org-config/config.json:
3527         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3528
3529 2011-07-26  Chris Rogers  <crogers@google.com>
3530
3531         Avoid outputting #EOF twice for web audio tests in chromium DRT
3532         https://bugs.webkit.org/show_bug.cgi?id=65201
3533
3534         Reviewed by Dirk Pranke.
3535
3536         * DumpRenderTree/chromium/TestShell.cpp:
3537         (TestShell::dump):
3538
3539 2011-07-26  Adam Barth  <abarth@webkit.org>
3540
3541         Windows bots on build.chromium.org can't figure out the head_svn_revision
3542         https://bugs.webkit.org/show_bug.cgi?id=65156
3543
3544         Reviewed by Tony Chang.
3545
3546         This patch is a bit of a guess as to the issue based on the
3547         investigation in https://bugs.webkit.org/show_bug.cgi?id=65148.  I'm
3548         not sure whether it will fix the issue, but it seems worth a try.
3549
3550         * Scripts/webkitpy/common/checkout/scm/svn.py:
3551
3552 2011-07-26  Carlos Garcia Campos  <cgarcia@igalia.com>
3553
3554         Unreviewed. Fix WebKitGtk build with GTK+ 3.x after r91707.
3555
3556         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp:
3557         (getPreferredSizeMethod):
3558
3559 2011-07-26  MORITA Hajime  <morrita@google.com>
3560