[GTK] Clear application cache between tests in DumpRenderTree
[WebKit-https.git] / Tools / ChangeLog
1 2012-09-14  Zan Dobersek  <zandobersek@gmail.com>
2
3         [GTK] Clear application cache between tests in DumpRenderTree
4         https://bugs.webkit.org/show_bug.cgi?id=96543
5
6         Reviewed by Philippe Normand.
7
8         Call the new DumpRenderTreeSupportGtk method to clear application cache
9         after each test in DumpRenderTree.
10
11         Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
12         as well. It's now being set in XvfbDriver._start so that each driver is assigned
13         a cache directory that's constructed out of the driver's name and its worker
14         number. These directories are located in the layout tests results directory.
15         At least on the builders this ensures a driver-specific empty cache directory
16         with each test run.
17
18         * DumpRenderTree/gtk/DumpRenderTree.cpp:
19         (runTest):
20         * Scripts/webkitpy/layout_tests/port/gtk.py:
21         (GtkPort.setup_environ_for_server):
22         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
23         (XvfbDriver._start):
24
25 2012-09-14  Simon Hausmann  <simon.hausmann@nokia.com>
26
27         [Qt] Fix linking on Windows
28
29         Reviewed by Tor Arne Vestbø.
30
31         When compiling code _after_ QtWebKit.dll, we need to make sure that the QWEBKIT_EXPORT
32         macro turns into an import macro, which means QT_MAKEDLL should only be set _up until_
33         the QtWebKit.dll creation in the build process and be off afterwards. This is done in
34         win32/default_post.prf using a !contains(QT, webkit): DEFINES += QT_MAKEDLL.
35
36         r128450 sanitized the values of QT and PKGCONFIG to only contain the dependencies we
37         want for QtWebKit.dll, but unfortunately that code was applied to any binary built also
38         after the module. Therefore QT did never contain webkit anymore and we always passed
39         QT_MAKEDLL to DEFINES, resulting in QWEBKIT_EXPORT to _not_ turn into an import macro.
40
41         This patch introduces a creating_module configuration that is used to
42         scope the qt/pkgconfig sanitization.
43
44         * qmake/mkspecs/features/default_post.prf:
45
46 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
47
48         [WK2][WKTR] TestRunner is not dumping some frame load callbacks information
49         https://bugs.webkit.org/show_bug.cgi?id=96740
50
51         Reviewed by Kenneth Rohde Christiansen.
52
53         Dump information expected by the test cases about the following
54         frame load callbacks:
55         "didDisplayInsecureContentForFrame"
56         "didRunInsecureContentForFrame"
57         "didDetectXSSForFrame"
58
59         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
60         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Print a URL
61         as expected by test results by calling pathSuitableForTestResult() instead
62         of printing raw URL.
63         (WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
64         (WTR::InjectedBundlePage::didRunInsecureContentForFrame):
65         (WTR::InjectedBundlePage::didDetectXSSForFrame):
66
67 2012-09-14  Peter Beverloo  <peter@chromium.org>
68
69         The runtime/unsigned category should be valid in the cpp style-checker.
70         https://bugs.webkit.org/show_bug.cgi?id=96748
71
72         Reviewed by Csaba Osztrogonác.
73
74         This is causing the webkitpy tests to fail because it's not listed in the
75         category array. Furthermore, change an "int" to "long" because it's
76         throwing a double error in one of the earlier asserts.
77
78         * Scripts/webkitpy/style/checkers/cpp.py:
79         (CppChecker):
80         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
81         (WebKitStyleTest.test_names):
82
83 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
84
85         Evas_Object* is a ref'ed structure, so tread it as such
86         https://bugs.webkit.org/show_bug.cgi?id=96659
87
88         Reviewed by Adam Barth.
89
90         Replace OwnPtr<Evas_Object> with RefPtr.
91
92         * DumpRenderTree/efl/ImageDiff.cpp:
93         (calculateDifference):
94         (printImageDifferences):
95         (readImageFromStdin):
96         (main):
97
98 2012-09-14  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
99
100         Unreviewed, rolling out r128507.
101         http://trac.webkit.org/changeset/128507
102         https://bugs.webkit.org/show_bug.cgi?id=96659
103
104         Revert. r128507 makes too many crashes in EFL layout test bots.
105
106         * DumpRenderTree/efl/ImageDiff.cpp:
107         (calculateDifference):
108         (printImageDifferences):
109         (readImageFromStdin):
110         (main):
111
112 2012-09-13  Kevin Funk  <kevin.funk@kdab.com>
113
114         Make compile with both OS(WINCE) and PLATFORM(QT) support
115         https://bugs.webkit.org/show_bug.cgi?id=95536
116
117         Reviewed by Simon Hausmann.
118
119         Fix wince support in qmake files
120
121         * Tools.pro:
122         * qmake/mkspecs/features/configure.prf:
123         * qmake/mkspecs/features/default_post.prf:
124         * qmake/mkspecs/features/features.prf:
125         * qmake/mkspecs/features/functions.prf:
126
127 2012-09-13  KwangYong Choi  <ky0.choi@samsung.com>
128
129         [WK2] Add color picker API support for WebKit2
130         https://bugs.webkit.org/show_bug.cgi?id=95058
131
132         Reviewed by Gyuyoung Kim.
133
134         Initialization code for color picker callbacks in UI client.
135
136         * MiniBrowser/mac/BrowserWindowController.m:
137         (-[BrowserWindowController awakeFromNib]):
138         * MiniBrowser/win/BrowserView.cpp:
139         (BrowserView::create):
140         * WebKitTestRunner/TestController.cpp:
141         (WTR::TestController::createOtherPage):
142         (WTR::TestController::initialize):
143
144 2012-09-13  Yuta Kitamura  <yutak@chromium.org>
145
146         Upgrade yutak to reviewer
147         https://bugs.webkit.org/show_bug.cgi?id=96721
148
149         Reviewed by Kent Tamura.
150
151         * Scripts/webkitpy/common/config/committers.py:
152
153 2012-09-13  Adenilson Cavalcanti  <cavalcantii@gmail.com>
154
155         Make the style checker report usage of "unsigned int"
156         https://bugs.webkit.org/show_bug.cgi?id=96693
157
158         Reviewed by Dirk Pranke.
159
160         Add a rule to check for uses of unsigned int, as the updated coding style recomends.
161
162         * Scripts/webkitpy/style/checkers/cpp.py:
163         (check_language):
164
165 2012-09-13  Philip Rogers  <pdr@google.com>
166
167         Add gender-neutral form of webkit-patch land-cowboy
168         https://bugs.webkit.org/show_bug.cgi?id=96709
169
170         Reviewed by Adam Barth.
171
172         Add webkit-patch land-cowhand, the confident and courageous form of webkit-patch for everyone.
173
174         * Scripts/webkitpy/tool/commands/download.py:
175         (LandCowhand):
176
177 2012-09-13  Seokju Kwon  <seokju.kwon@samsung.com>
178
179         [EFL] Remove some parameters in browserCreate()
180         https://bugs.webkit.org/show_bug.cgi?id=96499
181
182         Reviewed by Kenneth Rohde Christiansen.
183
184         There are too many parameters in browserCreate(). Lots of it seems like settings from command line argument.
185         And I have moved some parameters into User_Arguments.
186
187         * EWebLauncher/main.c:
188         (_User_Arguments):
189         (_ELauncher):
190         (on_key_down):
191         (browserCreate):
192         (findThemePath):
193         (parseUserArguments):
194         (main):
195
196 2012-09-13  Mark Lam  <mark.lam@apple.com>
197
198         Unreviewed. Adding myself to the committers list.
199
200         * Scripts/webkitpy/common/config/committers.py:
201
202 2012-09-13  Ryosuke Niwa  <rniwa@webkit.org>
203
204         run-perf-tests output cryptic error when the config file is missing.
205         https://bugs.webkit.org/show_bug.cgi?id=96453
206
207         Reviewed by Tony Chang.
208
209         Add a special error message when a configuration file is missing.
210
211         Also update the help message of --source-json-path to signify the fact it specifies
212         the configuration file on performance tests bots.
213
214         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
215         (PerfTestsRunner._parse_args):
216         (PerfTestsRunner._generate_and_show_results):
217         (PerfTestsRunner._merge_slave_config_json):
218         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
219         (_test_run_with_json_output): Make upload to fail by default and assert the result
220         in the function so that we can return logs instead.
221         (_test_run_with_json_output.mock_upload_json):
222         (test_run_with_json_output):
223         (test_run_with_description):
224         (test_run_respects_no_results):
225         (test_run_with_slave_config_json):
226         (test_run_with_bad_slave_config_json):
227         (test_run_with_multiple_repositories):
228
229 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
230
231         Evas_Object* is a ref'ed structure, so tread it as such
232         https://bugs.webkit.org/show_bug.cgi?id=96659
233
234         Reviewed by Adam Barth.
235
236         Replace OwnPtr<Evas_Object> with RefPtr.
237
238         * DumpRenderTree/efl/ImageDiff.cpp:
239         (calculateDifference):
240         (printImageDifferences):
241         (readImageFromStdin):
242         (main):
243
244 2012-09-13  Csaba Osztrogonác  <ossy@webkit.org>
245
246         One more unreviewed trivial fix after r128399.
247
248         * BuildSlaveSupport/build.webkit.org-config/config.json: Fix URLs of the SVN mirror server.
249
250 2012-09-13  Csaba Osztrogonác  <ossy@webkit.org>
251
252         Unreviewed trivial fix after r128399.
253
254         * BuildSlaveSupport/wait-for-SVN-server.py: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py.
255         (getLatestSVNRevision):
256         (waitForSVNRevision):
257
258 2012-09-13  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
259
260         [WK2][WTR] WebKitTestRunner needs testRunner.callShouldCloseOnWebView
261         https://bugs.webkit.org/show_bug.cgi?id=96366
262
263         Reviewed by Anders Carlsson.
264
265         Implement testRunner.callShouldCloseOnWebView for WebKitTestRunner
266         by calling shouldClose() on the FrameLoader.
267
268         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
269         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
270         (WTR::TestRunner::callShouldCloseOnWebView):
271         (WTR):
272         * WebKitTestRunner/InjectedBundle/TestRunner.h:
273         (TestRunner):
274
275 2012-09-13  Sheriff Bot  <webkit.review.bot@gmail.com>
276
277         Unreviewed, rolling out r128453.
278         http://trac.webkit.org/changeset/128453
279         https://bugs.webkit.org/show_bug.cgi?id=96681
280
281         Having tests use the same appcache directory leads to timeouts
282         (Requested by zdobersek on #webkit).
283
284         * DumpRenderTree/gtk/DumpRenderTree.cpp:
285         (runTest):
286         * Scripts/webkitpy/layout_tests/port/gtk.py:
287         (GtkPort.setup_environ_for_server):
288
289 2012-09-13  James Robinson  <jamesr@chromium.org>
290
291         [chromium] Temporarily remove Android Builder (dbg) from garden-o-matic view
292         https://bugs.webkit.org/show_bug.cgi?id=96678
293
294         Reviewed by Dirk Pranke.
295
296         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
297         (.):
298
299 2012-09-13  Rob Buis  <rbuis@rim.com>
300
301         Unreviewed changes to watchlist.
302
303         - Add myself to BlackBerry bugs
304
305         * Scripts/webkitpy/common/config/watchlist:
306
307 2012-09-13  Stephen Chenney  <schenney@chromium.org>
308
309         Add an SVG entry to the watchlist
310
311         Unreviewed config change.
312
313         * Scripts/webkitpy/common/config/watchlist:
314         - Created a new SVG watchlist label covering WebCore/svg and WebCore/rendering/svg
315         - Added myself and pdr as watchers
316
317 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
318
319         [Qt] Make WebKit2 work on Windows with Qt 5
320         https://bugs.webkit.org/show_bug.cgi?id=76776
321
322         Reviewed by Tor Arne Vestbø.
323
324         WebKit2 should compile with Qt on Windows now, so enable it. This patch in fact corrects
325         the check to disable WebKit when we don't have USE_3D_GRAPHICS available, because we need
326         that for the GL TextureMapper (it's only built when that feature is set).
327
328         * qmake/mkspecs/features/configure.prf:
329
330 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
331
332         [Qt] Ensure that QT is finalized before loading qt_module.prf
333
334         As qt_module.prf does dependency tracking based on the content of the
335         QT variable. The intermediate WebKit modules modify the variable in
336         their .pri files, so we have to ensure we've loaded all the modules
337         before loading qt_module.
338
339         Reviewed by Tor Arne Vestbø.
340         Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-09-13
341
342         * qmake/mkspecs/features/default_post.prf:
343         * qmake/mkspecs/features/webkit_modules.prf: Added.
344
345 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
346
347         [Qt] Fix build of Qt WTR/MiniBrowser with MSVC and nmake
348         https://bugs.webkit.org/show_bug.cgi?id=96633
349
350         Reviewed by Csaba Osztrogonác.
351
352         WTR and MiniBrowser both have DRT in their include path (for the shared font stuff). Batch
353         builds with MSVC and nmake result in nmake picking up main.cpp from the wrong directory.
354         It's the usual problem and the usual solution is to rename one of the conflicting files.
355         This patch chooses to rename DRT instead of WTR and MBR.
356
357         Fixed include order at the same time to match style guide.
358
359         * DumpRenderTree/qt/DumpRenderTree.pro:
360         * DumpRenderTree/qt/DumpRenderTreeMain.cpp: Renamed from Tools/DumpRenderTree/qt/main.cpp.
361         (messageHandler):
362         (isOption):
363         (takeOptionValue):
364         (printUsage):
365         (main):
366
367 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
368
369         The Script run-launcher should support -2 in combination with --efl
370         https://bugs.webkit.org/show_bug.cgi?id=96639
371
372         Reviewed by Simon Hausmann.
373
374         Support running the MiniBrowser then supplied -2 as argument.
375
376         * Scripts/run-launcher:
377
378 2012-09-13  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
379
380         Unreviewed, add my Intel email address to the list.
381
382         * Scripts/webkitpy/common/config/committers.py:
383
384 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
385
386         [Qt] Don't overwrite LIBS_PRIVATE when sanitizing LIBS
387
388         Reviewed by Ossy.
389
390         * qmake/mkspecs/features/default_post.prf:
391
392 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
393
394         [EFL][DRT] Implement LayoutTestController::layerTreeAsText
395         https://bugs.webkit.org/show_bug.cgi?id=82294
396
397         Reviewed by Gyuyoung Kim.
398
399         Implement layerTreeAsText using the DumpRenderTreeSupportEfl method.
400
401         * DumpRenderTree/efl/TestRunnerEfl.cpp:
402         (TestRunner::layerTreeAsText):
403
404 2012-09-13  Zan Dobersek  <zandobersek@gmail.com>
405
406         [GTK] Clear application cache between tests in DumpRenderTree
407         https://bugs.webkit.org/show_bug.cgi?id=96543
408
409         Reviewed by Philippe Normand.
410
411         Call the new DumpRenderTreeSupportGtk method to clear application cache
412         after each test.
413
414         Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
415         as well. Currently it points to a subdirectory in the layout tests results
416         directory. At least on the builders this ensures an empty cache directory
417         with each test run.
418
419         * DumpRenderTree/gtk/DumpRenderTree.cpp:
420         (runTest):
421         * Scripts/webkitpy/layout_tests/port/gtk.py:
422         (GtkPort.setup_environ_for_server):
423
424 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
425
426         [Qt] Make sure LIBS, PKGCONFIG, and QT, do not affect QtWebKit's prl file
427
428         Unless it's actually a dependency of the public QtWebKit API.
429
430         We could replace every occurance of LIBS, PKGCONFIG, and QT, in the pri
431         files with their _PRIVATE equivivalent, but that's likely to break when
432         someone adds a new QT/LIBS/PKGCONFIG += foo line somewhere. Instead we
433         clean up the variables in default_post.
434
435         This means that the CONFIG -= explicitlib in linkAgainstLibrary() is no
436         longer needed, as it was a workaround for the intermediate libraries ending
437         up in the prl file. And, since CONFIG -= staticlib was there to support
438         the explicitlib option, we can remove that too (as well as the exception
439         for gprof, since it would be empty). If gprof needs tweaks to always link
440         statically they should go in gprof.prf.
441
442         Reviewed by Simon Hausmann.
443
444         * qmake/mkspecs/features/default_post.prf:
445         * qmake/mkspecs/features/functions.prf:
446
447 2012-09-13  Mario Sanchez Prada  <msanchez@igalia.com>
448
449         [GTK] "Infinite" loop in AccessibilityUIElementGtk.cpp
450         https://bugs.webkit.org/show_bug.cgi?id=96632
451
452         Reviewed by Carlos Garcia Campos.
453
454         Fix this by using atk_object_get_n_accessible_children instead of
455         calling getChildren() from childCount.
456
457         * WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp:
458         (WTR::AccessibilityUIElement::childrenCount): Avoid the infinite
459         loop by using atk_object_get_n_accessible_children().
460
461 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
462
463         [Qt][Win] Enable USE(3D_GRAPHICS)
464         https://bugs.webkit.org/show_bug.cgi?id=90879
465
466         Reviewed by Kenneth Rohde Christiansen.
467
468         Enable it on Windows as well as on QNX (bug fixed).
469
470         * qmake/mkspecs/features/features.prf:
471
472 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
473
474         [Qt] The ANGLE build on Windows breaks with GnuWin32's flex because it is too old
475         https://bugs.webkit.org/show_bug.cgi?id=96359
476
477         Reviewed by Tor Arne Vestbø.
478
479         GnuWin32's flex is 2.5.4 and that is too old for ANGLE's preprocessor
480         lexer. The only viable alternative I could find on Windows that provides
481         binaries is the winflexbison distribution (http://sourceforge.net/projects/winflexbison/),
482         so let's use that one instead.
483
484         * Scripts/webkitdirs.pm:
485         (checkRequiredSystemConfig):
486         * qmake/mkspecs/features/default_pre.prf:
487
488 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
489
490         [Qt] Add configuration for production builds
491         https://bugs.webkit.org/show_bug.cgi?id=96607
492
493         Reviewed by Kenneth Rohde Christiansen.
494
495         Add configuration tweaks for production builds, to ease memory pressure with the GNU toolchain
496         and enable all-in-one-files optimizations.
497
498         * qmake/mkspecs/features/production_build.prf: Added.
499
500 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
501
502         [Qt] GStreamer detection does not work when cross-compiling
503         https://bugs.webkit.org/show_bug.cgi?id=96608
504
505         Reviewed by Kenneth Rohde Christiansen.
506
507         When cross-compiling it is not safe to just use system(pkg-config),
508         because there is a high probability that it will find packages in the
509         host system instead of in the target one. Instead use qmake's new
510         packagesExist() function that takes care of this delicate aspect of
511         cross compilation by setting PKG_CONFIG_SYSROOT_DIR and
512         PKG_CONFIG_LIBDIR accordingly.
513
514         * qmake/mkspecs/features/features.prf:
515
516 2012-09-13  Christophe Dumez  <christophe.dumez@intel.com>
517
518         [WK2][WTR] More efficient string handling in InjectedBundlePage
519         https://bugs.webkit.org/show_bug.cgi?id=96609
520
521         Reviewed by Kenneth Rohde Christiansen.
522
523         Update StringBuilder usage in InjectedBundlePage to follow
524         the latest recommandations for efficient string handling:
525         http://trac.webkit.org/wiki/EfficientStrings
526
527         This involves using appendLiteral() or appendNumber()
528         instead of append() whenever possible.
529
530         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
531         (WTR::dumpPath):
532         (WTR::rangeToStr):
533         (WTR::styleDecToStr):
534         (WTR::frameToStr):
535         (WTR::dumpResourceURL):
536         (WTR):
537         (WTR::dumpFrameDescriptionSuitableForTestResult):
538         (WTR::dumpRequestDescriptionSuitableForTestResult):
539         (WTR::dumpResponseDescriptionSuitableForTestResult):
540         (WTR::dumpErrorDescriptionSuitableForTestResult):
541         (WTR::InjectedBundlePage::didReceiveIntentForFrame):
542         (WTR::InjectedBundlePage::registerIntentServiceForFrame):
543         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
544         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
545         (WTR::InjectedBundlePage::didCommitLoadForFrame):
546         (WTR::InjectedBundlePage::didFinishProgress):
547         (WTR::dumpFrameScrollPosition):
548         (WTR::dumpFrameText):
549         (WTR::dumpDescendantFramesText):
550         (WTR::InjectedBundlePage::didFinishLoadForFrame):
551         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
552         (WTR::InjectedBundlePage::didCancelClientRedirectForFrame):
553         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
554         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
555         (WTR::InjectedBundlePage::didHandleOnloadEventsForFrame):
556         (WTR::InjectedBundlePage::willSendRequestForFrame):
557         (WTR::InjectedBundlePage::didReceiveResponseForResource):
558         (WTR::InjectedBundlePage::didFinishLoadForResource):
559         (WTR::InjectedBundlePage::didFailLoadForResource):
560         (WTR::InjectedBundlePage::shouldCacheResponse):
561         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
562         (WTR::InjectedBundlePage::willAddMessageToConsole):
563         (WTR::InjectedBundlePage::willSetStatusbarText):
564         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
565         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
566         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
567         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
568         (WTR::InjectedBundlePage::shouldBeginEditing):
569         (WTR::InjectedBundlePage::shouldEndEditing):
570         (WTR::InjectedBundlePage::shouldInsertNode):
571         (WTR::InjectedBundlePage::shouldInsertText):
572         (WTR::InjectedBundlePage::shouldDeleteRange):
573         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
574         (WTR::InjectedBundlePage::shouldApplyStyle):
575         (WTR::InjectedBundlePage::didBeginEditing):
576         (WTR::InjectedBundlePage::didEndEditing):
577         (WTR::InjectedBundlePage::didChange):
578         (WTR::InjectedBundlePage::didChangeSelection):
579         (WTR::InjectedBundlePage::supportsFullScreen):
580         (WTR::InjectedBundlePage::enterFullScreenForElement):
581         (WTR::InjectedBundlePage::exitFullScreenForElement):
582         (WTR::InjectedBundlePage::beganEnterFullScreen):
583         (WTR::InjectedBundlePage::beganExitFullScreen):
584         (WTR::InjectedBundlePage::closeFullScreen):
585         (WTR::dumpBackForwardListItem):
586         (WTR::InjectedBundlePage::dumpBackForwardList):
587
588 2012-09-13  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
589
590         [Qt][WK2] Memory leaks in Qt's TestRunner
591         https://bugs.webkit.org/show_bug.cgi?id=96603
592
593         Reviewed by Csaba Osztrogonác.
594
595         Fix memory leaks in Qt's TestRunner code by adopting WKString
596         created with WKStringCreateWithUTF8CString().
597
598         * WebKitTestRunner/qt/TestControllerQt.cpp:
599         (WTR::TestController::initializeInjectedBundlePath):
600         (WTR::TestController::initializeTestPluginDirectory):
601
602 2012-09-13  Zan Dobersek  <zandobersek@gmail.com>
603
604         [GTK][NRWT] Lower timeout value to 6 seconds (12 for debug configuration)
605         https://bugs.webkit.org/show_bug.cgi?id=96506
606
607         Reviewed by Dirk Pranke.
608
609         Lower the timeout value to 6 seconds for release configuration and 12 seconds
610         for debug configuration. These are the same values the Chromium port uses.
611
612         Currently the value is lowered only for the DumpRenderTree, WebKitTestRunner (and
613         the layout tests under WebKit2 generally) requires more attention and gardening
614         than what the current effort produces.
615
616         The unit test is updated as well to test these changes.
617
618         * Scripts/webkitpy/layout_tests/port/gtk.py:
619         (GtkPort.default_timeout_ms):
620         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
621         (GtkPortTest.test_default_timeout_ms):
622         (GtkPortTest.assertLinesEqual):
623
624 2012-09-12  Csaba Osztrogonác  <ossy@webkit.org>
625
626         Add SVN mirror handling feature to build.webkit.org
627         https://bugs.webkit.org/show_bug.cgi?id=85887
628
629         Reviewed by Dirk Pranke.
630
631         * BuildSlaveSupport/build.webkit.org-config/config.json: Add SVN mirrors for Qt buildslaves hosted in Szeged.
632         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
633         (ConfigureBuild.__init__): Add SVNMirror property to be able to watch which slaves use which mirror on build.webkit.org.
634         (ConfigureBuild.start):
635         (CheckOutSource.__init__): Set baseURL to the SVNMirror or the default http://svn.webkit.org/repository/webkit/
636         (WaitForSVNServer): Add new buildstep for waiting the SVNMirror to be in sync with http://svn.webkit.org/repository/webkit/
637         (Factory.__init__):
638         (BuildFactory.__init__):
639         (TestFactory.__init__):
640         (BuildAndTestFactory.__init__):
641         (BuildAndPerfTestFactory.__init__):
642         (BuildAndPerfTestWebKit2Factory.__init__):
643         (DownloadAndPerfTestFactory.__init__):
644         (DownloadAndPerfTestWebKit2Factory.__init__):
645         (loadBuilderConfig): Use kwargs instead of args to be able to add the optional SVNMirror factory argument.
646         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
647         (SVNMirrorTest):
648         (SVNMirrorTest.setUp): Load config.json once at startup.
649         (SVNMirrorTest.get_SVNMirrorFromConfig): Get the SVNMirror from config.json for a given buildslave.
650         (SVNMirrorTest.test_CheckOutSource): Compare CheckOutSource.baseURL with SVNMirror in config.json for all builders
651         * BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py: Added.
652         (getLatestSVNRevision): Get the latest SVN revison from the given server.
653         (waitForSVNRevision): Wait until the given SVN revision is committed to the given server. It doesn't wait if the
654                               SVN revision is empty (force build triggered without revision) or the server is unavailable.
655
656 2012-09-12  Kangil Han  <kangil.han@samsung.com>
657
658         [WK2][WTR] Set waitUntilDone watchdog timer value equal to WK1.
659         https://bugs.webkit.org/show_bug.cgi?id=81606
660
661         Reviewed by Tim Horton.
662
663         6 seconds is harsh for some jquery test cases.
664         Therefore, adjust the value to match DumpRenderTree.
665
666         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
667         (WTR):
668
669 2012-09-12  KyungTae Kim  <ktf.kim@samsung.com>
670
671         [EFL] Support download attribute feature
672         https://bugs.webkit.org/show_bug.cgi?id=96462
673
674         Reviewed by Gyuyoung Kim.
675
676         Enable DOWNLOAD_ATTRIBUTE feature for EFL port,
677         and add "download,request" callback to the DumpRenderTree for EFL.
678
679         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
680         (DumpRenderTreeChrome::createView):
681         (DumpRenderTreeChrome::onDownloadRequest):
682         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
683         (DumpRenderTreeChrome):
684         * Scripts/webkitperl/FeatureList.pm:
685
686 2012-09-12  Stephanie Lewis  <slewis@apple.com>
687
688         Reduce parallism on the wk2 testers.
689         https://bugs.webkit.org/show_bug.cgi?id=95906
690
691         Reviewed by Dirk Pranke.
692
693         The wk2 testers on Mountain Lion are getting stuck and timing out.  The problem appears to be due to
694         resource contention.  Reducing the number of processes alleviates the issue.  
695
696         Starting by reducing 25%.
697
698         * Scripts/webkitpy/layout_tests/port/mac.py:
699         (MacPort.default_child_processes):
700
701 2012-09-12  Brady Eidson  <beidson@apple.com>
702
703         Assert in NetscapePlugin::destroy() with async plugin init
704         <rdar://problem/12277595> and https://bugs.webkit.org/show_bug.cgi?id=96576
705
706         Reviewed by Anders Carlsson.
707
708         Expose NPN_Invoke to plug-in tests:
709         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
710         (PluginTest::NPN_Invoke):
711         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
712         (PluginTest):
713
714         Add a test that uses NPN_Invoke on the window object from inside NPP_New to remove the plug-in element:
715         * DumpRenderTree/TestNetscapePlugIn/Tests/InvokeDestroysPluginWithinNPP_New.cpp: Added.
716         (InvokeDestroysPluginWithinNPP_New):
717         (InvokeDestroysPluginWithinNPP_New::InvokeDestroysPluginWithinNPP_New):
718         (InvokeDestroysPluginWithinNPP_New::NPP_New):
719         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
720
721 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
722
723         refactor TestExpectations tokenization slightly in preparation for the new syntax
724         https://bugs.webkit.org/show_bug.cgi?id=96564
725
726         Reviewed by Ojan Vafai.
727
728         This change changes how we will tokenize/lex the
729         TestExpectations files, in preparation for supporting both the
730         old syntax and the new one. This change by itself should be a
731         no-op.
732
733         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
734         (TestExpectationParser._tokenize_line):
735         (TestExpectationParser):
736         (TestExpectationParser._tokenize_line_using_old_format):
737         (TestExpectationParser._tokenize_line_using_new_format):
738
739 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
740
741         remove unused testexpectations editing code from webkitpy, garden-o-matic
742         https://bugs.webkit.org/show_bug.cgi?id=96562
743
744         Reviewed by Adam Barth.
745
746         This code was prototyped but never fully realized. Removing
747         until it reanimates :).
748
749         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
750         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
751         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py: Removed.
752         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py: Removed.
753         * Scripts/webkitpy/tool/servers/gardeningserver.py:
754         (BuildCoverageExtrapolator.extrapolate_test_configurations):
755         (GardeningHTTPRequestHandler._run_webkit_patch):
756         (GardeningHTTPRequestHandler.ping):
757         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
758         (BuildCoverageExtrapolatorTest.test_extrapolate):
759         (GardeningServerTest.test_rebaseline_new_port):
760
761 2012-09-12  Lucas Forschler  <lforschler@apple.com>
762
763         Remove unused bot, apple-xserve-1.
764         https://bugs.webkit.org/show_bug.cgi?id=96570
765         
766         Reviewed by Stephanie Lewis.
767
768         * BuildSlaveSupport/build.webkit.org-config/config.json:
769
770 2012-09-12  Xan Lopez  <xlopez@igalia.com>
771
772         [GTK] We attempt to rebase documentation even if it's not present
773         https://bugs.webkit.org/show_bug.cgi?id=96553
774
775         Reviewed by Martin Robinson.
776
777         Do not make the documentation rebase step fatal. This allows make
778         install to succeed when there's no documentation generated.
779
780         * gtk/generate-gtkdoc:
781
782 2012-09-12  Kenneth Rohde Christiansen  <kenneth@webkit.org>
783
784         Respect WEBKITOUTPUTDIR when running EFL tests
785         https://bugs.webkit.org/show_bug.cgi?id=96528
786
787         Reviewed by Dirk Pranke.
788
789         Expose user set WEBKITOUTPUTDIR to the web process.
790
791         * Scripts/webkitpy/layout_tests/port/driver.py:
792         (Driver._start): Add WEBKITOUTPUTDIR to the environment
793         of the web process and its potential jhbuild wrapper.
794
795 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
796
797         webkitdirs: fix uname version handling for cygwin
798         https://bugs.webkit.org/show_bug.cgi?id=96436
799
800         Reviewed by Jon Honeycutt.
801
802         Newer versions of cygwin embed an additional version string
803         inside parentheses, so you get "1.7.16(0.249/5/3)" instead of "1.7.16".
804         Update the code to handle that.
805
806         * Scripts/webkitdirs.pm:
807         (setupAppleWinEnv):
808
809 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
810
811         Regression(r128338): Broke Windows build
812         https://bugs.webkit.org/show_bug.cgi?id=96537
813
814         Unreviewed build fix.
815
816         Fix Apple-Win build by allocating array dynamically
817         since its size is not constant.
818
819         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
820         (WTR::stringArrayToJS):
821
822 2012-09-12  Alex Sakhartchouk  <alexst@chromium.org>
823
824         [chromium] Add a virtual test suite for fast/hidpi
825         https://bugs.webkit.org/show_bug.cgi?id=90192
826
827         Reviewed by Dirk Pranke.
828
829         Add a virtual test suite to make sure the pixel tests in fast/hidpi give the same result
830         on the hardware accelerated path as the software path.
831
832         * DumpRenderTree/chromium/WebPreferences.cpp:
833         (WebPreferences::applyTo):
834         * Scripts/webkitpy/layout_tests/port/chromium.py:
835         (ChromiumPort.virtual_test_suites):
836
837 2012-09-12  Adam Klein  <adamk@chromium.org>
838
839         [chromium] Add content_browsertests to the flakiness dashboard
840         https://bugs.webkit.org/show_bug.cgi?id=96535
841
842         Reviewed by Ojan Vafai.
843
844         * TestResultServer/static-dashboards/dashboard_base.js:
845
846 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
847
848         [WK2][WKTR] TestRunner needs to implement originsWithApplicationCache
849         https://bugs.webkit.org/show_bug.cgi?id=96496
850
851         Reviewed by Kenneth Rohde Christiansen.
852
853         Add implementation for originsWithApplicationCache to
854         WebKitTestRunner.
855
856         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
857         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
858         (WTR::stringArrayToJS):
859         (WTR):
860         (WTR::TestRunner::originsWithApplicationCache):
861         * WebKitTestRunner/InjectedBundle/TestRunner.h:
862         (TestRunner):
863
864 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
865
866         Fix Qt/Windows build with Python3
867         https://bugs.webkit.org/show_bug.cgi?id=96473
868
869         Reviewed by Csaba Osztrogonác.
870
871         In Python 3 print is a real function, so we must use parentheses around
872         the function parameters. This is backwards compatible with Python 2.
873
874         * Scripts/generate-win32-export-forwards:
875
876 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
877
878         Unreviewed trivial build fix for Qt/Windows after bug #96358.
879
880         As pointed out by Kevin, we should inject the "set PATH=..." statement
881         to add the GnuWin32 directory only if that directory actually exists.
882
883         * qmake/mkspecs/features/default_post.prf:
884
885 2012-09-12  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
886
887         [EFL] [WK2] Memory leaks in TestControllerEfl
888         https://bugs.webkit.org/show_bug.cgi?id=96525
889
890         Reviewed by Kenneth Rohde Christiansen.
891
892         Fix memory leaks in EFL's TestRunner code by adopting an allocation
893         of WKString created with WKStringCreateWithUTF8CString().
894
895         * WebKitTestRunner/efl/TestControllerEfl.cpp:
896         (WTR::TestController::initializeInjectedBundlePath):
897         (WTR::TestController::initializeTestPluginDirectory):
898
899 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
900
901         [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
902         https://bugs.webkit.org/show_bug.cgi?id=96374
903
904         Reviewed by Kenneth Rohde Christiansen.
905
906         Implement support for dumpApplicationCacheDelegateCallbacks
907         and disallowIncreaseForApplicationCacheQuota in
908         WebKitTestRunner and properly dump the information
909         expected by the tests.
910
911         If the application cache quota is reached for a given
912         security origin, WebKitTestRunner will reset the quota
913         to its default value, unless intructed not to via
914         disallowIncreaseForApplicationCacheQuota().
915
916         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
917         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
918         (WTR::InjectedBundlePage::InjectedBundlePage):
919         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
920         (WTR):
921         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
922         (InjectedBundlePage):
923         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
924         (WTR::TestRunner::TestRunner):
925         (WTR::TestRunner::disallowIncreaseForApplicationCacheQuota):
926         (WTR):
927         * WebKitTestRunner/InjectedBundle/TestRunner.h:
928         (WTR::TestRunner::dumpApplicationCacheDelegateCallbacks):
929         (TestRunner):
930         (WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota):
931         (WTR::TestRunner::shouldDumpApplicationCacheDelegateCallbacks):
932
933 2012-09-12  Jochen Eisinger  <jochen@chromium.org>
934
935         [chromium] remove deprecated and unused sets import from chromium_android driver
936         https://bugs.webkit.org/show_bug.cgi?id=96485
937
938         Reviewed by Dirk Pranke.
939
940         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
941
942 2012-09-12  Zan Dobersek  <zandobersek@gmail.com>
943
944         Flakiness dashboard doesn't recognize new Chromium Android test builder
945         https://bugs.webkit.org/show_bug.cgi?id=96523
946
947         Reviewed by Ojan Vafai.
948
949         Properly return 'ANDROID' as the Chromium platform for Android builders.
950
951         * TestResultServer/static-dashboards/flakiness_dashboard.js:
952         (chromiumPlatform):
953         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
954         (test):
955
956 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
957
958         [Qt] Build on Windows requires bison/flex in PATH
959         https://bugs.webkit.org/show_bug.cgi?id=96358
960
961         Reviewed by Tor Arne Vestbø.
962
963         The build requires flex, bison, etc. and they need to be in the PATH when building. On Mac OS X
964         and Linux that is rarely a problem given how easily available the tools are. On Windows however
965         a separate installation of various GNU tools is required as the operating system doesn't come with
966         them. To make the development more convenient, Qt 5 provides a copy of the most essential tools in
967         the gnuwin32 directory of the qt5.git top-level repository.
968
969         This patch tries to detect the presence of those tools and prepends them to the PATH if found.
970
971         This is required in preparation for the elimination of qt5/qtwebkit.pri, which currently expands
972         PATH before calling build-webkit. It it also required for the upcoming introduction of win_flex
973         as dependency over flex, which can be done with less hassle when qt5's gnuwin32 directory has been
974         updated with the new tool.
975
976         * Scripts/webkitdirs.pm:
977         (checkRequiredSystemConfig):
978         * qmake/mkspecs/features/default_post.prf:
979
980 2012-09-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
981
982         [Qt] Update build-jsc after r128174
983
984         Reviewed by Ossy.
985
986         * Scripts/build-jsc:
987
988 2012-09-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
989
990         [Qt] Teach addStrictSubdirOrderBetween to handle more than two targets
991
992         By hard-coding the names of the targets we defined we ended up just
993         redefining the previous target when using addStrictSubdirOrderBetween
994         more than once in a single project file.
995
996         We now embed the two base targets into the target names.
997
998         Reviewed by Simon Hausmann.
999
1000         * qmake/mkspecs/features/functions.prf:
1001
1002 2012-09-12  Philippe Liard  <pliard@google.com>
1003
1004         Depend on {base,net} GYP targets rather than {base,net}_java.
1005         https://bugs.webkit.org/show_bug.cgi?id=95690
1006
1007         Reviewed by Adam Barth.
1008
1009         {base,net}_java became 'private' targets on the Chromium side that
1010         clients should not depend on (see
1011         https://chromiumcodereview.appspot.com/10913083/).
1012         This removes a bunch of trailing white spaces additionally in
1013         TestWebkitAPI.gyp (which includes non-trailing white space changes).
1014
1015         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1016         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
1017
1018 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1019
1020         [Qt] Fix the build with ENABLE_NETSCAPE_PLUGIN_API=0
1021         https://bugs.webkit.org/show_bug.cgi?id=96494
1022
1023         Reviewed by Tor Arne Vestbø.
1024
1025         WK2's ENABLE_PLUGIN_PROCESS uses the NPAPI functions unconditionally, so disable the
1026         plugin process feature if we don't have NPAPI.
1027
1028         * qmake/mkspecs/features/features.prf:
1029
1030 2012-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1031
1032         Unreviewed, rolling out r128280.
1033         http://trac.webkit.org/changeset/128280
1034         https://bugs.webkit.org/show_bug.cgi?id=96498
1035
1036         it broke compilation on windows debug bot (Requested by loislo
1037         on #webkit).
1038
1039         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1040         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1041         (WTR::InjectedBundlePage::InjectedBundlePage):
1042         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1043         (InjectedBundlePage):
1044         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1045         (WTR::TestRunner::TestRunner):
1046         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1047         (TestRunner):
1048
1049 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1050
1051         [Qt] Make it possible to build with "make release" and "make debug" on Windows
1052         https://bugs.webkit.org/show_bug.cgi?id=96488
1053
1054         Reviewed by Tor Arne Vestbø.
1055
1056         A "make debug" is passed through recursively and currently it aborts at Makefile.DerivedSources
1057         because there are no such targets. We want the generated sources to be independent from release
1058         or debug build configurations, so it is sufficient to provide fake debug and release targets that
1059         redirect to the same general-purpose target (first) of creating the derived sources.
1060
1061         * qmake/mkspecs/features/default_post.prf:
1062
1063 2012-09-12  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1064
1065         [EFL] Make DumpRenderTree smarter at finding the fonts
1066         http://webkit.org/b/96281
1067
1068         Reviewed by Gyuyoung Kim.
1069
1070         Respect WEBKITOUTPUTDIR and expand the font dir from it.
1071         Use CString consistently.
1072
1073         * DumpRenderTree/efl/FontManagement.cpp:
1074         (buildPath):
1075         (getCoreFontFiles):
1076         (addFontDirectory):
1077         (addFontFiles):
1078         (getCustomBuildDir):
1079         (getPlatformFontsPath):
1080         (addFontsToEnvironment):
1081
1082 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
1083
1084         [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
1085         https://bugs.webkit.org/show_bug.cgi?id=96374
1086
1087         Reviewed by Kenneth Rohde Christiansen.
1088
1089         Implement support for dumpApplicationCacheDelegateCallbacks
1090         and disallowIncreaseForApplicationCacheQuota in
1091         WebKitTestRunner and properly dump the information
1092         expected by the tests.
1093
1094         If the application cache quota is reached for a given
1095         security origin, WebKitTestRunner will reset the quota
1096         to its default value, unless intructed not to via
1097         disallowIncreaseForApplicationCacheQuota().
1098
1099         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1100         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1101         (WTR::InjectedBundlePage::InjectedBundlePage):
1102         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
1103         (WTR):
1104         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1105         (InjectedBundlePage):
1106         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1107         (WTR::TestRunner::TestRunner):
1108         (WTR::TestRunner::disallowIncreaseForApplicationCacheQuota):
1109         (WTR):
1110         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1111         (WTR::TestRunner::dumpApplicationCacheDelegateCallbacks):
1112         (TestRunner):
1113         (WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota):
1114         (WTR::TestRunner::shouldDumpApplicationCacheDelegateCallbacks):
1115
1116 2012-09-12  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1117
1118         [WK2] [WTR] WebKitTestRunner needs TestRunner.workerThreadCount
1119         https://bugs.webkit.org/show_bug.cgi?id=96388
1120
1121         Reviewed by Kenneth Rohde Christiansen.
1122
1123         Exported TestRunner.workerThreadCount as readonly attribute.
1124
1125         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1126         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Added workerThreadCount() method implementation.
1127         (WTR::TestRunner::workerThreadCount): Returns count of worker threads.
1128         (WTR):
1129         * WebKitTestRunner/InjectedBundle/TestRunner.h: Added workerThreadCount() method. 
1130         (TestRunner):
1131
1132 2012-09-12  Jochen Eisinger  <jochen@chromium.org>
1133
1134         [chromium] Consume a user gesture when creating a new view.
1135         https://bugs.webkit.org/show_bug.cgi?id=96373
1136
1137         Reviewed by Adam Barth.
1138
1139         * DumpRenderTree/chromium/WebViewHost.cpp:
1140         (WebViewHost::createView):
1141
1142 2012-09-12  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1143
1144         [WK2][WTR] Some of TestRunner special options are not reset before testing
1145         https://bugs.webkit.org/show_bug.cgi?id=96384
1146
1147         Reviewed by Kenneth Rohde Christiansen.
1148
1149         Now values of the following special options are reset:
1150         void setAcceptsEditing(in boolean value);
1151         void setCloseRemainingWindowsWhenComplete(in boolean value);
1152         void setXSSAuditorEnabled(in boolean value);
1153         void setAllowFileAccessFromFileURLs(in boolean value);
1154         void setPluginsEnabled(in boolean value);
1155         void setPopupBlockingEnabled(in boolean value);
1156
1157         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1158         (WTR::InjectedBundle::beginTesting):
1159
1160 2012-09-11  Ryuan Choi  <ryuan.choi@samsung.com>
1161
1162         [CMAKE] Supply feature defines to CodeGeneratorTestRunner.
1163         https://bugs.webkit.org/show_bug.cgi?id=96273
1164
1165         Reviewed by Gyuyoung Kim.
1166
1167         Passed FEATURE_DEFINES_WITH_SPACE_SEPARATOR to CodeGeneratorTestRunner
1168         in order to distinguish compile time options such as ENABLE(TOUCH_EVENTS).
1169
1170         * WebKitTestRunner/CMakeLists.txt:
1171
1172 2012-09-11  Dirk Pranke  <dpranke@chromium.org>
1173
1174         [chromium] rename webkit_resources
1175         https://bugs.webkit.org/show_bug.cgi?id=95874
1176
1177         Reviewed by James Robinson.
1178
1179         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1180
1181 2012-09-11  Jochen Eisinger  <jochen@chromium.org>
1182
1183         [chromium] don't include content shell builders in the garden-o-matic view
1184         https://bugs.webkit.org/show_bug.cgi?id=96418
1185
1186         Reviewed by James Robinson.
1187
1188         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1189
1190 2012-09-11  Adam Klein  <adamk@chromium.org>
1191
1192         Garden-o-matic should ignore a wider variety of warnings in buildbot json
1193         https://bugs.webkit.org/show_bug.cgi?id=96411
1194
1195         Reviewed by Adam Barth.
1196
1197         Previously only the exact string "warning" was treated as a warning
1198         result. This patch treats any string with "warning" as a substring
1199         as a warning (e.g., "warnings", as seen on the cr-win buildbots).
1200
1201         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
1202         (.):
1203         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
1204
1205 2012-09-11  Marcelo Lira  <marcelo.lira@openbossa.org>
1206
1207         Restore original value of mock scrollbars enabled in InternalSettings
1208         https://bugs.webkit.org/show_bug.cgi?id=87680
1209
1210         Reviewed by Adam Barth.
1211
1212         Added backup support for mock scrollbars state in
1213         InternalSettings::Backup, and removed support for these
1214         from Qt's DumpRenderTree.
1215
1216         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1217         (WebCore::WebPage::resetSettings):
1218         * DumpRenderTree/qt/TestRunnerQt.cpp:
1219         (TestRunner::setFrameFlatteningEnabled):
1220         * DumpRenderTree/qt/TestRunnerQt.h:
1221         (TestRunner):
1222
1223 2012-09-11  Dan Bernstein  <mitz@apple.com>
1224
1225         Fixed a bug where kill-old-processes failed to kill clang++.
1226
1227         Rubber-stamped by Alexey Proskuryakov.
1228
1229         * BuildSlaveSupport/kill-old-processes: Escape the + signs in "clang++"
1230         where it is passed as a regular expression to killall.
1231
1232 2012-09-11  Philippe Liard  <pliard@google.com>
1233
1234         Make sure that md5sum is not setup on non-Chromium Android platforms.
1235         https://bugs.webkit.org/show_bug.cgi?id=96393
1236
1237         Reviewed by Adam Barth.
1238
1239         Previously md5sum was setup in ChromiumAndroidDriver's constructor
1240         which is also invoked on non-Chromium Android platforms. The following patch
1241         moves this logic to _startup_test() which is guaranteed to be invoked
1242         only on Android.
1243
1244         This also updates the prompt unit test in chromium_android_unittest.py.
1245
1246         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1247         (ChromiumAndroidDriver.__init__):
1248         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
1249         (ChromiumAndroidDriver._setup_test):
1250
1251 2012-09-11  Raphael Kubo da Costa  <rakuco@webkit.org>
1252
1253         [EFL] Rewrite the EFL-related Find modules
1254         https://bugs.webkit.org/show_bug.cgi?id=95237
1255
1256         Reviewed by Kenneth Rohde Christiansen.
1257
1258         * DumpRenderTree/efl/CMakeLists.txt: Stop setting the LINK_FLAGS
1259         property and include all the Enlightenment Foundation Libraries
1260         required by the target.
1261         * EWebLauncher/CMakeLists.txt: Ditto.
1262         * MiniBrowser/efl/CMakeLists.txt: Ditto.
1263         * TestWebKitAPI/PlatformEfl.cmake: Add missing include directories
1264         now that they are not added implicitly.
1265         * WebKitTestRunner/CMakeLists.txt: Stop setting the LINK_FLAGS
1266         property.
1267         * WebKitTestRunner/PlatformEfl.cmake: Stop setting the LINK_FLAGS
1268         property and include all the Enlightenment Foundation Libraries
1269         required by the target.
1270
1271 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
1272
1273         [WK2][WKTR] TestRunner needs to implement setApplicationCacheOriginQuota
1274         https://bugs.webkit.org/show_bug.cgi?id=96379
1275
1276         Reviewed by Kenneth Rohde Christiansen.
1277
1278         Add implementation for setApplicationCacheOriginQuota
1279         to WebKitTestRunner.
1280
1281         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1282         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1283         (WTR::TestRunner::setApplicationCacheOriginQuota):
1284         (WTR):
1285         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1286         (TestRunner):
1287
1288 2012-09-11  Luciano Wolf  <luciano.wolf@openbossa.org>
1289
1290         [Qt] [WK2] editing/inserting/typing-tab-designmode tests are failing
1291         https://bugs.webkit.org/show_bug.cgi?id=91988
1292
1293         Reviewed by Kenneth Rohde Christiansen.
1294
1295         Regular key events generated by Qt for the tab key fill both
1296         keyCode and keyText, so we should do the same for our fake events.
1297
1298         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
1299         (WTR::EventSenderProxy::keyDown):
1300
1301 2012-09-11  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1302
1303         [WK2][WTR] WebKitTestRunner needs testRunner.setSpatialNavigationEnabled
1304         https://bugs.webkit.org/show_bug.cgi?id=96269
1305
1306         Reviewed by Kenneth Rohde Christiansen.
1307
1308         Exported missing testRunner.setSpatialNavigationEnabled() method.
1309
1310         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1311         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1312         (WTR::InjectedBundle::beginTesting):
1313         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1314         (WTR::TestRunner::setSpatialNavigationEnabled):
1315         (WTR):
1316         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1317         (TestRunner):
1318
1319 2012-09-11  Philippe Liard  <pliard@chromium.org>
1320
1321         Support LayoutTests on non-rooted devices for Chromium Android.
1322         https://bugs.webkit.org/show_bug.cgi?id=95346
1323
1324         Reviewed by Dirk Pranke.
1325
1326         We were requiring root permissions to sync resource files with the
1327         device by comparing host and device files' timestamp after we
1328         synchronized the device and host clocks.
1329         We now rely on md5sum provided by Chromium to handle data files
1330         synchronization.
1331
1332         * Scripts/webkitpy/layout_tests/port/chromium.py:
1333         (ChromiumPort._check_driver_build_up_to_date):
1334         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1335         (ChromiumAndroidDriver.__init__):
1336         (ChromiumAndroidDriver._setup_test):
1337         (ChromiumAndroidDriver._push_executable):
1338         (ChromiumAndroidDriver._push_test_resources):
1339         (ChromiumAndroidDriver._read_prompt):
1340
1341 2012-09-11  Simon Hausmann  <simon.hausmann@nokia.com>
1342
1343         [Qt] Fix output paths on Windows
1344
1345         Reviewed by Tor Arne Vestbø.
1346
1347         BUILD_ROOT_RELATIVE_TO_OUT_PWD was calculated incorrectly Windows, resulting in an incorrect
1348         DESTDIR transformation at the end of default_post.prf. The calculation should be baased no qmake
1349         paths, which can use drive letters but always use forward slashes. So the use of QMAKE_DIR_SEP is
1350         incorrect here and instead for the calculation we should use forward slashes.
1351
1352         * qmake/mkspecs/features/default_pre.prf:
1353
1354 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1355
1356         [Qt] Fix passing of defines from the build system
1357
1358         We explicitly have to pass -DENABLE_FOO=0 for every single feature
1359         that's not explicitly enabled in WEBKIT_CONFIG, since Platform.h
1360         will add it's own defaults if the features are not defined.
1361
1362         At some point we might want to run a configure-test to inspect what
1363         Platform.h will do, so we can sync up the build system's view of
1364         the feature-defines with the compile-time situation.
1365
1366         Reviewed by Simon Hausmann.
1367
1368         * qmake/mkspecs/features/functions.prf:
1369
1370 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1371
1372         [Qt] Fix --qt option to build-webkit
1373
1374         Reviewed by Ossy.
1375
1376         * Scripts/webkitdirs.pm:
1377         (buildQMakeProjects):
1378
1379 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1380
1381         [Qt] Add a configure step to the Qt build system
1382
1383         This allows building the Qt port using just 'qmake WebKit.pro'. Using
1384         the build-webkit script is still supported, and will add slightly more
1385         logic to the build, such as detecting the need for clean or incremental
1386         builds.
1387
1388         Internally, the build system now uses a new variable, WEBKIT_CONFIG, for
1389         all things related to configuring the build, such as use/have/enable flags,
1390         and these are translated to defines in default_post. Project files should
1391         no longer check contains(DEFINES,...) to detect features, but use the new
1392         enable?(), use?(), and have?() functions. The no_webkit1 and no_webkit2
1393         options have been translated into WEBKIT_CONFIG options as well, and can
1394         be checked using build?().
1395
1396         Reviewed by Simon Hausmann.
1397
1398         * DumpRenderTree/qt/DumpRenderTree.pro:
1399         * MiniBrowser/qt/MiniBrowser.pro:
1400         * QtTestBrowser/QtTestBrowser.pro:
1401         * Scripts/build-webkit:
1402         * Scripts/webkitdirs.pm:
1403         (qtFeatureDefaults):
1404         (buildQMakeProjects):
1405         * Tools.pro:
1406         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
1407         * WebKitTestRunner/InjectedBundle/Target.pri:
1408         * WebKitTestRunner/Target.pri:
1409         * qmake/.qmake.cache: Added.
1410         * qmake/configure.pri: Removed.
1411         * qmake/configure.pro: Removed.
1412         * qmake/dump-features: Added.
1413         * qmake/mkspecs/features/configure.prf: Added.
1414         * qmake/mkspecs/features/default_post.prf:
1415         * qmake/mkspecs/features/default_pre.prf:
1416         * qmake/mkspecs/features/features.prf:
1417         * qmake/mkspecs/features/features.pri:
1418         * qmake/mkspecs/features/functions.prf:
1419         * qmake/mkspecs/features/gprof.prf:
1420         * qmake/mkspecs/features/mac/default_pre.prf:
1421         * qmake/mkspecs/features/win32/default_pre.prf:
1422
1423 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
1424
1425         [WK2][WKTR] TestRunner needs to implement clearApplicationCacheForOrigin
1426         https://bugs.webkit.org/show_bug.cgi?id=96372
1427
1428         Reviewed by Kenneth Rohde Christiansen.
1429
1430         Implement clearApplicationCacheForOrigin() in WebKitTestRunner.
1431
1432         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1433         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1434         (WTR::TestRunner::clearApplicationCacheForOrigin):
1435         (WTR):
1436         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1437         (TestRunner):
1438
1439 2012-09-11  Peter Beverloo  <peter@chromium.org>
1440
1441         Don't ignore .pak files when making an archive for Android
1442         https://bugs.webkit.org/show_bug.cgi?id=96375
1443
1444         Reviewed by Jochen Eisinger.
1445
1446         The .pak files do need to be pushed to the device, which is currently
1447         preventing the layout test runner from correctly pushing all files.
1448
1449         * BuildSlaveSupport/built-product-archive:
1450         (archiveBuiltProduct):
1451
1452 2012-09-11  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1453
1454         [WK2][WTR] WebKitTestRunner needs layoutTestController.setMinimumTimerInterval
1455         https://bugs.webkit.org/show_bug.cgi?id=96256
1456
1457         Reviewed by Kenneth Rohde Christiansen.
1458
1459         Exported TestRunner::setMinimumTimerInterval() method.
1460
1461         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1462         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1463         (WTR::InjectedBundle::beginTesting):
1464         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1465         (WTR::TestRunner::setMinimumTimerInterval):
1466         (WTR):
1467         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1468         (TestRunner):
1469
1470 2012-09-11  Tommy Widenflycht  <tommyw@google.com>
1471
1472         MediaStream API: add RTCPeerConnection::onnegotiationneeded
1473         https://bugs.webkit.org/show_bug.cgi?id=96097
1474
1475         Reviewed by Adam Barth.
1476
1477         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1478         (MockWebRTCPeerConnectionHandler::addStream):
1479         (MockWebRTCPeerConnectionHandler::removeStream):
1480
1481 2012-09-11  Peter Beverloo  <peter@chromium.org>
1482
1483         Recognize the "--chromium-android" argument in run-webkit-tests
1484         https://bugs.webkit.org/show_bug.cgi?id=96369
1485
1486         Reviewed by Jochen Eisinger.
1487
1488         Chromium for the Android platform cannot determine the platform based on
1489         the host itself, so we'll use the --chromium-android argument as the build
1490         master passes to run-webkit-tests. Make sure the layout test runner
1491         can pick the right port when doing so.
1492
1493         * Scripts/run-webkit-tests:
1494         * Scripts/webkitpy/layout_tests/port/factory.py:
1495         (port_options):
1496
1497 2012-09-11  Simon Hausmann  <simon.hausmann@nokia.com>
1498
1499         [QT] Fix build with newer qmake from Qt 5
1500
1501         Rubber-stamped by Tor Arne Vestbø.
1502
1503         Support for "qmake -query QMAKE_MKSPECS" was removed from qmake. Replace
1504         it with the use of QT_HOST_DATA/mkspecs.
1505         Based on patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com>.
1506
1507         * Scripts/webkitdirs.pm:
1508         (builtDylibPathForName):
1509         (qtMakeCommand):
1510
1511 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1512
1513         [Qt] Remove Qt 4 syncqt, no longer needed
1514
1515         Reviewed by Simon Hausmann.
1516
1517         * qmake/syncqt-4.8: Removed.
1518
1519 2012-09-11  Andras Becsi  <andras.becsi@nokia.com>
1520
1521         [Qt][WK2] Fix the build with recent Qt5
1522         https://bugs.webkit.org/show_bug.cgi?id=96283
1523
1524         Reviewed by Simon Hausmann.
1525
1526         We should not use deprecated Qt API because doing that results
1527         in build failure since all the deprecated API was disabled
1528         in qtbase (https://codereview.qt-project.org/#change,24890).
1529
1530         * DumpRenderTree/qt/main.cpp:
1531         (main):
1532         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1533         (MiniBrowserApplication::notify):
1534         * MiniBrowser/qt/raw/View.cpp:
1535         (View::exposeEvent):
1536         (main):
1537
1538 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
1539
1540         WTR needs an implementation of applicationCacheDiskUsageForOrigin
1541         https://bugs.webkit.org/show_bug.cgi?id=87188
1542
1543         Reviewed by Kenneth Rohde Christiansen.
1544
1545         Add implementation for applicationCacheDiskUsageForOrigin()
1546         in WebKitTestRunner.
1547
1548         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1549         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1550         (WTR::TestRunner::applicationCacheDiskUsageForOrigin):
1551         (WTR):
1552         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1553         (TestRunner):
1554
1555 2012-09-10  Joanmarie Diggs  <jdiggs@igalia.com>
1556
1557         Properly expose <legend> elements to ATs
1558         https://bugs.webkit.org/show_bug.cgi?id=84137
1559
1560         Reviewed by Chris Fleizach.
1561
1562         Created a new WebCore Accessibility Role, LegendRole. Used it to map to
1563         the expected platform role, ATK_ROLE_LABEL. Also established the needed
1564         AtkRelation pair, label-for/labelled-by between the legend and fieldset.
1565
1566         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
1567         (roleToString): added "Legend" string for WebAccessibilityRoleLegend
1568
1569 2012-09-10  Jer Noble  <jer.noble@apple.com>
1570
1571         Unreviewed; rolling out r128081.
1572         http://trac.webkit.org/changeset/128081
1573         https://bugs.webkit.org/show_bug.cgi?id=96134
1574
1575         New test http/tests/media/video-donottrack.html fails to run on Apple test bots.
1576
1577         * DumpRenderTree/TestRunner.cpp:
1578         (TestRunner::TestRunner):
1579         (TestRunner::staticFunctions):
1580         * DumpRenderTree/TestRunner.h:
1581         (TestRunner):
1582         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1583         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1584         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1585         (WTR::InjectedBundlePage::InjectedBundlePage):
1586         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1587         (InjectedBundlePage):
1588         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1589         (WTR::TestRunner::TestRunner):
1590         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1591         (TestRunner):
1592
1593 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
1594
1595         TestExpectationsChecker._determine_port_from_expectations_path() does not support cascaded TestExpectations
1596         https://bugs.webkit.org/show_bug.cgi?id=96205
1597
1598         Reviewed by Tony Chang.
1599
1600         _determine_port_from_expectations_path() was calling port.path_to_test_expectations_file()
1601         internally, which means that it would support only 1 TestExpectations file per port. This
1602         is an issue for ports such as EFL that support cascased TestExpectations (efl-wk2 -> efl
1603         and efl-wk1 -> efl).
1604
1605         This patch makes _determine_port_from_expectations_path() call port.expectations_files()
1606         instead so that all the ports TestExpectations are recognized. The ports are also
1607         constructed twice, with "webkit_test_runner" option set to True and False so that we
1608         retrieve the TestExpectations paths for both WebKit1 and WebKit2.
1609
1610         * Scripts/webkitpy/style/checkers/test_expectations.py:
1611         (TestExpectationsChecker._determine_port_from_expectations_path):
1612         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Add corresponding unit test.
1613         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
1614
1615 2012-09-10  Ryuan Choi  <ryuan.choi@samsung.com>
1616
1617         [WTR] Generated source files should include config.h
1618         https://bugs.webkit.org/show_bug.cgi?id=96254
1619
1620         Reviewed by Benjamin Poulain.
1621
1622         Current coding style has encouraged to include config.h at the first position,
1623         But derived sources, generated by CodeGeneratorTestRunner.pm, don't follow
1624         this rule.
1625         Therefore, this patch added it.
1626
1627         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1628         (_generateImplementationFile):
1629
1630 2012-09-10  Rick Byers  <rbyers@chromium.org>
1631
1632         Add handling of new GestureTapCancel in DRT
1633         
1634         https://bugs.webkit.org/show_bug.cgi?id=96183
1635
1636         Reviewed by Adam Barth.
1637
1638         * DumpRenderTree/chromium/TestWebPlugin.cpp:
1639         (TestWebPlugin::handleInputEvent):
1640
1641 2012-09-10  Brady Eidson  <beidson@apple.com>
1642
1643         Javascript in foreground tabs should not wait synchronously for plug-ins to load
1644         <rdar://problem/12067415> and https://bugs.webkit.org/show_bug.cgi?id=96167
1645
1646         Reviewed by Geoff Garen.
1647
1648         Enhance the "Slow NPP_New" plug-in to also be able to return properties to javascript.
1649
1650         * DumpRenderTree/TestNetscapePlugIn/Tests/SlowNPPNew.cpp:
1651         (PluginObject):
1652         (SlowNPPNew::PluginObject::PluginObject):
1653         (SlowNPPNew::PluginObject::~PluginObject):
1654         (SlowNPPNew::PluginObject::hasProperty):
1655         (SlowNPPNew::PluginObject::getProperty):
1656         (SlowNPPNew::NPP_GetValue):
1657         (SlowNPPNew):
1658
1659 2012-09-10  Tim Horton  <timothy_horton@apple.com>
1660
1661         WKTR often reports an unresponsive WebProcess on Mac bots
1662         https://bugs.webkit.org/show_bug.cgi?id=95906
1663
1664         Reviewed by Dan Bernstein.
1665
1666         Attempt to work around resource contention issues by increasing the NRWT
1667         timeout when running against WKTR, as well as WKTR's own WebProcess timeout.
1668
1669         * Scripts/webkitpy/layout_tests/port/base.py:
1670         (Port.default_timeout_ms): Default timeout when using WKTR -> 80 seconds.
1671         * WebKitTestRunner/TestController.cpp:
1672         (WTR): LongTimeout (used when waiting for WebProcess to finish) -> 60 seconds.
1673
1674 2012-09-07  Jer Noble  <jer.noble@apple.com>
1675
1676         <audio> and <video> should send Do Not Track when appropriate
1677         https://bugs.webkit.org/show_bug.cgi?id=96134
1678
1679         Reviewed by Eric Carlson.
1680
1681         Add a testRunner JS API for calling setShouldSendDoNotTrackHTTPHeader to DRT and 
1682         WTR. Add FrameLoaderClient client methods for retrieving that value.
1683
1684         * DumpRenderTree/TestRunner.cpp:
1685         (setShouldSendDoNotTrackHTTPHeaderCallback): Pass through to the TestRunner.
1686         (TestRunner::staticFunctions): Add the setShouldSendDoNotTrackHTTPHeader function.
1687         * DumpRenderTree/TestRunner.h:
1688         (TestRunner::setShouldSendDoNotTrackHTTPHeader): Simple setter.
1689         (TestRunner::shouldSendDoNotTrackHTTPHeader): Simple getter.
1690         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1691         (-[FrameLoadDelegate webViewShouldSendDoNotTrackHTTPHeader:]): 
1692             Pass the question on to the TestRunner.
1693         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1694         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1695         (WTR::InjectedBundlePage::InjectedBundlePage):
1696             Add the setShouldSendDoNotTrackHTTPHeader client function.
1697         (WTR::InjectedBundlePage::shouldSendDoNotTrackHTTPHeader):
1698             Pass the question on to the TestRunner.
1699         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1700         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1701         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1702         (WTR::TestRunner::shouldSendDoNotTrackHTTPHeader): Simple getter.
1703         (WTR::TestRunner::setShouldSendDoNotTrackHTTPHeader): Simple Setter.
1704
1705 2012-09-10  Ojan Vafai  <ojan@chromium.org>
1706
1707         Make EFL bots work on the flakiness dashboard
1708         https://bugs.webkit.org/show_bug.cgi?id=96164
1709
1710         Reviewed by Tony Chang.
1711
1712         Also, update outdated unittests that had started failing.
1713
1714         * TestResultServer/static-dashboards/builders.js:
1715         (isWebkitTestRunner):
1716         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1717         (nonChromiumPlatform):
1718         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1719         (test):
1720
1721 2012-09-10  Tommy Widenflycht  <tommyw@google.com>
1722
1723         [chromium] MediaStream API: Remove the Descriptor postfix
1724         https://bugs.webkit.org/show_bug.cgi?id=96268
1725
1726         Reviewed by Adam Barth.
1727
1728         After consideration I realized that there is no need whatsoever in using the Descriptor prefix
1729         in the WekKit embedder API. Removed from WebRTCSessionDescription and WebRTCICECandidate to start with.
1730
1731         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1732         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
1733         (MockWebRTCPeerConnectionHandler::createOffer):
1734         (MockWebRTCPeerConnectionHandler::createAnswer):
1735         (MockWebRTCPeerConnectionHandler::setLocalDescription):
1736         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
1737         (MockWebRTCPeerConnectionHandler::localDescription):
1738         (MockWebRTCPeerConnectionHandler::remoteDescription):
1739         (MockWebRTCPeerConnectionHandler::addICECandidate):
1740         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
1741         (MockWebRTCPeerConnectionHandler):
1742
1743 2012-09-10  Arnaud Renevier  <a.renevier@sisa.samsung.com>
1744
1745         [Gtk] failure to build jhbuild dependencies with cups 1.6
1746         https://bugs.webkit.org/show_bug.cgi?id=95991
1747
1748         Reviewed by Gustavo Noronha Silva.
1749
1750         Bump gtk+ and gnome-themes-standard dependencies to 3.4.2 to allow
1751         building with cups >= 1.6 [GNOME #670373].
1752
1753         * gtk/jhbuild.modules:
1754
1755 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
1756
1757         [EFL][DRT] Encoding issue in printed console messages
1758         https://bugs.webkit.org/show_bug.cgi?id=96263
1759
1760         Reviewed by Kenneth Rohde Christiansen.
1761
1762         Correctly handle CONSOLE messages that contain non-ascii
1763         characters in EFL's DRT. We need to use String::fromUTF8()
1764         to construct a WTF::String from a raw string.
1765
1766         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1767         (onConsoleMessage):
1768
1769 2012-09-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1770
1771         [WK2][WTR] User style sheet location should be reset before each test
1772         https://bugs.webkit.org/show_bug.cgi?id=96262
1773
1774         Reviewed by Kenneth Rohde Christiansen.
1775
1776         User style sheet location is reset before each test now.
1777
1778         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1779         (WTR::InjectedBundle::beginTesting):
1780
1781 2012-09-10  Simon Hausmann  <simon.hausmann@nokia.com>
1782
1783         Fix build of WTR with Qt on Windows
1784         https://bugs.webkit.org/show_bug.cgi?id=96249
1785
1786         Reviewed by Kenneth Rohde Christiansen.
1787
1788         Windows loves to define min and max as macros, which beautifully
1789         clashes in many places where min and max are used as variable or method
1790         names. It can be convinced not to do this when min and max are already
1791         define as macros (expanding to themselves). We have this kind of
1792         workaround in config.h files all over WebKit and as it turns out when
1793         building WTR with Qt on Windows we do end up with such a clash. Therefore
1794         we need the same workaround.
1795
1796         * WebKitTestRunner/config.h:
1797
1798 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
1799
1800         [WK2] New fast/forms/number/number-interactive-validation-required.html fails
1801         https://bugs.webkit.org/show_bug.cgi?id=95936
1802
1803         Reviewed by Kenneth Rohde Christiansen.
1804
1805         Enable interactive form validation setting in WebKitTestRunner as
1806         we are currently doing in DumpRenderTree. This is needed for some
1807         tests to pass.
1808
1809         * WebKitTestRunner/TestController.cpp:
1810         (WTR::TestController::resetStateToConsistentValues):
1811
1812 2012-09-09  Zan Dobersek  <zandobersek@gmail.com>
1813
1814         Clean up the code in XvfbDriver
1815         https://bugs.webkit.org/show_bug.cgi?id=96202
1816
1817         Reviewed by Philippe Normand.
1818
1819         Changes:
1820         - Remove unneeded imports,
1821         - assign the _lock_file member variable when the display number is determined,
1822         - no need for parentheses around a single string format argument,
1823         - use FileSystem.exists method when checking if lock file is present as it
1824         makes the intention much more clearer.
1825
1826         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
1827         (XvfbDriver._start):
1828         (XvfbDriver.stop):
1829
1830 2012-09-09  Patrick Gansterer  <paroga@webkit.org>
1831
1832         Make the String initialization on the function side of String::number()
1833         https://bugs.webkit.org/show_bug.cgi?id=95940
1834
1835         Reviewed by Benjamin Poulain.
1836
1837         * TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp:
1838         (testBoundaries):
1839         (testNumbers):
1840
1841 2012-09-09  Pierre Rossi  <pierre.rossi@gmail.com>
1842
1843         [WK2] expose element rect for color input type
1844         https://bugs.webkit.org/show_bug.cgi?id=91664
1845
1846         Reviewed by Simon Hausmann.
1847
1848         Update the QML logic in MiniBrowser to take advantage of this.
1849         The picker size is now hardcoded and we try to place it below the
1850         input element if possible.
1851
1852         * MiniBrowser/qt/qml/ColorChooser.qml:
1853
1854 2012-09-08  Christophe Dumez  <christophe.dumez@intel.com>
1855
1856         [WK2] New fast/events/tab-focus-link-in-canvas fails from r126908
1857         https://bugs.webkit.org/show_bug.cgi?id=95329
1858
1859         Reviewed by Kenneth Rohde Christiansen.
1860
1861         Explicitely disable TabToLinks setting in WebKitTestRunner.
1862         Tests override the "WebKitTabToLinksPreferenceKey" preference
1863         to enable it.
1864
1865         * WebKitTestRunner/TestController.cpp:
1866         (WTR::TestController::resetStateToConsistentValues):
1867
1868 2012-09-08  Kenichi Ishibashi  <bashi@chromium.org>
1869
1870         webkit.py gdb pretty printer can't print CString
1871         https://bugs.webkit.org/show_bug.cgi?id=96068
1872
1873         Reviewed by Tony Chang.
1874
1875         Update WTFCStringPrinter to follow r126191.
1876
1877         * gdb/webkit.py:
1878         (WTFCStringPrinter.to_string):
1879
1880 2012-09-07  Benjamin Poulain  <bpoulain@apple.com>
1881
1882         Rename the ustring() accessor to string()
1883         https://bugs.webkit.org/show_bug.cgi?id=95919
1884
1885         Reviewed by Geoffrey Garen.
1886
1887         Update EFL's DRT.
1888
1889         Fix some string conversion that have been made useless
1890         with recent changes.
1891
1892         * DumpRenderTree/efl/EventSender.cpp:
1893         (keyPadNameFromJSValue):
1894         (keyNameFromJSValue):
1895         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1896         (TestRunner::queueLoad):
1897         (TestRunner::addOriginAccessWhitelistEntry):
1898         (TestRunner::removeOriginAccessWhitelistEntry):
1899         (TestRunner::setUserStyleSheetLocation):
1900         (TestRunner::setValueForUser):
1901         (TestRunner::elementDoesAutoCompleteForElementWithId):
1902         (TestRunner::execCommand):
1903         (TestRunner::findString):
1904         (TestRunner::isCommandEnabled):
1905         (TestRunner::clearApplicationCacheForOrigin):
1906         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
1907         (TestRunner::pauseAnimationAtTimeOnElementWithId):
1908         (TestRunner::pauseTransitionAtTimeOnElementWithId):
1909         (toInt):
1910         (TestRunner::overridePreference):
1911         (TestRunner::addUserScript):
1912         (TestRunner::addUserStyleSheet):
1913         (TestRunner::evaluateInWebInspector):
1914         (TestRunner::evaluateScriptInIsolatedWorld):
1915         (TestRunner::setTextDirection):
1916         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
1917         (LoadItem::invoke):
1918         (LoadHTMLStringItem::invoke):
1919         (ScriptItem::invoke):
1920
1921 2012-09-06  Jeffrey Pfau  <jpfau@apple.com>
1922
1923         Extend third-party storage blocking API to optionally allow blocking all storage
1924         https://bugs.webkit.org/show_bug.cgi?id=95915
1925
1926         Reviewed by Brady Eidson.
1927
1928         Modified API test to use new revised API.
1929
1930         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1931         (TestWebKitAPI::TEST):
1932
1933 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
1934
1935         AX: WebCore accessibility roles should be cross-platform
1936         https://bugs.webkit.org/show_bug.cgi?id=94870
1937
1938         Reviewed by Chris Fleizach.
1939
1940         Add debug strings to Chromium for new accessibility roles.
1941
1942         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
1943         (roleToString):
1944
1945 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
1946
1947         AX: Chromium needs access to canvasHasFallbackContent
1948         https://bugs.webkit.org/show_bug.cgi?id=96124
1949
1950         Reviewed by Chris Fleizach.
1951
1952         Distinguish between canvas roles with and without fallback
1953         content on Chromium.
1954
1955         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
1956         (getRole):
1957
1958 2012-09-07  Ojan Vafai  <ojan@chromium.org>
1959
1960         Handle non-existant TestExpectations files gracefully
1961         https://bugs.webkit.org/show_bug.cgi?id=96149
1962
1963         Reviewed by Eric Seidel.
1964
1965         Even when we get rid of Skipped files, we shouldn't have each port
1966         require a TestExpectations file for each platform if it doesn't
1967         need one.
1968
1969         * Scripts/webkitpy/layout_tests/port/base.py:
1970         (Port.expectations_dict):
1971         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1972         (PortTest.test_nonexistant_expectations):
1973
1974 2012-09-07  Tony Chang  <tony@chromium.org>
1975
1976         Regression: check-webkit-style no longer checks TestExpectations for syntax errors
1977         https://bugs.webkit.org/show_bug.cgi?id=96136
1978
1979         Reviewed by Ojan Vafai.
1980
1981         When we renamed the file to TestExpectations, it was no longer considered a text file so
1982         it was no longer being checked. Since then, test_expectations_overrides() has been removed
1983         from the port object, so I've removed that from the check. I'm not sure what it was
1984         supposed to do.
1985
1986         * Scripts/webkitpy/style/checker.py:
1987         (CheckerDispatcher._file_type): Mark TestExpectations as a text file.
1988         * Scripts/webkitpy/style/checkers/test_expectations.py:
1989         (TestExpectationsChecker.check_test_expectations): Remove overrides param.
1990         (TestExpectationsChecker.check): Remove overrides param.
1991         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1992         (TestExpectationsTestCase.assert_lines_lint): Remove overrides param.
1993
1994 2012-09-07  Christophe Dumez  <christophe.dumez@intel.com>
1995
1996         [EFL] Use same default minimum logical font size in DRT and WTR
1997         https://bugs.webkit.org/show_bug.cgi?id=96116
1998
1999         Reviewed by Martin Robinson.
2000
2001         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2002         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Set minimum
2003         logical font size to 9 to match the value used in WTR.
2004         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2005         (WTR::InjectedBundle::beginTesting): Explicitly set the minimum
2006         logical font size to 9 (default value in WK2)
2007
2008 2012-09-07  Tommy Widenflycht  <tommyw@google.com>
2009
2010         MediaStream API: add RTCPeerConnection::createAnswer
2011         https://bugs.webkit.org/show_bug.cgi?id=96092
2012
2013         Reviewed by Adam Barth.
2014
2015         Expanding and enhancing MockWebRTCPeerConnectionHandler.
2016
2017         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2018         (MockWebRTCPeerConnectionHandler::createOffer):
2019         (MockWebRTCPeerConnectionHandler::createAnswer):
2020         (MockWebRTCPeerConnectionHandler::setLocalDescription):
2021         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
2022         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2023         (MockWebRTCPeerConnectionHandler):
2024
2025 2012-09-07  Dean Jackson  <dino@apple.com>
2026
2027         Unreviewed changes to watchlist.
2028
2029         - Add new WebGL and Filters definitions
2030         - Add myself to OpenGL bugs
2031
2032         * Scripts/webkitpy/common/config/watchlist:
2033
2034 2012-09-07  Peter Beverloo  <peter@chromium.org>
2035
2036         Actually trigger the Android Tester
2037         https://bugs.webkit.org/show_bug.cgi?id=96118
2038
2039         Reviewed by Adam Barth.
2040
2041         * BuildSlaveSupport/build.webkit.org-config/config.json:
2042
2043 2012-09-07  Dominic Mazzoni <dmazzoni@google.com>
2044
2045         New time input needs accessibility
2046         https://bugs.webkit.org/show_bug.cgi?id=96032
2047
2048         Reviewed by Chris Fleizach.
2049
2050         Add support for valueDescription for testing.
2051
2052         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2053         (getValueDescription):
2054         (AccessibilityUIElement::AccessibilityUIElement):
2055         (AccessibilityUIElement::valueDescriptionGetterCallback):
2056         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h:
2057         (AccessibilityUIElement):
2058
2059 2012-09-07  Peter Beverloo  <peter@chromium.org>
2060
2061         Add the google-android-tests build slave to the master's config
2062         https://bugs.webkit.org/show_bug.cgi?id=96113
2063
2064         Reviewed by Csaba Osztrogonác.
2065
2066         * BuildSlaveSupport/build.webkit.org-config/config.json:
2067
2068 2012-09-07  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2069
2070         [WK2] [EFL] Set theme for WebKit2 API test runner
2071         https://bugs.webkit.org/show_bug.cgi?id=96100
2072
2073         Reviewed by Kenneth Rohde Christiansen.
2074
2075         Set the theme generated by the build for the WebKit2 API test runner.
2076
2077         * TestWebKitAPI/PlatformEfl.cmake:
2078         * TestWebKitAPI/efl/PlatformWebView.cpp:
2079         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2080
2081 2012-09-07  Csaba Osztrogonác  <ossy@webkit.org>
2082
2083         Unreviewed. Add Gábor Ballabás as contributor.
2084
2085         * Scripts/webkitpy/common/config/committers.py:
2086
2087 2012-09-07  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
2088
2089         [Qt] Fix ROOT_BUILD_DIR on Windows MSVC build.
2090         https://bugs.webkit.org/show_bug.cgi?id=96078
2091
2092         Reviewed by Tor Arne Vestbø.
2093
2094         Correct JSC, DumpRenderTree, ImageDiff, QtTestBrowser binaries location by adding $$toSystemPath to ROOT_BUILD_DIR generation.
2095
2096         * qmake/mkspecs/features/default_pre.prf:
2097
2098 2012-09-07  Christophe Dumez  <christophe.dumez@intel.com>
2099
2100         [EFL] Add TestExpectations file for efl-wk1
2101         https://bugs.webkit.org/show_bug.cgi?id=96019
2102
2103         Reviewed by Gyuyoung Kim.
2104
2105         Update TestExpectations cascading for EFL port
2106         so that we use efl-wk1 -> efl search paths
2107         for WebKit1 EFL.
2108
2109         * Scripts/webkitpy/layout_tests/port/efl.py:
2110         (EflPort._search_paths):
2111
2112 2012-09-07  Zan Dobersek  <zandobersek@gmail.com>
2113
2114         [NRWT] XvfbDriver should stop the Xvfb more aggressively
2115         https://bugs.webkit.org/show_bug.cgi?id=95097
2116
2117         Reviewed by Dirk Pranke.
2118
2119         The Xvfb process is now killed when the XvfbDriver is stopping. Simply
2120         terminating the process does not always work as expected, leading to timeouts
2121         in run-webkit-tests on the buildbot. The lock file Xvfb creates is also removed
2122         as it's not removed by the killed Xvfb process.
2123
2124         Also included is a thorough unittest for XvfbDriver. Proper starting of the driver
2125         is tested in different circumstances - whether pixel tests are enabled or not,
2126         with an arbitrary worker number or with an Xorg process already running on the system.
2127         The stopping of the driver is tested by checking that the Xvfb process is truly killed
2128         and then set to None.
2129
2130         * BuildSlaveSupport/kill-old-processes:
2131         Kill any stale Xvfb processes at the start of the build cycle so no Xvfb
2132         is left running, potentially clogging up a display at a certain position.
2133         * Scripts/webkitpy/common/system/executive_mock.py:
2134         (MockExecutive.__init__):
2135         The _running_pids is now a dictionary with process names as keys and pids
2136         as values.
2137         (MockExecutive.check_running_pid):
2138         Check whether the passed-in pid is in the _running_pids dictionary's values.
2139         (MockExecutive):
2140         (MockExecutive.running_pids):
2141         This method returns the list of all the process pids of which the name passes
2142         through the process_name_filter.
2143         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
2144         Use the Executive object of the port's host to check for running pids and open
2145         new subprocesses or kill them throughout the class.
2146         (XvfbDriver._start):
2147         Use the _server_process_constructor to make testing the XvfbDriver possible. Also,
2148         start the server process after it's created.
2149         (XvfbDriver.stop):
2150         Now kills the Xvfb process instead of terminating it and waiting for it to close.
2151         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py: Added.
2152         (XvfbDriverTest):
2153         (XvfbDriverTest.make_driver):
2154         (XvfbDriverTest.assertDriverStartSuccessful):
2155         (XvfbDriverTest.test_start_no_pixel_tests):
2156         (XvfbDriverTest.test_start_pixel_tests):
2157         (XvfbDriverTest.test_start_arbitrary_worker_number):
2158         (XvfbDriverTest.test_start_existing_xorg_process):
2159         (XvfbDriverTest.test_stop):
2160         (XvfbDriverTest.test_stop.FakeXvfbProcess):
2161
2162 2012-09-06  Peter Beverloo  <peter@chromium.org>
2163
2164         Introduce the Chromium Android Release (Tests) bot
2165         https://bugs.webkit.org/show_bug.cgi?id=95980
2166
2167         Reviewed by Adam Barth.
2168
2169         This adds the Chromium Android Release (Tests) bot to the WebKit waterfall,
2170         which will be running layout tests on actual Android devices. Right now,
2171         four Galaxy Nexus phones are attached.
2172
2173         * BuildSlaveSupport/build.webkit.org-config/config.json:
2174
2175 2012-09-06  James Robinson  <jamesr@chromium.org>
2176
2177         [chromium] Use WebCompositorSupport functions instead of WebCompositor statics
2178         https://bugs.webkit.org/show_bug.cgi?id=96007
2179
2180         Reviewed by Adrienne Walker.
2181
2182         Fixes initialization / settings code to use WebCompositorSupport.
2183
2184         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2185         (main):
2186         * DumpRenderTree/chromium/TestShell.cpp:
2187         (TestShell::initialize):
2188         (TestShell::setPerTilePaintingEnabled):
2189
2190 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
2191
2192         [EFL][WK2] Provide implementation for PlatformWebView::windowFrame()
2193         https://bugs.webkit.org/show_bug.cgi?id=95995
2194
2195         Reviewed by Kenneth Rohde Christiansen.
2196
2197         Provide proper implementation for PlatformWebView::windowFrame()
2198         in EFL's WebKitTestRunner.
2199
2200         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2201         (WTR::PlatformWebView::windowFrame):
2202
2203 2012-09-06  Fady Samuel  <fsamuel@chromium.org>
2204
2205         Fix WTF.Lrint on 32-bit platforms
2206         https://bugs.webkit.org/show_bug.cgi?id=96003
2207
2208         Reviewed by Benjamin Poulain.
2209
2210         Fixed failing WTF.Lrint test on 32-bit platforms.
2211
2212         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2213         (TestWebKitAPI::TEST):
2214
2215 2012-09-06  Tommy Widenflycht  <tommyw@google.com>
2216
2217         MediaStream API: Add the local and remote description functionality to RTCPeerConnection
2218         https://bugs.webkit.org/show_bug.cgi?id=95839
2219
2220         Reviewed by Adam Barth.
2221
2222         In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
2223         up the task definitions a bit. There was no need to have them in the header file.
2224
2225         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2226         (RTCSessionDescriptionRequestSuccededTask):
2227         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
2228         (RTCSessionDescriptionRequestFailedTask):
2229         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
2230         (RTCVoidRequestTask):
2231         (RTCVoidRequestTask::RTCVoidRequestTask):
2232         (MockWebRTCPeerConnectionHandler::createOffer):
2233         (MockWebRTCPeerConnectionHandler::setLocalDescription):
2234         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
2235         (MockWebRTCPeerConnectionHandler::localDescription):
2236         (MockWebRTCPeerConnectionHandler::remoteDescription):
2237         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2238         (MockWebRTCPeerConnectionHandler):
2239
2240 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
2241
2242         [Qt] Fix build on Mac OS X 10.6
2243         https://bugs.webkit.org/show_bug.cgi?id=95200
2244
2245         Reviewed by Tor Arne Vestbø.
2246
2247         The build on Mac OS X 10.6 is broken when using QuickTime. Enable it only for
2248         10.7 and newer.
2249
2250         * qmake/mkspecs/features/features.prf:
2251
2252 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
2253
2254         [WKTR] addSelectionKey should be mapped to "Control" modifiers on other OSes than Mac
2255         https://bugs.webkit.org/show_bug.cgi?id=95973
2256
2257         Reviewed by Kenneth Rohde Christiansen.
2258
2259         Correctly map "addSelectionKey" to "Control" modifier
2260         in WKTR's EventSender on other OSes than Mac OS X,
2261         instead of mapping it to the "Meta" modifier.
2262
2263         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2264         (WTR::parseModifier):
2265
2266 2012-09-06  Balazs Kelemen  <kbalazs@webkit.org>
2267
2268         [nrwt] Harden against empty stdout/stderr after stopping a crashed/timed out driver
2269         https://bugs.webkit.org/show_bug.cgi?id=95710
2270
2271         Reviewed by Dirk Pranke.
2272
2273         The stdout / stderr output can be None so make sure
2274         we won't raise an exception in this case.
2275
2276         * Scripts/webkitpy/layout_tests/port/driver.py:
2277         (Driver.run_test):
2278
2279 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
2280
2281         [EFL] Sanitize URLs in EWebLauncher / Minibrowser
2282         https://bugs.webkit.org/show_bug.cgi?id=95849
2283
2284         Reviewed by Kenneth Rohde Christiansen.
2285
2286         Sanitize URLs passed by the user as program
2287         argument or typed in the URL bar in order to
2288         be more tolerant.
2289
2290         * EWebLauncher/CMakeLists.txt:
2291         * EWebLauncher/main.c:
2292         (main):
2293         * EWebLauncher/url_bar.c:
2294         (_url_bar_url_get_with_protocol):
2295         (on_urlbar_key_down):
2296         * EWebLauncher/url_utils.c: Added.
2297         (has_scheme):
2298         (url_from_user_input): Add utility function to construct a
2299         URL from user input.
2300         * EWebLauncher/url_utils.h: Added.
2301         * MiniBrowser/efl/CMakeLists.txt:
2302         * MiniBrowser/efl/main.c:
2303         (main):
2304
2305 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
2306
2307         [Qt] Various small Windows / MSVC build fixes
2308         https://bugs.webkit.org/show_bug.cgi?id=95934
2309
2310         Reviewed by Kenneth Rohde Christiansen.
2311
2312         setFocus takes a boolean as argument: Don't try to implicitly convert
2313         an enum to a boolean, MSVC doesn't like that. The intent here is to
2314         enable focus, so just pass true.
2315
2316         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2317         (WTR::PlatformWebView::focus):
2318
2319 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
2320
2321         [Qt] Fix build with ANGLE on platforms that provide EGL/GLESv2
2322         https://bugs.webkit.org/show_bug.cgi?id=95965
2323
2324         Reviewed by Tor Arne Vestbø.
2325
2326         Add ANGLE as a static library module to the Qt WebKit build system.
2327
2328         * qmake/mkspecs/features/default_post.prf:
2329         * qmake/mkspecs/modules/angle.prf: Added.
2330
2331 2012-09-06  Andras Becsi  <andras.becsi@nokia.com>
2332
2333         [WK2] Make [Qt]ViewportHandler cross platform
2334         https://bugs.webkit.org/show_bug.cgi?id=91257
2335
2336         Reviewed by Kenneth Rohde Christiansen.
2337
2338         Remove initial scale from viewport info item since it is
2339         set to -1 after applied thus it does not hold any valuable
2340         information.
2341
2342         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
2343
2344 2012-09-05  Tony Chang  <tony@chromium.org>
2345
2346         [chromium] Remove dependency on webkit_user_agent
2347         https://bugs.webkit.org/show_bug.cgi?id=95886
2348
2349         Reviewed by Adam Barth.
2350
2351         The code isn't used by DumpRenderTree.
2352
2353         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2354
2355 2012-09-05  Rick Byers  <rbyers@chromium.org>
2356
2357         Update chromium DumpRenderTree for new WebGestureEvent fields
2358         https://bugs.webkit.org/show_bug.cgi?id=95573
2359
2360         Reviewed by James Robinson.
2361
2362         Update EventSender to write gesture details into the appropriate
2363         type-specific WebGestureEvent fields.
2364         * DumpRenderTree/chromium/TestRunner/EventSender.cpp:
2365         (EventSender::gestureEvent):
2366         (EventSender::gestureFlingStart):
2367
2368 2012-09-05  Dirk Pranke  <dpranke@chromium.org>
2369
2370         NRWT lies about the number of tests that it's skipping when used with --repeat-each
2371         https://bugs.webkit.org/show_bug.cgi?id=95789
2372
2373         Reviewed by Ojan Vafai.
2374
2375         Fix miscalculation in log message.
2376
2377         * Scripts/webkitpy/layout_tests/views/printing.py:
2378         (Printer.print_found):
2379
2380 2012-09-05  Kenichi Ishibashi  <bashi@chromium.org>
2381
2382         Unreviewed, rolling out r127612, r127660, and r127664.
2383         http://trac.webkit.org/changeset/127612
2384         http://trac.webkit.org/changeset/127660
2385         http://trac.webkit.org/changeset/127664
2386         https://bugs.webkit.org/show_bug.cgi?id=95920
2387
2388         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2389         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
2390         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
2391         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
2392         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
2393         (MockWebRTCPeerConnectionHandler::createOffer):
2394         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2395         (MockWebRTCPeerConnectionHandler):
2396         (SuccessCallbackTask):
2397         (FailureCallbackTask):
2398
2399 2012-09-05  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
2400
2401         Ignore-metrics includes scroll offsets.
2402         https://bugs.webkit.org/show_bug.cgi?id=95845
2403
2404         Reviewed by Dirk Pranke.
2405
2406         Strip scroll-offsets the same way scroll-height and scroll-width is stripped.
2407
2408         * Scripts/old-run-webkit-tests:
2409         (stripMetrics):
2410         * Scripts/webkitpy/layout_tests/port/driver.py:
2411         (DriverOutput):
2412
2413 2012-09-05  Zan Dobersek  <zandobersek@gmail.com>
2414
2415         Unreviewed test fix.
2416
2417         Including a plugin source file into the build that was added in r127595.
2418
2419         * GNUmakefile.am:
2420
2421 2012-09-05  Tommy Widenflycht  <tommyw@google.com>
2422
2423         MediaStream API: Add the local and remote description functionality to RTCPeerConnection
2424         https://bugs.webkit.org/show_bug.cgi?id=95839
2425
2426         Reviewed by Adam Barth.
2427
2428         In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
2429         up the task definitions a bit. There was no need to have them in the header file.
2430
2431         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2432         (RTCSessionDescriptionRequestSuccededTask):
2433         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
2434         (RTCSessionDescriptionRequestFailedTask):
2435         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
2436         (RTCVoidRequestTask):
2437         (RTCVoidRequestTask::RTCVoidRequestTask):
2438         (MockWebRTCPeerConnectionHandler::createOffer):
2439         (MockWebRTCPeerConnectionHandler::setLocalDescription):
2440         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
2441         (MockWebRTCPeerConnectionHandler::localDescription):
2442         (MockWebRTCPeerConnectionHandler::remoteDescription):
2443         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2444         (MockWebRTCPeerConnectionHandler):
2445
2446 2012-09-05  Kangil Han  <kangil.han@samsung.com>
2447
2448         [EFL] Remove '+=' usage in String
2449         https://bugs.webkit.org/show_bug.cgi?id=95808
2450
2451         Reviewed by Benjamin Poulain.
2452
2453         Replaced use of String operator '+=' with StringBuilder.append*() in order to adopt efficient String concatenation.
2454
2455         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2456         (descriptionSuitableForTestResult):
2457
2458 2012-09-05  Christophe Dumez  <christophe.dumez@intel.com>
2459
2460         [EFL][WK2] Provide implementation for TestRunner::pathToLocalResource()
2461         https://bugs.webkit.org/show_bug.cgi?id=95842
2462
2463         Reviewed by Kenneth Rohde Christiansen.
2464
2465         Provide proper implementation for TestRunner::pathToLocalResource()
2466         in EFL WKTR, identical to the one for DumpRenderTree.
2467
2468         Map /tmp to ${DUMPRENDERTREE_TEMP} environment variable and
2469         /tmp/LayoutTests to ${LOCAL_RESOURCE_ROOT} so that local resources
2470         are found my WebKitTestRunner.
2471
2472         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
2473         (WTR::TestRunner::pathToLocalResource):
2474
2475 2012-09-05  Brady Eidson  <beidson@apple.com>
2476
2477         Frequent crashes in PluginView::scriptObject under runtimeObjectCustomGetOwnPropertySlot
2478         <rdar://problem/12142226> and https://bugs.webkit.org/show_bug.cgi?id=95026
2479
2480         Reviewed by Andy Estes.
2481
2482         Add a plug-in that always fails to initialize:
2483         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPNewFails.cpp: Added.
2484         (NPPNewFails):
2485         (NPPNewFails::NPPNewFails):
2486         (NPPNewFails::NPP_New):
2487
2488         Add it to all the project files:
2489         * DumpRenderTree/DumpRenderTree.gypi:
2490         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2491         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2492         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2493         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2494
2495 2012-09-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2496
2497         [Qt] Fix makefile race condition between derived sources and target
2498
2499         r121966 removed too much of the old qmake logic, including the rule
2500         that ensured that qmake_all would not trigger dual runs of qmake --
2501         one of the derived sources -qmake-all rule, and one for making the
2502         derived sources.
2503
2504         We now follow a similar pattern as before, by introducing a custom
2505         target that explicitly depends on the derived sources' qmake-all before
2506         doing a manual run of make. That ensures a single qmake run for the derived
2507         sources.
2508
2509         https://bugs.webkit.org/show_bug.cgi?id=93847
2510
2511         Reviewed by Csaba Osztrogonác.
2512
2513         * qmake/mkspecs/features/functions.prf:
2514
2515 2012-09-05  Christophe Dumez  <christophe.dumez@intel.com>
2516
2517         WKTR doesn't implement dumpWillCacheResponse()
2518         https://bugs.webkit.org/show_bug.cgi?id=94607
2519
2520         Reviewed by Kenneth Rohde Christiansen.
2521
2522         Define shouldCacheResponse() callback in resource
2523         load client and provide implementation for
2524         dumpWillCacheResponse() in WebKitTestRunner.
2525
2526         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2527         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2528         (WTR::InjectedBundlePage::InjectedBundlePage):
2529         (WTR::InjectedBundlePage::shouldCacheResponse):
2530         (WTR):
2531         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2532         (InjectedBundlePage):
2533         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2534         (WTR::TestRunner::TestRunner):
2535         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2536         (WTR::TestRunner::dumpWillCacheResponse):
2537         (WTR::TestRunner::shouldDumpWillCacheResponse):
2538         (TestRunner):
2539
2540 2012-09-05  Kaustubh Atrawalkar  <kaustubh@motorola.com>
2541
2542         [DRT] LTC:: Move printing related APIs from LayoutTestController to Internals
2543         https://bugs.webkit.org/show_bug.cgi?id=92735
2544
2545         Reviewed by Hajime Morita.
2546
2547         Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
2548
2549         * DumpRenderTree/TestRunner.cpp:
2550         (TestRunner::staticFunctions):
2551         * DumpRenderTree/TestRunner.h:
2552         (TestRunner):
2553         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2554         (TestRunner::addUserStyleSheet):
2555         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2556         (DRTTestRunner::DRTTestRunner):
2557         (DRTTestRunner::hasCustomPageSizeStyle):
2558         * DumpRenderTree/chromium/DRTTestRunner.h:
2559         (DRTTestRunner):
2560         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2561         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2562         * DumpRenderTree/mac/TestRunnerMac.mm:
2563         * DumpRenderTree/qt/TestRunnerQt.cpp:
2564         (TestRunner::evaluateScriptInIsolatedWorld):
2565         * DumpRenderTree/qt/TestRunnerQt.h:
2566         (TestRunner):
2567         * DumpRenderTree/win/TestRunnerWin.cpp:
2568         * DumpRenderTree/wx/TestRunnerWx.cpp:
2569         (TestRunner::abortModal):
2570         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2571         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2572         (WTR):
2573         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2574         (TestRunner):
2575
2576 2012-09-05  Simon Hausmann  <simon.hausmann@nokia.com>
2577
2578         [Qt] Automate the use of AllInOne files in the Qt build
2579         https://bugs.webkit.org/show_bug.cgi?id=95837
2580
2581         Reviewed by Tor Arne Vestbø.
2582
2583         New feature file that implements the all-in-one file automation by
2584         adding the requested all-in-one files to SOURCES and removing the files
2585         it includes from SOURCES.
2586
2587         * qmake/mkspecs/features/use_all_in_one_files.prf: Added.
2588
2589 2012-09-04  Tim Horton  <timothy_horton@apple.com>
2590
2591         Have NRWT log more output when crash logs are missing
2592         https://bugs.webkit.org/show_bug.cgi?id=95814
2593
2594         Reviewed by Dan Bernstein.
2595
2596         Log the stderr and stdout of the test, in order to provide slightly more
2597         context when the WebProcess times out while running tests.
2598
2599         * Scripts/webkitpy/layout_tests/port/driver.py:
2600         (Driver.run_test):
2601
2602 2012-09-04  Xianzhu Wang  <wangxianzhu@chromium.org>
2603
2604         [Chromium-Android] Include device serial number in ChromiumAndroidDriver log messages
2605         https://bugs.webkit.org/show_bug.cgi?id=95770
2606
2607         Reviewed by Adam Barth.
2608
2609         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2610         (ChromiumAndroidDriver.__init__):
2611         (ChromiumAndroidDriver._log_error): Added to replace original _log.error().
2612         (ChromiumAndroidDriver._log_debug): Added to replace original _log.debug().
2613         (ChromiumAndroidDriver._abort): Added to replace original raise AssertionError().
2614         (ChromiumAndroidDriver._push_executable):
2615         (ChromiumAndroidDriver._push_fonts):
2616         (ChromiumAndroidDriver._push_test_resources):
2617         (ChromiumAndroidDriver._run_adb_command):
2618         (ChromiumAndroidDriver._get_last_stacktrace):
2619         (ChromiumAndroidDriver._get_crash_log):
2620         (ChromiumAndroidDriver._start):
2621         (ChromiumAndroidDriver._start_once):
2622         (ChromiumAndroidDriver._start_once.deadlock_detector):
2623         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
2624         (ChromiumAndroidDriverTest.test_get_crash_log):
2625
2626 2012-09-04  Satish Sampath  <satish@chromium.org>
2627
2628         Run git commands within the checkout directory
2629         https://bugs.webkit.org/show_bug.cgi?id=95742
2630
2631         Reviewed by Eric Seidel.
2632
2633         git commands run from scm/git.py are sometimes run with cwd set to the
2634         checkout_root and other times with whatever directory was the default cwd.
2635         Instead all these should run with the checkout root set as the cwd
2636         (except where we explicitly need a different path)
2637
2638         * Scripts/webkitpy/common/checkout/scm/git.py:
2639         (Git._run_git):
2640         (Git.find_checkout_root):
2641         (Git.discard_local_commits):
2642         (Git.local_commits):
2643         (Git.working_directory_is_clean):
2644         (Git.clean_working_directory):
2645         (Git.add_list):
2646         (Git.delete_list):
2647         (Git.exists):
2648         (Git._current_branch):
2649         (Git._changes_files_for_commit):
2650         (Git.revisions_changing_file):
2651         (Git.svn_revision):
2652         (Git._run_git_svn_find_rev):
2653         (Git.contents_at_revision):
2654         (Git.diff_for_file):
2655         (Git.show_head):
2656         (Git.committer_email_for_revision):
2657         (Git.apply_reverse_diff):
2658         (Git.revert_files):
2659         (Git.commit_with_message):
2660         (Git._commit_on_branch):
2661         (Git.svn_commit_log):
2662         (Git.last_svn_commit_log):
2663         (Git.svn_blame):
2664         (Git._branch_ref_exists):
2665         (Git.delete_branch):
2666         (Git.remote_merge_base):
2667         (Git.commit_locally_with_message):
2668         (Git.push_local_commits_to_server):
2669         (Git.commit_ids_from_commitish_arguments):
2670         (Git.commit_message_for_local_commit):
2671         (Git.files_changed_summary_for_commit):
2672
2673 2012-09-04  Tommy Widenflycht  <tommyw@google.com>
2674
2675         MediaStream API: Add the async createOffer functionality to RTCPeerConnection
2676         https://bugs.webkit.org/show_bug.cgi?id=95734
2677
2678         Reviewed by Adam Barth.
2679
2680         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2681         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
2682         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
2683         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
2684         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
2685         (MockWebRTCPeerConnectionHandler::createOffer):
2686         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2687         (MockWebRTCPeerConnectionHandler):
2688         (MockWebRTCPeerConnectionHandler::taskList):
2689         (SuccessCallbackTask):
2690         (FailureCallbackTask):
2691
2692 2012-09-04  Xianzhu Wang  <wangxianzhu@chromium.org>
2693
2694         [Chromium-Android] Output time and thread info in crash log
2695         https://bugs.webkit.org/show_bug.cgi?id=95768
2696
2697         Reviewed by Adam Barth.
2698
2699         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2700         (ChromiumAndroidDriver._get_logcat): Add '-v threadtime' to adb logcat command line to get time and thread info.
2701
2702 2012-09-04  Tommy Widenflycht  <tommyw@google.com>
2703
2704         MediaStream API: Change the MediaStreamTrackList track added/removed signaling
2705         https://bugs.webkit.org/show_bug.cgi?id=95721
2706
2707         Reviewed by Adam Barth.
2708
2709         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
2710         (MockWebMediaStreamCenter::didAddMediaStreamTrack):
2711         (MockWebMediaStreamCenter::didRemoveMediaStreamTrack):
2712         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
2713         (MockWebMediaStreamCenter):
2714
2715 2012-09-04  Tony Chang  <tony@chromium.org>
2716
2717         Elide test names when running new-run-webkit-tests
2718         https://bugs.webkit.org/show_bug.cgi?id=95626
2719
2720         Reviewed by Dirk Pranke.
2721
2722         When the test name exceeds the number of terminal columns, it leaves
2723         text on the screen. Avoid this by eliding the test name when running
2724         tests. This is similar to what ninja does when compiling.
2725
2726         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
2727         (MeteredStream):
2728         (MeteredStream.number_of_columns): Helper method to get number of
2729         terminal columns. Won't work on Win32 python, but meh.
2730         * Scripts/webkitpy/layout_tests/views/printing.py:
2731         (Printer._test_status_line): New method for eliding the text. Doesn't use \u2026
2732         because stderr appears to be ascii only.
2733         (Printer.print_started_test): Route through _test_status_line.
2734         (Printer.print_finished_test): Route through _test_status_line.
2735         (Printer._print_test_trace): Route through _test_status_line.
2736         (Printer._print_baseline): Route through _test_status_line.
2737         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2738         (test_test_status_line): Test for _test_status_line.
2739
2740 2012-09-04  Martin Robinson  <mrobinson@igalia.com>
2741
2742         [GTK] Print API missing documentation when generating gtkdoc
2743         https://bugs.webkit.org/show_bug.cgi?id=95703
2744
2745         Reviewed by Carlos Garcia Campos.
2746
2747         Print out API missing documentation when generating gtkdoc. This makes it
2748         easier to fix documentation errors.
2749
2750         * gtk/generate-gtkdoc:
2751         (print_missing_api): Added.
2752         (generate_doc): Inline the rebase step, since it now reports an error
2753         when you try to rebase without generating documentation first.
2754         * gtk/gtkdoc.py:
2755         (GTKDoc.rebase_installed_docs): Raise an error when rebasing without
2756         generating documentation first to enable a small cleanup at the caller.
2757         (GTKDoc.api_missing_documentation): Added.
2758
2759 2012-09-04  Vincent Scheib  <scheib@chromium.org>
2760
2761         [Chromium] Allow asyncronous response of pointer lock requests in layout tests.
2762         https://bugs.webkit.org/show_bug.cgi?id=95628
2763
2764         Reviewed by James Robinson.
2765
2766         Future tests need the ability to respond asynchronously that
2767         pointer lock requests have been accepted or rejected. This patch
2768         adds the following:
2769             testRunner.setPointerLockWillRespondAsynchronously();
2770             testRunner.didAcquirePointerLock();
2771             testRunner.didNotAcquirePointerLock();
2772
2773         Tested in existing test:
2774             pointerlockchange-pointerlockerror-events.html
2775
2776         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2777         (DRTTestRunner::DRTTestRunner):
2778         (DRTTestRunner::didAcquirePointerLock):
2779         (DRTTestRunner::didNotAcquirePointerLock):
2780         (DRTTestRunner::setPointerLockWillRespondAsynchronously):
2781         * DumpRenderTree/chromium/DRTTestRunner.h:
2782         (DRTTestRunner):
2783         * DumpRenderTree/chromium/WebViewHost.cpp:
2784         (WebViewHost::requestPointerLock):
2785         (WebViewHost::didAcquirePointerLock):
2786         (WebViewHost::didNotAcquirePointerLock):
2787         * DumpRenderTree/chromium/WebViewHost.h:
2788         (WebViewHost):
2789         (WebViewHost::setPointerLockWillRespondAsynchronously):
2790
2791 2012-09-04  Ojan Vafai  <ojan@chromium.org>
2792
2793         Move content shell bots to their own builder group
2794         https://bugs.webkit.org/show_bug.cgi?id=95765
2795
2796         Reviewed by Adam Barth.
2797
2798         In their current state of instability, they add too much noise. Once they get more stable,
2799         we can add them back to the regular group or just have them replace the other bots.
2800
2801         Also, fix the filter for Apple Windows bots since some of them are now "Apple Win ...".
2802
2803         * TestResultServer/static-dashboards/builders.js:
2804         (isWebkitTestRunner):
2805         (isChromiumContentShellTestRunner):
2806         (isChromiumWebkitTipOfTreeTestRunner):
2807         (loadBuildersList):
2808
2809 2012-09-03  Ryuan Choi  <ryuan.choi@samsung.com>
2810
2811         [EFL] Change the focus when the web view is clicked in MiniBrowser and EWebLauncher
2812         https://bugs.webkit.org/show_bug.cgi?id=95689
2813
2814         Reviewed by Kenneth Rohde Christiansen.
2815
2816         In Minibrowser & EWebLauncher, the web view loses the focus when url bar is clicked.
2817         So, there are bugs that key events are always generated in url bar although
2818         the user clicked the web view.
2819
2820         This patch recovers the focus of the web view when left button is pressed and
2821         adds for MiniBrowser to toggle the focus when middle button is pressed
2822         like EWebLauncher already did.
2823
2824         * EWebLauncher/main.c:
2825         (on_mouse_down):
2826         * MiniBrowser/efl/main.c:
2827         (on_mouse_down):
2828         (browserCreate):
2829
2830 2012-09-03  Tao Bai  <michaelbai@chromium.org>
2831
2832         Added ANDROID_GDBSERVER definition for Ant
2833         https://bugs.webkit.org/show_bug.cgi?id=95265
2834
2835         Reviewed by Adam Barth.
2836
2837         ANDROID_GDBSERVER will replace ANDROID_TOOLCHAIN, because the ANDROID_TOOLCHAIN
2838         is only used for finding the gdbserver.
2839
2840         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2841         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
2842
2843 2012-09-03  Tommy Widenflycht  <tommyw@google.com>
2844
2845         MediaStream API: Add Ice-related functionality to RTCPeerConnection
2846         https://bugs.webkit.org/show_bug.cgi?id=95565
2847
2848         Reviewed by Adam Barth.
2849
2850         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2851         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
2852         (MockWebRTCPeerConnectionHandler::updateICE):
2853         (MockWebRTCPeerConnectionHandler::addICECandidate):
2854         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2855         (MockWebRTCPeerConnectionHandler):
2856
2857 2012-09-03  Christophe Dumez  <christophe.dumez@intel.com>
2858
2859         [EFL] Fix resizing issues related to URL bar in Minibrowser / EWebLauncher
2860         https://bugs.webkit.org/show_bug.cgi?id=95670
2861
2862         Reviewed by Kenneth Rohde Christiansen.
2863
2864         Fix layout issues related to the URL bar in Minibrowser
2865         and EWebLauncher when the window is resized.
2866
2867         The URL bar was not resized accordingly and the Web
2868         page was moved behing the URL bar, hiding part of it.
2869
2870         * EWebLauncher/main.c:
2871         (on_ecore_evas_resize):
2872         (closeWindow):
2873         * EWebLauncher/url_bar.c:
2874         (url_bar_width_set):
2875         (url_bar_add):
2876         * EWebLauncher/url_bar.h:
2877         * MiniBrowser/efl/main.c:
2878         (on_ecore_evas_resize):
2879         (main):
2880
2881 2012-09-01  Xianzhu Wang  <wangxianzhu@chromium.org>
2882
2883         [Chromium-Android] Remove hard-coded skipped directories in chromium_android.py
2884         https://bugs.webkit.org/show_bug.cgi?id=95605
2885
2886         Reviewed by Dirk Pranke.
2887
2888         Now skipping rules are put in LayoutTests/platform/chromium-android/TestExpectations.
2889
2890         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2891         (ChromiumAndroidPort.check_sys_deps):
2892         (ChromiumAndroidPort.expectations_files):
2893         (ChromiumAndroidPort.clean_up_test_run):
2894
2895 2012-09-01  Joanmarie Diggs  <jdiggs@igalia.com>
2896
2897         [Gtk] Incorrect/unexpected characters in the text of certain accessibles
2898         https://bugs.webkit.org/show_bug.cgi?id=95180
2899
2900         Reviewed by Chris Fleizach.
2901
2902         The bug that was fixed stood in the way of fully implementing stringValue().
2903         Testing that the bug is fixed requires stringValue() to be fully implemented
2904         and object replacement characters to be printable.
2905
2906         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2907         (replaceCharactersForResults): New method which turns object replacement
2908         characters into "<obj>" so that the characters can be properly shown in
2909         Layout Test results. Also turns "\n" into "<\\n>" so that printing the
2910         accessible text of a single object in the accessible tree doesn't mess up
2911         the readibility of the results.
2912         (AccessibilityUIElement::stringValue): Remove the code that immediately
2913         returned upon encountering an object of ATK_ROLE_PANEL and call the new
2914         replaceCharactersForResults() prior to returning the accessible string
2915         value.
2916
2917 2012-09-01  Tommy Widenflycht  <tommyw@google.com>
2918
2919         MediaStream API: Add MediaStream management to RTCPeerConnection
2920         https://bugs.webkit.org/show_bug.cgi?id=95543
2921
2922         Reviewed by Adam Barth.
2923
2924         Extending MockWebRTCPeerConnectionHandler to handle addStream/removeStream.
2925
2926         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2927         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
2928         (MockWebRTCPeerConnectionHandler::addStream):
2929         (MockWebRTCPeerConnectionHandler::removeStream):
2930         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2931         (MockWebRTCPeerConnectionHandler):
2932
2933 2012-08-31  Tony Chang  <tony@chromium.org>
2934
2935         Remove ENABLE_CSS3_FLEXBOX compile time flag
2936         https://bugs.webkit.org/show_bug.cgi?id=95382
2937
2938         Reviewed by Ojan Vafai.
2939
2940         Everyone is already enabling this by default and the spec has stablized.
2941
2942         * Scripts/webkitperl/FeatureList.pm:
2943         * qmake/mkspecs/features/features.pri:
2944
2945 2012-08-31  Pratik Solanki  <psolanki@apple.com>
2946
2947         objc_msgSend and IMP should be cast appropriately before using
2948         https://bugs.webkit.org/show_bug.cgi?id=95242
2949
2950         Reviewed by Benjamin Poulain.
2951
2952         Fix for older compilers. Pass id as the return type to the template
2953         instead of relying on default type.
2954
2955         * DumpRenderTree/mac/DumpRenderTree.mm:
2956         (drt_NSFontManager_availableFontFamilies):
2957         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
2958         (WTR::wtr_NSFontManager_availableFontFamilies):
2959
2960 2012-08-31  Zan Dobersek  <zandobersek@gmail.com>
2961
2962         nrwt: use scm instead of calling svn directly to get the revision in json results generator
2963         https://bugs.webkit.org/show_bug.cgi?id=89616
2964
2965         Reviewed by Eric Seidel.
2966
2967         Add the new 'executive' optional function argument to the SCM.in_working_directory
2968         class method. This way we get to reuse an Executive instance which is necessary in testing
2969         when we're operating with a mock version of the object.
2970
2971         In JSONResultsGeneratorBase, it's now possible to get the current SVN revision by using
2972         the SCMDetector with the generator's FileSystem and Executive instances.
2973
2974         * Scripts/webkitpy/common/checkout/scm/detection.py:
2975         (SCMDetector.detect_scm_system):
2976         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
2977         (SCMDetectorTest.test_detect_scm_system): Update the unit test to capture the mock
2978         Executive output and test it against expected output.
2979         * Scripts/webkitpy/common/checkout/scm/git.py:
2980         (Git.in_working_directory):
2981         * Scripts/webkitpy/common/checkout/scm/scm.py:
2982         (SCM.in_working_directory):
2983         * Scripts/webkitpy/common/checkout/scm/svn.py:
2984         (SVN.in_working_directory):
2985         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2986         (JSONResultsGeneratorBase.__init__):
2987         (JSONResultsGeneratorBase._get_svn_revision):
2988
2989 2012-08-31  Jon Lee  <jonlee@apple.com>
2990
2991         [Tests] Add basic tests to http/tests/notifications
2992         https://bugs.webkit.org/show_bug.cgi?id=95493
2993         <rdar://problem/12209303>
2994
2995         Reviewed by Alexey Proskuryakov.
2996
2997         Add permission request support for WTR.
2998
2999         * WebKitTestRunner/TestController.cpp:
3000         (WTR::TestController::initialize):
3001         (WTR::TestController::decidePolicyForNotificationPermissionRequest): Always allow.
3002         * WebKitTestRunner/TestController.h:
3003         (TestController):
3004
3005 2012-08-31  Jon Lee  <jonlee@apple.com>
3006
3007         [DRT] Make simulating a web click on a notification a queued task
3008         https://bugs.webkit.org/show_bug.cgi?id=95546
3009         <rdar://problem/12214170>
3010
3011         Reviewed by Alexey Proskuryakov.
3012
3013         Making the web click happen asynchronously better mimics user interaction with the platform.
3014
3015         * DumpRenderTree/TestRunner.h: Add a flag that determines whether we have a pending notification click.
3016         (TestRunner::hasPendingWebNotificationClick): Exposed so that dump() can check that the flag is
3017         not set.
3018         * DumpRenderTree/mac/DumpRenderTree.mm:
3019         (dump): Assert that the flag is not set.
3020         * DumpRenderTree/mac/TestRunnerMac.mm:
3021         (TestRunner::simulateWebNotificationClick): Set the flag, then add a task to click the
3022         notification. In the case where the block gets executed after the flag has been unset, we avoid
3023         performing the click.
3024
3025 2012-08-31  Balazs Kelemen  <kbalazs@webkit.org>
3026
3027         [Qt] ImageDiff output is not in the expected form if image dimensions differ
3028         https://bugs.webkit.org/show_bug.cgi?id=95575
3029
3030         Reviewed by Csaba Osztrogonác.
3031
3032         Output 100% difference in the case of differing image dimensions so
3033         the test harness knows that we won't produce any output further.
3034         This matches the behavior of other ports.
3035
3036         * DumpRenderTree/qt/ImageDiff.cpp:
3037         (main):
3038
3039 2012-08-31  Sheriff Bot  <webkit.review.bot@gmail.com>
3040
3041         Unreviewed, rolling out r127261.
3042         http://trac.webkit.org/changeset/127261
3043         https://bugs.webkit.org/show_bug.cgi?id=95572
3044
3045         This patch depends on other build fixes (see blockers of bug
3046         95466) which should land first (Requested by milian on
3047         #webkit).
3048
3049         * qmake/mkspecs/features/features.prf:
3050
3051 2012-08-31  Milian Wolff  <milian.wolff@kdab.com>
3052
3053         [Qt] Support WebKit2/QML on QNX
3054         https://bugs.webkit.org/show_bug.cgi?id=95466
3055
3056         Reviewed by Noam Rosenthal.
3057
3058         Enable USE(3D_GRAPHICS) on QNX again, paired with the other bug fixes
3059         this should finally work now.
3060
3061         * qmake/mkspecs/features/features.prf:
3062
3063 2012-08-30  Xianzhu Wang  <wangxianzhu@chromium.org>
3064
3065         [Chromium-Android] Skip compositing/webgl and platform/chromium/virtual/threaded/compositing/webgl tests
3066         https://bugs.webkit.org/show_bug.cgi?id=95400
3067
3068         Reviewed by Dirk Pranke.
3069
3070         WebGL is not enabled and should be skipped on Android (http://crbug.com/135877).
3071
3072         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3073         (ChromiumAndroidPort.skipped_layout_tests):
3074
3075 2012-08-30  Gustavo Noronha Silva  <gns@gnome.org>
3076
3077         [GTK] Tries to run empty string when calling generate-gtkdoc when not using jhbuild
3078         https://bugs.webkit.org/show_bug.cgi?id=95499
3079
3080         Unreviewed. One more fix to avoid trying to run the empty string.
3081
3082         * Scripts/webkitdirs.pm:
3083         (buildAutotoolsProject):
3084
3085 2012-08-30  Sheriff Bot  <webkit.review.bot@gmail.com>
3086
3087         Unreviewed, rolling out r127171.
3088         http://trac.webkit.org/changeset/127171
3089         https://bugs.webkit.org/show_bug.cgi?id=95505
3090
3091         testRunner does not need dumpWebNotificationCallbacks().
3092         (Requested by jonlee on #webkit).
3093
3094         * DumpRenderTree/TestRunner.cpp:
3095         (TestRunner::TestRunner):
3096         (TestRunner::staticFunctions):
3097         * DumpRenderTree/TestRunner.h:
3098         (TestRunner):
3099         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
3100         (-[MockWebNotificationProvider webView:didShowNotification:]):
3101         (-[MockWebNotificationProvider webView:didClickNotification:]):
3102         (-[MockWebNotificationProvider webView:didCloseNotifications:]):
3103         * DumpRenderTree/mac/UIDelegate.mm:
3104         (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]):
3105
3106 2012-08-30  Pratik Solanki  <psolanki@apple.com>
3107
3108         objc_msgSend and IMP should be cast appropriately before using
3109         https://bugs.webkit.org/show_bug.cgi?id=95242
3110
3111         Reviewed by Benjamin Poulain.
3112
3113         Use wtfObjcMsgSend and wtfCallIMP templates which do appropriate casts
3114         to a function pointer with right types when calling objc_msgSend and an
3115         IMP method directly.
3116
3117         * DumpRenderTree/mac/DumpRenderTree.mm:
3118         (drt_NSFontManager_availableFontFamilies):
3119         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3120         (WTR::wtr_NSFontManager_availableFontFamilies):
3121
3122 2012-08-30  Benjamin Poulain  <bpoulain@apple.com>
3123
3124         Replace JSC::UString by WTF::String
3125         https://bugs.webkit.org/show_bug.cgi?id=95271
3126
3127         Reviewed by Geoffrey Garen.
3128
3129         Get rid of UString.
3130
3131         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
3132         * gdb/webkit.py:
3133         (WTFStringPrinter.to_string):
3134         (JSCIdentifierPrinter.to_string):
3135         (JSCJSStringPrinter.to_string):
3136         (add_pretty_printers):
3137
3138 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
3139
3140         nrwt should have TestExpectations everywhere we have Skipped files for apple ports
3141         https://bugs.webkit.org/show_bug.cgi?id=95495
3142
3143         Reviewed by Ojan Vafai.
3144
3145         This is a follow-on to bug 95370 that adds in support for
3146         platform/wk2/TestExpectations and
3147         platform/{mac,win}-$version/TestExpectations.
3148
3149         * Scripts/webkitpy/layout_tests/port/apple.py:
3150         (ApplePort.expectations_files):
3151         * Scripts/webkitpy/layout_tests/port/base.py:
3152         (Port._skipped_file_search_paths):
3153         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3154         (MacTest.test_expectations_files):
3155         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3156         (MockDRTPortTest.make_port):
3157         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3158         (WinPortTest.test_expectations_files):
3159
3160 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
3161
3162         executive.run_in_parallel() hangs if given nothing to do
3163         https://bugs.webkit.org/show_bug.cgi?id=95387
3164
3165         Reviewed by Ojan Vafai.
3166
3167         Check to make sure that Executive.run_in_parallel() requires
3168         a non-empty list of commands to execute; passing an empty list
3169         seems surely like a programming error.
3170
3171         * Scripts/webkitpy/common/system/executive.py:
3172         (Executive.run_in_parallel):
3173         * Scripts/webkitpy/common/system/executive_unittest.py:
3174         (ExecutiveTest.test_run_in_parallel_assert_nonempty):
3175
3176 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
3177
3178         decide what (and how) we should set the tolerance for ref test pixel compares and test for that
3179         https://bugs.webkit.org/show_bug.cgi?id=94746
3180
3181         Reviewed by Ojan Vafai.
3182
3183         Add an assertion to diff_image() to check that we are passing
3184         tolerance=0 explicitly when diffing ref test results.
3185
3186         * Scripts/webkitpy/layout_tests/port/test.py:
3187         (TestPort.diff_image):
3188
3189 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
3190
3191         NRWT should look in mac-wk2 for a TestExpecations file
3192         https://bugs.webkit.org/show_bug.cgi?id=95370
3193
3194         Reviewed by Ojan Vafai.
3195
3196         Adds support for mac-wk2 and win-wk2 to expectations_files()
3197         for the apple mac and apple win ports.
3198         
3199         * Scripts/webkitpy/layout_tests/port/apple.py:
3200         (ApplePort.expectations_files):
3201         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3202         (MacTest.test_expectations_files):
3203         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3204         (WinTest.test_expectations_files):
3205         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3206         (PortTestCase.test_expectations_files):
3207
3208 2012-08-30  Jon Lee  <jonlee@apple.com>
3209
3210         [Mac] Add testRunner.dumpWebNotificationCallbacks() to DRT
3211         https://bugs.webkit.org/show_bug.cgi?id=95232
3212         <rdar://problem/12190776>
3213
3214         Reviewed by Alexey Proskuryakov.
3215
3216         Add additional output when running test, if testRunner.dumpWebNotificationCallbacks() is called.
3217
3218         * DumpRenderTree/TestRunner.cpp:
3219         (TestRunner::TestRunner):
3220         (dumpWebNotificationCallbacksCallback):
3221         (TestRunner::staticFunctions):
3222         * DumpRenderTree/TestRunner.h:
3223         (TestRunner):
3224         (TestRunner::dumpWebNotificationCallbacks):
3225         (TestRunner::setDumpWebNotificationCallbacks):
3226         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
3227         (-[WebNotification _drt_descriptionSuitableForTestResult]):
3228         (-[MockWebNotificationProvider webView:didShowNotification:]):
3229         (-[MockWebNotificationProvider webView:didClickNotification:]):
3230         (-[MockWebNotificationProvider webView:didCloseNotifications:]):
3231         * DumpRenderTree/mac/UIDelegate.mm:
3232         (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]):
3233
3234 2012-08-30  Tommy Widenflycht  <tommyw@google.com>
3235
3236         MediaStream API: Introduce MediaConstraints
3237         https://bugs.webkit.org/show_bug.cgi?id=95198
3238
3239         Reviewed by Adam Barth.
3240
3241         Extending the MockWebRTCPeerConnectionHandler with MediaConstraints functionality.
3242
3243         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3244         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
3245         (isSupportedConstraint):
3246         (isValidConstraint):
3247         (MockWebRTCPeerConnectionHandler::initialize):
3248         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3249         (MockWebRTCPeerConnectionHandler):
3250
3251 2012-08-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3252
3253         [WK2][WTR] Add didReceiveServerRedirectForProvisionalLoadForFrame dumping
3254         https://bugs.webkit.org/show_bug.cgi?id=95454
3255
3256         Reviewed by Kenneth Rohde Christiansen.
3257
3258         Added didReceiveServerRedirectForProvisionalLoadForFrame dumping to WTR.
3259
3260         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3261         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
3262
3263 2012-08-30  Leo Yang  <leoyang@rim.com>
3264
3265         Update my email address.
3266
3267         Not reviewed.
3268
3269         * Scripts/webkitpy/common/config/committers.py:
3270
3271 2012-08-30  Jochen Eisinger  <jochen@chromium.org>
3272
3273         [NRWT] Add support for recognizing arbitrary process names in crash lines
3274         https://bugs.webkit.org/show_bug.cgi?id=95435
3275
3276         Reviewed by Adam Barth.
3277
3278         When running layout tests in the chromium port using the content shell,
3279         we want to be able to report sub-process crashes as well.
3280
3281         * Scripts/webkitpy/layout_tests/port/driver.py:
3282         (Driver._check_for_driver_crash):
3283         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
3284         (DriverTest.test_check_for_driver_crash):
3285
3286 2012-08-29  Zan Dobersek  <zandobersek@gmail.com>
3287
3288         Random test-webkitpy failures on the buildbot
3289         https://bugs.webkit.org/show_bug.cgi?id=95096
3290
3291         Reviewed by Dirk Pranke.
3292
3293         Suppress occasional errors when running test-webkitpy on GTK builders
3294         by running these tests serially. The 64-bit Release builder is especially
3295         prone to these as it can run up to 24 tests in parallel.
3296
3297         Despite the tests not being run in parallel, the testing only lasts a handful
3298         of seconds more, so this is a worthy trade-off to avoid unnecessary
3299         false-alarm redness on the GTK builders.
3300
3301         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3302         (RunPythonTests.start):
3303
3304 2012-08-29  Benjamin Poulain  <bpoulain@apple.com>
3305
3306         REGRESSION(r126780): Crash using StringImpl::is8Bit before checking if there is an impl
3307         https://bugs.webkit.org/show_bug.cgi?id=95380
3308
3309         Reviewed by Michael Saboff.
3310
3311         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3312         Add very basic tests for String::ascii(). This covers the case of null strings that caused
3313         the crash.
3314
3315 2012-08-29  Dominic Mazzoni  <dmazzoni@google.com>
3316
3317         AX: Canvas should have a distinct role
3318         https://bugs.webkit.org/show_bug.cgi?id=95248
3319
3320         Reviewed by Chris Fleizach.
3321
3322         Add support for canvas accessibility role.
3323
3324         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
3325         (roleToString):
3326
3327 2012-08-29  José Dapena Paz  <jdapena@igalia.com>
3328
3329         [Gtk] Process Gtk 3.4 smooth scroll events properly
3330         https://bugs.webkit.org/show_bug.cgi?id=88070
3331
3332         Added continousMouseScrollBy support in WebKitTestRunner, and added
3333         implementation for gtk, and stub for Qt, mac and EFL.
3334
3335         Added layout tests support for smooth scroll in Gtk 3.4, and use smooth
3336         scroll for emulating multi-tick mouseScrollBy events.
3337
3338         Reviewed by Martin Robinson.
3339
3340         * DumpRenderTree/gtk/EventSender.cpp:
3341         (mouseScrollByCallback):
3342         (continuousMouseScrollByCallback):
3343         * WebKitTestRunner/EventSenderProxy.h:
3344         (EventSenderProxy):
3345         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3346         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3347         (WTR::EventSendingController::mouseScrollBy):
3348         (WTR):
3349         (WTR::EventSendingController::continuousMouseScrollBy):
3350         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3351         (EventSendingController):
3352         * WebKitTestRunner/TestController.cpp:
3353         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3354         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3355         (WTR):
3356         (WTR::EventSenderProxy::mouseScrollBy):
3357         (WTR::EventSenderProxy::continuousMouseScrollBy):
3358         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
3359         (WTR):
3360         (WTR::EventSenderProxy::continuousMouseScrollBy):
3361         * WebKitTestRunner/mac/EventSenderProxy.mm:
3362         (WTR::EventSenderProxy::continuousScrollBy):
3363         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
3364         (WTR::EventSenderProxy::continuousMouseScrollBy):
3365         (WTR):
3366
3367 2012-08-29  Alex Sakhartchouk  <alexst@chromium.org>
3368
3369         [chromium] Support high DIP pixel tests with DumpRenderTree
3370         https://bugs.webkit.org/show_bug.cgi?id=94935
3371
3372         Reviewed by James Robinson.
3373
3374         Adding device scale factor into the drt image dumping code
3375
3376         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3377         (DRTTestRunner::reset):
3378         (DRTTestRunner::setBackingScaleFactor):
3379         * DumpRenderTree/chromium/WebViewHost.cpp:
3380         (WebViewHost::setDeviceScaleFactor):
3381         (WebViewHost::paintInvalidatedRegion):
3382         (WebViewHost::canvas):
3383         * DumpRenderTree/chromium/WebViewHost.h:
3384         (WebViewHost):
3385
3386 2012-08-29  Kevin Funk  <kevin.funk@kdab.com>
3387
3388         Fix check-webkit-style (and probably others) when WebKit is in a git submodule
3389         https://bugs.webkit.org/show_bug.cgi?id=95177
3390
3391         Reviewed by Dirk Pranke.
3392
3393         Find the real checkout root by using 'git rev-parse --show-toplevel' instead of '--git-dir'
3394
3395         * Scripts/webkitpy/common/checkout/scm/git.py:
3396
3397 2012-08-29  Dirk Pranke  <dpranke@chromium.org>
3398
3399         webkit-patch rebaseline-expectations wrongly touches other platforms' TestExpectations
3400         https://bugs.webkit.org/show_bug.cgi?id=95222
3401
3402         Reviewed by Adam Barth.
3403
3404         The code we had to remove REBASELINE lines from the
3405         TestExpectations files did not handle multiple files (in a
3406         cascade) correctly; we weren't limiting lines to a particular
3407         file correctly in without_rebaseline_modifier(). This patch
3408         fixes that and corrects the tests (which weren't correct and
3409         didn't cover things very well).
3410
3411         Note also that the webkit-patch rebaseline-commands are still
3412         using the include_overrides=False option in a couple places;
3413         this is never correct or needed at this point. This patch fixes
3414         the usage for webkit-patch rebaseline-expectations, but I still
3415         need to fix rebaseline-test-internal, which I will do in a
3416         separate patch (see bug 95268).
3417
3418         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3419         (TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier):
3420         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3421         (RebaseliningTest.assertRemove):
3422         (RebaseliningTest.test_remove):
3423         * Scripts/webkitpy/tool/commands/rebaseline.py:
3424         (RebaselineExpectations._update_expectations_files):
3425
3426 2012-08-29  Dirk Pranke  <dpranke@chromium.org>
3427
3428         webkit-patch rebaseline-expectations hangs
3429         https://bugs.webkit.org/show_bug.cgi?id=95243
3430
3431         Reviewed by Tony Chang.
3432
3433         Don't try to run no commands in parallel; report an error
3434         instead that we didn't find any tests to rebaseline.
3435
3436         Filed bug 95387 as well to make sure run_in_parallel() doesn't hang forever.
3437
3438         * Scripts/webkitpy/tool/commands/rebaseline.py:
3439         (RebaselineExpectations.execute):
3440         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3441         (_assert_command):
3442         (test_rebaseline_expectations_noop):
3443
3444 2012-08-29  Brady Eidson  <beidson@apple.com>
3445
3446         REGRESSION: Not sending NPP_SetWindow is causing Flash to not throttle itself
3447         <rdar://problem/12133021> and https://bugs.webkit.org/show_bug.cgi?id=95274
3448
3449         Reviewed by Sam Weinig.
3450
3451         Add a test plug-in that calls back into the page with info on the NPWindow passed
3452         in to NPP_SetWindow.
3453
3454         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3455         * DumpRenderTree/TestNetscapePlugIn/Tests/LogNPPSetWindow.cpp: Added.
3456         (LogNPPSetWindow):
3457         (LogNPPSetWindow::LogNPPSetWindow):
3458         (LogNPPSetWindow::NPP_SetWindow):
3459
3460 2012-08-29  Jon Lee  <jonlee@apple.com>
3461
3462         [Mac] Basic DRT support for web notifications
3463         https://bugs.webkit.org/show_bug.cgi?id=79492
3464         <rdar://problem/10357639>
3465
3466         Reviewed by Alexey Proskuryakov.
3467
3468         This patch implements the stubs for web notification support on DRT. Assume that when
3469         Notification.requestPermission() is called, the user always chooses to allow it. This can be easily
3470         overridden in layout tests with testRunner.denyWebNotificationPermission() when needed.
3471
3472         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add MockWebNotificationProvider.
3473         * DumpRenderTree/mac/DumpRenderTree.mm:
3474         (createWebViewAndOffscreenWindow): Set MockWebNotificationProvider singleton as the provider for the
3475         web view.
3476         (resetWebViewToConsistentStateBeforeTesting): Make sure to reset the provider's state between each test.
3477
3478         * DumpRenderTree/mac/TestRunnerMac.mm:
3479         (TestRunner::grantWebNotificationPermission): Set permission to granted for specified origin.
3480         (TestRunner::denyWebNotificationPermission): Set permission to denied for specified origin.
3481         (TestRunner::removeAllWebNotificationPermissions):
3482         (TestRunner::simulateWebNotificationClick): Retrieve the notification ID from the JS notification object, and
3483         simulate the click. This is similar to how WTR performs the click.
3484         * DumpRenderTree/mac/UIDelegate.mm:
3485         (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]): Assume when asked, the
3486         user allows web notifications.
3487
3488         * DumpRenderTree/mac/MockWebNotificationProvider.h: Added. Maintains a list of registered web views, known permissions,
3489         a map of notification IDs to WebNotification instances, and a map of the WebViews from which the notifications were dispatched.
3490         * DumpRenderTree/mac/MockWebNotificationProvider.mm: Added.
3491         (+[MockWebNotificationProvider shared]): The provider is a singleton.
3492         (-[MockWebNotificationProvider init]): Instantiate the permissions map.
3493         (-[MockWebNotificationProvider registerWebView:]):
3494         (-[MockWebNotificationProvider unregisterWebView:]):
3495         (-[MockWebNotificationProvider showNotification:fromWebView:]): Add the notification to the maps. Tell the web view that the
3496         notification did show.
3497         (-[MockWebNotificationProvider cancelNotification:]): Tell the web view the notification did close.
3498         (-[MockWebNotificationProvider notificationDestroyed:]): Remove the notification from the maps. Here we don't make a callback.
3499         (-[MockWebNotificationProvider clearNotifications:]): Remove the specified notifications from the maps. Here we don't make a callback.
3500         (-[MockWebNotificationProvider webView:didShowNotification:]): Delegate callback. Dispatch the show event.
3501         (-[MockWebNotificationProvider webView:didClickNotification:]): Delegate callback. Dispatch the click event.
3502         (-[MockWebNotificationProvider webView:didCloseNotifications:]): Delegate callback. Dispatch the close event.
3503         (-[MockWebNotificationProvider simulateWebNotificationClick:]): Tell the web view we clicked the notification.
3504         (-[MockWebNotificationProvider policyForOrigin:]): Look in the permission dictionary.
3505         (-[MockWebNotificationProvider setWebNotificationOrigin:permission:]): Set the permission for the origin in the dictionary.
3506         (-[MockWebNotificationProvider removeAllWebNotificationPermissions]): Clear the permission map.
3507         (-[MockWebNotificationProvider reset]): Remove all mappings and permissions.
3508
3509 2012-08-29  Rob Buis  <rbuis@rim.com>
3510
3511         [BlackBerry] Adjust wtf include header style
3512         https://bugs.webkit.org/show_bug.cgi?id=95368
3513
3514         Reviewed by Yong Li.
3515
3516         Switch to #include <wtf/...> like the other ports.
3517
3518         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3519         * DumpRenderTree/blackberry/PNGImageEncoder.cpp:
3520         * DumpRenderTree/blackberry/PNGImageEncoder.h:
3521         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
3522         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.h:
3523         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
3524
3525 2012-08-29  Roger Fong  <roger_fong@apple.com>
3526
3527         Update cygwin-downloader.zip to match modified downloader script.
3528         https://bugs.webkit.org/show_bug.cgi?id=76936
3529
3530         Rubber Stamped by Jon Honeycutt.
3531
3532         cygwin-downloader.py was modified in http://trac.webkit.org/changeset/126948.
3533         Updating zip to reflect changes.
3534
3535         * CygwinDownloader/cygwin-downloader.zip:
3536
3537 2012-08-29  Dominik Röttsches  <dominik.rottsches@intel.com>
3538
3539         Stylechecker warns about comparison to zero when comparing to 0.5
3540         https://bugs.webkit.org/show_bug.cgi?id=94913
3541
3542         Reviewed by Dirk Pranke.
3543
3544         According to the python documentation, \W is the character group with all
3545         non-alphanumeric characters, equivalent to [^a-zA-Z0-9_], which is equal to
3546         to [^\w]. We need to exclude the dot "." as well, so that floating point
3547         values do not trigger this warning. Adding a unit test that shows the problem.
3548
3549         * Scripts/webkitpy/style/checkers/cpp.py:
3550         (check_for_comparisons_to_zero): Modifying the regex to not get triggered by comparing to floats.
3551         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3552         (WebKitStyleTest.test_null_false_zero): Unit test exposing this issue.
3553
3554 2012-08-29  Jon Lee  <jonlee@apple.com>
3555
3556         WTR build fixes.
3557
3558         * WebKitTestRunner/CMakeLists.txt:
3559         * WebKitTestRunner/GNUmakefile.am:
3560         * WebKitTestRunner/Target.pri:
3561         * WebKitTestRunner/WebNotificationProvider.cpp:
3562         (WTR::WebNotificationProvider::showWebNotification): Make ML happier.
3563         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3564
3565 2012-08-29  Jon Lee  <jonlee@apple.com>
3566
3567         [WK2] Basic WTR support for web notifications
3568         https://bugs.webkit.org/show_bug.cgi?id=95154
3569         <rdar://problem/12184492>
3570
3571         Reviewed by Alexey Proskuryakov.
3572
3573         Implement WTR support, without platform event output (bug 95233).
3574
3575         Legacy APIs will not be supported, since many of the tests are skipped
3576         on ports that do test notifications, and the issue with using file:// as the origin means a lot of the permissions
3577         tests won't work. Bugs 81048 and 81697 will track migrating the existing tests to use the new testRunner API, and move
3578         the tests to http/tests/notifications.
3579
3580         Permissions will be handled only in the injected bundle. This allows tests to set permission synchronously, and not
3581         require a chain of setTimeout()'s when writing a notification test. Clicking a notification, however, should
3582         be invoked from the UIProcess.
3583
3584         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3585         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3586         (WTR::InjectedBundle::didReceiveMessage): When told to "Reset", clear out all of the permissions.
3587         (WTR::InjectedBundle::postSimulateWebNotificationClick): Tell the bundle client to simulate a click based on the
3588         notification's internal ID.
3589         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3590         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3591         (WTR::TestRunner::grantWebNotificationPermission): Manually set the permission using WKBundle SPI.
3592         (WTR::TestRunner::denyWebNotificationPermission): Manually set the permission using WKBundle SPI.
3593         (WTR::TestRunner::removeAllWebNotificationPermissions):
3594         (WTR::TestRunner::simulateWebNotificationClick): Post a message through the injected bundle.
3595         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3596
3597         Because supporting web notifications goes beyond a couple functions, move all of the logic into a WebNotificationProvider
3598         class.
3599         * WebKitTestRunner/TestInvocation.cpp:
3600         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): When the injected bundle sends a message to simulate a click,
3601         TestInvocation forwards that request to the TestController.
3602         * WebKitTestRunner/TestController.cpp:
3603         (WTR::TestController::initialize): Set the provider.
3604         (WTR::TestController::resetStateToConsistentValues): Tell the provider to reset.
3605         (WTR::TestController::simulateWebNotificationClick): Tell the provider to simulate a user clicking on a platform notification.
3606         * WebKitTestRunner/TestController.h: Holds an instance to the provider.
3607
3608         The provider maintains a pointer to one notification manager (presumably the web process associated with WTR), and a set
3609         of notification IDs that have been "shown" by the platform. This allows us to simulate a click on a notification.
3610         * WebKitTestRunner/WebNotificationProvider.h: Added.
3611         * WebKitTestRunner/WebNotificationProvider.cpp: Added.
3612         (WTR::WebNotificationProvider::showWebNotification): Adds the notification to set of shown notifications. Notifies provider that
3613         the notification got shown.
3614         (WTR::WebNotificationProvider::closeWebNotification): Removes the notification from the set. Notifies provider that the notification
3615         got closed.
3616         (WTR::WebNotificationProvider::addNotificationManager): Maintains one manager, which is fine for testing purposes.
3617         (WTR::WebNotificationProvider::removeNotificationManager): Maintains one manager.
3618         (WTR::WebNotificationProvider::notificationPermissions): When the web process starts, it maintains an initial set of known
3619         permissions. For testing purposes, we always want this set to be empty.
3620         (WTR::WebNotificationProvider::simulateWebNotificationClick): Notifies provider that the notification got "clicked".
3621         (WTR::WebNotificationProvider::reset): To reset the state, we pretend that we closed all of the platform notifications.
3622
3623         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Add WebNotificationProvider.
3624
3625 2012-08-29  Kamil Blank  <k.blank@samsung.com>
3626
3627         [EFL] Add setting API for allow universal/file access from file URLs.
3628         https://bugs.webkit.org/show_bug.cgi?id=83121
3629
3630         Reviewed by Eric Seidel.
3631
3632         Implementation of setAllowUniversalAccessFromFileURLs and setAllowFileAccessFromFileURLs.
3633
3634         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3635         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3636         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3637         (TestRunner::setAllowUniversalAccessFromFileURLs):
3638         (TestRunner::setAllowFileAccessFromFileURLs):
3639
3640 2012-08-29  Jon Lee  <jonlee@apple.com>
3641
3642         Update TestRunner API for web notifications
3643         https://bugs.webkit.org/show_bug.cgi?id=95093
3644         <rdar://problem/12179649>
3645
3646         Reviewed by Alexey Proskuryakov.
3647
3648         As it turns out the patch for this accidentally got squashed into the commit for
3649         bug 95099 (r126909). This amendment patch adds some comments about the renaming
3650         of the older TestRunner API for web notifications.
3651
3652         * DumpRenderTree/TestRunner.h:
3653         (TestRunner):
3654
3655 2012-08-29  Sheriff Bot  <webkit.review.bot@gmail.com>
3656