[GTK] [CMake] Add a "make dist" target
[WebKit-https.git] / Tools / ChangeLog
1 2014-01-30  Martin Robinson  <mrobinson@igalia.com>
2
3         [GTK] [CMake] Add a "make dist" target
4         https://bugs.webkit.org/show_bug.cgi?id=116378
5
6         Reviewed by Gustavo Noronha Silva.
7
8         Added a script that reads a manifest file an produces a tarball. Also add
9         the manifest.
10
11         * gtk/make-dist.py: Added.
12         * gtk/manifest.txt: Added.
13
14 2014-01-30  David Farler  <dfarler@apple.com>
15
16         Move OTHER_LDFLAGS erasure to DumpRenderTreeLibrary.xcconfig.
17         https://bugs.webkit.org/show_bug.cgi?id=127935
18
19         Reviewed by Andy Estes.
20
21         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
22         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig:
23         Move OTHER_LDFLAGS erasure to the static library's xcconfig.
24
25 2014-01-30  David Farler  <dfarler@apple.com>
26
27         DumpRenderTree fails to build with ASAN: -fsanitize=address passed to static DRT target
28         https://bugs.webkit.org/show_bug.cgi?id=127935
29
30         Reviewed by Andy Estes.
31
32         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
33         Clear OTHER_LDFLAGS at the project level for the static library target.
34         No other linker flags were inherited from DebugRelease.
35
36 2014-01-30  David Farler  <dfarler@apple.com>
37
38         package-root shouldn't prefix simulator roots with the SDK path
39         http://bugs.webkit.org/show_bug.cgi?id=127923
40
41         Reviewed by Dan Bernstein.
42
43         * Scripts/package-root: Don't add an install path prefix.
44
45 2014-01-30  Gabor Rapcsanyi  <rgabor@webkit.org>
46
47         Add ARM EFL Linux builder bots to Apple buildmaster
48         https://bugs.webkit.org/show_bug.cgi?id=127472
49
50         Reviewed by Csaba Osztrogonác.
51
52         There is no ARM buildslaves after removing the Qt builders.
53
54         * BuildSlaveSupport/build.webkit.org-config/config.json:
55
56 2014-01-30  Andy Estes  <aestes@apple.com>
57
58         REGRESSION (r163037): WebKit2.PageLoadBasic API test failing on Mountain Lion
59         https://bugs.webkit.org/show_bug.cgi?id=127934
60
61         Disable the failing test on Mountain Lion.
62
63         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
64         (TestWebKitAPI::TEST):
65
66 2014-01-30  Anders Carlsson  <andersca@apple.com>
67
68         Add WKNavigationDelegate class
69         https://bugs.webkit.org/show_bug.cgi?id=127927
70
71         Reviewed by Dan Bernstein.
72
73         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
74         (TEST):
75
76 2014-01-30  David Farler  <dfarler@apple.com>
77
78         Enable iOS Tools builds by default
79         https://bugs.webkit.org/show_bug.cgi?id=127919
80
81         Reviewed by Andy Estes.
82
83         * Makefile:
84         Build all the tools except MiniBrowser on iOS
85         * Scripts/build-webkit:
86         Ditto.
87         Build WebKitTestRunnerApp target on iOS.
88
89 2014-01-30  David Farler  <dfarler@apple.com>
90
91         Make TestWebKitAPI build and run for iOS
92         https://bugs.webkit.org/show_bug.cgi?id=127925
93
94         Reviewed by Andy Estes.
95
96         * TestWebKitAPI/Configurations/Base.xcconfig:
97         - Don't warn on 64-32 bit conversion on x86_64 and arm64
98         - Don't build mac/*
99         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
100         - Link WebKit2 on all platforms
101
102 2014-01-30  David Farler  <dfarler@apple.com>
103
104         package-root should copy ./usr from the build products directory
105         https://bugs.webkit.org/show_bug.cgi?id=127878
106
107         Reviewed by Daniel Bates.
108
109         * Scripts/package-root:
110         Copy ./usr in addition to the frameworks.
111
112 2014-01-30  Andrei Bucur  <abucur@adobe.com>
113
114         Remove the ACCELERATED_COMPOSITING flag
115         https://bugs.webkit.org/show_bug.cgi?id=127833
116
117         Reviewed by Antti Koivisto.
118
119         Remove the USE(ACCELERATED_COMPOSITING) conditionals from the code base and make AC
120         mandatory.
121
122         * DumpRenderTree/efl/DumpRenderTree.cpp:
123         (initEcoreEvas):
124         * EWebLauncher/main.c:
125         (windowCreate):
126         * MiniBrowser/efl/main.c:
127         (elm_main):
128         * TestWebKitAPI/efl/PlatformWebView.cpp:
129         (TestWebKitAPI::initEcoreEvas):
130         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
131         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
132         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
133         (WTR::initEcoreEvas):
134
135 2014-01-29  Csaba Osztrogonác  <ossy@webkit.org>
136
137         Remove ENABLE(JAVASCRIPT_DEBUGGER) leftovers
138         https://bugs.webkit.org/show_bug.cgi?id=127845
139
140         Reviewed by Joseph Pecoraro.
141
142         * Scripts/webkitperl/FeatureList.pm:
143
144 2014-01-29  Anders Carlsson  <andersca@apple.com>
145
146         -[WKWebView loadRequest:] should return a WKNavigation
147         https://bugs.webkit.org/show_bug.cgi?id=127873
148
149         Reviewed by Dan Bernstein.
150
151         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
152         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm: Added.
153         (TEST):
154
155 2014-01-29  Tim Horton  <timothy_horton@apple.com>
156
157         WebKit2 View Gestures (Swipe): Update rubberBandsAt{Left,Right} when WebKit swipe is enabled
158         https://bugs.webkit.org/show_bug.cgi?id=127855
159         <rdar://problem/15933878>
160
161         Reviewed by Anders Carlsson.
162
163         * MiniBrowser/mac/WK2BrowserWindowController.m:
164         (-[WK2BrowserWindowController awakeFromNib]):
165         Enable swipe in MiniBrowser for testing purposes.
166
167 2014-01-29  Daniel Bates  <dabates@apple.com>
168
169         Fix JSONP requests made by the WebKit Bot Watcher's Dashboard following <http://trac.webkit.org/changeset/163034>
170         (https://bugs.webkit.org/show_bug.cgi?id=127784)
171
172         Use dot-notation instead of array index notation to access the dictionary value for key jsonpCallbackName
173         in the specified options dictionary.
174
175         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
176         (JSON.load):
177
178 2014-01-29  Daniel Bates  <dabates@apple.com>
179
180         WebKit Bot Watcher's Dashboard: Add support for using HTTP authentication with Buildbot
181         https://bugs.webkit.org/show_bug.cgi?id=127784
182
183         Reviewed by Alexey Proskuryakov.
184
185         Implement support for querying a Buildbot that requires HTTP authentication to access it.
186
187         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
188         (Buildbot): Add optional argument, options, to pass a dictionary of Buildbot options.
189         For now, we only support a single option, needsAuthentication, to indicate whether the
190         Buildbots requires HTTP authentication (defaults to false - HTTP authentication is
191         not required).
192         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
193         (BuildbotIteration.prototype.loadLayoutTestResults): Modified to pass JSONP callback name
194         to JSON.load() using the option dictionary.
195         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
196         (BuildbotQueue.prototype.update): Modified to pass withCredentials to JSON.load().
197         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
198         (JSON.load): Removed optional argument jsonpCallbackName and added optional argument options,
199         which is a dictionary. The argument jsonpCallbackName is now specified as an entry in the
200         options dictionary. Added boolean options withCredentials to toggle querying with HTTP
201         authentication credentials.
202
203 2014-01-29  Alexey Proskuryakov  <ap@apple.com>
204
205         build.webkit.org/dashboard links to an old failing build rather than the most recent
206         https://bugs.webkit.org/show_bug.cgi?id=127765
207         <rdar://problem/15795228>
208
209         Reviewed by Timothy Hatcher.
210
211         This patch changes builder view to not show how many failures there were in a row,
212         because it is not very relevant, and complicates the UI. Instead, we just show the
213         latest failing build and the latest successful one.
214
215         The patch also removes commit history popovers from revisions that can not be correlated
216         with any change. These popovers are only helpful in the first line, when there is
217         another line for comparison below. In this case, it's useful to see what changed
218         between the revisions, but even then, only if it was an actual failure, not a buildbot
219         exception.
220
221         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
222         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
223         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
224         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
225         (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
226         (BuildbotQueueView.prototype._revisionPopoverContentForIteration):
227         (BuildbotQueueView.prototype.revisionContentForIteration):
228         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
229         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
230
231 2014-01-29  Csaba Osztrogonác  <ossy@webkit.org>
232
233         Remove ENABLE(JAVASCRIPT_DEBUGGER) guards
234         https://bugs.webkit.org/show_bug.cgi?id=127840
235
236         Reviewed by Mark Lam.
237
238         * Scripts/webkitperl/FeatureList.pm:
239
240 2014-01-29  Krzysztof Czech  <k.czech@samsung.com>
241
242         [ATK] Expose aria-describedby with ATK_RELATION_DESCRIBED_BY
243         https://bugs.webkit.org/show_bug.cgi?id=121684
244
245         Reviewed by Mario Sanchez Prada.
246
247         Implementing helpText by using relation ATK_RELATION_DESCRIBED_BY.
248
249         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
250         (AccessibilityUIElement::helpText):
251         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
252         (WTR::AccessibilityUIElement::helpText):
253
254 2014-01-27  Chris Fleizach  <cfleizach@apple.com>
255
256         AX: Support @scope in HTML tables
257         https://bugs.webkit.org/show_bug.cgi?id=127688
258
259         Reviewed by Mario Sanchez Prada.
260
261         Add support for rowHeaders and columnHeaders.
262
263         * DumpRenderTree/AccessibilityUIElement.cpp:
264         (convertElementsToObjectArray):
265         (columnHeadersCallback):
266         (rowHeadersCallback):
267         (uiElementArrayAttributeValueCallback):
268         (AccessibilityUIElement::columnHeaders):
269         (AccessibilityUIElement::rowHeaders):
270         (AccessibilityUIElement::getJSClass):
271         * DumpRenderTree/AccessibilityUIElement.h:
272         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
273         (AccessibilityUIElement::rowHeaders):
274         (AccessibilityUIElement::columnHeaders):
275         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
276         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
277         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
278         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
279         (WTR::AccessibilityUIElement::rowHeaders):
280         (WTR::AccessibilityUIElement::columnHeaders):
281         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
282         (WTR::convertElementsToObjectArray):
283         (WTR::AccessibilityUIElement::rowHeaders):
284         (WTR::AccessibilityUIElement::columnHeaders):
285         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
286
287 2014-01-28  Daniel Bates  <dabates@apple.com>
288
289         Teach Buildbot dashboard to parse alternative revision format
290         https://bugs.webkit.org/show_bug.cgi?id=127561
291
292         Reviewed by Alexey Proskuryakov.
293
294         Add support for extracting the OpenSource and Internal revision numbers when Buildbot
295         returns a dictionary for the value of property got_revision.
296
297         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
298         (isMultiCodebaseGotRevisionProperty): Added.
299         (parseRevisionProperty): Added; parses Buildbot revision property, which can either be a
300         string or a dictionary.
301         (BuildbotIteration.prototype.update.): Modified to call parseRevisionProperty() to determine
302         the OpenSource and Internal revision numbers.
303
304 2014-01-28  Adrian Perez de Castro  <aperez@igalia.com>
305
306         [GTK] Add API to allow setting the process model in WebKitWebContext
307         https://bugs.webkit.org/show_bug.cgi?id=125463
308
309         Reviewed by Carlos Garcia Campos.
310
311         Implements accessors in WebKitWebContext for the process model.
312         The default behavior is unchanged, and a single web process is
313         used. Using WEBKIT_PROCESS_MODEL_ONE_SECONDARY_PROCESS_PER_WEB_VIEW
314         as the process model will make use one web process for each
315         WebKitWebView. This also enables the network process. Setting
316         the process model must be done as early as possible, before the
317         very first web process is spawned.
318
319         * MiniBrowser/gtk/main.c:
320         (main):
321         Enable multiple process mode if the MINIBROWSER_MULTIPROCESS
322         environment variable is defined and not empty.
323         * TestWebKitAPI/GNUmakefile.am:
324         Add new TestMultiprocess test case.
325         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
326         Add new TestMultiprocess test case.
327         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp: Added.
328         (loadChanged):
329         (testMultipleSecondaryProcesses):
330         (initializeWebExtensions):
331         (beforeAll):
332         (afterAll):
333         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
334         (methodCallCallback):
335         Implement the GetProcessIdentifier D-Bus method.
336         (makeBusName):
337         Choose a different bus name when the web extension is used
338         from TestMultiprocess.
339         (webkit_web_extension_initialize_with_user_data):
340         Use makeBusName() to choose the bus name.
341
342 2014-01-28  Carlos Garcia Campos  <cgarcia@igalia.com>
343
344         [SOUP] Remove soupURIToKURL
345         https://bugs.webkit.org/show_bug.cgi?id=127104
346
347         Reviewed by Martin Robinson.
348
349         * TestWebKitAPI/GNUmakefile.am: Add soup cppflags to WebCore unit
350         tests, because URL.h now includes GUniquePtrSoup.h.
351         * TestWebKitAPI/CMakeLists.txt: Ditto.
352         * WebKitTestRunner/PlatformEfl.cmake: Add soup cppflags to WTR,
353         because URL.h now includes GUniquePtrSoup.h.
354
355 2014-01-27  Carlos Garcia Campos  <cgarcia@igalia.com>
356
357         [GTK] Make webkit_uri_scheme_request_get_web_view() work with CustomProtocols
358         https://bugs.webkit.org/show_bug.cgi?id=127614
359
360         Reviewed by Gustavo Noronha Silva.
361
362         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: Bring
363         back the custom URI scheme WebView check.
364
365 2014-01-27  Tim Horton  <timothy_horton@apple.com>
366
367         Revert yet one more tiny part of r162629 that didn't get reverted in r162883
368
369         * WebKitTestRunner/TestController.cpp:
370         (WTR::TestController::pluginLoadPolicy):
371         * WebKitTestRunner/TestController.h:
372
373 2014-01-27  Tim Horton  <timothy_horton@apple.com>
374
375         Revert one more tiny part of r162629 that didn't get reverted in r162883.
376
377         ... which was also causing test failures!
378
379         * WebKitTestRunner/TestController.cpp:
380         (WTR::TestController::createWebViewWithOptions):
381
382 2014-01-27  David Farler  <dfarler@apple.com>
383
384         iOS DumpRenderTree.app dies loading fonts
385         https://bugs.webkit.org/show_bug.cgi?id=127730
386
387         Reviewed by Daniel Bates.
388
389         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
390         - Add Ahem to the __DATA section
391         * DumpRenderTree/mac/DumpRenderTree.mm:
392         (activateFontsIOS):
393         - Load "WeightWatcher100" instead.
394
395 2014-01-27  Alexey Proskuryakov  <ap@apple.com>
396
397         [Mac] Extra logging output from run-safari --no-saved-state
398         https://bugs.webkit.org/show_bug.cgi?id=127732
399
400         Reviewed by Daniel Bates.
401
402         * Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp): Use an option that
403         disables saved state without logging.
404
405 2014-01-27  Tim Horton  <timothy_horton@apple.com>
406
407         Revert the parts of r162629 that add a new pluginLoadPolicy and the context menu item.
408
409         We're leaving the parts that make us use PDFPlugin instead of showing the blocked
410         plugin indicator intact, though.
411
412         * WebKitTestRunner/TestController.cpp:
413         (WTR::TestController::createWebViewWithOptions):
414
415 2014-01-27  Andy Estes  <aestes@apple.com>
416
417         Scrub WebKit API headers of WTF macros
418         https://bugs.webkit.org/show_bug.cgi?id=127706
419
420         Reviewed by David Kilzer.
421
422         * Scripts/check-for-inappropriate-macros-in-external-headers: Modified
423         the regex to require a '(' after the macro name in order to be
424         considered a match. This prevents things like 'ENABLE_SOME_FEATURE'
425         from being flagged as an ENABLE() macro.
426
427 2014-01-27  Commit Queue  <commit-queue@webkit.org>
428
429         Unreviewed, rolling out r162846.
430         http://trac.webkit.org/changeset/162846
431         https://bugs.webkit.org/show_bug.cgi?id=127695
432
433         "Broke the WebKit Bot Watcher's Dashboard; will fix offline"
434         (Requested by dydz on #webkit).
435
436         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
437         (BuildbotIteration.prototype.update.):
438
439 2014-01-27  Daniel Bates  <dabates@apple.com>
440
441         Add support for displaying results from multiple Buildbots on WebKit Bot Watcher's Dashboard
442         https://bugs.webkit.org/show_bug.cgi?id=127564
443
444         Reviewed by Alexey Proskuryakov.
445
446         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
447         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
448
449 2014-01-27  Daniel Bates  <dabates@apple.com>
450
451         Teach Buildbot dashboard to parse alternative revision format
452         https://bugs.webkit.org/show_bug.cgi?id=127561
453
454         Reviewed by Alexey Proskuryakov.
455
456         Add support for extracting the OpenSource and Internal revision numbers when Buildbot
457         returns a dictionary for the value of property got_revision.
458
459         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
460         (parseRevisionProperty): Added; parses Buildbot revision property, which can either be a
461         string or a dictionary.
462         (BuildbotIteration.prototype.update.): Modified to call parseRevisionProperty() to determine
463         the OpenSource and Internal revision numbers.
464
465 2014-01-27  Carlos Garcia Campos  <cgarcia@igalia.com>
466
467         [GTK] Implement custom URI schemes with CustomProtocols
468         https://bugs.webkit.org/show_bug.cgi?id=127091
469
470         Reviewed by Gustavo Noronha Silva.
471
472         Temporarily disable the WebKitWebView check until we figure out
473         how to implement it with CustomProtocols.
474
475         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
476
477 2014-01-26  Alexey Proskuryakov  <ap@apple.com>
478
479         REGRESSION(r127412): http/tests/misc/link-rel-icon-beforeload.html is broken.
480
481         * DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::setIconDatabaseEnabled):
482         Fixed an incorrect ifdef.
483
484 2014-01-26  Brendan Long  <b.long@cablelabs.com>
485
486         [GTK] DumpRenderTree prints out suggesting to set WEBKIT_TOP_LEVEL when fonts are missing but doesn't use it.
487         https://bugs.webkit.org/show_bug.cgi?id=110602
488
489         Reviewed by Philippe Normand.
490
491         * DumpRenderTree/gtk/DumpRenderTree.cpp:
492         (getTopLevelPath): Use WEBKIT_TOP_LEVEL environment variable if it exists.
493         (initializeFonts): Fix printing of expected font path (fontPath is guaranteed to be null here).
494
495 2014-01-24  Andy Estes  <aestes@apple.com>
496
497         [iOS] Upstream changes in Tools/DumpRenderTree
498         https://bugs.webkit.org/show_bug.cgi?id=127412
499
500         Reviewed by Simon Fraser.
501
502         Upstream all iOS changes. Added a new target called DumpRenderTree.app,
503         which builds the DumpRenderTree static library into an app bundle as
504         expected by the iOS Simulator.
505
506         * DumpRenderTree/AccessibilityTextMarker.h:
507         * DumpRenderTree/AccessibilityUIElement.h:
508         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
509         * DumpRenderTree/DumpRenderTreeFileDraggingSource.h:
510         * DumpRenderTree/DumpRenderTreePrefix.h:
511         * DumpRenderTree/PixelDumpSupport.cpp:
512         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
513         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
514         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
515         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
516         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
517         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
518         * DumpRenderTree/TestNetscapePlugIn/TestObject.h:
519         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp:
520         * DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSAfterRemovingPluginElement.cpp:
521         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
522         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp:
523         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:
524         * DumpRenderTree/TestNetscapePlugIn/Tests/NullNPPGetValuePointer.cpp:
525         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
526         * DumpRenderTree/TestNetscapePlugIn/Tests/PluginScriptableNPObjectInvokeDefault.cpp:
527         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
528         * DumpRenderTree/TestRunner.cpp:
529         * DumpRenderTree/TestRunner.h:
530         * DumpRenderTree/cg/ImageDiffCG.cpp:
531         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
532         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
533         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
534         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h: Added.
535         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm: Added.
536         * DumpRenderTree/ios/Info.plist: Added.
537         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport.c: Added.
538         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Added.
539         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Added.
540         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Changes: Added.
541         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/IPhoneSimulatorNotification.xs: Added.
542         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/MANIFEST: Added.
543         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL: Added.
544         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/README: Added.
545         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm: Added.
546         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/ppport.h: Added.
547         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/t/IPhoneSimulatorNotification.t: Added.
548         * DumpRenderTree/ios/PerlSupport/Makefile: Added.
549         * DumpRenderTree/ios/PixelDumpSupportIOS.mm: Added.
550         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
551         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
552         * DumpRenderTree/mac/AppleScriptController.m:
553         * DumpRenderTree/mac/Configurations/Base.xcconfig:
554         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
555         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
556         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Added.
557         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig:
558         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
559         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig: Added.
560         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
561         * DumpRenderTree/mac/DumpRenderTree.mm:
562         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
563         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
564         * DumpRenderTree/mac/DumpRenderTreeMac.h:
565         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
566         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
567         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
568         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
569         * DumpRenderTree/mac/EditingDelegate.h:
570         * DumpRenderTree/mac/EventSendingController.h:
571         * DumpRenderTree/mac/EventSendingController.mm:
572         * DumpRenderTree/mac/FrameLoadDelegate.mm:
573         * DumpRenderTree/mac/HistoryDelegate.h:
574         * DumpRenderTree/mac/LayoutTestHelper.m:
575         * DumpRenderTree/mac/MockGeolocationProvider.mm:
576         * DumpRenderTree/mac/NavigationController.h:
577         * DumpRenderTree/mac/ObjCPlugin.h:
578         * DumpRenderTree/mac/ObjCPlugin.m:
579         * DumpRenderTree/mac/ObjCPluginFunction.h:
580         * DumpRenderTree/mac/PolicyDelegate.h:
581         * DumpRenderTree/mac/ResourceLoadDelegate.h:
582         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
583         * DumpRenderTree/mac/TestRunnerMac.mm:
584         * DumpRenderTree/mac/TextInputController.h:
585         * DumpRenderTree/mac/TextInputController.m:
586         * DumpRenderTree/mac/UIDelegate.h:
587         * DumpRenderTree/mac/UIDelegate.mm:
588
589 2014-01-25  Darin Adler  <darin@apple.com>
590
591         Call deprecatedCharacters instead of characters at more call sites
592         https://bugs.webkit.org/show_bug.cgi?id=127631
593
594         Reviewed by Sam Weinig.
595
596         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
597         (TestWebKitAPI::expectBuilderContent):
598         (TestWebKitAPI::expectEmpty):
599         (TestWebKitAPI::TEST):
600         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
601         (TestWebKitAPI::TEST):
602         Use the new name.
603
604 2014-01-25  Anders Carlsson  <andersca@apple.com>
605
606         Modernize HashTable threading code
607         https://bugs.webkit.org/show_bug.cgi?id=127621
608
609         Reviewed by Darin Adler.
610
611         Explicitly include headers that used to be brought in by HashTable.h
612
613         * DumpRenderTree/JavaScriptThreading.cpp:
614
615 2014-01-24  Eric Carlson  <eric.carlson@apple.com>
616
617         Unreviewed. Add Philip Jägenstedt to watch and contributor lists.
618
619         * Scripts/webkitpy/common/config/contributors.json:
620         * Scripts/webkitpy/common/config/watchlist:
621
622 2014-01-23  David Farler  <dfarler@apple.com>
623
624         Make WebKitTestRunner work with iOS
625         https://bugs.webkit.org/show_bug.cgi?id=127448
626
627         Reviewed by Simon Fraser.
628
629         Combined patch from Simon below with some additional xcconfig cleanups,
630         rebasing and stubbing out a couple of new functions that popped up
631         since then.
632
633         2013-12-03  Simon Fraser  <simon.fraser@apple.com>
634
635                 <rdar://problem/15515469> Get WebKitTestRunner working on iOS
636
637                 Get WebKitTestRunner limping on iOS. Main parts:
638                 - Stub out lots of accessibility-related functions.
639                 - Stub out EventSender
640                 - Create target to make a bundled app that runs in the simulator,
641                   and copy the injected bundle library into it.
642                 - Make a UIWindow and WKView to load tests in
643
644                 It runs, load tests, and dumps results to output. More work will be
645                 required once we can execute it via the webkitpy scripts.
646
647         * WebKitTestRunner/Configurations/Base.xcconfig:
648         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
649         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
650         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
651         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm: Added.
652         (WTR::AccessibilityController::addNotificationListener):
653         (WTR::AccessibilityController::removeNotificationListener):
654         (WTR::AccessibilityController::platformName):
655         (WTR::AccessibilityController::logAccessibilityEvents):
656         (WTR::AccessibilityController::resetToConsistentState):
657         (WTR::findAccessibleObjectById):
658         (WTR::AccessibilityController::accessibleElementById):
659         * WebKitTestRunner/InjectedBundle/ios/AccessibilityNotificationHandler.h: Added.
660         * WebKitTestRunner/InjectedBundle/ios/AccessibilityTextMarkerIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
661         (WTR::AccessibilityTextMarker::isEqual):
662         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm: Added.
663         (WTR::AccessibilityUIElement::AccessibilityUIElement):
664         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
665         (WTR::AccessibilityUIElement::isEqual):
666         (WTR::AccessibilityUIElement::getLinkedUIElements):
667         (WTR::AccessibilityUIElement::getDocumentLinks):
668         (WTR::AccessibilityUIElement::getChildren):
669         (WTR::AccessibilityUIElement::getChildrenWithRange):
670         (WTR::AccessibilityUIElement::childrenCount):
671         (WTR::AccessibilityUIElement::elementAtPoint):
672         (WTR::AccessibilityUIElement::indexOfChild):
673         (WTR::AccessibilityUIElement::childAtIndex):
674         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
675         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
676         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
677         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
678         (WTR::AccessibilityUIElement::rowAtIndex):
679         (WTR::AccessibilityUIElement::selectedChildAtIndex):
680         (WTR::AccessibilityUIElement::selectedChildrenCount):
681         (WTR::AccessibilityUIElement::selectedRowAtIndex):
682         (WTR::AccessibilityUIElement::titleUIElement):
683         (WTR::AccessibilityUIElement::parentElement):
684         (WTR::AccessibilityUIElement::disclosedByRow):
685         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
686         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
687         (WTR::AccessibilityUIElement::attributesOfChildren):
688         (WTR::AccessibilityUIElement::allAttributes):
689         (WTR::AccessibilityUIElement::stringAttributeValue):
690         (WTR::AccessibilityUIElement::numberAttributeValue):
691         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
692         (WTR::AccessibilityUIElement::uiElementAttributeValue):
693         (WTR::AccessibilityUIElement::boolAttributeValue):
694         (WTR::AccessibilityUIElement::isAttributeSettable):
695         (WTR::AccessibilityUIElement::isAttributeSupported):
696         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
697         (WTR::AccessibilityUIElement::role):
698         (WTR::AccessibilityUIElement::subrole):
699         (WTR::AccessibilityUIElement::roleDescription):
700         (WTR::AccessibilityUIElement::title):
701         (WTR::AccessibilityUIElement::description):
702         (WTR::AccessibilityUIElement::orientation):
703         (WTR::AccessibilityUIElement::stringValue):
704         (WTR::AccessibilityUIElement::language):
705         (WTR::AccessibilityUIElement::helpText):
706         (WTR::AccessibilityUIElement::x):
707         (WTR::AccessibilityUIElement::y):
708         (WTR::AccessibilityUIElement::width):
709         (WTR::AccessibilityUIElement::height):
710         (WTR::AccessibilityUIElement::clickPointX):
711         (WTR::AccessibilityUIElement::clickPointY):
712         (WTR::AccessibilityUIElement::intValue):
713         (WTR::AccessibilityUIElement::minValue):
714         (WTR::AccessibilityUIElement::maxValue):
715         (WTR::AccessibilityUIElement::valueDescription):
716         (WTR::AccessibilityUIElement::insertionPointLineNumber):
717         (WTR::AccessibilityUIElement::isPressActionSupported):
718         (WTR::AccessibilityUIElement::isIncrementActionSupported):
719         (WTR::AccessibilityUIElement::isDecrementActionSupported):
720         (WTR::AccessibilityUIElement::isEnabled):
721         (WTR::AccessibilityUIElement::isRequired):
722         (WTR::AccessibilityUIElement::isFocused):
723         (WTR::AccessibilityUIElement::isSelected):
724         (WTR::AccessibilityUIElement::isSelectedOptionActive):
725         (WTR::AccessibilityUIElement::isIndeterminate):
726         (WTR::AccessibilityUIElement::isExpanded):
727         (WTR::AccessibilityUIElement::isChecked):
728         (WTR::AccessibilityUIElement::hierarchicalLevel):
729         (WTR::AccessibilityUIElement::classList):
730         (WTR::AccessibilityUIElement::speak):
731         (WTR::AccessibilityUIElement::ariaIsGrabbed):
732         (WTR::AccessibilityUIElement::ariaDropEffects):
733         (WTR::AccessibilityUIElement::lineForIndex):
734         (WTR::AccessibilityUIElement::rangeForLine):
735         (WTR::AccessibilityUIElement::rangeForPosition):
736         (WTR::AccessibilityUIElement::boundsForRange):
737         (WTR::AccessibilityUIElement::stringForRange):
738         (WTR::AccessibilityUIElement::attributedStringForRange):
739         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
740         (WTR::uiElementCountForSearchPredicate):
741         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
742         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
743         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
744         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
745         (WTR::AccessibilityUIElement::attributesOfColumns):
746         (WTR::AccessibilityUIElement::attributesOfRows):
747         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
748         (WTR::AccessibilityUIElement::attributesOfHeader):
749         (WTR::AccessibilityUIElement::rowCount):
750         (WTR::AccessibilityUIElement::columnCount):
751         (WTR::AccessibilityUIElement::indexInTable):
752         (WTR::AccessibilityUIElement::rowIndexRange):
753         (WTR::AccessibilityUIElement::columnIndexRange):
754         (WTR::AccessibilityUIElement::cellForColumnAndRow):
755         (WTR::AccessibilityUIElement::horizontalScrollbar):
756         (WTR::AccessibilityUIElement::verticalScrollbar):
757         (WTR::AccessibilityUIElement::scrollToMakeVisible):
758         (WTR::AccessibilityUIElement::selectedTextRange):
759         (WTR::AccessibilityUIElement::setSelectedTextRange):
760         (WTR::AccessibilityUIElement::increment):
761         (WTR::AccessibilityUIElement::decrement):
762         (WTR::AccessibilityUIElement::showMenu):
763         (WTR::AccessibilityUIElement::press):
764         (WTR::AccessibilityUIElement::setSelectedChild):
765         (WTR::AccessibilityUIElement::accessibilityValue):
766         (WTR::AccessibilityUIElement::documentEncoding):
767         (WTR::AccessibilityUIElement::documentURI):
768         (WTR::AccessibilityUIElement::url):
769         (WTR::AccessibilityUIElement::addNotificationListener):
770         (WTR::AccessibilityUIElement::removeNotificationListener):
771         (WTR::AccessibilityUIElement::isFocusable):
772         (WTR::AccessibilityUIElement::isSelectable):
773         (WTR::AccessibilityUIElement::isMultiSelectable):
774         (WTR::AccessibilityUIElement::isVisible):
775         (WTR::AccessibilityUIElement::isOffScreen):
776         (WTR::AccessibilityUIElement::isCollapsed):
777         (WTR::AccessibilityUIElement::isIgnored):
778         (WTR::AccessibilityUIElement::hasPopup):
779         (WTR::AccessibilityUIElement::takeFocus):
780         (WTR::AccessibilityUIElement::takeSelection):
781         (WTR::AccessibilityUIElement::addSelection):
782         (WTR::AccessibilityUIElement::removeSelection):
783         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
784         (WTR::AccessibilityUIElement::textMarkerRangeLength):
785         (WTR::AccessibilityUIElement::previousTextMarker):
786         (WTR::AccessibilityUIElement::nextTextMarker):
787         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
788         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
789         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
790         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
791         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
792         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
793         (WTR::AccessibilityUIElement::textMarkerForPoint):
794         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
795         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
796         (WTR::AccessibilityUIElement::indexForTextMarker):
797         (WTR::AccessibilityUIElement::isTextMarkerValid):
798         (WTR::AccessibilityUIElement::textMarkerForIndex):
799         (WTR::AccessibilityUIElement::startTextMarker):
800         (WTR::AccessibilityUIElement::endTextMarker):
801         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
802         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
803         (WTR::AccessibilityUIElement::pathDescription):
804         (WTR::AccessibilityUIElement::supportedActions):
805         * WebKitTestRunner/InjectedBundle/ios/ActivateFontsIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
806         (WTR::activateFonts):
807         * WebKitTestRunner/InjectedBundle/ios/EventSenderProxyIOS.mm: Added.
808         (WTR::EventSenderProxy::EventSenderProxy):
809         (WTR::EventSenderProxy::~EventSenderProxy):
810         (WTR::EventSenderProxy::updateClickCountForButton):
811         (WTR::EventSenderProxy::mouseDown):
812         (WTR::EventSenderProxy::mouseUp):
813         (WTR::EventSenderProxy::mouseMoveTo):
814         (WTR::EventSenderProxy::leapForward):
815         (WTR::EventSenderProxy::keyDown):
816         (WTR::EventSenderProxy::mouseScrollBy):
817         (WTR::EventSenderProxy::continuousMouseScrollBy):
818         (WTR::EventSenderProxy::addTouchPoint):
819         (WTR::EventSenderProxy::updateTouchPoint):
820         (WTR::EventSenderProxy::setTouchModifier):
821         (WTR::EventSenderProxy::setTouchPointRadius):
822         (WTR::EventSenderProxy::touchStart):
823         (WTR::EventSenderProxy::touchMove):
824         (WTR::EventSenderProxy::touchEnd):
825         (WTR::EventSenderProxy::touchCancel):
826         (WTR::EventSenderProxy::clearTouchPoints):
827         (WTR::EventSenderProxy::releaseTouchPoint):
828         (WTR::EventSenderProxy::cancelTouchPoint):
829         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
830         (WTR::InjectedBundle::platformInitialize):
831         * WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
832         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
833         * WebKitTestRunner/Makefile:
834         * WebKitTestRunner/TestController.cpp:
835         (WTR::TestController::initialize):
836         * WebKitTestRunner/TestController.h:
837         * WebKitTestRunner/TestInvocation.cpp:
838         (WTR::TestInvocation::invoke):
839         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
840         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
841         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Added.
842         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Added.
843         (-[AppDelegate application:didFinishLaunchingWithOptions:]):
844         (-[AppDelegate applicationWillResignActive:]):
845         (-[AppDelegate applicationDidEnterBackground:]):
846         (-[AppDelegate applicationWillEnterForeground:]):
847         (-[AppDelegate applicationDidBecomeActive:]):
848         (-[AppDelegate applicationWillTerminate:]):
849         * WebKitTestRunner/WebKitTestRunnerApp/Images.xcassets/AppIcon.appiconset/Contents.json: Added.
850         * WebKitTestRunner/WebKitTestRunnerApp/Images.xcassets/LaunchImage.launchimage/Contents.json: Added.
851         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist: Added.
852         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Prefix.pch: Added.
853         * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Added.
854         * WebKitTestRunner/WebKitTestRunnerApp/main.m: Added.
855         (main):
856         * WebKitTestRunner/WebKitTestRunnerAppTests-Info.plist: Added.
857         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests-Info.plist: Added.
858         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests.m: Added.
859         (-[WebKitTestRunnerAppTests setUp]):
860         (-[WebKitTestRunnerAppTests tearDown]):
861         (-[WebKitTestRunnerAppTests testExample]):
862         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj/InfoPlist.strings: Added.
863         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
864         * WebKitTestRunner/cg/TestInvocationCG.cpp:
865         * WebKitTestRunner/iOS.xcconfig: Added.
866         * WebKitTestRunner/ios/PlatformWebViewIOS.mm: Added.
867         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useTiledDrawing:]):
868         (-[TestRunnerWKView _shouldUseTiledDrawingArea]):
869         (-[WebKitTestRunnerWindow isKeyWindow]):
870         (-[WebKitTestRunnerWindow setFrameOrigin:]):
871         (-[WebKitTestRunnerWindow setFrame:]):
872         (-[WebKitTestRunnerWindow frameRespectingFakeOrigin]):
873         (-[WebKitTestRunnerWindow backingScaleFactor]):
874         (WTR::PlatformWebView::PlatformWebView):
875         (WTR::PlatformWebView::resizeTo):
876         (WTR::PlatformWebView::~PlatformWebView):
877         (WTR::PlatformWebView::page):
878         (WTR::PlatformWebView::focus):
879         (WTR::PlatformWebView::windowFrame):
880         (WTR::PlatformWebView::setWindowFrame):
881         (WTR::PlatformWebView::didInitializeClients):
882         (WTR::PlatformWebView::addChromeInputField):
883         (WTR::PlatformWebView::removeChromeInputField):
884         (WTR::PlatformWebView::makeWebViewFirstResponder):
885         (WTR::PlatformWebView::windowSnapshotImage):
886         (WTR::PlatformWebView::viewSupportsOptions):
887         * WebKitTestRunner/ios/TestControllerIOS.mm: Added.
888         (WTR::TestController::notifyDone):
889         (WTR::TestController::platformInitialize):
890         (WTR::TestController::platformDestroy):
891         (WTR::TestController::initializeInjectedBundlePath):
892         (WTR::TestController::initializeTestPluginDirectory):
893         (WTR::TestController::platformRunUntil):
894         (WTR::TestController::platformInitializeContext):
895         (WTR::TestController::runModal):
896         (WTR::TestController::platformLibraryPathForTesting):
897         * WebKitTestRunner/ios/WebArchiveDumpSupportIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
898         (createCFURLResponseFromResponseData):
899         (supportedNonImageMIMETypes):
900         * WebKitTestRunner/ios/mainIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
901         (-[WebKitTestRunnerApp _runTestController]):
902         (-[WebKitTestRunnerApp applicationDidFinishLaunching:]):
903         (main):
904
905 2014-01-24  Enrique Ocaña González  <eocanha@igalia.com>
906
907         [GTK] Put cache files in XDG_CACHE_HOME
908         https://bugs.webkit.org/show_bug.cgi?id=123458
909
910         Reviewed by Martin Robinson.
911
912         * GtkLauncher/main.c:
913         (createBrowser):
914
915 2014-01-23  Max Vujovic  <mvujovic@adobe.com>
916
917         Remove CSS Custom Filters code and tests
918         https://bugs.webkit.org/show_bug.cgi?id=127382
919
920         Reviewed by Simon Fraser.
921
922         * DumpRenderTree/gtk/DumpRenderTree.cpp:
923         (resetDefaultsToConsistentValues):
924         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
925         (TestRunner::overridePreference):
926
927 2014-01-23  Tim Horton  <timothy_horton@apple.com>
928
929         PDFPlugin: Use PDFPlugin even if there's an external plugin installed, if it's blocked
930         https://bugs.webkit.org/show_bug.cgi?id=127415
931         <rdar://problem/12482452>
932
933         Reviewed by Sam Weinig.
934
935         Adopt the new page loader client plugin load callback.
936
937         * WebKitTestRunner/TestController.cpp:
938         (WTR::TestController::createWebViewWithOptions):
939         (WTR::TestController::pluginLoadPolicy):
940         * WebKitTestRunner/TestController.h:
941
942 2014-01-23  peavo@outlook.com  <peavo@outlook.com>
943
944         [Curl] There is no way to specify cache folder.
945         https://bugs.webkit.org/show_bug.cgi?id=125028
946
947         Reviewed by Brent Fulgham.
948
949         Enable disc cache in WinLauncher by setting cache folder location.
950
951         * WinLauncher/WinLauncher.cpp:
952         (getAppDataFolder): Added function to get app data folder.
953         (setCacheFolder): Added function to set cache folder.
954         (createCrashReport): Use new getAppDataFolder function.
955         (wWinMain): Use function setCacheFolder to set cache folder location.
956
957 2014-01-23  Daniel Bates  <dabates@apple.com>
958
959         build-webkit --sdk=iphonesimulator doesn't think it's building iOS
960         https://bugs.webkit.org/show_bug.cgi?id=127379
961
962         Reviewed by Simon Fraser.
963
964         Teach build-webkit to recognize --sdk=X.
965
966         Currently, build-webkit recognizes --sdk X to specify X as the Xcode SDK to use, which is also
967         considered when determining the WebKit port to build. But build-webkit advertises --sdk=X in its
968         help message. We should teach build-webkit to recognize both --sdk X and --sdk=X to make its handling
969         of --sdk more consistent with the handling of other build-webkit options that take a value (e.g. --prefix).
970
971         * Scripts/webkitdirs.pm:
972         (checkForArgumentAndRemoveFromArrayRefGettingValue): Added.
973         (checkForArgumentAndRemoveFromARGVGettingValue): Modified to call checkForArgumentAndRemoveFromArrayRefGettingValue().
974         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl: Added.
975
976 2014-01-23  Commit Queue  <commit-queue@webkit.org>
977
978         Unreviewed, rolling out r162612.
979         http://trac.webkit.org/changeset/162612
980         https://bugs.webkit.org/show_bug.cgi?id=127488
981
982         broke the build (Requested by mhahnenberg on #webkit).
983
984         * Scripts/build-jsc:
985         * jsc-cli/jsc-cli.xcodeproj/project.pbxproj: Removed.
986         * jsc-cli/jsc-cli/CLIInstance.h: Removed.
987         * jsc-cli/jsc-cli/CLIInstance.m: Removed.
988         * jsc-cli/jsc-cli/JSModule.h: Removed.
989         * jsc-cli/jsc-cli/JSModule.m: Removed.
990         * jsc-cli/jsc-cli/JSRunLoopThread.h: Removed.
991         * jsc-cli/jsc-cli/JSRunLoopThread.m: Removed.
992         * jsc-cli/jsc-cli/ReadEvalPrintLoop.h: Removed.
993         * jsc-cli/jsc-cli/ReadEvalPrintLoop.m: Removed.
994         * jsc-cli/jsc-cli/RunLoopThread.h: Removed.
995         * jsc-cli/jsc-cli/RunLoopThread.m: Removed.
996         * jsc-cli/jsc-cli/ScriptInputSource.h: Removed.
997         * jsc-cli/jsc-cli/ScriptInputSource.m: Removed.
998         * jsc-cli/jsc-cli/main.m: Removed.
999
1000 2014-01-23  Mark Hahnenberg  <mhahnenberg@apple.com>
1001
1002         Basic framework for a modern jsc CLI
1003         https://bugs.webkit.org/show_bug.cgi?id=127435
1004
1005         Reviewed by Geoffrey Garen.
1006
1007         The most basic components of a modern jsc command line interface consist of the following:
1008
1009         - A simple REPL to enter commands and receive results
1010         - The ability to define a module (which consists of various internal methods as well as a 
1011           set of externally visible methods)
1012         - The ability to load other modules at runtime
1013         - The ability to interact with the underlying platform to perform various "privileged" 
1014           functions (e.g. opening files, printing to the stdout, etc.)
1015         
1016         The basic architecture will look something like the following:
1017         - If the tool is run in REPL mode (i.e. no command line arguments), it will start the REPL 
1018           on the main thread and start a secondary thread with a run loop to handle various inputs 
1019           from the REPL thread.
1020         - If the tool is given a script to run, it will evaluate that script (and any scripts that 
1021           it might transitively load) within the run loop on the secondary thread while the main 
1022           thread blocks until it has completed.
1023
1024         * Scripts/build-jsc:
1025         * jsc-cli: Added.
1026         * jsc-cli/jsc-cli: Added.
1027         * jsc-cli/jsc-cli.xcodeproj: Added.
1028         * jsc-cli/jsc-cli.xcodeproj/project.pbxproj: Added.
1029         * jsc-cli/jsc-cli/CLIInstance.h: Added.
1030         * jsc-cli/jsc-cli/CLIInstance.m: Added.
1031         (-[CLIInstance init]):
1032         (-[CLIInstance loadFile:]):
1033         (-[CLIInstance run]):
1034         * jsc-cli/jsc-cli/JSModule.h: Added.
1035         * jsc-cli/jsc-cli/JSModule.m: Added.
1036         (coreModules):
1037         (isCoreModule):
1038         (classForModule):
1039         (coreModuleFullPath):
1040         (resolveModuleAsFile):
1041         (resolveModuleAsDirectory):
1042         (nodeModulePaths):
1043         (resolveAsNodeModule):
1044         (+[JSModule resolve:atPath:]):
1045         (globalModuleCache):
1046         (isCached):
1047         (cachedModule):
1048         (cacheModule):
1049         (+[JSModule require:atPath:]):
1050         (+[JSModule require:atPath:inContext:]):
1051         (-[JSModule platformObjectInContext:]):
1052         (-[JSModule initWithId:filename:context:]):
1053         (-[JSModule dealloc]):
1054         (-[JSModule didStartLoading]):
1055         (-[JSModule didFinishLoading]):
1056         (-[JSModule require:]):
1057         (-[JSModule exports]):
1058         * jsc-cli/jsc-cli/JSRunLoopThread.h: Added.
1059         * jsc-cli/jsc-cli/JSRunLoopThread.m: Added.
1060         (jsThreadMain):
1061         (+[JSRunLoopThread threadMain]):
1062         (-[JSRunLoopThread initWithFiles:andContext:]):
1063         (-[JSRunLoopThread startRunLoop]):
1064         (-[JSRunLoopThread start]):
1065         (-[JSRunLoopThread join]):
1066         (-[JSRunLoopThread didReceiveInput:]):
1067         (-[JSRunLoopThread performCallback:withError:]):
1068         (-[JSRunLoopThread performCallback:withArguments:]):
1069         (-[JSRunLoopThread didFinishRunLoopInitialization]):
1070         * jsc-cli/jsc-cli/ReadEvalPrintLoop.h: Added.
1071         * jsc-cli/jsc-cli/ReadEvalPrintLoop.m: Added.
1072         (-[ReadEvalPrintLoop initWithJSThread:]):
1073         (prompt):
1074         (escapeStringForOutput):
1075         (-[ReadEvalPrintLoop processNextInput]):
1076         (-[ReadEvalPrintLoop run]):
1077         * jsc-cli/jsc-cli/RunLoopThread.h: Added.
1078         * jsc-cli/jsc-cli/RunLoopThread.m: Added.
1079         (+[RunLoopThread threadMain]):
1080         (-[RunLoopThread init]):
1081         (-[RunLoopThread dealloc]):
1082         (-[RunLoopThread didFinishRunLoopInitialization]):
1083         (-[RunLoopThread start]):
1084         (-[RunLoopThread join]):
1085         * jsc-cli/jsc-cli/ScriptInputSource.h: Added.
1086         * jsc-cli/jsc-cli/ScriptInputSource.m: Added.
1087         (scriptInputSourceScheduleRoutine):
1088         (scriptInputSourcePerformRoutine):
1089         (scriptInputSourceCancelRoutine):
1090         (-[ScriptInputSource initWithContext:]):
1091         (-[ScriptInputSource dealloc]):
1092         (-[ScriptInputSource addToCurrentRunLoop]):
1093         (-[ScriptInputSource removeFromRemoteRunLoop]):
1094         (-[ScriptInputSource didReceiveScript:]):
1095         (-[ScriptInputSource didReceiveSignal]):
1096         (-[ScriptInputSource runScriptRemotely:]):
1097         (-[ScriptInputSource finishAsyncCallback:withResult:]):
1098         * jsc-cli/jsc-cli/main.m: Added.
1099         (main):
1100
1101 2014-01-23  László Langó  <llango.u-szeged@partner.samsung.com>
1102
1103         Remove a FIXME comment that is already fixed.
1104         https://bugs.webkit.org/show_bug.cgi?id=127468
1105
1106         Reviewed by Csaba Osztrogonác.
1107
1108         * Scripts/webkitpy/style/filereader.py:
1109         (TextFileReader.__init__):
1110
1111 2014-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1112
1113         [GLIB] Use GUniquePtr instead of GOwnPtr
1114         https://bugs.webkit.org/show_bug.cgi?id=127431
1115
1116         Reviewed by Martin Robinson.
1117
1118         GUniquePtr is a template alias of std::unique_ptr with a custom
1119         deleter that replaces GOwnPtr. GOwnPtr is still used for the cases
1120         where the output pointer is needed, but it will also be replaced soon.
1121
1122         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
1123         (printAccessibilityEvent):
1124         (axObjectEventListener):
1125         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1126         (indexRangeInTable):
1127         (AccessibilityUIElement::role):
1128         (AccessibilityUIElement::title):
1129         (AccessibilityUIElement::description):
1130         (AccessibilityUIElement::stringValue):
1131         (AccessibilityUIElement::language):
1132         (AccessibilityUIElement::lineForIndex):
1133         (AccessibilityUIElement::selectedTextRange):
1134         (AccessibilityUIElement::url):
1135         * DumpRenderTree/efl/AccessibilityControllerEfl.cpp:
1136         (AccessibilityController::accessibleElementById):
1137         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1138         (AccessibilityController::accessibleElementById):
1139         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1140         (getOutputDir):
1141         (getFontsPath):
1142         (initializeFonts):
1143         (dumpFramesAsText):
1144         (compareHistoryItems):
1145         (dumpHistoryItem):
1146         (soupURIToStringPreservingPassword):
1147         (resetDefaultsToConsistentValues):
1148         (temporaryDatabaseDirectory):
1149         (webViewTitleChanged):
1150         (webFrameLoadStatusNotified):
1151         (pathFromSoupURI):
1152         (convertWebResourceToURLPath):
1153         (urlSuitableForTestResult):
1154         (descriptionSuitableForTestResult):
1155         (willSendRequestCallback):
1156         (frameLoadEventCallback):
1157         * DumpRenderTree/gtk/EditingCallbacks.cpp:
1158         (dumpNodePath):
1159         (dumpRange):
1160         (shouldApplyStyle):
1161         * DumpRenderTree/gtk/EventSender.cpp:
1162         (contextClickCallback):
1163         (beginDragWithFilesCallback):
1164         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1165         (TestRunner::pathToLocalResource):
1166         (TestRunner::queueLoad):
1167         (TestRunner::removeOriginAccessWhitelistEntry):
1168         (TestRunner::setMockGeolocationPositionUnavailableError):
1169         (TestRunner::setIconDatabaseEnabled):
1170         (TestRunner::findString):
1171         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
1172         (TestRunner::overridePreference):
1173         (TestRunner::addUserScript):
1174         (TestRunner::addUserStyleSheet):
1175         (TestRunner::setTextDirection):
1176         * DumpRenderTree/gtk/TextInputController.cpp:
1177         (setMarkedTextCallback):
1178         (insertTextCallback):
1179         (doCommandCallback):
1180         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
1181         (LoadHTMLStringItem::invoke):
1182         * TestWebKitAPI/PlatformGTK.cmake:
1183         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
1184         (WebKitDOMNodeTest::testTagNames):
1185         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
1186         (testBackForwardListLimitAndCache):
1187         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
1188         (testContextMenuSmartSeparators):
1189         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
1190         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1191         (testDownloadLocalFile):
1192         (testDownloadLocalFileError):
1193         (addContentDispositionHTTPHeaderToResponse):
1194         (serverCallback):
1195         (testDownloadRemoteFileError):
1196         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
1197         (startTestServer):
1198         (testInspectorServerPageList):
1199         (openRemoteDebuggingSession):
1200         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
1201         (testPrintOperationPrint):
1202         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1203         (addCacheHTTPHeadersToResponse):
1204         (serverCallback):
1205         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1206         (httpsServerCallback):
1207         (httpServerCallback):
1208         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1209         (testWebViewJavaScriptDialogs):
1210         (testWebViewWindowProperties):
1211         (testWebViewFileChooserRequest):
1212         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
1213         (testWebExtensionWindowObjectCleared):
1214         (testWebExtensionIsolatedWorld):
1215         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp:
1216         (startTestServer):
1217         (checkAtspiAccessible):
1218         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
1219         (serverCallback):
1220         (testClearDatabase):
1221         (testGetFaviconURI):
1222         (webkitFaviconDatabaseFinalizedCallback):
1223         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1224         (testWebContextGetPlugins):
1225         (testWebContextURIScheme):
1226         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1227         (testWebViewRunJavaScript):
1228         (testWebViewMode):
1229         (testWebViewPageVisibility):
1230         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp:
1231         (isStyleSheetInjectedForURLAtPath):
1232         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
1233         (testWebViewEditorCutCopyPasteNonEditable):
1234         (testWebViewEditorCutCopyPasteEditable):
1235         (testWebViewEditorSelectAllNonEditable):
1236         (testWebViewEditorSelectAllEditable):
1237         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1238         (sendRequestCallback):
1239         (methodCallCallback):
1240         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
1241         (TestWebKitAPI::Util::createInjectedBundlePath):
1242         (TestWebKitAPI::Util::createURLForResource):
1243         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
1244         (TestWebKitAPI::doKeyStroke):
1245         (TestWebKitAPI::doMouseButtonEvent):
1246         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
1247         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
1248         (loadFailedCallback):
1249         (LoadTrackingTest::loadURI):
1250         (LoadTrackingTest::loadHtml):
1251         (LoadTrackingTest::loadPlainText):
1252         (LoadTrackingTest::loadRequest):
1253         (LoadTrackingTest::reload):
1254         (LoadTrackingTest::goBack):
1255         (LoadTrackingTest::goForward):
1256         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
1257         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:
1258         (registerGResource):
1259         (removeNonEmptyDirectory):
1260         (main):
1261         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1262         (Test::getWebKit1TestResoucesDir):
1263         (Test::getResourcesDir):
1264         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp:
1265         (WebKitTestBus::run):
1266         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
1267         (WebKitTestServer::WebKitTestServer):
1268         (WebKitTestServer::getURIForPath):
1269         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp:
1270         (WebProcessTestRunner::runTest):
1271         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1272         (resourceGetDataCallback):
1273         (WebViewTest::mainResourceData):
1274         (WebViewTest::mouseMoveTo):
1275         (WebViewTest::keyStroke):
1276         (WebViewTest::doMouseButtonEvent):
1277         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
1278         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1279         (WTR::AccessibilityController::accessibleElementById):
1280         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1281         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1282         (WTR::AccessibilityUIElement::role):
1283         (WTR::AccessibilityUIElement::title):
1284         (WTR::AccessibilityUIElement::description):
1285         (WTR::AccessibilityUIElement::stringValue):
1286         (WTR::AccessibilityUIElement::language):
1287         (WTR::AccessibilityUIElement::lineForIndex):
1288         (WTR::AccessibilityUIElement::selectedTextRange):
1289         (WTR::AccessibilityUIElement::url):
1290         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1291         (WTR::getOutputDir):
1292         (WTR::getFontsPath):
1293         (WTR::initializeFontConfigSetting):
1294         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1295         (WTR::topLevelPath):
1296         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1297         (WTR::TestRunner::pathToLocalResource):
1298         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1299         (WTR::TestController::initializeInjectedBundlePath):
1300         (WTR::TestController::initializeTestPluginDirectory):
1301
1302 2014-01-05  Martin Robinson  <mrobinson@igalia.com>
1303
1304         [GTK] [CMake] run-webkit-tests should support the CMake build
1305         https://bugs.webkit.org/show_bug.cgi?id=126503
1306
1307         Reviewed by Daniel Bates.
1308
1309         Update run-launcher and gtk.py to work properly when dealing with the CMake port.
1310         run-webkit-tests does not need the --gtkcmake flag, but run-launcher does.
1311
1312         * Scripts/run-launcher: Work properly with the gtkcmake flag.
1313         * Scripts/webkitpy/port/gtk.py:
1314         (GtkPort._is_cmake_build): Added this helper which looks for the CMakeCache
1315         file to detect a CMake build.
1316         (GtkPort._built_executables_path): Added this helper to locate the built executable path.
1317         (GtkPort._built_libraries_path): Added this helper to locate the built library path.
1318         (GtkPort._port_flag_for_scripts): Use --gtkcmake when appropriate.
1319         (GtkPort.setup_environ_for_server): The way CMake builds libraries differs from GTK+.
1320         (GtkPort._path_to_driver): Use the new helper.
1321         (GtkPort._path_to_image_diff): Use the new helper.
1322         (GtkPort._path_to_webcore_library): Use the new helper.
1323         (GtkPort.build_webkit_command): Use --gtkcmake when appropriate.
1324
1325 2014-01-22  Ryuan Choi  <ryuan.choi@samsung.com>
1326
1327         [EFL] Remove unnecessary smart method since ewk_view_tiled removed
1328         https://bugs.webkit.org/show_bug.cgi?id=127417
1329
1330         Reviewed by Gyuyoung Kim.
1331
1332         * EWebLauncher/main.c:
1333         (on_key_down): Removed shortcut to test pre render.
1334
1335 2014-01-22  Myles C. Maxfield  <mmaxfield@apple.com>
1336
1337         Remove CSS3_TEXT_DECORATION define
1338         https://bugs.webkit.org/show_bug.cgi?id=127333
1339
1340         This is required for unprefixing the text-decoration-* CSS properties.
1341
1342         Reviewed by Simon Fraser.
1343
1344         * Configurations/FeatureDefines.xcconfig:
1345
1346 2014-01-22  Andy Estes  <aestes@apple.com>
1347
1348         [iOS] Prepare for upstreaming DumpRenderTree changes
1349         https://bugs.webkit.org/show_bug.cgi?id=127412
1350
1351         Reviewed by Simon Fraser.
1352
1353         Unlike on Mac where DumpRenderTree is a command-line tool, on iOS it is
1354         an application bundle. Instead of upstreaming a separate target for the
1355         app that duplicates the 'Compile Sources' phase of the tool, separate
1356         out the compilation into a static library target that both the
1357         command-line tool and the app can link against. Also, perform some
1358         unrelated cleanup.
1359
1360         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Updated the
1361         project file format from 2.4- to 3.2-compatible. Removed the
1362         'Copy Headers' build phase and removed all files from the
1363         'Compile Sources' build phase of DumpRenderTree. Added some files that
1364         were missing from the project. Created a 'DumpRenderTree (Library)'
1365         target for building the static library and made the 'DumpRenderTree'
1366         target depend on it. Added a 'Compile Sources' build phase to this
1367         target that builds the same files the DumpRenderTree target used to.
1368         Created DumpRenderTreeMain.mm as the only source file of the
1369         DumpRenderTree target, since targets won't link a binary without at
1370         least one source file. Made DumpRenderTree (Library) use
1371         DumpRenderTreeLibrary.xcconfig and made LayoutTestHelper use
1372         BaseTarget.xcconfig (so that it doesn't try to link libDumpRenderTree.a).
1373         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Moved
1374         definitions of GCC_ENABLE_OBJC_EXCEPTIONS and GCC_PREFIX_HEADER from
1375         DumpRenderTree.xcconfig to here so that LayoutTestHelper can use them.
1376         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Passed
1377         -force_load $(BUILT_PRODUCTS_DIR)libDumpRenderTree.a to OTHER_LDFLAGS.
1378         This is needed to correctly link a static library containing an Objective-C
1379         category (see <https://developer.apple.com/library/mac/qa/qa1490/_index.html>).
1380         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Added.
1381         * DumpRenderTree/mac/DumpRenderTree.mm:
1382         (DumpRenderTreeMain): Renamed from main.
1383         * DumpRenderTree/mac/DumpRenderTreeMac.h: Added declaration of DumpRenderTreeMain.
1384         * DumpRenderTree/mac/DumpRenderTreeMain.mm: Added.
1385         (main): Called DumpRenderTreeMain from main.
1386
1387 2014-01-15  Martin Robinson  <mrobinson@igalia.com>
1388
1389         [GTK][CMake] build-webkit should try harder to avoid re-running cmake
1390         https://bugs.webkit.org/show_bug.cgi?id=127073
1391
1392         Reviewed by Daniel Bates.
1393
1394         * Scripts/build-webkit: Unify all the ports that call buildCMakeProjectOrExit with
1395         the new isCMakeBuild conditional. This allows us to share more code between ports.
1396         Pass the build arguments to the removeCMakeCache function.
1397         * Scripts/webkitdirs.pm:
1398         (runAutogenForAutotoolsProjectIfNecessary): Renamed mustReRunAutogen to cachedArgumentFileOutOfDate
1399         because it's now shared with the CMake build.
1400         (cachedArgumentFileOutOfDate): Renamed.
1401         (cmakeCachePath): Added this helper which gets the CMakeCache.txt path.
1402         (shouldRemoveCMakeCache): Tries to preserve current behavior for all ports, 
1403         except GTK+ which examines the OptionsGTK.cmake and OptionsCommon.cmake file
1404         as well as checking if build-webkit has been run with different arguments.
1405         (removeCMakeCache): Call shouldRemoveCMakeCache now.
1406         (generateBuildSystemFromCMakeProject): Exit early if CMakeCache.txt exists for GTK+.
1407         (isCMakeBuild): Added.
1408
1409 2014-01-22  Thiago de Barros Lacerda  <thiago.lacerda@openbossa.org>
1410
1411         [EFL][GTK] Get EFL and GTK compiling with ACCESSIBILITY disabled
1412         https://bugs.webkit.org/show_bug.cgi?id=127119
1413
1414         Reviewed by Mario Sanchez Prada.
1415
1416         Guarding ACCESSIBILITY code in DumpRenderTree and WebKitTestRunner with HAVE(ACCESSIBILITY).
1417
1418         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1419         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1420         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1421         (resetDefaultsToConsistentValues):
1422         (webViewWindowObjectCleared):
1423         (main):
1424         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1425         (WTR::AccessibilityController::platformName):
1426         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1427         (WTR::AccessibilityUIElement::isIndeterminate):
1428
1429 2014-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1430
1431
1432         [GTK] Add GUniquePtr
1433         https://bugs.webkit.org/show_bug.cgi?id=127170
1434
1435         Reviewed by Gustavo Noronha Silva.
1436
1437         Add unit tests for GUniquePtr.
1438
1439         * TestWebKitAPI/GNUmakefile.am: Add new file to compilation.
1440         * TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp: Added.
1441         (log):
1442         (takeLogStr):
1443         (TestWebKitAPI::TEST):
1444
1445 2014-01-22  Jinwoo Song  <jinwoo7.song@samsung.com>
1446
1447         Remove Nix files from Tools
1448         https://bugs.webkit.org/show_bug.cgi?id=127418
1449
1450         Reviewed by Csaba Osztrogonác.
1451
1452         * Scripts/build-webkit:
1453         * Scripts/update-webkit-libs-jhbuild:
1454         * Scripts/webkitdirs.pm:
1455         (determineArchitecture):
1456         (argumentsForConfiguration):
1457         (jscProductDir):
1458         (builtDylibPathForName):
1459         (isAppleWebKit):
1460         (launcherPath):
1461         (launcherName):
1462         (checkRequiredSystemConfig):
1463         (copyInspectorFrontendFiles):
1464         (jhbuildWrapperPrefixIfNeeded):
1465         (buildCMakeProjectOrExit):
1466         (cmakeBasedPortName):
1467         * Scripts/webkitpy/common/config/ports.py:
1468         (DeprecatedPort.port):
1469         (EflWK2Port.build_webkit_command):
1470         * Scripts/webkitpy/port/factory.py:
1471         (platform_options):
1472         (PortFactory):
1473         * Scripts/webkitpy/port/nix.py: Removed.
1474         * Scripts/webkitpy/port/nix_unittest.py: Removed.
1475
1476 2014-01-21  Benjamin Poulain  <benjamin@webkit.org>
1477
1478         Add Ian and Ricky to the contributor list
1479
1480         * Scripts/webkitpy/common/config/contributors.json:
1481         I am too old to remember all those email addresses :)
1482
1483 2014-01-21  David Farler  <dfarler@apple.com>
1484
1485         Upstream package-root for iOS
1486
1487         Reviewed by Daniel bates.
1488
1489         * Scripts/package-root: Added.
1490         (usage):
1491         * Scripts/webkitdirs.pm:
1492         (XcodeSDKPath): Added function.
1493
1494 2014-01-21  Daniel Bates  <dabates@apple.com>
1495
1496         [iOS] Tools/Makefile shouldn't build modules DumpRenderTree, gtest, or TestWebKitAPI
1497         https://bugs.webkit.org/show_bug.cgi?id=127368
1498
1499         Reviewed by Tim Horton.
1500
1501         Similar to the build-webkit change in <https://bugs.webkit.org/show_bug.cgi?id=127364>,
1502         we don't want to build DumpRenderTree, gtest, or TestWebKitAPI when running make in
1503         Tools.
1504
1505         * Makefile:
1506
1507 2014-01-21  Daniel Bates  <dabates@apple.com>
1508
1509         [iOS] Don't build DumpRenderTree, gtest, or TestWebKitAPI
1510         https://bugs.webkit.org/show_bug.cgi?id=127364
1511
1512         Reviewed by Simon Fraser.
1513
1514         For now, don't build DumpRenderTree and TestWebKitAPI for iOS as these
1515         projects fail to build because we need to upstream the relevant iOS changes.
1516         Also, don't build gtest, which is a dependency of TestWebKitAPI since we
1517         aren't building TestWebKitAPI.
1518
1519         * Scripts/build-webkit:
1520
1521 2014-01-21  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1522
1523         Unreviewed, remove myself from some watchlist entries.
1524
1525         * Scripts/webkitpy/common/config/watchlist:
1526
1527 2014-01-21  Zalan Bujtas  <zalan@apple.com>
1528
1529         Use 64 as the default value for the subpixel denominator.
1530
1531         Reviewed by Simon Fraser.
1532
1533         * lldb/lldb_webkit.py:
1534         (WebCoreLayoutUnitProvider.to_string):
1535
1536 2014-01-21  ChangSeok Oh  <changseok.oh@collabora.com>
1537
1538         [GTK] Fix a c++11 compliance issue for fontconfig
1539         https://bugs.webkit.org/show_bug.cgi?id=127283
1540
1541         Reviewed by Martin Robinson.
1542
1543         fontconfig-2.8.0 is not compliant with C++11. So I propose to apply a
1544         hotfix until bumping fontconfig up.
1545
1546         * gtk/jhbuild.modules:
1547         * gtk/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
1548
1549 2014-01-21  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
1550
1551         run-jsc-stress-tests should accept --child-processes option and WEBKIT_TEST_CHILD_PROCESSES env.var
1552         like run_webkit_test does
1553         https://bugs.webkit.org/show_bug.cgi?id=127349
1554
1555         Reviewed by Csaba Osztrogonác.
1556
1557         * Scripts/run-jsc-stress-tests:
1558
1559 2014-01-21  Adrian Perez de Castro  <aperez@igalia.com>
1560
1561         [GTK] Allow passing extra data to web extensions
1562         https://bugs.webkit.org/show_bug.cgi?id=125990
1563
1564         Reviewed by Carlos Garcia Campos.
1565
1566         Allow passing additional information to the injected bundle. On top
1567         of the string containing the path to the web extensions directory,
1568         a GVariant can be set with additional data using
1569         webkit_web_context_set_web_extensions_initialization_user_data().
1570         Also, a new initialize-web-extensions signal is emitted before
1571         launching a new WebProcess to allow setting different user data
1572         for each process. The GVariant is serialized as a string, passed
1573         to the injected bundle, and the injected bundle deserializes back
1574         the data, which is passed to web extensions which define the
1575         webkit_web_extension_initialize_with_user_data() function (for
1576         backwards compatibility, webkit_web_extension_initialize() is
1577         used as a fallback.)
1578
1579         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
1580         (initializeWebExtensions): Handles the initialize-web-extensions
1581         signal, and sets the web extensions directory and the initialization
1582         user data.
1583         (testWebExtensionInitializationUserData): New test case for checking
1584         the user data passed on initialization to web extensions.
1585         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1586         (methodCallCallback): Added implementation for the
1587         GetInitializationUserData D-Bus method, used by
1588         testWebExtensionInitializationUserData().
1589         (webkit_web_extension_initialize_with_user_data): Define the
1590         initialization function with the additional user data parameter.
1591
1592 2014-01-21  Siddharth Mathur  <s.mathur@ieee.org>
1593
1594         Change my email address in contributors.json.
1595
1596         Unreviewed.
1597
1598         * Scripts/webkitpy/common/config/contributors.json:
1599
1600 2014-01-21  Krzysztof Czech  <k.czech@samsung.com>
1601
1602         [ATK] Expose aria-flowto through ATK_RELATION_FLOWS_TO
1603         https://bugs.webkit.org/show_bug.cgi?id=127291
1604
1605         Reviewed by Mario Sanchez Prada.
1606
1607         Implemented AccessibilityUIElement::ariaFlowToElementAtIndex method.
1608
1609         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1610         (AccessibilityUIElement::ariaFlowToElementAtIndex):
1611         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1612         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
1613
1614 2014-01-20  Zalan Bujtas  <zalan@apple.com>
1615
1616         Force float division when calculating CSS px value.
1617
1618         Reviewed by Simon Fraser.
1619
1620         Note that in Python 3, this is the default behavior.
1621
1622         * lldb/lldb_webkit.py:
1623         (WebCoreLayoutUnitProvider.to_string):
1624
1625 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
1626
1627         build.webkit.org/dashboard should display information about patches in EWS
1628         https://bugs.webkit.org/show_bug.cgi?id=127006
1629
1630         Reviewed by Ryosuke Niwa.
1631
1632         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
1633         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Bugzilla.js: Added.
1634         (Bugzilla.prototype.detailsURLForAttachment):
1635         Added a class for Bugzilla. So far, the only thing it can do is build patch URLs,
1636         which is needed when one wants to do something with a patch EWS is stuck on.
1637
1638         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
1639         Create a Bugzilla instance.
1640
1641         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
1642         (EWS.prototype.jsonQueueLengthURL):
1643         (EWS.prototype.jsonQueueStatusURL):
1644         Build JSON ULRs here, not in EWSQueue, as this is how other classes are structured.
1645
1646         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
1647         (EWSQueue.prototype.get statusPageURL): Changed to use a URL provided by EWS instead
1648         of second guessing.
1649         (EWSQueue.prototype.get chartsPageURL): Added.
1650         (EWSQueue.prototype.get loadedDetailedStatus): Tells whether we currently have
1651         additional data already loaded (it's reset with every update).
1652         (EWSQueue.prototype.get patches): Get patch queue.
1653         (EWSQueue.prototype.get bots): Get bots.
1654         (EWSQueue.prototype.update): Changed to use a specialized cheaper URL.
1655         (EWSQueue.prototype.loadDetailedStatus): Load and transform detailed status JSON.
1656
1657         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
1658         (EWSQueueView.prototype.update.appendQueue): Add a popover is there are any patches
1659         in the queue.
1660         (EWSQueueView.prototype.addLinkToRow): A helper to build the popover.
1661         (EWSQueueView.prototype.addTextToRow): Ditto.
1662         (EWSQueueView.prototype._addQueueHeadingToPopover): Ditto.
1663         (EWSQueueView.prototype._addBotsHeadingToPopover): Ditto.
1664         (EWSQueueView.prototype._addDividerToPopover): Ditto.
1665         (EWSQueueView.prototype._timeIntervalString): A helper to format a timestamp into a
1666         relative string.
1667         (EWSQueueView.prototype._popoverContentForEWSQueue): Build the popover.
1668         (EWSQueueView.prototype._presentPopoverForEWSQueue): Start loading data, and present
1669         it when done.
1670
1671         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
1672         Added rules for EWS popover. Removed a duplicate rule for build-logs-popover.
1673         Changed a few difficult to read padding styles to padding-left.
1674
1675 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
1676
1677         Fix webkitpy tests.
1678
1679         * Scripts/webkitpy/common/net/web_mock.py: (MockBrowser.set_handle_robots):
1680         Added a mock implementation, as we now call this function.
1681
1682 2014-01-20  Darin Adler  <darin@apple.com>
1683
1684         Update style checker and tests to deal with override instead of OVERRIDE
1685         https://bugs.webkit.org/show_bug.cgi?id=127175
1686
1687         Reviewed by Anders Carlsson.
1688
1689         * Scripts/webkitpy/style/checkers/cpp.py:
1690         (check_braces): Use override instead of OVERRIDE.
1691         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1692         (CppStyleTest.test_brace_at_begin_of_line): Ditto.
1693
1694 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
1695
1696         EWS should provide better information to Dashboard via JSON
1697         https://bugs.webkit.org/show_bug.cgi?id=127265
1698
1699         Reviewed by Ryosuke Niwa.
1700
1701         * QueueStatusServer/app.yaml: Updated version.
1702
1703         * QueueStatusServer/main.py:
1704         * QueueStatusServer/handlers/queuelengthjson.py:
1705         Added a way to cheaply get only the queue length, which is all the dashboard
1706         needs unless a popover is opened.
1707
1708         * QueueStatusServer/handlers/queuestatusjson.py: Updated to return more information
1709         that we will need. Changed some field names to be more meaningful. Fixed bot listing
1710         to understand that a bot can be reprurposed and used in a different queue.
1711
1712 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
1713
1714         Make uploading results to EWS work despite robots.txt
1715         https://bugs.webkit.org/show_bug.cgi?id=127296
1716
1717         Reviewed by Ryosuke Niwa.
1718
1719         * Scripts/webkitpy/common/net/statusserver.py: (StatusServer.__init__): Disable
1720         checking robots.txt.
1721
1722         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: (Bugzilla._get_browser):
1723         Removed a comment saying that we would want to stop doing this. Not checking
1724         robots.txt is more efficient than checking it.
1725
1726 2014-01-19  Ryuan Choi  <ryuan.choi@samsung.com>
1727
1728         [EFL][WK1] Remove and refactor the APIs which use single and base keyword
1729         https://bugs.webkit.org/show_bug.cgi?id=127214
1730
1731         Reviewed by Gyuyoung Kim.
1732
1733         Followed the changes of API.
1734
1735         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1736         (drtViewAdd):
1737         * EWebLauncher/main.c:
1738         (windowCreate):
1739
1740 2014-01-19  Eunmi Lee  <eunmi15.lee@samsung.com>
1741
1742         [EFL][WK2] Add touch events option to MiniBrowser.
1743         https://bugs.webkit.org/show_bug.cgi?id=127262
1744
1745         Reviewed by Gyuyoung Kim.
1746
1747         As a default, touch events are disabled and mouse events are enabled.
1748         If touch events option sets to true, touch events are enabled and mouse
1749         events are disabled.
1750
1751         * MiniBrowser/efl/main.c:
1752         (window_create):
1753         (elm_main):
1754
1755 2014-01-19  Zalan Bujtas  <zalan@apple.com>
1756
1757         Pretty print LayoutUnit, LayoutPoint, and LayoutSize in lldb and gdb.
1758         https://bugs.webkit.org/show_bug.cgi?id=126080
1759
1760         Reviewed by Sam Weinig.
1761
1762         This changes the output of printing LayoutUnits to be in px but it also
1763         preserves the original LayoutUnit value.
1764
1765         This will lead to lldb output like: (and it works even when subpixel is disabled)
1766
1767         (const WebCore::LayoutRect) $0 = {
1768             m_location = { x = 2.25px (144), y = 1px (64)}
1769             m_size = { width = 13.75px (880), height = 20px (1280) }
1770
1771
1772         And gdb output like:
1773
1774         m_frameRect = {
1775             m_location = LayoutPoint(0px (0), 0px(0)),
1776             m_size = LayoutSize(8px (512), 5px (320))
1777         }
1778
1779         This patch is based on patch by bjonesbe@adobe.com and for Blink by cbiesinger@chromium.org.
1780
1781         * gdb/webkit.py:
1782         (WebCoreLayoutUnitPrinter):
1783         (WebCoreLayoutUnitPrinter.__init__):
1784         (WebCoreLayoutUnitPrinter.to_string):
1785         (WebCoreLayoutSizePrinter):
1786         (WebCoreLayoutSizePrinter.__init__):
1787         (WebCoreLayoutSizePrinter.to_string):
1788         (WebCoreLayoutPointPrinter):
1789         (WebCoreLayoutPointPrinter.__init__):
1790         (WebCoreLayoutPointPrinter.to_string):
1791         (add_pretty_printers):
1792         * lldb/lldb_webkit.py:
1793         (__lldb_init_module):
1794         (WebCoreLayoutUnit_SummaryProvider):
1795         (WebCoreLayoutSize_SummaryProvider):
1796         (WebCoreLayoutPoint_SummaryProvider):
1797         (WebCoreLayoutUnitProvider):
1798         (WebCoreLayoutUnitProvider.__init__):
1799         (WebCoreLayoutUnitProvider.to_string):
1800         (WebCoreLayoutSizeProvider):
1801         (WebCoreLayoutSizeProvider.__init__):
1802         (WebCoreLayoutSizeProvider.get_width):
1803         (WebCoreLayoutSizeProvider.get_height):
1804         (WebCoreLayoutPointProvider):
1805         (WebCoreLayoutPointProvider.__init__):
1806         (WebCoreLayoutPointProvider.get_x):
1807         (WebCoreLayoutPointProvider.get_y):
1808
1809 2014-01-18  Alexey Proskuryakov  <ap@apple.com>
1810
1811         Add robots.txt to http://webkit-queues.appspot.com
1812         https://bugs.webkit.org/show_bug.cgi?id=127240
1813
1814         * QueueStatusServer/app.yaml: Added required "upload" attribute for robots.txt.
1815
1816 2014-01-18  Alexey Proskuryakov  <ap@apple.com>
1817
1818         Add robots.txt to http://webkit-queues.appspot.com
1819         https://bugs.webkit.org/show_bug.cgi?id=127240
1820
1821         Reviewed by Ryosuke Niwa.
1822
1823         * QueueStatusServer/app.yaml: Added robots.txt as a static file. Updated version.
1824
1825         * QueueStatusServer/robots.txt: Added.
1826
1827 2014-01-18  Alberto Garcia  <berto@igalia.com>
1828
1829         Tools/Scripts/test-webkitperl fails: 'tempdir' can't be called as a method
1830         https://bugs.webkit.org/show_bug.cgi?id=127217
1831
1832         Reviewed by Daniel Bates.
1833
1834         The syntax File::Temp->tempdir() was explicitly made invalid
1835         following <https://github.com/Perl-Toolchain-Gang/File-Temp/commit/c8920b2161ab6900a09e02b9410e0e4c3d74f565>
1836         which was included in File::Temp v2.30, shipped with Perl v5.18.0.
1837
1838         Use File::Temp::tempdir() instead.
1839
1840         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
1841
1842 2014-01-18  Alexey Proskuryakov  <ap@apple.com>
1843
1844         build.webkit.org/dashboard should have image diff links in test results popovers
1845         https://bugs.webkit.org/show_bug.cgi?id=127188
1846
1847         Reviewed by Timothy Hatcher.
1848
1849         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1850         (Buildbot.prototype.layoutTestImagesURLForIteration):
1851         (Buildbot.prototype.layoutTestImageDiffURLForIteration):
1852         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1853         (BuildbotIteration.prototype.loadLayoutTestResults):
1854         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1855         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions.addFailureInfoLink):
1856         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions.addFailureInfoText):
1857         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
1858
1859 2014-01-18  Anders Carlsson  <andersca@apple.com>
1860
1861         Remove ENABLE_THREADED_HTML_PARSER defines everywhere
1862         https://bugs.webkit.org/show_bug.cgi?id=127225
1863
1864         Reviewed by Andreas Kling.
1865
1866         This concludes the removal of over 8.8 million lines of threaded parser code.
1867
1868         * Scripts/webkitperl/FeatureList.pm:
1869
1870 2014-01-17  Alexey Proskuryakov  <ap@apple.com>
1871
1872         build.webkit.org/dashboard should have diff links in test results popovers
1873         https://bugs.webkit.org/show_bug.cgi?id=126986
1874
1875         Reviewed by Tim Horton.
1876
1877         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1878         (Buildbot.prototype.layoutTestCrashLogURLForIteration):
1879         (Buildbot.prototype.layoutTestStderrURLForIteration):
1880         (Buildbot.prototype.layoutTestDiffURLForIteration):
1881         (Buildbot.prototype.layoutTestPrettyDiffURLForIteration):
1882         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1883         (BuildbotIteration.prototype.loadLayoutTestResults):
1884         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1885         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
1886
1887 2014-01-17  Matthew Hanson  <matthew_hanson@apple.com>
1888
1889         Add the bare minimum support for branches to the bot-watchers dashboard
1890         https://bugs.webkit.org/show_bug.cgi?id=127124
1891
1892         This patch simply introduces the notion of branches into the bot-watchers dashboard.
1893         Subsequent patches will build functionality on top of this simple bit of infrastructure.
1894
1895         Reviewed by Timothy Hatcher.
1896
1897         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1898         (BuildbotQueue): store the branch property in the BuildbotQueue constructor
1899         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1900         Initialize the Dashboard.Branch object
1901
1902 2014-01-17  Chris Fleizach  <cfleizach@apple.com>
1903
1904         platform/mac/accessibility/aria-multiline.html sometimes asserts in AccessibilityController::removeNotificationListener
1905         https://bugs.webkit.org/show_bug.cgi?id=127141
1906
1907         Reviewed by Alexey Proskuryakov.
1908
1909         Make sure to reset the notification handler each time.
1910
1911         * DumpRenderTree/AccessibilityController.cpp:
1912         (AccessibilityController::resetToConsistentState):
1913         * DumpRenderTree/AccessibilityController.h:
1914         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
1915         (AccessibilityController::platformResetToConsistentState):
1916         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
1917         (AccessibilityController::platformResetToConsistentState):
1918         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1919         (AccessibilityController::~AccessibilityController):
1920         (AccessibilityController::platformResetToConsistentState):
1921         (AccessibilityController::removeNotificationListener):
1922         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1923         (AccessibilityController::platformResetToConsistentState):
1924
1925 2014-01-17  Alberto Garcia  <berto@igalia.com>
1926
1927         [GTK] Test /webkit/download/not-found fails in GTK Linux 64-bit Release bot
1928         https://bugs.webkit.org/show_bug.cgi?id=82329
1929
1930         Reviewed by Carlos Garcia Campos.
1931
1932         Unskip, this is working fine now.
1933
1934         * Scripts/run-gtk-tests:
1935         (TestRunner):
1936
1937 2014-01-17  Alberto Garcia  <berto@igalia.com>
1938
1939         [GTK] Test /webkit/webview/icon-uri times out in GTK Linux 64-bit Release bot
1940         https://bugs.webkit.org/show_bug.cgi?id=82328
1941
1942         Reviewed by Carlos Garcia Campos.
1943
1944         This was caused by the icon database being corrupted in the
1945         Release bot. After removing it the test works fine so it can be
1946         run again.
1947
1948         * Scripts/run-gtk-tests:
1949         (TestRunner):
1950
1951 2014-01-16  Alexey Proskuryakov  <ap@apple.com>
1952
1953         Test results popovers at http://build.webkit.org/dashboard should link to stderr
1954         https://bugs.webkit.org/show_bug.cgi?id=126929
1955
1956         Reviewed by Timothy Hatcher.
1957
1958         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1959         (Buildbot.prototype.layoutTestCrashLogURLForIteration): Renamed for consistency.
1960         (Buildbot.prototype.layoutTestStderrURLForIteration): Added.
1961
1962         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1963         (BuildbotIteration.prototype.loadLayoutTestResults): Store has_stderr attribute.
1964
1965         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1966         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
1967         Add a link to stderr output if present.
1968
1969         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
1970         (.test-results-popover .additional-link): Style with light grey (will use the same style
1971         for diff links).
1972
1973 2014-01-16  Ryosuke Niwa  <rniwa@webkit.org>
1974
1975         Automate DoYouEvenBench
1976         https://bugs.webkit.org/show_bug.cgi?id=124497
1977
1978         Reviewed by Geoffrey Garen.
1979
1980         * Scripts/webkitpy/performance_tests/perftest.py:
1981         (PerfTestMetric.__init__): Added the aggregator name as an argument.
1982         (PerfTestMetric.aggregator): Added.
1983         (PerfTest._metrics_regex): Made the subtest name match non-greedy so that the metric names will be
1984         won't be eagerly parsed as a part of the subtest name. e.g. "Time" and "Total" in "a:Time:Total"
1985         should be parsed as the metric and the aggregator respectively.
1986         (PerfTest._run_with_driver): Pass in the aggregator name.
1987         (PerfTest._ensure_metrics): Ditto. Also split the subtest name by / as required by DoYouEvenBench
1988         which generates subtests of subtests within a single test file.
1989
1990         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1991         (test_parse_output_with_subtests_and_total): Added.
1992
1993         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1994         (_generate_results_dict): Add the aggregator name to the JSON when one is available.
1995
1996         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1997         (TestWithSubtestsData): Added a sub test with an aggregator and a sub-sub test.
1998
1999 2014-01-16  Chris Fleizach  <cfleizach@apple.com>
2000
2001         platform/mac/accessibility/aria-multiline.html sometimes asserts in AccessibilityController::removeNotificationListener
2002         https://bugs.webkit.org/show_bug.cgi?id=127141
2003
2004         Reviewed by Alexey Proskuryakov.
2005
2006         Don't assert that the notification handler needs to be cleaned up. Deallocing the controller should be enough to clean up as it is.
2007
2008         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2009         (AccessibilityController::~AccessibilityController):
2010
2011 2014-01-16  Ryosuke Niwa  <rniwa@webkit.org>
2012
2013         EWS shouldn't comment on Bugzilla for failing builds or style errors
2014         https://bugs.webkit.org/show_bug.cgi?id=127079
2015
2016         Reviewed by Anders Carlsson.
2017
2018         Since patch authors and reviewers could retrieve this information from bubbles,
2019         we shouldn't spam the Bugzilla with useless comments.
2020
2021         We still post style errors but not python paths we used since it's a pure noise.
2022
2023         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2024         (AbstractEarlyWarningSystem._post_reject_message_on_bug):
2025         * Scripts/webkitpy/tool/commands/queues.py:
2026         (StyleQueue.review_patch):
2027
2028 2014-01-15  Roger Fong  <roger_fong@apple.com>
2029
2030         Add support for handling WebGL load policies.
2031         https://bugs.webkit.org/show_bug.cgi?id=126935
2032         <rdar://problem/15790448>.
2033
2034         Reviewed by Timothy Horton.
2035
2036         * WebKitTestRunner/TestController.cpp: Update WKPageLoaderClient to V4.
2037         (WTR::TestController::createWebViewWithOptions):
2038
2039 2014-01-16  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2040
2041         Remove workaround for compilers not supporting explicit override control
2042         https://bugs.webkit.org/show_bug.cgi?id=127111
2043
2044         Reviewed by Anders Carlsson.
2045
2046         Now all compilers support explicit override control, this workaround can be removed.
2047
2048         * DumpRenderTree/gtk/fonts/fonts.conf:
2049         * Scripts/do-webcore-rename:
2050         Removed this rename operation from the list of contemplated future renames.
2051         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
2052         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
2053         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
2054         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
2055         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2056
2057 2014-01-16  Oliver Hunt  <oliver@apple.com>
2058
2059         Stop run-jsc from consuming stderr output
2060         https://bugs.webkit.org/show_bug.cgi?id=127115
2061
2062         Reviewed by Mark Lam.
2063
2064         Simple patch to make run-jsc easier to deal with
2065
2066         * Scripts/run-jsc:
2067
2068 2014-01-16  Eva Balazsfalvi  <balazsfalvi.eva@stud.u-szeged.hu>
2069
2070         Tools/gtk/generate-feature-defines-files doesn't work with older versions of python
2071         https://bugs.webkit.org/show_bug.cgi?id=126323
2072
2073         Reviewed by Csaba Osztrogonác.
2074
2075         * gtk/generate-feature-defines-files:
2076
2077 2014-01-16  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
2078
2079         [EFL][WK2] Implement TestController::setHidden
2080         https://bugs.webkit.org/show_bug.cgi?id=127036
2081
2082         Reviewed by Gyuyoung Kim.
2083
2084         WebKitTestRunner needs TestController::setHidden implementation to
2085         properly handle page visibility API layout tests after r161105.
2086
2087         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2088         (WTR::TestController::setHidden):
2089
2090 2014-01-16  Zan Dobersek  <zdobersek@igalia.com>
2091
2092         [GTK][MiniBrowser] The progress entry reset callback can be fired after the BrowserWindow is destroyed
2093         https://bugs.webkit.org/show_bug.cgi?id=127083
2094
2095         Reviewed by Carlos Garcia Campos.
2096
2097         When the load progress reaches 1.0 (i.e. 100%), a timeout callback is set up in webViewLoadProgressChanged.
2098         The progress entry is then reset back to 0 in that callback and the timeout source is removed.
2099
2100         The callback can be fired after the relevant BrowserWindow and its progress entry are destroyed, causing
2101         assertion failures in gtk_entry_set_progress_fraction due to an invalid GtkEntry object. To avoid that,
2102         To avoid that, the ID of the timeout source is stored on the BrowserWindow and is destroyed when the
2103         BrowserWindow object is being finalized, preventing the callback from firing.
2104
2105         * MiniBrowser/gtk/BrowserWindow.c:
2106         (resetEntryProgress):
2107         (webViewLoadProgressChanged):
2108         (browserWindowFinalize):
2109
2110 2014-01-15  Alexey Proskuryakov  <ap@apple.com>
2111
2112         DumpRenderTree doesn't disable web preferences autosave
2113         https://bugs.webkit.org/show_bug.cgi?id=127062
2114
2115         Reviewed by Dan Bernstein.
2116
2117         * DumpRenderTree/mac/DumpRenderTree.mm: (prepareConsistentTestingEnvironment):
2118         Do it.
2119
2120 2014-01-15  Dean Jackson  <dino@apple.com>
2121
2122         Improve filter-build-webkit, especially for iOS builds
2123         https://bugs.webkit.org/show_bug.cgi?id=81046
2124
2125         Reviewed by Joseph Pecoraro.
2126
2127         Lots of updates to the filtering rules, mostly from the
2128         iOS build output. Other highlights include:
2129         - ignoring escape sequences for color ouput
2130         - detecting escaped spaces in file name regexps
2131
2132         * Scripts/filter-build-webkit:
2133         (shouldIgnoreLine):
2134
2135 2014-01-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2136
2137         [GTK] Web process sometimes crashes when printing in synchronous mode
2138         https://bugs.webkit.org/show_bug.cgi?id=126979
2139
2140         Reviewed by Gustavo Noronha Silva.
2141
2142         * Scripts/run-gtk-tests:
2143         (TestRunner): Unskip
2144         /webkit2/WebKitPrintOperation/close-after-print.
2145
2146 2014-01-15  ChangSeok Oh  <changseok.oh@collabora.com>
2147
2148         [EFL] Change test font installed path to webkitgtk-font-tests
2149         https://bugs.webkit.org/show_bug.cgi?id=126723
2150
2151         Reviewed by Gyuyoung Kim.
2152
2153         I'd like to change the test fonts installed directory from 'webkitgtk-test-fonts-0.0.3'
2154         to 'webkitgtk-test-fonts'. webkitgtk-test-fonts-0.0.3 doesn't match the path
2155         hard-coded in FontManagement.cpp#105
2156
2157         * DumpRenderTree/PlatformEfl.cmake:
2158         * WebKitTestRunner/PlatformEfl.cmake:
2159         * efl/jhbuild.modules:
2160
2161 2014-01-14  Ryosuke Niwa  <rniwa@webkit.org>
2162
2163         Make DoYouEvenBench runnable by run-perf-tests
2164         https://bugs.webkit.org/show_bug.cgi?id=127030
2165
2166         Reviewed by Andreas Kling.
2167
2168         Ignore console messages spit out by DoYouEvenBench and support aggregator names such as
2169         ":Total" to appear at the end of a test name. We don't do anything with it for now.
2170
2171         * Scripts/webkitpy/performance_tests/perftest.py:
2172         (PerfTest._metrics_regex): Handle aggregator names such as ":Total". We'll pass it down
2173         to the JSON in a follow up patch for the perf dashboard.
2174         (PerfTest._lines_to_ignore_in_parser_result): Added lines to ignore for DoYouEvenBench.
2175
2176 2014-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
2177
2178         [GTK] UI process crashes when the web process crashes while printing
2179         https://bugs.webkit.org/show_bug.cgi?id=126977
2180
2181         Reviewed by Gustavo Noronha Silva.
2182
2183         Add new test case to check that closing the window right after
2184         printing works. It's skipped for now, because this patch only
2185         fixes the UI process crash, but not the web process one.
2186
2187         * Scripts/run-gtk-tests:
2188         (TestRunner): Skip
2189         /webkit2/WebKitPrintOperation/close-after-print.
2190         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
2191         (testPrintOperationPrintPrinter):
2192         (findPrintToFilePrinter):
2193         (testPrintOperationPrint):
2194         (testPrintOperationErrors):
2195         (testPrintOperationCloseAfterPrint):
2196         (beforeAll):
2197
2198 2014-01-14  Brent Fulgham  <bfulgham@apple.com>
2199
2200         [WIN] Set MSBuild environment variable to avoid long-lived processes locking log files
2201         https://bugs.webkit.org/show_bug.cgi?id=127002
2202
2203         Reviewed by David Kilzer.
2204
2205         * Scripts/webkitdirs.pm:
2206         (setupAppleWinEnv): Export MSBUILDDISABLENODEREUSE=1 to the environment.
2207
2208 2014-01-14  Commit Queue  <commit-queue@webkit.org>
2209
2210         Unreviewed, rolling out r162000.
2211         http://trac.webkit.org/changeset/162000
2212         https://bugs.webkit.org/show_bug.cgi?id=127009
2213
2214         API versioning is wrong (Requested by rfong on #webkit).
2215
2216         * MiniBrowser/mac/WK2BrowserWindowController.m:
2217         (-[WK2BrowserWindowController awakeFromNib]):
2218         * WebKitTestRunner/TestController.cpp:
2219         (WTR::TestController::createOtherPage):
2220         (WTR::TestController::createWebViewWithOptions):
2221
2222 2014-01-13  Roger Fong  <roger_fong@apple.com>
2223
2224         Add support for handling WebGL load policies.
2225         https://bugs.webkit.org/show_bug.cgi?id=126935
2226         <rdar://problem/15790448>.
2227
2228         Reviewed by Brent Fulgham.
2229
2230         * MiniBrowser/mac/WK2BrowserWindowController.m:
2231         (-[WK2BrowserWindowController awakeFromNib]):
2232         * WebKitTestRunner/TestController.cpp:
2233         (WTR::TestController::createWebViewWithOptions):
2234
2235 2014-01-14  Zan Dobersek  <zdobersek@igalia.com>
2236
2237         [GTK] Skip FontConfig initialization in WebKitTestRunner if requested
2238         https://bugs.webkit.org/show_bug.cgi?id=120110
2239
2240         Reviewed by Martin Robinson.
2241
2242         Skip the FontConfig settings initialization in WebKitTestRunner if the
2243         WEBKIT_SKIP_WEBKITTESTRUNNER_FONTCONFIG_INITIALIZATION environment variable is set.
2244         This is useful when profiling the WebKitTestRunner execution, where at the startup
2245         this step takes considerable amount of time and disturbs the profiling output.
2246
2247         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2248         (WTR::initializeFontConfigSetting):
2249
2250 2014-01-14  Brian J. Burg  <burg@cs.washington.edu>
2251
2252         Add ENABLE(WEB_REPLAY) feature flag to the build system
2253         https://bugs.webkit.org/show_bug.cgi?id=126949
2254
2255         Reviewed by Joseph Pecoraro.
2256
2257         * Scripts/webkitperl/FeatureList.pm:
2258
2259 2014-01-14  László Langó  <llango.u-szeged@partner.samsung.com>
2260
2261         REGRESSION (r160085): check-webkit-style: utf8' codec can't decode byte 0x89 in position 0: invalid start byte.
2262         https://bugs.webkit.org/show_bug.cgi?id=126702
2263
2264         Reviewed by Alexey Proskuryakov.
2265
2266         Resolve regression and remove a FIXME comment that is already fixed.
2267
2268         * Scripts/webkitpy/common/system/filesystem.py:
2269         (FileSystem.open_text_file_for_reading):
2270         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2271         (RealFileSystemTest.test_read_and_write_file):
2272         * Scripts/webkitpy/style/filereader.py:
2273         (TextFileReader._read_lines):
2274         * Scripts/webkitpy/style/filereader_unittest.py:
2275         (TextFileReaderTest.test_count_delete_only_file):
2276         (TextFileReaderTest):
2277         (TextFileReaderTest.test_process_malformed_file):
2278
2279 2014-01-02  Brian Holt  <brian.holt@samsung.com>
2280
2281         [GTK] Parse Valgrind xml leak files
2282         https://bugs.webkit.org/show_bug.cgi?id=119446
2283
2284         Reviewed by Alejandro G. Castro.
2285
2286         Parse the xml files generated by Valgrind to yield useful
2287         information about the memory leaks.
2288
2289         * Scripts/webkitpy/port/gtk.py:
2290         (GtkPort.__init__):
2291         (GtkPort.setup_test_run): Clear the previous output files before new
2292         run.
2293         (GtkPort.print_leaks_summary):
2294
2295         * Scripts/webkitpy/port/leakdetector_valgrind.py: Added.
2296         Parse the xml files generated by Valgrind and summarise leaks
2297         into an easily understandable list.
2298         (get_text_of):
2299         (get_CDATA_of):
2300         (gather_frames):
2301         (ValgrindError):
2302         (ValgrindError.__init__):
2303         (ValgrindError.__str__):
2304         (ValgrindError.unique_string):
2305         (ValgrindError.error_hash):
2306         (ValgrindError.__hash__):
2307         (ValgrindError.__eq__):
2308         (LeakDetectorValgrind):
2309         (LeakDetectorValgrind.__init__):
2310         (LeakDetectorValgrind._parse_leaks_output):
2311         (LeakDetectorValgrind.leaks_files_in_results_directory):
2312         (LeakDetectorValgrind.clean_leaks_files_from_results_directory):
2313         (LeakDetectorValgrind.parse_and_print_leaks_detail):
2314
2315         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Added.
2316         (make_mock_valgrind_output):
2317         (make_mock_incomplete_valgrind_output):
2318         (make_mock_valgrind_results):
2319         (make_mock_valgrind_results_incomplete):
2320         (make_mock_valgrind_results_empty):
2321         (make_mock_valgrind_results_misformatted):
2322         (mock_run_cppfilt_command):
2323         (LeakDetectorValgrindTest):
2324         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
2325         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
2326         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
2327         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
2328         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
2329         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
2330         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
2331         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
2332
2333 2014-01-13  Lucas Forschler  <lforschler@apple.com>
2334
2335         Update the LLINT CLoop Bot build infrastructure
2336         https://bugs.webkit.org/show_bug.cgi?id=126604
2337         
2338         Unreviewed.
2339         
2340         * BuildSlaveSupport/build.webkit.org-config/config.json:
2341         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2342         (CompileLLINTCLoop):
2343         (RunLLINTCLoopTests):
2344         (BuildAndTestLLINTCLoopFactory):
2345         (BuildAndTestLLINTCLoopFactory.__init__):
2346
2347 2014-01-13  Jinwoo Song  <jinwoo7.song@samsung.com>
2348
2349         [EFL][WK2] Disable failing API tests
2350         https://bugs.webkit.org/show_bug.cgi?id=126960
2351
2352         Reviewed by Gyuyoung Kim.
2353
2354         Disable WKViewUserViewportToContents test until bug 126261 is resolved.
2355
2356         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
2357         (TestWebKitAPI::TEST):
2358
2359 2014-01-13  Daniel Batyai  <dbatyai.u-szeged@partner.samsung.com>
2360
2361         Remove wdiff
2362         https://bugs.webkit.org/show_bug.cgi?id=124766
2363
2364         Reviewed by Ryosuke Niwa.
2365
2366         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
2367         (ResultsJSONParserTest):
2368         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2369         (TestResultWriter):
2370         (TestResultWriter.create_text_diff_and_write_result):
2371         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2372         (summarize_results):
2373         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2374         (RunTest.test_output_diffs):
2375         * Scripts/webkitpy/port/base.py:
2376         (Port.__init__):
2377         (Port.driver_stop_timeout):
2378         (Port.check_image_diff):
2379         (Port.repository_paths):
2380         (Port._path_to_lighttpd_php):
2381         * Scripts/webkitpy/port/base_unittest.py:
2382         (PortTest.test_default_child_processes):
2383         (PortTest.test_pretty_patch_script_error):
2384         * Scripts/webkitpy/port/port_testcase.py:
2385         (PortTestCase.test_diff_image_crashed):
2386         * Scripts/webkitpy/port/test.py:
2387         (TestPort.operating_system):
2388
2389 2014-01-13  Martin Robinson  <mrobinson@igalia.com>
2390
2391         Build fix for the GTK+ CMake port
2392
2393         * TestWebKitAPI/PlatformGTK.cmake: The WKConnection test is no longer with us.
2394
2395 2014-01-13  Adrian Perez de Castro  <aperez@igalia.com>
2396
2397         [GTK] Add cast in call to g_object_add_weak_pointer in MiniBrowser
2398         https://bugs.webkit.org/show_bug.cgi?id=126881
2399
2400         Reviewed by Carlos Garcia Campos.
2401
2402         * MiniBrowser/gtk/BrowserWindow.c:
2403         (browser_window_new):
2404         Explicitly cast GtkWindow** to gpointer* in call to
2405         g_object_add_weak_pointer to avoid compiler warnings.
2406
2407 2014-01-13  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2408
2409         Remove parsing of old-run-webkit-tests output from master.cfg
2410         https://bugs.webkit.org/show_bug.cgi?id=126690
2411
2412         Reviewed by Csaba Osztrogonác.
2413
2414         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2415         Removed parsing of ORWT output, as it is not used anymore.
2416         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2417         Updated unit tests accordingly.
2418
2419 2014-01-13  Commit Queue  <commit-queue@webkit.org>
2420
2421         Unreviewed, rolling out r161808.
2422         http://trac.webkit.org/changeset/161808
2423         https://bugs.webkit.org/show_bug.cgi?id=126874
2424
2425         This patch make several files to be always regenerated on
2426         every make (Requested by KaL on #webkit).
2427
2428         * WebKitTestRunner/GNUmakefile.am:
2429
2430 2014-01-13  Adrian Perez de Castro  <aperez@igalia.com>
2431
2432         [GTK] Make MiniBrowser windows non-transient by default
2433         https://bugs.webkit.org/show_bug.cgi?id=126840
2434
2435         Reviewed by Carlos Garcia Campos.
2436
2437         Instead of making new browser windows transient as soon as they are
2438         created, save the pointer to the parent window and set the transient
2439         state later on when handling the "run-as-modal" signal. This makes
2440         it easier to use the MiniBrowser to do tests involving multiple
2441         windows, and will be useful as well when multi-web-process mode is
2442         enabled for the GTK port.
2443
2444         * MiniBrowser/gtk/BrowserWindow.c:
2445         (webViewRunAsModal): Set the parent window using
2446         gtk_window_set_transient_for() using the saved parent
2447         window.
2448         (browser_window_new): Save the parent window using
2449         g_object_set_data() instead of making the new window
2450         transient immediately.
2451
2452 2014-01-12  Sergio Correia  <sergio.correia@openbossa.org>
2453
2454         [EFL][WK2] Make API tests work again
2455         https://bugs.webkit.org/show_bug.cgi?id=126769
2456
2457         Reviewed by Gyuyoung Kim.
2458
2459         The EFL and WK2 test binaries are currently being generated at *TestWebKitAPI/
2460         [E]WebKit2, respectively, and this causes problems because the logic to find
2461         where WebProcess is to look in the same directory of the running process and
2462         then proceed to use LIBEXECDIR (typically /usr/loca/bin).
2463
2464         This patch introduces a WEBKIT_EXEC_PATH environment variable, inspired in the
2465         Gtk port, which allows us to look for WebProcess initially in this directory,
2466         if it's defined.
2467
2468         * TestWebKitAPI/efl/main.cpp:
2469         (main): Define WEBKIT_EXEC_PATH to be used by WebKit2 API tests.
2470
2471 2014-01-12  Daniel Bates  <dabates@apple.com>
2472
2473         [iOS] Fix the build
2474
2475         For now, ensure we build WebKit System Interface before we build WebKit.
2476         We'll remove this constraint and the constraint to build WebKit Additions
2477         in a subsequent commit.
2478
2479         * Scripts/build-webkit:
2480
2481 2014-01-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2482
2483         Unreviewed. Fix make distcheck.
2484
2485         * gtk/GNUmakefile.am: Add generate-inspector-gresource-manifest.py
2486         to EXTRA_DIST.
2487
2488 2014-01-12  Tobias Mueller  <tobiasmue@gnome.org>
2489
2490         --disable-dependency-tracking causes build failure due to missing directories
2491         https://bugs.webkit.org/show_bug.cgi?id=94488
2492
2493         Reviewed by Gustavo Noronha Silva.
2494
2495         Autotools build fix: Ensure output directory existing
2496         before generating DerivedSources. This allows for
2497         --disable-dependency-tracking to be run.
2498
2499
2500         * WebKitTestRunner/GNUmakefile.am: Added a new target of the directory in which files are meant to be stored.
2501
2502 2014-01-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2503
2504         [GTK] Fix return value of WebKitDownload::created-destination
2505         https://bugs.webkit.org/show_bug.cgi?id=126741
2506
2507         Reviewed by Martin Robinson.
2508
2509         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp: Fix return
2510         value of several callbacks.
2511
2512 2014-01-11  Sam Weinig  <sam@webkit.org>
2513
2514         Add support for null StringViews
2515         https://bugs.webkit.org/show_bug.cgi?id=126827
2516
2517         Reviewed by Anders Carlsson.
2518
2519         Add new test for StringView.
2520
2521         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2522         * TestWebKitAPI/Tests/WTF/StringView.cpp: Added.
2523         (TestWebKitAPI::TEST):
2524
2525 2014-01-10  Benjamin Poulain  <bpoulain@apple.com>
2526
2527         Remove the BlackBerry port from trunk
2528         https://bugs.webkit.org/show_bug.cgi?id=126715
2529
2530         Reviewed by Anders Carlsson.
2531
2532         * DumpRenderTree/DumpRenderTree.h:
2533         * DumpRenderTree/PixelDumpSupport.cpp:
2534
2535 2014-01-10  Daniel Bates  <dabates@apple.com>
2536
2537         [iOS] Fix project build order
2538
2539         Ensure we build WebKitAdditions before WebCore (if applicable). Also, we don't
2540         build WebInspectorUI, Tools/MiniBrowser, or Tools/WebKitTestRunner on iOS at the
2541         time of writing.
2542
2543         * Scripts/build-webkit:
2544
2545 2014-01-10  Mario Sanchez Prada  <mario.prada@samsung.com>
2546
2547         Move platformName property from testRunner to accessibilityController
2548         https://bugs.webkit.org/show_bug.cgi?id=126689
2549
2550         Reviewed by Chris Fleizach.
2551
2552         Move the platformName property from the testRunner into
2553         accessibilityController, since this is a concept that has only be
2554         used by accessibility tests since it got added, and also because
2555         the real intention was not to distinguish among "ports" (mac, win,
2556         gtk, efl) but between platforms (atk, mac, win).
2557
2558         This change will be very useful to merge GTK's roles-exposed.html
2559         and Mac's role-subrole-roledescription.html into one single test,
2560         since we will be specifying in the test itself which elements are
2561         supported in which accessibility "platform". In this context,
2562         being able to check accessibilityController.platformName directly
2563         against a list of supported accessibility platforms (e.g. "atk,mac")
2564         will certainly maintain the code cleaner and simpler.
2565
2566         * DumpRenderTree/TestRunner.h:
2567         (TestRunner::platformName): Removed.
2568         * DumpRenderTree/TestRunner.cpp:
2569         (getPlatformNameCallback): Removed.
2570         (TestRunner::staticValues): Removed platformName
2571         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2572         (TestRunner::platformName): Removed.
2573         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2574         (TestRunner::platformName): Removed.
2575         * DumpRenderTree/mac/TestRunnerMac.mm:
2576         (TestRunner::platformName): Removed.
2577         * DumpRenderTree/win/TestRunnerWin.cpp:
2578         (TestRunner::platformName): Removed.
2579
2580         * DumpRenderTree/AccessibilityController.h:
2581         (AccessibilityController::platformName): Added.
2582         * DumpRenderTree/AccessibilityController.cpp:
2583         (getPlatformNameCallback): Added.
2584         (AccessibilityController::getJSClass): Added platformName.
2585         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
2586         (AccessibilityController::platformName): Added, returning "atk".
2587         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2588         (AccessibilityController::platformName): Ditto, returning "mac".
2589         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
2590         (AccessibilityController::platformName): Ditto, returning "ios".
2591         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2592         (AccessibilityController::platformName): Ditto, returning "win".
2593
2594         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2595         (platformName): Removed.
2596         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2597         (TestRunner::platformName): Removed.
2598         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
2599         (TestRunner::platformName): Removed.
2600         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2601         (TestRunner::platformName): Removed.
2602         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2603         (TestRunner::platformName): Removed.
2604         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
2605         (TestRunner::platformName): Removed.
2606
2607         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2608         (WTR:AccessibilityController::platformName): Added.
2609         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
2610         (platformName): Added.
2611         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2612         (WTR::AccessibilityController::platformName): Added, returning "atk".
2613         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
2614         (WTR::AccessibilityController::platformName): Added, returning "mac".
2615
2616 2014-01-10  Benjamin Poulain  <bpoulain@apple.com>
2617
2618         Remove the BlackBerry port from trunk
2619         https://bugs.webkit.org/show_bug.cgi?id=126715
2620
2621         Reviewed by Anders Carlsson.
2622
2623         * Scripts/webkitpy/common/config/watchlist:
2624
2625 2014-01-09  Benjamin Poulain  <bpoulain@apple.com>
2626
2627         Remove the BlackBerry files outside WebCore
2628         https://bugs.webkit.org/show_bug.cgi?id=126715
2629
2630         Reviewed by Anders Carlsson.
2631
2632         * DumpRenderTree/blackberry: Removed.
2633
2634 2014-01-10  Simon Fraser  <simon.fraser@apple.com>
2635
2636         Remove knowledge of Blackberry from build scripts
2637         https://bugs.webkit.org/show_bug.cgi?id=126766
2638
2639         Reviewed by Anders Carlsson.
2640         
2641         Remove isBlackBerry() and references to it, and rmeove
2642         blackberry-related stuff from the watchlist.
2643
2644         * Scripts/build-webkit:
2645         * Scripts/webkit-build-directory:
2646         * Scripts/webkitdirs.pm:
2647         (determineBaseProductDir):
2648         (argumentsForConfiguration):
2649         (builtDylibPathForName):
2650         (isAppleWebKit):
2651         (buildCMakeProjectOrExit):
2652         (cmakeBasedPortArguments):
2653         (cmakeBasedPortName):
2654         * Scripts/webkitperl/FeatureList.pm:
2655         * Scripts/webkitpy/common/config/watchlist:
2656
2657 2014-01-10  Daniel Bates  <dabates@apple.com>
2658
2659         [iOS] Fix up simulator build and enable default features
2660
2661         Rubber-stamped by Joseph Pecoraro.
2662
2663         * Scripts/webkitdirs.pm:
2664         (determineArchitecture):
2665         (determinePassedArchitecture):
2666         * Scripts/webkitperl/FeatureList.pm: Also expose command line option to toggle ENABLE_PLUGIN_PROXY_FOR_VIDEO (enabled
2667         by default only in iOS).
2668
2669 2014-01-10  Daniel Bates  <dabates@apple.com>
2670
2671         [iOS] Upstream WebCore and Tools miscellaneous changes
2672         https://bugs.webkit.org/show_bug.cgi?id=126698
2673
2674         Reviewed by David Kilzer.
2675
2676         * Scripts/check-for-inappropriate-objc-class-names:
2677         * Scripts/check-for-webkit-framework-include-consistency:
2678
2679 2014-01-09  Dan Bernstein  <mitz@apple.com>
2680
2681         [Cocoa] Promote WKBackForwardList{,Item}.h to public
2682         https://bugs.webkit.org/show_bug.cgi?id=126707
2683
2684         Reviewed by Sam Weinig.
2685
2686         * Scripts/check-for-webkit-framework-include-consistency: Account for stale private headers
2687         left behind in the build products directory after a private header is made public.
2688
2689 2014-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2690
2691         [SOUP] Partial file left on disk after a download fails or is cancelled in WebKit2
2692         https://bugs.webkit.org/show_bug.cgi?id=126686
2693
2694         Reviewed by Martin Robinson.
2695
2696         Test that partial files are not left on disk after a download has
2697         been cancelled after the destination has been decided. To make
2698         sure the download is cancelled after the destination has been
2699         decided and before the operation finishes, we cancel the download
2700         in the destination decided callback, and we use an infinite
2701         resource that writes chunks to the response body and never
2702         completes the body.
2703
2704         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
2705         (addContentDispositionHTTPHeaderToResponse): Helper function to
2706         add the Content-Disposition to the response headers.
2707         (writeNextChunkIdle): Write next chunk to response body.
2708         (writeNextChunk): Write next chunk in an idle to avoid flooding
2709         the network with the inifnite resource.
2710         (serverCallback): Add an inifinite resource.
2711         (testDownloadRemoteFileError): Check that partial file is not
2712         present after the download has been cancelled.
2713
2714 2014-01-09  Roland Takacs  <rtakacs@inf.u-szeged.hu>
2715
2716         Move myself to the committers list.
2717
2718         Unreviewed.
2719
2720         * Scripts/webkitpy/common/config/contributors.json:
2721
2722 2014-01-08  Seokju Kwon  <seokju@webkit.org>
2723
2724         [GTK] Unreviewed build fix after r161522.
2725
2726         * TestWebKitAPI/GNUmakefile.am: Remove WKConnection.cpp and WKConnection_Bundle.cpp.
2727
2728 2014-01-08  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
2729
2730         Missleading style error when mixing system and non-system header include lines.
2731         https://bugs.webkit.org/show_bug.cgi?id=126564
2732
2733         Reviewed by Ryosuke Niwa.
2734
2735         * Scripts/webkitpy/style/checkers/cpp.py:
2736         (check_include_line):
2737         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2738         (OrderOfIncludesTest.test_check_alphabetical_include_order):
2739         (OrderOfIncludesTest.test_public_primary_header):
2740
2741 2014-01-08  Seokju Kwon  <seokju@webkit.org>
2742
2743         [EFL] Unreviewed build fix after r161522.
2744
2745         * TestWebKitAPI/CMakeLists.txt:
2746         * TestWebKitAPI/PlatformEfl.cmake:
2747
2748 2014-01-08  Anders Carlsson  <andersca@apple.com>
2749
2750         Remove WKConnectionRef tests
2751         https://bugs.webkit.org/show_bug.cgi?id=126666
2752
2753         Reviewed by Dan Bernstein.
2754
2755         The WKConnectionRef is poorly designed but thankfully not used anywhere. 
2756         Remove the API tests as a first step towards killing the entire thing.
2757
2758         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2759         * TestWebKitAPI/Tests/WebKit2/WKConnection.cpp: Removed.
2760         * TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp: Removed.
2761
2762 2014-01-08  Commit Queue  <commit-queue@webkit.org>
2763
2764         Unreviewed, rolling out r161512.
2765         http://trac.webkit.org/changeset/161512
2766         https://bugs.webkit.org/show_bug.cgi?id=126655
2767
2768         Broke webkitpy tests (Requested by ap on #webkit).
2769
2770         * Scripts/webkitpy/port/gtk.py:
2771         (GtkPort.__init__):
2772         (GtkPort.setup_test_run):
2773         (GtkPort._port_specific_expectations_files):
2774         * Scripts/webkitpy/port/leakdetector_valgrind.py: Removed.
2775         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Removed.
2776
2777 2014-01-08  Commit Queue  <commit-queue@webkit.org>
2778
2779         Unreviewed, rolling out r161517.
2780         http://trac.webkit.org/changeset/161517
2781         https://bugs.webkit.org/show_bug.cgi?id=126659
2782
2783         The fix didn't completely remove the problem and is now
2784         standing in the way of the rollout of the offending patch
2785         (Requested by zdobersek on #webkit).
2786
2787         * Scripts/webkitpy/port/gtk.py:
2788         (GtkPort.__init__):
2789
2790 2014-01-08  Zan Dobersek  <zdobersek@igalia.com>
2791
2792         Unreviewed. Attempting to fix webkitpy tests after r161512.
2793
2794         * Scripts/webkitpy/port/gtk.py:
2795         (GtkPort.__init__): Construct LeakDetectorValgrin only if leak detection is enabled.
2796
2797 2014-01-08  Brian Holt  <brian.holt@samsung.com>
2798
2799         [GTK] Parse Valgrind xml leak files
2800         https://bugs.webkit.org/show_bug.cgi?id=119446
2801
2802         Reviewed by Alejandro G. Castro.
2803
2804         Parse the xml files generated by Valgrind to yield useful
2805         information about the memory leaks.
2806
2807         * Scripts/webkitpy/port/gtk.py:
2808         (GtkPort.__init__):
2809         (GtkPort.setup_test_run): Clear the previous output files before new
2810         run.
2811         (GtkPort.print_leaks_summary):
2812
2813         * Scripts/webkitpy/port/leakdetector_valgrind.py: Added.
2814         Parse the xml files generated by Valgrind and summarise leaks
2815         into an easily understandable list.
2816         (get_text_of):
2817         (get_CDATA_of):
2818         (gather_frames):
2819         (ValgrindError):
2820         (ValgrindError.__init__):
2821         (ValgrindError.__str__):
2822         (ValgrindError.unique_string):
2823         (ValgrindError.error_hash):
2824         (ValgrindError.__hash__):
2825         (ValgrindError.__eq__):
2826         (LeakDetectorValgrind):
2827         (LeakDetectorValgrind.__init__):
2828         (LeakDetectorValgrind._parse_leaks_output):
2829         (LeakDetectorValgrind.leaks_files_in_results_directory):
2830         (LeakDetectorValgrind.clean_leaks_files_from_results_directory):
2831         (LeakDetectorValgrind.parse_and_print_leaks_detail):
2832
2833         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Added.
2834         (make_mock_valgrind_output):
2835         (make_mock_incomplete_valgrind_output):
2836         (make_mock_valgrind_results):
2837         (make_mock_valgrind_results_incomplete):
2838         (make_mock_valgrind_results_empty):
2839         (make_mock_valgrind_results_misformatted):
2840         (LeakDetectorValgrindTest):
2841         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
2842         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
2843         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
2844         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
2845         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
2846         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
2847         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
2848         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
2849
2850 2014-01-08  Commit Queue  <commit-queue@webkit.org>
2851
2852         Unreviewed, rolling out r161427.
2853         http://trac.webkit.org/changeset/161427
2854         https://bugs.webkit.org/show_bug.cgi?id=126645
2855
2856         Emits a stye error on any newly added files (Requested by ap
2857         on #webkit).
2858
2859         * Scripts/webkitpy/style/checkers/cpp.py:
2860         (check_style):
2861         (CppChecker):
2862         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2863         (WebKitStyleTest.test_other):
2864
2865 2014-01-08  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2866
2867         Remove run-webkit-tests wrapper script as all platform are using NRWT now.
2868         https://bugs.webkit.org/show_bug.cgi?id=126580
2869
2870         Reviewed by Csaba Osztrogonác.
2871
2872         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2873         (RunWebKitTests): Passing --debug-rwt-logging here instead of the
2874         run-webkit-tests script.
2875         * Scripts/new-run-webkit-tests: Renamed to run-webkit-tests.
2876         * Scripts/run-webkit-tests: Removed, as it was just a temporary hack.
2877
2878 2014-01-08  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2879
2880         Update the list of non-committer u-szeged contributors
2881         https://bugs.webkit.org/show_bug.cgi?id=126640
2882
2883         Reviewed by Csaba Osztrogonác.
2884
2885         * Scripts/webkitpy/common/config/contributors.json:
2886
2887 2014-01-08  Alberto Garcia  <berto@igalia.com>
2888
2889         Fix some compilation warnings
2890         https://bugs.webkit.org/show_bug.cgi?id=126635
2891
2892         Reviewed by Csaba Osztrogonác.
2893
2894         * GtkLauncher/main.c:
2895         (createWindow): This function is not supposed to receive any
2896         parameter, yet we are passing one.
2897
2898 2014-01-08  Brian Holt  <brian.holt@samsung.com>
2899
2900         [GTK][WK2] unskip passing unit tests
2901         https://bugs.webkit.org/show_bug.cgi?id=126637
2902
2903         Reviewed by Carlos Garcia Campos.
2904
2905         Unskip TestResources and TestAuthentication unit tests since they
2906         are passing both under Xvfb and X.
2907
2908         * Scripts/run-gtk-tests:
2909         (TestRunner):
2910
2911 2014-01-08  Alberto Garcia  <berto@igalia.com>
2912
2913         REGRESSION(r160304): [GTK] Disable libtool fast install
2914         https://bugs.webkit.org/show_bug.cgi?id=126381
2915
2916         Reviewed by Gustavo Noronha Silva.
2917
2918         Disable the libtool fast-install mode in developer/test builds.
2919
2920         In this mode binaries are generated ready to be used directly from
2921         the build tree. Otherwise they would need to be relinked when they
2922         are executed, which can take a lot of resources, particularly in
2923         debug builds.
2924
2925         * Scripts/webkitdirs.pm:
2926         (runAutogenForAutotoolsProjectIfNecessary):
2927
2928 2014-01-08  Zan Dobersek  <zdobersek@igalia.com>
2929
2930         Unreviewed GTK gardening.
2931
2932         * Scripts/run-gtk-tests:
2933         (TestRunner): Skipping the snapshot test case from the TestWebKitWebView test suite.
2934         The test is failing due to issues with Xvfb, with the problem being handled in bug #120404.
2935
2936 2014-01-07  Lucas Forschler  <lforschler@apple.com>
2937
2938         Add buildbot infrasctructure for building and testing JSC cloop
2939         https://bugs.webkit.org/show_bug.cgi?id=126604
2940
2941         Reviewed by Geoffrey Garen.
2942
2943         * BuildSlaveSupport/build.webkit.org-config/config.json:
2944         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2945         (CompileCLOOP):
2946         (RunCLOOPTests):
2947         (RunCLOOPTests.countFailures):
2948         (BuildAndTestCLOOP):
2949
2950 2014-01-07  Brian Burg  <bburg@apple.com>
2951
2952         Unreviewed. Add myself as a committer.
2953
2954         * Scripts/webkitpy/common/config/contributors.json:
2955
2956 2014-01-07  Alexey Proskuryakov  <ap@apple.com>
2957
2958         Popovers at build.webkit.org/dashboard could have titles
2959         https://bugs.webkit.org/show_bug.cgi?id=126495
2960
2961         Reviewed by Timothy Hatcher.
2962
2963         Added titles to all popovers except for pending revisions one, which I would like
2964         to improve more (probably add an ETA).
2965
2966         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
2967         (BuildbotBuilderQueueView.prototype._presentPopoverFailureLogs): Moved code for 
2968         adding a title to base class.
2969
2970         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2971         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Moved code for inserting
2972         a divider to a separate function.
2973         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Added a title.
2974         (BuildbotQueueView.prototype._presentNoChangePopover): Updated the text to match
2975         title from above function.
2976         (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Renamed "contentElement"
2977         variable to "content" to match all other code.
2978         (BuildbotQueueView.prototype._addIterationHeadingToPopover): Added.
2979         (BuildbotQueueView.prototype._addDividerToPopover): Added.
2980
2981         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2982         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions): Add a title.
2983         (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions): Ditto.
2984         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): Ditto.
2985
2986         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
2987
2988 2014-01-07  Alexey Proskuryakov  <ap@apple.com>
2989
2990         There should be a delay when quickly switching to a different popover at build.webkit.org/dashboard
2991         https://bugs.webkit.org/show_bug.cgi?id=126472
2992
2993         Reviewed by Timothy Hatcher.
2994
2995         Added a delay when quickly switching to a different popover, making it easier to
2996         move mouse pointer from active element to its popover without accidentally opening
2997         a different popover.
2998
2999         Used this code to add a delay before creating a popover. This doesn't change UI
3000         behavior, as there was alerady a delay before it became visible, but it avoids
3001         flooding buildbot server with http requests when quickly moving the mouse over
3002         dashboard page.
3003
3004         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js:
3005         Fixed a case where popover could get stuck. If content was updated while fade-out
3006         transition was already in place, the transition was removed for no good reason.
3007
3008         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
3009         (PopoverTracker._onblur): While at it, also taught popovers to disappear on window blur.
3010
3011         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:
3012         (.popover.step-in): Now that PopoverTracker has a 200ms delay of its own, reduced
3013         popover delay from 1s to 800ms.
3014
3015 2014-01-07  Alexey Proskuryakov  <ap@apple.com>
3016
3017         Improve display of failed builds at build.webkit.org/dashboard
3018         https://bugs.webkit.org/show_bug.cgi?id=126542
3019         <rdar://problem/15753550>
3020
3021         Reviewed by Timothy Hatcher.
3022
3023         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
3024         Instead of hardcoding step name, look for the first step that failed.
3025         While at it, added a popover with more links. There are multiple, and it's good
3026         to have a choice of which one to look at in each situation.
3027
3028         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3029         (BuildbotIteration.prototype.get successful): Being successful is not the opposite
3030         of having failed. Many iterations are interrupted for whatever reason internal to
3031         Buildbot, and these are suppoed to be orange, not red.
3032         (BuildbotIteration.prototype.get productive): Changed to exclude inerrupted iterations,
3033         not only WillRetry ones.
3034         (BuildbotIteration.prototype.get failed): Changed to only include iterations that
3035         actually failed, more likely indicating a problem with code base.
3036         (BuildbotIteration.prototype.get firstFailedStepName):
3037         (BuildbotIteration.prototype.failureLogURL): Expose informaiton about failure.
3038         (BuildbotIteration.prototype.get failureLogs): Ditto.
3039         (BuildbotIteration.prototype.update): Store complete results for the failed step.
3040         Not every failure stops the iteration, so we could have multiple failed steps,
3041         but let's see if seeing just the first one will be enough.
3042
3043         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3044         (BuildbotQueue.prototype.get firstRecentUnsuccessfulIteration): Updated to work in
3045         terms of successful iterations.
3046         (BuildbotQueue.prototype.get mostRecentSuccessfulIteration): Ditto.
3047
3048         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3049         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Updated to work in
3050         terms of successful iterations.
3051
3052         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3053         Removed code to create a path to build output, we now take it from results JSON.
3054
3055         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
3056         Added styles for the new popover.
3057
3058 2014-01-07  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
3059
3060         defined constants should use all uppercase names with words separated by underscores.
3061         https://bugs.webkit.org/show_bug.cgi?id=126055
3062
3063         Reviewed by Alexey Proskuryakov.
3064
3065         * Scripts/webkitpy/style/checkers/cpp.py:
3066         (check_style):
3067         (CppChecker):
3068         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3069         (WebKitStyleTest.test_define_constants):
3070
3071 2014-01-07  Brian Holt  <brian.holt@samsung.com>
3072
3073         Unreviewed. Add myself as a committer.
3074
3075         * Scripts/webkitpy/common/config/contributors.json:
3076
3077 2014-01-07  Csaba Osztrogonác  <ossy@webkit.org>
3078
3079         Remove the WinCE buildbot from build.webkit.org
3080         https://bugs.webkit.org/show_bug.cgi?id=126517
3081
3082         Reviewed by Alexey Proskuryakov.
3083
3084         * BuildSlaveSupport/build.webkit.org-config/config.json:
3085         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3086         (appendCustomBuildFlags):
3087
3088 2014-01-07  Krzysztof Czech  <k.czech@samsung.com>
3089
3090         [EFL] Change ATK version to 2.11.4
3091         https://bugs.webkit.org/show_bug.cgi?id=126573
3092
3093         Reviewed by Gyuyoung Kim.
3094
3095         ATK 2.11.4 introduces some new roles, that are already being used by WebKit.
3096
3097         * efl/jhbuild.modules:
3098
3099 2014-01-07  Alberto Garcia  <berto@igalia.com>
3100
3101         [GTK][EFL] Use function jhbuildWrapperPrefixIfNeeded to run launcher
3102         https://bugs.webkit.org/show_bug.cgi?id=117275
3103
3104         Reviewed by Carlos Garcia Campos.
3105
3106         If we are not using the internal jhbuild we must not use the
3107         jhbuild-wrapper script, else it will try to download and install
3108         it.
3109
3110         * Scripts/run-launcher:
3111
3112 2014-01-07  Krzysztof Czech  <k.czech@samsung.com>
3113
3114         [ATK] Expose aria-checked mixed state as ATK_STATE_INDETERMINATE
3115         https://bugs.webkit.org/show_bug.cgi?id=125855
3116
3117         Reviewed by Mario Sanchez Prada.
3118
3119         Added new function isIndeterminate for testing aria-checked mixed state.
3120         I provided respective, but empty function in mac port. Mac testing it differently.
3121
3122         * DumpRenderTree/AccessibilityUIElement.cpp:
3123         (getIsIndeterminate):
3124         (AccessibilityUIElement::getJSClass):
3125         * DumpRenderTree/AccessibilityUIElement.h:
3126         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3127         (AccessibilityUIElement::isIndeterminate):
3128         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: Added empty function.
3129         (AccessibilityUIElement::isIndeterminate):
3130         * DumpRenderTree/mac/AccessibilityUIElementMac.mm: Added empty function.
3131         (AccessibilityUIElement::isIndeterminate):
3132         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Added empty function.
3133         (AccessibilityUIElement::isIndeterminate):
3134         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3135         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3136         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3137         (WTR::AccessibilityUIElement::isIndeterminate):
3138         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3139         (WTR::AccessibilityUIElement::isIndeterminate):
3140
3141 2014-01-06  Mark Rowe  <mrowe@apple.com>
3142
3143         <https://webkit.org/b/126560> Fix incorrectness in use of some AppKit enums
3144
3145         Reviewed by Ryosuke Niwa.
3146
3147         * DumpRenderTree/mac/DumpRenderTree.mm:
3148         (-[DRTMockScroller rectForPart:]): Move to using an if with early return instead of a switch
3149         with a single case. This avoids the potential for warnings about unhandled cases.
3150         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3151         (WTR::PlatformWebView::PlatformWebView): Cast the argument to NSBackingStoreType.
3152
3153 2014-01-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3154
3155         [GTK] Move all GTK/GObject unit tests to Tools/TestWebKitAPI
3156         https://bugs.webkit.org/show_bug.cgi?id=126342
3157
3158         Reviewed by Gustavo Noronha Silva.
3159
3160         * CMakeLists.txt: Include the new unit tests subdirectories.
3161         * Scripts/run-gtk-tests: Update to refer to the new build locations.
3162         * Scripts/webkitpy/style/checker.py: Update the style checker.
3163         * Scripts/webkitpy/style/checker_unittest.py:
3164         * TestWebKitAPI/GNUmakefile.am:
3165         * TestWebKitAPI/Tests/WebKit2Gtk/AccessibilityTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/AccessibilityTestServer.cpp.
3166         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Added.
3167         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp: Added.
3168         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/DOMNodeTest.cpp.
3169         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/FrameTest.cpp.
3170         * TestWebKitAPI/Tests/WebKit2Gtk/InspectorTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/InspectorTestServer.cpp.
3171         * TestWebKitAPI/Tests/WebKit2Gtk/LoadTrackingTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/LoadTrackingTest.cpp.
3172         * TestWebKitAPI/Tests/WebKit2Gtk/LoadTrackingTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/LoadTrackingTest.h.
3173         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestAuthentication.cpp.
3174         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestBackForwardList.cpp.
3175         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestContextMenu.cpp.
3176         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestCookieManager.cpp.
3177         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMDOMWindow.cpp: Added.
3178         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestDOMNode.cpp.
3179         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestDownloads.cpp.
3180         * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestFrame.cpp.
3181         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestInspector.cpp.
3182         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestInspectorServer.cpp.
3183         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestLoaderClient.cpp.
3184         * TestWebKitAPI/Tests/WebKit2Gtk/TestMain.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestMain.cpp.
3185         * TestWebKitAPI/Tests/WebKit2Gtk/TestMain.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestMain.h.
3186         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestPrinting.cpp.
3187         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestResources.cpp.
3188         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestSSL.cpp.
3189         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestUIClient.cpp.
3190         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebExtensions.cpp.
3191         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitAccessibility.cpp.
3192         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp.
3193         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFindController.cpp.
3194         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitPolicyClient.cpp.
3195         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitSettings.cpp.
3196         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitVersion.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitVersion.cpp.
3197         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebContext.cpp.
3198         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp.
3199         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebViewGroup.cpp.
3200         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebViewEditor.cpp.
3201         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebExtensionTest.cpp.
3202         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestBus.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestBus.cpp.
3203         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestBus.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestBus.h.
3204         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestServer.cpp.
3205         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestServer.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestServer.h.
3206         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.cpp.
3207         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.h.
3208         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTestRunner.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTestRunner.cpp.
3209         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTestRunner.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTestRunner.h.
3210         * TestWebKitAPI/Tests/WebKit2Gtk/WebViewTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.cpp.
3211         * TestWebKitAPI/Tests/WebKit2Gtk/WebViewTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.h.
3212         * TestWebKitAPI/Tests/WebKit2Gtk/resources/link-title.js: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/link-title.js.
3213         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test-cert.pem: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/test-cert.pem.
3214         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test-key.pem: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/test-key.pem.
3215         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/webkit2gtk-tests.gresource.xml.
3216         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Added.
3217         * TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Renamed from Source/WebKit/gtk/tests/resources/blank.ico.
3218         * TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Renamed from Source/WebKit/gtk/tests/resources/test.html.
3219         * TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Renamed from Source/WebKit/gtk/tests/resources/test.ogg.
3220         * TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Renamed from Source/WebKit/gtk/tests/resources/test.pdf.
3221         * TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Renamed from Source/WebKit/gtk/tests/resources/test.txt.
3222         * TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Renamed from Source/WebKit/gtk/tests/test_utils.c.
3223         * TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Renamed from Source/WebKit/gtk/tests/test_utils.h.
3224         * TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Renamed from Source/WebKit/gtk/tests/testapplicationcache.c.
3225         * TestWebKitAPI/Tests/WebKitGtk/testatk.c: Renamed from Source/WebKit/gtk/tests/testatk.c.
3226         * TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Renamed from Source/WebKit/gtk/tests/testatkroles.c.
3227         * TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Renamed from Source/WebKit/gtk/tests/testcontextmenu.c.
3228         * TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Renamed from Source/WebKit/gtk/tests/testcopyandpaste.c.
3229         * TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Renamed from Source/WebKit/gtk/tests/testdomdocument.c.
3230         * TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Renamed from Source/WebKit/gtk/tests/testdomdomwindow.c.
3231         * TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Renamed from Source/WebKit/gtk/tests/testdomnode.c.
3232         * TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Renamed from Source/WebKit/gtk/tests/testdownload.c.
3233         * TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Renamed from Source/WebKit/gtk/tests/testfavicondatabase.c.
3234         * TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Renamed from Source/WebKit/gtk/tests/testglobals.c.
3235         * TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Renamed from Source/WebKit/gtk/tests/testhittestresult.c.
3236         * TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Renamed from Source/WebKit/gtk/tests/testhttpbackend.c.
3237         * TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Renamed from Source/WebKit/gtk/tests/testkeyevents.c.
3238         * TestWebKitAPI/Tests/WebKitGtk/testloading.c: Renamed from Source/WebKit/gtk/tests/testloading.c.
3239         * TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Renamed from Source/WebKit/gtk/tests/testmimehandling.c.
3240         * TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Renamed from Source/WebKit/gtk/tests/testnetworkrequest.c.
3241         * TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Renamed from Source/WebKit/gtk/tests/testnetworkresponse.c.
3242         * TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Renamed from Source/WebKit/gtk/tests/testwebbackforwardlist.c.
3243         * TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Renamed from Source/WebKit/gtk/tests/testwebdatasource.c.
3244         * TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Renamed from Source/WebKit/gtk/tests/testwebframe.c.
3245         * TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Renamed from Source/WebKit/gtk/tests/testwebhistoryitem.c.
3246         * TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Renamed from Source/WebKit/gtk/tests/testwebinspector.c.
3247         * TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Renamed from Source/WebKit/gtk/tests/testwebplugindatabase.c.
3248         * TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Renamed from Source/WebKit/gtk/tests/testwebresource.c.
3249         * TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Renamed from Source/WebKit/gtk/tests/testwebsettings.c.
3250         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Renamed from Source/WebKit/gtk/tests/testwebview.c.
3251         * TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Renamed from Source/WebKit/gtk/tests/testwindow.c.
3252
3253 2014-01-06  Alexey Proskuryakov  <ap@apple.com>
3254
3255         Gtk and Efl API test results confuse the dashboard
3256         https://bugs.webkit.org/show_bug.cgi?id=126535
3257
3258         Reviewed by Tim Horton.
3259
3260         Added "API tests" step as "platform api tests".
3261
3262         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3263         (Buildbot.prototype.platformAPITestResultsURLForIteration):
3264         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3265         (BuildbotIteration):
3266         (BuildbotIteration.prototype.update):
3267         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3268         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
3269         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
3270
3271 2014-01-06  Tim Horton  <timothy_horton@apple.com>
3272
3273         build.webkit.org/dashboard should still function if localStorage is disabled
3274         https://bugs.webkit.org/show_bug.cgi?id=126511
3275
3276         Reviewed by Alexey Proskuryakov.
3277
3278         If localStorage is disabled, we should carry on with a warning.
3279
3280         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3281         Don't show the gear if localStorage isn't working.
3282
3283         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
3284         (QueueView.prototype._updateHiddenState):
3285         Bail if localStorage isn't working.
3286
3287         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
3288         (Settings.prototype.available):
3289
3290 2014-01-02  Roger Fong  <roger_fong@apple.com>
3291
3292         Set VSINSTALLDIR in win ews start script.
3293         https://bugs.webkit.org/show_bug.cgi?id=126407
3294
3295         Reviewed by Brent Fulgham.
3296
3297         * EWSTools/start-queue-win.sh:
3298
3299 2014-01-06  Bem Jones-Bey  <bjonesbe@adobe.com>
3300
3301         Adding myself as a reviewer.
3302
3303         Unreviewed.
3304
3305         * Scripts/webkitpy/common/config/contributors.json:
3306
3307 2014-01-06  Zan Dobersek  <zdobersek@igalia.com>
3308
3309         Unreviewed. Unbreaking JSC tests after r161328.
3310
3311         * Scripts/webkitdirs.pm:
3312         (cmakeBasedPortName): Only recognize the GTK port as CMake-based if actually building
3313         through the CMake build system (i.e. passing --gtkcmake to build-webkit).
3314
3315 2014-01-05  Martin Robinson  <mrobinson@igalia.com>
3316
3317         [GTK][CMake] Add support for building the GTK+ port with cmake to build-webkit
3318         https://bugs.webkit.org/show_bug.cgi?id=126212
3319
3320         Reviewed by Daniel Bates.
3321
3322         Allow building the GTK+ cmake port with --gtkcmake.
3323
3324         * Scripts/build-webkit: Use the new isGtkCMake function to head down the CMake path
3325         when appropriate. Skip the autotoos path when isGtkAutotools is false.
3326         * Scripts/webkitdirs.pm: Add an isGtkCMake path in addition to the newly renamed isGtkAutotools.
3327         Add isGtk which checks isGtkCMake || isGtkAutotools
3328         (determineArchitecture): Use the CMake path for GTK+ when appropriate.
3329         (argumentsForConfiguration): use --gtkcmake when appropriate.
3330         (jscProductDir): Look in the CMake directory when appropriate.
3331         (builtDylibPathForName): CMake builds the library into a different directory, so handle that.
3332         (determineIsGtkCMake): Added.
3333         (isGtkCMake): Added.
3334         (isGtkAutotools): Renamed from isGtk.
3335         (isGtk): New function which returns isGtkAutotools || isGtkCMake.
3336         (determineIsGtkAutotools): Renamed from determineIsGtk.
3337         (cmakeBasedPortName): Added a GTK+ path.
3338
3339 2014-01-04  Martin Robinson  <mrobinson@igalia.com>
3340
3341         [GTK] [CMake] Fix the video and audio build
3342         https://bugs.webkit.org/show_bug.cgi?id=126464
3343
3344         Reviewed by Philippe Normand.
3345
3346         * GtkLauncher/CMakeLists.txt: Add GStreamer includes and libraries, since GtkLauncher uses it.
3347
3348 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
3349
3350         It's confusing to have two elements link to the same URL at build.webkit.org/dashboard
3351         https://bugs.webkit.org/show_bug.cgi?id=126467
3352
3353         Reviewed by Geoffrey Garen.
3354
3355         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
3356         (StatusLineView): Don't linkify the label text, the bubble is easier to target with mouse
3357         pointer, or to tap.
3358
3359 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
3360
3361         build.webkit.org/dashboard says "failed build" even if it's another step that failed
3362         https://bugs.webkit.org/show_bug.cgi?id=126461
3363
3364         Reviewed by Geoffrey Garen.
3365
3366         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
3367         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Link to main
3368         build page if it's not the compilation that failed. Use text from buildbot for description.
3369         Show a yellow icon if it's a different kind of failure.
3370
3371         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3372         (BuildbotIteration.prototype.update): Record whether it was compile-webkit step that failed.
3373
3374 2014-01-03  Bem Jones-Bey  <bjonesbe@adobe.com>
3375
3376         setup-git-clone fails to get email address from git
3377         https://bugs.webkit.org/show_bug.cgi?id=126446
3378
3379         Reviewed by Ryosuke Niwa.
3380
3381         The setup-git-clone command fails to get an email address from git
3382         because of a bug in VCSUtils. This patch fixes that bug, and also
3383         makes it so that when VCSUtils fails for real because of a local
3384         misconfiguration, the error message is actually presented to the user
3385         of setup-git-clone.
3386
3387         * Scripts/VCSUtils.pm:
3388         (gitConfig): Call isGit() instead of accessing $isGit directly to make
3389             sure that $isGit is properly initialized.
3390         * Scripts/webkitpy/tool/commands/setupgitclone.py:
3391         (SetupGitClone.execute): Pull out username and email acquistion to
3392             it's own method.
3393         (SetupGitClone._get_username_and_email): Catch the exception thrown
3394             when VCSUtils fails and print out the error message so that the
3395             user actually knows why the command failed.
3396
3397 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
3398
3399         It feels too hard to get rid of a popover at build.webkit.org/dashboard
3400         https://bugs.webkit.org/show_bug.cgi?id=126451
3401
3402         Reviewed by Simon Fraser.
3403
3404         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:
3405         (.popover.fade-out): Reduced the timeout - 200 ms is enough to not have flicker
3406         when moving the mouse from an element to its popover.
3407
3408 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
3409
3410         Please add a way to quick peek at failing tests at build.webkit.org/dashboard
3411         https://bugs.webkit.org/show_bug.cgi?id=122181
3412
3413         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3414         (BuildbotQueueView.prototype._presentNoChangePopover): Update one more place for
3415         popover.present signature change.
3416
3417 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
3418
3419         Please add a way to quick peek at failing tests at build.webkit.org/dashboard
3420         https://bugs.webkit.org/show_bug.cgi?id=122181
3421
3422         Reviewed by Timothy Hatcher and Timothy Horton.
3423
3424         Detailed results are saved by run-webkit-tests to full_results.json (which is actually
3425         JSONP). Dashboard will load them on demand.
3426
3427         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3428         (Buildbot.prototype.layoutTestResultsURLForIteration): Moved from WebKitBuildbot.js
3429         and made it use a function from WebKitBuildbot that builds results directory path.
3430         (Buildbot.prototype.layoutTestFullResultsURLForIteration): Added a function that builds
3431         a URL for full_results.json.
3432         (Buildbot.prototype.layoutTestCrashLogForIteration): Added a function that builds
3433         a URL for a crash log.
3434
3435         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3436         (BuildbotIteration.prototype.loadLayoutTestResults): Load and cache layout test results for
3437         the iteration.
3438
3439         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:        
3440         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Updated for changed
3441         popover API (see below).
3442         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Ditto.
3443
3444         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3445         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Added a check
3446         for iterations that were interrupted (previously, they were displayed incorrectly,
3447         often as passes). Install popover trackers for failure bubbles for which we can currently
3448         display something useful.
3449         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions): Build
3450         a popover for layout test regressions when we have the data loaded on demand.
3451         We have test paths, special indicators for crashes/timeouts, and links to test history
3452         at flakiness dashboard.
3453         (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions): Show
3454         the popover for layout test regressions. Just shows "Loading..." until the data is
3455         loaded.
3456         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): List
3457         types of failures if there are multiple. There is a lot of similarity with
3458         appendBuilderQueueStatus(), but I couldn't find a good way to share the code.
3459
3460         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
3461         Create a global test history object, which is used for links in layout test popover.
3462
3463         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js:
3464         Changed the API to be more like WebInspector again, allowing for changing content
3465         of an existing popover. As the size of a popover can change, making the mouse pointer
3466         enter it without a mousenter event, install a handler for mousewheel instead, and block
3467         document scrolling from this event handler when needed.
3468
3469         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
3470         (StatusLineView.prototype.get statusBubbleElement): Added an accessor for status
3471         bubble element, making it possible to install a popover on it.
3472
3473         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
3474         (JSON.load): Added the ability to load JSONP by providing an optional callback name.
3475
3476         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3477         (WebKitBuildbot.prototype.layoutTestResultsDirectoryURLForIteration): Switched from
3478         building a complete results URL to only building one for root results path. This is
3479         the part that depends on specific buildbot installation, everything relative to it
3480         is the same.
3481
3482         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js: Added.
3483         Build a path to test history page. In the future, we may consider adding code to
3484         load the data and display it inline.
3485
3486         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
3487         Added styles for this new popover.
3488
3489         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added
3490         a new file, WebKitTestHistory.js.
3491
3492 2014-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3493
3494         REGRESSION(r161214): [GTK] WebKit2 C API tests fail to run after r161214
3495         https://bugs.webkit.org/show_bug.cgi?id=126430
3496
3497         Reviewed by Martin Robinson.
3498
3499         * Scripts/run-gtk-tests:
3500         (TestRunner._setup_testing_environment):
3501         * gtk/common.py: Use common.tests_library_build_path() instead.
3502         (tests_library_build_path): Helper funtion that returns the path
3503         where the tests libraries are built.
3504
3505 2014-01-03  Martin Robinson  <mrobinson@igalia.com>
3506
3507         [CMake] Build TestWebKitAPI tests into a directory structure
3508         https://bugs.webkit.org/show_bug.cgi?id=126358
3509
3510         Reviewed by Gyuyoung Kim.
3511
3512         WebKitGTK+ builds the TestWebKitAPI tests into a "TestWebKitAPI" directory. This
3513         is useful for keeping the "bin" directory tidy during building and will make it easier
3514         to integrate the CMake build into the existing WebKitGTK+ scripts.
3515
3516         * TestWebKitAPI/CMakeLists.txt: Set the output directory of all TestWebKitAPI binaries
3517         and make the names simpler now that the directory identifies what category the test is in.
3518
3519 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
3520
3521         Provide a visual clue when element has a popover at build.webkit.org/dashboard
3522         https://bugs.webkit.org/show_bug.cgi?id=126281
3523
3524         Reviewed by Timothy Hatcher.
3525
3526         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
3527         (PopoverTracker): Add a class name to elements with popovers.
3528
3529         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3530         (*): We have -webkit-user-select:none, so let's also not show text selection cursor.
3531         I might have broke that recently.
3532         (*:link): Show hand cursor over links.
3533         (.popover-tracking:hover): Put a shadow on hover over element with popovers.
3534
3535         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3536         (.status-line .message .revision-number): Show text selection cursor on our only
3537         selectable text element.
3538         (.status-line .bubble.popover-tracking:hover): Text in a bubble looks better with
3539         a white shadow than with a dark one on hover.
3540
3541 2014-01-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3542
3543         [GTK] Add API to WebKitResponsePolicyDecision to check if the MIME type can be shown
3544         https://bugs.webkit.org/show_bug.cgi?id=124652
3545
3546         Reviewed by Martin Robinson.
3547
3548         * MiniBrowser/gtk/BrowserWindow.c:
3549         (webViewDecidePolicy): Use the new API instead of
3550         webkit_web_view_can_show_mime_type().
3551
3552 2014-01-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3553
3554         REGRESSION(r160304): [GTK] Disable libtool fast install
3555         https://bugs.webkit.org/show_bug.cgi?id=126381
3556
3557         Reviewed by Martin Robinson.
3558
3559         Remove -no-fast-install ld flag since fast install is now disabled
3560         globally.
3561
3562         * GNUmakefile.am:
3563         * GtkLauncher/GNUmakefile.am:
3564         * MiniBrowser/gtk/GNUmakefile.am:
3565         * TestWebKitAPI/GNUmakefile.am:
3566         * WebKitTestRunner/GNUmakefile.am:
3567
3568 2014-01-02  Ryuan Choi  <ryuan.choi@samsung.com>
3569
3570  &n