ca155e82926af177419ea35044b1f18e7150d6dc
[WebKit-https.git] / Tools / ChangeLog
1 2019-03-06  Rob Buis  <rbuis@igalia.com>
2
3         Consider supporting the `referrerpolicy` attribute.
4         https://bugs.webkit.org/show_bug.cgi?id=179053
5
6         Reviewed by Darin Adler.
7
8         Add a runtime flag for referrerpolicy attribute.
9
10         * DumpRenderTree/mac/DumpRenderTree.mm:
11         (enableExperimentalFeatures):
12
13 2019-03-05  Daniel Bates  <dabates@apple.com>
14
15         Update expected API test result following r242379
16         (https://bugs.webkit.org/show_bug.cgi?id=195125)
17
18         Update expected x-coordinate of selection rect now that the left padding of
19         a textarea is sized in ems (so dependent on the font size) just like the left
20         padding of a text field.
21
22         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
23         (TestWebKitAPI::TEST):
24
25 2019-03-05  David Quesada  <david_quesada@apple.com>
26
27         [WK2] It should be possible to follow links with 'download' attributes
28         https://bugs.webkit.org/show_bug.cgi?id=195145
29         rdar://problem/48462642
30
31         Reviewed by Alex Christensen.
32
33         Add a unit test to verify that activating links with 'download' attributes now
34         navigates to the linked resource, rather than starts downloading it. Add another
35         to verify that it is still possible to explicitly download the link via the
36         'Download' navigation action policy.
37
38         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
39         (-[DownloadAttributeTestDelegate init]):
40         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
41         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
42         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
43         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
44         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
45         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
46         (TEST):
47         * WebKitTestRunner/TestController.cpp:
48         (WTR::TestController::decidePolicyForNavigationAction):
49         * WebKitTestRunner/TestController.h:
50
51 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
52
53         [Curl] Implement Cookie Accept Policy.
54         https://bugs.webkit.org/show_bug.cgi?id=191645
55
56         Reviewed by Fujii Hironori.
57
58         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
59         (TestWebKitAPI::Curl::TEST_F):
60
61 2019-03-05  Youenn Fablet  <youenn@apple.com>
62
63         Rename requestCacheStorageSpace to requestStorageSpace
64         https://bugs.webkit.org/show_bug.cgi?id=195282
65
66         Reviewed by Chris Dumez.
67
68         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
69         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
70         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
71
72 2019-03-05  Brady Eidson  <beidson@apple.com>
73
74         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
75         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
76
77         Reviewed by Tim Horton.
78
79         Loading a file: URL into a WKWebView and then loading another file: url from a completely
80         different directory into that same WKWebView should work.
81
82         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
83         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
84
85 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
86
87         Add WeakHashSet
88         https://bugs.webkit.org/show_bug.cgi?id=195152
89
90         Reviewed by Antti Koivisto.
91
92         Added tests for WeakHashSet.
93
94         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
95         (TestWebKitAPI::Base::Base): Moved.
96         (TestWebKitAPI::Derived::foo): Moved.
97         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
98         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
99         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
100         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
101
102 2019-03-04  Chris Dumez  <cdumez@apple.com>
103
104         Do not share WebProcesses between private and regular sessions
105         https://bugs.webkit.org/show_bug.cgi?id=195189
106         <rdar://problem/48421064>
107
108         Reviewed by Alex Christensen.
109
110         Add API test coverage.
111
112         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
113         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
114
115 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
116
117         [WPE] Enable web process sandbox
118         https://bugs.webkit.org/show_bug.cgi?id=195169
119
120         Reviewed by Daniel Bates.
121
122         * wpe/install-dependencies:
123         * wpe/jhbuild.modules:
124
125 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
126
127         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
128         https://bugs.webkit.org/show_bug.cgi?id=195206
129
130         Reviewed by Žan Doberšek.
131
132         Add a new test case.
133
134         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
135         (testJSCClass):
136
137 2019-03-04  Charlie Turner  <cturner@igalia.com>
138
139         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
140         https://bugs.webkit.org/show_bug.cgi?id=194898
141
142         Reviewed by Žan Doberšek.
143
144         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
145         a GCC extension that permits arithmetic on void* pointer. Inline
146         the macro until this issue is fixed upstream.
147
148 2019-03-03  Tim Horton  <timothy_horton@apple.com>
149
150         Rid the world of WK_API_ENABLED
151         https://bugs.webkit.org/show_bug.cgi?id=195263
152
153         Reviewed by Dan Bernstein.
154
155         List of changed files elided because it's useless.
156
157 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
158
159         Unreviewed follow-up to r242292.
160
161         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
162
163         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
164         (TestWebKitAPI::testStrip): Renamed from strip.
165         (TestWebKitAPI::TEST):
166
167 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
168
169         Unreviewed, remove accidentally-committed URLHelpers.cpp test
170
171         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
172         and bug #194272 for details.
173
174         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
175
176 2019-03-03  Tim Horton  <timothy_horton@apple.com>
177
178         Remove some more unused 32-bit code
179         https://bugs.webkit.org/show_bug.cgi?id=195255
180
181         Reviewed by Darin Adler.
182
183         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
184         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
185         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
186         (NPP_New):
187         (NPP_HandleEvent):
188         (handleEventCarbon): Deleted.
189
190 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
191
192         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
193
194         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
195         (TestWebKitAPI::TEST):
196
197 2019-03-01  Darin Adler  <darin@apple.com>
198
199         Finish removing String::format
200         https://bugs.webkit.org/show_bug.cgi?id=194893
201
202         Reviewed by Daniel Bates.
203 '
204         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
205
206 2019-03-01  Alex Christensen  <achristensen@webkit.org>
207
208         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
209         https://bugs.webkit.org/show_bug.cgi?id=195229
210         <rdar://problem/48520362>
211
212         Reviewed by Chris Dumez.
213
214         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
215         (TEST):
216
217 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
218
219         Add a system trace scope for event region building
220         https://bugs.webkit.org/show_bug.cgi?id=195226
221
222         Reviewed by Jon Lee.
223
224         This trace scope measures the time spend converting element rects into Region objects,
225         which can be large on some pages.
226
227         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
228
229         * Tracing/SystemTracePoints.plist:
230
231 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
232
233         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
234         https://bugs.webkit.org/show_bug.cgi?id=194612
235
236         Reviewed by Alex Christensen.
237
238         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
239         Just test the new string-processing function and don't touch the actual environment.
240         (Test cases are all as before, but based on operator== instead of strcmp.)
241
242 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
243
244         [ews-app] Update primary keys for handling multiple Buildbot instances
245         https://bugs.webkit.org/show_bug.cgi?id=195120
246
247         Reviewed by Stephanie Lewis.
248
249         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
250         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
251         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
252
253         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
254         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
255         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
256         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
257         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
258         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
259
260 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
261
262         [WinCairo] Enable service worker
263         https://bugs.webkit.org/show_bug.cgi?id=188318
264
265         Reviewed by Youenn Fablet.
266
267         * DumpRenderTree/DumpRenderTreePrefix.h:
268         * TestWebKitAPI/PlatformWin.cmake:
269         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
270         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
271         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
272
273 2019-03-01  Justin Fan  <justin_fan@apple.com>
274
275         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
276         https://bugs.webkit.org/show_bug.cgi?id=195191
277
278         Rubber-stamped by Dean Jackson.
279
280         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
281
282         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
283
284 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
285
286         Unreviewed, fix lldb webkitpy tests
287         https://bugs.webkit.org/show_bug.cgi?id=194375
288
289         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
290
291         * lldb/lldb_webkit.py:
292         (WTFStringImplProvider.is_8bit):
293
294 2019-02-28  David Quesada  <david_quesada@apple.com>
295
296         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
297         https://bugs.webkit.org/show_bug.cgi?id=195121
298         rdar://problem/48450302
299
300         Reviewed by Alex Christensen.
301
302         Add API tests for -WKNavigationAction._shouldPerformDownload in various
303         configurations where the 'download' attribute is absent, blank, or populated
304         with a filename, and where the anchor element is same-origin or cross-origin
305         (meaning the 'download' attribute shouldn't be honored).
306
307         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
308         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
309         (-[NavigationActionTestDelegate init]):
310         (-[NavigationActionTestDelegate navigationAction]):
311         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
312         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
313         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
314         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
315         (TEST):
316
317 2019-02-28  Antoine Quint  <graouts@apple.com>
318
319         Enable the Pointer Events runtime flag by default
320         https://bugs.webkit.org/show_bug.cgi?id=195156
321
322         Reviewed by Dean Jackson.
323
324         * DumpRenderTree/mac/DumpRenderTree.mm:
325         (enableExperimentalFeatures):
326
327 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
328
329         Several PasteImage API tests are flaky
330         https://bugs.webkit.org/show_bug.cgi?id=195160
331
332         Reviewed by Tim Horton.
333
334         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
335         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
336         listening for a "load" event after image load is already complete.
337
338         To address this, make these tests first register a "load" event handler, then run script to insert an image
339         element into the document, and finally wait until the load event is observed before checking image size.
340
341         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
342
343 2019-02-28  Chris Dumez  <cdumez@apple.com>
344
345         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
346         https://bugs.webkit.org/show_bug.cgi?id=195107
347
348         Reviewed by Alex Christensen.
349
350         Give some time for the zoom level to get restored.
351
352         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
353
354 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
355
356         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
357         https://bugs.webkit.org/show_bug.cgi?id=194958
358
359         Reviewed by Geoffrey Garen.
360
361         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
362         (TEST):
363
364 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
365
366         [ews-app] Update method to save build to handle builder_display_name
367         https://bugs.webkit.org/show_bug.cgi?id=195047
368
369         Reviewed by Dewei Zhu.
370
371         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
372         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
373
374 2019-02-28  Justin Fan  <justin_fan@apple.com>
375
376         [Web GPU] Enable Web GPU only on 64-bit
377         https://bugs.webkit.org/show_bug.cgi?id=195139
378
379         Because Metal is only supported on 64 bit apps.
380
381         Unreviewed build fix.
382
383         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
384
385 2019-02-27  Youenn Fablet  <youenn@apple.com>
386
387         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
388         https://bugs.webkit.org/show_bug.cgi?id=194959
389
390         Reviewed by Chris Dumez.
391
392         Spin loop until getting the condition to remove flakiness.
393
394         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
395
396 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
397
398         [ews-build] Buildbot should include builder_display_name in the build events
399         https://bugs.webkit.org/show_bug.cgi?id=195045
400
401         Reviewed by Dewei Zhu.
402
403         * BuildSlaveSupport/ews-build/events.py:
404         (Events.buildStarted): Included builder_display_name in event data. Also renamed
405         buildername to builder_name to be consistent in naming style.
406         (Events.buildFinished): Ditto.
407
408 2019-02-27  Chris Dumez  <cdumez@apple.com>
409
410         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
411         https://bugs.webkit.org/show_bug.cgi?id=194480
412
413         Reviewed by Brady Eidson.
414
415         Update existing API test to make it more likely to reproduce the issue.
416
417         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
418
419 2019-02-27  Brady Eidson  <beidson@apple.com>
420
421         Universal links from Google search results pages don't open the app.
422         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
423
424         Reviewed by Geoffrey Garen.
425
426         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
427         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
428         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
429         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
430
431 2019-02-27  Chris Dumez  <cdumez@apple.com>
432
433         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
434         https://bugs.webkit.org/show_bug.cgi?id=195102
435
436         Reviewed by Geoffrey Garen.
437
438         If the number of processes is not yet what we expect, wait a bit and check again to give
439         processes some time to exit.
440
441         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
442
443 2019-02-27  Chris Dumez  <cdumez@apple.com>
444
445         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
446         https://bugs.webkit.org/show_bug.cgi?id=194545
447
448         Reviewed by Brady Eidson.
449
450         Make sure the test navigates forward and then back only once. Previously, navigating
451         back would trigger a navigation again in a timer.
452
453         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
454
455 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
456
457         High Sierra Debug JSC test queue should use faster hardware
458         https://bugs.webkit.org/show_bug.cgi?id=194603
459
460         Rubber-stamped by Alexey Proskuryakov.
461
462         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
463
464         * BuildSlaveSupport/build.webkit.org-config/config.json:
465         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
466         (BubbleQueueServer):
467         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
468         (WebKitBuildbot):
469         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
470         * QueueStatusServer/config/queues.py:
471         * Scripts/webkitpy/common/config/ews.json:
472         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
473         (test_ews_name):
474
475 2019-02-27  John Wilander  <wilander@apple.com>
476
477         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
478         https://bugs.webkit.org/show_bug.cgi?id=195071
479         <rdar://problem/48417690>
480
481         Reviewed by Alex Christensen and Brent Fulgham.
482
483         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
484         (TestWebKitAPI::createURL):
485             Convenience function.
486         (TestWebKitAPI::TEST):
487             WebCore::AdClickAttribution now takes a URL when creating Source and
488             Destination.
489         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
490         (TestWebKitAPI::TEST):
491             WebCore::AdClickAttribution now takes a URL when creating Source and
492             Destination.
493
494 2019-02-27  Antoine Quint  <graouts@apple.com>
495
496         Support Pointer Events on macOS
497         https://bugs.webkit.org/show_bug.cgi?id=195008
498         <rdar://problem/47454419>
499
500         Reviewed by Dean Jackson.
501
502         * DumpRenderTree/mac/DumpRenderTree.mm:
503         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
504         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
505
506 2019-02-26  Mark Lam  <mark.lam@apple.com>
507
508         Remove remaining poisoning code.
509         https://bugs.webkit.org/show_bug.cgi?id=194138
510
511         Reviewed by Saam Barati.
512
513         * TestWebKitAPI/CMakeLists.txt:
514         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
515         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
516         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
517         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
518         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
519         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
520         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
521
522 2019-02-26  Alex Christensen  <achristensen@webkit.org>
523
524         Move ephemeral local storage from WebProcess to UIProcess
525         https://bugs.webkit.org/show_bug.cgi?id=195074
526         <rdar://problem/47937975>
527
528         Reviewed by Geoff Garen.
529
530         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
531
532 2019-02-20  Jer Noble  <jer.noble@apple.com>
533
534         [Cocoa] Media elements will restart network buffering just before suspending
535         https://bugs.webkit.org/show_bug.cgi?id=193691
536
537         Reviewed by Eric Carlson.
538
539         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
540         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
541         (TEST):
542
543 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
544
545         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
546         https://bugs.webkit.org/show_bug.cgi?id=191652
547
548         Reviewed by Alex Christensen.
549
550         Fix WinCairo MiniBrowser behavior of authentication dialog.
551
552         * MiniBrowser/win/WebKitBrowserWindow.cpp:
553         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
554
555 2019-02-26  Youenn Fablet  <youenn@apple.com>
556
557         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
558         https://bugs.webkit.org/show_bug.cgi?id=195028
559         <rdar://problem/48243733>
560
561         Reviewed by Eric Carlson.
562
563         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
564
565 2019-02-26  Philippe Normand  <pnormand@igalia.com>
566
567         [WPE] Add API for webview background color configuration
568         https://bugs.webkit.org/show_bug.cgi?id=192305
569
570         Reviewed by Michael Catanzaro.
571
572         * MiniBrowser/wpe/main.cpp:
573         (main): Add a new option to configure the webview background
574         color. Example: --bg-color=transparent.
575         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
576         (testWebViewBackgroundColor): Enable background color API tests for WPE.
577         (beforeAll): Ditto.
578
579 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
580
581         scalableNativeWebpageParameters() is not preserved on new page navigation.
582         https://bugs.webkit.org/show_bug.cgi?id=194892
583         <rdar://problem/47538280>
584
585         Reviewed by Wenson Hsieh.
586         
587         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
588
589         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
590         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
591         * DumpRenderTree/mac/UIScriptControllerMac.mm:
592         (WTR::UIScriptController::allowsViewportShrinkToFit):
593         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
594         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
595         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
596         * TestRunnerShared/UIScriptContext/UIScriptController.h:
597         * WebKitTestRunner/UIScriptControllerCocoa.mm:
598         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
599
600 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
601
602         [ews-app] Add model for handling multiple Buildbot instances
603         https://bugs.webkit.org/show_bug.cgi?id=194863
604
605         Reviewed by Stephanie Lewis.
606
607         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
608
609 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
610
611         [ews-app] Remove BuilderMapping table
612         https://bugs.webkit.org/show_bug.cgi?id=194961
613
614         Reviewed by Stephanie Lewis.
615
616         Store builder name directly in build table, instead of having a separate
617         table for it.
618
619         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
620         * BuildSlaveSupport/ews-app/ews/models/build.py:
621         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
622         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
623
624 2019-02-25  John Wilander  <wilander@apple.com>
625
626         Introduce and adopt new class RegistrableDomain for eTLD+1
627         https://bugs.webkit.org/show_bug.cgi?id=194791
628         <rdar://problem/48179240>
629
630         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
631
632         This patch adds an API test and replaces two instances of
633         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
634
635         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
636         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
637         (TestWebKitAPI::TEST):
638             Changed two strings to make sure the registrable domains are still considered
639             invalid and pass the test.
640         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
641         (TestWebKitAPI::TEST):
642         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
643         (WTR::InjectedBundle::didReceiveMessageToPage):
644
645 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
646
647         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
648         https://bugs.webkit.org/show_bug.cgi?id=195001
649
650         Reviewed by Carlos Garcia Campos.
651
652         API version 1.0 always includes the functionality previously guarded with
653         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
654         unconditionally.
655
656         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
657         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
658         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
659         (WebViewTest::showInWindow): Ditto.
660         (WebViewTest::hideView): Ditto.
661         * wpe/backends/HeadlessViewBackend.cpp:
662         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
663         * wpe/backends/ViewBackend.cpp:
664         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
665         * wpe/backends/WindowViewBackend.cpp:
666         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
667         WPE_BACKEND_CHECK_VERSION().
668         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
669
670 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
671
672         [Flatpak] Add support for flatpak > 1.1.2
673         https://bugs.webkit.org/show_bug.cgi?id=194088
674
675         Flatpak 1.2 is now out so we need to support that
676         version now.
677
678         Reviewed by Michael Catanzaro.
679
680         * flatpak/flatpakutils.py:
681         (check_flatpak):
682         (FlatpakPackages.__init__):
683         (FlatpakPackages.__detect_packages):
684         (FlatpakPackages.__detect_packages.in):
685         (FlatpakRepos.update):
686
687 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
688
689         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
690         https://bugs.webkit.org/show_bug.cgi?id=194998
691
692         Reviewed by Carlos Garcia Campos.
693
694         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
695         to a Git checkout and using the latest commit containing various fixes
696         and improvements.
697
698 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
699
700         [WPE][GTK] Remove user agent quirk for washingtonpost.com
701         https://bugs.webkit.org/show_bug.cgi?id=194981
702
703         Reviewed by Žan Doberšek.
704
705         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
706         (TestWebKitAPI::TEST):
707
708 2019-02-23  Keith Miller  <keith_miller@apple.com>
709
710         Add new mac target numbers
711         https://bugs.webkit.org/show_bug.cgi?id=194955
712
713         Reviewed by Tim Horton.
714
715         * DumpRenderTree/mac/Configurations/Base.xcconfig:
716         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
717         * MiniBrowser/Configurations/Base.xcconfig:
718         * TestWebKitAPI/Configurations/Base.xcconfig:
719         * WebKitTestRunner/Configurations/Base.xcconfig:
720
721 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
722
723         [WinCairo] Enable wk1/wk2 suffix for platform search path.
724         https://bugs.webkit.org/show_bug.cgi?id=194846
725
726         Reviewed by Don Olmstead.
727
728         Added _search_paths() and _port_specific_expectations_files() for
729         WinCairoPort.
730
731         * Scripts/webkitpy/port/win.py:
732         (WinCairoPort.default_baseline_search_path):
733         (WinCairoPort):
734         (WinCairoPort._port_specific_expectations_files):
735         (WinCairoPort._search_paths):
736
737 2019-02-22  Tim Horton  <timothy_horton@apple.com>
738
739         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
740         https://bugs.webkit.org/show_bug.cgi?id=194963
741
742         Reviewed by Dean Jackson.
743
744         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
745         Do a `contains` check instead of `equals`, because in debug builds we
746         put the GraphicsLayer pointer in a prefix.
747
748 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
749
750         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
751         https://bugs.webkit.org/show_bug.cgi?id=194873
752         <rdar://problem/46701974>
753
754         Reviewed by Tim Horton.
755
756         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
757
758         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
759         (WTR::UIScriptController::menuRect const):
760         (WTR::UIScriptController::isShowingMenu const):
761         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
762         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
763         (WTR::UIScriptController::menuRect const):
764
765         Add a function to query the bounds of the callout menu in content coordinates.
766
767         (WTR::UIScriptController::isShowingMenu const):
768
769         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
770
771         * TestRunnerShared/UIScriptContext/UIScriptController.h:
772         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
773         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
774         (WTR::UIScriptController::rectForMenuAction const):
775         (WTR::UIScriptController::menuRect const):
776         (WTR::UIScriptController::isShowingMenu const):
777         (WTR::findViewInHierarchyOfType): Deleted.
778
779 2019-02-22  Chris Dumez  <cdumez@apple.com>
780
781         Regression(PSON) Unable to preview password-protected documents on iCloud.com
782         https://bugs.webkit.org/show_bug.cgi?id=194954
783         <rdar://problem/48127957>
784
785         Reviewed by Alex Christensen.
786
787         Add API test coverage.
788
789         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
790         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
791         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
792         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
793
794 2019-02-22  Chris Dumez  <cdumez@apple.com>
795
796         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
797         https://bugs.webkit.org/show_bug.cgi?id=194924
798         <rdar://problem/48216125>
799
800         Reviewed by Geoffrey Garen.
801
802         Add API test coverage.
803
804         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
805
806 2019-02-22  Chris Dumez  <cdumez@apple.com>
807
808         Unreviewed, disable API test added in r241928 on iOS.
809
810         The cache is not enabled on devices with less than 3GB of RAM.
811
812         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
813
814 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
815
816         Hardcode Visual Viewports on everywhere except iOS WK1
817         https://bugs.webkit.org/show_bug.cgi?id=194928
818
819         Reviewed by Zalan Bujtas.
820
821         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
822         change the default value of the Setting to 'true', and hardcode WebView on iOS to
823         set it to false. The setting has shipped for several years and there's no need to turn
824         it off now.
825
826         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
827         Visual Viewports are not enabled.
828         
829         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
830         that only runs in WK2
831
832         * MiniBrowser/mac/SettingsController.h:
833         * MiniBrowser/mac/SettingsController.m:
834         (-[SettingsController init]):
835         (-[SettingsController _populateMenu]):
836         (-[SettingsController validateMenuItem:]):
837         (-[SettingsController visualViewportEnabled]): Deleted.
838         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
839         * MiniBrowser/mac/WK1BrowserWindowController.m:
840         (-[WK1BrowserWindowController didChangeSettings]):
841         * MiniBrowser/mac/WK2BrowserWindowController.m:
842         (-[WK2BrowserWindowController didChangeSettings]):
843
844 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
845
846         Discard cached processes when clearing website data store
847         https://bugs.webkit.org/show_bug.cgi?id=194894
848
849         Reviewed by Chris Dumez.
850
851         Added a test case.
852
853         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
854         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
855
856 2019-02-21  Alex Christensen  <achristensen@webkit.org>
857
858         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
859         https://bugs.webkit.org/show_bug.cgi?id=194914
860         <rdar://problem/47586889>
861
862         Reviewed by Geoffrey Garen.
863
864         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
865         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
866         (TEST):
867         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
868
869 2019-02-21  David Kilzer  <ddkilzer@apple.com>
870
871         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
872         <https://webkit.org/b/194761>
873
874         Reviewed by Myles Maxfield.
875
876         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
877         (WTR::activateSystemCoreWebFonts): Log `error` to console if
878         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
879         to use ARC-compliant cast.
880         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
881         ARC-compliant cast.
882         (WTR::installFakeHelvetica): Log `error` to console if
883         CTFontManagerRegisterFontsForURL() fails, but only on supported
884         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
885         Call CFRelease() on `error` to fix the leak.  Update to use
886         ARC-compliant cast.
887         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
888         cast.
889
890 2019-02-21  Chris Dumez  <cdumez@apple.com>
891
892         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
893         https://bugs.webkit.org/show_bug.cgi?id=194481
894
895         Reviewed by Alex Christensen.
896
897         Give the processes a chance to shutdown and wait until we reached the expected number
898         of processes.
899
900         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
901
902 2019-02-21  Tim Horton  <timothy_horton@apple.com>
903
904         Fix the macOS build
905
906         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
907
908 2019-02-21  Tim Horton  <timothy_horton@apple.com>
909
910         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
911
912         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
913         I am a backwards.
914
915 2019-02-21  Tim Horton  <timothy_horton@apple.com>
916
917         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
918
919         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
920         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
921         We could force on UI-side compositing, but I feel like the test might be more
922         valuable exercising the normal path on each platform (though the original
923         bug was also UI-side specific). Though we can't validate that the overlay
924         layer was installed successfully, there are layout tests that do that.
925
926 2019-02-21  Tim Horton  <timothy_horton@apple.com>
927
928         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
929         https://bugs.webkit.org/show_bug.cgi?id=194845
930         <rdar://problem/47944579>
931
932         Reviewed by Antti Koivisto.
933
934         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
935         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
936
937 2019-02-21  Zalan Bujtas  <zalan@apple.com>
938
939         [LFC][Floats] Add support for placing formatting roots in-between floats.
940         https://bugs.webkit.org/show_bug.cgi?id=194902
941
942         Reviewed by Antti Koivisto.
943
944         * LayoutReloaded/misc/LFC-passing-tests.txt:
945
946 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
947
948         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
949         https://bugs.webkit.org/show_bug.cgi?id=194901
950
951         Unreviewed build fix.
952
953         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
954         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
955         WPEBackend-fdo-0.1 as library name.
956
957 2019-02-21  Rob Buis  <rbuis@igalia.com>
958
959         Update MIME type parser
960         https://bugs.webkit.org/show_bug.cgi?id=180526
961
962         Reviewed by Darin Adler.
963
964         Add tests involving leading and trailing whitespace, non-token
965         characters and quoted strings.
966
967         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
968         (TestWebKitAPI::TEST):
969
970 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
971
972         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
973         https://bugs.webkit.org/show_bug.cgi?id=194884
974
975         Reviewed by Michael Catanzaro.
976
977         * PlatformWin.cmake:
978
979 2019-02-20  Chris Dumez  <cdumez@apple.com>
980
981         Add API test for <rdar://problem/47471222>
982         https://bugs.webkit.org/show_bug.cgi?id=194847
983
984         Reviewed by Alex Christensen.
985
986         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
987
988 2019-02-20  Chris Dumez  <cdumez@apple.com>
989
990         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
991         https://bugs.webkit.org/show_bug.cgi?id=194872
992         <rdar://problem/47924500>
993
994         Reviewed by Alex Christensen.
995
996         Add API test coverage.
997
998         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
999
1000 2019-02-20  Jer Noble  <jer.noble@apple.com>
1001
1002         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
1003         https://bugs.webkit.org/show_bug.cgi?id=191332
1004
1005         Reviewed by Dean Jackson.
1006
1007         * Scripts/git-is-in-range: Added.
1008
1009 2019-02-20  Andy Estes  <aestes@apple.com>
1010
1011         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
1012         https://bugs.webkit.org/show_bug.cgi?id=194869
1013
1014         Rubber-stamped by Jer Noble.
1015
1016         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1017         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
1018         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1019         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1020         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1021         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1022
1023 2019-02-20  Chris Dumez  <cdumez@apple.com>
1024
1025         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
1026         https://bugs.webkit.org/show_bug.cgi?id=194857
1027         <rdar://problem/47759323>
1028
1029         Reviewed by Alex Christensen.
1030
1031         Add API test coverage.
1032
1033         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1034
1035 2019-02-20  Chris Dumez  <cdumez@apple.com>
1036
1037         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
1038         https://bugs.webkit.org/show_bug.cgi?id=194829
1039         <rdar://problem/47889906>
1040
1041         Reviewed by Alexey Proskuryakov.
1042
1043         Every time the TestOptions were changing we were creating both a new Web view and
1044         a new WKContext, which would start a new Network process. In most cases, we only
1045         need to contruct a new Web view and we do can keep reusing the same WKContext.
1046         This patch implements this optimization and thus avoids spinning a lot of new
1047         Network processes while running the layout tests.
1048
1049         * WebKitTestRunner/TestController.cpp:
1050         (WTR::TestController::generateContextConfiguration const):
1051         (WTR::TestController::generatePageConfiguration):
1052         (WTR::TestController::createWebViewWithOptions):
1053         (WTR::TestController::resetPreferencesToConsistentValues):
1054         (WTR::updateTestOptionsFromTestHeader):
1055         * WebKitTestRunner/TestController.h:
1056         * WebKitTestRunner/TestOptions.h:
1057         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
1058         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
1059         (WTR::TestOptions::hasSameInitializationOptions const):
1060         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
1061         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1062         (WTR::TestController::platformAddTestOptions const):
1063
1064 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
1065
1066         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
1067         https://bugs.webkit.org/show_bug.cgi?id=167941
1068
1069         Reviewed by Carlos Garcia Campos.
1070
1071         * MiniBrowser/gtk/main.c:
1072         (filterSavedCallback): Added.
1073         (main): Support loading a JSON rule set file for content filtering.
1074         * MiniBrowser/wpe/main.cpp:
1075         (filterSavedCallback): Added.
1076         (main): Support loading a JSON rule set file for content filtering.
1077         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
1078         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
1079         (WTF::derefGPtr): Ditto.
1080         (testEmptyStore):
1081         (testSaveInvalidFilter):
1082         (testSaveLoadFilter):
1083         (testSavedFilterIdentifierMatch):
1084         (testRemoveFilter):
1085         (testSaveMultipleFilters):
1086         (testSaveFilterFromFile):
1087         (testFilterPersistence):
1088         (beforeAll):
1089         (afterAll):
1090         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
1091         (removeOldInjectedContentAndResetLists): Also reset content filters.
1092         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
1093         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
1094         the element affected by the style sheet.
1095         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
1096         and returns it to be used by tests.
1097         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
1098         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
1099         (serverCallback): Add support for serving a CSS style sheet for testing.
1100         (beforeAll): Add call to testUserContentManagerContentFilter().
1101         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
1102
1103 2019-02-19  Keith Rollin  <krollin@apple.com>
1104
1105         Add timing information to build output
1106         https://bugs.webkit.org/show_bug.cgi?id=194839
1107         <rdar://problem/48219609>
1108
1109         Reviewed by Alexey Proskuryakov.
1110
1111         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
1112         emit each project's build time to its output. E.g.,
1113
1114             ** BUILD SUCCEEDED ** [0.132 sec]
1115
1116         * Scripts/webkitdirs.pm:
1117         (XcodeOptions):
1118
1119 2019-02-19  Truitt Savell  <tsavell@apple.com>
1120
1121         Unreviewed, rolling out r241784.
1122
1123         Broke all OpenSource builds.
1124
1125         Reverted changeset:
1126
1127         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
1128         instances view"
1129         https://bugs.webkit.org/show_bug.cgi?id=172848
1130         https://trac.webkit.org/changeset/241784
1131
1132 2019-02-19  Zalan Bujtas  <zalan@apple.com>
1133
1134         [LFC][Floats] Remove redundant intersecting logic
1135         https://bugs.webkit.org/show_bug.cgi?id=194804
1136
1137         Reviewed by Antti Koivisto.
1138
1139         * LayoutReloaded/misc/LFC-passing-tests.txt:
1140
1141 2019-02-19  Dean Jackson  <dino@apple.com>
1142
1143         Clean-up output from generate-xcfilelists so it can be filtered
1144         https://bugs.webkit.org/show_bug.cgi?id=194795
1145
1146         Reviewed by Joseph Pecoraro (and Keith Rollin).
1147
1148         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
1149         make a slight tweak to filter-build-webkit so such lines are marked
1150         as plain.
1151
1152         * Scripts/filter-build-webkit:
1153         * Scripts/generate-xcfilelists:
1154
1155 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
1156
1157         pytest is not correctly auto-installed
1158         https://bugs.webkit.org/show_bug.cgi?id=194707
1159
1160         Reviewed by Carlos Garcia Campos.
1161
1162         * Scripts/webkitpy/thirdparty/__init__.py:
1163         (AutoinstallImportHook._install_pytest):
1164
1165 2019-02-18  Chris Dumez  <cdumez@apple.com>
1166
1167         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
1168         https://bugs.webkit.org/show_bug.cgi?id=194797
1169         <rdar://problem/48055151>
1170
1171         Reviewed by Geoffrey Garen.
1172
1173         Add API test coverage.
1174
1175         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1176
1177 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1178
1179         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
1180         https://bugs.webkit.org/show_bug.cgi?id=194670
1181         <rdar://problem/39066529>
1182
1183         Reviewed by Tim Horton.
1184
1185         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
1186         pasted in an editable area as attachment elements.
1187
1188         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
1189         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1190         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
1191         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1192         (TestWebKitAPI::TEST):
1193         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1194         (WTR::InjectedBundlePage::InjectedBundlePage):
1195
1196 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1197
1198         Fix API test after r241728
1199        ​https://bugs.webkit.org/show_bug.cgi?id=194723
1200
1201         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1202         (TEST):
1203         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
1204
1205 2019-02-18  Daniel Bates  <dabates@apple.com>
1206
1207         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1208         https://bugs.webkit.org/show_bug.cgi?id=192824
1209         <rdar://problem/47100332>
1210
1211         Reviewed by Wenson Hsieh.
1212
1213         Fix a bug where the wrong usage code was used for F13 thru F24.
1214
1215         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1216         (keyCodeForDOMFunctionKey):
1217
1218 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
1219
1220         Bytecode cache should a have a boot-specific validation
1221         https://bugs.webkit.org/show_bug.cgi?id=194769
1222         <rdar://problem/48149509>
1223
1224         Reviewed by Keith Miller.
1225
1226         Add test for WTF::bootSessionUUIDString()
1227
1228         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1229         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
1230         (TEST):
1231
1232 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1233
1234         Disable safe browsing in WKWebView and remove its WKPreferences API
1235         https://bugs.webkit.org/show_bug.cgi?id=194723
1236         <rdar://problem/48122993>
1237
1238         Reviewed by Geoffrey Garen.
1239
1240         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1241         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1242         (TEST):
1243         (safeBrowsingView):
1244         Make tests use SPI instead of API.
1245
1246 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
1247
1248         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
1249         https://bugs.webkit.org/show_bug.cgi?id=194586
1250
1251         Reviewed by Ross Kirsling.
1252
1253         * DumpRenderTree/win/DumpRenderTree.cpp:
1254         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
1255         * Scripts/webkitpy/port/driver.py:
1256         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
1257
1258 2019-02-17  David Kilzer  <ddkilzer@apple.com>
1259
1260         Unreviewed, rolling out r241620.
1261
1262         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
1263         (Requested by ddkilzer on #webkit.)
1264
1265         Reverted changeset:
1266
1267         "[WTF] Add environment variable helpers"
1268         https://bugs.webkit.org/show_bug.cgi?id=192405
1269         https://trac.webkit.org/changeset/241620
1270
1271 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1272
1273         [LFC] RenderImage's default intrinsic size is 0.
1274         https://bugs.webkit.org/show_bug.cgi?id=194745
1275
1276         Reviewed by Antti Koivisto.
1277
1278         * LayoutReloaded/misc/LFC-passing-tests.txt:
1279
1280 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1281
1282         [LFC][BFC] Add support for block replaced intrinsic width.
1283         https://bugs.webkit.org/show_bug.cgi?id=194705
1284
1285         Reviewed by Simon Fraser.
1286
1287         * LayoutReloaded/misc/LFC-passing-tests.txt:
1288
1289 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1290
1291         [LFC] Apply min/max width constraints to preferred width computation
1292         https://bugs.webkit.org/show_bug.cgi?id=194739
1293
1294         Reviewed by Simon Fraser.
1295
1296         * LayoutReloaded/misc/LFC-passing-tests.txt:
1297
1298 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
1299
1300         [WTF] Add environment variable helpers
1301         https://bugs.webkit.org/show_bug.cgi?id=192405
1302
1303         Reviewed by Michael Catanzaro.
1304
1305         * DumpRenderTree/mac/DumpRenderTree.mm:
1306         (libraryPathForDumpRenderTree):
1307         * DumpRenderTree/win/DumpRenderTree.cpp:
1308         (libraryPathForDumpRenderTree):
1309         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1310         (setUpIOSLayoutTestCommunication):
1311         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1312         (beforeAll):
1313         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1314         (main):
1315         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1316         (WebKitTestBus::run):
1317         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1318         (WTR::getOutputDir):
1319         (WTR::initializeFontConfigSetting):
1320         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1321         (WTR::InjectedBundle::platformInitialize):
1322         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1323         (WTR::topLevelPath):
1324         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1325         (WTR::topLevelPath):
1326         (WTR::getOutputDir):
1327         (WTR::activateFonts):
1328         * WebKitTestRunner/TestController.cpp:
1329         (WTR::TestController::libraryPathForTesting):
1330         (WTR::TestController::generateContextConfiguration const):
1331         (WTR::TestController::generatePageConfiguration):
1332         (WTR::TestController::decideDestinationWithSuggestedFilename):
1333         (WTR::TestController::platformAdjustContext):
1334         * WebKitTestRunner/TestController.h:
1335         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1336         (WTR::TestController::cocoaPlatformInitialize):
1337         (WTR::TestController::platformAdjustContext):
1338         * WebKitTestRunner/gtk/main.cpp:
1339         (main):
1340         * WebKitTestRunner/mac/TestControllerMac.mm:
1341         (WTR::TestController::configureContentExtensionForTest):
1342         * WebKitTestRunner/wpe/main.cpp:
1343         (main):
1344         Utilize WTF::Environment where possible.
1345
1346 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1347
1348         [iOS] WKWebView callout bar is missing Change Writing Direction item
1349         https://bugs.webkit.org/show_bug.cgi?id=190015
1350         <rdar://problem/44810366>
1351
1352         Reviewed by Tim Horton.
1353
1354         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
1355         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
1356
1357         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
1358         (TestWebKitAPI::TEST):
1359
1360 2019-02-15  Chris Dumez  <cdumez@apple.com>
1361
1362         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
1363         https://bugs.webkit.org/show_bug.cgi?id=194717
1364         <rdar://problem/47884404>
1365
1366         Reviewed by Brady Eidson.
1367
1368         Add API test coverage.
1369
1370         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1371
1372 2019-02-15  Youenn Fablet  <youenn@apple.com>
1373
1374         Make navigator.mediaDevices SecureContext
1375         https://bugs.webkit.org/show_bug.cgi?id=194666
1376
1377         Reviewed by Eric Carlson.
1378
1379         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
1380         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
1381         (TEST_F):
1382
1383 2019-02-15  Brian Burg  <bburg@apple.com>
1384
1385         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
1386         https://bugs.webkit.org/show_bug.cgi?id=194411
1387         <rdar://problem/47787614>
1388
1389         Reviewed by Joseph Pecoraro.
1390
1391         Remove unnecessary soft linking macro usage.
1392
1393         * DumpRenderTree/mac/TestRunnerMac.mm:
1394         (TestRunner::inspectorTestStubURL):
1395         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
1396         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1397         (WTR::TestRunner::inspectorTestStubURL):
1398
1399 2019-02-15  Commit Queue  <commit-queue@webkit.org>
1400
1401         Unreviewed, rolling out r241559 and r241566.
1402         https://bugs.webkit.org/show_bug.cgi?id=194710
1403
1404         Causes layout test crashes under GuardMalloc (Requested by
1405         ryanhaddad on #webkit).
1406
1407         Reverted changesets:
1408
1409         "[WTF] Add environment variable helpers"
1410         https://bugs.webkit.org/show_bug.cgi?id=192405
1411         https://trac.webkit.org/changeset/241559
1412
1413         "Unreviewed build fix for WinCairo Debug after r241559."
1414         https://trac.webkit.org/changeset/241566
1415
1416 2019-02-15  Zalan Bujtas  <zalan@apple.com>
1417
1418         [LFC] Out-of-flow box is never a float box
1419         https://bugs.webkit.org/show_bug.cgi?id=194704
1420
1421         Reviewed by Antti Koivisto.
1422
1423         * LayoutReloaded/misc/LFC-passing-tests.txt:
1424
1425 2019-02-10  Darin Adler  <darin@apple.com>
1426
1427         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
1428         https://bugs.webkit.org/show_bug.cgi?id=194487
1429
1430         Reviewed by Daniel Bates.
1431
1432         * DumpRenderTree/win/DumpRenderTree.cpp:
1433         (applicationId): Use makeString instead of String::format.
1434         (main): Ditto.
1435         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1436         (TestWebKitAPI::Util::createURLForResource): Ditto.
1437         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1438         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
1439
1440         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1441         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
1442         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
1443         (WTR::createStringWithAttributes): Use appendLiteral.
1444         (WTR::AccessibilityUIElement::helpText const): Ditto.
1445         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
1446         directly instead of using String::format.
1447         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
1448         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
1449
1450 2019-02-15  Truitt Savell  <tsavell@apple.com>
1451
1452         Unreviewed, rolling out r241564.
1453
1454         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
1455
1456         Reverted changeset:
1457
1458         "[Mac] WebInspectorUI.framework does not need to be soft-
1459         linked anymore"
1460         https://bugs.webkit.org/show_bug.cgi?id=194411
1461         https://trac.webkit.org/changeset/241564
1462
1463 2019-02-15  Saam barati  <sbarati@apple.com>
1464
1465         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
1466         https://bugs.webkit.org/show_bug.cgi?id=194036
1467
1468         Reviewed by Yusuke Suzuki.
1469
1470         * Scripts/run-jsc-stress-tests:
1471
1472 2019-02-14  Tim Horton  <timothy_horton@apple.com>
1473
1474         Fix the build.
1475
1476         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1477         (WTR::UIScriptController::drawSquareInEditableImage):
1478         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1479         (TestWebKitAPI::drawSquareInEditableImage):
1480
1481 2019-02-14  Tim Horton  <timothy_horton@apple.com>
1482
1483         Fix the build.
1484
1485         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1486         (WTR::UIScriptController::drawSquareInEditableImage):
1487         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1488         (TestWebKitAPI::drawSquareInEditableImage):
1489
1490 2019-02-14  Brian Burg  <bburg@apple.com>
1491
1492         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
1493         https://bugs.webkit.org/show_bug.cgi?id=194411
1494         <rdar://problem/47787614>
1495
1496         Reviewed by Joseph Pecoraro.
1497
1498         Remove unnecessary soft linking macro usage.
1499
1500         * DumpRenderTree/mac/TestRunnerMac.mm:
1501         (TestRunner::inspectorTestStubURL):
1502         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
1503         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1504         (WTR::TestRunner::inspectorTestStubURL):
1505
1506 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
1507
1508         [ews-app] status bubble should fetch builder name info from BuilderMapping table
1509         https://bugs.webkit.org/show_bug.cgi?id=194599
1510
1511         Reviewed by Lucas Forschler.
1512
1513         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1514         (StatusBubble._build_bubble):
1515
1516 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
1517
1518         [ews-app] Set Foreign Key in Django build model
1519         https://bugs.webkit.org/show_bug.cgi?id=194667
1520
1521         Reviewed by Lucas Forschler.
1522
1523         * BuildSlaveSupport/ews-app/ews/models/build.py:
1524         (Build):
1525
1526 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
1527
1528         [WTF] Add environment variable helpers
1529         https://bugs.webkit.org/show_bug.cgi?id=192405
1530
1531         Reviewed by Michael Catanzaro.
1532
1533         * DumpRenderTree/mac/DumpRenderTree.mm:
1534         (libraryPathForDumpRenderTree):
1535         * DumpRenderTree/win/DumpRenderTree.cpp:
1536         (libraryPathForDumpRenderTree):
1537         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1538         (setUpIOSLayoutTestCommunication):
1539         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
1540         (TestWebKitAPI::strip):
1541         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1542         (beforeAll):
1543         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1544         (main):
1545         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1546         (WebKitTestBus::run):
1547         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1548         (WTR::getOutputDir):
1549         (WTR::initializeFontConfigSetting):
1550         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1551         (WTR::InjectedBundle::platformInitialize):
1552         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1553         (WTR::topLevelPath):
1554         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1555         (WTR::topLevelPath):
1556         (WTR::getOutputDir):
1557         (WTR::activateFonts):
1558         * WebKitTestRunner/TestController.cpp:
1559         (WTR::TestController::libraryPathForTesting):
1560         (WTR::TestController::generateContextConfiguration const):
1561         (WTR::TestController::generatePageConfiguration):
1562         (WTR::TestController::decideDestinationWithSuggestedFilename):
1563         (WTR::TestController::platformAdjustContext):
1564         * WebKitTestRunner/TestController.h:
1565         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1566         (WTR::TestController::cocoaPlatformInitialize):
1567         (WTR::TestController::platformAdjustContext):
1568         * WebKitTestRunner/gtk/main.cpp:
1569         (main):
1570         * WebKitTestRunner/mac/TestControllerMac.mm:
1571         (WTR::TestController::configureContentExtensionForTest):
1572         * WebKitTestRunner/wpe/main.cpp:
1573         (main):
1574         Utilize WTF::Environment where possible.
1575
1576 2019-02-14  Chris Dumez  <cdumez@apple.com>
1577
1578         [PSON] Introduce a WebContent Process cache
1579         https://bugs.webkit.org/show_bug.cgi?id=194594
1580         <rdar://problem/46793397>
1581
1582         Reviewed by Geoff Garen.
1583
1584         Update API tests to turn on the WebContent Process cache.
1585
1586         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1587
1588 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
1589
1590         Unreviewed, build fix after r241480
1591
1592         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1593         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1594         (-[DragAndDropSimulator initWithWebView:]):
1595
1596 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
1597
1598         AX: ARIA Reflection was disabled in error
1599         https://bugs.webkit.org/show_bug.cgi?id=194647
1600         <rdar://problem/48068336>
1601
1602         Reviewed by Ryosuke Niwa.
1603
1604         Remove test override now that this feature should be enabled by default.
1605
1606         * WebKitTestRunner/TestController.cpp:
1607         (WTR::TestController::resetPreferencesToConsistentValues):
1608
1609 2019-02-14  Commit Queue  <commit-queue@webkit.org>
1610
1611         Unreviewed, rolling out r241486.
1612         https://bugs.webkit.org/show_bug.cgi?id=194655
1613
1614         causing API failures in builds (Requested by ShawnRoberts on
1615         #webkit).
1616
1617         Reverted changeset:
1618
1619         "[Cocoa] Media elements will restart network buffering just
1620         before suspending"
1621         https://bugs.webkit.org/show_bug.cgi?id=193691
1622         https://trac.webkit.org/changeset/241486
1623
1624 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1625
1626         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
1627         https://bugs.webkit.org/show_bug.cgi?id=194622
1628
1629         Reviewed by Antti Koivisto.
1630
1631         * LayoutReloaded/misc/LFC-passing-tests.txt:
1632
1633 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1634
1635         [LFC] Shrink-to-fit-width should be constrained by min/max width
1636         https://bugs.webkit.org/show_bug.cgi?id=194653
1637
1638         Reviewed by Antti Koivisto.
1639
1640         * LayoutReloaded/misc/LFC-passing-tests.txt:
1641
1642 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
1643
1644         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
1645         https://bugs.webkit.org/show_bug.cgi?id=194641
1646
1647         Reviewed by Geoffrey Garen.
1648
1649         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
1650         so that the test would fail without this fix.
1651
1652         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
1653         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
1654
1655 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1656
1657         [ews-app] Change log level for a log statement
1658
1659         Unreviewed minor fix.
1660
1661         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1662         (Patch.save_patch):
1663
1664 2019-02-13  Jer Noble  <jer.noble@apple.com>
1665
1666         [Cocoa] Media elements will restart network buffering just before suspending
1667         https://bugs.webkit.org/show_bug.cgi?id=193691
1668
1669         Reviewed by Eric Carlson.
1670
1671         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1672         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
1673         (TEST):
1674
1675 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1676
1677         [ews-app] Fetch builder id to name mapping
1678         https://bugs.webkit.org/show_bug.cgi?id=194355
1679
1680         Reviewed by Lucas Forschler.
1681
1682         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1683         (Buildbot.get_builder_id_to_name_mapping):
1684         (Buildbot._get_display_name_from_builder_name):
1685
1686 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
1687
1688         Further restricting webarchive loads
1689         https://bugs.webkit.org/show_bug.cgi?id=194567
1690         <rdar://problem/47610130>
1691
1692         Reviewed by Youenn Fablet.
1693
1694         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
1695         navigations on drop.
1696
1697         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1698         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
1699         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
1700         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
1701         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1702         (TestWebKitAPI::TEST):
1703         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
1704         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
1705         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
1706         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1707         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
1708         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1709         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
1710
1711 2019-02-13  John Wilander  <wilander@apple.com>
1712
1713         Store Ad Click Attribution requests in the network process
1714         https://bugs.webkit.org/show_bug.cgi?id=194510
1715         <rdar://problem/47650118>
1716
1717         Reviewed by Alex Christensen and Daniel Bates.
1718
1719         This patch adds two TestRunner functions:
1720         - dumpAdClickAttribution()
1721         - clearAdClickAttribution()
1722
1723         They call into the network process to dump and clear Ad Click
1724         Attribution state, respectively.
1725
1726         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1727         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1728         (WTR::TestRunner::dumpAdClickAttribution):
1729         (WTR::TestRunner::clearAdClickAttribution):
1730         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1731         * WebKitTestRunner/TestController.cpp:
1732         (WTR::TestController::resetStateToConsistentValues):
1733         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
1734         (WTR::adClickAttributionStringResultCallback):
1735         (WTR::TestController::dumpAdClickAttribution):
1736         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
1737         (WTR::adClickAttributionVoidCallback):
1738         (WTR::TestController::clearAdClickAttribution):
1739         * WebKitTestRunner/TestController.h:
1740         * WebKitTestRunner/TestInvocation.cpp:
1741         (WTR::TestInvocation::dumpResults):
1742         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1743         (WTR::TestInvocation::dumpAdClickAttribution):
1744         * WebKitTestRunner/TestInvocation.h:
1745
1746 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1747
1748         [ews-app] Generate status-bubble
1749         https://bugs.webkit.org/show_bug.cgi?id=194572
1750
1751         Reviewed by Lucas Forschler.
1752
1753         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1754         (StatusBubble._build_bubble):
1755         (StatusBubble._should_show_bubble_for):
1756         (StatusBubble._build_bubbles_for_patch):
1757
1758 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1759
1760         [ews-app] Add status bubble html template
1761         https://bugs.webkit.org/show_bug.cgi?id=194571
1762
1763         Reviewed by Lucas Forschler.
1764
1765         * BuildSlaveSupport/ews-app/ews/templates: Added.
1766         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
1767
1768 2019-02-12  Chris Dumez  <cdumez@apple.com>
1769
1770         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
1771         https://bugs.webkit.org/show_bug.cgi?id=194568
1772         <rdar://problem/47944490>
1773
1774         Reviewed by Ryosuke Niwa.
1775
1776         Add API test coverage.
1777
1778         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1779         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
1780
1781 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1782
1783         webkitpy: Remove bug_dummy from parsed test expectations
1784         https://bugs.webkit.org/show_bug.cgi?id=194562
1785         <rdar://problem/47853999>
1786
1787         Reviewed by Lucas Forschler.
1788
1789         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1790         (TestExpectationParser):
1791         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
1792         skipped tests.
1793         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1794
1795 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
1796
1797         [ews-app] Add method to fetch patch
1798         https://bugs.webkit.org/show_bug.cgi?id=194518
1799
1800         Reviewed by Lucas Forschler.
1801
1802         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1803         (Patch.get_patch):
1804
1805 2019-02-12  Zalan Bujtas  <zalan@apple.com>
1806
1807         [LFC] Expand tests coverage (60 new tests -> 860)
1808
1809         Unreviewed test gardening (run-singly, --child-processes=1).
1810
1811         * LayoutReloaded/misc/LFC-passing-tests.txt:
1812
1813 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1814
1815         Allow pages to trigger programmatic paste from script on iOS
1816         https://bugs.webkit.org/show_bug.cgi?id=194271
1817         <rdar://problem/47808810>
1818
1819         Reviewed by Tim Horton.
1820
1821         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
1822
1823         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1824         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1825         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1826         (WTR::UIScriptController::rectForMenuAction const):
1827
1828         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
1829         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
1830         for when the menu is shown or hidden.
1831
1832         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1833         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1834         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1835         (WTR::UIScriptController::setDidShowMenuCallback):
1836         (WTR::UIScriptController::didShowMenuCallback const):
1837         (WTR::UIScriptController::setDidHideMenuCallback):
1838         (WTR::UIScriptController::didHideMenuCallback const):
1839         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1840         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1841         (WTR::UIScriptController::rectForMenuAction const):
1842         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1843         * WebKitTestRunner/TestController.cpp:
1844         (WTR::TestController::resetPreferencesToConsistentValues):
1845         (WTR::updateTestOptionsFromTestHeader):
1846         * WebKitTestRunner/TestOptions.h:
1847
1848         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
1849         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
1850
1851         (WTR::TestOptions::hasSameInitializationOptions const):
1852         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1853         (WTR::UIScriptController::calendarType const):
1854         (WTR::UIScriptController::platformUndoManager const):
1855         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1856         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1857         (-[TestRunnerWKWebView initWithFrame:configuration:]):
1858         (-[TestRunnerWKWebView dealloc]):
1859         (-[TestRunnerWKWebView _didShowMenu]):
1860         (-[TestRunnerWKWebView _didHideMenu]):
1861
1862         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
1863
1864         * WebKitTestRunner/ios/TestControllerIOS.mm:
1865         (WTR::handleMenuWillHideNotification):
1866         (WTR::handleMenuDidHideNotification):
1867         (WTR::TestController::platformInitialize):
1868         (WTR::TestController::platformDestroy):
1869         (WTR::TestController::platformResetStateToConsistentValues):
1870
1871         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
1872         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
1873
1874         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1875         (WTR::forEachViewInHierarchy):
1876         (WTR::findViewInHierarchyOfType):
1877
1878         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
1879         functions that dig through a given view's hierarchy in search of a view of a given class.
1880
1881         (WTR::UIScriptController::selectionStartGrabberViewRect const):
1882         (WTR::UIScriptController::selectionEndGrabberViewRect const):
1883         (WTR::UIScriptController::selectionCaretViewRect const):
1884         (WTR::UIScriptController::selectionRangeViewRects const):
1885         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1886         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1887
1888         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
1889
1890         (WTR::UIScriptController::rectForMenuAction const):
1891
1892         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
1893         callout bar) whose label matches the given string.
1894
1895         (WTR::UIScriptController::platformContentView const):
1896
1897         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
1898         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
1899         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
1900
1901         (WTR::UIScriptController::platformUndoManager const): Deleted.
1902         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1903         (WTR::UIScriptController::platformContentView const):
1904         (WTR::UIScriptController::platformUndoManager const): Deleted.
1905
1906 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1907
1908         webkitpy: No option to only show unexpected failures in results.html for iPad
1909         https://bugs.webkit.org/show_bug.cgi?id=194554
1910         <rdar://problem/47922442>
1911
1912         Rubber-stamped by Aakash Jain.
1913
1914         Just because a TestExpecations file does not exist for a specific platform does not mean that
1915         TestExpecations are not being used, given that platforms inherit test expectations.
1916
1917         * Scripts/webkitpy/port/base.py:
1918         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
1919         * Scripts/webkitpy/port/base_unittest.py:
1920         (PortTest.test_uses_test_expectations_file):
1921
1922 2019-02-12  Alex Christensen  <achristensen@webkit.org>
1923
1924         Remove setDefersLoading infrastructure from WebKit2
1925         https://bugs.webkit.org/show_bug.cgi?id=194506
1926
1927         Reviewed by Brady Eidson.
1928
1929         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1930         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1931         (WTR::TestRunner::setDefersLoading): Deleted.
1932         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1933
1934 2019-02-12  Alex Christensen  <achristensen@webkit.org>
1935
1936         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
1937         https://bugs.webkit.org/show_bug.cgi?id=194522
1938         <rdar://problem/47789393>
1939
1940         Reviewed by Chris Dumez.
1941
1942         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1943         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
1944         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1945         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1946
1947 2019-02-12  Andy Estes  <aestes@apple.com>
1948
1949         [iOSMac] Enable Parental Controls Content Filtering
1950         https://bugs.webkit.org/show_bug.cgi?id=194521
1951         <rdar://39732376>
1952
1953         Reviewed by Tim Horton.
1954
1955         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1956
1957 2019-02-12  Zalan Bujtas  <zalan@apple.com>
1958
1959         [LFC][IFC] Add intrinsic width support for float boxes.
1960         https://bugs.webkit.org/show_bug.cgi?id=194528
1961
1962         Reviewed by Antti Koivisto.
1963
1964         Expand tests coverage (2 new tests -> 800).
1965         (This is the correct test ordering --runs-singly --child-processes=1)
1966
1967         * LayoutReloaded/misc/LFC-passing-tests.txt:
1968
1969 2019-02-12  Rob Buis  <rbuis@igalia.com>
1970
1971         Implement serializing in MIME type parser
1972         https://bugs.webkit.org/show_bug.cgi?id=193909
1973
1974         Reviewed by Darin Adler.
1975
1976         Add various tests involving upper case, non-ASCII, control/null characters,
1977         various HTTP whitespace, single quotes and an unpaired surrogate.
1978
1979         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1980         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
1981         (TestWebKitAPI::serializeIfValid):
1982         (TestWebKitAPI::TEST):
1983
1984 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
1985
1986         [Cocoa] Ask platform for generic font family mappings
1987         https://bugs.webkit.org/show_bug.cgi?id=187723
1988         <rdar://problem/41892438>
1989
1990         Reviewed by Brent Fulgham.
1991
1992         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1993
1994         * DumpRenderTree/mac/DumpRenderTree.mm:
1995         (allowedFontFamilySet):
1996         * WebKitTestRunner/mac/TestControllerMac.mm:
1997         (WTR::allowedFontFamilySet):
1998
1999 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
2000
2001         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
2002         https://bugs.webkit.org/show_bug.cgi?id=193622
2003
2004         Reviewed by Michael Catanzaro.
2005
2006         This adds support for loading content extension rule sets from the JSON files which
2007         accompany the corresponding layout test, using the C API. The Cocoa specific parts
2008         of WKTR for this could be removed, but that is left for a follow-up patch with
2009         cleanups.
2010
2011         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
2012         * WebKitTestRunner/TestController.cpp:
2013         (WTR::testPath): Subtract one from the length when constructing the result std::string to
2014         avoid having the null-terminator copied into the result.
2015         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
2016         part of the preparations to run a test.
2017         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
2018         (WTR::contentExtensionStoreCallback): Added.
2019         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
2020         used for content extensions test.
2021         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
2022         extensions and compiling the JSON rule set for tests involving content extensions.
2023         (WTR::TestController::resetContentExtensions): Removes the content extension built for
2024         testing and disables content extensions.
2025         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
2026         resetContentExtensions().
2027         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
2028         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
2029         configureContentExtensionForTest(), and userContentController().
2030
2031 2019-02-11  Daniel Bates  <dabates@apple.com>
2032
2033         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2034         https://bugs.webkit.org/show_bug.cgi?id=191446
2035         <rdar://problem/45929460>
2036
2037         Reviewed by Tim Horton.
2038
2039         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
2040
2041         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2042         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2043         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2044         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2045         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2046         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2047         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2048         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2049         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2050         (WTR::arrayLength):
2051         (WTR::parseModifierArray):
2052         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2053         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2054         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2055         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2056
2057 2019-02-11  Commit Queue  <commit-queue@webkit.org>
2058
2059         Unreviewed, rolling out r241272 and r241276.
2060         https://bugs.webkit.org/show_bug.cgi?id=194514
2061
2062         Broke the Apple Internal build and the fix requires human
2063         intervention :( (Requested by dydz on #webkit).
2064
2065         Reverted changesets:
2066
2067         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
2068         https://bugs.webkit.org/show_bug.cgi?id=191446
2069         https://trac.webkit.org/changeset/241272
2070
2071         "Fix internal iOS build after r241272"
2072         https://bugs.webkit.org/show_bug.cgi?id=191446
2073         https://trac.webkit.org/changeset/241276
2074
2075 2019-02-11  Truitt Savell  <tsavell@apple.com>
2076
2077         Unreviewed, rolling out r241269.
2078
2079         Caused 5 layout tests crashes on Mac WK1
2080
2081         Reverted changeset:
2082
2083         "DumpRenderTree should report unknown options"
2084         https://bugs.webkit.org/show_bug.cgi?id=191303
2085         https://trac.webkit.org/changeset/241269
2086
2087 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2088
2089         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
2090         https://bugs.webkit.org/show_bug.cgi?id=194313
2091
2092         Reviewed by Tim Horton.
2093
2094         Add a helper to determine whether the web view is presenting modal UI.
2095
2096         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2097         (WTR::UIScriptController::isPresentingModally const):
2098         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2099         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2100         (WTR::UIScriptController::isPresentingModally const):
2101         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2102         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2103         (WTR::UIScriptController::calendarType const): Deleted.
2104         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2105         (WTR::UIScriptController::isPresentingModally const):
2106         (WTR::UIScriptController::calendarType const):
2107         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2108         (WTR::UIScriptController::calendarType const):
2109
2110 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
2111
2112         GCHeapInspector: Show the retained sizes in more places
2113         https://bugs.webkit.org/show_bug.cgi?id=194464
2114
2115         Reviewed by Simon Fraser.
2116
2117         * GCHeapInspector/gc-heap-inspector.html:
2118         * GCHeapInspector/script/interface.js:
2119         (HeapInspectorUtils.humanReadableSize):
2120         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
2121         (HeapInspectorUtils.spanForNode.span.span):
2122         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
2123         (HeapSnapshotInspector.prototype.buildRoots):
2124
2125 2019-02-11  Daniel Bates  <dabates@apple.com>
2126
2127         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2128         https://bugs.webkit.org/show_bug.cgi?id=191446
2129         <rdar://problem/45929460>
2130
2131         Reviewed by Tim Horton.
2132
2133         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
2134
2135         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2136         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2137         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2138         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2139         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2140         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2141         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2142         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2143         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2144         (WTR::arrayLength):
2145         (WTR::parseModifierArray):
2146         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2147         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2148         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2149         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2150
2151 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
2152
2153         DumpRenderTree should report unknown options
2154         https://bugs.webkit.org/show_bug.cgi?id=191303
2155
2156         Reviewed by Frédéric Wang.
2157
2158         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
2159         to report unknown options.
2160         Added and assigned test options which are currently used in tests.
2161
2162         * DumpRenderTree/TestOptions.cpp:
2163         (TestOptions::TestOptions):
2164
2165 2019-02-11  Truitt Savell  <tsavell@apple.com>
2166
2167         Unreviewed, rolling out r241229.
2168
2169         Revision broke internal builds for watchOS.
2170
2171         Reverted changeset:
2172
2173         "[Cocoa] Ask platform for generic font family mappings"
2174         https://bugs.webkit.org/show_bug.cgi?id=187723
2175         https://trac.webkit.org/changeset/241229
2176
2177 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
2178
2179         [WinCairo][MiniBrowser] Basic authentication always fails.
2180         https://bugs.webkit.org/show_bug.cgi?id=194496
2181
2182         Reviewed by Don Olmstead.
2183
2184         * MiniBrowser/win/DialogHelper.h:
2185         (Dialog::getText):
2186
2187 2019-02-11  Philippe Normand  <pnormand@igalia.com>
2188
2189         [GStreamer] GstMappedBuffer testsuite build fails
2190         https://bugs.webkit.org/show_bug.cgi?id=194495
2191
2192         Reviewed by Carlos Garcia Campos.
2193
2194         Fix the build by explicitely adding the gstreamer1.0-audio include
2195         directories to the include path.
2196
2197         * TestWebKitAPI/PlatformGTK.cmake:
2198         * TestWebKitAPI/PlatformWPE.cmake:
2199
2200 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2201
2202         [GTK][WPE] Add enable-javascript-markup setting
2203         https://bugs.webkit.org/show_bug.cgi?id=193439
2204
2205         Reviewed by Michael Catanzaro.
2206
2207         Add test cases to check the new setting.
2208
2209         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2210         (testWebKitSettings):
2211         (testWebKitSettingsJavaScriptMarkup):
2212         (beforeAll):
2213
2214 2019-02-10  Darin Adler  <darin@apple.com>
2215
2216         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
2217         https://bugs.webkit.org/show_bug.cgi?id=194485
2218
2219         Reviewed by Daniel Bates.
2220
2221         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
2222
2223 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2224
2225         Add more tests for clampTo<>()
2226         https://bugs.webkit.org/show_bug.cgi?id=194462
2227
2228         Reviewed by Geoffrey Garen.
2229
2230         Darin suggested to test the very last floating point number
2231         at the boundaries when truncating to integer.
2232         I added test for max/min and max-1/min-1.
2233
2234         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2235         (TestWebKitAPI::TEST):
2236
2237 2019-02-09  Darin Adler  <darin@apple.com>
2238
2239         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
2240         https://bugs.webkit.org/show_bug.cgi?id=194021
2241
2242         Reviewed by Geoffrey Garen.
2243
2244         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
2245         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
2246         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
2247
2248 2019-02-09  Zalan Bujtas  <zalan@apple.com>
2249
2250         [LFC][IFC] Add intrinsic width support for basic inline containers
2251         https://bugs.webkit.org/show_bug.cgi?id=194473
2252
2253         Reviewed by Antti Koivisto.
2254
2255         Expand tests coverage (11 new tests -> 798)
2256
2257         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
2258
2259 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2260
2261         Fix MiniBrowser's entitlements
2262         https://bugs.webkit.org/show_bug.cgi?id=192431
2263
2264         Reviewed by Joseph Pecoraro.
2265
2266         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
2267         files, making it impossible to load any extension.
2268
2269         * MiniBrowser/MiniBrowser.entitlements:
2270
2271 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
2272
2273         [Cocoa] Ask platform for generic font family mappings
2274         https://bugs.webkit.org/show_bug.cgi?id=187723
2275         <rdar://problem/41892438>
2276
2277         Reviewed by Brent Fulgham.
2278
2279         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
2280
2281         * DumpRenderTree/mac/DumpRenderTree.mm:
2282         (allowedFontFamilySet):
2283         * WebKitTestRunner/mac/TestControllerMac.mm:
2284         (WTR::allowedFontFamilySet):
2285
2286 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
2287
2288         [GTK] Implement back/forward touchpad gesture
2289         https://bugs.webkit.org/show_bug.cgi?id=193919
2290
2291         Reviewed by Michael Catanzaro.
2292
2293         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2294         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
2295
2296 2019-02-08  Alex Christensen  <achristensen@webkit.org>
2297
2298         Add SPI to use networking daemon instead of XPC service
2299         https://bugs.webkit.org/show_bug.cgi?id=194427
2300
2301         Reviewed by Geoffrey Garen
2302
2303         * MiniBrowser/MiniBrowser.entitlements:
2304
2305 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2306
2307         [ews-build] Ensure that every builder in config.json has short name
2308         https://bugs.webkit.org/show_bug.cgi?id=194461
2309
2310         Reviewed by Lucas Forschler.
2311
2312         * BuildSlaveSupport/ews-build/loadConfig.py:
2313         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
2314
2315 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2316
2317         [ews-build] Add short name to config.json
2318         https://bugs.webkit.org/show_bug.cgi?id=194456
2319
2320         Reviewed by Lucas Forschler.
2321
2322         * BuildSlaveSupport/ews-build/config.json: Added short name.
2323         * BuildSlaveSupport/ews-build/loadConfig.py:
2324         (loadBuilderConfig): Set the short name as the builder description.
2325
2326 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
2327
2328         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
2329         https://bugs.webkit.org/show_bug.cgi?id=194418
2330
2331         Reviewed by Lucas Forschler.
2332
2333         Do not include errors trying when finding crashlogs at the end of
2334         a run-webkit-tests run since we don't process those errors.
2335
2336         * Scripts/webkitpy/port/darwin.py:
2337         (DarwinPort._look_for_all_crash_logs_in_log_dir):
2338         * Scripts/webkitpy/port/ios_device.py:
2339         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
2340         * Scripts/webkitpy/port/watch_device.py:
2341         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
2342
2343 2019-02-08  Beth Dakin  <bdakin@apple.com>
2344
2345         Add afterScreenUpdates to WKSnapshotConfiguration
2346         https://bugs.webkit.org/show_bug.cgi?id=194362
2347         -and corresponding-
2348         <rdar://problem/40655528> Please add an "after screen updates" property to 
2349         WKSnapshotConfiguration (to solve blank snapshots)
2350
2351         Reviewed by Tim Horton.
2352
2353         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
2354         (TEST):
2355
2356 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
2357
2358         clampTo(): do not convert the input to double when dealing with integers
2359         https://bugs.webkit.org/show_bug.cgi?id=194263
2360         <rdar://problem/47692312>
2361
2362         Reviewed by Darin Adler.
2363
2364         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2365         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
2366         (TestWebKitAPI::testClampFloatingPointToInteger):
2367         (TestWebKitAPI::testClampSameSignIntegers):
2368         (TestWebKitAPI::testClampUnsignedToSigned):
2369         (TestWebKitAPI::testClampSignedToUnsigned):
2370
2371 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
2372
2373         webkitpy: Respect --dedicated-simulators flag
2374         https://bugs.webkit.org/show_bug.cgi?id=194416
2375         <rdar://problem/47894722>
2376
2377         Reviewed by Lucas Forschler.
2378
2379         * Scripts/webkitpy/port/device_port.py:
2380         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
2381         available devices can be safely ignored.
2382
2383 2019-02-07  Keith Rollin  <krollin@apple.com>
2384
2385         Remove extra copy of 100x100-red.tga
2386         https://bugs.webkit.org/show_bug.cgi?id=194371
2387         <rdar://problem/47873465>
2388
2389         Reviewed by Said Abou-Hallawa.
2390
2391         In order to help it pass its tests, Bug 194190 added a second copy of
2392         the file 100x100-red.tga. However, it turns out that this additional
2393         file wasn't actually needed, and that that sole previous copy was
2394         sufficient. At the same time, this second copy -- which was copied to
2395         the same location in the build output as the first copy -- now caused
2396         XCBuild to complain because there were two production rules for the
2397         same output file. Address this by removing the newly-added extra copy.
2398
2399         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2400         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
2401
2402 2019-02-07  Alex Christensen  <achristensen@webkit.org>
2403
2404         Deprecate WKBundlePageSetDefersLoading
2405         https://bugs.webkit.org/show_bug.cgi?id=191394
2406
2407         Reviewed by Dean Jackson.
2408
2409         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2410         (WTR::TestRunner::setDefersLoading):
2411
2412 2019-02-07  Zalan Bujtas  <zalan@apple.com>
2413
2414         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
2415         https://bugs.webkit.org/show_bug.cgi?id=194391
2416
2417         Reviewed by Antti Koivisto.
2418
2419         * LayoutReloaded/misc/LFC-passing-tests.txt:
2420
2421 2019-02-06  Keith Rollin  <krollin@apple.com>
2422
2423         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
2424         https://bugs.webkit.org/show_bug.cgi?id=193975
2425         <rdar://problem/47643306>
2426
2427         Reviewed by Tim Horton.
2428
2429         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
2430         the Info.plist file into the bundle. This step is not necessary as the
2431         implicit "bundle up all the build products into a framework" build
2432         phase does this already. Having the Copy Bundle Resources phase do
2433         this causes a conflict under XCBuild, which objects to two build
2434         phases producing the same file (Info.plist). Address this by removing
2435         Info.plist from the Copy Bundle Resources phase.
2436
2437         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
2438
2439 2019-02-06  Keith Rollin  <krollin@apple.com>
2440
2441         Really enable the automatic checking and regenerations of .xcfilelists during builds
2442         https://bugs.webkit.org/show_bug.cgi?id=194357
2443         <rdar://problem/47861231>
2444
2445         Reviewed by Chris Dumez.
2446
2447         Bug 194124 was supposed to enable the automatic checking and
2448         regenerating of .xcfilelist files during the build. While related
2449         changes were included in that patch, the change to actually enable the
2450         operation somehow was omitted. This patch actually enables the
2451         operation. The check-xcfilelist.sh scripts now check
2452         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
2453         from the checking.
2454
2455         * DumpRenderTree/Scripts/check-xcfilelists.sh:
2456         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
2457
2458 2019-02-06  David Kilzer  <ddkilzer@apple.com>
2459
2460         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
2461         <https://webkit.org/b/194286>
2462         <rdar://problem/47815558>
2463
2464         Reviewed by Alexey Proskuryakov.
2465
2466         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2467         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
2468         WKRetainPtr<> to avoid leaking the WKDataRef.
2469
2470 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2471
2472         Unreviewed, fix a typo
2473
2474         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2475
2476 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
2477
2478         [GTK][WPE] force libpsl build to use ICU in jhbuild
2479         https://bugs.webkit.org/show_bug.cgi?id=194288
2480
2481         Reviewed by Carlos Garcia Campos.
2482
2483         * gtk/jhbuild.modules:
2484         Require ICU for libpsl build in jhbuild, like done in WPE.
2485
2486 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2487
2488         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
2489         https://bugs.webkit.org/show_bug.cgi?id=194209
2490
2491         Reviewed by Carlos Garcia Campos.
2492
2493         Enhance TestCookieManager to ensure this doesn't happen again.
2494
2495         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2496         (testCookieManagerPersistentStorage):
2497         (beforeAll):
2498
2499 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2500
2501         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
2502         https://bugs.webkit.org/show_bug.cgi?id=194324
2503
2504         Reviewed by Andy Estes.
2505
2506         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
2507         part of the name is already implicit, since this is in testing code in TestOptions.
2508
2509         * WebKitTestRunner/TestController.cpp:
2510         (WTR::TestController::generateContextConfiguration const):
2511         (WTR::updateTestOptionsFromTestHeader):
2512         * WebKitTestRunner/TestOptions.h:
2513         (WTR::TestOptions::hasSameInitializationOptions const):
2514
2515 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2516
2517         [ews-build] Allow * as platform for builders and workers
2518         https://bugs.webkit.org/show_bug.cgi?id=188533
2519
2520         Reviewed by Lucas Forschler.
2521
2522         * BuildSlaveSupport/ews-build/loadConfig.py:
2523         (checkWorkersAndBuildersForConsistency):
2524
2525 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2526
2527         [ews-build] Add few bots to config.json
2528         https://bugs.webkit.org/show_bug.cgi?id=194304
2529
2530         Reviewed by Lucas Forschler.
2531
2532         * BuildSlaveSupport/ews-build/config.json:
2533
2534 2019-02-05  Keith Rollin  <krollin@apple.com>
2535
2536         Enable the automatic checking and regenerations of .xcfilelists during builds
2537         https://bugs.webkit.org/show_bug.cgi?id=194124
2538         <rdar://problem/47721277>
2539
2540         Reviewed by Tim Horton.
2541
2542         Bug 193790 add a facility for checking -- during build time -- that
2543         any needed .xcfilelist files are up-to-date and for updating them if
2544         they are not. This facility was initially opt-in by setting
2545         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
2546         the process seemed robust. Its now time to enable this facility and
2547         make it opt-out. If there is a need to disable this facility, set and
2548         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
2549         running `make` or `build-webkit`, or before running Xcode from the
2550         command line.
2551
2552         Additionally, remove the step that generates a list of source files
2553         going into the UnifiedSources build step. It's only necessarily to
2554         specify Sources.txt and SourcesCocoa.txt as inputs.
2555
2556         * Scripts/generate-xcfilelists:
2557
2558 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2559
2560         [GTK][WPE] force libpsl build to use ICU in jhbuild
2561         https://bugs.webkit.org/show_bug.cgi?id=194288
2562
2563         Reviewed by Philippe Normand.
2564
2565         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
2566         This can cause build failures if libidn is detected but libunistring is not available.
2567
2568         Make sure that ICU is used for runtime and builtin PSL data.
2569
2570         * gtk/jhbuild.modules:
2571         * wpe/jhbuild.modules:
2572
2573 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2574
2575         [ews-app] Modified timestamp should be updated on updating data
2576         https://bugs.webkit.org/show_bug.cgi?id=194295
2577
2578         Reviewed by Lucas Forschler.
2579
2580         * BuildSlaveSupport/ews-app/ews/models/build.py:
2581         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2582         * BuildSlaveSupport/ews-app/ews/models/step.py:
2583
2584 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
2585
2586         Unreviewed, rolling out r240742.
2587
2588         Causes crashes on iOS simulator.
2589
2590         Reverted changeset:
2591
2592         "[iOS] Keyups for non-modifier keys identified as "Dead" when
2593         not focused in a content-editable element"
2594         https://bugs.webkit.org/show_bug.cgi?id=192824
2595         https://trac.webkit.org/changeset/240742
2596
2597 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
2598
2599         run-webkit-tests emits message "...running None" when running tests
2600         https://bugs.webkit.org/show_bug.cgi?id=194133
2601         <rdar://problem/47724738>
2602
2603         Reviewed by Lucas Forschler.
2604
2605         * Scripts/webkitpy/xcode/device_type.py:
2606         (DeviceType.__str__): Use both version mapping tables and use just the variant
2607         name if no version name is available.
2608         * Scripts/webkitpy/xcode/device_type_unittest.py:
2609         (DeviceTypeTest):
2610         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
2611         an associated named.
2612
2613 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2614
2615         [WPE] require python3-setuptools for meson build in jhbuild
2616         https://bugs.webkit.org/show_bug.cgi?id=194287
2617
2618         Reviewed by Philippe Normand.
2619
2620         python3-setuptools is needed to build meson in jhbuild.
2621         It is already required by the GTK port.
2622
2623         * wpe/install-dependencies:
2624
2625 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2626
2627         [ews-app] Add method to save BuilderMapping to database
2628         https://bugs.webkit.org/show_bug.cgi?id=194264
2629
2630         Reviewed by Lucas Forschler.
2631
2632         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2633         (BuilderMapping.__str__):
2634         (BuilderMapping):
2635         (BuilderMapping.save_mapping):
2636         (BuilderMapping.update_mapping):
2637         (BuilderMapping.get_existing_mapping):
2638         (BuilderMapping.is_valid_mapping):
2639
2640 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2641
2642         [ews-app] Add timestamp fields for BuilderMappings
2643         https://bugs.webkit.org/show_bug.cgi?id=194266
2644
2645         Reviewed by Lucas Forschler.
2646
2647         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2648         (BuilderMapping):
2649
2650 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
2651
2652         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
2653         https://bugs.webkit.org/show_bug.cgi?id=174816
2654
2655         Reviewed by Michael Catanzaro.
2656
2657         Add tests for webkit_uri_for_display().
2658
2659         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
2660         (testURIForDisplayUnaffected):
2661         (testURIForDisplayAffected):
2662         (beforeAll):
2663         (afterAll):
2664         * TestWebKitAPI/glib/CMakeLists.txt:
2665
2666 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
2667
2668         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
2669         https://bugs.webkit.org/show_bug.cgi?id=194158
2670         <rdar://problem/47737268>
2671
2672         Rubber-stamped by Aakash Jain.
2673
2674         * Scripts/webkitpy/port/device_port.py:
2675         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
2676
2677 2019-02-04  Said Abou-Hallawa  <said@apple.com>
2678
2679         [CG] Enable setAdditionalSupportedImageTypes for WK1
2680         https://bugs.webkit.org/show_bug.cgi?id=194190
2681
2682         Reviewed by Tim Horton.
2683
2684         Add a test similar to the one under WebKit Cocoa but make it create a
2685         WebView instead of a WKWebView.
2686
2687         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2688         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
2689         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
2690         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
2691         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
2692         (TestWebKitAPI::runTest):
2693         (TestWebKitAPI::TEST):
2694
2695 2019-02-04  Zalan Bujtas  <zalan@apple.com>
2696
2697         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
2698         https://bugs.webkit.org/show_bug.cgi?id=194168
2699
2700         Reviewed by Simon Fraser.
2701
2702         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
2703
2704         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2705         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
2706         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
2707         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
2708         (TEST):
2709         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
2710         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
2711
2712 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
2713
2714         REGRESSION (r237269): webkit-patch what-broke is broken 
2715         https://bugs.webkit.org/show_bug.cgi?id=193025
2716
2717         Reviewed by Aakash Jain.
2718
2719         * Scripts/webkitpy/common/host.py:
2720         (Host.buildbot):
2721         (Host.bugzilla): Renamed to 'buildbot'.
2722
2723 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2724
2725         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
2726         https://bugs.webkit.org/show_bug.cgi?id=194207
2727
2728         Reviewed by Tim Horton.
2729
2730         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
2731         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
2732         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
2733         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
2734         start and delete forwards to remove the original attachment.
2735
2736         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2737         (TestWebKitAPI::TEST):
2738
2739 2019-02-04  Youenn Fablet  <youenn@apple.com>
2740
2741         Capture state should be managed consistently when doing process swapping
2742         https://bugs.webkit.org/show_bug.cgi?id=194122
2743         <rdar://problem/47609293>
2744
2745         Reviewed by Eric Carlson.
2746
2747         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2748         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
2749         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
2750         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
2751         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2752         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2753         (WTR::TestRunner::isDoingMediaCapture const):
2754         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2755         * WebKitTestRunner/TestController.cpp:
2756         (WTR::TestController::isDoingMediaCapture const):
2757         * WebKitTestRunner/TestController.h:
2758         * WebKitTestRunner/TestInvocation.cpp:
2759         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2760         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2761         (WTR::TestController::isDoingMediaCapture const):
2762
2763 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
2764
2765         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
2766         https://bugs.webkit.org/show_bug.cgi?id=194142
2767
2768         Reviewed by Ross Kirsling.
2769
2770         There three 'separator' variables in TestController.cpp. Renamed
2771         it 'pathSeparator', and unified them.
2772
2773         * WebKitTestRunner/TestController.cpp:
2774         (WTR::TestController::generateContextConfiguration const):
2775         (WTR::createTestURL):
2776         (WTR::TestController::platformAdjustContext):
2777
2778 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
2779
2780         Make setNeedsLayout on the root more explicitly about triggering its side-effects
2781         https://bugs.webkit.org/show_bug.cgi?id=194198
2782
2783         Reviewed by Antti Koivisto.
2784
2785         No need to set the banner heights on navigation now, since Page stores them.
2786
2787         * MiniBrowser/mac/WK2BrowserWindowController.m:
2788         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
2789
2790 2019-02-03  John Wilander  <wilander@apple.com>
2791
2792         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
2793         https://bugs.webkit.org/show_bug.cgi?id=194104
2794         <rdar://problem/47649991>
2795
2796         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
2797
2798         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2799         (TestWebKitAPI::TEST):
2800             Changed numeric types from unsigned short to uint32_t.
2801
2802 2019-02-02  David Kilzer  <ddkilzer@apple.com>
2803
2804         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
2805         <https://webkit.org/b/194178>
2806         <rdar://problem/47753473>
2807
2808         Reviewed by Alexey Proskuryakov.
2809
2810         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2811         (WTR::uninstallFakeHelvetica): Pass nullptr into
2812         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
2813
2814 2019-02-02  Zalan Bujtas  <zalan@apple.com>
2815
2816         [LFC] Initialize ICB's style with fixed width/height.
2817         https://bugs.webkit.org/show_bug.cgi?id=194188
2818
2819         Reviewed by Antti Koivisto.
2820
2821         * LayoutReloaded/misc/LFC-passing-tests.txt:
2822
2823 2019-02-02  Zalan Bujtas  <zalan@apple.com>
2824
2825         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
2826         https://bugs.webkit.org/show_bug.cgi?id=194185
2827
2828         Reviewed by Antti Koivisto.
2829
2830         * LayoutReloaded/misc/LFC-passing-tests.txt:
2831
2832 2018-12-16  Darin Adler  <darin@apple.com>
2833
2834         Convert additional String::format clients to alternative approaches
2835         https://bugs.webkit.org/show_bug.cgi?id=192746
2836
2837         Reviewed by Alexey Proskuryakov.
2838
2839         * WebKitTestRunner/TestController.cpp:
2840         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
2841         as an intermediate in code that ultimately constructs a WTF::String.
2842         (WTR::userMediaOriginHash): Use makeString.
2843         (WTR::TestController::didNavigateWithNavigationData): More of the same.
2844         (WTR::TestController::didPerformClientRedirect): Ditto.
2845         (WTR::TestController::didPerformServerRedirect): Ditto.
2846         (WTR::TestController::didUpdateHistoryTitle): Ditto.
2847
2848 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
2849
2850         [ews-build] Add unit test to verify builder keys
2851         https://bugs.webkit.org/show_bug.cgi?id=194152
2852
2853         Reviewed by Lucas Forschler.
2854
2855         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2856         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
2857
2858 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2859
2860         [LFC] Expand tests coverage (12 new tests -> 787)
2861
2862         Unreviewed test gardening.
2863
2864         * LayoutReloaded/misc/LFC-passing-tests.txt:
2865
2866 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2867
2868         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
2869         https://bugs.webkit.org/show_bug.cgi?id=194163
2870
2871         Reviewed by Simon Fraser.
2872
2873         775
2874
2875         * LayoutReloaded/misc/LFC-passing-tests.txt:
2876
2877 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2878
2879         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
2880         https://bugs.webkit.org/show_bug.cgi?id=194140
2881         <rdar://problem/47728098>
2882
2883         Reviewed by Tim Horton.
2884
2885         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2886         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2887         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
2888
2889         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
2890         test to induce an IPC deadlock when presenting a modal alert during touch start.
2891
2892         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2893         * WebKitTestRunner/TestController.cpp:
2894         (WTR::runJavaScriptAlert):
2895
2896         Add a client callback function for running JavaScript alerts.
2897
2898         (WTR::TestController::createOtherPage):
2899         (WTR::TestController::generateContextConfiguration const):
2900
2901         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
2902         the fix in this patch.
2903
2904         (WTR::TestController::createWebViewWithOptions):
2905
2906         Plumb TestOptions to generateContextConfiguration.
2907
2908         (WTR::TestController::resetPreferencesToConsistentValues):
2909         (WTR::TestController::resetStateToConsistentValues):
2910         (WTR::updateTestOptionsFromTestHeader):
2911         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
2912         (WTR::TestController::handleJavaScriptAlert):
2913         * WebKitTestRunner/TestController.h:
2914         * WebKitTestRunner/TestInvocation.cpp:
2915         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2916         * WebKitTestRunner/TestOptions.h:
2917         (WTR::TestOptions::hasSameInitializationOptions const):
2918
2919 2019-02-01  Chris Dumez  <cdumez@apple.com>
2920
2921         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
2922         https://bugs.webkit.org/show_bug.cgi?id=193740
2923         <rdar://problem/47527267>
2924
2925         Reviewed by Alex Christensen.
2926
2927         Add API test coverage.
2928
2929         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2930
2931 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
2932
2933         [ews-app] Add display name field to BuilderMapping model
2934         https://bugs.webkit.org/show_bug.cgi?id=194153
2935
2936         Reviewed by Lucas Forschler.
2937
2938         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2939         (BuilderMapping):
2940
2941 2019-02-01  Youenn Fablet  <youenn@apple.com>
2942
2943         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
2944         https://bugs.webkit.org/show_bug.cgi?id=194155
2945
2946         Reviewed by Eric Carlson.
2947
2948         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2949         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
2950         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
2951
2952 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2953
2954         [LFC] Adjust replaced element's intrinsic ratio
2955         https://bugs.webkit.org/show_bug.cgi?id=194154
2956
2957         Reviewed by Antti Koivisto.
2958
2959         761
2960
2961         * LayoutReloaded/misc/LFC-passing-tests.txt:
2962
2963 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2964
2965         [WPE] Show test results in minibrowser
2966         https://bugs.webkit.org/show_bug.cgi?id=194150
2967
2968         Reviewed by Žan Doberšek.
2969
2970         * Scripts/webkitpy/port/wpe.py:
2971         (WPEPort.show_results_html_file):
2972
2973 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2974
2975         [WPE] MiniBrowser: add ky bindings for back/forward navigation
2976         https://bugs.webkit.org/show_bug.cgi?id=194151
2977
2978         Reviewed by Žan Doberšek.
2979
2980         ALT + <- go back
2981         ALT + -> go forward
2982
2983         * MiniBrowser/wpe/main.cpp:
2984         (main):
2985
2986 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2987
2988         [LFC] Set intrinsic size on Layout::Replaced
2989         https://bugs.webkit.org/show_bug.cgi?id=194139
2990
2991         Reviewed by Antti Koivisto.
2992
2993         744
2994
2995         * LayoutReloaded/misc/LFC-passing-tests.txt:
2996
2997 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2998
2999         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
3000         https://bugs.webkit.org/show_bug.cgi?id=194146
3001
3002         Reviewed by Xabier Rodriguez-Calvar.
3003
3004         It allows to open relative paths.
3005
3006         * MiniBrowser/wpe/main.cpp:
3007         (main):
3008
3009 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
3010
3011         Update flakiness dashboard configuration after recent queue changes
3012         https://bugs.webkit.org/show_bug.cgi?id=194127
3013
3014         Rubber-stamped by Aakash Jain.
3015
3016         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
3017
3018         * TestResultServer/static-dashboards/builders.jsonp:
3019
3020 2019-01-31  Youenn Fablet  <youenn@apple.com>
3021
3022         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
3023         https://bugs.webkit.org/show_bug.cgi?id=194106
3024         <rdar://problem/47676333>
3025
3026         Reviewed by Ryosuke Niwa.
3027
3028         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3029         (TestWebKitAPI::didFinishNavigation):
3030         (TestWebKitAPI::TEST):
3031         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
3032
3033 2019-01-31  Chris Dumez  <cdumez@apple.com>
3034
3035         Page zoom level is lost after a process swap or a crash
3036         https://bugs.webkit.org/show_bug.cgi?id=194105
3037         <rdar://problem/47610781>
3038
3039         Reviewed by Alex Christensen.
3040
3041         Add API test coverage.
3042
3043         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3044         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
3045
3046 2019-01-31  Alex Christensen  <achristensen@webkit.org>
3047
3048         Revert r238819 which is unneeded and caused a performance regression.
3049         https://bugs.webkit.org/show_bug.cgi?id=192272
3050         <rdar://problem/46664625>
3051
3052         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
3053         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
3054         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
3055
3056 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
3057
3058         Formalize WebKitAdditions mechanism of LoadOptimizer
3059         https://bugs.webkit.org/show_bug.cgi?id=193886
3060         <rdar://problem/47696809>
3061
3062         Reviewed by Brent Fulgham.
3063
3064         * MiniBrowser/MiniBrowser.entitlements:
3065         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
3066
3067 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3068
3069         [LFC] Margin before/after/start/end initial value is 0 and not auto.
3070         https://bugs.webkit.org/show_bug.cgi?id=194090
3071
3072         Reviewed by Antti Koivisto.
3073
3074         * LayoutReloaded/misc/LFC-passing-tests.txt:
3075
3076 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3077
3078         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
3079         https://bugs.webkit.org/show_bug.cgi?id=194074
3080
3081         Reviewed by Antti Koivisto.
3082
3083         * LayoutReloaded/misc/LFC-passing-tests.txt:
3084
3085 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3086
3087         [LFC][BFC] Add support for block level replaced box.
3088         https://bugs.webkit.org/show_bug.cgi?id=194071
3089
3090         Reviewed by Antti Koivisto.
3091
3092         * LayoutReloaded/misc/LFC-passing-tests.txt:
3093
3094 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
3095
3096         Fix WebKitTestRunner's testPath with Windows full paths
3097         https://bugs.webkit.org/show_bug.cgi?id=194012
3098
3099         Reviewed by Alex Christensen.
3100
3101         updateTestOptionsFromTestHeader failed to open test files because
3102         testPath returned wrong file paths. It returned a path "/C:/..."
3103         if a URL "file:///C:/..." was given.
3104
3105         * WebKitTestRunner/TestController.cpp:
3106         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
3107
3108 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3109
3110         [WPE] Bump font related dependencies to match the GTK+ port
3111         https://bugs.webkit.org/show_bug.cgi?id=194017
3112
3113         Reviewed by Žan Doberšek.
3114
3115         * wpe/jhbuild.modules:
3116         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3117         * wpe/patches/icudata-stdlibs.patch: Added.
3118
3119 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3120
3121         Enable swipe tests on iOS
3122         https://bugs.webkit.org/show_bug.cgi?id=194076
3123
3124         Reviewed by Geoffrey Garen.
3125
3126         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
3127         it causes a debug assertion failure in runUIScript.
3128
3129         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3130         (WTR::UIScriptController::beginBackSwipe):
3131         (WTR::UIScriptController::completeBackSwipe):
3132
3133 2019-01-30  Keith Rollin  <krollin@apple.com>
3134
3135         Use correct printf format specifier
3136         https://bugs.webkit.org/show_bug.cgi?id=194062
3137         <rdar://problem/47686167>
3138
3139         Reviewed by Alexey Proskuryakov.
3140
3141         LayoutTestSpellChecker.mm is trying to format a variable of type
3142         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
3143         actually an unsigned long long. Fix this by formatting with %llu.
3144
3145         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
3146         (-[LayoutTestTextCheckingResult description]):
3147
3148 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3149
3150         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
3151         https://bugs.webkit.org/show_bug.cgi?id=193979
3152
3153         Reviewed by Wenson Hsieh.
3154
3155         Fix the test for iOS. Make the test work with iOS UA string.
3156
3157         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3158
3159 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
3160
3161         Replace High Sierra LLINT CLoop bot due to hardware failure
3162         https://bugs.webkit.org/show_bug.cgi?id=194066
3163
3164         Reviewed by Aakash Jain.
3165
3166         * BuildSlaveSupport/build.webkit.org-config/config.json:
3167
3168 2019-01-30  Keith Rollin  <krollin@apple.com>
3169
3170         [NSDragItem init] is unavailable
3171         https://bugs.webkit.org/show_bug.cgi?id=194059
3172         <rdar://problem/47685715>
3173
3174         Reviewed by Wenson Hsieh.
3175
3176         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
3177         DumpRenderTree and TestWebKitAPI, which both try to create an
3178         NSDragItem in a manner that invokes this method. Address this by using
3179         -initWithPasteboardWriter instead.
3180
3181         Note that the parameter passed to initWithPasteboardWriter is likely
3182         incorrect. In both cases, the object passed does not conform to
3183         NSPasteboardWriting. However, with this fix, we're no worse off than
3184         before, and can now perform builds with newer compilers and SDKs until
3185         a real fix can be crafted. That work is tracked in
3186         https://bugs.webkit.org/show_bug.cgi?id=194060
3187
3188         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3189         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3190         * TestWebKitAPI/mac/TestDraggingInfo.mm:
3191         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3192
3193 2019-01-30  Daniel Bates  <dabates@apple.com>
3194
3195         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
3196         https://bugs.webkit.org/show_bug.cgi?id=192824
3197         <rdar://problem/47100332>
3198
3199         Reviewed by Wenson Hsieh.
3200
3201         Fix a bug where the wrong usage code was used for F13 thru F24.
3202
3203         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3204         (keyCodeForDOMFunctionKey):
3205
3206 2019-01-30  Chris Dumez  <cdumez@apple.com>
3207
3208         Regression(PSON) Load hang can occur on history navigation
3209         https://bugs.webkit.org/show_bug.cgi?id=194030
3210         <rdar://problem/47656939>
3211
3212         Reviewed by Antti Koivisto.
3213
3214         Add API test coverage.
3215
3216         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3217
3218 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3219
3220         [LFC] Expand tests coverage.
3221
3222         Unreviewed test gardening.
3223
3224         * LayoutReloaded/misc/LFC-passing-tests.txt:
3225
3226 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
3227
3228         [Flatpak] Add openjpeg support
3229         https://bugs.webkit.org/show_bug.cgi?id=194019
3230
3231         Reviewed by Michael Catanzaro.
3232
3233         * flatpak/org.webkit.CommonModules.yaml:
3234
3235 2019-01-30  Commit Queue  <commit-queue@webkit.org>
3236
3237         Unreviewed, rolling out r240708.
3238         https://bugs.webkit.org/show_bug.cgi?id=194022
3239
3240         It broke WPE build (Requested by KaL on #webkit).
3241
3242         Reverted changeset:
3243
3244         "[WPE] Bump font related dependencies to match the GTK+ port"
3245         https://bugs.webkit.org/show_bug.cgi?id=194017
3246         https://trac.webkit.org/changeset/240708
3247
3248 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3249
3250         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
3251         https://bugs.webkit.org/show_bug.cgi?id=194001
3252
3253         Reviewed by Antti Koivisto.
3254
3255         * LayoutReloaded/misc/LFC-passing-tests.txt:
3256
3257 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3258
3259         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
3260         https://bugs.webkit.org/show_bug.cgi?id=194020
3261
3262         Reviewed by Antti Koivisto.
3263
3264         * LayoutReloaded/misc/LFC-passing-tests.txt:
3265
3266 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
3267
3268         AX: Support color well on iOS
3269         https://bugs.webkit.org/show_bug.cgi?id=194010
3270
3271         Reviewed by Joanmarie Diggs.
3272
3273         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3274         (WTR::AccessibilityUIElement::stringAttributeValue):
3275
3276 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3277
3278         [WPE] Bump font related dependencies to match the GTK+ port
3279         https://bugs.webkit.org/show_bug.cgi?id=194017
3280
3281         Reviewed by Žan Doberšek.
3282
3283         * wpe/jhbuild.modules:
3284         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3285         * wpe/patches/icudata-stdlibs.patch: Added.
3286
3287 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
3288
3289         [Mac] Update window scale API usage
3290         https://bugs.webkit.org/show_bug.cgi?id=193991
3291         rdar://problem/47614795
3292
3293         Reviewed by Tim Horton.
3294
3295         * DumpRenderTree/mac/DumpRenderTree.mm:
3296         (changeWindowScaleIfNeeded):
3297         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3298         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3299         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3300
3301 2019-01-29  Chris Dumez  <cdumez@apple.com>
3302
3303         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
3304         https://bugs.webkit.org/show_bug.cgi?id=193977
3305         <rdar://problem/47643716>
3306
3307         Reviewed by Geoff Garen.
3308
3309         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
3310         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
3311         to the previous provisional committing *before* we make the last load. 
3312
3313         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3314
3315 2019-01-29  Youenn Fablet  <youenn@apple.com>
3316
3317         Adopt new SPI to evaluate server certificate trust
3318         https://bugs.webkit.org/show_bug.cgi?id=193355
3319
3320         Reviewed by Alex Christensen.
3321
3322         Add infrastructure to handle HTTPS server trust evaluation testing.
3323
3324         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3325         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3326         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
3327         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
3328         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
3329         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3330         * WebKitTestRunner/TestController.cpp:
3331         (WTR::TestController::resetPreferencesToConsistentValues):
3332         (WTR::TestController::didReceiveAuthenticationChallenge):
3333         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
3334         * WebKitTestRunner/TestController.h:
3335         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
3336         * WebKitTestRunner/TestInvocation.cpp:
3337         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3338         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3339         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
3340
3341 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3342
3343         [ews-build] Add build step to print bot Configuration
3344         https://bugs.webkit.org/show_bug.cgi?id=193887
3345
3346         Reviewed by Lucas Forschler.
3347
3348         * BuildSlaveSupport/ews-build/steps.py:
3349         (PrintConfiguration): Build step to print configuration.
3350         * BuildSlaveSupport/ews-build/factories.py:
3351
3352 2019-01-29  Chris Dumez  <cdumez@apple.com>
3353
3354         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
3355         https://bugs.webkit.org/show_bug.cgi?id=193967
3356         <rdar://problem/47635348>
3357
3358         Reviewed by Alex Christensen.
3359
3360         Add API test coverage.
3361
3362         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3363         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
3364
3365 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3366
3367         [ews-app] Handle incoming results data
3368         https://bugs.webkit.org/show_bug.cgi?id=193973
3369
3370         Reviewed by Lucas Forschler.
3371
3372         * BuildSlaveSupport/ews-app/ews/views/results.py:
3373
3374 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3375
3376         [ews-app] Make the results url generic
3377         https://bugs.webkit.org/show_bug.cgi?id=193928
3378
3379         Reviewed by Lucas Forschler.
3380
3381         * BuildSlaveSupport/ews-app/ews/urls.py:
3382
3383 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3384
3385         [ews-build] Configure buildbot to send events to ews-app
3386         https://bugs.webkit.org/show_bug.cgi?id=193968
3387
3388         Reviewed by Lucas Forschler.
3389
3390         * BuildSlaveSupport/ews-build/events.py: Added.
3391         * BuildSlaveSupport/ews-build/master.cfg:
3392
3393 2019-01-29  Keith Rollin  <krollin@apple.com>
3394
3395         Add .xcfilelists to Run Script build phases
3396         https://bugs.webkit.org/show_bug.cgi?id=193792
3397         <rdar://problem/47201785>
3398
3399         Reviewed by Alex Christensen.
3400
3401         As part of supporting XCBuild, update the necessary Run Script build
3402         phases in their Xcode projects to refer to their associated
3403         .xcfilelist files.
3404
3405         Note that the addition of these files bumps the Xcode project version
3406         number to something that's Xcode 10 compatible. This change means that
3407         older versions of the Xcode IDE can't read these projects. Nor can it
3408         fully load workspaces that refer to these projects (the updated
3409         projects are shown as non-expandable placeholders). `xcodebuild` can
3410         still build these projects; it's just that the IDE can't open them.
3411
3412         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3413         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3414
3415 2019-01-29  John Wilander  <wilander@apple.com>
3416
3417         Add data abstraction and validation for Ad Click Attribution
3418         https://bugs.webkit.org/show_bug.cgi?id=193916
3419         <rdar://problem/47603481>
3420
3421         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
3422
3423         Ad click attribution has two steps. First, the storage of an ad
3424         campaign ID for a click that takes the user to a destination
3425         site. Second, a conversion on the destination site that can be
3426         attributed to the ad click.
3427
3428         This patch adds a class that represents a request for ad click
3429         attribution. Validation makes sure that the bits of entropy
3430         reported through this mechanism is limited.
3431
3432         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3433         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
3434         (TestWebKitAPI::TEST):
3435
3436 2019-01-29  Chris Dumez  <cdumez@apple.com>
3437
3438         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
3439         https://bugs.webkit.org/show_bug.cgi?id=193932
3440         <rdar://problem/47598947>
3441
3442         Reviewed by Brady Eidson.
3443
3444         Add API test coverage.
3445
3446         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3447
3448 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3449
3450         Adding new passing LFC tests.
3451
3452         Unreviewed test gardening.
3453
3454         * LayoutReloaded/misc/LFC-passing-tests.txt:
3455
3456 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3457
3458         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
3459         https://bugs.webkit.org/show_bug.cgi?id=193964
3460
3461         Reviewed by Antti Koivisto.
3462
3463         * LayoutReloaded/misc/LFC-passing-tests.txt:
3464
3465 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3466
3467         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
3468         https://bugs.webkit.org/show_bug.cgi?id=193954
3469
3470         Reviewed by Antti Koivisto.
3471
3472         * LayoutReloaded/misc/LFC-passing-tests.txt:
3473
3474 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
3475
3476         WebDriver: add support for running subtests
3477         https://bugs.webkit.org/show_bug.cgi?id=193904
3478
3479         Reviewed by Michael Catanzaro.
3480
3481         pytest already supports it by passing test.py::subtest, so we can do the same.
3482
3483         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
3484         (get_item_name): Made this global.
3485         (CollectRecorder.__init__): Receive the parameter to ignore.
3486         (CollectRecorder.pytest_collectreport): Collect also the subtests.
3487         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
3488         (collect): Add parameter to ignore.
3489         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
3490         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
3491         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
3492         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
3493         (WebDriverTestRunnerSelenium.run): Ditto.
3494         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
3495         (WebDriverTestRunnerW3C.collect_tests): Ditto.
3496         (WebDriverTestRunnerW3C.run): Ditto.
3497
3498 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
3499
3500         User agent string override for navigator.userAgent should be site specific quirks
3501         https://bugs.webkit.org/show_bug.cgi?id=193950
3502
3503         Reviewed by Brent Fulgham.
3504
3505         Updated per the _WKWebsitePolicies rename.
3506
3507         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3508         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3509
3510 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
3511
3512         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
3513         https://bugs.webkit.org/show_bug.cgi?id=193941
3514
3515         Reviewed by Alex Christensen.
3516
3517         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
3518         * TestWebKitAPI/Tests/WTF/Condition.cpp:
3519         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3520         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3521         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3522         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
3523         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
3524         * TestWebKitAPI/Tests/WTF/Time.cpp:
3525         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
3526         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
3527         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3528         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
3529
3530 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
3531
3532         Unreviewed, reorder my emails to fix autocomplete in bugzilla
3533
3534         * Scripts/webkitpy/common/config/contributors.json:
3535
3536 2019-01-28  Andy Estes  <aestes@apple.com>
3537
3538         [watchOS] Enable Parental Controls content filtering
3539         https://bugs.webkit.org/show_bug.cgi?id=193939
3540         <rdar://problem/46641912>
3541
3542         Reviewed by Ryosuke Niwa.
3543
3544         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3545
3546 2019-01-28  David Kilzer  <ddkilzer@apple.com>
3547
3548         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
3549         <https://webkit.org/b/193884>
3550
3551         Reviewed by Jiewen Tan.
3552
3553         * Scripts/webkitpy/style/checkers/cpp.py:
3554         (check_language): Add LocalAuthentication to
3555         `frameworks_with_soft_links`.
3556
3557 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
3558
3559         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
3560         https://bugs.webkit.org/show_bug.cgi?id=193891
3561
3562         Reviewed by Ross Kirsling.
3563
3564         There were three problems in window sizes of WebView and the host window.
3565         1. The sizes of pixel image output were incorrect.
3566         2. The host window is going to appear after window.resize was invoked.
3567         3. window.resize resized only the host window, not WebView.
3568
3569         This change solves them with a following approach.
3570         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
3571         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
3572            as well as DumpRenderTree in order to match the client area and the window area.
3573         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
3574         d. PlatformWebView::setWindowFrame changes both window sizes.
3575         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
3576
3577         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3578         (WTR::PlatformWebView::PlatformWebView): Create the host window
3579         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
3580         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
3581         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
3582
3583 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3584
3585         [ews-app] Add method to save Step data to database
3586         https://bugs.webkit.org/show_bug.cgi?id=193890
3587
3588         Reviewed by Lucas Forschler.
3589
3590         * BuildSlaveSupport/ews-app/ews/models/step.py:
3591         (Step.save_step): Method to save step data.
3592         (Step.update_step): Method to update step data.
3593         (Step.get_existing_step): Method to fetch existing step from database.
3594         (Step.is_valid_result): Method to validate valid step result.
3595
3596 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3597
3598         [ews-app] Add method to save Build data to database
3599         https://bugs.webkit.org/show_bug.cgi?id=193735
3600
3601         Reviewed by Lucas Forschler.
3602
3603         * BuildSlaveSupport/ews-app/ews/models/build.py:
3604         (Build.save_build): Method to save build information to database.
3605         (Build.get_existing_build): Method to fetch existing build from database.
3606         (Build.is_valid_result): Method to validate build result.
3607         * BuildSlaveSupport/ews-app/ews/common/util.py:
3608         (is_valid_int_id): Method to validate valid id.
3609
3610 2019-01-28  Chris Dumez  <cdumez@apple.com>
3611
3612         Regression(PSON) Crash under WebPageProxy::didStartProgress()
3613         https://bugs.webkit.org/show_bug.cgi?id=193915
3614         <rdar://problem/47560907>
3615
3616         Reviewed by Alex Christensen.
3617
3618         Add API test coverage.
3619
3620         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3621
3622 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3623
3624         [ews-app] Rename id variables
3625         https://bugs.webkit.org/show_bug.cgi?id=193883
3626
3627         Reviewed by Lucas Forschler.
3628
3629         * BuildSlaveSupport/ews-app/ews/models/build.py:
3630         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3631         * BuildSlaveSupport/ews-app/ews/models/step.py:
3632         * BuildSlaveSupport/ews-app/ews/urls.py:
3633         * BuildSlaveSupport/ews-app/ews/views/patch.py:
3634         * BuildSlaveSupport/ews-app/ews/views/results.py:
3635         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3636
3637 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3638
3639         [ews-app] Allow certain fields to be empty
3640         https://bugs.webkit.org/show_bug.cgi?id=193892
3641
3642         Reviewed by Lucas Forschler.
3643
3644         * BuildSlaveSupport/ews-app/ews/models/build.py:
3645         * BuildSlaveSupport/ews-app/ews/models/step.py:
3646
3647 2019-01-28  Rob Buis  <rbuis@igalia.com>
3648
3649         Update MIME type parser
3650         https://bugs.webkit.org/show_bug.cgi?id=180526
3651
3652         Reviewed by Frédéric Wang.
3653
3654         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3655         (TestWebKitAPI::TEST):
3656
3657 2019-01-28  Zalan Bujtas  <zalan@apple.com>
3658
3659         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
3660         https://bugs.webkit.org/show_bug.cgi?id=193896
3661
3662         Reviewed by Antti Koivisto.
3663
3664         * LayoutReloaded/misc/LFC-passing-tests.txt:
3665
3666 2018-12-15  Darin Adler  <darin@apple.com>
3667
3668         Replace many uses of String::format with more type-safe alternatives
3669         https://bugs.webkit.org/show_bug.cgi?id=192742
3670
3671         Reviewed by Mark Lam.
3672
3673         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3674         (WTR::cacheTestRunnerCallback): Use makeString.
3675         * WebKitTestRunner/TestController.cpp:
3676         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
3677         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
3678
3679 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
3680
3681         Use a load optimizer for some sites
3682         https://bugs.webkit.org/show_bug.cgi?id=193881
3683         <rdar://problem/46325455>
3684
3685         Reviewed by Brent Fulgham.
3686
3687         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3688         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
3689
3690 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
3691
3692         AX: Introduce a static accessibility tree
3693         https://bugs.webkit.org/show_bug.cgi?id=193348
3694         <rdar://problem/47203295>
3695
3696         Reviewed by Ryosuke Niwa.
3697
3698         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3699
3700 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3701
3702         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
3703         https://bugs.webkit.org/show_bug.cgi?id=193867
3704
3705         Reviewed by Antti Koivisto.
3706
3707         * LayoutReloaded/misc/LFC-passing-tests.txt:
3708
3709 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3710
3711         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
3712         https://bugs.webkit.org/show_bug.cgi?id=193865
3713
3714         Reviewed by Antti Koivisto.
3715
3716         * LayoutReloaded/misc/LFC-passing-tests.txt:
3717
3718 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
3719
3720         Need a mechanism to override navigator.userAgent
3721         https://bugs.webkit.org/show_bug.cgi?id=193762
3722         <rdar://problem/47504939>
3723
3724         Reviewed by Brent Fulgham.
3725
3726         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
3727
3728         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3729         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3730         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
3731
3732 2019-01-25  Dean Jackson  <dino@apple.com>
3733
3734         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
3735         https://bugs.webkit.org/show_bug.cgi?id=193831
3736         <rdar://problem/47399263>
3737
3738         Reviewed by Chris Dumez.
3739
3740         Two new tests that exercise cross-origin and same-origin System
3741         Previews.
3742
3743         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3744
3745 2019-01-25  Keith Rollin  <krollin@apple.com>
3746
3747         Update Xcode projects with "Check .xcfilelists" build phase
3748         https://bugs.webkit.org/show_bug.cgi?id=193790
3749         <rdar://problem/47201374>
3750
3751         Reviewed by Alex Christensen.
3752
3753         Support for XCBuild includes specifying inputs and outputs to various
3754         Run Script build phases. These inputs and outputs are specified as
3755         .xcfilelist files. Once created, these .xcfilelist files need to be
3756         kept up-to-date. In order to check that they are up-to-date or not,
3757         add an Xcode build step that invokes an external script that performs
3758         the checking. If the .xcfilelists are found to be out-of-date, update
3759         them, halt the build, and instruct the developer to restart the build
3760         with up-to-date files.
3761
3762         At this time, the checking and regenerating is performed only if the
3763         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
3764         who want to use this facility can set this variable and test out the
3765         checking/regenerating. Once it seems like there are no egregious
3766         issues that upset a developer's workflow, we'll unconditionally enable
3767         this facility.
3768
3769         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3770         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
3771         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
3772         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3773
3774 2019-01-25  Keith Rollin  <krollin@apple.com>
3775
3776         Update Xcode projects with "Apply Configuration to XCFileLists" build target
3777         https://bugs.webkit.org/show_bug.cgi?id=193781
3778         <rdar://problem/47201153>
3779
3780         Reviewed by Alex Christensen.
3781
3782         Part of generating the .xcfilelists used as part of adopting XCBuild
3783         includes running `make DerivedSources.make` from a standalone script.
3784         It’s important for this invocation to have the same environment as
3785         when the actual build invokes `make DerivedSources.make`. If the
3786         environments are different, then the two invocations will provide
3787         different results. In order to get the same environment in the
3788         standalone script, have the script launch xcodebuild targeting the
3789         "Apply Configuration to XCFileLists" build target, which will then
3790         re-invoke our standalone script. The script is now running again, this
3791         time in an environment with all workspace, project, target, xcconfig
3792         and other environment variables established.
3793
3794         The "Apply Configuration to XCFileLists" build target accomplishes
3795         this task via a small embedded shell script that consists only of:
3796
3797             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
3798
3799         The process that invokes "Apply Configuration to XCFileLists" first
3800         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
3801         evaluated and exports it into the shell environment. When xcodebuild
3802         is invoked, it inherits the value of this variable and can `eval` the
3803         contents of that variable. Our external standalone script can then set
3804         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
3805         of command-line parameters needed to restart itself in the appropriate
3806         state.
3807
3808         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3809         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3810
3811 2019-01-25  Alex Christensen  <achristensen@webkit.org>
3812
3813         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
3814         https://bugs.webkit.org/show_bug.cgi?id=193802
3815         <rdar://problem/46010580>
3816
3817         Reviewed by Andy Estes.
3818
3819         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3820         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
3821         (TEST):
3822
3823 2019-01-25  Daniel Bates  <dabates@apple.com>
3824
3825         [iOS] uiController.keyDown() does not translate Control modified key
3826         https://bugs.webkit.org/show_bug.cgi?id=192898
3827
3828         Reviewed by Wenson Hsieh.
3829
3830         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
3831         key translation, as applicable. Among other cases, key translation occurs when performing
3832         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
3833         also makes the behavior of uiController.keyDown() more closely match the behavior of a
3834         human pressing down and releasing key(s) using a hardware keyboard.
3835
3836         * WebKitTestRunner/ios/HIDEventGenerator.h:
3837         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3838         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
3839
3840         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
3841         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
3842         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3843         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3844         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
3845         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3846         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
3847         (-[HIDEventGenerator longPress:completionBlock:]):
3848         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
3849         Update code for above renaming.
3850
3851         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
3852         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
3853
3854         (-[HIDEventGenerator keyDown:]): Added.
3855         (-[HIDEventGenerator keyUp:]): Added.
3856         (-[HIDEventGenerator keyPress:completionBlock:]):
3857         (-[HIDEventGenerator eventDispatchThreadEntry:]):
3858         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
3859         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3860         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
3861         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
3862         (WTR::parseModifier): Deleted.
3863
3864 2019-01-25  Keith Rollin  <krollin@apple.com>
3865
3866         Complete the implementation of generate-xcfilelists
3867         https://bugs.webkit.org/show_bug.cgi?id=193782
3868
3869         Reviewed by Alex Christensen.
3870
3871         A preliminary version of generate-xcfilelists was added in r238008.
3872         This patch updates that script in order to:
3873
3874         - Support checking of .xcfilelists
3875         - Perform better execution of `make DerivedSources.make` by
3876           relaunching generate-xcfilelists under xcodebuild
3877         - Support incremental generation and checking of .xcfilelists
3878         - Support supplementary .xcfilelists files from WebKitAdditions
3879         - Support being wrapped by parallel version of generate-xcfilelists in
3880           Internal that adds support for (re)generating WebKit projects in
3881           that repo.
3882         - Support builds that have been performed in WebKitBuild as well as
3883           ~/Library/Developer/code/DerivedData
3884         - Increase robustness and debugging facilities.
3885
3886         * Scripts/generate-xcfilelists:
3887
3888 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
3889
3890         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3891         https://bugs.webkit.org/show_bug.cgi?id=193297
3892         <rdar://problem/47158841>
3893
3894         Unreviewed test case fix.
3895
3896         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
3897         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
3898
3899         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3900         (TEST):
3901
3902 2019-01-25  Keith Rollin  <krollin@apple.com>
3903
3904         Update existing .xcfilelists
3905         https://bugs.webkit.org/show_bug.cgi?id=193791
3906         <rdar://problem/47201706>
3907
3908         Reviewed by Alex Christensen.
3909
3910         Many .xcfilelist files were added in r238824 in order to support
3911         XCBuild. Update these with recent changes to the set of build files
3912         and with the current generate-xcfilelist script.
3913
3914         * DumpRenderTree/DerivedSources-input.xcfilelist:
3915         * DumpRenderTree/DerivedSources-output.xcfilelist:
3916         * WebKitTestRunner/DerivedSources-input.xcfilelist:
3917         * WebKitTestRunner/DerivedSources-output.xcfilelist:
3918
3919 2019-01-25  Keith Rollin  <krollin@apple.com>
3920
3921         Fix missing dependencies in extract-dependencies-from-makefile
3922         https://bugs.webkit.org/show_bug.cgi?id=193783
3923         <rdar://problem/47201571>
3924
3925         Reviewed by Alex Christensen.
3926
3927         The extract-dependencies-from-makefile script generates .xcfilelists
3928         for XCBuild by invoking a makefile in --debug mode, parsing the
3929         dependency information in the output, and extracting information
3930         regarding targets and dependents. However, the way `make` emits this
3931         dependency information is not rigorous, and so we need to determine
3932         what lines to look for and parse by trial and error. This approach
3933         didn't coriginally atch all the information we needed to collect, so
3934         update the script to look for the additional lines we now know to look
3935         for.
3936
3937         * Scripts/extract-dependencies-from-makefile:
3938         (Parser):
3939         (Parser.addTarget):
3940         (Parser.addPrereq):
3941         (Parser.doParse):
3942
3943 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
3944
3945         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3946         https://bugs.webkit.org/show_bug.cgi?id=193297
3947         <rdar://problem/47158841>
3948
3949         Reviewed by Alex Christensen.
3950
3951         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
3952             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
3953         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3954         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
3955         activating the message used to trigger the callback when it is set.
3956
3957 2019-01-25  Alex Christensen  <achristensen@webkit.org>
3958
3959         WKWebView.goBack should reload if there is a safe browsing warning
3960         https://bugs.webkit.org/show_bug.cgi?id=193805
3961         <rdar://problem/46908216>
3962
3963         Reviewed by Geoff Garen.
3964
3965         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3966         (+[Simple3LookupContext sharedLookupContext]):
3967         (-[Simple3LookupContext lookUpURL:completionHandler:]):
3968         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
3969         (TEST):
3970
3971 2019-01-25  Chris Dumez  <cdumez@apple.com>
3972
3973         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
3974         https://bugs.webkit.org/show_bug.cgi?id=193788
3975         <rdar://problem/47531231>
3976
3977         Reviewed by Alex Christensen.
3978
3979         Add API test coverage.
3980
3981         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3982         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
3983
3984 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
3985
3986         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
3987         https://bugs.webkit.org/show_bug.cgi?id=193771
3988
3989         Unreviewed infrastructure fix.
3990
3991         * Scripts/webkitpy/port/darwin.py:
3992         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
3993
3994 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
3995
3996         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
3997
3998 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
3999
4000         Add contributors.json entries for Ling Ho and for a new bot watchers group.
4001
4002         * Scripts/webkitpy/common/config/contributors.json:
4003
4004 2019-01-25  Chris Dumez  <cdumez@apple.com>
4005
4006         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
4007         https://bugs.webkit.org/show_bug.cgi?id=193779
4008         <rdar://problem/46170903>
4009
4010         Reviewed by Antti Koivisto.
4011
4012         Add API test that quickly navigates forward to a previous process without waiting for it to
4013         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
4014         the process' previous page when reconnecting the it for the forward navigation.
4015
4016         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4017
4018 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
4019
4020         Need a way for JavaScript (or bundle) code to participate in undo
4021         https://bugs.webkit.org/show_bug.cgi?id=190009
4022         <rdar://problem/44807048>
4023
4024         Reviewed by Ryosuke Niwa.
4025
4026         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
4027         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
4028
4029         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4030         (WTR::UIScriptController::lastUndoLabel const):
4031         (WTR::UIScriptController::firstRedoLabel const):
4032         (WTR::UIScriptController::platformUndoManager const):
4033         * DumpRenderTree/mac/UIScriptControllerMac.mm:
4034         (WTR::UIScriptController::lastUndoLabel const):
4035         (WTR::UIScriptController::firstRedoLabel const):
4036         (WTR::UIScriptController::platformUndoManager const):
4037         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4038         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4039         (WTR::UIScriptController::lastUndoLabel const):
4040         (WTR::UIScriptController::firstRedoLabel const):
4041         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4042         * WebKitTestRunner/UIScriptControllerCocoa.mm:
4043         (WTR::UIScriptController::lastUndoLabel const):
4044         (WTR::UIScriptController::firstRedoLabel const):
4045         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4046         (WTR::UIScriptController::platformUndoManager const):
4047         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
4048         (WTR::UIScriptController::platformUndoManager const):
4049
4050 2019-01-25  Zalan Bujtas  <zalan@apple.com>
4051
4052         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
4053         https://bugs.webkit.org/show_bug.cgi?id=193824
4054
4055         Reviewed by Antti Koivisto.
4056
4057         * LayoutReloaded/misc/LFC-passing-tests.txt:
4058
4059 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
4060
4061         Update macOS JSC bot configurations
4062         https://bugs.webkit.org/show_bug.cgi?id=193739
4063
4064         Reviewed by Alexey Proskuryakov.
4065
4066         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
4067         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
4068         (BubbleQueueServer): Move JSC EWS to Mojave section.
4069         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4070         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
4071         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
4072
4073 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
4074
4075         [Win][WebKitTestRunner] Implement EventSenderProxy
4076         https://bugs.webkit.org/show_bug.cgi?id=193755
4077
4078         Reviewed by Don Olmstead.
4079
4080         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
4081         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
4082         (WTR::EventSenderProxy::dispatchMessage):
4083         (WTR::EventSenderProxy::EventSenderProxy):
4084         (WTR::EventSenderProxy::mouseDown):
4085         (WTR::EventSenderProxy::mouseUp):
4086         (WTR::EventSenderProxy::mouseMoveTo):
4087         (WTR::EventSenderProxy::mouseScrollBy):
4088         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
4089
4090 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
4091
4092         Unreviewed fix for API test failure after r240437.
4093
4094         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
4095
4096         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
4097
4098 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
4099
4100         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
4101         https://bugs.webkit.org/show_bug.cgi?id=193787
4102         <rdar://problem/47497634>
4103
4104         Reviewed by Alexey Proskuryakov.
4105
4106         * Scripts/webkitdirs.pm:
4107         (iosSimulatorApplicationsPath): Pick from available runtime directories.
4108
4109 2019-01-24  Truitt Savell  <tsavell@apple.com>
4110
4111         Unreviewed, rolling out r240446.
4112
4113         Casued 5 API failures
4114
4115         Reverted changeset:
4116
4117         "Activate the WebResourceLoadStatisticsStore in the
4118         NetworkProcess and deactivate it in the UIProcess."
4119         https://bugs.webkit.org/show_bug.cgi?id=193297
4120         https://trac.webkit.org/changeset/240446
4121
4122 2019-01-24  Zalan Bujtas  <zalan@apple.com>
4123
4124         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
4125         https://bugs.webkit.org/show_bug.cgi?id=193741
4126         <rdar://problem/47135030>
4127
4128         Reviewed by Antti Koivisto and Simon Fraser.
4129
4130         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4131         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
4132         (TestWebKitAPI::TEST):
4133
4134 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
4135
4136         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
4137         https://bugs.webkit.org/show_bug.cgi?id=193297
4138         <rdar://problem/47158841>
4139
4140         Reviewed by Alex Christensen.
4141
4142         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4143         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
4144         activating the message used to trigger the callback when it is set.
4145
4146 2019-01-24  John Wilander  <wilander@apple.com>
4147
4148         Add Ad Click Attribution as an internal/experimental feature
4149         https://bugs.webkit.org/show_bug.cgi?id=193685
4150         <rdar://problem/47450399>
4151
4152         Reviewed by Brent Fulgham.
4153
4154         Added test option adClickAttributionEnabled.
4155
4156         * DumpRenderTree/TestOptions.cpp:
4157         (TestOptions::TestOptions):
4158         * DumpRenderTree/TestOptions.h:
4159         * DumpRenderTree/mac/DumpRenderTree.mm:
4160         (setWebPreferencesForTestOptions):
4161
4162 2019-01-24  Antti Koivisto  <antti@apple.com>
4163
4164         [PSON] Flash on back navigation on Mac
4165         https://bugs.webkit.org/show_bug.cgi?id=193716
4166         <rdar://problem/47148458>
4167
4168         Reviewed by Chris Dumez.
4169
4170         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4171
4172         Closing of the previous page is delayed so waiting for didFinishNavigation is
4173         not sufficient to guarantee we have received all the messages. Wait for them.
4174
4175 2019-01-24  Chris Dumez  <cdumez@apple.com>
4176
4177         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
4178         https://bugs.webkit.org/show_bug.cgi?id=193761
4179         <rdar://problem/47456405>
4180
4181         Reviewed by Alex Christensen.
4182
4183         Add API test coverage.
4184
4185         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4186
4187 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
4188
4189         webkitpy: Missing PID in crashlog name should not be fatal
4190         https://bugs.webkit.org/show_bug.cgi?id=193771
4191
4192         If we can't determine the PID of a crashlog, just ignore the crashlog instead
4193         of raising an exception.
4194
4195         Reviewed by Lucas Forschler.
4196
4197         * Scripts/webkitpy/port/darwin.py:
4198         (DarwinPort._merge_crash_logs):
4199
4200 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
4201
4202         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
4203         https://bugs.webkit.org/show_bug.cgi?id=193746
4204
4205         Reviewed by Youenn Fablet.
4206
4207         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
4208         so we'd best just not call it.
4209
4210         * Scripts/webkitpy/w3c/test_exporter.py:
4211         (WebPlatformTestExporter.create_branch_with_patch):
4212
4213 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
4214
4215         Move FileSystem to WTF
4216         https://bugs.webkit.org/show_bug.cgi?id=193602
4217
4218         Reviewed by Yusuke Suzuki.
4219
4220         * DumpRenderTree/win/DumpRenderTree.cpp:
4221         * TestWebKitAPI/CMakeLists.txt:
4222         * TestWebKitAPI/PlatformGTK.cmake:
4223         * TestWebKitAPI/PlatformJSCOnly.cmake:
4224         * TestWebKitAPI/PlatformPlayStation.cmake:
4225         * TestWebKitAPI/PlatformWPE.cmake:
4226         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4227         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
4228         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
4229         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
4230         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
4231         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
4232         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
4233         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4234         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
4235         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
4236
4237 2019-01-24  Philippe Normand  <pnormand@igalia.com>
4238
4239         [WPE] Remove hard dependency on subprocess32 for the API tests
4240
4241         Rubber-stamped by Carlos Garcia Campos.
4242
4243         * glib/api_test_runner.py:
4244         (TestRunner._run_test_qt): Lazily import subprocess32 and check
4245         its presence only when running WPEQt tests.
4246
4247 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
4248
4249         [GLIB] Expose JavaScriptCore options in GLib public API
4250         https://bugs.webkit.org/show_bug.cgi?id=188742
4251
4252         Reviewed by Michael Catanzaro.
4253
4254         Add a test for the new API.
4255
4256         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
4257         (testsJSCOptions):
4258         (main):
4259
4260 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
4261
4262         [GTK][WPE] Support JPEG 2000 images
4263         https://bugs.webkit.org/show_bug.cgi?id=186272
4264
4265         Reviewed by Žan Doberšek.
4266
4267         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
4268
4269         * gtk/jhbuild.modules:
4270         * wpe/jhbuild.modules:
4271
4272 2019-01-23  David Kilzer  <ddkilzer@apple.com>
4273
4274         check-webkit-style should warn when using soft-linking macros in a header
4275         <https://webkit.org/b/193750>
4276
4277         Reviewed by Darin Adler.
4278
4279         * Scripts/webkitpy/style/checkers/cpp.py:
4280         (check_language): Add softlink/header check by refactoring the
4281         softlink/framework check.
4282         (CppChecker): Enable softlink/header check by default.
4283         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4284         (CppStyleTest.test_softlink_framework): Rename from
4285         CppStyleTest.test_softlink() and change test framework name in
4286         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
4287         files. Set file_name for macros that only appear in headers.
4288         (CppStyleTest.test_softlink_header): Add tests for using
4289         soft-link macros in headers.
4290
4291 2019-01-23  Chris Dumez  <cdumez@apple.com>
4292
4293         Deprecate API to limit the maximum number of WebProcesses
4294         https://bugs.webkit.org/show_bug.cgi?id=193725
4295         <rdar://problem/47464879>
4296
4297         Reviewed by Geoff Garen.
4298
4299         Update existing API tests to stop using deprecated API.
4300
4301         * MiniBrowser/mac/AppDelegate.m:
4302         (defaultConfiguration):
4303         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
4304         (TestWebKitAPI::TEST):
4305         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
4306         (TestWebKitAPI::TEST):
4307         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4308         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
4309         (TEST):
4310         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
4311         (TEST):
4312
4313 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
4314
4315         [ews-app] Rename ews model buildermappings to buildermapping
4316         https://bugs.webkit.org/show_bug.cgi?id=193729
4317
4318         Reviewed by Lucas Forschler.
4319
4320         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
4321         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
4322         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
4323
4324 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
4325
4326         [ews-app] Rename ews model steps to step
4327         https://bugs.webkit.org/show_bug.cgi?id=193697
4328
4329         Reviewed by Lucas Forschler.
4330
4331         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
4332         (Step): Renamed Steps to Step.
4333
4334 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
4335
4336         Clean up IndexedDB files between tests
4337         https://bugs.webkit.org/show_bug.cgi?id=192796
4338         <rdar://problem/46824999>
4339
4340         Reviewed by Geoffrey Garen.
4341
4342         * DumpRenderTree/mac/DumpRenderTree.mm:
4343         (runTest):
4344         * WebKitTestRunner/TestController.cpp:
4345         (WTR::TestController::resetStateToConsistentValues):
4346         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
4347         (WTR::RemoveAllIndexedDatabasesCallback):
4348         (WTR::TestController::ClearIndexedDatabases):
4349         * WebKitTestRunner/TestController.h:
4350         * WebKitTestRunner/TestInvocation.cpp:
4351         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4352
4353 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
4354
4355         [ews-app] Rename ews model Builds to Build
4356         https://bugs.webkit.org/show_bug.cgi?id=193695
4357
4358         Reviewed by Lucas Forschler.
4359
4360         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
4361         (Build): Renamed Builds to Build.
4362
4363 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
4364
4365         webkitpy: Wait longer when launching WebKitTestRunner
4366         https://bugs.webkit.org/show_bug.cgi?id=193734
4367
4368         Reviewed by Aakash Jain.
4369
4370         * Scripts/webkitpy/port/simulator_process.py:
4371         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
4372
4373 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
4374
4375         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
4376         https://bugs.webkit.org/show_bug.cgi?id=193182
4377         <rdar://problem/47452154>
4378
4379         Reviewed by Tim Horton.
4380
4381         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
4382         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
4383         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
4384
4385         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
4386         preventing later tests from recognizing gestures.
4387
4388         * WebKitTestRunner/ios/TestControllerIOS.mm:
4389         (WTR::TestController::platformResetStateToConsistentValues):
4390
4391