c9e1d26418c2f950272682d9599d59bb571c91fe
[WebKit-https.git] / Tools / ChangeLog
1 2020-04-07  Fujii Hironori  <Hironori.Fujii@sony.com>
2
3         [Clang 10] Fix -Wimplicit-int-float-conversion compilation warnings in TestWebKitAPI
4         https://bugs.webkit.org/show_bug.cgi?id=210067
5
6         Reviewed by Darin Adler.
7
8         There are test cases for overflow, non-overflow, underflow and
9         non-underflow edge cases in WTF.clampToIntegerFloat test.
10         maxPlusOne<int> can be used for overflow edge case, INT_MIN for
11         non-underflow. This change added code to calculate values for
12         non-overflow and underflow cases.
13
14         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
15         (TestWebKitAPI::TEST(WTF.clampToIntegerFloat)):
16         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
17         (TestWebKitAPI::TEST(FloatRect.EnclosingIntRect)): Replaced
18         shiftMaxXEdgeTo(INT_MAX) with shiftMaxXEdgeTo(0) because it also
19         causes overflow for enclosingIntRect.
20
21 2020-04-07  Aakash Jain  <aakash_jain@apple.com>
22
23         [ews] Add unit tests for layout tests factories
24         https://bugs.webkit.org/show_bug.cgi?id=210150
25
26         Reviewed by Jonathan Bedard.
27
28         * BuildSlaveSupport/ews-build/factories_unittest.py:
29         (TestLayoutTestsFactory):
30         (TestLayoutTestsFactory.test_macos_wk1_release_factory): Added unit-test.
31         (TestLayoutTestsFactory.test_macos_wk1_debug_factory): Ditto.
32         (TestLayoutTestsFactory.test_macos_wk2_factory): Ditto.
33         (TestLayoutTestsFactory.test_ios_wk2_factory): Ditto.
34         (TestGTKFactory): Renamed.
35
36 2020-04-07  Aakash Jain  <aakash_jain@apple.com>
37
38         [ews] Improve summary for CheckPatchRelevance build step
39         https://bugs.webkit.org/show_bug.cgi?id=210146
40
41         Reviewed by Jonathan Bedard.
42
43         * BuildSlaveSupport/ews-build/steps.py:
44         (CheckPatchRelevance): Improved success message.
45         (CheckPatchRelevance.start):
46         (CheckPatchRelevance.getResultSummary): Improved failure message.
47         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
48         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Updated accordingly.
49
50 2020-04-07  Jiewen Tan  <jiewen_tan@apple.com>
51
52         [WebAuthn] Cancel WebAuthn requests when users cancel LocalAuthentication prompts
53         https://bugs.webkit.org/show_bug.cgi?id=209923
54         <rdar://problem/61223713>
55
56         Reviewed by Brent Fulgham.
57
58         Modifies existing tests to accommodate changes in MockWebAuthenticationConfiguration.idl.
59
60         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html:
61         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-duplicate-credential.html:
62         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-error.html:
63         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la.html:
64
65 2020-04-07  Ryan Haddad  <ryanhaddad@apple.com>
66
67         Unreviewed, reverting r259655.
68
69         Caused assertion failures and timeouts on iOS bots
70
71         Reverted changeset:
72
73         "Return app-bound sessions for instances where
74         WKAppBoundDomains is"
75         https://bugs.webkit.org/show_bug.cgi?id=210124
76         https://trac.webkit.org/changeset/259655
77
78 2020-04-07  Joanmarie Diggs  <jdiggs@igalia.com>
79
80         AX: Change ATK mapping of the ARIA alert and alertdialog roles
81         https://bugs.webkit.org/show_bug.cgi?id=210121
82
83         Reviewed by Chris Fleizach.
84
85         Add support for ATK_ROLE_NOTIFICATION.
86
87         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
88
89 2020-04-07  Wenson Hsieh  <wenson_hsieh@apple.com>
90
91         Preventing touch events should not prevent gestures installed above WKWebView from recognizing
92         https://bugs.webkit.org/show_bug.cgi?id=210080
93         <rdar://problem/61365814>
94
95         Reviewed by Tim Horton.
96
97         Add a UIScriptController helper method that allows a test to install a tap gesture recognizer on the UIWindow
98         containing the web view. This method additionally takes a JavaScript callback, which is invoked when the tap
99         gesture is recognized.
100
101         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
102         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
103         * TestRunnerShared/UIScriptContext/UIScriptController.h:
104         (WTR::UIScriptController::installTapGestureOnWindow):
105         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
106         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
107         (-[TestRunnerWKWebView resetInteractionCallbacks]):
108         (-[TestRunnerWKWebView didRecognizeTapOnWindow]):
109         (-[TestRunnerWKWebView windowTapRecognizedCallback]):
110         (-[TestRunnerWKWebView setWindowTapRecognizedCallback:]):
111         (-[TestRunnerWKWebView willMoveToWindow:]):
112         (-[TestRunnerWKWebView didMoveToWindow]):
113         (-[TestRunnerWKWebView gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:]):
114         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
115         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
116         (WTR::UIScriptControllerIOS::installTapGestureOnWindow):
117
118 2020-04-07  Alexey Shvayka  <shvaikalesh@gmail.com>
119
120         test262/Runner.pm ignores "async" flag
121         https://bugs.webkit.org/show_bug.cgi?id=210127
122
123         Reviewed by Ross Kirsling.
124
125         This change adds dereferencing for `$data->{flags}` array, making `grep` work as
126         expected. Other flags are correctly handled by `getScenarios` function, which
127         gets a dereferenced array as an argument.
128
129         * Scripts/test262/Runner.pm:
130         (runTest):
131
132 2020-04-07  Truitt Savell  <tsavell@apple.com>
133
134         Unreviewed, reverting r259446.
135
136         Broke Windows testing
137
138         Reverted changeset:
139
140         "[Windows] Ignore render tree dump based results on Windows"
141         https://bugs.webkit.org/show_bug.cgi?id=209897
142         https://trac.webkit.org/changeset/259446
143
144 2020-04-07  Aakash Jain  <aakash_jain@apple.com>
145
146         [ews] Add unit-test for CheckPatchRelevance build step
147         https://bugs.webkit.org/show_bug.cgi?id=210140
148
149         Reviewed by Jonathan Bedard.
150
151         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
152         (TestCheckPatchRelevance):
153         (TestCheckPatchRelevance.test_relevant_patch):
154         (TestCheckPatchRelevance.test_non_relevant_patch):
155
156 2020-04-07  Kate Cheney  <katherine_cheney@apple.com>
157
158         Return app-bound sessions for instances where WKAppBoundDomains is
159         empty
160         https://bugs.webkit.org/show_bug.cgi?id=210124
161         <rdar://problem/61276630>
162
163         Reviewed by Brent Fulgham.
164
165         Cleaned up tests to turn the flag on at the start of each In-App
166         Browser Privacy test.
167
168         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
169         (cleanUpInAppBrowserPrivacyTestSettings):
170         (initializeInAppBrowserPrivacyTestSettings):
171         (TEST):
172
173 2020-04-07  Timothy Hatcher  <timothy@apple.com>
174
175         WKUserScripts deferred from injection are not injected if -[WKWebView _notifyUserScripts] is called early.
176         https://bugs.webkit.org/show_bug.cgi?id=210131
177         rdar://problem/61368446
178
179         Reviewed by Brady Eidson.
180
181         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
182         (TEST):
183
184 2020-04-07  Ryosuke Niwa  <rniwa@webkit.org>
185
186         TextManipulationController fails to replace a paragraph that ends with a br
187         https://bugs.webkit.org/show_bug.cgi?id=210099
188
189         Reviewed by Wenson Hsieh.
190
191         Added regression tests.
192
193         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
194         (TextManipulation.CompleteTextManipulationReplaceMultipleSimpleParagraphsSeparatedByBR):
195         (TextManipulation.CompleteTextManipulationReplaceParagraphsSeparatedByWrappedBR):
196         (TextManipulation.CompleteTextManipulationFailWhenBRIsInserted):
197
198 2020-04-07  Adrian Perez de Castro  <aperez@igalia.com>
199
200         [GTK] CMake find module for GTK4
201         https://bugs.webkit.org/show_bug.cgi?id=210110
202
203         Reviewed by Don Olmstead.
204
205         * MiniBrowser/gtk/CMakeLists.txt: Use the GTK::GTK imported target.
206         * TestWebKitAPI/PlatformGTK.cmake: Ditto.
207         * TestWebKitAPI/glib/PlatformGTK.cmake: Ditto.
208         * WebKitTestRunner/PlatformGTK.cmake: Ditto.
209
210 2020-04-07  Youenn Fablet  <youenn@apple.com>
211
212         Reset mock capture devices between layout tests
213         https://bugs.webkit.org/show_bug.cgi?id=210098
214
215         Reviewed by Eric Carlson.
216
217         This fixes fast/mediastream/anonymize-device-name.html
218         failure since https://trac.webkit.org/changeset/259477/webkit.
219
220         * WebKitTestRunner/TestController.cpp:
221         (WTR::TestController::resetStateToConsistentValues):
222
223 2020-04-06  Peng Liu  <peng.liu6@apple.com>
224
225         REGRESSION (r259531?): [iOS] TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia is timing out
226         https://bugs.webkit.org/show_bug.cgi?id=210013
227
228         Reviewed by Daniel Bates.
229
230         Fix mistakes in the test and make it more reliable.
231
232         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
233         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
234         (-[ScrollingDoesNotPauseMediaDelegate handleEvent:]):
235         (TestWebKitAPI::TEST):
236         * TestWebKitAPI/Tests/WebKitLegacy/ios/one-video.html: Added.
237
238 2020-04-06  Don Olmstead  <don.olmstead@sony.com>
239
240         [CMake] Use WEBKIT_EXECUTABLE in DumpRenderTree
241         https://bugs.webkit.org/show_bug.cgi?id=210059
242
243         Reviewed by Fujii Hironori.
244
245         Modify CMake code to use WEBKIT_EXECUTABLE when creating DumpRenderTree.
246
247         * DumpRenderTree/CMakeLists.txt:
248         * DumpRenderTree/PlatformWin.cmake:
249
250 2020-04-06  Jonathan Bedard  <jbedard@apple.com>
251
252         ImageDiff: Don't build with ASan in automation
253         https://bugs.webkit.org/show_bug.cgi?id=210057
254         <rdar://problem/61234753>
255
256         Reviewed by David Kilzer.
257
258         * ImageDiff/cg/Configurations/ImageDiff.xcconfig: Disable ASan.
259
260 2020-04-06  Kenneth Russell  <kbr@chromium.org>
261
262         Update my committer status
263         https://bugs.webkit.org/show_bug.cgi?id=210072
264
265         Reviewed by Dean Jackson.
266
267         Update contributors.json to reflect that my lapsed committer
268         status was recently reinstated.
269
270         * Scripts/webkitpy/common/config/contributors.json:
271
272 2020-04-06  Ross Kirsling  <ross.kirsling@sony.com>
273
274         Update minimum ICU version to 60.2
275         https://bugs.webkit.org/show_bug.cgi?id=209694
276
277         Reviewed by Darin Adler.
278
279         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
280         Remove obsoleted compile-time version checks.
281
282         * DumpRenderTree/TestRunner.cpp:
283         (TestRunner::runUIScript):
284         * TestWebKitAPI/Tests/WebCore/LineBreaking.mm:
285         (breakingLocationsFromICU):
286         Manually convert between UChar and UniChar/unichar where needed.
287
288 2020-04-06  Rick Waldron  <waldron.rick@gmail.com> and Alexey Shvayka  <shvaikalesh@gmail.com>
289
290         Remove unnecessary Test262 harness file and implement $262.IsHTMLDDA
291         https://bugs.webkit.org/show_bug.cgi?id=187526
292
293         Reviewed by Darin Adler.
294
295         Removed file duplicates functionality of jsc.cpp's GlobalObject::finishCreation.
296
297         * Scripts/test262/Runner.pm:
298         * Scripts/test262/agent.js: Removed.
299
300 2020-04-06  Saam Barati  <sbarati@apple.com>
301
302         Implement 1GB of executable memory on arm64
303         https://bugs.webkit.org/show_bug.cgi?id=208490
304         <rdar://problem/60797127>
305
306         Reviewed by Keith Miller.
307
308         * Scripts/run-jsc-stress-tests:
309         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
310         (TestWebKitAPI::TEST_F):
311         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
312         (TestWebKitAPI::TEST_F):
313
314 2020-04-04  Darin Adler  <darin@apple.com>
315
316         Stop using live ranges in DocumentMarkerController
317         https://bugs.webkit.org/show_bug.cgi?id=209985
318
319         Reviewed by Antti Koivisto.
320
321         * TestWebKitAPI/Tests/WebCore/MarkedText.cpp:
322         (TestWebKitAPI::TEST): Update for change to DocumentMarker constructor.
323
324 2020-04-06  Jonathan Bedard  <jbedard@apple.com>
325
326         run-api-tests spew "setup_environ_for_server" in verbose mode
327         https://bugs.webkit.org/show_bug.cgi?id=210012
328         <rdar://problem/61306056>
329
330         Reviewed by Aakash Jain.
331
332         * Scripts/webkitpy/port/ios_simulator.py:
333         (IOSSimulatorPort.setup_environ_for_server): Do not log this function when called.
334
335 2020-04-06  Antoine Quint  <graouts@apple.com>
336
337         [macOS] TestWebKitAPI.WKUserContentController.UserStyleSheetAffectingOnlySpecificWebViewSharedConfiguration is a flaky timeout
338         https://bugs.webkit.org/show_bug.cgi?id=209934
339         <rdar://problem/61229832>
340
341         Reviewed by Antti Koivisto.
342
343         Fix a couple of tests which would use `-[WKWebView _test_waitForDidFinishNavigation]` in a way where the navigation may have finished before the method was called.
344
345         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
346         (TEST):
347
348 2020-04-05  Gus Caplan  <me@gus.host> and Ross Kirsling  <ross.kirsling@sony.com>
349
350         DLLLauncherMain print to console instead of opening window on fatal error
351         https://bugs.webkit.org/show_bug.cgi?id=206537
352
353         Reviewed by Fujii Hironori.
354
355         * win/DLLLauncher/DLLLauncherMain.cpp:
356         (fatalError):
357
358 2020-04-05  Don Olmstead  <don.olmstead@sony.com>
359
360         [CMake] Use WEBKIT_EXECUTABLE in MiniBrowser
361         https://bugs.webkit.org/show_bug.cgi?id=206894
362
363         Reviewed by Adrian Perez de Castro.
364
365         Modify CMake ports to use WEBKIT_EXECUTABLE when creating their respective
366         MiniBrowsers.
367
368         * MiniBrowser/gtk/CMakeLists.txt:
369         * MiniBrowser/win/CMakeLists.txt:
370         * MiniBrowser/wpe/CMakeLists.txt:
371
372 2020-04-05  Don Olmstead  <don.olmstead@sony.com>
373
374         [CMake] Add WebKit::WebKit target
375         https://bugs.webkit.org/show_bug.cgi?id=210033
376
377         Reviewed by Fujii Hironori.
378
379         Use the WebKit::WebKit target for MiniBrowser and TestWebKit. This removes
380         the need to have WebProcess and NetworkProcess as dependencies since they are
381         attached to the WebKit::WebKit target.
382
383         Remove references to WebKitFrameworkHeaders as it is now WebKit_CopyHeaders.
384         It is also a dependency of WebKit::WebKit so it does not need to be listed
385         as a dependency.
386
387         * MiniBrowser/win/CMakeLists.txt:
388         * TestWebKitAPI/CMakeLists.txt:
389         * TestWebKitAPI/PlatformPlayStation.cmake:
390         * TestWebKitAPI/PlatformWin.cmake:
391         * WebKitTestRunner/CMakeLists.txt:
392
393 2020-04-05  Daniel Bates  <dabates@apple.com>
394
395         RequestTextInputContext.Simple iframe sub-tests may sometimes fail
396         https://bugs.webkit.org/show_bug.cgi?id=210010
397         <rdar://problem/61303697>
398
399         Reviewed by Simon Fraser and Darin Adler.
400
401         Make the iframe sub tests wait until the DOM Load event has fired in the main frame.
402         When it fires this means that all immediate child frames (like the one added by these
403         sub tests) have fired their DOM Load event. This ensures deterministic results.
404
405         Also while I am here, extract out the iframe sub-tests into their own TEST() method
406         for testing and debugging convenience. I also fixed up -performAfterLoading so that
407         it wouldn't leak the user script string and made it work if called more than once in the
408         same TEST() by caching this script and only adding it to the user content controller
409         once. Moreover, removed duplication by writing it in terms of -performAfterReceivingMessage.
410
411         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
412         (TEST):
413         (webViewLoadHTMLStringAndWaitForDOMLoadEvent): Helper function to load an HTML string
414         into a web view and wait until a DOM Load event is fired at the main frame.
415         * TestWebKitAPI/cocoa/TestWKWebView.h:
416         * TestWebKitAPI/cocoa/TestWKWebView.mm:
417         (-[TestWKWebView performAfterLoading:]): Modernized and simplified. Modified user script
418         to use addEventListener() instead of onload as the latter overrides any existing load handler.
419         This user script is also added only to the main frame since all existing callers just
420         want to know that all main frame and immediate child frames loaded. Also listen for the load
421         event during the capture phase, which is a tiny bit faster to receive, instead of the bubbling
422         phase. See second paragraph above for more details on the changes I made to this function.
423
424
425 2020-04-04  Wenson Hsieh  <wenson_hsieh@apple.com>
426
427         Add a fourth round of logging to help diagnose <webkit.org/b/209685>
428         https://bugs.webkit.org/show_bug.cgi?id=210011
429
430         Reviewed by Darin Adler.
431
432         Remove all logging previously added to DragAndDropSimulator.
433
434         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
435         (-[DragAndDropSimulator _webView:adjustedDataInteractionItemProvidersForItemProvider:representingObjects:additionalData:]):
436
437 2020-04-04  Chris Dumez  <cdumez@apple.com>
438
439         [iOS] Simplify ProcessAssertion class in preparation for switch to RunningBoard
440         https://bugs.webkit.org/show_bug.cgi?id=209984
441         <rdar://problem/61273941>
442
443         Reviewed by Darin Adler.
444
445         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
446
447 2020-04-04  Wenson Hsieh  <wenson_hsieh@apple.com>
448
449         Add even more logging to try and diagnose <webkit.org/b/209685>
450         https://bugs.webkit.org/show_bug.cgi?id=210008
451
452         Reviewed by Tim Horton.
453
454         Replace old logging with new logging (in different places).
455
456         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
457         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
458         (-[DragAndDropSimulator _advanceProgress]):
459         (-[DragAndDropSimulator _webView:adjustedDataInteractionItemProvidersForItemProvider:representingObjects:additionalData:]):
460
461         Rule out the possibility that the WebKit client (in this case, the drag and drop simulator) is overriding the
462         list of drag items by logging the given NSItemProvider that will be used to start the drag.
463
464 2020-04-04  Peng Liu  <peng.liu6@apple.com>
465
466         REGRESSION (r259095): ASSERTION FAILED: m_videoFullscreenMode != VideoFullscreenModeNone seen with TestWebKitAPI.WebKitLegacy.AudioSessionCategoryIOS
467         https://bugs.webkit.org/show_bug.cgi?id=209680
468
469         Reviewed by Jer Noble.
470
471         Add an API test for the video fullscreen support of WebKitLegacy on iOS.
472
473         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
474         * TestWebKitAPI/Tests/WebKitLegacy/ios/PreemptVideoFullscreen.mm: Added.
475         (-[VideoFullscreenStressUIWebViewDelegate webViewDidFinishLoad:]):
476         (-[VideoFullscreenStressUIWebViewDelegate uiWebView:didCommitLoadForFrame:]):
477         (-[VideoFullscreenStressUIWebViewDelegate handleEvent:]):
478         (TestWebKitAPI::TEST):
479         * TestWebKitAPI/Tests/WebKitLegacy/ios/two-videos.html: Added.
480
481 2020-04-03  Alex Christensen  <achristensen@webkit.org>
482
483         Add SPI to make WKUserScripts wait for a notification
484         https://bugs.webkit.org/show_bug.cgi?id=209845
485         <rdar://problem/60342299>
486
487         Reviewed by Chris Dumez.
488
489         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
490         (TEST):
491
492 2020-04-03  Kate Cheney  <katherine_cheney@apple.com>
493
494         Prevent non app-bound domain cookies from being read or set using API calls
495         https://bugs.webkit.org/show_bug.cgi?id=209926
496         <rdar://problem/61071428>
497
498         Reviewed by Brady Eidson.
499
500         Added 3 new API tests to test that non app-bound cookies are not being
501         set or returned via API calls. Also added a function to reset state
502         between tests for internal debugging.
503
504         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
505         (setUpCookieTest):
506         (TEST):
507
508 2020-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
509
510         Add more logging to help diagnose <webkit.org/b/209685>
511         https://bugs.webkit.org/show_bug.cgi?id=209988
512
513         Reviewed by Timothy Hatcher.
514
515         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
516
517         Fix a few stray style mistakes (unnecessary `.get()`s).
518
519         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
520         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
521         (-[DragAndDropSimulator _advanceProgress]):
522
523 2020-04-03  Truitt Savell  <tsavell@apple.com>
524
525         Unreviewed, reverting r259440.
526
527         Introduced 2 failing tests on Mac and iOS
528
529         Reverted changeset:
530
531         "Add SPI to configure WebsiteDataStores with a URL for
532         standalone web applications and use it to disable first-party
533         website data removal in ITP"
534         https://bugs.webkit.org/show_bug.cgi?id=209634
535         https://trac.webkit.org/changeset/259440
536
537 2020-04-03  Kate Cheney  <katherine_cheney@apple.com>
538
539         Remove _setIsNavigatingToAppBoundDomain testing SPI
540         https://bugs.webkit.org/show_bug.cgi?id=209973
541         <rdar://problem/61264350>
542
543         Reviewed by David Kilzer.
544
545         This SPI is no longer needed to set a webView as navigating to an
546         app-bound domain. We can now load a local file instead.
547
548         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
549         (TEST):
550         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-local-file.html:
551
552 2020-04-03  David Kilzer  <ddkilzer@apple.com>
553
554         [Xcode] Replace ASAN_OTHER_CFLAGS and ASAN_OTHER_CPLUSPLUSFLAGS with $(inherited)
555         <https://webkit.org/b/209963>
556         <rdar://problem/61257504>
557
558         Reviewed by Alexey Proskuryakov.
559
560         * asan/asan.xcconfig:
561         - Use $(inherited) to get rid of custom ASAN_OTHER_CFLAGS and
562           ASAN_OTHER_CPLUSPLUSFLAGS.  Note that ASAN_OTHER_LDFLAGS had
563           been previously removed in r179312, but not in the other
564           *.xcconfig files.
565
566         * ContentExtensionTester/Configurations/Base.xcconfig:
567         * DumpRenderTree/mac/Configurations/Base.xcconfig:
568         * ImageDiff/cg/Configurations/Base.xcconfig:
569         * MiniBrowser/Configurations/Base.xcconfig:
570         * MobileMiniBrowser/Configurations/Base.xcconfig:
571         * TestWebKitAPI/Configurations/Base.xcconfig:
572         * WebEditingTester/Configurations/Base.xcconfig:
573         * WebKitLauncher/Configurations/Base.xcconfig:
574         * WebKitTestRunner/Configurations/Base.xcconfig:
575         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
576         - Remove ASAN_OTHER_CFLAGS, ASAN_OTHER_CPLUSPLUSFLAGS and
577           ASAN_OTHER_LDFLAGS.
578
579 2020-04-03  Aakash Jain  <aakash_jain@apple.com>
580
581         [ews] Improve error message when patch fails to apply to trunk
582         https://bugs.webkit.org/show_bug.cgi?id=209965
583
584         Reviewed by Jonathan Bedard.
585
586         * BuildSlaveSupport/ews-build/steps.py:
587         (ApplyPatch.getResultSummary): Improved error message.
588         (ApplyPatch.evaluateCommand): Ditto.
589         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
590
591 2020-04-03  Sihui Liu  <sihui_liu@apple.com>
592
593         ASSERTION FAILED: m_delegate in IDBConnectionToClient::identifier()
594         https://bugs.webkit.org/show_bug.cgi?id=209891
595         <rdar://problem/59293891>
596
597         Reviewed by Geoffrey Garen.
598
599         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
600         * TestWebKitAPI/Tests/WebKitCocoa/KillWebProcessWithOpenConnection-1.html: Added.
601         * TestWebKitAPI/Tests/WebKitCocoa/KillWebProcessWithOpenConnection-2.html: Added.
602         * TestWebKitAPI/Tests/WebKitCocoa/WebProcessKillIDBCleanup.mm:
603         (TEST):
604
605 2020-04-03  Aakash Jain  <aakash_jain@apple.com>
606
607         [ews] Display list of test failures along-with the layout-test build step
608         https://bugs.webkit.org/show_bug.cgi?id=209912
609
610         Reviewed by Jonathan Bedard.
611
612         * BuildSlaveSupport/ews-build/steps.py:
613         (RunWebKitTests._addToLog):
614         (RunWebKitTests.commandComplete): Add list of test failures to 'test-failures' log which is displayed in UI.
615         (ReRunWebKitTests.commandComplete): Ditto.
616         (RunWebKitTestsWithoutPatch.commandComplete): Ditto.
617
618 2020-04-03  Philippe Normand  <pnormand@igalia.com>
619
620         REGRESSION(r259453): [Flatpak SDK] Build directory no longer bind-mounted when running tests
621         https://bugs.webkit.org/show_bug.cgi?id=209960
622
623         Reviewed by Carlos Alberto Lopez Perez.
624
625         The bind-mount is always needed, not only when running build-webkit.
626
627         * flatpak/flatpakutils.py:
628         (WebkitFlatpak.run_in_sandbox):
629
630 2020-04-03  Diego Pino Garcia  <dpino@igalia.com>
631
632         [Flatpak SDK] Create platform/Release directory only when build-webkit is called
633         https://bugs.webkit.org/show_bug.cgi?id=209954
634
635         Reviewed by Philippe Normand.
636
637         * flatpak/flatpakutils.py:
638         (WebkitFlatpak.clean_args): Remove creation of self.build_path.
639         (WebkitFlatpak.run_in_sandbox): Create self.build_path if command is
640         build-webkit.
641
642 2020-04-03  Philippe Normand  <pnormand@igalia.com>
643
644         [Flatpak SDK] build-webkit --flatpak-cmakeargs option is ignored
645         https://bugs.webkit.org/show_bug.cgi?id=209648
646
647         Reviewed by Žan Doberšek.
648
649         This patch removes redundant options from webkit-flatpak,
650         correctly handles the cmakeargs option and reduces the amount of
651         `flatpak list` calls performed.
652
653         * flatpak/flatpakutils.py:
654         (check_flatpak):
655         (FlatpakPackages.__init__):
656         (FlatpakPackage.is_installed):
657         (WebkitFlatpak.load_from_args):
658         (WebkitFlatpak.__init__):
659         (WebkitFlatpak.clean_args):
660         (WebkitFlatpak.run_in_sandbox):
661         (WebkitFlatpak.main):
662         (WebkitFlatpak.setup_dev_env):
663         (WebkitFlatpak.run_gdb):
664
665 2020-04-03  Diego Pino Garcia  <dpino@igalia.com>
666
667         [Flatpak SDK] Call setup_icecc only if use_icecream is defined
668         https://bugs.webkit.org/show_bug.cgi?id=209956
669
670         Reviewed by Philippe Normand.
671
672         * flatpak/flatpakutils.py:
673         (WebkitFlatpak.setup_dev_env):
674
675 2020-04-03  Antti Koivisto  <antti@apple.com>
676
677         [Windows] Ignore render tree dump based results on Windows
678         https://bugs.webkit.org/show_bug.cgi?id=209897
679
680         Reviewed by Darin Adler.
681
682         Render tree dumps are port specific and so difficult to maintain. They are mostly very old and
683         have been superseded by more modern ref and text dump tests. They rarely reveal any port specific bugs.
684
685         This patch adds --ignore-render-tree-dump-results option to run-webkit-tests and enables it by
686         default on Apple Windows port.
687
688         With the option set the render tree dump tests are still run (so crashes are detected) but their
689         output is treated as if it always passed. Missing results are not written to disk.
690
691         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
692         (SingleTestRunner._compare_text):
693         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
694         (parse_args):
695         (_set_up_derived_options):
696
697 2020-04-02  James Savage  <james.savage@apple.com>
698
699         Add myself, as a committer, to contributors.json.
700         https://bugs.webkit.org/show_bug.cgi?id=209952.
701
702         * Scripts/webkitpy/common/config/contributors.json:
703
704 2020-04-02  James Savage  <james.savage@apple.com>
705
706         Add myself to contributors.json.
707         https://bugs.webkit.org/show_bug.cgi?id=209952.
708
709         * Scripts/webkitpy/common/config/contributors.json:
710
711 2020-04-02  John Wilander  <wilander@apple.com>
712
713         Add SPI to configure WebsiteDataStores with a URL for standalone web applications and use it to disable first-party website data removal in ITP
714         https://bugs.webkit.org/show_bug.cgi?id=209634
715         <rdar://problem/60943970>
716
717         Reviewed by Alex Christensen.
718
719         Added a new test option called standaloneWebApplicationURL so that layout tests can
720         configure the website data store accordingly. Picking it up and using it requires
721         creating a new website data store with a configuration that has the standalone web
722         application URL.
723
724         * WebKitTestRunner/TestController.cpp:
725         (WTR::parseStringTestHeaderValueAsURL):
726         (WTR::updateTestOptionsFromTestHeader):
727         * WebKitTestRunner/TestOptions.h:
728         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
729         (WTR::TestController::platformCreateWebView):
730
731 2020-04-02  David Kilzer  <ddkilzer@apple.com>
732
733         REGRESSION (r234685): Leak of CALayer in createCoreAnimationLayer() in PluginObjectMac.mm
734         <https://webkit.org/b/209915>
735
736         Reviewed by Darin Adler.
737
738         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
739         (createCoreAnimationLayer): Use RetainPtr<> to fix leak.
740
741 2020-04-02  David Kilzer  <ddkilzer@apple.com>
742
743         API::PageConfiguration may have conflicting preference values between WebPreferences and WebPreferencesStore::ValueMap instance variables
744         <https://webkit.org/b/209678>
745         <rdar://problem/60981271>
746
747         Reviewed by Brent Fulgham.
748
749         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
750         (TestWebKitAPI::TEST):
751         - Fix WKView constructor to pass a valid WKPageGroupRef.
752
753         * WebKitTestRunner/TestController.cpp:
754         (WTR::updateTestOptionsFromTestHeader):
755         * WebKitTestRunner/TestOptions.h:
756         (WTR::TestOptions::hasSameInitializationOptions const):
757         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
758         (WTR::TestController::platformCreateWebView):
759         - Remove support for custom "enableUndoManagerAPI" setting since
760           layout tests should use "internal:UndoManagerAPIEnabled"
761           instead.
762
763 2020-04-02  Alex Christensen  <achristensen@webkit.org>
764
765         Add SPI to restrict loading to main resources or non-network loads
766         https://bugs.webkit.org/show_bug.cgi?id=209893
767
768         Reviewed by Tim Horton.
769
770         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
771         * TestWebKitAPI/cocoa/HTTPServer.h:
772         (TestWebKitAPI::HTTPServer::totalRequests const):
773         * TestWebKitAPI/cocoa/HTTPServer.mm:
774         (TestWebKitAPI::HTTPServer::respondToRequests):
775
776 2020-04-02  Kate Cheney  <katherine_cheney@apple.com>
777
778         Add additional WKAppBoundDomains to TestWebKitAPI's expectations after initializing eTLD+1 by default
779         https://bugs.webkit.org/show_bug.cgi?id=209889
780         <rdar://problem/61184539>
781
782         Reviewed by Brent Fulgham.
783
784         Additional domains will now be included in TestWebKitAPI's
785         WKAppBoundDomains list after
786         https://bugs.webkit.org/show_bug.cgi?id=209839 (Allow WKAppBoundDomains
787         to be initialized with eTLD+1 only (no protocol)).
788
789         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
790         (TEST):
791
792 2020-04-01  Per Arne Vollan  <pvollan@apple.com>
793
794         [Cocoa] UTI from MIME type cache can be removed after r258915
795         https://bugs.webkit.org/show_bug.cgi?id=209787
796
797         Unreviewed rollout of r257828.
798
799         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
800         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Removed.
801
802 2020-04-01  Jonathan Bedard  <jbedard@apple.com>
803
804         run-javascriptcore-tests: runJSCStressTests shouldn't exit the program
805         https://bugs.webkit.org/show_bug.cgi?id=209887
806
807         Reviewed by Darin Adler.
808
809         * Scripts/run-javascriptcore-tests:
810         (runJSCStressTests): Exit the function, not the program.
811
812 2020-04-01  Chris Dumez  <cdumez@apple.com>
813
814         Regression(r257963) didFailProvisionalNavigation delegate no longer gets called when cancelling a cross-site provisional navigation
815         https://bugs.webkit.org/show_bug.cgi?id=209873
816         <rdar://problem/61132068>
817
818         Reviewed by Alex Christensen.
819
820         Add API test coverage.
821
822         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
823
824 2020-04-01  Don Olmstead  <don.olmstead@sony.com>
825
826         [PlayStation] Use OBJECT libraries for WebCore and PAL
827         https://bugs.webkit.org/show_bug.cgi?id=209835
828
829         Reviewed by Ross Kirsling.
830
831         Use the object libraries when compiling TestWebCore.
832
833         * TestWebKitAPI/PlatformPlayStation.cmake:
834
835 2020-04-01  Jack Lee  <shihchieh_lee@apple.com>
836
837         Unreviewed, add new committer to contributors.json
838
839         * Scripts/webkitpy/common/config/contributors.json:
840
841 2020-04-01  Philippe Normand  <pnormand@igalia.com>
842
843         [Flatpak SDK] Migration to version 0.2
844         https://bugs.webkit.org/show_bug.cgi?id=209850
845
846         Reviewed by Carlos Alberto Lopez Perez.
847
848         Version 0.2 of the SDK is now built with Buildstream instead of
849         flatpak-builder. With this new version it will be easier to add
850         new dependencies and hack on dependencies shipped by the SDK.
851
852         Sadly I haven't found a nice way to upgrade smoothly without
853         removing the UserFlatpak directory. In theory this shouldn't be
854         needed but then old SDK branches would accumulate there, wasting
855         disk-space.
856
857         * flatpak/flatpakutils.py:
858         (Console):
859         (Console.colored_message):
860         (Console.error_message):
861         (Console.warning_message):
862         (check_flatpak):
863         (FlatpakObject.flatpak):
864         (FlatpakRepo.__init__):
865         (FlatpakRepo):
866         (FlatpakRepo.is_app_installed):
867         (FlatpakPackage.__init__):
868         (FlatpakPackage.install):
869         (FlatpakPackage.update):
870         (WebkitFlatpak.__init__):
871         (WebkitFlatpak.clean_args):
872         (WebkitFlatpak._reset_repository):
873         (WebkitFlatpak.setup_gstbuild):
874         (WebkitFlatpak.main):
875         (WebkitFlatpak.run):
876         (WebkitFlatpak.setup_dev_env):
877         (WebkitFlatpak._get_packages):
878
879 2020-04-01  Carlos Garcia Campos  <cgarcia@igalia.com>
880
881         [GTK] MiniBrowser: valgrind claims 'Invalid write of size 8' on close
882         https://bugs.webkit.org/show_bug.cgi?id=209471
883
884         Reviewed by Adrian Perez de Castro.
885
886         This is because we need to remove the weak pointer added in child windows to their parent.
887
888         * MiniBrowser/gtk/BrowserWindow.c:
889         (browserWindowDispose): Remove the parentWindow weak ref.
890         (browser_window_class_init): Add dispose.
891
892 2020-03-31  Kate Cheney  <katherine_cheney@apple.com>
893
894         Requests for messageHandlers() in the DOMWindow should be ignored for non-app-bound navigations
895         https://bugs.webkit.org/show_bug.cgi?id=209836
896         <rdar://problem/61071607>
897
898         Reviewed by Brent Fulgham.
899
900         Most of this patch is changes to the tests, which formerly relied
901         on message handlers to test script injection protections. I rewrote
902         three tests to remove the use of message handlers which were used to
903         confirm normal script injection behavior before enabling In-App
904         Browser Privacy. Since normal script injection behavior is tested in
905         WKUserContentController.mm already it is unecessary to test here.
906
907         I removed one test, IgnoreAppBoundDomainsAcceptsUserScripts, which
908         fully relied on message handler use and could not be tested without
909         somehow disabling this feature.
910
911         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
912         (TEST):
913         (-[TestInAppBrowserScriptMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
914         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-local-file.html:
915         Add a message handler to this page to demonstrate that message
916         handlers work for app-bound navigations (file:// protocol is always
917         app-bound).
918
919 2020-03-31  Alex Christensen  <achristensen@webkit.org>
920
921         Send correct UserContentControllerIdentifier after using SPI WKWebpagePreferences._userContentController
922         https://bugs.webkit.org/show_bug.cgi?id=209833
923
924         Reviewed by Tim Hatcher.
925
926         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
927
928 2020-03-31  Brent Fulgham  <bfulgham@apple.com>
929
930         Allow WKAppBoundDomains to be initialized with eTLD+1 only (no protocol)
931         https://bugs.webkit.org/show_bug.cgi?id=209839
932         <rdar://problem/61129400>
933
934         Reviewed by Darin Adler.
935
936         * TestWebKitAPI/Info.plist:
937
938 2020-03-31  Alex Christensen  <achristensen@webkit.org>
939
940         Add SPI WKWebpagePreferences._userContentController
941         https://bugs.webkit.org/show_bug.cgi?id=209795
942
943         Reviewed by Tim Hatcher.
944
945         * TestWebKitAPI/SourcesCocoa.txt:
946         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
947         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
948         (-[TestUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Deleted.
949         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
950         * TestWebKitAPI/cocoa/TestUIDelegate.h: Added.
951         * TestWebKitAPI/cocoa/TestUIDelegate.mm: Added.
952         (-[TestUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
953         (-[TestUIDelegate waitForAlert]):
954
955 2020-03-31  Aakash Jain  <aakash_jain@apple.com>
956
957         Delete code for security EWS from old EWS (follow-up fix)
958         https://bugs.webkit.org/show_bug.cgi?id=209683
959
960         Revert 233220.
961
962         Unreviewed follow-up fix.
963
964         * Scripts/webkitpy/common/net/statusserver_mock.py:
965         * Scripts/webkitpy/tool/commands/queues.py:
966
967 2020-03-30  Peng Liu  <peng.liu6@apple.com>
968
969         PiP support of MiniBrowser is broken
970         https://bugs.webkit.org/show_bug.cgi?id=209749
971
972         Reviewed by Jer Noble.
973
974         Add com.apple.PIPAgent to the mach-lookup.global.name temporary exception entitlement.
975         * MiniBrowser/MiniBrowser.entitlements:
976         Fix an issue that the intended preferences are overwritten by default values
977         and enable the PiP support.
978         * MiniBrowser/mac/AppDelegate.m:
979         (-[BrowserAppDelegate defaultConfiguration]):
980
981 2020-03-30  Zhifei Fang  <zhifei_fang@apple.com>
982
983         [results.webkit.org: Timeline]: Left side of the timeline scale is usually bigger than the right        
984
985         https://bugs.webkit.org/show_bug.cgi?id=209569
986
987         Reviewed by Jonathan Bedard.
988
989         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
990
991 2020-03-30  Frank Yang  <guowei_yang@apple.com>
992
993         Update my name in contributors.json
994         https://bugs.webkit.org/show_bug.cgi?id=209751
995         
996         Added myself to contributors.json. Also some changes to other
997         people's information are made after running the canonicalize script.
998         
999         Reviewed by Myles C. Maxfield.
1000
1001         * Scripts/webkitpy/common/config/contributors.json:
1002
1003 2020-03-30  Aakash Jain  <aakash_jain@apple.com>
1004
1005         Delete code for security EWS from old EWS
1006         https://bugs.webkit.org/show_bug.cgi?id=209683
1007
1008         Reverted r232979, r233061, r233190, r233219, r233276 and r233288.
1009
1010         Rubber-stamped by Jonathan Bedard.
1011
1012         * QueueStatusServer/handlers/releasepatch.py: Reverted changes for security EWS in old EWS.
1013         * QueueStatusServer/main.py:
1014         * QueueStatusServer/config/authorization.py: Removed.
1015         * QueueStatusServer/handlers/fetchattachment.py: Removed.
1016         * QueueStatusServer/handlers/uploadattachment.py: Removed.
1017         * QueueStatusServer/model/attachmentdata.py: Removed.
1018         * QueueStatusServer/templates/uploadattachment.html: Removed.
1019         * Scripts/webkitpy/common/net/bugzilla/constants.py: Removed.
1020         * Scripts/webkitpy/common/net/bugzilla/attachment.py:
1021         * Scripts/webkitpy/common/net/bugzilla/attachment_unittest.py:
1022         * Scripts/webkitpy/common/net/bugzilla/bug.py:
1023         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1024         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1025         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1026         * Scripts/webkitpy/common/net/statusserver.py:
1027         * Scripts/webkitpy/common/net/statusserver_mock.py:
1028         * Scripts/webkitpy/tool/bot/feeders.py:
1029         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1030         * Scripts/webkitpy/tool/commands/download.py:
1031         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1032         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1033         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1034         * Scripts/webkitpy/tool/commands/queues.py:
1035         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1036         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1037         * Scripts/webkitpy/tool/main.py:
1038         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
1039
1040 2020-03-30  Michael Catanzaro  <mcatanzaro@gnome.org>
1041
1042         Add user agent quirk for Red Hat Bugzilla
1043         https://bugs.webkit.org/show_bug.cgi?id=209484
1044
1045         Reviewed by Adrian Perez de Castro.
1046
1047         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1048         (TestWebKitAPI::TEST):
1049
1050 2020-03-30  Per Arne Vollan  <pvollan@apple.com>
1051
1052         [Cocoa] Sleep disabling should be performed in the UI process
1053         https://bugs.webkit.org/show_bug.cgi?id=209676
1054
1055         Reviewed by Darin Adler.
1056
1057         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1058         * TestWebKitAPI/Tests/WebKit/SleepDisabler.mm: Added.
1059         (TEST):
1060
1061 2020-03-30  Per Arne Vollan  <pvollan@apple.com>
1062
1063         [macOS] REGRESSION(r258949) API test failures
1064         https://bugs.webkit.org/show_bug.cgi?id=209702
1065
1066         Reviewed by Darin Adler.
1067
1068         After r258949, the preference observer is started when the app is activated, but since the app running
1069         API tests is not being activated, the preference observer needs to be manually instantiated in each test.
1070
1071         * TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm:
1072         (-[WKTestPreferenceObserver preferenceDidChange:key:encodedValue:]):
1073         (TEST):
1074
1075 2020-03-28  Alex Christensen  <achristensen@webkit.org>
1076
1077         REGRESSION(r257963) UI process crashes when setting navigation delegate inside navigation delegate callbacks
1078         https://bugs.webkit.org/show_bug.cgi?id=209705
1079         <rdar://problem/60814765>
1080
1081         Reviewed by Darin Adler.
1082
1083         * TestWebKitAPI/Tests/WebKitCocoa/AsyncPolicyForNavigationResponse.mm:
1084         (-[TestAsyncNavigationDelegate webView:didFailNavigation:withError:]):
1085         (-[TestAsyncNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
1086
1087 2020-03-28  Alex Christensen  <achristensen@webkit.org>
1088
1089         Deprecate injected bundle page group SPI
1090         https://bugs.webkit.org/show_bug.cgi?id=209687
1091
1092         Reviewed by Timothy Hatcher.
1093
1094         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
1095         (TestWebKitAPI::DOMWindowExtensionBasic::didCreatePage):
1096         (TestWebKitAPI::DOMWindowExtensionBasic::initialize): Deleted.
1097         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
1098         (TestWebKitAPI::DOMWindowExtensionNoCache::didCreatePage):
1099         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize): Deleted.
1100         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
1101         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::didCreatePage):
1102         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize): Deleted.
1103         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
1104         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize): Deleted.
1105         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize): Deleted.
1106         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
1107         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::didCreatePage):
1108         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize): Deleted.
1109
1110 2020-03-28  ChangSeok Oh  <changseok@webkit.org>
1111
1112         [GTK] No libsystemd-devel for DNF
1113         https://bugs.webkit.org/show_bug.cgi?id=209697
1114
1115         Reviewed by Philippe Normand.
1116
1117         Replace libsystemd-devel to systemd-devel for DNF.
1118
1119         * gtk/install-dependencies:
1120         * wpe/install-dependencies:
1121
1122 2020-03-27  Philippe Normand  <pnormand@igalia.com>
1123
1124         [Flatpak SDK] Allow passing gst-build Meson options
1125         https://bugs.webkit.org/show_bug.cgi?id=209608
1126
1127         Reviewed by Žan Doberšek.
1128
1129         Add support for the GST_BUILD_ARGS env var storing gst-build Meson options.
1130
1131         * flatpak/flatpakutils.py:
1132         (WebkitFlatpak.setup_gstbuild):
1133
1134 2020-03-27  Philippe Normand  <pnormand@igalia.com>
1135
1136         [Flatpak SDK] Warn when gst-build support was requested but GST_BUILD_PATH is not set
1137         https://bugs.webkit.org/show_bug.cgi?id=209599
1138
1139         Reviewed by Žan Doberšek.
1140
1141         * flatpak/flatpakutils.py:
1142         (WebkitFlatpak.setup_gstbuild):
1143         (WebkitFlatpak.setup_dev_env):
1144
1145 2020-03-26  Chris Dumez  <cdumez@apple.com>
1146
1147         REGRESSION: Unable to show Web Inspector on empty tabs in Safari
1148         https://bugs.webkit.org/show_bug.cgi?id=209639
1149         <rdar://problem/60937524>
1150
1151         Reviewed by Darin Adler.
1152
1153         Add API test coverage.
1154
1155         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1156
1157 2020-03-26  Fujii Hironori  <Hironori.Fujii@sony.com>
1158
1159         [Win] lld-link: error: /manifestdependency: is not allowed in .drectve
1160         https://bugs.webkit.org/show_bug.cgi?id=204831
1161
1162         Reviewed by Ross Kirsling.
1163
1164         * TestWebKitAPI/win/main.cpp:
1165         * win/DLLLauncher/DLLLauncherMain.cpp:
1166
1167 2020-03-24  Ryan Haddad  <ryanhaddad@apple.com>
1168
1169         Unreviewed test gardening for iOS API tests.
1170
1171         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
1172         (TEST):
1173         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1174         (TestWebKitAPI::TEST):
1175
1176 2020-03-26  Daniel Bates  <dabates@apple.com>
1177
1178         WebPage::selectPositionAtPoint() does not focus an element in a non-focused frame
1179         https://bugs.webkit.org/show_bug.cgi?id=209559
1180         <rdar://problem/60887055>
1181
1182         Reviewed by Wenson Hsieh.
1183
1184         Add a test.
1185
1186         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
1187         (TEST):
1188
1189 2020-03-26  Fujii Hironori  <Hironori.Fujii@sony.com>
1190
1191         WebKitTestRunner should enable ResourceLoadStatistics also for non-Cocoa ports
1192         https://bugs.webkit.org/show_bug.cgi?id=209410
1193
1194         Reviewed by Youenn Fablet.
1195
1196         Cocoa WebKitTestRunner always enables ResourceLoadStatistics.
1197         Other ports should do so.
1198
1199         * WebKitTestRunner/TestController.cpp:
1200         (WTR::TestController::platformAdjustContext): Enable ResourceLoadStatistics
1201         by using WKWebsiteDataStoreSetResourceLoadStatisticsEnabled.
1202
1203 2020-03-26  Kate Cheney  <katherine_cheney@apple.com>
1204
1205         Guard AppBound domain protections with PLATFORM(iOS_FAMILY)
1206         https://bugs.webkit.org/show_bug.cgi?id=209615
1207         <rdar://problem/60931014>
1208
1209         Reviewed by Darin Adler.
1210
1211         Tests should only be run on iOS.
1212
1213         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
1214
1215 2020-03-26  Aakash Jain  <aakash_jain@apple.com>
1216
1217         [ews] status-bubble for tester queues should point to tester queue while waiting in queue (Follow-up fix)
1218         https://bugs.webkit.org/show_bug.cgi?id=209598
1219
1220         Unreviewed follow-up fix.
1221
1222         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1223         (StatusBubble._build_bubble): Display the tester name in tester's status-bubble hover-over message.
1224
1225 2020-03-26  Aakash Jain  <aakash_jain@apple.com>
1226
1227         [ews] status-bubble for tester queues should point to tester queue while waiting in queue
1228         https://bugs.webkit.org/show_bug.cgi?id=209598
1229
1230         Reviewed by Jonathan Bedard.
1231
1232         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1233         (StatusBubble._build_bubble):
1234
1235 2020-03-26  Chris Fleizach  <cfleizach@apple.com>
1236
1237         AX: WKTR: Don't update isolated tree mode behavior if not required
1238         https://bugs.webkit.org/show_bug.cgi?id=209555
1239         <rdar://problem/60885094>
1240
1241         Reviewed by Darin Adler.
1242
1243         If the isolated tree mode has not changed, then we should not poke at the mechanisms for turning it on/off.
1244         This might have the side effect of turning on accessibility unexpectedly.
1245
1246         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1247         (WTR::AccessibilityController::setAccessibilityIsolatedTreeMode):
1248
1249 2020-03-26  Philippe Normand  <pnormand@igalia.com>
1250
1251         [Flatpak SDK] Pass all the arguments of build-webkit to webkit-flatpak
1252         https://bugs.webkit.org/show_bug.cgi?id=209558
1253
1254         Reviewed by Žan Doberšek.
1255
1256         When using flatpak some of the arguments we pass to build-webkit
1257         are not meant to be used by that script but by webkit-flatpak. However we are
1258         not passing all of them to webkit-flatpak but just the configuration ones
1259         (port, release/debug...). This means that all the arguments that configure the
1260         behaviour of webkit-flatpak are lost.
1261
1262         * Scripts/webkitdirs.pm:
1263         (runInFlatpak): Filter-out Flatpak SDK-specific arguments to a
1264         separate array, passed to webkit-flatpak.
1265
1266 2020-03-26  Commit Queue  <commit-queue@webkit.org>
1267
1268         Unreviewed, reverting r259035.
1269         https://bugs.webkit.org/show_bug.cgi?id=209597
1270
1271         broke windows layout-tests (Requested by aakashjain on
1272         #webkit).
1273
1274         Reverted changeset:
1275
1276         "[Win] lld-link: error: /manifestdependency: is not allowed in
1277         .drectve"
1278         https://bugs.webkit.org/show_bug.cgi?id=204831
1279         https://trac.webkit.org/changeset/259035
1280
1281 2020-03-26  Philippe Normand  <pnormand@igalia.com>
1282
1283         [Flatpak SDK] update-webkitgtk-libs fails
1284         https://bugs.webkit.org/show_bug.cgi?id=209546
1285
1286         Reviewed by Žan Doberšek.
1287
1288         Simplify the code a bit, add a `--assumeyes` argument to the
1289         `flatpak update` command to make it non-interactive and improve
1290         error handling/reporting a bit as well.
1291
1292         * flatpak/flatpakutils.py:
1293         (FlatpakObject.flatpak):
1294         (WebkitFlatpak.main):
1295         (WebkitFlatpak.run):
1296         (WebkitFlatpak.install_all):
1297         (WebkitFlatpak.update_all): Deleted.
1298
1299 2020-03-26  Philippe Normand  <pnormand@igalia.com>
1300
1301         [Flatpak SDK] Crash post-mortem debugging is broken
1302         https://bugs.webkit.org/show_bug.cgi?id=209537
1303
1304         Reviewed by Žan Doberšek.
1305
1306         webkit-flatpak --gdb now properly launches gdb to inspect the last
1307         crash reported to coredumpctl. The -m argument can be used to
1308         select another crash dump.
1309
1310         * flatpak/flatpakutils.py:
1311         (WebkitFlatpak.clean_args):
1312         (WebkitFlatpak.run_in_sandbox):
1313         (WebkitFlatpak.run_gdb):
1314
1315 2020-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1316
1317         [Win] lld-link: error: /manifestdependency: is not allowed in .drectve
1318         https://bugs.webkit.org/show_bug.cgi?id=204831
1319
1320         Reviewed by Ross Kirsling.
1321
1322         * TestWebKitAPI/win/main.cpp:
1323         * win/DLLLauncher/DLLLauncherMain.cpp:
1324
1325 2020-03-25  Alexey Shvayka  <shvaikalesh@gmail.com>
1326
1327         Invalid numeric and named references should be early syntax errors
1328         https://bugs.webkit.org/show_bug.cgi?id=178175
1329
1330         Reviewed by Ross Kirsling.
1331
1332         Removes FIXME as YarrParser is correct not to throw errors as it is
1333         parsing in non-Unicode mode. Also adds a few named groups tests.
1334
1335         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1336
1337 2020-03-25  Zhifei Fang  <zhifei_fang@apple.com>
1338
1339         [Timeline] A better default get label function, which fit the assumpation the label is always a string
1340         https://bugs.webkit.org/show_bug.cgi?id=209567
1341
1342         Reviewed by Jonathan Bedard.
1343
1344         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
1345
1346 2020-03-25  Zhifei Fang  <zhifei_fang@apple.com>
1347
1348         [Timeline] Fix the out of bound dot index
1349         https://bugs.webkit.org/show_bug.cgi?id=209492
1350
1351         Reviewed by Jonathan Bedard.
1352
1353         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
1354         (Timeline.CanvasSeriesComponent):
1355
1356 2020-03-25  Daniel Bates  <dabates@apple.com>
1357
1358         Element context character rects may be in wrong coordinate system
1359         https://bugs.webkit.org/show_bug.cgi?id=209493
1360         <rdar://problem/60840261>
1361
1362         Reviewed by Wenson Hsieh.
1363
1364         Add some tests.
1365
1366         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1367         (TEST):
1368
1369 2020-03-25  Doug Kelly  <dougk@apple.com>
1370
1371         Unreviewed, add new committer to contributors.json
1372
1373         * Scripts/webkitpy/common/config/contributors.json:
1374
1375 2020-03-25  Frank Yang  <guowei_yang@apple.com>
1376
1377         Unprefix -webkit-text-orientation
1378         https://bugs.webkit.org/show_bug.cgi?id=196139
1379
1380         Reviewed by Myles C. Maxfield.
1381
1382         This change is made to add the extra flag "related-property" in CSSProperty.json
1383         in the jsonchecker so that the jsonchecker would not complain about unrecognized key
1384
1385         * Scripts/webkitpy/style/checkers/jsonchecker.py: added check for related-property
1386         (JSONCSSPropertiesChecker.check_codegen_properties): 
1387
1388 2020-03-25  Aakash Jain  <aakash_jain@apple.com>
1389
1390         [ews] commit-queue should comment on bug if it fails to find any modified ChangeLog
1391         https://bugs.webkit.org/show_bug.cgi?id=209550
1392
1393         Reviewed by Jonathan Bedard.
1394
1395         * BuildSlaveSupport/ews-build/steps.py:
1396         (FindModifiedChangeLogs): Set haltOnFailure to false.
1397         (FindModifiedChangeLogs.getResultSummary):
1398         (FindModifiedChangeLogs.evaluateCommand): Add build steps to comment on bug and set cq- on patch appropriately.
1399         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
1400
1401 2020-03-25  Aakash Jain  <aakash_jain@apple.com>
1402
1403         [ews] status-bubble should link to buildbot queue while waiting in queue
1404         https://bugs.webkit.org/show_bug.cgi?id=209543
1405
1406         Reviewed by Jonathan Bedard.
1407
1408         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1409         (StatusBubble._build_bubble): Link to buildbot queue whil patch is waiting in queue.
1410         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1411         (Buildbot.update_icons_for_queues_mapping): Generate the mapping for shortname to full queue name.
1412
1413 2020-03-25  Ting-Wei Lan  <lantw44@gmail.com>
1414
1415         [GTK] Add user agent quirk for auth.mayohr.com
1416         https://bugs.webkit.org/show_bug.cgi?id=209378
1417
1418         Reviewed by Michael Catanzaro.
1419
1420         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1421         (TestWebKitAPI::assertUserAgentForURLHasNoSafariVersionQuirk):
1422         (TestWebKitAPI::TEST):
1423
1424 2020-03-24  Daniel Bates  <dabates@apple.com>
1425
1426         Unreviewed, reverting r258945.
1427
1428         Revert change that broke API tests while I investigate
1429         offline.
1430
1431         Reverted changeset:
1432
1433         "Element context character rects may be in wrong coordinate
1434         system"
1435         https://bugs.webkit.org/show_bug.cgi?id=209493
1436         https://trac.webkit.org/changeset/258945
1437
1438 2020-03-24  Jiewen Tan  <jiewen_tan@apple.com>
1439
1440         Unreviewed, skips a test for iOS
1441
1442         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
1443
1444 2020-03-24  Jonathan Bedard  <jbedard@apple.com>
1445
1446         results.webkit.org: Documentation for uncollapsed failure endpoints is wrong
1447         https://bugs.webkit.org/show_bug.cgi?id=209496
1448
1449         Rubber-stamped by Aakash Jain.
1450
1451         * resultsdbpy/resultsdbpy/view/templates/documentation.html:
1452
1453 2020-03-24  Jonathan Bedard  <jbedard@apple.com>
1454
1455         results.webkit.org: Filter suite results by expectation by default
1456         https://bugs.webkit.org/show_bug.cgi?id=209500
1457
1458         Rubber-stamped by Aakash Jain.
1459
1460         * resultsdbpy/resultsdbpy/view/static/js/timeline.js: Allow the Legend constructor
1461         to set a willFilterExpected default.
1462         * resultsdbpy/resultsdbpy/view/templates/suite_results.html:
1463
1464 2020-03-24  Per Arne Vollan  <pvollan@apple.com>
1465
1466         [Cocoa] Fix launch time regression with CF prefs direct mode enabled
1467         https://bugs.webkit.org/show_bug.cgi?id=209244
1468
1469         Reviewed by Darin Adler.
1470
1471         * TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm:
1472         (TEST):
1473         (sharedInstanceMethodOverride):
1474
1475 2020-03-24  Jonathan Bedard  <jbedard@apple.com>
1476
1477         results.webkit.org: Correct UUID capitalization in documentation
1478         https://bugs.webkit.org/show_bug.cgi?id=209497
1479
1480         Reviewed by Aakash Jain.
1481
1482         * resultsdbpy/resultsdbpy/view/templates/documentation.html:
1483
1484 2020-03-24  Aakash Jain  <aakash_jain@apple.com>
1485
1486         [ews] commit-queue should comment on bug if it fails to create git commit
1487         https://bugs.webkit.org/show_bug.cgi?id=209487
1488
1489         Reviewed by Jonathan Bedard.
1490
1491         * BuildSlaveSupport/ews-build/steps.py:
1492         (CreateLocalGITCommit):
1493         (CreateLocalGITCommit.start):
1494         (CreateLocalGITCommit.evaluateCommand):
1495         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
1496
1497 2020-03-24  Daniel Bates  <dabates@apple.com>
1498
1499         Element context character rects may be in wrong coordinate system
1500         https://bugs.webkit.org/show_bug.cgi?id=209493
1501         <rdar://problem/60840261>
1502
1503         Reviewed by Wenson Hsieh.
1504
1505         Add some tests.
1506
1507         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1508         (TEST):
1509
1510 2020-03-24  Aakash Jain  <aakash_jain@apple.com>
1511
1512         [ews] position in queue shown in status-bubble is larger than actual position
1513         https://bugs.webkit.org/show_bug.cgi?id=209481
1514
1515         Reviewed by Jonathan Bedard.
1516
1517         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1518         (StatusBubble._queue_position): Use created timestamp instead of modified.
1519
1520 2020-03-24  Daniel Bates  <dabates@apple.com>
1521
1522         [iOS][WK2] Set text trait isSingleLineDocument
1523         https://bugs.webkit.org/show_bug.cgi?id=209391
1524         <rdar://problem/60705870>
1525
1526         Reviewed by Darin Adler.
1527
1528         Add a test.
1529
1530         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1531         (TestWebKitAPI::TEST):
1532         * TestWebKitAPI/ios/UIKitSPI.h: Expose more SPI.
1533
1534 2020-03-24  Alex Christensen  <achristensen@webkit.org>
1535
1536         Unreviewed, reverting r258862.
1537
1538         SPI was not what was needed
1539
1540         Reverted changeset:
1541
1542         "Add SPI to move localStorage to a different domain"
1543         https://bugs.webkit.org/show_bug.cgi?id=209260
1544         https://trac.webkit.org/changeset/258862
1545
1546 2020-03-24  Chris Lord  <clord@igalia.com>
1547
1548         [GTK][WPE] WEB_PROCESS_CMD_PREFIX and others have stopped working
1549         https://bugs.webkit.org/show_bug.cgi?id=209478
1550
1551         Make sure *_PROCESS_CMD_PREFIX variables are whitelisted in the Flatpak sandbox.
1552
1553         Reviewed by Philippe Normand.
1554
1555         * flatpak/flatpakutils.py:
1556         (WebkitFlatpak.run_in_sandbox):
1557
1558 2020-03-23  Simon Fraser  <simon.fraser@apple.com>
1559
1560         [mac-wk1] fast/scrolling/arrow-key-scroll-in-rtl-document.html is a flaky timeout
1561         https://bugs.webkit.org/show_bug.cgi?id=209427
1562
1563         Reviewed by Wenson Hsieh.
1564         
1565         0 => NULL
1566
1567         * DumpRenderTree/mac/DumpRenderTree.mm:
1568         (invalidateAnyPreviousWaitToDumpWatchdog):
1569
1570 2020-03-23  Dean Jackson  <dino@apple.com>
1571
1572         webkitpy Git class must expose the repository URL
1573         https://bugs.webkit.org/show_bug.cgi?id=209439
1574         <rdar://problem/60792668>
1575
1576         Reviewed by Simon Fraser.
1577
1578         Some internal tools were relying on the svn_url() method
1579         that was changed/removed in r258164. Add a replacement.
1580
1581         * Scripts/webkitpy/common/checkout/scm/git.py:
1582         (Git.svn_repository_url):
1583
1584 2020-03-23  Alex Christensen  <achristensen@webkit.org>
1585
1586         Fix memory leak introduced in r257726
1587         https://bugs.webkit.org/show_bug.cgi?id=208399
1588
1589         Reviewed by John Wilander.
1590
1591         * WebKitTestRunner/TestController.cpp:
1592         (WTR::TestController::websiteDataStore):
1593         We were leaking page configurations.
1594
1595 2020-03-23  John Wilander  <wilander@apple.com>
1596
1597         Add the capability to change all of a website's cookies to SameSite=Strict
1598         https://bugs.webkit.org/show_bug.cgi?id=209369
1599         <rdar://problem/60710690>
1600
1601         Reviewed by Alex Christensen and David Kilzer.
1602
1603         These changes add TestRunner function statisticsSetToSameSiteStrictCookies().
1604
1605         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1606         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1607         (WTR::InjectedBundle::didReceiveMessageToPage):
1608         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1609         (WTR::TestRunner::statisticsSetToSameSiteStrictCookies):
1610         (WTR::TestRunner::statisticsCallDidSetToSameSiteStrictCookiesCallback):
1611         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1612         * WebKitTestRunner/TestController.cpp:
1613         (WTR::TestController::setStatisticsToSameSiteStrictCookies):
1614         * WebKitTestRunner/TestController.h:
1615         * WebKitTestRunner/TestInvocation.cpp:
1616         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1617         (WTR::TestInvocation::didSetToSameSiteStrictCookies):
1618         * WebKitTestRunner/TestInvocation.h:
1619
1620 2020-03-23  Nikos Mouchtaris  <nmouchtaris@apple.com>
1621
1622         Uneviewed, added myself to contributors.json.
1623
1624         * Scripts/webkitpy/common/config/contributors.json:
1625
1626 2020-03-23  Daniel Bates  <dabates@apple.com>
1627
1628         Support inserting text or dictation alternative by simulating keyboard input
1629         https://bugs.webkit.org/show_bug.cgi?id=209380
1630         <rdar://problem/59445102>
1631
1632         Reviewed by Darin Adler.
1633
1634         Add tests to ensure that DOM events are dispatched on insertion when shouldSimulateKeyboardInput
1635         is enabled.
1636
1637         I also added a convenience assertion function, EXPECT_NS_EQUAL, that can
1638         compare NSObjects so long as they implement -isEqual and -description. I
1639         make use of this to compare the actual array of fired DOM events types to
1640         an expected array.
1641
1642         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1643         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1644         (TestWebKitAPI::shouldSimulateKeyboardInputOnTextInsertionOverride):
1645         (TestWebKitAPI::TEST):
1646         * TestWebKitAPI/cocoa/TestCocoa.h:
1647         (TestWebKitAPI::Util::assertNSObjectsAreEqual): Added.
1648         (EXPECT_NS_EQUAL): Added.
1649         * TestWebKitAPI/ios/insert-text.html: Added.
1650
1651 2020-03-23  Kate Cheney  <katherine_cheney@apple.com>
1652
1653         Add checks for app-bound navigations when evaluating user style sheets
1654         https://bugs.webkit.org/show_bug.cgi?id=209368
1655         <rdar://problem/60204230>
1656
1657         Reviewed by Brent Fulgham.
1658
1659         Tested cases based on those in UserContentController.mm.
1660
1661         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
1662         (-[InAppBrowserSchemeHandler webView:startURLSchemeTask:]):
1663         (expectScriptEvaluatesToColor):
1664         (TEST):
1665
1666
1667 2020-03-23  Alex Christensen  <achristensen@webkit.org>
1668
1669         Add SPI to move localStorage to a different domain
1670         https://bugs.webkit.org/show_bug.cgi?id=209260
1671         <rdar://problem/60285683>
1672
1673         Reviewed by Brady Eidson.
1674
1675         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1676         (TEST):
1677
1678 2020-03-23  youenn fablet  <youenn@apple.com>
1679
1680         Disable TestWebKitAPI.ProcessSwap.GetUserMediaCaptureState if getUserMedia is not supported
1681         https://bugs.webkit.org/show_bug.cgi?id=209428
1682
1683         Reviewed by Jonathan Bedard.
1684
1685         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1686
1687 2020-03-23  Chris Lord  <clord@igalia.com>
1688
1689         Add missing committer status to Chris Lord in contributors.json
1690
1691         Unreviewed
1692
1693         * Scripts/webkitpy/common/config/contributors.json:
1694
1695 2020-03-23  youenn fablet  <youenn@apple.com>
1696
1697         StringView::startsWith and String::startsWith do not treat null strings the same
1698         https://bugs.webkit.org/show_bug.cgi?id=209273
1699
1700         Reviewed by Darin Adler.
1701
1702         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1703         (TestWebKitAPI::TEST):
1704         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1705         (TestWebKitAPI::TEST):
1706
1707 2020-03-22  Antoine Quint  <graouts@apple.com>
1708
1709         DocumentTimeline / CSSTransition objects are leaking on CNN.com
1710         https://bugs.webkit.org/show_bug.cgi?id=208069
1711         <rdar://problem/59680143>
1712
1713         Reviewed by Simon Fraser, Geoffrey Garen and Darin Adler.
1714
1715         Add a test that checks that a ListHashSet containing RefPtr<> types correctly calls the destructor for those items when the assignment operator is used.
1716
1717         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
1718         (TestWebKitAPI::ListHashSetReferencedItem::create):
1719         (TestWebKitAPI::ListHashSetReferencedItem::ListHashSetReferencedItem):
1720         (TestWebKitAPI::ListHashSetReferencedItem::~ListHashSetReferencedItem):
1721         (TestWebKitAPI::FakeElementAnimationRareData::FakeElementAnimationRareData):
1722         (TestWebKitAPI::FakeElementAnimationRareData::~FakeElementAnimationRareData):
1723         (TestWebKitAPI::FakeElementAnimationRareData::collection):
1724         (TestWebKitAPI::FakeElementAnimationRareData::setCollection):
1725         (TestWebKitAPI::TEST):
1726
1727 2020-03-21  Michael Catanzaro  <mcatanzaro@gnome.org>
1728
1729         [GTK] Use ${PYTHON_EXECUTABLE} to run generate-gtkdoc
1730         https://bugs.webkit.org/show_bug.cgi?id=208970
1731
1732         Reviewed by Konstantin Tokarev.
1733
1734         We are allowed to use /usr/bin/env in this script because it's not installed (so not
1735         packaged). Therefore we can make the shebang compatible with FreeBSD in this particularl
1736         case.
1737
1738         * gtkdoc/generate-gtkdoc:
1739
1740 2020-03-20  Jonathan Bedard  <jbedard@apple.com>
1741
1742         run-webkit-tests: Report MacCatalyst as a unique platform
1743         https://bugs.webkit.org/show_bug.cgi?id=209361
1744
1745         Rubber-stamped by Aakash Jain.
1746
1747         * Scripts/webkitpy/port/mac.py:
1748         (MacCatalystPort):
1749         (MacCatalystPort.configuration_for_upload): Treat MacCatalyst as a separate platform from Mac.
1750
1751 2020-03-20  Alex Christensen  <achristensen@webkit.org>
1752
1753         CORS-disabling SPI introduced in r253978 should make responses non-opaque
1754         https://bugs.webkit.org/show_bug.cgi?id=209351
1755         <rdar://problem/60024850>
1756
1757         Reviewed by Chris Dumez.
1758
1759         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1760
1761 2020-03-20  Aakash Jain  <aakash_jain@apple.com>
1762
1763         commit-queue should skip building and testing if patch already passed tests on mac-wk2 queue
1764         https://bugs.webkit.org/show_bug.cgi?id=208938
1765
1766         Reviewed by Jonathan Bedard.
1767
1768         * BuildSlaveSupport/ews-build/steps.py:
1769         (RunWebKitTests.doStepIf): Skip testing if patch already passed mac-wk2 tests.
1770         (CheckPatchStatusOnEWSQueues): Build-step to check patch status on other queues.
1771         (CheckPatchStatusOnEWSQueues.get_patch_status):
1772         (CheckPatchStatusOnEWSQueues.start):
1773         * BuildSlaveSupport/ews-build/steps_unittest.py:
1774         (test_skip_for_mac_wk2_passed_patch_on_commit_queue): Added unit-tests.
1775         * BuildSlaveSupport/ews-build/factories.py: Added build-step to check the patch status on other queues.
1776         * BuildSlaveSupport/ews-build/factories_unittest.py: Updated unit-test.
1777         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added the new step status to STEPS_TO_HIDE.
1778
1779 2020-03-20  Aakash Jain  <aakash_jain@apple.com>
1780
1781         [ews] Better organize patch status api data
1782         https://bugs.webkit.org/show_bug.cgi?id=209342
1783
1784         Reviewed by Jonathan Bedard.
1785
1786         * BuildSlaveSupport/ews-app/ews/views/status.py:
1787         (Status._build_status):
1788         (Status._build_statuses_for_patch): Updated to return dictionary instead of list.
1789         (Status.get): Remove safe=false now that we are returning a dictionary.
1790
1791 2020-03-20  Tim Horton  <timothy_horton@apple.com>
1792
1793         Upstream a variety of Cocoa-platform HAVE and ENABLE macros
1794         https://bugs.webkit.org/show_bug.cgi?id=209307
1795
1796         Reviewed by Andy Estes.
1797
1798         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1799
1800 2020-03-20  Jacob Uphoff  <jacob_uphoff@apple.com>
1801
1802         Unreviewed, reverting r258748.
1803
1804         This commit broke the Catalina build
1805
1806         Reverted changeset:
1807
1808         "Upstream a variety of Cocoa-platform HAVE and ENABLE macros"
1809         https://bugs.webkit.org/show_bug.cgi?id=209307
1810         https://trac.webkit.org/changeset/258748
1811
1812 2020-03-20  Aakash Jain  <aakash_jain@apple.com>
1813
1814         [ews] commit-queue should comment on bug if patch fails to apply
1815         https://bugs.webkit.org/show_bug.cgi?id=209334
1816
1817         Reviewed by Jonathan Bedard.
1818
1819         * BuildSlaveSupport/ews-build/steps.py:
1820         (ApplyPatch):
1821         (ApplyPatch.evaluateCommand): Overridden to check build status and queue name and comment on bug accordingly.
1822         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1823         (TestApplyPatch):
1824         (TestApplyPatch.setUp):
1825         (TestApplyPatch.setUp.mock_start):
1826         (TestApplyPatch.tearDown):
1827         (TestApplyPatch.test_success):
1828         (TestApplyPatch.test_failure):
1829         (TestApplyPatch.test_failure_on_commit_queue):
1830
1831 2020-03-20  Aakash Jain  <aakash_jain@apple.com>
1832
1833         [EWS] Limit number of builds to display in status-bubble hover over message in case of lot of retried builds
1834         https://bugs.webkit.org/show_bug.cgi?id=209122
1835
1836         Reviewed by Jonathan Bedard.
1837
1838         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1839         (StatusBubble._build_bubble):
1840
1841 2020-03-19  Tim Horton  <timothy_horton@apple.com>
1842
1843         Upstream a variety of Cocoa-platform HAVE and ENABLE macros
1844         https://bugs.webkit.org/show_bug.cgi?id=209307
1845
1846         Reviewed by Andy Estes.
1847
1848         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1849
1850 2020-03-19  Alex Christensen  <achristensen@webkit.org>
1851
1852         Remove test failing after r258734
1853         https://bugs.webkit.org/show_bug.cgi?id=209303
1854
1855         We removed the functionality it was testing because it did nothing useful except call the callback.
1856         I'm about to remove the only user of WKContextGetStatistics.
1857
1858         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1859         * TestWebKitAPI/Tests/WebKit/WebCoreStatisticsWithNoWebProcess.cpp: Removed.
1860
1861 2020-03-19  Aakash Jain  <aakash_jain@apple.com>
1862
1863         commit-queue status-bubble shows incorrect position in queue
1864         https://bugs.webkit.org/show_bug.cgi?id=209313
1865
1866         Reviewed by Jonathan Bedard.
1867
1868         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1869         (StatusBubble._queue_position):
1870
1871 2020-03-19  Takashi Komori  <Takashi.Komori@sony.com>
1872
1873         [Curl] Add an API returns description of verification errors.
1874         https://bugs.webkit.org/show_bug.cgi?id=208913
1875
1876         Reviewed by Fujii Hironori.
1877
1878         WKCertificateInfoCopyVerificationErrorDescription returns the description of SSL verification error as human readable string.
1879         Browser can display more precise error information with this API.
1880
1881         API Test: Curl.CertificateAPI
1882
1883         * MiniBrowser/win/Common.cpp:
1884         (askServerTrustEvaluation):
1885         * MiniBrowser/win/Common.h:
1886         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1887         (createPEMString):
1888         (WebKitBrowserWindow::canTrustServerCertificate):
1889         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp:
1890         (TestWebKitAPI::Curl::TEST):
1891
1892 2020-03-19  Aakash Jain  <aakash_jain@apple.com>
1893
1894         Update build.webkit.org link for EWS
1895         https://bugs.webkit.org/show_bug.cgi?id=209280
1896
1897         Reviewed by Alexey Proskuryakov.
1898
1899         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1900
1901 2020-03-19  Stephan Szabo  <stephan.szabo@sony.com>
1902
1903         [WinCairo] extract-built-product fails after r258612
1904         https://bugs.webkit.org/show_bug.cgi?id=209285
1905
1906         extractBuiltProduct also references the old name for the
1907         requirements on wincairo.
1908
1909         Reviewed by Ross Kirsling.
1910
1911         * BuildSlaveSupport/built-product-archive:
1912
1913 2020-03-19  Philippe Normand  <pnormand@igalia.com>
1914
1915         [Flatpak SDK] Release logs not sent to journald when running within the SDK runtime
1916         https://bugs.webkit.org/show_bug.cgi?id=209223
1917
1918         Reviewed by Carlos Alberto Lopez Perez.
1919
1920         flatpak build doesn't expose a --socket option for white-listing
1921         the systemd journal socket. So white-list everything in /run. 🤷
1922
1923         * flatpak/flatpakutils.py:
1924         (WebkitFlatpak.run_in_sandbox):
1925
1926 2020-03-19  Charlie Turner  <cturner@igalia.com>
1927
1928         Fix many warnings with Clang 7.0 on GTK x86-64 in Debug.
1929         https://bugs.webkit.org/show_bug.cgi?id=209146
1930
1931         Reviewed by Darin Adler.
1932
1933         * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp:
1934         (TestWebKitAPI::TEST):
1935         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1936         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
1937         (testDownloadMIMEType):
1938         (testContextMenuDownloadActions):
1939         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
1940
1941 2020-03-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1942
1943         [GTK][WPE] REGRESSION(r258626): flatpak is used even when WEBKIT_JHBUILD is set
1944         https://bugs.webkit.org/show_bug.cgi?id=209278
1945
1946         Reviewed by Philippe Normand.
1947
1948         This happens when using an external jhbuild, because shouldUseFlatpak() assumes that no command prefix always
1949         means flatpak.
1950
1951         * Scripts/webkitdirs.pm:
1952         (shouldUseFlatpak): Return early if WEBKIT_JHBUILD is set.
1953
1954 2020-03-19  Philippe Normand  <pnormand@igalia.com>
1955
1956         [CMake] cache not cleared when build-webkit options change
1957         https://bugs.webkit.org/show_bug.cgi?id=209277
1958
1959         Reviewed by Adrian Perez de Castro.
1960
1961         * Scripts/webkitdirs.pm:
1962         (shouldRemoveCMakeCache): The expected function signature never
1963         included the cache file path. Remove it.
1964
1965 2020-03-18  Philippe Normand  <pnormand@igalia.com>
1966
1967         REGRESSION(r258626): webkit-dirs warning
1968         https://bugs.webkit.org/show_bug.cgi?id=209221
1969
1970         Reviewed by Adrian Perez de Castro.
1971
1972         * Scripts/webkitdirs.pm:
1973         (buildCMakeProjectOrExit): Fix Perl Warning. 😎
1974
1975 2020-03-19  Chris Lord  <clord@igalia.com>
1976
1977         Add Chris Lord (clord@igalia.com) to the list of contributors
1978         https://bugs.webkit.org/show_bug.cgi?id=209274
1979
1980         Unreviewed
1981
1982         * Scripts/webkitpy/common/config/contributors.json:
1983
1984 2020-03-19  Ryan Haddad  <ryanhaddad@apple.com>
1985
1986         Remove commit queue bubble from bot watchers dashboard
1987         https://bugs.webkit.org/show_bug.cgi?id=209271
1988
1989         Reviewed by Alexey Proskuryakov.
1990
1991         Remove commit queue bubble from bot watchers dashboard now that it has moved to the new EWS.
1992
1993         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1994         (BubbleQueueServer): 
1995
1996 2020-03-18  Simon Fraser  <simon.fraser@apple.com>
1997
1998         eventSender.monitorWheelEvents() is very fragile
1999         https://bugs.webkit.org/show_bug.cgi?id=197819
2000         <rdar://problem/51319456>
2001
2002         Reviewed by Tim Horton.
2003
2004         Deflake tests using eventSender.monitorWheelEvents() by fixing several causes of flakiness,
2005         adding back changes from r257844 that were reverted in r258558.
2006         
2007         First, have EventSendingController keep track of whether it's seen then "end" event
2008         for the scrolling and momentum phases, and pass this down to WheelEventTestMonitor, which
2009         now waits until it sees these, which prevents premature triggering which was a common cause of
2010         failure before.
2011         
2012         Second, remove WheelEventTestMonitor's 1/60s timer and instead have WheelEventTestMonitor test
2013         for completion in a callout from the end of Page::updateRendering(), which makes it test
2014         and fire at a more consistent time.
2015         
2016         Third, push WheelEventTestMonitor to the ScrollingTree, so that reasons for deferral
2017         can be added on the scrolling thread. This fixes an issue where the RunLoop::main().dispatch()
2018         used to send the "ScrollingThreadSyncNeeded" reason to the main thread would get delayed,
2019         also resulting in a premature trigger.
2020
2021         * DumpRenderTree/mac/EventSendingController.h:
2022         * DumpRenderTree/mac/EventSendingController.mm:
2023         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
2024         (-[EventSendingController monitorWheelEvents]):
2025         (-[EventSendingController callAfterScrollingCompletes:]):
2026         * DumpRenderTree/win/EventSender.cpp:
2027         (mouseScrollBy):
2028         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2029         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
2030         (WTR::EventSendingController::monitorWheelEvents):
2031         (WTR::EventSendingController::callAfterScrollingCompletes):
2032         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2033
2034 2020-03-18  John Wilander  <wilander@apple.com>
2035
2036         WebResourceLoadStatisticsStore::requestStorageAccessUnderOpener() should call its ephemeral counterpart when appropriate
2037         https://bugs.webkit.org/show_bug.cgi?id=209245
2038         <rdar://problem/60511121>
2039
2040         Reviewed by Chris Dumez.
2041
2042         These changes to the TestRunner makes sure that
2043         - statisticsClearInMemoryAndPersistentStore()
2044         - statisticsClearInMemoryAndPersistentStoreModifiedSinceHours()
2045         ... use their own StatisticsDidClearInMemoryAndPersistentStoreCallbackID
2046         and adds the infrastructure for that.
2047
2048         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2049         (WTR::InjectedBundle::didReceiveMessageToPage):
2050         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2051         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
2052         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
2053         (WTR::TestRunner::statisticsCallClearInMemoryAndPersistentStoreCallback):
2054         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2055         * WebKitTestRunner/TestController.cpp:
2056         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
2057         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
2058         * WebKitTestRunner/TestInvocation.cpp:
2059         (WTR::TestInvocation::didClearStatisticsInMemoryAndPersistentStore):
2060         * WebKitTestRunner/TestInvocation.h:
2061
2062 2020-03-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2063
2064         REGRESSION (r257214): Targeted preview animates to the wrong place when dropping in editable content
2065         https://bugs.webkit.org/show_bug.cgi?id=209218
2066         <rdar://problem/60560831>
2067
2068         Reviewed by Tim Horton.
2069
2070         Augment the drag and drop test harness to verify that for all targeted previews, if they have container views,
2071         those views must be parented (i.e. they must be connected to a UIWindow).
2072
2073         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2074         (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
2075         (-[DragAndDropSimulator _expectNoDropPreviewsWithUnparentedContainerViews]):
2076         (-[DragAndDropSimulator _invokeDropAnimationCompletionBlocksAndConcludeDrop]):
2077
2078 2020-03-18  Aakash Jain  <aakash_jain@apple.com>
2079
2080         [ews] commit-queue should comment on bug in case of test failures
2081         https://bugs.webkit.org/show_bug.cgi?id=209226
2082
2083         Reviewed by Jonathan Bedard.
2084
2085         * BuildSlaveSupport/ews-build/steps.py:
2086         (AnalyzeLayoutTestsResults.report_failure): Comment on bug and set cq- in case of test failure on commit-queue.
2087         (BuildLogLineObserver.outLineReceived): Drive-by fix to use single quotes instead of double quotes.
2088         (SetBuildSummary): Ditto.
2089         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
2090
2091 2020-03-18  Philippe Normand  <pnormand@igalia.com>
2092
2093         REGRESSION (r258626): test262 tests failing to run on macOS with error 'Undefined subroutine &Test262::Runner::setConfiguration'
2094         https://bugs.webkit.org/show_bug.cgi?id=209238
2095
2096         Reviewed by Jonathan Bedard.
2097
2098         * Scripts/test262-runner: Perform the flatpak check on Linux only.
2099
2100 2020-03-18  Stephan Szabo  <stephan.szabo@sony.com>
2101
2102         [WinCairo] archive-built-product fails after r258612
2103         https://bugs.webkit.org/show_bug.cgi?id=209237
2104
2105         Reviewed by Alex Christensen.
2106
2107         * BuildSlaveSupport/built-product-archive:
2108         Update name of version file for requirements version
2109         file for wincairo.
2110
2111 2020-03-18  Aakash Jain  <aakash_jain@apple.com>
2112
2113         commit-queue should allow patches which are reviewed by patch author
2114         https://bugs.webkit.org/show_bug.cgi?id=209231
2115
2116         Reviewed by Jonathan Bedard.
2117
2118         * BuildSlaveSupport/ews-build/steps.py:
2119         (BugzillaMixin._does_patch_have_acceptable_review_flag):
2120
2121 2020-03-18  Philippe Normand  <pnormand@igalia.com>
2122
2123         [JHBuild] Flatpak used for run-minibrowser even when forcing jhbuild
2124         https://bugs.webkit.org/show_bug.cgi?id=209222
2125
2126         Reviewed by Carlos Alberto Lopez Perez.
2127
2128         * Scripts/webkitdirs.pm:
2129         (runInFlatpakIfAvailable): If a command wrapper is required it
2130         means Flatpak shouldn't be used.
2131
2132 2020-03-18  Aakash Jain  <aakash_jain@apple.com>
2133
2134         [ews] commit-queue should comment on bug in case patch fails to build
2135         https://bugs.webkit.org/show_bug.cgi?id=209227
2136
2137         Reviewed by Jonathan Bedard.
2138
2139         * BuildSlaveSupport/ews-build/steps.py:
2140         (AnalyzeCompileWebKitResults.start):
2141         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
2142
2143 2020-03-18  Philippe Normand  <pnormand@igalia.com>
2144
2145         [GTK][WPE] Migrate to Flatpak-based dev SDK
2146         https://bugs.webkit.org/show_bug.cgi?id=205658
2147
2148         Reviewed by Carlos Alberto Lopez Perez.
2149
2150         JHBuild will now be used only if the WEBKIT_JHBUILD environment
2151         variable is set to 1, which is the case for the time being on the
2152         GTK and WPE EWS/build bots.
2153
2154         By default the build dependencies are now locally installed from a
2155         Flatpak repository hosted at https://software.igalia.com. The
2156         repository can be regenerated with the scripts from the
2157         webkit-flatpak-sdk Github project
2158         (https://github.com/Igalia/webkit-flatpak-sdk). This is done
2159         transparently with the update-webkit{gtk,wpe}-libs scripts. As
2160         there is no need to rebuild the dependencies from scratch, the
2161         developer user-experience should now be much more friendly and
2162         overall build times reduced.
2163
2164         As an additional commodity, the new environment supports the
2165         GStreamer gst-build-based workflow. Just set the GST_BUILD_PATH
2166         environment variable to your gst-build path. This feature was
2167         contributed by Thibault Saunier.
2168
2169         The JHBuild infrastructure will be removed once all the bots have
2170         been switched over to Flatpak.
2171
2172         * BuildSlaveSupport/ews-build/steps.py:
2173         (InstallGtkDependencies):
2174         (InstallWpeDependencies):
2175         (CompileWebKit.start):
2176         * BuildSlaveSupport/gtk/buildbot/run:
2177         * Scripts/build-webkit:
2178         * Scripts/run-bindings-tests:
2179         * Scripts/run-builtins-generator-tests:
2180         * Scripts/run-gtk-tests:
2181         * Scripts/run-javascriptcore-tests:
2182         * Scripts/run-minibrowser:
2183         * Scripts/run-qt-wpe-minibrowser:
2184         * Scripts/run-webdriver-tests:
2185         * Scripts/run-wpe-tests:
2186         * Scripts/test-webkitperl:
2187         * Scripts/test-webkitpy:
2188         * Scripts/test262-runner:
2189         * Scripts/update-webkit-flatpak: Renamed from Tools/Scripts/update-webkitgtk-flatpak.
2190         * Scripts/update-webkitgtk-libs:
2191         * Scripts/update-webkitwpe-flatpak: Removed.
2192         * Scripts/update-webkitwpe-libs:
2193         * Scripts/webkitdirs.pm:
2194         (getUserFlatpakPath):
2195         (inFlatpakSandbox):
2196         (runInFlatpakIfAvailable):
2197         (wrapperPrefixIfNeeded):
2198         (shouldUseJhbuild):
2199         (shouldUseFlatpak):
2200         (shouldRemoveCMakeCache):
2201         * Scripts/webkitpy/common/system/executive.py:
2202         (Executive.kill_all):
2203         * Scripts/webkitpy/port/base.py:
2204         (Port._path_to_apache):
2205         (Port._should_run_as_pixel_test):
2206         (Port._in_flatpak_sandbox):
2207         * Scripts/webkitpy/port/gtk.py:
2208         (GtkPort.setup_environ_for_server):
2209         (GtkPort._get_crash_log):
2210         * Scripts/webkitpy/port/linux_get_crash_log.py:
2211         (GDBCrashLogGenerator):
2212         (GDBCrashLogGenerator.__init__):
2213         (GDBCrashLogGenerator.generate_crash_log):
2214         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
2215         (GDBCrashLogGeneratorTest.test_generate_crash_log):
2216         * Scripts/webkitpy/port/wpe.py:
2217         (WPEPort.setup_environ_for_server):
2218         (WPEPort._get_crash_log):
2219         * Scripts/webkitpy/port/xvfbdriver.py:
2220         (XvfbDriver._setup_environ_for_test):
2221         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2222         (WTR::getFontsPath):
2223         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
2224         (WTR::getFontsPath):
2225         * flatpak/files/default.xkm: Removed.
2226         * flatpak/files/httpd-autogen.sh: Removed.
2227         * flatpak/flatpakutils.py:
2228         (check_flatpak):
2229         (FlatpakRepos.update):
2230         (FlatpakPackage.__repr__):
2231         (FlatpakPackage.__str__):
2232         (WebkitFlatpak.load_from_args):
2233         (WebkitFlatpak.__init__):
2234         (WebkitFlatpak.clean_args):
2235         (WebkitFlatpak.setup_builddir):
2236         (WebkitFlatpak):
2237         (WebkitFlatpak.setup_gstbuild):
2238         (WebkitFlatpak.run_in_sandbox):
2239         (WebkitFlatpak.run):
2240         (WebkitFlatpak.has_environment):
2241         (WebkitFlatpak.save_config):
2242         (WebkitFlatpak.setup_dev_env):
2243         (WebkitFlatpak.install_all):
2244         (WebkitFlatpak.run_gdb):
2245         * flatpak/org.webkit.CommonModules.yaml: Removed.
2246         * flatpak/org.webkit.GTK.yaml: Removed.
2247         * flatpak/org.webkit.WPE.yaml: Removed.
2248         * flatpak/org.webkit.WPEModules.yaml: Removed.
2249         * flatpak/org.webkit.WPEQT.yaml: Removed.
2250         * flatpak/org.webkit.WebKit.yaml: Removed.
2251         * flatpak/patches/httpd-0001-configure-use-pkg-config-for-PCRE-detection.patch: Removed.
2252         * flatpak/patches/libgcrypt-0001-Use-pkg-config-to-detect-gpg-error.patch: Removed.
2253         * flatpak/patches/xvfb-0001-HACK-Avoid-compiling-a-kbm-file.patch: Removed.
2254
2255 2020-03-17  Kate Cheney  <katherine_cheney@apple.com>
2256
2257         Expand In-App-Browser-Privacy testing
2258         https://bugs.webkit.org/show_bug.cgi?id=209142
2259         <rdar://problem/60496618>
2260
2261         Reviewed by Darin Adler.
2262
2263         Expanded test coverage by adding new tests and creating a custom url
2264         scheme handler to get around the fact that local file loads are
2265         always classified as app-bound.
2266
2267         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2268         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
2269         (-[InAppBrowserSchemeHandler webView:startURLSchemeTask:]):
2270         If the path indicates testing user scripts on load, notify the script message
2271         handler that the navigation has finished. If the path indicates
2272         testing user-agent scripts, set the window.wkUserScriptInjected
2273         variable to true. A user agent script will attempt to read this
2274         variable and should fail.
2275
2276         (-[InAppBrowserSchemeHandler webView:stopURLSchemeTask:]):
2277         (initializeInAppBrowserPrivacyTestSettings):
2278         Basic test setup. Initialize the main run loop and make sure we are
2279         starting with a clean state.
2280
2281         (TEST):
2282         Add tests for all protocols checked in shouldBeTreatedAsAppBound,
2283         except for blob files which must be generated within the web content.
2284
2285         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-local-file.html: Added.
2286         Basic html document to test local file loads are classified as
2287         app-bound.
2288
2289         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-agent-script.html: Removed.
2290         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-script.html: Removed.
2291         These files are no longer needed as their content is directly copied
2292         into the URL scheme handler.
2293
2294 2020-03-17  Chris Dumez  <cdumez@apple.com>
2295
2296         REGRESSION: [ macOS wk1 ] ASSERTION FAILED: _notifications.contains(notificationID) imported/w3c/web-platform-tests/notifications/constructor-basic.html is flaky crashing
2297         https://bugs.webkit.org/show_bug.cgi?id=207307
2298         <rdar://problem/59206964>
2299
2300         Reviewed by Alex Christensen.
2301
2302         When [MockWebNotificationProvider reset] was called at the end of the test, it would remove all
2303         notifications from the map but not tell WebCore that the notification were discarded. As a result,
2304         WebCore would later tell the MockWebNotificationProvider to cancel the notification but this
2305         notification would no longer be in the map, causing us to hit an assertion in debug.
2306
2307         To address the issue, we now call Notification::finalize() in [MockWebNotificationProvider reset]
2308         to let WebCore know the notification was discarded. This is similar to what is already done for
2309         WebKit2 in WebNotificationManager::clearNotifications().
2310
2311         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
2312         (-[MockWebNotificationProvider reset]):
2313
2314 2020-03-17  Don Olmstead  <don.olmstead@sony.com>
2315
2316         [WinCairo][FTW] Update path to requirements download
2317         https://bugs.webkit.org/show_bug.cgi?id=209202
2318
2319         Reviewed by Ross Kirsling.
2320
2321         Repository was renamed from WinCairoRequirements to WebKitRequirements in the
2322         WebKitForWindows org on GitHub. Additionally the .zip file was renamed to
2323         WebKitRequirementsWin64.zip.
2324
2325         * Scripts/update-webkit-wincairo-libs.py:
2326
2327 2020-03-17  Aakash Jain  <aakash_jain@apple.com>
2328
2329         [ews] Resubmit patches to commit-queue which were cq- by commit-queue and later cq+
2330         https://bugs.webkit.org/show_bug.cgi?id=208920
2331
2332         Reviewed by Jonathan Bedard.
2333
2334         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2335         (Buildbot.update_builder_name_to_id_mapping): Method to generate builder name to id mapping.
2336         (Buildbot.fetch_pending_and_inprogress_builds): Method to fetch pendign and in-progress builds from buildbot.
2337         (Buildbot.get_patches_in_queue): Method to fetch list of patches which are pending or are in-progress on buildbot.
2338         * BuildSlaveSupport/ews-app/ews/common/bugzilla.py:
2339         (Bugzilla.get_cq_plus_timestamp): Get UTC timestamp when cq+ flag was set.
2340         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2341         (FetchLoop.run): Update builder name to id mapping. We just need to update it one-time, since we need the id only
2342         for commit-queue which isn't expected to change.
2343         (BugzillaPatchFetcher.fetch_commit_queue_patches):
2344         (BugzillaPatchFetcher.send_patches_to_buildbot): Allow sending the patch again to commit-queue.
2345         (BugzillaPatchFetcher.patches_to_send_to_commit_queue): Find patches which needs to be sent to commit-queue. Filter
2346         out patches which are already waiting or in-progress on commit-queue, or whose recent build was completed after
2347         setting cq+ flag on bugzilla.
2348
2349 2020-03-17  Chris Dumez  <cdumez@apple.com>
2350
2351         [WKTR] testRunner API that takes in a completion handler should use async IPC
2352         https://bugs.webkit.org/show_bug.cgi?id=209187
2353
2354         Reviewed by John Wilander.
2355
2356         testRunner API that takes in a completion handler should use async IPC. This hangs
2357         the WebProcess for no reason and can cause deadlocks if the UIProcess then tries
2358         to IPC the WebProcess as a result of this testRunner call.
2359
2360         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2361         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
2362         (WTR::TestRunner::statisticsUpdateCookieBlocking):
2363         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
2364         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
2365         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
2366         (WTR::TestRunner::setStatisticsShouldDowngradeReferrer):
2367         (WTR::TestRunner::setStatisticsFirstPartyWebsiteDataRemovalMode):
2368         (WTR::TestRunner::statisticsResetToConsistentState):
2369         (WTR::TestRunner::getAllStorageAccessEntries):
2370         (WTR::TestRunner::removeAllSessionCredentials):
2371         (WTR::TestRunner::getApplicationManifestThen):
2372         * WebKitTestRunner/TestInvocation.cpp:
2373         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2374         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2375
2376 2020-03-17  Aakash Jain  <aakash_jain@apple.com>
2377
2378         [ews-app] Timestamp shown in status-bubble hover-over message is in future
2379         https://bugs.webkit.org/show_bug.cgi?id=196628
2380
2381         Reviewed by Jonathan Bedard.
2382
2383         * BuildSlaveSupport/ews-build/events.py:
2384         (JSONProducer.json_serialize_datetime): Keep the timestamp in UTC, instead of converting it to local time zone.
2385         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2386         (StatusBubble.get_all_builds_for_queue): Sort the queues based on build number instead of start time, since the 
2387         timestamps for new builds might be less than timestamps for old builds which completed immediately prior to this change.
2388
2389 2020-03-17  Alex Christensen  <achristensen@webkit.org>
2390
2391         Add WKUIDelegatePrivate SPI _webView:printFrame:completionHandler:
2392         https://bugs.webkit.org/show_bug.cgi?id=209192
2393         <rdar://problem/51313336>
2394
2395         Reviewed by Geoff Garen.
2396
2397         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2398         (-[PrintDelegateWithCompletionHandler _webView:printFrame:completionHandler:]):
2399         (-[PrintDelegateWithCompletionHandler waitForPrintFrameCall]):
2400         (TEST):
2401
2402 2020-03-17  Chris Dumez  <cdumez@apple.com>
2403
2404         Use less sync IPC for ITP testRunner methods
2405         https://bugs.webkit.org/show_bug.cgi?id=209184
2406
2407         Reviewed by Alex Christensen.
2408
2409         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2410         (WTR::TestRunner::setStatisticsDebugMode):
2411         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
2412         (WTR::TestRunner::setStatisticsLastSeen):
2413         (WTR::TestRunner::setStatisticsMergeStatistic):
2414         (WTR::TestRunner::setStatisticsPrevalentResource):
2415         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
2416         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
2417         * WebKitTestRunner/TestInvocation.cpp:
2418         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2419         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2420
2421 2020-03-17  Chris Dumez  <cdumez@apple.com>
2422
2423         [WKTR] Crash when trying to open a new window in an ephemeral session test
2424         https://bugs.webkit.org/show_bug.cgi?id=209181
2425
2426         Reviewed by Geoffrey Garen.
2427
2428         Make sure that the new WKWebView is using the same data store as its related WKWebView.
2429
2430         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2431         (WTR::TestController::platformCreateOtherPage):
2432
2433 2020-03-17  Jacob Uphoff  <jacob_uphoff@apple.com>
2434
2435         Unreviewed, reverting r257844.
2436
2437         this revision caused a test to start timing out
2438
2439         Reverted changeset:
2440
2441         "(r256513) [ Mac ] fast/scrolling/programmatic-scroll-to-zero-
2442         zero.html is a flaky failure"
2443         https://bugs.webkit.org/show_bug.cgi?id=207948
2444         https://trac.webkit.org/changeset/257844
2445
2446 2020-03-16  Justin Michaud  <justin_michaud@apple.com>
2447
2448         Add personal email to Tools/Scripts/webkitpy/common/config/contributors.json
2449         https://bugs.webkit.org/show_bug.cgi?id=209151
2450
2451         Reviewed by Yusuke Suzuki.
2452
2453         * Scripts/webkitpy/common/config/contributors.json:
2454
2455 2020-03-16  Chris Dumez  <cdumez@apple.com>
2456
2457         Crash under WebCookieCache::clearForHost()
2458         https://bugs.webkit.org/show_bug.cgi?id=209149
2459         <rdar://problem/60453086>
2460
2461         Reviewed by Alex Christensen.
2462
2463         Add API test coverage.
2464
2465         * TestWebKitAPI/Tests/WebKitCocoa/CookiePrivateBrowsing.mm:
2466         (TEST):
2467
2468 2020-03-16  Keith Rollin  <krollin@apple.com>
2469
2470         Remove support for WebKitSystemInterface
2471         https://bugs.webkit.org/show_bug.cgi?id=208894
2472         <rdar://problem/60297590>
2473
2474         Reviewed by Brent Fulgham.
2475
2476         This project provided support for facilities that are now handled
2477         elsewhere and is no longer needed.
2478
2479         * Scripts/copy-webkitlibraries-to-product-directory:
2480
2481 2020-03-16  Per Arne Vollan  <pvollan@apple.com>
2482
2483         [macOS] Accessibility sandbox regressions
2484         https://bugs.webkit.org/show_bug.cgi?id=209065
2485
2486         Reviewed by Brent Fulgham.
2487
2488         * TestWebKitAPI/Tests/WebKit/EnableAccessibility.mm:
2489         (TEST):
2490         * TestWebKitAPI/Tests/WebKit/GrantAccessToPreferencesService.mm:
2491         (TEST):
2492
2493 2020-03-16  Ryan Haddad  <ryanhaddad@apple.com>
2494
2495         Unreviewed infrastructure fix.
2496
2497         * BuildSlaveSupport/ews-build/config.json: Temporarily remove ews114
2498         while the hardware is out for repair.
2499
2500 2020-03-13  Sergio Villar Senin  <svillar@igalia.com>
2501
2502         [WebXR] IDLs, stubs and build configuration for WPE
2503         https://bugs.webkit.org/show_bug.cgi?id=208702
2504
2505         Reviewed by Dean Jackson.
2506
2507         * Scripts/webkitperl/FeatureList.pm: Added WebXR.
2508         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Added ENABLE_WEBXR, off by default.
2509
2510 2020-03-16  Per Arne Vollan  <pvollan@apple.com>
2511
2512         [Cocoa] Limit set of classes that can be decoded when a preference has changed
2513         https://bugs.webkit.org/show_bug.cgi?id=208012
2514
2515         Reviewed by Brent Fulgham.
2516
2517         * TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm:
2518         (TEST):
2519
2520 2020-03-16  youenn fablet  <youenn@apple.com>
2521
2522         Unique origins should not be Potentially Trustworthy
2523         https://bugs.webkit.org/show_bug.cgi?id=209049
2524
2525         Reviewed by Darin Adler.
2526
2527         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2528         (TestWebKitAPI::TEST_F):
2529
2530 2020-03-15  Fujii Hironori  <Hironori.Fujii@sony.com>
2531
2532         KeyedDecoderGeneric fails to allocate Vector while decoding broken data
2533         https://bugs.webkit.org/show_bug.cgi?id=207324
2534
2535         Reviewed by Darin Adler.
2536
2537         * TestWebKitAPI/Tests/WebCore/KeyedCoding.cpp:
2538         (TestWebKitAPI::generateRandomData): Added.
2539         (TestWebKitAPI::KeyedCoding.DecodeRandomData): Added a new test decoding random data.
2540
2541 2020-03-15  Yusuke Suzuki  <ysuzuki@apple.com>
2542
2543         Should not use variable-length-array (VLA)
2544         https://bugs.webkit.org/show_bug.cgi?id=209043
2545
2546         Reviewed by Mark Lam.
2547
2548         * ContentExtensionTester/Configurations/Base.xcconfig:
2549         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
2550
2551 2020-03-13  Alex Christensen  <achristensen@webkit.org>
2552
2553         WKWebView._negotiatedLegacyTLS should be correct after back/forward navigations
2554         https://bugs.webkit.org/show_bug.cgi?id=209011
2555         <rdar://problem/59370588>
2556
2557         Reviewed by Youenn Fablet.
2558
2559         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
2560         (TestWebKitAPI::TEST):
2561
2562 2020-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2563
2564         [watchOS] Don’t display empty text suggestions in Quickboard when editing input fields
2565         https://bugs.webkit.org/show_bug.cgi?id=209089
2566
2567         Reviewed by Tim Horton.
2568
2569         Add an API test for watchOS. Also rename a few occurrences of "Autofill" to "AutoFill", to reflect the official
2570         marketing name for the feature.
2571
2572         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2573         (runUntilReceivesAutoplayEvent):
2574
2575         Additionally fix the watchOS engineering build for arm64_32, which was failing due to comparisons between 64-bit
2576         and 32-bit integers. This is because this function took a `WKAutoplayEvent` (a 32-bit integer), but compared
2577         against the `_WKAutoplayEvent` type (an NSInteger that is 64 bits on this architecture). There didn't seem to
2578         be any compelling reason to compare against different types here (especially since we only set
2579         `receivedAutoplayEvent` under the Objective-C delegate method that provides a `_WKAutoplayEvent`), so I changed
2580         these all to be `_WKAutoplayEvent`.
2581
2582         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2583         (-[AutoFillTestView _autofillInputView]):
2584         (-[AutoFillTestView textInputHasAutoFillContext]):
2585         (TestWebKitAPI::TEST):
2586         (-[AutofillTestView initWithFrame:]): Deleted.
2587         (-[AutofillTestView _autofillInputView]): Deleted.
2588         (-[AutofillTestView textInputHasAutofillContext]): Deleted.
2589         * TestWebKitAPI/ios/UIKitSPI.h:
2590
2591 2020-03-13  Chris Dumez  <cdumez@apple.com>
2592
2593         Unreviewed, reverting r256232.
2594
2595         Caused ResizeObserver tests to become flaky
2596
2597         Reverted changeset:
2598
2599         "[DRT] InternalSettingsGenerated::resetToConsistentState() may
2600         override TestOptions"
2601         https://bugs.webkit.org/show_bug.cgi?id=207481
2602         https://trac.webkit.org/changeset/256232
2603
2604 2020-03-13  Kate Cheney  <katherine_cheney@apple.com>
2605
2606         [ iOS and Mac wk2 ] http/tests/in-app-browser-privacy/ tests failing
2607         https://bugs.webkit.org/show_bug.cgi?id=209016
2608         <rdar://problem/60329530> 
2609
2610         Reviewed by Chris Dumez.
2611
2612         Re-initialize the app-bound domains when the correct
2613         TestOptions parameter is set.
2614
2615         * WebKitTestRunner/TestController.cpp:
2616         (WTR::TestController::createWebViewWithOptions):
2617         (WTR::TestController::reinitializeAppBoundDomains):
2618         * WebKitTestRunner/TestController.h:
2619
2620 2020-03-13  Kate Cheney  <katherine_cheney@apple.com>
2621
2622         Report all third party loads on a per-page basis
2623         https://bugs.webkit.org/show_bug.cgi?id=209032
2624         <rdar://problem/60397323>
2625
2626         Reviewed by Chris Dumez.
2627
2628         Mostly naming updates to reflect the change in use for this SPI call.
2629         It now returns all loaded third party domains, not just prevalent ones.
2630
2631         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2632         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2633         (WTR::InjectedBundle::didReceiveMessageToPage):
2634         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2635         (WTR::TestRunner::getLoadedThirdPartyDomains):
2636         (WTR::TestRunner::callDidReceiveLoadedThirdPartyDomainsCallback):
2637         (WTR::TestRunner::getPrevalentDomains): Deleted.
2638         (WTR::TestRunner::callDidReceivePrevalentDomainsCallback): Deleted.
2639         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2640         * WebKitTestRunner/TestController.cpp:
2641         (WTR::TestController::resetStateToConsistentValues):
2642         (WTR::TestController::getLoadedThirdPartyDomains):
2643         (WTR::TestController::clearLoadedThirdPartyDomains):
2644         (WTR::TestController::getPrevalentDomains): Deleted.
2645         (WTR::TestController::clearPrevalentDomains): Deleted.
2646         * WebKitTestRunner/TestController.h:
2647         * WebKitTestRunner/TestInvocation.cpp:
2648         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2649         (WTR::TestInvocation::didReceiveLoadedThirdPartyDomains):
2650         (WTR::TestInvocation::didReceivePrevalentDomains): Deleted.
2651         * WebKitTestRunner/TestInvocation.h:
2652         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2653         (WTR::TestController::getLoadedThirdPartyDomains):
2654         (WTR::TestController::clearLoadedThirdPartyDomains):
2655         (WTR::TestController::getPrevalentDomains): Deleted.
2656         (WTR::TestController::clearPrevalentDomains): Deleted.
2657
2658 2020-03-13  Aakash Jain  <aakash_jain@apple.com>
2659
2660         [ews] run FindModifiedChangeLogs early in the build
2661         https://bugs.webkit.org/show_bug.cgi?id=209060
2662
2663         Reviewed by Jonathan Bedard.
2664
2665         * BuildSlaveSupport/ews-build/factories.py:
2666         * BuildSlaveSupport/ews-build/factories_unittest.py: Updated unit-test.
2667
2668 2020-03-13  Diego Pino Garcia  <dpino@igalia.com>
2669
2670         [GTK] Add EWS testers to run GTK layout tests
2671         https://bugs.webkit.org/show_bug.cgi?id=207648
2672
2673         Reviewed by Carlos Alberto Lopez Perez and Aakash Jain.
2674
2675         Queue 'GTK-Webkit2-EWS' was renamed to 'GTK-Build-EWS'.
2676         A new queue, named 'GTK-WK2-Tests-EWS', was added for WK2
2677         tests (layout tests).
2678
2679         * BuildSlaveSupport/ews-build/config.json: Added new queue for
2680         WK2 tests.
2681         * BuildSlaveSupport/ews-build/factories.py:
2682         (GTKTestsFactory):
2683         * BuildSlaveSupport/ews-build/factories_unittest.py:
2684         (TestCommitQueueFactory.test_commit_queue_factory):
2685         (TestGTKFactory): Added unit-test.
2686         (TestGTKFactory.test_gtk_factory):
2687         * BuildSlaveSupport/ews-build/loadConfig.py:
2688         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2689         (TagsForBuilderTest.test_getTagsForBuilder):
2690
2691 2020-03-13  Aakash Jain  <aakash_jain@apple.com>
2692
2693         Add API endpoint in EWS django app to provide patch status in json format
2694         https://bugs.webkit.org/show_bug.cgi?id=208940
2695
2696         Reviewed by Jonathan Bedard.
2697
2698         * BuildSlaveSupport/ews-app/ews/urls.py: Added url for new api endpoint.
2699         * BuildSlaveSupport/ews-app/ews/views/status.py: Added.
2700
2701 2020-03-13  Kate Cheney  <katherine_cheney@apple.com>
2702
2703         WebKit2UseRemoteLayerTreeDrawingArea should be reset to NO between layout tests
2704         https://bugs.webkit.org/show_bug.cgi?id=209055
2705         <rdar://problem/60272692>
2706
2707         Reviewed by Simon Fraser.
2708
2709         Now that WebKitTestRunner has a bundleID, its' user default values
2710         persist between tests. This patch resets WebKit2UseRemoteLayerTreeDrawingArea
2711         to NO before running tests. It will be set to YES in PlatformWebView
2712         if specified by the test.
2713
2714         * WebKitTestRunner/mac/main.mm:
2715         (setDefaultsToConsistentValuesForTesting):
2716
2717 2020-03-13  Konstantin Tokarev  <annulen@yandex.ru>
2718
2719         [CMake] Eleminate mismatches between Find* module names and variables they set
2720         https://bugs.webkit.org/show_bug.cgi?id=208948
2721
2722         Reviewed by Michael Catanzaro.
2723
2724         * wpe/backends/CMakeLists.txt:
2725
2726 2020-03-13  Aakash Jain  <aakash_jain@apple.com>
2727
2728         [ews-app] reduce logging
2729         https://bugs.webkit.org/show_bug.cgi?id=209062
2730
2731         Reviewed by Jonathan Bedard.
2732
2733         * BuildSlaveSupport/ews-app/ews/common/bugzilla.py:
2734         (BugzillaBeautifulSoup.authenticate):
2735         (BugzillaBeautifulSoup._load_query):
2736
2737 2020-03-13  Ryosuke Niwa  <rniwa@webkit.org>
2738
2739         Crash in TextIterator::node via TextManipulationController::replace
2740         https://bugs.webkit.org/show_bug.cgi?id=209048
2741
2742         Reviewed by Wenson Hsieh.
2743
2744         Added a regression test.
2745
2746         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2747         (TextManipulation.CompleteTextManipulationShouldReplaceContentsAroundParagraphWithJustImage):
2748
2749 2020-03-13  Saam Barati  <sbarati@apple.com>
2750
2751         Pull in JS tests from "Internal" when there are "Internal" tests in an adjacent directory
2752         https://bugs.webkit.org/show_bug.cgi?id=209038
2753
2754         Reviewed by Keith Miller.
2755
2756         This allows us to automatically pull in some tests that are in non open sourced Apple
2757         checkouts.
2758
2759         * Scripts/run-javascriptcore-tests:
2760         (runJSCStressTests):
2761
2762 2020-03-12  Ryosuke Niwa  <rniwa@webkit.org>
2763
2764         Crash in TextManipulationController::replace
2765         https://bugs.webkit.org/show_bug.cgi?id=209021
2766
2767         Reviewed by Wenson Hsieh.
2768
2769         Added a regression test.
2770
2771         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2772         (TextManipulation.CompleteTextManipulationShouldReplaceContentFollowedAfterImageInCSSTable):
2773
2774 2020-03-12  Per Arne Vollan  <pvollan@apple.com>
2775
2776         [macOS] _AXSApplicationAccessibilityEnabled should not be called
2777         https://bugs.webkit.org/show_bug.cgi?id=208953
2778
2779         Reviewed by Brent Fulgham.
2780
2781         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2782
2783 2020-03-12  Kate Cheney  <katherine_cheney@apple.com>
2784
2785         Resource load statistics data summary should return all third party data
2786         https://bugs.webkit.org/show_bug.cgi?id=209000
2787         <rdar://problem/60348306>
2788
2789         Reviewed by John Wilander.
2790
2791         Marked only 2 of 3 domains prevalent in data summary tests to ensure
2792         the call returns all third parties, not just prevalent ones.
2793         Added a more aggressive check for the size of the array at the
2794         beginning of the test to ensure the array is still returning 3 values. 
2795         Also removed the ASSERT statements as they seem to cause timeouts (not
2796         clear crashes) when they are not true, which is hard to debug.
2797         If these values are nil, the test will fail in the EXPECT_WK_STREQ
2798         checks, we don't need ASSERT statements.
2799
2800         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2801         (TEST):
2802
2803 2020-03-12  Jonathan Bedard  <jbedard@apple.com>
2804
2805         resultsdpy: Add script to run local instance
2806         https://bugs.webkit.org/show_bug.cgi?id=208746
2807
2808         Rubber-stamped by Aakash Jain.
2809
2810         * resultsdbpy/resultsdbpy/example: Added.
2811         * resultsdbpy/resultsdbpy/example/__init__.py: Added.
2812         * resultsdbpy/resultsdbpy/example/environment.py: Added.
2813         (Environment): Organize environment variables used by results database.
2814         (ModelFromEnvironment): Construct the database model from the environment.
2815         (main): Create and drop tables, if required.
2816         * resultsdbpy/resultsdbpy/example/main.py: Added.
2817         (health): Web-server health check.
2818         (handle_errors):
2819         (main): Run results database web-server.
2820         * resultsdbpy/resultsdbpy/example/worker.py: Added.
2821         (main): Asynchronously process uploaded results.
2822         * resultsdbpy/resultsdbpy/run: Added.
2823
2824 2020-03-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2825
2826         run-webkit-tests --use-gpu-process should enable GPU Process for canvas
2827         https://bugs.webkit.org/show_bug.cgi?id=209004
2828
2829         Reviewed by Tim Horton.
2830
2831         Add "RenderCanvasInGPUProcessEnabled" to the list of internal features that should be enabled when
2832         `use_gpu_process` is specified.
2833
2834         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2835         (parse_args):
2836
2837 2020-03-12  Matt Lewis  <jlewis3@apple.com>
2838
2839         Make flatpack import for run-webkit-tests only happen on linux systems
2840         https://bugs.webkit.org/show_bug.cgi?id=208954
2841
2842         Reviewed by Philippe Normand.
2843
2844         * Scripts/run-webkit-tests: Added an if statement to find the system platform
2845         to determine if we need the flatpackutils import. 
2846
2847 2020-03-12  Alex Christensen  <achristensen@webkit.org>
2848
2849         WKWebView.hasOnlySecureContent should be correct after back/forward navigations
2850         https://bugs.webkit.org/show_bug.cgi?id=207609
2851
2852         Reviewed by Ryosuke Niwa.
2853
2854         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
2855         (TestWebKitAPI::TEST):
2856
2857 2020-03-12  Daniel Bates  <dabates@apple.com>
2858
2859         FocusController::setFocusedElement() should tell client of refocused element
2860         https://bugs.webkit.org/show_bug.cgi?id=208880
2861
2862         Reviewed by Wenson Hsieh.
2863
2864         Adds a test to ensure that calling -selectPositionAtPoint on an already focused element tries
2865         to start an input session. Currently, it does not even try.
2866
2867         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
2868         (TEST):
2869
2870 2020-03-12  Michael Catanzaro  <mcatanzaro@gnome.org>
2871
2872         [GTK] Use #!/usr/bin/python3 shebang to run generate-gtkdoc
2873         https://bugs.webkit.org/show_bug.cgi?id=208970
2874
2875         Reviewed by Daniel Bates.
2876
2877         Fedora and Ubuntu are both patching generate-gtkdoc to use #!/usr/bin/python3 rather than
2878         #!/usr/bin/env python.
2879
2880         #!/usr/bin/env and /usr/bin/python are both banned in Fedora packages. I guess Ubuntu
2881         probably has similar rules.
2882
2883         Note this is the only script that attempts to use /usr/bin/python in tarball builds.
2884         Everything else that does so is probably only used by webkit-build.
2885
2886         https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_multiple_python_runtimes
2887
2888         * gtkdoc/generate-gtkdoc:
2889
2890 2020-03-11  Jiewen Tan  <jiewen_tan@apple.com>
2891
2892         [WebAuthn] Formalize the Keychain schema
2893         https://bugs.webkit.org/show_bug.cgi?id=183533
2894         <rdar://problem/43347926>
2895
2896         Reviewed by Brent Fulgham.
2897
2898         Modifies the test infra to use Credential ID as the unique identifier for a credential instead of
2899         the original combination of RP ID and user handle.
2900
2901         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2902         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2903         (WTR::TestRunner::cleanUpKeychain):
2904         (WTR::TestRunner::keyExistsInKeychain):
2905         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2906         * WebKitTestRunner/TestController.h:
2907         * WebKitTestRunner/TestInvocation.cpp:
2908         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2909         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2910         (WTR::TestController::cleanUpKeychain):
2911         (WTR::TestController::keyExistsInKeychain):
2912
2913 2020-03-11  Keith Miller  <keith_miller@apple.com>
2914
2915         Test262-runner should always consider crashes as new failures
2916         https://bugs.webkit.org/show_bug.cgi?id=208943
2917
2918         Reviewed by Yusuke Suzuki.
2919
2920         Right now the runner will consider crashes with no output as passes, which is obviously bad.
2921         Since we should never crash on a conformance test we should consider a crash as a new failure
2922         100% of the time.
2923
2924         * Scripts/test262/Runner.pm:
2925         (processFile):
2926         (runTest):
2927         (processResult):
2928
2929 2020-03-11  Chris Dumez  <cdumez@apple.com>
2930
2931         Assertion hit under WebPageProxy::suspendCurrentPageIfPossible() when bypassing certificate warning page
2932         https://bugs.webkit.org/show_bug.cgi?id=208927
2933         <rdar://problem/55448331>
2934
2935         Reviewed by Alex Christensen.
2936
2937         Add API test coverage.
2938
2939         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2940
2941 2020-03-11  Diego Pino Garcia  <dpino@igalia.com>
2942
2943         [GTK] Switch EWS api-gtk bot from buildAndTest to testOnly
2944         https://bugs.webkit.org/show_bug.cgi?id=208860
2945
2946         Reviewed by Carlos Alberto Lopez Perez.
2947
2948         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2949         (StatusBubble): Added 'api-gtk'.
2950         * BuildSlaveSupport/ews-build/config.json:
2951         * BuildSlaveSupport/ews-build/factories.py:
2952         (BuildFactory.__init__): Call InstallGTKDependencies() if platform is
2953         GTK.
2954         (TestFactory.__init__): Call InstallGTKDependencies() if platform is
2955         GTK.
2956         (GTKBuildFactory):
2957         (GTKBuildFactory.__init__): Deleted.
2958         (GTKBuildAndTestFactory): Deleted.
2959         (GTKBuildAndTestFactory.__init__): Deleted.
2960         (GTKAPIBuildAndTestFactory): Deleted.
2961         * BuildSlaveSupport/ews-build/loadConfig.py:
2962
2963 2020-03-11  Aakash Jain  <aakash_jain@apple.com>
2964
2965         [ews] Add unit test to prevent multiple schedulers for a builder.
2966         https://bugs.webkit.org/show_bug.cgi?id=208917
2967
2968         Reviewed by Carlos Alberto Lopez Perez.
2969
2970         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2971         (ConfigDotJSONTest.test_multiple_scheduers_for_builder): Added unit test.
2972         (TagsForBuilderTest): Fixed a typo.
2973
2974 2020-03-11 Philippe Normand  <pnormand@igalia.com>
2975
2976         [GTK] Failing API tests under the Flatpak SDK environment
2977         https://bugs.webkit.org/show_bug.cgi?id=208871
2978
2979         Reviewed by Michael Catanzaro.
2980
2981         The load-failed signal callback should return a boolean result,
2982         otherwise we enter in unknown territory depending on how the
2983         toolchain compiles this, possibly triggering bad behavior (with
2984         GCC 9.2 from the Flatpak SDK) or not caring at all (with current
2985         GCC toolchain on buildbots).
2986
2987         Patch suggested by Michael Catanzaro.
2988
2989         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
2990         (loadFailedCallback):
2991
2992 2020-03-10  Don Olmstead  <don.olmstead@sony.com>
2993
2994         Sync FeatureList.pm with CMake definitions
2995         https://bugs.webkit.org/show_bug.cgi?id=208866
2996
2997         Reviewed by Michael Catanzaro.
2998
2999         * Scripts/webkitperl/FeatureList.pm:
3000
3001 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
3002
3003         [ews] Add unit tests for commit queue factory
3004         https://bugs.webkit.org/show_bug.cgi?id=208862
3005
3006         Reviewed by Jonathan Bedard.
3007
3008         * BuildSlaveSupport/ews-build/factories_unittest.py:
3009         (TestCommitQueueFactory):
3010         (TestCommitQueueFactory.test_commit_queue_factory): Added unit-test for commit-queue factory.
3011
3012 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
3013
3014         [ews-app] Status bubble should only display important messages in pop-over - part 3
3015         https://bugs.webkit.org/show_bug.cgi?id=208865
3016
3017         Reviewed by Jonathan Bedard.
3018
3019         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3020         (StatusBubble): Added more strings to STEPS_TO_HIDE.
3021
3022 2020-03-10  Lauro Moura  <lmoura@igalia.com>
3023
3024         [WPE] MiniBrowser: Close child WebViews when exiting
3025         https://bugs.webkit.org/show_bug.cgi?id=208689
3026
3027         Reviewed by Carlos Garcia Campos.
3028
3029         Store created views so we can release them before exiting.
3030
3031         * MiniBrowser/wpe/main.cpp:
3032         (webViewClose):
3033         (createWebView):
3034         (main):
3035
3036 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
3037
3038         Add ValidateCommiterAndReviewer and ValidateChangeLogAndReviewer build steps in commit-queue
3039         https://bugs.webkit.org/show_bug.cgi?id=208861
3040
3041         Reviewed by Jonathan Bedard.
3042
3043         * BuildSlaveSupport/ews-build/factories.py:
3044         (Factory.__init__): Remove verifycqplus parameter.
3045         (CommitQueueFactory): Inherit from factory.BuildFactory base class instead of custom Factory class.
3046         (CommitQueueFactory.__init__): Add required build steps, especially ValidateCommiterAndReviewer, 
3047         UpdateWorkingDirectory and ValidateChangeLogAndReviewer.
3048
3049 2020-03-10  Philippe Normand  <pnormand@igalia.com>
3050
3051         [GTK] API favicon test flaky timeouts
3052         https://bugs.webkit.org/show_bug.cgi?id=208189
3053
3054         Reviewed by Carlos Garcia Campos.
3055
3056         Sometimes the favicon changes already during the load. Keeping
3057         track of it in the WebView favicon property notification handler
3058         gets us rid of the race.
3059
3060         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
3061         (testFaviconDatabaseGetFavicon):
3062
3063 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
3064
3065         Generate commit-queue status bubble from new EWS
3066         https://bugs.webkit.org/show_bug.cgi?id=208811
3067
3068         Reviewed by Jonathan Bedard.
3069
3070         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3071         (StatusBubble._build_bubbles_for_patch):
3072
3073 2020-03-09  Don Olmstead  <don.olmstead@sony.com>
3074
3075         Remove obsolete feature flags
3076         https://bugs.webkit.org/show_bug.cgi?id=208830
3077
3078         Reviewed by Alex Christensen.
3079
3080         Remove ENABLE_CUSTOM_SCHEME_HANDLER and ENABLE_MAC_VIDEO_TOOLBOX since they
3081         are no longer used.
3082
3083         Also remove ENABLE_POINTER_EVENTS since the FeaturesDefines.xcconfig was not modified
3084         when the compilation flag was removed in r258148.
3085
3086         Remove ENABLE_ACCELERATED_OVERFLOW_SCROLLING, ENABLE_CSS_IMAGE_ORIENTATION,
3087         ENABLE_CUSTOM_SCHEME_HANDLER, and ENABLE_FETCH_API from FeatureList.pm.
3088
3089         * Scripts/webkitperl/FeatureList.pm:
3090         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3091
3092 2020-03-09  Kate Cheney  <katherine_cheney@apple.com>
3093
3094         WebKitTestRunner bundleID should not be cleared before every test
3095         https://bugs.webkit.org/show_bug.cgi?id=208823
3096         <rdar://problem/60204539>
3097
3098         Reviewed by Per Arne Vollan.
3099
3100         This is causing test failures for layout tests which rely on the Info.plist 
3101         bundle identifier (not the one set via the override method).
3102
3103         * WebKitTestRunner/TestController.cpp:
3104         (WTR::TestController::createWebViewWithOptions):
3105         (WTR::TestController::ensureViewSupportsOptionsForTest):
3106         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3107
3108 2020-03-09  Per Arne Vollan  <pvollan@apple.com>
3109
3110         [macOS] Notification observer is not removed
3111         https://bugs.webkit.org/show_bug.cgi?id=208834
3112
3113         Reviewed by Tim Horton.
3114
3115         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3116         * TestWebKitAPI/Tests/WebKit/EnableAccessibility.mm: Added.
3117         (TEST):
3118
3119 2020-03-06  Brian Burg  <bburg@apple.com>
3120
3121         upload.py gets confused by git-svn checkouts, unable to upload test results from my desk build
3122         https://bugs.webkit.org/show_bug.cgi?id=208729
3123         <rdar://problem/60105447>
3124
3125         Reviewed by Jonathan Bedard.
3126
3127         Improve upload.py to look for the svn branch and revision for the 'webkit'
3128         project and prefer those to the git equivalents (eg, prefer trunk/rNNNNN to master/<hash>).
3129
3130         * Scripts/webkitpy/common/checkout/scm/git.py:
3131         (Git):
3132         (Git.git_svn_id_regexp):
3133         (Git._field_from_git_svn_id):
3134         (Git.svn_revision):
3135         (Git.svn_branch):
3136         (Git.svn_url):
3137         (Git.native_branch):
3138         Refactor svn revision, branch, url to use the same regexp and helper code.
3139
3140         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
3141         (StubRepository.svn_branch):
3142         Expose a stub since this is used unconditionally by Port.commits_for_upload.
3143
3144         * Scripts/webkitpy/common/checkout/scm/svn.py:
3145         (SVN.svn_branch):
3146         (SVN.native_revision):
3147         (SVN):
3148         (SVN.native_branch):
3149         Refactor so the actual implementation is contained in svn_revision / svn_branch.
3150         The native_* methods call out to the SVN equivalents since this is an SVN repository.
3151
3152         * Scripts/webkitpy/port/base.py:
3153         (Port.commits_for_upload):
3154         Add special git-svn handling for the WebKit repository so that SVN branch and revision
3155         is preferred over the git equivalents.
3156
3157 2020-03-09  Antoine Quint  <graouts@apple.com>
3158
3159         TestWebKitAPI fails to build on watchOS
3160         https://bugs.webkit.org/show_bug.cgi?id=208820
3161
3162         Reviewed by Tim Horton.
3163
3164         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
3165
3166 2020-03-09  Jonathan Bedard  <jbedard@apple.com>
3167
3168         resultsdbpy: Add tool to manage resultsdbpy container
3169         https://bugs.webkit.org/show_bug.cgi?id=208743
3170
3171         Rubber-stamped by Aakash Jain.
3172
3173         Add tool to start, stop and restart the resultsdbpy Docker container.
3174
3175         * resultsdbpy/resultsdbpy/container: Added.
3176
3177 2020-03-09  Carlos Garcia Campos  <cgarcia@igalia.com>
3178
3179         [GTK][WPE] Surrounding text for input methods should not be limited to the current paragraph
3180         https://bugs.webkit.org/show_bug.cgi?id=208706
3181
3182         Reviewed by Žan Doberšek.
3183
3184         Add test case to check surrounding text in multiline context.
3185
3186         * TestWebKitAPI/Tests/WebKitGLib/TestInputMethodContext.cpp:
3187         (testWebKitInputMethodContextSurrounding):
3188
3189 2020-03-08  Per Arne Vollan  <pvollan@apple.com>
3190
3191         [iOS] Mapping to UTI from tag and tag class should be performed in the UI process
3192         https://bugs.webkit.org/show_bug.cgi?id=208783
3193
3194         Reviewed by Brent Fulgham.
3195
3196         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3197
3198 2020-03-07  Ross Kirsling  <ross.kirsling@sony.com>
3199
3200         Replace the use of term "rollout" to "revert" in various tools
3201         https://bugs.webkit.org/show_bug.cgi?id=208775
3202
3203         Reviewed by Ryosuke Niwa.
3204
3205         See this webkit-dev thread for the originating discussion:
3206         https://lists.webkit.org/pipermail/webkit-dev/2020-March/031132.html
3207
3208         'rollout' is a confusing term to anyone unacquainted with WebKit;
3209         consensus seems to be that 'revert' would be the best replacement (as opposed to 'rollback').
3210
3211         Given the long legacy of this term within WebKit, it's important to deprecate and not remove 'rollout' commands.
3212         As such, this patch aims to make 'revert' the preferred term everywhere without making 'rollout' fail.
3213
3214         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js:
3215         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
3216         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3217         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
3218         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/trac_unittests.js:
3219         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3220         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
3221         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
3222         * BuildSlaveSupport/ews-build/steps.py:
3223         * BuildSlaveSupport/ews-build/steps_unittest.py:
3224         * Scripts/webkit-tools-completion.sh:
3225         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3226         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3227         * Scripts/webkitpy/common/checkout/scm/svn.py:
3228         * Scripts/webkitpy/common/net/bugzilla/attachment.py:
3229         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
3230         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3231         * Scripts/webkitpy/tool/bot/feeders.py:
3232         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3233         * Scripts/webkitpy/tool/bot/irc_command.py:
3234         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3235         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
3236         * Scripts/webkitpy/tool/bot/sheriff.py:
3237         * Scripts/webkitpy/tool/commands/download.py:
3238         * Scripts/webkitpy/tool/commands/download_unittest.py:
3239         * Scripts/webkitpy/tool/commands/newcommitbot.py:
3240         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
3241         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3242         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
3243         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3244         * Scripts/webkitpy/tool/steps/__init__.py:
3245         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
3246         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
3247         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
3248         * Scripts/webkitpy/tool/steps/reopenbugafterrevert.py: Renamed from Tools/Scripts/webkitpy/tool/steps/reopenbugafterrollout.py.
3249
3250 2020-03-07  David Quesada  <david_quesada@apple.com>
3251
3252         Crash in -[_WKRemoteObjectRegistry _invokeMethod:] block when calling a reply block after the web view has deallocated
3253         https://bugs.webkit.org/show_bug.cgi?id=208781
3254         rdar://problem/60061016
3255
3256         Reviewed by Alex Christensen.
3257
3258         Add a test that recreates the conditions of this crash:
3259         - Send a message from the injected bundle to the UI process that contains a reply block.
3260         - Hold a reference to the reply block.
3261         - Let the web view deallocate.
3262         - Call the block, and expect not to crash.
3263
3264         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
3265         (localObjectInterface):
3266         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
3267         (-[LocalObject doSomethingWithCompletionHandler:]):
3268         (TEST):
3269         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
3270         (-[RemoteObjectRegistryPlugIn callUIProcessMethodWithReplyBlock]):
3271
3272 2020-03-07  Ryosuke Niwa  <rniwa@webkit.org>
3273
3274         TextManipulationController should work with ARIA labels
3275         https://bugs.webkit.org/show_bug.cgi?id=208759
3276
3277         Reviewed by Wenson Hsieh.
3278
3279         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
3280         (TextManipulation.StartTextManipulationFindAttributeContent): Added.
3281         (TextManipulation.CompleteTextManipulationShouldPreserveOrderOfBlockImage): Updated
3282         the expected number of tokens for the first item as the very first image is correctly
3283         detected per the code change. 
3284         (TextManipulation.CompleteTextManipulationShouldReplaceAttributeContent): Added.
3285
3286 2020-03-07  Alex Christensen  <achristensen@webkit.org>
3287
3288         Regression r258042: Failing API test TestWebKitAPI.URLSchemeHandler.Frames
3289         https://bugs.webkit.org/show_bug.cgi?id=208767
3290
3291         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
3292         The frameID of the main frame before loading is only 0 on Mac right now.
3293         The test is still good because it validates that execution works in the main frame before loading.
3294
3295 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
3296
3297         [ews] commit queue is not skipping layout tests for rollout patches
3298         https://bugs.webkit.org/show_bug.cgi?id=208716
3299
3300         Unreviewed minor fix.
3301
3302         * BuildSlaveSupport/ews-build/steps.py:
3303         (RunWebKitTests.doStepIf):
3304         (RunWebKit1Tests.doStepIf): Moved to base class RunWebKitTests.
3305         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
3306
3307 2020-03-05  Sam Weinig  <weinig@apple.com>
3308
3309         Move JavaScriptCore related feature defines from FeatureDefines.xcconfig to PlatformEnableCocoa.h
3310         https://bugs.webkit.org/show_bug.cgi?id=207436
3311         <rdar://problem/59296762>
3312
3313         Reviewed by Darin Adler.
3314
3315         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3316         Remove JSC related defines.
3317
3318 2020-03-07  Chris Fleizach  <cfleizach@apple.com>
3319
3320         AX: Provide a way to run tests in isolated tree mode
3321         https://bugs.webkit.org/show_bug.cgi?id=208629
3322         <rdar://problem/60075583>
3323
3324         Reviewed by Ryosuke Niwa.
3325
3326         Provide the ability to run tests for accessibility in the isolated tree mode.
3327         This sends a flag over to the injected bundle which calls the right HIServices override so that
3328         the system thinks it is in isolated mode.
3329
3330         * Scripts/compare-webkit-configurations:
3331         (flag_for_comparison):
3332         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3333         (parse_args):
3334         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3335         (parse_args):
3336         * Scripts/webkitpy/port/driver.py:
3337         (Driver.cmd_line):
3338         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3339         (WTR::AccessibilityController::AccessibilityController):
3340         (WTR::AccessibilityController::setAccessibilityIsolatedTreeMode):
3341         (WTR::AccessibilityController::updateIsolatedTreeMode):
3342         (WTR::AccessibilityController::executeOnAXThreadIfPossible):
3343         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
3344         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3345         (WTR::InjectedBundle::didReceiveMessageToPage):
3346         (WTR::InjectedBundle::beginTesting):
3347         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3348         * WebKitTestRunner/Options.cpp:
3349         (WTR::handleOptionAccessibilityIsolatedTreeMode):
3350         (WTR::OptionsHandler::OptionsHandler):
3351         * WebKitTestRunner/Options.h:
3352         * WebKitTestRunner/TestController.cpp:
3353         (WTR::TestController::initialize):
3354         (WTR::TestController::resetPreferencesToConsistentValues):
3355         (WTR::TestController::resetStateToConsistentValues):
3356         * WebKitTestRunner/TestController.h:
3357         (WTR::TestController::accessibilityIsolatedTreeMode const):
3358
3359 2020-03-06  Per Arne Vollan  <pvollan@apple.com>
3360
3361         [Cocoa] Re-enable CFPrefs direct mode
3362         https://bugs.webkit.org/show_bug.cgi?id=208690
3363
3364         Reviewed by Brent Fulgham.
3365
3366         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3367         * TestWebKitAPI/Tests/WebKit/GrantAccessToPreferencesService.mm: Added.
3368         (TEST):
3369         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
3370         (TestWebKitAPI::TEST):
3371
3372 2020-03-06  Kate Cheney  <katherine_cheney@apple.com>
3373
3374         UIProcess needs mechanism to specify AppBound domains
3375         https://bugs.webkit.org/show_bug.cgi?id=208528
3376         <rdar://problem/59980340>
3377
3378         Reviewed by Brent Fulgham.
3379
3380         Added test app-bound domains to the plist and tested that the domains
3381         are properly stored in the website data store after a navigation.
3382
3383         * TestWebKitAPI/Info.plist:
3384         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
3385         (TEST):
3386
3387 2020-03-06  Alex Christensen  <achristensen@webkit.org>
3388
3389         Add SPI to disable cross origin access control checks
3390         https://bugs.webkit.org/show_bug.cgi?id=208748
3391
3392         Reviewed by Tim Hatcher.
3393
3394         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
3395         Add a test that verifies this SPI allows Access-Control-Allow-Origin: * with credentials.
3396
3397 2020-03-06  Basuke Suzuki  <basuke.suzuki@sony.com>
3398
3399         [webkitpy] Fix executive on Windows to run wpt server correctly
3400         https://bugs.webkit.org/show_bug.cgi?id=208693
3401
3402         Reviewed by Jonathan Bedard.
3403
3404         Bug fix for Windows environment a) fixing a typo. b) fixing path
3405         c) fix how to kill subprocesses.
3406
3407         * Scripts/webkitpy/common/system/executive.py:
3408         (Executive._windows_kill_command):
3409         (Executive.interrupt):
3410         (Executive.kill_all):
3411         * Scripts/webkitpy/port/base.py:
3412         (Port.web_platform_test_server_doc_root):
3413
3414 2020-03-06  Alex Christensen  <achristensen@webkit.org>
3415
3416         Evaluating JavaScript in main frame before loading should succeed
3417         https://bugs.webkit.org/show_bug.cgi?id=208733
3418
3419         Reviewed by Tim Horton.
3420
3421         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
3422
3423 2020-03-06  Ryosuke Niwa  <rniwa@webkit.org>
3424
3425         TextManipulationController should preserve images
3426         https://bugs.webkit.org/show_bug.cgi?id=208692
3427
3428         Reviewed by Wenson Hsieh.
3429
3430         Added tests for preserving images and their ordering.
3431
3432         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
3433         (TextManipulation.CompleteTextManipulationShouldPreserveImagesAsExcludedTokens):
3434         (TextManipulation.CompleteTextManipulationShouldPreserveSVGAsExcludedTokens):
3435         (TextManipulation.CompleteTextManipulationShouldPreserveOrderOfBlockImage):
3436
3437 2020-03-06  David Quesada  <david_quesada@apple.com>
3438
3439         Add _WKResourceLoadInfo.resourceType SPI
3440         https://bugs.webkit.org/show_bug.cgi?id=208723
3441
3442         Reviewed by Alex Christensen.
3443
3444         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
3445         (TEST):
3446
3447 2020-03-06  Jonathan Bedard  <jbedard@apple.com>
3448
3449         Stop reporting to webkit-test-results.webkit.org
3450         https://bugs.webkit.org/show_bug.cgi?id=207218
3451
3452         Reviewed by Alexey Proskuryakov.
3453
3454         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3455         (RunWebKitTests):
3456
3457 2020-03-06  Sihui Liu  <sihui_liu@apple.com>
3458
3459         UIProcess crash after using _prepareForMoveToWindow, then deallocating the WKWebView before moving to the window
3460         https://bugs.webkit.org/show_bug.cgi?id=208365
3461         <rdar://problem/59877296>
3462
3463         Reviewed by Geoffrey Garen.
3464
3465         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
3466         (TEST):
3467
3468 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
3469
3470         EWS should be able to fetch patch status for security bugs while processing them
3471         https://bugs.webkit.org/show_bug.cgi?id=206511
3472
3473         Reviewed by Alexey Proskuryakov.
3474
3475         * BuildSlaveSupport/ews-build/steps.py:
3476         (BugzillaMixin.fetch_data_from_url_with_authentication): Method to fetch data from bugzilla using api key.
3477         (BugzillaMixin.get_patch_json): 
3478         (BugzillaMixin.get_bug_json):
3479         (BugzillaMixin._is_bug_closed):
3480         (ApplyPatch.hideStepIf): Use 'sensitive' build property instead of 'validated'.
3481         (TransferToS3.hideStepIf): Ditto.
3482
3483 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
3484
3485         [ews] commit-queue should show the trac url for the commit on the build page
3486         https://bugs.webkit.org/show_bug.cgi?id=208715
3487
3488         Reviewed by Jonathan Bedard.
3489
3490         * BuildSlaveSupport/ews-build/steps.py:
3491         (PushCommitToWebKitRepo.evaluateCommand):
3492
3493 2020-03-06  Alex Christensen  <achristensen@webkit.org>
3494
3495         Fix ResourceLoadDelegate.LoadInfo API test after r257816
3496         https://bugs.webkit.org/show_bug.cgi?id=208550
3497
3498         * TestWebKitAPI/cocoa/HTTPServer.mm:
3499         (TestWebKitAPI::HTTPServer::respondToRequests):
3500         Sometimes we need a separate read to read the HTTP body after a request header, sometimes it comes in the same read.
3501         If it comes in the same read, send the response immediately.  Otherwise read the HTTP body then send the response.
3502
3503 2020-03-06  Lauro Moura <lmoura@igalia.com>
3504
3505         [WPE][WebDriver] MiniBrowser should react to close session commands
3506         https://bugs.webkit.org/show_bug.cgi?id=207529
3507
3508         Reviewed by Carlos Garcia Campos.
3509
3510         Do not call g_object_unref on the first created view if it has already
3511         been disposed in the "close" signal handler.
3512
3513         Based on original patch by Yury Semikhatsky.
3514
3515         * MiniBrowser/wpe/main.cpp:
3516         (main):
3517
3518 2020-03-06  Michael Catanzaro  <mcatanzaro@gnome.org>
3519
3520         [WPE][GTK] Use Firefox user agent quirk more aggressively on Google Docs
3521         https://bugs.webkit.org/show_bug.cgi?id=208647
3522
3523         Reviewed by Carlos Garcia Campos.
3524
3525         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3526         (TestWebKitAPI::TEST):
3527
3528 2020-03-05  Alex Christensen  <achristensen@webkit.org>
3529
3530         Add WKNavigationDelegatePrivate SPI to inform application of subframe navigations
3531         https://bugs.webkit.org/show_bug.cgi?id=208670
3532
3533         Reviewed by Brady Eidson.
3534
3535         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
3536         (-[FrameNavigationDelegate waitForNavigations:]):
3537         (-[FrameNavigationDelegate requests]):
3538         (-[FrameNavigationDelegate frames]):
3539         (-[FrameNavigationDelegate callbacks]):
3540         (-[FrameNavigationDelegate _webView:didStartProvisionalLoadWithRequest:inFrame:]):
3541         (-[FrameNavigationDelegate _webView:didFailProvisionalLoadWithRequest:inFrame:withError:]):
3542         (-[FrameNavigationDelegate _webView:didCommitLoadWithRequest:inFrame:]):
3543         (-[FrameNavigationDelegate _webView:didFailLoadWithRequest:inFrame:withError:]):
3544         (-[FrameNavigationDelegate _webView:didFinishLoadWithRequest:inFrame:]):
3545         (TEST):
3546
3547 2020-03-05  Alex Christensen  <achristensen@webkit.org>
3548
3549         Add WKFrameInfo._parentFrameHandle SPI
3550         https://bugs.webkit.org/show_bug.cgi?id=208674
3551
3552         Reviewed by Brady Eidson.
3553
3554         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
3555
3556 2020-03-05  Jiewen Tan  <jiewen_tan@apple.com>
3557
3558         [WebAuthn] Implement SPI -[_WKWebAuthenticationPanelDelegate panel:selectAssertionResponse:source:completionHandler:]
3559         https://bugs.webkit.org/show_bug.cgi?id=208626
3560         <rdar://problem/60074148>
3561
3562         Reviewed by Brent Fulgham.
3563
3564         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3565         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
3566         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:source:completionHandler:]):
3567         (TestWebKitAPI::TEST):
3568         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:completionHandler:]): Deleted.
3569         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-multiple-accounts.html:
3570         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Added.
3571
3572 2020-03-05  Antoine Quint  <graouts@apple.com>
3573
3574         Page-specific UserStyleSheets should wait until the initial empty document has been removed to be injected
3575         https://bugs.webkit.org/show_bug.cgi?id=208644
3576         <rdar://problem/60042429>
3577
3578         Reviewed by Brady Eidson.
3579
3580         Add new tests for -[_WKUserStyleSheet initWithSource:forWKWebView:forMainFrameOnly:userContentWorld:]) that check:
3581         
3582         1. that a _WKUserStyleSheet can be added immediately after a WKWebView's creation and will be injected once the initial
3583            empty document has been removed in favor of the document for the requested URL,
3584         2. that removing a _WKUserStyleSheet immediately after it was added but before the initial empty document was removed
3585            correctly does not injected the style sheet.
3586
3587         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
3588
3589 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
3590
3591         [ews] Add build step to push commit to WebKit repository
3592         https://bugs.webkit.org/show_bug.cgi?id=208589
3593
3594         Reviewed by Jonathan Bedard.
3595
3596         * BuildSlaveSupport/ews-build/steps.py:
3597         (PushCommitToWebKitRepo): Build step to push the local commit to WebKit repository.
3598         (PushCommitToWebKitRepo.start): Initialize log observer.
3599         (PushCommitToWebKitRepo.evaluateCommand): Check command return status and comment on bug accordingly.
3600         (PushCommitToWebKitRepo.comment_text_for_bug): Generate comment text for commenting on bug.
3601         (PushCommitToWebKitRepo.svn_revision_from_commit_text): Extract the svn revision from commit text.
3602         (PushCommitToWebKitRepo.getResultSummary): Set custom failure message.
3603         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3604         * BuildSlaveSupport/ews-build/factories.py:
3605
3606 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
3607
3608         [ews] Add unit tests for ValidateCommiterAndReviewer build step
3609         https://bugs.webkit.org/show_bug.cgi?id=208262
3610
3611         Reviewed by Jonathan Bedard.
3612
3613         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests for ValidateCommiterAndReviewer.
3614
3615 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
3616
3617         commit-queue should run WK2 tests instead of WK1 tests
3618         https://bugs.webkit.org/show_bug.cgi?id=208544
3619
3620         Reviewed by Jonathan Bedard.
3621
3622         * BuildSlaveSupport/ews-build/factories.py:
3623
3624 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
3625
3626         [ews] ValidateCommiterAndReviewer should validate emails in case insensitive manner
3627         https://bugs.webkit.org/show_bug.cgi?id=208645
3628
3629         Reviewed by Alexey Proskuryakov.
3630
3631         * BuildSlaveSupport/ews-build/steps.py:
3632         (ValidateCommiterAndReviewer.load_contributors):
3633         (ValidateCommiterAndReviewer.start):
3634
3635 2020-03-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3636
3637         style-checker: Add UAF to the list of security words to warn about.
3638         https://bugs.webkit.org/show_bug.cgi?id=208643
3639
3640         Reviewed by Jonathan Bedard.
3641
3642         UAF is a common acronym used for use after free.
3643
3644         * Scripts/webkitpy/style/checkers/changelog.py:
3645         (ChangeLogChecker.check_for_unwanted_security_phrases):
3646
3647 2020-03-04  Basuke Suzuki  <basuke.suzuki@sony.com>
3648
3649         [MSVC] Add .natvis support of WebKit types
3650         https://bugs.webkit.org/show_bug.cgi?id=193119
3651
3652         Reviewed by Don Olmstead.
3653
3654         To help the WebKit developer while debugging, this file defines how
3655         WebKit types are displayed in debugger of Visual Studio.
3656         Very limited set of WebKit types, but it changes the world.
3657
3658         * VisualStudio/WebKit.natvis: Added.
3659
3660 2020-03-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3661
3662         Add system trace points around display list replay
3663         https://bugs.webkit.org/show_bug.cgi?id=208616
3664
3665         Reviewed by Simon Fraser.
3666
3667         Add a new "Display list replay" trace point.
3668
3669         * Tracing/SystemTracePoints.plist:
3670
3671 2020-03-04  Alex Christensen  <achristensen@webkit.org>
3672
3673         Call globalObjectIsAvailableForFrame before evaluating JavaScript in newly created worlds
3674         https://bugs.webkit.org/show_bug.cgi?id=208615
3675         <rdar://problem/59406743>
3676
3677         Reviewed by Alex Christensen.
3678
3679         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3680         * TestWebKitAPI/Tests/WebKitCocoa/ContentWorldPlugIn.mm: Added.
3681         (-[ContentWorldPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3682         (-[ContentWorldPlugIn webProcessPlugInBrowserContextController:globalObjectIsAvailableForFrame:inScriptWorld:]):
3683         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
3684         (TEST):
3685         Also make a test written in bug 206310 actually run code.
3686
3687 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
3688
3689         [build.webkit.org] Remove leaks queue
3690         https://bugs.webkit.org/show_bug.cgi?id=208580
3691
3692         Reviewed by Jonathan Bedard.
3693
3694         * BuildSlaveSupport/build.webkit.org-config/config.json:
3695         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3696         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3697
3698 2020-03-04  Alex Christensen  <achristensen@webkit.org>
3699
3700         Add SPI to evaluate JavaScript in an iframe
3701         https://bugs.webkit.org/show_bug.cgi?id=208605
3702
3703         Reviewed by Brady Eidson.
3704
3705         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
3706
3707 2020-03-03  Jiewen Tan  <jiewen_tan@apple.com>
3708
3709         [WebAuthn] Implement -[_WKWebAuthenticationPanelDelegate panel:decidePolicyForLocalAuthenticatorWithCompletionHandler:] SPI
3710         https://bugs.webkit.org/show_bug.cgi?id=208533
3711         <rdar://problem/60010184>
3712
3713         Reviewed by Alex Christensen.
3714
3715         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3716         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
3717         (-[TestWebAuthenticationPanelDelegate panel:decidePolicyForLocalAuthenticatorWithCompletionHandler:]):
3718         (TestWebKitAPI::TEST):
3719         (-[TestWebAuthenticationPanelDelegate panel:verifyUserWithAccessControl:completionHandler:]): Deleted.
3720         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Removed.
3721
3722 2020-03-04  Alex Christensen  <achristensen@webkit.org>
3723
3724         callAsyncJavaScript with an invalid parameter and no completionHandler should not crash
3725         https://bugs.webkit.org/show_bug.cgi?id=208593
3726
3727         Reviewed by Brady Eidson.
3728
3729         * TestWebKitAPI/Tests/WebKitCocoa/AsyncFunction.mm:
3730         (TestWebKitAPI::TEST):
3731
3732 2020-03-04  Alex Christensen  <achristensen@webkit.org>
3733
3734         WKWebView's frames accessor should return a traversable type
3735         https://bugs.webkit.org/show_bug.cgi?id=208591
3736
3737         Reviewed by Brady Eidson.
3738
3739         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
3740
3741 2020-03-04  Antoine Quint  <graouts@apple.com>
3742
3743         Add an SPI to allow UserStyleSheet injection to target a specific WKWebView
3744         https://bugs.webkit.org/show_bug.cgi?id=208575
3745         <rdar://problem/59773690>
3746
3747         Reviewed by Brady Eidson.
3748
3749         Add new tests for the new SPI which check:
3750         
3751         1. that specifying forWKWebView: when initializing a _WKUserStyleSheet will inject the provided CSS source in the
3752            specified WKWebView alone,
3753         2. that the same test works with two WKWebViews with a shared WKWebKitConfiguration,
3754         3. that a WKWebView-specific _WKUserStyleSheet can be removed,
3755         4. that a WKWebView-specific _WKUserStyleSheet can be added twice and removed once and be removed as expected,
3756         5. and that a WKWebView-specific _WKUserStyleSheet is automatically removed when navigating to a new page,
3757         6. and that the same test also works with PSON enabled.
3758
3759         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
3760
3761 2020-03-04  Ryan Haddad  <ryanhaddad@apple.com>
3762
3763         [macOS] test-lldb-webkit failing on debug bots
3764         https://bugs.webkit.org/show_bug.cgi?id=208545
3765
3766         Reviewed by Jonathan Bedard.
3767
3768         The lldb-webkit-test step must pass in the build configuration as an
3769         argument to the test-lldb-webkit script so that it uses the lldbWebKitTester
3770         binary that is downloaded with the rest of the build products. Without this
3771         argument, the bots expect to find the binary in the 'WebKitBuild/Release' directory
3772         regardless of their actual build configuration.
3773
3774         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3775         (RunLLDBWebKitTests): Pass in the build configuration to the test-lldb-webkit script.
3776         * Scripts/test-lldb-webkit:
3777         (LldbTester.parse_args): Capitalize the constants for Debug / Release since that is what webkitpy expects.
3778
3779 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
3780
3781         [ews] Add build step to create local git commit for commit-queue (follow-up fix)
3782         https://bugs.webkit.org/show_bug.cgi?id=208539
3783
3784         Unreviewed follow-up fix.
3785
3786         * BuildSlaveSupport/ews-build/steps.py:
3787
3788 2020-03-04  Daniel Bates  <dabates@apple.com>
3789
3790         Should use -bounds instead of -frame in RequestTextInputContext.mm tests
3791         https://bugs.webkit.org/show_bug.cgi?id=208565
3792
3793         Reviewed by Wenson Hsieh.
3794
3795         Pass the bounds of the web view to -synchronouslyRequestTextInputContextsInRect: instead
3796         of its frame as a means to find all the editable elements in the visible content area
3797         of the web view.
3798
3799         Coincidentally this makes no difference to the test results right now because the web view
3800         happens to be located at the origin (0, 0) in the window. However if in the future the
3801         web view would be located at some other point then the tests may fail because the rectangle
3802         passed to -synchronouslyRequestTextInputContextsInRect: would no longer represent the
3803         rectangle for the visible content area.
3804
3805         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3806         (TEST):
3807
3808 2020-03-04  Daniel Bates  <dabates@apple.com>
3809
3810         Organize tests in RequestTextInputContext.mm tests under test name RequestTextInputContext
3811         https://bugs.webkit.org/show_bug.cgi?id=208564
3812
3813         Reviewed by Alex Christensen.
3814
3815         Group the tests in RequestTextInputContext.mm under the test case name RequestTextInputContext
3816         to make it easy to run just these tests.
3817
3818         Currently, the tests are organized under the test case name WebKit. This means you need to
3819         pass run-api-tests the name of each sub-test as there is no easy way to run them all without
3820         also running all the TestWebKitAPI.WebKit sub-tests. Instead organize them under RequestTextInputContext
3821         so that a person can run just these test using:
3822         
3823                 run-api-tests --debug TestWebKitAPI.RequestTextInputContext
3824
3825         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3826         (TEST):
3827
3828 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
3829
3830         [ews] Add build step to create local git commit for commit-queue
3831         https://bugs.webkit.org/show_bug.cgi?id=208539
3832
3833         Reviewed by Jonathan Bedard.
3834
3835         * BuildSlaveSupport/ews-build/steps.py:
3836         (CreateLocalGITCommit): Build step to create local git commit.
3837         (CreateLocalGITCommit.start):
3838         (CreateLocalGITCommit.getResultSummary): Set custom failure message.
3839         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests and restructured imports.
3840         * BuildSlaveSupport/ews-build/factories.py:
3841
3842 2020-03-04  Simon Fraser  <simon.fraser@apple.com>
3843
3844         (r256513) [ Mac ] fast/scrolling/programmatic-scroll-to-zero-zero.html is a flaky failure
3845         https://bugs.webkit.org/show_bug.cgi?id=207948
3846
3847         Reviewed by Zalan Bujtas.
3848
3849         EventSendingController needs to trigger layout so that the WebHTMLView is not 0x0,
3850         so that it receives the wheel events.
3851
3852         * DumpRenderTree/mac/EventSendingController.mm:
3853         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
3854         * DumpRenderTree/win/EventSender.cpp:
3855         (mouseScrollBy):
3856
3857 2020-03-04  Andres Gonzalez  <andresg_22@apple.com>
3858
3859         REGRESSION (r257739): two fast/events/autoscroll test have started to fail
3860         https://bugs.webkit.org/show_bug.cgi?id=208520
3861         <rdar://problem/60000214>
3862
3863         Reviewed by Chris Fleizach.
3864
3865         Calling InjectedBundle::singleton().page()->page() in the constructor
3866         of the AccessibilityController is having this side effect on iOS.
3867         So #if to MAC where it's actually being used.
3868
3869         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3870         (WTR::AccessibilityController::AccessibilityController):
3871
3872 2020-03-03  Alex Christensen  <achristensen@webkit.org>
3873
3874         Add SPI _WKResourceLoadInfo.loadedFromCache
3875         https://bugs.webkit.org/show_bug.cgi?id=208554
3876
3877         Reviewed by Wenson Hsieh.
3878
3879         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
3880         (TEST):
3881
3882 2020-03-03  Ryosuke Niwa  <rniwa@webkit.org>
3883
3884         Batch observations and completions of text manipulations
3885         https://bugs.webkit.org/show_bug.cgi?id=208406
3886
3887         Reviewed by Wenson Hsieh.
3888
3889         Updated the existing tests to use new APIs, and added new tests for batching finding & replacing
3890         multiple paragraphs at once.
3891
3892         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
3893         (-[TextManipulationDelegate _webView:didFindTextManipulationItems:]):
3894         (-[TextManipulationDelegate items]):
3895         (-[LegacyTextManipulationDelegate init]):
3896         (-[LegacyTextManipulationDelegate _webView:didFindTextManipulationItem:]):
3897         (TextManipulation.StartTextManipulationSupportsLegacyDelegateCallback): Added.
3898         (TextManipulation.LegacyCompleteTextManipulationReplaceSimpleSingleParagraph): Added.
3899         (TextManipulation.CompleteTextManipulationReplaceMultipleSimpleParagraphsAtOnce): Added.
3900         (TextManipulation.CompleteTextManipulationShouldBatchItemCallback): Added.
3901         (TextManipulation.CompleteTextManipulationFailWhenItemIdentifierIsDuplicated): Added.
3902         (TextManipulation.CompleteTextManipulationCanHandleSubsetOfItemsToFail): Added.
3903
3904 2020-03-03  Per Arne Vollan  <pvollan@apple.com>
3905
3906         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
3907         https://bugs.webkit.org/show_bug.cgi?id=208415
3908
3909         Reviewed by Brent Fulgham.
3910
3911         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3912         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
3913         (TEST):
3914
3915 2020-03-03  Alex Christensen  <achristensen@webkit.org>
3916
3917         Add response to _WKResourceLoadDelegate didCompleteWithError callback
3918         https://bugs.webkit.org/show_bug.cgi?id=208553
3919
3920         Reviewed by Simon Fraser.
3921
3922         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
3923         (-[TestResourceLoadDelegate webView:resourceLoad:didCompleteWithError:response:]):
3924         (TEST):
3925         (-[TestResourceLoadDelegate webView:resourceLoad:didCompleteWithError:]): Deleted.
3926
3927 2020-03-03  Brady Eidson  <beidson@apple.com>
3928
3929         API Test [Mojave+ WK2 Debug ] TestWebKitAPI.WKAttachmentTestsMac.InsertDroppedFilePromisesAsAttachments is a flaky crash.
3930         https://bugs.webkit.org/show_bug.cgi?id=198795
3931
3932         Reviewed by Chris Dumez.
3933
3934         This test appears to no longer be flaky.
3935         
3936         Let's re-enable it.
3937         
3938         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3939         (TestWebKitAPI::TEST):
3940
3941 2020-03-03  Alex Christensen  <achristensen@webkit.org>
3942
3943         Requests sent to _WKResourceLoadDelegate should include HTTPBody
3944         https://bugs.webkit.org/show_bug.cgi?id=208550
3945
3946         Reviewed by Tim Hatcher.
3947
3948         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
3949         (TEST):
3950         * TestWebKitAPI/cocoa/HTTPServer.mm:
3951         (TestWebKitAPI::HTTPServer::respondToRequests):
3952         HTTPServer now looks for Content-Length in its request.
3953         If it finds this header, that means that the HTTP body is going to be received in another read, then the response should be sent after receiving that.
3954
3955 2020-03-03  Alex Christensen  <achristensen@webkit.org>
3956
3957         Expose originalURL and originalHTTPMethod on _WKResourceLoadInfo
3958         https://bugs.webkit.org/show_bug.cgi?id=208522
3959
3960         Reviewed by Brian Weinstein.
3961
3962         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
3963         (TEST):
3964
3965 2020-03-03  Aakash Jain  <aakash_jain@apple.com>
3966
3967         commit-queue should update working directory and reapply patch just before commiting
3968         https://bugs.webkit.org/show_bug.cgi?id=208521
3969
3970         Reviewed by Jonathan Bedard.
3971
3972         * BuildSlaveSupport/ews-build/factories.py:
3973
3974 2020-03-03  Matt Lewis  <jlewis3@apple.com>
3975
3976         Add Unittest to commits_for_upload() and fix multiple unittests for several test suites.
3977         https://bugs.webkit.org/show_bug.cgi?id=208485
3978
3979         Reviewed by Jonathan Bedard.
3980
3981         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
3982         (StubRepository.__init__): Fixing the constructor to call upon the parent class as we were not doing this before. It also means
3983         that we don't have to recreate the variables that are already created.
3984         * Scripts/webkitpy/common/checkout/scm/stub_repository_unittest.py: High level changed the imports to better reflect what we are using
3985         from each module, rather than making extra imports that we don't need.
3986         (StubRepositoryTest.mock_host_for_stub_repository): Since we are calling both an executive and a filesystem mock for most of the
3987         tests. it makes more sense to create a mock host with the files needed, than it does to instantiate each of these as separate objects
3988         and not part of the host.
3989         (StubRepositoryTest.test_in_working_directory): Changed the filesystem call to the host call.
3990         (StubRepositoryTest.test_native_revision): Changed the filesystem call to the host call.
3991         (StubRepositoryTest.test_native_branch): Changed the filesystem call to the host call.
3992         (StubRepositoryTest.test_svn_revision): Changed the filesystem call to the host call.
3993         (StubRepositoryTest.test_find_checkout_root): Changed the filesystem call to the host call.
3994         (StubRepositoryTest.test_find_checkout_root_failure): Changed the filesystem call to the host call.
3995         (StubRepositoryTest.test_find_parent_path_matching_callback_condition_with_file_system): Changed the filesystem call to the host call.
3996         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py: 
3997         (SummarizedResultsTest.test_svn_revision_exists): Changed the name to original test to better reflect that it was just looking to see
3998         if we were geting any value at all
3999         (SummarizedResultsTest.test_svn_revision): Added a test to make sure that the revision we are getting is what we expect to get and make
4000         sure we aren't gabking the wrong key:value pair
4001         * Scripts/webkitpy/port/base_unittest.py: Changed from MockSystemHost to MockHost as we want the extras that
4002         come with the MockHosts and MockHost inherits from MockSystemHost.
4003         (PortTest.make_port): Changed the port to call MockHost that will creat the required stub_repository files.
4004         (test_commits_for_upload): Added amissing test for commits_for_upload as this has been an issue when trying to make changes
4005         to the various upload steps.
4006
4007 2020-03-03  Aakash Jain  <aakash_jain@apple.com>
4008
4009         [ews] Add build step to find list of modified changelogs
4010         https://bugs.webkit.org/show_bug.cgi?id=208514
4011
4012         Reviewed by Jonathan Bedard.
4013
4014         * BuildSlaveSupport/ews-build/factories.py:
4015         * BuildSlaveSupport/ews-build/steps.py:
4016         (FindModifiedChangeLogs): Build step to find modified ChangeLogs.
4017         (FindModifiedChangeLogs.start): Initialize log observer.
4018         (FindModifiedChangeLogs.getResultSummary): Set custom failure message.
4019         (FindModifiedChangeLogs.evaluateCommand):
4020         (FindModifiedChangeLogs.is_path_to_changelog): Check if the file is a ChangeLog.
4021         (FindModifiedChangeLogs._status_regexp): Regex to match files from git output.
4022         (FindModifiedChangeLogs.extract_changelogs): Method to get list of ChangeLogs from git output.
4023         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
4024
4025 2020-03-03  Ryan Haddad  <ryanhaddad@apple.com>
4026
4027         [iOS EWS] TestWebKitAPI.WKWebsiteDataStore.RemoveAndFetchData is failing
4028         https://bugs.webkit.org/show_bug.cgi?id=208451
4029
4030         Unreviewed test gardening.
4031
4032         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm: Disable the test for iOS since it is slowing down EWS.
4033
4034 2020-03-03  Jiten Mehta  <jmehta@apple.com>
4035
4036         Adopt HTTP Alternative Services Storage
4037         https://bugs.webkit.org/show_bug.cgi?id=208387
4038
4039         Reviewed by Alex Christensen.
4040
4041         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
4042         (checkUntilEntryFound):
4043         (TEST):
4044
4045 2020-03-03  Kate Cheney  <katherine_cheney@apple.com>
4046
4047         Check for navigation to app-bound domain during script evaluation
4048         https://bugs.webkit.org/show_bug.cgi?id=208319
4049         <rdar://problem/57569321>
4050
4051         Reviewed by Brent Fulgham.
4052
4053         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4054         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm: Added.
4055         (-[TestInAppBrowserScriptMessageHandler userContentController:didReceiveScriptMessage:]):
4056         (TEST):
4057         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-agent-script.html: Added.
4058         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-script.html: Added.
4059
4060 2020-03-03  Commit Queue  <commit-queue@webkit.org>
4061
4062         Unreviewed, rolling out r257754.
4063         https://bugs.webkit.org/show_bug.cgi?id=208513
4064
4065         Introduced API test failure (Requested by perarne on #webkit).
4066
4067         Reverted changeset:
4068
4069         "[Cocoa] Mapping from MIME type to UTI type should be done in
4070         the UI process"
4071         https://bugs.webkit.org/show_bug.cgi?id=208415
4072         https://trac.webkit.org/changeset/257754
4073
4074 2020-03-03  Diego Pino Garcia  <dpino@igalia.com>
4075
4076         REGRESSION(r257726): [GTK] LayoutTests crashing after r257726
4077         https://bugs.webkit.org/show_bug.cgi?id=208506
4078
4079         Reviewed by Carlos Garcia Campos.
4080
4081         * WebKitTestRunner/TestController.cpp:
4082         (WTR::TestController::platformAdjustContext): Remove unnecessary code.
4083
4084 2020-03-02  Ben Nham  <nham@apple.com>
4085
4086         Add performance probes for HTML parsing
4087         https://bugs.webkit.org/show_bug.cgi?id=208271
4088
4089         Reviewed by Daniel Bates.
4090
4091         This adds probes that show which lines of HTML are have been parsed.
4092
4093         * Tracing/SystemTracePoints.plist:
4094
4095 2020-03-02  Per Arne Vollan  <pvollan@apple.com>
4096
4097         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
4098         https://bugs.webkit.org/show_bug.cgi?id=208415
4099
4100         Reviewed by Brent Fulgham.
4101
4102         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4103         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
4104         (TEST):
4105
4106 2020-03-02  Jacob Uphoff  <jacob_uphoff@apple.com>
4107
4108         Unreviewed, rolling out r257725.
4109
4110         This commit caused 10 API tests to fail
4111
4112         Reverted changeset:
4113
4114         "[Cocoa] Mapping from MIME type to UTI type should be done in
4115         the UI process"
4116         https://bugs.webkit.org/show_bug.cgi?id=208415
4117         https://trac.webkit.org/changeset/257725
4118
4119 2020-03-02  Saam Barati  <sbarati@apple.com>
4120
4121         Don't skip tests unnecessarily on arm64
4122         https://bugs.webkit.org/show_bug.cgi?id=208470
4123         <rdar://problem/59968869>
4124
4125         Reviewed by Tadeu Zagallo.
4126
4127         * Scripts/run-jsc-stress-tests:
4128
4129 2020-03-02  Andres Gonzalez  <andresg_22@apple.com>
4130
4131         Fix for LayoutTests/accessibility/mac/search-text/search-text.html in IsolatedTree mode.
4132         https://bugs.webkit.org/show_bug.cgi?id=208434
4133
4134         Reviewed by Chris Fleizach.
4135
4136         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
4137         (WTR::AccessibilityController::AccessibilityController): Initializes m_useAXThread.
4138         (WTR::AccessibilityController::rootElement): No need to set m_useAXThread here since it is initialize in the constructor.
4139         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
4140         (WTR::AccessibilityController::accessibleElementById): Same as above.
4141
4142 2020-03-02  John Wilander  <wilander@apple.com>
4143
4144         ResourceLoadStatistics: Enable cookie blocking and the Storage Access API in ephemeral sessions
4145         https://bugs.webkit.org/show_bug.cgi?id=208399
4146         <rdar://problem/24731650>
4147
4148         Reviewed by Brent Fulgham.
4149
4150         The majority of the changes in WTR::TestController is (partially) fixing a bug
4151         where the TestRunner would statically use the default website datastore instead
4152         of the website data store configure for the page. This worked for persistent
4153         storage testing but not for ephemeral sessions which is what this patch is all
4154         about. The previous TestController::websiteDataStore() is now called
4155         TestController::defaultWebsiteDataStore() and the new
4156         TestController::websiteDataStore() returns the configured website data store.
4157         Most of the use of the default website data store should probably change but
4158         that's not really for this patch to deal with. I did however move all of
4159         resource load statistics' use to the new TestController::websiteDataStore().
4160
4161         A new TestRunner function was added: isStatisticsEphemeral()
4162         It allows test cases to query the ephemeral status of resource load statistics.
4163
4164         One problem that is mitigated in this patch but not fully fixed is that for
4165         Cocoa platforms, the TestRunner sets up two ephemeral sessions, once in
4166         TestController::generatePageConfiguration() via C API 
4167         WKPageConfigurationSetWebsiteDataStore(), and then again in 
4168         TestControllerCocoa's initializeWebViewConfiguration() via Cocoa API
4169         [copiedConfiguration setWebsiteDataStore:ephemeralWebsiteDataStore].
4170         I tried removing the latter since one session for all platforms should be
4171         Enough but got broken behavior as a result. So now both are still there
4172         and both enable resource load statistics.
4173
4174         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4175         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4176         (WTR::TestRunner::isStatisticsEphemeral):
4177         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4178         * WebKitTestRunner/TestController.cpp:
4179         (WTR::TestController::defaultWebsiteDataStore):
4180         (WTR::TestController::websiteDataStore):
4181         (WTR::TestController::generatePageConfiguration):
4182         (WTR::TestController::resetPreferencesToConsistentValues):
4183         (WTR::TestController::resetStateToConsistentValues):
4184         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
4185         (WTR::TestController::decidePolicyForNavigationAction):
4186         (WTR::TestController::platformAdjustContext):
4187         (WTR::TestController::clearServiceWorkerRegistrations):
4188         (WTR::TestController::clearDOMCache):
4189         (WTR::TestController::clearDOMCaches):
4190         (WTR::TestController::clearIndexedDatabases):
4191         (WTR::TestController::clearLocalStorage):
4192         (WTR::TestController::hasDOMCache):
4193         (WTR::TestController::domCacheSize):
4194         (WTR::TestController::setStatisticsEnabled):
4195         (WTR::TestController::isStatisticsEphemeral):
4196         (WTR::TestController::setStatisticsDebugMode):
4197         (WTR::TestController::setStatisticsPrevalentResourceForDebugMode):
4198         (WTR::TestController::setStatisticsLastSeen):
4199         (WTR::TestController::setStatisticsMergeStatistic):
4200         (WTR::TestController::setStatisticsPrevalentResource):
4201         (WTR::TestController::setStatisticsVeryPrevalentResource):
4202         (WTR::TestController::dumpResourceLoadStatistics):
4203         (WTR::TestController::isStatisticsPrevalentResource):
4204         (WTR::TestController::isStatisticsVeryPrevalentResource):
4205         (WTR::TestController::isStatisticsRegisteredAsSubresourceUnder):
4206         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
4207         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
4208         (WTR::TestController::setStatisticsHasHadUserInteraction):
4209         (WTR::TestController::isStatisticsHasHadUserInteraction):
4210         (WTR::TestController::isStatisticsOnlyInDatabaseOnce):
4211         (WTR::TestController::setStatisticsGrandfathered):
4212         (WTR::TestController::isStatisticsGrandfathered):
4213         (WTR::TestController::setUseITPDatabase):
4214         (WTR::TestController::setStatisticsSubframeUnderTopFrameOrigin):
4215         (WTR::TestController::setStatisticsSubresourceUnderTopFrameOrigin):
4216         (WTR::TestController::setStatisticsSubresourceUniqueRedirectTo):
4217         (WTR::TestController::setStatisticsSubresourceUniqueRedirectFrom):
4218         (WTR::TestController::setStatisticsTopFrameUniqueRedirectTo):
4219         (WTR::TestController::setStatisticsTopFrameUniqueRedirectFrom):
4220         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
4221         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
4222         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
4223         (WTR::TestController::statisticsUpdateCookieBlocking):
4224         (WTR::TestController::statisticsSubmitTelemetry):
4225         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
4226         (WTR::TestController::setStatisticsIsRunningTest):
4227         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
4228         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
4229         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
4230         (WTR::TestController::setStatisticsGrandfatheringTime):
4231         (WTR::TestController::setStatisticsMaxStatisticsEntries):
4232         (WTR::TestController::setStatisticsPruneEntriesDownTo):
4233         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
4234         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
4235         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
4236         (WTR::TestController::statisticsDeleteCookiesForHost):
4237         (WTR::TestController::isStatisticsHasLocalStorage):
4238         (WTR::TestController::setStatisticsCacheMaxAgeCap):
4239         (WTR::TestController::hasStatisticsIsolatedSession):
4240         (WTR::TestController::setStatisticsShouldDowngradeReferrer):
4241         (WTR::TestController::setStatisticsShouldBlockThirdPartyCookies):
4242         (WTR::TestController::setStatisticsFirstPartyWebsiteDataRemovalMode):
4243         (WTR::TestController::statisticsResetToConsistentState):
4244         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
4245         * WebKitTestRunner/TestController.h:
4246         * WebKitTestRunner/TestInvocation.cpp:
4247         (WTR::TestInvocation::invoke):
4248         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4249         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4250         (WTR::initializeWebViewConfiguration):
4251         (WTR::TestController::platformCreateWebView):
4252
4253 2020-03-02  Per Arne Vollan  <pvollan@apple.com>
4254
4255         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
4256         https://bugs.webkit.org/show_bug.cgi?id=208415
4257
4258         Reviewed by Brent Fulgham.
4259
4260         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4261         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
4262         (TEST):
4263
4264 2020-03-02  Daniel Bates  <dabates@apple.com>
4265
4266         Page::editableElementsInRect() should find nested editable elements and return found elements in paint order
4267         https://bugs.webkit.org/show_bug.cgi?id=208352
4268         <rdar://problem/59867815>
4269
4270         Reviewed by Wenson Hsieh.
4271
4272         Update test results to reflect the new behavior. To do this I also need to fix up the test code
4273         to actually scroll the web content. This also means we now execute the same code on both Mac and
4274         iOS to do the scrolling: window.scrollTo(0, 5000). Also fixed up sub-test "Inputs scrolled outside
4275         the requested rect; should not be included." to use a 10000px height <div> so that you can scroll
4276         to a y position of 5000. Otherwise, it's impossible to do because the page height is < 5000px.
4277
4278         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
4279         (TEST):
4280
4281 2020-03-02  Jacob Uphoff  <jacob_uphoff@apple.com>
4282
4283         Unreviewed, rolling out r257687.
4284
4285         This commit caused debug tests to crash for macOS & iOS
4286
4287         Reverted changeset:
4288
4289         "[Cocoa] Mapping from MIME type to UTI type should be done in
4290         the UI process"
4291         https://bugs.webkit.org/show_bug.cgi?id=208415
4292         https://trac.webkit.org/changeset/257687
4293
4294 2020-03-01  Wenson Hsieh  <wenson_hsieh@apple.com>
4295
4296         Unreviewed, rolling out r257618.
4297
4298         This allegedly causes Safari to crash when closing a window
4299         (see rdar://problem/59922725).
4300
4301         Reverted changeset:
4302
4303         "UIProcess crash after using _prepareForMoveToWindow, then
4304         deallocating the WKWebView before moving to the window"
4305         https://bugs.webkit.org/show_bug.cgi?id=208365
4306         https://trac.webkit.org/changeset/257618
4307
4308 2020-02-29  Yusuke Suzuki  <ysuzuki@apple.com>
4309
4310         Remove std::lock_guard
4311         https://bugs.webkit.org/show_bug.cgi?id=206451
4312
4313         Reviewed by Anders Carlsson.
4314
4315         Add std::lock_guard lint rule to prevent from using it.
4316
4317         * Scripts/webkitpy/style/checkers/cpp.py:
4318         (check_lock_guard):
4319         (check_style):
4320         (CppChecker):
4321         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4322         (WebKitStyleTest.test_lock_guard):
4323         * TestWebKitAPI/Tests/WTF/Condition.cpp:
4324         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
4325         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
4326         (assertHasObjects):
4327         (assertHasOnlyObjects):
4328         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
4329         (WTR::AXThread::dispatch):
4330         (WTR::AXThread::dispatchFunctionsFromAXThread):
4331         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
4332         (WTR::AXThread::initializeRunLoop):
4333
4334 2020-02-29  Per Arne Vollan  <pvollan@apple.com>
4335
4336         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
4337         https://bugs.webkit.org/show_bug.cgi?id=208415
4338
4339         Reviewed by Brent Fulgham.
4340
4341         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4342         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
4343         (TEST):
4344
4345 2020-02-28  Fujii Hironori  <Hironori.Fujii@sony.com>
4346
4347         Unreviewed, rolling out r257565.
4348
4349         It broke WinCa