[GTK] gtkdoc does not appear in DevHelp
[WebKit-https.git] / Tools / ChangeLog
1 2015-01-26  Michael Catanzaro  <mcatanzaro@igalia.com> and Carlos Garcia Campos  <cgarcia@igalia.com>
2
3         [GTK] gtkdoc does not appear in DevHelp
4         https://bugs.webkit.org/show_bug.cgi?id=139369
5
6         Reviewed by Philippe Normand.
7
8         * gtk/generate-gtkdoc: Create the generators in the main function
9         and use them to get the local cross renference dependencies. Also
10         pass the generator module name to webkitdom.write_doc_files().
11         (get_gtkdoc_module_paths): Receive a list of local cross reference
12         dependencies.
13         (get_generator_for_config): Set the main_sgml_file property of the
14         GtkDoc object from the configuration file.
15         (generate_documentation): Generate the documentation for the given
16         generator.
17         (generate_documentation_for_config): Deleted.
18         * gtk/manifest.txt.in: Expect the API version in the gtkdoc filenames.
19         * gtk/webkitdom.py:
20         (write_doc_files): Receive the module name used to build the
21         -sections.txt filename.
22
23 2015-01-26  Commit Queue  <commit-queue@webkit.org>
24
25         Unreviewed, rolling out r179107.
26         https://bugs.webkit.org/show_bug.cgi?id=140880
27
28         The GCC in the bots doesn't support the AsyncTask
29         implementation (Requested by KaL on #webkit).
30
31         Reverted changeset:
32
33         "[GTK] Enable IndexedDB"
34         https://bugs.webkit.org/show_bug.cgi?id=98932
35         http://trac.webkit.org/changeset/179107
36
37 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
38
39         [EFL] Bump libseccomp version to 2.1.1
40         https://bugs.webkit.org/show_bug.cgi?id=140357
41
42         Reviewed by Gyuyoung Kim.
43
44         * efl/jhbuild.modules:
45
46 2015-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
47
48         [GTK] Enable IndexedDB
49         https://bugs.webkit.org/show_bug.cgi?id=98932
50
51         Reviewed by Žan Doberšek.
52
53         * Scripts/webkitperl/FeatureList.pm: Enable IndexedDB for the GTK port.
54
55 2015-01-25  Alexey Proskuryakov  <ap@apple.com>
56
57         Would like leaks bot results at build.webkit.org/dashboard
58         https://bugs.webkit.org/show_bug.cgi?id=122657
59
60         Reviewed by Darin Adler.
61
62         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
63         Record links provided by buildbot steps. Currently, the dashboard hardcodes more links
64         than necessary, could use the ones from buildbot in more places.
65
66         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
67         (BuildbotQueue): Reflect configuration option for leaks queues.
68
69         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
70         Add leaks queues to performance column. First, leaks are about performance indeed,
71         and second, this is where we have some space to spare.
72
73         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
74         (WebKitBuildbot): Added Yosemite Leaks queue, which was sitting neglected for at
75         least a year.
76
77         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
78         (table.queue-grid td): Moved height from queue-view - we can now have more than one
79         queue view per cell. The heigt is needed to avoid ugly overlapping while loading
80         results - once the results are loaded, all rows are currently higher than that.
81
82         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
83         (.leaks-popover): Added.
84
85         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
86         Added.
87
88         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
89         Load BuildbotLeaksQueueView.js.
90
91 2015-01-25  peavo@outlook.com  <peavo@outlook.com>
92
93         [Win] Add WebKit message loop interface.
94         https://bugs.webkit.org/show_bug.cgi?id=140857
95
96         Reviewed by Brent Fulgham.
97
98         Added message loop interface which will run the message loop,
99         and perform required tasks (like calling CFRunLoopRunInMode)
100         on each iteration of the loop.
101
102         * WinLauncher/WinMain.cpp:
103         (wWinMain): Use new message loop interface.
104
105 2015-01-24  Dan Bernstein  <mitz@apple.com>
106
107         update-webkit’s --internal option is unused
108         https://bugs.webkit.org/show_bug.cgi?id=140861
109
110         Reviewed by Anders Carlsson.
111
112         * Scripts/update-webkit: Removed the option.
113
114 2015-01-24  Brent Fulgham  <bfulgham@apple.com>
115
116         DumpRenderTree needs to run with Windows native controls on Windows
117         https://bugs.webkit.org/show_bug.cgi?id=25592
118
119         Reviewed by Anders Carlsson.
120
121         * DumpRenderTree/win/DumpRenderTree.cpp:
122         (resetWebPreferencesToConsistentValues): Tell DRT to use native controls.
123         (prepareConsistentTestingEnvironment): Ditto.
124
125 2015-01-23  David Kilzer  <ddkilzer@apple.com>
126
127         test-webkitpy: webkitpy.tool.commands.earlywarningsystem_unittest.EarlyWarningSystemTest.test_ewses fails on EFL, GTK, Win ports
128         <http://webkit.org/b/140787>
129
130         Reviewed by Daniel Bates.
131
132         * Scripts/webkitpy/port/ios.py:
133         (IOSPort.determine_full_port_name): Instead of checking the type
134         of the current host, test if /usr/bin/xcrun exists before trying
135         to use it.
136
137 2015-01-23  Csaba Osztrogonác  <ossy@webkit.org>
138
139         Fix the false positive build failures on the Windows buildbots
140         https://bugs.webkit.org/show_bug.cgi?id=140819
141
142         Reviewed by Brent Fulgham.
143
144         Increase the build timeout (without producing output) to 2 hours for Windows bots,
145         the default 20 minutes is enough for others since they produce output during the build.
146
147         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
148         (BuildFactory.__init__):
149
150 2015-01-23  Brent Fulgham  <bfulgham@apple.com>
151
152         [Win] Teach WebKit to provide IAccessible2 'get_language' and access AXLanguage
153         https://bugs.webkit.org/show_bug.cgi?id=140839
154
155         Reviewed by Dean Jackson.
156
157         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
158         (AccessibilityUIElement::language): Retrieve the 'language' BSTR
159         from the IA2Locale structure and pass it to DRT.
160
161 2015-01-23  Brent Fulgham  <bfulgham@apple.com>
162
163         [Win] Update DRT Accessibility implementation to better match Mac.
164         https://bugs.webkit.org/show_bug.cgi?id=140830
165
166         Reviewed by Dean Jackson.
167
168         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
169         (AccessibilityUIElement::titleUIElement):
170         (AccessibilityUIElement::parentElement):
171         (convertToDRTLabel):
172         (AccessibilityUIElement::role):
173         (AccessibilityUIElement::title):
174         (AccessibilityUIElement::description):
175         (AccessibilityUIElement::stringValue):
176         (AccessibilityUIElement::helpText):
177         (AccessibilityUIElement::isFocused):
178
179 2015-01-23  Sergio Villar Senin  <svillar@igalia.com>
180
181         REGRESSION: run-perf-tests --profiler= seems to have broken
182         https://bugs.webkit.org/show_bug.cgi?id=113528
183
184         Reviewed by Daniel Bates.
185
186         The problem is that "perf --record" (or the equivalent call for
187         other profilers) is never called whenever there is a wrapper
188         option in the port. We should inject the profiler call first
189         (should it exists) and then use the port wrapper.
190
191         * Scripts/webkitpy/port/driver.py:
192         (Driver._command_wrapper):
193         * Scripts/webkitpy/port/driver_unittest.py:
194         (DriverTest.test_profiler_and_wrapper): New unit test.
195
196 2015-01-22  David Kilzer  <ddkilzer@apple.com>
197
198         configure-xcode-for-ios-development needs to import webkitdirs.pm
199         <http://webkit.org/b/140704>
200
201         Fixes the following runtime error:
202
203             Undefined subroutine &main::exitStatus called at ./Tools/Scripts/configure-xcode-for-ios-development line 167.
204
205         * Scripts/configure-xcode-for-ios-development: Add back code to
206         import webkitdirs.pm for the exitStatus() method.  Not sure why
207         I removed it before patch review.
208
209 2015-01-22  Timothy Horton  <timothy_horton@apple.com>
210
211         REGRESSION (r178847): Yosemite 32-bit bot isn't doing any work
212         https://bugs.webkit.org/show_bug.cgi?id=140795
213
214         Reviewed by Jon Honeycutt.
215
216         * BuildSlaveSupport/build.webkit.org-config/config.json:
217         r178847 accidentally remove the scheduler for this bot. Re-add it to the
218         Yosemite scheduler.
219
220 2015-01-22  Brent Fulgham  <bfulgham@apple.com>
221
222         [Win] Expose missing editing features through WebView interface
223         https://bugs.webkit.org/show_bug.cgi?id=140773
224         <rdar://problem/19565421>
225
226         Reviewed by Dean Jackson.
227
228         Connect the various WebView editing delegate methods to our
229         test infrastructure. Also prefer _bstr_t to raw BSTR types
230         to simplify life cycle management.
231
232         * DumpRenderTree/win/DumpRenderTree.cpp:
233         (resetWebViewToConsistentStateBeforeTesting):
234         * DumpRenderTree/win/EditingDelegate.cpp:
235         (EditingDelegate::QueryInterface):
236         (dumpPath):
237         (dump):
238         (EditingDelegate::shouldBeginEditingInDOMRange):
239         (EditingDelegate::shouldEndEditingInDOMRange):
240         (EditingDelegate::shouldInsertNode):
241         (EditingDelegate::shouldInsertText):
242         (EditingDelegate::shouldDeleteDOMRange):
243         (EditingDelegate::shouldChangeSelectedDOMRange):
244         (EditingDelegate::shouldApplyStyle):
245         (EditingDelegate::shouldChangeTypingStyle):
246         (EditingDelegate::doPlatformCommand):
247         (EditingDelegate::webViewDidBeginEditing):
248         (EditingDelegate::webViewDidChange):
249         (EditingDelegate::webViewDidEndEditing):
250         (EditingDelegate::webViewDidChangeTypingStyle):
251         (EditingDelegate::webViewDidChangeSelection):
252         (EditingDelegate::checkSpellingOfString):
253         (EditingDelegate::onNotify):
254         * DumpRenderTree/win/EditingDelegate.h:
255
256 2015-01-22  Ryosuke Niwa  <rniwa@webkit.org>
257
258         Add a build flag for ES6 class syntax
259         https://bugs.webkit.org/show_bug.cgi?id=140760
260
261         Reviewed by Michael Saboff.
262
263         * Scripts/webkitperl/FeatureList.pm:
264
265 2015-01-22  Daniel Bates  <dabates@apple.com>
266
267         [iOS] run-webkit-tests --ios-sim dies with an error; fails to parse Apple Internal
268         runtime in simctl output
269         https://bugs.webkit.org/show_bug.cgi?id=140751
270
271         Reviewed by David Kilzer.
272
273         Following the fix for <rdar://problem/19444383>, run-webkit-tests --ios-sim dies
274         with an error because it does not know how to parse the output of the simctl tool
275         to identify an Apple Internal runtime.
276
277         * Scripts/webkitpy/xcode/simulator.py:
278         (Runtime.__init__): Add parameter is_internal_runtime (defaults to False).
279         (Runtime.__eq__): Take is_internal_runtime when comparing two Runtime objects for equality.
280         (Runtime.__repr__): Update printable representation of Runtime object to indicate whether
281         the runtime is an internal runtime.
282         (Simulator): Update regular expressions runtime_re and version_re to match an internal runtime.
283         (Simulator._parse_runtimes): Pass is_internal_runtime to the Runtime constructor with the
284         appropriate value.
285         (Simulator._parse_devices): Pass argument is_internal_runtime to Simulator.runtime() so that
286         it updates the appropriate Runtime object.
287         (Simulator.runtime): Added optional parameter, is_internal_runtime. Modified to support
288         looking up a Runtime object for an internal runtime.
289
290 2015-01-22  Alexey Proskuryakov  <ap@apple.com>
291
292         LeaksViewer doesn't show recent builds if there are less than 10
293         https://bugs.webkit.org/show_bug.cgi?id=140716
294
295         Reviewed by Tim Horton.
296
297         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
298
299 2015-01-22  Lucas Forschler  <lforschler@apple.com>
300
301         Add Apple build slaves.
302         Fixed text alignment for slave list.
303         
304         Unreviewed.
305         
306         * BuildSlaveSupport/build.webkit.org-config/config.json:
307
308 2015-01-21  Lucas Forschler  <lforschler@apple.com>
309
310         Teach build.webkit.org about bot308 and bot309.
311         
312         Unreviewed.
313         
314         * BuildSlaveSupport/build.webkit.org-config/config.json:
315
316 2015-01-21  Lucas Forschler  <lforschler@apple.com>
317
318         Add two Apple Mavericks slaves.
319         
320         Unreviewed.
321         
322         * BuildSlaveSupport/build.webkit.org-config/config.json:
323
324 2015-01-21  Daniel Bates  <dabates@apple.com>
325
326         Add iOS WebKit1 TestExpectation file
327         https://bugs.webkit.org/show_bug.cgi?id=140739
328
329         Reviewed by David Kilzer.
330
331         Teach run-webkit-tests to look for iOS WebKit1-specific test results and
332         expectations in directory LayoutTests/platform/ios-simulator-wk1.
333
334         * Scripts/webkitpy/port/ios.py:
335         (IOSSimulatorPort.default_baseline_search_path):
336
337 2015-01-21  David Kilzer  <ddkilzer@apple.com>
338
339         [iOS] Update configure-xcode-for-ios-development to copy missing headers to iphoneos SDK
340         <http://webkit.org/b/140704>
341
342         Reviewed by Daniel Bates.
343
344         * Scripts/configure-xcode-for-ios-development:
345         - Update copyright.
346         - Remove FIXME addressed by r178709.
347         - Call copyMissingHeadersToIPhoneOSSDKIfNeeded().
348         (copyMissingHeadersToIPhoneOSSDKIfNeeded): Add method to copy
349         missing headers from iphonesimulator SDK to iphoneos SDK.
350         (sdkDirectory): Add method that returns SDK directory.
351         (sdkPlatformDirectory): Extract method from
352         xcodeSDKSpecificationsPath() that returns SDK platform
353         directory.
354         (xcodeSDKSpecificationsPath): Update to use
355         sdkPlatformDirectory().
356
357 2015-01-21  Alexey Proskuryakov  <ap@apple.com>
358
359         https://build.webkit.org/dashboard/metrics.html fails because of ios-ews
360         https://bugs.webkit.org/show_bug.cgi?id=140731
361
362         Reviewed by Tim Horton.
363
364         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
365         (Analyzer.prototype._analyzeAllBubblesPerformance): Corrected a typo.
366
367 2015-01-21  Brent Fulgham  <bfulgham@apple.com>
368
369         [Win] eventSender does not support scalePageBy
370         https://bugs.webkit.org/show_bug.cgi?id=140726
371         <rdar://problem/19549865>
372
373         Reviewed by Dean Jackson.
374
375         * DumpRenderTree/win/EventSender.cpp:
376         (scalePageByCallback): Provide implementation using new WebView method.
377
378 2015-01-21  Lucas Forschler  <lforschler@apple.com>
379
380         Remove Apple Mountain Lion Build & Test slaves.
381         
382         Unreviewed.
383
384         * BuildSlaveSupport/build.webkit.org-config/config.json:
385
386 2015-01-21  Csaba Osztrogonác  <ossy@webkit.org>
387
388         Remove ENABLE(INSPECTOR) ifdef guards
389         https://bugs.webkit.org/show_bug.cgi?id=140668
390
391         Reviewed by Darin Adler.
392
393         * DumpRenderTree/mac/TestRunnerMac.mm:
394         (TestRunner::showWebInspector):
395         (TestRunner::closeWebInspector):
396         (TestRunner::evaluateInWebInspector):
397         * Scripts/webkitperl/FeatureList.pm:
398         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
399         (WTR::TestRunner::showWebInspector):
400         (WTR::TestRunner::closeWebInspector):
401         (WTR::TestRunner::evaluateInWebInspector):
402         * WebKitTestRunner/TestInvocation.cpp:
403         (WTR::TestInvocation::invoke):
404
405 2015-01-20  Alexey Proskuryakov  <ap@apple.com>
406
407         Update build.webkit.org/dashboard to match current Mac queues.
408
409         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion.png: Removed.
410         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion@2x.png: Removed.
411         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png: Removed.
412         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png: Removed.
413         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
414         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
415         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
416         (table.queue-grid tr.platform.mac-os-x-mountain-lion img.logo): Deleted.
417         (table.queue-grid tr.platform.mac-os-x-lion img.logo): Deleted.
418
419 2015-01-20  Lucas Forschler  <lforschler@apple.com>
420
421         Update Apple MountainLion Leaks slave to Yosemite
422         Update Apple MountainLion Release (32-bit) Build slave to Yosemite
423         
424         Unreviewed.
425
426         * BuildSlaveSupport/build.webkit.org-config/config.json:
427
428 2015-01-20  Lucas Forschler  <lforschler@apple.com>
429
430         Update LeaksViewer from MountainLion to Yosemite
431         
432         Reviewed by Alexey Proskuryakov.
433
434         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
435         (LeaksViewer._displayURLPrompt):
436
437 2015-01-20  Jake Nielsen  <jacob_nielsen@apple.com>
438
439         Fix EWS python unit tests and address code comments as per 140476
440         https://bugs.webkit.org/show_bug.cgi?id=140637
441
442         Reviewed by David Kilzer.
443
444         * Scripts/webkitpy/port/base.py:
445         (Port):
446         (Port.__init__):
447         Adds DEFAULT_ARCHITECTURE member.
448         (Port.architecture):
449         Removes architecture member and instead uses
450         self.get_option('architecture'). Also removes redundant architecture
451         method.
452         (Port.set_architecture):
453         Adds a setter for the architecture variable to be able to set a flag
454         upon modification.
455         (Port.test_configuration):
456         Uses self.architecture() instead of self._architecture.
457         * Scripts/webkitpy/port/ios.py:
458         Overrides DEFAULT_ARCHITECTURE.
459         (IOSPort):
460         (IOSPort.determine_full_port_name):
461         Uses subprocess.check_output instead of Popen. Uses rstrip instead of
462         strip. Fixes regex to not match arbitrary characters after the
463         relevent digits are matched.
464         (IOSPort.__init__):
465         Removes old _architecture defaulting strategy.
466         (IOSPort._build_driver_flags):
467         Uses self.architecture() instead of self._architecture.
468         (IOSSimulatorPort):
469         Overrides DEFAULT_ARCHITECTURE.
470         (IOSSimulatorPort.__init__):
471         Removes old _architecture defaulting strategy.
472         * Scripts/webkitpy/port/mac.py:
473         (MacPort):
474         Overrides DEFAULT_ARCHITECTURE.
475         (MacPort.__init__):
476         Removes old _architecture defaulting strategy.
477         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
478         (AbstractEarlyWarningSystem.run_command):
479         Checks the did_override_architecture flag to determine whether to add
480         the --architecture option.
481         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
482         Uses ews.architecture rather than trying to discern the correct
483         architecture using a port object.
484         (EarlyWarningSystemTest._default_expected_logs):
485         * Scripts/webkitpy/tool/commands/queues.py:
486         Removes use of optparse, and removes the import statement.
487         (AbstractQueue.__init__):
488         (PatchProcessingQueue.begin_work_queue):
489
490 2015-01-20  Sam Weinig  <sam@webkit.org>
491
492         Attempt to fix Mountain Lion and EFL tests.
493
494         * WebKitTestRunner/TestController.cpp:
495         (WTR::TestController::initialize):
496         Disable Process-per-tab and network process on Mountain Lion and EFL.
497
498 2015-01-20  Darin Adler  <darin@apple.com>
499
500         Remove SVGElementInstanceList, m_instanceUnderMouse, DUMP_INSTANCE_TREE, DUMP_SHADOW_TREE
501         https://bugs.webkit.org/show_bug.cgi?id=140679
502
503         Reviewed by Anders Carlsson.
504
505         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
506         Removed a reference to SVGElementInstanceList.
507
508 2015-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
509
510         [GTK] WebViewTest should prohibit overriding initializeWebExtensions()
511         https://bugs.webkit.org/show_bug.cgi?id=140028
512
513         Reviewed by Carlos Garcia Campos.
514
515         This won't work as expected, since this function is called before the
516         WebViewTest constructor completes.
517
518         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
519
520 2015-01-20  David Kilzer  <ddkilzer@apple.com>
521
522         configure-xcode-for-ios-development needs to update iPhoneOS SDK
523         <http://webkit.org/b/140661>
524
525         Reviewed by Daniel Bates.
526
527         * Scripts/configure-xcode-for-ios-development: Add for() loop to
528         run createXcodeSpecificationFilesForSDKIfNeeded() for both
529         "iphoneos" and "iphonesimulator" SDKs.
530         (createXcodeSpecificationFilesForSDKIfNeeded): Extracted from
531         the main body of the script.
532
533 2015-01-20  Tomas Popela  <tpopela@redhat.com>
534
535         [GTK] Add API to set the web view editable into WebKit2 GTK+ API
536         https://bugs.webkit.org/show_bug.cgi?id=139443
537
538         Reviewed by Carlos Garcia Campos.
539
540         Create the new test cases for setting the editable property on the web
541         view and on the contenteditable enabled document. Also rework the
542         current tests that are expecting that the web view is editable.
543
544         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
545         (loadTestHtml):
546         (testWebViewEditorCutCopyPasteNonEditable):
547         (testWebViewEditorCutCopyPasteEditable):
548         (testWebViewEditorSelectAllNonEditable):
549         (testWebViewEditorSelectAllEditable):
550         (runEditorEditableCutTests):
551         (testWebViewEditorEditableOnNonEditable):
552         (testWebViewEditorEditableOnContentEditable):
553         (testWebViewEditorNonEditable):
554         (beforeAll):
555         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
556         (WebViewTest::isEditable):
557         (WebViewTest::setEditable):
558
559 2015-01-20  Carlos Garcia Campos  <cgarcia@igalia.com>
560
561         [GTK] Add an option to create WebKitWebView snapshots with transparent background
562         https://bugs.webkit.org/show_bug.cgi?id=140617
563
564         Reviewed by Gustavo Noronha Silva.
565
566         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
567         (testWebViewSnapshot): Check that the same snapshot with
568         transparent background is different than the default one filled
569         with white.
570
571 2015-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
572
573         [GTK] Add API to change the WebKitWebView background color
574         https://bugs.webkit.org/show_bug.cgi?id=140610
575
576         Reviewed by Gustavo Noronha Silva.
577
578         Add --bg-color command line option to MiniBrowser to be able to
579         manually test the API passing any RGBA color to MiniBrowser.
580         Also add a simple unit test to check that getting and setting
581         colors from the API point of view.
582
583         * MiniBrowser/gtk/BrowserWindow.c:
584         (browser_window_set_background_color):
585         * MiniBrowser/gtk/BrowserWindow.h:
586         * MiniBrowser/gtk/main.c:
587         (createBrowserWindow):
588         (parseBackgroundColor):
589         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
590         (testWebViewBackgroundColor):
591         (beforeAll):
592
593 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
594
595         [Win] Layout Test fast/xmlhttprequest/xmlhttprequest-no-file-access.html is failing
596         https://bugs.webkit.org/show_bug.cgi?id=140665
597
598         Reviewed by Brian Burg.
599
600         * DumpRenderTree/win/UIDelegate.cpp:
601         (UIDelegate::webViewAddMessageToConsole): Correct string search and concatenation to
602         match expected test output.
603
604 2015-01-19  Benjamin Poulain  <bpoulain@apple.com>
605
606         Remove the support for custom suffixes on ChangeLog
607         https://bugs.webkit.org/show_bug.cgi?id=140648
608
609         Reviewed by David Kilzer.
610
611         Custom suffixes were used for the iOS branch of WebKit.
612         Now that everything is opensource, there is no need for it.
613
614         * Scripts/VCSUtils.pm:
615         (changeLogSuffix): Deleted.
616         (changeLogFileName): Deleted.
617         * Scripts/commit-log-editor:
618         * Scripts/prepare-ChangeLog:
619         (getLatestChangeLogs):
620         (generateNewChangeLogs):
621         (generateFileList):
622         * Scripts/resolve-ChangeLogs:
623         (findChangeLog):
624
625 2015-01-19  Timothy Horton  <timothy_horton@apple.com>
626
627         Adjust naming of action menu SPI
628         https://bugs.webkit.org/show_bug.cgi?id=140644
629         <rdar://problem/19448129>
630
631         Reviewed by Brian Weinstein.
632
633         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
634         (-[ActionMenusTestWKView runMenuSequenceAtPoint:preDidCloseMenuHandler:]):
635         (TestWebKitAPI::TEST):
636
637 2015-01-19  Michael Catanzaro  <mcatanzaro@igalia.com>
638
639         [GTK] Generate the make dist manifest from a CMake template file
640         https://bugs.webkit.org/show_bug.cgi?id=139387
641
642         Reviewed by Martin Robinson.
643
644         Remove the code that performs variable substitution on manifest.txt.
645         Replace the custom variables used in that file with CMake variables.
646
647         * gtk/make-dist.py:
648         (Manifest.add_directory):
649         (Manifest.get_full_source_path):
650         (Manifest.process_line):
651         (Manifest.resolve_variables): Deleted.
652         (Manifest.get_full_tarball_path): Deleted.
653         * gtk/manifest.txt.in: Renamed from Tools/gtk/manifest.txt.
654
655 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
656
657         [Win] Correct merge error in last commit.
658
659         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
660         (findAccessibleObjectById): Undo accidental paste made during landing.
661
662 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
663
664         [Win] Periodic failure in DumpRenderTree related to WebActionPropertyBag::Read
665         https://bugs.webkit.org/show_bug.cgi?id=139906
666
667         Reviewed by Dean Jackson.
668
669         WebKit on Windows was creating uninitialized VARIANT structures, then attempting
670         to use them. This patch fixes that.
671
672         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
673         (findAccessibleObjectById):
674         (AccessibilityController::focusedElement):
675         (logEventProc):
676         (notificationListenerProc):
677         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
678         (AccessibilityUIElement::getChildAtIndex):
679         (AccessibilityUIElement::titleUIElement):
680         (self):
681         (AccessibilityUIElement::role):
682         (AccessibilityUIElement::valueDescription):
683         (accessibilityState):
684         (AccessibilityUIElement::isChecked):
685         * DumpRenderTree/win/DumpRenderTree.cpp:
686         (dumpFrameScrollPosition):
687         (dumpFramesAsText):
688         * DumpRenderTree/win/PolicyDelegate.cpp:
689         (PolicyDelegate::decidePolicyForNavigationAction):
690         * DumpRenderTree/win/UIDelegate.cpp:
691         (UIDelegate::exceededDatabaseQuota):
692         * WinLauncher/Common.cpp:
693         (setWindowText):
694
695 2015-01-19  Dean Jackson  <dino@apple.com>
696
697         Add "override" to fix the build with newer clangs.
698
699         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
700         (TestWebKitAPI::CalculationDeletionTestNode::operator==):
701
702 2015-01-19  David Kilzer  <ddkilzer@apple.com>
703
704         [iOS] Do not hard-code iphoneos.internal SDK in buildXCodeProject()
705         <http://webkit.org/b/140623>
706
707         Reviewed by Daniel Bates.
708
709         * Scripts/build-webkit: Update help for --device switch.
710         * Scripts/webkitdirs.pm:
711         (determineXcodeSDK): When passing --device, prefer the internal
712         iOS SDK if it exists, else fall back to the external iOS SDK.
713         (buildXCodeProject): Use xcodeSDK() as -sdk argument for
714         xcodebuild instead of trying to sanitize values.
715
716 2015-01-19  Alexey Proskuryakov  <ap@apple.com>
717
718         "Unknown option: sharedworkerglobalscopeconstructorsfile" when running bindings tests.
719         https://bugs.webkit.org/show_bug.cgi?id=140606
720
721         Reviewed by Csaba Osztrogonác.
722
723         * Scripts/webkitpy/bindings/main.py:
724         (BindingsTests.generate_supplemental_dependency):
725         (BindingsTests.main):
726
727 2015-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
728
729         [GTK] [WK2] TestWebKitWebView snapshot fails
730         https://bugs.webkit.org/show_bug.cgi?id=120404
731
732         Reviewed by Žan Doberšek.
733
734         Rework the test to make sure the snapshot is always created at the
735         desired size.
736
737         * Scripts/run-gtk-tests:
738         (TestRunner): Unskip /webkit2/WebKitWebView/snapshot.
739         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
740         (testWebViewSnapshot): Use a fixed size for the document, and
741         disable scrollbars to make sure the visible area is always the
742         WebView size.
743         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
744         (WebViewTest::showInWindowAndWaitUntilMapped): Add optional width
745         and height parameters to create the window with a given size.
746         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
747
748 2015-01-18  David Kilzer  <ddkilzer@apple.com>
749
750         iOS EWS queue name should be consistent
751         <http://webkit.org/b/140585>
752
753         Reviewed by Daniel Bates.
754
755         * Scripts/webkitpy/common/config/ews.json: Rename 'ios-device'
756         to 'ios'.
757         * Scripts/webkitpy/common/config/ports.py: Ditto.
758         (DeprecatedPort.port):
759         (IOSPort):
760         * Scripts/webkitpy/port/ios.py: Ditto.
761         (IOSPort):
762
763         * Scripts/webkitpy/port/factory.py:
764         (PortFactory): Re-order PORT_CLASSES so ios.IOSSimulatorPort
765         appears before ios.IOSPort.  If this is not done,
766         `run-webkit-tests --ios-simulator` will get the wrong Port class
767         (IOSPort instead of IOSSimulatorPort) due to the way that
768         PortFactory.get() uses prefix matching of <Port>.port_name to
769         find the correct class to use.
770
771 2015-01-18  Alexey Proskuryakov  <ap@apple.com>
772
773         build.webkit.org/dashboard: OS X EWS is now on Mavericks
774         https://bugs.webkit.org/show_bug.cgi?id=140595
775
776         Reviewed by Csaba Osztrogonác.
777
778         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
779         (BubbleQueueServer):
780
781 2015-01-17  David Kilzer  <ddkilzer@apple.com>
782
783         Attempt to fix webkitpy tests on Mountain Lion, Mavericks bots
784
785         * Scripts/webkitpy/port/ios.py:
786         (IOSPort): Add 'ios-device-7' to VERSION_FALLBACK_ORDER so that
787         test-webkitpy doesn't fail since iOS 7.x SDKs are installed on
788         the Mountain Lion and Mavericks bots.
789
790 2015-01-17  David Kilzer  <ddkilzer@apple.com>
791
792         Attempt to fix webkitpy tests on GTK Linux ports
793
794         * Scripts/webkitpy/port/ios.py:
795         (IOSPort.determine_full_port_name): Set a sensible default if
796         not running on a Mac platform or if no iOS SDK is installed.
797
798 2015-01-17  Jake Nielsen  <jacob_nielsen@apple.com>
799
800         Create iOS-EWS client queue
801         https://bugs.webkit.org/show_bug.cgi?id=140476
802
803         Reviewed by Alexey Proskuryakov.
804
805         * EWSTools/start-queue-mac.sh:
806         Adds call to configure-xcode-for-ios-development for iOS EWS.
807         * Scripts/webkitpy/common/config/ews.json:
808         Adds the iOS EWS config entry.
809         * Scripts/webkitpy/common/config/ports.py:
810         (DeprecatedPort.port):
811         Adds IOSPort to the port map.
812         (IOSPort):
813         (IOSPort.build_webkit_command):
814         Adds --sdk=iphoneos to the webkit build command.
815         * Scripts/webkitpy/port/base.py:
816         (Port.architecture):
817         Adds an accessor for the architecture member variable.
818         * Scripts/webkitpy/port/factory.py:
819         (PortFactory):
820         Adds IOSPort to the port class list.
821         * Scripts/webkitpy/port/ios.py:
822         Adds the IOSPort to encapsulate iOS-specific things.
823         (IOSPort):
824         (IOSPort.determine_full_port_name):
825         (IOSPort.__init__):
826         (IOSPort._build_driver_flags):
827         (IOSPort.operating_system):
828         * Scripts/webkitpy/tool/commands/download_unittest.py:
829         Adds the archetecture option to the mock options.
830         (DownloadCommandsTest._default_options):
831         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
832         Appends the archetecture option into calls to webkit-patch.
833         (AbstractEarlyWarningSystem.review_patch):
834         (AbstractEarlyWarningSystem.run_command):
835         (AbstractEarlyWarningSystem.load_ews_classes):
836         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
837         Adds logic to soothe the unittest now that --architecture is being
838         thrown around everywhere.
839         (EarlyWarningSystemTest._default_expected_logs):
840         * Scripts/webkitpy/tool/commands/queues.py:
841         Adds glue code to ferry the --architecture option around.
842         (AbstractQueue.__init__):
843         (PatchProcessingQueue.begin_work_queue):
844         * Scripts/webkitpy/tool/steps/abstractstep.py:
845         Adds the archetecture option to all AbstractSteps so that
846         EarlyWarningSystem doesn't start shoving --architecture into
847         unsuspecting commands.
848         (AbstractStep.options):
849         * Scripts/webkitpy/tool/steps/build.py:
850         Translates the --architecture option into an ARCHS= format to pass to
851         build-webkit.
852         (Build.build):
853         * Scripts/webkitpy/tool/steps/options.py:
854         Adds a definition for the --architecture option.
855         (Options):
856
857 2015-01-16  Sam Weinig  <sam@webkit.org>
858
859         Add a basic configuration object for WKView
860         https://bugs.webkit.org/show_bug.cgi?id=140559
861
862         Reviewed by Anders Carlsson.
863
864         Add tests for WKPageConfigurationRef.
865
866         * TestWebKitAPI/PlatformWebView.h:
867         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
868         * TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp: Added.
869         (TestWebKitAPI::TEST):
870         (TestWebKitAPI::didFinishLoadForFrame):
871         (TestWebKitAPI::setPageLoaderClient):
872         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
873         (TestWebKitAPI::PlatformWebView::initialize):
874         (TestWebKitAPI::PlatformWebView::PlatformWebView):
875
876 2015-01-16  Myles C. Maxfield  <mmaxfield@apple.com>
877
878         WeakPtr functions crash when created with default constructor
879         https://bugs.webkit.org/show_bug.cgi?id=140479
880
881         Reviewed by Andreas Kling.
882
883         Add WeakPtr API tests.
884
885         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
886         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: Added.
887         * TestWebKitAPI/Tests/WTF/Ref.cpp: Update to not use copy constructor.
888
889 2015-01-16  Chris Dumez  <cdumez@apple.com>
890
891         Regression(r178586): Caused webkitpy.w3c.test_converter_unittest.W3CTestConverterTest.test_convert_prefixed_properties to fail
892         https://bugs.webkit.org/show_bug.cgi?id=140568
893
894         Reviewed by Alexey Proskuryakov.
895
896         Fix the script parsing CSSPropertyNames.in to stop splitting lines
897         on '=' sign. The '=' sign is also used in StyleBuilder parameters:
898         e.g. "Longhands=background-position-x|background-position-y".
899         This would confuse the script and treat this as a CSS property:
900         "background-position-x|background-position-y".
901
902         We now split on white space and treat the first string on the line
903         to be the property name (this is the syntax in this file).
904
905         * Scripts/webkitpy/w3c/test_converter.py:
906         (_W3CTestConverter.__init__):
907         (_W3CTestConverter.read_webkit_prefixed_css_property_list):
908
909 2015-01-16  Daniel Bates  <dabates@apple.com>
910
911         REGRESSION (r171968): run-safari --simulator fails to launch Safari on iOS
912         https://bugs.webkit.org/show_bug.cgi?id=135589
913
914         Reviewed by David Kilzer.
915
916         Derived from a patch by David Farler.
917
918         Following the removal IPhoneSimulatorNotification.pm in <http://trac.webkit.org/changeset/171968>
919         run-safari --simulator fails to launch Safari on iOS. We need to implement run-safari
920         in terms of the simctl command line utility.
921
922         * Scripts/webkitdirs.pm: Added constant SIMULATOR_DEVICE_STATE_BOOTED.
923         (eraseIOSSimulatorDevice): Added.
924         (bootedIOSSimulatorDevice): Added.
925         (iosSimulatorApplicationsPath): Added.
926         (installedMobileSafariBundle): Implemented in terms of iosSimulatorApplicationsPath().
927         (openIOSSimulator): Modified to launch iOS Simulator using OPEN(1).
928         (quitIOSSimulator): Added.
929         (iosSimulatorDeviceByName): Modified to find the first simulator device that matches
930         the specified name and currently selected iOS runtime.
931         (isIOSSimulatorSystemInstalledApp): Added.
932         (runIOSWebKitAppInSimulator): Modified to use simctl launch to launch an app in the simulator.
933         (deleteiOSSimulatorDevice): Deleted.
934         (loadIPhoneSimulatorNotificationIfNeeded): Deleted.
935         (installAndLaunchIOSWebKitAppInSimulator): Deleted.
936
937 2015-01-16  Alex Christensen  <alex.christensen@flexsim.com>
938
939         Resurrect the WinCairo bot.
940         https://bugs.webkit.org/show_bug.cgi?id=139908
941
942         Reviewed by Csaba Osztrogonác.
943
944         * BuildSlaveSupport/build.webkit.org-config/config.json:
945         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
946         (appendCustomBuildFlags):
947         * BuildSlaveSupport/test-result-archive:
948         (archiveTestResults):
949         Add WinCairo buildbot.
950
951 2015-01-16  Chris Dumez  <cdumez@apple.com>
952
953         webkit-patch should auto-install the keyring python module
954         https://bugs.webkit.org/show_bug.cgi?id=140547
955
956         Reviewed by David Kilzer.
957
958         Auto-install the keyring python module. This is the module that
959         webkit-patch uses for cross-platform access to the keyring
960         service.
961
962         Without this module, if the password if not in the keychain,
963         webkit-patch will keep asking for your username / password and
964         never remember them.
965
966         * Scripts/webkitpy/common/net/credentials.py:
967         * Scripts/webkitpy/thirdparty/__init__.py:
968         (AutoinstallImportHook.find_module):
969         (AutoinstallImportHook._install_keyring):
970
971 2015-01-15  Csaba Osztrogonác  <ossy@webkit.org>
972
973         Remove ENABLE(SQL_DATABASE) guards
974         https://bugs.webkit.org/show_bug.cgi?id=140434
975
976         Reviewed by Darin Adler.
977
978         * Scripts/webkitperl/FeatureList.pm:
979
980 2015-01-15  Daniel Bates  <dabates@apple.com>
981
982         [iOS] REGRESSION (r174642): DumpRenderTree.app test may dump result twice
983         https://bugs.webkit.org/show_bug.cgi?id=139685
984         <rdar://problem/19281317>
985
986         Reviewed by Simon Fraser.
987
988         Fixes an issue where a test in DumpRenderTree.app may dump its result twice. In particular,
989         the test LayoutTests/fast/dom/gc-10.html may dump its result twice.
990
991         Following <http://trac.webkit.org/changeset/174642>, we dump the test result asynchronously
992         as opposed to synchronously. So, the WebThread or the main thread may perform other tasks
993         before DRT dumps the output of a test. In particular, the WebThread may start a new page
994         load (say, as a result of continued JavaScript execution), which will ultimately lead to
995         dumping the test result again. Instead we want DRT to dump the test result synchronously
996         such that we capture the state of the web page either when the page is loaded or when
997         window.testRunner.notifyDone() is called.
998
999         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1000         (createBitmapContextFromWebView): Moved logic to re-enable tile painting and update the
1001         state of the display from here to updateDisplay(). Added call to -[CATransaction flush] to
1002         flush CA transactions to the window.
1003         * DumpRenderTree/mac/DumpRenderTree.mm:
1004         (updateDisplay): Added iOS-specific code to update tiles and tell WebKit to flush
1005         compositing changes to ensure that we have up-to-date tile content for a pixel/ref-test.
1006         (dump): Renamed; formerly named dumpTestResults().
1007         (displayWebView): Removed outdated FIXME comment. Added FIXME comment to investigate
1008         enabling repaint support on iOS.
1009         (-[DumpRenderTree _deferDumpToMainThread]): Deleted.
1010         (-[DumpRenderTree _waitForWebThreadThenDump]): Deleted.
1011         (dumpTestResults): Deleted.
1012
1013 2015-01-15  Brent Fulgham  <bfulgham@apple.com>
1014
1015         [Win] Miscellaneous DRT fixes
1016         https://bugs.webkit.org/show_bug.cgi?id=116562
1017
1018         Reviewed by Tim Horton.
1019
1020         While investigating the cause of several Windows crashes, I found:
1021         (1) Messy conversions to and from BSTR types
1022         (2) Weird mixes of wide-string and narrow string conversions
1023         (3) Passing nullptr to some CoreFoundation routines that do not
1024             permit null arguments.
1025         (4) Commands to link the executable to the VS2005 runtime.
1026
1027         This patch cleans up these issues to improve DRT reliability on
1028         Windows.
1029
1030         * DumpRenderTree/cg/ImageDiffCG.cpp:
1031         (main): Get rid of VS2005 runtime linking.
1032         * DumpRenderTree/win/DumpRenderTree.cpp:
1033         (urlSuitableForTestResult): Protect against being asked
1034         to process an empty URL.
1035         (dumpHistoryItem): Do BSTR string building using _bstr_t, rather
1036         than converting to/from wchar_t buffers.
1037         (runTest): Simplify string and BSTR handling.
1038         (createWebViewAndOffscreenWindow): Ditto.
1039         (main): Get rid of VS2005 runtime linking.
1040         * DumpRenderTree/win/TestRunnerWin.cpp:
1041         (jsStringRefToWString): Simplify code.
1042         (TestRunner::pathToLocalResource):
1043         (TestRunner::setUserStyleSheetLocation):
1044         * TestWebKitAPI/win/main.cpp: Get rid of
1045         VS2005 runtime linking.
1046         * win/DLLLauncher/DLLLauncherMain.cpp:
1047         (wWinMain): Ditto.
1048
1049 2015-01-15  Alexey Proskuryakov  <ap@apple.com>
1050
1051         Stop hardcoding mac-mountainlion in commit queue
1052         https://bugs.webkit.org/show_bug.cgi?id=140492
1053
1054         Reviewed by Anders Carlsson.
1055
1056         Use "mac", not "mac-<platform>". This matches how EWS queues are initialized, and
1057         there should be no change in behavior, because:
1058         1. PatchProcessingQueue converts the name with _new_port_name_from_old() before
1059         using it to create a port object.
1060         2. Although it doesn't convert the name before using DeprecatedPort.port(), it
1061         is actually correct to use "mac" for the name there. We only used to get the expected
1062         behavior with "mac-mountainlion" accidentally, because of a fallback to "mac"
1063         for unknown deprecated port names.
1064
1065         * Scripts/webkitpy/tool/commands/queues.py: (CommitQueue):
1066
1067 2015-01-14  Jake Nielsen  <jacob_nielsen@apple.com>
1068
1069         Create iOS-EWS server queue
1070         https://bugs.webkit.org/show_bug.cgi?id=140473
1071
1072         Reviewed by Benjamin Poulain.
1073
1074         * QueueStatusServer/app.yaml: Updates the SVN version number.
1075         * QueueStatusServer/config/queues.py: Add ios-ews queue.
1076         * QueueStatusServer/model/queues.py:         
1077         (Queue.display_name): Makes sure the display name is pretty!
1078
1079 2015-01-14  Daniel Bates  <dabates@apple.com>
1080
1081         [iOS] run-webkit-tests --ios hangs trying to launch iOS Simulator with unavailable runtime
1082         https://bugs.webkit.org/show_bug.cgi?id=140301
1083         <rdar://problem/19389266>
1084
1085         Reviewed by Jon Honeycutt.
1086
1087         Fixes an issue where run-webkit-tests --ios will hang when trying to launch iOS Simulator
1088         with an unavailable runtime.
1089
1090         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1091         (_set_up_derived_options): Modified to access property Simulator.latest_available_runtime,
1092         which was formerly called Simulator.latest_runtime. Additionally, raise an exception if the
1093         specified runtime cannot be used because it is unavailable.
1094         * Scripts/webkitpy/port/ios.py:
1095         (IOSSimulatorPort.testing_device): Modified to call Simulator.lookup_or_create_device(),
1096         which was formerly named testing_device.
1097         * Scripts/webkitpy/xcode/simulator.py:
1098         (Device.create): Modified to lookup created device by the UDID returned by simctl, which is
1099         more robust than looking up the simulator device by name and runtime. This approach also
1100         avoids returning the wrong device due to <rdar://problem/19444383> (simctl list shows
1101         unavailable runtimes under the same iOS heading it would use to show it as available).
1102         (Simulator.find_device_by_udid): Added.
1103         (Simulator.device): Added optional parameter should_ignore_unavailable_devices (defaults
1104         to False) to ignore devices that are unavailable (say, because their runtime is unavailable).
1105         (Simulator.available_runtimes): Added.
1106         (Simulator.latest_available_runtime): Renamed; formerly named latest_runtime. Take advantage
1107         of the reverse=True argument to sorted() to sort the list of available runtimes such that the
1108         first element of the sorted list is the runtime with the highest version number.
1109         (Simulator.lookup_or_create_device): Renamed; formerly named testing_device.
1110
1111 2015-01-14  Csaba Osztrogonác  <ossy@webkit.org>
1112
1113         Remove WK2 Windows cruft
1114         https://bugs.webkit.org/show_bug.cgi?id=140440
1115
1116         Reviewed by Anders Carlsson.
1117
1118         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp: Removed.
1119         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp: Removed.
1120         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp: Removed.
1121
1122 2015-01-13  Hunseop Jeong  <hs85.jeong@samsung.com>
1123
1124         Fix TestWTF failed in TestWebKitAPI
1125         https://bugs.webkit.org/show_bug.cgi?id=140333
1126
1127         Reviewed by Sam Weinig.
1128
1129         Clear the std::ostringstream before starting test.
1130
1131         * TestWebKitAPI/Tests/WTF/RefLogger.h:
1132         (TestWebKitAPI::DerivedRefLogger::DerivedRefLogger):
1133
1134 2015-01-13  Michael Catanzaro  <mcatanzaro@igalia.com>
1135
1136         TestWebKitWebContext depends on British English spellcheck dictionary
1137         https://bugs.webkit.org/show_bug.cgi?id=140403
1138
1139         Reviewed by Martin Robinson.
1140
1141         Install all English hunspell dictionaries on Fedora and Arch.
1142
1143         * gtk/install-dependencies:
1144
1145 2015-01-13  Michael Catanzaro  <mcatanzaro@igalia.com>
1146
1147         [GTK] install-dependencies should grok dnf
1148         https://bugs.webkit.org/show_bug.cgi?id=140396
1149
1150         Reviewed by Martin Robinson.
1151
1152         Fedora: install dependencies with dnf if yum is not installed.
1153
1154         * gtk/install-dependencies:
1155
1156 2015-01-12  Hunseop Jeong  <hs85.jeong@samsung.com>
1157
1158         [EFL][GTK] Fix build after r178309  
1159         https://bugs.webkit.org/show_bug.cgi?id=140381
1160
1161         Reviewed by Gyuyoung Kim.
1162
1163         * TestWebKitAPI/CMakeLists.txt: Added the API directory
1164
1165 2015-01-11  Sam Weinig  <sam@webkit.org>
1166
1167         Remove support for SharedWorkers
1168         https://bugs.webkit.org/show_bug.cgi?id=140344
1169
1170         Reviewed by Anders Carlsson.
1171
1172         * Scripts/webkitperl/FeatureList.pm:
1173
1174 2015-01-12  Anders Carlsson  <andersca@apple.com>
1175
1176         Make delegates conform to formal delegate protocols
1177         https://bugs.webkit.org/show_bug.cgi?id=140370
1178
1179         Reviewed by Dan Bernstein.
1180
1181         * DumpRenderTree/mac/TestRunnerMac.mm:
1182         (TestRunner::numberOfPendingGeolocationPermissionRequests):
1183         (TestRunner::setGeolocationPermission):
1184
1185 2015-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
1186
1187         build-webkit: silence output of 'which'
1188         https://bugs.webkit.org/show_bug.cgi?id=140278
1189
1190         Reviewed by Daniel Bates.
1191
1192         Use a more elegent test for the existance of ninja and eclipse.
1193
1194         * Scripts/webkitdirs.pm:
1195         (commandExists): Don't assume the command supports --version
1196         (canUseNinja): Use commandExists()
1197         (canUseEclipse): Use commandExists()
1198
1199 2015-01-09  Sam Weinig  <sam@webkit.org>
1200
1201         Update the output format for run-api-tests
1202         https://bugs.webkit.org/show_bug.cgi?id=140332
1203
1204         Reviewed by Dan Bernstein.
1205
1206         Changes the output format for run-api-tests be a bit simpler (no longer 
1207         indented based on suite, as we were not really using suite very well) but
1208         also include details in the case of failure.
1209
1210         Changes verbose mode to no longer spew out the gtest default printer output,
1211         as the custom printer now includes the failure information.
1212
1213         * Scripts/run-api-tests:
1214         (runTestsBySuite):
1215         (runTest):
1216         Augment the custom gtest printer by replacing the tokens "**PASS**" and "**FAIL**"
1217         with colorized variants and strip out leaks spew (the leaks can be added back using
1218         the new --show-leaks argument).
1219
1220         * TestWebKitAPI/TestsController.cpp:
1221         (TestWebKitAPI::Printer::OnTestPartResult):
1222         (TestWebKitAPI::Printer::OnTestEnd):
1223         (TestWebKitAPI::TestsController::run):
1224         Implement a custom result printer that just prints out the information we want.
1225
1226 2015-01-09  Sam Weinig  <sam@webkit.org>
1227
1228         TestWebKitAPI should print out the lists that fail at the end
1229         https://bugs.webkit.org/show_bug.cgi?id=140329
1230
1231         Reviewed by Tim Horton.
1232
1233         * Scripts/run-api-tests:
1234         (runTestsBySuite):
1235         Print out failures and timeouts in all modes, not just verbose.
1236
1237 2015-01-07  Geoffrey Garen  <ggaren@apple.com>
1238
1239         Make bmalloc work with ASan
1240         https://bugs.webkit.org/show_bug.cgi?id=140194
1241
1242         Reviewed by Mark Lam.
1243
1244         * asan/asan.xcconfig: No need to disable FastMalloc; bmalloc supports
1245         ASan automatically (by forwarding to system malloc at runtime).
1246
1247 2015-01-09  Daniel Bates  <dabates@apple.com>
1248
1249         [iOS] Make DumpRenderTree build with public SDK
1250         https://bugs.webkit.org/show_bug.cgi?id=140311
1251
1252         Reviewed by Sam Weinig.
1253
1254         Use CGRound() instead of the obsolete macro function _ROUNDF_ (defined in
1255         header UIKit/UIMath.h), and std::max() instead of the macro function MAX.
1256         Additionally, remove unused header CoreGraphics/CGFontDB.h.
1257
1258         * DumpRenderTree/mac/DumpRenderTree.mm:
1259         (-[ScrollViewResizerDelegate view:didSetFrame:oldFrame:asResultOfZoom:]):
1260
1261 2015-01-09  Alexey Proskuryakov  <ap@apple.com>
1262
1263         platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html fails on Retina machines
1264         https://bugs.webkit.org/show_bug.cgi?id=140300
1265
1266         Reviewed by Simon Fraser.
1267
1268         * WebKitTestRunner/TestController.cpp:
1269         (WTR::TestController::createOtherPage):
1270         (WTR::TestController::updateWindowScaleForTest):
1271         (WTR::TestController::configureViewForTest):
1272         * WebKitTestRunner/TestController.h:
1273
1274 2015-01-09  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1275
1276         Unreviewed. Moving myself to the committer section.
1277
1278         * Scripts/webkitpy/common/config/contributors.json:
1279
1280 2015-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1281
1282         Add a script to check for platform layering violations
1283         https://bugs.webkit.org/show_bug.cgi?id=140248
1284
1285         Reviewed by Darin Adler.
1286
1287         It prints all the cases where files inside platform include
1288         headers that are not in platform directory.
1289
1290         * Scripts/check-for-platform-layering-violations: Added.
1291         (get_platform_headers):
1292         (check_source_file):
1293
1294 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
1295
1296         [Mac WK2] Test snapshots are 1600x1200 on Retina devices
1297         https://bugs.webkit.org/show_bug.cgi?id=139884
1298
1299         Reviewed by Tim Horton.
1300
1301         * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
1302         Tell CGWindowListCreateImage to use the correct resolution. I don't really understand
1303         what the "nominal resolution" is, but this appears to work in practice.
1304
1305 2015-01-08  Brent Fulgham  <bfulgham@apple.com>
1306
1307         [Win] DumpRenderTree is always using 800x600 size, even if tests need other size.
1308         https://bugs.webkit.org/show_bug.cgi?id=140256
1309
1310         Reviewed by Anders Carlsson.
1311
1312         * DumpRenderTree/win/DumpRenderTree.cpp:
1313         (resetWebPreferencesToConsistentValues): Drive-by fix of a buffer overrun found while
1314         running with heap validation checks.
1315         (sizeWebViewForCurrentTest): Check both path separators ('/' and '\\') when checking for
1316         the "svg\\W3C-SVG-1.1" test directory.
1317         (removeFontFallbackIfPresent): Use nullptr instead of 0.
1318         * DumpRenderTree/win/TestRunnerWin.cpp:
1319         (TestRunner::clearPersistentUserStyleSheet): Ditto.
1320
1321 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
1322
1323         Follow-up to:  When WebProcess is slow to respond to IPC, that's mistakenly reported as crash
1324         https://bugs.webkit.org/show_bug.cgi?id=140218
1325
1326         * Scripts/webkitpy/port/driver.py: (Driver._check_for_driver_crash_or_unresponsiveness):
1327         Undone an accidental change - check for self.has_crashed() again. This code path
1328         is for ports that don't have a signal handler printing #CRASHED when main process
1329         crashes.
1330
1331         * Scripts/webkitpy/port/driver_unittest.py:
1332         (DriverTest.test_check_for_driver_crash.assert_crash):
1333         (DriverTest.test_check_for_driver_crash):
1334         Updated the tests, all changes are expected.
1335
1336 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
1337
1338         When WebProcess is slow to respond to IPC, that's mistakenly reported as crash
1339         https://bugs.webkit.org/show_bug.cgi?id=140218
1340
1341         Reviewed by Darin Adler.
1342
1343         * Scripts/webkitpy/port/driver.py:
1344         (Driver.__init__): Removed _subprocess_was_unresponsive that was a modifier for
1345         "process crashed" condition. These don't make sense together - it's either a crash
1346         or a timeout, and we should detect those properly at a much lower level.
1347         (Driver.run_test): Ditto.
1348         (Driver._check_for_driver_crash_or_unresponsiveness): Split crash and unresponsiveness
1349         cases.
1350
1351         * WebKitTestRunner/TestController.h:
1352         * WebKitTestRunner/TestController.cpp:
1353         (WTR::TestController::webProcessName): 
1354         (WTR::TestController::processDidCrash):
1355         Factored out hardcoded child process names, as we now use these in two places.
1356
1357         * WebKitTestRunner/TestInvocation.cpp:
1358         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Dump an accurate child
1359         process name, so that it can be sampled (fixes sampling on Mavericks and above).
1360
1361 2015-01-08  Zan Dobersek  <zdobersek@igalia.com>
1362
1363         Reorder my list of email addresses, keeping the Bugzilla address at the
1364         top since Bugzilla and other webkitpy scripts rely on that ordering.
1365
1366         * Scripts/webkitpy/common/config/contributors.json:
1367
1368 2015-01-08  Zan Dobersek  <zdobersek@igalia.com>
1369
1370         Moving myself to the reviewers section and updating
1371         the list of my email addresses.
1372
1373         * Scripts/webkitpy/common/config/contributors.json:
1374
1375 2015-01-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1376
1377         [GTK] Build gtk-doc without gtkdoc-mktmpl
1378         https://bugs.webkit.org/show_bug.cgi?id=140225
1379
1380         Reviewed by Darin Adler.
1381
1382         Stop calling gtkdoc-mktmpl. It's being removed upstream, and since we
1383         don't modify the tmpl files that it generates, it's not doing anything
1384         for us.
1385
1386         * gtk/gtkdoc.py:
1387         (GTKDoc.generate):
1388         (GTKDoc._run_gtkdoc_scangobj):
1389         (GTKDoc._run_gtkdoc_mktmpl): Deleted.
1390
1391 2015-01-07  Gwang Yoon Hwang  <yoon@igalia.com>
1392
1393         [GTK][ThreadedCompositor] Add support for threaded compositor.
1394         https://bugs.webkit.org/show_bug.cgi?id=118265
1395
1396         Reviewed by Martin Robinson.
1397
1398         Added the ENABLE_THREADED_COMPOSITOR feature flag to the cmake and
1399         autotools build systems. The feature is disabled by default.
1400         And remove deprecated the WTF_USE_TILED_BACKING_STORE feature flag
1401         from the feature flags.
1402
1403         * Scripts/webkitperl/FeatureList.pm:
1404
1405 2015-01-07  Daniel Bates  <dabates@apple.com>
1406
1407         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
1408         https://bugs.webkit.org/show_bug.cgi?id=137371
1409
1410         Reviewed by David Kilzer.
1411
1412         Use SPI wrapper headers instead of directly referencing private SPI headers.
1413
1414         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
1415         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1416         * DumpRenderTree/mac/Configurations/Base.xcconfig: Append directory Source/WebKit2/Platform/spi/ios
1417         to the list of iOS header search directories so that we can include header UIKitSPI.h.
1418         * DumpRenderTree/mac/DumpRenderTree.mm:
1419         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1420         * DumpRenderTree/mac/EventSendingController.mm:
1421         * DumpRenderTree/mac/TestRunnerMac.mm:
1422
1423 2015-01-07  Commit Queue  <commit-queue@webkit.org>
1424
1425         Unreviewed, rolling out r178068.
1426         https://bugs.webkit.org/show_bug.cgi?id=140235
1427
1428         Breaks the iOS build (Requested by enrica on #webkit).
1429
1430         Reverted changeset:
1431
1432         "[iOS] Make WebKit2 build with public iOS SDK and more build
1433         fixes for DRT"
1434         https://bugs.webkit.org/show_bug.cgi?id=137371
1435         http://trac.webkit.org/changeset/178068
1436
1437 2015-01-07  Daniel Bates  <dabates@apple.com>
1438
1439         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
1440         https://bugs.webkit.org/show_bug.cgi?id=137371
1441
1442         Reviewed by David Kilzer.
1443
1444         Use SPI wrapper headers instead of directly referencing private SPI headers.
1445
1446         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
1447         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1448         * DumpRenderTree/mac/Configurations/Base.xcconfig: Append directory Source/WebKit2/Platform/spi/ios
1449         to the list of header search directories so that we can include header UIKitSPI.h.
1450         * DumpRenderTree/mac/DumpRenderTree.mm:
1451         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1452         * DumpRenderTree/mac/EventSendingController.mm:
1453         * DumpRenderTree/mac/TestRunnerMac.mm:
1454
1455 2015-01-07  Brent Fulgham  <bfulgham@apple.com>
1456
1457         [Win] Unreviewed test change to improve run reproducibility
1458
1459         * Scripts/webkitpy/port/win.py:
1460         (WinPort.default_child_processes): Run a single DRT instance to help
1461         identify failures caused by earlier test runs.
1462
1463 2015-01-07  Myles C. Maxfield  <mmaxfield@apple.com>
1464
1465         Myles C. Maxfield is a reviewer now
1466         https://bugs.webkit.org/show_bug.cgi?id=140196
1467
1468         Reviewed by Dean Jackson.
1469
1470         * Scripts/webkitpy/common/config/contributors.json:
1471
1472 2015-01-07  Myles C. Maxfield  <mmaxfield@apple.com>
1473
1474         Make webkit-patch try harder to find keychain credentials
1475         https://bugs.webkit.org/show_bug.cgi?id=140170
1476
1477         Reviewed by Ryosuke Niwa.
1478
1479         When the user manually enters a password into webkit-patch, we hand that off to the
1480         Keyring Python module. However, that module creates a generic password entry instead
1481         of an internet password entry. We should look for both kinds.
1482
1483         * Scripts/webkitpy/common/net/credentials.py:
1484         (Credentials._run_security_tool):
1485         (Credentials._credentials_from_keychain):
1486         * Scripts/webkitpy/common/net/credentials_unittest.py:
1487         (test_security_output_parse_entry_not_found):
1488         (_assert_security_call):
1489
1490 2015-01-06  Anders Carlsson  <andersca@apple.com>
1491
1492         Try to fix the Mountain Lion build.
1493
1494         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
1495         (TestWebKitAPI::didGetImageForMatchResult):
1496
1497 2015-01-06  Alexey Proskuryakov  <ap@apple.com>
1498
1499         Debug ASan builds frequently crash in Register::jsValue under DFG::prepareOSREntry
1500         https://bugs.webkit.org/show_bug.cgi?id=140095
1501
1502         Reviewed by Anders Carlsson.
1503
1504         * asan/webkit-asan-ignore.txt: Blacklist a function that gets inlined in release
1505         builds, but not in debug ones.
1506
1507 2015-01-06  Brent Fulgham  <bfulgham@apple.com>
1508
1509         [Win] Extend WinLauncher with support for Page Zoom
1510         https://bugs.webkit.org/show_bug.cgi?id=140152
1511
1512         Reviewed by Anders Carlsson.
1513
1514         * WinLauncher/Common.cpp:
1515         (WndProc):
1516         * WinLauncher/WinLauncher.cpp:
1517         (WinLauncher::resetZoom):
1518         (WinLauncher::zoomIn):
1519         (WinLauncher::zoomOut):
1520         * WinLauncher/WinLauncher.h:
1521         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc:
1522         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
1523         * win/DLLLauncher/DLLLauncherMain.cpp:
1524         (wWinMain):
1525
1526 2015-01-06  Anders Carlsson  <andersca@apple.com>
1527
1528         Fix API tests that are broken under HiDPI
1529         https://bugs.webkit.org/show_bug.cgi?id=140146
1530
1531         Reviewed by Tim Horton.
1532
1533         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
1534         (TestWebKitAPI::didGetImageForMatchResult):
1535         NSImages are measured in points, so grab the underlying bitmap image and get its size in pixels.
1536
1537         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
1538         (TestWebKitAPI::DeviceScaleFactorOnBack::runTest):
1539         Don't assume that a web view not in a window has a backing scale factor of 1. Instead, always have web views start
1540         out in a window that has a backing scale factor of 1.
1541  
1542         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
1543         (TestWebKitAPI::DynamicDeviceScaleFactor::runTest):
1544         Ditto.
1545
1546 2015-01-06  Alexey Proskuryakov  <ap@apple.com>
1547
1548         ADDRESS_SANITIZER macro is overloaded
1549         https://bugs.webkit.org/show_bug.cgi?id=140130
1550
1551         Reviewed by Anders Carlsson.
1552
1553         * WebKitTestRunner/TestController.cpp: Use the new macro.
1554
1555 2015-01-05  Joseph Pecoraro  <pecoraro@apple.com>
1556
1557         Remove some stale class names in check-for-inappropriate-objc-class-names
1558         https://bugs.webkit.org/show_bug.cgi?id=140104
1559
1560         Reviewed by Darin Adler.
1561
1562         * Scripts/check-for-inappropriate-objc-class-names:
1563         These UIWK* classes no longer exist.
1564
1565 2015-01-05  Anders Carlsson  <andersca@apple.com>
1566
1567         heap-buffer-overflow on fast/loader/reload-zero-byte-plugin.html
1568         https://bugs.webkit.org/show_bug.cgi?id=140096
1569         rdar://problem/19368938
1570
1571         Reviewed by Alexey Proskuryakov.
1572
1573         When creating a new page, don't pass clientInfo when setting up the frame and policy clients,
1574         since clientInfo points to a web view, not the test controller.
1575
1576         * WebKitTestRunner/TestController.cpp:
1577         (WTR::TestController::createOtherPage):
1578
1579 2015-01-05  Hunseop Jeong  <hs85.jeong@samsung.com>
1580
1581         [EFL][GTK] WKPreferencesDefaults test failed after r177506 
1582         https://bugs.webkit.org/show_bug.cgi?id=140077
1583
1584         Reviewed by Csaba Osztrogonác.
1585
1586         WebKit C SPI is available on EFL,GTK.
1587         Changed the define order to pass the API test.
1588
1589         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1590         (TestWebKitAPI::TEST):
1591
1592 2015-01-01  Alexey Proskuryakov  <ap@apple.com>
1593
1594         Simplify WebKitTestRunner timeout tracking
1595         https://bugs.webkit.org/show_bug.cgi?id=140036
1596
1597         Reviewed by Darin Adler.
1598
1599         The code for configuring timeouts was mostly dead, because run-webkit-tests never
1600         passes the --timeout option to WebKitTestRunner.
1601
1602         * WebKitTestRunner/Options.h:
1603         * WebKitTestRunner/Options.cpp:
1604         (WTR::Options::Options):
1605         (WTR::OptionsHandler::OptionsHandler):
1606         (WTR::handleOptionTimeout): Deleted.
1607         Removed support for --timeout. Timeouts are passed for each test individually,
1608         and defaults are good enough for the rare cases where WebKitTestRunner is run
1609         manually without run-webkit-tests.
1610
1611         * WebKitTestRunner/TestController.cpp:
1612         (WTR::TestController::TestController):
1613         (WTR::TestController::initialize):
1614         (WTR::TestController::resetStateToConsistentValues):
1615         (WTR::TestController::reattachPageToWebProcess):
1616         (WTR::TestController::runUntil):
1617         * WebKitTestRunner/TestController.h:
1618         Simplified runUntil by passing the actual timeout, not an enum.
1619         Increased short timeout for ASan enabled builds, as WebProcess launching takes
1620         quite a while.
1621
1622         * WebKitTestRunner/TestInvocation.cpp:
1623         (WTR::TestInvocation::invoke): Removed dead code that handled a timeout from NoTimeout.
1624
1625         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1626         (WTR::TestController::platformRunUntil):
1627         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1628         (WTR::TestController::platformRunUntil):
1629         Build fixes.
1630
1631 2015-01-02  Anders Carlsson  <andersca@apple.com>
1632
1633         Remove now unused storage tracker glue from DumpRenderTree
1634         https://bugs.webkit.org/show_bug.cgi?id=140045
1635
1636         Reviewed by Darin Adler.
1637
1638         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1639         * DumpRenderTree/StorageTrackerDelegate.h: Removed.
1640         * DumpRenderTree/StorageTrackerDelegate.mm: Removed.
1641         * DumpRenderTree/TestRunner.cpp:
1642         (TestRunner::staticFunctions):
1643         (syncLocalStorageCallback): Deleted.
1644         (observeStorageTrackerNotificationsCallback): Deleted.
1645         (deleteAllLocalStorageCallback): Deleted.
1646         (deleteLocalStorageForOriginCallback): Deleted.
1647         (localStorageDiskUsageForOriginCallback): Deleted.
1648         (originsWithLocalStorageCallback): Deleted.
1649         * DumpRenderTree/TestRunner.h:
1650         * DumpRenderTree/mac/DumpRenderTree.mm:
1651         (allocateGlobalControllers):
1652         (releaseGlobalControllers):
1653         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1654         * DumpRenderTree/mac/TestRunnerMac.mm:
1655         (TestRunner::syncLocalStorage): Deleted.
1656         (TestRunner::localStorageDiskUsageForOrigin): Deleted.
1657         (TestRunner::observeStorageTrackerNotifications): Deleted.
1658         (TestRunner::deleteAllLocalStorage): Deleted.
1659         (TestRunner::originsWithLocalStorage): Deleted.
1660         (TestRunner::deleteLocalStorageForOrigin): Deleted.
1661         * DumpRenderTree/win/TestRunnerWin.cpp:
1662         (TestRunner::syncLocalStorage): Deleted.
1663         (TestRunner::localStorageDiskUsageForOrigin): Deleted.
1664         (TestRunner::observeStorageTrackerNotifications): Deleted.
1665         (TestRunner::deleteAllLocalStorage): Deleted.
1666         (TestRunner::originsWithLocalStorage): Deleted.
1667         (TestRunner::deleteLocalStorageForOrigin): Deleted.
1668
1669 2015-01-01  Darin Adler  <darin@apple.com>
1670
1671         We often misspell identifier as "identifer"
1672         https://bugs.webkit.org/show_bug.cgi?id=140025
1673
1674         Reviewed by Michael Saboff.
1675
1676         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1677         * Scripts/webkitdirs.pm:
1678         (appIdentifierFromBundle):
1679         (installAndLaunchIOSWebKitAppInSimulator):
1680         Fix misspellings
1681
1682 2015-01-01  Zalan Bujtas  <zalan@apple.com>
1683
1684         Saturated arithmetics: Incorrect float/double clamping.
1685         https://bugs.webkit.org/show_bug.cgi?id=139888
1686         rdar://problem/19330885
1687
1688         Reviewed by Simon Fraser.
1689
1690         Clamp float and double values correctly when applying saturated arithmetics.
1691
1692         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
1693         (TestWebKitAPI::TEST):
1694
1695 2014-12-30  Krzysztof Czech  <k.czech@samsung.com>
1696
1697         [EFL] Bump version of ATK used by jhbuild to 2.15.2
1698         https://bugs.webkit.org/show_bug.cgi?id=139816
1699
1700         Reviewed by Gyuyoung Kim.
1701
1702         Bump version of ATK used by jhbuild to 2.15.2
1703
1704         * efl/jhbuild.modules:
1705
1706 2014-12-29  Fabien Vallée  <fvallee@connected-labs.com>
1707
1708         [jhBuild] cairo build error (-flto)
1709         https://bugs.webkit.org/show_bug.cgi?id=139056
1710
1711         Reviewed by Philippe Normand.
1712
1713         cairo fails to link  with gcc 4.9 due to lto
1714         related issue. This problem has been partially
1715         addressed by cairo:
1716         http://cgit.freedesktop.org/cairo/commit/?id=c3645d97ebd24c6f7ad850785d585aebc706a11c
1717         use the cairo --disable-lto option and remove jhbuild
1718         makeargs fixes the issue.
1719
1720         * gtk/jhbuild.modules:
1721         * gtk/patches/cairo-1.12.8-add_disable-lto.patch: Added.
1722
1723 2014-12-27  Myles C. Maxfield  <mmaxfield@apple.com>
1724         [Mac] Enable kerning, ligatures, and printer fonts 
1725         https://bugs.webkit.org/show_bug.cgi?id=139970
1726
1727         Rubber stamped by Simon Fraser.
1728
1729         Flip the switch.
1730
1731         * DumpRenderTree/mac/DumpRenderTree.mm:
1732         * WebKitTestRunner/TestController.cpp:
1733         * WebKitTestRunner/mac/main.mm:
1734
1735 2014-12-26  Dan Bernstein  <mitz@apple.com>
1736
1737         <rdar://problem/19348208> REGRESSION (r177027): iOS builds use the wrong toolchain
1738         https://bugs.webkit.org/show_bug.cgi?id=139950
1739
1740         Reviewed by David Kilzer.
1741
1742         * asan/asan.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
1743         in a manner that works with Xcode 5.1.1.
1744
1745 2014-12-24  Dan Bernstein  <mitz@apple.com>
1746
1747         Engineering builds of MiniBrowser ignore deprecated declaration warnings
1748         https://bugs.webkit.org/show_bug.cgi?id=139941
1749
1750         Reviewed by Darin Adler.
1751
1752         * MiniBrowser/Configurations/Base.xcconfig: Added semicolon.
1753         * MiniBrowser/Configurations/DebugRelease.xcconfig: Set GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS
1754         to YES.
1755         * MiniBrowser/mac/AppDelegate.m:
1756         (-[BrowserAppDelegate openDocument:]): Use NSFileHandlingPanelOKButton instead of
1757         deprecated NSOKButton.
1758
1759 2014-12-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1760
1761         W3C test importer should have an option to disable testharness.js/testharnessreport.js link conversion
1762         https://bugs.webkit.org/show_bug.cgi?id=134763
1763
1764         Reviewed by Ryosuke Niwa.
1765
1766         Adding an option to disable test harness link conversion.
1767
1768         * Scripts/webkitpy/w3c/test_converter.py:
1769         (convert_for_webkit):
1770         (_W3CTestConverter.__init__):
1771         (_W3CTestConverter.convert_attributes_if_needed):
1772         * Scripts/webkitpy/w3c/test_importer.py:
1773         (parse_args):
1774         (TestImporter.import_tests):
1775
1776 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
1777
1778         DumpRenderTree crashes are mis-reported as timeouts on Yosemite
1779         https://bugs.webkit.org/show_bug.cgi?id=139933
1780
1781         Reviewed by Daniel Bates.
1782
1783         Crash logs take a very long time to be generated on Yosemite (rdar://problem/18701447),
1784         and there is no way for run-webkit-tests to tell a crashed process from a frozen one
1785         until ReportCrash lets it go.
1786
1787         Reuse existing machinery that tells run-webkit-tests about crashes. The script may
1788         even get the actual crash log eventually - even when it times out waiting for the log, it
1789         makes a second lookup at the very end, after all tests finish. There may be further
1790         improvements needed here, but this small fix addresses most cases that happen in practice.
1791
1792         * DumpRenderTree/mac/DumpRenderTree.mm:
1793         (writeCrashedMessageOnFatalError):
1794         (dumpRenderTree):
1795         Removed PLATFORM(IOS) ifdefs, this code is just as helpful on Mac.
1796
1797         * Scripts/webkitpy/port/driver.py: (Driver._check_for_driver_crash): Removed an
1798         unhelpful comment.
1799
1800 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
1801
1802         Don't force -O1 for debug ASan builds
1803         https://bugs.webkit.org/show_bug.cgi?id=139926
1804
1805         Reviewed by Darin Adler.
1806
1807         * asan/asan.xcconfig:
1808
1809 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
1810
1811         Simplify building with ASan
1812         https://bugs.webkit.org/show_bug.cgi?id=139916
1813
1814         Reviewed by Mark Rowe.
1815
1816         * Scripts/set-webkit-configuration: Store ASan state into a new configuration file.
1817         We could also update Configuration file format, but that's a little scary because
1818         of how many places in code read it.
1819
1820         * Scripts/webkitdirs.pm:
1821         (determineASanIsEnabled): Read it from ASan configuration file.
1822         (argumentsForConfiguration): Added a FIXME.
1823         (asanIsEnabled): A caching wrapper similar to what we have for other configuration options.
1824         (XcodeOptions): Pass the options needed for ASan.
1825
1826         * asan/asan.xcconfig: Use the right toolchains. Made warnings fatal again, as there
1827         no warnings to avoid. Removed explicit linking options, as -fsanitize=address does
1828         that automatically.
1829
1830 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
1831
1832         TestWebKitAPI build is broken when ASan is enabled
1833         https://bugs.webkit.org/show_bug.cgi?id=139902
1834
1835         Reviewed by Darin Adler.
1836
1837         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
1838         * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig:
1839         Inherit linker flags from DebugRelease, which respects ASAN.
1840
1841 2014-12-22  Simon Fraser  <simon.fraser@apple.com>
1842
1843         Sort the Xcode project file.
1844
1845         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1846
1847 2014-12-22  Lucas Forschler  <lforschler@apple.com>
1848
1849         Update apple-mac-114 to bot629.
1850         
1851         Unreviewed.
1852         
1853         * BuildSlaveSupport/build.webkit.org-config/config.json:
1854
1855 2014-12-22  Lucas Forschler  <lforschler@apple.com>
1856
1857         Replace Apple bot104 with bot124.
1858         
1859         Unreviewed.
1860         
1861         * BuildSlaveSupport/build.webkit.org-config/config.json:
1862
1863 2014-12-22  Csaba Osztrogonác  <ossy@webkit.org>
1864
1865         URTBF after r177639.
1866
1867         * TestWebKitAPI/CMakeLists.txt:
1868
1869 2014-12-22  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
1870
1871         [EFL] MiniBrowser steals web view's focus
1872         https://bugs.webkit.org/show_bug.cgi?id=139482
1873
1874         Reviewed by Gyuyoung Kim.
1875
1876         Although we set focus on ewk_view while MiniBrowser initialization
1877         Ecore steals it in a favor of main window. As a result
1878         focused element on web page is unable to receive events.
1879
1880         * MiniBrowser/efl/main.c:
1881         (window_create):
1882         Prevent window from stealing web view's focus on start up.
1883
1884 2014-12-19  Brent Fulgham  <bfulgham@apple.com>
1885
1886         [Win] Revise DRT logic to match Mac.
1887
1888         Rubberstamped by Anders Carlsson.
1889
1890         Update the Windows logic to perform initialization of preferences and WebKit
1891         settings to match Mac. Also make sure that we only ever emit #EOF tokens under
1892         the same circumstances as the Mac version.
1893
1894         * DumpRenderTree/win/DumpRenderTree.cpp:
1895         (dump):
1896         (resetWebPreferencesToConsistentValues):
1897         (setDefaultsToConsistentValuesForTesting):
1898         (resetWebViewToConsistentStateBeforeTesting):
1899         (sizeWebViewForCurrentTest):
1900         (runTest):
1901         (createWebViewAndOffscreenWindow):
1902         (allocateGlobalControllers):
1903         (prepareConsistentTestingEnvironment):
1904         (main):
1905         (resetDefaultsToConsistentValues): Deleted.
1906
1907 2014-12-19  Roger Fong  <roger_fong@apple.com>
1908
1909         Unreviewed. Rollout r177605.
1910
1911         * EWSTools/start-queue-win.sh:
1912
1913 2014-12-19  Roger Fong  <roger_fong@apple.com>
1914
1915         Unreviewed. Try running EWS scripts without —no-confirm, since it defaults to true.
1916
1917         * EWSTools/start-queue-win.sh:
1918
1919 2014-12-19  Daniel Bates  <dabates@apple.com>
1920
1921         [iOS] Add WebKitSystemInterface for iOS 8.1
1922         https://bugs.webkit.org/show_bug.cgi?id=139831
1923
1924         Reviewed by Alexey Proskuryakov.
1925
1926         Implement support in copy-webkitlibraries-to-product-directory to copy
1927         WebKitSystemInterface for iOS to the product directory and have build-webkit
1928         pass --wksi to copy-webkitlibraries-to-product-directory when building for iOS.
1929
1930         * Scripts/build-webkit:
1931         * Scripts/copy-webkitlibraries-to-product-directory:
1932
1933 2014-12-19  Daniel Bates  <dabates@apple.com>
1934
1935         copy-webkitlibraries-to-product-directory uses wrong SDK when called from build-webkit
1936         https://bugs.webkit.org/show_bug.cgi?id=139829
1937
1938         Reviewed by Alexey Proskuryakov.
1939
1940         The script build-webkit calls script copy-webkitlibraries-to-product-directory with
1941         argument --sdk to specify the Xcode SDK to use, but copy-webkitlibraries-to-product-directory
1942         expects the Xcode SDK to be specified using the --sdk-name command line argument.
1943
1944         Currently copy-webkitlibraries-to-product-directory has its own logic to handle
1945         parsing for a specified Xcode SDK. Instead we should make use of the webkitdirs.pm
1946         logic to both avoid duplicating effort and make the command line options for
1947         copy-webkitlibraries-to-product-directory for specify the Xcode SDK consistent
1948         with the approach used in other WebKit tools.
1949
1950         As a side effect of making use of the webkitdirs.pm logic for determining the Xcode SDK
1951         copy-webkitlibraries-to-product-directory now recognizes --device and --simulator
1952         shorthands for --sdk=iphoneos.internal and --sdk=iphonesimulator, respectively.
1953
1954         * Scripts/copy-webkitlibraries-to-product-directory: Also, renamed some variables to
1955         improve the readability of the code.
1956         (executeRanlib): Added; convenience function that calls the RANLIB(1) with the appropriate
1957         Xcode SDK. We pass -no_warning_for_no_symbols to RANLIB(1) when using an Xcode SDK
1958         for iOS since it's acceptable that an empty object file (say, for a Mac-specific feature)
1959         be included in a library.
1960         (unpackIfNecessary): Modified to call executeRanlib().
1961
1962 2014-12-19  Alexey Proskuryakov  <ap@apple.com>
1963
1964         REGRESSION (177368): Some tests started to immediately time out
1965         https://bugs.webkit.org/show_bug.cgi?id=139826
1966
1967         Reviewed by Daniel Bates.
1968
1969         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::done):
1970         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::dump):
1971         Move invalidateWaitToDumpWatchdogTimer() call from dump() to done(). When a test
1972         ends in a load failure, we don't dump, so we used to leak the timer.
1973         
1974         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::notifyDone):
1975         Added a comment.
1976
1977 2014-12-19  Brent Fulgham  <bfulgham@apple.com>
1978
1979         [Win] Add accessor for serializing HTTP loads
1980         https://bugs.webkit.org/show_bug.cgi?id=139817
1981
1982         Reviewed by Mark Lam.
1983
1984         * DumpRenderTree/win/DumpRenderTree.cpp: Reset serialized HTTP loads in our reset method.
1985         * DumpRenderTree/win/TestRunnerWin.cpp: Provide implementation for serializing HTTP. Also
1986         remove some redundant code from the destructor.
1987
1988 2014-12-19  Alexey Proskuryakov  <ap@apple.com>
1989
1990         Clean up a fix for performance test bot failing to build
1991         https://bugs.webkit.org/show_bug.cgi?id=139818
1992
1993         Reviewed by Csaba Osztrogonác.
1994
1995         The "_1" in step name was annoying.
1996
1997         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1998         (CleanBuildIfScheduled.start):
1999         (RunAndUploadPerfTests):
2000         (DownloadAndPerfTestFactory.__init__):
2001         (DownloadAndPerfTestWebKit2Factory.__init__):
2002         (CleanBuildUnconditionally): Deleted.
2003         (CleanBuildUnconditionally.start): Deleted.
2004
2005 2014-12-19  Csaba Osztrogonác  <ossy@webkit.org>
2006
2007         REGRESSION(r177535): It broke the GTK performance bot
2008         https://bugs.webkit.org/show_bug.cgi?id=139811
2009
2010         Reviewed by Carlos Garcia Campos.
2011
2012         Trigger clean build only on mac platform.
2013
2014         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2015         (DownloadAndPerfTestFactory.__init__):
2016         (DownloadAndPerfTestWebKit2Factory.__init__):
2017
2018 2014-12-18  KwangHyuk Kim  <hyuki.kim@samsung.com>
2019
2020         Unreviewed, moved myself to the list of committers.
2021
2022         * Scripts/webkitpy/common/config/contributors.json:
2023
2024 2014-12-18  Brent Fulgham  <bfulgham@apple.com>
2025
2026         [Win] Update DumpRenderTree to more closely match Mac version
2027         https://bugs.webkit.org/show_bug.cgi?id=139799
2028
2029         Reviewed by Tim Horton.
2030
2031         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2032         (AccessibilityController::accessibleElementById): Correct
2033         use of BSTR to avoid leak.
2034         * DumpRenderTree/win/DumpRenderTree.cpp: Reorder methods and
2035         update to match Mac version more closely.
2036         (dumpFramesAsText):
2037         (dump):
2038         (resetDefaultsToConsistentValues):
2039         (resetWebViewToConsistentStateBeforeTesting):
2040         (sizeWebViewForCurrentTest):
2041         (runTest):
2042         (openWindows):
2043         (windowToWebViewMap):
2044         (createWebViewAndOffscreenWindow):
2045         (sharedCFURLCache):
2046         (initializeGlobalsFromCommandLineOptions):
2047         (main):
2048         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
2049         (TestRunner::addDisallowedURL):
2050         (TestRunner::applicationCacheDiskUsageForOrigin):
2051         (TestRunner::syncLocalStorage):
2052         (TestRunner::localStorageDiskUsageForOrigin):
2053         (TestRunner::observeStorageTrackerNotifications):
2054         (TestRunner::clearApplicationCacheForOrigin):
2055         (TestRunner::originsWithApplicationCache):
2056         (TestRunner::deleteAllLocalStorage):
2057         (TestRunner::setStorageDatabaseIdleInterval):
2058         (TestRunner::closeIdleLocalStorageDatabases):
2059         (TestRunner::originsWithLocalStorage):
2060         (TestRunner::deleteLocalStorageForOrigin):
2061         (TestRunner::copyDecodedHostName):
2062         (TestRunner::copyEncodedHostName):
2063         (TestRunner::keepWebHistory):
2064         (TestRunner::numberOfPendingGeolocationPermissionRequests):
2065         (TestRunner::setAppCacheMaximumSize):
2066         (TestRunner::setCustomPolicyDelegate):
2067         (TestRunner::goBack):
2068         (TestRunner::setDefersLoading):
2069         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
2070         (TestRunner::setMockDeviceOrientation):
2071         (TestRunner::setMockGeolocationPosition):
2072         (TestRunner::setMockGeolocationPositionUnavailableError):
2073         (TestRunner::setIconDatabaseEnabled):
2074         (TestRunner::setMainFrameIsFirstResponder):
2075         (TestRunner::setSpatialNavigationEnabled):
2076         (TestRunner::setPluginsEnabled):
2077         (TestRunner::setAutomaticLinkDetectionEnabled):
2078         (TestRunner::setUseDashboardCompatibilityMode):
2079         (TestRunner::dispatchPendingLoadRequests):
2080         (TestRunner::findString):
2081         (TestRunner::setCacheModel):
2082         (TestRunner::apiTestNewWindowDataLoadBaseURL):
2083         (TestRunner::setWebViewEditable):
2084         (TestRunner::authenticateSession):
2085         (TestRunner::abortModal):
2086         (TestRunner::setSerializeHTTPLoads):
2087         (TestRunner::addChromeInputField):
2088         (TestRunner::removeChromeInputField):
2089         (TestRunner::focusWebView):
2090         (TestRunner::setBackingScaleFactor):
2091         (TestRunner::grantWebNotificationPermission):
2092         (TestRunner::denyWebNotificationPermission):
2093         (TestRunner::removeAllWebNotificationPermissions):
2094         (TestRunner::simulateWebNotificationClick):
2095
2096 2014-12-18  Gavin Barraclough  <barraclough@apple.com>
2097
2098         Add strong typing to RefCounter interface, return value as a bool.
2099         https://bugs.webkit.org/show_bug.cgi?id=139776
2100
2101         Reviewed by Geoff Garen.
2102
2103         Currently all token vended by a RefCounter have the same type - Ref<RefCounter::Count>.
2104         This means there is no compile time type checking to prevent mistakes. Update the count()
2105         method to token<>(), templated on type used to identify the token being returned.
2106         Calls to token<T>() will return a result of type RefCounter::Token<T>.
2107
2108         There are a few problems with the fact the counter will return you an exact count of the
2109         number of outstanding tokens:
2110           - It is desirable to only fire the callback on zero-edge changes; it is more consistent
2111             to do so if the value is only readable as a boolean.
2112           - It is desirable to provide the value as an argument to the callback, however to make
2113             this useful for integer values it is also necessary to indicate the direction of change
2114             (0->1 is often interesting where 2->1 is not).
2115           - There is a mismatch between the precision of returning a count, and the inherent
2116             imprecision of a token based mechanism, where it may be difficult to guarantee
2117             absolutely no unnecessary refcount churn, and thus unintentional counter values.
2118
2119         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
2120         (TestWebKitAPI::TEST):
2121             - update API test.
2122
2123 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
2124
2125         Disable retries on Mac Release WK2 testers
2126         https://bugs.webkit.org/show_bug.cgi?id=139798
2127
2128         Reviewed by Simon Fraser.
2129
2130         * BuildSlaveSupport/build.webkit.org-config/config.json:
2131
2132 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
2133
2134         Perf tests frequently fail saying "build not up to date"
2135         https://bugs.webkit.org/show_bug.cgi?id=139786
2136
2137         Illegitimately yet authoritatively reviewed by Lucas Forschler.
2138
2139         Undo the rest of the first fix, and implement the behavior differently.
2140
2141         is_clean isn't automatically forwarded from config.json to properties.
2142
2143         * BuildSlaveSupport/build.webkit.org-config/config.json:
2144         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2145         (CleanBuildUnconditionally):
2146         (CleanBuildUnconditionally.start):
2147         (DownloadAndPerfTestFactory.__init__):
2148         (DownloadAndPerfTestWebKit2Factory.__init__):
2149
2150 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
2151
2152         Roll out part of the previous patch - BuildAndPerfTestWebKit2 is used by Efl.
2153         I thought that it was unused because grepping for BuildAndPerfTestWebKit2Factory
2154         found nothing.
2155
2156         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2157         (BuildAndPerfTestFactory):
2158         (BuildAndPerfTestWebKit2Factory):
2159
2160 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
2161
2162         Perf tests frequently fail saying "build not up to date"
2163         https://bugs.webkit.org/show_bug.cgi?id=139786
2164
2165         Reviewed by Ryosuke Niwa.
2166
2167         Perf tests only build DumpRenderTree, not WebKit itself. Just clean the build
2168         directory to get rid of stale precompiled headers, and let it rebuild
2169         DumpRenderTree each time, that's fast.
2170
2171         Also, removed unused "build and perf test" code.
2172
2173         * BuildSlaveSupport/build.webkit.org-config/config.json:
2174
2175 2014-12-18  Brent Fulgham  <bfulgham@apple.com>
2176
2177         [Win] Unreviewed gardening. Reorder file contents to match Mac version.
2178
2179         Reorder the contents of the TestRunnerWin so that it matches TestRunnerMac. This makes
2180         it easier to see what steps are missing when running under Windows.
2181
2182         * DumpRenderTree/win/TestRunnerWin.cpp:
2183         (TestRunner::callShouldCloseOnWebView):
2184         (TestRunner::clearAllApplicationCaches):
2185         (TestRunner::applicationCacheDiskUsageForOrigin):
2186         (TestRunner::syncLocalStorage):
2187         (TestRunner::localStorageDiskUsageForOrigin):
2188         (TestRunner::observeStorageTrackerNotifications):
2189         (TestRunner::clearApplicationCacheForOrigin):
2190         (TestRunner::originsWithApplicationCache):
2191         (TestRunner::clearAllDatabases):
2192         (TestRunner::deleteAllLocalStorage):
2193         (TestRunner::setStorageDatabaseIdleInterval):
2194         (TestRunner::closeIdleLocalStorageDatabases):
2195         (TestRunner::originsWithLocalStorage):
2196         (TestRunner::deleteLocalStorageForOrigin):
2197         (TestRunner::numberOfPendingGeolocationPermissionRequests):
2198         (jsStringRefToWString):
2199         (TestRunner::setAppCacheMaximumSize):
2200         (TestRunner::setDatabaseQuota):
2201         (TestRunner::goBack):
2202         (TestRunner::setDefersLoading):
2203         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
2204         (TestRunner::setAutomaticLinkDetectionEnabled):
2205         (TestRunner::dispatchPendingLoadRequests):
2206         (TestRunner::overridePreference):
2207         (TestRunner::removeAllVisitedLinks):
2208         (TestRunner::waitForPolicyDelegate):
2209         (TestRunner::resetPageVisibility):
2210         (TestRunner::setPageVisibility):
2211         (TestRunner::grantWebNotificationPermission):
2212         (TestRunner::denyWebNotificationPermission):
2213         (TestRunner::removeAllWebNotificationPermissions):
2214         (TestRunner::simulateWebNotificationClick):
2215         (TestRunner::simulateLegacyWebNotificationClick):
2216
2217 2014-12-18  Brent Fulgham  <bfulgham@apple.com>
2218
2219         [Win] Correct Windows tests after Bug 139149 (edit)
2220         https://bugs.webkit.org/show_bug.cgi?id=139781
2221
2222         Reviewed by Anders Carlsson.
2223
2224         * DumpRenderTree/win/TestRunnerWin.cpp:
2225         (TestRunner::clearAllApplicationCaches): Use new WebApplicationCache
2226         interface.
2227
2228 2014-12-18  Simon Fraser  <simon.fraser@apple.com>
2229
2230         [iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim) in arguments for build and test scripts
2231         https://bugs.webkit.org/show_bug.cgi?id=139748
2232
2233         Reviewed by Daniel Bates.
2234         
2235         Staging change to support --ios-sim and --ios-simulator temporarily until the bots
2236         have all been updated.
2237
2238         * Scripts/webkitpy/port/factory.py:
2239         (platform_options):
2240
2241 2014-12-18  Simon Fraser  <simon.fraser@apple.com>
2242
2243         Build more of TestWebKitAPI for iOS
2244         https://bugs.webkit.org/show_bug.cgi?id=139747
2245
2246         Reviewed by Daniel Bates.
2247         
2248         Base.xcconfig removed many test files from the iOS build via EXCLUDED_SOURCE_FILE_NAMES,
2249         which excluded some tests that should be run for iOS.
2250         
2251         Fix by removing some patterns from EXCLUDED_SOURCE_FILE_NAMES, and #ifdeffing
2252         source files instead. config.h defines WK_HAVE_C_SPI when the WebKit C SPI is
2253         available (i.e. Mac OS X), and most files use that. Some files with Mac-only
2254         functionality (ActionMenus, Downloads) use #if PLATFORM(MAC).
2255         
2256         Added PlatformUtilitiesCocoa.mm and moved WeakObjCPtr.mm into a cocoa directory
2257         to share code between Mac and iOS.
2258
2259         * TestWebKitAPI/Configurations/Base.xcconfig:
2260         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
2261         * TestWebKitAPI/InjectedBundleController.cpp:
2262         * TestWebKitAPI/InjectedBundleMain.cpp:
2263         * TestWebKitAPI/JavaScriptTest.cpp:
2264         * TestWebKitAPI/PlatformUtilities.cpp:
2265         * TestWebKitAPI/PlatformUtilities.h:
2266         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2267         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
2268         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
2269         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
2270         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
2271         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp:
2272         * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp:
2273         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
2274         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
2275         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
2276         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
2277         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
2278         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp:
2279         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
2280         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
2281         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
2282         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
2283         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
2284         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
2285         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
2286         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
2287         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
2288         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
2289         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
2290         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
2291         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
2292         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2293         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
2294         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp:
2295         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
2296         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
2297         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
2298         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
2299         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
2300         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
2301         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
2302         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp:
2303         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
2304         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
2305         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
2306         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
2307         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
2308         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
2309         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp:
2310         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
2311         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
2312         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
2313         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
2314         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp:
2315         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
2316         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
2317         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
2318         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2319         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2320         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
2321         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
2322         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
2323         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
2324         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
2325         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
2326         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
2327         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
2328         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
2329         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
2330         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp:
2331         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
2332         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
2333         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
2334         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
2335         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:
2336         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
2337         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
2338         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
2339         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp:
2340         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp:
2341         * TestWebKitAPI/Tests/WebKit2/UserMessage_Bundle.cpp:
2342         * TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp:
2343         * TestWebKitAPI/Tests/WebKit2/WKPageGetScaleFactorNotZero.cpp:
2344         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
2345         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2346         (TestWebKitAPI::TEST):
2347         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
2348         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
2349         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
2350         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
2351         * TestWebKitAPI/Tests/WebKit2/WebCoreStatisticsWithNoWebProcess.cpp:
2352         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
2353         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
2354         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent.cpp:
2355         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
2356         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm.
2357         (TEST):
2358         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2359         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
2360         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
2361         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm:
2362         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
2363         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
2364         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2365         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
2366         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
2367         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
2368         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp.
2369         (TestWebKitAPI::Util::run):
2370         (TestWebKitAPI::Util::sleep):
2371         (TestWebKitAPI::Util::toSTD):
2372         * TestWebKitAPI/config.h:
2373         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
2374         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2375         (TestWebKitAPI::Util::run): Deleted.
2376         (TestWebKitAPI::Util::sleep): Deleted.
2377         (TestWebKitAPI::Util::toSTD): Deleted.
2378
2379 2014-12-18  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
2380
2381         [GTK] Add support for FTL JIT on ARM64
2382         https://bugs.webkit.org/show_bug.cgi?id=139677
2383
2384         Reviewed by Csaba Osztrogonác.
2385
2386         * gtk/jhbuild-optional.modules:
2387         * gtk/patches/llvm-elf-add-stackmaps-arm64.patch: Added.
2388         * gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range-arm64.patch: Added.
2389
2390 2014-12-18  Adrian Perez de Castro  <aperez@igalia.com>
2391
2392         [GTK] Implement webkit_web_view_is_playing_audio()
2393         https://bugs.webkit.org/show_bug.cgi?id=138918
2394
2395         Reviewed by Carlos Garcia Campos.
2396
2397         Add test case case for webkit_web_view_is_playing_audio() and the
2398         WebKitWebView::is-playing-audio property.
2399
2400         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2401         (urlForResource): Utility function to get URLs pointing to resources
2402         under the Tools/TestWebKitAPI/Tests/WebKit2/ directory.
2403         (testWebViewIsPlayingAudio): Added.
2404         (beforeAll):
2405         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2406         (getResourcesDir): Allow passing a flag to choose from the WebKit2 GTK
2407         API tests resources directory, or the WebKit2 C API tests resources
2408         directory. The default value of the flag is to use the WebKit2 GTK
2409         one, to avoid having to change existing tests.
2410         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2411         (isPlayingAudioChanged): Added.
2412         (WebViewTest::waitUntilIsPlayingAudioChanged): Added.
2413         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2414
2415 2014-12-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2416
2417         [GTK] [EFL] Enable per_test_timeout
2418         https://bugs.webkit.org/show_bug.cgi?id=139771
2419
2420         Reviewed by Csaba Osztrogonác.
2421
2422         This is needed to make WKTR use either the default port timeout, or the
2423         user supplied timeout via the "--time-out-ms" parameter of run-webkit-tests.
2424         Otherwise WTR will use the default (30 seconds after r177363 and r177471).
2425
2426         * Scripts/webkitpy/port/efl.py:
2427         (EflPort.supports_per_test_timeout): Enabled.
2428         * Scripts/webkitpy/port/gtk.py:
2429         (GtkPort.supports_per_test_timeout): Enabled.
2430
2431 2014-12-17  Lucas Forschler  <lforschler@apple.com>
2432
2433         Move Apple buildbot slaves to their new home.
2434         
2435         Reviewed by Roger Fong.
2436
2437         * BuildSlaveSupport/build.webkit.org-config/config.json:
2438
2439 2014-12-17  Alexey Proskuryakov  <ap@apple.com>
2440
2441         REGRESSION (r177363): Gtk and Efl testing is broken
2442         https://bugs.webkit.org/show_bug.cgi?id=139734
2443
2444         Reviewed by Simon Fraser.
2445
2446         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2447         (SingleTestRunner.__init__): Remove timeout adjustment from here, because it
2448         affected both script and tool timeout. This is still the right place for this logic,
2449         but it would be a larger refactoring than I can do right now.
2450
2451         * Scripts/webkitpy/port/base.py:
2452         (Port.supports_per_test_timeout): Added a FIXME.
2453         (Port.default_timeout_ms): Now that the effective timeout is longer, change this
2454         to avoid making tests take more time.
2455
2456         * Scripts/webkitpy/port/driver.py:
2457         (Driver.run_test): Adjust script timeout here.
2458         (Driver._check_for_driver_timeout): Fix the timeout detection.
2459         (Driver._read_block): Actually use the timeout detection code.
2460
2461         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):
2462         Use TestRunner default timeout when there isn't a timeout passed from command line for the test.
2463
2464         * Scripts/webkitpy/port/port_testcase.py: (PortTestCase.test_default_timeout_ms):
2465         Update results for the new default.
2466
2467         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2468         (RunTest.test_hung_thread): Restore a test that I previously deleted, it was
2469         actually a good one.
2470
2471 2014-12-17  Commit Queue  <commit-queue@webkit.org>
2472
2473         Unreviewed, rolling out r177456.
2474         https://bugs.webkit.org/show_bug.cgi?id=139749
2475
2476         Broke webkitpy and Mac tests (Requested by ap on #webkit).
2477
2478         Reverted changeset:
2479
2480         "REGRESSION (r177363): Gtk and Efl testing is broken"
2481         https://bugs.webkit.org/show_bug.cgi?id=139734
2482         http://trac.webkit.org/changeset/177456
2483
2484 2014-12-17  Alexey Proskuryakov  <ap@apple.com>
2485
2486         REGRESSION (r177363): Gtk and Efl testing is broken
2487         https://bugs.webkit.org/show_bug.cgi?id=139734
2488
2489         Reviewed by Simon Fraser.
2490
2491         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2492         (SingleTestRunner.__init__): Remove timeout adjustment from here, because it
2493         affected both script and tool timeout. This is still the right place for this logic,
2494         but it would be a larger refactoring than I can do right now.
2495
2496         * Scripts/webkitpy/port/base.py:
2497         (Port.supports_per_test_timeout): Added a FIXME.
2498         (Port.default_timeout_ms): Now that the effective timeout is longer, change this
2499         to avoid making tests take more time.
2500
2501         * Scripts/webkitpy/port/driver.py: (Driver.run_test): Adjust script timeout here.
2502
2503         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):
2504         Use TestRunner default timeout when there isn't a timeout passed from command line for the test.
2505
2506 2014-12-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2507
2508         [GTK] Simplify timeout handling in TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded
2509         https://bugs.webkit.org/show_bug.cgi?id=139725
2510
2511         Reviewed by Martin Robinson.
2512
2513         The timeout is already in milliseconds, so we don't need to do any conversion.
2514
2515         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2516         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2517
2518 2014-12-17  Hunseop Jeong  <hs85.jeong@samsung.com>
2519
2520         [EFL]Fix build warning in MiniBrowser
2521         https://bugs.webkit.org/show_bug.cgi?id=139723
2522
2523         Reviewed by Darin Adler.
2524
2525         The warning is caused by the compiler wanting the first argument to be a
2526         string literal, not a dynamically created string.
2527
2528         * MiniBrowser/efl/main.c:
2529         (quit):
2530
2531 2014-12-16  Sam Weinig  <sam@webkit.org>
2532
2533         TestWebKitAPI should use a static lib to support both Mac and iOS cleanly
2534         https://bugs.webkit.org/show_bug.cgi?id=139718
2535
2536         Reviewed by Mark Rowe.
2537
2538         Change TestWebKitAPI to be more like DumpRenderTree by moving all the source
2539         files into a static lib which the command line utility can link link against.
2540         This will allow us to create a TestWebKitAPI.app that can run on iOS.
2541
2542         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2543         * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig: Added.
2544         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2545
2546 2014-12-16  Alexey Proskuryakov  <ap@apple.com>
2547
2548         Sort out timeout implementations in DRT and WKTR
2549         https://bugs.webkit.org/show_bug.cgi?id=139671
2550
2551         Remove an obsolete test that doesn't capture how run-webkit-tests interacts
2552         with the tool.
2553
2554         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2555         (RunTest.test_hung_thread):
2556
2557 2014-12-15  Alexey Proskuryakov  <ap@apple.com>
2558
2559         Sort out timeout implementations in DRT and WKTR
2560         https://bugs.webkit.org/show_bug.cgi?id=139671
2561
2562         Reviewed by Simon Fraser.
2563
2564         Test timeout implementation had many deficiencies, please see the bug for details.
2565         Most notably, we shouldn't have the tool confused about timeouts vs. failures, and
2566         [ Slow ] modifiers should work a lot better.
2567
2568         * DumpRenderTree/TestRunner.cpp: (TestRunner::TestRunner):
2569         * DumpRenderTree/TestRunner.h: (TestRunner::setCustomTimeout):
2570         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest):
2571         * DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::setWaitToDump):
2572         DumpRenderTree already read the --timeout option from command line, and webkitpy
2573         was already configured to pass it on Mac and iOS. Let's actually use it.
2574         TestCommand already had the same 30 second default, so this doesn't change behavior
2575         when DRT is ran manually without the option.
2576         Windows DumpRenderTree will need to be fixed separately (that's easy).
2577
2578         * DumpRenderTree/TestRunner.cpp: (TestRunner::waitToDumpWatchdogTimerFired()):
2579         Don't print the timeout message to stdout to match WebKitTestRunner. It would be
2580         slightly better to use stderr in both, as this is an out of band message, but
2581         that's a larger refactoring, and the difference is minimal in practice.
2582
2583         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2584         (SingleTestRunner.__init__): Ensure that script and tool timeouts are substantially
2585         different. We want the tool to reliably detect timeouts that can be detected, and
2586         not race with the script for that.
2587
2588         * Scripts/webkitpy/port/base.py: (Port.default_timeout_ms): Don't make WebKit2
2589         timeout longer than WebKit1 one, I doubt that this is necessary. Now that the value
2590         is honored inmore cases, that could make tests run slower.
2591         * Scripts/webkitpy/port/driver.py:
2592         (Driver.__init__):
2593         (Driver.run_test):
2594         (Driver.cmd_line):
2595         (Driver._check_for_driver_timeout):
2596         Detect tests that have the timeout output, and make these have the proper Timeout result.
2597
2598         * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.default_timeout_ms): Remove an
2599         incorrect recent change - 80 * 1000 is 80 seconds, not 80 milliseconds.
2600
2601         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2602         (WTR::TestRunner::setCustomTimeout): Deleted.
2603         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2604         (WTR::TestRunner::setCustomTimeout):
2605         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
2606         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2607         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2608         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2609         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
2610         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2611         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2612         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2613         Updated to use a timeout passed from UI process, which used to be ignored.
2614
2615         * WebKitTestRunner/TestController.cpp:
2616         (WTR::TestController::TestController):
2617         (WTR::TestController::runUntil):
2618         (WTR::TestController::getCustomTimeout): Deleted.
2619         * WebKitTestRunner/TestController.h:
2620         Delete unused m_timeout. First, it was always 0, and second, we don't need it at all.
2621         Changed default message timeouts to match new run-webkit-tests timeout. These don't
2622         affect ports where timeout is passed per test (shouldn't they all be like that?).
2623
2624         * WebKitTestRunner/TestInvocation.cpp:
2625         (WTR::TestInvocation::invoke):
2626         (WTR::TestInvocation::setCustomTimeout): Deleted.
2627         * WebKitTestRunner/TestInvocation.h:
2628         (WTR::TestInvocation::setCustomTimeout):
2629         (WTR::TestInvocation::customTimeout):
2630         Ditto.
2631
2632 2014-12-16  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
2633
2634         [EFL] Add logging domain for MiniBrowser
2635         https://bugs.webkit.org/show_bug.cgi?id=139642
2636
2637         Reviewed by Gyuyoung Kim.
2638
2639         Similarly to EWebKit2, provide logging facility for MiniBrowser
2640         based on Eina Log module to have a convenient way to display
2641         all/subset/none messages for EFL based libraries and MiniBrowser.
2642
2643         Usage:
2644         1. Disable all messages:
2645            EINA_LOG_LEVEL=0 ./Tools/Scripts/run-launcher --efl
2646
2647         2. Enable all messages:
2648            EINA_LOG_LEVEL=7 ./Tools/Scripts/run-launcher --efl
2649
2650         3. Enable MiniBrowser and EWebkit2 messages only:
2651            EINA_LOG_LEVELS="minibrowser:7,ewebkit2:7" ./Tools/Scripts/run-launcher --efl
2652
2653         More information and examples you can find here:
2654         http://docs.enlightenment.org/auto/eet/tutorial_log_page.html
2655
2656         * MiniBrowser/efl/main.c:
2657         (on_mouse_wheel):
2658         (on_window_resize):
2659         (save_page_contents_callback):
2660         (script_execute_callback):
2661         (on_key_down):
2662         (on_download_request):
2663         (on_download_finished):
2664         (on_download_failed):
2665         (quit):
2666         (on_refresh_button_clicked):
2667         (on_stop_button_clicked):
2668         (navigation_button_longpress_process):
2669         (on_popup_menu_item_clicked):
2670         (popup_menu_populate):
2671         (on_popup_menu_show):
2672         (on_window_create):
2673         (context_menu_item_selected_cb):
2674         (context_menu_populate):
2675         (on_context_menu_show):
2676         (on_context_menu_hide):
2677         (on_navigation_policy_decision):
2678         (window_create):
2679         (parse_cookies_policy):
2680         (elm_main):
2681         (has_scheme):
2682         (list_item_label_get):
2683         (on_popup_menu_hide):
2684         (on_window_close):
2685         (on_home_button_clicked):
2686         Replace locally info() macro with newly introduced
2687         one which uses Eina Log module. There is no logic change.
2688
2689 2014-12-15  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
2690
2691         [EFL] FTL JIT not working on ARM64
2692         https://bugs.webkit.org/show_bug.cgi?id=139295
2693
2694         Reviewed by Michael Saboff.
2695
2696         Added patches for llvm to add ARM64 support for FTL JIT
2697
2698         * efl/jhbuild.modules:
2699         * efl/patches/llvm-elf-add-stackmaps-arm64.patch: Added.
2700         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range-arm64.patch: Added.
2701
2702 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
2703
2704         Move Said to the committers section.
2705
2706         * Scripts/webkitpy/common/config/contributors.json:
2707
2708 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
2709
2710         Implement Data Detectors immediate actions for WebKit2
2711         https://bugs.webkit.org/show_bug.cgi?id=139617
2712         <rdar://problem/19198539>
2713
2714         Reviewed by Beth Dakin.
2715
2716         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
2717         (TestWebKitAPI::TEST):
2718         Temporarily disable the action menu tests while the
2719         underlying code is in flux.
2720
2721 2014-12-14  Andreas Kling  <akling@apple.com>
2722
2723         Replace PassRef with Ref/Ref&& across the board.
2724         <https://webkit.org/b/139587>
2725
2726         Reviewed by Darin Adler.
2727
2728         * TestWebKitAPI/Tests/WTF/Ref.cpp:
2729         (TestWebKitAPI::passWithRef):
2730         (TestWebKitAPI::TEST):
2731         (TestWebKitAPI::passWithPassRef): Deleted.
2732         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
2733         (TestWebKitAPI::TEST):
2734         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
2735         (TestWebKitAPI::TEST):
2736         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
2737         (TestWebKitAPI::createTestValue):
2738
2739 2014-12-13  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
2740
2741         [EFL] MiniBrowser's window_create may return NULL
2742         https://bugs.webkit.org/show_bug.cgi?id=139585
2743
2744         Reviewed by Gyuyoung Kim.
2745
2746         Move NULL checking before using object which window_create
2747         returns.
2748
2749         * MiniBrowser/efl/main.c:
2750         (elm_main):
2751
2752 2014-12-12  Alexey Proskuryakov  <ap@apple.com>
2753
2754         Layout Test http/tests/loading/307-after-303-after-post.html is flaky
2755         https://bugs.webkit.org/show_bug.cgi?id=73030
2756
2757         Reviewed by Anders Carlsson.
2758
2759         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): Set icon
2760         database to empty to avoid having it fetch default favicons at random times.
2761         DumpRenderTree also disables it, and also it has a way for tests to temporarily
2762         enable it.
2763
2764 2014-12-12  Lucas Forschler  <lforschler@apple.com>
2765
2766         Update Apple owned build slaves after infrastructure update.
2767         
2768         Reviewed by Ryosuke Niwa.
2769
2770         * BuildSlaveSupport/build.webkit.org-config/config.json:
2771
2772 2014-12-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2773
2774         [GTK] REGRESSION(r175555) GTK API Tests run outside the JHBuild.
2775         https://bugs.webkit.org/show_bug.cgi?id=139537
2776
2777         Reviewed by Carlos Garcia Campos.
2778
2779         * jhbuild/jhbuild-wrapper: Pass the port name in the invocation
2780         of get_dependencies_path().
2781         * jhbuild/jhbuildutils.py:
2782         (get_dependencies_path): Fix the function to return the new
2783         dependencies path: DependenciesPORT.
2784         (enter_jhbuild_environment_if_available): Pass the port name
2785         when invoking get_dependencies_path().
2786
2787 2014-12-10  Lucas Forschler  <lforschler@apple.com>
2788
2789         Update Apple owned build slaves.
2790         
2791         Rubber-stamped by Dana Burkart.
2792         
2793         * BuildSlaveSupport/build.webkit.org-config/config.json:
2794
2795 2014-12-10  Daniel Bates  <dabates@apple.com>
2796
2797         [iOS] REGRESSION (r174642): Watchdog timer expiration reported as DumpRenderTree.app
2798         timeout instead of test failure
2799         https://bugs.webkit.org/show_bug.cgi?id=139525
2800
2801         Reviewed by Zalan Bujtas.
2802
2803         Increase the default process timeout limit in run-webkit-tests to 80ms to prevent
2804         run-webkit-tests from prematurely terminating DumpRenderTree.app before it dumps
2805         output.
2806
2807         Following <http://trac.webkit.org/changeset/174642>, DumpRenderTree.app waits
2808         for the WebThread to spin its run loop before dumping its output. A test that
2809         calls testRunner.waitUntilDone() and does not subsequently call testRunner.notifyDone()
2810         before DumpRenderTree.app's watchdog timer expires may be incorrectly reported
2811         by run-webkit-tests as a DumpRenderTree.app timeout instead of a test failure
2812         because run-webkit-tests may terminate a DumpRenderTree.app process when it
2813         exceeds its process time limit (defaults to 35ms) regardless of whether such
2814         a DumpRenderTree.app process was waiting for the WebThread to run so as to dump output.
2815
2816         * Scripts/webkitpy/port/ios.py:
2817         (IOSSimulatorPort.default_timeout_ms):
2818
2819 2014-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
2820
2821         [GTK][WK2] Add HTML5 Notifications support
2822         https://bugs.webkit.org/show_bug.cgi?id=61140
2823
2824         Reviewed by Carlos Garcia Campos.
2825
2826         * Scripts/webkitperl/FeatureList.pm: enable notifications for GTK+.
2827         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2828         (testWebViewNotification):
2829         (beforeAll):
2830         * MiniBrowser/gtk/BrowserWindow.c: also handle notification permission requests.
2831         (permissionRequestDialogCallback):
2832         (webViewDecidePermissionRequest):
2833         (geolocationRequestDialogCallback): Deleted.
2834
2835 2014-12-09  Benjamin Poulain  <bpoulain@apple.com>
2836
2837         Fix webkitpy test expectation
2838
2839         Not sure what I messed up, but TOTAL_SKIPS was not right.
2840
2841         * Scripts/webkitpy/port/test.py:
2842
2843 2014-12-09  Benjamin Poulain  <bpoulain@apple.com>
2844
2845         Remove virtual test support from webkitpy
2846         https://bugs.webkit.org/show_bug.cgi?id=139427
2847
2848         Reviewed by Alexey Proskuryakov.
2849
2850         It seems that the only concrete client of virtual tests is the unit tests :D
2851
2852         This patch tries to clean as much useless code as possible.
2853
2854         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2855         (RunTest.test_tolerance):
2856         (RunTest.test_virtual): Deleted.
2857         * Scripts/webkitpy/layout_tests/views/printing.py:
2858         (Printer._print_test_trace):
2859         * Scripts/webkitpy/port/base.py:
2860         (Port.expected_filename):
2861         (Port.tests):
2862         (Port.test_isfile):
2863         (Port.test_isdir):
2864         (Port.sample_process):
2865         (Port.find_system_pid):
2866         (Port.test_expectations_file_position):
2867         (Port.virtual_test_suites): Deleted.
2868         (Port): Deleted.
2869         (Port.populated_virtual_test_suites): Deleted.
2870         (Port._virtual_tests): Deleted.
2871         (Port.lookup_virtual_test_base): Deleted.
2872         (Port.lookup_virtual_test_args): Deleted.
2873         (VirtualTestSuite): Deleted.
2874         (VirtualTestSuite.__init__): Deleted.
2875         (VirtualTestSuite.__repr__): Deleted.
2876         * Scripts/webkitpy/port/base_unittest.py:
2877         (PortTest.test_test_exists):
2878         (PortTest.test_test_isfile):
2879         (PortTest.test_test_isdir):
2880         (PortTest.test_tests):
2881         * Scripts/webkitpy/port/driver.py:
2882         (DriverProxy.run_test): Deleted.
2883         * Scripts/webkitpy/port/test.py:
2884         (TestPort._skipped_tests_for_unsupported_features):
2885         (TestPort.all_baseline_variants):
2886         (TestPort.virtual_test_suites): Deleted.
2887         * Scripts/webkitpy/tool/commands/queries.py:
2888         (PrintBaselines.__init__):
2889         (PrintBaselines.execute):
2890         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2891         (PrintBaselinesTest.test_basic):
2892         (PrintBaselinesTest.test_multiple):
2893         (PrintBaselinesTest.test_csv):
2894
2895 2014-12-09  Csaba Osztrogonác  <ossy@webkit.org>
2896
2897         Blink Merge: Remove 'http_lock' code from webkitpy
2898         https://bugs.webkit.org/show_bug.cgi?id=136722
2899
2900         Reviewed by Alexey Proskuryakov.
2901
2902         Based on Blink commit by Dirk Pranke <dpranke@chromium.org>
2903         https://chromium.googlesource.com/chromium/blink/+/196f8146a948275c2f1594b13e30ab19a6e6fd66
2904
2905         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2906         (LayoutTestRunner.__init__):
2907         (LayoutTestRunner.run_tests):
2908         (LayoutTestRunner.start_servers): Renamed from start_servers_with_lock.
2909         (LayoutTestRunner.stop_servers): Renamed from stop_servers_with_lock.
2910         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
2911         (FakePrinter.flush):
2912         (LayoutTestRunnerTests._runner):
2913         (LayoutTestRunnerTests._run_tests):
2914         (LayoutTestRunnerTests.test_servers_started):
2915         (LockCheckingRunner): Deleted.
2916         (LockCheckingRunner.__init__): Deleted.
2917         (LockCheckingRunner.handle_finished_list): Deleted.
2918         (LayoutTestRunnerTests.test_http_locking): Deleted.
2919         * Scripts/webkitpy/port/base.py:
2920         (Port.__init__):
2921         (Port.to.http_server_supports_ipv6):
2922         (Port.to.stop_websocket_server):
2923         (Port.to.acquire_http_lock): Deleted.
2924         (Port.to.release_http_lock): Deleted.
2925         * Scripts/webkitpy/port/http_lock.py: Removed.
2926         * Scripts/webkitpy/port/http_lock_unittest.py: Removed.
2927         * Scripts/webkitpy/port/ios.py:
2928         (IOSSimulatorPort.show_results_html_file):
2929         (IOSSimulatorPort.acquire_http_lock): Deleted.
2930         (IOSSimulatorPort): Deleted.
2931         (IOSSimulatorPort.release_http_lock): Deleted.
2932         * Scripts/webkitpy/port/mac.py:
2933         (MacPort.show_results_html_file):
2934         (MacPort): Deleted.
2935         (MacPort.acquire_http_lock): Deleted.
2936         (MacPort.release_http_lock): Deleted.
2937         * Scripts/webkitpy/port/mock_drt.py:
2938         (MockDRTPort.start_websocket_server):
2939         (MockDRTPort.stop_websocket_server):
2940         (MockDRTPort.acquire_http_lock): Deleted.
2941         (MockDRTPort.release_http_lock): Deleted.
2942         * Scripts/webkitpy/port/mock_drt_unittest.py:
2943         (MockDRTPortTest.test_uses_apache):
2944         (MockDRTPortTest.integration_test_http_lock): Deleted.
2945         * Scripts/webkitpy/port/port_testcase.py:
2946         (PortTestCase.assert_servers_are_up):
2947         (PortTestCase.integration_test_http_lock): Deleted.
2948         * Scripts/webkitpy/port/test.py:
2949         (TestPort.start_websocket_server):
2950         (TestPort.stop_websocket_server):
2951         (TestPort.acquire_http_lock): Deleted.
2952         (TestPort.release_http_lock): Deleted.
2953
2954 2014-12-09  Alberto Garcia  <berto@igalia.com>
2955
2956         convertToUTF8String converts null string to empty string
2957         https://bugs.webkit.org/show_bug.cgi?id=133904
2958
2959         Reviewed by Carlos Garcia Campos.
2960
2961         Test that trying to get the value of a non-existent attribute
2962         returns 0 instead of an empty string.
2963
2964         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
2965         (WebKitDOMNodeTest::testInsertion):
2966
2967 2014-12-09  Joanmarie Diggs  <jdiggs@igalia.com>
2968
2969         [GTK] Bump minimum version of ATK used by jhbuild to at least 2.15.2
2970         https://bugs.webkit.org/show_bug.cgi?id=139070
2971
2972         Reviewed by Carlos Garcia Campos.
2973
2974         * gtk/jhbuild.modules:
2975
2976 2014-12-08  Tim Horton  <timothy_horton@apple.com>
2977
2978         Add action menu tests
2979         https://bugs.webkit.org/show_bug.cgi?id=139156
2980
2981         Reviewed by Dean Jackson.
2982
2983         * TestWebKitAPI/PlatformWebView.h:
2984         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2985         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2986         Add a mechanism allowing tests to provide their own WKView subclass.
2987
2988         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2989         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Added.
2990         Add a file with lots of menu targets.
2991
2992         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: Added.
2993         (-[ActionMenusTestWKView _actionMenuItemsForHitTestResult:withType:defaultActionMenuItems:userData:]):
2994         (-[ActionMenusTestWKView runMenuSequenceAtPoint:preMenuNeedsUpdateHandler:preWillOpenMenuHandler:preDidCloseMenuHandler:]):
2995         (-[ActionMenusTestWKView runMenuSequenceAtPoint:preDidCloseMenuHandler:]):
2996         Run through the normal sequence of callbacks, recording what items and type were returned, and give clients a chance to do work at various points in the process.
2997
2998         (-[ActionMenusTestWKView _setOverrideActionMenuItems:]):
2999
3000         (TestWebKitAPI::didFinishLoadForFrameCallback):
3001         (TestWebKitAPI::didFinishDownloadCallback):
3002         (TestWebKitAPI::didCreateDownloadDestinationCallback):
3003         Watch downloads and ensure that they match the content we expect.
3004
3005         (TestWebKitAPI::watchPasteboardForString):
3006         (TestWebKitAPI::watchPasteboardForImage):
3007         (TestWebKitAPI::JavaScriptStringCallbackContext::JavaScriptStringCallbackContext):
3008         (TestWebKitAPI::JavaScriptBoolCallbackContext::JavaScriptBoolCallbackContext):
3009         (TestWebKitAPI::javaScriptStringCallback):
3010         (TestWebKitAPI::javaScriptBoolCallback):
3011         (TestWebKitAPI::callJavaScriptReturningString):
3012         (TestWebKitAPI::callJavaScriptReturningBool):
3013         (TestWebKitAPI::watchEditableAreaForString):
3014         (TestWebKitAPI::waitForVideoReady):
3015         (TestWebKitAPI::retrieveSelection):
3016         (TestWebKitAPI::retrieveSelectionInElement):
3017         (TestWebKitAPI::performMenuItemAtIndexOfTypeAsync):
3018         (TestWebKitAPI::ensureMenuItemAtIndexOfTypeIsDisabled):
3019         Add many helpers for testing, especially to make asynchronous things synchronous.
3020
3021         (TestWebKitAPI::windowPointForTarget):
3022         (TestWebKitAPI::inset8):
3023         Hard-code points in action-menu-targets.html for hit testing.
3024
3025         (TestWebKitAPI::TEST):
3026         Add a suite of tests for WebKit2 action menus.
3027
3028         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm: Added.
3029         (TestWebKitAPI::createActionContextForPhoneNumber):
3030         (TestWebKitAPI::ActionMenuTest::ActionMenuTest):
3031         (TestWebKitAPI::ActionMenuTest::prepareForActionMenu):
3032         (TestWebKitAPI::ActionMenuTest::actionContextForResultAtPoint):
3033         (TestWebKitAPI::ActionMenuTest::drawRect):
3034         (TestWebKitAPI::ActionMenuTest::didCreatePage):
3035         Add a bundle with a PageOverlay and a actionContextForResultAtPoint override,
3036         so that we can test that infrastructure.
3037
3038 2014-12-08  Philippe Normand  <pnormand@igalia.com>
3039
3040         [GTK] UserMedia Permission Request API
3041         https://bugs.webkit.org/show_bug.cgi?id=136449
3042
3043         Reviewed by Carlos Garcia Campos.
3044
3045         The GTK version of the MiniBrowser has gained UserMedia permission
3046         request support.
3047
3048         * MiniBrowser/gtk/BrowserWindow.c: Show a popup when the page
3049         requires user permission to access audio/video devices.
3050         (permissionRequestDialogCallback):
3051         (webViewDecidePermissionRequest):
3052         (geolocationRequestDialogCallback): Deleted.
3053
3054 2014-12-08  Anders Carlsson  <andersca@apple.com>
3055
3056         Add a stubbed out method for clearing out the website data store
3057         https://bugs.webkit.org/show_bug.cgi?id=139404
3058
3059         Reviewed by Antti Koivisto.
3060
3061         Add a debug menu item for testing clearing of website data.
3062
3063         * MiniBrowser/mac/MainMenu.xib:
3064         * MiniBrowser/mac/WK2BrowserWindowController.m:
3065         (-[WK2BrowserWindowController clearWebsiteData:]):
3066
3067 2014-12-07  Gwang Yoon Hwang  <yoon@igalia.com>
3068
3069         Update style checker to deal with "const override"
3070         https://bugs.webkit.org/show_bug.cgi?id=139371
3071
3072         Reviewed by Csaba Osztrogonác.
3073
3074         check-webkit-style shouldn't complain about an open brace to start a
3075         line after a function definition with const override.
3076
3077         * Scripts/webkitpy/style/checkers/cpp.py:
3078         (check_braces):
3079         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3080         (CppStyleTest.test_brace_at_begin_of_line):
3081
3082 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
3083
3084         [GTK] Fix GObject DOM bindings API break tests after r176920
3085         https://bugs.webkit.org/show_bug.cgi?id=139368
3086
3087         Reviewed by Gustavo Noronha Silva.
3088
3089         Remove the @version from the symbol name before comparing.
3090
3091         * gtk/check-for-webkitdom-api-breaks:
3092         (read_expected_api):
3093
3094 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
3095
3096         Remove the option to automatically update the GObject DOM bindings symbols file
3097         https://bugs.webkit.org/show_bug.cgi?id=139366
3098
3099         Reviewed by Martin Robinson.
3100
3101         It's currently broken, because symbols now need to be in a
3102         specific order. Now that the symbols file only contains stable
3103         API, it's not a problem to manually update it every time new API
3104         is added.
3105
3106         * gtk/check-for-webkitdom-api-breaks:
3107         (read_expected_api):
3108         (check_api):
3109         (write_expected_api): Deleted.
3110
3111 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
3112
3113         [GTK] Use GMainLoopSource in WebKitTestRunner
3114         https://bugs.webkit.org/show_bug.cgi?id=138831
3115
3116         Reviewed by Sergio Villar Senin.
3117
3118         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3119         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
3120         (WTR::TestRunner::platformInitialize):
3121         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
3122         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
3123         (WTR::waitToDumpWatchdogTimerCallback): Deleted.
3124         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3125         (WTR::TestController::notifyDone):
3126         (WTR::TestController::platformRunUntil):
3127         (WTR::cancelTimeout): Deleted.
3128
3129 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
3130
3131         [GTK] Missing API detected in GObject DOM bindings after r176630
3132         https://bugs.webkit.org/show_bug.cgi?id=139201
3133
3134         Reviewed by Gustavo Noronha Silva.
3135
3136         Handle deprecated symbols again when generating the GObject DOM
3137         bindings documentation.
3138
3139         * gtk/webkitdom.py:
3140         (WebKitDOMDocGenerator):
3141         (WebKitDOMDocGenerator.is_deprecated_symbol_file):
3142         (WebKitDOMDocGenerator.generate):
3143         (WebKitDOMDocGeneratorSections.__init__):
3144         (WebKitDOMDocGeneratorSections._find_deprecated_symbols):
3145         (WebKitDOMDocGeneratorSections.write_section):
3146
3147 2014-12-07  Csaba Osztrogonác  <ossy@webkit.org>
3148
3149         [EFL][jhbuild] Fix libsoup build with clang
3150         https://bugs.webkit.org/show_bug.cgi?id=139088
3151
3152         Reviewed by Gyuyoung Kim.
3153
3154         * efl/jhbuild.modules:
3155         * efl/patches/soup-clang-warning-fix1.patch: Added.
3156         * efl/patches/soup-clang-warning-fix2.patch: Added.
3157
3158 2014-12-06  Alexey Proskuryakov  <ap@apple.com>
3159
3160         [Mac] DumpRenderTree sets storage directory incorrectly
3161         https://bugs.webkit.org/show_bug.cgi?id=139347
3162
3163         Reviewed by Dan Bernstein.
3164
3165         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
3166         Don't use user defaults to pass per-instance paths, as user defaults are shared
3167         across all instances.
3168
3169 2014-12-05  Chris Fleizach  <cfleizach@apple.com>
3170
3171         AX: I cannot activate links on the mobile version of news.google.com
3172         https://bugs.webkit.org/show_bug.cgi?id=139330
3173
3174         Reviewed by Simon Fraser.
3175
3176         Implement press for iOS.
3177
3178         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3179         (AccessibilityUIElement::press):
3180
3181 2014-12-05  Daniel Bates  <dabates@apple.com>
3182
3183         [iOS] Query -[WAKWindow screenScale] instead of using WKGetScreenScaleFactor()
3184         https://bugs.webkit.org/show_bug.cgi?id=139326
3185
3186         Reviewed by Anders Carlsson.
3187
3188         Ask the window for its screen scale factor instead of calling WKGetScreenScaleFactor()
3189         to query the OS for it. This approach will ensure DumpRenderTree takes the snapshot
3190         using the same scale factor as used in WebKit.
3191
3192         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3193         (createBitmapContextFromWebView):
3194
3195 2014-12-05  Anders Carlsson  <andersca@apple.com>
3196
3197         REGRESSION (r176677): All tests crash on Windows
3198         https://bugs.webkit.org/show_bug.cgi?id=139321
3199
3200         Reviewed by Alexey Proskuryakov.
3201
3202         * DumpRenderTree/win/DumpRenderTree.cpp:
3203         (runTest):
3204         Don't call CFRelease on the url while we have an outstanding pointer to its string,
3205         and use the right number of bytes when allocating the testURL buffer.
3206
3207 2014-12-05  Daniel Bates  <dabates@apple.com>
3208
3209         [iOS] DumpRenderTree produces many reference test mismatches
3210         https://bugs.webkit.org/show_bug.cgi?id=139314
3211
3212         Reviewed by Simon Fraser.
3213
3214         Fixes an issue where the scale factor used to render the snapshot taken by
3215         DumpRenderTree may differ from the device scale factor. In particular, the
3216         scale factor used to render a snapshot of a test may differ from the scale
3217         factor used to render the snapshot of its expected result.
3218
3219         Currently DumpRenderTree uses SPI, -[UIView newSnapshotForRect], on iOS to
3220         snapshot the UIWebBrowserView. This SPI always render using a scale factor
3221         of one when the backing store for the LegacyTileLayer objects were out-of-
3222         date regardless of the device scale factor. Instead we should use UIImage
3223         and CALayer API to perform the snapshot with respect to the device scale
3224         factor.
3225
3226         Additionally write iOS pixel dump support logic in terms of existing
3227         DumpRenderTree abstractions so as to support generating and comparing
3228         pixel dump checksums as well as make the iOS code more consistent with
3229         the logic used by other ports.
3230
3231         * DumpRenderTree/PixelDumpSupport.cpp:
3232         (dumpWebViewAsPixelsAndCompareWithExpected): Removed !PLATFORM(IOS)-guard.
3233         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3234         (BitmapContext::createFromUIImage): Added.
3235         (BitmapContext::pixelData): Added.
3236         (BitmapContext::BitmapContext): Added.
3237         (computeMD5HashStringForBitmapContext): Added.
3238         (dumpBitmap): Added.
3239         (createBitmapContextFromWebView): Moved logic from dumpWebViewAsPixelsAndCompareWithExpected() to here.
3240         (dumpWebViewAsPixelsAndCompareWithExpected): Deleted.
3241
3242 2014-12-05  Anders Carlsson  <andersca@apple.com>
3243
3244         Give all web pages a website data store
3245         https://bugs.webkit.org/show_bug.cgi?id=139317
3246
3247         Reviewed by Tim Horton.
3248
3249         * MiniBrowser/mac/AppDelegate.m:
3250         (-[BrowserAppDelegate newPrivateWindow:]):
3251         Don't release the controller - it's implicitly retained by the window.
3252
3253 2014-12-05  Daniel Bates  <dabates@apple.com>
3254
3255         [iOS] DumpRenderTree fails to render every other test when pixel tests are on
3256         https://bugs.webkit.org/show_bug.cgi?id=137581
3257         <rdar://problem/18642906>
3258
3259         Reviewed by Simon Fraser.
3260
3261         Fixes an issue where the DumpRenderTree snapshot may reflect the rendered content
3262         of the test that proceeded the currently running test.
3263
3264         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3265         (dumpWebViewAsPixelsAndCompareWithExpected): Ensure that UIKit has performed a layout
3266         of the UIWebBrowserView view. Also, remove unnecessary call to -[UIWebDocumentView layoutTilesNow]
3267         as -[UIWebDocumentView newSnapshotWithRect] will layout the tiles.
3268
3269 2014-12-05  Jer Noble  <jer.noble@apple.com>
3270
3271         [WTF] MediaTime should support round-tripping from and to doubles.
3272         https://bugs.webkit.org/show_bug.cgi?id=139248
3273
3274         Reviewed by Eric Carlson.
3275
3276         Add API tests for new features of MediaTime. Update the LLDB python provider to correctly display
3277         the MediaTimes after this change.
3278
3279         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
3280         (WTF::operator<<):
3281         (TestWebKitAPI::TEST):
3282         * lldb/lldb_webkit.py:
3283         (WTFMediaTime_SummaryProvider):
3284         (WTFMediaTimeProvider.timeValueAsDouble):
3285         (WTFMediaTimeProvider.isIndefinite):
3286         (WTFMediaTimeProvider):
3287         (WTFMediaTimeProvider.hasDoubleValue):
3288
3289 2014-12-05  Anders Carlsson  <andersca@apple.com>
3290
3291         Add a private browsing mode to MiniBrowser
3292         https://bugs.webkit.org/show_bug.cgi?id=139308
3293
3294         Reviewed by Sam Weinig.
3295
3296         * MiniBrowser/mac/AppDelegate.m:
3297         (defaultConfiguration):
3298         (-[BrowserAppDelegate newWindow:]):
3299         (-[BrowserAppDelegate newPrivateWindow:]):
3300         * MiniBrowser/mac/MainMenu.xib:
3301         * MiniBrowser/mac/WK2BrowserWindowController.h:
3302         * MiniBrowser/mac/WK2BrowserWindowController.m:
3303         (-[WK2BrowserWindowController awakeFromNib]):
3304         (-[WK2BrowserWindowController initWithConfiguration:]):
3305         (-[WK2BrowserWindowController dealloc]):
3306         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
3307
3308 2014-12-04  Alexey Proskuryakov  <ap@apple.com>
3309
3310         Run http tests parallel
3311         https://bugs.webkit.org/show_bug.cgi?id=138958
3312
3313         Reviewed by Daniel Bates.
3314
3315         Remove the concept of "locked shard". Now http tests are just like any other tests.
3316         We start HTTP and WebSocket servers at the start if we need them, and terminate them
3317         when done with all the tests (not when the last http test runs, which is unnecessarily
3318         unpredictable).
3319
3320         This makes debug tests run in 8 minutes and 12 seconds on my Mac Pro. Without the
3321         patch, they used to take over 15 minutes.
3322
3323         As part of the fix, we no longer pass the number of servers to Apache. I don't
3324         think that these parameters did what we wanted them to do; Apache handles the load
3325         just fine without them.
3326
3327         The change applies to all platforms. I fixed everything I could find on Mac, and
3328         Ossy told me that he's been running http tests in parallel for a long time. If
3329         there is increased instability for some ports, it will need to be fixed - there is
3330         generally nothing special about http tests at this point, and most code is
3331         cross-platform in WebKit2.
3332
3333         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3334         (LayoutTestRunner.__init__):
3335         (LayoutTestRunner.run_tests):
3336         (LayoutTestRunner.start_servers_with_lock):
3337         (LayoutTestRunner._handle_started_test):
3338         (Worker.handle):
3339         (Sharder.__init__):
3340         (Sharder.shard_tests):
3341         (Sharder._shard_every_file):
3342         (Sharder._shard_by_directory):
3343         (LayoutTestRunner._handle_finished_test_list): Deleted.
3344         (LayoutTestRunner._handle_finished_test_list.find): Deleted.
3345         (Sharder._shard_in_two): Deleted.
3346         (Sharder): Deleted.
3347         (Sharder._resize_shards): Deleted.
3348         (Sharder._resize_shards.divide_and_round_up): Deleted.
3349         (Sharder._resize_shards.extract_and_flatten): Deleted.
3350         (Sharder._resize_shards.split_at): Deleted.
3351         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
3352         (FakePrinter.print_workers_and_shards):
3353         (LayoutTestRunnerTests.test_servers_started.start_http_server):
3354         (LayoutTestRunnerTests.test_servers_started):
3355         (SharderTests.get_shards):
3356         (SharderTests.test_shard_by_dir):
3357         (SharderTests.test_shard_every_file):
3358         (SharderTests): Deleted.
3359         (SharderTests.test_shard_in_two): Deleted.
3360         (SharderTests.test_shard_in_two_has_no_locked_shards): Deleted.
3361         (SharderTests.test_shard_in_two_has_no_unlocked_shards): Deleted.
3362         (SharderTests.test_multiple_locked_shards): Deleted.
3363         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3364         (ManagerTest.test_needs_servers.get_manager):
3365         (ManagerTest.integration_test_needs_servers.get_manager):
3366         (ManagerTest.test_look_for_new_crash_logs.get_manager):
3367         (ManagerTest):
3368         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3369         (_set_up_derived_options):
3370         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3371         (RunTest.test_batch_size):
3372         (RunTest.test_max_locked_shards): Deleted.
3373         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3374         (LayoutTestApacheHttpd.__init__):
3375         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
3376         (TestLayoutTestApacheHttpd.test_start_cmd):
3377         * Scripts/webkitpy/layout_tests/servers/http_server.py:
3378         (Lighttpd.__init__):
3379         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
3380         (HttpServerBase.__init__):
3381         * Scripts/webkitpy/layout_tests/views/printing.py:
3382         (Printer.print_workers_and_shards):
3383         * Scripts/webkitpy/port/base.py:
3384         (Port.default_child_processes):
3385         (Port.to.start_http_server):
3386         (Port.default_max_locked_shards): Deleted.
3387         * Scripts/webkitpy/port/port_testcase.py:
3388         (PortTestCase.make_port):
3389         (PortTestCase.test_default_max_locked_shards): Deleted.
3390         * Scripts/webkitpy/port/test.py:
3391         (TestPort.start_http_server):
3392
3393 2014-12-04  Alexey Proskuryakov  <ap@apple.com>
3394
3395         Don't lock perf tests in run-webkit-tests
3396         https://bugs.webkit.org/show_bug.cgi?id=139264
3397
3398         Reviewed by Daniel Bates.
3399
3400         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3401         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
3402         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3403         * Scripts/webkitpy/layout_tests/models/test_input.py:
3404         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3405
3406 2014-12-03  Alexey Proskuryakov  <ap@apple.com>
3407
3408         http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html fails unless certain other tests run before it
3409         https://bugs.webkit.org/show_bug.cgi?id=139243
3410
3411         Reviewed by Anders Carlsson.
3412
3413         We didn't get WKPageLoaderClient calls in secondary windows, so we didn't have a
3414         chance to allow untrusted certificates.
3415
3416         * WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage):
3417         Set up more client objects for secondary windows. We may be able to share some of the
3418         code with main view creation function, but it's not exactly the same (notably, we
3419         do not focus a secondary window when it's done loading).
3420
3421 2014-12-03  Joanmarie Diggs  <jdiggs@igalia.com>
3422
3423         AX: [ATK] Inline text elements with accessible object attributes and/or event handlers are not exposed
3424         https://bugs.webkit.org/show_bug.cgi?id=139071
3425
3426         Reviewed by Chris Fleizach.
3427
3428         Add string value for ATK_ROLE_STATIC in roleToString.
3429
3430         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3431
3432 2014-12-03  Renato Nagy  <rnagy@inf.u-szeged.hu>
3433
3434         check-webkit-style is confused by ternary expression inside first member initializer
3435         https://bugs.webkit.org/show_bug.cgi?id=136442
3436
3437         Reviewed by Csaba Osztrogonác.
3438
3439         * Scripts/webkitpy/style/checkers/cpp.py:
3440         (check_member_initialization_list):
3441
3442 2014-12-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3443
3444         [GTK] [JHBuild] gst-plugins-bad fails to build if the GNUStep libraries are installed.
3445         https://bugs.webkit.org/show_bug.cgi?id=139220
3446
3447         Reviewed by Philippe Normand.
3448
3449         * gtk/jhbuild.modules:
3450         * gtk/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
3451
3452 2014-12-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
3453
3454         Remove unused JSC runtime options
3455         https://bugs.webkit.org/show_bug.cgi?id=133070
3456
3457         Reviewed by Csaba Osztrogonác.
3458
3459         * Scripts/run-jsc-stress-tests:
3460
3461 2014-12-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3462
3463         [EFL] Add subtle crypto to the build system
3464         https://bugs.webkit.org/show_bug.cgi?id=138612
3465
3466         Reviewed by Csaba Osztrogonác.
3467
3468         * Scripts/webkitperl/FeatureList.pm:
3469
3470 2014-12-02  Joanmarie Diggs  <jdiggs@igalia.com>
3471
3472         AX: [ATK] Table captions and table rows are missing from the accessible hierarchy
3473         https://bugs.webkit.org/show_bug.cgi?id=139005
3474
3475         Reviewed by Chris Fleizach.
3476
3477         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3478         Add mapping for ATK_ROLE_CAPTION to roleToString
3479
3480 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
3481
3482         http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests
3483         https://bugs.webkit.org/show_bug.cgi?id=139149
3484
3485         Reviewed by Anders Carlsson.
3486
3487         WebKit2 already cleared application caches between runs (although it wasn't entirely
3488         effective without WebCore changes in this patch).
3489
3490         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Clear applicaiton caches between runs.
3491
3492         * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ditto (unfortunately, this
3493         function is not implemented on Windows, see below).
3494
3495         * DumpRenderTree/win/TestRunnerWin.cpp: (TestRunner::clearAllApplicationCaches):
3496         Ameded a FIXME.
3497
3498 2014-12-02  Gavin Barraclough  <barraclough@apple.com>
3499
3500         Generalize PageActivityAssertionToken
3501         https://bugs.webkit.org/show_bug.cgi?id=139106
3502
3503         Reviewed by Sam Weinig.
3504
3505         Add an API test for WTF::RefCounter.
3506
3507         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3508         * TestWebKitAPI/Tests/WTF/RefCounter.cpp: Added.
3509         (TestWebKitAPI::TEST):
3510             - added RefCounter test.
3511
3512 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
3513
3514         [Mac, iOS] Crash log application information contains latest main frame URL instead of test URL
3515         https://bugs.webkit.org/show_bug.cgi?id=139174
3516
3517         Reviewed by Simon Fraser.
3518
3519         * DumpRenderTree/TestRunner.cpp:
3520         * DumpRenderTree/TestRunner.h:
3521         Renamed testPathOrURL to testURL, because this variable always contains a URL.
3522
3523         * DumpRenderTree/mac/DumpRenderTree.mm:
3524         (sizeWebViewForCurrentTest): Updated for testPathOrURL renaming.
3525         (testPathFromURL): Moved from FrameLoadDelegate.mm.
3526         (runTest): Set crash reporter information here, as we know the exact test URL.
3527
3528         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3529         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): Don't set crash
3530         reporter information here.
3531
3532         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3533         * DumpRenderTree/mac/TestRunnerMac.mm:
3534         Updated for testPathOrURL renaming.
3535
3536         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3537         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): WebProcess doesn't know
3538         test URL until load starts, so save it into TestRunner now. A new TestRunner object
3539         is created for each test.
3540
3541         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3542         (WTR::TestRunner::testURL):
3543         (WTR::TestRunner::setTestURL):
3544         Make TestRunner know the test name. For now, it's good enough to have it once load
3545         starts, but if we ever need it earlier, we can send it with BeginTest message.
3546
3547         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
3548         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
3549         Use test URL, not currently loading URL for CrashReporter.
3550
3551         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
3552         (WTR::setCrashReportApplicationSpecificInformationToURL): Added a space after colon
3553         (WebKit1 already had it right).
3554
3555         * DumpRenderTree/win/DumpRenderTree.cpp:
3556         (sizeWebViewForCurrentTest):
3557         (runTest):
3558         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3559         (ResourceLoadDelegate::willSendRequest):
3560         Changed Windows DumpRenderTree to also use URL in TestRunner.
3561
3562 2014-12-02  Daniel Bates  <dabates@apple.com>
3563
3564         [iOS] run-webkit-tests records most DumpRenderTree.app crashes as time-outs
3565         https://bugs.webkit.org/show_bug.cgi?id=139143
3566
3567         Reviewed by David Kilzer.
3568
3569         Similar to the Windows-specific fix in <https://bugs.webkit.org/show_bug.cgi?id=37859>,
3570         teach DumpRenderTree for iOS to write "#CRASHED" to the standard error stream when it
3571         crashes. Run-webkit-tests will record as crashing the test associated with the
3572         DumpRenderTree instance that wrote that string.
3573
3574         Currently almost all of the DumpRenderTree.app crashes are recorded by run-
3575         webkit-tests as a time-out because ReportCrash(8) delays delivery of the
3576         process exit notification for DumpRenderTree.app to LayoutTestRelay, which
3577         launched DumpRenderTree.app, past the time-out time limit. Notice LayoutTestRelay
3578         was launched by run-webkit-tests. So, run-webkit-tests kills LayoutTestRelay
3579         (since it exceeded the time-out time limit) before it can inform rub-webkit-tests
3580         about a crash.
3581
3582         Additionally, update the crash message format written to standard error when LayoutTestRelay
3583         detects that {WebKitTestRunner, DumpRenderTree}.app crashed so as to be similar to the
3584         crash message format used by WebKitTestRunner when it detects that the WebProcess crashed.
3585         Then run-webkit-tests will collect the crash logs for {WebKitTestRunner, DumpRenderTree}.app
3586         when they crash in their test machinery logic/UI process code.
3587
3588         * DumpRenderTree/mac/DumpRenderTree.mm:
3589         (writeCrashedMessageOnFatalError): Added.
3590         (dumpRenderTree): Register signal handler, writeCrashedMessageOnFatalError(), for signals:
3591         SIGILL, SIGFPE, SIGBUS and SIGSEGV.
3592         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3593         (-[LTRelayController didCrashWithMessage:]): Emit a crash message with a format
3594         similar to the format used by WebKitTestRunner so that run-webkit-tests will collect
3595         the crash logs for WebKitTestRunner/DumpRenderTree.app.
3596         * Scripts/webkitpy/port/driver.py:
3597         (Driver.__init__): Update comment.
3598         (Driver._check_for_driver_crash): Ditto.
3599         * Scripts/webkitpy/port/ios.py:
3600         (IOSSimulatorPort): Add class constant SUBPROCESS_CRASH_REGEX, which represents a compiled
3601         regular expression. This constant is used as an optimization to avoid compiling the same
3602         regular expression across invocations of _get_crash_log().
3603         (IOSSimulatorPort._get_crash_log): Modified to parse the WebKitTestRunner-like crash message
3604         for the subprocess name and pid. Also, moved variables crash_log, crash_logs, and now to be
3605         closer to where they are used.
3606
3607 2014-12-01  Anders Carlsson  <andersca@apple.com>
3608
3609         Remove WKBundleRemoveAllVisitedLinks
3610         https://bugs.webkit.org/show_bug.cgi?id=139163
3611
3612         Reviewed by Sam Weinig.
3613
3614         Remove the call to WKBundleRemoveAllVisitedLinks and add a FIXME instead.
3615
3616         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3617         (WTR::InjectedBundle::beginTesting):
3618         * WebKitTestRunner/TestInvocation.cpp:
3619         (WTR::TestInvocation::invoke):
3620
3621 2014-12-02  Anders Carlsson  <andersca@apple.com>
3622