[ews-app] Status-bubble steps are sometimes displayed in reverse order
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2
3         [ews-app] Status-bubble steps are sometimes displayed in reverse order
4         https://bugs.webkit.org/show_bug.cgi?id=196625
5
6         Reviewed by Lucas Forschler.
7
8         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
9         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
10
11 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
12
13         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
14         https://bugs.webkit.org/show_bug.cgi?id=196630
15
16         Reviewed by Wenson Hsieh.
17
18         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
19
20 2019-04-04  Youenn Fablet  <youenn@apple.com>
21
22         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
23         https://bugs.webkit.org/show_bug.cgi?id=196543
24
25         Reviewed by Alex Christensen.
26
27         * WebKitTestRunner/TestController.cpp:
28         (WTR::TestController::generatePageConfiguration):
29
30 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
31
32         [ews-app] Status bubble should not display skipped buildbot steps
33         https://bugs.webkit.org/show_bug.cgi?id=196584
34
35         Reviewed by Lucas Forschler.
36
37         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
38
39 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
40
41         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
42         https://bugs.webkit.org/show_bug.cgi?id=196620
43
44         Reviewed by Lucas Forschler.
45
46         * BuildSlaveSupport/ews-app/ews/config.py:
47
48 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
49
50         [Win] DumpRenderTreeWatchDog.py is not checked into source
51         https://bugs.webkit.org/show_bug.cgi?id=196567
52         <rdar://problem/49525901>
53
54         Reviewed by Lucas Forschler.
55
56         This script is used on Win EWS bots to terminate hanging DRT processes.
57
58         * EWSTools/dumprendertreewatchdog.py: Added.
59
60 2019-04-04  Chris Dumez  <cdumez@apple.com>
61
62         Unreviewed, roll out r243858 which made tests time out.
63
64         Disable new API tests on Windows instead.
65
66         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
67         (TestWebKitAPI::TEST):
68
69 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
70
71         [ATK] Cleanup WebPageAccessibilityObjectAtk
72         https://bugs.webkit.org/show_bug.cgi?id=196537
73
74         Reviewed by Michael Catanzaro.
75
76         Also consider files under atk directories as exceptions for GObject conventions.
77
78         * Scripts/webkitpy/style/checkers/cpp.py:
79         (check_identifier_name_in_declaration):
80
81 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
82
83         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
84         https://bugs.webkit.org/show_bug.cgi?id=196588
85         <rdar://problem/49365787>
86
87         Unreviewed build fix for Windows port.
88
89         error C3861: 'kill': identifier not found
90
91         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
92         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
93
94 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
95
96         [ews-build] Cancel build and similar operations should have authentication
97         https://bugs.webkit.org/show_bug.cgi?id=196520
98
99         Reviewed by Dewei Zhu.
100
101         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
102         environment variables.
103
104 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
105
106         [ews-build] Do not trigger queues which are not in production yet
107         https://bugs.webkit.org/show_bug.cgi?id=196581
108
109         Reviewed by Dewei Zhu.
110
111         * BuildSlaveSupport/ews-build/config.json:
112
113 2019-04-03  Chris Dumez  <cdumez@apple.com>
114
115         Unreviewed, fix typo in the name of API test added in r243848.
116
117         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
118         (TestWebKitAPI::TEST):
119
120 2019-04-03  Chris Dumez  <cdumez@apple.com>
121
122         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
123         https://bugs.webkit.org/show_bug.cgi?id=196588
124         <rdar://problem/49365787>
125
126         Reviewed by Ryosuke Niwa.
127
128         Add API test coverage.
129
130         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
131         (TestWebKitAPI::nullJavaScriptCallback):
132         (TestWebKitAPI::didCrashCheckFrames):
133         (TestWebKitAPI::TEST):
134
135 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
136
137         run-webkit-tests: Upload test results (new results database)
138         https://bugs.webkit.org/show_bug.cgi?id=196577
139         <rdar://problem/34841155>
140
141         Reviewed by Lucas Forschler.
142
143         * Scripts/webkitpy/layout_tests/controllers/manager.py:
144         (Manager.run): Upload results after each device shard, since the configuration will be
145         different for each device.
146         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
147         uploaded to a results database.
148         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
149         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
150
151 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
152
153         -apple-trailing-word is needed for browser detection
154         https://bugs.webkit.org/show_bug.cgi?id=196575
155
156         Unreviewed.
157
158         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
159
160 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
161
162         [CMake][WTF] Mirror XCode header directories
163         https://bugs.webkit.org/show_bug.cgi?id=191662
164
165         Reviewed by Konstantin Tokarev.
166
167         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
168         builds.
169
170         * CMakeLists.txt:
171         * DumpRenderTree/CMakeLists.txt:
172         * DumpRenderTree/PlatformWin.cmake:
173         * MiniBrowser/win/CMakeLists.txt:
174         * TestWebKitAPI/CMakeLists.txt:
175         * TestWebKitAPI/PlatformWin.cmake:
176         * WebKitTestRunner/PlatformGTK.cmake:
177         * WebKitTestRunner/PlatformWin.cmake:
178
179 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
180
181         [ews-app] Status bubble should not display certain infrastructure status messages
182         https://bugs.webkit.org/show_bug.cgi?id=196550
183
184         Reviewed by Lucas Forschler.
185
186         Do not display the steps which are un-needed for end-user. This information is still avaiable
187         if the user click on the bubble and look at the Buildbot build.
188         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
189         (StatusBubble._steps_messages):
190         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
191
192 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
193
194         [ews-build] Use https for sending data to ews-app
195         https://bugs.webkit.org/show_bug.cgi?id=196492
196
197         Reviewed by Lucas Forschler.
198
199         * BuildSlaveSupport/ews-build/events.py:
200
201 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
202
203         Remove support for -apple-trailing-word
204         https://bugs.webkit.org/show_bug.cgi?id=196525
205
206         Reviewed by Zalan Bujtas.
207
208         This CSS property is nonstandard and not used.
209
210         * Scripts/webkitperl/FeatureList.pm:
211         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
212
213 2019-04-03  Youenn Fablet  <youenn@apple.com>
214
215         Add a test for DOMCache on multiple browsing in case of private browsing
216         https://bugs.webkit.org/show_bug.cgi?id=196524
217
218         Reviewed by Alex Christensen.
219
220         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
221         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
222
223 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
224
225         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
226         https://bugs.webkit.org/show_bug.cgi?id=196540
227
228         Reviewed by Aakash Jain.
229
230         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
231
232 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
233
234         Add plumbing for a compatibility mode preference in WebKit
235         https://bugs.webkit.org/show_bug.cgi?id=196005
236
237         Reviewed by Tim Horton.
238
239         Add new API tests.
240
241         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
242         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
243
244 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
245
246         [WPE][GTK] Update libsrtp dependency package for Debian
247         https://bugs.webkit.org/show_bug.cgi?id=196528
248
249         Reviewed by Frédéric Wang.
250
251         * gtk/install-dependencies:
252         * wpe/install-dependencies:
253
254 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
255
256         [WK2] Add support for Window's beforeprint / afterprint events
257         https://bugs.webkit.org/show_bug.cgi?id=196478
258         <rdar://problem/49535124>
259
260         Unreviewed build fix for MSVC.
261
262         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
263
264         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
265
266         * WebKitTestRunner/TestController.cpp:
267         (WTR::printFrame): Use int and float literals.
268
269 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
270
271         [ews-build] Reassign bots to queues
272
273         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
274
275 2019-04-02  Chris Dumez  <cdumez@apple.com>
276
277         [WK2] Add support for Window's beforeprint / afterprint events
278         https://bugs.webkit.org/show_bug.cgi?id=196478
279
280         Reviewed by Alex Christensen.
281
282         Add minimal implementation for printFrame in WebKitTestRunner.
283
284         * WebKitTestRunner/TestController.cpp:
285         (WTR::printFrame):
286         (WTR::TestController::createOtherPage):
287         (WTR::TestController::createWebViewWithOptions):
288
289 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
290
291         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
292         https://bugs.webkit.org/show_bug.cgi?id=196491
293
294         Reviewed by Lucas Forschler.
295
296         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
297
298 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
299
300         [ews-build] Configure buildbot try credentials in environment variables
301         https://bugs.webkit.org/show_bug.cgi?id=196501
302
303         Reviewed by Lucas Forschler.
304
305         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
306         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
307         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
308
309 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
310
311         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
312         https://bugs.webkit.org/show_bug.cgi?id=196496
313         <rdar://problem/49521634>
314
315         Reviewed by Chris Dumez.
316
317         Add new API tests (see WebKit ChangeLog for more detail).
318
319         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
320         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
321         (TEST):
322
323 2019-04-02  David Kilzer  <ddkilzer@apple.com>
324
325         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
326         <https://webkit.org/b/196499>
327
328         Reviewed by Alexey Proskuryakov.
329
330         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
331         ENABLE_ADDRESS_SANITIZER.
332
333 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
334
335         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
336         https://bugs.webkit.org/show_bug.cgi?id=182757
337
338         Reviewed by Don Olmstead.
339
340         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
341         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
342
343 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
344
345         run-api-tests: Upload test results
346         https://bugs.webkit.org/show_bug.cgi?id=196323
347         <rdar://problem/49356714>
348
349         Reviewed by Lucas Forschler.
350
351         * Scripts/webkitpy/api_tests/manager.py:
352         (Manager):
353         (Manager.run): Upload results to a results database.
354         * Scripts/webkitpy/api_tests/run_api_tests.py:
355         (parse_args): Add upload arguments.
356         * Scripts/webkitpy/port/base.py:
357         (Port):
358         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
359         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
360         with commits from any other associated repositories.
361         * Scripts/webkitpy/port/device.py:
362         (Device):
363         (Device.build_version): Access build_versoin of underlying platform device.
364         * Scripts/webkitpy/port/ios_simulator_unittest.py:
365         (IOSSimulatorTest):
366         (IOSSimulatorTest.test_configuration_for_upload):
367         * Scripts/webkitpy/port/device_port.py:
368         (DevicePort):
369         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
370         the same as the machine uploading results.
371         * Scripts/webkitpy/port/mac.py:
372         (MacPort):
373         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
374         * Scripts/webkitpy/port/mac_unittest.py:
375         (MacTest):
376         (MacTest.test_configuration_for_upload):
377         * Scripts/webkitpy/xcode/simulated_device.py:
378         (SimulatedDeviceManager._create_device_with_runtime):
379         (SimulatedDevice.__init__): Create simulated device with a build_version.
380         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
381         (test_existing_simulator):
382
383 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
384
385         Remove extra newline characters (Follow-up fix to r243707)
386
387         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
388
389 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
390
391         [ews-app] Use API_KEY to accept results data
392         https://bugs.webkit.org/show_bug.cgi?id=196461
393
394         Reviewed by Dewei Zhu.
395
396         * BuildSlaveSupport/ews-app/ews/views/results.py:
397         (Results.post): Validate EWS_API_KEY before accepting any data.
398         * BuildSlaveSupport/ews-build/events.py:
399         (Events.sendData): Send EWS_API_KEY if available along with event data.
400
401 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
402
403         Unable to copy and paste a PDF from Notes into Mail compose body
404         https://bugs.webkit.org/show_bug.cgi?id=196442
405         <rdar://problem/48573098>
406
407         Reviewed by Tim Horton.
408
409         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
410         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
411         to be specified on the item providers.
412
413         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
414         (TestWebKitAPI::mapItemForTesting):
415         (TestWebKitAPI::contactItemForTesting):
416
417 2019-04-01  Tim Horton  <timothy_horton@apple.com>
418
419         Make UIWKDocumentContext rects per-character instead of per-word
420         https://bugs.webkit.org/show_bug.cgi?id=196459
421
422         Reviewed by Wenson Hsieh.
423
424         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
425         (TEST):
426         Adjust test results due to switching to per-character rects.
427
428 2019-04-01  Chris Dumez  <cdumez@apple.com>
429
430         UIProcess crash when a prewarmed process is terminated
431         https://bugs.webkit.org/show_bug.cgi?id=196451
432         <rdar://problem/49245471>
433
434         Reviewed by Geoffrey Garen.
435
436         Add API test coverage.
437
438         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
439         (TEST):
440
441 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
442
443         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
444         https://bugs.webkit.org/show_bug.cgi?id=196449
445
446         Reviewed by Lucas Forschler.
447
448         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
449         (StatusBubble.get_os_details): Method to get OS and Xcode details.
450         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
451         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
452
453 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
454
455         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
456         https://bugs.webkit.org/show_bug.cgi?id=196444
457
458         Reviewed by Lucas Forschler.
459
460         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
461
462 2019-04-01  Alex Christensen  <achristensen@webkit.org>
463
464         Add SPI to canonicalize NSURLs with WTF::URL
465         https://bugs.webkit.org/show_bug.cgi?id=196415
466         <rdar://problem/44980271>
467
468         Reviewed by Darin Adler.
469
470         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
471         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
472         (TestWebKitAPI::TEST):
473
474 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
475
476         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
477         https://bugs.webkit.org/show_bug.cgi?id=196441
478
479         Reviewed by Carlos Garcia Campos.
480
481         Don't cache the wpe_view_backend object that might not exist yet at the
482         time of EventSenderProxy constructor invocation, but instead retrieve
483         that object whenever it's required for event dispatching. This should
484         avoid crashes in this constructor now that it's invoked before any
485         PlatformWindow has been set up (as changed in r243496).
486
487         * WebKitTestRunner/EventSenderProxy.h:
488         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
489         (WTR::viewBackend):
490         (WTR::EventSenderProxy::EventSenderProxy):
491         (WTR::EventSenderProxy::mouseDown):
492         (WTR::EventSenderProxy::mouseUp):
493         (WTR::EventSenderProxy::mouseMoveTo):
494         (WTR::EventSenderProxy::mouseScrollBy):
495         (WTR::EventSenderProxy::keyDown):
496         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
497
498 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
499
500         [Win][WebKit] MiniBrowser should support high DPI display
501         https://bugs.webkit.org/show_bug.cgi?id=196391
502
503         Reviewed by Alex Christensen.
504
505         * MiniBrowser/win/WebKitBrowserWindow.cpp:
506         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
507         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
508         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
509
510 2019-03-31  Sam Weinig  <weinig@apple.com>
511
512         Remove more i386 specific configurations
513         https://bugs.webkit.org/show_bug.cgi?id=196430
514
515         Reviewed by Alexey Proskuryakov.
516
517         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
518         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
519
520 2019-03-31  Andy Estes  <aestes@apple.com>
521
522         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
523         https://bugs.webkit.org/show_bug.cgi?id=196433
524         <rdar://problem/49293305>
525
526         Reviewed by Tim Horton.
527
528         Enhanced API test coverage to include all navigation response policy decisions in both
529         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
530
531         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
532         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
533         (TestWebKitAPI::TEST):
534         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
535         (readFile):
536         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
537         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
538         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
539         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
540         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
541         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
542         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
543         (-[QuickLookDelegate _downloadDidStart:]):
544         (-[QuickLookDelegate _download:didReceiveResponse:]):
545         (-[QuickLookDelegate _download:didReceiveData:]):
546         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
547         (-[QuickLookDelegate _downloadDidFinish:]):
548         (-[QuickLookDelegate _download:didFailWithError:]):
549         (-[QuickLookDelegate _downloadDidCancel:]):
550         (-[QuickLookDelegate verifyDownload]):
551         (runTest):
552         (runTestDecideBeforeLoading):
553         (runTestDecideAfterLoading):
554         (TEST):
555         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
556         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
557         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
558         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
559         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
560         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
561         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
562         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
563         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
564         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
565         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
566         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
567         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
568         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
569
570 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
571
572         [CMake] add testdfg as target with build-jsc
573         https://bugs.webkit.org/show_bug.cgi?id=196393
574
575         Reviewed by Saam Barati.
576
577         Added testdfg as one of the targets to build when
578         using CMake.
579
580         * Scripts/build-jsc:
581
582 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
583
584         Delete WebMetal implementation in favor of WebGPU
585         https://bugs.webkit.org/show_bug.cgi?id=195418
586
587         Reviewed by Dean Jackson.
588
589         * DumpRenderTree/mac/DumpRenderTree.mm:
590         (enableExperimentalFeatures):
591         (resetWebPreferencesToConsistentValues):
592         * Scripts/webkitperl/FeatureList.pm:
593         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
594         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
595         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
596         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
597         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
598         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
599         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
600         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
601         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
602         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
603         (WTR::InjectedBundle::beginTesting):
604         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
605         (WTR::TestRunner::setWebMetalEnabled): Deleted.
606         * WebKitTestRunner/InjectedBundle/TestRunner.h:
607
608 2019-03-29  Chris Dumez  <cdumez@apple.com>
609
610         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
611         https://bugs.webkit.org/show_bug.cgi?id=196405
612         <rdar://problem/49428130>
613
614         Reviewed by Wenson Hsieh.
615
616         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
617         the popover presentation methods to be no-ops. Use this in the new test added in
618         r243523 so that we do not swizzle those methods for all tests. This is needed because
619         those WatchOS tests rely on the popover getting presented and interactive.
620
621         * WebKitTestRunner/TestController.cpp:
622         (WTR::updateTestOptionsFromTestHeader):
623         * WebKitTestRunner/TestController.h:
624         * WebKitTestRunner/TestOptions.h:
625         (WTR::TestOptions::hasSameInitializationOptions const):
626         * WebKitTestRunner/ios/TestControllerIOS.mm:
627         (WTR::TestController::platformInitialize):
628         (WTR::TestController::platformResetStateToConsistentValues):
629
630 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
631
632         [Curl] Add Server Trust Evaluation Support.
633         https://bugs.webkit.org/show_bug.cgi?id=191646
634
635         Reviewed by Fujii Hironori.
636
637         Implemented MiniBrowser UI for asking if user trusts the server.
638
639         * MiniBrowser/win/Common.cpp:
640         (askServerTrustEvaluation):
641         (replaceString):
642         * MiniBrowser/win/Common.h:
643         * MiniBrowser/win/MiniBrowserLib.rc:
644         * MiniBrowser/win/MiniBrowserLibResource.h:
645         * MiniBrowser/win/WebKitBrowserWindow.cpp:
646         (createPEMString):
647         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
648         (WebKitBrowserWindow::canTrustServerCertificate):
649         * MiniBrowser/win/WebKitBrowserWindow.h:
650
651 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
652
653         Implement ResizeObserver.
654         https://bugs.webkit.org/show_bug.cgi?id=157743
655
656         Reviewed by Simon Fraser.
657
658         Support resizeObserverEnabled webPreferences.
659
660         * DumpRenderTree/TestOptions.cpp:
661         (TestOptions::TestOptions):
662         * DumpRenderTree/TestOptions.h:
663         * DumpRenderTree/mac/DumpRenderTree.mm:
664         (setWebPreferencesForTestOptions):
665         * DumpRenderTree/win/DumpRenderTree.cpp:
666         (enableExperimentalFeatures):
667         * Scripts/webkitperl/FeatureList.pm:
668         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
669
670 2019-03-28  John Wilander  <wilander@apple.com>
671
672         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
673         https://bugs.webkit.org/show_bug.cgi?id=196281
674         <rdar://problem/48938748>
675
676         Reviewed by Alex Christensen.
677
678         This patch adds the function isStatisticsHasLocalStorage() to the
679         TestRunner. With it, the page can query the WebsiteDataStore in the
680         UI process to make sure that it sees LocalStorage.
681
682         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
683         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
684         (WTR::TestRunner::isStatisticsHasLocalStorage):
685         * WebKitTestRunner/InjectedBundle/TestRunner.h:
686         * WebKitTestRunner/TestController.cpp:
687         (WTR::TestController::isStatisticsHasLocalStorage):
688         * WebKitTestRunner/TestController.h:
689         * WebKitTestRunner/TestInvocation.cpp:
690         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
691
692 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
693
694         API::Data::createWithoutCopying should do a null check before calling CFRelease
695         https://bugs.webkit.org/show_bug.cgi?id=196276
696         <rdar://problem/48059859>
697
698         Reviewed by Alex Christensen.
699
700         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
701
702         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
703         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
704         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
705         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
706         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
707         (TestWebKitAPI::TEST):
708
709 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
710
711         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
712         https://bugs.webkit.org/show_bug.cgi?id=186276
713
714         Reviewed by Carlos Garcia Campos.
715
716         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
717         (webViewLoadChanged):
718         (testWebResourceGetDataError):
719         (testWebResourceGetDataEmpty):
720         (beforeAll):
721         (webViewloadChanged): Deleted.
722
723 2019-03-27  Andy Estes  <aestes@apple.com>
724
725         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
726         https://bugs.webkit.org/show_bug.cgi?id=196317
727
728         Reviewed by Dan Bernstein.
729
730         package-root copies built products into a staging directory using ditto(1), which does not
731         follow symbolic links as it traverses a directory. Now that the files in
732         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
733         itself, these become broken links when ditto'd into the staging directory.
734
735         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
736
737         * Scripts/package-root:
738
739 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
740
741         [ews-app] Update display text of Submit for ews analysis
742         https://bugs.webkit.org/show_bug.cgi?id=196309
743
744         Reviewed by Dewei Zhu.
745
746         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
747
748 2019-03-27  David Kilzer  <ddkilzer@apple.com>
749
750         run-webkit-tests should check for leaks in WebKit processes
751         <https://webkit.org/b/193772>
752         <rdar://problem/46526680>
753
754         Reviewed by Ryosuke Niwa.
755
756         This works by doing the following:
757         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
758           The list of child processes are returned one per line:
759           process.name: pid
760         - Run the "#LIST CHILD PROCESSES" command just before the
761           "#CHECK FOR WORLD LEAKS" command, and store the list of child
762           processes on the ServerProcess object.
763         - When the `--leaks` switch is handled, run check_for_leaks() on
764           each child process after the main test harness.
765
766         * DumpRenderTree/mac/DumpRenderTree.mm:
767         (handleControlCommand):
768         - Use strncmp() instead of strcmp().
769         - Add support for handling "#LIST CHILD PROCESSES" command.
770
771         * Scripts/webkitpy/port/base.py:
772         (Port.check_for_leaks):
773         * Scripts/webkitpy/port/darwin.py:
774         (DarwinPort.check_for_leaks):
775         - Rename redundant 'process_pid' argument to 'process_id'.
776
777         * Scripts/webkitpy/port/driver.py:
778         (Driver.do_post_tests_work):
779         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
780           longer the only command this sends to WebKitTestRunner.
781         - If the `--leaks` switch is present, send the
782           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
783           result using Port.set_webkit_processes().
784         (Driver._parse_child_processes_output):
785         - Add helper method to parse list of child process names and
786           process IDs returned from WebKitTestRunner.
787
788         * Scripts/webkitpy/port/ios_device.py:
789         (IOSDevicePort.check_for_leaks):
790         - Rename redundant 'process_pid' argument to 'process_id'.
791
792         * Scripts/webkitpy/port/leakdetector.py:
793         (LeakDetector._parse_leaks_output):
794         - Return early if there is no leaks_output.
795         (LeakDetector.check_for_leaks):
796         - Rename redundant 'process_pid' argument to 'process_id'.
797
798         * Scripts/webkitpy/port/server_process.py:
799         (ServerProcess.__init__):
800         (ServerProcess.child_processes):
801         (ServerProcess.set_child_processes):
802         - Add instance variable to Port to store list of child process
803           names and process IDs returned from WebKitTestRunner.
804         (ServerProcess._start):
805         - Clear self._child_processes.
806         (ServerProcess.stop):
807         - If self._child_processes is set, call
808           self._port.check_for_leaks() for each child process.
809
810         * Scripts/webkitpy/port/server_process_unittest.py:
811         (TrivialMockPort.check_for_leaks):
812         - Rename redundant 'process_pid' argument to 'process_id'.
813
814         * Scripts/webkitpy/port/simulator_process.py:
815         (SimulatorProcess.stop):
816         - If self._child_processes is set, call
817           self._port.check_for_leaks() for each child process.
818
819         * Scripts/webkitpy/port/watch_device.py:
820         (WatchDevicePort.check_for_leaks):
821         - Rename redundant 'process_pid' argument to 'process_id'.
822
823         * WebKitTestRunner/TestController.cpp:
824         (WTR::TestController::dumpResponse):
825         - Extract method from findAndDumpWorldLeaks() so that it may be
826           reused by findAndDumpWebKitProcessIdentifiers().
827         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
828         - Add method to output process name and process ID of both the
829           WebContent and Networking processes.
830         (WTR::TestController::findAndDumpWorldLeaks):
831         - Fix missing newline in output when there were no abandoned
832           documents.
833         - Call dumpResponse() for extracted code.
834         (WTR::TestController::handleControlCommand):
835         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
836         - Use strncmp() instead of strcmp().
837         - Call findAndDumpWebKitProcessIdentifiers() when
838           "#LIST CHILD PROCESSES" command is sent.
839         * WebKitTestRunner/TestController.h:
840         (WTR::TestController::dumpResponse):
841         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
842         - Declare methods.
843
844 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
845
846         Unreviewed. Add GLib API test cases after r243434.
847
848         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
849         (testWebViewActiveURI):
850         (serverCallback):
851         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
852         (sendRequestCallback):
853
854 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
855
856         Geolocation request not complete when watch request was started in a different web process
857         https://bugs.webkit.org/show_bug.cgi?id=195996
858
859         Reviewed by Alex Christensen.
860
861         Add a test case.
862
863         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
864         (TestWebKitAPI::runJavaScriptAlert):
865         (TestWebKitAPI::TEST):
866
867 2019-03-26  Keith Rollin  <krollin@apple.com>
868
869         Update the way generate-xcfilelists returns strings from functions
870         https://bugs.webkit.org/show_bug.cgi?id=195975
871         <rdar://problem/49040807>
872
873         Reviewed by Dean Jackson.
874
875         There are places where generate-xcfilelists executes assignments with
876         statements like:
877
878             FOO=$(some_function)
879
880         where "some_function" return a string by echoing it. E.g.
881
882             some_function()
883             {
884                 echo "Hello, World"
885             }
886
887         This is a common idiom, but it has a problem if "some_function" needs
888         to call "exit" in an attempt to halt the entire script right then and
889         there. Since "some_function" is called inside of $(), it's being
890         executed in a sub-shell. Calling exit in that sub-shell simply exits
891         that shell; it doesn't not exit the outer shell in which the main part
892         of the script is still running. As such, the main script keeps
893         executing when the intent was for the script to halt.
894
895         The solution to this is to use a different idiom for returning
896         strings. The one we now is to pass in the name of the variable to
897         receive the string result:
898
899             some_function()
900             {
901                 variable_name=$1
902                 eval $variable_name ="Hello, World"
903             }
904
905         The call site now looks like
906
907             some_function FOO
908
909         Because there's no invocation of a sub-shell, some_function can now
910         call "exit" if it wants to, and the entire script will exit at that
911         point.
912
913         * Scripts/generate-xcfilelists:
914
915 2019-03-26  Chris Dumez  <cdumez@apple.com>
916
917         Add basic layout test coverage for File Picker on iOS
918         https://bugs.webkit.org/show_bug.cgi?id=196265
919
920         Reviewed by Wenson Hsieh.
921
922         Add layout test infrastructure to test the file picker on iOS.
923
924         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
925         (WTR::UIScriptController::dismissFilePicker):
926         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
927         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
928         (WTR::UIScriptController::dismissFilePicker):
929         * TestRunnerShared/UIScriptContext/UIScriptController.h:
930         * WebKitTestRunner/TestController.cpp:
931         (WTR::TestController::createWebViewWithOptions):
932         (WTR::updateTestOptionsFromTestHeader):
933         * WebKitTestRunner/TestOptions.h:
934         (WTR::TestOptions::hasSameInitializationOptions const):
935         * WebKitTestRunner/ios/TestControllerIOS.mm:
936         (overridePresentViewController):
937         (WTR::TestController::platformInitialize):
938         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
939         (WTR::UIScriptController::dismissFilePicker):
940
941 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
942
943         Implement async paste method on UIWKInteractionViewProtocol
944         https://bugs.webkit.org/show_bug.cgi?id=196267
945         <rdar://problem/49236346>
946
947         Reviewed by Tim Horton.
948
949         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
950         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
951         are now a part of all iOS 12 internal SDKs.
952
953         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
954
955         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
956         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
957
958         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
959         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
960         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
961         * TestWebKitAPI/ios/UIKitSPI.h:
962
963 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
964
965         [ews-build] Use PostgreSQL for ews.webkit.org database
966         https://bugs.webkit.org/show_bug.cgi?id=196270
967
968         Reviewed by Lucas Forschler.
969
970         * BuildSlaveSupport/ews-app/ews-app/settings.py:
971
972 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
973
974         [ews] Reset simctl states on reboot
975         https://bugs.webkit.org/show_bug.cgi?id=196260
976
977         Rubber-stamped by Aakash Jain.
978
979         * EWSTools/start-queue-mac.sh:
980
981 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
982
983         [ews-build] Use PostgreSQL for ews-build database
984         https://bugs.webkit.org/show_bug.cgi?id=196229
985
986         Reviewed by Lucas Forschler.
987
988         * BuildSlaveSupport/ews-build/master.cfg:
989
990 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
991
992         [ews-build] Get master_hostname dynamically in master.cfg
993         https://bugs.webkit.org/show_bug.cgi?id=196255
994
995         Reviewed by Lucas Forschler.
996
997         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
998         send events data in test mode.
999
1000 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1001
1002         [ews-app] Set db_constraint to False for Foreign Keys
1003         https://bugs.webkit.org/show_bug.cgi?id=196252
1004
1005         Reviewed by Lucas Forschler.
1006
1007         * BuildSlaveSupport/ews-app/ews/models/build.py:
1008         * BuildSlaveSupport/ews-app/ews/models/step.py:
1009
1010 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1011
1012         [ews-build] is_test_mode_enabled should default to True
1013         https://bugs.webkit.org/show_bug.cgi?id=196248
1014
1015         Reviewed by Lucas Forschler.
1016
1017         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1018
1019 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1020
1021         [ews-app] Add webkitperl to ENABLED_QUEUES
1022         https://bugs.webkit.org/show_bug.cgi?id=196253
1023
1024         Reviewed by Lucas Forschler.
1025
1026         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1027
1028 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1029
1030         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1031         https://bugs.webkit.org/show_bug.cgi?id=196211
1032         rdar://problem/49110552
1033
1034         Reviewed by Tim Horton.
1035
1036         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1037         Make sure that EventSenderProxy always exists when running tests. We used to create
1038         it when resetting before the first test, which is a bit too late.
1039
1040         * WebKitTestRunner/TestController.h:
1041         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1042         (WTR::TestController::platformCreateWebView):
1043         (WTR::TestController::platformCreateOtherPage):
1044         (WTR::TestController::finishCreatingPlatformWebView):
1045         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1046         (WTR::PlatformWebView::PlatformWebView):
1047         Moved some code that made NSWindow use NSEvent during web view creation. We may
1048         need to move more if some other case us found, but this is enough for now.
1049
1050 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1051
1052         Unreviewed. Fix typo in GLib geolocation API after r243285.
1053
1054         gelocation -> geolocation.
1055
1056         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1057         (testGeolocationManagerWatchPosition):
1058
1059 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1060
1061         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1062         https://bugs.webkit.org/show_bug.cgi?id=196213
1063
1064         Reviewed by Geoff Garen.
1065
1066         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1067         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1068         (credentialWithIdentityAndKeychainPath):
1069         (-[ChallengeDelegate webView:didFinishNavigation:]):
1070         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1071         (TestWebKitAPI::TEST):
1072
1073 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1074
1075         Expected shouldn't assume its contained types are copyable
1076         https://bugs.webkit.org/show_bug.cgi?id=195986
1077
1078         Reviewed by JF Bastien.
1079
1080         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1081         (TestWebKitAPI::NonCopyable::operator== const):
1082         (TestWebKitAPI::NonCopyable::operator!= const):
1083         (TestWebKitAPI::TEST):
1084
1085 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1086
1087         Remove some now-unnecessary dynamic class lookup
1088         https://bugs.webkit.org/show_bug.cgi?id=196237
1089
1090         Reviewed by Simon Fraser.
1091
1092         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1093         (makeRequest):
1094         (TEST):
1095
1096 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1097
1098         Unreviewed, rolling out r243450.
1099
1100         AppleWin and WinCairo port builds get broken.
1101
1102         Reverted changeset:
1103
1104         "Add test for fix of #196095"
1105         https://bugs.webkit.org/show_bug.cgi?id=196097
1106         https://trac.webkit.org/changeset/243450
1107
1108 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1109
1110         Unreviewed, rolling out r243465.
1111         https://bugs.webkit.org/show_bug.cgi?id=196226
1112
1113         the test doesn't build (Requested by thorton on #webkit).
1114
1115         Reverted changeset:
1116
1117         "Do not terminate the NetworkProcess if a third party
1118         application sends a NSCredential with a SecIdentityRef"
1119         https://bugs.webkit.org/show_bug.cgi?id=196213
1120         https://trac.webkit.org/changeset/243465
1121
1122 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1123
1124         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1125         https://bugs.webkit.org/show_bug.cgi?id=196213
1126
1127         Reviewed by Geoff Garen.
1128
1129         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1130         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1131         (credentialWithIdentityAndKeychainPath):
1132         (-[ChallengeDelegate webView:didFinishNavigation:]):
1133         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1134         (TestWebKitAPI::TEST):
1135
1136 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1137
1138         [ews-build] Gracefully handle missing patch_id in events
1139         https://bugs.webkit.org/show_bug.cgi?id=196216
1140
1141         Reviewed by Lucas Forschler.
1142
1143         * BuildSlaveSupport/ews-build/events.py:
1144
1145 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1146
1147         [ews-build] use lz4 compression for improving buildbot performance
1148         https://bugs.webkit.org/show_bug.cgi?id=196155
1149
1150         Reviewed by Lucas Forschler.
1151
1152         * BuildSlaveSupport/ews-build/master.cfg:
1153
1154 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1155
1156         Pull some API testing helper methods out of TestWKWebView
1157         https://bugs.webkit.org/show_bug.cgi?id=196212
1158
1159         Reviewed by Tim Horton.
1160
1161         Refactor some more API testing utility methods, so that they can be used in
1162         tests that do not use TestWKWebView.
1163
1164         * TestWebKitAPI/cocoa/TestWKWebView.h:
1165         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1166         (-[WKWebView loadTestPageNamed:]):
1167         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1168         (-[WKWebView synchronouslyLoadHTMLString:]):
1169         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1170         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1171         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1172         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1173         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1174
1175 2019-03-25  Jer Noble  <jer.noble@apple.com>
1176
1177         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1178         https://bugs.webkit.org/show_bug.cgi?id=196097
1179
1180         Reviewed by Eric Carlson.
1181
1182         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1183
1184         * DumpRenderTree/mac/DumpRenderTree.mm:
1185         (resetWebPreferencesToConsistentValues):
1186         * WebKitTestRunner/TestController.cpp:
1187         (WTR::TestController::resetPreferencesToConsistentValues):
1188
1189 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1190
1191         Pull IPadUserInterfaceSwizzler out into a separate header file
1192         https://bugs.webkit.org/show_bug.cgi?id=196193
1193
1194         Reviewed by Anders Carlsson.
1195
1196         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1197         be used in other API tests.
1198
1199         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1200         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1201         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1202         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1203         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1204         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1205         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1206
1207 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1208
1209         Remove NavigatorContentUtils in WebCore/Modules
1210         https://bugs.webkit.org/show_bug.cgi?id=196070
1211
1212         Reviewed by Alex Christensen.
1213
1214         NavigatorContentUtils was to support the custom scheme spec [1].
1215         However, in WebKit side, no port has supported the feature in
1216         WebKit layer after EFL port was removed. So there has been the
1217         only IDL implementation of the NavigatorContentUtils in WebCore.
1218         So we don't need to keep the implementation in WebCore anymore.
1219
1220         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1221
1222         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1223
1224 2019-03-24  Andy Estes  <aestes@apple.com>
1225
1226         [watchOS] Remove unused Proximity Networking code
1227         https://bugs.webkit.org/show_bug.cgi?id=196188
1228
1229         Reviewed by Tim Horton.
1230
1231         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1232         (TEST):
1233
1234 2019-03-23  Keith Miller  <keith_miller@apple.com>
1235
1236         Refactor clz/ctz and fix getLSBSet.
1237         https://bugs.webkit.org/show_bug.cgi?id=196162
1238
1239         Reviewed by Saam Barati.
1240
1241         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1242
1243         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1244         (TestWebKitAPI::TEST):
1245
1246 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1247
1248         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1249         https://bugs.webkit.org/show_bug.cgi?id=196143
1250
1251         Reviewed by Michael Catanzaro.
1252
1253         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1254         directories.
1255
1256         * Scripts/webkitpy/style/checkers/cpp.py:
1257         (check_identifier_name_in_declaration):
1258         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1259         (WebKitStyleTest.test_names):
1260
1261 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1262
1263         [Flatpak] Manifest expanding fails for qt WPE extension
1264         https://bugs.webkit.org/show_bug.cgi?id=196148
1265
1266         Reviewed by Alex Christensen.
1267
1268         * flatpak/flatpakutils.py:
1269         (expand_submodules_recurse): The last recurse manifest expand
1270         iteration might lead to a single module so take it into account
1271         and don't try to recurse further.
1272
1273 2019-03-22  Chris Dumez  <cdumez@apple.com>
1274
1275         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1276         https://bugs.webkit.org/show_bug.cgi?id=195348
1277         <rdar://problem/48622090>
1278
1279         Reviewed by Alex Christensen.
1280
1281         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1282         to NO when test.options().shouldIgnoreMetaViewport is false.
1283
1284         * WebKitTestRunner/ios/TestControllerIOS.mm:
1285         (WTR::TestController::platformConfigureViewForTest):
1286
1287 2019-03-22  Chris Dumez  <cdumez@apple.com>
1288
1289         Prewarmed processes should be usable with any website data store
1290         https://bugs.webkit.org/show_bug.cgi?id=196104
1291
1292         Reviewed by Alex Christensen.
1293
1294         Add API test coverage.
1295
1296         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1297         (runInitialWarmedProcessUsedTest):
1298         (TEST):
1299
1300 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1301
1302         Back out local changes to Alex's Subversion working directory
1303
1304         They were accidentally committed.
1305
1306         * Scripts/webkitpy/common/system/abstractexecutive.py:
1307         (AbstractExecutive.wait_newest):
1308         * Scripts/webkitpy/common/system/executive.py:
1309         (Executive.running_pids):
1310         * Scripts/webkitpy/common/system/executive_mock.py:
1311         (MockExecutive.running_pids):
1312         * Scripts/webkitpy/common/system/executive_unittest.py:
1313         (ExecutiveTest.serial_test_running_pids):
1314         * Scripts/webkitpy/port/darwin.py:
1315         (DarwinPort.check_for_leaks):
1316         * Scripts/webkitpy/port/leakdetector.py:
1317         (LeakDetector.check_for_leaks):
1318         - This was the hack attached to Bug 193772.
1319
1320         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1321         (+[WebKitTestRunnerEvent mouseLocation]):
1322         - This works around a crash on an internal build.
1323
1324 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1325
1326         Fix the build after r243354
1327         https://bugs.webkit.org/show_bug.cgi?id=196138
1328         <rdar://problem/49145951>
1329
1330         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1331         (TEST):
1332         * TestWebKitAPI/ios/UIKitSPI.h:
1333
1334 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1335
1336         Adopt UIWKDocumentContext
1337         https://bugs.webkit.org/show_bug.cgi?id=196040
1338         <rdar://problem/48642440>
1339
1340         Reviewed by Ryosuke Niwa.
1341
1342         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1343         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1344         (makeRequest):
1345         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1346         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1347         (applyStyle):
1348         (TEST):
1349         Add tests for UIWKDocumentContext.
1350
1351         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1352         (TEST):
1353         (recursiveFindWKContentView): Deleted.
1354         * TestWebKitAPI/cocoa/TestWKWebView.h:
1355         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1356         (recursiveFindWKContentView):
1357         (-[TestWKWebView wkContentView]):
1358         * TestWebKitAPI/ios/UIKitSPI.h:
1359         Share the WKContentView finding code between tests.
1360
1361 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1362
1363         [iOS WK2] Turn on async overflow scrolling by default
1364         https://bugs.webkit.org/show_bug.cgi?id=196011
1365         rdar://problem/48453859
1366
1367         Reviewed by Antti Koivisto.
1368         
1369         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1370         since so many basic layout tests have different results when compositing is triggered for
1371         overflow.
1372         
1373         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1374
1375         * WebKitTestRunner/TestController.cpp:
1376         (WTR::TestController::resetPreferencesToConsistentValues):
1377
1378 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1379
1380         [ews-build] Retry API test in case of failures
1381         https://bugs.webkit.org/show_bug.cgi?id=196004
1382
1383         Reviewed by Lucas Forschler.
1384
1385         * BuildSlaveSupport/ews-build/steps.py:
1386         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1387         (CompileWebKitToT.doStepIf): Ditto.
1388         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1389         (ReRunAPITests): Re-run API tests.
1390         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1391         (RunAPITestsWithoutPatch): Run API tests without patch.
1392         (RunAPITestsWithoutPatch.doStepIf):
1393         (RunAPITestsWithoutPatch.hideStepIf):
1394         (RunAPITestsWithoutPatch.evaluateCommand):
1395         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1396         (AnalyzeAPITestsResults.start):
1397         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1398         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1399         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1400         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1401
1402 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1403
1404         [ews-build] Update queues configurations
1405         https://bugs.webkit.org/show_bug.cgi?id=196074
1406
1407         Reviewed by Dewei Zhu.
1408
1409         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1410         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1411
1412 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1413
1414         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1415         https://bugs.webkit.org/show_bug.cgi?id=195680
1416         <rdar://problem/48903534>
1417
1418         Unreviewed infrastructure fix.
1419
1420         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1421         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1422
1423 2019-03-21  Andy Estes  <aestes@apple.com>
1424
1425         [iOS] Apple Pay should be available in documents with no user agent scripts
1426         https://bugs.webkit.org/show_bug.cgi?id=196061
1427         <rdar://problem/48649391>
1428
1429         Reviewed by Brady Eidson.
1430
1431         Added API tests and related infrastructure.
1432
1433         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1434         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1435         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1436         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1437         (TestWebKitAPI::TEST):
1438         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1439         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1440         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1441         * TestWebKitAPI/cocoa/TestProtocol.mm:
1442         (-[TestProtocol startLoading]):
1443         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1444         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1445         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1446         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1447
1448 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1449
1450         REGRESSSION (r243297): webkitpy tests broken
1451         https://bugs.webkit.org/show_bug.cgi?id=196108
1452
1453         Reviewed by Aakash Jain.
1454
1455         r243297 updated contributors.json, which broke a few unit tests.
1456
1457         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1458         (IRCCommandTest.test_whois):
1459         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1460
1461 2019-03-21  Chris Dumez  <cdumez@apple.com>
1462
1463         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1464         https://bugs.webkit.org/show_bug.cgi?id=196041
1465         <rdar://problem/49083230>
1466
1467         Reviewed by Alex Christensen.
1468
1469         Add API test coverage.
1470
1471         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1472         (TEST):
1473
1474 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1475
1476         Add SPI to inform applications of WKContentRuleList actions
1477         https://bugs.webkit.org/show_bug.cgi?id=195965
1478         <rdar://problem/42664365>
1479
1480         Reviewed by Geoff Garen.
1481
1482         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1483         (TestWebKitAPI::allActionsForResourceLoad):
1484         (TestWebKitAPI::testRequest):
1485         (TestWebKitAPI::TEST_F):
1486         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1487         (Notification::description):
1488         (Notification::operator== const):
1489         (toVector):
1490         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1491         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1492         (makeContentRuleList):
1493         (TEST):
1494         (makeWarnContentRuleList): Deleted.
1495
1496 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1497
1498         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1499         https://bugs.webkit.org/show_bug.cgi?id=196088
1500
1501         Reviewed by Brian Burg.
1502
1503         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1504         Support checks when only one platform is specified. Also deprecate macosx() and
1505         force the use of macos() instead.
1506
1507         * Scripts/webkitpy/style/checkers/cpp.py:
1508         (check_min_versions_of_wk_api_available):
1509         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1510         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1511
1512 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1513
1514         Update status inactive committers' status to 'contributor'.
1515
1516         * Scripts/webkitpy/common/config/contributors.json:
1517
1518 2019-03-21  Xan Lopez  <xan@igalia.com>
1519
1520         [JSC][x86] Drop support for x87 floating point
1521         https://bugs.webkit.org/show_bug.cgi?id=194853
1522
1523         Reviewed by Don Olmstead.
1524
1525         Force SSE2 on x86/32bit builds.
1526
1527         * Scripts/webkitdirs.pm:
1528         (generateBuildSystemFromCMakeProject):
1529
1530 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1531
1532         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1533         https://bugs.webkit.org/show_bug.cgi?id=196073
1534
1535         Reviewed by Michael Catanzaro.
1536
1537         Add test cases to check functions and constructors with no arguments but receiving user data.
1538
1539         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1540         (checkUserData):
1541         (testJSCFunction):
1542         (fooCreateWithUserData):
1543         (testJSCClass):
1544
1545 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1546
1547         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1548
1549         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1550
1551         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1552
1553 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1554
1555         [GTK][WPE] Add API to provide geolocation information
1556         https://bugs.webkit.org/show_bug.cgi?id=195940
1557
1558         Reviewed by Michael Catanzaro.
1559
1560         Add a new test to check the new API.
1561
1562         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1563         (testGeolocationManagerCurrentPosition):
1564         (testGeolocationManagerWatchPosition):
1565         (beforeAll):
1566         (afterAll):
1567         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1568         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1569         (beforeAll): Ditto.
1570         * TestWebKitAPI/glib/CMakeLists.txt:
1571
1572 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1573
1574         [GLib] Returning G_TYPE_OBJECT from a method does not work
1575         https://bugs.webkit.org/show_bug.cgi?id=195574
1576
1577         Reviewed by Michael Catanzaro.
1578
1579         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1580
1581         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1582         (getGFile):
1583         (getParent):
1584         (createGString):
1585         (getGString):
1586         (getGStringCopyWillRaise):
1587         (getGStringCopy):
1588         (getGStringStr):
1589         (getGStringLen):
1590         (freeGString):
1591         (testJSCClass):
1592
1593 2019-03-20  Saam Barati  <sbarati@apple.com>
1594
1595         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1596         https://bugs.webkit.org/show_bug.cgi?id=195721
1597
1598         Reviewed by Filip Pizlo.
1599
1600         * Scripts/run-javascriptcore-tests:
1601
1602 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1603
1604         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
1605         https://bugs.webkit.org/show_bug.cgi?id=196049
1606
1607         Reviewed by Tim Horton.
1608
1609         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
1610         overflow scrolling in general, so rename it.
1611
1612         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1613
1614 2019-03-20  Daniel Bates  <dabates@apple.com>
1615
1616         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
1617         https://bugs.webkit.org/show_bug.cgi?id=196031
1618         <rdar://problem/49078172>
1619
1620         Reviewed by Tim Horton.
1621
1622         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
1623         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
1624         same code path used when the Done button is pressed to dismiss the <select> picker.
1625
1626         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1627         (TestWebKitAPI::TEST):
1628
1629 2019-03-20  Chris Dumez  <cdumez@apple.com>
1630
1631         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
1632         https://bugs.webkit.org/show_bug.cgi?id=196029
1633         <rdar://problem/48954651>
1634
1635         Reviewed by Tim Horton.
1636
1637         Add API test coverage.
1638
1639         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1640
1641 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
1642
1643         [ews-build] Improve failure summary string for ApplyPatch step
1644         https://bugs.webkit.org/show_bug.cgi?id=195995
1645
1646         Reviewed by Alexey Proskuryakov.
1647
1648         * BuildSlaveSupport/ews-build/steps.py:
1649         (ApplyPatch.getResultSummary): Override getResultSummary.
1650
1651 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
1652
1653         AX: Implement support for new meter ARIA role
1654         https://bugs.webkit.org/show_bug.cgi?id=195966
1655
1656         Reviewed by Chris Fleizach.
1657
1658         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
1659         to AXLevelIndicator.
1660
1661         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1662
1663 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
1664
1665         [WebAuthN] Implement FIDO AppID extension
1666         https://bugs.webkit.org/show_bug.cgi?id=143491
1667         <rdar://problem/48298273>
1668
1669         Reviewed by Brent Fulgham.
1670
1671         Add a test that covers the new flag of convertToU2fSignCommand.
1672
1673         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
1674         (TestWebKitAPI::TEST):
1675         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1676         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
1677         (TestWebKitAPI::TEST):
1678
1679 2019-03-19  Keith Rollin  <krollin@apple.com>
1680
1681         Add support for more platforms to generate-xcfilelists
1682         https://bugs.webkit.org/show_bug.cgi?id=195977
1683
1684         Reviewed by Alexey Proskuryakov.
1685
1686         generate-xcfilelists incorrectly complains when involved with building
1687         WebKit for iphonesimulator:
1688
1689             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
1690             …
1691             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
1692
1693         Address this by teaching generate-xcfilelists about more platforms.
1694
1695         * Scripts/generate-xcfilelists:
1696
1697 2019-03-19  John Wilander  <wilander@apple.com>
1698
1699         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
1700         https://bugs.webkit.org/show_bug.cgi?id=195923
1701         <rdar://problem/49001272>
1702
1703         Reviewed by Alex Christensen.
1704
1705         This patch does the following to the TestRunner:
1706         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
1707         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
1708         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
1709
1710         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1711         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1712         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1713         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1714         * WebKitTestRunner/TestController.cpp:
1715         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1716         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1717         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1718         * WebKitTestRunner/TestController.h:
1719         * WebKitTestRunner/TestInvocation.cpp:
1720         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1721
1722 2019-03-19  Christopher Reid  <chris.reid@sony.com>
1723
1724         [CMake] Support more clang and gcc sanitizers
1725         https://bugs.webkit.org/show_bug.cgi?id=195956
1726
1727         Reviewed by Michael Catanzaro.
1728
1729         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
1730
1731 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1732
1733         [ews-build] Improve summary for PrintConfiguration step
1734         https://bugs.webkit.org/show_bug.cgi?id=195945
1735
1736         Reviewed by Lucas Forschler.
1737
1738         * BuildSlaveSupport/ews-build/steps.py:
1739         (PrintConfiguration.getResultSummary): Override getResultSummary.
1740
1741 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1742
1743         [ews-build] Improve summary for CheckOutSource step
1744         https://bugs.webkit.org/show_bug.cgi?id=195963
1745
1746         Reviewed by Lucas Forschler.
1747
1748         * BuildSlaveSupport/ews-build/steps.py:
1749         (CheckOutSource.getResultSummary):
1750
1751 2019-03-19  Daniel Bates  <dabates@apple.com>
1752
1753         [iOS] Focus not preserved when switching between tabs
1754         https://bugs.webkit.org/show_bug.cgi?id=195820
1755         <rdar://problem/43614450>
1756
1757         Reviewed by Brent Fulgham.
1758
1759         Add tests to ensure that we restore focus when resigning and becoming first responder.
1760
1761         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1762         (TestWebKitAPI::TEST):
1763
1764 2019-03-19  Alex Christensen  <achristensen@webkit.org>
1765
1766         Make WTFLogChannelState and WTFLogLevel enum classes
1767         https://bugs.webkit.org/show_bug.cgi?id=195904
1768
1769         Reviewed by Eric Carlson.
1770
1771         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1772         (TestWebKitAPI::TEST_F):
1773
1774 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1775
1776         [GStreamer][EME] Backported mssdemux protection data crash fix
1777         https://bugs.webkit.org/show_bug.cgi?id=195918
1778
1779         Reviewed by Philippe Normand.
1780
1781         * gstreamer/jhbuild.modules:
1782         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
1783
1784 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1785
1786         Unreviewed, rolling out r243132.
1787
1788         Broke GTK build
1789
1790         Reverted changeset:
1791
1792         "Make WTFLogChannelState and WTFLogLevel enum classes"
1793         https://bugs.webkit.org/show_bug.cgi?id=195904
1794         https://trac.webkit.org/changeset/243132
1795
1796 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
1797
1798         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
1799
1800         * Scripts/webkitdirs.pm:
1801         (builtDylibPathForName): Adjust the shared library name that's changed
1802         with the API version bump in r243073.
1803
1804 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1805
1806         Make WTFLogChannelState and WTFLogLevel enum classes
1807         https://bugs.webkit.org/show_bug.cgi?id=195904
1808
1809         Reviewed by Eric Carlson.
1810
1811         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1812         (TestWebKitAPI::TEST_F):
1813
1814 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1815
1816         Disable flaky test added in r2431100
1817         https://webkit.org/b/195785
1818
1819         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1820         (TestWebKitAPI::TEST):
1821         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
1822
1823 2019-03-18  Timothy Hatcher  <timothy@apple.com>
1824
1825         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
1826         https://bugs.webkit.org/show_bug.cgi?id=195916
1827
1828         Reviewed by Tim Horton.
1829
1830         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1831         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
1832
1833 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
1834
1835         Add a secondary e-mail address for Fujii Hironori to make tools happier.
1836
1837         * Scripts/webkitpy/common/config/contributors.json:
1838
1839 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1840
1841         Implement DownloadMonitor to prevent long-running slow downloads from background apps
1842         https://bugs.webkit.org/show_bug.cgi?id=195785
1843
1844         Reviewed by Geoffrey Garen.
1845
1846         * TestWebKitAPI/TCPServer.cpp: Added.
1847         (TestWebKitAPI::TCPServer::TCPServer):
1848         (TestWebKitAPI::TCPServer::~TCPServer):
1849         (TestWebKitAPI::TCPServer::socketBindListen):
1850         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
1851         * TestWebKitAPI/TCPServer.h: Added.
1852         (TestWebKitAPI::TCPServer::port const):
1853         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1854         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1855         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
1856         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
1857         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1858         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
1859         (TestWebKitAPI::respondSlowly):
1860         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
1861         (TestWebKitAPI::downloadAtRate):
1862         (TestWebKitAPI::TEST):
1863
1864 2019-03-18  Saam Barati  <sbarati@apple.com>
1865
1866         Add a plan file for JetStream 2
1867         https://bugs.webkit.org/show_bug.cgi?id=190734
1868
1869         Reviewed by Mark Lam.
1870
1871         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
1872
1873 2019-03-18  Chris Dumez  <cdumez@apple.com>
1874
1875         Delay WebProcess launch until a load is triggered in a Web view
1876         https://bugs.webkit.org/show_bug.cgi?id=195758
1877         <rdar://problem/48126013>
1878
1879         Reviewed by Geoff Garen.
1880
1881         Add API test coverage. Also update some existing API tests to not expect
1882         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
1883
1884         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
1885         (TestWebKitAPI::TEST):
1886         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
1887         (TestWebKitAPI::TEST):
1888         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1889         (TEST):
1890         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1891         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1892         (TEST):
1893         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1894         (TEST):
1895         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
1896
1897 2019-03-18  Xan Lopez  <xan@igalia.com>
1898
1899         [CMake] Prevent potential warning when determining $architecture
1900         https://bugs.webkit.org/show_bug.cgi?id=195891
1901
1902         Reviewed by Michael Catanzaro.
1903
1904         It's possible for generateBuildSystemForCMakeProject to be called
1905         before determineArchitecture() is ever called. This will make the
1906         first eq check with $architecture to be bogus (and print a
1907         warning). Change that to an eq check with architecture(), which
1908         implicitly calls determineArchitecture() if needed, and change all
1909         the other similar cases in the method in the same way to prevent
1910         future bugs like this one.
1911
1912         * Scripts/webkitdirs.pm:
1913         (generateBuildSystemFromCMakeProject):
1914
1915 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1916
1917         [WPE] Tarballs generated with “make dist” cannot build documentation
1918         https://bugs.webkit.org/show_bug.cgi?id=195885
1919
1920         Reviewed by Carlos Garcia Campos.
1921
1922         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
1923
1924 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1925
1926         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
1927         https://bugs.webkit.org/show_bug.cgi?id=195883
1928
1929         Reviewed by Carlos Garcia Campos.
1930
1931         * gtkdoc/gtkdoc.py:
1932         (GTKDoc._run_command): When commands fail to run, include the full command line for
1933         the program invocation and the output it has generated on the standard error stream.
1934
1935 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1936
1937         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
1938         https://bugs.webkit.org/show_bug.cgi?id=195786
1939
1940         Reviewed by Philippe Normand.
1941
1942         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
1943         * wpe/jhbuild.modules: Ditto.
1944
1945 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
1946
1947         [ews-build] Don't run clean builds on EWS builders
1948         https://bugs.webkit.org/show_bug.cgi?id=195851
1949
1950         Reviewed by Geoffrey Garen.
1951
1952         * BuildSlaveSupport/ews-build/factories.py:
1953
1954 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
1955
1956         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
1957         https://bugs.webkit.org/show_bug.cgi?id=195849
1958
1959         Reviewed by Chris Dumez.
1960
1961         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
1962
1963         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1964         (runWebsiteDataStoreCustomPaths):
1965
1966 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
1967
1968         webkitpy: Upload test results
1969         https://bugs.webkit.org/show_bug.cgi?id=195755
1970         <rdar://problem/48896182>
1971
1972         Reviewed by Aakash Jain.
1973
1974         Establish a new format for uploading results that is not tied to layout tests, apply
1975         that format to webkitpy tests.
1976
1977         * Scripts/webkitpy/common/checkout/scm/git.py:
1978         (Git.native_branch): Return what branch the current checkout is on.
1979         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1980         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1981         * Scripts/webkitpy/common/checkout/scm/svn.py:
1982         (SVN.native_branch): Ditto.
1983         * Scripts/webkitpy/common/system/platforminfo.py:
1984         (PlatformInfo.build_version): Return a build version for Mac.
1985         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1986         (MockPlatformInfo.__init__):
1987         (MockPlatformInfo.build_version):
1988         * Scripts/webkitpy/results: Added.
1989         * Scripts/webkitpy/results/__init__.py: Added.
1990         * Scripts/webkitpy/results/options.py: Added.
1991         (upload_options): OptParse list for upload options.
1992         * Scripts/webkitpy/results/upload.py: Added.
1993         (Upload): Class which enforces the upload format expected by the results server.
1994         (Upload.Expectations):
1995         (Upload.create_configuration):
1996         (Upload.create_commit):
1997         (Upload.create_details):
1998         (Upload.create_run_stats):
1999         (Upload.create_test_result):
2000         (Upload.__init__):
2001         (Upload.Encoder): Encode Upload object as json.
2002         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2003         * Scripts/webkitpy/results/upload_unittest.py: Added.
2004         * Scripts/webkitpy/test/main.py:
2005         (Tester._parse_args): Add upload arguments.
2006         (Tester._run_tests): Allow results to be uploaded.
2007         * Scripts/webkitpy/test/runner.py:
2008         (Runner.__init__): Record which tests were run, rather than just counting them.
2009         (Runner.handle):
2010         * Scripts/webkitpy/test/runner_unittest.py:
2011         (RunnerTest.test_run):
2012         * Scripts/webkitpy/thirdparty/__init__.py:
2013         (AutoinstallImportHook.find_module): Add requests auto-install.
2014         (AutoinstallImportHook._install_requests):
2015         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2016         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2017
2018 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2019
2020         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2021         https://bugs.webkit.org/show_bug.cgi?id=195810
2022
2023         Reviewed by Tim Horton.
2024
2025         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2026         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2027         ending certain layout tests.
2028
2029         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2030         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2031         (-[TestRunnerWKWebView dealloc]):
2032         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2033
2034         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2035         helper method when destroying the web view, and when resetting state between tests.
2036
2037         * WebKitTestRunner/ios/TestControllerIOS.mm:
2038         (WTR::TestController::platformResetStateToConsistentValues):
2039
2040         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2041
2042 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2043
2044         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2045         https://bugs.webkit.org/show_bug.cgi?id=190350
2046         <rdar://problem/45089503>
2047
2048         Reviewed by Geoffrey Garen.
2049
2050         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2051         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2052         (TEST):
2053         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2054         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2055         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2056         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2057         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2058         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2059         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2060         (runTest):
2061         (createDirectories):
2062         (TEST):
2063         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2064         (TEST):
2065         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2066         (TEST):
2067
2068 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2069
2070         Add support to WebPage for getting the contents as an attributed string.
2071         https://bugs.webkit.org/show_bug.cgi?id=195636
2072         rdar://problem/45055697
2073
2074         Reviewed by Tim Horton.
2075
2076         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2077         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2078
2079 2019-03-15  Chris Dumez  <cdumez@apple.com>
2080
2081         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2082         https://bugs.webkit.org/show_bug.cgi?id=195747
2083
2084         Reviewed by Geoff Garen.
2085
2086         Add API test coverage.
2087
2088         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2089
2090 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2091
2092         Unreviewed, rolling out r242952.
2093
2094         Causing API failures on iOS Simulator
2095
2096         Reverted changeset:
2097
2098         "[PSON] Make sure the WebProcessCache is leverage when
2099         relaunching a process after termination"
2100         https://bugs.webkit.org/show_bug.cgi?id=195747
2101         https://trac.webkit.org/changeset/242952
2102
2103 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2104
2105         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2106         https://bugs.webkit.org/show_bug.cgi?id=195740
2107
2108         Reviewed by Ross Kirsling.
2109
2110         window.open doesn't work for WebKitBrowserWindow because it is not
2111         implemented yet.
2112
2113         1. Implemented createNewPage callback of WKPageUIClient.
2114         2. Changed MainWindow to take a BrowserWindow factory function
2115           instead of BrowserWindowType to be flexible to create
2116           BrowserWindow with extra settings.
2117         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2118           because it is not relevant with MainWindow anymore.
2119
2120         * MiniBrowser/win/Common.cpp:
2121         (parseCommandLine):
2122         * MiniBrowser/win/Common.h:
2123         (CommandLineOptions::CommandLineOptions):
2124         * MiniBrowser/win/MainWindow.cpp:
2125         (MainWindow::MainWindow):
2126         (MainWindow::create):
2127         (MainWindow::init):
2128         (MainWindow::WndProc):
2129         * MiniBrowser/win/MainWindow.h:
2130         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2131         (PrintWebUIDelegate::createWebViewWithRequest):
2132         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2133         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2134         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2135         (WebKitBrowserWindow::updateProxySettings):
2136         (WebKitBrowserWindow::createNewPage):
2137         * MiniBrowser/win/WebKitBrowserWindow.h:
2138         * MiniBrowser/win/WinMain.cpp:
2139         (wWinMain):
2140
2141 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2142
2143         Make it possible to test scrolling tree layer manipulation more easily
2144         https://bugs.webkit.org/show_bug.cgi?id=195780
2145
2146         Reviewed by Tim Horton.
2147         
2148         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2149         cuts off communication of scrolling tree scrolls back to the web process
2150         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2151         allows tests to trigger scrolls which run the scrolling tree layer positioning
2152         logic, but never get another commit from the web process that might mask
2153         scrolling tree bugs.
2154         
2155         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2156         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2157         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2158
2159         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2160         (WTR::UIScriptController::scrollUpdatesDisabled const):
2161         (WTR::UIScriptController::setScrollUpdatesDisabled):
2162         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2163         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2164         (WTR::UIScriptController::scrollUpdatesDisabled const):
2165         (WTR::UIScriptController::setScrollUpdatesDisabled):
2166         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2167         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2168         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2169         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2170         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2171         * WebKitTestRunner/ios/TestControllerIOS.mm:
2172         (WTR::TestController::platformResetStateToConsistentValues):
2173         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2174         (WTR::UIScriptController::scrollUpdatesDisabled const):
2175         (WTR::UIScriptController::setScrollUpdatesDisabled):
2176
2177 2019-03-14  Youenn Fablet  <youenn@apple.com>
2178
2179         Move IDB storage in private browsing mode to NetworkProcess
2180         https://bugs.webkit.org/show_bug.cgi?id=195602
2181
2182         Reviewed by Brady Eidson.
2183
2184         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2185         (TEST):
2186
2187 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2188
2189         [ews-build] Make descriptionDone messages more readable
2190         https://bugs.webkit.org/show_bug.cgi?id=195760
2191
2192         Reviewed by Lucas Forschler.
2193
2194         * BuildSlaveSupport/ews-build/steps.py:
2195         * BuildSlaveSupport/ews-build/steps_unittest.py:
2196
2197 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2198
2199         [ews-build] Generate status-bubble hover-over messages
2200         https://bugs.webkit.org/show_bug.cgi?id=195680
2201
2202         Reviewed by Lucas Forschler.
2203
2204         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2205         (StatusBubble):
2206         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2207         on hover-over.
2208         (StatusBubble._iso_time):
2209         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2210         hover-over message.
2211         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2212
2213 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2214
2215         [ews-app] Gracefully handle the case when state_string is None
2216         https://bugs.webkit.org/show_bug.cgi?id=195753
2217
2218         Reviewed by Lucas Forschler.
2219
2220         * BuildSlaveSupport/ews-app/ews/models/build.py:
2221         * BuildSlaveSupport/ews-app/ews/models/step.py:
2222
2223 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2224
2225         [ews-app] Status bubble display pending for currently running build step
2226         https://bugs.webkit.org/show_bug.cgi?id=195744
2227
2228         Reviewed by Lucas Forschler.
2229
2230         * BuildSlaveSupport/ews-build/events.py:
2231         (Events.stepStarted): If state_string is pending, replace it with step name.
2232
2233 2019-03-14  Chris Dumez  <cdumez@apple.com>
2234
2235         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2236         https://bugs.webkit.org/show_bug.cgi?id=195750
2237
2238         Reviewed by Geoffrey Garen.
2239
2240         Add API test coverage.
2241
2242         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2243         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2244         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2245         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2246
2247 2019-03-14  Chris Dumez  <cdumez@apple.com>
2248
2249         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2250         https://bugs.webkit.org/show_bug.cgi?id=195747
2251
2252         Reviewed by Geoff Garen.
2253
2254         Add API test coverage.
2255
2256         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2257
2258 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2259
2260         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2261         https://bugs.webkit.org/show_bug.cgi?id=195725
2262         <rdar://problem/48545062>
2263
2264         Reviewed by Tim Horton.
2265
2266         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2267         handler is nil.
2268
2269         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2270         (TestWebKitAPI::TEST):
2271
2272 2019-03-13  Sam Weinig  <sam@webkit.org>
2273
2274         Add utility function to allow easy reverse range-based iteration of a container
2275         https://bugs.webkit.org/show_bug.cgi?id=195542
2276
2277         Reviewed by Antti Koivisto.
2278
2279         * TestWebKitAPI/CMakeLists.txt:
2280         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2281         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2282         (TestWebKitAPI::TEST):
2283         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2284
2285 2019-03-13  Chris Dumez  <cdumez@apple.com>
2286
2287         Use a ServiceWorker process per registrable domain
2288         https://bugs.webkit.org/show_bug.cgi?id=195649
2289
2290         Reviewed by Youenn Fablet.
2291
2292         Update API test coverage.
2293
2294         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2295
2296 2019-03-13  Chris Dumez  <cdumez@apple.com>
2297
2298         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2299         https://bugs.webkit.org/show_bug.cgi?id=195684
2300         <rdar://problem/48294714>
2301
2302         Reviewed by Antti Koivisto.
2303
2304         Add API test coverage.
2305
2306         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2307
2308 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2309
2310         [ews-app] Remove unused patch view
2311         https://bugs.webkit.org/show_bug.cgi?id=195669
2312
2313         Reviewed by Lucas Forschler.
2314
2315         * BuildSlaveSupport/ews-app/ews/urls.py:
2316         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2317
2318 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2319
2320         [ews-app] Use Buildbot result code variables
2321         https://bugs.webkit.org/show_bug.cgi?id=195668
2322
2323         Reviewed by Alexey Proskuryakov.
2324
2325         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2326         (Buildbot): Added Buildbot result code variables.
2327         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2328         (StatusBubble._build_bubble): Used Buildbot result code variables.
2329
2330 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2331
2332         [Flatpak] Expand submodule recursively
2333         https://bugs.webkit.org/show_bug.cgi?id=195672
2334
2335         Building WPE with flatpak was impossible without that as it was raising an exception.
2336         Also update wpebackend-fdo to match what is built in jhbuild
2337
2338         Reviewed by Philippe Normand.
2339
2340         * flatpak/flatpakutils.py:
2341         (expand_submodules_recurse):
2342         (expand_manifest):
2343         * flatpak/org.webkit.WPEModules.yaml:
2344
2345 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2346
2347         [ews-app] status bubble should be hidden for certain builds
2348         https://bugs.webkit.org/show_bug.cgi?id=194597
2349
2350         Reviewed by Dewei Zhu.
2351
2352         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2353         (StatusBubble._build_bubble):
2354         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2355         because the patch didn't have relevant changes.
2356         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2357         in production yet.
2358
2359 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2360
2361         [Win] Fix a slew of simple clang-cl warnings.
2362         https://bugs.webkit.org/show_bug.cgi?id=195652
2363
2364         Reviewed by Don Olmstead.
2365
2366         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2367         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2368
2369 2019-03-12  Justin Fan  <justin_fan@apple.com>
2370
2371         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2372         https://bugs.webkit.org/show_bug.cgi?id=195518
2373         <rdar://problem/46322356>
2374
2375         Reviewed by Myles C. Maxfield.
2376
2377         * DumpRenderTree/DerivedSources-input.xcfilelist:
2378         * DumpRenderTree/DerivedSources-output.xcfilelist:
2379
2380 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2381
2382         Unreviewed, rolling out r242825.
2383         https://bugs.webkit.org/show_bug.cgi?id=195648
2384
2385         "Broke webkitpy tests with my change to
2386         lldb_dump_class_layout.py" (Requested by rmorisset on
2387         #webkit).
2388
2389         Reverted changeset:
2390
2391         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2392         classes with suspicious padding"
2393         https://bugs.webkit.org/show_bug.cgi?id=195573
2394         https://trac.webkit.org/changeset/242825
2395
2396 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2397
2398         [ews-build] Show status bubbles while the patch is waiting in queue
2399         https://bugs.webkit.org/show_bug.cgi?id=195618
2400
2401         Reviewed by Lucas Forschler.
2402
2403         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2404         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2405         enabled in initial deployment.
2406         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2407         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2408         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2409         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2410         (StatusBubble._build_bubbles_for_patch):
2411
2412 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2413
2414         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2415         https://bugs.webkit.org/show_bug.cgi?id=195573
2416
2417         Reviewed by Simon Fraser.
2418
2419         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2420
2421         * Scripts/dump-class-layout:
2422         (main):
2423         * lldb/lldb_dump_class_layout.py:
2424         (ClassLayout.__init__):
2425         (ClassLayout._compute_padding_recursive):
2426         (LLDBDebuggerInstance.dump_layout_for_classname):
2427         (LLDBDebuggerInstance):
2428         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2429         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2430
2431 2019-03-12  Chris Dumez  <cdumez@apple.com>
2432
2433         Device Orientation access permission should be denied unless explicitly granted by the client
2434         https://bugs.webkit.org/show_bug.cgi?id=195625
2435
2436         Reviewed by Youenn Fablet.
2437
2438         add API test coverage.
2439
2440         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2441         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2442         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2443         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2444         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2445         (runDeviceOrientationTest):
2446         (TEST):
2447         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2448         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2449
2450 2019-03-12  Jer Noble  <jer.noble@apple.com>
2451
2452         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2453         https://bugs.webkit.org/show_bug.cgi?id=195137
2454         <rdar://problem/48810307>
2455
2456         Reviewed by Eric Carlson.
2457
2458         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2459         (TestWebKitAPI::TEST):
2460
2461 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2462
2463         [ews-build] Change urls from uat to production
2464         https://bugs.webkit.org/show_bug.cgi?id=195566
2465
2466         Reviewed by Lucas Forschler.
2467
2468         * BuildSlaveSupport/ews-app/ews/config.py:
2469         * BuildSlaveSupport/ews-build/events.py:
2470         * BuildSlaveSupport/ews-build/steps.py:
2471
2472 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2473
2474         [ews-build] change max_builds for local-worker to 1
2475         https://bugs.webkit.org/show_bug.cgi?id=195568
2476
2477         Reviewed by Lucas Forschler.
2478
2479         * BuildSlaveSupport/ews-build/loadConfig.py:
2480
2481 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2482
2483         Fix the build
2484
2485         * TestRunnerShared/spi/PencilKitTestSPI.h:
2486         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2487
2488 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2489
2490         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2491         https://bugs.webkit.org/show_bug.cgi?id=194131
2492
2493         Reviewed by Michael Catanzaro.
2494
2495         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2496         (uriChanged):
2497         (testUnfinishedSubresourceLoad):
2498         (serverCallback):
2499         (beforeAll):
2500
2501 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2502
2503         WTF::Expected should use std::addressof instead of operator&
2504         https://bugs.webkit.org/show_bug.cgi?id=195604
2505
2506         Reviewed by Myles Maxfield.
2507
2508         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2509         (TestWebKitAPI::Unique::Unique):
2510         (TestWebKitAPI::Unique::operator&):
2511         (TestWebKitAPI::TEST):
2512
2513 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2514
2515         Add Optional to Forward.h.
2516         https://bugs.webkit.org/show_bug.cgi?id=195586
2517
2518         Reviewed by Darin Adler.
2519
2520         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2521         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2522         Remove unnecessary includes from headers.
2523
2524 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2525
2526         Add testing API to hit-test and scroll overflow scrollers
2527         https://bugs.webkit.org/show_bug.cgi?id=195278
2528
2529         Reviewed by Antti Koivisto.
2530         
2531         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2532         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2533         
2534         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2535
2536         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2537         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2538         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2539         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2540         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2541         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2542         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2543         (WTR::enclosingScrollViewIncludingSelf):
2544         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2545
2546 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2547
2548         API test WebKit.RequestTextInputContext fails on iOS
2549         https://bugs.webkit.org/show_bug.cgi?id=195585
2550
2551         Reviewed by Wenson Hsieh and Simon Fraser.
2552
2553         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2554         (applyStyle):
2555         (TEST):
2556         Add a viewport, so that the coordinates match up on iOS.
2557         Scroll by moving the UIScrollView's contentOffset.
2558
2559 2019-03-11  Chris Dumez  <cdumez@apple.com>
2560
2561         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2562         https://bugs.webkit.org/show_bug.cgi?id=195506
2563         <rdar://problem/48733477>
2564
2565         Reviewed by Alex Christensen.
2566
2567         Add API test coverage.
2568
2569         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2570
2571 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2572
2573         Adding myself to contributors.json
2574
2575         Unreviewed, addming myself to contributors.json .
2576
2577         * Scripts/webkitpy/common/config/contributors.json:
2578
2579 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2580
2581         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2582         https://bugs.webkit.org/show_bug.cgi?id=195511
2583         <rdar://problem/44873269>
2584
2585         Reviewed by Darin Adler.
2586
2587         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2588         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2589         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2590         (TEST_F):
2591
2592 2019-03-11  Chris Dumez  <cdumez@apple.com>
2593
2594         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2595         https://bugs.webkit.org/show_bug.cgi?id=195561
2596
2597         Reviewed by Youenn Fablet.
2598
2599         Make sure the JS in the test requests for permission to receive device orientation events.
2600
2601         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2602
2603 2019-03-11  Youenn Fablet  <youenn@apple.com>
2604
2605         Allow storage quota increase by default in WTR
2606         https://bugs.webkit.org/show_bug.cgi?id=195541
2607
2608         Reviewed by Geoffrey Garen.
2609
2610         Allow storage quota increase by default in WTR.
2611         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
2612         Use this for tests that explicitly need cache increase.
2613
2614         Instead of increasing quota by 2, make sure the next request is
2615         granted by adding all given parameters.
2616
2617         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2618         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2619         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2620         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
2621         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2622         * WebKitTestRunner/TestController.cpp:
2623         (WTR::TestController::setAllowStorageQuotaIncrease):
2624         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2625         * WebKitTestRunner/TestController.h:
2626         * WebKitTestRunner/TestInvocation.cpp:
2627         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2628         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2629         (WTR::TestController::cocoaResetStateToConsistentValues):
2630         (WTR::TestController::setAllowStorageQuotaIncrease):
2631         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2632         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2633         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2634
2635 2019-03-11  Xan Lopez  <xan@igalia.com>
2636
2637         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
2638         https://bugs.webkit.org/show_bug.cgi?id=194147
2639
2640         Reviewed by Michael Saboff.
2641
2642         To make --32-bit work correctly on Linux/64bit we need to:
2643
2644         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
2645         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
2646         unfortunately CMake only allows us to do this during
2647         crosscompilation, which is overkill here.
2648         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
2649         pkg-config detection module uses the x86 .pc files instead of the
2650         x86_64 ones.
2651         - Set the -m32 flags for the compiler.
2652
2653         * Scripts/webkitdirs.pm:
2654         (generateBuildSystemFromCMakeProject):
2655
2656 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
2657
2658         Add MotionMark-1.1 plan file for run-benchmark script.
2659         https://bugs.webkit.org/show_bug.cgi?id=195481
2660
2661         Rubber-stamped by Darin Adler.
2662
2663         Run-benchmark script should support MontionMark-1.1.
2664
2665         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
2666
2667 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2668
2669         [ews-app] Add support for submit-to-ews url
2670         https://bugs.webkit.org/show_bug.cgi?id=195477
2671
2672         Reviewed by Lucas Forschler.
2673
2674         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2675         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2676         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
2677         * BuildSlaveSupport/ews-app/ews/urls.py:
2678         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
2679
2680 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
2681
2682         Unreviewed, rolling out r242688, r242643, r242624.
2683
2684         Caused multiple layout test failures and crashes on iOS and macOS.
2685
2686         Reverted changeset:
2687
2688         "requestAnimationFrame should execute before the next frame"
2689         https://bugs.webkit.org/show_bug.cgi?id=177484
2690         https://trac.webkit.org/changeset/242624/webkit
2691
2692         * Tracing/SystemTracePoints.plist:
2693
2694 2019-03-11  John Wilander  <wilander@apple.com>
2695
2696         Resource Load Statistics: Make it possible exclude localhost from classification
2697         https://bugs.webkit.org/show_bug.cgi?id=195474
2698         <rdar://problem/47520577>
2699
2700         Reviewed by Brent Fulgham.
2701
2702         This patch allows for localhost to be excluded from classification and
2703         treatment as a prevalent resource.
2704
2705         The WebKit Tools change adds a new function called
2706         testRunner.setStatisticsIsRunningTest() which can be used to control this
2707         behavior.
2708
2709         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2710         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2711         (WTR::TestRunner::setStatisticsIsRunningTest):
2712         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2713         * WebKitTestRunner/TestController.cpp:
2714         (WTR::TestController::setStatisticsIsRunningTest):
2715         * WebKitTestRunner/TestController.h:
2716         * WebKitTestRunner/TestInvocation.cpp:
2717         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2718
2719 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2720
2721         [ews-build] Disable waterfall and console view for ews-build.webkit.org
2722         https://bugs.webkit.org/show_bug.cgi?id=195560
2723
2724         Reviewed by Lucas Forschler.
2725
2726         * BuildSlaveSupport/ews-build/master.cfg:
2727
2728 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2729
2730         Unreviewed, rolling out r242698.
2731
2732         API test crashes on bots.
2733
2734         Reverted changeset:
2735
2736         "Add a WKContentRuleList variant that uses copied memory
2737         instead of mmap'd shared memory for class A containerized
2738         apps"
2739         https://bugs.webkit.org/show_bug.cgi?id=195511
2740         https://trac.webkit.org/changeset/242698
2741
2742 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2743
2744         [WPE] Enable web process sandbox
2745         https://bugs.webkit.org/show_bug.cgi?id=195169
2746
2747         Reviewed by Daniel Bates.
2748
2749         * wpe/install-dependencies:
2750         * wpe/jhbuild.modules:
2751
2752 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2753
2754         [ews-app] Use port 17000 for worker communication
2755         https://bugs.webkit.org/show_bug.cgi?id=195558
2756
2757         Reviewed by Lucas Forschler.
2758
2759         * BuildSlaveSupport/ews-build/master.cfg:
2760
2761 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2762
2763         [ews-build] unit-tests fail when passwords.json is missing
2764         https://bugs.webkit.org/show_bug.cgi?id=195557
2765
2766         Reviewed by Lucas Forschler.
2767
2768         * BuildSlaveSupport/ews-build/loadConfig.py:
2769         (loadBuilderConfig):
2770         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2771         (ConfigDotJSONTest.test_configuration):
2772         * BuildSlaveSupport/ews-build/master.cfg:
2773
2774 2019-03-11  Truitt Savell  <tsavell@apple.com>
2775
2776         Unreviewed, rolling out r242702.
2777
2778         Broke High Sierra builders.
2779
2780         Reverted changeset:
2781
2782         "Add utility function to allow easy reverse range-based
2783         iteration of a container"
2784         https://bugs.webkit.org/show_bug.cgi?id=195542
2785         https://trac.webkit.org/changeset/242702
2786
2787 2019-03-11  Sam Weinig  <sam@webkit.org>
2788
2789         Add utility function to allow easy reverse range-based iteration of a container
2790         https://bugs.webkit.org/show_bug.cgi?id=195542
2791
2792         Reviewed by Antti Koivisto.
2793
2794         * TestWebKitAPI/CMakeLists.txt:
2795         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2796         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2797         (TestWebKitAPI::TEST):
2798         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2799
2800 2019-03-10  Alex Christensen  <achristensen@webkit.org>
2801
2802         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2803         https://bugs.webkit.org/show_bug.cgi?id=195511
2804         <rdar://problem/44873269>
2805
2806         Reviewed by Darin Adler.
2807
2808         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2809         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2810         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2811         (TEST_F):
2812
2813 2019-03-10  Tim Horton  <timothy_horton@apple.com>
2814
2815         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
2816         https://bugs.webkit.org/show_bug.cgi?id=195499
2817
2818         Reviewed by Darin Adler.
2819
2820         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2821         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
2822         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
2823         (-[WKWebView synchronouslyFocusTextInputContext:]):
2824         (applyStyle):
2825         (applyIframe):
2826         (TEST):
2827         Add some tests for this SPI.
2828
2829 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
2830
2831         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
2832         https://bugs.webkit.org/show_bug.cgi?id=181151
2833
2834         Reviewed by Don Olmstead.
2835
2836         * TestWebKitAPI/CMakeLists.txt:
2837         * TestWebKitAPI/PlatformWin.cmake:
2838         Enable TestWTF RunLoop tests in all platforms.
2839
2840         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
2841         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
2842         (TestWebKitAPI::DerivedOneShotTimer::fired):
2843         (TestWebKitAPI::TEST):
2844         Only a few platforms support nested RunLoop.
2845
2846         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
2847         (TestWebKitAPI::DerivedRepeatingTimer::fired):
2848
2849 2019-03-10  David Quesada  <david_quesada@apple.com>
2850
2851         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
2852         https://bugs.webkit.org/show_bug.cgi?id=152480
2853
2854         Reviewed by Chris Dumez.
2855
2856         Add a unit test based on Daniel Bates's test case that starts a download, ensures
2857         there are no additional references to the process pool besides the one held by
2858         the download, waits for the download to finish (in the sense that the
2859         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
2860         measure, also check that the process pool has been deallocated at the end of the
2861         test. The test wouldn't be meaningful if the process pool were still alive.
2862
2863         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2864         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
2865         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
2866             The download will be canceled because the delegate does not implement the
2867             method to decide the download's destination, so this is where we know the
2868             DownloadProxyMap is done with the DownloadProxy.
2869         (TEST):
2870
2871 2019-03-08  Chris Dumez  <cdumez@apple.com>
2872
2873         Add support for Device Orientation / Motion permission API
2874         https://bugs.webkit.org/show_bug.cgi?id=195329
2875         <rdar://problem/47645367>
2876
2877         Reviewed by Geoffrey Garen.
2878
2879         Add test infrastructure to help test the Device Orientation / Motion permission API.
2880
2881         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2882         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2883         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
2884         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2885         * WebKitTestRunner/TestController.cpp:
2886         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
2887         (WTR::TestController::createWebViewWithOptions):
2888         (WTR::TestController::resetStateToConsistentValues):
2889         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
2890         * WebKitTestRunner/TestController.h:
2891         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
2892         * WebKitTestRunner/TestInvocation.cpp:
2893         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2894
2895 2019-03-08  Saam barati  <sbarati@apple.com>
2896
2897         Add a compare-results script to compare benchmark results
2898         https://bugs.webkit.org/show_bug.cgi?id=195486
2899         <rdar://problem/48723397>
2900
2901         Reviewed by Geoffrey Garen.
2902
2903         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
2904         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
2905         to extend it to learn about our other benchmarks.
2906
2907         * Scripts/compare-results: Added.
2908         (readJSONFile):
2909         (detectJetStream2):
2910         (JetStream2Results):
2911         (detectSpeedometer2):
2912         (Speedometer2Results):
2913         (detectPLT5):
2914         (PLT5Results):
2915         (detectBenchmark):
2916         (biggerIsBetter):
2917         (ttest):
2918         (getOptions):
2919         (main):
2920
2921 2019-03-08  Stephanie Lewis  <slewis@apple.com>
2922
2923         Ensure old tab state is cleared between iterations of run-benchmark
2924         https://bugs.webkit.org/show_bug.cgi?id=195393
2925         <rdar://problem/46885583>
2926
2927         Reviewed by Dewei Zhu.
2928
2929         a) ensure the default to restore state is not set
2930         b) terminate Safari correctly
2931         c) Set the system default to ignore Persistent State in Safari
2932
2933         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2934         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
2935         (OSXBrowserDriver.prepare_env): 
2936         (OSXBrowserDriver.restore_env):
2937         (OSXBrowserDriver.close_browsers):
2938         (OSXBrowserDriver._terminate_processes):
2939         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
2940         (OSXChromeDriver):
2941         (OSXChromeCanaryDriver):
2942         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
2943         (OSXFirefoxDriver):
2944         (OSXFirefoxNightlyDriver):
2945         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
2946         (OSXSafariDriver):
2947         (OSXSafariDriver.prepare_env):
2948
2949 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
2950
2951         [GTK] Several InputMethodFilter tests are failing
2952         https://bugs.webkit.org/show_bug.cgi?id=195408
2953
2954         Reviewed by Carlos Garcia Campos.
2955
2956         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
2957         Regressed in r241751.
2958         Hexadecimal values of keycodes are expressed now in upper letters.
2959         Composited characters should be cast to UTF8 strings.
2960
2961         (TestWebKitAPI::TEST):
2962
2963 2019-03-07  Tomas Popela  <tpopela@redhat.com>
2964
2965         [GTK] Make Tools/gtkdoc python3 compatible
2966         https://bugs.webkit.org/show_bug.cgi?id=195359
2967
2968         Reviewed by Carlos Garcia Campos.
2969
2970         * gtkdoc/generate-gtkdoc:
2971         ConfigParser was reworked in Python 3.2 so we have adapt the code to
2972         work with Python 2 and 3.
2973         (get_gtkdoc_module_paths):
2974         The iteritems() was removed in Python 3, so let's use items() that's
2975         available in Python 2 and 3.
2976         (get_generator_for_config):
2977         * gtkdoc/gtkdoc.py:
2978         (GTKDoc._run_command):
2979         The sys.stdout.write() is expecting str in Python 3 and not bytes
2980         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
2981         for passing the bytes there.
2982
2983 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
2984
2985         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
2986         https://bugs.webkit.org/show_bug.cgi?id=195346
2987         <rdar://problem/48667048>
2988
2989         Unreviewed build fix for clang-cl.
2990
2991         * DumpRenderTree/win/DumpRenderTree.cpp:
2992         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
2993
2994 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
2995
2996         requestAnimationFrame should execute before the next frame
2997         https://bugs.webkit.org/show_bug.cgi?id=177484
2998
2999         Reviewed by Simon Fraser.
3000
3001         Add trace points for the page RenderingUpdate.
3002
3003         * Tracing/SystemTracePoints.plist:
3004
3005 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3006
3007         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3008         https://bugs.webkit.org/show_bug.cgi?id=195353
3009         <rdar://problem/48626394>
3010
3011         Reviewed by Simon Fraser.
3012
3013         * WebKitTestRunner/ios/TestControllerIOS.mm:
3014         (WTR::TestController::platformResetPreferencesToConsistentValues):
3015
3016 2019-03-07  John Wilander  <wilander@apple.com>
3017
3018         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3019         https://bugs.webkit.org/show_bug.cgi?id=195383
3020         <rdar://problem/48570136>
3021
3022         Reviewed by Brent Fulgham.
3023
3024         This patch adds test infrastructure to purge only script-accessible cookies,
3025         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3026
3027         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3028         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3029         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3030         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3031         * WebKitTestRunner/TestController.cpp:
3032         (WTR::TestController::statisticsDeleteCookiesForHost):
3033         * WebKitTestRunner/TestController.h:
3034         * WebKitTestRunner/TestInvocation.cpp:
3035         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3036
3037 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3038
3039         Unreviewed, rolling out r242354.
3040         https://bugs.webkit.org/show_bug.cgi?id=195402
3041
3042         breaks layout tests in all configurations (Requested by
3043         zdobersek on #webkit).
3044
3045         Reverted changeset:
3046
3047         "[WPE] Enable web process sandbox"
3048         https://bugs.webkit.org/show_bug.cgi?id=195169
3049         https://trac.webkit.org/changeset/242354
3050
3051 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3052
3053         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3054         https://bugs.webkit.org/show_bug.cgi?id=195346
3055
3056         Reviewed by Fujii Hironori.
3057
3058         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3059         (TestWebKitAPI::TEST):
3060         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3061
3062         * DumpRenderTree/win/DumpRenderTree.cpp:
3063         (findFontFallback):
3064         (addFontFallbackIfPresent):
3065         (removeFontFallbackIfPresent):
3066         (main):
3067         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3068         (TestWebKitAPI::Util::moduleDirectory):
3069         (TestWebKitAPI::Util::createInjectedBundlePath):
3070         Use wchar helpers as needed.
3071
3072 2019-03-06  Rob Buis  <rbuis@igalia.com>
3073
3074         Consider supporting the `referrerpolicy` attribute.
3075         https://bugs.webkit.org/show_bug.cgi?id=179053
3076
3077         Reviewed by Darin Adler.
3078
3079         Add a runtime flag for referrerpolicy attribute.
3080
3081         * DumpRenderTree/mac/DumpRenderTree.mm:
3082         (enableExperimentalFeatures):
3083
3084 2019-03-05  Daniel Bates  <dabates@apple.com>
3085
3086         Update expected API test result following r242379
3087         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3088
3089         Update expected x-coordinate of selection rect now that the left padding of
3090         a textarea is sized in ems (so dependent on the font size) just like the left
3091         padding of a text field.
3092
3093         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3094         (TestWebKitAPI::TEST):
3095
3096 2019-03-05  David Quesada  <david_quesada@apple.com>
3097
3098         [WK2] It should be possible to follow links with 'download' attributes
3099         https://bugs.webkit.org/show_bug.cgi?id=195145
3100         rdar://problem/48462642
3101
3102         Reviewed by Alex Christensen.
3103
3104         Add a unit test to verify that activating links with 'download' attributes now
3105         navigates to the linked resource, rather than starts downloading it. Add another
3106         to verify that it is still possible to explicitly download the link via the
3107         'Download' navigation action policy.
3108
3109         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3110         (-[DownloadAttributeTestDelegate init]):
3111         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3112         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3113         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3114         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3115         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3116         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3117         (TEST):
3118         * WebKitTestRunner/TestController.cpp:
3119         (WTR::TestController::decidePolicyForNavigationAction):
3120         * WebKitTestRunner/TestController.h:
3121
3122 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3123
3124         [Curl] Implement Cookie Accept Policy.
3125         https://bugs.webkit.org/show_bug.cgi?id=191645
3126
3127         Reviewed by Fujii Hironori.
3128
3129         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3130         (TestWebKitAPI::Curl::TEST_F):
3131
3132 2019-03-05  Youenn Fablet  <youenn@apple.com>
3133
3134         Rename requestCacheStorageSpace to requestStorageSpace
3135         https://bugs.webkit.org/show_bug.cgi?id=195282
3136
3137         Reviewed by Chris Dumez.
3138
3139         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3140         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3141         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3142
3143 2019-03-05  Brady Eidson  <beidson@apple.com>
3144
3145         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3146         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3147
3148         Reviewed by Tim Horton.
3149
3150         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3151         different directory into that same WKWebView should work.
3152
3153         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3154         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3155
3156 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3157
3158         Add WeakHashSet
3159         https://bugs.webkit.org/show_bug.cgi?id=195152
3160
3161         Reviewed by Antti Koivisto.
3162
3163         Added tests for WeakHashSet.
3164
3165         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3166         (TestWebKitAPI::Base::Base): Moved.
3167         (TestWebKitAPI::Derived::foo): Moved.
3168         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3169         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3170         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3171         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3172
3173 2019-03-04  Chris Dumez  <cdumez@apple.com>
3174
3175         Do not share WebProcesses between private and regular sessions
3176         https://bugs.webkit.org/show_bug.cgi?id=195189
3177         <rdar://problem/48421064>
3178
3179         Reviewed by Alex Christensen.
3180
3181         Add API test coverage.
3182
3183         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3184         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3185
3186 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3187
3188         [WPE] Enable web process sandbox
3189         https://bugs.webkit.org/show_bug.cgi?id=195169
3190
3191         Reviewed by Daniel Bates.
3192
3193         * wpe/install-dependencies:
3194         * wpe/jhbuild.modules:
3195
3196 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3197
3198         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3199         https://bugs.webkit.org/show_bug.cgi?id=195206
3200
3201         Reviewed by Žan Doberšek.
3202
3203         Add a new test case.
3204
3205         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3206         (testJSCClass):
3207
3208 2019-03-04  Charlie Turner  <cturner@igalia.com>
3209
3210         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3211         https://bugs.webkit.org/show_bug.cgi?id=194898
3212
3213         Reviewed by Žan Doberšek.
3214
3215         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3216         a GCC extension that permits arithmetic on void* pointer. Inline
3217         the macro until this issue is fixed upstream.
3218
3219 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3220
3221         Rid the world of WK_API_ENABLED
3222         https://bugs.webkit.org/show_bug.cgi?id=195263
3223
3224         Reviewed by Dan Bernstein.
3225
3226         List of changed files elided because it's useless.
3227
3228 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3229
3230         Unreviewed follow-up to r242292.
3231
3232         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3233
3234         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3235         (TestWebKitAPI::testStrip): Renamed from strip.
3236         (TestWebKitAPI::TEST):
3237
3238 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3239
3240         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3241
3242         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3243         and bug #194272 for details.
3244
3245         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3246
3247 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3248
3249         Remove some more unused 32-bit code
3250         https://bugs.webkit.org/show_bug.cgi?id=195255
3251
3252         Reviewed by Darin Adler.
3253
3254         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3255         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3256         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3257         (NPP_New):
3258         (NPP_HandleEvent):
3259         (handleEventCarbon): Deleted.
3260
3261 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3262
3263         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3264
3265         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3266         (TestWebKitAPI::TEST):
3267
3268 2019-03-01  Darin Adler  <darin@apple.com>
3269
3270         Finish removing String::format
3271         https://bugs.webkit.org/show_bug.cgi?id=194893
3272
3273         Reviewed by Daniel Bates.
3274 '
3275         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3276
3277 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3278
3279         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3280         https://bugs.webkit.org/show_bug.cgi?id=195229
3281         <rdar://problem/48520362>
3282
3283         Reviewed by Chris Dumez.
3284
3285         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3286         (TEST):
3287
3288 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3289
3290         Add a system trace scope for event region building
3291         https://bugs.webkit.org/show_bug.cgi?id=195226
3292
3293         Reviewed by Jon Lee.
3294
3295         This trace scope measures the time spend converting element rects into Region objects,
3296         which can be large on some pages.
3297
3298         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3299
3300         * Tracing/SystemTracePoints.plist:
3301
3302 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3303
3304         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3305         https://bugs.webkit.org/show_bug.cgi?id=194612
3306
3307         Reviewed by Alex Christensen.
3308
3309         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3310         Just test the new string-processing function and don't touch the actual environment.
3311         (Test cases are all as before, but based on operator== instead of strcmp.)
3312
3313 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3314
3315         [ews-app] Update primary keys for handling multiple Buildbot instances
3316         https://bugs.webkit.org/show_bug.cgi?id=195120
3317
3318         Reviewed by Stephanie Lewis.
3319
3320         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3321         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3322         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3323
3324         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3325         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3326         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3327         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3328         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3329         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3330
3331 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3332
3333         [WinCairo] Enable service worker
3334         https://bugs.webkit.org/show_bug.cgi?id=188318
3335
3336         Reviewed by Youenn Fablet.
3337
3338         * DumpRenderTree/DumpRenderTreePrefix.h:
3339         * TestWebKitAPI/PlatformWin.cmake:
3340         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3341         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3342         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3343
3344 2019-03-01  Justin Fan  <justin_fan@apple.com>
3345
3346         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3347         https://bugs.webkit.org/show_bug.cgi?id=195191
3348
3349         Rubber-stamped by Dean Jackson.
3350
3351         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3352
3353         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3354
3355 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3356
3357         Unreviewed, fix lldb webkitpy tests
3358         https://bugs.webkit.org/show_bug.cgi?id=194375
3359
3360         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3361
3362         * lldb/lldb_webkit.py:
3363         (WTFStringImplProvider.is_8bit):
3364
3365 2019-02-28  David Quesada  <david_quesada@apple.com>
3366
3367         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3368         https://bugs.webkit.org/show_bug.cgi?id=195121
3369         rdar://problem/48450302
3370
3371         Reviewed by Alex Christensen.
3372
3373         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3374         configurations where the 'download' attribute is absent, blank, or populated
3375         with a filename, and where the anchor element is same-origin or cross-origin
3376         (meaning the 'download' attribute shouldn't be honored).
3377
3378         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3379         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3380         (-[NavigationActionTestDelegate init]):
3381         (-[NavigationActionTestDelegate navigationAction]):
3382         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3383         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3384         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3385         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3386         (TEST):
3387
3388 2019-02-28  Antoine Quint  <graouts@apple.com>
3389
3390         Enable the Pointer Events runtime flag by default
3391         https://bugs.webkit.org/show_bug.cgi?id=195156
3392
3393         Reviewed by Dean Jackson.
3394
3395         * DumpRenderTree/mac/DumpRenderTree.mm:
3396         (enableExperimentalFeatures):
3397
3398 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3399
3400         Several PasteImage API tests are flaky
3401         https://bugs.webkit.org/show_bug.cgi?id=195160
3402
3403         Reviewed by Tim Horton.
3404
3405         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3406         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3407         listening for a "load" event after image load is already complete.
3408
3409         To address this, make these tests first register a "load" event handler, then run script to insert an image
3410         element into the document, and finally wait until the load event is observed before checking image size.
3411
3412         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3413
3414 2019-02-28  Chris Dumez  <cdumez@apple.com>
3415
3416         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3417         https://bugs.webkit.org/show_bug.cgi?id=195107
3418
3419         Reviewed by Alex Christensen.
3420
3421         Give some time for the zoom level to get restored.
3422
3423         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3424
3425 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3426
3427         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3428         https://bugs.webkit.org/show_bug.cgi?id=194958
3429
3430         Reviewed by Geoffrey Garen.
3431
3432         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3433         (TEST):
3434
3435 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3436
3437         [ews-app] Update method to save build to handle builder_display_name
3438         https://bugs.webkit.org/show_bug.cgi?id=195047
3439
3440         Reviewed by Dewei Zhu.
3441
3442         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3443         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3444
3445 2019-02-28  Justin Fan  <justin_fan@apple.com>
3446
3447         [Web GPU] Enable Web GPU only on 64-bit
3448         https://bugs.webkit.org/show_bug.cgi?id=195139
3449
3450         Because Metal is only supported on 64 bit apps.
3451
3452         Unreviewed build fix.
3453
3454         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3455
3456 2019-02-27  Youenn Fablet  <youenn@apple.com>
3457
3458         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3459         https://bugs.webkit.org/show_bug.cgi?id=194959
3460
3461         Reviewed by Chris Dumez.
3462
3463         Spin loop until getting the condition to remove flakiness.
3464
3465         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3466
3467 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3468
3469         [ews-build] Buildbot should include builder_display_name in the build events
3470         https://bugs.webkit.org/show_bug.cgi?id=195045
3471
3472         Reviewed by Dewei Zhu.
3473
3474         * BuildSlaveSupport/ews-build/events.py:
3475         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3476         buildername to builder_name to be consistent in naming style.
3477         (Events.buildFinished): Ditto.
3478
3479 2019-02-27  Chris Dumez  <cdumez@apple.com>
3480
3481         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3482         https://bugs.webkit.org/show_bug.cgi?id=194480
3483
3484         Reviewed by Brady Eidson.
3485
3486         Update existing API test to make it more likely to reproduce the issue.
3487
3488         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3489
3490 2019-02-27  Brady Eidson  <beidson@apple.com>
3491
3492         Universal links from Google search results pages don't open the app.
3493         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3494
3495         Reviewed by Geoffrey Garen.
3496
3497         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3498         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3499         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3500         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3501
3502 2019-02-27  Chris Dumez  <cdumez@apple.com>
3503
3504         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3505         https://bugs.webkit.org/show_bug.cgi?id=195102
3506
3507         Reviewed by Geoffrey Garen.
3508
3509         If the number of processes is not yet what we expect, wait a bit and check again to give
3510         processes some time to exit.
3511
3512         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3513
3514 2019-02-27  Chris Dumez  <cdumez@apple.com>
3515
3516         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3517         https://bugs.webkit.org/show_bug.cgi?id=194545
3518
3519         Reviewed by Brady Eidson.
3520
3521         Make sure the test navigates forward and then back only once. Previously, navigating
3522         back would trigger a navigation again in a timer.
3523
3524         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3525
3526 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3527
3528         High Sierra Debug JSC test queue should use faster hardware
3529         https://bugs.webkit.org/show_bug.cgi?id=194603
3530
3531         Rubber-stamped by Alexey Proskuryakov.
3532
3533         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3534
3535         * BuildSlaveSupport/build.webkit.org-config/config.json:
3536         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3537         (BubbleQueueServer):
3538         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3539         (WebKitBuildbot):
3540         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3541         * QueueStatusServer/config/queues.py:
3542         * Scripts/webkitpy/common/config/ews.json:
3543         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3544         (test_ews_name):
3545
3546 2019-02-27  John Wilander  <wilander@apple.com>
3547
3548         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3549         https://bugs.webkit.org/show_bug.cgi?id=195071
3550         <rdar://problem/48417690>
3551
3552         Reviewed by Alex Christensen and Brent Fulgham.
3553
3554         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3555         (TestWebKitAPI::createURL):
3556             Convenience function.
3557         (TestWebKitAPI::TEST):
3558             WebCore::AdClickAttribution now takes a URL when creating Source and
3559             Destination.
3560         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3561         (TestWebKitAPI::TEST):
3562             WebCore::AdClickAttribution now takes a URL when creating Source and
3563             Destination.
3564
3565 2019-02-27  Antoine Quint  <graouts@apple.com>
3566
3567         Support Pointer Events on macOS
3568         https://bugs.webkit.org/show_bug.cgi?id=195008
3569         <rdar://problem/47454419>
3570
3571         Reviewed by Dean Jackson.
3572
3573         * DumpRenderTree/mac/DumpRenderTree.mm:
3574         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3575         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3576
3577 2019-02-26  Mark Lam  <mark.lam@apple.com>
3578
3579         Remove remaining poisoning code.
3580         https://bugs.webkit.org/show_bug.cgi?id=194138
3581
3582         Reviewed by Saam Barati.
3583
3584         * TestWebKitAPI/CMakeLists.txt:
3585         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3586         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
3587         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
3588         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
3589         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
3590         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
3591         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
3592
3593 2019-02-26  Alex Christensen  <achristensen@webkit.org>
3594
3595         Move ephemeral local storage from WebProcess to UIProcess
3596         https://bugs.webkit.org/show_bug.cgi?id=195074
3597         <rdar://problem/47937975>
3598
3599         Reviewed by Geoff Garen.
3600
3601         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3602
3603 2019-02-20  Jer Noble  <jer.noble@apple.com>
3604
3605         [Cocoa] Media elements will restart network buffering just before suspending
3606         https://bugs.webkit.org/show_bug.cgi?id=193691
3607
3608         Reviewed by Eric Carlson.
3609
3610         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3611         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3612         (TEST):
3613
3614 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
3615
3616         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
3617         https://bugs.webkit.org/show_bug.cgi?id=191652
3618
3619         Reviewed by Alex Christensen.
3620
3621         Fix WinCairo MiniBrowser behavior of authentication dialog.
3622
3623         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3624         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3625
3626 2019-02-26  Youenn Fablet  <youenn@apple.com>
3627
3628         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
3629         https://bugs.webkit.org/show_bug.cgi?id=195028
3630         <rdar://problem/48243733>
3631
3632         Reviewed by Eric Carlson.
3633
3634         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3635
3636 2019-02-26  Philippe Normand  <pnormand@igalia.com>
3637
3638         [WPE] Add API for webview background color configuration
3639         https://bugs.webkit.org/show_bug.cgi?id=192305
3640
3641         Reviewed by Michael Catanzaro.
3642
3643         * MiniBrowser/wpe/main.cpp:
3644         (main): Add a new option to configure the webview background
3645         color. Example: --bg-color=transparent.
3646         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3647         (testWebViewBackgroundColor): Enable background color API tests for WPE.
3648         (beforeAll): Ditto.
3649
3650 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
3651
3652         scalableNativeWebpageParameters() is not preserved on new page navigation.
3653         https://bugs.webkit.org/show_bug.cgi?id=194892
3654         <rdar://problem/47538280>
3655
3656         Reviewed by Wenson Hsieh.
3657         
3658         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
3659
3660         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3661         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3662         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3663         (WTR::UIScriptController::allowsViewportShrinkToFit):
3664         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3665         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3666         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3667         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3668         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3669         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3670
3671 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3672
3673         [ews-app] Add model for handling multiple Buildbot instances
3674         https://bugs.webkit.org/show_bug.cgi?id=194863
3675
3676         Reviewed by Stephanie Lewis.
3677
3678         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
3679
3680 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3681
3682         [ews-app] Remove BuilderMapping table
3683         https://bugs.webkit.org/show_bug.cgi?id=194961
3684
3685         Reviewed by Stephanie Lewis.
3686
3687         Store builder name directly in build table, instead of having a separate
3688         table for it.
3689
3690         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
3691         * BuildSlaveSupport/ews-app/ews/models/build.py:
3692         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
3693         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3694
3695 2019-02-25  John Wilander  <wilander@apple.com>
3696
3697         Introduce and adopt new class RegistrableDomain for eTLD+1
3698         https://bugs.webkit.org/show_bug.cgi?id=194791
3699         <rdar://problem/48179240>
3700
3701         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
3702
3703         This patch ad