REGRESSION(r215686): O(n^2) algorithm in CachedRawResource::addDataBuffer
[WebKit-https.git] / Tools / ChangeLog
1 2017-05-20  Alex Christensen  <achristensen@webkit.org>
2
3         REGRESSION(r215686): O(n^2) algorithm in CachedRawResource::addDataBuffer
4         https://bugs.webkit.org/show_bug.cgi?id=172406
5         <rdar://32109532>
6
7         Reviewed by Brady Eidson.
8
9         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
10         (TestWebKitAPI::checkBuffer):
11         (TestWebKitAPI::TEST_F):
12
13 2017-05-22  Jason Marcell  <jmarcell@apple.com>
14
15         Do not enter Subversion-specific logic when parsing Git-based Trac data.
16         https://bugs.webkit.org/show_bug.cgi?id=172433
17         <rdar://problem/32234188>
18
19         Reviewed by Alexey Proskuryakov.
20
21         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
22         (Trac.prototype._convertCommitInfoElementToObject):
23
24 2017-05-22  Tim Horton  <timothy_horton@apple.com>
25
26         ExplicitSnapshotsChangeUponNavigation API test often fails
27         https://bugs.webkit.org/show_bug.cgi?id=172475
28         <rdar://problem/31688322>
29
30         Reviewed by Simon Fraser.
31
32         * TestWebKitAPI/cocoa/TestWKWebView.mm:
33         (-[TestWKWebView _setUpTestWindow:]):
34         Make TestWKWebView's window layer-backed. This is now the default,
35         and it's also easy to accidentally write a test that depends on it
36         (for example, ExplicitSnapshotsChangeUponNavigation adds an NSBox,
37         which becomes layer backed, just like the WKWebView, but with no
38         common layer-backed ancestor).
39
40 2017-05-22  youenn fablet  <youenn@apple.com>
41
42         Resync web-platform-tests up to 8df7c9c215678328212f232ce0b5270c505a8563
43         https://bugs.webkit.org/show_bug.cgi?id=172426
44
45         Reviewed by Chris Dumez.
46
47         * Scripts/webkitpy/w3c/test_importer.py:
48         (TestImporter.remove_deleted_files): Outputting warning when trying to delete a file that no longer exists.
49
50 2017-05-22  Konstantin Tokarev  <annulen@yandex.ru>
51
52         Unreviewed, change my status to reviewer and fill "expertise" field
53
54         * Scripts/webkitpy/common/config/contributors.json:
55
56 2017-05-22  Tomas Popela  <tpopela@redhat.com>
57
58         Remove some of the EFL port leftovers
59         https://bugs.webkit.org/show_bug.cgi?id=172440
60
61         Reviewed by Carlos Garcia Campos.
62
63         * BuildSlaveSupport/built-product-archive:
64         (archiveBuiltProduct):
65         (extractBuiltProduct):
66         * BuildSlaveSupport/test-result-archive:
67         (archiveTestResults):
68         * ImageDiff/PlatformEfl.cmake: Removed.
69         * Scripts/run-efl-tests: Removed.
70         * Scripts/webkit-build-directory:
71         * Scripts/webkitpy/common/config/contributionareas.py:
72         * Scripts/webkitpy/common/config/watchlist:
73         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
74         (parse_args):
75         (_set_up_derived_options):
76         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
77         (PerfTestsRunner.__init__):
78         * Scripts/webkitpy/style/checker.py:
79         * Scripts/webkitpy/style/checker_unittest.py:
80         (GlobalVariablesTest.test_path_rules_specifier):
81         * gtk/manifest.txt.in:
82         * jhbuild/jhbuild-wrapper:
83
84 2017-05-22  Carlos Garcia Campos  <cgarcia@igalia.com>
85
86         Unreviewed. Do not include WPE files in GTK+ tarballs.
87
88         * gtk/manifest.txt.in:
89
90 2017-05-22  Carlos Garcia Campos  <cgarcia@igalia.com>
91
92         [GTK] Add webkit_context_menu_item_new_from_gaction
93         https://bugs.webkit.org/show_bug.cgi?id=159631
94
95         Reviewed by Michael Catanzaro.
96
97         Update context menu tests to check the new GAction API.
98
99         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
100         (testContextMenuPopulateMenu):
101
102 2017-05-21  Michael Catanzaro  <mcatanzaro@igalia.com>
103
104         [GTK] Remove Firefox user agent quirk for Google domains
105         https://bugs.webkit.org/show_bug.cgi?id=171941
106
107         Reviewed by Carlos Garcia Campos.
108
109         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
110         (TestWebKitAPI::TEST):
111         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk): Deleted.
112
113 2017-05-20  Ting-Wei Lan  <lantw44@gmail.com>
114
115         [GTK] gtkdoc-fixxref needs --module argument to work
116         https://bugs.webkit.org/show_bug.cgi?id=172415
117
118         Reviewed by Michael Catanzaro.
119
120         * gtk/gtkdoc.py:
121         (GTKDoc._run_gtkdoc_fixxref):
122
123 2017-05-20  Alexey Proskuryakov  <ap@apple.com>
124
125         make-new-script-test should create tests that use js-test.js, not js-test-pre.js
126         https://bugs.webkit.org/show_bug.cgi?id=172416
127
128         Reviewed by Daniel Bates.
129
130         * Scripts/make-new-script-test:
131
132 2017-05-19  Fujii Hironori  <Hironori.Fujii@sony.com>
133
134         [Win] error LNK2005: WebCore::JSNode::checkSubClassPatchpoint() already defined in WebKit.lib
135         https://bugs.webkit.org/show_bug.cgi?id=172267
136
137         Reviewed by Per Arne Vollan.
138
139         TestWebCoreLib and TestWebKitLib have linked both WebCore and WebKit.
140         TestWebCoreLib should link only with WebCore. And, TestWebKitLib
141         should link only with WebKit.
142
143         Unfortunately, there is a layer violation at the moment.
144         WebCore::Image::loadPlatformResource needs loadResourceIntoBuffer
145         in WebKit. This change contains a stub of loadResourceIntoBuffer
146         in TestWebCoreLib for the workaround.
147
148         * TestWebKitAPI/PlatformWin.cmake: Do not link WebKit to
149         TestWebCoreLib. Do not link WebCore to TestWebKitLib.
150         * TestWebKitAPI/win/TestWebCoreStubs.cpp: Added.
151         (loadResourceIntoBuffer): Added a stub.
152
153 2017-05-19  Simon Fraser  <simon.fraser@apple.com>
154
155         Fix dump-class-layout to handle different file architectures
156         https://bugs.webkit.org/show_bug.cgi?id=172392
157
158         Reviewed by Zalan Bujtas.
159
160         Instead of using lldb.LLDB_ARCH_DEFAULT by default, run 'file' on the binary
161         and use the first architecture reported. Also add a "--architecture" argument
162         to allow the user to specify an architecture.
163
164         * Scripts/dump-class-layout:
165         (import_lldb):
166         (verify_type_recursive):
167         (get_first_file_architecture):
168         (dump_class):
169         (main):
170         (find_build_directory): Deleted.
171
172 2017-05-19  Jonathan Bedard  <jbedard@apple.com>
173
174         Unreviewed infrastructure fix.
175
176         * Scripts/webkitpy/port/ios_simulator.py:
177         (IOSSimulatorPort._create_devices): Ignore failure to open Simulator.app.
178
179 2017-05-19  Jonathan Bedard  <jbedard@apple.com>
180
181         webkitpy: Use simctl boot to run multiple simulators at once
182         https://bugs.webkit.org/show_bug.cgi?id=172374
183
184         Reviewed by Alexey Proskuryakov.
185
186         * Scripts/webkitpy/common/system/platforminfo.py:
187         (PlatformInfo.xcode_version): Return the current version of Xcode.
188         * Scripts/webkitpy/common/system/platforminfo_mock.py:
189         (MockPlatformInfo.xcode_version): Return version 8.0 for testing.
190         * Scripts/webkitpy/port/ios_simulator.py:
191         (IOSSimulatorPort.use_multiple_simulator_apps): Return true if we need to
192         run multiple Simulator.app instances.
193         (IOSSimulatorPort._create_simulators): Only copy the simulator app for older
194         versions of Xcode.
195         (IOSSimulatorPort._create_devices): Use 'simctl boot' directly unless using
196         an older version of Xcode.
197
198 2017-05-19  Wenson Hsieh  <wenson_hsieh@apple.com>
199
200         Unreviewed, fix the build on the latest internal SDK.
201
202         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
203         (TestWebKitAPI::TEST):
204
205 2017-05-19  Filip Pizlo  <fpizlo@apple.com>
206
207         arrayProtoPrivateFuncConcatMemcpy needs to be down with firstArray being undecided
208         https://bugs.webkit.org/show_bug.cgi?id=172369
209
210         Reviewed by Mark Lam.
211         
212         Because I wrote a test that relies on the NoCJIT config scribbling free cells, I thought it
213         would be a good idea to write this down.
214
215         * Scripts/run-jsc-stress-tests:
216
217 2017-05-19  Jonathan Bedard  <jbedard@apple.com>
218
219         webkitpy: Layout tests which have no output will succeed
220         https://bugs.webkit.org/show_bug.cgi?id=172322
221         <rdar://problem/32258350>
222
223         Reviewed by David Kilzer.
224
225         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
226         (SingleTestRunner._compare_text): Add FailreNotTested to failures if test has no output.
227         * Scripts/webkitpy/layout_tests/models/test_failures.py:
228         (determine_result_type): FailureNotTested means that the test could not be loaded. This
229         is classified as a MISSING failure.
230         (FailureNotTested): Added.
231         (FailureNotTested.message):
232
233 2017-05-19  Yusuke Suzuki  <utatane.tea@gmail.com>
234
235         Add SixSpeed benchmark to PerformanceTests
236         https://bugs.webkit.org/show_bug.cgi?id=172326
237
238         Reviewed by Sam Weinig.
239
240         * Scripts/run-jsc-benchmarks:
241
242 2017-05-19  Wenson Hsieh  <wenson_hsieh@apple.com>
243
244         [WK1] MiniBrowser should navigate when handling a dropped URL
245         https://bugs.webkit.org/show_bug.cgi?id=172350
246
247         Reviewed by Tim Horton.
248
249         Allow all drop actions, including URL navigation, for WebKit1 MiniBrowser.
250
251         * MiniBrowser/mac/WK1BrowserWindowController.m:
252         (-[WK1BrowserWindowController webView:dragDestinationActionMaskForDraggingInfo:]):
253
254 2017-05-18  Ryosuke Niwa  <rniwa@webkit.org>
255
256         REGRESSION (r216694 - 216712): Performance test Speedometer/Full.html is failing
257         https://bugs.webkit.org/show_bug.cgi?id=172077
258
259         Reviewed by Chris Dumez.
260
261         Fixed perftest.py by updating the lines to ignore in Speedometer.
262
263         Also start report the results as "Speedometer" instead of "DoYouEvenBench/Full.html" to perf.webkit.org.
264
265         * Scripts/webkitpy/performance_tests/perftest.py:
266         (PerfTest._lines_to_ignore_in_parser_result): Updated for Speedometer 2.0.
267         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
268         (PerfTestsRunner._collect_tests): Use "Speedometer" instead of "Speedometer/index.html" as the test name.
269         (_generate_results_dict): Removed the workaround to keep reporting Speedometer as DoYouEvenBench.
270         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
271         (MainTest.test_collect_tests_with_index_html_and_resources): Added.
272
273 2017-05-18  Andy Estes  <aestes@apple.com>
274
275         ENABLE(APPLE_PAY_DELEGATE) should be NO on macOS Sierra and earlier
276         https://bugs.webkit.org/show_bug.cgi?id=172305
277
278         Reviewed by Anders Carlsson.
279
280         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
281
282 2017-05-18  Wenson Hsieh  <wenson_hsieh@apple.com>
283
284         Selection around attachment elements should not persist when beginning a drag
285         https://bugs.webkit.org/show_bug.cgi?id=172319
286         <rdar://problem/32283008>
287
288         Reviewed by Tim Horton.
289
290         Tests that temporary selection around an attachment does not persist longer than it needs to.
291
292         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
293         (TestWebKitAPI::TEST):
294
295 2017-05-18  John Wilander  <wilander@apple.com>
296
297         Resource Load Statistics: Grandfather domains for existing data records
298         https://bugs.webkit.org/show_bug.cgi?id=172155
299         <rdar://problem/24913532>
300
301         Reviewed by Alex Christensen.
302
303         Adds test infrastructure needed for the added functionality.
304
305         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
306         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
307         (WTR::InjectedBundle::didReceiveMessageToPage):
308         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
309         (WTR::TestRunner::setStatisticsGrandfathered):
310         (WTR::TestRunner::isStatisticsGrandfathered):
311         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
312         (WTR::TestRunner::statisticsDidScanDataRecordsCallback):
313         (WTR::TestRunner::setStatisticsGrandfatheringTime):
314         * WebKitTestRunner/InjectedBundle/TestRunner.h:
315         * WebKitTestRunner/TestController.cpp:
316         (WTR::TestController::setStatisticsGrandfathered):
317         (WTR::TestController::isStatisticsGrandfathered):
318         (WTR::TestController::setStatisticsGrandfatheringTime):
319         * WebKitTestRunner/TestController.h:
320         * WebKitTestRunner/TestInvocation.cpp:
321         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
322
323 2017-05-18  Saam Barati  <sbarati@apple.com>
324
325         WebAssembly: perform stack checks
326         https://bugs.webkit.org/show_bug.cgi?id=165546
327         <rdar://problem/29760307>
328
329         Reviewed by Filip Pizlo.
330
331         Add some new testing modes for using and not using fast TLS wasm contexts.
332
333         * Scripts/run-jsc-stress-tests:
334
335 2017-05-18  Daniel Bates  <dabates@apple.com>
336
337         REGRESSION (r209608): Cross-origin plugin document opened in child window blocked by parent
338         window CSP when object-src 'none' is set
339         https://bugs.webkit.org/show_bug.cgi?id=172038
340         <rdar://problem/32258262>
341
342         Reviewed by Andy Estes.
343
344         Teach the test Netscape plugin to look for a URL that contains plugin-document-alert-and-notify-done.pl.
345         When it sees this URL it will show a JavaScript alert and call testRunner.notifyDone().
346
347         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
348         (NPP_New):
349
350 2017-05-18  Per Arne Vollan  <pvollan@apple.com>
351
352         [Win] Many layout tests are failing.
353         https://bugs.webkit.org/show_bug.cgi?id=172286
354
355         Reviewed by Brent Fulgham.
356
357         Add a FIXME comment about unimplemented functions, instead of writing this to the test result file.
358  
359         * DumpRenderTree/win/TestRunnerWin.cpp:
360         (TestRunner::grantWebNotificationPermission):
361         (TestRunner::denyWebNotificationPermission):
362         (TestRunner::removeAllWebNotificationPermissions):
363         (TestRunner::simulateWebNotificationClick):
364
365 2017-05-18  Don Olmstead  <don.olmstead@am.sony.com>
366
367         [Win] Remove usage of _snprintf
368         https://bugs.webkit.org/show_bug.cgi?id=172251
369
370         Reviewed by Per Arne Vollan.
371
372         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
373         * MiniBrowser/win/PageLoadTestClient.cpp:
374         (PageLoadTestClient::dumpRunStatistics):
375
376 2017-05-17  Ryan Haddad  <ryanhaddad@apple.com>
377
378         Unreviewed, rolling out r217014.
379
380         This change caused mac-wk2 LayoutTests to exit early due to
381         crashes.
382
383         Reverted changeset:
384
385         "Resource Load Statistics: Grandfather domains for existing
386         data records"
387         https://bugs.webkit.org/show_bug.cgi?id=172155
388         http://trac.webkit.org/changeset/217014
389
390 2017-05-17  John Wilander  <wilander@apple.com>
391
392         Resource Load Statistics: Grandfather domains for existing data records
393         https://bugs.webkit.org/show_bug.cgi?id=172155
394         <rdar://problem/24913532>
395
396         Reviewed by Alex Christensen.
397
398         Adds test infrastructure needed for the added functionality.
399
400         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
401         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
402         (WTR::InjectedBundle::didReceiveMessageToPage):
403         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
404         (WTR::TestRunner::setStatisticsGrandfathered):
405         (WTR::TestRunner::isStatisticsGrandfathered):
406         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
407         (WTR::TestRunner::statisticsDidScanDataRecordsCallback):
408         (WTR::TestRunner::setStatisticsGrandfatheringTime):
409         * WebKitTestRunner/InjectedBundle/TestRunner.h:
410         * WebKitTestRunner/TestController.cpp:
411         (WTR::TestController::setStatisticsGrandfathered):
412         (WTR::TestController::isStatisticsGrandfathered):
413         (WTR::TestController::setStatisticsGrandfatheringTime):
414         * WebKitTestRunner/TestController.h:
415         * WebKitTestRunner/TestInvocation.cpp:
416         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
417
418 2017-05-17  Alex Christensen  <achristensen@webkit.org>
419
420         Fix ios-simulator API test after r216977
421         https://bugs.webkit.org/show_bug.cgi?id=171987
422
423         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
424         (TEST):
425         <rdar://problem/32260156> covers the investigation of this, but fixing it is 
426         not as urgent as having the rest of this working. Notably the ephemeral part of the
427         test works, so something is just wrong with the persistent part.
428
429 2017-05-17  Ryan Haddad  <ryanhaddad@apple.com>
430
431         Unreviewed, rolling out r216955.
432
433         This change caused strange behavior with web-platform-tests
434         locally and on EWS.
435
436         Reverted changeset:
437
438         "webkitpy: Start servers before setting-up for testing"
439         https://bugs.webkit.org/show_bug.cgi?id=172176
440         http://trac.webkit.org/changeset/216955
441
442 2017-05-17  Wenson Hsieh  <wenson_hsieh@apple.com>
443
444         A URL type is vended for a non-URL plain text string when starting data interaction
445         https://bugs.webkit.org/show_bug.cgi?id=172228
446         <rdar://problem/32166729>
447
448         Reviewed by Andy Estes.
449
450         Adds two new data interaction tests, SinglePlainTextWordTypeIdentifiers and SinglePlainTextURLTypeIdentifiers,
451         to verify that a URL UTI is not vended when beginning a data interaction on a single word, but that a URL is
452         still vended when beginning data interaction on something that resembles a link.
453
454         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
455
456 2017-05-17  David Kilzer  <ddkilzer@apple.com>
457
458         BlobDataFileReference::generateReplacementFile() should use mkstemp()
459         <https://webkit.org/b/172192>
460
461         Reviewed by Brent Fulgham.
462
463         * Scripts/webkitpy/style/checkers/cpp.py:
464         (check_language): Add check for mktemp.
465         (CppChecker): Add 'security/temp_file' category.
466         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
467         (CppStyleTest.test_insecure_temp_file): Add test.
468
469 2017-05-17  Devin Rousso  <drousso@apple.com>
470
471         Unreviewed, change my email.
472
473         * Scripts/webkitpy/common/config/contributors.json:
474
475 2017-05-17  Matt Lewis  <jlewis3@apple.com>
476
477         Unreviewed, rolling out r216974.
478
479         Revision caused consistent timeouts on all platforms.
480
481         Reverted changeset:
482
483         "Add a RuntimeEnabledFeature for display: contents, defaulted
484         to false."
485         https://bugs.webkit.org/show_bug.cgi?id=171984
486         http://trac.webkit.org/changeset/216974
487
488 2017-05-17  Alex Christensen  <achristensen@webkit.org>
489
490         Interacting with WKHTTPCookieStores before creating WKWebViews and WKProcessPools should affect cookies used
491         https://bugs.webkit.org/show_bug.cgi?id=171987
492
493         Reviewed by Brady Eidson.
494
495         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
496         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
497         (TEST):
498
499 2017-05-17  Emilio Cobos Álvarez  <ecobos@igalia.com>
500
501         Add a RuntimeEnabledFeature for display: contents, defaulted to false.
502         https://bugs.webkit.org/show_bug.cgi?id=171984
503
504         Reviewed by Antti Koivisto.
505
506         * DumpRenderTree/mac/DumpRenderTree.mm:
507         (enableExperimentalFeatures):
508         * WebKitTestRunner/TestController.cpp:
509         (WTR::TestController::resetPreferencesToConsistentValues):
510
511 2017-05-16  Timothy Horton  <timothy_horton@apple.com>
512
513         Fix the build
514
515         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
516         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
517
518 2017-05-16  Tim Horton  <timothy_horton@apple.com>
519
520         PageVisibilityStateWithWindowChanges tests sometimes time out
521         https://bugs.webkit.org/show_bug.cgi?id=172202
522         <rdar://problem/29653266>
523
524         Reviewed by Dean Jackson.
525
526         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
527         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
528         Make sure the window is miniaturizable, otherwise, in some cases, miniaturize: will not work.
529
530 2017-05-16  Jonathan Bedard  <jbedard@apple.com>
531
532         webkitpy: Start servers before setting-up for testing
533         https://bugs.webkit.org/show_bug.cgi?id=172176
534         <rdar://problem/32225538>
535
536         Reviewed by Alexey Proskuryakov.
537
538         On-device testing requires that servers are started before ports set-up their
539         test environments.
540
541         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
542         (LayoutTestRunner.__init__): Start servers when initializing LayoutTestRunner.
543         (LayoutTestRunner.run_tests): Move the starting of servers to the initializer.
544         * Scripts/webkitpy/layout_tests/controllers/manager.py:
545         (Manager.__init__): Delay construction of the test runner until we can determine
546         if servers need to be started.
547         (Manager.run): Determine if servers need to be started and construct the test runner.
548         (Manager._run_tests): Move the determination of servers to run into Manager.run.
549
550 2017-05-16  Adrian Perez de Castro  <aperez@igalia.com>
551
552         Unreviewed, adding myself to contributors.json
553
554         * Scripts/webkitpy/common/config/contributors.json:
555
556 2017-05-16  Claudio Saavedra  <csaavedra@igalia.com>
557
558         [GTK] Tests that always pass when run alone, but fail in the bots
559         https://bugs.webkit.org/show_bug.cgi?id=168572
560
561         Reviewed by Michael Catanzaro.
562
563         PlatformWebView::viewSupportsOptions() is basically a comparison
564         that checks that the passed options are the ones supported by the
565         web view. There is no reason for them to be implemented for each
566         platform differently. In fact doing so causes issues each time a
567         new option is added, if the corresponding platform implementation
568         is not updated accordingly.
569
570         A consequence of not updating the viewSupportOptions()
571         implementations when new options are added is that tests that need
572         these options might fail if they are executed after a test that
573         didn't need the option, as the webview will be reused even if the
574         option is not supported. This cannot be spotted when running the
575         tests individually. See bug #165133 for other example of the same
576         problem.
577
578         Remove the platform implementations and make the comparison a
579         method of the TestOptions structure, so that the check is in one
580         place. For the time being, only include in the comparison the
581         options that were checked in the mac platform, which seem to be
582         the only ones relevant this far (unless newer ones have also been
583         forgotten).
584
585         * WebKitTestRunner/PlatformWebView.h:
586         (WTR::PlatformWebView::viewSupportsOptions): Use the method
587         defined below.
588         * WebKitTestRunner/TestOptions.h:
589         (WTR::TestOptions::hasSameInitializationOptions): Added.
590         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
591         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
592         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
593         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
594         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
595         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
596         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:
597         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
598
599 2017-05-15  Yusuke Suzuki  <utatane.tea@gmail.com>
600
601         [JSC] Build testapi in non Apple ports
602         https://bugs.webkit.org/show_bug.cgi?id=172103
603
604         Reviewed by Filip Pizlo.
605
606         Now testapi is drived in JSCOnly, GTK and WPE ports too.
607
608         * Scripts/build-jsc:
609         * Scripts/run-javascriptcore-tests:
610
611 2017-05-15  Youenn Fablet  <youenn@apple.com>
612
613         WPT test importer should not account for slow manual tests
614         https://bugs.webkit.org/show_bug.cgi?id=172127
615
616         Reviewed by Ryosuke Niwa.
617
618         Making sure manual tests are not triggering updating tests-options.json file.
619
620         * Scripts/webkitpy/w3c/test_importer.py:
621         (TestImporter.find_importable_tests):
622         (TestImporter._already_identified_as_resource_file):
623         (TestImporter.update_tests_options):
624         * Scripts/webkitpy/w3c/test_importer_unittest.py:
625         (test_manual_slow_test):
626
627 2017-05-15  Jonathan Bedard  <jbedard@apple.com>
628
629         webkitpy: Some versions of simctl do not place parenthesis around runtime identifiers
630         https://bugs.webkit.org/show_bug.cgi?id=172142
631
632         Reviewed by Tim Horton.
633
634         * Scripts/webkitpy/xcode/simulator.py:
635         (Simulator._parse_runtimes): Newer versions of simctl output do not put parenthesis
636         around runtime identifiers.
637         * Scripts/webkitpy/xcode/simulator_unittest.py: Add tests for new simctl output.
638
639 2017-05-15  Ryosuke Niwa  <rniwa@webkit.org>
640
641         Update ARES-6 plan file to use the latest version
642         https://bugs.webkit.org/show_bug.cgi?id=172139
643
644         Reviewed by Keith Miller.
645
646         Include r216538.
647
648         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
649
650 2017-05-15  Jeremy Jones  <jeremyj@apple.com>
651
652         Disable Picture In Picture API tests on unsupported platforms.
653         https://bugs.webkit.org/show_bug.cgi?id=172125
654         rdar://problem/32199477
655
656         Reviewed by Simon Fraser.
657
658         The callbacks and allowing picture-in-picture require new SPI.
659
660         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm:
661
662 2017-05-15  Brady Eidson  <beidson@apple.com>
663
664         [ios-simulator] API test WKWebView.ClearAppCache is failing.
665         https://bugs.webkit.org/show_bug.cgi?id=172120
666
667         Unreviewed test gardening.
668
669         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
670         (TEST): ios-sim needs explicit deleting of the app cache paths that I'd removed in 216805.
671           Restoring that code fixes this.
672
673 2017-05-15  Timothy Horton  <timothy_horton@apple.com>
674
675         Null deref under WebContentReader::readURL when interacting with a file URL
676         https://bugs.webkit.org/show_bug.cgi?id=172045
677         <rdar://problem/25880647>
678
679         Reviewed by Wenson Hsieh.
680
681         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
682         (TestWebKitAPI::TEST):
683         The text of the file URL is pasted because a textual version of it gets
684         onto the pasteboard. However, this test would have crashed before. Also
685         tests that we don't make an <a>.
686
687 2017-05-14  Per Arne Vollan  <pvollan@apple.com>
688
689         [Win] fast/cookies/local-file-can-set-cookies.html is flaky.
690         https://bugs.webkit.org/show_bug.cgi?id=172071
691
692         Reviewed by Alexey Proskuryakov.
693
694         * DumpRenderTree/win/DumpRenderTree.cpp:
695         (resetWebPreferencesToConsistentValues):
696
697 2017-05-14  Chris Dumez  <cdumez@apple.com>
698
699         Drop PassRefPtr class from WTF
700         https://bugs.webkit.org/show_bug.cgi?id=172091
701
702         Reviewed by Alex Christensen.
703
704         Drop API test coverage.
705
706         * TestWebKitAPI/Tests/WTF/Ref.cpp:
707         (TestWebKitAPI::TEST):
708         (TestWebKitAPI::passWithPassRefPtr): Deleted.
709
710 2017-05-13  Eric Carlson  <eric.carlson@apple.com>
711
712         [MediaStream] deviceId constraint doesn't work with getUserMedia
713         https://bugs.webkit.org/show_bug.cgi?id=171877
714         <rdar://problem/31899730>
715
716         Reviewed by Jer Noble.
717
718         The device ID hash salt is now required for getUserMedia to check deviceId constraint, so
719         implement the "checkUserMediaPermission" callback.
720         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
721         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
722         (TestWebKitAPI::checkUserMediaPermissionCallback):
723         (TestWebKitAPI::TEST):
724
725         * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm:
726         (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
727
728 2017-05-13  Chris Dumez  <cdumez@apple.com>
729
730         Stop using RefPtr::release()
731         https://bugs.webkit.org/show_bug.cgi?id=172074
732
733         Reviewed by Geoffrey Garen.
734
735         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
736         (TestWebKitAPI::TEST):
737
738 2017-05-13  Commit Queue  <commit-queue@webkit.org>
739
740         Unreviewed, rolling out r216808.
741         https://bugs.webkit.org/show_bug.cgi?id=172075
742
743         caused lldb to hang when debugging (Requested by smfr on
744         #webkit).
745
746         Reverted changeset:
747
748         "Use Mach exceptions instead of signals where possible"
749         https://bugs.webkit.org/show_bug.cgi?id=171865
750         http://trac.webkit.org/changeset/216808
751
752 2017-05-12  Alex Christensen  <achristensen@webkit.org>
753
754         Rename WKContentExtension to WKContentRuleList
755         https://bugs.webkit.org/show_bug.cgi?id=172053
756         <rdar://problem/32141005>
757
758         Reviewed by Geoffrey Garen.
759
760         * TestWebKitAPI/Tests/WebKit2Cocoa/WKContentExtensionStore.mm:
761         (WKContentRuleListStoreTest::SetUp):
762         (TEST_F):
763         (-[ContentRuleListDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
764         (WKContentExtensionStoreTest::SetUp): Deleted.
765         (-[ContentExtensionDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Deleted.
766
767 2017-05-12  Keith Miller  <keith_miller@apple.com>
768
769         Use Mach exceptions instead of signals where possible
770         https://bugs.webkit.org/show_bug.cgi?id=171865
771
772         Reviewed by Mark Lam.
773
774         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
775         (runThreadMessageTest):
776         (TEST):
777
778 2017-05-12  Jeremy Jones  <jeremyj@apple.com>
779
780         Add objc version of WK2 UIPageClient setHasVideoInPictureInPicture and rename it to hasVideoInPictureInPictureDidChange.
781         https://bugs.webkit.org/show_bug.cgi?id=172048
782         rdar://problem/32163054
783
784         Reviewed by Simon Fraser.
785
786         Add a WKWebView test for hasVideoInPictureInPictureDidChange UIDelegate callback.
787
788         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.html:
789         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm:
790         (hasVideoInPictureInPictureDidChange):
791         (-[PictureInPictureUIDelegate _webView:hasVideoInPictureInPictureDidChange:]):
792         (-[PictureInPictureUIDelegate userContentController:didReceiveScriptMessage:]):
793         (TestWebKitAPI::TEST):
794
795 2017-05-12  Brady Eidson  <beidson@apple.com>
796
797         REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
798         https://bugs.webkit.org/show_bug.cgi?id=172030
799
800         Unreviewed - Test gardening
801
802         Try to resolve this once and for all by using the WebsiteDataStore API to nuke everything
803         before the test starts.
804
805         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
806         (defaultWebsiteCacheDirectory):
807         (defaultApplicationCacheDirectory):
808         (TEST):
809         (defaultWebsiteDataDirectory): Deleted.
810
811 2017-05-12  David Quesada  <david_quesada@apple.com>
812
813         Add SPI for overriding WKWebView's clipping behavior for _visibleContentRect
814         https://bugs.webkit.org/show_bug.cgi?id=172000
815         rdar://problem/32144756
816
817         Reviewed by Simon Fraser.
818
819         Added API tests to verify that WKWebView provides the expected value for
820         _visibleContentRect in various configurations. (i.e. not inside a scrollview,
821         inside a scrollview but not clipped, clipped by an ancestor scrollview,
822         clipped by the webview's _enclosingViewForExposedRectComputation)
823
824         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
825         * TestWebKitAPI/Tests/WebKit2Cocoa/VisibleContentRect.mm: Added.
826         (-[TestWKWebViewWithEnclosingView _enclosingViewForExposedRectComputation]):
827         (TestWebKitAPI::TEST):
828
829 2017-05-12  Brady Eidson  <beidson@apple.com>
830
831         REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
832         https://bugs.webkit.org/show_bug.cgi?id=172030
833
834         Unreviewed - Test gardening, in effect...
835
836         More exploration as to why this continues to fail on the bots.
837         
838         This change should give us a smoking gun.
839         
840         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
841         (TEST):
842
843 2017-05-12  Hyungwook Lee  <hyungwook.lee@navercorp.com>
844
845         [GTK] Fix compile warnings in PlatformImageCairo.cpp
846         https://bugs.webkit.org/show_bug.cgi?id=171850
847
848         Reviewed by Michael Catanzaro.
849
850         * ImageDiff/cairo/PlatformImageCairo.cpp:
851         (ImageDiff::PlatformImage::createFromStdin):
852         (ImageDiff::PlatformImage::writeAsPNGToStdout):
853
854 2017-05-12  Jeremy Jones  <jeremyj@apple.com>
855
856         Add UIClient callback for when picture-in-picture is activated.
857         https://bugs.webkit.org/show_bug.cgi?id=172023
858
859         Reviewed by Simon Fraser.
860
861         Added a test for WKPageUIClientV10 setHasVideoInPictureInPicture.
862
863         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
864         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.html: Added.
865         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm: Added.
866         (onLoadedCompletedCallback):
867         (waitUntilOnLoadIsCompleted):
868         (didFinishLoadForFrame):
869         (setHasVideoInPictureInPicture):
870         (TestWebKitAPI::TEST):
871
872 2017-05-12  Jonathan Bedard  <jbedard@apple.com>
873
874         Unreviewed follow-up to r216776.
875
876         * Scripts/webkitpy/port/base.py:
877         (Port.path_to_crash_logs): Raise not implemented.
878         * Scripts/webkitpy/port/test.py:
879         (TestPort.path_to_crash_logs): Return results directory as the location of crash logs.
880         * Scripts/webkitpy/port/win.py:
881         (WinPort.path_to_crash_logs): Ditto.
882
883 2017-05-12  Alexey Proskuryakov  <ap@apple.com>
884
885         Bot watcher's dashboard shows results links twice sometimes
886         https://bugs.webkit.org/show_bug.cgi?id=172043
887
888         Reviewed by Tim Horton.
889
890         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
891         (BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):
892
893 2017-05-12  Brady Eidson  <beidson@apple.com>
894
895         REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
896         https://bugs.webkit.org/show_bug.cgi?id=172030
897
898         Unreviewed - Test gardening, in effect...
899
900         This failure is only being seen by the bots.
901         
902         I believe this test is utterly broken in the first place; when it checks the .wal file's
903         size that is not actually an indicator that the records were deleted.
904         
905         But that isn't what's coming up as failure on the bots.
906         
907         This patch is an attempt to:
908         1 - More forcefully clear the Website data directory of leftovers before the test starts.
909         2 - Give an earlier indication of the failure that the bots are seeing, to possibly reveal more.
910
911         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
912         (defaultWebsiteDataDirectory):
913         (defaultApplicationCacheDirectory):
914         (TEST):
915
916 2017-05-12  Jonathan Bedard  <jbedard@apple.com>
917
918         webkitpy: Pass directory with crash logs into CrashLogs
919         https://bugs.webkit.org/show_bug.cgi?id=172033
920         <rdar://problem/32157616>
921
922         Reviewed by Daniel Bates.
923
924         Refactor CrashLogs and the callers of CrashLogs so that the port object owns
925         the location of crash logs.
926
927         * Scripts/webkitpy/common/system/crashlogs.py:
928         (CrashLogs.__init__): Pass mandatory crash_log_directory when constructing.
929         (CrashLogs._find_newest_log_darwin): Use self._crash_log_directory instead of
930         generating one.
931         (CrashLogs._find_newest_log_win): Use self._crash_log_directory instead of
932         self._results_directory.
933         (CrashLogs._find_all_logs_darwin): Use self._crash_log_directory instead of
934         generating one.
935         (CrashLogs._log_directory_darwin): Moved to port.
936         * Scripts/webkitpy/common/system/crashlogs_unittest.py: Update tests since the path
937         to the crash log is no longer owned by CrashLogs.
938         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Use the general
939         directory for uploading crash logs. Note that crash logs are only supported on Mac
940         and Windows.
941         * Scripts/webkitpy/port/apple.py: Remove unneeded CrashLogs import.
942         * Scripts/webkitpy/port/base.py:
943         (Port.path_to_crash_logs): Unless ports declare otherwise, crash logs are assumed
944         to be in the results directory.
945         * Scripts/webkitpy/port/darwin.py:
946         (DarwinPort.path_to_crash_logs): Moved from CrashLogs._log_directory_darwin.
947         (DarwinPort._look_for_all_crash_logs_in_log_dir): Use port specific crash log path.
948         (DarwinPort._get_crash_log): Ditto.
949         * Scripts/webkitpy/port/darwin_testcase.py:
950         (DarwinTest.test_crashlog_path): Test that the Darwin ports are correctly calculating
951         the path to crash logs.
952         * Scripts/webkitpy/port/ios_device.py:
953         (IOSDevicePort.path_to_crash_logs): Currently, crash log retrieval is undefined for iOS.
954         * Scripts/webkitpy/port/ios_device_unittest.py:
955         (IOSDeviceTest.test_crashlog_path): Currently, crash log retrieval is undefined for iOS.
956         * Scripts/webkitpy/port/ios_simulator.py: Remove unneeded CrashLogs import.
957         * Scripts/webkitpy/port/mac.py: Ditto.
958         * Scripts/webkitpy/port/test.py:
959         (TestDriver.run_test): Use port specific crash log path when retrieving crash logs.
960         * Scripts/webkitpy/port/win.py:
961         (WinPort._get_crash_log): Ditto.
962         * Scripts/webkitpy/tool/commands/queries.py:
963         (execute): Construct a port object since this is the object which owns the path to crash logs.
964
965 2017-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
966
967         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/create-navigation-data after r216615.
968
969         In r216615 the custom code for window.open() was removed. The generated code now correctly handles the optional
970         URL parameter using the default value "about:blank" when not provided.
971
972         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
973         (testWebViewCreateNavigationData):
974
975 2017-05-11  Youenn Fablet  <youenn@apple.com>
976
977         Allow WPT server to serve specific WebKit test
978         https://bugs.webkit.org/show_bug.cgi?id=171479
979
980         Reviewed by Ryosuke Niwa.
981
982         Adding a new mount point to WPT server.
983         It points to LayoutTests/http/wpt folder and is triggered on "/WebKit" urls.
984
985         Updating the webkitpy infrastructure to launch WPT server and do test url mapping for LayoutTests/wpt tests.
986
987         * Scripts/webkitpy/layout_tests/controllers/manager.py:
988         (Manager.__init__):
989         (Manager._is_http_test):
990         (Manager._needs_web_platform_test):
991         (Manager._run_tests):
992         (Manager._is_web_platform_test): Deleted.
993         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
994         (build_routes):
995         (main):
996         * Scripts/webkitpy/port/driver.py:
997         (Driver):
998         (Driver.is_webkit_specific_web_platform_test):
999         (Driver.test_to_uri):
1000         (Driver._command_from_driver_input):
1001
1002 2017-05-11  Brady Eidson  <beidson@apple.com>
1003
1004         [WKWebsiteDataStore removeDataOfTypes:...] doesn't work for IndexedDB if the data store has a custom IDB path.
1005         <rdar://problem/30612463> and https://bugs.webkit.org/show_bug.cgi?id=171994
1006
1007         Reviewed by Andy Estes.
1008         Informal review by Maureen Daum.
1009
1010         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1011         (TEST):
1012
1013 2017-05-11  Joseph Pecoraro  <pecoraro@apple.com>
1014
1015         REGRESSION(r216217): lldb_webkit.py no longer prints out a WTFString, StringImpl needs to handle StringImplShape change
1016         https://bugs.webkit.org/show_bug.cgi?id=171989
1017
1018         Reviewed by Brian Burg.
1019
1020         * lldb/lldb_webkit.py:
1021         (WTFStringImplProvider.get_data8):
1022         (WTFStringImplProvider.get_data16):
1023         m_data8 and m_data16 are now part of the superclass StringImplShape
1024         instead of directly in StringImpl. So first get the shape by getting
1025         index 0, and the data properties are the same offset within that.
1026
1027 2017-05-11  Joseph Pecoraro  <pecoraro@apple.com>
1028
1029         Remove Vibration API
1030         https://bugs.webkit.org/show_bug.cgi?id=171766
1031
1032         Rubber-stamped by Alexey Proskuryakov.
1033
1034         * Scripts/webkitperl/FeatureList.pm:
1035
1036 2017-05-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1037
1038         Add WPE release bots
1039         https://bugs.webkit.org/show_bug.cgi?id=171973
1040
1041         Reviewed by Žan Doberšek.
1042
1043         This adds a WPE Release Build bot (64-bit) and a WPE Release Test bot.
1044         It also adds a new WPE buildbot category.
1045
1046         * BuildSlaveSupport/build.webkit.org-config/config.json:
1047         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1048         (InstallWpeDependencies):
1049         (appendCustomBuildFlags):
1050         (Factory.__init__):
1051         (loadBuilderConfig):
1052         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1053         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1054
1055 2017-05-09  Sam Weinig  <sam@webkit.org>
1056
1057         Remove support for legacy Notifications
1058         https://bugs.webkit.org/show_bug.cgi?id=171487
1059
1060         Reviewed by Jon Lee.
1061
1062         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1063         (DRTDesktopNotificationPresenter::checkNotificationPermission):
1064         * Scripts/webkitperl/FeatureList.pm:
1065         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1066         Remove use and definition of ENABLE_LEGACY_NOTIFICATIONS.
1067
1068 2017-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
1069
1070         Remove user agent quirk for Slack
1071         https://bugs.webkit.org/show_bug.cgi?id=171869
1072
1073         Reviewed by Carlos Garcia Campos.
1074
1075         Remove the corresponding test.
1076
1077         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1078         (TestWebKitAPI::TEST):
1079
1080 2017-05-10  Commit Queue  <commit-queue@webkit.org>
1081
1082         Unreviewed, rolling out r216578.
1083         https://bugs.webkit.org/show_bug.cgi?id=171920
1084
1085         Broke the GTK+ build with Wayland enabled (Requested by KaL on
1086         #webkit).
1087
1088         Reverted changeset:
1089
1090         "[GTK] Bump GTK+ and its dependencies in jhbuild"
1091         https://bugs.webkit.org/show_bug.cgi?id=171918
1092         http://trac.webkit.org/changeset/216578
1093
1094 2017-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1095
1096         [GTK] Bump GTK+ and its dependencies in jhbuild
1097         https://bugs.webkit.org/show_bug.cgi?id=171918
1098
1099         Reviewed by Carlos Alberto Lopez Perez.
1100
1101         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1102         (WTR::initializeGtkSettings):
1103         * gtk/jhbuild.modules:
1104         * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Removed.
1105         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch: Removed.
1106
1107 2017-05-10  Don Olmstead  <don.olmstead@am.sony.com>
1108
1109         [Win] Set CMake args in build-webkit
1110         https://bugs.webkit.org/show_bug.cgi?id=171436
1111
1112         Reviewed by Per Arne Vollan.
1113
1114         * Scripts/build-webkit:
1115
1116 2017-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1117
1118         ImageDiff: Add CG implementation for new ImageDiff
1119         https://bugs.webkit.org/show_bug.cgi?id=170608
1120
1121         Reviewed Alex Christensen.
1122
1123         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1124         * DumpRenderTree/win/ImageDiffCairo.cpp: Removed.
1125         * DumpRenderTree/win/ImageDiffWin.cpp: Removed.
1126         * ImageDiff/CMakeLists.txt:
1127         * ImageDiff/Cairo.cmake:
1128         * ImageDiff/ImageDiff.cpp:
1129         (main):
1130         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
1131         * ImageDiff/PlatformImage.cpp:
1132         * ImageDiff/PlatformImage.h:
1133         * ImageDiff/cairo/PlatformImageCairo.cpp:
1134         * ImageDiff/cg/ImageDiff.cpp: Removed.
1135         * ImageDiff/cg/PlatformImageCG.cpp: Added.
1136         (ImageDiff::PlatformImage::createFromStdin):
1137         (ImageDiff::PlatformImage::createFromDiffData):
1138         (ImageDiff::PlatformImage::PlatformImage):
1139         (ImageDiff::PlatformImage::~PlatformImage):
1140         (ImageDiff::PlatformImage::width):
1141         (ImageDiff::PlatformImage::height):
1142         (ImageDiff::PlatformImage::rowBytes):
1143         (ImageDiff::PlatformImage::hasAlpha):
1144         (ImageDiff::PlatformImage::pixels):
1145         (ImageDiff::PlatformImage::writeAsPNGToStdout):
1146
1147 2017-05-10  Zan Dobersek  <zdobersek@igalia.com>
1148
1149         Enable FTL JIT by default on AArch64
1150         https://bugs.webkit.org/show_bug.cgi?id=144039
1151
1152         Reviewed by Yusuke Suzuki.
1153
1154         * Scripts/build-jsc: Enable the FTL JIT option by default on ARM64.
1155         * Scripts/run-jsc-stress-tests: Unmark the ARM64 and Linux combination
1156         as an unsupported FTL platform.
1157         * Scripts/webkitdirs.pm:
1158         (isARM64): Returns 1 if the determined architecture is 'arm64'.
1159         * Scripts/webkitperl/FeatureList.pm: Enable FTL_JIT and WEBASSEMBLY on ARM64.
1160
1161 2017-05-09  Jonathan Bedard  <jbedard@apple.com>
1162
1163         webkitpy: Remove unneeded crash log retrieval, refactor Darwin crash retrieval
1164         https://bugs.webkit.org/show_bug.cgi?id=170857
1165         <rdar://problem/31635373>
1166
1167         Reviewed by Aakash Jain.
1168
1169         Since LayoutTestRelay has been removed, iOS Simulators and Macs can use the same
1170         code to search for crash logs.
1171
1172         * Scripts/webkitpy/port/darwin.py:
1173         (DarwinPort._get_crash_log): Moved from MacPort.
1174         * Scripts/webkitpy/port/darwin_testcase.py:
1175         (DarwinTest.test_get_crash_log): Moved from MacTest.
1176         * Scripts/webkitpy/port/ios_device.py:
1177         (IOSDevicePort._get_crash_log): Implement pass-through for iOS device, since iOS
1178         devices must search for crash-logs remotely.
1179         * Scripts/webkitpy/port/ios_simulator.py:
1180         (IOSSimulatorPort._get_crash_log): Deleted.
1181         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1182         (IOSSimulatorTest.test_get_crash_log): Deleted.
1183         * Scripts/webkitpy/port/mac.py:
1184         (MacPort._get_crash_log): Moved to DarwinPort
1185         * Scripts/webkitpy/port/mac_unittest.py:
1186         (MacTest.test_get_crash_log): Moved to DarwinTest.
1187
1188 2017-05-09  Jonathan Bedard  <jbedard@apple.com>
1189
1190         build ImageDiff with host SDK from Make
1191         https://bugs.webkit.org/show_bug.cgi?id=171835
1192
1193         Reviewed by Alexey Proskuryakov.
1194
1195         ImageDiff should be built for the default SDK and default architecture when
1196         the SDKROOT is set to either iOS device or iOS simulator. Check the
1197         DO_NOT_BUILD_IMAGE_DIFF flag to skip the ImageDiff build.
1198
1199         * ImageDiff/Makefile: Use Mac SDK when building for iOS Simulator or iOS device.
1200         * Makefile: Do not build ImageDiff if the DO_NOT_BUILD_IMAGE_DIFF flag is set.
1201
1202 2017-05-09  Matt Lewis  <jlewis3@apple.com>
1203
1204         Unreviewed, adding myself to contributors.json
1205
1206         * Scripts/webkitpy/common/config/contributors.json:
1207
1208 2017-05-09  Jonathan Bedard  <jbedard@apple.com>
1209
1210         REGRESSION: ImageDiff not building with make
1211         https://bugs.webkit.org/show_bug.cgi?id=171788
1212
1213         Reviewed by Alex Christensen.
1214
1215         * Makefile: Build ImageDiff for all platforms.
1216
1217 2017-05-09  Fujii Hironori  <Hironori.Fujii@sony.com>
1218
1219         [Win] ImageDiff isn't built since Bug 168945
1220         https://bugs.webkit.org/show_bug.cgi?id=171847
1221
1222         Reviewed by Alex Christensen.
1223
1224         * CMakeLists.txt: Add 'ImageDiff' sub-directory to build if WIN32.
1225         * ImageDiff/ImageDiff.cpp: Include some header files to fix compilation errors.
1226         * ImageDiff/PlatformWin.cmake: Define USE_CAIRO if WinCairo port.
1227
1228 2017-05-09  Zan Dobersek  <zdobersek@igalia.com>
1229
1230         Upstream the WPE port
1231         https://bugs.webkit.org/show_bug.cgi?id=171110
1232
1233         Reviewed by Alex Christensen.
1234
1235         webkit-dev thread:
1236         https://lists.webkit.org/pipermail/webkit-dev/2017-April/028923.html
1237
1238         Add WPE support to various tooling scripts, TestWebKitAPI and WebKitTestRunner.
1239         In-file changes removed from this ChangeLog entry for brevity.
1240
1241         * BuildSlaveSupport/built-product-archive:
1242         * BuildSlaveSupport/test-result-archive:
1243         * CMakeLists.txt:
1244         * ImageDiff/PlatformWPE.cmake: Added.
1245         * Scripts/build-dumprendertree:
1246         * Scripts/build-webkit:
1247         * Scripts/build-webkittestrunner:
1248         * Scripts/update-webkit-libs-jhbuild:
1249         * Scripts/update-webkitwpe-libs: Added.
1250         * Scripts/webkitdirs.pm:
1251         * Scripts/webkitperl/FeatureList.pm:
1252         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1253         * Scripts/webkitpy/port/factory.py:
1254         * Scripts/webkitpy/port/wpe.py: Added.
1255         * TestWebKitAPI/PlatformWPE.cmake: Added.
1256         * TestWebKitAPI/wpe/InjectedBundleControllerWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
1257         * TestWebKitAPI/wpe/PlatformUtilitiesWPE.cpp: Added.
1258         * TestWebKitAPI/wpe/main.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
1259         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1260         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
1261         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1262         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1263         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1264         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1265         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityControllerWPE.cpp: Added.
1266         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp: Added.
1267         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp: Added.
1268         * WebKitTestRunner/InjectedBundle/wpe/InjectedBundleWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
1269         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
1270         * WebKitTestRunner/PlatformWPE.cmake: Added.
1271         * WebKitTestRunner/PlatformWebView.h:
1272         * WebKitTestRunner/TestController.cpp:
1273         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp: Added.
1274         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp: Added.
1275         * WebKitTestRunner/wpe/HeadlessViewBackend.h: Copied from Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h.
1276         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp: Added.
1277         * WebKitTestRunner/wpe/TestControllerWPE.cpp: Added.
1278         * WebKitTestRunner/wpe/main.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
1279         * jhbuild/jhbuild-wrapper:
1280         * wpe/generate-inspector-gresource-manifest.py: Added.
1281         * wpe/jhbuild.modules: Added.
1282         * wpe/jhbuildrc: Added.
1283         * wpe/patches/cairo-egl-device-create-for-egl-surface.patch: Added.
1284         * wpe/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
1285         * wpe/patches/freetype6-2.4.11-truetype-font-height-fix.patch: Added.
1286         * wpe/patches/gdate-suppress-string-format-literal-warning.patch: Added.
1287         * wpe/patches/glib-warning-fix.patch: Added.
1288         * wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Added.
1289         * wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Added.
1290         * wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added.
1291         * wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added.
1292         * wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Added.
1293
1294 2017-05-08  Jonathan Bedard  <jbedard@apple.com>
1295
1296         Implement PlatformWebView::windowSnapshotImage and createBitmapContextFromWebView for iOS devices
1297         https://bugs.webkit.org/show_bug.cgi?id=169421
1298         <rdar://problem/30950171>
1299
1300         Reviewed by Tim Horton.
1301
1302         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1303         (createBitmapContextFromWebView): Implement for IOSurface.
1304         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1305         (WTR::PlatformWebView::windowSnapshotImage): Use snapshot API for device.
1306
1307 2017-05-08  Jonathan Bedard  <jbedard@apple.com>
1308
1309         buildbot: Cleanup simulators after running tests
1310         https://bugs.webkit.org/show_bug.cgi?id=171679
1311
1312         Reviewed by Aakash Jain.
1313
1314         simctl is partitioned for each user. Since kill-old-processes
1315         is run as root, we need to specify the buildbot user when tearing
1316         down simulators between steps.
1317
1318         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1319         (KillOldProcesses): Pass buildbot user to kill-old-processes.
1320         * BuildSlaveSupport/kill-old-processes:
1321         (main): Specify the user for simctl if one has been provided.
1322
1323 2017-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1324
1325         REGRESSION(r216179): [GTK] Script install-dependencies misses liborc
1326         https://bugs.webkit.org/show_bug.cgi?id=171681
1327
1328         Reviewed by Carlos Garcia Campos.
1329
1330         * gtk/install-dependencies:
1331
1332 2017-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1333
1334         Unreviewed. Fix GTK+ test /webkit2/WebKitConsoleMessage/network-error after r215556.
1335
1336         Glib uses now Unicode quotes in error messages.
1337
1338         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
1339         (testWebKitConsoleMessageNetworkError):
1340
1341 2017-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1342
1343         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/javascript-dialogs after r215404.
1344
1345         Sending down+up keys is no longer enough to simulate a real user interaction after r215404, the key events now
1346         should be handled by the web process to be considered a user interaction. So, add an input to the HTML and send
1347         characters to the input. Also fix typo in the function name.
1348
1349         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1350         (testWebViewJavaScriptDialogs):
1351
1352 2017-05-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1353
1354         [GTK] Cannot sign in with new Google sign-in page
1355         https://bugs.webkit.org/show_bug.cgi?id=171770
1356
1357         Unreviewed. This just adds a test.
1358
1359         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1360         (TestWebKitAPI::TEST):
1361
1362 2017-05-06  Simon Fraser  <simon.fraser@apple.com>
1363
1364         [iOS WK2] Make rotation tests more reliable
1365         https://bugs.webkit.org/show_bug.cgi?id=171778
1366
1367         Reviewed by Tim Horton.
1368
1369         Switching between "safari-style" rotation and normal rotation left state on the WKWebView
1370         that would cause later viewport-sensitive tests to fail. The WKWebView would be left
1371         with override layout parameters, and an override orientation, and these caused viewport
1372         size to leak into later tests, and WebCore orientation to not get reset correctly.
1373
1374         Also, WKWebView was unregistering for UIWindowDidRotateNotification notifications when
1375         an override orientation was set, and would never re-register, causing lost orientationchanged
1376         events.
1377
1378         Fix by exposing WKWebView SPI to clear the various bits of overide state. Also don't unregister
1379         from the UIWindowDidRotateNotification notification; it's already ignored anyway if it fires.
1380
1381         Also wait for a visible content rect update after resizing the WKWebVeiw between tests, to make sure
1382         the WebProcess is caught up before proceeding with the test.
1383
1384         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1385         (-[PlatformWebViewController viewWillTransitionToSize:withTransitionCoordinator:]):
1386         * WebKitTestRunner/ios/TestControllerIOS.mm:
1387         (WTR::TestController::platformResetStateToConsistentValues):
1388         (WTR::TestController::platformConfigureViewForTest):
1389
1390 2017-05-06  Csaba Osztrogonác  <ossy@webkit.org>
1391
1392         [Mac][cmake] Buildfix after r216047
1393         https://bugs.webkit.org/show_bug.cgi?id=171769
1394
1395         Unreviewed buildfix.
1396
1397         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1398
1399 2017-05-05  Brady Eidson  <beidson@apple.com>
1400
1401         API test WebKit2.WebsiteDataStoreCustomPaths is failing on ios-simulator.
1402         <rdar://problem/31977294> and https://bugs.webkit.org/show_bug.cgi?id=171513
1403
1404         Reviewed by Andy Estes.
1405
1406         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1407         (TEST):
1408
1409 2017-05-05  Brian Burg  <bburg@apple.com>
1410
1411         [Cocoa] Converting from WebCore::Cookie to NSHTTPCookie always marks cookies as session cookies
1412         https://bugs.webkit.org/show_bug.cgi?id=171748
1413         <rdar://problem/32027327>
1414
1415         Reviewed by Michael Catanzaro.
1416
1417         Remove temporary workaround now that the assertion failure is fixed.
1418
1419         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1420         (TEST):
1421
1422 2017-05-05  Simon Fraser  <simon.fraser@apple.com>
1423
1424         Make it possible to test rotation in iOS WebKitTestRunner
1425         https://bugs.webkit.org/show_bug.cgi?id=171755
1426
1427         Reviewed by Tim Horton.
1428
1429         Add to UIScriptController:
1430             void simulateRotation(DeviceOrientation orientation, object callback);
1431             void simulateRotationLikeSafari(DeviceOrientation orientation, object callback);
1432
1433         The former just does a view resize, as a simple WKWebView app would do. The second does
1434         animation more like MobileSafari, using _begin/_endAnimatedResize. and associated override
1435         layout size and interface orientation. The two behaviors produce different resize and
1436         orientationchange events and sizes, and both need to be tested.
1437
1438         Rotation is initiated by a call on UIDevice, and responded to by the root view controller,
1439         which is now a custom subclass (PlatformWebViewController).
1440
1441         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1442         (WTR::UIScriptController::simulateRotation):
1443         (WTR::UIScriptController::simulateRotationLikeSafari):
1444         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1445         (WTR::UIScriptController::simulateRotation):
1446         (WTR::UIScriptController::simulateRotationLikeSafari):
1447         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1448         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1449         (WTR::toDeviceOrientation):
1450         (WTR::UIScriptController::simulateRotation):
1451         (WTR::UIScriptController::simulateRotationLikeSafari):
1452         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1453         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1454         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1455         (-[TestRunnerWKWebView dealloc]):
1456         (-[TestRunnerWKWebView _didEndRotation]):
1457         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1458         (-[PlatformWebViewController viewWillTransitionToSize:withTransitionCoordinator:]):
1459         (WTR::PlatformWebView::PlatformWebView):
1460         * WebKitTestRunner/ios/TestControllerIOS.mm:
1461         (WTR::TestController::platformResetStateToConsistentValues):
1462         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1463         (WTR::toUIDeviceOrientation):
1464         (WTR::UIScriptController::simulateRotation):
1465         (WTR::UIScriptController::simulateRotationLikeSafari):
1466         (WTR::UIScriptController::platformClearAllCallbacks):
1467         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1468         (WTR::UIScriptController::simulateRotation):
1469         (WTR::UIScriptController::simulateRotationLikeSafari):
1470
1471 2017-05-05  Jonathan Bedard  <jbedard@apple.com>
1472
1473         Use ImageDiff built by host SDK and remove ImageDiff from DumpRenderTree
1474         https://bugs.webkit.org/show_bug.cgi?id=168945
1475         <rdar://problem/30745695>
1476
1477         Reviewed by David Kilzer.
1478
1479         Use ImageDiff built with the host machine's SDK and stop building ImageDiff with the
1480         target SDK. These two changes must happen simultaneously because some archives will
1481         clobber the ImageDiff from the host SDK with the ImageDiff from the target SDK.
1482
1483         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Remove ImageDiff from project.
1484         * DumpRenderTree/PlatformWin.cmake: Remove ImageDiff. Note that the CMakeLists.txt in the
1485         tools directory still includes ImageDiff.
1486         * DumpRenderTree/cg/ImageDiffCG.cpp: Removed.
1487         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Removed.
1488         * Scripts/webkitpy/port/darwin.py: 
1489         (DarwinPort._path_to_image_diff): Return the correct path to ImageDiff when building
1490         locally or when running archives.
1491         * Scripts/webkitpy/port/image_diff.py:
1492         (IOSSimulatorImageDiffer): Deleted.
1493         * Scripts/webkitpy/port/ios_simulator.py:
1494         (IOSSimulatorPort.diff_image): Deleted.
1495
1496 2017-05-05  Brian Burg  <bburg@apple.com>
1497
1498         API test WebKit2.WKHTTPCookieStore fails due to possible issue with handling non-session cookies
1499         https://bugs.webkit.org/show_bug.cgi?id=171748
1500
1501         Unreviewed test gardening.
1502
1503         The assertion failure will be investigated separately in order to avoid rolling out
1504         the fix for "secure" cookies. This assertion fails even without r216258 applied.
1505
1506         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1507         (TEST):
1508
1509 2017-05-05  Jonathan Bedard  <jbedard@apple.com>
1510
1511         Unreviewed, rolling out r216260.
1512
1513         Breaks internal iOS testers
1514
1515         Reverted changeset:
1516
1517         "Use ImageDiff built by host SDK and remove ImageDiff from
1518         DumpRenderTree"
1519         https://bugs.webkit.org/show_bug.cgi?id=168945
1520         http://trac.webkit.org/changeset/216260
1521
1522 2017-05-05  Jonathan Bedard  <jbedard@apple.com>
1523
1524         Use ImageDiff built by host SDK and remove ImageDiff from DumpRenderTree
1525         https://bugs.webkit.org/show_bug.cgi?id=168945
1526         <rdar://problem/30745695>
1527
1528         Reviewed by David Kilzer.
1529
1530         Use ImageDiff built with the host machine's SDK and stop building ImageDiff with the
1531         target SDK. These two changes must happen simultaneously because some archives will
1532         clobber the ImageDiff from the host SDK with the ImageDiff from the target SDK.
1533
1534         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Remove ImageDiff from project.
1535         * DumpRenderTree/PlatformWin.cmake: Remove ImageDiff. Note that the CMakeLists.txt in the
1536         tools directory still includes ImageDiff.
1537         * DumpRenderTree/cg/ImageDiffCG.cpp: Removed.
1538         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Removed.
1539         * Scripts/webkitpy/port/darwin.py: 
1540         (DarwinPort._path_to_image_diff): Return the correct path to ImageDiff when building
1541         locally or when running archives.
1542         * Scripts/webkitpy/port/image_diff.py:
1543         (IOSSimulatorImageDiffer): Deleted.
1544         * Scripts/webkitpy/port/ios_simulator.py:
1545         (IOSSimulatorPort.diff_image): Deleted.
1546
1547 2017-05-05  Brian Burg  <bburg@apple.com>
1548
1549         [Cocoa] Converting from WebCore::Cookie to NSHTTPCookie always marks cookies as secure
1550         https://bugs.webkit.org/show_bug.cgi?id=171700
1551         <rdar://problem/32017975>
1552
1553         Reviewed by Brady Eidson.
1554
1555         Fix a mistake in the test that should have caught this bug.
1556
1557         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1558         (TEST):
1559         The assertions that were meant to check round-tripping were actually checking
1560         the properties of the original cookie objects, not the round-tripped ones.
1561         This test now fails without the bugfix and passes when it is applied.
1562
1563 2017-05-05  Daniel Bates  <dabates@apple.com>
1564
1565         Use EXPECT_EQ() when comparing strings in TestWebKitAPI tests
1566         https://bugs.webkit.org/show_bug.cgi?id=171698
1567
1568         Reviewed by Darin Adler.
1569
1570         We should use EXPECT_EQ() instead of EXPECT_TRUE() to compare WTF::String() objects
1571         so that we get pretty diff output when the actual string differs from the expected
1572         string as opposed to seeing a boolean result. The former makes makes it straightforward
1573         to diagnose a regression without reading the code for the test or instrumenting it to
1574         determine the actual string that was compared.
1575
1576         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1577         (TestWebKitAPI::TEST):
1578         * TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm:
1579         (TestWebKitAPI::TEST_F):
1580         * TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm:
1581         (TestWebKitAPI::TEST_F):
1582
1583 2017-05-05  Chris Dumez  <cdumez@apple.com>
1584
1585         Rename webProcessDidCrashWithReason callback to webProcessDidTerminate and stop calling webProcessDidCrash for client terminations
1586         https://bugs.webkit.org/show_bug.cgi?id=171624
1587
1588         Reviewed by Dan Bernstein.
1589
1590         Extend API test coverage to cover crashes in addition to terminations requested by the client.
1591
1592         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1593         * TestWebKitAPI/Tests/WebKit2/ProcessDidTerminate.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/ProcessDidCrashWithReason.cpp.
1594         (TestWebKitAPI::webProcessWasTerminatedByClient):
1595         (TestWebKitAPI::webProcessCrashed):
1596         (TestWebKitAPI::TEST):
1597
1598 2017-05-04  Mark Lam  <mark.lam@apple.com>
1599
1600         DRT's setAudioResultCallback() and IDBRequest::setResult() need to acquire the JSLock.
1601         https://bugs.webkit.org/show_bug.cgi?id=171716
1602         <rdar://problem/30878027>
1603
1604         Reviewed by Saam Barati.
1605
1606         setAudioResultCallback() needs to acquire the JSLock before calling toJS() (which
1607         does JS conversion and therefore, potentially JS allocations) and accessing
1608         methods of internal JS data structures (which may do JS invocation, etc).
1609
1610         * DumpRenderTree/TestRunner.cpp:
1611         (setAudioResultCallback):
1612
1613 2017-05-05  Jonathan Bedard  <jbedard@apple.com>
1614
1615         buildbot: Cleanup simulators after running tests
1616         https://bugs.webkit.org/show_bug.cgi?id=171679
1617         <rdar://problem/31994361>
1618
1619         Reviewed by Aakash Jain.
1620
1621         We shutdown the simulator process between tests, but in some cases, this is not
1622         sufficient. Explicitly shutdown every booted simulator.
1623
1624         * BuildSlaveSupport/kill-old-processes:
1625         (main): Shutdown all booted simulators.
1626
1627 2017-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1628
1629         [GTK] Assertion failure in Inspector::RemoteInspector::setRemoteInspectorClient when disposing WebKitWebContext
1630         https://bugs.webkit.org/show_bug.cgi?id=171644
1631
1632         Reviewed by Michael Catanzaro.
1633
1634         Check that only one WebKitWebContext can have automation enabled.
1635
1636         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp:
1637         (testAutomationSessionRequestSession):
1638
1639 2017-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1640
1641         [GTK] TestController timeout source callback should return G_SOURCE_REMOVE
1642         https://bugs.webkit.org/show_bug.cgi?id=171724
1643
1644         Reviewed by Michael Catanzaro.
1645
1646         It's currently returning CONTINUE which causes it to be called again even if the run loop has been stopped.
1647
1648         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1649         (WTR::timeoutSource):
1650
1651 2017-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1652
1653         Unreviewed. Fix wrong assert after r215176.
1654
1655         Cairo surface received by computeMD5HashStringForCairoSurface() doesn't need to be ARGB32 since r215176, it
1656         could also be RGB24 when created from a web view snapshot.
1657
1658         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1659         (WTR::computeMD5HashStringForCairoSurface):
1660
1661 2017-05-04  Brian Burg  <bburg@apple.com>
1662
1663         lldb_webkit.py should provide a type summary for WebCore::URL
1664         https://bugs.webkit.org/show_bug.cgi?id=171670
1665
1666         Reviewed by Jer Noble.
1667
1668         Just print out the underlying string using the WTFString provider.
1669
1670         * lldb/lldb_webkit.py:
1671         (__lldb_init_module):
1672         (WebCoreURL_SummaryProvider):
1673         (WebCoreURLProvider):
1674         (WebCoreURLProvider.__init__):
1675         (WebCoreURLProvider.to_string):
1676
1677 2017-05-04  Commit Queue  <commit-queue@webkit.org>
1678
1679         Unreviewed, rolling out r216206.
1680         https://bugs.webkit.org/show_bug.cgi?id=171714
1681
1682         Multiple LayoutTests crashing in Document::page() (Requested
1683         by ap on #webkit).
1684
1685         Reverted changeset:
1686
1687         "Remove support for legacy Notifications"
1688         https://bugs.webkit.org/show_bug.cgi?id=171487
1689         http://trac.webkit.org/changeset/216206
1690
1691 2017-05-04  Mark Lam  <mark.lam@apple.com>
1692
1693         API test WTF.StaticStringImpl crashing in TestWebKitAPI::WTF_StaticStringImpl_Test::TestBody() + 3188
1694         https://bugs.webkit.org/show_bug.cgi?id=171702
1695
1696         Reviewed by Filip Pizlo.
1697
1698         The test was supposed to use the MAKE_STATIC_STRING_IMPL macro.  I had previously
1699         changed it to instantiate an automatic StaticStringImpl (i.e. stack allocated) to
1700         confirm that the test will detect a regression.  Unfortunately, I forgot to
1701         change it back to using MAKE_STATIC_STRING_IMPL before I landed the test.
1702         This patch fixes that.
1703
1704         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1705         (TestWebKitAPI::neverDestroyedString):
1706
1707 2017-05-04  Ryan Haddad  <ryanhaddad@apple.com>
1708
1709         Disable failing API test WebKit2.ResizeWithHiddenContentDoesNotHang.
1710         https://bugs.webkit.org/show_bug.cgi?id=170195
1711
1712         Unreviewed test gardening.
1713
1714         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1715         (TEST):
1716
1717 2017-05-04  Don Olmstead  <don.olmstead@am.sony.com>
1718
1719         [Win] Remove redundant macros that are set in the CMake config
1720         https://bugs.webkit.org/show_bug.cgi?id=171571
1721
1722         Reviewed by Brent Fulgham.
1723
1724         * DumpRenderTree/config.h:
1725         * MiniBrowser/win/stdafx.h:
1726         * TestWebKitAPI/config.h:
1727
1728 2017-05-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
1729
1730         Add testRunner.display() to force displaying the web page for testing
1731         https://bugs.webkit.org/show_bug.cgi?id=171694
1732
1733         Reviewed by Simon Fraser.
1734
1735         Unlike testRunner.displayAndTrackRepaints(), this new function forces 
1736         drawing the web page but without track repaints.
1737
1738         * DumpRenderTree/TestRunner.cpp:
1739         (displayCallback):
1740         (TestRunner::staticFunctions):
1741         * DumpRenderTree/TestRunner.h:
1742         * DumpRenderTree/mac/TestRunnerMac.mm:
1743         (TestRunner::display):
1744         * DumpRenderTree/win/TestRunnerWin.cpp:
1745         (TestRunner::display):
1746         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1747         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1748         (WTR::TestRunner::display):
1749         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1750
1751 2017-05-04  Mark Lam  <mark.lam@apple.com>
1752
1753         NeverDestroyed<String>(ASCIILiteral(...)) is not thread safe.
1754         https://bugs.webkit.org/show_bug.cgi?id=171586
1755         <rdar://problem/31873190>
1756
1757         Reviewed by Yusuke Suzuki.
1758
1759         API test for exercising StaticStringImpl and the MAKE_STATIC_STRING_IMPL macro.
1760
1761         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1762         (TestWebKitAPI::neverDestroyedString):
1763         (TestWebKitAPI::getNeverDestroyedStringAtStackDepth):
1764         (TestWebKitAPI::TEST):
1765
1766 2017-05-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1767
1768         [WK2] Add support for keeping the selection in a focused editable element when dragging begins
1769         https://bugs.webkit.org/show_bug.cgi?id=171585
1770         <rdar://problem/31544320>
1771
1772         Reviewed by Beth Dakin and Zalan Bujtas.
1773
1774         Adds 1 new unit test and tweaks existing tests to check that when first responder status is lost after beginning
1775         a drag while editing, content is still moved (and not copied) when performing data interaction on a different
1776         element. ContentEditableMoveParagraphs checks that content can be shifted within a single element via a move
1777         operation rather than a copy.
1778
1779         See WebCore ChangeLog for more details.
1780
1781         Tests:  DataInteractionSimulator.ContentEditableToContentEditable
1782                 DataInteractionSimulator.ContentEditableToTextarea
1783                 DataInteractionSimulator.ContentEditableMoveParagraphs
1784                 DataInteractionSimulator.TextAreaToInput
1785
1786         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1787         * TestWebKitAPI/Tests/WebKit2Cocoa/two-paragraph-contenteditable.html: Added.
1788         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1789         (TestWebKitAPI::TEST):
1790         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1791         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1792         (-[DataInteractionSimulator initWithWebView:]):
1793         (-[DataInteractionSimulator dealloc]):
1794         (-[DataInteractionSimulator _advanceProgress]):
1795         (-[DataInteractionSimulator waitForInputSession]):
1796         (-[DataInteractionSimulator _webView:focusShouldStartInputSession:]):
1797         (-[DataInteractionSimulator _webView:didStartInputSession:]):
1798
1799 2017-05-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
1800
1801         Rename TestRunner.display() to TestRunner::displayAndTrackRepaints()
1802         https://bugs.webkit.org/show_bug.cgi?id=171641
1803
1804         Reviewed by Simon Fraser.
1805
1806         The plan is to add back the TestRunner.display() which does the display
1807         only without track repaints.
1808
1809         * DumpRenderTree/DumpRenderTree.h:
1810         * DumpRenderTree/TestRunner.cpp:
1811         (displayAndTrackRepaintsCallback):
1812         (TestRunner::staticFunctions):
1813         (displayCallback): Deleted.
1814         (displayInvalidatedRegionCallback): Deleted.
1815         * DumpRenderTree/TestRunner.h:
1816         * DumpRenderTree/mac/DumpRenderTree.mm:
1817         (displayWebView):
1818         (displayAndTrackRepaintsWebView):
1819         * DumpRenderTree/mac/TestRunnerMac.mm:
1820         (TestRunner::displayAndTrackRepaints):
1821         (TestRunner::display): Deleted.
1822         * DumpRenderTree/win/TestRunnerWin.cpp:
1823         (TestRunner::displayAndTrackRepaints):
1824         (TestRunner::display): Deleted.
1825         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1826         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1827         (WTR::TestRunner::displayAndTrackRepaints):
1828         (WTR::TestRunner::display): Deleted.
1829         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1830
1831 2017-05-04  Brady Eidson  <beidson@apple.com>
1832
1833         [ios-simulator] API test WebKit2.WebsiteDataStoreCustomPaths is failing.
1834         https://bugs.webkit.org/show_bug.cgi?id=171513
1835
1836         Unreviewed gardening.
1837
1838         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1839         (TEST): Skip the failing parts of the test on iOS for now.
1840
1841 2017-05-03  Jonathan Bedard  <jbedard@apple.com>
1842
1843         Make ImageDiff stand-alone
1844         https://bugs.webkit.org/show_bug.cgi?id=168939
1845
1846         Reviewed by David Kilzer.
1847
1848         Create ImageDiff without dependencies on bmalloc and WTF so that it exists as a
1849         stand-alone project. Note that this change does not eliminate the ImageDiff inside
1850         the DumpRenderTree project.
1851
1852         * ImageDiff/ImageDiff.xcodeproj: Added.
1853         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj: Added.
1854         * ImageDiff/Makefile: Use ImageDiff project.
1855         * ImageDiff/PlatformMac.cmake: Added.
1856         * ImageDiff/PlatformWin.cmake: Added.
1857         * ImageDiff/cg: Added.
1858         * ImageDiff/cg/Configurations: Added.
1859         * ImageDiff/cg/Configurations/Base.xcconfig: Copied from Tools/DumpRenderTree/mac/Configurations/Base.xcconfig.
1860         * ImageDiff/cg/Configurations/DebugRelease.xcconfig: Copied from Tools/DumpRenderTree/mac/Configurations/DebugRelease.xcconfig.
1861         * ImageDiff/cg/Configurations/ImageDiff.xcconfig: Copied from Tools/DumpRenderTree/mac/Configurations/ImageDiff.xcconfig.
1862         * ImageDiff/cg/ImageDiff.cpp: Copied from Tools/DumpRenderTree/cg/ImageDiffCG.cpp.
1863         (createImageFromStdin): Stop using RetainPtr.
1864         (createDifferenceImage): Ditto.
1865         (main): Ditto.
1866         * Scripts/build-imagediff: Stop building WTF and bmalloc.
1867
1868 2017-05-04  Sam Weinig  <sam@webkit.org>
1869
1870         Remove support for legacy Notifications
1871         https://bugs.webkit.org/show_bug.cgi?id=171487
1872
1873         Reviewed by Jon Lee.
1874
1875         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1876         (DRTDesktopNotificationPresenter::checkNotificationPermission):
1877         * Scripts/webkitperl/FeatureList.pm:
1878         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1879         Remove use and definition of ENABLE_LEGACY_NOTIFICATIONS.
1880
1881 2017-05-04  Andy Estes  <aestes@apple.com>
1882
1883         Give +testwebkitapi_configurationWithTestPlugInClassName: a shorter name
1884         https://bugs.webkit.org/show_bug.cgi?id=171673
1885
1886         Reviewed by Dan Bernstein.
1887
1888         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm:
1889         (TEST):
1890         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
1891         (TEST):
1892         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
1893         (TEST):
1894         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
1895         (TEST):
1896         * TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresource.mm:
1897         (TEST):
1898         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
1899         (configurationWithContentFilterSettings):
1900         (-[LazilyLoadPlatformFrameworksController init]):
1901         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1902         (TEST):
1903         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptions.mm:
1904         (runTestWithWidth):
1905         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentWorld.mm:
1906         (TEST):
1907         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1908         (TestWebKitAPI::TEST):
1909         * TestWebKitAPI/WKWebViewConfigurationExtras.h:
1910         * TestWebKitAPI/WKWebViewConfigurationExtras.mm:
1911         (+[WKWebViewConfiguration _test_configurationWithTestPlugInClassName:]):
1912         (+[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]): Renamed to
1913         +_test_configurationWithTestPlugInClassName:
1914
1915 2017-05-04  Eric Carlson  <eric.carlson@apple.com>
1916
1917         [MediaStream] Allow host application to enable/disable media capture
1918         https://bugs.webkit.org/show_bug.cgi?id=171292
1919         <rdar://problem/31821492>
1920
1921         Reviewed by Jer Noble.
1922
1923         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1924         * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm: Added.
1925         (-[UserMediaMessageHandler userContentController:didReceiveScriptMessage:]):
1926         (-[UserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1927         (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1928         (MediaCaptureDisabledTest::SetUp):
1929         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
1930         (TEST_F):
1931         * TestWebKitAPI/Tests/WebKit2Cocoa/disableGetUserMedia.html: Added.
1932
1933 2017-05-04  Caio Lima  <ticaiolima@gmail.com>
1934
1935         Unreviewed, Adding self to contributors.json
1936
1937         * Scripts/webkitpy/common/config/contributors.json: Added name.
1938
1939 2017-05-04  Konstantin Tokarev  <annulen@yandex.ru>
1940
1941         Fix compilation with ICU 59.1
1942         https://bugs.webkit.org/show_bug.cgi?id=171612
1943
1944         Reviewed by Mark Lam.
1945
1946         ICU 59.1 has broken source compatibility. Now it defines UChar as
1947         char16_t, which does not allow automatic type conversion from unsigned
1948         short in C++ code.
1949
1950         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
1951         (UIScriptContext::tryToCompleteUIScriptForCurrentParentCallback):
1952
1953 2017-05-04  Andy Estes  <aestes@apple.com>
1954
1955         [Cocoa] Add an optional width parameter to -[WKWebProcessPlugInNodeHandle renderedImageWithOptions:]
1956         https://bugs.webkit.org/show_bug.cgi?id=171646
1957         <rdar://problem/30306321>
1958
1959         Reviewed by Tim Horton.
1960
1961         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptions.mm:
1962         (runTestWithWidth):
1963         (TEST):
1964         (-[RenderedImageWithOptionsObject didRenderImageWithSize:]): Deleted.
1965         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptionsPlugIn.mm:
1966         (-[RenderedImageWithOptionsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1967         (-[RenderedImageWithOptionsPlugIn webProcessPlugInBrowserContextController:didFinishLoadForFrame:]):
1968         (-[RenderedImageWithOptionsPlugIn renderImageWithWidth:completionHandler:]):
1969         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptionsProtocol.h:
1970
1971 2017-05-04  Adrian Perez de Castro  <aperez@igalia.com>
1972
1973         [GTK] Fontconfig 2.11.2 in JHBuild does not build with glibc 2.25+ or gperf 3.1+
1974         https://bugs.webkit.org/show_bug.cgi?id=171649
1975
1976         Reviewed by Carlos Garcia Campos.
1977
1978         Add two patches picked from the upstream repository to fix building of
1979         the Fontconfig module in JHBuild. Additionally, this needed a patch to
1980         add "autogen.sh" as it is not included in release tarballs. Also:
1981         building the module with srcdir!=builddir prevents "fcobjshash.gperf"
1982         being regenerated (which is needed) so this is disabled for the
1983         Fontconfig module.
1984
1985         * gtk/jhbuild.modules:
1986         * gtk/patches/fontconfig-2.11.1-add-autogen.patch: Added.
1987         * gtk/patches/fontconfig-Avoid-conflicts-with-integer-width-macros-from-TS-18661-1-2014.patch: Added.
1988         * gtk/patches/fontconfig-Fix-the-build-issue-with-gperf-3.1.patch: Added.
1989
1990 2017-05-04  Commit Queue  <commit-queue@webkit.org>
1991
1992         Unreviewed, rolling out r216172.
1993         https://bugs.webkit.org/show_bug.cgi?id=171654
1994
1995         FTBFS for iOS due to missing WebPageProxy::stopMediaCapture()
1996         implementation. (Requested by ddkilzer on #webkit).
1997
1998         Reverted changeset:
1999
2000         "[MediaStream] Allow host application to enable/disable media
2001         capture"
2002         https://bugs.webkit.org/show_bug.cgi?id=171292
2003         http://trac.webkit.org/changeset/216172
2004
2005 2017-05-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2006
2007         [GTK] Bump GStreamer version to 1.10.4 in jhbuild
2008         https://bugs.webkit.org/show_bug.cgi?id=171595
2009
2010         Reviewed by Xabier Rodriguez-Calvar.
2011
2012         * gtk/jhbuild.modules:
2013         * gtk/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Removed.
2014         * gtk/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Removed.
2015         * gtk/patches/gst-plugins-good-0001-rtpbin-pipeline-gets-an-EOS-when-any-rtpsources-byes.patch: Removed.
2016         * gtk/patches/gst-plugins-good-0002-rtpbin-avoid-generating-errors-when-rtcp-messages-ar.patch: Removed.
2017         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch:
2018         * gtk/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
2019         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
2020
2021 2017-05-03  Saam Barati  <sbarati@apple.com>
2022
2023         How we build polymorphic cases is wrong when making a call from Wasm
2024         https://bugs.webkit.org/show_bug.cgi?id=171527
2025
2026         Reviewed by JF Bastien.
2027
2028         * Scripts/run-jsc-stress-tests:
2029
2030 2017-05-03  Eric Carlson  <eric.carlson@apple.com>
2031
2032         [MediaStream] Allow host application to enable/disable media capture
2033         https://bugs.webkit.org/show_bug.cgi?id=171292
2034         <rdar://problem/31821492>
2035
2036         Reviewed by Jer Noble.
2037
2038         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2039         * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm: Added.
2040         (-[UserMediaMessageHandler userContentController:didReceiveScriptMessage:]):
2041         (-[UserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
2042         (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
2043         (MediaCaptureDisabledTest::SetUp):
2044         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
2045         (TEST_F):
2046         * TestWebKitAPI/Tests/WebKit2Cocoa/disableGetUserMedia.html: Added.
2047
2048 2017-05-03  John Wilander  <wilander@apple.com>
2049
2050         Resource Load Statistics: Remove all statistics for modifiedSince website data removals
2051         https://bugs.webkit.org/show_bug.cgi?id=171584
2052         <rdar://problem/24702576>
2053
2054         Reviewed by Brent Fulgham.
2055
2056         New function to call the clear function that takes a modifiedSince parameter.
2057
2058         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2059         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2060         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
2061         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2062         * WebKitTestRunner/TestController.cpp:
2063         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
2064         * WebKitTestRunner/TestController.h:
2065         * WebKitTestRunner/TestInvocation.cpp:
2066         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2067
2068 2017-05-03  Commit Queue  <commit-queue@webkit.org>
2069
2070         Unreviewed, rolling out r216160 and r216161.
2071         https://bugs.webkit.org/show_bug.cgi?id=171640
2072
2073         These changes broke the iOS build. (Requested by mlewis13 on
2074         #webkit).
2075
2076         Reverted changesets:
2077
2078         "[MediaStream] Allow host application to enable/disable media
2079         capture"
2080         https://bugs.webkit.org/show_bug.cgi?id=171292
2081         http://trac.webkit.org/changeset/216160
2082
2083         "[MediaStream] Allow host application to enable/disable media
2084         capture"
2085         https://bugs.webkit.org/show_bug.cgi?id=171292
2086         http://trac.webkit.org/changeset/216161
2087
2088 2017-05-03  Eric Carlson  <eric.carlson@apple.com>
2089
2090         [MediaStream] Allow host application to enable/disable media capture
2091         https://bugs.webkit.org/show_bug.cgi?id=171292
2092         <rdar://problem/31821492>
2093
2094         Reviewed by Jer Noble.
2095
2096         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2097         * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm: Added.
2098         (-[UserMediaMessageHandler userContentController:didReceiveScriptMessage:]):
2099         (-[UserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
2100         (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
2101         (MediaCaptureDisabledTest::SetUp):
2102         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
2103         (TEST_F):
2104         * TestWebKitAPI/Tests/WebKit2Cocoa/disableGetUserMedia.html: Added.
2105
2106 2017-04-26  Jiewen Tan  <jiewen_tan@apple.com>
2107
2108         [WebCrypto] Add an api test for testing wrapping/unwrapping serialized crypto keys
2109         https://bugs.webkit.org/show_bug.cgi?id=171350
2110         <rdar://problem/28600836>
2111
2112         Patched by Brady Eidson.
2113
2114         Reviewed by Brent Fulgham.
2115
2116         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2117         * TestWebKitAPI/Tests/WebKit2/NavigationClientDefaultCrypto.cpp: Added.
2118         (TestWebKitAPI::runJavaScriptAlert):
2119         (TestWebKitAPI::decidePolicyForNavigationAction):
2120         (TestWebKitAPI::decidePolicyForNavigationResponse):
2121         (TestWebKitAPI::TEST):
2122         * TestWebKitAPI/Tests/WebKit2/navigation-client-default-crypto.html: Added.
2123
2124 2017-05-03  Simon Fraser  <simon.fraser@apple.com>
2125
2126         Have WKWebView call _updateVisibleContentRects for the current transaction if possible, rather than always delaying
2127         https://bugs.webkit.org/show_bug.cgi?id=171619
2128         https://bugs.webkit.org/show_bug.cgi?id=170195
2129
2130         Reviewed by Tim Horton.
2131
2132         Re-enable WebKit2.ResizeWithHiddenContentDoesNotHang.
2133
2134         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
2135         (TEST):
2136
2137 2017-05-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2138
2139         YouTube user agent quirk breaks new YouTube
2140         https://bugs.webkit.org/show_bug.cgi?id=171603
2141
2142         Reviewed by Carlos Garcia Campos.
2143
2144         Remove the YouTube quirk test.
2145
2146         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2147         (TestWebKitAPI::TEST):
2148
2149 2017-05-03  Said Abou-Hallawa  <sabouhallawa@apple.com>
2150
2151         Async image decoding should be disabled for snapshots, printing and preview
2152         https://bugs.webkit.org/show_bug.cgi?id=171467
2153
2154         Reviewed by Simon Fraser.
2155
2156         Add a API test for snapshotting with large images. Ensure the images are
2157         drawn correctly which implies they should have been synchronously decoded.
2158
2159         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2160         * TestWebKitAPI/Tests/WebKit2/large-red-square-image.html: Added.
2161         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewSnapshot.mm:
2162         (TEST):
2163
2164 2017-05-03  Chris Dumez  <cdumez@apple.com>
2165
2166         [WK2] Extend processDidCrash delegate to let the client know the reason for the crash
2167         https://bugs.webkit.org/show_bug.cgi?id=171565
2168         <rdar://problem/31204417>
2169
2170         Reviewed by Sam Weinig.
2171
2172         Add API test coverage.
2173
2174         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2175         * TestWebKitAPI/Tests/WebKit2/ProcessDidCrashWithReason.cpp: Added.
2176         (TestWebKitAPI::didFinishNavigation):
2177         (TestWebKitAPI::didCrashWithReason):
2178         (TestWebKitAPI::TEST):
2179
2180 2017-05-02  David Kilzer  <ddkilzer@apple.com>
2181
2182         check-webkit-style should also keep js-test-post[-async].js in sync
2183         <https://webkit.org/b/171568>
2184
2185         Reviewed by Joseph Pecoraro.
2186
2187         * Scripts/webkitpy/style/checker.py:
2188         (_NEVER_SKIPPED_JS_FILES): Add new list that just contains
2189         JavaScript files not to be skipped.
2190         (_NEVER_SKIPPED_FILES): Update to use _NEVER_SKIPPED_JS_FILES.
2191         (CheckerDispatcher._create_checker): Update to use
2192         _NEVER_SKIPPED_JS_FILES.
2193
2194         * Scripts/webkitpy/style/checkers/jstest.py:
2195         (ALL_JS_TEST_FUNCTION_FILES): Rename from ALL_JS_TEST_FILES.
2196         This is the list of files containing functions that need to be
2197         kept in sync.
2198         (KEEP_JS_TEST_FILES_IN_SYNC): Change to list-of-lists format so
2199         we can keep more sets of files in sync between
2200         LayoutTests/resources and LayoutTests/http/tests/resources.
2201         (JSTestChecker.check): Update to use KEEP_JS_TEST_FILES_IN_SYNC
2202         as list of lists.  Update for ALL_JS_TEST_FUNCTION_FILES rename.
2203         (JSTestChecker.check_js_test_files): Add 'file_group' argument
2204         for list of files to check instead of using
2205         KEEP_JS_TEST_FILES_IN_SYNC.
2206         (JSTestChecker.check_js_test_functions): Update for
2207         ALL_JS_TEST_FUNCTION_FILES rename.
2208
2209         * Scripts/webkitpy/style/checkers/jstest_unittest.py:
2210         (JSTestCheckerTestCase):
2211         (JSTestCheckerTestCase.test_map_functions_to_dict):
2212         - Add test case for map_functions_to_dict() in jstest.py.
2213
2214 2017-05-02  Aakash Jain  <aakash_jain@apple.com>
2215
2216         ews should indicate in logs when it fails to fetch the attachment
2217         https://bugs.webkit.org/show_bug.cgi?id=171583
2218
2219         Reviewed by Alexey Proskuryakov.
2220
2221         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2222         (Bugzilla.fetch_attachment): Added log statement.
2223
2224 2017-05-02  David Kilzer  <ddkilzer@apple.com>
2225
2226         Rolling out jstest_unittest.py so it can be reviewed
2227
2228         Follow-up fix for:
2229         check-webkit-style should keep JavaScript test functions in sync
2230         <https://webkit.org/b/171424>
2231
2232         * Scripts/webkitpy/style/checkers/jstest_unittest.py: Remove.
2233
2234 2017-05-02  David Kilzer  <ddkilzer@apple.com>
2235
2236         check-webkit-style should keep JavaScript test functions in sync
2237         <https://webkit.org/b/171424>
2238
2239         Reviewed by Joseph Pecoraro.
2240
2241         Add a new JSTestChecker for check-webkit-style that keeps these
2242         two files in sync:
2243
2244             LayoutTests/http/tests/resources/js-test-pre.js
2245             LayoutTests/resources/js-test-pre.js
2246
2247         And keeps implementations of shouldBe(), shouldNotBe(),
2248         shouldNotThrow(), and shouldThrow() in sync across multiple
2249         files (with the ability to add more functions later):
2250
2251             JSTests/stress/resources/standalone-pre.js
2252             LayoutTests/http/tests/resources/js-test-pre.js
2253             LayoutTests/resources/js-test-pre.js
2254             LayoutTests/resources/js-test.js
2255             LayoutTests/resources/standalone-pre.js
2256
2257         * Scripts/webkitpy/style/checker.py: Remove unused import.  Add
2258         import for JSTestChecker.
2259         (_NEVER_SKIPPED_FILES): Add array of file names that are never
2260         skipped regardless of other rules.
2261         (_all_categories): Add JSTestChecker categories.
2262         (CheckerDispatcher.should_skip_without_warning): Use
2263         _NEVER_SKIPPED_FILES.
2264         (CheckerDispatcher._create_checker): Return JSTestChecker for
2265         the files to check.
2266
2267         * Scripts/webkitpy/style/checkers/jstest.py: Add.
2268         (map_functions_to_dict): Parse JavaScript source by splitting on
2269         /^function\s+/ regex.  This is good enough for the sanity checks
2270         to keep function implementations in sync.
2271         (strip_blank_lines_and_comments): Strips blank lines and lines
2272         with comments from the end of a chunk of text representing a
2273         function.
2274         (JSTestChecker): New checker.
2275         (JSTestChecker.__init__):
2276         (JSTestChecker.check):
2277         (JSTestChecker.check_js_test_files): Keeps whole files in sync.
2278         (JSTestChecker.check_js_test_functions): Keeps individual
2279         functions in sync.
2280
2281         * Scripts/webkitpy/style/checkers/jstest_unittest.py: Add test
2282         case.
2283         (JSTestTestCase):
2284         (JSTestTestCase.test_map_functions_to_dict):
2285
2286 2017-05-02  Joanmarie Diggs  <jdiggs@igalia.com>
2287
2288         AX: Update implementation of aria-orientation
2289         https://bugs.webkit.org/show_bug.cgi?id=171166
2290
2291         Reviewed by Chris Fleizach.
2292
2293         Return "AXUnknownOrientation" when ATK_STATE_VERTICAL and ATK_STATE_HORIZONTAL
2294         are both absent from the state set. Before we were returning an empty string
2295         which was not consistent with what the Mac port does, thus making shared tests
2296         harder.
2297
2298         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2299         (WTR::AccessibilityUIElement::orientation):
2300
2301 2017-05-01  David Kilzer  <ddkilzer@apple.com>
2302
2303         Stop using sprintf() in JavaScriptCore debugger
2304         <https://webkit.org/b/171512>
2305
2306         Reviewed by Keith Miller.
2307
2308         * Scripts/webkitpy/style/checker.py:
2309         (_PATH_RULES_SPECIFIER): Ignore some formatting checkers since
2310         Source/JavaScriptCore/disassembler/udis86/ is generated code.
2311
2312 2017-05-01  Timothy Horton  <timothy_horton@apple.com>
2313
2314         Expose viewport-fit instead of clip-to-safe-area
2315         https://bugs.webkit.org/show_bug.cgi?id=171503
2316         <rdar://problem/31918249>
2317
2318         Reviewed by Simon Fraser.
2319
2320         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2321         (WTR::UIScriptController::setSafeAreaInsets):
2322         (WTR::UIScriptController::setObscuredInsets): Deleted.
2323         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2324         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2325         (WTR::UIScriptController::setSafeAreaInsets):
2326         (WTR::UIScriptController::setObscuredInsets): Deleted.
2327         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2328         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2329         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2330         (-[TestRunnerWKWebView setOverrideSafeAreaInsets:]):
2331         (-[TestRunnerWKWebView _safeAreaInsetsForFrame:inSuperview:]):
2332         * WebKitTestRunner/ios/TestControllerIOS.mm:
2333         (WTR::TestController::platformResetStateToConsistentValues):
2334         * WebKitTestRunner/ios/UIKitSPI.h:
2335         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2336         (WTR::UIScriptController::setSafeAreaInsets):
2337         (WTR::UIScriptController::setObscuredInsets): Deleted.
2338         Expose a safe area inset setter instead of obscured insets.
2339
2340 2017-05-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2341
2342         Unreviewed, fix the build on a new internal SDK
2343
2344         Replace usages of NSItemProviderRepresentationVisibilityAll with
2345         UIItemProviderRepresentationOptionsVisibilityAll.
2346
2347         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2348         (-[UIItemProvider registerDataRepresentationForTypeIdentifier:withData:]):
2349         (TestWebKitAPI::TEST):
2350
2351 2017-05-01  David Kilzer  <ddkilzer@apple.com>
2352
2353         [Cocoa] Replace uses of [get…Class() alloc] in TestWebKitAPI
2354         <https://webkit.org/b/171493>
2355
2356         Reviewed by Dan Bernstein.
2357
2358         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
2359         Remove UIKit soft-link since TestWebKitAPI links to
2360         UIKit.framework.
2361         (TestWebKitAPI::WebKit1_AudioSessionCategoryIOS_Test): Use
2362         UIWindow and UIWebView classes directly.
2363         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2364         Remove UIKit soft-link since TestWebKitAPI links to
2365         UIKit.framework.
2366         (RequiresUserActionForPlaybackTest::createWebView): Use UIWindow
2367         class directly.
2368
2369 2017-05-01  Brady Eidson  <beidson@apple.com>
2370
2371         Update names in WKURLSchemeHandler/WKURLSchemeHandlerTask APIs.
2372         <rdar://problem/31824838> and https://bugs.webkit.org/show_bug.cgi?id=171508
2373
2374         Reviewed by Andy Estes.
2375
2376         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
2377         (-[SchemeHandler webView:startURLSchemeTask:]):
2378         (-[SchemeHandler webView:stopURLSchemeTask:]):
2379         (-[SchemeHandler webView:startTask:]): Deleted.
2380         (-[SchemeHandler webView:stopTask:]): Deleted.
2381
2382 2017-05-01  Jason Marcell  <jmarcell@apple.com>
2383
2384         Add a new function for getting the Git hash for a pure git directory.
2385         https://bugs.webkit.org/show_bug.cgi?id=171450
2386
2387         Reviewed by David Kilzer.
2388
2389         * Scripts/VCSUtils.pm:
2390         (gitHashForDirectory):
2391
2392 2017-05-01  Joanmarie Diggs  <jdiggs@igalia.com>
2393
2394         [ATK] Expose values of aria-rowcount, aria-colcount, aria-rowindex, aria-colindex, aria-rowspan, and aria-colspan as object attributes
2395         https://bugs.webkit.org/show_bug.cgi?id=171496
2396
2397         Reviewed by Chris Fleizach.
2398
2399         Add new attribute names so that the values of the object attributes can be tested.
2400
2401         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2402         (WTR::AccessibilityUIElement::numberAttributeValue):
2403
2404 2017-05-01  Beth Dakin  <bdakin@apple.com>
2405
2406         On-screen panel for candidate bar is in the wrong place when the caret is at the 
2407         start of a paragraph
2408         https://bugs.webkit.org/show_bug.cgi?id=171453
2409         -and corresponding-
2410         rdar://problem/29779764
2411
2412         Reviewed by Tim Horton.
2413
2414         This test hard-codes the y-coordinate for the expected candidateRect. 
2415         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
2416         (TEST):
2417
2418 2017-05-01  David Kilzer  <ddkilzer@apple.com>
2419
2420         check-webkit-style: Enable sprintf(), strcat(), strcpy() and printf() format checks
2421         <https://webkit.org/b/171494>
2422
2423         Reviewed by Brent Fulgham.
2424
2425         * Scripts/webkitpy/style/checkers/cpp.py:
2426         (check_language): Change categories for certain checkers from
2427         'runtime/printf' to 'security/printf' so they are no longer
2428         filtered.
2429         (CppChecker.categories): Add 'security/printf'.
2430         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2431         (CppStyleTest.test_insecure_string_operations): Add new test for
2432         sprintf(), strcat() and strcpy().
2433         (CppStyleTest.test_format_strings): Update test results for new
2434         'security/printf' category use.
2435
2436 2017-05-01  Joanmarie Diggs  <jdiggs@igalia.com>
2437
2438         AX: [GTK] Add support to query for aria-current
2439         https://bugs.webkit.org/show_bug.cgi?id=149016
2440
2441         Reviewed by Chris Fleizach.
2442
2443         Implement support for "AXARIACurrent" string attribute value.
2444
2445         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2446
2447 2017-05-01  David Kilzer  <ddkilzer@apple.com>
2448
2449         REGRESSION (r216000): test-webkitpy fails after adding new soft-linked class checker
2450
2451         Unreviewed.
2452
2453         Follow-up fix for:
2454         [Cocoa] Have check-webkit-style advise against use of [get…Class() alloc]
2455         https://bugs.webkit.org/show_bug.cgi?id=171486
2456
2457         * Scripts/webkitpy/style/checkers/cpp.py:
2458         (check_soft_link_class_alloc): Use (\w+) instead of ([^\s]+) to
2459         match and capture the function name.  The latter also mistakenly
2460         matches C-preprocessor directives.
2461         (CppChecker.categories): Add 'runtime/soft-linked-alloc', which
2462         is a requirement for the CppChecker class.
2463
2464 2017-05-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2465
2466         [GTK] Add automation session API
2467         https://bugs.webkit.org/show_bug.cgi?id=171428
2468
2469         Reviewed by Carlos Alberto Lopez Perez.
2470
2471         Add an automation mode to MiniBrowser using the new API and add a unit test too.
2472
2473         * MiniBrowser/gtk/BrowserWindow.c:
2474         (webViewTitleChanged):
2475         (webViewDecidePolicy):
2476         (newTabCallback):
2477         (openPrivateWindow):
2478         (browserWindowFinalize):
2479         (browser_window_init):
2480         (browser_window_get_or_create_web_view_for_automation):
2481         * MiniBrowser/gtk/BrowserWindow.h:
2482         * MiniBrowser/gtk/main.c:
2483         (createBrowserTab):
2484         (createWebViewForAutomationCallback):
2485         (automationStartedCallback):
2486         (main):
2487         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2488         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp: Added.
2489         (testAutomationSessionRequestSession):
2490         (beforeAll):
2491         (afterAll):
2492
2493 2017-04-30  Dan Bernstein  <mitz@apple.com>
2494
2495         [Cocoa] Have check-webkit-style advise against use of [get…Class() alloc]
2496         https://bugs.webkit.org/show_bug.cgi?id=171486
2497
2498         Reviewed by Sam Weinig.
2499
2500         * Scripts/webkitpy/style/checkers/cpp.py:
2501         (check_soft_link_class_alloc): Added. Looks for [get…Class() alloc] and suggests
2502           alloc…Instance() instead.
2503         (check_style): Invoke new check.
2504
2505 2017-04-30  Brady Eidson  <beidson@apple.com>
2506
2507         More fixing after r215991
2508         https://bugs.webkit.org/show_bug.cgi?id=171483
2509
2510         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2511         (TEST):
2512
2513 2017-04-30  Brady Eidson  <beidson@apple.com>
2514
2515         Updates to _WKWebsiteDataStoreConfiguration cookie storage location SPI.
2516         <rdar://problem/31906397> and https://bugs.webkit.org/show_bug.cgi?id=171483
2517
2518         Reviewed by Geoff Garen (and kind of Andy Estes).
2519
2520         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2521         (TEST):
2522
2523 2017-04-30  Joanmarie Diggs  <jdiggs@igalia.com>
2524
2525         [ATK] Implement support for aria-autocomplete
2526         https://bugs.webkit.org/show_bug.cgi?id=171167
2527
2528         Reviewed by Chris Fleizach.
2529
2530         Add "AXSupportsAutoCompletion" attribute so the presence of
2531         ATK_STATE_SUPPORTS_AUTOCOMPLETION can be tested.
2532
2533         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2534         (WTR::AccessibilityUIElement::boolAttributeValue):
2535
2536 2017-04-30  Joanmarie Diggs  <jdiggs@igalia.com>
2537
2538         [ATK] ARIA treegrid role should be exposed as ATK_ROLE_TREE_TABLE; not ATK_ROLE_TABLE
2539         https://bugs.webkit.org/show_bug.cgi?id=171170
2540
2541         Reviewed by Chris Fleizach.
2542
2543         Add "AXInterfaceTable" attribute to test which elements implement AtkTable.
2544
2545         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2546         (WTR::AccessibilityUIElement::boolAttributeValue):
2547
2548 2017-04-30  Joanmarie Diggs  <jdiggs@igalia.com>
2549
2550         [ATK] Emit object:state-changed:busy event when aria-busy value changes
2551         https://bugs.webkit.org/show_bug.cgi?id=171181
2552
2553         Reviewed by Chris Fleizach.
2554
2555         Add handler for AXElementBusyChanged notifications.
2556
2557         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2558
2559 2017-04-29  Aakash Jain  <aakash_jain@apple.com>
2560
2561         Use PEP8 style guide for raising exceptions in webkitpy.
2562         https://bugs.webkit.org/show_bug.cgi?id=171439
2563
2564         Reviewed by Daniel Bates.
2565
2566         As per https://www.python.org/dev/peps/pep-0008/
2567         "When raising an exception in Python 2, use raise ValueError('message') 
2568         instead of the older form raise ValueError, 'message'"
2569
2570         * Scripts/webkitpy/common/net/irc/ircbot.py: Using new style for raising exceptions.
2571         * Scripts/webkitpy/common/thread/messagepump.py: Same.
2572         * Scripts/webkitpy/tool/bot/queueengine.py: Same.
2573         * Scripts/webkitpy/tool/commands/queues.py: Same.
2574         * Scripts/webkitpy/tool/commands/stepsequence.py: Same.
2575         * Scripts/webkitpy/tool/multicommandtool.py: Same.
2576         * Scripts/webkitpy/tool/steps/abstractstep.py: Same.
2577
2578 2017-04-28  Simon Fraser  <simon.fraser@apple.com>
2579
2580         Add system trace points for Document::updateTouchEventRegions()
2581         https://bugs.webkit.org/show_bug.cgi?id=171470
2582         rdar://problem/31901239
2583
2584         Reviewed by Tim Horton.
2585
2586         Add trace markers for updateTouchEventRegions.
2587
2588         * Tracing/SystemTracePoints.plist:
2589
2590 2017-04-28  Jonathan Bedard  <jbedard@apple.com>
2591
2592         webkitpy: Add apple_additions to webkitpy to insert Internal tools
2593         https://bugs.webkit.org/show_bug.cgi?id=170461
2594         <rdar://problem/31433077>
2595
2596         Reviewed by Daniel Bates.
2597
2598         Allow a package to be pulled in by run-webkit-tests which provides an interface to
2599         run layout tests on an iOS device.  If this package is not available, throw an
2600         exception when attempting to run layout tests on an iOS device.
2601
2602         * Scripts/webkitpy/port/config.py:
2603         (apple_additions): Import apple_additions package.
2604         * Scripts/webkitpy/port/device.py:
2605         (Device.install_dylibs): Pass a directory with all the frameworks and dylibs to be
2606         installed on a device.
2607         (Device.prepare_for_testing): Pass a list of ports to forward from the device to the
2608         host, the bundle id of the app to be used for testing and a path to the layout test
2609         directory to be mounted on the device.
2610         (Device.finished_testing):
2611         * Scripts/webkitpy/port/factory.py:
2612         (platform_options): Add apple_additions platform options if apple_additions exists.
2613         * Scripts/webkitpy/port/ios.py:
2614         (IOSPort.setup_test_run): Install dylibs and frameworks on the device, pass ports
2615         to forward, the bundle ID of the testing app and the layout tests directory to
2616         each device.
2617         * Scripts/webkitpy/port/ios_device.py:
2618         (IOSDevicePort):
2619         (IOSDevicePort.default_child_processes): Query apple_additions for the number of child
2620         processes to be run.
2621         (IOSDevicePort.using_multiple_devices): Always assume multiple devices are used. When
2622         a single device is used, it is still accessed through an array.
2623         (IOSDevicePort._device_for_worker_number_map): Query apple_additions for the device
2624         for worker number map.
2625         (IOSDevicePort._driver_class): Query apple_additions for the test driver.
2626         (IOSDevicePort.determine_full_port_name): Use class variable over hard-coded string.
2627         (IOSDevicePort.check_for_leaks): No implementation for iOSDevicePort.
2628         (IOSDevicePort.look_for_new_crash_logs): Ditto.
2629         (IOSDevicePort.look_for_new_samples): Ditto.
2630         (IOSDevicePort.sample_process): Ditto.
2631         (IOSDevicePort._build_driver_flags): Use class variable over hard-coded string.
2632         (IOSDevicePort._create_devices): Check that devices are available for testing and check
2633         that we have enough devices for each child process.
2634         (IOSDevicePort.clean_up_test_run): Have apple_additions preform any needed clean up.
2635         * Scripts/webkitpy/port/ios_device_unittest.py:
2636         (IOSDeviceTest.test_operating_system):
2637         (IOSDeviceTest.test_spindump): Override method from DarwinTest.
2638         (IOSDeviceTest.test_sample_process): Ditto.
2639         (IOSDeviceTest.test_sample_process_exception): Ditto.
2640
2641 2017-04-28  Wenson Hsieh  <wenson_hsieh@apple.com>
2642
2643         Fix and re-enable data interaction unit tests
2644         https://bugs.webkit.org/show_bug.cgi?id=171446
2645         <rdar://problem/31820646>
2646
2647         Reviewed by Tim Horton.
2648
2649         Enables all DataInteractionTests, and adjusts file upload tests to no longer write to a temporary file before
2650         registering with the UIItemProvider, and instead just register data directly via
2651         -registerDataRepresentationForTypeIdentifier:visibility:loadHandler:.
2652
2653         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2654         (TestWebKitAPI::TEST):
2655         (temporaryURLForDataInteractionFileLoad): Deleted.
2656         (cleanUpDataInteractionTemporaryPath): Deleted.
2657         (-[UIItemProvider registerFileRepresentationForTypeIdentifier:withData:filename:]): Deleted.
2658         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2659         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2660
2661 2017-04-28  Brady Eidson  <beidson@apple.com>
2662
2663         Teach the DatabaseProcess to be fully SessionID aware
2664         https://bugs.webkit.org/show_bug.cgi?id=171451
2665
2666         Reviewed by Geoffrey Garen.
2667
2668         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2669
2670 2017-04-28  Jonathan Bedard  <jbedard@apple.com>
2671
2672         Unreviewed follow-up to r214705.
2673
2674         shut.copytree will fail if given a file as an argument instead of a directory.
2675
2676         * Scripts/webkitpy/common/system/filesystem.py:
2677         (FileSystem.copy_to_base_host): Use copytree when source is a directory and copyfile
2678         when source is a file.
2679         (FileSystem.copy_from_base_host): Ditto.
2680
2681 2017-04-28  Chris Dumez  <cdumez@apple.com>
2682
2683         Update DOMTokenList.replace() to match the latest DOM specification
2684         https://bugs.webkit.org/show_bug.cgi?id=171388
2685
2686         Reviewed by Alex Christensen.
2687
2688         Add API test coverage for new Vector API.
2689
2690         * TestWebKitAPI/Tests/WTF/Vector.cpp:
2691         (TestWebKitAPI::TEST):
2692
2693 2017-04-28  Jonathan Bedard  <jbedard@apple.com>
2694
2695         WebKitTestRunner/DumpRenderTree prevent device from sleeping
2696         https://bugs.webkit.org/show_bug.cgi?id=170731
2697
2698         Reviewed by Alex Christensen.
2699
2700         While running layout tests on a device, the device should not be put asleep.
2701
2702         * DumpRenderTree/mac/DumpRenderTree.mm:
2703         (dumpRenderTree): Disable idle timer.
2704         * WebKitTestRunner/ios/TestControllerIOS.mm:
2705         (WTR::TestController::platformInitialize): Ditto.
2706
2707 2017-04-28  Brady Eidson  <beidson@apple.com>
2708
2709         Start of support for multiple WebsiteDataStore/SessionIDs per process
2710         https://bugs.webkit.org/show_bug.cgi?id=171422
2711
2712         Reviewed by Geoffrey Garen.
2713
2714         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2715         (TEST):
2716
2717 2017-04-28  Youenn Fablet  <youenn@apple.com>
2718
2719         Adding a runtime flag specific to MediaDevices
2720         https://bugs.webkit.org/show_bug.cgi?id=171433
2721
2722         Reviewed by Geoffrey Garen.
2723
2724         Updating WTR and DRT as peer connection and media stream runtime flags are enabled by default.
2725         Setting media devices runtime flag to true for WTR and DRT.
2726
2727         * DumpRenderTree/mac/DumpRenderTree.mm:
2728         (enableExperimentalFeatures):
2729         (resetWebPreferencesToConsistentValues):
2730         * TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp:
2731         (TestWebKitAPI::TEST):
2732         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
2733         (TestWebKitAPI::TEST):
2734         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2735         (WTR::InjectedBundle::beginTesting):
2736         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2737         (WTR::TestRunner::setMediaDevicesEnabled):
2738         (WTR::TestRunner::setMediaStreamEnabled): Deleted.
2739         (WTR::TestRunner::setPeerConnectionEnabled): Deleted.
2740         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2741         * WebKitTestRunner/TestController.cpp:
2742         (WTR::TestController::resetPreferencesToConsistentValues):
2743
2744 2017-04-28  Dean Jackson  <dino@apple.com>
2745
2746         [WebGPU] Label MTLCommandQueues with a prefix for internal telemetry
2747         https://bugs.webkit.org/show_bug.cgi?id=171441
2748         <rdar://problem/31826915>
2749
2750         Reviewed by Tim Horton.
2751
2752         Add an API test for GPUCommandQueue, exercising creation
2753         and setting the label.
2754
2755         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2756         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Added.
2757         (TestWebKitAPI::TEST_F):
2758
2759 2017-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
2760
2761         [ATK] aria-modal="true" should be exposed via ATK_STATE_MODAL
2762         https://bugs.webkit.org/show_bug.cgi?id=171188
2763
2764         Reviewed by Chris Fleizach.
2765
2766         Add "AXModal" attribute string so that we can test the state's exposure.
2767
2768         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2769         (WTR::AccessibilityUIElement::boolAttributeValue):
2770
2771 2017-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
2772
2773         [ATK] GridCellRole should implement AtkTableCell (regression?)
2774         https://bugs.webkit.org/show_bug.cgi?id=171179
2775
2776         Reviewed by Chris Fleizach.
2777
2778         Add new "AXInterfaceTableCell" attribute so that we can test whether or
2779         not there is an implementation of AtkTableCell (i.e. without risking false
2780         negatives from bugs in the interface's implementation).
2781
2782         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2783         (WTR::AccessibilityUIElement::boolAttributeValue):
2784
2785 2017-04-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2786
2787         Move UUID from WebCore/platform to WTF
2788         https://bugs.webkit.org/show_bug.cgi?id=171372
2789
2790         Reviewed by Michael Catanzaro.
2791
2792         * WebKitTestRunner/TestController.cpp:
2793
2794 2017-04-27  Alex Christensen  <achristensen@webkit.org>
2795
2796         Add stub SPI for setting cookie storage path on _WKWebsiteDataStoreConfiguration
2797         https://bugs.webkit.org/show_bug.cgi?id=171399
2798
2799         Reviewed by Brady Eidson.
2800
2801         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.html:
2802         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2803         (TEST):
2804
2805 2017-04-27  Ryan Haddad  <ryanhaddad@apple.com>
2806
2807         Disable flaky API test WKWebView.SetOverrideContentSecurityPolicyWithEmptyStringForPageWithCSP.
2808         https://bugs.webkit.org/show_bug.cgi?id=167914
2809
2810         Unreviewed test gardening.
2811
2812         * TestWebKitAPI/Tests/WebKit2Cocoa/OverrideContentSecurityPolicy.mm:
2813         (TEST):
2814
2815 2017-04-26  Saam Barati  <sbarati@apple.com>
2816
2817         Add some more testing modes for Wasm tests now that we have tier up
2818         https://bugs.webkit.org/show_bug.cgi?id=171360
2819
2820         Reviewed by Keith Miller.
2821
2822         Lets enable the FTL on all Wasm tests. Let's also run each
2823         test with and without CJIT.
2824
2825         * Scripts/run-jsc-stress-tests:
2826
2827 2017-04-26  Aakash Jain  <aakash_jain@apple.com>
2828
2829         JSC EWS Patch Relevance skips few JSC scripts
2830         https://bugs.webkit.org/show_bug.cgi?id=171351
2831
2832         Reviewed by Alexey Proskuryakov.
2833
2834         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
2835         (CheckPatchRelevance): Added few jsc related scripts.
2836
2837 2017-04-26  Youenn Fablet  <youenn@apple.com>
2838
2839         Test importer should delete obsolete files based on w3c-import.log
2840         https://bugs.webkit.org/show_bug.cgi?id=171348
2841
2842         Reviewed by Chris Dumez.
2843
2844         * Scripts/webkitpy/w3c/test_importer.py:
2845         (TestImporter.do_import): Removing dangling -expected.txt files in regular import mode.
2846         (TestImporter.remove_deleted_files): Fixing according w3c-import.log current format.
2847         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2848         (test_remove_obsolete_content):
2849
2850 2017-04-26  Jonathan Bedard  <jbedard@apple.com>
2851
2852         REGRESSION (r213926): We're sometimes trying to start WebKitTestRunner without proper DYLD variables
2853         <rdar://problem/31816459>
2854
2855         Unreviewed infrastructure fix.
2856
2857         Some of our iOS Simulator bots are slow and will register crashes due to an incorrect
2858         DYLD_FRAMEWORK_PATH when installing an app.
2859
2860         * Scripts/webkitpy/port/ios.py:
2861         (IOSPort.setup_test_run): Pass DYLD_FRAMEWORK_PATH to app on install.
2862
2863 2017-04-26  Joanmarie Diggs  <jdiggs@igalia.com>
2864
2865         [ATK] Elements with a defined, non-false value for aria-current should expose ATK_STATE_ACTIVE
2866         https://bugs.webkit.org/show_bug.cgi?id=171163
2867
2868         Reviewed by Chris Fleizach.
2869
2870         Add support for state-change notifications for ATK_STATE_ACTIVE.
2871
2872         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2873
2874 2017-04-26  Jonathan Bedard  <jbedard@apple.com>
2875
2876         webkitpy: Teardown iOS Simulators on exit if managed Simulators are still running
2877         https://bugs.webkit.org/show_bug.cgi?id=171293
2878
2879         Reviewed by Aakash Jain.
2880
2881         We should make an effort to teardown simulators which we booted even when an exception is
2882         thrown while booting. Make some IOSSimulatorPort functions into static methods and register
2883         one of these functions to be run at exit to ensure any devices webkitpy is managing gets
2884         torn down.
2885
2886         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2887         (Manager._set_up_run): Rely on exit handlers to teardown, not exceptions.
2888         * Scripts/webkitpy/port/ios_simulator.py:
2889         (IOSSimulatorPort._teardown_managed_simulators): Function run on exit which will kill all
2890         iOS simulators and teardown and managed devices.
2891         (IOSSimulatorPort._create_simulators): Register teardown function.
2892         (IOSSimulatorPort.clean_up_test_run): Move device teardown to _teardown_managed_simulators.
2893         (IOSSimulatorPort._remove_device): Deleted.
2894
2895 2017-04-26  Joanmarie Diggs  <jdiggs@igalia.com>
2896
2897         [ATK] Implement support for new ARIA 1.1 values of aria-haspopup
2898         https://bugs.webkit.org/show_bug.cgi?id=171164
2899
2900         Reviewed by Chris Fleizach.
2901
2902         hasPopup() should return whether or not ATK_STATE_HAS_POPUP is in the
2903         AtkStateSet; not what is found in the AtkObject's attributes.
2904
2905         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2906         (WTR::AccessibilityUIElement::hasPopup):
2907
2908 2017-04-25  Alex Christensen  <achristensen@webkit.org>
2909
2910         Encoded filename should be decoded for WKContentExtension.identifier
2911         https://bugs.webkit.org/show_bug.cgi?id=171316
2912
2913         Reviewed by Andy Estes.
2914
2915         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2916         * TestWebKitAPI/Tests/WebKit2Cocoa/WKContentExtensionStore.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKUserContentExtensionStore.mm.
2917         (TEST_F):
2918         * TestWebKitAPI/Tests/WebKit2Cocoa/WKUserContentExtensionStore.mm: Removed.
2919
2920 2017-04-25  Alex Christensen  <achristensen@webkit.org>
2921
2922         REGRESSION(206450): WebKit2PlatformMouseEvent m_modifierFlags not set
2923         https://bugs.webkit.org/show_bug.cgi?id=171297
2924         <rdar://problem/31530719>
2925
2926         Reviewed by Geoffrey Garen.
2927
2928         * TestWebKitAPI/PlatformWebView.h:
2929         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2930         * TestWebKitAPI/Tests/WebKit2/EventModifiers.cpp: Added.
2931         (TestWebKitAPI::didFinishLoadForFrame):
2932         (TestWebKitAPI::mouseDidMoveOverElement):
2933         (TestWebKitAPI::setClients):
2934         (TestWebKitAPI::TEST):
2935         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2936         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2937         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
2938
2939 2017-04-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2940
2941         Unreviewed, temporarily disable the data interaction unit tests.
2942
2943         The API around data interaction will change significantly in the near future, and
2944         these tests will begin to fail. These will be reenabled once the bots are on an SDK
2945         that supports the updated data interaction API.
2946
2947         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2948         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2949         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2950
2951 2017-04-25  Brent Fulgham  <bfulgham@apple.com>
2952
2953         Limit allowed size of document.title to avoid locking WebKit clients
2954         https://bugs.webkit.org/show_bug.cgi?id=165113
2955         <rdar://problem/28324389>
2956
2957         Reviewed by Darin Adler.
2958
2959         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2960         * TestWebKitAPI/Tests/WebKit2/LimitTitleSize.cpp: Added.
2961         * TestWebKitAPI/Tests/WebKit2/set-long-title.html: Added.
2962         * TestWebKitAPI/Tests/mac/LimitTitleSize.mm: Added.
2963
2964 2017-04-25  John Wilander  <wilander@apple.com>
2965
2966         Resource Load Statistics: Introduce shorter time-to-live for cookie partition whitelisting
2967         https://bugs.webkit.org/show_bug.cgi?id=171295
2968         <rdar://problem/31823818>
2969
2970         Reviewed by Brent Fulgham.
2971
2972         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2973         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2974         (WTR::TestRunner::setStatisticsTimeToLiveCookiePartitionFree):
2975         (WTR::TestRunner::statisticsFireShouldPartitionCookiesHandler):
2976         (WTR::TestRunner::statisticsFireShouldPartitionCookiesHandlerForOneDomain):
2977         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2978         * WebKitTestRunner/TestController.cpp:
2979         (WTR::TestController::setStatisticsTimeToLiveCookiePartitionFree):
2980         (WTR::TestController::statisticsFireShouldPartitionCookiesHandler):
2981         (WTR::TestController::statisticsFireShouldPartitionCookiesHandlerForOneDomain):
2982         * WebKitTestRunner/TestController.h:
2983         * WebKitTestRunner/TestInvocation.cpp:
2984         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2985
2986 2017-04-25  Tim Horton  <timothy_horton@apple.com>
2987
2988         Try to fix the WKTR build after r215758
2989
2990         * Scripts/build-webkittestrunner:
2991
2992 2017-04-25  Daniel Bates  <dabates@apple.com>
2993
2994         Remove more EFL code
2995         https://bugs.webkit.org/show_bug.cgi?id=171288
2996
2997         Rubber-stamped by Simon Fraser.
2998
2999         The EFL port is no longer in the WebKit OpenSource Project repository. Remove more code
3000         that was part of the EFL port.
3001
3002         * CMakeLists.txt:
3003         * DumpRenderTree/AccessibilityController.h:
3004         * DumpRenderTree/AccessibilityUIElement.cpp:
3005         (AccessibilityUIElement::getJSClass):
3006         * DumpRenderTree/AccessibilityUIElement.h:
3007         * DumpRenderTree/DumpRenderTree.h:
3008         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
3009         * ImageDiff/efl/ImageDiff.cpp: Removed.
3010         * MiniBrowser/efl/CMakeLists.txt: Removed.
3011         * MiniBrowser/efl/main.c: Removed.
3012         * Scripts/build-dumprendertree:
3013         * Scripts/build-jsc:
3014         * Scripts/build-webkit:
3015         * Scripts/build-webkittestrunner:
3016         * Scripts/run-minibrowser:
3017         * Scripts/update-webkit-libs-jhbuild:
3018         * Scripts/update-webkitefl-libs: Removed.
3019         * Scripts/webkitdirs.pm:
3020         (argumentsForConfiguration):
3021         (extractNonMacOSHostConfiguration):
3022         (executableProductDir):
3023         (builtDylibPathForName):
3024         (determinePortName):
3025         (launcherPath):
3026         (launcherName):
3027         (getJhbuildPath):
3028         (wrapperPrefixIfNeeded):
3029         (generateBuildSystemFromCMakeProject):
3030         (buildCMakeProjectOrExit):
3031         (isEfl): Deleted.
3032         * Scripts/webkitperl/FeatureList.pm:
3033         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl:
3034         * Scripts/webkitpy/common/config/ports.py:
3035         (DeprecatedPort.port):
3036         (GtkWK2Port.run_webkit_tests_command):
3037         (EflWK2Port): Deleted.
3038         (EflWK2Port.build_webkit_command): Deleted.
3039         * Scripts/webkitpy/port/builders.py:
3040         * Scripts/webkitpy/port/efl.py: Removed.
3041         * Scripts/webkitpy/port/efl_unittest.py: Removed.
3042         * Scripts/webkitpy/port/factory.py:
3043         (platform_options):
3044         (PortFactory):
3045         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3046         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
3047         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3048         (TestRebaselineTest.test_baseline_directory):
3049         (TestRebaselineExpectations.test_rebaseline_expectations):
3050         * TestWebKitAPI/PlatformEfl.cmake: Removed.
3051         * TestWebKitAPI/PlatformWebView.h:
3052         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3053         (TestWebKitAPI::TEST):
3054         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp: Removed.
3055         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp: Removed.
3056         * TestWebKitAPI/Tests/WebKit2/efl/WKViewScrollTo.cpp: Removed.
3057         * TestWebKitAPI/Tests/WebKit2/efl/scrollTo.html: Removed.
3058         * TestWebKitAPI/efl/InjectedBundleController.cpp: Removed.
3059         * TestWebKitAPI/efl/PlatformUtilities.cpp: Removed.
3060         * TestWebKitAPI/efl/PlatformWebView.cpp: Removed.
3061         * TestWebKitAPI/efl/main.cpp: Removed.
3062         * WebKitTestRunner/EventSenderProxy.h:
3063         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3064         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
3065         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3066         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3067         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3068         (WTR::EventSendingController::contextClick):
3069         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3070         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3071         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
3072         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
3073         * WebKitTestRunner/InjectedBundle/efl/ActivateFontsEfl.cpp: Removed.
3074         * WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp: Removed.
3075         * WebKitTestRunner/InjectedBundle/efl/FontManagement.h: Removed.
3076         * WebKitTestRunner/InjectedBundle/efl/InjectedBundleEfl.cpp: Removed.
3077         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp: Removed.
3078         * WebKitTestRunner/PlatformEfl.cmake: Removed.
3079         * WebKitTestRunner/PlatformWebView.h:
3080         * WebKitTestRunner/TestController.cpp:
3081         (WTR::TestController::resetStateToConsistentValues):
3082         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp: Removed.
3083         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp: Removed.
3084         * WebKitTestRunner/efl/TestControllerEfl.cpp: Removed.
3085         * WebKitTestRunner/efl/main.cpp: Removed.
3086         * efl/install-dependencies: Removed.
3087         * efl/jhbuild-optional.modules: Removed.
3088         * efl/jhbuild.modules: Removed.
3089         * efl/jhbuildrc: Removed.
3090         * efl/patches/evas-fix-build-with-giflib5.patch: Removed.
3091         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Removed.
3092         * efl/patches/gst-libav.patch: Removed.
3093         * efl/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Removed.
3094         * efl/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
3095         * efl/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
3096         * efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Removed.
3097         * gtk/manifest.txt.in:
3098
3099 2017-04-25  Daniel Bates  <dabates@apple.com>
3100
3101         [Cocoa][Win] Enable of X-Content-Type-Options: nosniff header
3102         https://bugs.webkit.org/show_bug.cgi?id=136452
3103         <rdar://problem/23412620>
3104
3105         Reviewed by Brent Fulgham.
3106
3107         Enable X-Content-Type-Options: nosniff on Mac, iOS and Windows platforms.
3108
3109         * Scripts/webkitperl/FeatureList.pm: Also do not enable nosniff on EFL
3110         as the EFL port is no longer in the WebKit OpenSource repository.
3111         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3112
3113 2017-04-25  Zan Dobersek  <zdobersek@igalia.com>
3114
3115         Unreviewed follow-up to r215739 and r215740.
3116
3117         * gtk/jhbuild.modules: List the libgcrypt patch that has to be applied.
3118         This (and r215740) was supposed to land in r215739, but I managed to
3119         specify the previous version of the patch.
3120
3121 2017-04-25  Zan Dobersek  <zdobersek@igalia.com>
3122
3123         Unreviewed follow-up to r215739.
3124
3125         * gtk/patches/libgcrypt-use-only-dev-urandom-for-testing.patch: Add the missing
3126         libgcrypt patch that enforces the use of /dev/urandom.
3127
3128 2017-04-25  Zan Dobersek  <zdobersek@igalia.com>
3129
3130         [GTK] Add libgpg-error, libgcrypt libraries to JHBuild
3131         https://bugs.webkit.org/show_bug.cgi?id=171270
3132
3133         Reviewed by Michael Catanzaro.
3134
3135         * gtk/jhbuild.modules: Add the latest stable versions of libgpg-error and libgcrypt
3136         libraries to the webkitgtk-testing-dependencies metamodule. This will help people
3137         that use systems that don't yet provide libgcrypt >= 1.7.0.
3138
3139 2017-04-25  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3140
3141         [GTK] Improve an unit test for the JHBuild wrapper.
3142         https://bugs.webkit.org/show_bug.cgi?id=168036
3143
3144         Unreviewed follow-up patch after r215727
3145
3146         * Scripts/webkitpy/port/base_unittest.py:
3147         (test_jhbuild_wrapper): Improve the unit test by ensuring the directory
3148         wasn't there before calling MockFileSystem.maybe_make_directory(), and
3149         also that it exists after calling it.
3150
3151 2017-04-25  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3152
3153         [GTK] ImageDiff should be run by jhbuild-wrapper in case of using jhbuild
3154         https://bugs.webkit.org/show_bug.cgi?id=168036
3155
3156         Reviewed by Michael Catanzaro.
3157
3158         Call ImageDiff with the JHBuild wrapper if we should use it.
3159         Also add some unit tests for the JHBuild wrapper feature.
3160
3161         * Scripts/webkitpy/port/base.py:
3162         (Port._should_use_jhbuild): Use self._filesystem instead of os.path to allow mock testing.
3163         * Scripts/webkitpy/port/base_unittest.py:
3164         (test_jhbuild_wrapper): Add a test for port._should_use_jhbuild()
3165         * Scripts/webkitpy/port/image_diff.py:
3166         (ImageDiffer._start): The actual fix, use the wrapper if we should.
3167         * Scripts/webkitpy/port/image_diff_unittest.py: Removed. This two tests are now integrated in port_testcase
3168         * Scripts/webkitpy/port/port_testcase.py:
3169         (PortTestCase):
3170         (PortTestCase.test_diff_image): Test the command with wrapper and without it.
3171         (PortTestCase.test_diff_image_passed): Moved from image_diff_unittest.py
3172         (PortTestCase.test_diff_image_failed): Moved from image_diff_unittest.py
3173
3174 2017-04-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3175
3176         Support reading NSURL titles from the pasteboard when performing data interaction
3177         https://bugs.webkit.org/show_bug.cgi?id=171156
3178         <rdar://problem/31356937>
3179
3180         Reviewed by Tim Horton.
3181
3182         Adds a new unit test, DataInteractionTests.ExternalSourceTitledNSURL.
3183
3184         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3185         (TestWebKitAPI::TEST):
3186
3187 2017-04-24  Wenson Hsieh  <wenson_hsieh@apple.com>
3188
3189         Respect fidelity order when reading web content from item providers
3190         https://bugs.webkit.org/show_bug.cgi?id=171155
3191         <rdar://problem/31356937>
3192
3193         Reviewed by Tim Horton.
3194
3195         Adds a new unit test (DataInteractionTests.RespectsExternalSourceFidelityRankings). See WebCore ChangeLog for
3196         more details.
3197
3198         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3199         (TestWebKitAPI::TEST):
3200
3201 2017-04-24  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3202
3203         SyntaxError fix after r215702.
3204         https://bugs.webkit.org/show_bug.cgi?id=168944
3205
3206         Unreviewed "build" fix.
3207
3208         * BuildSlaveSupport/built-product-archive:
3209         (archiveBuiltProduct):
3210
3211 2017-04-24  Jonathan Bedard  <jbedard@apple.com>
3212
3213         Package ImageDiff built with host SDK
3214         https://bugs.webkit.org/show_bug.cgi?id=168944
3215         <rdar://problem/30745642>
3216
3217         Reviewed by David Kilzer.
3218
3219         iOS Simulator and iOS device should archive the ImageDiff built for the host
3220         machine.
3221
3222         * BuildSlaveSupport/built-product-archive:
3223         (determineWebKitBuildDirectories): Add _hostBuildDirectory for iOS.
3224         (archiveBuiltProduct): Archive Mac products for iOS so that ImageDiff is included.
3225
3226 2017-04-24  Keith Miller  <keith_miller@apple.com>
3227
3228         ThreadMessage API tests failing on release bots
3229         https://bugs.webkit.org/show_bug.cgi?id=171246
3230
3231         Reviewed by Saam Barati.
3232
3233         Need to make sure that C++ doesn't optimize away our spin loop.
3234
3235         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
3236         (runThreadMessageTest):
3237         (TEST):
3238
3239 2017-04-24  Alex Christensen  <achristensen@webkit.org>
3240
3241         Reduce copies and allocations in SharedBuffer::append
3242         https://bugs.webkit.org/show_bug.cgi?id=170956
3243
3244         Reviewed by Andreas Kling.
3245
3246         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
3247         (TestWebKitAPI::TEST_F):
3248
3249 2017-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3250
3251         [GTK] Switch to use ENABLE_REMOTE_INSPECTOR instead of ENABLE_INSPECTOR_SERVER for the remote inspector
3252         https://bugs.webkit.org/show_bug.cgi?id=166680
3253
3254         Reviewed by Michael Catanzaro.
3255
3256         Update remote inspector unit tests.
3257
3258         * TestWebKitAPI/Tests/WebKit2Gtk/InspectorTestServer.cpp:
3259         (main):
3260         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
3261         (connectToInspectorServer):
3262         (waitUntilInspectorServerIsReady):
3263         (startTestServer):
3264         (testInspectorServerPageList):
3265         (beforeAll):
3266
3267 2017-04-23  Youenn Fablet  <youenn@apple.com>
3268
3269         Add a tool to update expected.txt files from EWS bot results
3270         https://bugs.webkit.org/show_bug.cgi?id=169538
3271
3272         Reviewed by Ryosuke Niwa.
3273
3274         This script updates expected-txt files from bugzilla posted EWS results.
3275         It uses mac-wk2 as the generic baseline and adds platform-specific results if other ports
3276         have results different from the generic baseline.
3277
3278         * Scripts/update-test-expectations-from-bugzilla: Added.
3279         * Scripts/webkitpy/common/net/bugzilla/test_expectation_updater.py: Added.
3280         * Scripts/webkitpy/common/net/bugzilla/test_expectation_updater_unittest.py: Added.
3281         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: Adding helper routines.
3282
3283 2017-04-22  Youenn Fablet  <youenn@apple.com>
3284
3285         Add an option to import tip-of-tree WPT tests
3286         https://bugs.webkit.org/show_bug.cgi?id=171152
3287
3288         Reviewed by Joseph Pecoraro.
3289
3290         Adding a '-t' option to import tip of tree WPT tests.
3291         Updating importer based on the fact that csswg-test is no longer a thing. 
3292
3293         * Scripts/webkitpy/w3c/test_downloader.py:
3294         (TestDownloader.download_tests):
3295         * Scripts/webkitpy/w3c/test_importer.py:
3296         (configure_logging):
3297         (TestImporter.do_import):
3298         (TestImporter.write_import_log):
3299
3300 2017-04-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3301
3302         File inputs only accept UTI types that can be inserted into contenteditable areas when dropping
3303         https://bugs.webkit.org/show_bug.cgi?id=171177
3304         <rdar://problem/31765379>
3305
3306         Reviewed by Andy Estes.
3307
3308         Tests uploading a JSON file to a file input.
3309
3310         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3311         (TestWebKitAPI::TEST):
3312
3313 2017-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
3314
3315         Support writing link titles to the pasteboard when beginning data interaction on a link
3316         https://bugs.webkit.org/show_bug.cgi?id=171154
3317         <rdar://problem/31356937>
3318
3319         Reviewed by Andy Estes.
3320
3321         Augments an existing unit test, DataInteractionTests.LinkToInput, to also check that the fetching the NSURL from
3322         the source UIItemProvider generated by performing data interaction results in an NSURL with the _title attribute
3323         matching the title of the link.
3324
3325         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3326         (TestWebKitAPI::TEST):
3327
3328 2017-04-21  Michael Catanzaro  <mcatanzaro@igalia.com>
3329
3330         Unreviewed, rolling out r215608.
3331
3332         Hundreds of test failures on GTK bot
3333
3334         Reverted changeset:
3335
3336         "Reduce copies and allocations in SharedBuffer::append"
3337         https://bugs.webkit.org/show_bug.cgi?id=170956
3338         http://trac.webkit.org/changeset/215608
3339
3340 2017-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
3341
3342         [WK2] Add delegate hooks for overriding unhanded data interaction operations
3343         https://bugs.webkit.org/show_bug.cgi?id=171005
3344         <rdar://problem/31669646>
3345
3346         Reviewed by Tim Horton.
3347
3348         Adds a new API test checking that normal WebKit behavior when vending updated data interaction operations may
3349         be overridden, resulting in a data interaction operation being performed when it otherwise would not have. Also
3350         adjusts for some changes in WebKit2 (See WebKit2 ChangeLog for more details).
3351
3352         New API test:
3353         DataInteractionTests.OverrideDataInteractionOperation
3354
3355         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3356         (-[UIItemProvider registerDataRepresentationForTypeIdentifier:withData:]):
3357         (TestWebKitAPI::TEST):
3358         * TestWebKitAPI/ios/DataInteractionSimulator.h:
3359         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3360         (-[DataInteractionSimulator initWithWebView:]):
3361         (-[DataInteractionSimulator dealloc]):
3362         (-[DataInteractionSimulator _webView:dataInteractionOperationWasHandled:forSession:itemProviders:]):
3363         (-[DataInteractionSimulator _webView:willUpdateDataInteractionOperationToOperation:forSession:]):
3364         (-[DataInteractionSimulator webViewDidPerformDataInteractionControllerOperation:]): Deleted.
3365
3366 2017-04-21  Ryan Haddad  <ryanhaddad@apple.com>
3367
3368         Temporarily disable two flaky API tests.
3369
3370         Unreviewed test gardening.
3371
3372         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
3373         (TEST):
3374         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
3375         (TEST):
3376
3377 2017-04-21  Keith Miller  <keith_miller@apple.com>
3378
3379         Unreviewed, rolling out r215634.
3380
3381         underlying build issues should have been fixed
3382
3383         Reverted changeset:
3384
3385         "Unreviewed, rolling out r215620 and r215623."
3386         https://bugs.webkit.org/show_bug.cgi?id=171139
3387         http://trac.webkit.org/changeset/215634
3388
3389 2017-04-21  Aakash Jain  <aakash_jain@apple.com>
3390
3391         Bubbles on dashboard doesn't turn red for test262 failures
3392         https://bugs.webkit.org/show_bug.cgi?id=171129
3393
3394         Reviewed by Alexey Proskuryakov.
3395
3396         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Added test262-test.
3397
3398 2017-04-21  Commit Queue  <commit-queue@webkit.org>
3399
3400         Unreviewed, rolling out r215620 and r215623.
3401         https://bugs.webkit.org/show_bug.cgi?id=171139
3402
3403         broke arm64 build (Requested by keith_miller on #webkit).
3404
3405         Reverted changesets:
3406
3407         "Add signaling API"
3408         https://bugs.webkit.org/show_bug.cgi?id=170976
3409         http://trac.webkit.org/changeset/215620
3410
3411         "Unreviewed, fix Cloop build."
3412         http://trac.webkit.org/changeset/215623
3413
3414 2017-04-20  Keith Miller  <keith_miller@apple.com>
3415
3416         Add signaling API
3417         https://bugs.webkit.org/show_bug.cgi?id=170976
3418
3419         Reviewed by Filip Pizlo.
3420
3421         Add tests for ThreadMessages.
3422
3423         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3424         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp: Added.
3425         (runThreadMessageTest):
3426         (TEST):
3427
3428 2017-04-20  Conrad Shultz  <conrad_shultz@apple.com>
3429
3430         commit-log-editor should respect the git editor if one is set
3431         https://bugs.webkit.org/show_bug.cgi?id=171085
3432         <rdar://problem/31745506>
3433
3434         Reviewed by Daniel Bates.
3435
3436         * Scripts/commit-log-editor:
3437         If Git is available, consider GIT_LOG_EDITOR and any global Git editor preference when
3438         deciding which editor to present. We examine the global editor preference since that may be
3439         set automatically by installers or third-party tools.
3440
3441 2017-04-21  Alex Christensen  <achristensen@webkit.org>
3442
3443         Reduce copies and allocations in SharedBuffer::append
3444         https://bugs.webkit.org/show_bug.cgi?id=170956
3445
3446         Reviewed by Andreas Kling.
3447
3448         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
3449         (TestWebKitAPI::TEST_F):
3450
3451 2017-04-20  Konstantin Tokarev  <annulen@yandex.ru>
3452
3453         [cmake] Define FORWARDING_HEADERS_DIR in WebKitFS and use it everywhere
3454         https://bugs.webkit.org/show_bug.cgi?id=171071
3455
3456         Reviewed by Michael Catanzaro.
3457
3458         "${DERIVED_SOURCES_DIR}/ForwardingHeaders" path occurs very often in the
3459         build system files. GTK-specifc FORWARDING_HEADERS_DIR variable should
3460         be available for all ports.
3461
3462         * DumpRenderTree/PlatformMac.cmake:
3463         * MiniBrowser/mac/CMakeLists.txt:
3464         * MiniBrowser/win/CMakeLists.txt:
3465         * TestWebKitAPI/PlatformJSCOnly.cmake:
3466         * TestWebKitAPI/PlatformMac.cmake:
3467         * TestWebKitAPI/PlatformWin.cmake:
3468         * WebKitTestRunner/PlatformMac.cmake:
3469
3470 2017-04-20  Joseph Pecoraro  <pecoraro@apple.com>
3471
3472         Test262 bot does not go red with failures
3473         https://bugs.webkit.org/show_bug.cgi?id=171044
3474
3475         Reviewed by Aakash Jain.
3476
3477         The piped output of run-jsc-stress-tests is different from
3478         its non-piped output. Switch to parsing the correct output.
3479
3480         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3481         (RunTest262Tests.countFailures):
3482         Just count the number of lines that start with "FAIL:".
3483
3484         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3485         (RunTest262TestsTest.test_no_regressions_output):
3486         (test_failure_output):
3487         (test_failures_output):
3488         Updated tests with new sample output produced partially from bots and
3489         locally. In cases of failure the return code of run-jsc-stress-tests
3490         is still 0 so update the expected return code in the tests.
3491
3492 2017-04-20  Brady Eidson  <beidson@apple.com>
3493
3494         WebContent process becomes unresponsive after returning nil from async version of -webView:createWebViewWithConfiguration:...
3495         <rdar://problem/31739023> and https://bugs.webkit.org/show_bug.cgi?id=171090
3496
3497         Reviewed by Andy Estes.
3498
3499         * TestWebKitAPI/Tests/WebKit2/open-and-close-window.html:
3500         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
3501         (resetToConsistentState):
3502         (-[OpenAndCloseWindowUIDelegate webViewDidClose:]):
3503         (-[OpenAndCloseWindowUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3504         (TEST):
3505         (-[OpenAndCloseWindowUIDelegateAsync _webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:completionHandler:]):
3506
3507 2017-04-20  Wenson Hsieh  <wenson_hsieh@apple.com>
3508
3509         [ios-simulator] PositionInformationTests API tests are timing out
3510         https://bugs.webkit.org/show_bug.cgi?id=171089
3511
3512         Rubber-stamped by Tim Horton.
3513
3514         Addresses failures observed in the new position information tests added in r215573 by only running them if the
3515         DATA_INTERACTION feature flag is enabled.
3516
3517         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm:
3518
3519 2017-04-20  Brady Eidson  <beidson@apple.com>
3520
3521         Skip WebKit2.OpenAndCloseWindowAsyncCallbackException for now.
3522         https://bugs.webkit.org/show_bug.cgi?id=171083
3523
3524         Unreviewed.
3525
3526         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
3527
3528 2017-04-20  Brady Eidson  <beidson@apple.com>
3529
3530         Add CompletionHandlerCallChecker to SPI added in r215545.
3531         https://bugs.webkit.org/show_bug.cgi?id=171067
3532
3533         Reviewed by Dan Bernstein.
3534
3535         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
3536         (TEST):
3537         (-[OpenAndCloseWindowUIDelegateAsync _webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:completionHandler:]):
3538
3539 2017-04-20  Wenson Hsieh  <wenson_hsieh@apple.com>
3540
3541         [WK2] -[WKContentView doAfterPositionInformationUpdate:atPosition:] should be robust against synchronous reentrancy
3542         https://bugs.webkit.org/show_bug.cgi?id=170922
3543         <rdar://problem/31634990>
3544
3545         Reviewed by Tim Horton.
3546
3547         Adds six new unit tests for retrieving interaction information at a given position in the UI process. See
3548         WebKit2 ChangeLog for more details.
3549
3550         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm:
3551         (-[_WKDraggableElementInfo expectToBeLink:image:atPoint:]):
3552         (TestWebKitAPI::TEST):
3553         (TestWebKitAPI::expectCGPointsToBeEqual): Deleted.
3554
3555 2017-04-20  Xan Lopez  <xlopez@igalia.com>
3556
3557         [GTK][jhbuild] Update glib and glib-networking to the latest stable versions
3558         https://bugs.webkit.org/show_bug.cgi?id=170942
3559
3560         Reviewed by Carlos Garcia Campos.
3561
3562         Update glib and glib-networking to the last stable releases. This
3563         is needed to get working TLS certificate verification at all at
3564         least in Fedora.
3565
3566         * gtk/install-dependencies: add libmount, needed for newer glib.
3567         * gtk/jhbuild.modules: update glib and glib-networking to last
3568         stable releases.
3569
3570 2017-04-20  Joanmarie Diggs  <jdiggs@igalia.com>
3571
3572         [ATK] Implement support for DPub ARIA roles
3573         https://bugs.webkit.org/show_bug.cgi?id=170679
3574
3575         Reviewed by Chris Fleizach.
3576
3577         Add DPub ARIA landmark roles to roleToString().
3578
3579         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3580
3581 2017-04-19  Joseph Pecoraro  <pecoraro@apple.com>
3582
3583         Remove WebKitTestRunner code for enabling features that are already enabled by default
3584         https://bugs.webkit.org/show_bug.cgi?id=171033
3585
3586         Reviewed by Ryosuke Niwa.
3587
3588         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3589         (WTR::InjectedBundle::beginTesting):
3590         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3591         (WTR::TestRunner::setShadowDOMEnabled): Deleted.
3592         (WTR::TestRunner::setCustomElementsEnabled): Deleted.
3593         (WTR::TestRunner::setFetchAPIEnabled): Deleted.
3594         (WTR::TestRunner::setDownloadAttributeEnabled): Deleted.
3595         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3596
3597 2017-04-19  Youenn Fablet  <youenn@apple.com>
3598
3599         [Mac] Allow customizing H264 encoder
3600         https://bugs.webkit.org/show_bug.cgi?id=170829
3601
3602         Reviewed by Alex Christensen.
3603
3604         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3605
3606 2017-04-19  Brady Eidson  <beidson@apple.com>
3607
3608         Add asynchronous equivalent of -[<WKUIDelegate> webView:createWebViewWithConfiguration:...].
3609         <rdar://problem/30699851> and https://bugs.webkit.org/show_bug.cgi?id=171018
3610
3611         Reviewed by Tim Horton.
3612
3613         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
3614         (TEST):
3615         (-[OpenAndCloseWindowUIDelegateAsync webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3616         (-[OpenAndCloseWindowUIDelegateAsync _webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:completionHandler:]):
3617
3618 2017-04-19  Brady Eidson  <beidson@apple.com>
3619
3620         REGRESSION (r213168): An extra Web Content process is spun up on launch and is never closed.
3621         <rdar://problem/30774839> and https://bugs.webkit.org/show_bug.cgi?id=171002
3622
3623         Reviewed by Alex Christensen.
3624
3625         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3626         * TestWebKitAPI/Tests/WebKit2Cocoa/InitialWarmedProcessUsed.mm: Added.
3627
3628 2017-04-19  Brent Fulgham  <bfulgham@apple.com>
3629
3630         [WK2] Run tests with ResourceLoadStatistics enabled
3631         https://bugs.webkit.org/show_bug.cgi?id=170952
3632
3633         Reviewed by Andy Estes.
3634
3635         Excercise the load statistics code during tests.
3636
3637         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3638         (WTR::initializeWebViewConfiguration):
3639
3640 2017-04-19  Bill Ming  <mbbill@gmail.com>
3641
3642         close_fds should be set to False on Windows.
3643         https://bugs.webkit.org/show_bug.cgi?id=170838
3644
3645         Reviewed by Brent Fulgham.
3646
3647         * Scripts/webkitpy/common/system/executive.py:
3648         (Executive._should_close_fds):
3649
3650 2017-04-19  David Kilzer  <ddkilzer@apple.com>
3651
3652         Stop using strcpy() in WebKit::EnvironmentUtilities::stripValuesEndingWithString()
3653         <https://webkit.org/b/170994>
3654         <rdar://problem/29889932>
3655
3656         Reviewed by Brent Fulgham.
3657
3658         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3659         (EnvironmentUtilitiesTest.cpp): Add to TestWebKitAPILibrary
3660         target.
3661         * TestWebKitAPI/Tests/WebKit2/EnvironmentUtilitiesTest.cpp: Add.
3662