2011-01-17 John Knottenbelt <jknotten@chromium.org>
[WebKit-https.git] / Tools / ChangeLog
1 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2
3         Reviewed by Jeremy Orlow.
4
5         GeolocationController should call stopUpdating on destruction
6         https://bugs.webkit.org/show_bug.cgi?id=52216
7
8         fast/dom/Geolocation/window-close-crash.html requires that a
9         Geolocation watch be started in a secondary window. Consequently,
10         we need to allow geolocation permission and provide a mock
11         geolocation position for the secondary window's
12         GeolocationClientMock.
13
14         * DumpRenderTree/chromium/LayoutTestController.cpp:
15         (LayoutTestController::setGeolocationPermission):
16         (LayoutTestController::setMockGeolocationPosition):
17         (LayoutTestController::setMockGeolocationError):
18         * DumpRenderTree/chromium/TestShell.h:
19         (TestShell::windowList):
20
21 2011-01-16  Adam Barth  <abarth@webkit.org>
22
23         Update more include paths to reflect WebKit move.
24
25         * DumpRenderTree/chromium/EventSender.cpp:
26         (EventSender::keyDown):
27         (EventSender::needsShiftModifier):
28         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
29         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
30
31 2011-01-16  Kent Tamura  <tkent@chromium.org>
32
33         Unreviewed, Chromium build fix.
34
35         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
36
37 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
38
39         Build fix for GTK+ after source directory movement.
40
41         * GNUmakefile.am: Correct include paths.
42
43 2011-01-16  Adam Barth  <abarth@webkit.org>
44
45         Teach svn-apply about WebKit move.
46
47         * Scripts/VCSUtils.pm:
48
49 2011-01-16  Adam Barth  <abarth@webkit.org>
50
51         Rubber-stamped by Eric Seidel.
52
53         Move WebKit into Source
54         https://bugs.webkit.org/show_bug.cgi?id=52530
55
56         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
57         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
58         * DumpRenderTree/qt/DumpRenderTreeQt.h:
59         * DumpRenderTree/qt/GCControllerQt.cpp:
60         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
61         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
62         * DumpRenderTree/qt/TextInputControllerQt.cpp:
63         * DumpRenderTree/wscript:
64         * QtTestBrowser/launcherwindow.h:
65         * Scripts/build-webkit:
66         * Scripts/webkitdirs.pm:
67
68 2011-01-15  Adam Barth  <abarth@webkit.org>
69
70         Teach svn-apply about WebKit2 move.
71
72         * Scripts/VCSUtils.pm:
73
74 2011-01-15  Adam Barth  <abarth@webkit.org>
75
76         Rubber-stamped by Eric Seidel.
77
78         Move WebKit2 into Source
79         https://bugs.webkit.org/show_bug.cgi?id=52438
80
81         * MiniBrowser/qt/MiniBrowser.pro:
82         * Scripts/build-webkit:
83         * Scripts/do-file-rename:
84         * Scripts/do-webcore-rename:
85         * Scripts/test-webkitpy:
86         * Scripts/webkitdirs.pm:
87         * Scripts/webkitpy/style/checker.py:
88         * WebKitTestRunner/DerivedSources.pro:
89         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
90         * WebKitTestRunner/qt/WebKitTestRunner.pro:
91
92 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
93
94         Reviewed by David Levin.
95
96         [chromium] remove obsolete createView method
97         https://bugs.webkit.org/show_bug.cgi?id=52437
98
99         * DumpRenderTree/chromium/WebViewHost.cpp:
100         (WebViewHost::createView):
101         * DumpRenderTree/chromium/WebViewHost.h:
102
103 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
104
105         Reviewed by Geoff Garen.
106
107         ShouldLoadResourceForFrame should use strings, not URLs.
108         https://bugs.webkit.org/show_bug.cgi?id=52476
109
110         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
111         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
112         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
113
114 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
115
116         Reviewed by David Levin.
117
118         Add Tony Gentilcore as a reviewer
119         https://bugs.webkit.org/show_bug.cgi?id=52480
120
121         * Scripts/webkitpy/common/config/committers.py:
122
123 2011-01-14  David Levin  <levin@chromium.org>
124
125         Reviewed by Eric Seidel.
126
127         check-webkit-style: _FunctionState should keep track of where the function name starts.
128         https://bugs.webkit.org/show_bug.cgi?id=52454
129
130         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
131         _FunctionState and logic for setting it correctly.
132         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
133
134 2011-01-14  Vincent Scheib  <scheib@chromium.org>
135
136         Reviewed by David Levin.
137
138         Add support to DumpRenderTree to use the GPU rather than software renderer
139         https://bugs.webkit.org/show_bug.cgi?id=52333
140
141         * DumpRenderTree/chromium/DumpRenderTree.cpp:
142         (main):
143         * Scripts/webkitpy/layout_tests/port/chromium.py:
144         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
145
146 2011-01-14  Tony Chang  <tony@chromium.org>
147
148         Reviewed by Kent Tamura.
149
150         [chromium] update fonts.conf to fix 6 linux tests in drt
151         https://bugs.webkit.org/show_bug.cgi?id=52411
152
153         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
154             chromium's src/webkit/tools/test_shell/resources/fonts.conf
155
156 2011-01-14  Eric Seidel  <eric@webkit.org>
157
158         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
159
160         Reviewed by Adam Barth.
161
162         Fix when running Tools/Scripts/check-webkit-style without arguments.
163         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
164
165         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
166         * Scripts/webkitpy/common/checkout/scm_unittest.py:
167
168 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
169
170         Reviewed by David Levin.
171
172         Store the tempdir object in a variable so it doesn't get deleted too early.
173         https://bugs.webkit.org/show_bug.cgi?id=51875
174
175         * Scripts/update-webkit-auxiliary-libs:
176         * Scripts/update-webkit-support-libs:
177
178 2011-01-14  Eric Seidel  <eric@webkit.org>
179
180         Unreviewed.  Make it work in python 2.5.
181
182         webkit-patch suggest-reviewers dies when ChangeLogs are missing
183         https://bugs.webkit.org/show_bug.cgi?id=49158
184
185         * Scripts/webkitpy/common/checkout/api_unittest.py:
186
187 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
188
189         Unreviewed, rolling out r75774.
190         http://trac.webkit.org/changeset/75774
191         https://bugs.webkit.org/show_bug.cgi?id=52431
192
193         gtk builds were broken (Requested by loislo2 on #webkit).
194
195         * Scripts/webkitpy/common/checkout/scm.py:
196
197 2011-01-14  David Levin  <levin@chromium.org>
198
199         Reviewed by Shinichiro Hamaji.
200
201         check-webkit-style: _FunctionState should detect pure functions.
202         https://bugs.webkit.org/show_bug.cgi?id=52428
203
204         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
205         is a pure virtual function.
206         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
207         virtual functions are correctly detected.
208
209 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
210
211         Reviewed by Yury Semikhatsky.
212
213         Just small fix for problem with check-webkit-style.
214         It just didn't work for this patch.
215         Old code can't concatenate a list of strings with None.
216
217         * Scripts/webkitpy/common/checkout/scm.py:
218
219 2011-01-13  David Levin  <levin@chromium.org>
220
221         Reviewed by Shinichiro Hamaji.
222
223         check-webkit-style: _FunctionState should use Position to know where items are.
224         https://bugs.webkit.org/show_bug.cgi?id=52424
225
226         * Scripts/webkitpy/style/checkers/cpp.py:
227         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
228         (detect_functions): Changed to pass Position's to _FunctionState.begin and
229         did some minor clean-up.
230         (*): Other changes are simply about converting to use the Position's in_FunctionState
231         instead of line numbers.
232         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
233         to verify the positions stored in _FunctionState.
234
235 2011-01-13  Eric Seidel  <eric@webkit.org>
236
237         Reviewed by David Levin.
238
239         webkit-patch suggest-reviewers dies when ChangeLogs are missing
240         https://bugs.webkit.org/show_bug.cgi?id=49158
241
242         This is not the most elegant, but it is a very safe fix to this bug.
243         One advantage of catching ScriptError like this instead of adding a
244         new added_or_modified_files or fixing all changed_files callers
245         to use a more specific change_files variant, is that we catch
246         all kinds of ScriptErrors which might cause our (non-essential)
247         suggest-reviewers code to fail out.  This should make passing
248         --suggest-reviewers to webkit-patch upload much more robust
249         and may even make it possible for us to make it default.
250
251         The root of the problem here is that SCM.changed_files includes
252         deleted ChangeLog paths (from moves, etc) which then when we ask
253         SVN/Git for the contents of the file at that revision, the command
254         errors out and Executive.run_command raises a ScriptError.
255
256         In the future we might fix this differently by making all current
257         callers of chagned_files use a more specific method for requesting
258         what types of changes they're interested in (adds, modifies, deletes, etc.)
259
260         * Scripts/webkitpy/common/checkout/api.py:
261         * Scripts/webkitpy/common/checkout/api_unittest.py:
262
263 2011-01-13  Dan Bernstein  <mitz@apple.com>
264
265         Reviewed by Alexey Proskuryakov.
266
267         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
268         https://bugs.webkit.org/show_bug.cgi?id=52419
269
270         Allow to further control the behavior of the willSendRequest delegate callback by making it
271         set a different URL in the new request.
272
273         * DumpRenderTree/LayoutTestController.cpp:
274         (addURLToRedirectCallback): Added.
275         (LayoutTestController::staticFunctions): Added addURLToRedirect.
276         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
277         (LayoutTestController::redirectionDestinationForURL): Added this getter.
278         * DumpRenderTree/LayoutTestController.h:
279         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
280         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
281         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
282         change the URL in the new request to the redirect destination.
283
284 2011-01-13  Eric Seidel  <eric@webkit.org>
285
286         Reviewed by Mihai Parparita.
287
288         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
289         https://bugs.webkit.org/show_bug.cgi?id=52416
290
291         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
292         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
293
294         I also added FIXMEs about the changed_files returning deleted files problem
295         which is causing the other most common exception for suggest-reviewers
296         (and is probably breaking sheriff-bots blame detection).
297
298         * Scripts/webkitpy/common/checkout/api.py:
299         * Scripts/webkitpy/common/checkout/api_unittest.py:
300         * Scripts/webkitpy/common/checkout/scm.py:
301
302 2011-01-13  Eric Seidel  <eric@webkit.org>
303
304         Reviewed by Adam Barth.
305
306         results archives from commit-queue are too large to upload
307         https://bugs.webkit.org/show_bug.cgi?id=52405
308
309         * Scripts/webkitpy/common/system/filesystem.py:
310         * Scripts/webkitpy/common/system/filesystem_mock.py:
311         * Scripts/webkitpy/tool/commands/queues.py:
312
313 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
314
315         Reviewed by Martin Robinson.
316
317         [gtk] Zero-sized font does not yet work
318         https://bugs.webkit.org/show_bug.cgi?id=49793
319
320         Set minimum-font-size to 0 for the DRT.
321
322         * DumpRenderTree/gtk/DumpRenderTree.cpp:
323         (resetDefaultsToConsistentValues):
324
325 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
326
327         Reviewed by Darin Adler.
328
329         Make old-run-webkit-tests more robust on buildbots
330         https://bugs.webkit.org/show_bug.cgi?id=52364
331
332         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
333
334 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
335
336         Reviewed by Darin Adler.
337
338         Make old-run-webkit-tests more robust on buildbots
339         https://bugs.webkit.org/show_bug.cgi?id=52364
340
341         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
342
343 2011-01-13  Tony Chang  <tony@chromium.org>
344
345         Reviewed by Kent Tamura.
346
347         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
348         https://bugs.webkit.org/show_bug.cgi?id=52332
349
350         Forked Info.plist is not longer needed.
351
352         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
353
354 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
355
356         Reviewed by Timothy Hatcher.
357
358         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
359         to be passed directly to WebInspector.UIString
360
361         https://bugs.webkit.org/show_bug.cgi?id=52365
362
363         * Scripts/check-inspector-strings:
364
365 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
366
367         Unreviewed, rolling out r74881.
368         http://trac.webkit.org/changeset/74881
369         https://bugs.webkit.org/show_bug.cgi?id=52357
370
371         The EFL builder has been red for days (Requested by abarth on
372         #webkit).
373
374         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
375         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
376
377 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
378
379         Reviewed by David Levin.
380
381         Add beforeunload support to WebKitTestRunner
382         https://bugs.webkit.org/show_bug.cgi?id=52353
383         
384         This makes a number of currently failing tests pass.
385
386         * WebKitTestRunner/TestController.cpp:
387         (WTR::runBeforeUnloadConfirmPanel):
388         (WTR::createOtherPage):
389         (WTR::TestController::initialize):
390
391 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
392
393         Reviewed by Sam Weinig.
394
395         Detect, identify and recover from WebProcess crashes in run-webkit-tests
396         https://bugs.webkit.org/show_bug.cgi?id=52330
397
398         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
399         a web process crash.
400         * WebKitTestRunner/TestController.cpp:
401         (WTR::TestController::initialize): Set up a processDidCrash
402         callback.
403         (WTR::TestController::processDidCrash): Report that the Web process
404         crashed.
405         * WebKitTestRunner/TestController.h:
406
407 2011-01-12  David Levin  <levin@chromium.org>
408
409         Reviewed by Shinichiro Hamaji.
410
411         check-webkit-style -- close_expression function doesn't work correctly.
412         https://bugs.webkit.org/show_bug.cgi?id=52272
413
414         * Scripts/webkitpy/style/checkers/cpp.py:
415         (Position.__str__): Added a way to convert it to a string which is useful in tests.
416         (Position.__cmp__): Added a way to compare Position which is useful in tests and
417         generally useful (for upcoming code changes).
418         (close_expression): Changed to use Position for input and output.
419         Also, fixed many bugs such as only working correctly for parenthesis,
420         not working correctly if given an offset in a line and not finding
421         the real closing element if there were multiple closing elements in
422         the same line.
423         (detect_functions): Adjusted due to the change in arguments for
424         close_expression.
425         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
426         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
427         two positions are the same.
428         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
429         (CppStyleTest.test_close_expression): Added tests to catch the issues
430         that were fixed.
431
432 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
433
434         Unreviewed, rolling out r75576.
435         http://trac.webkit.org/changeset/75576
436         https://bugs.webkit.org/show_bug.cgi?id=52304
437
438         broke rebaseline-chromium-webkit-test (Requested by thakis on
439         #webkit).
440
441         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
442         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
443         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
444         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
445         * Scripts/webkitpy/layout_tests/port/base.py:
446         * Scripts/webkitpy/layout_tests/port/chromium.py:
447         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
448         * Scripts/webkitpy/layout_tests/port/test.py:
449         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
450         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
451         * Scripts/webkitpy/style/checkers/test_expectations.py:
452         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
453
454 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
455
456         Reviewed by Darin Adler.
457
458         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
459         https://bugs.webkit.org/show_bug.cgi?id=52307
460
461         * Scripts/old-run-webkit-tests:
462
463 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
464
465         Reviewed by Martin Robinson.
466
467         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
468         https://bugs.webkit.org/show_bug.cgi?id=50867
469
470         Fixed library extention for Mac in webkitdirs.pm and type conflict in
471         TestNetscapePlugin.cpp 
472
473         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
474         * Scripts/webkitdirs.pm:
475
476 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
477
478         Reviewed by Pavel Feldman.
479
480         Add check-inspector-strings script.
481
482         https://bugs.webkit.org/show_bug.cgi?id=52295
483
484         * Scripts/check-inspector-strings: Added.
485
486 2011-01-12  Adam Roben  <aroben@apple.com>
487
488         Advertise the .testnetscape file extension on Windows
489
490         Fixes <http://webkit.org/b/52298>
491         plugins/no-mime-with-valid-extension.html fails on Windows
492
493         Reviewed by Dan Bernstein.
494
495         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
496         FileExtents field to map the .testnetscape file extension to the
497         application/x-webkit-test-netscape MIME type, just as we do on Mac.
498
499 2011-01-12  Adam Barth  <abarth@webkit.org>
500
501         Reviewed by Eric Seidel.
502
503         Make webkit-patch support subdirectories for SVN checkouts
504         https://bugs.webkit.org/show_bug.cgi?id=52261
505
506         os.relpath does not exist on Python 2.5, so we need to call our version
507         of the API.
508
509         * Scripts/webkitpy/common/checkout/scm.py:
510
511 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
512
513         Reviewed by Eric Seidel.
514
515         Close additional pages opened during a test once the test completes.
516         https://bugs.webkit.org/show_bug.cgi?id=52276
517
518         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
519         (WTR::InjectedBundle::done):
520
521 2011-01-11  David Levin  <levin@chromium.org>
522
523         Reviewed by Eric Seidel.
524
525         Errors should be separated from the command line in bot messages.
526         https://bugs.webkit.org/show_bug.cgi?id=52275
527
528         * Scripts/webkitpy/common/system/executive.py:
529         (ScriptError.message_with_output): Added a newline to separate the command
530         line from the errors.
531         * Scripts/webkitpy/common/system/executive_unittest.py:
532         (ScriptErrorTest.test_message_with_output): Added tests for the various code
533         paths in message_with_output.
534
535 2011-01-11  Eric Seidel  <eric@webkit.org>
536
537         Unreviewed.
538
539         commit-queue should know how to upload archived results (for test flakes or general failures)
540         https://bugs.webkit.org/show_bug.cgi?id=52048
541
542         The zips are mostly empty due to forgetting -r.
543         Expected diffs were not being pulled from the archive due
544         to the archive having longer paths than I realized.
545
546         * Scripts/webkitpy/common/system/workspace.py:
547         * Scripts/webkitpy/common/system/workspace_unittest.py:
548         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
549         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
550
551 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
552
553         Reviewed by Ojan Vafai.
554
555         The current modifier parsing code in test_expectations is
556         fragile and hard-coded, so it's not easy to understand the logic
557         or easily add new types of modifiers (like GPU vs. CPU testing
558         for graphics tests, or 32-bit vs. 64-bit differences).
559
560         This is the first of two patches that will add in more generic
561         support and then eliminate the GPU-specific test expectations
562         files for Chromium.
563
564         This patch adds two standalone objects for handling modifiers. The
565         rules for interpreting modifiers, precedence, and conflicts are
566         given in the docstring to the ModifierMatcher class, which
567         returns ModifierMatchResult objects.
568         
569         This patch also adds routines to the Port interface and a
570         default set of values in the base object, in order to obtain the
571         values needed on a given test run. These values are then passed
572         to the expectation parser. This also allows us to clean up the
573         logic used to lint all of the different configurations in a
574         single test_expectations.txt file.
575
576         The next patch will merge in the separate GPU expectations file.
577
578         https://bugs.webkit.org/show_bug.cgi?id=51222
579
580         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
581         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
582         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
583         * Scripts/webkitpy/layout_tests/port/base.py:
584         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
585         * Scripts/webkitpy/layout_tests/port/chromium.py:
586         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
587         * Scripts/webkitpy/layout_tests/port/test.py:
588         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
589         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
590
591 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
592
593         Reviewed by Adam Barth.
594
595         Make webkit-patch support subdirectories for SVN checkouts
596         https://bugs.webkit.org/show_bug.cgi?id=52261
597
598         * Scripts/webkitpy/common/checkout/scm.py:
599         * Scripts/webkitpy/style_references.py:
600         * Scripts/webkitpy/tool/main.py:
601         * Scripts/webkitpy/tool/steps/preparechangelog.py:
602
603 2011-01-11  Eric Seidel  <eric@webkit.org>
604
605         Unreviewed.
606
607         commit-queue should know how to upload archived results (for test flakes or general failures)
608         https://bugs.webkit.org/show_bug.cgi?id=52048
609
610         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
611         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
612
613         * Scripts/webkitpy/common/system/workspace.py:
614         * Scripts/webkitpy/common/system/workspace_unittest.py:
615         * Scripts/webkitpy/tool/commands/queues.py:
616
617 2011-01-11  Sam Weinig  <sam@webkit.org>
618
619         Roll r75474 back in.
620
621 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
622
623         Reviewed by Kenneth Rohde Christiansen.
624
625         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
626         https://bugs.webkit.org/show_bug.cgi?id=51204
627
628         * QtTestBrowser/webpage.h:
629         (QtNAMThread::QtNAMThread):
630         (QtNAMThread::networkAccessManager):
631         (QtNAMThread::run):
632
633 2011-01-11  Peter Varga  <pvarga@webkit.org>
634
635         Unreviewed.
636
637         Add myself to committers' list.
638
639         * Scripts/webkitpy/common/config/committers.py:
640
641 2011-01-11  Eric Seidel  <eric@webkit.org>
642
643         Reviewed by Adam Barth.
644
645         commit-queue should know how to upload archived results (for test flakes or general failures)
646         https://bugs.webkit.org/show_bug.cgi?id=52048
647
648         Now the queue will always upload results.  Either the entire zip, or just
649         the diffs.txt in the case of text failures.
650
651         This should make understanding flakes much easier, and paves the way
652         for having the EWS run layout tests (and upload failures).
653
654         In order to upload .zip files I had to teach bugzilla.py to autodetect
655         mime types from the filename.  Since mimetypes.py doesn't include a mapping
656         for .patch files, I have it add one before calling guess_type.
657
658         We may find that always uploading the whole zip instead of just the -diffs.txt
659         file is preferable, but for now I'm keeping the old behavior because it makes
660         quickly understanding text failures easy.
661
662         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
663         * Scripts/webkitpy/common/system/workspace.py: Added.
664         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
665         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
666         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
667         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
668         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
669         * Scripts/webkitpy/tool/commands/queues.py:
670         * Scripts/webkitpy/tool/commands/queues_unittest.py:
671
672 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
673
674         Unreviewed, rolling out r75464.
675         http://trac.webkit.org/changeset/75464
676         https://bugs.webkit.org/show_bug.cgi?id=52193
677
678         Followup rollout for 75474 (Requested by Ossy on #webkit).
679
680         * MiniBrowser/mac/BrowserWindowController.m:
681         (-[BrowserWindowController awakeFromNib]):
682         * MiniBrowser/win/BrowserView.cpp:
683         (BrowserView::create):
684         * WebKitTestRunner/TestController.cpp:
685         (WTR::createOtherPage):
686         (WTR::TestController::initialize):
687
688 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
689
690         Reviewed by Csaba Osztrogonác.
691
692         [Qt] Baseline qt_minimal configuration
693         https://bugs.webkit.org/show_bug.cgi?id=51313
694
695         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
696         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
697         QT_NO_UNDOSTACK guard.
698
699         * QtTestBrowser/launcherwindow.cpp:
700         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
701         guards.
702         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
703         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
704         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
705         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
706
707         * QtTestBrowser/launcherwindow.h:
708         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
709         * QtTestBrowser/locationedit.h: Ditto.
710
711         * QtTestBrowser/mainwindow.cpp:
712         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
713         QT_NO_UNDOSTACK guards.
714         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
715         (MainWindow::changeLocation): Ditto.
716         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
717         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
718
719         * QtTestBrowser/webpage.cpp:
720         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
721         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
722
723         * QtTestBrowser/webview.cpp:
724         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
725         (WebViewGraphicsBased::animatedYFlip): Ditto.
726
727 2011-01-10  Sam Weinig  <sam@webkit.org>
728
729         Fix build.
730
731         * MiniBrowser/mac/BrowserWindowController.m:
732         (-[BrowserWindowController awakeFromNib]):
733         * MiniBrowser/win/BrowserView.cpp:
734         (BrowserView::create):
735         * WebKitTestRunner/TestController.cpp:
736         (WTR::createOtherPage):
737         (WTR::TestController::initialize):
738
739 2011-01-10  Eric Seidel  <eric@webkit.org>
740
741         Reviewed by Ojan Vafai.
742
743         style-queue messages are way too long for big patches
744         https://bugs.webkit.org/show_bug.cgi?id=52161
745
746         We definitely could build much fancier list-to-string-with-limit functions
747         but this should be sufficient for our needs at the moment.
748
749         * Scripts/webkitpy/common/system/executive.py:
750         * Scripts/webkitpy/common/system/executive_unittest.py:
751
752 2011-01-10  Tony Chang  <tony@chromium.org>
753
754         Unreviewed, rolling out r75398.
755         http://trac.webkit.org/changeset/75398
756         https://bugs.webkit.org/show_bug.cgi?id=52008
757
758         Some layout tests are crashing on Chromium Win.
759
760         * DumpRenderTree/chromium/WebViewHost.cpp:
761         (WebViewHost::updatePaintRect):
762         * DumpRenderTree/chromium/WebViewHost.h:
763
764 2011-01-10  Adam Roben  <aroben@apple.com>
765
766         Roll out r75392
767
768         It isn't needed now that r75289 has been rolled out.
769
770         * Scripts/run-javascriptcore-tests:
771
772 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
773
774         Reviewed by Anders Carlsson.
775
776         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
777         https://bugs.webkit.org/show_bug.cgi?id=52160
778
779         * WebKitTestRunner/mac/TestControllerMac.mm:
780         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
781         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
782         anyway.
783
784 2011-01-10  Tony Chang  <tony@chromium.org>
785
786         Reviewed by Mihai Parparita.
787
788         [chromium] fix for animated gif layout tests
789         https://bugs.webkit.org/show_bug.cgi?id=52008
790
791         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
792             to trigger gif animations.
793         (WebViewHostPaintTask::WebViewHostPaintTask):
794         (WebViewHostPaintTask::runIfValid):
795         (WebViewHost::updatePaintRect):
796         * DumpRenderTree/chromium/WebViewHost.h:
797         (WebViewHost::taskList):
798
799 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
800
801         Reviewed by Xan Lopez.
802
803         [GTK] Fix gtk2 compilation for master
804         https://bugs.webkit.org/show_bug.cgi?id=51885
805
806         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
807         (createBitmapContextFromWebView): Replaced the old
808         gdk_drawable_get_size with gdk_pixmap_get_size.
809
810 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
811
812         Reviewed by Laszlo Gombos.
813
814         [WINCE] Reenable NPAPI after r75203
815         https://bugs.webkit.org/show_bug.cgi?id=52109
816
817         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
818         it with !isEfl(), because EFL port does not support NPAPI (yet).
819
820         * Scripts/build-webkit:
821
822 2011-01-10  Adam Roben  <aroben@apple.com>
823
824         Skip some asserting JS tests
825
826         See <http://webkit.org/b/52156>.
827
828         * Scripts/run-javascriptcore-tests:
829
830 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
831
832         Reviewed by Xan Lopez.
833
834         [GTK] build-webkit disable Blob support via arguments passed to automake
835         https://bugs.webkit.org/show_bug.cgi?id=52097
836
837         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
838         build-webkit.
839
840 2011-01-10  Adam Roben  <aroben@apple.com>
841
842         Use the same name and description for TestNetscapePlugin on Windows and
843         Mac
844
845         Fixes <http://webkit.org/b/52151>
846         fast/frames/iframe-reparenting-plugins.html fails on Windows
847
848         Reviewed by Steve Falkenburg.
849
850         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
851         the name and description from Mac's Info.plist.
852
853 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
854
855         Reviewed by Laszlo Gombos.
856
857         [Qt][WK2] Guard gcc-specific syntax
858
859         Non-gcc based compliers choke on the "-include"
860         syntax for preinclude, place guard around it.
861
862         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
863         * WebKitTestRunner/qt/WebKitTestRunner.pro:
864
865 2011-01-10  Andreas Kling  <kling@webkit.org>
866
867         Reviewed by Simon Hausmann.
868
869         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
870         https://bugs.webkit.org/show_bug.cgi?id=52111
871
872         When getting a createNewPage() callback from QWKPage, create the
873         new page with the same QWKContext as the page that is passed to
874         the callback.
875
876         * MiniBrowser/qt/BrowserView.h:
877         * MiniBrowser/qt/BrowserWindow.cpp:
878         (newPageFunction):
879         (BrowserWindow::BrowserWindow):
880         * MiniBrowser/qt/BrowserWindow.h:
881
882 2011-01-10  Andreas Kling  <kling@webkit.org>
883
884         Reviewed by Kenneth Rohde Christiansen.
885
886         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
887
888         BrowserView set its own useless createNewPage() callback on QWKPage.
889         This was immediately overridden by BrowserWindow anyway, so remove
890         the BrowserView one.
891
892         * MiniBrowser/qt/BrowserView.cpp:
893         (BrowserView::BrowserView):
894
895 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
896
897         Reviewed by Jeremy Orlow.
898
899         [Chromium] Remove non-client-based Geolocation code
900         https://bugs.webkit.org/show_bug.cgi?id=50921
901
902         * DumpRenderTree/chromium/LayoutTestController.cpp:
903         (LayoutTestController::setGeolocationPermission):
904         (LayoutTestController::setMockGeolocationPosition):
905         (LayoutTestController::setMockGeolocationError):
906         * DumpRenderTree/chromium/WebViewHost.cpp:
907         (WebViewHost::geolocationClientMock):
908         (WebViewHost::reset):
909         * DumpRenderTree/chromium/WebViewHost.h:
910
911 2011-01-10  Eric Seidel  <eric@webkit.org>
912
913         Reviewed by Adam Barth.
914
915         Commit bot tried to land r? cq+ patch
916         https://bugs.webkit.org/show_bug.cgi?id=36638
917
918         It should now be possible to post a patch with r? and cq+ and the
919         commit-queue will correctly wait for the r+ before attempting to land the patch.
920         (This was a feature requested by several users.)
921
922         One caveat: We don't actually reject r-, cq+ patches from the queue
923         (we just ignore them), but I think that's OK for now.
924
925         I also noticed that setting r- once a commit-queue node had grabbed
926         a patch would not properly cancel the landing.  That's fixed and
927         tested in this patch.
928
929         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
930         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
931         * Scripts/webkitpy/tool/bot/feeders.py:
932         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
933
934 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
935
936         Reviewed by Kenneth Rohde Christiansen.
937
938         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
939         https://bugs.webkit.org/show_bug.cgi?id=51934
940
941         When accessing the network from the destructor of QWebPage, the network access manager
942         was already deleted because the object WebPage was already destructed.
943
944         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
945         The object is now destructed in the destructor of QObject.
946
947         * QtTestBrowser/webpage.cpp:
948         (WebPage::WebPage):
949         (WebPage::setQnamThreaded):
950         * QtTestBrowser/webpage.h:
951         (QtNAMThread::QtNAMThread):
952
953 2011-01-08  Eric Seidel  <eric@webkit.org>
954
955         Reviewed by Ojan Vafai.
956
957         test_failures.py should not mention TestShell (long live DumpRenderTree!)
958         https://bugs.webkit.org/show_bug.cgi?id=52067
959
960         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
961         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
962
963         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
964
965 2011-01-08  Eric Seidel  <eric@webkit.org>
966
967         Reviewed by Mihai Parparita.
968
969         commit-queue hangs when the ChangeLog diff is bad
970         https://bugs.webkit.org/show_bug.cgi?id=52072
971
972         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
973         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
974
975 2011-01-08  Adam Barth  <abarth@webkit.org>
976
977         Teach svn-apply how to re-write WebCore to Source/WebCore.
978
979         * Scripts/VCSUtils.pm:
980
981 2011-01-07  Adam Barth  <abarth@webkit.org>
982
983         Rubber-stamped by Eric Seidel.
984
985         Move WebCore to Source
986         https://bugs.webkit.org/show_bug.cgi?id=52050
987
988         Update the tools to understand WebCore's new location.
989
990         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
991         * DumpRenderTree/wscript:
992         * GNUmakefile.am:
993         * Scripts/build-webkit:
994         * Scripts/do-file-rename:
995         * Scripts/do-webcore-rename:
996         * Scripts/generate-qt-inspector-resource:
997         * Scripts/prepare-ChangeLog:
998         * Scripts/run-bindings-tests:
999         * Scripts/update-iexploder-cssproperties:
1000         * Scripts/update-sources-list.py:
1001         * Scripts/update-webkit-localizable-strings:
1002         * Scripts/webkitdirs.pm:
1003         * Scripts/webkitpy/common/config/build.py:
1004         * Scripts/webkitpy/common/config/build_unittest.py:
1005         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1006         * Scripts/webkitpy/style/checker.py:
1007         * Scripts/webkitpy/style/checker_unittest.py:
1008         * WebKitTestRunner/DerivedSources.pro:
1009         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1010         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
1011         * wx/browser/wscript:
1012         * wx/build/settings.py:
1013
1014 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
1015
1016         Reviewed by Sam Weinig.
1017
1018         Make WebKitTestRunner rest between loads more robust to avoid test crashes
1019         https://bugs.webkit.org/show_bug.cgi?id=52086
1020
1021         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1022         (WTR::InjectedBundle::didReceiveMessage):
1023         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1024         (WTR::LayoutTestController::notifyDone):
1025         * WebKitTestRunner/TestController.cpp:
1026         (WTR::TestController::resetStateToConsistentValues):
1027         (WTR::TestController::run):
1028
1029 2011-01-07  James Robinson  <jamesr@chromium.org>
1030
1031         Revert "Implement mozilla's animationTime property"
1032         https://bugs.webkit.org/show_bug.cgi?id=51952
1033
1034         This approach isn't quite right.
1035
1036         * DumpRenderTree/chromium/WebViewHost.cpp:
1037         (WebViewHost::paintInvalidatedRegion):
1038
1039 2011-01-07  Adam Roben  <aroben@apple.com>
1040
1041         Build master fix
1042
1043         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1044         (RunWebKitTests.start): Don't try to concatenate a list and a string.
1045
1046 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
1047
1048         Reviewed by Csaba Osztrogonác.
1049
1050         run-qtwebkit-tests should be able to kill a testsuite.
1051
1052         Add new option in the script that can setup a timeout for a test.
1053         If the test execution takes more then specified time then the test
1054         would be terminated.
1055
1056         [Qt] run-qtwebkit-tests needs timeout
1057         https://bugs.webkit.org/show_bug.cgi?id=51894
1058
1059         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1060         * Scripts/run-qtwebkit-tests:
1061
1062 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
1063
1064         Unreviewed fix after r75233.
1065
1066         Based on idea from Eric Seidel.
1067
1068         Add remote zip file handling to webkitpy.
1069         https://bugs.webkit.org/show_bug.cgi?id=50901
1070
1071         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
1072
1073 2011-01-07  Shane Stephens  <shanestephens@google.com>
1074
1075         Reviewed by Eric Seidel.
1076
1077         svn-apply: should support git binary delta diffs
1078         https://bugs.webkit.org/show_bug.cgi?id=38864
1079
1080         * Scripts/VCSUtils.pm:
1081         * Scripts/svn-apply:
1082
1083 2011-01-06  Julie Parent  <jparent@chromium.org>
1084
1085         Reviewed by Eric Seidel.
1086
1087         Test Result Server not removing old results.
1088         https://bugs.webkit.org/show_bug.cgi?id=52012
1089
1090         * TestResultServer/model/jsonresults.py:
1091         Fix off-by-one: Truncate if >= num_runs, not just >.
1092         * TestResultServer/model/jsonresults_unittest.py:
1093         Add unit test to test that merging in a new result with the same value
1094         as the last result causes previous result to fall off.
1095
1096 2011-01-06  James Kozianski  <koz@chromium.org>
1097
1098         Reviewed by Mihai Parparita.
1099
1100         Add classes to provide a consistent interface to a set of files.
1101         https://bugs.webkit.org/show_bug.cgi?id=50901
1102
1103         These classes allow us to write code that is agnostic to whether a
1104         particular set of files resides in a local directory or in a zip file
1105         on a remote machine.
1106
1107         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
1108         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
1109         * Scripts/webkitpy/common/system/fileset.py: Added.
1110         * Scripts/webkitpy/common/system/filesystem.py:
1111         * Scripts/webkitpy/common/system/filesystem_mock.py:
1112         * Scripts/webkitpy/common/system/zipfileset.py: Added.
1113         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
1114
1115 2011-01-06  Eric Seidel  <eric@webkit.org>
1116
1117         Reviewed by Adam Barth.
1118
1119         NetworkTransaction should log the url it is retrying
1120         https://bugs.webkit.org/show_bug.cgi?id=52043
1121
1122         * Scripts/webkitpy/common/net/networktransaction.py:
1123         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
1124
1125 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1126
1127         Windows build fix.
1128         Import os before using it.
1129
1130         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1131
1132 2011-01-06  Eric Seidel  <eric@webkit.org>
1133
1134         Reviewed by Adam Barth.
1135
1136         StyleQueue fails to report errors when patches have many files
1137         https://bugs.webkit.org/show_bug.cgi?id=52042
1138
1139         This is one of at least two errors preventing style error reporting at the moment.
1140         When we moved to passing the list of files to check explicitly,
1141         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
1142         We could change the type of the QueueStatus.message type, or we could
1143         just teach statusserver.py how to clamp values (and warn when it does).
1144         I chose the latter path.
1145
1146         * Scripts/webkitpy/common/net/statusserver.py:
1147
1148 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1149
1150         Reviewed by Stephanie Lewis.
1151         
1152         Fix syntax error in script.
1153
1154         Windows bots need to archive/unarchive builds to/from configuration-specific directories
1155         https://bugs.webkit.org/show_bug.cgi?id=51996
1156
1157         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1158
1159 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1160
1161         Unreviewed, fixing WinCE build after r75196.
1162
1163         WinCE port does not (yet) support NPAPI.
1164
1165         * Scripts/build-webkit:
1166
1167 2011-01-06  Xan Lopez  <xlopez@igalia.com>
1168
1169         Reviewed by Darin Adler.
1170
1171         File::Spec->rel2abs in sunspider-compare-results mangles parameters
1172         https://bugs.webkit.org/show_bug.cgi?id=52015
1173
1174         * Scripts/sunspider-compare-results: call rel2abs on our arguments
1175         after the platform has been detected, otherwise the script will
1176         mangle things like '--gtk' into '/a/path/--gtk', breaking the
1177         detection.
1178
1179 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1180
1181         Reviewed by Eric Seidel.
1182
1183         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
1184         https://bugs.webkit.org/show_bug.cgi?id=51346
1185
1186         * Scripts/build-webkit:
1187
1188 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1189
1190         Reviewed by Adam Roben.
1191
1192         Windows bots need to archive/unarchive builds to/from configuration-specific directories
1193         https://bugs.webkit.org/show_bug.cgi?id=51996
1194         
1195         After the configuration directory change, we were archiving the incorrect directory for
1196         build product, so we were running tests on the wrong binaries.
1197         
1198         This change archives the correct directory, and also unarchives it into a configuration-
1199         specific directory.
1200
1201         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
1202         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
1203
1204 2011-01-06  Eric Seidel  <eric@webkit.org>
1205
1206         Reviewed by Mihai Parparita.
1207
1208         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
1209         https://bugs.webkit.org/show_bug.cgi?id=52002
1210
1211         See an example of this here:
1212         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
1213
1214         It's due to the fact that we pass around TestFailure() instance
1215         objects and yet expect them to all compare to be the same.
1216
1217         This is bad.  We should either have shared instances of these values
1218         or we should just pass around the class names.  There are already hacks
1219         in place to make TestFailure objects pass equality tests, I just added
1220         a __hash__ implementation so they can be used in sets as expected.
1221
1222         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1223         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1224
1225 2011-01-06  Evan Martin  <evan@chromium.org>
1226
1227         Reviewed by Tony Chang.
1228
1229         [gdb] handle inaccessible memory and UChar*
1230         https://bugs.webkit.org/show_bug.cgi?id=52003
1231
1232         To pretty-print a UChar*, we just grope around in the memory
1233         looking for a terminating NUL.  We need to handle the exception
1234         that can occur when we poke into an invalid location.
1235
1236         Additionally, the logic for choosing which pretty-printer would
1237         early return before hitting the point where we'd use the UChar*
1238         printer.  (Did this ever work?  How did it regress?)
1239
1240         * gdb/webkit.py:
1241
1242 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
1243
1244         Reviewed by Ada Chan.
1245
1246         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
1247         https://bugs.webkit.org/show_bug.cgi?id=51969
1248         
1249         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
1250
1251         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1252         (WTR::InjectedBundlePage::InjectedBundlePage):
1253         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
1254         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1255
1256 2011-01-06  James Robinson  <jamesr@chromium.org>
1257
1258         Reviewed by Simon Fraser.
1259
1260         Implement mozilla's animationTime property
1261         https://bugs.webkit.org/show_bug.cgi?id=51952
1262
1263         Chromium DRT support for webkitAnimationTime.
1264
1265         * DumpRenderTree/chromium/WebViewHost.cpp:
1266         (WebViewHost::paintInvalidatedRegion):
1267
1268 2011-01-06  Julie Parent  <jparent@chromium.org>
1269
1270         Reviewed by Tony Chang.
1271
1272         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
1273         https://bugs.webkit.org/show_bug.cgi?id=51217
1274
1275         * TestResultServer/model/jsonresults.py:
1276         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
1277         Adds missing documentation.
1278         * TestResultServer/model/jsonresults_unittest.py:
1279         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
1280         Update test_merge to take a number of builds to truncate at.
1281
1282 2011-01-06  Adam Barth  <abarth@webkit.org>
1283
1284         Reviewed by Eric Seidel.
1285
1286         The EWS should log outside of the working directory
1287         https://bugs.webkit.org/show_bug.cgi?id=51986
1288
1289         This patch prepare us for using git clean -x -d -f in the EWS wrapper
1290         script, which will actually clean the working copy back to a pristine
1291         state instead of leaving untracked directories and ignored files.
1292
1293         * Scripts/webkitpy/tool/commands/queues.py:
1294         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1295
1296 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1297
1298         Windows build fix.
1299         Back out attempted change to built-product-archive.
1300
1301         * BuildSlaveSupport/built-product-archive:
1302
1303 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1304
1305         Windows build fix.
1306         Include configuration name when unpacking a build archive.
1307
1308         Needed, since we split Windows build results into configuration-specific directories
1309         under WebKitOutputDir.
1310
1311         * BuildSlaveSupport/built-product-archive:
1312
1313 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1314
1315         Reviewed by Darin Adler.
1316
1317         Debug and Release builds on Windows clobber each other
1318         https://bugs.webkit.org/show_bug.cgi?id=49185
1319
1320         Changes the structure of WebKitBuild build products directory so we
1321         completely separate each build configuration into independent directories.
1322         
1323         Although we previously had per-configuration directories for obj, this change adds
1324         per-configuration directories for bin, lib, obj, and include. Each configuration's
1325         build products are stored within a directory inside of WebKitBuild.
1326         
1327         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
1328         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
1329
1330         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
1331         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
1332         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
1333         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
1334         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
1335         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
1336         * DumpRenderTree/win/ImageDiffCommon.vsprops:
1337         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
1338         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
1339         * FindSafari/FindSafari.vcproj:
1340         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
1341         * MiniBrowser/MiniBrowserPostBuild.cmd:
1342         * MiniBrowser/MiniBrowserPreBuild.cmd:
1343         * Scripts/webkitdirs.pm:
1344         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
1345         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
1346         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
1347         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
1348         * TestWebKitAPI/win/copy-resources.cmd:
1349         * WebKitAPITest/WebKitAPITestCommon.vsprops:
1350         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
1351         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
1352         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
1353         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
1354         * WebKitTestRunner/win/InjectedBundle.vcproj:
1355         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
1356         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
1357         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
1358         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
1359         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
1360         * WinLauncher/WinLauncherCommon.vsprops:
1361         * WinLauncher/WinLauncherPostBuild.cmd:
1362         * WinLauncher/WinLauncherPreBuild.cmd:
1363
1364 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
1365
1366         Reviewed by Ariya Hidayat.
1367
1368         [Qt] TestNetscapePlugin doesn't link on OS X
1369         https://bugs.webkit.org/show_bug.cgi?id=51948
1370
1371         Only add a dependency on libX11 on X11 systems
1372
1373         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1374
1375 2011-01-05  Jeff Miller  <jeffm@apple.com>
1376
1377         Reviewed by Adam Roben.
1378
1379         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
1380         https://bugs.webkit.org/show_bug.cgi?id=51970
1381
1382         * Scripts/webkitpy/style/checker.py:
1383         Add -readability/naming for WebKit2 C API directories.
1384
1385 2011-01-05  Eric Seidel  <eric@webkit.org>
1386
1387         Unreviewed, just fixing one more log error from my previous python patch.
1388
1389         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1390         https://bugs.webkit.org/show_bug.cgi?id=51802
1391
1392         webkit-patch failure-reason was logging about parsing errors
1393         due to my misunderstanding of how BeautifulSoup.findAll worked.
1394
1395         Fixed, and added a unit test.
1396
1397         * Scripts/webkitpy/common/net/layouttestresults.py:
1398         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1399
1400 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
1401
1402         Reviewed by Kenneth Rohde Christiansen.
1403
1404         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
1405         https://bugs.webkit.org/show_bug.cgi?id=51951
1406
1407         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
1408         to create new window from WebKit.
1409
1410         * MiniBrowser/qt/BrowserWindow.cpp:
1411         (newPageFunction):
1412         (BrowserWindow::BrowserWindow):
1413         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
1414         (BrowserWindow::newWindow):
1415         (BrowserWindow::updateUserAgentList):
1416         (BrowserWindow::showUserAgentDialog):
1417         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
1418         define the type of the backing store used for new windows.
1419         * MiniBrowser/qt/main.cpp:
1420         (main):
1421
1422 2011-01-05  Eric Seidel  <eric@webkit.org>
1423
1424         Reviewed by Ojan Vafai.
1425
1426         commit-queue should report failure type when reporting flaky tests
1427         https://bugs.webkit.org/show_bug.cgi?id=51900
1428
1429         This patch was a ridiculous amount of plumbing.  In the end I like
1430         the NRWT-style TestResult class even less.  But now we're passing
1431         a list of TestResult objects from the queue to the FlakyTestReporter.
1432         Thus the FlakyTestReporter can more easily report what type of failure
1433         occurred.
1434
1435         In the process, I found that I was not alone in finding TestResult
1436         cumbersome to use.  A bunch of code was trying to create a TestResult
1437         object with default values.  However since the constructor didn't make
1438         this easy, some places were getting it wrong (including the TestResult unit test)!
1439         I've fixed the TestResult constructor to have default values for non-essential
1440         arguments.
1441
1442         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1443         * Scripts/webkitpy/common/net/layouttestresults.py:
1444         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1445         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1446         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1447         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1448         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
1449         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
1450         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1451         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1452         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1453         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1454         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1455         * Scripts/webkitpy/tool/commands/queues.py:
1456         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1457
1458 2011-01-05  Eric Seidel  <eric@webkit.org>
1459
1460         Unreviewed.
1461
1462         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1463         https://bugs.webkit.org/show_bug.cgi?id=51802
1464
1465         Add another unit test to cover a previously missing import.
1466
1467         * Scripts/webkitpy/common/net/layouttestresults.py:
1468         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1469
1470 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
1471
1472         Reviewed by David Levin.
1473
1474         Add mihaip@chromium.org as a reviewer
1475         https://bugs.webkit.org/show_bug.cgi?id=51966
1476         
1477         Add myself as a reviewer.
1478
1479         * Scripts/webkitpy/common/config/committers.py:
1480
1481 2011-01-05  James Simonsen  <simonjam@chromium.org>
1482
1483         Unreviewed. Adding myself to the list of committers.
1484
1485         * Scripts/webkitpy/common/config/committers.py:
1486
1487 2011-01-05  Eric Seidel  <eric@webkit.org>
1488
1489         Unreviewed.
1490
1491         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1492         https://bugs.webkit.org/show_bug.cgi?id=51802
1493
1494         Fix two exceptions seen on the bots after my original commit.
1495
1496         * Scripts/webkitpy/common/net/layouttestresults.py:
1497         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1498
1499 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
1500
1501         Reviewed by Andreas Kling.
1502
1503         [Qt]Add local storage settings to QtTestBrowser command line arguments 
1504         https://bugs.webkit.org/show_bug.cgi?id=51750
1505
1506         * QtTestBrowser/main.cpp:
1507         (LauncherApplication::handleUserOptions):
1508          Local storage settings can be enable form command line arguments for
1509          QtTestBrowser.
1510
1511 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
1512
1513         Reviewed by Martin Robinson.
1514
1515         GTK: AX: DRT needs to use correct root object method.
1516         https://bugs.webkit.org/show_bug.cgi?id=51911
1517
1518         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1519         (AccessibilityController::rootElement):
1520
1521 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1522
1523         Rubber-stamped by Csaba Osztrogonác.
1524
1525         Based on idea from Péter Gál.
1526
1527         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
1528
1529 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1530
1531         Reviewed by Adam Barth.
1532
1533         sheriff-bot should be able to do multi-revision rollouts
1534         https://bugs.webkit.org/show_bug.cgi?id=51176
1535
1536         * Scripts/webkitpy/tool/bot/irc_command.py:
1537         * Scripts/webkitpy/tool/bot/sheriff.py:
1538         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1539
1540 2011-01-05  Eric Seidel  <eric@webkit.org>
1541
1542         Reviewed by Adam Barth.
1543
1544         queues.webkit.org should have per-bot status pages
1545         https://bugs.webkit.org/show_bug.cgi?id=51906
1546
1547         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
1548         statuses from a single queue.  Now that we have many bots servicing
1549         some queues (commit-queue, win-ews, etc.) its easy to have the messages
1550         you care about scroll off the end of the 15-message limit on the main page.
1551
1552         Eventually we should probably rename /queue-status to /queue or /queues,
1553         but that's fodder for another patch.
1554
1555         * QueueStatusServer/handlers/queuestatus.py:
1556         * QueueStatusServer/index.yaml:
1557         * QueueStatusServer/main.py:
1558         * QueueStatusServer/templates/includes/singlequeuestatus.html:
1559          - This probably should use a custom filter instead of hard-coding
1560            the URL scheme here, but I couldn't figure out how to easily
1561            create such a filter.  Most filters work with "strings" so we can't
1562            pass the status object.  We could add a method to the status
1563            object and call that, but that seemed a bit strange too.
1564         * QueueStatusServer/templates/queuestatus.html:
1565
1566 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1567
1568         Unreviewed. Adding myself to the list of committers.
1569
1570         * Scripts/webkitpy/common/config/committers.py:
1571
1572 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
1573
1574         Reviewed by David Levin.
1575
1576         check-webkit-style treated some macros with parentheses after #elif as function calls
1577         https://bugs.webkit.org/show_bug.cgi?id=51695
1578
1579         Ingore function call space checking in any preprocessor directives
1580         (things starting with #). Change search() to match() because 
1581         preprocessor directives are supposed to be in the beginning of lines.
1582
1583         * Scripts/webkitpy/style/checkers/cpp.py:
1584         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
1585
1586 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
1587
1588         Reviewed by Tony Chang.
1589
1590         Change the --multi-load test option to --stress-opt
1591         https://bugs.webkit.org/show_bug.cgi?id=50751
1592
1593         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1594         (runTest):
1595         (main):
1596         * DumpRenderTree/chromium/TestShell.cpp:
1597         (TestShell::TestShell):
1598         * DumpRenderTree/chromium/TestShell.h:
1599         (TestShell::stressOpt):
1600         (TestShell::setStressOpt):
1601         (TestShell::stressDeopt):
1602         (TestShell::setStressDeopt):
1603         (TestShell::javaScriptFlags):
1604         (TestShell::setJavaScriptFlags):
1605         * Scripts/webkitpy/layout_tests/port/chromium.py:
1606         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1607
1608 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
1609
1610         Reviewed by Sam Weinig.
1611
1612         WK2: Support Accessibility
1613         https://bugs.webkit.org/show_bug.cgi?id=51859
1614
1615         Use rootObject() method to get top of accessibility tree.
1616
1617         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1618         (AccessibilityController::focusedElement):
1619         (AccessibilityController::rootElement):
1620
1621 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
1622
1623         Reviewed by Darin Adler.
1624
1625         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
1626         https://bugs.webkit.org/show_bug.cgi?id=51846
1627
1628         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
1629         back to GRefPtr.
1630
1631 2011-01-04  Zhe Su  <suzhe@chromium.org>
1632
1633         Reviewed by Kenneth Russell.
1634
1635         Fix insertText, setMarkedText and unmarkText methods of
1636         TextInputController to call corresponding methods of WebKit::WebView
1637         rather than WebKit::WebFrame. This change matches the behavior of
1638         chromium browser.
1639         insertText corresponds to WebView::confirmComposition(text)
1640         setMarkedText corresponds to WebView::setComposition(...)
1641         unmarkText corresponds to WebView::confirmComposition()
1642         https://bugs.webkit.org/show_bug.cgi?id=51693
1643
1644         * DumpRenderTree/chromium/TextInputController.cpp:
1645         (TextInputController::insertText):
1646         (TextInputController::setMarkedText):
1647         (TextInputController::unmarkText):
1648
1649 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
1650
1651         Reviewed by Laszlo Gombos.
1652
1653         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
1654
1655         On Symbian productDir points to the source directory. Removing all the
1656         empty files from the productDir directory corrupts the svn repository.
1657
1658         * Scripts/build-webkit:
1659
1660 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
1661
1662         Reviewed by Adam Barth.
1663
1664         [Qt] Add SelectAll option to the context menu for the editor
1665         https://bugs.webkit.org/show_bug.cgi?id=50049
1666
1667         Set shortcut for the SelectAll action.
1668
1669         * QtTestBrowser/mainwindow.cpp:
1670         (MainWindow::buildUI):
1671
1672 2011-01-03  David Levin  <levin@chromium.org>
1673
1674         Reviewed by Eric Seidel.
1675
1676         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
1677         https://bugs.webkit.org/show_bug.cgi?id=51842
1678
1679         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
1680         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
1681
1682 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
1683
1684         Reviewed by David Kilzer.
1685
1686         [WINCE] Adds a build slave.
1687         https://bugs.webkit.org/show_bug.cgi?id=50523
1688
1689         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
1690         entry for a release build of the WinCE port.
1691         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
1692         flag to build the WinCE port.
1693
1694 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
1695
1696         Reviewed by David Kilzer.
1697
1698         Add WinCE support to build-webkit
1699         https://bugs.webkit.org/show_bug.cgi?id=51642
1700
1701         * Scripts/build-webkit:
1702         * Scripts/webkitdirs.pm:
1703
1704 2011-01-03  Eric Seidel  <eric@webkit.org>
1705
1706         Reviewed by Adam Barth.
1707
1708         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1709         https://bugs.webkit.org/show_bug.cgi?id=51802
1710
1711         I'm not the biggest fan of the test_failures or test_results classes,
1712         but it's better to have one shared set of classes, than separate ones
1713         for new vs. old run-webkit-test result handling.
1714
1715         This moves the ORWT results class "LayoutTestResults" over to using
1716         TestResult and TestFailure classes, making it easy for us to
1717         make all our sheriff-bot and other webkitpy code NRWT ready.
1718
1719         This also makes it a trivial patch to generate results.json information
1720         from ORWT results.html files (for flaky test analysis, etc.) as well
1721         as making it a one-liner to report test failure types when the
1722         commit-queue sees flaky tests.
1723
1724         This patch tried not to add new functionality, but only to replace
1725         the guts of LayoutTestResults, while adding unit tests and hoping
1726         not to break anything.
1727
1728         I also moved callers which assumed User.prompt* were static/class methods
1729         to using them as instance methods (since we'll eventually want to make them such).
1730
1731         In the process of re-writing things, I broke the rebaseline command, so I wrote
1732         a unit test to catch my breakage were I do do so again in the future.
1733
1734         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1735         * Scripts/webkitpy/common/net/layouttestresults.py:
1736         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1737         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1738         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
1739         * Scripts/webkitpy/tool/commands/queries.py:
1740         * Scripts/webkitpy/tool/commands/rebaseline.py:
1741         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1742         * Scripts/webkitpy/tool/mocktool.py:
1743
1744 2011-01-03  Adam Barth  <abarth@webkit.org>
1745
1746         Reviewed by Simon Fraser.
1747
1748         webkit-patch shouldn't waste time cleaning a working directory that's already clean
1749         https://bugs.webkit.org/show_bug.cgi?id=51840
1750
1751         * Scripts/webkitpy/common/checkout/scm.py:
1752
1753 2011-01-03  Adam Barth  <abarth@webkit.org>
1754
1755         Reviewed by Simon Fraser.
1756
1757         webkit-patch should only hide update output if --quiet
1758         https://bugs.webkit.org/show_bug.cgi?id=51838
1759
1760         As requested by smfr.
1761
1762         * Scripts/webkitpy/tool/steps/update.py:
1763
1764 2011-01-03  Adam Barth  <abarth@webkit.org>
1765
1766         Reviewed by David Levin.
1767
1768         commit-queue shouldn't reject patches twice if two bots process the same patch
1769         https://bugs.webkit.org/show_bug.cgi?id=51805
1770
1771         Before raising an error, we first check whether the patch is still in
1772         the commit-queue.  This check is still racy, of course, but the time
1773         window is much smaller.
1774
1775         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1776
1777 2011-01-03  Sam Weinig  <sam@webkit.org>
1778
1779         Reviewed by Anders Carlsson.
1780
1781         Make run-api-tests less chatty.
1782         https://bugs.webkit.org/show_bug.cgi?id=51831
1783
1784         - Make script quiet by default and add --verbose option (replacing --quiet).
1785         - When not verbose, pipe stdout and stderr to devnull.
1786
1787         * Scripts/run-api-tests:
1788
1789 2011-01-03  Pratik Solanki  <psolanki@apple.com>
1790
1791         Unreviewed. Adding myself to committers.py.
1792
1793         * Scripts/webkitpy/common/config/committers.py:
1794
1795 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
1796
1797         Reviewed by Xan Lopez.
1798
1799         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
1800         https://bugs.webkit.org/show_bug.cgi?id=51806
1801
1802         Originally, the $libraryName is 'JavaScriptCore'. When building release 
1803         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
1804         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
1805         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
1806         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
1807         so make it 'WebKitBuild/Release/.libs'
1808
1809         * Scripts/webkitdirs.pm: 
1810
1811 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
1812
1813         Reviewed by Adam Barth.
1814
1815         Make EFL a core builder
1816         https://bugs.webkit.org/show_bug.cgi?id=51804
1817
1818         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1819         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1820
1821 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1822
1823         [Qt] Unreviewed fix after r74855 and r74875.
1824
1825         * BuildSlaveSupport/built-product-archive:
1826          - Create directories explicitly.
1827          - Pass shell=True to subprocess.call().
1828
1829 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1830
1831         [Qt] Unreviewed fix after r74855.
1832
1833         Move JavaScriptCore to Source
1834         https://bugs.webkit.org/show_bug.cgi?id=51604
1835
1836         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
1837
1838 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1839
1840         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
1841
1842         Move JavaScriptCore to Source
1843         https://bugs.webkit.org/show_bug.cgi?id=51604
1844
1845         * Scripts/webkitdirs.pm:
1846
1847 2011-01-02  Robert Hogan  <robert@webkit.org>
1848
1849         Unreviewed, build fix.
1850
1851         [Qt] Fix DRT build after 74855
1852
1853         * DumpRenderTree/qt/DumpRenderTree.pro:
1854
1855 2011-01-01  Adam Barth  <abarth@webkit.org>
1856
1857         Remove the assumption from the Qt and Gtk builds that every project is
1858         in the root directory.
1859
1860         * Scripts/build-webkit:
1861
1862 2011-01-01  Adam Barth  <abarth@webkit.org>
1863
1864         Reviewed by Eric Seidel.
1865
1866         Teach svn-apply how to apply patches even though JavaScriptCore has moved
1867         https://bugs.webkit.org/show_bug.cgi?id=51796
1868
1869         After this change, svn-apply will magically apply patches to
1870         JavaScriptCore/foo to Source/JavaScriptCore/foo.
1871
1872         * Scripts/VCSUtils.pm:
1873
1874 2011-01-01  Adam Barth  <abarth@webkit.org>
1875
1876         Reviewed by Eric Seidel.
1877
1878         Move JavaScriptCore to Source
1879         https://bugs.webkit.org/show_bug.cgi?id=51604
1880
1881         Update references to JavaScriptCore to point to the new location.
1882
1883         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1884         * DumpRenderTree/qt/DumpRenderTree.pro:
1885         * DumpRenderTree/qt/ImageDiff.pro:
1886         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1887         * DumpRenderTree/wscript:
1888         * Scripts/build-jsc:
1889         * Scripts/build-webkit:
1890         * Scripts/do-file-rename:
1891         * Scripts/do-webcore-rename:
1892         * Scripts/run-javascriptcore-tests:
1893         * Scripts/update-javascriptcore-test-results:
1894         * Scripts/webkitdirs.pm:
1895         * Scripts/webkitpy/common/config/build_unittest.py:
1896         * Scripts/webkitpy/style/checker.py:
1897         * Scripts/webkitpy/style/checker_unittest.py:
1898         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1899         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1900         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1901         * wx/build/settings.py:
1902
1903 2011-01-01  Adam Barth  <abarth@webkit.org>
1904
1905         Reviewed by Eric Seidel.
1906
1907         Move Sources to Source
1908         https://bugs.webkit.org/show_bug.cgi?id=51794
1909
1910         Update scripts to point to the new location.
1911
1912         * Scripts/build-webkit:
1913         * Scripts/do-file-rename:
1914         * Scripts/do-webcore-rename:
1915         * Scripts/webkitpy/common/config/build.py:
1916         * Scripts/webkitpy/common/config/build_unittest.py:
1917
1918 2010-12-31  Kent Tamura  <tkent@chromium.org>
1919
1920         Reviewed by Eric Seidel.
1921
1922         [DRT/Chromium] Enable mock spell checker on non-OSX
1923         https://bugs.webkit.org/show_bug.cgi?id=51401
1924
1925         * DumpRenderTree/chromium/WebViewHost.cpp:
1926         (WebViewHost::spellCheck):
1927
1928 2010-12-31  Adam Barth  <abarth@webkit.org>
1929
1930         Reviewed by Ariya Hidayat.
1931
1932         Remove Tools/Scripts/wkstyle
1933         https://bugs.webkit.org/show_bug.cgi?id=51774
1934
1935         This script appears to not have been touched in a while and seems to
1936         have been replaced by check-webkit-style.
1937
1938         * Scripts/wkstyle: Removed.
1939
1940 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
1941
1942         Unreviewed. Coding style fix.
1943
1944         * DumpRenderTree/chromium/TestShell.h:
1945
1946 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
1947
1948         Reviewed by Pavel Feldman.
1949
1950         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
1951
1952         It was a problem with Chromium DRT. DevToolsAgent object instance was
1953         attached not only to the inspected page but to the DevTools window too.
1954         As result all the inspector files were interpreted as a content of inspected page
1955         and were transfered to the DevTools scripts panel for debugging etc.
1956
1957         https://bugs.webkit.org/show_bug.cgi?id=51735
1958
1959         * DumpRenderTree/chromium/TestShell.cpp:
1960         (TestShell::TestShell):
1961         (TestShell::bindJSObjectsToWindow):
1962         (TestShell::createNewWindow):
1963         * DumpRenderTree/chromium/TestShell.h:
1964
1965 2010-12-31  Adam Barth  <abarth@webkit.org>
1966
1967         Rubber-stamped by Eric Seidel.
1968
1969         Move PageLoadTests to PerformanceTests/PageLoad
1970         https://bugs.webkit.org/show_bug.cgi?id=51771
1971
1972         Update references to PageLoadTests to point to the new location.
1973
1974         * Scripts/run-pageloadtest:
1975         * Scripts/webkitpy/common/config/build.py:
1976
1977 2010-12-31  Adam Barth  <abarth@webkit.org>
1978
1979         Rubber-stamped by Eric Seidel.
1980
1981         Move SunSpider into PerformanceTests
1982         https://bugs.webkit.org/show_bug.cgi?id=51769
1983
1984         Update these scripts to point to the new location.
1985
1986         * Scripts/run-sunspider:
1987         * Scripts/sunspider-compare-results:
1988
1989 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
1990
1991         Reviewed by Kent Tamura.
1992
1993         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
1994         https://bugs.webkit.org/show_bug.cgi?id=51728
1995         
1996         Add implementation of the Mac WebThemeEngine that uses an NSScroller
1997         to render top-level scrollbars. This makes them match the Mac port's
1998         use of an NSScrollView, which means that we'll be able to share more
1999         pixel baselines.
2000         
2001         The new rendering code will not be activated until the 
2002         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
2003         ScrollbarThemeChromiumMac.
2004
2005         * DumpRenderTree/DumpRenderTree.gypi:
2006         * DumpRenderTree/chromium/TestShellMac.mm:
2007         (platformInit):
2008         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
2009         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
2010         (+[FakeActiveWindow alwaysActiveWindow]):
2011         (+[FakeActiveWindow alwaysInactiveWindow]):
2012         (-[FakeActiveWindow initWithActiveControls:]):
2013         (-[FakeActiveWindow _hasActiveControls]):
2014         (WebThemeEngineDRTMac::paintScrollbarThumb):
2015         (stateToHIEnableState):
2016         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2017         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2018
2019 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
2020
2021         Reviewed by David Kilzer.
2022
2023         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
2024         used
2025         https://bugs.webkit.org/show_bug.cgi?id=51672
2026
2027         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
2028         with USE_SYSTEM_MALLOC=1
2029         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
2030         with USE_SYSTEM_MALLOC=1
2031
2032 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2033
2034         Reviewed by David Kilzer.
2035
2036         [Qt] [Symbian] Fix build-webkit script for Symbian
2037         https://bugs.webkit.org/show_bug.cgi?id=51509
2038
2039         Set the OUTPUT_DIR for Symbian to be the same as the source
2040         directory.
2041
2042         * Scripts/webkitdirs.pm:
2043
2044 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
2045
2046         Reviewed by Darin Adler.
2047
2048         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
2049         https://bugs.webkit.org/show_bug.cgi?id=51758
2050
2051         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
2052
2053         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
2054         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
2055
2056 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
2057
2058         Unreviewed WinCE buildfix.
2059
2060         * WinCELauncher/main.cpp: Add missing include.
2061
2062 2010-12-29  Daniel Bates  <dbates@rim.com>
2063
2064         Reviewed by Darin Adler.
2065
2066         svn-apply updates date of wrong change log entry for a change log diff that
2067         contains two consecutive entries with the same author and date
2068         https://bugs.webkit.org/show_bug.cgi?id=46061
2069
2070         Fixes an issue where the date of the wrong change log entry may be modified.
2071         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
2072         in a ChangeLog file to the top of the file.
2073
2074         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
2075         diff when it detects that the diff inserts a change log entry earlier in a
2076         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
2077         change. With the advent of the commit-queue this functionality of bailing out
2078         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
2079         Instead, we should always move the change log entry to the top of the ChangeLog file.
2080
2081         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
2082         the date line of the correct change log entry in a ChangeLog diff.
2083
2084         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
2085
2086         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
2087           Updated the following unit tests now that we move entries inserted earlier to the top:
2088           - "fixChangeLogPatch: New entry inserted in middle."
2089             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
2090
2091           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
2092             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
2093
2094         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
2095
2096 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
2097
2098         Reviewed by Eric Seidel.
2099
2100         [Qt] Fixed compatibility with gold linker on X11 platforms
2101         https://bugs.webkit.org/show_bug.cgi?id=51700
2102
2103         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2104         Linked TestNetscapePlugin with libX11 on Unix platforms
2105
2106 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
2107
2108         Reviewed by Darin Adler.
2109
2110         Circular dependency in webkitpy.common.checkout.changelog module
2111         https://bugs.webkit.org/show_bug.cgi?id=50475
2112
2113         Remove automatic import of api.Checkout module when any checkout/
2114         submodule is imported (e.g.: when checkout.scm.Git is imported).
2115
2116         * Scripts/webkitpy/common/checkout/__init__.py:
2117
2118 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
2119
2120         Reviewed by Ojan Vafai.
2121
2122         prepare-ChangeLog should support the -g option for specifying the git-commit
2123         https://bugs.webkit.org/show_bug.cgi?id=51708
2124
2125         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
2126         webkit-patch, though the exact meaning of the two options remain different.
2127
2128         * Scripts/prepare-ChangeLog: Add -g.
2129
2130 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
2131
2132         Reviewed by Simon Hausmann.
2133
2134         [Qt] Fix compilation with Qt in namespace
2135         https://bugs.webkit.org/show_bug.cgi?id=51701
2136
2137         * QtTestBrowser/webview.h:
2138
2139 2010-12-28  Daniel Bates  <dbates@rim.com>
2140
2141         Reviewed by Sam Weinig.
2142
2143         Substitute // MARK: for compiler-specific #pragma mark
2144         https://bugs.webkit.org/show_bug.cgi?id=51657
2145
2146         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
2147         substituting  "// MARK:" for "#pragma mark", which provides
2148         analogous code-bookmarking functionality under Xcode.
2149
2150         Also, for consistency, we should substitute "// MARK:" for compiler-
2151         specific "#pragma mark" in the source files for the Mac port.
2152
2153         * DumpRenderTree/AccessibilityTextMarker.cpp:
2154         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
2155         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
2156         * DumpRenderTree/mac/ObjCController.m:
2157         * MiniBrowser/mac/AppDelegate.m:
2158         * MiniBrowser/mac/BrowserWindowController.m:
2159
2160 2010-12-28  Xan Lopez  <xlopez@igalia.com>
2161
2162         Reviewed by Eric Seidel.
2163
2164         Add --no-build option to run-sunspider
2165         https://bugs.webkit.org/show_bug.cgi?id=51658
2166
2167         * Scripts/run-sunspider: add --no-build flag to skip building
2168         phase.
2169
2170 2010-12-27  Daniel Bates  <dbates@rim.com>
2171
2172         Rubber-stamped by Martin Robinson.
2173
2174         Append the directory Tools/DumpRenderTree to the list of directories that
2175         do-webcore-rename should search so that it can rename DRT files and
2176         source code.
2177
2178         * Scripts/do-webcore-rename:
2179
2180 2010-12-27  Eric Seidel  <eric@webkit.org>
2181
2182         Reviewed by Adam Barth.
2183
2184         build-webkit should detect missing Java SDK and explain how to install it
2185         https://bugs.webkit.org/show_bug.cgi?id=51651
2186
2187         * Scripts/build-webkit:
2188
2189 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
2190
2191         Reviewed by Daniel Bates.
2192
2193         [GTK] Add support for build-jsc
2194         https://bugs.webkit.org/show_bug.cgi?id=51625
2195
2196         Add GTK+ support to build-jsc now that building the jsc executable as
2197         a standalone target is easy.
2198
2199         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
2200         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
2201         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
2202         and pass it along to buildAutotoolsProject.
2203
2204 2010-12-27  David Levin  <levin@chromium.org>
2205
2206         Reviewed by Eric Seidel.
2207
2208         check-webkit-style check for meaningless variable names in function declarations.
2209         https://bugs.webkit.org/show_bug.cgi?id=51523
2210
2211         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
2212         from the new check and whitespace/parens because the syntax is unusual and
2213         produced a fair number of positives for these checks.
2214         * Scripts/webkitpy/style/checkers/cpp.py:
2215         (_convert_to_lower_with_underscores): Used as a canonical form for type names
2216         and parameter names when determining if the parameter name is useless.
2217         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
2218         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
2219         format.
2220         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
2221         text or an acronym of it.
2222         (check_function_definition): Checks function definitions for meaningless variable names.
2223         (process_line): Added call to check_function_definition.
2224         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2225         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
2226         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
2227         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
2228         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
2229         because when only checking a snippet, there are a lot of bogus functions.
2230         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
2231         that I put there previously and just noticed.
2232         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
2233         check_function_definition and process_line.
2234
2235 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2236
2237         Reviewed by Martin Robinson.
2238
2239         [GTK] Disable flash plugin in GtkLauncher when using gtk3
2240         https://bugs.webkit.org/show_bug.cgi?id=51591
2241
2242         Flash plugin uses gtk2 that is incompatible with gtk3 making
2243         webkit crash when it's built with gtk3.
2244
2245         * GtkLauncher/main.c:
2246         (main):
2247
2248 2010-12-25  Adam Barth  <abarth@webkit.org>
2249
2250         Reviewed by Eric Seidel.
2251
2252         Move ANGLE to Sources/ThirdParty
2253         https://bugs.webkit.org/show_bug.cgi?id=51605
2254
2255         * Scripts/build-webkit:
2256           - Point to the new ANGLE location.
2257
2258 2010-12-26  David Levin  <levin@chromium.org>
2259
2260         Reviewed by Eric Seidel.
2261
2262         check-webkit-style should be able to parse function declaration parameters.
2263         https://bugs.webkit.org/show_bug.cgi?id=51451
2264
2265         * Scripts/webkitpy/style/checkers/cpp.py:
2266         (Position.__init__): Holds simple position information (row, column).
2267         (Parameter.__init__): Holds information about a parameter.
2268         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
2269         (SingleLineView.convert_column_to_row): Returns the original row given a column.
2270         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
2271         (find_parameter_name_index): Finds where the parameter name is.
2272         (parameter_list): Generates the list of parameters for a function.
2273         (_FunctionState.begin): Added information to allow determining the parameters
2274         on demand.
2275         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
2276         (detect_functions): Improve function detection for operator functions and
2277         determine where the parameters end and pass that to _FunctionState.begin.
2278         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2279         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
2280         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
2281         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
2282         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
2283         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
2284         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
2285         (FunctionDetectionTest.perform_function_detection): Added support for verifying
2286         the parameters found.
2287         (FunctionDetectionTest.test_function_declaration_detection): Added more function
2288         detection test to verify that we catch the operator functions.
2289         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
2290         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
2291         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
2292         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
2293         test_function_length_check_definition_severity1_for_test.
2294
2295 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
2296
2297         Unreviewed WinCE buildfix after r74334.
2298
2299         * CMakeListsWinCE.txt:
2300
2301 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2302
2303         Unreviewed, rolling out r74632.
2304         http://trac.webkit.org/changeset/74632
2305         https://bugs.webkit.org/show_bug.cgi?id=51600
2306
2307         makes test-webkitpy hang forever on GTK (Requested by philn-tp
2308         on #webkit).
2309
2310         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2311         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2312
2313 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
2314
2315         Reviewed by Kenneth Rohde Christiansen.
2316
2317         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
2318         https://bugs.webkit.org/show_bug.cgi?id=43528
2319
2320         Remove on_resize because ewk_view_fixed_layout_size_set should not be
2321         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
2322         FrameView, rendering was ignored when _ewk_view_smart_calculate was
2323         called.
2324
2325         * EWebLauncher/main.c:
2326         (browserCreate):
2327
2328 2010-12-24  Eric Seidel  <eric@webkit.org>
2329
2330         Reviewed by Adam Barth.
2331
2332         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
2333         https://bugs.webkit.org/show_bug.cgi?id=28291
2334
2335         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
2336         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
2337         to strings with find in the diff.
2338         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
2339
2340         * Scripts/webkitpy/common/checkout/api.py:
2341         * Scripts/webkitpy/common/checkout/diff_parser.py:
2342         * Scripts/webkitpy/tool/steps/abstractstep.py:
2343         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
2344         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
2345         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
2346         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2347
2348 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
2349
2350         Reviewed by Kenneth Russell.
2351
2352         Modify new-run-webkit-tests to shut up and exit when all the threads
2353         are wedged so that test runs complete faster and we don't end up
2354         w/ enormous log files.
2355
2356         https://bugs.webkit.org/show_bug.cgi?id=51572
2357
2358         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2359         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2360
2361 2010-12-24  Eric Seidel  <eric@webkit.org>
2362
2363         Reviewed by David Levin.
2364
2365         commit-queue should better explain how it will re-open bugs and follow duplicate chains
2366         https://bugs.webkit.org/show_bug.cgi?id=51549
2367
2368         I've had multiple people ask me about the commit-queue's behavior
2369         regarding reporting flaky tests.  I figured it would be best to just
2370         have the queue explain itself in the bugs it files.
2371
2372         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2373         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2374
2375 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
2376
2377         Reviewed by Eric Seidel.
2378
2379         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
2380         https://bugs.webkit.org/show_bug.cgi?id=51467
2381
2382         * Scripts/webkitpy/style/checker.py:
2383         * Scripts/webkitpy/style/checker_unittest.py:
2384
2385 2010-12-23  Adam Barth  <abarth@webkit.org>
2386
2387         Rubber-stamped by Eric Seidel.
2388
2389         Move JavaScriptGlue into Sources
2390         https://bugs.webkit.org/show_bug.cgi?id=51583
2391
2392         These tools refer to JavaScriptGlue and need to be updated to its new
2393         location.
2394
2395         * Scripts/build-webkit:
2396         * Scripts/do-file-rename:
2397         * Scripts/do-webcore-rename:
2398         * Scripts/webkitpy/common/config/build.py:
2399         * Scripts/webkitpy/common/config/build_unittest.py:
2400
2401 2010-12-23  Lucas Forschler  <lforschler@apple.com>
2402
2403         Reviewed by Eric Seidel.
2404
2405         Bug 51539 - update iexploder scripts to point to new location
2406
2407         * Scripts/run-iexploder-tests:
2408         * Scripts/update-iexploder-cssproperties:
2409
2410 2010-12-23  Evan Martin  <evan@chromium.org>
2411
2412         Reviewed by Ryosuke Niwa.
2413
2414         [chromium] LayoutTestController warning in float->int conversion
2415         https://bugs.webkit.org/show_bug.cgi?id=51553
2416
2417         Rather than reading an int, converting to a float, then getting a compiler
2418         warning on passing the float to something that expects an int, instead
2419         just pass around ints.
2420
2421         No tests, fixes a compiler warning.
2422
2423         * DumpRenderTree/chromium/LayoutTestController.cpp:
2424         (parsePageSizeParameters):
2425         (LayoutTestController::pageNumberForElementById):
2426         (LayoutTestController::numberOfPages):
2427
2428 2010-12-23  Lucas Forschler  <lforschler@apple.com>
2429
2430         Reviewed by Darin Adler.
2431
2432         Bug 51537 - iexploder needs cleanup
2433         
2434         * iExploder/htdocs: Removed.
2435         * iExploder/htdocs/config.rb: Removed.
2436         * iExploder/htdocs/cssproperties.in: Removed.
2437         * iExploder/htdocs/cssvalues.in: Removed.
2438         * iExploder/htdocs/htmlattrs.in: Removed.
2439         * iExploder/htdocs/htmltags.in: Removed.
2440         * iExploder/htdocs/htmlvalues.in: Removed.
2441         * iExploder/htdocs/iexploder.cgi: Removed.
2442         * iExploder/htdocs/iexploder.rb: Removed.
2443         * iExploder/htdocs/index.html: Removed.
2444         * iExploder/htdocs/webserver.rb: Removed.
2445         * iExploder/iexploder-1.7.2/output: Removed.
2446         * iExploder/tools: Removed.
2447         * iExploder/tools/lasthit.rb: Removed.
2448         * iExploder/tools/osx_last_crash.rb: Removed.
2449         * iExploder/tools/showtest.rb: Removed.
2450
2451 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2452
2453         Reviewed by Kenneth Rohde Christiansen.
2454
2455         [EFL] Make 'single' the default backing store in EWebLauncher
2456         https://bugs.webkit.org/show_bug.cgi?id=51534
2457
2458         'single' is the simplest backing store and the one intended to be the
2459         default in the test browser. By mistake the tiled backing store was
2460         left as default in r72617.
2461
2462         * EWebLauncher/main.c:
2463         (browserCreate): ditto.
2464
2465 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2466
2467         Reviewed by Kenneth Rohde Christiansen.
2468
2469         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
2470         https://bugs.webkit.org/show_bug.cgi?id=51533
2471
2472         There's no point in concatenating env("HOME") with "blah", so remove
2473         option from EWebLauncher.
2474
2475         * EWebLauncher/main.c:
2476         (main): ditto.
2477
2478 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
2479
2480         Reviewed by Eric Seidel.
2481
2482         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
2483
2484         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
2485         I just discovered that we have two additional GC runs per each WebViewHost.
2486         Test_shell had no such calls.
2487         These gc runs eat 15% of cpu time.
2488
2489         https://bugs.webkit.org/show_bug.cgi?id=51479
2490
2491         * DumpRenderTree/chromium/WebViewHost.cpp:
2492         (WebViewHost::~WebViewHost):
2493
2494 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
2495
2496         Reviewed by Ojan Vafai.
2497
2498         This change splits out the TestRunner class into its own file.
2499         When we fork the code for message passing, we will create a new
2500         TestRunner, and this change will allow that to be more modular.
2501
2502         While we're at it, split out TestInput and ResultSummary into
2503         their own files, to reduce the size of run_webkit_tests to
2504         something more managable.
2505
2506         https://bugs.webkit.org/show_bug.cgi?id=51092
2507
2508         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2509         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
2510         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2511         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
2512         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
2513         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2514         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2515
2516  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
2517
2518         Reviewed by Ojan Vafai.
2519
2520         nrwt multiprocessing - start over, prepare to fork the code
2521  
2522         This code cleans up the signatures and implementation of the
2523         TestRunner class so we can easily fork it to run either the
2524         stable implementation or the new, unstable message-passing
2525         implementation. The two variants will have different
2526         implementations of the run_tests() method. We will switch
2527         between the two based on the setting for the '--worker-model'
2528         switch. We rename the two currently valid values to 'old-inline'
2529         and 'old-threads'.
2530
2531         https://bugs.webkit.org/show_bug.cgi?id=51081
2532
2533         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2534         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2535
2536 2010-12-22  Victor Wang  <victorw@chromium.org>
2537
2538         Reviewed by Darin Fisher.
2539
2540         [Chromium] Update chromium archive test result url in rebaseline script.
2541
2542         https://bugs.webkit.org/show_bug.cgi?id=51503
2543
2544         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2545
2546 2010-12-22  Lucas Forschler  <lforschler@apple.com>
2547
2548         Reviewed by Alice Liu.
2549
2550         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
2551         Verified on Chrome, Safari, and IE.
2552         With this change, we will record memory from a parent browser window and all child processes.
2553
2554         * record-memory-win/main.cpp:
2555         (ProcessArgs):
2556         (PrintUsage):
2557         (getMemoryInfo):
2558         (printProcessInfo):
2559         (evalProcesses):
2560         (UseImage):
2561         (QueryContinuously):
2562         (ElapsedTime):
2563
2564 2010-12-22  Lucas Forschler  <lforschler@apple.com>
2565
2566         Unreviewed rollout r74489, because it was missing changelog.
2567
2568         * record-memory-win/main.cpp:
2569         
2570 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
2571
2572         Adding myself as a reviewer.
2573
2574         * Scripts/webkitpy/common/config/committers.py:
2575
2576 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
2577
2578         Unreviewed.  Adding myself to committers.py.
2579
2580         * Scripts/webkitpy/common/config/committers.py:
2581
2582 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
2583
2584         Reviewed by Kenneth Rohde Christiansen.
2585
2586         TestNetscapePlugIn should use #if defined
2587         https://bugs.webkit.org/show_bug.cgi?id=51471
2588
2589         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2590         (NP_Initialize):
2591         (NPP_New):
2592
2593 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
2594
2595         Reviewed by Yury Semikhatsky.
2596
2597         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
2598
2599         DevTools window should be closed explicitly because it has custom deinitialization code.
2600
2601         https://bugs.webkit.org/show_bug.cgi?id=50722
2602
2603         * DumpRenderTree/chromium/TestShell.cpp:
2604         (TestShell::closeRemainingWindows):
2605
2606 2010-12-22  David Levin  <levin@chromium.org>
2607
2608         Reviewed by Shinichiro Hamaji.
2609
2610         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
2611         https://bugs.webkit.org/show_bug.cgi?id=51452
2612
2613         * Scripts/webkitpy/style/checkers/cpp.py:
2614         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
2615         Using the file extension if possible but falling back to the file contents if we have a header file.
2616         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
2617         (_FileState.is_c_or_objective_c):
2618         (check_using_std): Changed to using _FileState to determine the file type.
2619         (check_max_min_macros): Ditto.
2620         (check_for_null): Ditto.
2621         (check_style): Changed the parameters to various calls since they now need _FileState
2622         to determine the file type.
2623         (check_language): Added the file_state parameter so it could be passed
2624         to check_identifier_name_in_declaration.
2625         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
2626         this is an Objective C file.
2627         (_process_lines): Added information for the _FileState constructor (and moved the
2628         call to a place that had the information).
2629         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2630         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
2631         its functionality.
2632         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
2633
2634 2010-12-21  Andy Estes  <aestes@apple.com>
2635
2636         Reviewed by Mark Rowe.
2637
2638         Do not build non-Intel architectures for WebKit2-related projects.
2639         https://bugs.webkit.org/show_bug.cgi?id=51440
2640
2641         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
2642         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
2643         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
2644
2645 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
2646
2647         Reviewed by Darin Fisher.
2648
2649         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
2650         https://bugs.webkit.org/show_bug.cgi?id=51406 
2651         
2652         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
2653         to WebThemeEngineDRTWin and update references everywhere.
2654
2655         * DumpRenderTree/DumpRenderTree.gypi:
2656         * DumpRenderTree/chromium/TestShellWin.cpp:
2657         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
2658         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
2659         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
2660         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
2661
2662 2010-12-21  Anders Carlsson  <andersca@apple.com>
2663
2664         Reviewed by John Sullivan.
2665
2666         Clicking missing plug-in text does not show a sheet
2667         https://bugs.webkit.org/show_bug.cgi?id=51403
2668
2669         Update for changes to the WebPageUIClient.
2670
2671         * MiniBrowser/mac/BrowserWindowController.m:
2672         (-[BrowserWindowController awakeFromNib]):
2673         * WebKitTestRunner/TestController.cpp:
2674         (WTR::createOtherPage):
2675         (WTR::TestController::initialize):
2676
2677 2010-12-21  Eric Seidel  <eric@webkit.org>
2678
2679         Reviewed by Adam Barth.
2680
2681         commit-queue will report constant failures as flaky if other tests flake
2682         https://bugs.webkit.org/show_bug.cgi?id=51272
2683
2684         This patch just removes functionality and adds testing.
2685         Previously we attempted to report flaky tests when we had
2686         two different tests fail in a row.  However, since we stop
2687         running the tests at the first failure, our code was wrong in
2688         trying to determine flakiness from the incomplete runs.
2689
2690         Originally I posted an alternate patch:
2691         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
2692         which fixed our flaky logic in this case, however it was decided
2693         that that patch would be too difficult to maintain, so now
2694         I'm just removing the broken logic.
2695
2696         This will dramatically cut-down on our flaky-test false positives
2697         at the (small) cost of the queues being unable to report
2698         any flakiness if the tree is very flaky.  (With at least one test
2699         flaking on every run, we'll never report failures anymore.)  I think
2700         this is a tradeoff worth making.
2701
2702         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2703         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2704
2705 2010-12-20  Eric Seidel  <eric@webkit.org>
2706
2707         Reviewed by Adam Barth.
2708
2709         commit-queue wrongly rejects patches when it can't update itself
2710         https://bugs.webkit.org/show_bug.cgi?id=46636
2711
2712         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2713         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2714         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2715
2716 2010-12-20  Adam Barth  <abarth@webkit.org>
2717
2718         Move web sites to Websites directory
2719         https://bugs.webkit.org/show_bug.cgi?id=51323
2720
2721         Update references to BugsSite to point to the new location.
2722
2723         This patch was never officially reviewed (because it was too large to
2724         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
2725         Rowe gave me the green light.
2726
2727         * Scripts/old-run-webkit-tests:
2728         * Scripts/webkitpy/common/config/build.py:
2729         * Scripts/webkitpy/common/config/build_unittest.py:
2730         * Scripts/webkitpy/common/prettypatch.py:
2731         * Scripts/webkitpy/layout_tests/port/base.py:
2732         * Scripts/webkitpy/style/main.py:
2733
2734 2010-12-20  Adrienne Walker  <enne@google.com>
2735
2736         Unreviewed. Adding myself to the list of committers.
2737
2738         * webkitpy/common/config/committers.py:
2739
2740 2010-12-20  Mark Rowe  <mrowe@apple.com>
2741
2742         Reviewed by Dan Bernstein.
2743
2744         <rdar://problem/8757601> Don't install header files in to the Resources directory.
2745
2746         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
2747         Resources directory.
2748
2749 2010-12-20  Eric Seidel  <eric@webkit.org>
2750
2751         Reviewed by Adam Barth.
2752
2753         commit-queue should include bot id when attaching failure diffs
2754         https://bugs.webkit.org/show_bug.cgi?id=51280
2755
2756         This is a tiny change to include the bot id in the name of the attachment.
2757         Most of this diff is just changing the unit test expectations
2758         now that I hid the comment printing when the comment is None.
2759
2760         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2761         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2762         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2763         * Scripts/webkitpy/tool/mocktool.py:
2764
2765 2010-12-20  Jeff Miller  <jeffm@apple.com>
2766
2767         Reviewed by Dan Bernstein.
2768
2769         Tools/vcbin/midl.exe needs to be rebuilt
2770         https://bugs.webkit.org/show_bug.cgi?id=51347
2771
2772         * vcbin/midl.exe: Rebuilt.
2773
2774 2010-12-20  David Levin  <levin@chromium.org>
2775
2776         Reviewed by Ariya Hidayat.
2777
2778         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
2779         https://bugs.webkit.org/show_bug.cgi?id=51343
2780
2781         Follow up from the WebKitTools -> Tools rename.
2782
2783         * Scripts/webkit-tools-completion.sh:
2784
2785 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
2786
2787         Reviewed by James Robinson.
2788
2789         new-run-webkit-tests ignores trailing EOL differences in text tests
2790         https://bugs.webkit.org/show_bug.cgi?id=36983
2791
2792         Changed the handling of new-line characters within new-run-webkit-tests
2793         to match old-run-webkit-tests.  Differences in leading and trailing empty
2794         lines in text expectation files are no longer ignored.
2795
2796         * Scripts/webkitpy/layout_tests/port/base.py:
2797         * Scripts/webkitpy/layout_tests/port/test.py:
2798         Added unit tests.  Removed old duplicate unit test entries.
2799         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2800
2801 2010-12-20  David Levin  <levin@chromium.org>
2802
2803         Reviewed by Shinichiro Hamaji.
2804
2805         check-webkit-style should detect function declarations (and trivial functions).
2806         https://bugs.webkit.org/show_bug.cgi?id=51303
2807
2808         * Scripts/webkitpy/style/checkers/cpp.py:
2809         (_FunctionState.begin): Add is_declaration and changed the line count
2810         start to begin at -1 (which will keep the results consistent, since
2811         the starting line number passed in is one less in this change).
2812         (detect_functions): changed function detection to now catch trivial
2813         functions and declarations.
2814         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
2815         of the function as this may look at return values (when processing
2816         a declaration).
2817         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2818         (FunctionDetectionTest.perform_function_detection): Basic mechanics
2819         of testing the function detection.
2820         (FunctionDetectionTest.test_basic_function_detection): Test a simple
2821         function.
2822         (FunctionDetectionTest.test_function_declaration_detection): Test a
2823         declaration.
2824         (FunctionDetectionTest.test_non_functions): A test case for a case
2825         that caused the code to fail due to the { being in quotes.
2826         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
2827         cases to help catch false alarms for return values.
2828         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
2829         we don't get false alarms for member variables either.
2830
2831 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
2832
2833         Reviewed by Antonio Gomes.
2834
2835         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
2836         https://bugs.webkit.org/show_bug.cgi?id=51319
2837
2838         * CMakeListsEfl.txt:
2839
2840 2010-12-18  Adam Barth  <abarth@webkit.org>
2841
2842         Reviewed by Sam Weinig.
2843
2844         Move WebKitExamplePlugins to Examples
2845         https://bugs.webkit.org/show_bug.cgi?id=51291
2846
2847         * Scripts/webkitpy/common/config/build.py:
2848
2849 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
2850
2851         Unreviewed Qt buildfix after r74301.
2852
2853         Rename WebKitTools to Tools
2854         https://bugs.webkit.org/show_bug.cgi?id=49861
2855
2856         * MiniBrowser/DerivedSources.pro:
2857         * MiniBrowser/qt/MiniBrowser.pro:
2858
2859 2010-12-17  Dan Bernstein  <mitz@apple.com>
2860
2861         Reviewed by Simon Fraser.
2862
2863         Rename WebKitTools to Tools
2864         https://bugs.webkit.org/show_bug.cgi?id=49861
2865
2866         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2867         * CodeCoverage/README:
2868         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2869         (WebCore::DumpRenderTree::initializeFonts):
2870         * EWSTools/start-commit-queue.sh:
2871         * EWSTools/start-queue.sh:
2872         * GNUmakefile.am:
2873         * MIDLWrapper/MIDLWrapper.cpp:
2874         (wmain):
2875         * MiniBrowser/qt/MiniBrowser.pro:
2876         * Scripts/build-api-tests:
2877         * Scripts/build-dumprendertree:
2878         * Scripts/build-webkit:
2879         * Scripts/build-webkittestrunner:
2880         * Scripts/generate-coverage-data:
2881         * Scripts/old-run-webkit-tests:
2882         * Scripts/run-api-tests:
2883         * Scripts/run-iexploder-tests:
2884         * Scripts/run-javascriptcore-tests:
2885         * Scripts/run-mangleme-tests:
2886         * Scripts/run-sunspider:
2887         * Scripts/run-webkit-websocketserver:
2888         * Scripts/sunspider-compare-results:
2889         * Scripts/test-webkitperl:
2890         * Scripts/test-webkitpy:
2891         * Scripts/update-iexploder-cssproperties:
2892         * Scripts/update-webkit:
2893         * Scripts/update-webkit-localizable-strings:
2894         * Scripts/webkitdirs.pm:
2895         * Scripts/webkitpy/common/checkout/scm.py:
2896         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2897         * Scripts/webkitpy/common/config/committervalidator.py:
2898         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
2899         * Scripts/webkitpy/common/config/ports.py:
2900         * Scripts/webkitpy/common/config/ports_unittest.py:
2901         * Scripts/webkitpy/common/system/logutils_unittest.py:
2902         * Scripts/webkitpy/common/system/ospath_unittest.py:
2903         * Scripts/webkitpy/layout_tests/port/chromium.py:
2904         * Scripts/webkitpy/layout_tests/port/config.py:
2905         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2906         * Scripts/webkitpy/layout_tests/port/http_server.py:
2907         * Scripts/webkitpy/layout_tests/port/test.py:
2908         * Scripts/webkitpy/style/checker.py:
2909         * Scripts/webkitpy/style/checker_unittest.py:
2910         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2911         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2912         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2913         * WebKitTestRunner/DerivedSources.pro:
2914         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2915         (WTR::activateFonts):
2916         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2917         * wx/build/build_utils.py:
2918
2919 2010-12-16  Antonio Gomes  <agomes@rim.com>
2920
2921         Reviewed by Martin Robinson.
2922
2923         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
2924         https://bugs.webkit.org/show_bug.cgi?id=51163
2925
2926         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
2927         GTK+'s DRT should also reset to UNIX after each test execution.
2928
2929         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2930         (resetDefaultsToConsistentValues):
2931
2932 2010-12-17  David Levin  <levin@chromium.org>
2933
2934         Reviewed by Eric Seidel.
2935
2936         check-webkit-style should understand WTF #include guards
2937         https://bugs.webkit.org/show_bug.cgi?id=44911
2938
2939         * Scripts/webkitpy/style/checkers/cpp.py:
2940         (get_header_guard_cpp_variable): modify to suggest the WTF style
2941         of header guard when appropriate.
2942         (check_for_header_guard): handle multiple return values from
2943         get_header_guard_cpp_variable
2944         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2945         (CppStyleTest.test_build_header_guard): Added tests for the WTF
2946         header style.
2947
2948 2010-12-16  David Levin  <levin@chromium.org>
2949
2950         Reviewed by Eric Seidel.
2951
2952         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
2953         https://bugs.webkit.org/show_bug.cgi?id=51210
2954
2955         The error only shows up when using python 2.6 or later.
2956
2957         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
2958         the decprecated field error,message with something equivalent.
2959
2960 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
2961
2962         Reviewed by Eric Seidel.
2963
2964         Add --exit-after-n-failures/crashes to NRWT
2965         https://bugs.webkit.org/show_bug.cgi?id=51160
2966         
2967         Abort test run (in a similar way to how control-C is handled) when
2968         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
2969         that number of unexpected failures/crashes/timeouts.
2970
2971         * Scripts/webkitpy/layout_tests/port/test.py:
2972         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2973         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2974
2975 2010-12-16  David Levin  <levin@chromium.org>
2976
2977         Reviewed by Shinichiro Hamaji.
2978
2979         check-webkit-style unit tests has some duplicate boilerplate code.
2980         https://bugs.webkit.org/show_bug.cgi?id=49519
2981
2982         * Scripts/webkitpy/style/checkers/cpp.py:
2983         (update_include_state): Replaced the "io" parameter with the global
2984         configuration _unit_test_config. This allowed not calling into
2985         functions at a low level and also not plumbing through the injection
2986         information through many levels of code.
2987         (check_for_include_what_you_use): Ditto.
2988         (process_file_data): Added the ability to set up the unit test config
2989         to allow for injection.
2990         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2991         (ErrorCollector.__init__): Added support for having a filter for errors.
2992         (ErrorCollector.__call__): Ditto.
2993         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
2994         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
2995         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
2996         functions in the cpp.py with generic processing and a filter that
2997         indicates what errors should be kept.
2998         (CppStyleTestBase.perform_multi_line_lint): Ditto.
2999         (CppStyleTestBase.perform_language_rules_check): Ditto.
3000         (CppStyleTestBase.perform_function_lengths_check): Ditto.
3001         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
3002         (CppStyleTestBase.perform_include_what_you_use): Ditto.
3003         (CppStyleTest.test_multi_line_comments): Added another
3004         error message which applies to the test case.
3005         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
3006         to not have config.h, since it is processed as a header file.
3007         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
3008         style and indentation in checked code.
3009         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
3010         Fixed line number.
3011         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
3012         Ditto.
3013
3014 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
3015
3016         Unreviewed, rolling out r74136.
3017         http://trac.webkit.org/changeset/74136
3018         https://bugs.webkit.org/show_bug.cgi?id=51135
3019
3020         r74136 breaks chromium canary bots because some tests are not
3021         rebaselined correctly to resolve EOL differences (Requested by
3022         jianli on #webkit).
3023
3024         * Scripts/webkitpy/layout_tests/port/base.py:
3025         * Scripts/webkitpy/layout_tests/port/test.py:
3026         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3027
3028 2010-12-15  Adam Roben  <aroben@apple.com>
3029
3030         Teach check-webkit-style to check .vcproj and .vsprops files for XML
3031         syntax errors
3032
3033         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
3034         XML syntax errors in .vcproj/.vsprops files
3035
3036         Reviewed by Dave Levin.
3037
3038         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
3039         that should be treated as XML and that should be allowed to contain
3040         carriage returns. (These lists happen to be identical currently.)
3041         (FileType): Added a new XML type.
3042         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
3043         Just does a simple file extension check.
3044         (CheckerDispatcher._file_type): Added a case for XML files.
3045         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
3046         files (surprise!).
3047         (StyleProcessor.process): Ask the dispatcher whether we should pass the
3048         lines through the carriage checker.
3049
3050         * Scripts/webkitpy/style/checker_unittest.py:
3051         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
3052         Added. Checks a few file names to see if carriage returns are allowed
3053         or not.
3054         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
3055         other assert_checker_* functions.
3056         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
3057         test_*_paths functions.
3058         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
3059         test_*_paths functions.
3060         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
3061         file from this test case, as vcproj files now have a type.
3062         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
3063         Added. Similar to the other should_* functions.
3064         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
3065         Added. Checks that carriage returns aren't checked for or stripped for
3066         allowed files.
3067
3068         * Scripts/webkitpy/style/checkers/xml.py: Added.
3069         (XMLChecker.__init__): Simple init method.
3070         (XMLChecker.check): Pass each line through the expat parser, and record
3071         a style error for any errors thrown by the parser.
3072
3073         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
3074         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
3075         produce a style error.
3076         (XMLCheckerTest.assert_error): Checks that the given XML produces an
3077         error of the given category on the given line.
3078         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
3079         checking that the XMLChecker constructor works properly.
3080         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
3081         cause a style error (see, e.g., r73887).
3082         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
3083         cause a style error (see, e.g., r73773).
3084         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
3085         properly.
3086         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
3087         tags cause a style error (see, e.g., r72795).
3088         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
3089         style error.
3090
3091 2010-12-15  Lucas Forschler  <lforschler@apple.com>
3092
3093         Reviewed by Stephanie Lewis.
3094
3095         https://bugs.webkit.org/show_bug.cgi?id=51117
3096         Add a new leopard test bot
3097         really really commit to trunk this time.
3098
3099         * BuildSlaveSupport/build.webkit.org-config/config.json:
3100
3101 2010-12-15  Sam Weinig  <sam@webkit.org>
3102
3103         Reviewed by Anders Carlsson.
3104
3105         WebKit2: Can't add files to an <input type=file>
3106         https://bugs.webkit.org/show_bug.cgi?id=51087
3107
3108         * MiniBrowser/mac/BrowserWindowController.m:
3109         (runOpenPanel):
3110         (-[BrowserWindowController awakeFromNib]):
3111         Add simple implementation of runOpenPanel callback.
3112
3113         * MiniBrowser/win/BrowserView.cpp:
3114         (BrowserView::create):
3115         * WebKitTestRunner/TestController.cpp:
3116         (WTR::createOtherPage):
3117         (WTR::TestController::initialize):
3118         Stub out runOpenPanel callback. 
3119
3120 2010-12-14  Eric Seidel  <eric@webkit.org>
3121
3122         Reviewed by Adam Barth.
3123
3124         commit-queue should upload failure diffs when tests flake
3125         https://bugs.webkit.org/show_bug.cgi?id=51051
3126
3127         To make this testable I needed to pipe FileSystem down onto tool.
3128         We've wanted it there for a long time anyway.
3129
3130         This patch is kinda a big hack.  But we don't have a nice
3131         way to read results.html files.  I think this will need further
3132         revision before this code actually feels clean.
3133
3134         As part of testing this change, I had to make MockBugzilla.create_bug
3135         actually return an id (like it should) which required updating
3136         a few other unit test results (for the better).
3137
3138         The results_matching_keys change in layouttestresults/rebasline
3139         was an alternate path which I decided not to use in the end, but
3140         I left the change as it seemed an improvement.
3141
3142         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3143         * Scripts/webkitpy/common/net/layouttestresults.py:
3144         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3145         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3146         * Scripts/webkitpy/tool/commands/queues.py:
3147         * Scripts/webkitpy/tool/commands/rebaseline.py:
3148         * Scripts/webkitpy/tool/main.py:
3149         * Scripts/webkitpy/tool/mocktool.py:
3150
3151 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
3152
3153         Reviewed by James Robinson.
3154
3155         new-run-webkit-tests ignores trailing EOL differences in text tests
3156         https://bugs.webkit.org/show_bug.cgi?id=36983
3157
3158         Changed the handling of new-line characters within new-run-webkit-tests
3159         to match old-run-webkit-tests.  Differences in leading and trailing empty
3160         lines in text expectation files are no longer ignored.
3161
3162         * Scripts/webkitpy/layout_tests/port/base.py:
3163         * Scripts/webkitpy/layout_tests/port/test.py:
3164         Added unit tests.  Removed old duplicate unit test entries.
3165         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3166
3167 2010-12-15  Ojan Vafai  <ojan@chromium.org>
3168
3169         Reviewed by Adam Barth.
3170
3171         make status-bubble white-space:nowrap so we can measure it's width without wrapping
3172         https://bugs.webkit.org/show_bug.cgi?id=51149
3173
3174         * QueueStatusServer/templates/statusbubble.html:
3175
3176 2010-12-15  Ojan Vafai  <ojan@chromium.org>
3177
3178         Reviewed by Adam Barth.
3179
3180         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
3181         https://bugs.webkit.org/show_bug.cgi?id=51125
3182
3183         * QueueStatusServer/templates/statusbubble.html:
3184
3185 2010-12-15  Darin Adler  <darin@apple.com>
3186
3187         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
3188
3189 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
3190
3191         Unreviewed, rolling out r74117.
3192         http://trac.webkit.org/changeset/74117
3193         https://bugs.webkit.org/show_bug.cgi?id=51113
3194
3195         This broke the GTK1 build. (Requested by mrobinson on
3196         #webkit).
3197
3198         * Scripts/webkitdirs.pm:
3199
3200 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
3201
3202         Reviewed by Martin Robinson.
3203
3204         Change generate-forwarding-headers.pl for GTK port usage 
3205         (https://bugs.webkit.org/show_bug.cgi?id=37369)
3206
3207         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
3208
3209 2010-12-14  Kent Tamura  <tkent@chromium.org>
3210
3211         Reviewed by Jian Li.
3212
3213         [DRT/Chromium] Remove another unnecessary error message
3214         https://bugs.webkit.org/show_bug.cgi?id=51083
3215
3216         * DumpRenderTree/chromium/WebViewHost.cpp:
3217         (WebViewHost::didInvalidateRect):
3218
3219 2010-12-14  Lucas Forschler  <lforschler@apple.com>
3220
3221         Reviewed by Stephanie Lewis.
3222
3223         Add a new Leopard Debug Test WK2 Bot
3224
3225         * BuildSlaveSupport/build.webkit.org-config/config.json:
3226
3227 2010-12-14  Ojan Vafai  <ojan@chromium.org>
3228
3229         Fix python unittests after http://trac.webkit.org/changeset/74070.
3230
3231         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3232
3233 2010-12-14  Kent Tamura  <tkent@chromium.org>
3234
3235         Reviewed by Jian Li.
3236
3237         [DRT/Chromium] Remove a unnecessary error message
3238         https://bugs.webkit.org/show_bug.cgi?id=51069
3239
3240         * DumpRenderTree/chromium/WebViewHost.cpp:
3241         (WebViewHost::paintInvalidatedRegion):
3242
3243 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
3244
3245         Reviewed by Ojan Vafai.
3246
3247         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
3248         https://bugs.webkit.org/show_bug.cgi?id=48926
3249
3250         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3251         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
3252
3253 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3254
3255         Reviewed by Eric Seidel.
3256
3257         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
3258         https://bugs.webkit.org/show_bug.cgi?id=50231
3259
3260         Guard CONFIG+=link_pkgconfig with !symbian.
3261
3262         * DumpRenderTree/qt/DumpRenderTree.pro:
3263         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3264         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3265
3266 2010-12-14  Philippe Normand  <pnormand@igalia.com>
3267
3268         Reviewed by Ojan Vafai.
3269
3270         [new-run-webkit-tests] expectations parsing is slow
3271         https://bugs.webkit.org/show_bug.cgi?id=50635
3272
3273         Avoid expensive iteration of all the tests when checking if a test
3274         file is to be skipped or not.
3275
3276         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3277         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3278         * Scripts/webkitpy/layout_tests/port/test.py:
3279
3280 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
3281
3282         Reviewed by Xan Lopez.
3283
3284         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
3285         https://bugs.webkit.org/show_bug.cgi?id=27048
3286
3287         Add support in DRT for checking whether an accessibility UI
3288         element is focusable and/or focused. Implemented for GTK.
3289
3290         * DumpRenderTree/AccessibilityUIElement.cpp:
3291         (getIsFocusedCallback): New.
3292         (getIsFocusableCallback): New.
3293         (AccessibilityUIElement::getJSClass): Add the new available
3294         callbacks for isFocused and isFocusable.
3295         * DumpRenderTree/AccessibilityUIElement.h:
3296         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3297         (AccessibilityUIElement::isFocused): New, implemented by checking
3298         whether the related AtkState value is in the object's state set.
3299         (AccessibilityUIElement::isFocusable): Ditto.
3300         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3301         (AccessibilityUIElement::isFocused): New, dummy implementation.
3302         (AccessibilityUIElement::isFocusable): Ditto.
3303         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3304         (AccessibilityUIElement::isFocused): Ditto.
3305         (AccessibilityUIElement::isFocusable): Ditto.
3306
3307 2010-12-14  Eric Seidel  <eric@webkit.org>
3308
3309         Reviewed by Ojan Vafai.
3310
3311         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
3312         https://bugs.webkit.org/show_bug.cgi?id=50715
3313
3314         This patch makes webkit-patch print the following:
3315
3316         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
3317         Install a 64-bit git for better performance, see:
3318         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
3319
3320         I wrote this mostly because I have approximately 8 machines that I use
3321         and making sure each one is using a good Git install seemed folly.
3322         webkit-patch makes a lot of git calls, so using a fast git can shave
3323         several seconds in every invocation.  See the webkit-dev thread for more info.
3324
3325         This message will print twice during 'webkit-patch upload',
3326         once from webkit-patch and once from check-webkit-style.
3327
3328         Unfortunately there is no good way to test this due to how machine-dependent
3329         the code is.  I considered writing a test for the log message, but it seemed not worth it.
3330
3331         * Scripts/webkitpy/common/checkout/scm.py:
3332
3333 2010-12-13  Eric Seidel  <eric@webkit.org>
3334
3335         Reviewed by Adam Barth.
3336
3337         FlakyTestReporter doesn't understand bots running from multiple email addresses
3338         https://bugs.webkit.org/show_bug.cgi?id=50960
3339
3340         This explains at least one of the dupes of:
3341         https://bugs.webkit.org/show_bug.cgi?id=50863
3342         that we saw filed by the commit-queue this morning.
3343         I think the other one was explained by my previous fix to result counting code.
3344
3345         Since this is really hard to test with a unit test, instead I
3346         create a new (possibly useful in the future) command
3347         which given a layout test path will return you
3348         the one bug which our tools would assume it the flaky test bug.
3349         If some other script wants to use bug-for-test we'll
3350         need to extend it with some options like --create-if-missing or similar.
3351
3352         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3353         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3354         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3355         * Scripts/webkitpy/tool/commands/__init__.py:
3356         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
3357
3358 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
3359
3360         Reviewed by James Robinson.
3361
3362         Add option to build-webkit to not build WebKit2
3363         https://bugs.webkit.org/show_bug.cgi?id=50988
3364         
3365         Add support for a --no-webkit2 option to build-webkit. It seems to save
3366         ~1 minute from clean builds and ~10 seconds from no-op builds.
3367
3368         * Scripts/build-webkit:
3369
3370 2010-12-13  Lucas Forschler  <lforschler@apple.com>
3371
3372         Reviewed by Dave Kilzer.
3373
3374         Update iexploder from 1.3.2 to 1.7.2
3375         Move 1.3.2 into its own subdir
3376         Add 1.7.2 into its own subdir
3377         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
3378
3379         * Scripts/run-iexploder-tests:
3380         * Scripts/update-iexploder-cssproperties:
3381         * iExploder/CHANGELOG.txt: Removed.
3382         * iExploder/LICENSE.txt: Removed.
3383         * iExploder/README.txt: Removed.
3384         * iExploder/htdocs: Removed.
3385         * iExploder/iexploder-1.3.2: Added.
3386         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
3387         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
3388         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
3389         * iExploder/iexploder-1.3.2/htdocs: Added.
3390         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
3391         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
3392         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
3393         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
3394         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
3395         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
3396         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
3397         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
3398         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
3399         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
3400         * iExploder/iexploder-1.3.2/tools: Added.
3401         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
3402         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
3403         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
3404         * iExploder/iexploder-1.7.2: Added.
3405         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
3406         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
3407         * iExploder/iexploder-1.7.2/README.txt: Added.
3408         * iExploder/iexploder-1.7.2/output: Added.
3409         * iExploder/iexploder-1.7.2/src: Added.
3410         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
3411         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
3412         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
3413         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
3414         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
3415         * iExploder/iexploder-1.7.2/src/css-properties: Added.
3416         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
3417         * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
3418         * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
3419         * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
3420         * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
3421         * iExploder/iexploder-1.7.2/src/css-pseudo: Added.
3422         * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
3423         * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
3424         * iExploder/iexploder-1.7.2/src/css-values: Added.
3425         * iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
3426         * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
3427         * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
3428         * iExploder/iexploder-1.7.2/src/css-values/other: Added.
3429         * iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
3430         * iExploder/iexploder-1.7.2/src/headers: Added.
3431         * iExploder/iexploder-1.7.2/src/headers/dillo: Added.
3432         * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
3433         * iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
3434         * iExploder/iexploder-1.7.2/src/headers/webkit: Added.
3435         * iExploder/iexploder-1.7.2/src/html-attrs: Added.
3436         * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
3437         * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
3438         * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
3439         * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
3440         * iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
3441         * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
3442         * iExploder/iexploder-1.7.2/src/html-tags: Added.
3443         * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
3444         * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
3445         * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
3446         * iExploder/iexploder-1.7.2/src/html-tags/other: Added.
3447         * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
3448         * iExploder/iexploder-1.7.2/src/html-values: Added.
3449         * iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
3450         * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
3451         * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
3452         * iExploder/iexploder-1.7.2/src/html-values/other: Added.
3453         * iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
3454         * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
3455         * iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
3456         * iExploder/iexploder-1.7.2/src/index.html: Added.
3457         * iExploder/iexploder-1.7.2/src/media: Added.
3458         * iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
3459         * iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
3460         * iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
3461         * iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
3462         * iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
3463         * iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
3464         * iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
3465         * iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
3466         * iExploder/iexploder-1.7.2/src/media/bug.png: Added.
3467         * iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
3468         * iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
3469         * iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
3470         * iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
3471         * iExploder/iexploder-1.7.2/src/mime-types: Added.
3472         * iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
3473         * iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
3474         * iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
3475         * iExploder/iexploder-1.7.2/src/protocols: Added.
3476         * iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
3477         * iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
3478         * iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
3479         * iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
3480         * iExploder/iexploder-1.7.2/src/scanner.rb: Added.
3481         * iExploder/iexploder-1.7.2/src/version.rb: Added.
3482         * iExploder/iexploder-1.7.2/src/webserver.rb: Added.
3483         * iExploder/iexploder-1.7.2/testcases: Added.
3484         * iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
3485         * iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
3486         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added.
3487         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added.
3488         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added.
3489         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added.
3490         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added.
3491         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added.
3492         * iExploder/iexploder-1.7.2/tools: Added.
3493         * iExploder/iexploder-1.7.2/tools/lasthit.rb: Added.
3494         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added.
3495         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added.
3496         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added.
3497         * iExploder/tools: Removed.
3498
3499 2010-12-13  Sam Weinig  <sam@webkit.org>
3500
3501         Reviewed by Anders Carlsson.
3502
3503         Remove associated page concept from WKView constructor
3504         https://bugs.webkit.org/show_bug.cgi?id=50983
3505
3506         Step 1: Remove associate page constructors from WKView and make
3507         all views use the shared namespace for the context.
3508
3509         * TestWebKitAPI/PlatformWebView.h:
3510         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3511         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3512         * WebKitTestRunner/PlatformWebView.h:
3513         * WebKitTestRunner/TestController.cpp:
3514         (WTR::createOtherPage):
3515         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3516         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3517         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3518
3519 2010-12-13  Sam Weinig  <sam@webkit.org>
3520
3521         Reviewed by Anders Carlsson.
3522
3523         Change the WebKit2 public API so there is no explicit WKPageNamespace object
3524         https://bugs.webkit.org/show_bug.cgi?id=50898
3525
3526         * MiniBrowser/mac/AppDelegate.h:
3527         * MiniBrowser/mac/AppDelegate.m:
3528         * MiniBrowser/mac/BrowserWindowController.h:
3529         * MiniBrowser/mac/BrowserWindowController.m:
3530         * MiniBrowser/win/BrowserView.cpp:
3531         Convert MiniBrowser to not use PageNamespaces.
3532
3533         * TestWebKitAPI/PlatformWebView.h:
3534         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
3535         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
3536         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
3537         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
3538         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
3539         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
3540         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
3541         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3542         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3543         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
3544         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
3545         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
3546         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
3547         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3548         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3549         Convert TestWebKitAPI to not use PageNamespaces.
3550
3551         * WebKitTestRunner/PlatformWebView.h:
3552         * WebKitTestRunner/TestController.cpp:
3553         * WebKitTestRunner/TestController.h:
3554         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3555         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3556         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3557         Convert WebKitTestRunner to not use PageNamespaces.
3558
3559 2010-12-13  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3560
3561         Reviewed by Eric Seidel.
3562
3563         webkit-patch rollout should be able to do multi-revision rollouts
3564         https://bugs.webkit.org/show_bug.cgi?id=33336
3565
3566         Make it possible to pass more than one revision to webkit-patch.
3567
3568         * Scripts/webkitpy/common/checkout/api.py:
3569         * Scripts/webkitpy/common/checkout/changelog.py:
3570         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3571         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
3572         * Scripts/webkitpy/tool/commands/download.py:
3573         * Scripts/webkitpy/tool/commands/download_unittest.py:
3574         * Scripts/webkitpy/tool/mocktool.py:
3575         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
3576         * Scripts/webkitpy/tool/steps/revertrevision.py:
3577
3578 2010-12-13  Eric Seidel  <eric@webkit.org>
3579
3580         Unreviewed.
3581
3582         Teach webkit-patch how to search bugzilla
3583         https://bugs.webkit.org/show_bug.cgi?id=50500
3584
3585         webkit-patch bug-search fails when there is only one result.
3586         Turns out we needed a bit more logic in our result count parsing code.
3587
3588         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3589         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3590
3591 2010-12-13  Antti Koivisto  <antti@apple.com>
3592
3593         Reviewed by Alexey Proskuryakov.
3594
3595         Add setSerializeHTTPLoads function to allow testing resource load order on OS X.
3596         https://bugs.webkit.org/show_bug.cgi?id=50758
3597
3598         * DumpRenderTree/LayoutTestController.cpp:
3599         (setSerializeHTTPLoadsCallback):
3600         (LayoutTestController::staticFunctions):
3601         * DumpRenderTree/LayoutTestController.h:
3602         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3603         (LayoutTestController::setSerializeHTTPLoads):
3604         * DumpRenderTree/mac/DumpRenderTree.mm:
3605         (resetDefaultsToConsistentValues):
3606         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3607         (LayoutTestController::setSerializeHTTPLoads):
3608         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3609         (LayoutTestController::setSerializeHTTPLoads):
3610
3611 2010-12-13  Dimitri Glazkov  <dglazkov@chromium.org>
3612
3613         Reviewed by Ojan Vafai.
3614
3615         Remove "use-drt" option from test step command line, since the option was removed in r73748.
3616         https://bugs.webkit.org/show_bug.cgi?id=50936
3617
3618         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed the option.
3619
3620 2010-12-13  Patrick Gansterer  <paroga@webkit.org>
3621
3622         Reviewed by Csaba Osztrogonác.
3623
3624         Add revlink to BuildBot status
3625         https://bugs.webkit.org/show_bug.cgi?id=50914
3626
3627         This adds a hyperlink to trac changeset on the revision numbers. 
3628
3629         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3630
3631 2010-12-13  Andras Becsi  <abecsi@webkit.org>
3632
3633         Reviewed by Csaba Osztrogonác.
3634
3635         [Qt][WK2] Fix build if WebKitTools are not available
3636         https://bugs.webkit.org/show_bug.cgi?id=50242
3637
3638         * MiniBrowser/qt/MiniBrowser.pro: Correct the comment.
3639         * Scripts/webkitdirs.pm: Added WebKitTools/MiniBrowser to $subdirs.
3640         * MiniBrowser/DerivedSources.pro: Added.
3641
3642 2010-12-13  Eric Seidel  <eric@webkit.org>
3643
3644         Reviewed by Adam Barth.
3645
3646         EWS Queues should remove orpahned pyc files before starting
3647         https://bugs.webkit.org/show_bug.cgi?id=50904
3648
3649         A previous check added a platform.py which caused
3650         EWS bots on some platforms to hit an import exception.
3651         The platform.py file was removed in a subsequent commit, but
3652         the EWS bots in question stayed stuck.  This change will
3653    &n