results.webkit.org: Color should be the worst result, count should include all results
[WebKit-https.git] / Tools / ChangeLog
1 2019-07-25  Jonathan Bedard  <jbedard@apple.com>
2
3         results.webkit.org: Color should be the worst result, count should include all results
4         https://bugs.webkit.org/show_bug.cgi?id=200127
5
6         Rubber-stamped by Aakash Jain.
7
8         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
9         (Dot.prototype.toString): Do not differentiate the count based on the prevailing failure type.
10
11 2019-07-25  Zhifei Fang  <zhifei_fang@apple.com>
12
13         [Timeline]: Make timeline header width automatic, instead of fixed width
14         https://bugs.webkit.org/show_bug.cgi?id=200059
15
16         Reviewed by Jonathan Bedard.
17
18         * resultsdbpy/resultsdbpy/view/static/css/timeline.css:
19         (.dot.crash):
20         (.timeline>.header): Deleted.
21         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
22         (.timeline>.content):
23         (.timeline>.header):
24
25 2019-07-25  Ross Kirsling  <ross.kirsling@sony.com>
26
27         [ESNext] Implement nullish coalescing
28         https://bugs.webkit.org/show_bug.cgi?id=200072
29
30         Reviewed by Darin Adler.
31
32         * Scripts/run-jsc-stress-tests:
33
34 2019-07-24  Fujii Hironori  <Hironori.Fujii@sony.com>
35
36         Add Takashi Komori and Tomoki Imai as contributors
37
38         Unreviewed.
39
40         * Scripts/webkitpy/common/config/contributors.json:
41
42 2019-07-24  Yusuke Suzuki  <ysuzuki@apple.com>
43
44         [bmalloc] Add IsoHeap test to ensure that IsoHeap pages are not allocating too large VA
45         https://bugs.webkit.org/show_bug.cgi?id=200103
46
47         Reviewed by Mark Lam.
48
49         This patch adds tests to TestWTF IsoHeap tests to ensure that IsoHeap's component is not leaking pages or not allocating too large VAs for memory allocation.
50         We use VMTag to get the system view of the allocated VAs and check whether it is not incredibly large.
51
52         While the tests are white-box tests (it means that this is a bit flaky to the implementation changes of IsoHeap), I adjusted some threshold to make this less-flaky
53         to the future implementation changes while it catches the severe issues we had.
54
55         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
56         (assertEmptyPointerSet):
57         (assertHasOnlyObjects):
58         (assertClean):
59         (TEST):
60         (allocateAndDeallocate):
61
62 2019-07-24  Fujii Hironori  <fujii.hironori@gmail.com>
63
64         [CMake] CMAKE_SHARED_LINKER_FLAGS drops "-Wl,--no-undefined"
65         https://bugs.webkit.org/show_bug.cgi?id=200074
66
67         Reviewed by Michael Catanzaro.
68
69         There was a latent issue. PluginTest::indicateTestFailure was
70         using WTF::sleep without linking WTF.
71
72         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
73         Added WebKit::WTF to WebKitTestNetscapePlugIn_LIBRARIES.
74
75 2019-07-24  Fujii Hironori  <fujii.hironori@gmail.com>
76
77         [GTK][WPE][CMake] failing to build TestWebKitAPIInjectedBundle due to missing forwarding headers
78         https://bugs.webkit.org/show_bug.cgi?id=200073
79
80         Reviewed by Michael Catanzaro.
81
82         * TestWebKitAPI/PlatformGTK.cmake:
83         * TestWebKitAPI/PlatformWPE.cmake:
84         Added add_dependencies(TestWebKitAPIInjectedBundle TestWebKitAPI-forwarding-headers).
85
86 2019-07-24  Fujii Hironori  <Hironori.Fujii@sony.com>
87
88         [webkitperl] runCommand doesn't work in Windows Perl
89         https://bugs.webkit.org/show_bug.cgi?id=199900
90
91         Reviewed by Don Olmstead.
92
93         runCommand was always failing implicit fork by using 'open' with
94         '-|' in Windows Perl. Explicitly specify the command to 'open' not
95         to do the implicit fork.
96
97         There is one more difference between Windows and Unix. 'open'
98         successes on Windows even for non existent command while it fails
99         on Unix. So, return the same error code on Unix as well as
100         Windows.
101
102         * Scripts/VCSUtils.pm: Specified the command to 'open'.
103         * Scripts/webkitperl/VCSUtils_unittest/runCommand.pl: 'echo'
104         command is not available on Windows. Use Perl ($^X) instead.
105
106 2019-07-24  Priyanka Agarwal  <pagarwal999@apple.com>
107
108         Allow Clients to Add Fields to the AutoFillContext Dictionary.
109         https://bugs.webkit.org/show_bug.cgi?id=199326
110         rdar://problem/42816957
111
112         Reviewed by Wenson Hsieh.
113
114         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
115         (TestWebKitAPI::TEST): Created a test to check that the auto fill context
116         is being properly populated with additional context dictionary.
117
118         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
119         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
120         (-[TestInputDelegate setWebViewAdditionalContextForStrongPasswordAssistanceHandler:]): Setting the handler for the function
121         which will populate the additional autofill context dictionary.
122
123         (-[TestInputDelegate webViewAdditionalContextForStrongPasswordAssistanceHandler]): Returns the handler for the function which
124         populates the additional autofill context dictionary.
125
126         (-[TestInputDelegate _webViewAdditionalContextForStrongPasswordAssistance:]): Function which populates the additional autofill
127         context dictionary.
128
129         (-[TestInputDelegate setFocusRequiresStrongPasswordAssistanceHandler:]): Setting the handler for the function which checks if the 
130         input field requires strong password work.
131
132         (-[TestInputDelegate focusRequiresStrongPasswordAssistanceHandler]): Returns the handler for the function which checks if the
133         input field requires strong password work.
134
135         (-[TestInputDelegate _webView:focusRequiresStrongPasswordAssistance:]): Function which checks if the input field requires strong
136         password work.
137
138 2019-07-24  Zhifei Fang  <zhifei_fang@apple.com>
139
140         run-javascriptcore-tests won't report test results for testmasm, testair, testb3, testdfg and test api
141         https://bugs.webkit.org/show_bug.cgi?id=199489
142
143         Reviewed by Aakash Jain.
144
145         * BuildSlaveSupport/build.webkit.org-config/steps.py:
146         (RunJavaScriptCoreTests.start): Skip run jsc test binaries for mips, armv7, aarch64.
147         (RunJavaScriptCoreTests.countFailures): Pick up the test binaires failure to total failures count
148         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
149         * Scripts/run-javascriptcore-tests: The script now failed wether the run-jsc-stress-tests failed or test binaries failed.
150         (runTest): Record test binary failure
151         (reportTestFailures): Report test binary failure
152         (runJSCStressTests): 
153         * Scripts/webkitpy/common/config/ports.py: Skip run jsc test binaries for those need to run remotely
154         (JscOnlyPort.build_jsc_command):
155         (JscOnlyPort):
156         (JscOnlyPort.run_javascriptcore_tests_command):
157         * Scripts/webkitpy/common/config/ports_unittest.py:
158         (DeprecatedPortTest.test_jsconly_port):
159
160 2019-07-24  Zalan Bujtas  <zalan@apple.com>
161
162         ASSERTION FAILED: settings().textAutosizingEnabled() && settings().textAutosizingUsesIdempotentMode() in WebCore::Page::recomputeTextAutoSizingInAllFrames()
163         https://bugs.webkit.org/show_bug.cgi?id=200079
164         <rdar://problem/53474325>
165
166         Reviewed by Wenson Hsieh.
167
168         Reset textAutosizingUsesIdempotentMode when transitioning to a new test.
169
170         * WebKitTestRunner/ios/TestControllerIOS.mm:
171         (WTR::TestController::platformResetPreferencesToConsistentValues):
172
173 2019-07-23  Fujii Hironori  <Hironori.Fujii@sony.com>
174
175         [webkitperl] prepare-ChangeLog_unittest/parser_unittests.pl is failing on Windows Perl
176         https://bugs.webkit.org/show_bug.cgi?id=199927
177
178         Reviewed by Alex Christensen.
179
180         convertAbsolutepathToWebKitPath was failing to convert paths on
181         Windows Perl due to path separators mismatch.
182
183         Renamed convertAbsolutepathToWebKitPath to
184         convertAbsolutePathToRelativeUnixPath, and changed it to replace
185         paths to relative Unix paths.
186
187         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
188         (convertAbsolutePathToRelativeUnixPath): Added.
189         (convertAbsolutepathToWebKitPath): Deleted.
190
191 2019-07-23  Alex Christensen  <achristensen@webkit.org>
192
193         Fix iOS API test after r247759
194         https://bugs.webkit.org/show_bug.cgi?id=200045
195
196         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
197         (TEST):
198         In the iOS simulator, the WebProcess was being started before we were setting the value on the WKProcessPool.
199         To fix this, set the value on the WKProcessPool before making the WKWebView.  This makes the test always pass on Mac and iOS.
200
201 2019-07-23  Keith Rollin  <krollin@apple.com>
202
203         Remove rest of NavigatorContentUtils support
204         https://bugs.webkit.org/show_bug.cgi?id=200052
205         <rdar://problem/53467357>
206
207         Reviewed by Alex Christensen.
208
209         Bug 196070 removes most of the support for the never-used
210         NavigatorContentUtils facility. However, there were still a couple of
211         left-over references after that change. This patch sweeps those up.
212
213         * Scripts/webkitperl/FeatureList.pm:
214
215 2019-07-23  Alex Christensen  <achristensen@webkit.org>
216
217         Move javaScriptConfigurationDirectory SPI from _WKProcessPoolConfiguration to WKProcessPoolPrivate to make it runtime switchable
218         https://bugs.webkit.org/show_bug.cgi?id=200045
219
220         Reviewed by Mark Lam.
221
222         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
223         (TEST):
224
225 2019-07-23  Russell Epstein  <repstein@apple.com>
226
227         Unreviewed, rolling out r247745.
228
229         This broke API test
230         TestWebKitAPI.WKProcessPool.JavaScriptConfiguration as
231         indicated by EWS
232
233         Reverted changeset:
234
235         "Move javaScriptConfigurationDirectory SPI from
236         _WKProcessPoolConfiguration to WKProcessPoolPrivate to make it
237         runtime switchable"
238         https://bugs.webkit.org/show_bug.cgi?id=200045
239         https://trac.webkit.org/changeset/247745
240
241 2019-07-23  Alex Christensen  <achristensen@webkit.org>
242
243         Move javaScriptConfigurationDirectory SPI from _WKProcessPoolConfiguration to WKProcessPoolPrivate to make it runtime switchable
244         https://bugs.webkit.org/show_bug.cgi?id=200045
245
246         Reviewed by Mark Lam.
247
248         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
249         (TEST):
250
251 2019-07-23  Alex Christensen  <achristensen@webkit.org>
252
253         Add SPI for setting media cache and key location on _WKWebsiteDataStoreConfiguration
254         https://bugs.webkit.org/show_bug.cgi?id=199972
255
256         Reviewed by Jer Noble.
257
258         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
259         (TEST):
260
261 2019-07-23  Alicia Boya García  <aboya@igalia.com>
262
263         [WTF] Add DataMutex and MainThreadData wrappers
264         https://bugs.webkit.org/show_bug.cgi?id=199831
265
266         Reviewed by Alex Christensen.
267
268         Added a very simple test that checks that DataMutex<T> indeed takes
269         the lock and indeed holds data.
270
271         * TestWebKitAPI/CMakeLists.txt:
272         * TestWebKitAPI/Tests/WTF/DataMutex.cpp: Added.
273         (TestWebKitAPI::TEST):
274
275 2019-07-23  Wenson Hsieh  <wenson_hsieh@apple.com>
276
277         [macOS 10.15] Web process crashes when attempting to show the font panel via Font > Show Fonts
278         https://bugs.webkit.org/show_bug.cgi?id=200021
279         <rdar://problem/53301325>
280
281         Reviewed by Ryosuke Niwa.
282
283         Add support for grabbing the child menu items of a context menu item.
284
285         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
286         (WTR::getMenuItemChildrenCallback):
287
288 2019-07-23  Ryosuke Niwa  <rniwa@webkit.org>
289
290         WebKit should strip away system font names from the pasted content
291         https://bugs.webkit.org/show_bug.cgi?id=199975
292         <rdar://problem/53336353>
293
294         Reviewed by Darin Adler.
295
296         Added a test to strip away system font names such as ".AppleSystemUIFont", ".SFUI-Regular", and ".SF UI Mono".
297
298         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
299         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
300         * TestWebKitAPI/Tests/WebKitCocoa/cocoa-writer-markup-with-system-fonts.html: Added.
301
302 2019-07-22  Aakash Jain  <aakash_jain@apple.com>
303
304         [ews-build] EWS fails to parse multi-line full_results.json
305         https://bugs.webkit.org/show_bug.cgi?id=199992
306
307         Reviewed by Alexey Proskuryakov.
308
309         * BuildSlaveSupport/ews-build/layout_test_failures.py:
310         (LayoutTestFailures.results_from_string): Concatenate content into single line.
311         * BuildSlaveSupport/ews-build/steps_unittest.py:
312         (test_parse_results_json_with_newlines): Unit-test to cover this scenario.
313
314 2019-07-22  Jonathan Bedard  <jbedard@apple.com>
315
316         resultsdbpy: Handle case where the previous commit doesn't have the changelog
317         https://bugs.webkit.org/show_bug.cgi?id=200015
318
319         Reviewed by Aakash Jain.
320
321         * resultsdbpy/resultsdbpy/model/repository.py:
322         (WebKitRepository.commit_for_id.diff_changelogs): Allow the previous_response to be None.
323
324 2019-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
325
326         [iOS] [WK1] UIWebView always jumps to the top left corner when scrolling to reveal the selection
327         https://bugs.webkit.org/show_bug.cgi?id=200013
328         <rdar://problem/52526901>
329
330         Reviewed by Simon Fraser.
331
332         Add a new API test to verify that inserting text in UIWebView causes the document to scroll.
333
334         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
335         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollToRevealSelection.mm: Added.
336         (-[LegacyLoadingDelegate webViewDidFinishLoad:]):
337         (-[LegacyLoadingDelegate waitForDidFinishLoad]):
338         * TestWebKitAPI/ios/UIKitSPI.h:
339
340 2019-07-22  Jer Noble  <jer.noble@apple.com>
341
342         REGRESSION(rUnknown): YouTube playback pauses when switching to a new tab
343         https://bugs.webkit.org/show_bug.cgi?id=199971
344         <rdar://problem/51951218>
345
346         Reviewed by Alex Christensen.
347
348         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
349         * TestWebKitAPI/Tests/WebKitCocoa/NoPauseWhenSwitchingTabs.mm: Added.
350         (TestWebKitAPI::TEST):
351
352 2019-07-22  Aakash Jain  <aakash_jain@apple.com>
353
354         [ews-build] Add an EWS to run services tests
355         https://bugs.webkit.org/show_bug.cgi?id=199994
356
357         Reviewed by Jonathan Bedard.
358
359         * BuildSlaveSupport/ews-build/config.json: Added Services-EWS configuration.
360         * BuildSlaveSupport/ews-build/factories.py: Added ServicesFactory.
361         * BuildSlaveSupport/ews-build/steps.py:
362         (CheckPatchRelevance): Run this EWS only for patches with changes in relevant files.
363         (RunEWSUnitTests): Build step to run EWS unit-tests.
364         (RunEWSBuildbotCheckConfig): Build step to run buildbot checkconfig command.
365         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
366         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added services status-bubble.
367
368 2019-07-22  Youenn Fablet  <youenn@apple.com>
369
370         Disable MediaRecorder for legacy WebKit
371         https://bugs.webkit.org/show_bug.cgi?id=200001
372         <rdar://problem/53400030>
373
374         Reviewed by Eric Carlson.
375
376         Enable MediaRecorder for testing purposes.
377
378         * DumpRenderTree/mac/DumpRenderTree.mm:
379         (createWebViewAndOffscreenWindow):
380
381 2019-07-22  Jonathan Bedard  <jbedard@apple.com>
382
383         results.webkit.org: Timeline header is too small
384         https://bugs.webkit.org/show_bug.cgi?id=199955
385
386         Reviewed by Aakash Jain.
387
388         * resultsdbpy/resultsdbpy/view/static/css/timeline.css:
389         (.timeline>.header): Make timeline header larder to fit configuration names.
390
391 2019-07-22  Alex Christensen  <achristensen@webkit.org>
392
393         Add SPI to _WKWebsiteDataStoreConfiguration for configuring application cache storage location
394         https://bugs.webkit.org/show_bug.cgi?id=199954
395
396         Reviewed by Geoff Garen.
397
398         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
399         (TEST):
400
401 2019-07-22  Alex Christensen  <achristensen@webkit.org>
402
403         Add SPI _WKProcessPoolConfiguration.javaScriptConfigurationDirectory
404         https://bugs.webkit.org/show_bug.cgi?id=199917
405
406         Reviewed by Sam Weinig.
407
408         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
409         (TEST):
410
411 2019-07-22  Aakash Jain  <aakash_jain@apple.com>
412
413         [ews-build] ReRunWebKitTests should use similar logic for evaluateCommand as RunWebKitTests
414         https://bugs.webkit.org/show_bug.cgi?id=199980
415
416         Reviewed by Jonathan Bedard.
417
418         * BuildSlaveSupport/ews-build/steps.py:
419         (ReRunWebKitTests.evaluateCommand): Updatd to use similar logic as RunWebKitTests.
420         * BuildSlaveSupport/ews-build/steps_unittest.py:
421         (TestRunWebKitTests): Modified to make it generic so as to re-use tests.
422         (TestReRunWebKitTests): Run all TestRunWebKitTests unit-tests for ReRunWebKitTests as well.
423
424 2019-07-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
425
426         [webkitpy] Add an unit test for setting up the driver environment without starting it.
427         https://bugs.webkit.org/show_bug.cgi?id=199945
428
429         Reviewed by Michael Catanzaro.
430
431         This adds an unit test for the change implemented in r247663.
432
433         * Scripts/webkitpy/port/driver_unittest.py:
434         (DriverTest.test_setup_environ_base_vars):
435         (DriverTest):
436         (DriverTest.test_setup_environ_without_starting_driver):
437
438 2019-07-21  Wenson Hsieh  <wenson_hsieh@apple.com>
439
440         [iOS] [WebKit2] Add limited support for -isPosition:atBoundary:inDirection: in WKContentView
441         https://bugs.webkit.org/show_bug.cgi?id=199993
442         <rdar://problem/49523528>
443
444         Reviewed by Beth Dakin.
445
446         Add a new API test to verify the behavior of -isPosition:atBoundary:inDirection:.
447
448         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
449         (TestWebKitAPI::TEST):
450         * TestWebKitAPI/cocoa/TestWKWebView.h:
451
452 2019-07-21  Andres Gonzalez  <andresg_22@apple.com>
453
454         Add accessibilityInsertText for text insertion in edit fields.
455         https://bugs.webkit.org/show_bug.cgi?id=199973
456
457         Reviewed by Chris Fleizach.
458
459         Renamed accessibilityInsertText to _accessibilityInsertText.
460
461         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
462         (AccessibilityUIElement::insertText):
463         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
464         (AccessibilityUIElement::insertText):
465         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
466         (WTR::AccessibilityUIElement::insertText):
467         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
468         (WTR::AccessibilityUIElement::insertText):
469
470 2019-07-20  Chris Dumez  <cdumez@apple.com>
471
472         Speed up HashTable decoding by reserving capacity and avoiding rehashing
473         https://bugs.webkit.org/show_bug.cgi?id=199982
474
475         Reviewed by Saam Barati.
476
477         Add API test coverage.
478
479         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
480         (TestWebKitAPI::TEST):
481
482 2019-07-20  Andres Gonzalez  <andresg_22@apple.com>
483
484         Add accessibilityInsertText for text insertion in edit fields.
485         https://bugs.webkit.org/show_bug.cgi?id=199973
486
487         Reviewed by Chris Fleizach.
488
489         Glue code to run new LayoutTests.
490         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
491         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
492         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
493         (WTR::AccessibilityUIElement::insertText):
494         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
495         (WTR::AccessibilityUIElement::insertText):
496         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
497         (WTR::AccessibilityUIElement::insertText):
498         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
499         (WTR::AccessibilityUIElement::insertText):
500
501 2019-07-19  Zhifei Fang  <zhifei_fang@apple.com>
502
503         Move webkit.css to opensource to support resultsdbpy's frontend
504         https://bugs.webkit.org/show_bug.cgi?id=199957
505
506         Reviewed by Jonathan Bedard.
507
508         * resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml: Added.
509         * resultsdbpy/resultsdbpy/view/static/library/css/generate-webkit-css-docs: Added.
510         * resultsdbpy/resultsdbpy/view/static/library/css/index.html: Added.
511         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css: Added.
512
513 2019-07-19  Zhifei Fang  <zhifei_fang@apple.com>
514
515         Move Ref.js to WebKit to support resultsdbpy's frontend
516         https://bugs.webkit.org/show_bug.cgi?id=199956
517
518         Reviewed by Jonathan Bedard.
519
520         * resultsdbpy/resultsdbpy/view/static/js/drawer.js:
521         * resultsdbpy/resultsdbpy/view/static/js/search.js:
522         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
523         * resultsdbpy/resultsdbpy/view/static/library/js/Ref.js: Added.
524         * resultsdbpy/resultsdbpy/view/static/library/js/Utils.js: Added.
525         * resultsdbpy/resultsdbpy/view/static/library/js/components/BaseComponents.js: Added.
526         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js: Added.
527         * resultsdbpy/resultsdbpy/view/templates/base.html:
528         * resultsdbpy/resultsdbpy/view/templates/commits.html:
529         * resultsdbpy/resultsdbpy/view/templates/documentation.html:
530         * resultsdbpy/resultsdbpy/view/templates/search.html:
531         * resultsdbpy/resultsdbpy/view/templates/suite_results.html:
532         * resultsdbpy/resultsdbpy/view/view_routes.py:
533
534 2019-07-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
535
536         [webkitpy] Allow the testrunner driver to setup the environment completely without needing to start the server process.
537         https://bugs.webkit.org/show_bug.cgi?id=199945
538
539         Reviewed by Michael Catanzaro.
540
541         Refactor the code to create the Driver temporal directories inside Driver._setup_environ_for_driver().
542         This allows external callers to setup the environment for running tests by calling that method without needing to start the server process.
543         When this callers finish testing, it is enough with calling either Driver.stop() or Driver._delete_temporal_directories().
544
545         * Scripts/webkitpy/port/driver.py:
546         (Driver._setup_environ_for_driver):
547         (Driver._create_temporal_directories):
548         (Driver):
549         (Driver._start):
550         (Driver._delete_temporal_directories):
551         (Driver.stop):
552         * Scripts/webkitpy/w3c/wpt_runner.py: Not needed anymore to start the driver since this doesnt need the server process running.
553         (main):
554         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py: Ditto.
555         (WebDriverTestRunner.__init__):
556         * glib/api_test_runner.py:
557         (TestRunner._setup_testing_environment): Ditto.
558
559 2019-07-19  Aakash Jain  <aakash_jain@apple.com>
560
561         [ews-build] Display pre-existing Layout test failure names in the build summary
562         https://bugs.webkit.org/show_bug.cgi?id=199941
563
564         Reviewed by Jonathan Bedard.
565
566         * BuildSlaveSupport/ews-build/steps.py:
567         (AnalyzeLayoutTestsResults.report_pre_existing_failures):
568
569 2019-07-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
570
571         [GTK][WPE] run-webkit-tests should run with a temporal homedir
572         https://bugs.webkit.org/show_bug.cgi?id=199738
573
574         Reviewed by Michael Catanzaro.
575
576         Run the tests with an empty homedir that is created inside the driver tmpdir.
577         The driver tmpdir is a random directory created for each test runner that is purged after the run.
578
579         This is done to ensure that the test results are not affected by the user settings of any library.
580
581         * Scripts/webkitpy/port/driver.py:
582         (Driver._setup_environ_for_driver):
583         * Scripts/webkitpy/port/driver_unittest.py:
584         (DriverTest.test_setup_environ_base_vars):
585         (DriverTest):
586         (DriverTest.test_create_temporal_home_dir):
587
588 2019-07-19  Carlos Garcia Campos  <cgarcia@igalia.com>
589
590         Remove pywebsockets from thirdparty
591         https://bugs.webkit.org/show_bug.cgi?id=199710
592
593         Reviewed by Jonathan Bedard.
594
595         We have a very old version of pywebsocket in webkitpy thirdparty, but we are also importing pywebsocket as part
596         of wpt tools. We can simply use the wpt one for all websocket tests and remove the old copy from sources.
597
598         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
599         (PyWebSocket._prepare_config): Use pywebsocket from imported w3c tools directory.
600         * Scripts/webkitpy/thirdparty/mod_pywebsocket/COPYING: Removed.
601         * Scripts/webkitpy/thirdparty/mod_pywebsocket/__init__.py: Removed.
602         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_base.py: Removed.
603         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hixie75.py: Removed.
604         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py: Removed.
605         * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py: Removed.
606         * Scripts/webkitpy/thirdparty/mod_pywebsocket/dispatch.py: Removed.
607         * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py: Removed.
608         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/__init__.py: Removed.
609         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py: Removed.
610         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py: Removed.
611         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi00.py: Removed.
612         * Scripts/webkitpy/thirdparty/mod_pywebsocket/headerparserhandler.py: Removed.
613         * Scripts/webkitpy/thirdparty/mod_pywebsocket/http_header_util.py: Removed.
614         * Scripts/webkitpy/thirdparty/mod_pywebsocket/memorizingfile.py: Removed.
615         * Scripts/webkitpy/thirdparty/mod_pywebsocket/msgutil.py: Removed.
616         * Scripts/webkitpy/thirdparty/mod_pywebsocket/mux.py: Removed.
617         * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py: Removed.
618         * Scripts/webkitpy/thirdparty/mod_pywebsocket/stream.py: Removed.
619         * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py: Removed.
620
621 2019-07-18  Jonathan Bedard  <jbedard@apple.com>
622
623         results.webkit.org: Move resultsdbpy to WebKit
624         https://bugs.webkit.org/show_bug.cgi?id=199837
625         <rdar://problem/53172130>
626
627         Rubber-stamped by Aakash Jain.
628
629         Moving the entirety of the resultsdbpy library, which provides utilities to build
630         a database designed to store, visualize and organize test results, into WebKit.
631
632         * Scripts/webkitpy/style/checker.py:
633         (CheckerDispatcher._create_checker): resulltsdbpy is a Python 3 library.
634         * resultsdbpy: Added.
635         * resultsdbpy/MANIFEST.in: Added.
636         * resultsdbpy/README.md: Added.
637         * resultsdbpy/resultsdbpy: Added.
638         * resultsdbpy/resultsdbpy/__init__.py: Added.
639         * resultsdbpy/resultsdbpy/controller: Added.
640         * resultsdbpy/resultsdbpy/controller/__init__.py: Added.
641         * resultsdbpy/resultsdbpy/controller/api_routes.py: Added.
642         * resultsdbpy/resultsdbpy/controller/ci_controller.py: Added.
643         * resultsdbpy/resultsdbpy/controller/ci_controller_unittest.py: Added.
644         * resultsdbpy/resultsdbpy/controller/commit.py: Added.
645         * resultsdbpy/resultsdbpy/controller/commit_controller.py: Added.
646         * resultsdbpy/resultsdbpy/controller/commit_controller_unittest.py: Added.
647         * resultsdbpy/resultsdbpy/controller/commit_unittest.py: Added.
648         * resultsdbpy/resultsdbpy/controller/configuration.py: Added.
649         * resultsdbpy/resultsdbpy/controller/configuration_controller.py: Added.
650         * resultsdbpy/resultsdbpy/controller/configuration_controller_unittest.py: Added.
651         * resultsdbpy/resultsdbpy/controller/configuration_unittest.py: Added.
652         * resultsdbpy/resultsdbpy/controller/suite_controller.py: Added.
653         * resultsdbpy/resultsdbpy/controller/suite_controller_unittest.py: Added.
654         * resultsdbpy/resultsdbpy/controller/test_controller.py: Added.
655         * resultsdbpy/resultsdbpy/controller/test_controller_unittest.py: Added.
656         * resultsdbpy/resultsdbpy/controller/upload_controller.py: Added.
657         * resultsdbpy/resultsdbpy/controller/upload_controller_unittest.py: Added.
658         * resultsdbpy/resultsdbpy/flask_support: Added.
659         * resultsdbpy/resultsdbpy/flask_support/__init__.py: Added.
660         * resultsdbpy/resultsdbpy/flask_support/authed_blueprint.py: Added.
661         * resultsdbpy/resultsdbpy/flask_support/flask_test_context.py: Added.
662         * resultsdbpy/resultsdbpy/flask_support/flask_testcase.py: Added.
663         * resultsdbpy/resultsdbpy/flask_support/util.py: Added.
664         * resultsdbpy/resultsdbpy/flask_support/util_unittest.py: Added.
665         * resultsdbpy/resultsdbpy/model: Added.
666         * resultsdbpy/resultsdbpy/model/__init__.py: Added.
667         * resultsdbpy/resultsdbpy/model/cassandra_context.py: Added.
668         * resultsdbpy/resultsdbpy/model/cassandra_context_unittest.py: Added.
669         * resultsdbpy/resultsdbpy/model/casserole.py: Added.
670         * resultsdbpy/resultsdbpy/model/casserole_unittest.py: Added.
671         * resultsdbpy/resultsdbpy/model/ci_context.py: Added.
672         * resultsdbpy/resultsdbpy/model/ci_context_unittest.py: Added.
673         * resultsdbpy/resultsdbpy/model/commit_context.py: Added.
674         * resultsdbpy/resultsdbpy/model/commit_context_unittest.py: Added.
675         * resultsdbpy/resultsdbpy/model/configuration_context.py: Added.
676         * resultsdbpy/resultsdbpy/model/configuration_context_unittest.py: Added.
677         * resultsdbpy/resultsdbpy/model/docker-compose.yml: Added.
678         * resultsdbpy/resultsdbpy/model/docker.py: Added.
679         * resultsdbpy/resultsdbpy/model/docker_unittest.py: Added.
680         * resultsdbpy/resultsdbpy/model/mock_cassandra_context.py: Added.
681         * resultsdbpy/resultsdbpy/model/mock_model_factory.py: Added.
682         * resultsdbpy/resultsdbpy/model/mock_repository.py: Added.
683         * resultsdbpy/resultsdbpy/model/model.py: Added.
684         * resultsdbpy/resultsdbpy/model/partitioned_redis.py: Added.
685         * resultsdbpy/resultsdbpy/model/partitioned_redis_unittest.py: Added.
686         * resultsdbpy/resultsdbpy/model/redis_unittest.py: Added.
687         * resultsdbpy/resultsdbpy/model/repository.py: Added.
688         * resultsdbpy/resultsdbpy/model/repository_unittest.py: Added.
689         * resultsdbpy/resultsdbpy/model/suite_context.py: Added.
690         * resultsdbpy/resultsdbpy/model/suite_context_unittest.py: Added.
691         * resultsdbpy/resultsdbpy/model/test_context.py: Added.
692         * resultsdbpy/resultsdbpy/model/test_context_unittest.py: Added.
693         * resultsdbpy/resultsdbpy/model/upload_context.py: Added.
694         * resultsdbpy/resultsdbpy/model/upload_context_unittest.py: Added.
695         * resultsdbpy/resultsdbpy/model/wait_for_docker_test_case.py: Added.
696         * resultsdbpy/resultsdbpy/run-tests: Added.
697         * resultsdbpy/resultsdbpy/view: Added.
698         * resultsdbpy/resultsdbpy/view/__init__.py: Added.
699         * resultsdbpy/resultsdbpy/view/ci_view.py: Added.
700         * resultsdbpy/resultsdbpy/view/commit_view.py: Added.
701         * resultsdbpy/resultsdbpy/view/commit_view_unittest.py: Added.
702         * resultsdbpy/resultsdbpy/view/site_menu.py: Added.
703         * resultsdbpy/resultsdbpy/view/static: Added.
704         * resultsdbpy/resultsdbpy/view/static/css: Added.
705         * resultsdbpy/resultsdbpy/view/static/css/commit.css: Added.
706         * resultsdbpy/resultsdbpy/view/static/css/drawer.css: Added.
707         * resultsdbpy/resultsdbpy/view/static/css/search.css: Added.
708         * resultsdbpy/resultsdbpy/view/static/css/timeline.css: Added.
709         * resultsdbpy/resultsdbpy/view/static/js: Added.
710         * resultsdbpy/resultsdbpy/view/static/js/commit.js: Added.
711         * resultsdbpy/resultsdbpy/view/static/js/common.js: Added.
712         * resultsdbpy/resultsdbpy/view/static/js/configuration.js: Added.
713         * resultsdbpy/resultsdbpy/view/static/js/drawer.js: Added.
714         * resultsdbpy/resultsdbpy/view/static/js/search.js: Added.
715         * resultsdbpy/resultsdbpy/view/static/js/timeline.js: Added.
716         * resultsdbpy/resultsdbpy/view/suite_view.py: Added.
717         * resultsdbpy/resultsdbpy/view/templates: Added.
718         * resultsdbpy/resultsdbpy/view/templates/base.html: Added.
719         * resultsdbpy/resultsdbpy/view/templates/commit.html: Added.
720         * resultsdbpy/resultsdbpy/view/templates/commits.html: Added.
721         * resultsdbpy/resultsdbpy/view/templates/documentation.html: Added.
722         * resultsdbpy/resultsdbpy/view/templates/error.html: Added.
723         * resultsdbpy/resultsdbpy/view/templates/search.html: Added.
724         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Added.
725         * resultsdbpy/resultsdbpy/view/view_routes.py: Added.
726         * resultsdbpy/resultsdbpy/view/view_routes_unittest.py: Added.
727         * resultsdbpy/setup.py: Added.
728
729 2019-07-18  Alex Christensen  <achristensen@webkit.org>
730
731         Add and test _WKWebsiteDataStoreConfiguration.deviceIdHashSaltsStorageDirectory SPI
732         https://bugs.webkit.org/show_bug.cgi?id=199923
733
734         Reviewed by Youenn Fablet.
735
736         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
737         (TestWebKitAPI::TEST):
738
739 2019-07-18  Aakash Jain  <aakash_jain@apple.com>
740
741         [ews-build] Enable iOS WK2 tester queue on new EWS
742         https://bugs.webkit.org/show_bug.cgi?id=199867
743
744         Reviewed by Jonathan Bedard.
745
746         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for ios-wk2 queue.
747         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Enabled ios-sim (builder) and ios-wk2 (tester) bubbles.
748         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Removed ios-sim queue from bot-watcher's dashboard.
749         * QueueStatusServer/config/queues.py: Removed ios-sim queue from old EWS.
750
751 2019-07-18  Aakash Jain  <aakash_jain@apple.com>
752
753         [ews-build] Add build step to AnalyzeLayoutTestsResults
754         https://bugs.webkit.org/show_bug.cgi?id=199877
755
756         Reviewed by Jonathan Bedard.
757
758         Logic is ported from webkitpy/tool/bot/patchanalysistask.py::_retry_layout_tests()
759
760         * BuildSlaveSupport/ews-build/steps.py:
761         (RunWebKitTestsWithoutPatch.evaluateCommand): invoke AnalyzeLayoutTestsResults step.
762         (AnalyzeLayoutTestsResults): Build step to analyze layout-test results.
763         (AnalyzeLayoutTestsResults.report_failure):
764         (AnalyzeLayoutTestsResults.report_pre_existing_failures):
765         (AnalyzeLayoutTestsResults.retry_build):
766         (AnalyzeLayoutTestsResults._results_failed_different_tests):
767         (AnalyzeLayoutTestsResults._report_flaky_tests):
768         (AnalyzeLayoutTestsResults.start):
769         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
770
771 2019-07-18  Alex Christensen  <achristensen@webkit.org>
772
773         Move NetworkCache ownership from NetworkProcess to NetworkSession
774         https://bugs.webkit.org/show_bug.cgi?id=199817
775
776         Reviewed by Geoff Garen.
777
778         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
779         (TEST):
780         * TestWebKitAPI/cocoa/TestWKWebView.h:
781         * TestWebKitAPI/cocoa/TestWKWebView.mm:
782         (-[WKWebView synchronouslyLoadRequest:]):
783
784 2019-07-18  Youenn Fablet  <youenn@apple.com>
785
786         Make sure to set kCTFontFallbackOptionAttribute to kCTFontFallbackOptionSystem for system fonts
787         https://bugs.webkit.org/show_bug.cgi?id=199769
788         <rdar://problem/49390297>
789
790         Reviewed by Myles C. Maxfield.
791
792         Add a font containing one extended character not found in system fonts.
793
794         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
795         * WebKitTestRunner/fonts/FakeHelvetica-SingleExtendedCharacter.ttf: Added.
796
797 2019-07-18  Konstantin Tokarev  <annulen@yandex.ru>
798
799         Unreviewed, Add Olivier Blin as contributor
800
801         * Scripts/webkitpy/common/config/contributors.json:
802
803 2019-07-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
804
805         [GTK][WPE][webkitpy] Refactor drivers to use the base driver for setting up the environment and start the drivers.
806         https://bugs.webkit.org/show_bug.cgi?id=199855
807
808         Reviewed by Michael Catanzaro.
809
810         The webkitpy drivers for GTK and WPE use their own versions for setting
811         up the environment and starting/stopping the drivers.
812         This refactors those drivers to use the base class driver functions.
813         As a benefit we get some fixes like support for setting the profiler
814         environment variables, and a simpler code.
815
816         * Scripts/webkitpy/port/driver.py:
817         (Driver._setup_environ_for_driver): This already correctly setups LOCAL_RESOURCE_ROOT and DUMPRENDERTREE_TEMP.
818         Add the remaining environment variable XDG_CACHE_HOME that is needed for Linux.
819         * Scripts/webkitpy/port/headlessdriver.py:
820         (HeadlessDriver._setup_environ_for_test):
821         * Scripts/webkitpy/port/waylanddriver.py:
822         (WaylandDriver._setup_environ_for_test):
823         * Scripts/webkitpy/port/westondriver.py:
824         (WestonDriver._setup_environ_for_test):
825         (WestonDriver.stop):
826         * Scripts/webkitpy/port/westondriver_unittest.py: now mock _test_runner_process_constructor as base driver does.
827         (WestonDriverTest.make_driver):
828         * Scripts/webkitpy/port/xorgdriver.py:
829         (XorgDriver._setup_environ_for_test):
830         * Scripts/webkitpy/port/xvfbdriver.py: the xvfb binary is started with the port server env
831         (XvfbDriver._setup_environ_for_test):
832         * Scripts/webkitpy/port/xvfbdriver_unittest.py: rename the variable to make clearer that it uses the port server env.
833         (XvfbDriverTest.make_driver):
834         (XvfbDriverTest.test_start):
835         (XvfbDriverTest.test_start_arbitrary_worker_number):
836         * Scripts/webkitpy/w3c/wpt_runner.py:
837         (main): Start the driver before trying to get its environment to define all the environment variables.
838         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
839         (WebDriverTestRunner.__init__): Ditto.
840         * glib/api_test_runner.py:
841         (TestRunner._setup_testing_environment): Ditto.
842
843 2019-07-17  Antoine Quint  <graouts@apple.com>
844
845         Disable Pointer Events prior to watchOS 6
846         https://bugs.webkit.org/show_bug.cgi?id=199890
847         <rdar://problem/53206113>
848
849         Reviewed by Dean Jackson.
850
851         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
852
853 2019-07-17  Christopher Reid  <chris.reid@sony.com>
854
855         Bytecode cache should use FileSystem
856         https://bugs.webkit.org/show_bug.cgi?id=199759
857
858         Reviewed by Yusuke Suzuki.
859
860         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
861
862 2019-07-17  Jonathan Bedard  <jbedard@apple.com>
863
864         check-webkit-style: Add limited Python3 support
865         https://bugs.webkit.org/show_bug.cgi?id=199870
866
867         Rubber-stamped by Aakash Jain.
868
869         Since new services will be added in the near future which are Python 3, we
870         need to support Python 3 style checks. For now, assume all Python files are
871         Python 2 unless otherwise specified.
872
873         * Scripts/webkitpy/style/checker.py:
874         (_all_categories): Add pycodestyle to valid categories for testing.
875         (CheckerDispatcher._create_checker): Check that the provided Python file is in
876         one of the declared Python 3 directories.
877         * Scripts/webkitpy/style/checkers/python.py:
878         (Python3Checker): Add Python 3 checker, which doesn't lint and uses pycodestyle
879         instead of pep8.
880         (Python3Checker.__init__):
881         (Python3Checker.check):
882         * Scripts/webkitpy/thirdparty/__init__.py:
883         (AutoinstallImportHook.find_module): Support auto-installing pycodestyle.
884         (AutoinstallImportHook._install_pycodestyle):
885
886 2019-07-17  Sam Weinig  <weinig@apple.com>
887
888         Add StringBuilder member function which allows makeString() style variadic argument construction
889         https://bugs.webkit.org/show_bug.cgi?id=198997
890
891         Reviewed by Darin Adler.
892
893         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
894         Add basic test showing that StringBuilder::flexibleAppend can be used to 
895         append one or more string adaptable types. 
896
897         * TestWebKitAPI/CMakeLists.txt:
898         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
899         Add WTFStringUtilities.cpp
900
901         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
902         Add basic test showing that StringBuilder::flexibleAppend can be used to 
903         append one or more string adaptable types. 
904
905         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
906         * TestWebKitAPI/WTFStringUtilities.cpp: Added.
907         * TestWebKitAPI/WTFStringUtilities.h:
908         Move WTF_STRINGTYPEADAPTER_COPIED_WTF_STRING() and wtfStringCopyCount to WTFStringUtilities.h/cpp
909         to allow for a single definition of StringTypeAdapter<String, void> which is required for ODR.
910
911 2019-07-17  Ryosuke Niwa  <rniwa@webkit.org>
912
913         Remove the file superfluously added in r247535.
914
915         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.h: Removed.
916         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.mm:
917
918 2019-07-17  Alex Christensen  <achristensen@webkit.org>
919
920         Add a runtime-disabled dialog element skeleton
921         https://bugs.webkit.org/show_bug.cgi?id=199839
922
923         Reviewed by Ryosuke Niwa.
924
925         * DumpRenderTree/mac/DumpRenderTree.mm:
926         (resetWebPreferencesToConsistentValues):
927         * WebKitTestRunner/TestController.cpp:
928         (WTR::TestController::resetPreferencesToConsistentValues):
929         Enable the dialog element for layout tests.
930
931 2019-07-17  Ryosuke Niwa  <rniwa@webkit.org>
932
933         [iOS] Option + Up or Down Arrow key doesn’t move cursor past paragraph boundaries in WebKit2
934         https://bugs.webkit.org/show_bug.cgi?id=199851
935
936         Reviewed by Wenson Hsieh.
937
938         Added a regression test for iOS. Unfortunately, event sender, etc... doesn't work because
939         this code is getting directly triggered from UIKeyboard's code.
940
941         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
942         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.h: Added.
943         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.mm: Added.
944         * TestWebKitAPI/ios/UIKitSPI.h:
945
946 2019-07-17  Commit Queue  <commit-queue@webkit.org>
947
948         Unreviewed, rolling out r247505.
949         https://bugs.webkit.org/show_bug.cgi?id=199871
950
951         "Caused failed ASSERT in stress test" (Requested by creid on
952         #webkit).
953
954         Reverted changeset:
955
956         "Bytecode cache should use FileSystem"
957         https://bugs.webkit.org/show_bug.cgi?id=199759
958         https://trac.webkit.org/changeset/247505
959
960 2019-07-17  Russell Epstein  <russell_e@apple.com>
961
962         Adding self to contributors.json
963
964         Unreviewed.
965
966         * Scripts/webkitpy/common/config/contributors.json:
967
968 2019-07-17  Aakash Jain  <aakash_jain@apple.com>
969
970         [ews-build] Parse full_results.json for layout-tests
971         https://bugs.webkit.org/show_bug.cgi?id=199804
972
973         Reviewed by Jonathan Bedard.
974
975         * BuildSlaveSupport/ews-build/steps.py:
976         (RunWebKitTests.start): Monitor json output.
977         (RunWebKitTests.commandComplete): Read json output, parse the results and set Buildbot properties accordingly. These
978         properties would be used in subsequent AnalyzeLayoutTests build step to determine whether the failures are introduced
979         by the patch or are pre-existing.
980         (ReRunWebKitTests.commandComplete): Ditto.
981         (RunWebKitTestsWithoutPatch.commandComplete): Ditto.
982         * BuildSlaveSupport/ews-build/steps_unittest.py:
983         (BuildStepMixinAdditions.getProperty): Added.
984         (TestRunWebKitTests.test_parse_results_json): Added unit-tests.
985         * BuildSlaveSupport/ews-build/layout_test_failures.py: Parse full_results.json and generate list of failing tests.
986
987 2019-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
988
989         Unreviewed, rolling out r247512.
990
991         Broke API test runners
992
993         Reverted changeset:
994
995         "[GTK][WPE][webkitpy] Refactor drivers to use the base driver
996         for setting up the environment and start the drivers."
997         https://bugs.webkit.org/show_bug.cgi?id=199855
998         https://trac.webkit.org/changeset/247512
999
1000 2019-07-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1001
1002         [GTK][WPE][webkitpy] Refactor drivers to use the base driver for setting up the environment and start the drivers.
1003         https://bugs.webkit.org/show_bug.cgi?id=199855
1004
1005         Reviewed by Carlos Garcia Campos.
1006
1007         The webkitpy drivers for GTK and WPE use their own versions for setting
1008         up the environment and starting/stopping the drivers.
1009         This refactors those drivers to use the base class driver functions.
1010         As a benefit we get some fixes like support for setting the profiler
1011         environment variables, and a simpler code.
1012
1013         * Scripts/webkitpy/port/driver.py:
1014         (Driver._setup_environ_for_driver): This already correctly setups LOCAL_RESOURCE_ROOT and DUMPRENDERTREE_TEMP.
1015         Add the remaining environment variable XDG_CACHE_HOME that is needed for Linux.
1016         * Scripts/webkitpy/port/headlessdriver.py:
1017         (HeadlessDriver._setup_environ_for_test):
1018         * Scripts/webkitpy/port/waylanddriver.py:
1019         (WaylandDriver._setup_environ_for_test):
1020         * Scripts/webkitpy/port/westondriver.py:
1021         (WestonDriver._setup_environ_for_test):
1022         (WestonDriver.stop):
1023         * Scripts/webkitpy/port/westondriver_unittest.py: now mock _test_runner_process_constructor as base driver does.
1024         (WestonDriverTest.make_driver):
1025         * Scripts/webkitpy/port/xorgdriver.py:
1026         (XorgDriver._setup_environ_for_test):
1027         * Scripts/webkitpy/port/xvfbdriver.py: the xvfb binary is started with the port server env
1028         (XvfbDriver._setup_environ_for_test):
1029         * Scripts/webkitpy/port/xvfbdriver_unittest.py: rename the variable to make clearer that it uses the port server env.
1030         (XvfbDriverTest.make_driver):
1031         (XvfbDriverTest.test_start):
1032         (XvfbDriverTest.test_start_arbitrary_worker_number):
1033
1034 2019-07-16  Christopher Reid  <chris.reid@sony.com>
1035
1036         Bytecode cache should use FileSystem
1037         https://bugs.webkit.org/show_bug.cgi?id=199759
1038
1039         Reviewed by Yusuke Suzuki.
1040
1041         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
1042
1043 2019-07-16  Jonathan Bedard  <jbedard@apple.com>
1044
1045         svn-create-patch duplicates diffs when adding directories
1046         https://bugs.webkit.org/show_bug.cgi?id=199842
1047
1048         Reviewed by Dewei Zhu.
1049
1050         * Scripts/svn-create-patch:
1051         (findKind): Add function which returns what 'kind' of file the provided path is.
1052         (generateFileList): If the path is a directory and being added, don't add it.
1053         Instead, rely on the fact that its children will be added.
1054
1055 2019-07-16  Tim Horton  <timothy_horton@apple.com>
1056
1057         NSTextFinder holes don't scroll with the page
1058         https://bugs.webkit.org/show_bug.cgi?id=199815
1059         <rdar://problem/52280514>
1060
1061         Reviewed by Simon Fraser.
1062
1063         * MiniBrowser/mac/WK2BrowserWindowController.m:
1064         (-[MiniBrowserNSTextFinder performAction:]):
1065         (-[WK2BrowserWindowController awakeFromNib]):
1066         Adopt the WebKit UI in MiniBrowser. Also, override NSTextFinder's
1067         -performAction: so that we can intercept the close action and
1068         hide our own find UI, since there is no delegate for that action yet.
1069
1070         * TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
1071         (TEST):
1072
1073 2019-07-15  Keith Miller  <keith_miller@apple.com>
1074
1075         JSGlobalObject type macros should support feature flags and WeakRef should have one
1076         https://bugs.webkit.org/show_bug.cgi?id=199601
1077
1078         Reviewed by Mark Lam.
1079
1080         JSC options need to be set before the window is created for the test.
1081
1082         * DumpRenderTree/mac/DumpRenderTree.mm:
1083         (resetWebViewToConsistentStateBeforeTesting):
1084         * DumpRenderTree/win/DumpRenderTree.cpp:
1085         (setJSCOptions):
1086         (resetWebViewToConsistentStateBeforeTesting):
1087
1088 2019-07-15  Said Abou-Hallawa  <sabouhallawa@apple.com>
1089
1090         [ Mojave WK1 ] Some Image tests are flakey failures and are failing in tandem with zoomed in or blank image results
1091         https://bugs.webkit.org/show_bug.cgi?id=193108
1092
1093         Reviewed by Simon Fraser.
1094
1095         Add a workaround for <rdar://problem/17084993> in createBitmapContextFromWebView().
1096         Re-request the snapshot at kCGWindowImageNominalResolution if it was captured
1097         at the wrong scale.
1098
1099         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1100         (takeWindowSnapshot):
1101         (createBitmapContextFromWebView):
1102
1103 2019-07-15  Brady Eidson  <beidson@apple.com>
1104
1105         Make WKURLSchemeTask thread safe.
1106         <rdar://problem/50471863> and https://bugs.webkit.org/show_bug.cgi?id=199764
1107
1108         Reviewed by Alex Christensen.
1109
1110         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1111
1112 2019-07-15  Jiewen Tan  <jiewen_tan@apple.com>
1113
1114         Unreviewed, a build fix after r247437
1115
1116         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
1117         Added platform guard towards -[WKUIDelegate _presentingViewControllerForWebView:].
1118
1119 2019-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1120
1121         [macOS 10.15] Cannot unbold selected text when the system font is used
1122         https://bugs.webkit.org/show_bug.cgi?id=199788
1123         <rdar://problem/52142570>
1124
1125         Reviewed by Tim Horton.
1126
1127         Add a new API test to verify that bolding and unbolding updates the
1128         shared font manager's selected font.
1129
1130         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
1131         (TestWebKitAPI::TEST):
1132
1133 2019-07-15  Jiewen Tan  <jiewen_tan@apple.com>
1134
1135         [iOS] SOAuthorizationSession should tell AppSSO whether the UIClient is capable of showing the extension UI
1136         https://bugs.webkit.org/show_bug.cgi?id=199790
1137         <rdar://problem/52790112>
1138
1139         Reviewed by Brent Fulgham.
1140
1141         Add tests to check SOAuthorization.enableEmbeddedAuthorizationViewController accordingly.
1142
1143         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
1144         (-[TestSOAuthorizationDelegate _presentingViewControllerForWebView:]):
1145         (configureSOAuthorizationWebView):
1146         (TestWebKitAPI::TEST):
1147         (-[TestSOAuthorizationNavigationDelegate init]): Deleted.
1148         (-[TestSOAuthorizationNavigationDelegate webView:didFinishNavigation:]): Deleted.
1149         (-[TestSOAuthorizationNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
1150         (-[TestSOAuthorizationNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]): Deleted.
1151         (-[TestSOAuthorizationNavigationDelegate _webView:decidePolicyForSOAuthorizationLoadWithCurrentPolicy:forExtension:completionHandler:]): Deleted.
1152
1153 2019-07-15  Sihui Liu  <sihui_liu@apple.com>
1154
1155         window.openDatabase is not writable
1156         https://bugs.webkit.org/show_bug.cgi?id=199737
1157         <rdar://problem/52551332>
1158
1159         Reviewed by Chris Dumez.
1160
1161         * TestWebKitAPI/Tests/WebKitCocoa/WebSQLBasics.mm:
1162         (TEST):
1163         * TestWebKitAPI/Tests/WebKitCocoa/opendatabase-always-exists.html:
1164
1165 2019-07-15  Aakash Jain  <aakash_jain@apple.com>
1166
1167         [ews-build] Parse and display layout test failures
1168         https://bugs.webkit.org/show_bug.cgi?id=199709
1169
1170         Rubber-stamped by Jonathan Bedard.
1171
1172         * BuildSlaveSupport/ews-build/steps.py:
1173         (RunWebKitTests.start): Initialize log_observer.
1174         (RunWebKitTests._strip_python_logging_prefix): Copied from similar code in build.webkit.org buildbot config.
1175         (RunWebKitTests._parseRunWebKitTestsOutput): Ditto.
1176         (RunWebKitTests.commandComplete): Gather and parse the stdout and stderr logs.
1177         (RunWebKitTests.evaluateResult): Analyze the results and decide build status.
1178         (RunWebKitTests.getResultSummary): Update build and step summary.
1179         * BuildSlaveSupport/ews-build/steps_unittest.py: Added and updated unit-tests.
1180
1181 2019-07-15  Commit Queue  <commit-queue@webkit.org>
1182
1183         Unreviewed, rolling out r247393.
1184         https://bugs.webkit.org/show_bug.cgi?id=199797
1185
1186         broke mips and arm EWS (Requested by guijemont on #webkit).
1187
1188         Reverted changeset:
1189
1190         "run-javascriptcore-tests won't report test results for
1191         testmasm, testair, testb3, testdfg and test api"
1192         https://bugs.webkit.org/show_bug.cgi?id=199489
1193         https://trac.webkit.org/changeset/247393
1194
1195 2019-07-12  Andy Estes  <aestes@apple.com>
1196
1197         [Cocoa] -loadFileURL:allowingReadAccessToURL: should fully resolve file URLs
1198         https://bugs.webkit.org/show_bug.cgi?id=199768
1199         <rdar://problem/52002206>
1200
1201         Reviewed by Geoffrey Garen.
1202
1203         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
1204         (TEST):
1205
1206 2019-07-12  Aakash Jain  <aakash_jain@apple.com>
1207
1208         [ews-build] Remove wincairo queue from old EWS and dashboard
1209         https://bugs.webkit.org/show_bug.cgi?id=199776
1210
1211         Reviewed by Don Olmstead.
1212
1213         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1214         * QueueStatusServer/config/queues.py:
1215
1216 2019-07-12  Aakash Jain  <aakash_jain@apple.com>
1217
1218         [ews-build] Enable wincairo queue on new EWS
1219         https://bugs.webkit.org/show_bug.cgi?id=199593
1220
1221         Reviewed by Don Olmstead.
1222
1223         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for wincairo builder.
1224         * BuildSlaveSupport/ews-build/factories.py: Added required build steps for wincairo factory.
1225         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1226         (StatusBubble): Enable wincairo status-bubble.
1227
1228 2019-07-12  Aakash Jain  <aakash_jain@apple.com>
1229
1230         [ews-app] Enable logging for clicking SubmitToEWS button
1231         https://bugs.webkit.org/show_bug.cgi?id=199757
1232
1233         Unreviewed minor infrastructure fix.
1234
1235         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
1236         (SubmitToEWS.post): Change logging level from debug to info.
1237
1238 2019-07-12  Alex Christensen  <achristensen@webkit.org>
1239
1240         Enable client certificate authentication unit test
1241         https://bugs.webkit.org/show_bug.cgi?id=199735
1242
1243         Reviewed by Chris Dumez.
1244
1245         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1246         (TEST):
1247         I originally wrote this in https://bugs.webkit.org/show_bug.cgi?id=197800 but it was disabled because it crashed.
1248         I found what was crashing.  I was reading out of bounds on my vector of 2 strings :(
1249
1250 2019-07-12  Alex Christensen  <achristensen@webkit.org>
1251
1252         Begin unifying TestWebKitAPI build
1253         https://bugs.webkit.org/show_bug.cgi?id=199728
1254
1255         Reviewed by Keith Miller.
1256
1257         * TestWebKitAPI/Configurations/Base.xcconfig:
1258         * TestWebKitAPI/Scripts/generate-unified-sources.sh: Added.
1259         * TestWebKitAPI/Sources.txt: Added.
1260         * TestWebKitAPI/SourcesCocoa.txt: Added.
1261         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1262
1263 2019-07-12  Zhifei Fang  <zhifei_fang@apple.com>
1264
1265         run-javascriptcore-tests won't report test results for testmasm, testair, testb3, testdfg and test api
1266         https://bugs.webkit.org/show_bug.cgi?id=199489
1267         <rdar://problem/47891081>
1268
1269         Reviewed by Aakash Jain.
1270
1271         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1272         (RunJavaScriptCoreTests.countFailures):
1273         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1274         * Scripts/run-javascriptcore-tests:
1275         (runTest):
1276         (reportTestFailures):
1277         (runJSCStressTests):
1278
1279 2019-07-12  Aakash Jain  <aakash_jain@apple.com>
1280
1281         [ews-build] Make layout-tests' full_results.json accessible in Buildbot
1282         https://bugs.webkit.org/show_bug.cgi?id=199743
1283
1284         Reviewed by Jonathan Bedard.
1285
1286         * BuildSlaveSupport/ews-build/steps.py:
1287         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
1288
1289 2019-07-11  Aakash Jain  <aakash_jain@apple.com>
1290
1291         Unreviewed follow-up fix to r247364.
1292         [ews-build] Add build step to clean up .git/index.lock file
1293         https://bugs.webkit.org/show_bug.cgi?id=199722
1294
1295         * BuildSlaveSupport/ews-build/steps.py:
1296         (CheckOutSource): CheckOutSource should not haltOnFailure since CleanUpGitIndexLock step needs
1297         to be run after this step.
1298
1299 2019-07-11  Yusuke Suzuki  <ysuzuki@apple.com>
1300
1301         Flaky API Test TestWTF.bmalloc.ScavengedMemoryShouldBeReused
1302         https://bugs.webkit.org/show_bug.cgi?id=199524
1303         <rdar://problem/52783816>
1304
1305         Reviewed by Saam Barati.
1306
1307         This test is white-box one and it has strong assumption how IsoHeap allocates pages.
1308         But this test has several problems.
1309
1310         1. IsoPage::numObjects is not the exact number of how many we allocate objects. This
1311            number is calculated by pageSize / sizeof(T), and this does not account the header
1312            size of IsoPage. So, # of objects per IsoPage is less than numObjects. Since sizeof(double)
1313            is very small, we can have many objects in one IsoPage. As a result, we need a large
1314            bitmap in IsoPage. This reduces # of objects in IsoPage largely. So, `ptrs.size()` becomes
1315            less than numObjects.
1316
1317         2. We now have lower tier of allocation in IsoHeap. It means that we allocate 8 objects in
1318            shared page (page is shared, but memory is pinned for a specific type) before using IsoHeap's
1319            page. This also makes the intention of this test wrong.
1320
1321         Due to (1), we access OoB of ptrs vector, passing a garbage to IsoHeap::deallocate, and crashing.
1322
1323         We make this test robust while we still keep this test white-box one to test the critical feature
1324         of IsoHeap. We first exhaust lower tier of IsoHeap, and after that, start testing the memory. We
1325         allocate many pointers, deallocate them, allocate one pointer while keeping pointers in the lower
1326         tier live, and check whether the deallocated memory is reused.
1327
1328         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
1329         (TEST):
1330
1331 2019-07-11  Pablo Saavedra  <psaavedra@igalia.com>
1332
1333         [WPE][GTK] Build failure with ENABLE_ACCESSIBILITY=OFF
1334         https://bugs.webkit.org/show_bug.cgi?id=199625
1335
1336         Added ENABLE(ACCESSIBILITY) and replaced HAVE(ACCESSIBILITY)
1337         with ENABLE(ACCESSIBILITY) in the code.
1338
1339         Additionally, the TestRunner code generator now honors the
1340         Conditional IDL format.
1341
1342         Reviewed by Konstantin Tokarev.
1343
1344         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1345         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
1346         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
1347         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1348         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
1349         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl:
1350         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl:
1351         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1352         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1353         (_generateImplementationFile):
1354
1355 2019-07-11  Aakash Jain  <aakash_jain@apple.com>
1356
1357         [ews-build] Add build step to clean up .git/index.lock file
1358         https://bugs.webkit.org/show_bug.cgi?id=199722
1359
1360         Reviewed by Jonathan Bedard.
1361
1362         * BuildSlaveSupport/ews-build/steps.py:
1363         (CheckOutSource.getResultSummary): Run CleanUpGitIndexLock step when CheckOutSource fails.
1364         (CleanUpGitIndexLock.__init__): Configure timeout and logEnviron.
1365         (CleanUpGitIndexLock.evaluateCommand): Always RETRY the build after this step is run.
1366         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1367
1368 2019-07-11  Jonathan Bedard  <jbedard@apple.com>
1369
1370         [iOS 13] Enable WebKit build
1371         https://bugs.webkit.org/show_bug.cgi?id=199481
1372         <rdar://problem/52619048>
1373
1374         Reviewed by Tim Horton.
1375
1376         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Add iOS framework stubs.
1377
1378 2019-07-11  Ryan Haddad  <ryanhaddad@apple.com>
1379
1380         Add test expectations and baselines for iOS 13
1381         https://bugs.webkit.org/show_bug.cgi?id=199329
1382
1383         Reviewed by Jonathan Bedard.
1384
1385         * Scripts/webkitpy/port/ios.py:
1386         (IOSPort): Increment current version to 13.
1387         * Scripts/webkitpy/port/ios_device_unittest.py: Update unit tests.
1388         (IOSDeviceTest.test_layout_test_searchpath_with_apple_additions):
1389         (IOSDeviceTest.test_layout_test_searchpath_without_apple_additions):
1390         (IOSDeviceTest.test_layout_searchpath_wih_device_type):
1391         * Scripts/webkitpy/port/ios_simulator_unittest.py: Ditto.
1392         (IOSSimulatorTest.make_port):
1393         (IOSSimulatorTest.test_layout_test_searchpath_with_apple_additions):
1394         (IOSSimulatorTest.test_layout_test_searchpath_without_apple_additions):
1395         (IOSSimulatorTest.test_layout_searchpath_wih_device_type):
1396         * Scripts/webkitpy/port/ios_testcase.py: Ditto.
1397         (IOSTest.make_port):
1398
1399 2019-07-11  Joanmarie Diggs  <jdiggs@igalia.com>
1400
1401         AX: Implement support for ARIA roles insertion, deletion, subscript, superscript, and time
1402         https://bugs.webkit.org/show_bug.cgi?id=199692
1403
1404         Reviewed by Chris Fleizach.
1405
1406         Add support for output of AXDeletion and AXInsertion roles for tests.
1407         Update GTK and WPE jhbuild modules to use version of ATK and AT-SPI2
1408         which include ROLE_CONTENT_DELETION and ROLE_CONTENT_INSERTION.
1409
1410         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1411         * gtk/jhbuild.modules:
1412         * wpe/jhbuild.modules:
1413
1414 2019-07-11  Adrian Perez de Castro  <aperez@igalia.com>
1415
1416         [ews-build] Remove workers {ltilve,tanty}-gtk-wk2-ews from configuration
1417         https://bugs.webkit.org/show_bug.cgi?id=199707
1418
1419         Reviewed by Aakash Jain.
1420
1421         * BuildSlaveSupport/ews-build/config.json: Remove old unused workers.
1422
1423 2019-07-10  Simon Fraser  <simon.fraser@apple.com>
1424
1425         [iOS WK2] With modal overlay and body overflow:hidden, can't access all the content
1426         https://bugs.webkit.org/show_bug.cgi?id=199693
1427         rdar://problem/51930364
1428
1429         Reviewed by Tim Horton.
1430         
1431         New API tests that test scrollability with various combinations of content, insets,
1432         input accessory bars etc.
1433
1434         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1435         * TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm: Added.
1436         (TestWebKitAPI::webViewWithAutofocusedInput):
1437         (TestWebKitAPI::TEST):
1438
1439 2019-07-10  Tim Horton  <timothy_horton@apple.com>
1440
1441         Long pressing on attachments will crash the WebContent process
1442         https://bugs.webkit.org/show_bug.cgi?id=199696
1443         <rdar://problem/52920241>
1444
1445         Reviewed by Dean Jackson.
1446
1447         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
1448         (TestWebKitAPI::TEST):
1449         Add a test that previously crashed.
1450
1451 2019-07-10  Dean Jackson  <dino@apple.com>
1452
1453         Support MacCatalyst in run-webkit-app
1454         https://bugs.webkit.org/show_bug.cgi?id=199690
1455
1456         Reviewed by Tim Horton.
1457
1458         Add a --maccatalyst option to run-webkit-app that
1459         can launch MacCatalyst applications with a built WebKit.
1460
1461         * Scripts/webkitdirs.pm:
1462         (argumentsForConfiguration):
1463         (determineXcodeSDK):
1464         (xcodeSDKPlatformName):
1465         (determineConfigurationProductDir):
1466         (determinePortName):
1467         (isCatalystWebKit):
1468         (isAppleCocoaWebKit):
1469         (willUseCatalystSDK):
1470
1471 2019-07-10  Ryan Haddad  <ryanhaddad@apple.com>
1472
1473         [MacOS] Filter VPA info logged to stdout
1474         https://bugs.webkit.org/show_bug.cgi?id=199673
1475
1476         Reviewed by Eric Carlson.
1477
1478         * Scripts/webkitpy/port/mac.py:
1479         (MacPort.logging_patterns_to_strip):
1480
1481 2019-07-10  Ryan Haddad  <ryanhaddad@apple.com>
1482
1483         Unreviewed, rolling out r247286.
1484
1485         Caused TestWTF.WTF.StringOperators to fail on debug bots
1486
1487         Reverted changeset:
1488
1489         "Add StringBuilder member function which allows makeString()
1490         style variadic argument construction"
1491         https://bugs.webkit.org/show_bug.cgi?id=198997
1492         https://trac.webkit.org/changeset/247286
1493
1494 2019-07-10  Aakash Jain  <aakash_jain@apple.com>
1495
1496         [ews-build] Explicitly use perl or python while invoking scripts
1497         https://bugs.webkit.org/show_bug.cgi?id=199669
1498
1499         Reviewed by Jonathan Bedard.
1500
1501         * BuildSlaveSupport/ews-build/steps.py: Explicitly added perl or python while invoking scripts.
1502         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
1503
1504 2019-07-10  Guillaume Emont  <guijemont@igalia.com>
1505
1506         Run tests on mips EWS
1507         https://bugs.webkit.org/show_bug.cgi?id=196854
1508
1509         Reviewed by Carlos Garcia Campos.
1510
1511         * Scripts/webkitpy/common/config/ews.json:
1512
1513 2019-07-09  Michael Catanzaro  <mcatanzaro@igalia.com>
1514
1515         [WPE][GTK] GUniqueOutPtr::release should return a raw pointer
1516         https://bugs.webkit.org/show_bug.cgi?id=199579
1517
1518         Reviewed by Carlos Garcia Campos.
1519
1520         * TestWebKitAPI/Tests/WTF/glib/GUniquePtr.cpp:
1521         (TestWebKitAPI::TEST):
1522
1523 2019-07-09  Chris Dumez  <cdumez@apple.com>
1524
1525         Fix integer type encoding / decoding in WKRemoteObjectCoder
1526         https://bugs.webkit.org/show_bug.cgi?id=199643
1527         <rdar://problem/52732342>
1528
1529         Reviewed by Anders Carlsson.
1530
1531         Update API test coverage.
1532
1533         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
1534         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
1535         (TEST):
1536         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
1537         (-[RemoteObjectRegistryPlugIn takeUnsignedLongLong:completionHandler:]):
1538         (-[RemoteObjectRegistryPlugIn takeLongLong:completionHandler:]):
1539         (-[RemoteObjectRegistryPlugIn takeUnsignedLong:completionHandler:]):
1540         (-[RemoteObjectRegistryPlugIn takeLong:completionHandler:]):
1541
1542 2019-07-09  Sam Weinig  <weinig@apple.com>
1543
1544         Add StringBuilder member function which allows makeString() style variadic argument construction
1545         https://bugs.webkit.org/show_bug.cgi?id=198997
1546
1547         Reviewed by Darin Adler.
1548
1549         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1550         Add basic test showing that StringBuilder::flexibleAppend can be used to 
1551         append one or more string adaptable types. 
1552
1553 2019-07-09  Sihui Liu  <sihui_liu@apple.com>
1554
1555         Only allow fetching and removing session credentials from WebsiteDataStore
1556         https://bugs.webkit.org/show_bug.cgi?id=199385
1557         <rdar://problem/52622080>
1558
1559         Reviewed by Alex Christensen.
1560
1561         removeDataOfTypes will no longer remove persistent credentials. We should clear persistent credentials using
1562         the new SPI after each test that creates persistent credentials, otherwise the later tests may use credentials
1563         left by previous tests and didReceiveAuthenticationChallenge will not be invoked.
1564
1565         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1566         (TEST):
1567         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1568         (TestWebKitAPI::TEST):
1569
1570 2019-07-09  Alex Christensen  <achristensen@webkit.org>
1571
1572         When parsing an IPv4 address, wait until after deciding it is indeed an IPv4 address before reporting syntax violations
1573         https://bugs.webkit.org/show_bug.cgi?id=199628
1574
1575         Reviewed by Brady Eidson.
1576
1577         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
1578         (TestWebKitAPI::TEST_F):
1579
1580 2019-07-09  Alex Christensen  <achristensen@webkit.org>
1581
1582         Remove invalid assertion in URLParser::domainToASCII
1583         https://bugs.webkit.org/show_bug.cgi?id=199624
1584
1585         Reviewed by Brady Eidson.
1586
1587         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
1588         (TestWebKitAPI::TEST_F):
1589
1590 2019-07-09  Alex Christensen  <achristensen@webkit.org>
1591
1592         URLParser should reserialize IPv6 addresses that end with a colon
1593         https://bugs.webkit.org/show_bug.cgi?id=199627
1594
1595         Reviewed by Brady Eidson.
1596
1597         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
1598         (TestWebKitAPI::TEST_F):
1599
1600 2019-07-08  Aakash Jain  <aakash_jain@apple.com>
1601
1602         [ews-build] Do not run unix commands for windows in PrintConfiguration
1603         https://bugs.webkit.org/show_bug.cgi?id=199605
1604
1605         Reviewed by Jonathan Bedard.
1606
1607         * BuildSlaveSupport/ews-build/steps.py:
1608
1609 2019-07-08  Fujii Hironori  <Hironori.Fujii@sony.com>
1610
1611         JSTestGlobalObject.cpp of bindings-generation-tests is failing for Windows Python
1612         https://bugs.webkit.org/show_bug.cgi?id=199487
1613
1614         Reviewed by Ross Kirsling.
1615
1616         In Windows Python, preprocessor.pm is using cl.exe. cl.exe was
1617         failing to open testglobalscope_constructors_file which was
1618         created by using tempfile.mkstemp() because it keeps the file
1619         open. Use tempfile.mkdtemp() to create temporary files in the
1620         temporary directory instead of tempfile.mkstemp().
1621
1622         * Scripts/webkitpy/bindings/main.py:
1623         (BindingsTests.run_tests):
1624         (BindingsTests.main):
1625         (BindingsTests.close_and_remove): Deleted.
1626
1627 2019-07-08  Aakash Jain  <aakash_jain@apple.com>
1628
1629         [ews-build] Add KillOldProcesses step before running API or Layout tests
1630         https://bugs.webkit.org/show_bug.cgi?id=199592
1631
1632         Reviewed by Jonathan Bedard.
1633
1634         * BuildSlaveSupport/ews-build/factories.py:
1635
1636 2019-07-08  Jonathan Bedard  <jbedard@apple.com>
1637
1638         test-webkitpy: Explicitly use Python 2.7 lldb library
1639         https://bugs.webkit.org/show_bug.cgi?id=199578
1640         <rdar://problem/51853557>
1641
1642         Reviewed by Aakash Jain.
1643
1644         * Scripts/webkitpy/common/system/systemhost.py:
1645         (SystemHost.path_to_lldb_python_directory): Explicitly use Python 2.7 lldb libary.
1646         * Scripts/webkitpy/test/main.py:
1647         (_supports_building_and_running_lldb_tests): Run lldb tests on Catalina again.
1648
1649 2019-07-08  Ryan Haddad  <ryanhaddad@apple.com>
1650
1651         Add test expectations and baselines for Catalina
1652         https://bugs.webkit.org/show_bug.cgi?id=199328
1653
1654         Reviewed by Jonathan Bedard.
1655
1656         * Scripts/webkitpy/port/mac.py:
1657         (MacPort): Increment current version to 10.15 so that baseline search paths are correctly constructed for High Sierra.
1658
1659 2019-07-08  Christopher Reid  <chris.reid@sony.com>
1660
1661         Implement MappedFileData for Windows
1662         https://bugs.webkit.org/show_bug.cgi?id=198269
1663
1664         Reviewed by Darin Adler.
1665
1666         * TestWebKitAPI/PlatformWin.cmake:
1667
1668 2019-07-08  Charlie Turner  <cturner@igalia.com>
1669
1670         REGRESSION(r243197): [GStreamer] Web process hangs when scrolling twitter timeline which contains HLS videos
1671         https://bugs.webkit.org/show_bug.cgi?id=197558
1672
1673         Reviewed by Xabier Rodriguez-Calvar.
1674
1675         On shutdown we can easily deadlock the web process if we don't
1676         ensure all network operations are completed before comitting state
1677         changes. In HLS, make sure the network operations are cancelled,
1678         and also prevent hlsdemux's retry logic from scuppering our
1679         efforts.
1680
1681         * gstreamer/jhbuild.modules: Include the patch.
1682         * gstreamer/patches/gst-plugins-bad-do-not-retry-downloads-during-shutdown.patch: Added.
1683
1684 2019-07-08  Antoine Quint  <graouts@apple.com>
1685
1686         [Pointer Events] Enable only on the most recent version of the supported iOS family
1687         https://bugs.webkit.org/show_bug.cgi?id=199562
1688         <rdar://problem/52766511>
1689
1690         Reviewed by Dean Jackson.
1691
1692         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1693
1694 2019-07-06  Simon Fraser  <simon.fraser@apple.com>
1695
1696         Long hang when loading a cnn.com page on iOS
1697         https://bugs.webkit.org/show_bug.cgi?id=199556
1698
1699         Reviewed by Zalan Bujtas.
1700
1701         Add code to load a page by default in MobileMiniBrowser so it's easy to hack it
1702         to load a test page of your choice.
1703
1704         * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.m:
1705         (-[WebViewController viewDidLoad]):
1706
1707 2019-07-05  Ryosuke Niwa  <rniwa@webkit.org>
1708
1709         [iOS] Crash in WebKit::WebPage::positionInformation via Range::startPosition
1710         https://bugs.webkit.org/show_bug.cgi?id=199503
1711
1712         Reviewed by Wenson Hsieh.
1713
1714         Added UIScriptController.ensurePositionInformationIsUpToDateAt using the existing WKWebView SPI:
1715         _requestActivatedElementAtPosition
1716
1717         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1718         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
1719         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1720         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
1721         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1722         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1723         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
1724         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1725         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1726         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
1727         * WebKitTestRunner/ios/UIScriptControllerMac.mm:
1728         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
1729
1730 2019-07-05  Ryan Haddad  <ryanhaddad@apple.com>
1731
1732         Unreviewed, rolling out r247115.
1733
1734         Breaks lldbWebKitTester (and by extension, test-webkitpy)
1735
1736         Reverted changeset:
1737
1738         "[WHLSL] Standard library is too big to directly include in
1739         WebCore"
1740         https://bugs.webkit.org/show_bug.cgi?id=198186
1741         https://trac.webkit.org/changeset/247115
1742
1743 2019-07-05  Ryan Haddad  <ryanhaddad@apple.com>
1744
1745         Unreviewed, rolling out r247123.
1746
1747         Caused TestWebKitAPI.Challenge.BasicProposedCredential to
1748         fail.
1749
1750         Reverted changeset:
1751
1752         "Only allow fetching and removing session credentials from
1753         WebsiteDataStore"
1754         https://bugs.webkit.org/show_bug.cgi?id=199385
1755         https://trac.webkit.org/changeset/247123
1756
1757 2019-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1758
1759         Touching media controls sometimes shows software keyboard
1760         https://bugs.webkit.org/show_bug.cgi?id=199490
1761         <rdar://problem/52076270>
1762
1763         Reviewed by Eric Carlson.
1764
1765         Adds plumbing for a new testing hook to check whether or not there is an active input session. See other
1766         ChangeLog entries for more detail.
1767
1768         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1769         (WTR::UIScriptController::hasInputSession const):
1770         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1771         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1772         (WTR::UIScriptController::hasInputSession const):
1773         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1774         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1775         (WTR::UIScriptController::hasInputSession const):
1776
1777 2019-07-04  Aakash Jain  <aakash_jain@apple.com>
1778
1779         [ews-build] Remove GTK and WPE queue from old EWS and dashboard
1780         https://bugs.webkit.org/show_bug.cgi?id=199458
1781
1782         Reviewed by Michael Catanzaro.
1783
1784         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1785         * QueueStatusServer/config/queues.py:
1786
1787 2019-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1788
1789         [GTK] Fix browserperfdash script after r239522
1790         https://bugs.webkit.org/show_bug.cgi?id=199496
1791
1792         Reviewed by Michael Catanzaro.
1793
1794         * Scripts/webkitpy/browserperfdash/browserperfdash_runner.py:
1795         (BrowserPerfDashRunner.run): Pass None for the new required BenchmarkRunner constructor.
1796
1797 2019-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1798
1799         [webkitpy] test-webkitpy is broken on Linux since r246662
1800         https://bugs.webkit.org/show_bug.cgi?id=199493
1801
1802         Reviewed by Michael Catanzaro.
1803
1804         * Scripts/webkitpy/test/main.py:
1805         (_supports_building_and_running_lldb_tests): Add a check for None before calling startswith().
1806
1807 2019-07-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1808
1809         [GTK][WPE] Not longer needed to build woff2 on the JHBuild
1810         https://bugs.webkit.org/show_bug.cgi?id=199406
1811
1812         Reviewed by Michael Catanzaro.
1813
1814         Install the Woff2 libraries and headers from the system package
1815         and stop building them on the JHBuild.
1816
1817         * gtk/install-dependencies:
1818         * gtk/jhbuild.modules:
1819         * wpe/install-dependencies:
1820         * wpe/jhbuild.modules:
1821
1822 2019-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1823
1824         [GTK][WPE][CMake] The CMake cache should be clean when the JHBuild is rebuilt
1825         https://bugs.webkit.org/show_bug.cgi?id=199449
1826
1827         Reviewed by Michael Catanzaro.
1828
1829         * Scripts/webkitdirs.pm:
1830         (shouldRemoveCMakeCache): Clean the CMake cache if we detect that the JHBuild has been rebuilt.
1831
1832 2019-07-01  Philippe Normand  <pnormand@igalia.com>
1833
1834         Unreviewed, GTK a11y tests fix after r247071
1835
1836         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1837         (WTR::AccessibilityUIElement::popupValue const):
1838
1839 2019-07-03  Aakash Jain  <aakash_jain@apple.com>
1840
1841         [ews-build] Enable WPE and GTK queues on new EWS
1842         https://bugs.webkit.org/show_bug.cgi?id=199234
1843
1844         Reviewed by Jonathan Bedard.
1845
1846         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for GTK and WPE builders.
1847         * BuildSlaveSupport/ews-build/factories.py: Added required build steps for GTKFactory and WPEFactory.
1848         * BuildSlaveSupport/ews-build/steps.py:
1849         (CompileWebKit.evaluateCommand): Added InstallGtkDependencies/InstallWpeDependencies step before Compiling WebKit without patch.
1850         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1851         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1852         (StatusBubble): Enable gtk and wpe status-bubbles.
1853
1854 2019-07-03  Sihui Liu  <sihui_liu@apple.com>
1855
1856         Only allow fetching and removing session credentials from WebsiteDataStore
1857         https://bugs.webkit.org/show_bug.cgi?id=199385
1858
1859         Reviewed by Alex Christensen.
1860
1861         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1862         (TestWebKitAPI::TEST):
1863
1864 2019-07-03  Tim Horton  <timothy_horton@apple.com>
1865
1866         UI process exception when dragging an <attachment> with no content type
1867         https://bugs.webkit.org/show_bug.cgi?id=199480
1868         <rdar://problem/44351353>
1869
1870         Reviewed by Wenson Hsieh.
1871
1872         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1873         (TestWebKitAPI::TEST):
1874         Add a test; before the change, it crashes.
1875
1876 2019-07-03  Jonathan Bedard  <jbedard@apple.com>
1877
1878         [Catalina] Enable WebKit build
1879         https://bugs.webkit.org/show_bug.cgi?id=199209
1880
1881         Reviewed by Darin Adler.
1882
1883         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Add Mac framework stubs.
1884
1885 2019-07-03  Sam Weinig  <weinig@apple.com>
1886
1887         Adopt simple structured bindings in more places
1888         https://bugs.webkit.org/show_bug.cgi?id=199247
1889
1890         Reviewed by Alex Christensen.
1891
1892         Replaces simple uses of std::tie() with structured bindings. Does not touch
1893         uses of std::tie() that are not initial declarations, use std::ignore or in
1894         case where the binding is captured by a lambda, as structured bindings don't
1895         work for those cases yet.
1896
1897         * TestWebKitAPI/ios/PreferredContentMode.mm:
1898         (TestWebKitAPI::TEST):
1899
1900 2019-07-03  Aakash Jain  <aakash_jain@apple.com>
1901
1902         Unreviewed follow-up fix to r247049, default the platform to '*' when platform property is not set.
1903
1904         * BuildSlaveSupport/ews-build/steps.py:
1905         (PrintConfiguration.run):
1906
1907 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
1908
1909         [ews-build] Add build steps to Install Wpe and Gtk dependencies
1910         https://bugs.webkit.org/show_bug.cgi?id=199408
1911
1912         Reviewed by Michael Catanzaro.
1913
1914         * BuildSlaveSupport/ews-build/steps.py:
1915         (InstallGtkDependencies): Build step to install dependencies for GTK. Set haltOnFailure=False so that in case of failure, build isn't
1916         marked as failed (which would indicated patch failed EWS), instead subsequent steps would be run and the build would be marked as RETRY.
1917         (InstallWpeDependencies): Ditto for WPE.
1918         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1919
1920 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
1921
1922         [ews-build] Allow skipping uploading built product for few builders
1923         https://bugs.webkit.org/show_bug.cgi?id=199422
1924
1925         Reviewed by Michael Catanzaro.
1926
1927         * BuildSlaveSupport/ews-build/steps.py:
1928         (CompileWebKit.__init__): Added optional skipUpload parameter.
1929         (CompileWebKit.evaluateCommand): Allow to skip upload if there are no triggers and skipUpload is True.
1930
1931 2019-07-02  Tim Horton  <timothy_horton@apple.com>
1932
1933         REGRESSION (r243240): Unable to swipe back in Safari
1934         https://bugs.webkit.org/show_bug.cgi?id=199394
1935         <rdar://problem/51137447>
1936
1937         Reviewed by Wenson Hsieh.
1938
1939         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1940         Make sure that we actually end up with swipe gesture recognizers installed
1941         after process swap and crash.
1942
1943 2019-07-02  Andres Gonzalez  <andresg_22@apple.com>
1944
1945         Enhance support of aria-haspopup per ARIA 1.1 specification.
1946         https://bugs.webkit.org/show_bug.cgi?id=199216
1947         <rdar://problem/46221342>
1948
1949         Reviewed by Chris Fleizach.
1950
1951         * DumpRenderTree/AccessibilityUIElement.cpp:
1952         (getPopupValueCallback):
1953         (AccessibilityUIElement::getJSClass):
1954         * DumpRenderTree/AccessibilityUIElement.h:
1955         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1956         (AccessibilityUIElement::popupValue const):
1957         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1958         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1959         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1960         (WTR::AccessibilityUIElement::popupValue const):
1961         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1962         (WTR::AccessibilityUIElement::popupValue const):
1963
1964 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
1965
1966         [ews-build] Do not print worker environment variables in each build step [part 2]
1967         https://bugs.webkit.org/show_bug.cgi?id=199405
1968
1969         Reviewed by Jonathan Bedard.
1970
1971         * BuildSlaveSupport/ews-build/steps.py:
1972         (CheckOutSpecificRevision.__init__): Disabled logging of environment variables.
1973         (CleanWorkingDirectory.__init__): Ditto.
1974         (RunBindingsTests.__init__): Ditto.
1975         (RunWebKitPerlTests.__init__): Ditto.
1976         (RunWebKitPyTests.__init__): Ditto.
1977         (CompileWebKit.__init__): Ditto.
1978         (ArchiveTestResults.__init__): Ditto.
1979         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
1980
1981 2019-07-02  Jer Noble  <jer.noble@apple.com>
1982
1983         Pipe suport for 'cenc' init data type into CDMFairPlayStreaming
1984         https://bugs.webkit.org/show_bug.cgi?id=199381
1985         <rdar://problem/52483103>
1986
1987         Reviewed by Eric Carlson.
1988
1989         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
1990
1991 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
1992
1993         [ews-build] Update bot configuration for WPE and GTK
1994         https://bugs.webkit.org/show_bug.cgi?id=199238
1995
1996         Reviewed by Michael Catanzaro.
1997
1998         * BuildSlaveSupport/ews-build/config.json:
1999
2000 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
2001
2002         [ews-build] Make PrintConfiguration platform aware
2003         https://bugs.webkit.org/show_bug.cgi?id=196657
2004
2005         Reviewed by Lucas Forschler.
2006
2007         * BuildSlaveSupport/ews-build/steps.py:
2008         (PrintConfiguration): Specified platform-specific command lists.
2009         (PrintConfiguration.run): Override run method and specify platform specific commands.
2010         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2011
2012 2019-07-01  Justin Michaud  <justin_michaud@apple.com>
2013
2014         [Wasm-References] Disable references by default
2015         https://bugs.webkit.org/show_bug.cgi?id=199390
2016
2017         Reviewed by Saam Barati.
2018
2019         * Scripts/run-jsc-stress-tests:
2020
2021 2019-07-01  Joonghun Park  <pjh0718@gmail.com>
2022
2023         Unreviewed. Revert r246965 to fix build break
2024         since r247019 reverted its related changes.
2025
2026         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2027         (WTR::AccessibilityUIElement::popupValue const): Deleted.
2028
2029 2019-07-01  Alex Christensen  <achristensen@webkit.org>
2030
2031         Add new decidePolicyForNavigationAction SPI with preferences and userInfo
2032         https://bugs.webkit.org/show_bug.cgi?id=199371
2033         <rdar://problem/52352905>
2034
2035         Reviewed by Tim Horton.
2036
2037         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
2038         (-[NavigationActionSPIDelegate webView:didFinishNavigation:]):
2039         (-[NavigationActionSPIDelegate _webView:decidePolicyForNavigationAction:preferences:userInfo:decisionHandler:]):
2040         (-[NavigationActionSPIDelegate spiCalled]):
2041         (TEST):
2042
2043 2019-07-01  Alex Christensen  <achristensen@webkit.org>
2044
2045         Deprecate _webView:showCustomSheetForElement: after transition to UIContextMenuInteraction
2046         https://bugs.webkit.org/show_bug.cgi?id=199296
2047         <rdar://problem/51041960>
2048
2049         Reviewed by Darin Adler.
2050
2051         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2052         (-[DragAndDropSimulator _webView:showCustomSheetForElement:]):
2053
2054 2019-07-01  Truitt Savell  <tsavell@apple.com>
2055
2056         Unreviewed, rolling out r246958.
2057
2058         Broke inspector/dom/getAccessibilityPropertiesForNode.html
2059
2060         Reverted changeset:
2061
2062         "Enhance support of aria-haspopup per ARIA 1.1 specification."
2063         https://bugs.webkit.org/show_bug.cgi?id=199216
2064         https://trac.webkit.org/changeset/246958
2065
2066 2019-07-01  Philippe Normand  <pnormand@igalia.com>
2067
2068         Unreviewed, GTK a11y tests fix after r246958
2069
2070         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2071         (WTR::AccessibilityUIElement::popupValue const):
2072
2073 2019-06-30  Andres Gonzalez  <andresg_22@apple.com>
2074
2075         Enhance support of aria-haspopup per ARIA 1.1 specification.
2076         https://bugs.webkit.org/show_bug.cgi?id=199216
2077         <rdar://problem/46221342>
2078
2079         Reviewed by Chris Fleizach.
2080
2081         * DumpRenderTree/AccessibilityUIElement.cpp:
2082         (getPopupValueCallback):
2083         (AccessibilityUIElement::getJSClass):
2084         * DumpRenderTree/AccessibilityUIElement.h:
2085         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2086         (AccessibilityUIElement::popupValue const):
2087         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2088         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2089         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2090         (WTR::AccessibilityUIElement::popupValue const):
2091         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2092         (WTR::AccessibilityUIElement::popupValue const):
2093
2094 2019-06-28  Robin Morisset  <rmorisset@apple.com>
2095
2096         Adding myself as a reviewer to contributors.json.
2097
2098         Unreviewed.
2099
2100         * Scripts/webkitpy/common/config/contributors.json:
2101
2102 2019-06-28  Jer Noble  <jer.noble@apple.com>
2103
2104         Add new -[WKWebView _closeAllMediaPresentations] SPI
2105         https://bugs.webkit.org/show_bug.cgi?id=199294
2106         <rdar://problem/51965958>
2107
2108         Reviewed by Alex Christensen.
2109
2110         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2111         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm: Added.
2112         (TEST):
2113
2114 2019-06-28  Sihui Liu  <sihui_liu@apple.com>
2115
2116         Add a regression test for change r246901
2117         https://bugs.webkit.org/show_bug.cgi?id=199290
2118
2119         Reviewed by Geoffrey Garen.
2120
2121         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2122         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
2123         (-[LocalStorageNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2124         (TEST):
2125         * TestWebKitAPI/Tests/WebKitCocoa/localstorage-open-window-private.html: Added.
2126
2127 2019-06-28  Konstantin Tokarev  <annulen@yandex.ru>
2128
2129         Remove traces of ENABLE_ICONDATABASE remaining after its removal in 219733
2130         https://bugs.webkit.org/show_bug.cgi?id=199317
2131
2132         Reviewed by Michael Catanzaro.
2133
2134         While IconDatabase and all code using it was removed,
2135         ENABLE_ICONDATABASE still exists as build option and C++ macro.
2136
2137         * Scripts/webkitperl/FeatureList.pm:
2138         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2139         * gtk/manifest.txt.in: Remove reference to unused urlIcon.png file.
2140         * wpe/manifest.txt.in: Remove reference to unused urlIcon.png file.
2141
2142 2019-06-28  Wenson Hsieh  <wenson_hsieh@apple.com>
2143
2144         -[WKContentView _selectionClipRects] returns a bogus value in -reloadInputViews when focusing an element
2145         https://bugs.webkit.org/show_bug.cgi?id=199310
2146         <rdar://problem/52292137>
2147
2148         Reviewed by Megan Gardner.
2149
2150         Add a new API test to verify that _selectionClipRects returns the correct value when invoked under the scope of
2151         _elementDidFocus.
2152
2153         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2154         (TestWebKitAPI::TEST):
2155         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
2156         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
2157         (-[TestInputDelegate setDidStartInputSessionHandler:]):
2158         (-[TestInputDelegate didStartInputSessionHandler]):
2159
2160         Add plumbing for a handler block in TestInputDelegate.
2161
2162         (-[TestInputDelegate setWillStartInputSessionHandler:]):
2163
2164         Drive-by style fixes to add a space between id and < for Objective-C protocols.
2165
2166         (-[TestInputDelegate willStartInputSessionHandler]):
2167         (-[TestInputDelegate _webView:willStartInputSession:]):
2168         (-[TestInputDelegate _webView:didStartInputSession:]):
2169         * TestWebKitAPI/cocoa/TestWKWebView.h:
2170         * TestWebKitAPI/ios/UIKitSPI.h:
2171
2172         Add a declaration for _selectionClipRects.
2173
2174 2019-06-27  Zalan Bujtas  <zalan@apple.com>
2175
2176         REGRESSION(r244633): e-mail with "height: 100%" causes unstable layout.
2177         https://bugs.webkit.org/show_bug.cgi?id=199303
2178         <rdar://problem/51340927>
2179
2180         Reviewed by Tim Horton.
2181
2182         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
2183         (TEST):
2184
2185 2019-06-27  Beth Dakin  <bdakin@apple.com>
2186
2187         Upstream use of MACCATALYST
2188         https://bugs.webkit.org/show_bug.cgi?id=199245
2189         rdar://problem/51687723
2190
2191         Reviewed by Tim Horton.
2192
2193         * ContentExtensionTester/Configurations/SDKVariant.xcconfig:
2194         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig:
2195         * ImageDiff/cg/Configurations/SDKVariant.xcconfig:
2196         * MiniBrowser/Configurations/SDKVariant.xcconfig:
2197         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig:
2198         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
2199         (JavaScriptCoreGenerator):
2200         (WebCoreGenerator):
2201         (WebKitGenerator):
2202         * TestWebKitAPI/Configurations/Base.xcconfig:
2203         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2204         * TestWebKitAPI/Configurations/SDKVariant.xcconfig:
2205         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2206         * WebEditingTester/Configurations/SDKVariant.xcconfig:
2207         * WebKitLauncher/Configurations/SDKVariant.xcconfig:
2208         * WebKitTestRunner/Configurations/SDKVariant.xcconfig:
2209         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig:
2210
2211 2019-06-27  Saam Barati  <sbarati@apple.com>
2212
2213         Make WEBGPU enabled only on Mojave and later.
2214
2215         Rubber-stamped by Myles C. Maxfield.
2216
2217         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2218
2219 2019-06-27  Aakash Jain  <aakash_jain@apple.com>
2220
2221         [ews-build] Do not print worker environment variables in each build step
2222         https://bugs.webkit.org/show_bug.cgi?id=197319
2223
2224         Reviewed by Lucas Forschler.
2225
2226         * BuildSlaveSupport/ews-build/steps.py:
2227         (CheckOutSource.__init__): Disabled logging of environment variables.
2228         (ApplyPatch.__init__): Ditto.
2229         (KillOldProcesses.__init__): Ditto.
2230         (ArchiveBuiltProduct.__init__): Ditto.
2231         (DownloadBuiltProduct.__init__): Ditto.
2232         (ExtractBuiltProduct.__init__): Ditto.
2233         (RunAPITests.__init__): Ditto.
2234         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
2235
2236 2019-06-26  Jiewen Tan  <jiewen_tan@apple.com>
2237
2238         SubFrameSOAuthorizationSession should preserve the referrer header when fall back to web path
2239         https://bugs.webkit.org/show_bug.cgi?id=199232
2240         <rdar://problem/51718328>
2241
2242         Reviewed by Youenn Fablet.
2243
2244         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
2245         (TestWebKitAPI::TEST):
2246         Add a test that utilizes TCPServer as local files always omit referrer.
2247
2248 2019-06-26  Aakash Jain  <aakash_jain@apple.com>
2249
2250         [ews-build] Add configuration and architecture for WPE and GTK builders
2251         https://bugs.webkit.org/show_bug.cgi?id=199249
2252
2253         Reviewed by Jonathan Bedard.
2254
2255         * BuildSlaveSupport/ews-build/config.json:
2256
2257 2019-06-26  Aakash Jain  <aakash_jain@apple.com>
2258
2259         [ews-build] Add check for duplicate workers in config.json
2260         https://bugs.webkit.org/show_bug.cgi?id=199240
2261
2262         Reviewed by Jonathan Bedard.
2263
2264         * BuildSlaveSupport/ews-build/loadConfig.py:
2265         (checkWorkersAndBuildersForConsistency._find_worker_with_name): Check for duplicate worker entry.
2266         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2267         (TestcheckWorkersAndBuildersForConsistency.test_duplicate_worker): Added unit-test.
2268
2269 2019-06-26  Ross Kirsling  <ross.kirsling@sony.com>
2270
2271         [Win] MiniBrowser should make better font choices
2272         https://bugs.webkit.org/show_bug.cgi?id=199244
2273
2274         Reviewed by Brent Fulgham.
2275
2276         * MiniBrowser/win/MainWindow.cpp:
2277         (MainWindow::updateDeviceScaleFactor):
2278         * MiniBrowser/win/MiniBrowserLib.rc:
2279
2280 2019-06-26  Alex Christensen  <achristensen@webkit.org>
2281
2282         testRunner.setAlwaysAcceptCookies should wait for cookie accept policy to be set
2283         https://bugs.webkit.org/show_bug.cgi?id=199230
2284         <rdar://51757107>
2285
2286         Reviewed by Andy Estes.
2287
2288         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp:
2289         (TestWebKitAPI::didGetTestHTTPCookieAcceptPolicy):
2290         (TestWebKitAPI::didGetUserHTTPCookieAcceptPolicy):
2291         * WebKitTestRunner/TestController.cpp:
2292         (WTR::TestController::generatePageConfiguration):
2293         (WTR::TestController::createWebViewWithOptions):
2294         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundleWithListener):
2295         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundleWithListener):
2296         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2297         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundle): Deleted.
2298         * WebKitTestRunner/TestController.h:
2299         * WebKitTestRunner/TestInvocation.cpp:
2300         (WTR::TestInvocation::invoke):
2301         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2302
2303 2019-06-26  Ross Kirsling  <ross.kirsling@sony.com>
2304
2305         [Win][MiniBrowser] Remove obsolete code after r246814.
2306         https://bugs.webkit.org/show_bug.cgi?id=199233
2307
2308         Reviewed by Fujii Hironori.
2309
2310         * MiniBrowser/win/MiniBrowserWebHost.cpp:
2311         (MiniBrowserWebHost::didFinishLoadForFrame):
2312         (SimpleEventListener::SimpleEventListener): Deleted.
2313         (SimpleEventListener::handleEvent): Deleted.
2314
2315 2019-06-25  Jiewen Tan  <jiewen_tan@apple.com>
2316
2317         Implement a new SPI to inform clients about AppSSO
2318         https://bugs.webkit.org/show_bug.cgi?id=199085
2319         <rdar://problem/50028246>
2320
2321         Reviewed by Geoffrey Garen.
2322
2323         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
2324         (-[TestSOAuthorizationBasicDelegate webView:didFinishNavigation:]):
2325         (-[TestSOAuthorizationNavigationDelegate init]):
2326         (-[TestSOAuthorizationNavigationDelegate _webView:decidePolicyForSOAuthorizationLoadWithCurrentPolicy:forExtension:completionHandler:]):
2327         (TestWebKitAPI::TEST):
2328
2329 2019-06-25  Aakash Jain  <aakash_jain@apple.com>
2330
2331         [ews-build] Retry Layout test in case of failures
2332         https://bugs.webkit.org/show_bug.cgi?id=199194
2333
2334         Reviewed by Jonathan Bedard.
2335
2336         * BuildSlaveSupport/ews-build/steps.py:
2337         (RunWebKitTests.evaluateCommand): Check if tests failed and retry them if required.
2338         (ReRunWebKitTests): Build step to re-run layout tests.
2339         (ReRunWebKitTests.evaluateCommand): Check if tests failed and retry on clean build if required.
2340         (RunWebKitTestsWithoutPatch): Build step to run tests without patch.
2341         (RunWebKitTestsWithoutPatch.evaluateCommand):
2342
2343 2019-06-25  Aakash Jain  <aakash_jain@apple.com>
2344
2345         [ews-build] Combine various patchFailed*Tests properties
2346         https://bugs.webkit.org/show_bug.cgi?id=199193
2347
2348         Reviewed by Jonathan Bedard.
2349
2350         * BuildSlaveSupport/ews-build/steps.py: Renamed patchFailedJSCTests and patchFailedAPITests to patchFailedTests. This property 
2351         can also be used for layout-tests later on.
2352         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
2353
2354 2019-06-25  Ross Kirsling  <ross.kirsling@sony.com>
2355
2356         [Win] MiniBrowser should default to webkit.org
2357         https://bugs.webkit.org/show_bug.cgi?id=199201
2358
2359         Reviewed by Don Olmstead.
2360
2361         * MiniBrowser/win/BrowserWindow.h:
2362         * MiniBrowser/win/MiniBrowserReplace.h:
2363         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2364         (WebKitBrowserWindow::loadHTMLString): Deleted.
2365         * MiniBrowser/win/WebKitBrowserWindow.h:
2366         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
2367         (WebKitLegacyBrowserWindow::loadHTMLString): Deleted.
2368         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
2369         * MiniBrowser/win/WinMain.cpp:
2370         (wWinMain):
2371
2372 2019-06-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2373
2374         [iOS] Occasional crash under -[UIPreviewTarget initWithContainer:center:transform:] when generating a drag preview
2375         https://bugs.webkit.org/show_bug.cgi?id=199192
2376         <rdar://problem/51554509>
2377
2378         Reviewed by Tim Horton.
2379
2380         Tweak the drag and drop simulator to ask for drag cancellation previews, and use this to write a couple tests to
2381         verify that we gracefully handle web process termination and web view unparenting mid-drag.
2382
2383         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2384         (TestWebKitAPI::TEST):
2385         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2386         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2387         (-[DragAndDropSimulator _resetSimulatedState]):
2388         (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
2389         (-[DragAndDropSimulator _advanceProgress]):
2390         (-[DragAndDropSimulator liftPreviews]):
2391         (-[DragAndDropSimulator cancellationPreviews]):
2392         (-[DragAndDropSimulator setSessionWillBeginBlock:]):
2393         (-[DragAndDropSimulator sessionWillBeginBlock]):
2394         (-[DragAndDropSimulator _webView:dataInteraction:sessionWillBegin:]):
2395
2396 2019-06-25  Aakash Jain  <aakash_jain@apple.com>
2397
2398         [ews-build] UploadTestResults and ExtractTestResults clobber results in case of multiple layout test runs in a build
2399         https://bugs.webkit.org/show_bug.cgi?id=199178
2400
2401         Reviewed by Jonathan Bedard.
2402
2403         * BuildSlaveSupport/ews-build/steps.py:
2404         (UploadTestResults.__init__): Add an optional identifier and append the identifier to the file name.
2405         (ExtractTestResults.__init__): Ditto.
2406         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit tests.
2407
2408 2019-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
2409
2410         Add user agent quirk for bankofamerica.com
2411         https://bugs.webkit.org/show_bug.cgi?id=199154
2412
2413         Reviewed by Carlos Garcia Campos.
2414
2415         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2416         (TestWebKitAPI::TEST):
2417
2418 2019-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
2419
2420         Fully rename WebKitGTK+ -> WebKitGTK everywhere
2421         https://bugs.webkit.org/show_bug.cgi?id=199159
2422
2423         Reviewed by Carlos Garcia Campos.
2424
2425         * BuildSlaveSupport/gtk/README:
2426         * MiniBrowser/gtk/BrowserWindow.c:
2427         * MiniBrowser/gtk/main.c:
2428         (aboutURISchemeRequestCallback):
2429         * Scripts/webkitpy/common/config/contributionareas.py:
2430         * Scripts/webkitpy/common/config/contributors.json:
2431         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py:
2432         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2433         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
2434         (testWebViewResources):
2435         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2436         (testWebViewMouseTarget):
2437         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
2438         (testWebExtensionGetTitle):
2439         (testDocumentLoadedSignal):
2440         (testWebExtensionFormControlsAssociated):
2441         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2442         (testWebKitSettingsUserAgent):
2443         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2444         (testWebViewRunJavaScript):
2445         * TestWebKitAPI/Tests/WebKitGtk/InspectorTestServer.cpp:
2446         (main):
2447         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
2448         (prepareContextMenuTestView):
2449         (testContextMenuPopulateMenu):
2450         (testContextMenuCustomMenu):
2451         (testContextMenuDisableMenu):
2452         (testContextMenuSubMenu):
2453         (testContextMenuDismissed):
2454         (testContextMenuWebExtensionMenu):
2455         (testContextMenuWebExtensionNode):
2456         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
2457         (testInspectorDefault):
2458         (testInspectorManualAttachDetach):
2459         (testInspectorCustomContainerDestroyed):
2460         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
2461         (testWebViewPrint):
2462         (testPrintOperationPrint):
2463         (testPrintOperationErrors):
2464         * gtk/install-dependencies:
2465         * gtk/jhbuild.modules:
2466         * gtkdoc/generate-gtkdoc:
2467         * wpe/install-dependencies:
2468
2469 2019-06-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2470
2471         contributors.json not canonicalized since r243297
2472         https://bugs.webkit.org/show_bug.cgi?id=199161
2473
2474         Reviewed by Alexey Proskuryakov.
2475
2476         Canonicalize it using 'validate-committer-lists --canonicalize'
2477
2478         * Scripts/webkitpy/common/config/contributors.json:
2479
2480 2019-06-24  Jonathan Bedard  <jbedard@apple.com>
2481
2482         webkitpy: Build style should be lower-case
2483         https://bugs.webkit.org/show_bug.cgi?id=199158
2484
2485         Reviewed by Aakash Jain.
2486
2487         * Scripts/webkitpy/test/main.py:
2488         (Tester._run_tests): Make all styles lower-case.
2489
2490 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
2491
2492         [ews-build] Remove iOS queue from old EWS and dashboard
2493         https://bugs.webkit.org/show_bug.cgi?id=199150
2494
2495         Reviewed by Jonathan Bedard.
2496
2497         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2498         * QueueStatusServer/config/queues.py:
2499
2500 2019-06-21  Ryan Haddad  <ryanhaddad@apple.com>
2501
2502         API Test [Mojave+ WK2 Debug ] TestWebKitAPI.WKAttachmentTestsMac.InsertDroppedFilePromisesAsAttachments is a flaky crash
2503         https://bugs.webkit.org/show_bug.cgi?id=198795
2504
2505         Unreviewed test gardening.
2506
2507         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2508         (TestWebKitAPI::TEST): Disable flaky test.
2509
2510 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
2511
2512         [ews-build] Enable iOS-12-Build queue on new EWS
2513         https://bugs.webkit.org/show_bug.cgi?id=199149
2514
2515         Reviewed by Jonathan Bedard.
2516
2517         * BuildSlaveSupport/ews-build/config.json: Enable iOS-12-Build-EWS trigger. Also temporarily share ews152 and ews154 with
2518         this queue.
2519         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2520         (StatusBubble): Enable ios status-bubble. Also display the ios bubble first (left). Going forward
2521         will keep the builders to the left and testers to the right.
2522
2523 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
2524
2525         [ews-build] Upload test results after running layout-tests
2526         https://bugs.webkit.org/show_bug.cgi?id=199120
2527
2528         Reviewed by Jonathan Bedard.
2529
2530         * BuildSlaveSupport/ews-build/steps.py:
2531         (RunWebKitTests.evaluateCommand):
2532         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2533
2534 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
2535
2536         [ews-build] EWS should provide option to download layout test results zip file
2537         https://bugs.webkit.org/show_bug.cgi?id=199121
2538
2539         Reviewed by Jonathan Bedard.
2540
2541         * BuildSlaveSupport/ews-build/steps.py:
2542         (ExtractTestResults.resultsDownloadURL): Method to return layout test result zip file url. 
2543         (ExtractTestResults.addCustomURLs): Add url to download layout test results zip file.
2544
2545 2019-06-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2546
2547         Add user agent quirk for Google Drive
2548         https://bugs.webkit.org/show_bug.cgi?id=199153
2549
2550         Reviewed by Carlos Garcia Campos.
2551
2552         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2553         (TestWebKitAPI::TEST):
2554
2555 2019-06-22  Zalan Bujtas  <zalan@apple.com>
2556
2557         [LFC] Expand tests coverage (328 new tests -> 2652).
2558
2559         * LayoutReloaded/misc/LFC-passing-tests.txt:
2560
2561 2019-06-22  Andres Gonzalez  <andresg_22@apple.com>
2562
2563         Accessibility objects contained in links should honor the aria-haspopup attribute in the ancestor link.
2564         https://bugs.webkit.org/show_bug.cgi?id=199107
2565         <rdar://problem/43663611>
2566
2567         Reviewed by Chris Fleizach.
2568
2569         iOS implementation for AccessibilityUIElement::hasPopup.
2570         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2571         (WTR::AccessibilityUIElement::hasPopup const):
2572
2573 2019-06-22  Konstantin Tokarev  <annulen@yandex.ru>
2574
2575         Unreviewed, add myself to CMake watchlist
2576
2577         * Scripts/webkitpy/common/config/watchlist:
2578
2579 2019-06-21  Sihui Liu  <sihui_liu@apple.com>
2580
2581         openDatabase should return an empty object when WebSQL is disabled
2582         https://bugs.webkit.org/show_bug.cgi?id=198805
2583
2584         Reviewed by Geoffrey Garen.
2585
2586         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2587         * TestWebKitAPI/Tests/WebKitCocoa/WebSQLBasics.mm: Added.
2588         (-[WebSQLBasicsMessageHandler userContentController:didReceiveScriptMessage:]):
2589         (TEST):
2590         * TestWebKitAPI/Tests/WebKitCocoa/opendatabase-always-exists.html: Added.
2591
2592 2019-06-21  Jiewen Tan  <jiewen_tan@apple.com>
2593
2594         WebPageProxy::loadData should accept ShouldOpenExternalURLsPolicy
2595         https://bugs.webkit.org/show_bug.cgi?id=199114
2596         <rdar://problem/51671674>
2597
2598         Reviewed by Youenn Fablet.
2599
2600         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
2601         (-[TestSOAuthorizationNavigationDelegate init]):
2602         (-[TestSOAuthorizationNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2603         (configureSOAuthorizationWebView):
2604         (TestWebKitAPI::TEST):
2605
2606 2019-06-21  Youenn Fablet  <youenn@apple.com>
2607
2608         WebPageProxy should use the right path for sandbox extension
2609         https://bugs.webkit.org/show_bug.cgi?id=198902
2610         <rdar://problem/50772810>
2611
2612         Reviewed by Geoffrey Garen.
2613
2614         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
2615         (TEST):
2616         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2617
2618 2019-06-21  Michael Catanzaro  <mcatanzaro@igalia.com>
2619
2620         [WPE][GTK] Bump minimum versions of GLib, GTK, libsoup, ATK, GStreamer, and Cairo
2621         https://bugs.webkit.org/show_bug.cgi?id=199094
2622
2623         Reviewed by Carlos Garcia Campos.
2624
2625         * MiniBrowser/gtk/BrowserTab.c:
2626         (runColorChooserCallback):
2627         (browserTabConstructed):
2628         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
2629         (testWebViewSyncRequestOnMaxConns):
2630         (beforeAll):
2631         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
2632         (testWebSocketTLSErrors):
2633         (beforeAll):
2634         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
2635         (WebKitTestServer::~WebKitTestServer):
2636         (WebKitTestServer::getWebSocketURIForPath const):
2637         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2638         (WTR::AccessibilityUIElement::rowHeaders const):
2639         (WTR::AccessibilityUIElement::columnHeaders const):
2640         (WTR::AccessibilityUIElement::isAttributeSettable):
2641         (WTR::AccessibilityUIElement::x):
2642         (WTR::AccessibilityUIElement::y):
2643         (WTR::AccessibilityUIElement::width):
2644         (WTR::AccessibilityUIElement::height):
2645         (WTR::AccessibilityUIElement::clickPointX):
2646         (WTR::AccessibilityUIElement::clickPointY):
2647         (WTR::AccessibilityUIElement::intValue const):
2648         (WTR::AccessibilityUIElement::minValue):
2649         (WTR::AccessibilityUIElement::maxValue):
2650         (WTR::stringAtOffset):
2651
2652 2019-06-20  Dean Johnson  <dean_johnson@apple.com>
2653
2654         test-webkitpy is broken on macOS Catalina
2655         https://bugs.webkit.org/show_bug.cgi?id=199078
2656
2657         Reviewed by Jonathan Bedard.
2658
2659         * Scripts/webkitpy/test/main.py: Check if lldb tests are supported before adding them
2660         to the runner.
2661         (main): 
2662         (_supports_building_and_running_lldb_tests): Check if you are running macOS Catalina.
2663
2664 2019-06-20  Dean Johnson  <dean_johnson@apple.com>
2665
2666         Change status to "committer" in contributors.json
2667
2668         Unreviewed.
2669
2670         * Scripts/webkitpy/common/config/contributors.json:
2671
2672 2019-06-20  Alex Christensen  <achristensen@webkit.org>
2673
2674         Add unit test for UIContextMenuConfiguration API
2675         https://bugs.webkit.org/show_bug.cgi?id=199043
2676
2677         Reviewed by Wenson Hsieh.
2678
2679         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2680         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm: Added.
2681         (-[TestContextMenuUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
2682         (-[TestContextMenuUIDelegate webView:contextMenuWillPresentForElement:]):
2683         (-[TestContextMenuUIDelegate webView:contextMenuForElement:willCommitWithAnimator:]):
2684         (-[TestContextMenuUIDelegate webView:contextMenuDidEndForElement:]):
2685         (TEST):
2686         * TestWebKitAPI/cocoa/TestContextMenuDriver.h: Added.
2687         * TestWebKitAPI/cocoa/TestContextMenuDriver.mm: Added.
2688         (-[TestContextMenuDriver delegate]):
2689         (-[TestContextMenuDriver setDelegate:]):
2690         (-[TestContextMenuDriver view]):
2691         (-[TestContextMenuDriver setView:]):
2692         (-[TestContextMenuDriver allowableMovement]):
2693         (-[TestContextMenuDriver setAllowableMovement:]):
2694         (-[TestContextMenuDriver primaryGestureRecognizer]):
2695         (-[TestContextMenuDriver setPrimaryGestureRecognizer:]):
2696         (-[TestContextMenuDriver touchDuration]):
2697         (-[TestContextMenuDriver setTouchDuration:]):
2698         (-[TestContextMenuDriver locationInCoordinateSpace:]):
2699         (-[TestContextMenuDriver cancelInteraction]):
2700         (-[TestContextMenuDriver begin:]):
2701         (-[TestContextMenuDriver clickDown]):
2702         (-[TestContextMenuDriver clickUp]):
2703         (-[TestContextMenuDriver end]):
2704         * TestWebKitAPI/ios/UIKitSPI.h:
2705
2706 2019-06-20  Aakash Jain  <aakash_jain@apple.com>
2707
2708         [ews-app] Status bubble should not turn orange when any build step is skipped
2709         https://bugs.webkit.org/show_bug.cgi?id=199079
2710
2711         Reviewed by Jonathan Bedard.
2712
2713         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2714
2715 2019-06-20  Alex Christensen  <achristensen@webkit.org>
2716
2717         Fix an internal engineering build after r246605
2718        ​https://bugs.webkit.org/show_bug.cgi?id=197800
2719
2720         * TestWebKitAPI/TCPServer.cpp:
2721
2722 2019-06-20  Aakash Jain  <aakash_jain@apple.com>
2723
2724         [ews-build] Triggered builds should use same revision as parent build
2725         https://bugs.webkit.org/show_bug.cgi?id=198289
2726
2727         Reviewed by Jonathan Bedard.
2728
2729         * BuildSlaveSupport/ews-build/steps.py:
2730         (CheckOutSpecificRevision): Build step to checkout specific revision.
2731         (CheckOutSpecificRevision.doStepIf): Run this step only if ews_revision property is set.
2732         (CheckOutSpecificRevision.hideStepIf): Hide this step when it is skipped.
2733         (CheckOutSpecificRevision.start): Run appropriate git command.
2734         (Trigger.propertiesToPassToTriggers): Pass ews_revision property to triggered builds, so that triggered
2735         builds use same revision as parent build.
2736         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2737         * BuildSlaveSupport/ews-build/factories.py:
2738         (Factory.__init__): Added CheckOutSpecificRevision step.
2739
2740 2019-06-20  Aakash Jain  <aakash_jain@apple.com>
2741
2742         [ews-build] Add unit tests for AnalyzeCompileWebKitResults
2743         https://bugs.webkit.org/show_bug.cgi?id=199073
2744
2745         Reviewed by Jonathan Bedard.
2746
2747         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests for AnalyzeCompileWebKitResults.
2748
2749 2019-06-20  Alexander Mikhaylenko  <exalm7659@gmail.com>
2750
2751         [GTK] Enable navigation swipe layout tests
2752         https://bugs.webkit.org/show_bug.cgi?id=198995
2753
2754         Reviewed by Michael Catanzaro.
2755
2756         Add a way for tests to enable and then control swipe gesture on GTK.
2757
2758         * TestRunnerShared/UIScriptContext/UIScriptController.cpp: Hide
2759         empty implementations of beginBackSwipe() and completeBackSwipe() for GTK.
2760         * WebKitTestRunner/PlatformGTK.cmake:
2761         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2762         (WTR::PlatformWebView::setNavigationGesturesEnabled): Implemented.
2763         * WebKitTestRunner/gtk/UIScriptControllerGtk.cpp: Added.
2764         (WTR::UIScriptController::beginBackSwipe):
2765         (WTR::UIScriptController::completeBackSwipe):
2766
2767 2019-06-20  Alexander Mikhaylenko  <exalm7659@gmail.com>
2768
2769         [GTK] HTTP layout tests don't run in flatpak
2770         https://bugs.webkit.org/show_bug.cgi?id=199067
2771
2772         Reviewed by Michael Catanzaro.
2773
2774         Stop bind mounting /app/lib/perl to /etc/perl because Perl doesn't actually
2775         check that path. Instead, add /app/lib/perl to Apache config directly.
2776
2777         /usr/manifest.json file is not guaranteed to exist in sandbox, check for
2778         /.flatpak-info instead.
2779
2780         * Scripts/webkitpy/port/base.py:
2781         (Port._is_flatpak):
2782         (Port._in_flatpak_sandbox):
2783         * flatpak/flatpakutils.py:
2784         (WebkitFlatpak.run_in_sandbox):
2785         (is_sandboxed):
2786
2787 2019-06-18  Darin Adler  <darin@apple.com>
2788
2789         Tidy up the remaining bits of the AtomicString to AtomString rename
2790         https://bugs.webkit.org/show_bug.cgi?id=198990
2791
2792         Reviewed by Michael Catanzaro.
2793
2794         * Scripts/do-webcore-rename: Removed already-done renames.
2795         * TestWebKitAPI/Tests/WTF/StringImpl.cpp: Rename one use of "atomic".
2796
2797 2019-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2798
2799         [GTK] Remove support for GTK2 plugins
2800         https://bugs.webkit.org/show_bug.cgi?id=199065
2801
2802         Reviewed by Sergio Villar Senin.
2803
2804         * EWSTools/ubuntu-ews-packages:
2805         * TestWebKitAPI/PlatformGTK.cmake:
2806         * WebKitTestRunner/PlatformGTK.cmake:
2807         * flatpak/org.webkit.GTK.yaml:
2808         * gtk/install-dependencies:
2809
2810 2019-06-19  Yusuke Suzuki  <ysuzuki@apple.com>
2811
2812         [bmalloc] IsoHeap's initialization is racy with IsoHeap::isInitialized
2813         https://bugs.webkit.org/show_bug.cgi?id=199053
2814
2815         Reviewed by Saam Barati.
2816
2817         Added a test stressing IsoHeap with multiple threads.
2818
2819         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
2820         (assertHasObjects):
2821         (assertHasOnlyObjects):
2822         (assertClean):
2823         (TEST):
2824
2825 2019-06-19  Zalan Bujtas  <zalan@apple.com>
2826
2827         [LFC] Expand tests coverage (1126 new tests -> 2324).
2828
2829         * LayoutReloaded/misc/LFC-passing-tests.txt:
2830
2831 2019-06-19  Fujii Hironori  <Hironori.Fujii@sony.com>
2832
2833         Add WTF::crossThreadCopy(T&&) to utilize String::isolatedCopy() &&
2834         https://bugs.webkit.org/show_bug.cgi?id=198957
2835
2836         Reviewed by Alex Christensen.
2837
2838         * TestWebKitAPI/CMakeLists.txt:
2839         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2840         * TestWebKitAPI/Tests/WTF/CrossThreadCopier.cpp: Added.
2841
2842 2019-06-19  Keith Rollin  <krollin@apple.com>
2843
2844         Relocate some test tools in non-mac builds
2845         https://bugs.webkit.org/show_bug.cgi?id=198984
2846         <rdar://problem/51873261>
2847
2848         Reviewed by Andy Estes.
2849
2850         The tools DumpRenderTree, WebKitTestRunner, LayoutTestHelper, and
2851         TestNetscapePlugin get created in
2852         WebKit.framework/Versions/A/Resources on non-mac builds. This is
2853         incorrect, as those bundles are shallow bundles that don't use the
2854         Versions hierarchy. Instead, store these files directly in
2855         WebKit.framework.
2856
2857         Note that getting rid of just the "Versions/A" path components and
2858         putting the files in WebKit.framework/Resources doesn't work as
2859         `codesign` treats the result as an invalid layout.
2860
2861         The work in this patch involves changing the definition of the custom
2862         build variable WEBKIT_FRAMEWORK_RESOURCES_PATH. The standard build
2863         variable INSTALL_PATH is defined in terms of this variable. In order
2864         to increase visiblity into this relationship, move both of these
2865         variables into .xcconfig files if they weren't already. This
2866         refactoring was done in a way to be the least disruptive and most
2867         compatible with the previous definitions, even at the cost of being
2868         repetitive.
2869
2870         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2871         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2872         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2873         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
2874         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
2875         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
2876
2877 2019-06-19  Aakash Jain  <aakash_jain@apple.com>
2878
2879         [ews-build] Patch link should open the pretty patch
2880         https://bugs.webkit.org/show_bug.cgi?id=199031
2881
2882         Reviewed by Jonathan Bedard.
2883
2884         * BuildSlaveSupport/ews-build/steps.py:
2885         (ConfigureBuild.getPatchURL): Use the prettypatch url for patch.
2886
2887 2019-06-19  Aakash Jain  <aakash_jain@apple.com>
2888
2889         [ews-build] Add step to analyze Compile WebKit failures
2890         https://bugs.webkit.org/show_bug.cgi?id=199025
2891
2892         Reviewed by Jonathan Bedard.
2893
2894         * BuildSlaveSupport/ews-build/steps.py:
2895         (CompileWebKit.evaluateCommand): Add AnalyzeCompileWebKitResults step.
2896         (CompileWebKitToT): set haltOnFailure to False since we need to run AnalyzeCompileWebKitResults step.
2897         (AnalyzeCompileWebKitResults): Class to analyze compile webkit steps results.
2898         (AnalyzeCompileWebKitResults.start): If ToT fails to build, retry the build, else marked the build as failed. Note that
2899         this step is run only when compile-webkit failed.
2900
2901 2019-06-19  Aakash Jain  <aakash_jain@apple.com>
2902
2903         [ews-build] Send email notifications for failures
2904         https://bugs.webkit.org/show_bug.cgi?id=198919
2905
2906         Reviewed by Jonathan Bedard.
2907
2908         * BuildSlaveSupport/ews-build/master.cfg:
2909
2910 2019-06-19  Alex Christensen  <achristensen@webkit.org>
2911
2912         Add a unit test for client certificate authentication
2913         https://bugs.webkit.org/show_bug.cgi?id=197800
2914
2915         Reviewed by Youenn Fablet.
2916
2917         Make better abstractions for reading and writing from/to TCPServer.
2918         Add a unit test that causes a client certificate authentication challenge to happen.
2919
2920         * TestWebKitAPI/TCPServer.cpp:
2921         (TestWebKitAPI::TCPServer::TCPServer):
2922         (TestWebKitAPI::TCPServer::read):
2923         (TestWebKitAPI::TCPServer::write):
2924         (TestWebKitAPI::TCPServer::respondWithChallengeThenOK):
2925         (TestWebKitAPI::TCPServer::respondWithOK):
2926         * TestWebKitAPI/TCPServer.h:
2927         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
2928         (credentialWithIdentity):
2929         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2930         (TEST):
2931         (-[ClientCertificateDelegate webView:didFinishNavigation:]):
2932         (-[ClientCertificateDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2933         (-[ClientCertificateDelegate challengeCount]):
2934         (TestWebKitAPI::TEST):
2935         (respondWithChallengeThenOK): Deleted.
2936         (credentialWithIdentityAndKeychainPath): Deleted.
2937         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
2938         (TEST):
2939         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
2940         (TestWebKitAPI::TEST):
2941         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2942         (TEST):
2943         (readRequest): Deleted.
2944         (writeResponse): Deleted.
2945         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
2946         (TestWebKitAPI::TEST):
2947         (TestWebKitAPI::respondWithChallengeThenOK): Deleted.
2948
2949 2019-06-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2950
2951         Unreviewed, fix build warnings in TestWebKitAPIInjectedBundle
2952
2953         System headers are being included without SYSTEM again here.
2954
2955         * TestWebKitAPI/PlatformGTK.cmake:
2956
2957 2019-06-18  Yusuke Suzuki  <ysuzuki@apple.com>
2958
2959         [JSC] JSLock should be WebThread aware
2960         https://bugs.webkit.org/show_bug.cgi?id=198911
2961
2962         Reviewed by Geoffrey Garen.
2963
2964         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2965         * TestWebKitAPI/Tests/WebKitLegacy/ios/JSLockTakesWebThreadLock.mm: Added.
2966         (TestWebKitAPI::TEST):
2967
2968 2019-06-18  Keith Miller  <keith_miller@apple.com>
2969
2970         webkit-patch should allow for a bugzilla url not just bugzilla id
2971         https://bugs.webkit.org/show_bug.cgi?id=198972
2972
2973         Reviewed by Dewei Zhu.
2974
2975         When prompting for a bugzilla id or a new title we should also
2976         allow for a bugzilla url.
2977
2978         * Scripts/webkitpy/tool/steps/promptforbugortitle.py:
2979         (PromptForBugOrTitle.run):
2980
2981 2019-06-18  David Quesada  <david_quesada@apple.com>
2982
2983         REGRESSION: _WKDownload.OriginatingWebView and _WKDownload.CrashAfterDownloadDidFinishWhenDownloadProxyHoldsTheLastRefOnWebProcessPool failing
2984         https://bugs.webkit.org/show_bug.cgi?id=198954
2985         rdar://problem/51711556
2986
2987         Reviewed by Alex Christensen.
2988
2989         For these tests, kill the web process after the download starts. This makes the deallocation
2990         of the download-originating web views, which these tests depend on, more reliable.
2991
2992         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2993         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
2994         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
2995
2996 2019-06-18  Dan Bernstein  <mitz@apple.com>
2997
2998         Revert workaround for bug 198904 from run-webkit-archive
2999         https://bugs.webkit.org/show_bug.cgi?id=198931
3000
3001         Reviewed by Alexey Proskuryakov.
3002
3003         Reverted r245965, now that the load commands in the XPC service binaries make them correctly
3004         pick up the built frameworks.
3005
3006         * WebKitArchiveSupport/run-webkit-archive:
3007         (set_dyld_framework_path):
3008
3009 2019-06-17  Sihui Liu  <sihui_liu@apple.com>
3010
3011         -[WKWebsiteDataStore removeDataOfTypes:modifiedSince:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
3012         https://bugs.webkit.org/show_bug.cgi?id=198854
3013         <rdar://problem/51386058>
3014
3015         Reviewed by Geoffrey Garen.
3016
3017         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
3018         (TestWebKitAPI::TEST):
3019
3020 2019-06-17  Adrian Perez de Castro  <aperez@igalia.com>
3021
3022         [Flatpak][JHBuild] Update build environments to use WPEBackend-fdo 1.3.1
3023         https://bugs.webkit.org/show_bug.cgi?id=198831
3024
3025         Reviewed by Žan Doberšek.
3026
3027         * flatpak/org.webkit.WPEModules.yaml: Bump versions of libwpe and WPEBackend-fdo to 1.3.1
3028         * wpe/jhbuild.modules: Ditto.
3029         * wpe/patches/wpebackend-fdo-Handle-the-case-of-new-target-created-for-the-same-v.patch: Removed.
3030         * wpe/wpebackend-fdo-view-backend-exportable-private-don-t-double-free-ca.patch: Removed.
3031
3032 2019-06-17  Jiewen Tan  <jiewen_tan@apple.com>
3033
3034         Move SOAuthorization from WebKitAdditions to WebKit
3035         https://bugs.webkit.org/show_bug.cgi?id=198874
3036         <rdar://problem/47573431>
3037
3038         Reviewed by Brent Fulgham.
3039
3040         This patch moves all SOAuthorization tests from WebKitAdditions to WebKit.
3041
3042         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3043         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3044         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm: Added.
3045         (-[TestSOAuthorizationNavigationDelegate init]):
3046         (-[TestSOAuthorizationNavigationDelegate webView:didFinishNavigation:]):
3047         (-[TestSOAuthorizationNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3048         (-[TestSOAuthorizationNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3049         (-[TestSOAuthorizationViewController viewDidAppear]):
3050         (-[TestSOAuthorizationViewController viewDidDisappear]):
3051         (overrideCanPerformAuthorizationWithURL):
3052         (overrideSetDelegate):
3053         (overrideBeginAuthorizationWithURL):
3054         (overrideCancelAuthorization):
3055         (overrideAddObserverForName):
3056         (overrideIsURLFromAppleOwnedDomain):
3057         (resetState):
3058         (configureSOAuthorizationWebView):
3059         (generateHtml):
3060         (checkAuthorizationOptions):
3061         (TestWebKitAPI::TEST):
3062
3063 2019-06-17  Brent Fulgham  <bfulgham@apple.com>
3064
3065         Ensure ITP state is relayed to Network Process on restart
3066         https://bugs.webkit.org/show_bug.cgi?id=198797
3067         <rdar://problem/51646944>
3068
3069         Reviewed by Youenn Fablet.
3070
3071         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3072         (cleanupITPDatabase): Added.
3073         (TEST:EnableDisableITP): Update to use cleanup method.
3074         (TEST:NetworkProcessRestart): Added.
3075
3076 2019-06-17  Aakash Jain  <aakash_jain@apple.com>
3077
3078         New EWS can't process patches larger than 640kb
3079         https://bugs.webkit.org/show_bug.cgi?id=198851
3080
3081         Reviewed by Jonathan Bedard.
3082
3083         * BuildSlaveSupport/ews-build/master.cfg: Increase the patch size limit to 100 MB.
3084
3085 2019-06-17  Jonathan Bedard  <jbedard@apple.com>
3086
3087         webkitpy: Add macOS Catalina, iOS 13
3088         https://bugs.webkit.org/show_bug.cgi?id=198492
3089
3090         Reviewed by Alexey Proskuryakov.
3091
3092         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Catalina.png: Added.
3093         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Catalina@2x.png: Added.
3094         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS13.png: Added.
3095         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS13@2x.png: Added.
3096         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS13Simulator.png: Added.
3097         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS13Simulator@2x.png: Added.
3098         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3099         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3100         * BuildSlaveSupport/ews-build/steps.py:
3101         * Scripts/webkitpy/common/version_name_map.py:
3102         * Scripts/webkitpy/common/version_name_map_unittest.py:
3103         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3104         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3105
3106 2019-06-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3107
3108         Unreviewed. [GTK] Bump WPEBackend-fdo requirement to 1.3.1
3109
3110         * gtk/jhbuild.modules:
3111         * gtk/patches/wpebackend-fdo-Handle-the-case-of-new-target-created-for-the-same-v.patch: Removed.
3112         * gtk/wpebackend-fdo-view-backend-exportable-private-don-t-double-free-ca.patch: Removed.
3113
3114 2019-06-16  Zalan Bujtas  <zalan@apple.com>
3115
3116         [LFC] Expand tests coverage (325 new tests -> 1198).
3117
3118         * LayoutReloaded/misc/LFC-passing-tests.txt:
3119
3120 2019-06-16  Darin Adler  <darin@apple.com>
3121
3122         Rename AtomicString to AtomString
3123         https://bugs.webkit.org/show_bug.cgi?id=195276
3124
3125         Reviewed by Michael Catanzaro.
3126
3127         * many files: Let do-webcore-rename do the renaming.
3128
3129         * Scripts/do-webcore-rename: Updated with a list of all the identifiers
3130         that mention "atomic string" and changed them to instead say "atom string".
3131
3132 2019-06-16  Zalan Bujtas  <zalan@apple.com>
3133
3134         [LFC] Unreviewed test gardening.
3135
3136         Unsupported alignments.
3137
3138         fast/inline/absolute-positioned-inline-in-centred-block.html -align: center
3139         fast/borders/empty-outline-border-assert.html -vertical-align: super
3140         css2.1/20110323/vertical-align-boxes-001.htm - vertical-align: middle
3141
3142         * LayoutReloaded/misc/LFC-passing-tests.txt:
3143
3144 2019-06-15  Youenn Fablet  <youenn@apple.com>
3145
3146         WPT test importer WTR option reader should not throw if the file is not proper UTF-8
3147         https://bugs.webkit.org/show_bug.cgi?id=198780
3148
3149         Reviewed by Jonathan Bedard.
3150
3151         * Scripts/webkitpy/w3c/test_importer.py:
3152         (TestImporter._webkit_test_runner_options):
3153         In case the test file cannot be read as text, consider that there is no WTR option.
3154
3155 2019-06-14  Youenn Fablet  <youenn@apple.com>
3156
3157         WebResourceLoadStatisticsStore should not use its network session if invalidated
3158         https://bugs.webkit.org/show_bug.cgi?id=198814
3159
3160         Reviewed by Geoffrey Garen.
3161
3162         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3163         (TEST):
3164
3165 2019-06-14  Youenn Fablet  <youenn@apple.com>
3166
3167         import-w3c-tests should respect WEBKIT_OUTPUTDIR
3168         https://bugs.webkit.org/show_bug.cgi?id=198682
3169         <rdar://problem/51536931>
3170
3171         Reviewed by Jonathan Bedard.
3172
3173         Check for WEBKIT_OUTPUTDIR environment variable to compute the w3c-tests folder.
3174         Made some refactoring to also teach WPTPaths users about WEBKIT_OUTPUTDIR.
3175
3176         * Scripts/webkitpy/common/webkit_finder.py:
3177         (WebKitFinder.path_from_webkit_outputdir):
3178         * Scripts/webkitpy/w3c/common.py:
3179         (WPTPaths):
3180         (WPTPaths.checkout_directory):
3181         (WPTPaths.wpt_checkout_path):
3182         * Scripts/webkitpy/w3c/test_importer.py:
3183         (TestImporter.__init__):
3184         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3185         (test_checkout_directory):
3186
3187 2019-06-13  Antoine Quint  <graouts@apple.com>
3188
3189         REGRESSION (r246103) [ Mojave+ WK1 ] Layout Test scrollbars/scrollbar-iframe-click-does-not-blur-content.html is timing out
3190         https://bugs.webkit.org/show_bug.cgi?id=198800
3191         <rdar://problem/51679634>
3192
3193         Reviewed by Tim Horton.
3194
3195         We didn't detect an NSScroller in a sub-frame due to WebHTMLView's implementation of -[NSView hitTest:]. We now use a private method
3196         which lets us use the default implementation and correctly returns an NSScroller in a sub-frame.
3197
3198         * DumpRenderTree/mac/EventSendingController.mm:
3199         (eventPressedMouseButtonsSwizzlerForViewAndEvent):
3200         (-[EventSendingController mouseDown:withModifiers:]):
3201         (-[EventSendingController mouseUp:withModifiers:]):
3202         (-[EventSendingController mouseMoveToX:Y:]):
3203
3204 2019-06-13  Fujii Hironori  <Hironori.Fujii@sony.com>
3205
3206         [WinCairo][WebKitTestRunner] pixel image dump outputs blank images
3207         https://bugs.webkit.org/show_bug.cgi?id=198820
3208
3209         Reviewed by Ross Kirsling.
3210
3211         WebView window paints nothing because it is moved out of the
3212         screen. Send WM_PRINT with memory DC instead of WM_PAINT as well
3213         as DumpRenderTree does.
3214
3215         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3216         (WTR::PlatformWebView::windowSnapshotImage): Send WM_PRINT instead of BitBlt.
3217
3218 2019-06-13  Tim Horton  <timothy_horton@apple.com>
3219
3220         Make it possible for validate-committer-lists to dump a mailmap file
3221         https://bugs.webkit.org/show_bug.cgi?id=198517
3222
3223         Reviewed by Simon Fraser.
3224
3225         Mailmaps wildly improve the output of various Git tools, including
3226         `git shortlog -sne`, mapping committers to our canonical name/email pair.
3227
3228         * Scripts/validate-committer-lists:
3229         (CommitterListFromGit):
3230         (CommitterListBugzillaChecker.print_committers_with_invalid_bugzilla_emails):
3231         Add some missing legacy username mappings.
3232
3233         (dump_mailmap):
3234         (dump_mailmap.format_email):
3235         (dump_mailmap.format_email_with_gitsvn_uuid):
3236         (dump_mailmap.map_emails_to_legacy_username):
3237         (main):
3238         Add `validate-committer-lists --dump-mailmap`, which generates
3239         one given committers.json and the existing mapping of legacy username
3240         to email addresses that exists in validate-committer-lists.
3241
3242 2019-06-12  Aakash Jain  <aakash_jain@apple.com>
3243
3244         Replace double-quotes with single quotes in loadConfig.py
3245         https://bugs.webkit.org/show_bug.cgi?id=198792
3246
3247         Reviewed by Jonathan Bedard.
3248
3249         * BuildSlaveSupport/ews-build/loadConfig.py:
3250         * BuildSlaveSupport/ews-build/steps_unittest.py:
3251
3252 22019-06-11  Brent Fulgham  <bfulgham@apple.com>
3253
3254         Add mechanism and test case to check if ITP is active
3255         https://bugs.webkit.org/show_bug.cgi?id=198694
3256         <rdar://problem/51557704>
3257
3258         Reviewed by Youenn Fablet.
3259
3260         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3261         (TEST):
3262
3263 2019-06-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3264
3265         [WPE][GTK] Deprecate WebSQL APIs
3266         https://bugs.webkit.org/show_bug.cgi?id=195011
3267
3268         Reviewed by Carlos Garcia Campos.
3269
3270         * MiniBrowser/gtk/main.c:
3271         (gotWebsiteDataCallback):
3272         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
3273         (testWebsiteDataConfiguration):
3274         (testWebsiteDataEphemeral):
3275         (testWebsiteDataDatabases):
3276
3277 2019-06-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3278
3279         [WPE][GTK] Enable hyperlink auditing
3280         https://bugs.webkit.org/show_bug.cgi?id=197845
3281
3282         Reviewed by Carlos Garcia Campos.
3283
3284         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3285         (testWebKitSettings):
3286
3287 2019-06-11  Keith Rollin  <krollin@apple.com>
3288
3289         Open up xcfilelist processing to more platforms
3290         https://bugs.webkit.org/show_bug.cgi?id=198675
3291         <rdar://problem/51533238>
3292
3293         Reviewed by Jonathan Bedard.
3294
3295         Now that it's been tested, add AppleTV{OS,Simulator} to the set of
3296         platforms on which to perform xcfilelist generation/updating.
3297
3298         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
3299         (JavaScriptCoreGenerator):
3300         (WebCoreGenerator):
3301         (WebKitGenerator):
3302
3303 2019-06-11  Jonathan Bedard  <jbedard@apple.com>
3304
3305         webkitpy: Fix device ASan reporting, add testing for report configurations
3306         https://bugs.webkit.org/show_bug.cgi?id=198756
3307
3308         Reviewed by Aakash Jain.
3309
3310         ASan results were reporting an incorrect style. This indicates we need to be testing this upload
3311         configuration thoroughly in webkitpy.
3312
3313         * Scripts/webkitpy/port/config.py:
3314         (clear_cached_configuration): Clearing configurations should clear the ASan cache as well.
3315         * Scripts/webkitpy/port/device_port.py:
3316         (DevicePort.configuration_for_upload): Add ASan as style.
3317         * Scripts/webkitpy/port/ios_device_unittest.py:
3318         (IOSDeviceTest):
3319         (IOSDeviceTest.test_default_upload_configuration):
3320         * Scripts/webkitpy/port/ios_simulator_unittest.py:
3321         (IOSSimulatorTest.test_default_upload_configuration):
3322         * Scripts/webkitpy/port/mock_drt_unittest.py:
3323         (MockDRTPortTest.test_asan_upload_configuration):
3324         * Scripts/webkitpy/port/port_testcase.py:
3325         (test_default_upload_configuration):
3326         (test_debug_upload_configuration):
3327         (test_asan_upload_configuration):
3328         (test_guard_malloc_configuration):
3329         * Scripts/webkitpy/port/watch_simulator_unittest.py:
3330         (WatchSimulatorTest):
3331         (WatchSimulatorTest.test_default_upload_configuration):
3332
3333 2019-06-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3334
3335         tu-berlin university email web interface (Outlook Web App) goes directly to the light version instead of the normal web app
3336         https://bugs.webkit.org/show_bug.cgi?id=198749
3337
3338         Reviewed by Carlos Garcia Campos.
3339
3340         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3341         (TestWebKitAPI::TEST):
3342
3343 2019-06-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3344
3345         Quotes are always inserted as smart quotes on stackblitz.com, causing compilation errors
3346         https://bugs.webkit.org/show_bug.cgi?id=198735
3347         <rdar://problem/51557159>
3348
3349         Reviewed by Megan Gardner.
3350
3351         Add a test to verify that spellcheck="false" disables smart quotes and dashes, but any other value defers to the
3352         user's preferences by using UITextSmartQuotesTypeDefault and UITextSmartDashesTypeDefault.
3353
3354         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3355         (TestWebKitAPI::TEST):
3356
3357 2019-06-11  Tadeu Zagallo  <tzagallo@apple.com>
3358
3359         Unreviewed, add myself to the JavaScriptCore watchlist.
3360
3361         * Scripts/webkitpy/common/config/watchlist:
3362
3363 2019-06-11  Tadeu Zagallo  <tzagallo@apple.com>
3364
3365         Unreviewed, change my status to be a WebKit reviewer
3366
3367         * Scripts/webkitpy/common/config/contributors.json:
3368
3369 2019-06-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3370
3371         [WPE] Use new exported image API from fdo backend
3372         https://bugs.webkit.org/show_bug.cgi?id=198558
3373
3374         Reviewed by Philippe Normand.
3375
3376         * WebKitTestRunner/PlatformWPE.cmake: Do not find fdo backend and libxkb again here, since WKTR depends on
3377         WPEToolingBackends that already depends on fdo backend and libxkb
3378         * wpe/backends/CMakeLists.txt: Bump fdo requirements to 1.3.0 version.
3379         * wpe/backends/HeadlessViewBackend.cpp:
3380         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend):
3381         (WPEToolingBackends::HeadlessViewBackend::createSnapshot):
3382         (WPEToolingBackends::HeadlessViewBackend::performUpdate):
3383         (WPEToolingBackends::HeadlessViewBackend::displayBuffer):
3384         * wpe/backends/HeadlessViewBackend.h:
3385         * wpe/backends/ViewBackend.cpp:
3386         (WPEToolingBackends::ViewBackend::initialize):
3387         * wpe/backends/ViewBackend.h:
3388         * wpe/backends/WindowViewBackend.cpp:
3389         (WPEToolingBackends::WindowViewBackend::displayBuffer):
3390         * wpe/backends/WindowViewBackend.h:
3391
3392 2019-06-10  Dewei Zhu  <dewei_zhu@apple.com>
3393
3394         Extend run-benchmark to allow diagnosing before closing browser on test failure.
3395         https://bugs.webkit.org/show_bug.cgi?id=198729
3396
3397         Reviewed by Ryosuke Niwa.
3398
3399         Add '--diagnose-directory' option to store diagnose information when test failed.
3400
3401         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3402         (BenchmarkRunner.__init__):
3403         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
3404         (BrowserDriver.diagnose_test_failure): Add default no-op function to base class.
3405         * Scripts/webkitpy/benchmark_runner/run_benchmark.py: Added '--diagnose-directory' option.
3406         (parse_args):
3407         (run_benchmark_plan):
3408         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
3409         (WebDriverBenchmarkRunner._run_one_test): Added 'diagnose_test_failure' invocation on test failure.
3410         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
3411         (WebServerBenchmarkRunner.__init__):
3412         (WebServerBenchmarkRunner._run_one_test): Added 'diagnose_test_failure' invocation on test failure.
3413
3414 2019-06-10  Sam Weinig  <weinig@apple.com>
3415
3416         Remove Dashboard support
3417         https://bugs.webkit.org/show_bug.cgi?id=198615
3418
3419         Reviewed by Ryosuke Niwa.
3420
3421         * DumpRenderTree/TestRunner.cpp:
3422         (TestRunner::staticFunctions):
3423         (setUseDashboardCompatibilityModeCallback): Deleted.
3424         * DumpRenderTree/TestRunner.h:
3425         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3426         * DumpRenderTree/mac/DumpRenderTree.mm:
3427         (resetWebViewToConsistentStateBeforeTesting):
3428         * DumpRenderTree/mac/TestRunnerMac.mm:
3429         (TestRunner::setUseDashboardCompatibilityMode): Deleted.
3430         * ImageDiff/cg/Configurations/Base.xcconfig:
3431         * Scripts/webkitperl/FeatureList.pm:
3432         * TestWebKitAPI/Configurations/Base.xcconfig:
3433         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3434         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3435         * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm: Removed.
3436         * WebKitTestRunner/Configurations/Base.xcconfig:
3437         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3438         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3439         (WTR::InjectedBundle::beginTesting):
3440         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3441         (WTR::TestRunner::setUseDashboardCompatibilityMode): Deleted.
3442         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3443
3444 2019-06-10  Alexey Proskuryakov  <ap@apple.com>
3445
3446         Tool binaries like WebKitTestRunner have too aggressive stripping, resulting in non-symbolicated crash logs
3447         https://bugs.webkit.org/show_bug.cgi?id=198616
3448         rdar://problem/36386573
3449
3450         Reviewed by David Kilzer.
3451
3452         Adding an explicit STRIP_STYLE to appropriate xcconfigs.
3453
3454         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
3455         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
3456         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
3457         * ImageDiff/cg/Configurations/ImageDiff.xcconfig:
3458         * MiniBrowser/Configurations/MiniBrowser.xcconfig:
3459         * MobileMiniBrowser/Configurations/MobileMiniBrowser.xcconfig:
3460         * TestWebKitAPI/Configurations/TestWTF.xcconfig:
3461         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3462         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
3463         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
3464
3465 2019-06-10  Wenson Hsieh  <wenson_hsieh@apple.com>
3466
3467         [iOS] fast/xsl tests are flaky when run after certain viewport shrink-to-fit tests
3468         https://bugs.webkit.org/show_bug.cgi?id=198699
3469         <rdar://problem/50501718>
3470
3471         Reviewed by Simon Fraser.
3472
3473         Add logic to platformResetPreferencesToConsistentValues, to reset the "ShouldIgnoreMetaViewport" preference.
3474         While this is already being adjusted in platformConfigureViewForTest using the correct, TestOptions, this might
3475         happen too late, allowing the shrink-to-fit-content heuristic to unexpectedly kick in on tests where testing
3476         viewport parameters are used.
3477
3478         * WebKitTestRunner/ios/TestControllerIOS.mm:
3479         (WTR::TestController::platformResetPreferencesToConsistentValues):
3480         (WTR::TestController::platformConfigureViewForTest):
3481
3482 2019-06-10  Yusuke Suzuki  <ysuzuki@apple.com>
3483
3484         [JSC] UnlinkedCodeBlock should be eventually jettisoned in VM mini mode
3485         https://bugs.webkit.org/show_bug.cgi?id=198023
3486
3487         Reviewed by Saam Barati.
3488
3489         * Scripts/run-jsc-stress-tests:
3490
3491 2019-06-10  Timothy Hatcher  <timothy@apple.com>
3492
3493         Integrate dark mode support for iOS.
3494         https://bugs.webkit.org/show_bug.cgi?id=198687
3495         rdar://problem/51545643
3496
3497         Reviewed by Tim Horton.
3498
3499         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3500
3501 2019-06-10  Jonathan Bedard  <jbedard@apple.com>
3502
3503         webkitpy: xcrun simctl spawn *** launchctl print system output is not utf-8
3504         https://bugs.webkit.org/show_bug.cgi?id=198723
3505
3506         Reviewed by Aakash Jain.
3507
3508         * Scripts/webkitpy/xcode/simulated_device.py:
3509         (SimulatedDevice.is_usable): Do not decode 'print system' output, it's already ASCII.
3510
3511 2019-06-10  Sihui Liu  <sihui_liu@apple.com>
3512
3513         [WKHTTPCookieStore getAllCookies:] may return duplicate cookies
3514         https://bugs.webkit.org/show_bug.cgi?id=198635
3515         <rdar://problem/46010232>
3516
3517         Reviewed by Ryosuke Niwa.
3518
3519         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
3520         (areCookiesEqual):
3521         (TEST):
3522
3523 2019-06-10  Adrian Perez de Castro  <aperez@igalia.com>
3524
3525         [JHBuild] Bump shared-mime-info to version ≥ 1.6
3526         https://bugs.webkit.org/show_bug.cgi?id=198714
3527
3528         Reviewed by Carlos Garcia Campos.
3529
3530         * gtk/jhbuild.modules: Bump shared-mime-info version to 1.10.
3531         * gtk/patches/shared-mime-info-xht-glob.patch: Removed.
3532         * gtk/patches/shared-mime-info-xhtml-magic.patch: Removed.
3533
3534 2019-06-10  Philippe Normand  <pnormand@igalia.com>
3535
3536         [WPE][Qt] Port to new wpe_fdo_egl_exported_image API
3537         https://bugs.webkit.org/show_bug.cgi?id=198713
3538
3539         Reviewed by Carlos Garcia Campos.
3540
3541         * flatpak/org.webkit.WPEModules.yaml: Include wpebackend-fdo
3542         patches currently used in JHBuild.
3543
3544 2019-06-10  Adrian Perez de Castro  <aperez@igalia.com>
3545
3546         [GTK][Flatpak] webkit-build fails due to missing libwpe in Flatpak environment
3547         https://bugs.webkit.org/show_bug.cgi?id=198711
3548
3549         Reviewed by Philippe Normand.
3550
3551         * flatpak/org.webkit.GTK.yaml: Also include modules from
3552         org.webkit.WPEModules.yaml, which brings in libwpe and WPEBackend-fdo
3553
3554 2019-06-10  Zan Dobersek  <zdobersek@igalia.com>
3555
3556         Unreviewed follow-up to r246148. Add another WPEBackend-fdo patch that
3557         avoids double-free condition that's causing bots to exit early.
3558
3559         * gtk/jhbuild.modules:
3560         * gtk/wpebackend-fdo-view-backend-exportable-private-don-t-double-free-ca.patch: Added.
3561         * wpe/jhbuild.modules:
3562         * wpe/wpebackend-fdo-view-backend-exportable-private-don-t-double-free-ca.patch: Added.
3563
3564 2019-06-09  Fujii Hironori  <Hironori.Fujii@sony.com>
3565
3566         [WinCairo][MiniBrowser] Disable MediaCapabilities until it's ready
3567         https://bugs.webkit.org/show_bug.cgi?id=198655
3568
3569         Reviewed by Ross Kirsling.
3570
3571         MediaCapabilities is enabled by default for WK2, but WinCairo
3572         doesn't implemented yet. Disable it in MiniBrowser.
3573
3574         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3575         (WebKitBrowserWindow::create):
3576
3577 2019-06-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3578
3579         [iOS] The default application name for user agent when requesting desktop content is still "Mobile/15E148"
3580         https://bugs.webkit.org/show_bug.cgi?id=198693
3581         <rdar://problem/51555371>
3582
3583         Reviewed by Tim Horton.
3584
3585         Augment an existing API test to exercise three additional scenarios:
3586             -   The web view configuration's application name is never set; the default should not include
3587                 "Mobile/15E148" in desktop mode.
3588             -   The application name is explicitly set to nil; the default application name should still not include
3589                 "Mobile/15E148".
3590             -   The application name is explicitly set to the default value, "Mobile/15E148". WKWebView should honor
3591                 this when generating the user agent, even in desktop mode.
3592
3593         * TestWebKitAPI/ios/PreferredContentMode.mm:
3594         (TestWebKitAPI::setUpWebViewForPreferredContentModeTestingWithoutNavigationDelegate):
3595         (TestWebKitAPI::setUpWebViewForPreferredContentModeTesting):
3596         (TestWebKitAPI::TEST):
3597
3598 2019-06-08  Zalan Bujtas  <zalan@apple.com>
3599
3600         [LFC] Unreviewed test gardening.
3601
3602         Remove rtl tests. They were mistakenly marked as pass.
3603
3604         * LayoutReloaded/misc/LFC-passing-tests.txt:
3605
3606 2019-06-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3607
3608         REGRESSION (r244182) [WK1]: Page updates should always scheduleCompositingLayerFlush() immediately
3609         https://bugs.webkit.org/show_bug.cgi?id=198664
3610
3611         Reviewed by Simon Fraser.
3612
3613         Delete repeated entries which were submitted by mistake.
3614
3615         * Tracing/SystemTracePoints.plist:
3616
3617 2019-06-07  Wenson Hsieh  <wenson_hsieh@apple.com>
3618
3619         Allow clients to vend custom -inputView and -inputAccessoryView by overriding WKWebView methods
3620         https://bugs.webkit.org/show_bug.cgi?id=198631
3621         <rdar://problem/51505431>
3622
3623         Reviewed by Tim Horton.
3624
3625         Add an API test that overrides -[WKWebView inputView] and -[WKWebView inputAccessoryView].
3626
3627         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3628         (-[CustomInputWebView initWithFrame:configuration:inputView:inputAccessoryView:]):
3629         (-[CustomInputWebView inputView]):
3630         (-[CustomInputWebView inputAccessoryView]):
3631         (TestWebKitAPI::TEST):
3632
3633 2019-06-07  Daniel Bates  <dabates@apple.com>
3634
3635         [lldb-webkit] Pretty-print all kinds of Documents
3636         https://bugs.webkit.org/show_bug.cgi?id=198620
3637
3638         Reviewed by Simon Fraser.
3639
3640         Register formatters for all classes derived from WebCore::Document so we get nice summaries
3641         without having to drill down in Xcode- or casting- to the base class, Document.
3642
3643         Older LLDB versions use to do this automatically, but this functionality was removed in newer
3644         versions:
3645             [[
3646                 Warning: previous versions of LLDB defined cascading to mean not only going through typedef
3647                 chains, but also through inheritance chains. This feature has been removed since it
3648                 significantly degrades performance. You need to set up your formatters for every type in
3649                 inheritance chains to which you want the formatter to apply.
3650             ]]
3651             <https://lldb.llvm.org/use/variable.html> (as of 06/06/2019)
3652
3653         * lldb/lldb_webkit.py:
3654         (__lldb_init_module):
3655
3656 2019-06-07  Jonathan Bedard  <jbedard@apple.com>
3657
3658         webkitpy: Support reporting results for uncommon test configurations
3659         https://bugs.webkit.org/show_bug.cgi?id=198662
3660         <rdar://problem/51524128>
3661
3662         Reviewed by Aakash Jain.
3663
3664         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3665