c859449a3b652f400b9e1488ce597811e47054a0
[WebKit-https.git] / Tools / ChangeLog
1 2014-09-30  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2
3         Remove thirdparty/unittest2 from webkitpy
4         https://bugs.webkit.org/show_bug.cgi?id=137251
5
6         Reviewed by Brent Fulgham.
7
8         Additionally ordered imports in related webkitpy files and
9         removed unnecessary shebangs from unittest files.
10
11         * BuildSlaveSupport/build.webkit.org-config/htdigestparser_unittest.py:
12         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
13         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
14         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
15         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
16         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
17         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
18         * Scripts/webkitpy/common/config/committers_unittest.py:
19         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
20         * Scripts/webkitpy/common/config/contributionareas_unittest.py:
21         * Scripts/webkitpy/common/config/ports_unittest.py:
22         * Scripts/webkitpy/common/config/urls_unittest.py:
23         * Scripts/webkitpy/common/editdistance_unittest.py:
24         * Scripts/webkitpy/common/find_files_unittest.py:
25         * Scripts/webkitpy/common/lru_cache_unittest.py:
26         * Scripts/webkitpy/common/memoized_unittest.py:
27         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
28         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
29         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
30         * Scripts/webkitpy/common/net/credentials_unittest.py:
31         * Scripts/webkitpy/common/net/failuremap_unittest.py:
32         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
33         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
34         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
35         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
36         * Scripts/webkitpy/common/net/statusserver_unittest.py:
37         * Scripts/webkitpy/common/net/unittestresults_unittest.py:
38         * Scripts/webkitpy/common/newstringio_unittest.py:
39         * Scripts/webkitpy/common/prettypatch_unittest.py:
40         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py:
41         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
42         * Scripts/webkitpy/common/system/environment_unittest.py:
43         * Scripts/webkitpy/common/system/executive.py: Ordered imports.
44         * Scripts/webkitpy/common/system/executive_mock.py: Ordered imports.
45         * Scripts/webkitpy/common/system/executive_unittest.py:
46         * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
47         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
48         * Scripts/webkitpy/common/system/filesystem_unittest.py:
49         * Scripts/webkitpy/common/system/logtesting.py:
50         * Scripts/webkitpy/common/system/logutils_unittest.py:
51         * Scripts/webkitpy/common/system/outputcapture.py:
52         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
53         * Scripts/webkitpy/common/system/outputtee_unittest.py:
54         * Scripts/webkitpy/common/system/path_unittest.py:
55         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
56         * Scripts/webkitpy/common/system/profiler_unittest.py:
57         * Scripts/webkitpy/common/system/stack_utils_unittest.py:
58         * Scripts/webkitpy/common/system/user_unittest.py:
59         * Scripts/webkitpy/common/system/workspace_unittest.py:
60         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
61         * Scripts/webkitpy/common/thread/messagepump_unittest.py:
62         * Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py:
63         * Scripts/webkitpy/common/watchlist/amountchangedpattern_unittest.py:
64         * Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py:
65         * Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py:
66         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
67         * Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py:
68         * Scripts/webkitpy/common/webkitunittest.py:
69         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
70         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
71         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
72         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
73         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
74         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
75         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
76         * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
77         * Scripts/webkitpy/layout_tests/models/test_results_unittest.py:
78         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
79         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
80         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
81         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py:
82         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
83         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
84         * Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py:
85         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
86         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
87         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
88         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
89         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
90         * Scripts/webkitpy/port/base_unittest.py:
91         * Scripts/webkitpy/port/builders_unittest.py:
92         * Scripts/webkitpy/port/config_unittest.py:
93         * Scripts/webkitpy/port/driver_unittest.py:
94         * Scripts/webkitpy/port/efl_unittest.py:
95         * Scripts/webkitpy/port/factory_unittest.py:
96         * Scripts/webkitpy/port/gtk_unittest.py:
97         * Scripts/webkitpy/port/http_lock_unittest.py:
98         * Scripts/webkitpy/port/image_diff_unittest.py:
99         * Scripts/webkitpy/port/leakdetector_unittest.py:
100         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py:
101         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
102         * Scripts/webkitpy/port/mock_drt_unittest.py:
103         * Scripts/webkitpy/port/port_testcase.py:
104         * Scripts/webkitpy/port/server_process_unittest.py:
105         * Scripts/webkitpy/port/westondriver_unittest.py:
106         * Scripts/webkitpy/port/win_unittest.py:
107         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
108         * Scripts/webkitpy/style/checker_unittest.py:
109         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
110         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
111         * Scripts/webkitpy/style/checkers/common_unittest.py:
112         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
113         * Scripts/webkitpy/style/checkers/exportfile_unittest.py:
114         * Scripts/webkitpy/style/checkers/js_unittest.py:
115         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
116         * Scripts/webkitpy/style/checkers/messagesin_unittest.py:
117         * Scripts/webkitpy/style/checkers/png_unittest.py:
118         * Scripts/webkitpy/style/checkers/python_unittest.py:
119         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
120         * Scripts/webkitpy/style/checkers/text_unittest.py:
121         * Scripts/webkitpy/style/checkers/watchlist_unittest.py:
122         * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
123         * Scripts/webkitpy/style/checkers/xml_unittest.py:
124         * Scripts/webkitpy/style/error_handlers_unittest.py:
125         * Scripts/webkitpy/style/filereader_unittest.py:
126         * Scripts/webkitpy/style/filter_unittest.py:
127         * Scripts/webkitpy/style/main_unittest.py:
128         * Scripts/webkitpy/style/optparser_unittest.py:
129         * Scripts/webkitpy/style/patchreader_unittest.py:
130         * Scripts/webkitpy/test/finder_unittest.py:
131         * Scripts/webkitpy/test/main.py: Ordered imports.
132         * Scripts/webkitpy/test/main_unittest.py:
133         * Scripts/webkitpy/test/printer.py: Ordered imports.
134         (Printer.configure):
135         * Scripts/webkitpy/test/runner_unittest.py:
136         * Scripts/webkitpy/test/skip_unittest.py:
137         * Scripts/webkitpy/thirdparty/__init__.py:
138         (AutoinstallImportHook._install_irc):
139         (AutoinstallImportHook._install_unittest2): Deleted.
140         * Scripts/webkitpy/thirdparty/__init___unittest.py:
141         * Scripts/webkitpy/thirdparty/ordered_dict.py: Removed.
142         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
143         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
144         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
145         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
146         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
147         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
148         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
149         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
150         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
151         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
152         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
153         * Scripts/webkitpy/tool/commands/download_unittest.py:
154         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
155         * Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
156         * Scripts/webkitpy/tool/commands/queries_unittest.py:
157         * Scripts/webkitpy/tool/commands/queuestest.py:
158         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
159         * Scripts/webkitpy/tool/grammar_unittest.py:
160         * Scripts/webkitpy/tool/mocktool_unittest.py:
161         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
162         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
163         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
164         * Scripts/webkitpy/tool/servers/reflectionhandler_unittest.py:
165         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py:
166         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py:
167         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
168         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
169         * Scripts/webkitpy/tool/steps/commit_unittest.py:
170         * Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py:
171         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
172         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
173         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
174         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
175         * Scripts/webkitpy/tool/steps/steps_unittest.py:
176         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
177         * Scripts/webkitpy/tool/steps/update_unittest.py:
178         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
179         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
180         * Scripts/webkitpy/w3c/test_converter_unittest.py:
181         * Scripts/webkitpy/w3c/test_importer_unittest.py:
182         * Scripts/webkitpy/w3c/test_parser_unittest.py:
183
184 2014-09-30  Jake Nielsen  <jacob_nielsen@apple.com>
185
186         LayoutTestResults and ExpectedFailures should know about the
187         interrupted flag from the json results file
188         https://bugs.webkit.org/show_bug.cgi?id=137229
189
190         Reviewed by Daniel Bates.
191
192         Changes LayoutTestResults to use the interrupted flag instead of
193         counting failures.
194
195         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
196         (BuilderTest._install_fetch_build._mock_fetch_build):
197         (BuilderTest.test_latest_layout_test_results):
198         * Scripts/webkitpy/common/net/layouttestresults.py:
199         Removes notion of failure_limit_count, and adds
200         did_exceed_test_failure_limit.
201
202         (LayoutTestResults.results_from_string):
203         (LayoutTestResults.__init__):
204         (LayoutTestResults.did_exceed_test_failure_limit):
205         (LayoutTestResults): Deleted.
206         (LayoutTestResults.set_failure_limit_count): Deleted.
207         (LayoutTestResults.failure_limit_count): Deleted.
208         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
209         Removes unit test for failure_limit_count logic.
210
211         (LayoutTestResultsTest.test_set_failure_limit_count): Deleted.
212         * Scripts/webkitpy/common/net/resultsjsonparser.py:
213         Instead of providing a class method that returns a list of
214         TestResults objects, resultsjsonparser now provides a class
215         ParsedJSONResults that serves as an interface between the results.json
216         file and the rest of webkitpy.
217
218         (ParsedJSONResults):
219         (ParsedJSONResults.__init__):
220         (ParsedJSONResults.did_exceed_test_failure_limit):
221         (ParsedJSONResults.test_results):
222         (ResultsJSONParser): Deleted.
223         (ResultsJSONParser.parse_results_json): Deleted.
224         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
225         Updates the unit test so that it can test the new ResultsJSONParser
226         class.
227
228         (ParsedJSONResultsTest):
229         (test_basic):
230         (ResultsJSONParserTest): Deleted.
231         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
232         Updates the unit test to instantiate ResultsJSONParser objects rather
233         than simple lists of TestResult objects.
234
235         (MockCommitQueue.test_results):
236         (FailingTestCommitQueue.test_results):
237         (test_flaky_test_failure):
238         (test_failed_archive):
239         * Scripts/webkitpy/tool/bot/expectedfailures.py:
240         Updates ExpectedFailures to use the did_exceed_test_failure_limit
241         method rather than counting the number of failed tests.
242
243         (ExpectedFailures._should_trust):
244         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
245         Updates MockResults to more closely resemble the updated
246         LayoutTestResults class.
247
248         (MockResults.__init__):
249         (MockResults.did_exceed_test_failure_limit):
250         (ExpectedFailuresTest.test_can_trust_results):
251         (ExpectedFailuresTest.test_unexpected_failures_observed):
252         (ExpectedFailuresTest.test_unexpected_failures_observed_when_tree_is_hosed):
253         (MockResults.failure_limit_count): Deleted.
254         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
255         Removes a FIXME regarding the use of the
256         NON_INTERACTIVE_FAILURE_LIMIT_COUNT value.
257
258         (LayoutTestResultsReader.results):
259         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
260         Updates test to not check the now-nonexistant failure_count_limit
261         method.
262
263         (test_missing_unit_test_results_path):
264         (test_layout_test_results):
265         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
266         Accounts for name change: ResultsJSONParserTest ->
267         ParsedJSONParserTest.
268
269         (RebaselineTestTest.test_gather_baselines):
270
271 2014-09-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
272
273         [EFL] Rename TEST_THEME_DIR macro
274         https://bugs.webkit.org/show_bug.cgi?id=137244
275
276         Reviewed by Csaba Osztrogonác.
277
278         TEST_THEME_DIR is to get a path for default theme though, it has used TEST_ prefix.
279         DEFAULT_THEME_DIR is better than it.
280
281         * MiniBrowser/efl/main.c:
282         (window_create):
283         * TestWebKitAPI/efl/PlatformWebView.cpp:
284         (TestWebKitAPI::PlatformWebView::PlatformWebView):
285         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
286         (WTR::PlatformWebView::PlatformWebView):
287
288 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
289
290         Windows EWS went purple when it failed to build
291         https://bugs.webkit.org/show_bug.cgi?id=137267
292
293         Reviewed by Ryosuke Niwa.
294
295         * QueueStatusServer/app.yaml: Update the version.
296
297         * QueueStatusServer/model/attachment.py: (Attachment._calculate_queue_positions):
298         Make it work for style and win-ews queues.
299
300 2014-09-29  Filip Pizlo  <fpizlo@apple.com>
301
302         It should be fun and easy to run every possible JavaScript benchmark from the command line
303         https://bugs.webkit.org/show_bug.cgi?id=137245
304
305         Reviewed by Oliver Hunt.
306         
307         We previously had Tools/Scripts/bencher.  Then we stopped adding things to it because we
308         weren't sure about the licensing of things like Kraken and Octane.  Various people ended up
309         having their own private scripts for doing benchmark runs, and didn't share them in the open
310         source community, because of fears about the shady licensing of the benchmarks suites that
311         they were running. The dominant version of this was "run-jsc-benchmarks", which has a lot of
312         excellent power - it can run benchmarks through either jsc, DumpRenferTree, or
313         WebKitTestRunner; it can run tests on any number of remote machines; and it has inside
314         knowledge about how to run *a lot* of test suites. Many of those test suites are not public,
315         but some of them are. The non-public tests are exclusively those that were not made by any
316         WebKit contributor, but which JSC/WebKit devs found useful for testing.
317
318         This fixes this weirdness by releasing run-jsc-benchmarks. The paths to the test suites
319         whose licenses are incompatible with WebKit's (to the extent that they cannot be safely
320         checked into WebKit svn at all) can be run by passing the path to them via a configuration
321         file. The default configuration file is ~/.run-jsc-benchmarks. The most important benchmark
322         suites are Octane version 2 and Kraken version 1.1. We should probably check Octane 2 into
323         WebKit eventually because it seems that the license is fine. Kraken, on the other hand, will
324         probably never be checked in because there is no license text anywhere in that benchmark.
325         A valid ~/.run-jsc-benchmarks file will just be something like:
326         
327             {
328                 "OctanePath": "/path/to/Octane2",
329                 "KrakenPath": "/path/to/Kraken-1.1/tests/kraken-1.1"
330             }
331         
332         If your ~/.run-jsc-benchmarks file omits the directory for any particular test suite, then
333         run-jsc-benchmarks will just gracefully avoid running that test suite.
334         
335         Finally, a word about policy: it is understood that different organizations that do
336         development on JSC may find themselves having internal benchmarks that they cannot share
337         because of weird licensing. It happens - usually because the organization doing JSC
338         development found some test in the wild that is owned by someone else and therefore cannot
339         be shared. So, we should consider it acceptable to write patches against run-jsc-benchmarks
340         that add support for some new kind of benchmark suite even if the suite is not made public
341         as part of the same patch - so long as the patch isn't too invasive. An example of
342         non-invasiveness is the DSPJS suite, which is implemented using some new classes (like
343         DSPJSAmmoJSRegularBenchmark) and some calls to otherwise reusable functions (like
344         emitSelfContainedBenchRunCode). It is obviously super helpful if a benchmark suite can be
345         completely open-sourced and committed to the WebKit repo - but the reality is that this
346         can't always be done safely.
347
348         * Scripts/bencher: Removed.
349         * Scripts/run-jsc-benchmarks: Added.
350
351 2014-09-30  Roger Fong  <roger_fong@apple.com>
352
353         [Windows] Back to 2 child processes for NRWT on Windows.
354
355         * Scripts/webkitpy/port/win.py:
356         (WinPort.default_child_processes):
357         Changing the number of processes to 1 did not have an effect on the layout test results. 
358         It does introduce an issue with one of the workers hanging indefinitely and causing the 
359         layout tests to timeout as a whole occasionally, but we should just fix that.
360
361 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
362
363         Remove an accidentally committed line..
364
365         * QueueStatusServer/handlers/statusbubble.py:
366         (StatusBubble._build_bubble):
367
368 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
369
370         build.webkit.org/dashboard: Switch EWS view to using actual retry count
371         https://bugs.webkit.org/show_bug.cgi?id=137240
372
373         Reviewed by Ryosuke Niwa.
374
375         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
376         (EWSQueue.prototype.loadDetailedStatus):
377         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
378         (EWSQueueView.prototype._popoverContentForEWSQueue):
379         Use the new retry_count data member from JSON.
380
381         * QueueStatusServer/app.yaml: Updating the version.
382
383         * QueueStatusServer/handlers/queuestatusjson.py: (QueueStatusJSON._rows_for_work_items):
384         Instead of message_count, produce retry_count.
385
386 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
387
388         EWS doesn't need to show all the bubbles when a patch fails to apply
389         https://bugs.webkit.org/show_bug.cgi?id=137256
390
391         Reviewed by Ryosuke Niwa.
392
393         * QueueStatusServer/app.yaml: Updated app version.
394
395         * QueueStatusServer/handlers/statusbubble.py:
396         (StatusBubble._build_bubble):
397         (StatusBubble._build_bubbles_for_attachment):
398         (StatusBubble.get):
399         * QueueStatusServer/templates/statusbubble.html:
400         When some queues fail to apply, and no queues had meaningful output (meaning that
401         they will almost certainly fail to apply later), we can show a single bubble
402         telling the user just that.
403
404 2014-09-30  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
405
406         [EFL] Bump EFL version to 1.11.2
407         https://bugs.webkit.org/show_bug.cgi?id=137118
408
409         Reviewed by Gyuyoung Kim.
410
411         Disable NEON for EFL build because the build system doesn't pass the necessary -mfpu=neon flag to the compiler.
412         Tools/efl/patches/ecore.patch: Removed, because this fix is already in EFL.
413
414         * efl/jhbuild.modules:
415         * efl/patches/ecore.patch: Removed.
416
417 2014-09-30  Carlos Garcia Campos  <cgarcia@igalia.com>
418
419         REGRESSION(r173929): [GTK] TestInspector fails after r173929
420         https://bugs.webkit.org/show_bug.cgi?id=137247
421
422         Reviewed by Philippe Normand.
423
424         Wait until can-attach property changes before trying to attach the
425         inspector after resizing the view.
426
427         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp:
428         (testInspectorDefault):
429
430 2014-09-30  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
431
432         Require Python 2.7 version
433         https://bugs.webkit.org/show_bug.cgi?id=137112
434
435         Reviewed by Csaba Osztrogonác.
436
437         * Scripts/ensure-valid-python:
438         (checkPythonVersion):
439         * Scripts/webkitpy/common/version_check.py:
440
441 2014-09-30  Martin Hock  <mhock@apple.com>
442
443         Skip a JSC test after r174036.
444         https://bugs.webkit.org/show_bug.cgi?id=137236
445
446         Reviewed by Csaba Osztrogonác.
447
448         * Scripts/run-javascriptcore-tests:
449
450 2014-09-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
451
452         [GTK] [EFL] Install TestNetscapePlugin apart from the other libs.
453         https://bugs.webkit.org/show_bug.cgi?id=137212
454
455         This moves TestNetscapePlugin to a new folder (lib/plugins).
456         We should not use the same directory for TestNetscapePlugin and
457         the other libraries, because we end up scanning all the .so in the
458         lib dir for every test.
459
460         Reviewed by Carlos Garcia Campos.
461
462         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Set LIBRARY_OUTPUT_DIRECTORY to lib/plugins.
463         * Scripts/webkitpy/port/efl.py:
464         (EflPort.setup_environ_for_server): Update plugin path.
465         * Scripts/webkitpy/port/gtk.py:
466         (GtkPort.setup_environ_for_server): Update plugin path.
467         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Update plugin path.
468
469 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
470
471         A small change to EWS bubble text. Explain why there are messages for ineligible patches.
472
473         Rubber-stamped by Tim Horton.
474
475         * QueueStatusServer/app.yaml:
476         * QueueStatusServer/handlers/statusbubble.py:
477         (StatusBubble._build_bubble):
478
479 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
480
481         Typo fix, suggested by Tim Horton.
482
483         * QueueStatusServer/handlers/statusbubble.py:
484         (StatusBubble._build_message_for_provisional_failure):
485
486 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
487
488         Improve Bugzilla status bubbles
489         https://bugs.webkit.org/show_bug.cgi?id=137232
490
491         Reviewed by Ryosuke Niwa.
492
493         * QueueStatusServer/app.yaml: Will update again with an actual version when landing.
494
495         * QueueStatusServer/handlers/statusbubble.py: Eliminated yellow color, added
496         blue and orange. Significantly extended tooltips. Made bubbles show up even for queues
497         that are stuck, as it was only confusing that they disappeared after 99.
498
499         * QueueStatusServer/model/attachment.py: Removed functionality that was only used
500         by old bubbles. We need a lot more information to determine color, so the implementation
501         can not be here.
502
503         * QueueStatusServer/templates/statusbubble.html: Updated colors in CSS, made bubbles
504         always have a link for consistency. Added code to convert timestamps in tooltips
505         to local time zone.
506
507 2014-09-29  Commit Queue  <commit-queue@webkit.org>
508
509         Unreviewed, rolling out r174045.
510         https://bugs.webkit.org/show_bug.cgi?id=137231
511
512         Introduced a crash during page loading tests on Mac (Requested
513         by rniwa on #webkit).
514
515         Reverted changeset:
516
517         "Replace OSObjectPtr with RetainPtr/adoptOS"
518         https://bugs.webkit.org/show_bug.cgi?id=137158
519         http://trac.webkit.org/changeset/174045
520
521 2014-09-29  Tim Horton  <timothy_horton@apple.com>
522
523         Add Jake as a contributor.
524
525         * Scripts/webkitpy/common/config/contributors.json:
526
527 2014-09-29  Roger Fong  <roger_fong@apple.com>
528
529         [Windows] Skip a javascriptcore test following r174036.
530
531         * Scripts/run-javascriptcore-tests:
532
533 2014-09-29  Roger Fong  <roger_fong@apple.com>
534
535         [Windows] Reduce number of processes used by NRWT on Windows to 1.
536
537         * Scripts/webkitpy/port/win.py:
538         (WinPort.default_child_processes):
539         Reduce number of processes to 1 so we can get a good baseline for what failures
540         we should be expecting to see from the Windows bots.
541
542 2014-09-29  Darin Adler  <darin@apple.com>
543
544         Tweak and tighten SVG font converter
545         https://bugs.webkit.org/show_bug.cgi?id=136956
546
547         Reviewed by Myles Maxfield.
548
549         I was investigating behavior of String::toInt, String::toDouble, and
550         String::toFloat for various failure cases, and decided to start some
551         unit tests for those functions here.
552
553         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
554         (TestWebKitAPI::TEST): Addded a first small bit of StringToInt and
555         StringToDouble testing.
556
557 2014-09-29  Philippe Normand  <pnormand@igalia.com>
558
559         [GTK][CMake] TestWebCore target build sometimes fail
560         https://bugs.webkit.org/show_bug.cgi?id=137207
561
562         Reviewed by Csaba Osztrogon.
563
564         * TestWebKitAPI/PlatformGTK.cmake: Make sure the forwarding
565         headers are generated before the TestWebCore target is built.
566
567 2014-09-29  Carlos Garcia Campos  <cgarcia@igalia.com>
568
569         [GTK] Remove IntPointGtk.cpp and IntRectGtk.cpp
570         https://bugs.webkit.org/show_bug.cgi?id=137209
571
572         Reviewed by Philippe Normand.
573
574         * TestWebKitAPI/PlatformGTK.cmake: Remove unneeded IntRectGtk.cpp
575         from the WebCore test sources.
576
577 2014-09-28  Myles C. Maxfield  <mmaxfield@apple.com>
578
579         Allow webkit-patch upload to respect the --directory argument with git checkouts
580         https://bugs.webkit.org/show_bug.cgi?id=137166
581
582         Reviewed by Darin Adler.
583
584         We simply hadn't plumbed it through.
585
586         * Scripts/webkitpy/common/checkout/scm/detection.py:
587         (SCMDetector.detect_scm_system):
588         * Scripts/webkitpy/common/checkout/scm/git.py:
589         (Git.__init__):
590         (Git.changed_files):
591
592 2014-09-26  Sam Weinig  <sam@webkit.org>
593
594         Replace OSObjectPtr with RetainPtr/adoptOS
595         https://bugs.webkit.org/show_bug.cgi?id=137158
596
597         Reviewed by Dan Bernstein.
598
599         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
600         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp: Removed.
601         * TestWebKitAPI/Tests/WTF/darwin/RetainPtrOSObject.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp.
602         Rename and change test to use RetainPtr. Remove now unneeded part testing WTF::retainOSObject/WTF::releaseOSObject.
603
604 2014-09-26  Filip Pizlo  <fpizlo@apple.com>
605
606         Disable function.arguments
607         https://bugs.webkit.org/show_bug.cgi?id=137167
608
609         Rubber stamped by Geoffrey Garen
610         
611         Enable the feature by default during tests.
612
613         * Scripts/run-jsc-stress-tests:
614
615 2014-09-26  Beth Dakin  <bdakin@apple.com>
616
617         Many platform/mac-wk2/tiled-drawing/ tests fail when run on a retina device
618         https://bugs.webkit.org/show_bug.cgi?id=137089
619
620         Reviewed by Tim Horton.
621
622         This is a little sneaky since updateWindowScaleForTest() should ensure that these 
623         tests run at 1x, but that code does not seem to execute at the right time for 
624         these tests, so if we just ensure we start out at 1x, that appears to fix these 
625         tests and does not break the HiDPI tests either.
626         * WebKitTestRunner/TestController.cpp:
627         (WTR::TestController::createWebViewWithOptions):
628
629 2014-09-26  Roger Fong  <roger_fong@apple.com>
630
631         [Windows] Decrease default number of child processes used by Windows.
632
633         * Scripts/webkitpy/port/win.py:
634         (WinPort.default_child_processes):
635         Having too many seems to cause many tests to crash or timeout. 
636         We may even need to make it have only 1 child process if we’re still seeing problems after this.
637
638 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
639
640         Mac EWS bots do not keep logs as promised
641         https://bugs.webkit.org/show_bug.cgi?id=137151
642
643         Reviewed by Ryosuke Niwa.
644
645         * EWSTools/start-queue-mac.sh: Actually keep the logs for 14 days.
646
647 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
648
649         Get rid of webkit-queues dashboard
650         https://bugs.webkit.org/show_bug.cgi?id=137141
651
652         Reviewed by Ryosuke Niwa.
653
654         * QueueStatusServer/app.yaml: Updated version.
655
656         * QueueStatusServer/templates/dashboard.html: Removed.
657         * QueueStatusServer/handlers/dashboard.py: Removed.
658         * QueueStatusServer/main.py:
659         Kill it!
660
661         * QueueStatusServer/stylesheets/common.css: Copied from Tools/QueueStatusServer/stylesheets/dashboard.css.
662         (.status-cell): Deleted.
663         (.status-cell:hover): Deleted.
664         (.status-cell.pass): Deleted.
665         (.status-cell.fail): Deleted.
666         (.status-cell.pending): Deleted.
667         (.status-cell.error): Deleted.
668         * QueueStatusServer/stylesheets/dashboard.css: Removed.
669         * QueueStatusServer/templates/activebots.html:
670         * QueueStatusServer/templates/patch.html:
671         * QueueStatusServer/templates/queuestatus.html:
672         * QueueStatusServer/templates/recentstatus.html:
673         Renamed dashboard.css to common.css, and removed dashboard-only rules.
674
675 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
676
677         Get rid of Retry status in webkit-queues
678         https://bugs.webkit.org/show_bug.cgi?id=137135
679
680         Reviewed by Ryosuke Niwa.
681
682         * QueueStatusServer/config/messages.py: Removed Retry.
683
684         * QueueStatusServer/handlers/releasepatch.py: This is now straightforward, as it
685         no longer needs to check the latest status. It just always both unlocks the patch
686         and removes it from WorkItems.
687
688         * QueueStatusServer/handlers/submittoews.py: (SubmitToEWS._should_add_to_ews_queue):
689         I don't understand why we even needed to check for retries here, but now that there
690         are no retries, that code can go to /dev/null.
691
692         * QueueStatusServer/loggers/recordpatchevent.py:
693         (RecordPatchEvent.started):
694         (RecordPatchEvent.retrying): Deleted.
695         Fixed retry counting, it should work for all queues now.
696
697         * QueueStatusServer/model/queuestatus.py:
698         (QueueStatus.is_retry_request): Deleted. These are no more.
699
700         * Scripts/webkitpy/common/net/statusserver_mock.py:
701         (MockStatusServer.release_lock):
702         * Scripts/webkitpy/tool/commands/queues_unittest.py:
703         Did whatever it took to keep passing the tests. The particular test doesn't seem
704         quite right, but whatever.
705
706         * Scripts/webkitpy/tool/commands/queues.py:
707         (CommitQueue.process_work_item): Instead of posting a retry status, just unlock
708         and let others pick up. Also, added explicit returns for clarity.
709         (AbstractPatchQueue._did_retry): Deleted.
710
711 2014-09-26  Csaba Osztrogonác  <ossy@webkit.org>
712
713         [EFL] Fix the gst-libav build on ARM Thumb2
714         https://bugs.webkit.org/show_bug.cgi?id=137022
715
716         Reviewed by Zoltan Herczeg.
717
718         * efl/jhbuild.modules:
719         * efl/patches/gst-libav.patch: Added.
720
721 2014-09-26  Akos Kiss  <akiss@inf.u-szeged.hu>
722
723         [EFL] Bump up dependencies not to conflict with the GTK port.
724         https://bugs.webkit.org/show_bug.cgi?id=137143
725
726         Reviewed by Gyuyoung Kim.
727
728         Tools/efl/install-dependencies and Tools/gtk/install-dependencies keep
729         installing and removing different versions of libgnutls-dev, thus
730         hindering the development for both ports on the same machine. GTK is
731         using the newer version of the package, now bumping up EFL to use the 
732         same.
733
734         * efl/install-dependencies:
735
736 2014-09-25  Rohit Kumar  <kumar.rohit@samsung.com>
737
738         [EFL][WK2] Minibrowser : Fix the 'Escape' button issue to exit fullscreen
739         https://bugs.webkit.org/show_bug.cgi?id=136854
740
741         Reviewed by Gyuyoung Kim.
742
743         'Escape' key should exit fullscreen first and then should be used to stop page load.
744
745         * MiniBrowser/efl/main.c:
746         (on_key_down):
747
748 2014-09-25  Dean Jackson  <dino@apple.com>
749
750         Add Said to the contributors list so his name completes in bugzilla.
751
752         * Scripts/webkitpy/common/config/contributors.json:
753
754 2014-09-25  Alexey Proskuryakov  <ap@apple.com>
755
756         EWS only repeats its cycle every two hours
757         https://bugs.webkit.org/show_bug.cgi?id=137129
758
759         Reviewed by Ryosuke Niwa.
760
761         * QueueStatusServer/app.yaml: Updated version.
762
763         * QueueStatusServer/config/queues.py: Moved timeout from activeworkitems.py to configuration.
764
765         * QueueStatusServer/handlers/releaselock.py: Added. Releases the lock without removing
766         the patch from work items.
767
768         * QueueStatusServer/index.yaml: No real change, just let AppEngine have its way with entry order.
769
770         * QueueStatusServer/main.py: Added release-lock.
771
772         * QueueStatusServer/model/activeworkitems.py:
773         (ActiveWorkItems.deactivate_expired): Use timeout from configuration.
774
775         * QueueStatusServer/model/workitems.py: Added move_to_end. When we unlock a patch,
776         we don't want it to be immediately picked up again, it's better to give other patches
777         a chance.
778
779         * QueueStatusServer/templates/releaselock.html: Added. Not sure why all commands have
780         these interactive versions, but OK.
781
782         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: (AbstractEarlyWarningSystem.review_patch):
783         Unlock the patch when a non-final failure occurs (e.g. can't build even without the patch,
784         or svn is down).
785
786         * Scripts/webkitpy/tool/commands/queues.py:
787         (AbstractReviewQueue.process_work_item): Do not try/catch ScriptError around review_patch.
788         Style queue never raises these, and EWS already calls _did_fail, before re-throwing,
789         meaning that these handlers could never do the right thing. We'd either get a duplicate
790         _did_fail, or try to unlock an already unlocked patch.
791         (StyleQueue.review_patch): Unlock the patch on transient failure (such as svn failure),
792         making it eligible for retry immediately.
793
794         * Scripts/webkitpy/common/net/statusserver.py:
795         (StatusServer._post_release_lock):
796         (StatusServer.release_lock):
797         Added a call to release-lock.
798
799 2014-09-25  Roger Fong  <roger_fong@apple.com>
800
801         [Windows] Followup to r173972. Don’t set child process to none before reading from stdout.
802
803         * Scripts/webkitpy/common/system/path.py:
804         (_CygPath.convert):
805
806 2014-09-25  Roger Fong  <roger_fong@apple.com>
807
808         [Windows] Close stdin to force a flush to stdout if no test path is read during layout tests.
809
810         * Scripts/webkitpy/common/system/path.py:
811         (_CygPath.convert):
812
813 2014-09-25  Carlos Garcia Campos  <cgarcia@igalia.com>
814
815         [Gtk] build.sh needs a -- before make options when the build command is cmake --build
816         https://bugs.webkit.org/show_bug.cgi?id=136377
817
818         Reviewed by Philippe Normand.
819
820         * Scripts/webkitdirs.pm:
821         (buildCMakeGeneratedProject): Only use the build.sh script if it exists.
822
823 2014-09-25  Akos Kiss  <akiss@inf.u-szeged.hu>
824
825         [EFL] Split the list of dependencies to make sure that at least the universally available packages get installed
826         https://bugs.webkit.org/show_bug.cgi?id=137117
827
828         Tools/efl/install-dependencies relies on apt-get to install packages.
829         Unfortunately, if a package does not exist (e.g., for a given
830         architecture) then apt-get install is not able to ignore the missing
831         package and install the rest but fails to run entirely (and there
832         seems to be no intent to change this behaviour).
833
834         On ARM64, the luajit package is missing and currently it needs manual
835         editing of install-dependencies to get the script install as much as it
836         can.
837
838         This patch separates the installation of the universally available
839         packages from those which might not be available for all architectures.
840
841         Reviewed by Gyuyoung Kim.
842
843         * efl/install-dependencies:
844
845 2014-09-25  Csaba Osztrogonác  <ossy@webkit.org>
846
847         Remove WinCE port from trunk
848         https://bugs.webkit.org/show_bug.cgi?id=136951
849
850         Reviewed by Alex Christensen.
851
852         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
853         (_should_file_trigger_build):
854         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
855         (ShouldBuildTest):
856         * CMakeLists.txt:
857         * DumpRenderTree/win/DRTDataObject.cpp:
858         (DRTDataObject::CopyMedium):
859         * Scripts/build-webkit:
860         * Scripts/webkit-build-directory:
861         * Scripts/webkitdirs.pm:
862         (argumentsForConfiguration):
863         (builtDylibPathForName):
864         (isAppleWinWebKit):
865         (launcherPath):
866         (launcherName):
867         (shouldRemoveCMakeCache):
868         (cmakeBasedPortArguments):
869         (cmakeBasedPortName):
870         (isCMakeBuild):
871         (isWinCE): Deleted.
872         (determineIsWinCE): Deleted.
873         * Scripts/webkitperl/FeatureList.pm:
874         * Scripts/webkitpy/port/port_testcase.py:
875         (test_apache_config_file_name_for_platform):
876         * TestWebKitAPI/config.h:
877         * WinCELauncher/CMakeLists.txt: Removed.
878         * WinCELauncher/main.cpp: Removed.
879         * gtk/manifest.txt:
880
881 2014-09-23  David Farler  <dfarler@apple.com>
882
883         [iOS] run-webkit-tests should support minor versions under devices and create a testing device under the right runtime
884         https://bugs.webkit.org/show_bug.cgi?id=136895
885
886         Reviewed by David Kilzer.
887
888         Create Device, DeviceType, and Runtime data classes.
889         Create Simulator class represent simctl output.
890
891         Wherever possible, use structured data classes anywhere a raw
892         identifier or UDID string was used for a cleaner implementation
893         and to encapsulate the inherent fragility of scraping simctl output.
894
895         Create a suitably named testing device if one doesn't exist.
896
897         Finally, accurately handle having multiple simulator runtimes (SDKs)
898         installed in the active Xcode.app bundle.
899
900         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
901         (_set_up_derived_options):
902         * Scripts/webkitpy/port/driver.py:
903         (IOSSimulatorDriver.cmd_line):
904         Construct DeviceType and Runtime objects from identifiers passed at the
905         command line, still providing sensible defaults for 32- and 64-bit testing.
906         * Scripts/webkitpy/port/ios.py:
907         (IOSSimulatorPort.__init__):
908         (IOSSimulatorPort.setup_test_run):
909         (IOSSimulatorPort):
910         (IOSSimulatorPort.testing_device):
911         Cache the testing device once it is created or found.
912         (IOSSimulatorPort.reset_preferences):
913         Get the device path from the Device object instead of consructing it
914         in the port class.
915         (IOSSimulatorPort.simulator_udid): Deleted.
916         Get the UDID from the testing_device :: Device object itself.
917         * Scripts/webkitpy/xcode/simulator.py:
918         Created Device, DeviceType, Runtime, and Simulator classes.
919         (get_runtimes): Deleted.
920         (get_devices): Deleted.
921         (get_device_types): Deleted.
922         (get_latest_runtime): Deleted.
923
924 2014-09-24  Roger Fong  <roger_fong@apple.com>
925
926         [Windows] Tentative fix for Windows test bots.
927
928         * Scripts/webkitpy/common/system/path.py:
929         (_CygPath.convert):
930
931 2014-09-24  Alexey Proskuryakov  <ap@apple.com>
932
933         Change more build.webkit.org links to https
934         https://bugs.webkit.org/show_bug.cgi?id=137049
935
936         Reviewed by Csaba Osztrogonác.
937
938         Fix appspot, svn.webkit.org and Trac links.
939
940         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
941         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
942         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
943         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
944         (ViewController.prototype._domForBuildName):
945         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
946         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
947         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
948         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
949         (.):
950         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
951         (EWS):
952         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
953         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js:
954         (TestHistory):
955         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
956
957 2014-09-24  Langó László  <llango.u-szeged@partner.samsung.com>
958
959         Update the list of u-szeged contributors.
960
961         Rubber-stamped by Csaba Osztrogonác <ossy@webkit.org>.
962
963         * Scripts/webkitpy/common/config/contributors.json:
964
965 2014-09-23  Roger Fong  <roger_fong@apple.com>
966
967         [Windows] More debugging for the Windows bots.
968
969         * Scripts/webkitpy/common/system/path.py:
970         (_CygPath):
971
972 2014-09-23  Roger Fong  <roger_fong@apple.com>
973
974         Unreviewed. Fix for r173899, those tabs should be spaces.
975
976         * Scripts/webkitpy/port/driver.py:
977         (Driver._command_from_driver_input):
978         (Driver): Deleted.
979
980 2014-09-23  Roger Fong  <roger_fong@apple.com>
981
982         [Windows] Add some logging to debug a problem with the Windows bots that causes layout tests to exit early.
983
984         * Scripts/webkitpy/port/driver.py:
985         (Driver):
986
987 2014-09-23  Jer Noble  <jer.noble@apple.com>
988
989         [Tools] git-commit uses wrong ChangeLog when run from a subdirectory
990         https://bugs.webkit.org/show_bug.cgi?id=137031
991
992         Reviewed by Joseph Pecoraro.
993
994         commit-log-editor is run from the top of the Git checkout, even when git-commit is invoked
995         from a subdirectory, making the parsed locations of ChangeLog files incorrect. Git provides
996         a mapping prefix in the GIT_PREFIX environment variable, so apply this prefix to the parsed
997         ChangeLog locations before passing them to createCommitMessage().
998
999         * Scripts/commit-log-editor:
1000
1001 2014-09-23  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1002
1003         W3C test importer should detect manual and reference tests according their filenames
1004         https://bugs.webkit.org/show_bug.cgi?id=133852
1005
1006         Reviewed by Bem Jones-Bey.
1007
1008         * Scripts/webkitpy/w3c/test_parser.py:
1009         (TestParser.analyze_test): Adding checks based on WPT filename rules.
1010         (TestParser.is_wpt_manualtest): Detecting whether the test is a manual test based on its filename.
1011         (TestParser):
1012         (TestParser.potential_ref_filename): Getting the potential reference filename of a test from its filename.
1013         (TestParser.is_wpt_reftest): Detecting whether the test is a ref test based on its filename.
1014         * Scripts/webkitpy/w3c/test_parser_unittest.py:
1015         (test_analyze_manual_wpt_test): Adding a test for a "-manual.html" file with testharness.js link in it. 
1016
1017 2014-09-23  Bem Jones-Bey  <bjonesbe@adobe.com>
1018
1019         Unreviewed, add Rebecca Hauck as a contributor.
1020
1021         * Scripts/webkitpy/common/config/contributors.json:
1022
1023 2014-09-23  David Kilzer  <ddkilzer@apple.com>
1024
1025         Switch build.webkit.org URLs to https
1026
1027         Reviewed by Lucas Forschler and Alexey Proskuryakov.
1028
1029         * TestResultServer/app.yaml: Update version to this commit
1030         revision.
1031
1032         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1033         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1034         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1035         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBuildbot.js:
1036         (WebKitBuildbot):
1037         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
1038         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1039         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
1040         (.):
1041         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1042         (WebKitBuildbot):
1043         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1044         * Scripts/webkitpy/common/config/urls.py:
1045         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1046         (test_builder_with_name):
1047         * Scripts/webkitpy/tool/commands/queries.py:
1048         (TreeStatus):
1049         * TestResultServer/generate_builders_json.py:
1050         (main):
1051         * TestResultServer/generate_builders_json_unittest.py:
1052         (GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
1053         (GenerateBuildersJsonTest):
1054         (GenerateBuildersJsonTest.test_generate_json_data):
1055         * TestResultServer/static-dashboards/builders.jsonp:
1056         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1057         (loadExpectationsLayoutTests):
1058         * TestResultServer/static-dashboards/timeline_explorer.js:
1059
1060 2014-09-23  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1061
1062         W3C test importer should copy .htaccess files
1063         https://bugs.webkit.org/show_bug.cgi?id=136850
1064
1065         Reviewed by Bem Jones-Bey.
1066
1067         * Scripts/webkitpy/w3c/test_importer.py:
1068         (TestImporter.should_skip_file): Helper function to check whether to skip file or not. Added ".htaccess" file specific check.
1069         (TestImporter):
1070         (TestImporter.find_importable_tests): Making use of new helper function.
1071
1072 2014-09-23  Alexey Proskuryakov  <ap@apple.com>
1073
1074         Trying to revive bot watcher's dashboard after HSTS.
1075
1076         Unreviewed.
1077
1078         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1079         (WebKitBuildbot): It looks like XMLHttpRequest may not like HSTS redirects, let's try to avoid these.
1080
1081 2014-09-23  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1082
1083         Make Tools/BuildSlaveSupport/wait-for-SVN-server.py handle server donwtime
1084         https://bugs.webkit.org/show_bug.cgi?id=137026
1085
1086         Reviewed by Csaba Osztrogonác.
1087
1088         * BuildSlaveSupport/wait-for-SVN-server.py:
1089         (getLatestSVNRevision):
1090         (waitForSVNRevision):
1091
1092 2014-09-23  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1093
1094         Remove unlinkZeroFiles from build-webkit
1095         https://bugs.webkit.org/show_bug.cgi?id=137018
1096
1097         Reviewed by Csaba Osztrogonác.
1098
1099         * Scripts/build-webkit:
1100         (unlinkZeroFiles): Deleted.
1101
1102 2014-09-23  Rohit Kumar  <kumar.rohit@samsung.com>
1103
1104         [GTK] Minibrowser : Add keyboard support for stop page load
1105         https://bugs.webkit.org/show_bug.cgi?id=136857
1106
1107         Reviewed by Philippe Normand.
1108
1109         Keyboard support to stop page load in GTK Minibrowser using F6 and Escape keys.
1110
1111         * MiniBrowser/gtk/BrowserWindow.c:
1112         (stopPageLoad): Callback to stop page load.
1113         (browser_window_init):
1114
1115 2014-09-22  Rohit Kumar  <kumar.rohit@samsung.com>
1116
1117         [EFL][WK2] Minibrowser : Add keyboard support for page reload while ignoring cache
1118         https://bugs.webkit.org/show_bug.cgi?id=136813
1119
1120         Reviewed by Gyuyoung Kim.
1121
1122         Ctrl+r is used for page reload along with F5. Ctrl+Shift+r and Ctrl+F5 is used for page reload while ignoring cache.
1123
1124         * MiniBrowser/efl/main.c:
1125         (on_key_down):
1126
1127 2014-09-22  Daniel Bates  <dabates@apple.com>
1128
1129         [Cocoa] Add UI delegate callback when window.close() is called
1130         https://bugs.webkit.org/show_bug.cgi?id=137008
1131         <rdar://problem/17801001>
1132
1133         Reviewed by Anders Carlsson.
1134
1135         Add a test to ensure that -[WKUIDelegatePrivate _webViewClose:] is called on window.close()
1136         for window opened via JavaScript (i.e. window.open()).
1137
1138         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1139         * TestWebKitAPI/Tests/WebKit2/open-and-close-window.html: Added.
1140         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm: Added.
1141
1142 2014-09-22  Youenn Fablet  <youennf@gmail.com>
1143
1144         W3C importer should import html files within resources folders
1145         https://bugs.webkit.org/show_bug.cgi?id=127548
1146
1147         Reviewed by Ryosuke Niwa.
1148         
1149         Import HTML files in any folder named "resources" even if file is not detected as a HTML test file 
1150
1151         * Scripts/webkitpy/w3c/test_importer.py:
1152         (TestImporter.find_importable_tests):
1153
1154 2014-09-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1155
1156         [GTK] Test /webkit2/WebKitWebView/can-show-mime-type fails if evince browser plugin is installed
1157         https://bugs.webkit.org/show_bug.cgi?id=136998
1158
1159         Reviewed by Philippe Normand.
1160
1161         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1162         (testWebViewCanShowMIMEType): Remove the check of PDF as
1163         unsupported MIME type.
1164
1165 2014-09-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1166
1167         Unreviewed. Fix WebKitGTKTranslations rule in watchlist.
1168
1169         In r145081 GTK+ translations were moved from Source/WebKit/gtk/po/
1170         to Source/WebCore/platform/gtk/po/ but the rule was not updated.
1171
1172         * Scripts/webkitpy/common/config/watchlist: Use
1173         Source/WebCore/platform/gtk/po/ as directory to watch for
1174         WebKitGTKTranslations rule and add berto and myself to the list of
1175         watchers.
1176
1177 2014-09-22  Ryuan Choi  <ryuan.choi@gmail.com>
1178
1179         Fix syntaxError in watchlist since r173594
1180         https://bugs.webkit.org/show_bug.cgi?id=136996
1181
1182         Reviewed by Philippe Normand.
1183
1184         * Scripts/webkitpy/common/config/watchlist: Removed unnecessary comma.
1185
1186 2014-09-20  Sam Weinig  <sam@webkit.org>
1187
1188         Make possible HashSet<std::unique_ptr<>>
1189         https://bugs.webkit.org/show_bug.cgi?id=136166
1190
1191         Reviewed by Darin Adler.
1192
1193         * TestWebKitAPI/Tests/WTF/CopyMoveCounter.h: Removed.
1194         * TestWebKitAPI/Counters.cpp: Added.
1195         * TestWebKitAPI/Counters.h: Copied from Tools/TestWebKitAPI/Tests/WTF/CopyMoveCounter.h.
1196         Move the CopyMoveCounter helper from CopyMoveCounter.h to Counters.h, and add a ConstructorDestructorCounter
1197         helper to the mix as well. Add Counters.cpp to allow for the global variables to be used in more than one
1198         translation unit.
1199     
1200         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1201         Add new files.
1202
1203         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1204         Add tests for using std::unique_ptr and OwnPtr as the key's of a HashMap.
1205
1206         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1207         Add tests for using std::unique_ptr and OwnPtr as the values of a HashSet.
1208
1209 2014-09-21  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1210
1211         run-webkit-tests should count tests submitted as absolute paths once
1212         https://bugs.webkit.org/show_bug.cgi?id=136848
1213
1214         Reviewed by Darin Adler.
1215
1216         * Scripts/webkitpy/port/base.py:
1217         (Port._expanded_paths): In case of absolute path, do not search for platform specific tests.
1218
1219 2014-09-19  Joseph Pecoraro  <pecoraro@apple.com>
1220
1221         JSStringRef leak on the leaks bot allocation under selectTextWithCriteriaCallback
1222         https://bugs.webkit.org/show_bug.cgi?id=136974
1223
1224         Reviewed by Chris Fleizach.
1225
1226         * DumpRenderTree/AccessibilityUIElement.cpp:
1227         (selectTextWithCriteriaCallback):
1228         Be sure to release the string if it was allocated.
1229
1230 2014-09-19  Alexey Proskuryakov  <ap@apple.com>
1231
1232         build.webkit.org/dashboard: Pending builds don't show up when there is a commit with no comments
1233         https://bugs.webkit.org/show_bug.cgi?id=136966
1234
1235         Reviewed by Daniel Bates.
1236
1237         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1238         (Trac.prototype._convertCommitInfoElementToObject): Tolerate these horrible commits.
1239
1240 2014-09-19  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1241
1242         [CoordinatedGraphics][EFL] window.scrollTo(x, y) doesn't work when fixed layout is enabled
1243         https://bugs.webkit.org/show_bug.cgi?id=136917
1244
1245         Reviewed by Darin Adler.
1246
1247         Added WKViewScrollTo.cpp and scrollTo.html to test this issue.
1248
1249         * TestWebKitAPI/PlatformEfl.cmake:
1250         * TestWebKitAPI/Tests/WebKit2/efl/WKViewScrollTo.cpp: Added.
1251         (TestWebKitAPI::didFinishLoadForFrame):
1252         (TestWebKitAPI::TEST):
1253         * TestWebKitAPI/Tests/WebKit2/efl/scrollTo.html: Added.
1254
1255 2014-09-19  Daniel Bates  <dabates@apple.com>
1256
1257         Always assume internal SDK when building configuration Production
1258         https://bugs.webkit.org/show_bug.cgi?id=136925
1259         <rdar://problem/18362399>
1260
1261         Reviewed by Dan Bernstein.
1262
1263         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1264         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1265         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1266         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1267
1268 2014-09-19  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1269
1270         WTR and DRT didReceiveAuthenticationChallengeInFrame should print messages consistently
1271         https://bugs.webkit.org/show_bug.cgi?id=136847
1272
1273         Added protection space host and port logging to WTR didReceiveAuthenticationChallengeInFrame.
1274
1275         Reviewed by Alexey Proskuryakov.
1276
1277         * WebKitTestRunner/TestController.cpp:
1278         (WTR::TestController::didReceiveAuthenticationChallengeInFrame):
1279
1280 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1281
1282         [GTK] Missing inspector files in the tarball
1283         https://bugs.webkit.org/show_bug.cgi?id=136952
1284
1285         Reviewed by Gustavo Noronha Silva.
1286
1287         * gtk/manifest.txt: Add
1288         Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
1289         to the tarball.
1290
1291 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1292
1293         Webkitgtk 2.5.3: tarball contains APPLE LICENSE file - stating not distributable
1294         https://bugs.webkit.org/show_bug.cgi?id=136632
1295
1296         Reviewed by Gustavo Noronha Silva.
1297
1298         * gtk/generate-inspector-gresource-manifest.py: Use an alias for
1299         the gtk icons.
1300         * gtk/manifest.txt: Only include the free icons in the tarball.
1301
1302 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1303
1304         [GTK] generate-inspector-gresource-manifest.py should receive the list of files from the makefile
1305         https://bugs.webkit.org/show_bug.cgi?id=136943
1306
1307         Reviewed by Philippe Normand.
1308
1309         Update the script to receive the list of files from the command
1310         line instead of scanning the given directories.
1311
1312         * gtk/generate-inspector-gresource-manifest.py:
1313         (get_filenames): Convert filenames to use relative paths.
1314         (find_all_files_in_directory): Deleted.
1315         (find_all_files_in_directory.select_file): Deleted.
1316
1317 2014-09-18  Tanay C  <tanay.c@samsung.com>
1318
1319         [EFL][WK2] Minibrowser : Support Zoom on Control key + scroll
1320         https://bugs.webkit.org/show_bug.cgi?id=136739
1321
1322         Reviewed by Gyuyoung Kim.
1323
1324         * MiniBrowser/efl/main.c: Add support for zoom on control key + mouse scroll
1325         (on_mouse_wheel): Modified.
1326
1327 2014-09-18  Carlos Garcia Campos  <cgarcia@igalia.com>
1328
1329         [GTK] Dot not allow to create delete-on-destroy GMainLoopSources
1330         https://bugs.webkit.org/show_bug.cgi?id=136923
1331
1332         Reviewed by Gustavo Noronha Silva.
1333
1334         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
1335         (TestWebKitAPI::TEST): Use the new API that doesn't allow to use
1336         the source.
1337
1338 2014-09-18  Csaba Osztrogonác  <ossy@webkit.org>
1339
1340         Fix countFailures of RunLLINTCLoopTests and Run32bitJSCTests (II)
1341         https://bugs.webkit.org/show_bug.cgi?id=136856
1342
1343         Reviewed by Darin Adler.
1344
1345         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1346         (RunLLINTCLoopTests.countFailures):
1347         (Run32bitJSCTests.countFailures):
1348         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1349         (RunLLINTCLoopTestsTest.test_failures):
1350         (RunLLINTCLoopTestsTest.test_failure):
1351         (RunLLINTCLoopTestsTest.test_no_failure):
1352         (Run32bitJSCTestsTest.test_failures):
1353         (Run32bitJSCTestsTest.test_failure):
1354         (Run32bitJSCTestsTest.test_no_failure):
1355
1356 2014-09-18  Zan Dobersek  <zdobersek@igalia.com>
1357
1358         GMainLoopSource is exposed to race conditions
1359         https://bugs.webkit.org/show_bug.cgi?id=135800
1360
1361         Reviewed by Carlos Garcia Campos.
1362
1363         Add unit tests for GMainLoopSource.
1364
1365         The tests check correct behavior of GMainLoopSource in various conditions --
1366         from the most simple rescheduling to rescheduling during dispatch, cancelling
1367         or destroying the GMainLoopSource during dispatch, proper destroy callback
1368         dispatching etc.
1369
1370         Scheduling both void (one-time) and bool (repeatable) callbacks is tested.
1371         State of the GMainLoopSource object (either ready, sheduled or active) is
1372         thoroughly tested throughout the lifetime of that object.
1373
1374         Still missing are tests for socket callbacks, which are a bit trickier because
1375         they rely on a GSocket object. The delete-on-destroy GMainLoopSource objects
1376         are also not tested thoroughly, simply because it is at the moment impossible
1377         to test that the objects are actually destroyed when the corresponding source
1378         is finally deleted.
1379
1380         * TestWebKitAPI/PlatformGTK.cmake:
1381         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp: Added.
1382         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
1383         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
1384         (TestWebKitAPI::GMainLoopSourceTest::runLoop):
1385         (TestWebKitAPI::GMainLoopSourceTest::delayedFinish):
1386         (TestWebKitAPI::GMainLoopSourceTest::finish):
1387         (TestWebKitAPI::GMainLoopSourceTest::source):
1388         (TestWebKitAPI::TEST):
1389
1390 2014-09-17  Ryuan Choi  <ryuan.choi@gmail.com>
1391
1392         Unreviewed, Update my email in contributors.json
1393
1394         * Scripts/webkitpy/common/config/contributors.json:
1395
1396 2014-09-17  Daniel Bates  <dabates@apple.com>
1397
1398         Unreviewed, rolling out r173695.
1399
1400         Broke building third-party Legacy WebKit apps; will
1401         investigate offline
1402
1403         Reverted changeset:
1404
1405         "[iOS] Make WebCore build with public iOS SDK"
1406         https://bugs.webkit.org/show_bug.cgi?id=136487
1407         http://trac.webkit.org/changeset/173695
1408
1409 2014-09-17  Daniel Bates  <dabates@apple.com>
1410
1411         [iOS] Make WebCore build with public iOS SDK
1412         https://bugs.webkit.org/show_bug.cgi?id=136487
1413
1414         Reviewed by David Kilzer.
1415
1416         Substitute <WebCore/MachVMSPI.h> for <mach/mach_vm.h>.
1417
1418         * DumpRenderTree/mac/CheckedMalloc.cpp:
1419
1420 2014-09-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1421
1422         [GTK] WebKitWebView::load-failed-with-tls-errors should receive the failing URI instead of a host
1423         https://bugs.webkit.org/show_bug.cgi?id=136889
1424
1425         Reviewed by Gustavo Noronha Silva.
1426
1427         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1428         (testLoadFailedWithTLSErrors): Check that LoadFailedWithTLSErrors
1429         event was added to the events vector.
1430         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
1431         (loadFailedCallback): Do not assume the web view URI is the
1432         failing URI when the load fails before the committed state.
1433         (loadFailedWithTLSErrorsCallback): Handle the case of load failure
1434         because of TLS errors can call LoadTrackingTest::loadFailedWithTLSErrors.
1435         (LoadTrackingTest::LoadTrackingTest): Connect to WebKitWebView::load-failed-with-tls-errors.
1436         (LoadTrackingTest::loadFailedWithTLSErrors): Add
1437         LoadFailedWithTLSErrors event to the events vector.
1438         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
1439
1440 2014-09-17  Renato Nagy  <rnagy@inf.u-szeged.hu>
1441
1442         [EFL][GTK] Remove WebKit1 related codes
1443         https://bugs.webkit.org/show_bug.cgi?id=136853
1444
1445         Reviewed by Csaba Osztrogonác.
1446
1447         Gtk and EFL WebKit1 ports no longer exist. Webkit1 related codes were deleted
1448         from scripts.
1449
1450         * BuildSlaveSupport/build.webkit.org-config/config.json:
1451         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1452         (Compile32bitJSC):
1453         (BuildAndTestWebKit2Factory):
1454         (CompileWebKit1Only): Deleted.
1455         (CompileWebKit2Only): Deleted.
1456         (BuildAndTestWebKit1OnlyFactory): Deleted.
1457         (BuildAndTestWebKit2OnlyFactory): Deleted.
1458         * Scripts/build-webkit:
1459         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
1460         * Scripts/webkitpy/common/config/ports.py:
1461         (GtkWK2Port.build_webkit_command):
1462         (EflWK2Port.build_webkit_command):
1463         * Scripts/webkitpy/common/config/ports_unittest.py:
1464         (DeprecatedPortTest.test_gtk_wk2_port):
1465         * Scripts/webkitpy/port/efl.py:
1466         (EflPort.build_webkit_command):
1467         * Scripts/webkitpy/port/gtk.py:
1468         (GtkPort._built_libraries_path):
1469         (GtkPort._search_paths):
1470         (GtkPort.test_expectations_file_position):
1471         (GtkPort.build_webkit_command):
1472         (GtkPort.run_webkit_tests_command):
1473         (GtkPort.warn_if_bug_missing_in_test_expectations): Deleted.
1474
1475 2014-09-16  Daniel Bates  <dabates@apple.com>
1476
1477         [iOS] Add iOS SDK name and version suffix to WebKitSystemInterface debug/release product name
1478         https://bugs.webkit.org/show_bug.cgi?id=136862
1479
1480         Reviewed by David Kilzer.
1481
1482         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1483         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1484         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Remove hardcoded iOS 8.0
1485         IPHONEOS_DEPLOYMENT_TARGET to ensure we link against the latest version of WebKitSystemInterface.
1486
1487 2014-09-12  Ryosuke Niwa  <rniwa@webkit.org>
1488
1489         Mac queue slaves should reboot every so often
1490         https://bugs.webkit.org/show_bug.cgi?id=136791
1491
1492         Reviewed by Alexey Proskuryakov.
1493
1494         Reboot Mac queue slaves every night between 1 A.M. and 6 A.M.
1495
1496         * EWSTools/start-queue-mac.sh:
1497
1498 2014-09-16  Csaba Osztrogonác  <ossy@webkit.org>
1499
1500         Unreviewed gardening, skip one more tests on Windows.
1501
1502         * Scripts/run-javascriptcore-tests:
1503
1504 2014-09-16  Csaba Osztrogonác  <ossy@webkit.org>
1505
1506         JSC test gardening
1507         https://bugs.webkit.org/show_bug.cgi?id=136823
1508
1509         Reviewed by Geoffrey Garen.
1510
1511         * Scripts/run-javascriptcore-tests: Skip tests on only the affected platforms.
1512
1513 2014-09-16  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1514
1515         Remove shouldAbortEarly cruft from master.cfg
1516         https://bugs.webkit.org/show_bug.cgi?id=136779
1517
1518         Reviewed by Csaba Osztrogonác.
1519
1520         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1521         (ConfigureBuild.start):
1522         (RunWebKitTests.start):
1523         (RunWebKit2Tests.start): Deleted.
1524
1525 2014-09-15  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1526
1527         Remove ORWT related crufts from webkitdirs.pm
1528         https://bugs.webkit.org/show_bug.cgi?id=136821
1529
1530         Reviewed by Alexey Proskuryakov.
1531
1532         * Scripts/webkitdirs.pm:
1533         (isPerianInstalled): Deleted.
1534         (determineIPhoneSimulatorVersion): Deleted.
1535         (iPhoneSimulatorVersion): Deleted.
1536         (isSnowLeopard): Deleted.
1537         (isLion): Deleted.
1538         (quitIOSSimulator): Deleted.
1539
1540 2014-09-15  Roger Fong  <roger_fong@apple.com>
1541
1542         Unreviewed. Skip yet another ecma/Date test that fails only on Windows.
1543         https://bugs.webkit.org/show_bug.cgi?id=25160
1544
1545         * Scripts/run-javascriptcore-tests:
1546
1547 2014-09-15  Lucas Forschler  <lforschler@apple.com>
1548
1549         Add another Apple build slave to the Mountain Lion Debug WK1 queue
1550         
1551         Rubber stamped by Matt Hanson.
1552         
1553         * BuildSlaveSupport/build.webkit.org-config/config.json:
1554
1555 2014-09-15  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
1556
1557         [EFL] Ecore and Eina are initialized twice in TestWebKitAPI
1558         https://bugs.webkit.org/show_bug.cgi?id=136822
1559
1560         Reviewed by Gyuyoung Kim.
1561
1562         In TestWebKitAPI/efl/main.cpp, ecore and eina modules are unnecessarily
1563         initialized as we already does it in PlatformWebView::PlatformWebView
1564         calling ewk_init(). The reason for that was to ensure testing for example,
1565         WTF where creating the view is not mandatory.
1566
1567         Call ewk_init() and ewk_shutdown() in TestWebKitAPI/efl/main.cpp
1568         in order to properly initalize and release EWebKit.
1569
1570         * TestWebKitAPI/PlatformEfl.cmake:
1571         * TestWebKitAPI/efl/PlatformWebView.cpp:
1572         (TestWebKitAPI::PlatformWebView::PlatformWebView):
1573         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
1574         * TestWebKitAPI/efl/main.cpp:
1575         (main):
1576
1577 2014-09-15  peavo@outlook.com  <peavo@outlook.com>
1578
1579         [WinCairo] Make it easier to enable/disable GStreamer.
1580         https://bugs.webkit.org/show_bug.cgi?id=135766
1581
1582         Reviewed by Brent Fulgham.
1583
1584         Make it possible to enable/disable GStreamer by editing the new user macro ENABLE_GSTREAMER_WINCAIRO.
1585
1586         * WinLauncher/WinMain.cpp: Compile fix when GStreamer is enabled.
1587
1588 2014-09-12  Brian J. Burg  <burg@cs.washington.edu>
1589
1590         Web Inspector: remind about rebaselining generator test results
1591         https://bugs.webkit.org/show_bug.cgi?id=136759
1592
1593         Reviewed by Joseph Pecoraro.
1594
1595         For now, we can implement this as a watchlist message. Add watchlist
1596         groups and messages for the inspector and web replay generators.
1597
1598         * Scripts/webkitpy/common/config/watchlist:
1599
1600 2014-09-12  Alexey Proskuryakov  <ap@apple.com>
1601
1602         build.webkit.org/dashboard: Overlapping text when status is long
1603         https://bugs.webkit.org/show_bug.cgi?id=136794
1604
1605         Reviewed by Timothy Hatcher.
1606
1607         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
1608         (.status-line): Replaces height with min-height.
1609
1610 2014-09-12  Timothy Hatcher  <timothy@apple.com>
1611
1612         Make Brian Burg a WebKit reviewer.
1613
1614         * Scripts/webkitpy/common/config/contributors.json: Move Brian Burg's entry.
1615
1616 2014-09-12  Alexey Proskuryakov  <ap@apple.com>
1617
1618         Multiple EWS or commit bots can pick up processing of the same patch
1619         https://bugs.webkit.org/show_bug.cgi?id=136793
1620
1621         Reviewed by Ryosuke Niwa.
1622
1623         Change timeout from one hour to two hours. This will let bots finish, and in the
1624         unlikely event of a bot being frozen, will only delay patch processing restart by
1625         one hour.
1626
1627         * QueueStatusServer/app.yaml:
1628         * QueueStatusServer/model/activeworkitems.py: (ActiveWorkItems.deactivate_expired):
1629
1630 2014-09-11  Andy Estes  <aestes@apple.com>
1631
1632         [WebKit2] WKImageCreateCGImage crashes when passed a null WKImage
1633         https://bugs.webkit.org/show_bug.cgi?id=136768
1634
1635         Reviewed by Tim Horton.
1636
1637         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1638         * TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp: Added.
1639         (TestWebKitAPI::TEST):
1640
1641 2014-09-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1642
1643         REGRESSION(r173423): CertificateInfo is never sent to the UI process when using shared secondary process model
1644         https://bugs.webkit.org/show_bug.cgi?id=136669
1645
1646         Reviewed by Antti Koivisto.
1647
1648         * Scripts/run-gtk-tests:
1649         (TestRunner): Unskip SSL test.
1650
1651 2014-09-12  Eric Carlson  <eric.carlson@apple.com>
1652
1653         Strip extraneous AVFoundation and CoreMedia logging
1654         https://bugs.webkit.org/show_bug.cgi?id=136747
1655
1656         Reviewed by Jer Noble.
1657
1658         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1659         (SingleTestRunner._run_compare_test): Allow the port to specify patterns to strip from stderr.
1660
1661         * Scripts/webkitpy/port/base.py:
1662         (Port.stderr_patterns_to_strip): Base class, empty list
1663
1664         * Scripts/webkitpy/port/driver.py:
1665         (DriverOutput.strip_stderror_patterns): Strip the specified patterns from stderr.
1666
1667         * Scripts/webkitpy/port/ios.py:
1668         (IOSSimulatorPort.stderr_patterns_to_strip): iOS patterns - there are none.
1669
1670         * Scripts/webkitpy/port/mac.py:
1671         (MacPort.stderr_patterns_to_strip): CoreMedia and AVFoundation logging we can ignore.
1672
1673
1674 2014-09-11  Michael Saboff  <msaboff@apple.com>
1675
1676         lldb_webkit.py:btjs doesn't work with release builds
1677         https://bugs.webkit.org/show_bug.cgi?id=136760
1678
1679         Reviewed by Jer Noble.
1680
1681         If we can't get a result calling JSC::ExecState::describeFrame(), try calling the
1682         mangled name _ZN3JSC9ExecState13describeFrameEv.  Also cleaned up the handling if
1683         we can't get a valid result from trying either call.  In that case, we fallback to
1684         just showing the PC.  Also added check for both entry points.  If neither is found,
1685         we issue a warning and output the stack trace without JavaScript annotations.
1686
1687         * lldb/lldb_webkit.py:
1688         (btjs):
1689
1690 2014-09-11  Rebecca Hauck  <rhauck@adobe.com>
1691
1692         webkitpy test failures from import-w3c-tests
1693         https://bugs.webkit.org/show_bug.cgi?id=136752
1694
1695         Reviewed by Bem Jones-Bey.
1696
1697         This patch fixes a bug in import-w3c-tests where we were appending
1698         the wrong set of files to the copy_list. This also updates the tests
1699         to clear the failures introduced in the patch for bug 135929.
1700
1701         * Scripts/webkitpy/w3c/test_converter_unittest.py:
1702         (W3CTestConverterTest.test_read_prefixed_property_list):
1703         * Scripts/webkitpy/w3c/test_parser.py:
1704         (TestParser.analyze_test):
1705         (TestParser.support_files):
1706         * Scripts/webkitpy/w3c/test_parser_unittest.py:
1707
1708 2014-09-10  Brent Fulgham  <bfulgham@apple.com>
1709
1710         Blink merge: Speculative fix for windows run-webkit-tests hangs
1711         https://bugs.webkit.org/show_bug.cgi?id=136727
1712
1713         Reviewed by Csaba Osztrogonác.
1714
1715         Merged from Blink (patch by Dirk Pranke):
1716         <https://chromium.googlesource.com/chromium/blink/+/0cdd98d44a20c3951562ccf8b08b1fefba8dac67%5E%21/#F0>
1717
1718         * Scripts/webkitpy/common/system/executive.py:
1719         (Executive.kill_process):
1720
1721 2014-09-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1722
1723         Added myself as a committer.
1724
1725         Unreviewed.
1726
1727         * Scripts/webkitpy/common/config/contributors.json:
1728
1729 2014-09-11  László Langó  <llango.u-szeged@partner.samsung.com>
1730
1731         [JavaScriptCore] Fix FTL on platform EFL.
1732         https://bugs.webkit.org/show_bug.cgi?id=133571
1733
1734         Reviewed by Filip Pizlo.
1735
1736         * efl/install-dependencies: Revert r169181.
1737         * efl/jhbuild.modules: Clone and build a custom branch.
1738         This branch contains some fix for FTL of platform EFL.
1739         The branch is a fork of llvm r206311.
1740
1741 2014-09-10  Tanay C  <tanay.c@samsung.com>
1742
1743         [EFL][WK2] Minibrowser : Shift+Scroll navigate to back or forward url's
1744         https://bugs.webkit.org/show_bug.cgi?id=136698
1745
1746         Reviewed by Gyuyoung Kim.
1747
1748         * MiniBrowser/efl/main.c: Add functionality to support shift + mouse scroll navigation
1749         (on_mouse_wheel): Added.
1750         (window_free):
1751         (window_create):
1752
1753 2014-09-10  Rohit Kumar  <kumar.rohit@samsung.com>
1754
1755         [EFL][WK2] Minibrowser : Add tooltip for toolbar buttons in Minibrowser
1756         https://bugs.webkit.org/show_bug.cgi?id=136284
1757
1758         Reviewed by Gyuyoung Kim.
1759
1760         * MiniBrowser/efl/main.c:
1761         (window_create):
1762
1763 2014-09-10  Rebecca Hauck  <rhauck@adobe.com>
1764
1765         import-w3c-tests doesn't handle relative paths to support files in ref files correctly
1766         https://bugs.webkit.org/show_bug.cgi?id=135929
1767
1768         Reviewed by Bem Jones-Bey.
1769
1770         The recent refactor of the W3C test repo falsified a bunch of assmumptions that
1771         were made when this script was originally written with respect to relative paths
1772         in ref files. This patch updates import-w3c-tests to update paths in ref files if
1773         they move relative to the test file.
1774
1775
1776         * Scripts/webkitpy/w3c/test_converter.py:
1777         (convert_for_webkit):
1778         (_W3CTestConverter.__init__):
1779         (_W3CTestConverter.convert_reference_relpaths):
1780         (_W3CTestConverter.convert_style_data):
1781         (_W3CTestConverter.convert_attributes_if_needed):
1782         * Scripts/webkitpy/w3c/test_importer.py:
1783         (TestImporter.find_importable_tests):
1784         (TestImporter.import_tests):
1785         * Scripts/webkitpy/w3c/test_parser.py:
1786         (TestParser.load_file):
1787         (TestParser.analyze_test):
1788         (TestParser.support_files):
1789
1790 2014-09-10  Michael Catanzaro  <mcatanzaro@igalia.com>
1791
1792         [GTK] allow overwriting destination of download
1793         https://bugs.webkit.org/show_bug.cgi?id=136372
1794
1795         Reviewed by Carlos Garcia Campos.
1796
1797         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1798         (downloadLocalFileSuccessfully): Split from testDownloadLocalFile
1799         (testDownloadLocalFile): Split off downloadLocalFileSuccessfully
1800         (createFileAtDestination): Added
1801         (testDownloadOverwriteDestinationAllowed): Added
1802         (testDownloadOverwriteDestinationDisallowed): Added
1803         (testDownloadLocalFileError): Use new DownloadErrorTest::ExpectedError
1804         (testDownloadRemoteFileError): Use new DownloadErrorTest::ExpectedError
1805         (beforeAll): New tests
1806
1807 2014-08-05  David Farler  <dfarler@apple.com>
1808
1809         iOS Simulator: run-webkit-tests chokes on unterminated UTF-8 when writing a test result
1810         https://bugs.webkit.org/show_bug.cgi?id=135551
1811
1812         Reviewed by Daniel Bates.
1813
1814         Prevent printing invalid Unicode strings going to stderr.
1815         Also, make filesystem.py more tolerant about receiving
1816         Unicode (encoded as UTF-8) when writing to files, in the
1817         rare case that an NSError description will make it to
1818         stderr, such as -[LTRelayController createUniqueApp].
1819
1820         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1821         (-[LTRelayController launchSimulator]): Removed.
1822         (-[LTRelayController createUniqueApp]):
1823         Don't explicitly try to uninstall the app. It is automatically handled
1824         when installing an app with the same bundle identifier.
1825         (-[LTRelayController start]):
1826         (-[LTRelayController bootDevice]): Removed.
1827         The device already boots as a part of starting the simulator. Attempting
1828         to boot a second time may cause spurious stderr output.
1829         * Scripts/webkitpy/port/driver.py:
1830         (IOSSimulatorDriver._setup_environ_for_driver):
1831         Explicitly set DEVELOPER_DIR once so xcode-select isn't called.
1832         Open the iOS Simulator once instead of the LayoutTestRelay trying
1833         to do it.
1834         * Scripts/webkitpy/port/ios.py:
1835         (IOSSimulatorPort._get_crash_log):
1836         Make sure stderr is at least an empty string.
1837         (IOSSimulatorPort):
1838         (IOSSimulatorPort.developer_dir):
1839         New property for setting up DEVELOPER_DIR in the driver environment.
1840
1841 2014-09-09  Dan Bernstein  <mitz@apple.com>
1842
1843         Clean up the MiniBrowser Xcode project
1844         https://bugs.webkit.org/show_bug.cgi?id=136684
1845
1846         Reviewed by Tim Horton.
1847
1848         * MiniBrowser/Configurations/Base.xcconfig: Enabled warnings recommended by Xcode 6.
1849         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Removed explicit linking against
1850         WebKit2.framework. Upgraded project file version.
1851
1852 2014-09-09  Daniel Bates  <dbates@webkit.org>
1853
1854         svn-{apply, unapply} fails to apply/unapply SVN 1.7 patch that adds new file with property change
1855         https://bugs.webkit.org/show_bug.cgi?id=136379
1856
1857         Reviewed by David Kilzer.
1858
1859         Fixes an issue where svn-{apply, unapply} fail to apply or unapply, respectively,
1860         a patch generated using Subversion 1.7.4 (r1295709) that both adds a new file F
1861         and sets a property on F (say, the executable bit).
1862
1863         * Scripts/svn-apply:
1864         (patch): Only add file if the diff has text chunks.
1865         * Scripts/svn-unapply:
1866         (patch): Only delete added file if the diff has text chunks.
1867
1868 2014-09-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1869
1870         [GTK] Unreviewed GTK gardening.
1871
1872         * Scripts/run-gtk-tests:
1873         (TestRunner): Skip TestSSL:webkit2/WebKitWebView/ssl (fails since r173423).
1874
1875 2014-09-09  Christophe Dumez  <cdumez@apple.com>
1876
1877         Update my email in contributors.json
1878         https://bugs.webkit.org/show_bug.cgi?id=136671
1879
1880         Reviewed by Andreas Kling.
1881
1882         * Scripts/webkitpy/common/config/contributors.json:
1883
1884 2014-09-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1885
1886         [EFL] Enable fixed layout by default
1887         https://bugs.webkit.org/show_bug.cgi?id=136607
1888
1889         Reviewed by Csaba Osztrogonác.
1890
1891         Fixed layout is being used by Tizen platform by default. However, the feature
1892         has still many defects now. So, we need to enable it by default, then should fix
1893         those bugs. 
1894
1895         * MiniBrowser/efl/main.c:
1896
1897 2014-09-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1898
1899         Remove FILTERS flag
1900         https://bugs.webkit.org/show_bug.cgi?id=136571
1901
1902         Reviewed by Darin Adler.
1903
1904         * Scripts/webkitperl/FeatureList.pm:
1905
1906 2014-09-08  Alexey Proskuryakov  <ap@apple.com>
1907
1908         Dashboard metrics should ignore commits that didn't trigger builds
1909         https://bugs.webkit.org/show_bug.cgi?id=136618
1910
1911         Reviewed by Darin Adler.
1912
1913         Commits that didn't trigger builds are ones like ChangeLog updates, patches for
1914         other platforms etc. It does not make sense to count wait time for these, as it
1915         can be arbitrarily long.
1916
1917         The new algorithm is much slower asymptotically, but it's OK, computers are fast.
1918
1919         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1920         (BuildbotIteration.prototype._parseData): Record changes that triggered the iteration.
1921
1922         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
1923         We used to walk the timeline to see which revisions are fully tested, but that's not
1924         correct. A revision that's only tested by a subset of queues finishes independently
1925         of another that's tested by another subset. Now, we just search for the answer for
1926         each revision individually.
1927
1928         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js:
1929         (MetricsView.prototype._update.appendQueueResults): Added worst revision number, which
1930         the analyzer now reports. Removed best time, which is more confusing than meaningful.
1931
1932 2014-09-08  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1933
1934         Remove EWebLauncher from webkitdirs.pm
1935         https://bugs.webkit.org/show_bug.cgi?id=136622
1936
1937         Reviewed by Gyuyoung Kim.
1938
1939         * Scripts/webkitdirs.pm:
1940         (launcherName):
1941
1942 2014-09-06  Sam Weinig  <sam@webkit.org>
1943
1944         XPCPtr should be converted into an all purpose smart pointer for os_objects
1945         https://bugs.webkit.org/show_bug.cgi?id=136602
1946
1947         Reviewed by Darin Adler.
1948
1949         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1950         * TestWebKitAPI/Tests/WTF/darwin: Added.
1951         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp: Added.
1952         Add basic unit tests for OSObjectPtr.
1953
1954 2014-09-06  Saam Barati  <saambarati1@gmail.com>
1955
1956         Unreviewed. Add myself as a committer.
1957
1958         * Scripts/webkitpy/common/config/contributors.json:
1959
1960 2014-09-06  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1961
1962         Unreviewed, EFL build fix when SHARED_CORE is on.
1963
1964         * TestWebKitAPI/PlatformEfl.cmake:
1965
1966 2014-09-05  Lucas Forschler  <lforschler@apple.com>
1967
1968         <https://webkit.org/b/136586> Add bots to Apple build/test queues
1969         
1970         Reviewed by Daniel Bates.
1971
1972         * BuildSlaveSupport/build.webkit.org-config/config.json:
1973
1974 2014-09-05  Alexey Proskuryakov  <ap@apple.com>
1975
1976         Buildbot metrics page gives wrong results after a new bot gets added
1977         https://bugs.webkit.org/show_bug.cgi?id=136516
1978
1979         Reviewed by Tim Horton.
1980
1981         Part 2: Fix elapsed times.
1982
1983         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
1984         (Analyzer.prototype._countTimes): Made lastTestedRevisionByQueue contain undefined values
1985         until the first build in a queue. This happens to work as needed with _fullyTestedRevisionNumber().
1986
1987 2014-09-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1988
1989         [SOUP] Implement ResourceResponse::platformSuggestedFilename() when USE(SOUP) is enabled.
1990         https://bugs.webkit.org/show_bug.cgi?id=136562
1991
1992         Reviewed by Martin Robinson.
1993
1994         * Scripts/run-gtk-tests:
1995         (TestRunner): Remove failure expectations for tests that now pass.
1996
1997 2014-09-04  Alexey Proskuryakov  <ap@apple.com>
1998
1999         Dashboard metrics page wastes a lot of time sorting iterations
2000         https://bugs.webkit.org/show_bug.cgi?id=136559
2001
2002         Reviewed by Tim Horton.
2003
2004         Also fixes comments here and there, and adds a missing "var".
2005
2006         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2007         (BuildbotIteration.prototype._parseData):
2008         (BuildbotIteration.prototype._updateWithData):
2009         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2010         (BuildbotQueue.prototype.loadAll):
2011         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2012         (Analyzer.prototype._countTimes):
2013
2014 2014-09-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2015
2016         [GTK] Unreviewed GTK gardening.
2017
2018         * Scripts/run-gtk-tests:
2019         (TestRunner): Skip tests failing since r173272.
2020
2021 2014-09-04  Simon Fraser  <simon.fraser@apple.com>
2022
2023         Add some logging to help diagnose assertions in dumpWebViewAsPixelsAndCompareWithExpected() on bots
2024         https://bugs.webkit.org/show_bug.cgi?id=136561
2025
2026         Reviewed by Tim Horton.
2027         
2028         Log for calloc() and CGBitmapContextCreate() failures.
2029
2030         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2031         (createBitmapContext):
2032         (createBitmapContextFromWebView):
2033
2034 2014-09-04  Andy Estes  <aestes@apple.com>
2035
2036         Fix the Mac Production build after r173283.
2037
2038         * WebKitTestRunner/config.h: Reverted to defining WEBCORE_EXPORT for now.
2039
2040 2014-09-04  Brent Fulgham  <bfulgham@apple.com>
2041
2042         [Win] webkitpy test suite frequently fails to complete
2043         https://bugs.webkit.org/show_bug.cgi?id=136546
2044
2045         Reviewed by Daniel Bates.
2046
2047         Properly convert the ASCII crash log produced by ntsd into
2048         a unicode string as early as possible so that we handle it
2049         properly when generating our logs and other test support output.
2050
2051         We were mixing ASCII/unicode strings under Windows, which was
2052         causing test system failures when we processed some crash logs.
2053
2054         Also do a better job of handling garbage pid entries in the
2055         Cygwin lock files.
2056
2057         * Scripts/webkitpy/common/system/crashlogs.py:
2058         (CrashLogs._find_newest_log_win): The ntsd '.logopen' command
2059         creates an ASCII file. Decode it as ASCII, not 'utf-8', and
2060         handle the strings as unicode from that point on.
2061         * Scripts/webkitpy/port/http_lock.py:
2062         (HttpLock._current_lock_pid): Add logging and handle case of
2063         the current_pid failing to cleanly convert to 'int'.
2064         * Scripts/webkitpy/port/win.py:
2065         (WinPort): Add 64-bit architecture as a known target for the
2066         Windows build.
2067
2068 2014-09-04  Andy Estes  <aestes@apple.com>
2069
2070         Address additional review feedback after landing r173283.
2071
2072         Reviewed by Daniel Bates.
2073
2074         * DumpRenderTree/config.h: Removed redundant includes.
2075         * TestWebKitAPI/config.h: Ditto.
2076         * WebKitTestRunner/config.h: Ditto.
2077
2078 2014-09-03  Andy Estes  <aestes@apple.com>
2079
2080         [Cocoa] Some WebKitLegacy headers migrated from WebCore incorrectly contain WEBCORE_EXPORT
2081         https://bugs.webkit.org/show_bug.cgi?id=136521
2082
2083         Reviewed by Anders Carlsson.
2084
2085         * DumpRenderTree/config.h: Included <WebCore/PlatformExportMacros.h> instead of defining WEBCORE_EXPORT.
2086         * TestWebKitAPI/config.h: Ditto.
2087         * WebKitTestRunner/config.h: Ditto.
2088
2089 2014-09-04  Alexey Proskuryakov  <ap@apple.com>
2090
2091         REGRESSION: Dashboard metrics page aggregation counts performance bots
2092         https://bugs.webkit.org/show_bug.cgi?id=136539
2093
2094         Reviewed by Tim Horton.
2095
2096         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
2097
2098 2014-09-04  Brent Fulgham  <bfulgham@apple.com>
2099
2100         [Win] Perl test fix.
2101
2102         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl: Correct test to check for
2103         VersionStamp.exe tool, not just the driver script.
2104
2105 2014-09-04  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2106
2107         Remove CSS_FILTERS flag
2108         https://bugs.webkit.org/show_bug.cgi?id=136529
2109
2110         Reviewed by Dirk Schulze.
2111
2112         * Scripts/webkitperl/FeatureList.pm:
2113
2114 2014-09-04  Commit Queue  <commit-queue@webkit.org>
2115
2116         Unreviewed, rolling out r173201.
2117         https://bugs.webkit.org/show_bug.cgi?id=136538
2118
2119         Improves the situation but also introduces additional crashes.
2120         (Requested by zdobersek on #webkit).
2121
2122         Reverted changeset:
2123
2124         "GMainLoopSource is exposed to race conditions"
2125         https://bugs.webkit.org/show_bug.cgi?id=135800
2126         http://trac.webkit.org/changeset/173201
2127
2128 2014-09-03  Alexey Proskuryakov  <ap@apple.com>
2129
2130         Buildbot metrics page gives wrong results after a new bot gets added
2131         https://bugs.webkit.org/show_bug.cgi?id=136516
2132
2133         Part 1: Fix red/green counters. Dashboard is considered green at a given time
2134         if all the bots that ever had results before this time are green.
2135
2136         This doesn't (and cannot) address situations where the bot gets removed and then
2137         re-added. It also gives wrong results after a bot gets removed, because it doesn't
2138         know that it was ever displayed on the dashboard.
2139
2140         Reviewed by Darin Adler.
2141
2142         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2143         (Analyzer.prototype._dashboardIsAllGreen):
2144         (Analyzer.prototype._updateStretchOfRedCounters):
2145         (Analyzer.prototype._countPercentageOfGreen):
2146         (Analyzer.prototype._allQueuesAreSuccessful): Deleted.
2147
2148 2014-09-03  Brent Fulgham  <bfulgham@apple.com>
2149
2150         [Win] Unreviewed test fix.
2151
2152         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl: Don't fail
2153         test if user doesn't have the VersionStamp.exe program.
2154
2155 2014-09-03  Dana Burkart  <dburkart@apple.com>
2156
2157         Unreviewed. Add myself as a committer.
2158
2159         * Scripts/webkitpy/common/config/contributors.json:
2160
2161 2014-09-03  Alexey Proskuryakov  <ap@apple.com>
2162
2163         build.webkit.org/dashboard performance popover is unstyled
2164         https://bugs.webkit.org/show_bug.cgi?id=136499
2165
2166         Reviewed by Tim Horton.
2167
2168         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
2169         (.performance-popover):
2170         (.performance-popover .dashboard-link):
2171
2172 2014-09-03  Saam Barati  <saambarati1@gmail.com>
2173
2174         Create tests for type profiling
2175         https://bugs.webkit.org/show_bug.cgi?id=136161
2176
2177         Reviewed by Geoffrey Garen.
2178
2179         Have run-javascriptcore-tests run the newly created
2180         tests for the type profiler.
2181
2182         * Scripts/run-javascriptcore-tests:
2183         * Scripts/run-jsc-stress-tests:
2184
2185 2014-09-03  Brent Fulgham  <bfulgham@apple.com>
2186
2187         [Win] Revise test environment for Windows build.
2188         https://bugs.webkit.org/show_bug.cgi?id=136486
2189
2190         Reviewed by David Kilzer.
2191
2192         The various calls to get the Safari path really only have
2193         meaning on the Mac. Other ports get access to the build
2194         and test environment separately, so remove the various
2195         checks in the Safari-specific code to simplify things.
2196
2197         Remove some 64-bit hacks used on Windows now that the
2198         various tools know how to find the 64-bit runtime environment.
2199
2200         * Scripts/run-javascriptcore-tests: 
2201         * Scripts/webkitdirs.pm:
2202         (safariPathFromSafariBundle): Revise to expect Mac.
2203         (installedSafariPath): Ditto.
2204         (safariPath): Ditto.
2205         (appleApplicationSupportPath): Get rid of 64-bit Windows hack.
2206         (setPathForRunningWebKitApp): Get rid of unused SafariPath
2207         argument for Windows runs.
2208
2209 2014-09-03  Dana Burkart  <dburkart@apple.com>
2210
2211         Dashboard should show performance bots.
2212         https://bugs.webkit.org/show_bug.cgi?id=136386
2213
2214         Reviewed by Alexey Proskuryakov.
2215
2216         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2217         (BuildbotIteration.prototype._parseData.collectPerfTestResults):
2218         (BuildbotIteration.prototype._parseData):
2219         Support possible performance failures.
2220
2221         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
2222         New QueueView to manage the way we present performance data.
2223
2224         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2225         (BuildbotQueue):
2226         Support new 'performance' and 'performanceTestName' keys.
2227
2228
2229         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2230         Add performance column to the main page.
2231
2232         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2233         (WebKitBuildbot):
2234         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2235         (body):
2236         Make sure everything fits on 13 inch screens.
2237
2238         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
2239
2240 2014-09-03  Zan Dobersek  <zdobersek@igalia.com>
2241
2242         GMainLoopSource is exposed to race conditions
2243         https://bugs.webkit.org/show_bug.cgi?id=135800
2244
2245         Reviewed by Carlos Garcia Campos.
2246
2247         Add a unit test for GMainLoopSource that tests different
2248         types of rescheduling tasks on already-active sources.
2249
2250         * TestWebKitAPI/PlatformGTK.cmake:
2251         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp: Added.
2252         (GMainLoopSourceTest::GMainLoopSourceTest):
2253         (GMainLoopSourceTest::~GMainLoopSourceTest):
2254         (GMainLoopSourceTest::runLoop):
2255         (GMainLoopSourceTest::finish):
2256         (GMainLoopSourceTest::source):
2257         (testGMainLoopSourceBasicRescheduling):
2258         (testGMainLoopSourceReentrantRescheduling):
2259         (testGMainLoopSourceDifferentThreadRescheduling):
2260         (beforeAll):
2261         (afterAll):
2262         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
2263         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
2264         (TestWebKitAPI::GMainLoopSourceTest::runLoop):
2265         (TestWebKitAPI::GMainLoopSourceTest::finish):
2266         (TestWebKitAPI::GMainLoopSourceTest::source):
2267         (TestWebKitAPI::TEST):
2268
2269 2014-09-02  Simon Fraser  <simon.fraser@apple.com>
2270
2271         Make sure WK1 prefs are initialized in MiniBrowser
2272         https://bugs.webkit.org/show_bug.cgi?id=136465
2273
2274         Reviewed by Tim Horton.
2275         
2276         Call -didChangeSettings from -awakeFromNib for WK1 windows just as we do
2277         for WK2 windows, to make sure that WebPreferences are updated (to get
2278         layer borders to work consistently).
2279
2280         * MiniBrowser/mac/WK1BrowserWindowController.m:
2281         (-[WK1BrowserWindowController awakeFromNib]):
2282
2283 2014-09-02  Renato Nagy  <rnagy@inf.u-szeged.hu>
2284
2285         check-webkit-style should complain about C++ comments in Platform.h
2286         https://bugs.webkit.org/show_bug.cgi?id=133802
2287
2288         Reviewed by Csaba Osztrogonác.
2289
2290         * Scripts/webkitpy/style/checkers/cpp.py:
2291         (check_platformh_comments):
2292         (_process_lines):
2293         (CppChecker):
2294         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2295         (CppStyleTest.test_platformh_comment):
2296
2297 2014-09-02  Brendan Long  <self@brendanlong.com>
2298
2299         [Gtk] Make install-dependencies work on Arch Linux
2300         https://bugs.webkit.org/show_bug.cgi?id=136374
2301
2302         Reviewed by Philippe Normand.
2303
2304         * gtk/install-dependencies: Add dependencies for pacman (Arch Linux).
2305
2306 2014-09-01  Brian J. Burg  <burg@cs.washington.edu>
2307
2308         Provide column numbers to DTrace willExecute/didExecute probes
2309         https://bugs.webkit.org/show_bug.cgi?id=136434
2310
2311         Reviewed by Antti Koivisto.
2312
2313         Create a directory for DTrace scripts. Add an example script that
2314         shows how to use static probes provided by JavaScriptCore's profiler.
2315
2316         * Scripts/dtrace/jsc-trace-profiler-events.d: Added.
2317
2318 2014-09-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2319
2320         [GTK] [JHBuild] Cyclic dependency between cairo and librsvg.
2321         https://bugs.webkit.org/show_bug.cgi?id=136431
2322
2323         Reviewed by Martin Robinson.
2324
2325         * gtk/jhbuild.modules: Disable cairo SVG testsuite.
2326         Add missing dependencies for librsvg (glib and cairo).
2327
2328 2014-09-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2329
2330         [GTK] install-dependencies don't installs dbus-launch that is needed for the API tests.
2331         https://bugs.webkit.org/show_bug.cgi?id=136425
2332
2333         Reviewed by Martin Robinson.
2334
2335         * gtk/install-dependencies: Add dbus-x11 to the list of packages needed for running the tests.
2336
2337 2014-09-01  Ryuan Choi  <ryuan.choi@samsung.com>
2338
2339         Update my list of email addresses in contributors.json
2340         https://bugs.webkit.org/show_bug.cgi?id=136424
2341
2342         Reviewed by Gyuyoung Kim.
2343
2344         * Scripts/webkitpy/common/config/contributors.json:
2345
2346 2014-08-30  Filip Pizlo  <fpizlo@apple.com>
2347
2348         [RJST] eager-no-cjit should really mean eager
2349         https://bugs.webkit.org/show_bug.cgi?id=136407
2350
2351         Reviewed by Mark Hahnenberg.
2352         
2353         At some point we made NO_CJIT_OPTIONS force threshold settings to something reasonable
2354         and well-known. But the way we appended options was such that NO_CJIT_OPTIONS came in
2355         after EAGER_OPTIONS. The whole point of "eager" was to use eager tier-up thresholds. This
2356         all meant that NO_CJIT_OPTIONS was overriding the eagerness of EAGER_OPTIONS, for the one
2357         threshold setting that NO_CJIT_OPTIONS was currently setting
2358         (thresholdForJITAfterWarmUp). The solution is to make sure that we always append
2359         NO_CJIT_OPTIONS before we append EAGER_OPTIONS.
2360         
2361         Luckily, no tests regressed during the time that we lost eager-no-cjit coverage.
2362
2363         * Scripts/run-jsc-stress-tests:
2364
2365 2014-08-29  Daniel Bates  <dabates@apple.com>
2366
2367         [iOS] Configure Xcode to build a command line tool for the iOS Simulator
2368         https://bugs.webkit.org/show_bug.cgi?id=136388
2369
2370         Reviewed by David Kilzer.
2371
2372         Add a script, called configure-xcode-for-ios-development, to configure Xcode to
2373         support building a command line tool for the iOS Simulator. You must run this
2374         script as root.
2375
2376         The script uses the xcspec files in the OS X SDK to create xcspec files in the
2377         iOS Simulator SDK with the product- and package- type definitions to build a
2378         command line tool, if applicable.
2379
2380         * Scripts/configure-xcode-for-ios-development: Added.
2381
2382 2014-08-29  Tim Horton  <timothy_horton@apple.com>
2383
2384         Remove Windows WebKit2 code from TestWebKitAPI
2385         https://bugs.webkit.org/show_bug.cgi?id=136385
2386
2387         Reviewed by Alexey Proskuryakov.
2388
2389         * TestWebKitAPI/PlatformUtilities.h:
2390         * TestWebKitAPI/PlatformWebView.h:
2391         (TestWebKitAPI::PlatformWebView::setParentWindowMessageObserver): Deleted.
2392         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
2393         (TestWebKitAPI::TEST): Deleted.
2394         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
2395         (TestWebKitAPI::TEST):
2396         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2397         (TestWebKitAPI::TEST):
2398         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp: Removed.
2399         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp: Removed.
2400         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp: Removed.
2401         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp: Removed.
2402         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp: Removed.
2403         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp: Removed.
2404         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp: Removed.
2405
2406 2014-08-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2407
2408         [JSC] Some JSC tests are dependent on the machine time zone.
2409         https://bugs.webkit.org/show_bug.cgi?id=136363
2410
2411         Reviewed by Filip Pizlo.
2412
2413         * Scripts/run-javascriptcore-tests: Export TZ environment variable to US/Pacific.
2414         Unskip the tests that were skipped on r99580.
2415
2416 2014-08-29  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2417
2418         [EFL] Remove non Coordinated Graphics code path from cmake build system after r142169
2419         https://bugs.webkit.org/show_bug.cgi?id=135560
2420
2421         Reviewed by Gyuyoung Kim.
2422
2423         * Scripts/webkitperl/FeatureList.pm: Removed TILED_BACKING_STORE guard.
2424
2425 2014-08-28  Daniel Bates  <dabates@apple.com>
2426
2427         [Win] update-webkit should update auxiliary libs by default
2428
2429         Reviewed by Dan Bernstein.
2430
2431         The change set <http://trac.webkit.org/changeset/172795> inadvertently prevented update-webkit
2432         from updating the Windows auxiliary libs by default. We should make update-webkit update the
2433         Windows auxiliary libs by default. This will make its behavior match its usage text.
2434
2435         * Scripts/update-webkit:
2436
2437 2014-08-28  Brian J. Burg  <burg@cs.washington.edu>
2438
2439         build-webkit --inspector-frontend tries to copy files from old inspector path
2440         https://bugs.webkit.org/show_bug.cgi?id=136346
2441
2442         Reviewed by Timothy Hatcher.
2443
2444         Remove the old code path for copying inspector resources. It doesn't work.
2445         Complain if this option is passed to CMake-based builds.
2446
2447         * Scripts/build-webkit:
2448         * Scripts/webkitdirs.pm:
2449         (copyInspectorFrontendFiles): Deleted.
2450
2451 2014-08-28  Alexey Proskuryakov  <ap@apple.com>
2452
2453         Dashboard metrics page could show longest stretch of red
2454         https://bugs.webkit.org/show_bug.cgi?id=136334
2455
2456         Reviewed by Sam Weinig.
2457
2458         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2459         (Analyzer.prototype._updateStretchOfRedCounters):
2460         (Analyzer.prototype._countPercentageOfGreen):
2461         When counting percentage of green, also keep track of how long the page was red.
2462
2463         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js:
2464         (MetricsView.prototype._update.addDivider):
2465         (MetricsView.prototype._update.appendQueueResults):
2466         Show it in aggregate queues (can't think of a reason to have it in individual ones).
2467
2468         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Metrics.css:
2469         Changed to use an explicit divider element between green time and performance groups,
2470         as there are too many combinations to easily express in CSS.
2471
2472 2014-08-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2473
2474         [GTK] Add webkit_uri_response_get_http_headers to WebKit2 GTK+ API
2475         https://bugs.webkit.org/show_bug.cgi?id=136248
2476
2477         Reviewed by Gustavo Noronha Silva.
2478
2479         Add new test case for webkit_uri_response_get_http_headers().
2480
2481         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
2482         (testURIResponseHTTPHeaders):
2483         (serverCallback):
2484         (beforeAll):
2485
2486 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
2487
2488         EWS status link at build.webkit.org/dashboard is incorrect until EWS pop-up is opened
2489         https://bugs.webkit.org/show_bug.cgi?id=131668
2490
2491         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
2492         (EWSQueue.prototype.loadDetailedStatus): Fixed a typo in assertion.
2493
2494 2014-08-27  Zalan Bujtas  <zalan@apple.com>
2495
2496         Subpixel layout: Cleanup snapSizeToPixel/snapSizeToDevicePixel.
2497         https://bugs.webkit.org/show_bug.cgi?id=136264
2498
2499         Reviewed by Simon Fraser.
2500         
2501         1. Align snapSizeToPixel()/snapSizeToDevicePixel() function names with the rest of snapping
2502         functions. ->snappedIntSize()/snapSizeToDevicePixel().
2503         2. Operate on LayoutSize/LayoutPoint instead of LayoutUnit/LayoutUnit to reflect functionality.
2504
2505         Covered by existing tests.
2506
2507         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
2508         (TestWebKitAPI::TEST): Deleted.
2509
2510 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
2511
2512         EWS status link at build.webkit.org/dashboard is incorrect until EWS pop-up is opened
2513         https://bugs.webkit.org/show_bug.cgi?id=131668
2514
2515         Reviewed by Daniel Bates.
2516
2517         We used to fetch the URL from EWS detailed status JSON, but there isn't much reason
2518         to not just hardcode.
2519
2520         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
2521         (EWS.prototype.queueStatusURL): Added.
2522
2523         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
2524         (EWSQueue.prototype.get statusPageURL): Use the above function.
2525         (EWSQueue.prototype.loadDetailedStatus): Changed assignment to an assertion.
2526
2527         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
2528         (EWSQueueView.prototype.update): While at it, made a popover show up even if there
2529         are no patches in the queue. The popover has other useful information, such as charts
2530         link and bot status.
2531
2532 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
2533
2534         https://bugs.webkit.org/show_bug.cgi?id=136317
2535         Dashboard metrics page sometimes shows 0 for best time
2536
2537         Reviewed by Tim Horton.
2538
2539         This also affects regular dashboard display in a good way - iterations that failed
2540         due to infrastructure misbehavior will more reliably show up as yellow and not red.
2541
2542         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2543         (BuildbotIteration): Added a list of steps that we actually care about. It will need to be
2544         updated if we rename steps.
2545         (BuildbotIteration.prototype.get productive): Now that computation is more involved,
2546         do it once.
2547         (BuildbotIteration.prototype._parseData): Tweak computation of "productive" - builds
2548         that failed e.g. at downloading built archive step are not productive.
2549
2550 2014-08-27  Brent Fulgham  <bfulgham@apple.com>
2551
2552         [Win] Unreviewed gardening.
2553
2554         * win/AssembleBuildLogs/AssembleLogs.cmd: Add some missing build logs to the set
2555         of logs assembled into the final build output.
2556
2557 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
2558
2559         build.webkit.org/dashboard: Add a metrics page with overall bot performance results
2560         https://bugs.webkit.org/show_bug.cgi?id=136196
2561
2562         Reviewed by Timothy Hatcher.
2563
2564         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External: Added.
2565         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/daterangepicker.css: Added.
2566         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/jquery-1.11.1.min.js: Added.
2567         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/jquery.daterangepicker.js: Added.
2568         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/moment.min.js: Added.
2569         A date range picker control with dependencies.
2570         There are a few modifications from upstream at <https://github.com/longbill/jquery-date-range-picker>:
2571         - Fixed a bug where selected dates were not at midnight the first time a range was chosen
2572         (it didn't happen again upon re-opening the picker).
2573         - Made made style tweaks to match Dashboard UI.
2574
2575         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
2576         Don't create objects that are not needed by the given app, and thus are not loaded at all.
2577
2578         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js: Added.
2579         Math to count all the things. Only supports open source tree and trunk at the moment,
2580         but written with internal tree and branches in mind.
2581
2582         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js: Added.
2583         Like dashboard Main.js, draws the UI and creates all necessary objects.
2584
2585         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js: Added.
2586         A view for table cells.
2587
2588         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
2589         (Settings.prototype.toggleSettingsDisplay): Added an event for entering settings.
2590         Metrics page has individual platforms initially scrolled away form the view, so 
2591         it needs to scroll down to reveal what's being configured.
2592
2593         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
2594         Added Array.prototype.average and Array.prototype.median.
2595
2596         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2597         Made gear icon fixed instead of absolute, so that it's visible on metrics page when
2598         in settings mode.
2599
2600         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Metrics.css:
2601         Additional style rules.
2602
2603         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/metrics.html:
2604         The metrics page.
2605
2606 2014-08-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2607
2608         Remove networkinfo watch category in watchlist
2609         https://bugs.webkit.org/show_bug.cgi?id=136279
2610
2611         Reviewed by Alexey Proskuryakov.
2612
2613         Network info was removed. So, it is not needed anymore.
2614
2615         * Scripts/webkitpy/common/config/watchlist:
2616
2617 2014-08-26  Alexey Proskuryakov  <ap@apple.com>
2618
2619         build.webkit.org/dashboard: Poor performance when there are broken builds at initial load time
2620         https://bugs.webkit.org/show_bug.cgi?id=136281
2621
2622         Reviewed by Tim Horton.
2623
2624         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2625         Track and expose whether the itertion is being loaded. Made update() a no-op if
2626         the iteration is already being loaded.
2627
2628         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
2629         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Instead of
2630         loading everything at once, ask the queue to load a little more. We can always repeat
2631         if we still don't have enough data.
2632
2633         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2634         (BuildbotQueue.prototype.loadMoreHistoricalIterations): Added a function that loads
2635         10 more iterations intelligently.
2636
2637 2014-08-26  Alexey Proskuryakov  <ap@apple.com>
2638
2639         build.webkit.org/dashboard raises an exception when Trac RSS fails to load
2640         https://bugs.webkit.org/show_bug.cgi?id=136283
2641
2642         Reviewed by Tim Horton.
2643
2644         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2645         Don't.
2646
2647 2014-08-26  Alexey Proskuryakov  <ap@apple.com>
2648
2649         build.webkit.org/dashboard raises an exception after a hidden platform is removed
2650         https://bugs.webkit.org/show_bug.cgi?id=136282
2651
2652         Reviewed by Tim Horton.
2653
2654         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2655         (updateHiddenPlatforms): Check that the platform is still valid.
2656
2657 2014-08-26  Matt Lilek  <mrl@apple.com>
2658
2659         Add WebKit SPI to control the navigator.standalone property
2660         https://bugs.webkit.org/show_bug.cgi?id=136189
2661
2662         Reviewed by Andy Estes.
2663
2664         Add API test for WKPreferences
2665
2666         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2667         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
2668         (TEST):
2669
2670 2014-08-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2671
2672         Remove ENABLE_DRT environment variable to enable SHARED_CORE
2673         https://bugs.webkit.org/show_bug.cgi?id=136205
2674
2675         Reviewed by Andrei Bucur.
2676
2677         EFL port doesn't need to enable SHARED_CORE since r172894. Thus, we don't need to
2678         use ENABLE_DRT enviroment variable, which enables SHARED_CORE.
2679
2680         * Scripts/webkitdirs.pm:
2681         (generateBuildSystemFromCMakeProject):
2682
2683 2014-08-26  Brent Fulgham  <bfulgham@apple.com>
2684
2685         [Win] Version stamp should include package-level version
2686         https://bugs.webkit.org/show_bug.cgi?id=136266
2687         <rdar://problem/18134138>
2688
2689         Reviewed by David Kilzer.
2690
2691         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Add
2692         tests for the full 3+ digit version.
2693         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl:
2694         Confirm that the final output DLL uses the 3+ digit version.
2695
2696 2014-08-26  Brent Fulgham  <bfulgham@apple.com>
2697
2698         [Win] WebKit IDL incorrectly passes HWND as OLE_HANDLE
2699         https://bugs.webkit.org/show_bug.cgi?id=136258
2700         <rdar://problem/18134138>
2701
2702         Reviewed by Tim Horton.
2703
2704         Avoid 32/64-bit truncation by preventing 64-bit HWND (and other)
2705         values from passing through the 32-bit OLE_HANDLE data type.
2706
2707         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2708         (AccessibilityController::rootElement):
2709         * DumpRenderTree/win/DumpRenderTree.cpp:
2710         (resetWebViewToConsistentStateBeforeTesting):
2711         (runTest):
2712         (createWebViewAndOffscreenWindow):
2713         * DumpRenderTree/win/FrameLoadDelegate.h:
2714         (FrameLoadDelegate::didReceiveIcon):
2715         * DumpRenderTree/win/TestRunnerWin.cpp:
2716         (TestRunner::setWindowIsKey):
2717         * DumpRenderTree/win/UIDelegate.cpp:
2718         (UIDelegate::trackCustomPopupMenu):
2719         (UIDelegate::drawHeaderInRect):
2720         (UIDelegate::drawFooterInRect):
2721         (UIDelegate::webViewClose):
2722         (UIDelegate::webViewFocus):
2723         (UIDelegate::webViewSetCursor):
2724         (UIDelegate::drawBackground):
2725         * DumpRenderTree/win/UIDelegate.h:
2726         (UIDelegate::webViewFirstResponder):
2727         (UIDelegate::makeFirstResponder):
2728         (UIDelegate::contextMenuItemsForElement):
2729         (UIDelegate::addCustomMenuDrawingData):
2730         (UIDelegate::cleanUpCustomMenuDrawingData):
2731         (UIDelegate::webViewLostFocus):
2732         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
2733         (TestWebKitAPI::WebViewDestructionWithHostWindow::SetUp):
2734         * WinLauncher/PrintWebUIDelegate.cpp:
2735         (PrintWebUIDelegate::drawHeaderInRect):
2736         (PrintWebUIDelegate::drawFooterInRect):
2737         * WinLauncher/PrintWebUIDelegate.h:
2738         (PrintWebUIDelegate::webViewFirstResponder):
2739         (PrintWebUIDelegate::makeFirstResponder):
2740         (PrintWebUIDelegate::contextMenuItemsForElement):
2741         (PrintWebUIDelegate::trackCustomPopupMenu):
2742         (PrintWebUIDelegate::addCustomMenuDrawingData):
2743         (PrintWebUIDelegate::cleanUpCustomMenuDrawingData):
2744         * WinLauncher/WinLauncher.cpp:
2745         (WinLauncher::prepareViews):
2746         * WinLauncher/WinLauncherWebHost.h:
2747         (WinLauncherWebHost::didReceiveIcon):
2748
2749 2014-08-26  Daniel Bates  <dabates@apple.com>
2750
2751         Only define WEBCORE_EXPORT when building DumpRenderTree for Windows and iOS
2752
2753         Rubber-stamped by Tim Horton.
2754
2755         The Windows and iOS ports are the only ports that make use of WebCore headers
2756         in DumpRenderTree.
2757
2758         * DumpRenderTree/config.h:
2759
2760 2014-08-26  Dan Bernstein  <mitz@apple.com>
2761
2762         runSvnUpdateAndResolveChangeLogs() doesn’t work when invoked from a script outside Tools/Scripts
2763         https://bugs.webkit.org/show_bug.cgi?id=136254
2764
2765         Reviewed by Tim Horton.
2766
2767         * Scripts/webkitdirs.pm:
2768         (runSvnUpdateAndResolveChangeLogs): Locate resolve-ChangeLogs relative to the source tree,
2769         not the invoking script.
2770
2771 2014-08-26  Krzysztof Czech  <k.czech@samsung.com>
2772
2773         [EFL] Utilize espeak as a synthesizer back-end for WebSpeech
2774         https://bugs.webkit.org/show_bug.cgi?id=136127
2775
2776         Reviewed by Gyuyoung Kim.
2777
2778         Add espeak dependency.
2779
2780         * efl/install-dependencies:
2781
2782 2014-08-25  Alexey Proskuryakov  <ap@apple.com>
2783
2784         Remove a little more accidentally landed code from r172891.
2785
2786         iteration.branch also wasn't meant to be landed.
2787
2788         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2789         (BuildbotIteration.prototype._parseData):
2790
2791 2014-08-25  Alexey Proskuryakov  <ap@apple.com>
2792
2793         REGRESSION (r172891): Internal dashboard is broken.
2794
2795         Removing some accidentally landed code - I needed "changes" for another patch, but
2796         not here, and then I decided to not use it anyway.
2797
2798         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2799         (BuildbotIteration.prototype._parseData):
2800
2801 2014-08-25  Daniel Bates  <dabates@apple.com>
2802
2803         Fix the iOS DumpRenderTree build after <http://trac.webkit.org/changeset/172814/>
2804         (https://bugs.webkit.org/show_bug.cgi?id=136108)
2805
2806         Use a similar approach as in TestWebKitAPI/config.h and define a stub for the macro define WEBCORE_EXPORT
2807         so that we can compile DumpRenderTree for iOS.
2808
2809         * DumpRenderTree/config.h:
2810
2811 2014-08-25  Alexey Proskuryakov  <ap@apple.com>
2812
2813         Make build.webkit.org/dashboard work with changeset_show_files=location
2814         https://bugs.webkit.org/show_bug.cgi?id=136237
2815
2816         Reviewed by Tim Horton.
2817
2818         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2819         (Trac.prototype._convertCommitInfoElementToObject): Remove location information
2820         from description before getting title, and also actually parse the location into
2821         result object when available.
2822
2823         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
2824         (String.prototype.startsWith): Added.
2825
2826 2014-08-25  Tanay C  <tanay.c@samsung.com>
2827
2828         [EFL][WK2] Minibrowser : Enhance application to be able to support history list navigation
2829         https://bugs.webkit.org/show_bug.cgi?id=135795
2830
2831         Reviewed by Gyuyoung Kim.
2832
2833         * MiniBrowser/efl/main.c: Adding functionality for long press history list navigation
2834         (history_list_hide): Hiding and dereferencing the history list and items
2835         (on_key_down):
2836         (on_mouse_down):
2837         (on_back_button_clicked): Early return for longpress 
2838         (on_forward_button_clicked): Early return for longpress 
2839         (list_item_label_get): Populate item labels
2840         (on_list_item_select): Navigates on selection from history list
2841         (navigation_button_longpress_process): Populates the history list and displays it
2842         (on_forward_button_longpress):
2843         (on_back_button_longpress):
2844         (window_create): Add the widget for history list
2845
2846 2014-08-25  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2847
2848         [GTK] JHBuild module gst-plugins-base fails to build on x86 with GCC 4.9
2849         https://bugs.webkit.org/show_bug.cgi?id=136152
2850
2851         Reviewed by Philippe Normand.
2852
2853         * gtk/jhbuild.modules: Apply gst-plugins-base-fix-build-gcc-4.9-x86.patch.
2854         * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Added.
2855         Cherry pick upstream patches daa194 and 4e3d101.
2856
2857 2014-08-24  Zan Dobersek  <zdobersek@igalia.com>
2858
2859         GenericHashTraits::peek() is producing copies of passed-in temporary values
2860         https://bugs.webkit.org/show_bug.cgi?id=131461
2861
2862         Reviewed by Darin Adler.
2863
2864         Add a test case that checks the number of copies and moves of the mapped objects
2865         when calling HashMap::get(). Exactly one copy of the mapped value should be
2866         performed when there exists a value that is mapped to the specified key, and
2867         exactly one move and no copies of the empty value should be performed when there
2868         isn't any mapped value for the specified key.
2869
2870         * TestWebKitAPI/Tests/WTF/CopyMoveCounter.h: Added.
2871         (CopyMoveCounter::TestingScope::TestingScope):
2872         (CopyMoveCounter::CopyMoveCounter):
2873         (CopyMoveCounter::operator=):
2874         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2875         (TestWebKitAPI::TEST):
2876
2877 2014-08-24  Ryuan Choi  <ryuan.choi@samsung.com>
2878
2879         [EFL] Introduce DEVELOPER_MODE
2880         https://bugs.webkit.org/show_bug.cgi?id=135884
2881
2882         Reviewed by Gyuyoung Kim.
2883
2884         * Scripts/webkitdirs.pm: Turn on DEVELOPER_MODE for the EFL port.
2885         (generateBuildSystemFromCMakeProject):
2886
2887 2014-08-24  Alexey Proskuryakov  <ap@apple.com>
2888
2889         build.webkit.org/dashboard unnecessarily loads results of hidden queues
2890         https://bugs.webkit.org/show_bug.cgi?id=136195
2891
2892         Reviewed by Tim Horton.
2893
2894         This patch also makes it possible to avoid any automatic loading, as needed for metrics view.
2895
2896         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2897         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
2898         Don't start an update just because a queue object was created. Periodic updates
2899         are triggered by views, so it only makes sense to do the same for the initial update.
2900
2901         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2902         Now that Trac object doesn't auto-load, start loading here.
2903
2904         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
2905         (QueueView): Calling _updateHiddenState right away was wrong, because it accesses
2906         a data member added by subclasses later. With this.platform being undefined, it
2907         always looked like this queue was not hidden.
2908         (QueueView.prototype._updateHiddenState): Start an immediate update, too.
2909
2910         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2911         (Trac): Don't load anything here, the client may choose to load a custom date range.
2912         (Trac.prototype.startPeriodicUpdates): Added a function to start automatic loading.
2913
2914 2014-08-23  Alexey Proskuryakov  <ap@apple.com>
2915
2916         build.webkit.org/dashboard: Further improve Trac loading
2917         https://bugs.webkit.org/show_bug.cgi?id=136174
2918
2919         Reviewed by Timothy Hatcher.
2920
2921         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2922         (Trac.prototype._xmlTimelineURL): Passing -1 as "max" resulted in an off by one
2923         error, the oldest commit within the range wasn't returned. The correct argument for
2924         "no limit" is 0.
2925         (Trac.prototype.load): Added a function to load a specific time range.
2926         (Trac.prototype._loaded): Updated to support loading revisions that are arbitrarily
2927         positioned with regards to ones that were already known.
2928
2929 2014-08-23  Alexey Proskuryakov  <ap@apple.com>
2930
2931         build.webkit.org/dashboard: Make it possible to pull historic data from Buildbot
2932         https://bugs.webkit.org/show_bug.cgi?id=136182
2933
2934         Reviewed by Timothy Hatcher.
2935
2936         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2937         Make it possible to create a complete BuildbotIteration object with JSON, not only by
2938         loading data from the network.
2939
2940         An iteration has three states:
2941         1. Just created, it only knows the revision, and whether it's already finished.
2942         BuildbotIteration constructor used to create these.
2943         2. A complete JSON report loaded from buildbot. The new constructor form creates these.
2944         3. Data about tests is fetched.
2945
2946         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2947         Make it possible to pull all data from a buildbot queue. This needs to be better
2948         optimized eventually, as it's somewhat slow.
2949
2950 2014-08-22  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
2951
2952         Remove LevelDB.
2953         https://bugs.webkit.org/show_bug.cgi?id=136170
2954
2955         Reviewed by Gyuyoung Kim.
2956
2957         * Scripts/webkitpy/common/config/watchlist:
2958         * Scripts/webkitpy/style/checker.py:
2959
2960 2014-08-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2961
2962         [GTK] install-dependencies don't installs Xvfb that is needed for the tests.
2963         https://bugs.webkit.org/show_bug.cgi?id=136153
2964
2965         Reviewed by Martin Robinson.
2966
2967         * gtk/install-dependencies: Add Xvfb package to the list of dependencies necessary for running tests.
2968
2969 2014-08-21  Alex Christensen  <achristensen@webkit.org>
2970
2971         [Win] Another unreviewed build fix.
2972
2973         * DumpRenderTree/config.h:
2974         Defined WEBCORE_EXPORT on Windows.
2975
2976 2014-08-21  Rohit Kumar  <kumar.rohit@samsung.com>
2977
2978         [EFL][WK2] Minibrowser : Add stop button to abort page load
2979         https://bugs.webkit.org/show_bug.cgi?id=136122
2980
2981         Reviewed by Gyuyoung Kim.
2982
2983         * MiniBrowser/efl/main.c:
2984         (on_key_down):
2985         (on_stop_button_clicked): Callback for stop button press.
2986         (window_create):
2987
2988 2014-08-21  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2989
2990         [GTK] Load the llvmpipe (Mesa) libraries when running the tests with Xvfb.
2991         https://bugs.webkit.org/show_bug.cgi?id=134070
2992
2993         Reviewed by Martin Robinson.
2994
2995         * Scripts/webkitpy/port/base.py:
2996         (Port.__init__): Set default _jhbuild_wrapper variable.
2997         (Port._should_use_jhbuild): Implement generic check.
2998         * Scripts/webkitpy/port/efl.py: Rename to jhbuild_wrapper variable
2999         to make it consistent with the other ports.
3000         * Scripts/webkitpy/port/gtk.py:
3001         (GtkPort.__init__): Use the new _should_use_jhbuild() method.
3002         (GtkPort.setup_environ_for_server): Get the path for llvmpipe_libgl_path by
3003         querying the jhbuild with printenv. Also check that the path contains
3004         the libraries we expect. Preload this path only for XvfbDriver.
3005         * Scripts/webkitpy/port/xvfbdriver.py:
3006         (XvfbDriver.check_driver): Check for the jhbuild wrapper and use it.
3007         (XvfbDriver._start): The environment for llvmpipe_libgl_path is now
3008         configured at setup_environ_for_server()
3009         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
3010         (XvfbDriverTest.make_driver): Get the port default environment.
3011         (XvfbDriverTest.test_start_no_pixel_tests): The expected log now
3012         should include the environment that is passed when running Xvfb.
3013         (XvfbDriverTest.test_start_pixel_tests): Ditto.
3014         (XvfbDriverTest.test_start_arbitrary_worker_number): Ditto.
3015         (XvfbDriverTest.test_start_next_worker): Ditto.
3016         * gtk/jhbuild.modules: Rename checkoutdir to generic "Mesa" to
3017         prevent future problems when the version is raised. Add also a
3018         comment with a warning.
3019         * gtk/jhbuildrc: The path LLVMPIPE_LIBGL_PATH should be the one
3020         that has the llvm optimized Gallium libGL libraries.
3021
3022 2014-08-21  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
3023
3024         Fix countFailures of RunLLINTCLoopTests and Run32bitJSCTests.
3025         https://bugs.webkit.org/show_bug.cgi?id=136125
3026
3027         Reviewed by Csaba Osztrogonác.
3028
3029         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3030         (RunLLINTCLoopTests.countFailures):
3031         (Run32bitJSCTests.countFailures):
3032         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3033         (RunLLINTCLoopTestsTest):
3034         (RunLLINTCLoopTestsTest.assertResults):
3035         (RunLLINTCLoopTestsTest.test_failures):
3036         (RunLLINTCLoopTestsTest.test_failure):
3037         (RunLLINTCLoopTestsTest.test_no_failure):
3038         (Run32bitJSCTestsTest):
3039         (Run32bitJSCTestsTest.assertResults):
3040         (Run32bitJSCTestsTest.test_failures):
3041         (Run32bitJSCTestsTest.test_failure):
3042         (Run32bitJSCTestsTest.test_no_failure):
3043
3044 2014-08-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3045
3046         Unreviewed, EFL build fix since r172814.
3047
3048         * WebKitTestRunner/config.h: Define WEBCORE_EXPORT.
3049
3050 2014-08-20  Alex Christensen  <achristensen@webkit.org>
3051
3052         Introducing WEBCORE_EXPORT macro.
3053         https://bugs.webkit.org/show_bug.cgi?id=136108
3054
3055         Reviewed by Antti Koivisto.
3056
3057         * TestWebKitAPI/config.h:
3058         Added stub definition of WEBCORE_EXPORT defined to nothing to be able to compile with WebCore headers.
3059
3060 2014-08-20  Rebecca Hauck  <rhauck@adobe.com>
3061
3062         import-w3c-tests doesn't import .svg support files
3063         https://bugs.webkit.org/show_bug.cgi?id=135928
3064
3065         Reviewed by Bem Jones-Bey.
3066
3067         This patch fixes the W3C import script to not treat all
3068         files with an xml mimetype as convertible tests, which
3069         was causing SVG support files to not be imported.
3070
3071         * Scripts/webkitpy/w3c/test_importer.py:
3072         (TestImporter.find_importable_tests):
3073
3074 2014-08-19  Dan Bernstein  <mitz@apple.com>
3075
3076         update-webkit should not check for the presence of Apple’s Internal directory
3077         Last part of https://bugs.webkit.org/show_bug.cgi?id=135815
3078
3079         Reviewed by Tim Horton.
3080
3081         * Scripts/update-webkit:
3082
3083 2014-08-19  Zalan Bujtas  <zalan@apple.com>
3084
3085         Remove ENABLE(SUBPIXEL_LAYOUT).
3086         https://bugs.webkit.org/show_bug.cgi?id=136077
3087
3088         Reviewed by Simon Fraser.
3089
3090         Remove compile time flag SUBPIXEL_LAYOUT. All ports have it enabled for a while now.
3091
3092         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
3093
3094 2014-08-19  Akos Kiss  <akiss@inf.u-szeged.hu>
3095
3096         Let the caller define JSC_timeout for run-javascriptcore-tests
3097         https://bugs.webkit.org/show_bug.cgi?id=136068
3098
3099         Reviewed by Csaba Osztrogonác.
3100
3101         Keep the 60 second timeout for jsc tests as the default setting but
3102         don't override the value of JSC_timeout if already set.
3103
3104         * Scripts/run-javascriptcore-tests:
3105
3106 2014-08-19  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
3107
3108         Remove obsolete run-javascriptcore-tests result parsing from master.cfg
3109         https://bugs.webkit.org/show_bug.cgi?id=136039
3110
3111         Reviewed by Csaba Osztrogonác.
3112
3113         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3114         (RunJavaScriptCoreTests.commandComplete):
3115         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3116         (RunJavaScriptCoreTestsTest.test_no_failure_new_output):
3117         (RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output):
3118         (RunJavaScriptCoreTestsTest):
3119         (RunJavaScriptCoreTestsTest.test_jsc_stress_failure_new_output):
3120         (RunJavaScriptCoreTestsTest.test_mozilla_failure_new_output): Deleted.
3121         (test_layout_failure_new_output): Deleted.
3122         (test_layout_crash_new_output): Deleted.
3123         (test_mozilla_and_layout_failure_new_output): Deleted.
3124         (test_jsc_stress_failure_new_output): Deleted.
3125         (test_js_crashes_and_jsc_stress_failures_new_output): Deleted.
3126
3127 2014-08-19  Alexey Proskuryakov  <ap@apple.com>
3128
3129         build.webkit.org/dashboard should not request 50 revisions from trac each time
3130         https://bugs.webkit.org/show_bug.cgi?id=127130
3131
3132         build.webkit.org/dashboard sometimes fetches a Trac revision in an intermediate state, and never updates later
3133         https://bugs.webkit.org/show_bug.cgi?id=127131
3134
3135         Reviewed by Timothy Hatcher.
3136
3137         Turns out that requesting 50 builds is much slower than requesting by date - even
3138         if the request ends up returning more than 50 results. There is no way to only
3139         request updates, but this change brings request time from 6-8 seconds down to
3140         less than a second.
3141
3142         This patch generalizes date handling for later use in metrics code. As part of the
3143         rewrite, I made newly fetched data update author e-mail in previously fetched
3144         revisions, as it changes after commit queue first lands.
3145
3146         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3147         Updated for event rename. I changed the trac event to not contain the list of new
3148         commits, as we now sometimes update old commits, and that couldn't be expressed
3149         in event data. We never used the list anywhere in the first place.
3150
3151         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3152         (Trac.prototype._xmlTimelineURL): Made this function take arbitrary dates. When called
3153         without arguments, return commits for today and yesterday.
3154         (Trac.prototype._loaded):
3155         (Trac.prototype.update): Moved the function for processing loaded results out of
3156         here for clarity, and also because I'm going to have a separate loading code path
3157         for metrics.
3158
3159 2014-08-18  Dan Bernstein  <mitz@apple.com>
3160
3161         Added an update-webkit option to override the ../Internal check.
3162         Part of https://bugs.webkit.org/show_bug.cgi?id=135815
3163
3164         Reviewed by Tim Horton.
3165
3166         * Scripts/update-webkit:
3167         Added an explicit --internal option to control updating ../Internal, defaulting to whether
3168         ../Internal exists.
3169         (runSvnUpdate): Moved to webkitdirs.pm.
3170         (runGitUpdate): Ditto.
3171         * Scripts/webkitdirs.pm:
3172         (runSvnUpdateAndResolveChangeLogs): Moved runSvnUpdate from update-webkit and renamed to this.
3173         (runGitUpdate): Moved from update-webkit.
3174
3175 2014-08-18  Pratik Solanki  <psolanki@apple.com>
3176
3177         Make update-webkit more lenient for pure git svn repositories
3178         https://bugs.webkit.org/show_bug.cgi?id=135805
3179
3180         Reviewed by Oliver Hunt.
3181
3182         Make the call to git fetch be non fatal. If you have a pure git svn repository, then the
3183         call to git fetch will fail and update-webkit will abort. The purpose of r72966 was to
3184         provide an optimization when you have a git repository setup. We should not fail if the
3185         git setup does not have svn-remote.svn.fetch set.
3186
3187         * Scripts/update-webkit:
3188         (runGitUpdate):
3189
3190 2014-08-18  Simon Fraser  <simon.fraser@apple.com>
3191
3192         Enable Web Inspector in MiniBrowser WK2 windows
3193         https://bugs.webkit.org/show_bug.cgi?id=136045
3194
3195         Reviewed by Tim Horton.
3196         
3197         Set the pref to enable developer extras for all WK2 windows.
3198
3199         * MiniBrowser/mac/WK2BrowserWindowController.m:
3200         (-[WK2BrowserWindowController awakeFromNib]):
3201
3202 2014-08-18  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
3203
3204         master.cfg should handle special return codes of run-perf-tests
3205         https://bugs.webkit.org/show_bug.cgi?id=135974
3206
3207         Reviewed by Ryosuke Niwa.
3208
3209         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3210         (RunAndUploadPerfTests.getText2):
3211         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3212         (RunAndUploadPerfTestsTest):
3213         (RunAndUploadPerfTestsTest.assertResults):
3214         (RunAndUploadPerfTestsTest.test_tests_failed):
3215         (RunAndUploadPerfTestsTest.test_build_bad_build):
3216         (RunAndUploadPerfTestsTest.test_build_bad_source_json):
3217         (RunAndUploadPerfTestsTest.test_build_bad_marge):
3218         (RunAndUploadPerfTestsTest.test_build_bad_failed_uploading):
3219         (RunAndUploadPerfTestsTest.test_build_bad_preparation):
3220
3221 2014-08-17  Brent Fulgham  <bfulgham@apple.com>
3222
3223         [Win] Unreviewed change to force rebuild
3224         (plus drive-by add an accessor I wanted for
3225         some future tooling).
3226
3227         * WinLauncher/WinLauncher.h:
3228         (WinLauncher::webView): Added.
3229
3230 2014-08-16  Mark Hahnenberg  <mhahnenb@gmail.com>
3231
3232         Update contributors.json for my new email
3233         https://bugs.webkit.org/show_bug.cgi?id=136021
3234
3235         Reviewed by Filip Pizlo.
3236
3237         * Scripts/webkitpy/common/config/contributors.json:
3238
3239 2014-08-15  Alexey Proskuryakov  <ap@apple.com>
3240
3241         REGRESSION (r172660): WebKit2.TerminateTwice asserts
3242         https://bugs.webkit.org/show_bug.cgi?id=136012
3243
3244         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp: Skipped the test in debug mode.
3245
3246 2014-08-15  Ryuan Choi  <ryuan.choi@samsung.com>
3247
3248         Unreviewed build fix attempt on the CMake based pots since r172665
3249
3250         * TestWebKitAPI/CMakeLists.txt: Added JavaScriptCore/interpreter to the include list.
3251
3252 2014-08-15  Brian J. Burg  <burg@cs.washington.edu>
3253
3254         Web Inspector: rewrite CodeGeneratorInspector to be modular and testable
3255         https://bugs.webkit.org/show_bug.cgi?id=131596
3256
3257         Reviewed by Joseph Pecoraro.
3258
3259         * Scripts/run-inspector-generator-tests: Added.
3260         (main):
3261         * Scripts/webkitpy/inspector/__init__.py: Added.
3262         * Scripts/webkitpy/inspector/main.py: Added.
3263         (InspectorGeneratorTests):
3264         (InspectorGeneratorTests.__init__):
3265         (InspectorGeneratorTests.generate_from_json):
3266         (InspectorGeneratorTests.write_error_file):
3267         (InspectorGeneratorTests.detect_changes):
3268         (InspectorGeneratorTests.run_tests):
3269         (InspectorGeneratorTests.main):
3270
3271 2014-08-15  Rebecca Hauck  <rhauck@adobe.com>
3272
3273         run-webkit-tests should skip 'support' directories
3274         https://bugs.webkit.org/show_bug.cgi?id=135910
3275
3276         Reviewed by Bem Jones-Bey.
3277         
3278         This patch adds the 'support' directory to the list
3279         of dirs to skip when looking for runnable tests.
3280         the W3C uses this name for support files, so tests
3281         imported from the W3C will not work without this change
3282         or without many edits.
3283
3284         * Scripts/webkitpy/port/base.py:
3285         (Port._real_tests):
3286
3287 2014-08-14  Brent Fulgham  <bfulgham@apple.com>
3288
3289         [Win] Extend auto-version and version-stamp for RC_ProjectBuildVersion
3290         https://bugs.webkit.org/show_bug.cgi?id=135948
3291         <rdar://problem/18022221>
3292
3293         Reviewed by David Kilzer.
3294
3295         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Add tests
3296         for RC_ProjectBuildVersion.
3297
3298 2014-08-05  David Farler  <dfarler@apple.com>
3299
3300         [iOS] run-webkit-tests runs webkit-build-directory on every test
3301         https://bugs.webkit.org/show_bug.cgi?id=135409
3302
3303         Reviewed by Daniel Bates.
3304
3305         * Scripts/webkitpy/port/ios.py:
3306         (IOSSimulatorPort.__init__): Cache Mac build directory.
3307         (IOSSimulatorPort.relay_path): Use cached build directory.
3308         (IOSSimulatorPort._path_to_image_diff): Use cached build directory.
3309
3310 2014-08-14  Zan Dobersek  <zdobersek@igalia.com>
3311
3312         Initialize a separate variable (TestWTF_SOURCES) with the list of files
3313         that are built into the TestWTF executable and move it above the platform-specific
3314         config file inclusion. This makes it possible to add platform-specific files to that
3315         list (e.g. GUniquePtr.cpp for the GTK port).
3316
3317         Rubber-stamped by Carlos Garcia Campos.
3318
3319         * TestWebKitAPI/CMakeLists.txt:
3320         * TestWebKitAPI/PlatformGTK.cmake:
3321
3322 2014-08-13  Akos Kiss  <akiss@inf.u-szeged.hu>
3323
3324         [EFL] Bump up and patch dependencies to allow building for aarch64
3325         https://bugs.webkit.org/show_bug.cgi?id=135885
3326
3327         Reviewed by Gyuyoung Kim.
3328
3329         The currently used versions of pixman, libffi, glib, glib-networking,
3330         and fontconfig fail to configure for aarch64, so they are bumped up to
3331         the latest stable version.
3332
3333         Gstreamer-plugins-base configures for aarch64 but incorrectly recogizes
3334         ARM NEON assembly support, so it is patched with a change that has been
3335         accepted by upstream.
3336
3337         * efl/jhbuild.modules:
3338         * efl/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Added.
3339
3340 2014-08-13  Mark Rowe  <mrowe@apple.com>
3341
3342         <https://webkit.org/b/135911> WebKit should build on Yosemite with the public SDK.
3343
3344         Reviewed by Darin Adler.
3345
3346         * DumpRenderTree/mac/TextInputController.m: Don't use extern "C" in a non-C++ file.
3347
3348 2014-08-13  Alex Christensen  <achristensen@webkit.org>
3349
3350         Progress towards CMake on Mac.
3351         https://bugs.webkit.org/show_bug.cgi?id=135819
3352
3353         Reviewed by Laszlo Gombos.
3354
3355         * WebKitTestRunner/CMakeLists.txt:
3356         Added new cpp parameter for the extension of the generated files.
3357
3358 2014-08-13  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
3359
3360         Make check-webkit-style run sort-export-file
3361         https://bugs.webkit.org/show_bug.cgi?id=135877
3362
3363         Reviewed by Csaba Osztrogonác.
3364
3365         * Scripts/webkitpy/style/checker.py:
3366         (_all_categories):
3367         (FileType):
3368         (CheckerDispatcher._file_type):
3369         (CheckerDispatcher._create_checker):
3370         * Scripts/webkitpy/style/checkers/exportfile.py: Added.
3371         (ExportFileChecker):
3372         (ExportFileChecker.__init__):
3373         (ExportFileChecker.check):
3374         * Scripts/webkitpy/style/checkers/exportfile_unittest.py: Added.
3375         (handle_style_error):
3376         (MockErrorHandler):
3377         (MockErrorHandler.__init__):
3378         (MockErrorHandler.turn_off_line_filtering):
3379         (MockErrorHandler.__call__):
3380         (ExportFileTest):
3381         (ExportFileTest.setUp):
3382         (ExportFileTest.tearDown):
3383         (ExportFileTest.test_sorted):
3384         (ExportFileTest.test_non_sorted):
3385         (ExportFileTest.test_parse_error):
3386
3387 2014-08-13  Jinwoo Song  <jinwoo7.song@samsung.com>
3388
3389         [EFL] Sets the persistent storage for cookies in MiniBrowser
3390         https://bugs.webkit.org/show_bug.cgi?id=135875
3391
3392         Reviewed by Gyuyoung Kim.
3393
3394         In case of EWK_COOKIE_ACCEPT_POLICY_ALWAYS, sets the persistent storage
3395         for non-session cookies can be stored persistently.
3396
3397         * MiniBrowser/efl/main.c:
3398         (elm_main):
3399
3400 2014-08-12  Daniel Bates  <dabates@apple.com>
3401
3402         [iOS] build-webkit should not build WebKitSystemInterface and WebKitAdditions
3403         https://bugs.webkit.org/show_bug.cgi?id=135845
3404
3405         Reviewed by Andy Estes.
3406
3407         Towards building the iOS WebKit port using the public SDK, remove the logic
3408         added to build-webkit to build projects WebKitSystemInterface and
3409         WebKitAdditions when building the iOS WebKit port.
3410
3411         * Scripts/build-webkit:
3412
3413 2014-08-12  Yusuke Suzuki  <utatane.tea@gmail.com>
3414
3415         [GTK] Adds dependency for GnuTLS 3.0+ explicitly in gtk/install-dependencies
3416         https://bugs.webkit.org/show_bug.cgi?id=135850
3417
3418         Reviewed by Philippe Normand.
3419
3420         After r172433, GTK port requires GnuTLS 3.0+. In this time, libgnutls-dev is 2.x in
3421         Ubuntu(trusty) and Debian(sid). So added libgnutls28-dev explicitly.
3422
3423         * gtk/install-dependencies:
3424
3425 2014-08-12  Eduardo Lima Mitev  <elima@igalia.com>
3426
3427         [GTK] Subtle-crypto feature off by default and add a new configure flag to enable it
3428         https://bugs.webkit.org/show_bug.cgi?id=135798
3429
3430         Reviewed by Philippe Normand.
3431
3432         * Scripts/webkitperl/FeatureList.pm: Adds new flag --subtle-crypto to
3433             toggle SUBTLE_CRYPTO feature.
3434
3435 2014-08-12  Ryuan Choi  <ryuan.choi@samsung.com>
3436
3437         [EFL] Disable ecore logs about bad fd
3438         https://bugs.webkit.org/show_bug.cgi?id=135831
3439
3440         Reviewed by Gyuyoung Kim.
3441
3442         ecore checks EBADF and prints the warnings.
3443         But, it looks noise in layout test because it's not webkit issue.
3444         This patch disables it until we found right solution.
3445
3446         * efl/jhbuild.modules:
3447         * efl/patches/ecore_remove_warnings.patch: Added.
3448
3449 2014-08-12  Shivakumar JM  <shiva.jm@samsung.com>
3450
3451         [EFL][WK2] Minibrowser: Enhance the application to use download directory selector.
3452         https://bugs.webkit.org/show_bug.cgi?id=135791
3453
3454         Reviewed by Gyuyoung Kim.
3455
3456         Currently Minibrowser stores the downloaded files to /tmp directory, add support so that destination folder can be selected by the
3457         user.
3458
3459         * MiniBrowser/efl/main.c:
3460         (on_download_request):
3461
3462 2014-08-11  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
3463
3464         [EFL] Prevent the client from creating ewk_view when EWebkit is not initialized
3465         https://bugs.webkit.org/show_bug.cgi?id=135606
3466
3467         Reviewed by Gyuyoung Kim.
3468
3469         TestWebKitAPI does not initialize EWebkit using ewk_init()
3470         which is not recommended.
3471
3472         * TestWebKitAPI/efl/PlatformWebView.cpp:
3473         (TestWebKitAPI::createEcoreEvas):
3474         Renamed from initEcoreEvas() since it doesn't not initialize
3475         ecore evas.
3476
3477         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3478         Call ewk_init() that initalizes all EFL modules needed by EWebKit
3479         instead of ecore_evas_init() only.
3480
3481         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
3482         Call ewk_shutdown() to finalize EWebkit.
3483         (TestWebKitAPI::initEcoreEvas): Deleted.
3484
3485 2014-08-11  Dan Bernstein  <mitz@apple.com>
3486
3487         Added an update-webkit option to update the auxiliary libraries or not.
3488         Part of https://bugs.webkit.org/show_bug.cgi?id=135815
3489
3490         Reviewed by Tim Horton.
3491
3492         * Scripts/update-webkit: Added --[no-]auxiliary-libs option, which defaults to yes unless
3493         an Internal directory exists alongside the WebKit root directory.
3494
3495 2014-08-11  Bem Jones-Bey  <bjonesbe@adobe.com>
3496
3497         Remove hg changeset from w3c-import.log
3498         https://bugs.webkit.org/show_bug.cgi?id=135735
3499
3500         Reviewed by Ryosuke Niwa.
3501
3502         Since the csswg's test suite is now accessible via github and it is
3503         possible to push changes by creating github pull requests, the hg
3504         changeset makes less sense, as many people will just use a clone of
3505         the git repo. There isn't an obvious thing to replace it with, so
3506         might as well remove it for now instead of having it just be set to
3507         UNKNOWN in imports.
3508
3509         This also adds a pointer to the github repo in the generated comments
3510         in the w3c-import.log.
3511
3512         * Scripts/webkitpy/w3c/test_importer.py:
3513         (TestImporter.__init__): Remove changeset handling.
3514         (TestImporter.do_import): Ditto.
3515         (TestImporter.write_import_log): Ditto.
3516         (TestImporter.load_changeset): Deleted.
3517
3518 2014-08-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3519
3520         Unreviewed. Fix GTK+ make distcheck.
3521
3522         * gtk/manifest.txt: Remove Source/WebCore/Resources/inputSpeech.png.
3523
3524 2014-08-08  Simon Fraser  <simon.fraser@apple.com>
3525
3526         Unbreak webkitpy unit tests by checking for the existence of the image diff template
3527         file before trying to open it (as the tests do for results.html).
3528
3529         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3530         (TestResultWriter.write_image_diff_files):
3531
3532 2014-08-08  Simon Fraser  <simon.fraser@apple.com>
3533
3534         Load the layout test result image diff HTML from a file, rather than having it inline in webkitpy
3535         https://bugs.webkit.org/show_bug.cgi?id=135780
3536
3537         Reviewed by Dan Bates.
3538         
3539         Pull the HTML for the image diff file into a separate file, for easier hackability.
3540
3541         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3542         (TestResultWriter.write_image_diff_files):
3543
3544 2014-08-08  Mark Lam  <mark.lam@apple.com>
3545
3546         Gardening: fix Windows build after r172259.
3547
3548         Not reviewed.
3549
3550         * DumpRenderTree/win/TestRunnerWin.cpp:
3551         (TestRunner::addMockSpeechInputResult): Deleted.
3552         (TestRunner::setMockSpeechInputDumpRect): Deleted.
3553         (TestRunner::startSpeechInput): Deleted.
3554
3555 2014-08-08  Joseph Pecoraro  <pecoraro@apple.com>
3556
3557         make clean does not work in OpenSource, fails in WebKitLibraries
3558         https://bugs.webkit.org/show_bug.cgi?id=135734
3559
3560         Reviewed by David Kilzer.
3561
3562         * Scripts/copy-webkitlibraries-to-product-directory:
3563         Add a --clean switch that removes possible WebKitSystemInterface
3564         and LLVM libraries and headers that may have been copied to the
3565         product directory.
3566
3567 2014-08-08  Joseph Pecoraro  <pecoraro@apple.com>
3568
3569         commit-log-message has extra blank line at the top of pre-populated message
3570         https://bugs.webkit.org/show_bug.cgi?id=135744
3571
3572         Reviewed by Csaba Osztrogonác.
3573
3574         Do not add a blank leading line in single ChangeLog commit messages.
3575
3576         * Scripts/commit-log-editor:
3577         (createCommitMessage):
3578         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3579         (test_commit_message_for_one_reviewed_changelog):
3580         (test_commit_message_for_one_rollout_changelog):
3581
3582 2014-08-07  Brent Fulgham  <bfulgham@apple.com>
3583
3584         [Win] Unreviewed gardening.
3585
3586         Have 'Assemble Build Logs' step work properly for DebugSuffix target
3587         (both 32-bit and 64-bit).
3588
3589         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
3590
3591 2014-08-07  Benjamin Poulain  <bpoulain@apple.com>
3592
3593         Get rid of INPUT_SPEECH
3594         https://bugs.webkit.org/show_bug.cgi?id=135672
3595
3596         Reviewed by Andreas Kling.
3597
3598         * DumpRenderTree/TestRunner.cpp:
3599         (TestRunner::staticFunctions):
3600         (addMockSpeechInputResultCallback): Deleted.
3601         (setMockSpeechInputDumpRectCallback): Deleted.
3602         * DumpRenderTree/TestRunner.h:
3603         * DumpRenderTree/mac/TestRunnerMac.mm:
3604         (TestRunner::addMockSpeechInputResult): Deleted.
3605         (TestRunner::setMockSpeechInputDumpRect): Deleted.
3606         (TestRunner::startSpeechInput): Deleted.
3607
3608 2014-08-07  Bem Jones-Bey  <bjonesbe@adobe.com>
3609
3610         The support directory shouldn't be skipped unconditionally in test import
3611         https://bugs.webkit.org/show_bug.cgi?id=135660
3612
3613         Reviewed by Ryosuke Niwa.
3614
3615         The 'DIRS_TO_SKIP' should only be skipped when in the root directory
3616         of the test repo, as that's the only time they are special. In
3617         addition, instead of hardcoding .hg and .git as special, skip all
3618         directories that begin with '.', just like with files that begin with '.'.
3619         
3620         In order to make this work, the root directory must always be
3621         passed in, so the interface to the script has been changed to take the
3622         root directory, and if one wants to only import a subset of the tests,
3623         a new -t option can be used to limit the tests imported.
3624
3625         * Scripts/webkitpy/w3c/test_importer.py:
3626         (main): Remove repo_dir command line argument.
3627         (parse_args): Add -t option and set expected non-option args to 1.
3628         (TestImporter.__init__): Remove repo_dir.
3629         (TestImporter.do_import): Handle the varying number of import
3630             directories.
3631         (TestImporter.should_keep_subdir): Helper for find_importable_tests to
3632             determine if a subdirectory should be skipped.
3633         (TestImporter.find_importable_tests): Filter directories using new
3634             helper.
3635         (TestImporter.import_tests): Remove use of repo_dir.
3636         (TestImporter.setup_destination_directory): Unused, Deleted. 
3637         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3638         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg): Update for
3639             new API.
3640         (TestImporterTest.test_import_dir_with_no_tests): Ditto.
3641
3642 2014-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
3643
3644         [GTK] Use WebKitNavigationAction also for WebKitNavigationPolicyDecision
3645         https://bugs.webkit.org/show_bug.cgi?id=135695
3646
3647         Reviewed by Gustavo Noronha Silva.
3648
3649         Use WebKitNavigationAction API.
3650
3651         * MiniBrowser/gtk/BrowserWindow.c:
3652         (webViewDecidePolicy):
3653         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp:
3654         (testNavigationPolicy):
3655
3656 2014-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
3657
3658         [GTK] Test /webkit2/WebKitUserContentManager/injected-script fails
3659         https://bugs.webkit.org/show_bug.cgi?id=135696
3660
3661         Reviewed by Sergio Villar Senin.
3662
3663         Don't assume the JavaScript result is always a valid pointer. In case of JavaScript
3664         exception (that happens when testing the script hasn't been injected) the JavaScript
3665         result is NULL.
3666
3667         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
3668         (isScriptInjectedForURLAtPath):
3669
3670 2014-08-07  Csaba Osztrogonác  <ossy@webkit.org>
3671
3672         [GTK] Disable IndexedDB
3673         https://bugs.webkit.org/show_bug.cgi?id=135692
3674
3675         Reviewed by Carlos Garcia Campos.
3676
3677         * Scripts/webkitperl/FeatureList.pm:
3678
3679 2014-08-06  Dean Jackson  <dino@apple.com>
3680
3681         ENABLE_CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED is not used anywhere. Remove it.
3682         https://bugs.webkit.org/show_bug.cgi?id=135675
3683
3684         Reviewed by Sam Weinig.
3685
3686         * Scripts/webkitperl/FeatureList.pm:
3687
3688 2014-08-06  David Farler  <dfarler@apple.com>
3689
3690         Set DSYMUTIL_NUM_THREADS to the number of logical cores
3691         https://bugs.webkit.org/show_bug.cgi?id=135655
3692
3693         Reviewed by Mark Rowe.
3694
3695         * Scripts/webkitdirs.pm:
3696         (buildXCodeProject): Set before calling xcodebuild.
3697
3698 2014-08-06  Adrian Perez de Castro  <aperez@igalia.com>
3699
3700         [GTK] Add support for user scripts to WebKitUserContentManager
3701         https://bugs.webkit.org/show_bug.cgi?id=134738
3702
3703         Reviewed by Carlos Garcia Campos.
3704
3705         Add support for user scripts, to complement the user style sheet
3706         support already present in WebKitUserContentManager. Most of the
3707         moving parts are already present, so this just adds a boxed type
3708         for user scripts (WebKitUserScript) and the corresponding methods
3709         to add and remove scripts from the WebKitUserContentManager.
3710
3711         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
3712         Add test case for injected user scripts.
3713         (isScriptInjectedForURLAtPath):
3714         (removeOldInjectedContentAndResetLists):
3715         (testUserContentManagerInjectedStyleSheet):
3716         (testUserContentManagerInjectedScript):
3717         (beforeAll):
3718         (removeOldInjectedStyleSheetsAndResetLists): Deleted.
3719
3720 2014-08-06  Philippe Normand  <pnormand@igalia.com>
3721
3722         [GTK] run-launcher --gtk still fails
3723         https://bugs.webkit.org/show_bug.cgi?id=135642
3724
3725         Reviewed by Carlos Garcia Campos.
3726
3727         The perl interpreter is confused by the combination of string
3728         concatenation and a ternary in the same line. Using a separate
3729         variable to determine the library file extension fixes this issue.
3730
3731         * Scripts/webkitdirs.pm:
3732         (builtDylibPathForName): Use an intermediate variable, it's more
3733         readable and unambiguous.
3734
3735 2014-07-29  Filip Pizlo  <fpizlo@apple.com>
3736
3737         Merge r170564, r170571, r170604, r170628, r170672, r170680, r170724, r170728, r170729, r170819, r170821, r170836, r170855, r170860, r170890, r170907, r170929, r171052, r171106, r171152, r171153, r171214 from ftlopt.
3738
3739     2014-06-25  Filip Pizlo  <fpizlo@apple.com>
3740     
3741             [ftlopt] If a CodeBlock is jettisoned due to a watchpoint then it should be possible to figure out something about that watchpoint
3742             https://bugs.webkit.org/show_bug.cgi?id=134333
3743     
3744             Reviewed by Geoffrey Garen.
3745     
3746             * Scripts/display-profiler-output:
3747     
3748 2014-08-05  David Farler  <dfarler@apple.com>
3749
3750         [iOS] Run ImageDiff in the sim bootstrap
3751         https://bugs.webkit.org/show_bug.cgi?id=135624
3752
3753         Reviewed by David Kilzer.
3754
3755         * Scripts/webkitpy/port/image_diff.py:
3756         (ImageDiffer.stop):
3757         (IOSSimulatorImageDiffer):
3758         (IOSSimulatorImageDiffer._start):
3759         * Scripts/webkitpy/port/ios.py:
3760         (IOSSimulatorPort.diff_image):
3761
3762 2014-08-05  David Farler  <dfarler@apple.com>
3763
3764         [iOS] run-webkit-tests: defaults for --runtime and --device-type flags
3765         https://bugs.webkit.org/show_bug.cgi?id=135441
3766
3767         Reviewed by Tim Horton.
3768
3769         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3770         (parse_args):
3771         (_set_up_derived_options):
3772         If using the ios-simulator platform and runtime or device-type
3773         aren't defined, get the latest runtime from the active Xcode.app
3774         and pick a default device type based on the desired architecture:
3775         iPhone 5 for i386 and iPhone 5s for x86_64.
3776         * Scripts/webkitpy/xcode/__init__.py: Added.
3777         * Scripts/webkitpy/xcode/simulator.py: Added.
3778
3779 2014-08-05  David Farler  <dfarler@apple.com>
3780
3781         [iOS] simctl can hang if run quickly after shutting down CoreSimulator services
3782         https://bugs.webkit.org/show_bug.cgi?id=135626
3783
3784         Reviewed by Dan Bernstein.
3785
3786         * Scripts/webkitpy/port/ios.py:
3787         (IOSSimulatorPort.setup_test_run):
3788         Remove call to simctl shutdown <device> - telling the simulator app to quit
3789         will shut down all booted devices.
3790
3791 2014-08-05  Alexey Proskuryakov  <ap@apple.com>
3792
3793         Remove an unused argument from BuildbotQueue.update()
3794         https://bugs.webkit.org/show_bug.cgi?id=135623
3795
3796         Reviewed by Timothy Hatcher.
3797
3798         Also remaned a constant to better match what it means.
3799
3800         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3801
3802 2014-08-05  Vivek Galatage  <vivek.vg@samsung.com>
3803
3804         [gtk] Include llvm-dev(el) package to satisfy mesa build configuration
3805         https://bugs.webkit.org/show_bug.cgi?id=135555
3806
3807         Reviewed by Philippe Normand.
3808
3809         Initial setup of gtk on linux requires this package to be installed.
3810         This is required during the build configuration of mesa through jhbuild.
3811
3812         * gtk/install-dependencies:
3813
3814 2014-08-05  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3815
3816         Fix the commit-log-editor after r167243 and add more unit tests
3817         https://bugs.webkit.org/show_bug.cgi?id=131727
3818
3819         Reviewed by Csaba Osztrogonác.
3820
3821         * Scripts/commit-log-editor:
3822         (createCommitMessage):
3823         (removeLongestCommonPrefixEndingInNewline):
3824         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3825         (CommitMessageForThisCommitTest):
3826         (CommitMessageForThisCommitTest.mock_changelog):
3827         (CommitMessageForThisCommitTest.mock_checkout_for_test):
3828         (CommitMessageForThisCommitTest.test_commit_message_for_unreviewed_changelogs_with_different_messages):
3829         (test_commit_message_for_one_reviewed_changelog):
3830         (test_commit_message_for_changelogs_with_same_messages):
3831         (test_commit_message_for_changelogs_with_different_messages):
3832         (test_commit_message_for_one_rollout_changelog):
3833         (test_commit_message_for_rollout_changelogs_with_different_directories):
3834         (setUp): Deleted.
3835         (test_commit_message_for_this_commit): Deleted.
3836
3837 2014-08-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3838
3839         [GTK] run-launcher --gtk is broken
3840         https://bugs.webkit.org/show_bug.cgi?id=135571
3841
3842         Reviewed by Martin Robinson.
3843
3844         * Scripts/webkitdirs.pm:
3845         (builtDylibPathForName): Search for libwebkit2gtk-4.0
3846
3847 2014-08-04  Matt Baker  <mattbaker@apple.com>
3848
3849         lldb_webkit.py throws exception when generating summary of null StringImpl
3850         https://bugs.webkit.org/show_bug.cgi?id=129448
3851
3852         Reviewed by Jer Noble.
3853
3854         Added checks for null StringImpl and 0 byte ReadMemory calls.
3855
3856         * lldb/lldb_webkit.py:
3857         (WTFStringImpl_SummaryProvider):
3858         (ustring_to_string):
3859         (lstring_to_string):
3860         (WTFStringImplProvider.to_string):
3861         (WTFStringImplProvider.is_initialized):
3862
3863 2014-08-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3864
3865         [GTK] Do not include JavaScriptCore stress tests in release tarballs
3866         https://bugs.webkit.org/show_bug.cgi?id=135503
3867
3868         Reviewed by Martin Robinson.
3869
3870         * gtk/manifest.txt: Exclude Source/JavaScriptCore/tests dir.
3871
3872 2014-07-30  David Farler  <dfarler@apple.com>
3873
3874         build-webkittestrunner doesn't build the app target for iOS SDKs
3875         https://bugs.webkit.org/show_bug.cgi?id=135433
3876
3877         Reviewed by Dan Bernstein.
3878
3879         * Scripts/build-dumprendertree: Build the app target on iOS.
3880         * Scripts/build-webkittestrunner: Build the app target on iOS.
3881         * Scripts/webkitdirs.pm: Add -sdk flags when building for iOS.
3882         (buildXCodeProject):
3883         * Scripts/webkitpy/port/ios.py: Use --sdk flags instead of SDKROOT.
3884         (IOSSimulatorPort._build_driver_flags):
3885
3886 2014-07-30  David Farler  <dfarler@apple.com>
3887
3888         Remove iOS Perl DumpRenderTree support target
3889         https://bugs.webkit.org/show_bug.cgi?id=135271
3890
3891         Reviewed by Dan Bernstein.
3892
3893         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Remove the target.
3894         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport.c: Removed.
3895         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Removed.
3896         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Removed.
3897         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Changes: Removed.
3898         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/IPhoneSimulatorNotification.xs: Removed.
3899         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/MANIFEST: Removed.
3900         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL: Removed.
3901         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/README: Removed.
3902         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm: Removed.
3903         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/ppport.h: Removed.
3904         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/t/IPhoneSimulatorNotification.t: Removed.
3905         * DumpRenderTree/ios/PerlSupport/Makefile: Removed.
3906
3907 2014-07-30  David Farler  <dfarler@apple.com>
3908
3909         Remove old-run-webkit-tests
3910         https://bugs.webkit.org/show_bug.cgi?id=135374
3911
3912         Reviewed by Csaba Osztrogonác.
3913
3914         * Scripts/old-run-webkit-tests: Removed.
3915
3916 2014-08-02  Dan Bernstein  <mitz@apple.com>
3917
3918         prepare-ChangeLog --no-write shouldn’t require ChangeLog to exist
3919         https://bugs.webkit.org/show_bug.cgi?id=135542
3920
3921         Reviewed by Tim Horton.
3922
3923         * Scripts/prepare-ChangeLog:
3924         (main): Pass $writeChangeLogs for the new requireChangeLogToExist parameter of
3925         findChangeLogs.
3926         (findChangeLogs): Don’t require a ChangeLog file to exist if unless the
3927         requireChangeLogToExist argument is true.
3928
3929 2014-08-01  Dan Bernstein  <mitz@apple.com>
3930
3931         commit-log-editor uses a non-standard message format when git index contains no ChangeLog changes
3932         https://bugs.webkit.org/show_bug.cgi?id=135527
3933
3934         Reviewed by Tim Horton.
3935
3936         * Scripts/commit-log-editor:
3937         In the case of a git repository when there are no changed ChangeLog files, changed to pass
3938         the --delimiters option to prepare-ChangeLog, then process each entry in the output using
3939         commitMessageFromChangeLogEntry.
3940         (commitMessageFromChangeLogEntry): Factored out from createCommitMessage.
3941         (sortKey): Factored out from createCommitMessage.
3942         (createCommitMessage): Changed to use new sortKey and commitMessageFromChangeLogEntry
3943         subroutines.
3944
3945         * Scripts/prepare-ChangeLog:
3946         (main): Parse new --delimiters option.
3947         (generateNewChangeLogs): When --no-write and --delimiters are both specified, always print
3948         the label before each change log entry, and a "~" delimiter on a new line after each entry.
3949
3950 2014-08-01  Bear Travis  <betravis@adobe.com>
3951
3952         [Feature Queries] Enable Feature Queries on EFL/GTK
3953         https://bugs.webkit.org/show_bug.cgi?id=134902
3954
3955         Reviewed by Benjamin Poulain.
3956
3957         Turn the feature on by default for the build script.
3958
3959         * Scripts/webkitperl/FeatureList.pm:
3960
3961 2014-08-01  Timothy Horton  <timothy_horton@apple.com>
3962
3963         Build fix for 32-bit after r171926.
3964
3965         * MiniBrowser/mac/SettingsController.h:
3966         * MiniBrowser/mac/SettingsController.m:
3967
3968 2014-08-01  Tim Horton  <timothy_horton@apple.com>
3969
3970         Confusing build fix after r171926.
3971
3972         * MiniBrowser/mac/AppDelegate.h:
3973         * MiniBrowser/mac/AppDelegate.m:
3974         * MiniBrowser/mac/SettingsController.m:
3975
3976 2014-08-01  Tim Horton  <timothy_horton@apple.com>
3977
3978         Make it easer to add switches to MiniBrowser
3979         https://bugs.webkit.org/show_bug.cgi?id=135499
3980
3981         Reviewed by Simon Fraser.
3982
3983         Add a single class to manage a set of persistent, global settings for MiniBrowser.
3984         Add a new menu that contains items to toggle the aforementioned settings (moving them out of the Debug menu).
3985
3986         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3987         Add SettingsController.{m, h}.
3988
3989         * MiniBrowser/mac/AppDelegate.h:
3990         Move _browserWindowControllers to the implementation.
3991         Get rid of toggleUseWebKit2ByDefault, because SettingsController now takes care
3992         of that; instead, we'll receive didChangeSettings.
3993
3994         * MiniBrowser/mac/AppDelegate.m:
3995         Move the default URL, default URL preference key, and use-WebKit2-by-default
3996         preference key into SettingsController.
3997
3998         (-[BrowserAppDelegate awakeFromNib]):
3999         Add the dynamically-generated SettingsController menu just to the left of the Debug menu.
4000
4001         (-[BrowserAppDelegate newWindow:]):
4002         Ask SettingsController if we should use WebKit2 by default, and what the initial URL to load is.
4003
4004         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
4005         SettingsController now takes care of reading the default URL preference.
4006         WK1BrowserWindowController now takes care of enabling the developer extras, via WebPreferences.
4007
4008         (-[BrowserAppDelegate didChangeSettings]):
4009         When settings change, update the key equivalents for the new-window menu items, as they
4010         might have changed (as use-WebKit2-by-default is one of the settings).
4011
4012         Dispatch settings change notifications to all live BrowserControllers.
4013
4014         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
4015         (-[BrowserAppDelegate toggleUseWebKit2ByDefault:]): Deleted.
4016         (-[BrowserAppDelegate _useWebKit2ByDefault]): Deleted.
4017         (-[BrowserAppDelegate validateMenuItem:]): Deleted.
4018         All menu item validation for settings is moved into SettingsController.
4019
4020         * MiniBrowser/mac/BrowserWindowController.h:
4021         Simplify the BrowserWindowController interface; "toggling" settings will happen inside SettingsController,
4022         the BrowserWindowController subclasses will be able to a) know when any setting changes, b) query the current setting state.
4023
4024         * MiniBrowser/mac/MainMenu.xib:
4025         Remove the settings menu items from the "Debug" menu.
4026
4027         * MiniBrowser/mac/SettingsController.h: Added.
4028         * MiniBrowser/mac/SettingsController.m: Added.
4029         (+[SettingsController shared]):
4030         (-[SettingsController menu]):
4031
4032         (-[SettingsController _addItemWithTitle:action:indented:]):
4033         (-[SettingsController _addHeaderWithTitle:]):
4034         NSMenuItem-creating helpers.
4035
4036         (-[SettingsController _populateMenu]):
4037         Build the menu. Ideally this and the validation step would eventually be made more dynamic.
4038
4039         (-[SettingsController validateMenuItem:]):
4040         Validate menu items; since they can be used to toggle the default state of a setting,
4041         we'll always return YES. However, we will use this opportunity to set the 'checked' state
4042         of each item.
4043
4044
4045         (-[SettingsController _toggleBooleanDefault:]):
4046         Toggle the given boolean default, and notify BrowserAppDelegate that something changed.
4047
4048         (-[SettingsController toggleUseWebKit2ByDefault:]):
4049         (-[SettingsController useWebKit2ByDefault]):
4050         (-[SettingsController toggleUseTransparentWindows:]):
4051         (-[SettingsController useTransparentWindows]):
4052         (-[SettingsController toggleUsePaginatedMode:]):
4053         (-[SettingsController usePaginatedMode]):
4054         (-[SettingsController toggleUseUISideCompositing:]):
4055         (-[SettingsController useUISideCompositing]):
4056         (-[SettingsController toggleShowLayerBorders:]):
4057         (-[SettingsController layerBordersVisible]):
4058         (-[SettingsController toggleShowTiledScrollingIndicator:]):
4059         (-[SettingsController tiledScrollingIndicatorVisible]):
4060         (-[SettingsController toggleEnableSubPixelCSSOMMetrics:]):
4061         (-[SettingsController subPixelCSSOMMetricsEnabled]):
4062         (-[SettingsController defaultURL]):
4063         Toggle or return the current state of each preference.
4064
4065         * MiniBrowser/mac/WK1BrowserWindowController.m:
4066         (-[WK1BrowserWindowController awakeFromNib]):
4067         (-[WK1BrowserWindowController validateMenuItem:]):
4068         (-[WK1BrowserWindowController windowWillClose:]):
4069         (-[WK1BrowserWindowController find:]):
4070         (-[WK1BrowserWindowController dumpSourceToConsole:]):
4071         (-[WK1BrowserWindowController didChangeSettings]):
4072         (-[WK1BrowserWindowController webView:didReceiveTitle:forFrame:]):
4073         (-[WK1BrowserWindowController isPaginated]): Deleted.
4074         (-[WK1BrowserWindowController togglePaginationMode:]): Deleted.
4075         (-[WK1BrowserWindowController toggleTransparentWindow:]): Deleted.
4076         (-[WK1BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]): Deleted.
4077         (-[WK1BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]): Deleted.
4078         (-[WK1BrowserWindowController layerBordersVisible]): Deleted.
4079         (-[WK1BrowserWindowController toggleLayerBordersVisibility:]): Deleted.
4080         * MiniBrowser/mac/WK2BrowserWindowController.m:
4081         (-[WK2BrowserWindowController awakeFromNib]):
4082         (-[WK2BrowserWindowController validateMenuItem:]):
4083         (-[WK2BrowserWindowController forceRepaint:]):
4084         (-[WK2BrowserWindowController windowWillClose:]):
4085         (-[WK2BrowserWindowController didChangeSettings]):
4086         (-[WK2BrowserWindowController isPaginated]): Deleted.
4087         (-[WK2BrowserWindowController togglePaginationMode:]): Deleted.
4088         (-[WK2BrowserWindowController toggleTransparentWindow:]): Deleted.
4089         (-[WK2BrowserWindowController isUISideCompositingEnabled]): Deleted.
4090         (-[WK2BrowserWindowController toggleUISideCompositing:]): Deleted.
4091         (-[WK2BrowserWindowController layerBordersVisible]): Deleted.
4092         (-[WK2BrowserWindowController toggleLayerBordersVisibility:]): Deleted.
4093         (-[WK2BrowserWindowController tiledScrollingIndicatorVisible]): Deleted.
4094         (-[WK2BrowserWindowController toggleTiledScrollingIndicatorVisibility:]): Deleted.
4095
4096 2014-08-01  Tim Horton  <timothy_horton@apple.com>
4097
4098         MiniBrowser doesn't support data URLs
4099         https://bugs.webkit.org/show_bug.cgi?id=135492
4100
4101         Reviewed by Simon Fraser.
4102
4103         * MiniBrowser/mac/BrowserWindowController.m:
4104         (-[BrowserWindowController addProtocolIfNecessary:]):
4105         Don't add http:// to data: URLs.
4106
4107         * MiniBrowser/mac/WK2BrowserWindowController.m:
4108         (-[WK2BrowserWindowController fetch:]):
4109         (-[WK2BrowserWindowController updateTextFieldFromURL:]):
4110         Percent-escape the contents of the address field before trying to make a URL.
4111         Percent-unescape the URL when displaying it in the address field.
4112         This is not great, but trivial and good-enough-for-Minibrowser.
4113
4114 2014-07-31  Ryuan Choi  <ryuan.choi@samsung.com>
4115
4116         [EFL][WK2] MiniBrower comes to crash when combo box is pressed
4117         https://bugs.webkit.org/show_bug.cgi?id=135378
4118
4119         Reviewed by Gyuyoung Kim.
4120
4121         "clicked" signal of elm_menu is emitted after EwkView calls popup_menu_hide
4122         and removes Ewk_Popup_Menu instance.
4123
4124         * MiniBrowser/efl/main.c:
4125         (on_popup_menu_show):
4126         (on_popup_menu_discarded): Deleted.
4127
4128 2014-07-31  Brent Fulgham  <bfulgham@apple.com>
4129
4130         [Win] Use RC_PROJECTBUILDVERSION as build portion of version
4131         https://bugs.webkit.org/show_bug.cgi?id=135478
4132
4133         Reviewed by David Kilzer.
4134
4135         Add new test suite for the version-stamp program.
4136
4137         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl: Added.
4138
4139 2014-07-31  Dan Bernstein  <mitz@apple.com>
4140
4141         Reverted r171893, because it broke http/tests/appcache/different-https-origin-resource-main.html,
4142         which loads HTTPS content without calling the delegate.
4143
4144         Rubber-stamped by Alexey Proskuryakov.
4145
4146         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
4147         (WTR::InjectedBundle::platformInitialize):
4148         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
4149         (WTR::InjectedBundle::platformInitialize):
4150
4151 2014-07-31  Brent Fulgham  <bfulgham@apple.com>
4152
4153         Unreviewed typo correction (and build fix).
4154
4155         * MiniBrowser/mac/WK2BrowserWindowController.m:
4156         (-[WK2BrowserWindowController awakeFromNib]): Use correct
4157         property name (_fullScreenIsEnabled -> _fullScreenEnabled)
4158
4159 2014-07-31  Brent Fulgham  <bfulgham@apple.com>
4160
4161         MiniBrowser Should Support Fullscreen Videos in WebKit2 Mode
4162         https://bugs.webkit.org/show_bug.cgi?id=135482
4163
4164         Reviewed by Simon Fraser.
4165
4166         * MiniBrowser/mac/WK2BrowserWindowController.m:
4167         (-[WK2BrowserWindowController awakeFromNib]): Activate the Fullscreen
4168         feature.
4169
4170 2014-07-31  Alexey Proskuryakov  <ap@apple.com>
4171
4172         [Mac, iOS] Remove -setAllowsAnyHTTPSCertificate calls
4173         https://bugs.webkit.org/show_bug.cgi?id=135472
4174
4175         Reviewed by Dan Bernstein.
4176
4177         We now handle server trust challenges, and don't need such hacks.
4178
4179         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
4180         (WTR::InjectedBundle::platformInitialize):
4181         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
4182         (WTR::InjectedBundle::platformInitialize):
4183
4184 2014-07-31  Alexey Proskuryakov  <ap@apple.com>
4185
4186         media/track/add-and-remove-track.html and media/media-fragments/TC0001.html are flaky
4187         on Mac WK2 EWS, asserting under TestRunner::removeAllWebNotificationPermissions
4188         https://bugs.webkit.org/show_bug.cgi?id=135418
4189
4190         Reviewed by Anders Carlsson.
4191
4192         This was only happening in shared web process mode, because WKBundlePostMessage
4193         has different behavior then. When there is no process, the message is dropped on
4194         the floor in multiple process mode, but it's stored to be delivered after launch
4195         in shared process mode.
4196
4197         So, calling resetStateToConsistentValues() resulted in storing a Reset bundle message
4198         that was delivered immediately after launch, when there was nothing to reset.
4199
4200         We don't actually need to reset anything at this point, as the previous call has
4201         already reset everything UI process side, and web process is brand new. All we need
4202         is to reattach the page to a process, as invoke() expects one to exist.
4203
4204         * WebKitTestRunner/TestController.cpp: (WTR::TestController::reattachPageToWebProcess):
4205         * WebKitTestRunner/TestController.h:
4206         * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke):
4207
4208 2014-07-31  Dan Bernstein  <mitz@apple.com>
4209
4210         [WK2] Regression tests can't load HTTPS pages with NetworkProcess due to self-signed certificate
4211         https://bugs.webkit.org/show_bug.cgi?id=115282
4212
4213         Reviewed by Sam Weinig.
4214
4215         * WebKitTestRunner/TestController.cpp:
4216         (WTR::TestController::canAuthenticateAgainstProtectionSpaceInFrame): Return true for any
4217         local host server trust protection space.
4218         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Respond with a non-empty
4219         credential to server trust challenges.
4220
4221 2014-07-31  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
4222
4223         [webkitpy] Make diff_text generate correct diff if there is no newline at the end of file
4224         https://bugs.webkit.org/show_bug.cgi?id=135381
4225
4226         Reviewed by Csaba Osztrogonác.
4227
4228         * Scripts/webkitpy/port/base.py:
4229         (Port.diff_text):
4230         * Scripts/webkitpy/port/base_unittest.py:
4231         (PortTest.test_diff_text):
4232
4233 2014-07-31  Carlos Garcia Campos  <cgarcia@igalia.com>
4234
4235         Unreviewed. Fix GTK+ make distcheck.
4236
4237         * gtk/make-dist.py:
4238         (ensure_version_if_possible): Use 4.0 instead of 3.0 as binary
4239         version to find the pkg-config file.
4240         * gtk/manifest.txt: Add missing resource to the tarball.
4241
4242 2014-07-31  Carlos Garcia Campos  <cgarcia@igalia.com>
4243
4244         [GTK] make distcheck is building from sources dir instead of dist dir
4245         https://bugs.webkit.org/show_bug.cgi?id=135457
4246
4247         Reviewed by Philippe Normand.
4248
4249         * gtk/make-dist.py:
4250         (Distcheck.configure): Use dist_dir as source dir.
4251         (Distcheck.check): Pass dist_dir to configure().
4252
4253 2014-07-31  Carlos Garcia Campos  <cgarcia@igalia.com>
4254
4255         [GTK] Do not include files that are not in git in the tarball
4256         https://bugs.webkit.org/show_bug.cgi?id=134804
4257
4258         Reviewed by Philippe Normand.
4259
4260         Skip all files in the source tree that are not under version control
4261         except for files added from the build dir like the documentation.
4262
4263         * gtk/make-dist.py:
4264         (Directory.__init__): Initialize the list of files under control version.
4265         (Directory.list_cms_files): Helper function to list all files
4266         under the control version for the current source root.
4267         (Directory.should_skip_file): Return True for files that are not
4268         under control version only when the source root is also under
4269         control version.
4270         (Directory.get_files): Filter the files also using should_skip_file().
4271
4272 2014-07-29  David Farler  <dfarler@apple.com>
4273
4274         iOS Simulator LayoutTestRelay
4275         https://bugs.webkit.org/show_bug.cgi?id=135269
4276
4277         Reviewed by David Kilzer.
4278
4279         * LayoutTestRelay/Configurations/Base.xcconfig: Added.
4280         * LayoutTestRelay/Configurations/DebugRelease.xcconfig: Added.
4281         * LayoutTestRelay/LayoutTestRelay.xcodeproj/project.pbxproj: Added.
4282         * LayoutTestRelay/LayoutTestRelay/LTPipeRelay.h: Added.
4283         * LayoutTestRelay/LayoutTestRelay/LTPipeRelay.m: Added.
4284         (-[LTPipeRelay inPipePath]):
4285         (-[LTPipeRelay outPipePath]):
4286         (-[LTPipeRelay errorPipePath]):
4287         (-[LTPipeRelay outputStream]):
4288         (-[LTPipeRelay initWithPrefix:]):
4289         (-[LTPipeRelay setup]):
4290         (-[LTPipeRelay tearDown]):
4291         (-[LTPipeRelay connect]):
4292         (-[LTPipeRelay disconnect]):
4293         (-[LTPipeRelay createFIFOs]):
4294         (-[LTPipeRelay destroyFIFOs]):
4295         (-[LTPipeRelay relayStream:]):