Allow json NRWT downloads to be pure json and not jsonp
[WebKit-https.git] / Tools / ChangeLog
1 2011-11-19  Ojan Vafai  <ojan@chromium.org>
2
3         Allow json NRWT downloads to be pure json and not jsonp
4         https://bugs.webkit.org/show_bug.cgi?id=72809
5
6         Reviewed by Adam Barth.
7
8         I'm moving the server to storing and serving up raw json instead of jsonp.
9         You can still get the jsonp by passing a "callback" parameter, but there's no
10         need for run-webkit-tests to get jsonp when all it wants is the raw json.
11
12         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
13         Make the wrapper stripping only happen if the json is actually wrapped.
14         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
15
16 2011-11-18  Daniel Bates  <dbates@rim.com>
17
18         Add CMake build infrastructure for the BlackBerry port
19         https://bugs.webkit.org/show_bug.cgi?id=72768
20
21         Reviewed by Antonio Gomes.
22
23         Add optional --blackberry command line argument to build-webkit to build the
24         BlackBerry port.
25
26         * Scripts/build-webkit:
27         * Scripts/webkitdirs.pm:
28         (determineBaseProductDir):
29         (argumentsForConfiguration):
30         (builtDylibPathForName):
31         (determineIsQt):
32         (isBlackBerry): Added.
33         (determineIsBlackBerry): Added.
34         (blackberryTargetArchitecture): Added.
35         (isAppleWebKit):
36
37 2011-11-18  James Robinson  <jamesr@chromium.org>
38
39         Unreviewed, rolling out r100835.
40         http://trac.webkit.org/changeset/100835
41         https://bugs.webkit.org/show_bug.cgi?id=72778
42
43         Broke some page scale tests
44
45         * DumpRenderTree/chromium/EventSender.cpp:
46         (EventSender::scalePageBy):
47
48 2011-11-18  Adam Barth  <abarth@webkit.org>
49
50         Prepare to move manual-tests out of WebCore
51         https://bugs.webkit.org/show_bug.cgi?id=72782
52
53         Reviewed by Eric Seidel.
54
55         Update this file to refer to the new location of ManualTests.
56
57         * Scripts/webkitpy/common/config/build.py:
58
59 2011-11-18  James Robinson  <jamesr@chromium.org>
60
61         [chromium] Set min/max page scale factors when calling eventSender.scalePageBy to avoid clamping
62         https://bugs.webkit.org/show_bug.cgi?id=72778
63
64         Reviewed by Kenneth Russell.
65
66         Set the min/max page scale clamps when a test calls eventSender.scalePageBy() so that the scale isn't clamped.
67
68         * DumpRenderTree/chromium/EventSender.cpp:
69         (EventSender::scalePageBy):
70
71 2011-11-18  Scott Graham  <scottmg@chromium.org>
72
73         IDL changes for gamepad support
74         https://bugs.webkit.org/show_bug.cgi?id=71753
75
76         Reviewed by Adam Barth.
77
78         Runtime enable gamepad in chromium test shell.
79
80         * DumpRenderTree/chromium/TestShell.cpp:
81         (TestShell::TestShell):
82
83 2011-10-27  Darin Fisher  <darin@chromium.org>
84
85         [chromium] Improve fullscreen API
86         https://bugs.webkit.org/show_bug.cgi?id=70477
87
88         Reviewed by Adam Barth.
89
90         Implement enter/exitFullScreen.  The implementation is asynchronous,
91         via postDelayedTask, to simulate how the browser actually behaves.
92
93         * DumpRenderTree/chromium/WebViewHost.cpp:
94         (WebViewHost::enterFullScreen):
95         (WebViewHost::exitFullScreen):
96         (WebViewHost::setAddressBarURL):
97         (WebViewHost::enterFullScreenNow):
98         (WebViewHost::exitFullScreenNow):
99         * DumpRenderTree/chromium/WebViewHost.h:
100
101 2011-11-18  Adam Roben  <aroben@apple.com>
102
103         Ignore an ANGLE leak that is not WebKit's fault
104
105         * Scripts/old-run-webkit-tests:
106         (countAndPrintLeaks):
107         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
108         (LeakDetector._callstacks_to_exclude_from_leaks):
109         Added ScanFromString to the call stacks to exclude on all OS versions.
110
111 2011-11-18  Adam Roben  <aroben@apple.com>
112
113         Ignore another Lion-specific leak that is not WebKit's fault
114
115         * Scripts/old-run-webkit-tests:
116         (countAndPrintLeaks):
117         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
118         (LeakDetector._callstacks_to_exclude_from_leaks):
119         Added SecTransformExecute to the call stacks to exclude.
120
121 2011-11-18  Yuta Kitamura  <yutak@chromium.org>
122
123         [Qt] Enable WebSocket hybi tests
124         https://bugs.webkit.org/show_bug.cgi?id=72687
125
126         Reviewed by Simon Hausmann.
127
128         Let LayoutTestControllerQt be able to switch WebSocket protocols via overridePreference().
129
130         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
131         (WebCore::WebPage::resetSettings):
132         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
133         (LayoutTestController::overridePreference):
134
135 2011-11-18  Sergio Villar Senin  <svillar@igalia.com>
136
137         [GTK][WK2] Invalid TestNetscapePlugin path when using new-run-webkit-tests
138         https://bugs.webkit.org/show_bug.cgi?id=72707
139
140         Reviewed by Philippe Normand.
141
142         Make new-run-webkit-tests use the right path to locate the test
143         plugin used by WebKitTestRunner.
144
145         * Scripts/webkitpy/layout_tests/port/gtk.py:
146
147 2011-11-18  Simon Hausmann  <simon.hausmann@nokia.com>
148
149         [Qt] WTR and InjectedBundle should not link statically against JSC/WTF
150         https://bugs.webkit.org/show_bug.cgi?id=72697
151
152         Reviewed by Kenneth Rohde Christiansen.
153
154         * Tools.pro: Make WTR linux only for the moment.
155         * WebKitTestRunner/InjectedBundle/Target.pri: Remove static jsc/wtf linkage.
156         * WebKitTestRunner/Target.pri: Ditto.
157         * qmake/mkspecs/features/default_post.prf: Don't build the main webkit sources
158         with ELF visibility on Linux. Instead we're temporarily using an LD version script.
159
160 2011-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
161
162         [Qt] Change default size of the MiniBrowser
163
164         Reviewed by Simon Hausmann.
165
166         As we lay out desktop pages using the width of 980, change our default
167         size to 980x735 so that we are not scaling down by default.
168
169         * MiniBrowser/qt/MiniBrowserApplication.h:
170         (WindowOptions::WindowOptions):
171
172 2011-11-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
173
174         [EFL] Clean up the use of DATA_DIR in the buildsystem
175         https://bugs.webkit.org/show_bug.cgi?id=72681
176
177         Reviewed by Daniel Bates.
178
179         Instead of adding -DDATA_DIR in all scopes, only define it in
180         WebCore/PlatformEFL.cmake, as WebCore is the only place that uses
181         it.
182
183         We can then define DATA_DIR to the generated theme directory for
184         EWebLauncher, since it's what we want here.
185
186         * CMakeListsEfl.txt:
187
188 2011-11-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
189
190         [EFL] Move platform includes last in DRT's include directories.
191         https://bugs.webkit.org/show_bug.cgi?id=72684
192
193         Reviewed by Daniel Bates.
194
195         This is the first step in fixing the build when a platform include (in
196         this case, Valgrind 3.7.0 ships its config.h) and the wrong config.h
197         is included instead of WebKit's.
198
199         * DumpRenderTree/efl/CMakeLists.txt:
200
201 2011-11-17  Ryosuke Niwa  <rniwa@webkit.org>
202
203         fuzzy_match doesn't recognize "Dan B" or "hyatt"
204         https://bugs.webkit.org/show_bug.cgi?id=72636
205
206         Reviewed by Eric Seidel.
207
208         Make contributors_by_fuzz_match search string in shorthand names of contributors such as "Ryosuke N"
209         and user names of email addreses such as rniwa in rniwa@webkit.org.
210
211         Also import legacy contributor names and mispell lists from Eric's script on the bug 26533 as a test.
212
213         * Scripts/webkitpy/common/config/committers.py:
214         * Scripts/webkitpy/common/config/committers_unittest.py:
215
216 2011-11-17  Eric Seidel  <eric@webkit.org>
217
218         Remove support for running check-webkit-style w/o a webkit checkout
219         https://bugs.webkit.org/show_bug.cgi?id=72678
220
221         Reviewed by Adam Barth.
222
223         After talking to Dave Levin we've decided to remove this
224         code.  I know of no users of check-webkit-style w/o a webkit checkout
225         and this needlessly adds complexity.
226
227         * Scripts/webkitpy/style/main.py:
228
229 2011-11-17  Eric Seidel  <eric@webkit.org>
230
231         Remove more direct uses of os.path
232         https://bugs.webkit.org/show_bug.cgi?id=72677
233
234         Reviewed by Adam Barth.
235
236         Remove more uses of os.path, including refactoring
237         CommitterValidator to use a Host object instead of
238         manual hacks to emulate what SCM and FileSystem provide.
239
240         * Scripts/webkitpy/common/checkout/changelog.py:
241         * Scripts/webkitpy/common/config/committervalidator.py:
242         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
243         * Scripts/webkitpy/common/system/filesystem_mock.py:
244          - Turns out none of our unittests actually looked at this path.
245            now I've made it be a valid path.
246         * Scripts/webkitpy/tool/bot/feeders.py:
247         * Scripts/webkitpy/tool/commands/queues.py:
248
249 2011-11-17  Eric Seidel  <eric@webkit.org>
250
251         Teach TextFileReader about FileSystem
252         https://bugs.webkit.org/show_bug.cgi?id=72673
253
254         Reviewed by Adam Barth.
255
256         Unfortunately TextFileReader doesn't use FileSystem
257         everywhere yet, so we can't move the unittests to
258         using MockFileSystem, but we're close.
259
260         * Scripts/webkitpy/style/filereader.py:
261         * Scripts/webkitpy/style/filereader_unittest.py:
262         * Scripts/webkitpy/style/main.py:
263
264 2011-11-17  Eric Seidel  <eric@webkit.org>
265
266         Give check-webkit-style a Host
267         https://bugs.webkit.org/show_bug.cgi?id=72670
268
269         Reviewed by Adam Barth.
270
271         * Scripts/webkitpy/common/checkout/scm/detection.py:
272         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
273          - We don't run these unittests, but this one was looking for the wrong exception.
274         * Scripts/webkitpy/style/main.py:
275         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
276          - This was create a new scm object even though it already had one?
277
278 2011-11-17  Eric Seidel  <eric@webkit.org>
279
280         Move check-webkit-style change_directory code to more modern mocks
281         https://bugs.webkit.org/show_bug.cgi?id=72664
282
283         Reviewed by Adam Barth.
284
285         * Scripts/check-webkit-style:
286         * Scripts/webkitpy/style/main.py:
287         * Scripts/webkitpy/style/main_unittest.py:
288
289 2011-11-17  Zan Dobersek  <zandobersek@gmail.com>
290
291         [GTK] enable ref tests
292         https://bugs.webkit.org/show_bug.cgi?id=72601
293
294         Re-enable ref tests. Run the driver under evenly numbered display if performing
295         pixel tests or under oddly numbered display otherwise. This prevents the ref tests
296         being run in an already used Xvfb instance if pixel tests are disabled.
297
298         Reviewed by Tony Chang.
299
300         * Scripts/webkitpy/layout_tests/port/gtk.py: Also set Xvfb variable to None
301         after the process is killed
302
303 2011-11-17  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
304
305         Make check-webkit-style accept xxx_p.h as a primary header for xxx.cpp for Qt's sake
306         https://bugs.webkit.org/show_bug.cgi?id=72620
307
308         Reviewed by David Levin.
309
310         Qt's convention of keeping private (but exposed) API suffixed by "_p.h" but not
311         adding the suffix the cpp file. One example of false positive
312         https://bugs.webkit.org/show_bug.cgi?id=72319#c12.
313
314         * Scripts/webkitpy/style/checkers/cpp.py: accept headers ending with _p as primary if its
315         basename contains the cpp's basename.
316         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
317
318 2011-11-17  Eric Seidel  <eric@webkit.org>
319
320         Move check-webkit-style's guts into webkitpy/style/main.py
321         https://bugs.webkit.org/show_bug.cgi?id=72657
322
323         Reviewed by Adam Barth.
324
325         * Scripts/check-webkit-style:
326         * Scripts/webkitpy/style/main.py:
327
328 2011-11-17  Eric Seidel  <eric@webkit.org>
329
330         new-run-webkit-tests is locale dependent
331         https://bugs.webkit.org/show_bug.cgi?id=68691
332
333         Reviewed by Adam Barth.
334
335         Make NRWT use a clean environment, just like ORWT did.
336
337         * Scripts/webkitpy/layout_tests/port/base.py:
338         * Scripts/webkitpy/layout_tests/port/chromium.py:
339         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
340         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
341         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
342         * Scripts/webkitpy/layout_tests/port/efl.py:
343         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
344         * Scripts/webkitpy/layout_tests/port/mac.py:
345         * Scripts/webkitpy/layout_tests/port/qt.py:
346         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
347         * Scripts/webkitpy/layout_tests/port/webkit.py:
348         * Scripts/webkitpy/layout_tests/port/win.py:
349
350 2011-11-17  Dirk Pranke  <dpranke@chromium.org>
351
352         Chromium Mac 10.5 CG dbg bots are failing to run webkit_gpu_tests
353         https://bugs.webkit.org/show_bug.cgi?id=72615
354
355         Reviewed by James Robinson.
356
357         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
358
359 2011-11-17  Simon Hausmann  <simon.hausmann@nokia.com>
360
361         [Qt] Layer violation: qt_runtime.cpp accesses QWebElement and QTDRTNode
362         https://bugs.webkit.org/show_bug.cgi?id=72595
363
364         Reviewed by Noam Rosenthal.
365
366         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
367         (WebCore::DumpRenderTree::DumpRenderTree): Use new initialize() function to
368         ensure the registration of the DRTNode JS bindings.
369         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
370         (LayoutTestController::LayoutTestController): Remove unnecessary explicit qt meta type
371         registration of QWebElement (now done implicitly through QWebPage ->
372         QtWebElementRunTime::initialize code path)
373
374 2011-11-17  Adam Roben  <aroben@apple.com>
375
376         Fix a crash-inducing typo I introduced in r100648
377
378         Fixes <http://webkit.org/b/72642> REGRESSION (r100648): NRWT crashes on Chromium when
379         handling a crashing test
380
381         Reviewed by Adam Barth.
382
383         * Scripts/webkitpy/layout_tests/port/chromium.py:
384         (ChromiumDriver.run_test): Get the driver name from the port.
385
386         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
387         (ChromiumDriverTest.test_crashed_process_name): Simulate a crash and check that we got the
388         right crashed process name.
389
390 2011-11-17  Adam Roben  <aroben@apple.com>
391
392         Fix NRWT's parsing of the number of excluded leaks
393
394         Fixes <http://webkit.org/b/72635> NRWT crashes when parsing leaks files from which certain
395         leaks were excluded
396
397         Reviewed by Adam Barth.
398
399         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
400         (LeakDetector._parse_leaks_output): Extract just the number of excluded leaks from the
401         regular expression match, not the entire matched string.
402
403         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
404         (LeakDetectorTest): Added some example output that shows how things look when leaks are
405         excluded.
406         (LeakDetectorTest.test_parse_leaks_output): Test that we parse the number of exclusions
407         correctly.
408
409 2011-11-17  Adam Roben  <aroben@apple.com>
410
411         Make NRWT find crash logs for the crashed process, which may not necessarily be the driver process
412
413         Fixes <http://webkit.org/b/72526> REGRESSION (NRWT): WebKitTestRunner crash log gets saved
414         when web process crashes, but WebProcess crash log should get saved instead
415
416         Reviewed by Eric Seidel.
417
418         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
419         (write_test_result): Simplified a little to share more code between the case where we
420         crashed when running the test and where we crashed when checking the expected rendering for
421         a reftest. Changed to pass the crashed process name down to write_crash_report.
422         (TestResultWriter.write_crash_report): Added crashed_process_name parameter, which we pass
423         along to CrashLogs.find_newest_log rather than always using the driver name.
424
425         * Scripts/webkitpy/layout_tests/port/chromium.py:
426         (ChromiumDriver.run_test): Pass the driver name as the name of the crashed process if we
427         crashed.
428
429         * Scripts/webkitpy/layout_tests/port/test.py:
430         (TestInstance.__init__): Initialize new web_process_crash attribute.
431         (unit_test_list): Added new web-process-crash-with-stderr test, which is used by the new
432         test this patch adds.
433         (TestDriver.run_test): Pass a crashed process name to DriverOutput based on whether the test
434         specifies that the driver crashed or the web process crashed.
435
436         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
437         (MainTest.test_web_process_crash_log): Added. Similar to test_crash_log, but uses a test for
438         which we pretend the web process crashed rather than the driver process.
439
440         (MainTest.test_run_singly_actually_runs_tests):
441         (MainTest.test_unexpected_failures):
442         (EndToEndTest.test_end_to_end):
443         Updated magic numbers to account for new unexpected failing test added to unit_test_list.
444
445 2011-11-17  Tony Chang  <tony@chromium.org>
446
447         [chromium] stop spamming features warning on every build
448         https://bugs.webkit.org/show_bug.cgi?id=72629
449
450         Reviewed by Ojan Vafai.
451
452         We toggle $blobSupport on if $mediaStreamSupport is on.  Since
453         $mediaStreamSupport is on by default for chromium, make the default
454         for $blobSupport also on.
455
456         * Scripts/build-webkit:
457
458 2011-11-17  Adam Roben  <aroben@apple.com>
459
460         Remove extra quoting of call stacks and types passed to run-leaks by NRWT
461
462         Fixes <http://webkit.org/b/72623> REGRESSION (NRWT): run-webkit-tests --leaks reports leaks
463         that are supposed to be ignored
464
465         Reviewed by Adam Barth.
466
467         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
468         (LeakDetector._leaks_args): Removed extra quoting of call stacks and types. Quoting is only
469         required when passing arguments via the shell (which we aren't doing here). It is not
470         required by Perl's option-parsing code (as the comment I removed mistakenly claimed).
471
472         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
473         (LeakDetectorTest.test_leaks_args): Updated expectations.
474
475 2011-11-17  Philippe Normand  <pnormand@igalia.com>
476
477         Unreviewed, run-bindings-tests fix after r91028.
478
479         * Scripts/run-bindings-tests: Use scm.detection module.
480
481 2011-11-17  Jochen Eisinger  <jochen@chromium.org>
482
483         Silence a warning about control reaching the end of a non-void function
484         https://bugs.webkit.org/show_bug.cgi?id=72616
485
486         Reviewed by Tony Gentilcore.
487
488         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
489         (AccessibilityUIElement::verticalScrollbar):
490
491 2011-11-17  Adam Roben  <aroben@apple.com>
492
493         Ignore some leaks in frameworks we link against on Lion
494
495         Fixes <http://webkit.org/b/72609> Lion Leaks bot complains about a bunch of leaks that
496         aren't WebKit's fault
497
498         Reviewed by Antti Koivisto.
499
500         * Scripts/old-run-webkit-tests:
501         (countAndPrintLeaks):
502         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
503         (LeakDetector._callstacks_to_exclude_from_leaks):
504         Added some call stacks to exclude on Lion that represent leaks in lower-level frameworks.
505
506         * Scripts/webkitpy/layout_tests/port/mac.py:
507         (MacPort.is_lion): Added.
508
509         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
510         (MacPortTest.test_is_version_methods): Added tests for the is_leopard/is_snowleopard/is_lion
511         methods.
512
513 2011-11-17  Philippe Normand  <pnormand@igalia.com>
514
515         [GTK] Disable ref tests
516         https://bugs.webkit.org/show_bug.cgi?id=72599
517
518         Reviewed by Xan Lopez.
519
520         * Scripts/webkitpy/layout_tests/port/gtk.py: Enforce disabled ref
521         tests to avoid massive flakiness.
522
523 2011-11-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
524
525         [Qt] Move WebKit2 C++ APIs to private API and build QML extension plugin on top of that
526
527         A new extension object has been added to QQuickWebView (the same approach should be used
528         for other API classes that need experimental APIs). The QML extension mechanism is then
529         built on top of the experimental object.
530
531         https://bugs.webkit.org/show_bug.cgi?id=72522
532
533         Reviewed by Simon Hausmann.
534
535         * MiniBrowser/qt/BrowserWindow.cpp:
536         (BrowserWindow::BrowserWindow):
537         (BrowserWindow::webView):
538         * MiniBrowser/qt/BrowserWindow.h:
539         * MiniBrowser/qt/UrlLoader.cpp:
540         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
541         * qmake/mkspecs/features/default_post.prf:
542         * qmake/mkspecs/features/default_pre.prf:
543         * qmake/mkspecs/features/qtwebkit-private.prf: Added.
544         * qmake/mkspecs/features/qtwebkit.prf:
545
546 2011-11-17  Adam Barth  <abarth@webkit.org>
547
548         Move test_results_uploader.py out of layout_package
549         https://bugs.webkit.org/show_bug.cgi?id=72590
550
551         Reviewed by Eric Seidel.
552
553         Most of the lines of code in this file are wrong, but I've restrained
554         myself and only changed a few of them to generalized this class to the
555         common package.
556
557         This is part of a series of patches to remove layout_package.
558
559         * Scripts/webkitpy/common/net/file_uploader.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py.
560         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
561         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py: Removed.
562
563 2011-11-17  Adam Barth  <abarth@webkit.org>
564
565         Unreviewed. Fix style nits in printing.py.
566
567         * Scripts/webkitpy/layout_tests/views/printing.py:
568
569 2011-11-17  Adam Barth  <abarth@webkit.org>
570
571         Minor style nits in run_webkit_tests.py
572         https://bugs.webkit.org/show_bug.cgi?id=72583
573
574         Reviewed by Eric Seidel.
575
576         This patch just fixes some minor style issues as I work my way back
577         into this code.
578
579         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
580
581 2011-11-17  Adam Barth  <abarth@webkit.org>
582
583         Move test_result_writer out of layout_package
584         https://bugs.webkit.org/show_bug.cgi?id=72586
585
586         Rubber-stamped by Eric Seidel.
587
588         This is part of a series of patches to remove layout_package.
589
590         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
591         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py.
592         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: Removed.
593         * Scripts/webkitpy/tool/commands/rebaseline.py:
594
595 2011-11-17  Adam Barth  <abarth@webkit.org>
596
597         svn-apply shouldn't magically move files into Source anymore
598         https://bugs.webkit.org/show_bug.cgi?id=72579
599
600         Reviewed by Eric Seidel.
601
602         The Source directory has existed for long enough that we don't need
603         svn-apply to magically re-write old-style patches anymore.
604
605         * Scripts/VCSUtils.pm:
606         (parseGitDiffHeader):
607         (parseSvnDiffHeader):
608
609 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
610
611         Add a list of contribution areas
612         https://bugs.webkit.org/show_bug.cgi?id=72566
613
614         Reviewed by Eric Seidel.
615
616         Added ContributionAreas class.
617
618         * Scripts/webkitpy/common/config/contributionareas.py: Added.
619         * Scripts/webkitpy/common/config/contributionareas_unittest.py: Added.
620
621 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
622
623         Refactor ChangeLogTest.test_parse_reviewer_text
624         https://bugs.webkit.org/show_bug.cgi?id=72572
625
626         Reviewed by Eric Seidel.
627
628         Refactored the test code by introduing two helper functions.
629
630         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
631
632 2011-11-16  Eric Seidel  <eric@webkit.org>
633
634         Add SCMDetector object to make scm detection mockable
635         https://bugs.webkit.org/show_bug.cgi?id=72247
636
637         Reviewed by Adam Barth.
638
639         I think SCM detection may eventually be rolled into Checkout,
640         but this patch at least makes it possible to mock code-paths
641         which rely on scm detection.
642         In the process of replacing callers of these free-functions
643         I found that one of the functions was no longer used,
644         and that one of the callers could instead just use the SCM
645         object it already had access to through port.host.scm().
646         I also discovered that I was not calling Host._initialize_scm()
647         and thus host.scm() was always returning None!
648
649         * Scripts/check-webkit-style:
650         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
651         * Scripts/webkitpy/common/checkout/deps.py:
652         * Scripts/webkitpy/common/checkout/scm/__init__.py:
653         * Scripts/webkitpy/common/checkout/scm/detection.py:
654         * Scripts/webkitpy/common/checkout/scm/git.py:
655         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
656         * Scripts/webkitpy/common/checkout/scm/svn.py:
657         * Scripts/webkitpy/common/host.py:
658         * Scripts/webkitpy/common/host_mock.py:
659         * Scripts/webkitpy/layout_tests/controllers/manager.py:
660         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
661         * Scripts/webkitpy/layout_tests/port/base.py:
662         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
663         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
664         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
665         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
666
667 2011-11-16  Mark Rowe  <mrowe@apple.com>
668
669         Fix the build.
670
671         The C++ standard library interferes with Objective-C exceptions when built with -fno-exceptions.
672         Apply the workaround that we use in other projects to WebKitTestRunner.
673
674         * WebKitTestRunner/Configurations/Base.xcconfig: Use the prefix header for all targets.
675         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Ditto.
676         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Work around the C++ standard library obnoxiousness.
677
678 2011-11-16  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
679
680         [Qt] Fix build after WTR AX support
681         https://bugs.webkit.org/show_bug.cgi?id=72560
682
683         Reviewed by Geoffrey Garen.
684
685         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
686         * WebKitTestRunner/InjectedBundle/Target.pri:
687
688 2011-11-16  Tony Chang  <tony@chromium.org>
689
690         repurpose the flexbox bot for grid layout
691         https://bugs.webkit.org/show_bug.cgi?id=72557
692
693         Reviewed by Ryosuke Niwa.
694
695         Since new flexbox is enabled everywhere, we don't need this bot
696         anymore.  However, work on grid layout has begun, so we can use this
697         bot to compile with ENABLE_CSS_GRID_LAYOUT.
698
699         * BuildSlaveSupport/build.webkit.org-config/config.json: Just rename
700         the bot on the waterfall, I will change the slave config to enable
701         the compile flag and tests.
702
703 2011-11-11  Adrienne Walker  <enne@google.com>
704
705         [chromium] Expose mock scrollbars to window.internals
706         https://bugs.webkit.org/show_bug.cgi?id=72195
707
708         Reviewed by James Robinson.
709
710         Because mock scrollbars are a global setting, reset between runs.
711
712         * DumpRenderTree/chromium/WebPreferences.cpp:
713         (WebPreferences::applyTo):
714
715 2011-11-16  James Robinson  <jamesr@chromium.org>
716
717         [chromium] Enable video and canvas 2d compositing triggers by default for layout tests in the compositing directory
718         https://bugs.webkit.org/show_bug.cgi?id=72562
719
720         Reviewed by Dirk Pranke.
721
722         * DumpRenderTree/chromium/TestShell.cpp:
723         (TestShell::runFileTest):
724
725 2011-11-16  Tony Chang  <tony@chromium.org>
726
727         [NRWT] speculative fix for multiple subprocess test on cygwin
728         https://bugs.webkit.org/show_bug.cgi?id=72518
729
730         Reviewed by Adam Barth.
731
732         * Scripts/webkitpy/layout_tests/port/chromium.py: cygwin probably
733             tries to emulate posix fd behavior.
734         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
735
736 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
737
738         Revert r100509; change was committed twice (first time as r100491).
739         Unreviewed, build fix.
740
741         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
742
743 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
744
745         Run a dummy test in the gpu configurations if there's nothing to do.
746         https://bugs.webkit.org/show_bug.cgi?id=72498
747
748         Reviewed by James Robinson.
749
750         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
751
752 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
753
754         contributors_by_fuzzy_match is super slow
755         https://bugs.webkit.org/show_bug.cgi?id=72540
756
757         Reviewed by Eric Seidel.
758
759         Make contributors_by_name do case insensitive search using a dictionary.
760
761         Also call contributors_by_name first in contributors_by_fuzzy_match now that it's fast
762         because that's the most common case.
763
764         * Scripts/webkitpy/common/config/committers.py:
765         * Scripts/webkitpy/common/config/committers_unittest.py:
766
767 2011-11-16  David Levin  <levin@chromium.org>
768
769         check-webkit-style should recognize functions even if they have OVERRIDE after them.
770         https://bugs.webkit.org/show_bug.cgi?id=72515
771
772         Reviewed by Adam Barth.
773
774         * Scripts/webkitpy/style/checkers/cpp.py:
775         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
776
777 2011-11-16  Tony Chang  <tony@chromium.org>
778
779         [NRWT] refactor drivers to require pixel_tests param
780         https://bugs.webkit.org/show_bug.cgi?id=72517
781
782         Reviewed by Ojan Vafai.
783
784         No tests, just a refactoring.
785
786         * Scripts/webkitpy/layout_tests/port/chromium.py:
787         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
788         * Scripts/webkitpy/layout_tests/port/webkit.py:
789         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
790
791 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
792
793         Run a dummy test in the gpu configurations if there's nothing to do.
794         https://bugs.webkit.org/show_bug.cgi?id=72498
795
796         Reviewed by James Robinson.
797
798         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
799
800 2011-11-16  Chris Fleizach  <cfleizach@apple.com>
801
802         WebKitTestRunner needs to support accessibility-related DRT APIs
803         https://bugs.webkit.org/show_bug.cgi?id=42131
804
805         Reviewed by Beth Dakin.
806
807         Port the AX code in DRT to WKTestRunner by using IDL.
808
809         * DumpRenderTree/AccessibilityUIElement.cpp:
810         (horizontalScrollbarCallback):
811         (verticalScrollbarCallback):
812         (AccessibilityUIElement::horizontalScrollbar):
813         (AccessibilityUIElement::verticalScrollbar):
814         (AccessibilityUIElement::getJSClass):
815         * DumpRenderTree/AccessibilityUIElement.h:
816         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
817         (AccessibilityUIElement::horizontalScrollbar):
818         (AccessibilityUIElement::verticalScrollbar):
819         * WebKitTestRunner/DerivedSources.make:
820         * WebKitTestRunner/GNUmakefile.am:
821         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Added.
822         (WTR::AccessibilityController::create):
823         (WTR::AccessibilityController::AccessibilityController):
824         (WTR::AccessibilityController::~AccessibilityController):
825         (WTR::AccessibilityController::makeWindowObject):
826         (WTR::AccessibilityController::wrapperClass):
827         (WTR::AccessibilityController::rootElement):
828         (WTR::AccessibilityController::focusedElement):
829         (WTR::AccessibilityController::elementAtPoint):
830         * WebKitTestRunner/InjectedBundle/AccessibilityController.h: Added.
831         (WTR::AccessibilityController::logFocusEvents):
832         (WTR::AccessibilityController::logValueChangeEvents):
833         (WTR::AccessibilityController::logScrollingStartEvents):
834         (WTR::AccessibilityController::logAccessibilityEvents):
835         (WTR::AccessibilityController::addNotificationListener):
836         (WTR::AccessibilityController::notificationReceived):
837         (WTR::AccessibilityController::resetToConsistentState):
838         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp: Added.
839         (WTR::AccessibilityTextMarker::create):
840         (WTR::AccessibilityTextMarker::AccessibilityTextMarker):
841         (WTR::AccessibilityTextMarker::~AccessibilityTextMarker):
842         (WTR::AccessibilityTextMarker::platformTextMarker):
843         (WTR::AccessibilityTextMarker::wrapperClass):
844         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.h: Added.
845         (WTR::AccessibilityTextMarker::isEqual):
846         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp: Added.
847         (WTR::AccessibilityTextMarkerRange::create):
848         (WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
849         (WTR::AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
850         (WTR::AccessibilityTextMarkerRange::platformTextMarkerRange):
851         (WTR::AccessibilityTextMarkerRange::wrapperClass):
852         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.h: Added.
853         (WTR::AccessibilityTextMarkerRange::isEqual):
854         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: Added.
855         (WTR::AccessibilityUIElement::create):
856         (WTR::AccessibilityUIElement::wrapperClass):
857         (WTR::AccessibilityUIElement::isValid):
858         (WTR::AccessibilityUIElement::AccessibilityUIElement):
859         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
860         (WTR::AccessibilityUIElement::isEqual):
861         (WTR::AccessibilityUIElement::elementAtPoint):
862         (WTR::AccessibilityUIElement::childAtIndex):
863         (WTR::AccessibilityUIElement::indexOfChild):
864         (WTR::AccessibilityUIElement::childrenCount):
865         (WTR::AccessibilityUIElement::titleUIElement):
866         (WTR::AccessibilityUIElement::parentElement):
867         (WTR::AccessibilityUIElement::takeFocus):
868         (WTR::AccessibilityUIElement::takeSelection):
869         (WTR::AccessibilityUIElement::addSelection):
870         (WTR::AccessibilityUIElement::removeSelection):
871         (WTR::AccessibilityUIElement::allAttributes):
872         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
873         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
874         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
875         (WTR::AccessibilityUIElement::attributesOfChildren):
876         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
877         (WTR::AccessibilityUIElement::increment):
878         (WTR::AccessibilityUIElement::decrement):
879         (WTR::AccessibilityUIElement::showMenu):
880         (WTR::AccessibilityUIElement::press):
881         (WTR::AccessibilityUIElement::stringAttributeValue):
882         (WTR::AccessibilityUIElement::uiElementAttributeValue):
883         (WTR::AccessibilityUIElement::numberAttributeValue):
884         (WTR::AccessibilityUIElement::boolAttributeValue):
885         (WTR::AccessibilityUIElement::isAttributeSupported):
886         (WTR::AccessibilityUIElement::isAttributeSettable):
887         (WTR::AccessibilityUIElement::isActionSupported):
888         (WTR::AccessibilityUIElement::role):
889         (WTR::AccessibilityUIElement::subrole):
890         (WTR::AccessibilityUIElement::roleDescription):
891         (WTR::AccessibilityUIElement::title):
892         (WTR::AccessibilityUIElement::description):
893         (WTR::AccessibilityUIElement::language):
894         (WTR::AccessibilityUIElement::stringValue):
895         (WTR::AccessibilityUIElement::accessibilityValue):
896         (WTR::AccessibilityUIElement::helpText):
897         (WTR::AccessibilityUIElement::orientation):
898         (WTR::AccessibilityUIElement::x):
899         (WTR::AccessibilityUIElement::y):
900         (WTR::AccessibilityUIElement::width):
901         (WTR::AccessibilityUIElement::height):
902         (WTR::AccessibilityUIElement::intValue):
903         (WTR::AccessibilityUIElement::minValue):
904         (WTR::AccessibilityUIElement::maxValue):
905         (WTR::AccessibilityUIElement::valueDescription):
906         (WTR::AccessibilityUIElement::insertionPointLineNumber):
907         (WTR::AccessibilityUIElement::selectedTextRange):
908         (WTR::AccessibilityUIElement::isEnabled):
909         (WTR::AccessibilityUIElement::isRequired):
910         (WTR::AccessibilityUIElement::isFocused):
911         (WTR::AccessibilityUIElement::isFocusable):
912         (WTR::AccessibilityUIElement::isSelected):
913         (WTR::AccessibilityUIElement::isSelectable):
914         (WTR::AccessibilityUIElement::isMultiSelectable):
915         (WTR::AccessibilityUIElement::setSelectedChild):
916         (WTR::AccessibilityUIElement::selectedChildrenCount):
917         (WTR::AccessibilityUIElement::selectedChildAtIndex):
918         (WTR::AccessibilityUIElement::isExpanded):
919         (WTR::AccessibilityUIElement::isChecked):
920         (WTR::AccessibilityUIElement::isVisible):
921         (WTR::AccessibilityUIElement::isOffScreen):
922         (WTR::AccessibilityUIElement::isCollapsed):
923         (WTR::AccessibilityUIElement::isIgnored):
924         (WTR::AccessibilityUIElement::hasPopup):
925         (WTR::AccessibilityUIElement::hierarchicalLevel):
926         (WTR::AccessibilityUIElement::clickPointX):
927         (WTR::AccessibilityUIElement::clickPointY):
928         (WTR::AccessibilityUIElement::documentEncoding):
929         (WTR::AccessibilityUIElement::documentURI):
930         (WTR::AccessibilityUIElement::url):
931         (WTR::AccessibilityUIElement::speak):
932         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
933         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
934         (WTR::AccessibilityUIElement::attributesOfColumns):
935         (WTR::AccessibilityUIElement::attributesOfRows):
936         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
937         (WTR::AccessibilityUIElement::attributesOfHeader):
938         (WTR::AccessibilityUIElement::indexInTable):
939         (WTR::AccessibilityUIElement::rowIndexRange):
940         (WTR::AccessibilityUIElement::columnIndexRange):
941         (WTR::AccessibilityUIElement::rowCount):
942         (WTR::AccessibilityUIElement::columnCount):
943         (WTR::AccessibilityUIElement::selectedRowAtIndex):
944         (WTR::AccessibilityUIElement::disclosedByRow):
945         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
946         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
947         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
948         (WTR::AccessibilityUIElement::ariaIsGrabbed):
949         (WTR::AccessibilityUIElement::ariaDropEffects):
950         (WTR::AccessibilityUIElement::lineForIndex):
951         (WTR::AccessibilityUIElement::rangeForLine):
952         (WTR::AccessibilityUIElement::boundsForRange):
953         (WTR::AccessibilityUIElement::setSelectedTextRange):
954         (WTR::AccessibilityUIElement::stringForRange):
955         (WTR::AccessibilityUIElement::attributedStringForRange):
956         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
957         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
958         (WTR::AccessibilityUIElement::cellForColumnAndRow):
959         (WTR::AccessibilityUIElement::horizontalScrollbar):
960         (WTR::AccessibilityUIElement::verticalScrollbar):
961         (WTR::AccessibilityUIElement::addNotificationListener):
962         (WTR::AccessibilityUIElement::removeNotificationListener):
963         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
964         (WTR::AccessibilityUIElement::textMarkerRangeLength):
965         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
966         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
967         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
968         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
969         (WTR::AccessibilityUIElement::textMarkerForPoint):
970         (WTR::AccessibilityUIElement::previousTextMarker):
971         (WTR::AccessibilityUIElement::nextTextMarker):
972         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
973         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: Added.
974         (WTR::AccessibilityUIElement::platformUIElement):
975         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl: Added.
976         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl: Added.
977         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl: Added.
978         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl: Added.
979         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
980         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
981         (WTR::InjectedBundle::beginTesting):
982         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
983         (WTR::InjectedBundle::accessibilityController):
984         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
985         (WTR::InjectedBundlePage::didClearWindowForFrame):
986         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
987         * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp:
988         (WTR::LayoutTestController::platformName):
989         * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerMac.mm: Added.
990         (WTR::AccessibilityTextMarker::isEqual):
991         * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerRangeMac.mm: Added.
992         (WTR::AccessibilityTextMarkerRange::isEqual):
993         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: Added.
994         (+[NSString stringWithJSStringRef:]):
995         (-[NSString createJSStringRef]):
996         (-[AccessibilityNotificationHandler initWithPlatformElement:]):
997         (-[AccessibilityNotificationHandler dealloc]):
998         (-[AccessibilityNotificationHandler _notificationReceived:]):
999         (-[AccessibilityNotificationHandler setCallback:]):
1000         (WTR::AccessibilityUIElement::AccessibilityUIElement):
1001         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
1002         (WTR::AccessibilityUIElement::isEqual):
1003         (WTR::descriptionOfValue):
1004         (WTR::attributesOfElement):
1005         (WTR::concatenateAttributeAndValue):
1006         (WTR::convertNSArrayToVector):
1007         (WTR::descriptionOfElements):
1008         (WTR::AccessibilityUIElement::getLinkedUIElements):
1009         (WTR::AccessibilityUIElement::getDocumentLinks):
1010         (WTR::AccessibilityUIElement::getChildren):
1011         (WTR::AccessibilityUIElement::getChildrenWithRange):
1012         (WTR::AccessibilityUIElement::childrenCount):
1013         (WTR::AccessibilityUIElement::elementAtPoint):
1014         (WTR::AccessibilityUIElement::indexOfChild):
1015         (WTR::AccessibilityUIElement::childAtIndex):
1016         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
1017         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
1018         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
1019         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
1020         (WTR::AccessibilityUIElement::selectedChildAtIndex):
1021         (WTR::AccessibilityUIElement::selectedChildrenCount):
1022         (WTR::AccessibilityUIElement::selectedRowAtIndex):
1023         (WTR::AccessibilityUIElement::titleUIElement):
1024         (WTR::AccessibilityUIElement::parentElement):
1025         (WTR::AccessibilityUIElement::disclosedByRow):
1026         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
1027         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
1028         (WTR::AccessibilityUIElement::attributesOfChildren):
1029         (WTR::AccessibilityUIElement::allAttributes):
1030         (WTR::AccessibilityUIElement::stringAttributeValue):
1031         (WTR::AccessibilityUIElement::numberAttributeValue):
1032         (WTR::AccessibilityUIElement::uiElementAttributeValue):
1033         (WTR::AccessibilityUIElement::boolAttributeValue):
1034         (WTR::AccessibilityUIElement::isAttributeSettable):
1035         (WTR::AccessibilityUIElement::isAttributeSupported):
1036         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
1037         (WTR::AccessibilityUIElement::role):
1038         (WTR::AccessibilityUIElement::subrole):
1039         (WTR::AccessibilityUIElement::roleDescription):
1040         (WTR::AccessibilityUIElement::title):
1041         (WTR::AccessibilityUIElement::description):
1042         (WTR::AccessibilityUIElement::orientation):
1043         (WTR::AccessibilityUIElement::stringValue):
1044         (WTR::AccessibilityUIElement::language):
1045         (WTR::AccessibilityUIElement::helpText):
1046         (WTR::AccessibilityUIElement::x):
1047         (WTR::AccessibilityUIElement::y):
1048         (WTR::AccessibilityUIElement::width):
1049         (WTR::AccessibilityUIElement::height):
1050         (WTR::AccessibilityUIElement::clickPointX):
1051         (WTR::AccessibilityUIElement::clickPointY):
1052         (WTR::AccessibilityUIElement::intValue):
1053         (WTR::AccessibilityUIElement::minValue):
1054         (WTR::AccessibilityUIElement::maxValue):
1055         (WTR::AccessibilityUIElement::valueDescription):
1056         (WTR::AccessibilityUIElement::insertionPointLineNumber):
1057         (WTR::AccessibilityUIElement::isActionSupported):
1058         (WTR::AccessibilityUIElement::isEnabled):
1059         (WTR::AccessibilityUIElement::isRequired):
1060         (WTR::AccessibilityUIElement::isFocused):
1061         (WTR::AccessibilityUIElement::isSelected):
1062         (WTR::AccessibilityUIElement::isExpanded):
1063         (WTR::AccessibilityUIElement::isChecked):
1064         (WTR::AccessibilityUIElement::hierarchicalLevel):
1065         (WTR::AccessibilityUIElement::speak):
1066         (WTR::AccessibilityUIElement::ariaIsGrabbed):
1067         (WTR::AccessibilityUIElement::ariaDropEffects):
1068         (WTR::AccessibilityUIElement::lineForIndex):
1069         (WTR::AccessibilityUIElement::rangeForLine):
1070         (WTR::AccessibilityUIElement::boundsForRange):
1071         (WTR::AccessibilityUIElement::stringForRange):
1072         (WTR::AccessibilityUIElement::attributedStringForRange):
1073         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
1074         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1075         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
1076         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
1077         (WTR::AccessibilityUIElement::attributesOfColumns):
1078         (WTR::AccessibilityUIElement::attributesOfRows):
1079         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
1080         (WTR::AccessibilityUIElement::attributesOfHeader):
1081         (WTR::AccessibilityUIElement::rowCount):
1082         (WTR::AccessibilityUIElement::columnCount):
1083         (WTR::AccessibilityUIElement::indexInTable):
1084         (WTR::AccessibilityUIElement::rowIndexRange):
1085         (WTR::AccessibilityUIElement::columnIndexRange):
1086         (WTR::AccessibilityUIElement::cellForColumnAndRow):
1087         (WTR::AccessibilityUIElement::horizontalScrollbar):
1088         (WTR::AccessibilityUIElement::verticalScrollbar):
1089         (WTR::AccessibilityUIElement::selectedTextRange):
1090         (WTR::AccessibilityUIElement::setSelectedTextRange):
1091         (WTR::AccessibilityUIElement::increment):
1092         (WTR::AccessibilityUIElement::decrement):
1093         (WTR::AccessibilityUIElement::showMenu):
1094         (WTR::AccessibilityUIElement::press):
1095         (WTR::AccessibilityUIElement::setSelectedChild):
1096         (WTR::AccessibilityUIElement::accessibilityValue):
1097         (WTR::AccessibilityUIElement::documentEncoding):
1098         (WTR::AccessibilityUIElement::documentURI):
1099         (WTR::AccessibilityUIElement::url):
1100         (WTR::AccessibilityUIElement::addNotificationListener):
1101         (WTR::AccessibilityUIElement::removeNotificationListener):
1102         (WTR::AccessibilityUIElement::isFocusable):
1103         (WTR::AccessibilityUIElement::isSelectable):
1104         (WTR::AccessibilityUIElement::isMultiSelectable):
1105         (WTR::AccessibilityUIElement::isVisible):
1106         (WTR::AccessibilityUIElement::isOffScreen):
1107         (WTR::AccessibilityUIElement::isCollapsed):
1108         (WTR::AccessibilityUIElement::isIgnored):
1109         (WTR::AccessibilityUIElement::hasPopup):
1110         (WTR::AccessibilityUIElement::takeFocus):
1111         (WTR::AccessibilityUIElement::takeSelection):
1112         (WTR::AccessibilityUIElement::addSelection):
1113         (WTR::AccessibilityUIElement::removeSelection):
1114         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
1115         (WTR::AccessibilityUIElement::textMarkerRangeLength):
1116         (WTR::AccessibilityUIElement::previousTextMarker):
1117         (WTR::AccessibilityUIElement::nextTextMarker):
1118         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
1119         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
1120         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
1121         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
1122         (WTR::AccessibilityUIElement::textMarkerForPoint):
1123         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
1124         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
1125         (WTR::LayoutTestController::platformName):
1126         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
1127         (WTR::LayoutTestController::platformName):
1128         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
1129         (WTR::LayoutTestController::platformName):
1130         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1131         * WebKitTestRunner/win/InjectedBundle.vcproj:
1132
1133 2011-11-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1134
1135         [Qt] Fix use of config.tests
1136
1137         We were checking @buildArgs to determine if the optional argument was
1138         passed or not, but this is not the right way to do that in Perl. The
1139         right way is to not use a prototype for the function, and to pass
1140         the list as a reference (to avoid list expansion). That way we can
1141         check the number of arguments, and choose the right code path based
1142         on that.
1143
1144         We were also missing a default-value of 0 for any feature that's not
1145         set in features.prf.
1146
1147         Reviewed by Kenneth Rohde Christiansen.
1148
1149         * Scripts/build-webkit:
1150         * Scripts/webkitdirs.pm:
1151         (qtFeatureDefaults):
1152         (buildQMakeProject):
1153
1154 2011-11-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1155
1156         [Qt] Prospective fix for broken plugin tests
1157
1158         Don't hide symbols for the NPAPI test plugin
1159
1160         Rubber-stamped by Andreas Kling.
1161
1162         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1163
1164 2011-11-16  Adam Roben  <aroben@apple.com>
1165
1166         Move filenames/line numbers off to the right edge in Leaks Viewer
1167
1168         Fixes <http://webkit.org/b/72510> Callstacks in Leaks Viewer are a little hard to read
1169         because filenames/line numbers are right next to function names
1170
1171         Reviewed by Andreas Kling.
1172
1173         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserImpl.js:
1174         (LeaksParserImpl.prototype._createNode): Separate the filename and line number out from the
1175         function name. Use the filename as the profile node's URL (we don't have enough info to
1176         compute a real URL currently) and the line number as the profile node's line number so the
1177         Inspector code will put them on the right side of the callstack graph.
1178
1179         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
1180         (WebInspector.displayNameForURL): Stubbed this out. For now we don't ever get any URLs
1181         passed here, just filenames.
1182
1183         (WebInspector.linkifyURLAsNode):
1184         (WebInspector.linkifyResourceAsNode):
1185         Copied and slightly modified from inspector.js.
1186
1187 2011-11-16  Adam Roben  <aroben@apple.com>
1188
1189         Make Leaks Viewer load builds from the new Lion Leaks bot
1190
1191         Fixes <http://webkit.org/b/72507> REGRESSION: Leaks Viewer no longer shows recent leaky builds
1192
1193         Reviewed by Andreas Kling.
1194
1195         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1196         (LeaksViewer._displayURLPrompt): Use the Lion Leaks bot instead of the nonexistent
1197         SnowLeopard one.
1198
1199 2011-11-16  Raphael Kubo da Costa  <kubo@profusion.mobi>
1200
1201         [EFL] Clean up the offline apps-related functions in ewk_settings.
1202         https://bugs.webkit.org/show_bug.cgi?id=72132
1203
1204         Reviewed by Kenneth Rohde Christiansen.
1205
1206         `ewk_settings_cache' and `ewk_view_setting_cache' are too common
1207         prefixes for code that is related only to the HTML5 app cache
1208         features.
1209
1210         Use `ewk_settings_application_cache' and
1211         `ewk_view_setting_application_cache' instead.
1212
1213         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1214         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1215
1216 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
1217
1218         [Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions
1219
1220         Reviewed by Tor Arne Vestbø.
1221
1222         * qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions
1223         magic here where we handle all TEMPLATE = lib .pro files (except plugins).
1224         * WebKitTestRunner/InjectedBundle/Target.pri: Mark the injected bundle as plugin, which also
1225         removes the .so.0.0.0 and just produces .so.
1226
1227 2011-11-16  Peter Beverloo  <peter@chromium.org>
1228
1229         Explicitly include unistd.h in TestNetscapePlugIn
1230         https://bugs.webkit.org/show_bug.cgi?id=72385
1231
1232         This is needed for the sleep() call in the indicateTestFailure method,
1233         which seems to be implicitly available for other platforms. This is not
1234         the case on Android.
1235
1236         Reviewed by Steve Block.
1237
1238         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1239
1240 2011-11-16  Peter Beverloo  <peter@chromium.org>
1241
1242         [Chromium] Update the Android NDK version being pulled in by update-webkit-chromium
1243         https://bugs.webkit.org/show_bug.cgi?id=72384
1244
1245         Update to Android NDK r7, which was released last Friday. This adds
1246         support for RTTI and the -mimplicit-it gcc flag, which are required to
1247         respectively build ICU and Skia.
1248
1249         Reviewed by Steve Block.
1250
1251         * Scripts/update-webkit-chromium:
1252         * Scripts/webkitdirs.pm:
1253         (buildChromiumMakefile):
1254
1255 2011-11-16  Simon Hausmann  <simon.hausmann@nokia.com>
1256
1257         Unreviewed, rolling out r100266.
1258         http://trac.webkit.org/changeset/100266
1259
1260         Broke WTR.
1261
1262         * qmake/mkspecs/features/default_post.prf:
1263
1264 2011-11-16  Eric Seidel  <eric@webkit.org>
1265
1266         check-webkit-style broken by r99773: "Could not determine the port"
1267         https://bugs.webkit.org/show_bug.cgi?id=72275
1268
1269         Reviewed by Adam Barth.
1270
1271         I will continue engaging hacks, until windows improves.
1272
1273         * Scripts/webkitpy/common/host.py:
1274          - Host uses self.executive instead of self._executive like Port does.
1275          - I wanted to test this, but it mutates global state -- thus impossible to unittest at this time.
1276
1277 2011-11-16  Eric Seidel  <eric@webkit.org>
1278
1279         check-webkit-style broken by r99773: "Could not determine the port"
1280         https://bugs.webkit.org/show_bug.cgi?id=72275
1281
1282         Reviewed by Adam Barth.
1283
1284         Engage windows hacks harder.
1285
1286         This is a speculative fix for ChromiumWin.  We're now
1287         creating an SCM object much earlier, so we need to
1288         engage our "awesome" windows hacks earlier.
1289
1290         * Scripts/webkitpy/common/host.py:
1291         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1292
1293 2011-11-15  Darin Adler  <darin@apple.com>
1294
1295         DRT's uiElementAttributeValueCallback function is leaky
1296         https://bugs.webkit.org/show_bug.cgi?id=72453
1297
1298         Reviewed by Dan Bernstein.
1299
1300         * DumpRenderTree/AccessibilityUIElement.cpp:
1301         (uiElementAttributeValueCallback): Use JSRetainPtr and don't leak.
1302
1303 2011-11-14  Ryosuke Niwa  <rniwa@webkit.org>
1304
1305         Implement edit-distance based reviewer recognition algorithm
1306         https://bugs.webkit.org/show_bug.cgi?id=72351
1307
1308         Reviewed by Eric Seidel.
1309
1310         Implement an algorithm to recognize reviewer's name based on its edit distance (or more precisely
1311         its Levenshtein distance) to each reviewer's full name, first, last and middle names, and IRC nicknames.
1312         Furthermore, we cap the maximum edit distance at len(name) - 1 to avoid matching a bogus string like
1313         "build fix" to a reviewer's name (e.g. with with edit distance 9).
1314
1315         This algorithm is implemented in CommitterList.contributors_by_fuzzy_match. The function to compute
1316         the edit distance is implemented in edit_distance.py.
1317
1318         Also moved _has_valid_reviewer from ValidateReviewer to ChangeLogEntry because we can no longer rely
1319         on the presence of ChangeLogEntry.reviewer() to verify that reviewer string is nicely formatted.
1320
1321         * Scripts/webkitpy/common/checkout/changelog.py:
1322         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1323         * Scripts/webkitpy/common/config/committers.py:
1324         * Scripts/webkitpy/common/config/committers_unittest.py:
1325         * Scripts/webkitpy/common/editdistance.py: Added.
1326         * Scripts/webkitpy/common/editdistance_unittest.py: Added.
1327         * Scripts/webkitpy/tool/steps/validatereviewer.py:
1328         * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py: Removed.
1329
1330 2011-11-15  Tony Chang  <tony@chromium.org>
1331
1332         Skip a failing webkitpy test on cygwin.
1333
1334         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1335
1336 2011-11-15  Sam Weinig  <sam@webkit.org>
1337
1338         TestWebKitAPI should not put its resources in the root products directory
1339         https://bugs.webkit.org/show_bug.cgi?id=72446
1340
1341         Reviewed by Anders Carlsson.
1342
1343         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1344         Change the copy resources phase to place the resources in a TestWebKitAPI.resources
1345         directory.
1346
1347         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
1348         (TEST_F):
1349         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
1350         (TestWebKitAPI::TEST):
1351         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
1352         (TestWebKitAPI::DeviceScaleFactorOnBack::url):
1353         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
1354         (TestWebKitAPI::DynamicDeviceScaleFactor::url):
1355         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1356         (TestWebKitAPI::Util::createURLForResource):
1357         Update calls to retrieve files from the bundle to look in the newly
1358         created subdirectory.
1359
1360 2011-11-15  Tony Chang  <tony@chromium.org>
1361
1362         Fix a webkitpy test caused by renaming the accelerate-video flag in r100355.
1363
1364         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1365
1366 2011-11-15  Tony Chang  <tony@chromium.org>
1367
1368         Unreviewed, fix test-webkitpy tests.  Move the check for image results
1369         earlier.
1370
1371         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1372         * Scripts/webkitpy/layout_tests/port/webkit.py:
1373
1374 2011-11-15  James Robinson  <jamesr@chromium.org>
1375
1376         [chromium] Fix flag name in chromium DumpRenderTree for accelerated video trigger
1377         https://bugs.webkit.org/show_bug.cgi?id=72444
1378
1379         Reviewed by Adam Barth.
1380
1381         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1382
1383 2011-11-15  Tony Chang  <tony@chromium.org>
1384
1385         Unreviewed, better fix for ref tests failures on SL Intel bot.
1386         Revert the previous change and return None if pixel results from
1387         either the test page or the expected page is missing.
1388
1389         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1390         * Scripts/webkitpy/layout_tests/port/webkit.py:
1391
1392 2011-11-15  James Robinson  <jamesr@chromium.org>
1393
1394         [chromium] Merge chromium-gpu layout test configurations into non-gpu versions
1395         https://bugs.webkit.org/show_bug.cgi?id=72402
1396
1397         Reviewed by Dirk Pranke.
1398
1399         Allows the compositing layout tests to run in the normal layout test run. This sets the default compositing
1400         triggers in DumpRenderTree to more closely match what we use in Chromium. There are two exceptions, canvas 2d
1401         and video (media) are still controlled by an explicit trigger so that they are true when platform=chromium-gpu
1402         and false otherwise, so that we can run the same set of tests in both configurations. This isn't necessary for
1403         the normal compositing triggers since we currently run the compositing tests in only one configuration - with
1404         compositing enabled.
1405
1406         Since the compositing tests are currently marked WONTFIX SKIP on non-GPU platforms in test_expectations.txt this
1407         patch should not impact any tests.
1408
1409         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1410         (main):
1411         * DumpRenderTree/chromium/TestShell.cpp:
1412         (TestShell::TestShell):
1413         (TestShell::resetWebSettings):
1414         * DumpRenderTree/chromium/TestShell.h:
1415         (TestShell::setAcceleratedCompositingForVideoEnabled):
1416         * DumpRenderTree/chromium/WebPreferences.cpp:
1417         (WebPreferences::reset):
1418         (WebPreferences::applyTo):
1419         * DumpRenderTree/chromium/WebPreferences.h:
1420         * Scripts/webkitpy/layout_tests/port/chromium.py:
1421         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1422         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1423
1424 2011-11-15  Tony Chang  <tony@chromium.org>
1425
1426         Unreviewed, try to fix ref tests failures on SL Intel bot.
1427         It looks like ImageDiff isn't returning an image diff.
1428
1429         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1430
1431 2011-11-15  Tony Chang  <tony@chromium.org>
1432
1433         Unreviewed fix of ref-tests on GTK+.
1434         If a driver is never started, _xvfb_process is never set.
1435
1436         * Scripts/webkitpy/layout_tests/port/gtk.py:
1437
1438 2011-11-14  Tony Chang  <tony@chromium.org>
1439
1440         [NRWT] Reftests should run even when pixel tests are disabled.
1441         https://bugs.webkit.org/show_bug.cgi?id=60605
1442
1443         Reviewed by Dirk Pranke.
1444
1445         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Only skip ref tests if --no-ref-tests is passed.
1446             Also add an assert to make sure we get image hashes back when running ref tests.
1447         * Scripts/webkitpy/layout_tests/controllers/worker.py: Use Driver.has_crashed() instead of poll().
1448         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1449         * Scripts/webkitpy/layout_tests/port/chromium.py: Use DriverProxy.
1450         * Scripts/webkitpy/layout_tests/port/driver.py: Add DriverProxy which does the work
1451             of starting a pixel driver if needed.  It handles the logic of sending the test
1452             to the correct driver.  Also renamed Driver.poll() to Driver.has_crashed().
1453         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1454         * Scripts/webkitpy/layout_tests/port/test.py: Switch to using DriverProxy so we get test coverage.
1455         * Scripts/webkitpy/layout_tests/port/webkit.py:
1456         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --no-ref-tests.
1457         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Test --no-ref-tests.
1458
1459 2011-11-15  David Kilzer  <ddkilzer@apple.com>
1460
1461         Don't use File::Slurp for run-leaks unit tests
1462         <http://webkit.org/b/72356>
1463
1464         Reviewed by Daniel Bates.
1465
1466         * Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm: Added.
1467         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
1468         Extracted common package logic into RunLeaks.pm.  Fixed call to
1469         RunLeaks::parseLeaksOutput().
1470         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Ditto.
1471         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Ditto.
1472
1473 2011-11-15  Peter Kasting  <pkasting@google.com>
1474
1475         Handle svn 1.7 when detecting whether a directory is in an svn checkout.
1476         https://bugs.webkit.org/show_bug.cgi?id=72349
1477
1478         Reviewed by Adam Roben.
1479
1480         * Scripts/VCSUtils.pm:
1481         (isSVNDirectory):
1482
1483 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
1484
1485         [Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions
1486
1487         Reviewed by Tor Arne Vestbø.
1488
1489         * qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions
1490         magic here where we handle all TEMPLATE = lib .pro files.
1491
1492 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
1493
1494         [Qt] Unreviewed prospective --minimal build fix.
1495
1496         * DumpRenderTree/qt/DumpRenderTree.pro: Avoid USE_SYSTEM_MALLOC=0
1497         and USE_SYSTEM_MALLOC=1 appearing in DEFINES at the same time.
1498
1499 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
1500
1501         [Qt] Unreviewed --minimal build fix.
1502
1503         * Scripts/build-webkit: Add to DEFINES+= from @options only if there is
1504         a define. The "coverage" option doesn't have one, causing "DEFINES+= =0"
1505         to make moc's preprocessor abort.
1506
1507 2011-11-14  Raphael Kubo da Costa  <kubo@profusion.mobi>
1508
1509         build-webkit: Accept --cmakearg to pass additional arguments to CMake.
1510         https://bugs.webkit.org/show_bug.cgi?id=72156
1511
1512         Reviewed by Daniel Bates.
1513
1514         Similar to --makearg and --qmakearg, --cmakearg lets one pass
1515         additional arguments to CMake (eg. --cmakearg="-DFOO=bar").
1516
1517         * Scripts/build-webkit:
1518         * Scripts/webkitdirs.pm:
1519         (generateBuildSystemFromCMakeProject):
1520
1521 2011-11-14  Ryosuke Niwa  <rniwa@webkit.org>
1522
1523         Improve ChangeLogEntry's reviewer parsing algorithm part 2
1524         https://bugs.webkit.org/show_bug.cgi?id=72340
1525
1526         Reviewed by Eric Seidel.
1527
1528         This patch improves the recognition of NOBODY, wrestler names, and parenthesized clauses,
1529         and prepares ChangeLogEntry to support edit-distance-based reviewer-name recognition.
1530
1531         * Scripts/webkitpy/common/checkout/changelog.py:
1532         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1533
1534 2011-11-14  Eric Seidel  <eric@webkit.org>
1535
1536         check-webkit-style broken by r99773: "Could not determine the port"
1537         https://bugs.webkit.org/show_bug.cgi?id=72275
1538
1539         Reviewed by Adam Barth.
1540
1541         The TestExpectationsChecker was using a generic try/except block
1542         which caught all exceptions, so we didn't notice that failing
1543         to pass a Host to PortFactory was causing an exception in port instantiation.
1544         I've factored out the "lookup the port" logic into a separate function
1545         which I've now unittested.  This should fix the bug and prevent
1546         others like it from occuring the the future.
1547
1548         * Scripts/webkitpy/style/checkers/test_expectations.py:
1549         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1550
1551 2011-11-14  Julien Chaffraix  <jchaffraix@webkit.org>
1552
1553         Add --css-grid-layout to build-webkit and the build systems
1554         https://bugs.webkit.org/show_bug.cgi?id=72320
1555
1556         Reviewed by Ojan Vafai.
1557
1558         * Scripts/build-webkit:
1559         Added the option.
1560
1561 2011-11-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1562
1563         Unreviewed, rolling out r100192.
1564         http://trac.webkit.org/changeset/100192
1565         https://bugs.webkit.org/show_bug.cgi?id=72328
1566
1567         Caused infinite tests to fail (Requested by abarth on
1568         #webkit).
1569
1570         * Scripts/webkitpy/layout_tests/port/base.py:
1571         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1572
1573 2011-11-14  Tony Chang  <tony@chromium.org>
1574
1575         Remove the CSS3_FLEXBOX compile time flag and enable on all ports
1576         https://bugs.webkit.org/show_bug.cgi?id=72196
1577
1578         Reviewed by Ojan Vafai.
1579
1580         * Scripts/build-webkit:
1581
1582 2011-11-14  John Yani  <vanuan@gmail.com>
1583
1584         new-run-webkit-tests should not be locale dependent https://bugs.webkit.org/show_bug.cgi?id=68691
1585         Override LOCALE to en_US.
1586
1587         Reviewed by Eric Seidel.
1588
1589         * Scripts/webkitpy/layout_tests/port/base.py:
1590
1591 2011-11-14  Julien Chaffraix  <jchaffraix@webkit.org>
1592
1593         [Chromium] build-webkit silently drops the features flags
1594         https://bugs.webkit.org/show_bug.cgi?id=72293
1595
1596         Reviewed by Tony Chang.
1597
1598         Chromium still ignores @features but now we give a warning!
1599
1600         * Scripts/build-webkit: Check if one of the features is different
1601         from the default and print a warning in this case.
1602
1603 2011-11-14  David Kilzer  <ddkilzer@apple.com>
1604
1605         run-leaks does not work on Lion?
1606         <http://webkit.org/b/71059>
1607         <rdar://problem/10428527>
1608
1609         Reviewed by Adam Roben.
1610
1611         The output of leaks(1) changed again in Lion to move the
1612         "leaks Report Version: 2.0" line from the first line of the
1613         output to just above the "Process " lines that run-leaks is
1614         interested in parsing.  This required using a more generic
1615         algorithm to find the start of the "Process " lines.
1616
1617         * Scripts/run-leaks:
1618         (parseLeaksOutput): Make the code to skip headers more generic.
1619         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl: Added.
1620         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Added.
1621         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Added.
1622
1623 2011-11-14  Lei Zhang  <thestig@chromium.org>
1624
1625         Missing include in Tools/DumpRenderTree/chromium/AccessibilityUIElement.h:
1626         https://bugs.webkit.org/show_bug.cgi?id=72088
1627
1628         Reviewed by Tony Chang.
1629
1630         * DumpRenderTree/chromium/AccessibilityUIElement.h:
1631
1632 2011-11-14  Andrew Scherkus  <scherkus@chromium.org>
1633
1634         [Chromium] Skip media layout tests on chromium-gpu-cg-mac-leopard platform
1635         https://bugs.webkit.org/show_bug.cgi?id=72147
1636
1637         Reviewed by Adam Barth.
1638
1639         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1640
1641 2011-11-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1642
1643         [Qt] Move the QtWebKit module file to match the layout of Qt's mkspecs
1644
1645         Reviewed by Simon Hausmann.
1646
1647         * qmake/mkspecs/modules/qt_webkit.pri: Renamed from Tools/qmake/qt_webkit.pri.
1648
1649 2011-11-14  Simon Hausmann  <simon.hausmann@nokia.com>
1650
1651         [Qt] Disable plugins on X11 for WK2
1652
1653         Reviewed by Kenneth Rohde Christiansen.
1654
1655         Currently plugins are in-process and they crash in the likely case of
1656         a plugin installation that uses Qt 4, which beautifully clashes with the
1657         Qt 5 based QtWebProcess.
1658
1659         * qmake/mkspecs/features/features.prf:
1660
1661 2011-11-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1662
1663         [Qt] Add support for config tests for Qt 5
1664
1665         This allows us to build and run configure-tests at build
1666         time to determine if a given platform feature is available.
1667
1668         Reviewed by Simon Hausmann.
1669
1670         * Scripts/build-webkit:
1671         * Scripts/webkitdirs.pm:
1672         (qtFeatureDefaults):
1673         * qmake/configure.pro: Added.
1674         * qmake/mkspecs/features/features.prf:
1675         * qmake/sync.profile: Added.
1676
1677 2011-11-11  Pierre Rossi  <pierre.rossi@gmail.com>
1678
1679         [Qt] Remove the QStyle dependency in Qt's mobile theme
1680         https://bugs.webkit.org/show_bug.cgi?id=67773
1681
1682         This refactoring splits up RenderThemeQt with two
1683         subclasses, a QStyle-backed one, and a Mobile version
1684         that uses the old mobile theme for now.
1685
1686         QStyle availability is detected at compile time, and
1687         its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
1688         environment variable.
1689
1690         Reviewed by Simon Hausmann.
1691
1692         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1693         (WTR::activateFonts):
1694         * qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,
1695         based on availability of QtWidgets.
1696         * qmake/mkspecs/features/webcore.prf: cleanup.
1697
1698 2011-11-14  Tony Gentilcore  <tonyg@chromium.org>
1699
1700         Unreviewed, rolling out r100116.
1701         http://trac.webkit.org/changeset/100116
1702
1703         r100104 was rolled out, so no longer needed
1704
1705         * Scripts/run-bindings-tests:
1706
1707 2011-11-14  Tony Gentilcore  <tonyg@chromium.org>
1708
1709         Unreviewed, rolling out r100104.
1710         http://trac.webkit.org/changeset/100104
1711         https://bugs.webkit.org/show_bug.cgi?id=72247
1712
1713         broke windows builds
1714
1715         * Scripts/check-webkit-style:
1716         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1717         * Scripts/webkitpy/common/checkout/deps.py:
1718         * Scripts/webkitpy/common/checkout/scm/__init__.py:
1719         * Scripts/webkitpy/common/checkout/scm/detection.py:
1720         * Scripts/webkitpy/common/checkout/scm/git.py:
1721         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1722         * Scripts/webkitpy/common/checkout/scm/svn.py:
1723         * Scripts/webkitpy/common/host.py:
1724         * Scripts/webkitpy/common/host_mock.py:
1725         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1726         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1727         * Scripts/webkitpy/layout_tests/port/base.py:
1728         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1729         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1730         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1731         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1732
1733 2011-11-14  Philippe Normand  <pnormand@igalia.com>
1734
1735         Unreviewed, build fix after r100104. run-binding-tests broke.
1736
1737         * Scripts/run-bindings-tests: Explicitely use scm.detection.
1738
1739 2011-11-13  Eric Seidel  <eric@webkit.org>
1740
1741         Add SCMDetector object to make scm detection mockable
1742         https://bugs.webkit.org/show_bug.cgi?id=72247
1743
1744         Reviewed by Adam Barth.
1745
1746         I think SCM detection may eventually be rolled into Checkout,
1747         but this patch at least makes it possible to mock code-paths
1748         which rely on scm detection.
1749         In the process of replacing callers of these free-functions
1750         I found that one of the functions was no longer used,
1751         and that one of the callers could instead just use the SCM
1752         object it already had access to through port.host.scm().
1753         I also discovered that I was not calling Host._initialize_scm()
1754         and thus host.scm() was always returning None!
1755
1756         * Scripts/check-webkit-style:
1757         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1758         * Scripts/webkitpy/common/checkout/deps.py:
1759         * Scripts/webkitpy/common/checkout/scm/__init__.py:
1760         * Scripts/webkitpy/common/checkout/scm/detection.py:
1761         * Scripts/webkitpy/common/checkout/scm/git.py:
1762         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1763         * Scripts/webkitpy/common/checkout/scm/svn.py:
1764         * Scripts/webkitpy/common/host.py:
1765         * Scripts/webkitpy/common/host_mock.py:
1766         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1767         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1768         * Scripts/webkitpy/layout_tests/port/base.py:
1769         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1770         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1771         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1772         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1773
1774 2011-11-13  Gavin Peters  <gavinp@chromium.org>
1775
1776         command line control of webcore log channels in chromium DumpRenderTree
1777         https://bugs.webkit.org/show_bug.cgi?id=72126
1778         
1779         The option --webcore-log-channels=<foo>,<bar>,<quux> is the same as
1780         what chromium takes.
1781
1782         Reviewed by Kent Tamura.
1783
1784         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1785         (main):
1786
1787 2011-11-12  Ariya Hidayat  <ariya@sencha.com>
1788
1789         [Qt] Fix minor config typo in the build tool documentation
1790         https://bugs.webkit.org/show_bug.cgi?id=72194
1791
1792         Reviewed by Andreas Kling.
1793
1794         * qmake/README:
1795
1796 2011-11-11  Stephen Chenney  <schenney@chromium.org>
1797
1798         [Chromium] DRT does not have LayoutTestController.pageSizeAndMarginsInPixels
1799         https://bugs.webkit.org/show_bug.cgi?id=49257
1800
1801         Adds the remaining missing layout test functionality for printing.
1802
1803         Reviewed by Darin Fisher.
1804
1805         * DumpRenderTree/chromium/LayoutTestController.cpp:
1806         (LayoutTestController::LayoutTestController): Add bindings for new JS methods
1807         (parsePageNumber): Method to parse JS arguments for a page number
1808         (parsePageNumberSizeMargins): Method to parse JS arguments for page size and margins
1809         (LayoutTestController::pageSizeAndMarginsInPixels): Get the page size and margins for a given page.
1810         (LayoutTestController::isPageBoxVisible): get the visibility status for printing
1811         (LayoutTestController::pageProperty): get a specific CSS property when in printing mode
1812         * DumpRenderTree/chromium/LayoutTestController.h: Add declarations for new methods
1813
1814 2011-11-11  Darin Adler  <darin@apple.com>
1815
1816         Remove all releaseRef implementations except for RetainPtr
1817         https://bugs.webkit.org/show_bug.cgi?id=71423
1818
1819         Reviewed by Julien Chaffraix.
1820
1821         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
1822         (createXMLStringFromWebArchiveData): Use leakRef instead of releaseRef.
1823
1824 2011-11-11  Ryosuke Niwa  <rniwa@webkit.org>
1825
1826         Make ChangeLogEntry's reviewer parsing algorithm support last 4 WebCore change logs
1827         https://bugs.webkit.org/show_bug.cgi?id=72090
1828
1829         Reviewed by Eric Seidel.
1830
1831         Significantly improve ChangeLogEntry's reviewer parsing algorithm. This version can successfully parse
1832         ChangeLog, ChangeLog-2011-10-19, ChangeLog-2011-06-04, ChangeLog-2011-02-16, and ChangeLog-2010-12-06.
1833
1834         yay! r100002.
1835
1836         * Scripts/webkitpy/common/checkout/changelog.py:
1837         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1838
1839 2011-11-11  Tony Chang  <tony@chromium.org>
1840
1841         Remove --force from gclient sync.  The bots seem to have made it past
1842         the update step.
1843
1844         * Scripts/update-webkit:
1845
1846 2011-11-11  Tony Chang  <tony@chromium.org>
1847
1848         Add --force to gclient sync. Once the cq bots cycle, we can remove
1849         this since it slows down the normal sync.
1850
1851         * Scripts/update-webkit:
1852
1853 2011-11-11  Marc-Antoine Ruel  <maruel@chromium.org>
1854
1855         When --force is used, also use --reset
1856         https://bugs.webkit.org/show_bug.cgi?id=72129
1857
1858         Reviewed by Dimitri Glazkov.
1859
1860         * Scripts/update-webkit-chromium:
1861
1862 2011-11-11  Tony Chang  <tony@chromium.org>
1863
1864         allow two chromium drivers to run at the same time in NRWT
1865         https://bugs.webkit.org/show_bug.cgi?id=72067
1866
1867         Reviewed by Dirk Pranke.
1868
1869         * Scripts/webkitpy/layout_tests/port/chromium.py: close_fds=True on
1870             posix prevents the subprocesses from sharing the same fd for stdin.
1871             Sharing the same fd prevents us from closing the files unless all references
1872             to the fd are closed.
1873         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: In addition
1874             to adding a test for this, speed up a test (from 3sec to 0) by fixing
1875             the timeout override. It looks like it regressed in r95875.
1876
1877 2011-11-11  Sheriff Bot  <webkit.review.bot@gmail.com>
1878
1879         Unreviewed, rolling out r99964.
1880         http://trac.webkit.org/changeset/99964
1881         https://bugs.webkit.org/show_bug.cgi?id=72124
1882
1883         Broke too many Qt tests (Requested by tronical_ on #webkit).
1884
1885         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1886         (WTR::activateFonts):
1887         * qmake/mkspecs/features/features.prf:
1888         * qmake/mkspecs/features/webcore.prf:
1889
1890 2011-11-11  Pierre Rossi  <pierre.rossi@gmail.com>
1891
1892         [Qt] Remove the QStyle dependency in Qt's mobile theme
1893         https://bugs.webkit.org/show_bug.cgi?id=67773
1894
1895         This refactoring splits up RenderThemeQt with two
1896         subclasses, a QStyle-backed one, and a Mobile version
1897         that uses the old mobile theme for now.
1898
1899         QStyle availability is detected at compile time, and
1900         its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
1901         environment variable.
1902
1903         Reviewed by Simon Hausmann.
1904
1905         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1906         (WTR::activateFonts):
1907         * qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,
1908         based on availability of QtWidgets.
1909         * qmake/mkspecs/features/webcore.prf: cleanup.
1910
1911 2011-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1912
1913         [Qt] Add missing include to PlatformWebViewQt
1914
1915         Reviewed by Simon Hausmann.
1916
1917         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1918
1919 2011-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1920
1921         [Qt] Fix incremental builds on Windows after buildsystem refactor
1922
1923         The qmake rules to ensure that we run make on the derived sources
1924         before running qmake on the target were inside a unix-scope, which
1925         resulted in flakey builds on Windows.
1926
1927         We now generate a rule on all platforms that ensures that "make qmake"
1928         will always run make on the derived sources. In addition, on platforms
1929         that have GNU make (where "make incremental" does not run "make qmake",
1930         but only "make"), we add a similar rule that ensures that any time the
1931         target makefile is regenerated we first run qmake and make on the derived
1932         sources. This rule relies on GNU make's order-only-prerequisites to
1933         not trigger a qmake-run of the target every time we run make.
1934
1935         https://bugs.webkit.org/show_bug.cgi?id=71778
1936
1937         Reviewed by Simon Hausmann.
1938
1939         * qmake/mkspecs/features/functions.prf:
1940
1941 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
1942
1943         [Qt][WK2] Remove QWebNavigationController
1944         https://bugs.webkit.org/show_bug.cgi?id=72113
1945
1946         Reviewed by Andreas Kling.
1947
1948         Adapt to the move of the QWebNavigationController functions/properties to
1949         QQuickWebView.
1950
1951         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1952         * MiniBrowser/qt/qml/BrowserWindow.qml:
1953
1954 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
1955
1956         [Qt] Build system tweak
1957
1958         Reviewed by Tor Arne Vestbø.
1959
1960         Be a good qmake citizen, return true from our linkStaticLibrary
1961         "test" function.
1962
1963         * qmake/mkspecs/features/functions.prf:
1964
1965 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
1966
1967         [Qt] Add support for QT += webkit-private
1968
1969         Reviewed by Tor Arne Vestbø.
1970
1971         * qmake/qt_webkit.pri: Declare private headers.
1972
1973 2011-11-11  Philippe Normand  <pnormand@igalia.com>
1974
1975         Unreviewed, build fix attempt after r99907. Since that revision
1976         GTK layout tests were not running at all...
1977
1978         * Scripts/webkitpy/layout_tests/port/gtk.py:
1979
1980 2011-11-10  Andrew Scherkus  <scherkus@chromium.org>
1981
1982         [Chromium] only run media GPU layout tests on platforms supporting accelerated compositing
1983         https://bugs.webkit.org/show_bug.cgi?id=72001
1984
1985         Reviewed by Dirk Pranke.
1986
1987         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1988
1989 2011-11-05  Filip Pizlo  <fpizlo@apple.com>
1990
1991         bencher script should support remote benchmarking
1992         https://bugs.webkit.org/show_bug.cgi?id=71618
1993
1994         Rubber-stamped by Geoff Garen.
1995         
1996         Added the following features:
1997         
1998         - Benchmark report tells you the hostname and machine model (according to
1999           'sysctl hw.model') of the machine you did the run on, and svn revision number
2000           (according to 'svn info') of the VMs you're testing.
2001         
2002         - The --remote option. You give this an ssh-style hostname (i.e. user@host is
2003           acceptable, in addition to just host, in which case your username is used)
2004           and it automatically packages the build directories of the VMs you're testing,
2005           sends them to the remote machine along with your copy of the bencher script
2006           and all of the options you passed.  This pretty much seamlessly allows you
2007           to run a set of benchmarks on any machine that is sufficiently compatible with
2008           yours (i.e. similar OS) and that has the appropriate ~/.bencher file, which
2009           must now include a tempPath setting that tells bencher where to put files
2010           when that machine is used as a slave in a remote benchmarking run.
2011           
2012         - Added yet another way of specifying which benchmarks to run. This was sort of
2013           necessary for --remote to work as expected. Previously, you either said what
2014           suites to exclude (for example --exclude-sunspider) or that you only wanted
2015           to run one suite to the exclusion of others (--sunspider-only). But it's
2016           often better to just be able to specify the list of suites you want. This is
2017           now supported. You can say, for example, --v8 --sunspider, which means, just
2018           run V8 and SunSpider. This is equivalent to saying --exclude-kraken, which is
2019           still supported.
2020
2021         * Scripts/bencher:
2022
2023 2011-11-10  Tony Chang  <tony@chromium.org>
2024
2025         Lazily start DRT instances in NRWT
2026         https://bugs.webkit.org/show_bug.cgi?id=72038
2027
2028         Reviewed by Eric Seidel.
2029
2030         Just a refactoring, no new tests.
2031
2032         * Scripts/webkitpy/layout_tests/controllers/worker.py:
2033         * Scripts/webkitpy/layout_tests/port/chromium.py:
2034         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2035         * Scripts/webkitpy/layout_tests/port/test.py:
2036         * Scripts/webkitpy/layout_tests/port/webkit.py:
2037
2038 2011-11-10  Ryosuke Niwa  <rniwa@webkit.org>
2039
2040         ChangeLog mistakenly recognizes any string between '*' and ':' as touched files
2041         https://bugs.webkit.org/show_bug.cgi?id=72057
2042
2043         Reviewed by Eric Seidel.
2044
2045         Make the regular expression more explicit.
2046
2047         * Scripts/webkitpy/common/checkout/changelog.py:
2048         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2049
2050 2011-11-10  Balazs Kelemen  <kbalazs@webkit.org>
2051
2052         [Qt] X11 plugins need to be reworked for Qt5
2053         https://bugs.webkit.org/show_bug.cgi?id=70023
2054
2055         Reviewed by Simon Hausmann.
2056
2057         Rework our basic plugin support in a way that does
2058         not need a bridge between Qt and X. The solution is
2059         based on getting the content drawed by the plugin
2060         from the server as an image and creating a QImage
2061         from it.
2062
2063         * qmake/mkspecs/features/features.prf: Enable X11
2064         plugins if Qt is built with the xcb-xlib backend.
2065
2066 2011-11-10  Simon Hausmann  <simon.hausmann@nokia.com>
2067
2068         [Qt] Fix keyboard related layout tests after API refactoring
2069
2070         Reviewed by Tor Arne Vestbø.
2071
2072         Send key events to the handling page item, not the view.
2073
2074         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2075         (WTR::PlatformWebView::sendEvent):
2076         (WTR::PlatformWebView::postEvent):
2077
2078 2011-11-10  Alexandre Mazari  <amazari@igalia.com>
2079
2080         [GTK] Make the ENABLE(FEATURE) macro work in DRT
2081         https://bugs.webkit.org/show_bug.cgi?id=71940
2082
2083         Reviewed by Philippe Normand.
2084
2085         * GNUmakefile.am:
2086         Add webcore_cppflags to Programs_DumpRenderTree_CPP so
2087         ENABLE_* variables are part of the environment.
2088
2089 2011-11-10  Simon Hausmann  <simon.hausmann@nokia.com>
2090
2091         [Qt] Fix focus related layout tests after API refactoring
2092
2093         Reviewed by Tor Arne Vestbø.
2094
2095         Make sure the focus is set on the page now, not on the view
2096         (which doesn't actually handle the focus).
2097
2098         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2099         (WTR::WrapperWindow::WrapperWindow):
2100         (WTR::WrapperWindow::handleStatusChanged):
2101
2102 2011-11-10  Alexis Menard  <alexis.menard@openbossa.org>
2103
2104         [Qt] Merge QTouchWebView and QDesktopWebView into one class
2105         https://bugs.webkit.org/show_bug.cgi?id=71355
2106
2107         Reviewed by Kenneth Rohde Christiansen.
2108
2109         Make MiniBrowser and WebKitTestRunner work again after the
2110         merge.
2111
2112         * MiniBrowser/qt/BrowserWindow.cpp:
2113         (BrowserWindow::BrowserWindow):
2114         (BrowserWindow::webView):
2115         * MiniBrowser/qt/MiniBrowser.pro:
2116         * MiniBrowser/qt/MiniBrowser.qrc:
2117         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2118         * MiniBrowser/qt/main.cpp:
2119         * MiniBrowser/qt/qml/BrowserWindow.qml:
2120         * MiniBrowser/qt/qml/DesktopView.qml: Removed.
2121         * MiniBrowser/qt/qml/TouchView.qml: Removed.
2122         * WebKitTestRunner/PlatformWebView.h:
2123         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2124         (WTR::PlatformWebView::PlatformWebView):
2125
2126 2011-11-10  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2127
2128         [Qt] Change semantics of the haveQt() function to match API promises
2129
2130         Having Qt 5 does not imply that we have Qt 4, from an API point of
2131         view, as a major version can in theory break BC/SC. Our minimum
2132         version of Qt 4 will always be the latest released version of Qt 4,
2133         so the only place we should use haveQt(4, x) is when checking for
2134         the minimum requirements.
2135
2136         Reviewed by Simon Hausmann.
2137
2138         * qmake/mkspecs/features/default_pre.prf:
2139         * qmake/mkspecs/features/features.prf:
2140         * qmake/mkspecs/features/functions.prf:
2141
2142 2011-11-07  Kaustubh Atrawalkar  <kaustubh@motorola.com> and Sergio Villar Senin  <svillar@igalia.com>
2143
2144         [WK2] [GTK] Implement a MouseDown/MouseUp/MouseMoveTo/MouseScrollBy/LeapForward functions for WebKit2 EventSender
2145         https://bugs.webkit.org/show_bug.cgi?id=69411
2146
2147         Reviewed by Martin Robinson.
2148
2149         * WebKitTestRunner/EventSenderProxy.h:
2150         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2151         * WebKitTestRunner/TestController.cpp:
2152         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2153         use the EventSender instead of WebProcess Event Simulation.
2154         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2155         (WTR::WTREventQueueItem::WTREventQueueItem):
2156         (WTR::EventSenderProxy::EventSenderProxy):
2157         (WTR::getMouseButtonModifiers):
2158         (WTR::eventSenderButtonToGDKButton):
2159         (WTR::EventSenderProxy::createMouseButtonEvent):
2160         (WTR::EventSenderProxy::updateClickCountForButton):
2161         (WTR::EventSenderProxy::replaySavedEvents):
2162         (WTR::EventSenderProxy::sendOrQueueEvent):
2163         (WTR::webkitModifiersToGDKModifiers):
2164         (WTR::getGDKKeySymForKeyRef):
2165         (WTR::EventSenderProxy::keyDown):
2166         (WTR::EventSenderProxy::mouseDown):
2167         (WTR::EventSenderProxy::mouseUp):
2168         (WTR::EventSenderProxy::mouseMoveTo):
2169         (WTR::EventSenderProxy::mouseScrollBy):
2170         (WTR::EventSenderProxy::leapForward):
2171
2172 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2173
2174         [Qt] Enable exports and constructor functions in static libs
2175
2176         Reviewed by Tor Arne Vestbø.
2177
2178         * qmake/mkspecs/features/functions.prf: Use --whole-archive and their
2179         mac/win32-msvc equivalents when linking static libraries into a shared
2180         library or executable.
2181
2182 2011-11-09  Hayato Ito  <hayato@chromium.org>
2183
2184         [NRWT] Make results.html aware of reference filename in reftests.
2185         https://bugs.webkit.org/show_bug.cgi?id=71574
2186
2187         Reviewed by Ryosuke Niwa.
2188
2189         If a reference filename is different from the default one, include that in result summary
2190         so results.html can link to the correct reference file.
2191
2192         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2193         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2194
2195 2011-11-09  Kevin Ollivier  <kevino@theolliviers.com>
2196
2197         [wx] Unreviewed build fix. Update project files and
2198         add LTC stubs for new methods.
2199
2200         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2201         (LayoutTestController::addChromeInputField):
2202         (LayoutTestController::removeChromeInputField):
2203         (LayoutTestController::focusWebView):
2204         (LayoutTestController::setBackingScaleFactor):
2205         * waf/build/settings.py:
2206
2207 2011-11-09  Kevin Ollivier  <kevino@theolliviers.com>
2208
2209         [wx] Unreviewed build fix. Support XCode 4 when building deps.
2210
2211         * wx/install-unix-extras:
2212
2213 2011-11-09  Eric Seidel  <eric@webkit.org>
2214
2215         Remove the concept of platform-dependent unittests
2216         https://bugs.webkit.org/show_bug.cgi?id=71963
2217
2218         Unreviewed.  Fix test-webkitpy on cygwin.
2219
2220         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2221
2222 2011-11-09  Dana Jansens  <danakj@chromium.org>
2223
2224         Add cc-bugs group to watch changes in chromium graphics
2225         https://bugs.webkit.org/show_bug.cgi?id=71690
2226
2227         Reviewed by David Levin.
2228
2229         * Scripts/webkitpy/common/config/committers.py: Make new Account superclass for non-contributor watch accounts
2230         * Scripts/webkitpy/common/config/committers_unittest.py: Test the Account superclass
2231         * Scripts/webkitpy/common/config/watchlist: Add cc-bugs@google.com to watch list
2232         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Check for Accounts also, but require it to be the bugzilla email for any Account/Contributor/etc.
2233
2234 2011-11-09  Eric Seidel  <eric@webkit.org>
2235
2236         Remove more platform-dependent unittests
2237         https://bugs.webkit.org/show_bug.cgi?id=71971
2238
2239         Reviewed by Adam Barth.
2240
2241         Tests which only run on a couple platforms will break.
2242         All tests should run on all platforms where possible.
2243
2244         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2245         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2246         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2247         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2248
2249 2011-11-09  Ojan Vafai  <ojan@chromium.org>
2250
2251         Merge in results to the test results server even if build numbers conflict
2252         https://bugs.webkit.org/show_bug.cgi?id=71967
2253
2254         Reviewed by Tony Chang.
2255
2256         This was initially meant to be a sanity check that we don't
2257         enter duplicate runs, but it turns out that we can reasonably get
2258         in these situations when a builder is clobbered (e.g. the build
2259         numbers start over again from 0).
2260
2261         * TestResultServer/model/jsonresults.py:
2262         * TestResultServer/model/jsonresults_unittest.py:
2263
2264 2011-11-09  Eric Seidel  <eric@webkit.org>
2265
2266         Remove the concept of platform-dependent unittests
2267         https://bugs.webkit.org/show_bug.cgi?id=71963
2268
2269         Reviewed by Adam Barth.
2270
2271         These have been the source of never-ending sadness.
2272         We'd change behavior and forget to update results in
2273         some unittests because they were only run on certain platforms.
2274         This change removes a large source of these platform-dependent
2275         unittests, which was caused by the port_maker stuff.
2276
2277         It's possible that this change will break test-webkitpy
2278         on some platforms, but that will be a one-time cost.
2279         I will fix the breakage by removing the platform-dependantness
2280         of any such broken tests.
2281
2282         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2283         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2284         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2285         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2286         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2287         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2288         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
2289         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2290         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2291         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2292         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2293         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2294         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2295
2296 2011-11-09  Eric Seidel  <eric@webkit.org>
2297
2298         Make the Port object have a Host
2299         https://bugs.webkit.org/show_bug.cgi?id=71961
2300
2301         Reviewed by Adam Barth.
2302
2303         This has been a long time coming.
2304         Now that Port has a Host object, it's very easy
2305         to write unittests which use a properly mocked Port.
2306         Soon we will remove the executive, filesystem and user
2307         members of Port and get everything through the Host.
2308
2309         Note how in many callsites we're actually removing
2310         explicit mocks, since we're now always going to get the
2311         correct Executive/User/FileSystem from the
2312         Host and callsites don't need to be careful to pass each one.
2313
2314         This is prep-work for adding a new Environment member to
2315         Host and needing to be able to access the Environment
2316         member from Port functions w/o needing to pass an Environment
2317         object (or appropriate Mock) every place we create a Port object.
2318         Now that we have a single Host object to reach out through, its
2319         simple to add additional functionality (like Environment) while
2320         keeping our unittests properly mocked.
2321
2322         * Scripts/webkitpy/common/host.py:
2323         * Scripts/webkitpy/common/net/credentials_unittest.py:
2324         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2325         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2326         * Scripts/webkitpy/layout_tests/port/apple.py:
2327         * Scripts/webkitpy/layout_tests/port/base.py:
2328         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2329         * Scripts/webkitpy/layout_tests/port/chromium.py:
2330         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2331         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2332         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2333         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2334         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2335         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2336         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2337         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2338         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2339         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2340         * Scripts/webkitpy/layout_tests/port/efl.py:
2341         * Scripts/webkitpy/layout_tests/port/factory.py:
2342         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2343         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2344         * Scripts/webkitpy/layout_tests/port/gtk.py:
2345         * Scripts/webkitpy/layout_tests/port/mac.py:
2346         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2347         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2348         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2349         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2350         * Scripts/webkitpy/layout_tests/port/qt.py:
2351         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2352         * Scripts/webkitpy/layout_tests/port/test.py:
2353         * Scripts/webkitpy/layout_tests/port/webkit.py:
2354         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2355         * Scripts/webkitpy/layout_tests/port/win.py:
2356         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2357         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2358         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
2359         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
2360         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
2361
2362 2011-11-09  Dominic Mazzoni  <dmazzoni@google.com>
2363
2364         [Chromium] Implement AccessibilityUIElement::insertionPointLineNumberGetterCallback
2365         https://bugs.webkit.org/show_bug.cgi?id=71561
2366
2367         Reviewed by Dimitri Glazkov.
2368
2369         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2370         (AccessibilityUIElement::insertionPointLineNumberGetterCallback):
2371
2372 2011-11-09  Benjamin Poulain  <bpoulain@apple.com>
2373
2374         Implement dumpProgressFinishedCallback() for Mac layoutTestController
2375         https://bugs.webkit.org/show_bug.cgi?id=66772
2376
2377         Reviewed by Simon Fraser.
2378
2379         When dumpProgressFinishedCallback is enabled, DumpRenderTree should output
2380         "postProgressFinishedNotification" on FrameLoaderClient::postProgressFinishedNotification().
2381
2382         On Mac, the FrameLoaderClient post a notification. This patch add handling for this notification
2383         in the FrameLoadDelegate and print the output in response to the notification.
2384
2385         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2386         (-[FrameLoadDelegate init]):
2387         (-[FrameLoadDelegate dealloc]):
2388         (-[FrameLoadDelegate webViewProgressFinishedNotification:]):
2389
2390 2011-11-09  Philippe Normand  <pnormand@igalia.com>
2391
2392         [GTK][DRT] window internals object is not reset after each test
2393         https://bugs.webkit.org/show_bug.cgi?id=71890
2394
2395         Reviewed by Martin Robinson.
2396
2397         Call WebCoreTestSupport::resetInternalsObject without going
2398         through DumpRenderTreeSupport.
2399
2400         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2401         (runTest):
2402
2403 2011-11-09  Beth Dakin  <bdakin@apple.com>
2404
2405         Build fix.
2406
2407         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2408         (AccessibilityUIElement::uiElementAttributeValue):
2409
2410 2011-11-09  Beth Dakin  <bdakin@apple.com>
2411
2412         Speculative build fix.
2413
2414         * DumpRenderTree/AccessibilityUIElement.h:
2415
2416 2011-11-09  Julien Chaffraix  <jchaffraix@webkit.org>
2417
2418         Unreviewed build fix.
2419
2420         * DumpRenderTree/AccessibilityUIElement.cpp:
2421         (AccessibilityUIElement::makeJSAccessibilityUIElement):
2422         A bad merge added this check that is making the bots sad.
2423
2424 2011-11-09  Chris Fleizach  <cfleizach@apple.com>
2425
2426         AX: crash when accessing selectedTab in a tab list
2427         https://bugs.webkit.org/show_bug.cgi?id=70938
2428
2429         Reviewed by Beth Dakin.
2430
2431         Add the ability to retrieve an element through an arbitrary attribute.
2432
2433         * DumpRenderTree/AccessibilityUIElement.cpp:
2434         (uiElementAttributeValueCallback):
2435         (AccessibilityUIElement::uiElementAttributeValue):
2436         (AccessibilityUIElement::getJSClass):
2437         * DumpRenderTree/AccessibilityUIElement.h:
2438         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2439         (AccessibilityUIElement::uiElementAttributeValue):
2440
2441 2011-11-09  Andy Wingo  <wingo@igalia.com>
2442
2443         Add webkitdirs.pm:getArchitecture implementation for GTK
2444         https://bugs.webkit.org/show_bug.cgi?id=71370
2445
2446         Reviewed by Xan Lopez.
2447
2448         * Scripts/webkitdirs.pm (determineArchitecture): Add an
2449         implementation for ports using autotools, so that a vanilla
2450         `run-javascriptcore-tests --gtk' invocation doesn't pass --32-bit
2451         to build-jsc on x86-64 machines.
2452
2453 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2454
2455         Unreviewed, rolling out r99707.
2456         http://trac.webkit.org/changeset/99707
2457
2458         Re-enable until we can disable it together with tests in one
2459         shot.
2460
2461         * qmake/mkspecs/features/features.prf:
2462
2463 2011-11-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2464
2465         [Qt] Disable use of QtUiTools if the library/module is not found
2466
2467         We rely on the lookup order of prf files to inject our own uitools.prf
2468         that will verify that QtUiTools is in fact present before allowing the
2469         CONFIG += uitools to have any effect.
2470
2471         Reviewed by Simon Hausmann.
2472
2473         * DumpRenderTree/qt/DumpRenderTree.pro:
2474         * QtTestBrowser/QtTestBrowser.pro:
2475         * qmake/mkspecs/features/uitools.prf: Added.
2476
2477 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2478
2479         Unreviewed, rolling out r99701.
2480         http://trac.webkit.org/changeset/99701
2481
2482         Breaks Qt mac build
2483
2484         * qmake/mkspecs/features/functions.prf:
2485
2486 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2487
2488         [Qt] Prospective build fix for Win32/Mac with xmlpatterns
2489
2490         Reviewed by Tor Arne Vestbø.
2491
2492         * qmake/mkspecs/features/features.prf: Disable XSLT support initially.
2493         We default to XSLT support if qxmlpatterns is available. However qxmlpatterns
2494         is not up to the task of full XSLT support, so we should disable it.
2495
2496 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2497
2498         [Qt] Enable exports and constructor functions in static libs
2499
2500         Reviewed by Tor Arne Vestbø.
2501
2502         * qmake/mkspecs/features/functions.prf: Use --whole-archive and their
2503         mac/win32-msvc equivalents when linking static libraries into a shared
2504         library or executable.
2505
2506 2011-11-09  Philippe Normand  <pnormand@igalia.com>
2507
2508         [GTK][DRT] window internals object is not reset after each test
2509         https://bugs.webkit.org/show_bug.cgi?id=71890
2510
2511         Reviewed by Xan Lopez.
2512
2513         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2514         (runTest): reset the Internals object after each test.
2515
2516 2011-11-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2517
2518         [Qt] Detect presence of QtUiTools and enable it only when available
2519
2520         The disable_uitools option was a workaround for missing detection.
2521
2522         Reviewed by Simon Hausmann.
2523
2524         * QtTestBrowser/QtTestBrowser.pro:
2525         * qmake/mkspecs/features/default_post.prf:
2526         * qmake/mkspecs/features/default_pre.prf:
2527
2528 2011-11-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2529
2530         [Qt] Don't override config for the build_pass of debug_and_release
2531
2532         Qmake will parse the profile once for each configuration (debug and
2533         release), with the build_pass option set. In that situation we don't
2534         want to override what qmake is setting explicitly, otherwise the
2535         debug-step will end up hitting all the release-scopes.
2536
2537         Reviewed by Simon Hausmann.
2538
2539         * qmake/mkspecs/features/default_pre.prf:
2540
2541 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2542
2543         [Qt] Unbreak the Qt build (copy & paste mistake - oops)
2544
2545         * qmake/mkspecs/features/functions.prf:
2546
2547 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2548
2549         [Qt] Centralize duplicated code for linking the static libs
2550
2551         Reviewed by Tor Arne Vestbø.
2552
2553         * qmake/mkspecs/features/functions.prf:
2554         * qmake/mkspecs/features/javascriptcore.prf:
2555         * qmake/mkspecs/features/webcore.prf:
2556         * qmake/mkspecs/features/webkit2.prf:
2557
2558 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2559
2560         [Qt] Build system cleanup
2561         https://bugs.webkit.org/show_bug.cgi?id=71815
2562
2563         Reviewed by Kenneth Rohde Christiansen.
2564
2565         * WebKitTestRunner/InjectedBundle/Target.pri: We don't need to link against the webkit2
2566         static library.
2567         * qmake/mkspecs/features/javascriptcore.prf: The wtf sources pull in a glib dependency
2568         (ownPtr functions for glib types). Propagate that to everyone using javascriptcore.
2569
2570 2011-11-08  Hayato Ito  <hayato@chromium.org>
2571
2572         [NRWT] Make single_test_runner aware of reference filename of test_input.
2573         https://bugs.webkit.org/show_bug.cgi?id=71567
2574
2575         Reviewed by Ryosuke Niwa.
2576
2577         Make single_test_runner honor a reference filename of given test_input so that
2578         we can use any file as reference html, instead of depending on implicit naming convention.
2579         The typical use case is to support w3c reftests.
2580
2581         No tests since no functional changes until there is a client.
2582         Test should be easily written with future clients.
2583
2584         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2585         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2586         * Scripts/webkitpy/layout_tests/models/test_failures.py:
2587         * Scripts/webkitpy/layout_tests/models/test_input.py:
2588
2589 2011-11-08  Lucas Forschler  <lforschler@apple.com>
2590
2591         https://bugs.webkit.org/show_bug.cgi?id=71839
2592         Update the leaks bot OS to Lion.
2593         Update the config.json to reflect the update.
2594
2595         Reviewed by Stephanie Lewis.
2596
2597         * BuildSlaveSupport/build.webkit.org-config/config.json:
2598
2599 2011-11-08  Sheriff Bot  <webkit.review.bot@gmail.com>
2600
2601         Unreviewed, rolling out r99626.
2602         http://trac.webkit.org/changeset/99626
2603         https://bugs.webkit.org/show_bug.cgi?id=71866
2604
2605         "C++ exceptions cannot be disabled without influencing the
2606         Objective-C exceptions" (Requested by benjaminp on #webkit).
2607
2608         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2609
2610 2011-11-08  Benjamin Poulain  <bpoulain@apple.com>
2611
2612         [Mac] Disable C++ exceptions from DumpRenderTree
2613         https://bugs.webkit.org/show_bug.cgi?id=71834
2614
2615         Reviewed by Darin Adler.
2616
2617         DumpRenderTree Mac does not handle C++ exceptions. When such exception
2618         happens, it tends to cause the AutoReleasePool stack to be corrupted,
2619         which leads to crashes long after the exception was raised.
2620
2621         This patch disabled C++ exceptions in order to catch the problems where
2622         they happen when a C++ exception is raised.
2623
2624         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2625
2626 2011-11-08  Julien Chaffraix  <jchaffraix@webkit.org>
2627
2628         Moved myself to the reviewer list (yay!).
2629
2630         * Scripts/webkitpy/common/config/committers.py:
2631
2632 2011-11-08  Zeno Albisser  <zeno@webkit.org>
2633
2634         Added myself as a committer.
2635
2636         * Scripts/webkitpy/common/config/committers.py:
2637
2638 2011-11-08  Andy Wingo  <wingo@igalia.com>
2639
2640         Skip some ECMAScript tests that fail on Linux in some time zones.
2641         https://bugs.webkit.org/show_bug.cgi?id=71371
2642
2643         Reviewed by Martin Robinson.
2644
2645         * Scripts/run-javascriptcore-tests: Skip some more tests.
2646
2647 2011-11-08  Csaba Osztrogonác  <ossy@webkit.org>
2648
2649         [Qt] Unreviewed trivial fix after build system refactoring.
2650
2651         * Scripts/run-qtwebkit-tests: Fix path of QtWebProcess for QML tests.
2652
2653 2011-11-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2654
2655         [Qt] Don't set OBJECTS_DIR and DEFINES in default_pre
2656
2657         If a pro file needs to access the OBJECTS_DIR it should use the
2658         form ${QMAKE_VAR_OBJECTS_DIR} to ensure the value is evaluated
2659         after defaults_post has been processed.
2660
2661         Setting DEFINES in defaults_pre is also bad, as any DEFINES=foo on
2662         the command line will override whatever we set in defaults_pre.
2663
2664         Reviewed by Simon Hausmann.
2665
2666         * qmake/mkspecs/features/default_post.prf:
2667         * qmake/mkspecs/features/default_pre.prf:
2668
2669 2011-11-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2670
2671         [Qt] Prevent duplicated sources in SOURCES/OBJECTIVE_SOURCES
2672
2673         Reviewed by Simon Hausmann.
2674
2675         * qmake/mkspecs/features/default_post.prf:
2676
2677 2011-11-07  Zeno Albisser  <zeno.albisser@nokia.com>
2678
2679         [Qt][WK2] MiniBrowser should use urlFromUserInput()
2680         https://bugs.webkit.org/show_bug.cgi?id=71680
2681
2682         Use urlFromUserInput() / QUrl::fromUserInput() to automatically
2683         complete urls in MiniBrowser.
2684
2685         Reviewed by Tor Arne Vestbø.
2686
2687         * MiniBrowser/qt/BrowserWindow.cpp:
2688         (BrowserWindow::BrowserWindow):
2689         (BrowserWindow::load):
2690         * MiniBrowser/qt/qml/BrowserWindow.qml:
2691         * MiniBrowser/qt/utils.cpp:
2692         (Utils::urlFromUserInput):
2693         * MiniBrowser/qt/utils.h:
2694         (Utils::Utils):
2695
2696 2011-11-07  Yuqiang Xian  <yuqiang.xian@intel.com>
2697
2698         Added myself as a committer.
2699
2700         * Scripts/webkitpy/common/config/committers.py:
2701
2702 2011-11-07  Csaba Osztrogonác  <ossy@webkit.org>
2703
2704         Unreviewed webkitpy test fix after r99512.
2705
2706         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2707         Xianzhu Wang is now a committer, so we can't nominate him as a committer anymore.
2708
2709 2011-11-07  Xianzhu Wang  <wangxianzhu@chromium.org>
2710
2711         Added myself as a committer.
2712
2713         * Scripts/webkitpy/common/config/committers.py:
2714
2715 2011-11-07  Sheriff Bot  <webkit.review.bot@gmail.com>
2716
2717         Unreviewed, rolling out r99470.
2718         http://trac.webkit.org/changeset/99470
2719         https://bugs.webkit.org/show_bug.cgi?id=71740
2720
2721         "Broke test-webkitpy" (Requested by eseidel2 on #webkit).
2722
2723         * Scripts/webkitpy/common/config/watchlist:
2724
2725 2011-11-07  Tony Chang  <tony@chromium.org>
2726
2727         [chromium] update flakiness dashboard to reflect current bots
2728
2729         Reviewed by Ojan Vafai.
2730
2731         * TestResultServer/static-dashboards/builders.js: Remove (deps) debug
2732             bots and merged linux debug bots into a single bot.
2733         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2734         (setupExpectationsTest):
2735
2736 2011-11-07  Dana Jansens  <danakj@chromium.org>
2737
2738         Add cc-bugs group to watch changes in chromium graphics
2739         https://bugs.webkit.org/show_bug.cgi?id=71690
2740
2741         Reviewed by James Robinson.
2742
2743         * Scripts/webkitpy/common/config/watchlist:
2744
2745 2011-11-07  Balazs Ankes  <Ankes.Balazs@stud.u-szeged.hu>
2746
2747         [NRWT] Parsing of test_expectations.txt should be agnostic to newline at end
2748         https://bugs.webkit.org/show_bug.cgi?id=70912
2749
2750         Reviewed by Ojan Vafai.
2751
2752         * Scripts/webkitpy/layout_tests/port/webkit.py: Add newline at the end of test_expectations.txt.
2753         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Make up the test_test_expectations method for the updated webkit.py.
2754
2755 2011-11-07  Eric Seidel  <eric@webkit.org>
2756
2757         new-run-webkit-tests: support --repeat-each feature from old-run-webkit-tests
2758         https://bugs.webkit.org/show_bug.cgi?id=62199
2759
2760         Reviewed by Dirk Pranke.
2761
2762         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2763         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2764         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2765
2766 2011-11-07  Fady Samuel  <fsamuel@chromium.org>
2767
2768         [Chromium] Rename WebView::scalePage to WebView::setPageScaleFactor to match WebCore
2769         https://bugs.webkit.org/show_bug.cgi?id=71485
2770
2771         Reviewed by Darin Fisher.
2772
2773         * DumpRenderTree/chromium/EventSender.cpp:
2774         (EventSender::scalePageBy):
2775         * DumpRenderTree/chromium/TestShell.cpp:
2776         (TestShell::resetTestController):
2777
2778 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2779
2780         [Qt] Put the jsc binary in 'bin' instead of leaving it deep in the build tree
2781
2782         Allows us to not package up the whole Source/JavaScriptCore directory for the
2783         buildbots.
2784
2785         Reviewed-by Simon Hausmann.
2786
2787         * BuildSlaveSupport/built-product-archive:
2788         * Scripts/webkitdirs.pm:
2789         (jscProductDir):
2790
2791 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2792
2793         [Qt] Ensure we always export symbols for the QtWebKit API when building WebKit
2794
2795         Reviewed-by Simon Hausmann.
2796
2797         * qmake/mkspecs/features/default_post.prf:
2798
2799 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2800
2801         [Qt] Sanitize qmake paths correctly before comparing
2802
2803         The qmake function toSanitizedPath had a bug causing empty paths on MinGW,
2804         which caused us to always generate derived webcore sources, but never build
2805         them. The bug has been fixed, and we now also sanitize paths for the injected
2806         bundle derived sources.
2807
2808         Reviewed by Simon Hausmann.
2809
2810         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
2811         * qmake/mkspecs/features/functions.prf:
2812
2813 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2814
2815         [Qt] Print right order for changing feature defines
2816
2817         Reviewed by Simon Hausmann.
2818
2819         * Scripts/webkitdirs.pm:
2820         (buildQMakeProject):
2821
2822 2011-11-06  Csaba Osztrogonác  <ossy@webkit.org>
2823
2824         [Qt] Unreviewed trivial fix after build system refactoring.
2825
2826         * Scripts/run-qtwebkit-tests: Fix qml_import_path.
2827
2828 2011-11-06  Eric Seidel  <eric@webkit.org>
2829
2830         Clarify how the symbol and runtime-feature based test exclusion works and cleanup the code a bit
2831         https://bugs.webkit.org/show_bug.cgi?id=66078
2832
2833         Unreviewed.  Add an assert about the type of "args"
2834         to our Executive Mocks and fix a piece of code
2835         from this patch which was hitting that assert
2836         when executing for real.
2837
2838         * Scripts/webkitpy/common/system/executive_mock.py:
2839         * Scripts/webkitpy/layout_tests/port/webkit.py:
2840
2841 2011-11-06  Eric Seidel  <eric@webkit.org>
2842
2843         Split chunk handling out of prepare_lists_and_print_output to make it more readable
2844         https://bugs.webkit.org/show_bug.cgi?id=71629
2845
2846         Reviewed by Adam Barth.
2847
2848         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2849
2850 2011-11-06  Eric Seidel  <eric@webkit.org>
2851
2852         Clarify how the symbol and runtime-feature based test exclusion works and cleanup the code a bit
2853         https://bugs.webkit.org/show_bug.cgi?id=66078
2854
2855         Reviewed by Adam Barth.
2856
2857         The runtime feature detection was fixed to work in bug 64472.
2858         In this bug I moved the symbol-based feature detection from
2859         popen() to Executive.run_command and cleaned up the callers
2860         and unittests to make sure that we're correctly parsing the
2861         nm output correctly.  The old code happened to work even though
2862         the runtime-features path was using "str in list" and the
2863         symbol features path was using "str in str" and it just happened
2864         to do what we wanted to.  Now runtime features and symbol feature
2865         blacklists are computed separately (and with better documentation).
2866
2867         This system remains confusing, partially because these are black-lists
2868         which are amended to whatever static blacklist may exist for the
2869         port as part of a Skipped list file.
2870
2871         For example, notice how the runtime feature list only has directory
2872         blacklists for a couple features.  If all features are off,
2873         how do we skip enough tests with only 2 entries in the blacklist map?
2874         The answer is that Windows is the only port to use runtime feature
2875         detection, and the win/Skipped file turns off all the other features
2876         statically (like mathml, mhtml, wss, etc.) where as some other ports (like AppleMac)
2877         which use symbol-based feature detection turn of mathml, wcss, etc
2878         using the blacklists found in _missing_symbol_to_skipped_tests.
2879
2880         I also noticed a couple places where we still referenced xhtmlmp
2881         even though support for such has been removed from WebKit.  Removed those.
2882
2883         This should result in no functional change.
2884
2885         * Scripts/webkitpy/layout_tests/port/gtk.py:
2886          - Use self._filesystem instead of os.path
2887         * Scripts/webkitpy/layout_tests/port/webkit.py:
2888         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2889
2890 2011-11-06  Dan Bernstein  <mitz@apple.com>
2891
2892         Made show-pretty-diff work when the input path contains spaces.
2893
2894         Reviewed by Anders Carlsson.
2895
2896         * Scripts/show-pretty-diff:
2897
2898 2011-11-05  Daniel Cheng  <dcheng@chromium.org>
2899
2900         [chromium] Use the security origin instead of the URL when checking notification permissions
2901         https://bugs.webkit.org/show_bug.cgi?id=71590
2902
2903         Reviewed by Adam Barth.
2904
2905         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2906         (NotificationPresenter::checkPermission):
2907         * DumpRenderTree/chromium/NotificationPresenter.h:
2908
2909 2011-11-05  Darin Adler  <darin@apple.com>
2910
2911         Fix a small leak in Mac version of LayoutTestController
2912         https://bugs.webkit.org/show_bug.cgi?id=71615
2913
2914         Reviewed by Mark Rowe.
2915
2916         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2917         (LayoutTestController::applicationCacheDiskUsageForOrigin): Release the origin.
2918         (LayoutTestController::localStorageDiskUsageForOrigin): Ditto.
2919
2920 2011-11-04  Eric Seidel  <eric@webkit.org>
2921
2922         Upgrade to the latest Mechanize
2923         https://bugs.webkit.org/show_bug.cgi?id=71594
2924
2925         Reviewed by Adam Barth.
2926
2927         I noticed our mechanize was somewhat out of date when removing Python 2.5 support.
2928         Mechanize is no longer two separate libraries, so importing it is much simpler.
2929
2930         * Scripts/webkitpy/thirdparty/__init__.py:
2931
2932 2011-11-04  Stephen Chenney  <schenney@chromium.org>
2933
2934         Crash in ScrollAnimator.cpp
2935         https://bugs.webkit.org/show_bug.cgi?id=69865
2936
2937         The code in ScrollAnimator assumes that horizontal per-page mouse
2938         wheel events cannot happen, which is not true. This patch adds layout
2939         tests for all paging wheel event situations and fixes the broken
2940         horizontal case.
2941
2942         Reviewed by Anders Carlsson
2943
2944         * DumpRenderTree/chromium/EventSender.cpp:
2945         (EventSender::handleMouseWheel): Added the ability to specify that a
2946         mouse wheel event should be paging.
2947
2948 2011-11-04  Eric Seidel  <eric@webkit.org>
2949
2950         Remove deprecated free functions in port.factory
2951         https://bugs.webkit.org/show_bug.cgi?id=71494
2952
2953         Unreviewed.  Fix exception when running new-run-webkit-httpd.
2954
2955         * Scripts/new-run-webkit-httpd:
2956
2957 2011-11-04  Adam Roben  <aroben@apple.com>
2958
2959         Remove Leopard-specific code from build.webkit.org
2960
2961         We don't have any Leopard bots anymore.
2962
2963         Fixes <http://webkit.org/b/71583> build.webkit.org configuration contains obsolete Leopard code
2964
2965         Reviewed by Mark Rowe.
2966
2967         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed now-unused StartATSServer
2968         and StopATSServer steps.
2969         (unitTestsSupported): Removed check for mac-leopard.
2970         (TestFactory.__init__): Removed Leopard-specific steps.
2971
2972 2011-11-04  Eric Seidel  <eric@webkit.org>
2973
2974         new-run-webkit-tests autoinstalls python-irclib even though it doesn't need to
2975         https://bugs.webkit.org/show_bug.cgi?id=71549
2976
2977         Reviewed by Adam Barth.
2978
2979         Several members of Host didn't really belong there
2980         and were instead specific to WebKitPatch, so I've moved
2981         them up onto that class.
2982
2983         * Scripts/webkitpy/common/host.py:
2984         * Scripts/webkitpy/common/host_mock.py:
2985         * Scripts/webkitpy/tool/main.py:
2986         * Scripts/webkitpy/tool/mocktool.py:
2987         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2988
2989 2011-11-04  Tony Chang  <tony@chromium.org>
2990
2991         garden-o-matic: bring back party time!
2992         https://bugs.webkit.org/show_bug.cgi?id=71582
2993
2994         Reviewed by Adam Barth.
2995
2996         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Allow images from file:
2997         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/partytime.gif: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/partytime.gif.
2998         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Add length() for UpdateTracker.
2999         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Plumb through length().
3000         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: Toggle partytime.gif via css class.
3001         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css: Add css styling for partytime.
3002
3003 2011-11-04  Raphael Kubo da Costa  <kubo@profusion.mobi>
3004
3005         [EFL] DRT: Fix the order of the items in the dumped history list.
3006         https://bugs.webkit.org/show_bug.cgi?id=71562
3007
3008         It did not make much sense to hold the history list in a map, as we do not need
3009         the keys. And the printed items must be sorted by target, which is more easily
3010         done with a vector.
3011
3012         Should make tests such as http/tests/navigation/error404-frames.html pass.
3013
3014         Reviewed by Antonio Gomes.
3015
3016         * DumpRenderTree/efl/DumpHistoryItem.cpp:
3017         (compareHistoryItemsByTarget):
3018         (dumpHistoryItem):
3019
3020 2011-11-04  Patrick Gansterer  <paroga@webkit.org>
3021
3022         [Qt] Remove ENABLE_SQLITE from qmake files
3023         https://bugs.webkit.org/show_bug.cgi?id=71546
3024
3025         Reviewed by Simon Hausmann.
3026
3027         * qmake/mkspecs/features/features.prf:
3028         * qmake/mkspecs/features/webcore.prf:
3029
3030 2011-11-04  Adam Barth  <abarth@webkit.org>
3031
3032         watchlist for WebIDL shouldn't trigger on Internals.idl
3033         https://bugs.webkit.org/show_bug.cgi?id=70657
3034
3035         Reviewed by David Levin.
3036
3037         Internals.idl isn't part of the Web-facing IDL in the project.
3038
3039         * Scripts/webkitpy/common/config/watchlist:
3040
3041 2011-11-04  Anders Carlsson  <andersca@apple.com>
3042
3043         Fix WKTR crash when running NPN_ConvertPoint test.
3044
3045         Call notifyDone in a timeout - otherwise we'll end up entering layout from layout.
3046
3047         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:
3048         (ConvertPoint::NPP_SetWindow):
3049
3050 2011-11-04  Anders Carlsson  <andersca@apple.com>
3051
3052         NPN_ConvertPoint plug-in test should be called from NPP_SetWindow
3053         https://bugs.webkit.org/show_bug.cgi?id=71570
3054
3055         Reviewed by Simon Fraser.
3056
3057         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3058         (PluginTest::NPP_SetWindow):
3059         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3060         Remove the NPP parameter from NPP_SetWindow.
3061
3062         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPSetWindowCalledDuringDestruction.cpp:
3063         (NPPSetWindowCalledDuringDestruction::NPP_SetWindow):
3064         Remove the NPP parameter from NPP_SetWindow.
3065
3066         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
3067         (PassDifferentNPPStruct::NPP_SetWindow):
3068         Remove the NPP parameter from NPP_SetWindow and use PluginTest::log for logging.
3069
3070         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:
3071         (ConvertPoint::NPP_SetWindow):
3072         Run the test from NPP_SetWindow and call notifyDone() when done.
3073
3074         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3075         (NPP_SetWindow):
3076         Remove unnecessary parameter.
3077
3078 2011-11-04  Simon Hausmann  <simon.hausmann@nokia.com>
3079
3080         [Qt] Fix run-qtwebkit-tests execution on the build bot(s).
3081
3082         Rubber-stamped by Tor Arne Vestbø.
3083
3084         * BuildSlaveSupport/build.webkit.org-config/master.cfg: The path to the tests
3085         changed slightly after the refactoring.
3086
3087 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3088
3089         [Qt] Don't warn about disabling WebKit2 when qmake does recursive includes
3090
3091         Reviewed by Simon Hausmann.
3092
3093         * qmake/mkspecs/features/default_pre.prf:
3094
3095 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3096
3097         [Qt] Don't error out on wrong Qt version when qmake does recursive includes
3098
3099         Reviewed by Simmon Hausmann.
3100
3101         * qmake/mkspecs/features/default_pre.prf:
3102
3103 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3104
3105         [Qt] Disable STDIN check before cleaning build dir
3106
3107         It didn't work on the bots.
3108
3109         Reviewed by Ossy.
3110
3111         * Scripts/webkitdirs.pm:
3112
3113 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3114
3115         [Qt] Don't build all of webkit when running build-jsc
3116
3117         In case the whole webkit project was built, but we then subsequently
3118         want to build only JSC, we need to run make in the proper subdirectory.
3119
3120         This also means the incremental target needs to be added to all
3121         makefiles.
3122
3123         Reviewed by Simmon Hausmann.
3124
3125         * Scripts/webkitdirs.pm:
3126         (buildQMakeProject):
3127         * qmake/mkspecs/features/default_post.prf:
3128
3129 2011-11-04  Simon Hausmann  <simon.hausmann@nokia.com>
3130
3131         Fix run-javascriptcore-tests for Qt when it's executed by the bot.
3132
3133         Reviewed by Tor Arne Vestbø.
3134
3135         * Scripts/webkitdirs.pm:
3136         (jscProductDir): jsc path changed.
3137
3138 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3139
3140         [Qt] Error out early if trying to build against Qt < 4.8
3141
3142         Reviewed by Simon Hausmann.
3143
3144         * qmake/mkspecs/features/default_pre.prf:
3145
3146 2011-11-04  Simon Hausmann  <simon.hausmann@nokia.com>
3147
3148         Fix run-launcher for Qt and Gtk.
3149
3150         Rubber-stamped by Tor Arne Vestbø.
3151
3152         * Scripts/webkitdirs.pm:
3153         (isWK2): Re-add isWK2(), as it's used in run-launcher.
3154
3155 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3156
3157         [Qt] Ignore '-2' if passed to build-webkit. WebKit2 is now built by default.
3158
3159         Reviewed by Simon Hausmann.
3160
3161         * Scripts/build-webkit:
3162
3163 2011-11-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3164
3165         [GTK] Use web view title as window title in MiniBrowser
3166         https://bugs.webkit.org/show_bug.cgi?id=71544
3167
3168         Reviewed by Philippe Normand.
3169
3170         * MiniBrowser/gtk/BrowserWindow.c:
3171         (webViewURIChanged): Removed extra space.
3172         (webViewTitleChanged): Set window title using
3173         webkit_web_view_get_title().
3174         (browser_window_init): Set initial default window title.
3175         (browserWindowConstructed): Connect to WebView notify::title
3176         signal.
3177
3178 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3179
3180         [Qt] Refactor and clean up the qmake build system
3181
3182         The qmake build system has accumulated a bit of cruft and redundancy
3183         over time. There's also a fairly tight coupling between how to build
3184         the various targets, and _what_ to build, making it harder to add new
3185         rules or sources. This patch aims to elevate these issues somewhat.
3186
3187         This is a short-list of the changes:
3188
3189           * The rules for how to build targets are now mostly contained as
3190             prf-files in Tools/qmake/mkspecs/features. Using mkspecs also
3191             allows us to do pre- and post-processing of each project file,
3192             which helps to clean up the actual project files.
3193
3194           * Derived sources are no longer generated as a separate make-step
3195             but is part of each target's project file as a subdir. Makefile
3196             rules are used to ensure that we run make on the derived sources
3197             before running qmake on the actual target makefile. This makes
3198             it easier to keep a proper dependency between derived sources
3199             and the target.
3200
3201           * We use GNU make and the compiler to generate dependencies on
3202             UNIX-based systems running Qt 5. This allows us to lessen the
3203             need to run qmake, which should reduce compile time.
3204
3205           * WebKit2 is now build by default if building with Qt 5. It can
3206             be disabled by passing --no-webkit2 to build-webkit.
3207
3208         The result of these changes are hopefully a cleaner and easier
3209         build system to modify, and faster build times due to no longer
3210         running qmake on every single build. It's also a first step
3211         towards possibly generating the list of sources using another
3212         build system.
3213
3214         https://bugs.webkit.org/show_bug.cgi?id=71222
3215
3216         Reviewed by Simon Hausmann.
3217
3218         * DerivedSources.pro: Removed.
3219         * DumpRenderTree/qt/DumpRenderTree.pro:
3220         * DumpRenderTree/qt/ImageDiff.pro:
3221         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3222         * MiniBrowser/qt/MiniBrowser.pro:
3223         * QtTestBrowser/QtTestBrowser.pro:
3224         * QtTestBrowser/launcherwindow.cpp:
3225         (LauncherWindow::initializeView):
3226         (LauncherWindow::createChrome):
3227         (LauncherWindow::screenshot):
3228         * QtTestBrowser/launcherwindow.h:
3229         (WindowOptions::WindowOptions):
3230         * Scripts/build-webkit:
3231         (unlinkZeroFiles):
3232         * Scripts/webkitdirs.pm:
3233         (qtFeatureDefaults):
3234         (promptUser):
3235         (buildQMakeProject):
3236         * Tools.pro:
3237         * WebKitTestRunner/DerivedSources.pri: Added.
3238         * WebKitTestRunner/DerivedSources.pro: Removed.
3239         * WebKitTestRunner/InjectedBundle/DerivedSources.pri: Added.
3240         * WebKitTestRunner/InjectedBundle/InjectedBundle.pro: Added.
3241         * WebKitTestRunner/InjectedBundle/Target.pri: Added.
3242         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Removed.
3243         * WebKitTestRunner/Target.pri: Added.
3244         * WebKitTestRunner/WebKitTestRunner.pro:
3245         * WebKitTestRunner/qt/TestInvocationQt.cpp:
3246         * WebKitTestRunner/qt/WebKitTestRunner.pro: Removed.
3247         * qmake/README: Added.
3248         * qmake/mkspecs/features/default_post.prf: Added.
3249         * qmake/mkspecs/features/default_pre.prf: Added.
3250         * qmake/mkspecs/features/features.prf: Renamed from Source/WebCore/features.pri.
3251         * qmake/mkspecs/features/functions.prf: Added.
3252         * qmake/mkspecs/features/javascriptcore.prf: Renamed from Source/JavaScriptCore/JavaScriptCore.pri.
3253         * qmake/mkspecs/features/mac/default_post.prf: Added.
3254         * qmake/mkspecs/features/mac/default_pre.prf: Added.
3255         * qmake/mkspecs/features/minimal_qt.prf: Added.
3256         * qmake/mkspecs/features/qtwebkit.prf: Added.
3257         * qmake/mkspecs/features/rpath.prf: Added.
3258         * qmake/mkspecs/features/unix/default_post.prf: Added.
3259         * qmake/mkspecs/features/unix/default_pre.prf: Added.
3260         * qmake/mkspecs/features/valgrind.prf: Added.
3261         * qmake/mkspecs/features/webcore.prf: Renamed from Source/WebCore/WebCore.pri.
3262         * qmake/mkspecs/features/webkit2.prf: Copied from Source/WebKit2/WebKit2.pri.
3263         * qmake/mkspecs/features/win32/default_post.prf: Added.
3264         * qmake/qt_webkit.pri: Renamed from Source/WebKit/qt/qt_webkit_version.pri.
3265         * qmake/syncqt-4.8: Added.
3266         (showUsage):
3267         ():
3268         (copyFile):
3269         (symlinkFile):
3270
3271 2011-11-04  Eric Seidel  <eric@webkit.org>
3272
3273         Remove deprecated free functions in port.factory
3274         https://bugs.webkit.org/show_bug.cgi?id=71494
3275
3276         Unreviewed.  Fixing exception seen when running test-webkitpy.
3277
3278         Sorry, I previously had deleted the relevant rebaseline-chromium-webkit-tests
3279         unittest, since that script is nearly ready to be deleted.  But I added
3280         it back at the last second and failed to run the tests. :(
3281         This fixes the exception the bots were seeing.
3282
3283         * Scripts/webkitpy/style/checkers/test_expectations.py:
3284         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3285         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
3286
3287 2011-11-02  Xiaomei Ji  <xji@chromium.org>
3288
3289         Enable ctrl-arrow move cursor by word in visual order in cr-win by command line flag.
3290         https://bugs.webkit.org/show_bug.cgi?id=71163
3291
3292         Reviewed by Ryosuke Niwa.
3293
3294         * DumpRenderTree/chromium/WebPreferences.cpp: Set visualWordMovementEabled to false in DRT.
3295         (WebPreferences::applyTo):
3296
3297 2011-11-03  Eric Seidel  <eric@webkit.org>
3298
3299         Remove deprecated free functions in port.factory
3300         https://bugs.webkit.org/show_bug.cgi?id=71494
3301
3302         Reviewed by Adam Barth.
3303
3304         I removed port.factory.get, get_all, and all_port_names -- long-since deprecated
3305         free functions in factory.py.  To remove these required fixing all callsites
3306         to use MockHost, Host, or PortFactory where appropriate.  After this change
3307         we're only left with a handfull of places where we inappropraitely use a
3308         real Executive, FileSystem or User object during unittesting.
3309
3310         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
3311          - These PortFactory overrides were from an earlier edition of my previous patch
3312            in the end, I removed MockPortFactory so all tests ended up with this same
3313            real PortFactory() with a MockHost.  This was simply redundent code.
3314         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3315          - Use MockHost to get a mocked-out PortFactory.
3316         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3317          - This code has no access to a Host object, so we just use a default PortFactory
3318            for now.  This will still incorrectly create real Executive/FileSystem objects
3319            durring unittesting, which is wrong. :(
3320         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
3321          - Use a MockHost to get a mocked PortFactory.
3322         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
3323          - Use a MockHost to get a mocked PortFactory.
3324         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
3325          - ditto.
3326         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3327          - ditto.
3328         * Scripts/webkitpy/layout_tests/port/__init__.py:
3329          - factory.get no longer exists.  Yay!
3330         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3331          - Use a MockHost to get a mocked PortFactory.
3332            To do this efficiently, I created a helper function
3333            and combined all these (mostly redundant) tests into one test
3334            with several calls to the helper function.
3335         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3336          - Pass MockUser and MockExecutive in these port testing subclasses.
3337          - I also removed a bunch of unecessary uses of mocktool. namespacing.
3338         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3339          - Awesome windows hacks should only happen on win32.  Once we started
3340            using MockExecutives these 'svn help' commands started printing in
3341            other tests, which is how I found this bug.
3342         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3343          - DryRunPort has no Host, so just use a PortFactory() directly.
3344            This will do the wrong thing if we're unittesting the DryRun port
3345            but it's no worse than the existing code.
3346         * Scripts/webkitpy/layout_tests/port/factory.py:
3347          - Remove the free functions.
3348          - Fix argument overriding to be able to override None.
3349         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3350          - Use a mocked-out PortFactory during testing.
3351         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3352          - Pass MockExecutive and MockUser to these manual Port instantiations.
3353         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
3354          - No access to a Host object here, so just using PortFactory directly.
3355            This is wrong, but no more wrong than the existing code was.
3356         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3357          - Use a MockHost to get a mocked out PortFactory.
3358         * Scripts/webkitpy/layout_tests/port/test.py:
3359          - Use our fancy _set_default_overriding_none system to clean this code up and pass a MockExecutive.
3360         * Scripts/webkitpy/layout_tests/port/win.py:
3361          - Don't run cmd /c ver from WinPort.__init__ or it shows up in unittests which have logging MockExecutive
3362            now that we're actually passing MockExecutive to most Port instantiations during testing.
3363         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3364          - Pass our new "unittesting" bool to _detect_version when actually unittesting.
3365         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3366          - Host is the future.
3367         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3368          - Use a MockHost to get a mocked out PortFactory.  Once we have a mocked PortFactory
3369            we don't need to pass MockUser explicitly, it does that automatically for us.
3370         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3371          - Use a MockHost to get a mocked out PortFactory.
3372         * Scripts/webkitpy/style/checkers/test_expectations.py:
3373          - We don't have access to a Host object, so using PortFactory() directly.
3374         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3375          - Remove unused variable.
3376         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3377          - Host isn't accessible here, so using PortFactory() directly, which
3378            although unfortunate is no worse than before.
3379         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
3380          - Testing is much easier when you don't need to hack global state...
3381         * Scripts/webkitpy/tool/commands/expectations.py:
3382          - Use the port_factory on the tool.
3383         * Scripts/webkitpy/tool/commands/rebaseline.py:
3384          - ditto.
3385         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3386          - This unittest was wrong.  It was trying to pass the tool object, but failing to pass
3387            the arguments in the right order.  Fixing that made it use a MockFileSystem
3388            (like it had been trying to), which then required us to actually populate
3389            that MockFileSystem with fake expectation files (instead of using the ones on the real disk).
3390         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3391          - Get the port_factory from the tool.
3392         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3393          - Ditto.
3394         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3395          - Use a MockHost to get a mocked out Port object.
3396
3397 2011-11-03  Raphael Kubo da Costa  <kubo@profusion.mobi>
3398
3399         [EFL] DRT: Allow choosing which backing store to use.
3400         https://bugs.webkit.org/show_bug.cgi?id=70532
3401
3402         Reviewed by Antonio Gomes.
3403
3404         This change makes it possible to change the backing store used by DRT
3405         from Tiled Backing Store (TBS) to Single Backing Store (SBS) by
3406         setting the environment variable DRT_USE_SINGLE_BACKING_STORE to 1.
3407
3408         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3409         (DumpRenderTreeChrome::createView):
3410         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
3411         (shouldUseSingleBackingStore):
3412         (chooseAndInitializeAppropriateSmartClass):
3413         (drtViewAdd):
3414         * DumpRenderTree/efl/DumpRenderTreeView.h:
3415
3416 2011-11-02  Erik Arvidsson  <arv@chromium.org>
3417
3418         JS Test Harness: Remove more link tags
3419         https://bugs.webkit.org/show_bug.cgi?id=71339
3420
3421         Reviewed by Ojan Vafai.
3422
3423         * Scripts/make-new-script-test:
3424         (writeTestFile): Don't output <link>
3425
3426 2011-11-03  Thouraya ANDOLSI  <thouraya.andolsi@st.com>
3427
3428         Reviewed by Martin Robinson.
3429
3430         [GTK] arguments passed to build-jsc are not taken into account
3431         https://bugs.webkit.org/show_bug.cgi?id=58333
3432
3433         * Scripts/build-jsc:
3434
3435 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3436
3437         [GTK] Show url of history items in a status bar in MiniBrowser
3438         https://bugs.webkit.org/show_bug.cgi?id=71474
3439
3440         Reviewed by Martin Robinson.
3441
3442         * MiniBrowser/gtk/BrowserWindow.c:
3443         (browserWindowSetStatusText): Set status text and show/hide the
3444         status label.
3445         (resetStatusText): Reset status text when history menu is hidden.
3446         (browserWindowHistoryItemSelected): Show url of currently selected
3447         history item.
3448         (browserWindowCreateBackForwardMenu): Connect to hide signal of
3449         menu to reset the status text.
3450         (browserWindowConstructed): Use GtkOverlay if available to show
3451         status text.
3452
3453 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3454
3455         [GTK] Add back/forward menus to MiniBrowser using WebKit2 GTK+ API
3456         https://bugs.webkit.org/show_bug.cgi?id=71466
3457
3458         Reviewed by Martin Robinson.
3459
3460         * MiniBrowser/gtk/BrowserWindow.c:
3461         (browserWindowHistoryItemActivated): Go to selected back formard
3462         list item using webkit_web_view_go_to_back_forward_list_item()
3463         (browserWindowCreateBackForwardMenu): Create a GtkMenu for the
3464         given GList of WebKitBackForwardListItems.
3465         (browserWindowUpdateNavigationActions): Enable/disable back and
3466         forward buttons depending on whether it's possible to go
3467         back/forward. Create a menu for back and forward toolbar buttons.
3468         (backForwadlistChanged): Call browserWindowUpdateNavigationActions().
3469         (browserWindowConstructed): Connect to WebKitBackForwardList
3470         changed signal.
3471
3472 2011-11-03  Simon Hausmann  <simon.hausmann@nokia.com>
3473
3474         [Qt] Remove Maemo specific code paths
3475         https://bugs.webkit.org/show_bug.cgi?id=71476
3476
3477         Reviewed by Kenneth Rohde Christiansen.
3478
3479         * QtTestBrowser/launcherwindow.cpp:
3480         (LauncherWindow::~LauncherWindow):
3481         (LauncherWindow::init):
3482         (LauncherWindow::showLinkHover):
3483         (LauncherWindow::selectElements):
3484         (LauncherWindow::showFPS):
3485         (LauncherWindow::updateFPS):
3486         * QtTestBrowser/launcherwindow.h:
3487         (WindowOptions::WindowOptions):
3488         * QtTestBrowser/locationedit.cpp:
3489         * QtTestBrowser/locationedit.h:
3490
3491 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3492
3493         [GTK] Show load progress information in MiniBrowser using WebKit2 GTK+ API
3494         https://bugs.webkit.org/show_bug.cgi?id=71461
3495
3496         Reviewed by Martin Robinson.
3497
3498         * MiniBrowser/gtk/BrowserWindow.c:
3499         (resetEntryProgress): Reset the entry progress after a while when
3500         load has been completed.
3501         (webViewLoadProgressChanged): Update location entry progress.
3502         (browserWindowConstructed): Connect to WebView
3503         notify::estimated-load-progress signal.
3504
3505 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3506
3507         [GTK] Remove WebKit2 C API from MiniBrowser
3508         https://bugs.webkit.org/show_bug.cgi?id=71459
3509
3510         Reviewed by Martin Robinson.
3511
3512         Use the GTK+ API instead to add minimum functionality. The other
3513         features will be ported to GTK+ API in following patches.
3514
3515         * MiniBrowser/gtk/BrowserWindow.c:
3516         (activateUriEntryCallback): Use webkit_web_view_load_uri().
3517         (goBackCallback): Use webkit_web_view_go_back().
3518         (goForwardCallback): Use webkit_web_view_go_forward().
3519         (webViewURIChanged): Update location entry with current uri using
3520         webkit_web_view_get_uri().
3521         (browserWindowFinalize):
3522         (browserWindowGetProperty):
3523         (browserWindowSetProperty):
3524         (browser_window_init):
3525         (browserWindowConstructed): Connect to notify::uri signal of
3526         WebView to be notified when the URI changes.
3527         (browser_window_class_init):
3528         (browser_window_new): Use WebKitWebView.
3529         (browser_window_get_view): Use WebKitWebView
3530         * MiniBrowser/gtk/BrowserWindow.h:
3531         * MiniBrowser/gtk/GNUmakefile.am:
3532         * MiniBrowser/gtk/WebBundle/WebBundleMain.c: Removed.
3533         * MiniBrowser/gtk/main.c:
3534         (loadURI): Use webkit_web_view_new().
3535         (main):
3536
3537 2011-11-03  Simon Hausmann  <simon.hausmann@nokia.com>
3538
3539         [Qt] Unable to start MiniBrowser after run-webkit-tests
3540         https://bugs.webkit.org/show_bug.cgi?id=71469
3541
3542         Reviewed by Csaba Osztrogonác.
3543
3544         * Scripts/run-launcher: Pass @ARGV instead of @args, which is stripped
3545         from things like -2. Neither Gtk or Qt MiniBrowser like unknown command
3546         line arguments.
3547
3548 2011-11-03  Philippe Normand  <pnormand@igalia.com>
3549
3550         [GTK] [WK2] ttf-liberation fonts moved to a new location (in Debian)
3551         https://bugs.webkit.org/show_bug.cgi?id=71445
3552
3553         Reviewed by Martin Robinson.
3554
3555         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3556         (initializeFonts): set directoriesDescription only when needed.
3557         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3558         (WTR::inititializeFontConfigSetting): Add the new font path for Debian fonts and
3559         refactored the font files loading code to avoid copy/pastes, ease
3560         maintenance and future font directories additions.
3561
3562 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3563
3564         [GTK] Remove GtkLauncher2
3565         https://bugs.webkit.org/show_bug.cgi?id=71449
3566
3567         Reviewed by Martin Robinson.
3568
3569         GtkLauncher2 is the GtkLauncher code compiled with webkit2. This
3570         made sense when we wanted to implement the exactly same wk1 API
3571         for wk2. Now the code would require an ifdef for most the api, so
3572         it's better to remove GtkLauncher2 and port MiniBrowser to the new
3573         GTK+ API.
3574
3575         * GNUmakefile.am:
3576         * GtkLauncher/main.c:
3577         (notifyProgressCb):
3578         (closeWebViewCb):
3579         (createBrowser):
3580         (addWebSettingsGroupToContext):
3581         (main):
3582
3583 2011-11-02  Philippe Normand  <pnormand@igalia.com>
3584
3585         [GTK] [DRT] ttf-liberation fonts moved to a new location (in Debian)
3586         https://bugs.webkit.org/show_bug.cgi?id=71359
3587
3588         Reviewed by Martin Robinson.
3589
3590         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3591         (initializeFonts): Add the new font path for Debian fonts and
3592         refactored the font files loading code to avoid copy/pastes, ease
3593         maintenance and future font directories additions.
3594
3595 2011-11-02  Eric Seidel  <eric@webkit.org>
3596
3597         Move Mocks into _mock files near their implementations
3598         https://bugs.webkit.org/show_bug.cgi?id=71425
3599
3600         Reviewed by Adam Barth.
3601
3602         This entire change is splitting mocktool.py into separate _mock.py files
3603         and placing them next to their real implementations.
3604
3605         I also deleted MockPortFactory (since it was wrong) and was just hiding
3606         the fact that the "skipped-ports" command was broken (and has been for a long time).
3607         So I made MockHost use a real PortFactory (passed a MockHost) and changed
3608         the skipped-ports implementation to use modern PortFactory methods.
3609
3610         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
3611         * Scripts/webkitpy/common/checkout/checkout_mock.py: Added.
3612         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3613         * Scripts/webkitpy/common/checkout/deps_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
3614         * Scripts/webkitpy/common/checkout/scm/scm_mock.py: Added.
3615         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3616         * Scripts/webkitpy/common/config/ports_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
3617         * Scripts/webkitpy/common/host.py:
3618         * Scripts/webkitpy/common/host_mock.py: Added.
3619         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py: Added.
3620         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3621         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py: Added.
3622         * Scripts/webkitpy/common/net/credentials_unittest.py:
3623         * Scripts/webkitpy/common/net/failuremap_unittest.py:
3624         * Scripts/webkitpy/common/net/irc/irc_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
3625         * Scripts/webkitpy/common/net/statusserver_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
3626         * Scripts/webkitpy/common/net/statusserver_unittest.py: