[GTK] Enable introspection always for developer builds
[WebKit-https.git] / Tools / ChangeLog
1 2013-04-22  Martin Robinson  <mrobinson@igalia.com>
2
3         [GTK] Enable introspection always for developer builds
4         https://bugs.webkit.org/show_bug.cgi?id=114983
5
6         Reviewed by Gustavo Noronha Silva.
7
8         * Scripts/webkitdirs.pm:
9         (runAutogenForAutotoolsProjectIfNecessary): Always enable introspection
10         when using build-webkit.
11         * gtk/jhbuildrc: Enable documentation for all jhbuild modules and explicitly
12         choose the memory gsettings backend while in the jhbuild. This eliminates
13         warnings from programs that fall back to the memory backend.
14
15 2013-04-22  Zan Dobersek  <zdobersek@igalia.com>
16
17         [GTK] Set up libPlatform.la
18         https://bugs.webkit.org/show_bug.cgi?id=114168
19
20         Reviewed by Martin Robinson.
21
22         * GNUmakefile.am: Link the DumpRenderTree executable against both libPlatform.la and libPlatformGtk.la libraries.
23
24 2013-04-22  Xuefei Ren  <xren@blackberry.com>
25
26         fix build warning(unused parameter)
27         https://bugs.webkit.org/show_bug.cgi?id=114855
28
29         Reviewed by Rob Buis.
30
31         remove warning(unused parameter) in
32         Tools/DumpRenderTree/blackberry/EventSender.cpp
33
34         * DumpRenderTree/blackberry/EventSender.cpp:
35         (getDragModeCallback):
36
37 2013-04-22  Alberto Garcia  <agarcia@igalia.com>
38
39         [BlackBerry] Add dummy implementation of AccessibilityController::accessibleElementById()
40         https://bugs.webkit.org/show_bug.cgi?id=114939
41
42         Reviewed by Carlos Garcia Campos.
43
44         This was added in r129308.
45
46         * DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp:
47         (AccessibilityController::accessibleElementById):
48
49 2013-04-21  Christophe Dumez  <ch.dumez@sisa.samsung.com>
50
51         Unreviewed EFL build fix after r148855.
52
53         * TestWebKitAPI/PlatformEfl.cmake:
54
55 2013-04-21  Christophe Dumez  <ch.dumez@sisa.samsung.com>
56
57         [EFL][WK2] Mark WKViewClientWebProcessCallbacks API test as failing
58         https://bugs.webkit.org/show_bug.cgi?id=114922
59
60         Reviewed by Gyuyoung Kim.
61
62         Mark WKViewClientWebProcessCallbacks API test as failing on WK2 EFL.
63
64         * TestWebKitAPI/PlatformEfl.cmake:
65
66 2013-04-20  Zan Dobersek  <zdobersek@igalia.com>
67
68         [GTK] Fix baseline positioning issue by updating Freetype
69         https://bugs.webkit.org/show_bug.cgi?id=106775
70
71         Reviewed by Martin Robinson.
72
73         * gtk/jhbuild.modules: Bump the Freetype Jhbuild dependency to 2.4.11.
74         * gtk/patches/freetype6-2.4.11-truetype-font-height-fix.patch: Added. This is the Freetype
75         patch (committed as e0469372) that fixes rounding issues for smaller fonts. It is bound to be included
76         in the 2.4.12 release of Freetype (not released yet) but is provided here as its effect on baselines is
77         considered positive and will reduce the amout of future rebaselining.
78
79 2013-04-20  Manuel Rego Casasnovas  <rego@igalia.com>
80
81         [GTK] Fix unit test webkit2/WebKitFindController/hide
82         https://bugs.webkit.org/show_bug.cgi?id=89810
83
84         Reviewed by Carlos Garcia Campos.
85
86         * Scripts/run-gtk-tests:
87         (TestRunner): Unskip test webkit2/WebKitFindController/hide.
88
89 2013-04-19  Ryosuke Niwa  <rniwa@webkit.org>
90
91         Build fixes for the flakiness dashboard.
92
93         * TestResultServer/static-dashboards/flakiness_dashboard.js:
94
95 2013-04-17  Gustavo Noronha Silva  <gns@gnome.org>
96
97         [GTK] Make the 32 bits bot only build and run API tests
98         https://bugs.webkit.org/show_bug.cgi?id=113532
99
100         Reviewed by Martin Robinson.
101
102         * BuildSlaveSupport/build.webkit.org-config/config.json: make the 32 bits bot use the new BuildAndAPITest type
103         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
104         (BuildAndAPITestFactory): new factory that builds and runs API tests, only used by the GTK+ 32 bits bot at the
105         moment;
106         (BuildAndAPITestFactory.__init__): add API tests step for platforms that have it.
107
108 2013-04-19  Andras Becsi  <andras.becsi@digia.com>
109
110         [Qt] Only use thin archives on Linux
111
112         Rubber-stamped by Jocelyn Turcotte.
113
114         Since "thin archive" is a feature of GNU's ar
115         we limit the usage to Linux to avoid problems
116         with other configurations (eg. macx-g++).
117
118         * qmake/mkspecs/features/default_pre.prf:
119
120 2013-04-19  Krzysztof Czech  <k.czech@samsung.com>
121
122         [GTK][WK2] accessibility/language-attribute.html is failing
123         https://bugs.webkit.org/show_bug.cgi?id=106342
124
125         Reviewed by Gyuyoung Kim.
126
127         Adds support for getting language information.
128
129         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
130         (WTR::AccessibilityUIElement::language):
131
132 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
133
134         [Dashboard] Remove the isToTWebKit member variable from the BuilderGroup interface
135         https://bugs.webkit.org/show_bug.cgi?id=114805
136
137         Reviewed by Benjamin Poulain.
138
139         Remove the isToTWebKit member variable from the BuilderGroup and all its usages as it now defaults to true for every
140         builder group. The isTipOfTreeWebKitBuilder method now returns true by default but should be removed in a follow-up patch.
141         The BuilderGroup constructor does not accept the isToTWebKit parameter anymore so all the callsites are adjusted accordingly.
142
143         * TestResultServer/static-dashboards/builders.js:
144         (BuilderGroup):
145         (loadBuildersList):
146         * TestResultServer/static-dashboards/dashboard_base.js:
147         (isTipOfTreeWebKitBuilder):
148         (expectationsMap):
149         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
150         (test):
151
152 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
153
154         [Dashboard] htmlForIndividualTests unit test should include its dummy builder under the webkit.org builder master
155         https://bugs.webkit.org/show_bug.cgi?id=114804
156
157         Reviewed by Benjamin Poulain.
158
159         The htmlForIndividualTests unit test should include its dummy builder under the sole supported webkit.org builder master
160         just so the unit tests properly functions.
161
162         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
163
164 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
165
166         [Dashboard] Remove Chromium-specific helper functions that were used in the builder-loading code
167         https://bugs.webkit.org/show_bug.cgi?id=114803
168
169         Reviewed by Benjamin Poulain.
170
171         Remove three Chromium-specific helper functions that were used to determine Chromium DEPS, Content Shell and WebKit ToT
172         test runners. These are not required anymore and thus removed along with a couple of unit tests that were testing these
173         methods' correct behavior.
174
175         * TestResultServer/static-dashboards/builders.js:
176         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
177
178 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
179
180         [Dashboard] Remove the Chromium-specific builder masters
181         https://bugs.webkit.org/show_bug.cgi?id=114802
182
183         Reviewed by Benjamin Poulain.
184
185         Remove all the Chromium-specific builder masters, the webkit.org builder master is the only one currently supported.
186
187         * TestResultServer/static-dashboards/builders.js:
188
189 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
190
191         [Dashboard] Remove all the Chromium-specific builder groups
192         https://bugs.webkit.org/show_bug.cgi?id=114801
193
194         Reviewed by Benjamin Poulain.
195
196         Remove all the Chromium-specific builder groups, all of these are not supported anymore.
197
198         * TestResultServer/static-dashboards/builders.js:
199
200 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
201
202         [Dashboard] Only accept the 'group' parameter if present in the layout tests builders group
203         https://bugs.webkit.org/show_bug.cgi?id=114799
204
205         Reviewed by Benjamin Poulain.
206
207         The layout tests builder group is the only one supported, all the other Chromium-specific builder groups are
208         bound to be removed.
209
210         * TestResultServer/static-dashboards/history.js:
211         (.):
212
213 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
214
215         [Dashboard] Remove Chromium-specific builder loading code from loadBuildersList
216         https://bugs.webkit.org/show_bug.cgi?id=114797
217
218         Reviewed by Benjamin Poulain.
219
220         Remove anything Chromium-specific from the builder-loading code, specifically removing support for loading builder data
221         for anything other that the layout-tests type and removing support for loading builder data from builders connected
222         to the Chromium-specific builder groups which are no longer supported.
223
224         * TestResultServer/static-dashboards/builders.js:
225
226 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
227
228         [Dashboard] The currentBuilderGroupCategory method should return the layout tests builder groups by default
229         https://bugs.webkit.org/show_bug.cgi?id=114796
230
231         Reviewed by Benjamin Poulain.
232
233         With the Chromium builders no longer uploading results and the layout-tests test type the only one supported by the
234         WebKit's dashboard, the currentBuilderGroupCategory can now return LAYOUT_TESTS_BUILDER_GROUPS as the default builder
235         group category.
236
237         * TestResultServer/static-dashboards/dashboard_base.js:
238         (currentBuilderGroupCategory):
239
240 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
241
242         [Dashboard] Narrow down the test types list to only layout-tests
243         https://bugs.webkit.org/show_bug.cgi?id=114795
244
245         Reviewed by Ryosuke Niwa.
246
247         Remove all the redundant test types that the webkit.org builders do not upload results for. All of the removed
248         test types were specific to the Chromium builders.
249
250         * TestResultServer/static-dashboards/dashboard_base.js:
251
252 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
253
254         [Dashboard] The revision rows for aggregate results should no longer include Chromium revisions
255         https://bugs.webkit.org/show_bug.cgi?id=114760
256
257         Reviewed by Benjamin Poulain.
258
259         With the Chromium builders no longer present there's no need to display the Chromium revision range under the
260         aggregate results. Only the first half of the htmlForRevisionRows method (the one returning the table row listing the
261         WebKit revisions) is now relevant - the method is therefor removed and its callsites updated to directly call the
262         htmlForTableRow method that returns the table row containing all the relevant WebKit revisions.
263
264         * TestResultServer/static-dashboards/aggregate_results.js:
265         (htmlForSummaryTable):
266         (htmlForTestType):
267
268 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
269
270         [Dashboard] Remove Chromium-specific cases from the construction of the chart HTML for aggregate results
271         https://bugs.webkit.org/show_bug.cgi?id=114759
272
273         Reviewed by Benjamin Poulain.
274
275         Aggregate results are not viewable for Chromium builders anymore, meaning the WebKit revisions are shown by default.
276         This means the code in the chartHTML method can be simplified, defaulting the revision key to WEBKIT_REVISIONS_KEY
277         and the revision label to 'WebKit Revision'.
278
279         * TestResultServer/static-dashboards/aggregate_results.js:
280         (chartHTML):
281
282 2013-04-18  Xuefei Ren  <xren@blackberry.com>
283
284         remove build warning(unused parameter)
285         https://bugs.webkit.org/show_bug.cgi?id=114670
286
287         Reviewed by Rob Buis.
288
289         remove builde warning (unused parameter) in
290         Tools/DumpRenderTree/blackberry
291
292         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
293         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
294         (AccessibilityUIElement::scrollToGlobalPoint):
295         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
296         (BlackBerry::WebKit::DumpRenderTree::addMessageToConsole):
297         (BlackBerry::WebKit::DumpRenderTree::didReceiveResponseForFrame):
298         * DumpRenderTree/blackberry/EventSender.cpp:
299         (getDragModeCallback):
300         (setDragModeCallback):
301         (mouseWheelToCallback):
302         (contextClickCallback):
303         (mouseDownCallback):
304         (mouseUpCallback):
305         (mouseMoveToCallback):
306         (beginDragWithFilesCallback):
307         (leapForwardCallback):
308         (keyDownCallback):
309         (textZoomInCallback):
310         (textZoomOutCallback):
311         (zoomPageInCallback):
312         (zoomPageOutCallback):
313         (addTouchPointCallback):
314         (updateTouchPointCallback):
315         (setTouchModifierCallback):
316         (touchStartCallback):
317         (touchCancelCallback):
318         (touchMoveCallback):
319         (touchEndCallback):
320         (clearTouchPointsCallback):
321         (cancelTouchPointCallback):
322         (releaseTouchPointCallback):
323         (scalePageByCallback):
324         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
325         (TestRunner::authenticateSession):
326         (TestRunner::setSpatialNavigationEnabled):
327         (TestRunner::apiTestNewWindowDataLoadBaseURL):
328         (TestRunner::setPluginsEnabled):
329         (TestRunner::setApplicationCacheOriginQuota):
330         (TestRunner::addMockSpeechInputResult):
331         (TestRunner::setViewModeMediaFeature):
332         (TestRunner::deleteLocalStorageForOrigin):
333         (TestRunner::applicationCacheDiskUsageForOrigin):
334         (TestRunner::grantWebNotificationPermission):
335         (TestRunner::denyWebNotificationPermission):
336         (TestRunner::simulateWebNotificationClick):
337         (TestRunner::simulateLegacyWebNotificationClick):
338
339 2013-04-18  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
340
341         [WK2][EFL] Text Checker's settings refactor
342         https://bugs.webkit.org/show_bug.cgi?id=111713
343
344         Reviewed by Andreas Kling.
345
346         * MiniBrowser/efl/main.c:
347         (window_create):
348         Use a new text checker API to enable spell checking.
349
350 2013-04-18  Seokju Kwon  <seokju.kwon@gmail.com>
351
352         [EFL] Add a newline to the end of log message
353         https://bugs.webkit.org/show_bug.cgi?id=114659
354
355         Reviewed by Gyuyoung Kim.
356
357         Move a newline to info() definition.
358
359         * EWebLauncher/main.c:
360         (on_load_finished):
361         (on_tooltip_text_set):
362         (on_tooltip_text_unset):
363         (on_inputmethod_changed):
364         (on_focus_out):
365         (on_focus_in):
366         (on_key_down):
367         (windowCreate):
368         * MiniBrowser/efl/main.c:
369         (on_key_down):
370         (on_download_request):
371         (on_download_finished):
372         (on_download_failed):
373         (on_refresh_button_clicked):
374         (on_popup_menu_discarded):
375         (on_popup_menu_item_clicked):
376         (popup_menu_populate):
377         (on_popup_menu_show):
378         (on_window_create):
379         (context_popup_item_selected_cb):
380         (on_context_menu_show):
381         (on_context_menu_hide):
382         (window_create):
383
384 2013-04-17  Zan Dobersek  <zandobersek@gmail.com>
385
386         [Dashboard] Remove code for showing 'WebKit roll' annotations in timelines for Chromium builders
387         https://bugs.webkit.org/show_bug.cgi?id=114755
388
389         Reviewed by Ryosuke Niwa.
390
391         The Chromium builders are no longer available to inspect so there's no need for the code that used to show
392         the 'WebKit roll' annotations in the Chromium builders' timeline.
393
394         * TestResultServer/static-dashboards/timeline_explorer.js:
395
396 2013-04-17  Zan Dobersek  <zandobersek@gmail.com>
397
398         [Dashboard] Clean up the timeline updating code, removing Chromium-specific cases
399         https://bugs.webkit.org/show_bug.cgi?id=114756
400
401         Reviewed by Ryosuke Niwa.
402
403         Clean up the updating of the timeline in the timeline explorer, defaulting to the webkit.org build master when
404         constructing the results URL and removing the possible row addition containing the Chromium commit range that
405         only applied to Chromium builders in the first place. Also removes the now-redundant shouldShowWebKitRevisionsOnly
406         method.
407
408         * TestResultServer/static-dashboards/timeline_explorer.js:
409
410 2013-04-17  Alberto Garcia  <agarcia@igalia.com>
411
412         media-stream and xslt are no longer configurable options in the GTK+ port
413         https://bugs.webkit.org/show_bug.cgi?id=114736
414
415         Reviewed by Martin Robinson.
416
417         media-stream support was removed in r145199 and XSLT is a hard
418         requirement since r145859. Attempting to pass those options to the
419         configure script, only results in a warning.
420
421         * Scripts/webkitdirs.pm:
422         (buildAutotoolsProject):
423
424 2013-04-17  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
425
426         [EFL][WK2] Implement context menu in MiniBrowser
427         https://bugs.webkit.org/show_bug.cgi?id=102932
428
429         Reviewed by Gyuyoung Kim.
430
431         Added context menu support for EFL port using Elementary context popup.
432
433         * MiniBrowser/efl/main.c:
434         (_Browser_Window):
435         (context_popup_item_selected_cb):
436         (context_popup_populate):
437         (on_context_menu_show):
438         (on_context_menu_hide):
439         (window_create):
440
441 2013-04-17  Csaba Osztrogonác  <ossy@webkit.org>
442
443         REGRESSION(r148588): It broke the Qt WK2 EWS
444         https://bugs.webkit.org/show_bug.cgi?id=114737
445
446         Reviewed by Jocelyn Turcotte.
447
448         * Scripts/webkitpy/common/config/ews.json: "Qt WK2 EWS" should use qt-wk2 port.
449         * Scripts/webkitpy/common/config/ports.py:
450         (DeprecatedPort.port):
451         (QtPort.build_webkit_command): qt port shouldn't build WebKit2.
452         (QtPort.run_webkit_tests_command): qt port runs WK1 tests.
453         (QtWK2Port): Added.
454         (QtWK2Port.build_webkit_command): qt-wk2 port builds WK1 and WK2 too.
455         (QtWK2Port.run_webkit_tests_command): qt-wk2 port runs WK2 tests.
456         * Scripts/webkitpy/common/config/ports_unittest.py:
457         (DeprecatedPortTest.test_qt_port):
458         (DeprecatedPortTest):
459         (DeprecatedPortTest.test_qt_wk2_port):
460
461 2013-04-17  Zan Dobersek  <zdobersek@igalia.com>
462
463         Unreviewed.
464
465         * Scripts/webkitpy/common/config/ports_unittest.py:
466         (DeprecatedPortTest.test_efl_port): Adjusting the expected outcome of the EFL build-webkit command after r148589.
467
468 2013-04-17  Allan Sandfeld Jensen  <allan.jensen@digia.com>
469
470         [Qt] Enable sub-pixel layout.
471         https://bugs.webkit.org/show_bug.cgi?id=113199
472
473         Reviewed by Jocelyn Turcotte.
474
475         * qmake/mkspecs/features/features.pri:
476
477 2013-04-16  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
478
479         Add Efl WebKit2 EWS bot
480         https://bugs.webkit.org/show_bug.cgi?id=114564
481
482         Reviewed by Ryosuke Niwa.
483
484         Added EflWK2EWS, and add myself a watcher for EflWK2EWS.
485         Also add a deprecated EflWK2Port class.
486
487         Besides clean up eflews watchers.
488
489         * QueueStatusServer/config/queues.py:
490         * Scripts/webkitpy/common/config/ews.json:
491         * Scripts/webkitpy/common/config/ports.py:
492         (DeprecatedPort.port):
493         (EflPort.build_webkit_command):
494         (EflWK2Port):
495         (EflWK2Port.build_webkit_command):
496
497 2013-04-16  Ryosuke Niwa  <rniwa@webkit.org>
498
499         Isolate Early Warning System definitions into a JSON
500         https://bugs.webkit.org/show_bug.cgi?id=114558
501
502         Reviewed by Benjamin Poulain.
503
504         Added ews.json to common/config, and made tool/commands/__init__.py call
505         AbstractEarlyWarningSystem.load_ews_classes to instantiate classes based on ews.json.
506
507         Reland the patch since the EWS failure was a false positive.
508
509         * Scripts/webkitpy/common/config/ews.json: Extracted from earlywarningsystem.py.
510         * Scripts/webkitpy/tool/commands/__init__.py:
511         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
512         (AbstractEarlyWarningSystem):
513         (AbstractEarlyWarningSystem.__init__):
514         (AbstractEarlyWarningSystem.load_ews_classes): Added. Loads ews.json.
515         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
516         (EarlyWarningSystemTest._default_expected_logs):
517         (_test_ews):
518         (test_ewses):
519
520 2013-04-16  Sam Weinig  <sam@webkit.org>
521
522         Fix fallout after r148545.
523
524         * WebKitTestRunner/TestController.cpp:
525         (WTR::TestController::resetStateToConsistentValues):
526         Remove calls to non-existent API functions.
527
528 2013-04-13  Roger Fong  <roger_fong@apple.com>
529
530         Unreviewed. Disable WinEWS tests, simply not enough bots.
531
532         All bots are running consistently now but the queue still keeps growing.
533         Until we get more bots or make the tests faster, it doesn't seem wise to keep running tests.
534
535         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
536         (WinEWS):
537
538 2013-04-16  Ryosuke Niwa  <rniwa@webkit.org>
539
540         The list of contributors in committers.py should be a separate JSON
541         https://bugs.webkit.org/show_bug.cgi?id=114673
542
543         Reviewed by Anders Carlsson.
544
545         Added webkitpy/common/config/contributors.json, made CommitterList load it.
546
547         * EWSTools/start-queue-mac.sh:
548         * EWSTools/start-queue.sh:
549         * Scripts/webkitpy/common/checkout/commitinfo.py:
550         (CommitInfo.committer):
551         * Scripts/webkitpy/common/config/contributors.json: Added.
552         * Scripts/webkitpy/common/config/committers.py:
553         (Reviewer.__init__):
554         (CommitterList.__init__):
555         (CommitterList.load_json): Added.
556         (CommitterList.load_json.emails):
557         (CommitterList.load_json.nicks):
558         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
559         (MockCommitInfo.author):
560
561 2013-04-16  Manuel Rego Casasnovas  <rego@igalia.com>
562
563         [EFL] Bump libsoup dependency to 2.42.0
564         https://bugs.webkit.org/show_bug.cgi?id=113927
565
566         Reviewed by Gyuyoung Kim.
567
568         Update libsoup required version to v2.42.0 and GLib to v2.36.0 as
569         required by libsoup for EFL port.
570
571         * efl/jhbuild.modules:
572         * efl/patches/libsoup-2.40-auth-fix.patch: Removed as it's already
573         included in v2.42.0.
574
575 2013-04-16  Ryosuke Niwa  <rniwa@webkit.org>
576
577         Remove Account class from committers.py
578         https://bugs.webkit.org/show_bug.cgi?id=114671
579
580         Reviewed by Csaba Osztrogonác.
581
582         Account class was added to support watch list email addresses that are not associated with
583         a particular contributor but nobody uses these email address since Chromium port forked.
584
585         Remove it.
586
587         Also removed account_by_login from CommitterList since it was never called except its unittests.
588
589         * Scripts/webkitpy/common/checkout/changelog.py:
590         * Scripts/webkitpy/common/config/committers.py:
591         (Contributor):
592         (Contributor.matches_glob):
593         (Reviewer.__init__):
594         (CommitterList.__init__):
595         (CommitterList._email_to_account_map):
596         (CommitterList._login_to_account_map):
597         (CommitterList.contributors_by_fuzzy_match):
598         (CommitterList.contributor_by_email):
599         (CommitterList.contributor_by_name):
600         (CommitterList.committer_by_email):
601         (CommitterList.reviewer_by_email):
602         * Scripts/webkitpy/common/config/committers_unittest.py:
603         (CommittersTest.test_committer_lookup):
604         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
605         (Bugzilla._commit_queue_flag):
606         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
607         (test_commit_queue_flag):
608         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
609         (WatchListParser._validate):
610
611 2013-04-16  Mike West  <mkwst@chromium.org>
612
613         Unreviewed update to the watchlist.
614
615         Removing 'mkwst+watchlist@chromium.org' from committers.py and the
616         watchist file; moving to 'mkwst@chromium.org' instead.
617
618         * Scripts/webkitpy/common/config/committers.py:
619         * Scripts/webkitpy/common/config/watchlist:
620
621 2013-04-16  Ryosuke Niwa  <rniwa@webkit.org>
622
623         Move webkitpy.layout_tests.port to webkitpy.port
624         https://bugs.webkit.org/show_bug.cgi?id=114668
625
626         Reviewed by Maciej Stachowiak.
627
628         Moved. Port objects knows a lot more than just layout_tests. They doesn't belong down in layout_tests.
629
630         * Scripts/webkitpy/common/host.py:
631         * Scripts/webkitpy/common/host_mock.py:
632         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
633         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
634         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
635         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
636         * Scripts/webkitpy/layout_tests/lint_test_expectations.py:
637         * Scripts/webkitpy/layout_tests/port: Removed.
638         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
639         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
640         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
641         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py:
642         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
643         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
644         * Scripts/webkitpy/performance_tests/perftest.py:
645         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
646         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
647         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
648         * Scripts/webkitpy/port: Copied from Tools/Scripts/webkitpy/layout_tests/port.
649         * Scripts/webkitpy/port/apple.py:
650         * Scripts/webkitpy/port/base.py:
651         * Scripts/webkitpy/port/base_unittest.py:
652         * Scripts/webkitpy/port/config_unittest.py:
653         (ConfigTest.test_default_configuration__standalone):
654         * Scripts/webkitpy/port/driver_unittest.py:
655         * Scripts/webkitpy/port/efl.py:
656         * Scripts/webkitpy/port/efl_unittest.py:
657         * Scripts/webkitpy/port/factory.py:
658         * Scripts/webkitpy/port/factory_unittest.py:
659         * Scripts/webkitpy/port/gtk.py:
660         * Scripts/webkitpy/port/gtk_unittest.py:
661         * Scripts/webkitpy/port/image_diff.py:
662         * Scripts/webkitpy/port/image_diff_unittest.py:
663         * Scripts/webkitpy/port/leakdetector_unittest.py:
664         * Scripts/webkitpy/port/mac.py:
665         * Scripts/webkitpy/port/mac_unittest.py:
666         * Scripts/webkitpy/port/mock_drt.py:
667         * Scripts/webkitpy/port/mock_drt_unittest.py:
668         * Scripts/webkitpy/port/port_testcase.py:
669         * Scripts/webkitpy/port/qt.py:
670         * Scripts/webkitpy/port/qt_unittest.py:
671         * Scripts/webkitpy/port/server_process_unittest.py:
672         * Scripts/webkitpy/port/test.py:
673         * Scripts/webkitpy/port/win.py:
674         * Scripts/webkitpy/port/win_unittest.py:
675         * Scripts/webkitpy/port/xvfbdriver.py:
676         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
677         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
678         * Scripts/webkitpy/tool/commands/gardenomatic.py:
679         * Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
680         * Scripts/webkitpy/tool/commands/queries.py:
681         * Scripts/webkitpy/tool/commands/queries_unittest.py:
682         * Scripts/webkitpy/tool/commands/rebaseline.py:
683         * Scripts/webkitpy/tool/servers/gardeningserver.py:
684         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
685         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
686         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
687
688 2013-04-16  Commit Queue  <rniwa@webkit.org>
689
690         Unreviewed, rolling out r148498.
691         http://trac.webkit.org/changeset/148498
692         https://bugs.webkit.org/show_bug.cgi?id=114669
693
694         Appears to have broken EWS (Requested by rniwa on #webkit).
695
696         * Scripts/webkitpy/common/config/ews.json: Removed.
697         * Scripts/webkitpy/tool/commands/__init__.py:
698         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
699         (AbstractEarlyWarningSystem):
700         (AbstractEarlyWarningSystem.__init__):
701         (AbstractEarlyWarningSystem.handle_script_error.does):
702         (GtkEWS):
703         (GtkWK2EWS):
704         (EflEWS):
705         (QtEWS):
706         (QtWK2EWS):
707         (WinEWS):
708         (MacEWS):
709         (MacWK2EWS):
710         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
711         (EarlyWarningSystemTest._default_expected_logs):
712         (_test_ews):
713         (test_ewses):
714
715 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
716
717         Isolate Early Warning System definitions into a JSON
718         https://bugs.webkit.org/show_bug.cgi?id=114558
719
720         Reviewed by Benjamin Poulain.
721
722         Added ews.json to common/config, and made tool/commands/__init__.py call
723         AbstractEarlyWarningSystem.load_ews_classes to instantiate classes based on ews.json.
724
725         * Scripts/webkitpy/common/config/ews.json: Extracted from earlywarningsystem.py.
726         * Scripts/webkitpy/tool/commands/__init__.py:
727         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
728         (AbstractEarlyWarningSystem):
729         (AbstractEarlyWarningSystem.__init__):
730         (AbstractEarlyWarningSystem.load_ews_classes): Added. Loads ews.json.
731         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
732         (EarlyWarningSystemTest._default_expected_logs):
733         (_test_ews):
734         (test_ewses):
735
736 2013-04-15  Ryosuke Niwa  <rniwa@webkit.org>
737
738         WKR gets stuck when there are many merges
739         https://bugs.webkit.org/show_bug.cgi?id=114632
740
741         Reviewed by Andreas Kling.
742
743         Move the last revision forward when it exists in a branch.
744         Otherwise, we'll be stuck looping over revisions made to merge patches.
745
746         * Scripts/webkitpy/tool/commands/newcommitbot.py:
747         (NewCommitBot.next_work_item):
748
749 2013-04-15  Gustavo Noronha Silva  <gns@gnome.org>
750
751         [GTK] Missing a few packages for building on stock Fedora
752         https://bugs.webkit.org/show_bug.cgi?id=113916
753
754         Reviewed by Philippe Normand.
755
756         * gtk/install-dependencies: add packages that are missing.
757
758 2013-04-15  Zan Dobersek  <zdobersek@igalia.com>
759
760         REGRESSION (r148360): Failure in webkitpy.tool.multicommandtool_unittest.MultiCommandToolTest.test_command_help
761         https://bugs.webkit.org/show_bug.cgi?id=114602
762
763         Reviewed by Ryosuke Niwa.
764
765         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
766         (CommandTest.test_required_arguments): Reset the static argument_names variable on the TrivialCommand
767         interface so its value doesn't leak into the following tests.
768
769 2013-04-15  Zan Dobersek  <zandobersek@gmail.com>
770
771         Deprecate land-cowboy in favor of land-cowhand
772         https://bugs.webkit.org/show_bug.cgi?id=104470
773
774         Reviewed by Darin Adler.
775
776         Move the LandCowboy command implementation under the LandCowhand command and deprecate the former.
777
778         * Scripts/webkitpy/tool/commands/download.py:
779         (LandCowhand):
780         (LandCowboy):
781         (LandCowboy._prepare_state):
782         * Scripts/webkitpy/tool/commands/download_unittest.py:
783         (test_land_cowhand): Adjust the unit tests by testing both LandCowhand and LandCowboy,
784         also checking the deprecation message in the output of the latter.
785
786 2013-04-15  Jonathan Liu  <net147@gmail.com>
787
788         Improve Windows cmd.exe detection
789         https://bugs.webkit.org/show_bug.cgi?id=114620
790
791         Reviewed by Jocelyn Turcotte.
792
793         The current detection code handles Windows cmd.exe and Cygwin shell
794         but not does not handle MSYS shell correctly. Simplify and improve the
795         detection by checking MINGW_IN_SHELL instead as used in other places
796         (e.g. qt_functions.prf).
797
798         * qmake/mkspecs/features/default_pre.prf:
799
800 2013-04-15  Manuel Rego Casasnovas  <rego@igalia.com>
801
802         [webkitpy] Use $NUMBER_OF_PROCESSORS in Executive.cpu_count()
803         https://bugs.webkit.org/show_bug.cgi?id=114506
804
805         Reviewed by Philippe Normand.
806
807         * Scripts/webkitpy/common/system/executive.py:
808         (Executive.cpu_count): Modify function in order to use the environment
809         variable $NUMBER_OF_PROCESSORS if it is defined and it is an integer
810         greater than 0.
811
812 2013-04-15  Xan Lopez  <xlopez@igalia.com>
813
814         [BlackBerry] ASSERT in StyleResolver::ensureScopeResolver()
815         https://bugs.webkit.org/show_bug.cgi?id=114615
816
817         Reviewed by Carlos Garcia Campos.
818
819         Enable the style scoped feature if we have support for it.
820
821         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
822         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
823
824 2013-04-15  Allan Sandfeld Jensen  <allan.jensen@digia.com>
825
826         [Qt] QtMultimedia not used when GStreamer is not found
827         https://bugs.webkit.org/show_bug.cgi?id=111842
828
829         Reviewed by Philippe Normand.
830
831         Fallback to using QtMultimedia when native libraries are not found.
832
833         * qmake/mkspecs/features/features.prf:
834
835 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
836
837         Build fix attempt for webkitbot. Unicodify everything.
838
839         * Scripts/webkitpy/tool/bot/irc_command.py:
840         (Whois.execute):
841
842 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
843
844         webkitbot should provide full name, email address, and IRC nicknames on whois
845         https://bugs.webkit.org/show_bug.cgi?id=114494
846
847         Reviewed by Benjamin Poulain.
848
849         A response like the one below is useless. Improve it:
850         webkitbot: rniwa: zdobersek is zdobersek (zandobersek@gmail.com). Why do you ask?
851
852         We now report full name, email address, committer/reviewer status, and IRC nickname.
853
854         Also teach webkitbot how to respond to ping.
855
856         * Scripts/webkitpy/tool/bot/irc_command.py:
857         (PingPong): Moved 
858         (PingPong.execute):
859         (Whois._full_record_and_nick): Renamed and rewritten.
860         (Whois.execute):
861
862         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
863         (IRCCommandTest.test_whois): Updated test cases as needed.
864
865         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
866         (IRCBotTest.test_help): Added ping.
867
868         * Scripts/webkitpy/tool/commands/newcommitbot.py:
869         (NewCommitBot): Teached WKR how to respond to hi.
870
871 2013-04-13  Anders Carlsson  <andersca@apple.com>
872
873         Add form delegate method that's invoked right before sending a submit event to a form element
874         https://bugs.webkit.org/show_bug.cgi?id=114575
875
876         Reviewed by Dan Bernstein.
877
878         Add a test.
879
880         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
881         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm: Added.
882         (-[FormDelegate willSendSubmitEventToForm:inFrame:withValues:]):
883         (TestWebKitAPI):
884         (TestWebKitAPI::TEST):
885         
886         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
887         (TestWebKitAPI::Util::toSTD):
888         Don't crash when a null NSString is passed to toSTD.
889
890 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
891
892         Python test fix attempt after r148360.
893
894         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
895         (test_command_help):
896
897 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
898
899         Merge AbstractDeclarativeCommand into Command as a comment suggests
900         https://bugs.webkit.org/show_bug.cgi?id=114559
901
902         Reviewed by Antti Koivisto.
903
904         Merged two classes as the comment right above AbstractDeclarativeCommand suggested.
905         We need to merge a lot more classes to make webkitpy hackable.
906
907         * Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
908         (AbstractLocalServerCommand):
909         (AbstractLocalServerCommand.__init__):
910         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
911         (AbstractSequencedCommand):
912         (AbstractSequencedCommand.__init__):
913         * Scripts/webkitpy/tool/commands/adduserstogroups.py:
914         (AddUsersToGroups):
915         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
916         (AnalyzeChangeLog):
917         (AnalyzeChangeLog.__init__):
918         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py:
919         * Scripts/webkitpy/tool/commands/bugfortest.py:
920         (BugForTest):
921         * Scripts/webkitpy/tool/commands/bugsearch.py:
922         (BugSearch):
923         * Scripts/webkitpy/tool/commands/chromechannels.py:
924         (ChromeChannels):
925         (__init__):
926         * Scripts/webkitpy/tool/commands/download.py:
927         (AbstractPatchProcessingCommand):
928         * Scripts/webkitpy/tool/commands/findusers.py:
929         (FindUsers):
930         * Scripts/webkitpy/tool/commands/openbugs.py:
931         (OpenBugs):
932         * Scripts/webkitpy/tool/commands/queries.py:
933         (BugsToCommit):
934         (PatchesInCommitQueue):
935         (PatchesToCommitQueue):
936         (PatchesToCommitQueue.__init__):
937         (PatchesToReview):
938         (PatchesToReview.__init__):
939         (PatchesToReview.execute):
940         (WhatBroke):
941         (ResultsFor):
942         (FailureReason):
943         (FindFlakyTests):
944         (TreeStatus):
945         (CrashLog):
946         (PrintExpectations):
947         (PrintExpectations.__init__):
948         (PrintBaselines):
949         (PrintBaselines.__init__):
950         * Scripts/webkitpy/tool/commands/queues.py:
951         (AbstractQueue.__init__):
952         * Scripts/webkitpy/tool/commands/rebaseline.py:
953         (AbstractRebaseliningCommand):
954         * Scripts/webkitpy/tool/commands/suggestnominations.py:
955         (SuggestNominations):
956         (SuggestNominations.__init__):
957         * Scripts/webkitpy/tool/commands/upload.py:
958         (CommitMessageForCurrentDiff):
959         (CommitMessageForCurrentDiff.__init__):
960         (CleanPendingCommit):
961         (CleanReviewQueue):
962         (AssignToCommitter):
963         (PostCommits):
964         (PostCommits.__init__):
965         (MarkBugFixed):
966         (MarkBugFixed.__init__):
967         (CreateBug):
968         (CreateBug.__init__):
969         * Scripts/webkitpy/tool/multicommandtool.py:
970         (Command):
971         (Command.__init__):
972         (Command.main):
973         (HelpCommand):
974         (HelpCommand.__init__):
975         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
976         (TrivialCommand):
977         (TrivialCommand.__init__):
978         (LikesToRetry):
979         (LikesToRetry.__init__):
980         (CommandTest.test_name_with_arguments):
981         (CommandTest.test_required_arguments):
982         (test_command_help):
983
984 2013-04-13  Ed Bartosh  <bartosh@gmail.com>
985
986         [EFL] --minimal build fails with error: 'ViewModeInvalid' is not a member of 'WebCore::Page'
987         https://bugs.webkit.org/show_bug.cgi?id=114048
988
989         Reviewed by Gyuyoung Kim.
990
991         Wrapped view media related code in #if ENABLE(VIEW_MODE_CSS_MEDIA)
992
993         * DumpRenderTree/efl/TestRunnerEfl.cpp:
994         (TestRunner::setViewModeMediaFeature):
995
996 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
997
998         Merge watchlistloader into host since it's an unnecessary indirection
999         https://bugs.webkit.org/show_bug.cgi?id=114555
1000
1001         Reviewed by Antti Koivisto.
1002
1003         We don't need a class to load a file.
1004
1005         * Scripts/webkitpy/common/host.py:
1006         (Host.watch_list):
1007         * Scripts/webkitpy/common/watchlist/watchlistloader.py: Removed.
1008         * Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Removed.
1009
1010 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
1011
1012         Rename JSONResultsGeneratorBase to JSONResultsGenerator
1013         https://bugs.webkit.org/show_bug.cgi?id=114553
1014
1015         Reviewed by Philippe Normand.
1016
1017         Renamed now that we've got rid of the old JSONResultsGenerator in r148352.
1018
1019         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1020         (JSONLayoutResultsGenerator):
1021         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1022         (JSONResultsGenerator):
1023         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1024         (JSONGeneratorTest._test_json_generation):
1025         (JSONGeneratorTest._verify_json_results):
1026
1027 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
1028
1029         Remove more Chromium specific code from webkitpy
1030         https://bugs.webkit.org/show_bug.cgi?id=114552
1031
1032         Reviewed by Philippe Normand.
1033
1034         * Scripts/webkitpy/common/host.py:
1035         (Host.checkout):
1036         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1037         (JSONResultsGeneratorBase):
1038         (JSONResultsGeneratorBase.__init__):
1039         (JSONResultsGeneratorBase._is_results_all_of_type):
1040         * Scripts/webkitpy/layout_tests/port/base.py:
1041         (Port):
1042         (Port.expected_filename):
1043         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1044         (PerfTestsRunner._parse_args):
1045         * Scripts/webkitpy/tool/commands/queues.py:
1046         (PatchProcessingQueue._new_port_name_from_old):
1047         (CommitQueue.did_pass_testing_ews):
1048         * Scripts/webkitpy/tool/commands/rebaseline.py:
1049         (RebaselineTest._results_url):
1050         (Rebaseline._builder_with_name):
1051         * Scripts/webkitpy/tool/mocktool.py:
1052         (MockTool.irc):
1053
1054 2013-04-13  Zan Dobersek  <zdobersek@igalia.com>
1055
1056         Fix flakiness dashboard unit test failures
1057         https://bugs.webkit.org/show_bug.cgi?id=114518
1058
1059         Reviewed by Ryosuke Niwa.
1060
1061         Fix the current failures in unit tests for the flakiness dashboard by adjusting failing
1062         test cases to simulate loading the builders list from the webkit.org build master, replacing
1063         the Chromium builders and platforms that are used in tests with builders and platforms for the
1064         Apple Mac Lion WebKit2 port, and removing two test cases that were testing Chromium-specific
1065         functionality of the dashboard.
1066
1067         This is sort of an interlude to the flakiness dashboard cleanup, with the removal of Chromium-specific
1068         code and hopefully general simplification of the dashboard codebase coming in near future.
1069
1070         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1071         (resetGlobals):
1072         (test):
1073         * TestResultServer/static-dashboards/loader_unittests.js:
1074
1075 2013-04-12  David Kilzer  <ddkilzer@apple.com>
1076
1077         BUILD FIX: Make AccessibilityUIElementIOS.mm build on iOS
1078
1079         Reviewed by Chris Fleizach.
1080
1081         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: Declare
1082         -_accessibilityPath from the WebAccessibilityObjectWrapper
1083         class.
1084         (_CGPathEnumerationIteration): Remove unused CGPoint* variable.
1085
1086 2013-04-12  Jeffrey Pfau  <jpfau@apple.com>
1087
1088         Unreviewed, remove an old email address for myself.
1089
1090         * Scripts/webkitpy/common/config/committers.py:
1091
1092 2013-04-12  Adenilson Cavalcanti  <cavalcantii@gmail.com>
1093
1094         [WK2] WebPageProxy loadURL() won't work when called just after terminateProcess()
1095         https://bugs.webkit.org/show_bug.cgi?id=110743
1096
1097         Reviewed by Benjamin Poulain.
1098
1099         Adding a new test file to check if loading a page just after WebProcess
1100         has crashed (or was terminated) works. The test executes the
1101         following steps (Load, Crash, Load), thus stressing WebProcess
1102         reattach and process termination code path.
1103
1104         * TestWebKitAPI/GNUmakefile.am:
1105         * TestWebKitAPI/PlatformEfl.cmake:
1106         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1107         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
1108         (TestWebKitAPI::setPageLoaderClient):
1109         (TestWebKitAPI::TEST):
1110         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp: Added.
1111         (TestWebKitAPI):
1112         (WebKit2CrashLoader):
1113         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
1114         (TestWebKitAPI::WebKit2CrashLoader::loadUrl):
1115         (TestWebKitAPI::WebKit2CrashLoader::crashWebProcess):
1116         (TestWebKitAPI::didFinishLoad):
1117         (TestWebKitAPI::TEST):
1118         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro:
1119
1120 2013-04-12  Ryosuke Niwa  <rniwa@webkit.org>
1121
1122         [Mac] REGRESSION: Auto substitution strips new lines
1123         https://bugs.webkit.org/show_bug.cgi?id=114537
1124
1125         Reviewed by Enrica Casucci.
1126
1127         Add a rule to replace "helloleworld" by "hello\nworld" for testing purpose.
1128
1129         * DumpRenderTree/mac/DumpRenderTree.mm:
1130         (resetDefaultsToConsistentValues):
1131
1132 2013-04-09  Roger Fong  <roger_fong@apple.com>
1133
1134         Re-enable WinEWS tests.
1135
1136         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1137         (WinEWS):
1138
1139 2013-04-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1140
1141         [GTK] Split GtkAuthenticationDialog in two widgets
1142         https://bugs.webkit.org/show_bug.cgi?id=103644
1143
1144         Reviewed by Xan Lopez.
1145
1146         * gtk/generate-gtkdoc:
1147         (get_webkit2_options): Do not generate api docs for
1148         WebKitAuthenticationDialog which is private in WebKit2.
1149         (get_webkit1_options): Do not generate api docs for
1150         webkitauthenticationdialog which is private in WebKit1.
1151
1152 2013-04-12  Ryosuke Niwa  <rniwa@webkit.org>
1153
1154         WebKit Queues should capitalize K in Wk2
1155         https://bugs.webkit.org/show_bug.cgi?id=114524
1156
1157         Reviewed by Philippe Normand.
1158
1159         * QueueStatusServer/model/queues.py:
1160         (Queue.display_name):
1161
1162 2013-04-12  Ryosuke Niwa  <rniwa@webkit.org>
1163
1164         [Mac] Enable spellchecking tests added in r141471
1165         https://bugs.webkit.org/show_bug.cgi?id=108525
1166
1167         Reviewed by Darin Adler.
1168
1169         * DumpRenderTree/mac/DumpRenderTree.mm:
1170         (createWebViewAndOffscreenWindow):
1171         (resetDefaultsToConsistentValues):
1172         * WebKitTestRunner/TestController.cpp:
1173         (WTR::TestController::resetStateToConsistentValues):
1174
1175 2013-04-12  Manuel Rego Casasnovas  <rego@igalia.com>
1176
1177         [GTK] Enable WebKit2 building on GTK EWSs
1178         https://bugs.webkit.org/show_bug.cgi?id=114500
1179
1180         Reviewed by Philippe Normand.
1181
1182         Add configuration in order to be able to setup GTK EWSs building
1183         WebKit2. A new queue gtk-wk2-ews is added.
1184
1185         * QueueStatusServer/config/queues.py:
1186         * Scripts/webkitpy/common/config/ports.py:
1187         (DeprecatedPort.port):
1188         (GtkWK2Port):
1189         (GtkWK2Port.build_webkit_command):
1190         (GtkWK2Port.run_webkit_tests_command):
1191         * Scripts/webkitpy/common/config/ports_unittest.py:
1192         (DeprecatedPortTest.test_gtk_port):
1193         (DeprecatedPortTest):
1194         (DeprecatedPortTest.test_gtk_wk2_port):
1195         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1196         (GtkWK2EWS):
1197
1198 2013-04-12  Ryosuke Niwa  <rniwa@webkit.org>
1199
1200         Remove Chromium scripts
1201         https://bugs.webkit.org/show_bug.cgi?id=114492
1202
1203         Reviewed by Benjamin Poulain.
1204
1205         * Scripts/run-chromium-webkit-unit-tests: Removed.
1206         * Scripts/update-webkit-chromium: Removed.
1207
1208 2013-04-12  Commit Queue  <rniwa@webkit.org>
1209
1210         Unreviewed, rolling out r148262.
1211         http://trac.webkit.org/changeset/148262
1212         https://bugs.webkit.org/show_bug.cgi?id=114493
1213
1214         Cairo dep should now build, rolling r148247 back in (Requested
1215         by zdobersek on #webkit).
1216
1217         * Scripts/webkitdirs.pm:
1218         (buildAutotoolsProject):
1219         * gtk/jhbuild.modules:
1220
1221 2013-04-11  Commit Queue  <rniwa@webkit.org>
1222
1223         Unreviewed, rolling out r148247.
1224         http://trac.webkit.org/changeset/148247
1225         https://bugs.webkit.org/show_bug.cgi?id=114490
1226
1227         Cairo dep fails to build on builders due to missing EGL
1228         headers (Requested by zdobersek on #webkit).
1229
1230         * Scripts/webkitdirs.pm:
1231         (buildAutotoolsProject):
1232         * gtk/jhbuild.modules:
1233
1234 2013-04-11  Martin Robinson  <mrobinson@igalia.com>
1235
1236         [GTK] Add accelerated 2D canvas support using cairo-gl
1237         https://bugs.webkit.org/show_bug.cgi?id=104672
1238
1239         Reviewed by Alejandro G. Castro.
1240
1241         Since the value of ACCELERATED_2D_CANVAS relies on some somewhat unusual
1242         dependencies, don't override value of the setting determined by configure.
1243         This will make it easier for people using build-webkit, but not the
1244         WebKit JHBuild.
1245
1246         * Scripts/webkitdirs.pm:
1247         (buildAutotoolsProject): Add a blacklist for settings to never override.
1248         * gtk/jhbuild.modules: Build CairoGL.
1249
1250 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
1251
1252         build.webkit.org should link to webkit-queues instead of webkit-commit-queue
1253         https://bugs.webkit.org/show_bug.cgi?id=114477
1254
1255         Reviewed by Benjamin Poulain.
1256
1257         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1258
1259 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
1260
1261         Leaks builder should not be triggered upon new commits
1262         https://bugs.webkit.org/show_bug.cgi?id=114475
1263
1264         Reviewed by Jessie Berlin.
1265
1266         Don't trigger them on new checkins. Wait for Mountain Lion (Build), which already triggers
1267         the leak builder when builds are done.
1268
1269         * BuildSlaveSupport/build.webkit.org-config/config.json:
1270
1271 2013-04-11  Kalev Lember  <kalevlember@gmail.com>
1272
1273         [GTK] Windows build failure after r136056
1274         https://bugs.webkit.org/show_bug.cgi?id=114121
1275
1276         Reviewed by Martin Robinson.
1277
1278         * TestWebKitAPI/config.h: Make sure defines are correct for other
1279         Windows ports than apple-win.
1280
1281 2013-04-11  Ojan Vafai  <ojan@chromium.org>
1282
1283         Remove myself from watchlists.
1284         * Scripts/webkitpy/common/config/watchlist:
1285
1286 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
1287
1288         Build fix. Don't hard-code queues.webkit.org at least during the transition.
1289
1290         * QueueStatusServer/templates/statusbubble.html:
1291
1292 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
1293
1294         Use webkit-queues.appspot.com instead of webkit-commit-queue.appspot.com
1295         https://bugs.webkit.org/show_bug.cgi?id=114397
1296
1297         Reviewed by Benjamin Poulain.
1298
1299         Reland the patch since Alan appears to have finished the migration.
1300
1301         * Scripts/webkitpy/common/net/statusserver.py:
1302         (StatusServer):
1303
1304 2013-04-11  Brian Holt  <brian.holt@samsung.com>
1305
1306         [Gtk] Combo boxes should be arrow-out-of-able similar to list boxes when caret-browsing is enabled.
1307         https://bugs.webkit.org/show_bug.cgi?id=76796
1308
1309         Reviewed by Chris Fleizach.
1310
1311         Make the Gtk window for the DRT a toplevel so that it gets the
1312         focus from the window manager when the test starts.
1313
1314         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1315         (main):
1316
1317 2013-04-04  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1318
1319         Use CSS4 image-rendering to determing image scaling quality
1320         https://bugs.webkit.org/show_bug.cgi?id=113405
1321
1322         Reviewed by Simon Fraser.
1323
1324         Introduce new flag to enable experimental support for CSS4 Images.
1325
1326         * Scripts/webkitperl/FeatureList.pm:
1327
1328 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
1329
1330         Remove code for Chromium from wkbuild.py
1331         https://bugs.webkit.org/show_bug.cgi?id=114423
1332
1333         Reviewed by Benjamin Poulain.
1334
1335         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1336         (_should_file_trigger_build):
1337         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1338         (ShouldBuildTest):
1339
1340 2013-04-11  Philippe Normand  <pnormand@igalia.com>
1341
1342         Unreviewed, update my IRC nickname.
1343
1344         * Scripts/webkitpy/common/config/committers.py: I no longer use philn-tp.
1345
1346 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
1347
1348         Remove the rest of Chromium code from webkitpy
1349         https://bugs.webkit.org/show_bug.cgi?id=114420
1350
1351         Reviewed by Benjamin Poulain.
1352
1353         * Scripts/webkitpy/common/config/urls.py:
1354         (view_revision_url):
1355         * Scripts/webkitpy/common/host.py:
1356         (Host._engage_awesome_locale_hacks):
1357         (Host.initialize_scm):
1358         (Host):
1359         * Scripts/webkitpy/common/host_mock.py:
1360         (MockHost.__init__):
1361         (MockHost.checkout):
1362         * Scripts/webkitpy/common/net/buildbot/chromiumbuildbot.py: Removed.
1363         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1364         (JSONResultsGeneratorBase._insert_generic_metadata):
1365         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1366         (TestExpectationParser._tokenize_line):
1367         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1368         (ExpectationSyntaxTests.test_bare_name_and_bugs):
1369         (ExpectationSyntaxTests.test_warnings):
1370         * Scripts/webkitpy/layout_tests/port/base.py:
1371         (Port.skips_perf_test):
1372         (Port.path_to_test_expectations_file):
1373         (Port._port_flag_for_scripts):
1374         * Scripts/webkitpy/style/checkers/cpp.py:
1375         (check_function_definition):
1376         (check_include_line):
1377         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1378         (OrderOfIncludesTest.test_check_wtf_includes):
1379         (WebKitStyleTest.test_webkit_export_check):
1380         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1381         (TestExpectationsTestCase.test_valid_expectations):
1382         * Scripts/webkitpy/tool/bot/irc_command.py:
1383         (Rollout.execute):
1384         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1385         (IRCCommandTest.test_whois):
1386         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1387         (IRCBotTest.test_help):
1388         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1389         (SheriffBotTest.test_command_aliases):
1390
1391 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
1392
1393         roll-chromium-deps doesn't roll DEPS
1394         https://bugs.webkit.org/show_bug.cgi?id=114421
1395
1396         Reviewed by Antti Koivisto.
1397
1398         Roll DEPS. Rolling DEPS. Rolled DEPS.
1399
1400         * Scripts/webkitpy/tool/bot/irc_command.py:
1401         (RollChromiumDEPS.execute):
1402
1403 2013-04-11  Glenn Adams  <glenn@skynav.com>
1404
1405         [webkitpy] Remove lingering return_exit_code usage in scm_mock and rebaselineserver.
1406         https://bugs.webkit.org/show_bug.cgi?id=114418
1407
1408         Reviewed by Ryosuke Niwa.
1409
1410         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1411         (MockSCM.add): Remove optional remove_exit_code argument.
1412         (MockSCM.add_list): Remove optional remove_exit_code argument and return value.
1413         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1414         (_rebaseline_test): Use ScriptError to capture SCM.add() failure and exit code.
1415         (_move_test_baselines): Use ScriptError to capture SCM.add() failure and exit code.
1416
1417 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
1418
1419         Fix roll-chromium-deps and hi.
1420
1421         * Scripts/webkitpy/tool/bot/irc_command.py:
1422         (Hi.execute):
1423         (RollChromiumDEPS.execute):
1424
1425 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
1426
1427         Remove webkitpy code to roll Chromium DEPS
1428         https://bugs.webkit.org/show_bug.cgi?id=114415
1429
1430         Reviewed by Benjamin Poulain.
1431
1432         Removed the code to roll Chromium DEPS in WebKit.
1433
1434         * Scripts/webkitpy/common/checkout/checkout.py:
1435         (Checkout.bug_id_for_this_commit):
1436         * Scripts/webkitpy/common/checkout/checkout_mock.py:
1437         (MockCheckout.commit_message_for_this_commit):
1438         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1439         (CheckoutTest.test_suggested_reviewers):
1440         * Scripts/webkitpy/common/checkout/deps.py: Removed.
1441         * Scripts/webkitpy/common/checkout/deps_mock.py: Removed.
1442         * Scripts/webkitpy/tool/bot/irc_command.py:
1443         (RollChromiumDEPS): Teach webkitbot a sense of humor.
1444         (RollChromiumDEPS.execute):
1445         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1446         (IRCCommandTest.test_create_bug):
1447         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1448         (IRCBotTest.test_revert):
1449         * Scripts/webkitpy/tool/bot/sheriff.py:
1450         (Sheriff.post_rollout_patch):
1451         * Scripts/webkitpy/tool/commands/__init__.py:
1452         * Scripts/webkitpy/tool/commands/roll.py: Removed.
1453         * Scripts/webkitpy/tool/commands/roll_unittest.py: Removed.
1454         * Scripts/webkitpy/tool/steps/__init__.py:
1455         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Removed.
1456         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Removed.
1457         * Scripts/webkitpy/tool/steps/updatechromiumdeps_unittest.py: Removed.
1458
1459 2013-04-11  Glenn Adams  <glenn@skynav.com>
1460
1461         [webkitpy] SVNTest fails four tests when using subversion client 1.7 or later
1462         https://bugs.webkit.org/show_bug.cgi?id=114386
1463
1464         Reviewed by Benjamin Poulain.
1465
1466         Subversion client 1.7 uses a new locking scheme that invalidates the technique used
1467         in test_svn_lock(), so skip that test for 1.7 (or later) until a new technique
1468         can be implemented. Further, 1.7 changed svn add to not add intermediate directories
1469         by default and to return exit code 1 if a file/dir had already been added.
1470
1471         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1472         (test_svn_lock): Skip body of test if subversion client 1.7 or later.
1473         * Scripts/webkitpy/common/checkout/scm/svn.py:
1474         (SVN.add_list): Use --parents option and handle exit code 1 if subversion client 1.7 or later.
1475
1476 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
1477
1478         Unreviewed.
1479
1480         * GNUmakefile.am: Removing extra whitespace that's producing warnings.
1481
1482 2013-04-10  Glenn Adams  <glenn@skynav.com>
1483
1484         [webkitpy] Remove unused return_exit_code argument and returned values from SCM.{add,add_list}
1485         https://bugs.webkit.org/show_bug.cgi?id=114410
1486
1487         Reviewed by Ryosuke Niwa.
1488
1489         * Scripts/webkitpy/common/checkout/scm/git.py:
1490         (Git.add_list): Remove optional return_exit_code argument. Remove return value.
1491         * Scripts/webkitpy/common/checkout/scm/scm.py:
1492         (SCM.add): Remove optional return_exit_code argument.
1493         (SCM.add_list): Remove optional return_exit_code argument.
1494         * Scripts/webkitpy/common/checkout/scm/svn.py:
1495         (SVN.add_list): Remove optional return_exit_code argument. Remove return value.
1496
1497 2013-04-10  Eric Seidel  <eric@webkit.org>
1498
1499         Remove myself from the watchlists, I'm getting too much bug mail. :)
1500
1501         * Scripts/webkitpy/common/config/watchlist:
1502
1503 2013-04-10  Commit Queue  <rniwa@webkit.org>
1504
1505         Unreviewed, rolling out r148158.
1506         http://trac.webkit.org/changeset/148158
1507         https://bugs.webkit.org/show_bug.cgi?id=114405
1508
1509         We need to migrate status data (Requested by rniwa on
1510         #webkit).
1511
1512         * Scripts/webkitpy/common/net/statusserver.py:
1513         (StatusServer):
1514
1515 2013-04-10  Benjamin Poulain  <bpoulain@apple.com>
1516
1517         Mass remove all the empty directories
1518
1519         Rubberstamped by Ryosuke Niwa.
1520
1521         * BuildSlaveSupport/gtk/crashmon/log: Removed.
1522         * BuildSlaveSupport/gtk/xvfb/log: Removed.
1523         * DumpRenderTree/ForwardingHeaders/wtf: Removed.
1524         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit: Removed.
1525         * MiniBrowser/gtk/WebBundle: Removed.
1526         * MiniBrowser/win: Removed.
1527         * QtTestPlatformPlugin/mac: Removed.
1528         * Scripts/webkitpy/tool/bot/testdata: Removed.
1529         * Scripts/webkitpy/tool/commands/data/rebaselineserver: Removed.
1530         * efl/ImageDiff: Removed.
1531         * iExploder/htdocs: Removed.
1532         * iExploder/iexploder-1.7.2/output: Removed.
1533         * iExploder/tools: Removed.
1534         * qmake/config.tests/libexecdir: Removed.
1535         * qmake/config.tests/libjpeg: Removed.
1536         * qmake/config.tests/libpng: Removed.
1537
1538 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
1539
1540         Use webkit-queeus.appspot.com instead of webkit-commit-queue.appspot.com
1541         https://bugs.webkit.org/show_bug.cgi?id=114397
1542
1543         Reviewed by Benjamin Poulain.
1544
1545         * Scripts/webkitpy/common/net/statusserver.py:
1546         (StatusServer):
1547
1548 2013-04-10  Adam Barth  <abarth@webkit.org>
1549
1550         Remove abarth from watchlists
1551         https://bugs.webkit.org/show_bug.cgi?id=114390
1552
1553         Reviewed by Ryosuke Niwa.
1554
1555         I'm trying to cut down on the amount of bugmail I get so that I'll have
1556         more of a chance to notice a piece of bugmail directed at me.
1557
1558         * Scripts/webkitpy/common/config/watchlist:
1559
1560 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
1561
1562         webkit-test-results.appspot.com loads the dashboard for Chromium by default
1563         https://bugs.webkit.org/show_bug.cgi?id=114381
1564
1565         Reviewed by Benjamin Poulain.
1566
1567         Changed the defaults.
1568
1569         * TestResultServer/static-dashboards/builders.js:
1570         * TestResultServer/static-dashboards/dashboard_base.js:
1571         (currentBuilderGroupCategory):
1572
1573 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
1574
1575         Remove Chromium EWS bots from the queue status server
1576         https://bugs.webkit.org/show_bug.cgi?id=113988
1577
1578         Reviewed by Benjamin Poulain.
1579
1580         Removed Chromium EWS bots. Also updated it to use webkit-queues.appspot.com.
1581
1582         * QueueStatusServer/app.yaml:
1583         * QueueStatusServer/config/queues.py:
1584         * QueueStatusServer/model/queues.py:
1585         (Queue.short_name):
1586         (Queue.display_name):
1587         * QueueStatusServer/model/queues_unittest.py:
1588         (QueueTest.test_short_name):
1589         (QueueTest.test_display_name):
1590         (QueueTest.test_name_with_underscores):
1591         * QueueStatusServer/templates/activebots.html:
1592
1593 2013-04-10  Ojan Vafai  <ojan@chromium.org>
1594
1595         Change all instances of test-results.appspot.com to webkit-test-results.appspot.com
1596         https://bugs.webkit.org/show_bug.cgi?id=114370
1597
1598         Reviewed by Ryosuke Niwa.
1599
1600         Finish the transition of WebKit over to it's own instance of the flakiness dashboard.
1601         Unfortunately, there's no way to test this until this is committed and there is
1602         a master restart.
1603
1604         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1605         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1606         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
1607         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1608         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1609         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1610         * TestResultServer/generate_builders_json.py:
1611         * TestResultServer/static-dashboards/dashboard_base.js:
1612         * TestResultServer/static-dashboards/loader.js:
1613
1614 2013-04-10  Glenn Adams  <glenn@skynav.com>
1615
1616         [Qt] Fix regression to test-webkitpy.
1617         https://bugs.webkit.org/show_bug.cgi?id=114368
1618
1619         Reviewed by Ryosuke Niwa.
1620
1621         * Scripts/webkitpy/layout_tests/port/factory.py:
1622         (PortFactory._default_port): Return qt-linux instead of chromium-linux as default port for linux/freebsd.
1623         (PortFactory.get): Remove obsolete chromium port related code.
1624         * Scripts/webkitpy/layout_tests/port/mac.py:
1625         (MacPort.default_child_processes): Prevent type error if can't determine total memory.
1626
1627 2013-04-10  Anders Carlsson  <andersca@apple.com>
1628
1629         Remove unneeded headers from FrameLoader.h
1630         https://bugs.webkit.org/show_bug.cgi?id=114223
1631
1632         Reviewed by Geoffrey Garen.
1633
1634         Add back headers implicitly included by other headers.
1635
1636         * WebKitTestRunner/WorkQueueManager.cpp:
1637
1638 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
1639
1640         [GTK] Include a crash-fixing patch for the at-spi2-atk dependency
1641         https://bugs.webkit.org/show_bug.cgi?id=114365
1642
1643         Reviewed by Martin Robinson.
1644
1645         Add a patch for the at-spi2-atk 2.8.0 dependency that is applied through the Jhbuild setup.
1646         The patch addresses crashes in the tally_event_reply method. It is already committed into the
1647         at-spi2-atk source tree and will be available with the next stable release, after which the
1648         patch should be removed and the dependency version bumped.
1649
1650         * gtk/jhbuild.modules:
1651         * gtk/patches/at-spi2-atk-2.8.0-null-check-after-cleanup.patch: Added.
1652
1653 2013-04-10  Brent Fulgham  <bfulgham@webkit.org>
1654
1655         [WinCairo] Unreviewed build fix. Correct DropBox download link.
1656
1657         * Scripts/update-webkit-wincairo-libs: Revise download URL to
1658         match change in DropBox server behavior.
1659
1660 2013-04-09  Geoffrey Garen  <ggaren@apple.com>
1661
1662         Removed an annoying message from svn-create-patch
1663         https://bugs.webkit.org/show_bug.cgi?id=114332
1664
1665         Reviewed by Alexey Proskuryakov.
1666
1667         I see this message basically every time I write a patch, so it must not
1668         be true.
1669
1670         * Scripts/svn-create-patch:
1671         (generateDiff):
1672
1673 2013-04-10  Anton Obzhirov  <a.obzhirov@samsung.com>
1674
1675         [GTK] Add support for Page Visibility
1676         https://bugs.webkit.org/show_bug.cgi?id=97324
1677
1678         Reviewed by Sam Weinig.
1679
1680         Implemented test runner API for page visibility layout tests.
1681
1682         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1683         (TestRunner::resetPageVisibility):
1684         (TestRunner::setPageVisibility):
1685         * Scripts/webkitperl/FeatureList.pm:
1686
1687 2013-04-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1688
1689         [ATK] REGRESSION(r148033): Add a stub for AccessibilityUIElement::pathDescription().
1690         https://bugs.webkit.org/show_bug.cgi?id=114342
1691
1692         Reviewed by Gyuyoung Kim.
1693
1694         Commit 148033 only added an implementation for the Mac port, which made
1695         other ports fail most tests since loading the injected bundle failed
1696         with a missing symbol.
1697
1698         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1699         (WTR::AccessibilityUIElement::pathDescription):
1700
1701 2013-04-10  Artur Moryc  <a.moryc@samsung.com>
1702
1703         [EFL] Add spell checking option to MiniBrowser
1704         https://bugs.webkit.org/show_bug.cgi?id=114282
1705
1706         Reviewed by Ryosuke Niwa.
1707
1708         Spell checking is enabled by adding a flag (t/text-checking)
1709         with launching MiniBrowser.
1710
1711         * MiniBrowser/efl/main.c:
1712         (window_create):
1713         (elm_main):
1714
1715 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
1716
1717         REGRESSION (r146518): WebKit2APITests/TestInspector is failing
1718         https://bugs.webkit.org/show_bug.cgi?id=113281
1719
1720         Reviewed by Darin Adler.
1721
1722         * Scripts/run-gtk-tests:
1723         (TestRunner): Remove the skip entry for the WebKit2APITests/TestInspector unit test.
1724
1725 2013-04-09  Glenn Adams  <glenn@skynav.com>
1726
1727         Fix trivial test-webkitpy regression introduced by http://trac.webkit.org/changeset/148075.
1728
1729         Unreviewed.
1730
1731         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1732         (RunTest.test_build_check):
1733
1734 2013-04-09  Glenn Adams  <glenn@skynav.com>
1735
1736         [webkitpy] Remove chromium ports.
1737         https://bugs.webkit.org/show_bug.cgi?id=114326
1738
1739         Reviewed by Dirk Pranke.
1740
1741         As a side effect, also:
1742
1743         - remove chromium builders from webkitpy.layout_tests.port.builders
1744         - remove chromium builders from rebaseline
1745         - rewrite chromium dependent tests in rebaseline_unittest
1746         - remove chromium platform from garden-o-matic
1747         - select apple platform as default platform in garden-o-matic
1748         - remove chromium port dependencies from a few other tests (run_webkit_tests_integrationtest, factory_unittest, style.checkers.test_expectations_unittest)
1749
1750         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1751         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1752         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
1753         (BaselineOptimizerTest.test_move_baselines):
1754         (BaselineOptimizerTest.test_efl):
1755         (BaselineOptimizerTest.test_no_add_mac_future):
1756         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
1757         (BaselineOptimizerTest.test_common_directory_includes_root):
1758         (BaselineOptimizerTest.test_complex_shadowing):
1759         (BaselineOptimizerTest.test_virtual_ports_filtered):
1760         * Scripts/webkitpy/layout_tests/port/builders.py:
1761         * Scripts/webkitpy/layout_tests/port/chromium.py: Removed.
1762         * Scripts/webkitpy/layout_tests/port/chromium_android.py: Removed.
1763         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py: Removed.
1764         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Removed.
1765         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: Removed.
1766         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Removed.
1767         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: Removed.
1768         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py: Removed.
1769         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Removed.
1770         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Removed.
1771         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: Removed.
1772         * Scripts/webkitpy/layout_tests/port/factory.py:
1773         (platform_options):
1774         (PortFactory):
1775         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1776         (FactoryTest.test_qt):
1777         (FactoryTest.test_get_from_builder_name):
1778         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1779         (RunTest.test_build_check):
1780         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1781         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
1782         * Scripts/webkitpy/tool/commands/rebaseline.py:
1783         (Rebaseline._builders_to_pull_from):
1784         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1785         (_BaseTestCase):
1786         (_BaseTestCase.setUp):
1787         (TestRebaselineTest.setUp):
1788         (TestRebaselineTest.test_baseline_directory):
1789         (test_rebaseline_updates_expectations_file):
1790         (test_rebaseline_does_not_include_overrides):
1791         (test_rebaseline_test):
1792         (test_rebaseline_test_and_print_scm_changes):
1793         (test_rebaseline_and_copy_test):
1794         (test_rebaseline_and_copy_test_no_existing_result):
1795         (test_rebaseline_and_copy_test_with_lion_result):
1796         (test_rebaseline_and_copy_no_overwrite_test):
1797         (TestRebaselineExpectations.test_rebaseline_expectations):
1798
1799 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
1800
1801         newcommitbot (WKR) requires a subversion checkout
1802         https://bugs.webkit.org/show_bug.cgi?id=114309
1803
1804         Reviewed by Benjamin Poulain.
1805
1806         Directly talk to the subversion server instead of relying on a local checkout.
1807         This allows us to run WKR off of a git clone.
1808
1809         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1810         (NewCommitBot.next_work_item):
1811         (NewCommitBot.process_work_item):
1812
1813 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
1814
1815         webkitbot refers to sheriffbot in help
1816         https://bugs.webkit.org/show_bug.cgi?id=114307
1817
1818         Reviewed by Benjamin Poulain.
1819
1820         Fixed the bug by proxying the IRC nickname of "sheriffbot" via Sheriff object.
1821
1822         * Scripts/webkitpy/tool/bot/irc_command.py:
1823         (Help):
1824         (Help.execute):
1825         (RollChromiumDEPS.execute):
1826         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1827         (IRCBotTest.test_help):
1828         * Scripts/webkitpy/tool/bot/sheriff.py:
1829         (Sheriff.name):
1830
1831 2013-04-06  Roger Fong  <roger_fong@apple.com>
1832
1833         Kill old processes between runs on WinEWS bots.
1834         Temporarily disable tests to let bots catch up again.
1835
1836         * EWSTools/start-queue-win.sh:
1837         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1838         (WinEWS):
1839
1840 2013-04-09  Glenn Adams  <glenn@skynav.com>
1841
1842         [webkitpy] Remove chromium deprecated port support.
1843         https://bugs.webkit.org/show_bug.cgi?id=114228
1844
1845         Reviewed by Ryosuke Niwa.
1846
1847         * Scripts/webkitpy/common/config/ports.py:
1848         (DeprecatedPort.port): Removed chromium ports from port name to port class mapping.
1849         (ChromiumPort): Removed.
1850         (ChromiumAndroidPort): Removed.
1851         (ChromiumXVFBPort): Removed.
1852         * Scripts/webkitpy/common/config/ports_unittest.py:
1853         (DeprecatedPortTest.test_chromium_port): Removed.
1854         (DeprecatedPortTest.test_chromium_android_port): Removed.
1855         (DeprecatedPortTest.test_chromium_xvfb_port): Removed.
1856         * Scripts/webkitpy/tool/steps/update_unittest.py:
1857         (UpdateTest.test_update_command_non_interactive): Use mac instead of chromium ports.
1858         (UpdateTest.test_update_command_interactive): Use mac instead of chromium ports.
1859
1860 2013-04-09  Chris Fleizach  <cfleizach@apple.com>
1861
1862         AX: The bounding paths should be made available through accessibility
1863         https://bugs.webkit.org/show_bug.cgi?id=113817
1864
1865         Reviewed by David Kilzer.
1866
1867         Add a pathDescription property for testing so that it's possible
1868         to verify that a path is being returned correctly.
1869
1870         * DumpRenderTree/AccessibilityUIElement.cpp:
1871         (getPathDescriptionCallback):
1872         (AccessibilityUIElement::pathDescription):
1873         (AccessibilityUIElement::getJSClass):
1874         * DumpRenderTree/AccessibilityUIElement.h:
1875         (AccessibilityUIElement):
1876         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1877         (_CGPathEnumerationIteration):
1878         (AccessibilityUIElement::pathDescription):
1879         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1880         (AccessibilityUIElement::pathDescription):
1881         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1882         (WTR::AccessibilityUIElement::pathDescription):
1883         (WTR):
1884         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1885         (AccessibilityUIElement):
1886         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1887         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1888         (WTR::AccessibilityUIElement::pathDescription):
1889         (WTR):
1890
1891 2013-04-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1892
1893         [EFL] Declare TEST_THEME_DIR in a single place.
1894         https://bugs.webkit.org/show_bug.cgi?id=114285
1895
1896         Reviewed by Anders Carlsson.
1897
1898         Adapt to the renaming of `THEME_DIR' to `TEST_THEME_DIR'.
1899
1900         * DumpRenderTree/efl/CMakeLists.txt:
1901         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1902         (DumpRenderTreeChrome::createView):
1903         (DumpRenderTreeChrome::createInspectorView):
1904         (DumpRenderTreeChrome::initialize):
1905         (DumpRenderTreeChrome::onDownloadRequest):
1906         * EWebLauncher/CMakeLists.txt:
1907         * EWebLauncher/main.c:
1908         (findThemePath):
1909         * EWebLauncher/url_bar.c:
1910         (url_bar_add):
1911         * MiniBrowser/efl/CMakeLists.txt:
1912         * MiniBrowser/efl/main.c:
1913         (window_create):
1914         * TestWebKitAPI/PlatformEfl.cmake:
1915         * TestWebKitAPI/efl/PlatformWebView.cpp:
1916         (TestWebKitAPI::PlatformWebView::PlatformWebView):
1917         * WebKitTestRunner/PlatformEfl.cmake:
1918         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1919         (WTR::PlatformWebView::PlatformWebView):
1920
1921 2013-04-09  ChangSeok Oh  <changseok.oh@collabora.com>
1922
1923         [GTK][AC] upversion of clutter and its dependecy
1924         https://bugs.webkit.org/show_bug.cgi?id=114016
1925
1926         Reviewed by Gustavo Noronha Silva.
1927
1928         Upversion of clutter to 1.14, cogl to 1.14 and clutter-gtk to 1.4.4.
1929
1930         * gtk/jhbuild-optional.modules:
1931
1932 2013-04-09  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1933
1934         [WK2] Drop WebProcess capabilities on Linux using seccomp filters
1935         https://bugs.webkit.org/show_bug.cgi?id=89875
1936
1937         Reviewed by Maciej Stachowiak.
1938
1939         Add unit tests to verify if the handling of the open, openat, creat syscall
1940         is being done right. We check if the Read/Write/ReadAndWrite permissions
1941         are respected, if the canonical path is being resolved and if
1942         the permissions are falling back to the topmost parent directory with a
1943         policy set when the directory being opened has no policy.
1944
1945         We also test if any attempt of blocking SIGSYS is silently ignored.
1946         SIGSYS cannot be blocked because in it's handler is where we hook
1947         syscalls to the broker process.
1948
1949         Also added libseccomp to EFL's jhbuild to make the life of developers
1950         willing to help easier.
1951
1952         * Scripts/webkitperl/FeatureList.pm:
1953         * TestWebKitAPI/PlatformEfl.cmake:
1954         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp: Added.
1955         (TestWebKitAPI):
1956         (SeccompEnvironment):
1957         (TestWebKitAPI::SeccompEnvironment::SetUp):
1958         (TestWebKitAPI::SeccompEnvironment::TearDown):
1959         (TestWebKitAPI::dummyHandler):
1960         (TestWebKitAPI::TEST):
1961         (TestWebKitAPI::stressTest):
1962         * efl/jhbuild.modules:
1963         * qmake/mkspecs/features/features.pri:
1964
1965 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
1966
1967         REGRESSION: Autocorrection doesn't work in DumpRenderTree
1968         https://bugs.webkit.org/show_bug.cgi?id=113846
1969
1970         Reviewed by Alexey Proskuryakov.
1971
1972         The problem was that we were replacing NSSpellCheck's dictionary with our own
1973         in DumpRenderTree but we were not adding necessary corrections to the dictionary.
1974
1975         Fixed the bug by having NSSpellChecker correct "mesage" and "wouldn" to "message"
1976         and "would" respectively in DumpRenderTree.
1977
1978         * DumpRenderTree/mac/DumpRenderTree.mm:
1979         (resetDefaultsToConsistentValues):
1980
1981 2013-04-09  Benjamin Poulain  <benjamin@webkit.org>
1982
1983         Remove the gyp files for Tools
1984         https://bugs.webkit.org/show_bug.cgi?id=114248
1985
1986         Reviewed by Ryosuke Niwa.
1987
1988         * DumpRenderTree/DumpRenderTree.gyp: Removed.
1989         * DumpRenderTree/DumpRenderTree.gyp/.gitignore: Removed.
1990         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Removed.
1991         * DumpRenderTree/DumpRenderTree.gypi: Removed.
1992         * TestWebKitAPI/TestWebKitAPI.gyp: Removed.
1993         * TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Removed.
1994         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Removed.
1995         * TestWebKitAPI/TestWebKitAPI.gypi: Removed.
1996
1997 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
1998
1999         WKR (new-commit-bot) is too slow
2000         https://bugs.webkit.org/show_bug.cgi?id=110087
2001
2002         Reviewed by Geoffrey Garen.
2003
2004         Running "svn up" or "git svn fetch" is way too slow (takes 2-3 minutes) on the machine I'm running the bot.
2005         Just run "svn log -r <revision>" instead to cut down the delay.
2006
2007         Unfortunately, this work around doesn't work in a git checkout but who cares given I'm the one running the bot.
2008
2009         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2010         (NewCommitBot):
2011         (NewCommitBot.next_work_item):
2012         (NewCommitBot._is_empty_log):
2013         (NewCommitBot._update_checkout):
2014
2015 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
2016
2017         Build fix. Can't remove appendCustomBuildFlags.
2018
2019         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2020         (appendCustomBuildFlags):
2021
2022 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
2023
2024         Remove Chromium builders from build.webkit.org
2025         https://bugs.webkit.org/show_bug.cgi?id=113990
2026
2027         Reviewed by Benjamin Poulain.
2028
2029         Removed.
2030
2031         * BuildSlaveSupport/build.webkit.org-config/config.json:
2032         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2033         (InstallGtkDependencies):
2034         (RunUnitTests.start):
2035         (RunWebKit2Tests.start):
2036         (Factory.__init__):
2037         (unitTestsSupported):
2038         (TestFactory.__init__):
2039         (BuildAndTestFactory.__init__):
2040         (BuildAndPerfTestFactory.__init__):
2041         (BuildAndPerfTestWebKit2Factory.__init__):
2042         (DownloadAndPerfTestFactory.__init__):
2043         (loadBuilderConfig):
2044         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2045
2046 2013-04-08  Benjamin Poulain  <benjamin@webkit.org>
2047
2048         Remove HTML Notification
2049         https://bugs.webkit.org/show_bug.cgi?id=114231
2050
2051         Reviewed by Ryosuke Niwa.
2052
2053         * qmake/mkspecs/features/features.pri:
2054
2055 2013-04-08  Glenn Adams  <glenn@skynav.com>
2056
2057         Remove chromium EWS support, and fix broken test.
2058         https://bugs.webkit.org/show_bug.cgi?id=114221
2059
2060         Reviewed by Ryosuke Niwa.
2061
2062         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2063         (AbstractChromiumEWS): Removed.
2064         (ChromiumLinuxEWS): Removed.
2065         (ChromiumLinuxDebugEWS): Removed.
2066         (ChromiumWindowsEWS): Removed.
2067         (ChromiumAndroidEWS): Removed.
2068         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2069         (EarlyWarningSystemTest): Fix misspelled class name.
2070         (test_ewses): Fix entry point name to ensure test is run.
2071
2072 2013-04-08  Patrick Gansterer  <paroga@webkit.org>
2073
2074         [WIN] Remove WebKit2 source code
2075         https://bugs.webkit.org/show_bug.cgi?id=114096
2076
2077         Reviewed by Anders Carlsson.
2078
2079         Remove the windows specific parts of the MiniBrowser.
2080
2081         * MiniBrowser/MiniBrowser.vcproj: Removed.
2082         * MiniBrowser/MiniBrowserLauncher.vcproj: Removed.
2083         * MiniBrowser/MiniBrowserPostBuild.cmd: Removed.
2084         * MiniBrowser/MiniBrowserPreBuild.cmd: Removed.
2085         * MiniBrowser/win/BrowserView.cpp: Removed.
2086         * MiniBrowser/win/BrowserView.h: Removed.
2087         * MiniBrowser/win/BrowserWindow.cpp: Removed.
2088         * MiniBrowser/win/BrowserWindow.h: Removed.
2089         * MiniBrowser/win/MiniBrowser.cpp: Removed.
2090         * MiniBrowser/win/MiniBrowser.h: Removed.
2091         * MiniBrowser/win/MiniBrowser.rc: Removed.
2092         * MiniBrowser/win/main.cpp: Removed.
2093         * MiniBrowser/win/resource.h: Removed.
2094         * MiniBrowser/win/stdafx.cpp: Removed.
2095         * MiniBrowser/win/stdafx.h: Removed.
2096
2097 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
2098
2099         Use port 6665 instead of 6667 since the latter doesn't seem to work well.
2100
2101         * Scripts/webkitpy/common/config/irc.py:
2102
2103 2013-04-08  Arunprasad Rajkumar  <arunprasadr@nds.com>
2104
2105         Call Netscape Plugin's toString() and valueOf() instead of providing default implementation
2106         https://bugs.webkit.org/show_bug.cgi?id=113139
2107
2108         Reviewed by Anders Carlsson.
2109
2110         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2111         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
2112         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2113         * DumpRenderTree/TestNetscapePlugIn/Tests/ToStringAndValueOfObject.cpp: Added.
2114         (ToStringAndValueOfObject):
2115         (ToStringAndValueOfObject::ToStringAndValueOfObject):
2116         (ScriptableObject):
2117         (ToStringAndValueOfObject::ScriptableObject::hasMethod):
2118         (ToStringAndValueOfObject::ScriptableObject::invoke):
2119         (ToStringAndValueOfObject::ScriptableObject::pluginTest):
2120         (ToStringAndValueOfObject::NPP_GetValue):
2121         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2122         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2123         * GNUmakefile.am:
2124
2125 2013-04-08  Manuel Rego Casasnovas  <rego@igalia.com>
2126
2127         [GTK] Bump gnome-themes-standard to 3.6.0
2128         https://bugs.webkit.org/show_bug.cgi?id=114155
2129
2130         Reviewed by Martin Robinson.
2131
2132         * gtk/jhbuild.modules: As now we depend on GTK+ 3.6.0 bump the
2133         dependency of gnome-themes-standard accordingly.
2134
2135 2013-04-08  David Levin  <levin@chromium.org>
2136
2137         Remove my watchlist entries.
2138         https://bugs.webkit.org/show_bug.cgi?id=114180
2139
2140         Reviewed by Adam Barth.
2141
2142         * Scripts/webkitpy/common/config/committers.py:
2143         * Scripts/webkitpy/common/config/watchlist:
2144
2145 2013-04-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2146
2147         [EFL] Mark ShouldGoToBackForwardListItem API test as failing
2148         https://bugs.webkit.org/show_bug.cgi?id=114161
2149
2150         Reviewed by Gyuyoung Kim.
2151
2152         Mark ShouldGoToBackForwardListItem API test as failing for EFL port
2153         as it is crashing due to Bug 111074.
2154
2155         * TestWebKitAPI/PlatformEfl.cmake:
2156
2157 2013-04-07  David Kilzer  <ddkilzer@apple.com>
2158
2159         Remove the rest of SVG_DOM_OBJC_BINDINGS
2160         <http://webkit.org/b/114112>
2161
2162         Reviewed by Geoffrey Garen.
2163
2164         * Scripts/webkitperl/FeatureList.pm:
2165         - Remove --svg-dom-objc-bindings switch.
2166         * qmake/mkspecs/features/features.pri:
2167         - Remove reference to ENABLE_SVG_DOM_OBJC_BINDINGS.
2168
2169 2013-04-07  Ed Bartosh  <bartosh@gmail.com>
2170
2171         [EFL] -minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
2172         https://bugs.webkit.org/show_bug.cgi?id=114089
2173
2174         Reviewed by Chris Fleizach.
2175
2176         Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)
2177         * DumpRenderTree/AccessibilityController.cpp:
2178         * DumpRenderTree/AccessibilityUIElement.cpp:
2179         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2180         (DumpRenderTreeChrome::DumpRenderTreeChrome):
2181         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
2182         (DumpRenderTreeChrome):
2183
2184 2013-04-06  Laszlo Gombos  <l.gombos@samsung.com>
2185
2186         Build fix after r147857, remove remaining USE(JSC) guards.
2187
2188         Unreviewed.
2189
2190         * DumpRenderTree/config.h:
2191         * TestWebKitAPI/config.h:
2192         * WebKitTestRunner/config.h:
2193
2194 2013-04-06  Ryosuke Niwa  <rniwa@webkit.org>
2195
2196         Rename sheriffbot to webkitbot
2197         https://bugs.webkit.org/show_bug.cgi?id=114109
2198
2199         Reviewed by Benjamin Poulain.
2200
2201         Renamed since sheriffbot will be used in Blink.
2202
2203         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2204         (SheriffBot):
2205         (SheriffBot.begin_work_queue):
2206
2207 2013-04-06  Oliver Hunt  <oliver@apple.com>
2208
2209         Unify the many and varied stack trace mechanisms, and make the result sane.
2210         https://bugs.webkit.org/show_bug.cgi?id=114072
2211
2212         Reviewed by Filip Pizlo.
2213
2214         The commandline jsc executable no longer requires arguments, so
2215         I've made run-jsc work without them.
2216
2217         * Scripts/run-jsc:
2218
2219 2013-04-06  Ed Bartosh  <bartosh@gmail.com>
2220
2221         [EFL] build fails with error: 'UINT_MAX' was not declared in this scope
2222         https://bugs.webkit.org/show_bug.cgi?id=114086
2223
2224         Reviewed by Tim Horton.
2225
2226         * DumpRenderTree/AccessibilityUIElement.cpp: Included limits.h
2227
2228 2013-04-06  Zan Dobersek  <zdobersek@igalia.com>
2229
2230         Remove remaining PLATFORM(CHROMIUM) guards in TestWebKitAPI, WebKitTestRunner
2231         https://bugs.webkit.org/show_bug.cgi?id=114083
2232
2233         Reviewed by Ryosuke Niwa.
2234
2235         Remove the remaining three occurrences of the PLATFORM(CHROMIUM) build guards
2236         in TestWebKitAPI and WebKitTestRunner.
2237
2238         * TestWebKitAPI/config.h:
2239         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
2240         (TestWebKitAPI::InjectedBundleController::platformInitialize):
2241         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2242         (WTR::InjectedBundle::platformInitialize):
2243
2244 2013-04-06  Geoffrey Garen  <ggaren@apple.com>
2245
2246         Rolled out 147820 and 147818 because they caused plugins tests to ASSERT
2247         https://bugs.webkit.org/show_bug.cgi?id=114094
2248
2249         Reviewed by Anders Carlsson.
2250
2251         * Scripts/run-jsc:
2252
2253 2013-04-05  Ojan Vafai  <ojan@chromium.org>
2254
2255         Move the flakiness dashboard to the new instance at webkit-test-results.appspot.com
2256         https://bugs.webkit.org/show_bug.cgi?id=114080
2257
2258         Reviewed by Ryosuke Niwa.
2259
2260         This way, the WebKit and Blink dashboard code can change as appropriate without
2261         needing to consider the other project's needs. This still doesn't update the
2262         buildbots to upload to the new location, or the dashboard code to pull the
2263         results.json files from the new location, but it at least allows for changing the
2264         UI code (e.g. the WebKit one can remove all knowledge of the Chromium bots).
2265
2266         * TestResultServer/app.yaml:
2267
2268 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
2269
2270         Re-enable testing on the commit queue
2271         https://bugs.webkit.org/show_bug.cgi?id=114078
2272
2273         Reviewed by Darin Adler.
2274
2275         Re-enabled the feature and the associated tests.
2276
2277         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2278         (CommitQueueTask.run):
2279         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2280         (CommitQueueTaskTest._run_through_task):
2281         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2282         (CommitQueueTest._mock_test_result):
2283
2284 2013-04-05  Oliver Hunt  <oliver@apple.com>
2285
2286         Unify the many and varied stack trace mechanisms, and make the result sane.
2287         https://bugs.webkit.org/show_bug.cgi?id=114072
2288
2289         Reviewed by Filip Pizlo.
2290
2291         The commandline jsc executable no longer requires arguments, so
2292         I've made run-jsc work without them.
2293
2294         * Scripts/run-jsc:
2295
2296 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
2297
2298         AX: Make SVG Group containers accessible elements
2299         https://bugs.webkit.org/show_bug.cgi?id=113939
2300
2301         Reviewed by Simon Fraser.
2302
2303         Implement axController.elementAtPoint for iOS.
2304         Implement a correct version of clickPoint for iOS.
2305
2306         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
2307         (AccessibilityController::elementAtPoint):
2308         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2309         (AccessibilityUIElement::clickPointX):
2310         (AccessibilityUIElement::clickPointY):
2311
2312 2013-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
2313
2314         Unreviewed, rolling out r147773 and r147774.
2315         http://trac.webkit.org/changeset/147773
2316         http://trac.webkit.org/changeset/147774
2317         https://bugs.webkit.org/show_bug.cgi?id=114056
2318
2319         Causing some exceptions on AppEngine I don't understand
2320         (Requested by rniwa on #webkit).
2321
2322         * QueueStatusServer/config/queues.py:
2323         * QueueStatusServer/model/queues.py:
2324         (Queue.short_name):
2325         (Queue.display_name):
2326         * QueueStatusServer/model/queues_unittest.py:
2327         (QueueTest.test_short_name):
2328         (QueueTest.test_display_name):
2329         (QueueTest.test_name_with_underscores):
2330
2331 2013-04-05  Geoffrey Garen  <ggaren@apple.com>
2332
2333         Fixed run-bindings-tests by removing V8
2334         https://bugs.webkit.org/show_bug.cgi?id=114053
2335
2336         Reviewed by Benjamin Poulain.
2337
2338         * Scripts/run-bindings-tests:
2339         (main):
2340
2341 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
2342
2343         Build fix.
2344
2345         * QueueStatusServer/model/queues.py:
2346         (Queue.short_name):
2347         (Queue.display_name):
2348
2349 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
2350
2351         Remove Chromium EWS bots from the queue status server
2352         https://bugs.webkit.org/show_bug.cgi?id=113988
2353
2354         Reviewed by Benjamin Poulain.
2355
2356         Removed Chromium EWS bots.
2357
2358         * QueueStatusServer/config/queues.py:
2359         * QueueStatusServer/model/queues.py:
2360         (Queue.short_name):
2361         (Queue.display_name):
2362         * QueueStatusServer/model/queues_unittest.py:
2363         (QueueTest.test_short_name):
2364         (QueueTest.test_display_name):
2365         (QueueTest.test_name_with_underscores):
2366
2367 2013-04-05  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
2368
2369         [EFL] Enable indexed database
2370         https://bugs.webkit.org/show_bug.cgi?id=107248
2371
2372         Reviewed by Alexis Menard.
2373
2374         * Scripts/webkitperl/FeatureList.pm:
2375
2376 2013-04-05  Dimitri Glazkov  <dglazkov@chromium.org>
2377
2378         Remove vestiges of Chromium bits from watchlists.
2379         https://bugs.webkit.org/show_bug.cgi?id=114047
2380
2381         Reviewed by Ryosuke Niwa.
2382
2383         * Scripts/webkitpy/common/config/watchlist: Removed vestiges.
2384
2385 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
2386
2387         Add James Craig to the contributors list.
2388
2389         * Scripts/webkitpy/common/config/committers.py:
2390
2391 2013-04-04  Kent Tamura  <tkent@chromium.org>
2392
2393         Remove ChromiumPublicApi pattern, and cc/message rules for it.
2394
2395         * Scripts/webkitpy/common/config/watchlist:
2396
2397 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
2398
2399         Temporarily disable the Python unittests broken by the commit queue not running layout tests
2400         https://bugs.webkit.org/show_bug.cgi?id=113997
2401
2402         Reviewed by Ryosuke Niwa.
2403
2404         Disable the tests until Ryosuke gets the time and hardware to have
2405         a testing commit-queue.
2406
2407         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2408         (CommitQueueTaskTest):
2409         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2410         (CommitQueueTest):
2411
2412 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
2413
2414         Remove Chromium builders from build.webkit.org
2415         https://bugs.webkit.org/show_bug.cgi?id=113990
2416
2417         Reviewed by Benjamin Poulain.
2418
2419         Land the part to disable triggering of Chromium builders first so that we may start
2420         deleting more Chromium code that breaks the update step.
2421
2422         * BuildSlaveSupport/build.webkit.org-config/config.json:
2423
2424 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
2425
2426         Remove Chromium's DumpRenderTree
2427         https://bugs.webkit.org/show_bug.cgi?id=113989
2428
2429         Reviewed by Kent Tamura.
2430
2431         On second thought, let's not go to Camelot. It is a silly place.
2432
2433         * DumpRenderTree/mac/DumpRenderTree.mm:
2434         (resetDefaultsToConsistentValues):
2435
2436 2013-04-04  Geoffrey Garen  <ggaren@apple.com>
2437
2438         Nixed the defunct chromium folder from DumpRenderTree
2439         https://bugs.webkit.org/show_bug.cgi?id=113993
2440
2441         Reviewed by Ryosuke Niwa.
2442
2443         * DumpRenderTree/chromium: Removed.
2444         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Removed.
2445         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Removed.
2446         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Removed.
2447         * DumpRenderTree/chromium/DRTDevToolsClient.h: Removed.
2448         * DumpRenderTree/chromium/DumpRenderTree.cpp: Removed.
2449         * DumpRenderTree/chromium/ImageDiff.cpp: Removed.
2450         * DumpRenderTree/chromium/LayoutTestHelper.mm: Removed.
2451         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Removed.
2452         * DumpRenderTree/chromium/MockPlatform.cpp: Removed.
2453         * DumpRenderTree/chromium/MockPlatform.h: Removed.
2454         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Removed.
2455         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Removed.
2456         * DumpRenderTree/chromium/Task.cpp: Removed.
2457         * DumpRenderTree/chromium/Task.h: Removed.
2458         * DumpRenderTree/chromium/TestEventPrinter.cpp: Removed.
2459         * DumpRenderTree/chromium/TestEventPrinter.h: Removed.
2460         * DumpRenderTree/chromium/TestNavigationController.cpp: Removed.
2461         * DumpRenderTree/chromium/TestNavigationController.h: Removed.
2462         * DumpRenderTree/chromium/TestNetscapePlugIn: Removed.
2463         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders: Removed.
2464         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit: Removed.
2465         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
2466         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
2467         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
2468         * DumpRenderTree/chromium/TestRunner: Removed.
2469         * DumpRenderTree/chromium/TestRunner/public: Removed.
2470         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Removed.
2471         * DumpRenderTree/chromium/TestRunner/public/WebTask.h: Removed.
2472         * DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
2473         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Removed.
2474         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Removed.
2475         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Removed.
2476         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Removed.
2477         * DumpRenderTree/chromium/TestRunner/src: Removed.
2478         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: Removed.
2479         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: Removed.
2480         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: Removed.
2481         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: Removed.
2482         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: Removed.
2483         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: Removed.
2484         * DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: Removed.
2485         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h: Removed.
2486         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: Removed.
2487         * DumpRenderTree/chromium/TestRunner/src/EventSender.h: Removed.
2488         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: Removed.
2489         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h: Removed.
2490         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
2491         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
2492         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Removed.
2493         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Removed.
2494         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Removed.
2495         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Removed.
2496         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Removed.
2497         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Removed.
2498         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Removed.
2499         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Removed.
2500         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Removed.
2501         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Removed.
2502         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Removed.
2503         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Removed.
2504         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Removed.
2505         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Removed.
2506         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Removed.
2507         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Removed.
2508         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Removed.
2509         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Removed.
2510         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Removed.
2511         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Removed.
2512         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Removed.
2513         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Removed.
2514         * DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Removed.
2515         * DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
2516         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: Removed.
2517         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h: Removed.
2518         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Removed.
2519         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Removed.
2520         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Removed.
2521         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Removed.
2522         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp: Removed.
2523         * DumpRenderTree/chromium/TestRunner/src/TextInputController.h: Removed.
2524         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Removed.
2525         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Removed.
2526         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Removed.
2527         * DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Removed.
2528         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Removed.
2529         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Removed.
2530         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Removed.
2531         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Removed.
2532         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Removed.
2533         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Removed.
2534         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2535         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Removed.
2536         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Removed.
2537         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
2538         * DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
2539         * DumpRenderTree/chromium/TestShell.cpp: Removed.
2540         * DumpRenderTree/chromium/TestShell.h: Removed.
2541         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
2542         * DumpRenderTree/chromium/TestShellMac.mm: Removed.
2543         * DumpRenderTree/chromium/TestShellPosix.cpp: Removed.
2544         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
2545         * DumpRenderTree/chromium/TestShellWin.cpp: Removed.
2546         * DumpRenderTree/chromium/TestShellX11.cpp: Removed.
2547         * DumpRenderTree/chromium/WebViewHost.cpp: Removed.
2548         * DumpRenderTree/chromium/WebViewHost.h: Removed.
2549         * DumpRenderTree/chromium/android_fallback_fonts.xml: Removed.
2550         * DumpRenderTree/chromium/android_main_fonts.xml: Removed.
2551         * DumpRenderTree/chromium/config.h: Removed.
2552         * DumpRenderTree/chromium/fonts.conf: Removed.
2553
2554 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
2555
2556         Remove the rebaseline queue server since nobody except maybe one person from Google uses it.
2557
2558         Rubber stamped by Benjamin Poulain.
2559
2560         * RebaselineQueueServer: Removed.
2561         * RebaselineQueueServer/app.yaml: Removed.
2562         * RebaselineQueueServer/handlers: Removed.
2563         * RebaselineQueueServer/handlers/__init__.py: Removed.
2564         * RebaselineQueueServer/handlers/builderqueue.py: Removed.
2565         * RebaselineQueueServer/handlers/pages.py: Removed.
2566         * RebaselineQueueServer/index.yaml: Removed.
2567         * RebaselineQueueServer/main.py: Removed.
2568         * RebaselineQueueServer/model: Removed.
2569         * RebaselineQueueServer/model/__init__.py: Removed.
2570         * RebaselineQueueServer/model/queueentry.py: Removed.
2571         * RebaselineQueueServer/static: Removed.
2572         * RebaselineQueueServer/static/builder-frame-empty.html: Removed.
2573         * RebaselineQueueServer/static/styles.css: Removed.
2574         * RebaselineQueueServer/templates: Removed.
2575         * RebaselineQueueServer/templates/builder-picker.html: Removed.
2576         * RebaselineQueueServer/templates/builder-queue-edit.html: Removed.
2577         * RebaselineQueueServer/templates/builder-queue-list.html: Removed.
2578         * RebaselineQueueServer/templates/home.html: Removed.
2579
2580 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
2581
2582         Fix setup-commit-queue and temporarily disable testing on commit-queue
2583         https://bugs.webkit.org/show_bug.cgi?id=113979
2584
2585         Reviewed by Benjamin Poulain.
2586
2587         Use commit-queue@webkit.org instead of webkit.bot.review@gmail.com in commit-queue,
2588         and temporarily disable tests in commit-queue as we don't have enough resources at the moment.
2589
2590         * EWSTools/setup-commit-queue.sh:
2591         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2592         (CommitQueueTask.run):
2593
2594 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
2595
2596         temporarily make flakiness dashboard work again webkit.org bots
2597         https://bugs.webkit.org/show_bug.cgi?id=113972
2598
2599         Reviewed by Ojan Vafai.
2600
2601         This patch disables the chromium.org layout test bots TestExpectations
2602         parsing temporarily until we can work out the right way to split into
2603         two instances for webkit.org and chromium.org and figure out which
2604         code to delete where :).
2605
2606         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2607
2608 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
2609
2610         Fix webkitpy tests after r147678.
2611
2612         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2613         (CommitQueueTest.test_commit_queue):
2614         (test_manual_reject_during_processing):
2615
2616 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
2617
2618         The commit queue should use Mac MountainLion port
2619         https://bugs.webkit.org/show_bug.cgi?id=113971
2620
2621         Reviewed by Lucas Forschler.
2622
2623         * EWSTools/setup-commit-queue.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
2624         * Scripts/webkitpy/tool/commands/queues.py:
2625         (CommitQueue):
2626
2627 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
2628
2629         turn off running tests on chromium linux EWS bots
2630         https://bugs.webkit.org/show_bug.cgi?id=113959
2631
2632         Reviewed by Geoffrey Garen.
2633
2634         Now that the Chromium port is no longer being maintained
2635         there's little point in running the tests. Soon we should
2636         just shut this bot off altogether.
2637
2638         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2639         (ChromiumLinuxEWS):
2640
2641 2013-04-04  Andrew Scherkus  <scherkus@chromium.org>
2642
2643         Unreviewed. Removing feature-media-reviews@chromium.org from Media watchlist.
2644
2645         * Scripts/webkitpy/common/config/watchlist:
2646
2647 2013-04-04  Pierre Rossi  <pierre.rossi@gmail.com>
2648
2649         Indentation fix to get webkit-patch working again after r147625
2650
2651         Unreviewed.
2652
2653         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2654         (MacEWS):
2655         (MacWK2EWS):
2656
2657 2013-04-04  Lucas Forschler  <lforschler@apple.com>
2658
2659         Turn tests back on for Mac WK1/WK2 EWS.
2660         
2661         Unreviewed.
2662         
2663         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2664         (MacEWS):
2665         (MacWK2EWS):
2666
2667 2013-04-04  Manuel Rego Casasnovas  <rego@igalia.com>
2668
2669         [GTK][WK2] MiniBrowser custom URI scheme support
2670         https://bugs.webkit.org/show_bug.cgi?id=112419
2671
2672         Reviewed by Carlos Garcia Campos.
2673
2674         Add support for about URIs in MiniBrowser. An example about page is show
2675         with URI "about:minibrowser", the rest of the cases it will show a
2676         proper message explaining that the about page didn't exist.
2677
2678         Internally it uses "minibrowser-about" prefix instead of "about", but
2679         from the user point of view it works with "about" prefix.
2680
2681         * MiniBrowser/gtk/BrowserWindow.c: Add miniBrowserAboutScheme constant.
2682         (getInternalURI): Method to convert URIs from "about" prefix to
2683         "minibrowser-about".
2684         (getExternalURI): Opposite method.
2685         (webViewURIChanged): Use "about" prefix to show the URI to users.
2686         (webViewEnterFullScreen): Ditto.
2687         (browser_window_load_uri): Use "minibrowser-about" prefix internally.
2688         * MiniBrowser/gtk/main.c: Add miniBrowserAboutScheme constant.
2689         (aboutURISchemeRequestCallback): Callback to manage about calls.
2690         (main): Register the URI scheme to manage about URIs.
2691
2692 2013-04-03  Roger Fong  <roger_fong@apple.com>
2693
2694         Re-enable WinEWS tests.
2695
2696         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2697         (WinEWS):
2698
2699 2013-04-03  Zan Dobersek  <zdobersek@igalia.com>
2700
2701         [GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
2702         https://bugs.webkit.org/show_bug.cgi?id=113883
2703
2704         Reviewed by Martin Robinson.
2705
2706         * gtk/jhbuild-optional.modules: Remove the ATK entry as it is now placed in jhbuild.modules.
2707         * gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.
2708         The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.
2709
2710 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
2711
2712         [GTK] Include Pango in jhbuild-optional.modules
2713         https://bugs.webkit.org/show_bug.cgi?id=113878
2714
2715         Reviewed by Martin Robinson.
2716
2717         Since r147547 Pango 1.32.0 is required. Including the module in the
2718         JHBuild optional moduleset.
2719
2720         * gtk/jhbuild-optional.modules: Add Pango module.
2721
2722 2013-04-03  Zeno Albisser  <zeno@webkit.org>
2723
2724         [Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
2725         https://bugs.webkit.org/show_bug.cgi?id=113864
2726
2727         Moving setDefersLoading from TestRunnerQt to TestRunner
2728         requires access to the non-Qt TestRunner.
2729         As long as we instantiate both TestRunner and TestRunnerQt,
2730         we need a separate getter for the non-Qt TestRunner instance.
2731
2732         Reviewed by Simon Hausmann.
2733
2734         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2735         (WebPage::resetSettings):
2736         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2737         (DumpRenderTree::jscTestRunner):
2738         * DumpRenderTree/qt/TestRunnerQt.cpp:
2739         (TestRunner::setDefersLoading):
2740             Moving setDefersLoading from TestRunnerQt
2741             to TestRunner.
2742         * DumpRenderTree/qt/TestRunnerQt.h:
2743         (TestRunnerQt):
2744
2745 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
2746
2747         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
2748         https://bugs.webkit.org/show_bug.cgi?id=104779
2749
2750         Reviewed by Carlos Garcia Campos.
2751
2752         * Scripts/run-gtk-tests:
2753         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
2754         passing in current trunk.
2755
2756 2013-04-03  Pierre Rossi  <pierre.rossi@digia.com>
2757
2758         Fix HAVE(QTTESTSUPPORT) logic
2759
2760         build_qttestsupport has not been added to WEBKIT_CONFIG in detectFeatures,
2761         resulting in HAVE(QTTESTSUPPORT) never being true.
2762         Move that logic down in sanitizeFeatures.
2763
2764         Rubber-stamped by Tor Arne Vestbø.
2765
2766         * qmake/mkspecs/features/features.prf:
2767
2768 2013-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2769
2770         [GTK] Bump required versions of some dependencies
2771         https://bugs.webkit.org/show_bug.cgi?id=113282
2772
2773         Reviewed by Martin Robinson.
2774
2775         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
2776
2777 2013-04-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
2778
2779         [GTK] gst-plugins-good fails to build with newer Linux(v4l2)
2780         https://bugs.webkit.org/show_bug.cgi?id=113809
2781
2782         Reviewed by Philippe Normand.
2783
2784         Newer Linux kernels have removed some deprecated macros from v4l2
2785         headers, causing gst-plugins-good's build to break. We don't need it
2786         right now, so just disable it.
2787
2788         * gtk/jhbuild.modules: disable v4l2 usage in gst-plugins-good.
2789
2790 2013-03-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2791
2792         [Qt] Switch ContextMenu implementation to CROSS_PLATFORM_CONTEXT_MENU
2793         https://bugs.webkit.org/show_bug.cgi?id=113535
2794
2795         Reviewed by Simon Hausmann.
2796
2797         Adding USE_CROSS_PLATFORM_CONTEXT_MENUS to WEBKIT_CONFIG.
2798
2799         * qmake/mkspecs/features/features.prf:
2800
2801 2013-04-03  Zeno Albisser  <zeno@webkit.org>
2802
2803         [Qt] Move logic of simple forwarding functions to TestRunner.
2804         https://bugs.webkit.org/show_bug.cgi?id=113863
2805
2806         Reviewed by Simon Hausmann.
2807
2808         * DumpRenderTree/qt/TestRunnerQt.cpp:
2809         (TestRunner::setTextDirection):
2810         (TestRunner::goBack):
2811         (TestRunner::evaluateScriptInIsolatedWorld):
2812         (TestRunner::addUserStyleSheet):
2813         * DumpRenderTree/qt/TestRunnerQt.h:
2814         (TestRunnerQt):
2815
2816 2013-04-03  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
2817
2818         [Qt] Disable media support using QuickTime if deployment target != SDK
2819
2820         We link to a single libWebKitSystemInterface static lib, so unless the
2821         deployment target matches the SDK let's not pretend like we'll be able
2822         to run on anything lower than the SDK version.
2823
2824         Reviewed by Simon Hausmann.
2825
2826         * qmake/mkspecs/features/features.prf:
2827
2828 2013-04-02  James Craig  <james@cookiecrook.com>
2829
2830         AXRoleDescripton for DL is "list"; should be "description list"
2831         https://bugs.webkit.org/show_bug.cgi?id=111665
2832
2833         Reviewed by Chris Fleizach.
2834
2835         Defining the role and description strings.
2836
2837         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
2838
2839 2013-04-02  Roger Fong  <roger_fong@apple.com>
2840
2841         Unreviewed. Disable running tests on Win EWS queue.
2842
2843         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2844         (WinEWS):
2845
2846 2013-04-02  Lucas Forschler  <lforschler@apple.com>
2847
2848         Disable running tests on the MAC WK2 EWS queue.
2849         
2850         Unreviewed.
2851         
2852         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2853         (MacWK2EWS):
2854
2855 2013-04-02  Julie Parent  <jparent@chromium.org>
2856
2857         Dashboard refactor: Move dashboard specific history related features to History.
2858         https://bugs.webkit.org/show_bug.cgi?id=113717
2859
2860         Reviewed by Ojan Vafai.
2861         
2862         Each dashboard now creates its own History object, with a custom
2863         configuration. This changes from just overriding global functions
2864         to passing in callbacks for generatePage, handleValidHashParameter,
2865         and handleQueryParameterChange. Same with passing in defaultStateValues
2866         and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
2867         variables.
2868         
2869         All functions related to these features are now (mostly) private
2870         function on History. 
2871         
2872         Loader no longer needs a loadingComplete callback, since it can just
2873         initialize the history object itself.
2874
2875         * TestResultServer/static-dashboards/aggregate_results.js:
2876         (handleValidHashParameter):
2877         * TestResultServer/static-dashboards/dashboard_base.js:
2878         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2879         (generatePage):
2880         (.switch.return):
2881         (handleQueryParameterChange):
2882         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2883         (resetGlobals):
2884         * TestResultServer/static-dashboards/history.js:
2885         (.):
2886         * TestResultServer/static-dashboards/loader.js:
2887         (.):
2888         * TestResultServer/static-dashboards/loader_unittests.js:
2889         * TestResultServer/static-dashboards/timeline_explorer.js:
2890         (generatePage):
2891         (initCurrentBuilderTestResults):
2892         * TestResultServer/static-dashboards/treemap.js:
2893         (generatePage):
2894         (.switch.return):
2895         (handleQueryParameterChange):
2896
2897 2013-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2898
2899         Unreviewed, rolling out r147401.
2900         http://trac.webkit.org/changeset/147401
2901         https://bugs.webkit.org/show_bug.cgi?id=113767
2902
2903         The patch makes it extremely hard to set up the dependencies
2904         properly on the GTK builders (Requested by zdobersek on
2905         #webkit).
2906
2907         * gtk/jhbuild.modules:
2908
2909 2013-04-02  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2910
2911         [EFL][WK2] Empty tooltip shown when hovering over popup menu items
2912         https://bugs.webkit.org/show_bug.cgi?id=113382
2913
2914         Reviewed by Gyuyoung Kim.
2915
2916         Do not show the empty tooltip box if the text is null.
2917
2918         * MiniBrowser/efl/main.c:
2919         (popup_menu_populate):
2920
2921 2013-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2922
2923         [GTK] Bump required versions of some dependencies
2924         https://bugs.webkit.org/show_bug.cgi?id=113282
2925
2926         Reviewed by Martin Robinson.
2927
2928         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
2929
2930 2013-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
2931
2932         Unreviewed, rolling out r147319.
2933         http://trac.webkit.org/changeset/147319
2934         https://bugs.webkit.org/show_bug.cgi?id=113707
2935
2936         The unit test is still failing on the buildbot (Requested by
2937         zdobersek on #webkit).
2938
2939         * Scripts/run-gtk-tests:
2940         (TestRunner):
2941
2942 2013-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
2943
2944         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
2945         https://bugs.webkit.org/show_bug.cgi?id=104779
2946
2947         Reviewed by Carlos Garcia Campos.
2948
2949         * Scripts/run-gtk-tests:
2950         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
2951         passing in current trunk.
2952
2953 2013-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
2954
2955         Unreviewed, rolling out r147289.
2956         http://trac.webkit.org/changeset/147289
2957         https://bugs.webkit.org/show_bug.cgi?id=113678
2958
2959         broke Win7 (dbg) build (Requested by shinyak|gardener on
2960         #webkit).
2961
2962         * DumpRenderTree/DumpRenderTree.gypi:
2963         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h.
2964         (WebTestRunner):
2965         (WebUserMediaClientMock):
2966         (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
2967         (WebTestRunner::WebUserMediaClientMock::taskList):
2968         * Scripts/webkitpy/style/checkers/cpp.py:
2969         (check_function_definition):
2970
2971 2013-03-31  Adam Barth  <abarth@webkit.org>
2972
2973         configure-svn-config.sh fails
2974         https://codereview.chromium.org/13392007/
2975
2976         Reviewed by Eric Seidel.
2977
2978         This script was trying to use "svn checkout" to dowload a file from
2979         svn.webkit.org, but "svn checkout" only works with directories.
2980         Instead, we should use "svn export".
2981
2982         * EWSTools/configure-svn-config.sh:
2983
2984 2013-03-31  Wei Jia  <wjia@chromium.org>
2985
2986         Allow WebUserMediaClientMock to be used by client
2987         https://bugs.webkit.org/show_bug.cgi?id=113633
2988
2989         Reviewed by Adam Barth.
2990
2991         Export WebUserMediaClientMock.
2992         Allow files in chromium/TestRunner/public to have WEBKIT_EXPORT.
2993
2994         * DumpRenderTree/DumpRenderTree.gypi:
2995         * DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h.
2996         (WebUserMediaClientMock):
2997         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
2998         * Scripts/webkitpy/style/checkers/cpp.py:
2999         (check_function_definition):
3000
3001 2013-03-29  Alexey Proskuryakov  <ap@apple.com>
3002
3003         Expose FeatureObserver data to WebKit clients
3004         https://bugs.webkit.org/show_bug.cgi?id=113613
3005
3006         Reviewed by Sam Weinig.
3007
3008         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3009         (WTR::InjectedBundlePage::InjectedBundlePage): Added an initializer for featuresUsedInPage.
3010
3011 2013-03-29  Greg Hughes  <ghughes@apple.com>
3012
3013         Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
3014         https://bugs.webkit.org/show_bug.cgi?id=112276
3015
3016         Reviewed by Chris Fleizach.
3017
3018         Added support to test accessibility search predicates with multiple keys.  
3019
3020         * DumpRenderTree/AccessibilityUIElement.cpp:
3021         (uiElementForSearchPredicateCallback):
3022         * DumpRenderTree/AccessibilityUIElement.h:
3023         (AccessibilityUIElement):
3024         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3025         (AccessibilityUIElement::uiElementForSearchPredicate):
3026         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
3027         (AccessibilityUIElement::uiElementForSearchPredicate):
3028         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3029         (AccessibilityUIElement::uiElementForSearchPredicate):
3030         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3031         (AccessibilityUIElement::uiElementForSearchPredicate):
3032         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3033         (AccessibilityUIElement::uiElementForSearchPredicate):
3034         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3035         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
3036         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3037         (AccessibilityUIElement):
3038         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3039         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3040         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
3041         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3042         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
3043
3044 2013-03-29  Ryosuke Niwa  <rniwa@webkit.org>
3045
3046         Fix a typo in r147147 to fix Mac EWS.
3047
3048         * Scripts/webkitpy/tool/commands/queues.py:
3049         (PatchProcessingQueue._new_port_name_from_old):
3050
3051 2013-03-28  Ryuan Choi  <ryuan.choi@samsung.com>
3052
3053         [EFL] Build break with latest EFL libraries after r146265
3054         https://bugs.webkit.org/show_bug.cgi?id=113558
3055
3056         Unreviewed build fix.
3057
3058         * TestWebKitAPI/PlatformWebView.h:
3059         * WebKitTestRunner/PlatformWebView.h:
3060
3061 2013-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3062
3063         Unreviewed. Fix build break when running --update-efl in WebKit EFL.
3064
3065         * efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail
3066         in libgcrypt build.
3067
3068 2013-03-28  Lucas Forschler  <lforschler@apple.com>
3069
3070         Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.
3071
3072         Unreviewed.
3073
3074         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3075         (MacEWS):
3076
3077 2013-03-28  Ryosuke Niwa  <rniwa@webkit.org>
3078
3079         Use the right OS name on Mac EWS instead of mac-future.
3080
3081         Rubber-stamped by Dirk Pranke.
3082
3083         * Scripts/webkitpy/tool/commands/queues.py:
3084         (PatchProcessingQueue._new_port_name_from_old):
3085         (PatchProcessingQueue.begin_work_queue):
3086         (PatchProcessingQueue._upload_results_archive_for_patch):
3087
3088 2013-03-28  Zan Dobersek  <zdobersek@igalia.com>
3089
3090         [GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
3091         https://bugs.webkit.org/show_bug.cgi?id=112546
3092
3093         Reviewed by Martin Robinson.
3094
3095         * GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
3096         moved back to Source/WebCore/platform. Fix an indentation issue as well.
3097
3098 2013-03-28  Ming Xie  <mxie@blackberry.com>
3099
3100         [BlackBerry] Committer Email Updates
3101         https://bugs.webkit.org/show_bug.cgi?id=113435
3102
3103         Reviewed by Rob Buis.
3104
3105         Add the @blackberry.com email address for all our BlackBerry
3106         WebKit committers. This is the first step for our email address
3107         migration.
3108
3109         * Scripts/webkitpy/common/config/committers.py:
3110
3111 2013-03-28  Philippe Normand  <pnormand@igalia.com>
3112
3113         [jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
3114         https://bugs.webkit.org/show_bug.cgi?id=113508
3115
3116         Reviewed by Martin Robinson.
3117
3118         Prevent the GStreamer plugin scanner to load system-wide
3119         plugins. Only the ones built in JHBuild should be loaded and used
3120         at runtime.
3121
3122         * efl/jhbuildrc:
3123         * gtk/jhbuildrc:
3124
3125 2013-03-27  Philippe Normand  <pnormand@igalia.com>
3126
3127         [GTK] run-launcher --gtk -2 fails on a WK2-only build
3128         https://bugs.webkit.org/show_bug.cgi?id=113386
3129
3130         Reviewed by Carlos Garcia Campos.
3131
3132         * Scripts/webkitdirs.pm:
3133         (builtDylibPathForName): The WebKit2GTK .so name change from 1.0
3134         version to 3.0. Reflect this change so the builtDylibPathForName
3135         function doesn't fail to report the library as found.
3136
3137 2013-03-28  Jaehun Lim  <ljaehun.lim@samsung.com>
3138
3139         [CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
3140         https://bugs.webkit.org/show_bug.cgi?id=113484
3141
3142         Unreviewed build fix.
3143
3144         Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.
3145
3146         * TestWebKitAPI/CMakeLists.txt:
3147         * WebKitTestRunner/CMakeLists.txt:
3148
3149 2013-03-27  Mario Sanchez Prada  <mario.prada@samsung.com>
3150
3151         Revision for the internal jhbuild is too old
3152         https://bugs.webkit.org/show_bug.cgi?id=113324
3153
3154         Reviewed by Martin Robinson.
3155
3156         Update the minimum required version to a point where jhbuild won't
3157         fail installing packages when trying to remove a symlink to a directory.
3158
3159         * jhbuild/jhbuild-wrapper: Updated revision.
3160
3161 2013-03-27  Gustavo Noronha Silva  <gns@gnome.org>
3162
3163         [GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup
3164         https://bugs.webkit.org/show_bug.cgi?id=113203
3165
3166         Reviewed by Philippe Normand.
3167
3168         We build our libsoup without GNOME support. gst-plugins-good does separate
3169         pkg-config checks for libsoup-gnome and libsoup, causing the build to use
3170         libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to
3171         build failures as the headers of those diverge. We do not use souphttpsrc, so
3172         disable it when building gst-plugins-good.
3173
3174         * gtk/jhbuild.modules: disable soup support in gst-plugins-good.
3175
3176 2013-03-27  Ryosuke Niwa  <rniwa@webkit.org>
3177
3178         Build fix after r146852. Please another reference to the Lion leaks builder.
3179
3180         * BuildSlaveSupport/build.webkit.org-config/config.json:
3181
3182 2013-03-27  Zan Dobersek  <zdobersek@igalia.com>
3183
3184         [GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
3185         https://bugs.webkit.org/show_bug.cgi?id=113421
3186
3187         Reviewed by Dirk Pranke.
3188
3189         When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
3190         This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
3191         equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
3192         in the GTK-specific TestExpectations files.
3193
3194         To avoid this only enable the warnings only when not using WKTR.
3195
3196         * Scripts/webkitpy/layout_tests/port/gtk.py:
3197         (GtkPort.warn_if_bug_missing_in_test_expectations):
3198
3199 2013-03-27  Antti Koivisto  <antti@apple.com>
3200
3201         Fix Zalan's email.
3202
3203         * Scripts/webkitpy/common/config/committers.py:
3204
3205 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
3206
3207         master.cfg cleanup
3208         https://bugs.webkit.org/show_bug.cgi?id=113195
3209
3210         Reviewed by Ryosuke Niwa.
3211
3212         * BuildSlaveSupport/build.webkit.org-config/config.json:
3213         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3214
3215 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
3216
3217         master.cfg fine-tuning for Qt Mountain Lion Release bot
3218         https://bugs.webkit.org/show_bug.cgi?id=113191
3219
3220         Reviewed by Ryosuke Niwa.
3221
3222         * BuildSlaveSupport/build.webkit.org-config/config.json:
3223           - Rename the slave due to its location change.
3224           - Update the platform of the slave.
3225         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3226         (RunQtAPITests): Enable running WK2 API tests on Qt.
3227         (RunQtAPITests.start):
3228         (RunWebKit2Tests.start): Force pixel tests on the Qt Mountain Lion Release builder.
3229         (BuildAndTestWebKit2Factory): Added. (Build WK1 and WK2 too, but run only WK2 tests.)
3230
3231 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3232
3233         [EFL][jhbuild] Evas fails to build when Wayland is present on the system
3234         https://bugs.webkit.org/show_bug.cgi?id=113403
3235
3236         Reviewed by Kenneth Rohde Christiansen.
3237
3238         As of Evas 1.7.5, when Wayland is detected on the system, support for
3239         both Wayland SHM and Wayland EGL is automatically enabled in autoconf.
3240         The code, however, seems to depend on a few other flags which must be
3241         explicitly enabled.
3242
3243         If those additional GL-related options are passed, we end up
3244         having issues on the WebKit side, so disable Wayland support for
3245         now.
3246
3247         * efl/jhbuild.modules:
3248
3249 2013-03-27  Sheriff Bot  <webkit.review.bot@gmail.com>
3250
3251         Unreviewed, rolling out r146864.
3252         http://trac.webkit.org/changeset/146864
3253         https://bugs.webkit.org/show_bug.cgi?id=113391
3254
3255         causes crashes on Wk2 EFL release bot (Requested by drott on
3256         #webkit).
3257
3258         * Scripts/webkitperl/FeatureList.pm:
3259
3260 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3261
3262         [jhbuild] Correctly specify an alternate number of make jobs.
3263         https://bugs.webkit.org/show_bug.cgi?id=113396
3264
3265         Reviewed by Philippe Normand.
3266
3267         So far, we were using the `MAKEFLAGS' environment variable to pass the
3268         number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
3269         other hand, prefers to use the `jobs' variable from jhbuildrc for that.
3270
3271         We now behave more closely to the rest of the WebKit tools by first
3272         checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
3273         not set, just letting jhbuild itself figure out how many jobs to use.
3274
3275         * efl/jhbuildrc:
3276         * gtk/jhbuildrc:
3277
3278 2013-03-27  Zeno Albisser  <zeno@webkit.org>
3279
3280         [Qt] Remove Qt specific WorkQueueItem definitions.
3281         https://bugs.webkit.org/show_bug.cgi?id=112891
3282
3283         This patch is preparation work for removing
3284         WorkQueue related code from TestRunnerQt and
3285         replacing it with generic TestRunner code.
3286
3287         Reviewed by Benjamin Poulain.
3288
3289         * DumpRenderTree/qt/TestRunnerQt.cpp:
3290         (TestRunnerQt::queueBackNavigation):
3291         (TestRunnerQt::queueForwardNavigation):
3292         (TestRunnerQt::queueLoadHTMLString):
3293         (TestRunnerQt::queueReload):
3294         (TestRunnerQt::queueLoadingScript):
3295         (TestRunnerQt::queueNonLoadingScript):
3296         (TestRunner::queueLoad):
3297         * DumpRenderTree/qt/TestRunnerQt.h:
3298         (TestRunnerQt):
3299         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
3300         (LoadItem::invoke):
3301         (LoadHTMLStringItem::invoke):
3302         (LoadAlternateHTMLStringItem::invoke):
3303         (ReloadItem::invoke):
3304         (ScriptItem::invoke):
3305         (BackForwardItem::invoke):
3306         * DumpRenderTree/qt/WorkQueueItemQt.h:
3307         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
3308         (LoadAlternateHTMLStringItem):
3309
3310 2013-03-26  Julie Parent  <jparent@chromium.org>
3311
3312         Flakiness dashboard: simplify logic around which tests to show.
3313         https://bugs.webkit.org/show_bug.cgi?id=113250
3314
3315         Reviewed by Ojan Vafai.
3316         
3317         The different filters for showing results are only used for layout
3318         tests, otherwise, we show everything.
3319         
3320         Change the defaults to false (what layout tests used), and only
3321         look at the values when viewing layout tests.
3322
3323         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3324         (htmlForTestsWithExpectationsButNoFailures):
3325         (shouldHideTest):
3326
3327 2013-03-26  Isaac Levy  <ilevy@google.com>
3328
3329         Update bots on test-results.appspot
3330         https://bugs.webkit.org/show_bug.cgi?id=113333
3331
3332         Reviewed by Ojan Vafai.
3333
3334         * TestResultServer/static-dashboards/builders.jsonp:
3335
3336 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
3337
3338         Unreviewed GTK gardening.
3339
3340         * Scripts/run-gtk-tests:
3341         (TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.
3342
3343 2013-03-26  Csaba Osztrogonác  <ossy@webkit.org>
3344
3345         [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
3346         https://bugs.webkit.org/show_bug.cgi?id=113287
3347
3348         Reviewed by Jocelyn Turcotte.
3349
3350         * Scripts/run-qtwebkit-tests:
3351         (Options.__init__):
3352
3353 2013-03-26  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
3354
3355         [EFL] Enable IndexedDB by default
3356         https://bugs.webkit.org/show_bug.cgi?id=107248
3357
3358         Reviewed by Laszlo Gombos.
3359
3360         * Scripts/webkitperl/FeatureList.pm:
3361         Enable IndexedDB by default on EFL.
3362
3363 2013-03-26  Alan Cutter  <alancutter@chromium.org>
3364
3365         Sheriffbot should explain rollout failures in a human readable form.
3366         https://bugs.webkit.org/show_bug.cgi?id=107092
3367
3368         Reviewed by Ryosuke Niwa.
3369
3370         Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).
3371
3372         * Scripts/webkitpy/tool/bot/irc_command.py:
3373         (Rollout._check_diff_failure):
3374         (Rollout.execute):
3375         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3376         (IRCCommandTest.test_rollout):
3377
3378 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
3379
3380         Unreviewed GTK gardening.
3381
3382         * Scripts/run-gtk-tests:
3383         (TestRunner): Skipping a failing unit test after r146518.
3384
3385 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
3386
3387         Remove Lion leaks builder
3388         https://bugs.webkit.org/show_bug.cgi?id=113252
3389
3390         Reviewed by Andreas Kling.
3391
3392         Removed.
3393
3394         * BuildSlaveSupport/build.webkit.org-config/config.json:
3395
3396 2013-03-25  Kent Tamura  <tkent@chromium.org>
3397
3398         Rename ENABLE_INPUT_TYPE_DATETIME
3399         https://bugs.webkit.org/show_bug.cgi?id=113254
3400
3401         Reviewed by Kentaro Hara.
3402
3403         Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
3404         Actually I'd like to remove the code, but we shouldn't remove it yet
3405         because we shipped products with it on some platforms.
3406
3407         * Scripts/webkitperl/FeatureList.pm:
3408         * qmake/mkspecs/features/features.pri:
3409
3410 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
3411
3412         Remove one more line that was intended to be removed in r146657.
3413
3414         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3415         (summarize_results):
3416
3417 2013-03-25  Roger Fong  <roger_fong@apple.com>
3418
3419         No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
3420         Re-enable WinEWS tests.
3421
3422         * Scripts/webkitpy/common/config/ports.py:
3423         (WinPort.run_bindings_tests_command):
3424         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3425         (WinEWS):
3426
3427 2013-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>
3428
3429         Unreviewed, rolling out r146793.
3430         http://trac.webkit.org/changeset/146793
3431         https://bugs.webkit.org/show_bug.cgi?id=113248
3432
3433         Fix did not work (Requested by rfong on #webkit).
3434
3435         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3436         (WinEWS):
3437
3438 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
3439
3440         REGRESSION(r146657): Test failures reported incorrectly
3441         https://bugs.webkit.org/show_bug.cgi?id=113223
3442
3443         Reviewed by Dirk Pranke.
3444
3445         The bug was caused by BuildBotPrinter not taking the new behavior into account.
3446
3447         Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
3448         treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.
3449
3450         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3451         (Manager.run):
3452
3453         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3454         (RunDetails.__init__):
3455         (summarize_results): Remove the line I intended to remove in r146657.
3456
3457         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3458         (logging_run): Return details instead of the exit code.
3459         (run_and_capture): Ditto.
3460
3461         (RunTest.test_full_results_html):
3462         (RunTest.test_hung_thread):
3463         (RunTest.test_no_tests_found):
3464         (RunTest.test_no_tests_found_2):
3465         (RunTest.test_repeat_each_iterations_num_tests):
3466         (RunTest.test_run_singly_actually_runs_tests):
3467         (RunTest.test_test_list):
3468         (RunTest.test_missing_and_unexpected_results):
3469         (RunTest.test_pixel_test_directories):
3470         (RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
3471         (RunTest.test_crash_with_stderr):
3472         (RunTest.test_no_image_failure_with_image_diff):
3473         (RunTest.test_crash_log):
3474         (RunTest.test_exit_after_n_failures_upload):
3475         (RunTest.test_results_directory_absolute):
3476         (RunTest.test_results_directory_relative):
3477         (RunTest.test_retrying_and_flaky_tests):
3478         (RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
3479         (RunTest.test_retrying_uses_retries_directory):
3480         (RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
3481         (RunTest.test_output_diffs):
3482         (EndToEndTest.test_reftest_with_two_notrefs):
3483         (RebaselineTest.test_reset_results):
3484         (RebaselineTest.test_missing_results):
3485         (RebaselineTest.test_new_baseline):
3486
3487         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
3488         (BuildBotPrinter.print_results):
3489         (BuildBotPrinter.print_unexpected_results):
3490         (BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
3491         when we forced pixel tests in retry (i.e. pixel test was initially disabled).
3492
3493 2013-03-25  Julie Parent  <jparent@chromium.org>
3494
3495         Dashboard refactor: Move cross dashboard history related code into history.js.
3496         https://bugs.webkit.org/show_bug.cgi?id=113104
3497
3498         Reviewed by Ojan Vafai.
3499
3500         All functions relating to cross dashboard behavior move from being
3501         globals to methods on the history.History object. Names stay the same,
3502         except many are made private, ones that should have been constants now
3503         are, and the long standing TODO to change "currentState" to 
3504         dashboardSpecificState is done.
3505         
3506         We now create a global history object in dashboard_base, as an 
3507         intermediate measure.  Once the dashboard specific code is
3508         added to history, each DB will need to create its own, and this
3509         global will be eliminated.
3510         
3511         * TestResultServer/static-dashboards/aggregate_results.js:
3512         (handleValidHashParameter):
3513         (htmlForBuilder):
3514         (rawValuesHTML):
3515         * TestResultServer/static-dashboards/dashboard_base.js:
3516         (parseDashboardSpecificParameters):
3517         (defaultValue):
3518         (currentBuilderGroupCategory):
3519         (currentBuilderGroupName):
3520         (handleLocationChange):
3521         (expectationsMap):
3522         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3523         (generatePage):
3524         (.switch.return):
3525         (platformAndBuildType):
3526         (individualTests):
3527         (substringList):
3528         (processMissingAndExtraExpectations):
3529         (pathToFailureLog):
3530         (showPopupForBuild):
3531         (htmlForTestsWithExpectationsButNoFailures):
3532         (shouldHideTest):
3533         (isCrossBuilderView):
3534         (tableHeaders):
3535         (htmlForSingleTestRow):
3536         (htmlForTableColumnHeader):
3537         (generatePageForExpectationsUpdate):
3538         (handleUpdate):
3539         (nextUpdate):
3540         (setUpdateIndex):
3541         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
3542         (.appendExpectationsItem):
3543         (loadExpectations):
3544         (.dummyNode.onload):
3545         (loadExpectationsLayoutTests):
3546         (appendExpectations):
3547         (htmlForNavBar):
3548         (checkBoxToToggleState):
3549         (linkHTMLToToggleState):
3550         (generatePageForBuilder):
3551         (isInvalidKeyForCrossBuilderView):
3552         (handleQueryParameterChange):
3553         (showLegend):
3554         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3555         (resetGlobals):
3556         (test):
3557         * TestResultServer/static-dashboards/history.js:
3558         (.):
3559         * TestResultServer/static-dashboards/history_unittests.js:
3560         * TestResultServer/static-dashboards/loader.js:
3561         (.):
3562         * TestResultServer/static-dashboards/loader_unittests.js:
3563         * TestResultServer/static-dashboards/timeline_explorer.js:
3564         (generatePage):
3565         (initCurrentBuilderTestResults):
3566         (selectBuild):
3567         (showResultsDelta):
3568         * TestResultServer/static-dashboards/treemap.js:
3569         (generatePage):
3570         (.switch.return):
3571         (handleFocus):
3572         * TestResultServer/static-dashboards/ui.js:
3573
3574 2013-03-25  Roger Fong  <roger_fong@apple.com>
3575
3576         Unreviewed. Enable WinEWS tests again.
3577
3578         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3579         (WinEWS):
3580
3581 2013-03-25  Dominik Röttsches  <dominik.rottsches@intel.com>
3582
3583         [HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
3584         https://bugs.webkit.org/show_bug.cgi?id=112166
3585
3586         HarfBuzz 0.9.14 merged my patch for icu detection without
3587         pkg-config files, as needed by for example Ubuntu 12.04.
3588         This obsoletes our local workaround. Removed it for GTK and EFL.
3589
3590         Reviewed by Martin Robinson.
3591
3592         * efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
3593         * efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
3594         * gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
3595         * gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
3596
3597 2013-03-22  Kiran Muppala  <cmuppala@apple.com>
3598
3599         Unreviewed.  Move self from contributor to committer list.
3600
3601         * Scripts/webkitpy/common/config/committers.py:
3602
3603 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
3604
3605         EWS should use a human readable port name when uploading layout test archives
3606         https://bugs.webkit.org/show_bug.cgi?id=113099
3607
3608         Reviewed by Dirk Pranke.
3609
3610         Use new port's object's name() method to report human readable port names.
3611         This will also help us resolving the bug to apply layout test results posted by EWS.
3612
3613         * Scripts/webkitpy/tool/bot/botinfo.py:
3614         (BotInfo.__init__): Take port's name.
3615         (BotInfo.summary_text):
3616
3617         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
3618         (BotInfoTest.test_summary_text):
3619
3620         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3621         (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.
3622
3623         * Scripts/webkitpy/tool/commands/queues.py:
3624         (PatchProcessingQueue.__init__): Initialize self._port.
3625         (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
3626         and use that for the attachment filename and the comment posted.
3627
3628         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3629         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
3630         "mac-snowleopard" as expected for TestPort.
3631
3632 2013-03-22  Roger Fong  <roger_fong@apple.com>
3633
3634         Unreviewed. Turn off EWS test on Win again.
3635         The battle continues.
3636
3637         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3638         (WinEWS):
3639
3640 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
3641
3642         NRWT: Enable pixel tests when retrying tests
3643         https://bugs.webkit.org/show_bug.cgi?id=112898
3644
3645         Reviewed by Dirk Pranke.
3646
3647         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3648         (Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
3649         if we've forced pixel tests in the retry.
3650         (Manager._run_tests):
3651         (Manager._clean_up_run): Fixed the capitalizations.
3652         (Manager._force_pixel_tests_if_needed): Added.
3653
3654         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3655         (_interpret_test_failures): Now that this function maybe called multiple times, only set
3656         'image_diff_percent' if it doesn't already exist.
3657
3658         (summarize_results): When the first attempt resulted in a text failure and the second attempt
3659         resulted in image and text failures and we've forced to run pixel tests in the retry run,
3660         treat this as a regular regression instead of a flakiness.
3661
3662         Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
3663         run had image diffs.
3664
3665         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
3666         (summarized_results):
3667
3668         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3669         (parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
3670         Also removed some dead code.
3671
3672         (RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
3673         pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
3674         is set and pixel_tests_enabled is set to false.
3675         (EndToEndTest.test_reftest_with_two_notrefs):
3676
3677 2013-03-22  Tim Horton  <timothy_horton@apple.com>
3678
3679         Make it possible to run layout tests on Retina MBP
3680         https://bugs.webkit.org/show_bug.cgi?id=93673
3681
3682         Reviewed by Ryosuke Niwa.
3683
3684         Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
3685         windows on 2x machines still run at 1x.
3686
3687         * DumpRenderTree/mac/DumpRenderTree.mm:
3688         (createWebViewAndOffscreenWindow):
3689         Reset the window resolution to 1x on creation.